projects / deliverable / binutils-gdb.git / blame
| Commit | Line | Data |
|---|---|---|
| e63d1232 NC |
1 | 2017-04-26 Nick Clifton <nickc@redhat.com> |
| 2 | ||
| 3 | PR binutils/21431 | |
| 4 | * compress.c (bfd_init_section_compress_status): Check the return | |
| 5 | value from bfd_malloc. | |
| 6 | ||
| 9e9821dd L |
7 | 2017-04-24 H.J. Lu <hongjiu.lu@intel.com> |
| 8 | ||
| 9 | * elf64-x86-64.c (elf_x86_64_link_hash_entry): Add | |
| 10 | no_finish_dynamic_symbol. | |
| 11 | (elf_x86_64_link_hash_newfunc): Set no_finish_dynamic_symbol to | |
| 12 | 0. | |
| 13 | (elf_x86_64_allocate_dynrelocs): If a symbol isn't undefined | |
| 14 | weak symbol, don't make it dynamic. | |
| 15 | (elf_x86_64_relocate_section): If a symbol isn't dynamic in PIC, | |
| 16 | set no_finish_dynamic_symbol and generate R_X86_64_RELATIVE | |
| 17 | relocation for GOT reference. | |
| 18 | (elf_x86_64_finish_dynamic_symbol): Abort if | |
| 19 | no_finish_dynamic_symbol isn't 0. | |
| 20 | ||
| 0dc9a308 L |
21 | 2017-04-24 H.J. Lu <hongjiu.lu@intel.com> |
| 22 | ||
| 23 | PR ld/21402 | |
| 24 | * elf32-i386.c (elf_i386_allocate_dynrelocs): If a symbol isn't | |
| 25 | undefined weak symbol, don't make it dynamic. | |
| 26 | (elf_i386_relocate_section): If a symbol isn't dynamic in PIC, | |
| 27 | set no_finish_dynamic_symbol and generate R_386_RELATIVE | |
| 28 | relocation for R_386_GOT32. | |
| 29 | ||
| 1587442d L |
30 | 2017-04-24 H.J. Lu <hongjiu.lu@intel.com> |
| 31 | ||
| 32 | PR ld/21425 | |
| 33 | * elf32-i386.c (ELF_MAXPAGESIZE): Set to 0x1000 for VxWorks. | |
| 34 | ||
| 7eacd66b AM |
35 | 2017-04-23 Alan Modra <amodra@gmail.com> |
| 36 | ||
| 37 | PR 21414 | |
| 38 | * section.c (GLOBAL_SYM_INIT): Make available in bfd.h. | |
| 39 | * elf.c (lcomm_sym): New. | |
| 40 | (_bfd_elf_large_com_section): Use lcomm_sym section symbol. | |
| 41 | * bfd-in2.h: Regenerate. | |
| 42 | ||
| bce964aa AM |
43 | 2017-04-23 Alan Modra <amodra@gmail.com> |
| 44 | ||
| 45 | PR 21412 | |
| 46 | * elf-bfd.h (struct elf_backend_data <get_reloc_section>): Change | |
| 47 | parameters and comment. | |
| 48 | (_bfd_elf_get_reloc_section): Delete. | |
| 49 | (_bfd_elf_plt_get_reloc_section): Declare. | |
| 50 | * elf.c (_bfd_elf_plt_get_reloc_section, elf_get_reloc_section): | |
| 51 | New functions. Don't blindly skip over assumed .rel/.rela prefix. | |
| 52 | Extracted from.. | |
| 53 | (_bfd_elf_get_reloc_section): ..here. Delete. | |
| 54 | (assign_section_numbers): Call elf_get_reloc_section. | |
| 55 | * elf64-ppc.c (elf_backend_get_reloc_section): Define. | |
| 56 | * elfxx-target.h (elf_backend_get_reloc_section): Update. | |
| 57 | ||
| 97e83a10 AM |
58 | 2017-04-23 Alan Modra <amodra@gmail.com> |
| 59 | ||
| 60 | PR 21409 | |
| 61 | * dwarf2.c (_bfd_dwarf2_find_nearest_line): Don't segfault when | |
| 62 | no symbols. | |
| 63 | ||
| e133d005 L |
64 | 2017-04-21 H.J. Lu <hongjiu.lu@intel.com> |
| 65 | ||
| 66 | PR ld/21402 | |
| 67 | * elf32-i386.c (elf_i386_link_hash_entry): Add | |
| 68 | no_finish_dynamic_symbol. | |
| 69 | (elf_i386_link_hash_newfunc): Set no_finish_dynamic_symbol to 0. | |
| 70 | (elf_i386_allocate_dynrelocs): If a symbol isn't undefined weak | |
| 71 | symbol, don't make it dynamic in PIE. | |
| 72 | (elf_i386_relocate_section): If a symbol isn't dynamic in PIE, | |
| 73 | set no_finish_dynamic_symbol and generate R_386_RELATIVE | |
| 74 | relocation for R_386_GOT32 | |
| 75 | (elf_i386_finish_dynamic_symbol): Abort if no_finish_dynamic_symbol | |
| 76 | isn't 0. | |
| 77 | ||
| 3c5fce9b L |
78 | 2017-04-21 H.J. Lu <hongjiu.lu@intel.com> |
| 79 | ||
| 80 | PR ld/19617 | |
| 81 | PR ld/21086 | |
| 82 | * elflink.c (elf_link_add_object_symbols): Require | |
| 83 | --no-dynamic-linker with -E/--dynamic-list when creating | |
| 84 | dynamic sections. | |
| 85 | ||
| 0fad2956 MR |
86 | 2017-04-20 Maciej W. Rozycki <macro@imgtec.com> |
| 87 | ||
| 88 | * elflink.c (_bfd_elf_symbol_refs_local_p): Always return TRUE | |
| 89 | if forced local. | |
| 90 | ||
| 64575f78 MR |
91 | 2017-04-20 Maciej W. Rozycki <macro@imgtec.com> |
| 92 | ||
| 93 | * elfxx-mips.c (_bfd_mips_elf_final_link): Reorder comment about | |
| 94 | dynamic symbol sorting. | |
| 95 | ||
| 59fa66c5 L |
96 | 2017-04-20 H.J. Lu <hongjiu.lu@intel.com> |
| 97 | ||
| 98 | PR ld/21382 | |
| 99 | * elflink.c (elf_link_add_object_symbols): Preserve | |
| 100 | dynamic_ref_after_ir_def when restoring the symbol table for | |
| 101 | unneeded dynamic object. | |
| 102 | ||
| e492d2f8 L |
103 | 2017-04-19 H.J. Lu <hongjiu.lu@intel.com> |
| 104 | ||
| 105 | PR ld/21401 | |
| 106 | * elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Don't abort | |
| 107 | on on undefined IFUNC symbol in the second PLT. | |
| 108 | ||
| 10169134 WAF |
109 | 2017-04-19 Wedson Almeida Filho <wedsonaf@gmail.com> |
| 110 | ||
| 111 | * peXXigen.c (pe_print_reloc): Correct chunk_end. | |
| 112 | ||
| 954b63d4 AM |
113 | 2017-04-19 Alan Modra <amodra@gmail.com> |
| 114 | ||
| 115 | * elflink.c (_bfd_elf_adjust_dynamic_symbol): Hide undefweak | |
| 116 | or make dynamic for info->dynamic_undefined_weak 0 and 1. | |
| 117 | * elf32-ppc.c:Formatting. | |
| 118 | (ensure_undefweak_dynamic): Don't make dynamic when | |
| 119 | info->dynamic_undefined_weak is zero. | |
| 120 | (allocate_dynrelocs): Discard undefweak dyn_relocs for | |
| 121 | info->dynamic_undefined_weak. Discard undef dyn_relocs when | |
| 122 | not default visibility. Discard undef and undefweak | |
| 123 | dyn_relocs earlier. | |
| 124 | (ppc_elf_relocate_section): Adjust to suit. | |
| 125 | * elf64-ppc.c: Formatting. | |
| 126 | (ensure_undefweak_dynamic): Don't make dynamic when | |
| 127 | info->dynamic_undefined_weak is zero. | |
| 128 | (allocate_dynrelocs): Discard undefweak dyn_relocs for | |
| 129 | info->dynamic_undefined_weak. Discard them earlier. | |
| 130 | ||
| e6699019 L |
131 | 2017-04-17 H.J. Lu <hongjiu.lu@intel.com> |
| 132 | ||
| 133 | PR ld/21389 | |
| 134 | * elflink.c (bfd_elf_size_dynamic_sections): Get soname index | |
| 135 | before generating the version definition section. | |
| 136 | ||
| c5d37467 AM |
137 | 2017-04-17 Alan Modra <amodra@gmail.com> |
| 138 | ||
| 139 | * elflink.c (_bfd_elf_merge_symbol): Undo dynamic linking | |
| 140 | state when a regular object file defines a symbol with | |
| 141 | incompatible type to that defined by an earlier shared lib. | |
| 142 | ||
| 63a5468a AM |
143 | 2017-04-13 Alan Modra <amodra@gmail.com> |
| 144 | ||
| 145 | * coffcode.h: Wrap some overly long _bfd_error_handler args. | |
| 146 | * elf.c: Likewise. | |
| 147 | * elf32-arm.c: Likewise. | |
| 148 | * elf32-i386.c: Likewise. | |
| 149 | * elf32-mep.c: Likewise. | |
| 150 | * elf64-ia64-vms.c: Likewise. | |
| 151 | * elf64-x86-64.c: Likewise. | |
| 152 | * elflink.c: Likewise. | |
| 153 | * elfnn-ia64.c: Likewise. | |
| 154 | * elfxx-mips.c: Likewise. | |
| 155 | ||
| dae82561 AM |
156 | 2017-04-13 Alan Modra <amodra@gmail.com> |
| 157 | ||
| 158 | * aoutx.h: Use %B and %A in error messages throughout file. | |
| 159 | * aout-cris.c: Likewise. | |
| 160 | * archive.c: Likewise. | |
| 161 | * binary.c: Likewise. | |
| 162 | * coff-rs6000.c: Likewise. | |
| 163 | * coff-tic4x.c: Likewise. | |
| 164 | * coffcode.h: Likewise. | |
| 165 | * coffgen.c: Likewise. | |
| 166 | * cofflink.c: Likewise. | |
| 167 | * coffswap.h: Likewise. | |
| 168 | * cpu-arm.c: Likewise. | |
| 169 | * elf-eh-frame.c: Likewise. | |
| 170 | * elf-m10300.c: Likewise. | |
| 171 | * elf.c: Likewise. | |
| 172 | * elf32-arc.c: Likewise. | |
| 173 | * elf32-arm.c: Likewise. | |
| 174 | * elf32-bfin.c: Likewise. | |
| 175 | * elf32-frv.c: Likewise. | |
| 176 | * elf32-iq2000.c: Likewise. | |
| 177 | * elf32-m32c.c: Likewise. | |
| 178 | * elf32-microblaze.c: Likewise. | |
| 179 | * elf32-nds32.c: Likewise. | |
| 180 | * elf32-rl78.c: Likewise. | |
| 181 | * elf32-rx.c: Likewise. | |
| 182 | * elf32-score.c: Likewise. | |
| 183 | * elf32-score7.c: Likewise. | |
| 184 | * elf32-sh64.c: Likewise. | |
| 185 | * elf32-v850.c: Likewise. | |
| 186 | * elf32-vax.c: Likewise. | |
| 187 | * elf32-visium.c: Likewise. | |
| 188 | * elf64-ia64-vms.c: Likewise. | |
| 189 | * elf64-mmix.c: Likewise. | |
| 190 | * elf64-sh64.c: Likewise. | |
| 191 | * elfcode.h: Likewise. | |
| 192 | * elfnn-aarch64.c: Likewise. | |
| 193 | * elfnn-ia64.c: Likewise. | |
| 194 | * elfxx-mips.c: Likewise. | |
| 195 | * hpux-core.c: Likewise. | |
| 196 | * ieee.c: Likewise. | |
| 197 | * ihex.c: Likewise. | |
| 198 | * linker.c: Likewise. | |
| 199 | * merge.c: Likewise. | |
| 200 | * mmo.c: Likewise. | |
| 201 | * oasys.c: Likewise. | |
| 202 | * pdp11.c: Likewise. | |
| 203 | * peXXigen.c: Likewise. | |
| 204 | * rs6000-core.c: Likewise. | |
| 205 | * vms-alpha.c: Likewise. | |
| 206 | * xcofflink.c: Likewise. | |
| 207 | ||
| c08bb8dd AM |
208 | 2017-04-13 Alan Modra <amodra@gmail.com> |
| 209 | ||
| 210 | * bfd.c (PRINT_TYPE): Define. | |
| 211 | (_doprnt): New function. | |
| 212 | (error_handler_internal): Use _doprnt. | |
| 213 | * coff-arm.c: Put %A and %B arguments to _bfd_error_handler | |
| 214 | calls in their natural order, throughout file. | |
| 215 | * coff-mcore.c: Likewise. | |
| 216 | * coff-ppc.c: Likewise. | |
| 217 | * coff-tic80.c: Likewise. | |
| 218 | * cofflink.c: Likewise. | |
| 219 | * elf-s390-common.c: Likewise. | |
| 220 | * elf.c: Likewise. | |
| 221 | * elf32-arm.c: Likewise. | |
| 222 | * elf32-i386.c: Likewise. | |
| 223 | * elf32-m32r.c: Likewise. | |
| 224 | * elf32-msp430.c: Likewise. | |
| 225 | * elf32-spu.c: Likewise. | |
| 226 | * elf64-ia64-vms.c: Likewise. | |
| 227 | * elf64-sparc.c: Likewise. | |
| 228 | * elf64-x86-64.c: Likewise. | |
| 229 | * elflink.c: Likewise. | |
| 230 | * elfnn-aarch64.c: Likewise. | |
| 231 | * elfnn-ia64.c: Likewise. | |
| 232 | * elfxx-mips.c: Likewise. | |
| 233 | ||
| 10463f39 AM |
234 | 2017-04-13 Alan Modra <amodra@gmail.com> |
| 235 | ||
| 236 | * elf32-arm.c (arm_type_of_stub): Supply missing args to "long | |
| 237 | branch veneers" error. Fix double space and format message. | |
| 238 | * elf32-avr.c (avr_add_stub): Do not pass NULL as %B arg. | |
| 239 | * elf64-ppc.c (tocsave_find): Supply missing %B arg. | |
| 240 | ||
| 4af8774e AM |
241 | 2017-04-13 Alan Modra <amodra@gmail.com> |
| 242 | ||
| 243 | * bfd-in2.h: Regenerate. | |
| 244 | ||
| e4097f5e L |
245 | 2017-04-11 H.J. Lu <hongjiu.lu@intel.com> |
| 246 | ||
| 247 | * elf-properties.c (_bfd_elf_parse_gnu_properties): Remove the | |
| 248 | extra `\n' in warning/error messages. | |
| 249 | * elf32-i386.c (elf_i386_parse_gnu_properties): Likewise. | |
| 250 | * elf64-x86-64.c (elf_x86_64_parse_gnu_properties): Likewise. | |
| 251 | ||
| 537616aa L |
252 | 2017-04-11 H.J. Lu <hongjiu.lu@intel.com> |
| 253 | ||
| 254 | * elf-properties.c (_bfd_elf_parse_gnu_properties): Ignore | |
| 255 | processor-specific properties with generic ELF target vector. | |
| 256 | ||
| bb1dd176 QZ |
257 | 2017-04-10 Qing Zhao <qing.zhao@oracle.com> |
| 258 | ||
| 259 | * elf32-sparc.c (elf_backend_fixup_symbol): New. | |
| 260 | * elf64-sparc.c (elf_backend_fixup_symbol): New. | |
| 261 | * elfxx-sparc.c (UNDEFINED_WEAK_RESOLVED_TO_ZERO): New. | |
| 262 | (_bfd_sparc_elf_link_hash_entry): Add has_got_reloc and | |
| 263 | has_non_got_reloc. | |
| 264 | (link_hash_newfunc): Initialize has_got_reloc and | |
| 265 | has_non_got_reloc. | |
| 266 | (_bfd_sparc_elf_size_dynamic_sections): Set interp to .interp | |
| 267 | section. | |
| 268 | (_bfd_sparc_elf_copy_indirect_symbol): Copy has_got_reloc and | |
| 269 | has_non_got_reloc. | |
| 270 | (_bfd_sparc_elf_check_relocs): Set has_got_reloc and | |
| 271 | has_non_got_reloc. | |
| 272 | (_bfd_sparc_elf_fixup_symbol): New function. | |
| 273 | (allocate_dynrelocs): Don't allocate space for dynamic | |
| 274 | relocations and discard relocations against resolved undefined | |
| 275 | weak symbols in executable. Don't make resolved undefined weak | |
| 276 | symbols in executable dynamic. Keep dynamic non-GOT/non-PLT | |
| 277 | relocation against undefined weak symbols in PIE. | |
| 278 | (_bfd_sparc_elf_relocate_section): Don't generate dynamic | |
| 279 | relocations against resolved undefined weak symbols in PIE | |
| 280 | (_bfd_sparc_elf_finish_dynamic_symbol): Keep PLT/GOT entries | |
| 281 | without ynamic PLT/GOT relocations for resolved undefined weak | |
| 282 | symbols. | |
| 283 | Don't generate dynamic relocation against resolved undefined | |
| 284 | weak symbol in executable. | |
| 285 | (pie_finish_undefweak_symbol): New function. | |
| 286 | (_bfd_sparc_elf_finish_dynamic_sections): Call | |
| 287 | pie_finish_undefweak_symbol on all symbols in PIE. | |
| 288 | * elfxx-sparc.h (_bfd_sparc_elf_link_hash_table): Add interp. | |
| 289 | (_bfd_sparc_elf_fixup_symbol): New function. | |
| 290 | ||
| d236cfd4 NC |
291 | 2017-04-10 Nick Clifton <nickc@redhat.com> |
| 292 | ||
| 293 | * config.bfd: Remove ns32k from obsolete list. | |
| 294 | ||
| 6f9dbcd4 AM |
295 | 2017-04-10 Alan Modra <amodra@gmail.com> |
| 296 | ||
| 297 | PR 21287 | |
| 298 | * elf.c (special_sections_f): Match .fini_array and .fini_array.*. | |
| 299 | (special_sections_i): Likewise for .init_array. | |
| 300 | (special_sections_p): Likewise for .preinit_array. | |
| 301 | ||
| 8170f769 L |
302 | 2017-04-07 H.J. Lu <hongjiu.lu@intel.com> |
| 303 | ||
| 304 | PR ld/19579 | |
| 305 | PR ld/21306 | |
| 306 | * elf32-s390.c (elf_s390_finish_dynamic_symbol): Check | |
| 307 | ELF_COMMON_DEF_P for common symbols. | |
| 308 | * elf64-s390.c (elf_s390_finish_dynamic_symbol): Likewise. | |
| 309 | * elf64-x86-64.c (elf_x86_64_relocate_section): Likewise. | |
| 310 | * elflink.c (_bfd_elf_merge_symbol): Revert commits | |
| 311 | 202ac193bbbecc96a4978d1ac3d17148253f9b01 and | |
| 312 | 07492f668d2173da7a2bda3707ff0985e0f460b6. | |
| 313 | ||
| 49f4617b PA |
314 | 2017-04-07 Pedro Alves <palves@redhat.com> |
| 315 | ||
| 316 | * opncls.c (bfd_get_debug_link_info): Rename to... | |
| 317 | (bfd_get_debug_link_info_1): ... this. Change type of second | |
| 318 | parameter to void pointer. Adjust. | |
| 319 | (bfd_get_debug_link_info): Reimplement on top of | |
| 320 | bfd_get_debug_link_info_1. | |
| 321 | (separate_debug_file_exists, separate_alt_debug_file_exists): | |
| 322 | Change type of second parameter to void pointer. Adjust. | |
| 323 | (get_func_type, check_func_type): Change type of second parameter | |
| 324 | to void pointer. | |
| 325 | (find_separate_debug_file): Add 'func_data' parameter. Pass it to | |
| 326 | the callback functions instead of passing the address of a local. | |
| 327 | (bfd_follow_gnu_debuglink): Pass address of unsigned long local to | |
| 328 | find_separate_debug_file. | |
| 329 | (get_alt_debug_link_info_shim): Change type of second parameter to | |
| 330 | void pointer. Adjust. | |
| 331 | (bfd_follow_gnu_debugaltlink): Adjust to pass NULL to | |
| 332 | find_separate_debug_file. | |
| 333 | (get_build_id_name, bfd_boolean check_build_id_file): Change type | |
| 334 | of second parameter to void pointer. Adjust. | |
| 335 | (bfd_follow_build_id_debuglink): Pass address of bfd_build_id | |
| 336 | pointer local to find_separate_debug_file. | |
| 337 | ||
| 338 | 2017-04-07 Tristan Gingold <gingold@gingold-Precision-7510> | |
| 1fd6d111 TG |
339 | |
| 340 | * coffgen.c (_bfd_coff_gc_mark_hook): Handle PE weak | |
| 341 | external symbols with a definition. | |
| 342 | (_bfd_coff_gc_mark_extra_sections): Fix typo. | |
| 343 | ||
| 86abf93a AM |
344 | 2017-04-07 Alan Modra <amodra@gmail.com> |
| 345 | ||
| 346 | * po/SRC-POTFILES.in: Regenerate. | |
| 347 | ||
| 8dea77f0 AM |
348 | 2017-04-05 Alan Modra <amodra@gmail.com> |
| 349 | ||
| 350 | * elf64-ppc.c (ppc64_elf_gc_sweep_hook): Support ELFv2 PLT | |
| 351 | reference counting. | |
| 352 | ||
| 477bdd39 JT |
353 | 2017-04-02 Jon Turney <jon.turney@dronecode.org.uk> |
| 354 | ||
| 355 | (_bfd_XXi_swap_aouthdr_out): For clarity, use defines rather than | |
| 356 | numbers for DataDirectory entry indicies passed to | |
| 357 | add_data_entry(). | |
| 358 | ||
| a91e1603 L |
359 | 2017-04-04 H.J. Lu <hongjiu.lu@intel.com> |
| 360 | ||
| 361 | * elf.c (get_program_header_size): Add a GNU_MBIND segment for | |
| 362 | each GNU_MBIND section and align GNU_MBIND section to page size. | |
| 363 | (_bfd_elf_map_sections_to_segments): Create a GNU_MBIND | |
| 364 | segment for each GNU_MBIND section. | |
| 365 | (_bfd_elf_init_private_section_data): Copy sh_info from input | |
| 366 | for GNU_MBIND section. | |
| 367 | ||
| b5292032 PD |
368 | 2017-04-03 Palmer Dabbelt <palmer@dabbelt.com> |
| 369 | ||
| 370 | * elfnn-riscv.c (GP_NAME): Delete. | |
| 371 | (riscv_global_pointer_value): Change GP_NAME to RISCV_GP_SYMBOL. | |
| 372 | (_bfd_riscv_relax_lui): Likewise. | |
| 373 | ||
| ad32986f NC |
374 | 2017-04-04 Nick Clifton <nickc@redhat.com> |
| 375 | ||
| 376 | PR binutils/21342 | |
| 377 | * elflink.c (_bfd_elf_define_linkage_sym): Prevent null pointer | |
| 378 | dereference. | |
| 379 | (bfd_elf_final_link): Only initialize the extended symbol index | |
| 380 | section if there are extended symbol tables to list. | |
| 381 | ||
| 46bed679 L |
382 | 2017-04-03 H.J. Lu <hongjiu.lu@intel.com> |
| 383 | ||
| 384 | * Makefile.am (BFD32_BACKENDS): Add elf-properties.lo. | |
| 385 | (BFD32_BACKENDS_CFILES): Add elf-properties.c. | |
| 386 | * configure.ac (elf): Add elf-properties.lo. | |
| 387 | * Makefile.in: Regenerated. | |
| 388 | * configure: Likewise. | |
| 389 | * elf-bfd.h (elf_property_kind): New. | |
| 390 | (elf_property): Likewise. | |
| 391 | (elf_property_list): Likewise. | |
| 392 | (elf_properties): Likewise. | |
| 393 | (_bfd_elf_parse_gnu_properties): Likewise. | |
| 394 | (_bfd_elf_get_property): Likewise. | |
| 395 | (_bfd_elf_link_setup_gnu_properties): Likewise. | |
| 396 | (elf_backend_data): Add parse_gnu_properties, merge_gnu_properties | |
| 397 | and setup_gnu_properties. | |
| 398 | (elf_obj_tdata): Add properties. | |
| 399 | * elf-properties.c: New file. | |
| 400 | * elf32-i386.c (elf_i386_parse_gnu_properties): New. | |
| 401 | (elf_i386_merge_gnu_properties): Likewise. | |
| 402 | (elf_backend_parse_gnu_properties): Likewise. | |
| 403 | (elf_backend_merge_gnu_properties): Likewise. | |
| 404 | * elf64-x86-64.c (elf_x86_64_parse_gnu_properties): Likewise. | |
| 405 | (elf_x86_64_merge_gnu_properties): Likewise. | |
| 406 | (elf_backend_parse_gnu_properties): Likewise. | |
| 407 | (elf_backend_merge_gnu_properties): Likewise. | |
| 408 | * elfxx-target.h (elf_backend_merge_gnu_properties): Likewise. | |
| 409 | (elf_backend_parse_gnu_properties): Likewise. | |
| 410 | (elf_backend_setup_gnu_properties): Likewise. | |
| 411 | (elfNN_bed): Add elf_backend_parse_gnu_properties, | |
| 412 | elf_backend_merge_gnu_properties and | |
| 413 | elf_backend_setup_gnu_properties. | |
| 414 | ||
| f96bd6c2 PC |
415 | 2017-03-30 Pip Cet <pipcet@gmail.com> |
| 416 | ||
| 417 | * elf32-wasm32.c: Add relocation code, two relocs. | |
| 418 | * reloc.c: Add wasm32 relocations. | |
| 419 | * libbfd.h: Regenerate. | |
| 420 | * bfd-in2.h: Regenerate. | |
| 421 | * bfd/po/bfd.pot: Regenerate. | |
| 422 | ||
| e643cb45 NC |
423 | 2017-03-29 Nick Clifton <nickc@redhat.com> |
| 424 | ||
| 425 | PR binutils/18025 | |
| 426 | * coff-bfd.h (struct coff_section_data): Add new fields: | |
| 427 | saved_bias and bias. | |
| 428 | * coffgen.c (coff_find_nearest_line_with_names): Cache the bias | |
| 429 | computed for PE binaries. | |
| 430 | * dwarf2.c (scan_unit_for_symbols): Only warn once about each | |
| 431 | missing abbrev. | |
| 432 | ||
| 086554e8 HPN |
433 | 2017-03-28 Hans-Peter Nilsson <hp@axis.com> |
| 434 | ||
| 435 | PR ld/16044 | |
| 436 | * elf32-cris.c (elf_cris_adjust_gotplt_to_got): Adjust BFD_ASSERT | |
| 437 | to handle a local symbol with a hash-symbol-entry; without PLT. | |
| 438 | Add BFD_ASSERT for an incidental case with GOT entry present. | |
| 439 | (cris_elf_check_relocs): Increment PLT refcount only if the symbol | |
| 440 | isn't forced-or-set local. | |
| 441 | ||
| a6be0538 PC |
442 | 2017-03-27 Pip Cet <pipcet@gmail.com> |
| 443 | ||
| 444 | * wasm-module.c: New file to support WebAssembly modules. | |
| 445 | * wasm-module.h: New file to support WebAssembly modules. | |
| 446 | * doc/webassembly.texi: Start documenting wasm-module.c. | |
| 447 | * config.bfd: Add wasm_vec. | |
| 448 | * targets.c: Likewise. | |
| 449 | * configure.ac: Likewise. | |
| 450 | * Makefile.am: Add entries for wasm-module.c. | |
| 451 | * Makefile.in: Regenerate. | |
| 452 | * configure: Regenerate. | |
| 453 | * po/SRC-POTFILES.in: Regenerate. | |
| 454 | ||
| 79b1d3cb PC |
455 | 2017-03-27 Pip Cet <pipcet@gmail.com> |
| 456 | ||
| 457 | * cpu-wasm32.c: New file to support wasm32 architecture. | |
| 458 | * elf32-wasm32.c: New file to support wasm32 architecture. | |
| 459 | * Makefile.am: Add wasm32 architecture. | |
| 460 | * archures.c: Likewise. | |
| 461 | * config.bfd: Likewise. | |
| 462 | * configure.ac: Likewise. | |
| 463 | * targets.c: Likewise. | |
| 464 | * Makefile.in: Regenerate. | |
| 465 | * bfd-in2.h: Regenerate. | |
| 466 | * configure: Regenerate. | |
| 467 | * po/SRC-POTFILES.in: Regenerate. | |
| 468 | ||
| aaed6f5b AM |
469 | 2017-03-20 Alan Modra <amodra@gmail.com> |
| 470 | ||
| 471 | PR 21266 | |
| 472 | * elf64-ppc.c (compare_symbols): Stabilize sort. | |
| 473 | ||
| 82e66161 AM |
474 | 2017-03-18 Alan Modra <amodra@gmail.com> |
| 475 | ||
| 476 | * elf64-ppc.c (struct ppc_link_hash_table): Add | |
| 477 | local_ifunc_resolver and maybe_local_ifunc_resolver. | |
| 478 | (ppc_build_one_stub): Set flags on emitting dynamic | |
| 479 | relocation to ifunc. | |
| 480 | (ppc64_elf_relocate_section): Likewise. | |
| 481 | (ppc64_elf_finish_dynamic_symbol): Likewise. | |
| 482 | (ppc64_elf_finish_dynamic_sections): Error on DT_TEXTREL with | |
| 483 | local dynamic relocs to ifuncs. | |
| 484 | * elf32-ppc.c (struct ppc_elf_link_hash_table): Add | |
| 485 | local_ifunc_resolver and maybe_local_ifunc_resolver. | |
| 486 | (ppc_elf_relocate_section): Set flag on emitting dynamic | |
| 487 | relocation to ifuncs. | |
| 488 | (ppc_elf_finish_dynamic_symbol): Likewise. | |
| 489 | (ppc_elf_finish_dynamic_sections): Error on DT_TEXTREL with local | |
| 490 | dynamic relocs to ifuncs. | |
| 491 | ||
| f955cccf NC |
492 | 2017-03-13 Nick Clifton <nickc@redhat.com> |
| 493 | ||
| 494 | PR binutils/21202 | |
| 495 | * reloc.c (BFD_RELOC_AARCH64_TLSDESC_LD64_LO12_NC): Rename to | |
| 496 | BFD_RELOC_AARCH64_TLSDESC_LD64_LO12. | |
| 497 | (BFD_RELOC_AARCH64_TLSDESC_ADD_LO12_NC): Rename to | |
| 498 | BFD_RELOC_AARCH64_TLSDESC_ADD_LO12. | |
| 499 | * bfd-in2.h: Regenerate. | |
| 500 | * libbfd.h: Regenerate. | |
| 501 | * elfnn-aarch64.c (IS_AARCH64_TLS_RELAX_RELOC): Update reloc | |
| 502 | names. | |
| 503 | (IS_AARCH64_TLSDESC_RELOC): Likewise. | |
| 504 | (elfNN_aarch64_howto_table): Likewise. | |
| 505 | (aarch64_tls_transition_without_check): Likewise. | |
| 506 | (aarch64_reloc_got_type): Likewise. | |
| 507 | (elfNN_aarch64_final_link_relocate): Likewise. | |
| 508 | (elfNN_aarch64_tls_relax): Likewise. | |
| 509 | (elfNN_aarch64_relocate_section): Likewise. | |
| 510 | (elfNN_aarch64_gc_sweep_hook): Likewise. | |
| 511 | (elfNN_aarch64_check_relocs): Likewise. | |
| 512 | * elfxx-aarch64.c (_bfd_aarch64_elf_put_addend): Likewise. | |
| 513 | (_bfd_aarch64_elf_resolve_relocation): Likewise. | |
| 514 | ||
| 4aef7643 AM |
515 | 2017-03-11 Alan Modra <amodra@gmail.com> |
| 516 | ||
| 517 | * elf32-ppc.c: Remove ATTRIBUTE_UNUSED throughout when function | |
| 518 | parameter is in fact used. Whitespace fixes. | |
| 519 | * elf64-ppc.c: Likewise. | |
| 520 | ||
| f03265d9 ST |
521 | 2017-03-09 Sam Thursfield <sam.thursfield@codethink.co.uk> |
| 522 | ||
| 523 | * rs6000-core.c (CORE_NEW): Simplify macro when | |
| 524 | AIX_CORE_DUMPX_CORE and BFD64 are true to avoid compile warning. | |
| 525 | ||
| b1b07054 AM |
526 | 2017-03-07 Alan Modra <amodra@gmail.com> |
| 527 | ||
| 528 | PR 21224 | |
| 529 | PR 20519 | |
| 530 | * elf64-ppc.c (ppc64_elf_relocate_section): Add missing | |
| 531 | dyn_relocs check. | |
| 532 | ||
| 2e0ce1c8 AM |
533 | 2017-03-05 Alan Modra <amodra@gmail.com> |
| 534 | ||
| 535 | * elf-bfd.h (struct eh_cie_fde): Add u.cie.per_encoding_aligned8. | |
| 536 | * elf-eh-frame.c (size_of_output_cie_fde): Don't align here. | |
| 537 | (next_cie_fde_offset): New function. | |
| 538 | (_bfd_elf_parse_eh_frame): Set u.cie.per_encoding_aligned8. | |
| 539 | (_bfd_elf_discard_section_eh_frame): Align zero terminator to | |
| 540 | four bytes. Align CIEs to four or eight bytes depending on | |
| 541 | per_encoding_aligned8. Align FDEs according to their encoding. | |
| 542 | Pad last FDE to output section alignment. | |
| 543 | (_bfd_elf_write_section_eh_frame): Adjust to suit. Remove | |
| 544 | assertion. | |
| 545 | * elf64-ppc.c (glink_eh_frame_cie): Delete padding. | |
| 546 | (ppc64_elf_size_stubs): Pad glink eh_frame as per elf-eh-frame.c. | |
| 547 | (ppc64_elf_finish_dynamic_sections): Adjust to suit. | |
| 548 | ||
| f98450c6 NC |
549 | 2017-03-02 Martin Bickel <binutils@ineranves.de> |
| 550 | ||
| 551 | PR ld/21212 | |
| 552 | * elf.c (rewrite_elf_program_header): Do not issue a warning for | |
| d20928fa | 553 | empty segments which have a zero filesz, but a non-zero memsz. |
| f98450c6 | 554 | |
| 673cff9b AM |
555 | 2017-03-02 Alan Modra <amodra@gmail.com> |
| 556 | ||
| 557 | * elf32-ppc.c (ppc_elf_vle_split16): Correct insn mask typo. | |
| 558 | ||
| 3de43e7b AM |
559 | 2017-02-28 Alan Modra <amodra@gmail.com> |
| 560 | ||
| 561 | * elf64-ppc.c (ppc64_elf_ha_reloc): Revert last change. | |
| 562 | (ppc64_elf_relocate_section): Likewise. | |
| 563 | ||
| 4ef97a1b AM |
564 | 2017-02-28 Alan Modra <amodra@gmail.com> |
| 565 | ||
| 566 | PR 20995 | |
| 567 | * elf32-nios2.c (nios2_elf32_relocate_section): Use htab | |
| 568 | rather than elf32_nios2_hash_table or elf_hash_table. | |
| 569 | (create_got_section): Likewise. | |
| 570 | (nios2_elf32_finish_dynamic_symbol): Likewise. | |
| 571 | (nios2_elf32_adjust_dynamic_symbol): Likewise. | |
| 572 | (nios2_elf32_size_dynamic_sections): Likewise. | |
| 573 | (nios2_elf32_check_relocs): Delete dynobj, sgot, and srelgot | |
| 574 | vars. Use htab equivalents directly instead. Don't create | |
| 575 | all dynamic sections on needing just the GOT. Use a goto | |
| 576 | rather than a fall-through with reloc test. Ensure | |
| 577 | htab->dynobj is set when making dynamic sreloc section. | |
| 578 | (nios2_elf32_finish_dynamic_sections): Delete dynobj, use htab | |
| 579 | equivalent directly instead. Don't segfault on looking for | |
| 580 | .dynamic when dynamic sections have not been created. Don't | |
| 581 | segfault on .got.plt being discarded. | |
| 582 | (nios2_elf32_size_dynamic_sections): Delete plt and got vars. | |
| 583 | Don't set "relocs" on .rela.plt. Do handle .sbss. Delete | |
| 584 | fixme and another not so relevant comment. | |
| 585 | (nios2_elf_add_symbol_hook): Delete dynobj var. If not | |
| 586 | already set, set hash table dynobj on creating .sbss. | |
| 587 | ||
| 7ba71655 AM |
588 | 2017-02-28 Alan Modra <amodra@gmail.com> |
| 589 | ||
| 590 | * reloc.c (BFD_RELOC_PPC_16DX_HA): New. | |
| 591 | * elf64-ppc.c (ppc64_elf_howto_raw <R_PPC64_16DX_HA>): New howto. | |
| 592 | (ppc64_elf_reloc_type_lookup): Translate new bfd reloc. | |
| 593 | (ppc64_elf_ha_reloc): Correct overflow test on REL16DX_HA. | |
| 594 | (ppc64_elf_relocate_section): Likewise. | |
| 595 | * elf32-ppc.c (ppc_elf_howto_raw <R_PPC_16DX_HA>): New howto. | |
| 596 | (ppc_elf_reloc_type_lookup): Translate new bfd reloc. | |
| 597 | (ppc_elf_check_relocs): Handle R_PPC_16DX_HA to pacify gcc. | |
| 598 | * libbfd.h: Regenerate. | |
| 599 | * bfd-in2.h: Regenerate. | |
| 600 | ||
| afbf7e8e AM |
601 | 2017-02-28 Alan Modra <amodra@gmail.com> |
| 602 | ||
| 603 | * elflink.c (_bfd_elf_create_dynamic_sections): Don't make | |
| 604 | dynamic .data.rel.ro read-only. | |
| 605 | * elf32-arm.c (elf32_arm_finish_dynamic_symbol): Compare section | |
| 606 | rather than section flags when deciding where copy reloc goes. | |
| 607 | * elf32-cris.c (elf_cris_finish_dynamic_symbol): Likewise. | |
| 608 | * elf32-hppa.c (elf32_hppa_finish_dynamic_symbol): Likewise. | |
| 609 | * elf32-i386.c (elf_i386_finish_dynamic_symbol): Likewise. | |
| 610 | * elf32-metag.c (elf_metag_finish_dynamic_symbol): Likewise. | |
| 611 | * elf32-microblaze.c (microblaze_elf_finish_dynamic_symbol): Likewise. | |
| 612 | * elf32-nios2.c (nios2_elf32_finish_dynamic_symbol): Likewise. | |
| 613 | * elf32-or1k.c (or1k_elf_finish_dynamic_symbol): Likewise. | |
| 614 | * elf32-ppc.c (ppc_elf_finish_dynamic_symbol): Likewise. | |
| 615 | * elf32-s390.c (elf_s390_finish_dynamic_symbol): Likewise. | |
| 616 | * elf32-tic6x.c (elf32_tic6x_finish_dynamic_symbol): Likewise. | |
| 617 | * elf32-tilepro.c (tilepro_elf_finish_dynamic_symbol): Likewise. | |
| 618 | * elf64-ppc.c (ppc64_elf_finish_dynamic_symbol): Likewise. | |
| 619 | * elf64-s390.c (elf_s390_finish_dynamic_symbol): Likewise. | |
| 620 | * elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Likewise. | |
| 621 | * elfnn-aarch64.c (elfNN_aarch64_finish_dynamic_symbol): Likewise. | |
| 622 | * elfnn-riscv.c (riscv_elf_finish_dynamic_symbol): Likewise. | |
| 623 | * elfxx-mips.c (_bfd_mips_vxworks_finish_dynamic_symbol): Likewise. | |
| 624 | * elfxx-sparc.c (_bfd_sparc_elf_finish_dynamic_symbol): Likewise. | |
| 625 | * elfxx-tilegx.c (tilegx_elf_finish_dynamic_symbol): Likewise. | |
| 626 | ||
| 0e392101 MR |
627 | 2017-02-28 Maciej W. Rozycki <macro@imgtec.com> |
| 628 | ||
| 629 | * elfxx-mips.c (mips_elf_perform_relocation): Also handle the | |
| 630 | `jalr $0, $25' instruction encoding. | |
| 631 | ||
| bd757ca7 NC |
632 | 2017-02-27 Nick Clifton <nickc@redhat.com> |
| 633 | ||
| 634 | PR ld/21180 | |
| 635 | * elf32-microblaze.c (microblaze_elf_finish_dynamic_symbol): Avoid | |
| 636 | generating a seg-fault when encountering a symbol that has been | |
| 637 | deleted by garbage collection. | |
| 638 | ||
| 034fed0b AM |
639 | 2017-02-25 Alan Modra <amodra@gmail.com> |
| 640 | ||
| 641 | * elf32-arc.c (struct dynamic_sections): Delete. | |
| 642 | (enum dyn_section_types): Delete. | |
| 643 | (dyn_section_names): Delete. | |
| 644 | (arc_create_dynamic_sections): Delete. | |
| 645 | (elf_arc_finish_dynamic_sections): Don't call the above. Don't | |
| 646 | segfault on discarded .rela.plt section. | |
| 647 | (elf_arc_size_dynamic_sections): Formatting. Don't call | |
| 648 | arc_create_dynamic_sections. Don't allocate memory for sections | |
| 649 | handled by the generic linker. Correct code finding relocs in | |
| 650 | read-only sections. Set SEC_EXCLUDE on zero size .got, | |
| 651 | .got.plt, and .dynbss sections. Do set .interp for pies. | |
| 652 | ||
| d0f744f9 AW |
653 | 2017-02-24 Andrew Waterman <andrew@sifive.com> |
| 654 | ||
| 655 | * elfnn-riscv.c (GP_NAME): New macro. | |
| 656 | (riscv_global_pointer_value): Use it. | |
| 657 | (_bfd_riscv_relax_lui): If symbol and global pointer are in same | |
| 658 | output section, consider only that section's alignment. | |
| 659 | ||
| 5d58c733 MR |
660 | 2017-02-23 Maciej W. Rozycki <macro@imgtec.com> |
| 661 | ||
| 662 | * elfxx-mips.h (_bfd_mips_relax_section): Remove prototype. | |
| 663 | * elfxx-mips.c (_bfd_mips_relax_section): Remove function. | |
| 664 | * elf64-mips.c (bfd_elf64_bfd_relax_section): Remove macro. | |
| 665 | * elfn32-mips.c (bfd_elf32_bfd_relax_section): Likewise. | |
| 666 | ||
| c1556ecd MR |
667 | 2017-02-23 Maciej W. Rozycki <macro@imgtec.com> |
| 668 | ||
| 669 | * elfxx-mips.c (mips_elf_calculate_relocation) <R_MIPS_JALR> | |
| 670 | <R_MICROMIPS_JALR>: Discard relocation if `cross_mode_jump_p' | |
| 671 | or misaligned. | |
| 672 | ||
| 5499c7c7 AM |
673 | 2017-02-23 Alan Modra <amodra@gmail.com> |
| 674 | ||
| 675 | PR 20744 | |
| 676 | * elf32-ppc.c (ppc_elf_howto_raw): Correct dst_mask on all VLE | |
| 677 | 16D relocations. | |
| 678 | (ppc_elf_vle_split16): Correct field mask and shift for 16D relocs. | |
| 679 | (ppc_elf_relocate_section): Correct calculation for VLE SDAREL | |
| 680 | relocs. | |
| 681 | ||
| 902e9fc7 MR |
682 | 2017-02-22 Maciej W. Rozycki <macro@imgtec.com> |
| 683 | ||
| 684 | PR ld/20828 | |
| 685 | * elflink.c (bfd_elf_size_dynamic_sections): Move symbol version | |
| 686 | processing ahead of the call to `elf_gc_sweep_symbol'. | |
| 687 | ||
| 758d96d8 NC |
688 | 2017-02-22 Nick Clifton <nickc@redhat.com> |
| 689 | ||
| 690 | PR binutils/21193 | |
| 691 | * opncls.c (bfd_create_gnu_debuglink_section): Give the newly | |
| 692 | created section 4-byte alignment. | |
| 693 | ||
| 6528b6eb AM |
694 | 2017-02-22 Alan Modra <amodra@gmail.com> |
| 695 | ||
| 696 | * elf64-ppc.c (ppc64_elf_finish_dynamic_sections): Don't segfault | |
| 697 | on .got or .plt output section being discarded by script. | |
| 698 | * elf32-ppc.c (ppc_elf_finish_dynamic_sections): Likewise. Move | |
| 699 | vxworks splt temp. | |
| 700 | ||
| 24f1a751 AM |
701 | 2017-02-21 Alan Modra <amodra@gmail.com> |
| 702 | ||
| 703 | * elf64-alpha.c (elf64_alpha_size_dynamic_sections): Only emit | |
| 704 | DT_RELA, DT_RELASZ, and DT_RELAENT when DT_RELASZ is non-zero. | |
| 705 | ||
| 64487780 AM |
706 | 2017-02-20 Alan Modra <amodra@gmail.com> |
| 707 | ||
| 708 | PR 21181 | |
| 709 | * elflink.c (bfd_elf_final_link): Make DT_REL/DT_RELA zero | |
| 710 | if DT_RELSZ/DT_RELASZ is zero. | |
| 711 | ||
| 6438d1be NC |
712 | 2017-02-17 Nick Clifton <nickc@redhat.com> |
| 713 | ||
| 714 | * compress.c (bfd_get_full_section_contents): Remember to reduce | |
| 715 | compressed size by the sizeof the compression header when | |
| 716 | decompressing the contents. | |
| 717 | ||
| 4bc26c69 PA |
718 | 2017-02-17 Pedro Alves <palves@redhat.com> |
| 719 | ||
| 720 | * srec.c (Chunk): Rename to ... | |
| 721 | (_bfd_srec_len): ... this. | |
| 722 | (S3Forced): Rename to ... | |
| 723 | (_bfd_srec_forceS3): ... this. | |
| 724 | * objcopy.c: Adjust all references. | |
| 725 | ||
| 7ec22e0f PA |
726 | 2017-02-17 Pedro Alves <palves@redhat.com> |
| 727 | ||
| 728 | * archive.c (bsd_write_armap): Rename to ... | |
| 729 | (_bfd_bsd_write_armap): ... this. | |
| 730 | (coff_write_armap): Rename to ... | |
| 731 | (_bfd_coff_write_armap): ... this. | |
| 732 | * libbfd-in.h (bsd_write_armap): Rename to ... | |
| 733 | (_bfd_bsd_write_armap): ... this. | |
| 734 | (coff_write_armap): Rename to ... | |
| 735 | (_bfd_coff_write_armap): ... this. | |
| 736 | * aout-target.h, aout-tic30.c: Adjust all users. | |
| 737 | * libbfd.h: Regenerate. | |
| 738 | ||
| 8c8402cc PA |
739 | 2017-02-17 Pedro Alves <palves@redhat.com> |
| 740 | ||
| 741 | * bfd-in.h (bfd_read, bfd_write): Adjust to rename. | |
| 742 | (warn_deprecated): Rename to ... | |
| 743 | (_bfd_warn_deprecated): ... this. | |
| 744 | * libbfd.c (warn_deprecated): Rename to ... | |
| 745 | (_bfd_warn_deprecated): ... this. | |
| 746 | * bfd-in2.h: Regenerate. | |
| 747 | ||
| c7c3d11b PA |
748 | 2017-02-17 Pedro Alves <palves@redhat.com> |
| 749 | ||
| 750 | * bfdio.c (real_ftell): Rename to ... | |
| 751 | (_bfd_real_ftell): ... this. | |
| 752 | (real_fseek): Rename to ... | |
| 753 | (_bfd_real_fseek): ... this. | |
| 754 | (real_fopen): Rename to ... | |
| 755 | (_bfd_real_fopen): ... this. | |
| 756 | * libbfd-in.h (real_ftell): Rename to ... | |
| 757 | (_bfd_real_ftell): ... this. | |
| 758 | (real_fseek): Rename to ... | |
| 759 | (_bfd_real_fseek): ... this. | |
| 760 | (real_fopen): Rename to ... | |
| 761 | (_bfd_real_fopen): ... this. | |
| 762 | * cache.c, dwarf2.c, opncls.c: Adjust all callers. | |
| 763 | * libbfd.h: Regenerate. | |
| 764 | ||
| 4265548c PA |
765 | 2017-02-17 Pedro Alves <palves@redhat.com> |
| 766 | ||
| 767 | * dwarf2.c, elf-attrs.c, elf32-nds32.c: Adjust all callers. | |
| 768 | * libbfd.c (read_unsigned_leb128): Rename to ... | |
| 769 | (_bfd_read_unsigned_leb128): ... this. | |
| 770 | (read_signed_leb128): Rename to ... | |
| 771 | (_bfd_read_signed_leb128): ... this. | |
| 772 | (safe_read_leb128): Rename to ... | |
| 773 | (_bfd_safe_read_leb128): ... this. | |
| 774 | * libbfd-in.h (read_unsigned_leb128): Rename to ... | |
| 775 | (_bfd_read_unsigned_leb128): ... this. | |
| 776 | (read_signed_leb128): Rename to ... | |
| 777 | (_bfd_read_signed_leb128): ... this. | |
| 778 | (safe_read_leb128): Rename to ... | |
| 779 | (_bfd_safe_read_leb128): ... this. | |
| 780 | * libbfd.h: Renegerate. | |
| 781 | ||
| 3239a423 AB |
782 | 2017-02-16 Andrew Burgess <andrew.burgess@embecosm.com> |
| 783 | ||
| 784 | * dwarf2.c (_bfd_dwarf2_find_nearest_line): Perform symbol lookup | |
| 785 | before trying to fine matching file and line information. | |
| 786 | ||
| 90ed9b8b AB |
787 | 2017-02-16 Andrew Burgess <andrew.burgess@embecosm.com> |
| 788 | ||
| 789 | * dwarf2.c (struct dwarf2_debug): Add orig_bfd member. | |
| 790 | (_bfd_dwarf2_slurp_debug_info): If stashed debug information does | |
| 791 | not match current bfd, then reload debug information. Record bfd | |
| 792 | we're loading debug info for in the stash. If we have debug | |
| 793 | informatin in the cache then perform section placement before | |
| 794 | returning. | |
| 795 | ||
| a8c75b76 AM |
796 | 2017-02-16 Alan Modra <amodra@gmail.com> |
| 797 | ||
| 798 | PR 21000 | |
| 799 | * elf-bfd.h (struct elf_backend_data): Add no_page_alias. | |
| 800 | * elfxx-target.h (elf_backend_no_page_alias): Define. | |
| 801 | (elfNN_bed): Init new field. | |
| 802 | * elf.c (assign_file_positions_for_load_sections): If no_page_alias | |
| 803 | ensure PT_LOAD segment starts on a new page. | |
| 804 | * elf32-hppa.c (elf_backend_no_page_alias): Define. | |
| 805 | ||
| 247d6c4c AM |
806 | 2017-02-16 Alan Modra <amodra@gmail.com> |
| 807 | ||
| 808 | PR 21132 | |
| 809 | * elf32-hppa.c (allocate_plt_static): Allocate space for relocs | |
| 810 | if pic. | |
| 811 | ||
| 90571206 JW |
812 | 2017-02-16 Jiong Wang <jiong.wang@arm.com> |
| 813 | ||
| 814 | * bfd.c (BFD_FLAGS_SAVED): Add BFD_LINKER_CREATED. | |
| 815 | * bfd-in2.h: Regenerated. | |
| 816 | ||
| 2a568401 L |
817 | 2017-02-15 H.J. Lu <hongjiu.lu@intel.com> |
| 818 | ||
| 819 | PR ld/21168 | |
| 820 | * elf32-i386.c (elf_i386_relocate_section): Allow | |
| 821 | "lea foo@GOT, %reg" in PIC. | |
| 822 | ||
| a5def14f L |
823 | 2017-02-15 H.J. Lu <hongjiu.lu@intel.com> |
| 824 | ||
| 825 | PR ld/20244 | |
| 826 | * elf32-i386.c (elf_i386_relocate_section): Properly get IFUNC | |
| 827 | symbol name when reporting R_386_GOT32/R_386_GOT32X relocation | |
| 828 | error against local IFUNC symbol without a base register for | |
| 829 | PIC. | |
| 830 | ||
| 174d0a74 MR |
831 | 2017-02-15 Maciej W. Rozycki <macro@imgtec.com> |
| 832 | ||
| 833 | * elf32-ppc.c (ppc_elf_check_relocs): Use `%H:' rather than | |
| 834 | `%P: %H:' with `info->callbacks->einfo'. | |
| 835 | (ppc_elf_relocate_section): Likewise. | |
| 836 | * elf64-ppc.c (ppc64_elf_check_relocs): Likewise. | |
| 837 | (ppc64_elf_edit_toc): Likewise. | |
| 838 | (ppc64_elf_relocate_section): Likewise. | |
| 839 | ||
| e278ae05 AM |
840 | 2017-02-14 Alan Modra <amodra@gmail.com> |
| 841 | ||
| 842 | * elf64-ppc.c (ppc64_elf_gc_mark_dynamic_ref): Support | |
| 843 | --gc-keep-exported, and test versioned field of sym rather than | |
| 844 | looking for @ in name. | |
| 845 | ||
| 10ddfe62 PD |
846 | 2017-02-13 Palmer Dabbelt <palmer@dabbelt.com> |
| 847 | ||
| 848 | * elfnn-riscv.c (riscv_global_pointer_value): Change _gp to | |
| 849 | __global_pointer$. | |
| 850 | ||
| d11135f5 NC |
851 | 2017-02-13 Nick Clifton <nickc@redhat.com> |
| 852 | ||
| 853 | PR binutils/21151 | |
| 854 | * dwarf2.c (_bfd_dwarf2_find_nearest_line): Check for an invalid | |
| 855 | unit length field. | |
| 856 | ||
| cc162427 AW |
857 | 2017-02-07 Andrew Waterman <andrew@sifive.com> |
| 858 | ||
| 859 | * elfnn-riscv.c (riscv_elf_finish_dynamic_sections): Only write PLT | |
| 860 | entry size if PLT header is written. | |
| 861 | ||
| 3d044c0c SL |
862 | 2017-02-06 Sheldon Lobo <sheldon.lobo@oracle.com> |
| 863 | ||
| 864 | Fix sparc64 dynamic relocation processing to use the dynamic | |
| 865 | symbol count. | |
| 866 | * elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Use 'dynamic' | |
| 867 | to determine if bfd_get_symcount() or bfd_get_dynamic_symcount() | |
| 868 | should be used. | |
| 869 | ||
| 1b7e3d2f NC |
870 | 2017-02-03 Nick Clifton <nickc@redhat.com> |
| 871 | ||
| 872 | PR 21096 | |
| 873 | * coffcode.h (coff_write_object_contents): Enlarge size of | |
| 874 | s_name_buf in order to avoid compile time warning about possible | |
| 875 | integer truncation. | |
| 876 | * elf32-nds32.c (nds32_elf_ex9_import_table): Mask off lower | |
| 877 | 32-bits of insn value before printing into buffer. | |
| 878 | ||
| e17b0c35 MR |
879 | 2017-02-02 Maciej W. Rozycki <macro@imgtec.com> |
| 880 | ||
| 881 | * elfxx-mips.c (mips_elf_hash_sort_data): Add | |
| 882 | `max_local_dynindx'. | |
| 883 | (mips_elf_sort_hash_table): Handle it. | |
| 884 | (mips_elf_sort_hash_table_f) <GGA_NONE>: For forced local | |
| 885 | symbols bump up `max_local_dynindx' rather than | |
| 886 | `max_non_got_dynindx'. | |
| 887 | ||
| 55f8b9d2 MR |
888 | 2017-02-02 Maciej W. Rozycki <macro@imgtec.com> |
| 889 | ||
| 890 | * elfxx-mips.c (mips_elf_hash_sort_data): Convert the | |
| 891 | `min_got_dynindx', `max_unref_got_dynindx' and | |
| 892 | `max_non_got_dynindx' members to the `bfd_size_type' data type. | |
| 893 | (mips_elf_sort_hash_table): Adjust accordingly. | |
| 894 | ||
| 0f8c4b60 MR |
895 | 2017-02-02 Maciej W. Rozycki <macro@imgtec.com> |
| 896 | ||
| 897 | * elfxx-mips.c (mips_elf_sort_hash_table): Use `htab' throughout | |
| 898 | to access the hash table. | |
| 899 | ||
| 17a80fa8 MR |
900 | 2017-02-02 Maciej W. Rozycki <macro@imgtec.com> |
| 901 | ||
| 902 | * elfxx-mips.c (mips_elf_sort_hash_table): Move assertion on | |
| 903 | non-NULL `htab' to the beginning. | |
| 904 | ||
| 8f56d4fd MR |
905 | 2017-02-02 Maciej W. Rozycki <macro@imgtec.com> |
| 906 | ||
| 907 | * elflink.c (elf_gc_sweep): Wrap overlong line. | |
| 908 | ||
| 8b10b0b3 MR |
909 | 2017-01-30 Maciej W. Rozycki <macro@imgtec.com> |
| 910 | ||
| 911 | * elfxx-mips.h (_bfd_mips_elf_insn32): Rename prototype to... | |
| 912 | (_bfd_mips_elf_linker_flags): ... this. Add another parameter. | |
| 913 | * elfxx-mips.c (mips_elf_link_hash_table): Add | |
| 914 | `ignore_branch_isa' member. | |
| 915 | (mips_elf_perform_relocation): Do not treat an ISA mode mismatch | |
| 916 | in branch relocation calculation as an error if | |
| 917 | `ignore_branch_isa' has been set. | |
| 918 | (_bfd_mips_elf_insn32): Rename to... | |
| 919 | (_bfd_mips_elf_linker_flags): ... this. Rename the `on' | |
| 920 | parameter to `insn32' and add an `ignore_branch_isa' parameter. | |
| 921 | Handle the new parameter. | |
| 922 | ||
| 1fbd05e1 HPN |
923 | 2017-01-27 Hans-Peter Nilsson <hp@axis.com> |
| 924 | ||
| 22d9a0de HPN |
925 | * elf32-cris.c (elf_cris_finish_dynamic_symbol): Remove now unused |
| 926 | local variable dynobj. | |
| 927 | ||
| 1fbd05e1 HPN |
928 | PR ld/20995 |
| 929 | * elf32-cris.c (elf_cris_size_dynamic_sections): Handle sdynrelro. | |
| 930 | (elf_cris_adjust_dynamic_symbol): Place variables copied into the | |
| 931 | executable from read-only sections into sdynrelro. | |
| 932 | (elf_cris_finish_dynamic_symbol): Select sreldynrelro for | |
| 933 | dynamic relocs in sdynrelro. | |
| 934 | (elf_backend_want_dynrelro): Define. | |
| 935 | ||
| 4a7324e1 SH |
936 | 2017-01-25 Sebastian Huber <sebastian.huber@embedded-brains.de> |
| 937 | ||
| 938 | * config.bfd (*-*-rtemsaout*): Mark as removed. | |
| 939 | ||
| c75b4ebd SH |
940 | 2017-01-25 Sebastian Huber <sebastian.huber@embedded-brains.de> |
| 941 | ||
| 942 | * config.bfd (powerpcle-*-rtems*): Do not mark as removed. | |
| 943 | (arm-*-rtems*): Move to (arm*-*-eabi*). | |
| 944 | (i[3-7]86-*-rtems*): Move to (i[3-7]86-*-elf*). | |
| 945 | (m68-*-rtems*): Move to (m68*-*-elf*). | |
| 946 | ||
| 850d84f6 SH |
947 | 2017-01-25 Sebastian Huber <sebastian.huber@embedded-brains.de> |
| 948 | ||
| 949 | * config.bfd (*-*-rtemscoff*): Mark as removed. | |
| 950 | ||
| b531344c MR |
951 | 2017-01-24 Maciej W. Rozycki <macro@imgtec.com> |
| 952 | ||
| 953 | PR ld/20828 | |
| 954 | * elflink.c (bfd_elf_record_link_assignment): Revert last | |
| 955 | change and don't ever clear `forced_local'. Set `mark' | |
| 956 | unconditionally. | |
| 957 | (elf_gc_sweep_symbol_info, elf_gc_sweep_symbol): Reorder within | |
| 958 | file. | |
| 959 | (elf_gc_sweep): Move the call to `elf_gc_sweep_symbol'... | |
| 960 | (bfd_elf_size_dynamic_sections): ... here. | |
| 961 | * elf32-ppc.c (ppc_elf_tls_setup): Don't clear `forced_local' | |
| 962 | and set `mark' instead in `__tls_get_addr_opt' processing. | |
| 963 | * elf64-ppc.c (ppc64_elf_tls_setup): Likewise. | |
| 964 | ||
| f0158f44 AM |
965 | 2017-01-24 Alan Modra <amodra@gmail.com> |
| 966 | ||
| 967 | * elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Merge two cases | |
| 968 | where dynamic relocs are preferable. Allow ifunc too. | |
| 969 | (ensure_undefweak_dynamic): New function. | |
| 970 | (allocate_dynrelocs): Use it here. Move plt handling last and | |
| 971 | don't make symbols dynamic, simplifying loop. Only make undef | |
| 972 | weak symbols with GOT entries dynamic. Correct condition | |
| 973 | for GOT relocs. Handle dynamic relocs on ifuncs. Correct | |
| 974 | comments. Remove goto. | |
| 975 | (ppc_elf_relocate_section): Correct test for using dynamic | |
| 976 | symbol on GOT relocs. Rearrange test for emitting GOT relocs | |
| 977 | to suit. Set up explicit tls_index entries and implicit GOT | |
| 978 | tls_index entries resolvable at link time for | |
| 979 | __tls_get_addr_opt. Simplify test to clear mem for prelink. | |
| 980 | * elf64-ppc.c (allocate_got): Correct condition for GOT relocs. | |
| 981 | (ensure_undefweak_dynamic): New function. | |
| 982 | (allocate_dynrelocs): Use it here. Only make undef weak symbols | |
| 983 | with GOT entries dynamic. Remove unnecessary test of | |
| 984 | WILL_CALL_FINISH_DYNAMIC_SYMBOL in PLT handling. | |
| 985 | (ppc64_elf_relocate_section): Correct test for using dynamic | |
| 986 | symbol on GOT relocs. Rearrange test for emitting GOT relocs | |
| 987 | to suit. Set up explicit tls_index entries and implicit GOT | |
| 988 | tls_index entries resolvable at link time for __tls_get_addr_opt. | |
| 989 | Simplify expression to clear mem for prelink. | |
| 990 | ||
| 2d0ca824 YN |
991 | 2017-01-23 Yury Norov <ynorov@caviumnetworks.com> |
| 992 | ||
| 993 | * elfnn-aarch64.c: Fix relaxations for ILP32 mode. | |
| 994 | ||
| 7f784814 JW |
995 | 2017-01-20 Jiong Wang <jiong.wang@arm.com> |
| 996 | ||
| 997 | * elfnn-aarch64.c (elf_aarch64_hash_symbol): New function. | |
| 998 | (elf_backend_hash_symbol): Define. | |
| 999 | ||
| 81ff47b3 MR |
1000 | 2017-01-18 Maciej W. Rozycki <macro@imgtec.com> |
| 1001 | ||
| 1002 | PR ld/20828 | |
| 1003 | * elflink.c (bfd_elf_record_link_assignment): Clear any | |
| 1004 | `forced_local' marking for DSO symbols that are not being | |
| 1005 | provided. | |
| 1006 | ||
| 640d6bfd KLC |
1007 | 2017-01-17 Kuan-Lin Chen <kuanlinchentw@gmail.com> |
| 1008 | ||
| 1009 | * elfnn-riscv.c (riscv_elf_object_p): New function. | |
| 1010 | ||
| 8361ed4d L |
1011 | 2017-01-12 H.J. Lu <hongjiu.lu@intel.com> |
| 1012 | ||
| 1013 | PR ld/21038 | |
| 1014 | * elf64-x86-64.c (elf_x86_64_link_hash_table): Add | |
| 1015 | plt_bnd_eh_frame. | |
| 1016 | (elf_x86_64_check_relocs): Create .eh_frame section for the | |
| 1017 | .plt.bnd section. | |
| 1018 | (elf_x86_64_size_dynamic_sections): Allocate and initialize | |
| 1019 | .eh_frame section for the .plt.bnd section. | |
| 1020 | (elf_x86_64_finish_dynamic_sections): Adjust .eh_frame section | |
| 1021 | for the .plt.bnd section. | |
| 1022 | ||
| 2425a30e NC |
1023 | 2017-01-12 Nick Clifton <nickc@redhat.com> |
| 1024 | ||
| 1025 | PR binutils/20876 | |
| 1026 | * opncls.c (find_separate_debug_file): Add include_dirs | |
| 1027 | parameter. Only include the directory part of the bfd's filename | |
| 1028 | in search paths if include_dirs is true. Add a couple of extra | |
| 1029 | locations for looking for debug files. | |
| 1030 | ( bfd_follow_gnu_debuglink): Update invocation of | |
| 1031 | find_separate_debug_file. | |
| 1032 | (bfd_follow_gnu_debugaltlink): Likewise. | |
| 1033 | (get_build_id): New function: Finds the build-id of the given bfd. | |
| 1034 | (get_build_id_name): New function: Computes the name of the | |
| 1035 | separate debug info file for a bfd, based upon its build-id. | |
| 1036 | (check_build_id_file): New function: Checks to see if a separate | |
| 1037 | debug info file exists at the given location, and that its | |
| 1038 | build-id matches that of the original bfd. | |
| 1039 | (bfd_follow_build_id_debuglink): New function: Finds a separate | |
| 1040 | debug info file for a given bfd by using the build-id method. | |
| 1041 | * dwarf2.c (_bfd_dwarf2_slurp_debug_info): Try using the build-id | |
| 1042 | method of locating a separate debug info file before using the | |
| 1043 | debuglink method. | |
| 1044 | * bfd-in2.h: Regenerate. | |
| 1045 | ||
| 9e659176 L |
1046 | 2017-01-11 H.J. Lu <hongjiu.lu@intel.com> |
| 1047 | ||
| 1048 | PR ld/21038 | |
| 1049 | * elf64-x86-64.c (elf_x86_64_eh_frame_bnd_plt): New. | |
| 1050 | (elf_x86_64_bnd_arch_bed): Use elf_x86_64_eh_frame_bnd_plt and | |
| 1051 | elf_x86_64_eh_frame_plt_got. | |
| 1052 | (elf_x86_64_size_dynamic_sections): Get unwind info from | |
| 1053 | elf_x86_64_bnd_arch_bed for the BND PLT. | |
| 1054 | ||
| f2e2d2f5 JS |
1055 | 2017-01-11 Jeremy Soller <jackpot51@gmail.com> |
| 1056 | ||
| 1057 | * config.bfd: Add entries for i686-redox and x86_64-redox. | |
| 1058 | ||
| 52b232b3 L |
1059 | 2017-01-10 H.J. Lu <hongjiu.lu@intel.com> |
| 1060 | ||
| 1061 | * elf32-i386.c (elf_i386_check_relocs): Align .eh_frame section | |
| 1062 | to 4 bytes. | |
| 1063 | * elf64-x86-64.c (elf_x86_64_create_dynamic_sections): Align | |
| 1064 | .eh_frame section to 4 bytes for x32. | |
| 1065 | (elf_x86_64_check_relocs): Likewise. | |
| 1066 | ||
| fff53dae L |
1067 | 2017-01-10 H.J. Lu <hongjiu.lu@intel.com> |
| 1068 | ||
| 1069 | PR ld/20830 | |
| 1070 | * elf32-i386.c (elf_i386_eh_frame_plt_got): New. | |
| 1071 | (PLT_GOT_FDE_LENGTH): Likewise. | |
| 1072 | (elf_i386_plt_layout): Add eh_frame_plt_got and | |
| 1073 | eh_frame_plt_got_size. | |
| 1074 | (elf_i386_plt): Updated. | |
| 1075 | (elf_i386_link_hash_table): Add plt_got_eh_frame. | |
| 1076 | (elf_i386_check_relocs): Create .eh_frame section for .plt.got. | |
| 1077 | (elf_i386_size_dynamic_sections): Allocate and initialize | |
| 1078 | .eh_frame section for .plt.got. | |
| 1079 | (elf_i386_finish_dynamic_sections): Adjust .eh_frame section for | |
| 1080 | .plt.got. | |
| 1081 | (elf_i386_nacl_plt): Add FIXME for eh_frame_plt_got and | |
| 1082 | eh_frame_plt_got_size. | |
| 1083 | * elf64-x86-64.c (elf_x86_64_eh_frame_plt_got): New. | |
| 1084 | (PLT_GOT_FDE_LENGTH): Likewise. | |
| 1085 | (elf_x86_64_backend_data): Add eh_frame_plt_got and | |
| 1086 | eh_frame_plt_got_size. | |
| 1087 | (elf_x86_64_arch_bed): Updated. | |
| 1088 | (elf_x86_64_bnd_arch_bed): Add FIXME for eh_frame_plt_got and | |
| 1089 | eh_frame_plt_got_size. | |
| 1090 | (elf_x86_64_nacl_arch_bed): Likewise. | |
| 1091 | (elf_x86_64_link_hash_table): Add plt_got_eh_frame. | |
| 1092 | (elf_x86_64_check_relocs): Create .eh_frame section for .plt.got. | |
| 1093 | (elf_x86_64_size_dynamic_sections): Allocate and initialize | |
| 1094 | .eh_frame section for .plt.got. | |
| 1095 | (elf_x86_64_finish_dynamic_sections): Adjust .eh_frame section | |
| 1096 | for .plt.got. | |
| 1097 | ||
| f129e49f L |
1098 | 2017-01-10 H.J. Lu <hongjiu.lu@intel.com> |
| 1099 | ||
| 1100 | * elf32-i386.c (elf_i386_size_dynamic_sections): Set | |
| 1101 | plt_eh_frame->size to eh_frame_plt_size and use eh_frame_plt. | |
| 1102 | ||
| cd6581da NC |
1103 | 2017-01-09 Nick Clifton <nickc@redhat.com> |
| 1104 | ||
| 1105 | * dwarf2.c (lookup_address_in_function_table): Return early if | |
| 1106 | there are no functions in the given comp unit, or if the high | |
| 1107 | address of the last function in the comp unit is less than the | |
| 1108 | desired address. | |
| 1109 | ||
| 98f02962 NC |
1110 | 2017-01-09 Nick Clifton <nickc@redhat.com> |
| 1111 | ||
| 1112 | PR binutils/21013 | |
| 1113 | * coffgen.c (_bfd_coff_get_external_symbols): Generate an error | |
| 1114 | message if there are too many symbols to load. | |
| 1115 | ||
| ae4fda66 JC |
1116 | 2017-01-04 James Clarke <jrtc27@jrtc27.com> |
| 1117 | ||
| 1118 | * elf64-alpha.c (elf64_alpha_relax_opt_call): Don't set tsec_free | |
| 1119 | if relocs are cached. | |
| 1120 | ||
| de1010f4 RF |
1121 | 2017-01-03 Rich Felker <bugdal@aerifal.cx> |
| 1122 | ||
| 1123 | PR ld/21017 | |
| 1124 | * elf32-microblaze.c (microblaze_elf_check_relocs): Add an entry | |
| 1125 | for R_MICROBLAZE_GOTOFF_64. | |
| 1126 | ||
| 09fe2662 NC |
1127 | 2017-01-03 Nick Clifton <nickc@redhat.com> |
| 1128 | ||
| 1129 | * mach-o.c (bfd_mach_o_lookup_uuid_command): Fix compile time | |
| 1130 | warning about using a possibly uninitialised variable. | |
| 1131 | ||
| 595e0a47 AM |
1132 | 2017-01-02 Alan Modra <amodra@gmail.com> |
| 1133 | ||
| 1134 | * elf32-hppa.c (ensure_undef_weak_dynamic): New function. | |
| 1135 | (allocate_plt_static, allocate_dynrelocs): Use it. | |
| 1136 | ||
| 7bd9df3b AM |
1137 | 2017-01-02 Alan Modra <amodra@gmail.com> |
| 1138 | ||
| 1139 | * elf-hppa.h (elf_hppa_fake_sections): Set SHF_INFO_LINK for | |
| 1140 | .PARISC.unwind section. | |
| 1141 | ||
| 5b86074c AM |
1142 | 2017-01-02 Alan Modra <amodra@gmail.com> |
| 1143 | ||
| 1144 | PR ld/20989 | |
| 1145 | * elfxx-sparc.c (gdop_relative_offset_ok): New function. | |
| 1146 | (_bfd_sparc_elf_relocate_section): Use it to validate GOT | |
| 1147 | indirect to GOT pointer relative code edit. | |
| 1148 | ||
| 2571583a AM |
1149 | 2017-01-02 Alan Modra <amodra@gmail.com> |
| 1150 | ||
| 1151 | Update year range in copyright notice of all files. | |
| 1152 | ||
| 5c1ad6b5 | 1153 | For older changes see ChangeLog-2016 |
| 3499769a | 1154 | \f |
| 5c1ad6b5 | 1155 | Copyright (C) 2017 Free Software Foundation, Inc. |
| 3499769a AM |
1156 | |
| 1157 | Copying and distribution of this file, with or without modification, | |
| 1158 | are permitted in any medium without royalty provided the copyright | |
| 1159 | notice and this notice are preserved. | |
| 1160 | ||
| 1161 | Local Variables: | |
| 1162 | mode: change-log | |
| 1163 | left-margin: 8 | |
| 1164 | fill-column: 74 | |
| 1165 | version-control: never | |
| 1166 | End: |