[deliverable/linux.git] / drivers / hwmon / ds1621.c

/*
    ds1621.c - Part of lm_sensors, Linux kernel modules for hardware
             monitoring
    Christian W. Zuckschwerdt  <zany@triq.net>  2000-11-23
    based on lm75.c by Frodo Looijaard <frodol@dds.nl>
    Ported to Linux 2.6 by Aurelien Jarno <aurelien@aurel32.net> with 
    the help of Jean Delvare <khali@linux-fr.org>

    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 2 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software
    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/

#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/jiffies.h>
#include <linux/i2c.h>
#include <linux/hwmon.h>
#include <linux/hwmon-sysfs.h>
#include <linux/err.h>
#include <linux/mutex.h>
#include <linux/sysfs.h>
#include "lm75.h"

/* Addresses to scan */
static unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b, 0x4c,
					0x4d, 0x4e, 0x4f, I2C_CLIENT_END };

/* Insmod parameters */
I2C_CLIENT_INSMOD_1(ds1621);
static int polarity = -1;
module_param(polarity, int, 0);
MODULE_PARM_DESC(polarity, "Output's polarity: 0 = active high, 1 = active low");

/* Many DS1621 constants specified below */
/* Config register used for detection         */
/*  7    6    5    4    3    2    1    0      */
/* |Done|THF |TLF |NVB | X  | X  |POL |1SHOT| */
#define DS1621_REG_CONFIG_NVB		0x10
#define DS1621_REG_CONFIG_POLARITY	0x02
#define DS1621_REG_CONFIG_1SHOT		0x01
#define DS1621_REG_CONFIG_DONE		0x80

/* The DS1621 registers */
static const u8 DS1621_REG_TEMP[3] = {
	0xAA,		/* input, word, RO */
	0xA2,		/* min, word, RW */
	0xA1,		/* max, word, RW */
};
#define DS1621_REG_CONF			0xAC /* byte, RW */
#define DS1621_COM_START		0xEE /* no data */
#define DS1621_COM_STOP			0x22 /* no data */

/* The DS1621 configuration register */
#define DS1621_ALARM_TEMP_HIGH		0x40
#define DS1621_ALARM_TEMP_LOW		0x20

/* Conversions */
#define ALARMS_FROM_REG(val) ((val) & \
                              (DS1621_ALARM_TEMP_HIGH | DS1621_ALARM_TEMP_LOW))

/* Each client has this additional data */
struct ds1621_data {
	struct i2c_client client;
	struct device *hwmon_dev;
	struct mutex update_lock;
	char valid;			/* !=0 if following fields are valid */
	unsigned long last_updated;	/* In jiffies */

	u16 temp[3];			/* Register values, word */
	u8 conf;			/* Register encoding, combined */
};

static int ds1621_attach_adapter(struct i2c_adapter *adapter);
static int ds1621_detect(struct i2c_adapter *adapter, int address,
			 int kind);
static void ds1621_init_client(struct i2c_client *client);
static int ds1621_detach_client(struct i2c_client *client);
static struct ds1621_data *ds1621_update_client(struct device *dev);

/* This is the driver that will be inserted */
static struct i2c_driver ds1621_driver = {
	.driver = {
		.name	= "ds1621",
	},
	.attach_adapter	= ds1621_attach_adapter,
	.detach_client	= ds1621_detach_client,
};

/* All registers are word-sized, except for the configuration register.
   DS1621 uses a high-byte first convention, which is exactly opposite to
   the SMBus standard. */
static int ds1621_read_value(struct i2c_client *client, u8 reg)
{
	if (reg == DS1621_REG_CONF)
		return i2c_smbus_read_byte_data(client, reg);
	else
		return swab16(i2c_smbus_read_word_data(client, reg));
}

static int ds1621_write_value(struct i2c_client *client, u8 reg, u16 value)
{
	if (reg == DS1621_REG_CONF)
		return i2c_smbus_write_byte_data(client, reg, value);
	else
		return i2c_smbus_write_word_data(client, reg, swab16(value));
}

static void ds1621_init_client(struct i2c_client *client)
{
	int reg = ds1621_read_value(client, DS1621_REG_CONF);
	/* switch to continuous conversion mode */
	reg &= ~ DS1621_REG_CONFIG_1SHOT;

	/* setup output polarity */
	if (polarity == 0)
		reg &= ~DS1621_REG_CONFIG_POLARITY;
	else if (polarity == 1)
		reg |= DS1621_REG_CONFIG_POLARITY;
	
	ds1621_write_value(client, DS1621_REG_CONF, reg);
	
	/* start conversion */
	i2c_smbus_write_byte(client, DS1621_COM_START);
}

static ssize_t show_temp(struct device *dev, struct device_attribute *da,
			 char *buf)
{
	struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
	struct ds1621_data *data = ds1621_update_client(dev);
	return sprintf(buf, "%d\n",
		       LM75_TEMP_FROM_REG(data->temp[attr->index]));
}

static ssize_t set_temp(struct device *dev, struct device_attribute *da,
			const char *buf, size_t count)
{
	struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
	struct i2c_client *client = to_i2c_client(dev);
	struct ds1621_data *data = ds1621_update_client(dev);
	u16 val = LM75_TEMP_TO_REG(simple_strtol(buf, NULL, 10));

	mutex_lock(&data->update_lock);
	data->temp[attr->index] = val;
	ds1621_write_value(client, DS1621_REG_TEMP[attr->index],
			   data->temp[attr->index]);
	mutex_unlock(&data->update_lock);
	return count;
}

static ssize_t show_alarms(struct device *dev, struct device_attribute *da,
			   char *buf)
{
	struct ds1621_data *data = ds1621_update_client(dev);
	return sprintf(buf, "%d\n", ALARMS_FROM_REG(data->conf));
}

static ssize_t show_alarm(struct device *dev, struct device_attribute *da,
			  char *buf)
{
	struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
	struct ds1621_data *data = ds1621_update_client(dev);
	return sprintf(buf, "%d\n", !!(data->conf & attr->index));
}

static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL, 0);
static SENSOR_DEVICE_ATTR(temp1_min, S_IWUSR | S_IRUGO, show_temp, set_temp, 1);
static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_temp, set_temp, 2);
static SENSOR_DEVICE_ATTR(temp1_min_alarm, S_IRUGO, show_alarm, NULL,
		DS1621_ALARM_TEMP_LOW);
static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_alarm, NULL,
		DS1621_ALARM_TEMP_HIGH);

static struct attribute *ds1621_attributes[] = {
	&sensor_dev_attr_temp1_input.dev_attr.attr,
	&sensor_dev_attr_temp1_min.dev_attr.attr,
	&sensor_dev_attr_temp1_max.dev_attr.attr,
	&sensor_dev_attr_temp1_min_alarm.dev_attr.attr,
	&sensor_dev_attr_temp1_max_alarm.dev_attr.attr,
	&dev_attr_alarms.attr,
	NULL
};

static const struct attribute_group ds1621_group = {
	.attrs = ds1621_attributes,
};


static int ds1621_attach_adapter(struct i2c_adapter *adapter)
{
	if (!(adapter->class & I2C_CLASS_HWMON))
		return 0;
	return i2c_probe(adapter, &addr_data, ds1621_detect);
}

/* This function is called by i2c_probe */
static int ds1621_detect(struct i2c_adapter *adapter, int address,
			 int kind)
{
	int conf, temp;
	struct i2c_client *client;
	struct ds1621_data *data;
	int i, err = 0;

	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA 
				     | I2C_FUNC_SMBUS_WORD_DATA 
				     | I2C_FUNC_SMBUS_WRITE_BYTE))
		goto exit;

	/* OK. For now, we presume we have a valid client. We now create the
	   client structure, even though we cannot fill it completely yet.
	   But it allows us to access ds1621_{read,write}_value. */
	if (!(data = kzalloc(sizeof(struct ds1621_data), GFP_KERNEL))) {
		err = -ENOMEM;
		goto exit;
	}
	
	client = &data->client;
	i2c_set_clientdata(client, data);
	client->addr = address;
	client->adapter = adapter;
	client->driver = &ds1621_driver;

	/* Now, we do the remaining detection. It is lousy. */
	if (kind < 0) {
		/* The NVB bit should be low if no EEPROM write has been 
		   requested during the latest 10ms, which is highly 
		   improbable in our case. */
		conf = ds1621_read_value(client, DS1621_REG_CONF);
		if (conf & DS1621_REG_CONFIG_NVB)
			goto exit_free;
		/* The 7 lowest bits of a temperature should always be 0. */
		for (i = 0; i < ARRAY_SIZE(data->temp); i++) {
			temp = ds1621_read_value(client, DS1621_REG_TEMP[i]);
			if (temp & 0x007f)
				goto exit_free;
		}
	}

	/* Fill in remaining client fields and put it into the global list */
	strlcpy(client->name, "ds1621", I2C_NAME_SIZE);
	mutex_init(&data->update_lock);

	/* Tell the I2C layer a new client has arrived */
	if ((err = i2c_attach_client(client)))
		goto exit_free;

	/* Initialize the DS1621 chip */
	ds1621_init_client(client);

	/* Register sysfs hooks */
	if ((err = sysfs_create_group(&client->dev.kobj, &ds1621_group)))
		goto exit_detach;

	data->hwmon_dev = hwmon_device_register(&client->dev);
	if (IS_ERR(data->hwmon_dev)) {
		err = PTR_ERR(data->hwmon_dev);
		goto exit_remove_files;
	}

	return 0;

      exit_remove_files:
	sysfs_remove_group(&client->dev.kobj, &ds1621_group);
      exit_detach:
	i2c_detach_client(client);
      exit_free:
	kfree(data);
      exit:
	return err;
}

static int ds1621_detach_client(struct i2c_client *client)
{
	struct ds1621_data *data = i2c_get_clientdata(client);
	int err;

	hwmon_device_unregister(data->hwmon_dev);
	sysfs_remove_group(&client->dev.kobj, &ds1621_group);

	if ((err = i2c_detach_client(client)))
		return err;

	kfree(data);

	return 0;
}


static struct ds1621_data *ds1621_update_client(struct device *dev)
{
	struct i2c_client *client = to_i2c_client(dev);
	struct ds1621_data *data = i2c_get_clientdata(client);
	u8 new_conf;

	mutex_lock(&data->update_lock);

	if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
	    || !data->valid) {
		int i;

		dev_dbg(&client->dev, "Starting ds1621 update\n");

		data->conf = ds1621_read_value(client, DS1621_REG_CONF);

		for (i = 0; i < ARRAY_SIZE(data->temp); i++)
			data->temp[i] = ds1621_read_value(client,
							  DS1621_REG_TEMP[i]);

		/* reset alarms if necessary */
		new_conf = data->conf;
		if (data->temp[0] > data->temp[1])	/* input > min */
			new_conf &= ~DS1621_ALARM_TEMP_LOW;
		if (data->temp[0] < data->temp[2])	/* input < max */
			new_conf &= ~DS1621_ALARM_TEMP_HIGH;
		if (data->conf != new_conf)
			ds1621_write_value(client, DS1621_REG_CONF,
					   new_conf);

		data->last_updated = jiffies;
		data->valid = 1;
	}

	mutex_unlock(&data->update_lock);

	return data;
}

static int __init ds1621_init(void)
{
	return i2c_add_driver(&ds1621_driver);
}

static void __exit ds1621_exit(void)
{
	i2c_del_driver(&ds1621_driver);
}


MODULE_AUTHOR("Christian W. Zuckschwerdt <zany@triq.net>");
MODULE_DESCRIPTION("DS1621 driver");
MODULE_LICENSE("GPL");

module_init(ds1621_init);
module_exit(ds1621_exit);
Commit	Line	Data
1da177e4 LT	1	/*
	2	ds1621.c - Part of lm_sensors, Linux kernel modules for hardware
	3	monitoring
	4	Christian W. Zuckschwerdt <zany@triq.net> 2000-11-23
	5	based on lm75.c by Frodo Looijaard <frodol@dds.nl>
	6	Ported to Linux 2.6 by Aurelien Jarno <aurelien@aurel32.net> with
	7	the help of Jean Delvare <khali@linux-fr.org>
	8
	9	This program is free software; you can redistribute it and/or modify
	10	it under the terms of the GNU General Public License as published by
	11	the Free Software Foundation; either version 2 of the License, or
	12	(at your option) any later version.
	13
	14	This program is distributed in the hope that it will be useful,
	15	but WITHOUT ANY WARRANTY; without even the implied warranty of
	16	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	17	GNU General Public License for more details.
	18
	19	You should have received a copy of the GNU General Public License
	20	along with this program; if not, write to the Free Software
	21	Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
	22	*/
	23
	24	#include <linux/module.h>
	25	#include <linux/init.h>
	26	#include <linux/slab.h>
	27	#include <linux/jiffies.h>
	28	#include <linux/i2c.h>
943b0830	29	#include <linux/hwmon.h>
46a2e71c	30	#include <linux/hwmon-sysfs.h>
943b0830	31	#include <linux/err.h>
9a61bf63	32	#include <linux/mutex.h>
a5ebe668	33	#include <linux/sysfs.h>
1da177e4 LT	34	#include "lm75.h"
	35
	36	/* Addresses to scan */
	37	static unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b, 0x4c,
	38	0x4d, 0x4e, 0x4f, I2C_CLIENT_END };
1da177e4 LT	39
1da177e4 LT	40	/* Insmod parameters */
f4b50261	41	I2C_CLIENT_INSMOD_1(ds1621);
1da177e4 LT	42	static int polarity = -1;
	43	module_param(polarity, int, 0);
	44	MODULE_PARM_DESC(polarity, "Output's polarity: 0 = active high, 1 = active low");
	45
	46	/* Many DS1621 constants specified below */
	47	/* Config register used for detection */
	48	/* 7 6 5 4 3 2 1 0 */
	49	/* \|Done\|THF \|TLF \|NVB \| X \| X \|POL \|1SHOT\| */
	50	#define DS1621_REG_CONFIG_NVB 0x10
	51	#define DS1621_REG_CONFIG_POLARITY 0x02
	52	#define DS1621_REG_CONFIG_1SHOT 0x01
	53	#define DS1621_REG_CONFIG_DONE 0x80
	54
	55	/* The DS1621 registers */
46a2e71c JD	56	static const u8 DS1621_REG_TEMP[3] = {
	57	0xAA, /* input, word, RO */
	58	0xA2, /* min, word, RW */
	59	0xA1, /* max, word, RW */
	60	};
1da177e4 LT	61	#define DS1621_REG_CONF 0xAC /* byte, RW */
	62	#define DS1621_COM_START 0xEE /* no data */
	63	#define DS1621_COM_STOP 0x22 /* no data */
	64
	65	/* The DS1621 configuration register */
	66	#define DS1621_ALARM_TEMP_HIGH 0x40
	67	#define DS1621_ALARM_TEMP_LOW 0x20
	68
75819f01	69	/* Conversions */
1da177e4 LT	70	#define ALARMS_FROM_REG(val) ((val) & \
	71	(DS1621_ALARM_TEMP_HIGH \| DS1621_ALARM_TEMP_LOW))
	72
	73	/* Each client has this additional data */
	74	struct ds1621_data {
	75	struct i2c_client client;
1beeffe4	76	struct device *hwmon_dev;
9a61bf63	77	struct mutex update_lock;
1da177e4 LT	78	char valid; /* !=0 if following fields are valid */
	79	unsigned long last_updated; /* In jiffies */
	80
46a2e71c	81	u16 temp[3]; /* Register values, word */
1da177e4 LT	82	u8 conf; /* Register encoding, combined */
	83	};
	84
	85	static int ds1621_attach_adapter(struct i2c_adapter *adapter);
	86	static int ds1621_detect(struct i2c_adapter *adapter, int address,
	87	int kind);
	88	static void ds1621_init_client(struct i2c_client *client);
	89	static int ds1621_detach_client(struct i2c_client *client);
	90	static struct ds1621_data ds1621_update_client(struct device dev);
	91
	92	/* This is the driver that will be inserted */
	93	static struct i2c_driver ds1621_driver = {
cdaf7934	94	.driver = {
cdaf7934 LR	95	.name = "ds1621",
cdaf7934 LR	96	},
1da177e4 LT	97	.attach_adapter = ds1621_attach_adapter,
	98	.detach_client = ds1621_detach_client,
	99	};
	100
	101	/* All registers are word-sized, except for the configuration register.
	102	DS1621 uses a high-byte first convention, which is exactly opposite to
75819f01	103	the SMBus standard. */
1da177e4 LT	104	static int ds1621_read_value(struct i2c_client *client, u8 reg)
	105	{
	106	if (reg == DS1621_REG_CONF)
	107	return i2c_smbus_read_byte_data(client, reg);
	108	else
	109	return swab16(i2c_smbus_read_word_data(client, reg));
	110	}
	111
1da177e4 LT	112	static int ds1621_write_value(struct i2c_client *client, u8 reg, u16 value)
	113	{
	114	if (reg == DS1621_REG_CONF)
	115	return i2c_smbus_write_byte_data(client, reg, value);
	116	else
	117	return i2c_smbus_write_word_data(client, reg, swab16(value));
	118	}
	119
	120	static void ds1621_init_client(struct i2c_client *client)
	121	{
	122	int reg = ds1621_read_value(client, DS1621_REG_CONF);
44bbe87e	123	/* switch to continuous conversion mode */
1da177e4 LT	124	reg &= ~ DS1621_REG_CONFIG_1SHOT;
	125
	126	/* setup output polarity */
	127	if (polarity == 0)
	128	reg &= ~DS1621_REG_CONFIG_POLARITY;
	129	else if (polarity == 1)
	130	reg \|= DS1621_REG_CONFIG_POLARITY;
	131
	132	ds1621_write_value(client, DS1621_REG_CONF, reg);
	133
	134	/* start conversion */
	135	i2c_smbus_write_byte(client, DS1621_COM_START);
	136	}
	137
46a2e71c JD	138	static ssize_t show_temp(struct device dev, struct device_attribute da,
	139	char *buf)
	140	{
	141	struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
	142	struct ds1621_data *data = ds1621_update_client(dev);
	143	return sprintf(buf, "%d\n",
	144	LM75_TEMP_FROM_REG(data->temp[attr->index]));
1da177e4 LT	145	}
1da177e4 LT	146
46a2e71c JD	147	static ssize_t set_temp(struct device dev, struct device_attribute da,
	148	const char *buf, size_t count)
	149	{
	150	struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
	151	struct i2c_client *client = to_i2c_client(dev);
	152	struct ds1621_data *data = ds1621_update_client(dev);
5bfedac0	153	u16 val = LM75_TEMP_TO_REG(simple_strtol(buf, NULL, 10));
1da177e4	154
46a2e71c JD	155	mutex_lock(&data->update_lock);
	156	data->temp[attr->index] = val;
	157	ds1621_write_value(client, DS1621_REG_TEMP[attr->index],
	158	data->temp[attr->index]);
	159	mutex_unlock(&data->update_lock);
	160	return count;
	161	}
1da177e4	162
46a2e71c JD	163	static ssize_t show_alarms(struct device dev, struct device_attribute da,
46a2e71c JD	164	char *buf)
1da177e4 LT	165	{
	166	struct ds1621_data *data = ds1621_update_client(dev);
	167	return sprintf(buf, "%d\n", ALARMS_FROM_REG(data->conf));
	168	}
	169
87f0f31b JD	170	static ssize_t show_alarm(struct device dev, struct device_attribute da,
	171	char *buf)
	172	{
	173	struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
	174	struct ds1621_data *data = ds1621_update_client(dev);
	175	return sprintf(buf, "%d\n", !!(data->conf & attr->index));
	176	}
	177
1da177e4	178	static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
46a2e71c JD	179	static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL, 0);
	180	static SENSOR_DEVICE_ATTR(temp1_min, S_IWUSR \| S_IRUGO, show_temp, set_temp, 1);
	181	static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR \| S_IRUGO, show_temp, set_temp, 2);
87f0f31b JD	182	static SENSOR_DEVICE_ATTR(temp1_min_alarm, S_IRUGO, show_alarm, NULL,
	183	DS1621_ALARM_TEMP_LOW);
	184	static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_alarm, NULL,
	185	DS1621_ALARM_TEMP_HIGH);
1da177e4	186
a5ebe668	187	static struct attribute *ds1621_attributes[] = {
46a2e71c JD	188	&sensor_dev_attr_temp1_input.dev_attr.attr,
	189	&sensor_dev_attr_temp1_min.dev_attr.attr,
	190	&sensor_dev_attr_temp1_max.dev_attr.attr,
87f0f31b JD	191	&sensor_dev_attr_temp1_min_alarm.dev_attr.attr,
87f0f31b JD	192	&sensor_dev_attr_temp1_max_alarm.dev_attr.attr,
a5ebe668 JD	193	&dev_attr_alarms.attr,
	194	NULL
	195	};
	196
	197	static const struct attribute_group ds1621_group = {
	198	.attrs = ds1621_attributes,
	199	};
	200
1da177e4 LT	201
	202	static int ds1621_attach_adapter(struct i2c_adapter *adapter)
	203	{
ddec748f JD	204	if (!(adapter->class & I2C_CLASS_HWMON))
ddec748f JD	205	return 0;
2ed2dc3c	206	return i2c_probe(adapter, &addr_data, ds1621_detect);
1da177e4 LT	207	}
1da177e4 LT	208
2ed2dc3c	209	/* This function is called by i2c_probe */
c49efcef BD	210	static int ds1621_detect(struct i2c_adapter *adapter, int address,
c49efcef BD	211	int kind)
1da177e4 LT	212	{
1da177e4 LT	213	int conf, temp;
75819f01	214	struct i2c_client *client;
1da177e4	215	struct ds1621_data *data;
46a2e71c	216	int i, err = 0;
1da177e4 LT	217
	218	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA
	219	\| I2C_FUNC_SMBUS_WORD_DATA
	220	\| I2C_FUNC_SMBUS_WRITE_BYTE))
	221	goto exit;
	222
	223	/* OK. For now, we presume we have a valid client. We now create the
	224	client structure, even though we cannot fill it completely yet.
	225	But it allows us to access ds1621_{read,write}_value. */
ba9c2e8d	226	if (!(data = kzalloc(sizeof(struct ds1621_data), GFP_KERNEL))) {
1da177e4 LT	227	err = -ENOMEM;
	228	goto exit;
	229	}
1da177e4	230
75819f01 JD	231	client = &data->client;
	232	i2c_set_clientdata(client, data);
	233	client->addr = address;
	234	client->adapter = adapter;
	235	client->driver = &ds1621_driver;
1da177e4 LT	236
	237	/* Now, we do the remaining detection. It is lousy. */
	238	if (kind < 0) {
	239	/* The NVB bit should be low if no EEPROM write has been
	240	requested during the latest 10ms, which is highly
	241	improbable in our case. */
75819f01	242	conf = ds1621_read_value(client, DS1621_REG_CONF);
1da177e4 LT	243	if (conf & DS1621_REG_CONFIG_NVB)
	244	goto exit_free;
	245	/* The 7 lowest bits of a temperature should always be 0. */
46a2e71c JD	246	for (i = 0; i < ARRAY_SIZE(data->temp); i++) {
	247	temp = ds1621_read_value(client, DS1621_REG_TEMP[i]);
	248	if (temp & 0x007f)
	249	goto exit_free;
	250	}
1da177e4 LT	251	}
1da177e4 LT	252
1da177e4	253	/* Fill in remaining client fields and put it into the global list */
75819f01	254	strlcpy(client->name, "ds1621", I2C_NAME_SIZE);
9a61bf63	255	mutex_init(&data->update_lock);
1da177e4 LT	256
1da177e4 LT	257	/* Tell the I2C layer a new client has arrived */
75819f01	258	if ((err = i2c_attach_client(client)))
1da177e4 LT	259	goto exit_free;
	260
	261	/* Initialize the DS1621 chip */
75819f01	262	ds1621_init_client(client);
1da177e4 LT	263
1da177e4 LT	264	/* Register sysfs hooks */
75819f01	265	if ((err = sysfs_create_group(&client->dev.kobj, &ds1621_group)))
a5ebe668 JD	266	goto exit_detach;
a5ebe668 JD	267
1beeffe4 TJ	268	data->hwmon_dev = hwmon_device_register(&client->dev);
	269	if (IS_ERR(data->hwmon_dev)) {
	270	err = PTR_ERR(data->hwmon_dev);
a5ebe668	271	goto exit_remove_files;
943b0830 MH	272	}
943b0830 MH	273
1da177e4 LT	274	return 0;
1da177e4 LT	275
a5ebe668	276	exit_remove_files:
75819f01	277	sysfs_remove_group(&client->dev.kobj, &ds1621_group);
943b0830	278	exit_detach:
75819f01	279	i2c_detach_client(client);
1da177e4 LT	280	exit_free:
	281	kfree(data);
	282	exit:
	283	return err;
	284	}
	285
	286	static int ds1621_detach_client(struct i2c_client *client)
	287	{
943b0830	288	struct ds1621_data *data = i2c_get_clientdata(client);
1da177e4 LT	289	int err;
1da177e4 LT	290
1beeffe4	291	hwmon_device_unregister(data->hwmon_dev);
a5ebe668	292	sysfs_remove_group(&client->dev.kobj, &ds1621_group);
943b0830	293
7bef5594	294	if ((err = i2c_detach_client(client)))
1da177e4	295	return err;
1da177e4	296
943b0830	297	kfree(data);
1da177e4 LT	298
	299	return 0;
	300	}
	301
	302
	303	static struct ds1621_data ds1621_update_client(struct device dev)
	304	{
	305	struct i2c_client *client = to_i2c_client(dev);
	306	struct ds1621_data *data = i2c_get_clientdata(client);
	307	u8 new_conf;
	308
9a61bf63	309	mutex_lock(&data->update_lock);
1da177e4 LT	310
	311	if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
	312	\|\| !data->valid) {
46a2e71c	313	int i;
1da177e4 LT	314
	315	dev_dbg(&client->dev, "Starting ds1621 update\n");
	316
	317	data->conf = ds1621_read_value(client, DS1621_REG_CONF);
	318
46a2e71c JD	319	for (i = 0; i < ARRAY_SIZE(data->temp); i++)
	320	data->temp[i] = ds1621_read_value(client,
	321	DS1621_REG_TEMP[i]);
1da177e4	322
44bbe87e	323	/* reset alarms if necessary */
1da177e4	324	new_conf = data->conf;
46a2e71c	325	if (data->temp[0] > data->temp[1]) /* input > min */
1da177e4	326	new_conf &= ~DS1621_ALARM_TEMP_LOW;
46a2e71c	327	if (data->temp[0] < data->temp[2]) /* input < max */
1da177e4 LT	328	new_conf &= ~DS1621_ALARM_TEMP_HIGH;
	329	if (data->conf != new_conf)
	330	ds1621_write_value(client, DS1621_REG_CONF,
	331	new_conf);
	332
	333	data->last_updated = jiffies;
	334	data->valid = 1;
	335	}
	336
9a61bf63	337	mutex_unlock(&data->update_lock);
1da177e4 LT	338
	339	return data;
	340	}
	341
	342	static int __init ds1621_init(void)
	343	{
	344	return i2c_add_driver(&ds1621_driver);
	345	}
	346
	347	static void __exit ds1621_exit(void)
	348	{
	349	i2c_del_driver(&ds1621_driver);
	350	}
	351
	352
	353	MODULE_AUTHOR("Christian W. Zuckschwerdt <zany@triq.net>");
	354	MODULE_DESCRIPTION("DS1621 driver");
	355	MODULE_LICENSE("GPL");
	356
	357	module_init(ds1621_init);
	358	module_exit(ds1621_exit);