phy: Clean coding style in vitesse phy
[deliverable/linux.git] / drivers / net / phy / vitesse.c
CommitLineData
ef82a306
JL
1/*
2 * Driver for Vitesse PHYs
3 *
4 * Author: Kriston Carson
5 *
fddf86fc 6 * Copyright (c) 2005, 2009 Freescale Semiconductor, Inc.
ef82a306
JL
7 *
8 * This program is free software; you can redistribute it and/or modify it
9 * under the terms of the GNU General Public License as published by the
10 * Free Software Foundation; either version 2 of the License, or (at your
11 * option) any later version.
12 *
13 */
14
ef82a306
JL
15#include <linux/kernel.h>
16#include <linux/module.h>
17#include <linux/mii.h>
18#include <linux/ethtool.h>
19#include <linux/phy.h>
20
21/* Vitesse Extended Control Register 1 */
22#define MII_VSC8244_EXT_CON1 0x17
23#define MII_VSC8244_EXTCON1_INIT 0x0000
af2d940d
AF
24#define MII_VSC8244_EXTCON1_TX_SKEW_MASK 0x0c00
25#define MII_VSC8244_EXTCON1_RX_SKEW_MASK 0x0300
26#define MII_VSC8244_EXTCON1_TX_SKEW 0x0800
27#define MII_VSC8244_EXTCON1_RX_SKEW 0x0200
ef82a306
JL
28
29/* Vitesse Interrupt Mask Register */
30#define MII_VSC8244_IMASK 0x19
31#define MII_VSC8244_IMASK_IEN 0x8000
32#define MII_VSC8244_IMASK_SPEED 0x4000
33#define MII_VSC8244_IMASK_LINK 0x2000
34#define MII_VSC8244_IMASK_DUPLEX 0x1000
35#define MII_VSC8244_IMASK_MASK 0xf000
36
11c6dd2c
TP
37#define MII_VSC8221_IMASK_MASK 0xa000
38
ef82a306
JL
39/* Vitesse Interrupt Status Register */
40#define MII_VSC8244_ISTAT 0x1a
41#define MII_VSC8244_ISTAT_STATUS 0x8000
42#define MII_VSC8244_ISTAT_SPEED 0x4000
43#define MII_VSC8244_ISTAT_LINK 0x2000
44#define MII_VSC8244_ISTAT_DUPLEX 0x1000
45
46/* Vitesse Auxiliary Control/Status Register */
2a8626d1
MS
47#define MII_VSC8244_AUX_CONSTAT 0x1c
48#define MII_VSC8244_AUXCONSTAT_INIT 0x0000
49#define MII_VSC8244_AUXCONSTAT_DUPLEX 0x0020
50#define MII_VSC8244_AUXCONSTAT_SPEED 0x0018
51#define MII_VSC8244_AUXCONSTAT_GBIT 0x0010
52#define MII_VSC8244_AUXCONSTAT_100 0x0008
ef82a306 53
11c6dd2c
TP
54#define MII_VSC8221_AUXCONSTAT_INIT 0x0004 /* need to set this bit? */
55#define MII_VSC8221_AUXCONSTAT_RESERVED 0x0004
56
57#define PHY_ID_VSC8244 0x000fc6c0
58#define PHY_ID_VSC8221 0x000fc550
59
ef82a306
JL
60MODULE_DESCRIPTION("Vitesse PHY driver");
61MODULE_AUTHOR("Kriston Carson");
62MODULE_LICENSE("GPL");
63
baec126c 64static int vsc824x_add_skew(struct phy_device *phydev)
ef82a306
JL
65{
66 int err;
fddf86fc 67 int extcon;
ef82a306 68
af2d940d
AF
69 extcon = phy_read(phydev, MII_VSC8244_EXT_CON1);
70
71 if (extcon < 0)
fddf86fc 72 return extcon;
af2d940d
AF
73
74 extcon &= ~(MII_VSC8244_EXTCON1_TX_SKEW_MASK |
75 MII_VSC8244_EXTCON1_RX_SKEW_MASK);
76
fddf86fc
AF
77 extcon |= (MII_VSC8244_EXTCON1_TX_SKEW |
78 MII_VSC8244_EXTCON1_RX_SKEW);
af2d940d
AF
79
80 err = phy_write(phydev, MII_VSC8244_EXT_CON1, extcon);
81
ef82a306
JL
82 return err;
83}
fddf86fc
AF
84
85static int vsc824x_config_init(struct phy_device *phydev)
86{
87 int err;
88
89 err = phy_write(phydev, MII_VSC8244_AUX_CONSTAT,
90 MII_VSC8244_AUXCONSTAT_INIT);
91 if (err < 0)
92 return err;
93
94 if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
95 err = vsc824x_add_skew(phydev);
96
97 return err;
98}
ef82a306
JL
99
100static int vsc824x_ack_interrupt(struct phy_device *phydev)
101{
1d5e83aa 102 int err = 0;
2a8626d1
MS
103
104 /* Don't bother to ACK the interrupts if interrupts
1d5e83aa
AF
105 * are disabled. The 824x cannot clear the interrupts
106 * if they are disabled.
107 */
108 if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
109 err = phy_read(phydev, MII_VSC8244_ISTAT);
ef82a306
JL
110
111 return (err < 0) ? err : 0;
112}
113
11c6dd2c 114static int vsc82xx_config_intr(struct phy_device *phydev)
ef82a306
JL
115{
116 int err;
117
118 if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
119 err = phy_write(phydev, MII_VSC8244_IMASK,
11c6dd2c
TP
120 phydev->drv->phy_id == PHY_ID_VSC8244 ?
121 MII_VSC8244_IMASK_MASK :
122 MII_VSC8221_IMASK_MASK);
1d5e83aa 123 else {
2a8626d1 124 /* The Vitesse PHY cannot clear the interrupt
1d5e83aa
AF
125 * once it has disabled them, so we clear them first
126 */
127 err = phy_read(phydev, MII_VSC8244_ISTAT);
128
52cb1c2b 129 if (err < 0)
1d5e83aa
AF
130 return err;
131
ef82a306 132 err = phy_write(phydev, MII_VSC8244_IMASK, 0);
1d5e83aa
AF
133 }
134
ef82a306
JL
135 return err;
136}
137
11c6dd2c 138static int vsc8221_config_init(struct phy_device *phydev)
ef82a306 139{
11c6dd2c
TP
140 int err;
141
142 err = phy_write(phydev, MII_VSC8244_AUX_CONSTAT,
143 MII_VSC8221_AUXCONSTAT_INIT);
144 return err;
145
146 /* Perhaps we should set EXT_CON1 based on the interface?
2a8626d1
MS
147 * Options are 802.3Z SerDes or SGMII
148 */
11c6dd2c
TP
149}
150
d5bf9071
CH
151/* Vitesse 824x */
152static struct phy_driver vsc82xx_driver[] = {
153{
154 .phy_id = PHY_ID_VSC8244,
155 .name = "Vitesse VSC8244",
156 .phy_id_mask = 0x000fffc0,
157 .features = PHY_GBIT_FEATURES,
158 .flags = PHY_HAS_INTERRUPT,
159 .config_init = &vsc824x_config_init,
160 .config_aneg = &genphy_config_aneg,
161 .read_status = &genphy_read_status,
162 .ack_interrupt = &vsc824x_ack_interrupt,
163 .config_intr = &vsc82xx_config_intr,
164 .driver = { .owner = THIS_MODULE,},
165}, {
166 /* Vitesse 8221 */
11c6dd2c
TP
167 .phy_id = PHY_ID_VSC8221,
168 .phy_id_mask = 0x000ffff0,
169 .name = "Vitesse VSC8221",
170 .features = PHY_GBIT_FEATURES,
171 .flags = PHY_HAS_INTERRUPT,
172 .config_init = &vsc8221_config_init,
173 .config_aneg = &genphy_config_aneg,
174 .read_status = &genphy_read_status,
175 .ack_interrupt = &vsc824x_ack_interrupt,
176 .config_intr = &vsc82xx_config_intr,
d5bf9071
CH
177 .driver = { .owner = THIS_MODULE,},
178} };
11c6dd2c
TP
179
180static int __init vsc82xx_init(void)
181{
d5bf9071
CH
182 return phy_drivers_register(vsc82xx_driver,
183 ARRAY_SIZE(vsc82xx_driver));
ef82a306
JL
184}
185
11c6dd2c 186static void __exit vsc82xx_exit(void)
ef82a306 187{
d5bf9071
CH
188 return phy_drivers_unregister(vsc82xx_driver,
189 ARRAY_SIZE(vsc82xx_driver));
ef82a306
JL
190}
191
11c6dd2c
TP
192module_init(vsc82xx_init);
193module_exit(vsc82xx_exit);
4e4f10f6 194
cf93c945 195static struct mdio_device_id __maybe_unused vitesse_tbl[] = {
4e4f10f6
DW
196 { PHY_ID_VSC8244, 0x000fffc0 },
197 { PHY_ID_VSC8221, 0x000ffff0 },
198 { }
199};
200
201MODULE_DEVICE_TABLE(mdio, vitesse_tbl);
This page took 0.811435 seconds and 5 git commands to generate.