Commit | Line | Data |
---|---|---|
1da177e4 | 1 | /* |
3e57ecf6 | 2 | * Copyright (c) 2000-2006 Silicon Graphics, Inc. |
7b718769 | 3 | * All Rights Reserved. |
1da177e4 | 4 | * |
7b718769 NS |
5 | * This program is free software; you can redistribute it and/or |
6 | * modify it under the terms of the GNU General Public License as | |
1da177e4 LT |
7 | * published by the Free Software Foundation. |
8 | * | |
7b718769 NS |
9 | * This program is distributed in the hope that it would be useful, |
10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | |
11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
12 | * GNU General Public License for more details. | |
1da177e4 | 13 | * |
7b718769 NS |
14 | * You should have received a copy of the GNU General Public License |
15 | * along with this program; if not, write the Free Software Foundation, | |
16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | |
1da177e4 | 17 | */ |
1da177e4 | 18 | #include "xfs.h" |
a844f451 | 19 | #include "xfs_fs.h" |
1da177e4 | 20 | #include "xfs_types.h" |
1da177e4 LT |
21 | #include "xfs_log.h" |
22 | #include "xfs_trans.h" | |
23 | #include "xfs_sb.h" | |
a844f451 | 24 | #include "xfs_ag.h" |
1da177e4 | 25 | #include "xfs_mount.h" |
1da177e4 | 26 | #include "xfs_bmap_btree.h" |
1da177e4 | 27 | #include "xfs_dinode.h" |
1da177e4 | 28 | #include "xfs_inode.h" |
a844f451 | 29 | #include "xfs_inode_item.h" |
1da177e4 | 30 | #include "xfs_bmap.h" |
1da177e4 LT |
31 | #include "xfs_itable.h" |
32 | #include "xfs_dfrag.h" | |
33 | #include "xfs_error.h" | |
739bfb2a | 34 | #include "xfs_vnodeops.h" |
0b1b213f | 35 | #include "xfs_trace.h" |
1da177e4 | 36 | |
6bded0f3 DC |
37 | |
38 | static int xfs_swap_extents( | |
39 | xfs_inode_t *ip, /* target inode */ | |
40 | xfs_inode_t *tip, /* tmp inode */ | |
41 | xfs_swapext_t *sxp); | |
42 | ||
1da177e4 | 43 | /* |
6bded0f3 | 44 | * ioctl interface for swapext |
1da177e4 LT |
45 | */ |
46 | int | |
47 | xfs_swapext( | |
743bb465 | 48 | xfs_swapext_t *sxp) |
1da177e4 | 49 | { |
35fec8df | 50 | xfs_inode_t *ip, *tip; |
6bded0f3 | 51 | struct file *file, *tmp_file; |
1da177e4 | 52 | int error = 0; |
1da177e4 | 53 | |
1da177e4 | 54 | /* Pull information for the target fd */ |
35fec8df CH |
55 | file = fget((int)sxp->sx_fdtarget); |
56 | if (!file) { | |
1da177e4 | 57 | error = XFS_ERROR(EINVAL); |
ac12b4e2 | 58 | goto out; |
1da177e4 LT |
59 | } |
60 | ||
1817176a DR |
61 | if (!(file->f_mode & FMODE_WRITE) || |
62 | !(file->f_mode & FMODE_READ) || | |
63 | (file->f_flags & O_APPEND)) { | |
f6aa7f21 CH |
64 | error = XFS_ERROR(EBADF); |
65 | goto out_put_file; | |
66 | } | |
67 | ||
6bded0f3 DC |
68 | tmp_file = fget((int)sxp->sx_fdtmp); |
69 | if (!tmp_file) { | |
1da177e4 | 70 | error = XFS_ERROR(EINVAL); |
35fec8df | 71 | goto out_put_file; |
1da177e4 LT |
72 | } |
73 | ||
6bded0f3 | 74 | if (!(tmp_file->f_mode & FMODE_WRITE) || |
1817176a | 75 | !(tmp_file->f_mode & FMODE_READ) || |
6bded0f3 | 76 | (tmp_file->f_flags & O_APPEND)) { |
f6aa7f21 | 77 | error = XFS_ERROR(EBADF); |
6bded0f3 | 78 | goto out_put_tmp_file; |
f6aa7f21 CH |
79 | } |
80 | ||
7c8f7af6 | 81 | if (IS_SWAPFILE(file->f_path.dentry->d_inode) || |
6bded0f3 | 82 | IS_SWAPFILE(tmp_file->f_path.dentry->d_inode)) { |
7c8f7af6 | 83 | error = XFS_ERROR(EINVAL); |
6bded0f3 | 84 | goto out_put_tmp_file; |
7c8f7af6 CH |
85 | } |
86 | ||
35fec8df | 87 | ip = XFS_I(file->f_path.dentry->d_inode); |
6bded0f3 | 88 | tip = XFS_I(tmp_file->f_path.dentry->d_inode); |
1da177e4 LT |
89 | |
90 | if (ip->i_mount != tip->i_mount) { | |
35fec8df | 91 | error = XFS_ERROR(EINVAL); |
6bded0f3 | 92 | goto out_put_tmp_file; |
1da177e4 LT |
93 | } |
94 | ||
95 | if (ip->i_ino == tip->i_ino) { | |
35fec8df | 96 | error = XFS_ERROR(EINVAL); |
6bded0f3 | 97 | goto out_put_tmp_file; |
1da177e4 LT |
98 | } |
99 | ||
35fec8df CH |
100 | if (XFS_FORCED_SHUTDOWN(ip->i_mount)) { |
101 | error = XFS_ERROR(EIO); | |
6bded0f3 | 102 | goto out_put_tmp_file; |
1da177e4 LT |
103 | } |
104 | ||
541d7d3c | 105 | error = xfs_swap_extents(ip, tip, sxp); |
3e57ecf6 | 106 | |
6bded0f3 DC |
107 | out_put_tmp_file: |
108 | fput(tmp_file); | |
35fec8df CH |
109 | out_put_file: |
110 | fput(file); | |
35fec8df | 111 | out: |
3e57ecf6 OW |
112 | return error; |
113 | } | |
114 | ||
e09f9860 DC |
115 | /* |
116 | * We need to check that the format of the data fork in the temporary inode is | |
117 | * valid for the target inode before doing the swap. This is not a problem with | |
118 | * attr1 because of the fixed fork offset, but attr2 has a dynamically sized | |
119 | * data fork depending on the space the attribute fork is taking so we can get | |
120 | * invalid formats on the target inode. | |
121 | * | |
122 | * E.g. target has space for 7 extents in extent format, temp inode only has | |
123 | * space for 6. If we defragment down to 7 extents, then the tmp format is a | |
124 | * btree, but when swapped it needs to be in extent format. Hence we can't just | |
125 | * blindly swap data forks on attr2 filesystems. | |
126 | * | |
127 | * Note that we check the swap in both directions so that we don't end up with | |
128 | * a corrupt temporary inode, either. | |
129 | * | |
130 | * Note that fixing the way xfs_fsr sets up the attribute fork in the source | |
131 | * inode will prevent this situation from occurring, so all we do here is | |
132 | * reject and log the attempt. basically we are putting the responsibility on | |
133 | * userspace to get this right. | |
134 | */ | |
135 | static int | |
136 | xfs_swap_extents_check_format( | |
137 | xfs_inode_t *ip, /* target inode */ | |
138 | xfs_inode_t *tip) /* tmp inode */ | |
139 | { | |
140 | ||
141 | /* Should never get a local format */ | |
142 | if (ip->i_d.di_format == XFS_DINODE_FMT_LOCAL || | |
143 | tip->i_d.di_format == XFS_DINODE_FMT_LOCAL) | |
144 | return EINVAL; | |
145 | ||
146 | /* | |
147 | * if the target inode has less extents that then temporary inode then | |
148 | * why did userspace call us? | |
149 | */ | |
150 | if (ip->i_d.di_nextents < tip->i_d.di_nextents) | |
151 | return EINVAL; | |
152 | ||
153 | /* | |
154 | * if the target inode is in extent form and the temp inode is in btree | |
155 | * form then we will end up with the target inode in the wrong format | |
156 | * as we already know there are less extents in the temp inode. | |
157 | */ | |
158 | if (ip->i_d.di_format == XFS_DINODE_FMT_EXTENTS && | |
159 | tip->i_d.di_format == XFS_DINODE_FMT_BTREE) | |
160 | return EINVAL; | |
161 | ||
162 | /* Check temp in extent form to max in target */ | |
163 | if (tip->i_d.di_format == XFS_DINODE_FMT_EXTENTS && | |
8096b1eb CH |
164 | XFS_IFORK_NEXTENTS(tip, XFS_DATA_FORK) > |
165 | XFS_IFORK_MAXEXT(ip, XFS_DATA_FORK)) | |
e09f9860 DC |
166 | return EINVAL; |
167 | ||
168 | /* Check target in extent form to max in temp */ | |
169 | if (ip->i_d.di_format == XFS_DINODE_FMT_EXTENTS && | |
8096b1eb CH |
170 | XFS_IFORK_NEXTENTS(ip, XFS_DATA_FORK) > |
171 | XFS_IFORK_MAXEXT(tip, XFS_DATA_FORK)) | |
e09f9860 DC |
172 | return EINVAL; |
173 | ||
dd77ef92 DC |
174 | /* |
175 | * If we are in a btree format, check that the temp root block will fit | |
176 | * in the target and that it has enough extents to be in btree format | |
177 | * in the target. | |
178 | * | |
179 | * Note that we have to be careful to allow btree->extent conversions | |
180 | * (a common defrag case) which will occur when the temp inode is in | |
181 | * extent format... | |
182 | */ | |
8096b1eb CH |
183 | if (tip->i_d.di_format == XFS_DINODE_FMT_BTREE) { |
184 | if (XFS_IFORK_BOFF(ip) && | |
185 | tip->i_df.if_broot_bytes > XFS_IFORK_BOFF(ip)) | |
186 | return EINVAL; | |
187 | if (XFS_IFORK_NEXTENTS(tip, XFS_DATA_FORK) <= | |
188 | XFS_IFORK_MAXEXT(ip, XFS_DATA_FORK)) | |
189 | return EINVAL; | |
190 | } | |
e09f9860 | 191 | |
dd77ef92 | 192 | /* Reciprocal target->temp btree format checks */ |
8096b1eb CH |
193 | if (ip->i_d.di_format == XFS_DINODE_FMT_BTREE) { |
194 | if (XFS_IFORK_BOFF(tip) && | |
195 | ip->i_df.if_broot_bytes > XFS_IFORK_BOFF(tip)) | |
196 | return EINVAL; | |
197 | ||
198 | if (XFS_IFORK_NEXTENTS(ip, XFS_DATA_FORK) <= | |
199 | XFS_IFORK_MAXEXT(tip, XFS_DATA_FORK)) | |
200 | return EINVAL; | |
201 | } | |
e09f9860 DC |
202 | |
203 | return 0; | |
204 | } | |
205 | ||
6bded0f3 | 206 | static int |
3e57ecf6 | 207 | xfs_swap_extents( |
e09f9860 DC |
208 | xfs_inode_t *ip, /* target inode */ |
209 | xfs_inode_t *tip, /* tmp inode */ | |
3e57ecf6 OW |
210 | xfs_swapext_t *sxp) |
211 | { | |
45c51b99 | 212 | xfs_mount_t *mp = ip->i_mount; |
3e57ecf6 OW |
213 | xfs_trans_t *tp; |
214 | xfs_bstat_t *sbp = &sxp->sx_stat; | |
3e57ecf6 | 215 | xfs_ifork_t *tempifp, *ifp, *tifp; |
f5d8d5c4 | 216 | int src_log_flags, target_log_flags; |
3e57ecf6 OW |
217 | int error = 0; |
218 | int aforkblks = 0; | |
219 | int taforkblks = 0; | |
220 | __uint64_t tmp; | |
3e57ecf6 | 221 | |
3e57ecf6 OW |
222 | tempifp = kmem_alloc(sizeof(xfs_ifork_t), KM_MAYFAIL); |
223 | if (!tempifp) { | |
224 | error = XFS_ERROR(ENOMEM); | |
ef8f7fc5 | 225 | goto out; |
3e57ecf6 OW |
226 | } |
227 | ||
f9114eba DC |
228 | /* |
229 | * we have to do two separate lock calls here to keep lockdep | |
230 | * happy. If we try to get all the locks in one call, lock will | |
231 | * report false positives when we drop the ILOCK and regain them | |
232 | * below. | |
233 | */ | |
234 | xfs_lock_two_inodes(ip, tip, XFS_IOLOCK_EXCL); | |
235 | xfs_lock_two_inodes(ip, tip, XFS_ILOCK_EXCL); | |
1da177e4 | 236 | |
1da177e4 LT |
237 | /* Verify that both files have the same format */ |
238 | if ((ip->i_d.di_mode & S_IFMT) != (tip->i_d.di_mode & S_IFMT)) { | |
239 | error = XFS_ERROR(EINVAL); | |
ef8f7fc5 | 240 | goto out_unlock; |
1da177e4 LT |
241 | } |
242 | ||
243 | /* Verify both files are either real-time or non-realtime */ | |
71ddabb9 | 244 | if (XFS_IS_REALTIME_INODE(ip) != XFS_IS_REALTIME_INODE(tip)) { |
1da177e4 | 245 | error = XFS_ERROR(EINVAL); |
ef8f7fc5 | 246 | goto out_unlock; |
1da177e4 LT |
247 | } |
248 | ||
df80c933 | 249 | if (VN_CACHED(VFS_I(tip)) != 0) { |
739bfb2a CH |
250 | error = xfs_flushinval_pages(tip, 0, -1, |
251 | FI_REMAPF_LOCKED); | |
d3cf2094 | 252 | if (error) |
ef8f7fc5 | 253 | goto out_unlock; |
bd5a876a | 254 | } |
1da177e4 LT |
255 | |
256 | /* Verify O_DIRECT for ftmp */ | |
df80c933 | 257 | if (VN_CACHED(VFS_I(tip)) != 0) { |
1da177e4 | 258 | error = XFS_ERROR(EINVAL); |
ef8f7fc5 | 259 | goto out_unlock; |
1da177e4 LT |
260 | } |
261 | ||
262 | /* Verify all data are being swapped */ | |
d0cfb373 ES |
263 | if (sxp->sx_offset != 0 || |
264 | sxp->sx_length != ip->i_d.di_size || | |
265 | sxp->sx_length != tip->i_d.di_size) { | |
1da177e4 | 266 | error = XFS_ERROR(EFAULT); |
ef8f7fc5 | 267 | goto out_unlock; |
1da177e4 LT |
268 | } |
269 | ||
3a85cd96 DC |
270 | trace_xfs_swap_extent_before(ip, 0); |
271 | trace_xfs_swap_extent_before(tip, 1); | |
272 | ||
e09f9860 DC |
273 | /* check inode formats now that data is flushed */ |
274 | error = xfs_swap_extents_check_format(ip, tip); | |
275 | if (error) { | |
53487786 | 276 | xfs_notice(mp, |
e09f9860 | 277 | "%s: inode 0x%llx format is incompatible for exchanging.", |
53487786 | 278 | __func__, ip->i_ino); |
ef8f7fc5 | 279 | goto out_unlock; |
1da177e4 LT |
280 | } |
281 | ||
282 | /* | |
283 | * Compare the current change & modify times with that | |
284 | * passed in. If they differ, we abort this swap. | |
285 | * This is the mechanism used to ensure the calling | |
286 | * process that the file was not changed out from | |
287 | * under it. | |
288 | */ | |
f9581b14 CH |
289 | if ((sbp->bs_ctime.tv_sec != VFS_I(ip)->i_ctime.tv_sec) || |
290 | (sbp->bs_ctime.tv_nsec != VFS_I(ip)->i_ctime.tv_nsec) || | |
291 | (sbp->bs_mtime.tv_sec != VFS_I(ip)->i_mtime.tv_sec) || | |
292 | (sbp->bs_mtime.tv_nsec != VFS_I(ip)->i_mtime.tv_nsec)) { | |
1da177e4 | 293 | error = XFS_ERROR(EBUSY); |
ef8f7fc5 | 294 | goto out_unlock; |
1da177e4 LT |
295 | } |
296 | ||
297 | /* We need to fail if the file is memory mapped. Once we have tossed | |
298 | * all existing pages, the page fault will have no option | |
299 | * but to go to the filesystem for pages. By making the page fault call | |
67fcaa73 | 300 | * vop_read (or write in the case of autogrow) they block on the iolock |
1da177e4 LT |
301 | * until we have switched the extents. |
302 | */ | |
df80c933 | 303 | if (VN_MAPPED(VFS_I(ip))) { |
1da177e4 | 304 | error = XFS_ERROR(EBUSY); |
ef8f7fc5 | 305 | goto out_unlock; |
1da177e4 LT |
306 | } |
307 | ||
308 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | |
309 | xfs_iunlock(tip, XFS_ILOCK_EXCL); | |
310 | ||
311 | /* | |
312 | * There is a race condition here since we gave up the | |
313 | * ilock. However, the data fork will not change since | |
314 | * we have the iolock (locked for truncation too) so we | |
315 | * are safe. We don't really care if non-io related | |
316 | * fields change. | |
317 | */ | |
318 | ||
739bfb2a | 319 | xfs_tosspages(ip, 0, -1, FI_REMAPF); |
1da177e4 LT |
320 | |
321 | tp = xfs_trans_alloc(mp, XFS_TRANS_SWAPEXT); | |
322 | if ((error = xfs_trans_reserve(tp, 0, | |
323 | XFS_ICHANGE_LOG_RES(mp), 0, | |
324 | 0, 0))) { | |
325 | xfs_iunlock(ip, XFS_IOLOCK_EXCL); | |
326 | xfs_iunlock(tip, XFS_IOLOCK_EXCL); | |
327 | xfs_trans_cancel(tp, 0); | |
ef8f7fc5 | 328 | goto out; |
1da177e4 | 329 | } |
e1cccd91 | 330 | xfs_lock_two_inodes(ip, tip, XFS_ILOCK_EXCL); |
1da177e4 LT |
331 | |
332 | /* | |
333 | * Count the number of extended attribute blocks | |
334 | */ | |
335 | if ( ((XFS_IFORK_Q(ip) != 0) && (ip->i_d.di_anextents > 0)) && | |
336 | (ip->i_d.di_aformat != XFS_DINODE_FMT_LOCAL)) { | |
337 | error = xfs_bmap_count_blocks(tp, ip, XFS_ATTR_FORK, &aforkblks); | |
ef8f7fc5 JJS |
338 | if (error) |
339 | goto out_trans_cancel; | |
1da177e4 LT |
340 | } |
341 | if ( ((XFS_IFORK_Q(tip) != 0) && (tip->i_d.di_anextents > 0)) && | |
342 | (tip->i_d.di_aformat != XFS_DINODE_FMT_LOCAL)) { | |
343 | error = xfs_bmap_count_blocks(tp, tip, XFS_ATTR_FORK, | |
344 | &taforkblks); | |
ef8f7fc5 JJS |
345 | if (error) |
346 | goto out_trans_cancel; | |
1da177e4 LT |
347 | } |
348 | ||
349 | /* | |
350 | * Swap the data forks of the inodes | |
351 | */ | |
352 | ifp = &ip->i_df; | |
353 | tifp = &tip->i_df; | |
d0cfb373 ES |
354 | *tempifp = *ifp; /* struct copy */ |
355 | *ifp = *tifp; /* struct copy */ | |
356 | *tifp = *tempifp; /* struct copy */ | |
1da177e4 LT |
357 | |
358 | /* | |
359 | * Fix the on-disk inode values | |
360 | */ | |
361 | tmp = (__uint64_t)ip->i_d.di_nblocks; | |
362 | ip->i_d.di_nblocks = tip->i_d.di_nblocks - taforkblks + aforkblks; | |
363 | tip->i_d.di_nblocks = tmp + taforkblks - aforkblks; | |
364 | ||
365 | tmp = (__uint64_t) ip->i_d.di_nextents; | |
366 | ip->i_d.di_nextents = tip->i_d.di_nextents; | |
367 | tip->i_d.di_nextents = tmp; | |
368 | ||
369 | tmp = (__uint64_t) ip->i_d.di_format; | |
370 | ip->i_d.di_format = tip->i_d.di_format; | |
371 | tip->i_d.di_format = tmp; | |
372 | ||
309c8480 DC |
373 | /* |
374 | * The extents in the source inode could still contain speculative | |
375 | * preallocation beyond EOF (e.g. the file is open but not modified | |
376 | * while defrag is in progress). In that case, we need to copy over the | |
377 | * number of delalloc blocks the data fork in the source inode is | |
378 | * tracking beyond EOF so that when the fork is truncated away when the | |
379 | * temporary inode is unlinked we don't underrun the i_delayed_blks | |
380 | * counter on that inode. | |
381 | */ | |
382 | ASSERT(tip->i_delayed_blks == 0); | |
383 | tip->i_delayed_blks = ip->i_delayed_blks; | |
384 | ip->i_delayed_blks = 0; | |
385 | ||
f5d8d5c4 CH |
386 | src_log_flags = XFS_ILOG_CORE; |
387 | switch (ip->i_d.di_format) { | |
1da177e4 LT |
388 | case XFS_DINODE_FMT_EXTENTS: |
389 | /* If the extents fit in the inode, fix the | |
390 | * pointer. Otherwise it's already NULL or | |
391 | * pointing to the extent. | |
392 | */ | |
393 | if (ip->i_d.di_nextents <= XFS_INLINE_EXTS) { | |
394 | ifp->if_u1.if_extents = | |
395 | ifp->if_u2.if_inline_ext; | |
396 | } | |
f5d8d5c4 | 397 | src_log_flags |= XFS_ILOG_DEXT; |
1da177e4 LT |
398 | break; |
399 | case XFS_DINODE_FMT_BTREE: | |
f5d8d5c4 | 400 | src_log_flags |= XFS_ILOG_DBROOT; |
1da177e4 LT |
401 | break; |
402 | } | |
403 | ||
f5d8d5c4 CH |
404 | target_log_flags = XFS_ILOG_CORE; |
405 | switch (tip->i_d.di_format) { | |
1da177e4 LT |
406 | case XFS_DINODE_FMT_EXTENTS: |
407 | /* If the extents fit in the inode, fix the | |
408 | * pointer. Otherwise it's already NULL or | |
409 | * pointing to the extent. | |
410 | */ | |
411 | if (tip->i_d.di_nextents <= XFS_INLINE_EXTS) { | |
412 | tifp->if_u1.if_extents = | |
413 | tifp->if_u2.if_inline_ext; | |
414 | } | |
f5d8d5c4 | 415 | target_log_flags |= XFS_ILOG_DEXT; |
1da177e4 LT |
416 | break; |
417 | case XFS_DINODE_FMT_BTREE: | |
f5d8d5c4 | 418 | target_log_flags |= XFS_ILOG_DBROOT; |
1da177e4 LT |
419 | break; |
420 | } | |
421 | ||
1da177e4 | 422 | |
ddc3415a CH |
423 | xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL); |
424 | xfs_trans_ijoin(tp, tip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL); | |
1da177e4 | 425 | |
f5d8d5c4 CH |
426 | xfs_trans_log_inode(tp, ip, src_log_flags); |
427 | xfs_trans_log_inode(tp, tip, target_log_flags); | |
1da177e4 LT |
428 | |
429 | /* | |
430 | * If this is a synchronous mount, make sure that the | |
431 | * transaction goes to disk before returning to the user. | |
432 | */ | |
ef8f7fc5 | 433 | if (mp->m_flags & XFS_MOUNT_WSYNC) |
1da177e4 | 434 | xfs_trans_set_sync(tp); |
1da177e4 | 435 | |
815cb216 | 436 | error = xfs_trans_commit(tp, 0); |
1da177e4 | 437 | |
3a85cd96 DC |
438 | trace_xfs_swap_extent_after(ip, 0); |
439 | trace_xfs_swap_extent_after(tip, 1); | |
ef8f7fc5 JJS |
440 | out: |
441 | kmem_free(tempifp); | |
1da177e4 | 442 | return error; |
ef8f7fc5 | 443 | |
1f23920d FB |
444 | out_unlock: |
445 | xfs_iunlock(ip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL); | |
446 | xfs_iunlock(tip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL); | |
447 | goto out; | |
448 | ||
ef8f7fc5 JJS |
449 | out_trans_cancel: |
450 | xfs_trans_cancel(tp, 0); | |
451 | goto out_unlock; | |
1da177e4 | 452 | } |