Change TUI window commands to be case-sensitive
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
78e8cb91
TT
12019-09-20 Tom Tromey <tom@tromey.com>
2
3 * NEWS: Mention case-sensitivity of TUI commands.
4 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
5 (tui_set_win_height_command, parse_scrolling_args): Likewise.
6 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
7
f074b67e
TT
82019-09-20 Tom Tromey <tom@tromey.com>
9
10 * tui/tui-source.c (tui_source_window::set_contents): Use
11 make_unique_xstrdup.
12 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
13 make_unique_xstrdup.
14
63c4bf19
TT
152019-09-20 Tom Tromey <tom@tromey.com>
16
17 * tui/tui-data.c: Remove separator comments.
18 * tui/tui-layout.c: Remove separator comments.
19 * tui/tui-win.c: Remove separator comments.
20 * tui/tui-wingeneral.c: Remove separator comments.
21
43df9b2f
TT
222019-09-20 Tom Tromey <tom@tromey.com>
23
24 * tui/tui.h (strcat_to_buf): Don't declare.
25 * tui/tui.c (strcat_to_buf): Remove.
26
7226433c
TT
272019-09-20 Tom Tromey <tom@tromey.com>
28
29 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
30 from "fullname".
31 * tui/tui-source.c (tui_source_window::set_contents)
32 (tui_source_window::location_matches_p)
33 (tui_source_window::maybe_update): Update.
34
80df3337
TT
352019-09-20 Tom Tromey <tom@tromey.com>
36
37 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
38 Update.
39 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
40 prefix.
41 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
42 (tui_data_window::line_from_reg_element_no)
43 (tui_data_window::first_reg_element_no_inline)
44 (tui_data_window::show_registers)
45 (tui_data_window::show_register_group)
46 (tui_data_window::display_registers_from)
47 (tui_data_window::display_registers_from_line)
48 (tui_data_window::first_data_item_displayed)
49 (tui_data_window::delete_data_content_windows)
50 (tui_data_window::erase_data_content)
51 (tui_data_window::do_scroll_vertical)
52 (tui_data_window::refresh_window)
53 (tui_data_window::check_register_values): Update.
54
9923f347
TT
552019-09-20 Tom Tromey <tom@tromey.com>
56
57 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
58 (struct tui_locator_window) <full_name, proc_name>: Now
59 std::string.
60 * tui/tui-stack.c (tui_locator_window::make_status_line)
61 (tui_locator_window::set_locator_fullname)
62 (tui_locator_window::set_locator_info): Update.
63 * tui/tui-source.c (tui_source_window::set_contents)
64 (tui_source_window::showing_source_p): Update.
65
b76251ab
TT
662019-09-20 Tom Tromey <tom@tromey.com>
67
68 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
69 Don't call tui_locator_win_info_ptr.
70
0891be08
TT
712019-09-20 Tom Tromey <tom@tromey.com>
72
73 * tui/tui-win.c (tui_resize_all): Don't call refresh.
74
1b935acf
TT
752019-09-20 Tom Tromey <tom@tromey.com>
76
77 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
78 height for locator.
79 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
80 * tui/tui-layout.c (show_source_disasm_command, show_data)
81 (show_source_or_disasm_and_command): Use 1 as height for locator.
82
9abd8a65
TT
832019-09-20 Tom Tromey <tom@tromey.com>
84
85 * tui/tui.c (tui_enable): Update.
86 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
87 Update.
88 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
89 Update.
90 * tui/tui-data.c (win_resized): Now bool.
91 (tui_win_resized): Return bool.
92 (tui_set_win_resized_to): Accept a bool.
93
b5457826
TT
942019-09-20 Tom Tromey <tom@tromey.com>
95
96 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
97 Change type of "refresh_values_only".
98 * tui/tui-regs.c (tui_data_window::show_register_group): Change
99 type of "refresh_values_only".
100
6b915f7d
TT
1012019-09-20 Tom Tromey <tom@tromey.com>
102
103 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
104 std::string.
105 (tui_disassemble): Add "pos" parameter.
106 (tui_disasm_window::set_contents): Simplify.
107
2ad52f6f
TT
1082019-09-20 Tom Tromey <tom@tromey.com>
109
110 * tui/tui-winsource.h (struct tui_source_window_base)
111 <show_source_content>: Now private.
112 * tui/tui-winsource.c
113 (tui_source_window_base::show_source_content): Don't handle empty
114 content case.
115
b3b1bde6
TT
1162019-09-20 Tom Tromey <tom@tromey.com>
117
118 * tui/tui-layout.c (show_source_disasm_command)
119 (show_source_or_disasm_and_command): Don't call
120 show_source_content.
121
71a25ed2
TT
1222019-09-20 Tom Tromey <tom@tromey.com>
123
124 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
125 Declare.
126 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
127 from tui_make_status_line.
128 (tui_locator_window::rerender): Update.
129
f8532154
TT
1302019-09-20 Tom Tromey <tom@tromey.com>
131
132 * tui/tui-stack.c (tui_make_status_line): Return std::string.
133 (tui_locator_window::rerender): Update.
134
2d81b349
TT
1352019-09-20 Tom Tromey <tom@tromey.com>
136
137 * tui/tui-winsource.h (struct tui_source_window_base)
138 <~tui_source_window_base>: Don't declare.
139 <fullname>: Remove.
140 * tui/tui-winsource.c (~tui_source_window_base): Remove.
141 * tui/tui-source.h (struct tui_source_window) <fullname>: New
142 member.
143 * tui/tui-source.c (tui_source_window::set_contents): Update.
144 (tui_source_window::location_matches_p)
145 (tui_source_window::maybe_update): Update.
146
f14bec58
TT
1472019-09-20 Tom Tromey <tom@tromey.com>
148
149 * tui/tui-winsource.h (~tui_source_element): Remove.
150 (tui_source_element): Update.
151 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
152 * tui/tui-winsource.c (tui_show_source_line): Update.
153 * tui/tui-source.c (tui_source_window::set_contents): Update.
154 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
155
78d5933a
TT
1562019-09-20 Tom Tromey <tom@tromey.com>
157
158 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
159 declare.
160 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
161 tui_clear_source_windows_detail.
162 * tui/tui-winsource.h (struct tui_source_window_base)
163 <clear_detail>: Don't declare.
164 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
165 Remove.
166 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
167
d4207696
TT
1682019-09-20 Tom Tromey <tromey@adacore.com>
169
170 PR ada/24919:
171 * block.c (contained_in): Fix final return value.
172
00f93c44
AM
1732019-09-20 Alan Modra <amodra@gmail.com>
174
175 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
176 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
177 (read_indirect_string_from_dwz): Use bfd accessor.
178 * dwarf2read.h (struct dwz_file <filename>): Likewise.
179 * machoread.c (macho_symfile_read_all_oso): Likewise.
180 * solib.c (solib_bfd_open): Likewise.
181
e4153ae6
CB
1822019-09-19 Christian Biesinger <cbiesinger@google.com>
183
184 * eval.c: Move declaration of overload_resolution to...
185 * value.h: ...here.
186
c7ae7675
CB
1872019-09-19 Christian Biesinger <cbiesinger@google.com>
188
189 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
190 * arm-linux-tdep.c: Likewise.
191 * arm-nbsd-nat.c: Likewise.
192 * arm-tdep.h: Declare arm_apcs_32.
193 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
194
e86f08d2
CB
1952019-09-19 Christian Biesinger <cbiesinger@google.com>
196
197 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
198 * dwarf2read.h: Declare dwarf_always_disassemble.
199
f64e2f40
TV
2002019-09-19 Tom de Vries <tdevries@suse.de>
201
202 PR gdb/25009
203 * source-cache.c (source_cache::ensure): Catch exception thrown during
204 construction of the highlighter.
205
fd361982
AM
2062019-09-18 Alan Modra <amodra@gmail.com>
207
208 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
209 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
210 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
211 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
212 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
213 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
214 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
215 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
216 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
217 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
218 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
219 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
220 * solib-spu.c, * solib-svr4.c, * solib-target.c,
221 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
222 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
223 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
224 * mi/mi-interp.c: Update throughout for bfd section macro and
225 function changes.
226 * gcore (gcore_create_callback): Use bfd_set_section_lma.
227 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
228
11061048
TT
2292019-09-18 Tom Tromey <tom@tromey.com>
230
231 * NEWS: Add entry.
232 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
233 call rl_initialize.
234 (tui_enable): Do not call rl_initialize.
235
7a27b85f
CG
2362019-09-18 Christian Groessler <chris@groessler.org>
237
238 * alpha-linux-nat.c: Include gdbarch.h.
239
f64eea3a
SM
2402019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
241
242 * ui-file.c: Include cli/cli-style.h.
243 (term_cli_styling): Remove cli_styling declaration.
244
e6f7f6d1
AM
2452019-09-18 Alan Modra <amodra@gmail.com>
246
247 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
248 to bfd_asymbol_section.
249
1d38e9d1
AM
2502019-09-18 Alan Modra <amodra@gmail.com>
251
252 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
253 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
254 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
255
90d92a63
AM
2562019-09-18 Alan Modra <amodra@gmail.com>
257
258 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
259 * spu-linux-nat.c (spu_bfd_open): Likewise.
260
a3d181d2
CB
2612019-09-18 Christian Biesinger <cbiesinger@google.com>
262
263 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
264 to bool to match definition in dwarf2read.c.
265
491144b5
CB
2662019-09-17 Christian Biesinger <cbiesinger@google.com>
267
268 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
269 (print_signatures): Likewise.
270 (trust_pad_over_xvs): Likewise.
271 * arch/aarch64-insn.c (aarch64_debug): Likewise.
272 * arch/aarch64-insn.h (aarch64_debug): Likewise.
273 * arm-linux-nat.c (arm_apcs_32): Likewise.
274 * arm-linux-tdep.c (arm_apcs_32): Likewise.
275 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
276 * arm-tdep.c (arm_debug): Likewise.
277 (arm_apcs_32): Likewise.
278 * auto-load.c (debug_auto_load): Likewise.
279 (auto_load_gdb_scripts): Likewise.
280 (global_auto_load): Likewise.
281 (auto_load_local_gdbinit): Likewise.
282 (auto_load_local_gdbinit_loaded): Likewise.
283 * auto-load.h (global_auto_load): Likewise.
284 (auto_load_local_gdbinit): Likewise.
285 (auto_load_local_gdbinit_loaded): Likewise.
286 * breakpoint.c (disconnected_dprintf): Likewise.
287 (breakpoint_proceeded): Likewise.
288 (automatic_hardware_breakpoints): Likewise.
289 (always_inserted_mode): Likewise.
290 (target_exact_watchpoints): Likewise.
291 (_initialize_breakpoint): Update.
292 * breakpoint.h (target_exact_watchpoints): Change to bool.
293 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
294 * cli/cli-cmds.c (trace_commands): Likewise.
295 * cli/cli-cmds.h (trace_commands): Likewise.
296 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
297 to bool*.
298 * cli/cli-logging.c (logging_overwrite): Change to bool.
299 (logging_redirect): Likewise.
300 (debug_redirect): Likewise.
301 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
302 (struct boolean_option_def) <get_var_address_cb_>: Change return type
303 to bool.
304 <boolean_option_def>: Update.
305 (struct flag_option_def): Change default type of Context to bool
306 from int.
307 <flag_option_def>: Change return type of var_address_cb_ to bool*.
308 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
309 (get_setshow_command_value_string): Likewise.
310 * cli/cli-style.c (cli_styling): Change to bool.
311 (source_styling): Likewise.
312 * cli/cli-style.h (source_styling): Likewise.
313 (cli_styling): Likewise.
314 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
315 to bool.
316 * command.h (var_types): Update comment.
317 (add_setshow_boolean_cmd): Change int* var argument to bool*.
318 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
319 bool.
320 (debug_compile_cplus_scopes): Likewise.
321 * compile/compile-internal.h (compile_debug): Likewise.
322 * compile/compile.c (compile_debug): Likewise.
323 (struct compile_options) <raw>: Likewise.
324 * cp-support.c (catch_demangler_crashes): Likewise.
325 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
326 (usr_cmd_cris_dwarf2_cfi): Likewise.
327 * csky-tdep.c (csky_debug): Likewise.
328 * darwin-nat.c (enable_mach_exceptions): Likewise.
329 * dcache.c (dcache_enabled_p): Likewise.
330 * defs.h (info_verbose): Likewise.
331 * demangle.c (demangle): Likewise.
332 (asm_demangle): Likewise.
333 * dwarf-index-cache.c (debug_index_cache): Likewise.
334 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
335 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
336 * dwarf2read.c (check_physname): Likewise.
337 (use_deprecated_index_sections): Likewise.
338 (dwarf_always_disassemble): Likewise.
339 * eval.c (overload_resolution): Likewise.
340 * event-top.c (set_editing_cmd_var): Likewise.
341 (exec_done_display_p): Likewise.
342 * event-top.h (set_editing_cmd_var): Likewise.
343 (exec_done_display_p): Likewise.
344 * exec.c (write_files): Likewise.
345 * fbsd-nat.c (debug_fbsd_lwp): Likewise
346 (debug_fbsd_nat): Likewise.
347 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
348 Likewise.
349 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
350 <backtrace_past_entry> Likewise.
351 * gdb-demangle.h (demangle): Likewise.
352 (asm_demangle): Likewise.
353 * gdb_bfd.c (bfd_sharing): Likewise.
354 * gdbcore.h (write_files): Likewise.
355 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
356 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
357 * gdbthread.h (print_thread_events): Likewise.
358 * gdbtypes.c (opaque_type_resolution): Likewise.
359 (strict_type_checking): Likewise.
360 * gnu-nat.c (gnu_debug_flag): Likewise.
361 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
362 * guile/scm-param.c (pascm_variable): Add boolval.
363 (add_setshow_generic): Update.
364 (pascm_param_value): Update.
365 (pascm_set_param_value_x): Update.
366 * hppa-tdep.c (hppa_debug): Change to bool..
367 * infcall.c (may_call_functions_p): Likewise.
368 (coerce_float_to_double_p): Likewise.
369 (unwind_on_signal_p): Likewise.
370 (unwind_on_terminating_exception_p): Likewise.
371 * infcmd.c (startup_with_shell): Likewise.
372 * inferior.c (print_inferior_events): Likewise.
373 * inferior.h (startup_with_shell): Likewise.
374 (print_inferior_events): Likewise.
375 * infrun.c (step_stop_if_no_debug): Likewise.
376 (detach_fork): Likewise.
377 (debug_displaced): Likewise.
378 (disable_randomization): Likewise.
379 (non_stop): Likewise.
380 (non_stop_1): Likewise.
381 (observer_mode): Likewise.
382 (observer_mode_1): Likewise.
383 (set_observer_mode): Update.
384 (sched_multi): Change to bool.
385 * infrun.h (debug_displaced): Likewise.
386 (sched_multi): Likewise.
387 (step_stop_if_no_debug): Likewise.
388 (non_stop): Likewise.
389 (disable_randomization): Likewise.
390 * linux-tdep.c (use_coredump_filter): Likewise.
391 (dump_excluded_mappings): Likewise.
392 * linux-thread-db.c (auto_load_thread_db): Likewise.
393 (check_thread_db_on_load): Likewise.
394 * main.c (captured_main_1): Update.
395 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
396 xx2_opt, boolean_opt>: Change to bool.
397 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
398 * maint.c (maintenance_profile_p): Likewise.
399 (per_command_time): Likewise.
400 (per_command_space): Likewise.
401 (per_command_symtab): Likewise.
402 * memattr.c (inaccessible_by_default): Likewise.
403 * mi/mi-main.c (mi_async): Likewise.
404 (mi_async_1): Likewise.
405 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
406 * nat/fork-inferior.h (startup_with_shell): Likewise.
407 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
408 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
409 * nios2-tdep.c (nios2_debug): Likewise.
410 * or1k-tdep.c (or1k_debug): Likewise.
411 * parse.c (parser_debug): Likewise.
412 * parser-defs.h (parser_debug): Likewise.
413 * printcmd.c (print_symbol_filename): Likewise.
414 * proc-api.c (procfs_trace): Likewise.
415 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
416 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
417 (set_parameter_value): Update.
418 (add_setshow_generic): Update.
419 * python/py-value.c (copy_py_bool_obj): Change argument from int*
420 to bool*.
421 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
422 int*.
423 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
424 * record-btrace.c (record_btrace_target::store_registers): Update.
425 * record-full.c (record_full_memory_query): Change to bool.
426 (record_full_stop_at_limit): Likewise.
427 * record-full.h (record_full_memory_query): Likewise.
428 * remote-notif.c (notif_debug): Likewise.
429 * remote-notif.h (notif_debug): Likewise.
430 * remote.c (use_range_stepping): Likewise.
431 (interrupt_on_connect): Likewise.
432 (remote_break): Likewise.
433 * ser-tcp.c (tcp_auto_retry): Likewise.
434 * ser-unix.c (serial_hwflow): Likewise.
435 * skip.c (debug_skip): Likewise.
436 * solib-aix.c (solib_aix_debug): Likewise.
437 * spu-tdep.c (spu_stop_on_load_p): Likewise.
438 (spu_auto_flush_cache_p): Likewise.
439 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
440 Likewise.
441 (struct info_print_options) <quiet>: Likewise.
442 * symfile-debug.c (debug_symfile): Likewise.
443 * symfile.c (auto_solib_add): Likewise.
444 (separate_debug_file_debug): Likewise.
445 * symfile.h (auto_solib_add): Likewise.
446 (separate_debug_file_debug): Likewise.
447 * symtab.c (basenames_may_differ): Likewise.
448 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
449 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
450 (struct info_types_options) <quiet>: Likewise.
451 * symtab.h (demangle): Likewise.
452 (basenames_may_differ): Likewise.
453 * target-dcache.c (stack_cache_enabled_1): Likewise.
454 (code_cache_enabled_1): Likewise.
455 * target.c (trust_readonly): Likewise.
456 (may_write_registers): Likewise.
457 (may_write_memory): Likewise.
458 (may_insert_breakpoints): Likewise.
459 (may_insert_tracepoints): Likewise.
460 (may_insert_fast_tracepoints): Likewise.
461 (may_stop): Likewise.
462 (auto_connect_native_target): Likewise.
463 (target_stop_and_wait): Update.
464 (target_async_permitted): Change to bool.
465 (target_async_permitted_1): Likewise.
466 (may_write_registers_1): Likewise.
467 (may_write_memory_1): Likewise.
468 (may_insert_breakpoints_1): Likewise.
469 (may_insert_tracepoints_1): Likewise.
470 (may_insert_fast_tracepoints_1): Likewise.
471 (may_stop_1): Likewise.
472 * target.h (target_async_permitted): Likewise.
473 (may_write_registers): Likewise.
474 (may_write_memory): Likewise.
475 (may_insert_breakpoints): Likewise.
476 (may_insert_tracepoints): Likewise.
477 (may_insert_fast_tracepoints): Likewise.
478 (may_stop): Likewise.
479 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
480 (make_thread_apply_all_options_def_group): Change argument from int*
481 to bool*.
482 (thread_apply_all_command): Update.
483 (print_thread_events): Change to bool.
484 * top.c (confirm): Likewise.
485 (command_editing_p): Likewise.
486 (history_expansion_p): Likewise.
487 (write_history_p): Likewise.
488 (info_verbose): Likewise.
489 * top.h (confirm): Likewise.
490 (history_expansion_p): Likewise.
491 * tracepoint.c (disconnected_tracing): Likewise.
492 (circular_trace_buffer): Likewise.
493 * typeprint.c (print_methods): Likewise.
494 (print_typedefs): Likewise.
495 * utils.c (debug_timestamp): Likewise.
496 (sevenbit_strings): Likewise.
497 (pagination_enabled): Likewise.
498 * utils.h (sevenbit_strings): Likewise.
499 (pagination_enabled): Likewise.
500 * valops.c (overload_resolution): Likewise.
501 * valprint.h (struct value_print_options) <prettyformat_arrays,
502 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
503 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
504 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
505 Likewise.
506 * windows-nat.c (new_console): Likewise.
507 (cygwin_exceptions): Likewise.
508 (new_group): Likewise.
509 (debug_exec): Likewise.
510 (debug_events): Likewise.
511 (debug_memory): Likewise.
512 (debug_exceptions): Likewise.
513 (useshell): Likewise.
514 * windows-tdep.c (maint_display_all_tib): Likewise.
515 * xml-support.c (debug_xml): Likewise.
516
f1b620e9
MG
5172019-09-17 Mike Gulick <mgulick@mathworks.com>
518
519 * source.c (prepare_path_for_appending): New function.
520 (openp): Make use of new function.
521 (find_and_open_source): Search for the compilation directory and
522 source file as a relative path beneath the directory search path.
523
67f3ed6a
AB
5242019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
525
526 * source-cache.c (source_cache::get_line_charpos): Catch
527 exceptions and return false, this matches the behaviour documented
528 in the header file.
529
74332189
JB
5302019-09-17 Joel Brobecker <brobecker@adacore.com>
531
532 * ada-tasks.c (info_task): Remove quoting of the task's name.
533
f2f24aa9
CB
5342019-09-16 Christian Biesinger <cbiesinger@google.com>
535
536 * symfile.c (auto_solib_add): Replace comment with a reference
537 to the header file.
538
6a062a93
CB
5392019-09-14 Christian Biesinger <cbiesinger@google.com>
540
541 * NEWS: Mention that gdb can now be compiled with Python 3
542 on Windows.
543
ec6c8338
AB
5442019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
545
546 * maint.c (maint_print_section_data::maint_print_section_data):
547 Force use of 'float log10 (float)' by casting the argument to
548 float.
549
aa17805f
AB
5502019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
551
552 * maint.c: Add 'cmath' include.
553 (struct maint_print_section_data): New structure.
554 (print_section_index): New function.
555 (print_bfd_section_info): Add header comment, small whitespace
556 cleanup, and update to call new print_section_index function.
557 (print_objfile_section_info): Likewise.
558 (maint_obj_section_from_bfd_section): New function.
559 (print_bfd_section_info_maybe_relocated): New function.
560 (maintenance_info_sections): Add header comment, always use
561 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
562
3dd9bb46
AB
5632019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
564
565 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
566 inner scope, add check that the objfile has psymtabs before
567 checking psymtabs_addrmap.
568 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
569
4993045d
PW
5702019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
571
572 * NEWS: Announce that Ada task names are now shown at more places,
573 and between quotes (except in info task output).
574 * gdb/ada-tasks.c (task_to_str): New function.
575 (display_current_task_id): Call task_to_str.
576 (task_command_1): Likewise.
577 (print_ada_task_info): In non-mi mode, Properly align headers and data
578 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
579
7a289707
RO
5802019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
581
582 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
583 prstatus.pr_lwp.pr_info instead of making it up.
584
f2aec7f6
CB
5852019-09-11 Christian Biesinger <cbiesinger@google.com>
586
587 * auto-load.c (auto_load_expand_dir_vars): Update.
588 * defs.h (gdb_datadir): Change to std::string.
589 (python_libdir): Likewise.
590 (relocate_gdb_directory): Change return type to std::string.
591 * guile/guile.c (gdbscm_data_directory): Update.
592 (initialize_scheme_side): Update.
593 * jit.c (jit_reader_dir): Change to std::string.
594 (jit_reader_load_command): Update.
595 * main.c (gdb_datadir): Change to std::string.
596 (python_libdir): Likewise.
597 (set_gdb_data_directory): Update.
598 (relocate_path): Change to return std::string.
599 (relocate_gdb_directory): Change to return std::string.
600 (relocate_gdbinit_path_maybe_in_datadir): Update.
601 (captured_main_1): Update.
602 * python/python.c (do_start_initialization): Update.
603 * top.c (show_gdb_datadir): Update.
604 * xml-syscall.c (xml_init_syscalls_info): Update.
605 (init_syscalls_info): Update.
606
9224a013
CB
6072019-09-11 Christian Biesinger <cbiesinger@google.com>
608
609 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
610 out of get_init_files.
611 (get_init_files): Update.
612
f48cd836
CB
6132019-09-11 Christian Biesinger <cbiesinger@google.com>
614
615 * main.c (get_init_files): Change to use std::string.
616 (captured_main_1): Update.
617 (print_gdb_help): Update.
618
9cab7ecd
AT
6192019-09-11 Ali Tamur <tamur@google.com>
620
621 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
622 implementation.
623
67547d89
CB
6242019-09-11 Christian Biesinger <cbiesinger@google.com>
625
626 * dbxread.c (read_dbx_symtab): Update.
627 * dwarf2read.c (load_partial_dies): Update.
628 * mdebugread.c (parse_partial_symbols): Update.
629 (handle_psymbol_enumerators): Update.
630 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
631 * psymtab.c (add_psymbol_to_bcache): Likewise.
632 (add_psymbol_to_list): Likewise.
633 * symtab.c (symbol_set_names): Likewise.
634 * symtab.h (symbol_set_names): Likewise.
635 * xcoffread.c (scan_xcoff_symtab): Update.
636
64b2d4a0
TT
6372019-09-11 Tom Tromey <tom@tromey.com>
638
639 * symfile-mem.c (symbol_file_add_from_memory): Use
640 bfd_set_filename.
641 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
642 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
643
3b00ef10
TT
6442019-09-10 Tom Tromey <tromey@adacore.com>
645
646 * dwarf-index-write.c (write_psymbols): Extend error message.
647 (debug_names::insert): Add Ada code.
648 (debug_names::write_psymbols): Remove Ada check.
649 (debug_names) <m_string_obstack>: New member.
650 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
651 (gdb_index_symbol_name_matcher::matches): Remove.
652 (mapped_index_base::find_name_components_bounds): Add "lang"
653 parameter.
654 (mapped_index_base::build_name_components): Also split names
655 according to Ada syntax.
656 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
657 type of "match_callback".
658 (check_match, check_find_bounds_finds)
659 (dw2_expand_symtabs_matching): Update.
660 (dw2_debug_names_iterator): Add new constructor.
661 (dw2_debug_names_map_matching_symbols): New function.
662 (dw2_debug_names_expand_symtabs_matching): Update.
663 (dwarf2_debug_names_functions): Use
664 dw2_debug_names_map_matching_symbols.
665
aa391654
TT
6662019-09-10 Tom Tromey <tromey@adacore.com>
667
668 * dwarf2read.c (dw2_get_file_names_reader): Add the
669 CU's file name to the results.
670
b054970d
TT
6712019-09-10 Tom Tromey <tromey@adacore.com>
672
673 * ada-lang.c (add_nonlocal_symbols): Combine calls to
674 map_matching_symbols. Update.
675 * dwarf2read.c (dw2_map_matching_symbols): Update.
676 * psymtab.c (match_partial_symbol): Change type; update.
677 (psym_map_matching_symbols): Likewise.
678 * symfile-debug.c (debug_qf_map_matching_symbols): Change
679 type; update.
680 * symfile.h (struct quick_symbol_functions)
681 <map_matching_symbols>: Change "name" to be a lookup_name_info.
682 Remove "match".
683
6a3dbf1b
TT
6842019-09-10 Tom Tromey <tromey@adacore.com>
685
686 * psymtab.c (map_block): Remove.
687 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
688 * symtab.c (iterate_over_symbols_terminated): New function.
689 * symtab.c (iterate_over_symbols_terminated): Declare.
690
6969f124
TT
6912019-09-10 Tom Tromey <tromey@adacore.com>
692
693 * ada-lang.c (ada_iterate_over_symbols): Return bool.
694 * language.h (struct language_defn) <la_iterate_over_symbols>:
695 Return bool.
696 * symtab.c (iterate_over_symbols): Return bool.
697 * symtab.h (iterate_over_symbols): Return bool.
698
199b4314
TT
6992019-09-10 Tom Tromey <tromey@adacore.com>
700
701 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
702 (add_nonlocal_symbols): Update.
703 * dwarf2read.c (dw2_map_matching_symbols): Change type.
704 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
705 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
706 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
707 Change type of "callback". Remove "data".
708
a084a2a6
AT
709
7102019-09-09 Ali Tamur <tamur@google.com>
711
712 * dwarf2read.c (comp_unit_head): Update comment.
713 (dwarf2_dwo_name): New function declaration.
714 (dwarf_unit_type_name): New function declaration.
715 (read_comp_unit_head): Add support for new compilation units,
716 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
717 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
718 (currently named as "signature") in their header. Also clarify error
719 messages.
720 (lookup_dwo_id): New function. Returns the dwo id of the given
721 compile unit.
722 (lookup_dwo_unit): Use the new lookup_dwo_id function.
723 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
724 functions.
725 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
726 (dwarf2_dwo_name): Get the dwo name if present.
727 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
728 purposes.
729
25a2915e
TT
7302019-09-09 Tom Tromey <tom@tromey.com>
731
732 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
733
e4df0874
PW
7342019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
735
736 * python/python.c (do_start_initialization): Make progname_copy static,
737 to avoid a leak report.
738
8634b462
TT
7392019-09-08 Tom Tromey <tom@tromey.com>
740
741 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
742
c7f839cb
SM
7432019-09-07 Simon Marchi <simon.marchi@efficios.com>
744
745 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
746 Change type to gdb::optional<block_enum>.
747 (dw2_symtab_iter_init): Change block_index parameter type
748 to gdb::optional<block_enum>.
749 (dw2_lookup_symbol): Change block_index parameter
750 type to block_enum.c
751 (dw2_debug_names_lookup_symbol): Likewise.
752 * psymtab.c (psym_lookup_symbol): Likewise.
753 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
754 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
755 Likewise.
756
ead0e69a
CB
7572019-09-06 Christian Biesinger <cbiesinger@google.com>
758
759 * defs.h (relocate_gdb_directory): Change int to bool in
760 signature and rename flag to relocatable.
761 * main.c (relocate_path): Likewise.
762 (relocate_gdb_directory): Likewise.
763
b16c44de
AM
7642019-09-06 Alan Modra <amodra@gmail.com>
765
766 * coffread.c (coff_symfile_read): Constify filename variable.
767 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
768 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
769 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
770 * solib.c (reload_shared_libraries_1): Likewise.
771 * symfile.c (reread_symbols): Likewise.
772 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
773 * solib-darwin.c (darwin_bfd_open): Likewise.
774 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
775
06ff036e
AB
7762019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
777
778 * psymtab.c (print_partial_symbols): Handle missing domain_enum
779 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
780
4e962e74
TT
7812019-09-03 Tom Tromey <tromey@adacore.com>
782
783 * ada-valprint.c (ada_val_print_num): Don't recurse for range
784 types.
785 (has_negatives): Unbias a range type bound.
786 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
787 * gdbtypes.c (operator==): Handle new field.
788 (create_range_type): Add "bias" parameter.
789 (create_static_range_type, resolve_dynamic_range): Update.
790 * gdbtypes.h (struct range_bounds) <bias>: New member.
791 (create_range_type): Add bias parameter.
792 * printcmd.c (print_scalar_formatted): Unbias range types.
793 * value.c (unpack_long): Unbias range types.
794 (pack_long): Bias range types.
795
d90b8f26
AH
7962019-09-02 Alan Hayward <alan.hayward@arm.com>
797
798 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
799 probe arguments.
800
fe01123e
AH
8012019-09-02 Alan Hayward <alan.hayward@arm.com>
802
803 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
804 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
805 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
806 (compile_probe_arg): Likewise.
807 * probe.h (get_argument_count): Likewise.
808 * solib-svr4.c (solib_event_probe_action): Likewise.
809 * stap-probe.c (stap_probe::get_argument_count): Likewise.
810
e661ef01
AH
8112019-09-02 Alan Hayward <alan.hayward@arm.com>
812
813 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
814 code to here...
815 (svr4_create_solib_event_breakpoints): ...from here.
816
47a536d9
SDJ
8172019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
818
819 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
820 suffix from warning message.
821
d6a00eba
TT
8222019-08-30 Tom Tromey <tom@tromey.com>
823
824 * tui/tui-winsource.h (struct tui_source_window_base)
825 <refresh_all>: Don't declare.
826 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
827 Remove.
828 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
829 tui_show_locator_content.
830 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
831 declare.
832 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
833 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
834 declare.
835
55b2657b
TT
8362019-08-30 Tom Tromey <tom@tromey.com>
837
838 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
839
12a8555a
TT
8402019-08-30 Tom Tromey <tom@tromey.com>
841
842 * tui/tui-stack.c (_initialize_tui_stack): Move later.
843 Remove unnecessary forward declarations.
844
900ac242
TT
8452019-08-30 Tom Tromey <tom@tromey.com>
846
847 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
848 rerender.
849 (tui_update_locator_fullname, tui_show_frame_info): Don't call
850 tui_show_locator_content.
851
99ab33fb
TT
8522019-08-30 Tom Tromey <tom@tromey.com>
853
854 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
855 (tui_locator_window::rerender): Rewrite using body of previous
856 tui_show_locator_content.
857
e594a5d1
TT
8582019-08-30 Tom Tromey <tom@tromey.com>
859
860 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
861 set_locator_fullname>: New methods.
862 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
863 Rename from tui_set_locator_fullname.
864 (tui_locator_window::set_locator_info): Rename from
865 tui_set_locator_info. Return bool.
866 (tui_update_locator_fullname, tui_show_frame_info): Update.
867
715bb467
TT
8682019-08-30 Tom Tromey <tom@tromey.com>
869
870 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
871
772f3f03
TT
8722019-08-30 Tom Tromey <tom@tromey.com>
873
874 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
875 call touchwin.
876
108e13ab
TT
8772019-08-30 Tom Tromey <tom@tromey.com>
878
879 * tui/tui-wingeneral.c (box_win): Assume win_info and
880 win_info->handle cannot be NULL.
881
cdaa6eb4
TT
8822019-08-30 Tom Tromey <tom@tromey.com>
883
884 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
885 refresh_window>: Declare.
886 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
887 resize.
888 (tui_data_item_window::rerender): Rename from
889 tui_display_register.
890 (tui_data_item_window::refresh_window): New method.
891 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
892 no-op.
893
89df7f90
TT
8942019-08-30 Tom Tromey <tom@tromey.com>
895
896 * tui/tui-regs.h (struct tui_data_window) <regs_content,
897 regs_column_count, current_group>: Move later. Now private.
898 <get_current_group>: New method.
899 * tui/tui-regs.c (tui_reg_command): Update.
900 * tui/tui-layout.c (tui_set_layout): Update.
901
1bf2866a
TT
9022019-08-30 Tom Tromey <tom@tromey.com>
903
904 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
905 (tui_data_window::rerender): Don't call
906 check_and_display_highlight_if_needed.
907 (tui_data_window::refresh_all): Remove call to
908 erase_data_content.
909
0670413d
TT
9102019-08-30 Tom Tromey <tom@tromey.com>
911
912 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
913 (tui_data_window::display_registers_from)
914 (tui_data_window::display_reg_element_at_line)
915 (tui_data_window::display_registers_from_line): Remove checks of
916 "empty".
917
18bb55c7
TT
9182019-08-30 Tom Tromey <tom@tromey.com>
919
920 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
921 Don't declare.
922 * tui/tui-regs.c (tui_data_window::show_registers): Call
923 rerender.
924 (tui_data_window::rerender): Rename from display_all_data.
925 (tui_data_window::rerender): Remove old implementation.
926
1f6d2f10
TT
9272019-08-30 Tom Tromey <tom@tromey.com>
928
929 * tui/tui-regs.c (tui_data_window::display_all_data): Change
930 text.
931 * tui/tui-data.h (NO_DATA_STRING): Remove define.
932
16d01f9c
BW
9332019-08-29 Bernhard Wodok <barto@gmx.net>
934 Sergio Durigan Junior <sergiodj@redhat.com>
935
936 PR win32/24284
937 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
938
d8f27c60
AB
9392019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
940
941 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
942 when searching for types.
943
1f20c35e
AB
9442019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
945
946 * f-lang.c (f_language_defn): Use f_print_typedef.
947 * f-lang.h (f_print_typedef): Declare.
948 * f-typeprint.c (f_print_typedef): Define.
949
550105b7
CB
9502019-08-27 Christian Biesinger <cbiesinger@google.com>
951
952 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
953
4acfdd20
AB
9542019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
955
956 * cli/cli-utils.c (info_print_options_defs): Delete.
957 (make_info_print_options_def_group): Delete.
958 (extract_info_print_options): Delete.
959 (info_print_command_completer): Delete.
960 (info_print_args_help): Add extra parameter, and optionally
961 include text about -n flag.
962 * cli/cli-utils.h (struct info_print_options): Delete.
963 (extract_info_print_options): Delete declaration.
964 (info_print_command_completer): Delete declaration.
965 (info_print_args_help): Add extra parameter, extend header
966 comment.
967 * python/python.c (gdbpy_rbreak): Pass additional parameter to
968 search_symbols.
969 * stack.c (struct info_print_options): New type.
970 (info_print_options_defs): New file scoped variable.
971 (make_info_print_options_def_group): New static function.
972 (info_print_command_completer): New static function.
973 (info_locals_command): Update to use new local functions.
974 (info_args_command): Likewise.
975 (_initialize_stack): Add extra parameter to calls to
976 info_print_args_help.
977 * symtab.c (search_symbols): Add extra parameter, use this to
978 possibly excluse non-debug symbols.
979 (symtab_symbol_info): Add extra parameter, which is passed on to
980 search_symbols.
981 (struct info_print_options): New type.
982 (info_print_options_defs): New file scoped variable.
983 (make_info_print_options_def_group): New static function.
984 (info_print_command_completer): New static function.
985 (info_variables_command): Update to use local functions, and pass
986 extra parameter through to symtab_symbol_info.
987 (info_functions_command): Likewise.
988 (info_types_command): Pass additional argument through to
989 symtab_symbol_info.
990 (rbreak_command): Pass extra argument to search_symbols.
991 (_initialize_symtab): Add extra arguments for calls to
992 info_print_args_help, and update help text for 'info variables',
993 'whereis', and 'info functions' commands.
994 * symtab.h (search_symbols): Add extra argument to declaration.
995 * NEWS: Mention new flags.
996
9aa55206
CB
9972019-08-26 Christian Biesinger <cbiesinger@google.com>
998
999 * symtab.c (lookup_static_symbol): Call the new function (and move
1000 it down to be next to lookup_global_symbol).
1001 (struct global_sym_lookup_data): Add block_enum member and rename to...
1002 (struct global_or_static_sym_lookup_data): ...this.
1003 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1004 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1005 (lookup_symbol_global_or_static_iterator_cb): ...this.
1006 (lookup_global_or_static_symbol): New function.
1007 (lookup_global_symbol): Call new function.
1008
5c31b358
TV
10092019-08-26 Tom de Vries <tdevries@suse.de>
1010
1011 PR c++/24852
1012 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1013 when pc_probe.prob == NULL.
1014
23c13d42
SM
10152019-08-25 Simon Marchi <simon.marchi@efficios.com>
1016
1017 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1018 variable symbol_linkage to symbol_linkage_.
1019
beadd3e8
SM
10202019-08-25 Simon Marchi <simon.marchi@efficios.com>
1021
1022 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1023 represent whether the symbol is static, dynamic, or we don't
1024 know.
1025
e3ec872f
YS
10262019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1027
1028 * gdb/rx-tdep.c (rx_register_names): New.
1029 (rx_register_name): Delete.
1030 (rx_psw_type): Delete.
1031 (rx_fpsw_type): Delete.
1032 (rx_register_type): Delete.
1033 (rx_gdbarch_init): Convert target-descriptions.
1034 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1035 * gdb/features/Makefile: Add rx.xml.
1036 * gdb/features/rx.xml: New.
1037 * gdb/features/rx.c: Generated.
1038 * gdb/NEWS: Mention target description support.
1039
d0509ba4
CB
10402019-08-22 Christian Biesinger <cbiesinger@google.com>
1041
1042 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1043 *slot_ptr.
1044
2d41fa11
SDJ
10452019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1046
1047 * configure.ac: Don't check for 'dlfcn.h' (moved to
1048 gdbsupport/common.m4).
1049 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1050 'gdbsupport/'.
1051 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1052 * compile/compile-c-support.c: Include
1053 'gdbsupport/gdb-dlfcn.h'.
1054 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1055 * gdb-dlfcn.c: Move to...
1056 * gdbsupport/gdb-dlfcn.c: ... here.
1057 * gdb-dlfcn.h: Move to...
1058 * gdbsupport/gdb-dlfcn.h: ... here.
1059
de8af808
SL
10602019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1061
1062 * nios2-tdep.c (struct reg_value): Improve comments. Make
1063 the offset field signed.
1064
27204489
CB
10652019-08-22 Christian Biesinger <cbiesinger@google.com>
1066
1067 * python/lib/gdb/__init__.py (_execute_file): New function.
1068 * python/python.c (python_run_simple_file): Call gdb._execute_file
1069 on Windows.
1070
43771869
AB
10712019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1072
1073 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1074 all uses as this was never set to anything but a zero value.
1075
26c957f1
PA
10762019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1077
1078 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1079
c07aae6e
CB
10802019-08-21 Christian Biesinger <cbiesinger@google.com>
1081
1082 * tui/tui-data.h (tui_gen_win_info): Add an =default
1083 move constructor, required by some GCC versions.
1084
3960cb7a
JF
10852019-08-21 Jinke Fan <fanjinke51@yeah.net>
1086
1087 * go32-nat.c (go32_sysinfo): Add hygon_p.
1088
04c72a68
TT
10892019-08-20 Tom Tromey <tom@tromey.com>
1090
1091 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1092 line_from_reg_element_no, first_reg_element_no_inline,
1093 display_all_data, delete_data_content_windows,
1094 erase_data_content>: Now private.
1095
072272ce
TT
10962019-08-20 Tom Tromey <tom@tromey.com>
1097
1098 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1099 (tui_unhighlight_win, tui_highlight_win)
1100 (tui_win_info::make_window): Update.
1101 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1102
973961bd
TT
11032019-08-20 Tom Tromey <tom@tromey.com>
1104
1105 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1106 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1107 (MAX_PID_WIDTH): Move to tui-stack.c.
1108 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1109 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1110 (MAX_PID_WIDTH): Move from tui-data.h.
1111
ab0e1f1a
TT
11122019-08-20 Tom Tromey <tom@tromey.com>
1113
1114 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1115 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1116 (box_win): Update.
1117 (tui_gen_win_info::make_window): Rename from tui_make_window.
1118 (tui_win_info::make_window): New method.
1119 (tui_gen_win_info::make_visible): Update.
1120 * tui/tui-source.c (tui_source_window::set_contents): Update.
1121 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1122 (tui_data_window::display_registers_from): Update.
1123 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1124 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1125 Declare.
1126 <can_box>: Remove.
1127 <title>: Remove.
1128 (struct tui_win_info) <make_window>: Declare.
1129 <can_box>: Now virtual.
1130 <title>: New member.
1131 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1132 * tui/tui-command.c (tui_cmd_window::resize): Update.
1133
100c2bf3
TT
11342019-08-20 Tom Tromey <tom@tromey.com>
1135
1136 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1137 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1138 (tui_data_window::check_register_values): Update.
1139
fa4dc567
TT
11402019-08-20 Tom Tromey <tom@tromey.com>
1141
1142 * tui/tui-regs.h (struct tui_data_window): Use
1143 DISABLE_COPY_AND_ASSIGN.
1144 <regs_content>: Change type, removing unique_ptr.
1145 <tui_data_window>: Add move constructor.
1146 * tui/tui-regs.c (tui_data_window::show_registers)
1147 (tui_data_window::show_register_group)
1148 (tui_data_window::display_registers_from)
1149 (tui_data_window::display_registers_from)
1150 (tui_data_window::first_data_item_displayed)
1151 (tui_data_window::delete_data_content_windows)
1152 (tui_data_window::rerender, tui_data_window::refresh_window)
1153 (tui_data_window::check_register_values): Update.
1154
ca02d7c8
TT
11552019-08-20 Tom Tromey <tom@tromey.com>
1156
1157 * tui/tui-regs.h (struct tui_data_window) <show_registers,
1158 show_register_group>: Declare.
1159 (tui_show_register_group): Don't declare.
1160 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1161 tui_show_registers.
1162 (tui_data_window::show_register_group): Rename from
1163 tui_show_register_group.
1164 (tui_data_window::check_register_values, tui_reg_command):
1165 Update.
1166 * tui/tui-layout.c (tui_set_layout): Update.
1167
63356bfd
TT
11682019-08-20 Tom Tromey <tom@tromey.com>
1169
1170 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1171 Declare.
1172 (tui_check_register_values): Don't declare.
1173 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1174 from tui_check_register_values.
1175 * tui/tui-hooks.c (tui_register_changed): Update.
1176
42cc14a7
TT
11772019-08-20 Tom Tromey <tom@tromey.com>
1178
1179 * tui/tui-regs.c (tui_reg_layout): Move later.
1180 (tui_show_registers): Don't enable TUI mode or change layout.
1181
b9ad3686
TT
11822019-08-20 Tom Tromey <tom@tromey.com>
1183
1184 * tui/tui-regs.h (struct tui_data_item_window)
1185 <~tui_data_item_window>: Remove.
1186 <content>: Now a unique_xmalloc_ptr.
1187 * tui/tui-regs.c (tui_register_format): Return a
1188 unique_xmalloc_ptr.
1189 (tui_get_register): Update.
1190 (~tui_data_item_window): Remove.
1191 (tui_data_window::display_registers_from, tui_display_register):
1192 Update.
1193 * tui/tui-io.h (tui_expand_tabs): Update.
1194 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1195 Remove "col" parameter.
1196
8e114aab
TT
11972019-08-20 Tom Tromey <tom@tromey.com>
1198
1199 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1200 field.
1201 * tui/tui-regs.c (~tui_data_item_window): Update.
1202
1a4f81dd
TT
12032019-08-20 Tom Tromey <tom@tromey.com>
1204
1205 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1206 earlier.
1207
0f8d8876
TT
12082019-08-20 Tom Tromey <tom@tromey.com>
1209
1210 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1211
605dc2c2
TT
12122019-08-20 Tom Tromey <tom@tromey.com>
1213
1214 * tui/tui-source.h (struct tui_source_window): Update.
1215 * tui/tui-regs.c (tui_show_registers): Update.
1216 * tui/tui-disasm.h (struct tui_disasm_window): Update.
1217 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1218 (NO_REGS_STRING): Remove defines.
1219
aedbe3bb
CM
12202019-08-20 Conrad Meyer <cem@FreeBSD.org>
1221
1222 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1223 unnecessary thread walk if remote doesn't support the packet.
1224
7ce8f214
TT
12252019-08-19 Tom Tromey <tromey@adacore.com>
1226
1227 * python/py-value.c (value_has_field): Fix indentation.
1228
f21c2bd7
TT
12292019-08-19 Tom Tromey <tromey@adacore.com>
1230
1231 * printcmd.c (do_one_display, info_display_command): Update.
1232 * block.h (contained_in): Return bool. Add allow_nested
1233 parameter.
1234 * block.c (contained_in): Return bool. Add allow_nested
1235 parameter.
1236
d806ea2d
TT
12372019-08-19 Tom Tromey <tom@tromey.com>
1238
1239 * configure: Rebuild.
1240 * configure.ac: Disallow the combination of -static-libstdc++ and
1241 source highlight.
1242 * source-cache.c (get_language_name): Handle rust.
1243 (source_cache::get_source_lines): Ignore highlighting exceptions.
1244
398fdd60
TT
12452019-08-16 Tom Tromey <tom@tromey.com>
1246
1247 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1248 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1249 (struct tui_source_window_base) <make_visible, refresh_window,
1250 resize>: Remove methods.
1251 <execution_info>: Remove field.
1252 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1253 (tui_show_source_line, tui_source_window_base)
1254 (~tui_source_window_base): Update.
1255 (tui_source_window_base::resize)
1256 (tui_source_window_base::make_visible)
1257 (tui_source_window_base::refresh_window): Remove.
1258 (tui_source_window_base::update_exec_info): Update.
1259 * tui/tui-source.c (tui_source_window::set_contents): Update.
1260 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1261
e699d331
TT
12622019-08-16 Tom Tromey <tom@tromey.com>
1263
1264 * tui/tui-hooks.c (tui_remove_hooks): Don't set
1265 deprecated_query_hook.
1266
bb01dbfc
TT
12672019-08-16 Tom Tromey <tom@tromey.com>
1268
1269 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1270 (tui_update_source_windows_with_line): Update.
1271 * tui/tui-source.h (struct tui_source_window)
1272 <show_symtab_source>: Declare.
1273 (tui_show_symtab_source): Don't declare.
1274 * tui/tui-source.c (tui_show_symtab_source): Rename from
1275 tui_show_symtab_source.
1276
81c82c4b
TT
12772019-08-16 Tom Tromey <tom@tromey.com>
1278
1279 * tui/tui-winsource.h (struct tui_source_window_base)
1280 <set_contents>: Declare.
1281 * tui/tui-winsource.c
1282 (tui_source_window_base::update_source_window_as_is): Update.
1283 * tui/tui-source.h (struct tui_source_window) <set_contents>:
1284 Declare.
1285 (tui_set_source_content): Don't declare.
1286 * tui/tui-source.c (tui_source_window::set_contents): Rename from
1287 tui_set_source_content.
1288 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1289 Declare.
1290 (tui_set_disassem_content): Don't declare.
1291 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1292 tui_set_disassem_content.
1293
2ddaf614
TT
12942019-08-16 Tom Tromey <tom@tromey.com>
1295
1296 * tui/tui-winsource.h (struct tui_source_window_base)
1297 <update_breakpoint_info>: Declare.
1298 (tui_update_breakpoint_info): Don't declare.
1299 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1300 (tui_update_all_breakpoint_info): Update.
1301 (tui_source_window_base::update_breakpoint_info): Rename from
1302 tui_update_breakpoint_info.
1303 (tui_source_window_base::update_exec_info): Update.
1304
017f9828
TT
13052019-08-16 Tom Tromey <tom@tromey.com>
1306
1307 * tui/tui-winsource.h (struct tui_source_window_base)
1308 <update_source_window>: Declare.
1309 (tui_update_source_window): Don't declare.
1310 * tui/tui-winsource.c
1311 (tui_source_window_base::update_source_window): Rename from
1312 tui_update_source_window.
1313 (tui_source_window_base::rerender): Update.
1314 * tui/tui-source.c (tui_source_window::maybe_update): Update.
1315 * tui/tui-disasm.c (tui_show_disassem)
1316 (tui_show_disassem_and_update_source)
1317 (tui_disasm_window::maybe_update): Update.
1318
ed8358e9
TT
13192019-08-16 Tom Tromey <tom@tromey.com>
1320
1321 * tui/tui-winsource.h (struct tui_source_window_base)
1322 <update_source_window_as_is>: Declare.
1323 (tui_update_source_window_as_is): Don't declare.
1324 * tui/tui-winsource.c (tui_update_source_window): Update
1325 (tui_source_window_base::update_source_window_as_is): Rename from
1326 tui_update_source_window_as_is.
1327 (tui_source_window_base::refill): Update.
1328 * tui/tui-source.c (tui_show_symtab_source): Update.
1329 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1330 Update.
1331
20149b6b
TT
13322019-08-16 Tom Tromey <tom@tromey.com>
1333
1334 * tui/tui-winsource.h (tui_update_source_window)
1335 (tui_update_source_window_as_is): Remove "noerror" parameter.
1336 * tui/tui-winsource.c (tui_update_source_window)
1337 (tui_update_source_window_as_is): Remove "noerror" parameter.
1338 (tui_update_source_windows_with_addr)
1339 (tui_update_source_windows_with_line)
1340 (tui_source_window_base::rerender)
1341 (tui_source_window_base::refill): Update.
1342 * tui/tui-source.h (tui_set_source_content)
1343 (tui_show_symtab_source): Remove "noerror" parameter.
1344 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1345 parameter.
1346 (tui_show_symtab_source): Likewise.
1347 (tui_source_window::maybe_update): Update.
1348 * tui/tui-disasm.c (tui_show_disassem)
1349 (tui_show_disassem_and_update_source)
1350 (tui_disasm_window::do_scroll_vertical)
1351 (tui_disasm_window::maybe_update): Update.
1352
2d83e710
TT
13532019-08-16 Tom Tromey <tom@tromey.com>
1354
1355 * tui/tui.c (tui_is_window_visible): Update.
1356 * tui/tui-wingeneral.c (tui_make_window)
1357 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1358 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1359 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1360 (tui_set_win_height_command, parse_scrolling_args): Update.
1361 * tui/tui-source.c (tui_source_window::style_changed): Update.
1362 * tui/tui-regs.c (tui_show_registers)
1363 (tui_data_window::first_data_item_displayed)
1364 (tui_data_window::delete_data_content_windows)
1365 (tui_check_register_values, tui_reg_command): Update.
1366 * tui/tui-disasm.c (tui_show_disassem): Update.
1367 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1368 method.
1369 <is_visible>: Remove field.
1370 * tui/tui-data.c (tui_next_win, tui_prev_win)
1371 (tui_delete_invisible_windows): Update.
1372
d4ab829a
TT
13732019-08-16 Tom Tromey <tom@tromey.com>
1374
1375 * tui/tui-winsource.h (struct tui_source_window_base)
1376 <m_has_locator>: Remove.
1377 * tui/tui-layout.c (show_source_disasm_command, show_data)
1378 (show_source_or_disasm_and_command): Update.
1379
aa7ca1bb
AH
13802019-08-16 Alan Hayward <alan.hayward@arm.com>
1381
1382 * NEWS (Other MI changes): New subsection.
1383 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1384 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1385 * arch-utils.c (default_get_pc_address_flags): New function.
1386 * arch-utils.h (default_get_pc_address_flags): New declaration.
1387 * gdbarch.sh: Add get_pc_address_flags.
1388 * gdbarch.c: Regenerate.
1389 * gdbarch.h: Likewise.
1390 * stack.c (print_pc): New function.
1391 (print_frame_info) (print_frame): Call print_pc.
1392
6eac171f
TV
13932019-08-16 Tom de Vries <tdevries@suse.de>
1394
1395 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1396 print_objfile_section_info.
1397
3df505f6
TT
13982019-08-15 Tom Tromey <tom@tromey.com>
1399
1400 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1401 calling update_cmdwin_start_line.
1402 * tui/tui-winsource.h (struct tui_source_window_base)
1403 <do_make_visible_with_new_height, set_new_height>: Don't declare.
1404 <rerender>: Declare.
1405 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1406 Call rerender.
1407 (tui_source_window_base::set_new_height): Remove.
1408 (tui_source_window_base::rerender): Rename from
1409 do_make_visible_with_new_height.
1410 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1411 resize method.
1412 (tui_win_info::make_invisible_and_set_new_height)
1413 (tui_win_info::make_visible_with_new_height): Remove.
1414 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1415 Declare.
1416 * tui/tui-stack.c (tui_locator_window::rerender): New method.
1417 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1418 do_make_visible_with_new_height>: Don't declare.
1419 <rerender>: Declare.
1420 * tui/tui-regs.c (tui_data_window::rerender): Rename from
1421 set_new_height.
1422 (tui_data_window::do_make_visible_with_new_height): Remove.
1423 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1424 call tui_show_locator_content.
1425 (tui_gen_win_info::resize): Call rerender.
1426 (show_source_or_disasm_and_command): Don't call
1427 tui_show_locator_content.
1428 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1429 method.
1430 (struct tui_win_info) <rerender>: Declare.
1431 <set_new_height, make_invisible_and_set_new_height,
1432 make_visible_with_new_height>: Don't declare.
1433 * tui/tui-data.c (tui_win_list::rerender): New method.
1434 * tui/tui-command.h (struct tui_cmd_window)
1435 <do_make_visible_with_new_height>: Don't declare.
1436 * tui/tui-command.c
1437 (tui_cmd_window::do_make_visible_with_new_height): Remove.
1438
272560b5
TT
14392019-08-15 Tom Tromey <tromey@adacore.com>
1440
1441 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1442 * ada-lang.c (ada_enum_name): Likewise.
1443
08235187
CB
14442019-08-15 Christian Biesinger <cbiesinger@google.com>
1445
1446 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1447 leading underscore.
1448 (GdbOutputErrorFile): Likewise.
1449 (global scope): Adjust constructor calls to GdbOutput{,Error}File
1450 accordingly.
1451 (execute_unwinders): Rename to have a leading underscore.
1452 (auto_load_packages): Likewise.
1453 (global scope): Adjust call to auto_load_packages accordingly.
1454 (GdbSetPythonDirectory): Likewise.
1455 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1456 instead of execute_unwinders.
1457
db502012
TT
14582019-08-15 Tom Tromey <tom@tromey.com>
1459
1460 * tui/tui-layout.c (show_layout, show_source_disasm_command)
1461 (show_data): Don't change window visibility.
1462 (tui_gen_win_info::resize): Remove special case for command
1463 window. Use wresize, when available.
1464 (show_source_or_disasm_and_command): Don't change window
1465 visibility.
1466 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1467 <make_visible>: New method.
1468 * tui/tui-command.c (tui_cmd_window::resize): New method.
1469
3891b65e
TT
14702019-08-15 Tom Tromey <tom@tromey.com>
1471
1472 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1473 (struct tui_source_windows): New.
1474 * tui/tui-winsource.c (tui_display_main): Update.
1475 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1476 (new_height_ok, parse_scrolling_args): Update.
1477 * tui/tui-layout.c (show_layout, show_data): Update.
1478 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1479 (tui_add_to_source_windows): Don't declare.
1480 * tui/tui-data.c (source_windows, tui_source_windows)
1481 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1482
ee556432
TT
14832019-08-15 Tom Tromey <tom@tromey.com>
1484
1485 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1486 Rename from reset.
1487 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1488 * tui/tui-layout.c (show_source_disasm_command, show_data):
1489 Update.
1490 (tui_gen_win_info::resize): Rename.
1491 (show_source_or_disasm_and_command): Update.
1492 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1493 reset.
1494
46f438e3
TT
14952019-08-15 Tom Tromey <tom@tromey.com>
1496
1497 * tui/tui-stack.c (tui_initialize_static_data): Remove.
1498 * tui/tui-interp.c (tui_interp::init): Don't call
1499 tui_initialize_static_data.
1500 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1501
f4ce562c
TT
15022019-08-15 Tom Tromey <tom@tromey.com>
1503
1504 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1505 examine tui_win_list.
1506
c398c3d0
TT
15072019-08-15 Tom Tromey <tom@tromey.com>
1508
1509 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1510 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1511 tui_clear_source_content.
1512 (tui_clear_source_content): Remove.
1513 (tui_source_window_base::do_erase_source_content): Hoist call to
1514 content.clear().
1515 * tui/tui-stack.c (tui_show_frame_info): Don't call
1516 tui_clear_source_content.
1517
e25d2004
TT
15182019-08-15 Tom Tromey <tom@tromey.com>
1519
1520 * tui/tui-winsource.h (struct tui_source_window_base)
1521 <do_erase_source_content>: New method.
1522 <erase_source_content>: New method.
1523 (tui_erase_source_content): Don't declare.
1524 * tui/tui-winsource.c (tui_clear_source_content): Update.
1525 (tui_source_window_base::do_erase_source_content): Rename from
1526 tui_erase_source_content.
1527 (tui_source_window_base::show_source_content): Update.
1528 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1529 * tui/tui-source.h (struct tui_source_window)
1530 <erase_source_content>: New method.
1531 * tui/tui-disasm.h (struct tui_disasm_window)
1532 <erase_source_content>: New method.
1533
002f15c2
TT
15342019-08-15 Tom Tromey <tom@tromey.com>
1535
1536 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1537 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1538 constructor.
1539 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1540 * tui/tui-source.c (tui_set_source_content): Update.
1541 * tui/tui-disasm.c (tui_set_disassem_content): Update.
1542
c9033fe8
TT
15432019-08-15 Tom Tromey <tom@tromey.com>
1544
1545 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1546 * tui/tui-winsource.c (tui_line_is_displayed): Move to
1547 tui-source.c.
1548 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1549 Declare.
1550 * tui/tui-source.c (tui_source_window::line_is_displayed): New
1551 method.
1552 (tui_source_window::maybe_update): Update.
1553
088f37dd
TT
15542019-08-15 Tom Tromey <tom@tromey.com>
1555
1556 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1557 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1558 tui-disasm.c.
1559 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1560 Declare.
1561 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1562 method.
1563 (tui_disasm_window::maybe_update): Update.
1564
a54700c6
TT
15652019-08-15 Tom Tromey <tom@tromey.com>
1566
1567 * tui/tui-winsource.h (struct tui_source_window_base)
1568 <maybe_update>: Declare.
1569 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1570 method.
1571 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1572 Declare.
1573 * tui/tui-source.c (tui_source_window::maybe_update): New method.
1574 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1575 Declare.
1576 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1577
e2a678a5
TT
15782019-08-15 Tom Tromey <tom@tromey.com>
1579
1580 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1581
f2dda477
TT
15822019-08-15 Tom Tromey <tom@tromey.com>
1583
1584 * tui/tui-wingeneral.c: Include tui-stack.h.
1585 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1586 (struct tui_locator_window): Move from tui-data.h.
1587 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1588 (tui_initialize_static_data): Move from tui-data.c.
1589 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1590 (struct tui_locator_window): Move to tui-stack.c.
1591 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1592 (tui_initialize_static_data): Move to tui-stack.c.
1593
ed4a1084
TT
15942019-08-15 Tom Tromey <tom@tromey.com>
1595
1596 * tui/tui-layout.c (show_source_disasm_command)
1597 (show_source_or_disasm_and_command): Use make_visible method, not
1598 tui_make_window.
1599 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1600 Remove.
1601
65962b20
TT
16022019-08-15 Tom Tromey <tom@tromey.com>
1603
1604 * tui/tui-wingeneral.h (tui_make_window): Update.
1605 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1606 parameter.
1607 (tui_gen_win_info::make_visible): Update.
1608 * tui/tui-regs.c (tui_data_window::display_registers_from):
1609 Update.
1610 * tui/tui-layout.c (show_source_disasm_command)
1611 (show_source_or_disasm_and_command): Update.
1612 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1613 (enum tui_box): Remove.
1614 (struct tui_win_info) <can_box>: New method.
1615 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1616 method.
1617
2208ee91
TV
16182019-08-15 Tom de Vries <tdevries@suse.de>
1619
1620 * linux-nat-trad.c: Include gdbarch.h.
1621
75faf5c4
AH
16222019-08-14 Alan Hayward <alan.hayward@arm.com>
1623
1624 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1625 register sizes.
1626
b1c896b3
TT
16272019-08-14 Tom Tromey <tromey@adacore.com>
1628
1629 * darwin-nat.c: Include gdbarch.h.
1630 * darwin-nat-info.c: Include gdbarch.h.
1631
6405cd73
TT
16322019-08-13 Tom Tromey <tom@tromey.com>
1633
1634 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1635 Remove.
1636 * tui/tui-data.c (tui_initialize_static_data): Update.
1637
5216580d
TT
16382019-08-13 Tom Tromey <tom@tromey.com>
1639
1640 * tui/tui-winsource.h (struct tui_exec_info_window)
1641 <~tui_exec_info_window, maybe_allocate_content, get_content,
1642 m_content>: Remove.
1643 (struct tui_source_window_base) <set_exec_info_content,
1644 show_exec_info_content>: Don't declare.
1645 * tui/tui-winsource.c
1646 (tui_exec_info_window::maybe_allocate_content): Remove.
1647 (tui_source_window_base::update_exec_info): Rename from
1648 set_exec_info_content.
1649 (tui_source_window_base::show_exec_info_content)
1650 (tui_source_window_base::update_exec_info): Remove.
1651
93858ad3
TT
16522019-08-13 Tom Tromey <tom@tromey.com>
1653
1654 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1655 declare.
1656 * tui/tui-winsource.c (tui_update_source_window_as_is)
1657 (tui_update_source_windows_with_addr, tui_erase_source_content):
1658 Update.
1659 (tui_clear_exec_info_content): Remove.
1660
e321e7ce
TT
16612019-08-13 Tom Tromey <tom@tromey.com>
1662
1663 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1664 declare.
1665 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1666 call tui_erase_exec_info_content.
1667 (tui_clear_exec_info_content): Rename from
1668 tui_erase_exec_info_content.
1669 (tui_clear_exec_info_content): Delete.
1670
8270ac62
TT
16712019-08-13 Tom Tromey <tom@tromey.com>
1672
1673 * tui/tui-winsource.h (struct tui_source_window_base)
1674 <show_exec_info_content>: Declare.
1675 (tui_show_exec_info_content): Don't declare.
1676 * tui/tui-winsource.c
1677 (tui_source_window_base::show_exec_info_content): Rename from
1678 tui_show_exec_info_content.
1679 (tui_source_window_base::update_exec_info): Update.
1680
7b56485d
TT
16812019-08-13 Tom Tromey <tom@tromey.com>
1682
1683 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1684 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1685 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1686 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1687 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1688 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1689 ... here.
1690
7ba913dc
TT
16912019-08-13 Tom Tromey <tom@tromey.com>
1692
1693 * tui/tui-winsource.h (struct tui_source_window_base)
1694 <update_exec_info>: Declare.
1695 (tui_update_exec_info): Don't declare.
1696 * tui/tui-winsource.c (tui_update_source_window_as_is)
1697 (tui_source_window_base::refresh_all)
1698 (tui_update_all_breakpoint_info): Update.
1699 (tui_source_window_base::update_exec_info): Rename from
1700 tui_update_exec_info.
1701 * tui/tui-stack.c (tui_show_frame_info): Update.
1702
37a4a131
TT
17032019-08-13 Tom Tromey <tom@tromey.com>
1704
1705 * tui/tui-winsource.h (struct tui_source_window_base)
1706 <set_exec_info_content>: Declare.
1707 (tui_set_exec_info_content): Don't declare.
1708 * tui/tui-winsource.c
1709 (tui_source_window_base::set_exec_info_content): Rename from
1710 tui_set_exec_info_content.
1711 (tui_update_exec_info): Update.
1712
0bd27e07
TT
17132019-08-13 Tom Tromey <tom@tromey.com>
1714
1715 * tui/tui-winsource.h (struct tui_source_window_base)
1716 <show_source_content>: Declare.
1717 (tui_show_source_content): Don't declare.
1718 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1719 (tui_source_window_base::show_source_content): Rename from
1720 tui_show_source_content.
1721 (tui_source_window_base::refresh_all): Update.
1722 * tui/tui-layout.c (show_source_disasm_command)
1723 (show_source_or_disasm_and_command): Update.
1724
b4ef5aeb
TT
17252019-08-13 Tom Tromey <tom@tromey.com>
1726
1727 * tui/tui-winsource.c (tui_erase_source_content)
1728 (tui_show_source_content, tui_source_window_base::refresh_all):
1729 Update.
1730 * tui/tui-wingeneral.h
1731 (tui_check_and_display_highlight_if_needed): Don't declare.
1732 * tui/tui-wingeneral.c
1733 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1734 check_and_display_highlight_if_needed.
1735 * tui/tui-win.c (tui_rehighlight_all)
1736 (tui_win_info::make_visible_with_new_height): Update.
1737 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1738 (tui_data_window::erase_data_content)
1739 (tui_data_window::display_all_data): Update.
1740 * tui/tui-data.h (struct tui_win_info)
1741 <check_and_display_highlight_if_needed>: Declare.
1742
fede5273
TT
17432019-08-13 Tom Tromey <tom@tromey.com>
1744
1745 * tui/tui-win.c (tui_resize_all): Call
1746 tui_delete_invisible_windows.
1747 * tui/tui-layout.c (show_layout): Call
1748 tui_delete_invisible_windows.
1749 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1750 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1751
22c3f490
TT
17522019-08-13 Tom Tromey <tom@tromey.com>
1753
1754 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1755 tui_add_win_to_layout.
1756
16cb7910
TT
17572019-08-13 Tom Tromey <tom@tromey.com>
1758
1759 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1760 * tui/tui-layout.c (tui_default_win_height): Now static.
1761
cc0c3ffb
TT
17622019-08-13 Tom Tromey <tom@tromey.com>
1763
1764 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1765 single switch.
1766 (show_source_disasm_command, show_source_or_disasm_and_command):
1767 Don't check current layout.
1768
3f3ffe54
TT
17692019-08-13 Tom Tromey <tom@tromey.com>
1770
1771 * tui/tui-wingeneral.c (make_all_visible): Remove.
1772 (tui_make_all_invisible): Simplify.
1773 * tui/tui-layout.c (tui_make_all_invisible): Move from
1774 tui-wingeneral.c; simplify.
1775 (show_layout): Hoist call to tui_make_all_invisible.
1776 (show_data): Don't call tui_make_all_invisible.
1777
69258091
TT
17782019-08-13 Tom Tromey <tom@tromey.com>
1779
1780 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1781 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1782
62cf57fe
TT
17832019-08-13 Tom Tromey <tom@tromey.com>
1784
1785 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1786 tui-data.c.
1787 (show_source_disasm_command, show_data)
1788 (show_source_or_disasm_and_command): Don't use
1789 tui_set_current_layout_to.
1790 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1791 * tui/tui-data.c (current_layout, tui_current_layout): Move to
1792 tui-layout.c.
1793 (tui_set_current_layout_to): Remove.
1794
2afade5d
TT
17952019-08-13 Tom Tromey <tom@tromey.com>
1796
1797 * tui/tui-layout.c (tui_set_layout): Update.
1798 * tui/tui-data.h (struct tui_layout_def): Remove.
1799 (tui_layout_def): Don't declare.
1800 * tui/tui-data.c (layout_def): Remove.
1801 (tui_layout_def): Remove.
1802
a3504e96
TT
18032019-08-13 Tom Tromey <tom@tromey.com>
1804
1805 * tui/tui-winsource.h (struct tui_source_window_base)
1806 <clear_detail>: No longer "override".
1807 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1808 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1809 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1810 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1811 Remove.
1812 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1813
29c92911
TT
18142019-08-13 Tom Tromey <tromey@adacore.com>
1815
1816 * tracepoint.c: Don't include readline.h or history.h.
1817
86c6b807
TT
18182019-08-12 Tom Tromey <tom@tromey.com>
1819
1820 * configure: Rebuild.
1821 * configure.ac: Check for readline 7.
1822 * NEWS: Mention readline 7 requirement.
1823 * README: Update.
1824
5db2718c
TT
18252019-08-12 Tom Tromey <tom@tromey.com>
1826
1827 * mingw-hdep.c (gdb_select): Remove readline hack.
1828
dac36daf
PFC
18292019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1830
1831 * blockframe.c (find_pc_partial_function): Set *block to nullptr
1832 when the function fails.
1833
1022c627
AA
18342019-08-09 Andreas Arnez <arnez@linux.ibm.com>
1835
1836 * s390-tdep.c (s390_type_align): New function.
1837 (s390_gdbarch_init): Set it as type_align gdbarch method.
1838
eba4caf2
TV
18392019-08-09 Tom de Vries <tdevries@suse.de>
1840
1841 PR gdb/24591
1842 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1843 pc_low with relocation offset.
1844
123cd851
TT
18452019-08-07 Tom Tromey <tromey@adacore.com>
1846
1847 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1848 (print_frame_args): Update.
1849 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1850 Update.
1851 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1852 * frame.h (struct frame_arg): Add initializers.
1853 <error>: Now a unique_xmalloc_ptr.
1854
3d31bc39
AH
18552019-08-07 Alan Hayward <alan.hayward@arm.com>
1856
1857 * NEWS: Expand the Pointer Authentication entry.
1858 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1859 (aarch64_frame_unmask_lr): ... to this.
1860 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1861 Call aarch64_frame_unmask_lr.
1862 * frame.c (struct frame_info): Add "masked" variable.
1863 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1864 (fprint_frame): Check for masked pc.
1865 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1866 declarations.
1867 * python/py-framefilter.c (py_print_frame): Check for masked pc.
1868 * stack.c (print_frame): Check for masked pc.
1869
0cf9feb9
TT
18702019-08-06 Tom Tromey <tom@tromey.com>
1871
1872 * stabsread.c (patch_block_stabs, read_one_struct_field)
1873 (read_enum_type): Use obstack_strndup.
1874 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1875 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1876 * dwarf2read.c (guess_full_die_structure_name)
1877 (anonymous_struct_prefix): Use obstack_strndup.
1878 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1879 * c-exp.y (yylex): Use obstack_strndup.
1880 * ada-exp.y (write_object_renaming, write_ambiguous_var)
1881 (write_var_or_type): Use obstack_strndup.
1882
efba19b0
TT
18832019-08-06 Tom Tromey <tom@tromey.com>
1884
1885 * symfile.c (reread_symbols): Use obstack_strdup.
1886 * stabsread.c (read_type): Use obstack_strdup.
1887 * gdb_obstack.h (obstack_strdup): New overload.
1888 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1889 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1890 (dwarf2_canonicalize_name): Use obstack_strdup.
1891 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1892 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1893 Use obstack_strdup.
1894
f25102f7
TT
18952019-08-06 Tom Tromey <tom@tromey.com>
1896
1897 * gdb_obstack.h (obstack_strdup): Define.
1898 * gdb_obstack.c (obstack_strdup): Don't define.
1899
021887d8
TT
19002019-08-06 Tom Tromey <tom@tromey.com>
1901
1902 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1903 obstack_strdup.
1904 * typeprint.c (typedef_hash_table::find_global_typedef): Use
1905 obstack_strdup.
1906 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1907 * stabsread.c (common_block_start): Use obstack_strdup.
1908 * objfiles.c (set_objfile_main_name, objfile): Use
1909 obstack_strdup.
1910 * namespace.c (add_using_directive): Use obstack_strdup.
1911 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1912 * jit.c (finalize_symtab): Use obstack_strdup.
1913 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1914 (guess_partial_die_structure_name, partial_die_info::fixup)
1915 (dwarf2_name): Use obstack_strdup.
1916 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1917 obstack_strdup.
1918 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1919 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1920 obstack_strdup.
1921 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1922
d2834edc
PW
19232019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1924
1925 * unittests/help-doc-selftests.c: New file.
1926 * Makefile.in: Add the new file.
1927
590042fc
PW
19282019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1929
1930 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1931 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
1932 the full first line, except when FOR_VALUE_PREFIX. In this case,
1933 the trailing '.' is not output, and the first character is uppercased.
1934 (print_help_for_command): Update call to print_doc_line.
1935 (print_doc_of_command): Likewise.
1936 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1937 * cli/cli-option.c (append_indented_doc): Do not append newline.
1938 (build_help_option): Append newline after first appended_indented_doc
1939 only if a second call is done.
1940 (build_help): Append 2 new lines before each option, except the first
1941 one.
1942 * compile/compile.c (_initialize_compile): Add new lines after
1943 %OPTIONS%, when not at the end of the help.
1944 Change help doc or code
1945 producing the help doc to respect the invariants.
1946 * maint-test-options.c (_initialize_maint_test_options): Likewise.
1947 Also removed the new line after 'Options:', as all other commands
1948 do not put an empty line between 'Options:' and the first option.
1949 * printcmd.c (_initialize_printcmd): Likewise.
1950 * stack.c (_initialize_stack): Likewise.
1951 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1952 incorrectly telling COMMAND is optional.
1953 * ada-lang.c (_initialize_ada_language): Change help doc or code
1954 producing the help doc to respect the invariants.
1955 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1956 * breakpoint.c (_initialize_breakpoint): Likewise.
1957 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1958 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1959 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1960 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1961 _initialize_cli_style): Likewise.
1962 * corelow.c (core_target_info): Likewise.
1963 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1964 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1965 * filesystem.c (_initialize_filesystem): Likewise.
1966 * frame.c (_initialize_frame): Likewise.
1967 * gnu-nat.c (add_task_commands): Likewise.
1968 * infcall.c (_initialize_infcall): Likewise.
1969 * infcmd.c (_initialize_infcmd): Likewise.
1970 * interps.c (_initialize_interpreter): Likewise.
1971 * language.c (_initialize_language): Likewise.
1972 * linux-fork.c (_initialize_linux_fork): Likewise.
1973 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1974 * maint.c (_initialize_maint_cmds): Likewise.
1975 * memattr.c (_initialize_mem): Likewise.
1976 * printcmd.c (_initialize_printcmd): Likewise.
1977 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1978 _RegEx): Likewise.
1979 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1980 * record-btrace.c (_initialize_record_btrace): Likewise.
1981 * record-full.c (_initialize_record_full): Likewise.
1982 * record.c (_initialize_record): Likewise.
1983 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1984 * regcache.c (_initialize_regcache): Likewise.
1985 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1986 _initialize_remote): Likewise.
1987 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1988 * serial.c (_initialize_serial): Likewise.
1989 * skip.c (_initialize_step_skip): Likewise.
1990 * source.c (_initialize_source): Likewise.
1991 * stack.c (_initialize_stack): Likewise.
1992 * symfile.c (_initialize_symfile): Likewise.
1993 * symtab.c (_initialize_symtab): Likewise.
1994 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1995 * top.c (init_main): Likewise.
1996 * tracefile-tfile.c (tfile_target_info): Likewise.
1997 * tracepoint.c (_initialize_tracepoint): Likewise.
1998 * tui/tui-win.c (_initialize_tui_win): Likewise.
1999 * utils.c (add_internal_problem_command): Likewise.
2000 * valprint.c (value_print_option_defs): Likewise.
2001
404f2902
FCE
20022019-08-06 Frank Ch. Eigler <fche@redhat.com>
2003
2004 PR build/24886
2005 * configure.ac: Drop enable-libmcheck support.
2006 * configure, config.in: Rebuild.
2007 * libmcheck.m4: Remove.
2008 * acinclude.m4: Don't include it.
2009 * Makefile.in: Don't distribute it.
2010 * top.c (print_gdb_configuration): Don't mention it.
2011
046bebe1
TT
20122019-08-06 Tom Tromey <tom@tromey.com>
2013
2014 * utils.c (set_output_style): Sometimes pass stream to
2015 emit_style_escape.
2016 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2017 * record-btrace.c (btrace_insn_history): Update.
2018 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2019 method.
2020 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2021 Update initializers.
2022 <m_uiout>: New field.
2023 <m_di>: Move lower.
2024 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2025 Remove "uiout" parameter.
2026 (dump_insns): Update.
2027 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2028 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2029
ddbcedf5
CB
20302019-08-06 Christian Biesinger <cbiesinger@google.com>
2031
2032 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2033 (error_in_psymtab_expansion): Likewise.
2034 (lookup_symbol_via_quick_fns): Likewise.
2035 (basic_lookup_transparent_type_quick): Likewise.
2036 (basic_lookup_transparent_type_1): Likewise.
2037
b08b16c8
TT
20382019-08-06 Tom Tromey <tromey@adacore.com>
2039
2040 * source.c (last_source_error): Now bool.
2041 (print_source_lines_base): Make "noprint" bool. Only open
2042 source file when last_source_visited changes.
2043
cb44333d
TT
20442019-08-06 Tom Tromey <tromey@adacore.com>
2045
2046 * annotate.c (annotate_source_line): Use g_source_cache.
2047 * source-cache.c (source_cache::get_plain_source_lines): Change
2048 parameters. Populate m_offset_cache.
2049 (source_cache::ensure): New method.
2050 (source_cache::get_line_charpos): New method.
2051 (extract_lines): Move lower. Change parameters.
2052 (source_cache::get_source_lines): Move lower.
2053 * source-cache.h (class source_cache): Update comment.
2054 <get_line_charpos>: New method.
2055 <get_source_lines>: Update comment.
2056 <clear>: Clear m_offset_cache.
2057 <get_plain_source_lines>: Change parameters.
2058 <ensure>: New method
2059 <m_offset_cache>: New member.
2060 * source.c (forget_cached_source_info_for_objfile): Update.
2061 (info_source_command): Use g_source_cache.
2062 (find_source_lines, open_source_file_with_line_charpos): Remove.
2063 (print_source_lines_base, search_command_helper): Use g_source_cache.
2064 * source.h (open_source_file_with_line_charpos): Don't declare.
2065 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2066 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2067 Use g_source_cache.
2068
872dceaa
TT
20692019-08-06 Tom Tromey <tromey@adacore.com>
2070
2071 * source-cache.c (source_cache::get_plain_source_lines):
2072 Remove "first_line" and "last_line" parameters.
2073 (source_cache::get_source_lines): Cache plain text.
2074 * source-cache.h (class source_cache)
2075 <get_plain_source_lines>: Update.
2076
269249d9
TT
20772019-08-06 Tom Tromey <tromey@adacore.com>
2078
2079 * source-cache.c (extract_lines): No longer a method.
2080 Changed type of parameter. Include final newline.
2081 (selftests::extract_lines_test): New function.
2082 (_initialize_source_cache): Likewise.
2083 * source-cache.h (class source_cache)
2084 <extract_lines>: Don't declare.
2085
c0e8dcd8
TT
20862019-08-06 Tom Tromey <tromey@adacore.com>
2087
2088 * breakpoint.c (init_breakpoint_sal): Update.
2089 (breakpoint): Update.
2090 * breakpoint.h (struct breakpoint) <filter>: Now a
2091 unique_xmalloc_ptr.
2092
0b27c27d
CB
20932019-08-05 Christian Biesinger <cbiesinger@google.com>
2094
2095 * NEWS: Mention dictionary access on blocks.
2096 * python/py-block.c (blpy_getitem): New function.
2097 (block_object_as_mapping): New struct.
2098 (block_object_type): Use new struct for tp_as_mapping field.
2099
4ee94178
CB
21002019-08-05 Christian Biesinger <cbiesinger@google.com>
2101
2102 * objfiles.h (objfile): Add a comment describing partial symbols.
2103
8abfcabc
TT
21042019-08-05 Tom Tromey <tromey@adacore.com>
2105
2106 * compile/compile.c (_initialize_compile): Use _(), not N_().
2107 * thread.c (_initialize_thread): Use _(), not N_().
2108 * stack.c (_initialize_stack): Use _(), not N_().
2109 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2110
2b79f376
SM
21112019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2112
2113 * dwarf2read.c (struct dw2_symtab_iterator):
2114 <want_specific_block>: Remove.
2115 <block_index>: Change type to gdb::optional.
2116 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2117 change type of BLOCK_INDEX parameter to gdb::optional.
2118 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2119 (dw2_lookup_symbol): Don't pass argument for
2120 WANT_SPECIFIC_BLOCK.
2121 (dw2_expand_symtabs_for_function): Don't pass argument for
2122 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2123 (class dw2_debug_names_iterator)
2124 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2125 parameter, change BLOCK_INDEX type to gdb::optional.
2126 <m_want_specific_block>: Remove.
2127 <m_block_index>: Change type to gdb::optional.
2128 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2129 gdb::optional. Re-write in function of gdb::optional.
2130 (dw2_debug_names_lookup_symbol): Don't pass argument for
2131 WANT_SPECIFIC_BLOCK.
2132 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2133 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2134 BLOCK_INDEX.
2135
ae60f04e
PW
21362019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2137
2138 * NEWS: Mention changes to "info sources" command.
2139
28cd9371
PW
21402019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2141
2142 * symtab.c (filename_partial_match_opts): New struct type.
2143 (struct output_source_filename_data): New members
2144 regexp, c_regexp, partial_match.
2145 (output_source_filename): Use new members to decide to print file.
2146 (info_sources_option_defs): New variable.
2147 (make_info_sources_options_def_group, print_info_sources_header,
2148 info_sources_command_completer):
2149 New functions.
2150 (info_sources_command): Read new optional arguments.
2151 (_initialize_symtab): Update info sources help.
2152
ca683e3a
AO
21532019-08-02 Alexandre Oliva <oliva@adacore.com>
2154
2155 * ada-lang.c (exception_support_info_v0): Renamed from...
2156 (default_exception_support_info): ... this. Create new
2157 definition for v1.
2158 (ada_has_this_exception_support): Look up catch_handlers_sym.
2159 (ada_exception_support_info_sniffer): Try v0 after default.
2160
f1264162
TT
21612019-08-01 Tom Tromey <tromey@adacore.com>
2162
2163 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2164 gdbarch.h.
2165
0a7b2485
CB
21662019-08-01 Christian Biesinger <cbiesinger@google.com>
2167
2168 * s12z-tdep.c: Fix include path for s12z-opc.h.
2169
c6bdbeb7
AH
21702019-08-01 Alan Hayward <alan.hayward@arm.com>
2171
2172 * NEWS: Require GNU make 3.82.
2173
a2bd7b82
TT
21742019-07-16 Tom Tromey <tom@tromey.com>
2175
2176 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2177 declare.
2178
aa3b6533
TT
21792019-07-30 Tom Tromey <tromey@adacore.com>
2180
2181 * block.c (contained_in): Remove BLOCK_FUNCTION check.
2182
a1530dc7
KB
21832019-07-30 Kevin Buettner <kevinb@redhat.com>
2184
2185 * printcmd.c (print_address_symbolic): Print negative offsets.
2186 (build_address_symbolic): Force signed arithmetic when computing
2187 offset.
2188
2906593f
CB
21892019-07-30 Christian Biesinger <cbiesinger@google.com>
2190
2191 PR/24474: Add a function to lookup static variables.
2192 * NEWS: Mention this new function.
2193 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2194 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2195 * python/python.c (python_GdbMethods): Add new function.
2196
c620ed88
CB
21972019-07-29 Christian Biesinger <cbiesinger@google.com>
2198
2199 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2200 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2201 (objfpy_lookup_static_symbol): New function.
2202 (objfile_object_methods): Add new functions.
2203
bc4268a5
PW
22042019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2205
2206 * NEWS: Mention 'set|show print frame-info'. Mention new
2207 'presence' value for 'frame-arguments'. Mention new '-frame-info'
2208 backtrace argument. Mention that python frame filtering code
2209 is now consistent with what 'backtrace' command prints.
2210
4b5e8d19
PW
22112019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2212
2213 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2214 comments.
2215 (print_frame_info_auto, print_frame_info_source_line,
2216 print_frame_info_location, print_frame_info_source_and_location,
2217 print_frame_info_location_and_address, print_frame_info_short_location):
2218 New declarations.
2219 (struct frame_print_options): New member print_frame_info.
2220 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2221 * stack.h (get_user_print_what_frame_info): New declaration.
2222 (frame_show_address): New declaration.
2223 * stack.c (print_frame_arguments_choices): New value 'presence'.
2224 (print_frame_info_auto, print_frame_info_source_line,
2225 print_frame_info_location, print_frame_info_source_and_location,
2226 print_frame_info_location_and_address, print_frame_info_short_location,
2227 print_frame_info_choices, print_frame_info_print_what): New definitions.
2228 (print_frame_args): Only print dots for args if print frame-arguments
2229 is 'presence'.
2230 (frame_print_option_defs): New element for "frame-info".
2231 (get_user_print_what_frame_info): New function.
2232 (frame_show_address): Make non static. Move comment to stack.h.
2233 (print_frame_info_to_print_what): New function.
2234 (print_frame_info): Update comment. Use fp_opts.print_frame_info
2235 to decide what to print.
2236 (backtrace_command_1): Handle the new print_frame_arguments_presence
2237 value.
2238 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2239 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2240 (py_print_frame): In non-mi mode, use LOCATION as default for
2241 print_what, similarly to frame information printed directly by
2242 backtrace command. Handle frame-info user option in non MI mode.
2243
6bdfee81
KB
22442019-07-27 Kevin Buettner <kevinb@redhat.com>
2245
2246 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2247 Add case for debugging 32-bit target on 64-bit host. Revise
2248 comment.
2249
98a617f8
KB
22502019-07-27 Kevin Buettner <kevinb@redhat.com>
2251
2252 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2253 instead of find_function_entry_range_from_pc.
2254
567238c9
KB
22552019-07-27 Kevin Buettner <kevinb@redhat.com>
2256
2257 * stack.c (find_frame_funname): Remove code which preferred
2258 minsym over symtab sym in "certain pathological cases".
2259
2dc80cf8
KB
2260 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2261 parameter. Change type of "do_demangle" to bool.
2262 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2263 Pass suitable "prefer_sym_over_minsym" flag to
2264 build_address_symbolic(). Don't output "+" for negative offsets.
2265 * printcmd.c (print_address_symbolic): Update invocation of
2266 build_address_symbolic to include a "prefer_sym_over_minsym"
2267 flag.
2268 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2269 Restrict cases in which use of minimal symbol is preferred to that
2270 of a found symbol. Update comments.
2271
1aff7173
KB
2272 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2273 for entry pc when entry pc is out of range for that FDE.
2274
89b085ac
BC
22752019-07-26 Brian Callahan <bcallah@openbsd.org>
2276
2277 PR gdb/24839:
2278 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2279 type.
2280
f32feb4a
CB
22812019-07-25 Christian Biesinger <cbiesinger@google.com>
2282
2283 * python/py-objfile.c (add_separate_debug_file): Fix comment about
2284 this function's Python signature.
2285
2286
22872019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
2288
2289 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2290 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2291 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2292 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2293 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2294
2295
c54e4253
YS
22962019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
2297
2298 * h8300-tdep.c (h8300_register_name_common): New.
2299 h8300_register_name): Use h8300_register_name_common.
2300 (h8300s_register_name): Likewise.
2301 (h8300sx_register_name): Likewise.
2302 (h8300h_register_nam): New.
2303 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2304
2305
40eadf04
SP
23062019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
2307
2308 * arm-tdep.c (arm_skip_cmse_entry): New function.
2309 (arm_is_sgstubs_section): New function.
2310 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2311
bfa2a36d
TT
23122019-07-22 Tom Tromey <tom@tromey.com>
2313
2314 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2315 Don't self-assign.
2316
a8e9d247
AB
23172019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2318
2319 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2320 type_print.
2321
eb86c5e2
AB
23222019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2323
2324 * symtab.c (search_symbols): Adjust msymbol matching type arrays
2325 so that GDB doesn't match any msymbols when searching in the
2326 TYPES_DOMAIN.
2327 (print_symbol_info): Print using typedef_print or type_print based
2328 on the type of the symbol. Add updated FIXME comment moved from...
2329 (_initialize_symtab): ... move and update FIXME comment to above.
2330
a8eab7c6
AB
23312019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2332
2333 * NEWS: Mention adding -q option to "info types".
2334 * symtab.c (struct info_types_options): New struct.
2335 (info_types_options_defs): New variable.
2336 (make_info_types_options_def_group): New function.
2337 (info_types_command): Use gdb::option framework to parse options.
2338 (info_types_command_completer): New function.
2339 (_initialize_symtab): Extend the help text on "info types" and
2340 register command completer.
2341
b4603c34
CB
23422019-07-21 Christian Biesinger <cbiesinger@google.com>
2343
2344 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2345 (lookup_symbol_in_objfile): Change int to block_enum and add a
2346 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2347
c8cdc1e0
CB
23482019-07-20 Christian Biesinger <cbiesinger@google.com>
2349
2350 * MAINTAINERS (Write After Approval): Add self.
2351
01e175fe
AB
23522019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
2353
2354 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2355 instruction to the dummy code region.
2356
56f79b63
TT
23572019-07-19 Tom Tromey <tromey@adacore.com>
2358
2359 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2360 (ARGSUSED, PARAMS, __func__): Remove rules.
2361
4c5aa8e0
AH
23622019-07-19 Alan Hayward <alan.hayward@arm.com>
2363
2364 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2365 * features/arm/arm-with-iwmmxt.c: Remove.
2366 * features/arm/arm-with-iwmmxt.xml: Remove.
2367 * features/arm/arm-with-m-fpa-layout.c: Remove.
2368 * features/arm/arm-with-m-fpa-layout.xml: Remove.
2369 * features/arm/arm-with-m-vfp-d16.c: Remove.
2370 * features/arm/arm-with-m-vfp-d16.xml: Remove.
2371 * features/arm/arm-with-m.c: Remove.
2372 * features/arm/arm-with-m.xml: Remove.
2373 * features/arm/arm-with-neon.c: Remove.
2374 * features/arm/arm-with-neon.xml: Remove.
2375 * features/arm/arm-with-vfpv2.c: Remove.
2376 * features/arm/arm-with-vfpv2.xml: Remove.
2377 * features/arm/arm-with-vfpv3.c: Remove.
2378 * features/arm/arm-with-vfpv3.xml: Remove.
2379
f42b2617
AH
23802019-07-19 Alan Hayward <alan.hayward@arm.com>
2381
2382 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2383
f29ec966
AH
23842019-07-19 Alan Hayward <alan.hayward@arm.com>
2385
2386 * arch/aarch32.c (aarch32_create_target_description): Create
2387 target descriptions using features.
2388 * arch/arm.c (arm_create_target_description)
2389 (arm_create_mprofile_target_description): Likewise.
2390 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2391
d105cce5
AH
23922019-07-19 Alan Hayward <alan.hayward@arm.com>
2393
2394 * Makefile.in: Add new files.
2395 * aarch32-tdep.c: New file.
2396 * aarch32-tdep.h: New file.
2397 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2398 Call aarch32_read_description.
2399 * arch/aarch32.c: New file.
2400 * arch/aarch32.h: New file.
2401 * arch/arm.c (arm_create_target_description)
2402 (arm_create_mprofile_target_description): New function.
2403 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2404 (arm_create_target_description)
2405 (arm_create_mprofile_target_description): New declaration.
2406 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2407 read_description functions.
2408 * arm-linux-nat.c (arm_linux_nat_target::read_description):
2409 Likewise.
2410 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2411 * arm-tdep.c (tdesc_arm_list): New variable.
2412 (arm_register_g_packet_guesses): Call create description functions.
2413 (arm_read_description) (arm_read_mprofile_description): New
2414 function.
2415 * arm-tdep.h (arm_read_description)
2416 (arm_read_mprofile_description): Add declaration.
2417 * configure.tgt: Add new files.
2418
afe09f0b
GL
24192019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
2420
2421 * top.c (new_ui_command): Open specified terminal just once.
2422
cd215b2e
TT
24232019-07-18 Tom Tromey <tromey@adacore.com>
2424
2425 * symtab.c (main_name): Constify return type.
2426 * symfile.c (set_initial_language): Update.
2427 * symtab.h (main_name): Constify return type.
2428
d8f68fcb
TT
24292019-07-17 Tom Tromey <tom@tromey.com>
2430
2431 * tui/tui-winsource.c (tui_update_source_window)
2432 (tui_update_source_window_as_is)
2433 (tui_update_source_windows_with_line): Remove return.
2434 * tui/tui-disasm.c (tui_show_disassem)
2435 (tui_show_disassem_and_update_source): Remove return.
2436 * tui/tui.c (tui_reset): Remove return.
2437 * tui/tui-wingeneral.c
2438 (tui_check_and_display_highlight_if_needed): Remove return.
2439
ca5af91e
TT
24402019-07-17 Tom Tromey <tom@tromey.com>
2441
2442 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2443
5104fe36
TT
24442019-07-17 Tom Tromey <tom@tromey.com>
2445
2446 * tui/tui-winsource.h (struct tui_exec_info_window)
2447 (struct tui_source_window_base): Move from tui-data.h.
2448 * tui/tui-winsource.c: Move many method definitions from
2449 elsewhere. Remove "structuring" comments.
2450 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2451 (tui_source_window_base::refresh_window): Move to
2452 tui-winsource.c.
2453 * tui/tui-win.c (tui_source_window_base::refresh_all)
2454 (tui_source_window_base::update_tab_width)
2455 (tui_source_window_base::set_new_height)
2456 (tui_source_window_base::do_make_visible_with_new_height): Move to
2457 tui-winsource.c.
2458 * tui/tui-source.h: Update.
2459 * tui/tui-source.c (tui_source_window_base::reset): Move to
2460 tui-winsource.c.
2461 * tui/tui-disasm.h: Update.
2462 * tui/tui-data.h (struct tui_exec_info_window): Move to
2463 tui-winsource.h.
2464 (struct tui_source_window_base): Likewise.
2465 * tui/tui-data.c (tui_source_window_base::clear_detail)
2466 (tui_source_window_base, ~tui_source_window_base): Move to
2467 tui-winsource.c.
2468
daa15dde
TT
24692019-07-17 Tom Tromey <tom@tromey.com>
2470
2471 * tui/tui-win.c (tui_resize_all)
2472 (tui_source_window_base::update_tab_width)
2473 (tui_adjust_win_heights): Update.
2474 (tui_win_info::make_invisible_and_set_new_height): Rename from
2475 make_invisible_and_set_new_height.
2476 * tui/tui-data.h (struct tui_win_info)
2477 <make_invisible_and_set_new_height>: New method.
2478
bfad4537
TT
24792019-07-17 Tom Tromey <tom@tromey.com>
2480
2481 * tui/tui.c: Update.
2482 * tui/tui-source.h (struct tui_source_window): Move from
2483 tui-data.h.
2484 * tui/tui-layout.c: Update.
2485 * tui/tui-disasm.c: Update.
2486 * tui/tui-data.h (struct tui_source_window): Move to
2487 tui-source.h.
2488
88f7e873
TT
24892019-07-17 Tom Tromey <tom@tromey.com>
2490
2491 * tui/tui-disasm.h (struct tui_disasm_window): Move from
2492 tui-data.h.
2493 * tui/tui-data.h (struct tui_disasm_window): Move to
2494 tui-disasm.h.
2495
96bd6233
TT
24962019-07-17 Tom Tromey <tom@tromey.com>
2497
2498 * tui/tui-regs.h (struct tui_data_item_window): Move from
2499 tui-data.h.
2500 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2501 * tui/tui-data.h (struct tui_data_item_window): Move to
2502 tui-regs.h.
2503 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2504
ce38393b
TT
25052019-07-17 Tom Tromey <tom@tromey.com>
2506
2507 * tui/tui.c: Update.
2508 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2509 (tui_cmd_window::max_height): Move to tui-command.c.
2510 * tui/tui-layout.c: Update.
2511 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2512 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2513 tui-command.c.
2514 * tui/tui-command.h (struct tui_cmd_window): Move from
2515 tui-data.h.
2516 * tui/tui-command.c: Remove "structuring" comments.
2517 (tui_cmd_window::clear_detail)
2518 (tui_cmd_window::do_make_visible_with_new_height)
2519 (tui_cmd_window::max_height): Move from elsewhere.
2520
2d8b51cb
TT
25212019-07-17 Tom Tromey <tom@tromey.com>
2522
2523 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2524 Now static.
2525 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2526 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2527
18ab23af
TT
25282019-07-17 Tom Tromey <tom@tromey.com>
2529
2530 * tui/tui.c: Update.
2531 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2532 tui-regs.c.
2533 * tui/tui-windata.h: Remove file.
2534 * tui/tui-windata.c: Remove file.
2535 * tui/tui-win.c (tui_data_window::set_new_height)
2536 (tui_data_window::do_make_visible_with_new_height): Move to
2537 tui-regs.c.
2538 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2539 * tui/tui-regs.c: Remove "structuring" comments.
2540 (tui_data_window::first_data_item_displayed)
2541 (tui_data_window::delete_data_content_windows)
2542 (tui_data_window::erase_data_content)
2543 (tui_data_window::display_all_data)
2544 (tui_data_window::refresh_all)
2545 (tui_data_window::do_scroll_vertical)
2546 (tui_data_window::clear_detail, tui_data_window::set_new_height)
2547 (tui_data_window::do_make_visible_with_new_height)
2548 (tui_data_window::refresh_window): Move from elsewhere.
2549 (_initialize_tui_regs): Move to end of file.
2550 * tui/tui-layout.c: Update.
2551 * tui/tui-hooks.c: Update.
2552 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2553 * tui/tui-data.c (tui_data_window::clear_detail): Move to
2554 tui-regs.c.
2555 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2556
88b7e7cc
TT
25572019-07-17 Tom Tromey <tom@tromey.com>
2558
2559 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2560 seen.
2561
0fcd3711
TT
25622019-07-17 Tom Tromey <tom@tromey.com>
2563
2564 * tui/tui-win.c (tui_source_window_base::set_new_height)
2565 (tui_source_window_base::do_make_visible_with_new_height): Use
2566 m_has_locator field directly.
2567 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2568 method.
2569 (struct tui_source_window_base) <has_locator>: Likewise.
2570
4a38112d
TT
25712019-07-17 Tom Tromey <tom@tromey.com>
2572
2573 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2574 Don't declare.
2575 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2576 Remove.
2577 * tui/tui-win.c (tui_source_window_base::set_new_height)
2578 (tui_source_window_base::set_new_height)
2579 (make_invisible_and_set_new_height)
2580 (tui_source_window_base::do_make_visible_with_new_height)
2581 (tui_source_window_base::do_make_visible_with_new_height):
2582 Update.
2583 * tui/tui-layout.c (show_source_disasm_command, show_data)
2584 (show_source_or_disasm_and_command): Update.
2585 * tui/tui-layout.c (show_layout): Update.
2586
09129226
TT
25872019-07-17 Tom Tromey <tom@tromey.com>
2588
2589 * tui/tui-layout.c (make_data_window): Remove.
2590 (show_data): Unify creation and re-initialization cases.
2591
4a8a5e84
TT
25922019-07-17 Tom Tromey <tom@tromey.com>
2593
2594 * tui/tui-layout.c (make_source_window, make_disasm_window):
2595 Remove.
2596 (show_data): Unify creation and re-initialization cases.
2597
76d2be8e
TT
25982019-07-17 Tom Tromey <tom@tromey.com>
2599
2600 * tui/tui-layout.c (make_command_window): Remove.
2601 (show_source_disasm_command, show_source_or_disasm_and_command):
2602 Unify creation and re-initialization cases.
2603
890b8bde
TT
26042019-07-17 Tom Tromey <tom@tromey.com>
2605
2606 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2607 creation and re-initialization cases.
2608
2cdfa113
TT
26092019-07-17 Tom Tromey <tom@tromey.com>
2610
2611 * tui/tui-regs.c (tui_get_register): Return void.
2612
8e3cfd09
TT
26132019-07-17 Tom Tromey <tom@tromey.com>
2614
2615 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2616 Simplify.
2617
f4e04977
TT
26182019-07-17 Tom Tromey <tom@tromey.com>
2619
2620 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2621 resetting.
2622
0379b883
TT
26232019-07-17 Tom Tromey <tom@tromey.com>
2624
2625 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2626 * tui/tui-regs.c (tui_reg_layout): New function.
2627 (tui_show_registers, tui_reg_command): Use it.
2628 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2629 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2630 parameters.
2631 (tui_layout_command): Remove.
2632
b7fbad91
TT
26332019-07-17 Tom Tromey <tom@tromey.com>
2634
2635 * tui/tui-layout.h (tui/tui-layout): Return void.
2636 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2637
4e1e56b9
TT
26382019-07-17 Tom Tromey <tom@tromey.com>
2639
2640 * tui/tui-layout.c (show_source_disasm_command, show_data):
2641 Update.
2642 (reset_locator): Remove.
2643 (show_source_or_disasm_and_command): Update.
2644
1e0c09ba
TT
26452019-07-17 Tom Tromey <tom@tromey.com>
2646
2647 * tui/tui-source.c (tui_source_window_base::reset): Remove
2648 win_type parameter.
2649 * tui/tui-layout.c (make_command_window, make_source_window)
2650 (make_disasm_window, make_data_window)
2651 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2652 (reset_locator, show_source_or_disasm_and_command): Update.
2653 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2654 win_type parameter.
2655 (struct tui_source_window_base) <reset>: Likewise.
2656
1bf605de
TT
26572019-07-17 Tom Tromey <tom@tromey.com>
2658
2659 * tui/tui-layout.c (show_source_disasm_command): Use
2660 reset_locator.
2661 (reset_locator): New function.
2662 (init_and_make_win): Remove.
2663 (show_source_or_disasm_and_command): Use reset_locator.
2664
098f9ed4
TT
26652019-07-17 Tom Tromey <tom@tromey.com>
2666
2667 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2668 condition.
2669 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2670 Remove condition.
2671 * tui/tui-source.c (tui_source_window_base::reset): New method.
2672 * tui/tui-layout.c (make_command_window): Don't call
2673 init_and_make_win.
2674 (make_source_window, make_disasm_window): Don't call
2675 make_source_or_disasm_window.
2676 (make_data_window): Don't call init_and_make_win. Change calling
2677 convention.
2678 (show_source_disasm_command, show_data): Simplify.
2679 (make_source_or_disasm_window): Remove.
2680 (show_source_or_disasm_and_command): Simplify.
2681 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2682 (struct tui_source_window_base) <reset>: Likewise.
2683 <execution_info>: Remove initializer.
2684 * tui/tui-data.c (tui_source_window_base): Initialize
2685 execution_info.
2686
80110957
TT
26872019-07-17 Tom Tromey <tom@tromey.com>
2688
2689 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2690 variable.
2691
cf82af05
TT
26922019-07-17 Tom Tromey <tom@tromey.com>
2693
2694 * tui/tui.c (tui_rl_other_window): Update.
2695 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2696 superclass method first. Always iterate over regs_content.
2697 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2698 method.
2699 * tui/tui-win.c (tui_set_focus_command): Update.
2700
01aeb396
TT
27012019-07-17 Tom Tromey <tom@tromey.com>
2702
2703 * tui/tui-win.c (tui_set_focus_command): Rename from
2704 tui_set_focus. Call tui_enable.
2705 (tui_set_focus_command): Remove.
2706
fd6c75ee
TT
27072019-07-17 Tom Tromey <tom@tromey.com>
2708
2709 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2710 refresh_window.
2711 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2712 touchwin.
2713 (tui_data_window::refresh_window): Call refresh_window on data
2714 items. Always call superclass refresh_window.
2715 (tui_win_info::refresh): Remove.
2716 (tui_source_window_base::refresh_window): Update.
2717 (tui_refresh_all): Update.
2718 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2719 refresh_window.
2720 (show_source_or_disasm_and_command): Likewise.
2721 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2722 (struct tui_source_window_base) <refresh>: Likewise.
2723
f6cc34a9
TT
27242019-07-17 Tom Tromey <tom@tromey.com>
2725
2726 * tui/tui-winsource.c (tui_clear_source_content)
2727 (tui_show_source_content): Update.
2728 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2729 whether content is empty.
2730 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2731 Remove.
2732
f31ec9af
TT
27332019-07-17 Tom Tromey <tom@tromey.com>
2734
2735 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2736 window's contents.
2737 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2738 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2739
d1b6f1e5
TT
27402019-07-17 Tom Tromey <tom@tromey.com>
2741
2742 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2743 (struct tui_data_item_window): Update.
2744
d9743a13
TT
27452019-07-17 Tom Tromey <tom@tromey.com>
2746
2747 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2748 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2749 defines.
2750
caf0bc4e
TT
27512019-07-17 Tom Tromey <tom@tromey.com>
2752
2753 * tui/tui-winsource.h (tui_erase_source_content)
2754 (tui_clear_source_content): Remove "display_prompt" parameter.
2755 * tui/tui-winsource.c (tui_update_source_window_as_is)
2756 (tui_update_source_windows_with_addr): Update.
2757 (tui_clear_source_content): Remove "display_prompt" parameter.
2758 (tui_erase_source_content): Likewise. Simplify.
2759 (tui_show_source_content): Update.
2760 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2761 * tui/tui-stack.c (tui_show_frame_info): Update.
2762 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2763 Remove defines.
2764
9d391078
TT
27652019-07-17 Tom Tromey <tom@tromey.com>
2766
2767 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2768 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2769 parameter.
2770 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2771 parameter.
2772
a38da35d
TT
27732019-07-17 Tom Tromey <tom@tromey.com>
2774
2775 * tui/tui-winsource.c (tui_clear_source_content)
2776 (tui_show_source_content, tui_show_exec_info_content)
2777 (tui_clear_exec_info_content): Update.
2778 * tui/tui-stack.c (tui_show_locator_content): Update.
2779 (tui_show_frame_info): Update.
2780 * tui/tui-source.h (tui_source_window): Don't declare.
2781 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2782 from tui_source_is_displayed.
2783 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2784 Remove field.
2785 (struct tui_source_window_base) <content_in_use>: New field. Now
2786 bool.
2787 (struct tui_source_window) <showing_source_p>: New method.
2788 (TUI_SRC_WIN): Change cast.
2789 * tui/tui-data.c (tui_initialize_static_data): Update.
2790
c2cd8994
TT
27912019-07-17 Tom Tromey <tom@tromey.com>
2792
2793 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2794 location_matches_p.
2795 * tui/tui-source.c (tui_source_window::location_matches_p): New
2796 method.
2797 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2798 method.
2799 * tui/tui-data.h (struct tui_source_window_base)
2800 <location_matches_p>: New method.
2801 (struct tui_source_window, struct tui_disasm_window)
2802 <location_matches_p>: Likewise.
2803
4dde7b34
TT
28042019-07-17 Tom Tromey <tom@tromey.com>
2805
2806 * tui/tui-win.c (tui_set_win_height_command): Rename from
2807 tui_set_win_height.
2808 (tui_set_win_height_command): Remove.
2809
b73dd877
TT
28102019-07-17 Tom Tromey <tom@tromey.com>
2811
2812 * tui/tui-source.c (tui_source_window): New constructor. Add
2813 observer.
2814 (~tui_source_window): New destructor.
2815 (tui_source_window::style_changed): New method.
2816 * tui/tui-hooks.c (tui_redisplay_source): Remove.
2817 (tui_attach_detach_observers): Update.
2818 * tui/tui-data.h (struct tui_source_window): Make constructor not
2819 inline. Add destructor.
2820 (struct tui_source_window) <style_changed>: New method.
2821 <m_observable>: New member.
2822
ae2b5380
TT
28232019-07-17 Tom Tromey <tom@tromey.com>
2824
2825 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2826 * tui/tui-win.c (tui_resize_all): Fix typo.
2827
1ce3e844
TT
28282019-07-17 Tom Tromey <tom@tromey.com>
2829
2830 * tui/tui-wingeneral.h (tui_refresh_all): Update.
2831 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2832 (tui_refresh_all): Remove "list" parameter. Use foreach.
2833 * tui/tui-win.c (window_name_completer): Use foreach.
2834 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2835 (update_tab_width): Likewise.
2836 * tui/tui-layout.c (show_layout): Update.
2837 * tui/tui-data.h (class tui_window_iterator): New.
2838 (struct all_tui_windows): New.
2839 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2840
fe3eaf1c
TT
28412019-07-17 Tom Tromey <tom@tromey.com>
2842
2843 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2844 parameter. Don't reference globals.
2845 (tui_reg_command): Update.
2846
368c1354
TT
28472019-07-17 Tom Tromey <tom@tromey.com>
2848
2849 * tui/tui-regs.c (tui_show_registers): Simplify.
2850
e80cd204
TT
28512019-07-17 Tom Tromey <tom@tromey.com>
2852
2853 * tui/tui-regs.c (tui_show_registers): Update.
2854 (tui_show_register_group): Add win_info parameter.
2855
aca2dd16
TT
28562019-07-17 Tom Tromey <tom@tromey.com>
2857
2858 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2859 Rename from tui_display_reg_element_at_line.
2860 (tui_data_window::display_registers_from_line): Update.
2861 * tui/tui-data.h (struct tui_data_window)
2862 <display_reg_element_at_line>: New method.
2863
517e9505
TT
28642019-07-17 Tom Tromey <tom@tromey.com>
2865
2866 * tui/tui-regs.h (tui_display_registers_from)
2867 (tui_display_registers_from_line): Don't declare.
2868 * tui/tui-windata.c (tui_data_window::display_all_data)
2869 (tui_data_window::refresh_all)
2870 (tui_data_window::do_scroll_vertical): Update.
2871 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2872 from tui_display_registers_from.
2873 (tui_display_reg_element_at_line): Update.
2874 (tui_data_window::display_registers_from_line): Rename from
2875 tui_display_registers_from_line.
2876 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2877 display_registers_from_line>: New methods.
2878
f76d8b19
TT
28792019-07-17 Tom Tromey <tom@tromey.com>
2880
2881 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2882 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2883 from tui_erase_data_content.
2884 (tui_data_window::display_all_data)
2885 (tui_data_window::refresh_all)
2886 (tui_data_window::do_scroll_vertical): Update.
2887 * tui/tui-regs.c (tui_show_registers): Update.
2888 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2889 New method.
2890
b4094625
TT
28912019-07-17 Tom Tromey <tom@tromey.com>
2892
2893 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2894 declare.
2895 * tui/tui-windata.c
2896 (tui_data_window::delete_data_content_windows): Rename from
2897 tui_delete_data_content_windows.
2898 (tui_data_window::display_all_data)
2899 (tui_data_window::do_scroll_vertical): Update.
2900 * tui/tui-data.h (struct tui_data_window)
2901 <delete_data_content_windows>: New method.
2902
c223a729
TT
29032019-07-17 Tom Tromey <tom@tromey.com>
2904
2905 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2906 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2907
50daf268
TT
29082019-07-17 Tom Tromey <tom@tromey.com>
2909
2910 * tui/tui-windata.h (tui_display_all_data): Don't declare.
2911 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2912 from tui_display_all_data.
2913 * tui/tui-win.c
2914 (tui_data_window::do_make_visible_with_new_height): Update.
2915 * tui/tui-regs.c (tui_show_registers): Update.
2916 * tui/tui-layout.c (tui_set_layout): Update.
2917 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2918 method.
2919
df5f8cab
TT
29202019-07-17 Tom Tromey <tom@tromey.com>
2921
2922 * tui/tui-windata.h (tui_display_data_from): Don't declare.
2923 * tui/tui-windata.c (tui_display_data_from): Remove.
2924 (tui_data_window::refresh_all): Update.
2925
80cb6c27
TT
29262019-07-17 Tom Tromey <tom@tromey.com>
2927
2928 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2929 * tui/tui-windata.c (tui_display_data_from_line): Remove.
2930 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2931 tui_display_registers_from_line.
2932 * tui/tui-regs.h (tui_display_registers_from_line): Update.
2933 * tui/tui-regs.c (tui_display_registers_from_line): Remove
2934 "force_display" parameter.
2935
baff0c28
TT
29362019-07-17 Tom Tromey <tom@tromey.com>
2937
2938 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2939 declare.
2940 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2941 Rename from tui_first_reg_element_no_inline.
2942 (tui_display_reg_element_at_line)
2943 (tui_display_registers_from_line): Update.
2944 * tui/tui-data.h (struct tui_data_window)
2945 <first_reg_element_no_inline>: New method.
2946
3b23c5f2
TT
29472019-07-17 Tom Tromey <tom@tromey.com>
2948
2949 * tui/tui-windata.c (tui_display_data_from)
2950 (tui_data_window::do_scroll_vertical): Update.
2951 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2952 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2953 Rename from tui_line_from_reg_element_no.
2954 (tui_display_registers_from_line): Update.
2955 * tui/tui-data.h (struct tui_data_window)
2956 <line_from_reg_element_no>: New method.
2957
0b5ec218
TT
29582019-07-17 Tom Tromey <tom@tromey.com>
2959
2960 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2961 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2962 tui_last_regs_line_no.
2963 (tui_display_reg_element_at_line)
2964 (tui_display_registers_from_line): Update.
2965 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2966 method.
2967
0807ab7b
TT
29682019-07-17 Tom Tromey <tom@tromey.com>
2969
2970 PR tui/24722:
2971 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2972 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2973 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2974 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2975 (tui_update_breakpoint_info): Likewise.
2976 * tui/tui-hooks.c (tui_event_create_breakpoint)
2977 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2978 Update.
2979
9ad7fdef
TT
29802019-07-17 Tom Tromey <tom@tromey.com>
2981
2982 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2983
5813316f
TT
29842019-07-17 Tom Tromey <tom@tromey.com>
2985
2986 * tui/tui-winsource.c (tui_update_source_window_as_is)
2987 (tui_update_source_windows_with_addr): Update.
2988 * tui/tui-source.h (tui_set_source_content)
2989 (tui_show_symtab_source): Add "win_info" parameter.
2990 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2991 parameter.
2992 (tui_show_symtab_source): Likewise.
2993
00e264e7
TT
29942019-07-17 Tom Tromey <tom@tromey.com>
2995
2996 * tui/tui-wingeneral.c
2997 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2998
06210ce4
TT
29992019-07-17 Tom Tromey <tom@tromey.com>
3000
3001 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3002 (struct tui_cmd_window) <can_scroll>: New method.
3003 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3004 method.
3005
381befee
TT
30062019-07-17 Tom Tromey <tromey@adacore.com>
3007
3008 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3009 do_field_signed>: Rename. Change type of "value".
3010 * ui-out.c (ui_out::field_signed): Rename from field_int.
3011 Change type of "value".
3012 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3013 type of "value".
3014 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3015 do_field_int. Change type of "value".
3016 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3017 do_field_int. Change type of "value".
3018 * tracepoint.c (trace_status_mi, tfind_1)
3019 (print_one_static_tracepoint_marker): Update.
3020 * thread.c (print_thread_info_1, print_selected_thread_frame):
3021 Update.
3022 * stack.c (print_frame, print_frame_info): Update.
3023 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3024 Update.
3025 * source.c (print_source_lines_base): Update.
3026 * skip.c (info_skip_command): Update.
3027 * record-btrace.c (btrace_ui_out_decode_error)
3028 (btrace_call_history_src_line): Update.
3029 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3030 Update.
3031 * progspace.c (print_program_space): Update.
3032 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3033 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3034 do_field_int. Change type of "value".
3035 * mi/mi-out.c (mi_ui_out::do_table_begin)
3036 (mi_ui_out::do_table_header): Update.
3037 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3038 type of "value".
3039 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3040 (mi_cmd_data_list_changed_registers, output_register)
3041 (mi_cmd_data_read_memory, mi_load_progress)
3042 (mi_cmd_trace_frame_collected): Update.
3043 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3044 Update.
3045 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3046 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3047 (mi_cmd_var_list_children, varobj_update_one): Update.
3048 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3049 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3050 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3051 * inferior.c (print_inferior): Update.
3052 * gdb_bfd.c (print_one_bfd): Update.
3053 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3054 Update.
3055 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3056 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3057 do_field_int. Change type of "value".
3058 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3059 do_field_int. Change type of "value".
3060 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3061 (print_one_breakpoint_location, print_it_catch_fork)
3062 (print_one_catch_fork, print_it_catch_vfork)
3063 (print_one_catch_vfork, print_it_catch_solib)
3064 (print_it_catch_exec, print_it_ranged_breakpoint)
3065 (print_mention_watchpoint, print_mention_masked_watchpoint)
3066 (bkpt_print_it, update_static_tracepoint): Update.
3067 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3068 * break-catch-syscall.c (print_it_catch_syscall): Update.
3069 * ada-tasks.c (print_ada_task_info): Update.
3070 * ada-lang.c (print_it_exception, print_mention_exception):
3071 Update.
3072
6b78c3f8
AB
30732019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3074
3075 PR breakpoints/24541
3076 * gdbarch.c: Regenerate.
3077 * gdbarch.h: Regenerate.
3078 * gdbarch.sh: Adjust return type and parameter types for
3079 'stap_adjust_register'.
3080 (i386_stap_adjust_register): Adjust signature and return new
3081 register name.
3082 * stap-probe.c (stap_parse_register_operand): Adjust use of
3083 'gdbarch_stap_adjust_register'.
3084
d72a9b85
TT
30852019-07-17 Tom Tromey <tromey@adacore.com>
3086
3087 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3088 declare VEC.
3089 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3090 std::vector.
3091 (struct s390_process_info): Add initializers.
3092 (s390_add_process): Use new.
3093 (s390_linux_nat_target::low_forget_process): Use delete.
3094 (s390_linux_nat_target::low_new_fork)
3095 (s390_linux_nat_target::stopped_by_watchpoint)
3096 (s390_linux_nat_target::low_prepare_to_resume)
3097 (s390_linux_nat_target::insert_watchpoint)
3098 (s390_linux_nat_target::insert_hw_breakpoint)
3099 (s390_linux_nat_target::remove_watchpoint)
3100 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3101
206e6c58
JB
31022019-07-16 John Baldwin <jhb@FreeBSD.org>
3103
3104 * aarch64-fbsd-nat.c: Include regcache.h.
3105 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3106 argument.
3107 (aarch64_fbsd_nat_target::fetch_registers)
3108 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3109 variable.
3110 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3111
cbde90f2
JB
31122019-07-16 John Baldwin <jhb@FreeBSD.org>
3113
3114 * fbsd-nat.c: Include gdbarch.h.
3115
07128006
TT
31162019-07-15 Tom Tromey <tromey@adacore.com>
3117
3118 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3119
1f77b012
TT
31202019-07-15 Tom Tromey <tromey@adacore.com>
3121
3122 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3123 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3124 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3125 * cli-out.c (cli_ui_out::do_field_int): New method.
3126 * ui-out.c (ui_out::field_unsigned): New method.
3127 * symfile.c (generic_load): Use field_unsigned.
3128 (print_transfer_performance): Likewise.
3129 * record-btrace.c (ui_out_field_uint): Remove.
3130 (btrace_call_history_insn_range, btrace_call_history): Use
3131 field_unsigned.
3132 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3133 field_unsigned.
3134 * ui-out.h (class ui_out) <field_unsigned>: New method.
3135 <do_field_unsigned>: Likewise.
3136
33eca680
TT
31372019-07-15 Tom Tromey <tromey@adacore.com>
3138
3139 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3140 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3141 * target.c (flash_erase_command): Use field_string.
3142 * infrun.c (print_signal_received_reason): Use field_string.
3143 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3144 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3145 field_string.
3146 * ada-tasks.c (print_ada_task_info): Use field_string.
3147
ca8d69be
TT
31482019-07-15 Tom Tromey <tromey@adacore.com>
3149
3150 * target.c (flash_erase_command): Use field_core_addr.
3151 * symfile.c (generic_load): Use field_core_addr.
3152 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3153 Use field_core_addr.
3154 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3155 field_core_addr.
3156
0d4e84ed
AB
31572019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3158
3159 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3160 value if its desired type is smaller than a CORE_ADDR and signed.
3161
9a49df9d
AB
31622019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3163
3164 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3165 of changes to field names, and use new is_reference field to
3166 decide if a property is a reference or not.
3167 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3168 field.
3169 (struct dwarf2_property_baton): Update header comment, rename
3170 'referenced_type' to 'property_type' and update comments.
3171 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3172 default property type, store in property baton, update to take
3173 accound of renamed field.
3174 (read_func_scope): Update call to attr_to_dynamic_prop.
3175 (read_array_type): Likewise.
3176 (dwarf2_per_cu_addr_sized_int_type): New function.
3177 (read_subrange_index_type): Move type finding code to
3178 dwarf2_per_cu_addr_sized_int_type.
3179 (read_subrange_type): Update calls to attr_to_dynamic_prop.
3180 (dwarf2_per_cu_addr_type): New function.
3181 (set_die_type): Update calls to attr_to_dynamic_prop.
3182
b86352cf
AB
31832019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3184
3185 * dwarf2read.c (read_subrange_index_type): New function.
3186 (read_subrange_type): Move code into new function and call it.
3187 * gdbtypes.c (create_range_type): Add some asserts.
3188
603490bf
AB
31892019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3190
3191 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3192 update return statements.
3193 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3194 declaration, and update comment to match.
3195 * gdbtypes.c (resolve_dynamic_array): Update call to
3196 dwarf2_evaluate_property to match new return type.
3197
592f9d27
AB
31982019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3199
3200 * valarith.c (value_subscripted_rvalue): Change lowerbound
3201 parameter type from int to LONGEST.
3202 * value.h (value_subscripted_rvalue): Likewise in declaration.
3203
60cfcb20
AB
32042019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3205
3206 * cli/cli-utils.c (info_print_command_completer): New function.
3207 * cli/cli-utils.h: Add 'completer.h' include, and forward
3208 declaration for 'struct cmd_list_element'.
3209 (info_print_command_completer): Declare.
3210 * stack.c (_initialize_stack): Add completer for 'info locals' and
3211 'info args'.
3212 * symtab.c (_initialize_symtab): Add completer for 'info
3213 variables' and 'info functions'.
3214 * NEWS: Mention completion for additional info commands.
3215
b16507e0
AB
32162019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3217
3218 * cli/cli-utils.c (extract_info_print_args): Delete.
3219 (extract_arg_maybe_quoted): Delete.
3220 (info_print_options_defs): New variable.
3221 (make_info_print_options_def_group): New function.
3222 (extract_info_print_options): Define new function.
3223 * cli/cli-utils.h (extract_info_print_args): Delete.
3224 (struct info_print_options): New structure.
3225 (extract_info_print_options): Declare new function.
3226 * stack.c (info_locals_command): Update to use new
3227 extract_info_print_options, also add a header comment.
3228 (info_args_command): Likewise.
3229 * symtab.c (info_variables_command): Likewise.
3230 (info_functions_command): Likewise.
3231
021d8588
AB
32322019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3233
3234 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3235 to extract string arguments.
3236 * common/common-utils.c (extract_string_maybe_quoted): New function.
3237 * common/common-utils.h (extract_string_maybe_quoted): Declare.
3238
b777eb6d
TT
32392019-07-11 Tom Tromey <tromey@adacore.com>
3240
3241 * main.c (get_init_files): Use GDBINIT, not gdbinit.
3242 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3243 * top.h (gdbinit): Don't declare.
3244 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3245 into...
3246 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
3247 * top.c (gdb_init): Don't call init_cli_cmds.
3248 (gdbinit): Remove.
3249 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3250
72ee03ff
TT
32512019-07-11 Tom Tromey <tromey@adacore.com>
3252
3253 * python/py-inferior.c (add_thread_object): Don't use thread_obj
3254 after it has been moved.
3255
00db9531
SM
32562019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3257
3258 * valops.c (value_must_coerce_to_target): Change return type to
3259 bool.
3260 * value.h (value_must_coerce_to_target): Likewise.
3261
f2478a7e
SM
32622019-07-10 Simon Marchi <simon.marchi@efficios.com>
3263
3264 * breakpoint.c (is_hardware_watchpoint): Remove
3265 forward-declaration.
3266 (is_masked_watchpoint): Change return type to bool.
3267 (is_tracepoint): Likewise.
3268 (is_breakpoint): Likewise.
3269 (is_hardware_watchpoint): Likewise.
3270 (is_watchpoint): Likewise.
3271 (is_no_memory_software_watchpoint): Likewise.
3272 (is_catchpoint): Likewise.
3273 (breakpoint_1): Make FILTER parameter's return type bool.
3274 is_masked_watchpoint): Change return type to bool.
3275 (save_breakpoints): Make FILTER parameter's return type bool.
3276 * breakpoint.h (is_breakpoint): Change return type to bool.
3277 (is_watchpoint): Likewise.
3278 (is_catchpoint): Likewise.
3279 (is_tracepoint): Likewise.
3280
0d12e84c
TT
32812019-07-10 Tom Tromey <tom@tromey.com>
3282
3283 * defs.h: Don't include gdbarch.h.
3284 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3285 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3286 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3287 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3288 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3289 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3290 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3291 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3292 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3293 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3294 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3295 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3296 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3297 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3298 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3299 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3300 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3301 record-btrace.c, record.h, regcache-dump.c, regcache.h,
3302 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3303 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3304 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3305 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3306 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3307 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3308 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3309 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3310 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3311
f06f1252
TT
33122019-07-10 Tom Tromey <tromey@adacore.com>
3313
3314 * ada-lang.h (is_ada_exception_catchpoint): Declare.
3315 * breakpoint.c (init_ada_exception_breakpoint): Register as
3316 bp_catchpoint.
3317 (print_one_breakpoint_location, print_one_breakpoint): Use
3318 is_ada_exception_catchpoint.
3319 * ada-lang.c (class ada_catchpoint_location): Pass
3320 bp_loc_software_breakpoint to bp_location constructor.
3321 (is_ada_exception_catchpoint): New function.
3322
7a5d944b
TT
33232019-07-10 Tom Tromey <tromey@adacore.com>
3324
3325 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
3326 VEC.
3327 (struct arm_exidx_entry): New method operator<.
3328 (struct arm_exidx_data) <section_maps>: Change type.
3329 (arm_exidx_data_free): Remove.
3330 (arm_exidx_data_key): Change type. Move lower.
3331 (arm_exidx_new_objfile): Update.
3332 (arm_compare_exidx_entries): Remove.
3333 (arm_find_exidx_entry, _initialize_arm_tdep)
3334
48c66e1d
TT
33352019-07-10 Tom Tromey <tromey@adacore.com>
3336
3337 * solib-spu.c (ocl_program_data_key): Change type.
3338 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3339 Update.
3340
a269fbf1
TT
33412019-07-10 Tom Tromey <tromey@adacore.com>
3342
3343 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
3344 (struct solib_aix_inferior_data) <library_list>: Change type.
3345 (solib_aix_inferior_data_handle): Change type.
3346 (get_solib_aix_inferior_data): Update.
3347 (solib_aix_free_library_list): Remove.
3348 (library_list_start_library): Update.
3349 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3350 return type.
3351 (solib_aix_get_library_list)
3352 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3353 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3354
c294730c
TT
33552019-07-10 Tom Tromey <tromey@adacore.com>
3356
3357 * solib-dsbt.c (struct dsbt_info): Add initializers.
3358 (solib_dsbt_pspace_data): Change type.
3359 (dsbt_pspace_data_cleanup): Remove.
3360 (get_dsbt_info, _initialize_dsbt_solib): Update.
3361
9d52077d
TT
33622019-07-10 Tom Tromey <tromey@adacore.com>
3363
3364 * spu-tdep.c (spu_overlay_data): Change type.
3365 (spu_get_overlay_table, spu_overlay_new_objfile)
3366 (_initialize_spu_tdep): Update.
3367
22a20dca
TT
33682019-07-10 Tom Tromey <tromey@adacore.com>
3369
3370 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3371 destructor.
3372 (dbx_objfile_data_key): Change type and declare later.
3373 (DBX_SYMFILE_INFO): Rewrite.
3374 * dbxread.c (dbx_objfile_data_key): Change type.
3375 (dbx_symfile_init): Update.
3376 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
3377 (coffstab_build_psymtabs, elfstab_build_psymtabs)
3378 (stabsect_build_psymtabs, _initialize_dbxread): Update.
3379
cb60f420
TT
33802019-07-10 Tom Tromey <tromey@adacore.com>
3381
3382 * jit.c (jit_program_space_key): Change type. Move lower.
3383 (get_jit_program_space_data): Update.
3384 (jit_program_space_data_cleanup): Remove.
3385 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3386 Update.
3387 (struct jit_program_space_data): Add initializers.
3388
51df2ae3
TT
33892019-07-10 Tom Tromey <tromey@adacore.com>
3390
3391 * solib-darwin.c (struct darwin_info): Add initializers.
3392 (solib_darwin_pspace_data): Change type.
3393 (darwin_pspace_data_cleanup): Remove.
3394 (get_darwin_info, _initialize_darwin_solib): Update.
3395
18101a35
TT
33962019-07-10 Tom Tromey <tromey@adacore.com>
3397
3398 * remote-sim.c (struct sim_inferior_data): Add initializers,
3399 constructor, and destructor.
3400 (sim_inferior_data_key): Change type. Move lower.
3401 (check_for_duplicate_sim_descriptor): Update.
3402 (get_sim_inferior_data): Use new. Update.
3403 (~sim_inferior_data_cleanup): Rename from
3404 sim_inferior_data_cleanup. Simplify.
3405 (gdbsim_close_inferior, simulator_command)
3406 (sim_command_completer, _initialize_remote_sim): Update.
3407 (next_pid, INITIAL_PID): Move earlier.
3408
05b08ac1
TT
34092019-07-10 Tom Tromey <tromey@adacore.com>
3410
3411 * python/python-internal.h (create_thread_object): Return
3412 gdbpy_ref.
3413 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3414 * python/py-inferior.c (struct threadlist_entry): Add
3415 constructor.
3416 <thread_obj>: Now a gdbpy_ref.
3417 (thread_to_thread_object): Update.
3418 (add_thread_object): Use new.
3419 (delete_thread_object): Use delete.
3420 (infpy_threads): Update.
3421 (py_free_inferior): Update. Construct "inf_obj" after acquiring
3422 GIL.
3423
32372d80
TT
34242019-07-10 Tom Tromey <tromey@adacore.com>
3425
3426 * valops.c (value_cast): Specialize error message for Ada.
3427
5c458ae8
SM
34282019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3429
3430 * breakpoint.c (breakpoint_1): Update doc and parameter names.
3431
4c462cb0
SM
34322019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3433
3434 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3435 bpstat_should_step): Return bool, adjust comments.
3436 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3437 bpstat_should_step): Likewise.
3438
89abbcc2
AH
34392019-07-10 Alan Hayward <alan.hayward@arm.com>
3440
3441 * features/Makefile: Use feature target descriptions for Arm.
3442 * features/arm/arm-core.c: Generate new file.
3443 * features/arm/arm-fpa.c: Likewise.
3444 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3445 * features/arm/arm-m-profile.c: Likewise.
3446 * features/arm/arm-vfpv2.c: Likewise.
3447 * features/arm/arm-vfpv3.c: Likewise.
3448 * features/arm/xscale-iwmmxt.c: Likewise.
3449 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3450
166a82be
AH
34512019-07-10 Alan Hayward <alan.hayward@arm.com>
3452
3453 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3454 ptrace earlier.
3455
9fb4c7e9
AH
34562019-07-10 Alan Hayward <alan.hayward@arm.com>
3457
3458 * features/aarch64-pauth.c: Regenerate.
3459
e2d0f980
SM
34602019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
3461
3462 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3463 bool.
3464 (bpstat_what): Use false instead of 0.
3465
a38118e5
PA
34662019-07-09 Pedro Alves <palves@redhat.com>
3467
3468 * break-catch-throw.c (is_exception_catchpoint): New.
3469 * breakpoint.c (print_one_breakpoint_location): New parameter
3470 'raw_loc'. Handle it. Use
3471 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3472 looking at the breakpoint's type.
3473 (print_one_breakpoint): If handling "maint info breakpoints", also
3474 print locations of exception catchpoints.
3475 * breakpoint.h (is_exception_catchpoint): Declare.
3476
cb1e4e32
PA
34772019-07-09 Pedro Alves <palves@redhat.com>
3478
3479 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3480 "addr" field.
3481 (allocate_location_exception_catchpoint): New.
3482 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3483 (initialize_throw_catchpoint_ops): Install
3484 allocate_location_exception_catchpoint as allocate_location
3485 method.
3486 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3487 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3488 bp_loc_other.
3489 (breakpoint_address_is_meaningful): Delete.
3490 (bl_address_is_meaningful): New.
3491 (breakpoint_locations_match): Adjust comment.
3492 (bp_location_from_bp_type): New, factored out of...
3493 (bp_location::bp_location(breakpoint *)): ... this.
3494 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3495 factored out of...
3496 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
3497 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3498 breakpoint_address_is_meaningful.
3499 (bp_locations_compare): Adjust comment.
3500 (update_global_location_list): Use bl_address_is_meaningful
3501 instead of breakpoint_address_is_meaningful.
3502 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3503 explicit.
3504 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3505 * python/py-breakpoint.c (bppy_get_location): No longer check
3506 whether location is null.
3507
b58a68fe
PA
35082019-07-09 Pedro Alves <palves@redhat.com>
3509
3510 PR c++/15468
3511 * breakpoint.c (print_one_breakpoint_location): Remove
3512 single-location assert.
3513
268a13a5
TT
35142019-07-09 Tom Tromey <tom@tromey.com>
3515
3516 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3517 * configure: Rebuild.
3518 * configure.ac: Change common to gdbsupport.
3519 * gdbsupport: Rename from common.
3520 * acinclude.m4: Change common to gdbsupport.
3521 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3522 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3523 gdbsupport.
3524 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3525 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3526 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3527 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3528 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3529 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3530 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3531 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3532 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3533 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3534 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3535 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3536 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3537 coff-pe-read.c, command.h, compile/compile-c-support.c,
3538 compile/compile-c.h, compile/compile-cplus-symbols.c,
3539 compile/compile-cplus-types.c, compile/compile-cplus.h,
3540 compile/compile-loc2c.c, compile/compile.c, completer.c,
3541 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3542 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3543 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3544 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3545 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3546 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3547 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3548 features/aarch64-core.c, features/aarch64-fpu.c,
3549 features/aarch64-pauth.c, features/aarch64-sve.c,
3550 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3551 features/i386/32bit-core.c, features/i386/32bit-linux.c,
3552 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3553 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3554 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3555 features/i386/64bit-core.c, features/i386/64bit-linux.c,
3556 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3557 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3558 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3559 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3560 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3561 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3562 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3563 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3564 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3565 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3566 go32-nat.c, guile/guile.c, guile/scm-ports.c,
3567 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3568 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3569 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3570 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3571 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3572 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3573 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3574 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3575 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3576 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3577 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3578 minsyms.c, mips-linux-tdep.c, namespace.h,
3579 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3580 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3581 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3582 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3583 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3584 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3585 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3586 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3587 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3588 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3589 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3590 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3591 procfs.c, producer.c, progspace.h, psymtab.h,
3592 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3593 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3594 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3595 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3596 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3597 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3598 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3599 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3600 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3601 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3602 target-memory.c, target.c, target.h, target/waitstatus.c,
3603 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3604 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3605 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3606 unittests/array-view-selftests.c,
3607 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3608 unittests/common-utils-selftests.c,
3609 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3610 unittests/format_pieces-selftests.c,
3611 unittests/function-view-selftests.c,
3612 unittests/lookup_name_info-selftests.c,
3613 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3614 unittests/mkdir-recursive-selftests.c,
3615 unittests/observable-selftests.c,
3616 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3617 unittests/parse-connection-spec-selftests.c,
3618 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3619 unittests/scoped_fd-selftests.c,
3620 unittests/scoped_mmap-selftests.c,
3621 unittests/scoped_restore-selftests.c,
3622 unittests/string_view-selftests.c, unittests/style-selftests.c,
3623 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3624 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3625 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3626 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3627 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3628 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3629
5b0e2db4
AB
36302019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3631
3632 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3633 bool value.
3634 (decode_digits_ordinary): Set explicit_line field in sal.
3635 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3636 symtab_and_line that was set on an explicit line number in
3637 assembler code. Do always update the recorded symtab and line if
3638 we do skip the prologue.
3639
0ba852ab
AB
36402019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3641
3642 * breakpoint.c (set_breakpoint_location_function): Remove
3643 explicit_loc parameter.
3644 (momentary_breakpoint_from_master): Update call to
3645 set_breakpoint_location_function.
3646 (add_location_to_breakpoint): Likewise.
3647
b3a7d171
AB
36482019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3649
3650 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3651 required features based on default bfd type when no specific bfd
3652 is present.
3653
1f6f6e21
PW
36542019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3655
3656 * NEWS: Mention that GDB printf and eval commands can now print
3657 C-style and Ada-style convenience var strings without
3658 calling the inferior.
3659 * printcmd.c (printf_c_string): Locally print GDB internal var
3660 instead of transiting via the inferior.
3661 (printf_wide_c_string): Likewise.
3662
36632019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
3664
3665 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3666
0598af48
TT
36672019-07-04 Tom Tromey <tom@tromey.com>
3668
3669 PR tui/24724:
3670 * tui/tui-winsource.c (tui_clear_source_content): Update.
3671 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3672 (tui_update_breakpoint_info): Update.
3673 (tui_set_exec_info_content): Update.
3674 * tui/tui-source.c (tui_set_source_content_nil): Update.
3675 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3676 has_break.
3677 * tui/tui-data.h (enum tui_bp_flag): New.
3678 (tui_bp_flags): New enum flags type.
3679 (struct tui_source_element) <break_mode>: Change type. Rename
3680 from has_break.
3681 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3682 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3683 constants.
3684 * tui/tui-winsource.h: Fix comment.
3685
350fab54
AH
36862019-07-04 Alan Hayward <alan.hayward@arm.com>
3687
3688 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3689 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3690 (store_fpregs_to_thread)
3691 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3692 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3693 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3694 (IWMMXT_REGS_SIZE): Add define.
3695 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3696 (fetch_vfp_regs, store_vfp_regs)
3697 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3698 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3699
f0452268
AH
37002019-07-04 Alan Hayward <alan.hayward@arm.com>
3701
3702 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3703 defines.
3704 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3705 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3706 (ARM_INT_REGISTER_SIZE): ...to this.
3707 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3708 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3709 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3710 (arm_linux_collect_gregset, supply_nwfpe_register)
3711 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3712 defines.
3713 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3714 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3715 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3716 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3717 (arm_return_in_memory, arm_store_return_value)
3718 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3719 (arm_record_ld_st_multiple): Likewise.
3720 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3721 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3722
e935475c
AH
37232019-07-04 Alan Hayward <alan.hayward@arm.com>
3724
3725 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3726 AARCH64_DISPLACED_MODIFIED_INSNS.
3727 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3728 (aarch64_displaced_step_copy_insn): Likewise.
3729 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3730 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3731 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3732 ARM_DISPLACED_MODIFIED_INSNS.
3733 * arm-tdep.c (arm_gdbarch_init): Likewise.
3734 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3735 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3736 (struct arm_displaced_step_closure): Use
3737 ARM_DISPLACED_MODIFIED_INSNS.
3738
df0bb381
AH
37392019-07-04 Alan Hayward <alan.hayward@arm.com>
3740
3741 * features/Makefile: Remove unused xml files.
3742 * features/aarch64.xml: Remove.
3743 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3744 * features/i386/amd64-avx-avx512.xml: Remove.
3745 * features/i386/amd64-avx-linux.xml: Remove.
3746 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3747 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3748 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3749 * features/i386/amd64-avx-mpx.xml: Remove.
3750 * features/i386/amd64-avx.xml: Remove.
3751 * features/i386/amd64-linux.xml: Remove.
3752 * features/i386/amd64-mpx-linux.xml: Remove.
3753 * features/i386/amd64-mpx.xml: Remove.
3754 * features/i386/amd64.xml: Remove.
3755 * features/i386/i386-avx-avx512-linux.xml: Remove.
3756 * features/i386/i386-avx-avx512.xml: Remove.
3757 * features/i386/i386-avx-linux.xml: Remove.
3758 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3759 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3760 * features/i386/i386-avx-mpx-linux.xml: Remove.
3761 * features/i386/i386-avx-mpx.xml: Remove.
3762 * features/i386/i386-avx.xml: Remove.
3763 * features/i386/i386-linux.xml: Remove.
3764 * features/i386/i386-mmx-linux.xml: Remove.
3765 * features/i386/i386-mmx.xml: Remove.
3766 * features/i386/i386-mpx-linux.xml: Remove.
3767 * features/i386/i386-mpx.xml: Remove.
3768 * features/i386/i386.xml: Remove.
3769 * features/i386/x32-avx-avx512-linux.xml: Remove.
3770 * features/i386/x32-avx-linux.xml: Remove.
3771 * features/i386/x32-linux.xml: Remove.
3772
edd6266a
AH
37732019-07-04 Alan Hayward <alan.hayward@arm.com>
3774
3775 * regformats/aarch64.dat: Remove.
3776 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3777 * regformats/i386/amd64-avx-linux.dat: Remove.
3778 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3779 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3780 * regformats/i386/amd64-linux.dat: Remove.
3781 * regformats/i386/amd64-mpx-linux.dat: Remove.
3782 * regformats/i386/amd64.dat: Remove.
3783 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3784 * regformats/i386/i386-avx-linux.dat: Remove.
3785 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3786 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3787 * regformats/i386/i386-linux.dat: Remove.
3788 * regformats/i386/i386-mmx-linux.dat: Remove.
3789 * regformats/i386/i386-mpx-linux.dat: Remove.
3790 * regformats/i386/i386.dat: Remove.
3791 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3792 * regformats/i386/x32-avx-linux.dat: Remove.
3793 * regformats/i386/x32-linux.dat: Remove.
3794
2b40fda7
AH
37952019-07-04 Alan Hayward <alan.hayward@arm.com>
3796
3797 * aarch64-tdep.c: Remove xml self tests.
3798 * amd64-linux-tdep.c: Likewise.
3799 * amd64-tdep.c: Likewise.
3800 * i386-linux-tdep.c: Likewise.
3801 * i386-tdep.c: Likewise.
3802
5f4ba3e7
PA
38032019-07-03 Pedro Alves <palves@redhat.com>
3804
3805 PR cli/24732
3806 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3807 (pipe_cmd_option_defs): New.
3808 (make_pipe_cmd_options_def_group): New.
3809 (pipe_command): Use gdb::option::process_options.
3810 (pipe_command_completer): New function.
3811 (_initialize_cli_cmds): Install completer for "pipe" command.
3812
3d9be6f5
PA
38132019-07-03 Pedro Alves <palves@redhat.com>
3814
3815 * cli/cli-option.c (union option_value) <string>: New field.
3816 (struct option_def_and_value): Add ctor, move ctor, dtor and
3817 use DISABLE_COPY_AND_ASSIGN.
3818 (option_def_and_value::clear_value): New.
3819 (parse_option, save_option_value_in_ctx, get_val_type_str)
3820 (add_setshow_cmds_for_options): Handle var_string.
3821 * cli-option.h (union option_def::var_address) <string>: New
3822 field.
3823 (struct string_option_def): New.
3824 * maint-test-options.c (struct test_options_opts): Add default
3825 ctor and use DISABLE_COPY_AND_ASSIGN.
3826 <string_opt>: New field.
3827 (test_options_opts::~test_options_opts): New.
3828 (test_options_opts::dump): Also dump "-string".
3829 (test_options_option_defs): Install "string.
3830
41fc454c
PA
38312019-07-03 Pedro Alves <palves@redhat.com>
3832
3833 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3834 option_value with a null enumeration.
3835 (complete_options): Save the option values in the context.
3836 (save_option_value_in_ctx): New, factored out from ...
3837 (process_options): ... here.
3838 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3839 of the function.
3840 * maint-test-options.c (test_options_opts::dump): New, factored
3841 out from ...
3842 (maintenance_test_options_command_mode): ... here.
3843 (maintenance_test_options_command_completion_result): Delete.
3844 (maintenance_test_options_command_completion_text): Update
3845 comment.
3846 (maintenance_show_test_options_completion_result): Change
3847 prototype. Just print
3848 maintenance_test_options_command_completion_text.
3849 (save_completion_result): New.
3850 (maintenance_test_options_completer_mode): Pass options context to
3851 complete_options, and then save a dump.
3852 (_initialize_maint_test_options): Use add_cmd to install "maint
3853 show test-options-completion-result".
3854
fdbc9870
PA
38552019-07-03 Pedro Alves <palves@redhat.com>
3856
3857 * NEWS (New commands): Mention "with" and "maint with".
3858 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3859 (with_command, with_command_completer): New.
3860 (pipe_command): Adjust to new repeat_previous
3861 interface.
3862 (_initialize_cli_cmds): Install the "with" command and its "w"
3863 alias.
3864 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3865 declarations.
3866 * cli/cli-setshow.c (parse_cli_var_uinteger)
3867 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3868 argument strings for all var_types.
3869 (get_setshow_command_value_string): New, factored out from ...
3870 (do_show_command): ... this.
3871 * cli/cli-setshow.h: Include <string>.
3872 (get_setshow_command_value_string): Declare.
3873 * command.h (repeat_previous): Now returns const char *. Adjust
3874 comment.
3875 * maint.c: Include "cli/cli-cmds.h".
3876 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3877 (_initialize_maint_cmds): Register the "maintenance with" command.
3878 * top.c (repeat_previous): Move bits from pipe_command here:
3879 Return the saved command line, if any; error out if there's no
3880 command to relaunch.
3881
c6ac8931
PA
38822019-07-03 Pedro Alves <palves@redhat.com>
3883
3884 * NEWS (New commands): Mention "maint set/show test-settings"
3885 instead of "maint test-settings".
3886 * maint-test-settings.c (maintenance_test_settings_list): Delete.
3887 (maintenance_test_settings_set_list): Rename to ...
3888 (maintenance_set_test_settings_list): ... this.
3889 (maintenance_test_settings_show_list): Rename to ...
3890 (maintenance_show_test_settings_list): ... this.
3891 (maintenance_test_settings_cmd): Delete.
3892 (maintenance_test_settings_set_cmd): ...
3893 (maintenance_set_test_settings_cmd): ... this.
3894 (maintenance_test_settings_show_cmd): ...
3895 (maintenance_show_test_settings_cmd): ... this.
3896 (maintenance_test_settings_show_value_cmd):
3897 (maintenance_show_test_settings_value_cmd): ... this.
3898 (_initialize_maint_test_settings): No longer install the "maint
3899 test-settings" prefix command. Rename "maint test-settings set"
3900 to "maint set test-settings", and "maint test-settings show" to
3901 "maint show test-settings". Adjust all subcommands.
3902
d1fcf2fd
PA
39032019-07-03 Pedro Alves <palves@redhat.com>
3904
3905 * maint-test-settings.c: Fix file's intro comment. Replace all
3906 references to "test-options" with references to "test-settings",
3907 in comments.
3908
970f9d09
PA
39092019-07-03 Pedro Alves <palves@redhat.com>
3910
3911 * maint-test-settings.c (maintenance_test_settings_xxx)
3912 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3913 New.
3914 (maintenance_test_settings_enums): Use them.
3915 (maintenance_test_settings_enum): Default to
3916 maintenance_test_settings_xxx.
3917 (_initialize_maint_test_settings): Initialize
3918 MAINTENANCE_TEST_SETTINGS_FILENAME.
3919
f3869b1a
SM
39202019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3921
3922 * breakpoint.h (remove_breakpoints_inf): Change return type to
3923 void, move function documentation here.
3924 * breakpoint.c (remove_breakpoints_inf): Change return type to
3925 void, move function documentation to header.
3926
54d66006
PA
39272019-07-02 Pedro Alves <palves@redhat.com>
3928
3929 * NEWS (Completion improvements): Mention "info threads".
3930 * thread.c (struct info_threads_opts, info_threads_option_defs)
3931 (make_info_threads_options_def_group): New.
3932 (info_threads_command): Use gdb::option::process_options.
3933 (info_threads_command_completer): New.
3934 (_initialize_thread): Use gdb::option::build_help to build the
3935 help text for "info threads".
3936
854f6088
SM
39372019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3938
3939 * defs.h (generic_load): Move from here...
3940 * symfile.h (generic_load): ... to here. Rename name parameter
3941 to args.
3942 * symfile.c (generic_load): Add comment.
3943
54ee4252
TT
39442019-07-01 Tom Tromey <tromey@adacore.com>
3945
3946 * dwarf2read.c
3947 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3948 declaration of without_params. Fix formatting.
3949
65392b3e
TT
39502019-07-01 Tom Tromey <tromey@adacore.com>
3951
3952 * ada-exp.y (find_primitive_type): Update.
3953 * ada-lang.h (ada_lookup_symbol): Update.
3954 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3955 parameter.
3956 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3957
7d7571f0
SDJ
39582019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3959
3960 PR breakpoints/24541
3961 * gdbarch.c: Regenerate.
3962 * gdbarch.h: Regenerate.
3963 * gdbarch.sh: Add 'stap_adjust_register'.
3964 * i386-tdep.c: Include '<unordered_set>'.
3965 (i386_stap_adjust_register): New function.
3966 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3967 * stap-probe.c (stap_parse_register_operand): Call
3968 'gdbarch_stap_adjust_register'.
3969
5af5392a
SDJ
39702019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3971
3972 PR python/24742
3973 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3974 * python/python.c (do_start_initialization): Use 'xmalloc'
3975 instead of 'PyMem_Malloc'.
3976
10d06d82
TT
39772019-06-28 Tom Tromey <tromey@adacore.com>
3978
3979 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3980 for Ada.
3981
1b7f24cd
TT
39822019-06-27 Tom Tromey <tromey@adacore.com>
3983
3984 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3985 objfile_key.
3986 (arm_find_mapping_symbol, arm_record_special_symbol)
3987 (_initialize_arm_tdep): Update.
3988 (arm_objfile_data_free): Remove.
3989
3d507ff2
TT
39902019-06-27 Tom Tromey <tromey@adacore.com>
3991
3992 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3993 to cp_print_static_field.
3994
762c164d
TT
39952019-06-26 Tom Tromey <tromey@adacore.com>
3996
3997 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3998 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3999 declare.
4000
aa2f9bcf
AH
40012019-06-26 Alan Hayward <alan.hayward@arm.com>
4002
4003 * features/aarch64-core.c (create_feature_aarch64_core):
4004 Regenerate.
4005 * features/aarch64-core.xml: Add cpsr flags.
4006
3426ae57
AH
40072019-06-26 Alan Hayward <alan.hayward@arm.com>
4008
4009 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4010 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4011
4838e44c
SM
40122019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4013
4014 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4015 field.
4016 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4017 use.
4018 (arm_record_special_symbol): Don't insert new symbol in sorted
4019 position, push it at the end.
4020
54cc7474
SM
40212019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4022
4023 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4024 (arm_mapping_symbol_s): Remove.
4025 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4026 (arm_mapping_symbol_vec): New typedef.
4027 (struct arm_per_objfile): Add constructor.
4028 <section_maps>: Change type to
4029 std::unique_ptr<arm_mapping_symbol_vec[]>.
4030 (arm_compare_mapping_symbols): Remove.
4031 (arm_find_mapping_symbol): Adjust to section_maps type change.
4032 (arm_objfile_data_free): Call delete on arm_per_objfile.
4033 (arm_record_special_symbol): Adjust to section_maps type change.
4034 Allocate arm_per_objfile with new.
4035
b65b566c
PW
40362019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4037
4038 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4039 with the command prefix.
4040
c2fc64f5
TT
40412019-06-25 Tom Tromey <tom@tromey.com>
4042
4043 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4044 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4045
fb54fa76
TT
40462019-06-25 Tom Tromey <tom@tromey.com>
4047
4048 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4049 type.
4050 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4051 protected.
4052
f7952c57
TT
40532019-06-25 Tom Tromey <tom@tromey.com>
4054
4055 * tui/tui-winsource.c
4056 (tui_source_window_base::set_is_exec_point_at): Add check against
4057 LOA_ADDRESS.
4058
17568d78
TT
40592019-06-25 Tom Tromey <tom@tromey.com>
4060
4061 * tui/tui-source.c (tui_set_source_content): Don't check before
4062 xfree.
4063 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4064
53e7cdba
TT
40652019-06-25 Tom Tromey <tom@tromey.com>
4066
4067 * tui/tui-winsource.h (tui_update_source_window_as_is)
4068 (tui_alloc_source_buffer, tui_line_is_displayed)
4069 (tui_addr_is_displayed): Change type of win_info.
4070 * tui/tui-winsource.c (tui_update_source_window_as_is)
4071 (tui_clear_source_content, tui_show_source_line)
4072 (tui_show_source_content, tui_source_window_base::refill)
4073 (tui_source_window_base::set_is_exec_point_at)
4074 (tui_source_window_base::set_is_exec_point_at)
4075 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4076 (tui_alloc_source_buffer, tui_line_is_displayed)
4077 (tui_addr_is_displayed): Change type of win_info. Update.
4078 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4079 (tui_source_window_base::do_make_visible_with_new_height):
4080 Update.
4081 * tui/tui-source.c (tui_set_source_content)
4082 (tui_set_source_content_nil)
4083 (tui_source_window::do_scroll_vertical): Update.
4084 * tui/tui-layout.c (show_layout): Update.
4085 * tui/tui-disasm.c (tui_set_disassem_content)
4086 (tui_disasm_window::do_scroll_vertical): Update.
4087 * tui/tui-data.h (tui_win_content): Remove.
4088 (struct tui_gen_win_info) <content, content_size>: Remove.
4089 (struct tui_source_element): Add initializers and destructor.
4090 (union tui_which_element, struct tui_win_element): Remove.
4091 (struct tui_source_window_base) <content>: New field.
4092 (struct tui_data_window): Remove destructor.
4093 (tui_alloc_content, tui_free_win_content)
4094 (tui_free_all_source_wins_content): Don't declare.
4095 * tui/tui-data.c (tui_initialize_static_data): Update.
4096 (init_content_element, tui_alloc_content): Remove.
4097 (~tui_gen_win_info): Update.
4098 (~tui_data_window, tui_free_all_source_wins_content)
4099 (tui_free_win_content, free_content, free_content_elements):
4100 Remove.
4101
7908abbf
TT
41022019-06-25 Tom Tromey <tom@tromey.com>
4103
4104 * tui/tui-winsource.h (tui_clear_source_content)
4105 (tui_erase_source_content, tui_show_source_content): Change type
4106 of win_info.
4107 * tui/tui-winsource.c (tui_clear_source_content)
4108 (tui_erase_source_content, tui_show_source_content): Change type
4109 of win_info.
4110 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4111 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4112 win_info.
4113 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4114 win_info.
4115 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4116
02c28df0
TT
41172019-06-25 Tom Tromey <tom@tromey.com>
4118
4119 * tui/tui-winsource.c (tui_clear_source_content)
4120 (tui_source_window_base::set_is_exec_point_at): Update.
4121 * tui/tui-source.c (tui_set_source_content_nil): Update.
4122 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4123 a bool.
4124 * tui/tui-data.c (init_content_element): Update.
4125
6658b1bf
TT
41262019-06-25 Tom Tromey <tom@tromey.com>
4127
4128 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4129 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4130 * tui/tui-layout.c (init_and_make_win): Update.
4131 * tui/tui.h (enum tui_win_type): Update.
4132 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4133 tui_win_is_auxillary.
4134 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4135 tui_win_is_auxillary.
4136
21e1c91e
TT
41372019-06-25 Tom Tromey <tom@tromey.com>
4138
4139 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4140 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4141 (tui_delete_data_content_windows, tui_display_all_data)
4142 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4143 Update.
4144 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4145 * tui/tui-regs.c (tui_last_regs_line_no)
4146 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4147 (tui_show_registers): Update.
4148 (tui_show_register_group): Return void. Update.
4149 (tui_display_registers_from, tui_display_reg_element_at_line)
4150 (tui_display_registers_from_line, tui_check_register_values):
4151 Update.
4152 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4153 member.
4154 (struct tui_data_window) <regs_content>: Now a std::vector.
4155 <regs_content_count>: Remove.
4156 (tui_add_content_elements, tui_free_data_content): Don't declare.
4157 * tui/tui-data.c (tui_data_window::clear_detail): Update.
4158 (init_content_element): Remove DATA_WIN case. Add assert.
4159 (tui_add_content_elements): Remove.
4160 (tui_data_window): Update.
4161 (tui_free_data_content): Remove.
4162 (free_content_elements): Remove DATA_WIN case.
4163
115ac53b
TT
41642019-06-25 Tom Tromey <tom@tromey.com>
4165
4166 * tui/tui-data.c (tui_data_item_window): Update.
4167 * tui/tui-windata.h (tui_check_data_values): Don't declare.
4168 * tui/tui-windata.c (tui_display_all_data)
4169 (tui_display_data_from_line): Update.
4170 (tui_check_data_values): Remove.
4171 * tui/tui-regs.c (tui_show_register_group)
4172 (tui_display_reg_element_at_line): Update.
4173 * tui/tui-hooks.c (tui_register_changed)
4174 (tui_refresh_frame_and_register_information): Call
4175 tui_check_register_values.
4176 * tui/tui-data.h (struct tui_data_window) <data_content,
4177 data_content_count, data_type>: Remove.
4178 (enum tui_data_type): Remove.
4179
4180 * tui/tui-data.c (tui_data_window::clear_detail)
4181 (~tui_data_window): Update.
4182
eaf9738b
TT
41832019-06-25 Tom Tromey <tom@tromey.com>
4184
4185 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4186 declare.
4187 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4188 Rename from tui_first_data_item_displayed. Update.
4189 (tui_data_window::refresh_all)
4190 (tui_data_window::do_scroll_vertical): Update.
4191 * tui/tui-data.h (struct tui_data_window)
4192 <first_data_item_displayed>: Declare new method.
4193
31ca4723
TT
41942019-06-25 Tom Tromey <tom@tromey.com>
4195
4196 * tui/tui-data.h (tui_init_generic_part): Don't declare.
4197 * tui/tui-data.c (tui_init_generic_part): Remove, moving
4198 contents...
4199 (tui_initialize_static_data): ...here.
4200
41bcff7f
TT
42012019-06-25 Tom Tromey <tom@tromey.com>
4202
4203 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4204 (tui_display_registers_from, tui_check_register_values): Update.
4205 (tui_display_register): Remove win_info parameter; update.
4206 (tui_get_register): Change type of parameters.
4207 * tui/tui-data.h (struct tui_data_element): Remove.
4208 (union tui_which_element) <data>: Remove.
4209 <data_window>: Change type.
4210 (struct tui_data_item_window): New.
4211 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4212 case. Add assert.
4213 (~tui_data_item_window): New destructor.
4214 (free_content_elements): Remove DATA_ITEM_WIN case.
4215
d2802c33
TT
42162019-06-25 Tom Tromey <tom@tromey.com>
4217
4218 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4219 Remove.
4220
dd835f8b
TT
42212019-06-25 Tom Tromey <tom@tromey.com>
4222
4223 * tui/tui-data.h (struct tui_command_element): Remove.
4224 (union tui_which_element) <command>: Remove.
4225 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
4226 assert.
4227 (free_content_elements): Remove CMD_WIN case.
4228
bd7db367
TT
42292019-06-25 Tom Tromey <tom@tromey.com>
4230
4231 * tui/tui-layout.c (tui_set_layout): Update.
4232 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4233 * tui/tui-data.c (layout_def): Update.
4234
3add462f
TT
42352019-06-25 Tom Tromey <tom@tromey.com>
4236
4237 * tui/tui-wingeneral.c (tui_refresh_all): Update.
4238 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4239 (tui_source_window_base::set_new_height): Update.
4240 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4241 Update.
4242 (tui_set_locator_fullname, tui_set_locator_info)
4243 (tui_show_frame_info): Update.
4244 * tui/tui-source.c (tui_set_source_content)
4245 (tui_source_is_displayed): Update.
4246 * tui/tui-layout.c (show_source_disasm_command, show_data)
4247 (show_source_or_disasm_and_command): Update.
4248 * tui/tui-disasm.c (tui_set_disassem_content)
4249 (tui_get_begin_asm_address): Update.
4250 * tui/tui-data.h (struct tui_locator_element): Remove.
4251 (union tui_which_element) <locator>: Remove.
4252 (struct tui_locator_window): New.
4253 (tui_locator_win_info_ptr): Change return type.
4254 * tui/tui-data.c (_locator): Change type.
4255 (tui_locator_win_info_ptr): Change return type.
4256 (init_content_element): Remove LOCATOR_WIN case. Add assert.
4257 (tui_alloc_content): Add assert.
4258
489e9d8b
TT
42592019-06-25 Tom Tromey <tom@tromey.com>
4260
4261 * tui/tui-winsource.c
4262 (tui_exec_info_window::maybe_allocate_content): New method.
4263 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4264 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4265 (make_source_or_disasm_window): Add cast.
4266 * tui/tui-data.h (union tui_which_element) <simple_string>:
4267 Remove.
4268 (struct tui_source_info): New.
4269 (struct tui_source_window_base) <execution_info>: Change type.
4270 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4271 case, and add assert.
4272 (tui_alloc_content): Add assert.
4273
c3fabb7d
TT
42742019-06-25 Tom Tromey <tom@tromey.com>
4275
4276 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4277 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4278 * tui/tui-data.c (tui_alloc_win_info): Remove.
4279
bbc228ee
TT
42802019-06-25 Tom Tromey <tom@tromey.com>
4281
4282 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4283 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4284 can_highlight.
4285
5fcee43a
TT
42862019-06-25 Tom Tromey <tom@tromey.com>
4287
4288 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4289 make_visible_with_new_height method.
4290 (tui_win_info::make_visible_with_new_height): New method.
4291 (tui_source_window_base::do_make_visible_with_new_height)
4292 (tui_data_window::do_make_visible_with_new_height)
4293 (tui_cmd_window::do_make_visible_with_new_height): New methods.
4294 (make_visible_with_new_height): Remove.
4295 (tui_resize_all, tui_adjust_win_heights): Use
4296 make_visible_with_new_height method.
4297 * tui/tui-data.h (struct tui_win_info)
4298 <do_make_visible_with_new_height, make_visible_with_new_height>:
4299 New methods.
4300 (struct tui_source_window_base, struct tui_data_window)
4301 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4302 methods.
4303
d83f1fe6
TT
43042019-06-25 Tom Tromey <tom@tromey.com>
4305
4306 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4307 method.
4308 (update_tab_width): Call update_tab_width method.
4309 * tui/tui-data.h (struct tui_win_info)
4310 (struct tui_source_window_base) <update_tab_width>: New methods.
4311
17374de4
TT
43122019-06-25 Tom Tromey <tom@tromey.com>
4313
4314 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4315 parameter.
4316 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4317 parameter.
4318 (tui_gen_win_info::make_visible): Update.
4319 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4320 parameter.
4321 * tui/tui-data.h (enum tui_box): New enum.
4322 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4323
f936bca2
TT
43242019-06-25 Tom Tromey <tom@tromey.com>
4325
4326 * tui/tui-layout.c (make_source_or_disasm_window): Always use
4327 init_and_make_win for EXEC_INFO_WIN.
4328 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4329 longer inline.
4330 (struct tui_win_info) <~tui_win_info>: Inline.
4331 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4332 Don't declare.
4333 * tui/tui-data.c (source_win, disasm_win): Remove globals.
4334 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4335 Remove.
4336 (tui_initialize_static_data): Update.
4337 (~tui_gen_win_info): Handle more cleanup here.
4338 (~tui_source_window_base): Delete "execution_info".
4339 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4340
d6ba6a11
TT
43412019-06-25 Tom Tromey <tom@tromey.com>
4342
4343 * tui/tui-layout.c (make_command_window): Don't set
4344 can_highlight.
4345 (show_source_disasm_command): Call the reset method.
4346 (show_data): Don't set can_highlight. Call the reset method.
4347 (tui_gen_win_info::reset): Rename from init_gen_win_info
4348 (init_and_make_win): Simplify. Return tui_gen_win_info.
4349 (show_source_or_disasm_and_command): Call the reset method.
4350 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4351 (struct tui_cmd_window): Set can_highlight.
4352
48a3bd16
TT
43532019-06-25 Tom Tromey <tom@tromey.com>
4354
4355 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4356 from make_visible.
4357 (tui_make_visible, tui_make_invisible): Rewrite.
4358 (tui_win_info::make_visible): Remove.
4359 (tui_source_window_base::make_visible): Update.
4360 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4361 method. Moved from...
4362 (struct tui_win_info) <make_visible>: ...here.
4363
c3bd716f
TT
43642019-06-25 Tom Tromey <tom@tromey.com>
4365
4366 * tui/tui-winsource.c
4367 (tui_source_window_base::do_scroll_horizontal): Remove direction
4368 parameter.
4369 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4370 direction parameter.
4371 * tui/tui-win.c (tui_win_info::forward_scroll)
4372 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4373 (tui_win_info::right_scroll): Update.
4374 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4375 direction parameter.
4376 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4377 direction parameter.
4378 * tui/tui-data.h (enum tui_scroll_direction): Remove.
4379 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4380 Remove direction parameter.
4381 (struct tui_source_window_base, struct tui_source_window)
4382 (struct tui_disasm_window, struct tui_data_window)
4383 (struct tui_cmd_window): Update.
4384
21c32dca
TT
43852019-06-25 Tom Tromey <tom@tromey.com>
4386
4387 * tui/tui-winsource.h (tui_set_exec_info_content)
4388 (tui_show_exec_info_content, tui_erase_exec_info_content)
4389 (tui_clear_exec_info_content, tui_update_exec_info): Change
4390 argument to tui_source_window_base.
4391 * tui/tui-winsource.c (tui_set_exec_info_content)
4392 (tui_show_exec_info_content, tui_erase_exec_info_content)
4393 (tui_clear_exec_info_content, tui_update_exec_info): Change
4394 argument to tui_source_window_base.
4395
73fbdc65
TT
43962019-06-25 Tom Tromey <tom@tromey.com>
4397
4398 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4399 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4400
33325343
TT
44012019-06-25 Tom Tromey <tom@tromey.com>
4402
4403 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4404 check.
4405
29d2c474
TT
44062019-06-25 Tom Tromey <tom@tromey.com>
4407
4408 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4409 type to void.
4410 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4411 type to void.
4412 * tui/tui-source.c (tui_set_source_content): Update.
4413 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4414
152f3f4b
TT
44152019-06-25 Tom Tromey <tom@tromey.com>
4416
4417 * tui/tui-win.c (window_name_completer, tui_set_focus)
4418 (tui_all_windows_info): Use name method.
4419 * tui/tui-data.h (struct tui_gen_win_info)
4420 (struct tui_source_window, struct tui_disasm_window)
4421 (struct tui_data_window, struct tui_cmd_window) <name>: New
4422 method.
4423 (tui_win_name): Don't declare.
4424 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4425 (tui_win_name): Remove.
4426
be4da588
TT
44272019-06-25 Tom Tromey <tom@tromey.com>
4428
4429 * tui/tui-winsource.h (tui_update_source_window)
4430 (tui_update_source_window_as_is): Change parameter type.
4431 * tui/tui-winsource.c (tui_update_source_window): Change win_info
4432 to be a tui_source_window_base.
4433 (tui_update_source_window_as_is): Likewise.
4434 * tui/tui-win.c (make_visible_with_new_height): Update.
4435
5b81daba
TT
44362019-06-25 Tom Tromey <tom@tromey.com>
4437
4438 * tui/tui-winsource.c (tui_erase_source_content)
4439 (tui_show_source_content, tui_show_exec_info_content)
4440 (tui_erase_exec_info_content): Use refresh_window method.
4441 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4442 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4443 from tui_refresh_win.
4444 (tui_data_window::refresh_window): New method.
4445 (tui_win_info::refresh, tui_source_window_base::refresh)
4446 (tui_refresh_all): Use refresh_window method.
4447 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4448 method.
4449 * tui/tui-regs.c (tui_display_register): Call refresh_window
4450 method.
4451 * tui/tui-layout.c (show_source_disasm_command)
4452 (show_source_or_disasm_and_command): Call refresh_window method.
4453 * tui/tui-data.h (struct tui_gen_win_info)
4454 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4455 New method.
4456
cb2ce893
TT
44572019-06-25 Tom Tromey <tom@tromey.com>
4458
4459 * tui/tui.c (tui_rl_other_window, tui_enable)
4460 (tui_is_window_visible, tui_get_command_dimension): Update.
4461 * tui/tui-winsource.c (tui_update_source_window_as_is)
4462 (tui_clear_source_content, tui_erase_source_content)
4463 (tui_show_source_line, tui_source_window_base::refill)
4464 (tui_source_window_base::do_scroll_horizontal)
4465 (tui_source_window_base::set_is_exec_point_at)
4466 (tui_update_breakpoint_info, tui_set_exec_info_content)
4467 (tui_alloc_source_buffer, tui_line_is_displayed)
4468 (tui_addr_is_displayed): Update.
4469 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4470 (tui_check_and_display_highlight_if_needed)
4471 (tui_win_info::make_visible, tui_win_info::refresh)
4472 (tui_refresh_all): Update.
4473 * tui/tui-windata.c (tui_first_data_item_displayed)
4474 (tui_delete_data_content_windows, tui_erase_data_content)
4475 (tui_display_all_data, tui_data_window::refresh_all)
4476 (tui_check_data_values): Update.
4477 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4478 (tui_set_win_focus_to, tui_win_info::forward_scroll)
4479 (tui_win_info::backward_scroll, tui_refresh_all_win)
4480 (tui_resize_all, tui_set_focus, tui_all_windows_info)
4481 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4482 (tui_source_window_base::set_new_height)
4483 (tui_data_window::set_new_height)
4484 (make_invisible_and_set_new_height)
4485 (make_visible_with_new_height, new_height_ok)
4486 (parse_scrolling_args): Update.
4487 * tui/tui-stack.c (tui_show_frame_info): Update.
4488 * tui/tui-source.c (tui_set_source_content)
4489 (tui_set_source_content_nil, tui_source_is_displayed)
4490 (tui_source_window::do_scroll_vertical): Update.
4491 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4492 (tui_display_registers_from, tui_display_reg_element_at_line)
4493 (tui_check_register_values, tui_reg_command): Update.
4494 * tui/tui-layout.c (tui_default_win_height)
4495 (show_source_disasm_command, show_data, init_and_make_win)
4496 (show_source_or_disasm_and_command): Update.
4497 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4498 (tui_redisplay_readline, tui_mld_flush)
4499 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4500 (tui_getc): Update.
4501 * tui/tui-disasm.c (tui_set_disassem_content)
4502 (tui_disasm_window::do_scroll_vertical): Update.
4503 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4504 Now virtual.
4505 (struct tui_win_info): Derive from tui_gen_win_info.
4506 <~tui_win_info>: Mark as override.
4507 <generic>: Remove member.
4508 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4509 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4510 (~tui_data_window, ~tui_win_info)
4511 (tui_free_all_source_wins_content): Update.
4512 * tui/tui-command.c (tui_refresh_cmd_win): Update.
4513
ab313b35
TT
45142019-06-25 Tom Tromey <tom@tromey.com>
4515
4516 * tui/tui-layout.c (init_and_make_win): Use new.
4517 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4518 destructor, initializers.
4519 (tui_alloc_generic_win_info): Don't declare.
4520 * tui/tui-data.c (_locator): Add argument to constructor.
4521 (source_win, disasm_win): New globals.
4522 (exec_info): Remove.
4523 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4524 Update.
4525 (tui_alloc_generic_win_info): Remove.
4526 (init_content_element): Use new.
4527 (tui_win_info::tui_win_info): Update.
4528 (free_content_elements) <case DATA_WIN>: Use delete.
4529
dc2c33e4
TT
45302019-06-25 Tom Tromey <tom@tromey.com>
4531
4532 * tui/tui-wingeneral.c (tui_refresh_win): Update.
4533 * tui/tui-windata.c (tui_first_data_item_displayed)
4534 (tui_delete_data_content_windows): Update.
4535 * tui/tui-win.c (tui_data_window::set_new_height): Update.
4536 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4537 (tui_display_registers_from, tui_check_register_values): Update.
4538 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4539 pointer.
4540 * tui/tui-data.c (init_content_element): Update. Allocate the new
4541 window.
4542 (tui_free_data_content): Update.
4543 (free_content_elements) <case DATA_WIN>: Free the window.
4544
214a5cbe
TT
45452019-06-25 Tom Tromey <tom@tromey.com>
4546
4547 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4548 Update.
4549 * tui/tui-layout.c (make_command_window)
4550 (show_source_disasm_command, show_data, init_and_make_win)
4551 (show_source_or_disasm_and_command): Update.
4552 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4553 method.
4554 <can_highight, is_highlighted>: Now bool.
4555 (tui_set_win_highlight): Don't declare.
4556 * tui/tui-data.c (tui_set_win_highlight): Remove.
4557
8e2daf15
TT
45582019-06-25 Tom Tromey <tom@tromey.com>
4559
4560 * tui/tui-wingeneral.c (make_visible): Remove check of window
4561 type.
4562
8903bd8a
TT
45632019-06-25 Tom Tromey <tom@tromey.com>
4564
4565 * tui/tui-win.c (tui_win_info::max_height)
4566 (tui_cmd_window::max_height): New methods.
4567 (new_height_ok): Call max_height.
4568 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4569 <max_height>: New method.
4570
3f02ce1e
TT
45712019-06-25 Tom Tromey <tom@tromey.com>
4572
4573 * tui/tui-win.c (tui_source_window_base::set_new_height)
4574 (tui_data_window::set_new_height): New methods.
4575 (make_invisible_and_set_new_height): Call set_new_height method.
4576 * tui/tui-data.h (struct tui_win_info)
4577 (struct tui_source_window_base, struct tui_data_window)
4578 <set_new_height>: New method.
4579
1825f487
TT
45802019-06-25 Tom Tromey <tom@tromey.com>
4581
4582 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4583 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4584 tui_refresh_data_win.
4585 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4586 method.
4587 (tui_refresh_all_win): Call the refresh_all method.
4588 (tui_set_focus): Likewise.
4589 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4590 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4591 Likewise.
4592
ad54d15b
TT
45932019-06-25 Tom Tromey <tom@tromey.com>
4594
4595 * tui/tui-winsource.h (tui_refill_source_window)
4596 (tui_set_is_exec_point_at): Don't declare.
4597 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4598 (tui_source_window_base::refill): Rename from
4599 tui_refill_source_window.
4600 (tui_source_window_base::do_scroll_horizontal): Update.
4601 (tui_source_window_base::set_is_exec_point_at): Rename from
4602 tui_set_is_exec_point_at.
4603 (tui_update_all_breakpoint_info): Update.
4604 * tui/tui-stack.c (tui_show_frame_info): Update.
4605 * tui/tui-layout.c (show_data): Add cast.
4606 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4607 * tui/tui-data.h (struct tui_source_window_base) <refill,
4608 set_is_exec_point_at>: New methods.
4609 (tui_source_windows, tui_add_to_source_windows): Update types.
4610 (tui_add_to_source_windows): Remove redundant declaration.
4611 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4612 (tui_source_windows): Change return type.
4613 (tui_clear_source_windows_detail): Update.
4614 (tui_add_to_source_windows): Change type of parameter.
4615 (tui_free_all_source_wins_content): Update.
4616
2042b506
TT
46172019-06-25 Tom Tromey <tom@tromey.com>
4618
4619 * tui/tui-wingeneral.c (tui_win_info::refresh)
4620 (tui_source_window_base::refresh): New methods.
4621 (tui_refresh_all): Call the refresh method.
4622 * tui/tui-data.h (struct tui_win_info)
4623 (struct tui_source_window_base) <refresh>: New method.
4624
56122977
TT
46252019-06-25 Tom Tromey <tom@tromey.com>
4626
4627 * tui/tui.h (tui_is_window_visible): Return bool.
4628 * tui/tui.c (tui_is_window_visible): Return bool.
4629 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4630 (tui_make_visible, tui_make_invisible)
4631 (tui_win_info::make_visible)
4632 (tui_source_window_base::make_visible, make_all_visible)
4633 (tui_make_all_visible, tui_make_all_invisible): Update.
4634 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4635 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4636 bool.
4637 (struct tui_win_info, struct tui_source_window_base)
4638 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4639 * tui/tui-data.c (tui_init_generic_part): Update.
4640
cda37efb
TT
46412019-06-25 Tom Tromey <tom@tromey.com>
4642
4643 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4644 (tui_source_window_base::make_visible): New methods.
4645 (make_all_visible): Make method call.
4646 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4647 (struct tui_source_window_base, struct tui_cmd_window): Override
4648 make_visible.
4649 (tui_win_is_source_type): Don't declare.
4650 * tui/tui-data.c (tui_win_is_source_type): Remove.
4651
6a0ee02c
TT
46522019-06-25 Tom Tromey <tom@tromey.com>
4653
4654 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4655 NULL check.
4656
63901aec
TT
46572019-06-25 Tom Tromey <tom@tromey.com>
4658
4659 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4660 Inline constructor. Add initializers for members.
4661 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4662 constructors; now inline in class.
4663
ceb13a13
TT
46642019-06-25 Tom Tromey <tom@tromey.com>
4665
4666 * tui/tui-regs.c (tui_show_registers): Update.
4667 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4668 bool.
4669 * tui/tui-data.c (tui_data_window::clear_detail)
4670 (tui_data_window): Update.
4671
238eb706
TT
46722019-06-25 Tom Tromey <tom@tromey.com>
4673
4674 * tui/tui-windata.c (tui_display_all_data)
4675 (tui_display_data_from_line, tui_display_data_from)
4676 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4677 Update.
4678 * tui/tui-regs.c (tui_last_regs_line_no)
4679 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4680 (tui_show_registers, tui_show_register_group)
4681 (tui_display_registers_from, tui_display_reg_element_at_line)
4682 (tui_display_registers_from_line, tui_check_register_values)
4683 (tui_reg_next, tui_reg_prev): Update.
4684 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4685 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4686 tui_data_window.
4687 (struct tui_win_info) <detail>: Remove. Add new fields from
4688 tui_data_info.
4689 (TUI_DATA_WIN): Add cast.
4690 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4691 (~tui_data_window): Simplify.
4692
81491aa0
TT
46932019-06-25 Tom Tromey <tom@tromey.com>
4694
4695 * tui/tui-layout.c (show_source_disasm_command)
4696 (show_source_or_disasm_and_command): Update.
4697 * tui/tui-io.c (update_cmdwin_start_line)
4698 (tui_redisplay_readline): Update.
4699 * tui/tui-data.h (struct tui_command_info): Remove.
4700 (struct tui_win_info) <detail>: Remove command_info member.
4701 (struct tui_data_window) <start_line>: New member, from
4702 tui_command_info.
4703 (TUI_CMD_WIN): Add casts.
4704
e6e41501
TT
47052019-06-25 Tom Tromey <tom@tromey.com>
4706
4707 * tui/tui-winsource.c (tui_update_source_window)
4708 (tui_refill_source_window)
4709 (tui_source_window_base::do_scroll_horizontal)
4710 (tui_update_breakpoint_info, tui_set_exec_info_content)
4711 (tui_show_exec_info_content, tui_erase_exec_info_content)
4712 (tui_clear_exec_info_content): Update.
4713 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4714 Update.
4715 * tui/tui-win.c (make_invisible_and_set_new_height)
4716 (make_visible_with_new_height): Update.
4717 * tui/tui-source.c (tui_set_source_content)
4718 (tui_show_symtab_source): Update.
4719 * tui/tui-layout.c (extract_display_start_addr)
4720 (show_source_disasm_command, show_data)
4721 (make_source_or_disasm_window)
4722 (show_source_or_disasm_and_command): Update.
4723 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4724 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4725 "gdbarch".
4726 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4727 to tui_source_window_base.
4728 (struct tui_win_info) <detail>: Remove source_info member.
4729 (struct tui_source_window_base) <has_locator>: Inline.
4730 Move contents from tui_source_info; rename has_locator member to
4731 m_has_locator.
4732 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4733 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4734 header file.
4735 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4736 Simplify.
4737 (tui_free_all_source_wins_content): Cast to
4738 tui_source_window_base.
4739
44f0e208
TT
47402019-06-25 Tom Tromey <tom@tromey.com>
4741
4742 * tui/tui-win.c (make_invisible_and_set_new_height)
4743 (make_visible_with_new_height): Call has_locator method.
4744 * tui/tui-layout.c (show_source_disasm_command, show_data)
4745 (show_source_or_disasm_and_command): Update for bool change.
4746 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4747 (tui_win_info) <has_locator>: New method.
4748 (struct tui_source_window_base) <has_locator>: New method.
4749 (tui_win_has_locator): Don't declare.
4750 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4751 from tui_win_has_locator.
4752 (tui_source_window_base): Use false, not FALSE.
4753
7778b912
TT
47542019-06-25 Tom Tromey <tom@tromey.com>
4755
4756 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4757 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4758 clear_detail method directly.
4759 (tui_clear_win_detail): Remove.
4760
f83d391c
TT
47612019-06-25 Tom Tromey <tom@tromey.com>
4762
4763 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4764 "this", not TUI_DISASM_WIN.
4765
13446e05
TT
47662019-06-25 Tom Tromey <tom@tromey.com>
4767
4768 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4769 declare.
4770 * tui/tui-winsource.c
4771 (tui_source_window_base::do_scroll_horizontal): Rename from
4772 tui_horizontal_source_scroll.
4773 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4774 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4775 from tui_vertical_data_scroll.
4776 * tui/tui-win.h (tui_scroll): Don't declare.
4777 * tui/tui-win.c (tui_win_info::forward_scroll)
4778 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4779 (tui_win_info::right_scroll): Rename and update.
4780 (tui_scroll_forward_command, tui_scroll_backward_command)
4781 (tui_scroll_left_command, tui_scroll_right_command): Update.
4782 (tui_scroll): Remove.
4783 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4784 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4785 from tui_vertical_source_scroll.
4786 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4787 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4788 from tui_vertical_disassem_scroll.
4789 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4790 do_scroll_horizontal>: New methods.
4791 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4792 Likewise.
4793 (struct tui_source_window_base): Add do_scroll_horizontal.
4794 (struct tui_source_window, struct tui_disasm_window): Add
4795 do_scroll_vertical.
4796 (struct tui_data_window, struct tui_cmd_window): Add
4797 do_scroll_horizontal and do_scroll_vertical.
4798 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4799
5cf82909
TT
48002019-06-25 Tom Tromey <tom@tromey.com>
4801
4802 * tui/tui-data.h (struct tui_source_window_base): New struct.
4803 (struct tui_source_window): Derive from tui_source_window_base.
4804 (struct tui_disasm_window): New struct.
4805 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4806 from tui_source_window::clear_detail.
4807 (tui_source_window_base): Rename from tui_source_window.
4808 (~tui_source_window_base): Rename from ~tui_source_window.
4809 (tui_alloc_win_info): Create a tui_disasm_window.
4810
ee1d42d6
TT
48112019-06-25 Tom Tromey <tom@tromey.com>
4812
4813 * tui/tui-data.h (struct tui_source_window)
4814 (struct tui_data_window): Declare destructors.
4815 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4816 destructors.
4817 (tui_win_info): Simplify.
4818
b4eb2452
TT
48192019-06-25 Tom Tromey <tom@tromey.com>
4820
4821 * tui/tui-winsource.c (tui_display_main)
4822 (tui_update_source_windows_with_addr)
4823 (tui_update_all_breakpoint_info): Update.
4824 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4825 (new_height_ok, parse_scrolling_args): Update.
4826 * tui/tui-stack.c (tui_show_frame_info): Update.
4827 * tui/tui-data.h (struct tui_list): Remove.
4828 (tui_source_windows): Return a reference to a std::vector.
4829 * tui/tui-data.c (source_windows): Now a std::vector.
4830 (tui_source_windows): Change return type.
4831 (tui_clear_source_windows): Rewrite.
4832 (tui_clear_source_windows_detail, tui_add_to_source_windows)
4833 (tui_free_all_source_wins_content): Rewrite.
4834
8761a91b
TT
48352019-06-25 Tom Tromey <tom@tromey.com>
4836
4837 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4838 (struct tui_data_window, struct tui_cmd_window): Declare
4839 clear_detail method.
4840 * tui/tui-data.c (tui_source_window::clear_detail)
4841 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4842 methods.
4843 (tui_clear_win_detail): Simplify.
4844
0ed69eda
TT
48452019-06-25 Tom Tromey <tom@tromey.com>
4846
4847 * tui/tui-layout.c (make_source_window, make_disasm_window)
4848 (make_source_or_disasm_window): Remove win_info_ptr parameter.
4849 Return the new window.
4850 (show_source_disasm_command, show_data)
4851 (show_source_or_disasm_and_command): Update.
4852
82432e10
TT
48532019-06-25 Tom Tromey <tom@tromey.com>
4854
4855 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4856 parameter. Return the new window.
4857 (show_source_disasm_command): Update and remove NULL check.
4858 (show_source_or_disasm_and_command): Update.
4859
ec328aa5
TT
48602019-06-25 Tom Tromey <tom@tromey.com>
4861
4862 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4863
33b906ab
TT
48642019-06-25 Tom Tromey <tom@tromey.com>
4865
4866 * tui/tui-data.h (struct tui_win_info): Make constructor
4867 protected. Make destructor virtual. Add initializers.
4868 (tui_source_window, tui_data_window, tui_cmd_window): New
4869 classes.
4870 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
4871 constructor. Add "type" parameter.
4872 (tui_source_window, tui_data_window, tui_cmd_window): New
4873 constructors.
4874 (tui_alloc_win_info): Instantiate the appropriate subclass.
4875
e7e11af4
TT
48762019-06-25 Tom Tromey <tom@tromey.com>
4877
4878 * tui/tui-win.c (tui_resize_all): Use delete.
4879 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4880 destructor.
4881 (tui_free_window): Don't declare.
4882 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4883 Update.
4884
6792b55e
TT
48852019-06-25 Tom Tromey <tom@tromey.com>
4886
4887 * tui/tui-data.h (struct tui_win_info): Add constructor.
4888 * tui/tui-data.c (tui_alloc_win_info): Use new.
4889 (tui_free_window): Use delete.
4890
f95675e1
TT
48912019-06-22 Tom Tromey <tom@tromey.com>
4892
4893 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4894 declare.
4895 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4896
5bff081c
TT
48972019-06-22 Tom Tromey <tom@tromey.com>
4898
4899 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4900 declare.
4901 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4902
47e3f474
TV
49032019-06-22 Tom de Vries <tdevries@suse.de>
4904
4905 * dwarf2read.c (create_addrmap_from_aranges)
4906 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4907 instead of '%zu'.
4908
fd5866f6
SM
49092019-06-21 Simon Marchi <simon.marchi@efficios.com>
4910
4911 * dwarf2read.h (dwarf2_section_info_def): Remove.
4912 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4913 * dwarf2read.c (struct dwo_sections) <types>: Change type to
4914 std::vector<dwarf2_section_info>.
4915 (struct dwo_file) <~dwo_file>: Remove.
4916 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4917 types field.
4918 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4919 (dwarf2_read_debug_names): Likewise.
4920 (create_debug_types_hash_table): Change parameter type to
4921 array_view, adjust code accordingly.
4922 (dwarf2_locate_dwo_sections): Adjust to std::vector.
4923 (partial_die_info::fixup): Likewise.
4924 (determine_prefix): Likewise.
4925 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4926
fb1eb2f9
SM
49272019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4928
4929 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4930 gdb_bfd_ref_ptr.
4931 <~dwo_file>: Remove call to gdb_bfd_unref.
4932 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4933 gdb_bfd_ref_ptr::get.
4934
51ac9db5
SM
49352019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4936
4937 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4938 type to htab_up.
4939 * dwarf2read.c (struct dwo_file): Initialize fields.
4940 <~dwo_file>: New.
4941 (free_dwo_file): Remove, move content to ~dwo_file.
4942 (struct dwo_file_deleter): Remove.
4943 (dwo_file_up>: Remove custom deleter.
4944 (free_dwo_files): Remove.
4945 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4946 dwo_files.
4947 (process_skeletonless_type_units): Call unique_ptr::get.
4948 (allocate_dwo_file_hash_table): Add deleter to created hash
4949 table. Change return type to htab_up.
4950 (lookup_dwo_file_slot): Don't memset dwo_file, call
4951 unique_ptr::get.
4952 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4953 (create_dwo_unit_in_dwp_v2): Likewise.
4954 (open_and_init_dwo_file): Likewise.
4955 (free_dwo_file_from_slot): Remove.
4956
dc4ccb6f
SM
49572019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4958
4959 * dwarf2read.h (struct dwarf2_section_info) <readin,
4960 is_virtual>: Change type to bool.
4961 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4962 true instead of 1.
4963
e6a1c5cb
TT
49642019-06-19 Tom Tromey <tom@tromey.com>
4965
4966 * tui/tui-data.h (tui_init_content_element): Don't declare.
4967
6f6ffbeb
TT
49682019-06-19 Tom Tromey <tom@tromey.com>
4969
4970 * tui/tui-data.h (tui_init_win_info): Don't declare.
4971
f23f598e
TV
49722019-06-19 Tom de Vries <tdevries@suse.de>
4973
4974 * dwarf2read.h (abstract_to_concrete): Change type to
4975 std::unordered_map<sect_offset, std::vector<sect_offset>,
4976 gdb::hash_enum<sect_offset>>.
4977
680e1bee
TT
49782019-06-19 Tom Tromey <tromey@adacore.com>
4979
4980 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4981 EVAL_AVOID_SIDE_EFFECTS specially.
4982
dcf37923
TT
49832019-06-19 Tom Tromey <tromey@adacore.com>
4984
4985 * source-cache.c (highlighter): New global.
4986 (source_cache::get_source_lines): Create a highlighter on demand.
4987
494986d5
AB
49882019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4989
4990 * defs.h (deprecated_interactive_hook): Delete declaration.
4991 * interps.c (clear_interpreter_hooks): Remove use of
4992 deprecated_interactive_hook.
4993 * top.c (deprecated_interactive_hook): Delete definition.
4994 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4995
3360b6e7
TV
49962019-06-18 Tom de Vries <tdevries@suse.de>
4997
4998 PR gdb/24515
4999 * dwarf2read.h (abstract_to_concrete): Change type from
5000 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5001 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5002 * dwarf2read.c (read_variable): Update.
5003 (dwarf2_fetch_die_loc_sect_off): Update.
5004
310b3441
TV
50052019-06-17 Tom de Vries <tdevries@suse.de>
5006
5007 PR gdb/24617
5008 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5009 accessing parent[parent_len - 1].
5010
ba9777be
PP
50112019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5012
5013 PR gdb/24364
5014 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5015 call dtrace_process_dof with NULL dof.
5016
2b9f6e89
TV
50172019-06-16 Tom de Vries <tdevries@suse.de>
5018
5019 PR gdb/24445
5020 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5021
431b3ead
TT
50222019-06-16 Tom Tromey <tom@tromey.com>
5023
5024 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5025 (make_all_visible): Use address of member.
5026
d04b44a1
TT
50272019-06-16 Tom Tromey <tom@tromey.com>
5028
5029 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5030 (tui_free_window, free_content, free_content_elements): Remove
5031 unnecessary cast.
5032 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5033 cast.
5034 * tui/tui-regs.c (tui_show_register_group)
5035 (tui_display_registers_from, tui_display_reg_element_at_line):
5036 Remove unnecessary cast.
5037
bf5142e7
AB
50382019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5039
5040 * linux-nat.c (normal_mask): Delete.
5041 (_initialize_linux_nat): Don't initialise normal_mask.
5042
c4973306
SM
50432019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5044
5045 PR gdb/24445
5046 * dwarf-index-write.h (write_psymtabs_to_index): Add
5047 dwz_basename parameter.
5048 * dwarf-index-write.c (write_gdbindex): Move file writing to
5049 write_gdbindex_1. Change return type void.
5050 (assert_file_size): Move up, remove filename parameter.
5051 (write_gdbindex_1): New function.
5052 (write_debug_names): Change return type to void, call
5053 assert_file_size.
5054 (struct index_wip_file): New struct.
5055 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5056 file logic to index_wip_file. Write index for dwz file if
5057 needed.
5058 (save_gdb_index_command): Pass basename of dwz file, if present.
5059 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5060 build-id of dwz file, if present.
5061 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5062 (dwarf2_get_dwz_file): Likewise.
5063 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5064 (dwarf2_get_dwz_file): Likewise.
5065
395f9c91
TT
50662019-06-16 Tom Tromey <tom@tromey.com>
5067
5068 * coffread.c (process_coff_symbol): Use xstrdup.
5069 * value.c (create_internalvar): Use xstrdup.
5070
cafb3438
TT
50712019-06-16 Tom Tromey <tom@tromey.com>
5072
5073 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5074 * breakpoint.c (stopin_command, stopat_command)
5075 (until_break_command, decode_location_default): Remove unnecessary
5076 cast.
5077 * utils.c (subset_compare): Remove unnecessary cast.
5078 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5079 cast.
5080 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5081 cast.
5082 * infcmd.c (path_command): Remove unnecessary cast.
5083 * coffread.c (decode_type): Remove unnecessary cast.
5084 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5085 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5086 * tui/tui-stack.c (tui_show_locator_content)
5087 (tui_show_frame_info): Remove unnecessary cast.
5088 * tui/tui-win.c (tui_scroll_forward_command)
5089 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5090 (parse_scrolling_args): Remove unnecessary cast.
5091 * tui/tui-data.c (init_win_info, tui_del_window)
5092 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5093 (free_content_elements): Remove unnecessary cast.
5094 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5095 unnecessary cast.
5096 * tui/tui-source.c (tui_set_source_content)
5097 (tui_vertical_source_scroll): Remove unnecessary cast.
5098 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5099 cast.
5100 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5101 * tui/tui-regs.c (tui_display_registers_from)
5102 (tui_display_register): Remove unnecessary cast.
5103 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5104 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5105 (make_visible): Remove unnecessary cast.
5106 * tui/tui-winsource.c (tui_erase_source_content)
5107 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5108 unnecessary cast.
5109 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5110 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5111 * stabsread.c (read_type, read_array_type, read_range_type):
5112 Remove unnecessary cast.
5113 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5114 (parse_symbol, parse_type, upgrade_type, parse_external)
5115 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5116 unnecessary cast.
5117 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5118
730ead81
TT
51192019-06-16 Tom Tromey <tom@tromey.com>
5120
5121 * tui/tui-data.c (tui_alloc_generic_win_info)
5122 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5123 checks.
5124
584a927c
AB
51252019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5126 Andrew Burgess <andrew.burgess@embecosm.com>
5127
5128 * f-typeprint.c (f_print_type): Don't return early for not
5129 associated or not allocated types.
5130 (f_type_print_varspec_suffix): Add print_rank parameter and print
5131 ranks of array types in case they dangling.
5132 (f_type_print_base): Add print_rank parameter.
5133
30056ea0
AB
51342019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5135
5136 * NEWS: Mention new MI commands.
5137 * break-catch-throw.c (enum exception_event_kind): Move to
5138 breakpoint.h.
5139 (print_mention_exception_catchpoint): Output text as a single
5140 message.
5141 (catch_exception_command_1): Rename to...
5142 (catch_exception_event): ...this, make non-static, update header
5143 command, and change some parameter types.
5144 (catch_catch_command): Update for changes to
5145 catch_exception_command_1.
5146 (catch_throw_command): Likewise.
5147 (catch_rethrow_command): Likewise.
5148 * breakpoint.c (enum exception_event_kind): Delete.
5149 * breakpoint.h (enum exception_event_kind): Moved here from
5150 break-catch-throw.c.
5151 (catch_exception_event): Declare.
5152 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5153 (mi_cmd_catch_throw): New function.
5154 (mi_cmd_catch_rethrow): New function.
5155 (mi_cmd_catch_catch): New function.
5156 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5157 'catch-catch' entries.
5158 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5159 (mi_cmd_catch_rethrow): Declare.
5160 (mi_cmd_catch_catch): Declare.
5161
ec8e2b6d
AB
51622019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5163
5164 * annotate.c (annotate_source_line): Change return type to void,
5165 update implementation to match.
5166 * annotate.h (annotate_source_line): Change return type to void,
5167 update header comment.
5168 * stack.c (print_frame_info): Don't change what frame information
5169 is printed based on whether annotations are on or not.
5170
0d3abd8c
AB
51712019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5172
5173 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5174 (annotate_source): Make static.
5175 (annotate_source_line): Moved from source.c and renamed from
5176 identify_source_line. Update the return type.
5177 * annotate.h (annotate_source): Delete declaration.
5178 (annotate_source_line): Declaration moved from source.h, and
5179 renamed from identify_source_line. Return type updated.
5180 * source.c (identify_source_line): Moved to annotate.c and renamed
5181 to annotate_source_line.
5182 (info_line_command): Remove check of annotation_level.
5183 * source.h (identify_source_line): Move declaration to annotate.h
5184 and rename to annotate_source_line.
5185 * stack.c: Add 'annotate.h' include.
5186 (print_frame_info): Remove check of annotation_level before
5187 calling annotate_source_line.
5188
00df30ae
AB
51892019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5190
5191 * source-cache.c (source_cache::get_plain_source_lines): Use
5192 open_source_file_with_line_charpos instead of just
5193 open_source_file, remove call to find_source_lines.
5194 (source_cache::get_source_lines): Likewise.
5195 * source.c (find_source_lines): Make static.
5196 (get_filename_and_charpos): Renamed into...
5197 (open_source_file_with_line_charpos): ..this along with changes to
5198 return a scoped_fd, and some other minor clean ups.
5199 (identify_source_line): Use open_source_file_with_line_charpos.
5200 (search_command_helper): Use open_source_file_with_line_charpos
5201 instead of just open_source_file, remove call to
5202 find_source_lines.
5203 * source.h (open_source_file_with_line_charpos): Declare new
5204 function.
5205 (find_source_lines): Delete declaration.
5206
afda45a2
AB
52072019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5208
5209 * source.c (get_filename_and_charpos): Remove fullname
5210 parameter.
5211 (identify_source_line): Update call to get_filename_and_charpos.
5212
0735b091
TT
52132019-06-14 Tom Tromey <tromey@adacore.com>
5214
5215 PR gdb/24502:
5216 * ui-style.h (skip_ansi_escape): Update comment.
5217 * ui-file.h (class no_terminal_escape_file): New class.
5218 * ui-file.c (no_terminal_escape_file::write)
5219 (no_terminal_escape_file::puts): New methods.
5220 * cli/cli-logging.c (handle_redirections): Use
5221 no_terminal_escape_file.
5222
52ce35e2
TT
52232019-06-14 Tom Tromey <tromey@adacore.com>
5224
5225 * NEWS: Move convenience variable news above Python news.
5226
73cc7272
TT
52272019-06-14 Tom Tromey <tom@tromey.com>
5228
5229 * gnulib: Move directory to top-level.
5230 * configure.ac: Don't configure gnulib.
5231 * configure: Rebuild.
5232 * common/common-defs.h: Use new path to gnulib.
5233 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5234 (GNULIB_H): Remove.
5235 (INCGNU): Look in new gnulib location.
5236 (HFILES_NO_SRCDIR): Remove gnulib files.
5237 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5238 (generated_files): Remove GNULIB_H.
5239 ($(LIBGNU), all-lib): Remove targets.
5240 (distclean): Don't mention GNULIB_BUILDDIR.
5241 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5242
f5686554
TT
52432019-06-14 Tom Tromey <tromey@adacore.com>
5244
5245 * symfile.c (add_symbol_file_command): Remove obsolete comment.
5246 Warn if symbol file does not provide any symbols.
5247
a0c1ffed
TT
52482019-06-14 Tom Tromey <tromey@adacore.com>
5249
5250 * source.c (find_and_open_source): Respect basenames_may_differ.
5251
7c39e397
AB
52522019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
5253
5254 * annotate.c (annotate_breakpoints_invalid): Make use of
5255 scoped_restore_terminal_state.
5256 (annotate_frames_invalid): Likewise.
5257
f411722c
TT
52582019-06-14 Tom Tromey <tromey@adacore.com>
5259
5260 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5261 allow assignment to an internalvar.
5262
4268ec18
TT
52632019-06-14 Tom Tromey <tromey@adacore.com>
5264
5265 * ada-lex.l: Allow "_" in attribute names.
5266
abdb711e
TT
52672019-06-14 Tom Tromey <tromey@adacore.com>
5268
5269 PR gdb/24653:
5270 * regcache.c (registers_changed): Don't call alloca.
5271 * top.c (execute_command): Don't call alloca.
5272
4c048731
PA
52732019-06-13 Pedro Alves <palves@redhat.com>
5274
5275 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5276 'expression'. When parsing an expression, error out if there's
5277 junk after "unlimited".
5278 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5279 (do_set_command): Adjust calls to is_unlimited_literal.
5280
66eb1ed3
PA
52812019-06-13 Pedro Alves <palves@redhat.com>
5282
5283 * compile/compile.c (make_compile_options_def_group): Add braces
5284 around array_view initializer.
5285 * thread.c (make_thread_apply_all_options_def_group)
5286 (make_thread_apply_all_options_def_group): Likewise.
5287
3345721a
PA
52882019-06-13 Pedro Alves <palves@redhat.com>
5289
5290 * NEWS (New commands): Mention "maint test-options
5291 require-delimiter", "maint test-options unknown-is-error", "maint
5292 test-options unknown-is-operand" and "maint show
5293 test-options-completion-result".
5294 (New command options, command completion): New section.
5295 (Completion improvements): New section.
5296 Mention that you can abbreviate "unlimited".
5297
6206060d
PA
52982019-06-13 Pedro Alves <palves@redhat.com>
5299
5300 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5301 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5302 * unittests/cli-utils-selftests.c (test_parse_flags)
5303 (test_parse_flags_qcs): Delete.
5304 (test_cli_utils): Don't call deleted functions.
5305
6665660a
PA
53062019-06-13 Pedro Alves <palves@redhat.com>
5307
5308 * thread.c: Include "cli/cli-option.h".
5309 (tp_array_compar_ascending): Global.
5310 (tp_array_compar): Delete function.
5311 (tp_array_compar_ascending, tp_array_compar_descending): New
5312 functions.
5313 (ascending_option_def, qcs_flag_option_def)
5314 (thr_qcs_flags_option_defs)
5315 (make_thread_apply_all_options_def_group)
5316 (make_thread_apply_options_def_group): New.
5317 (thread_apply_all_command): Use gdb::option::process_options.
5318 (thread_apply_command_completer)
5319 (thread_apply_all_command_completer): New.
5320 (thread_apply_command): Use gdb::option::process_options.
5321 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5322 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
5323 to generate help text of "thread apply". Adjust "taas"'s help.
5324 * tid-parse.c (tid_range_parser::in_thread_range): New method.
5325 * tid-parse.h (tid_range_parser::in_thread_range): New method.
5326
f7e13587
PA
53272019-06-13 Pedro Alves <palves@redhat.com>
5328
5329 * thread.c (thread_apply_command): Check for invalid TID with
5330 isdigit instead of !isalpha.
5331
5d707134
PA
53322019-06-13 Pedro Alves <palves@redhat.com>
5333
5334 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5335 (validate_flags_qcs): New.
5336 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5337 (validate_flags_qcs): Declare.
5338 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5339 (make_frame_apply_options_def_group): New.
5340 (frame_apply_command_count): Process options with
5341 gdb::option::process_options.
5342 (frame_apply_completer): New.
5343 (frame_apply_level_completer, frame_apply_all_completer)
5344 (frame_apply_completer): New.
5345 (_initialize_stack): Update help of "frame apply", "frame apply
5346 level", "frame apply all" and "faas" to mention supported options
5347 and install command completers.
5348 * stack.h (frame_apply_all_completer): Declare.
5349 * thread.c: Include "stack.h".
5350 (tfaas_command): Add "--".
5351 (_initialize_thread): Update help "tfaas" to mention supported
5352 options and install command completer.
5353
272d4594
PA
53542019-06-13 Pedro Alves <palves@redhat.com>
5355
5356 * completer.c (complete_nested_command_line): New.
5357 (gdb_completion_word_break_characters_throw): Add assertion.
5358 * completer.h (complete_nested_command_line): Declare.
5359
90a1ef87
PA
53602019-06-13 Pedro Alves <palves@redhat.com>
5361
5362 * stack.c (parse_backtrace_qualifiers): New.
5363 (backtrace_command): Use it.
5364 (backtrace_command_completer): Complete on qualifiers.
5365
d4c16835
PA
53662019-06-13 Pedro Alves <palves@redhat.com>
5367
5368 * frame.c: Include "cli/cli-option.h.
5369 (user_set_backtrace_options): New.
5370 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5371 Delete.
5372 (get_prev_frame): Adjust.
5373 (boolean_option_def, uinteger_option_def)
5374 (set_backtrace_option_defs): New.
5375 (_initialize_frame): Adjust and use
5376 gdb::option::add_setshow_cmds_for_options to install "set
5377 backtrace past-main" and "set backtrace past-entry".
5378 * frame.h: Include "cli/cli-option.h".
5379 (struct frame_print_options): Forward declare.
5380 (print_frame_arguments_all, print_frame_arguments_scalars)
5381 (print_frame_arguments_none): Declare.
5382 (print_entry_values): Delete declaration.
5383 (struct frame_print_options, user_frame_print_options): New.
5384 (struct set_backtrace_options): New.
5385 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5386 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5387 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5388 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5389 (list_args_or_locals): Add frame_print_options parameter.
5390 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5391 * python/py-framefilter.c (enumerate_args): Pass down
5392 USER_FRAME_PRINT_OPTIONS.
5393 * stack.c: Include "cli/cli-option.h".
5394 (print_frame_arguments_all, print_frame_arguments_scalars)
5395 (print_frame_arguments_none): Declare.
5396 (print_raw_frame_arguments, print_entry_values): Delete.
5397 (user_frame_print_options): New.
5398 (boolean_option_def, enum_option_def, frame_print_option_defs):
5399 New.
5400 (struct backtrace_cmd_options): New.
5401 (bt_flag_option_def): New.
5402 (backtrace_command_option_defs): New.
5403 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5404 (print_frame_arg, read_frame_arg, print_frame_args)
5405 (print_frame_info, print_frame): Add frame_print_options parameter
5406 and use it.
5407 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5408 (backtrace_command_1): Add frame_print_options and
5409 backtrace_cmd_options parameters and use them.
5410 (make_backtrace_options_def_group): New.
5411 (backtrace_command): Process command options with
5412 gdb::option::process_options.
5413 (backtrace_command_completer): New.
5414 (_initialize_stack): Extend "backtrace"'s help to mention
5415 supported options. Install completer for "backtrace".
5416 Install some settings commands with add_setshow_cmds_for_options.
5417
2daf894e
PA
54182019-06-13 Pedro Alves <palves@redhat.com>
5419
5420 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5421 and that "set/show print raw frame-arguments" are now deprecated.
5422
5423 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5424 command.
5425 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5426 * stack.c (_initialize_stack): Install "set/show print
5427 raw-frame-arguments", and deprecate "set/show print raw
5428 frame-arguments".
5429 * valprint.c (_initialize_valprint): Deprecate "set/show print
5430 raw".
5431
e6ed716c
PA
54322019-06-13 Pedro Alves <palves@redhat.com>
5433
5434 * compile/compile.c (struct compile_options): New.
5435 (compile_flag_option_def, compile_command_option_defs)
5436 (make_compile_options_def_group): New.
5437 (compile_file_command): Handle options with
5438 gdb::option::process_options.
5439 (compile_file_command_completer): New function.
5440 (compile_code_command): Handle options with
5441 gdb::option::process_options.
5442 (compile_code_command_completer): New function.
5443 (_initialize_compiler): Install completers for "compile code" and
5444 "compile file". Mention available options in "compile code" and
5445 "compile code"'s help.
5446 * completer.c (advance_to_completion_word): New, factored out from
5447 ...
5448 (advance_to_expression_complete_word_point): ... this.
5449 (advance_to_filename_complete_word_point): New.
5450 * completer.h (advance_to_filename_complete_word_point): New
5451 declaration.
5452
7d8062de
PA
54532019-06-13 Pedro Alves <palves@redhat.com>
5454
5455 * compile/compile.c: Include "cli/cli-option.h".
5456 (compile_print_value): Scope data pointer is now a
5457 value_print_options pointer; adjust.
5458 (compile_print_command): Process options. Scope data pointer is
5459 now a value_print_options pointer; adjust.
5460 (_initialize_compile): Update "compile print"'s help to include
5461 supported options. Install a completer for "compile print".
5462 * cp-valprint.c (show_vtblprint, show_objectprint)
5463 (show_static_field_print): Delete.
5464 (_initialize_cp_valprint): Don't install "set print
5465 static-members", "set print vtbl", "set print object" here.
5466 * printcmd.c: Include "cli/cli-option.h" and
5467 "common/gdb_optional.h".
5468 (print_command_parse_format): Rework to fill in a
5469 value_print_options instead of a format_data.
5470 (print_value): Change parameter type from format_data pointer to
5471 value_print_options reference. Adjust.
5472 (print_command_1): Process options. Adjust to pass down a
5473 value_print_options.
5474 (print_command_completer): New.
5475 (_initialize_printcmd): Install print_command_completer as
5476 handle_brkchars completer for the "print" command. Update
5477 "print"'s help to include supported options.
5478 * valprint.c: Include "cli/cli-option.h".
5479 (show_vtblprint, show_objectprint, show_static_field_print): Moved
5480 here from cp-valprint.c.
5481 (boolean_option_def, uinteger_option_def)
5482 (value_print_option_defs, make_value_print_options_def_group):
5483 New. Use gdb::option::add_setshow_cmds_for_options to install
5484 "set print elements", "set print null-stop", "set print repeats",
5485 "set print pretty", "set print union", "set print array", "set
5486 print address", "set print symbol", "set print array-indexes".
5487 * valprint.h: Include <string> and "cli/cli-option.h".
5488 (make_value_print_options_def_group): Declare.
5489 (print_value): Change parameter type from format_data pointer to
5490 value_print_options reference.
5491 (print_command_completer): Declare.
5492
9d0faba9
PA
54932019-06-13 Pedro Alves <palves@redhat.com>
5494
5495 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5496 (COMMON_SFILES): Add maint-test-settings.c.
5497 * cli/cli-decode.c (boolean_enums): New global, factored out from
5498 ...
5499 (add_setshow_boolean_cmd): ... here.
5500 * cli/cli-decode.h (boolean_enums): Declare.
5501 * cli/cli-option.c: New file.
5502 * cli/cli-option.h: New file.
5503 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5504 factored out from ...
5505 (parse_cli_boolean_value(const char *)): ... this.
5506 (is_unlimited_literal): Change parameter type to pointer to
5507 pointer. Adjust and advance ARG pointer.
5508 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5509 (parse_cli_var_enum): New, factored out from ...
5510 (do_set_command): ... this. Adjust.
5511 * cli/cli-setshow.h (parse_cli_boolean_value)
5512 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5513 (parse_cli_var_enum): Declare.
5514 * cli/cli-utils.c: Include "cli/cli-option.h".
5515 (get_ulongest): New.
5516 * cli/cli-utils.h (get_ulongest): Declare.
5517 (check_for_argument): New overloads.
5518 * maint-test-options.c: New file.
5519
2c722807
PA
55202019-06-13 Pedro Alves <palves@redhat.com>
5521
5522 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5523 parse a range if "-" is at the end of the string.
5524
dee7b4c8
PA
55252019-06-13 Pedro Alves <palves@redhat.com>
5526
5527 * cli/cli-setshow.c (parse_auto_binary_operation)
5528 (parse_cli_boolean_value): Don't allow "o".
5529
dca0f6c0
PA
55302019-06-13 Pedro Alves <palves@redhat.com>
5531
5532 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5533 * NEWS: Mention maint test-settings KIND.
5534 * maint-test-settings.c: New file.
5535
597bf39d
PA
55362019-06-13 Pedro Alves <palves@redhat.com>
5537
5538 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5539 completer.
5540 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5541 "set" completers.
5542
48c410fb
PA
55432019-06-13 Pedro Alves <palves@redhat.com>
5544
5545 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5546 after item.
5547
93bcb043
PA
55482019-06-13 Pedro Alves <palves@redhat.com>
5549
5550 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5551
cbba3ecd
PA
55522019-06-13 Pedro Alves <palves@redhat.com>
5553
5554 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5555 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5556 call.
5557 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5558 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5559 calls.
5560 (check_for_argument): Skip spaces after argument.
5561
b9a3f842
PA
55622019-06-13 Pedro Alves <palves@redhat.com>
5563
5564 * thread.c (thread_apply_command): Adjust TID parsing.
5565 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5566 detected before end of string.
5567 (tid_is_in_list): Error out if LIST is invalid.
5568
3844e605
PA
55692019-06-13 Pedro Alves <palves@redhat.com>
5570
5571 * completer.c (complete_line_internal_1): Rewind completion word
5572 point.
5573 (completion_tracker::advance_custom_word_point_by): Change
5574 parameter type to int.
5575 * completer.h (completion_tracker::advance_custom_word_point_by):
5576 Likewise.
5577
00b56dbe
PA
55782019-06-13 Pedro Alves <palves@redhat.com>
5579
5580 * completer.c (advance_to_completion_word): Handle delimiters.
5581
d106773e
PA
55822019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
5583
5584 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5585
08f10e02
TT
55862019-06-11 Tom Tromey <tom@tromey.com>
5587
5588 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5589 (xmalloc_failed): Move to alloc.c.
5590 * alloc.c: New file.
5591 * Makefile.in (COMMON_SFILES): Add alloc.c.
5592
1c7fe951
TT
55932019-06-11 Tom Tromey <tom@tromey.com>
5594
5595 * nat/linux-waitpid.c: Don't include server.h.
5596 (linux_debug): Remove.
5597 (my_waitpid): Update.
5598
89549d7f
TT
55992019-06-11 Tom Tromey <tromey@adacore.com>
5600
5601 * infcall.c (_initialize_infcall): Remove trailing newline from
5602 help.
5603 * user-regs.c (_initialize_user_regs): Remove trailing newline
5604 from help.
5605 * typeprint.c (_initialize_typeprint): Remove trailing newline
5606 from help.
5607 * reverse.c (_initialize_reverse): Remove trailing newlines from
5608 help.
5609 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5610 from help.
5611 * language.c (add_set_language_command): Remove trailing newline
5612 from help.
5613 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5614 help.
5615 * disasm.c (_initialize_disasm): Remove trailing newline from
5616 help.
5617 * top.c (init_main): Remove trailing newline from help.
5618 * interps.c (_initialize_interpreter): Remove trailing newline
5619 from help.
5620 * btrace.c (_initialize_btrace): Remove trailing newlines from
5621 help.
5622 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5623 from help.
5624 * python/python.c (_initialize_python): Remove trailing newline
5625 from help.
5626 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5627 help.
5628 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5629 from help. Reformat some text.
5630 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5631 from help.
5632 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5633 newline from help.
5634
86108c13
TT
56352019-06-11 Tom Tromey <tromey@adacore.com>
5636
5637 * darwin-nat.c (darwin_decode_exception_message)
5638 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5639
a7067863
AB
56402019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5641
5642 * valops.c (value_slice): Check for not allocated or not
5643 associated values.
5644
9ab08412
TV
56452019-06-10 Tom de Vries <tdevries@suse.de>
5646
5647 PR gdb/24618
5648 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5649 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5650 invalid.
5651
f19e22e9
TV
56522019-06-10 Tom de Vries <tdevries@suse.de>
5653
5654 PR gdb/24611
5655 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5656 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5657
e99f9db0
TV
56582019-06-10 Tom de Vries <tdevries@suse.de>
5659
5660 PR symtab/24545
5661 * symtab.c (struct demangled_name_entry): Add language field.
5662 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5663 static minimal symbol". Set and use language field.
5664
9bf7038b
TT
56652019-06-10 Tom Tromey <tromey@adacore.com>
5666
5667 * ada-lang.c (_initialize_ada_language): Update help text.
5668
422186a9
TT
56692019-06-10 Tom Tromey <tromey@adacore.com>
5670
5671 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5672 with a newline.
5673 * guile/guile.c (handle_boot_error): Don't end warning with a
5674 newline.
5675 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5676 warning with a newline.
5677 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5678 newline.
5679 (s12z_frame_cache): Likewise.
5680 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5681 a newline.
5682 * solib-svr4.c (disable_probes_interface): Don't end warning with
5683 a newline.
5684 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5685 newline.
5686 * python/python.c (do_finish_initialization): Don't end warning
5687 with a newline.
5688
25ce02ee
TT
56892019-06-10 Tom Tromey <tom@tromey.com>
5690
5691 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5692 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5693 gdbpy_enter.
5694
caa429d8
TT
56952019-06-10 Tom Tromey <tromey@adacore.com>
5696
5697 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5698 data.
5699 (elf_new_init): Don't call stabsread_new_init.
5700 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5701 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5702 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5703
81873cc8
TV
57042019-06-10 Tom de Vries <tdevries@suse.de>
5705
5706 PR symtab/16264
5707 PR symtab/24517
5708 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5709
4fa0265e
РИ
57102019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5711
5712 * source.c (find_and_open_source): Also rewrite relative file
5713 names.
5714
1a3da2cd
AB
57152019-04-26 Amos Bird <amosbird@gmail.com>
5716
5717 * annotate.c (annotate_thread_exited): Add "thread-exited"
5718 annotation.
5719
3847a7bf
TT
57202019-06-06 Tom Tromey <tromey@adacore.com>
5721
5722 * maint.h (class scoped_command_stats): Use
5723 DISABLE_COPY_AND_ASSIGN.
5724 <print_time>: New method.
5725 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5726 print_time.
5727 (scoped_command_stats::print_time): New method.
5728
312617a3
AB
57292019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5730
5731 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5732 instructions of lengths 6 or 8 bytes.
5733
b02f78f9
PA
57342019-06-04 Pedro Alves <palves@redhat.com>
5735
5736 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5737
5738 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5739 * breakpoint.c (condition_completer): Likewise.
5740 * cli/cli-dump.c (scan_expression): Likewise.
5741 * common/filestuff.c (mkdir_recursive): Likewise.
5742 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5743 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5744 (gdb_abspath): Likewise.
5745 * compile/compile-cplus-types.c
5746 (compile_cplus_instance::decl_name): Likewise.
5747 * completer.c (complete_explicit_location):
5748 (signal_completer, reg_or_group_completer_1): Likewise.
5749 * cp-support.c (cp_remove_params_if_any): Likewise.
5750 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5751 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5752 * infcmd.c (strip_bg_char): Likewise.
5753 * linespec.c (copy_token_string): Likewise.
5754 * mi/mi-main.c (output_cores): Likewise.
5755 * psymtab.c (psymtab_search_name):
5756 * symfile.c (test_set_ext_lang_command): Likewise.
5757 * target.c (target_fileio_read_stralloc): Likewise.
5758 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5759 * value.c (complete_internalvar): Likewise.
5760
e1f2e1a2
CB
57612019-06-04 Christian Biesinger <cbiesinger@google.com>
5762
5763 Add objfile property to gdb.Type.
d3238f7d
PA
5764 * NEWS: Mention Python API addition.
5765 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 5766
e664d728
PW
57672019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5768
5769 * NEWS: Mention the new set|show style [title|highlight].
5770 Mention changes to "show style", "help" and "apropos".
5771
66d8c862
PW
57722019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5773
5774 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5775 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5776 instead of print_help_for_command.
5777 (print_doc_of_command): New function.
5778 (help_list): Add 'apropos -v word' suggestion.
5779 (print_help_for_command): Style the command name using title style.
5780 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5781 (_initialize_cli_cmds): Describe -v in apropos_command help.
5782
9303eb2f
PW
57832019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5784
5785 * cli/cli-style.h (cli_style_option): Add name in constructor,
5786 add m_name class member, add constructor with intensity,
5787 add name class function.
5788 (cli_style_option::add_setshow_commands): Remove name argument.
5789 (highlight_style, title_style): New styles.
5790 * cli/cli-style.c (do_show): New function that shows a style
5791 characteristic styling the style name with itself.
5792 (set_style_name): New function.
5793 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5794 Update all callers according to the changes in cli/cli-style.h.
5795 * utils.h (fputs_highlighted): New function.
5796 * utils.c (fputs_highlighted): Likewise.
5797
e2c52041
PW
57982019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5799
5800 * NEWS: Mention new pipe command and new convenience variables.
5801
947d3946
PW
58022019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5803
5804 * cli/cli-cmds.c (pipe_command): New function.
5805 (_initialize_cli_cmds): Call add_com for pipe_command.
5806 Define | as an alias for pipe.
5807 (exit_status_set_internal_vars): New function.
5808 (shell_escape): Call exit_status_set_internal_vars.
5809 cli/cli-decode.c (find_command_name_length): Recognize | as
5810 a single character command.
5811
b8fd0918
PW
58122019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5813
5814 * gdbcmd.h (execute_command_to_ui_file): New declaration.
5815 top.c (execute_command_to_ui_file): New function, mostly a copy
5816 of execute_command_to_string.
5817 (execute_command_to_string): Implement by calling
5818 execute_command_to_ui_file.
5819
68bb5386
PW
58202019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5821
5822 * top.h (saved_command_line): Remove declaration.
5823 * top.c (previous_saved_command_line, previous_repeat_arguments):
5824 New variables.
5825 (saved_command_line): Make static, define together with other
5826 'repeat variables'.
5827 (dont_repeat): Clear repeat_arguments.
5828 (repeat_previous, get_saved_command_line, save_command_line):
5829 New functions.
5830 (gdb_init): Initialize saved_command_line
5831 and previous_saved_command_line.
5832 * main.c (captured_main_1): Remove saved_command_line initialization.
5833 * event-top.c (handle_line_of_input): Update to use
5834 the new 'repeat' related functions instead of direct access to
5835 saved_command_line.
5836 * command.h (repeat_previous, get_saved_command_line,
5837 save_command_line): New declarations.
5838 (dont_repeat): Add comment.
5839
bfcdb852
TT
58402019-05-30 Tom Tromey <tromey@adacore.com>
5841
5842 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5843 Fix comment.
5844 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5845
0ef209f2
JV
58462019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
5847
5848 PR cli/24587
5849 * completer.c (complete): Initialize variable word.
5850
955b06fa
SDJ
58512019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
5852
5853 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5854 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5855 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5856 'body' is NULL to the outter 'if', protecting the '!is_define'
5857 situation as well.
5858
fa9c3fa0
TT
58592019-05-29 Tom Tromey <tromey@adacore.com>
5860
5861 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5862 (dwarf_unknown): New function.
5863 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5864 (dwarf_type_encoding_name): Use dwarf_unknown.
5865
4330d61d
TT
58662019-05-29 Tom Tromey <tromey@adacore.com>
5867
5868 PR c++/20020:
5869 * cp-valprint.c (cp_print_value_fields): Call
5870 cp_print_static_field inside "try".
5871
33a6bc35
TT
58722019-05-29 Tom Tromey <tromey@adacore.com>
5873
5874 * inflow.c (struct terminal_info): Add default operator=.
5875 * configure: Rebuild.
5876 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5877 -Wdeprecated-copy-dtor, -Wredundant-move.
5878
000439d5
TT
58792019-05-29 Tom Tromey <tromey@adacore.com>
5880
5881 * NEWS: Add entry.
5882 * infcmd.c (print_return_value_1): Handle finish_print
5883 option.
5884 (show_print_finish): New function.
5885 (_initialize_infcmd): Add "set/show print finish" commands.
5886 * valprint.c (user_print_options): Initialize new member.
5887 * valprint.h (struct value_print_options) <finish_print>: New
5888 member.
5889
c0e70c62
TT
58902019-05-28 Tom Tromey <tromey@adacore.com>
5891
5892 * ada-lang.c (ada_remove_Xbn_suffix)
5893 (find_old_style_renaming_symbol)
5894 (parse_old_style_renaming): Remove.
5895 (ada_find_renaming_symbol): Don't call
5896 find_old_style_renaming_symbol.
5897 (ada_is_renaming_symbol): Rename from
5898 ada_find_renaming_symbol. Remove "block" parameter. Return
5899 bool. Now static.
5900 (ada_read_var_value): Update and simplify.
5901 * ada-exp.y (write_var_or_type): Remove old code.
5902
766f8836
AH
59032019-05-28 Alan Hayward <alan.hayward@arm.com>
5904
5905 * event-top.c: Remove include comment.
5906 * inflow.c (class scoped_ignore_sigttou): Move from here...
5907 * inflow.h (class scoped_ignore_sigttou): ...to here.
5908 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5909 * top.c: Remove include comment.
5910
eb41253a
TT
59112019-05-27 Tom Tromey <tom@tromey.com>
5912
5913 * NEWS: Fix typo.
5914
4ca51187
TT
59152019-05-22 Tom Tromey <tromey@adacore.com>
5916
5917 * target.c (target_follow_exec): Constify parameter.
5918 * target-delegates.c: Rebuild.
5919 * remote.c (remote_target::follow_exec): Constify parameter.
5920 * infrun.c (follow_exec): Constify parameter.
5921 * target.h (struct target_ops) <follow_exec>: Constify parameter.
5922 (target_follow_exec): Likewise.
5923
8fca4da0
AH
59242019-05-22 Alan Hayward <alan.hayward@arm.com>
5925
5926 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5927 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5928
b7060614
AH
59292019-05-22 Alan Hayward <alan.hayward@arm.com>
5930
5931 * NEWS: Add debugredirect and testsuite sections.
5932
0a5954bd
SC
59332019-05-22 Simon Cook <simon.cook@embecosm.com>
5934
5935 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5936 target descriptions using exclusively floating point register name
5937 aliases.
5938
dc42e902
AB
59392019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
5940
5941 PR gdb/18644:
5942 * f-lang.c (build_fortran_types): Handle the case where
5943 gdbarch_floatformat_for_type returns a nullptr.
5944
fb7806c7
TV
59452019-05-21 Tom de Vries <tdevries@suse.de>
5946
5947 PR cli/24587
5948 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5949
34d11c68
AB
59502019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5951
5952 PR gdb/18644:
5953 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5954 16-byte floats.
5955 * i386-tdep.c (i386_floatformat_for_type): Use
5956 floatformats_ia64_quad for the 16-byte floating point component
5957 within a fortran 32-byte complex number.
5958
122cf0f2
AB
59592019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5960
5961 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5962 delete default constructor.
5963 (find_partial_die): Update to return const struct.
5964 (partial_die_parent_scope): Move variable declaration into scope
5965 of its use and change its type to auto.
5966 (guess_partial_die_structure_name): Likewise.
5967 (partial_die_info::fixup): Likewise.
5968
33d0e35a
TT
59692019-05-17 Tom Tromey <tromey@adacore.com>
5970
5971 * source.c (find_and_open_source): Remove cast.
5972
a45575b0
TT
59732019-05-17 Tom Tromey <tromey@adacore.com>
5974
5975 * annotate.c (annotate_source): Make "filename" const.
5976 * annotate.h (annotate_source): Use const.
5977
81f47ac2
AH
59782019-05-17 Alan Hayward <alan.hayward@arm.com>
5979
5980 * disasm.c (set_disassembler_options): Send errors to stderr.
5981
ca1285d1
AH
59822019-05-17 Alan Hayward <alan.hayward@arm.com>
5983
5984 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5985 (cli_interp_base::set_logging): Check debug_redirect.
5986 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5987 * cli/cli-logging.c (debug_redirect): Add static variable.
5988 (pop_output_files): Add default param.
5989 (handle_redirections): Print debug setting.
5990 (show_logging_command): Likewise.
5991 (_initialize_cli_logging): Add debugredirect command.
5992 * interps.c (current_interp_set_logging): Add debug_redirect
5993 parameter.
5994 * interps.h (set_logging): Add debug_redirect parameter.
5995 (current_interp_set_logging): Likewise.
5996 * mi/mi-common.h: Likewise.
5997 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5998
59992019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
6000 Tom Tromey <tromey@adacore.com>
6001
6002 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6003 directly.
6004 * cli/cli-interp.h (make_logging_output): Remove declaration.
6005 * cli/cli-logging.c (make_logging_output): Remove function.
6006 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6007 directly.
6008 * ui-file.c (tee_file::tee_file): Remove bools.
6009 (tee_file::~tee_file): Remove deletes.
6010 * ui-file.h (tee_file): Remove bools.
6011
26648588
JV
60122019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6013
6014 * mi/mi-cmds.h (mi_cmd_complete): New function.
6015 * mi/mi-main.c (mi_cmd_complete): Likewise.
6016 * mi/mi-cmds.c: Define new MI command -complete.
6017 * NEWS: Mention new -complete command.
6018
6e035501
JV
60192019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6020
6021 * completer.h (complete): New function.
6022 * completer.c (complete): Likewise.
6023 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6024 function defined in completer.h.
6025
7d0e2ece
JV
60262019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6027
e79be6e5 6028 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 6029
fb816e8b
TV
60302019-05-17 Tom de Vries <tdevries@suse.de>
6031
6032 PR gdb/24094
6033 * dwarf2read.c (struct cu_partial_die_info): New struct.
6034 (find_partial_die): Return cu_partial_die_info.
6035 (partial_die_parent_scope, guess_partial_die_structure_name)
6036 (partial_die_info::fixup): Handle new return type of find_partial_die.
6037
677052f2
SDJ
60382019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6039
a1726c38 6040 PR breakpoints/24541
677052f2
SDJ
6041 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6042 "std::string", simplifying the algorithm.
6043
f3da9116
SDJ
60442019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6045
6046 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6047 (stap_static_probe_ops::get_probes): Likewise.
6048
f1bb75ab
SDJ
60492019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6050
6051 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6052 '-')" and "else if".
6053 (stap_parse_single_operand): Join checks for
6054 "gdbarch_stap_parse_special_token_p" and
6055 "gdbarch_stap_parse_special_token" in the same "if" statement.
6056 Invert check when verifying for operation on register
6057 displacement.
6058
3ca58cde
SDJ
60592019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6060
6061 * stap-probe.c (stap_get_opcode): Update comment.
6062 (stap_get_expected_argument_type): Likewise.
6063 (handle_stap_probe): Likewise.
6064
af2d9bee
SDJ
60652019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6066
6067 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6068 return type to 'bool'. Adjust comment. Use 'bool' when
6069 appropriate.
6070 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6071 * stap-probe.c (stap_parse_argument_1): Likewise.
6072 (stap_is_operator): Likewise.
6073 (stap_is_generic_prefix): Likewise.
6074 (stap_is_register_prefix): Likewise.
6075 (stap_is_register_indirection_prefix): Likewise.
6076 (stap_is_integer_prefix): Likewise.
6077 (stap_generic_check_suffix): Likewise.
6078 (stap_check_integer_suffix): Likewise.
6079 (stap_check_register_suffix): Likewise.
6080 (stap_check_register_indirection_suffix): Likewise.
6081 (stap_parse_register_operand): Likewise.
6082 (stap_parse_single_operand): Likewise.
6083 (stap_parse_argument_1): Likewise.
6084 (stap_probe::get_argument_count): Likewise.
6085 (stap_is_operator): Likewise.
6086
61c9c421
TT
60872019-05-16 Tom Tromey <tromey@adacore.com>
6088
6089 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6090 keyword to foreach.
6091
9ddc1af1
SM
60922019-05-15 Simon Marchi <simon.marchi@efficios.com>
6093
6094 * linux-thread-db.c (try_thread_db_load_1): Change return type
6095 to bool.
6096 (try_thread_db_load): Likewise.
6097 (try_thread_db_load_from_pdir_1): Likewise.
6098 (try_thread_db_load_from_pdir): Likewise.
6099 (try_thread_db_load_from_sdir): Likewise.
6100 (try_thread_db_load_from_dir): Likewise.
6101 (thread_db_load_search): Likewise.
6102 (has_libpthread): Likewise.
6103 (thread_db_load): Likewise.
6104
7bede828
SDJ
61052019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6106
6107 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6108 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6109 NULL, and complain/return if that's the case.
6110
c5358db4
JD
61112019-05-15 John Darrington <john@darrington.wattle.id.au>
6112
6113 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6114 (advance, posn, abstract_read_memory): New functions.
6115 [struct mem_read_abstraction]: New struct.
6116 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6117
c408a94f
TT
61182019-05-14 Tom Tromey <tromey@adacore.com>
6119
6120 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6121 value is not lval_memory.
6122
e7bd7fba
TT
61232019-05-14 Tom Tromey <tromey@adacore.com>
6124
6125 * solib.c (info_sharedlibrary_command): Style the file name.
6126
a6d0f249
AH
61272019-05-14 Alan Hayward <alan.hayward@arm.com>
6128
6129 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6130 (aarch64_vnv_type): Likewise.
6131 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6132 * common/tdesc.c: Likewise.
6133 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6134 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6135 * features/aarch64-fpu.xml: Add ieee half view.
6136 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6137 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6138 * gdbtypes.h (struct builtin_type): Likewise.
6139 (struct objfile_type): Likewise.
6140
66b8bb74
SM
61412019-05-12 Paul Naert <paul.naert@polymtl.ca>
6142
6143 * language.c (language_sniff_from_mangled_name): Fix "langauge"
6144 typo.
6145 * location.h (string_to_event_location): Likewise.
6146
21c219fd
JB
61472019-05-11 Joel Brobecker <brobecker@adacore.com>
6148
6149 GDB 8.3 released.
6150
13674803
SM
61512019-05-10 Simon Marchi <simon.marchi@efficios.com>
6152
6153 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6154 New variable declaration.
6155 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6156 New variable.
6157 (print_one_breakpoint): Use ui_out::test_flags and new global
6158 variable to compute use_fixed_output.
6159 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6160 Remove.
6161 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6162 (mi_multi_location_breakpoint_output_fixed): Remove.
6163 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6164 new variable.
6165 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6166 fix_multi_location_breakpoint_output flag if version >= 3.
6167 * ui-out.h (enum ui_out_flag)
6168 <fix_multi_location_breakpoint_output>: New enumerator.
6169
a9eac7f9
SM
61702019-05-10 Simon Marchi <simon.marchi@efficios.com>
6171
6172 * contrib/cc-with-tweaks.sh: Validate dwz's work.
6173
71bed2db
TT
61742019-05-10 Tom Tromey <tromey@adacore.com>
6175
6176 * ada-lang.c (catch_ada_completer): New function.
6177 (_initialize_ada_language): Use it.
6178
24c54127
TT
61792019-05-10 Tom Tromey <tromey@adacore.com>
6180
6181 * thread.c (print_thread_info): Make "requested_threads" const.
6182 * gdbthread.h (print_thread_info): Make "requested_threads"
6183 const.
6184 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6185 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6186
7a102139
TT
61872019-05-08 Tom Tromey <tom@tromey.com>
6188
6189 * gdbtypes.c (objfile_type_data): Change type.
6190 (objfile_type, _initialize_gdbtypes): Update.
6191
924d79e2
TT
61922019-05-08 Tom Tromey <tom@tromey.com>
6193
6194 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6195 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6196 (_initialize_dwarf2_frame): Update.
6197
4c58e337
TT
61982019-05-08 Tom Tromey <tom@tromey.com>
6199
6200 * objc-lang.c (objc_objfile_data): Change type.
6201 (find_methods): Update.
6202 (_initialize_objc_lang): Remove.
6203
d772d2ab
TT
62042019-05-08 Tom Tromey <tom@tromey.com>
6205
6206 * stabsread.c (rs6000_builtin_type_data): Change type.
6207 (rs6000_builtin_type, _initialize_stabsread): Update.
6208
d11d83f4
TT
62092019-05-08 Tom Tromey <tom@tromey.com>
6210
6211 * mips-tdep.c (mips_pdr_data): Remove.
6212 (_initialize_mips_tdep): Update.
6213
9a73f0ad
TT
62142019-05-08 Tom Tromey <tom@tromey.com>
6215
6216 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6217 (hppa_init_objfile_priv_data, read_unwind_info)
6218 (find_unwind_entry, _initialize_hppa_tdep): Update.
6219
8127a2fa
TT
62202019-05-08 Tom Tromey <tom@tromey.com>
6221
6222 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6223 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
6224 on obstack.
6225 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6226
91d3055d
TT
62272019-05-08 Tom Tromey <tom@tromey.com>
6228
6229 * mdebugread.c (basic_type_data): Change type.
6230 (basic_type, _initialize_mdebugread): Update.
6231
31930bd3
TT
62322019-05-08 Tom Tromey <tom@tromey.com>
6233
6234 * common/gdb_unique_ptr.h (struct noop_deleter): New.
6235
bdb3ed9e
TT
62362019-05-08 Tom Tromey <tom@tromey.com>
6237
6238 * nto-tdep.c (nto_inferior_data_reg): Change type.
6239 (nto_inferior_data): Update.
6240 (nto_inferior_data_cleanup, nto_new_inferior_data)
6241 (_initialize_nto_tdep): Remove.
6242 * nto-tdep.h (struct nto_inferior_data): Add initializers.
6243
f37b313d
TT
62442019-05-08 Tom Tromey <tom@tromey.com>
6245
6246 * ada-lang.c (struct ada_inferior_data): Add initializers.
6247 (ada_inferior_data): Change type.
6248 (ada_inferior_data_cleanup): Remove.
6249 (get_ada_inferior_data, ada_inferior_exit)
6250 (struct ada_pspace_data): Add initializers, destructor.
6251 (ada_pspace_data_handle): Change type.
6252 (get_ada_pspace_data): Update.
6253 (ada_pspace_data_cleanup): Remove.
6254
24699405
TT
62552019-05-08 Tom Tromey <tom@tromey.com>
6256
6257 * coffread.c (struct coff_symfile_info): Add initializers.
6258 (coff_objfile_data_key): Move lower. Change type.
6259 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6260 Update.
6261 (coff_free_info): Remove.
6262
d4e05d2f
TT
62632019-05-08 Tom Tromey <tom@tromey.com>
6264
6265 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6266 (fbsd_pspace_data_handle): Move lower. Change type.
6267 (get_fbsd_pspace_data): Update.
6268 (fbsd_pspace_data_cleanup): Remove.
6269 (_initialize_fbsd_tdep): Update.
6270
14ef6690
TT
62712019-05-08 Tom Tromey <tom@tromey.com>
6272
6273 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6274 (get_ada_tasks_pspace_data): Update.
6275 (ada_tasks_pspace_data_cleanup): Remove.
6276 (_initialize_tasks): Update.
6277 (ada_tasks_inferior_data_handle): Change type.
6278 (get_ada_tasks_inferior_data): Update.
6279 (ada_tasks_inferior_data_cleanup): Remove.
6280 (struct ada_tasks_pspace_data): Add initializers.
6281
814cf43a
TT
62822019-05-08 Tom Tromey <tom@tromey.com>
6283
6284 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6285 * symfile-debug.c (debug_sym_get_probes): Change type.
6286 * stap-probe.c (handle_stap_probe):
6287 (stap_static_probe_ops::get_probes): Change type.
6288 * probe.h (class static_probe_ops) <get_probes>: Change type.
6289 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6290 (parse_probes_in_pspace): Update.
6291 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6292 Update.
6293 (any_static_probe_ops::get_probes): Change type.
6294 * elfread.c (elfread_data): New typedef.
6295 (probe_key): Change type.
6296 (elf_get_probes): Likewise. Update.
6297 (probe_key_free): Remove.
6298 (_initialize_elfread): Update.
6299 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6300 Change type.
6301 (dtrace_process_dof_probe, dtrace_process_dof)
6302 (dtrace_static_probe_ops::get_probe): Change type.
6303
02dc647e
TT
63042019-05-08 Tom Tromey <tom@tromey.com>
6305
6306 * xcoffread.c (struct xcoff_symfile_info): Rename from
6307 coff_symfile_info. Add initializers.
6308 (xcoff_objfile_data_key): Move lower. Change type.
6309 (XCOFF_DATA): Rewrite.
6310 (xcoff_free_info): Remove.
6311 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6312 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6313 (xcoff_initial_scan): Update.
6314
09232438
TT
63152019-05-08 Tom Tromey <tom@tromey.com>
6316
6317 * solib-svr4.c (struct svr4_info): Add initializers and
6318 destructor.
6319 <probes_table>: Now an htab_up.
6320 (solib_svr4_pspace_data): Change type.
6321 (free_probes_table): Simplify.
6322 (~svr4_info): Rename from svr4_pspace_data_cleanup.
6323 (get_svr4_info, probes_table_htab_remove_objfile_probes)
6324 (probes_table_remove_objfile_probes, register_solib_event_probe)
6325 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6326 (_initialize_svr4_solib): Update.
6327
7b4a314f
TT
63282019-05-08 Tom Tromey <tom@tromey.com>
6329
6330 * remote.c (remote_pspace_data): Change type.
6331 (remote_pspace_data_cleanup): Remove.
6332 (get_remote_exec_file, set_pspace_remote_exec_file)
6333 (_initialize_remote): Update.
6334
51d3063a
TT
63352019-05-08 Tom Tromey <tom@tromey.com>
6336
6337 * breakpoint.c (breakpoint_objfile_key): Change type.
6338 (get_breakpoint_objfile_data): Update.
6339 (free_breakpoint_objfile_data): Remove.
6340 (_initialize_breakpoint): Update.
6341
89fb8848
TT
63422019-05-08 Tom Tromey <tom@tromey.com>
6343
6344 * linux-tdep.c (struct linux_info): Add initializers.
6345 (linux_inferior_data): Move. Change type.
6346 (invalidate_linux_cache_inf): Update.
6347 (linux_inferior_data_cleanup): Remove.
6348 (get_linux_inferior_data, _initialize_linux_tdep): Update.
6349
e9b89e2d
TT
63502019-05-08 Tom Tromey <tom@tromey.com>
6351
6352 * auxv.c (auxv_inferior_data): Move. Change type.
6353 (auxv_inferior_data_cleanup): Remove.
6354 (invalidate_auxv_cache_inf): Rewrite.
6355 (get_auxv_inferior_data, _initialize_auxv): Update.
6356
8c42777c
TT
63572019-05-08 Tom Tromey <tom@tromey.com>
6358
6359 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6360 (symfile_debug_objfile_data_key): Change type.
6361 (symfile_debug_installed, debug_qf_has_symbols)
6362 (debug_qf_find_last_source_symtab)
6363 (debug_qf_forget_cached_source_info)
6364 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6365 (debug_qf_print_stats, debug_qf_dump)
6366 (debug_qf_expand_symtabs_for_function)
6367 (debug_qf_expand_all_symtabs)
6368 (debug_qf_expand_symtabs_with_fullname)
6369 (debug_qf_map_matching_symbols)
6370 (debug_qf_expand_symtabs_matching)
6371 (debug_qf_find_pc_sect_compunit_symtab)
6372 (debug_qf_map_symbol_filenames)
6373 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6374 (debug_sym_new_init, debug_sym_init, debug_sym_read)
6375 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6376 (debug_sym_read_linetable, debug_sym_relocate): Update.
6377 (symfile_debug_free_objfile): Remove.
6378 (install_symfile_debug_logging, _initialize_symfile_debug):
6379 Update.
6380
5bfd760d
TT
63812019-05-08 Tom Tromey <tom@tromey.com>
6382
6383 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6384 allocate_on_obstack.
6385 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6386 (get_dwarf2_per_objfile): Update.
6387 (set_dwarf2_per_objfile): Remove.
6388 (dwarf2_has_info, dwarf2_get_section_info): Update.
6389 (dwarf2_free_objfile): Remove.
6390 (_initialize_dwarf2_read): Update.
6391
e85e19b4
TT
63922019-05-08 Tom Tromey <tom@tromey.com>
6393
6394 * auto-load.c (struct auto_load_pspace_info): Add destructor and
6395 initializers.
6396 <unsupported_script_warning_printed,
6397 script_not_found_warning_printed>: Now bool.
6398 (auto_load_pspace_data): Change type.
6399 (~auto_load_pspace_info): Rename from
6400 auto_load_pspace_data_cleanup.
6401 (get_auto_load_pspace_data, init_loaded_scripts_info)
6402 (clear_section_scripts, maybe_print_unsupported_script_warning)
6403 (maybe_print_script_not_found_warning, _initialize_auto_load):
6404 Update.
6405
f6aa7436
TT
64062019-05-08 Tom Tromey <tom@tromey.com>
6407
6408 * objfiles.c (objfile_pspace_info): Add destructor and
6409 initializers.
6410 (objfiles_pspace_data): Change type.
6411 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6412 (get_objfile_pspace_data): Update.
6413 (objfiles_bfd_data): Change type.
6414 (get_objfile_bfd_data): Update.
6415 (objfile_bfd_data_free, _initialize_objfiles): Remove.
6416
6ae614f6
TT
64172019-05-08 Tom Tromey <tom@tromey.com>
6418
6419 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6420 Change type.
6421 (get_catch_syscall_inferior_data): Update.
6422 (catch_syscall_inferior_data_cleanup): Remove.
6423 (_initialize_break_catch_syscall): Update.
6424
6509b8eb
TT
64252019-05-08 Tom Tromey <tom@tromey.com>
6426
6427 * inflow.c (struct terminal_info): Add destructor and
6428 initializers.
6429 (inflow_inferior_data): Change type.
6430 (~terminal_info): Rename from inflow_inferior_data_cleanup.
6431 (get_inflow_inferior_data, inflow_inferior_exit)
6432 (swap_terminal_info, _initialize_inflow): Update.
6433
35632941
TT
64342019-05-08 Tom Tromey <tom@tromey.com>
6435
6436 * target-dcache.c (target_dcache_cleanup): Remove.
6437 (target_dcache_aspace_key): Change type.
6438 (target_dcache_init_p, target_dcache_invalidate)
6439 (target_dcache_get, target_dcache_get_or_init)
6440 (_initialize_target_dcache): Update.
6441 * dcache.h (struct dcache_deleter): New.
6442
3017b94d
TT
64432019-05-08 Tom Tromey <tom@tromey.com>
6444
6445 * symtab.c (struct symbol_cache): Add destructor and
6446 initializers.
6447 (symbol_cache_key): Move. Change type.
6448 (make_symbol_cache, free_symbol_cache): Remove.
6449 (get_symbol_cache): Update.
6450 (symbol_cache_cleanup): Remove.
6451 (ALL_PSPACES, symbol_cache_flush)
6452 (maintenance_print_symbol_cache)
6453 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6454 Update.
6455
a32ad8c5
TT
64562019-05-08 Tom Tromey <tom@tromey.com>
6457
6458 * symtab.c (struct main_info): Add destructor and initializers.
6459 (main_progspace_key): Move. Change type.
6460 (get_main_info): Update.
6461 (main_info_cleanup): Remove.
6462 (_initialize_symtab): Update.
6463
5f6e90a0
TT
64642019-05-08 Tom Tromey <tom@tromey.com>
6465
6466 * registry.h (DECLARE_REGISTRY): Define the _key class.
6467
1bd0c6e4
AB
64682019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
6469
6470 * NEWS: Merge two 'New commands' sections.
6471
2228ef77
XR
64722019-05-08 Joel Brobecker <brobecker@adacore.com>
6473
6474 * ada-valprint.c (ada_val_print_gnat_array): Remove language
6475 parameter and use Ada language definition instead.
6476 (ada_val_print_ptr): Remove unused language parameter.
6477 (ada_val_print_num): Remove language parameter and use Ada language
6478 definition instead.
6479 (ada_val_print_enum, ada_val_print_flt): Remove unused language
6480 parameter.
6481 (ada_val_print_struct_union, ada_val_print_ref): Remove language
6482 parameter and use Ada language definition instead.
6483 (ada_val_print_1): Update all ada_val_print_xxx calls.
6484 Remove language parameter.
6485 (ada_val_print): Update ada_val_print_1 call.
6486
60fcc1c3
TT
64872019-05-08 Tom Tromey <tromey@adacore.com>
6488
6489 * remote.c (remote_hw_watchpoint_limit)
6490 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6491 Now static.
6492
ed2b7c17
TT
64932019-05-08 Tom Tromey <tromey@adacore.com>
6494
6495 * maint.c (_initialize_maint_cmds): Move initialization code to
6496 remote.c.
6497 (watchdog, show_watchdog): Move to remote.c.
6498 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
6499 "watchdog" static.
6500 (_initialize_remote): Move initialization code from maint.c.
6501 * defs.h (watchdog): Don't declare.
6502
b0be6c91
TT
65032019-05-08 Tom Tromey <tromey@adacore.com>
6504
6505 * tui/tui-interp.c: Include main.h.
6506 * interps.c: Include main.h.
6507 * main.h (interpreter_p): Declare.
6508 * defs.h (interpreter_p): Don't declare.
6509
587ee17b
TT
65102019-05-08 Tom Tromey <tromey@adacore.com>
6511
6512 * dwarf2loc.c: Include dwarf2read.h.
6513 * defs.h (read_unsigned_leb128): Don't declare.
6514 * dwarf2read.h (read_unsigned_leb128): Declare.
6515
ca1df239
TT
65162019-05-08 Tom Tromey <tromey@adacore.com>
6517
6518 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6519 method.
6520
99f20f08
TT
65212019-05-08 Tom Tromey <tromey@adacore.com>
6522
6523 * utils.c (fputs_maybe_filtered): Reset style after paging, even
6524 when no wrap column is set.
6525
80e55b13
TT
65262019-05-08 Tom Tromey <tromey@adacore.com>
6527
6528 * c-lang.c (c_get_string): Handle non-C-style arrays.
6529
9d3421af
TT
65302019-05-08 Tom Tromey <tromey@adacore.com>
6531
6532 * typeprint.c (print_offset_data::update): Print the bit offset,
6533 not the number of bits remaining.
6534
844333e2
TT
65352019-05-08 Tom Tromey <tromey@adacore.com>
6536
6537 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6538 padding at end of comment.
6539
988915ee
TT
65402019-05-08 Tom Tromey <tromey@adacore.com>
6541
6542 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6543 Compare main types.
6544
26bfd823
TT
65452019-05-06 Tom Tromey <tom@tromey.com>
6546
6547 * common/scoped_mmap.c: Include common-defs.h.
6548 * common/scoped_mmap.h: Don't include config.h.
6549
89055eaa
TT
65502019-05-04 Tom Tromey <tom@tromey.com>
6551
6552 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6553 (struct aarch64_call_info): Add initializers.
6554 <si>: Now a std::vector.
6555 (pass_on_stack, aarch64_push_dummy_call): Update.
6556
5da01df5
TT
65572019-05-04 Simon Marchi <simon.marchi@efficios.com>
6558 Tom Tromey <tom@tromey.com>
6559
6560 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6561 (ppc_threads): Now a std::vector. Now static.
6562 (hwdebug_find_thread_points_by_tid)
6563 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6564 Update.
6565
fbdf05a1
TT
65662019-05-04 Tom Tromey <tom@tromey.com>
6567
6568 * arc-tdep.c (arc_tdesc_init): Return bool.
6569
06d16ec9
TT
65702019-05-04 Tom Tromey <tom@tromey.com>
6571
6572 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6573 Use gdb_assert_not_reached.
6574
9c056022
TT
65752019-05-04 Tom Tromey <tom@tromey.com>
6576
6577 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6578 "false".
6579
fa9c2a59
TT
65802019-05-04 Tom Tromey <tom@tromey.com>
6581
6582 * arc-tdep.c (arc_tdesc_init): Use bool.
6583
e2eb806a
TT
65842019-05-04 Tom Tromey <tom@tromey.com>
6585
6586 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6587
6fe87677
TT
65882019-05-04 Tom Tromey <tom@tromey.com>
6589
6590 * cli/cli-cmds.c (valid_command_p): Return bool.
6591
7f008c9e
TT
65922019-05-04 Tom Tromey <tom@tromey.com>
6593
6594 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6595 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6596
b6484282
RT
65972019-05-04 Raul Tambre <raul@tambre.ee>
6598
6599 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6600 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6601 operator for comparison.
6602
af97b416
TT
66032019-05-04 Tom Tromey <tom@tromey.com>
6604
6605 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6606 (lookup_partial_symbol, print_partial_symbols)
6607 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6608 (psymbol_compare): Update.
6609 (add_psymbol_to_bcache): Clear the entire psymbol.
6610 (maintenance_check_psymtabs): Update.
6611 * psympriv.h (struct partial_symbol): Don't derive from
6612 general_symbol_info.
6613 <obj_section, unrelocated_address, address,
6614 set_unrelocated_address>: Update.
6615 <ginfo>: New member.
6616 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6617 (debug_names::write_psymbols): Update.
6618
9d6d4be8
TV
66192019-05-04 Tom de Vries <tdevries@suse.de>
6620
6621 * contrib/cc-with-tweaks.sh: Support -n arg.
6622
66452beb
PW
66232019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6624
6625 * corelow.c (core_target::detach): Ensure frame cache and
6626 register caches are cleared.
6627 inferior.c (exit_inferior_1): Likewise.
6628
bde09ab7
TT
66292019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6630 Tom Tromey <tom@tromey.com>
6631
6632 * dictionary.c (collate_pending_symbols_by_language): Remove
6633 "struct" from foreach.
6634 * symtab.c (lookup_global_symbol_from_objfile)
6635 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6636 foreach.
6637 * ser-tcp.c (net_open): Remove "struct" from foreach.
6638 * objfiles.c (objfile_relocate, objfile_rebase)
6639 (objfile_has_symbols): Remove "struct" from foreach.
6640 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6641 from foreach.
6642 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6643 foreach.
6644 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6645 "struct" from foreach.
6646 * ada-lang.c (create_excep_cond_exprs)
6647 (ada_exception_catchpoint_cond_string): Remove "struct" from
6648 foreach.
6649
222a8d25
TT
66502019-05-03 Tom Tromey <tromey@adacore.com>
6651
6652 * ada-exp.y (convert_char_literal): Check suffix of each
6653 enumerator.
6654
fcd60b84
DP
66552019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6656
6657 PR ada/21406:
6658 * ada-exp.y (yywrap): Don't define.
6659 * ada-lex.l (%option): Add noyywrap
6660 (yywrap): Remove.
6661
5f2459c2
EZ
66622019-05-03 Eli Zaretskii <eliz@gnu.org>
6663
353ea2d1
EZ
6664 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6665 _WIN32_WINNT to the XP level, unless already defined to a higher
6666 level.
6667
6668 * unittests/parse-connection-spec-selftests.c:
6669 * ser-tcp.c:
6670 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6671 override.
6672
5f2459c2
EZ
6673 * symfile.c (find_separate_debug_file): Remove colon from the
6674 drive spec of DOS/Windows file names of the target, so that the
6675 file name produced from DEBUGDIR and the target's directory will
6676 be valid on DOS/Windows systems.
6677
80062eb9
AB
66782019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6679
6680 * rust-lang.c (val_print_struct): Handle printing structures
6681 containing strings.
6682
b8c05e85
TT
66832019-05-02 Tom Tromey <tromey@adacore.com>
6684
6685 * valarith.c (_initialize_valarith): Remove.
6686
4504bbde
TT
66872019-05-01 Tom Tromey <tromey@adacore.com>
6688
6689 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6690 bitfields.
6691
d48e62f4
TT
66922019-05-01 Tom Tromey <tromey@adacore.com>
6693
6694 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6695 for big-endian copies.
6696
15f18d14
AT
66972019-04-30 Ali Tamur <tamur@google.com>
6698 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6699 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6700 (read_3_bytes): New function.
6701
ab4ee614
JB
67022019-04-30 Joel Brobecker <brobecker@adacore.com>
6703
6704 * windows-nat.c (main_thread_id): Delete.
6705 (handle_output_debug_string): Replace main_thread_id by
6706 current_event.dwThreadId.
6707 (fake_create_process): Likewise.
6708 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6709 Do not set main_thread_id.
6710 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6711 current_event.dwThreadId.
6712 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6713
8ed5b76e
JB
67142019-04-30 Joel Brobecker <brobecker@adacore.com>
6715
6716 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6717 Use current_event.dwThreadId instead of main_thread_id.
6718
2ff0a947
TT
67192019-04-30 Tom Tromey <tromey@adacore.com>
6720
6721 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6722 (create_excep_cond_exprs): Iterate over program spaces.
6723 (ada_exception_catchpoint_cond_string): Examine all minimal
6724 symbols for exception types.
6725
a776957c
TT
67262019-04-30 Tom Tromey <tromey@adacore.com>
6727
6728 PR c++/24470:
6729 * dwarf2read.c (process_structure_scope): Handle case where type
6730 has template parameters but no symbol was created.
6731
bc68014d
AB
67322019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6733 Chris January <chris.january@arm.com>
6734
6735 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6736 qualifier.
6737 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6738
f1fdc960
AB
67392019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6740
6741 * f-typeprint.c (f_print_type): Update rules for printing
6742 whitespace.
6743 (f_type_print_varspec_suffix): Likewise.
6744
bf7a4de1
AB
67452019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6746 Chris January <chris.january@arm.com>
6747
6748 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6749 function arguments.
6750
bbe75b9d
AB
67512019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6752
6753 * f-lang.c (build_fortran_types): Change name of void type to
6754 lower case.
6755 * f-typeprint.c (f_type_print_base): Print the name of the void
6756 type, rather than a fixed string.
6757 * f-valprint.c (f_decorations): Use lower case void string.
6758
1db455a7
AB
67592019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6760 Chris January <chris.january@arm.com>
6761
6762 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6763 types for Fortran.
6764
b6d03bb2
AB
67652019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6766 Chris January <chris.january@arm.com>
6767 David Lecomber <david.lecomber@arm.com>
6768
6769 * f-exp.y (BINOP_INTRINSIC): New token.
6770 (exp): New parser rule handling BINOP_INTRINSIC.
6771 (f77_keywords): Add new builtin procedures.
6772 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6773 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6774 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6775 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6776 (print_unop_subexp_f): New function.
6777 (print_binop_subexp_f): New function.
6778 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6779 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6780 (dump_subexp_body_f): Likewise.
6781 (operator_check_f): Likewise.
6782 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6783 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6784
83228e93
AB
67852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6786
6787 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6788 UNOP_KIND.
6789 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6790 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6791 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6792 (operator_length_f): New fuction.
6793 (print_subexp_f): New function.
6794 (op_name_f): New function.
6795 (dump_subexp_body_f): New function.
6796 (operator_check_f): New function.
6797 (exp_descriptor_f): Replace standard expression handling functions
6798 with new functions.
6799 * gdb/fortran-operator.def: New file.
6800 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6801 * gdb/std-operator.def: Remove UNOP_KIND.
6802
6fdcd7cc
AB
68032019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6804
6805 * std-operator.def: Remove unbalanced, stray double quote
6806 character.
6807
2e62ab40
AB
68082019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6809 Chris January <chris.january@arm.com>
6810 Daniel Everett <daniel.everett@arm.com>
6811 Nick Forrington <nick.forrington@arm.com>
6812 Richard Bunt <richard.bunt@arm.com>
6813
6814 * cp-valprint.c (cp_print_value_fields): Allow an additional level
6815 of depth when printing anonymous structs or unions.
6816 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6817 Don't print either the top-level value, or the children if the
6818 max-depth is exceeded.
6819 (ppscm_print_children): When printing the key of a map, allow one
6820 extra level of depth.
6821 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6822 print either the top-level value, or the children if the max-depth
6823 is exceeded.
6824 (print_children): When printing the key of a map, allow one extra
6825 level of depth.
6826 * python/py-value.c (valpy_format_string): Add max_depth keyword.
6827 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6828 (user_print_options): Initialise max_depth field.
6829 (val_print_scalar_or_string_type_p): New function.
6830 (val_print): Check to see if the max depth has been reached.
6831 (val_print_check_max_depth): Define new function.
6832 (show_print_max_depth): New function.
6833 (_initialize_valprint): Add 'print max-depth' option.
6834 * valprint.h (struct value_print_options) <max_depth>: New field.
6835 (val_print_check_max_depth): Declare new function.
6836 * NEWS: Document new feature.
6837
4be290b2
AB
68382019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6839
6840 * ada-lang.c (ada_language_defn): Initialise new field.
6841 * c-lang.c (c_is_string_type_p): New function.
6842 (c_language_defn): Initialise new field.
6843 (cplus_language_defn): Initialise new field.
6844 (asm_language_defn): Initialise new field.
6845 (minimal_language_defn): Initialise new field.
6846 * c-lang.h (c_is_string_type_p): Declare new function.
6847 * d-lang.c (d_language_defn): Initialise new field.
6848 * f-lang.c (f_is_string_type_p): New function.
6849 (f_language_defn): Initialise new field.
6850 * go-lang.c (go_is_string_type_p): New function.
6851 (go_language_defn): Initialise new field.
6852 * language.c (default_is_string_type_p): New function.
6853 (unknown_language_defn): Initialise new field.
6854 (auto_language_defn): Initialise new field.
6855 * language.h (struct language_defn) <la_is_string_type_p>: New
6856 member variable.
6857 (default_is_string_type_p): Declare new function.
6858 * m2-lang.c (m2_language_defn): Initialise new field.
6859 * objc-lang.c (objc_language_defn): Initialise new field.
6860 * opencl-lang.c (opencl_language_defn): Initialise new field.
6861 * p-lang.c (pascal_is_string_type_p): New function.
6862 (pascal_language_defn): Initialise new field.
6863 * rust-lang.c (rust_is_string_type_p): New function.
6864 (rust_language_defn): Initialise new field.
6865
721b08c6
AB
68662019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6867
6868 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6869 New field.
6870 * ada-lang.c (ada_language_defn): Initialise new field.
6871 * c-lang.c (c_language_defn): Likewise.
6872 (cplus_language_defn): Likewise.
6873 (asm_language_defn): Likewise.
6874 (minimal_language_defn): Likewise.
6875 * d-lang.c (d_language_defn): Likewise.
6876 * f-lang.c (f_language_defn): Likewise.
6877 * go-lang.c (go_language_defn): Likewise.
6878 * language.c (unknown_language_defn): Likewise.
6879 (auto_language_defn): Likewise.
6880 * m2-lang.c (m2_language_defn): Likewise.
6881 * objc-lang.c (objc_language_defn): Likewise.
6882 * opencl-lang.c (opencl_language_defn): Likewise.
6883 * p-lang.c (pascal_language_defn): Likewise.
6884 * rust-lang.c (rust_language_defn): Likewise.
6885
fc913e53
AB
68862019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6887
6888 * ada-lang.c (ada_is_character_type): Change return type to bool.
6889 (ada_is_string_type): Likewise.
6890 * ada-lang.h (ada_is_character_type): Update declaration
6891 (ada_is_string_type): Likewise.
6892
fa731fa0
PW
68932019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6894
6895 Support style in 'frame|thread apply'
6896
6897 * gdbcmd.h (execute_command_to_string): New term_out parameter.
6898 * record.c (record_start, record_stop): Update callers of
6899 execute_command_to_string with false.
6900 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6901 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6902 methods.
6903 (class string_file): New constructor with term_out parameter.
6904 Override methods term_out and can_emit_style_escape. New member
6905 term_out.
6906 (class stdio_file): Override can_emit_style_escape.
6907 (class tee_file): Override term_out and can_emit_style_escape.
6908 * utils.h (can_emit_style_escape): Remove.
6909 * utils.c (can_emit_style_escape): Likewise.
6910 Update all callers of can_emit_style_escape (SOMESTREAM) to
6911 SOMESTREAM->can_emit_style_escape.
6912 * source-cache.c (source_cache::get_source_lines): Likewise.
6913 * stack.c (frame_apply_command_count): Call execute_command_to_string
6914 passing the term_out characteristic of the current gdb_stdout.
6915 * thread.c (thr_try_catch_cmd): Likewise.
6916 * top.c (execute_command_to_string): pass term_out parameter
6917 to construct the string_file for the command output.
6918 * ui-file.c (term_cli_styling): New function (most code moved
6919 from utils.c can_emit_style_escape).
6920 (string_file::string_file, string_file::can_emit_style_escape,
6921 stdio_file::can_emit_style_escape, tee_file::term_out,
6922 tee_file::can_emit_style_escape): New functions.
6923
136afab8
PW
69242019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6925
6926 * NEWS: Mention the new set|show may-call-functions.
6927 * infcall.c (may_call_functions_p): New variable.
6928 (show_may_call_functions_p): New function.
6929 (call_function_by_hand_dummy): Throws an error if not
6930 may-call-functions.
6931 (_initialize_infcall): Call add_setshow_boolean_cmd for
6932 may-call-functions.
6933
725cbb63
KS
69342019-04-25 Keith Seitz <keiths@redhat.com>
6935
6936 PR c++/24367
6937 * cp-support.c (inspect_type): Don't attempt substitutions
6938 of symbol with the same name.
6939
3d1cbb78
TT
69402019-04-25 Tom Tromey <tromey@adacore.com>
6941
6942 PR gdb/24475:
6943 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6944 static.
6945
94aeb44b
TT
69462019-04-25 Tom Tromey <tromey@adacore.com>
6947
6948 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6949 rvalue reference.
6950 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6951 (gdb_xml_parser::parse): Use std::move.
6952 * python/python-internal.h (gdbpy_convert_exception): Take a const
6953 reference.
6954 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6955 std::move.
6956 * python/py-utils.c (gdbpy_convert_exception): Take a const
6957 reference.
6958 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6959 Use std::move.
6960 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6961 Use std::move.
6962 * mi/mi-main.c (mi_print_exception): Take a const reference.
6963 * main.c (handle_command_errors): Take a const reference.
6964 * linespec.c (parse_linespec): Use std::move.
6965 * infcall.c (run_inferior_call): Use std::move.
6966 (call_function_by_hand_dummy): Use std::move.
6967 * exec.c (try_open_exec_file): Use std::move.
6968 * exceptions.h (exception_print, exception_fprintf)
6969 (exception_print_same): Update.
6970 * exceptions.c (print_exception, exception_print)
6971 (exception_fprintf, exception_print_same): Change parameters to
6972 const reference.
6973 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6974 * common/new-op.c: Use std::move.
6975 * common/common-exceptions.h (struct gdb_exception): Add move
6976 constructor.
6977 (struct gdb_exception_error, struct gdb_exception_quit, struct
6978 gdb_quit_bad_alloc): Change constructor to move constructor.
6979 (throw_exception): Change parameter to rvalue reference.
6980 * common/common-exceptions.c (throw_exception): Take rvalue
6981 reference.
6982 * cli/cli-interp.c (safe_execute_command): Use std::move.
6983 * breakpoint.c (insert_bp_location, location_to_sals): Use
6984 std::move.
6985
680d7fd5
TT
69862019-04-25 Tom Tromey <tromey@adacore.com>
6987
6988 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6989 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6990 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6991 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6992 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6993 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6994 guile/scm-value.c: Use unpack.
6995 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6996 gdbscm_gdb_exception.
6997 (gdbscm_throw_gdb_exception): Likewise.
6998 (struct gdbscm_gdb_exception): New.
6999 (unpack): New function.
7000 (gdbscm_wrap): Use unpack.
7001
c6fdd8b2
TT
70022019-04-25 Tom Tromey <tromey@adacore.com>
7003
7004 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7005 (gdb_rl_callback_handler): Use std::move.
7006 * common/common-exceptions.h (struct gdb_exception): Add move
7007 assignment operator.
7008 (throw_exception_sjlj): Change "exception" to const reference.
7009 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7010 (throw_exception_sjlj): Change "exception" to const reference.
7011
cc06b668
TT
70122019-04-25 Tom Tromey <tromey@adacore.com>
7013
7014 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7015 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7016 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7017 Update.
7018 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7019 Update.
7020 * mi/mi-interp.c (mi_interp::exec): Update.
7021 * linespec.c (parse_linespec): Update.
7022 * infcall.c (run_inferior_call): Update.
7023 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7024 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7025 (gdbscm_lookup_global_symbol): Update.
7026 * guile/scm-param.c (gdbscm_parameter_value): Update.
7027 * guile/scm-frame.c (gdbscm_frame_read_register)
7028 (gdbscm_frame_read_var): Update.
7029 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7030 * exec.c (try_open_exec_file): Update.
7031 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7032 (gdb_rl_callback_handler): Update.
7033 * common/common-exceptions.h (exception_none): Don't declare.
7034 * common/common-exceptions.c (exception_none): Don't define.
7035 (struct catcher) <exception>: Update.
7036 * cli/cli-interp.c (safe_execute_command): Update.
7037 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7038
cf532bd1
AT
70392019-04-25 Ali Tamur <tamur@google.com>
7040
7041 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7042 (read_attribute_value): Likewise.
7043 (dwarf2_read_addr_index): Update comment.
7044 (read_str_index): Add DW_FORM_strx.
7045 (dwarf2_string_attr): Likewise.
7046 (dwarf2_const_value_attr): Likewise.
7047 (dump_die_shallow): Likewise.
7048 (dwarf2_fetch_constant_bytes): Likewise.
7049 (skip_form_bytes): Likewise.
7050 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7051
82433e3e
SDJ
70522019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7053
7054 PR corefiles/11608
7055 PR corefiles/18187
7056 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7057 OFFSET. Verify if current mapping contains an ELF header.
7058 (linux_find_memory_regions_full): Adjust call to
7059 dump_mapping_p.
7060
723adb65
SL
70612019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7062 Kang Li <kanglictf@gmail.com>
7063
7064 PR gdb/21600
7065
7066 * dwarf2-frame.c (read_initial_length): Be consistent about using
7067 unsigned representation of length.
7068 (decode_frame_entry_1): Likewise. Check for wraparound of
7069 end pointer as well as buffer overflow.
7070
596179f7
SDJ
70712019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7072
7073 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7074 "vq".
7075
a59240a4
TT
70762019-04-24 Tom Tromey <tromey@adacore.com>
7077
7078 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7079
f872fdbb
AB
70802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7081
7082 * s12z-tdep.c (s12z_unwind_pc): Delete.
7083 (s12z_unwind_sp): Delete.
7084 (s12z_gdbarch_init): Don't register deleted functions with
7085 gdbarch.
7086
b614e6f3
AB
70872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7088
7089 * rl78-tdep.c (rl78_unwind_sp): Delete.
7090 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7091
14faed38
AB
70922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7093
7094 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7095 (xstormy16_unwind_pc): Delete.
7096 (xstormy16_dummy_id): Delete.
7097 (xstormy16_gdbarch_init): Don't register deleted functions with
7098 gdbarch.
7099
541aad8a
AB
71002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7101
7102 * vax-tdep.c (vax_unwind_pc): Delete.
7103 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7104
29222070
AB
71052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7106
7107 * v850-tdep.c (v850_unwind_sp): Delete.
7108 (v850_unwind_pc): Delete.
7109 (v850_dummy_id): Delete.
7110 (v850_gdbarch_init): Don't register deleted functions with
7111 gdbarch.
7112
0f534d76
AB
71132019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7114
7115 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7116 (tilegx_unwind_pc): Delete.
7117 (tilegx_unwind_dummy_id): Delete.
7118 (tilegx_gdbarch_init): Don't register deleted functions with
7119 gdbarch.
7120
1ba7b7f9
AB
71212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7122
7123 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7124 (tic6x_dummy_id): Delete.
7125 (tic6x_gdbarch_init): Don't register deleted functions with
7126 gdbarch.
7127
d31f262c
AB
71282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7129
7130 * sparc-tdep.c (sparc_unwind_pc): Delete.
7131 (sparc32_gdbarch_init): Don't register deleted function with
7132 gdbarch.
7133
6d14d64d
AB
71342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7135
7136 * sh-tdep.c (sh_unwind_sp): Delete.
7137 (sh_unwind_pc): Delete.
7138 (sh_dummy_id): Delete.
7139 (sh_gdbarch_init): Don't register deleted functions with
7140 gdbarch.
7141
a40dde9d
AB
71422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7143
7144 * score-tdep.c (score_unwind_sp): Delete.
7145 (score_unwind_pc): Delete.
7146 (score_dummy_id): Delete.
7147 (score_gdbarch_init): Don't register deleted functions with
7148 gdbarch.
7149
47c47d69
AB
71502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7151
7152 * rx-tdep.c (rx_unwind_pc): Delete.
7153 (rx_unwind_sp): Delete.
7154 (rx_dummy_id): Delete.
7155 (rx_gdbarch_init): Don't register deleted functions with
7156 gdbarch. Update comment.
7157
833a4480
AB
71582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7159
7160 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7161 (rs6000_dummy_id): Delete.
7162 (rs6000_gdbarch_init): Don't register deleted functions with
7163 gdbarch.
7164
3f2cef49
AB
71652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7166
7167 * or1k-tdep.c (or1k_dummy_id): Delete.
7168 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7169
96acf884
AB
71702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7171
7172 * nios2-tdep.c (nios2_dummy_id): Delete.
7173 (nios2_unwind_sp): Delete.
7174 (nios2_gdbarch_init): Don't register deleted functions with
7175 gdbarch.
7176
ca0ab0aa
AB
71772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7178
7179 * nds32-tdep.c (nds32_dummy_id): Delete.
7180 (nds32_unwind_pc): Delete.
7181 (nds32_unwind_sp): Delete.
7182 (nds32_gdbarch_init): Don't register deleted functions with
7183 gdbarch.
7184
c8259044
AB
71852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7186
7187 * msp430-tdep.c (msp430_unwind_pc): Delete.
7188 (msp430_unwind_sp): Delete.
7189 (msp430_dummy_id): Delete.
7190 (msp430_gdbarch_init): Don't register deleted functions with
7191 gdbarch.
7192
27f113c8
AB
71932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7194
7195 * moxie-tdep.c (moxie_unwind_sp): Delete.
7196 (moxie_unwind_pc): Delete.
7197 (moxie_dummy_id): Delete.
7198 (moxie_gdbarch_init): Don't register deleted functions with
7199 gdbarch.
7200
aee6c3cd
AB
72012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7202
7203 * mn10300-tdep.c (mn10300_dummy_id): Delete.
7204 (mn10300_unwind_pc): Delete.
7205 (mn10300_unwind_sp): Delete.
7206 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7207 mn10300_unwind_sp.
7208 (mn10300_frame_unwind_init): Don't register deleted functions with
7209 gdbarch.
7210
8e2b5aea
AB
72112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7212
7213 * mep-tdep.c (mep_unwind_pc): Delete.
7214 (mep_unwind_sp): Delete.
7215 (mep_dummy_id): Delete.
7216 (mep_gdbarch_init): Don't register deleted functions with
7217 gdbarch.
7218
43cf3ede
AB
72192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7220
7221 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7222 (m68hc11_unwind_sp): Delete.
7223 (m68hc11_gdbarch_init): Don't register deleted functions with
7224 gdbarch.
7225
5e79b7bb
AB
72262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7227
7228 * m32r-tdep.c (m32r_unwind_sp): Delete.
7229 (m32r_unwind_pc): Delete.
7230 (m32r_dummy_id): Delete.
7231 (m32r_gdbarch_init): Don't register deleted functions with
7232 gdbarch.
7233
89b268d8
AB
72342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7235
7236 * m32c-tdep.c (m32c_unwind_pc): Delete.
7237 (m32c_unwind_sp): Delete.
7238 (m32c_dummy_id): Delete.
7239 (m32c_gdbarch_init): Don't register deleted functions with
7240 gdbarch.
7241
946c28d2
AB
72422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7243
7244 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7245 (lm32_unwind_pc): Delete.
7246 (lm32_dummy_id): Delete.
7247 (lm32_gdbarch_init): Don't register deleted functions with
7248 gdbarch.
7249
bf12844a
AB
72502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7251
7252 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7253 (iq2000_unwind_pc): Delete.
7254 (iq2000_dummy_id): Delete.
7255 (iq2000_gdbarch_init): Don't register deleted functions with
7256 gdbarch.
7257
ecbc06d2
AB
72582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7259
7260 * nds32-tdep.c (nds32_type_align): Delete.
7261 (nds32_push_dummy_call): Use type_align instead.
7262
030197b4
AB
72632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7264
7265 * arm-tdep.c (arm_type_align): Only handle vector override case.
7266 (arm_push_dummy_call): Use type_align.
7267 (arm_gdbarch_init): Register arm_type_align gdbarch function.
7268
b907456c
AB
72692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7270
7271 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7272 case.
7273 (pass_on_stack): Use type_align.
7274 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7275 function.
7276
9e97ba43
TT
72772019-04-23 Tom Tromey <tromey@adacore.com>
7278
7279 * dwarf2read.c (line_header::file_name_at): Remove unused
7280 overload.
7281
6892f601
TV
72822019-04-23 Tom de Vries <tdevries@suse.de>
7283
7284 PR gdb/24438
7285 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7286 invocation.
7287
336d760d
AT
7288
72892019-03-27 Ali Tamur <tamur@google.com>
7290
7291 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7292 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7293 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7294 (dwarf_expr_context::get_addr_index): Likewise
7295 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7296 (symbol_needs_eval_context::get_addr_index): Likewise
7297 (disassemble_dwarf_expression): Add DW_OP_addrx
7298 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7299 (read_cutu_die_from_dwo): Update comment
7300 (skip_one_die): Add DW_FORM_addrx
7301 (read_attribute_value): Likewise
7302 (var_decode_location): Add DW_OP_addrx
7303 (dwarf2_const_value_attr): Add DW_FORM_addrx
7304 (dump_die_shallow): Likewise
7305 (dwarf2_fetch_constant_bytes): Likewise
7306 (decode_locdesc): Add DW_OP_addrx
7307 (skip_form_bytes): Add DW_FORM_addrx
7308
ad9d13f8
AT
73092019-04-22 Ali Tamur <tamur@google.com>
7310
7311 * MAINTAINERS (Write After Approval): Add self.
7312
d70cc3ba
SM
73132019-04-22 Simon Marchi <simon.marchi@efficios.com>
7314
7315 * solib-svr4.c (get_svr4_info): Add pspace parameter.
7316 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7317 (open_symbol_file_object): Likewise.
7318 (svr4_default_sos): Add info parameter.
7319 (svr4_read_so_list): Likewise.
7320 (svr4_current_sos_direct): Adjust functions calls to pass down
7321 info.
7322 (svr4_current_sos_1): Add info parameter.
7323 (svr4_current_sos): Call get_svr4_info, pass info down to
7324 svr4_current_sos_1.
7325 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7326 get_svr4_info.
7327 (svr4_in_dynsym_resolve_code): Pass current_program_space to
7328 get_svr4_info.
7329 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7330 to get_svr4_info.
7331 (probes_table_remove_objfile_probes): Likewise.
7332 (register_solib_event_probe): Add info parameter.
7333 (solist_update_incremental): Pass info parameter down to
7334 svr4_read_so_list.
7335 (disable_probes_interface): Add info parameter.
7336 (svr4_handle_solib_event): Pass current_program_space to
7337 get_svr4_info. Adjust disable_probes_interface cleanup.
7338 (svr4_create_probe_breakpoints): Add info parameter, pass it
7339 down to register_solib_event_probe.
7340 (svr4_create_solib_event_breakpoints): Add info parameter,
7341 pass it down to svr4_create_probe_breakpoints.
7342 (enable_break): Pass info down to
7343 svr4_create_solib_event_breakpoints.
7344 (svr4_solib_create_inferior_hook): Pass current_program_space to
7345 get_svr4_info.
7346 (svr4_clear_solib): Likewise.
7347
7905fc35
PA
73482019-04-22 Pedro Alves <palves@redhat.com>
7349
7350 * solib-svr4.c (svr4_free_objfile_observer): New.
7351 (probe_and_action::objfile): New field.
7352 (probes_table_htab_remove_objfile_probes)
7353 (probes_table_remove_objfile_probes): New functions.
7354 (register_solib_event_probe): Add 'objfile' parameter. Store it
7355 in the new probe_and_action. Don't store the probe in 'lookup'.
7356 (svr4_create_probe_breakpoints): Pass objfile to
7357 register_solib_event_probe.
7358 (_initialize_svr4_solib): Register a free_objfile observer.
7359
fb881986
TT
73602019-04-19 Tom Tromey <tom@tromey.com>
7361
7362 * common/queue.h: Remove.
7363
8732db6c
TT
73642019-04-19 Tom Tromey <tom@tromey.com>
7365
7366 * event-loop.c: Don't include "common/queue.h".
7367
97dfbadd
TT
73682019-04-19 Tom Tromey <tom@tromey.com>
7369
7370 * remote.c (remote_target): Use delete.
7371 * remote-notif.h: Include <list>, not "common/queue.h".
7372 (notif_client_p): Remove typedef.
7373 (remote_notif_state): Add constructor, destructor, initializer.
7374 <notif_queue>: Now a std::list.
7375 (remote_notif_state_xfree): Don't declare.
7376 * remote-notif.c (remote_notif_process, handle_notification)
7377 (remote_notif_state_allocate): Update.
7378 (~remote_notif_state): Rename from remote_notif_state_xfree.
7379
cf250e36
TT
73802019-04-19 Tom Tromey <tom@tromey.com>
7381
7382 * symfile.c (reread_symbols): Update.
7383 * objfiles.c (objfile_register_static_link)
7384 (objfile_lookup_static_link): Update
7385 (~objfile) Don't delete static_links.
7386 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7387
61f4b350
TT
73882019-04-19 Tom Tromey <tom@tromey.com>
7389
7390 * type-stack.h (struct type_stack) <insert>: Constify string.
7391 * type-stack.c (type_stack::insert): Constify string.
7392 * gdbtypes.h (lookup_template_type): Update.
7393 (address_space_name_to_int): Update.
7394 * gdbtypes.c (address_space_name_to_int): Make space_identifier
7395 const.
7396 (lookup_template_type): Make name const.
7397 * c-exp.y: Update rules.
7398 (lex_one_token, classify_name, classify_inner_name)
7399 (c_print_token): Update.
7400 * p-exp.y: Update rules.
7401 (yylex): Update.
7402 * f-exp.y: Update rules.
7403 (yylex): Update.
7404 * d-exp.y: Update rules.
7405 (lex_one_token, classify_name, classify_inner_name): Update.
7406 * parse.c (write_dollar_variable, copy_name): Return std::string.
7407 * parser-defs.h (copy_name): Change return type.
7408 * m2-exp.y: Update rules.
7409 (yylex): Update.
7410 * go-exp.y (lex_one_token): Update.
7411 Update rules.
7412 (classify_unsafe_function, classify_packaged_name)
7413 (classify_name, yylex): Update.
7414
189b8c2e
ST
74152019-04-19 Sergei Trofimovich <siarheit@google.com>
7416
7417 * configure.ac: add --enable-source-highlight switch.
7418 * configure: Regenerate.
7419 * top.c (print_gdb_version): plumb --enable-source-highlight
7420 status to "show configuration".
7421
8ecb59f8
TT
74222019-04-19 Tom Tromey <tromey@adacore.com>
7423
7424 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7425 Check ADA_TYPE_P.
7426 (empty_record, ada_template_to_fixed_record_type_1)
7427 (template_to_static_fixed_type)
7428 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7429 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7430 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7431 macros.
7432
62160ec9
TT
74332019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
7434
7435 PR symtab/24423:
7436 * source.c (print_source_lines_base): Advance "iter" when a
7437 control character is seen.
7438
f2ae8bc8
PW
74392019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7440
7441 * inferior.h (struct infcall_suspend_state_deleter):
7442 Catch exception in destructor to avoid crash.
7443
d563b953
PW
74442019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7445
7446 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7447 close to the add_com "shell".
7448
dc34c897
TT
74492019-04-18 Tom Tromey <tromey@adacore.com>
7450
7451 * process-stratum-target.h (class process_stratum_target)
7452 <stratum>: Add "final".
7453
a12e5744
TT
74542019-04-17 Tom Tromey <tromey@adacore.com>
7455
7456 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7457 against nullptr before use.
7458
a7e559cc
AH
74592019-04-17 Alan Hayward <alan.hayward@arm.com>
7460
7461 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7462
c01660c6
AB
74632019-04-17 Jim Wilson <jimw@sifive.com>
7464 Andrew Burgess <andrew.burgess@embecosm.com>
7465
7466 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7467 code read might fail, assume 4-byte breakpoint in that case.
7468
4aa866af
LS
74692019-04-15 Leszek Swirski <leszeks@google.com>
7470
7471 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7472 rather than a hand-rolled POD check when checking for forced MEMORY
7473 classification.
7474
48574d91
AH
74752019-04-15 Alan Hayward <alan.hayward@arm.com>
7476
7477 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7478 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7479 function.
7480 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7481 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7482 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7483 declaration.
7484
4da037ef
AH
74852019-04-15 Alan Hayward <alan.hayward@arm.com>
7486
7487 * aarch64-linux-nat.c
7488 (aarch64_linux_nat_target::thread_architecture): Add override.
7489 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7490 each VQ.
7491
ccb8d7e8
AH
74922019-04-15 Alan Hayward <alan.hayward@arm.com>
7493
7494 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7495
35add35e
AB
74962019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
7497
7498 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7499 target types of size 96-bits, add some additional comments, and
7500 check that the builtin type we found was the correct size.
7501
51196bbc
EZ
75022019-04-12 Eli Zaretskii <eliz@gnu.org>
7503
7504 * utils.c (prompt_for_continue): Don't restore the styling at the
7505 end, as applied_style has the wrong value. This fixes styling in
7506 long lists of file names that are interrupted by the "Continue?"
7507 prompt.
7508
62253a61
AB
75092019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
7510
7511 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7512 * c-lang.c (c_language_defn): Likewise.
7513 (cplus_language_defn): Likewise.
7514 (asm_language_defn): Likewise.
7515 (minimal_language_defn): Likewise.
7516 * d-lang.c (d_language_defn): Likewise.
7517 * f-lang.c (f_language_defn): Likewise.
7518 * go-lang.c (go_language_defn): Likewise.
7519 * language.c (unknown_language_defn): Likewise.
7520 (auto_language_defn): Likewise.
7521 * language.h (struct language_defn): Remove la_magic field.
7522 (LANG_MAGIC): Delete.
7523 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7524 * objc-lang.c (objc_language_defn): Likewise.
7525 * opencl-lang.c (opencl_language_defn): Likewise.
7526 * p-lang.c (pascal_language_defn): Likewise.
7527 * rust-lang.c (rust_language_defn): Likewise.
7528
a9158a86
AB
75292019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7530
7531 * riscv-tdep.c (riscv_type_align): New function.
7532 (riscv_type_alignment): Delete.
7533 (riscv_arg_location): Use 'type_align'.
7534 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7535
41077b66
AB
75362019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7537
7538 * gdbtypes.c (type_align): A struct with no non-static fields also
7539 has alignment of 1.
7540
9f0272f8
AB
75412019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7542
7543 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7544 component to 0.
7545 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7546 member.
7547 (riscv_struct_info::analyse): New implementation using new
7548 analyse_inner member function.
7549 (riscv_struct_info::field_offset): New member function.
7550 (riscv_struct_info::m_offsets): New member variable.
7551 (riscv_struct_info::analyse_inner): New private member function,
7552 takes the old implementation of riscv_struct_info::analyse but
7553 extended to track field offsets.
7554 (riscv_call_arg_struct): Update the struct folding special cases
7555 to handle cases where empty C++ structs, which are non-zero
7556 length, are found.
7557 (riscv_arg_location): Initialise the length of each location, a
7558 non-zero length now indicates the location is in use.
7559 (riscv_push_dummy_call): Allow for the first location having a
7560 non-zero offset when setting up arguments.
7561 (riscv_return_value): Likewise, but for return values.
7562
02cf60c7
TT
75632019-04-11 Tom Tromey <tromey@adacore.com>
7564
7565 * utils.c (internal_vproblem): Make "msg" const.
7566
68811f8f
AH
75672019-04-11 Alan Hayward <alan.hayward@arm.com>
7568
7569 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7570 * trad-frame.c (trad_frame_reset_saved_regs): New function.
7571 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7572 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7573
3f52fdbc
KB
75742019-04-10 Kevin Buettner <kevinb@redhat.com>
7575
7576 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7577 function.
7578 (fill_gregset): Call amd64_linux_collect_native_gregset instead
7579 of amd64_collect_native_gregset.
7580 (amd64_linux_nat_target::store_registers): Likewise.
7581
e9ad22ee
TT
75822019-04-10 Tom Tromey <tom@tromey.com>
7583
7584 * symtab.c (lookup_global_symbol_from_objfile)
7585 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7586 * objfiles.h (class separate_debug_iterator): New.
7587 (class separate_debug_range): New.
7588 (struct objfile) <separate_debug_objfiles>: New method.
7589 (objfile_separate_debug_iterate): Don't declare.
7590 * objfiles.c (separate_debug_iterator::operator++): Rename from
7591 objfile_separate_debug_iterate.
7592 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7593 iterator.
7594 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7595 iterator.
7596
ee371134
TT
75972019-04-10 Tom Tromey <tom@tromey.com>
7598
7599 * symfile.c (reread_symbols): Remove old comment.
7600 * objfiles.c (free_all_objfiles): Fix a typo.
7601
bf227d61
TT
76022019-04-10 Tom Tromey <tom@tromey.com>
7603
7604 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7605 * minsyms.c (lookup_minimal_symbol): Use foreach.
7606 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7607 (lookup_minimal_symbol_solib_trampoline): Likewise.
7608 * symfile.c (reread_symbols): Use foreach.
7609
8dc433a0
TT
76102019-04-09 Ivan Begert <ivanbegert@gmail.com>
7611 Tom Tromey <tromey@adacore.com>
7612
7613 PR rust/24414:
7614 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7615 (rust_lex_int_test): Change "value" to be LONGEST.
7616 (rust_lex_tests): Add test for long integer literal.
7617
9ab8741a
TT
76182019-04-09 Tom Tromey <tromey@adacore.com>
7619
7620 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7621 to bool.
7622 (extended_remote_target::attach): Update.
7623 (remote_target::remote_notice_new_inferior): Update.
7624 (remote_target::add_current_inferior_and_thread): Update.
7625 * inferior.c (exit_inferior_1): Use "false".
7626 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7627
e242fd12
SM
76282019-04-09 Simon Marchi <simon.marchi@efficios.com>
7629
9ca1957f 7630 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
7631 the "start" command.
7632
2b0c8b01
KB
76332019-04-08 Kevin Buettner <kevinb@redhat.com>
7634
7635 * python/py-inferior.c (infpy_thread_from_thread_handle):
7636 Adjust comments to reflect renaming of thread_from_thread_handle
7637 to thread_from_handle. Adjust keywords. Fix type error message.
7638 (inferior_object_methods): Add thread_from_handle. Retain
7639 thread_from_thread_handle, but mark it as deprecated.
7640
50a82723
KB
76412019-04-08 Kevin Buettner <kevinb@redhat.com>
7642
7643 * gdbthread.h (find_thread_by_handle): Revise declaration.
7644 * thread.c (find_thread_by_handle): Likewise. Adjust
7645 implementation too.
7646 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7647 support for buffer objects as handles.
7648
cf63b016
KB
76492019-04-08 Kevin Buettner <kevinb@redhat.com>
7650
7651 * python/py-infthread.c (thpy_thread_handle): New function.
7652 (thread_object_methods): Register thpy_thread_handle.
7653
3d6c6204
KB
76542019-04-08 Kevin Buettner <kevinb@redhat.com>
7655
7656 * gdbthread.h (thread_to_thread_handle): Declare.
7657 * thread.c (gdbtypes.h): Include.
7658 (thread_to_thread_handle): New function.
7659
7660 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7661 (target_thread_info_to_thread_handle): Declare.
7662 * target.c (target_thread_info_to_thread_handle): New function.
7663 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7664 * target-delegates.c: Regenerate.
7665
7666 * linux-thread-db.c (class thread_db_target): Add method
7667 thread_info_to_thread_handle.
7668 (thread_db_target::thread_info_to_thread_handle): Define.
7669 * remote.c (class remote_target): Add new method
7670 thread_info_to_thread_handle.
7671 (remote_target::thread_info_to_thread_handle): Define.
7672
56be6ea8
PA
76732019-04-08 Pedro Alves <palves@redhat.com>
7674
7675 * common/common-exceptions.c (throw_exception): Don't create
7676 named object to throw; throw directly.
7677 (throw_it): Likewise. Don't initialize gdb_exception::message
7678 here, with new; pass FMT and AP to the ctor instead.
7679 * common/common-exceptions.h: Include <string>.
7680 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7681 const char *, va_list)): New ctor. Use std::make_shared.
7682 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7683 errors)): Delete.
7684 (gdb_exception_error::gdb_exception_error(enum errors, const char
7685 *, va_list)): New.
7686 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7687 Add assertion.
7688 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7689 errors)): Delete.
7690 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7691 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7692 Add assertion.
7693
eedc3f4f
TT
76942019-04-08 Tom Tromey <tom@tromey.com>
7695
7696 * valops.c (value_rtti_indirect_type): Replace throw_exception
7697 with throw.
7698 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7699 with throw.
7700 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7701 throw.
7702 * target.c (target_translate_tls_address): Replace throw_exception
7703 with throw.
7704 * stack.c (frame_apply_command_count): Replace throw_exception
7705 with throw.
7706 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7707 throw.
7708 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7709 with throw.
7710 * rs6000-tdep.c (rs6000_frame_cache)
7711 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7712 * remote.c: Replace throw_exception with throw.
7713 * record-full.c (record_full_message, record_full_wait_1)
7714 (record_full_restore): Replace throw_exception with throw.
7715 * record-btrace.c:
7716 (get_thread_current_frame_id, record_btrace_start_replaying)
7717 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7718 (cmd_record_btrace_start): Replace throw_exception with throw.
7719 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7720 throw.
7721 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7722 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7723 * linespec.c:
7724 (find_linespec_symbols): Replace throw_exception with throw.
7725 * infrun.c (displaced_step_prepare, resume): Replace
7726 throw_exception with throw.
7727 * infcmd.c (post_create_inferior): Replace throw_exception with
7728 throw.
7729 * inf-loop.c (inferior_event_handler): Replace throw_exception
7730 with throw.
7731 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7732 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7733 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7734 (get_prev_frame_always, get_frame_pc_if_available)
7735 (get_frame_address_in_block_if_available, get_frame_language):
7736 Replace throw_exception with throw.
7737 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7738 throw_exception with throw.
7739 * eval.c (fetch_subexp_value, evaluate_var_value)
7740 (evaluate_funcall, evaluate_subexp_standard): Replace
7741 throw_exception with throw.
7742 * dwarf2loc.c (call_site_find_chain)
7743 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7744 Replace throw_exception with throw.
7745 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7746 with throw.
7747 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7748 throw.
7749 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7750 * completer.c (complete_line_internal): Replace throw_exception
7751 with throw.
7752 * compile/compile-object-run.c (compile_object_run): Replace
7753 throw_exception with throw.
7754 * cli/cli-script.c (process_next_line): Replace throw_exception
7755 with throw.
7756 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7757 (btrace_enable, btrace_maint_update_pt_packets): Replace
7758 throw_exception with throw.
7759 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7760 throw_exception with throw.
7761 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7762 throw_exception with throw.
7763 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7764 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7765 * aarch64-tdep.c (aarch64_make_prologue_cache)
7766 (aarch64_make_stub_cache): Replace throw_exception with throw.
7767
26003a20
TT
77682019-04-08 Tom Tromey <tom@tromey.com>
7769
7770 * common/common-exceptions.c (throw_exception): Rename from
7771 throw_exception_cxx. Remove old copy. Make argument const.
7772 (throw_it): Create and throw exception objects directly.
7773 * common/common-exceptions.h (throw_exception): Make argument
7774 const.
7775 (struct gdb_exception_error): Add constructor.
7776 (struct gdb_exception_quit): Add constructor.
7777
d272eb37
TT
77782019-04-08 Tom Tromey <tom@tromey.com>
7779
7780 * common/common-exceptions.h (exception_rethrow): Don't declare.
7781 (TRY_SJLJ): Update comment.
7782 (TRY, CATCH, END_CATCH): Remove.
7783 * common/common-exceptions.c (exception_rethrow): Remove.
7784
230d2906
TT
77852019-04-08 Tom Tromey <tom@tromey.com>
7786
7787 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7788 Remove.
7789 (gdb_exception_error): Rename from
7790 gdb_exception_RETURN_MASK_ERROR.
7791 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7792 (gdb_quit_bad_alloc): Update.
7793 * aarch64-tdep.c: Update.
7794 * ada-lang.c: Update.
7795 * ada-typeprint.c: Update.
7796 * ada-valprint.c: Update.
7797 * amd64-tdep.c: Update.
7798 * arch-utils.c: Update.
7799 * break-catch-throw.c: Update.
7800 * breakpoint.c: Update.
7801 * btrace.c: Update.
7802 * c-varobj.c: Update.
7803 * cli/cli-cmds.c: Update.
7804 * cli/cli-interp.c: Update.
7805 * cli/cli-script.c: Update.
7806 * common/common-exceptions.c: Update.
7807 * common/new-op.c: Update.
7808 * common/selftest.c: Update.
7809 * compile/compile-c-symbols.c: Update.
7810 * compile/compile-cplus-symbols.c: Update.
7811 * compile/compile-object-load.c: Update.
7812 * compile/compile-object-run.c: Update.
7813 * completer.c: Update.
7814 * corelow.c: Update.
7815 * cp-abi.c: Update.
7816 * cp-support.c: Update.
7817 * cp-valprint.c: Update.
7818 * darwin-nat.c: Update.
7819 * disasm-selftests.c: Update.
7820 * dtrace-probe.c: Update.
7821 * dwarf-index-cache.c: Update.
7822 * dwarf-index-write.c: Update.
7823 * dwarf2-frame-tailcall.c: Update.
7824 * dwarf2-frame.c: Update.
7825 * dwarf2loc.c: Update.
7826 * dwarf2read.c: Update.
7827 * eval.c: Update.
7828 * event-loop.c: Update.
7829 * event-top.c: Update.
7830 * exec.c: Update.
7831 * f-valprint.c: Update.
7832 * fbsd-tdep.c: Update.
7833 * frame-unwind.c: Update.
7834 * frame.c: Update.
7835 * gdbtypes.c: Update.
7836 * gnu-v3-abi.c: Update.
7837 * guile/guile-internal.h: Update.
7838 * guile/scm-block.c: Update.
7839 * guile/scm-breakpoint.c: Update.
7840 * guile/scm-cmd.c: Update.
7841 * guile/scm-disasm.c: Update.
7842 * guile/scm-frame.c: Update.
7843 * guile/scm-lazy-string.c: Update.
7844 * guile/scm-math.c: Update.
7845 * guile/scm-param.c: Update.
7846 * guile/scm-ports.c: Update.
7847 * guile/scm-pretty-print.c: Update.
7848 * guile/scm-symbol.c: Update.
7849 * guile/scm-symtab.c: Update.
7850 * guile/scm-type.c: Update.
7851 * guile/scm-value.c: Update.
7852 * i386-linux-tdep.c: Update.
7853 * i386-tdep.c: Update.
7854 * inf-loop.c: Update.
7855 * infcall.c: Update.
7856 * infcmd.c: Update.
7857 * infrun.c: Update.
7858 * jit.c: Update.
7859 * language.c: Update.
7860 * linespec.c: Update.
7861 * linux-fork.c: Update.
7862 * linux-nat.c: Update.
7863 * linux-tdep.c: Update.
7864 * linux-thread-db.c: Update.
7865 * main.c: Update.
7866 * mi/mi-cmd-break.c: Update.
7867 * mi/mi-cmd-stack.c: Update.
7868 * mi/mi-interp.c: Update.
7869 * mi/mi-main.c: Update.
7870 * objc-lang.c: Update.
7871 * p-valprint.c: Update.
7872 * parse.c: Update.
7873 * ppc-linux-tdep.c: Update.
7874 * printcmd.c: Update.
7875 * python/py-arch.c: Update.
7876 * python/py-breakpoint.c: Update.
7877 * python/py-cmd.c: Update.
7878 * python/py-finishbreakpoint.c: Update.
7879 * python/py-frame.c: Update.
7880 * python/py-framefilter.c: Update.
7881 * python/py-gdb-readline.c: Update.
7882 * python/py-inferior.c: Update.
7883 * python/py-infthread.c: Update.
7884 * python/py-lazy-string.c: Update.
7885 * python/py-linetable.c: Update.
7886 * python/py-objfile.c: Update.
7887 * python/py-param.c: Update.
7888 * python/py-prettyprint.c: Update.
7889 * python/py-progspace.c: Update.
7890 * python/py-record-btrace.c: Update.
7891 * python/py-record.c: Update.
7892 * python/py-symbol.c: Update.
7893 * python/py-type.c: Update.
7894 * python/py-unwind.c: Update.
7895 * python/py-utils.c: Update.
7896 * python/py-value.c: Update.
7897 * python/python.c: Update.
7898 * record-btrace.c: Update.
7899 * record-full.c: Update.
7900 * remote-fileio.c: Update.
7901 * remote.c: Update.
7902 * riscv-tdep.c: Update.
7903 * rs6000-aix-tdep.c: Update.
7904 * rs6000-tdep.c: Update.
7905 * rust-exp.y: Update.
7906 * rust-lang.c: Update.
7907 * s390-tdep.c: Update.
7908 * selftest-arch.c: Update.
7909 * solib-dsbt.c: Update.
7910 * solib-frv.c: Update.
7911 * solib-spu.c: Update.
7912 * solib-svr4.c: Update.
7913 * solib.c: Update.
7914 * sparc64-linux-tdep.c: Update.
7915 * stack.c: Update.
7916 * symfile-mem.c: Update.
7917 * symmisc.c: Update.
7918 * target.c: Update.
7919 * thread.c: Update.
7920 * top.c: Update.
7921 * tracefile-tfile.c: Update.
7922 * tui/tui.c: Update.
7923 * typeprint.c: Update.
7924 * unittests/cli-utils-selftests.c: Update.
7925 * unittests/parse-connection-spec-selftests.c: Update.
7926 * valops.c: Update.
7927 * valprint.c: Update.
7928 * value.c: Update.
7929 * varobj.c: Update.
7930 * windows-nat.c: Update.
7931 * x86-linux-nat.c: Update.
7932 * xml-support.c: Update.
7933
a70b8144
TT
79342019-04-08 Tom Tromey <tom@tromey.com>
7935
7936 * xml-support.c: Use C++ exception handling.
7937 * x86-linux-nat.c: Use C++ exception handling.
7938 * windows-nat.c: Use C++ exception handling.
7939 * varobj.c: Use C++ exception handling.
7940 * value.c: Use C++ exception handling.
7941 * valprint.c: Use C++ exception handling.
7942 * valops.c: Use C++ exception handling.
7943 * unittests/parse-connection-spec-selftests.c: Use C++ exception
7944 handling.
7945 * unittests/cli-utils-selftests.c: Use C++ exception handling.
7946 * typeprint.c: Use C++ exception handling.
7947 * tui/tui.c: Use C++ exception handling.
7948 * tracefile-tfile.c: Use C++ exception handling.
7949 * top.c: Use C++ exception handling.
7950 * thread.c: Use C++ exception handling.
7951 * target.c: Use C++ exception handling.
7952 * symmisc.c: Use C++ exception handling.
7953 * symfile-mem.c: Use C++ exception handling.
7954 * stack.c: Use C++ exception handling.
7955 * sparc64-linux-tdep.c: Use C++ exception handling.
7956 * solib.c: Use C++ exception handling.
7957 * solib-svr4.c: Use C++ exception handling.
7958 * solib-spu.c: Use C++ exception handling.
7959 * solib-frv.c: Use C++ exception handling.
7960 * solib-dsbt.c: Use C++ exception handling.
7961 * selftest-arch.c: Use C++ exception handling.
7962 * s390-tdep.c: Use C++ exception handling.
7963 * rust-lang.c: Use C++ exception handling.
7964 * rust-exp.y: Use C++ exception handling.
7965 * rs6000-tdep.c: Use C++ exception handling.
7966 * rs6000-aix-tdep.c: Use C++ exception handling.
7967 * riscv-tdep.c: Use C++ exception handling.
7968 * remote.c: Use C++ exception handling.
7969 * remote-fileio.c: Use C++ exception handling.
7970 * record-full.c: Use C++ exception handling.
7971 * record-btrace.c: Use C++ exception handling.
7972 * python/python.c: Use C++ exception handling.
7973 * python/py-value.c: Use C++ exception handling.
7974 * python/py-utils.c: Use C++ exception handling.
7975 * python/py-unwind.c: Use C++ exception handling.
7976 * python/py-type.c: Use C++ exception handling.
7977 * python/py-symbol.c: Use C++ exception handling.
7978 * python/py-record.c: Use C++ exception handling.
7979 * python/py-record-btrace.c: Use C++ exception handling.
7980 * python/py-progspace.c: Use C++ exception handling.
7981 * python/py-prettyprint.c: Use C++ exception handling.
7982 * python/py-param.c: Use C++ exception handling.
7983 * python/py-objfile.c: Use C++ exception handling.
7984 * python/py-linetable.c: Use C++ exception handling.
7985 * python/py-lazy-string.c: Use C++ exception handling.
7986 * python/py-infthread.c: Use C++ exception handling.
7987 * python/py-inferior.c: Use C++ exception handling.
7988 * python/py-gdb-readline.c: Use C++ exception handling.
7989 * python/py-framefilter.c: Use C++ exception handling.
7990 * python/py-frame.c: Use C++ exception handling.
7991 * python/py-finishbreakpoint.c: Use C++ exception handling.
7992 * python/py-cmd.c: Use C++ exception handling.
7993 * python/py-breakpoint.c: Use C++ exception handling.
7994 * python/py-arch.c: Use C++ exception handling.
7995 * printcmd.c: Use C++ exception handling.
7996 * ppc-linux-tdep.c: Use C++ exception handling.
7997 * parse.c: Use C++ exception handling.
7998 * p-valprint.c: Use C++ exception handling.
7999 * objc-lang.c: Use C++ exception handling.
8000 * mi/mi-main.c: Use C++ exception handling.
8001 * mi/mi-interp.c: Use C++ exception handling.
8002 * mi/mi-cmd-stack.c: Use C++ exception handling.
8003 * mi/mi-cmd-break.c: Use C++ exception handling.
8004 * main.c: Use C++ exception handling.
8005 * linux-thread-db.c: Use C++ exception handling.
8006 * linux-tdep.c: Use C++ exception handling.
8007 * linux-nat.c: Use C++ exception handling.
8008 * linux-fork.c: Use C++ exception handling.
8009 * linespec.c: Use C++ exception handling.
8010 * language.c: Use C++ exception handling.
8011 * jit.c: Use C++ exception handling.
8012 * infrun.c: Use C++ exception handling.
8013 * infcmd.c: Use C++ exception handling.
8014 * infcall.c: Use C++ exception handling.
8015 * inf-loop.c: Use C++ exception handling.
8016 * i386-tdep.c: Use C++ exception handling.
8017 * i386-linux-tdep.c: Use C++ exception handling.
8018 * guile/scm-value.c: Use C++ exception handling.
8019 * guile/scm-type.c: Use C++ exception handling.
8020 * guile/scm-symtab.c: Use C++ exception handling.
8021 * guile/scm-symbol.c: Use C++ exception handling.
8022 * guile/scm-pretty-print.c: Use C++ exception handling.
8023 * guile/scm-ports.c: Use C++ exception handling.
8024 * guile/scm-param.c: Use C++ exception handling.
8025 * guile/scm-math.c: Use C++ exception handling.
8026 * guile/scm-lazy-string.c: Use C++ exception handling.
8027 * guile/scm-frame.c: Use C++ exception handling.
8028 * guile/scm-disasm.c: Use C++ exception handling.
8029 * guile/scm-cmd.c: Use C++ exception handling.
8030 * guile/scm-breakpoint.c: Use C++ exception handling.
8031 * guile/scm-block.c: Use C++ exception handling.
8032 * guile/guile-internal.h: Use C++ exception handling.
8033 * gnu-v3-abi.c: Use C++ exception handling.
8034 * gdbtypes.c: Use C++ exception handling.
8035 * frame.c: Use C++ exception handling.
8036 * frame-unwind.c: Use C++ exception handling.
8037 * fbsd-tdep.c: Use C++ exception handling.
8038 * f-valprint.c: Use C++ exception handling.
8039 * exec.c: Use C++ exception handling.
8040 * event-top.c: Use C++ exception handling.
8041 * event-loop.c: Use C++ exception handling.
8042 * eval.c: Use C++ exception handling.
8043 * dwarf2read.c: Use C++ exception handling.
8044 * dwarf2loc.c: Use C++ exception handling.
8045 * dwarf2-frame.c: Use C++ exception handling.
8046 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8047 * dwarf-index-write.c: Use C++ exception handling.
8048 * dwarf-index-cache.c: Use C++ exception handling.
8049 * dtrace-probe.c: Use C++ exception handling.
8050 * disasm-selftests.c: Use C++ exception handling.
8051 * darwin-nat.c: Use C++ exception handling.
8052 * cp-valprint.c: Use C++ exception handling.
8053 * cp-support.c: Use C++ exception handling.
8054 * cp-abi.c: Use C++ exception handling.
8055 * corelow.c: Use C++ exception handling.
8056 * completer.c: Use C++ exception handling.
8057 * compile/compile-object-run.c: Use C++ exception handling.
8058 * compile/compile-object-load.c: Use C++ exception handling.
8059 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8060 * compile/compile-c-symbols.c: Use C++ exception handling.
8061 * common/selftest.c: Use C++ exception handling.
8062 * common/new-op.c: Use C++ exception handling.
8063 * cli/cli-script.c: Use C++ exception handling.
8064 * cli/cli-interp.c: Use C++ exception handling.
8065 * cli/cli-cmds.c: Use C++ exception handling.
8066 * c-varobj.c: Use C++ exception handling.
8067 * btrace.c: Use C++ exception handling.
8068 * breakpoint.c: Use C++ exception handling.
8069 * break-catch-throw.c: Use C++ exception handling.
8070 * arch-utils.c: Use C++ exception handling.
8071 * amd64-tdep.c: Use C++ exception handling.
8072 * ada-valprint.c: Use C++ exception handling.
8073 * ada-typeprint.c: Use C++ exception handling.
8074 * ada-lang.c: Use C++ exception handling.
8075 * aarch64-tdep.c: Use C++ exception handling.
8076
3d6e9d23
TT
80772019-04-08 Tom Tromey <tom@tromey.com>
8078
8079 * xml-support.c (gdb_xml_parser::parse): Update.
8080 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8081 * value.c (show_convenience): Update.
8082 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8083 (test_parse_flags_qcs): Update.
8084 * thread.c (thr_try_catch_cmd): Update.
8085 * target.c (target_translate_tls_address): Update.
8086 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8087 (info_frame_command_core, frame_apply_command_count): Update.
8088 * rust-exp.y (rust_lex_exception_test): Update.
8089 * riscv-tdep.c (riscv_print_one_register_info): Update.
8090 * remote.c (remote_target::enable_btrace): Update.
8091 * record-btrace.c (record_btrace_enable_warn): Update.
8092 * python/py-utils.c (gdbpy_convert_exception): Update.
8093 * printcmd.c (do_one_display, print_variable_and_value): Update.
8094 * mi/mi-main.c (mi_print_exception): Update.
8095 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8096 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8097 * linux-nat.c (linux_nat_target::attach): Update.
8098 * linux-fork.c (class scoped_switch_fork_info): Update.
8099 * infrun.c (displaced_step_prepare): Update.
8100 * infcall.c (call_function_by_hand_dummy): Update.
8101 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8102 * gnu-v3-abi.c (print_one_vtable): Update.
8103 * frame.c (get_prev_frame_always): Update.
8104 * f-valprint.c (info_common_command_for_block): Update.
8105 * exec.c (try_open_exec_file): Update.
8106 * exceptions.c (print_exception, exception_print)
8107 (exception_fprintf, exception_print_same): Update.
8108 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8109 * dwarf-index-cache.c (index_cache::store)
8110 (index_cache::lookup_gdb_index): Update.
8111 * darwin-nat.c (maybe_cache_shell): Update.
8112 * cp-valprint.c (cp_print_value_fields): Update.
8113 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8114 (gcc_cplus_symbol_address): Update.
8115 * compile/compile-c-symbols.c (gcc_convert_symbol)
8116 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8117 * common/selftest.c: Update.
8118 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8119 a std::string.
8120 (exception_try_scope_entry, exception_try_scope_exit): Don't
8121 declare.
8122 (struct exception_try_scope): Remove.
8123 (TRY): Don't use exception_try_scope.
8124 (struct gdb_exception): Add constructor, operator=.
8125 <what>: New method.
8126 (struct gdb_exception_RETURN_MASK_ALL)
8127 (struct gdb_exception_RETURN_MASK_ERROR)
8128 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8129 (struct gdb_quit_bad_alloc): Update.
8130 * common/common-exceptions.c (exception_none): Change
8131 initializer.
8132 (struct catcher) <state, exception>: Initialize inline.
8133 <prev>: Remove member.
8134 (current_catcher): Remove.
8135 (catchers): New global.
8136 (exceptions_state_mc_init): Simplify.
8137 (catcher_pop): Remove.
8138 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8139 (try_scope_depth, exception_try_scope_entry)
8140 (exception_try_scope_exit): Remove.
8141 (throw_exception_sjlj): Update.
8142 (exception_messages, exception_messages_size): Remove.
8143 (throw_it): Simplify.
8144 (gdb_exception_sliced_copy): Remove.
8145 (throw_exception_cxx): Update.
8146 * cli/cli-script.c (script_from_file): Update.
8147 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8148 Update.
8149 * ada-valprint.c (ada_val_print): Update.
8150 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8151 (create_excep_cond_exprs): Update.
8152
c5c10118
TT
81532019-04-08 Tom Tromey <tom@tromey.com>
8154
8155 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8156 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8157 (TRY, CATCH, END_CATCH): Remove some definitions.
8158 * common/common-exceptions.c: Don't use GDB_XCPT.
8159 (catcher_list_size): Remove.
8160 (throw_exception, throw_it): Simplify.
8161
4de283e4
TT
81622019-04-05 Tom Tromey <tom@tromey.com>
8163
8164 Revert the header-sorting patch.
8165 * ft32-tdep.c: Revert.
8166 * frv-tdep.c: Revert.
8167 * frv-linux-tdep.c: Revert.
8168 * frame.c: Revert.
8169 * frame-unwind.c: Revert.
8170 * frame-base.c: Revert.
8171 * fork-child.c: Revert.
8172 * findvar.c: Revert.
8173 * findcmd.c: Revert.
8174 * filesystem.c: Revert.
8175 * filename-seen-cache.h: Revert.
8176 * filename-seen-cache.c: Revert.
8177 * fbsd-tdep.c: Revert.
8178 * fbsd-nat.h: Revert.
8179 * fbsd-nat.c: Revert.
8180 * f-valprint.c: Revert.
8181 * f-typeprint.c: Revert.
8182 * f-lang.c: Revert.
8183 * extension.h: Revert.
8184 * extension.c: Revert.
8185 * extension-priv.h: Revert.
8186 * expprint.c: Revert.
8187 * exec.h: Revert.
8188 * exec.c: Revert.
8189 * exceptions.c: Revert.
8190 * event-top.c: Revert.
8191 * event-loop.c: Revert.
8192 * eval.c: Revert.
8193 * elfread.c: Revert.
8194 * dwarf2read.h: Revert.
8195 * dwarf2read.c: Revert.
8196 * dwarf2loc.c: Revert.
8197 * dwarf2expr.h: Revert.
8198 * dwarf2expr.c: Revert.
8199 * dwarf2-frame.c: Revert.
8200 * dwarf2-frame-tailcall.c: Revert.
8201 * dwarf-index-write.h: Revert.
8202 * dwarf-index-write.c: Revert.
8203 * dwarf-index-common.c: Revert.
8204 * dwarf-index-cache.h: Revert.
8205 * dwarf-index-cache.c: Revert.
8206 * dummy-frame.c: Revert.
8207 * dtrace-probe.c: Revert.
8208 * disasm.h: Revert.
8209 * disasm.c: Revert.
8210 * disasm-selftests.c: Revert.
8211 * dictionary.c: Revert.
8212 * dicos-tdep.c: Revert.
8213 * demangle.c: Revert.
8214 * dcache.h: Revert.
8215 * dcache.c: Revert.
8216 * darwin-nat.h: Revert.
8217 * darwin-nat.c: Revert.
8218 * darwin-nat-info.c: Revert.
8219 * d-valprint.c: Revert.
8220 * d-namespace.c: Revert.
8221 * d-lang.c: Revert.
8222 * ctf.c: Revert.
8223 * csky-tdep.c: Revert.
8224 * csky-linux-tdep.c: Revert.
8225 * cris-tdep.c: Revert.
8226 * cris-linux-tdep.c: Revert.
8227 * cp-valprint.c: Revert.
8228 * cp-support.c: Revert.
8229 * cp-namespace.c: Revert.
8230 * cp-abi.c: Revert.
8231 * corelow.c: Revert.
8232 * corefile.c: Revert.
8233 * continuations.c: Revert.
8234 * completer.h: Revert.
8235 * completer.c: Revert.
8236 * complaints.c: Revert.
8237 * coffread.c: Revert.
8238 * coff-pe-read.c: Revert.
8239 * cli-out.h: Revert.
8240 * cli-out.c: Revert.
8241 * charset.c: Revert.
8242 * c-varobj.c: Revert.
8243 * c-valprint.c: Revert.
8244 * c-typeprint.c: Revert.
8245 * c-lang.c: Revert.
8246 * buildsym.c: Revert.
8247 * buildsym-legacy.c: Revert.
8248 * build-id.h: Revert.
8249 * build-id.c: Revert.
8250 * btrace.c: Revert.
8251 * bsd-uthread.c: Revert.
8252 * breakpoint.h: Revert.
8253 * breakpoint.c: Revert.
8254 * break-catch-throw.c: Revert.
8255 * break-catch-syscall.c: Revert.
8256 * break-catch-sig.c: Revert.
8257 * blockframe.c: Revert.
8258 * block.c: Revert.
8259 * bfin-tdep.c: Revert.
8260 * bfin-linux-tdep.c: Revert.
8261 * bfd-target.c: Revert.
8262 * bcache.c: Revert.
8263 * ax-general.c: Revert.
8264 * ax-gdb.h: Revert.
8265 * ax-gdb.c: Revert.
8266 * avr-tdep.c: Revert.
8267 * auxv.c: Revert.
8268 * auto-load.c: Revert.
8269 * arm-wince-tdep.c: Revert.
8270 * arm-tdep.c: Revert.
8271 * arm-symbian-tdep.c: Revert.
8272 * arm-pikeos-tdep.c: Revert.
8273 * arm-obsd-tdep.c: Revert.
8274 * arm-nbsd-tdep.c: Revert.
8275 * arm-nbsd-nat.c: Revert.
8276 * arm-linux-tdep.c: Revert.
8277 * arm-linux-nat.c: Revert.
8278 * arm-fbsd-tdep.c: Revert.
8279 * arm-fbsd-nat.c: Revert.
8280 * arm-bsd-tdep.c: Revert.
8281 * arch-utils.c: Revert.
8282 * arc-tdep.c: Revert.
8283 * arc-newlib-tdep.c: Revert.
8284 * annotate.h: Revert.
8285 * annotate.c: Revert.
8286 * amd64-windows-tdep.c: Revert.
8287 * amd64-windows-nat.c: Revert.
8288 * amd64-tdep.c: Revert.
8289 * amd64-sol2-tdep.c: Revert.
8290 * amd64-obsd-tdep.c: Revert.
8291 * amd64-obsd-nat.c: Revert.
8292 * amd64-nbsd-tdep.c: Revert.
8293 * amd64-nbsd-nat.c: Revert.
8294 * amd64-nat.c: Revert.
8295 * amd64-linux-tdep.c: Revert.
8296 * amd64-linux-nat.c: Revert.
8297 * amd64-fbsd-tdep.c: Revert.
8298 * amd64-fbsd-nat.c: Revert.
8299 * amd64-dicos-tdep.c: Revert.
8300 * amd64-darwin-tdep.c: Revert.
8301 * amd64-bsd-nat.c: Revert.
8302 * alpha-tdep.c: Revert.
8303 * alpha-obsd-tdep.c: Revert.
8304 * alpha-nbsd-tdep.c: Revert.
8305 * alpha-mdebug-tdep.c: Revert.
8306 * alpha-linux-tdep.c: Revert.
8307 * alpha-linux-nat.c: Revert.
8308 * alpha-bsd-tdep.c: Revert.
8309 * alpha-bsd-nat.c: Revert.
8310 * aix-thread.c: Revert.
8311 * agent.c: Revert.
8312 * addrmap.c: Revert.
8313 * ada-varobj.c: Revert.
8314 * ada-valprint.c: Revert.
8315 * ada-typeprint.c: Revert.
8316 * ada-tasks.c: Revert.
8317 * ada-lang.c: Revert.
8318 * aarch64-tdep.c: Revert.
8319 * aarch64-ravenscar-thread.c: Revert.
8320 * aarch64-newlib-tdep.c: Revert.
8321 * aarch64-linux-tdep.c: Revert.
8322 * aarch64-linux-nat.c: Revert.
8323 * aarch64-fbsd-tdep.c: Revert.
8324 * aarch64-fbsd-nat.c: Revert.
8325 * aarch32-linux-nat.c: Revert.
8326
d55e5aa6
TT
83272019-04-05 Tom Tromey <tom@tromey.com>
8328
8329 * ft32-tdep.c: Sort headers.
8330 * frv-tdep.c: Sort headers.
8331 * frv-linux-tdep.c: Sort headers.
8332 * frame.c: Sort headers.
8333 * frame-unwind.c: Sort headers.
8334 * frame-base.c: Sort headers.
8335 * fork-child.c: Sort headers.
8336 * findvar.c: Sort headers.
8337 * findcmd.c: Sort headers.
8338 * filesystem.c: Sort headers.
8339 * filename-seen-cache.h: Sort headers.
8340 * filename-seen-cache.c: Sort headers.
8341 * fbsd-tdep.c: Sort headers.
8342 * fbsd-nat.h: Sort headers.
8343 * fbsd-nat.c: Sort headers.
8344 * f-valprint.c: Sort headers.
8345 * f-typeprint.c: Sort headers.
8346 * f-lang.c: Sort headers.
8347 * extension.h: Sort headers.
8348 * extension.c: Sort headers.
8349 * extension-priv.h: Sort headers.
8350 * expprint.c: Sort headers.
8351 * exec.h: Sort headers.
8352 * exec.c: Sort headers.
8353 * exceptions.c: Sort headers.
8354 * event-top.c: Sort headers.
8355 * event-loop.c: Sort headers.
8356 * eval.c: Sort headers.
8357 * elfread.c: Sort headers.
8358 * dwarf2read.h: Sort headers.
8359 * dwarf2read.c: Sort headers.
8360 * dwarf2loc.c: Sort headers.
8361 * dwarf2expr.h: Sort headers.
8362 * dwarf2expr.c: Sort headers.
8363 * dwarf2-frame.c: Sort headers.
8364 * dwarf2-frame-tailcall.c: Sort headers.
8365 * dwarf-index-write.h: Sort headers.
8366 * dwarf-index-write.c: Sort headers.
8367 * dwarf-index-common.c: Sort headers.
8368 * dwarf-index-cache.h: Sort headers.
8369 * dwarf-index-cache.c: Sort headers.
8370 * dummy-frame.c: Sort headers.
8371 * dtrace-probe.c: Sort headers.
8372 * disasm.h: Sort headers.
8373 * disasm.c: Sort headers.
8374 * disasm-selftests.c: Sort headers.
8375 * dictionary.c: Sort headers.
8376 * dicos-tdep.c: Sort headers.
8377 * demangle.c: Sort headers.
8378 * dcache.h: Sort headers.
8379 * dcache.c: Sort headers.
8380 * darwin-nat.h: Sort headers.
8381 * darwin-nat.c: Sort headers.
8382 * darwin-nat-info.c: Sort headers.
8383 * d-valprint.c: Sort headers.
8384 * d-namespace.c: Sort headers.
8385 * d-lang.c: Sort headers.
8386 * ctf.c: Sort headers.
8387 * csky-tdep.c: Sort headers.
8388 * csky-linux-tdep.c: Sort headers.
8389 * cris-tdep.c: Sort headers.
8390 * cris-linux-tdep.c: Sort headers.
8391 * cp-valprint.c: Sort headers.
8392 * cp-support.c: Sort headers.
8393 * cp-namespace.c: Sort headers.
8394 * cp-abi.c: Sort headers.
8395 * corelow.c: Sort headers.
8396 * corefile.c: Sort headers.
8397 * continuations.c: Sort headers.
8398 * completer.h: Sort headers.
8399 * completer.c: Sort headers.
8400 * complaints.c: Sort headers.
8401 * coffread.c: Sort headers.
8402 * coff-pe-read.c: Sort headers.
8403 * cli-out.h: Sort headers.
8404 * cli-out.c: Sort headers.
8405 * charset.c: Sort headers.
8406 * c-varobj.c: Sort headers.
8407 * c-valprint.c: Sort headers.
8408 * c-typeprint.c: Sort headers.
8409 * c-lang.c: Sort headers.
8410 * buildsym.c: Sort headers.
8411 * buildsym-legacy.c: Sort headers.
8412 * build-id.h: Sort headers.
8413 * build-id.c: Sort headers.
8414 * btrace.c: Sort headers.
8415 * bsd-uthread.c: Sort headers.
8416 * breakpoint.h: Sort headers.
8417 * breakpoint.c: Sort headers.
8418 * break-catch-throw.c: Sort headers.
8419 * break-catch-syscall.c: Sort headers.
8420 * break-catch-sig.c: Sort headers.
8421 * blockframe.c: Sort headers.
8422 * block.c: Sort headers.
8423 * bfin-tdep.c: Sort headers.
8424 * bfin-linux-tdep.c: Sort headers.
8425 * bfd-target.c: Sort headers.
8426 * bcache.c: Sort headers.
8427 * ax-general.c: Sort headers.
8428 * ax-gdb.h: Sort headers.
8429 * ax-gdb.c: Sort headers.
8430 * avr-tdep.c: Sort headers.
8431 * auxv.c: Sort headers.
8432 * auto-load.c: Sort headers.
8433 * arm-wince-tdep.c: Sort headers.
8434 * arm-tdep.c: Sort headers.
8435 * arm-symbian-tdep.c: Sort headers.
8436 * arm-pikeos-tdep.c: Sort headers.
8437 * arm-obsd-tdep.c: Sort headers.
8438 * arm-nbsd-tdep.c: Sort headers.
8439 * arm-nbsd-nat.c: Sort headers.
8440 * arm-linux-tdep.c: Sort headers.
8441 * arm-linux-nat.c: Sort headers.
8442 * arm-fbsd-tdep.c: Sort headers.
8443 * arm-fbsd-nat.c: Sort headers.
8444 * arm-bsd-tdep.c: Sort headers.
8445 * arch-utils.c: Sort headers.
8446 * arc-tdep.c: Sort headers.
8447 * arc-newlib-tdep.c: Sort headers.
8448 * annotate.h: Sort headers.
8449 * annotate.c: Sort headers.
8450 * amd64-windows-tdep.c: Sort headers.
8451 * amd64-windows-nat.c: Sort headers.
8452 * amd64-tdep.c: Sort headers.
8453 * amd64-sol2-tdep.c: Sort headers.
8454 * amd64-obsd-tdep.c: Sort headers.
8455 * amd64-obsd-nat.c: Sort headers.
8456 * amd64-nbsd-tdep.c: Sort headers.
8457 * amd64-nbsd-nat.c: Sort headers.
8458 * amd64-nat.c: Sort headers.
8459 * amd64-linux-tdep.c: Sort headers.
8460 * amd64-linux-nat.c: Sort headers.
8461 * amd64-fbsd-tdep.c: Sort headers.
8462 * amd64-fbsd-nat.c: Sort headers.
8463 * amd64-dicos-tdep.c: Sort headers.
8464 * amd64-darwin-tdep.c: Sort headers.
8465 * amd64-bsd-nat.c: Sort headers.
8466 * alpha-tdep.c: Sort headers.
8467 * alpha-obsd-tdep.c: Sort headers.
8468 * alpha-nbsd-tdep.c: Sort headers.
8469 * alpha-mdebug-tdep.c: Sort headers.
8470 * alpha-linux-tdep.c: Sort headers.
8471 * alpha-linux-nat.c: Sort headers.
8472 * alpha-bsd-tdep.c: Sort headers.
8473 * alpha-bsd-nat.c: Sort headers.
8474 * aix-thread.c: Sort headers.
8475 * agent.c: Sort headers.
8476 * addrmap.c: Sort headers.
8477 * ada-varobj.c: Sort headers.
8478 * ada-valprint.c: Sort headers.
8479 * ada-typeprint.c: Sort headers.
8480 * ada-tasks.c: Sort headers.
8481 * ada-lang.c: Sort headers.
8482 * aarch64-tdep.c: Sort headers.
8483 * aarch64-ravenscar-thread.c: Sort headers.
8484 * aarch64-newlib-tdep.c: Sort headers.
8485 * aarch64-linux-tdep.c: Sort headers.
8486 * aarch64-linux-nat.c: Sort headers.
8487 * aarch64-fbsd-tdep.c: Sort headers.
8488 * aarch64-fbsd-nat.c: Sort headers.
8489 * aarch32-linux-nat.c: Sort headers.
8490
699bd4cf
TT
84912019-04-04 Tom Tromey <tom@tromey.com>
8492
8493 * varobj.c (varobj_create): Update.
8494 * rust-exp.y (struct rust_parser) <update_innermost_block,
8495 lookup_symbol>: New methods.
8496 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8497 Rename.
8498 (rust_parser::rust_lookup_type)
8499 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8500 * printcmd.c (display_command, do_one_display): Update.
8501 * parser-defs.h (struct parser_state) <parser_state>: Add
8502 "tracker" parameter.
8503 (block_tracker): New member.
8504 (class innermost_block_tracker) <innermost_block_tracker>: Add
8505 "types" parameter.
8506 <reset>: Remove method.
8507 (innermost_block): Don't declare.
8508 (null_post_parser): Update.
8509 * parse.c (innermost_block): Remove global.
8510 (write_dollar_variable): Update.
8511 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8512 Remove "tracker_types" parameter.
8513 (parse_expression): Add "tracker" parameter.
8514 (parse_expression_for_completion): Update.
8515 (null_post_parser): Add "tracker" parameter.
8516 * p-exp.y: Update rules.
8517 * m2-exp.y: Update rules.
8518 * language.h (struct language_defn) <la_post_parser>: Add
8519 "tracker" parameter.
8520 * go-exp.y: Update rules.
8521 * f-exp.y: Update rules.
8522 * expression.h (parse_expression, parse_exp_1): Add "tracker"
8523 parameter.
8524 * d-exp.y: Update rules.
8525 * c-exp.y: Update rules.
8526 * breakpoint.c (set_breakpoint_condition): Create an
8527 innermost_block_tracker.
8528 (watch_command_1): Likewise.
8529 * ada-lang.c (resolve): Add "tracker" parameter.
8530 (resolve_subexp): Likewise.
8531 * ada-exp.y (write_var_from_sym): Update.
8532
dac43e32
TT
85332019-04-04 Tom Tromey <tom@tromey.com>
8534
8535 * type-stack.h: New file.
8536 * type-stack.c: New file.
8537 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8538 type-stack.h.
8539 (insert_into_type_stack, insert_type, push_type, push_type_int)
8540 (insert_type_address_space, pop_type, pop_type_int)
8541 (pop_typelist, pop_type_stack, append_type_stack)
8542 (push_type_stack, get_type_stack, push_typelist)
8543 (follow_type_instance_flags, follow_types): Don't declare.
8544 * parse.c (type_stack): Remove global.
8545 (parse_exp_in_context): Update.
8546 (insert_into_type_stack, insert_type, push_type, push_type_int)
8547 (insert_type_address_space, pop_type, pop_type_int)
8548 (pop_typelist, pop_type_stack, append_type_stack)
8549 (push_type_stack, get_type_stack, push_typelist)
8550 (follow_type_instance_flags, follow_types): Remove (moved to
8551 type-stack.c).
8552 * f-exp.y (type_stack): New global.
8553 Update rules.
8554 (push_kind_type, f_parse): Update.
8555 * d-exp.y (type_stack): New global.
8556 Update rules.
8557 (d_parse): Update.
8558 * c-exp.y (struct c_parse_state) <type_stack>: New member.
8559 Update rules.
8560 * Makefile.in (COMMON_SFILES): Add type-stack.c.
8561 (HFILES_NO_SRCDIR): Add type-stack.h.
8562
2a612529
TT
85632019-04-04 Tom Tromey <tom@tromey.com>
8564
8565 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8566 (rust_parser::convert_ast_to_expression, rust_parse)
8567 (rust_lex_test_completion, rust_lex_tests): Update.
8568 * parser-defs.h (struct expr_completion_state): New.
8569 (struct parser_state) <parser_state>: Add completion parameter.
8570 <mark_struct_expression, mark_completion_tag>: New methods.
8571 <parse_completion, m_completion_state>: New members.
8572 (prefixify_expression, null_post_parser): Update.
8573 (mark_struct_expression, mark_completion_tag): Don't declare.
8574 * parse.c (parse_completion, expout_last_struct)
8575 (expout_tag_completion_type, expout_completion_name): Remove
8576 globals.
8577 (parser_state::mark_struct_expression)
8578 (parser_state::mark_completion_tag): Now methods.
8579 (prefixify_expression): Add last_struct parameter.
8580 (prefixify_subexp): Likewise.
8581 (parse_exp_1): Update.
8582 (parse_exp_in_context): Add cstate parameter. Update.
8583 (parse_expression_for_completion): Create an
8584 expr_completion_state.
8585 (null_post_parser): Add "completion" parameter.
8586 * p-exp.y: Update rules.
8587 (yylex): Update.
8588 * language.h (struct language_defn) <la_post_parser>: Add
8589 "completing" parameter.
8590 * go-exp.y: Update rules.
8591 (lex_one_token): Update.
8592 * expression.h (parse_completion): Don't declare.
8593 * d-exp.y: Update rules.
8594 (lex_one_token): Update rules.
8595 * c-exp.y: Update rules.
8596 (lex_one_token): Update.
8597 * ada-lang.c (resolve): Add "parse_completion" parameter.
8598 (resolve_subexp): Likewise.
8599 (ada_resolve_function): Likewise.
8600
43476f0b
TT
86012019-04-04 Tom Tromey <tom@tromey.com>
8602
8603 * parser-defs.h (struct parser_state) <start_arglist,
8604 end_arglist>: New methods.
8605 <arglist_len, m_funcall_chain>: New members.
8606 (arglist_len, start_arglist, end_arglist): Don't declare.
8607 * parse.c (arglist_len, funcall_chain): Remove global.
8608 (start_arglist, end_arglist): Remove functions.
8609 (parse_exp_in_context): Update.
8610 * p-exp.y: Update rules.
8611 * m2-exp.y: Update rules.
8612 * go-exp.y: Update rules.
8613 * f-exp.y: Update rules.
8614 * d-exp.y: Update rules.
8615 * c-exp.y: Update rules.
8616
5776fca3
TT
86172019-04-04 Tom Tromey <tom@tromey.com>
8618
8619 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8620 lex_operator, push_back>: New methods.
8621 Update all rules.
8622 (rust_parser::lex_hex, lex_escape): Rename and update.
8623 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8624 (rust_parser::lex_operator): Rename and update.
8625 (rust_parser::lex_number, rustyylex, rustyyerror)
8626 (rust_lex_test_init, rust_lex_test_sequence)
8627 (rust_lex_test_push_back, rust_lex_tests): Update.
8628 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8629 parameter.
8630 <lexptr, prev_lexptr>: New members.
8631 (lexptr, prev_lexptr): Don't declare.
8632 * parse.c (lexptr, prev_lexptr): Remove globals.
8633 (parse_exp_in_context): Update.
8634 * p-exp.y (yylex, yyerror): Update.
8635 * m2-exp.y (parse_number, yylex, yyerror): Update.
8636 * go-exp.y (lex_one_token, yyerror): Update.
8637 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8638 * d-exp.y (lex_one_token, yyerror): Update.
8639 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8640 (lex_one_token, yyerror): Update.
8641 * ada-lex.l (YY_INPUT): Update.
8642 (rewind_to_char): Update.
8643 * ada-exp.y (yyerror): Update.
8644
8621b685
TT
86452019-04-04 Tom Tromey <tom@tromey.com>
8646
8647 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8648 * parser-defs.h (struct parser_state) <parser_state>: Add new
8649 parameter.
8650 <comma_terminates>: New member.
8651 (comma_terminates): Don't declare global.
8652 * parse.c (comma_terminates): Remove global.
8653 (parse_exp_in_context): Update.
8654 * p-exp.y (yylex): Update.
8655 * m2-exp.y (yylex): Update.
8656 * go-exp.y (lex_one_token): Update.
8657 * f-exp.y (yylex): Update.
8658 * d-exp.y (lex_one_token): Update.
8659 * c-exp.y (lex_one_token): Update.
8660 * ada-lex.l: Update.
8661
28aaf3fd
TT
86622019-04-04 Tom Tromey <tom@tromey.com>
8663
8664 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8665 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8666 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8667 * parser-defs.h (paren_depth): Don't declare.
8668 * parse.c (paren_depth): Remove global.
8669 (parse_exp_in_context): Update.
8670 * p-exp.y (paren_depth): New global.
8671 (pascal_parse): Initialize it.
8672 * m2-exp.y (paren_depth): New global.
8673 (m2_parse): Initialize it.
8674 * go-exp.y (paren_depth): New global.
8675 (go_parse): Initialize it.
8676 * f-exp.y (paren_depth): New global.
8677 (f_parse): Initialize it.
8678 * d-exp.y (paren_depth): New global.
8679 (d_parse): Initialize it.
8680 * c-exp.y (paren_depth): New global.
8681 (c_parse): Initialize it.
8682 * ada-lex.l (paren_depth): New global.
8683 (lexer_init): Initialize it.
8684
1e58a4a4
TT
86852019-04-04 Tom Tromey <tom@tromey.com>
8686
8687 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8688 (rust_parser::convert_ast_to_type)
8689 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8690 * parser-defs.h (struct parser_state) <parser_state>: Add
8691 parameters. Initialize new members.
8692 <expression_context_block, expression_context_pc>: New members.
8693 * parse.c (expression_context_block, expression_context_pc):
8694 Remove globals.
8695 (parse_exp_in_context): Update.
8696 * p-exp.y: Update all rules.
8697 (yylex): Update.
8698 * m2-exp.y: Update all rules.
8699 (yylex): Update.
8700 * go-exp.y (yylex): Update.
8701 * f-exp.y (yylex): Update.
8702 * d-exp.y: Update all rules.
8703 (yylex): Update.
8704 * c-exp.y: Update all rules.
8705 (lex_one_token, classify_name, yylex, c_parse): Update.
8706 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8707
37eedb39
TT
87082019-04-04 Tom Tromey <tom@tromey.com>
8709
8710 * gdbarch.h, gdbarch.c: Rebuild.
8711 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8712 * stap-probe.h:
8713 (struct stap_parse_info): Replace "parser_state" with
8714 "expr_builder".
8715 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8716 (parser_state): New class.
8717 * parse.c (expr_builder): Rename.
8718 (expr_builder::release): Rename.
8719 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8720 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8721 (write_exp_elt_longcst, write_exp_elt_floatcst)
8722 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8723 (write_exp_string_vector, write_exp_bitstring)
8724 (write_exp_msymbol, mark_struct_expression)
8725 (write_dollar_variable)
8726 (insert_type_address_space, increase_expout_size): Replace
8727 "parser_state" with "expr_builder".
8728 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8729 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8730 "parser_state" with "expr_builder".
8731
73923d7e
TT
87322019-04-04 Tom Tromey <tom@tromey.com>
8733
8734 * rust-exp.y: Replace "parse_language" with method call.
8735 * p-exp.y:
8736 (yylex): Replace "parse_language" with method call.
8737 * m2-exp.y:
8738 (yylex): Replace "parse_language" with method call.
8739 * go-exp.y (classify_name): Replace "parse_language" with method
8740 call.
8741 * f-exp.y (yylex): Replace "parse_language" with method call.
8742 * d-exp.y (lex_one_token): Replace "parse_language" with method
8743 call.
8744 * c-exp.y:
8745 (lex_one_token, classify_name, yylex): Replace "parse_language"
8746 with method call.
8747 * ada-exp.y (find_primitive_type, type_char)
8748 (type_system_address): Replace "parse_language" with method call.
8749
fa9f5be6
TT
87502019-04-04 Tom Tromey <tom@tromey.com>
8751
8752 * rust-exp.y: Replace "parse_gdbarch" with method call.
8753 * parse.c (write_dollar_variable, insert_type_address_space):
8754 Replace "parse_gdbarch" with method call.
8755 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8756 call.
8757 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8758 call.
8759 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8760 "parse_gdbarch" with method call.
8761 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8762 with method call.
8763 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8764 "parse_gdbarch" with method call.
8765 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8766 "parse_gdbarch" with method call.
8767 * c-exp.y (parse_type, parse_number, classify_name): Replace
8768 "parse_gdbarch" with method call.
8769 * ada-lex.l: Replace "parse_gdbarch" with method call.
8770 * ada-exp.y (parse_type, find_primitive_type, type_char)
8771 (type_system_address): Replace "parse_gdbarch" with method call.
8772
1201a264
TT
87732019-04-04 Tom Tromey <tom@tromey.com>
8774
8775 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8776 * stap-probe.c (stap_parse_argument): Update.
8777 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8778 initial_size parameter.
8779 * rust-exp.y (rust_lex_tests): Update.
8780 * parse.c (parser_state): Update.
8781 (parse_exp_in_context): Update.
8782 * parser-defs.h (struct parser_state) <parser_state>: Remove
8783 "initial_size" parameter.
8784
e3980ce2
TT
87852019-04-04 Tom Tromey <tom@tromey.com>
8786
8787 * parser-defs.h (increase_expout_size): Don't declare.
8788 * parse.c (increase_expout_size): Now static.
8789
e9f8e3f1
TS
87902019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8791
8792 * gnu-nat.c (gnu_nat_target::wait): Fix
8793 target_waitstatus_to_string call.
8794
d7df6549
AB
87952019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8796
8797 * eval.c (evaluate_subexp_standard): Handle internal functions
8798 during Fortran function call handling.
8799
8bdc1658
AB
88002019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8801
8802 * NEWS: Mention new internal functions.
8803 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8804 (read_base_type): Use dwarf2_init_complex_target_type.
8805 * value.c (creal_internal_fn): New function.
8806 (cimag_internal_fn): New function.
8807 (_initialize_values): Register new internal functions.
8808
c29705b7
PW
88092019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8810
8811 * infrun.c (stop_all_threads): If debug_infrun, always
8812 trace the wait status after wait_one, using
8813 target_waitstatus_to_string and target_pid_to_str.
8814 (handle_inferior_event): Replace various trace of
8815 wait status kind by a single trace.
8816 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8817 wait status kind image by target_waitstatus_to_string.
8818 * target/waitstatus.c (target_waitstatus_to_string): Fix
8819 obsolete comment.
8820
05caa1d2
TT
88212019-04-01 Tom Tromey <tromey@adacore.com>
8822
8823 PR symtab/23331:
8824 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8825
9d1447e0
SDJ
88262019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
8827 Pedro Alves <palves@redhat.com>
8828
8829 * top.c (quit_force): Call 'finalize_values'.
8830 * value.c (finalize_values): New function.
8831 * value.h (finalize_values): Declare.
8832
7734102d
EZ
88332019-03-30 Eli Zaretskii <eliz@gnu.org>
8834
8835 * NEWS: Announce $_gdb_major and $_gdb_minor.
8836
8837 * top.c (init_gdb_version_vars): New function.
8838 (gdb_init): Call init_gdb_version_vars.
8839
188e1fa9
TT
88402019-03-29 Tom Tromey <tromey@adacore.com>
8841
8842 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
8843 help text. Remove dead code.
8844
2880242d
KS
88452019-03-29 Keith Seitz <keiths@redhat.com>
8846
8847 From Siddhesh Poyarekar:
8848 * f-lang.h (f77_get_upperbound): Return LONGEST.
8849 (f77_get_lowerbound): Likewise.
8850 * f-typeprint.c (f_type_print_varspec_suffix): Expand
8851 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
8852 print them.
8853 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
8854 plongest to format print it.
8855 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8856 (f77_get_upperbound): Likewise.
8857 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8858 LOWER_BOUND to LONGEST.
8859 (f77_create_arrayprint_offset_tbl): Likewise.
8860
cc1defb1
KS
88612019-03-29 Keith Seitz <keiths@redhat.com>
8862
8863 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8864 %s/pulongest for TYPE_LENGTH instead of %d in format
8865 strings.
8866 * ada-typerint.c (ada_print_type): Likewise.
8867 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8868 * compile/compile-c-support.c (generate_register_struct): Likewise.
8869 * gdbtypes.c (recursive_dump_type): Likewise.
8870 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8871 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
8872 instead of %d in format strings.
8873 * riscv-tdep.c (riscv_type_alignment): Cast second argument
8874 to std::min to ULONGEST.
8875 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8876 instead of %d in format strings.
8877 * tracepoint.c (info_scope_command): Likewise.
8878 * typeprint.c (print_offset_data::update)
8879 (print_offset_data::finish): Likewise.
8880 * xtensa-tdep.c (xtensa_store_return_value)
8881 (xtensa_push_dummy_call): Likewise.
8882
e432ccf1
JT
88832019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
8884
8885 * windows-nat.c (display_selector): Fixed format specifications
8886 for 64-bit Cygwin.
8887
65d2b333
PW
88882019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8889
8890 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8891
f489207e
SL
88922019-03-28 Sandra Loosemore <sandra@codesourcery.com>
8893
8894 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8895 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8896 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8897 (nios2_linux_init_abi): Install it.
8898
bffa1015
AH
88992019-03-28 Alan Hayward <alan.hayward@arm.com>
8900
8901 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8902
fc96163a
AH
89032019-03-28 Alan Hayward <alan.hayward@arm.com>
8904
8905 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8906
20dc7e9b
PW
89072019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8908 Tom Tromey <tromey@adacore.com>
8909
8910 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8911
7f5331a8
JB
89122019-03-26 Joel Brobecker <brobecker@adacore.com>
8913
8914 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8915 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8916 method to compute the bounds of range types. Also print "[evaluated]"
8917 if the bounds' values come from a dynamic evaluation.
8918
18c77628
AB
89192019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
8920
8921 * cp-valprint.c (cp_print_value_fields): Don't print trailing
8922 whitespace when pretty printing is on.
8923
53c973f2
AH
89242019-03-26 Alan Hayward <alan.hayward@arm.com>
8925
e79be6e5 8926 * ppc-linux-nat.c: Add include.
53c973f2 8927
d851aa71
AH
89282019-03-26 Alan Hayward <alan.hayward@arm.com>
8929
e79be6e5 8930 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 8931
2fe7bab7
AH
89322019-03-26 Alan Hayward <alan.hayward@arm.com>
8933
e79be6e5 8934 * arm-linux-nat.c: Add include.
2fe7bab7 8935
068ef30e
SM
89362019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
8937
8938 * source-cache.c (source_cache::get_source_lines): Re-read
8939 fullname after calling open_source_file.
8940
81a24d04
JB
89412019-03-25 John Baldwin <jhb@FreeBSD.org>
8942
8943 * NEWS: Mention TLS support for FreeBSD.
8944
79e7ae11
TT
89452019-03-25 Tom Tromey <tromey@adacore.com>
8946
8947 * minsyms.c (BUNCH_SIZE): Update comment.
8948 (~minimal_symbol_reader): Remove old comment.
8949 (compact_minimal_symbols): Update comment.
8950 (minimal_symbol_reader::install): Remove old comment. Update
8951 other comments.
8952
d45963c2
AH
89532019-03-25 Alan Hayward <alan.hayward@arm.com>
8954
8955 * s390-linux-nat.c: Add include.
8956
0f83012e
AH
89572019-03-25 Alan Hayward <alan.hayward@arm.com>
8958
8959 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8960 Call linux_get_hwcap.
8961 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8962 Likewise.
8963 (aarch64_linux_get_hwcap): Remove function.
8964 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8965 declaration.
8966 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8967 linux_get_hwcap.
8968 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8969 * linux-tdep.c (linux_get_hwcap): Add function.
8970 (linux_get_hwcap2): Likewise.
8971 * linux-tdep.h (linux_get_hwcap): Add declaration.
8972 (linux_get_hwcap2): Likewise.
8973 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8974 (ppc_linux_get_hwcap2): Likewise.
8975 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8976 linux_get_hwcap.
8977 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8978 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8979 (ppc_linux_nat_target::read_description): Likewise.
8980 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8981 * s390-linux-nat.c: Likewise.
8982 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8983
6640a367
TT
89842019-03-24 Tom Tromey <tom@tromey.com>
8985
8986 * ada-lang.c (standard_lookup): Simplify initialization.
8987 (ada_lookup_symbol_nonlocal): Simplify return.
8988 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8989 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8990 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8991 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8992 initialization.
8993 * solib.c (solib_global_lookup): Simplify.
8994 * symtab.c (null_block_symbol): Remove.
8995 (symbol_cache_lookup): Simplify returns.
8996 (lookup_language_this): Simplify returns.
8997 (lookup_symbol_aux): Simplify return.
8998 (lookup_local_symbol): Simplify returns.
8999 (lookup_global_symbol_from_objfile): Simplify return.
9000 (lookup_symbol_in_objfile_symtabs)
9001 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9002 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9003 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9004 * cp-namespace.c (cp_lookup_bare_symbol)
9005 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9006 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9007 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9008 (cp_lookup_symbol_via_imports): Simplify initialization.
9009 (find_symbol_in_baseclass): Likewise.
9010 * symtab.h (null_block_symbol): Remove.
9011 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9012 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9013 (d_lookup_symbol_module): Likewise.
9014 (find_symbol_in_baseclass): Simplify initialization.
9015
a930ebcd
TT
90162019-03-24 Tom Tromey <tom@tromey.com>
9017
9018 * expression.h: Don't include symtab.h.
9019 (struct block): Forward declare.
9020
582942f4
TT
90212019-03-24 Tom Tromey <tom@tromey.com>
9022
9023 * c-exp.y (typebase): Remove casts.
9024 * gdbtypes.c (lookup_unsigned_typename, )
9025 (lookup_signed_typename): Remove cast.
9026 * eval.c (parse_to_comma_and_eval): Remove cast.
9027 * parse.c (write_dollar_variable): Remove cast.
9028 * block.h (struct block) <superblock>: Now const.
9029 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9030 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9031 (map_block): Make "block" const.
9032 * symfile.h (struct quick_symbol_functions)
9033 <map_matching_symbols>: Constify block argument to "callback".
9034 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9035 const.
9036 (find_pc_sect_compunit_symtab): Make "b" const.
9037 (find_symbol_at_address): Likewise.
9038 (search_symbols): Likewise.
9039 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9040 (dw2_debug_names_lookup_symbol): Likewise.
9041 (dw2_map_matching_symbols): Update.
9042 * p-valprint.c (pascal_val_print): Remove "block".
9043 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9044 (aux_add_nonlocal_symbols): Make "block" const.
9045 (resolve_subexp): Remove cast.
9046 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9047 const.
9048 (iterate_over_file_blocks): Likewise.
9049 * f-exp.y (%union) <bval>: Remove.
9050 * coffread.c (patch_opaque_types): Make "b" const.
9051 * spu-tdep.c (spu_catch_start): Make "block" const.
9052 * c-valprint.c (print_unpacked_pointer): Remove "block".
9053 * symmisc.c (dump_symtab_1): Make "b" const.
9054 (block_depth): Make "block" const.
9055 * d-exp.y (%union) <bval>: Remove.
9056 * cp-support.h (cp_lookup_rtti_type): Update.
9057 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9058 * psymtab.c (psym_lookup_symbol): Make "block" const.
9059 (maintenance_check_psymtabs): Make "b" const.
9060 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9061 (enumerate_locals, enumerate_args): Update.
9062 * python/py-symtab.c (stpy_global_block): Make "block" const.
9063 (stpy_static_block): Likewise.
9064 * inline-frame.c (block_starting_point_at): Make "new_block"
9065 const.
9066 * block.c (find_block_in_blockvector): Make return type const.
9067 (blockvector_for_pc_sect): Make "b" const.
9068 (find_block_in_blockvector): Make "b" const.
9069
7ad417dd
TT
90702019-03-23 Tom Tromey <tom@tromey.com>
9071
9072 * varobj.c (varobj_create): Update.
9073 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9074 * printcmd.c (display_command, do_one_display): Don't reset
9075 innermost_block.
9076 * parser-defs.h (enum innermost_block_tracker_type): Move to
9077 expression.h.
9078 (innermost_block): Update comment.
9079 * parse.c (parse_exp_1): Add tracker_types parameter.
9080 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9081 tracker_types parameter. Reset innermost_block.
9082 (parse_exp_in_context): Remove.
9083 (parse_expression_for_completion): Update.
9084 * objfiles.c (~objfile): Don't reset expression_context_block or
9085 innermost_block.
9086 * expression.h (enum innermost_block_tracker_type): Move from
9087 parser-defs.h.
9088 (parse_exp_1): Add tracker_types parameter.
9089 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9090 reset innermost_block.
9091
b366c208
TT
90922019-03-23 Tom Tromey <tom@tromey.com>
9093
9094 * objfiles.h: Include bcache.h.
9095
9bb9b2f9
TT
90962019-03-23 Tom Tromey <tom@tromey.com>
9097
9098 * linespec.c (get_current_search_block): Use
9099 scoped_restore_current_language.
9100 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9101
59c28372
AH
91022019-03-22 Alan Hayward <alan.hayward@arm.com>
9103 Jiong Wang <jiong.wang@arm.com>
9104
9105 * aarch64-linux-tdep.c
9106 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9107 section.
9108 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9109
17e116a7
AH
91102019-03-22 Alan Hayward <alan.hayward@arm.com>
9111 Jiong Wang <jiong.wang@arm.com>
9112
9113 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9114 instructions.
9115 (aarch64_analyze_prologue_test): Add PACIASP test.
9116 (aarch64_prologue_prev_register): Unmask PC value.
9117
11e1b75f
AH
91182019-03-22 Alan Hayward <alan.hayward@arm.com>
9119 Jiong Wang <jiong.wang@arm.com>
9120
9121 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9122 (aarch64_dwarf2_prev_register): Unmask PC value.
9123 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9124 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9125 DW_CFA_AARCH64_negate_ra_state.
9126 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9127
34dcc7cf
AH
91282019-03-22 Alan Hayward <alan.hayward@arm.com>
9129 Jiong Wang <jiong.wang@arm.com>
9130
9131 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9132 registers.
9133 (aarch64_pseudo_register_name): Likewise.
9134 (aarch64_pseudo_register_type): Likewise.
9135 (aarch64_pseudo_register_reggroup_p): Likewise.
9136 (aarch64_gdbarch_init): Add pauth registers.
9137 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9138 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9139 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9140 (struct gdbarch_tdep): Add regnum for ra_state.
9141
1ef53e6b
AH
91422019-03-22 Alan Hayward <alan.hayward@arm.com>
9143 Jiong Wang <jiong.wang@arm.com>
9144
9145 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9146
76bed0fd
AH
91472019-03-22 Alan Hayward <alan.hayward@arm.com>
9148 Jiong Wang <jiong.wang@arm.com>
9149
9150 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9151 function.
9152 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9153 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9154 (aarch64_gdbarch_init): Add puth registers.
9155 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9156 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9157 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9158
ee4fbcfa
AH
91592019-03-22 Alan Hayward <alan.hayward@arm.com>
9160 Jiong Wang <jiong.wang@arm.com>
9161
9162 * aarch64-linux-nat.c
9163 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9164 * aarch64-linux-tdep.c
9165 (aarch64_linux_core_read_description): Likewise.
9166 (aarch64_linux_get_hwcap): New function.
9167 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9168 (aarch64_linux_get_hwcap): New declaration.
9169
6dc0ebde
AH
91702019-03-22 Alan Hayward <alan.hayward@arm.com>
9171 Jiong Wang <jiong.wang@arm.com>
9172
9173 * aarch64-linux-nat.c
9174 (aarch64_linux_nat_target::read_description): Add pauth param.
9175 * aarch64-linux-tdep.c
9176 (aarch64_linux_core_read_description): Likewise.
9177 * aarch64-tdep.c (struct target_desc): Add in pauth.
9178 (aarch64_read_description): Add pauth param.
9179 (aarch64_gdbarch_init): Likewise.
9180 * aarch64-tdep.h (aarch64_read_description): Likewise.
9181 * arch/aarch64.c (aarch64_create_target_description): Likewise.
9182 * arch/aarch64.h (aarch64_create_target_description): Likewise.
9183 * features/Makefile: Add new files.
9184 * features/aarch64-pauth.c: New file.
9185 * features/aarch64-pauth.xml: New file.
9186
595915c1
TT
91872019-03-20 Tom Tromey <tromey@adacore.com>
9188
9189 * infrun.c (handle_inferior_event): Rename from
9190 handle_inferior_event_1. Create a scoped_value_mark.
9191 (handle_inferior_event): Remove.
9192
4c7d57e7
TT
91932019-03-19 Tom Tromey <tromey@adacore.com>
9194
9195 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9196 * infrun.h (print_stop_event): Add "displays" parameter.
9197 * infrun.c (print_stop_event): Add "displays" parameter.
9198
cb246234
PA
91992019-03-19 Pedro Alves <palves@redhat.com>
9200
9201 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9202 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
9203 to -1. Fix TABs vs spaces.
9204 (tui_ui_out::tui_ui_out): Don't initialize fields here.
9205 * tui/tui-out.h (tui_ui_out) Add intro comments.
9206 <m_line, m_start_of_line>: In-class initialize, and add describing
9207 comment.
9208
3a0e45b2
AH
92092019-03-18 Alan Hayward <alan.hayward@arm.com>
9210
9211 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9212 variable names.
9213 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9214
5371b850
PA
92152019-03-18 Pedro Alves <palves@redhat.com>
9216 Eli Zaretskii <eliz@gnu.org>
9217
9218 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9219 m_line and m_start_of_line.
9220
b17c4cd0
EZ
92212019-03-18 Eli Zaretskii <eliz@gnu.org>
9222
9223 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9224 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9225 it returns a newline. This fixes a regression in TU mode, whereby
9226 the next line is output on the same screen line as the user input.
9227
4bd56d18
TT
92282019-03-18 Tom Tromey <tromey@adacore.com>
9229
9230 * minsyms.c (minimal_symbol_reader::install): Remove call to
9231 obstack_blank.
9232
55c10aca
PA
92332019-03-18 Pedro Alves <palves@redhat.com>
9234
9235 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9236 New globals.
9237 (apply_style): New, factored out from ...
9238 (apply_ansi_escape): ... this. Handle reverse video mode.
9239 (tui_set_reverse_mode): New function.
9240 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9241 * tui/tui-winsource.c (tui_show_source_line): Use
9242 tui_set_reverse_mode instead of setting A_STANDOUT.
9243 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9244 New setter methods.
9245
647bb750
HD
92462019-03-18 Hannes Domani <ssbssa@yahoo.de>
9247
9248 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9249 Handle tabs.
9250
bff8c71f
TT
92512019-03-18 Tom Tromey <tromey@adacore.com>
9252
9253 * ada-lang.c (empty_array): Add "high" parameter.
9254 (ada_evaluate_subexp): Update.
9255
58785d98
ST
92562019-03-17 Sergei Trofimovich <siarheit@google.com>
9257
9258 * unittests/string_view-selftests.c: Define
9259 _initialize_string_view_selftests unconditionally.
9260
d4cbef22
ВМ
92612019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9262
9263 PR gdb/24350
9264 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9265
fce4c071
ВМ
92662019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9267
9268 PR gdb/24351
9269 * windows-nat.c (display_selector): Fix format specifiers.
9270
f7f0a123
EZ
92712019-03-17 Eli Zaretskii <eliz@gnu.org>
9272
9273 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9274 tui_refill_source_window instead of tui_refresh_win, to update the
9275 current execution line. This fixes redisplay of the current line
9276 when stepping through the code with "next" or "step".
9277
ab42892f
EZ
92782019-03-16 Eli Zaretskii <eliz@gnu.org>
9279
9280 * source-cache.c (source_cache::get_source_lines): Call
9281 find_source_lines to initialize s->nlines. This fixes vertical
9282 scrolling of TUI source window when the DOWN arrow is pressed.
9283
8d8c087f
PW
92842019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9285
9286 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9287 linux-thread-db.c (_initialize_thread_db): Likewise.
9288
798e1c30
EZ
92892019-03-16 Eli Zaretskii <eliz@gnu.org>
9290
9291 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9292 wclrtoeol in tui_show_source_line". This reverts changes made in
9293 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9294
eefba3da
TT
92952019-03-15 Tom Tromey <tom@tromey.com>
9296
9297 * symtab.h (struct minimal_symbol): Derive from
9298 general_symbol_info.
9299 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9300 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9301 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9302 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9303 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9304 (MSYMBOL_SEARCH_NAME): Update.
9305 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9306 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9307 * minsyms.c (minimal_symbol_reader::record_full): Update.
9308
0de2420c
TT
93092019-03-15 Tom Tromey <tom@tromey.com>
9310
9311 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9312
042d75e4
TT
93132019-03-15 Tom Tromey <tom@tromey.com>
9314
9315 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9316 unique_xmalloc_ptr.
9317 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9318 Update.
9319 * minsyms.c (lookup_minimal_symbol_by_pc_section)
9320 (build_minimal_symbol_hash_tables)
9321 (minimal_symbol_reader::install): Update.
9322
db92718b
TT
93232019-03-15 Tom Tromey <tom@tromey.com>
9324
9325 * symtab.c (create_demangled_names_hash): Update.
9326 (symbol_set_names): Update.
9327 * objfiles.h (struct objfile_per_bfd_storage)
9328 <demangled_names_hash>: Now an htab_up.
9329 * objfiles.c (objfile_per_bfd_storage): Simplify.
9330
d6797f46
TT
93312019-03-15 Tom Tromey <tom@tromey.com>
9332
9333 * objfiles.h (struct objfile_per_bfd_storage): Declare
9334 destructor.
9335 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9336 New.
9337 (get_objfile_bfd_data): Use new. Don't initialize
9338 language_of_main.
9339 (free_objfile_per_bfd_storage): Remove.
9340 (objfile_bfd_data_free, objfile::~objfile): Use delete.
9341
741d7538
TT
93422019-03-15 Tom Tromey <tom@tromey.com>
9343
9344 * symfile.c (reread_symbols): Update.
9345 * objfiles.c (objfile::objfile): Update.
9346 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9347 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9348 comment.
9349 (minimal_symbol_reader::install): Update.
9350 (terminate_minimal_symbol_table): Remove.
9351 * jit.c (jit_object_close_impl): Update.
9352
788c80d1
TT
93532019-03-15 Tom Tromey <tom@tromey.com>
9354
9355 * minsyms.c (minimal_symbol_reader::record_full): Remove some
9356 initializations.
9357
1b7a07cb
TT
93582019-03-15 Tom Tromey <tom@tromey.com>
9359
9360 * objfiles.h (struct objfile_per_bfd_storage)
9361 <demangled_hash_languages>: Now a bitset.
9362 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9363 (lookup_minimal_symbol): Update.
9364
3db066bc
TT
93652019-03-15 Tom Tromey <tom@tromey.com>
9366
9367 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9368 Don't return the symbol.
9369 * coffread.c (record_minimal_symbol): Use record_full.
9370
3fff2c37
EZ
93712019-03-14 Eli Zaretskii <eliz@gnu.org>
9372
9373 The MS-Windows port of ncurses fails to switch to a color pair if
9374 one or both of the colors are the implicit default colors. This
9375 change records the default colors when TUI is initialized, and
9376 then specifies them explicitly when a color pair uses the default
9377 colors. This allows color styling in TUI mode on MS-Windows.
9378
9379 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
9380 ncurses_norm_attr.
9381 (tui_initialize_io) [__MINGW32__]: Record the default terminal
9382 colors in ncurses_norm_attr.
9383 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9384 "none", replace it with the default color recorded in
9385 ncurses_norm_attr.
9386
3b336828
TT
93872019-03-14 Tom Tromey <tromey@adacore.com>
9388
9389 * source-cache.h (class source_cache) <get_source_lines>: Return
9390 std::string.
9391 * source-cache.c (source_cache::extract_lines): Handle case where
9392 first_pos==npos. Return std::string.
9393 (source_cache::get_source_lines): Update.
9394
d085f989
TT
93952019-03-14 Tom Tromey <tromey@adacore.com>
9396
9397 * NEWS: Add item for "style sources" commands.
9398 * source-cache.c (source_cache::get_source_lines): Check
9399 source_styling.
9400 * cli/cli-style.c (source_styling): New global.
9401 (_initialize_cli_style): Add "style sources" commands.
9402 (show_style_sources): New function.
9403 * cli/cli-style.h (source_styling): Declare.
9404
6f11e682
TT
94052019-03-14 Pedro Alves <palves@redhat.com>
9406 Tom Tromey <tromey@adacore.com>
9407
9408 * tui/tui-winsource.h (tui_refill_source_window): Declare.
9409 * tui/tui-winsource.c (tui_refill_source_window): New function,
9410 from...
9411 (tui_horizontal_source_scroll): ... here. Move some logic.
9412 * cli/cli-style.c (set_style_enabled): Notify new observable.
9413 * tui/tui-hooks.c (tui_redisplay_source): New function.
9414 (tui_attach_detach_observers): Attach or detach
9415 tui_redisplay_source.
9416 * observable.h (source_styling_changed): New observable.
9417 * observable.c: Define source_styling_changed observable.
9418
a068643d
TT
94192019-03-13 Tom Tromey <tromey@adacore.com>
9420
9421 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9422 (i386_gnu_nat_target::store_registers): Update.
9423 * target-debug.h (target_debug_print_std_string): New macro.
9424 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9425 * windows-tdep.c (display_one_tib): Update.
9426 * tui/tui-stack.c (tui_make_status_line): Update.
9427 * top.c (print_inferior_quit_action): Update.
9428 * thread.c (thr_try_catch_cmd): Update.
9429 (add_thread_with_info): Update.
9430 (thread_target_id_str): Update.
9431 (thr_try_catch_cmd): Update.
9432 (thread_command): Update.
9433 (thread_find_command): Update.
9434 * record-btrace.c (record_btrace_target::info_record)
9435 (record_btrace_resume_thread, record_btrace_target::resume)
9436 (record_btrace_cancel_resume, record_btrace_step_thread)
9437 (record_btrace_target::wait, record_btrace_target::wait)
9438 (record_btrace_target::wait, record_btrace_target::stop): Update.
9439 * progspace.c (print_program_space): Update.
9440 * process-stratum-target.c
9441 (process_stratum_target::thread_address_space): Update.
9442 * linux-fork.c (linux_fork_mourn_inferior)
9443 (detach_checkpoint_command, info_checkpoints_command)
9444 (linux_fork_context): Update.
9445 (linux_fork_detach): Update.
9446 (class scoped_switch_fork_info): Update.
9447 (delete_checkpoint_command): Update.
9448 * infrun.c (follow_fork_inferior): Update.
9449 (follow_fork_inferior): Update.
9450 (proceed_after_vfork_done): Update.
9451 (handle_vfork_child_exec_or_exit): Update.
9452 (follow_exec): Update.
9453 (displaced_step_prepare_throw): Update.
9454 (displaced_step_restore): Update.
9455 (start_step_over): Update.
9456 (resume_1): Update.
9457 (clear_proceed_status_thread): Update.
9458 (proceed): Update.
9459 (print_target_wait_results): Update.
9460 (do_target_wait): Update.
9461 (context_switch): Update.
9462 (stop_all_threads): Update.
9463 (restart_threads): Update.
9464 (finish_step_over): Update.
9465 (handle_signal_stop): Update.
9466 (switch_back_to_stepped_thread): Update.
9467 (keep_going_pass_signal): Update.
9468 (print_exited_reason): Update.
9469 (normal_stop): Update.
9470 * inferior.c (inferior_pid_to_str): Change return type.
9471 (print_selected_inferior): Update.
9472 (add_inferior): Update.
9473 (detach_inferior): Update.
9474 * dummy-frame.c (fprint_dummy_frames): Update.
9475 * dcache.c (dcache_info_1): Update.
9476 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9477 (btrace_fetch, btrace_clear): Update.
9478 * linux-tdep.c (linux_core_pid_to_str): Change return type.
9479 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9480 type.
9481 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9482 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9483 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9484 * gdbarch.c, gdbarch.h: Rebuild.
9485 * gdbarch.sh (core_pid_to_str): Change return type.
9486 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9487 return type.
9488 (windows_nat_target::pid_to_str): Change return type.
9489 (windows_delete_thread): Update.
9490 (windows_nat_target::attach): Update.
9491 (windows_nat_target::files_info): Update.
9492 * target-delegates.c: Rebuild.
9493 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9494 return type.
9495 (sol_thread_target::pid_to_str): Change return type.
9496 * remote.c (class remote_target) <pid_to_str>: Change return
9497 type.
9498 (remote_target::pid_to_str): Change return type.
9499 (extended_remote_target::attach, remote_target::remote_stop_ns)
9500 (remote_target::remote_notif_remove_queued_reply)
9501 (remote_target::push_stop_reply, remote_target::disable_btrace):
9502 Update.
9503 (extended_remote_target::attach): Update.
9504 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9505 type.
9506 (gdbsim_target::pid_to_str): Change return type.
9507 * ravenscar-thread.c (struct ravenscar_thread_target)
9508 <pid_to_str>: Change return type.
9509 (ravenscar_thread_target::pid_to_str): Change return type.
9510 * procfs.c (class procfs_target) <pid_to_str>: Change return
9511 type.
9512 (procfs_target::pid_to_str): Change return type.
9513 (procfs_target::attach): Update.
9514 (procfs_target::detach): Update.
9515 (procfs_target::fetch_registers): Update.
9516 (procfs_target::store_registers): Update.
9517 (procfs_target::wait): Update.
9518 (procfs_target::files_info): Update.
9519 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9520 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9521 return type.
9522 (nto_procfs_target::pid_to_str): Change return type.
9523 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9524 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9525 return type.
9526 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9527 (exit_lwp): Update.
9528 (attach_proc_task_lwp_callback, get_detach_signal)
9529 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9530 (linux_nat_target::resume, wait_lwp, stop_callback)
9531 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9532 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9533 (linux_nat_wait_1, resume_stopped_resumed_lwps)
9534 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9535 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9536 type.
9537 (inf_ptrace_target::attach): Update.
9538 (inf_ptrace_target::files_info): Update.
9539 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9540 type.
9541 (go32_nat_target::pid_to_str): Change return type.
9542 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9543 (gnu_nat_target::wait): Update.
9544 (gnu_nat_target::wait): Update.
9545 (gnu_nat_target::resume): Update.
9546 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9547 (fbsd_nat_target::wait): Update.
9548 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9549 type.
9550 (darwin_nat_target::attach): Update.
9551 * corelow.c (class core_target) <pid_to_str>: Change return type.
9552 (core_target::pid_to_str): Change return type.
9553 * target.c (normal_pid_to_str): Change return type.
9554 (default_pid_to_str): Likewise.
9555 (target_pid_to_str): Change return type.
9556 (target_translate_tls_address): Update.
9557 (target_announce_detach): Update.
9558 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9559 return type.
9560 (bsd_uthread_target::pid_to_str): Change return type.
9561 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9562 type.
9563 (bsd_kvm_target::pid_to_str): Change return type.
9564 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9565 return type.
9566 (aix_thread_target::pid_to_str): Change return type.
9567 * target.h (struct target_ops) <pid_to_str>: Change return type.
9568 (target_pid_to_str, normal_pid_to_str): Likewise.
9569 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9570 type.
9571 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9572 type.
9573 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9574 return type.
9575 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9576 type.
9577 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9578 type.
9579 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9580 return type.
9581
b4be1b06
SM
95822019-03-13 Simon Marchi <simon.marchi@ericsson.com>
9583
9584 * NEWS: Mention that the new default MI version is 3. Mention
9585 changes to the output of commands and events that deal with
9586 multi-location breakpoints.
9587 * breakpoint.c: Include "mi/mi-out.h".
9588 (print_one_breakpoint): Change output syntax if using MI version
9589 >= 3.
9590 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9591 New.
9592 (mi_multi_location_breakpoint_output_fixed): New.
9593 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9594 (mi_cmd_fix_multi_location_breakpoint_output): New.
9595 (mi_multi_location_breakpoint_output_fixed): New.
9596 * mi/mi-cmds.c (mi_cmds): Register command
9597 -fix-multi-location-breakpoint-output.
9598 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9599 interpreter "mi".
9600
8e5e5494
SM
96012019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9602
9603 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9604 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9605 instantiate mi_ui_out based on interpreter name.
9606 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9607 * mi/mi-main.c (mi_load_progress): Likewise.
9608
197df35e
JB
96092019-03-12 John Baldwin <jhb@FreeBSD.org>
9610
9611 * NEWS: Combine separate "New targets" sections for 8.3.
9612
8399425f
JB
96132019-03-12 John Baldwin <jhb@FreeBSD.org>
9614
9615 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9616 (ppcfbsd_init_abi): Install gdbarch
9617 "fetch_tls_load_module_address" and "get_thread_local_address"
9618 methods.
9619
b0f87ed0
JB
96202019-03-12 John Baldwin <jhb@FreeBSD.org>
9621
9622 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9623 (riscv_fbsd_init_abi): Install gdbarch
9624 "fetch_tls_load_module_address" and "get_thread_local_address"
9625 methods.
9626
ce25aa57
JB
96272019-03-12 John Baldwin <jhb@FreeBSD.org>
9628
9629 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9630 (i386fbsd_init_abi): Install gdbarch
9631 "fetch_tls_load_module_address" and "get_thread_local_address"
9632 methods.
9633
f5424cfa
JB
96342019-03-12 John Baldwin <jhb@FreeBSD.org>
9635
9636 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9637 (amd64fbsd_init_abi): Install gdbarch
9638 "fetch_tls_load_module_address" and "get_thread_local_address"
9639 methods.
9640
945f3901
JB
96412019-03-12 John Baldwin <jhb@FreeBSD.org>
9642
9643 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9644 (struct fbsd_pspace_data): New type.
9645 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9646 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9647 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9648 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9649 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9650
ef0bd204
JB
96512019-03-12 John Baldwin <jhb@FreeBSD.org>
9652
9653 * gdbtypes.c (lookup_struct_elt): New function.
9654 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9655 * gdbtypes.h (struct struct_elt): New type.
9656 (lookup_struct_elt): New prototype.
9657
36c53a02
JB
96582019-03-12 John Baldwin <jhb@FreeBSD.org>
9659
9660 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9661 remove disabled code block.
9662
6e056c81
JB
96632019-03-12 John Baldwin <jhb@FreeBSD.org>
9664
9665 * gdbarch.sh (get_thread_local_address): New method.
9666 * gdbarch.h, gdbarch.c: Regenerate.
9667 * target.c (target_translate_tls_address): Use
9668 gdbarch_get_thread_local_address if present instead of
9669 target::get_thread_local_address.
9670
cd250a18
JB
96712019-03-12 John Baldwin <jhb@FreeBSD.org>
9672
9673 * target.h (target::get_thread_local_address): Update comment.
9674
df22c1e5
JB
96752019-03-12 John Baldwin <jhb@FreeBSD.org>
9676
9677 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9678 objfile->separate_debug_objfile_backlink if not NULL.
9679
dd6876c9
JB
96802019-03-12 John Baldwin <jhb@FreeBSD.org>
9681
9682 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9683 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9684 (amd64bsd_store_inferior_registers): Likewise.
9685 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9686 Enable segment base registers.
9687 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9688 PT_GETFSBASE and PT_GETGSBASE.
9689 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9690 PT_SETGSBASE.
9691 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9692 segment base registers.
9693 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9694
1163a4b7
JB
96952019-03-12 John Baldwin <jhb@FreeBSD.org>
9696
9697 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9698 Update calls to i386_target_description to add 'segments'
9699 parameter.
9700 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9701 add segment base registers.
9702 * arch/i386.c (i386_create_target_description): Add 'segments'
9703 parameter to enable segment base registers.
9704 * arch/i386.h (i386_create_target_description): Likewise.
9705 * features/i386/32bit-segments.xml: New file.
9706 * features/i386/32bit-segments.c: Generate.
9707 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9708 call to i386_target_description to add 'segments' parameter.
9709 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9710 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9711 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9712 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9713 if feature is present.
9714 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9715 Add 'segments' parameter to call to i386_target_description.
9716 (i386_target_description): Add 'segments' parameter to enable
9717 segment base registers.
9718 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9719 to call to i386_target_description.
9720 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9721 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9722 Define I386_NUM_REGS.
9723 (i386_target_description): Add 'segments' parameter to enable
9724 segment base registers.
9725
3a350822
EZ
97262019-03-12 Eli Zaretskii <eliz@gnu.org>
9727
9728 PR/24325
9729 * source-cache.c: #undef open and close, to avoid unresolved
9730 externals during linking.
9731
ffdd69cf
TT
97322019-03-12 Tom Tromey <tromey@adacore.com>
9733
9734 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9735 const. Add initializers.
9736 (_initialize_remote): Don't initialize ptid globals.
9737
ec148c57
PA
97382019-03-12 Pedro Alves <palves@redhat.com>
9739
9740 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9741
32764270
PA
97422019-03-12 Pedro Alves <palves@redhat.com>
9743
9744 * cp-name-parser.y (main): Remove unused 'len' variable.
9745
17547186
TT
97462019-03-12 Tom Tromey <tromey@adacore.com>
9747
9748 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9749 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9750
d3a70e03
TT
97512019-03-12 Tom Tromey <tromey@adacore.com>
9752
9753 * linux-nat.c (iterate_over_lwps): Update.
9754 (stop_callback): Remove parameter.
9755 (stop_wait_callback, detach_callback, resume_set_callback)
9756 (select_singlestep_lwp_callback, set_ignore_sigint)
9757 (status_callback, resumed_callback, resume_clear_callback)
9758 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9759 data parameter.
9760 (linux_nat_target::detach, linux_nat_target::resume)
9761 (linux_stop_and_wait_all_lwps, select_event_lwp)
9762 (linux_nat_filter_event, linux_nat_wait_1)
9763 (linux_nat_target::kill, linux_nat_target::stop)
9764 (linux_nat_target::stop): Update.
9765 (linux_nat_resume_callback): Change type.
9766 (resume_stopped_resumed_lwps, count_events_callback)
9767 (select_event_lwp_callback): Likewise.
9768 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9769 * arm-linux-nat.c (struct update_registers_data): Remove.
9770 (update_registers_callback): Change type.
9771 (arm_linux_insert_hw_breakpoint1): Update.
9772 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9773 parameter.
9774 (x86_linux_dr_set_addr): Update.
9775 (x86_linux_dr_set_control): Update.
9776 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9777 (iterate_over_lwps): Use gdb::function_view.
9778 * nat/aarch64-linux-hw-point.c (struct
9779 aarch64_dr_update_callback_param): Remove.
9780 (debug_reg_change_callback): Change type.
9781 (aarch64_notify_debug_reg_change): Update.
9782 * s390-linux-nat.c (s390_refresh_per_info): Update.
9783
82cb27ff
TT
97842019-03-11 Tom Tromey <tromey@adacore.com>
9785
9786 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9787 redundant assignment to "this_cu".
9788
568c0683
SM
97892019-03-08 Simon Marchi <simon.marchi@efficios.com>
9790
9791 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9792
f09ce22d
SM
97932019-03-08 Simon Marchi <simon.marchi@efficios.com>
9794
9795 * gdbtypes.c (rank_one_type_parm_set): New function extracted
9796 from...
9797 (rank_one_type): ... this.
9798
595f96a9
SM
97992019-03-08 Simon Marchi <simon.marchi@efficios.com>
9800
9801 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9802 from...
9803 (rank_one_type): ... this.
9804
2598a94b
SM
98052019-03-08 Simon Marchi <simon.marchi@efficios.com>
9806
9807 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9808 from...
9809 (rank_one_type): ... this.
9810
7f17b20d
SM
98112019-03-08 Simon Marchi <simon.marchi@efficios.com>
9812
9813 * gdbtypes.c (rank_one_type_parm_float): New function extracted
9814 from...
9815 (rank_one_type): ... this.
9816
2c509035
SM
98172019-03-08 Simon Marchi <simon.marchi@efficios.com>
9818
9819 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9820 from...
9821 (rank_one_type): ... this.
9822
0dd322dc
SM
98232019-03-08 Simon Marchi <simon.marchi@efficios.com>
9824
9825 * gdbtypes.c (rank_one_type_parm_range): New function extracted
9826 from...
9827 (rank_one_type): ... this.
9828
41ea4728
SM
98292019-03-08 Simon Marchi <simon.marchi@efficios.com>
9830
9831 * gdbtypes.c (rank_one_type_parm_char): New function extracted
9832 from...
9833 (rank_one_type): ... this.
9834
793cd1d2
SM
98352019-03-08 Simon Marchi <simon.marchi@efficios.com>
9836
9837 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9838 from...
9839 (rank_one_type): ... this.
9840
34910087
SM
98412019-03-08 Simon Marchi <simon.marchi@efficios.com>
9842
9843 * gdbtypes.c (rank_one_type_parm_int): New function extracted
9844 from...
9845 (rank_one_type): ... this.
9846
f1f832d6
SM
98472019-03-08 Simon Marchi <simon.marchi@efficios.com>
9848
9849 * gdbtypes.c (rank_one_type_parm_func): New function extracted
9850 from...
9851 (rank_one_type): ... this.
9852
b9f4512f
SM
98532019-03-08 Simon Marchi <simon.marchi@efficios.com>
9854
9855 * gdbtypes.c (rank_one_type_parm_array): New function extracted
9856 from...
9857 (rank_one_type): ... this.
9858
9293fc63
SM
98592019-03-08 Simon Marchi <simon.marchi@efficios.com>
9860
9861 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9862 from...
9863 (rank_one_type): ... this.
9864
e3abbe7e
PW
98652019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9866
9867 * inferior.c (initialize_inferiors): Ensure 'help set/show print
9868 inferior-events' shows the example events.
9869
e4adb939
EZ
98702019-03-08 Eli Zaretskii <eliz@gnu.org>
9871
9872 Support styling on native MS-Windows console
9873
9874 PR/24315
9875 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9876 on MS-Windows if $TERM is not defined.
9877
9878 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9879
9880 * posix-hdep.c (gdb_console_fputs):
9881 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9882 functions.
9883 * ui-file.h (gdb_console_fputs): Add prototype.
9884
9885 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9886 back to fputs only if the former returns zero.
9887
25629dfd
TT
98882019-03-07 Tom Tromey <tom@tromey.com>
9889
9890 * symmisc.c (print_symbol_bcache_statistics): Update.
9891 (print_objfile_statistics): Update.
9892 * symfile.c (allocate_symtab): Update.
9893 * stabsread.c: Don't include bcache.h.
9894 * psymtab.h (struct psymbol_bcache): Don't declare.
9895 (class psymtab_storage) <psymbol_cache>: Now a bcache.
9896 (psymbol_bcache_init, psymbol_bcache_free)
9897 (psymbol_bcache_get_bcache): Don't declare.
9898 * psymtab.c (struct psymbol_bcache): Remove.
9899 (psymtab_storage::psymtab_storage): Update.
9900 (psymtab_storage::~psymtab_storage): Update.
9901 (psymbol_bcache_init, psymbol_bcache_free)
9902 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9903 (add_psymbol_to_bcache): Update.
9904 (allocate_psymtab): Update.
9905 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9906 macro_cache>: No longer pointers.
9907 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9908 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9909 * macrotab.c (macro_bcache): Update.
9910 * macroexp.c: Don't include bcache.h.
9911 * gdbtypes.c (check_types_worklist): Update.
9912 (types_deeply_equal): Remove TRY/CATCH. Update.
9913 * elfread.c (elf_symtab_read): Update.
9914 * dwarf2read.c: Don't include bcache.h.
9915 * buildsym.c (buildsym_compunit::get_macro_table): Update.
9916 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9917 (print_bcache_statistics, bcache_memory_used): Don't declare.
9918 (struct bcache): Move from bcache.c. Add constructor, destructor,
9919 methods. Rename all data members.
9920 * bcache.c (struct bcache): Move to bcache.h.
9921 (bcache::expand_hash_table): Rename from expand_hash_table.
9922 (bcache): Remove.
9923 (bcache::insert): Rename from bcache_full.
9924 (bcache::compare): Rename from bcache_compare.
9925 (bcache_xmalloc): Remove.
9926 (bcache::~bcache): Rename from bcache_xfree.
9927 (bcache::print_statistics): Rename from print_bcache_statistics.
9928 (bcache::memory_used): Rename from bcache_memory_used.
9929
fe726667
PA
99302019-03-07 Pedro Alves <palves@redhat.com>
9931
9932 * infrun.c (normal_stop): Also check for
9933 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9934
7584bb30
AB
99352019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
9936
9937 * f-lang.c (value_from_host_double): Moved to...
9938 * value.c (value_from_host_double): ...here.
9939 * value.h (value_from_host_double): Declare.
9940 * guile/scm-math.c (vlscm_convert_typed_number): Use
9941 value_from_host_double.
9942 (vlscm_convert_number): Likewise.
9943 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9944 * python/py-value.c (convert_value_from_python): Likewise.
9945
a7b1986e
TT
99462019-03-06 Tom Tromey <tom@tromey.com>
9947
9948 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9949
0ccf4211
TT
99502019-03-06 Tom Tromey <tom@tromey.com>
9951
9952 * utils.h (free_current_contents): Don't declare.
9953 * utils.c (free_current_contents): Remove.
9954
fe7b42e5
TT
99552019-03-06 Tom Tromey <tom@tromey.com>
9956
9957 * top.c (quit_force): Update.
9958 * main.c (captured_command_loop): Update.
9959 * common/new-op.c (operator new): Update.
9960 * common/common-exceptions.c (struct catcher)
9961 <save_cleanup_chain>: Remove member.
9962 (exceptions_state_mc_init): Update.
9963 (exception_try_scope_entry): Return nullptr.
9964 (exception_try_scope_exit, exception_rethrow)
9965 (throw_exception_sjlj, throw_exception_cxx): Update.
9966 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9967 (all_cleanups, do_cleanups, discard_cleanups)
9968 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9969 (restore_cleanups, restore_final_cleanups): Don't declare.
9970 (do_final_cleanups): Remove parameter.
9971 * common/cleanups.c (cleanup_chain, make_cleanup)
9972 (make_cleanup_dtor, all_cleanups, do_cleanups)
9973 (discard_my_cleanups, discard_cleanups)
9974 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9975 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9976 (null_cleanup): Remove.
9977 (do_final_cleanups): Remove parameter.
9978
c6321f19
TT
99792019-03-06 Tom Tromey <tom@tromey.com>
9980
9981 * remote.c (remote_target::remote_parse_stop_reply): Use
9982 unique_xmalloc_ptr.
9983
61b30099
TT
99842019-03-06 Tom Tromey <tom@tromey.com>
9985
9986 * stabsread.c (struct stabs_field_info): Rename from field_info.
9987 <list, fnlist>: Add initializers.
9988 <obstack>: New member.
9989 (read_member_functions, read_struct_fields, read_baseclasses):
9990 Allocate on obstack. Don't use cleanups.
9991 (read_one_struct_field, read_member_functions, read_struct_fields)
9992 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9993 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9994 (read_struct_type): Update.
9995
6cceac94
TT
99962019-03-06 Tom Tromey <tom@tromey.com>
9997
9998 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9999 * common/filestuff.h (make_cleanup_close): Don't declare.
10000 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10001 Remove.
10002
72412762
TT
100032019-03-06 Tom Tromey <tom@tromey.com>
10004
10005 * solib-aix.c: Use make_scope_exit.
10006
2b6ff1c0
TT
100072019-03-06 Tom Tromey <tom@tromey.com>
10008
10009 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10010 Use make_scope_exit.
10011
d01c5877
TT
100122019-03-06 Tom Tromey <tom@tromey.com>
10013
10014 * solib-svr4.c (disable_probes_interface): Remove parameter.
10015 (svr4_handle_solib_event): Use make_scope_exit.
10016
32603266
TT
100172019-03-06 Tom Tromey <tom@tromey.com>
10018
10019 * remote.c (struct stop_reply_deleter): Remove.
10020 (stop_reply_up): Update.
10021 (struct stop_reply): Derive from notif_event. Don't typedef.
10022 <regcache>: Now a std::vector.
10023 (stop_reply_xfree): Remove.
10024 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10025 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10026 (remote_target::discard_pending_stop_replies): Use delete.
10027 (remote_target::remote_parse_stop_reply): Update.
10028 (remote_target::process_stop_reply): Update.
10029 * remote-notif.h (struct notif_event): Add virtual destructor.
10030 Remove "dtr" member.
10031 (struct notif_client) <alloc_event>: Return a unique_ptr.
10032 (notif_event_xfree): Don't declare.
10033 (notif_event_up): New typedef.
10034 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10035 (notif_event_xfree, do_notif_event_xfree): Remove.
10036 (remote_notif_state_xfree): Update.
10037
9799571e
TT
100382019-03-06 Tom Tromey <tom@tromey.com>
10039
10040 * infrun.c (displaced_step_clear_cleanup): Now a
10041 forward_scope_exit type.
10042 (displaced_step_prepare_throw): Update.
10043 (displaced_step_fixup): Update.
10044
09e3c4ca
TT
100452019-03-06 Tom Tromey <tom@tromey.com>
10046
10047 * inferior.h (class inferior): Update comment.
10048 * gdbthread.h (class thread_info): Update comment.
10049
e2a03548
TT
100502019-03-06 Joel Brobecker <brobecker@adacore.com>
10051 Tom Tromey <tom@tromey.com>
10052
10053 * stabsread.h (struct stab_section_list): Remove.
10054 (coffstab_build_psymtabs): Update.
10055 * dbxread.c (symbuf_sections): Now a std::vector.
10056 (sect_idx): New global.
10057 (fill_symbuf): Update.
10058 (coffstab_build_psymtabs): Change type of stabsects parameter.
10059 Update.
10060 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10061 std::vector.
10062 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10063 (coff_locate_sections): Update.
10064 (coff_symfile_read): Remove cleanups. Update.
10065 (init_stringtab): Add storage parameter.
10066 (free_stringtab, free_stringtab_cleanup): Remove.
10067 (init_lineno): Add storage parameter.
10068 (free_linetab, free_linetab_cleanup): Remove.
10069
b7e60d85
PA
100702019-03-06 Pedro Alves <palves@redhat.com>
10071
10072 * linux-fork.c (fork_info::clobber_regs): Delete.
10073 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10074 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10075 comment. Adjust.
10076 (scoped_switch_fork_info::scoped_switch_fork_info)
10077 (checkpoint_command, linux_fork_context): Adjust
10078 fork_save_infrun_state calls.
10079
e52c971f
PA
100802019-03-06 Pedro Alves <palves@redhat.com>
10081
10082 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10083 (inf_has_multiple_threads): Return 'bool' and rewrite using
10084 inferior_info::threads().
10085
06974e6c
PA
100862019-03-06 Pedro Alves <palves@redhat.com>
10087
10088 * linux-fork.c: Include <list>.
10089 (fork_list): Now a std::list instance.
10090 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10091 (forks_exist_p, find_last_fork): Adjust.
10092 (new_fork): Delete.
10093 (one_fork_p): New.
10094 (add_fork): Adjust.
10095 (free_fork): Delete, folded into fork_info::~fork_info().
10096 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10097 Adjust.
10098 (init_fork_list): Delete.
10099 (linux_fork_killall, linux_fork_mourn_inferior)
10100 (linux_fork_detach, info_checkpoints_command): Adjust.
10101 (_initialize_linux_fork): No longer call init_fork_list.
10102
72f31aea
PA
101032019-03-06 Pedro Alves <palves@redhat.com>
10104
10105 * linux-fork.c (new_fork): New, split out of ...
10106 (add_fork): ... this. Return void. Move "first fork" special
10107 case from here, to ...
10108 (checkpoint_command): ... here.
10109 * linux-linux.h (add_fork): Return void.
10110
efbecbc1
AB
101112019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10112
10113 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10114
0841c79a
AB
101152019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10116 Chris January <chris.january@arm.com>
10117 David Lecomber <david.lecomber@arm.com>
10118
10119 * f-exp.y: New token, UNOP_INTRINSIC.
10120 (exp): New pattern using UNOP_INTRINSIC token.
10121 (f77_keywords): Add 'abs' keyword.
10122 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10123 (value_from_host_double): New function.
10124 (evaluate_subexp_f): Support UNOP_ABS.
10125
4a270568
AB
101262019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10127
10128 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10129 types.
10130
067630bd
AB
101312019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10132
10133 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10134 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10135 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10136
3be47f7a
AB
101372019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10138
10139 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10140
4d00f5d8
AB
101412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10142 Chris January <chris.january@arm.com>
10143
10144 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10145 * f-exp.y: Define 'KIND' token.
10146 (exp): New pattern for KIND expressions.
10147 (ptype): Handle types with a kind extension.
10148 (direct_abs_decl): Extend to spot kind extensions.
10149 (f77_keywords): Add 'kind' to the list.
10150 (push_kind_type): New function.
10151 (convert_to_kind_type): New function.
10152 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10153 * parse.c (operator_length_standard): Likewise.
10154 * parser-defs.h (enum type_pieces): Add tp_kind.
10155 * std-operator.def: Add UNOP_KIND.
10156
e454224f
AB
101572019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10158
10159 * f-exp.y (f_parse): Set yydebug.
10160
9dad4a58
AB
101612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10162
10163 * f-lang.c (evaluate_subexp_f): New function.
10164 (exp_descriptor_f): New global.
10165 (f_language_defn): Use exp_descriptor_f instead of
10166 exp_descriptor_standard.
10167
c8f91604
AB
101682019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10169
10170 * f-exp.y (struct token): Add comments.
10171 (dot_ops): Remove uppercase versions and the end marker.
10172 (f77_keywords): Likewise.
10173 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10174 entries in the dot_ops array are case insensitive, and use
10175 strncasecmp to compare strings. Also some whitespace cleanup in
10176 this area. Similar for the f77_keywords array, except entries in
10177 this list might be case sensitive.
10178
dd9f2c76
AB
101792019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10180
10181 * f-exp.y (struct f77_boolean_val): Add comments.
10182 (boolean_values): Remove uppercase versions, and end marker.
10183 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10184 and use strncasecmp to achieve case insensitivity. Additionally,
10185 perform whitespace cleanup around this code.
10186
67a3048c
TT
101872019-03-06 Tom Tromey <tromey@adacore.com>
10188
10189 * remote-sim.c (gdbsim_target_open): Use result of
10190 gdb_argv::release.
10191
aa3cfbda
RB
101922019-03-06 Richard Bunt <richard.bunt@arm.com>
10193 Dirk Schubert <dirk.schubert@arm.com>
10194 Chris January <chris.january@arm.com>
10195
10196 * eval.c (evaluate_subexp_standard): Call Fortran argument
10197 wrapping logic.
10198 * f-lang.c (struct value): A value which can be passed into a
10199 Fortran function call.
10200 (fortran_argument_convert): Wrap Fortran arguments in a pointer
10201 where appropriate.
10202 (struct type): Value ready for a Fortran function call.
10203 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10204 is needed.
10205 * f-lang.h (fortran_argument_convert): Declaration.
10206 (fortran_preserve_arg_pointer): Declaration.
10207 * infcall.c (value_arg_coerce): Call Fortran argument logic.
10208
ea38e5df
TT
102092019-03-05 Tom Tromey <tromey@adacore.com>
10210
10211 * python/py-prettyprint.c (print_string_repr): Remove #if.
10212 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10213
06b5b831
TT
102142019-03-05 Tom Tromey <tromey@adacore.com>
10215
10216 * target.c (the_dummy_target): Move later. Change type to
10217 "dummy_target".
10218 (initialize_targets): Don't initialize the_dummy_target.
10219
edbd9e45
TT
102202019-03-05 Tom Tromey <tromey@adacore.com>
10221
10222 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10223 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10224
c119e040
TT
102252019-03-05 Tom Tromey <tromey@adacore.com>
10226
10227 * windows-nat.c (windows_nat_target::attach)
10228 (windows_nat_target::detach): Don't call gdb_flush.
10229 * valprint.c (generic_val_print, val_print, val_print_string):
10230 Don't call gdb_flush.
10231 * utils.c (defaulted_query): Don't call gdb_flush.
10232 * typeprint.c (print_type_scalar): Don't call gdb_flush.
10233 * target.c (target_announce_detach): Don't call gdb_flush.
10234 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10235 * remote.c (extended_remote_target::attach): Don't call
10236 gdb_flush.
10237 * procfs.c (procfs_target::detach): Don't call gdb_flush.
10238 * printcmd.c (do_examine): Don't call gdb_flush.
10239 (info_display_command): Don't call gdb_flush.
10240 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10241 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10242 * memattr.c (info_mem_command): Don't call gdb_flush.
10243 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10244 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10245 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10246 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10247 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10248 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10249 (gnu_nat_target::detach): Don't call gdb_flush.
10250 * f-valprint.c (f_val_print): Don't call gdb_flush.
10251 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10252 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10253 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10254 gdb_flush.
10255 * c-valprint.c (c_val_print): Don't call gdb_flush.
10256 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10257
895dafa6
TT
102582019-03-05 Tom Tromey <tromey@adacore.com>
10259
10260 * varobj.c (update_dynamic_varobj_children): Update.
10261 (install_default_visualizer): Use reset, not release.
10262 * value.c (set_internalvar): Update.
10263 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10264 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10265 ATTRIBUTE_UNUSED_RESULT.
10266
88a774b9
TT
102672019-03-05 Tom Tromey <tromey@adacore.com>
10268
10269 * remote.c (class scoped_remote_fd) <release>: Add
10270 ATTRIBUTE_UNUSED_RESULT.
10271
4e4a8b93
TT
102722019-03-05 Tom Tromey <tromey@adacore.com>
10273
10274 * macroexp.c (struct macro_buffer) <release>: Add
10275 ATTRIBUTE_UNUSED_RESULT.
10276
083eef1f
TT
102772019-03-05 Tom Tromey <tromey@adacore.com>
10278
10279 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10280 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10281 ATTRIBUTE_UNUSED_RESULT.
10282
3cabd438
TT
102832019-03-05 Tom Tromey <tromey@adacore.com>
10284
10285 * common/scoped_fd.h (class scoped_fd) <release>: Add
10286 ATTRIBUTE_UNUSED_RESULT.
10287
41e3300a
TT
102882019-03-05 Tom Tromey <tromey@adacore.com>
10289
10290 * parser-defs.h (struct parser_state) <release>: Add
10291 ATTRIBUTE_UNUSED_RESULT.
10292
18cb7c9f
TT
102932019-03-05 Tom Tromey <tromey@adacore.com>
10294
10295 * utils.h (class gdb_argv) <release>: Add
10296 ATTRIBUTE_UNUSED_RESULT.
10297 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10298
41fa577f
EZ
102992019-03-02 Eli Zaretskii <eliz@gnu.org>
10300
a6a4b2c6
EZ
10301 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10302 for-loop range, to avoid compiler warnings.
10303
10304 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10305 avoid compiler warnings about unused variables.
10306
742a7df5
EZ
10307 * NEWS: Mention end of support for native debugging on MS-Windows
10308 before XP.
10309
41fa577f
EZ
10310 PR gdb/24292
10311 * common/netstuff.c:
10312 * gdbserver/gdbreplay.c
10313 * gdbserver/remote-utils.c:
10314 * ser-tcp.c:
10315 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10316 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
10317 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10318 'getaddrinfo' and 'freeaddrinfo' were not available before
10319 Windows XP, and mingw.org's MinGW headers by default define
10320 _WIN32_WINNT to 0x500.
10321
827f438f
GB
103222019-03-01 Gary Benson <gbenson@redhat.com>
10323
10324 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10325
92137da0
RO
103262019-02-28 Brian Vandenberg <phantall@gmail.com>
10327 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
10328
10329 PR gdb/8527
10330 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10331 set_sigint_trap, clear_sigint_trap.
10332
799efbe8
PW
103332019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10334
10335 * target.c (target_detach): Clear the regcache and the
10336 frame cache.
10337
8ed25214
PA
103382019-02-27 Pedro Alves <palves@redhat.com>
10339
10340 * utils.c (set_screen_size): When we cap the height/width sizes,
10341 tweak the corresponding command variable to show "unlimited":
10342
23031e31
SJ
103432019-02-27 Saagar Jha <saagar@saagarjha.com>
10344 Pedro Alves <palves@redhat.com>
10345
10346 * utils.c (set_screen_size): Reduce "infinite" rows and columns
10347 before calling rl_set_screen_size.
10348
6c28e44a
TT
103492019-02-27 Tom Tromey <tromey@adacore.com>
10350
10351 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10352 define.
10353 * python/py-value.c: Remove Python 2.4 workaround.
10354 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10355 workaround.
10356 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10357 Python 2.4 workaround.
10358 * python/python-internal.h: Remove Python 2.4 comment.
10359 (Py_ssize_t): Don't define.
10360 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10361 (gdb_Py_DECREF): Remove Python 2.4 workaround.
10362 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10363 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10364 * python/python.c (do_start_initialization): Remove Python 2.4
10365 workaround.
10366 * python/py-prettyprint.c (class dummy_python_frame): Remove.
10367 (print_children): Remove Python 2.4 workaround.
10368 * python/py-inferior.c (buffer_procs): Remove Python 2.4
10369 workaround.
10370 (CHARBUFFERPROC_NAME): Remove.
10371 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10372 Python 2.4 workaround.
10373
2c3fc25d 103742019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 10375
2c3fc25d
KB
10376 * NEWS: Note minimum Python version.
10377
6ca62222
KB
103782019-02-27 Kevin Buettner <kevinb@redhat.com>
10379
10380 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10381 code from these functions. Remove corresponding ifdefs. Use
10382 Py_buffer_up instead of explicit calls to PyBuffer_Release.
10383 Remove gotos and target of gotos.
10384 (infpy_search_memory): Likewise.
10385
f4bc7d2c
AB
103862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10387
10388 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10389 (hppa_gdbarch_init): Don't register deleted functions with
10390 gdbarch.
10391
9734a586
AB
103922019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10393
10394 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10395 (h8300_unwind_sp): Delete.
10396 (h8300_dummy_id): Delete.
10397 (h8300_gdbarch_init): Don't register deleted functions with
10398 gdbarch.
10399
68b867f3
AB
104002019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10401
10402 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10403 (ft32_unwind_pc): Delete.
10404 (ft32_unwind_sp): Delete.
10405 (ft32_gdbarch_init): Don't register deleted functions with
10406 gdbarch.
10407
2fbe7ad0
AB
104082019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10409
10410 * gdb/frv-tdep.c (frv_dummy_id): Delete.
10411 (frv_unwind_pc): Delete.
10412 (frv_unwind_sp): Delete.
10413 (frv_gdbarch_init): Don't register deleted functions with
10414 gdbarch.
10415
76055cbe
AB
104162019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10417
10418 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10419 (riscv_unwind_pc): Delete.
10420 (riscv_unwind_sp): Delete.
10421 (riscv_gdbarch_init): Don't register deleted functions with
10422 gdbarch.
10423
4133e5a1
AB
104242019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10425
10426 * gdb/csky-tdep.c (csky_dummy_id): Delete.
10427 (csky_unwind_pc): Delete.
10428 (csky_unwind_sp): Delete.
10429 (csky_gdbarch_init): Don't register deleted functions with
10430 gdbarch.
10431
8010f576
AB
104322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10433
10434 * gdb/cris-tdep.c (cris_dummy_id): Delete.
10435 (cris_unwind_pc): Delete.
10436 (cris_unwind_sp): Delete.
10437 (cris_gdbarch_init): Don't register deleted functions with
10438 gdbarch.
10439
b56bf084
AB
104402019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10441
10442 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10443 (bfin_unwind_pc): Delete.
10444 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10445
a19a650f
AB
104462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10447
10448 * gdb/arm-tdep.c (arm_dummy_id): Delete.
10449 (arm_unwind_pc): Delete.
10450 (arm_unwind_sp): Delete.
10451 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10452
f8278c3c
AB
104532019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10454
10455 * gdb/arc-tdep.c (arc_dummy_id): Delete.
10456 (arc_unwind_pc): Delete.
10457 (arc_unwind_sp): Delete.
10458 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10459
480e46cf
AB
104602019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10461
10462 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10463 (alpha_unwind_pc): Delete.
10464 (alpha_gdbarch_init): Don't register deleted functions with
10465 gdbarch.
10466
7a995095
AB
104672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10468
10469 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10470 (aarch64_unwind_pc): Delete.
10471 (aarch64_unwind_sp): Delete.
10472 (aarch64_gdbarch_init): Don't register deleted functions with
10473 gdbarch.
10474
bf9a735e
AB
104752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10476
10477 * gdbtypes.c (type_align): Don't consider static members when
10478 computing structure alignment.
10479
5561fc30
AB
104802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10481
10482 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10483 return 0 for other types.
10484 * arch-utils.c (default_type_align): Always return 0.
10485 * gdbarch.h: Regenerate.
10486 * gdbarch.sh (type_align): Extend comment.
10487 * gdbtypes.c (type_align): Add additional comments, always call
10488 gdbarch_type_align before applying the default rules.
10489 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10490 generic code will then apply a suitable default.
10491 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10492 types, return 0 for other types.
10493
9335e75a
JB
104942019-02-27 Joel Brobecker <brobecker@adacore.com>
10495
10496 * NEWS: Create a new section for the next release branch.
10497 Rename the section of the current branch, now that it has
10498 been cut.
10499
3d34d8de
JB
105002019-02-27 Joel Brobecker <brobecker@adacore.com>
10501
10502 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10503 * version.in: Bump version to 8.3.50.DATE-git.
10504
143420fb
SM
105052019-02-26 Simon Marchi <simon.marchi@efficios.com>
10506
10507 * aix-thread.c (ptid_cmp): Remove unused variable.
10508 (get_signaled_thread): Likewise.
10509 (store_regs_user_thread): Likewise.
10510 (store_regs_kernel_thread): Likewise.
10511 (fetch_regs_kernel_thread): Remove shadowed variable.
10512
172fb711
AB
105132019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
10514
10515 * features/riscv/32bit-cpu.xml: Add register numbers.
10516 * features/riscv/32bit-fpu.c: Regenerate.
10517 * features/riscv/32bit-fpu.xml: Add register numbers.
10518 * features/riscv/64bit-cpu.xml: Add register numbers.
10519 * features/riscv/64bit-fpu.c: Regenerate.
10520 * features/riscv/64bit-fpu.xml: Add register numbers.
10521
26c89782
KB
105222019-02-26 Kevin Buettner <kevinb@redhat.com>
10523
af54ade9 10524 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
10525 * python/py-value.c (convert_buffer_and_type_to_value): New
10526 function.
10527 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10528 Add support for handling an optional second argument. Call
10529 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
10530 * python/python-internal.h (Py_buffer_deleter): New struct.
10531 (Py_buffer_up): New typedef.
10532
0f58c9e8
JB
105332019-02-25 John Baldwin <jhb@FreeBSD.org>
10534
10535 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10536 instead of releasing ownership.
10537
0a0f4c01
JR
105382019-02-25 Jordan Rupprecht <rupprecht@google.com>
10539
10540 * dwarf2read.c (open_and_init_dwp_file): Call
10541 elf_numsections instead of bfd_count_sections to initialize
10542 dwp_file->num_sections.
10543
cd5a152c
TT
105442019-02-25 Tom Tromey <tromey@adacore.com>
10545
10546 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10547
8a6a8513
SDJ
105482019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
10549
10550 * gcore.in: Add '--readnever' option when invoking GDB.
10551
04dcda9c
SM
105522019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10553
10554 * MAINTAINERS: Update my email address.
10555
07bc701d
SM
105562019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10557
10558 * build-id.c (build_id_to_debug_bfd_1): New function.
10559 (build_id_to_debug_bfd): Look for separate debug file in
10560 sysroot.
10561
c6f4a5d0
AB
105622019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
10563
10564 * gdbarch.sh: Update the copyright year range that is placed into
10565 generated files.
10566
9600246d
KS
105672019-02-22 Keith Seitz <keiths@redhat.com>
10568
10569 PR symtab/23853
10570 * linespec.c (create_sals_line_offset): Search for the default
10571 symtab's filename instead of its fullname.
10572
7557a514
AH
105732019-02-21 Alan Hayward <alan.hayward@arm.com>
10574
10575 * NEWS: Update style defaults.
10576
ee2bcb0c
AH
105772019-02-21 Alan Hayward <alan.hayward@arm.com>
10578
10579 * main.c (captured_main_1): Disable styling in batch mode.
10580
0c95f9ed
TT
105812019-02-20 Tom Tromey <tom@tromey.com>
10582
10583 * symtab.c (symtab_symbol_info): Fix typos.
10584
c763b894
TT
105852019-02-20 Tom Tromey <tromey@adacore.com>
10586
10587 * findcmd.c (_initialize_mem_search): Use upper case for
10588 metasyntactic variables.
10589
0ef8a082
AH
105902019-02-20 Alan Hayward <alan.hayward@arm.com>
10591
10592 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10593 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10594
6caa91b6
SM
105952019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10596
10597 * top.h (source_file_name): Change to std::string.
10598 * top.c (source_file_name): Likewise.
10599 (command_line_input): Adjust.
10600 * cli/cli-script.c (script_from_file): Adjust.
10601
98814c6c
TT
106022019-02-19 Tom Tromey <tromey@adacore.com>
10603
10604 * ravenscar-thread.c
10605 (ravenscar_thread_target::update_thread_list): Don't call
10606 ada_build_task_list.
10607 * ada-lang.h (ada_build_task_list): Don't declare.
10608 * ada-tasks.c (struct ada_tasks_inferior_data)
10609 <task_list_valid_p>: Now bool.
10610 (read_known_tasks, ada_task_list_changed)
10611 (ada_tasks_invalidate_inferior_data): Update.
10612 (read_known_tasks_array): Return bool.
10613 (read_known_tasks_list): Likewise.
10614 (read_known_tasks): Return void.
10615 (ada_build_task_list): Now static.
10616
70cd633e
AB
106172019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10618
10619 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10620 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10621
040b3e95
PW
106222019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10623
10624 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10625 variant for ada_tasks_pspace_data_handle and
10626 ada_tasks_inferior_data_handle.
10627 (ada_tasks_pspace_data_cleanup): New function.
10628 (ada_tasks_inferior_data_cleanup): New function.
10629
9409233b
TT
106302019-02-17 Tom Tromey <tom@tromey.com>
10631
10632 * macrotab.h (macro_source_fullname): Return a std::string.
10633 * macrotab.c (macro_include, check_for_redefinition)
10634 (macro_undef, macro_lookup_definition, foreach_macro)
10635 (foreach_macro_in_scope): Update.
10636 (macro_source_fullname): Return a std::string.
10637 * macrocmd.c (show_pp_source_pos): Update.
10638
6506371f
TT
106392019-02-17 Tom Tromey <tom@tromey.com>
10640
10641 * macrocmd.c (show_pp_source_pos): Style the file names.
10642
0c820d67
TT
106432019-02-17 Tom Tromey <tom@tromey.com>
10644
10645 PR tui/24197:
10646 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10647
a0087920
TT
106482019-02-17 Tom Tromey <tom@tromey.com>
10649
10650 * ada-lang.c (user_select_syms): Use filtered printing.
10651 * utils.c (wrap_style): New global.
10652 (desired_style): Remove.
10653 (emit_style_escape): Add stream parameter.
10654 (set_output_style, reset_terminal_style, prompt_for_continue):
10655 Update.
10656 (flush_wrap_buffer): Only flush gdb_stdout.
10657 (wrap_here): Set wrap_style.
10658 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10659 treat escape sequences as a character. Change when wrap buffer is
10660 flushed.
10661 (fputs_styled): Do not set the output style when the default is
10662 requested.
10663 * ui-style.h (struct ui_file_style) <is_default>: New method.
10664 * source.c (print_source_lines_base): Emit escape sequences in one
10665 piece.
10666
75ba10dc
JB
106672019-02-17 Joel Brobecker <brobecker@adacore.com>
10668
10669 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10670 integers and enumeration types.
10671
a2cd4f14
JB
106722019-02-17 Joel Brobecker <brobecker@adacore.com>
10673
10674 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10675 instead of lookup_symbol_in_language
10676 (do_exact_match): New function.
10677 (ada_get_symbol_name_matcher): Return do_exact_match when
10678 doing a verbatim match.
10679
485b851b
TT
106802019-02-15 Tom Tromey <tromey@adacore.com>
10681
10682 * ravenscar-thread.c (ravenscar_thread_target::resume)
10683 (ravenscar_thread_target::wait): Special case wildcard requests.
10684
0b790b1e
TT
106852019-02-15 Tom Tromey <tromey@adacore.com>
10686
10687 * ravenscar-thread.c (base_ptid): Remove.
10688 (struct ravenscar_thread_target) <close>: New method.
10689 <m_base_ptid>: New member.
10690 <update_inferior_ptid, active_task, task_is_currently_active,
10691 runtime_initialized>: Declare methods.
10692 <ravenscar_thread_target>: Add constructor.
10693 (ravenscar_thread_target::task_is_currently_active)
10694 (ravenscar_thread_target::update_inferior_ptid)
10695 (ravenscar_runtime_initialized): Rename. Now methods.
10696 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10697 (ravenscar_thread_target::update_thread_list): Update.
10698 (ravenscar_thread_target::active_task): Now method.
10699 (ravenscar_thread_target::store_registers)
10700 (ravenscar_thread_target::prepare_to_store)
10701 (ravenscar_thread_target::prepare_to_store)
10702 (ravenscar_thread_target::mourn_inferior): Update.
10703 (ravenscar_inferior_created): Use "new" to create target.
10704 (ravenscar_thread_target::get_ada_task_ptid): Update.
10705 (_initialize_ravenscar): Don't initialize base_ptid.
10706 (ravenscar_ops): Remove global.
10707
dea57a62
TT
107082019-02-15 Tom Tromey <tromey@adacore.com>
10709
10710 * target.h (push_target): Declare new overload.
10711 * target.c (push_target): New overload, taking an rvalue reference.
10712 * remote.c (remote_target::open_1): Use push_target overload.
10713 * corelow.c (core_target_open): Use push_target overload.
10714
989f3c58
TT
107152019-02-15 Tom Tromey <tromey@adacore.com>
10716
10717 * ravenscar-thread.c (is_ravenscar_task)
10718 (ravenscar_task_is_currently_active): Return bool.
10719 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10720 (_initialize_ravenscar): Remove "(void)".
10721 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10722 Return bool.
10723
6cbcc006
TT
107242019-02-15 Tom Tromey <tromey@adacore.com>
10725
10726 * ravenscar-thread.c (ravenscar_runtime_initializer)
10727 (has_ravenscar_runtime, get_running_thread_id)
10728 (ravenscar_thread_target::resume): Fix indentation.
10729
7657f14d
TT
107302019-02-15 Tom Tromey <tromey@adacore.com>
10731
10732 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10733 from ravenscar_arch_ops.
10734 (sparc_ravenscar_ops::fetch_registers)
10735 (sparc_ravenscar_ops::store_registers): Now methods.
10736 (sparc_ravenscar_prepare_to_store): Remove.
10737 (sparc_ravenscar_ops): Redefine.
10738 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10739 methods and destructor. Remove members.
10740 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10741 (ravenscar_thread_target::store_registers)
10742 (ravenscar_thread_target::prepare_to_store): Update.
10743 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10744 Remove.
10745 (struct ppc_ravenscar_powerpc_ops): Derive from
10746 ravenscar_arch_ops.
10747 (ppc_ravenscar_powerpc_ops::fetch_registers)
10748 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10749 (ppc_ravenscar_powerpc_ops): Redefine.
10750 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10751 (ppc_ravenscar_e500_ops::fetch_registers)
10752 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10753 (ppc_ravenscar_e500_ops): Redefine.
10754 * aarch64-ravenscar-thread.c
10755 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10756 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10757 (aarch64_ravenscar_fetch_registers)
10758 (aarch64_ravenscar_store_registers): Now methods.
10759 (aarch64_ravenscar_ops): Redefine.
10760
5b6ea500
TT
107612019-02-15 Tom Tromey <tromey@adacore.com>
10762
10763 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10764 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10765 (ravenscar_thread_target::stopped_by_watchpoint)
10766 (ravenscar_thread_target::stopped_data_address)
10767 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10768
e397fd39
TT
107692019-02-15 Tom Tromey <tromey@adacore.com>
10770
10771 * ravenscar-thread.c: Fix some typos.
10772
cc12f4a8
TT
107732019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10774 Tom Tromey <tromey@adacore.com>
10775
10776 * ada-lang.c (ada_exception_sal): Change addr_string to a
10777 std::string.
10778 (create_ada_exception_catchpoint): Update.
10779
5f486660
TT
107802019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10781 Tom Tromey <tromey@adacore.com>
10782
10783 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10784 (bp_location_ops): Remove.
10785 (base_breakpoint_allocate_location): Update.
10786 (free_bp_location): Update.
10787 * ada-lang.c (class ada_catchpoint_location)
10788 <ada_catchpoint_location>: Remove ops parameter.
10789 (ada_catchpoint_location_dtor): Remove.
10790 (ada_catchpoint_location_ops): Remove.
10791 (allocate_location_exception): Update.
10792 * breakpoint.h (struct bp_location_ops): Remove.
10793 (class bp_location) <bp_location>: Remove bp_location_ops
10794 parameter.
10795 <~bp_location>: Add destructor.
10796 <ops>: Remove.
10797
b671c7fb
TS
107982019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10799 Pedro Alves <palves@redhat.com>
10800
10801 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10802 'PATH_MAX'.
10803
8071c5ce
DM
108042019-02-14 David Michael <fedora.dm0@gmail.com>
10805 Samuel Thibault <samuel.thibault@gnu.org>
10806 Thomas Schwinge <thomas@codesourcery.com>
10807
10808 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10809 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10810
b1041ae0
TS
108112019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10812
924514e1
TS
10813 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10814 (check_empty): Use "const char *".
10815
c29ee8d4
TS
10816 * gnu-nat.c (gnu_nat_target::detach): Instead of
10817 'detach_inferior (pid)' call
10818 'detach_inferior (find_inferior_pid (pid))'.
10819
6c6ef69f
TS
10820 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10821 'nat/fork-inferior.o'.
10822 * gnu-nat.c: #include "nat/fork-inferior.h".
10823
2d0a338c
TS
10824 * gnu-nat.c (gnu_nat_target::detach): Instead of
10825 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10826 * gnu-nat.h: #include "inf-child.h".
10827 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10828 'i386_gnu_nat_target::fetch_registers'.
10829 (gnu_store_registers): Rename/move to
10830 'i386_gnu_nat_target::store_registers'.
10831
cabb5f06
TS
10832 * config/i386/nm-i386gnu.h: Don't "#include" any files.
10833 * gnu-nat.h (mach_thread_info): New function.
10834 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10835
b1041ae0
TS
10836 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10837
2988d01e
KF
108382019-02-14 Frederic Konrad <konrad@adacore.com>
10839
10840 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10841
c559d709
JB
108422019-02-14 Joel Brobecker <brobecker@adacore.com>
10843
10844 * windows-nat.c (windows_add_thread): Add new parameter
10845 "main_thread_p" with default value set to false. Update
10846 function documentation as well as all callers.
10847 (windows_delete_thread): Likewise.
10848 (fake_create_process): Update call to windows_add_thread.
10849 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10850 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10851 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10852 call to windows_delete_thread.
10853
007024cc
SM
108542019-02-13 Simon Marchi <simon.marchi@ericsson.com>
10855
10856 * MAINTAINERS: Add Andrew Burgess as global maintainer.
10857
f62318e9
JB
108582019-02-12 John Baldwin <jhb@FreeBSD.org>
10859
10860 * symfile.c (find_separate_debug_file): Use canonical path of
10861 sysroot with child_path instead of gdb_sysroot if it is valid.
10862
cd4b7848
JB
108632019-02-12 John Baldwin <jhb@FreeBSD.org>
10864
10865 * symfile.c (find_separate_debug_file): Use child_path to
10866 determine if an object file is under a sysroot.
10867
efac4bfe
JB
108682019-02-12 John Baldwin <jhb@FreeBSD.org>
10869
10870 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10871 unittests/child-path-selftests.c.
10872 * common/pathstuff.c (child_path): New function.
10873 * common/pathstuff.h (child_path): New prototype.
10874 * unittests/child-path-selftests.c: New file.
10875
402d2bfe
JB
108762019-02-12 John Baldwin <jhb@FreeBSD.org>
10877
10878 * symfile.c (find_separate_debug_file): Look for separate debug
10879 files in debug directories under the sysroot.
10880
1ed9f74e
PW
108812019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10882
10883 * symtab.h (struct minimal_symbol data_p): New const method.
10884 (struct minimal_symbol text_p): Likewise.
10885 * symtab.c (output_source_filename): Use file name style
10886 to print file name.
10887 (print_symbol_info): Likewise.
10888 (print_msymbol_info): Use address style to print addresses.
10889 Use function name style to print executable text symbols.
10890 (expand_symtab_containing_pc): Use data_p.
10891 (find_pc_sect_compunit_symtab): Likewise.
10892
2636d81d
PW
108932019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10894
10895 * breakpoint.c (describe_other_breakpoints): Use address style
10896 to print addresses.
10897 (say_where): Likewise.
10898
ac8c53cc
PW
108992019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10900
10901 * ada-typeprint.c (print_func_type): Print function name
10902 style to print function name.
10903 * c-typeprint.c (c_print_type_1): Likewise.
10904
ea638c43
AH
109052019-02-11 Alan Hayward <alan.hayward@arm.com>
10906
10907 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10908 for execve.
10909
ab759ca8
PW
109102019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10911
10912 * c-exp.y (direct_abs_decl): Use emplace_back to record the
10913 type_stack.
10914
aff29d1c
JB
109152019-02-10 Joel Brobecker <brobecker@adacore.com>
10916
10917 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10918 TYPE_CODE_REF types.
10919
617126bc
JW
109202019-02-08 Jim Wilson <jimw@sifive.com>
10921
10922 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10923 (riscv_linux_fregset): New.
10924 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10925
46e3ed7f
TT
109262019-02-07 Tom Tromey <tom@tromey.com>
10927
10928 * thread.c (thread_cancel_execution_command): Update.
10929 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10930 methods.
10931 (struct thread_fsm_ops): Remove.
10932 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10933 (thread_fsm_should_stop, thread_fsm_return_value)
10934 (thread_fsm_set_finished, thread_fsm_finished_p)
10935 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10936 Don't declare.
10937 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10938 * infrun.c (clear_proceed_status_thread)
10939 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10940 (print_stop_event): Update.
10941 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10942 Add constructor.
10943 (step_command_fsm_ops): Remove.
10944 (new_step_command_fsm): Remove.
10945 (step_1): Update.
10946 (step_command_fsm::should_stop): Rename from
10947 step_command_fsm_should_stop.
10948 (step_command_fsm::clean_up): Rename from
10949 step_command_fsm_clean_up.
10950 (step_command_fsm::do_async_reply_reason): Rename from
10951 step_command_fsm_async_reply_reason.
10952 (struct until_next_fsm): Inherit from thread_fsm. Add
10953 constructor.
10954 (until_next_fsm_ops): Remove.
10955 (new_until_next_fsm): Remove.
10956 (until_next_fsm::should_stop): Rename from
10957 until_next_fsm_should_stop.
10958 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10959 (until_next_fsm::do_async_reply_reason): Rename from
10960 until_next_fsm_async_reply_reason.
10961 (struct finish_command_fsm): Inherit from thread_fsm. Add
10962 constructor. Change type of breakpoint.
10963 (finish_command_fsm_ops): Remove.
10964 (new_finish_command_fsm): Remove.
10965 (finish_command_fsm::should_stop): Rename from
10966 finish_command_fsm_should_stop.
10967 (finish_command_fsm::clean_up): Rename from
10968 finish_command_fsm_clean_up.
10969 (finish_command_fsm::return_value): Rename from
10970 finish_command_fsm_return_value.
10971 (finish_command_fsm::do_async_reply_reason): Rename from
10972 finish_command_fsm_async_reply_reason.
10973 (finish_command): Update.
10974 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10975 Add constructor.
10976 (call_thread_fsm_ops): Remove.
10977 (call_thread_fsm::call_thread_fsm): Rename from
10978 new_call_thread_fsm.
10979 (call_thread_fsm::should_stop): Rename from
10980 call_thread_fsm_should_stop.
10981 (call_thread_fsm::should_notify_stop): Rename from
10982 call_thread_fsm_should_notify_stop.
10983 (run_inferior_call, call_function_by_hand_dummy): Update.
10984 * cli/cli-interp.c (should_print_stop_to_console): Update.
10985 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10986 Add constructor. Change type of location_breakpoint,
10987 caller_breakpoint.
10988 (until_break_fsm_ops): Remove.
10989 (new_until_break_fsm): Remove.
10990 (until_break_fsm::should_stop): Rename from
10991 until_break_fsm_should_stop.
10992 (until_break_fsm::clean_up): Rename from
10993 until_break_fsm_clean_up.
10994 (until_break_fsm::do_async_reply_reason): Rename from
10995 until_break_fsm_async_reply_reason.
10996 (until_break_command): Update.
10997 * thread-fsm.c: Remove.
10998 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10999
1a5c2598
TT
110002019-02-07 Tom Tromey <tom@tromey.com>
11001
11002 * yy-remap.h: Add include guard.
11003 * xtensa-tdep.h: Add include guard.
11004 * xcoffread.h: Rename include guard.
11005 * varobj-iter.h: Add include guard.
11006 * tui/tui.h: Rename include guard.
11007 * tui/tui-winsource.h: Rename include guard.
11008 * tui/tui-wingeneral.h: Rename include guard.
11009 * tui/tui-windata.h: Rename include guard.
11010 * tui/tui-win.h: Rename include guard.
11011 * tui/tui-stack.h: Rename include guard.
11012 * tui/tui-source.h: Rename include guard.
11013 * tui/tui-regs.h: Rename include guard.
11014 * tui/tui-out.h: Rename include guard.
11015 * tui/tui-layout.h: Rename include guard.
11016 * tui/tui-io.h: Rename include guard.
11017 * tui/tui-hooks.h: Rename include guard.
11018 * tui/tui-file.h: Rename include guard.
11019 * tui/tui-disasm.h: Rename include guard.
11020 * tui/tui-data.h: Rename include guard.
11021 * tui/tui-command.h: Rename include guard.
11022 * tic6x-tdep.h: Add include guard.
11023 * target/waitstatus.h: Rename include guard.
11024 * target/wait.h: Rename include guard.
11025 * target/target.h: Rename include guard.
11026 * target/resume.h: Rename include guard.
11027 * target-float.h: Rename include guard.
11028 * stabsread.h: Add include guard.
11029 * rs6000-tdep.h: Add include guard.
11030 * riscv-fbsd-tdep.h: Add include guard.
11031 * regformats/regdef.h: Rename include guard.
11032 * record.h: Rename include guard.
11033 * python/python.h: Rename include guard.
11034 * python/python-internal.h: Rename include guard.
11035 * python/py-stopevent.h: Rename include guard.
11036 * python/py-ref.h: Rename include guard.
11037 * python/py-record.h: Rename include guard.
11038 * python/py-record-full.h: Rename include guard.
11039 * python/py-record-btrace.h: Rename include guard.
11040 * python/py-instruction.h: Rename include guard.
11041 * python/py-events.h: Rename include guard.
11042 * python/py-event.h: Rename include guard.
11043 * procfs.h: Add include guard.
11044 * proc-utils.h: Add include guard.
11045 * p-lang.h: Add include guard.
11046 * or1k-tdep.h: Rename include guard.
11047 * observable.h: Rename include guard.
11048 * nto-tdep.h: Rename include guard.
11049 * nat/x86-linux.h: Rename include guard.
11050 * nat/x86-linux-dregs.h: Rename include guard.
11051 * nat/x86-gcc-cpuid.h: Add include guard.
11052 * nat/x86-dregs.h: Rename include guard.
11053 * nat/x86-cpuid.h: Rename include guard.
11054 * nat/ppc-linux.h: Rename include guard.
11055 * nat/mips-linux-watch.h: Rename include guard.
11056 * nat/linux-waitpid.h: Rename include guard.
11057 * nat/linux-ptrace.h: Rename include guard.
11058 * nat/linux-procfs.h: Rename include guard.
11059 * nat/linux-osdata.h: Rename include guard.
11060 * nat/linux-nat.h: Rename include guard.
11061 * nat/linux-namespaces.h: Rename include guard.
11062 * nat/linux-btrace.h: Rename include guard.
11063 * nat/glibc_thread_db.h: Rename include guard.
11064 * nat/gdb_thread_db.h: Rename include guard.
11065 * nat/gdb_ptrace.h: Rename include guard.
11066 * nat/fork-inferior.h: Rename include guard.
11067 * nat/amd64-linux-siginfo.h: Rename include guard.
11068 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11069 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11070 * nat/aarch64-linux.h: Rename include guard.
11071 * nat/aarch64-linux-hw-point.h: Rename include guard.
11072 * mn10300-tdep.h: Add include guard.
11073 * mips-linux-tdep.h: Add include guard.
11074 * mi/mi-parse.h: Rename include guard.
11075 * mi/mi-out.h: Rename include guard.
11076 * mi/mi-main.h: Rename include guard.
11077 * mi/mi-interp.h: Rename include guard.
11078 * mi/mi-getopt.h: Rename include guard.
11079 * mi/mi-console.h: Rename include guard.
11080 * mi/mi-common.h: Rename include guard.
11081 * mi/mi-cmds.h: Rename include guard.
11082 * mi/mi-cmd-break.h: Rename include guard.
11083 * m2-lang.h: Add include guard.
11084 * location.h: Rename include guard.
11085 * linux-record.h: Rename include guard.
11086 * linux-nat.h: Add include guard.
11087 * linux-fork.h: Add include guard.
11088 * i386-darwin-tdep.h: Rename include guard.
11089 * hppa-linux-offsets.h: Add include guard.
11090 * guile/guile.h: Rename include guard.
11091 * guile/guile-internal.h: Rename include guard.
11092 * gnu-nat.h: Rename include guard.
11093 * gdb-stabs.h: Rename include guard.
11094 * frv-tdep.h: Add include guard.
11095 * f-lang.h: Add include guard.
11096 * event-loop.h: Add include guard.
11097 * darwin-nat.h: Rename include guard.
11098 * cp-abi.h: Rename include guard.
11099 * config/sparc/nm-sol2.h: Rename include guard.
11100 * config/nm-nto.h: Rename include guard.
11101 * config/nm-linux.h: Add include guard.
11102 * config/i386/nm-i386gnu.h: Rename include guard.
11103 * config/djgpp/nl_types.h: Rename include guard.
11104 * config/djgpp/langinfo.h: Rename include guard.
11105 * compile/gcc-cp-plugin.h: Add include guard.
11106 * compile/gcc-c-plugin.h: Add include guard.
11107 * compile/compile.h: Rename include guard.
11108 * compile/compile-object-run.h: Rename include guard.
11109 * compile/compile-object-load.h: Rename include guard.
11110 * compile/compile-internal.h: Rename include guard.
11111 * compile/compile-cplus.h: Rename include guard.
11112 * compile/compile-c.h: Rename include guard.
11113 * common/xml-utils.h: Rename include guard.
11114 * common/x86-xstate.h: Rename include guard.
11115 * common/version.h: Rename include guard.
11116 * common/vec.h: Rename include guard.
11117 * common/tdesc.h: Rename include guard.
11118 * common/selftest.h: Rename include guard.
11119 * common/scoped_restore.h: Rename include guard.
11120 * common/scoped_mmap.h: Rename include guard.
11121 * common/scoped_fd.h: Rename include guard.
11122 * common/safe-iterator.h: Rename include guard.
11123 * common/run-time-clock.h: Rename include guard.
11124 * common/refcounted-object.h: Rename include guard.
11125 * common/queue.h: Rename include guard.
11126 * common/ptid.h: Rename include guard.
11127 * common/print-utils.h: Rename include guard.
11128 * common/preprocessor.h: Rename include guard.
11129 * common/pathstuff.h: Rename include guard.
11130 * common/observable.h: Rename include guard.
11131 * common/netstuff.h: Rename include guard.
11132 * common/job-control.h: Rename include guard.
11133 * common/host-defs.h: Rename include guard.
11134 * common/gdb_wait.h: Rename include guard.
11135 * common/gdb_vecs.h: Rename include guard.
11136 * common/gdb_unlinker.h: Rename include guard.
11137 * common/gdb_unique_ptr.h: Rename include guard.
11138 * common/gdb_tilde_expand.h: Rename include guard.
11139 * common/gdb_sys_time.h: Rename include guard.
11140 * common/gdb_string_view.h: Rename include guard.
11141 * common/gdb_splay_tree.h: Rename include guard.
11142 * common/gdb_setjmp.h: Rename include guard.
11143 * common/gdb_ref_ptr.h: Rename include guard.
11144 * common/gdb_optional.h: Rename include guard.
11145 * common/gdb_locale.h: Rename include guard.
11146 * common/gdb_assert.h: Rename include guard.
11147 * common/filtered-iterator.h: Rename include guard.
11148 * common/filestuff.h: Rename include guard.
11149 * common/fileio.h: Rename include guard.
11150 * common/environ.h: Rename include guard.
11151 * common/common-utils.h: Rename include guard.
11152 * common/common-types.h: Rename include guard.
11153 * common/common-regcache.h: Rename include guard.
11154 * common/common-inferior.h: Rename include guard.
11155 * common/common-gdbthread.h: Rename include guard.
11156 * common/common-exceptions.h: Rename include guard.
11157 * common/common-defs.h: Rename include guard.
11158 * common/common-debug.h: Rename include guard.
11159 * common/cleanups.h: Rename include guard.
11160 * common/buffer.h: Rename include guard.
11161 * common/btrace-common.h: Rename include guard.
11162 * common/break-common.h: Rename include guard.
11163 * cli/cli-utils.h: Rename include guard.
11164 * cli/cli-style.h: Rename include guard.
11165 * cli/cli-setshow.h: Rename include guard.
11166 * cli/cli-script.h: Rename include guard.
11167 * cli/cli-interp.h: Rename include guard.
11168 * cli/cli-decode.h: Rename include guard.
11169 * cli/cli-cmds.h: Rename include guard.
11170 * charset-list.h: Add include guard.
11171 * buildsym-legacy.h: Rename include guard.
11172 * bfin-tdep.h: Add include guard.
11173 * ax.h: Rename include guard.
11174 * arm-linux-tdep.h: Add include guard.
11175 * arm-fbsd-tdep.h: Add include guard.
11176 * arch/xtensa.h: Rename include guard.
11177 * arch/tic6x.h: Add include guard.
11178 * arch/i386.h: Add include guard.
11179 * arch/arm.h: Rename include guard.
11180 * arch/arm-linux.h: Rename include guard.
11181 * arch/arm-get-next-pcs.h: Rename include guard.
11182 * arch/amd64.h: Add include guard.
11183 * arch/aarch64-insn.h: Rename include guard.
11184 * arch-utils.h: Rename include guard.
11185 * annotate.h: Add include guard.
11186 * amd64-darwin-tdep.h: Rename include guard.
11187 * aarch64-linux-tdep.h: Add include guard.
11188 * aarch64-fbsd-tdep.h: Add include guard.
11189 * aarch32-linux-nat.h: Add include guard.
11190
ab9268d2
PW
111912019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11192
11193 * macrotab.c (macro_define_internal): New function that
11194 factorizes macro_define_object_internal and macro_define_function
11195 code.
11196 (macro_define_object_internal): Use macro_define_internal.
11197 (macro_define_function): Likewise.
11198
bb0da2b4
PW
111992019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11200
11201 * macrocmd.c (extract_identifier): Return
11202 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11203 callers.
11204
424eb552
JB
112052019-02-06 John Baldwin <jhb@FreeBSD.org>
11206
11207 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11208
1688cb29
TT
112092019-02-05 Tom Tromey <tom@tromey.com>
11210
11211 * target.c (target_stack::unpush): Move assertion earlier.
11212
b5eba2d8
TT
112132019-01-30 Tom Tromey <tom@tromey.com>
11214
11215 PR python/23615:
11216 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11217 (gdbpy_parse_and_eval): Likewise.
11218 * python/python-internal.h (gdbpy_allow_threads): New class.
11219
7054e2ff
JB
112202019-01-28 John Baldwin <jhb@FreeBSD.org>
11221
11222 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11223 (aarch64_fbsd_fpregmap): Move earlier.
11224 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11225 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11226 instead of individual calls to trad_frame_set_reg_addr.
11227 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11228 earlier.
11229 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11230 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11231 instead of individual calls to trad_frame_set_reg_addr.
11232
36c25ffa
AH
112332019-01-28 Alan Hayward <alan.hayward@arm.com>
11234
11235 * CONTRIBUTE: Replace contribution list with wiki link.
11236
a0707f3c
TT
112372019-01-25 Tom Tromey <tom@tromey.com>
11238
11239 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11240
0747795c
TT
112412019-01-25 Tom Tromey <tom@tromey.com>
11242
11243 * xtensa-linux-nat.c: Fix common/ includes.
11244 * xml-support.h: Fix common/ includes.
11245 * xml-support.c: Fix common/ includes.
11246 * x86-linux-nat.c: Fix common/ includes.
11247 * windows-nat.c: Fix common/ includes.
11248 * varobj.h: Fix common/ includes.
11249 * varobj.c: Fix common/ includes.
11250 * value.c: Fix common/ includes.
11251 * valops.c: Fix common/ includes.
11252 * utils.c: Fix common/ includes.
11253 * unittests/xml-utils-selftests.c: Fix common/ includes.
11254 * unittests/utils-selftests.c: Fix common/ includes.
11255 * unittests/unpack-selftests.c: Fix common/ includes.
11256 * unittests/tracepoint-selftests.c: Fix common/ includes.
11257 * unittests/style-selftests.c: Fix common/ includes.
11258 * unittests/string_view-selftests.c: Fix common/ includes.
11259 * unittests/scoped_restore-selftests.c: Fix common/ includes.
11260 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11261 * unittests/scoped_fd-selftests.c: Fix common/ includes.
11262 * unittests/rsp-low-selftests.c: Fix common/ includes.
11263 * unittests/parse-connection-spec-selftests.c: Fix common/
11264 includes.
11265 * unittests/optional-selftests.c: Fix common/ includes.
11266 * unittests/offset-type-selftests.c: Fix common/ includes.
11267 * unittests/observable-selftests.c: Fix common/ includes.
11268 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11269 * unittests/memrange-selftests.c: Fix common/ includes.
11270 * unittests/memory-map-selftests.c: Fix common/ includes.
11271 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11272 * unittests/function-view-selftests.c: Fix common/ includes.
11273 * unittests/environ-selftests.c: Fix common/ includes.
11274 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11275 * unittests/common-utils-selftests.c: Fix common/ includes.
11276 * unittests/cli-utils-selftests.c: Fix common/ includes.
11277 * unittests/array-view-selftests.c: Fix common/ includes.
11278 * ui-file.c: Fix common/ includes.
11279 * tui/tui-io.c: Fix common/ includes.
11280 * tracepoint.h: Fix common/ includes.
11281 * tracepoint.c: Fix common/ includes.
11282 * tracefile-tfile.c: Fix common/ includes.
11283 * top.h: Fix common/ includes.
11284 * top.c: Fix common/ includes.
11285 * thread.c: Fix common/ includes.
11286 * target/waitstatus.h: Fix common/ includes.
11287 * target/waitstatus.c: Fix common/ includes.
11288 * target.h: Fix common/ includes.
11289 * target.c: Fix common/ includes.
11290 * target-memory.c: Fix common/ includes.
11291 * target-descriptions.c: Fix common/ includes.
11292 * symtab.h: Fix common/ includes.
11293 * symfile.c: Fix common/ includes.
11294 * stap-probe.c: Fix common/ includes.
11295 * spu-linux-nat.c: Fix common/ includes.
11296 * sparc-nat.c: Fix common/ includes.
11297 * source.c: Fix common/ includes.
11298 * solib.c: Fix common/ includes.
11299 * solib-target.c: Fix common/ includes.
11300 * ser-unix.c: Fix common/ includes.
11301 * ser-tcp.c: Fix common/ includes.
11302 * ser-pipe.c: Fix common/ includes.
11303 * ser-base.c: Fix common/ includes.
11304 * selftest-arch.c: Fix common/ includes.
11305 * s12z-tdep.c: Fix common/ includes.
11306 * rust-exp.y: Fix common/ includes.
11307 * rs6000-aix-tdep.c: Fix common/ includes.
11308 * riscv-tdep.c: Fix common/ includes.
11309 * remote.c: Fix common/ includes.
11310 * remote-notif.h: Fix common/ includes.
11311 * remote-fileio.h: Fix common/ includes.
11312 * remote-fileio.c: Fix common/ includes.
11313 * regcache.h: Fix common/ includes.
11314 * regcache.c: Fix common/ includes.
11315 * record-btrace.c: Fix common/ includes.
11316 * python/python.c: Fix common/ includes.
11317 * python/py-type.c: Fix common/ includes.
11318 * python/py-inferior.c: Fix common/ includes.
11319 * progspace.h: Fix common/ includes.
11320 * producer.c: Fix common/ includes.
11321 * procfs.c: Fix common/ includes.
11322 * proc-api.c: Fix common/ includes.
11323 * printcmd.c: Fix common/ includes.
11324 * ppc-linux-nat.c: Fix common/ includes.
11325 * parser-defs.h: Fix common/ includes.
11326 * osdata.c: Fix common/ includes.
11327 * obsd-nat.c: Fix common/ includes.
11328 * nat/x86-linux.c: Fix common/ includes.
11329 * nat/x86-linux-dregs.c: Fix common/ includes.
11330 * nat/x86-dregs.h: Fix common/ includes.
11331 * nat/x86-dregs.c: Fix common/ includes.
11332 * nat/ppc-linux.c: Fix common/ includes.
11333 * nat/mips-linux-watch.h: Fix common/ includes.
11334 * nat/mips-linux-watch.c: Fix common/ includes.
11335 * nat/linux-waitpid.c: Fix common/ includes.
11336 * nat/linux-ptrace.h: Fix common/ includes.
11337 * nat/linux-ptrace.c: Fix common/ includes.
11338 * nat/linux-procfs.c: Fix common/ includes.
11339 * nat/linux-personality.c: Fix common/ includes.
11340 * nat/linux-osdata.c: Fix common/ includes.
11341 * nat/linux-namespaces.c: Fix common/ includes.
11342 * nat/linux-btrace.h: Fix common/ includes.
11343 * nat/linux-btrace.c: Fix common/ includes.
11344 * nat/fork-inferior.c: Fix common/ includes.
11345 * nat/amd64-linux-siginfo.c: Fix common/ includes.
11346 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11347 * nat/aarch64-linux.c: Fix common/ includes.
11348 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11349 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11350 * namespace.h: Fix common/ includes.
11351 * mips-linux-tdep.c: Fix common/ includes.
11352 * minsyms.c: Fix common/ includes.
11353 * mi/mi-parse.h: Fix common/ includes.
11354 * mi/mi-main.c: Fix common/ includes.
11355 * mi/mi-cmd-env.c: Fix common/ includes.
11356 * memrange.h: Fix common/ includes.
11357 * memattr.c: Fix common/ includes.
11358 * maint.h: Fix common/ includes.
11359 * maint.c: Fix common/ includes.
11360 * main.c: Fix common/ includes.
11361 * machoread.c: Fix common/ includes.
11362 * location.c: Fix common/ includes.
11363 * linux-thread-db.c: Fix common/ includes.
11364 * linux-nat.c: Fix common/ includes.
11365 * linux-fork.c: Fix common/ includes.
11366 * inline-frame.c: Fix common/ includes.
11367 * infrun.c: Fix common/ includes.
11368 * inflow.c: Fix common/ includes.
11369 * inferior.h: Fix common/ includes.
11370 * inferior.c: Fix common/ includes.
11371 * infcmd.c: Fix common/ includes.
11372 * inf-ptrace.c: Fix common/ includes.
11373 * inf-child.c: Fix common/ includes.
11374 * ia64-linux-nat.c: Fix common/ includes.
11375 * i387-tdep.c: Fix common/ includes.
11376 * i386-tdep.c: Fix common/ includes.
11377 * i386-linux-tdep.c: Fix common/ includes.
11378 * i386-linux-nat.c: Fix common/ includes.
11379 * i386-go32-tdep.c: Fix common/ includes.
11380 * i386-fbsd-tdep.c: Fix common/ includes.
11381 * i386-fbsd-nat.c: Fix common/ includes.
11382 * guile/scm-type.c: Fix common/ includes.
11383 * guile/guile.c: Fix common/ includes.
11384 * go32-nat.c: Fix common/ includes.
11385 * gnu-nat.c: Fix common/ includes.
11386 * gdbthread.h: Fix common/ includes.
11387 * gdbarch-selftests.c: Fix common/ includes.
11388 * gdb_usleep.c: Fix common/ includes.
11389 * gdb_select.h: Fix common/ includes.
11390 * gdb_bfd.c: Fix common/ includes.
11391 * gcore.c: Fix common/ includes.
11392 * fork-child.c: Fix common/ includes.
11393 * findvar.c: Fix common/ includes.
11394 * fbsd-nat.c: Fix common/ includes.
11395 * event-top.c: Fix common/ includes.
11396 * event-loop.c: Fix common/ includes.
11397 * dwarf2read.c: Fix common/ includes.
11398 * dwarf2loc.c: Fix common/ includes.
11399 * dwarf2-frame.c: Fix common/ includes.
11400 * dwarf-index-cache.c: Fix common/ includes.
11401 * dtrace-probe.c: Fix common/ includes.
11402 * disasm-selftests.c: Fix common/ includes.
11403 * defs.h: Fix common/ includes.
11404 * csky-tdep.c: Fix common/ includes.
11405 * cp-valprint.c: Fix common/ includes.
11406 * cp-support.h: Fix common/ includes.
11407 * cp-support.c: Fix common/ includes.
11408 * corelow.c: Fix common/ includes.
11409 * completer.h: Fix common/ includes.
11410 * completer.c: Fix common/ includes.
11411 * compile/compile.c: Fix common/ includes.
11412 * compile/compile-loc2c.c: Fix common/ includes.
11413 * compile/compile-cplus-types.c: Fix common/ includes.
11414 * compile/compile-cplus-symbols.c: Fix common/ includes.
11415 * command.h: Fix common/ includes.
11416 * cli/cli-dump.c: Fix common/ includes.
11417 * cli/cli-cmds.c: Fix common/ includes.
11418 * charset.c: Fix common/ includes.
11419 * build-id.c: Fix common/ includes.
11420 * btrace.h: Fix common/ includes.
11421 * btrace.c: Fix common/ includes.
11422 * breakpoint.h: Fix common/ includes.
11423 * breakpoint.c: Fix common/ includes.
11424 * ax.h:
11425 (enum agent_op): Fix common/ includes.
11426 * ax-general.c (struct aop_map): Fix common/ includes.
11427 * ax-gdb.c: Fix common/ includes.
11428 * auxv.c: Fix common/ includes.
11429 * auto-load.c: Fix common/ includes.
11430 * arm-tdep.c: Fix common/ includes.
11431 * arch/riscv.c: Fix common/ includes.
11432 * arch/ppc-linux-common.c: Fix common/ includes.
11433 * arch/i386.c: Fix common/ includes.
11434 * arch/arm.c: Fix common/ includes.
11435 * arch/arm-linux.c: Fix common/ includes.
11436 * arch/arm-get-next-pcs.c: Fix common/ includes.
11437 * arch/amd64.c: Fix common/ includes.
11438 * arch/aarch64.c: Fix common/ includes.
11439 * arch/aarch64-insn.c: Fix common/ includes.
11440 * arch-utils.c: Fix common/ includes.
11441 * amd64-windows-tdep.c: Fix common/ includes.
11442 * amd64-tdep.c: Fix common/ includes.
11443 * amd64-sol2-tdep.c: Fix common/ includes.
11444 * amd64-obsd-tdep.c: Fix common/ includes.
11445 * amd64-nbsd-tdep.c: Fix common/ includes.
11446 * amd64-linux-tdep.c: Fix common/ includes.
11447 * amd64-linux-nat.c: Fix common/ includes.
11448 * amd64-fbsd-tdep.c: Fix common/ includes.
11449 * amd64-fbsd-nat.c: Fix common/ includes.
11450 * amd64-dicos-tdep.c: Fix common/ includes.
11451 * amd64-darwin-tdep.c: Fix common/ includes.
11452 * agent.c: Fix common/ includes.
11453 * ada-lang.h: Fix common/ includes.
11454 * ada-lang.c: Fix common/ includes.
11455 * aarch64-tdep.c: Fix common/ includes.
11456
2f5c153e
TT
114572019-01-25 Tom Tromey <tom@tromey.com>
11458
11459 * common/create-version.sh: Use common/version.h.
11460
adc6a863
PA
114612019-01-24 Pedro Alves <palves@redhat.com>
11462
11463 * infrun.c (signal_stop, signal_print, signal_program)
11464 (signal_catch, signal_pass): Now arrays instead of pointers.
11465 (update_signals_program_target, do_target_resume)
11466 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11467 * linux-nat.c (linux_nat_target::pass_signals)
11468 (linux_nat_target::create_inferior, linux_nat_target::attach):
11469 Adjust.
11470 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11471 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11472 * procfs.c (procfs_target::pass_signals): Adjust.
11473 * record-full.c (record_full_target::resume): Adjust.
11474 * remote.c (remote_target::pass_signals)
11475 (remote_target::program_signals): Adjust.
11476 * target-debug.h (target_debug_print_signals): Now takes a
11477 gdb::array_view as parameter. Adjust.
11478 * target.h (target_ops) <pass_signals, program_signals>: Replace
11479 pointer and length parameters with gdb::array_view.
11480 (target_pass_signals, target_program_signals): Likewise.
11481 * target-delegates.c: Regenerate.
11482
3046d67a
PA
114832019-01-24 Pedro Alves <palves@redhat.com>
11484
11485 * common/forward-scope-exit.h
11486 (forward_scope_exit::forward_scope_exit): Pass arguments to
11487 m_bind_function directly, instead of creating a std::bind and
11488 copying that.
11489
353229bf
AH
114902019-01-24 Alan Hayward <alan.hayward@arm.com>
11491
11492 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11493 for static members.
11494 (pass_in_v_vfp_candidate): Likewise.
11495
311dc83a
TT
114962019-01-23 Tom Tromey <tom@tromey.com>
11497 Pedro Alves <palves@redhat.com>
11498
11499 * regcache.c (class regcache_invalidator): Remove.
11500 (regcache::raw_write): Use make_scope_exit.
11501
296bd123
TT
115022019-01-23 Tom Tromey <tom@tromey.com>
11503
11504 * ui-out.h (class ui_out_emit_type): Update comment.
11505
979a0d13
TT
115062019-01-23 Tom Tromey <tom@tromey.com>
11507
11508 * infrun.c (fetch_inferior_event): Update comment.
11509
d238133d
TT
115102019-01-23 Tom Tromey <tom@tromey.com>
11511 Pedro Alves <palves@redhat.com>
11512
11513 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11514 parameter.
11515 (fetch_inferior_event): Use SCOPE_EXIT.
11516
11517
9885e6bb
TT
115182019-01-23 Tom Tromey <tom@tromey.com>
11519 Pedro Alves <palves@redhat.com>
11520
11521 * infrun.c (disable_thread_events): Delete.
11522 (stop_all_threads): Use SCOPE_EXIT.
11523
286526c1
TT
115242019-01-23 Tom Tromey <tom@tromey.com>
11525 Pedro Alves <palves@redhat.com>
11526
11527 * symfile.c: Include forward-scope-exit.h.
11528 (clear_symtab_users_cleanup): Replace forward declaration with
11529 a FORWARD_SCOPE_EXIT.
11530 (syms_from_objfile_1): Use the forward_scope_exit and
11531 gdb::optional instead of cleanup_function.
11532 (reread_symbols): Use the forward_scope_exit instead of
11533 cleanup_function.
11534 (clear_symtab_users_cleanup): Remove function.
11535
1db93f14
TT
115362019-01-23 Tom Tromey <tom@tromey.com>
11537 Pedro Alves <palves@redhat.com>
11538
11539 * linux-nat.c: Include scope-exit.h.
11540 (cleanup_target_stop): Remove.
11541 (linux_nat_target::static_tracepoint_markers_by_strid): Use
11542 SCOPE_EXIT.
11543
2cc83d1e
TT
115442019-01-23 Tom Tromey <tom@tromey.com>
11545 Pedro Alves <palves@redhat.com>
11546
11547 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11548 (call_function_by_hand_dummy): Use SCOPE_EXIT.
11549
694c6bf5
TT
115502019-01-23 Tom Tromey <tom@tromey.com>
11551 Andrew Burgess <andrew.burgess@embecosm.com>
11552 Pedro Alves <palves@redhat.com>
11553
11554 * infrun.c (fetch_inferior_event): Use scope_exit.
11555 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11556 * top.c (execute_command): Use scope_exit.
11557 * breakpoint.c (bpstat_do_actions): Use scope_exit.
11558 * utils.c (do_bpstat_clear_actions_cleanup)
11559 (make_bpstat_clear_actions_cleanup): Remove.
11560
4c41382a
TT
115612019-01-23 Tom Tromey <tom@tromey.com>
11562 Pedro Alves <palves@redhat.com>
11563
11564 * infrun.c: Include "common/scope-exit.h"
11565 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11566 (wait_for_inferior): Use SCOPE_EXIT.
11567 (fetch_inferior_event): Use scope_exit.
11568
89f8fb50
TT
115692019-01-23 Tom Tromey <tom@tromey.com>
11570 Pedro Alves <palves@redhat.com>
11571
11572 * breakpoint.c (create_breakpoint): Remove cleanup.
11573
5419bdae
TT
115742019-01-23 Tom Tromey <tom@tromey.com>
11575 Andrew Burgess <andrew.burgess@embecosm.com>
11576 Pedro Alves <palves@redhat.com>
11577
e587ef42
PA
115782019-01-23 Pedro Alves <palves@redhat.com>
11579
11580 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11581
77f0e74c
PA
115822019-01-23 Pedro Alves <palves@redhat.com>
11583 Andrew Burgess <andrew.burgess@embecosm.com>
11584
11585 * gdbthread.h: Include "common/forward-scope-exit.h".
11586 (scoped_finish_thread_state): Redefine custom class in terms of
11587 forward_scope_exit.
11588
5b9b3e53
PA
115892019-01-23 Pedro Alves <palves@redhat.com>
11590 Andrew Burgess <andrew.burgess@embecosm.com>
11591
11592 * common/forward-scope-exit.h: New file.
11593
54b65c9b
PA
115942019-01-23 Pedro Alves <palves@redhat.com>
11595 Andrew Burgess <andrew.burgess@embecosm.com>
11596 Tom Tromey <tom@tromey.com>
11597
11598 * common/scope-exit.h: New file.
11599
cf08fb29
PA
116002019-01-23 Pedro Alves <palves@redhat.com>
11601
11602 * common/preprocessor.h (ESC): Rename to ...
11603 (ESC_PARENS): ... this.
11604 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11605 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11606
ae73e2e2
TT
116072019-01-23 Tom Tromey <tom@tromey.com>
11608
11609 * language.h (class scoped_switch_to_sym_language_if_auto):
11610 Initialize m_lang in both cases.
11611
6594e122
AH
116122019-01-23 Alan Hayward <alan.hayward@arm.com>
11613
11614 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11615 with XCNEW.
11616
a7c9855d
TT
116172019-01-22 Tom Tromey <tom@tromey.com>
11618
11619 * corelow.c: Do not include sys/file.h.
11620
93cc1d53
TT
116212019-01-22 Tom Tromey <tom@tromey.com>
11622
11623 * tui/tui-wingeneral.h: Include gdb_curses.h.
11624
38561778
TT
116252019-01-22 Tom Tromey <tom@tromey.com>
11626
11627 * source-cache.h (class source_cache) <get_source_lines,
11628 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11629
37b3ab5b
TT
116302019-01-22 Tom Tromey <tom@tromey.com>
11631
11632 * remote-fileio.h (struct remote_target): Declare.
11633
3fabc016
TT
116342019-01-22 Tom Tromey <tom@tromey.com>
11635
11636 * python/py-arch.c: Do not include py-ref.h.
11637 * python/py-bpevent.c: Do not include py-ref.h.
11638 * python/py-cmd.c: Do not include py-ref.h.
11639 * python/py-continueevent.c: Do not include py-ref.h.
11640 * python/py-event.h: Do not include py-ref.h.
11641 * python/py-evtregistry.c: Do not include py-ref.h.
11642 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11643 * python/py-frame.c: Do not include py-ref.h.
11644 * python/py-framefilter.c: Do not include py-ref.h.
11645 * python/py-function.c: Do not include py-ref.h.
11646 * python/py-infevents.c: Do not include py-ref.h.
11647 * python/py-linetable.c: Do not include py-ref.h.
11648 * python/py-objfile.c: Do not include py-ref.h.
11649 * python/py-param.c: Do not include py-ref.h.
11650 * python/py-prettyprint.c: Do not include py-ref.h.
11651 * python/py-progspace.c: Do not include py-ref.h.
11652 * python/py-symbol.c: Do not include py-ref.h.
11653 * python/py-symtab.c: Do not include py-ref.h.
11654 * python/py-type.c: Do not include py-ref.h.
11655 * python/py-unwind.c: Do not include py-ref.h.
11656 * python/py-utils.c: Do not include py-ref.h.
11657 * python/py-value.c: Do not include py-ref.h.
11658 * python/py-varobj.c: Do not include py-ref.h.
11659 * python/py-xmethods.c: Do not include py-ref.h.
11660 * python/python.c: Do not include py-ref.h.
11661 * varobj.c: Do not include py-ref.h.
11662
6b4d7774
TT
116632019-01-22 Tom Tromey <tom@tromey.com>
11664
11665 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11666 keyword for bcache.
11667
7af7e9b5
TT
116682019-01-22 Tom Tromey <tom@tromey.com>
11669
11670 * compile/compile-cplus-types.c: Remove a comment by #include.
11671
951d1049
TT
116722019-01-22 Tom Tromey <tom@tromey.com>
11673
11674 * compile/gcc-c-plugin.h: Include compile-internal.h.
11675
d65d5705
TT
116762019-01-22 Tom Tromey <tom@tromey.com>
11677
11678 * stabsread.c (EXTERN): Do not define.
11679 (symnum, next_symbol_text_func, processing_gcc_compilation)
11680 (within_function, global_sym_chain, global_stabs)
11681 (previous_stab_code, this_object_header_files)
11682 (n_this_object_header_files)
11683 (n_allocated_this_object_header_files): Define.
11684 * stabsread.h (EXTERN): Never define. Use "extern".
11685
b6fb1ee5
PW
116862019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11687
11688 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11689 history_value.
11690
be6d4f74
TT
116912019-01-21 Tom Tromey <tom@tromey.com>
11692
11693 * ui-out.c: Fix includes.
11694 * tui/tui-source.c: Fix includes.
11695 * target.c: Fix includes.
11696 * remote.c: Fix includes.
11697 * regcache.c: Fix includes.
11698 * python/py-block.c: Fix includes.
11699 * printcmd.c: Fix includes.
11700 * or1k-tdep.c: Fix includes.
11701 * mi/mi-main.c: Fix includes.
11702 * m32r-tdep.c: Fix includes.
11703 * csky-tdep.c: Fix includes.
11704 * compile/compile-cplus-types.c: Fix includes.
11705 * cli/cli-interp.c: Fix includes.
11706
73021deb
AH
117072019-01-21 Alan Hayward <alan.hayward@arm.com>
11708
11709 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11710 for padding.
11711
7932255d
TT
117122019-01-16 Tom Tromey <tom@tromey.com>
11713
11714 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11715 earlier.
11716 (struct objfile) <msymbols_range>: Move from top level.
11717 <msymbols>: New method.
11718 (class objfile_msymbols): Remove.
11719 * symtab.c (default_collect_symbol_completion_matches_break_on):
11720 Update.
11721 * symmisc.c (dump_msymbols): Update.
11722 * stabsread.c (scan_file_globals): Update.
11723 * objc-lang.c (info_selectors_command, info_classes_command)
11724 (find_methods): Update.
11725 * minsyms.c (find_solib_trampoline_target): Update.
11726 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11727 * coffread.c (coff_symfile_read): Update.
11728 * ada-lang.c (ada_lookup_simple_minsym)
11729 (ada_collect_symbol_completion_matches): Update.
11730
604b1bfb
TT
117312019-01-16 Tom Tromey <tom@tromey.com>
11732
11733 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11734 type. Remove no-argument constructor.
11735 <iterator::operator++>: Simplify.
11736 <begin>: Update.
11737 <end>: Use minimal_symbol_count.
11738
f252c6d5
TT
117392019-01-16 Tom Tromey <tom@tromey.com>
11740
11741 * objfiles.h (struct objfile) <psymtabs>: New method.
11742 (class objfile_psymtabs): Remove.
11743 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11744 typedef.
11745 <range>: New method.
11746 (require_partial_symbols): Change return type.
11747 * psymtab.c (require_partial_symbols)
11748 (psym_expand_symtabs_matching): Update.
11749 * mdebugread.c (parse_partial_symbols): Update.
11750 * dbxread.c (dbx_end_psymtab): Update.
11751
b669c953
TT
117522019-01-15 Tom Tromey <tom@tromey.com>
11753
11754 * symtab.c (lookup_objfile_from_block)
11755 (lookup_symbol_in_objfile_symtabs)
11756 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11757 (find_line_symtab, info_sources_command)
11758 (default_collect_symbol_completion_matches_break_on)
11759 (make_source_files_completion_list): Update.
11760 * symmisc.c (print_objfile_statistics, dump_objfile)
11761 (maintenance_print_symbols, maintenance_info_symtabs)
11762 (maintenance_check_symtabs, maintenance_info_line_tables):
11763 Update.
11764 * source.c (select_source_symtab)
11765 (forget_cached_source_info_for_objfile): Update.
11766 * objfiles.h (class objfile_compunits): Remove.
11767 (struct objfile) <compunits_range>: New typedef.
11768 (compunits): New method.
11769 * objfiles.c (objfile_relocate1): Update.
11770 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11771 * maint.c (count_symtabs_and_blocks): Update.
11772 * linespec.c (iterate_over_all_matching_symtabs): Update.
11773 * cp-support.c (add_symbol_overload_list_qualified): Update.
11774 * coffread.c (coff_symtab_read): Update.
11775 * ada-lang.c (add_nonlocal_symbols)
11776 (ada_collect_symbol_completion_matches)
11777 (ada_add_global_exceptions): Update.
11778
7e955d83
TT
117792019-01-15 Tom Tromey <tom@tromey.com>
11780
11781 * progspace.h (program_space) <objfiles_safe_range>: New
11782 typedef.
11783 <objfiles_safe>: New method.
11784 * objfiles.h (class all_objfiles_safe): Remove.
11785 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11786 * jit.c (jit_inferior_exit_hook): Update.
11787
2030c079
TT
117882019-01-17 Tom Tromey <tom@tromey.com>
11789
11790 * progspace.h (program_space) <objfiles_range>: New typedef.
11791 <objfiles>: New method.
11792 <objfiles_head>: Rename from objfiles.
11793 (object_files): Update.
11794 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11795 * guile/scm-pretty-print.c
11796 (ppscm_find_pretty_printer_from_objfiles): Update.
11797 * guile/scm-objfile.c (gdbscm_objfiles): Update.
11798 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11799 Update.
11800 * python/py-progspace.c (pspy_get_objfiles): Update.
11801 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11802 Update.
11803 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11804 (objfpy_lookup_objfile_by_build_id): Update.
11805 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11806 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11807 Update.
11808 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11809 (expand_symtab_containing_pc, lookup_objfile_from_block)
11810 (lookup_static_symbol, basic_lookup_transparent_type)
11811 (find_pc_sect_compunit_symtab, find_symbol_at_address)
11812 (find_line_symtab, info_sources_command)
11813 (default_collect_symbol_completion_matches_break_on)
11814 (make_source_files_completion_list, find_main_name): Update.
11815 * symmisc.c (print_symbol_bcache_statistics)
11816 (print_objfile_statistics, maintenance_print_symbols)
11817 (maintenance_print_msymbols, maintenance_print_objfiles)
11818 (maintenance_info_symtabs, maintenance_check_symtabs)
11819 (maintenance_expand_symtabs, maintenance_info_line_tables):
11820 Update.
11821 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11822 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11823 (map_overlay_command, unmap_overlay_command)
11824 (simple_overlay_update, expand_symtabs_matching)
11825 (map_symbol_filenames): Update.
11826 * symfile-debug.c (set_debug_symfile): Update.
11827 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11828 Update.
11829 * source.c (select_source_symtab, forget_cached_source_info):
11830 Update.
11831 * solib.c (solib_read_symbols): Update.
11832 * solib-spu.c (append_ocl_sos): Update.
11833 * psymtab.c (maintenance_print_psymbols)
11834 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11835 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11836 * printcmd.c (info_symbol_command): Update.
11837 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11838 Update.
11839 * objfiles.h (class all_objfiles): Remove.
11840 * objfiles.c (have_partial_symbols, have_full_symbols)
11841 (have_minimal_symbols, qsort_cmp, update_section_map)
11842 (shared_objfile_contains_address_p)
11843 (default_iterate_over_objfiles_in_search_order): Update.
11844 * objc-lang.c (info_selectors_command, info_classes_command)
11845 (find_methods): Update.
11846 * minsyms.c (find_solib_trampoline_target): Update.
11847 * maint.c (maintenance_info_sections)
11848 (maintenance_translate_address, count_symtabs_and_blocks):
11849 Update.
11850 * main.c (captured_main_1): Update.
11851 * linux-thread-db.c (try_thread_db_load_from_pdir)
11852 (has_libpthread): Update.
11853 * linespec.c (iterate_over_all_matching_symtabs)
11854 (search_minsyms_for_name): Update.
11855 * jit.c (jit_find_objf_with_entry_addr): Update.
11856 * hppa-tdep.c (find_unwind_entry)
11857 (hppa_lookup_stub_minimal_symbol): Update.
11858 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11859 Update.
11860 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11861 (elf_gnu_ifunc_resolve_by_got): Update.
11862 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11863 * dwarf-index-write.c (save_gdb_index_command): Update.
11864 * cp-support.c (add_symbol_overload_list_qualified): Update.
11865 * breakpoint.c (create_overlay_event_breakpoint)
11866 (create_longjmp_master_breakpoint)
11867 (create_std_terminate_master_breakpoint)
11868 (create_exception_master_breakpoint): Update.
11869 * blockframe.c (find_pc_partial_function): Update.
11870 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11871 (ada_collect_symbol_completion_matches)
11872 (ada_add_global_exceptions): Update.
11873
776489e0
TT
118742019-01-17 Tom Tromey <tom@tromey.com>
11875
11876 * solib-target.c (lm_info_target_p): Remove typedef. Don't
11877 declare VEC.
11878 (solib_target_parse_libraries): Change return type.
11879 (library_list_start_segment, library_list_start_section)
11880 (library_list_end_library, library_list_start_library); Update.
11881 (solib_target_free_library_list): Remove.
11882 (solib_target_parse_libraries): Remove cleanup. Change return
11883 type.
11884 (solib_target_current_sos): Update.
11885
6471e7d2
TT
118862019-01-17 Tom Tromey <tromey@bapiya>
11887
11888 * valprint.c: Replace "the the" with "the".
11889 * symtab.c: Replace "the the" with "the".
11890 * solib.c: Replace "the the" with "the".
11891 * solib-dsbt.c: Replace "the the" with "the".
11892 * linespec.c: Replace "the the" with "the".
11893 * dwarf2loc.h: Replace "the the" with "the".
11894 * amd64-windows-tdep.c: Replace "the the" with "the".
11895 * aarch64-tdep.c: Replace "the the" with "the".
11896
c24bdb02
KS
118972019-01-16 Keith Seitz <keiths@redhat.com>
11898
11899 PR gdb/23773
11900 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11901 <builder>: Rename to ..
11902 <m_builder>: ... this and make private.
11903 (dwarf2_cu::get_builder): New method. Change all users of
11904 `builder' to use this method.
11905 (dwarf2_start_symtab): Move to ...
11906 (dwarf2_cu::start_symtab): ... here. Update all callers
11907 (setup_type_unit_groups): Move to ...
11908 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
11909 callers.
11910 (dwarf2_cu::reset_builder): New method.
11911 (process_full_compunit, process_full_type_unit): Use
11912 dwarf2_cu::reset_builder.
11913 (follow_die_offset): Record the ancestor CU if it is different
11914 from the followed DIE's CU.
11915 (follow_die_sig_1): Likewise.
11916
8d64371b
TT
119172019-01-15 Tom Tromey <tom@tromey.com>
11918
11919 * remote.c (class remote_state) <buf>: Now a char_vector.
11920 <buf_size>: Remove.
11921 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
11922 parameter.
11923 (remote_target::getpkt_or_notif_sane_1)
11924 (remote_target::getpkt_sane)
11925 (remote_target::getpkt_or_notif_sane): Likewise.
11926 (class remote_target) <putpkt>: New overload.
11927 (remote_target::read_frame): Change type of "buf_p". Remove
11928 sizeof_p parameter.
11929 (packet_ok): New overload.
11930 (packet_check_result): New overload.
11931 Update all uses.
11932
bb277751
TT
119332019-01-14 Tom Tromey <tom@tromey.com>
11934
11935 * remote-notif.c (handle_notification, remote_notif_ack)
11936 (remote_notif_parse): Make "buf" const.
11937 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11938 const.
11939 (remote_notif_parse, remote_notif_ack, handle_notification):
11940 Likewise.
11941 * remote.c (remote_notif_stop_parse): Make "buf" const.
11942 (remote_target::remote_parse_stop_reply): Make "buf" const.
11943 (remote_notif_stop_ack): Make "buf" const.
11944
05be00a8
TT
119452019-01-14 Tom Tromey <tom@tromey.com>
11946
11947 * remote.c (remote_console_output): Make parameter const.
11948
491adeca
TT
119492019-01-14 Tom Tromey <tom@tromey.com>
11950
11951 * target-debug.h (target_debug_print_signals): Constify.
11952 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11953 * procfs.c (procfs_target::pass_signals): Update.
11954 * linux-nat.c (linux_nat_target::pass_signals): Update.
11955 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11956 * target-delegates.c: Rebuild.
11957 * remote.c (remote_target::program_signals): Update.
11958 (remote_target::pass_signals): Update.
11959 * target.c (target_pass_signals): Constify argument.
11960 (target_program_signals): Likewise.
11961 * target.h (struct target_ops) <pass_signals, program_signals>:
11962 Constify argument.
11963 (target_pass_signals, target_program_signals): Constify argument.
11964
bbd94648
TT
119652019-01-14 Tom Tromey <tom@tromey.com>
11966
11967 PR tui/28819:
11968 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11969
6f072a10
PFC
119702019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11971
11972 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11973 field.
11974 * rs6000-tdep.c: Include reggroups.h.
11975 (IS_V_ALIAS_PSEUDOREG): Define.
11976 (rs6000_register_name): Return names for the "vX" aliases.
11977 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11978 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11979 aliases. Call default_register_reggroup_p for all other
11980 pseudo-registers.
11981 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11982 New functions.
11983 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11984 Handle "vX" aliases.
11985 (v_alias_pseudo_register_collect): New function.
11986 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11987 (rs6000_gdbarch_init): Initialize "vX" aliases as
11988 pseudo-registers. Restore registration of
11989 rs6000_pseudo_register_reggroup_p with
11990 set_tdesc_pseudo_register_reggroup_p.
11991
1a782351
MF
119922019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11993
11994 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11995 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11996 set_gdbarch_num_pseudo_regs.
11997
d73cff18
PW
119982019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11999
12000 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12001 Remove arg prefixname, add do_set and do_show.
12002 Add member functions set_list and show_list.
12003 * cli/cli-style.c (class cli_style_option): Update accordingly.
12004 (style_set_list): Move to file scope.
12005 (style_show_list): Likewise.
12006 (set_style): Call help_list.
12007 (show_style): Call cmd_show_list.
12008 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12009 Update to use the new macro.
12010
60a90376
JB
120112019-10-12 Joel Brobecker <brobecker@adacore.com>
12012
12013 * ada-lang.c (_initialize_ada_language): Expand the help text
12014 for the "catch exception" command.
12015
9d7c67bf
PW
120162019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12017
12018 * symtab.c (matching_obj_sections): Initialize obj,
12019 declare it closer to its usage.
12020
7cf47dc4
TT
120212019-01-10 Tom Tromey <tom@tromey.com>
12022
12023 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12024 (basic_inf_threads_range): Remove.
12025 (inf_threads_range, inf_non_exited_threads_range)
12026 (safe_inf_threads_range): Use next_adapter.
12027
d3cb6808
KS
120282019-01-10 Keith Seitz <keiths@redhat.com>
12029
12030 PR gdb/23712
12031 PR symtab/23010
12032 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12033 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12034
63a20375
KS
120352019-01-10 Keith Seitz <keiths@redhat.com>
12036
12037 PR gdb/23712
12038 PR symtab/23010
12039 * dictionary.c (pending_to_vector): Remove.
12040 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12041 Remove _1 suffix, replacing functions of the same name. Update
12042 all callers.
12043 (dict_create_hashed, dict_create_hashed_expandable)
12044 (dict_create_linear, dict_create_linear_expandable, dict_free)
12045 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12046 Make functions static.
12047
b026f593
KS
120482019-01-10 Keith Seitz <keiths@redhat.com>
12049
12050 PR gdb/23712
12051 PR symtab/23010
12052 * dictionary.h (struct dictionary): Replace declaration with
12053 multidictionary.
12054 (dict_create_hashed, dict_create_hashed_expandable)
12055 (dict_create_linear, dict_create_linear_expandable)
12056 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12057 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12058 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12059 taking multidictionary argument.
12060 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12061 * block.h (struct block) <dict>: Change to multidictionary
12062 and rename `multidict'.
12063 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12064 symmisc.c: Update all dictionary references to multidictionary.
12065
c7748ee9
KS
120662019-01-10 Keith Seitz <keiths@redhat.com>
12067
12068 PR gdb/23712
12069 PR symtab/23010
12070 * dictionary.c: Include unordered_map.
12071 (pending_to_vector): New function.
12072 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12073 Rewrite the non-"_1" functions to take vector instead
12074 of linked list.
12075 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12076 "new" _1 versions of the same name.
12077 (multidictionary): Define.
12078 (std::hash<enum language): New definition.
12079 (collate_pending_symbols_by_language, mdict_create_hashed)
12080 (mdict_create_hashed_expandable, mdict_create_linear)
12081 (mdict_create_linear_expandable, mdict_free)
12082 (find_language_dictionary, create_new_language_dictionary)
12083 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12084 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12085 (mdict_size, mdict_empty): New functions.
12086 * dictionary.h (mdict_iterator): Define.
12087
67aa1f3c
PA
120882019-01-10 Pedro Alves <palves@redhat.com>
12089
12090 * breakpoint.c (read_uploaded_action)
12091 (create_tracepoint_from_upload): Adjust to use
12092 gdb::unique_xmalloc_ptr.
12093 * ctf.c (ctf_write_uploaded_tp):
12094 (SET_ARRAY_FIELD): Use emplace_back.
12095 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12096 * tracefile-tfile.c (tfile_write_uploaded_tp):
12097 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12098 gdb::unique_xmalloc_ptr.
12099 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12100 at_string, cond_string, cmd_strings>: Replace char pointers
12101 with gdb::unique_xmalloc_ptr.
12102
2f667667
PA
121032019-01-10 Pedro Alves <palves@redhat.com>
12104
12105 * solib-target.c (library_list_start_library): Don't xstrdup name.
12106
36cb7237
PA
121072019-01-10 Pedro Alves <palves@redhat.com>
12108
12109 * mdebugread.c (parse_partial_symbols): Use
12110 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12111
da584958
AB
121122019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12113
12114 * linux-fork.c (scoped_switch_fork_info)
12115 <~scoped_switch_fork_info>: Fix incorrect variable name.
12116
1ef8573c
AB
121172019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12118
12119 * linux-fork.c (scoped_switch_fork_info)
12120 <scoped_switch_fork_info>: Make explicit.
12121 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12122
8d7bcccb
TT
121232019-01-10 Tom Tromey <tom@tromey.com>
12124
12125 * objfiles.h (objfile::reset_psymtabs): Update.
12126 * objfiles.c (objfile::objfile): Update.
12127 * psymtab.h (psymtab_storage::obstack): Update.
12128 (psymtab_storage::m_obstack): Use gdb::optional.
12129 (class psymtab_storage): Update comment. Remove objfile
12130 parameter.
12131 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12132
b596a3c7
TT
121332019-01-10 Tom Tromey <tom@tromey.com>
12134
12135 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12136 <free_psymtabs>: Now private.
12137 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12138 (allocate_psymtab): Use new method.
12139
a9342b62
TT
121402019-01-10 Tom Tromey <tom@tromey.com>
12141
12142 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12143 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12144 * mdebugread.c (parse_partial_symbols): Use
12145 allocate_dependencies.
12146 * dwarf2read.c (dwarf2_create_include_psymtab): Use
12147 allocate_dependencies.
12148 (process_psymtab_comp_unit_reader)
12149 (build_type_psymtab_dependencies): Likewise.
12150 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12151
5af70966
TT
121522019-01-10 Tom Tromey <tom@tromey.com>
12153
12154 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12155 PSYMBOL_SET_LANGUAGE.
12156 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12157
5923a04c
TT
121582019-01-10 Tom Tromey <tom@tromey.com>
12159
12160 * psymtab.h (psymtab_storage::obstack): New method.
12161 <m_obstack>: Rename from obstack; now private.
12162 * psymtab.c (psymtab_storage): Update.
12163 * dwarf2read.c (create_addrmap_from_index)
12164 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12165 Update.
12166
6d6a12bf
TT
121672019-01-10 Tom Tromey <tom@tromey.com>
12168
12169 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12170 * objfiles.h (objfile::reset_psymtabs): New method.
12171
d320c2b5
TT
121722019-01-10 Tom Tromey <tom@tromey.com>
12173
12174 * symmisc.c (print_symbol_bcache_statistics): Update.
12175 (print_objfile_statistics): Update.
12176 * symfile.c (reread_symbols): Update.
12177 * psymtab.h (class psymtab_storage): New.
12178 * psymtab.c (psymtab_storage): New constructor.
12179 (~psymtab_storage): New destructor.
12180 (require_partial_symbols): Update.
12181 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12182 (find_pc_sect_psymtab, find_pc_sect_psymbol)
12183 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12184 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12185 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12186 (start_psymtab_common, end_psymtab_common)
12187 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12188 (allocate_psymtab): Update.
12189 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12190 Update.
12191 (dump_psymtab_addrmap, maintenance_print_psymbols)
12192 (maintenance_check_psymtabs): Update.
12193 (class objfile_psymtabs): Move to objfiles.h.
12194 * psympriv.h (discard_psymtab): Now inline.
12195 (psymtab_discarder::psymtab_discarder): Update.
12196 (psymtab_discarder::~psymtab_discarder): Update.
12197 (ALL_OBJFILE_PSYMTABS): Rewrite.
12198 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12199 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12200 Remove fields.
12201 <partial_symtabs>: New field.
12202 (class objfile_psymtabs): Move from psymtab.h. Update.
12203 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12204 psymbol_cache.
12205 (objfile::~objfile): Don't destroy psymbol_cache.
12206 * mdebugread.c (parse_partial_symbols): Update.
12207 * dwarf2read.c (create_addrmap_from_index)
12208 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12209 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12210 (add_partial_subprogram, dwarf2_ranges_read): Update.
12211 * dwarf-index-write.c (write_address_map)
12212 (write_one_signatured_type, recursively_write_psymbols)
12213 (class debug_names, class debug_names, write_psymtabs_to_index):
12214 Update.
12215
1d94a5a3
TT
122162019-01-10 Tom Tromey <tom@tromey.com>
12217
12218 * symtab.h (SYMBOL_SET_NAMES): Update.
12219 (symbol_set_names): Update.
12220 (MSYMBOL_SET_NAMES): Update.
12221 * symtab.c (symbol_set_names): Change argument to be an
12222 objfile_per_bfd_storage.
12223 * psymtab.c (add_psymbol_to_bcache): Update.
12224 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12225
0f14768a
TT
122262019-01-10 Tom Tromey <tom@tromey.com>
12227
12228 * symtab.c (create_demangled_names_hash): Change argument to be an
12229 objfile_per_bfd_storage.
12230 (symbol_set_names): Update.
12231
6eee24ce
TT
122322019-01-10 Tom Tromey <tom@tromey.com>
12233
12234 * xcoffread.c (xcoff_initial_scan): Unconditionally call
12235 init_psymbol_list.
12236 * psymtab.c (init_psymbol_list): Do nothing if already called.
12237 * psympriv.h (init_psymbol_list): Add comment.
12238 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12239 init_psymbol_list.
12240 * dbxread.c (dbx_symfile_read): Unconditionally call
12241 init_psymbol_list.
12242
75aedd27
TT
122432019-01-10 Tom Tromey <tom@tromey.com>
12244
12245 * xcoffread.c (scan_xcoff_symtab): Update.
12246 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12247 "where".
12248 * mdebugread.c (parse_partial_symbols)
12249 (handle_psymbol_enumerators): Update.
12250 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12251 * dbxread.c (read_dbx_symtab): Update.
12252 * psympriv.h (psymbol_placement): New enum.
12253 (add_psymbol_to_list): Update.
12254
939652a5
TT
122552019-01-10 Tom Tromey <tom@tromey.com>
12256
12257 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12258 static_psymbols parameters.
12259 (scan_xcoff_symtab): Update.
12260 * psymtab.c (start_psymtab_common): Remove global_psymbols and
12261 static_psymbols parameters.
12262 * psympriv.h (start_psymtab_common): Update.
12263 * mdebugread.c (parse_partial_symbols): Update.
12264 * dwarf2read.c (create_partial_symtab): Update.
12265 * dbxread.c (read_dbx_symtab): Update.
12266 (start_psymtab): Remove global_psymbols and static_psymbols
12267 parameters.
12268
baa62830
TT
122692019-01-10 Tom Tromey <tom@tromey.com>
12270
12271 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12272 * psymtab.c (allocate_psymtab): Add comment.
12273 * psympriv.h (allocate_psymtab): Add comment.
12274 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12275 initializations.
12276 * dbxread.c (dbx_end_psymtab): Remove some initializations.
12277
0e8f53ba
TT
122782019-01-10 Tom Tromey <tom@tromey.com>
12279
12280 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12281 Don't declare.
12282 * mipsread.c: Include mdebugread.h.
12283 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12284 Declare.
12285 * elfread.c: Include mdebugread.h.
12286
b22a7c6a
TT
122872019-01-09 Tom Tromey <tom@tromey.com>
12288
12289 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12290 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12291 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12292 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12293 (psym_lookup_symbol, psym_find_last_source_symtab)
12294 (psym_forget_cached_source_info, psym_print_stats)
12295 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12296 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12297 (psym_map_matching_symbols, psym_expand_symtabs_matching)
12298 (psym_find_compunit_symtab_by_address)
12299 (maintenance_print_psymbols, maintenance_info_psymtabs)
12300 (maintenance_check_psymtabs): Use ranged for.
12301 * psymtab.h (class objfile_psymtabs): New.
12302 (require_partial_symbols): Return objfile_psymtabs.
12303 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12304
3b9d3ac2
TT
123052019-01-09 Tom Tromey <tom@tromey.com>
12306
12307 * symfile.c (overlay_invalidate_all, find_pc_overlay)
12308 (find_pc_mapped_section, list_overlays_command)
12309 (map_overlay_command, unmap_overlay_command)
12310 (simple_overlay_update): Use all_objfiles.
12311 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12312 * printcmd.c (info_symbol_command): Use all_objfiles.
12313 * objfiles.h (ALL_OBJSECTIONS): Remove.
12314 * maint.c (maintenance_translate_address): Use all_objfiles.
12315 * gcore.c (gcore_create_callback): Use all_objfiles.
12316 (objfile_find_memory_regions): Likewise.
12317
8b31193a
TT
123182019-01-09 Tom Tromey <tom@tromey.com>
12319
12320 * symtab.c (find_line_symtab, info_sources_command)
12321 (make_source_files_completion_list): Use objfile_compunits.
12322 * source.c (select_source_symtab): Use objfile_compunits.
12323 * objfiles.h (struct objfile): Update comment.
12324 (ALL_OBJFILES): Remove.
12325 (ALL_FILETABS): Remove.
12326 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12327 objfile_compunits.
12328
d5da8b3c
TT
123292019-01-09 Tom Tromey <tom@tromey.com>
12330
12331 * symmisc.c (print_objfile_statistics, dump_objfile)
12332 (maintenance_print_symbols): Use compunit_filetabs.
12333 * source.c (forget_cached_source_info_for_objfile): Use
12334 compunit_filetabs.
12335 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12336 (ALL_FILETABS): Use compunit_filetabs.
12337 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12338 * coffread.c (coff_symtab_read): Use compunit_filetabs.
12339
5accd1a0
TT
123402019-01-09 Tom Tromey <tom@tromey.com>
12341
12342 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12343 (compunit_filetabs): New.
12344 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12345 compunit_filetabs.
12346 (info_sources_command, make_source_files_completion_list): Remove
12347 declaration.
12348 * symmisc.c (print_objfile_statistics, dump_objfile)
12349 (maintenance_print_symbols): Remove declaration.
12350 (maintenance_info_symtabs): Use compunit_filetabs.
12351 (maintenance_info_line_tables): Likewise.
12352 * source.c (select_source_symtab): Change local variable name.
12353 (forget_cached_source_info_for_objfile): Remove declaration.
12354 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12355 * objfiles.c (objfile_relocate1): Remove declaration.
12356 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12357 declaration.
12358 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12359 * coffread.c (coff_symtab_read): Remove declaration.
12360 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12361 compunit_filetabs.
12362
d8aeb77f
TT
123632019-01-09 Tom Tromey <tom@tromey.com>
12364
12365 * symtab.c (lookup_objfile_from_block)
12366 (find_pc_sect_compunit_symtab, search_symbols)
12367 (default_collect_symbol_completion_matches_break_on): Use
12368 objfile_compunits.
12369 * objfiles.h (ALL_COMPUNITS): Remove.
12370 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12371 * cp-support.c (add_symbol_overload_list_qualified): Use
12372 objfile_compunits.
12373 * ada-lang.c (ada_collect_symbol_completion_matches)
12374 (ada_add_global_exceptions): Use objfile_compunits.
12375
592553c4
TT
123762019-01-09 Tom Tromey <tom@tromey.com>
12377
12378 * source.c (select_source_symtab)
12379 (forget_cached_source_info_for_objfile): Remove declaration.
12380 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12381 declaration.
12382 * maint.c (count_symtabs_and_blocks): Remove declaration.
12383 * cp-support.c (add_symbol_overload_list_qualified): Remove
12384 declaration.
12385 * coffread.c (coff_symtab_read): Remove declaration.
12386 * symtab.c (lookup_symbol_in_objfile_symtabs)
12387 (basic_lookup_transparent_type_1): Use objfile_compunits.
12388 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12389 (info_sources_command, search_symbols)
12390 (default_collect_symbol_completion_matches_break_on)
12391 (make_source_files_completion_list): Remove declaration.
12392 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12393 (ada_collect_symbol_completion_matches)
12394 (ada_add_global_exceptions): Remove declaration.
12395 * linespec.c (iterate_over_all_matching_symtabs): Use
12396 objfile_compunits.
12397 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12398 (class objfile_compunits): New.
12399 (ALL_COMPUNITS): Use objfile_compunits.
12400 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12401 (maintenance_check_symtabs, maintenance_info_line_tables): Use
12402 objfile_compunits.
12403 * objfiles.c (objfile_relocate1): Use objfile_compunits.
12404
5325b9bf
TT
124052019-01-09 Tom Tromey <tom@tromey.com>
12406
12407 * symtab.c (search_symbols)
12408 (default_collect_symbol_completion_matches_break_on): Use
12409 objfile_msymbols.
12410 * ada-lang.c (ada_lookup_simple_minsym)
12411 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12412 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12413 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12414 objfile_msymbols.
12415 * coffread.c (coff_symfile_read): Use objfile_msymbols.
12416 * symmisc.c (dump_msymbols): Use objfile_msymbols.
12417 * objc-lang.c (find_methods): Use objfile_msymbols.
12418 (info_selectors_command, info_classes_command): Likewise.
12419 * stabsread.c (scan_file_globals): Use objfile_msymbols.
12420 * objfiles.h (class objfile_msymbols): New.
12421 (ALL_OBJFILE_MSYMBOLS): Remove.
12422 (ALL_MSYMBOLS): Remove.
12423
cac85af2
TT
124242019-01-09 Tom Tromey <tom@tromey.com>
12425
12426 * common/next-iterator.h (next_adapter): Add Iterator template
12427 parameter.
12428 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12429 (class all_objfiles_safe): New.
12430 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12431 * objfiles.c (put_objfile_before): Update comment.
12432 (add_separate_debug_objfile): Likewise.
12433 (free_all_objfiles): Use all_objfiles_safe.
12434 (objfile_purge_solibs): Likewise.
12435
aed57c53
TT
124362019-01-09 Tom Tromey <tom@tromey.com>
12437
12438 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12439 (expand_symtab_containing_pc, lookup_static_symbol)
12440 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12441 (find_symbol_at_address, find_line_symtab, find_main_name): Use
12442 all_objfiles.
12443 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12444 * breakpoint.c (create_overlay_event_breakpoint)
12445 (create_longjmp_master_breakpoint)
12446 (create_std_terminate_master_breakpoint)
12447 (create_exception_master_breakpoint): Use all_objfiles.
12448 * linux-thread-db.c (try_thread_db_load_from_pdir)
12449 (has_libpthread): Use all_objfiles.
12450 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12451 * linespec.c (iterate_over_all_matching_symtabs)
12452 (search_minsyms_for_name): Use all_objfiles.
12453 * maint.c (maintenance_info_sections): Use all_objfiles.
12454 * main.c (captured_main_1): Use all_objfiles.
12455 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12456 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12457 * guile/scm-pretty-print.c
12458 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12459 * solib-spu.c (append_ocl_sos): Use all_objfiles.
12460 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12461 (maintenance_print_msymbols): Use all_objfiles.
12462 * source.c (select_source_symtab): Use all_objfiles.
12463 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12464 * symfile.c (remove_symbol_file_command)
12465 (expand_symtabs_matching, map_symbol_filenames): Use
12466 all_objfiles.
12467 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12468 all_objfiles.
12469 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12470 * objc-lang.c (find_methods): Use all_objfiles.
12471 * objfiles.c (have_partial_symbols, have_full_symbols)
12472 (have_minimal_symbols, qsort_cmp)
12473 (default_iterate_over_objfiles_in_search_order): Use
12474 all_objfiles.
12475 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12476 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12477 (maintenance_check_psymtabs): Use all_objfiles.
12478 (ALL_PSYMTABS): Remove.
12479 * compile/compile-object-run.c (do_module_cleanup): Use
12480 all_objfiles.
12481 * blockframe.c (find_pc_partial_function): Use all_objfiles.
12482 * cp-support.c (add_symbol_overload_list_qualified): Use
12483 all_objfiles.
12484 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12485 Use all_objfiles.
12486 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12487 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12488 all_objfiles.
12489 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12490 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12491 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12492 Uses all_objfiles.
12493 * solib.c (solib_read_symbols): Use all_objfiles
12494
99d89cde
TT
124952019-01-09 Tom Tromey <tom@tromey.com>
12496
12497 * probe.c (parse_probes_in_pspace): Use all_objfiles.
12498 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12499 all_objfiles.
12500 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12501 * symmisc.c (print_symbol_bcache_statistics)
12502 (print_objfile_statistics, maintenance_print_objfiles)
12503 (maintenance_info_symtabs, maintenance_check_symtabs)
12504 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12505 all_objfiles.
12506 * source.c (forget_cached_source_info): Use all_objfiles.
12507 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12508 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12509 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12510 * objfiles.c (update_section_map): Use all_objfiles.
12511 (shared_objfile_contains_address_p): Likewise.
12512 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12513 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12514
21708325
TT
125152019-01-09 Tom Tromey <tom@tromey.com>
12516
12517 * common/next-iterator.h: New file.
12518 * objfiles.h (class all_objfiles): New.
12519 (struct objfile_iterator): New.
12520
669e09f6
PW
125212019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12522
12523 * NEWS: Move the description of the changed "frame", "select-frame",
12524 and "info frame" commands to the Changed commands section.
12525
041be526
SM
125262019-01-09 Simon Marchi <simon.marchi@ericsson.com>
12527
12528 * gdbtypes.c (check_stub_method_group): Remove handling of old
12529 mangling schemes.
12530 * linespec.c (find_methods): Likewise.
12531 * stabsread.c (read_member_functions): Likewise.
12532 * valops.c (search_struct_method): Likewise.
12533 (value_struct_elt_for_reference): Likewise.
12534 * NEWS: Mention this change.
12535
0e2a2133
AB
125362019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
12537
12538 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12539 print_source_lines.
12540 * source.c (print_source_lines_base): Update line number check.
12541 (print_source_lines): New function.
12542 (source_lines_range::source_lines_range): New function.
12543 * source.h (class source_lines_range): New class.
12544 (print_source_lines): New declaration.
12545
1055a3b4
PW
125462019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12547
12548 * linespec.c (linespec_state_destructor): Free self->canonical_names.
12549
cfeadda5
TT
125502019-01-08 Tom Tromey <tom@tromey.com>
12551 Simon Marchi <simon.marchi@ericsson.com>
12552
12553 PR gdb/24060
12554 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12555 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12556 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12557 * f-exp.y (DOLLAR_VARIABLE): Likewise.
12558 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12559 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12560
583068ca
AB
125612019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12562
12563 * source.c (select_source_symtab): Move header comment to
12564 declaration in source.h.
12565 (forget_cached_source_info_for_objfile): Likewise.
12566 (forget_cached_source_info): Likewise.
12567 (identify_source_line): Likewise.
12568 * source.h (identify_source_line): Move declaration from symtab.h
12569 and add comment from source.c
12570 (print_source_lines): Likewise.
12571 (forget_cached_source_info_for_objfile): Likewise.
12572 (forget_cached_source_info): Likewise.
12573 (select_source_symtab): Likewise.
12574 (enum print_source_lines_flag): Move definition from symtab.h.
12575 * symtab.h (identify_source_line): Move declaration to source.h.
12576 (print_source_lines): Likewise.
12577 (forget_cached_source_info_for_objfile): Likewise.
12578 (forget_cached_source_info): Likewise.
12579 (select_source_symtab): Likewise.
12580 (enum print_source_lines_flag): Move definition to source.h.
12581 * tui/tui-hooks.c: Add 'source.h' include.
12582
ec98a4ad
AB
125832019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12584
12585 * source.c (print_source_lines_base): Handle requests to print
12586 reverse line number sequences, and guard against empty lines
12587 string.
12588
62ea19c1
AB
125892019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12590
12591 * source.c (print_source_lines_base): Fix skip of '\r' if next
12592 character is '\n'.
12593
9d30e1fd
TT
125942019-01-06 Tom Tromey <tom@tromey.com>
12595
12596 * c-exp.y (struct c_parse_state) <macro_original_text,
12597 expansion_obstack>: New member.
12598 (macro_original_text, expansion_obstack): Remove globals.
12599 (scan_macro_expansion, scanning_macro_expansion)
12600 (finished_macro_expansion): Update.
12601 (scan_macro_cleanup): Remove.
12602 (yylex, c_parse): Update.
12603
c65bac38
TT
126042019-01-06 Tom Tromey <tom@tromey.com>
12605
12606 * c-exp.y (struct c_parse_state) <strings>: New member.
12607 (operator_stoken): Update.
12608
02e12e38
TT
126092019-01-06 Tom Tromey <tom@tromey.com>
12610
12611 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12612 (union type_stack_elt) <typelist_val>: Now a pointer to
12613 std::vector.
12614 (type_stack_cleanup): Don't declare.
12615 (push_typelist): Update.
12616 * parse.c (pop_typelist): Return a std::vector.
12617 (push_typelist): Take a std::vector.
12618 (follow_types): Update. Do not free args.
12619 (type_stack_cleanup): Remove.
12620 * c-exp.y (struct c_parse_state): New.
12621 (cpstate): New global.
12622 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12623 (nonempty_typelist): Update.
12624 (func_mod): Create a new vector.
12625 (c_parse): Create a c_parse_state.
12626 (check_parameter_typelist): Do not delete params.
12627 (function_method): Update. Do not delete type_list.
12628
f097f5ad
TT
126292019-01-06 Tom Tromey <tom@tromey.com>
12630
12631 PR gdb/28155:
12632 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12633 check_typedef.
12634 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12635 (print_return_value): Likewise.
12636
d2adf9f1
TT
126372019-01-05 Tom Tromey <tom@tromey.com>
12638
12639 * contrib/cleanup_check.py: Remove.
12640 * contrib/gcc-with-excheck: Remove.
12641 * contrib/exsummary.py: Remove.
12642 * contrib/excheck.py: Remove.
12643
2eab46b1
JB
126442019-01-05 Joel Brobecker <brobecker@adacore.com>
12645
12646 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12647 NULL. Initialize tpprev to NULL instead of assigning it
12648 to NULL on the next statement.
12649 * windows-nat.c (windows_delete_thread): Remove check for
12650 main_thread_id before printing thread exit notifications.
12651 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12652 Remove thread ID check against main_thread_id.
12653 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12654 windows_delete_thread.
12655 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12656
48c5e7e2
TT
126572019-01-04 Tom Tromey <tom@tromey.com>
12658
12659 * compile/compile.c (_initialize_compile): Use upper case for
12660 metasyntactic variables.
12661 * symmisc.c (_initialize_symmisc): Use upper case for
12662 metasyntactic variables.
12663 * psymtab.c (_initialize_psymtab): Use upper case for
12664 metasyntactic variables.
12665 * demangle.c (demangle_command): Use upper case for metasyntactic
12666 variables.
12667 (_initialize_demangler): Likewise.
12668 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12669 variables.
12670
986041cd
TT
126712019-01-03 Tom Tromey <tom@tromey.com>
12672
12673 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12674
7c711119
TT
126752019-01-03 Tom Tromey <tom@tromey.com>
12676
12677 * python/py-symtab.c (salpy_str): Update.
12678 (struct salpy_sal_object) <symtab>: Now a PyObject.
12679 (salpy_dealloc): Update.
12680 (del_objfile_sal): Use gdbpy_ref.
12681
1b20edf0
TT
126822019-01-03 Tom Tromey <tom@tromey.com>
12683
12684 * python/py-type.c (convert_field): Use new_reference. Return
12685 gdbpy_ref.
12686 (make_fielditem): Return gdbpy_ref.
12687 (typy_fields): Update.
12688 (typy_getitem): Update.
12689 (field_name): Return gdbpy_ref. Use new_reference.
12690 (typy_iterator_iternext): Update.
12691
ea41325b
TT
126922019-01-03 Tom Tromey <tom@tromey.com>
12693
12694 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12695
2a3c71d6
TT
126962019-01-03 Tom Tromey <tom@tromey.com>
12697
12698 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12699 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12700 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12701 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12702 (pspy_set_type_printers): Likewise.
12703 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12704 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12705 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12706 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12707 (objfpy_set_type_printers): Likewise.
12708
5c329e6a
TT
127092019-01-03 Tom Tromey <tom@tromey.com>
12710
12711 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12712 (gdbpy_print_stack): Use gdbpy_err_fetch.
12713 * python/python-internal.h (class gdbpy_err_fetch): New class.
12714 (class gdbpy_enter) <m_error_type, m_error_value,
12715 m_error_traceback>: Remove.
12716 <m_error>: New member.
12717 (gdbpy_exception_to_string): Don't declare.
12718 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12719 * python/py-value.c (convert_value_from_python): Use
12720 gdbpy_err_fetch.
12721 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12722 gdbpy_exception_to_string.
12723 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12724 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12725 gdbpy_err_fetch.
12726
169bb27b
AB
127272019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12728
12729 * linux-nat.c (delete_lwp_cleanup): Delete.
12730 (struct lwp_deleter): New struct.
12731 (lwp_info_up): New typedef.
12732 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12733 lwp_info_up.
12734
a07c8880
AB
127352019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12736
12737 * linux-fork.c (class scoped_switch_fork_info): New class.
12738 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12739
26089c49
AB
127402019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12741
12742 * valops.c (find_overload_match): Remove use of null_cleanup, and
12743 calls to do_cleanups.
12744
06d3e5b0
AB
127452019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12746
12747 * compile/compile-cplus-types.c
12748 (compile_cplus_instance::decl_name): Handle changes to
12749 cp_func_name.
12750 * cp-support.c (cp_func_name): Update header comment, update
12751 return type.
12752 * cp-support.h (cp_func_name): Update return type in declaration.
12753 * valops.c (find_overload_match): Move temp_func local to top
12754 level of function and change its type. Use temp_func to hold and
12755 delete temporary string obtained from cp_func_name.
12756
66644cd3
AB
127572019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12758
12759 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12760 gdb::char_vector, remove cleanup, and update uses of `msg`.
12761
592d8c0a
JW
127622019-01-03 Jim Wilson <jimw@sifive.com>
12763
12764 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12765
c55d06ec
TT
127662019-01-02 Tom Tromey <tom@tromey.com>
12767
12768 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12769 (tdesc_parse_xml): Remove cleanups.
12770 * target-descriptions.h (make_cleanup_free_target_description):
12771 Don't declare.
12772 (target_desc_deleter): New struct.
12773 (target_desc_up): New typedef.
12774 * target-descriptions.c (target_desc_deleter::operator()): Rename
12775 from free_target_description.
12776 (make_cleanup_free_target_description): Remove.
12777
3a6ae42d
TT
127782019-01-02 Tom Tromey <tom@tromey.com>
12779
12780 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12781 constructor, destructor.
12782 (linespec_parser): Remove typedef.
12783 (~linespec_parser): Rename from linespec_parser_delete.
12784 (linespec_lex_to_end, linespec_complete_label)
12785 (linespec_complete): Update.
12786 (decode_line_full): Remove cleanups.
12787 (decode_line_1): Update.
12788
61fd3e73
TT
127892019-01-02 Tom Tromey <tom@tromey.com>
12790
12791 * python/python-internal.h (inferior_to_inferior_object): Change
12792 return type.
12793 * python/py-exitedevent.c (create_exited_event_object): Update.
12794 * python/py-inferior.c (inferior_to_inferior_object): Return
12795 gdbpy_ref.
12796 (python_new_inferior, python_inferior_deleted)
12797 (thread_to_thread_object, delete_thread_object)
12798 (build_inferior_list, gdbpy_selected_inferior): Update.
12799 * python/py-infthread.c (create_thread_object): Update. Also fail
12800 if inferior_to_inferior_object fails.
12801
d20172fc
SM
128022019-01-02 Simon Marchi <simon.marchi@ericsson.com>
12803
12804 * inferior.h (class inferior) <displaced_step_state>: New field.
12805 * infrun.h (struct displaced_step_state): Move here from
12806 infrun.c. Initialize fields, add constructor.
12807 <inf>: Remove field.
12808 <reset>: New method.
12809 * infrun.c (struct displaced_step_inferior_state): Move to
12810 infrun.h.
12811 (displaced_step_inferior_states): Remove.
12812 (get_displaced_stepping_state): Adust.
12813 (displaced_step_in_progress_any_inferior): Adjust.
12814 (displaced_step_in_progress_thread): Adjust.
12815 (displaced_step_in_progress): Adjust.
12816 (add_displaced_stepping_state): Remove.
12817 (get_displaced_step_closure_by_addr): Adjust.
12818 (remove_displaced_stepping_state): Remove.
12819 (infrun_inferior_exit): Call displaced_step_state.reset.
12820 (use_displaced_stepping): Don't check for NULL.
12821 (displaced_step_prepare_throw): Call
12822 get_displaced_stepping_state.
12823 (displaced_step_fixup): Don't check for NULL.
12824 (prepare_for_detach): Don't check for NULL.
12825
e3319240
PW
128262019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12827
12828 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12829 in case of call that did not complete.
12830
5d36dfb9
AU
128312019-01-02 Andrey Utkin <autkin@undo.io>
12832
12833 * symfile.c (find_separate_debug_file): Fix search of debug files for
12834 remote debuggee.
12835
8833fbf0
TT
128362019-01-02 Tom Tromey <tom@tromey.com>
12837
12838 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12839 indentation.
12840 * python/py-frame.c (frapy_older): Remove cast.
12841 (frapy_newer): Likewise.
12842 * python/py-breakpoint.c (local_setattro): Remove cast.
12843 * python/py-arch.c (archpy_name): Remove local variable.
12844 * python/py-type.c (gdbpy_lookup_type): Remove cast.
12845
4ada3dfd
JB
128462019-01-02 Joel Brobecker <brobecker@adacore.com>
12847
12848 * unittests/basic_string_view/element_access/char/empty.cc:
12849 Fix year range in copyright header.
12850
113b7b81
AB
128512019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
12852
12853 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12854 Delete.
12855 <operator==>: Update with for removed field.
12856 <hash>: Likewise.
12857 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12858 <isa_features>: ...this.
12859 <abi_features>: New field.
12860 (riscv_isa_flen): Update comment.
12861 (riscv_abi_xlen): New declaration.
12862 (riscv_abi_flen): New declaration.
12863 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12864 isa_features.
12865 (riscv_abi_xlen): New function.
12866 (riscv_isa_flen): Update to get answer from isa_features.
12867 (riscv_abi_flen): New function.
12868 (riscv_has_fp_abi): Update to get answer from abi_features.
12869 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12870 xlen and flen.
12871 (riscv_call_info) <xlen, flen>: Update comment.
12872 (riscv_call_arg_struct): Remove invalid assertions
12873 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12874 is removed.
12875 (riscv_gdbarch_init): Gather isa features and abi features
12876 separately, ensure both match on the gdbarch when reusing an old
12877 gdbarch. Relax an error check to allow 32-bit abi float to run on
12878 a target with 64-bit float hardware.
12879
b18ca514
PW
128802019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12881
12882 * source.c (search_command_helper): Stop reverse search
12883 when line 1 has been searched.
12884
ec70d8db
PW
128852019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12886
12887 * record-full.c (record_full_base_target::close): Rewrite
12888 record_full_core_buf_list free logic.
12889
5b38f9c1
PW
128902019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12891
12892 * break-catch-syscall.c (print_one_catch_syscall): xfree
12893 the last text.
12894
66d91b39
JB
128952019-01-01 Joel Brobecker <brobecker@adacore.com>
12896
12897 * top.c (print_gdb_version): Update Copyright year in version
12898 message.
12899
42a4f53d
JB
129002019-01-01 Joel Brobecker <brobecker@adacore.com>
12901
12902 Update copyright year range in all GDB files.
12903
7e955d83 129042019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 12905
5bbd631d 12906 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 12907
5bbd631d 12908For older changes see ChangeLog-2018.
c906108c
SS
12909\f
12910Local Variables:
12911mode: change-log
12912left-margin: 8
12913fill-column: 74
12914version-control: never
57da7796 12915coding: utf-8
c906108c 12916End:
5bbd631d 12917
This page took 2.867872 seconds and 4 git commands to generate.