Introduce gdb-specific %p format suffixes
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
2a3c1174
PA
12019-10-01 Pedro Alves <palves@redhat.com>
2 Tom Tromey <tom@tromey.com>
3
4 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
5 (test_gdb_formats): New function.
6 (run_tests): Call it.
7 (test_format_specifier): Update.
8 * utils.h (fputs_filtered): Update comment.
9 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
10 (fputs_styled_unfiltered): Declare.
11 * utils.c (fputs_styled_unfiltered): New function.
12 (vfprintf_maybe_filtered): Add gdbfmt parameter.
13 (vfprintf_filtered): Update.
14 (vfprintf_unfiltered, vprintf_filtered): Update.
15 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
16 * ui-out.h (enum ui_out_flag) <unfiltered_output,
17 disallow_ui_out_field>: New constants.
18 (enum class field_kind): New.
19 (struct base_field_s, struct signed_field_s): New.
20 (signed_field): New function.
21 (struct string_field_s): New.
22 (string_field): New function.
23 (struct styled_string_s): New.
24 (styled_string): New function.
25 (class ui_out) <message>: Add comment.
26 <vmessage, call_do_message>: New methods.
27 <do_message>: Add style parameter.
28 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
29 methods.
30 (ui_out::message): Rewrite.
31 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
32 parameter.
33 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
34 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
35 gdb_extensions parameter.
36 (class format_piece): Add parameter to constructor.
37 (n_int_args): New field.
38 * gdbsupport/format.c (format_pieces::format_pieces): Add
39 gdb_extensions parameter. Handle '*'.
40 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
41 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
42 vfprintf_styled_no_gdbfmt.
43 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
44 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
45 unfiltered output.
46 * ui-style.h (struct ui_file_style) <ptr>: New method.
47
0dfe5bfb
TT
482019-10-01 Tom Tromey <tom@tromey.com>
49
50 * unittests/format_pieces-selftests.c: Update. Add final format.
51 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
52 empty literal pieces.
53
e43b10e1
TT
542019-10-01 Tom Tromey <tom@tromey.com>
55
56 * ui-out.h (enum class ui_out_style_kind): Remove.
57 (class ui_out) <field_string, field_stsream, do_field_string>:
58 Change type of "style".
59 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
60 (ui_out::field_string): Update.
61 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
62 of "style".
63 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
64 * tracepoint.c (print_one_static_tracepoint_marker): Update.
65 * stack.c (print_frame_arg, print_frame_info, print_frame):
66 Update.
67 * source.c (print_source_lines_base): Update.
68 * solib.c (info_sharedlibrary_command): Update.
69 * skip.c (info_skip_command): Update.
70 * record-btrace.c (btrace_call_history_src_line)
71 (btrace_call_history): Update.
72 * python/py-framefilter.c (py_print_frame): Update.
73 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
74 "style".
75 * mi/mi-out.c (mi_ui_out::do_table_header)
76 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
77 (mi_ui_out::do_field_string): Update.
78 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
79 Update.
80 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
81 "style".
82 * cli-out.c (cli_ui_out::do_table_header)
83 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
84 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
85 (cli_ui_out::do_field_fmt): Update.
86 * breakpoint.c (print_breakpoint_location): Update.
87 (update_static_tracepoint): Update.
88
cd7c32c3
PW
892019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
90
91 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
92 conversion of gdb_datadir.
93 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
94 remove not needed c_str ().
95
8fe0f950
AT
962019-09-30 Ali Tamur <tamur@google.com>
97
98 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
99 (dwarf2_string_attr): Likewise.
100
5f48f8f3
AT
1012019-09-30 Ali Tamur <tamur@google.com>
102
103 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
104 (process_full_type_unit): Likewise.
105 (dump_die_shallow): Likewise.
106 (cu_debug_loc_section): Likewise.
107
6fb08628
CB
1082019-09-28 Christian Biesinger <cbiesinger@google.com>
109
110 * minsyms.c (compare_minimal_symbols): Rename to...
111 (minimal_symbol_is_less_than): ...this, and adjust to STL
112 conventions (return bool, take arguments as references)
113 (minimal_symbol_reader::install): Call std::sort instead
114 of qsort.
115
c7ee338a
CB
1162019-09-29 Christian Biesinger <cbiesinger@google.com>
117
118 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
119 hash and why.
120 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
121 msymbol_hash, msymbol_demangled_hash>: Improve comments.
122
703a86c2
SM
1232019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
124
125 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
126 * psympriv.h (add_psymbol_to_list): Move comment here and update
127 it.
128
0df0352a
TV
1292019-09-29 Tom de Vries <tdevries@suse.de>
130
131 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
132 Use $tmpdir/$(basename "$output_file").dwz instead of
133 "${output_file}.dwz".
134
ad75efa6
SM
1352019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
136
137 PR gdb/25045
138 * hppa-linux-nat.c: Include gdbarch.h.
139
ececd218
CB
1402019-09-26 Christian Biesinger <cbiesinger@google.com>
141
142 * blockframe.c (find_pc_partial_function): Change return type to bool.
143 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
144 * minsyms.c (in_gnu_ifunc_stub): Likewise.
145 (stub_gnu_ifunc_resolve_name): Likewise.
146 * symtab.c (compare_filenames_for_search): Likewise.
147 (compare_glob_filenames_for_search): Likewise.
148 (matching_obj_sections): Likewise.
149 (symbol_matches_domain): Likewise.
150 (find_line_symtab): Change out param EXACT_MATCH to bool *.
151 (find_line_pc): Change return type to bool.
152 (find_line_pc_range): Likewise.
153 (producer_is_realview): Likewise.
154 * symtab.h (symbol_matches_domain): Likewise.
155 (find_pc_partial_function): Likewise.
156 (find_pc_line_pc_range): Likewise.
157 (in_gnu_ifunc_stub): Likewise.
158 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
159 (find_line_pc): Likewise.
160 (find_line_pc_range): Likewise.
161 (matching_obj_sections): Likewise.
162 (find_line_symtab): Change out parameter to bool.
163 (producer_is_realview): Change return type to bool.
164 (compare_filenames_for_search): Likewise.
165 (compare_glob_filenames_for_search): Likewise.
166
27a900b8
TT
1672019-09-26 Tom Tromey <tom@tromey.com>
168
169 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
170 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
171 * gdb_usleep.h: Remove.
172 * gdb_usleep.c: Remove.
173 * utils.c: Don't include gdb_usleep.h.
174
5d63b30a
TT
1752019-09-26 Tom Tromey <tromey@adacore.com>
176
177 * python/py-type.c (type_to_type_object): Call check_typedef
178 for stub types.
179
12904d37
TT
1802019-09-26 Tom Tromey <tom@tromey.com>
181
182 * utils.h (initialize_utils): Don't declare.
183 * top.c (gdb_init): Don't call initialize_utils.
184 * utils.c (initialize_utils): Remove. Move contents...
185 (_initialize_utils): ... here.
186
858f25f0
TT
1872019-09-25 Tom Tromey <tom@tromey.com>
188
189 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
190 * utils.h (make_hex_string): Don't declare.
191 * utils.c (make_hex_string): Remove.
192
3d435220
TV
1932019-09-24 Tom de Vries <tdevries@suse.de>
194
195 PR gdb/23815
196 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
197 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
198
ddd44b70
DD
1992019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
200
201 * NEWS: Mention new simulator port for PRU.
202
f945dedf
CB
2032019-09-23 Christian Biesinger <cbiesinger@google.com>
204
205 * ada-exp.y (write_object_remaining): Update.
206 * ada-lang.c (ada_decode): Return a std::string instead of a char*
207 and eliminate the static buffer.
208 (ada_decode_symbol): Update.
209 (ada_la_decode): Update.
210 (ada_sniff_from_mangled_name): Update.
211 (is_valid_name_for_wild_match): Update.
212 (ada_lookup_name_info::matches): Update and simplify.
213 (name_matches_regex): Update.
214 (ada_add_global_exceptions): Update.
215 * ada-lang.h (ada_decode): Update signature.
216 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
217 * dwarf-index-write.c (debug_names::insert): Update.
218
7ab78ccb
SM
2192019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
220
221 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
222 formatting.
223
9252448b
SM
2242019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
225
226 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
227 Change "nonzero" to "true" in documentation.
228
626ca2c0
CB
2292019-09-20 Christian Biesinger <cbiesinger@google.com>
230
231 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
232 (_initialize_darwin_solib): Don't set
233 darwin_so_ops.lookup_lib_global_symbol.
234 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
235 set_gdbarch_iterate_over_objfiles_in_search_order.
236 (elf_lookup_lib_symbol): Rename to...
237 (svr4_iterate_over_objfiles_in_search_order): this, and update
238 to iterate semantics.
239 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
240 * solib.c (solib_global_lookup): Remove.
241 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
242 (solib_global_lookup): Remove.
243 * symtab.c (lookup_global_or_static_symbol): Remove call to
244 solib_global_lookup.
245
5a3a0d63
JB
2462019-09-20 Joel Brobecker <brobecker@adacore.com>
247
248 * NEWS: Move entries about default MI version now being
249 version 3, and about the GDB/MI fix for multi-location
250 breakpoints to the "since GDB 8.3" section.
251
ffea1427
JB
2522019-09-20 Joel Brobecker <brobecker@adacore.com>
253
254 GDB 8.3.1 released.
255
abf516c6
UW
2562019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
257
258 * NEWS: Mention that Cell/B.E. debugging support was removed.
259 * MAINTAINERS: Remove spu target.
260
261 * config/djgpp/fnchange.lst: Remove entries for removed files.
262
263 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
264 spu-multiarch.o, and spu-tdep.o.
265 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
266 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
267 spu-multiarch.c, and spu-tdep.c.
268 * spu-linux-nat.c: Remove file.
269 * spu-multiarch.c: Remove file.
270 * spu-tdep.c: Remove file.
271 * spu-tdep.h: Remove file.
272 * solib-spu.c: Remove file.
273 * solib-spu.h: Remove file.
274
275 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
276 * configure.nat (spu-linux): Remove.
277 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
278 solib-multiarch.o from gdb_target_obs.
279 (spu*-*-*): Remove.
280
281 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
282 feature flag.
283 (ppc_linux_no_features): Update.
284 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
285 Cell/B.E. support.
286 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
287 (tdesc_powerpc_cell64l): Likewise.
288 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
289 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
290 Cell/B.E. support.
291 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
292 Do not include "features/rs6000/powerpc-cell32l.c" or
293 "features/rs6000/powerpc-cell64l.c".
294 (ppc_linux_spu_section): Remove.
295 (ppc_linux_core_read_description): Remove Cell/B.E. support.
296 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
297 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
298 (ppc_linux_spe_context_lookup): Remove.
299 (ppc_linux_spe_context_inferior_created): Remove.
300 (ppc_linux_spe_context_solib_loaded): Remove.
301 (ppc_linux_spe_context_solib_unloaded): Remove.
302 (ppc_linux_spe_context): Remove.
303 (struct ppu2spu_cache): Remove.
304 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
305 (struct ppu2spu_data): Remove.
306 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
307 ppu2spu_unwind): Remove.
308 (ppc_linux_init_abi): Remove Cell/B.E. support.
309 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
310
311 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
312 (rs6000/powerpc-cell64l-expedite): Likewise
313 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
314 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
315 rs6000/powerpc-cell64l.xml.
316 * features/rs6000/powerpc-cell32l.xml: Remove.
317 * features/rs6000/powerpc-cell64l.xml: Likewise.
318 * features/rs6000/powerpc-cell32l.c: Remove generated file.
319 * features/rs6000/powerpc-cell64l.c: Likewise.
320 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
321 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
322 * regformats/reg-spu.dat: Remove.
323
324 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
325 * corelow.c (struct spuid_list): Remove.
326 (add_to_spuid_list): Remove.
327 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
328 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
329 (remote_protocol_features): Remove associated entries.
330 (_initialize_remote): No longer initialize them.
331 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
332 * linux-nat.c (SPUFS_MAGIC): Remove.
333 (linux_proc_xfer_spu): Remove.
334 (spu_enumerate_spu_ids): Remove.
335 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
336 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
337 (linux_make_corefile_notes): No longer call it.
338
339 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
340 (cooked_write_test): Likewise.
341
78e8cb91
TT
3422019-09-20 Tom Tromey <tom@tromey.com>
343
344 * NEWS: Mention case-sensitivity of TUI commands.
345 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
346 (tui_set_win_height_command, parse_scrolling_args): Likewise.
347 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
348
f074b67e
TT
3492019-09-20 Tom Tromey <tom@tromey.com>
350
351 * tui/tui-source.c (tui_source_window::set_contents): Use
352 make_unique_xstrdup.
353 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
354 make_unique_xstrdup.
355
63c4bf19
TT
3562019-09-20 Tom Tromey <tom@tromey.com>
357
358 * tui/tui-data.c: Remove separator comments.
359 * tui/tui-layout.c: Remove separator comments.
360 * tui/tui-win.c: Remove separator comments.
361 * tui/tui-wingeneral.c: Remove separator comments.
362
43df9b2f
TT
3632019-09-20 Tom Tromey <tom@tromey.com>
364
365 * tui/tui.h (strcat_to_buf): Don't declare.
366 * tui/tui.c (strcat_to_buf): Remove.
367
7226433c
TT
3682019-09-20 Tom Tromey <tom@tromey.com>
369
370 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
371 from "fullname".
372 * tui/tui-source.c (tui_source_window::set_contents)
373 (tui_source_window::location_matches_p)
374 (tui_source_window::maybe_update): Update.
375
80df3337
TT
3762019-09-20 Tom Tromey <tom@tromey.com>
377
378 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
379 Update.
380 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
381 prefix.
382 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
383 (tui_data_window::line_from_reg_element_no)
384 (tui_data_window::first_reg_element_no_inline)
385 (tui_data_window::show_registers)
386 (tui_data_window::show_register_group)
387 (tui_data_window::display_registers_from)
388 (tui_data_window::display_registers_from_line)
389 (tui_data_window::first_data_item_displayed)
390 (tui_data_window::delete_data_content_windows)
391 (tui_data_window::erase_data_content)
392 (tui_data_window::do_scroll_vertical)
393 (tui_data_window::refresh_window)
394 (tui_data_window::check_register_values): Update.
395
9923f347
TT
3962019-09-20 Tom Tromey <tom@tromey.com>
397
398 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
399 (struct tui_locator_window) <full_name, proc_name>: Now
400 std::string.
401 * tui/tui-stack.c (tui_locator_window::make_status_line)
402 (tui_locator_window::set_locator_fullname)
403 (tui_locator_window::set_locator_info): Update.
404 * tui/tui-source.c (tui_source_window::set_contents)
405 (tui_source_window::showing_source_p): Update.
406
b76251ab
TT
4072019-09-20 Tom Tromey <tom@tromey.com>
408
409 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
410 Don't call tui_locator_win_info_ptr.
411
0891be08
TT
4122019-09-20 Tom Tromey <tom@tromey.com>
413
414 * tui/tui-win.c (tui_resize_all): Don't call refresh.
415
1b935acf
TT
4162019-09-20 Tom Tromey <tom@tromey.com>
417
418 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
419 height for locator.
420 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
421 * tui/tui-layout.c (show_source_disasm_command, show_data)
422 (show_source_or_disasm_and_command): Use 1 as height for locator.
423
9abd8a65
TT
4242019-09-20 Tom Tromey <tom@tromey.com>
425
426 * tui/tui.c (tui_enable): Update.
427 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
428 Update.
429 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
430 Update.
431 * tui/tui-data.c (win_resized): Now bool.
432 (tui_win_resized): Return bool.
433 (tui_set_win_resized_to): Accept a bool.
434
b5457826
TT
4352019-09-20 Tom Tromey <tom@tromey.com>
436
437 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
438 Change type of "refresh_values_only".
439 * tui/tui-regs.c (tui_data_window::show_register_group): Change
440 type of "refresh_values_only".
441
6b915f7d
TT
4422019-09-20 Tom Tromey <tom@tromey.com>
443
444 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
445 std::string.
446 (tui_disassemble): Add "pos" parameter.
447 (tui_disasm_window::set_contents): Simplify.
448
2ad52f6f
TT
4492019-09-20 Tom Tromey <tom@tromey.com>
450
451 * tui/tui-winsource.h (struct tui_source_window_base)
452 <show_source_content>: Now private.
453 * tui/tui-winsource.c
454 (tui_source_window_base::show_source_content): Don't handle empty
455 content case.
456
b3b1bde6
TT
4572019-09-20 Tom Tromey <tom@tromey.com>
458
459 * tui/tui-layout.c (show_source_disasm_command)
460 (show_source_or_disasm_and_command): Don't call
461 show_source_content.
462
71a25ed2
TT
4632019-09-20 Tom Tromey <tom@tromey.com>
464
465 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
466 Declare.
467 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
468 from tui_make_status_line.
469 (tui_locator_window::rerender): Update.
470
f8532154
TT
4712019-09-20 Tom Tromey <tom@tromey.com>
472
473 * tui/tui-stack.c (tui_make_status_line): Return std::string.
474 (tui_locator_window::rerender): Update.
475
2d81b349
TT
4762019-09-20 Tom Tromey <tom@tromey.com>
477
478 * tui/tui-winsource.h (struct tui_source_window_base)
479 <~tui_source_window_base>: Don't declare.
480 <fullname>: Remove.
481 * tui/tui-winsource.c (~tui_source_window_base): Remove.
482 * tui/tui-source.h (struct tui_source_window) <fullname>: New
483 member.
484 * tui/tui-source.c (tui_source_window::set_contents): Update.
485 (tui_source_window::location_matches_p)
486 (tui_source_window::maybe_update): Update.
487
f14bec58
TT
4882019-09-20 Tom Tromey <tom@tromey.com>
489
490 * tui/tui-winsource.h (~tui_source_element): Remove.
491 (tui_source_element): Update.
492 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
493 * tui/tui-winsource.c (tui_show_source_line): Update.
494 * tui/tui-source.c (tui_source_window::set_contents): Update.
495 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
496
78d5933a
TT
4972019-09-20 Tom Tromey <tom@tromey.com>
498
499 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
500 declare.
501 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
502 tui_clear_source_windows_detail.
503 * tui/tui-winsource.h (struct tui_source_window_base)
504 <clear_detail>: Don't declare.
505 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
506 Remove.
507 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
508
d4207696
TT
5092019-09-20 Tom Tromey <tromey@adacore.com>
510
511 PR ada/24919:
512 * block.c (contained_in): Fix final return value.
513
00f93c44
AM
5142019-09-20 Alan Modra <amodra@gmail.com>
515
516 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
517 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
518 (read_indirect_string_from_dwz): Use bfd accessor.
519 * dwarf2read.h (struct dwz_file <filename>): Likewise.
520 * machoread.c (macho_symfile_read_all_oso): Likewise.
521 * solib.c (solib_bfd_open): Likewise.
522
e4153ae6
CB
5232019-09-19 Christian Biesinger <cbiesinger@google.com>
524
525 * eval.c: Move declaration of overload_resolution to...
526 * value.h: ...here.
527
c7ae7675
CB
5282019-09-19 Christian Biesinger <cbiesinger@google.com>
529
530 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
531 * arm-linux-tdep.c: Likewise.
532 * arm-nbsd-nat.c: Likewise.
533 * arm-tdep.h: Declare arm_apcs_32.
534 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
535
e86f08d2
CB
5362019-09-19 Christian Biesinger <cbiesinger@google.com>
537
538 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
539 * dwarf2read.h: Declare dwarf_always_disassemble.
540
f64e2f40
TV
5412019-09-19 Tom de Vries <tdevries@suse.de>
542
543 PR gdb/25009
544 * source-cache.c (source_cache::ensure): Catch exception thrown during
545 construction of the highlighter.
546
fd361982
AM
5472019-09-18 Alan Modra <amodra@gmail.com>
548
549 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
550 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
551 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
552 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
553 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
554 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
555 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
556 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
557 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
558 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
559 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
560 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
561 * solib-spu.c, * solib-svr4.c, * solib-target.c,
562 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
563 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
564 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
565 * mi/mi-interp.c: Update throughout for bfd section macro and
566 function changes.
567 * gcore (gcore_create_callback): Use bfd_set_section_lma.
568 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
569
11061048
TT
5702019-09-18 Tom Tromey <tom@tromey.com>
571
572 * NEWS: Add entry.
573 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
574 call rl_initialize.
575 (tui_enable): Do not call rl_initialize.
576
7a27b85f
CG
5772019-09-18 Christian Groessler <chris@groessler.org>
578
579 * alpha-linux-nat.c: Include gdbarch.h.
580
f64eea3a
SM
5812019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
582
583 * ui-file.c: Include cli/cli-style.h.
584 (term_cli_styling): Remove cli_styling declaration.
585
e6f7f6d1
AM
5862019-09-18 Alan Modra <amodra@gmail.com>
587
588 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
589 to bfd_asymbol_section.
590
1d38e9d1
AM
5912019-09-18 Alan Modra <amodra@gmail.com>
592
593 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
594 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
595 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
596
90d92a63
AM
5972019-09-18 Alan Modra <amodra@gmail.com>
598
599 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
600 * spu-linux-nat.c (spu_bfd_open): Likewise.
601
a3d181d2
CB
6022019-09-18 Christian Biesinger <cbiesinger@google.com>
603
604 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
605 to bool to match definition in dwarf2read.c.
606
491144b5
CB
6072019-09-17 Christian Biesinger <cbiesinger@google.com>
608
609 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
610 (print_signatures): Likewise.
611 (trust_pad_over_xvs): Likewise.
612 * arch/aarch64-insn.c (aarch64_debug): Likewise.
613 * arch/aarch64-insn.h (aarch64_debug): Likewise.
614 * arm-linux-nat.c (arm_apcs_32): Likewise.
615 * arm-linux-tdep.c (arm_apcs_32): Likewise.
616 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
617 * arm-tdep.c (arm_debug): Likewise.
618 (arm_apcs_32): Likewise.
619 * auto-load.c (debug_auto_load): Likewise.
620 (auto_load_gdb_scripts): Likewise.
621 (global_auto_load): Likewise.
622 (auto_load_local_gdbinit): Likewise.
623 (auto_load_local_gdbinit_loaded): Likewise.
624 * auto-load.h (global_auto_load): Likewise.
625 (auto_load_local_gdbinit): Likewise.
626 (auto_load_local_gdbinit_loaded): Likewise.
627 * breakpoint.c (disconnected_dprintf): Likewise.
628 (breakpoint_proceeded): Likewise.
629 (automatic_hardware_breakpoints): Likewise.
630 (always_inserted_mode): Likewise.
631 (target_exact_watchpoints): Likewise.
632 (_initialize_breakpoint): Update.
633 * breakpoint.h (target_exact_watchpoints): Change to bool.
634 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
635 * cli/cli-cmds.c (trace_commands): Likewise.
636 * cli/cli-cmds.h (trace_commands): Likewise.
637 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
638 to bool*.
639 * cli/cli-logging.c (logging_overwrite): Change to bool.
640 (logging_redirect): Likewise.
641 (debug_redirect): Likewise.
642 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
643 (struct boolean_option_def) <get_var_address_cb_>: Change return type
644 to bool.
645 <boolean_option_def>: Update.
646 (struct flag_option_def): Change default type of Context to bool
647 from int.
648 <flag_option_def>: Change return type of var_address_cb_ to bool*.
649 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
650 (get_setshow_command_value_string): Likewise.
651 * cli/cli-style.c (cli_styling): Change to bool.
652 (source_styling): Likewise.
653 * cli/cli-style.h (source_styling): Likewise.
654 (cli_styling): Likewise.
655 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
656 to bool.
657 * command.h (var_types): Update comment.
658 (add_setshow_boolean_cmd): Change int* var argument to bool*.
659 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
660 bool.
661 (debug_compile_cplus_scopes): Likewise.
662 * compile/compile-internal.h (compile_debug): Likewise.
663 * compile/compile.c (compile_debug): Likewise.
664 (struct compile_options) <raw>: Likewise.
665 * cp-support.c (catch_demangler_crashes): Likewise.
666 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
667 (usr_cmd_cris_dwarf2_cfi): Likewise.
668 * csky-tdep.c (csky_debug): Likewise.
669 * darwin-nat.c (enable_mach_exceptions): Likewise.
670 * dcache.c (dcache_enabled_p): Likewise.
671 * defs.h (info_verbose): Likewise.
672 * demangle.c (demangle): Likewise.
673 (asm_demangle): Likewise.
674 * dwarf-index-cache.c (debug_index_cache): Likewise.
675 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
676 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
677 * dwarf2read.c (check_physname): Likewise.
678 (use_deprecated_index_sections): Likewise.
679 (dwarf_always_disassemble): Likewise.
680 * eval.c (overload_resolution): Likewise.
681 * event-top.c (set_editing_cmd_var): Likewise.
682 (exec_done_display_p): Likewise.
683 * event-top.h (set_editing_cmd_var): Likewise.
684 (exec_done_display_p): Likewise.
685 * exec.c (write_files): Likewise.
686 * fbsd-nat.c (debug_fbsd_lwp): Likewise
687 (debug_fbsd_nat): Likewise.
688 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
689 Likewise.
690 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
691 <backtrace_past_entry> Likewise.
692 * gdb-demangle.h (demangle): Likewise.
693 (asm_demangle): Likewise.
694 * gdb_bfd.c (bfd_sharing): Likewise.
695 * gdbcore.h (write_files): Likewise.
696 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
697 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
698 * gdbthread.h (print_thread_events): Likewise.
699 * gdbtypes.c (opaque_type_resolution): Likewise.
700 (strict_type_checking): Likewise.
701 * gnu-nat.c (gnu_debug_flag): Likewise.
702 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
703 * guile/scm-param.c (pascm_variable): Add boolval.
704 (add_setshow_generic): Update.
705 (pascm_param_value): Update.
706 (pascm_set_param_value_x): Update.
707 * hppa-tdep.c (hppa_debug): Change to bool..
708 * infcall.c (may_call_functions_p): Likewise.
709 (coerce_float_to_double_p): Likewise.
710 (unwind_on_signal_p): Likewise.
711 (unwind_on_terminating_exception_p): Likewise.
712 * infcmd.c (startup_with_shell): Likewise.
713 * inferior.c (print_inferior_events): Likewise.
714 * inferior.h (startup_with_shell): Likewise.
715 (print_inferior_events): Likewise.
716 * infrun.c (step_stop_if_no_debug): Likewise.
717 (detach_fork): Likewise.
718 (debug_displaced): Likewise.
719 (disable_randomization): Likewise.
720 (non_stop): Likewise.
721 (non_stop_1): Likewise.
722 (observer_mode): Likewise.
723 (observer_mode_1): Likewise.
724 (set_observer_mode): Update.
725 (sched_multi): Change to bool.
726 * infrun.h (debug_displaced): Likewise.
727 (sched_multi): Likewise.
728 (step_stop_if_no_debug): Likewise.
729 (non_stop): Likewise.
730 (disable_randomization): Likewise.
731 * linux-tdep.c (use_coredump_filter): Likewise.
732 (dump_excluded_mappings): Likewise.
733 * linux-thread-db.c (auto_load_thread_db): Likewise.
734 (check_thread_db_on_load): Likewise.
735 * main.c (captured_main_1): Update.
736 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
737 xx2_opt, boolean_opt>: Change to bool.
738 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
739 * maint.c (maintenance_profile_p): Likewise.
740 (per_command_time): Likewise.
741 (per_command_space): Likewise.
742 (per_command_symtab): Likewise.
743 * memattr.c (inaccessible_by_default): Likewise.
744 * mi/mi-main.c (mi_async): Likewise.
745 (mi_async_1): Likewise.
746 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
747 * nat/fork-inferior.h (startup_with_shell): Likewise.
748 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
749 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
750 * nios2-tdep.c (nios2_debug): Likewise.
751 * or1k-tdep.c (or1k_debug): Likewise.
752 * parse.c (parser_debug): Likewise.
753 * parser-defs.h (parser_debug): Likewise.
754 * printcmd.c (print_symbol_filename): Likewise.
755 * proc-api.c (procfs_trace): Likewise.
756 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
757 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
758 (set_parameter_value): Update.
759 (add_setshow_generic): Update.
760 * python/py-value.c (copy_py_bool_obj): Change argument from int*
761 to bool*.
762 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
763 int*.
764 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
765 * record-btrace.c (record_btrace_target::store_registers): Update.
766 * record-full.c (record_full_memory_query): Change to bool.
767 (record_full_stop_at_limit): Likewise.
768 * record-full.h (record_full_memory_query): Likewise.
769 * remote-notif.c (notif_debug): Likewise.
770 * remote-notif.h (notif_debug): Likewise.
771 * remote.c (use_range_stepping): Likewise.
772 (interrupt_on_connect): Likewise.
773 (remote_break): Likewise.
774 * ser-tcp.c (tcp_auto_retry): Likewise.
775 * ser-unix.c (serial_hwflow): Likewise.
776 * skip.c (debug_skip): Likewise.
777 * solib-aix.c (solib_aix_debug): Likewise.
778 * spu-tdep.c (spu_stop_on_load_p): Likewise.
779 (spu_auto_flush_cache_p): Likewise.
780 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
781 Likewise.
782 (struct info_print_options) <quiet>: Likewise.
783 * symfile-debug.c (debug_symfile): Likewise.
784 * symfile.c (auto_solib_add): Likewise.
785 (separate_debug_file_debug): Likewise.
786 * symfile.h (auto_solib_add): Likewise.
787 (separate_debug_file_debug): Likewise.
788 * symtab.c (basenames_may_differ): Likewise.
789 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
790 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
791 (struct info_types_options) <quiet>: Likewise.
792 * symtab.h (demangle): Likewise.
793 (basenames_may_differ): Likewise.
794 * target-dcache.c (stack_cache_enabled_1): Likewise.
795 (code_cache_enabled_1): Likewise.
796 * target.c (trust_readonly): Likewise.
797 (may_write_registers): Likewise.
798 (may_write_memory): Likewise.
799 (may_insert_breakpoints): Likewise.
800 (may_insert_tracepoints): Likewise.
801 (may_insert_fast_tracepoints): Likewise.
802 (may_stop): Likewise.
803 (auto_connect_native_target): Likewise.
804 (target_stop_and_wait): Update.
805 (target_async_permitted): Change to bool.
806 (target_async_permitted_1): Likewise.
807 (may_write_registers_1): Likewise.
808 (may_write_memory_1): Likewise.
809 (may_insert_breakpoints_1): Likewise.
810 (may_insert_tracepoints_1): Likewise.
811 (may_insert_fast_tracepoints_1): Likewise.
812 (may_stop_1): Likewise.
813 * target.h (target_async_permitted): Likewise.
814 (may_write_registers): Likewise.
815 (may_write_memory): Likewise.
816 (may_insert_breakpoints): Likewise.
817 (may_insert_tracepoints): Likewise.
818 (may_insert_fast_tracepoints): Likewise.
819 (may_stop): Likewise.
820 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
821 (make_thread_apply_all_options_def_group): Change argument from int*
822 to bool*.
823 (thread_apply_all_command): Update.
824 (print_thread_events): Change to bool.
825 * top.c (confirm): Likewise.
826 (command_editing_p): Likewise.
827 (history_expansion_p): Likewise.
828 (write_history_p): Likewise.
829 (info_verbose): Likewise.
830 * top.h (confirm): Likewise.
831 (history_expansion_p): Likewise.
832 * tracepoint.c (disconnected_tracing): Likewise.
833 (circular_trace_buffer): Likewise.
834 * typeprint.c (print_methods): Likewise.
835 (print_typedefs): Likewise.
836 * utils.c (debug_timestamp): Likewise.
837 (sevenbit_strings): Likewise.
838 (pagination_enabled): Likewise.
839 * utils.h (sevenbit_strings): Likewise.
840 (pagination_enabled): Likewise.
841 * valops.c (overload_resolution): Likewise.
842 * valprint.h (struct value_print_options) <prettyformat_arrays,
843 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
844 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
845 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
846 Likewise.
847 * windows-nat.c (new_console): Likewise.
848 (cygwin_exceptions): Likewise.
849 (new_group): Likewise.
850 (debug_exec): Likewise.
851 (debug_events): Likewise.
852 (debug_memory): Likewise.
853 (debug_exceptions): Likewise.
854 (useshell): Likewise.
855 * windows-tdep.c (maint_display_all_tib): Likewise.
856 * xml-support.c (debug_xml): Likewise.
857
f1b620e9
MG
8582019-09-17 Mike Gulick <mgulick@mathworks.com>
859
860 * source.c (prepare_path_for_appending): New function.
861 (openp): Make use of new function.
862 (find_and_open_source): Search for the compilation directory and
863 source file as a relative path beneath the directory search path.
864
67f3ed6a
AB
8652019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
866
867 * source-cache.c (source_cache::get_line_charpos): Catch
868 exceptions and return false, this matches the behaviour documented
869 in the header file.
870
74332189
JB
8712019-09-17 Joel Brobecker <brobecker@adacore.com>
872
873 * ada-tasks.c (info_task): Remove quoting of the task's name.
874
f2f24aa9
CB
8752019-09-16 Christian Biesinger <cbiesinger@google.com>
876
877 * symfile.c (auto_solib_add): Replace comment with a reference
878 to the header file.
879
6a062a93
CB
8802019-09-14 Christian Biesinger <cbiesinger@google.com>
881
882 * NEWS: Mention that gdb can now be compiled with Python 3
883 on Windows.
884
ec6c8338
AB
8852019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
886
887 * maint.c (maint_print_section_data::maint_print_section_data):
888 Force use of 'float log10 (float)' by casting the argument to
889 float.
890
aa17805f
AB
8912019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
892
893 * maint.c: Add 'cmath' include.
894 (struct maint_print_section_data): New structure.
895 (print_section_index): New function.
896 (print_bfd_section_info): Add header comment, small whitespace
897 cleanup, and update to call new print_section_index function.
898 (print_objfile_section_info): Likewise.
899 (maint_obj_section_from_bfd_section): New function.
900 (print_bfd_section_info_maybe_relocated): New function.
901 (maintenance_info_sections): Add header comment, always use
902 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
903
3dd9bb46
AB
9042019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
905
906 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
907 inner scope, add check that the objfile has psymtabs before
908 checking psymtabs_addrmap.
909 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
910
4993045d
PW
9112019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
912
913 * NEWS: Announce that Ada task names are now shown at more places,
914 and between quotes (except in info task output).
915 * gdb/ada-tasks.c (task_to_str): New function.
916 (display_current_task_id): Call task_to_str.
917 (task_command_1): Likewise.
918 (print_ada_task_info): In non-mi mode, Properly align headers and data
919 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
920
7a289707
RO
9212019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
922
923 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
924 prstatus.pr_lwp.pr_info instead of making it up.
925
f2aec7f6
CB
9262019-09-11 Christian Biesinger <cbiesinger@google.com>
927
928 * auto-load.c (auto_load_expand_dir_vars): Update.
929 * defs.h (gdb_datadir): Change to std::string.
930 (python_libdir): Likewise.
931 (relocate_gdb_directory): Change return type to std::string.
932 * guile/guile.c (gdbscm_data_directory): Update.
933 (initialize_scheme_side): Update.
934 * jit.c (jit_reader_dir): Change to std::string.
935 (jit_reader_load_command): Update.
936 * main.c (gdb_datadir): Change to std::string.
937 (python_libdir): Likewise.
938 (set_gdb_data_directory): Update.
939 (relocate_path): Change to return std::string.
940 (relocate_gdb_directory): Change to return std::string.
941 (relocate_gdbinit_path_maybe_in_datadir): Update.
942 (captured_main_1): Update.
943 * python/python.c (do_start_initialization): Update.
944 * top.c (show_gdb_datadir): Update.
945 * xml-syscall.c (xml_init_syscalls_info): Update.
946 (init_syscalls_info): Update.
947
9224a013
CB
9482019-09-11 Christian Biesinger <cbiesinger@google.com>
949
950 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
951 out of get_init_files.
952 (get_init_files): Update.
953
f48cd836
CB
9542019-09-11 Christian Biesinger <cbiesinger@google.com>
955
956 * main.c (get_init_files): Change to use std::string.
957 (captured_main_1): Update.
958 (print_gdb_help): Update.
959
9cab7ecd
AT
9602019-09-11 Ali Tamur <tamur@google.com>
961
962 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
963 implementation.
964
67547d89
CB
9652019-09-11 Christian Biesinger <cbiesinger@google.com>
966
967 * dbxread.c (read_dbx_symtab): Update.
968 * dwarf2read.c (load_partial_dies): Update.
969 * mdebugread.c (parse_partial_symbols): Update.
970 (handle_psymbol_enumerators): Update.
971 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
972 * psymtab.c (add_psymbol_to_bcache): Likewise.
973 (add_psymbol_to_list): Likewise.
974 * symtab.c (symbol_set_names): Likewise.
975 * symtab.h (symbol_set_names): Likewise.
976 * xcoffread.c (scan_xcoff_symtab): Update.
977
64b2d4a0
TT
9782019-09-11 Tom Tromey <tom@tromey.com>
979
980 * symfile-mem.c (symbol_file_add_from_memory): Use
981 bfd_set_filename.
982 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
983 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
984
3b00ef10
TT
9852019-09-10 Tom Tromey <tromey@adacore.com>
986
987 * dwarf-index-write.c (write_psymbols): Extend error message.
988 (debug_names::insert): Add Ada code.
989 (debug_names::write_psymbols): Remove Ada check.
990 (debug_names) <m_string_obstack>: New member.
991 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
992 (gdb_index_symbol_name_matcher::matches): Remove.
993 (mapped_index_base::find_name_components_bounds): Add "lang"
994 parameter.
995 (mapped_index_base::build_name_components): Also split names
996 according to Ada syntax.
997 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
998 type of "match_callback".
999 (check_match, check_find_bounds_finds)
1000 (dw2_expand_symtabs_matching): Update.
1001 (dw2_debug_names_iterator): Add new constructor.
1002 (dw2_debug_names_map_matching_symbols): New function.
1003 (dw2_debug_names_expand_symtabs_matching): Update.
1004 (dwarf2_debug_names_functions): Use
1005 dw2_debug_names_map_matching_symbols.
1006
aa391654
TT
10072019-09-10 Tom Tromey <tromey@adacore.com>
1008
1009 * dwarf2read.c (dw2_get_file_names_reader): Add the
1010 CU's file name to the results.
1011
b054970d
TT
10122019-09-10 Tom Tromey <tromey@adacore.com>
1013
1014 * ada-lang.c (add_nonlocal_symbols): Combine calls to
1015 map_matching_symbols. Update.
1016 * dwarf2read.c (dw2_map_matching_symbols): Update.
1017 * psymtab.c (match_partial_symbol): Change type; update.
1018 (psym_map_matching_symbols): Likewise.
1019 * symfile-debug.c (debug_qf_map_matching_symbols): Change
1020 type; update.
1021 * symfile.h (struct quick_symbol_functions)
1022 <map_matching_symbols>: Change "name" to be a lookup_name_info.
1023 Remove "match".
1024
6a3dbf1b
TT
10252019-09-10 Tom Tromey <tromey@adacore.com>
1026
1027 * psymtab.c (map_block): Remove.
1028 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1029 * symtab.c (iterate_over_symbols_terminated): New function.
1030 * symtab.c (iterate_over_symbols_terminated): Declare.
1031
6969f124
TT
10322019-09-10 Tom Tromey <tromey@adacore.com>
1033
1034 * ada-lang.c (ada_iterate_over_symbols): Return bool.
1035 * language.h (struct language_defn) <la_iterate_over_symbols>:
1036 Return bool.
1037 * symtab.c (iterate_over_symbols): Return bool.
1038 * symtab.h (iterate_over_symbols): Return bool.
1039
199b4314
TT
10402019-09-10 Tom Tromey <tromey@adacore.com>
1041
1042 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1043 (add_nonlocal_symbols): Update.
1044 * dwarf2read.c (dw2_map_matching_symbols): Change type.
1045 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1046 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1047 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1048 Change type of "callback". Remove "data".
1049
a084a2a6
AT
1050
10512019-09-09 Ali Tamur <tamur@google.com>
1052
1053 * dwarf2read.c (comp_unit_head): Update comment.
1054 (dwarf2_dwo_name): New function declaration.
1055 (dwarf_unit_type_name): New function declaration.
1056 (read_comp_unit_head): Add support for new compilation units,
1057 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1058 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1059 (currently named as "signature") in their header. Also clarify error
1060 messages.
1061 (lookup_dwo_id): New function. Returns the dwo id of the given
1062 compile unit.
1063 (lookup_dwo_unit): Use the new lookup_dwo_id function.
1064 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1065 functions.
1066 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1067 (dwarf2_dwo_name): Get the dwo name if present.
1068 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1069 purposes.
1070
25a2915e
TT
10712019-09-09 Tom Tromey <tom@tromey.com>
1072
1073 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1074
e4df0874
PW
10752019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1076
1077 * python/python.c (do_start_initialization): Make progname_copy static,
1078 to avoid a leak report.
1079
8634b462
TT
10802019-09-08 Tom Tromey <tom@tromey.com>
1081
1082 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1083
c7f839cb
SM
10842019-09-07 Simon Marchi <simon.marchi@efficios.com>
1085
1086 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1087 Change type to gdb::optional<block_enum>.
1088 (dw2_symtab_iter_init): Change block_index parameter type
1089 to gdb::optional<block_enum>.
1090 (dw2_lookup_symbol): Change block_index parameter
1091 type to block_enum.c
1092 (dw2_debug_names_lookup_symbol): Likewise.
1093 * psymtab.c (psym_lookup_symbol): Likewise.
1094 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1095 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1096 Likewise.
1097
ead0e69a
CB
10982019-09-06 Christian Biesinger <cbiesinger@google.com>
1099
1100 * defs.h (relocate_gdb_directory): Change int to bool in
1101 signature and rename flag to relocatable.
1102 * main.c (relocate_path): Likewise.
1103 (relocate_gdb_directory): Likewise.
1104
b16c44de
AM
11052019-09-06 Alan Modra <amodra@gmail.com>
1106
1107 * coffread.c (coff_symfile_read): Constify filename variable.
1108 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1109 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1110 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1111 * solib.c (reload_shared_libraries_1): Likewise.
1112 * symfile.c (reread_symbols): Likewise.
1113 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1114 * solib-darwin.c (darwin_bfd_open): Likewise.
1115 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1116
06ff036e
AB
11172019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
1118
1119 * psymtab.c (print_partial_symbols): Handle missing domain_enum
1120 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1121
4e962e74
TT
11222019-09-03 Tom Tromey <tromey@adacore.com>
1123
1124 * ada-valprint.c (ada_val_print_num): Don't recurse for range
1125 types.
1126 (has_negatives): Unbias a range type bound.
1127 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1128 * gdbtypes.c (operator==): Handle new field.
1129 (create_range_type): Add "bias" parameter.
1130 (create_static_range_type, resolve_dynamic_range): Update.
1131 * gdbtypes.h (struct range_bounds) <bias>: New member.
1132 (create_range_type): Add bias parameter.
1133 * printcmd.c (print_scalar_formatted): Unbias range types.
1134 * value.c (unpack_long): Unbias range types.
1135 (pack_long): Bias range types.
1136
d90b8f26
AH
11372019-09-02 Alan Hayward <alan.hayward@arm.com>
1138
1139 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1140 probe arguments.
1141
fe01123e
AH
11422019-09-02 Alan Hayward <alan.hayward@arm.com>
1143
1144 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1145 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1146 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1147 (compile_probe_arg): Likewise.
1148 * probe.h (get_argument_count): Likewise.
1149 * solib-svr4.c (solib_event_probe_action): Likewise.
1150 * stap-probe.c (stap_probe::get_argument_count): Likewise.
1151
e661ef01
AH
11522019-09-02 Alan Hayward <alan.hayward@arm.com>
1153
1154 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1155 code to here...
1156 (svr4_create_solib_event_breakpoints): ...from here.
1157
47a536d9
SDJ
11582019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
1159
1160 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1161 suffix from warning message.
1162
d6a00eba
TT
11632019-08-30 Tom Tromey <tom@tromey.com>
1164
1165 * tui/tui-winsource.h (struct tui_source_window_base)
1166 <refresh_all>: Don't declare.
1167 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1168 Remove.
1169 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1170 tui_show_locator_content.
1171 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1172 declare.
1173 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1174 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1175 declare.
1176
55b2657b
TT
11772019-08-30 Tom Tromey <tom@tromey.com>
1178
1179 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1180
12a8555a
TT
11812019-08-30 Tom Tromey <tom@tromey.com>
1182
1183 * tui/tui-stack.c (_initialize_tui_stack): Move later.
1184 Remove unnecessary forward declarations.
1185
900ac242
TT
11862019-08-30 Tom Tromey <tom@tromey.com>
1187
1188 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1189 rerender.
1190 (tui_update_locator_fullname, tui_show_frame_info): Don't call
1191 tui_show_locator_content.
1192
99ab33fb
TT
11932019-08-30 Tom Tromey <tom@tromey.com>
1194
1195 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
1196 (tui_locator_window::rerender): Rewrite using body of previous
1197 tui_show_locator_content.
1198
e594a5d1
TT
11992019-08-30 Tom Tromey <tom@tromey.com>
1200
1201 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1202 set_locator_fullname>: New methods.
1203 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1204 Rename from tui_set_locator_fullname.
1205 (tui_locator_window::set_locator_info): Rename from
1206 tui_set_locator_info. Return bool.
1207 (tui_update_locator_fullname, tui_show_frame_info): Update.
1208
715bb467
TT
12092019-08-30 Tom Tromey <tom@tromey.com>
1210
1211 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1212
772f3f03
TT
12132019-08-30 Tom Tromey <tom@tromey.com>
1214
1215 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1216 call touchwin.
1217
108e13ab
TT
12182019-08-30 Tom Tromey <tom@tromey.com>
1219
1220 * tui/tui-wingeneral.c (box_win): Assume win_info and
1221 win_info->handle cannot be NULL.
1222
cdaa6eb4
TT
12232019-08-30 Tom Tromey <tom@tromey.com>
1224
1225 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1226 refresh_window>: Declare.
1227 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1228 resize.
1229 (tui_data_item_window::rerender): Rename from
1230 tui_display_register.
1231 (tui_data_item_window::refresh_window): New method.
1232 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1233 no-op.
1234
89df7f90
TT
12352019-08-30 Tom Tromey <tom@tromey.com>
1236
1237 * tui/tui-regs.h (struct tui_data_window) <regs_content,
1238 regs_column_count, current_group>: Move later. Now private.
1239 <get_current_group>: New method.
1240 * tui/tui-regs.c (tui_reg_command): Update.
1241 * tui/tui-layout.c (tui_set_layout): Update.
1242
1bf2866a
TT
12432019-08-30 Tom Tromey <tom@tromey.com>
1244
1245 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1246 (tui_data_window::rerender): Don't call
1247 check_and_display_highlight_if_needed.
1248 (tui_data_window::refresh_all): Remove call to
1249 erase_data_content.
1250
0670413d
TT
12512019-08-30 Tom Tromey <tom@tromey.com>
1252
1253 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1254 (tui_data_window::display_registers_from)
1255 (tui_data_window::display_reg_element_at_line)
1256 (tui_data_window::display_registers_from_line): Remove checks of
1257 "empty".
1258
18bb55c7
TT
12592019-08-30 Tom Tromey <tom@tromey.com>
1260
1261 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1262 Don't declare.
1263 * tui/tui-regs.c (tui_data_window::show_registers): Call
1264 rerender.
1265 (tui_data_window::rerender): Rename from display_all_data.
1266 (tui_data_window::rerender): Remove old implementation.
1267
1f6d2f10
TT
12682019-08-30 Tom Tromey <tom@tromey.com>
1269
1270 * tui/tui-regs.c (tui_data_window::display_all_data): Change
1271 text.
1272 * tui/tui-data.h (NO_DATA_STRING): Remove define.
1273
16d01f9c
BW
12742019-08-29 Bernhard Wodok <barto@gmx.net>
1275 Sergio Durigan Junior <sergiodj@redhat.com>
1276
1277 PR win32/24284
1278 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1279
d8f27c60
AB
12802019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1281
1282 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1283 when searching for types.
1284
1f20c35e
AB
12852019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1286
1287 * f-lang.c (f_language_defn): Use f_print_typedef.
1288 * f-lang.h (f_print_typedef): Declare.
1289 * f-typeprint.c (f_print_typedef): Define.
1290
550105b7
CB
12912019-08-27 Christian Biesinger <cbiesinger@google.com>
1292
1293 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1294
4acfdd20
AB
12952019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
1296
1297 * cli/cli-utils.c (info_print_options_defs): Delete.
1298 (make_info_print_options_def_group): Delete.
1299 (extract_info_print_options): Delete.
1300 (info_print_command_completer): Delete.
1301 (info_print_args_help): Add extra parameter, and optionally
1302 include text about -n flag.
1303 * cli/cli-utils.h (struct info_print_options): Delete.
1304 (extract_info_print_options): Delete declaration.
1305 (info_print_command_completer): Delete declaration.
1306 (info_print_args_help): Add extra parameter, extend header
1307 comment.
1308 * python/python.c (gdbpy_rbreak): Pass additional parameter to
1309 search_symbols.
1310 * stack.c (struct info_print_options): New type.
1311 (info_print_options_defs): New file scoped variable.
1312 (make_info_print_options_def_group): New static function.
1313 (info_print_command_completer): New static function.
1314 (info_locals_command): Update to use new local functions.
1315 (info_args_command): Likewise.
1316 (_initialize_stack): Add extra parameter to calls to
1317 info_print_args_help.
1318 * symtab.c (search_symbols): Add extra parameter, use this to
1319 possibly excluse non-debug symbols.
1320 (symtab_symbol_info): Add extra parameter, which is passed on to
1321 search_symbols.
1322 (struct info_print_options): New type.
1323 (info_print_options_defs): New file scoped variable.
1324 (make_info_print_options_def_group): New static function.
1325 (info_print_command_completer): New static function.
1326 (info_variables_command): Update to use local functions, and pass
1327 extra parameter through to symtab_symbol_info.
1328 (info_functions_command): Likewise.
1329 (info_types_command): Pass additional argument through to
1330 symtab_symbol_info.
1331 (rbreak_command): Pass extra argument to search_symbols.
1332 (_initialize_symtab): Add extra arguments for calls to
1333 info_print_args_help, and update help text for 'info variables',
1334 'whereis', and 'info functions' commands.
1335 * symtab.h (search_symbols): Add extra argument to declaration.
1336 * NEWS: Mention new flags.
1337
9aa55206
CB
13382019-08-26 Christian Biesinger <cbiesinger@google.com>
1339
1340 * symtab.c (lookup_static_symbol): Call the new function (and move
1341 it down to be next to lookup_global_symbol).
1342 (struct global_sym_lookup_data): Add block_enum member and rename to...
1343 (struct global_or_static_sym_lookup_data): ...this.
1344 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1345 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1346 (lookup_symbol_global_or_static_iterator_cb): ...this.
1347 (lookup_global_or_static_symbol): New function.
1348 (lookup_global_symbol): Call new function.
1349
5c31b358
TV
13502019-08-26 Tom de Vries <tdevries@suse.de>
1351
1352 PR c++/24852
1353 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1354 when pc_probe.prob == NULL.
1355
23c13d42
SM
13562019-08-25 Simon Marchi <simon.marchi@efficios.com>
1357
1358 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1359 variable symbol_linkage to symbol_linkage_.
1360
beadd3e8
SM
13612019-08-25 Simon Marchi <simon.marchi@efficios.com>
1362
1363 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1364 represent whether the symbol is static, dynamic, or we don't
1365 know.
1366
e3ec872f
YS
13672019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1368
1369 * gdb/rx-tdep.c (rx_register_names): New.
1370 (rx_register_name): Delete.
1371 (rx_psw_type): Delete.
1372 (rx_fpsw_type): Delete.
1373 (rx_register_type): Delete.
1374 (rx_gdbarch_init): Convert target-descriptions.
1375 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1376 * gdb/features/Makefile: Add rx.xml.
1377 * gdb/features/rx.xml: New.
1378 * gdb/features/rx.c: Generated.
1379 * gdb/NEWS: Mention target description support.
1380
d0509ba4
CB
13812019-08-22 Christian Biesinger <cbiesinger@google.com>
1382
1383 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1384 *slot_ptr.
1385
2d41fa11
SDJ
13862019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1387
1388 * configure.ac: Don't check for 'dlfcn.h' (moved to
1389 gdbsupport/common.m4).
1390 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1391 'gdbsupport/'.
1392 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1393 * compile/compile-c-support.c: Include
1394 'gdbsupport/gdb-dlfcn.h'.
1395 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1396 * gdb-dlfcn.c: Move to...
1397 * gdbsupport/gdb-dlfcn.c: ... here.
1398 * gdb-dlfcn.h: Move to...
1399 * gdbsupport/gdb-dlfcn.h: ... here.
1400
de8af808
SL
14012019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1402
1403 * nios2-tdep.c (struct reg_value): Improve comments. Make
1404 the offset field signed.
1405
27204489
CB
14062019-08-22 Christian Biesinger <cbiesinger@google.com>
1407
1408 * python/lib/gdb/__init__.py (_execute_file): New function.
1409 * python/python.c (python_run_simple_file): Call gdb._execute_file
1410 on Windows.
1411
43771869
AB
14122019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1413
1414 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1415 all uses as this was never set to anything but a zero value.
1416
26c957f1
PA
14172019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1418
1419 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1420
c07aae6e
CB
14212019-08-21 Christian Biesinger <cbiesinger@google.com>
1422
1423 * tui/tui-data.h (tui_gen_win_info): Add an =default
1424 move constructor, required by some GCC versions.
1425
3960cb7a
JF
14262019-08-21 Jinke Fan <fanjinke51@yeah.net>
1427
1428 * go32-nat.c (go32_sysinfo): Add hygon_p.
1429
04c72a68
TT
14302019-08-20 Tom Tromey <tom@tromey.com>
1431
1432 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1433 line_from_reg_element_no, first_reg_element_no_inline,
1434 display_all_data, delete_data_content_windows,
1435 erase_data_content>: Now private.
1436
072272ce
TT
14372019-08-20 Tom Tromey <tom@tromey.com>
1438
1439 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1440 (tui_unhighlight_win, tui_highlight_win)
1441 (tui_win_info::make_window): Update.
1442 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1443
973961bd
TT
14442019-08-20 Tom Tromey <tom@tromey.com>
1445
1446 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1447 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1448 (MAX_PID_WIDTH): Move to tui-stack.c.
1449 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1450 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1451 (MAX_PID_WIDTH): Move from tui-data.h.
1452
ab0e1f1a
TT
14532019-08-20 Tom Tromey <tom@tromey.com>
1454
1455 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1456 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1457 (box_win): Update.
1458 (tui_gen_win_info::make_window): Rename from tui_make_window.
1459 (tui_win_info::make_window): New method.
1460 (tui_gen_win_info::make_visible): Update.
1461 * tui/tui-source.c (tui_source_window::set_contents): Update.
1462 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1463 (tui_data_window::display_registers_from): Update.
1464 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1465 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1466 Declare.
1467 <can_box>: Remove.
1468 <title>: Remove.
1469 (struct tui_win_info) <make_window>: Declare.
1470 <can_box>: Now virtual.
1471 <title>: New member.
1472 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1473 * tui/tui-command.c (tui_cmd_window::resize): Update.
1474
100c2bf3
TT
14752019-08-20 Tom Tromey <tom@tromey.com>
1476
1477 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1478 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1479 (tui_data_window::check_register_values): Update.
1480
fa4dc567
TT
14812019-08-20 Tom Tromey <tom@tromey.com>
1482
1483 * tui/tui-regs.h (struct tui_data_window): Use
1484 DISABLE_COPY_AND_ASSIGN.
1485 <regs_content>: Change type, removing unique_ptr.
1486 <tui_data_window>: Add move constructor.
1487 * tui/tui-regs.c (tui_data_window::show_registers)
1488 (tui_data_window::show_register_group)
1489 (tui_data_window::display_registers_from)
1490 (tui_data_window::display_registers_from)
1491 (tui_data_window::first_data_item_displayed)
1492 (tui_data_window::delete_data_content_windows)
1493 (tui_data_window::rerender, tui_data_window::refresh_window)
1494 (tui_data_window::check_register_values): Update.
1495
ca02d7c8
TT
14962019-08-20 Tom Tromey <tom@tromey.com>
1497
1498 * tui/tui-regs.h (struct tui_data_window) <show_registers,
1499 show_register_group>: Declare.
1500 (tui_show_register_group): Don't declare.
1501 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1502 tui_show_registers.
1503 (tui_data_window::show_register_group): Rename from
1504 tui_show_register_group.
1505 (tui_data_window::check_register_values, tui_reg_command):
1506 Update.
1507 * tui/tui-layout.c (tui_set_layout): Update.
1508
63356bfd
TT
15092019-08-20 Tom Tromey <tom@tromey.com>
1510
1511 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1512 Declare.
1513 (tui_check_register_values): Don't declare.
1514 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1515 from tui_check_register_values.
1516 * tui/tui-hooks.c (tui_register_changed): Update.
1517
42cc14a7
TT
15182019-08-20 Tom Tromey <tom@tromey.com>
1519
1520 * tui/tui-regs.c (tui_reg_layout): Move later.
1521 (tui_show_registers): Don't enable TUI mode or change layout.
1522
b9ad3686
TT
15232019-08-20 Tom Tromey <tom@tromey.com>
1524
1525 * tui/tui-regs.h (struct tui_data_item_window)
1526 <~tui_data_item_window>: Remove.
1527 <content>: Now a unique_xmalloc_ptr.
1528 * tui/tui-regs.c (tui_register_format): Return a
1529 unique_xmalloc_ptr.
1530 (tui_get_register): Update.
1531 (~tui_data_item_window): Remove.
1532 (tui_data_window::display_registers_from, tui_display_register):
1533 Update.
1534 * tui/tui-io.h (tui_expand_tabs): Update.
1535 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1536 Remove "col" parameter.
1537
8e114aab
TT
15382019-08-20 Tom Tromey <tom@tromey.com>
1539
1540 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1541 field.
1542 * tui/tui-regs.c (~tui_data_item_window): Update.
1543
1a4f81dd
TT
15442019-08-20 Tom Tromey <tom@tromey.com>
1545
1546 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1547 earlier.
1548
0f8d8876
TT
15492019-08-20 Tom Tromey <tom@tromey.com>
1550
1551 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1552
605dc2c2
TT
15532019-08-20 Tom Tromey <tom@tromey.com>
1554
1555 * tui/tui-source.h (struct tui_source_window): Update.
1556 * tui/tui-regs.c (tui_show_registers): Update.
1557 * tui/tui-disasm.h (struct tui_disasm_window): Update.
1558 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1559 (NO_REGS_STRING): Remove defines.
1560
aedbe3bb
CM
15612019-08-20 Conrad Meyer <cem@FreeBSD.org>
1562
1563 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1564 unnecessary thread walk if remote doesn't support the packet.
1565
7ce8f214
TT
15662019-08-19 Tom Tromey <tromey@adacore.com>
1567
1568 * python/py-value.c (value_has_field): Fix indentation.
1569
f21c2bd7
TT
15702019-08-19 Tom Tromey <tromey@adacore.com>
1571
1572 * printcmd.c (do_one_display, info_display_command): Update.
1573 * block.h (contained_in): Return bool. Add allow_nested
1574 parameter.
1575 * block.c (contained_in): Return bool. Add allow_nested
1576 parameter.
1577
d806ea2d
TT
15782019-08-19 Tom Tromey <tom@tromey.com>
1579
1580 * configure: Rebuild.
1581 * configure.ac: Disallow the combination of -static-libstdc++ and
1582 source highlight.
1583 * source-cache.c (get_language_name): Handle rust.
1584 (source_cache::get_source_lines): Ignore highlighting exceptions.
1585
398fdd60
TT
15862019-08-16 Tom Tromey <tom@tromey.com>
1587
1588 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1589 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1590 (struct tui_source_window_base) <make_visible, refresh_window,
1591 resize>: Remove methods.
1592 <execution_info>: Remove field.
1593 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1594 (tui_show_source_line, tui_source_window_base)
1595 (~tui_source_window_base): Update.
1596 (tui_source_window_base::resize)
1597 (tui_source_window_base::make_visible)
1598 (tui_source_window_base::refresh_window): Remove.
1599 (tui_source_window_base::update_exec_info): Update.
1600 * tui/tui-source.c (tui_source_window::set_contents): Update.
1601 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1602
e699d331
TT
16032019-08-16 Tom Tromey <tom@tromey.com>
1604
1605 * tui/tui-hooks.c (tui_remove_hooks): Don't set
1606 deprecated_query_hook.
1607
bb01dbfc
TT
16082019-08-16 Tom Tromey <tom@tromey.com>
1609
1610 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1611 (tui_update_source_windows_with_line): Update.
1612 * tui/tui-source.h (struct tui_source_window)
1613 <show_symtab_source>: Declare.
1614 (tui_show_symtab_source): Don't declare.
1615 * tui/tui-source.c (tui_show_symtab_source): Rename from
1616 tui_show_symtab_source.
1617
81c82c4b
TT
16182019-08-16 Tom Tromey <tom@tromey.com>
1619
1620 * tui/tui-winsource.h (struct tui_source_window_base)
1621 <set_contents>: Declare.
1622 * tui/tui-winsource.c
1623 (tui_source_window_base::update_source_window_as_is): Update.
1624 * tui/tui-source.h (struct tui_source_window) <set_contents>:
1625 Declare.
1626 (tui_set_source_content): Don't declare.
1627 * tui/tui-source.c (tui_source_window::set_contents): Rename from
1628 tui_set_source_content.
1629 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1630 Declare.
1631 (tui_set_disassem_content): Don't declare.
1632 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1633 tui_set_disassem_content.
1634
2ddaf614
TT
16352019-08-16 Tom Tromey <tom@tromey.com>
1636
1637 * tui/tui-winsource.h (struct tui_source_window_base)
1638 <update_breakpoint_info>: Declare.
1639 (tui_update_breakpoint_info): Don't declare.
1640 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1641 (tui_update_all_breakpoint_info): Update.
1642 (tui_source_window_base::update_breakpoint_info): Rename from
1643 tui_update_breakpoint_info.
1644 (tui_source_window_base::update_exec_info): Update.
1645
017f9828
TT
16462019-08-16 Tom Tromey <tom@tromey.com>
1647
1648 * tui/tui-winsource.h (struct tui_source_window_base)
1649 <update_source_window>: Declare.
1650 (tui_update_source_window): Don't declare.
1651 * tui/tui-winsource.c
1652 (tui_source_window_base::update_source_window): Rename from
1653 tui_update_source_window.
1654 (tui_source_window_base::rerender): Update.
1655 * tui/tui-source.c (tui_source_window::maybe_update): Update.
1656 * tui/tui-disasm.c (tui_show_disassem)
1657 (tui_show_disassem_and_update_source)
1658 (tui_disasm_window::maybe_update): Update.
1659
ed8358e9
TT
16602019-08-16 Tom Tromey <tom@tromey.com>
1661
1662 * tui/tui-winsource.h (struct tui_source_window_base)
1663 <update_source_window_as_is>: Declare.
1664 (tui_update_source_window_as_is): Don't declare.
1665 * tui/tui-winsource.c (tui_update_source_window): Update
1666 (tui_source_window_base::update_source_window_as_is): Rename from
1667 tui_update_source_window_as_is.
1668 (tui_source_window_base::refill): Update.
1669 * tui/tui-source.c (tui_show_symtab_source): Update.
1670 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1671 Update.
1672
20149b6b
TT
16732019-08-16 Tom Tromey <tom@tromey.com>
1674
1675 * tui/tui-winsource.h (tui_update_source_window)
1676 (tui_update_source_window_as_is): Remove "noerror" parameter.
1677 * tui/tui-winsource.c (tui_update_source_window)
1678 (tui_update_source_window_as_is): Remove "noerror" parameter.
1679 (tui_update_source_windows_with_addr)
1680 (tui_update_source_windows_with_line)
1681 (tui_source_window_base::rerender)
1682 (tui_source_window_base::refill): Update.
1683 * tui/tui-source.h (tui_set_source_content)
1684 (tui_show_symtab_source): Remove "noerror" parameter.
1685 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1686 parameter.
1687 (tui_show_symtab_source): Likewise.
1688 (tui_source_window::maybe_update): Update.
1689 * tui/tui-disasm.c (tui_show_disassem)
1690 (tui_show_disassem_and_update_source)
1691 (tui_disasm_window::do_scroll_vertical)
1692 (tui_disasm_window::maybe_update): Update.
1693
2d83e710
TT
16942019-08-16 Tom Tromey <tom@tromey.com>
1695
1696 * tui/tui.c (tui_is_window_visible): Update.
1697 * tui/tui-wingeneral.c (tui_make_window)
1698 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1699 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1700 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1701 (tui_set_win_height_command, parse_scrolling_args): Update.
1702 * tui/tui-source.c (tui_source_window::style_changed): Update.
1703 * tui/tui-regs.c (tui_show_registers)
1704 (tui_data_window::first_data_item_displayed)
1705 (tui_data_window::delete_data_content_windows)
1706 (tui_check_register_values, tui_reg_command): Update.
1707 * tui/tui-disasm.c (tui_show_disassem): Update.
1708 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1709 method.
1710 <is_visible>: Remove field.
1711 * tui/tui-data.c (tui_next_win, tui_prev_win)
1712 (tui_delete_invisible_windows): Update.
1713
d4ab829a
TT
17142019-08-16 Tom Tromey <tom@tromey.com>
1715
1716 * tui/tui-winsource.h (struct tui_source_window_base)
1717 <m_has_locator>: Remove.
1718 * tui/tui-layout.c (show_source_disasm_command, show_data)
1719 (show_source_or_disasm_and_command): Update.
1720
aa7ca1bb
AH
17212019-08-16 Alan Hayward <alan.hayward@arm.com>
1722
1723 * NEWS (Other MI changes): New subsection.
1724 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1725 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1726 * arch-utils.c (default_get_pc_address_flags): New function.
1727 * arch-utils.h (default_get_pc_address_flags): New declaration.
1728 * gdbarch.sh: Add get_pc_address_flags.
1729 * gdbarch.c: Regenerate.
1730 * gdbarch.h: Likewise.
1731 * stack.c (print_pc): New function.
1732 (print_frame_info) (print_frame): Call print_pc.
1733
6eac171f
TV
17342019-08-16 Tom de Vries <tdevries@suse.de>
1735
1736 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1737 print_objfile_section_info.
1738
3df505f6
TT
17392019-08-15 Tom Tromey <tom@tromey.com>
1740
1741 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1742 calling update_cmdwin_start_line.
1743 * tui/tui-winsource.h (struct tui_source_window_base)
1744 <do_make_visible_with_new_height, set_new_height>: Don't declare.
1745 <rerender>: Declare.
1746 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1747 Call rerender.
1748 (tui_source_window_base::set_new_height): Remove.
1749 (tui_source_window_base::rerender): Rename from
1750 do_make_visible_with_new_height.
1751 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1752 resize method.
1753 (tui_win_info::make_invisible_and_set_new_height)
1754 (tui_win_info::make_visible_with_new_height): Remove.
1755 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1756 Declare.
1757 * tui/tui-stack.c (tui_locator_window::rerender): New method.
1758 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1759 do_make_visible_with_new_height>: Don't declare.
1760 <rerender>: Declare.
1761 * tui/tui-regs.c (tui_data_window::rerender): Rename from
1762 set_new_height.
1763 (tui_data_window::do_make_visible_with_new_height): Remove.
1764 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1765 call tui_show_locator_content.
1766 (tui_gen_win_info::resize): Call rerender.
1767 (show_source_or_disasm_and_command): Don't call
1768 tui_show_locator_content.
1769 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1770 method.
1771 (struct tui_win_info) <rerender>: Declare.
1772 <set_new_height, make_invisible_and_set_new_height,
1773 make_visible_with_new_height>: Don't declare.
1774 * tui/tui-data.c (tui_win_list::rerender): New method.
1775 * tui/tui-command.h (struct tui_cmd_window)
1776 <do_make_visible_with_new_height>: Don't declare.
1777 * tui/tui-command.c
1778 (tui_cmd_window::do_make_visible_with_new_height): Remove.
1779
272560b5
TT
17802019-08-15 Tom Tromey <tromey@adacore.com>
1781
1782 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1783 * ada-lang.c (ada_enum_name): Likewise.
1784
08235187
CB
17852019-08-15 Christian Biesinger <cbiesinger@google.com>
1786
1787 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1788 leading underscore.
1789 (GdbOutputErrorFile): Likewise.
1790 (global scope): Adjust constructor calls to GdbOutput{,Error}File
1791 accordingly.
1792 (execute_unwinders): Rename to have a leading underscore.
1793 (auto_load_packages): Likewise.
1794 (global scope): Adjust call to auto_load_packages accordingly.
1795 (GdbSetPythonDirectory): Likewise.
1796 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1797 instead of execute_unwinders.
1798
db502012
TT
17992019-08-15 Tom Tromey <tom@tromey.com>
1800
1801 * tui/tui-layout.c (show_layout, show_source_disasm_command)
1802 (show_data): Don't change window visibility.
1803 (tui_gen_win_info::resize): Remove special case for command
1804 window. Use wresize, when available.
1805 (show_source_or_disasm_and_command): Don't change window
1806 visibility.
1807 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1808 <make_visible>: New method.
1809 * tui/tui-command.c (tui_cmd_window::resize): New method.
1810
3891b65e
TT
18112019-08-15 Tom Tromey <tom@tromey.com>
1812
1813 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1814 (struct tui_source_windows): New.
1815 * tui/tui-winsource.c (tui_display_main): Update.
1816 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1817 (new_height_ok, parse_scrolling_args): Update.
1818 * tui/tui-layout.c (show_layout, show_data): Update.
1819 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1820 (tui_add_to_source_windows): Don't declare.
1821 * tui/tui-data.c (source_windows, tui_source_windows)
1822 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1823
ee556432
TT
18242019-08-15 Tom Tromey <tom@tromey.com>
1825
1826 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1827 Rename from reset.
1828 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1829 * tui/tui-layout.c (show_source_disasm_command, show_data):
1830 Update.
1831 (tui_gen_win_info::resize): Rename.
1832 (show_source_or_disasm_and_command): Update.
1833 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1834 reset.
1835
46f438e3
TT
18362019-08-15 Tom Tromey <tom@tromey.com>
1837
1838 * tui/tui-stack.c (tui_initialize_static_data): Remove.
1839 * tui/tui-interp.c (tui_interp::init): Don't call
1840 tui_initialize_static_data.
1841 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1842
f4ce562c
TT
18432019-08-15 Tom Tromey <tom@tromey.com>
1844
1845 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1846 examine tui_win_list.
1847
c398c3d0
TT
18482019-08-15 Tom Tromey <tom@tromey.com>
1849
1850 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1851 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1852 tui_clear_source_content.
1853 (tui_clear_source_content): Remove.
1854 (tui_source_window_base::do_erase_source_content): Hoist call to
1855 content.clear().
1856 * tui/tui-stack.c (tui_show_frame_info): Don't call
1857 tui_clear_source_content.
1858
e25d2004
TT
18592019-08-15 Tom Tromey <tom@tromey.com>
1860
1861 * tui/tui-winsource.h (struct tui_source_window_base)
1862 <do_erase_source_content>: New method.
1863 <erase_source_content>: New method.
1864 (tui_erase_source_content): Don't declare.
1865 * tui/tui-winsource.c (tui_clear_source_content): Update.
1866 (tui_source_window_base::do_erase_source_content): Rename from
1867 tui_erase_source_content.
1868 (tui_source_window_base::show_source_content): Update.
1869 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1870 * tui/tui-source.h (struct tui_source_window)
1871 <erase_source_content>: New method.
1872 * tui/tui-disasm.h (struct tui_disasm_window)
1873 <erase_source_content>: New method.
1874
002f15c2
TT
18752019-08-15 Tom Tromey <tom@tromey.com>
1876
1877 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1878 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1879 constructor.
1880 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1881 * tui/tui-source.c (tui_set_source_content): Update.
1882 * tui/tui-disasm.c (tui_set_disassem_content): Update.
1883
c9033fe8
TT
18842019-08-15 Tom Tromey <tom@tromey.com>
1885
1886 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1887 * tui/tui-winsource.c (tui_line_is_displayed): Move to
1888 tui-source.c.
1889 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1890 Declare.
1891 * tui/tui-source.c (tui_source_window::line_is_displayed): New
1892 method.
1893 (tui_source_window::maybe_update): Update.
1894
088f37dd
TT
18952019-08-15 Tom Tromey <tom@tromey.com>
1896
1897 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1898 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1899 tui-disasm.c.
1900 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1901 Declare.
1902 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1903 method.
1904 (tui_disasm_window::maybe_update): Update.
1905
a54700c6
TT
19062019-08-15 Tom Tromey <tom@tromey.com>
1907
1908 * tui/tui-winsource.h (struct tui_source_window_base)
1909 <maybe_update>: Declare.
1910 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1911 method.
1912 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1913 Declare.
1914 * tui/tui-source.c (tui_source_window::maybe_update): New method.
1915 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1916 Declare.
1917 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1918
e2a678a5
TT
19192019-08-15 Tom Tromey <tom@tromey.com>
1920
1921 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1922
f2dda477
TT
19232019-08-15 Tom Tromey <tom@tromey.com>
1924
1925 * tui/tui-wingeneral.c: Include tui-stack.h.
1926 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1927 (struct tui_locator_window): Move from tui-data.h.
1928 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1929 (tui_initialize_static_data): Move from tui-data.c.
1930 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1931 (struct tui_locator_window): Move to tui-stack.c.
1932 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1933 (tui_initialize_static_data): Move to tui-stack.c.
1934
ed4a1084
TT
19352019-08-15 Tom Tromey <tom@tromey.com>
1936
1937 * tui/tui-layout.c (show_source_disasm_command)
1938 (show_source_or_disasm_and_command): Use make_visible method, not
1939 tui_make_window.
1940 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1941 Remove.
1942
65962b20
TT
19432019-08-15 Tom Tromey <tom@tromey.com>
1944
1945 * tui/tui-wingeneral.h (tui_make_window): Update.
1946 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1947 parameter.
1948 (tui_gen_win_info::make_visible): Update.
1949 * tui/tui-regs.c (tui_data_window::display_registers_from):
1950 Update.
1951 * tui/tui-layout.c (show_source_disasm_command)
1952 (show_source_or_disasm_and_command): Update.
1953 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1954 (enum tui_box): Remove.
1955 (struct tui_win_info) <can_box>: New method.
1956 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1957 method.
1958
2208ee91
TV
19592019-08-15 Tom de Vries <tdevries@suse.de>
1960
1961 * linux-nat-trad.c: Include gdbarch.h.
1962
75faf5c4
AH
19632019-08-14 Alan Hayward <alan.hayward@arm.com>
1964
1965 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1966 register sizes.
1967
b1c896b3
TT
19682019-08-14 Tom Tromey <tromey@adacore.com>
1969
1970 * darwin-nat.c: Include gdbarch.h.
1971 * darwin-nat-info.c: Include gdbarch.h.
1972
6405cd73
TT
19732019-08-13 Tom Tromey <tom@tromey.com>
1974
1975 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1976 Remove.
1977 * tui/tui-data.c (tui_initialize_static_data): Update.
1978
5216580d
TT
19792019-08-13 Tom Tromey <tom@tromey.com>
1980
1981 * tui/tui-winsource.h (struct tui_exec_info_window)
1982 <~tui_exec_info_window, maybe_allocate_content, get_content,
1983 m_content>: Remove.
1984 (struct tui_source_window_base) <set_exec_info_content,
1985 show_exec_info_content>: Don't declare.
1986 * tui/tui-winsource.c
1987 (tui_exec_info_window::maybe_allocate_content): Remove.
1988 (tui_source_window_base::update_exec_info): Rename from
1989 set_exec_info_content.
1990 (tui_source_window_base::show_exec_info_content)
1991 (tui_source_window_base::update_exec_info): Remove.
1992
93858ad3
TT
19932019-08-13 Tom Tromey <tom@tromey.com>
1994
1995 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1996 declare.
1997 * tui/tui-winsource.c (tui_update_source_window_as_is)
1998 (tui_update_source_windows_with_addr, tui_erase_source_content):
1999 Update.
2000 (tui_clear_exec_info_content): Remove.
2001
e321e7ce
TT
20022019-08-13 Tom Tromey <tom@tromey.com>
2003
2004 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2005 declare.
2006 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2007 call tui_erase_exec_info_content.
2008 (tui_clear_exec_info_content): Rename from
2009 tui_erase_exec_info_content.
2010 (tui_clear_exec_info_content): Delete.
2011
8270ac62
TT
20122019-08-13 Tom Tromey <tom@tromey.com>
2013
2014 * tui/tui-winsource.h (struct tui_source_window_base)
2015 <show_exec_info_content>: Declare.
2016 (tui_show_exec_info_content): Don't declare.
2017 * tui/tui-winsource.c
2018 (tui_source_window_base::show_exec_info_content): Rename from
2019 tui_show_exec_info_content.
2020 (tui_source_window_base::update_exec_info): Update.
2021
7b56485d
TT
20222019-08-13 Tom Tromey <tom@tromey.com>
2023
2024 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2025 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2026 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2027 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2028 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2029 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2030 ... here.
2031
7ba913dc
TT
20322019-08-13 Tom Tromey <tom@tromey.com>
2033
2034 * tui/tui-winsource.h (struct tui_source_window_base)
2035 <update_exec_info>: Declare.
2036 (tui_update_exec_info): Don't declare.
2037 * tui/tui-winsource.c (tui_update_source_window_as_is)
2038 (tui_source_window_base::refresh_all)
2039 (tui_update_all_breakpoint_info): Update.
2040 (tui_source_window_base::update_exec_info): Rename from
2041 tui_update_exec_info.
2042 * tui/tui-stack.c (tui_show_frame_info): Update.
2043
37a4a131
TT
20442019-08-13 Tom Tromey <tom@tromey.com>
2045
2046 * tui/tui-winsource.h (struct tui_source_window_base)
2047 <set_exec_info_content>: Declare.
2048 (tui_set_exec_info_content): Don't declare.
2049 * tui/tui-winsource.c
2050 (tui_source_window_base::set_exec_info_content): Rename from
2051 tui_set_exec_info_content.
2052 (tui_update_exec_info): Update.
2053
0bd27e07
TT
20542019-08-13 Tom Tromey <tom@tromey.com>
2055
2056 * tui/tui-winsource.h (struct tui_source_window_base)
2057 <show_source_content>: Declare.
2058 (tui_show_source_content): Don't declare.
2059 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2060 (tui_source_window_base::show_source_content): Rename from
2061 tui_show_source_content.
2062 (tui_source_window_base::refresh_all): Update.
2063 * tui/tui-layout.c (show_source_disasm_command)
2064 (show_source_or_disasm_and_command): Update.
2065
b4ef5aeb
TT
20662019-08-13 Tom Tromey <tom@tromey.com>
2067
2068 * tui/tui-winsource.c (tui_erase_source_content)
2069 (tui_show_source_content, tui_source_window_base::refresh_all):
2070 Update.
2071 * tui/tui-wingeneral.h
2072 (tui_check_and_display_highlight_if_needed): Don't declare.
2073 * tui/tui-wingeneral.c
2074 (tui_win_info::check_and_display_highlight_if_needed): Rename from
2075 check_and_display_highlight_if_needed.
2076 * tui/tui-win.c (tui_rehighlight_all)
2077 (tui_win_info::make_visible_with_new_height): Update.
2078 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2079 (tui_data_window::erase_data_content)
2080 (tui_data_window::display_all_data): Update.
2081 * tui/tui-data.h (struct tui_win_info)
2082 <check_and_display_highlight_if_needed>: Declare.
2083
fede5273
TT
20842019-08-13 Tom Tromey <tom@tromey.com>
2085
2086 * tui/tui-win.c (tui_resize_all): Call
2087 tui_delete_invisible_windows.
2088 * tui/tui-layout.c (show_layout): Call
2089 tui_delete_invisible_windows.
2090 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2091 * tui/tui-data.c (tui_delete_invisible_windows): New function.
2092
22c3f490
TT
20932019-08-13 Tom Tromey <tom@tromey.com>
2094
2095 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
2096 tui_add_win_to_layout.
2097
16cb7910
TT
20982019-08-13 Tom Tromey <tom@tromey.com>
2099
2100 * tui/tui-layout.h (tui_default_win_height): Don't declare.
2101 * tui/tui-layout.c (tui_default_win_height): Now static.
2102
cc0c3ffb
TT
21032019-08-13 Tom Tromey <tom@tromey.com>
2104
2105 * tui/tui-layout.c (show_layout): Unify all layout cases into a
2106 single switch.
2107 (show_source_disasm_command, show_source_or_disasm_and_command):
2108 Don't check current layout.
2109
3f3ffe54
TT
21102019-08-13 Tom Tromey <tom@tromey.com>
2111
2112 * tui/tui-wingeneral.c (make_all_visible): Remove.
2113 (tui_make_all_invisible): Simplify.
2114 * tui/tui-layout.c (tui_make_all_invisible): Move from
2115 tui-wingeneral.c; simplify.
2116 (show_layout): Hoist call to tui_make_all_invisible.
2117 (show_data): Don't call tui_make_all_invisible.
2118
69258091
TT
21192019-08-13 Tom Tromey <tom@tromey.com>
2120
2121 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2122 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2123
62cf57fe
TT
21242019-08-13 Tom Tromey <tom@tromey.com>
2125
2126 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2127 tui-data.c.
2128 (show_source_disasm_command, show_data)
2129 (show_source_or_disasm_and_command): Don't use
2130 tui_set_current_layout_to.
2131 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2132 * tui/tui-data.c (current_layout, tui_current_layout): Move to
2133 tui-layout.c.
2134 (tui_set_current_layout_to): Remove.
2135
2afade5d
TT
21362019-08-13 Tom Tromey <tom@tromey.com>
2137
2138 * tui/tui-layout.c (tui_set_layout): Update.
2139 * tui/tui-data.h (struct tui_layout_def): Remove.
2140 (tui_layout_def): Don't declare.
2141 * tui/tui-data.c (layout_def): Remove.
2142 (tui_layout_def): Remove.
2143
a3504e96
TT
21442019-08-13 Tom Tromey <tom@tromey.com>
2145
2146 * tui/tui-winsource.h (struct tui_source_window_base)
2147 <clear_detail>: No longer "override".
2148 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2149 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2150 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2151 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2152 Remove.
2153 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2154
29c92911
TT
21552019-08-13 Tom Tromey <tromey@adacore.com>
2156
2157 * tracepoint.c: Don't include readline.h or history.h.
2158
86c6b807
TT
21592019-08-12 Tom Tromey <tom@tromey.com>
2160
2161 * configure: Rebuild.
2162 * configure.ac: Check for readline 7.
2163 * NEWS: Mention readline 7 requirement.
2164 * README: Update.
2165
5db2718c
TT
21662019-08-12 Tom Tromey <tom@tromey.com>
2167
2168 * mingw-hdep.c (gdb_select): Remove readline hack.
2169
dac36daf
PFC
21702019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2171
2172 * blockframe.c (find_pc_partial_function): Set *block to nullptr
2173 when the function fails.
2174
1022c627
AA
21752019-08-09 Andreas Arnez <arnez@linux.ibm.com>
2176
2177 * s390-tdep.c (s390_type_align): New function.
2178 (s390_gdbarch_init): Set it as type_align gdbarch method.
2179
eba4caf2
TV
21802019-08-09 Tom de Vries <tdevries@suse.de>
2181
2182 PR gdb/24591
2183 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2184 pc_low with relocation offset.
2185
123cd851
TT
21862019-08-07 Tom Tromey <tromey@adacore.com>
2187
2188 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2189 (print_frame_args): Update.
2190 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2191 Update.
2192 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2193 * frame.h (struct frame_arg): Add initializers.
2194 <error>: Now a unique_xmalloc_ptr.
2195
3d31bc39
AH
21962019-08-07 Alan Hayward <alan.hayward@arm.com>
2197
2198 * NEWS: Expand the Pointer Authentication entry.
2199 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2200 (aarch64_frame_unmask_lr): ... to this.
2201 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2202 Call aarch64_frame_unmask_lr.
2203 * frame.c (struct frame_info): Add "masked" variable.
2204 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2205 (fprint_frame): Check for masked pc.
2206 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2207 declarations.
2208 * python/py-framefilter.c (py_print_frame): Check for masked pc.
2209 * stack.c (print_frame): Check for masked pc.
2210
0cf9feb9
TT
22112019-08-06 Tom Tromey <tom@tromey.com>
2212
2213 * stabsread.c (patch_block_stabs, read_one_struct_field)
2214 (read_enum_type): Use obstack_strndup.
2215 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2216 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2217 * dwarf2read.c (guess_full_die_structure_name)
2218 (anonymous_struct_prefix): Use obstack_strndup.
2219 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2220 * c-exp.y (yylex): Use obstack_strndup.
2221 * ada-exp.y (write_object_renaming, write_ambiguous_var)
2222 (write_var_or_type): Use obstack_strndup.
2223
efba19b0
TT
22242019-08-06 Tom Tromey <tom@tromey.com>
2225
2226 * symfile.c (reread_symbols): Use obstack_strdup.
2227 * stabsread.c (read_type): Use obstack_strdup.
2228 * gdb_obstack.h (obstack_strdup): New overload.
2229 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2230 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2231 (dwarf2_canonicalize_name): Use obstack_strdup.
2232 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2233 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2234 Use obstack_strdup.
2235
f25102f7
TT
22362019-08-06 Tom Tromey <tom@tromey.com>
2237
2238 * gdb_obstack.h (obstack_strdup): Define.
2239 * gdb_obstack.c (obstack_strdup): Don't define.
2240
021887d8
TT
22412019-08-06 Tom Tromey <tom@tromey.com>
2242
2243 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2244 obstack_strdup.
2245 * typeprint.c (typedef_hash_table::find_global_typedef): Use
2246 obstack_strdup.
2247 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2248 * stabsread.c (common_block_start): Use obstack_strdup.
2249 * objfiles.c (set_objfile_main_name, objfile): Use
2250 obstack_strdup.
2251 * namespace.c (add_using_directive): Use obstack_strdup.
2252 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2253 * jit.c (finalize_symtab): Use obstack_strdup.
2254 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2255 (guess_partial_die_structure_name, partial_die_info::fixup)
2256 (dwarf2_name): Use obstack_strdup.
2257 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2258 obstack_strdup.
2259 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2260 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2261 obstack_strdup.
2262 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2263
d2834edc
PW
22642019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2265
2266 * unittests/help-doc-selftests.c: New file.
2267 * Makefile.in: Add the new file.
2268
590042fc
PW
22692019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2270
2271 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2272 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
2273 the full first line, except when FOR_VALUE_PREFIX. In this case,
2274 the trailing '.' is not output, and the first character is uppercased.
2275 (print_help_for_command): Update call to print_doc_line.
2276 (print_doc_of_command): Likewise.
2277 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2278 * cli/cli-option.c (append_indented_doc): Do not append newline.
2279 (build_help_option): Append newline after first appended_indented_doc
2280 only if a second call is done.
2281 (build_help): Append 2 new lines before each option, except the first
2282 one.
2283 * compile/compile.c (_initialize_compile): Add new lines after
2284 %OPTIONS%, when not at the end of the help.
2285 Change help doc or code
2286 producing the help doc to respect the invariants.
2287 * maint-test-options.c (_initialize_maint_test_options): Likewise.
2288 Also removed the new line after 'Options:', as all other commands
2289 do not put an empty line between 'Options:' and the first option.
2290 * printcmd.c (_initialize_printcmd): Likewise.
2291 * stack.c (_initialize_stack): Likewise.
2292 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2293 incorrectly telling COMMAND is optional.
2294 * ada-lang.c (_initialize_ada_language): Change help doc or code
2295 producing the help doc to respect the invariants.
2296 * ada-tasks.c (_initialize_ada_tasks): Likewise.
2297 * breakpoint.c (_initialize_breakpoint): Likewise.
2298 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2299 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2300 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2301 * cli/cli-style.c (cli_style_option::add_setshow_commands,
2302 _initialize_cli_style): Likewise.
2303 * corelow.c (core_target_info): Likewise.
2304 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2305 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2306 * filesystem.c (_initialize_filesystem): Likewise.
2307 * frame.c (_initialize_frame): Likewise.
2308 * gnu-nat.c (add_task_commands): Likewise.
2309 * infcall.c (_initialize_infcall): Likewise.
2310 * infcmd.c (_initialize_infcmd): Likewise.
2311 * interps.c (_initialize_interpreter): Likewise.
2312 * language.c (_initialize_language): Likewise.
2313 * linux-fork.c (_initialize_linux_fork): Likewise.
2314 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2315 * maint.c (_initialize_maint_cmds): Likewise.
2316 * memattr.c (_initialize_mem): Likewise.
2317 * printcmd.c (_initialize_printcmd): Likewise.
2318 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2319 _RegEx): Likewise.
2320 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2321 * record-btrace.c (_initialize_record_btrace): Likewise.
2322 * record-full.c (_initialize_record_full): Likewise.
2323 * record.c (_initialize_record): Likewise.
2324 * regcache-dump.c (_initialize_regcache_dump): Likewise.
2325 * regcache.c (_initialize_regcache): Likewise.
2326 * remote.c (add_packet_config_cmd, init_remote_threadtests,
2327 _initialize_remote): Likewise.
2328 * ser-tcp.c (_initialize_ser_tcp): Likewise.
2329 * serial.c (_initialize_serial): Likewise.
2330 * skip.c (_initialize_step_skip): Likewise.
2331 * source.c (_initialize_source): Likewise.
2332 * stack.c (_initialize_stack): Likewise.
2333 * symfile.c (_initialize_symfile): Likewise.
2334 * symtab.c (_initialize_symtab): Likewise.
2335 * target-descriptions.c (_initialize_target_descriptions): Likewise.
2336 * top.c (init_main): Likewise.
2337 * tracefile-tfile.c (tfile_target_info): Likewise.
2338 * tracepoint.c (_initialize_tracepoint): Likewise.
2339 * tui/tui-win.c (_initialize_tui_win): Likewise.
2340 * utils.c (add_internal_problem_command): Likewise.
2341 * valprint.c (value_print_option_defs): Likewise.
2342
404f2902
FCE
23432019-08-06 Frank Ch. Eigler <fche@redhat.com>
2344
2345 PR build/24886
2346 * configure.ac: Drop enable-libmcheck support.
2347 * configure, config.in: Rebuild.
2348 * libmcheck.m4: Remove.
2349 * acinclude.m4: Don't include it.
2350 * Makefile.in: Don't distribute it.
2351 * top.c (print_gdb_configuration): Don't mention it.
2352
046bebe1
TT
23532019-08-06 Tom Tromey <tom@tromey.com>
2354
2355 * utils.c (set_output_style): Sometimes pass stream to
2356 emit_style_escape.
2357 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2358 * record-btrace.c (btrace_insn_history): Update.
2359 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2360 method.
2361 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2362 Update initializers.
2363 <m_uiout>: New field.
2364 <m_di>: Move lower.
2365 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2366 Remove "uiout" parameter.
2367 (dump_insns): Update.
2368 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2369 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2370
ddbcedf5
CB
23712019-08-06 Christian Biesinger <cbiesinger@google.com>
2372
2373 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2374 (error_in_psymtab_expansion): Likewise.
2375 (lookup_symbol_via_quick_fns): Likewise.
2376 (basic_lookup_transparent_type_quick): Likewise.
2377 (basic_lookup_transparent_type_1): Likewise.
2378
b08b16c8
TT
23792019-08-06 Tom Tromey <tromey@adacore.com>
2380
2381 * source.c (last_source_error): Now bool.
2382 (print_source_lines_base): Make "noprint" bool. Only open
2383 source file when last_source_visited changes.
2384
cb44333d
TT
23852019-08-06 Tom Tromey <tromey@adacore.com>
2386
2387 * annotate.c (annotate_source_line): Use g_source_cache.
2388 * source-cache.c (source_cache::get_plain_source_lines): Change
2389 parameters. Populate m_offset_cache.
2390 (source_cache::ensure): New method.
2391 (source_cache::get_line_charpos): New method.
2392 (extract_lines): Move lower. Change parameters.
2393 (source_cache::get_source_lines): Move lower.
2394 * source-cache.h (class source_cache): Update comment.
2395 <get_line_charpos>: New method.
2396 <get_source_lines>: Update comment.
2397 <clear>: Clear m_offset_cache.
2398 <get_plain_source_lines>: Change parameters.
2399 <ensure>: New method
2400 <m_offset_cache>: New member.
2401 * source.c (forget_cached_source_info_for_objfile): Update.
2402 (info_source_command): Use g_source_cache.
2403 (find_source_lines, open_source_file_with_line_charpos): Remove.
2404 (print_source_lines_base, search_command_helper): Use g_source_cache.
2405 * source.h (open_source_file_with_line_charpos): Don't declare.
2406 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2407 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2408 Use g_source_cache.
2409
872dceaa
TT
24102019-08-06 Tom Tromey <tromey@adacore.com>
2411
2412 * source-cache.c (source_cache::get_plain_source_lines):
2413 Remove "first_line" and "last_line" parameters.
2414 (source_cache::get_source_lines): Cache plain text.
2415 * source-cache.h (class source_cache)
2416 <get_plain_source_lines>: Update.
2417
269249d9
TT
24182019-08-06 Tom Tromey <tromey@adacore.com>
2419
2420 * source-cache.c (extract_lines): No longer a method.
2421 Changed type of parameter. Include final newline.
2422 (selftests::extract_lines_test): New function.
2423 (_initialize_source_cache): Likewise.
2424 * source-cache.h (class source_cache)
2425 <extract_lines>: Don't declare.
2426
c0e8dcd8
TT
24272019-08-06 Tom Tromey <tromey@adacore.com>
2428
2429 * breakpoint.c (init_breakpoint_sal): Update.
2430 (breakpoint): Update.
2431 * breakpoint.h (struct breakpoint) <filter>: Now a
2432 unique_xmalloc_ptr.
2433
0b27c27d
CB
24342019-08-05 Christian Biesinger <cbiesinger@google.com>
2435
2436 * NEWS: Mention dictionary access on blocks.
2437 * python/py-block.c (blpy_getitem): New function.
2438 (block_object_as_mapping): New struct.
2439 (block_object_type): Use new struct for tp_as_mapping field.
2440
4ee94178
CB
24412019-08-05 Christian Biesinger <cbiesinger@google.com>
2442
2443 * objfiles.h (objfile): Add a comment describing partial symbols.
2444
8abfcabc
TT
24452019-08-05 Tom Tromey <tromey@adacore.com>
2446
2447 * compile/compile.c (_initialize_compile): Use _(), not N_().
2448 * thread.c (_initialize_thread): Use _(), not N_().
2449 * stack.c (_initialize_stack): Use _(), not N_().
2450 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2451
2b79f376
SM
24522019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2453
2454 * dwarf2read.c (struct dw2_symtab_iterator):
2455 <want_specific_block>: Remove.
2456 <block_index>: Change type to gdb::optional.
2457 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2458 change type of BLOCK_INDEX parameter to gdb::optional.
2459 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2460 (dw2_lookup_symbol): Don't pass argument for
2461 WANT_SPECIFIC_BLOCK.
2462 (dw2_expand_symtabs_for_function): Don't pass argument for
2463 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2464 (class dw2_debug_names_iterator)
2465 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2466 parameter, change BLOCK_INDEX type to gdb::optional.
2467 <m_want_specific_block>: Remove.
2468 <m_block_index>: Change type to gdb::optional.
2469 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2470 gdb::optional. Re-write in function of gdb::optional.
2471 (dw2_debug_names_lookup_symbol): Don't pass argument for
2472 WANT_SPECIFIC_BLOCK.
2473 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2474 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2475 BLOCK_INDEX.
2476
ae60f04e
PW
24772019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2478
2479 * NEWS: Mention changes to "info sources" command.
2480
28cd9371
PW
24812019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2482
2483 * symtab.c (filename_partial_match_opts): New struct type.
2484 (struct output_source_filename_data): New members
2485 regexp, c_regexp, partial_match.
2486 (output_source_filename): Use new members to decide to print file.
2487 (info_sources_option_defs): New variable.
2488 (make_info_sources_options_def_group, print_info_sources_header,
2489 info_sources_command_completer):
2490 New functions.
2491 (info_sources_command): Read new optional arguments.
2492 (_initialize_symtab): Update info sources help.
2493
ca683e3a
AO
24942019-08-02 Alexandre Oliva <oliva@adacore.com>
2495
2496 * ada-lang.c (exception_support_info_v0): Renamed from...
2497 (default_exception_support_info): ... this. Create new
2498 definition for v1.
2499 (ada_has_this_exception_support): Look up catch_handlers_sym.
2500 (ada_exception_support_info_sniffer): Try v0 after default.
2501
f1264162
TT
25022019-08-01 Tom Tromey <tromey@adacore.com>
2503
2504 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2505 gdbarch.h.
2506
0a7b2485
CB
25072019-08-01 Christian Biesinger <cbiesinger@google.com>
2508
2509 * s12z-tdep.c: Fix include path for s12z-opc.h.
2510
c6bdbeb7
AH
25112019-08-01 Alan Hayward <alan.hayward@arm.com>
2512
2513 * NEWS: Require GNU make 3.82.
2514
a2bd7b82
TT
25152019-07-16 Tom Tromey <tom@tromey.com>
2516
2517 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2518 declare.
2519
aa3b6533
TT
25202019-07-30 Tom Tromey <tromey@adacore.com>
2521
2522 * block.c (contained_in): Remove BLOCK_FUNCTION check.
2523
a1530dc7
KB
25242019-07-30 Kevin Buettner <kevinb@redhat.com>
2525
2526 * printcmd.c (print_address_symbolic): Print negative offsets.
2527 (build_address_symbolic): Force signed arithmetic when computing
2528 offset.
2529
2906593f
CB
25302019-07-30 Christian Biesinger <cbiesinger@google.com>
2531
2532 PR/24474: Add a function to lookup static variables.
2533 * NEWS: Mention this new function.
2534 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2535 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2536 * python/python.c (python_GdbMethods): Add new function.
2537
c620ed88
CB
25382019-07-29 Christian Biesinger <cbiesinger@google.com>
2539
2540 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2541 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2542 (objfpy_lookup_static_symbol): New function.
2543 (objfile_object_methods): Add new functions.
2544
bc4268a5
PW
25452019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2546
2547 * NEWS: Mention 'set|show print frame-info'. Mention new
2548 'presence' value for 'frame-arguments'. Mention new '-frame-info'
2549 backtrace argument. Mention that python frame filtering code
2550 is now consistent with what 'backtrace' command prints.
2551
4b5e8d19
PW
25522019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2553
2554 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2555 comments.
2556 (print_frame_info_auto, print_frame_info_source_line,
2557 print_frame_info_location, print_frame_info_source_and_location,
2558 print_frame_info_location_and_address, print_frame_info_short_location):
2559 New declarations.
2560 (struct frame_print_options): New member print_frame_info.
2561 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2562 * stack.h (get_user_print_what_frame_info): New declaration.
2563 (frame_show_address): New declaration.
2564 * stack.c (print_frame_arguments_choices): New value 'presence'.
2565 (print_frame_info_auto, print_frame_info_source_line,
2566 print_frame_info_location, print_frame_info_source_and_location,
2567 print_frame_info_location_and_address, print_frame_info_short_location,
2568 print_frame_info_choices, print_frame_info_print_what): New definitions.
2569 (print_frame_args): Only print dots for args if print frame-arguments
2570 is 'presence'.
2571 (frame_print_option_defs): New element for "frame-info".
2572 (get_user_print_what_frame_info): New function.
2573 (frame_show_address): Make non static. Move comment to stack.h.
2574 (print_frame_info_to_print_what): New function.
2575 (print_frame_info): Update comment. Use fp_opts.print_frame_info
2576 to decide what to print.
2577 (backtrace_command_1): Handle the new print_frame_arguments_presence
2578 value.
2579 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2580 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2581 (py_print_frame): In non-mi mode, use LOCATION as default for
2582 print_what, similarly to frame information printed directly by
2583 backtrace command. Handle frame-info user option in non MI mode.
2584
6bdfee81
KB
25852019-07-27 Kevin Buettner <kevinb@redhat.com>
2586
2587 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2588 Add case for debugging 32-bit target on 64-bit host. Revise
2589 comment.
2590
98a617f8
KB
25912019-07-27 Kevin Buettner <kevinb@redhat.com>
2592
2593 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2594 instead of find_function_entry_range_from_pc.
2595
567238c9
KB
25962019-07-27 Kevin Buettner <kevinb@redhat.com>
2597
2598 * stack.c (find_frame_funname): Remove code which preferred
2599 minsym over symtab sym in "certain pathological cases".
2600
2dc80cf8
KB
2601 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2602 parameter. Change type of "do_demangle" to bool.
2603 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2604 Pass suitable "prefer_sym_over_minsym" flag to
2605 build_address_symbolic(). Don't output "+" for negative offsets.
2606 * printcmd.c (print_address_symbolic): Update invocation of
2607 build_address_symbolic to include a "prefer_sym_over_minsym"
2608 flag.
2609 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2610 Restrict cases in which use of minimal symbol is preferred to that
2611 of a found symbol. Update comments.
2612
1aff7173
KB
2613 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2614 for entry pc when entry pc is out of range for that FDE.
2615
89b085ac
BC
26162019-07-26 Brian Callahan <bcallah@openbsd.org>
2617
2618 PR gdb/24839:
2619 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2620 type.
2621
f32feb4a
CB
26222019-07-25 Christian Biesinger <cbiesinger@google.com>
2623
2624 * python/py-objfile.c (add_separate_debug_file): Fix comment about
2625 this function's Python signature.
2626
2627
26282019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
2629
2630 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2631 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2632 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2633 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2634 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2635
2636
c54e4253
YS
26372019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
2638
2639 * h8300-tdep.c (h8300_register_name_common): New.
2640 h8300_register_name): Use h8300_register_name_common.
2641 (h8300s_register_name): Likewise.
2642 (h8300sx_register_name): Likewise.
2643 (h8300h_register_nam): New.
2644 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2645
2646
40eadf04
SP
26472019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
2648
2649 * arm-tdep.c (arm_skip_cmse_entry): New function.
2650 (arm_is_sgstubs_section): New function.
2651 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2652
bfa2a36d
TT
26532019-07-22 Tom Tromey <tom@tromey.com>
2654
2655 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2656 Don't self-assign.
2657
a8e9d247
AB
26582019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2659
2660 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2661 type_print.
2662
eb86c5e2
AB
26632019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2664
2665 * symtab.c (search_symbols): Adjust msymbol matching type arrays
2666 so that GDB doesn't match any msymbols when searching in the
2667 TYPES_DOMAIN.
2668 (print_symbol_info): Print using typedef_print or type_print based
2669 on the type of the symbol. Add updated FIXME comment moved from...
2670 (_initialize_symtab): ... move and update FIXME comment to above.
2671
a8eab7c6
AB
26722019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2673
2674 * NEWS: Mention adding -q option to "info types".
2675 * symtab.c (struct info_types_options): New struct.
2676 (info_types_options_defs): New variable.
2677 (make_info_types_options_def_group): New function.
2678 (info_types_command): Use gdb::option framework to parse options.
2679 (info_types_command_completer): New function.
2680 (_initialize_symtab): Extend the help text on "info types" and
2681 register command completer.
2682
b4603c34
CB
26832019-07-21 Christian Biesinger <cbiesinger@google.com>
2684
2685 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2686 (lookup_symbol_in_objfile): Change int to block_enum and add a
2687 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2688
c8cdc1e0
CB
26892019-07-20 Christian Biesinger <cbiesinger@google.com>
2690
2691 * MAINTAINERS (Write After Approval): Add self.
2692
01e175fe
AB
26932019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
2694
2695 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2696 instruction to the dummy code region.
2697
56f79b63
TT
26982019-07-19 Tom Tromey <tromey@adacore.com>
2699
2700 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2701 (ARGSUSED, PARAMS, __func__): Remove rules.
2702
4c5aa8e0
AH
27032019-07-19 Alan Hayward <alan.hayward@arm.com>
2704
2705 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2706 * features/arm/arm-with-iwmmxt.c: Remove.
2707 * features/arm/arm-with-iwmmxt.xml: Remove.
2708 * features/arm/arm-with-m-fpa-layout.c: Remove.
2709 * features/arm/arm-with-m-fpa-layout.xml: Remove.
2710 * features/arm/arm-with-m-vfp-d16.c: Remove.
2711 * features/arm/arm-with-m-vfp-d16.xml: Remove.
2712 * features/arm/arm-with-m.c: Remove.
2713 * features/arm/arm-with-m.xml: Remove.
2714 * features/arm/arm-with-neon.c: Remove.
2715 * features/arm/arm-with-neon.xml: Remove.
2716 * features/arm/arm-with-vfpv2.c: Remove.
2717 * features/arm/arm-with-vfpv2.xml: Remove.
2718 * features/arm/arm-with-vfpv3.c: Remove.
2719 * features/arm/arm-with-vfpv3.xml: Remove.
2720
f42b2617
AH
27212019-07-19 Alan Hayward <alan.hayward@arm.com>
2722
2723 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2724
f29ec966
AH
27252019-07-19 Alan Hayward <alan.hayward@arm.com>
2726
2727 * arch/aarch32.c (aarch32_create_target_description): Create
2728 target descriptions using features.
2729 * arch/arm.c (arm_create_target_description)
2730 (arm_create_mprofile_target_description): Likewise.
2731 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2732
d105cce5
AH
27332019-07-19 Alan Hayward <alan.hayward@arm.com>
2734
2735 * Makefile.in: Add new files.
2736 * aarch32-tdep.c: New file.
2737 * aarch32-tdep.h: New file.
2738 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2739 Call aarch32_read_description.
2740 * arch/aarch32.c: New file.
2741 * arch/aarch32.h: New file.
2742 * arch/arm.c (arm_create_target_description)
2743 (arm_create_mprofile_target_description): New function.
2744 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2745 (arm_create_target_description)
2746 (arm_create_mprofile_target_description): New declaration.
2747 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2748 read_description functions.
2749 * arm-linux-nat.c (arm_linux_nat_target::read_description):
2750 Likewise.
2751 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2752 * arm-tdep.c (tdesc_arm_list): New variable.
2753 (arm_register_g_packet_guesses): Call create description functions.
2754 (arm_read_description) (arm_read_mprofile_description): New
2755 function.
2756 * arm-tdep.h (arm_read_description)
2757 (arm_read_mprofile_description): Add declaration.
2758 * configure.tgt: Add new files.
2759
afe09f0b
GL
27602019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
2761
2762 * top.c (new_ui_command): Open specified terminal just once.
2763
cd215b2e
TT
27642019-07-18 Tom Tromey <tromey@adacore.com>
2765
2766 * symtab.c (main_name): Constify return type.
2767 * symfile.c (set_initial_language): Update.
2768 * symtab.h (main_name): Constify return type.
2769
d8f68fcb
TT
27702019-07-17 Tom Tromey <tom@tromey.com>
2771
2772 * tui/tui-winsource.c (tui_update_source_window)
2773 (tui_update_source_window_as_is)
2774 (tui_update_source_windows_with_line): Remove return.
2775 * tui/tui-disasm.c (tui_show_disassem)
2776 (tui_show_disassem_and_update_source): Remove return.
2777 * tui/tui.c (tui_reset): Remove return.
2778 * tui/tui-wingeneral.c
2779 (tui_check_and_display_highlight_if_needed): Remove return.
2780
ca5af91e
TT
27812019-07-17 Tom Tromey <tom@tromey.com>
2782
2783 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2784
5104fe36
TT
27852019-07-17 Tom Tromey <tom@tromey.com>
2786
2787 * tui/tui-winsource.h (struct tui_exec_info_window)
2788 (struct tui_source_window_base): Move from tui-data.h.
2789 * tui/tui-winsource.c: Move many method definitions from
2790 elsewhere. Remove "structuring" comments.
2791 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2792 (tui_source_window_base::refresh_window): Move to
2793 tui-winsource.c.
2794 * tui/tui-win.c (tui_source_window_base::refresh_all)
2795 (tui_source_window_base::update_tab_width)
2796 (tui_source_window_base::set_new_height)
2797 (tui_source_window_base::do_make_visible_with_new_height): Move to
2798 tui-winsource.c.
2799 * tui/tui-source.h: Update.
2800 * tui/tui-source.c (tui_source_window_base::reset): Move to
2801 tui-winsource.c.
2802 * tui/tui-disasm.h: Update.
2803 * tui/tui-data.h (struct tui_exec_info_window): Move to
2804 tui-winsource.h.
2805 (struct tui_source_window_base): Likewise.
2806 * tui/tui-data.c (tui_source_window_base::clear_detail)
2807 (tui_source_window_base, ~tui_source_window_base): Move to
2808 tui-winsource.c.
2809
daa15dde
TT
28102019-07-17 Tom Tromey <tom@tromey.com>
2811
2812 * tui/tui-win.c (tui_resize_all)
2813 (tui_source_window_base::update_tab_width)
2814 (tui_adjust_win_heights): Update.
2815 (tui_win_info::make_invisible_and_set_new_height): Rename from
2816 make_invisible_and_set_new_height.
2817 * tui/tui-data.h (struct tui_win_info)
2818 <make_invisible_and_set_new_height>: New method.
2819
bfad4537
TT
28202019-07-17 Tom Tromey <tom@tromey.com>
2821
2822 * tui/tui.c: Update.
2823 * tui/tui-source.h (struct tui_source_window): Move from
2824 tui-data.h.
2825 * tui/tui-layout.c: Update.
2826 * tui/tui-disasm.c: Update.
2827 * tui/tui-data.h (struct tui_source_window): Move to
2828 tui-source.h.
2829
88f7e873
TT
28302019-07-17 Tom Tromey <tom@tromey.com>
2831
2832 * tui/tui-disasm.h (struct tui_disasm_window): Move from
2833 tui-data.h.
2834 * tui/tui-data.h (struct tui_disasm_window): Move to
2835 tui-disasm.h.
2836
96bd6233
TT
28372019-07-17 Tom Tromey <tom@tromey.com>
2838
2839 * tui/tui-regs.h (struct tui_data_item_window): Move from
2840 tui-data.h.
2841 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2842 * tui/tui-data.h (struct tui_data_item_window): Move to
2843 tui-regs.h.
2844 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2845
ce38393b
TT
28462019-07-17 Tom Tromey <tom@tromey.com>
2847
2848 * tui/tui.c: Update.
2849 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2850 (tui_cmd_window::max_height): Move to tui-command.c.
2851 * tui/tui-layout.c: Update.
2852 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2853 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2854 tui-command.c.
2855 * tui/tui-command.h (struct tui_cmd_window): Move from
2856 tui-data.h.
2857 * tui/tui-command.c: Remove "structuring" comments.
2858 (tui_cmd_window::clear_detail)
2859 (tui_cmd_window::do_make_visible_with_new_height)
2860 (tui_cmd_window::max_height): Move from elsewhere.
2861
2d8b51cb
TT
28622019-07-17 Tom Tromey <tom@tromey.com>
2863
2864 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2865 Now static.
2866 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2867 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2868
18ab23af
TT
28692019-07-17 Tom Tromey <tom@tromey.com>
2870
2871 * tui/tui.c: Update.
2872 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2873 tui-regs.c.
2874 * tui/tui-windata.h: Remove file.
2875 * tui/tui-windata.c: Remove file.
2876 * tui/tui-win.c (tui_data_window::set_new_height)
2877 (tui_data_window::do_make_visible_with_new_height): Move to
2878 tui-regs.c.
2879 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2880 * tui/tui-regs.c: Remove "structuring" comments.
2881 (tui_data_window::first_data_item_displayed)
2882 (tui_data_window::delete_data_content_windows)
2883 (tui_data_window::erase_data_content)
2884 (tui_data_window::display_all_data)
2885 (tui_data_window::refresh_all)
2886 (tui_data_window::do_scroll_vertical)
2887 (tui_data_window::clear_detail, tui_data_window::set_new_height)
2888 (tui_data_window::do_make_visible_with_new_height)
2889 (tui_data_window::refresh_window): Move from elsewhere.
2890 (_initialize_tui_regs): Move to end of file.
2891 * tui/tui-layout.c: Update.
2892 * tui/tui-hooks.c: Update.
2893 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2894 * tui/tui-data.c (tui_data_window::clear_detail): Move to
2895 tui-regs.c.
2896 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2897
88b7e7cc
TT
28982019-07-17 Tom Tromey <tom@tromey.com>
2899
2900 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2901 seen.
2902
0fcd3711
TT
29032019-07-17 Tom Tromey <tom@tromey.com>
2904
2905 * tui/tui-win.c (tui_source_window_base::set_new_height)
2906 (tui_source_window_base::do_make_visible_with_new_height): Use
2907 m_has_locator field directly.
2908 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2909 method.
2910 (struct tui_source_window_base) <has_locator>: Likewise.
2911
4a38112d
TT
29122019-07-17 Tom Tromey <tom@tromey.com>
2913
2914 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2915 Don't declare.
2916 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2917 Remove.
2918 * tui/tui-win.c (tui_source_window_base::set_new_height)
2919 (tui_source_window_base::set_new_height)
2920 (make_invisible_and_set_new_height)
2921 (tui_source_window_base::do_make_visible_with_new_height)
2922 (tui_source_window_base::do_make_visible_with_new_height):
2923 Update.
2924 * tui/tui-layout.c (show_source_disasm_command, show_data)
2925 (show_source_or_disasm_and_command): Update.
2926 * tui/tui-layout.c (show_layout): Update.
2927
09129226
TT
29282019-07-17 Tom Tromey <tom@tromey.com>
2929
2930 * tui/tui-layout.c (make_data_window): Remove.
2931 (show_data): Unify creation and re-initialization cases.
2932
4a8a5e84
TT
29332019-07-17 Tom Tromey <tom@tromey.com>
2934
2935 * tui/tui-layout.c (make_source_window, make_disasm_window):
2936 Remove.
2937 (show_data): Unify creation and re-initialization cases.
2938
76d2be8e
TT
29392019-07-17 Tom Tromey <tom@tromey.com>
2940
2941 * tui/tui-layout.c (make_command_window): Remove.
2942 (show_source_disasm_command, show_source_or_disasm_and_command):
2943 Unify creation and re-initialization cases.
2944
890b8bde
TT
29452019-07-17 Tom Tromey <tom@tromey.com>
2946
2947 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2948 creation and re-initialization cases.
2949
2cdfa113
TT
29502019-07-17 Tom Tromey <tom@tromey.com>
2951
2952 * tui/tui-regs.c (tui_get_register): Return void.
2953
8e3cfd09
TT
29542019-07-17 Tom Tromey <tom@tromey.com>
2955
2956 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2957 Simplify.
2958
f4e04977
TT
29592019-07-17 Tom Tromey <tom@tromey.com>
2960
2961 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2962 resetting.
2963
0379b883
TT
29642019-07-17 Tom Tromey <tom@tromey.com>
2965
2966 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2967 * tui/tui-regs.c (tui_reg_layout): New function.
2968 (tui_show_registers, tui_reg_command): Use it.
2969 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2970 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2971 parameters.
2972 (tui_layout_command): Remove.
2973
b7fbad91
TT
29742019-07-17 Tom Tromey <tom@tromey.com>
2975
2976 * tui/tui-layout.h (tui/tui-layout): Return void.
2977 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2978
4e1e56b9
TT
29792019-07-17 Tom Tromey <tom@tromey.com>
2980
2981 * tui/tui-layout.c (show_source_disasm_command, show_data):
2982 Update.
2983 (reset_locator): Remove.
2984 (show_source_or_disasm_and_command): Update.
2985
1e0c09ba
TT
29862019-07-17 Tom Tromey <tom@tromey.com>
2987
2988 * tui/tui-source.c (tui_source_window_base::reset): Remove
2989 win_type parameter.
2990 * tui/tui-layout.c (make_command_window, make_source_window)
2991 (make_disasm_window, make_data_window)
2992 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2993 (reset_locator, show_source_or_disasm_and_command): Update.
2994 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2995 win_type parameter.
2996 (struct tui_source_window_base) <reset>: Likewise.
2997
1bf605de
TT
29982019-07-17 Tom Tromey <tom@tromey.com>
2999
3000 * tui/tui-layout.c (show_source_disasm_command): Use
3001 reset_locator.
3002 (reset_locator): New function.
3003 (init_and_make_win): Remove.
3004 (show_source_or_disasm_and_command): Use reset_locator.
3005
098f9ed4
TT
30062019-07-17 Tom Tromey <tom@tromey.com>
3007
3008 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3009 condition.
3010 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3011 Remove condition.
3012 * tui/tui-source.c (tui_source_window_base::reset): New method.
3013 * tui/tui-layout.c (make_command_window): Don't call
3014 init_and_make_win.
3015 (make_source_window, make_disasm_window): Don't call
3016 make_source_or_disasm_window.
3017 (make_data_window): Don't call init_and_make_win. Change calling
3018 convention.
3019 (show_source_disasm_command, show_data): Simplify.
3020 (make_source_or_disasm_window): Remove.
3021 (show_source_or_disasm_and_command): Simplify.
3022 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3023 (struct tui_source_window_base) <reset>: Likewise.
3024 <execution_info>: Remove initializer.
3025 * tui/tui-data.c (tui_source_window_base): Initialize
3026 execution_info.
3027
80110957
TT
30282019-07-17 Tom Tromey <tom@tromey.com>
3029
3030 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3031 variable.
3032
cf82af05
TT
30332019-07-17 Tom Tromey <tom@tromey.com>
3034
3035 * tui/tui.c (tui_rl_other_window): Update.
3036 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3037 superclass method first. Always iterate over regs_content.
3038 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3039 method.
3040 * tui/tui-win.c (tui_set_focus_command): Update.
3041
01aeb396
TT
30422019-07-17 Tom Tromey <tom@tromey.com>
3043
3044 * tui/tui-win.c (tui_set_focus_command): Rename from
3045 tui_set_focus. Call tui_enable.
3046 (tui_set_focus_command): Remove.
3047
fd6c75ee
TT
30482019-07-17 Tom Tromey <tom@tromey.com>
3049
3050 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3051 refresh_window.
3052 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3053 touchwin.
3054 (tui_data_window::refresh_window): Call refresh_window on data
3055 items. Always call superclass refresh_window.
3056 (tui_win_info::refresh): Remove.
3057 (tui_source_window_base::refresh_window): Update.
3058 (tui_refresh_all): Update.
3059 * tui/tui-layout.c (show_source_disasm_command): Remove call to
3060 refresh_window.
3061 (show_source_or_disasm_and_command): Likewise.
3062 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3063 (struct tui_source_window_base) <refresh>: Likewise.
3064
f6cc34a9
TT
30652019-07-17 Tom Tromey <tom@tromey.com>
3066
3067 * tui/tui-winsource.c (tui_clear_source_content)
3068 (tui_show_source_content): Update.
3069 * tui/tui-source.c (tui_source_window::showing_source_p): Check
3070 whether content is empty.
3071 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3072 Remove.
3073
f31ec9af
TT
30742019-07-17 Tom Tromey <tom@tromey.com>
3075
3076 * tui/tui-winsource.c (tui_erase_source_content): Clear the
3077 window's contents.
3078 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3079 * tui/tui-source.c (tui_set_source_content_nil): Remove.
3080
d1b6f1e5
TT
30812019-07-17 Tom Tromey <tom@tromey.com>
3082
3083 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3084 (struct tui_data_item_window): Update.
3085
d9743a13
TT
30862019-07-17 Tom Tromey <tom@tromey.com>
3087
3088 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3089 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3090 defines.
3091
caf0bc4e
TT
30922019-07-17 Tom Tromey <tom@tromey.com>
3093
3094 * tui/tui-winsource.h (tui_erase_source_content)
3095 (tui_clear_source_content): Remove "display_prompt" parameter.
3096 * tui/tui-winsource.c (tui_update_source_window_as_is)
3097 (tui_update_source_windows_with_addr): Update.
3098 (tui_clear_source_content): Remove "display_prompt" parameter.
3099 (tui_erase_source_content): Likewise. Simplify.
3100 (tui_show_source_content): Update.
3101 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3102 * tui/tui-stack.c (tui_show_frame_info): Update.
3103 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3104 Remove defines.
3105
9d391078
TT
31062019-07-17 Tom Tromey <tom@tromey.com>
3107
3108 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3109 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3110 parameter.
3111 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3112 parameter.
3113
a38da35d
TT
31142019-07-17 Tom Tromey <tom@tromey.com>
3115
3116 * tui/tui-winsource.c (tui_clear_source_content)
3117 (tui_show_source_content, tui_show_exec_info_content)
3118 (tui_clear_exec_info_content): Update.
3119 * tui/tui-stack.c (tui_show_locator_content): Update.
3120 (tui_show_frame_info): Update.
3121 * tui/tui-source.h (tui_source_window): Don't declare.
3122 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3123 from tui_source_is_displayed.
3124 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3125 Remove field.
3126 (struct tui_source_window_base) <content_in_use>: New field. Now
3127 bool.
3128 (struct tui_source_window) <showing_source_p>: New method.
3129 (TUI_SRC_WIN): Change cast.
3130 * tui/tui-data.c (tui_initialize_static_data): Update.
3131
c2cd8994
TT
31322019-07-17 Tom Tromey <tom@tromey.com>
3133
3134 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3135 location_matches_p.
3136 * tui/tui-source.c (tui_source_window::location_matches_p): New
3137 method.
3138 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3139 method.
3140 * tui/tui-data.h (struct tui_source_window_base)
3141 <location_matches_p>: New method.
3142 (struct tui_source_window, struct tui_disasm_window)
3143 <location_matches_p>: Likewise.
3144
4dde7b34
TT
31452019-07-17 Tom Tromey <tom@tromey.com>
3146
3147 * tui/tui-win.c (tui_set_win_height_command): Rename from
3148 tui_set_win_height.
3149 (tui_set_win_height_command): Remove.
3150
b73dd877
TT
31512019-07-17 Tom Tromey <tom@tromey.com>
3152
3153 * tui/tui-source.c (tui_source_window): New constructor. Add
3154 observer.
3155 (~tui_source_window): New destructor.
3156 (tui_source_window::style_changed): New method.
3157 * tui/tui-hooks.c (tui_redisplay_source): Remove.
3158 (tui_attach_detach_observers): Update.
3159 * tui/tui-data.h (struct tui_source_window): Make constructor not
3160 inline. Add destructor.
3161 (struct tui_source_window) <style_changed>: New method.
3162 <m_observable>: New member.
3163
ae2b5380
TT
31642019-07-17 Tom Tromey <tom@tromey.com>
3165
3166 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3167 * tui/tui-win.c (tui_resize_all): Fix typo.
3168
1ce3e844
TT
31692019-07-17 Tom Tromey <tom@tromey.com>
3170
3171 * tui/tui-wingeneral.h (tui_refresh_all): Update.
3172 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3173 (tui_refresh_all): Remove "list" parameter. Use foreach.
3174 * tui/tui-win.c (window_name_completer): Use foreach.
3175 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3176 (update_tab_width): Likewise.
3177 * tui/tui-layout.c (show_layout): Update.
3178 * tui/tui-data.h (class tui_window_iterator): New.
3179 (struct all_tui_windows): New.
3180 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3181
fe3eaf1c
TT
31822019-07-17 Tom Tromey <tom@tromey.com>
3183
3184 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3185 parameter. Don't reference globals.
3186 (tui_reg_command): Update.
3187
368c1354
TT
31882019-07-17 Tom Tromey <tom@tromey.com>
3189
3190 * tui/tui-regs.c (tui_show_registers): Simplify.
3191
e80cd204
TT
31922019-07-17 Tom Tromey <tom@tromey.com>
3193
3194 * tui/tui-regs.c (tui_show_registers): Update.
3195 (tui_show_register_group): Add win_info parameter.
3196
aca2dd16
TT
31972019-07-17 Tom Tromey <tom@tromey.com>
3198
3199 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3200 Rename from tui_display_reg_element_at_line.
3201 (tui_data_window::display_registers_from_line): Update.
3202 * tui/tui-data.h (struct tui_data_window)
3203 <display_reg_element_at_line>: New method.
3204
517e9505
TT
32052019-07-17 Tom Tromey <tom@tromey.com>
3206
3207 * tui/tui-regs.h (tui_display_registers_from)
3208 (tui_display_registers_from_line): Don't declare.
3209 * tui/tui-windata.c (tui_data_window::display_all_data)
3210 (tui_data_window::refresh_all)
3211 (tui_data_window::do_scroll_vertical): Update.
3212 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3213 from tui_display_registers_from.
3214 (tui_display_reg_element_at_line): Update.
3215 (tui_data_window::display_registers_from_line): Rename from
3216 tui_display_registers_from_line.
3217 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3218 display_registers_from_line>: New methods.
3219
f76d8b19
TT
32202019-07-17 Tom Tromey <tom@tromey.com>
3221
3222 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3223 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3224 from tui_erase_data_content.
3225 (tui_data_window::display_all_data)
3226 (tui_data_window::refresh_all)
3227 (tui_data_window::do_scroll_vertical): Update.
3228 * tui/tui-regs.c (tui_show_registers): Update.
3229 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3230 New method.
3231
b4094625
TT
32322019-07-17 Tom Tromey <tom@tromey.com>
3233
3234 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3235 declare.
3236 * tui/tui-windata.c
3237 (tui_data_window::delete_data_content_windows): Rename from
3238 tui_delete_data_content_windows.
3239 (tui_data_window::display_all_data)
3240 (tui_data_window::do_scroll_vertical): Update.
3241 * tui/tui-data.h (struct tui_data_window)
3242 <delete_data_content_windows>: New method.
3243
c223a729
TT
32442019-07-17 Tom Tromey <tom@tromey.com>
3245
3246 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3247 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3248
50daf268
TT
32492019-07-17 Tom Tromey <tom@tromey.com>
3250
3251 * tui/tui-windata.h (tui_display_all_data): Don't declare.
3252 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3253 from tui_display_all_data.
3254 * tui/tui-win.c
3255 (tui_data_window::do_make_visible_with_new_height): Update.
3256 * tui/tui-regs.c (tui_show_registers): Update.
3257 * tui/tui-layout.c (tui_set_layout): Update.
3258 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3259 method.
3260
df5f8cab
TT
32612019-07-17 Tom Tromey <tom@tromey.com>
3262
3263 * tui/tui-windata.h (tui_display_data_from): Don't declare.
3264 * tui/tui-windata.c (tui_display_data_from): Remove.
3265 (tui_data_window::refresh_all): Update.
3266
80cb6c27
TT
32672019-07-17 Tom Tromey <tom@tromey.com>
3268
3269 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3270 * tui/tui-windata.c (tui_display_data_from_line): Remove.
3271 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3272 tui_display_registers_from_line.
3273 * tui/tui-regs.h (tui_display_registers_from_line): Update.
3274 * tui/tui-regs.c (tui_display_registers_from_line): Remove
3275 "force_display" parameter.
3276
baff0c28
TT
32772019-07-17 Tom Tromey <tom@tromey.com>
3278
3279 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3280 declare.
3281 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3282 Rename from tui_first_reg_element_no_inline.
3283 (tui_display_reg_element_at_line)
3284 (tui_display_registers_from_line): Update.
3285 * tui/tui-data.h (struct tui_data_window)
3286 <first_reg_element_no_inline>: New method.
3287
3b23c5f2
TT
32882019-07-17 Tom Tromey <tom@tromey.com>
3289
3290 * tui/tui-windata.c (tui_display_data_from)
3291 (tui_data_window::do_scroll_vertical): Update.
3292 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3293 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3294 Rename from tui_line_from_reg_element_no.
3295 (tui_display_registers_from_line): Update.
3296 * tui/tui-data.h (struct tui_data_window)
3297 <line_from_reg_element_no>: New method.
3298
0b5ec218
TT
32992019-07-17 Tom Tromey <tom@tromey.com>
3300
3301 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3302 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3303 tui_last_regs_line_no.
3304 (tui_display_reg_element_at_line)
3305 (tui_display_registers_from_line): Update.
3306 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3307 method.
3308
0807ab7b
TT
33092019-07-17 Tom Tromey <tom@tromey.com>
3310
3311 PR tui/24722:
3312 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3313 (tui_update_breakpoint_info): Add "being_deleted" parameter.
3314 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3315 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3316 (tui_update_breakpoint_info): Likewise.
3317 * tui/tui-hooks.c (tui_event_create_breakpoint)
3318 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3319 Update.
3320
9ad7fdef
TT
33212019-07-17 Tom Tromey <tom@tromey.com>
3322
3323 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3324
5813316f
TT
33252019-07-17 Tom Tromey <tom@tromey.com>
3326
3327 * tui/tui-winsource.c (tui_update_source_window_as_is)
3328 (tui_update_source_windows_with_addr): Update.
3329 * tui/tui-source.h (tui_set_source_content)
3330 (tui_show_symtab_source): Add "win_info" parameter.
3331 * tui/tui-source.c (tui_set_source_content): Add "win_info"
3332 parameter.
3333 (tui_show_symtab_source): Likewise.
3334
00e264e7
TT
33352019-07-17 Tom Tromey <tom@tromey.com>
3336
3337 * tui/tui-wingeneral.c
3338 (tui_check_and_display_highlight_if_needed): Check can_highlight.
3339
06210ce4
TT
33402019-07-17 Tom Tromey <tom@tromey.com>
3341
3342 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3343 (struct tui_cmd_window) <can_scroll>: New method.
3344 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3345 method.
3346
381befee
TT
33472019-07-17 Tom Tromey <tromey@adacore.com>
3348
3349 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3350 do_field_signed>: Rename. Change type of "value".
3351 * ui-out.c (ui_out::field_signed): Rename from field_int.
3352 Change type of "value".
3353 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3354 type of "value".
3355 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3356 do_field_int. Change type of "value".
3357 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3358 do_field_int. Change type of "value".
3359 * tracepoint.c (trace_status_mi, tfind_1)
3360 (print_one_static_tracepoint_marker): Update.
3361 * thread.c (print_thread_info_1, print_selected_thread_frame):
3362 Update.
3363 * stack.c (print_frame, print_frame_info): Update.
3364 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3365 Update.
3366 * source.c (print_source_lines_base): Update.
3367 * skip.c (info_skip_command): Update.
3368 * record-btrace.c (btrace_ui_out_decode_error)
3369 (btrace_call_history_src_line): Update.
3370 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3371 Update.
3372 * progspace.c (print_program_space): Update.
3373 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3374 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3375 do_field_int. Change type of "value".
3376 * mi/mi-out.c (mi_ui_out::do_table_begin)
3377 (mi_ui_out::do_table_header): Update.
3378 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3379 type of "value".
3380 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3381 (mi_cmd_data_list_changed_registers, output_register)
3382 (mi_cmd_data_read_memory, mi_load_progress)
3383 (mi_cmd_trace_frame_collected): Update.
3384 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3385 Update.
3386 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3387 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3388 (mi_cmd_var_list_children, varobj_update_one): Update.
3389 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3390 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3391 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3392 * inferior.c (print_inferior): Update.
3393 * gdb_bfd.c (print_one_bfd): Update.
3394 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3395 Update.
3396 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3397 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3398 do_field_int. Change type of "value".
3399 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3400 do_field_int. Change type of "value".
3401 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3402 (print_one_breakpoint_location, print_it_catch_fork)
3403 (print_one_catch_fork, print_it_catch_vfork)
3404 (print_one_catch_vfork, print_it_catch_solib)
3405 (print_it_catch_exec, print_it_ranged_breakpoint)
3406 (print_mention_watchpoint, print_mention_masked_watchpoint)
3407 (bkpt_print_it, update_static_tracepoint): Update.
3408 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3409 * break-catch-syscall.c (print_it_catch_syscall): Update.
3410 * ada-tasks.c (print_ada_task_info): Update.
3411 * ada-lang.c (print_it_exception, print_mention_exception):
3412 Update.
3413
6b78c3f8
AB
34142019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3415
3416 PR breakpoints/24541
3417 * gdbarch.c: Regenerate.
3418 * gdbarch.h: Regenerate.
3419 * gdbarch.sh: Adjust return type and parameter types for
3420 'stap_adjust_register'.
3421 (i386_stap_adjust_register): Adjust signature and return new
3422 register name.
3423 * stap-probe.c (stap_parse_register_operand): Adjust use of
3424 'gdbarch_stap_adjust_register'.
3425
d72a9b85
TT
34262019-07-17 Tom Tromey <tromey@adacore.com>
3427
3428 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3429 declare VEC.
3430 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3431 std::vector.
3432 (struct s390_process_info): Add initializers.
3433 (s390_add_process): Use new.
3434 (s390_linux_nat_target::low_forget_process): Use delete.
3435 (s390_linux_nat_target::low_new_fork)
3436 (s390_linux_nat_target::stopped_by_watchpoint)
3437 (s390_linux_nat_target::low_prepare_to_resume)
3438 (s390_linux_nat_target::insert_watchpoint)
3439 (s390_linux_nat_target::insert_hw_breakpoint)
3440 (s390_linux_nat_target::remove_watchpoint)
3441 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3442
206e6c58
JB
34432019-07-16 John Baldwin <jhb@FreeBSD.org>
3444
3445 * aarch64-fbsd-nat.c: Include regcache.h.
3446 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3447 argument.
3448 (aarch64_fbsd_nat_target::fetch_registers)
3449 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3450 variable.
3451 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3452
cbde90f2
JB
34532019-07-16 John Baldwin <jhb@FreeBSD.org>
3454
3455 * fbsd-nat.c: Include gdbarch.h.
3456
07128006
TT
34572019-07-15 Tom Tromey <tromey@adacore.com>
3458
3459 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3460
1f77b012
TT
34612019-07-15 Tom Tromey <tromey@adacore.com>
3462
3463 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3464 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3465 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3466 * cli-out.c (cli_ui_out::do_field_int): New method.
3467 * ui-out.c (ui_out::field_unsigned): New method.
3468 * symfile.c (generic_load): Use field_unsigned.
3469 (print_transfer_performance): Likewise.
3470 * record-btrace.c (ui_out_field_uint): Remove.
3471 (btrace_call_history_insn_range, btrace_call_history): Use
3472 field_unsigned.
3473 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3474 field_unsigned.
3475 * ui-out.h (class ui_out) <field_unsigned>: New method.
3476 <do_field_unsigned>: Likewise.
3477
33eca680
TT
34782019-07-15 Tom Tromey <tromey@adacore.com>
3479
3480 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3481 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3482 * target.c (flash_erase_command): Use field_string.
3483 * infrun.c (print_signal_received_reason): Use field_string.
3484 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3485 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3486 field_string.
3487 * ada-tasks.c (print_ada_task_info): Use field_string.
3488
ca8d69be
TT
34892019-07-15 Tom Tromey <tromey@adacore.com>
3490
3491 * target.c (flash_erase_command): Use field_core_addr.
3492 * symfile.c (generic_load): Use field_core_addr.
3493 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3494 Use field_core_addr.
3495 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3496 field_core_addr.
3497
0d4e84ed
AB
34982019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3499
3500 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3501 value if its desired type is smaller than a CORE_ADDR and signed.
3502
9a49df9d
AB
35032019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3504
3505 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3506 of changes to field names, and use new is_reference field to
3507 decide if a property is a reference or not.
3508 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3509 field.
3510 (struct dwarf2_property_baton): Update header comment, rename
3511 'referenced_type' to 'property_type' and update comments.
3512 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3513 default property type, store in property baton, update to take
3514 accound of renamed field.
3515 (read_func_scope): Update call to attr_to_dynamic_prop.
3516 (read_array_type): Likewise.
3517 (dwarf2_per_cu_addr_sized_int_type): New function.
3518 (read_subrange_index_type): Move type finding code to
3519 dwarf2_per_cu_addr_sized_int_type.
3520 (read_subrange_type): Update calls to attr_to_dynamic_prop.
3521 (dwarf2_per_cu_addr_type): New function.
3522 (set_die_type): Update calls to attr_to_dynamic_prop.
3523
b86352cf
AB
35242019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3525
3526 * dwarf2read.c (read_subrange_index_type): New function.
3527 (read_subrange_type): Move code into new function and call it.
3528 * gdbtypes.c (create_range_type): Add some asserts.
3529
603490bf
AB
35302019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3531
3532 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3533 update return statements.
3534 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3535 declaration, and update comment to match.
3536 * gdbtypes.c (resolve_dynamic_array): Update call to
3537 dwarf2_evaluate_property to match new return type.
3538
592f9d27
AB
35392019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3540
3541 * valarith.c (value_subscripted_rvalue): Change lowerbound
3542 parameter type from int to LONGEST.
3543 * value.h (value_subscripted_rvalue): Likewise in declaration.
3544
60cfcb20
AB
35452019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3546
3547 * cli/cli-utils.c (info_print_command_completer): New function.
3548 * cli/cli-utils.h: Add 'completer.h' include, and forward
3549 declaration for 'struct cmd_list_element'.
3550 (info_print_command_completer): Declare.
3551 * stack.c (_initialize_stack): Add completer for 'info locals' and
3552 'info args'.
3553 * symtab.c (_initialize_symtab): Add completer for 'info
3554 variables' and 'info functions'.
3555 * NEWS: Mention completion for additional info commands.
3556
b16507e0
AB
35572019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3558
3559 * cli/cli-utils.c (extract_info_print_args): Delete.
3560 (extract_arg_maybe_quoted): Delete.
3561 (info_print_options_defs): New variable.
3562 (make_info_print_options_def_group): New function.
3563 (extract_info_print_options): Define new function.
3564 * cli/cli-utils.h (extract_info_print_args): Delete.
3565 (struct info_print_options): New structure.
3566 (extract_info_print_options): Declare new function.
3567 * stack.c (info_locals_command): Update to use new
3568 extract_info_print_options, also add a header comment.
3569 (info_args_command): Likewise.
3570 * symtab.c (info_variables_command): Likewise.
3571 (info_functions_command): Likewise.
3572
021d8588
AB
35732019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3574
3575 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3576 to extract string arguments.
3577 * common/common-utils.c (extract_string_maybe_quoted): New function.
3578 * common/common-utils.h (extract_string_maybe_quoted): Declare.
3579
b777eb6d
TT
35802019-07-11 Tom Tromey <tromey@adacore.com>
3581
3582 * main.c (get_init_files): Use GDBINIT, not gdbinit.
3583 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3584 * top.h (gdbinit): Don't declare.
3585 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3586 into...
3587 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
3588 * top.c (gdb_init): Don't call init_cli_cmds.
3589 (gdbinit): Remove.
3590 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3591
72ee03ff
TT
35922019-07-11 Tom Tromey <tromey@adacore.com>
3593
3594 * python/py-inferior.c (add_thread_object): Don't use thread_obj
3595 after it has been moved.
3596
00db9531
SM
35972019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3598
3599 * valops.c (value_must_coerce_to_target): Change return type to
3600 bool.
3601 * value.h (value_must_coerce_to_target): Likewise.
3602
f2478a7e
SM
36032019-07-10 Simon Marchi <simon.marchi@efficios.com>
3604
3605 * breakpoint.c (is_hardware_watchpoint): Remove
3606 forward-declaration.
3607 (is_masked_watchpoint): Change return type to bool.
3608 (is_tracepoint): Likewise.
3609 (is_breakpoint): Likewise.
3610 (is_hardware_watchpoint): Likewise.
3611 (is_watchpoint): Likewise.
3612 (is_no_memory_software_watchpoint): Likewise.
3613 (is_catchpoint): Likewise.
3614 (breakpoint_1): Make FILTER parameter's return type bool.
3615 is_masked_watchpoint): Change return type to bool.
3616 (save_breakpoints): Make FILTER parameter's return type bool.
3617 * breakpoint.h (is_breakpoint): Change return type to bool.
3618 (is_watchpoint): Likewise.
3619 (is_catchpoint): Likewise.
3620 (is_tracepoint): Likewise.
3621
0d12e84c
TT
36222019-07-10 Tom Tromey <tom@tromey.com>
3623
3624 * defs.h: Don't include gdbarch.h.
3625 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3626 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3627 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3628 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3629 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3630 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3631 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3632 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3633 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3634 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3635 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3636 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3637 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3638 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3639 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3640 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3641 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3642 record-btrace.c, record.h, regcache-dump.c, regcache.h,
3643 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3644 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3645 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3646 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3647 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3648 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3649 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3650 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3651 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3652
f06f1252
TT
36532019-07-10 Tom Tromey <tromey@adacore.com>
3654
3655 * ada-lang.h (is_ada_exception_catchpoint): Declare.
3656 * breakpoint.c (init_ada_exception_breakpoint): Register as
3657 bp_catchpoint.
3658 (print_one_breakpoint_location, print_one_breakpoint): Use
3659 is_ada_exception_catchpoint.
3660 * ada-lang.c (class ada_catchpoint_location): Pass
3661 bp_loc_software_breakpoint to bp_location constructor.
3662 (is_ada_exception_catchpoint): New function.
3663
7a5d944b
TT
36642019-07-10 Tom Tromey <tromey@adacore.com>
3665
3666 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
3667 VEC.
3668 (struct arm_exidx_entry): New method operator<.
3669 (struct arm_exidx_data) <section_maps>: Change type.
3670 (arm_exidx_data_free): Remove.
3671 (arm_exidx_data_key): Change type. Move lower.
3672 (arm_exidx_new_objfile): Update.
3673 (arm_compare_exidx_entries): Remove.
3674 (arm_find_exidx_entry, _initialize_arm_tdep)
3675
48c66e1d
TT
36762019-07-10 Tom Tromey <tromey@adacore.com>
3677
3678 * solib-spu.c (ocl_program_data_key): Change type.
3679 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3680 Update.
3681
a269fbf1
TT
36822019-07-10 Tom Tromey <tromey@adacore.com>
3683
3684 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
3685 (struct solib_aix_inferior_data) <library_list>: Change type.
3686 (solib_aix_inferior_data_handle): Change type.
3687 (get_solib_aix_inferior_data): Update.
3688 (solib_aix_free_library_list): Remove.
3689 (library_list_start_library): Update.
3690 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3691 return type.
3692 (solib_aix_get_library_list)
3693 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3694 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3695
c294730c
TT
36962019-07-10 Tom Tromey <tromey@adacore.com>
3697
3698 * solib-dsbt.c (struct dsbt_info): Add initializers.
3699 (solib_dsbt_pspace_data): Change type.
3700 (dsbt_pspace_data_cleanup): Remove.
3701 (get_dsbt_info, _initialize_dsbt_solib): Update.
3702
9d52077d
TT
37032019-07-10 Tom Tromey <tromey@adacore.com>
3704
3705 * spu-tdep.c (spu_overlay_data): Change type.
3706 (spu_get_overlay_table, spu_overlay_new_objfile)
3707 (_initialize_spu_tdep): Update.
3708
22a20dca
TT
37092019-07-10 Tom Tromey <tromey@adacore.com>
3710
3711 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3712 destructor.
3713 (dbx_objfile_data_key): Change type and declare later.
3714 (DBX_SYMFILE_INFO): Rewrite.
3715 * dbxread.c (dbx_objfile_data_key): Change type.
3716 (dbx_symfile_init): Update.
3717 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
3718 (coffstab_build_psymtabs, elfstab_build_psymtabs)
3719 (stabsect_build_psymtabs, _initialize_dbxread): Update.
3720
cb60f420
TT
37212019-07-10 Tom Tromey <tromey@adacore.com>
3722
3723 * jit.c (jit_program_space_key): Change type. Move lower.
3724 (get_jit_program_space_data): Update.
3725 (jit_program_space_data_cleanup): Remove.
3726 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3727 Update.
3728 (struct jit_program_space_data): Add initializers.
3729
51df2ae3
TT
37302019-07-10 Tom Tromey <tromey@adacore.com>
3731
3732 * solib-darwin.c (struct darwin_info): Add initializers.
3733 (solib_darwin_pspace_data): Change type.
3734 (darwin_pspace_data_cleanup): Remove.
3735 (get_darwin_info, _initialize_darwin_solib): Update.
3736
18101a35
TT
37372019-07-10 Tom Tromey <tromey@adacore.com>
3738
3739 * remote-sim.c (struct sim_inferior_data): Add initializers,
3740 constructor, and destructor.
3741 (sim_inferior_data_key): Change type. Move lower.
3742 (check_for_duplicate_sim_descriptor): Update.
3743 (get_sim_inferior_data): Use new. Update.
3744 (~sim_inferior_data_cleanup): Rename from
3745 sim_inferior_data_cleanup. Simplify.
3746 (gdbsim_close_inferior, simulator_command)
3747 (sim_command_completer, _initialize_remote_sim): Update.
3748 (next_pid, INITIAL_PID): Move earlier.
3749
05b08ac1
TT
37502019-07-10 Tom Tromey <tromey@adacore.com>
3751
3752 * python/python-internal.h (create_thread_object): Return
3753 gdbpy_ref.
3754 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3755 * python/py-inferior.c (struct threadlist_entry): Add
3756 constructor.
3757 <thread_obj>: Now a gdbpy_ref.
3758 (thread_to_thread_object): Update.
3759 (add_thread_object): Use new.
3760 (delete_thread_object): Use delete.
3761 (infpy_threads): Update.
3762 (py_free_inferior): Update. Construct "inf_obj" after acquiring
3763 GIL.
3764
32372d80
TT
37652019-07-10 Tom Tromey <tromey@adacore.com>
3766
3767 * valops.c (value_cast): Specialize error message for Ada.
3768
5c458ae8
SM
37692019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3770
3771 * breakpoint.c (breakpoint_1): Update doc and parameter names.
3772
4c462cb0
SM
37732019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3774
3775 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3776 bpstat_should_step): Return bool, adjust comments.
3777 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3778 bpstat_should_step): Likewise.
3779
89abbcc2
AH
37802019-07-10 Alan Hayward <alan.hayward@arm.com>
3781
3782 * features/Makefile: Use feature target descriptions for Arm.
3783 * features/arm/arm-core.c: Generate new file.
3784 * features/arm/arm-fpa.c: Likewise.
3785 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3786 * features/arm/arm-m-profile.c: Likewise.
3787 * features/arm/arm-vfpv2.c: Likewise.
3788 * features/arm/arm-vfpv3.c: Likewise.
3789 * features/arm/xscale-iwmmxt.c: Likewise.
3790 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3791
166a82be
AH
37922019-07-10 Alan Hayward <alan.hayward@arm.com>
3793
3794 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3795 ptrace earlier.
3796
9fb4c7e9
AH
37972019-07-10 Alan Hayward <alan.hayward@arm.com>
3798
3799 * features/aarch64-pauth.c: Regenerate.
3800
e2d0f980
SM
38012019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
3802
3803 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3804 bool.
3805 (bpstat_what): Use false instead of 0.
3806
a38118e5
PA
38072019-07-09 Pedro Alves <palves@redhat.com>
3808
3809 * break-catch-throw.c (is_exception_catchpoint): New.
3810 * breakpoint.c (print_one_breakpoint_location): New parameter
3811 'raw_loc'. Handle it. Use
3812 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3813 looking at the breakpoint's type.
3814 (print_one_breakpoint): If handling "maint info breakpoints", also
3815 print locations of exception catchpoints.
3816 * breakpoint.h (is_exception_catchpoint): Declare.
3817
cb1e4e32
PA
38182019-07-09 Pedro Alves <palves@redhat.com>
3819
3820 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3821 "addr" field.
3822 (allocate_location_exception_catchpoint): New.
3823 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3824 (initialize_throw_catchpoint_ops): Install
3825 allocate_location_exception_catchpoint as allocate_location
3826 method.
3827 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3828 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3829 bp_loc_other.
3830 (breakpoint_address_is_meaningful): Delete.
3831 (bl_address_is_meaningful): New.
3832 (breakpoint_locations_match): Adjust comment.
3833 (bp_location_from_bp_type): New, factored out of...
3834 (bp_location::bp_location(breakpoint *)): ... this.
3835 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3836 factored out of...
3837 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
3838 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3839 breakpoint_address_is_meaningful.
3840 (bp_locations_compare): Adjust comment.
3841 (update_global_location_list): Use bl_address_is_meaningful
3842 instead of breakpoint_address_is_meaningful.
3843 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3844 explicit.
3845 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3846 * python/py-breakpoint.c (bppy_get_location): No longer check
3847 whether location is null.
3848
b58a68fe
PA
38492019-07-09 Pedro Alves <palves@redhat.com>
3850
3851 PR c++/15468
3852 * breakpoint.c (print_one_breakpoint_location): Remove
3853 single-location assert.
3854
268a13a5
TT
38552019-07-09 Tom Tromey <tom@tromey.com>
3856
3857 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3858 * configure: Rebuild.
3859 * configure.ac: Change common to gdbsupport.
3860 * gdbsupport: Rename from common.
3861 * acinclude.m4: Change common to gdbsupport.
3862 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3863 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3864 gdbsupport.
3865 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3866 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3867 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3868 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3869 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3870 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3871 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3872 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3873 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3874 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3875 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3876 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3877 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3878 coff-pe-read.c, command.h, compile/compile-c-support.c,
3879 compile/compile-c.h, compile/compile-cplus-symbols.c,
3880 compile/compile-cplus-types.c, compile/compile-cplus.h,
3881 compile/compile-loc2c.c, compile/compile.c, completer.c,
3882 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3883 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3884 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3885 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3886 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3887 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3888 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3889 features/aarch64-core.c, features/aarch64-fpu.c,
3890 features/aarch64-pauth.c, features/aarch64-sve.c,
3891 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3892 features/i386/32bit-core.c, features/i386/32bit-linux.c,
3893 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3894 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3895 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3896 features/i386/64bit-core.c, features/i386/64bit-linux.c,
3897 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3898 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3899 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3900 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3901 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3902 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3903 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3904 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3905 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3906 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3907 go32-nat.c, guile/guile.c, guile/scm-ports.c,
3908 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3909 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3910 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3911 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3912 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3913 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3914 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3915 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3916 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3917 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3918 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3919 minsyms.c, mips-linux-tdep.c, namespace.h,
3920 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3921 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3922 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3923 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3924 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3925 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3926 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3927 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3928 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3929 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3930 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3931 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3932 procfs.c, producer.c, progspace.h, psymtab.h,
3933 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3934 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3935 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3936 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3937 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3938 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3939 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3940 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3941 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3942 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3943 target-memory.c, target.c, target.h, target/waitstatus.c,
3944 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3945 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3946 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3947 unittests/array-view-selftests.c,
3948 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3949 unittests/common-utils-selftests.c,
3950 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3951 unittests/format_pieces-selftests.c,
3952 unittests/function-view-selftests.c,
3953 unittests/lookup_name_info-selftests.c,
3954 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3955 unittests/mkdir-recursive-selftests.c,
3956 unittests/observable-selftests.c,
3957 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3958 unittests/parse-connection-spec-selftests.c,
3959 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3960 unittests/scoped_fd-selftests.c,
3961 unittests/scoped_mmap-selftests.c,
3962 unittests/scoped_restore-selftests.c,
3963 unittests/string_view-selftests.c, unittests/style-selftests.c,
3964 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3965 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3966 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3967 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3968 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3969 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3970
5b0e2db4
AB
39712019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3972
3973 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3974 bool value.
3975 (decode_digits_ordinary): Set explicit_line field in sal.
3976 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3977 symtab_and_line that was set on an explicit line number in
3978 assembler code. Do always update the recorded symtab and line if
3979 we do skip the prologue.
3980
0ba852ab
AB
39812019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3982
3983 * breakpoint.c (set_breakpoint_location_function): Remove
3984 explicit_loc parameter.
3985 (momentary_breakpoint_from_master): Update call to
3986 set_breakpoint_location_function.
3987 (add_location_to_breakpoint): Likewise.
3988
b3a7d171
AB
39892019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3990
3991 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3992 required features based on default bfd type when no specific bfd
3993 is present.
3994
1f6f6e21
PW
39952019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3996
3997 * NEWS: Mention that GDB printf and eval commands can now print
3998 C-style and Ada-style convenience var strings without
3999 calling the inferior.
4000 * printcmd.c (printf_c_string): Locally print GDB internal var
4001 instead of transiting via the inferior.
4002 (printf_wide_c_string): Likewise.
4003
40042019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
4005
4006 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4007
0598af48
TT
40082019-07-04 Tom Tromey <tom@tromey.com>
4009
4010 PR tui/24724:
4011 * tui/tui-winsource.c (tui_clear_source_content): Update.
4012 (tui_source_window_base::set_is_exec_point_at): Fix comment.
4013 (tui_update_breakpoint_info): Update.
4014 (tui_set_exec_info_content): Update.
4015 * tui/tui-source.c (tui_set_source_content_nil): Update.
4016 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4017 has_break.
4018 * tui/tui-data.h (enum tui_bp_flag): New.
4019 (tui_bp_flags): New enum flags type.
4020 (struct tui_source_element) <break_mode>: Change type. Rename
4021 from has_break.
4022 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4023 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
4024 constants.
4025 * tui/tui-winsource.h: Fix comment.
4026
350fab54
AH
40272019-07-04 Alan Hayward <alan.hayward@arm.com>
4028
4029 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4030 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4031 (store_fpregs_to_thread)
4032 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4033 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4034 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4035 (IWMMXT_REGS_SIZE): Add define.
4036 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4037 (fetch_vfp_regs, store_vfp_regs)
4038 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4039 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4040
f0452268
AH
40412019-07-04 Alan Hayward <alan.hayward@arm.com>
4042
4043 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4044 defines.
4045 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4046 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4047 (ARM_INT_REGISTER_SIZE): ...to this.
4048 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4049 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4050 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4051 (arm_linux_collect_gregset, supply_nwfpe_register)
4052 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4053 defines.
4054 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4055 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4056 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4057 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4058 (arm_return_in_memory, arm_store_return_value)
4059 (arm_get_longjmp_target, arm_register_g_packet_guesses)
4060 (arm_record_ld_st_multiple): Likewise.
4061 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4062 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4063
e935475c
AH
40642019-07-04 Alan Hayward <alan.hayward@arm.com>
4065
4066 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4067 AARCH64_DISPLACED_MODIFIED_INSNS.
4068 * aarch64-tdep.c (struct aarch64_displaced_step_data)
4069 (aarch64_displaced_step_copy_insn): Likewise.
4070 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4071 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4072 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4073 ARM_DISPLACED_MODIFIED_INSNS.
4074 * arm-tdep.c (arm_gdbarch_init): Likewise.
4075 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4076 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4077 (struct arm_displaced_step_closure): Use
4078 ARM_DISPLACED_MODIFIED_INSNS.
4079
df0bb381
AH
40802019-07-04 Alan Hayward <alan.hayward@arm.com>
4081
4082 * features/Makefile: Remove unused xml files.
4083 * features/aarch64.xml: Remove.
4084 * features/i386/amd64-avx-avx512-linux.xml: Remove.
4085 * features/i386/amd64-avx-avx512.xml: Remove.
4086 * features/i386/amd64-avx-linux.xml: Remove.
4087 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4088 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4089 * features/i386/amd64-avx-mpx-linux.xml: Remove.
4090 * features/i386/amd64-avx-mpx.xml: Remove.
4091 * features/i386/amd64-avx.xml: Remove.
4092 * features/i386/amd64-linux.xml: Remove.
4093 * features/i386/amd64-mpx-linux.xml: Remove.
4094 * features/i386/amd64-mpx.xml: Remove.
4095 * features/i386/amd64.xml: Remove.
4096 * features/i386/i386-avx-avx512-linux.xml: Remove.
4097 * features/i386/i386-avx-avx512.xml: Remove.
4098 * features/i386/i386-avx-linux.xml: Remove.
4099 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4100 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4101 * features/i386/i386-avx-mpx-linux.xml: Remove.
4102 * features/i386/i386-avx-mpx.xml: Remove.
4103 * features/i386/i386-avx.xml: Remove.
4104 * features/i386/i386-linux.xml: Remove.
4105 * features/i386/i386-mmx-linux.xml: Remove.
4106 * features/i386/i386-mmx.xml: Remove.
4107 * features/i386/i386-mpx-linux.xml: Remove.
4108 * features/i386/i386-mpx.xml: Remove.
4109 * features/i386/i386.xml: Remove.
4110 * features/i386/x32-avx-avx512-linux.xml: Remove.
4111 * features/i386/x32-avx-linux.xml: Remove.
4112 * features/i386/x32-linux.xml: Remove.
4113
edd6266a
AH
41142019-07-04 Alan Hayward <alan.hayward@arm.com>
4115
4116 * regformats/aarch64.dat: Remove.
4117 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4118 * regformats/i386/amd64-avx-linux.dat: Remove.
4119 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4120 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4121 * regformats/i386/amd64-linux.dat: Remove.
4122 * regformats/i386/amd64-mpx-linux.dat: Remove.
4123 * regformats/i386/amd64.dat: Remove.
4124 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4125 * regformats/i386/i386-avx-linux.dat: Remove.
4126 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4127 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4128 * regformats/i386/i386-linux.dat: Remove.
4129 * regformats/i386/i386-mmx-linux.dat: Remove.
4130 * regformats/i386/i386-mpx-linux.dat: Remove.
4131 * regformats/i386/i386.dat: Remove.
4132 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4133 * regformats/i386/x32-avx-linux.dat: Remove.
4134 * regformats/i386/x32-linux.dat: Remove.
4135
2b40fda7
AH
41362019-07-04 Alan Hayward <alan.hayward@arm.com>
4137
4138 * aarch64-tdep.c: Remove xml self tests.
4139 * amd64-linux-tdep.c: Likewise.
4140 * amd64-tdep.c: Likewise.
4141 * i386-linux-tdep.c: Likewise.
4142 * i386-tdep.c: Likewise.
4143
5f4ba3e7
PA
41442019-07-03 Pedro Alves <palves@redhat.com>
4145
4146 PR cli/24732
4147 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4148 (pipe_cmd_option_defs): New.
4149 (make_pipe_cmd_options_def_group): New.
4150 (pipe_command): Use gdb::option::process_options.
4151 (pipe_command_completer): New function.
4152 (_initialize_cli_cmds): Install completer for "pipe" command.
4153
3d9be6f5
PA
41542019-07-03 Pedro Alves <palves@redhat.com>
4155
4156 * cli/cli-option.c (union option_value) <string>: New field.
4157 (struct option_def_and_value): Add ctor, move ctor, dtor and
4158 use DISABLE_COPY_AND_ASSIGN.
4159 (option_def_and_value::clear_value): New.
4160 (parse_option, save_option_value_in_ctx, get_val_type_str)
4161 (add_setshow_cmds_for_options): Handle var_string.
4162 * cli-option.h (union option_def::var_address) <string>: New
4163 field.
4164 (struct string_option_def): New.
4165 * maint-test-options.c (struct test_options_opts): Add default
4166 ctor and use DISABLE_COPY_AND_ASSIGN.
4167 <string_opt>: New field.
4168 (test_options_opts::~test_options_opts): New.
4169 (test_options_opts::dump): Also dump "-string".
4170 (test_options_option_defs): Install "string.
4171
41fc454c
PA
41722019-07-03 Pedro Alves <palves@redhat.com>
4173
4174 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4175 option_value with a null enumeration.
4176 (complete_options): Save the option values in the context.
4177 (save_option_value_in_ctx): New, factored out from ...
4178 (process_options): ... here.
4179 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4180 of the function.
4181 * maint-test-options.c (test_options_opts::dump): New, factored
4182 out from ...
4183 (maintenance_test_options_command_mode): ... here.
4184 (maintenance_test_options_command_completion_result): Delete.
4185 (maintenance_test_options_command_completion_text): Update
4186 comment.
4187 (maintenance_show_test_options_completion_result): Change
4188 prototype. Just print
4189 maintenance_test_options_command_completion_text.
4190 (save_completion_result): New.
4191 (maintenance_test_options_completer_mode): Pass options context to
4192 complete_options, and then save a dump.
4193 (_initialize_maint_test_options): Use add_cmd to install "maint
4194 show test-options-completion-result".
4195
fdbc9870
PA
41962019-07-03 Pedro Alves <palves@redhat.com>
4197
4198 * NEWS (New commands): Mention "with" and "maint with".
4199 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4200 (with_command, with_command_completer): New.
4201 (pipe_command): Adjust to new repeat_previous
4202 interface.
4203 (_initialize_cli_cmds): Install the "with" command and its "w"
4204 alias.
4205 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4206 declarations.
4207 * cli/cli-setshow.c (parse_cli_var_uinteger)
4208 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4209 argument strings for all var_types.
4210 (get_setshow_command_value_string): New, factored out from ...
4211 (do_show_command): ... this.
4212 * cli/cli-setshow.h: Include <string>.
4213 (get_setshow_command_value_string): Declare.
4214 * command.h (repeat_previous): Now returns const char *. Adjust
4215 comment.
4216 * maint.c: Include "cli/cli-cmds.h".
4217 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4218 (_initialize_maint_cmds): Register the "maintenance with" command.
4219 * top.c (repeat_previous): Move bits from pipe_command here:
4220 Return the saved command line, if any; error out if there's no
4221 command to relaunch.
4222
c6ac8931
PA
42232019-07-03 Pedro Alves <palves@redhat.com>
4224
4225 * NEWS (New commands): Mention "maint set/show test-settings"
4226 instead of "maint test-settings".
4227 * maint-test-settings.c (maintenance_test_settings_list): Delete.
4228 (maintenance_test_settings_set_list): Rename to ...
4229 (maintenance_set_test_settings_list): ... this.
4230 (maintenance_test_settings_show_list): Rename to ...
4231 (maintenance_show_test_settings_list): ... this.
4232 (maintenance_test_settings_cmd): Delete.
4233 (maintenance_test_settings_set_cmd): ...
4234 (maintenance_set_test_settings_cmd): ... this.
4235 (maintenance_test_settings_show_cmd): ...
4236 (maintenance_show_test_settings_cmd): ... this.
4237 (maintenance_test_settings_show_value_cmd):
4238 (maintenance_show_test_settings_value_cmd): ... this.
4239 (_initialize_maint_test_settings): No longer install the "maint
4240 test-settings" prefix command. Rename "maint test-settings set"
4241 to "maint set test-settings", and "maint test-settings show" to
4242 "maint show test-settings". Adjust all subcommands.
4243
d1fcf2fd
PA
42442019-07-03 Pedro Alves <palves@redhat.com>
4245
4246 * maint-test-settings.c: Fix file's intro comment. Replace all
4247 references to "test-options" with references to "test-settings",
4248 in comments.
4249
970f9d09
PA
42502019-07-03 Pedro Alves <palves@redhat.com>
4251
4252 * maint-test-settings.c (maintenance_test_settings_xxx)
4253 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4254 New.
4255 (maintenance_test_settings_enums): Use them.
4256 (maintenance_test_settings_enum): Default to
4257 maintenance_test_settings_xxx.
4258 (_initialize_maint_test_settings): Initialize
4259 MAINTENANCE_TEST_SETTINGS_FILENAME.
4260
f3869b1a
SM
42612019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4262
4263 * breakpoint.h (remove_breakpoints_inf): Change return type to
4264 void, move function documentation here.
4265 * breakpoint.c (remove_breakpoints_inf): Change return type to
4266 void, move function documentation to header.
4267
54d66006
PA
42682019-07-02 Pedro Alves <palves@redhat.com>
4269
4270 * NEWS (Completion improvements): Mention "info threads".
4271 * thread.c (struct info_threads_opts, info_threads_option_defs)
4272 (make_info_threads_options_def_group): New.
4273 (info_threads_command): Use gdb::option::process_options.
4274 (info_threads_command_completer): New.
4275 (_initialize_thread): Use gdb::option::build_help to build the
4276 help text for "info threads".
4277
854f6088
SM
42782019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4279
4280 * defs.h (generic_load): Move from here...
4281 * symfile.h (generic_load): ... to here. Rename name parameter
4282 to args.
4283 * symfile.c (generic_load): Add comment.
4284
54ee4252
TT
42852019-07-01 Tom Tromey <tromey@adacore.com>
4286
4287 * dwarf2read.c
4288 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4289 declaration of without_params. Fix formatting.
4290
65392b3e
TT
42912019-07-01 Tom Tromey <tromey@adacore.com>
4292
4293 * ada-exp.y (find_primitive_type): Update.
4294 * ada-lang.h (ada_lookup_symbol): Update.
4295 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4296 parameter.
4297 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4298
7d7571f0
SDJ
42992019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4300
4301 PR breakpoints/24541
4302 * gdbarch.c: Regenerate.
4303 * gdbarch.h: Regenerate.
4304 * gdbarch.sh: Add 'stap_adjust_register'.
4305 * i386-tdep.c: Include '<unordered_set>'.
4306 (i386_stap_adjust_register): New function.
4307 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4308 * stap-probe.c (stap_parse_register_operand): Call
4309 'gdbarch_stap_adjust_register'.
4310
5af5392a
SDJ
43112019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4312
4313 PR python/24742
4314 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4315 * python/python.c (do_start_initialization): Use 'xmalloc'
4316 instead of 'PyMem_Malloc'.
4317
10d06d82
TT
43182019-06-28 Tom Tromey <tromey@adacore.com>
4319
4320 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4321 for Ada.
4322
1b7f24cd
TT
43232019-06-27 Tom Tromey <tromey@adacore.com>
4324
4325 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
4326 objfile_key.
4327 (arm_find_mapping_symbol, arm_record_special_symbol)
4328 (_initialize_arm_tdep): Update.
4329 (arm_objfile_data_free): Remove.
4330
3d507ff2
TT
43312019-06-27 Tom Tromey <tromey@adacore.com>
4332
4333 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4334 to cp_print_static_field.
4335
762c164d
TT
43362019-06-26 Tom Tromey <tromey@adacore.com>
4337
4338 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4339 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4340 declare.
4341
aa2f9bcf
AH
43422019-06-26 Alan Hayward <alan.hayward@arm.com>
4343
4344 * features/aarch64-core.c (create_feature_aarch64_core):
4345 Regenerate.
4346 * features/aarch64-core.xml: Add cpsr flags.
4347
3426ae57
AH
43482019-06-26 Alan Hayward <alan.hayward@arm.com>
4349
4350 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4351 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4352
4838e44c
SM
43532019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4354
4355 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4356 field.
4357 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4358 use.
4359 (arm_record_special_symbol): Don't insert new symbol in sorted
4360 position, push it at the end.
4361
54cc7474
SM
43622019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4363
4364 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4365 (arm_mapping_symbol_s): Remove.
4366 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4367 (arm_mapping_symbol_vec): New typedef.
4368 (struct arm_per_objfile): Add constructor.
4369 <section_maps>: Change type to
4370 std::unique_ptr<arm_mapping_symbol_vec[]>.
4371 (arm_compare_mapping_symbols): Remove.
4372 (arm_find_mapping_symbol): Adjust to section_maps type change.
4373 (arm_objfile_data_free): Call delete on arm_per_objfile.
4374 (arm_record_special_symbol): Adjust to section_maps type change.
4375 Allocate arm_per_objfile with new.
4376
b65b566c
PW
43772019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4378
4379 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4380 with the command prefix.
4381
c2fc64f5
TT
43822019-06-25 Tom Tromey <tom@tromey.com>
4383
4384 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4385 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4386
fb54fa76
TT
43872019-06-25 Tom Tromey <tom@tromey.com>
4388
4389 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4390 type.
4391 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4392 protected.
4393
f7952c57
TT
43942019-06-25 Tom Tromey <tom@tromey.com>
4395
4396 * tui/tui-winsource.c
4397 (tui_source_window_base::set_is_exec_point_at): Add check against
4398 LOA_ADDRESS.
4399
17568d78
TT
44002019-06-25 Tom Tromey <tom@tromey.com>
4401
4402 * tui/tui-source.c (tui_set_source_content): Don't check before
4403 xfree.
4404 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4405
53e7cdba
TT
44062019-06-25 Tom Tromey <tom@tromey.com>
4407
4408 * tui/tui-winsource.h (tui_update_source_window_as_is)
4409 (tui_alloc_source_buffer, tui_line_is_displayed)
4410 (tui_addr_is_displayed): Change type of win_info.
4411 * tui/tui-winsource.c (tui_update_source_window_as_is)
4412 (tui_clear_source_content, tui_show_source_line)
4413 (tui_show_source_content, tui_source_window_base::refill)
4414 (tui_source_window_base::set_is_exec_point_at)
4415 (tui_source_window_base::set_is_exec_point_at)
4416 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4417 (tui_alloc_source_buffer, tui_line_is_displayed)
4418 (tui_addr_is_displayed): Change type of win_info. Update.
4419 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4420 (tui_source_window_base::do_make_visible_with_new_height):
4421 Update.
4422 * tui/tui-source.c (tui_set_source_content)
4423 (tui_set_source_content_nil)
4424 (tui_source_window::do_scroll_vertical): Update.
4425 * tui/tui-layout.c (show_layout): Update.
4426 * tui/tui-disasm.c (tui_set_disassem_content)
4427 (tui_disasm_window::do_scroll_vertical): Update.
4428 * tui/tui-data.h (tui_win_content): Remove.
4429 (struct tui_gen_win_info) <content, content_size>: Remove.
4430 (struct tui_source_element): Add initializers and destructor.
4431 (union tui_which_element, struct tui_win_element): Remove.
4432 (struct tui_source_window_base) <content>: New field.
4433 (struct tui_data_window): Remove destructor.
4434 (tui_alloc_content, tui_free_win_content)
4435 (tui_free_all_source_wins_content): Don't declare.
4436 * tui/tui-data.c (tui_initialize_static_data): Update.
4437 (init_content_element, tui_alloc_content): Remove.
4438 (~tui_gen_win_info): Update.
4439 (~tui_data_window, tui_free_all_source_wins_content)
4440 (tui_free_win_content, free_content, free_content_elements):
4441 Remove.
4442
7908abbf
TT
44432019-06-25 Tom Tromey <tom@tromey.com>
4444
4445 * tui/tui-winsource.h (tui_clear_source_content)
4446 (tui_erase_source_content, tui_show_source_content): Change type
4447 of win_info.
4448 * tui/tui-winsource.c (tui_clear_source_content)
4449 (tui_erase_source_content, tui_show_source_content): Change type
4450 of win_info.
4451 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4452 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4453 win_info.
4454 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4455 win_info.
4456 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4457
02c28df0
TT
44582019-06-25 Tom Tromey <tom@tromey.com>
4459
4460 * tui/tui-winsource.c (tui_clear_source_content)
4461 (tui_source_window_base::set_is_exec_point_at): Update.
4462 * tui/tui-source.c (tui_set_source_content_nil): Update.
4463 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4464 a bool.
4465 * tui/tui-data.c (init_content_element): Update.
4466
6658b1bf
TT
44672019-06-25 Tom Tromey <tom@tromey.com>
4468
4469 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4470 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4471 * tui/tui-layout.c (init_and_make_win): Update.
4472 * tui/tui.h (enum tui_win_type): Update.
4473 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4474 tui_win_is_auxillary.
4475 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4476 tui_win_is_auxillary.
4477
21e1c91e
TT
44782019-06-25 Tom Tromey <tom@tromey.com>
4479
4480 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4481 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4482 (tui_delete_data_content_windows, tui_display_all_data)
4483 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4484 Update.
4485 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4486 * tui/tui-regs.c (tui_last_regs_line_no)
4487 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4488 (tui_show_registers): Update.
4489 (tui_show_register_group): Return void. Update.
4490 (tui_display_registers_from, tui_display_reg_element_at_line)
4491 (tui_display_registers_from_line, tui_check_register_values):
4492 Update.
4493 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4494 member.
4495 (struct tui_data_window) <regs_content>: Now a std::vector.
4496 <regs_content_count>: Remove.
4497 (tui_add_content_elements, tui_free_data_content): Don't declare.
4498 * tui/tui-data.c (tui_data_window::clear_detail): Update.
4499 (init_content_element): Remove DATA_WIN case. Add assert.
4500 (tui_add_content_elements): Remove.
4501 (tui_data_window): Update.
4502 (tui_free_data_content): Remove.
4503 (free_content_elements): Remove DATA_WIN case.
4504
115ac53b
TT
45052019-06-25 Tom Tromey <tom@tromey.com>
4506
4507 * tui/tui-data.c (tui_data_item_window): Update.
4508 * tui/tui-windata.h (tui_check_data_values): Don't declare.
4509 * tui/tui-windata.c (tui_display_all_data)
4510 (tui_display_data_from_line): Update.
4511 (tui_check_data_values): Remove.
4512 * tui/tui-regs.c (tui_show_register_group)
4513 (tui_display_reg_element_at_line): Update.
4514 * tui/tui-hooks.c (tui_register_changed)
4515 (tui_refresh_frame_and_register_information): Call
4516 tui_check_register_values.
4517 * tui/tui-data.h (struct tui_data_window) <data_content,
4518 data_content_count, data_type>: Remove.
4519 (enum tui_data_type): Remove.
4520
4521 * tui/tui-data.c (tui_data_window::clear_detail)
4522 (~tui_data_window): Update.
4523
eaf9738b
TT
45242019-06-25 Tom Tromey <tom@tromey.com>
4525
4526 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4527 declare.
4528 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4529 Rename from tui_first_data_item_displayed. Update.
4530 (tui_data_window::refresh_all)
4531 (tui_data_window::do_scroll_vertical): Update.
4532 * tui/tui-data.h (struct tui_data_window)
4533 <first_data_item_displayed>: Declare new method.
4534
31ca4723
TT
45352019-06-25 Tom Tromey <tom@tromey.com>
4536
4537 * tui/tui-data.h (tui_init_generic_part): Don't declare.
4538 * tui/tui-data.c (tui_init_generic_part): Remove, moving
4539 contents...
4540 (tui_initialize_static_data): ...here.
4541
41bcff7f
TT
45422019-06-25 Tom Tromey <tom@tromey.com>
4543
4544 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4545 (tui_display_registers_from, tui_check_register_values): Update.
4546 (tui_display_register): Remove win_info parameter; update.
4547 (tui_get_register): Change type of parameters.
4548 * tui/tui-data.h (struct tui_data_element): Remove.
4549 (union tui_which_element) <data>: Remove.
4550 <data_window>: Change type.
4551 (struct tui_data_item_window): New.
4552 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4553 case. Add assert.
4554 (~tui_data_item_window): New destructor.
4555 (free_content_elements): Remove DATA_ITEM_WIN case.
4556
d2802c33
TT
45572019-06-25 Tom Tromey <tom@tromey.com>
4558
4559 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4560 Remove.
4561
dd835f8b
TT
45622019-06-25 Tom Tromey <tom@tromey.com>
4563
4564 * tui/tui-data.h (struct tui_command_element): Remove.
4565 (union tui_which_element) <command>: Remove.
4566 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
4567 assert.
4568 (free_content_elements): Remove CMD_WIN case.
4569
bd7db367
TT
45702019-06-25 Tom Tromey <tom@tromey.com>
4571
4572 * tui/tui-layout.c (tui_set_layout): Update.
4573 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4574 * tui/tui-data.c (layout_def): Update.
4575
3add462f
TT
45762019-06-25 Tom Tromey <tom@tromey.com>
4577
4578 * tui/tui-wingeneral.c (tui_refresh_all): Update.
4579 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4580 (tui_source_window_base::set_new_height): Update.
4581 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4582 Update.
4583 (tui_set_locator_fullname, tui_set_locator_info)
4584 (tui_show_frame_info): Update.
4585 * tui/tui-source.c (tui_set_source_content)
4586 (tui_source_is_displayed): Update.
4587 * tui/tui-layout.c (show_source_disasm_command, show_data)
4588 (show_source_or_disasm_and_command): Update.
4589 * tui/tui-disasm.c (tui_set_disassem_content)
4590 (tui_get_begin_asm_address): Update.
4591 * tui/tui-data.h (struct tui_locator_element): Remove.
4592 (union tui_which_element) <locator>: Remove.
4593 (struct tui_locator_window): New.
4594 (tui_locator_win_info_ptr): Change return type.
4595 * tui/tui-data.c (_locator): Change type.
4596 (tui_locator_win_info_ptr): Change return type.
4597 (init_content_element): Remove LOCATOR_WIN case. Add assert.
4598 (tui_alloc_content): Add assert.
4599
489e9d8b
TT
46002019-06-25 Tom Tromey <tom@tromey.com>
4601
4602 * tui/tui-winsource.c
4603 (tui_exec_info_window::maybe_allocate_content): New method.
4604 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4605 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4606 (make_source_or_disasm_window): Add cast.
4607 * tui/tui-data.h (union tui_which_element) <simple_string>:
4608 Remove.
4609 (struct tui_source_info): New.
4610 (struct tui_source_window_base) <execution_info>: Change type.
4611 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4612 case, and add assert.
4613 (tui_alloc_content): Add assert.
4614
c3fabb7d
TT
46152019-06-25 Tom Tromey <tom@tromey.com>
4616
4617 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4618 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4619 * tui/tui-data.c (tui_alloc_win_info): Remove.
4620
bbc228ee
TT
46212019-06-25 Tom Tromey <tom@tromey.com>
4622
4623 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4624 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4625 can_highlight.
4626
5fcee43a
TT
46272019-06-25 Tom Tromey <tom@tromey.com>
4628
4629 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4630 make_visible_with_new_height method.
4631 (tui_win_info::make_visible_with_new_height): New method.
4632 (tui_source_window_base::do_make_visible_with_new_height)
4633 (tui_data_window::do_make_visible_with_new_height)
4634 (tui_cmd_window::do_make_visible_with_new_height): New methods.
4635 (make_visible_with_new_height): Remove.
4636 (tui_resize_all, tui_adjust_win_heights): Use
4637 make_visible_with_new_height method.
4638 * tui/tui-data.h (struct tui_win_info)
4639 <do_make_visible_with_new_height, make_visible_with_new_height>:
4640 New methods.
4641 (struct tui_source_window_base, struct tui_data_window)
4642 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4643 methods.
4644
d83f1fe6
TT
46452019-06-25 Tom Tromey <tom@tromey.com>
4646
4647 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4648 method.
4649 (update_tab_width): Call update_tab_width method.
4650 * tui/tui-data.h (struct tui_win_info)
4651 (struct tui_source_window_base) <update_tab_width>: New methods.
4652
17374de4
TT
46532019-06-25 Tom Tromey <tom@tromey.com>
4654
4655 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4656 parameter.
4657 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4658 parameter.
4659 (tui_gen_win_info::make_visible): Update.
4660 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4661 parameter.
4662 * tui/tui-data.h (enum tui_box): New enum.
4663 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4664
f936bca2
TT
46652019-06-25 Tom Tromey <tom@tromey.com>
4666
4667 * tui/tui-layout.c (make_source_or_disasm_window): Always use
4668 init_and_make_win for EXEC_INFO_WIN.
4669 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4670 longer inline.
4671 (struct tui_win_info) <~tui_win_info>: Inline.
4672 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4673 Don't declare.
4674 * tui/tui-data.c (source_win, disasm_win): Remove globals.
4675 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4676 Remove.
4677 (tui_initialize_static_data): Update.
4678 (~tui_gen_win_info): Handle more cleanup here.
4679 (~tui_source_window_base): Delete "execution_info".
4680 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4681
d6ba6a11
TT
46822019-06-25 Tom Tromey <tom@tromey.com>
4683
4684 * tui/tui-layout.c (make_command_window): Don't set
4685 can_highlight.
4686 (show_source_disasm_command): Call the reset method.
4687 (show_data): Don't set can_highlight. Call the reset method.
4688 (tui_gen_win_info::reset): Rename from init_gen_win_info
4689 (init_and_make_win): Simplify. Return tui_gen_win_info.
4690 (show_source_or_disasm_and_command): Call the reset method.
4691 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4692 (struct tui_cmd_window): Set can_highlight.
4693
48a3bd16
TT
46942019-06-25 Tom Tromey <tom@tromey.com>
4695
4696 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4697 from make_visible.
4698 (tui_make_visible, tui_make_invisible): Rewrite.
4699 (tui_win_info::make_visible): Remove.
4700 (tui_source_window_base::make_visible): Update.
4701 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4702 method. Moved from...
4703 (struct tui_win_info) <make_visible>: ...here.
4704
c3bd716f
TT
47052019-06-25 Tom Tromey <tom@tromey.com>
4706
4707 * tui/tui-winsource.c
4708 (tui_source_window_base::do_scroll_horizontal): Remove direction
4709 parameter.
4710 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4711 direction parameter.
4712 * tui/tui-win.c (tui_win_info::forward_scroll)
4713 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4714 (tui_win_info::right_scroll): Update.
4715 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4716 direction parameter.
4717 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4718 direction parameter.
4719 * tui/tui-data.h (enum tui_scroll_direction): Remove.
4720 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4721 Remove direction parameter.
4722 (struct tui_source_window_base, struct tui_source_window)
4723 (struct tui_disasm_window, struct tui_data_window)
4724 (struct tui_cmd_window): Update.
4725
21c32dca
TT
47262019-06-25 Tom Tromey <tom@tromey.com>
4727
4728 * tui/tui-winsource.h (tui_set_exec_info_content)
4729 (tui_show_exec_info_content, tui_erase_exec_info_content)
4730 (tui_clear_exec_info_content, tui_update_exec_info): Change
4731 argument to tui_source_window_base.
4732 * tui/tui-winsource.c (tui_set_exec_info_content)
4733 (tui_show_exec_info_content, tui_erase_exec_info_content)
4734 (tui_clear_exec_info_content, tui_update_exec_info): Change
4735 argument to tui_source_window_base.
4736
73fbdc65
TT
47372019-06-25 Tom Tromey <tom@tromey.com>
4738
4739 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4740 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4741
33325343
TT
47422019-06-25 Tom Tromey <tom@tromey.com>
4743
4744 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4745 check.
4746
29d2c474
TT
47472019-06-25 Tom Tromey <tom@tromey.com>
4748
4749 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4750 type to void.
4751 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4752 type to void.
4753 * tui/tui-source.c (tui_set_source_content): Update.
4754 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4755
152f3f4b
TT
47562019-06-25 Tom Tromey <tom@tromey.com>
4757
4758 * tui/tui-win.c (window_name_completer, tui_set_focus)
4759 (tui_all_windows_info): Use name method.
4760 * tui/tui-data.h (struct tui_gen_win_info)
4761 (struct tui_source_window, struct tui_disasm_window)
4762 (struct tui_data_window, struct tui_cmd_window) <name>: New
4763 method.
4764 (tui_win_name): Don't declare.
4765 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4766 (tui_win_name): Remove.
4767
be4da588
TT
47682019-06-25 Tom Tromey <tom@tromey.com>
4769
4770 * tui/tui-winsource.h (tui_update_source_window)
4771 (tui_update_source_window_as_is): Change parameter type.
4772 * tui/tui-winsource.c (tui_update_source_window): Change win_info
4773 to be a tui_source_window_base.
4774 (tui_update_source_window_as_is): Likewise.
4775 * tui/tui-win.c (make_visible_with_new_height): Update.
4776
5b81daba
TT
47772019-06-25 Tom Tromey <tom@tromey.com>
4778
4779 * tui/tui-winsource.c (tui_erase_source_content)
4780 (tui_show_source_content, tui_show_exec_info_content)
4781 (tui_erase_exec_info_content): Use refresh_window method.
4782 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4783 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4784 from tui_refresh_win.
4785 (tui_data_window::refresh_window): New method.
4786 (tui_win_info::refresh, tui_source_window_base::refresh)
4787 (tui_refresh_all): Use refresh_window method.
4788 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4789 method.
4790 * tui/tui-regs.c (tui_display_register): Call refresh_window
4791 method.
4792 * tui/tui-layout.c (show_source_disasm_command)
4793 (show_source_or_disasm_and_command): Call refresh_window method.
4794 * tui/tui-data.h (struct tui_gen_win_info)
4795 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4796 New method.
4797
cb2ce893
TT
47982019-06-25 Tom Tromey <tom@tromey.com>
4799
4800 * tui/tui.c (tui_rl_other_window, tui_enable)
4801 (tui_is_window_visible, tui_get_command_dimension): Update.
4802 * tui/tui-winsource.c (tui_update_source_window_as_is)
4803 (tui_clear_source_content, tui_erase_source_content)
4804 (tui_show_source_line, tui_source_window_base::refill)
4805 (tui_source_window_base::do_scroll_horizontal)
4806 (tui_source_window_base::set_is_exec_point_at)
4807 (tui_update_breakpoint_info, tui_set_exec_info_content)
4808 (tui_alloc_source_buffer, tui_line_is_displayed)
4809 (tui_addr_is_displayed): Update.
4810 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4811 (tui_check_and_display_highlight_if_needed)
4812 (tui_win_info::make_visible, tui_win_info::refresh)
4813 (tui_refresh_all): Update.
4814 * tui/tui-windata.c (tui_first_data_item_displayed)
4815 (tui_delete_data_content_windows, tui_erase_data_content)
4816 (tui_display_all_data, tui_data_window::refresh_all)
4817 (tui_check_data_values): Update.
4818 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4819 (tui_set_win_focus_to, tui_win_info::forward_scroll)
4820 (tui_win_info::backward_scroll, tui_refresh_all_win)
4821 (tui_resize_all, tui_set_focus, tui_all_windows_info)
4822 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4823 (tui_source_window_base::set_new_height)
4824 (tui_data_window::set_new_height)
4825 (make_invisible_and_set_new_height)
4826 (make_visible_with_new_height, new_height_ok)
4827 (parse_scrolling_args): Update.
4828 * tui/tui-stack.c (tui_show_frame_info): Update.
4829 * tui/tui-source.c (tui_set_source_content)
4830 (tui_set_source_content_nil, tui_source_is_displayed)
4831 (tui_source_window::do_scroll_vertical): Update.
4832 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4833 (tui_display_registers_from, tui_display_reg_element_at_line)
4834 (tui_check_register_values, tui_reg_command): Update.
4835 * tui/tui-layout.c (tui_default_win_height)
4836 (show_source_disasm_command, show_data, init_and_make_win)
4837 (show_source_or_disasm_and_command): Update.
4838 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4839 (tui_redisplay_readline, tui_mld_flush)
4840 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4841 (tui_getc): Update.
4842 * tui/tui-disasm.c (tui_set_disassem_content)
4843 (tui_disasm_window::do_scroll_vertical): Update.
4844 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4845 Now virtual.
4846 (struct tui_win_info): Derive from tui_gen_win_info.
4847 <~tui_win_info>: Mark as override.
4848 <generic>: Remove member.
4849 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4850 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4851 (~tui_data_window, ~tui_win_info)
4852 (tui_free_all_source_wins_content): Update.
4853 * tui/tui-command.c (tui_refresh_cmd_win): Update.
4854
ab313b35
TT
48552019-06-25 Tom Tromey <tom@tromey.com>
4856
4857 * tui/tui-layout.c (init_and_make_win): Use new.
4858 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4859 destructor, initializers.
4860 (tui_alloc_generic_win_info): Don't declare.
4861 * tui/tui-data.c (_locator): Add argument to constructor.
4862 (source_win, disasm_win): New globals.
4863 (exec_info): Remove.
4864 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4865 Update.
4866 (tui_alloc_generic_win_info): Remove.
4867 (init_content_element): Use new.
4868 (tui_win_info::tui_win_info): Update.
4869 (free_content_elements) <case DATA_WIN>: Use delete.
4870
dc2c33e4
TT
48712019-06-25 Tom Tromey <tom@tromey.com>
4872
4873 * tui/tui-wingeneral.c (tui_refresh_win): Update.
4874 * tui/tui-windata.c (tui_first_data_item_displayed)
4875 (tui_delete_data_content_windows): Update.
4876 * tui/tui-win.c (tui_data_window::set_new_height): Update.
4877 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4878 (tui_display_registers_from, tui_check_register_values): Update.
4879 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4880 pointer.
4881 * tui/tui-data.c (init_content_element): Update. Allocate the new
4882 window.
4883 (tui_free_data_content): Update.
4884 (free_content_elements) <case DATA_WIN>: Free the window.
4885
214a5cbe
TT
48862019-06-25 Tom Tromey <tom@tromey.com>
4887
4888 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4889 Update.
4890 * tui/tui-layout.c (make_command_window)
4891 (show_source_disasm_command, show_data, init_and_make_win)
4892 (show_source_or_disasm_and_command): Update.
4893 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4894 method.
4895 <can_highight, is_highlighted>: Now bool.
4896 (tui_set_win_highlight): Don't declare.
4897 * tui/tui-data.c (tui_set_win_highlight): Remove.
4898
8e2daf15
TT
48992019-06-25 Tom Tromey <tom@tromey.com>
4900
4901 * tui/tui-wingeneral.c (make_visible): Remove check of window
4902 type.
4903
8903bd8a
TT
49042019-06-25 Tom Tromey <tom@tromey.com>
4905
4906 * tui/tui-win.c (tui_win_info::max_height)
4907 (tui_cmd_window::max_height): New methods.
4908 (new_height_ok): Call max_height.
4909 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4910 <max_height>: New method.
4911
3f02ce1e
TT
49122019-06-25 Tom Tromey <tom@tromey.com>
4913
4914 * tui/tui-win.c (tui_source_window_base::set_new_height)
4915 (tui_data_window::set_new_height): New methods.
4916 (make_invisible_and_set_new_height): Call set_new_height method.
4917 * tui/tui-data.h (struct tui_win_info)
4918 (struct tui_source_window_base, struct tui_data_window)
4919 <set_new_height>: New method.
4920
1825f487
TT
49212019-06-25 Tom Tromey <tom@tromey.com>
4922
4923 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4924 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4925 tui_refresh_data_win.
4926 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4927 method.
4928 (tui_refresh_all_win): Call the refresh_all method.
4929 (tui_set_focus): Likewise.
4930 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4931 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4932 Likewise.
4933
ad54d15b
TT
49342019-06-25 Tom Tromey <tom@tromey.com>
4935
4936 * tui/tui-winsource.h (tui_refill_source_window)
4937 (tui_set_is_exec_point_at): Don't declare.
4938 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4939 (tui_source_window_base::refill): Rename from
4940 tui_refill_source_window.
4941 (tui_source_window_base::do_scroll_horizontal): Update.
4942 (tui_source_window_base::set_is_exec_point_at): Rename from
4943 tui_set_is_exec_point_at.
4944 (tui_update_all_breakpoint_info): Update.
4945 * tui/tui-stack.c (tui_show_frame_info): Update.
4946 * tui/tui-layout.c (show_data): Add cast.
4947 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4948 * tui/tui-data.h (struct tui_source_window_base) <refill,
4949 set_is_exec_point_at>: New methods.
4950 (tui_source_windows, tui_add_to_source_windows): Update types.
4951 (tui_add_to_source_windows): Remove redundant declaration.
4952 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4953 (tui_source_windows): Change return type.
4954 (tui_clear_source_windows_detail): Update.
4955 (tui_add_to_source_windows): Change type of parameter.
4956 (tui_free_all_source_wins_content): Update.
4957
2042b506
TT
49582019-06-25 Tom Tromey <tom@tromey.com>
4959
4960 * tui/tui-wingeneral.c (tui_win_info::refresh)
4961 (tui_source_window_base::refresh): New methods.
4962 (tui_refresh_all): Call the refresh method.
4963 * tui/tui-data.h (struct tui_win_info)
4964 (struct tui_source_window_base) <refresh>: New method.
4965
56122977
TT
49662019-06-25 Tom Tromey <tom@tromey.com>
4967
4968 * tui/tui.h (tui_is_window_visible): Return bool.
4969 * tui/tui.c (tui_is_window_visible): Return bool.
4970 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4971 (tui_make_visible, tui_make_invisible)
4972 (tui_win_info::make_visible)
4973 (tui_source_window_base::make_visible, make_all_visible)
4974 (tui_make_all_visible, tui_make_all_invisible): Update.
4975 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4976 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4977 bool.
4978 (struct tui_win_info, struct tui_source_window_base)
4979 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4980 * tui/tui-data.c (tui_init_generic_part): Update.
4981
cda37efb
TT
49822019-06-25 Tom Tromey <tom@tromey.com>
4983
4984 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4985 (tui_source_window_base::make_visible): New methods.
4986 (make_all_visible): Make method call.
4987 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4988 (struct tui_source_window_base, struct tui_cmd_window): Override
4989 make_visible.
4990 (tui_win_is_source_type): Don't declare.
4991 * tui/tui-data.c (tui_win_is_source_type): Remove.
4992
6a0ee02c
TT
49932019-06-25 Tom Tromey <tom@tromey.com>
4994
4995 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4996 NULL check.
4997
63901aec
TT
49982019-06-25 Tom Tromey <tom@tromey.com>
4999
5000 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5001 Inline constructor. Add initializers for members.
5002 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5003 constructors; now inline in class.
5004
ceb13a13
TT
50052019-06-25 Tom Tromey <tom@tromey.com>
5006
5007 * tui/tui-regs.c (tui_show_registers): Update.
5008 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5009 bool.
5010 * tui/tui-data.c (tui_data_window::clear_detail)
5011 (tui_data_window): Update.
5012
238eb706
TT
50132019-06-25 Tom Tromey <tom@tromey.com>
5014
5015 * tui/tui-windata.c (tui_display_all_data)
5016 (tui_display_data_from_line, tui_display_data_from)
5017 (tui_check_data_values, tui_data_window::do_scroll_vertical):
5018 Update.
5019 * tui/tui-regs.c (tui_last_regs_line_no)
5020 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5021 (tui_show_registers, tui_show_register_group)
5022 (tui_display_registers_from, tui_display_reg_element_at_line)
5023 (tui_display_registers_from_line, tui_check_register_values)
5024 (tui_reg_next, tui_reg_prev): Update.
5025 * tui/tui-layout.c (tui_set_layout, show_data): Update.
5026 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
5027 tui_data_window.
5028 (struct tui_win_info) <detail>: Remove. Add new fields from
5029 tui_data_info.
5030 (TUI_DATA_WIN): Add cast.
5031 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5032 (~tui_data_window): Simplify.
5033
81491aa0
TT
50342019-06-25 Tom Tromey <tom@tromey.com>
5035
5036 * tui/tui-layout.c (show_source_disasm_command)
5037 (show_source_or_disasm_and_command): Update.
5038 * tui/tui-io.c (update_cmdwin_start_line)
5039 (tui_redisplay_readline): Update.
5040 * tui/tui-data.h (struct tui_command_info): Remove.
5041 (struct tui_win_info) <detail>: Remove command_info member.
5042 (struct tui_data_window) <start_line>: New member, from
5043 tui_command_info.
5044 (TUI_CMD_WIN): Add casts.
5045
e6e41501
TT
50462019-06-25 Tom Tromey <tom@tromey.com>
5047
5048 * tui/tui-winsource.c (tui_update_source_window)
5049 (tui_refill_source_window)
5050 (tui_source_window_base::do_scroll_horizontal)
5051 (tui_update_breakpoint_info, tui_set_exec_info_content)
5052 (tui_show_exec_info_content, tui_erase_exec_info_content)
5053 (tui_clear_exec_info_content): Update.
5054 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5055 Update.
5056 * tui/tui-win.c (make_invisible_and_set_new_height)
5057 (make_visible_with_new_height): Update.
5058 * tui/tui-source.c (tui_set_source_content)
5059 (tui_show_symtab_source): Update.
5060 * tui/tui-layout.c (extract_display_start_addr)
5061 (show_source_disasm_command, show_data)
5062 (make_source_or_disasm_window)
5063 (show_source_or_disasm_and_command): Update.
5064 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5065 (tui_disasm_window::do_scroll_vertical): Remove shadowing
5066 "gdbarch".
5067 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
5068 to tui_source_window_base.
5069 (struct tui_win_info) <detail>: Remove source_info member.
5070 (struct tui_source_window_base) <has_locator>: Inline.
5071 Move contents from tui_source_info; rename has_locator member to
5072 m_has_locator.
5073 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5074 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5075 header file.
5076 (tui_source_window_base::clear_detail, ~tui_source_window_base):
5077 Simplify.
5078 (tui_free_all_source_wins_content): Cast to
5079 tui_source_window_base.
5080
44f0e208
TT
50812019-06-25 Tom Tromey <tom@tromey.com>
5082
5083 * tui/tui-win.c (make_invisible_and_set_new_height)
5084 (make_visible_with_new_height): Call has_locator method.
5085 * tui/tui-layout.c (show_source_disasm_command, show_data)
5086 (show_source_or_disasm_and_command): Update for bool change.
5087 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5088 (tui_win_info) <has_locator>: New method.
5089 (struct tui_source_window_base) <has_locator>: New method.
5090 (tui_win_has_locator): Don't declare.
5091 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5092 from tui_win_has_locator.
5093 (tui_source_window_base): Use false, not FALSE.
5094
7778b912
TT
50952019-06-25 Tom Tromey <tom@tromey.com>
5096
5097 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5098 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5099 clear_detail method directly.
5100 (tui_clear_win_detail): Remove.
5101
f83d391c
TT
51022019-06-25 Tom Tromey <tom@tromey.com>
5103
5104 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5105 "this", not TUI_DISASM_WIN.
5106
13446e05
TT
51072019-06-25 Tom Tromey <tom@tromey.com>
5108
5109 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
5110 declare.
5111 * tui/tui-winsource.c
5112 (tui_source_window_base::do_scroll_horizontal): Rename from
5113 tui_horizontal_source_scroll.
5114 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5115 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5116 from tui_vertical_data_scroll.
5117 * tui/tui-win.h (tui_scroll): Don't declare.
5118 * tui/tui-win.c (tui_win_info::forward_scroll)
5119 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5120 (tui_win_info::right_scroll): Rename and update.
5121 (tui_scroll_forward_command, tui_scroll_backward_command)
5122 (tui_scroll_left_command, tui_scroll_right_command): Update.
5123 (tui_scroll): Remove.
5124 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5125 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5126 from tui_vertical_source_scroll.
5127 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5128 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5129 from tui_vertical_disassem_scroll.
5130 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5131 do_scroll_horizontal>: New methods.
5132 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5133 Likewise.
5134 (struct tui_source_window_base): Add do_scroll_horizontal.
5135 (struct tui_source_window, struct tui_disasm_window): Add
5136 do_scroll_vertical.
5137 (struct tui_data_window, struct tui_cmd_window): Add
5138 do_scroll_horizontal and do_scroll_vertical.
5139 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5140
5cf82909
TT
51412019-06-25 Tom Tromey <tom@tromey.com>
5142
5143 * tui/tui-data.h (struct tui_source_window_base): New struct.
5144 (struct tui_source_window): Derive from tui_source_window_base.
5145 (struct tui_disasm_window): New struct.
5146 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5147 from tui_source_window::clear_detail.
5148 (tui_source_window_base): Rename from tui_source_window.
5149 (~tui_source_window_base): Rename from ~tui_source_window.
5150 (tui_alloc_win_info): Create a tui_disasm_window.
5151
ee1d42d6
TT
51522019-06-25 Tom Tromey <tom@tromey.com>
5153
5154 * tui/tui-data.h (struct tui_source_window)
5155 (struct tui_data_window): Declare destructors.
5156 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5157 destructors.
5158 (tui_win_info): Simplify.
5159
b4eb2452
TT
51602019-06-25 Tom Tromey <tom@tromey.com>
5161
5162 * tui/tui-winsource.c (tui_display_main)
5163 (tui_update_source_windows_with_addr)
5164 (tui_update_all_breakpoint_info): Update.
5165 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5166 (new_height_ok, parse_scrolling_args): Update.
5167 * tui/tui-stack.c (tui_show_frame_info): Update.
5168 * tui/tui-data.h (struct tui_list): Remove.
5169 (tui_source_windows): Return a reference to a std::vector.
5170 * tui/tui-data.c (source_windows): Now a std::vector.
5171 (tui_source_windows): Change return type.
5172 (tui_clear_source_windows): Rewrite.
5173 (tui_clear_source_windows_detail, tui_add_to_source_windows)
5174 (tui_free_all_source_wins_content): Rewrite.
5175
8761a91b
TT
51762019-06-25 Tom Tromey <tom@tromey.com>
5177
5178 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5179 (struct tui_data_window, struct tui_cmd_window): Declare
5180 clear_detail method.
5181 * tui/tui-data.c (tui_source_window::clear_detail)
5182 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5183 methods.
5184 (tui_clear_win_detail): Simplify.
5185
0ed69eda
TT
51862019-06-25 Tom Tromey <tom@tromey.com>
5187
5188 * tui/tui-layout.c (make_source_window, make_disasm_window)
5189 (make_source_or_disasm_window): Remove win_info_ptr parameter.
5190 Return the new window.
5191 (show_source_disasm_command, show_data)
5192 (show_source_or_disasm_and_command): Update.
5193
82432e10
TT
51942019-06-25 Tom Tromey <tom@tromey.com>
5195
5196 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5197 parameter. Return the new window.
5198 (show_source_disasm_command): Update and remove NULL check.
5199 (show_source_or_disasm_and_command): Update.
5200
ec328aa5
TT
52012019-06-25 Tom Tromey <tom@tromey.com>
5202
5203 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5204
33b906ab
TT
52052019-06-25 Tom Tromey <tom@tromey.com>
5206
5207 * tui/tui-data.h (struct tui_win_info): Make constructor
5208 protected. Make destructor virtual. Add initializers.
5209 (tui_source_window, tui_data_window, tui_cmd_window): New
5210 classes.
5211 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
5212 constructor. Add "type" parameter.
5213 (tui_source_window, tui_data_window, tui_cmd_window): New
5214 constructors.
5215 (tui_alloc_win_info): Instantiate the appropriate subclass.
5216
e7e11af4
TT
52172019-06-25 Tom Tromey <tom@tromey.com>
5218
5219 * tui/tui-win.c (tui_resize_all): Use delete.
5220 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5221 destructor.
5222 (tui_free_window): Don't declare.
5223 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5224 Update.
5225
6792b55e
TT
52262019-06-25 Tom Tromey <tom@tromey.com>
5227
5228 * tui/tui-data.h (struct tui_win_info): Add constructor.
5229 * tui/tui-data.c (tui_alloc_win_info): Use new.
5230 (tui_free_window): Use delete.
5231
f95675e1
TT
52322019-06-22 Tom Tromey <tom@tromey.com>
5233
5234 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5235 declare.
5236 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5237
5bff081c
TT
52382019-06-22 Tom Tromey <tom@tromey.com>
5239
5240 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5241 declare.
5242 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5243
47e3f474
TV
52442019-06-22 Tom de Vries <tdevries@suse.de>
5245
5246 * dwarf2read.c (create_addrmap_from_aranges)
5247 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5248 instead of '%zu'.
5249
fd5866f6
SM
52502019-06-21 Simon Marchi <simon.marchi@efficios.com>
5251
5252 * dwarf2read.h (dwarf2_section_info_def): Remove.
5253 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5254 * dwarf2read.c (struct dwo_sections) <types>: Change type to
5255 std::vector<dwarf2_section_info>.
5256 (struct dwo_file) <~dwo_file>: Remove.
5257 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5258 types field.
5259 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5260 (dwarf2_read_debug_names): Likewise.
5261 (create_debug_types_hash_table): Change parameter type to
5262 array_view, adjust code accordingly.
5263 (dwarf2_locate_dwo_sections): Adjust to std::vector.
5264 (partial_die_info::fixup): Likewise.
5265 (determine_prefix): Likewise.
5266 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5267
fb1eb2f9
SM
52682019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5269
5270 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5271 gdb_bfd_ref_ptr.
5272 <~dwo_file>: Remove call to gdb_bfd_unref.
5273 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5274 gdb_bfd_ref_ptr::get.
5275
51ac9db5
SM
52762019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5277
5278 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5279 type to htab_up.
5280 * dwarf2read.c (struct dwo_file): Initialize fields.
5281 <~dwo_file>: New.
5282 (free_dwo_file): Remove, move content to ~dwo_file.
5283 (struct dwo_file_deleter): Remove.
5284 (dwo_file_up>: Remove custom deleter.
5285 (free_dwo_files): Remove.
5286 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5287 dwo_files.
5288 (process_skeletonless_type_units): Call unique_ptr::get.
5289 (allocate_dwo_file_hash_table): Add deleter to created hash
5290 table. Change return type to htab_up.
5291 (lookup_dwo_file_slot): Don't memset dwo_file, call
5292 unique_ptr::get.
5293 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5294 (create_dwo_unit_in_dwp_v2): Likewise.
5295 (open_and_init_dwo_file): Likewise.
5296 (free_dwo_file_from_slot): Remove.
5297
dc4ccb6f
SM
52982019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5299
5300 * dwarf2read.h (struct dwarf2_section_info) <readin,
5301 is_virtual>: Change type to bool.
5302 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5303 true instead of 1.
5304
e6a1c5cb
TT
53052019-06-19 Tom Tromey <tom@tromey.com>
5306
5307 * tui/tui-data.h (tui_init_content_element): Don't declare.
5308
6f6ffbeb
TT
53092019-06-19 Tom Tromey <tom@tromey.com>
5310
5311 * tui/tui-data.h (tui_init_win_info): Don't declare.
5312
f23f598e
TV
53132019-06-19 Tom de Vries <tdevries@suse.de>
5314
5315 * dwarf2read.h (abstract_to_concrete): Change type to
5316 std::unordered_map<sect_offset, std::vector<sect_offset>,
5317 gdb::hash_enum<sect_offset>>.
5318
680e1bee
TT
53192019-06-19 Tom Tromey <tromey@adacore.com>
5320
5321 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5322 EVAL_AVOID_SIDE_EFFECTS specially.
5323
dcf37923
TT
53242019-06-19 Tom Tromey <tromey@adacore.com>
5325
5326 * source-cache.c (highlighter): New global.
5327 (source_cache::get_source_lines): Create a highlighter on demand.
5328
494986d5
AB
53292019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
5330
5331 * defs.h (deprecated_interactive_hook): Delete declaration.
5332 * interps.c (clear_interpreter_hooks): Remove use of
5333 deprecated_interactive_hook.
5334 * top.c (deprecated_interactive_hook): Delete definition.
5335 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5336
3360b6e7
TV
53372019-06-18 Tom de Vries <tdevries@suse.de>
5338
5339 PR gdb/24515
5340 * dwarf2read.h (abstract_to_concrete): Change type from
5341 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5342 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5343 * dwarf2read.c (read_variable): Update.
5344 (dwarf2_fetch_die_loc_sect_off): Update.
5345
310b3441
TV
53462019-06-17 Tom de Vries <tdevries@suse.de>
5347
5348 PR gdb/24617
5349 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5350 accessing parent[parent_len - 1].
5351
ba9777be
PP
53522019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5353
5354 PR gdb/24364
5355 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5356 call dtrace_process_dof with NULL dof.
5357
2b9f6e89
TV
53582019-06-16 Tom de Vries <tdevries@suse.de>
5359
5360 PR gdb/24445
5361 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5362
431b3ead
TT
53632019-06-16 Tom Tromey <tom@tromey.com>
5364
5365 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5366 (make_all_visible): Use address of member.
5367
d04b44a1
TT
53682019-06-16 Tom Tromey <tom@tromey.com>
5369
5370 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5371 (tui_free_window, free_content, free_content_elements): Remove
5372 unnecessary cast.
5373 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5374 cast.
5375 * tui/tui-regs.c (tui_show_register_group)
5376 (tui_display_registers_from, tui_display_reg_element_at_line):
5377 Remove unnecessary cast.
5378
bf5142e7
AB
53792019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5380
5381 * linux-nat.c (normal_mask): Delete.
5382 (_initialize_linux_nat): Don't initialise normal_mask.
5383
c4973306
SM
53842019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5385
5386 PR gdb/24445
5387 * dwarf-index-write.h (write_psymtabs_to_index): Add
5388 dwz_basename parameter.
5389 * dwarf-index-write.c (write_gdbindex): Move file writing to
5390 write_gdbindex_1. Change return type void.
5391 (assert_file_size): Move up, remove filename parameter.
5392 (write_gdbindex_1): New function.
5393 (write_debug_names): Change return type to void, call
5394 assert_file_size.
5395 (struct index_wip_file): New struct.
5396 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5397 file logic to index_wip_file. Write index for dwz file if
5398 needed.
5399 (save_gdb_index_command): Pass basename of dwz file, if present.
5400 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5401 build-id of dwz file, if present.
5402 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5403 (dwarf2_get_dwz_file): Likewise.
5404 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5405 (dwarf2_get_dwz_file): Likewise.
5406
395f9c91
TT
54072019-06-16 Tom Tromey <tom@tromey.com>
5408
5409 * coffread.c (process_coff_symbol): Use xstrdup.
5410 * value.c (create_internalvar): Use xstrdup.
5411
cafb3438
TT
54122019-06-16 Tom Tromey <tom@tromey.com>
5413
5414 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5415 * breakpoint.c (stopin_command, stopat_command)
5416 (until_break_command, decode_location_default): Remove unnecessary
5417 cast.
5418 * utils.c (subset_compare): Remove unnecessary cast.
5419 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5420 cast.
5421 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5422 cast.
5423 * infcmd.c (path_command): Remove unnecessary cast.
5424 * coffread.c (decode_type): Remove unnecessary cast.
5425 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5426 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5427 * tui/tui-stack.c (tui_show_locator_content)
5428 (tui_show_frame_info): Remove unnecessary cast.
5429 * tui/tui-win.c (tui_scroll_forward_command)
5430 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5431 (parse_scrolling_args): Remove unnecessary cast.
5432 * tui/tui-data.c (init_win_info, tui_del_window)
5433 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5434 (free_content_elements): Remove unnecessary cast.
5435 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5436 unnecessary cast.
5437 * tui/tui-source.c (tui_set_source_content)
5438 (tui_vertical_source_scroll): Remove unnecessary cast.
5439 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5440 cast.
5441 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5442 * tui/tui-regs.c (tui_display_registers_from)
5443 (tui_display_register): Remove unnecessary cast.
5444 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5445 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5446 (make_visible): Remove unnecessary cast.
5447 * tui/tui-winsource.c (tui_erase_source_content)
5448 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5449 unnecessary cast.
5450 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5451 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5452 * stabsread.c (read_type, read_array_type, read_range_type):
5453 Remove unnecessary cast.
5454 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5455 (parse_symbol, parse_type, upgrade_type, parse_external)
5456 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5457 unnecessary cast.
5458 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5459
730ead81
TT
54602019-06-16 Tom Tromey <tom@tromey.com>
5461
5462 * tui/tui-data.c (tui_alloc_generic_win_info)
5463 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5464 checks.
5465
584a927c
AB
54662019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5467 Andrew Burgess <andrew.burgess@embecosm.com>
5468
5469 * f-typeprint.c (f_print_type): Don't return early for not
5470 associated or not allocated types.
5471 (f_type_print_varspec_suffix): Add print_rank parameter and print
5472 ranks of array types in case they dangling.
5473 (f_type_print_base): Add print_rank parameter.
5474
30056ea0
AB
54752019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5476
5477 * NEWS: Mention new MI commands.
5478 * break-catch-throw.c (enum exception_event_kind): Move to
5479 breakpoint.h.
5480 (print_mention_exception_catchpoint): Output text as a single
5481 message.
5482 (catch_exception_command_1): Rename to...
5483 (catch_exception_event): ...this, make non-static, update header
5484 command, and change some parameter types.
5485 (catch_catch_command): Update for changes to
5486 catch_exception_command_1.
5487 (catch_throw_command): Likewise.
5488 (catch_rethrow_command): Likewise.
5489 * breakpoint.c (enum exception_event_kind): Delete.
5490 * breakpoint.h (enum exception_event_kind): Moved here from
5491 break-catch-throw.c.
5492 (catch_exception_event): Declare.
5493 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5494 (mi_cmd_catch_throw): New function.
5495 (mi_cmd_catch_rethrow): New function.
5496 (mi_cmd_catch_catch): New function.
5497 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5498 'catch-catch' entries.
5499 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5500 (mi_cmd_catch_rethrow): Declare.
5501 (mi_cmd_catch_catch): Declare.
5502
ec8e2b6d
AB
55032019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5504
5505 * annotate.c (annotate_source_line): Change return type to void,
5506 update implementation to match.
5507 * annotate.h (annotate_source_line): Change return type to void,
5508 update header comment.
5509 * stack.c (print_frame_info): Don't change what frame information
5510 is printed based on whether annotations are on or not.
5511
0d3abd8c
AB
55122019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5513
5514 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5515 (annotate_source): Make static.
5516 (annotate_source_line): Moved from source.c and renamed from
5517 identify_source_line. Update the return type.
5518 * annotate.h (annotate_source): Delete declaration.
5519 (annotate_source_line): Declaration moved from source.h, and
5520 renamed from identify_source_line. Return type updated.
5521 * source.c (identify_source_line): Moved to annotate.c and renamed
5522 to annotate_source_line.
5523 (info_line_command): Remove check of annotation_level.
5524 * source.h (identify_source_line): Move declaration to annotate.h
5525 and rename to annotate_source_line.
5526 * stack.c: Add 'annotate.h' include.
5527 (print_frame_info): Remove check of annotation_level before
5528 calling annotate_source_line.
5529
00df30ae
AB
55302019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5531
5532 * source-cache.c (source_cache::get_plain_source_lines): Use
5533 open_source_file_with_line_charpos instead of just
5534 open_source_file, remove call to find_source_lines.
5535 (source_cache::get_source_lines): Likewise.
5536 * source.c (find_source_lines): Make static.
5537 (get_filename_and_charpos): Renamed into...
5538 (open_source_file_with_line_charpos): ..this along with changes to
5539 return a scoped_fd, and some other minor clean ups.
5540 (identify_source_line): Use open_source_file_with_line_charpos.
5541 (search_command_helper): Use open_source_file_with_line_charpos
5542 instead of just open_source_file, remove call to
5543 find_source_lines.
5544 * source.h (open_source_file_with_line_charpos): Declare new
5545 function.
5546 (find_source_lines): Delete declaration.
5547
afda45a2
AB
55482019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5549
5550 * source.c (get_filename_and_charpos): Remove fullname
5551 parameter.
5552 (identify_source_line): Update call to get_filename_and_charpos.
5553
0735b091
TT
55542019-06-14 Tom Tromey <tromey@adacore.com>
5555
5556 PR gdb/24502:
5557 * ui-style.h (skip_ansi_escape): Update comment.
5558 * ui-file.h (class no_terminal_escape_file): New class.
5559 * ui-file.c (no_terminal_escape_file::write)
5560 (no_terminal_escape_file::puts): New methods.
5561 * cli/cli-logging.c (handle_redirections): Use
5562 no_terminal_escape_file.
5563
52ce35e2
TT
55642019-06-14 Tom Tromey <tromey@adacore.com>
5565
5566 * NEWS: Move convenience variable news above Python news.
5567
73cc7272
TT
55682019-06-14 Tom Tromey <tom@tromey.com>
5569
5570 * gnulib: Move directory to top-level.
5571 * configure.ac: Don't configure gnulib.
5572 * configure: Rebuild.
5573 * common/common-defs.h: Use new path to gnulib.
5574 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5575 (GNULIB_H): Remove.
5576 (INCGNU): Look in new gnulib location.
5577 (HFILES_NO_SRCDIR): Remove gnulib files.
5578 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5579 (generated_files): Remove GNULIB_H.
5580 ($(LIBGNU), all-lib): Remove targets.
5581 (distclean): Don't mention GNULIB_BUILDDIR.
5582 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5583
f5686554
TT
55842019-06-14 Tom Tromey <tromey@adacore.com>
5585
5586 * symfile.c (add_symbol_file_command): Remove obsolete comment.
5587 Warn if symbol file does not provide any symbols.
5588
a0c1ffed
TT
55892019-06-14 Tom Tromey <tromey@adacore.com>
5590
5591 * source.c (find_and_open_source): Respect basenames_may_differ.
5592
7c39e397
AB
55932019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
5594
5595 * annotate.c (annotate_breakpoints_invalid): Make use of
5596 scoped_restore_terminal_state.
5597 (annotate_frames_invalid): Likewise.
5598
f411722c
TT
55992019-06-14 Tom Tromey <tromey@adacore.com>
5600
5601 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5602 allow assignment to an internalvar.
5603
4268ec18
TT
56042019-06-14 Tom Tromey <tromey@adacore.com>
5605
5606 * ada-lex.l: Allow "_" in attribute names.
5607
abdb711e
TT
56082019-06-14 Tom Tromey <tromey@adacore.com>
5609
5610 PR gdb/24653:
5611 * regcache.c (registers_changed): Don't call alloca.
5612 * top.c (execute_command): Don't call alloca.
5613
4c048731
PA
56142019-06-13 Pedro Alves <palves@redhat.com>
5615
5616 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5617 'expression'. When parsing an expression, error out if there's
5618 junk after "unlimited".
5619 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5620 (do_set_command): Adjust calls to is_unlimited_literal.
5621
66eb1ed3
PA
56222019-06-13 Pedro Alves <palves@redhat.com>
5623
5624 * compile/compile.c (make_compile_options_def_group): Add braces
5625 around array_view initializer.
5626 * thread.c (make_thread_apply_all_options_def_group)
5627 (make_thread_apply_all_options_def_group): Likewise.
5628
3345721a
PA
56292019-06-13 Pedro Alves <palves@redhat.com>
5630
5631 * NEWS (New commands): Mention "maint test-options
5632 require-delimiter", "maint test-options unknown-is-error", "maint
5633 test-options unknown-is-operand" and "maint show
5634 test-options-completion-result".
5635 (New command options, command completion): New section.
5636 (Completion improvements): New section.
5637 Mention that you can abbreviate "unlimited".
5638
6206060d
PA
56392019-06-13 Pedro Alves <palves@redhat.com>
5640
5641 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5642 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5643 * unittests/cli-utils-selftests.c (test_parse_flags)
5644 (test_parse_flags_qcs): Delete.
5645 (test_cli_utils): Don't call deleted functions.
5646
6665660a
PA
56472019-06-13 Pedro Alves <palves@redhat.com>
5648
5649 * thread.c: Include "cli/cli-option.h".
5650 (tp_array_compar_ascending): Global.
5651 (tp_array_compar): Delete function.
5652 (tp_array_compar_ascending, tp_array_compar_descending): New
5653 functions.
5654 (ascending_option_def, qcs_flag_option_def)
5655 (thr_qcs_flags_option_defs)
5656 (make_thread_apply_all_options_def_group)
5657 (make_thread_apply_options_def_group): New.
5658 (thread_apply_all_command): Use gdb::option::process_options.
5659 (thread_apply_command_completer)
5660 (thread_apply_all_command_completer): New.
5661 (thread_apply_command): Use gdb::option::process_options.
5662 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5663 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
5664 to generate help text of "thread apply". Adjust "taas"'s help.
5665 * tid-parse.c (tid_range_parser::in_thread_range): New method.
5666 * tid-parse.h (tid_range_parser::in_thread_range): New method.
5667
f7e13587
PA
56682019-06-13 Pedro Alves <palves@redhat.com>
5669
5670 * thread.c (thread_apply_command): Check for invalid TID with
5671 isdigit instead of !isalpha.
5672
5d707134
PA
56732019-06-13 Pedro Alves <palves@redhat.com>
5674
5675 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5676 (validate_flags_qcs): New.
5677 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5678 (validate_flags_qcs): Declare.
5679 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5680 (make_frame_apply_options_def_group): New.
5681 (frame_apply_command_count): Process options with
5682 gdb::option::process_options.
5683 (frame_apply_completer): New.
5684 (frame_apply_level_completer, frame_apply_all_completer)
5685 (frame_apply_completer): New.
5686 (_initialize_stack): Update help of "frame apply", "frame apply
5687 level", "frame apply all" and "faas" to mention supported options
5688 and install command completers.
5689 * stack.h (frame_apply_all_completer): Declare.
5690 * thread.c: Include "stack.h".
5691 (tfaas_command): Add "--".
5692 (_initialize_thread): Update help "tfaas" to mention supported
5693 options and install command completer.
5694
272d4594
PA
56952019-06-13 Pedro Alves <palves@redhat.com>
5696
5697 * completer.c (complete_nested_command_line): New.
5698 (gdb_completion_word_break_characters_throw): Add assertion.
5699 * completer.h (complete_nested_command_line): Declare.
5700
90a1ef87
PA
57012019-06-13 Pedro Alves <palves@redhat.com>
5702
5703 * stack.c (parse_backtrace_qualifiers): New.
5704 (backtrace_command): Use it.
5705 (backtrace_command_completer): Complete on qualifiers.
5706
d4c16835
PA
57072019-06-13 Pedro Alves <palves@redhat.com>
5708
5709 * frame.c: Include "cli/cli-option.h.
5710 (user_set_backtrace_options): New.
5711 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5712 Delete.
5713 (get_prev_frame): Adjust.
5714 (boolean_option_def, uinteger_option_def)
5715 (set_backtrace_option_defs): New.
5716 (_initialize_frame): Adjust and use
5717 gdb::option::add_setshow_cmds_for_options to install "set
5718 backtrace past-main" and "set backtrace past-entry".
5719 * frame.h: Include "cli/cli-option.h".
5720 (struct frame_print_options): Forward declare.
5721 (print_frame_arguments_all, print_frame_arguments_scalars)
5722 (print_frame_arguments_none): Declare.
5723 (print_entry_values): Delete declaration.
5724 (struct frame_print_options, user_frame_print_options): New.
5725 (struct set_backtrace_options): New.
5726 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5727 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5728 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5729 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5730 (list_args_or_locals): Add frame_print_options parameter.
5731 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5732 * python/py-framefilter.c (enumerate_args): Pass down
5733 USER_FRAME_PRINT_OPTIONS.
5734 * stack.c: Include "cli/cli-option.h".
5735 (print_frame_arguments_all, print_frame_arguments_scalars)
5736 (print_frame_arguments_none): Declare.
5737 (print_raw_frame_arguments, print_entry_values): Delete.
5738 (user_frame_print_options): New.
5739 (boolean_option_def, enum_option_def, frame_print_option_defs):
5740 New.
5741 (struct backtrace_cmd_options): New.
5742 (bt_flag_option_def): New.
5743 (backtrace_command_option_defs): New.
5744 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5745 (print_frame_arg, read_frame_arg, print_frame_args)
5746 (print_frame_info, print_frame): Add frame_print_options parameter
5747 and use it.
5748 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5749 (backtrace_command_1): Add frame_print_options and
5750 backtrace_cmd_options parameters and use them.
5751 (make_backtrace_options_def_group): New.
5752 (backtrace_command): Process command options with
5753 gdb::option::process_options.
5754 (backtrace_command_completer): New.
5755 (_initialize_stack): Extend "backtrace"'s help to mention
5756 supported options. Install completer for "backtrace".
5757 Install some settings commands with add_setshow_cmds_for_options.
5758
2daf894e
PA
57592019-06-13 Pedro Alves <palves@redhat.com>
5760
5761 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5762 and that "set/show print raw frame-arguments" are now deprecated.
5763
5764 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5765 command.
5766 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5767 * stack.c (_initialize_stack): Install "set/show print
5768 raw-frame-arguments", and deprecate "set/show print raw
5769 frame-arguments".
5770 * valprint.c (_initialize_valprint): Deprecate "set/show print
5771 raw".
5772
e6ed716c
PA
57732019-06-13 Pedro Alves <palves@redhat.com>
5774
5775 * compile/compile.c (struct compile_options): New.
5776 (compile_flag_option_def, compile_command_option_defs)
5777 (make_compile_options_def_group): New.
5778 (compile_file_command): Handle options with
5779 gdb::option::process_options.
5780 (compile_file_command_completer): New function.
5781 (compile_code_command): Handle options with
5782 gdb::option::process_options.
5783 (compile_code_command_completer): New function.
5784 (_initialize_compiler): Install completers for "compile code" and
5785 "compile file". Mention available options in "compile code" and
5786 "compile code"'s help.
5787 * completer.c (advance_to_completion_word): New, factored out from
5788 ...
5789 (advance_to_expression_complete_word_point): ... this.
5790 (advance_to_filename_complete_word_point): New.
5791 * completer.h (advance_to_filename_complete_word_point): New
5792 declaration.
5793
7d8062de
PA
57942019-06-13 Pedro Alves <palves@redhat.com>
5795
5796 * compile/compile.c: Include "cli/cli-option.h".
5797 (compile_print_value): Scope data pointer is now a
5798 value_print_options pointer; adjust.
5799 (compile_print_command): Process options. Scope data pointer is
5800 now a value_print_options pointer; adjust.
5801 (_initialize_compile): Update "compile print"'s help to include
5802 supported options. Install a completer for "compile print".
5803 * cp-valprint.c (show_vtblprint, show_objectprint)
5804 (show_static_field_print): Delete.
5805 (_initialize_cp_valprint): Don't install "set print
5806 static-members", "set print vtbl", "set print object" here.
5807 * printcmd.c: Include "cli/cli-option.h" and
5808 "common/gdb_optional.h".
5809 (print_command_parse_format): Rework to fill in a
5810 value_print_options instead of a format_data.
5811 (print_value): Change parameter type from format_data pointer to
5812 value_print_options reference. Adjust.
5813 (print_command_1): Process options. Adjust to pass down a
5814 value_print_options.
5815 (print_command_completer): New.
5816 (_initialize_printcmd): Install print_command_completer as
5817 handle_brkchars completer for the "print" command. Update
5818 "print"'s help to include supported options.
5819 * valprint.c: Include "cli/cli-option.h".
5820 (show_vtblprint, show_objectprint, show_static_field_print): Moved
5821 here from cp-valprint.c.
5822 (boolean_option_def, uinteger_option_def)
5823 (value_print_option_defs, make_value_print_options_def_group):
5824 New. Use gdb::option::add_setshow_cmds_for_options to install
5825 "set print elements", "set print null-stop", "set print repeats",
5826 "set print pretty", "set print union", "set print array", "set
5827 print address", "set print symbol", "set print array-indexes".
5828 * valprint.h: Include <string> and "cli/cli-option.h".
5829 (make_value_print_options_def_group): Declare.
5830 (print_value): Change parameter type from format_data pointer to
5831 value_print_options reference.
5832 (print_command_completer): Declare.
5833
9d0faba9
PA
58342019-06-13 Pedro Alves <palves@redhat.com>
5835
5836 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5837 (COMMON_SFILES): Add maint-test-settings.c.
5838 * cli/cli-decode.c (boolean_enums): New global, factored out from
5839 ...
5840 (add_setshow_boolean_cmd): ... here.
5841 * cli/cli-decode.h (boolean_enums): Declare.
5842 * cli/cli-option.c: New file.
5843 * cli/cli-option.h: New file.
5844 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5845 factored out from ...
5846 (parse_cli_boolean_value(const char *)): ... this.
5847 (is_unlimited_literal): Change parameter type to pointer to
5848 pointer. Adjust and advance ARG pointer.
5849 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5850 (parse_cli_var_enum): New, factored out from ...
5851 (do_set_command): ... this. Adjust.
5852 * cli/cli-setshow.h (parse_cli_boolean_value)
5853 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5854 (parse_cli_var_enum): Declare.
5855 * cli/cli-utils.c: Include "cli/cli-option.h".
5856 (get_ulongest): New.
5857 * cli/cli-utils.h (get_ulongest): Declare.
5858 (check_for_argument): New overloads.
5859 * maint-test-options.c: New file.
5860
2c722807
PA
58612019-06-13 Pedro Alves <palves@redhat.com>
5862
5863 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5864 parse a range if "-" is at the end of the string.
5865
dee7b4c8
PA
58662019-06-13 Pedro Alves <palves@redhat.com>
5867
5868 * cli/cli-setshow.c (parse_auto_binary_operation)
5869 (parse_cli_boolean_value): Don't allow "o".
5870
dca0f6c0
PA
58712019-06-13 Pedro Alves <palves@redhat.com>
5872
5873 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5874 * NEWS: Mention maint test-settings KIND.
5875 * maint-test-settings.c: New file.
5876
597bf39d
PA
58772019-06-13 Pedro Alves <palves@redhat.com>
5878
5879 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5880 completer.
5881 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5882 "set" completers.
5883
48c410fb
PA
58842019-06-13 Pedro Alves <palves@redhat.com>
5885
5886 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5887 after item.
5888
93bcb043
PA
58892019-06-13 Pedro Alves <palves@redhat.com>
5890
5891 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5892
cbba3ecd
PA
58932019-06-13 Pedro Alves <palves@redhat.com>
5894
5895 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5896 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5897 call.
5898 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5899 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5900 calls.
5901 (check_for_argument): Skip spaces after argument.
5902
b9a3f842
PA
59032019-06-13 Pedro Alves <palves@redhat.com>
5904
5905 * thread.c (thread_apply_command): Adjust TID parsing.
5906 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5907 detected before end of string.
5908 (tid_is_in_list): Error out if LIST is invalid.
5909
3844e605
PA
59102019-06-13 Pedro Alves <palves@redhat.com>
5911
5912 * completer.c (complete_line_internal_1): Rewind completion word
5913 point.
5914 (completion_tracker::advance_custom_word_point_by): Change
5915 parameter type to int.
5916 * completer.h (completion_tracker::advance_custom_word_point_by):
5917 Likewise.
5918
00b56dbe
PA
59192019-06-13 Pedro Alves <palves@redhat.com>
5920
5921 * completer.c (advance_to_completion_word): Handle delimiters.
5922
d106773e
PA
59232019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
5924
5925 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5926
08f10e02
TT
59272019-06-11 Tom Tromey <tom@tromey.com>
5928
5929 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5930 (xmalloc_failed): Move to alloc.c.
5931 * alloc.c: New file.
5932 * Makefile.in (COMMON_SFILES): Add alloc.c.
5933
1c7fe951
TT
59342019-06-11 Tom Tromey <tom@tromey.com>
5935
5936 * nat/linux-waitpid.c: Don't include server.h.
5937 (linux_debug): Remove.
5938 (my_waitpid): Update.
5939
89549d7f
TT
59402019-06-11 Tom Tromey <tromey@adacore.com>
5941
5942 * infcall.c (_initialize_infcall): Remove trailing newline from
5943 help.
5944 * user-regs.c (_initialize_user_regs): Remove trailing newline
5945 from help.
5946 * typeprint.c (_initialize_typeprint): Remove trailing newline
5947 from help.
5948 * reverse.c (_initialize_reverse): Remove trailing newlines from
5949 help.
5950 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5951 from help.
5952 * language.c (add_set_language_command): Remove trailing newline
5953 from help.
5954 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5955 help.
5956 * disasm.c (_initialize_disasm): Remove trailing newline from
5957 help.
5958 * top.c (init_main): Remove trailing newline from help.
5959 * interps.c (_initialize_interpreter): Remove trailing newline
5960 from help.
5961 * btrace.c (_initialize_btrace): Remove trailing newlines from
5962 help.
5963 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5964 from help.
5965 * python/python.c (_initialize_python): Remove trailing newline
5966 from help.
5967 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5968 help.
5969 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5970 from help. Reformat some text.
5971 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5972 from help.
5973 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5974 newline from help.
5975
86108c13
TT
59762019-06-11 Tom Tromey <tromey@adacore.com>
5977
5978 * darwin-nat.c (darwin_decode_exception_message)
5979 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5980
a7067863
AB
59812019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5982
5983 * valops.c (value_slice): Check for not allocated or not
5984 associated values.
5985
9ab08412
TV
59862019-06-10 Tom de Vries <tdevries@suse.de>
5987
5988 PR gdb/24618
5989 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5990 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5991 invalid.
5992
f19e22e9
TV
59932019-06-10 Tom de Vries <tdevries@suse.de>
5994
5995 PR gdb/24611
5996 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5997 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5998
e99f9db0
TV
59992019-06-10 Tom de Vries <tdevries@suse.de>
6000
6001 PR symtab/24545
6002 * symtab.c (struct demangled_name_entry): Add language field.
6003 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
6004 static minimal symbol". Set and use language field.
6005
9bf7038b
TT
60062019-06-10 Tom Tromey <tromey@adacore.com>
6007
6008 * ada-lang.c (_initialize_ada_language): Update help text.
6009
422186a9
TT
60102019-06-10 Tom Tromey <tromey@adacore.com>
6011
6012 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6013 with a newline.
6014 * guile/guile.c (handle_boot_error): Don't end warning with a
6015 newline.
6016 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6017 warning with a newline.
6018 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6019 newline.
6020 (s12z_frame_cache): Likewise.
6021 * dwarf-index-cache.c (index_cache::store): Don't end warning with
6022 a newline.
6023 * solib-svr4.c (disable_probes_interface): Don't end warning with
6024 a newline.
6025 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6026 newline.
6027 * python/python.c (do_finish_initialization): Don't end warning
6028 with a newline.
6029
25ce02ee
TT
60302019-06-10 Tom Tromey <tom@tromey.com>
6031
6032 * python/py-breakpoint.c (gdbpy_breakpoint_created)
6033 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6034 gdbpy_enter.
6035
caa429d8
TT
60362019-06-10 Tom Tromey <tromey@adacore.com>
6037
6038 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6039 data.
6040 (elf_new_init): Don't call stabsread_new_init.
6041 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6042 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
6043 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6044
81873cc8
TV
60452019-06-10 Tom de Vries <tdevries@suse.de>
6046
6047 PR symtab/16264
6048 PR symtab/24517
6049 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6050
4fa0265e
РИ
60512019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
6052
6053 * source.c (find_and_open_source): Also rewrite relative file
6054 names.
6055
1a3da2cd
AB
60562019-04-26 Amos Bird <amosbird@gmail.com>
6057
6058 * annotate.c (annotate_thread_exited): Add "thread-exited"
6059 annotation.
6060
3847a7bf
TT
60612019-06-06 Tom Tromey <tromey@adacore.com>
6062
6063 * maint.h (class scoped_command_stats): Use
6064 DISABLE_COPY_AND_ASSIGN.
6065 <print_time>: New method.
6066 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6067 print_time.
6068 (scoped_command_stats::print_time): New method.
6069
312617a3
AB
60702019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
6071
6072 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6073 instructions of lengths 6 or 8 bytes.
6074
b02f78f9
PA
60752019-06-04 Pedro Alves <palves@redhat.com>
6076
6077 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6078
6079 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6080 * breakpoint.c (condition_completer): Likewise.
6081 * cli/cli-dump.c (scan_expression): Likewise.
6082 * common/filestuff.c (mkdir_recursive): Likewise.
6083 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6084 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6085 (gdb_abspath): Likewise.
6086 * compile/compile-cplus-types.c
6087 (compile_cplus_instance::decl_name): Likewise.
6088 * completer.c (complete_explicit_location):
6089 (signal_completer, reg_or_group_completer_1): Likewise.
6090 * cp-support.c (cp_remove_params_if_any): Likewise.
6091 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6092 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6093 * infcmd.c (strip_bg_char): Likewise.
6094 * linespec.c (copy_token_string): Likewise.
6095 * mi/mi-main.c (output_cores): Likewise.
6096 * psymtab.c (psymtab_search_name):
6097 * symfile.c (test_set_ext_lang_command): Likewise.
6098 * target.c (target_fileio_read_stralloc): Likewise.
6099 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6100 * value.c (complete_internalvar): Likewise.
6101
e1f2e1a2
CB
61022019-06-04 Christian Biesinger <cbiesinger@google.com>
6103
6104 Add objfile property to gdb.Type.
d3238f7d
PA
6105 * NEWS: Mention Python API addition.
6106 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 6107
e664d728
PW
61082019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6109
6110 * NEWS: Mention the new set|show style [title|highlight].
6111 Mention changes to "show style", "help" and "apropos".
6112
66d8c862
PW
61132019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6114
6115 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6116 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
6117 instead of print_help_for_command.
6118 (print_doc_of_command): New function.
6119 (help_list): Add 'apropos -v word' suggestion.
6120 (print_help_for_command): Style the command name using title style.
6121 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6122 (_initialize_cli_cmds): Describe -v in apropos_command help.
6123
9303eb2f
PW
61242019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6125
6126 * cli/cli-style.h (cli_style_option): Add name in constructor,
6127 add m_name class member, add constructor with intensity,
6128 add name class function.
6129 (cli_style_option::add_setshow_commands): Remove name argument.
6130 (highlight_style, title_style): New styles.
6131 * cli/cli-style.c (do_show): New function that shows a style
6132 characteristic styling the style name with itself.
6133 (set_style_name): New function.
6134 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6135 Update all callers according to the changes in cli/cli-style.h.
6136 * utils.h (fputs_highlighted): New function.
6137 * utils.c (fputs_highlighted): Likewise.
6138
e2c52041
PW
61392019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6140
6141 * NEWS: Mention new pipe command and new convenience variables.
6142
947d3946
PW
61432019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6144
6145 * cli/cli-cmds.c (pipe_command): New function.
6146 (_initialize_cli_cmds): Call add_com for pipe_command.
6147 Define | as an alias for pipe.
6148 (exit_status_set_internal_vars): New function.
6149 (shell_escape): Call exit_status_set_internal_vars.
6150 cli/cli-decode.c (find_command_name_length): Recognize | as
6151 a single character command.
6152
b8fd0918
PW
61532019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6154
6155 * gdbcmd.h (execute_command_to_ui_file): New declaration.
6156 top.c (execute_command_to_ui_file): New function, mostly a copy
6157 of execute_command_to_string.
6158 (execute_command_to_string): Implement by calling
6159 execute_command_to_ui_file.
6160
68bb5386
PW
61612019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6162
6163 * top.h (saved_command_line): Remove declaration.
6164 * top.c (previous_saved_command_line, previous_repeat_arguments):
6165 New variables.
6166 (saved_command_line): Make static, define together with other
6167 'repeat variables'.
6168 (dont_repeat): Clear repeat_arguments.
6169 (repeat_previous, get_saved_command_line, save_command_line):
6170 New functions.
6171 (gdb_init): Initialize saved_command_line
6172 and previous_saved_command_line.
6173 * main.c (captured_main_1): Remove saved_command_line initialization.
6174 * event-top.c (handle_line_of_input): Update to use
6175 the new 'repeat' related functions instead of direct access to
6176 saved_command_line.
6177 * command.h (repeat_previous, get_saved_command_line,
6178 save_command_line): New declarations.
6179 (dont_repeat): Add comment.
6180
bfcdb852
TT
61812019-05-30 Tom Tromey <tromey@adacore.com>
6182
6183 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6184 Fix comment.
6185 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6186
0ef209f2
JV
61872019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
6188
6189 PR cli/24587
6190 * completer.c (complete): Initialize variable word.
6191
955b06fa
SDJ
61922019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
6193
6194 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6195 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6196 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6197 'body' is NULL to the outter 'if', protecting the '!is_define'
6198 situation as well.
6199
fa9c3fa0
TT
62002019-05-29 Tom Tromey <tromey@adacore.com>
6201
6202 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6203 (dwarf_unknown): New function.
6204 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6205 (dwarf_type_encoding_name): Use dwarf_unknown.
6206
4330d61d
TT
62072019-05-29 Tom Tromey <tromey@adacore.com>
6208
6209 PR c++/20020:
6210 * cp-valprint.c (cp_print_value_fields): Call
6211 cp_print_static_field inside "try".
6212
33a6bc35
TT
62132019-05-29 Tom Tromey <tromey@adacore.com>
6214
6215 * inflow.c (struct terminal_info): Add default operator=.
6216 * configure: Rebuild.
6217 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6218 -Wdeprecated-copy-dtor, -Wredundant-move.
6219
000439d5
TT
62202019-05-29 Tom Tromey <tromey@adacore.com>
6221
6222 * NEWS: Add entry.
6223 * infcmd.c (print_return_value_1): Handle finish_print
6224 option.
6225 (show_print_finish): New function.
6226 (_initialize_infcmd): Add "set/show print finish" commands.
6227 * valprint.c (user_print_options): Initialize new member.
6228 * valprint.h (struct value_print_options) <finish_print>: New
6229 member.
6230
c0e70c62
TT
62312019-05-28 Tom Tromey <tromey@adacore.com>
6232
6233 * ada-lang.c (ada_remove_Xbn_suffix)
6234 (find_old_style_renaming_symbol)
6235 (parse_old_style_renaming): Remove.
6236 (ada_find_renaming_symbol): Don't call
6237 find_old_style_renaming_symbol.
6238 (ada_is_renaming_symbol): Rename from
6239 ada_find_renaming_symbol. Remove "block" parameter. Return
6240 bool. Now static.
6241 (ada_read_var_value): Update and simplify.
6242 * ada-exp.y (write_var_or_type): Remove old code.
6243
766f8836
AH
62442019-05-28 Alan Hayward <alan.hayward@arm.com>
6245
6246 * event-top.c: Remove include comment.
6247 * inflow.c (class scoped_ignore_sigttou): Move from here...
6248 * inflow.h (class scoped_ignore_sigttou): ...to here.
6249 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6250 * top.c: Remove include comment.
6251
eb41253a
TT
62522019-05-27 Tom Tromey <tom@tromey.com>
6253
6254 * NEWS: Fix typo.
6255
4ca51187
TT
62562019-05-22 Tom Tromey <tromey@adacore.com>
6257
6258 * target.c (target_follow_exec): Constify parameter.
6259 * target-delegates.c: Rebuild.
6260 * remote.c (remote_target::follow_exec): Constify parameter.
6261 * infrun.c (follow_exec): Constify parameter.
6262 * target.h (struct target_ops) <follow_exec>: Constify parameter.
6263 (target_follow_exec): Likewise.
6264
8fca4da0
AH
62652019-05-22 Alan Hayward <alan.hayward@arm.com>
6266
6267 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6268 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6269
b7060614
AH
62702019-05-22 Alan Hayward <alan.hayward@arm.com>
6271
6272 * NEWS: Add debugredirect and testsuite sections.
6273
0a5954bd
SC
62742019-05-22 Simon Cook <simon.cook@embecosm.com>
6275
6276 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6277 target descriptions using exclusively floating point register name
6278 aliases.
6279
dc42e902
AB
62802019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
6281
6282 PR gdb/18644:
6283 * f-lang.c (build_fortran_types): Handle the case where
6284 gdbarch_floatformat_for_type returns a nullptr.
6285
fb7806c7
TV
62862019-05-21 Tom de Vries <tdevries@suse.de>
6287
6288 PR cli/24587
6289 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6290
34d11c68
AB
62912019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6292
6293 PR gdb/18644:
6294 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6295 16-byte floats.
6296 * i386-tdep.c (i386_floatformat_for_type): Use
6297 floatformats_ia64_quad for the 16-byte floating point component
6298 within a fortran 32-byte complex number.
6299
122cf0f2
AB
63002019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6301
6302 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6303 delete default constructor.
6304 (find_partial_die): Update to return const struct.
6305 (partial_die_parent_scope): Move variable declaration into scope
6306 of its use and change its type to auto.
6307 (guess_partial_die_structure_name): Likewise.
6308 (partial_die_info::fixup): Likewise.
6309
33d0e35a
TT
63102019-05-17 Tom Tromey <tromey@adacore.com>
6311
6312 * source.c (find_and_open_source): Remove cast.
6313
a45575b0
TT
63142019-05-17 Tom Tromey <tromey@adacore.com>
6315
6316 * annotate.c (annotate_source): Make "filename" const.
6317 * annotate.h (annotate_source): Use const.
6318
81f47ac2
AH
63192019-05-17 Alan Hayward <alan.hayward@arm.com>
6320
6321 * disasm.c (set_disassembler_options): Send errors to stderr.
6322
ca1285d1
AH
63232019-05-17 Alan Hayward <alan.hayward@arm.com>
6324
6325 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6326 (cli_interp_base::set_logging): Check debug_redirect.
6327 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6328 * cli/cli-logging.c (debug_redirect): Add static variable.
6329 (pop_output_files): Add default param.
6330 (handle_redirections): Print debug setting.
6331 (show_logging_command): Likewise.
6332 (_initialize_cli_logging): Add debugredirect command.
6333 * interps.c (current_interp_set_logging): Add debug_redirect
6334 parameter.
6335 * interps.h (set_logging): Add debug_redirect parameter.
6336 (current_interp_set_logging): Likewise.
6337 * mi/mi-common.h: Likewise.
6338 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6339
63402019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
6341 Tom Tromey <tromey@adacore.com>
6342
6343 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6344 directly.
6345 * cli/cli-interp.h (make_logging_output): Remove declaration.
6346 * cli/cli-logging.c (make_logging_output): Remove function.
6347 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6348 directly.
6349 * ui-file.c (tee_file::tee_file): Remove bools.
6350 (tee_file::~tee_file): Remove deletes.
6351 * ui-file.h (tee_file): Remove bools.
6352
26648588
JV
63532019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6354
6355 * mi/mi-cmds.h (mi_cmd_complete): New function.
6356 * mi/mi-main.c (mi_cmd_complete): Likewise.
6357 * mi/mi-cmds.c: Define new MI command -complete.
6358 * NEWS: Mention new -complete command.
6359
6e035501
JV
63602019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6361
6362 * completer.h (complete): New function.
6363 * completer.c (complete): Likewise.
6364 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6365 function defined in completer.h.
6366
7d0e2ece
JV
63672019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6368
e79be6e5 6369 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 6370
fb816e8b
TV
63712019-05-17 Tom de Vries <tdevries@suse.de>
6372
6373 PR gdb/24094
6374 * dwarf2read.c (struct cu_partial_die_info): New struct.
6375 (find_partial_die): Return cu_partial_die_info.
6376 (partial_die_parent_scope, guess_partial_die_structure_name)
6377 (partial_die_info::fixup): Handle new return type of find_partial_die.
6378
677052f2
SDJ
63792019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6380
a1726c38 6381 PR breakpoints/24541
677052f2
SDJ
6382 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6383 "std::string", simplifying the algorithm.
6384
f3da9116
SDJ
63852019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6386
6387 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6388 (stap_static_probe_ops::get_probes): Likewise.
6389
f1bb75ab
SDJ
63902019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6391
6392 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6393 '-')" and "else if".
6394 (stap_parse_single_operand): Join checks for
6395 "gdbarch_stap_parse_special_token_p" and
6396 "gdbarch_stap_parse_special_token" in the same "if" statement.
6397 Invert check when verifying for operation on register
6398 displacement.
6399
3ca58cde
SDJ
64002019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6401
6402 * stap-probe.c (stap_get_opcode): Update comment.
6403 (stap_get_expected_argument_type): Likewise.
6404 (handle_stap_probe): Likewise.
6405
af2d9bee
SDJ
64062019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6407
6408 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6409 return type to 'bool'. Adjust comment. Use 'bool' when
6410 appropriate.
6411 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6412 * stap-probe.c (stap_parse_argument_1): Likewise.
6413 (stap_is_operator): Likewise.
6414 (stap_is_generic_prefix): Likewise.
6415 (stap_is_register_prefix): Likewise.
6416 (stap_is_register_indirection_prefix): Likewise.
6417 (stap_is_integer_prefix): Likewise.
6418 (stap_generic_check_suffix): Likewise.
6419 (stap_check_integer_suffix): Likewise.
6420 (stap_check_register_suffix): Likewise.
6421 (stap_check_register_indirection_suffix): Likewise.
6422 (stap_parse_register_operand): Likewise.
6423 (stap_parse_single_operand): Likewise.
6424 (stap_parse_argument_1): Likewise.
6425 (stap_probe::get_argument_count): Likewise.
6426 (stap_is_operator): Likewise.
6427
61c9c421
TT
64282019-05-16 Tom Tromey <tromey@adacore.com>
6429
6430 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6431 keyword to foreach.
6432
9ddc1af1
SM
64332019-05-15 Simon Marchi <simon.marchi@efficios.com>
6434
6435 * linux-thread-db.c (try_thread_db_load_1): Change return type
6436 to bool.
6437 (try_thread_db_load): Likewise.
6438 (try_thread_db_load_from_pdir_1): Likewise.
6439 (try_thread_db_load_from_pdir): Likewise.
6440 (try_thread_db_load_from_sdir): Likewise.
6441 (try_thread_db_load_from_dir): Likewise.
6442 (thread_db_load_search): Likewise.
6443 (has_libpthread): Likewise.
6444 (thread_db_load): Likewise.
6445
7bede828
SDJ
64462019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6447
6448 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6449 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6450 NULL, and complain/return if that's the case.
6451
c5358db4
JD
64522019-05-15 John Darrington <john@darrington.wattle.id.au>
6453
6454 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6455 (advance, posn, abstract_read_memory): New functions.
6456 [struct mem_read_abstraction]: New struct.
6457 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6458
c408a94f
TT
64592019-05-14 Tom Tromey <tromey@adacore.com>
6460
6461 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6462 value is not lval_memory.
6463
e7bd7fba
TT
64642019-05-14 Tom Tromey <tromey@adacore.com>
6465
6466 * solib.c (info_sharedlibrary_command): Style the file name.
6467
a6d0f249
AH
64682019-05-14 Alan Hayward <alan.hayward@arm.com>
6469
6470 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6471 (aarch64_vnv_type): Likewise.
6472 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6473 * common/tdesc.c: Likewise.
6474 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6475 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6476 * features/aarch64-fpu.xml: Add ieee half view.
6477 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6478 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6479 * gdbtypes.h (struct builtin_type): Likewise.
6480 (struct objfile_type): Likewise.
6481
66b8bb74
SM
64822019-05-12 Paul Naert <paul.naert@polymtl.ca>
6483
6484 * language.c (language_sniff_from_mangled_name): Fix "langauge"
6485 typo.
6486 * location.h (string_to_event_location): Likewise.
6487
21c219fd
JB
64882019-05-11 Joel Brobecker <brobecker@adacore.com>
6489
6490 GDB 8.3 released.
6491
13674803
SM
64922019-05-10 Simon Marchi <simon.marchi@efficios.com>
6493
6494 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6495 New variable declaration.
6496 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6497 New variable.
6498 (print_one_breakpoint): Use ui_out::test_flags and new global
6499 variable to compute use_fixed_output.
6500 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6501 Remove.
6502 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6503 (mi_multi_location_breakpoint_output_fixed): Remove.
6504 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6505 new variable.
6506 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6507 fix_multi_location_breakpoint_output flag if version >= 3.
6508 * ui-out.h (enum ui_out_flag)
6509 <fix_multi_location_breakpoint_output>: New enumerator.
6510
a9eac7f9
SM
65112019-05-10 Simon Marchi <simon.marchi@efficios.com>
6512
6513 * contrib/cc-with-tweaks.sh: Validate dwz's work.
6514
71bed2db
TT
65152019-05-10 Tom Tromey <tromey@adacore.com>
6516
6517 * ada-lang.c (catch_ada_completer): New function.
6518 (_initialize_ada_language): Use it.
6519
24c54127
TT
65202019-05-10 Tom Tromey <tromey@adacore.com>
6521
6522 * thread.c (print_thread_info): Make "requested_threads" const.
6523 * gdbthread.h (print_thread_info): Make "requested_threads"
6524 const.
6525 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6526 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6527
7a102139
TT
65282019-05-08 Tom Tromey <tom@tromey.com>
6529
6530 * gdbtypes.c (objfile_type_data): Change type.
6531 (objfile_type, _initialize_gdbtypes): Update.
6532
924d79e2
TT
65332019-05-08 Tom Tromey <tom@tromey.com>
6534
6535 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6536 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6537 (_initialize_dwarf2_frame): Update.
6538
4c58e337
TT
65392019-05-08 Tom Tromey <tom@tromey.com>
6540
6541 * objc-lang.c (objc_objfile_data): Change type.
6542 (find_methods): Update.
6543 (_initialize_objc_lang): Remove.
6544
d772d2ab
TT
65452019-05-08 Tom Tromey <tom@tromey.com>
6546
6547 * stabsread.c (rs6000_builtin_type_data): Change type.
6548 (rs6000_builtin_type, _initialize_stabsread): Update.
6549
d11d83f4
TT
65502019-05-08 Tom Tromey <tom@tromey.com>
6551
6552 * mips-tdep.c (mips_pdr_data): Remove.
6553 (_initialize_mips_tdep): Update.
6554
9a73f0ad
TT
65552019-05-08 Tom Tromey <tom@tromey.com>
6556
6557 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6558 (hppa_init_objfile_priv_data, read_unwind_info)
6559 (find_unwind_entry, _initialize_hppa_tdep): Update.
6560
8127a2fa
TT
65612019-05-08 Tom Tromey <tom@tromey.com>
6562
6563 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6564 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
6565 on obstack.
6566 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6567
91d3055d
TT
65682019-05-08 Tom Tromey <tom@tromey.com>
6569
6570 * mdebugread.c (basic_type_data): Change type.
6571 (basic_type, _initialize_mdebugread): Update.
6572
31930bd3
TT
65732019-05-08 Tom Tromey <tom@tromey.com>
6574
6575 * common/gdb_unique_ptr.h (struct noop_deleter): New.
6576
bdb3ed9e
TT
65772019-05-08 Tom Tromey <tom@tromey.com>
6578
6579 * nto-tdep.c (nto_inferior_data_reg): Change type.
6580 (nto_inferior_data): Update.
6581 (nto_inferior_data_cleanup, nto_new_inferior_data)
6582 (_initialize_nto_tdep): Remove.
6583 * nto-tdep.h (struct nto_inferior_data): Add initializers.
6584
f37b313d
TT
65852019-05-08 Tom Tromey <tom@tromey.com>
6586
6587 * ada-lang.c (struct ada_inferior_data): Add initializers.
6588 (ada_inferior_data): Change type.
6589 (ada_inferior_data_cleanup): Remove.
6590 (get_ada_inferior_data, ada_inferior_exit)
6591 (struct ada_pspace_data): Add initializers, destructor.
6592 (ada_pspace_data_handle): Change type.
6593 (get_ada_pspace_data): Update.
6594 (ada_pspace_data_cleanup): Remove.
6595
24699405
TT
65962019-05-08 Tom Tromey <tom@tromey.com>
6597
6598 * coffread.c (struct coff_symfile_info): Add initializers.
6599 (coff_objfile_data_key): Move lower. Change type.
6600 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6601 Update.
6602 (coff_free_info): Remove.
6603
d4e05d2f
TT
66042019-05-08 Tom Tromey <tom@tromey.com>
6605
6606 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6607 (fbsd_pspace_data_handle): Move lower. Change type.
6608 (get_fbsd_pspace_data): Update.
6609 (fbsd_pspace_data_cleanup): Remove.
6610 (_initialize_fbsd_tdep): Update.
6611
14ef6690
TT
66122019-05-08 Tom Tromey <tom@tromey.com>
6613
6614 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6615 (get_ada_tasks_pspace_data): Update.
6616 (ada_tasks_pspace_data_cleanup): Remove.
6617 (_initialize_tasks): Update.
6618 (ada_tasks_inferior_data_handle): Change type.
6619 (get_ada_tasks_inferior_data): Update.
6620 (ada_tasks_inferior_data_cleanup): Remove.
6621 (struct ada_tasks_pspace_data): Add initializers.
6622
814cf43a
TT
66232019-05-08 Tom Tromey <tom@tromey.com>
6624
6625 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6626 * symfile-debug.c (debug_sym_get_probes): Change type.
6627 * stap-probe.c (handle_stap_probe):
6628 (stap_static_probe_ops::get_probes): Change type.
6629 * probe.h (class static_probe_ops) <get_probes>: Change type.
6630 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6631 (parse_probes_in_pspace): Update.
6632 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6633 Update.
6634 (any_static_probe_ops::get_probes): Change type.
6635 * elfread.c (elfread_data): New typedef.
6636 (probe_key): Change type.
6637 (elf_get_probes): Likewise. Update.
6638 (probe_key_free): Remove.
6639 (_initialize_elfread): Update.
6640 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6641 Change type.
6642 (dtrace_process_dof_probe, dtrace_process_dof)
6643 (dtrace_static_probe_ops::get_probe): Change type.
6644
02dc647e
TT
66452019-05-08 Tom Tromey <tom@tromey.com>
6646
6647 * xcoffread.c (struct xcoff_symfile_info): Rename from
6648 coff_symfile_info. Add initializers.
6649 (xcoff_objfile_data_key): Move lower. Change type.
6650 (XCOFF_DATA): Rewrite.
6651 (xcoff_free_info): Remove.
6652 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6653 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6654 (xcoff_initial_scan): Update.
6655
09232438
TT
66562019-05-08 Tom Tromey <tom@tromey.com>
6657
6658 * solib-svr4.c (struct svr4_info): Add initializers and
6659 destructor.
6660 <probes_table>: Now an htab_up.
6661 (solib_svr4_pspace_data): Change type.
6662 (free_probes_table): Simplify.
6663 (~svr4_info): Rename from svr4_pspace_data_cleanup.
6664 (get_svr4_info, probes_table_htab_remove_objfile_probes)
6665 (probes_table_remove_objfile_probes, register_solib_event_probe)
6666 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6667 (_initialize_svr4_solib): Update.
6668
7b4a314f
TT
66692019-05-08 Tom Tromey <tom@tromey.com>
6670
6671 * remote.c (remote_pspace_data): Change type.
6672 (remote_pspace_data_cleanup): Remove.
6673 (get_remote_exec_file, set_pspace_remote_exec_file)
6674 (_initialize_remote): Update.
6675
51d3063a
TT
66762019-05-08 Tom Tromey <tom@tromey.com>
6677
6678 * breakpoint.c (breakpoint_objfile_key): Change type.
6679 (get_breakpoint_objfile_data): Update.
6680 (free_breakpoint_objfile_data): Remove.
6681 (_initialize_breakpoint): Update.
6682
89fb8848
TT
66832019-05-08 Tom Tromey <tom@tromey.com>
6684
6685 * linux-tdep.c (struct linux_info): Add initializers.
6686 (linux_inferior_data): Move. Change type.
6687 (invalidate_linux_cache_inf): Update.
6688 (linux_inferior_data_cleanup): Remove.
6689 (get_linux_inferior_data, _initialize_linux_tdep): Update.
6690
e9b89e2d
TT
66912019-05-08 Tom Tromey <tom@tromey.com>
6692
6693 * auxv.c (auxv_inferior_data): Move. Change type.
6694 (auxv_inferior_data_cleanup): Remove.
6695 (invalidate_auxv_cache_inf): Rewrite.
6696 (get_auxv_inferior_data, _initialize_auxv): Update.
6697
8c42777c
TT
66982019-05-08 Tom Tromey <tom@tromey.com>
6699
6700 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6701 (symfile_debug_objfile_data_key): Change type.
6702 (symfile_debug_installed, debug_qf_has_symbols)
6703 (debug_qf_find_last_source_symtab)
6704 (debug_qf_forget_cached_source_info)
6705 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6706 (debug_qf_print_stats, debug_qf_dump)
6707 (debug_qf_expand_symtabs_for_function)
6708 (debug_qf_expand_all_symtabs)
6709 (debug_qf_expand_symtabs_with_fullname)
6710 (debug_qf_map_matching_symbols)
6711 (debug_qf_expand_symtabs_matching)
6712 (debug_qf_find_pc_sect_compunit_symtab)
6713 (debug_qf_map_symbol_filenames)
6714 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6715 (debug_sym_new_init, debug_sym_init, debug_sym_read)
6716 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6717 (debug_sym_read_linetable, debug_sym_relocate): Update.
6718 (symfile_debug_free_objfile): Remove.
6719 (install_symfile_debug_logging, _initialize_symfile_debug):
6720 Update.
6721
5bfd760d
TT
67222019-05-08 Tom Tromey <tom@tromey.com>
6723
6724 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6725 allocate_on_obstack.
6726 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6727 (get_dwarf2_per_objfile): Update.
6728 (set_dwarf2_per_objfile): Remove.
6729 (dwarf2_has_info, dwarf2_get_section_info): Update.
6730 (dwarf2_free_objfile): Remove.
6731 (_initialize_dwarf2_read): Update.
6732
e85e19b4
TT
67332019-05-08 Tom Tromey <tom@tromey.com>
6734
6735 * auto-load.c (struct auto_load_pspace_info): Add destructor and
6736 initializers.
6737 <unsupported_script_warning_printed,
6738 script_not_found_warning_printed>: Now bool.
6739 (auto_load_pspace_data): Change type.
6740 (~auto_load_pspace_info): Rename from
6741 auto_load_pspace_data_cleanup.
6742 (get_auto_load_pspace_data, init_loaded_scripts_info)
6743 (clear_section_scripts, maybe_print_unsupported_script_warning)
6744 (maybe_print_script_not_found_warning, _initialize_auto_load):
6745 Update.
6746
f6aa7436
TT
67472019-05-08 Tom Tromey <tom@tromey.com>
6748
6749 * objfiles.c (objfile_pspace_info): Add destructor and
6750 initializers.
6751 (objfiles_pspace_data): Change type.
6752 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6753 (get_objfile_pspace_data): Update.
6754 (objfiles_bfd_data): Change type.
6755 (get_objfile_bfd_data): Update.
6756 (objfile_bfd_data_free, _initialize_objfiles): Remove.
6757
6ae614f6
TT
67582019-05-08 Tom Tromey <tom@tromey.com>
6759
6760 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6761 Change type.
6762 (get_catch_syscall_inferior_data): Update.
6763 (catch_syscall_inferior_data_cleanup): Remove.
6764 (_initialize_break_catch_syscall): Update.
6765
6509b8eb
TT
67662019-05-08 Tom Tromey <tom@tromey.com>
6767
6768 * inflow.c (struct terminal_info): Add destructor and
6769 initializers.
6770 (inflow_inferior_data): Change type.
6771 (~terminal_info): Rename from inflow_inferior_data_cleanup.
6772 (get_inflow_inferior_data, inflow_inferior_exit)
6773 (swap_terminal_info, _initialize_inflow): Update.
6774
35632941
TT
67752019-05-08 Tom Tromey <tom@tromey.com>
6776
6777 * target-dcache.c (target_dcache_cleanup): Remove.
6778 (target_dcache_aspace_key): Change type.
6779 (target_dcache_init_p, target_dcache_invalidate)
6780 (target_dcache_get, target_dcache_get_or_init)
6781 (_initialize_target_dcache): Update.
6782 * dcache.h (struct dcache_deleter): New.
6783
3017b94d
TT
67842019-05-08 Tom Tromey <tom@tromey.com>
6785
6786 * symtab.c (struct symbol_cache): Add destructor and
6787 initializers.
6788 (symbol_cache_key): Move. Change type.
6789 (make_symbol_cache, free_symbol_cache): Remove.
6790 (get_symbol_cache): Update.
6791 (symbol_cache_cleanup): Remove.
6792 (ALL_PSPACES, symbol_cache_flush)
6793 (maintenance_print_symbol_cache)
6794 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6795 Update.
6796
a32ad8c5
TT
67972019-05-08 Tom Tromey <tom@tromey.com>
6798
6799 * symtab.c (struct main_info): Add destructor and initializers.
6800 (main_progspace_key): Move. Change type.
6801 (get_main_info): Update.
6802 (main_info_cleanup): Remove.
6803 (_initialize_symtab): Update.
6804
5f6e90a0
TT
68052019-05-08 Tom Tromey <tom@tromey.com>
6806
6807 * registry.h (DECLARE_REGISTRY): Define the _key class.
6808
1bd0c6e4
AB
68092019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
6810
6811 * NEWS: Merge two 'New commands' sections.
6812
2228ef77
XR
68132019-05-08 Joel Brobecker <brobecker@adacore.com>
6814
6815 * ada-valprint.c (ada_val_print_gnat_array): Remove language
6816 parameter and use Ada language definition instead.
6817 (ada_val_print_ptr): Remove unused language parameter.
6818 (ada_val_print_num): Remove language parameter and use Ada language
6819 definition instead.
6820 (ada_val_print_enum, ada_val_print_flt): Remove unused language
6821 parameter.
6822 (ada_val_print_struct_union, ada_val_print_ref): Remove language
6823 parameter and use Ada language definition instead.
6824 (ada_val_print_1): Update all ada_val_print_xxx calls.
6825 Remove language parameter.
6826 (ada_val_print): Update ada_val_print_1 call.
6827
60fcc1c3
TT
68282019-05-08 Tom Tromey <tromey@adacore.com>
6829
6830 * remote.c (remote_hw_watchpoint_limit)
6831 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6832 Now static.
6833
ed2b7c17
TT
68342019-05-08 Tom Tromey <tromey@adacore.com>
6835
6836 * maint.c (_initialize_maint_cmds): Move initialization code to
6837 remote.c.
6838 (watchdog, show_watchdog): Move to remote.c.
6839 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
6840 "watchdog" static.
6841 (_initialize_remote): Move initialization code from maint.c.
6842 * defs.h (watchdog): Don't declare.
6843
b0be6c91
TT
68442019-05-08 Tom Tromey <tromey@adacore.com>
6845
6846 * tui/tui-interp.c: Include main.h.
6847 * interps.c: Include main.h.
6848 * main.h (interpreter_p): Declare.
6849 * defs.h (interpreter_p): Don't declare.
6850
587ee17b
TT
68512019-05-08 Tom Tromey <tromey@adacore.com>
6852
6853 * dwarf2loc.c: Include dwarf2read.h.
6854 * defs.h (read_unsigned_leb128): Don't declare.
6855 * dwarf2read.h (read_unsigned_leb128): Declare.
6856
ca1df239
TT
68572019-05-08 Tom Tromey <tromey@adacore.com>
6858
6859 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6860 method.
6861
99f20f08
TT
68622019-05-08 Tom Tromey <tromey@adacore.com>
6863
6864 * utils.c (fputs_maybe_filtered): Reset style after paging, even
6865 when no wrap column is set.
6866
80e55b13
TT
68672019-05-08 Tom Tromey <tromey@adacore.com>
6868
6869 * c-lang.c (c_get_string): Handle non-C-style arrays.
6870
9d3421af
TT
68712019-05-08 Tom Tromey <tromey@adacore.com>
6872
6873 * typeprint.c (print_offset_data::update): Print the bit offset,
6874 not the number of bits remaining.
6875
844333e2
TT
68762019-05-08 Tom Tromey <tromey@adacore.com>
6877
6878 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6879 padding at end of comment.
6880
988915ee
TT
68812019-05-08 Tom Tromey <tromey@adacore.com>
6882
6883 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6884 Compare main types.
6885
26bfd823
TT
68862019-05-06 Tom Tromey <tom@tromey.com>
6887
6888 * common/scoped_mmap.c: Include common-defs.h.
6889 * common/scoped_mmap.h: Don't include config.h.
6890
89055eaa
TT
68912019-05-04 Tom Tromey <tom@tromey.com>
6892
6893 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6894 (struct aarch64_call_info): Add initializers.
6895 <si>: Now a std::vector.
6896 (pass_on_stack, aarch64_push_dummy_call): Update.
6897
5da01df5
TT
68982019-05-04 Simon Marchi <simon.marchi@efficios.com>
6899 Tom Tromey <tom@tromey.com>
6900
6901 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6902 (ppc_threads): Now a std::vector. Now static.
6903 (hwdebug_find_thread_points_by_tid)
6904 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6905 Update.
6906
fbdf05a1
TT
69072019-05-04 Tom Tromey <tom@tromey.com>
6908
6909 * arc-tdep.c (arc_tdesc_init): Return bool.
6910
06d16ec9
TT
69112019-05-04 Tom Tromey <tom@tromey.com>
6912
6913 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6914 Use gdb_assert_not_reached.
6915
9c056022
TT
69162019-05-04 Tom Tromey <tom@tromey.com>
6917
6918 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6919 "false".
6920
fa9c2a59
TT
69212019-05-04 Tom Tromey <tom@tromey.com>
6922
6923 * arc-tdep.c (arc_tdesc_init): Use bool.
6924
e2eb806a
TT
69252019-05-04 Tom Tromey <tom@tromey.com>
6926
6927 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6928
6fe87677
TT
69292019-05-04 Tom Tromey <tom@tromey.com>
6930
6931 * cli/cli-cmds.c (valid_command_p): Return bool.
6932
7f008c9e
TT
69332019-05-04 Tom Tromey <tom@tromey.com>
6934
6935 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6936 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6937
b6484282
RT
69382019-05-04 Raul Tambre <raul@tambre.ee>
6939
6940 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6941 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6942 operator for comparison.
6943
af97b416
TT
69442019-05-04 Tom Tromey <tom@tromey.com>
6945
6946 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6947 (lookup_partial_symbol, print_partial_symbols)
6948 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6949 (psymbol_compare): Update.
6950 (add_psymbol_to_bcache): Clear the entire psymbol.
6951 (maintenance_check_psymtabs): Update.
6952 * psympriv.h (struct partial_symbol): Don't derive from
6953 general_symbol_info.
6954 <obj_section, unrelocated_address, address,
6955 set_unrelocated_address>: Update.
6956 <ginfo>: New member.
6957 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6958 (debug_names::write_psymbols): Update.
6959
9d6d4be8
TV
69602019-05-04 Tom de Vries <tdevries@suse.de>
6961
6962 * contrib/cc-with-tweaks.sh: Support -n arg.
6963
66452beb
PW
69642019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6965
6966 * corelow.c (core_target::detach): Ensure frame cache and
6967 register caches are cleared.
6968 inferior.c (exit_inferior_1): Likewise.
6969
bde09ab7
TT
69702019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6971 Tom Tromey <tom@tromey.com>
6972
6973 * dictionary.c (collate_pending_symbols_by_language): Remove
6974 "struct" from foreach.
6975 * symtab.c (lookup_global_symbol_from_objfile)
6976 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6977 foreach.
6978 * ser-tcp.c (net_open): Remove "struct" from foreach.
6979 * objfiles.c (objfile_relocate, objfile_rebase)
6980 (objfile_has_symbols): Remove "struct" from foreach.
6981 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6982 from foreach.
6983 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6984 foreach.
6985 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6986 "struct" from foreach.
6987 * ada-lang.c (create_excep_cond_exprs)
6988 (ada_exception_catchpoint_cond_string): Remove "struct" from
6989 foreach.
6990
222a8d25
TT
69912019-05-03 Tom Tromey <tromey@adacore.com>
6992
6993 * ada-exp.y (convert_char_literal): Check suffix of each
6994 enumerator.
6995
fcd60b84
DP
69962019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6997
6998 PR ada/21406:
6999 * ada-exp.y (yywrap): Don't define.
7000 * ada-lex.l (%option): Add noyywrap
7001 (yywrap): Remove.
7002
5f2459c2
EZ
70032019-05-03 Eli Zaretskii <eliz@gnu.org>
7004
353ea2d1
EZ
7005 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7006 _WIN32_WINNT to the XP level, unless already defined to a higher
7007 level.
7008
7009 * unittests/parse-connection-spec-selftests.c:
7010 * ser-tcp.c:
7011 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
7012 override.
7013
5f2459c2
EZ
7014 * symfile.c (find_separate_debug_file): Remove colon from the
7015 drive spec of DOS/Windows file names of the target, so that the
7016 file name produced from DEBUGDIR and the target's directory will
7017 be valid on DOS/Windows systems.
7018
80062eb9
AB
70192019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
7020
7021 * rust-lang.c (val_print_struct): Handle printing structures
7022 containing strings.
7023
b8c05e85
TT
70242019-05-02 Tom Tromey <tromey@adacore.com>
7025
7026 * valarith.c (_initialize_valarith): Remove.
7027
4504bbde
TT
70282019-05-01 Tom Tromey <tromey@adacore.com>
7029
7030 * ada-lang.c (ada_value_primitive_field): Treat more fields as
7031 bitfields.
7032
d48e62f4
TT
70332019-05-01 Tom Tromey <tromey@adacore.com>
7034
7035 * ada-lang.c (ada_value_assign): Correctly compute starting offset
7036 for big-endian copies.
7037
15f18d14
AT
70382019-04-30 Ali Tamur <tamur@google.com>
7039 * gdb/dwarf2read.c (read_3_bytes): New declaration.
7040 (read_attribute_value): Added DW_FORM_strx1-4 cases.
7041 (read_3_bytes): New function.
7042
ab4ee614
JB
70432019-04-30 Joel Brobecker <brobecker@adacore.com>
7044
7045 * windows-nat.c (main_thread_id): Delete.
7046 (handle_output_debug_string): Replace main_thread_id by
7047 current_event.dwThreadId.
7048 (fake_create_process): Likewise.
7049 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7050 Do not set main_thread_id.
7051 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7052 current_event.dwThreadId.
7053 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7054
8ed5b76e
JB
70552019-04-30 Joel Brobecker <brobecker@adacore.com>
7056
7057 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7058 Use current_event.dwThreadId instead of main_thread_id.
7059
2ff0a947
TT
70602019-04-30 Tom Tromey <tromey@adacore.com>
7061
7062 * ada-lang.c (ada_lookup_simple_minsyms): New function.
7063 (create_excep_cond_exprs): Iterate over program spaces.
7064 (ada_exception_catchpoint_cond_string): Examine all minimal
7065 symbols for exception types.
7066
a776957c
TT
70672019-04-30 Tom Tromey <tromey@adacore.com>
7068
7069 PR c++/24470:
7070 * dwarf2read.c (process_structure_scope): Handle case where type
7071 has template parameters but no symbol was created.
7072
bc68014d
AB
70732019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7074 Chris January <chris.january@arm.com>
7075
7076 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7077 qualifier.
7078 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7079
f1fdc960
AB
70802019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7081
7082 * f-typeprint.c (f_print_type): Update rules for printing
7083 whitespace.
7084 (f_type_print_varspec_suffix): Likewise.
7085
bf7a4de1
AB
70862019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7087 Chris January <chris.january@arm.com>
7088
7089 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7090 function arguments.
7091
bbe75b9d
AB
70922019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7093
7094 * f-lang.c (build_fortran_types): Change name of void type to
7095 lower case.
7096 * f-typeprint.c (f_type_print_base): Print the name of the void
7097 type, rather than a fixed string.
7098 * f-valprint.c (f_decorations): Use lower case void string.
7099
1db455a7
AB
71002019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7101 Chris January <chris.january@arm.com>
7102
7103 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7104 types for Fortran.
7105
b6d03bb2
AB
71062019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7107 Chris January <chris.january@arm.com>
7108 David Lecomber <david.lecomber@arm.com>
7109
7110 * f-exp.y (BINOP_INTRINSIC): New token.
7111 (exp): New parser rule handling BINOP_INTRINSIC.
7112 (f77_keywords): Add new builtin procedures.
7113 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7114 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7115 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7116 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7117 (print_unop_subexp_f): New function.
7118 (print_binop_subexp_f): New function.
7119 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7120 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7121 (dump_subexp_body_f): Likewise.
7122 (operator_check_f): Likewise.
7123 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7124 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7125
83228e93
AB
71262019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7127
7128 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7129 UNOP_KIND.
7130 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7131 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7132 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7133 (operator_length_f): New fuction.
7134 (print_subexp_f): New function.
7135 (op_name_f): New function.
7136 (dump_subexp_body_f): New function.
7137 (operator_check_f): New function.
7138 (exp_descriptor_f): Replace standard expression handling functions
7139 with new functions.
7140 * gdb/fortran-operator.def: New file.
7141 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7142 * gdb/std-operator.def: Remove UNOP_KIND.
7143
6fdcd7cc
AB
71442019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7145
7146 * std-operator.def: Remove unbalanced, stray double quote
7147 character.
7148
2e62ab40
AB
71492019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7150 Chris January <chris.january@arm.com>
7151 Daniel Everett <daniel.everett@arm.com>
7152 Nick Forrington <nick.forrington@arm.com>
7153 Richard Bunt <richard.bunt@arm.com>
7154
7155 * cp-valprint.c (cp_print_value_fields): Allow an additional level
7156 of depth when printing anonymous structs or unions.
7157 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7158 Don't print either the top-level value, or the children if the
7159 max-depth is exceeded.
7160 (ppscm_print_children): When printing the key of a map, allow one
7161 extra level of depth.
7162 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7163 print either the top-level value, or the children if the max-depth
7164 is exceeded.
7165 (print_children): When printing the key of a map, allow one extra
7166 level of depth.
7167 * python/py-value.c (valpy_format_string): Add max_depth keyword.
7168 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7169 (user_print_options): Initialise max_depth field.
7170 (val_print_scalar_or_string_type_p): New function.
7171 (val_print): Check to see if the max depth has been reached.
7172 (val_print_check_max_depth): Define new function.
7173 (show_print_max_depth): New function.
7174 (_initialize_valprint): Add 'print max-depth' option.
7175 * valprint.h (struct value_print_options) <max_depth>: New field.
7176 (val_print_check_max_depth): Declare new function.
7177 * NEWS: Document new feature.
7178
4be290b2
AB
71792019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7180
7181 * ada-lang.c (ada_language_defn): Initialise new field.
7182 * c-lang.c (c_is_string_type_p): New function.
7183 (c_language_defn): Initialise new field.
7184 (cplus_language_defn): Initialise new field.
7185 (asm_language_defn): Initialise new field.
7186 (minimal_language_defn): Initialise new field.
7187 * c-lang.h (c_is_string_type_p): Declare new function.
7188 * d-lang.c (d_language_defn): Initialise new field.
7189 * f-lang.c (f_is_string_type_p): New function.
7190 (f_language_defn): Initialise new field.
7191 * go-lang.c (go_is_string_type_p): New function.
7192 (go_language_defn): Initialise new field.
7193 * language.c (default_is_string_type_p): New function.
7194 (unknown_language_defn): Initialise new field.
7195 (auto_language_defn): Initialise new field.
7196 * language.h (struct language_defn) <la_is_string_type_p>: New
7197 member variable.
7198 (default_is_string_type_p): Declare new function.
7199 * m2-lang.c (m2_language_defn): Initialise new field.
7200 * objc-lang.c (objc_language_defn): Initialise new field.
7201 * opencl-lang.c (opencl_language_defn): Initialise new field.
7202 * p-lang.c (pascal_is_string_type_p): New function.
7203 (pascal_language_defn): Initialise new field.
7204 * rust-lang.c (rust_is_string_type_p): New function.
7205 (rust_language_defn): Initialise new field.
7206
721b08c6
AB
72072019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7208
7209 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7210 New field.
7211 * ada-lang.c (ada_language_defn): Initialise new field.
7212 * c-lang.c (c_language_defn): Likewise.
7213 (cplus_language_defn): Likewise.
7214 (asm_language_defn): Likewise.
7215 (minimal_language_defn): Likewise.
7216 * d-lang.c (d_language_defn): Likewise.
7217 * f-lang.c (f_language_defn): Likewise.
7218 * go-lang.c (go_language_defn): Likewise.
7219 * language.c (unknown_language_defn): Likewise.
7220 (auto_language_defn): Likewise.
7221 * m2-lang.c (m2_language_defn): Likewise.
7222 * objc-lang.c (objc_language_defn): Likewise.
7223 * opencl-lang.c (opencl_language_defn): Likewise.
7224 * p-lang.c (pascal_language_defn): Likewise.
7225 * rust-lang.c (rust_language_defn): Likewise.
7226
fc913e53
AB
72272019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7228
7229 * ada-lang.c (ada_is_character_type): Change return type to bool.
7230 (ada_is_string_type): Likewise.
7231 * ada-lang.h (ada_is_character_type): Update declaration
7232 (ada_is_string_type): Likewise.
7233
fa731fa0
PW
72342019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7235
7236 Support style in 'frame|thread apply'
7237
7238 * gdbcmd.h (execute_command_to_string): New term_out parameter.
7239 * record.c (record_start, record_stop): Update callers of
7240 execute_command_to_string with false.
7241 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7242 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7243 methods.
7244 (class string_file): New constructor with term_out parameter.
7245 Override methods term_out and can_emit_style_escape. New member
7246 term_out.
7247 (class stdio_file): Override can_emit_style_escape.
7248 (class tee_file): Override term_out and can_emit_style_escape.
7249 * utils.h (can_emit_style_escape): Remove.
7250 * utils.c (can_emit_style_escape): Likewise.
7251 Update all callers of can_emit_style_escape (SOMESTREAM) to
7252 SOMESTREAM->can_emit_style_escape.
7253 * source-cache.c (source_cache::get_source_lines): Likewise.
7254 * stack.c (frame_apply_command_count): Call execute_command_to_string
7255 passing the term_out characteristic of the current gdb_stdout.
7256 * thread.c (thr_try_catch_cmd): Likewise.
7257 * top.c (execute_command_to_string): pass term_out parameter
7258 to construct the string_file for the command output.
7259 * ui-file.c (term_cli_styling): New function (most code moved
7260 from utils.c can_emit_style_escape).
7261 (string_file::string_file, string_file::can_emit_style_escape,
7262 stdio_file::can_emit_style_escape, tee_file::term_out,
7263 tee_file::can_emit_style_escape): New functions.
7264
136afab8
PW
72652019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7266
7267 * NEWS: Mention the new set|show may-call-functions.
7268 * infcall.c (may_call_functions_p): New variable.
7269 (show_may_call_functions_p): New function.
7270 (call_function_by_hand_dummy): Throws an error if not
7271 may-call-functions.
7272 (_initialize_infcall): Call add_setshow_boolean_cmd for
7273 may-call-functions.
7274
725cbb63
KS
72752019-04-25 Keith Seitz <keiths@redhat.com>
7276
7277 PR c++/24367
7278 * cp-support.c (inspect_type): Don't attempt substitutions
7279 of symbol with the same name.
7280
3d1cbb78
TT
72812019-04-25 Tom Tromey <tromey@adacore.com>
7282
7283 PR gdb/24475:
7284 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7285 static.
7286
94aeb44b
TT
72872019-04-25 Tom Tromey <tromey@adacore.com>
7288
7289 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7290 rvalue reference.
7291 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7292 (gdb_xml_parser::parse): Use std::move.
7293 * python/python-internal.h (gdbpy_convert_exception): Take a const
7294 reference.
7295 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7296 std::move.
7297 * python/py-utils.c (gdbpy_convert_exception): Take a const
7298 reference.
7299 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7300 Use std::move.
7301 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7302 Use std::move.
7303 * mi/mi-main.c (mi_print_exception): Take a const reference.
7304 * main.c (handle_command_errors): Take a const reference.
7305 * linespec.c (parse_linespec): Use std::move.
7306 * infcall.c (run_inferior_call): Use std::move.
7307 (call_function_by_hand_dummy): Use std::move.
7308 * exec.c (try_open_exec_file): Use std::move.
7309 * exceptions.h (exception_print, exception_fprintf)
7310 (exception_print_same): Update.
7311 * exceptions.c (print_exception, exception_print)
7312 (exception_fprintf, exception_print_same): Change parameters to
7313 const reference.
7314 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7315 * common/new-op.c: Use std::move.
7316 * common/common-exceptions.h (struct gdb_exception): Add move
7317 constructor.
7318 (struct gdb_exception_error, struct gdb_exception_quit, struct
7319 gdb_quit_bad_alloc): Change constructor to move constructor.
7320 (throw_exception): Change parameter to rvalue reference.
7321 * common/common-exceptions.c (throw_exception): Take rvalue
7322 reference.
7323 * cli/cli-interp.c (safe_execute_command): Use std::move.
7324 * breakpoint.c (insert_bp_location, location_to_sals): Use
7325 std::move.
7326
680d7fd5
TT
73272019-04-25 Tom Tromey <tromey@adacore.com>
7328
7329 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7330 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7331 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7332 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7333 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7334 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7335 guile/scm-value.c: Use unpack.
7336 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7337 gdbscm_gdb_exception.
7338 (gdbscm_throw_gdb_exception): Likewise.
7339 (struct gdbscm_gdb_exception): New.
7340 (unpack): New function.
7341 (gdbscm_wrap): Use unpack.
7342
c6fdd8b2
TT
73432019-04-25 Tom Tromey <tromey@adacore.com>
7344
7345 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7346 (gdb_rl_callback_handler): Use std::move.
7347 * common/common-exceptions.h (struct gdb_exception): Add move
7348 assignment operator.
7349 (throw_exception_sjlj): Change "exception" to const reference.
7350 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7351 (throw_exception_sjlj): Change "exception" to const reference.
7352
cc06b668
TT
73532019-04-25 Tom Tromey <tromey@adacore.com>
7354
7355 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7356 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7357 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7358 Update.
7359 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7360 Update.
7361 * mi/mi-interp.c (mi_interp::exec): Update.
7362 * linespec.c (parse_linespec): Update.
7363 * infcall.c (run_inferior_call): Update.
7364 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7365 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7366 (gdbscm_lookup_global_symbol): Update.
7367 * guile/scm-param.c (gdbscm_parameter_value): Update.
7368 * guile/scm-frame.c (gdbscm_frame_read_register)
7369 (gdbscm_frame_read_var): Update.
7370 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7371 * exec.c (try_open_exec_file): Update.
7372 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7373 (gdb_rl_callback_handler): Update.
7374 * common/common-exceptions.h (exception_none): Don't declare.
7375 * common/common-exceptions.c (exception_none): Don't define.
7376 (struct catcher) <exception>: Update.
7377 * cli/cli-interp.c (safe_execute_command): Update.
7378 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7379
cf532bd1
AT
73802019-04-25 Ali Tamur <tamur@google.com>
7381
7382 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7383 (read_attribute_value): Likewise.
7384 (dwarf2_read_addr_index): Update comment.
7385 (read_str_index): Add DW_FORM_strx.
7386 (dwarf2_string_attr): Likewise.
7387 (dwarf2_const_value_attr): Likewise.
7388 (dump_die_shallow): Likewise.
7389 (dwarf2_fetch_constant_bytes): Likewise.
7390 (skip_form_bytes): Likewise.
7391 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7392
82433e3e
SDJ
73932019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7394
7395 PR corefiles/11608
7396 PR corefiles/18187
7397 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7398 OFFSET. Verify if current mapping contains an ELF header.
7399 (linux_find_memory_regions_full): Adjust call to
7400 dump_mapping_p.
7401
723adb65
SL
74022019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7403 Kang Li <kanglictf@gmail.com>
7404
7405 PR gdb/21600
7406
7407 * dwarf2-frame.c (read_initial_length): Be consistent about using
7408 unsigned representation of length.
7409 (decode_frame_entry_1): Likewise. Check for wraparound of
7410 end pointer as well as buffer overflow.
7411
596179f7
SDJ
74122019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7413
7414 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7415 "vq".
7416
a59240a4
TT
74172019-04-24 Tom Tromey <tromey@adacore.com>
7418
7419 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7420
f872fdbb
AB
74212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7422
7423 * s12z-tdep.c (s12z_unwind_pc): Delete.
7424 (s12z_unwind_sp): Delete.
7425 (s12z_gdbarch_init): Don't register deleted functions with
7426 gdbarch.
7427
b614e6f3
AB
74282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7429
7430 * rl78-tdep.c (rl78_unwind_sp): Delete.
7431 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7432
14faed38
AB
74332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7434
7435 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7436 (xstormy16_unwind_pc): Delete.
7437 (xstormy16_dummy_id): Delete.
7438 (xstormy16_gdbarch_init): Don't register deleted functions with
7439 gdbarch.
7440
541aad8a
AB
74412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7442
7443 * vax-tdep.c (vax_unwind_pc): Delete.
7444 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7445
29222070
AB
74462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7447
7448 * v850-tdep.c (v850_unwind_sp): Delete.
7449 (v850_unwind_pc): Delete.
7450 (v850_dummy_id): Delete.
7451 (v850_gdbarch_init): Don't register deleted functions with
7452 gdbarch.
7453
0f534d76
AB
74542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7455
7456 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7457 (tilegx_unwind_pc): Delete.
7458 (tilegx_unwind_dummy_id): Delete.
7459 (tilegx_gdbarch_init): Don't register deleted functions with
7460 gdbarch.
7461
1ba7b7f9
AB
74622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7463
7464 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7465 (tic6x_dummy_id): Delete.
7466 (tic6x_gdbarch_init): Don't register deleted functions with
7467 gdbarch.
7468
d31f262c
AB
74692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7470
7471 * sparc-tdep.c (sparc_unwind_pc): Delete.
7472 (sparc32_gdbarch_init): Don't register deleted function with
7473 gdbarch.
7474
6d14d64d
AB
74752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7476
7477 * sh-tdep.c (sh_unwind_sp): Delete.
7478 (sh_unwind_pc): Delete.
7479 (sh_dummy_id): Delete.
7480 (sh_gdbarch_init): Don't register deleted functions with
7481 gdbarch.
7482
a40dde9d
AB
74832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7484
7485 * score-tdep.c (score_unwind_sp): Delete.
7486 (score_unwind_pc): Delete.
7487 (score_dummy_id): Delete.
7488 (score_gdbarch_init): Don't register deleted functions with
7489 gdbarch.
7490
47c47d69
AB
74912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7492
7493 * rx-tdep.c (rx_unwind_pc): Delete.
7494 (rx_unwind_sp): Delete.
7495 (rx_dummy_id): Delete.
7496 (rx_gdbarch_init): Don't register deleted functions with
7497 gdbarch. Update comment.
7498
833a4480
AB
74992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7500
7501 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7502 (rs6000_dummy_id): Delete.
7503 (rs6000_gdbarch_init): Don't register deleted functions with
7504 gdbarch.
7505
3f2cef49
AB
75062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7507
7508 * or1k-tdep.c (or1k_dummy_id): Delete.
7509 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7510
96acf884
AB
75112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7512
7513 * nios2-tdep.c (nios2_dummy_id): Delete.
7514 (nios2_unwind_sp): Delete.
7515 (nios2_gdbarch_init): Don't register deleted functions with
7516 gdbarch.
7517
ca0ab0aa
AB
75182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7519
7520 * nds32-tdep.c (nds32_dummy_id): Delete.
7521 (nds32_unwind_pc): Delete.
7522 (nds32_unwind_sp): Delete.
7523 (nds32_gdbarch_init): Don't register deleted functions with
7524 gdbarch.
7525
c8259044
AB
75262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7527
7528 * msp430-tdep.c (msp430_unwind_pc): Delete.
7529 (msp430_unwind_sp): Delete.
7530 (msp430_dummy_id): Delete.
7531 (msp430_gdbarch_init): Don't register deleted functions with
7532 gdbarch.
7533
27f113c8
AB
75342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7535
7536 * moxie-tdep.c (moxie_unwind_sp): Delete.
7537 (moxie_unwind_pc): Delete.
7538 (moxie_dummy_id): Delete.
7539 (moxie_gdbarch_init): Don't register deleted functions with
7540 gdbarch.
7541
aee6c3cd
AB
75422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7543
7544 * mn10300-tdep.c (mn10300_dummy_id): Delete.
7545 (mn10300_unwind_pc): Delete.
7546 (mn10300_unwind_sp): Delete.
7547 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7548 mn10300_unwind_sp.
7549 (mn10300_frame_unwind_init): Don't register deleted functions with
7550 gdbarch.
7551
8e2b5aea
AB
75522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7553
7554 * mep-tdep.c (mep_unwind_pc): Delete.
7555 (mep_unwind_sp): Delete.
7556 (mep_dummy_id): Delete.
7557 (mep_gdbarch_init): Don't register deleted functions with
7558 gdbarch.
7559
43cf3ede
AB
75602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7561
7562 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7563 (m68hc11_unwind_sp): Delete.
7564 (m68hc11_gdbarch_init): Don't register deleted functions with
7565 gdbarch.
7566
5e79b7bb
AB
75672019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7568
7569 * m32r-tdep.c (m32r_unwind_sp): Delete.
7570 (m32r_unwind_pc): Delete.
7571 (m32r_dummy_id): Delete.
7572 (m32r_gdbarch_init): Don't register deleted functions with
7573 gdbarch.
7574
89b268d8
AB
75752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7576
7577 * m32c-tdep.c (m32c_unwind_pc): Delete.
7578 (m32c_unwind_sp): Delete.
7579 (m32c_dummy_id): Delete.
7580 (m32c_gdbarch_init): Don't register deleted functions with
7581 gdbarch.
7582
946c28d2
AB
75832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7584
7585 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7586 (lm32_unwind_pc): Delete.
7587 (lm32_dummy_id): Delete.
7588 (lm32_gdbarch_init): Don't register deleted functions with
7589 gdbarch.
7590
bf12844a
AB
75912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7592
7593 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7594 (iq2000_unwind_pc): Delete.
7595 (iq2000_dummy_id): Delete.
7596 (iq2000_gdbarch_init): Don't register deleted functions with
7597 gdbarch.
7598
ecbc06d2
AB
75992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7600
7601 * nds32-tdep.c (nds32_type_align): Delete.
7602 (nds32_push_dummy_call): Use type_align instead.
7603
030197b4
AB
76042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7605
7606 * arm-tdep.c (arm_type_align): Only handle vector override case.
7607 (arm_push_dummy_call): Use type_align.
7608 (arm_gdbarch_init): Register arm_type_align gdbarch function.
7609
b907456c
AB
76102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7611
7612 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7613 case.
7614 (pass_on_stack): Use type_align.
7615 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7616 function.
7617
9e97ba43
TT
76182019-04-23 Tom Tromey <tromey@adacore.com>
7619
7620 * dwarf2read.c (line_header::file_name_at): Remove unused
7621 overload.
7622
6892f601
TV
76232019-04-23 Tom de Vries <tdevries@suse.de>
7624
7625 PR gdb/24438
7626 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7627 invocation.
7628
336d760d
AT
7629
76302019-03-27 Ali Tamur <tamur@google.com>
7631
7632 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7633 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7634 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7635 (dwarf_expr_context::get_addr_index): Likewise
7636 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7637 (symbol_needs_eval_context::get_addr_index): Likewise
7638 (disassemble_dwarf_expression): Add DW_OP_addrx
7639 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7640 (read_cutu_die_from_dwo): Update comment
7641 (skip_one_die): Add DW_FORM_addrx
7642 (read_attribute_value): Likewise
7643 (var_decode_location): Add DW_OP_addrx
7644 (dwarf2_const_value_attr): Add DW_FORM_addrx
7645 (dump_die_shallow): Likewise
7646 (dwarf2_fetch_constant_bytes): Likewise
7647 (decode_locdesc): Add DW_OP_addrx
7648 (skip_form_bytes): Add DW_FORM_addrx
7649
ad9d13f8
AT
76502019-04-22 Ali Tamur <tamur@google.com>
7651
7652 * MAINTAINERS (Write After Approval): Add self.
7653
d70cc3ba
SM
76542019-04-22 Simon Marchi <simon.marchi@efficios.com>
7655
7656 * solib-svr4.c (get_svr4_info): Add pspace parameter.
7657 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7658 (open_symbol_file_object): Likewise.
7659 (svr4_default_sos): Add info parameter.
7660 (svr4_read_so_list): Likewise.
7661 (svr4_current_sos_direct): Adjust functions calls to pass down
7662 info.
7663 (svr4_current_sos_1): Add info parameter.
7664 (svr4_current_sos): Call get_svr4_info, pass info down to
7665 svr4_current_sos_1.
7666 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7667 get_svr4_info.
7668 (svr4_in_dynsym_resolve_code): Pass current_program_space to
7669 get_svr4_info.
7670 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7671 to get_svr4_info.
7672 (probes_table_remove_objfile_probes): Likewise.
7673 (register_solib_event_probe): Add info parameter.
7674 (solist_update_incremental): Pass info parameter down to
7675 svr4_read_so_list.
7676 (disable_probes_interface): Add info parameter.
7677 (svr4_handle_solib_event): Pass current_program_space to
7678 get_svr4_info. Adjust disable_probes_interface cleanup.
7679 (svr4_create_probe_breakpoints): Add info parameter, pass it
7680 down to register_solib_event_probe.
7681 (svr4_create_solib_event_breakpoints): Add info parameter,
7682 pass it down to svr4_create_probe_breakpoints.
7683 (enable_break): Pass info down to
7684 svr4_create_solib_event_breakpoints.
7685 (svr4_solib_create_inferior_hook): Pass current_program_space to
7686 get_svr4_info.
7687 (svr4_clear_solib): Likewise.
7688
7905fc35
PA
76892019-04-22 Pedro Alves <palves@redhat.com>
7690
7691 * solib-svr4.c (svr4_free_objfile_observer): New.
7692 (probe_and_action::objfile): New field.
7693 (probes_table_htab_remove_objfile_probes)
7694 (probes_table_remove_objfile_probes): New functions.
7695 (register_solib_event_probe): Add 'objfile' parameter. Store it
7696 in the new probe_and_action. Don't store the probe in 'lookup'.
7697 (svr4_create_probe_breakpoints): Pass objfile to
7698 register_solib_event_probe.
7699 (_initialize_svr4_solib): Register a free_objfile observer.
7700
fb881986
TT
77012019-04-19 Tom Tromey <tom@tromey.com>
7702
7703 * common/queue.h: Remove.
7704
8732db6c
TT
77052019-04-19 Tom Tromey <tom@tromey.com>
7706
7707 * event-loop.c: Don't include "common/queue.h".
7708
97dfbadd
TT
77092019-04-19 Tom Tromey <tom@tromey.com>
7710
7711 * remote.c (remote_target): Use delete.
7712 * remote-notif.h: Include <list>, not "common/queue.h".
7713 (notif_client_p): Remove typedef.
7714 (remote_notif_state): Add constructor, destructor, initializer.
7715 <notif_queue>: Now a std::list.
7716 (remote_notif_state_xfree): Don't declare.
7717 * remote-notif.c (remote_notif_process, handle_notification)
7718 (remote_notif_state_allocate): Update.
7719 (~remote_notif_state): Rename from remote_notif_state_xfree.
7720
cf250e36
TT
77212019-04-19 Tom Tromey <tom@tromey.com>
7722
7723 * symfile.c (reread_symbols): Update.
7724 * objfiles.c (objfile_register_static_link)
7725 (objfile_lookup_static_link): Update
7726 (~objfile) Don't delete static_links.
7727 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7728
61f4b350
TT
77292019-04-19 Tom Tromey <tom@tromey.com>
7730
7731 * type-stack.h (struct type_stack) <insert>: Constify string.
7732 * type-stack.c (type_stack::insert): Constify string.
7733 * gdbtypes.h (lookup_template_type): Update.
7734 (address_space_name_to_int): Update.
7735 * gdbtypes.c (address_space_name_to_int): Make space_identifier
7736 const.
7737 (lookup_template_type): Make name const.
7738 * c-exp.y: Update rules.
7739 (lex_one_token, classify_name, classify_inner_name)
7740 (c_print_token): Update.
7741 * p-exp.y: Update rules.
7742 (yylex): Update.
7743 * f-exp.y: Update rules.
7744 (yylex): Update.
7745 * d-exp.y: Update rules.
7746 (lex_one_token, classify_name, classify_inner_name): Update.
7747 * parse.c (write_dollar_variable, copy_name): Return std::string.
7748 * parser-defs.h (copy_name): Change return type.
7749 * m2-exp.y: Update rules.
7750 (yylex): Update.
7751 * go-exp.y (lex_one_token): Update.
7752 Update rules.
7753 (classify_unsafe_function, classify_packaged_name)
7754 (classify_name, yylex): Update.
7755
189b8c2e
ST
77562019-04-19 Sergei Trofimovich <siarheit@google.com>
7757
7758 * configure.ac: add --enable-source-highlight switch.
7759 * configure: Regenerate.
7760 * top.c (print_gdb_version): plumb --enable-source-highlight
7761 status to "show configuration".
7762
8ecb59f8
TT
77632019-04-19 Tom Tromey <tromey@adacore.com>
7764
7765 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7766 Check ADA_TYPE_P.
7767 (empty_record, ada_template_to_fixed_record_type_1)
7768 (template_to_static_fixed_type)
7769 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7770 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7771 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7772 macros.
7773
62160ec9
TT
77742019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
7775
7776 PR symtab/24423:
7777 * source.c (print_source_lines_base): Advance "iter" when a
7778 control character is seen.
7779
f2ae8bc8
PW
77802019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7781
7782 * inferior.h (struct infcall_suspend_state_deleter):
7783 Catch exception in destructor to avoid crash.
7784
d563b953
PW
77852019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7786
7787 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7788 close to the add_com "shell".
7789
dc34c897
TT
77902019-04-18 Tom Tromey <tromey@adacore.com>
7791
7792 * process-stratum-target.h (class process_stratum_target)
7793 <stratum>: Add "final".
7794
a12e5744
TT
77952019-04-17 Tom Tromey <tromey@adacore.com>
7796
7797 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7798 against nullptr before use.
7799
a7e559cc
AH
78002019-04-17 Alan Hayward <alan.hayward@arm.com>
7801
7802 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7803
c01660c6
AB
78042019-04-17 Jim Wilson <jimw@sifive.com>
7805 Andrew Burgess <andrew.burgess@embecosm.com>
7806
7807 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7808 code read might fail, assume 4-byte breakpoint in that case.
7809
4aa866af
LS
78102019-04-15 Leszek Swirski <leszeks@google.com>
7811
7812 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7813 rather than a hand-rolled POD check when checking for forced MEMORY
7814 classification.
7815
48574d91
AH
78162019-04-15 Alan Hayward <alan.hayward@arm.com>
7817
7818 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7819 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7820 function.
7821 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7822 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7823 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7824 declaration.
7825
4da037ef
AH
78262019-04-15 Alan Hayward <alan.hayward@arm.com>
7827
7828 * aarch64-linux-nat.c
7829 (aarch64_linux_nat_target::thread_architecture): Add override.
7830 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7831 each VQ.
7832
ccb8d7e8
AH
78332019-04-15 Alan Hayward <alan.hayward@arm.com>
7834
7835 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7836
35add35e
AB
78372019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
7838
7839 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7840 target types of size 96-bits, add some additional comments, and
7841 check that the builtin type we found was the correct size.
7842
51196bbc
EZ
78432019-04-12 Eli Zaretskii <eliz@gnu.org>
7844
7845 * utils.c (prompt_for_continue): Don't restore the styling at the
7846 end, as applied_style has the wrong value. This fixes styling in
7847 long lists of file names that are interrupted by the "Continue?"
7848 prompt.
7849
62253a61
AB
78502019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
7851
7852 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7853 * c-lang.c (c_language_defn): Likewise.
7854 (cplus_language_defn): Likewise.
7855 (asm_language_defn): Likewise.
7856 (minimal_language_defn): Likewise.
7857 * d-lang.c (d_language_defn): Likewise.
7858 * f-lang.c (f_language_defn): Likewise.
7859 * go-lang.c (go_language_defn): Likewise.
7860 * language.c (unknown_language_defn): Likewise.
7861 (auto_language_defn): Likewise.
7862 * language.h (struct language_defn): Remove la_magic field.
7863 (LANG_MAGIC): Delete.
7864 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7865 * objc-lang.c (objc_language_defn): Likewise.
7866 * opencl-lang.c (opencl_language_defn): Likewise.
7867 * p-lang.c (pascal_language_defn): Likewise.
7868 * rust-lang.c (rust_language_defn): Likewise.
7869
a9158a86
AB
78702019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7871
7872 * riscv-tdep.c (riscv_type_align): New function.
7873 (riscv_type_alignment): Delete.
7874 (riscv_arg_location): Use 'type_align'.
7875 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7876
41077b66
AB
78772019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7878
7879 * gdbtypes.c (type_align): A struct with no non-static fields also
7880 has alignment of 1.
7881
9f0272f8
AB
78822019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7883
7884 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7885 component to 0.
7886 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7887 member.
7888 (riscv_struct_info::analyse): New implementation using new
7889 analyse_inner member function.
7890 (riscv_struct_info::field_offset): New member function.
7891 (riscv_struct_info::m_offsets): New member variable.
7892 (riscv_struct_info::analyse_inner): New private member function,
7893 takes the old implementation of riscv_struct_info::analyse but
7894 extended to track field offsets.
7895 (riscv_call_arg_struct): Update the struct folding special cases
7896 to handle cases where empty C++ structs, which are non-zero
7897 length, are found.
7898 (riscv_arg_location): Initialise the length of each location, a
7899 non-zero length now indicates the location is in use.
7900 (riscv_push_dummy_call): Allow for the first location having a
7901 non-zero offset when setting up arguments.
7902 (riscv_return_value): Likewise, but for return values.
7903
02cf60c7
TT
79042019-04-11 Tom Tromey <tromey@adacore.com>
7905
7906 * utils.c (internal_vproblem): Make "msg" const.
7907
68811f8f
AH
79082019-04-11 Alan Hayward <alan.hayward@arm.com>
7909
7910 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7911 * trad-frame.c (trad_frame_reset_saved_regs): New function.
7912 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7913 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7914
3f52fdbc
KB
79152019-04-10 Kevin Buettner <kevinb@redhat.com>
7916
7917 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7918 function.
7919 (fill_gregset): Call amd64_linux_collect_native_gregset instead
7920 of amd64_collect_native_gregset.
7921 (amd64_linux_nat_target::store_registers): Likewise.
7922
e9ad22ee
TT
79232019-04-10 Tom Tromey <tom@tromey.com>
7924
7925 * symtab.c (lookup_global_symbol_from_objfile)
7926 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7927 * objfiles.h (class separate_debug_iterator): New.
7928 (class separate_debug_range): New.
7929 (struct objfile) <separate_debug_objfiles>: New method.
7930 (objfile_separate_debug_iterate): Don't declare.
7931 * objfiles.c (separate_debug_iterator::operator++): Rename from
7932 objfile_separate_debug_iterate.
7933 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7934 iterator.
7935 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7936 iterator.
7937
ee371134
TT
79382019-04-10 Tom Tromey <tom@tromey.com>
7939
7940 * symfile.c (reread_symbols): Remove old comment.
7941 * objfiles.c (free_all_objfiles): Fix a typo.
7942
bf227d61
TT
79432019-04-10 Tom Tromey <tom@tromey.com>
7944
7945 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7946 * minsyms.c (lookup_minimal_symbol): Use foreach.
7947 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7948 (lookup_minimal_symbol_solib_trampoline): Likewise.
7949 * symfile.c (reread_symbols): Use foreach.
7950
8dc433a0
TT
79512019-04-09 Ivan Begert <ivanbegert@gmail.com>
7952 Tom Tromey <tromey@adacore.com>
7953
7954 PR rust/24414:
7955 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7956 (rust_lex_int_test): Change "value" to be LONGEST.
7957 (rust_lex_tests): Add test for long integer literal.
7958
9ab8741a
TT
79592019-04-09 Tom Tromey <tromey@adacore.com>
7960
7961 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7962 to bool.
7963 (extended_remote_target::attach): Update.
7964 (remote_target::remote_notice_new_inferior): Update.
7965 (remote_target::add_current_inferior_and_thread): Update.
7966 * inferior.c (exit_inferior_1): Use "false".
7967 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7968
e242fd12
SM
79692019-04-09 Simon Marchi <simon.marchi@efficios.com>
7970
9ca1957f 7971 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
7972 the "start" command.
7973
2b0c8b01
KB
79742019-04-08 Kevin Buettner <kevinb@redhat.com>
7975
7976 * python/py-inferior.c (infpy_thread_from_thread_handle):
7977 Adjust comments to reflect renaming of thread_from_thread_handle
7978 to thread_from_handle. Adjust keywords. Fix type error message.
7979 (inferior_object_methods): Add thread_from_handle. Retain
7980 thread_from_thread_handle, but mark it as deprecated.
7981
50a82723
KB
79822019-04-08 Kevin Buettner <kevinb@redhat.com>
7983
7984 * gdbthread.h (find_thread_by_handle): Revise declaration.
7985 * thread.c (find_thread_by_handle): Likewise. Adjust
7986 implementation too.
7987 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7988 support for buffer objects as handles.
7989
cf63b016
KB
79902019-04-08 Kevin Buettner <kevinb@redhat.com>
7991
7992 * python/py-infthread.c (thpy_thread_handle): New function.
7993 (thread_object_methods): Register thpy_thread_handle.
7994
3d6c6204
KB
79952019-04-08 Kevin Buettner <kevinb@redhat.com>
7996
7997 * gdbthread.h (thread_to_thread_handle): Declare.
7998 * thread.c (gdbtypes.h): Include.
7999 (thread_to_thread_handle): New function.
8000
8001 * target.h (struct target_ops): Add thread_info_to_thread_handle.
8002 (target_thread_info_to_thread_handle): Declare.
8003 * target.c (target_thread_info_to_thread_handle): New function.
8004 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8005 * target-delegates.c: Regenerate.
8006
8007 * linux-thread-db.c (class thread_db_target): Add method
8008 thread_info_to_thread_handle.
8009 (thread_db_target::thread_info_to_thread_handle): Define.
8010 * remote.c (class remote_target): Add new method
8011 thread_info_to_thread_handle.
8012 (remote_target::thread_info_to_thread_handle): Define.
8013
56be6ea8
PA
80142019-04-08 Pedro Alves <palves@redhat.com>
8015
8016 * common/common-exceptions.c (throw_exception): Don't create
8017 named object to throw; throw directly.
8018 (throw_it): Likewise. Don't initialize gdb_exception::message
8019 here, with new; pass FMT and AP to the ctor instead.
8020 * common/common-exceptions.h: Include <string>.
8021 (gdb_exception::gdb_exception(enum return_reason, enum errors,
8022 const char *, va_list)): New ctor. Use std::make_shared.
8023 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8024 errors)): Delete.
8025 (gdb_exception_error::gdb_exception_error(enum errors, const char
8026 *, va_list)): New.
8027 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8028 Add assertion.
8029 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8030 errors)): Delete.
8031 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8032 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8033 Add assertion.
8034
eedc3f4f
TT
80352019-04-08 Tom Tromey <tom@tromey.com>
8036
8037 * valops.c (value_rtti_indirect_type): Replace throw_exception
8038 with throw.
8039 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8040 with throw.
8041 * thread.c (thr_try_catch_cmd): Replace throw_exception with
8042 throw.
8043 * target.c (target_translate_tls_address): Replace throw_exception
8044 with throw.
8045 * stack.c (frame_apply_command_count): Replace throw_exception
8046 with throw.
8047 * solib-spu.c (append_ocl_sos): Replace throw_exception with
8048 throw.
8049 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8050 with throw.
8051 * rs6000-tdep.c (rs6000_frame_cache)
8052 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8053 * remote.c: Replace throw_exception with throw.
8054 * record-full.c (record_full_message, record_full_wait_1)
8055 (record_full_restore): Replace throw_exception with throw.
8056 * record-btrace.c:
8057 (get_thread_current_frame_id, record_btrace_start_replaying)
8058 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8059 (cmd_record_btrace_start): Replace throw_exception with throw.
8060 * parse.c (parse_exp_in_context_1): Replace throw_exception with
8061 throw.
8062 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8063 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8064 * linespec.c:
8065 (find_linespec_symbols): Replace throw_exception with throw.
8066 * infrun.c (displaced_step_prepare, resume): Replace
8067 throw_exception with throw.
8068 * infcmd.c (post_create_inferior): Replace throw_exception with
8069 throw.
8070 * inf-loop.c (inferior_event_handler): Replace throw_exception
8071 with throw.
8072 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8073 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8074 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8075 (get_prev_frame_always, get_frame_pc_if_available)
8076 (get_frame_address_in_block_if_available, get_frame_language):
8077 Replace throw_exception with throw.
8078 * frame-unwind.c (frame_unwind_try_unwinder): Replace
8079 throw_exception with throw.
8080 * eval.c (fetch_subexp_value, evaluate_var_value)
8081 (evaluate_funcall, evaluate_subexp_standard): Replace
8082 throw_exception with throw.
8083 * dwarf2loc.c (call_site_find_chain)
8084 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8085 Replace throw_exception with throw.
8086 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8087 with throw.
8088 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8089 throw.
8090 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8091 * completer.c (complete_line_internal): Replace throw_exception
8092 with throw.
8093 * compile/compile-object-run.c (compile_object_run): Replace
8094 throw_exception with throw.
8095 * cli/cli-script.c (process_next_line): Replace throw_exception
8096 with throw.
8097 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8098 (btrace_enable, btrace_maint_update_pt_packets): Replace
8099 throw_exception with throw.
8100 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8101 throw_exception with throw.
8102 * break-catch-throw.c (re_set_exception_catchpoint): Replace
8103 throw_exception with throw.
8104 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8105 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8106 * aarch64-tdep.c (aarch64_make_prologue_cache)
8107 (aarch64_make_stub_cache): Replace throw_exception with throw.
8108
26003a20
TT
81092019-04-08 Tom Tromey <tom@tromey.com>
8110
8111 * common/common-exceptions.c (throw_exception): Rename from
8112 throw_exception_cxx. Remove old copy. Make argument const.
8113 (throw_it): Create and throw exception objects directly.
8114 * common/common-exceptions.h (throw_exception): Make argument
8115 const.
8116 (struct gdb_exception_error): Add constructor.
8117 (struct gdb_exception_quit): Add constructor.
8118
d272eb37
TT
81192019-04-08 Tom Tromey <tom@tromey.com>
8120
8121 * common/common-exceptions.h (exception_rethrow): Don't declare.
8122 (TRY_SJLJ): Update comment.
8123 (TRY, CATCH, END_CATCH): Remove.
8124 * common/common-exceptions.c (exception_rethrow): Remove.
8125
230d2906
TT
81262019-04-08 Tom Tromey <tom@tromey.com>
8127
8128 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8129 Remove.
8130 (gdb_exception_error): Rename from
8131 gdb_exception_RETURN_MASK_ERROR.
8132 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8133 (gdb_quit_bad_alloc): Update.
8134 * aarch64-tdep.c: Update.
8135 * ada-lang.c: Update.
8136 * ada-typeprint.c: Update.
8137 * ada-valprint.c: Update.
8138 * amd64-tdep.c: Update.
8139 * arch-utils.c: Update.
8140 * break-catch-throw.c: Update.
8141 * breakpoint.c: Update.
8142 * btrace.c: Update.
8143 * c-varobj.c: Update.
8144 * cli/cli-cmds.c: Update.
8145 * cli/cli-interp.c: Update.
8146 * cli/cli-script.c: Update.
8147 * common/common-exceptions.c: Update.
8148 * common/new-op.c: Update.
8149 * common/selftest.c: Update.
8150 * compile/compile-c-symbols.c: Update.
8151 * compile/compile-cplus-symbols.c: Update.
8152 * compile/compile-object-load.c: Update.
8153 * compile/compile-object-run.c: Update.
8154 * completer.c: Update.
8155 * corelow.c: Update.
8156 * cp-abi.c: Update.
8157 * cp-support.c: Update.
8158 * cp-valprint.c: Update.
8159 * darwin-nat.c: Update.
8160 * disasm-selftests.c: Update.
8161 * dtrace-probe.c: Update.
8162 * dwarf-index-cache.c: Update.
8163 * dwarf-index-write.c: Update.
8164 * dwarf2-frame-tailcall.c: Update.
8165 * dwarf2-frame.c: Update.
8166 * dwarf2loc.c: Update.
8167 * dwarf2read.c: Update.
8168 * eval.c: Update.
8169 * event-loop.c: Update.
8170 * event-top.c: Update.
8171 * exec.c: Update.
8172 * f-valprint.c: Update.
8173 * fbsd-tdep.c: Update.
8174 * frame-unwind.c: Update.
8175 * frame.c: Update.
8176 * gdbtypes.c: Update.
8177 * gnu-v3-abi.c: Update.
8178 * guile/guile-internal.h: Update.
8179 * guile/scm-block.c: Update.
8180 * guile/scm-breakpoint.c: Update.
8181 * guile/scm-cmd.c: Update.
8182 * guile/scm-disasm.c: Update.
8183 * guile/scm-frame.c: Update.
8184 * guile/scm-lazy-string.c: Update.
8185 * guile/scm-math.c: Update.
8186 * guile/scm-param.c: Update.
8187 * guile/scm-ports.c: Update.
8188 * guile/scm-pretty-print.c: Update.
8189 * guile/scm-symbol.c: Update.
8190 * guile/scm-symtab.c: Update.
8191 * guile/scm-type.c: Update.
8192 * guile/scm-value.c: Update.
8193 * i386-linux-tdep.c: Update.
8194 * i386-tdep.c: Update.
8195 * inf-loop.c: Update.
8196 * infcall.c: Update.
8197 * infcmd.c: Update.
8198 * infrun.c: Update.
8199 * jit.c: Update.
8200 * language.c: Update.
8201 * linespec.c: Update.
8202 * linux-fork.c: Update.
8203 * linux-nat.c: Update.
8204 * linux-tdep.c: Update.
8205 * linux-thread-db.c: Update.
8206 * main.c: Update.
8207 * mi/mi-cmd-break.c: Update.
8208 * mi/mi-cmd-stack.c: Update.
8209 * mi/mi-interp.c: Update.
8210 * mi/mi-main.c: Update.
8211 * objc-lang.c: Update.
8212 * p-valprint.c: Update.
8213 * parse.c: Update.
8214 * ppc-linux-tdep.c: Update.
8215 * printcmd.c: Update.
8216 * python/py-arch.c: Update.
8217 * python/py-breakpoint.c: Update.
8218 * python/py-cmd.c: Update.
8219 * python/py-finishbreakpoint.c: Update.
8220 * python/py-frame.c: Update.
8221 * python/py-framefilter.c: Update.
8222 * python/py-gdb-readline.c: Update.
8223 * python/py-inferior.c: Update.
8224 * python/py-infthread.c: Update.
8225 * python/py-lazy-string.c: Update.
8226 * python/py-linetable.c: Update.
8227 * python/py-objfile.c: Update.
8228 * python/py-param.c: Update.
8229 * python/py-prettyprint.c: Update.
8230 * python/py-progspace.c: Update.
8231 * python/py-record-btrace.c: Update.
8232 * python/py-record.c: Update.
8233 * python/py-symbol.c: Update.
8234 * python/py-type.c: Update.
8235 * python/py-unwind.c: Update.
8236 * python/py-utils.c: Update.
8237 * python/py-value.c: Update.
8238 * python/python.c: Update.
8239 * record-btrace.c: Update.
8240 * record-full.c: Update.
8241 * remote-fileio.c: Update.
8242 * remote.c: Update.
8243 * riscv-tdep.c: Update.
8244 * rs6000-aix-tdep.c: Update.
8245 * rs6000-tdep.c: Update.
8246 * rust-exp.y: Update.
8247 * rust-lang.c: Update.
8248 * s390-tdep.c: Update.
8249 * selftest-arch.c: Update.
8250 * solib-dsbt.c: Update.
8251 * solib-frv.c: Update.
8252 * solib-spu.c: Update.
8253 * solib-svr4.c: Update.
8254 * solib.c: Update.
8255 * sparc64-linux-tdep.c: Update.
8256 * stack.c: Update.
8257 * symfile-mem.c: Update.
8258 * symmisc.c: Update.
8259 * target.c: Update.
8260 * thread.c: Update.
8261 * top.c: Update.
8262 * tracefile-tfile.c: Update.
8263 * tui/tui.c: Update.
8264 * typeprint.c: Update.
8265 * unittests/cli-utils-selftests.c: Update.
8266 * unittests/parse-connection-spec-selftests.c: Update.
8267 * valops.c: Update.
8268 * valprint.c: Update.
8269 * value.c: Update.
8270 * varobj.c: Update.
8271 * windows-nat.c: Update.
8272 * x86-linux-nat.c: Update.
8273 * xml-support.c: Update.
8274
a70b8144
TT
82752019-04-08 Tom Tromey <tom@tromey.com>
8276
8277 * xml-support.c: Use C++ exception handling.
8278 * x86-linux-nat.c: Use C++ exception handling.
8279 * windows-nat.c: Use C++ exception handling.
8280 * varobj.c: Use C++ exception handling.
8281 * value.c: Use C++ exception handling.
8282 * valprint.c: Use C++ exception handling.
8283 * valops.c: Use C++ exception handling.
8284 * unittests/parse-connection-spec-selftests.c: Use C++ exception
8285 handling.
8286 * unittests/cli-utils-selftests.c: Use C++ exception handling.
8287 * typeprint.c: Use C++ exception handling.
8288 * tui/tui.c: Use C++ exception handling.
8289 * tracefile-tfile.c: Use C++ exception handling.
8290 * top.c: Use C++ exception handling.
8291 * thread.c: Use C++ exception handling.
8292 * target.c: Use C++ exception handling.
8293 * symmisc.c: Use C++ exception handling.
8294 * symfile-mem.c: Use C++ exception handling.
8295 * stack.c: Use C++ exception handling.
8296 * sparc64-linux-tdep.c: Use C++ exception handling.
8297 * solib.c: Use C++ exception handling.
8298 * solib-svr4.c: Use C++ exception handling.
8299 * solib-spu.c: Use C++ exception handling.
8300 * solib-frv.c: Use C++ exception handling.
8301 * solib-dsbt.c: Use C++ exception handling.
8302 * selftest-arch.c: Use C++ exception handling.
8303 * s390-tdep.c: Use C++ exception handling.
8304 * rust-lang.c: Use C++ exception handling.
8305 * rust-exp.y: Use C++ exception handling.
8306 * rs6000-tdep.c: Use C++ exception handling.
8307 * rs6000-aix-tdep.c: Use C++ exception handling.
8308 * riscv-tdep.c: Use C++ exception handling.
8309 * remote.c: Use C++ exception handling.
8310 * remote-fileio.c: Use C++ exception handling.
8311 * record-full.c: Use C++ exception handling.
8312 * record-btrace.c: Use C++ exception handling.
8313 * python/python.c: Use C++ exception handling.
8314 * python/py-value.c: Use C++ exception handling.
8315 * python/py-utils.c: Use C++ exception handling.
8316 * python/py-unwind.c: Use C++ exception handling.
8317 * python/py-type.c: Use C++ exception handling.
8318 * python/py-symbol.c: Use C++ exception handling.
8319 * python/py-record.c: Use C++ exception handling.
8320 * python/py-record-btrace.c: Use C++ exception handling.
8321 * python/py-progspace.c: Use C++ exception handling.
8322 * python/py-prettyprint.c: Use C++ exception handling.
8323 * python/py-param.c: Use C++ exception handling.
8324 * python/py-objfile.c: Use C++ exception handling.
8325 * python/py-linetable.c: Use C++ exception handling.
8326 * python/py-lazy-string.c: Use C++ exception handling.
8327 * python/py-infthread.c: Use C++ exception handling.
8328 * python/py-inferior.c: Use C++ exception handling.
8329 * python/py-gdb-readline.c: Use C++ exception handling.
8330 * python/py-framefilter.c: Use C++ exception handling.
8331 * python/py-frame.c: Use C++ exception handling.
8332 * python/py-finishbreakpoint.c: Use C++ exception handling.
8333 * python/py-cmd.c: Use C++ exception handling.
8334 * python/py-breakpoint.c: Use C++ exception handling.
8335 * python/py-arch.c: Use C++ exception handling.
8336 * printcmd.c: Use C++ exception handling.
8337 * ppc-linux-tdep.c: Use C++ exception handling.
8338 * parse.c: Use C++ exception handling.
8339 * p-valprint.c: Use C++ exception handling.
8340 * objc-lang.c: Use C++ exception handling.
8341 * mi/mi-main.c: Use C++ exception handling.
8342 * mi/mi-interp.c: Use C++ exception handling.
8343 * mi/mi-cmd-stack.c: Use C++ exception handling.
8344 * mi/mi-cmd-break.c: Use C++ exception handling.
8345 * main.c: Use C++ exception handling.
8346 * linux-thread-db.c: Use C++ exception handling.
8347 * linux-tdep.c: Use C++ exception handling.
8348 * linux-nat.c: Use C++ exception handling.
8349 * linux-fork.c: Use C++ exception handling.
8350 * linespec.c: Use C++ exception handling.
8351 * language.c: Use C++ exception handling.
8352 * jit.c: Use C++ exception handling.
8353 * infrun.c: Use C++ exception handling.
8354 * infcmd.c: Use C++ exception handling.
8355 * infcall.c: Use C++ exception handling.
8356 * inf-loop.c: Use C++ exception handling.
8357 * i386-tdep.c: Use C++ exception handling.
8358 * i386-linux-tdep.c: Use C++ exception handling.
8359 * guile/scm-value.c: Use C++ exception handling.
8360 * guile/scm-type.c: Use C++ exception handling.
8361 * guile/scm-symtab.c: Use C++ exception handling.
8362 * guile/scm-symbol.c: Use C++ exception handling.
8363 * guile/scm-pretty-print.c: Use C++ exception handling.
8364 * guile/scm-ports.c: Use C++ exception handling.
8365 * guile/scm-param.c: Use C++ exception handling.
8366 * guile/scm-math.c: Use C++ exception handling.
8367 * guile/scm-lazy-string.c: Use C++ exception handling.
8368 * guile/scm-frame.c: Use C++ exception handling.
8369 * guile/scm-disasm.c: Use C++ exception handling.
8370 * guile/scm-cmd.c: Use C++ exception handling.
8371 * guile/scm-breakpoint.c: Use C++ exception handling.
8372 * guile/scm-block.c: Use C++ exception handling.
8373 * guile/guile-internal.h: Use C++ exception handling.
8374 * gnu-v3-abi.c: Use C++ exception handling.
8375 * gdbtypes.c: Use C++ exception handling.
8376 * frame.c: Use C++ exception handling.
8377 * frame-unwind.c: Use C++ exception handling.
8378 * fbsd-tdep.c: Use C++ exception handling.
8379 * f-valprint.c: Use C++ exception handling.
8380 * exec.c: Use C++ exception handling.
8381 * event-top.c: Use C++ exception handling.
8382 * event-loop.c: Use C++ exception handling.
8383 * eval.c: Use C++ exception handling.
8384 * dwarf2read.c: Use C++ exception handling.
8385 * dwarf2loc.c: Use C++ exception handling.
8386 * dwarf2-frame.c: Use C++ exception handling.
8387 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8388 * dwarf-index-write.c: Use C++ exception handling.
8389 * dwarf-index-cache.c: Use C++ exception handling.
8390 * dtrace-probe.c: Use C++ exception handling.
8391 * disasm-selftests.c: Use C++ exception handling.
8392 * darwin-nat.c: Use C++ exception handling.
8393 * cp-valprint.c: Use C++ exception handling.
8394 * cp-support.c: Use C++ exception handling.
8395 * cp-abi.c: Use C++ exception handling.
8396 * corelow.c: Use C++ exception handling.
8397 * completer.c: Use C++ exception handling.
8398 * compile/compile-object-run.c: Use C++ exception handling.
8399 * compile/compile-object-load.c: Use C++ exception handling.
8400 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8401 * compile/compile-c-symbols.c: Use C++ exception handling.
8402 * common/selftest.c: Use C++ exception handling.
8403 * common/new-op.c: Use C++ exception handling.
8404 * cli/cli-script.c: Use C++ exception handling.
8405 * cli/cli-interp.c: Use C++ exception handling.
8406 * cli/cli-cmds.c: Use C++ exception handling.
8407 * c-varobj.c: Use C++ exception handling.
8408 * btrace.c: Use C++ exception handling.
8409 * breakpoint.c: Use C++ exception handling.
8410 * break-catch-throw.c: Use C++ exception handling.
8411 * arch-utils.c: Use C++ exception handling.
8412 * amd64-tdep.c: Use C++ exception handling.
8413 * ada-valprint.c: Use C++ exception handling.
8414 * ada-typeprint.c: Use C++ exception handling.
8415 * ada-lang.c: Use C++ exception handling.
8416 * aarch64-tdep.c: Use C++ exception handling.
8417
3d6e9d23
TT
84182019-04-08 Tom Tromey <tom@tromey.com>
8419
8420 * xml-support.c (gdb_xml_parser::parse): Update.
8421 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8422 * value.c (show_convenience): Update.
8423 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8424 (test_parse_flags_qcs): Update.
8425 * thread.c (thr_try_catch_cmd): Update.
8426 * target.c (target_translate_tls_address): Update.
8427 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8428 (info_frame_command_core, frame_apply_command_count): Update.
8429 * rust-exp.y (rust_lex_exception_test): Update.
8430 * riscv-tdep.c (riscv_print_one_register_info): Update.
8431 * remote.c (remote_target::enable_btrace): Update.
8432 * record-btrace.c (record_btrace_enable_warn): Update.
8433 * python/py-utils.c (gdbpy_convert_exception): Update.
8434 * printcmd.c (do_one_display, print_variable_and_value): Update.
8435 * mi/mi-main.c (mi_print_exception): Update.
8436 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8437 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8438 * linux-nat.c (linux_nat_target::attach): Update.
8439 * linux-fork.c (class scoped_switch_fork_info): Update.
8440 * infrun.c (displaced_step_prepare): Update.
8441 * infcall.c (call_function_by_hand_dummy): Update.
8442 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8443 * gnu-v3-abi.c (print_one_vtable): Update.
8444 * frame.c (get_prev_frame_always): Update.
8445 * f-valprint.c (info_common_command_for_block): Update.
8446 * exec.c (try_open_exec_file): Update.
8447 * exceptions.c (print_exception, exception_print)
8448 (exception_fprintf, exception_print_same): Update.
8449 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8450 * dwarf-index-cache.c (index_cache::store)
8451 (index_cache::lookup_gdb_index): Update.
8452 * darwin-nat.c (maybe_cache_shell): Update.
8453 * cp-valprint.c (cp_print_value_fields): Update.
8454 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8455 (gcc_cplus_symbol_address): Update.
8456 * compile/compile-c-symbols.c (gcc_convert_symbol)
8457 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8458 * common/selftest.c: Update.
8459 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8460 a std::string.
8461 (exception_try_scope_entry, exception_try_scope_exit): Don't
8462 declare.
8463 (struct exception_try_scope): Remove.
8464 (TRY): Don't use exception_try_scope.
8465 (struct gdb_exception): Add constructor, operator=.
8466 <what>: New method.
8467 (struct gdb_exception_RETURN_MASK_ALL)
8468 (struct gdb_exception_RETURN_MASK_ERROR)
8469 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8470 (struct gdb_quit_bad_alloc): Update.
8471 * common/common-exceptions.c (exception_none): Change
8472 initializer.
8473 (struct catcher) <state, exception>: Initialize inline.
8474 <prev>: Remove member.
8475 (current_catcher): Remove.
8476 (catchers): New global.
8477 (exceptions_state_mc_init): Simplify.
8478 (catcher_pop): Remove.
8479 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8480 (try_scope_depth, exception_try_scope_entry)
8481 (exception_try_scope_exit): Remove.
8482 (throw_exception_sjlj): Update.
8483 (exception_messages, exception_messages_size): Remove.
8484 (throw_it): Simplify.
8485 (gdb_exception_sliced_copy): Remove.
8486 (throw_exception_cxx): Update.
8487 * cli/cli-script.c (script_from_file): Update.
8488 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8489 Update.
8490 * ada-valprint.c (ada_val_print): Update.
8491 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8492 (create_excep_cond_exprs): Update.
8493
c5c10118
TT
84942019-04-08 Tom Tromey <tom@tromey.com>
8495
8496 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8497 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8498 (TRY, CATCH, END_CATCH): Remove some definitions.
8499 * common/common-exceptions.c: Don't use GDB_XCPT.
8500 (catcher_list_size): Remove.
8501 (throw_exception, throw_it): Simplify.
8502
4de283e4
TT
85032019-04-05 Tom Tromey <tom@tromey.com>
8504
8505 Revert the header-sorting patch.
8506 * ft32-tdep.c: Revert.
8507 * frv-tdep.c: Revert.
8508 * frv-linux-tdep.c: Revert.
8509 * frame.c: Revert.
8510 * frame-unwind.c: Revert.
8511 * frame-base.c: Revert.
8512 * fork-child.c: Revert.
8513 * findvar.c: Revert.
8514 * findcmd.c: Revert.
8515 * filesystem.c: Revert.
8516 * filename-seen-cache.h: Revert.
8517 * filename-seen-cache.c: Revert.
8518 * fbsd-tdep.c: Revert.
8519 * fbsd-nat.h: Revert.
8520 * fbsd-nat.c: Revert.
8521 * f-valprint.c: Revert.
8522 * f-typeprint.c: Revert.
8523 * f-lang.c: Revert.
8524 * extension.h: Revert.
8525 * extension.c: Revert.
8526 * extension-priv.h: Revert.
8527 * expprint.c: Revert.
8528 * exec.h: Revert.
8529 * exec.c: Revert.
8530 * exceptions.c: Revert.
8531 * event-top.c: Revert.
8532 * event-loop.c: Revert.
8533 * eval.c: Revert.
8534 * elfread.c: Revert.
8535 * dwarf2read.h: Revert.
8536 * dwarf2read.c: Revert.
8537 * dwarf2loc.c: Revert.
8538 * dwarf2expr.h: Revert.
8539 * dwarf2expr.c: Revert.
8540 * dwarf2-frame.c: Revert.
8541 * dwarf2-frame-tailcall.c: Revert.
8542 * dwarf-index-write.h: Revert.
8543 * dwarf-index-write.c: Revert.
8544 * dwarf-index-common.c: Revert.
8545 * dwarf-index-cache.h: Revert.
8546 * dwarf-index-cache.c: Revert.
8547 * dummy-frame.c: Revert.
8548 * dtrace-probe.c: Revert.
8549 * disasm.h: Revert.
8550 * disasm.c: Revert.
8551 * disasm-selftests.c: Revert.
8552 * dictionary.c: Revert.
8553 * dicos-tdep.c: Revert.
8554 * demangle.c: Revert.
8555 * dcache.h: Revert.
8556 * dcache.c: Revert.
8557 * darwin-nat.h: Revert.
8558 * darwin-nat.c: Revert.
8559 * darwin-nat-info.c: Revert.
8560 * d-valprint.c: Revert.
8561 * d-namespace.c: Revert.
8562 * d-lang.c: Revert.
8563 * ctf.c: Revert.
8564 * csky-tdep.c: Revert.
8565 * csky-linux-tdep.c: Revert.
8566 * cris-tdep.c: Revert.
8567 * cris-linux-tdep.c: Revert.
8568 * cp-valprint.c: Revert.
8569 * cp-support.c: Revert.
8570 * cp-namespace.c: Revert.
8571 * cp-abi.c: Revert.
8572 * corelow.c: Revert.
8573 * corefile.c: Revert.
8574 * continuations.c: Revert.
8575 * completer.h: Revert.
8576 * completer.c: Revert.
8577 * complaints.c: Revert.
8578 * coffread.c: Revert.
8579 * coff-pe-read.c: Revert.
8580 * cli-out.h: Revert.
8581 * cli-out.c: Revert.
8582 * charset.c: Revert.
8583 * c-varobj.c: Revert.
8584 * c-valprint.c: Revert.
8585 * c-typeprint.c: Revert.
8586 * c-lang.c: Revert.
8587 * buildsym.c: Revert.
8588 * buildsym-legacy.c: Revert.
8589 * build-id.h: Revert.
8590 * build-id.c: Revert.
8591 * btrace.c: Revert.
8592 * bsd-uthread.c: Revert.
8593 * breakpoint.h: Revert.
8594 * breakpoint.c: Revert.
8595 * break-catch-throw.c: Revert.
8596 * break-catch-syscall.c: Revert.
8597 * break-catch-sig.c: Revert.
8598 * blockframe.c: Revert.
8599 * block.c: Revert.
8600 * bfin-tdep.c: Revert.
8601 * bfin-linux-tdep.c: Revert.
8602 * bfd-target.c: Revert.
8603 * bcache.c: Revert.
8604 * ax-general.c: Revert.
8605 * ax-gdb.h: Revert.
8606 * ax-gdb.c: Revert.
8607 * avr-tdep.c: Revert.
8608 * auxv.c: Revert.
8609 * auto-load.c: Revert.
8610 * arm-wince-tdep.c: Revert.
8611 * arm-tdep.c: Revert.
8612 * arm-symbian-tdep.c: Revert.
8613 * arm-pikeos-tdep.c: Revert.
8614 * arm-obsd-tdep.c: Revert.
8615 * arm-nbsd-tdep.c: Revert.
8616 * arm-nbsd-nat.c: Revert.
8617 * arm-linux-tdep.c: Revert.
8618 * arm-linux-nat.c: Revert.
8619 * arm-fbsd-tdep.c: Revert.
8620 * arm-fbsd-nat.c: Revert.
8621 * arm-bsd-tdep.c: Revert.
8622 * arch-utils.c: Revert.
8623 * arc-tdep.c: Revert.
8624 * arc-newlib-tdep.c: Revert.
8625 * annotate.h: Revert.
8626 * annotate.c: Revert.
8627 * amd64-windows-tdep.c: Revert.
8628 * amd64-windows-nat.c: Revert.
8629 * amd64-tdep.c: Revert.
8630 * amd64-sol2-tdep.c: Revert.
8631 * amd64-obsd-tdep.c: Revert.
8632 * amd64-obsd-nat.c: Revert.
8633 * amd64-nbsd-tdep.c: Revert.
8634 * amd64-nbsd-nat.c: Revert.
8635 * amd64-nat.c: Revert.
8636 * amd64-linux-tdep.c: Revert.
8637 * amd64-linux-nat.c: Revert.
8638 * amd64-fbsd-tdep.c: Revert.
8639 * amd64-fbsd-nat.c: Revert.
8640 * amd64-dicos-tdep.c: Revert.
8641 * amd64-darwin-tdep.c: Revert.
8642 * amd64-bsd-nat.c: Revert.
8643 * alpha-tdep.c: Revert.
8644 * alpha-obsd-tdep.c: Revert.
8645 * alpha-nbsd-tdep.c: Revert.
8646 * alpha-mdebug-tdep.c: Revert.
8647 * alpha-linux-tdep.c: Revert.
8648 * alpha-linux-nat.c: Revert.
8649 * alpha-bsd-tdep.c: Revert.
8650 * alpha-bsd-nat.c: Revert.
8651 * aix-thread.c: Revert.
8652 * agent.c: Revert.
8653 * addrmap.c: Revert.
8654 * ada-varobj.c: Revert.
8655 * ada-valprint.c: Revert.
8656 * ada-typeprint.c: Revert.
8657 * ada-tasks.c: Revert.
8658 * ada-lang.c: Revert.
8659 * aarch64-tdep.c: Revert.
8660 * aarch64-ravenscar-thread.c: Revert.
8661 * aarch64-newlib-tdep.c: Revert.
8662 * aarch64-linux-tdep.c: Revert.
8663 * aarch64-linux-nat.c: Revert.
8664 * aarch64-fbsd-tdep.c: Revert.
8665 * aarch64-fbsd-nat.c: Revert.
8666 * aarch32-linux-nat.c: Revert.
8667
d55e5aa6
TT
86682019-04-05 Tom Tromey <tom@tromey.com>
8669
8670 * ft32-tdep.c: Sort headers.
8671 * frv-tdep.c: Sort headers.
8672 * frv-linux-tdep.c: Sort headers.
8673 * frame.c: Sort headers.
8674 * frame-unwind.c: Sort headers.
8675 * frame-base.c: Sort headers.
8676 * fork-child.c: Sort headers.
8677 * findvar.c: Sort headers.
8678 * findcmd.c: Sort headers.
8679 * filesystem.c: Sort headers.
8680 * filename-seen-cache.h: Sort headers.
8681 * filename-seen-cache.c: Sort headers.
8682 * fbsd-tdep.c: Sort headers.
8683 * fbsd-nat.h: Sort headers.
8684 * fbsd-nat.c: Sort headers.
8685 * f-valprint.c: Sort headers.
8686 * f-typeprint.c: Sort headers.
8687 * f-lang.c: Sort headers.
8688 * extension.h: Sort headers.
8689 * extension.c: Sort headers.
8690 * extension-priv.h: Sort headers.
8691 * expprint.c: Sort headers.
8692 * exec.h: Sort headers.
8693 * exec.c: Sort headers.
8694 * exceptions.c: Sort headers.
8695 * event-top.c: Sort headers.
8696 * event-loop.c: Sort headers.
8697 * eval.c: Sort headers.
8698 * elfread.c: Sort headers.
8699 * dwarf2read.h: Sort headers.
8700 * dwarf2read.c: Sort headers.
8701 * dwarf2loc.c: Sort headers.
8702 * dwarf2expr.h: Sort headers.
8703 * dwarf2expr.c: Sort headers.
8704 * dwarf2-frame.c: Sort headers.
8705 * dwarf2-frame-tailcall.c: Sort headers.
8706 * dwarf-index-write.h: Sort headers.
8707 * dwarf-index-write.c: Sort headers.
8708 * dwarf-index-common.c: Sort headers.
8709 * dwarf-index-cache.h: Sort headers.
8710 * dwarf-index-cache.c: Sort headers.
8711 * dummy-frame.c: Sort headers.
8712 * dtrace-probe.c: Sort headers.
8713 * disasm.h: Sort headers.
8714 * disasm.c: Sort headers.
8715 * disasm-selftests.c: Sort headers.
8716 * dictionary.c: Sort headers.
8717 * dicos-tdep.c: Sort headers.
8718 * demangle.c: Sort headers.
8719 * dcache.h: Sort headers.
8720 * dcache.c: Sort headers.
8721 * darwin-nat.h: Sort headers.
8722 * darwin-nat.c: Sort headers.
8723 * darwin-nat-info.c: Sort headers.
8724 * d-valprint.c: Sort headers.
8725 * d-namespace.c: Sort headers.
8726 * d-lang.c: Sort headers.
8727 * ctf.c: Sort headers.
8728 * csky-tdep.c: Sort headers.
8729 * csky-linux-tdep.c: Sort headers.
8730 * cris-tdep.c: Sort headers.
8731 * cris-linux-tdep.c: Sort headers.
8732 * cp-valprint.c: Sort headers.
8733 * cp-support.c: Sort headers.
8734 * cp-namespace.c: Sort headers.
8735 * cp-abi.c: Sort headers.
8736 * corelow.c: Sort headers.
8737 * corefile.c: Sort headers.
8738 * continuations.c: Sort headers.
8739 * completer.h: Sort headers.
8740 * completer.c: Sort headers.
8741 * complaints.c: Sort headers.
8742 * coffread.c: Sort headers.
8743 * coff-pe-read.c: Sort headers.
8744 * cli-out.h: Sort headers.
8745 * cli-out.c: Sort headers.
8746 * charset.c: Sort headers.
8747 * c-varobj.c: Sort headers.
8748 * c-valprint.c: Sort headers.
8749 * c-typeprint.c: Sort headers.
8750 * c-lang.c: Sort headers.
8751 * buildsym.c: Sort headers.
8752 * buildsym-legacy.c: Sort headers.
8753 * build-id.h: Sort headers.
8754 * build-id.c: Sort headers.
8755 * btrace.c: Sort headers.
8756 * bsd-uthread.c: Sort headers.
8757 * breakpoint.h: Sort headers.
8758 * breakpoint.c: Sort headers.
8759 * break-catch-throw.c: Sort headers.
8760 * break-catch-syscall.c: Sort headers.
8761 * break-catch-sig.c: Sort headers.
8762 * blockframe.c: Sort headers.
8763 * block.c: Sort headers.
8764 * bfin-tdep.c: Sort headers.
8765 * bfin-linux-tdep.c: Sort headers.
8766 * bfd-target.c: Sort headers.
8767 * bcache.c: Sort headers.
8768 * ax-general.c: Sort headers.
8769 * ax-gdb.h: Sort headers.
8770 * ax-gdb.c: Sort headers.
8771 * avr-tdep.c: Sort headers.
8772 * auxv.c: Sort headers.
8773 * auto-load.c: Sort headers.
8774 * arm-wince-tdep.c: Sort headers.
8775 * arm-tdep.c: Sort headers.
8776 * arm-symbian-tdep.c: Sort headers.
8777 * arm-pikeos-tdep.c: Sort headers.
8778 * arm-obsd-tdep.c: Sort headers.
8779 * arm-nbsd-tdep.c: Sort headers.
8780 * arm-nbsd-nat.c: Sort headers.
8781 * arm-linux-tdep.c: Sort headers.
8782 * arm-linux-nat.c: Sort headers.
8783 * arm-fbsd-tdep.c: Sort headers.
8784 * arm-fbsd-nat.c: Sort headers.
8785 * arm-bsd-tdep.c: Sort headers.
8786 * arch-utils.c: Sort headers.
8787 * arc-tdep.c: Sort headers.
8788 * arc-newlib-tdep.c: Sort headers.
8789 * annotate.h: Sort headers.
8790 * annotate.c: Sort headers.
8791 * amd64-windows-tdep.c: Sort headers.
8792 * amd64-windows-nat.c: Sort headers.
8793 * amd64-tdep.c: Sort headers.
8794 * amd64-sol2-tdep.c: Sort headers.
8795 * amd64-obsd-tdep.c: Sort headers.
8796 * amd64-obsd-nat.c: Sort headers.
8797 * amd64-nbsd-tdep.c: Sort headers.
8798 * amd64-nbsd-nat.c: Sort headers.
8799 * amd64-nat.c: Sort headers.
8800 * amd64-linux-tdep.c: Sort headers.
8801 * amd64-linux-nat.c: Sort headers.
8802 * amd64-fbsd-tdep.c: Sort headers.
8803 * amd64-fbsd-nat.c: Sort headers.
8804 * amd64-dicos-tdep.c: Sort headers.
8805 * amd64-darwin-tdep.c: Sort headers.
8806 * amd64-bsd-nat.c: Sort headers.
8807 * alpha-tdep.c: Sort headers.
8808 * alpha-obsd-tdep.c: Sort headers.
8809 * alpha-nbsd-tdep.c: Sort headers.
8810 * alpha-mdebug-tdep.c: Sort headers.
8811 * alpha-linux-tdep.c: Sort headers.
8812 * alpha-linux-nat.c: Sort headers.
8813 * alpha-bsd-tdep.c: Sort headers.
8814 * alpha-bsd-nat.c: Sort headers.
8815 * aix-thread.c: Sort headers.
8816 * agent.c: Sort headers.
8817 * addrmap.c: Sort headers.
8818 * ada-varobj.c: Sort headers.
8819 * ada-valprint.c: Sort headers.
8820 * ada-typeprint.c: Sort headers.
8821 * ada-tasks.c: Sort headers.
8822 * ada-lang.c: Sort headers.
8823 * aarch64-tdep.c: Sort headers.
8824 * aarch64-ravenscar-thread.c: Sort headers.
8825 * aarch64-newlib-tdep.c: Sort headers.
8826 * aarch64-linux-tdep.c: Sort headers.
8827 * aarch64-linux-nat.c: Sort headers.
8828 * aarch64-fbsd-tdep.c: Sort headers.
8829 * aarch64-fbsd-nat.c: Sort headers.
8830 * aarch32-linux-nat.c: Sort headers.
8831
699bd4cf
TT
88322019-04-04 Tom Tromey <tom@tromey.com>
8833
8834 * varobj.c (varobj_create): Update.
8835 * rust-exp.y (struct rust_parser) <update_innermost_block,
8836 lookup_symbol>: New methods.
8837 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8838 Rename.
8839 (rust_parser::rust_lookup_type)
8840 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8841 * printcmd.c (display_command, do_one_display): Update.
8842 * parser-defs.h (struct parser_state) <parser_state>: Add
8843 "tracker" parameter.
8844 (block_tracker): New member.
8845 (class innermost_block_tracker) <innermost_block_tracker>: Add
8846 "types" parameter.
8847 <reset>: Remove method.
8848 (innermost_block): Don't declare.
8849 (null_post_parser): Update.
8850 * parse.c (innermost_block): Remove global.
8851 (write_dollar_variable): Update.
8852 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8853 Remove "tracker_types" parameter.
8854 (parse_expression): Add "tracker" parameter.
8855 (parse_expression_for_completion): Update.
8856 (null_post_parser): Add "tracker" parameter.
8857 * p-exp.y: Update rules.
8858 * m2-exp.y: Update rules.
8859 * language.h (struct language_defn) <la_post_parser>: Add
8860 "tracker" parameter.
8861 * go-exp.y: Update rules.
8862 * f-exp.y: Update rules.
8863 * expression.h (parse_expression, parse_exp_1): Add "tracker"
8864 parameter.
8865 * d-exp.y: Update rules.
8866 * c-exp.y: Update rules.
8867 * breakpoint.c (set_breakpoint_condition): Create an
8868 innermost_block_tracker.
8869 (watch_command_1): Likewise.
8870 * ada-lang.c (resolve): Add "tracker" parameter.
8871 (resolve_subexp): Likewise.
8872 * ada-exp.y (write_var_from_sym): Update.
8873
dac43e32
TT
88742019-04-04 Tom Tromey <tom@tromey.com>
8875
8876 * type-stack.h: New file.
8877 * type-stack.c: New file.
8878 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8879 type-stack.h.
8880 (insert_into_type_stack, insert_type, push_type, push_type_int)
8881 (insert_type_address_space, pop_type, pop_type_int)
8882 (pop_typelist, pop_type_stack, append_type_stack)
8883 (push_type_stack, get_type_stack, push_typelist)
8884 (follow_type_instance_flags, follow_types): Don't declare.
8885 * parse.c (type_stack): Remove global.
8886 (parse_exp_in_context): Update.
8887 (insert_into_type_stack, insert_type, push_type, push_type_int)
8888 (insert_type_address_space, pop_type, pop_type_int)
8889 (pop_typelist, pop_type_stack, append_type_stack)
8890 (push_type_stack, get_type_stack, push_typelist)
8891 (follow_type_instance_flags, follow_types): Remove (moved to
8892 type-stack.c).
8893 * f-exp.y (type_stack): New global.
8894 Update rules.
8895 (push_kind_type, f_parse): Update.
8896 * d-exp.y (type_stack): New global.
8897 Update rules.
8898 (d_parse): Update.
8899 * c-exp.y (struct c_parse_state) <type_stack>: New member.
8900 Update rules.
8901 * Makefile.in (COMMON_SFILES): Add type-stack.c.
8902 (HFILES_NO_SRCDIR): Add type-stack.h.
8903
2a612529
TT
89042019-04-04 Tom Tromey <tom@tromey.com>
8905
8906 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8907 (rust_parser::convert_ast_to_expression, rust_parse)
8908 (rust_lex_test_completion, rust_lex_tests): Update.
8909 * parser-defs.h (struct expr_completion_state): New.
8910 (struct parser_state) <parser_state>: Add completion parameter.
8911 <mark_struct_expression, mark_completion_tag>: New methods.
8912 <parse_completion, m_completion_state>: New members.
8913 (prefixify_expression, null_post_parser): Update.
8914 (mark_struct_expression, mark_completion_tag): Don't declare.
8915 * parse.c (parse_completion, expout_last_struct)
8916 (expout_tag_completion_type, expout_completion_name): Remove
8917 globals.
8918 (parser_state::mark_struct_expression)
8919 (parser_state::mark_completion_tag): Now methods.
8920 (prefixify_expression): Add last_struct parameter.
8921 (prefixify_subexp): Likewise.
8922 (parse_exp_1): Update.
8923 (parse_exp_in_context): Add cstate parameter. Update.
8924 (parse_expression_for_completion): Create an
8925 expr_completion_state.
8926 (null_post_parser): Add "completion" parameter.
8927 * p-exp.y: Update rules.
8928 (yylex): Update.
8929 * language.h (struct language_defn) <la_post_parser>: Add
8930 "completing" parameter.
8931 * go-exp.y: Update rules.
8932 (lex_one_token): Update.
8933 * expression.h (parse_completion): Don't declare.
8934 * d-exp.y: Update rules.
8935 (lex_one_token): Update rules.
8936 * c-exp.y: Update rules.
8937 (lex_one_token): Update.
8938 * ada-lang.c (resolve): Add "parse_completion" parameter.
8939 (resolve_subexp): Likewise.
8940 (ada_resolve_function): Likewise.
8941
43476f0b
TT
89422019-04-04 Tom Tromey <tom@tromey.com>
8943
8944 * parser-defs.h (struct parser_state) <start_arglist,
8945 end_arglist>: New methods.
8946 <arglist_len, m_funcall_chain>: New members.
8947 (arglist_len, start_arglist, end_arglist): Don't declare.
8948 * parse.c (arglist_len, funcall_chain): Remove global.
8949 (start_arglist, end_arglist): Remove functions.
8950 (parse_exp_in_context): Update.
8951 * p-exp.y: Update rules.
8952 * m2-exp.y: Update rules.
8953 * go-exp.y: Update rules.
8954 * f-exp.y: Update rules.
8955 * d-exp.y: Update rules.
8956 * c-exp.y: Update rules.
8957
5776fca3
TT
89582019-04-04 Tom Tromey <tom@tromey.com>
8959
8960 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8961 lex_operator, push_back>: New methods.
8962 Update all rules.
8963 (rust_parser::lex_hex, lex_escape): Rename and update.
8964 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8965 (rust_parser::lex_operator): Rename and update.
8966 (rust_parser::lex_number, rustyylex, rustyyerror)
8967 (rust_lex_test_init, rust_lex_test_sequence)
8968 (rust_lex_test_push_back, rust_lex_tests): Update.
8969 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8970 parameter.
8971 <lexptr, prev_lexptr>: New members.
8972 (lexptr, prev_lexptr): Don't declare.
8973 * parse.c (lexptr, prev_lexptr): Remove globals.
8974 (parse_exp_in_context): Update.
8975 * p-exp.y (yylex, yyerror): Update.
8976 * m2-exp.y (parse_number, yylex, yyerror): Update.
8977 * go-exp.y (lex_one_token, yyerror): Update.
8978 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8979 * d-exp.y (lex_one_token, yyerror): Update.
8980 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8981 (lex_one_token, yyerror): Update.
8982 * ada-lex.l (YY_INPUT): Update.
8983 (rewind_to_char): Update.
8984 * ada-exp.y (yyerror): Update.
8985
8621b685
TT
89862019-04-04 Tom Tromey <tom@tromey.com>
8987
8988 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8989 * parser-defs.h (struct parser_state) <parser_state>: Add new
8990 parameter.
8991 <comma_terminates>: New member.
8992 (comma_terminates): Don't declare global.
8993 * parse.c (comma_terminates): Remove global.
8994 (parse_exp_in_context): Update.
8995 * p-exp.y (yylex): Update.
8996 * m2-exp.y (yylex): Update.
8997 * go-exp.y (lex_one_token): Update.
8998 * f-exp.y (yylex): Update.
8999 * d-exp.y (lex_one_token): Update.
9000 * c-exp.y (lex_one_token): Update.
9001 * ada-lex.l: Update.
9002
28aaf3fd
TT
90032019-04-04 Tom Tromey <tom@tromey.com>
9004
9005 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9006 (rustyylex, rust_lex_test_init, rust_lex_test_one)
9007 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9008 * parser-defs.h (paren_depth): Don't declare.
9009 * parse.c (paren_depth): Remove global.
9010 (parse_exp_in_context): Update.
9011 * p-exp.y (paren_depth): New global.
9012 (pascal_parse): Initialize it.
9013 * m2-exp.y (paren_depth): New global.
9014 (m2_parse): Initialize it.
9015 * go-exp.y (paren_depth): New global.
9016 (go_parse): Initialize it.
9017 * f-exp.y (paren_depth): New global.
9018 (f_parse): Initialize it.
9019 * d-exp.y (paren_depth): New global.
9020 (d_parse): Initialize it.
9021 * c-exp.y (paren_depth): New global.
9022 (c_parse): Initialize it.
9023 * ada-lex.l (paren_depth): New global.
9024 (lexer_init): Initialize it.
9025
1e58a4a4
TT
90262019-04-04 Tom Tromey <tom@tromey.com>
9027
9028 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9029 (rust_parser::convert_ast_to_type)
9030 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9031 * parser-defs.h (struct parser_state) <parser_state>: Add
9032 parameters. Initialize new members.
9033 <expression_context_block, expression_context_pc>: New members.
9034 * parse.c (expression_context_block, expression_context_pc):
9035 Remove globals.
9036 (parse_exp_in_context): Update.
9037 * p-exp.y: Update all rules.
9038 (yylex): Update.
9039 * m2-exp.y: Update all rules.
9040 (yylex): Update.
9041 * go-exp.y (yylex): Update.
9042 * f-exp.y (yylex): Update.
9043 * d-exp.y: Update all rules.
9044 (yylex): Update.
9045 * c-exp.y: Update all rules.
9046 (lex_one_token, classify_name, yylex, c_parse): Update.
9047 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9048
37eedb39
TT
90492019-04-04 Tom Tromey <tom@tromey.com>
9050
9051 * gdbarch.h, gdbarch.c: Rebuild.
9052 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9053 * stap-probe.h:
9054 (struct stap_parse_info): Replace "parser_state" with
9055 "expr_builder".
9056 * parser-defs.h (struct expr_builder): Rename from "parser_state".
9057 (parser_state): New class.
9058 * parse.c (expr_builder): Rename.
9059 (expr_builder::release): Rename.
9060 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9061 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9062 (write_exp_elt_longcst, write_exp_elt_floatcst)
9063 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9064 (write_exp_string_vector, write_exp_bitstring)
9065 (write_exp_msymbol, mark_struct_expression)
9066 (write_dollar_variable)
9067 (insert_type_address_space, increase_expout_size): Replace
9068 "parser_state" with "expr_builder".
9069 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9070 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9071 "parser_state" with "expr_builder".
9072
73923d7e
TT
90732019-04-04 Tom Tromey <tom@tromey.com>
9074
9075 * rust-exp.y: Replace "parse_language" with method call.
9076 * p-exp.y:
9077 (yylex): Replace "parse_language" with method call.
9078 * m2-exp.y:
9079 (yylex): Replace "parse_language" with method call.
9080 * go-exp.y (classify_name): Replace "parse_language" with method
9081 call.
9082 * f-exp.y (yylex): Replace "parse_language" with method call.
9083 * d-exp.y (lex_one_token): Replace "parse_language" with method
9084 call.
9085 * c-exp.y:
9086 (lex_one_token, classify_name, yylex): Replace "parse_language"
9087 with method call.
9088 * ada-exp.y (find_primitive_type, type_char)
9089 (type_system_address): Replace "parse_language" with method call.
9090
fa9f5be6
TT
90912019-04-04 Tom Tromey <tom@tromey.com>
9092
9093 * rust-exp.y: Replace "parse_gdbarch" with method call.
9094 * parse.c (write_dollar_variable, insert_type_address_space):
9095 Replace "parse_gdbarch" with method call.
9096 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9097 call.
9098 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9099 call.
9100 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9101 "parse_gdbarch" with method call.
9102 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9103 with method call.
9104 * f-exp.y (parse_type, parse_f_type, yylex): Replace
9105 "parse_gdbarch" with method call.
9106 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9107 "parse_gdbarch" with method call.
9108 * c-exp.y (parse_type, parse_number, classify_name): Replace
9109 "parse_gdbarch" with method call.
9110 * ada-lex.l: Replace "parse_gdbarch" with method call.
9111 * ada-exp.y (parse_type, find_primitive_type, type_char)
9112 (type_system_address): Replace "parse_gdbarch" with method call.
9113
1201a264
TT
91142019-04-04 Tom Tromey <tom@tromey.com>
9115
9116 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9117 * stap-probe.c (stap_parse_argument): Update.
9118 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9119 initial_size parameter.
9120 * rust-exp.y (rust_lex_tests): Update.
9121 * parse.c (parser_state): Update.
9122 (parse_exp_in_context): Update.
9123 * parser-defs.h (struct parser_state) <parser_state>: Remove
9124 "initial_size" parameter.
9125
e3980ce2
TT
91262019-04-04 Tom Tromey <tom@tromey.com>
9127
9128 * parser-defs.h (increase_expout_size): Don't declare.
9129 * parse.c (increase_expout_size): Now static.
9130
e9f8e3f1
TS
91312019-04-04 Thomas Schwinge <thomas@codesourcery.com>
9132
9133 * gnu-nat.c (gnu_nat_target::wait): Fix
9134 target_waitstatus_to_string call.
9135
d7df6549
AB
91362019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9137
9138 * eval.c (evaluate_subexp_standard): Handle internal functions
9139 during Fortran function call handling.
9140
8bdc1658
AB
91412019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9142
9143 * NEWS: Mention new internal functions.
9144 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9145 (read_base_type): Use dwarf2_init_complex_target_type.
9146 * value.c (creal_internal_fn): New function.
9147 (cimag_internal_fn): New function.
9148 (_initialize_values): Register new internal functions.
9149
c29705b7
PW
91502019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9151
9152 * infrun.c (stop_all_threads): If debug_infrun, always
9153 trace the wait status after wait_one, using
9154 target_waitstatus_to_string and target_pid_to_str.
9155 (handle_inferior_event): Replace various trace of
9156 wait status kind by a single trace.
9157 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9158 wait status kind image by target_waitstatus_to_string.
9159 * target/waitstatus.c (target_waitstatus_to_string): Fix
9160 obsolete comment.
9161
05caa1d2
TT
91622019-04-01 Tom Tromey <tromey@adacore.com>
9163
9164 PR symtab/23331:
9165 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9166
9d1447e0
SDJ
91672019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
9168 Pedro Alves <palves@redhat.com>
9169
9170 * top.c (quit_force): Call 'finalize_values'.
9171 * value.c (finalize_values): New function.
9172 * value.h (finalize_values): Declare.
9173
7734102d
EZ
91742019-03-30 Eli Zaretskii <eliz@gnu.org>
9175
9176 * NEWS: Announce $_gdb_major and $_gdb_minor.
9177
9178 * top.c (init_gdb_version_vars): New function.
9179 (gdb_init): Call init_gdb_version_vars.
9180
188e1fa9
TT
91812019-03-29 Tom Tromey <tromey@adacore.com>
9182
9183 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
9184 help text. Remove dead code.
9185
2880242d
KS
91862019-03-29 Keith Seitz <keiths@redhat.com>
9187
9188 From Siddhesh Poyarekar:
9189 * f-lang.h (f77_get_upperbound): Return LONGEST.
9190 (f77_get_lowerbound): Likewise.
9191 * f-typeprint.c (f_type_print_varspec_suffix): Expand
9192 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
9193 print them.
9194 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
9195 plongest to format print it.
9196 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9197 (f77_get_upperbound): Likewise.
9198 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9199 LOWER_BOUND to LONGEST.
9200 (f77_create_arrayprint_offset_tbl): Likewise.
9201
cc1defb1
KS
92022019-03-29 Keith Seitz <keiths@redhat.com>
9203
9204 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9205 %s/pulongest for TYPE_LENGTH instead of %d in format
9206 strings.
9207 * ada-typerint.c (ada_print_type): Likewise.
9208 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9209 * compile/compile-c-support.c (generate_register_struct): Likewise.
9210 * gdbtypes.c (recursive_dump_type): Likewise.
9211 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9212 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
9213 instead of %d in format strings.
9214 * riscv-tdep.c (riscv_type_alignment): Cast second argument
9215 to std::min to ULONGEST.
9216 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9217 instead of %d in format strings.
9218 * tracepoint.c (info_scope_command): Likewise.
9219 * typeprint.c (print_offset_data::update)
9220 (print_offset_data::finish): Likewise.
9221 * xtensa-tdep.c (xtensa_store_return_value)
9222 (xtensa_push_dummy_call): Likewise.
9223
e432ccf1
JT
92242019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
9225
9226 * windows-nat.c (display_selector): Fixed format specifications
9227 for 64-bit Cygwin.
9228
65d2b333
PW
92292019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9230
9231 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9232
f489207e
SL
92332019-03-28 Sandra Loosemore <sandra@codesourcery.com>
9234
9235 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9236 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9237 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9238 (nios2_linux_init_abi): Install it.
9239
bffa1015
AH
92402019-03-28 Alan Hayward <alan.hayward@arm.com>
9241
9242 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9243
fc96163a
AH
92442019-03-28 Alan Hayward <alan.hayward@arm.com>
9245
9246 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9247
20dc7e9b
PW
92482019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9249 Tom Tromey <tromey@adacore.com>
9250
9251 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9252
7f5331a8
JB
92532019-03-26 Joel Brobecker <brobecker@adacore.com>
9254
9255 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9256 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9257 method to compute the bounds of range types. Also print "[evaluated]"
9258 if the bounds' values come from a dynamic evaluation.
9259
18c77628
AB
92602019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
9261
9262 * cp-valprint.c (cp_print_value_fields): Don't print trailing
9263 whitespace when pretty printing is on.
9264
53c973f2
AH
92652019-03-26 Alan Hayward <alan.hayward@arm.com>
9266
e79be6e5 9267 * ppc-linux-nat.c: Add include.
53c973f2 9268
d851aa71
AH
92692019-03-26 Alan Hayward <alan.hayward@arm.com>
9270
e79be6e5 9271 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 9272
2fe7bab7
AH
92732019-03-26 Alan Hayward <alan.hayward@arm.com>
9274
e79be6e5 9275 * arm-linux-nat.c: Add include.
2fe7bab7 9276
068ef30e
SM
92772019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
9278
9279 * source-cache.c (source_cache::get_source_lines): Re-read
9280 fullname after calling open_source_file.
9281
81a24d04
JB
92822019-03-25 John Baldwin <jhb@FreeBSD.org>
9283
9284 * NEWS: Mention TLS support for FreeBSD.
9285
79e7ae11
TT
92862019-03-25 Tom Tromey <tromey@adacore.com>
9287
9288 * minsyms.c (BUNCH_SIZE): Update comment.
9289 (~minimal_symbol_reader): Remove old comment.
9290 (compact_minimal_symbols): Update comment.
9291 (minimal_symbol_reader::install): Remove old comment. Update
9292 other comments.
9293
d45963c2
AH
92942019-03-25 Alan Hayward <alan.hayward@arm.com>
9295
9296 * s390-linux-nat.c: Add include.
9297
0f83012e
AH
92982019-03-25 Alan Hayward <alan.hayward@arm.com>
9299
9300 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9301 Call linux_get_hwcap.
9302 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9303 Likewise.
9304 (aarch64_linux_get_hwcap): Remove function.
9305 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9306 declaration.
9307 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9308 linux_get_hwcap.
9309 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9310 * linux-tdep.c (linux_get_hwcap): Add function.
9311 (linux_get_hwcap2): Likewise.
9312 * linux-tdep.h (linux_get_hwcap): Add declaration.
9313 (linux_get_hwcap2): Likewise.
9314 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9315 (ppc_linux_get_hwcap2): Likewise.
9316 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9317 linux_get_hwcap.
9318 (ppc_linux_nat_target::insert_watchpoint): Likewise.
9319 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9320 (ppc_linux_nat_target::read_description): Likewise.
9321 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9322 * s390-linux-nat.c: Likewise.
9323 * s390-linux-tdep.c (s390_core_read_description): Likewise.
9324
6640a367
TT
93252019-03-24 Tom Tromey <tom@tromey.com>
9326
9327 * ada-lang.c (standard_lookup): Simplify initialization.
9328 (ada_lookup_symbol_nonlocal): Simplify return.
9329 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9330 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9331 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9332 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9333 initialization.
9334 * solib.c (solib_global_lookup): Simplify.
9335 * symtab.c (null_block_symbol): Remove.
9336 (symbol_cache_lookup): Simplify returns.
9337 (lookup_language_this): Simplify returns.
9338 (lookup_symbol_aux): Simplify return.
9339 (lookup_local_symbol): Simplify returns.
9340 (lookup_global_symbol_from_objfile): Simplify return.
9341 (lookup_symbol_in_objfile_symtabs)
9342 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9343 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9344 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9345 * cp-namespace.c (cp_lookup_bare_symbol)
9346 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9347 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9348 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9349 (cp_lookup_symbol_via_imports): Simplify initialization.
9350 (find_symbol_in_baseclass): Likewise.
9351 * symtab.h (null_block_symbol): Remove.
9352 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9353 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9354 (d_lookup_symbol_module): Likewise.
9355 (find_symbol_in_baseclass): Simplify initialization.
9356
a930ebcd
TT
93572019-03-24 Tom Tromey <tom@tromey.com>
9358
9359 * expression.h: Don't include symtab.h.
9360 (struct block): Forward declare.
9361
582942f4
TT
93622019-03-24 Tom Tromey <tom@tromey.com>
9363
9364 * c-exp.y (typebase): Remove casts.
9365 * gdbtypes.c (lookup_unsigned_typename, )
9366 (lookup_signed_typename): Remove cast.
9367 * eval.c (parse_to_comma_and_eval): Remove cast.
9368 * parse.c (write_dollar_variable): Remove cast.
9369 * block.h (struct block) <superblock>: Now const.
9370 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9371 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9372 (map_block): Make "block" const.
9373 * symfile.h (struct quick_symbol_functions)
9374 <map_matching_symbols>: Constify block argument to "callback".
9375 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9376 const.
9377 (find_pc_sect_compunit_symtab): Make "b" const.
9378 (find_symbol_at_address): Likewise.
9379 (search_symbols): Likewise.
9380 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9381 (dw2_debug_names_lookup_symbol): Likewise.
9382 (dw2_map_matching_symbols): Update.
9383 * p-valprint.c (pascal_val_print): Remove "block".
9384 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9385 (aux_add_nonlocal_symbols): Make "block" const.
9386 (resolve_subexp): Remove cast.
9387 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9388 const.
9389 (iterate_over_file_blocks): Likewise.
9390 * f-exp.y (%union) <bval>: Remove.
9391 * coffread.c (patch_opaque_types): Make "b" const.
9392 * spu-tdep.c (spu_catch_start): Make "block" const.
9393 * c-valprint.c (print_unpacked_pointer): Remove "block".
9394 * symmisc.c (dump_symtab_1): Make "b" const.
9395 (block_depth): Make "block" const.
9396 * d-exp.y (%union) <bval>: Remove.
9397 * cp-support.h (cp_lookup_rtti_type): Update.
9398 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9399 * psymtab.c (psym_lookup_symbol): Make "block" const.
9400 (maintenance_check_psymtabs): Make "b" const.
9401 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9402 (enumerate_locals, enumerate_args): Update.
9403 * python/py-symtab.c (stpy_global_block): Make "block" const.
9404 (stpy_static_block): Likewise.
9405 * inline-frame.c (block_starting_point_at): Make "new_block"
9406 const.
9407 * block.c (find_block_in_blockvector): Make return type const.
9408 (blockvector_for_pc_sect): Make "b" const.
9409 (find_block_in_blockvector): Make "b" const.
9410
7ad417dd
TT
94112019-03-23 Tom Tromey <tom@tromey.com>
9412
9413 * varobj.c (varobj_create): Update.
9414 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9415 * printcmd.c (display_command, do_one_display): Don't reset
9416 innermost_block.
9417 * parser-defs.h (enum innermost_block_tracker_type): Move to
9418 expression.h.
9419 (innermost_block): Update comment.
9420 * parse.c (parse_exp_1): Add tracker_types parameter.
9421 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9422 tracker_types parameter. Reset innermost_block.
9423 (parse_exp_in_context): Remove.
9424 (parse_expression_for_completion): Update.
9425 * objfiles.c (~objfile): Don't reset expression_context_block or
9426 innermost_block.
9427 * expression.h (enum innermost_block_tracker_type): Move from
9428 parser-defs.h.
9429 (parse_exp_1): Add tracker_types parameter.
9430 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9431 reset innermost_block.
9432
b366c208
TT
94332019-03-23 Tom Tromey <tom@tromey.com>
9434
9435 * objfiles.h: Include bcache.h.
9436
9bb9b2f9
TT
94372019-03-23 Tom Tromey <tom@tromey.com>
9438
9439 * linespec.c (get_current_search_block): Use
9440 scoped_restore_current_language.
9441 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9442
59c28372
AH
94432019-03-22 Alan Hayward <alan.hayward@arm.com>
9444 Jiong Wang <jiong.wang@arm.com>
9445
9446 * aarch64-linux-tdep.c
9447 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9448 section.
9449 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9450
17e116a7
AH
94512019-03-22 Alan Hayward <alan.hayward@arm.com>
9452 Jiong Wang <jiong.wang@arm.com>
9453
9454 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9455 instructions.
9456 (aarch64_analyze_prologue_test): Add PACIASP test.
9457 (aarch64_prologue_prev_register): Unmask PC value.
9458
11e1b75f
AH
94592019-03-22 Alan Hayward <alan.hayward@arm.com>
9460 Jiong Wang <jiong.wang@arm.com>
9461
9462 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9463 (aarch64_dwarf2_prev_register): Unmask PC value.
9464 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9465 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9466 DW_CFA_AARCH64_negate_ra_state.
9467 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9468
34dcc7cf
AH
94692019-03-22 Alan Hayward <alan.hayward@arm.com>
9470 Jiong Wang <jiong.wang@arm.com>
9471
9472 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9473 registers.
9474 (aarch64_pseudo_register_name): Likewise.
9475 (aarch64_pseudo_register_type): Likewise.
9476 (aarch64_pseudo_register_reggroup_p): Likewise.
9477 (aarch64_gdbarch_init): Add pauth registers.
9478 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9479 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9480 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9481 (struct gdbarch_tdep): Add regnum for ra_state.
9482
1ef53e6b
AH
94832019-03-22 Alan Hayward <alan.hayward@arm.com>
9484 Jiong Wang <jiong.wang@arm.com>
9485
9486 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9487
76bed0fd
AH
94882019-03-22 Alan Hayward <alan.hayward@arm.com>
9489 Jiong Wang <jiong.wang@arm.com>
9490
9491 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9492 function.
9493 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9494 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9495 (aarch64_gdbarch_init): Add puth registers.
9496 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9497 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9498 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9499
ee4fbcfa
AH
95002019-03-22 Alan Hayward <alan.hayward@arm.com>
9501 Jiong Wang <jiong.wang@arm.com>
9502
9503 * aarch64-linux-nat.c
9504 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9505 * aarch64-linux-tdep.c
9506 (aarch64_linux_core_read_description): Likewise.
9507 (aarch64_linux_get_hwcap): New function.
9508 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9509 (aarch64_linux_get_hwcap): New declaration.
9510
6dc0ebde
AH
95112019-03-22 Alan Hayward <alan.hayward@arm.com>
9512 Jiong Wang <jiong.wang@arm.com>
9513
9514 * aarch64-linux-nat.c
9515 (aarch64_linux_nat_target::read_description): Add pauth param.
9516 * aarch64-linux-tdep.c
9517 (aarch64_linux_core_read_description): Likewise.
9518 * aarch64-tdep.c (struct target_desc): Add in pauth.
9519 (aarch64_read_description): Add pauth param.
9520 (aarch64_gdbarch_init): Likewise.
9521 * aarch64-tdep.h (aarch64_read_description): Likewise.
9522 * arch/aarch64.c (aarch64_create_target_description): Likewise.
9523 * arch/aarch64.h (aarch64_create_target_description): Likewise.
9524 * features/Makefile: Add new files.
9525 * features/aarch64-pauth.c: New file.
9526 * features/aarch64-pauth.xml: New file.
9527
595915c1
TT
95282019-03-20 Tom Tromey <tromey@adacore.com>
9529
9530 * infrun.c (handle_inferior_event): Rename from
9531 handle_inferior_event_1. Create a scoped_value_mark.
9532 (handle_inferior_event): Remove.
9533
4c7d57e7
TT
95342019-03-19 Tom Tromey <tromey@adacore.com>
9535
9536 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9537 * infrun.h (print_stop_event): Add "displays" parameter.
9538 * infrun.c (print_stop_event): Add "displays" parameter.
9539
cb246234
PA
95402019-03-19 Pedro Alves <palves@redhat.com>
9541
9542 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9543 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
9544 to -1. Fix TABs vs spaces.
9545 (tui_ui_out::tui_ui_out): Don't initialize fields here.
9546 * tui/tui-out.h (tui_ui_out) Add intro comments.
9547 <m_line, m_start_of_line>: In-class initialize, and add describing
9548 comment.
9549
3a0e45b2
AH
95502019-03-18 Alan Hayward <alan.hayward@arm.com>
9551
9552 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9553 variable names.
9554 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9555
5371b850
PA
95562019-03-18 Pedro Alves <palves@redhat.com>
9557 Eli Zaretskii <eliz@gnu.org>
9558
9559 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9560 m_line and m_start_of_line.
9561
b17c4cd0
EZ
95622019-03-18 Eli Zaretskii <eliz@gnu.org>
9563
9564 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9565 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9566 it returns a newline. This fixes a regression in TU mode, whereby
9567 the next line is output on the same screen line as the user input.
9568
4bd56d18
TT
95692019-03-18 Tom Tromey <tromey@adacore.com>
9570
9571 * minsyms.c (minimal_symbol_reader::install): Remove call to
9572 obstack_blank.
9573
55c10aca
PA
95742019-03-18 Pedro Alves <palves@redhat.com>
9575
9576 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9577 New globals.
9578 (apply_style): New, factored out from ...
9579 (apply_ansi_escape): ... this. Handle reverse video mode.
9580 (tui_set_reverse_mode): New function.
9581 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9582 * tui/tui-winsource.c (tui_show_source_line): Use
9583 tui_set_reverse_mode instead of setting A_STANDOUT.
9584 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9585 New setter methods.
9586
647bb750
HD
95872019-03-18 Hannes Domani <ssbssa@yahoo.de>
9588
9589 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9590 Handle tabs.
9591
bff8c71f
TT
95922019-03-18 Tom Tromey <tromey@adacore.com>
9593
9594 * ada-lang.c (empty_array): Add "high" parameter.
9595 (ada_evaluate_subexp): Update.
9596
58785d98
ST
95972019-03-17 Sergei Trofimovich <siarheit@google.com>
9598
9599 * unittests/string_view-selftests.c: Define
9600 _initialize_string_view_selftests unconditionally.
9601
d4cbef22
ВМ
96022019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9603
9604 PR gdb/24350
9605 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9606
fce4c071
ВМ
96072019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9608
9609 PR gdb/24351
9610 * windows-nat.c (display_selector): Fix format specifiers.
9611
f7f0a123
EZ
96122019-03-17 Eli Zaretskii <eliz@gnu.org>
9613
9614 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9615 tui_refill_source_window instead of tui_refresh_win, to update the
9616 current execution line. This fixes redisplay of the current line
9617 when stepping through the code with "next" or "step".
9618
ab42892f
EZ
96192019-03-16 Eli Zaretskii <eliz@gnu.org>
9620
9621 * source-cache.c (source_cache::get_source_lines): Call
9622 find_source_lines to initialize s->nlines. This fixes vertical
9623 scrolling of TUI source window when the DOWN arrow is pressed.
9624
8d8c087f
PW
96252019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9626
9627 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9628 linux-thread-db.c (_initialize_thread_db): Likewise.
9629
798e1c30
EZ
96302019-03-16 Eli Zaretskii <eliz@gnu.org>
9631
9632 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9633 wclrtoeol in tui_show_source_line". This reverts changes made in
9634 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9635
eefba3da
TT
96362019-03-15 Tom Tromey <tom@tromey.com>
9637
9638 * symtab.h (struct minimal_symbol): Derive from
9639 general_symbol_info.
9640 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9641 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9642 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9643 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9644 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9645 (MSYMBOL_SEARCH_NAME): Update.
9646 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9647 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9648 * minsyms.c (minimal_symbol_reader::record_full): Update.
9649
0de2420c
TT
96502019-03-15 Tom Tromey <tom@tromey.com>
9651
9652 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9653
042d75e4
TT
96542019-03-15 Tom Tromey <tom@tromey.com>
9655
9656 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9657 unique_xmalloc_ptr.
9658 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9659 Update.
9660 * minsyms.c (lookup_minimal_symbol_by_pc_section)
9661 (build_minimal_symbol_hash_tables)
9662 (minimal_symbol_reader::install): Update.
9663
db92718b
TT
96642019-03-15 Tom Tromey <tom@tromey.com>
9665
9666 * symtab.c (create_demangled_names_hash): Update.
9667 (symbol_set_names): Update.
9668 * objfiles.h (struct objfile_per_bfd_storage)
9669 <demangled_names_hash>: Now an htab_up.
9670 * objfiles.c (objfile_per_bfd_storage): Simplify.
9671
d6797f46
TT
96722019-03-15 Tom Tromey <tom@tromey.com>
9673
9674 * objfiles.h (struct objfile_per_bfd_storage): Declare
9675 destructor.
9676 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9677 New.
9678 (get_objfile_bfd_data): Use new. Don't initialize
9679 language_of_main.
9680 (free_objfile_per_bfd_storage): Remove.
9681 (objfile_bfd_data_free, objfile::~objfile): Use delete.
9682
741d7538
TT
96832019-03-15 Tom Tromey <tom@tromey.com>
9684
9685 * symfile.c (reread_symbols): Update.
9686 * objfiles.c (objfile::objfile): Update.
9687 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9688 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9689 comment.
9690 (minimal_symbol_reader::install): Update.
9691 (terminate_minimal_symbol_table): Remove.
9692 * jit.c (jit_object_close_impl): Update.
9693
788c80d1
TT
96942019-03-15 Tom Tromey <tom@tromey.com>
9695
9696 * minsyms.c (minimal_symbol_reader::record_full): Remove some
9697 initializations.
9698
1b7a07cb
TT
96992019-03-15 Tom Tromey <tom@tromey.com>
9700
9701 * objfiles.h (struct objfile_per_bfd_storage)
9702 <demangled_hash_languages>: Now a bitset.
9703 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9704 (lookup_minimal_symbol): Update.
9705
3db066bc
TT
97062019-03-15 Tom Tromey <tom@tromey.com>
9707
9708 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9709 Don't return the symbol.
9710 * coffread.c (record_minimal_symbol): Use record_full.
9711
3fff2c37
EZ
97122019-03-14 Eli Zaretskii <eliz@gnu.org>
9713
9714 The MS-Windows port of ncurses fails to switch to a color pair if
9715 one or both of the colors are the implicit default colors. This
9716 change records the default colors when TUI is initialized, and
9717 then specifies them explicitly when a color pair uses the default
9718 colors. This allows color styling in TUI mode on MS-Windows.
9719
9720 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
9721 ncurses_norm_attr.
9722 (tui_initialize_io) [__MINGW32__]: Record the default terminal
9723 colors in ncurses_norm_attr.
9724 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9725 "none", replace it with the default color recorded in
9726 ncurses_norm_attr.
9727
3b336828
TT
97282019-03-14 Tom Tromey <tromey@adacore.com>
9729
9730 * source-cache.h (class source_cache) <get_source_lines>: Return
9731 std::string.
9732 * source-cache.c (source_cache::extract_lines): Handle case where
9733 first_pos==npos. Return std::string.
9734 (source_cache::get_source_lines): Update.
9735
d085f989
TT
97362019-03-14 Tom Tromey <tromey@adacore.com>
9737
9738 * NEWS: Add item for "style sources" commands.
9739 * source-cache.c (source_cache::get_source_lines): Check
9740 source_styling.
9741 * cli/cli-style.c (source_styling): New global.
9742 (_initialize_cli_style): Add "style sources" commands.
9743 (show_style_sources): New function.
9744 * cli/cli-style.h (source_styling): Declare.
9745
6f11e682
TT
97462019-03-14 Pedro Alves <palves@redhat.com>
9747 Tom Tromey <tromey@adacore.com>
9748
9749 * tui/tui-winsource.h (tui_refill_source_window): Declare.
9750 * tui/tui-winsource.c (tui_refill_source_window): New function,
9751 from...
9752 (tui_horizontal_source_scroll): ... here. Move some logic.
9753 * cli/cli-style.c (set_style_enabled): Notify new observable.
9754 * tui/tui-hooks.c (tui_redisplay_source): New function.
9755 (tui_attach_detach_observers): Attach or detach
9756 tui_redisplay_source.
9757 * observable.h (source_styling_changed): New observable.
9758 * observable.c: Define source_styling_changed observable.
9759
a068643d
TT
97602019-03-13 Tom Tromey <tromey@adacore.com>
9761
9762 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9763 (i386_gnu_nat_target::store_registers): Update.
9764 * target-debug.h (target_debug_print_std_string): New macro.
9765 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9766 * windows-tdep.c (display_one_tib): Update.
9767 * tui/tui-stack.c (tui_make_status_line): Update.
9768 * top.c (print_inferior_quit_action): Update.
9769 * thread.c (thr_try_catch_cmd): Update.
9770 (add_thread_with_info): Update.
9771 (thread_target_id_str): Update.
9772 (thr_try_catch_cmd): Update.
9773 (thread_command): Update.
9774 (thread_find_command): Update.
9775 * record-btrace.c (record_btrace_target::info_record)
9776 (record_btrace_resume_thread, record_btrace_target::resume)
9777 (record_btrace_cancel_resume, record_btrace_step_thread)
9778 (record_btrace_target::wait, record_btrace_target::wait)
9779 (record_btrace_target::wait, record_btrace_target::stop): Update.
9780 * progspace.c (print_program_space): Update.
9781 * process-stratum-target.c
9782 (process_stratum_target::thread_address_space): Update.
9783 * linux-fork.c (linux_fork_mourn_inferior)
9784 (detach_checkpoint_command, info_checkpoints_command)
9785 (linux_fork_context): Update.
9786 (linux_fork_detach): Update.
9787 (class scoped_switch_fork_info): Update.
9788 (delete_checkpoint_command): Update.
9789 * infrun.c (follow_fork_inferior): Update.
9790 (follow_fork_inferior): Update.
9791 (proceed_after_vfork_done): Update.
9792 (handle_vfork_child_exec_or_exit): Update.
9793 (follow_exec): Update.
9794 (displaced_step_prepare_throw): Update.
9795 (displaced_step_restore): Update.
9796 (start_step_over): Update.
9797 (resume_1): Update.
9798 (clear_proceed_status_thread): Update.
9799 (proceed): Update.
9800 (print_target_wait_results): Update.
9801 (do_target_wait): Update.
9802 (context_switch): Update.
9803 (stop_all_threads): Update.
9804 (restart_threads): Update.
9805 (finish_step_over): Update.
9806 (handle_signal_stop): Update.
9807 (switch_back_to_stepped_thread): Update.
9808 (keep_going_pass_signal): Update.
9809 (print_exited_reason): Update.
9810 (normal_stop): Update.
9811 * inferior.c (inferior_pid_to_str): Change return type.
9812 (print_selected_inferior): Update.
9813 (add_inferior): Update.
9814 (detach_inferior): Update.
9815 * dummy-frame.c (fprint_dummy_frames): Update.
9816 * dcache.c (dcache_info_1): Update.
9817 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9818 (btrace_fetch, btrace_clear): Update.
9819 * linux-tdep.c (linux_core_pid_to_str): Change return type.
9820 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9821 type.
9822 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9823 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9824 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9825 * gdbarch.c, gdbarch.h: Rebuild.
9826 * gdbarch.sh (core_pid_to_str): Change return type.
9827 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9828 return type.
9829 (windows_nat_target::pid_to_str): Change return type.
9830 (windows_delete_thread): Update.
9831 (windows_nat_target::attach): Update.
9832 (windows_nat_target::files_info): Update.
9833 * target-delegates.c: Rebuild.
9834 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9835 return type.
9836 (sol_thread_target::pid_to_str): Change return type.
9837 * remote.c (class remote_target) <pid_to_str>: Change return
9838 type.
9839 (remote_target::pid_to_str): Change return type.
9840 (extended_remote_target::attach, remote_target::remote_stop_ns)
9841 (remote_target::remote_notif_remove_queued_reply)
9842 (remote_target::push_stop_reply, remote_target::disable_btrace):
9843 Update.
9844 (extended_remote_target::attach): Update.
9845 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9846 type.
9847 (gdbsim_target::pid_to_str): Change return type.
9848 * ravenscar-thread.c (struct ravenscar_thread_target)
9849 <pid_to_str>: Change return type.
9850 (ravenscar_thread_target::pid_to_str): Change return type.
9851 * procfs.c (class procfs_target) <pid_to_str>: Change return
9852 type.
9853 (procfs_target::pid_to_str): Change return type.
9854 (procfs_target::attach): Update.
9855 (procfs_target::detach): Update.
9856 (procfs_target::fetch_registers): Update.
9857 (procfs_target::store_registers): Update.
9858 (procfs_target::wait): Update.
9859 (procfs_target::files_info): Update.
9860 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9861 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9862 return type.
9863 (nto_procfs_target::pid_to_str): Change return type.
9864 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9865 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9866 return type.
9867 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9868 (exit_lwp): Update.
9869 (attach_proc_task_lwp_callback, get_detach_signal)
9870 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9871 (linux_nat_target::resume, wait_lwp, stop_callback)
9872 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9873 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9874 (linux_nat_wait_1, resume_stopped_resumed_lwps)
9875 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9876 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9877 type.
9878 (inf_ptrace_target::attach): Update.
9879 (inf_ptrace_target::files_info): Update.
9880 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9881 type.
9882 (go32_nat_target::pid_to_str): Change return type.
9883 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9884 (gnu_nat_target::wait): Update.
9885 (gnu_nat_target::wait): Update.
9886 (gnu_nat_target::resume): Update.
9887 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9888 (fbsd_nat_target::wait): Update.
9889 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9890 type.
9891 (darwin_nat_target::attach): Update.
9892 * corelow.c (class core_target) <pid_to_str>: Change return type.
9893 (core_target::pid_to_str): Change return type.
9894 * target.c (normal_pid_to_str): Change return type.
9895 (default_pid_to_str): Likewise.
9896 (target_pid_to_str): Change return type.
9897 (target_translate_tls_address): Update.
9898 (target_announce_detach): Update.
9899 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9900 return type.
9901 (bsd_uthread_target::pid_to_str): Change return type.
9902 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9903 type.
9904 (bsd_kvm_target::pid_to_str): Change return type.
9905 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9906 return type.
9907 (aix_thread_target::pid_to_str): Change return type.
9908 * target.h (struct target_ops) <pid_to_str>: Change return type.
9909 (target_pid_to_str, normal_pid_to_str): Likewise.
9910 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9911 type.
9912 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9913 type.
9914 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9915 return type.
9916 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9917 type.
9918 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9919 type.
9920 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9921 return type.
9922
b4be1b06
SM
99232019-03-13 Simon Marchi <simon.marchi@ericsson.com>
9924
9925 * NEWS: Mention that the new default MI version is 3. Mention
9926 changes to the output of commands and events that deal with
9927 multi-location breakpoints.
9928 * breakpoint.c: Include "mi/mi-out.h".
9929 (print_one_breakpoint): Change output syntax if using MI version
9930 >= 3.
9931 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9932 New.
9933 (mi_multi_location_breakpoint_output_fixed): New.
9934 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9935 (mi_cmd_fix_multi_location_breakpoint_output): New.
9936 (mi_multi_location_breakpoint_output_fixed): New.
9937 * mi/mi-cmds.c (mi_cmds): Register command
9938 -fix-multi-location-breakpoint-output.
9939 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9940 interpreter "mi".
9941
8e5e5494
SM
99422019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9943
9944 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9945 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9946 instantiate mi_ui_out based on interpreter name.
9947 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9948 * mi/mi-main.c (mi_load_progress): Likewise.
9949
197df35e
JB
99502019-03-12 John Baldwin <jhb@FreeBSD.org>
9951
9952 * NEWS: Combine separate "New targets" sections for 8.3.
9953
8399425f
JB
99542019-03-12 John Baldwin <jhb@FreeBSD.org>
9955
9956 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9957 (ppcfbsd_init_abi): Install gdbarch
9958 "fetch_tls_load_module_address" and "get_thread_local_address"
9959 methods.
9960
b0f87ed0
JB
99612019-03-12 John Baldwin <jhb@FreeBSD.org>
9962
9963 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9964 (riscv_fbsd_init_abi): Install gdbarch
9965 "fetch_tls_load_module_address" and "get_thread_local_address"
9966 methods.
9967
ce25aa57
JB
99682019-03-12 John Baldwin <jhb@FreeBSD.org>
9969
9970 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9971 (i386fbsd_init_abi): Install gdbarch
9972 "fetch_tls_load_module_address" and "get_thread_local_address"
9973 methods.
9974
f5424cfa
JB
99752019-03-12 John Baldwin <jhb@FreeBSD.org>
9976
9977 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9978 (amd64fbsd_init_abi): Install gdbarch
9979 "fetch_tls_load_module_address" and "get_thread_local_address"
9980 methods.
9981
945f3901
JB
99822019-03-12 John Baldwin <jhb@FreeBSD.org>
9983
9984 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9985 (struct fbsd_pspace_data): New type.
9986 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9987 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9988 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9989 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9990 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9991
ef0bd204
JB
99922019-03-12 John Baldwin <jhb@FreeBSD.org>
9993
9994 * gdbtypes.c (lookup_struct_elt): New function.
9995 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9996 * gdbtypes.h (struct struct_elt): New type.
9997 (lookup_struct_elt): New prototype.
9998
36c53a02
JB
99992019-03-12 John Baldwin <jhb@FreeBSD.org>
10000
10001 * gdbtypes.c (lookup_struct_elt_type): Update comment and
10002 remove disabled code block.
10003
6e056c81
JB
100042019-03-12 John Baldwin <jhb@FreeBSD.org>
10005
10006 * gdbarch.sh (get_thread_local_address): New method.
10007 * gdbarch.h, gdbarch.c: Regenerate.
10008 * target.c (target_translate_tls_address): Use
10009 gdbarch_get_thread_local_address if present instead of
10010 target::get_thread_local_address.
10011
cd250a18
JB
100122019-03-12 John Baldwin <jhb@FreeBSD.org>
10013
10014 * target.h (target::get_thread_local_address): Update comment.
10015
df22c1e5
JB
100162019-03-12 John Baldwin <jhb@FreeBSD.org>
10017
10018 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10019 objfile->separate_debug_objfile_backlink if not NULL.
10020
dd6876c9
JB
100212019-03-12 John Baldwin <jhb@FreeBSD.org>
10022
10023 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10024 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10025 (amd64bsd_store_inferior_registers): Likewise.
10026 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10027 Enable segment base registers.
10028 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10029 PT_GETFSBASE and PT_GETGSBASE.
10030 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10031 PT_SETGSBASE.
10032 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10033 segment base registers.
10034 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10035
1163a4b7
JB
100362019-03-12 John Baldwin <jhb@FreeBSD.org>
10037
10038 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10039 Update calls to i386_target_description to add 'segments'
10040 parameter.
10041 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
10042 add segment base registers.
10043 * arch/i386.c (i386_create_target_description): Add 'segments'
10044 parameter to enable segment base registers.
10045 * arch/i386.h (i386_create_target_description): Likewise.
10046 * features/i386/32bit-segments.xml: New file.
10047 * features/i386/32bit-segments.c: Generate.
10048 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10049 call to i386_target_description to add 'segments' parameter.
10050 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10051 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10052 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10053 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10054 if feature is present.
10055 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10056 Add 'segments' parameter to call to i386_target_description.
10057 (i386_target_description): Add 'segments' parameter to enable
10058 segment base registers.
10059 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10060 to call to i386_target_description.
10061 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10062 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10063 Define I386_NUM_REGS.
10064 (i386_target_description): Add 'segments' parameter to enable
10065 segment base registers.
10066
3a350822
EZ
100672019-03-12 Eli Zaretskii <eliz@gnu.org>
10068
10069 PR/24325
10070 * source-cache.c: #undef open and close, to avoid unresolved
10071 externals during linking.
10072
ffdd69cf
TT
100732019-03-12 Tom Tromey <tromey@adacore.com>
10074
10075 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10076 const. Add initializers.
10077 (_initialize_remote): Don't initialize ptid globals.
10078
ec148c57
PA
100792019-03-12 Pedro Alves <palves@redhat.com>
10080
10081 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10082
32764270
PA
100832019-03-12 Pedro Alves <palves@redhat.com>
10084
10085 * cp-name-parser.y (main): Remove unused 'len' variable.
10086
17547186
TT
100872019-03-12 Tom Tromey <tromey@adacore.com>
10088
10089 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10090 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10091
d3a70e03
TT
100922019-03-12 Tom Tromey <tromey@adacore.com>
10093
10094 * linux-nat.c (iterate_over_lwps): Update.
10095 (stop_callback): Remove parameter.
10096 (stop_wait_callback, detach_callback, resume_set_callback)
10097 (select_singlestep_lwp_callback, set_ignore_sigint)
10098 (status_callback, resumed_callback, resume_clear_callback)
10099 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10100 data parameter.
10101 (linux_nat_target::detach, linux_nat_target::resume)
10102 (linux_stop_and_wait_all_lwps, select_event_lwp)
10103 (linux_nat_filter_event, linux_nat_wait_1)
10104 (linux_nat_target::kill, linux_nat_target::stop)
10105 (linux_nat_target::stop): Update.
10106 (linux_nat_resume_callback): Change type.
10107 (resume_stopped_resumed_lwps, count_events_callback)
10108 (select_event_lwp_callback): Likewise.
10109 (linux_stop_lwp, linux_nat_stop_lwp): Update.
10110 * arm-linux-nat.c (struct update_registers_data): Remove.
10111 (update_registers_callback): Change type.
10112 (arm_linux_insert_hw_breakpoint1): Update.
10113 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10114 parameter.
10115 (x86_linux_dr_set_addr): Update.
10116 (x86_linux_dr_set_control): Update.
10117 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10118 (iterate_over_lwps): Use gdb::function_view.
10119 * nat/aarch64-linux-hw-point.c (struct
10120 aarch64_dr_update_callback_param): Remove.
10121 (debug_reg_change_callback): Change type.
10122 (aarch64_notify_debug_reg_change): Update.
10123 * s390-linux-nat.c (s390_refresh_per_info): Update.
10124
82cb27ff
TT
101252019-03-11 Tom Tromey <tromey@adacore.com>
10126
10127 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10128 redundant assignment to "this_cu".
10129
568c0683
SM
101302019-03-08 Simon Marchi <simon.marchi@efficios.com>
10131
10132 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10133
f09ce22d
SM
101342019-03-08 Simon Marchi <simon.marchi@efficios.com>
10135
10136 * gdbtypes.c (rank_one_type_parm_set): New function extracted
10137 from...
10138 (rank_one_type): ... this.
10139
595f96a9
SM
101402019-03-08 Simon Marchi <simon.marchi@efficios.com>
10141
10142 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10143 from...
10144 (rank_one_type): ... this.
10145
2598a94b
SM
101462019-03-08 Simon Marchi <simon.marchi@efficios.com>
10147
10148 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10149 from...
10150 (rank_one_type): ... this.
10151
7f17b20d
SM
101522019-03-08 Simon Marchi <simon.marchi@efficios.com>
10153
10154 * gdbtypes.c (rank_one_type_parm_float): New function extracted
10155 from...
10156 (rank_one_type): ... this.
10157
2c509035
SM
101582019-03-08 Simon Marchi <simon.marchi@efficios.com>
10159
10160 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10161 from...
10162 (rank_one_type): ... this.
10163
0dd322dc
SM
101642019-03-08 Simon Marchi <simon.marchi@efficios.com>
10165
10166 * gdbtypes.c (rank_one_type_parm_range): New function extracted
10167 from...
10168 (rank_one_type): ... this.
10169
41ea4728
SM
101702019-03-08 Simon Marchi <simon.marchi@efficios.com>
10171
10172 * gdbtypes.c (rank_one_type_parm_char): New function extracted
10173 from...
10174 (rank_one_type): ... this.
10175
793cd1d2
SM
101762019-03-08 Simon Marchi <simon.marchi@efficios.com>
10177
10178 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10179 from...
10180 (rank_one_type): ... this.
10181
34910087
SM
101822019-03-08 Simon Marchi <simon.marchi@efficios.com>
10183
10184 * gdbtypes.c (rank_one_type_parm_int): New function extracted
10185 from...
10186 (rank_one_type): ... this.
10187
f1f832d6
SM
101882019-03-08 Simon Marchi <simon.marchi@efficios.com>
10189
10190 * gdbtypes.c (rank_one_type_parm_func): New function extracted
10191 from...
10192 (rank_one_type): ... this.
10193
b9f4512f
SM
101942019-03-08 Simon Marchi <simon.marchi@efficios.com>
10195
10196 * gdbtypes.c (rank_one_type_parm_array): New function extracted
10197 from...
10198 (rank_one_type): ... this.
10199
9293fc63
SM
102002019-03-08 Simon Marchi <simon.marchi@efficios.com>
10201
10202 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10203 from...
10204 (rank_one_type): ... this.
10205
e3abbe7e
PW
102062019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10207
10208 * inferior.c (initialize_inferiors): Ensure 'help set/show print
10209 inferior-events' shows the example events.
10210
e4adb939
EZ
102112019-03-08 Eli Zaretskii <eliz@gnu.org>
10212
10213 Support styling on native MS-Windows console
10214
10215 PR/24315
10216 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10217 on MS-Windows if $TERM is not defined.
10218
10219 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10220
10221 * posix-hdep.c (gdb_console_fputs):
10222 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10223 functions.
10224 * ui-file.h (gdb_console_fputs): Add prototype.
10225
10226 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10227 back to fputs only if the former returns zero.
10228
25629dfd
TT
102292019-03-07 Tom Tromey <tom@tromey.com>
10230
10231 * symmisc.c (print_symbol_bcache_statistics): Update.
10232 (print_objfile_statistics): Update.
10233 * symfile.c (allocate_symtab): Update.
10234 * stabsread.c: Don't include bcache.h.
10235 * psymtab.h (struct psymbol_bcache): Don't declare.
10236 (class psymtab_storage) <psymbol_cache>: Now a bcache.
10237 (psymbol_bcache_init, psymbol_bcache_free)
10238 (psymbol_bcache_get_bcache): Don't declare.
10239 * psymtab.c (struct psymbol_bcache): Remove.
10240 (psymtab_storage::psymtab_storage): Update.
10241 (psymtab_storage::~psymtab_storage): Update.
10242 (psymbol_bcache_init, psymbol_bcache_free)
10243 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10244 (add_psymbol_to_bcache): Update.
10245 (allocate_psymtab): Update.
10246 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10247 macro_cache>: No longer pointers.
10248 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10249 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10250 * macrotab.c (macro_bcache): Update.
10251 * macroexp.c: Don't include bcache.h.
10252 * gdbtypes.c (check_types_worklist): Update.
10253 (types_deeply_equal): Remove TRY/CATCH. Update.
10254 * elfread.c (elf_symtab_read): Update.
10255 * dwarf2read.c: Don't include bcache.h.
10256 * buildsym.c (buildsym_compunit::get_macro_table): Update.
10257 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10258 (print_bcache_statistics, bcache_memory_used): Don't declare.
10259 (struct bcache): Move from bcache.c. Add constructor, destructor,
10260 methods. Rename all data members.
10261 * bcache.c (struct bcache): Move to bcache.h.
10262 (bcache::expand_hash_table): Rename from expand_hash_table.
10263 (bcache): Remove.
10264 (bcache::insert): Rename from bcache_full.
10265 (bcache::compare): Rename from bcache_compare.
10266 (bcache_xmalloc): Remove.
10267 (bcache::~bcache): Rename from bcache_xfree.
10268 (bcache::print_statistics): Rename from print_bcache_statistics.
10269 (bcache::memory_used): Rename from bcache_memory_used.
10270
fe726667
PA
102712019-03-07 Pedro Alves <palves@redhat.com>
10272
10273 * infrun.c (normal_stop): Also check for
10274 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10275
7584bb30
AB
102762019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
10277
10278 * f-lang.c (value_from_host_double): Moved to...
10279 * value.c (value_from_host_double): ...here.
10280 * value.h (value_from_host_double): Declare.
10281 * guile/scm-math.c (vlscm_convert_typed_number): Use
10282 value_from_host_double.
10283 (vlscm_convert_number): Likewise.
10284 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10285 * python/py-value.c (convert_value_from_python): Likewise.
10286
a7b1986e
TT
102872019-03-06 Tom Tromey <tom@tromey.com>
10288
10289 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10290
0ccf4211
TT
102912019-03-06 Tom Tromey <tom@tromey.com>
10292
10293 * utils.h (free_current_contents): Don't declare.
10294 * utils.c (free_current_contents): Remove.
10295
fe7b42e5
TT
102962019-03-06 Tom Tromey <tom@tromey.com>
10297
10298 * top.c (quit_force): Update.
10299 * main.c (captured_command_loop): Update.
10300 * common/new-op.c (operator new): Update.
10301 * common/common-exceptions.c (struct catcher)
10302 <save_cleanup_chain>: Remove member.
10303 (exceptions_state_mc_init): Update.
10304 (exception_try_scope_entry): Return nullptr.
10305 (exception_try_scope_exit, exception_rethrow)
10306 (throw_exception_sjlj, throw_exception_cxx): Update.
10307 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10308 (all_cleanups, do_cleanups, discard_cleanups)
10309 (discard_final_cleanups, save_cleanups, save_final_cleanups)
10310 (restore_cleanups, restore_final_cleanups): Don't declare.
10311 (do_final_cleanups): Remove parameter.
10312 * common/cleanups.c (cleanup_chain, make_cleanup)
10313 (make_cleanup_dtor, all_cleanups, do_cleanups)
10314 (discard_my_cleanups, discard_cleanups)
10315 (discard_final_cleanups, save_my_cleanups, save_cleanups)
10316 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10317 (null_cleanup): Remove.
10318 (do_final_cleanups): Remove parameter.
10319
c6321f19
TT
103202019-03-06 Tom Tromey <tom@tromey.com>
10321
10322 * remote.c (remote_target::remote_parse_stop_reply): Use
10323 unique_xmalloc_ptr.
10324
61b30099
TT
103252019-03-06 Tom Tromey <tom@tromey.com>
10326
10327 * stabsread.c (struct stabs_field_info): Rename from field_info.
10328 <list, fnlist>: Add initializers.
10329 <obstack>: New member.
10330 (read_member_functions, read_struct_fields, read_baseclasses):
10331 Allocate on obstack. Don't use cleanups.
10332 (read_one_struct_field, read_member_functions, read_struct_fields)
10333 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10334 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10335 (read_struct_type): Update.
10336
6cceac94
TT
103372019-03-06 Tom Tromey <tom@tromey.com>
10338
10339 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10340 * common/filestuff.h (make_cleanup_close): Don't declare.
10341 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10342 Remove.
10343
72412762
TT
103442019-03-06 Tom Tromey <tom@tromey.com>
10345
10346 * solib-aix.c: Use make_scope_exit.
10347
2b6ff1c0
TT
103482019-03-06 Tom Tromey <tom@tromey.com>
10349
10350 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10351 Use make_scope_exit.
10352
d01c5877
TT
103532019-03-06 Tom Tromey <tom@tromey.com>
10354
10355 * solib-svr4.c (disable_probes_interface): Remove parameter.
10356 (svr4_handle_solib_event): Use make_scope_exit.
10357
32603266
TT
103582019-03-06 Tom Tromey <tom@tromey.com>
10359
10360 * remote.c (struct stop_reply_deleter): Remove.
10361 (stop_reply_up): Update.
10362 (struct stop_reply): Derive from notif_event. Don't typedef.
10363 <regcache>: Now a std::vector.
10364 (stop_reply_xfree): Remove.
10365 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10366 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10367 (remote_target::discard_pending_stop_replies): Use delete.
10368 (remote_target::remote_parse_stop_reply): Update.
10369 (remote_target::process_stop_reply): Update.
10370 * remote-notif.h (struct notif_event): Add virtual destructor.
10371 Remove "dtr" member.
10372 (struct notif_client) <alloc_event>: Return a unique_ptr.
10373 (notif_event_xfree): Don't declare.
10374 (notif_event_up): New typedef.
10375 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10376 (notif_event_xfree, do_notif_event_xfree): Remove.
10377 (remote_notif_state_xfree): Update.
10378
9799571e
TT
103792019-03-06 Tom Tromey <tom@tromey.com>
10380
10381 * infrun.c (displaced_step_clear_cleanup): Now a
10382 forward_scope_exit type.
10383 (displaced_step_prepare_throw): Update.
10384 (displaced_step_fixup): Update.
10385
09e3c4ca
TT
103862019-03-06 Tom Tromey <tom@tromey.com>
10387
10388 * inferior.h (class inferior): Update comment.
10389 * gdbthread.h (class thread_info): Update comment.
10390
e2a03548
TT
103912019-03-06 Joel Brobecker <brobecker@adacore.com>
10392 Tom Tromey <tom@tromey.com>
10393
10394 * stabsread.h (struct stab_section_list): Remove.
10395 (coffstab_build_psymtabs): Update.
10396 * dbxread.c (symbuf_sections): Now a std::vector.
10397 (sect_idx): New global.
10398 (fill_symbuf): Update.
10399 (coffstab_build_psymtabs): Change type of stabsects parameter.
10400 Update.
10401 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10402 std::vector.
10403 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10404 (coff_locate_sections): Update.
10405 (coff_symfile_read): Remove cleanups. Update.
10406 (init_stringtab): Add storage parameter.
10407 (free_stringtab, free_stringtab_cleanup): Remove.
10408 (init_lineno): Add storage parameter.
10409 (free_linetab, free_linetab_cleanup): Remove.
10410
b7e60d85
PA
104112019-03-06 Pedro Alves <palves@redhat.com>
10412
10413 * linux-fork.c (fork_info::clobber_regs): Delete.
10414 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10415 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10416 comment. Adjust.
10417 (scoped_switch_fork_info::scoped_switch_fork_info)
10418 (checkpoint_command, linux_fork_context): Adjust
10419 fork_save_infrun_state calls.
10420
e52c971f
PA
104212019-03-06 Pedro Alves <palves@redhat.com>
10422
10423 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10424 (inf_has_multiple_threads): Return 'bool' and rewrite using
10425 inferior_info::threads().
10426
06974e6c
PA
104272019-03-06 Pedro Alves <palves@redhat.com>
10428
10429 * linux-fork.c: Include <list>.
10430 (fork_list): Now a std::list instance.
10431 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10432 (forks_exist_p, find_last_fork): Adjust.
10433 (new_fork): Delete.
10434 (one_fork_p): New.
10435 (add_fork): Adjust.
10436 (free_fork): Delete, folded into fork_info::~fork_info().
10437 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10438 Adjust.
10439 (init_fork_list): Delete.
10440 (linux_fork_killall, linux_fork_mourn_inferior)
10441 (linux_fork_detach, info_checkpoints_command): Adjust.
10442 (_initialize_linux_fork): No longer call init_fork_list.
10443
72f31aea
PA
104442019-03-06 Pedro Alves <palves@redhat.com>
10445
10446 * linux-fork.c (new_fork): New, split out of ...
10447 (add_fork): ... this. Return void. Move "first fork" special
10448 case from here, to ...
10449 (checkpoint_command): ... here.
10450 * linux-linux.h (add_fork): Return void.
10451
efbecbc1
AB
104522019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10453
10454 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10455
0841c79a
AB
104562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10457 Chris January <chris.january@arm.com>
10458 David Lecomber <david.lecomber@arm.com>
10459
10460 * f-exp.y: New token, UNOP_INTRINSIC.
10461 (exp): New pattern using UNOP_INTRINSIC token.
10462 (f77_keywords): Add 'abs' keyword.
10463 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10464 (value_from_host_double): New function.
10465 (evaluate_subexp_f): Support UNOP_ABS.
10466
4a270568
AB
104672019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10468
10469 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10470 types.
10471
067630bd
AB
104722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10473
10474 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10475 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10476 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10477
3be47f7a
AB
104782019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10479
10480 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10481
4d00f5d8
AB
104822019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10483 Chris January <chris.january@arm.com>
10484
10485 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10486 * f-exp.y: Define 'KIND' token.
10487 (exp): New pattern for KIND expressions.
10488 (ptype): Handle types with a kind extension.
10489 (direct_abs_decl): Extend to spot kind extensions.
10490 (f77_keywords): Add 'kind' to the list.
10491 (push_kind_type): New function.
10492 (convert_to_kind_type): New function.
10493 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10494 * parse.c (operator_length_standard): Likewise.
10495 * parser-defs.h (enum type_pieces): Add tp_kind.
10496 * std-operator.def: Add UNOP_KIND.
10497
e454224f
AB
104982019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10499
10500 * f-exp.y (f_parse): Set yydebug.
10501
9dad4a58
AB
105022019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10503
10504 * f-lang.c (evaluate_subexp_f): New function.
10505 (exp_descriptor_f): New global.
10506 (f_language_defn): Use exp_descriptor_f instead of
10507 exp_descriptor_standard.
10508
c8f91604
AB
105092019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10510
10511 * f-exp.y (struct token): Add comments.
10512 (dot_ops): Remove uppercase versions and the end marker.
10513 (f77_keywords): Likewise.
10514 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10515 entries in the dot_ops array are case insensitive, and use
10516 strncasecmp to compare strings. Also some whitespace cleanup in
10517 this area. Similar for the f77_keywords array, except entries in
10518 this list might be case sensitive.
10519
dd9f2c76
AB
105202019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10521
10522 * f-exp.y (struct f77_boolean_val): Add comments.
10523 (boolean_values): Remove uppercase versions, and end marker.
10524 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10525 and use strncasecmp to achieve case insensitivity. Additionally,
10526 perform whitespace cleanup around this code.
10527
67a3048c
TT
105282019-03-06 Tom Tromey <tromey@adacore.com>
10529
10530 * remote-sim.c (gdbsim_target_open): Use result of
10531 gdb_argv::release.
10532
aa3cfbda
RB
105332019-03-06 Richard Bunt <richard.bunt@arm.com>
10534 Dirk Schubert <dirk.schubert@arm.com>
10535 Chris January <chris.january@arm.com>
10536
10537 * eval.c (evaluate_subexp_standard): Call Fortran argument
10538 wrapping logic.
10539 * f-lang.c (struct value): A value which can be passed into a
10540 Fortran function call.
10541 (fortran_argument_convert): Wrap Fortran arguments in a pointer
10542 where appropriate.
10543 (struct type): Value ready for a Fortran function call.
10544 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10545 is needed.
10546 * f-lang.h (fortran_argument_convert): Declaration.
10547 (fortran_preserve_arg_pointer): Declaration.
10548 * infcall.c (value_arg_coerce): Call Fortran argument logic.
10549
ea38e5df
TT
105502019-03-05 Tom Tromey <tromey@adacore.com>
10551
10552 * python/py-prettyprint.c (print_string_repr): Remove #if.
10553 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10554
06b5b831
TT
105552019-03-05 Tom Tromey <tromey@adacore.com>
10556
10557 * target.c (the_dummy_target): Move later. Change type to
10558 "dummy_target".
10559 (initialize_targets): Don't initialize the_dummy_target.
10560
edbd9e45
TT
105612019-03-05 Tom Tromey <tromey@adacore.com>
10562
10563 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10564 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10565
c119e040
TT
105662019-03-05 Tom Tromey <tromey@adacore.com>
10567
10568 * windows-nat.c (windows_nat_target::attach)
10569 (windows_nat_target::detach): Don't call gdb_flush.
10570 * valprint.c (generic_val_print, val_print, val_print_string):
10571 Don't call gdb_flush.
10572 * utils.c (defaulted_query): Don't call gdb_flush.
10573 * typeprint.c (print_type_scalar): Don't call gdb_flush.
10574 * target.c (target_announce_detach): Don't call gdb_flush.
10575 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10576 * remote.c (extended_remote_target::attach): Don't call
10577 gdb_flush.
10578 * procfs.c (procfs_target::detach): Don't call gdb_flush.
10579 * printcmd.c (do_examine): Don't call gdb_flush.
10580 (info_display_command): Don't call gdb_flush.
10581 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10582 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10583 * memattr.c (info_mem_command): Don't call gdb_flush.
10584 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10585 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10586 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10587 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10588 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10589 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10590 (gnu_nat_target::detach): Don't call gdb_flush.
10591 * f-valprint.c (f_val_print): Don't call gdb_flush.
10592 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10593 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10594 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10595 gdb_flush.
10596 * c-valprint.c (c_val_print): Don't call gdb_flush.
10597 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10598
895dafa6
TT
105992019-03-05 Tom Tromey <tromey@adacore.com>
10600
10601 * varobj.c (update_dynamic_varobj_children): Update.
10602 (install_default_visualizer): Use reset, not release.
10603 * value.c (set_internalvar): Update.
10604 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10605 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10606 ATTRIBUTE_UNUSED_RESULT.
10607
88a774b9
TT
106082019-03-05 Tom Tromey <tromey@adacore.com>
10609
10610 * remote.c (class scoped_remote_fd) <release>: Add
10611 ATTRIBUTE_UNUSED_RESULT.
10612
4e4a8b93
TT
106132019-03-05 Tom Tromey <tromey@adacore.com>
10614
10615 * macroexp.c (struct macro_buffer) <release>: Add
10616 ATTRIBUTE_UNUSED_RESULT.
10617
083eef1f
TT
106182019-03-05 Tom Tromey <tromey@adacore.com>
10619
10620 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10621 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10622 ATTRIBUTE_UNUSED_RESULT.
10623
3cabd438
TT
106242019-03-05 Tom Tromey <tromey@adacore.com>
10625
10626 * common/scoped_fd.h (class scoped_fd) <release>: Add
10627 ATTRIBUTE_UNUSED_RESULT.
10628
41e3300a
TT
106292019-03-05 Tom Tromey <tromey@adacore.com>
10630
10631 * parser-defs.h (struct parser_state) <release>: Add
10632 ATTRIBUTE_UNUSED_RESULT.
10633
18cb7c9f
TT
106342019-03-05 Tom Tromey <tromey@adacore.com>
10635
10636 * utils.h (class gdb_argv) <release>: Add
10637 ATTRIBUTE_UNUSED_RESULT.
10638 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10639
41fa577f
EZ
106402019-03-02 Eli Zaretskii <eliz@gnu.org>
10641
a6a4b2c6
EZ
10642 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10643 for-loop range, to avoid compiler warnings.
10644
10645 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10646 avoid compiler warnings about unused variables.
10647
742a7df5
EZ
10648 * NEWS: Mention end of support for native debugging on MS-Windows
10649 before XP.
10650
41fa577f
EZ
10651 PR gdb/24292
10652 * common/netstuff.c:
10653 * gdbserver/gdbreplay.c
10654 * gdbserver/remote-utils.c:
10655 * ser-tcp.c:
10656 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10657 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
10658 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10659 'getaddrinfo' and 'freeaddrinfo' were not available before
10660 Windows XP, and mingw.org's MinGW headers by default define
10661 _WIN32_WINNT to 0x500.
10662
827f438f
GB
106632019-03-01 Gary Benson <gbenson@redhat.com>
10664
10665 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10666
92137da0
RO
106672019-02-28 Brian Vandenberg <phantall@gmail.com>
10668 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
10669
10670 PR gdb/8527
10671 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10672 set_sigint_trap, clear_sigint_trap.
10673
799efbe8
PW
106742019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10675
10676 * target.c (target_detach): Clear the regcache and the
10677 frame cache.
10678
8ed25214
PA
106792019-02-27 Pedro Alves <palves@redhat.com>
10680
10681 * utils.c (set_screen_size): When we cap the height/width sizes,
10682 tweak the corresponding command variable to show "unlimited":
10683
23031e31
SJ
106842019-02-27 Saagar Jha <saagar@saagarjha.com>
10685 Pedro Alves <palves@redhat.com>
10686
10687 * utils.c (set_screen_size): Reduce "infinite" rows and columns
10688 before calling rl_set_screen_size.
10689
6c28e44a
TT
106902019-02-27 Tom Tromey <tromey@adacore.com>
10691
10692 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10693 define.
10694 * python/py-value.c: Remove Python 2.4 workaround.
10695 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10696 workaround.
10697 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10698 Python 2.4 workaround.
10699 * python/python-internal.h: Remove Python 2.4 comment.
10700 (Py_ssize_t): Don't define.
10701 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10702 (gdb_Py_DECREF): Remove Python 2.4 workaround.
10703 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10704 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10705 * python/python.c (do_start_initialization): Remove Python 2.4
10706 workaround.
10707 * python/py-prettyprint.c (class dummy_python_frame): Remove.
10708 (print_children): Remove Python 2.4 workaround.
10709 * python/py-inferior.c (buffer_procs): Remove Python 2.4
10710 workaround.
10711 (CHARBUFFERPROC_NAME): Remove.
10712 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10713 Python 2.4 workaround.
10714
2c3fc25d 107152019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 10716
2c3fc25d
KB
10717 * NEWS: Note minimum Python version.
10718
6ca62222
KB
107192019-02-27 Kevin Buettner <kevinb@redhat.com>
10720
10721 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10722 code from these functions. Remove corresponding ifdefs. Use
10723 Py_buffer_up instead of explicit calls to PyBuffer_Release.
10724 Remove gotos and target of gotos.
10725 (infpy_search_memory): Likewise.
10726
f4bc7d2c
AB
107272019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10728
10729 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10730 (hppa_gdbarch_init): Don't register deleted functions with
10731 gdbarch.
10732
9734a586
AB
107332019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10734
10735 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10736 (h8300_unwind_sp): Delete.
10737 (h8300_dummy_id): Delete.
10738 (h8300_gdbarch_init): Don't register deleted functions with
10739 gdbarch.
10740
68b867f3
AB
107412019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10742
10743 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10744 (ft32_unwind_pc): Delete.
10745 (ft32_unwind_sp): Delete.
10746 (ft32_gdbarch_init): Don't register deleted functions with
10747 gdbarch.
10748
2fbe7ad0
AB
107492019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10750
10751 * gdb/frv-tdep.c (frv_dummy_id): Delete.
10752 (frv_unwind_pc): Delete.
10753 (frv_unwind_sp): Delete.
10754 (frv_gdbarch_init): Don't register deleted functions with
10755 gdbarch.
10756
76055cbe
AB
107572019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10758
10759 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10760 (riscv_unwind_pc): Delete.
10761 (riscv_unwind_sp): Delete.
10762 (riscv_gdbarch_init): Don't register deleted functions with
10763 gdbarch.
10764
4133e5a1
AB
107652019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10766
10767 * gdb/csky-tdep.c (csky_dummy_id): Delete.
10768 (csky_unwind_pc): Delete.
10769 (csky_unwind_sp): Delete.
10770 (csky_gdbarch_init): Don't register deleted functions with
10771 gdbarch.
10772
8010f576
AB
107732019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10774
10775 * gdb/cris-tdep.c (cris_dummy_id): Delete.
10776 (cris_unwind_pc): Delete.
10777 (cris_unwind_sp): Delete.
10778 (cris_gdbarch_init): Don't register deleted functions with
10779 gdbarch.
10780
b56bf084
AB
107812019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10782
10783 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10784 (bfin_unwind_pc): Delete.
10785 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10786
a19a650f
AB
107872019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10788
10789 * gdb/arm-tdep.c (arm_dummy_id): Delete.
10790 (arm_unwind_pc): Delete.
10791 (arm_unwind_sp): Delete.
10792 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10793
f8278c3c
AB
107942019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10795
10796 * gdb/arc-tdep.c (arc_dummy_id): Delete.
10797 (arc_unwind_pc): Delete.
10798 (arc_unwind_sp): Delete.
10799 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10800
480e46cf
AB
108012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10802
10803 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10804 (alpha_unwind_pc): Delete.
10805 (alpha_gdbarch_init): Don't register deleted functions with
10806 gdbarch.
10807
7a995095
AB
108082019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10809
10810 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10811 (aarch64_unwind_pc): Delete.
10812 (aarch64_unwind_sp): Delete.
10813 (aarch64_gdbarch_init): Don't register deleted functions with
10814 gdbarch.
10815
bf9a735e
AB
108162019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10817
10818 * gdbtypes.c (type_align): Don't consider static members when
10819 computing structure alignment.
10820
5561fc30
AB
108212019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10822
10823 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10824 return 0 for other types.
10825 * arch-utils.c (default_type_align): Always return 0.
10826 * gdbarch.h: Regenerate.
10827 * gdbarch.sh (type_align): Extend comment.
10828 * gdbtypes.c (type_align): Add additional comments, always call
10829 gdbarch_type_align before applying the default rules.
10830 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10831 generic code will then apply a suitable default.
10832 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10833 types, return 0 for other types.
10834
9335e75a
JB
108352019-02-27 Joel Brobecker <brobecker@adacore.com>
10836
10837 * NEWS: Create a new section for the next release branch.
10838 Rename the section of the current branch, now that it has
10839 been cut.
10840
3d34d8de
JB
108412019-02-27 Joel Brobecker <brobecker@adacore.com>
10842
10843 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10844 * version.in: Bump version to 8.3.50.DATE-git.
10845
143420fb
SM
108462019-02-26 Simon Marchi <simon.marchi@efficios.com>
10847
10848 * aix-thread.c (ptid_cmp): Remove unused variable.
10849 (get_signaled_thread): Likewise.
10850 (store_regs_user_thread): Likewise.
10851 (store_regs_kernel_thread): Likewise.
10852 (fetch_regs_kernel_thread): Remove shadowed variable.
10853
172fb711
AB
108542019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
10855
10856 * features/riscv/32bit-cpu.xml: Add register numbers.
10857 * features/riscv/32bit-fpu.c: Regenerate.
10858 * features/riscv/32bit-fpu.xml: Add register numbers.
10859 * features/riscv/64bit-cpu.xml: Add register numbers.
10860 * features/riscv/64bit-fpu.c: Regenerate.
10861 * features/riscv/64bit-fpu.xml: Add register numbers.
10862
26c89782
KB
108632019-02-26 Kevin Buettner <kevinb@redhat.com>
10864
af54ade9 10865 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
10866 * python/py-value.c (convert_buffer_and_type_to_value): New
10867 function.
10868 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10869 Add support for handling an optional second argument. Call
10870 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
10871 * python/python-internal.h (Py_buffer_deleter): New struct.
10872 (Py_buffer_up): New typedef.
10873
0f58c9e8
JB
108742019-02-25 John Baldwin <jhb@FreeBSD.org>
10875
10876 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10877 instead of releasing ownership.
10878
0a0f4c01
JR
108792019-02-25 Jordan Rupprecht <rupprecht@google.com>
10880
10881 * dwarf2read.c (open_and_init_dwp_file): Call
10882 elf_numsections instead of bfd_count_sections to initialize
10883 dwp_file->num_sections.
10884
cd5a152c
TT
108852019-02-25 Tom Tromey <tromey@adacore.com>
10886
10887 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10888
8a6a8513
SDJ
108892019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
10890
10891 * gcore.in: Add '--readnever' option when invoking GDB.
10892
04dcda9c
SM
108932019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10894
10895 * MAINTAINERS: Update my email address.
10896
07bc701d
SM
108972019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10898
10899 * build-id.c (build_id_to_debug_bfd_1): New function.
10900 (build_id_to_debug_bfd): Look for separate debug file in
10901 sysroot.
10902
c6f4a5d0
AB
109032019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
10904
10905 * gdbarch.sh: Update the copyright year range that is placed into
10906 generated files.
10907
9600246d
KS
109082019-02-22 Keith Seitz <keiths@redhat.com>
10909
10910 PR symtab/23853
10911 * linespec.c (create_sals_line_offset): Search for the default
10912 symtab's filename instead of its fullname.
10913
7557a514
AH
109142019-02-21 Alan Hayward <alan.hayward@arm.com>
10915
10916 * NEWS: Update style defaults.
10917
ee2bcb0c
AH
109182019-02-21 Alan Hayward <alan.hayward@arm.com>
10919
10920 * main.c (captured_main_1): Disable styling in batch mode.
10921
0c95f9ed
TT
109222019-02-20 Tom Tromey <tom@tromey.com>
10923
10924 * symtab.c (symtab_symbol_info): Fix typos.
10925
c763b894
TT
109262019-02-20 Tom Tromey <tromey@adacore.com>
10927
10928 * findcmd.c (_initialize_mem_search): Use upper case for
10929 metasyntactic variables.
10930
0ef8a082
AH
109312019-02-20 Alan Hayward <alan.hayward@arm.com>
10932
10933 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10934 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10935
6caa91b6
SM
109362019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10937
10938 * top.h (source_file_name): Change to std::string.
10939 * top.c (source_file_name): Likewise.
10940 (command_line_input): Adjust.
10941 * cli/cli-script.c (script_from_file): Adjust.
10942
98814c6c
TT
109432019-02-19 Tom Tromey <tromey@adacore.com>
10944
10945 * ravenscar-thread.c
10946 (ravenscar_thread_target::update_thread_list): Don't call
10947 ada_build_task_list.
10948 * ada-lang.h (ada_build_task_list): Don't declare.
10949 * ada-tasks.c (struct ada_tasks_inferior_data)
10950 <task_list_valid_p>: Now bool.
10951 (read_known_tasks, ada_task_list_changed)
10952 (ada_tasks_invalidate_inferior_data): Update.
10953 (read_known_tasks_array): Return bool.
10954 (read_known_tasks_list): Likewise.
10955 (read_known_tasks): Return void.
10956 (ada_build_task_list): Now static.
10957
70cd633e
AB
109582019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10959
10960 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10961 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10962
040b3e95
PW
109632019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10964
10965 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10966 variant for ada_tasks_pspace_data_handle and
10967 ada_tasks_inferior_data_handle.
10968 (ada_tasks_pspace_data_cleanup): New function.
10969 (ada_tasks_inferior_data_cleanup): New function.
10970
9409233b
TT
109712019-02-17 Tom Tromey <tom@tromey.com>
10972
10973 * macrotab.h (macro_source_fullname): Return a std::string.
10974 * macrotab.c (macro_include, check_for_redefinition)
10975 (macro_undef, macro_lookup_definition, foreach_macro)
10976 (foreach_macro_in_scope): Update.
10977 (macro_source_fullname): Return a std::string.
10978 * macrocmd.c (show_pp_source_pos): Update.
10979
6506371f
TT
109802019-02-17 Tom Tromey <tom@tromey.com>
10981
10982 * macrocmd.c (show_pp_source_pos): Style the file names.
10983
0c820d67
TT
109842019-02-17 Tom Tromey <tom@tromey.com>
10985
10986 PR tui/24197:
10987 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10988
a0087920
TT
109892019-02-17 Tom Tromey <tom@tromey.com>
10990
10991 * ada-lang.c (user_select_syms): Use filtered printing.
10992 * utils.c (wrap_style): New global.
10993 (desired_style): Remove.
10994 (emit_style_escape): Add stream parameter.
10995 (set_output_style, reset_terminal_style, prompt_for_continue):
10996 Update.
10997 (flush_wrap_buffer): Only flush gdb_stdout.
10998 (wrap_here): Set wrap_style.
10999 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
11000 treat escape sequences as a character. Change when wrap buffer is
11001 flushed.
11002 (fputs_styled): Do not set the output style when the default is
11003 requested.
11004 * ui-style.h (struct ui_file_style) <is_default>: New method.
11005 * source.c (print_source_lines_base): Emit escape sequences in one
11006 piece.
11007
75ba10dc
JB
110082019-02-17 Joel Brobecker <brobecker@adacore.com>
11009
11010 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11011 integers and enumeration types.
11012
a2cd4f14
JB
110132019-02-17 Joel Brobecker <brobecker@adacore.com>
11014
11015 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11016 instead of lookup_symbol_in_language
11017 (do_exact_match): New function.
11018 (ada_get_symbol_name_matcher): Return do_exact_match when
11019 doing a verbatim match.
11020
485b851b
TT
110212019-02-15 Tom Tromey <tromey@adacore.com>
11022
11023 * ravenscar-thread.c (ravenscar_thread_target::resume)
11024 (ravenscar_thread_target::wait): Special case wildcard requests.
11025
0b790b1e
TT
110262019-02-15 Tom Tromey <tromey@adacore.com>
11027
11028 * ravenscar-thread.c (base_ptid): Remove.
11029 (struct ravenscar_thread_target) <close>: New method.
11030 <m_base_ptid>: New member.
11031 <update_inferior_ptid, active_task, task_is_currently_active,
11032 runtime_initialized>: Declare methods.
11033 <ravenscar_thread_target>: Add constructor.
11034 (ravenscar_thread_target::task_is_currently_active)
11035 (ravenscar_thread_target::update_inferior_ptid)
11036 (ravenscar_runtime_initialized): Rename. Now methods.
11037 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11038 (ravenscar_thread_target::update_thread_list): Update.
11039 (ravenscar_thread_target::active_task): Now method.
11040 (ravenscar_thread_target::store_registers)
11041 (ravenscar_thread_target::prepare_to_store)
11042 (ravenscar_thread_target::prepare_to_store)
11043 (ravenscar_thread_target::mourn_inferior): Update.
11044 (ravenscar_inferior_created): Use "new" to create target.
11045 (ravenscar_thread_target::get_ada_task_ptid): Update.
11046 (_initialize_ravenscar): Don't initialize base_ptid.
11047 (ravenscar_ops): Remove global.
11048
dea57a62
TT
110492019-02-15 Tom Tromey <tromey@adacore.com>
11050
11051 * target.h (push_target): Declare new overload.
11052 * target.c (push_target): New overload, taking an rvalue reference.
11053 * remote.c (remote_target::open_1): Use push_target overload.
11054 * corelow.c (core_target_open): Use push_target overload.
11055
989f3c58
TT
110562019-02-15 Tom Tromey <tromey@adacore.com>
11057
11058 * ravenscar-thread.c (is_ravenscar_task)
11059 (ravenscar_task_is_currently_active): Return bool.
11060 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11061 (_initialize_ravenscar): Remove "(void)".
11062 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11063 Return bool.
11064
6cbcc006
TT
110652019-02-15 Tom Tromey <tromey@adacore.com>
11066
11067 * ravenscar-thread.c (ravenscar_runtime_initializer)
11068 (has_ravenscar_runtime, get_running_thread_id)
11069 (ravenscar_thread_target::resume): Fix indentation.
11070
7657f14d
TT
110712019-02-15 Tom Tromey <tromey@adacore.com>
11072
11073 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11074 from ravenscar_arch_ops.
11075 (sparc_ravenscar_ops::fetch_registers)
11076 (sparc_ravenscar_ops::store_registers): Now methods.
11077 (sparc_ravenscar_prepare_to_store): Remove.
11078 (sparc_ravenscar_ops): Redefine.
11079 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11080 methods and destructor. Remove members.
11081 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11082 (ravenscar_thread_target::store_registers)
11083 (ravenscar_thread_target::prepare_to_store): Update.
11084 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11085 Remove.
11086 (struct ppc_ravenscar_powerpc_ops): Derive from
11087 ravenscar_arch_ops.
11088 (ppc_ravenscar_powerpc_ops::fetch_registers)
11089 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11090 (ppc_ravenscar_powerpc_ops): Redefine.
11091 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11092 (ppc_ravenscar_e500_ops::fetch_registers)
11093 (ppc_ravenscar_e500_ops::store_registers): Now methods.
11094 (ppc_ravenscar_e500_ops): Redefine.
11095 * aarch64-ravenscar-thread.c
11096 (aarch64_ravenscar_generic_prepare_to_store): Remove.
11097 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11098 (aarch64_ravenscar_fetch_registers)
11099 (aarch64_ravenscar_store_registers): Now methods.
11100 (aarch64_ravenscar_ops): Redefine.
11101
5b6ea500
TT
111022019-02-15 Tom Tromey <tromey@adacore.com>
11103
11104 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11105 (ravenscar_thread_target::stopped_by_hw_breakpoint)
11106 (ravenscar_thread_target::stopped_by_watchpoint)
11107 (ravenscar_thread_target::stopped_data_address)
11108 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11109
e397fd39
TT
111102019-02-15 Tom Tromey <tromey@adacore.com>
11111
11112 * ravenscar-thread.c: Fix some typos.
11113
cc12f4a8
TT
111142019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11115 Tom Tromey <tromey@adacore.com>
11116
11117 * ada-lang.c (ada_exception_sal): Change addr_string to a
11118 std::string.
11119 (create_ada_exception_catchpoint): Update.
11120
5f486660
TT
111212019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11122 Tom Tromey <tromey@adacore.com>
11123
11124 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11125 (bp_location_ops): Remove.
11126 (base_breakpoint_allocate_location): Update.
11127 (free_bp_location): Update.
11128 * ada-lang.c (class ada_catchpoint_location)
11129 <ada_catchpoint_location>: Remove ops parameter.
11130 (ada_catchpoint_location_dtor): Remove.
11131 (ada_catchpoint_location_ops): Remove.
11132 (allocate_location_exception): Update.
11133 * breakpoint.h (struct bp_location_ops): Remove.
11134 (class bp_location) <bp_location>: Remove bp_location_ops
11135 parameter.
11136 <~bp_location>: Add destructor.
11137 <ops>: Remove.
11138
b671c7fb
TS
111392019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11140 Pedro Alves <palves@redhat.com>
11141
11142 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11143 'PATH_MAX'.
11144
8071c5ce
DM
111452019-02-14 David Michael <fedora.dm0@gmail.com>
11146 Samuel Thibault <samuel.thibault@gnu.org>
11147 Thomas Schwinge <thomas@codesourcery.com>
11148
11149 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11150 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11151
b1041ae0
TS
111522019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11153
924514e1
TS
11154 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11155 (check_empty): Use "const char *".
11156
c29ee8d4
TS
11157 * gnu-nat.c (gnu_nat_target::detach): Instead of
11158 'detach_inferior (pid)' call
11159 'detach_inferior (find_inferior_pid (pid))'.
11160
6c6ef69f
TS
11161 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11162 'nat/fork-inferior.o'.
11163 * gnu-nat.c: #include "nat/fork-inferior.h".
11164
2d0a338c
TS
11165 * gnu-nat.c (gnu_nat_target::detach): Instead of
11166 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11167 * gnu-nat.h: #include "inf-child.h".
11168 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11169 'i386_gnu_nat_target::fetch_registers'.
11170 (gnu_store_registers): Rename/move to
11171 'i386_gnu_nat_target::store_registers'.
11172
cabb5f06
TS
11173 * config/i386/nm-i386gnu.h: Don't "#include" any files.
11174 * gnu-nat.h (mach_thread_info): New function.
11175 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11176
b1041ae0
TS
11177 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11178
2988d01e
KF
111792019-02-14 Frederic Konrad <konrad@adacore.com>
11180
11181 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11182
c559d709
JB
111832019-02-14 Joel Brobecker <brobecker@adacore.com>
11184
11185 * windows-nat.c (windows_add_thread): Add new parameter
11186 "main_thread_p" with default value set to false. Update
11187 function documentation as well as all callers.
11188 (windows_delete_thread): Likewise.
11189 (fake_create_process): Update call to windows_add_thread.
11190 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11191 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11192 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11193 call to windows_delete_thread.
11194
007024cc
SM
111952019-02-13 Simon Marchi <simon.marchi@ericsson.com>
11196
11197 * MAINTAINERS: Add Andrew Burgess as global maintainer.
11198
f62318e9
JB
111992019-02-12 John Baldwin <jhb@FreeBSD.org>
11200
11201 * symfile.c (find_separate_debug_file): Use canonical path of
11202 sysroot with child_path instead of gdb_sysroot if it is valid.
11203
cd4b7848
JB
112042019-02-12 John Baldwin <jhb@FreeBSD.org>
11205
11206 * symfile.c (find_separate_debug_file): Use child_path to
11207 determine if an object file is under a sysroot.
11208
efac4bfe
JB
112092019-02-12 John Baldwin <jhb@FreeBSD.org>
11210
11211 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11212 unittests/child-path-selftests.c.
11213 * common/pathstuff.c (child_path): New function.
11214 * common/pathstuff.h (child_path): New prototype.
11215 * unittests/child-path-selftests.c: New file.
11216
402d2bfe
JB
112172019-02-12 John Baldwin <jhb@FreeBSD.org>
11218
11219 * symfile.c (find_separate_debug_file): Look for separate debug
11220 files in debug directories under the sysroot.
11221
1ed9f74e
PW
112222019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11223
11224 * symtab.h (struct minimal_symbol data_p): New const method.
11225 (struct minimal_symbol text_p): Likewise.
11226 * symtab.c (output_source_filename): Use file name style
11227 to print file name.
11228 (print_symbol_info): Likewise.
11229 (print_msymbol_info): Use address style to print addresses.
11230 Use function name style to print executable text symbols.
11231 (expand_symtab_containing_pc): Use data_p.
11232 (find_pc_sect_compunit_symtab): Likewise.
11233
2636d81d
PW
112342019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11235
11236 * breakpoint.c (describe_other_breakpoints): Use address style
11237 to print addresses.
11238 (say_where): Likewise.
11239
ac8c53cc
PW
112402019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11241
11242 * ada-typeprint.c (print_func_type): Print function name
11243 style to print function name.
11244 * c-typeprint.c (c_print_type_1): Likewise.
11245
ea638c43
AH
112462019-02-11 Alan Hayward <alan.hayward@arm.com>
11247
11248 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11249 for execve.
11250
ab759ca8
PW
112512019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11252
11253 * c-exp.y (direct_abs_decl): Use emplace_back to record the
11254 type_stack.
11255
aff29d1c
JB
112562019-02-10 Joel Brobecker <brobecker@adacore.com>
11257
11258 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11259 TYPE_CODE_REF types.
11260
617126bc
JW
112612019-02-08 Jim Wilson <jimw@sifive.com>
11262
11263 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11264 (riscv_linux_fregset): New.
11265 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11266
46e3ed7f
TT
112672019-02-07 Tom Tromey <tom@tromey.com>
11268
11269 * thread.c (thread_cancel_execution_command): Update.
11270 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11271 methods.
11272 (struct thread_fsm_ops): Remove.
11273 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11274 (thread_fsm_should_stop, thread_fsm_return_value)
11275 (thread_fsm_set_finished, thread_fsm_finished_p)
11276 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11277 Don't declare.
11278 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11279 * infrun.c (clear_proceed_status_thread)
11280 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11281 (print_stop_event): Update.
11282 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11283 Add constructor.
11284 (step_command_fsm_ops): Remove.
11285 (new_step_command_fsm): Remove.
11286 (step_1): Update.
11287 (step_command_fsm::should_stop): Rename from
11288 step_command_fsm_should_stop.
11289 (step_command_fsm::clean_up): Rename from
11290 step_command_fsm_clean_up.
11291 (step_command_fsm::do_async_reply_reason): Rename from
11292 step_command_fsm_async_reply_reason.
11293 (struct until_next_fsm): Inherit from thread_fsm. Add
11294 constructor.
11295 (until_next_fsm_ops): Remove.
11296 (new_until_next_fsm): Remove.
11297 (until_next_fsm::should_stop): Rename from
11298 until_next_fsm_should_stop.
11299 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11300 (until_next_fsm::do_async_reply_reason): Rename from
11301 until_next_fsm_async_reply_reason.
11302 (struct finish_command_fsm): Inherit from thread_fsm. Add
11303 constructor. Change type of breakpoint.
11304 (finish_command_fsm_ops): Remove.
11305 (new_finish_command_fsm): Remove.
11306 (finish_command_fsm::should_stop): Rename from
11307 finish_command_fsm_should_stop.
11308 (finish_command_fsm::clean_up): Rename from
11309 finish_command_fsm_clean_up.
11310 (finish_command_fsm::return_value): Rename from
11311 finish_command_fsm_return_value.
11312 (finish_command_fsm::do_async_reply_reason): Rename from
11313 finish_command_fsm_async_reply_reason.
11314 (finish_command): Update.
11315 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11316 Add constructor.
11317 (call_thread_fsm_ops): Remove.
11318 (call_thread_fsm::call_thread_fsm): Rename from
11319 new_call_thread_fsm.
11320 (call_thread_fsm::should_stop): Rename from
11321 call_thread_fsm_should_stop.
11322 (call_thread_fsm::should_notify_stop): Rename from
11323 call_thread_fsm_should_notify_stop.
11324 (run_inferior_call, call_function_by_hand_dummy): Update.
11325 * cli/cli-interp.c (should_print_stop_to_console): Update.
11326 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11327 Add constructor. Change type of location_breakpoint,
11328 caller_breakpoint.
11329 (until_break_fsm_ops): Remove.
11330 (new_until_break_fsm): Remove.
11331 (until_break_fsm::should_stop): Rename from
11332 until_break_fsm_should_stop.
11333 (until_break_fsm::clean_up): Rename from
11334 until_break_fsm_clean_up.
11335 (until_break_fsm::do_async_reply_reason): Rename from
11336 until_break_fsm_async_reply_reason.
11337 (until_break_command): Update.
11338 * thread-fsm.c: Remove.
11339 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11340
1a5c2598
TT
113412019-02-07 Tom Tromey <tom@tromey.com>
11342
11343 * yy-remap.h: Add include guard.
11344 * xtensa-tdep.h: Add include guard.
11345 * xcoffread.h: Rename include guard.
11346 * varobj-iter.h: Add include guard.
11347 * tui/tui.h: Rename include guard.
11348 * tui/tui-winsource.h: Rename include guard.
11349 * tui/tui-wingeneral.h: Rename include guard.
11350 * tui/tui-windata.h: Rename include guard.
11351 * tui/tui-win.h: Rename include guard.
11352 * tui/tui-stack.h: Rename include guard.
11353 * tui/tui-source.h: Rename include guard.
11354 * tui/tui-regs.h: Rename include guard.
11355 * tui/tui-out.h: Rename include guard.
11356 * tui/tui-layout.h: Rename include guard.
11357 * tui/tui-io.h: Rename include guard.
11358 * tui/tui-hooks.h: Rename include guard.
11359 * tui/tui-file.h: Rename include guard.
11360 * tui/tui-disasm.h: Rename include guard.
11361 * tui/tui-data.h: Rename include guard.
11362 * tui/tui-command.h: Rename include guard.
11363 * tic6x-tdep.h: Add include guard.
11364 * target/waitstatus.h: Rename include guard.
11365 * target/wait.h: Rename include guard.
11366 * target/target.h: Rename include guard.
11367 * target/resume.h: Rename include guard.
11368 * target-float.h: Rename include guard.
11369 * stabsread.h: Add include guard.
11370 * rs6000-tdep.h: Add include guard.
11371 * riscv-fbsd-tdep.h: Add include guard.
11372 * regformats/regdef.h: Rename include guard.
11373 * record.h: Rename include guard.
11374 * python/python.h: Rename include guard.
11375 * python/python-internal.h: Rename include guard.
11376 * python/py-stopevent.h: Rename include guard.
11377 * python/py-ref.h: Rename include guard.
11378 * python/py-record.h: Rename include guard.
11379 * python/py-record-full.h: Rename include guard.
11380 * python/py-record-btrace.h: Rename include guard.
11381 * python/py-instruction.h: Rename include guard.
11382 * python/py-events.h: Rename include guard.
11383 * python/py-event.h: Rename include guard.
11384 * procfs.h: Add include guard.
11385 * proc-utils.h: Add include guard.
11386 * p-lang.h: Add include guard.
11387 * or1k-tdep.h: Rename include guard.
11388 * observable.h: Rename include guard.
11389 * nto-tdep.h: Rename include guard.
11390 * nat/x86-linux.h: Rename include guard.
11391 * nat/x86-linux-dregs.h: Rename include guard.
11392 * nat/x86-gcc-cpuid.h: Add include guard.
11393 * nat/x86-dregs.h: Rename include guard.
11394 * nat/x86-cpuid.h: Rename include guard.
11395 * nat/ppc-linux.h: Rename include guard.
11396 * nat/mips-linux-watch.h: Rename include guard.
11397 * nat/linux-waitpid.h: Rename include guard.
11398 * nat/linux-ptrace.h: Rename include guard.
11399 * nat/linux-procfs.h: Rename include guard.
11400 * nat/linux-osdata.h: Rename include guard.
11401 * nat/linux-nat.h: Rename include guard.
11402 * nat/linux-namespaces.h: Rename include guard.
11403 * nat/linux-btrace.h: Rename include guard.
11404 * nat/glibc_thread_db.h: Rename include guard.
11405 * nat/gdb_thread_db.h: Rename include guard.
11406 * nat/gdb_ptrace.h: Rename include guard.
11407 * nat/fork-inferior.h: Rename include guard.
11408 * nat/amd64-linux-siginfo.h: Rename include guard.
11409 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11410 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11411 * nat/aarch64-linux.h: Rename include guard.
11412 * nat/aarch64-linux-hw-point.h: Rename include guard.
11413 * mn10300-tdep.h: Add include guard.
11414 * mips-linux-tdep.h: Add include guard.
11415 * mi/mi-parse.h: Rename include guard.
11416 * mi/mi-out.h: Rename include guard.
11417 * mi/mi-main.h: Rename include guard.
11418 * mi/mi-interp.h: Rename include guard.
11419 * mi/mi-getopt.h: Rename include guard.
11420 * mi/mi-console.h: Rename include guard.
11421 * mi/mi-common.h: Rename include guard.
11422 * mi/mi-cmds.h: Rename include guard.
11423 * mi/mi-cmd-break.h: Rename include guard.
11424 * m2-lang.h: Add include guard.
11425 * location.h: Rename include guard.
11426 * linux-record.h: Rename include guard.
11427 * linux-nat.h: Add include guard.
11428 * linux-fork.h: Add include guard.
11429 * i386-darwin-tdep.h: Rename include guard.
11430 * hppa-linux-offsets.h: Add include guard.
11431 * guile/guile.h: Rename include guard.
11432 * guile/guile-internal.h: Rename include guard.
11433 * gnu-nat.h: Rename include guard.
11434 * gdb-stabs.h: Rename include guard.
11435 * frv-tdep.h: Add include guard.
11436 * f-lang.h: Add include guard.
11437 * event-loop.h: Add include guard.
11438 * darwin-nat.h: Rename include guard.
11439 * cp-abi.h: Rename include guard.
11440 * config/sparc/nm-sol2.h: Rename include guard.
11441 * config/nm-nto.h: Rename include guard.
11442 * config/nm-linux.h: Add include guard.
11443 * config/i386/nm-i386gnu.h: Rename include guard.
11444 * config/djgpp/nl_types.h: Rename include guard.
11445 * config/djgpp/langinfo.h: Rename include guard.
11446 * compile/gcc-cp-plugin.h: Add include guard.
11447 * compile/gcc-c-plugin.h: Add include guard.
11448 * compile/compile.h: Rename include guard.
11449 * compile/compile-object-run.h: Rename include guard.
11450 * compile/compile-object-load.h: Rename include guard.
11451 * compile/compile-internal.h: Rename include guard.
11452 * compile/compile-cplus.h: Rename include guard.
11453 * compile/compile-c.h: Rename include guard.
11454 * common/xml-utils.h: Rename include guard.
11455 * common/x86-xstate.h: Rename include guard.
11456 * common/version.h: Rename include guard.
11457 * common/vec.h: Rename include guard.
11458 * common/tdesc.h: Rename include guard.
11459 * common/selftest.h: Rename include guard.
11460 * common/scoped_restore.h: Rename include guard.
11461 * common/scoped_mmap.h: Rename include guard.
11462 * common/scoped_fd.h: Rename include guard.
11463 * common/safe-iterator.h: Rename include guard.
11464 * common/run-time-clock.h: Rename include guard.
11465 * common/refcounted-object.h: Rename include guard.
11466 * common/queue.h: Rename include guard.
11467 * common/ptid.h: Rename include guard.
11468 * common/print-utils.h: Rename include guard.
11469 * common/preprocessor.h: Rename include guard.
11470 * common/pathstuff.h: Rename include guard.
11471 * common/observable.h: Rename include guard.
11472 * common/netstuff.h: Rename include guard.
11473 * common/job-control.h: Rename include guard.
11474 * common/host-defs.h: Rename include guard.
11475 * common/gdb_wait.h: Rename include guard.
11476 * common/gdb_vecs.h: Rename include guard.
11477 * common/gdb_unlinker.h: Rename include guard.
11478 * common/gdb_unique_ptr.h: Rename include guard.
11479 * common/gdb_tilde_expand.h: Rename include guard.
11480 * common/gdb_sys_time.h: Rename include guard.
11481 * common/gdb_string_view.h: Rename include guard.
11482 * common/gdb_splay_tree.h: Rename include guard.
11483 * common/gdb_setjmp.h: Rename include guard.
11484 * common/gdb_ref_ptr.h: Rename include guard.
11485 * common/gdb_optional.h: Rename include guard.
11486 * common/gdb_locale.h: Rename include guard.
11487 * common/gdb_assert.h: Rename include guard.
11488 * common/filtered-iterator.h: Rename include guard.
11489 * common/filestuff.h: Rename include guard.
11490 * common/fileio.h: Rename include guard.
11491 * common/environ.h: Rename include guard.
11492 * common/common-utils.h: Rename include guard.
11493 * common/common-types.h: Rename include guard.
11494 * common/common-regcache.h: Rename include guard.
11495 * common/common-inferior.h: Rename include guard.
11496 * common/common-gdbthread.h: Rename include guard.
11497 * common/common-exceptions.h: Rename include guard.
11498 * common/common-defs.h: Rename include guard.
11499 * common/common-debug.h: Rename include guard.
11500 * common/cleanups.h: Rename include guard.
11501 * common/buffer.h: Rename include guard.
11502 * common/btrace-common.h: Rename include guard.
11503 * common/break-common.h: Rename include guard.
11504 * cli/cli-utils.h: Rename include guard.
11505 * cli/cli-style.h: Rename include guard.
11506 * cli/cli-setshow.h: Rename include guard.
11507 * cli/cli-script.h: Rename include guard.
11508 * cli/cli-interp.h: Rename include guard.
11509 * cli/cli-decode.h: Rename include guard.
11510 * cli/cli-cmds.h: Rename include guard.
11511 * charset-list.h: Add include guard.
11512 * buildsym-legacy.h: Rename include guard.
11513 * bfin-tdep.h: Add include guard.
11514 * ax.h: Rename include guard.
11515 * arm-linux-tdep.h: Add include guard.
11516 * arm-fbsd-tdep.h: Add include guard.
11517 * arch/xtensa.h: Rename include guard.
11518 * arch/tic6x.h: Add include guard.
11519 * arch/i386.h: Add include guard.
11520 * arch/arm.h: Rename include guard.
11521 * arch/arm-linux.h: Rename include guard.
11522 * arch/arm-get-next-pcs.h: Rename include guard.
11523 * arch/amd64.h: Add include guard.
11524 * arch/aarch64-insn.h: Rename include guard.
11525 * arch-utils.h: Rename include guard.
11526 * annotate.h: Add include guard.
11527 * amd64-darwin-tdep.h: Rename include guard.
11528 * aarch64-linux-tdep.h: Add include guard.
11529 * aarch64-fbsd-tdep.h: Add include guard.
11530 * aarch32-linux-nat.h: Add include guard.
11531
ab9268d2
PW
115322019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11533
11534 * macrotab.c (macro_define_internal): New function that
11535 factorizes macro_define_object_internal and macro_define_function
11536 code.
11537 (macro_define_object_internal): Use macro_define_internal.
11538 (macro_define_function): Likewise.
11539
bb0da2b4
PW
115402019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11541
11542 * macrocmd.c (extract_identifier): Return
11543 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11544 callers.
11545
424eb552
JB
115462019-02-06 John Baldwin <jhb@FreeBSD.org>
11547
11548 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11549
1688cb29
TT
115502019-02-05 Tom Tromey <tom@tromey.com>
11551
11552 * target.c (target_stack::unpush): Move assertion earlier.
11553
b5eba2d8
TT
115542019-01-30 Tom Tromey <tom@tromey.com>
11555
11556 PR python/23615:
11557 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11558 (gdbpy_parse_and_eval): Likewise.
11559 * python/python-internal.h (gdbpy_allow_threads): New class.
11560
7054e2ff
JB
115612019-01-28 John Baldwin <jhb@FreeBSD.org>
11562
11563 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11564 (aarch64_fbsd_fpregmap): Move earlier.
11565 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11566 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11567 instead of individual calls to trad_frame_set_reg_addr.
11568 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11569 earlier.
11570 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11571 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11572 instead of individual calls to trad_frame_set_reg_addr.
11573
36c25ffa
AH
115742019-01-28 Alan Hayward <alan.hayward@arm.com>
11575
11576 * CONTRIBUTE: Replace contribution list with wiki link.
11577
a0707f3c
TT
115782019-01-25 Tom Tromey <tom@tromey.com>
11579
11580 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11581
0747795c
TT
115822019-01-25 Tom Tromey <tom@tromey.com>
11583
11584 * xtensa-linux-nat.c: Fix common/ includes.
11585 * xml-support.h: Fix common/ includes.
11586 * xml-support.c: Fix common/ includes.
11587 * x86-linux-nat.c: Fix common/ includes.
11588 * windows-nat.c: Fix common/ includes.
11589 * varobj.h: Fix common/ includes.
11590 * varobj.c: Fix common/ includes.
11591 * value.c: Fix common/ includes.
11592 * valops.c: Fix common/ includes.
11593 * utils.c: Fix common/ includes.
11594 * unittests/xml-utils-selftests.c: Fix common/ includes.
11595 * unittests/utils-selftests.c: Fix common/ includes.
11596 * unittests/unpack-selftests.c: Fix common/ includes.
11597 * unittests/tracepoint-selftests.c: Fix common/ includes.
11598 * unittests/style-selftests.c: Fix common/ includes.
11599 * unittests/string_view-selftests.c: Fix common/ includes.
11600 * unittests/scoped_restore-selftests.c: Fix common/ includes.
11601 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11602 * unittests/scoped_fd-selftests.c: Fix common/ includes.
11603 * unittests/rsp-low-selftests.c: Fix common/ includes.
11604 * unittests/parse-connection-spec-selftests.c: Fix common/
11605 includes.
11606 * unittests/optional-selftests.c: Fix common/ includes.
11607 * unittests/offset-type-selftests.c: Fix common/ includes.
11608 * unittests/observable-selftests.c: Fix common/ includes.
11609 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11610 * unittests/memrange-selftests.c: Fix common/ includes.
11611 * unittests/memory-map-selftests.c: Fix common/ includes.
11612 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11613 * unittests/function-view-selftests.c: Fix common/ includes.
11614 * unittests/environ-selftests.c: Fix common/ includes.
11615 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11616 * unittests/common-utils-selftests.c: Fix common/ includes.
11617 * unittests/cli-utils-selftests.c: Fix common/ includes.
11618 * unittests/array-view-selftests.c: Fix common/ includes.
11619 * ui-file.c: Fix common/ includes.
11620 * tui/tui-io.c: Fix common/ includes.
11621 * tracepoint.h: Fix common/ includes.
11622 * tracepoint.c: Fix common/ includes.
11623 * tracefile-tfile.c: Fix common/ includes.
11624 * top.h: Fix common/ includes.
11625 * top.c: Fix common/ includes.
11626 * thread.c: Fix common/ includes.
11627 * target/waitstatus.h: Fix common/ includes.
11628 * target/waitstatus.c: Fix common/ includes.
11629 * target.h: Fix common/ includes.
11630 * target.c: Fix common/ includes.
11631 * target-memory.c: Fix common/ includes.
11632 * target-descriptions.c: Fix common/ includes.
11633 * symtab.h: Fix common/ includes.
11634 * symfile.c: Fix common/ includes.
11635 * stap-probe.c: Fix common/ includes.
11636 * spu-linux-nat.c: Fix common/ includes.
11637 * sparc-nat.c: Fix common/ includes.
11638 * source.c: Fix common/ includes.
11639 * solib.c: Fix common/ includes.
11640 * solib-target.c: Fix common/ includes.
11641 * ser-unix.c: Fix common/ includes.
11642 * ser-tcp.c: Fix common/ includes.
11643 * ser-pipe.c: Fix common/ includes.
11644 * ser-base.c: Fix common/ includes.
11645 * selftest-arch.c: Fix common/ includes.
11646 * s12z-tdep.c: Fix common/ includes.
11647 * rust-exp.y: Fix common/ includes.
11648 * rs6000-aix-tdep.c: Fix common/ includes.
11649 * riscv-tdep.c: Fix common/ includes.
11650 * remote.c: Fix common/ includes.
11651 * remote-notif.h: Fix common/ includes.
11652 * remote-fileio.h: Fix common/ includes.
11653 * remote-fileio.c: Fix common/ includes.
11654 * regcache.h: Fix common/ includes.
11655 * regcache.c: Fix common/ includes.
11656 * record-btrace.c: Fix common/ includes.
11657 * python/python.c: Fix common/ includes.
11658 * python/py-type.c: Fix common/ includes.
11659 * python/py-inferior.c: Fix common/ includes.
11660 * progspace.h: Fix common/ includes.
11661 * producer.c: Fix common/ includes.
11662 * procfs.c: Fix common/ includes.
11663 * proc-api.c: Fix common/ includes.
11664 * printcmd.c: Fix common/ includes.
11665 * ppc-linux-nat.c: Fix common/ includes.
11666 * parser-defs.h: Fix common/ includes.
11667 * osdata.c: Fix common/ includes.
11668 * obsd-nat.c: Fix common/ includes.
11669 * nat/x86-linux.c: Fix common/ includes.
11670 * nat/x86-linux-dregs.c: Fix common/ includes.
11671 * nat/x86-dregs.h: Fix common/ includes.
11672 * nat/x86-dregs.c: Fix common/ includes.
11673 * nat/ppc-linux.c: Fix common/ includes.
11674 * nat/mips-linux-watch.h: Fix common/ includes.
11675 * nat/mips-linux-watch.c: Fix common/ includes.
11676 * nat/linux-waitpid.c: Fix common/ includes.
11677 * nat/linux-ptrace.h: Fix common/ includes.
11678 * nat/linux-ptrace.c: Fix common/ includes.
11679 * nat/linux-procfs.c: Fix common/ includes.
11680 * nat/linux-personality.c: Fix common/ includes.
11681 * nat/linux-osdata.c: Fix common/ includes.
11682 * nat/linux-namespaces.c: Fix common/ includes.
11683 * nat/linux-btrace.h: Fix common/ includes.
11684 * nat/linux-btrace.c: Fix common/ includes.
11685 * nat/fork-inferior.c: Fix common/ includes.
11686 * nat/amd64-linux-siginfo.c: Fix common/ includes.
11687 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11688 * nat/aarch64-linux.c: Fix common/ includes.
11689 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11690 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11691 * namespace.h: Fix common/ includes.
11692 * mips-linux-tdep.c: Fix common/ includes.
11693 * minsyms.c: Fix common/ includes.
11694 * mi/mi-parse.h: Fix common/ includes.
11695 * mi/mi-main.c: Fix common/ includes.
11696 * mi/mi-cmd-env.c: Fix common/ includes.
11697 * memrange.h: Fix common/ includes.
11698 * memattr.c: Fix common/ includes.
11699 * maint.h: Fix common/ includes.
11700 * maint.c: Fix common/ includes.
11701 * main.c: Fix common/ includes.
11702 * machoread.c: Fix common/ includes.
11703 * location.c: Fix common/ includes.
11704 * linux-thread-db.c: Fix common/ includes.
11705 * linux-nat.c: Fix common/ includes.
11706 * linux-fork.c: Fix common/ includes.
11707 * inline-frame.c: Fix common/ includes.
11708 * infrun.c: Fix common/ includes.
11709 * inflow.c: Fix common/ includes.
11710 * inferior.h: Fix common/ includes.
11711 * inferior.c: Fix common/ includes.
11712 * infcmd.c: Fix common/ includes.
11713 * inf-ptrace.c: Fix common/ includes.
11714 * inf-child.c: Fix common/ includes.
11715 * ia64-linux-nat.c: Fix common/ includes.
11716 * i387-tdep.c: Fix common/ includes.
11717 * i386-tdep.c: Fix common/ includes.
11718 * i386-linux-tdep.c: Fix common/ includes.
11719 * i386-linux-nat.c: Fix common/ includes.
11720 * i386-go32-tdep.c: Fix common/ includes.
11721 * i386-fbsd-tdep.c: Fix common/ includes.
11722 * i386-fbsd-nat.c: Fix common/ includes.
11723 * guile/scm-type.c: Fix common/ includes.
11724 * guile/guile.c: Fix common/ includes.
11725 * go32-nat.c: Fix common/ includes.
11726 * gnu-nat.c: Fix common/ includes.
11727 * gdbthread.h: Fix common/ includes.
11728 * gdbarch-selftests.c: Fix common/ includes.
11729 * gdb_usleep.c: Fix common/ includes.
11730 * gdb_select.h: Fix common/ includes.
11731 * gdb_bfd.c: Fix common/ includes.
11732 * gcore.c: Fix common/ includes.
11733 * fork-child.c: Fix common/ includes.
11734 * findvar.c: Fix common/ includes.
11735 * fbsd-nat.c: Fix common/ includes.
11736 * event-top.c: Fix common/ includes.
11737 * event-loop.c: Fix common/ includes.
11738 * dwarf2read.c: Fix common/ includes.
11739 * dwarf2loc.c: Fix common/ includes.
11740 * dwarf2-frame.c: Fix common/ includes.
11741 * dwarf-index-cache.c: Fix common/ includes.
11742 * dtrace-probe.c: Fix common/ includes.
11743 * disasm-selftests.c: Fix common/ includes.
11744 * defs.h: Fix common/ includes.
11745 * csky-tdep.c: Fix common/ includes.
11746 * cp-valprint.c: Fix common/ includes.
11747 * cp-support.h: Fix common/ includes.
11748 * cp-support.c: Fix common/ includes.
11749 * corelow.c: Fix common/ includes.
11750 * completer.h: Fix common/ includes.
11751 * completer.c: Fix common/ includes.
11752 * compile/compile.c: Fix common/ includes.
11753 * compile/compile-loc2c.c: Fix common/ includes.
11754 * compile/compile-cplus-types.c: Fix common/ includes.
11755 * compile/compile-cplus-symbols.c: Fix common/ includes.
11756 * command.h: Fix common/ includes.
11757 * cli/cli-dump.c: Fix common/ includes.
11758 * cli/cli-cmds.c: Fix common/ includes.
11759 * charset.c: Fix common/ includes.
11760 * build-id.c: Fix common/ includes.
11761 * btrace.h: Fix common/ includes.
11762 * btrace.c: Fix common/ includes.
11763 * breakpoint.h: Fix common/ includes.
11764 * breakpoint.c: Fix common/ includes.
11765 * ax.h:
11766 (enum agent_op): Fix common/ includes.
11767 * ax-general.c (struct aop_map): Fix common/ includes.
11768 * ax-gdb.c: Fix common/ includes.
11769 * auxv.c: Fix common/ includes.
11770 * auto-load.c: Fix common/ includes.
11771 * arm-tdep.c: Fix common/ includes.
11772 * arch/riscv.c: Fix common/ includes.
11773 * arch/ppc-linux-common.c: Fix common/ includes.
11774 * arch/i386.c: Fix common/ includes.
11775 * arch/arm.c: Fix common/ includes.
11776 * arch/arm-linux.c: Fix common/ includes.
11777 * arch/arm-get-next-pcs.c: Fix common/ includes.
11778 * arch/amd64.c: Fix common/ includes.
11779 * arch/aarch64.c: Fix common/ includes.
11780 * arch/aarch64-insn.c: Fix common/ includes.
11781 * arch-utils.c: Fix common/ includes.
11782 * amd64-windows-tdep.c: Fix common/ includes.
11783 * amd64-tdep.c: Fix common/ includes.
11784 * amd64-sol2-tdep.c: Fix common/ includes.
11785 * amd64-obsd-tdep.c: Fix common/ includes.
11786 * amd64-nbsd-tdep.c: Fix common/ includes.
11787 * amd64-linux-tdep.c: Fix common/ includes.
11788 * amd64-linux-nat.c: Fix common/ includes.
11789 * amd64-fbsd-tdep.c: Fix common/ includes.
11790 * amd64-fbsd-nat.c: Fix common/ includes.
11791 * amd64-dicos-tdep.c: Fix common/ includes.
11792 * amd64-darwin-tdep.c: Fix common/ includes.
11793 * agent.c: Fix common/ includes.
11794 * ada-lang.h: Fix common/ includes.
11795 * ada-lang.c: Fix common/ includes.
11796 * aarch64-tdep.c: Fix common/ includes.
11797
2f5c153e
TT
117982019-01-25 Tom Tromey <tom@tromey.com>
11799
11800 * common/create-version.sh: Use common/version.h.
11801
adc6a863
PA
118022019-01-24 Pedro Alves <palves@redhat.com>
11803
11804 * infrun.c (signal_stop, signal_print, signal_program)
11805 (signal_catch, signal_pass): Now arrays instead of pointers.
11806 (update_signals_program_target, do_target_resume)
11807 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11808 * linux-nat.c (linux_nat_target::pass_signals)
11809 (linux_nat_target::create_inferior, linux_nat_target::attach):
11810 Adjust.
11811 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11812 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11813 * procfs.c (procfs_target::pass_signals): Adjust.
11814 * record-full.c (record_full_target::resume): Adjust.
11815 * remote.c (remote_target::pass_signals)
11816 (remote_target::program_signals): Adjust.
11817 * target-debug.h (target_debug_print_signals): Now takes a
11818 gdb::array_view as parameter. Adjust.
11819 * target.h (target_ops) <pass_signals, program_signals>: Replace
11820 pointer and length parameters with gdb::array_view.
11821 (target_pass_signals, target_program_signals): Likewise.
11822 * target-delegates.c: Regenerate.
11823
3046d67a
PA
118242019-01-24 Pedro Alves <palves@redhat.com>
11825
11826 * common/forward-scope-exit.h
11827 (forward_scope_exit::forward_scope_exit): Pass arguments to
11828 m_bind_function directly, instead of creating a std::bind and
11829 copying that.
11830
353229bf
AH
118312019-01-24 Alan Hayward <alan.hayward@arm.com>
11832
11833 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11834 for static members.
11835 (pass_in_v_vfp_candidate): Likewise.
11836
311dc83a
TT
118372019-01-23 Tom Tromey <tom@tromey.com>
11838 Pedro Alves <palves@redhat.com>
11839
11840 * regcache.c (class regcache_invalidator): Remove.
11841 (regcache::raw_write): Use make_scope_exit.
11842
296bd123
TT
118432019-01-23 Tom Tromey <tom@tromey.com>
11844
11845 * ui-out.h (class ui_out_emit_type): Update comment.
11846
979a0d13
TT
118472019-01-23 Tom Tromey <tom@tromey.com>
11848
11849 * infrun.c (fetch_inferior_event): Update comment.
11850
d238133d
TT
118512019-01-23 Tom Tromey <tom@tromey.com>
11852 Pedro Alves <palves@redhat.com>
11853
11854 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11855 parameter.
11856 (fetch_inferior_event): Use SCOPE_EXIT.
11857
11858
9885e6bb
TT
118592019-01-23 Tom Tromey <tom@tromey.com>
11860 Pedro Alves <palves@redhat.com>
11861
11862 * infrun.c (disable_thread_events): Delete.
11863 (stop_all_threads): Use SCOPE_EXIT.
11864
286526c1
TT
118652019-01-23 Tom Tromey <tom@tromey.com>
11866 Pedro Alves <palves@redhat.com>
11867
11868 * symfile.c: Include forward-scope-exit.h.
11869 (clear_symtab_users_cleanup): Replace forward declaration with
11870 a FORWARD_SCOPE_EXIT.
11871 (syms_from_objfile_1): Use the forward_scope_exit and
11872 gdb::optional instead of cleanup_function.
11873 (reread_symbols): Use the forward_scope_exit instead of
11874 cleanup_function.
11875 (clear_symtab_users_cleanup): Remove function.
11876
1db93f14
TT
118772019-01-23 Tom Tromey <tom@tromey.com>
11878 Pedro Alves <palves@redhat.com>
11879
11880 * linux-nat.c: Include scope-exit.h.
11881 (cleanup_target_stop): Remove.
11882 (linux_nat_target::static_tracepoint_markers_by_strid): Use
11883 SCOPE_EXIT.
11884
2cc83d1e
TT
118852019-01-23 Tom Tromey <tom@tromey.com>
11886 Pedro Alves <palves@redhat.com>
11887
11888 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11889 (call_function_by_hand_dummy): Use SCOPE_EXIT.
11890
694c6bf5
TT
118912019-01-23 Tom Tromey <tom@tromey.com>
11892 Andrew Burgess <andrew.burgess@embecosm.com>
11893 Pedro Alves <palves@redhat.com>
11894
11895 * infrun.c (fetch_inferior_event): Use scope_exit.
11896 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11897 * top.c (execute_command): Use scope_exit.
11898 * breakpoint.c (bpstat_do_actions): Use scope_exit.
11899 * utils.c (do_bpstat_clear_actions_cleanup)
11900 (make_bpstat_clear_actions_cleanup): Remove.
11901
4c41382a
TT
119022019-01-23 Tom Tromey <tom@tromey.com>
11903 Pedro Alves <palves@redhat.com>
11904
11905 * infrun.c: Include "common/scope-exit.h"
11906 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11907 (wait_for_inferior): Use SCOPE_EXIT.
11908 (fetch_inferior_event): Use scope_exit.
11909
89f8fb50
TT
119102019-01-23 Tom Tromey <tom@tromey.com>
11911 Pedro Alves <palves@redhat.com>
11912
11913 * breakpoint.c (create_breakpoint): Remove cleanup.
11914
5419bdae
TT
119152019-01-23 Tom Tromey <tom@tromey.com>
11916 Andrew Burgess <andrew.burgess@embecosm.com>
11917 Pedro Alves <palves@redhat.com>
11918
e587ef42
PA
119192019-01-23 Pedro Alves <palves@redhat.com>
11920
11921 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11922
77f0e74c
PA
119232019-01-23 Pedro Alves <palves@redhat.com>
11924 Andrew Burgess <andrew.burgess@embecosm.com>
11925
11926 * gdbthread.h: Include "common/forward-scope-exit.h".
11927 (scoped_finish_thread_state): Redefine custom class in terms of
11928 forward_scope_exit.
11929
5b9b3e53
PA
119302019-01-23 Pedro Alves <palves@redhat.com>
11931 Andrew Burgess <andrew.burgess@embecosm.com>
11932
11933 * common/forward-scope-exit.h: New file.
11934
54b65c9b
PA
119352019-01-23 Pedro Alves <palves@redhat.com>
11936 Andrew Burgess <andrew.burgess@embecosm.com>
11937 Tom Tromey <tom@tromey.com>
11938
11939 * common/scope-exit.h: New file.
11940
cf08fb29
PA
119412019-01-23 Pedro Alves <palves@redhat.com>
11942
11943 * common/preprocessor.h (ESC): Rename to ...
11944 (ESC_PARENS): ... this.
11945 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11946 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11947
ae73e2e2
TT
119482019-01-23 Tom Tromey <tom@tromey.com>
11949
11950 * language.h (class scoped_switch_to_sym_language_if_auto):
11951 Initialize m_lang in both cases.
11952
6594e122
AH
119532019-01-23 Alan Hayward <alan.hayward@arm.com>
11954
11955 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11956 with XCNEW.
11957
a7c9855d
TT
119582019-01-22 Tom Tromey <tom@tromey.com>
11959
11960 * corelow.c: Do not include sys/file.h.
11961
93cc1d53
TT
119622019-01-22 Tom Tromey <tom@tromey.com>
11963
11964 * tui/tui-wingeneral.h: Include gdb_curses.h.
11965
38561778
TT
119662019-01-22 Tom Tromey <tom@tromey.com>
11967
11968 * source-cache.h (class source_cache) <get_source_lines,
11969 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11970
37b3ab5b
TT
119712019-01-22 Tom Tromey <tom@tromey.com>
11972
11973 * remote-fileio.h (struct remote_target): Declare.
11974
3fabc016
TT
119752019-01-22 Tom Tromey <tom@tromey.com>
11976
11977 * python/py-arch.c: Do not include py-ref.h.
11978 * python/py-bpevent.c: Do not include py-ref.h.
11979 * python/py-cmd.c: Do not include py-ref.h.
11980 * python/py-continueevent.c: Do not include py-ref.h.
11981 * python/py-event.h: Do not include py-ref.h.
11982 * python/py-evtregistry.c: Do not include py-ref.h.
11983 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11984 * python/py-frame.c: Do not include py-ref.h.
11985 * python/py-framefilter.c: Do not include py-ref.h.
11986 * python/py-function.c: Do not include py-ref.h.
11987 * python/py-infevents.c: Do not include py-ref.h.
11988 * python/py-linetable.c: Do not include py-ref.h.
11989 * python/py-objfile.c: Do not include py-ref.h.
11990 * python/py-param.c: Do not include py-ref.h.
11991 * python/py-prettyprint.c: Do not include py-ref.h.
11992 * python/py-progspace.c: Do not include py-ref.h.
11993 * python/py-symbol.c: Do not include py-ref.h.
11994 * python/py-symtab.c: Do not include py-ref.h.
11995 * python/py-type.c: Do not include py-ref.h.
11996 * python/py-unwind.c: Do not include py-ref.h.
11997 * python/py-utils.c: Do not include py-ref.h.
11998 * python/py-value.c: Do not include py-ref.h.
11999 * python/py-varobj.c: Do not include py-ref.h.
12000 * python/py-xmethods.c: Do not include py-ref.h.
12001 * python/python.c: Do not include py-ref.h.
12002 * varobj.c: Do not include py-ref.h.
12003
6b4d7774
TT
120042019-01-22 Tom Tromey <tom@tromey.com>
12005
12006 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12007 keyword for bcache.
12008
7af7e9b5
TT
120092019-01-22 Tom Tromey <tom@tromey.com>
12010
12011 * compile/compile-cplus-types.c: Remove a comment by #include.
12012
951d1049
TT
120132019-01-22 Tom Tromey <tom@tromey.com>
12014
12015 * compile/gcc-c-plugin.h: Include compile-internal.h.
12016
d65d5705
TT
120172019-01-22 Tom Tromey <tom@tromey.com>
12018
12019 * stabsread.c (EXTERN): Do not define.
12020 (symnum, next_symbol_text_func, processing_gcc_compilation)
12021 (within_function, global_sym_chain, global_stabs)
12022 (previous_stab_code, this_object_header_files)
12023 (n_this_object_header_files)
12024 (n_allocated_this_object_header_files): Define.
12025 * stabsread.h (EXTERN): Never define. Use "extern".
12026
b6fb1ee5
PW
120272019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12028
12029 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12030 history_value.
12031
be6d4f74
TT
120322019-01-21 Tom Tromey <tom@tromey.com>
12033
12034 * ui-out.c: Fix includes.
12035 * tui/tui-source.c: Fix includes.
12036 * target.c: Fix includes.
12037 * remote.c: Fix includes.
12038 * regcache.c: Fix includes.
12039 * python/py-block.c: Fix includes.
12040 * printcmd.c: Fix includes.
12041 * or1k-tdep.c: Fix includes.
12042 * mi/mi-main.c: Fix includes.
12043 * m32r-tdep.c: Fix includes.
12044 * csky-tdep.c: Fix includes.
12045 * compile/compile-cplus-types.c: Fix includes.
12046 * cli/cli-interp.c: Fix includes.
12047
73021deb
AH
120482019-01-21 Alan Hayward <alan.hayward@arm.com>
12049
12050 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12051 for padding.
12052
7932255d
TT
120532019-01-16 Tom Tromey <tom@tromey.com>
12054
12055 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
12056 earlier.
12057 (struct objfile) <msymbols_range>: Move from top level.
12058 <msymbols>: New method.
12059 (class objfile_msymbols): Remove.
12060 * symtab.c (default_collect_symbol_completion_matches_break_on):
12061 Update.
12062 * symmisc.c (dump_msymbols): Update.
12063 * stabsread.c (scan_file_globals): Update.
12064 * objc-lang.c (info_selectors_command, info_classes_command)
12065 (find_methods): Update.
12066 * minsyms.c (find_solib_trampoline_target): Update.
12067 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12068 * coffread.c (coff_symfile_read): Update.
12069 * ada-lang.c (ada_lookup_simple_minsym)
12070 (ada_collect_symbol_completion_matches): Update.
12071
604b1bfb
TT
120722019-01-16 Tom Tromey <tom@tromey.com>
12073
12074 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12075 type. Remove no-argument constructor.
12076 <iterator::operator++>: Simplify.
12077 <begin>: Update.
12078 <end>: Use minimal_symbol_count.
12079
f252c6d5
TT
120802019-01-16 Tom Tromey <tom@tromey.com>
12081
12082 * objfiles.h (struct objfile) <psymtabs>: New method.
12083 (class objfile_psymtabs): Remove.
12084 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12085 typedef.
12086 <range>: New method.
12087 (require_partial_symbols): Change return type.
12088 * psymtab.c (require_partial_symbols)
12089 (psym_expand_symtabs_matching): Update.
12090 * mdebugread.c (parse_partial_symbols): Update.
12091 * dbxread.c (dbx_end_psymtab): Update.
12092
b669c953
TT
120932019-01-15 Tom Tromey <tom@tromey.com>
12094
12095 * symtab.c (lookup_objfile_from_block)
12096 (lookup_symbol_in_objfile_symtabs)
12097 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12098 (find_line_symtab, info_sources_command)
12099 (default_collect_symbol_completion_matches_break_on)
12100 (make_source_files_completion_list): Update.
12101 * symmisc.c (print_objfile_statistics, dump_objfile)
12102 (maintenance_print_symbols, maintenance_info_symtabs)
12103 (maintenance_check_symtabs, maintenance_info_line_tables):
12104 Update.
12105 * source.c (select_source_symtab)
12106 (forget_cached_source_info_for_objfile): Update.
12107 * objfiles.h (class objfile_compunits): Remove.
12108 (struct objfile) <compunits_range>: New typedef.
12109 (compunits): New method.
12110 * objfiles.c (objfile_relocate1): Update.
12111 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12112 * maint.c (count_symtabs_and_blocks): Update.
12113 * linespec.c (iterate_over_all_matching_symtabs): Update.
12114 * cp-support.c (add_symbol_overload_list_qualified): Update.
12115 * coffread.c (coff_symtab_read): Update.
12116 * ada-lang.c (add_nonlocal_symbols)
12117 (ada_collect_symbol_completion_matches)
12118 (ada_add_global_exceptions): Update.
12119
7e955d83
TT
121202019-01-15 Tom Tromey <tom@tromey.com>
12121
12122 * progspace.h (program_space) <objfiles_safe_range>: New
12123 typedef.
12124 <objfiles_safe>: New method.
12125 * objfiles.h (class all_objfiles_safe): Remove.
12126 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12127 * jit.c (jit_inferior_exit_hook): Update.
12128
2030c079
TT
121292019-01-17 Tom Tromey <tom@tromey.com>
12130
12131 * progspace.h (program_space) <objfiles_range>: New typedef.
12132 <objfiles>: New method.
12133 <objfiles_head>: Rename from objfiles.
12134 (object_files): Update.
12135 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12136 * guile/scm-pretty-print.c
12137 (ppscm_find_pretty_printer_from_objfiles): Update.
12138 * guile/scm-objfile.c (gdbscm_objfiles): Update.
12139 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12140 Update.
12141 * python/py-progspace.c (pspy_get_objfiles): Update.
12142 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12143 Update.
12144 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12145 (objfpy_lookup_objfile_by_build_id): Update.
12146 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12147 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12148 Update.
12149 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12150 (expand_symtab_containing_pc, lookup_objfile_from_block)
12151 (lookup_static_symbol, basic_lookup_transparent_type)
12152 (find_pc_sect_compunit_symtab, find_symbol_at_address)
12153 (find_line_symtab, info_sources_command)
12154 (default_collect_symbol_completion_matches_break_on)
12155 (make_source_files_completion_list, find_main_name): Update.
12156 * symmisc.c (print_symbol_bcache_statistics)
12157 (print_objfile_statistics, maintenance_print_symbols)
12158 (maintenance_print_msymbols, maintenance_print_objfiles)
12159 (maintenance_info_symtabs, maintenance_check_symtabs)
12160 (maintenance_expand_symtabs, maintenance_info_line_tables):
12161 Update.
12162 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12163 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12164 (map_overlay_command, unmap_overlay_command)
12165 (simple_overlay_update, expand_symtabs_matching)
12166 (map_symbol_filenames): Update.
12167 * symfile-debug.c (set_debug_symfile): Update.
12168 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12169 Update.
12170 * source.c (select_source_symtab, forget_cached_source_info):
12171 Update.
12172 * solib.c (solib_read_symbols): Update.
12173 * solib-spu.c (append_ocl_sos): Update.
12174 * psymtab.c (maintenance_print_psymbols)
12175 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12176 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12177 * printcmd.c (info_symbol_command): Update.
12178 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12179 Update.
12180 * objfiles.h (class all_objfiles): Remove.
12181 * objfiles.c (have_partial_symbols, have_full_symbols)
12182 (have_minimal_symbols, qsort_cmp, update_section_map)
12183 (shared_objfile_contains_address_p)
12184 (default_iterate_over_objfiles_in_search_order): Update.
12185 * objc-lang.c (info_selectors_command, info_classes_command)
12186 (find_methods): Update.
12187 * minsyms.c (find_solib_trampoline_target): Update.
12188 * maint.c (maintenance_info_sections)
12189 (maintenance_translate_address, count_symtabs_and_blocks):
12190 Update.
12191 * main.c (captured_main_1): Update.
12192 * linux-thread-db.c (try_thread_db_load_from_pdir)
12193 (has_libpthread): Update.
12194 * linespec.c (iterate_over_all_matching_symtabs)
12195 (search_minsyms_for_name): Update.
12196 * jit.c (jit_find_objf_with_entry_addr): Update.
12197 * hppa-tdep.c (find_unwind_entry)
12198 (hppa_lookup_stub_minimal_symbol): Update.
12199 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12200 Update.
12201 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12202 (elf_gnu_ifunc_resolve_by_got): Update.
12203 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12204 * dwarf-index-write.c (save_gdb_index_command): Update.
12205 * cp-support.c (add_symbol_overload_list_qualified): Update.
12206 * breakpoint.c (create_overlay_event_breakpoint)
12207 (create_longjmp_master_breakpoint)
12208 (create_std_terminate_master_breakpoint)
12209 (create_exception_master_breakpoint): Update.
12210 * blockframe.c (find_pc_partial_function): Update.
12211 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12212 (ada_collect_symbol_completion_matches)
12213 (ada_add_global_exceptions): Update.
12214
776489e0
TT
122152019-01-17 Tom Tromey <tom@tromey.com>
12216
12217 * solib-target.c (lm_info_target_p): Remove typedef. Don't
12218 declare VEC.
12219 (solib_target_parse_libraries): Change return type.
12220 (library_list_start_segment, library_list_start_section)
12221 (library_list_end_library, library_list_start_library); Update.
12222 (solib_target_free_library_list): Remove.
12223 (solib_target_parse_libraries): Remove cleanup. Change return
12224 type.
12225 (solib_target_current_sos): Update.
12226
6471e7d2
TT
122272019-01-17 Tom Tromey <tromey@bapiya>
12228
12229 * valprint.c: Replace "the the" with "the".
12230 * symtab.c: Replace "the the" with "the".
12231 * solib.c: Replace "the the" with "the".
12232 * solib-dsbt.c: Replace "the the" with "the".
12233 * linespec.c: Replace "the the" with "the".
12234 * dwarf2loc.h: Replace "the the" with "the".
12235 * amd64-windows-tdep.c: Replace "the the" with "the".
12236 * aarch64-tdep.c: Replace "the the" with "the".
12237
c24bdb02
KS
122382019-01-16 Keith Seitz <keiths@redhat.com>
12239
12240 PR gdb/23773
12241 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12242 <builder>: Rename to ..
12243 <m_builder>: ... this and make private.
12244 (dwarf2_cu::get_builder): New method. Change all users of
12245 `builder' to use this method.
12246 (dwarf2_start_symtab): Move to ...
12247 (dwarf2_cu::start_symtab): ... here. Update all callers
12248 (setup_type_unit_groups): Move to ...
12249 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
12250 callers.
12251 (dwarf2_cu::reset_builder): New method.
12252 (process_full_compunit, process_full_type_unit): Use
12253 dwarf2_cu::reset_builder.
12254 (follow_die_offset): Record the ancestor CU if it is different
12255 from the followed DIE's CU.
12256 (follow_die_sig_1): Likewise.
12257
8d64371b
TT
122582019-01-15 Tom Tromey <tom@tromey.com>
12259
12260 * remote.c (class remote_state) <buf>: Now a char_vector.
12261 <buf_size>: Remove.
12262 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
12263 parameter.
12264 (remote_target::getpkt_or_notif_sane_1)
12265 (remote_target::getpkt_sane)
12266 (remote_target::getpkt_or_notif_sane): Likewise.
12267 (class remote_target) <putpkt>: New overload.
12268 (remote_target::read_frame): Change type of "buf_p". Remove
12269 sizeof_p parameter.
12270 (packet_ok): New overload.
12271 (packet_check_result): New overload.
12272 Update all uses.
12273
bb277751
TT
122742019-01-14 Tom Tromey <tom@tromey.com>
12275
12276 * remote-notif.c (handle_notification, remote_notif_ack)
12277 (remote_notif_parse): Make "buf" const.
12278 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12279 const.
12280 (remote_notif_parse, remote_notif_ack, handle_notification):
12281 Likewise.
12282 * remote.c (remote_notif_stop_parse): Make "buf" const.
12283 (remote_target::remote_parse_stop_reply): Make "buf" const.
12284 (remote_notif_stop_ack): Make "buf" const.
12285
05be00a8
TT
122862019-01-14 Tom Tromey <tom@tromey.com>
12287
12288 * remote.c (remote_console_output): Make parameter const.
12289
491adeca
TT
122902019-01-14 Tom Tromey <tom@tromey.com>
12291
12292 * target-debug.h (target_debug_print_signals): Constify.
12293 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12294 * procfs.c (procfs_target::pass_signals): Update.
12295 * linux-nat.c (linux_nat_target::pass_signals): Update.
12296 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12297 * target-delegates.c: Rebuild.
12298 * remote.c (remote_target::program_signals): Update.
12299 (remote_target::pass_signals): Update.
12300 * target.c (target_pass_signals): Constify argument.
12301 (target_program_signals): Likewise.
12302 * target.h (struct target_ops) <pass_signals, program_signals>:
12303 Constify argument.
12304 (target_pass_signals, target_program_signals): Constify argument.
12305
bbd94648
TT
123062019-01-14 Tom Tromey <tom@tromey.com>
12307
12308 PR tui/28819:
12309 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12310
6f072a10
PFC
123112019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
12312
12313 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12314 field.
12315 * rs6000-tdep.c: Include reggroups.h.
12316 (IS_V_ALIAS_PSEUDOREG): Define.
12317 (rs6000_register_name): Return names for the "vX" aliases.
12318 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12319 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
12320 aliases. Call default_register_reggroup_p for all other
12321 pseudo-registers.
12322 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12323 New functions.
12324 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12325 Handle "vX" aliases.
12326 (v_alias_pseudo_register_collect): New function.
12327 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12328 (rs6000_gdbarch_init): Initialize "vX" aliases as
12329 pseudo-registers. Restore registration of
12330 rs6000_pseudo_register_reggroup_p with
12331 set_tdesc_pseudo_register_reggroup_p.
12332
1a782351
MF
123332019-01-13 Max Filippov <jcmvbkbc@gmail.com>
12334
12335 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12336 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12337 set_gdbarch_num_pseudo_regs.
12338
d73cff18
PW
123392019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12340
12341 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12342 Remove arg prefixname, add do_set and do_show.
12343 Add member functions set_list and show_list.
12344 * cli/cli-style.c (class cli_style_option): Update accordingly.
12345 (style_set_list): Move to file scope.
12346 (style_show_list): Likewise.
12347 (set_style): Call help_list.
12348 (show_style): Call cmd_show_list.
12349 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12350 Update to use the new macro.
12351
60a90376
JB
123522019-10-12 Joel Brobecker <brobecker@adacore.com>
12353
12354 * ada-lang.c (_initialize_ada_language): Expand the help text
12355 for the "catch exception" command.
12356
9d7c67bf
PW
123572019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12358
12359 * symtab.c (matching_obj_sections): Initialize obj,
12360 declare it closer to its usage.
12361
7cf47dc4
TT
123622019-01-10 Tom Tromey <tom@tromey.com>
12363
12364 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12365 (basic_inf_threads_range): Remove.
12366 (inf_threads_range, inf_non_exited_threads_range)
12367 (safe_inf_threads_range): Use next_adapter.
12368
d3cb6808
KS
123692019-01-10 Keith Seitz <keiths@redhat.com>
12370
12371 PR gdb/23712
12372 PR symtab/23010
12373 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12374 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12375
63a20375
KS
123762019-01-10 Keith Seitz <keiths@redhat.com>
12377
12378 PR gdb/23712
12379 PR symtab/23010
12380 * dictionary.c (pending_to_vector): Remove.
12381 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12382 Remove _1 suffix, replacing functions of the same name. Update
12383 all callers.
12384 (dict_create_hashed, dict_create_hashed_expandable)
12385 (dict_create_linear, dict_create_linear_expandable, dict_free)
12386 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12387 Make functions static.
12388
b026f593
KS
123892019-01-10 Keith Seitz <keiths@redhat.com>
12390
12391 PR gdb/23712
12392 PR symtab/23010
12393 * dictionary.h (struct dictionary): Replace declaration with
12394 multidictionary.
12395 (dict_create_hashed, dict_create_hashed_expandable)
12396 (dict_create_linear, dict_create_linear_expandable)
12397 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12398 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12399 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12400 taking multidictionary argument.
12401 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12402 * block.h (struct block) <dict>: Change to multidictionary
12403 and rename `multidict'.
12404 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12405 symmisc.c: Update all dictionary references to multidictionary.
12406
c7748ee9
KS
124072019-01-10 Keith Seitz <keiths@redhat.com>
12408
12409 PR gdb/23712
12410 PR symtab/23010
12411 * dictionary.c: Include unordered_map.
12412 (pending_to_vector): New function.
12413 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12414 Rewrite the non-"_1" functions to take vector instead
12415 of linked list.
12416 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12417 "new" _1 versions of the same name.
12418 (multidictionary): Define.
12419 (std::hash<enum language): New definition.
12420 (collate_pending_symbols_by_language, mdict_create_hashed)
12421 (mdict_create_hashed_expandable, mdict_create_linear)
12422 (mdict_create_linear_expandable, mdict_free)
12423 (find_language_dictionary, create_new_language_dictionary)
12424 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12425 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12426 (mdict_size, mdict_empty): New functions.
12427 * dictionary.h (mdict_iterator): Define.
12428
67aa1f3c
PA
124292019-01-10 Pedro Alves <palves@redhat.com>
12430
12431 * breakpoint.c (read_uploaded_action)
12432 (create_tracepoint_from_upload): Adjust to use
12433 gdb::unique_xmalloc_ptr.
12434 * ctf.c (ctf_write_uploaded_tp):
12435 (SET_ARRAY_FIELD): Use emplace_back.
12436 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12437 * tracefile-tfile.c (tfile_write_uploaded_tp):
12438 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12439 gdb::unique_xmalloc_ptr.
12440 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12441 at_string, cond_string, cmd_strings>: Replace char pointers
12442 with gdb::unique_xmalloc_ptr.
12443
2f667667
PA
124442019-01-10 Pedro Alves <palves@redhat.com>
12445
12446 * solib-target.c (library_list_start_library): Don't xstrdup name.
12447
36cb7237
PA
124482019-01-10 Pedro Alves <palves@redhat.com>
12449
12450 * mdebugread.c (parse_partial_symbols): Use
12451 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12452
da584958
AB
124532019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12454
12455 * linux-fork.c (scoped_switch_fork_info)
12456 <~scoped_switch_fork_info>: Fix incorrect variable name.
12457
1ef8573c
AB
124582019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12459
12460 * linux-fork.c (scoped_switch_fork_info)
12461 <scoped_switch_fork_info>: Make explicit.
12462 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12463
8d7bcccb
TT
124642019-01-10 Tom Tromey <tom@tromey.com>
12465
12466 * objfiles.h (objfile::reset_psymtabs): Update.
12467 * objfiles.c (objfile::objfile): Update.
12468 * psymtab.h (psymtab_storage::obstack): Update.
12469 (psymtab_storage::m_obstack): Use gdb::optional.
12470 (class psymtab_storage): Update comment. Remove objfile
12471 parameter.
12472 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12473
b596a3c7
TT
124742019-01-10 Tom Tromey <tom@tromey.com>
12475
12476 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12477 <free_psymtabs>: Now private.
12478 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12479 (allocate_psymtab): Use new method.
12480
a9342b62
TT
124812019-01-10 Tom Tromey <tom@tromey.com>
12482
12483 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12484 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12485 * mdebugread.c (parse_partial_symbols): Use
12486 allocate_dependencies.
12487 * dwarf2read.c (dwarf2_create_include_psymtab): Use
12488 allocate_dependencies.
12489 (process_psymtab_comp_unit_reader)
12490 (build_type_psymtab_dependencies): Likewise.
12491 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12492
5af70966
TT
124932019-01-10 Tom Tromey <tom@tromey.com>
12494
12495 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12496 PSYMBOL_SET_LANGUAGE.
12497 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12498
5923a04c
TT
124992019-01-10 Tom Tromey <tom@tromey.com>
12500
12501 * psymtab.h (psymtab_storage::obstack): New method.
12502 <m_obstack>: Rename from obstack; now private.
12503 * psymtab.c (psymtab_storage): Update.
12504 * dwarf2read.c (create_addrmap_from_index)
12505 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12506 Update.
12507
6d6a12bf
TT
125082019-01-10 Tom Tromey <tom@tromey.com>
12509
12510 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12511 * objfiles.h (objfile::reset_psymtabs): New method.
12512
d320c2b5
TT
125132019-01-10 Tom Tromey <tom@tromey.com>
12514
12515 * symmisc.c (print_symbol_bcache_statistics): Update.
12516 (print_objfile_statistics): Update.
12517 * symfile.c (reread_symbols): Update.
12518 * psymtab.h (class psymtab_storage): New.
12519 * psymtab.c (psymtab_storage): New constructor.
12520 (~psymtab_storage): New destructor.
12521 (require_partial_symbols): Update.
12522 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12523 (find_pc_sect_psymtab, find_pc_sect_psymbol)
12524 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12525 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12526 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12527 (start_psymtab_common, end_psymtab_common)
12528 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12529 (allocate_psymtab): Update.
12530 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12531 Update.
12532 (dump_psymtab_addrmap, maintenance_print_psymbols)
12533 (maintenance_check_psymtabs): Update.
12534 (class objfile_psymtabs): Move to objfiles.h.
12535 * psympriv.h (discard_psymtab): Now inline.
12536 (psymtab_discarder::psymtab_discarder): Update.
12537 (psymtab_discarder::~psymtab_discarder): Update.
12538 (ALL_OBJFILE_PSYMTABS): Rewrite.
12539 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12540 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12541 Remove fields.
12542 <partial_symtabs>: New field.
12543 (class objfile_psymtabs): Move from psymtab.h. Update.
12544 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12545 psymbol_cache.
12546 (objfile::~objfile): Don't destroy psymbol_cache.
12547 * mdebugread.c (parse_partial_symbols): Update.
12548 * dwarf2read.c (create_addrmap_from_index)
12549 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12550 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12551 (add_partial_subprogram, dwarf2_ranges_read): Update.
12552 * dwarf-index-write.c (write_address_map)
12553 (write_one_signatured_type, recursively_write_psymbols)
12554 (class debug_names, class debug_names, write_psymtabs_to_index):
12555 Update.
12556
1d94a5a3
TT
125572019-01-10 Tom Tromey <tom@tromey.com>
12558
12559 * symtab.h (SYMBOL_SET_NAMES): Update.
12560 (symbol_set_names): Update.
12561 (MSYMBOL_SET_NAMES): Update.
12562 * symtab.c (symbol_set_names): Change argument to be an
12563 objfile_per_bfd_storage.
12564 * psymtab.c (add_psymbol_to_bcache): Update.
12565 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12566
0f14768a
TT
125672019-01-10 Tom Tromey <tom@tromey.com>
12568
12569 * symtab.c (create_demangled_names_hash): Change argument to be an
12570 objfile_per_bfd_storage.
12571 (symbol_set_names): Update.
12572
6eee24ce
TT
125732019-01-10 Tom Tromey <tom@tromey.com>
12574
12575 * xcoffread.c (xcoff_initial_scan): Unconditionally call
12576 init_psymbol_list.
12577 * psymtab.c (init_psymbol_list): Do nothing if already called.
12578 * psympriv.h (init_psymbol_list): Add comment.
12579 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12580 init_psymbol_list.
12581 * dbxread.c (dbx_symfile_read): Unconditionally call
12582 init_psymbol_list.
12583
75aedd27
TT
125842019-01-10 Tom Tromey <tom@tromey.com>
12585
12586 * xcoffread.c (scan_xcoff_symtab): Update.
12587 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12588 "where".
12589 * mdebugread.c (parse_partial_symbols)
12590 (handle_psymbol_enumerators): Update.
12591 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12592 * dbxread.c (read_dbx_symtab): Update.
12593 * psympriv.h (psymbol_placement): New enum.
12594 (add_psymbol_to_list): Update.
12595
939652a5
TT
125962019-01-10 Tom Tromey <tom@tromey.com>
12597
12598 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12599 static_psymbols parameters.
12600 (scan_xcoff_symtab): Update.
12601 * psymtab.c (start_psymtab_common): Remove global_psymbols and
12602 static_psymbols parameters.
12603 * psympriv.h (start_psymtab_common): Update.
12604 * mdebugread.c (parse_partial_symbols): Update.
12605 * dwarf2read.c (create_partial_symtab): Update.
12606 * dbxread.c (read_dbx_symtab): Update.
12607 (start_psymtab): Remove global_psymbols and static_psymbols
12608 parameters.
12609
baa62830
TT
126102019-01-10 Tom Tromey <tom@tromey.com>
12611
12612 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12613 * psymtab.c (allocate_psymtab): Add comment.
12614 * psympriv.h (allocate_psymtab): Add comment.
12615 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12616 initializations.
12617 * dbxread.c (dbx_end_psymtab): Remove some initializations.
12618
0e8f53ba
TT
126192019-01-10 Tom Tromey <tom@tromey.com>
12620
12621 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12622 Don't declare.
12623 * mipsread.c: Include mdebugread.h.
12624 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12625 Declare.
12626 * elfread.c: Include mdebugread.h.
12627
b22a7c6a
TT
126282019-01-09 Tom Tromey <tom@tromey.com>
12629
12630 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12631 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12632 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12633 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12634 (psym_lookup_symbol, psym_find_last_source_symtab)
12635 (psym_forget_cached_source_info, psym_print_stats)
12636 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12637 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12638 (psym_map_matching_symbols, psym_expand_symtabs_matching)
12639 (psym_find_compunit_symtab_by_address)
12640 (maintenance_print_psymbols, maintenance_info_psymtabs)
12641 (maintenance_check_psymtabs): Use ranged for.
12642 * psymtab.h (class objfile_psymtabs): New.
12643 (require_partial_symbols): Return objfile_psymtabs.
12644 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12645
3b9d3ac2
TT
126462019-01-09 Tom Tromey <tom@tromey.com>
12647
12648 * symfile.c (overlay_invalidate_all, find_pc_overlay)
12649 (find_pc_mapped_section, list_overlays_command)
12650 (map_overlay_command, unmap_overlay_command)
12651 (simple_overlay_update): Use all_objfiles.
12652 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12653 * printcmd.c (info_symbol_command): Use all_objfiles.
12654 * objfiles.h (ALL_OBJSECTIONS): Remove.
12655 * maint.c (maintenance_translate_address): Use all_objfiles.
12656 * gcore.c (gcore_create_callback): Use all_objfiles.
12657 (objfile_find_memory_regions): Likewise.
12658
8b31193a
TT
126592019-01-09 Tom Tromey <tom@tromey.com>
12660
12661 * symtab.c (find_line_symtab, info_sources_command)
12662 (make_source_files_completion_list): Use objfile_compunits.
12663 * source.c (select_source_symtab): Use objfile_compunits.
12664 * objfiles.h (struct objfile): Update comment.
12665 (ALL_OBJFILES): Remove.
12666 (ALL_FILETABS): Remove.
12667 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12668 objfile_compunits.
12669
d5da8b3c
TT
126702019-01-09 Tom Tromey <tom@tromey.com>
12671
12672 * symmisc.c (print_objfile_statistics, dump_objfile)
12673 (maintenance_print_symbols): Use compunit_filetabs.
12674 * source.c (forget_cached_source_info_for_objfile): Use
12675 compunit_filetabs.
12676 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12677 (ALL_FILETABS): Use compunit_filetabs.
12678 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12679 * coffread.c (coff_symtab_read): Use compunit_filetabs.
12680
5accd1a0
TT
126812019-01-09 Tom Tromey <tom@tromey.com>
12682
12683 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12684 (compunit_filetabs): New.
12685 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12686 compunit_filetabs.
12687 (info_sources_command, make_source_files_completion_list): Remove
12688 declaration.
12689 * symmisc.c (print_objfile_statistics, dump_objfile)
12690 (maintenance_print_symbols): Remove declaration.
12691 (maintenance_info_symtabs): Use compunit_filetabs.
12692 (maintenance_info_line_tables): Likewise.
12693 * source.c (select_source_symtab): Change local variable name.
12694 (forget_cached_source_info_for_objfile): Remove declaration.
12695 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12696 * objfiles.c (objfile_relocate1): Remove declaration.
12697 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12698 declaration.
12699 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12700 * coffread.c (coff_symtab_read): Remove declaration.
12701 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12702 compunit_filetabs.
12703
d8aeb77f
TT
127042019-01-09 Tom Tromey <tom@tromey.com>
12705
12706 * symtab.c (lookup_objfile_from_block)
12707 (find_pc_sect_compunit_symtab, search_symbols)
12708 (default_collect_symbol_completion_matches_break_on): Use
12709 objfile_compunits.
12710 * objfiles.h (ALL_COMPUNITS): Remove.
12711 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12712 * cp-support.c (add_symbol_overload_list_qualified): Use
12713 objfile_compunits.
12714 * ada-lang.c (ada_collect_symbol_completion_matches)
12715 (ada_add_global_exceptions): Use objfile_compunits.
12716
592553c4
TT
127172019-01-09 Tom Tromey <tom@tromey.com>
12718
12719 * source.c (select_source_symtab)
12720 (forget_cached_source_info_for_objfile): Remove declaration.
12721 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12722 declaration.
12723 * maint.c (count_symtabs_and_blocks): Remove declaration.
12724 * cp-support.c (add_symbol_overload_list_qualified): Remove
12725 declaration.
12726 * coffread.c (coff_symtab_read): Remove declaration.
12727 * symtab.c (lookup_symbol_in_objfile_symtabs)
12728 (basic_lookup_transparent_type_1): Use objfile_compunits.
12729 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12730 (info_sources_command, search_symbols)
12731 (default_collect_symbol_completion_matches_break_on)
12732 (make_source_files_completion_list): Remove declaration.
12733 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12734 (ada_collect_symbol_completion_matches)
12735 (ada_add_global_exceptions): Remove declaration.
12736 * linespec.c (iterate_over_all_matching_symtabs): Use
12737 objfile_compunits.
12738 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12739 (class objfile_compunits): New.
12740 (ALL_COMPUNITS): Use objfile_compunits.
12741 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12742 (maintenance_check_symtabs, maintenance_info_line_tables): Use
12743 objfile_compunits.
12744 * objfiles.c (objfile_relocate1): Use objfile_compunits.
12745
5325b9bf
TT
127462019-01-09 Tom Tromey <tom@tromey.com>
12747
12748 * symtab.c (search_symbols)
12749 (default_collect_symbol_completion_matches_break_on): Use
12750 objfile_msymbols.
12751 * ada-lang.c (ada_lookup_simple_minsym)
12752 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12753 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12754 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12755 objfile_msymbols.
12756 * coffread.c (coff_symfile_read): Use objfile_msymbols.
12757 * symmisc.c (dump_msymbols): Use objfile_msymbols.
12758 * objc-lang.c (find_methods): Use objfile_msymbols.
12759 (info_selectors_command, info_classes_command): Likewise.
12760 * stabsread.c (scan_file_globals): Use objfile_msymbols.
12761 * objfiles.h (class objfile_msymbols): New.
12762 (ALL_OBJFILE_MSYMBOLS): Remove.
12763 (ALL_MSYMBOLS): Remove.
12764
cac85af2
TT
127652019-01-09 Tom Tromey <tom@tromey.com>
12766
12767 * common/next-iterator.h (next_adapter): Add Iterator template
12768 parameter.
12769 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12770 (class all_objfiles_safe): New.
12771 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12772 * objfiles.c (put_objfile_before): Update comment.
12773 (add_separate_debug_objfile): Likewise.
12774 (free_all_objfiles): Use all_objfiles_safe.
12775 (objfile_purge_solibs): Likewise.
12776
aed57c53
TT
127772019-01-09 Tom Tromey <tom@tromey.com>
12778
12779 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12780 (expand_symtab_containing_pc, lookup_static_symbol)
12781 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12782 (find_symbol_at_address, find_line_symtab, find_main_name): Use
12783 all_objfiles.
12784 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12785 * breakpoint.c (create_overlay_event_breakpoint)
12786 (create_longjmp_master_breakpoint)
12787 (create_std_terminate_master_breakpoint)
12788 (create_exception_master_breakpoint): Use all_objfiles.
12789 * linux-thread-db.c (try_thread_db_load_from_pdir)
12790 (has_libpthread): Use all_objfiles.
12791 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12792 * linespec.c (iterate_over_all_matching_symtabs)
12793 (search_minsyms_for_name): Use all_objfiles.
12794 * maint.c (maintenance_info_sections): Use all_objfiles.
12795 * main.c (captured_main_1): Use all_objfiles.
12796 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12797 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12798 * guile/scm-pretty-print.c
12799 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12800 * solib-spu.c (append_ocl_sos): Use all_objfiles.
12801 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12802 (maintenance_print_msymbols): Use all_objfiles.
12803 * source.c (select_source_symtab): Use all_objfiles.
12804 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12805 * symfile.c (remove_symbol_file_command)
12806 (expand_symtabs_matching, map_symbol_filenames): Use
12807 all_objfiles.
12808 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12809 all_objfiles.
12810 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12811 * objc-lang.c (find_methods): Use all_objfiles.
12812 * objfiles.c (have_partial_symbols, have_full_symbols)
12813 (have_minimal_symbols, qsort_cmp)
12814 (default_iterate_over_objfiles_in_search_order): Use
12815 all_objfiles.
12816 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12817 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12818 (maintenance_check_psymtabs): Use all_objfiles.
12819 (ALL_PSYMTABS): Remove.
12820 * compile/compile-object-run.c (do_module_cleanup): Use
12821 all_objfiles.
12822 * blockframe.c (find_pc_partial_function): Use all_objfiles.
12823 * cp-support.c (add_symbol_overload_list_qualified): Use
12824 all_objfiles.
12825 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12826 Use all_objfiles.
12827 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12828 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12829 all_objfiles.
12830 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12831 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12832 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12833 Uses all_objfiles.
12834 * solib.c (solib_read_symbols): Use all_objfiles
12835
99d89cde
TT
128362019-01-09 Tom Tromey <tom@tromey.com>
12837
12838 * probe.c (parse_probes_in_pspace): Use all_objfiles.
12839 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12840 all_objfiles.
12841 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12842 * symmisc.c (print_symbol_bcache_statistics)
12843 (print_objfile_statistics, maintenance_print_objfiles)
12844 (maintenance_info_symtabs, maintenance_check_symtabs)
12845 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12846 all_objfiles.
12847 * source.c (forget_cached_source_info): Use all_objfiles.
12848 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12849 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12850 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12851 * objfiles.c (update_section_map): Use all_objfiles.
12852 (shared_objfile_contains_address_p): Likewise.
12853 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12854 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12855
21708325
TT
128562019-01-09 Tom Tromey <tom@tromey.com>
12857
12858 * common/next-iterator.h: New file.
12859 * objfiles.h (class all_objfiles): New.
12860 (struct objfile_iterator): New.
12861
669e09f6
PW
128622019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12863
12864 * NEWS: Move the description of the changed "frame", "select-frame",
12865 and "info frame" commands to the Changed commands section.
12866
041be526
SM
128672019-01-09 Simon Marchi <simon.marchi@ericsson.com>
12868
12869 * gdbtypes.c (check_stub_method_group): Remove handling of old
12870 mangling schemes.
12871 * linespec.c (find_methods): Likewise.
12872 * stabsread.c (read_member_functions): Likewise.
12873 * valops.c (search_struct_method): Likewise.
12874 (value_struct_elt_for_reference): Likewise.
12875 * NEWS: Mention this change.
12876
0e2a2133
AB
128772019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
12878
12879 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12880 print_source_lines.
12881 * source.c (print_source_lines_base): Update line number check.
12882 (print_source_lines): New function.
12883 (source_lines_range::source_lines_range): New function.
12884 * source.h (class source_lines_range): New class.
12885 (print_source_lines): New declaration.
12886
1055a3b4
PW
128872019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12888
12889 * linespec.c (linespec_state_destructor): Free self->canonical_names.
12890
cfeadda5
TT
128912019-01-08 Tom Tromey <tom@tromey.com>
12892 Simon Marchi <simon.marchi@ericsson.com>
12893
12894 PR gdb/24060
12895 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12896 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12897 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12898 * f-exp.y (DOLLAR_VARIABLE): Likewise.
12899 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12900 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12901
583068ca
AB
129022019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12903
12904 * source.c (select_source_symtab): Move header comment to
12905 declaration in source.h.
12906 (forget_cached_source_info_for_objfile): Likewise.
12907 (forget_cached_source_info): Likewise.
12908 (identify_source_line): Likewise.
12909 * source.h (identify_source_line): Move declaration from symtab.h
12910 and add comment from source.c
12911 (print_source_lines): Likewise.
12912 (forget_cached_source_info_for_objfile): Likewise.
12913 (forget_cached_source_info): Likewise.
12914 (select_source_symtab): Likewise.
12915 (enum print_source_lines_flag): Move definition from symtab.h.
12916 * symtab.h (identify_source_line): Move declaration to source.h.
12917 (print_source_lines): Likewise.
12918 (forget_cached_source_info_for_objfile): Likewise.
12919 (forget_cached_source_info): Likewise.
12920 (select_source_symtab): Likewise.
12921 (enum print_source_lines_flag): Move definition to source.h.
12922 * tui/tui-hooks.c: Add 'source.h' include.
12923
ec98a4ad
AB
129242019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12925
12926 * source.c (print_source_lines_base): Handle requests to print
12927 reverse line number sequences, and guard against empty lines
12928 string.
12929
62ea19c1
AB
129302019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12931
12932 * source.c (print_source_lines_base): Fix skip of '\r' if next
12933 character is '\n'.
12934
9d30e1fd
TT
129352019-01-06 Tom Tromey <tom@tromey.com>
12936
12937 * c-exp.y (struct c_parse_state) <macro_original_text,
12938 expansion_obstack>: New member.
12939 (macro_original_text, expansion_obstack): Remove globals.
12940 (scan_macro_expansion, scanning_macro_expansion)
12941 (finished_macro_expansion): Update.
12942 (scan_macro_cleanup): Remove.
12943 (yylex, c_parse): Update.
12944
c65bac38
TT
129452019-01-06 Tom Tromey <tom@tromey.com>
12946
12947 * c-exp.y (struct c_parse_state) <strings>: New member.
12948 (operator_stoken): Update.
12949
02e12e38
TT
129502019-01-06 Tom Tromey <tom@tromey.com>
12951
12952 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12953 (union type_stack_elt) <typelist_val>: Now a pointer to
12954 std::vector.
12955 (type_stack_cleanup): Don't declare.
12956 (push_typelist): Update.
12957 * parse.c (pop_typelist): Return a std::vector.
12958 (push_typelist): Take a std::vector.
12959 (follow_types): Update. Do not free args.
12960 (type_stack_cleanup): Remove.
12961 * c-exp.y (struct c_parse_state): New.
12962 (cpstate): New global.
12963 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12964 (nonempty_typelist): Update.
12965 (func_mod): Create a new vector.
12966 (c_parse): Create a c_parse_state.
12967 (check_parameter_typelist): Do not delete params.
12968 (function_method): Update. Do not delete type_list.
12969
f097f5ad
TT
129702019-01-06 Tom Tromey <tom@tromey.com>
12971
12972 PR gdb/28155:
12973 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12974 check_typedef.
12975 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12976 (print_return_value): Likewise.
12977
d2adf9f1
TT
129782019-01-05 Tom Tromey <tom@tromey.com>
12979
12980 * contrib/cleanup_check.py: Remove.
12981 * contrib/gcc-with-excheck: Remove.
12982 * contrib/exsummary.py: Remove.
12983 * contrib/excheck.py: Remove.
12984
2eab46b1
JB
129852019-01-05 Joel Brobecker <brobecker@adacore.com>
12986
12987 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12988 NULL. Initialize tpprev to NULL instead of assigning it
12989 to NULL on the next statement.
12990 * windows-nat.c (windows_delete_thread): Remove check for
12991 main_thread_id before printing thread exit notifications.
12992 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12993 Remove thread ID check against main_thread_id.
12994 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12995 windows_delete_thread.
12996 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12997
48c5e7e2
TT
129982019-01-04 Tom Tromey <tom@tromey.com>
12999
13000 * compile/compile.c (_initialize_compile): Use upper case for
13001 metasyntactic variables.
13002 * symmisc.c (_initialize_symmisc): Use upper case for
13003 metasyntactic variables.
13004 * psymtab.c (_initialize_psymtab): Use upper case for
13005 metasyntactic variables.
13006 * demangle.c (demangle_command): Use upper case for metasyntactic
13007 variables.
13008 (_initialize_demangler): Likewise.
13009 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13010 variables.
13011
986041cd
TT
130122019-01-03 Tom Tromey <tom@tromey.com>
13013
13014 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13015
7c711119
TT
130162019-01-03 Tom Tromey <tom@tromey.com>
13017
13018 * python/py-symtab.c (salpy_str): Update.
13019 (struct salpy_sal_object) <symtab>: Now a PyObject.
13020 (salpy_dealloc): Update.
13021 (del_objfile_sal): Use gdbpy_ref.
13022
1b20edf0
TT
130232019-01-03 Tom Tromey <tom@tromey.com>
13024
13025 * python/py-type.c (convert_field): Use new_reference. Return
13026 gdbpy_ref.
13027 (make_fielditem): Return gdbpy_ref.
13028 (typy_fields): Update.
13029 (typy_getitem): Update.
13030 (field_name): Return gdbpy_ref. Use new_reference.
13031 (typy_iterator_iternext): Update.
13032
ea41325b
TT
130332019-01-03 Tom Tromey <tom@tromey.com>
13034
13035 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13036
2a3c71d6
TT
130372019-01-03 Tom Tromey <tom@tromey.com>
13038
13039 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13040 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13041 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13042 (pspy_set_frame_filters, pspy_set_frame_unwinders)
13043 (pspy_set_type_printers): Likewise.
13044 * python/py-function.c (fnpy_init): Use gdbpy_ref.
13045 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13046 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13047 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13048 (objfpy_set_type_printers): Likewise.
13049
5c329e6a
TT
130502019-01-03 Tom Tromey <tom@tromey.com>
13051
13052 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13053 (gdbpy_print_stack): Use gdbpy_err_fetch.
13054 * python/python-internal.h (class gdbpy_err_fetch): New class.
13055 (class gdbpy_enter) <m_error_type, m_error_value,
13056 m_error_traceback>: Remove.
13057 <m_error>: New member.
13058 (gdbpy_exception_to_string): Don't declare.
13059 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13060 * python/py-value.c (convert_value_from_python): Use
13061 gdbpy_err_fetch.
13062 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13063 gdbpy_exception_to_string.
13064 (gdbpy_handle_exception): Use gdbpy_err_fetch.
13065 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13066 gdbpy_err_fetch.
13067
169bb27b
AB
130682019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13069
13070 * linux-nat.c (delete_lwp_cleanup): Delete.
13071 (struct lwp_deleter): New struct.
13072 (lwp_info_up): New typedef.
13073 (linux_nat_target::follow_fork): Delete cleanup, and make use of
13074 lwp_info_up.
13075
a07c8880
AB
130762019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13077
13078 * linux-fork.c (class scoped_switch_fork_info): New class.
13079 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13080
26089c49
AB
130812019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13082
13083 * valops.c (find_overload_match): Remove use of null_cleanup, and
13084 calls to do_cleanups.
13085
06d3e5b0
AB
130862019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13087
13088 * compile/compile-cplus-types.c
13089 (compile_cplus_instance::decl_name): Handle changes to
13090 cp_func_name.
13091 * cp-support.c (cp_func_name): Update header comment, update
13092 return type.
13093 * cp-support.h (cp_func_name): Update return type in declaration.
13094 * valops.c (find_overload_match): Move temp_func local to top
13095 level of function and change its type. Use temp_func to hold and
13096 delete temporary string obtained from cp_func_name.
13097
66644cd3
AB
130982019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13099
13100 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13101 gdb::char_vector, remove cleanup, and update uses of `msg`.
13102
592d8c0a
JW
131032019-01-03 Jim Wilson <jimw@sifive.com>
13104
13105 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13106
c55d06ec
TT
131072019-01-02 Tom Tromey <tom@tromey.com>
13108
13109 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13110 (tdesc_parse_xml): Remove cleanups.
13111 * target-descriptions.h (make_cleanup_free_target_description):
13112 Don't declare.
13113 (target_desc_deleter): New struct.
13114 (target_desc_up): New typedef.
13115 * target-descriptions.c (target_desc_deleter::operator()): Rename
13116 from free_target_description.
13117 (make_cleanup_free_target_description): Remove.
13118
3a6ae42d
TT
131192019-01-02 Tom Tromey <tom@tromey.com>
13120
13121 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
13122 constructor, destructor.
13123 (linespec_parser): Remove typedef.
13124 (~linespec_parser): Rename from linespec_parser_delete.
13125 (linespec_lex_to_end, linespec_complete_label)
13126 (linespec_complete): Update.
13127 (decode_line_full): Remove cleanups.
13128 (decode_line_1): Update.
13129
61fd3e73
TT
131302019-01-02 Tom Tromey <tom@tromey.com>
13131
13132 * python/python-internal.h (inferior_to_inferior_object): Change
13133 return type.
13134 * python/py-exitedevent.c (create_exited_event_object): Update.
13135 * python/py-inferior.c (inferior_to_inferior_object): Return
13136 gdbpy_ref.
13137 (python_new_inferior, python_inferior_deleted)
13138 (thread_to_thread_object, delete_thread_object)
13139 (build_inferior_list, gdbpy_selected_inferior): Update.
13140 * python/py-infthread.c (create_thread_object): Update. Also fail
13141 if inferior_to_inferior_object fails.
13142
d20172fc
SM
131432019-01-02 Simon Marchi <simon.marchi@ericsson.com>
13144
13145 * inferior.h (class inferior) <displaced_step_state>: New field.
13146 * infrun.h (struct displaced_step_state): Move here from
13147 infrun.c. Initialize fields, add constructor.
13148 <inf>: Remove field.
13149 <reset>: New method.
13150 * infrun.c (struct displaced_step_inferior_state): Move to
13151 infrun.h.
13152 (displaced_step_inferior_states): Remove.
13153 (get_displaced_stepping_state): Adust.
13154 (displaced_step_in_progress_any_inferior): Adjust.
13155 (displaced_step_in_progress_thread): Adjust.
13156 (displaced_step_in_progress): Adjust.
13157 (add_displaced_stepping_state): Remove.
13158 (get_displaced_step_closure_by_addr): Adjust.
13159 (remove_displaced_stepping_state): Remove.
13160 (infrun_inferior_exit): Call displaced_step_state.reset.
13161 (use_displaced_stepping): Don't check for NULL.
13162 (displaced_step_prepare_throw): Call
13163 get_displaced_stepping_state.
13164 (displaced_step_fixup): Don't check for NULL.
13165 (prepare_for_detach): Don't check for NULL.
13166
e3319240
PW
131672019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13168
13169 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13170 in case of call that did not complete.
13171
5d36dfb9
AU
131722019-01-02 Andrey Utkin <autkin@undo.io>
13173
13174 * symfile.c (find_separate_debug_file): Fix search of debug files for
13175 remote debuggee.
13176
8833fbf0
TT
131772019-01-02 Tom Tromey <tom@tromey.com>
13178
13179 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13180 indentation.
13181 * python/py-frame.c (frapy_older): Remove cast.
13182 (frapy_newer): Likewise.
13183 * python/py-breakpoint.c (local_setattro): Remove cast.
13184 * python/py-arch.c (archpy_name): Remove local variable.
13185 * python/py-type.c (gdbpy_lookup_type): Remove cast.
13186
4ada3dfd
JB
131872019-01-02 Joel Brobecker <brobecker@adacore.com>
13188
13189 * unittests/basic_string_view/element_access/char/empty.cc:
13190 Fix year range in copyright header.
13191
113b7b81
AB
131922019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
13193
13194 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13195 Delete.
13196 <operator==>: Update with for removed field.
13197 <hash>: Likewise.
13198 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13199 <isa_features>: ...this.
13200 <abi_features>: New field.
13201 (riscv_isa_flen): Update comment.
13202 (riscv_abi_xlen): New declaration.
13203 (riscv_abi_flen): New declaration.
13204 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13205 isa_features.
13206 (riscv_abi_xlen): New function.
13207 (riscv_isa_flen): Update to get answer from isa_features.
13208 (riscv_abi_flen): New function.
13209 (riscv_has_fp_abi): Update to get answer from abi_features.
13210 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13211 xlen and flen.
13212 (riscv_call_info) <xlen, flen>: Update comment.
13213 (riscv_call_arg_struct): Remove invalid assertions
13214 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13215 is removed.
13216 (riscv_gdbarch_init): Gather isa features and abi features
13217 separately, ensure both match on the gdbarch when reusing an old
13218 gdbarch. Relax an error check to allow 32-bit abi float to run on
13219 a target with 64-bit float hardware.
13220
b18ca514
PW
132212019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13222
13223 * source.c (search_command_helper): Stop reverse search
13224 when line 1 has been searched.
13225
ec70d8db
PW
132262019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13227
13228 * record-full.c (record_full_base_target::close): Rewrite
13229 record_full_core_buf_list free logic.
13230
5b38f9c1
PW
132312019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13232
13233 * break-catch-syscall.c (print_one_catch_syscall): xfree
13234 the last text.
13235
66d91b39
JB
132362019-01-01 Joel Brobecker <brobecker@adacore.com>
13237
13238 * top.c (print_gdb_version): Update Copyright year in version
13239 message.
13240
42a4f53d
JB
132412019-01-01 Joel Brobecker <brobecker@adacore.com>
13242
13243 Update copyright year range in all GDB files.
13244
7e955d83 132452019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 13246
5bbd631d 13247 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 13248
5bbd631d 13249For older changes see ChangeLog-2018.
c906108c
SS
13250\f
13251Local Variables:
13252mode: change-log
13253left-margin: 8
13254fill-column: 74
13255version-control: never
57da7796 13256coding: utf-8
c906108c 13257End:
5bbd631d 13258
This page took 3.03196 seconds and 4 git commands to generate.