[gdb/testsuite] Make gdb_test message more informative in multi-term-settings.exp
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
43771869
AB
12019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
2
3 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4 all uses as this was never set to anything but a zero value.
5
26c957f1
PA
62019-08-21 Bogdan Harjoc <harjoc@gmail.com>
7
8 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
9
c07aae6e
CB
102019-08-21 Christian Biesinger <cbiesinger@google.com>
11
12 * tui/tui-data.h (tui_gen_win_info): Add an =default
13 move constructor, required by some GCC versions.
14
3960cb7a
JF
152019-08-21 Jinke Fan <fanjinke51@yeah.net>
16
17 * go32-nat.c (go32_sysinfo): Add hygon_p.
18
04c72a68
TT
192019-08-20 Tom Tromey <tom@tromey.com>
20
21 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
22 line_from_reg_element_no, first_reg_element_no_inline,
23 display_all_data, delete_data_content_windows,
24 erase_data_content>: Now private.
25
072272ce
TT
262019-08-20 Tom Tromey <tom@tromey.com>
27
28 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
29 (tui_unhighlight_win, tui_highlight_win)
30 (tui_win_info::make_window): Update.
31 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
32
973961bd
TT
332019-08-20 Tom Tromey <tom@tromey.com>
34
35 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
36 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
37 (MAX_PID_WIDTH): Move to tui-stack.c.
38 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
39 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
40 (MAX_PID_WIDTH): Move from tui-data.h.
41
ab0e1f1a
TT
422019-08-20 Tom Tromey <tom@tromey.com>
43
44 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
45 * tui/tui-wingeneral.c (box_win): Change type of win_info.
46 (box_win): Update.
47 (tui_gen_win_info::make_window): Rename from tui_make_window.
48 (tui_win_info::make_window): New method.
49 (tui_gen_win_info::make_visible): Update.
50 * tui/tui-source.c (tui_source_window::set_contents): Update.
51 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
52 (tui_data_window::display_registers_from): Update.
53 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
54 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
55 Declare.
56 <can_box>: Remove.
57 <title>: Remove.
58 (struct tui_win_info) <make_window>: Declare.
59 <can_box>: Now virtual.
60 <title>: New member.
61 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
62 * tui/tui-command.c (tui_cmd_window::resize): Update.
63
100c2bf3
TT
642019-08-20 Tom Tromey <tom@tromey.com>
65
66 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
67 * tui/tui-regs.c (tui_data_window::show_registers): Update.
68 (tui_data_window::check_register_values): Update.
69
fa4dc567
TT
702019-08-20 Tom Tromey <tom@tromey.com>
71
72 * tui/tui-regs.h (struct tui_data_window): Use
73 DISABLE_COPY_AND_ASSIGN.
74 <regs_content>: Change type, removing unique_ptr.
75 <tui_data_window>: Add move constructor.
76 * tui/tui-regs.c (tui_data_window::show_registers)
77 (tui_data_window::show_register_group)
78 (tui_data_window::display_registers_from)
79 (tui_data_window::display_registers_from)
80 (tui_data_window::first_data_item_displayed)
81 (tui_data_window::delete_data_content_windows)
82 (tui_data_window::rerender, tui_data_window::refresh_window)
83 (tui_data_window::check_register_values): Update.
84
ca02d7c8
TT
852019-08-20 Tom Tromey <tom@tromey.com>
86
87 * tui/tui-regs.h (struct tui_data_window) <show_registers,
88 show_register_group>: Declare.
89 (tui_show_register_group): Don't declare.
90 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
91 tui_show_registers.
92 (tui_data_window::show_register_group): Rename from
93 tui_show_register_group.
94 (tui_data_window::check_register_values, tui_reg_command):
95 Update.
96 * tui/tui-layout.c (tui_set_layout): Update.
97
63356bfd
TT
982019-08-20 Tom Tromey <tom@tromey.com>
99
100 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
101 Declare.
102 (tui_check_register_values): Don't declare.
103 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
104 from tui_check_register_values.
105 * tui/tui-hooks.c (tui_register_changed): Update.
106
42cc14a7
TT
1072019-08-20 Tom Tromey <tom@tromey.com>
108
109 * tui/tui-regs.c (tui_reg_layout): Move later.
110 (tui_show_registers): Don't enable TUI mode or change layout.
111
b9ad3686
TT
1122019-08-20 Tom Tromey <tom@tromey.com>
113
114 * tui/tui-regs.h (struct tui_data_item_window)
115 <~tui_data_item_window>: Remove.
116 <content>: Now a unique_xmalloc_ptr.
117 * tui/tui-regs.c (tui_register_format): Return a
118 unique_xmalloc_ptr.
119 (tui_get_register): Update.
120 (~tui_data_item_window): Remove.
121 (tui_data_window::display_registers_from, tui_display_register):
122 Update.
123 * tui/tui-io.h (tui_expand_tabs): Update.
124 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
125 Remove "col" parameter.
126
8e114aab
TT
1272019-08-20 Tom Tromey <tom@tromey.com>
128
129 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
130 field.
131 * tui/tui-regs.c (~tui_data_item_window): Update.
132
1a4f81dd
TT
1332019-08-20 Tom Tromey <tom@tromey.com>
134
135 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
136 earlier.
137
0f8d8876
TT
1382019-08-20 Tom Tromey <tom@tromey.com>
139
140 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
141
605dc2c2
TT
1422019-08-20 Tom Tromey <tom@tromey.com>
143
144 * tui/tui-source.h (struct tui_source_window): Update.
145 * tui/tui-regs.c (tui_show_registers): Update.
146 * tui/tui-disasm.h (struct tui_disasm_window): Update.
147 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
148 (NO_REGS_STRING): Remove defines.
149
aedbe3bb
CM
1502019-08-20 Conrad Meyer <cem@FreeBSD.org>
151
152 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
153 unnecessary thread walk if remote doesn't support the packet.
154
7ce8f214
TT
1552019-08-19 Tom Tromey <tromey@adacore.com>
156
157 * python/py-value.c (value_has_field): Fix indentation.
158
f21c2bd7
TT
1592019-08-19 Tom Tromey <tromey@adacore.com>
160
161 * printcmd.c (do_one_display, info_display_command): Update.
162 * block.h (contained_in): Return bool. Add allow_nested
163 parameter.
164 * block.c (contained_in): Return bool. Add allow_nested
165 parameter.
166
d806ea2d
TT
1672019-08-19 Tom Tromey <tom@tromey.com>
168
169 * configure: Rebuild.
170 * configure.ac: Disallow the combination of -static-libstdc++ and
171 source highlight.
172 * source-cache.c (get_language_name): Handle rust.
173 (source_cache::get_source_lines): Ignore highlighting exceptions.
174
398fdd60
TT
1752019-08-16 Tom Tromey <tom@tromey.com>
176
177 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
178 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
179 (struct tui_source_window_base) <make_visible, refresh_window,
180 resize>: Remove methods.
181 <execution_info>: Remove field.
182 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
183 (tui_show_source_line, tui_source_window_base)
184 (~tui_source_window_base): Update.
185 (tui_source_window_base::resize)
186 (tui_source_window_base::make_visible)
187 (tui_source_window_base::refresh_window): Remove.
188 (tui_source_window_base::update_exec_info): Update.
189 * tui/tui-source.c (tui_source_window::set_contents): Update.
190 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
191
e699d331
TT
1922019-08-16 Tom Tromey <tom@tromey.com>
193
194 * tui/tui-hooks.c (tui_remove_hooks): Don't set
195 deprecated_query_hook.
196
bb01dbfc
TT
1972019-08-16 Tom Tromey <tom@tromey.com>
198
199 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
200 (tui_update_source_windows_with_line): Update.
201 * tui/tui-source.h (struct tui_source_window)
202 <show_symtab_source>: Declare.
203 (tui_show_symtab_source): Don't declare.
204 * tui/tui-source.c (tui_show_symtab_source): Rename from
205 tui_show_symtab_source.
206
81c82c4b
TT
2072019-08-16 Tom Tromey <tom@tromey.com>
208
209 * tui/tui-winsource.h (struct tui_source_window_base)
210 <set_contents>: Declare.
211 * tui/tui-winsource.c
212 (tui_source_window_base::update_source_window_as_is): Update.
213 * tui/tui-source.h (struct tui_source_window) <set_contents>:
214 Declare.
215 (tui_set_source_content): Don't declare.
216 * tui/tui-source.c (tui_source_window::set_contents): Rename from
217 tui_set_source_content.
218 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
219 Declare.
220 (tui_set_disassem_content): Don't declare.
221 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
222 tui_set_disassem_content.
223
2ddaf614
TT
2242019-08-16 Tom Tromey <tom@tromey.com>
225
226 * tui/tui-winsource.h (struct tui_source_window_base)
227 <update_breakpoint_info>: Declare.
228 (tui_update_breakpoint_info): Don't declare.
229 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
230 (tui_update_all_breakpoint_info): Update.
231 (tui_source_window_base::update_breakpoint_info): Rename from
232 tui_update_breakpoint_info.
233 (tui_source_window_base::update_exec_info): Update.
234
017f9828
TT
2352019-08-16 Tom Tromey <tom@tromey.com>
236
237 * tui/tui-winsource.h (struct tui_source_window_base)
238 <update_source_window>: Declare.
239 (tui_update_source_window): Don't declare.
240 * tui/tui-winsource.c
241 (tui_source_window_base::update_source_window): Rename from
242 tui_update_source_window.
243 (tui_source_window_base::rerender): Update.
244 * tui/tui-source.c (tui_source_window::maybe_update): Update.
245 * tui/tui-disasm.c (tui_show_disassem)
246 (tui_show_disassem_and_update_source)
247 (tui_disasm_window::maybe_update): Update.
248
ed8358e9
TT
2492019-08-16 Tom Tromey <tom@tromey.com>
250
251 * tui/tui-winsource.h (struct tui_source_window_base)
252 <update_source_window_as_is>: Declare.
253 (tui_update_source_window_as_is): Don't declare.
254 * tui/tui-winsource.c (tui_update_source_window): Update
255 (tui_source_window_base::update_source_window_as_is): Rename from
256 tui_update_source_window_as_is.
257 (tui_source_window_base::refill): Update.
258 * tui/tui-source.c (tui_show_symtab_source): Update.
259 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
260 Update.
261
20149b6b
TT
2622019-08-16 Tom Tromey <tom@tromey.com>
263
264 * tui/tui-winsource.h (tui_update_source_window)
265 (tui_update_source_window_as_is): Remove "noerror" parameter.
266 * tui/tui-winsource.c (tui_update_source_window)
267 (tui_update_source_window_as_is): Remove "noerror" parameter.
268 (tui_update_source_windows_with_addr)
269 (tui_update_source_windows_with_line)
270 (tui_source_window_base::rerender)
271 (tui_source_window_base::refill): Update.
272 * tui/tui-source.h (tui_set_source_content)
273 (tui_show_symtab_source): Remove "noerror" parameter.
274 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
275 parameter.
276 (tui_show_symtab_source): Likewise.
277 (tui_source_window::maybe_update): Update.
278 * tui/tui-disasm.c (tui_show_disassem)
279 (tui_show_disassem_and_update_source)
280 (tui_disasm_window::do_scroll_vertical)
281 (tui_disasm_window::maybe_update): Update.
282
2d83e710
TT
2832019-08-16 Tom Tromey <tom@tromey.com>
284
285 * tui/tui.c (tui_is_window_visible): Update.
286 * tui/tui-wingeneral.c (tui_make_window)
287 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
288 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
289 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
290 (tui_set_win_height_command, parse_scrolling_args): Update.
291 * tui/tui-source.c (tui_source_window::style_changed): Update.
292 * tui/tui-regs.c (tui_show_registers)
293 (tui_data_window::first_data_item_displayed)
294 (tui_data_window::delete_data_content_windows)
295 (tui_check_register_values, tui_reg_command): Update.
296 * tui/tui-disasm.c (tui_show_disassem): Update.
297 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
298 method.
299 <is_visible>: Remove field.
300 * tui/tui-data.c (tui_next_win, tui_prev_win)
301 (tui_delete_invisible_windows): Update.
302
d4ab829a
TT
3032019-08-16 Tom Tromey <tom@tromey.com>
304
305 * tui/tui-winsource.h (struct tui_source_window_base)
306 <m_has_locator>: Remove.
307 * tui/tui-layout.c (show_source_disasm_command, show_data)
308 (show_source_or_disasm_and_command): Update.
309
aa7ca1bb
AH
3102019-08-16 Alan Hayward <alan.hayward@arm.com>
311
312 * NEWS (Other MI changes): New subsection.
313 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
314 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
315 * arch-utils.c (default_get_pc_address_flags): New function.
316 * arch-utils.h (default_get_pc_address_flags): New declaration.
317 * gdbarch.sh: Add get_pc_address_flags.
318 * gdbarch.c: Regenerate.
319 * gdbarch.h: Likewise.
320 * stack.c (print_pc): New function.
321 (print_frame_info) (print_frame): Call print_pc.
322
6eac171f
TV
3232019-08-16 Tom de Vries <tdevries@suse.de>
324
325 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
326 print_objfile_section_info.
327
3df505f6
TT
3282019-08-15 Tom Tromey <tom@tromey.com>
329
330 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
331 calling update_cmdwin_start_line.
332 * tui/tui-winsource.h (struct tui_source_window_base)
333 <do_make_visible_with_new_height, set_new_height>: Don't declare.
334 <rerender>: Declare.
335 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
336 Call rerender.
337 (tui_source_window_base::set_new_height): Remove.
338 (tui_source_window_base::rerender): Rename from
339 do_make_visible_with_new_height.
340 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
341 resize method.
342 (tui_win_info::make_invisible_and_set_new_height)
343 (tui_win_info::make_visible_with_new_height): Remove.
344 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
345 Declare.
346 * tui/tui-stack.c (tui_locator_window::rerender): New method.
347 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
348 do_make_visible_with_new_height>: Don't declare.
349 <rerender>: Declare.
350 * tui/tui-regs.c (tui_data_window::rerender): Rename from
351 set_new_height.
352 (tui_data_window::do_make_visible_with_new_height): Remove.
353 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
354 call tui_show_locator_content.
355 (tui_gen_win_info::resize): Call rerender.
356 (show_source_or_disasm_and_command): Don't call
357 tui_show_locator_content.
358 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
359 method.
360 (struct tui_win_info) <rerender>: Declare.
361 <set_new_height, make_invisible_and_set_new_height,
362 make_visible_with_new_height>: Don't declare.
363 * tui/tui-data.c (tui_win_list::rerender): New method.
364 * tui/tui-command.h (struct tui_cmd_window)
365 <do_make_visible_with_new_height>: Don't declare.
366 * tui/tui-command.c
367 (tui_cmd_window::do_make_visible_with_new_height): Remove.
368
272560b5
TT
3692019-08-15 Tom Tromey <tromey@adacore.com>
370
371 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
372 * ada-lang.c (ada_enum_name): Likewise.
373
08235187
CB
3742019-08-15 Christian Biesinger <cbiesinger@google.com>
375
376 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
377 leading underscore.
378 (GdbOutputErrorFile): Likewise.
379 (global scope): Adjust constructor calls to GdbOutput{,Error}File
380 accordingly.
381 (execute_unwinders): Rename to have a leading underscore.
382 (auto_load_packages): Likewise.
383 (global scope): Adjust call to auto_load_packages accordingly.
384 (GdbSetPythonDirectory): Likewise.
385 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
386 instead of execute_unwinders.
387
db502012
TT
3882019-08-15 Tom Tromey <tom@tromey.com>
389
390 * tui/tui-layout.c (show_layout, show_source_disasm_command)
391 (show_data): Don't change window visibility.
392 (tui_gen_win_info::resize): Remove special case for command
393 window. Use wresize, when available.
394 (show_source_or_disasm_and_command): Don't change window
395 visibility.
396 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
397 <make_visible>: New method.
398 * tui/tui-command.c (tui_cmd_window::resize): New method.
399
3891b65e
TT
4002019-08-15 Tom Tromey <tom@tromey.com>
401
402 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
403 (struct tui_source_windows): New.
404 * tui/tui-winsource.c (tui_display_main): Update.
405 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
406 (new_height_ok, parse_scrolling_args): Update.
407 * tui/tui-layout.c (show_layout, show_data): Update.
408 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
409 (tui_add_to_source_windows): Don't declare.
410 * tui/tui-data.c (source_windows, tui_source_windows)
411 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
412
ee556432
TT
4132019-08-15 Tom Tromey <tom@tromey.com>
414
415 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
416 Rename from reset.
417 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
418 * tui/tui-layout.c (show_source_disasm_command, show_data):
419 Update.
420 (tui_gen_win_info::resize): Rename.
421 (show_source_or_disasm_and_command): Update.
422 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
423 reset.
424
46f438e3
TT
4252019-08-15 Tom Tromey <tom@tromey.com>
426
427 * tui/tui-stack.c (tui_initialize_static_data): Remove.
428 * tui/tui-interp.c (tui_interp::init): Don't call
429 tui_initialize_static_data.
430 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
431
f4ce562c
TT
4322019-08-15 Tom Tromey <tom@tromey.com>
433
434 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
435 examine tui_win_list.
436
c398c3d0
TT
4372019-08-15 Tom Tromey <tom@tromey.com>
438
439 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
440 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
441 tui_clear_source_content.
442 (tui_clear_source_content): Remove.
443 (tui_source_window_base::do_erase_source_content): Hoist call to
444 content.clear().
445 * tui/tui-stack.c (tui_show_frame_info): Don't call
446 tui_clear_source_content.
447
e25d2004
TT
4482019-08-15 Tom Tromey <tom@tromey.com>
449
450 * tui/tui-winsource.h (struct tui_source_window_base)
451 <do_erase_source_content>: New method.
452 <erase_source_content>: New method.
453 (tui_erase_source_content): Don't declare.
454 * tui/tui-winsource.c (tui_clear_source_content): Update.
455 (tui_source_window_base::do_erase_source_content): Rename from
456 tui_erase_source_content.
457 (tui_source_window_base::show_source_content): Update.
458 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
459 * tui/tui-source.h (struct tui_source_window)
460 <erase_source_content>: New method.
461 * tui/tui-disasm.h (struct tui_disasm_window)
462 <erase_source_content>: New method.
463
002f15c2
TT
4642019-08-15 Tom Tromey <tom@tromey.com>
465
466 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
467 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
468 constructor.
469 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
470 * tui/tui-source.c (tui_set_source_content): Update.
471 * tui/tui-disasm.c (tui_set_disassem_content): Update.
472
c9033fe8
TT
4732019-08-15 Tom Tromey <tom@tromey.com>
474
475 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
476 * tui/tui-winsource.c (tui_line_is_displayed): Move to
477 tui-source.c.
478 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
479 Declare.
480 * tui/tui-source.c (tui_source_window::line_is_displayed): New
481 method.
482 (tui_source_window::maybe_update): Update.
483
088f37dd
TT
4842019-08-15 Tom Tromey <tom@tromey.com>
485
486 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
487 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
488 tui-disasm.c.
489 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
490 Declare.
491 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
492 method.
493 (tui_disasm_window::maybe_update): Update.
494
a54700c6
TT
4952019-08-15 Tom Tromey <tom@tromey.com>
496
497 * tui/tui-winsource.h (struct tui_source_window_base)
498 <maybe_update>: Declare.
499 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
500 method.
501 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
502 Declare.
503 * tui/tui-source.c (tui_source_window::maybe_update): New method.
504 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
505 Declare.
506 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
507
e2a678a5
TT
5082019-08-15 Tom Tromey <tom@tromey.com>
509
510 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
511
f2dda477
TT
5122019-08-15 Tom Tromey <tom@tromey.com>
513
514 * tui/tui-wingeneral.c: Include tui-stack.h.
515 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
516 (struct tui_locator_window): Move from tui-data.h.
517 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
518 (tui_initialize_static_data): Move from tui-data.c.
519 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
520 (struct tui_locator_window): Move to tui-stack.c.
521 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
522 (tui_initialize_static_data): Move to tui-stack.c.
523
ed4a1084
TT
5242019-08-15 Tom Tromey <tom@tromey.com>
525
526 * tui/tui-layout.c (show_source_disasm_command)
527 (show_source_or_disasm_and_command): Use make_visible method, not
528 tui_make_window.
529 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
530 Remove.
531
65962b20
TT
5322019-08-15 Tom Tromey <tom@tromey.com>
533
534 * tui/tui-wingeneral.h (tui_make_window): Update.
535 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
536 parameter.
537 (tui_gen_win_info::make_visible): Update.
538 * tui/tui-regs.c (tui_data_window::display_registers_from):
539 Update.
540 * tui/tui-layout.c (show_source_disasm_command)
541 (show_source_or_disasm_and_command): Update.
542 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
543 (enum tui_box): Remove.
544 (struct tui_win_info) <can_box>: New method.
545 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
546 method.
547
2208ee91
TV
5482019-08-15 Tom de Vries <tdevries@suse.de>
549
550 * linux-nat-trad.c: Include gdbarch.h.
551
75faf5c4
AH
5522019-08-14 Alan Hayward <alan.hayward@arm.com>
553
554 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
555 register sizes.
556
b1c896b3
TT
5572019-08-14 Tom Tromey <tromey@adacore.com>
558
559 * darwin-nat.c: Include gdbarch.h.
560 * darwin-nat-info.c: Include gdbarch.h.
561
6405cd73
TT
5622019-08-13 Tom Tromey <tom@tromey.com>
563
564 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
565 Remove.
566 * tui/tui-data.c (tui_initialize_static_data): Update.
567
5216580d
TT
5682019-08-13 Tom Tromey <tom@tromey.com>
569
570 * tui/tui-winsource.h (struct tui_exec_info_window)
571 <~tui_exec_info_window, maybe_allocate_content, get_content,
572 m_content>: Remove.
573 (struct tui_source_window_base) <set_exec_info_content,
574 show_exec_info_content>: Don't declare.
575 * tui/tui-winsource.c
576 (tui_exec_info_window::maybe_allocate_content): Remove.
577 (tui_source_window_base::update_exec_info): Rename from
578 set_exec_info_content.
579 (tui_source_window_base::show_exec_info_content)
580 (tui_source_window_base::update_exec_info): Remove.
581
93858ad3
TT
5822019-08-13 Tom Tromey <tom@tromey.com>
583
584 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
585 declare.
586 * tui/tui-winsource.c (tui_update_source_window_as_is)
587 (tui_update_source_windows_with_addr, tui_erase_source_content):
588 Update.
589 (tui_clear_exec_info_content): Remove.
590
e321e7ce
TT
5912019-08-13 Tom Tromey <tom@tromey.com>
592
593 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
594 declare.
595 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
596 call tui_erase_exec_info_content.
597 (tui_clear_exec_info_content): Rename from
598 tui_erase_exec_info_content.
599 (tui_clear_exec_info_content): Delete.
600
8270ac62
TT
6012019-08-13 Tom Tromey <tom@tromey.com>
602
603 * tui/tui-winsource.h (struct tui_source_window_base)
604 <show_exec_info_content>: Declare.
605 (tui_show_exec_info_content): Don't declare.
606 * tui/tui-winsource.c
607 (tui_source_window_base::show_exec_info_content): Rename from
608 tui_show_exec_info_content.
609 (tui_source_window_base::update_exec_info): Update.
610
7b56485d
TT
6112019-08-13 Tom Tromey <tom@tromey.com>
612
613 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
614 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
615 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
616 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
617 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
618 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
619 ... here.
620
7ba913dc
TT
6212019-08-13 Tom Tromey <tom@tromey.com>
622
623 * tui/tui-winsource.h (struct tui_source_window_base)
624 <update_exec_info>: Declare.
625 (tui_update_exec_info): Don't declare.
626 * tui/tui-winsource.c (tui_update_source_window_as_is)
627 (tui_source_window_base::refresh_all)
628 (tui_update_all_breakpoint_info): Update.
629 (tui_source_window_base::update_exec_info): Rename from
630 tui_update_exec_info.
631 * tui/tui-stack.c (tui_show_frame_info): Update.
632
37a4a131
TT
6332019-08-13 Tom Tromey <tom@tromey.com>
634
635 * tui/tui-winsource.h (struct tui_source_window_base)
636 <set_exec_info_content>: Declare.
637 (tui_set_exec_info_content): Don't declare.
638 * tui/tui-winsource.c
639 (tui_source_window_base::set_exec_info_content): Rename from
640 tui_set_exec_info_content.
641 (tui_update_exec_info): Update.
642
0bd27e07
TT
6432019-08-13 Tom Tromey <tom@tromey.com>
644
645 * tui/tui-winsource.h (struct tui_source_window_base)
646 <show_source_content>: Declare.
647 (tui_show_source_content): Don't declare.
648 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
649 (tui_source_window_base::show_source_content): Rename from
650 tui_show_source_content.
651 (tui_source_window_base::refresh_all): Update.
652 * tui/tui-layout.c (show_source_disasm_command)
653 (show_source_or_disasm_and_command): Update.
654
b4ef5aeb
TT
6552019-08-13 Tom Tromey <tom@tromey.com>
656
657 * tui/tui-winsource.c (tui_erase_source_content)
658 (tui_show_source_content, tui_source_window_base::refresh_all):
659 Update.
660 * tui/tui-wingeneral.h
661 (tui_check_and_display_highlight_if_needed): Don't declare.
662 * tui/tui-wingeneral.c
663 (tui_win_info::check_and_display_highlight_if_needed): Rename from
664 check_and_display_highlight_if_needed.
665 * tui/tui-win.c (tui_rehighlight_all)
666 (tui_win_info::make_visible_with_new_height): Update.
667 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
668 (tui_data_window::erase_data_content)
669 (tui_data_window::display_all_data): Update.
670 * tui/tui-data.h (struct tui_win_info)
671 <check_and_display_highlight_if_needed>: Declare.
672
fede5273
TT
6732019-08-13 Tom Tromey <tom@tromey.com>
674
675 * tui/tui-win.c (tui_resize_all): Call
676 tui_delete_invisible_windows.
677 * tui/tui-layout.c (show_layout): Call
678 tui_delete_invisible_windows.
679 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
680 * tui/tui-data.c (tui_delete_invisible_windows): New function.
681
22c3f490
TT
6822019-08-13 Tom Tromey <tom@tromey.com>
683
684 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
685 tui_add_win_to_layout.
686
16cb7910
TT
6872019-08-13 Tom Tromey <tom@tromey.com>
688
689 * tui/tui-layout.h (tui_default_win_height): Don't declare.
690 * tui/tui-layout.c (tui_default_win_height): Now static.
691
cc0c3ffb
TT
6922019-08-13 Tom Tromey <tom@tromey.com>
693
694 * tui/tui-layout.c (show_layout): Unify all layout cases into a
695 single switch.
696 (show_source_disasm_command, show_source_or_disasm_and_command):
697 Don't check current layout.
698
3f3ffe54
TT
6992019-08-13 Tom Tromey <tom@tromey.com>
700
701 * tui/tui-wingeneral.c (make_all_visible): Remove.
702 (tui_make_all_invisible): Simplify.
703 * tui/tui-layout.c (tui_make_all_invisible): Move from
704 tui-wingeneral.c; simplify.
705 (show_layout): Hoist call to tui_make_all_invisible.
706 (show_data): Don't call tui_make_all_invisible.
707
69258091
TT
7082019-08-13 Tom Tromey <tom@tromey.com>
709
710 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
711 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
712
62cf57fe
TT
7132019-08-13 Tom Tromey <tom@tromey.com>
714
715 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
716 tui-data.c.
717 (show_source_disasm_command, show_data)
718 (show_source_or_disasm_and_command): Don't use
719 tui_set_current_layout_to.
720 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
721 * tui/tui-data.c (current_layout, tui_current_layout): Move to
722 tui-layout.c.
723 (tui_set_current_layout_to): Remove.
724
2afade5d
TT
7252019-08-13 Tom Tromey <tom@tromey.com>
726
727 * tui/tui-layout.c (tui_set_layout): Update.
728 * tui/tui-data.h (struct tui_layout_def): Remove.
729 (tui_layout_def): Don't declare.
730 * tui/tui-data.c (layout_def): Remove.
731 (tui_layout_def): Remove.
732
a3504e96
TT
7332019-08-13 Tom Tromey <tom@tromey.com>
734
735 * tui/tui-winsource.h (struct tui_source_window_base)
736 <clear_detail>: No longer "override".
737 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
738 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
739 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
740 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
741 Remove.
742 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
743
29c92911
TT
7442019-08-13 Tom Tromey <tromey@adacore.com>
745
746 * tracepoint.c: Don't include readline.h or history.h.
747
86c6b807
TT
7482019-08-12 Tom Tromey <tom@tromey.com>
749
750 * configure: Rebuild.
751 * configure.ac: Check for readline 7.
752 * NEWS: Mention readline 7 requirement.
753 * README: Update.
754
5db2718c
TT
7552019-08-12 Tom Tromey <tom@tromey.com>
756
757 * mingw-hdep.c (gdb_select): Remove readline hack.
758
dac36daf
PFC
7592019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
760
761 * blockframe.c (find_pc_partial_function): Set *block to nullptr
762 when the function fails.
763
1022c627
AA
7642019-08-09 Andreas Arnez <arnez@linux.ibm.com>
765
766 * s390-tdep.c (s390_type_align): New function.
767 (s390_gdbarch_init): Set it as type_align gdbarch method.
768
eba4caf2
TV
7692019-08-09 Tom de Vries <tdevries@suse.de>
770
771 PR gdb/24591
772 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
773 pc_low with relocation offset.
774
123cd851
TT
7752019-08-07 Tom Tromey <tromey@adacore.com>
776
777 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
778 (print_frame_args): Update.
779 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
780 Update.
781 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
782 * frame.h (struct frame_arg): Add initializers.
783 <error>: Now a unique_xmalloc_ptr.
784
3d31bc39
AH
7852019-08-07 Alan Hayward <alan.hayward@arm.com>
786
787 * NEWS: Expand the Pointer Authentication entry.
788 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
789 (aarch64_frame_unmask_lr): ... to this.
790 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
791 Call aarch64_frame_unmask_lr.
792 * frame.c (struct frame_info): Add "masked" variable.
793 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
794 (fprint_frame): Check for masked pc.
795 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
796 declarations.
797 * python/py-framefilter.c (py_print_frame): Check for masked pc.
798 * stack.c (print_frame): Check for masked pc.
799
0cf9feb9
TT
8002019-08-06 Tom Tromey <tom@tromey.com>
801
802 * stabsread.c (patch_block_stabs, read_one_struct_field)
803 (read_enum_type): Use obstack_strndup.
804 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
805 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
806 * dwarf2read.c (guess_full_die_structure_name)
807 (anonymous_struct_prefix): Use obstack_strndup.
808 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
809 * c-exp.y (yylex): Use obstack_strndup.
810 * ada-exp.y (write_object_renaming, write_ambiguous_var)
811 (write_var_or_type): Use obstack_strndup.
812
efba19b0
TT
8132019-08-06 Tom Tromey <tom@tromey.com>
814
815 * symfile.c (reread_symbols): Use obstack_strdup.
816 * stabsread.c (read_type): Use obstack_strdup.
817 * gdb_obstack.h (obstack_strdup): New overload.
818 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
819 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
820 (dwarf2_canonicalize_name): Use obstack_strdup.
821 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
822 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
823 Use obstack_strdup.
824
f25102f7
TT
8252019-08-06 Tom Tromey <tom@tromey.com>
826
827 * gdb_obstack.h (obstack_strdup): Define.
828 * gdb_obstack.c (obstack_strdup): Don't define.
829
021887d8
TT
8302019-08-06 Tom Tromey <tom@tromey.com>
831
832 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
833 obstack_strdup.
834 * typeprint.c (typedef_hash_table::find_global_typedef): Use
835 obstack_strdup.
836 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
837 * stabsread.c (common_block_start): Use obstack_strdup.
838 * objfiles.c (set_objfile_main_name, objfile): Use
839 obstack_strdup.
840 * namespace.c (add_using_directive): Use obstack_strdup.
841 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
842 * jit.c (finalize_symtab): Use obstack_strdup.
843 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
844 (guess_partial_die_structure_name, partial_die_info::fixup)
845 (dwarf2_name): Use obstack_strdup.
846 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
847 obstack_strdup.
848 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
849 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
850 obstack_strdup.
851 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
852
d2834edc
PW
8532019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
854
855 * unittests/help-doc-selftests.c: New file.
856 * Makefile.in: Add the new file.
857
590042fc
PW
8582019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
859
860 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
861 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
862 the full first line, except when FOR_VALUE_PREFIX. In this case,
863 the trailing '.' is not output, and the first character is uppercased.
864 (print_help_for_command): Update call to print_doc_line.
865 (print_doc_of_command): Likewise.
866 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
867 * cli/cli-option.c (append_indented_doc): Do not append newline.
868 (build_help_option): Append newline after first appended_indented_doc
869 only if a second call is done.
870 (build_help): Append 2 new lines before each option, except the first
871 one.
872 * compile/compile.c (_initialize_compile): Add new lines after
873 %OPTIONS%, when not at the end of the help.
874 Change help doc or code
875 producing the help doc to respect the invariants.
876 * maint-test-options.c (_initialize_maint_test_options): Likewise.
877 Also removed the new line after 'Options:', as all other commands
878 do not put an empty line between 'Options:' and the first option.
879 * printcmd.c (_initialize_printcmd): Likewise.
880 * stack.c (_initialize_stack): Likewise.
881 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
882 incorrectly telling COMMAND is optional.
883 * ada-lang.c (_initialize_ada_language): Change help doc or code
884 producing the help doc to respect the invariants.
885 * ada-tasks.c (_initialize_ada_tasks): Likewise.
886 * breakpoint.c (_initialize_breakpoint): Likewise.
887 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
888 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
889 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
890 * cli/cli-style.c (cli_style_option::add_setshow_commands,
891 _initialize_cli_style): Likewise.
892 * corelow.c (core_target_info): Likewise.
893 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
894 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
895 * filesystem.c (_initialize_filesystem): Likewise.
896 * frame.c (_initialize_frame): Likewise.
897 * gnu-nat.c (add_task_commands): Likewise.
898 * infcall.c (_initialize_infcall): Likewise.
899 * infcmd.c (_initialize_infcmd): Likewise.
900 * interps.c (_initialize_interpreter): Likewise.
901 * language.c (_initialize_language): Likewise.
902 * linux-fork.c (_initialize_linux_fork): Likewise.
903 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
904 * maint.c (_initialize_maint_cmds): Likewise.
905 * memattr.c (_initialize_mem): Likewise.
906 * printcmd.c (_initialize_printcmd): Likewise.
907 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
908 _RegEx): Likewise.
909 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
910 * record-btrace.c (_initialize_record_btrace): Likewise.
911 * record-full.c (_initialize_record_full): Likewise.
912 * record.c (_initialize_record): Likewise.
913 * regcache-dump.c (_initialize_regcache_dump): Likewise.
914 * regcache.c (_initialize_regcache): Likewise.
915 * remote.c (add_packet_config_cmd, init_remote_threadtests,
916 _initialize_remote): Likewise.
917 * ser-tcp.c (_initialize_ser_tcp): Likewise.
918 * serial.c (_initialize_serial): Likewise.
919 * skip.c (_initialize_step_skip): Likewise.
920 * source.c (_initialize_source): Likewise.
921 * stack.c (_initialize_stack): Likewise.
922 * symfile.c (_initialize_symfile): Likewise.
923 * symtab.c (_initialize_symtab): Likewise.
924 * target-descriptions.c (_initialize_target_descriptions): Likewise.
925 * top.c (init_main): Likewise.
926 * tracefile-tfile.c (tfile_target_info): Likewise.
927 * tracepoint.c (_initialize_tracepoint): Likewise.
928 * tui/tui-win.c (_initialize_tui_win): Likewise.
929 * utils.c (add_internal_problem_command): Likewise.
930 * valprint.c (value_print_option_defs): Likewise.
931
404f2902
FCE
9322019-08-06 Frank Ch. Eigler <fche@redhat.com>
933
934 PR build/24886
935 * configure.ac: Drop enable-libmcheck support.
936 * configure, config.in: Rebuild.
937 * libmcheck.m4: Remove.
938 * acinclude.m4: Don't include it.
939 * Makefile.in: Don't distribute it.
940 * top.c (print_gdb_configuration): Don't mention it.
941
046bebe1
TT
9422019-08-06 Tom Tromey <tom@tromey.com>
943
944 * utils.c (set_output_style): Sometimes pass stream to
945 emit_style_escape.
946 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
947 * record-btrace.c (btrace_insn_history): Update.
948 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
949 method.
950 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
951 Update initializers.
952 <m_uiout>: New field.
953 <m_di>: Move lower.
954 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
955 Remove "uiout" parameter.
956 (dump_insns): Update.
957 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
958 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
959
ddbcedf5
CB
9602019-08-06 Christian Biesinger <cbiesinger@google.com>
961
962 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
963 (error_in_psymtab_expansion): Likewise.
964 (lookup_symbol_via_quick_fns): Likewise.
965 (basic_lookup_transparent_type_quick): Likewise.
966 (basic_lookup_transparent_type_1): Likewise.
967
b08b16c8
TT
9682019-08-06 Tom Tromey <tromey@adacore.com>
969
970 * source.c (last_source_error): Now bool.
971 (print_source_lines_base): Make "noprint" bool. Only open
972 source file when last_source_visited changes.
973
cb44333d
TT
9742019-08-06 Tom Tromey <tromey@adacore.com>
975
976 * annotate.c (annotate_source_line): Use g_source_cache.
977 * source-cache.c (source_cache::get_plain_source_lines): Change
978 parameters. Populate m_offset_cache.
979 (source_cache::ensure): New method.
980 (source_cache::get_line_charpos): New method.
981 (extract_lines): Move lower. Change parameters.
982 (source_cache::get_source_lines): Move lower.
983 * source-cache.h (class source_cache): Update comment.
984 <get_line_charpos>: New method.
985 <get_source_lines>: Update comment.
986 <clear>: Clear m_offset_cache.
987 <get_plain_source_lines>: Change parameters.
988 <ensure>: New method
989 <m_offset_cache>: New member.
990 * source.c (forget_cached_source_info_for_objfile): Update.
991 (info_source_command): Use g_source_cache.
992 (find_source_lines, open_source_file_with_line_charpos): Remove.
993 (print_source_lines_base, search_command_helper): Use g_source_cache.
994 * source.h (open_source_file_with_line_charpos): Don't declare.
995 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
996 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
997 Use g_source_cache.
998
872dceaa
TT
9992019-08-06 Tom Tromey <tromey@adacore.com>
1000
1001 * source-cache.c (source_cache::get_plain_source_lines):
1002 Remove "first_line" and "last_line" parameters.
1003 (source_cache::get_source_lines): Cache plain text.
1004 * source-cache.h (class source_cache)
1005 <get_plain_source_lines>: Update.
1006
269249d9
TT
10072019-08-06 Tom Tromey <tromey@adacore.com>
1008
1009 * source-cache.c (extract_lines): No longer a method.
1010 Changed type of parameter. Include final newline.
1011 (selftests::extract_lines_test): New function.
1012 (_initialize_source_cache): Likewise.
1013 * source-cache.h (class source_cache)
1014 <extract_lines>: Don't declare.
1015
c0e8dcd8
TT
10162019-08-06 Tom Tromey <tromey@adacore.com>
1017
1018 * breakpoint.c (init_breakpoint_sal): Update.
1019 (breakpoint): Update.
1020 * breakpoint.h (struct breakpoint) <filter>: Now a
1021 unique_xmalloc_ptr.
1022
0b27c27d
CB
10232019-08-05 Christian Biesinger <cbiesinger@google.com>
1024
1025 * NEWS: Mention dictionary access on blocks.
1026 * python/py-block.c (blpy_getitem): New function.
1027 (block_object_as_mapping): New struct.
1028 (block_object_type): Use new struct for tp_as_mapping field.
1029
4ee94178
CB
10302019-08-05 Christian Biesinger <cbiesinger@google.com>
1031
1032 * objfiles.h (objfile): Add a comment describing partial symbols.
1033
8abfcabc
TT
10342019-08-05 Tom Tromey <tromey@adacore.com>
1035
1036 * compile/compile.c (_initialize_compile): Use _(), not N_().
1037 * thread.c (_initialize_thread): Use _(), not N_().
1038 * stack.c (_initialize_stack): Use _(), not N_().
1039 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1040
2b79f376
SM
10412019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1042
1043 * dwarf2read.c (struct dw2_symtab_iterator):
1044 <want_specific_block>: Remove.
1045 <block_index>: Change type to gdb::optional.
1046 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1047 change type of BLOCK_INDEX parameter to gdb::optional.
1048 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1049 (dw2_lookup_symbol): Don't pass argument for
1050 WANT_SPECIFIC_BLOCK.
1051 (dw2_expand_symtabs_for_function): Don't pass argument for
1052 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1053 (class dw2_debug_names_iterator)
1054 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1055 parameter, change BLOCK_INDEX type to gdb::optional.
1056 <m_want_specific_block>: Remove.
1057 <m_block_index>: Change type to gdb::optional.
1058 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1059 gdb::optional. Re-write in function of gdb::optional.
1060 (dw2_debug_names_lookup_symbol): Don't pass argument for
1061 WANT_SPECIFIC_BLOCK.
1062 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1063 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1064 BLOCK_INDEX.
1065
ae60f04e
PW
10662019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1067
1068 * NEWS: Mention changes to "info sources" command.
1069
28cd9371
PW
10702019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1071
1072 * symtab.c (filename_partial_match_opts): New struct type.
1073 (struct output_source_filename_data): New members
1074 regexp, c_regexp, partial_match.
1075 (output_source_filename): Use new members to decide to print file.
1076 (info_sources_option_defs): New variable.
1077 (make_info_sources_options_def_group, print_info_sources_header,
1078 info_sources_command_completer):
1079 New functions.
1080 (info_sources_command): Read new optional arguments.
1081 (_initialize_symtab): Update info sources help.
1082
ca683e3a
AO
10832019-08-02 Alexandre Oliva <oliva@adacore.com>
1084
1085 * ada-lang.c (exception_support_info_v0): Renamed from...
1086 (default_exception_support_info): ... this. Create new
1087 definition for v1.
1088 (ada_has_this_exception_support): Look up catch_handlers_sym.
1089 (ada_exception_support_info_sniffer): Try v0 after default.
1090
f1264162
TT
10912019-08-01 Tom Tromey <tromey@adacore.com>
1092
1093 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1094 gdbarch.h.
1095
0a7b2485
CB
10962019-08-01 Christian Biesinger <cbiesinger@google.com>
1097
1098 * s12z-tdep.c: Fix include path for s12z-opc.h.
1099
c6bdbeb7
AH
11002019-08-01 Alan Hayward <alan.hayward@arm.com>
1101
1102 * NEWS: Require GNU make 3.82.
1103
a2bd7b82
TT
11042019-07-16 Tom Tromey <tom@tromey.com>
1105
1106 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1107 declare.
1108
aa3b6533
TT
11092019-07-30 Tom Tromey <tromey@adacore.com>
1110
1111 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1112
a1530dc7
KB
11132019-07-30 Kevin Buettner <kevinb@redhat.com>
1114
1115 * printcmd.c (print_address_symbolic): Print negative offsets.
1116 (build_address_symbolic): Force signed arithmetic when computing
1117 offset.
1118
2906593f
CB
11192019-07-30 Christian Biesinger <cbiesinger@google.com>
1120
1121 PR/24474: Add a function to lookup static variables.
1122 * NEWS: Mention this new function.
1123 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1124 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1125 * python/python.c (python_GdbMethods): Add new function.
1126
c620ed88
CB
11272019-07-29 Christian Biesinger <cbiesinger@google.com>
1128
1129 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1130 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1131 (objfpy_lookup_static_symbol): New function.
1132 (objfile_object_methods): Add new functions.
1133
bc4268a5
PW
11342019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1135
1136 * NEWS: Mention 'set|show print frame-info'. Mention new
1137 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1138 backtrace argument. Mention that python frame filtering code
1139 is now consistent with what 'backtrace' command prints.
1140
4b5e8d19
PW
11412019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1142
1143 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1144 comments.
1145 (print_frame_info_auto, print_frame_info_source_line,
1146 print_frame_info_location, print_frame_info_source_and_location,
1147 print_frame_info_location_and_address, print_frame_info_short_location):
1148 New declarations.
1149 (struct frame_print_options): New member print_frame_info.
1150 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1151 * stack.h (get_user_print_what_frame_info): New declaration.
1152 (frame_show_address): New declaration.
1153 * stack.c (print_frame_arguments_choices): New value 'presence'.
1154 (print_frame_info_auto, print_frame_info_source_line,
1155 print_frame_info_location, print_frame_info_source_and_location,
1156 print_frame_info_location_and_address, print_frame_info_short_location,
1157 print_frame_info_choices, print_frame_info_print_what): New definitions.
1158 (print_frame_args): Only print dots for args if print frame-arguments
1159 is 'presence'.
1160 (frame_print_option_defs): New element for "frame-info".
1161 (get_user_print_what_frame_info): New function.
1162 (frame_show_address): Make non static. Move comment to stack.h.
1163 (print_frame_info_to_print_what): New function.
1164 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1165 to decide what to print.
1166 (backtrace_command_1): Handle the new print_frame_arguments_presence
1167 value.
1168 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1169 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1170 (py_print_frame): In non-mi mode, use LOCATION as default for
1171 print_what, similarly to frame information printed directly by
1172 backtrace command. Handle frame-info user option in non MI mode.
1173
6bdfee81
KB
11742019-07-27 Kevin Buettner <kevinb@redhat.com>
1175
1176 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1177 Add case for debugging 32-bit target on 64-bit host. Revise
1178 comment.
1179
98a617f8
KB
11802019-07-27 Kevin Buettner <kevinb@redhat.com>
1181
1182 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1183 instead of find_function_entry_range_from_pc.
1184
567238c9
KB
11852019-07-27 Kevin Buettner <kevinb@redhat.com>
1186
1187 * stack.c (find_frame_funname): Remove code which preferred
1188 minsym over symtab sym in "certain pathological cases".
1189
2dc80cf8
KB
1190 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1191 parameter. Change type of "do_demangle" to bool.
1192 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1193 Pass suitable "prefer_sym_over_minsym" flag to
1194 build_address_symbolic(). Don't output "+" for negative offsets.
1195 * printcmd.c (print_address_symbolic): Update invocation of
1196 build_address_symbolic to include a "prefer_sym_over_minsym"
1197 flag.
1198 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1199 Restrict cases in which use of minimal symbol is preferred to that
1200 of a found symbol. Update comments.
1201
1aff7173
KB
1202 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1203 for entry pc when entry pc is out of range for that FDE.
1204
89b085ac
BC
12052019-07-26 Brian Callahan <bcallah@openbsd.org>
1206
1207 PR gdb/24839:
1208 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1209 type.
1210
f32feb4a
CB
12112019-07-25 Christian Biesinger <cbiesinger@google.com>
1212
1213 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1214 this function's Python signature.
1215
1216
12172019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
1218
1219 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1220 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1221 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1222 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1223 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1224
1225
c54e4253
YS
12262019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1227
1228 * h8300-tdep.c (h8300_register_name_common): New.
1229 h8300_register_name): Use h8300_register_name_common.
1230 (h8300s_register_name): Likewise.
1231 (h8300sx_register_name): Likewise.
1232 (h8300h_register_nam): New.
1233 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1234
1235
40eadf04
SP
12362019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1237
1238 * arm-tdep.c (arm_skip_cmse_entry): New function.
1239 (arm_is_sgstubs_section): New function.
1240 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1241
bfa2a36d
TT
12422019-07-22 Tom Tromey <tom@tromey.com>
1243
1244 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1245 Don't self-assign.
1246
a8e9d247
AB
12472019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1248
1249 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1250 type_print.
1251
eb86c5e2
AB
12522019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1253
1254 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1255 so that GDB doesn't match any msymbols when searching in the
1256 TYPES_DOMAIN.
1257 (print_symbol_info): Print using typedef_print or type_print based
1258 on the type of the symbol. Add updated FIXME comment moved from...
1259 (_initialize_symtab): ... move and update FIXME comment to above.
1260
a8eab7c6
AB
12612019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1262
1263 * NEWS: Mention adding -q option to "info types".
1264 * symtab.c (struct info_types_options): New struct.
1265 (info_types_options_defs): New variable.
1266 (make_info_types_options_def_group): New function.
1267 (info_types_command): Use gdb::option framework to parse options.
1268 (info_types_command_completer): New function.
1269 (_initialize_symtab): Extend the help text on "info types" and
1270 register command completer.
1271
b4603c34
CB
12722019-07-21 Christian Biesinger <cbiesinger@google.com>
1273
1274 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1275 (lookup_symbol_in_objfile): Change int to block_enum and add a
1276 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1277
c8cdc1e0
CB
12782019-07-20 Christian Biesinger <cbiesinger@google.com>
1279
1280 * MAINTAINERS (Write After Approval): Add self.
1281
01e175fe
AB
12822019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1283
1284 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1285 instruction to the dummy code region.
1286
56f79b63
TT
12872019-07-19 Tom Tromey <tromey@adacore.com>
1288
1289 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1290 (ARGSUSED, PARAMS, __func__): Remove rules.
1291
4c5aa8e0
AH
12922019-07-19 Alan Hayward <alan.hayward@arm.com>
1293
1294 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1295 * features/arm/arm-with-iwmmxt.c: Remove.
1296 * features/arm/arm-with-iwmmxt.xml: Remove.
1297 * features/arm/arm-with-m-fpa-layout.c: Remove.
1298 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1299 * features/arm/arm-with-m-vfp-d16.c: Remove.
1300 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1301 * features/arm/arm-with-m.c: Remove.
1302 * features/arm/arm-with-m.xml: Remove.
1303 * features/arm/arm-with-neon.c: Remove.
1304 * features/arm/arm-with-neon.xml: Remove.
1305 * features/arm/arm-with-vfpv2.c: Remove.
1306 * features/arm/arm-with-vfpv2.xml: Remove.
1307 * features/arm/arm-with-vfpv3.c: Remove.
1308 * features/arm/arm-with-vfpv3.xml: Remove.
1309
f42b2617
AH
13102019-07-19 Alan Hayward <alan.hayward@arm.com>
1311
1312 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1313
f29ec966
AH
13142019-07-19 Alan Hayward <alan.hayward@arm.com>
1315
1316 * arch/aarch32.c (aarch32_create_target_description): Create
1317 target descriptions using features.
1318 * arch/arm.c (arm_create_target_description)
1319 (arm_create_mprofile_target_description): Likewise.
1320 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1321
d105cce5
AH
13222019-07-19 Alan Hayward <alan.hayward@arm.com>
1323
1324 * Makefile.in: Add new files.
1325 * aarch32-tdep.c: New file.
1326 * aarch32-tdep.h: New file.
1327 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1328 Call aarch32_read_description.
1329 * arch/aarch32.c: New file.
1330 * arch/aarch32.h: New file.
1331 * arch/arm.c (arm_create_target_description)
1332 (arm_create_mprofile_target_description): New function.
1333 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1334 (arm_create_target_description)
1335 (arm_create_mprofile_target_description): New declaration.
1336 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1337 read_description functions.
1338 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1339 Likewise.
1340 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1341 * arm-tdep.c (tdesc_arm_list): New variable.
1342 (arm_register_g_packet_guesses): Call create description functions.
1343 (arm_read_description) (arm_read_mprofile_description): New
1344 function.
1345 * arm-tdep.h (arm_read_description)
1346 (arm_read_mprofile_description): Add declaration.
1347 * configure.tgt: Add new files.
1348
afe09f0b
GL
13492019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1350
1351 * top.c (new_ui_command): Open specified terminal just once.
1352
cd215b2e
TT
13532019-07-18 Tom Tromey <tromey@adacore.com>
1354
1355 * symtab.c (main_name): Constify return type.
1356 * symfile.c (set_initial_language): Update.
1357 * symtab.h (main_name): Constify return type.
1358
d8f68fcb
TT
13592019-07-17 Tom Tromey <tom@tromey.com>
1360
1361 * tui/tui-winsource.c (tui_update_source_window)
1362 (tui_update_source_window_as_is)
1363 (tui_update_source_windows_with_line): Remove return.
1364 * tui/tui-disasm.c (tui_show_disassem)
1365 (tui_show_disassem_and_update_source): Remove return.
1366 * tui/tui.c (tui_reset): Remove return.
1367 * tui/tui-wingeneral.c
1368 (tui_check_and_display_highlight_if_needed): Remove return.
1369
ca5af91e
TT
13702019-07-17 Tom Tromey <tom@tromey.com>
1371
1372 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1373
5104fe36
TT
13742019-07-17 Tom Tromey <tom@tromey.com>
1375
1376 * tui/tui-winsource.h (struct tui_exec_info_window)
1377 (struct tui_source_window_base): Move from tui-data.h.
1378 * tui/tui-winsource.c: Move many method definitions from
1379 elsewhere. Remove "structuring" comments.
1380 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1381 (tui_source_window_base::refresh_window): Move to
1382 tui-winsource.c.
1383 * tui/tui-win.c (tui_source_window_base::refresh_all)
1384 (tui_source_window_base::update_tab_width)
1385 (tui_source_window_base::set_new_height)
1386 (tui_source_window_base::do_make_visible_with_new_height): Move to
1387 tui-winsource.c.
1388 * tui/tui-source.h: Update.
1389 * tui/tui-source.c (tui_source_window_base::reset): Move to
1390 tui-winsource.c.
1391 * tui/tui-disasm.h: Update.
1392 * tui/tui-data.h (struct tui_exec_info_window): Move to
1393 tui-winsource.h.
1394 (struct tui_source_window_base): Likewise.
1395 * tui/tui-data.c (tui_source_window_base::clear_detail)
1396 (tui_source_window_base, ~tui_source_window_base): Move to
1397 tui-winsource.c.
1398
daa15dde
TT
13992019-07-17 Tom Tromey <tom@tromey.com>
1400
1401 * tui/tui-win.c (tui_resize_all)
1402 (tui_source_window_base::update_tab_width)
1403 (tui_adjust_win_heights): Update.
1404 (tui_win_info::make_invisible_and_set_new_height): Rename from
1405 make_invisible_and_set_new_height.
1406 * tui/tui-data.h (struct tui_win_info)
1407 <make_invisible_and_set_new_height>: New method.
1408
bfad4537
TT
14092019-07-17 Tom Tromey <tom@tromey.com>
1410
1411 * tui/tui.c: Update.
1412 * tui/tui-source.h (struct tui_source_window): Move from
1413 tui-data.h.
1414 * tui/tui-layout.c: Update.
1415 * tui/tui-disasm.c: Update.
1416 * tui/tui-data.h (struct tui_source_window): Move to
1417 tui-source.h.
1418
88f7e873
TT
14192019-07-17 Tom Tromey <tom@tromey.com>
1420
1421 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1422 tui-data.h.
1423 * tui/tui-data.h (struct tui_disasm_window): Move to
1424 tui-disasm.h.
1425
96bd6233
TT
14262019-07-17 Tom Tromey <tom@tromey.com>
1427
1428 * tui/tui-regs.h (struct tui_data_item_window): Move from
1429 tui-data.h.
1430 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1431 * tui/tui-data.h (struct tui_data_item_window): Move to
1432 tui-regs.h.
1433 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1434
ce38393b
TT
14352019-07-17 Tom Tromey <tom@tromey.com>
1436
1437 * tui/tui.c: Update.
1438 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1439 (tui_cmd_window::max_height): Move to tui-command.c.
1440 * tui/tui-layout.c: Update.
1441 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1442 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1443 tui-command.c.
1444 * tui/tui-command.h (struct tui_cmd_window): Move from
1445 tui-data.h.
1446 * tui/tui-command.c: Remove "structuring" comments.
1447 (tui_cmd_window::clear_detail)
1448 (tui_cmd_window::do_make_visible_with_new_height)
1449 (tui_cmd_window::max_height): Move from elsewhere.
1450
2d8b51cb
TT
14512019-07-17 Tom Tromey <tom@tromey.com>
1452
1453 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1454 Now static.
1455 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1456 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1457
18ab23af
TT
14582019-07-17 Tom Tromey <tom@tromey.com>
1459
1460 * tui/tui.c: Update.
1461 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1462 tui-regs.c.
1463 * tui/tui-windata.h: Remove file.
1464 * tui/tui-windata.c: Remove file.
1465 * tui/tui-win.c (tui_data_window::set_new_height)
1466 (tui_data_window::do_make_visible_with_new_height): Move to
1467 tui-regs.c.
1468 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1469 * tui/tui-regs.c: Remove "structuring" comments.
1470 (tui_data_window::first_data_item_displayed)
1471 (tui_data_window::delete_data_content_windows)
1472 (tui_data_window::erase_data_content)
1473 (tui_data_window::display_all_data)
1474 (tui_data_window::refresh_all)
1475 (tui_data_window::do_scroll_vertical)
1476 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1477 (tui_data_window::do_make_visible_with_new_height)
1478 (tui_data_window::refresh_window): Move from elsewhere.
1479 (_initialize_tui_regs): Move to end of file.
1480 * tui/tui-layout.c: Update.
1481 * tui/tui-hooks.c: Update.
1482 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1483 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1484 tui-regs.c.
1485 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1486
88b7e7cc
TT
14872019-07-17 Tom Tromey <tom@tromey.com>
1488
1489 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1490 seen.
1491
0fcd3711
TT
14922019-07-17 Tom Tromey <tom@tromey.com>
1493
1494 * tui/tui-win.c (tui_source_window_base::set_new_height)
1495 (tui_source_window_base::do_make_visible_with_new_height): Use
1496 m_has_locator field directly.
1497 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1498 method.
1499 (struct tui_source_window_base) <has_locator>: Likewise.
1500
4a38112d
TT
15012019-07-17 Tom Tromey <tom@tromey.com>
1502
1503 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1504 Don't declare.
1505 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1506 Remove.
1507 * tui/tui-win.c (tui_source_window_base::set_new_height)
1508 (tui_source_window_base::set_new_height)
1509 (make_invisible_and_set_new_height)
1510 (tui_source_window_base::do_make_visible_with_new_height)
1511 (tui_source_window_base::do_make_visible_with_new_height):
1512 Update.
1513 * tui/tui-layout.c (show_source_disasm_command, show_data)
1514 (show_source_or_disasm_and_command): Update.
1515 * tui/tui-layout.c (show_layout): Update.
1516
09129226
TT
15172019-07-17 Tom Tromey <tom@tromey.com>
1518
1519 * tui/tui-layout.c (make_data_window): Remove.
1520 (show_data): Unify creation and re-initialization cases.
1521
4a8a5e84
TT
15222019-07-17 Tom Tromey <tom@tromey.com>
1523
1524 * tui/tui-layout.c (make_source_window, make_disasm_window):
1525 Remove.
1526 (show_data): Unify creation and re-initialization cases.
1527
76d2be8e
TT
15282019-07-17 Tom Tromey <tom@tromey.com>
1529
1530 * tui/tui-layout.c (make_command_window): Remove.
1531 (show_source_disasm_command, show_source_or_disasm_and_command):
1532 Unify creation and re-initialization cases.
1533
890b8bde
TT
15342019-07-17 Tom Tromey <tom@tromey.com>
1535
1536 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1537 creation and re-initialization cases.
1538
2cdfa113
TT
15392019-07-17 Tom Tromey <tom@tromey.com>
1540
1541 * tui/tui-regs.c (tui_get_register): Return void.
1542
8e3cfd09
TT
15432019-07-17 Tom Tromey <tom@tromey.com>
1544
1545 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1546 Simplify.
1547
f4e04977
TT
15482019-07-17 Tom Tromey <tom@tromey.com>
1549
1550 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1551 resetting.
1552
0379b883
TT
15532019-07-17 Tom Tromey <tom@tromey.com>
1554
1555 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1556 * tui/tui-regs.c (tui_reg_layout): New function.
1557 (tui_show_registers, tui_reg_command): Use it.
1558 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1559 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1560 parameters.
1561 (tui_layout_command): Remove.
1562
b7fbad91
TT
15632019-07-17 Tom Tromey <tom@tromey.com>
1564
1565 * tui/tui-layout.h (tui/tui-layout): Return void.
1566 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1567
4e1e56b9
TT
15682019-07-17 Tom Tromey <tom@tromey.com>
1569
1570 * tui/tui-layout.c (show_source_disasm_command, show_data):
1571 Update.
1572 (reset_locator): Remove.
1573 (show_source_or_disasm_and_command): Update.
1574
1e0c09ba
TT
15752019-07-17 Tom Tromey <tom@tromey.com>
1576
1577 * tui/tui-source.c (tui_source_window_base::reset): Remove
1578 win_type parameter.
1579 * tui/tui-layout.c (make_command_window, make_source_window)
1580 (make_disasm_window, make_data_window)
1581 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1582 (reset_locator, show_source_or_disasm_and_command): Update.
1583 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1584 win_type parameter.
1585 (struct tui_source_window_base) <reset>: Likewise.
1586
1bf605de
TT
15872019-07-17 Tom Tromey <tom@tromey.com>
1588
1589 * tui/tui-layout.c (show_source_disasm_command): Use
1590 reset_locator.
1591 (reset_locator): New function.
1592 (init_and_make_win): Remove.
1593 (show_source_or_disasm_and_command): Use reset_locator.
1594
098f9ed4
TT
15952019-07-17 Tom Tromey <tom@tromey.com>
1596
1597 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1598 condition.
1599 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1600 Remove condition.
1601 * tui/tui-source.c (tui_source_window_base::reset): New method.
1602 * tui/tui-layout.c (make_command_window): Don't call
1603 init_and_make_win.
1604 (make_source_window, make_disasm_window): Don't call
1605 make_source_or_disasm_window.
1606 (make_data_window): Don't call init_and_make_win. Change calling
1607 convention.
1608 (show_source_disasm_command, show_data): Simplify.
1609 (make_source_or_disasm_window): Remove.
1610 (show_source_or_disasm_and_command): Simplify.
1611 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1612 (struct tui_source_window_base) <reset>: Likewise.
1613 <execution_info>: Remove initializer.
1614 * tui/tui-data.c (tui_source_window_base): Initialize
1615 execution_info.
1616
80110957
TT
16172019-07-17 Tom Tromey <tom@tromey.com>
1618
1619 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1620 variable.
1621
cf82af05
TT
16222019-07-17 Tom Tromey <tom@tromey.com>
1623
1624 * tui/tui.c (tui_rl_other_window): Update.
1625 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1626 superclass method first. Always iterate over regs_content.
1627 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1628 method.
1629 * tui/tui-win.c (tui_set_focus_command): Update.
1630
01aeb396
TT
16312019-07-17 Tom Tromey <tom@tromey.com>
1632
1633 * tui/tui-win.c (tui_set_focus_command): Rename from
1634 tui_set_focus. Call tui_enable.
1635 (tui_set_focus_command): Remove.
1636
fd6c75ee
TT
16372019-07-17 Tom Tromey <tom@tromey.com>
1638
1639 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1640 refresh_window.
1641 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1642 touchwin.
1643 (tui_data_window::refresh_window): Call refresh_window on data
1644 items. Always call superclass refresh_window.
1645 (tui_win_info::refresh): Remove.
1646 (tui_source_window_base::refresh_window): Update.
1647 (tui_refresh_all): Update.
1648 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1649 refresh_window.
1650 (show_source_or_disasm_and_command): Likewise.
1651 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1652 (struct tui_source_window_base) <refresh>: Likewise.
1653
f6cc34a9
TT
16542019-07-17 Tom Tromey <tom@tromey.com>
1655
1656 * tui/tui-winsource.c (tui_clear_source_content)
1657 (tui_show_source_content): Update.
1658 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1659 whether content is empty.
1660 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1661 Remove.
1662
f31ec9af
TT
16632019-07-17 Tom Tromey <tom@tromey.com>
1664
1665 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1666 window's contents.
1667 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1668 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1669
d1b6f1e5
TT
16702019-07-17 Tom Tromey <tom@tromey.com>
1671
1672 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1673 (struct tui_data_item_window): Update.
1674
d9743a13
TT
16752019-07-17 Tom Tromey <tom@tromey.com>
1676
1677 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1678 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1679 defines.
1680
caf0bc4e
TT
16812019-07-17 Tom Tromey <tom@tromey.com>
1682
1683 * tui/tui-winsource.h (tui_erase_source_content)
1684 (tui_clear_source_content): Remove "display_prompt" parameter.
1685 * tui/tui-winsource.c (tui_update_source_window_as_is)
1686 (tui_update_source_windows_with_addr): Update.
1687 (tui_clear_source_content): Remove "display_prompt" parameter.
1688 (tui_erase_source_content): Likewise. Simplify.
1689 (tui_show_source_content): Update.
1690 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1691 * tui/tui-stack.c (tui_show_frame_info): Update.
1692 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1693 Remove defines.
1694
9d391078
TT
16952019-07-17 Tom Tromey <tom@tromey.com>
1696
1697 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1698 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1699 parameter.
1700 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1701 parameter.
1702
a38da35d
TT
17032019-07-17 Tom Tromey <tom@tromey.com>
1704
1705 * tui/tui-winsource.c (tui_clear_source_content)
1706 (tui_show_source_content, tui_show_exec_info_content)
1707 (tui_clear_exec_info_content): Update.
1708 * tui/tui-stack.c (tui_show_locator_content): Update.
1709 (tui_show_frame_info): Update.
1710 * tui/tui-source.h (tui_source_window): Don't declare.
1711 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1712 from tui_source_is_displayed.
1713 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1714 Remove field.
1715 (struct tui_source_window_base) <content_in_use>: New field. Now
1716 bool.
1717 (struct tui_source_window) <showing_source_p>: New method.
1718 (TUI_SRC_WIN): Change cast.
1719 * tui/tui-data.c (tui_initialize_static_data): Update.
1720
c2cd8994
TT
17212019-07-17 Tom Tromey <tom@tromey.com>
1722
1723 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1724 location_matches_p.
1725 * tui/tui-source.c (tui_source_window::location_matches_p): New
1726 method.
1727 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1728 method.
1729 * tui/tui-data.h (struct tui_source_window_base)
1730 <location_matches_p>: New method.
1731 (struct tui_source_window, struct tui_disasm_window)
1732 <location_matches_p>: Likewise.
1733
4dde7b34
TT
17342019-07-17 Tom Tromey <tom@tromey.com>
1735
1736 * tui/tui-win.c (tui_set_win_height_command): Rename from
1737 tui_set_win_height.
1738 (tui_set_win_height_command): Remove.
1739
b73dd877
TT
17402019-07-17 Tom Tromey <tom@tromey.com>
1741
1742 * tui/tui-source.c (tui_source_window): New constructor. Add
1743 observer.
1744 (~tui_source_window): New destructor.
1745 (tui_source_window::style_changed): New method.
1746 * tui/tui-hooks.c (tui_redisplay_source): Remove.
1747 (tui_attach_detach_observers): Update.
1748 * tui/tui-data.h (struct tui_source_window): Make constructor not
1749 inline. Add destructor.
1750 (struct tui_source_window) <style_changed>: New method.
1751 <m_observable>: New member.
1752
ae2b5380
TT
17532019-07-17 Tom Tromey <tom@tromey.com>
1754
1755 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1756 * tui/tui-win.c (tui_resize_all): Fix typo.
1757
1ce3e844
TT
17582019-07-17 Tom Tromey <tom@tromey.com>
1759
1760 * tui/tui-wingeneral.h (tui_refresh_all): Update.
1761 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1762 (tui_refresh_all): Remove "list" parameter. Use foreach.
1763 * tui/tui-win.c (window_name_completer): Use foreach.
1764 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1765 (update_tab_width): Likewise.
1766 * tui/tui-layout.c (show_layout): Update.
1767 * tui/tui-data.h (class tui_window_iterator): New.
1768 (struct all_tui_windows): New.
1769 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1770
fe3eaf1c
TT
17712019-07-17 Tom Tromey <tom@tromey.com>
1772
1773 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1774 parameter. Don't reference globals.
1775 (tui_reg_command): Update.
1776
368c1354
TT
17772019-07-17 Tom Tromey <tom@tromey.com>
1778
1779 * tui/tui-regs.c (tui_show_registers): Simplify.
1780
e80cd204
TT
17812019-07-17 Tom Tromey <tom@tromey.com>
1782
1783 * tui/tui-regs.c (tui_show_registers): Update.
1784 (tui_show_register_group): Add win_info parameter.
1785
aca2dd16
TT
17862019-07-17 Tom Tromey <tom@tromey.com>
1787
1788 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1789 Rename from tui_display_reg_element_at_line.
1790 (tui_data_window::display_registers_from_line): Update.
1791 * tui/tui-data.h (struct tui_data_window)
1792 <display_reg_element_at_line>: New method.
1793
517e9505
TT
17942019-07-17 Tom Tromey <tom@tromey.com>
1795
1796 * tui/tui-regs.h (tui_display_registers_from)
1797 (tui_display_registers_from_line): Don't declare.
1798 * tui/tui-windata.c (tui_data_window::display_all_data)
1799 (tui_data_window::refresh_all)
1800 (tui_data_window::do_scroll_vertical): Update.
1801 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1802 from tui_display_registers_from.
1803 (tui_display_reg_element_at_line): Update.
1804 (tui_data_window::display_registers_from_line): Rename from
1805 tui_display_registers_from_line.
1806 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1807 display_registers_from_line>: New methods.
1808
f76d8b19
TT
18092019-07-17 Tom Tromey <tom@tromey.com>
1810
1811 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1812 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1813 from tui_erase_data_content.
1814 (tui_data_window::display_all_data)
1815 (tui_data_window::refresh_all)
1816 (tui_data_window::do_scroll_vertical): Update.
1817 * tui/tui-regs.c (tui_show_registers): Update.
1818 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1819 New method.
1820
b4094625
TT
18212019-07-17 Tom Tromey <tom@tromey.com>
1822
1823 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1824 declare.
1825 * tui/tui-windata.c
1826 (tui_data_window::delete_data_content_windows): Rename from
1827 tui_delete_data_content_windows.
1828 (tui_data_window::display_all_data)
1829 (tui_data_window::do_scroll_vertical): Update.
1830 * tui/tui-data.h (struct tui_data_window)
1831 <delete_data_content_windows>: New method.
1832
c223a729
TT
18332019-07-17 Tom Tromey <tom@tromey.com>
1834
1835 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1836 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1837
50daf268
TT
18382019-07-17 Tom Tromey <tom@tromey.com>
1839
1840 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1841 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1842 from tui_display_all_data.
1843 * tui/tui-win.c
1844 (tui_data_window::do_make_visible_with_new_height): Update.
1845 * tui/tui-regs.c (tui_show_registers): Update.
1846 * tui/tui-layout.c (tui_set_layout): Update.
1847 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1848 method.
1849
df5f8cab
TT
18502019-07-17 Tom Tromey <tom@tromey.com>
1851
1852 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1853 * tui/tui-windata.c (tui_display_data_from): Remove.
1854 (tui_data_window::refresh_all): Update.
1855
80cb6c27
TT
18562019-07-17 Tom Tromey <tom@tromey.com>
1857
1858 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1859 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1860 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1861 tui_display_registers_from_line.
1862 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1863 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1864 "force_display" parameter.
1865
baff0c28
TT
18662019-07-17 Tom Tromey <tom@tromey.com>
1867
1868 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1869 declare.
1870 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1871 Rename from tui_first_reg_element_no_inline.
1872 (tui_display_reg_element_at_line)
1873 (tui_display_registers_from_line): Update.
1874 * tui/tui-data.h (struct tui_data_window)
1875 <first_reg_element_no_inline>: New method.
1876
3b23c5f2
TT
18772019-07-17 Tom Tromey <tom@tromey.com>
1878
1879 * tui/tui-windata.c (tui_display_data_from)
1880 (tui_data_window::do_scroll_vertical): Update.
1881 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1882 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1883 Rename from tui_line_from_reg_element_no.
1884 (tui_display_registers_from_line): Update.
1885 * tui/tui-data.h (struct tui_data_window)
1886 <line_from_reg_element_no>: New method.
1887
0b5ec218
TT
18882019-07-17 Tom Tromey <tom@tromey.com>
1889
1890 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1891 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1892 tui_last_regs_line_no.
1893 (tui_display_reg_element_at_line)
1894 (tui_display_registers_from_line): Update.
1895 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1896 method.
1897
0807ab7b
TT
18982019-07-17 Tom Tromey <tom@tromey.com>
1899
1900 PR tui/24722:
1901 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1902 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1903 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1904 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1905 (tui_update_breakpoint_info): Likewise.
1906 * tui/tui-hooks.c (tui_event_create_breakpoint)
1907 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1908 Update.
1909
9ad7fdef
TT
19102019-07-17 Tom Tromey <tom@tromey.com>
1911
1912 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1913
5813316f
TT
19142019-07-17 Tom Tromey <tom@tromey.com>
1915
1916 * tui/tui-winsource.c (tui_update_source_window_as_is)
1917 (tui_update_source_windows_with_addr): Update.
1918 * tui/tui-source.h (tui_set_source_content)
1919 (tui_show_symtab_source): Add "win_info" parameter.
1920 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1921 parameter.
1922 (tui_show_symtab_source): Likewise.
1923
00e264e7
TT
19242019-07-17 Tom Tromey <tom@tromey.com>
1925
1926 * tui/tui-wingeneral.c
1927 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1928
06210ce4
TT
19292019-07-17 Tom Tromey <tom@tromey.com>
1930
1931 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1932 (struct tui_cmd_window) <can_scroll>: New method.
1933 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1934 method.
1935
381befee
TT
19362019-07-17 Tom Tromey <tromey@adacore.com>
1937
1938 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1939 do_field_signed>: Rename. Change type of "value".
1940 * ui-out.c (ui_out::field_signed): Rename from field_int.
1941 Change type of "value".
1942 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1943 type of "value".
1944 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1945 do_field_int. Change type of "value".
1946 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1947 do_field_int. Change type of "value".
1948 * tracepoint.c (trace_status_mi, tfind_1)
1949 (print_one_static_tracepoint_marker): Update.
1950 * thread.c (print_thread_info_1, print_selected_thread_frame):
1951 Update.
1952 * stack.c (print_frame, print_frame_info): Update.
1953 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1954 Update.
1955 * source.c (print_source_lines_base): Update.
1956 * skip.c (info_skip_command): Update.
1957 * record-btrace.c (btrace_ui_out_decode_error)
1958 (btrace_call_history_src_line): Update.
1959 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1960 Update.
1961 * progspace.c (print_program_space): Update.
1962 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1963 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1964 do_field_int. Change type of "value".
1965 * mi/mi-out.c (mi_ui_out::do_table_begin)
1966 (mi_ui_out::do_table_header): Update.
1967 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1968 type of "value".
1969 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1970 (mi_cmd_data_list_changed_registers, output_register)
1971 (mi_cmd_data_read_memory, mi_load_progress)
1972 (mi_cmd_trace_frame_collected): Update.
1973 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1974 Update.
1975 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1976 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1977 (mi_cmd_var_list_children, varobj_update_one): Update.
1978 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1979 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1980 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1981 * inferior.c (print_inferior): Update.
1982 * gdb_bfd.c (print_one_bfd): Update.
1983 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1984 Update.
1985 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1986 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1987 do_field_int. Change type of "value".
1988 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1989 do_field_int. Change type of "value".
1990 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1991 (print_one_breakpoint_location, print_it_catch_fork)
1992 (print_one_catch_fork, print_it_catch_vfork)
1993 (print_one_catch_vfork, print_it_catch_solib)
1994 (print_it_catch_exec, print_it_ranged_breakpoint)
1995 (print_mention_watchpoint, print_mention_masked_watchpoint)
1996 (bkpt_print_it, update_static_tracepoint): Update.
1997 * break-catch-throw.c (print_it_exception_catchpoint): Update.
1998 * break-catch-syscall.c (print_it_catch_syscall): Update.
1999 * ada-tasks.c (print_ada_task_info): Update.
2000 * ada-lang.c (print_it_exception, print_mention_exception):
2001 Update.
2002
6b78c3f8
AB
20032019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2004
2005 PR breakpoints/24541
2006 * gdbarch.c: Regenerate.
2007 * gdbarch.h: Regenerate.
2008 * gdbarch.sh: Adjust return type and parameter types for
2009 'stap_adjust_register'.
2010 (i386_stap_adjust_register): Adjust signature and return new
2011 register name.
2012 * stap-probe.c (stap_parse_register_operand): Adjust use of
2013 'gdbarch_stap_adjust_register'.
2014
d72a9b85
TT
20152019-07-17 Tom Tromey <tromey@adacore.com>
2016
2017 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2018 declare VEC.
2019 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2020 std::vector.
2021 (struct s390_process_info): Add initializers.
2022 (s390_add_process): Use new.
2023 (s390_linux_nat_target::low_forget_process): Use delete.
2024 (s390_linux_nat_target::low_new_fork)
2025 (s390_linux_nat_target::stopped_by_watchpoint)
2026 (s390_linux_nat_target::low_prepare_to_resume)
2027 (s390_linux_nat_target::insert_watchpoint)
2028 (s390_linux_nat_target::insert_hw_breakpoint)
2029 (s390_linux_nat_target::remove_watchpoint)
2030 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2031
206e6c58
JB
20322019-07-16 John Baldwin <jhb@FreeBSD.org>
2033
2034 * aarch64-fbsd-nat.c: Include regcache.h.
2035 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2036 argument.
2037 (aarch64_fbsd_nat_target::fetch_registers)
2038 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2039 variable.
2040 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2041
cbde90f2
JB
20422019-07-16 John Baldwin <jhb@FreeBSD.org>
2043
2044 * fbsd-nat.c: Include gdbarch.h.
2045
07128006
TT
20462019-07-15 Tom Tromey <tromey@adacore.com>
2047
2048 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2049
1f77b012
TT
20502019-07-15 Tom Tromey <tromey@adacore.com>
2051
2052 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2053 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2054 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2055 * cli-out.c (cli_ui_out::do_field_int): New method.
2056 * ui-out.c (ui_out::field_unsigned): New method.
2057 * symfile.c (generic_load): Use field_unsigned.
2058 (print_transfer_performance): Likewise.
2059 * record-btrace.c (ui_out_field_uint): Remove.
2060 (btrace_call_history_insn_range, btrace_call_history): Use
2061 field_unsigned.
2062 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2063 field_unsigned.
2064 * ui-out.h (class ui_out) <field_unsigned>: New method.
2065 <do_field_unsigned>: Likewise.
2066
33eca680
TT
20672019-07-15 Tom Tromey <tromey@adacore.com>
2068
2069 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2070 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2071 * target.c (flash_erase_command): Use field_string.
2072 * infrun.c (print_signal_received_reason): Use field_string.
2073 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2074 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2075 field_string.
2076 * ada-tasks.c (print_ada_task_info): Use field_string.
2077
ca8d69be
TT
20782019-07-15 Tom Tromey <tromey@adacore.com>
2079
2080 * target.c (flash_erase_command): Use field_core_addr.
2081 * symfile.c (generic_load): Use field_core_addr.
2082 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2083 Use field_core_addr.
2084 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2085 field_core_addr.
2086
0d4e84ed
AB
20872019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2088
2089 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2090 value if its desired type is smaller than a CORE_ADDR and signed.
2091
9a49df9d
AB
20922019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2093
2094 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2095 of changes to field names, and use new is_reference field to
2096 decide if a property is a reference or not.
2097 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2098 field.
2099 (struct dwarf2_property_baton): Update header comment, rename
2100 'referenced_type' to 'property_type' and update comments.
2101 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2102 default property type, store in property baton, update to take
2103 accound of renamed field.
2104 (read_func_scope): Update call to attr_to_dynamic_prop.
2105 (read_array_type): Likewise.
2106 (dwarf2_per_cu_addr_sized_int_type): New function.
2107 (read_subrange_index_type): Move type finding code to
2108 dwarf2_per_cu_addr_sized_int_type.
2109 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2110 (dwarf2_per_cu_addr_type): New function.
2111 (set_die_type): Update calls to attr_to_dynamic_prop.
2112
b86352cf
AB
21132019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2114
2115 * dwarf2read.c (read_subrange_index_type): New function.
2116 (read_subrange_type): Move code into new function and call it.
2117 * gdbtypes.c (create_range_type): Add some asserts.
2118
603490bf
AB
21192019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2120
2121 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2122 update return statements.
2123 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2124 declaration, and update comment to match.
2125 * gdbtypes.c (resolve_dynamic_array): Update call to
2126 dwarf2_evaluate_property to match new return type.
2127
592f9d27
AB
21282019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2129
2130 * valarith.c (value_subscripted_rvalue): Change lowerbound
2131 parameter type from int to LONGEST.
2132 * value.h (value_subscripted_rvalue): Likewise in declaration.
2133
60cfcb20
AB
21342019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2135
2136 * cli/cli-utils.c (info_print_command_completer): New function.
2137 * cli/cli-utils.h: Add 'completer.h' include, and forward
2138 declaration for 'struct cmd_list_element'.
2139 (info_print_command_completer): Declare.
2140 * stack.c (_initialize_stack): Add completer for 'info locals' and
2141 'info args'.
2142 * symtab.c (_initialize_symtab): Add completer for 'info
2143 variables' and 'info functions'.
2144 * NEWS: Mention completion for additional info commands.
2145
b16507e0
AB
21462019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2147
2148 * cli/cli-utils.c (extract_info_print_args): Delete.
2149 (extract_arg_maybe_quoted): Delete.
2150 (info_print_options_defs): New variable.
2151 (make_info_print_options_def_group): New function.
2152 (extract_info_print_options): Define new function.
2153 * cli/cli-utils.h (extract_info_print_args): Delete.
2154 (struct info_print_options): New structure.
2155 (extract_info_print_options): Declare new function.
2156 * stack.c (info_locals_command): Update to use new
2157 extract_info_print_options, also add a header comment.
2158 (info_args_command): Likewise.
2159 * symtab.c (info_variables_command): Likewise.
2160 (info_functions_command): Likewise.
2161
021d8588
AB
21622019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2163
2164 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2165 to extract string arguments.
2166 * common/common-utils.c (extract_string_maybe_quoted): New function.
2167 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2168
b777eb6d
TT
21692019-07-11 Tom Tromey <tromey@adacore.com>
2170
2171 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2172 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2173 * top.h (gdbinit): Don't declare.
2174 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2175 into...
2176 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2177 * top.c (gdb_init): Don't call init_cli_cmds.
2178 (gdbinit): Remove.
2179 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2180
72ee03ff
TT
21812019-07-11 Tom Tromey <tromey@adacore.com>
2182
2183 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2184 after it has been moved.
2185
00db9531
SM
21862019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2187
2188 * valops.c (value_must_coerce_to_target): Change return type to
2189 bool.
2190 * value.h (value_must_coerce_to_target): Likewise.
2191
f2478a7e
SM
21922019-07-10 Simon Marchi <simon.marchi@efficios.com>
2193
2194 * breakpoint.c (is_hardware_watchpoint): Remove
2195 forward-declaration.
2196 (is_masked_watchpoint): Change return type to bool.
2197 (is_tracepoint): Likewise.
2198 (is_breakpoint): Likewise.
2199 (is_hardware_watchpoint): Likewise.
2200 (is_watchpoint): Likewise.
2201 (is_no_memory_software_watchpoint): Likewise.
2202 (is_catchpoint): Likewise.
2203 (breakpoint_1): Make FILTER parameter's return type bool.
2204 is_masked_watchpoint): Change return type to bool.
2205 (save_breakpoints): Make FILTER parameter's return type bool.
2206 * breakpoint.h (is_breakpoint): Change return type to bool.
2207 (is_watchpoint): Likewise.
2208 (is_catchpoint): Likewise.
2209 (is_tracepoint): Likewise.
2210
0d12e84c
TT
22112019-07-10 Tom Tromey <tom@tromey.com>
2212
2213 * defs.h: Don't include gdbarch.h.
2214 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2215 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2216 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2217 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2218 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2219 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2220 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2221 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2222 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2223 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2224 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2225 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2226 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2227 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2228 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2229 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2230 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2231 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2232 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2233 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2234 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2235 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2236 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2237 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2238 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2239 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2240 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2241
f06f1252
TT
22422019-07-10 Tom Tromey <tromey@adacore.com>
2243
2244 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2245 * breakpoint.c (init_ada_exception_breakpoint): Register as
2246 bp_catchpoint.
2247 (print_one_breakpoint_location, print_one_breakpoint): Use
2248 is_ada_exception_catchpoint.
2249 * ada-lang.c (class ada_catchpoint_location): Pass
2250 bp_loc_software_breakpoint to bp_location constructor.
2251 (is_ada_exception_catchpoint): New function.
2252
7a5d944b
TT
22532019-07-10 Tom Tromey <tromey@adacore.com>
2254
2255 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2256 VEC.
2257 (struct arm_exidx_entry): New method operator<.
2258 (struct arm_exidx_data) <section_maps>: Change type.
2259 (arm_exidx_data_free): Remove.
2260 (arm_exidx_data_key): Change type. Move lower.
2261 (arm_exidx_new_objfile): Update.
2262 (arm_compare_exidx_entries): Remove.
2263 (arm_find_exidx_entry, _initialize_arm_tdep)
2264
48c66e1d
TT
22652019-07-10 Tom Tromey <tromey@adacore.com>
2266
2267 * solib-spu.c (ocl_program_data_key): Change type.
2268 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2269 Update.
2270
a269fbf1
TT
22712019-07-10 Tom Tromey <tromey@adacore.com>
2272
2273 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2274 (struct solib_aix_inferior_data) <library_list>: Change type.
2275 (solib_aix_inferior_data_handle): Change type.
2276 (get_solib_aix_inferior_data): Update.
2277 (solib_aix_free_library_list): Remove.
2278 (library_list_start_library): Update.
2279 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2280 return type.
2281 (solib_aix_get_library_list)
2282 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2283 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2284
c294730c
TT
22852019-07-10 Tom Tromey <tromey@adacore.com>
2286
2287 * solib-dsbt.c (struct dsbt_info): Add initializers.
2288 (solib_dsbt_pspace_data): Change type.
2289 (dsbt_pspace_data_cleanup): Remove.
2290 (get_dsbt_info, _initialize_dsbt_solib): Update.
2291
9d52077d
TT
22922019-07-10 Tom Tromey <tromey@adacore.com>
2293
2294 * spu-tdep.c (spu_overlay_data): Change type.
2295 (spu_get_overlay_table, spu_overlay_new_objfile)
2296 (_initialize_spu_tdep): Update.
2297
22a20dca
TT
22982019-07-10 Tom Tromey <tromey@adacore.com>
2299
2300 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2301 destructor.
2302 (dbx_objfile_data_key): Change type and declare later.
2303 (DBX_SYMFILE_INFO): Rewrite.
2304 * dbxread.c (dbx_objfile_data_key): Change type.
2305 (dbx_symfile_init): Update.
2306 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2307 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2308 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2309
cb60f420
TT
23102019-07-10 Tom Tromey <tromey@adacore.com>
2311
2312 * jit.c (jit_program_space_key): Change type. Move lower.
2313 (get_jit_program_space_data): Update.
2314 (jit_program_space_data_cleanup): Remove.
2315 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2316 Update.
2317 (struct jit_program_space_data): Add initializers.
2318
51df2ae3
TT
23192019-07-10 Tom Tromey <tromey@adacore.com>
2320
2321 * solib-darwin.c (struct darwin_info): Add initializers.
2322 (solib_darwin_pspace_data): Change type.
2323 (darwin_pspace_data_cleanup): Remove.
2324 (get_darwin_info, _initialize_darwin_solib): Update.
2325
18101a35
TT
23262019-07-10 Tom Tromey <tromey@adacore.com>
2327
2328 * remote-sim.c (struct sim_inferior_data): Add initializers,
2329 constructor, and destructor.
2330 (sim_inferior_data_key): Change type. Move lower.
2331 (check_for_duplicate_sim_descriptor): Update.
2332 (get_sim_inferior_data): Use new. Update.
2333 (~sim_inferior_data_cleanup): Rename from
2334 sim_inferior_data_cleanup. Simplify.
2335 (gdbsim_close_inferior, simulator_command)
2336 (sim_command_completer, _initialize_remote_sim): Update.
2337 (next_pid, INITIAL_PID): Move earlier.
2338
05b08ac1
TT
23392019-07-10 Tom Tromey <tromey@adacore.com>
2340
2341 * python/python-internal.h (create_thread_object): Return
2342 gdbpy_ref.
2343 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2344 * python/py-inferior.c (struct threadlist_entry): Add
2345 constructor.
2346 <thread_obj>: Now a gdbpy_ref.
2347 (thread_to_thread_object): Update.
2348 (add_thread_object): Use new.
2349 (delete_thread_object): Use delete.
2350 (infpy_threads): Update.
2351 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2352 GIL.
2353
32372d80
TT
23542019-07-10 Tom Tromey <tromey@adacore.com>
2355
2356 * valops.c (value_cast): Specialize error message for Ada.
2357
5c458ae8
SM
23582019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2359
2360 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2361
4c462cb0
SM
23622019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2363
2364 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2365 bpstat_should_step): Return bool, adjust comments.
2366 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2367 bpstat_should_step): Likewise.
2368
89abbcc2
AH
23692019-07-10 Alan Hayward <alan.hayward@arm.com>
2370
2371 * features/Makefile: Use feature target descriptions for Arm.
2372 * features/arm/arm-core.c: Generate new file.
2373 * features/arm/arm-fpa.c: Likewise.
2374 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2375 * features/arm/arm-m-profile.c: Likewise.
2376 * features/arm/arm-vfpv2.c: Likewise.
2377 * features/arm/arm-vfpv3.c: Likewise.
2378 * features/arm/xscale-iwmmxt.c: Likewise.
2379 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2380
166a82be
AH
23812019-07-10 Alan Hayward <alan.hayward@arm.com>
2382
2383 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2384 ptrace earlier.
2385
9fb4c7e9
AH
23862019-07-10 Alan Hayward <alan.hayward@arm.com>
2387
2388 * features/aarch64-pauth.c: Regenerate.
2389
e2d0f980
SM
23902019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2391
2392 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2393 bool.
2394 (bpstat_what): Use false instead of 0.
2395
a38118e5
PA
23962019-07-09 Pedro Alves <palves@redhat.com>
2397
2398 * break-catch-throw.c (is_exception_catchpoint): New.
2399 * breakpoint.c (print_one_breakpoint_location): New parameter
2400 'raw_loc'. Handle it. Use
2401 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2402 looking at the breakpoint's type.
2403 (print_one_breakpoint): If handling "maint info breakpoints", also
2404 print locations of exception catchpoints.
2405 * breakpoint.h (is_exception_catchpoint): Declare.
2406
cb1e4e32
PA
24072019-07-09 Pedro Alves <palves@redhat.com>
2408
2409 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2410 "addr" field.
2411 (allocate_location_exception_catchpoint): New.
2412 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2413 (initialize_throw_catchpoint_ops): Install
2414 allocate_location_exception_catchpoint as allocate_location
2415 method.
2416 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2417 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2418 bp_loc_other.
2419 (breakpoint_address_is_meaningful): Delete.
2420 (bl_address_is_meaningful): New.
2421 (breakpoint_locations_match): Adjust comment.
2422 (bp_location_from_bp_type): New, factored out of...
2423 (bp_location::bp_location(breakpoint *)): ... this.
2424 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2425 factored out of...
2426 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2427 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2428 breakpoint_address_is_meaningful.
2429 (bp_locations_compare): Adjust comment.
2430 (update_global_location_list): Use bl_address_is_meaningful
2431 instead of breakpoint_address_is_meaningful.
2432 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2433 explicit.
2434 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2435 * python/py-breakpoint.c (bppy_get_location): No longer check
2436 whether location is null.
2437
b58a68fe
PA
24382019-07-09 Pedro Alves <palves@redhat.com>
2439
2440 PR c++/15468
2441 * breakpoint.c (print_one_breakpoint_location): Remove
2442 single-location assert.
2443
268a13a5
TT
24442019-07-09 Tom Tromey <tom@tromey.com>
2445
2446 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2447 * configure: Rebuild.
2448 * configure.ac: Change common to gdbsupport.
2449 * gdbsupport: Rename from common.
2450 * acinclude.m4: Change common to gdbsupport.
2451 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2452 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2453 gdbsupport.
2454 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2455 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2456 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2457 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2458 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2459 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2460 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2461 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2462 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2463 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2464 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2465 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2466 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2467 coff-pe-read.c, command.h, compile/compile-c-support.c,
2468 compile/compile-c.h, compile/compile-cplus-symbols.c,
2469 compile/compile-cplus-types.c, compile/compile-cplus.h,
2470 compile/compile-loc2c.c, compile/compile.c, completer.c,
2471 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2472 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2473 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2474 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2475 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2476 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2477 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2478 features/aarch64-core.c, features/aarch64-fpu.c,
2479 features/aarch64-pauth.c, features/aarch64-sve.c,
2480 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2481 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2482 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2483 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2484 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2485 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2486 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2487 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2488 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2489 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2490 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2491 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2492 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2493 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2494 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2495 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2496 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2497 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2498 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2499 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2500 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2501 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2502 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2503 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2504 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2505 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2506 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2507 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2508 minsyms.c, mips-linux-tdep.c, namespace.h,
2509 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2510 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2511 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2512 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2513 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2514 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2515 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2516 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2517 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2518 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2519 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2520 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2521 procfs.c, producer.c, progspace.h, psymtab.h,
2522 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2523 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2524 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2525 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2526 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2527 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2528 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2529 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2530 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2531 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2532 target-memory.c, target.c, target.h, target/waitstatus.c,
2533 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2534 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2535 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2536 unittests/array-view-selftests.c,
2537 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2538 unittests/common-utils-selftests.c,
2539 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2540 unittests/format_pieces-selftests.c,
2541 unittests/function-view-selftests.c,
2542 unittests/lookup_name_info-selftests.c,
2543 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2544 unittests/mkdir-recursive-selftests.c,
2545 unittests/observable-selftests.c,
2546 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2547 unittests/parse-connection-spec-selftests.c,
2548 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2549 unittests/scoped_fd-selftests.c,
2550 unittests/scoped_mmap-selftests.c,
2551 unittests/scoped_restore-selftests.c,
2552 unittests/string_view-selftests.c, unittests/style-selftests.c,
2553 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2554 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2555 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2556 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2557 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2558 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2559
5b0e2db4
AB
25602019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2561
2562 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2563 bool value.
2564 (decode_digits_ordinary): Set explicit_line field in sal.
2565 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2566 symtab_and_line that was set on an explicit line number in
2567 assembler code. Do always update the recorded symtab and line if
2568 we do skip the prologue.
2569
0ba852ab
AB
25702019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2571
2572 * breakpoint.c (set_breakpoint_location_function): Remove
2573 explicit_loc parameter.
2574 (momentary_breakpoint_from_master): Update call to
2575 set_breakpoint_location_function.
2576 (add_location_to_breakpoint): Likewise.
2577
b3a7d171
AB
25782019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2579
2580 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2581 required features based on default bfd type when no specific bfd
2582 is present.
2583
1f6f6e21
PW
25842019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2585
2586 * NEWS: Mention that GDB printf and eval commands can now print
2587 C-style and Ada-style convenience var strings without
2588 calling the inferior.
2589 * printcmd.c (printf_c_string): Locally print GDB internal var
2590 instead of transiting via the inferior.
2591 (printf_wide_c_string): Likewise.
2592
25932019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
2594
2595 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2596
0598af48
TT
25972019-07-04 Tom Tromey <tom@tromey.com>
2598
2599 PR tui/24724:
2600 * tui/tui-winsource.c (tui_clear_source_content): Update.
2601 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2602 (tui_update_breakpoint_info): Update.
2603 (tui_set_exec_info_content): Update.
2604 * tui/tui-source.c (tui_set_source_content_nil): Update.
2605 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2606 has_break.
2607 * tui/tui-data.h (enum tui_bp_flag): New.
2608 (tui_bp_flags): New enum flags type.
2609 (struct tui_source_element) <break_mode>: Change type. Rename
2610 from has_break.
2611 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2612 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2613 constants.
2614 * tui/tui-winsource.h: Fix comment.
2615
350fab54
AH
26162019-07-04 Alan Hayward <alan.hayward@arm.com>
2617
2618 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2619 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2620 (store_fpregs_to_thread)
2621 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2622 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2623 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2624 (IWMMXT_REGS_SIZE): Add define.
2625 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2626 (fetch_vfp_regs, store_vfp_regs)
2627 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2628 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2629
f0452268
AH
26302019-07-04 Alan Hayward <alan.hayward@arm.com>
2631
2632 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2633 defines.
2634 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2635 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2636 (ARM_INT_REGISTER_SIZE): ...to this.
2637 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2638 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2639 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2640 (arm_linux_collect_gregset, supply_nwfpe_register)
2641 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2642 defines.
2643 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2644 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2645 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2646 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2647 (arm_return_in_memory, arm_store_return_value)
2648 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2649 (arm_record_ld_st_multiple): Likewise.
2650 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2651 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2652
e935475c
AH
26532019-07-04 Alan Hayward <alan.hayward@arm.com>
2654
2655 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2656 AARCH64_DISPLACED_MODIFIED_INSNS.
2657 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2658 (aarch64_displaced_step_copy_insn): Likewise.
2659 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2660 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2661 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2662 ARM_DISPLACED_MODIFIED_INSNS.
2663 * arm-tdep.c (arm_gdbarch_init): Likewise.
2664 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2665 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2666 (struct arm_displaced_step_closure): Use
2667 ARM_DISPLACED_MODIFIED_INSNS.
2668
df0bb381
AH
26692019-07-04 Alan Hayward <alan.hayward@arm.com>
2670
2671 * features/Makefile: Remove unused xml files.
2672 * features/aarch64.xml: Remove.
2673 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2674 * features/i386/amd64-avx-avx512.xml: Remove.
2675 * features/i386/amd64-avx-linux.xml: Remove.
2676 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2677 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2678 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2679 * features/i386/amd64-avx-mpx.xml: Remove.
2680 * features/i386/amd64-avx.xml: Remove.
2681 * features/i386/amd64-linux.xml: Remove.
2682 * features/i386/amd64-mpx-linux.xml: Remove.
2683 * features/i386/amd64-mpx.xml: Remove.
2684 * features/i386/amd64.xml: Remove.
2685 * features/i386/i386-avx-avx512-linux.xml: Remove.
2686 * features/i386/i386-avx-avx512.xml: Remove.
2687 * features/i386/i386-avx-linux.xml: Remove.
2688 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2689 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2690 * features/i386/i386-avx-mpx-linux.xml: Remove.
2691 * features/i386/i386-avx-mpx.xml: Remove.
2692 * features/i386/i386-avx.xml: Remove.
2693 * features/i386/i386-linux.xml: Remove.
2694 * features/i386/i386-mmx-linux.xml: Remove.
2695 * features/i386/i386-mmx.xml: Remove.
2696 * features/i386/i386-mpx-linux.xml: Remove.
2697 * features/i386/i386-mpx.xml: Remove.
2698 * features/i386/i386.xml: Remove.
2699 * features/i386/x32-avx-avx512-linux.xml: Remove.
2700 * features/i386/x32-avx-linux.xml: Remove.
2701 * features/i386/x32-linux.xml: Remove.
2702
edd6266a
AH
27032019-07-04 Alan Hayward <alan.hayward@arm.com>
2704
2705 * regformats/aarch64.dat: Remove.
2706 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2707 * regformats/i386/amd64-avx-linux.dat: Remove.
2708 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2709 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2710 * regformats/i386/amd64-linux.dat: Remove.
2711 * regformats/i386/amd64-mpx-linux.dat: Remove.
2712 * regformats/i386/amd64.dat: Remove.
2713 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2714 * regformats/i386/i386-avx-linux.dat: Remove.
2715 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2716 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2717 * regformats/i386/i386-linux.dat: Remove.
2718 * regformats/i386/i386-mmx-linux.dat: Remove.
2719 * regformats/i386/i386-mpx-linux.dat: Remove.
2720 * regformats/i386/i386.dat: Remove.
2721 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2722 * regformats/i386/x32-avx-linux.dat: Remove.
2723 * regformats/i386/x32-linux.dat: Remove.
2724
2b40fda7
AH
27252019-07-04 Alan Hayward <alan.hayward@arm.com>
2726
2727 * aarch64-tdep.c: Remove xml self tests.
2728 * amd64-linux-tdep.c: Likewise.
2729 * amd64-tdep.c: Likewise.
2730 * i386-linux-tdep.c: Likewise.
2731 * i386-tdep.c: Likewise.
2732
5f4ba3e7
PA
27332019-07-03 Pedro Alves <palves@redhat.com>
2734
2735 PR cli/24732
2736 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2737 (pipe_cmd_option_defs): New.
2738 (make_pipe_cmd_options_def_group): New.
2739 (pipe_command): Use gdb::option::process_options.
2740 (pipe_command_completer): New function.
2741 (_initialize_cli_cmds): Install completer for "pipe" command.
2742
3d9be6f5
PA
27432019-07-03 Pedro Alves <palves@redhat.com>
2744
2745 * cli/cli-option.c (union option_value) <string>: New field.
2746 (struct option_def_and_value): Add ctor, move ctor, dtor and
2747 use DISABLE_COPY_AND_ASSIGN.
2748 (option_def_and_value::clear_value): New.
2749 (parse_option, save_option_value_in_ctx, get_val_type_str)
2750 (add_setshow_cmds_for_options): Handle var_string.
2751 * cli-option.h (union option_def::var_address) <string>: New
2752 field.
2753 (struct string_option_def): New.
2754 * maint-test-options.c (struct test_options_opts): Add default
2755 ctor and use DISABLE_COPY_AND_ASSIGN.
2756 <string_opt>: New field.
2757 (test_options_opts::~test_options_opts): New.
2758 (test_options_opts::dump): Also dump "-string".
2759 (test_options_option_defs): Install "string.
2760
41fc454c
PA
27612019-07-03 Pedro Alves <palves@redhat.com>
2762
2763 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2764 option_value with a null enumeration.
2765 (complete_options): Save the option values in the context.
2766 (save_option_value_in_ctx): New, factored out from ...
2767 (process_options): ... here.
2768 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2769 of the function.
2770 * maint-test-options.c (test_options_opts::dump): New, factored
2771 out from ...
2772 (maintenance_test_options_command_mode): ... here.
2773 (maintenance_test_options_command_completion_result): Delete.
2774 (maintenance_test_options_command_completion_text): Update
2775 comment.
2776 (maintenance_show_test_options_completion_result): Change
2777 prototype. Just print
2778 maintenance_test_options_command_completion_text.
2779 (save_completion_result): New.
2780 (maintenance_test_options_completer_mode): Pass options context to
2781 complete_options, and then save a dump.
2782 (_initialize_maint_test_options): Use add_cmd to install "maint
2783 show test-options-completion-result".
2784
fdbc9870
PA
27852019-07-03 Pedro Alves <palves@redhat.com>
2786
2787 * NEWS (New commands): Mention "with" and "maint with".
2788 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2789 (with_command, with_command_completer): New.
2790 (pipe_command): Adjust to new repeat_previous
2791 interface.
2792 (_initialize_cli_cmds): Install the "with" command and its "w"
2793 alias.
2794 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2795 declarations.
2796 * cli/cli-setshow.c (parse_cli_var_uinteger)
2797 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2798 argument strings for all var_types.
2799 (get_setshow_command_value_string): New, factored out from ...
2800 (do_show_command): ... this.
2801 * cli/cli-setshow.h: Include <string>.
2802 (get_setshow_command_value_string): Declare.
2803 * command.h (repeat_previous): Now returns const char *. Adjust
2804 comment.
2805 * maint.c: Include "cli/cli-cmds.h".
2806 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2807 (_initialize_maint_cmds): Register the "maintenance with" command.
2808 * top.c (repeat_previous): Move bits from pipe_command here:
2809 Return the saved command line, if any; error out if there's no
2810 command to relaunch.
2811
c6ac8931
PA
28122019-07-03 Pedro Alves <palves@redhat.com>
2813
2814 * NEWS (New commands): Mention "maint set/show test-settings"
2815 instead of "maint test-settings".
2816 * maint-test-settings.c (maintenance_test_settings_list): Delete.
2817 (maintenance_test_settings_set_list): Rename to ...
2818 (maintenance_set_test_settings_list): ... this.
2819 (maintenance_test_settings_show_list): Rename to ...
2820 (maintenance_show_test_settings_list): ... this.
2821 (maintenance_test_settings_cmd): Delete.
2822 (maintenance_test_settings_set_cmd): ...
2823 (maintenance_set_test_settings_cmd): ... this.
2824 (maintenance_test_settings_show_cmd): ...
2825 (maintenance_show_test_settings_cmd): ... this.
2826 (maintenance_test_settings_show_value_cmd):
2827 (maintenance_show_test_settings_value_cmd): ... this.
2828 (_initialize_maint_test_settings): No longer install the "maint
2829 test-settings" prefix command. Rename "maint test-settings set"
2830 to "maint set test-settings", and "maint test-settings show" to
2831 "maint show test-settings". Adjust all subcommands.
2832
d1fcf2fd
PA
28332019-07-03 Pedro Alves <palves@redhat.com>
2834
2835 * maint-test-settings.c: Fix file's intro comment. Replace all
2836 references to "test-options" with references to "test-settings",
2837 in comments.
2838
970f9d09
PA
28392019-07-03 Pedro Alves <palves@redhat.com>
2840
2841 * maint-test-settings.c (maintenance_test_settings_xxx)
2842 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2843 New.
2844 (maintenance_test_settings_enums): Use them.
2845 (maintenance_test_settings_enum): Default to
2846 maintenance_test_settings_xxx.
2847 (_initialize_maint_test_settings): Initialize
2848 MAINTENANCE_TEST_SETTINGS_FILENAME.
2849
f3869b1a
SM
28502019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2851
2852 * breakpoint.h (remove_breakpoints_inf): Change return type to
2853 void, move function documentation here.
2854 * breakpoint.c (remove_breakpoints_inf): Change return type to
2855 void, move function documentation to header.
2856
54d66006
PA
28572019-07-02 Pedro Alves <palves@redhat.com>
2858
2859 * NEWS (Completion improvements): Mention "info threads".
2860 * thread.c (struct info_threads_opts, info_threads_option_defs)
2861 (make_info_threads_options_def_group): New.
2862 (info_threads_command): Use gdb::option::process_options.
2863 (info_threads_command_completer): New.
2864 (_initialize_thread): Use gdb::option::build_help to build the
2865 help text for "info threads".
2866
854f6088
SM
28672019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2868
2869 * defs.h (generic_load): Move from here...
2870 * symfile.h (generic_load): ... to here. Rename name parameter
2871 to args.
2872 * symfile.c (generic_load): Add comment.
2873
54ee4252
TT
28742019-07-01 Tom Tromey <tromey@adacore.com>
2875
2876 * dwarf2read.c
2877 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2878 declaration of without_params. Fix formatting.
2879
65392b3e
TT
28802019-07-01 Tom Tromey <tromey@adacore.com>
2881
2882 * ada-exp.y (find_primitive_type): Update.
2883 * ada-lang.h (ada_lookup_symbol): Update.
2884 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2885 parameter.
2886 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2887
7d7571f0
SDJ
28882019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2889
2890 PR breakpoints/24541
2891 * gdbarch.c: Regenerate.
2892 * gdbarch.h: Regenerate.
2893 * gdbarch.sh: Add 'stap_adjust_register'.
2894 * i386-tdep.c: Include '<unordered_set>'.
2895 (i386_stap_adjust_register): New function.
2896 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2897 * stap-probe.c (stap_parse_register_operand): Call
2898 'gdbarch_stap_adjust_register'.
2899
5af5392a
SDJ
29002019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2901
2902 PR python/24742
2903 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2904 * python/python.c (do_start_initialization): Use 'xmalloc'
2905 instead of 'PyMem_Malloc'.
2906
10d06d82
TT
29072019-06-28 Tom Tromey <tromey@adacore.com>
2908
2909 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2910 for Ada.
2911
1b7f24cd
TT
29122019-06-27 Tom Tromey <tromey@adacore.com>
2913
2914 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2915 objfile_key.
2916 (arm_find_mapping_symbol, arm_record_special_symbol)
2917 (_initialize_arm_tdep): Update.
2918 (arm_objfile_data_free): Remove.
2919
3d507ff2
TT
29202019-06-27 Tom Tromey <tromey@adacore.com>
2921
2922 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2923 to cp_print_static_field.
2924
762c164d
TT
29252019-06-26 Tom Tromey <tromey@adacore.com>
2926
2927 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2928 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2929 declare.
2930
aa2f9bcf
AH
29312019-06-26 Alan Hayward <alan.hayward@arm.com>
2932
2933 * features/aarch64-core.c (create_feature_aarch64_core):
2934 Regenerate.
2935 * features/aarch64-core.xml: Add cpsr flags.
2936
3426ae57
AH
29372019-06-26 Alan Hayward <alan.hayward@arm.com>
2938
2939 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2940 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2941
4838e44c
SM
29422019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2943
2944 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2945 field.
2946 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2947 use.
2948 (arm_record_special_symbol): Don't insert new symbol in sorted
2949 position, push it at the end.
2950
54cc7474
SM
29512019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2952
2953 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2954 (arm_mapping_symbol_s): Remove.
2955 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2956 (arm_mapping_symbol_vec): New typedef.
2957 (struct arm_per_objfile): Add constructor.
2958 <section_maps>: Change type to
2959 std::unique_ptr<arm_mapping_symbol_vec[]>.
2960 (arm_compare_mapping_symbols): Remove.
2961 (arm_find_mapping_symbol): Adjust to section_maps type change.
2962 (arm_objfile_data_free): Call delete on arm_per_objfile.
2963 (arm_record_special_symbol): Adjust to section_maps type change.
2964 Allocate arm_per_objfile with new.
2965
b65b566c
PW
29662019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2967
2968 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2969 with the command prefix.
2970
c2fc64f5
TT
29712019-06-25 Tom Tromey <tom@tromey.com>
2972
2973 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2974 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2975
fb54fa76
TT
29762019-06-25 Tom Tromey <tom@tromey.com>
2977
2978 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2979 type.
2980 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2981 protected.
2982
f7952c57
TT
29832019-06-25 Tom Tromey <tom@tromey.com>
2984
2985 * tui/tui-winsource.c
2986 (tui_source_window_base::set_is_exec_point_at): Add check against
2987 LOA_ADDRESS.
2988
17568d78
TT
29892019-06-25 Tom Tromey <tom@tromey.com>
2990
2991 * tui/tui-source.c (tui_set_source_content): Don't check before
2992 xfree.
2993 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2994
53e7cdba
TT
29952019-06-25 Tom Tromey <tom@tromey.com>
2996
2997 * tui/tui-winsource.h (tui_update_source_window_as_is)
2998 (tui_alloc_source_buffer, tui_line_is_displayed)
2999 (tui_addr_is_displayed): Change type of win_info.
3000 * tui/tui-winsource.c (tui_update_source_window_as_is)
3001 (tui_clear_source_content, tui_show_source_line)
3002 (tui_show_source_content, tui_source_window_base::refill)
3003 (tui_source_window_base::set_is_exec_point_at)
3004 (tui_source_window_base::set_is_exec_point_at)
3005 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3006 (tui_alloc_source_buffer, tui_line_is_displayed)
3007 (tui_addr_is_displayed): Change type of win_info. Update.
3008 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3009 (tui_source_window_base::do_make_visible_with_new_height):
3010 Update.
3011 * tui/tui-source.c (tui_set_source_content)
3012 (tui_set_source_content_nil)
3013 (tui_source_window::do_scroll_vertical): Update.
3014 * tui/tui-layout.c (show_layout): Update.
3015 * tui/tui-disasm.c (tui_set_disassem_content)
3016 (tui_disasm_window::do_scroll_vertical): Update.
3017 * tui/tui-data.h (tui_win_content): Remove.
3018 (struct tui_gen_win_info) <content, content_size>: Remove.
3019 (struct tui_source_element): Add initializers and destructor.
3020 (union tui_which_element, struct tui_win_element): Remove.
3021 (struct tui_source_window_base) <content>: New field.
3022 (struct tui_data_window): Remove destructor.
3023 (tui_alloc_content, tui_free_win_content)
3024 (tui_free_all_source_wins_content): Don't declare.
3025 * tui/tui-data.c (tui_initialize_static_data): Update.
3026 (init_content_element, tui_alloc_content): Remove.
3027 (~tui_gen_win_info): Update.
3028 (~tui_data_window, tui_free_all_source_wins_content)
3029 (tui_free_win_content, free_content, free_content_elements):
3030 Remove.
3031
7908abbf
TT
30322019-06-25 Tom Tromey <tom@tromey.com>
3033
3034 * tui/tui-winsource.h (tui_clear_source_content)
3035 (tui_erase_source_content, tui_show_source_content): Change type
3036 of win_info.
3037 * tui/tui-winsource.c (tui_clear_source_content)
3038 (tui_erase_source_content, tui_show_source_content): Change type
3039 of win_info.
3040 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3041 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3042 win_info.
3043 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3044 win_info.
3045 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3046
02c28df0
TT
30472019-06-25 Tom Tromey <tom@tromey.com>
3048
3049 * tui/tui-winsource.c (tui_clear_source_content)
3050 (tui_source_window_base::set_is_exec_point_at): Update.
3051 * tui/tui-source.c (tui_set_source_content_nil): Update.
3052 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3053 a bool.
3054 * tui/tui-data.c (init_content_element): Update.
3055
6658b1bf
TT
30562019-06-25 Tom Tromey <tom@tromey.com>
3057
3058 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3059 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3060 * tui/tui-layout.c (init_and_make_win): Update.
3061 * tui/tui.h (enum tui_win_type): Update.
3062 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3063 tui_win_is_auxillary.
3064 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3065 tui_win_is_auxillary.
3066
21e1c91e
TT
30672019-06-25 Tom Tromey <tom@tromey.com>
3068
3069 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3070 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3071 (tui_delete_data_content_windows, tui_display_all_data)
3072 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3073 Update.
3074 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3075 * tui/tui-regs.c (tui_last_regs_line_no)
3076 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3077 (tui_show_registers): Update.
3078 (tui_show_register_group): Return void. Update.
3079 (tui_display_registers_from, tui_display_reg_element_at_line)
3080 (tui_display_registers_from_line, tui_check_register_values):
3081 Update.
3082 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3083 member.
3084 (struct tui_data_window) <regs_content>: Now a std::vector.
3085 <regs_content_count>: Remove.
3086 (tui_add_content_elements, tui_free_data_content): Don't declare.
3087 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3088 (init_content_element): Remove DATA_WIN case. Add assert.
3089 (tui_add_content_elements): Remove.
3090 (tui_data_window): Update.
3091 (tui_free_data_content): Remove.
3092 (free_content_elements): Remove DATA_WIN case.
3093
115ac53b
TT
30942019-06-25 Tom Tromey <tom@tromey.com>
3095
3096 * tui/tui-data.c (tui_data_item_window): Update.
3097 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3098 * tui/tui-windata.c (tui_display_all_data)
3099 (tui_display_data_from_line): Update.
3100 (tui_check_data_values): Remove.
3101 * tui/tui-regs.c (tui_show_register_group)
3102 (tui_display_reg_element_at_line): Update.
3103 * tui/tui-hooks.c (tui_register_changed)
3104 (tui_refresh_frame_and_register_information): Call
3105 tui_check_register_values.
3106 * tui/tui-data.h (struct tui_data_window) <data_content,
3107 data_content_count, data_type>: Remove.
3108 (enum tui_data_type): Remove.
3109
3110 * tui/tui-data.c (tui_data_window::clear_detail)
3111 (~tui_data_window): Update.
3112
eaf9738b
TT
31132019-06-25 Tom Tromey <tom@tromey.com>
3114
3115 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3116 declare.
3117 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3118 Rename from tui_first_data_item_displayed. Update.
3119 (tui_data_window::refresh_all)
3120 (tui_data_window::do_scroll_vertical): Update.
3121 * tui/tui-data.h (struct tui_data_window)
3122 <first_data_item_displayed>: Declare new method.
3123
31ca4723
TT
31242019-06-25 Tom Tromey <tom@tromey.com>
3125
3126 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3127 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3128 contents...
3129 (tui_initialize_static_data): ...here.
3130
41bcff7f
TT
31312019-06-25 Tom Tromey <tom@tromey.com>
3132
3133 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3134 (tui_display_registers_from, tui_check_register_values): Update.
3135 (tui_display_register): Remove win_info parameter; update.
3136 (tui_get_register): Change type of parameters.
3137 * tui/tui-data.h (struct tui_data_element): Remove.
3138 (union tui_which_element) <data>: Remove.
3139 <data_window>: Change type.
3140 (struct tui_data_item_window): New.
3141 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3142 case. Add assert.
3143 (~tui_data_item_window): New destructor.
3144 (free_content_elements): Remove DATA_ITEM_WIN case.
3145
d2802c33
TT
31462019-06-25 Tom Tromey <tom@tromey.com>
3147
3148 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3149 Remove.
3150
dd835f8b
TT
31512019-06-25 Tom Tromey <tom@tromey.com>
3152
3153 * tui/tui-data.h (struct tui_command_element): Remove.
3154 (union tui_which_element) <command>: Remove.
3155 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3156 assert.
3157 (free_content_elements): Remove CMD_WIN case.
3158
bd7db367
TT
31592019-06-25 Tom Tromey <tom@tromey.com>
3160
3161 * tui/tui-layout.c (tui_set_layout): Update.
3162 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3163 * tui/tui-data.c (layout_def): Update.
3164
3add462f
TT
31652019-06-25 Tom Tromey <tom@tromey.com>
3166
3167 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3168 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3169 (tui_source_window_base::set_new_height): Update.
3170 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3171 Update.
3172 (tui_set_locator_fullname, tui_set_locator_info)
3173 (tui_show_frame_info): Update.
3174 * tui/tui-source.c (tui_set_source_content)
3175 (tui_source_is_displayed): Update.
3176 * tui/tui-layout.c (show_source_disasm_command, show_data)
3177 (show_source_or_disasm_and_command): Update.
3178 * tui/tui-disasm.c (tui_set_disassem_content)
3179 (tui_get_begin_asm_address): Update.
3180 * tui/tui-data.h (struct tui_locator_element): Remove.
3181 (union tui_which_element) <locator>: Remove.
3182 (struct tui_locator_window): New.
3183 (tui_locator_win_info_ptr): Change return type.
3184 * tui/tui-data.c (_locator): Change type.
3185 (tui_locator_win_info_ptr): Change return type.
3186 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3187 (tui_alloc_content): Add assert.
3188
489e9d8b
TT
31892019-06-25 Tom Tromey <tom@tromey.com>
3190
3191 * tui/tui-winsource.c
3192 (tui_exec_info_window::maybe_allocate_content): New method.
3193 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3194 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3195 (make_source_or_disasm_window): Add cast.
3196 * tui/tui-data.h (union tui_which_element) <simple_string>:
3197 Remove.
3198 (struct tui_source_info): New.
3199 (struct tui_source_window_base) <execution_info>: Change type.
3200 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3201 case, and add assert.
3202 (tui_alloc_content): Add assert.
3203
c3fabb7d
TT
32042019-06-25 Tom Tromey <tom@tromey.com>
3205
3206 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3207 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3208 * tui/tui-data.c (tui_alloc_win_info): Remove.
3209
bbc228ee
TT
32102019-06-25 Tom Tromey <tom@tromey.com>
3211
3212 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3213 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3214 can_highlight.
3215
5fcee43a
TT
32162019-06-25 Tom Tromey <tom@tromey.com>
3217
3218 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3219 make_visible_with_new_height method.
3220 (tui_win_info::make_visible_with_new_height): New method.
3221 (tui_source_window_base::do_make_visible_with_new_height)
3222 (tui_data_window::do_make_visible_with_new_height)
3223 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3224 (make_visible_with_new_height): Remove.
3225 (tui_resize_all, tui_adjust_win_heights): Use
3226 make_visible_with_new_height method.
3227 * tui/tui-data.h (struct tui_win_info)
3228 <do_make_visible_with_new_height, make_visible_with_new_height>:
3229 New methods.
3230 (struct tui_source_window_base, struct tui_data_window)
3231 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3232 methods.
3233
d83f1fe6
TT
32342019-06-25 Tom Tromey <tom@tromey.com>
3235
3236 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3237 method.
3238 (update_tab_width): Call update_tab_width method.
3239 * tui/tui-data.h (struct tui_win_info)
3240 (struct tui_source_window_base) <update_tab_width>: New methods.
3241
17374de4
TT
32422019-06-25 Tom Tromey <tom@tromey.com>
3243
3244 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3245 parameter.
3246 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3247 parameter.
3248 (tui_gen_win_info::make_visible): Update.
3249 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3250 parameter.
3251 * tui/tui-data.h (enum tui_box): New enum.
3252 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3253
f936bca2
TT
32542019-06-25 Tom Tromey <tom@tromey.com>
3255
3256 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3257 init_and_make_win for EXEC_INFO_WIN.
3258 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3259 longer inline.
3260 (struct tui_win_info) <~tui_win_info>: Inline.
3261 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3262 Don't declare.
3263 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3264 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3265 Remove.
3266 (tui_initialize_static_data): Update.
3267 (~tui_gen_win_info): Handle more cleanup here.
3268 (~tui_source_window_base): Delete "execution_info".
3269 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3270
d6ba6a11
TT
32712019-06-25 Tom Tromey <tom@tromey.com>
3272
3273 * tui/tui-layout.c (make_command_window): Don't set
3274 can_highlight.
3275 (show_source_disasm_command): Call the reset method.
3276 (show_data): Don't set can_highlight. Call the reset method.
3277 (tui_gen_win_info::reset): Rename from init_gen_win_info
3278 (init_and_make_win): Simplify. Return tui_gen_win_info.
3279 (show_source_or_disasm_and_command): Call the reset method.
3280 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3281 (struct tui_cmd_window): Set can_highlight.
3282
48a3bd16
TT
32832019-06-25 Tom Tromey <tom@tromey.com>
3284
3285 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3286 from make_visible.
3287 (tui_make_visible, tui_make_invisible): Rewrite.
3288 (tui_win_info::make_visible): Remove.
3289 (tui_source_window_base::make_visible): Update.
3290 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3291 method. Moved from...
3292 (struct tui_win_info) <make_visible>: ...here.
3293
c3bd716f
TT
32942019-06-25 Tom Tromey <tom@tromey.com>
3295
3296 * tui/tui-winsource.c
3297 (tui_source_window_base::do_scroll_horizontal): Remove direction
3298 parameter.
3299 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3300 direction parameter.
3301 * tui/tui-win.c (tui_win_info::forward_scroll)
3302 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3303 (tui_win_info::right_scroll): Update.
3304 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3305 direction parameter.
3306 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3307 direction parameter.
3308 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3309 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3310 Remove direction parameter.
3311 (struct tui_source_window_base, struct tui_source_window)
3312 (struct tui_disasm_window, struct tui_data_window)
3313 (struct tui_cmd_window): Update.
3314
21c32dca
TT
33152019-06-25 Tom Tromey <tom@tromey.com>
3316
3317 * tui/tui-winsource.h (tui_set_exec_info_content)
3318 (tui_show_exec_info_content, tui_erase_exec_info_content)
3319 (tui_clear_exec_info_content, tui_update_exec_info): Change
3320 argument to tui_source_window_base.
3321 * tui/tui-winsource.c (tui_set_exec_info_content)
3322 (tui_show_exec_info_content, tui_erase_exec_info_content)
3323 (tui_clear_exec_info_content, tui_update_exec_info): Change
3324 argument to tui_source_window_base.
3325
73fbdc65
TT
33262019-06-25 Tom Tromey <tom@tromey.com>
3327
3328 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3329 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3330
33325343
TT
33312019-06-25 Tom Tromey <tom@tromey.com>
3332
3333 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3334 check.
3335
29d2c474
TT
33362019-06-25 Tom Tromey <tom@tromey.com>
3337
3338 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3339 type to void.
3340 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3341 type to void.
3342 * tui/tui-source.c (tui_set_source_content): Update.
3343 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3344
152f3f4b
TT
33452019-06-25 Tom Tromey <tom@tromey.com>
3346
3347 * tui/tui-win.c (window_name_completer, tui_set_focus)
3348 (tui_all_windows_info): Use name method.
3349 * tui/tui-data.h (struct tui_gen_win_info)
3350 (struct tui_source_window, struct tui_disasm_window)
3351 (struct tui_data_window, struct tui_cmd_window) <name>: New
3352 method.
3353 (tui_win_name): Don't declare.
3354 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3355 (tui_win_name): Remove.
3356
be4da588
TT
33572019-06-25 Tom Tromey <tom@tromey.com>
3358
3359 * tui/tui-winsource.h (tui_update_source_window)
3360 (tui_update_source_window_as_is): Change parameter type.
3361 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3362 to be a tui_source_window_base.
3363 (tui_update_source_window_as_is): Likewise.
3364 * tui/tui-win.c (make_visible_with_new_height): Update.
3365
5b81daba
TT
33662019-06-25 Tom Tromey <tom@tromey.com>
3367
3368 * tui/tui-winsource.c (tui_erase_source_content)
3369 (tui_show_source_content, tui_show_exec_info_content)
3370 (tui_erase_exec_info_content): Use refresh_window method.
3371 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3372 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3373 from tui_refresh_win.
3374 (tui_data_window::refresh_window): New method.
3375 (tui_win_info::refresh, tui_source_window_base::refresh)
3376 (tui_refresh_all): Use refresh_window method.
3377 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3378 method.
3379 * tui/tui-regs.c (tui_display_register): Call refresh_window
3380 method.
3381 * tui/tui-layout.c (show_source_disasm_command)
3382 (show_source_or_disasm_and_command): Call refresh_window method.
3383 * tui/tui-data.h (struct tui_gen_win_info)
3384 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3385 New method.
3386
cb2ce893
TT
33872019-06-25 Tom Tromey <tom@tromey.com>
3388
3389 * tui/tui.c (tui_rl_other_window, tui_enable)
3390 (tui_is_window_visible, tui_get_command_dimension): Update.
3391 * tui/tui-winsource.c (tui_update_source_window_as_is)
3392 (tui_clear_source_content, tui_erase_source_content)
3393 (tui_show_source_line, tui_source_window_base::refill)
3394 (tui_source_window_base::do_scroll_horizontal)
3395 (tui_source_window_base::set_is_exec_point_at)
3396 (tui_update_breakpoint_info, tui_set_exec_info_content)
3397 (tui_alloc_source_buffer, tui_line_is_displayed)
3398 (tui_addr_is_displayed): Update.
3399 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3400 (tui_check_and_display_highlight_if_needed)
3401 (tui_win_info::make_visible, tui_win_info::refresh)
3402 (tui_refresh_all): Update.
3403 * tui/tui-windata.c (tui_first_data_item_displayed)
3404 (tui_delete_data_content_windows, tui_erase_data_content)
3405 (tui_display_all_data, tui_data_window::refresh_all)
3406 (tui_check_data_values): Update.
3407 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3408 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3409 (tui_win_info::backward_scroll, tui_refresh_all_win)
3410 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3411 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3412 (tui_source_window_base::set_new_height)
3413 (tui_data_window::set_new_height)
3414 (make_invisible_and_set_new_height)
3415 (make_visible_with_new_height, new_height_ok)
3416 (parse_scrolling_args): Update.
3417 * tui/tui-stack.c (tui_show_frame_info): Update.
3418 * tui/tui-source.c (tui_set_source_content)
3419 (tui_set_source_content_nil, tui_source_is_displayed)
3420 (tui_source_window::do_scroll_vertical): Update.
3421 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3422 (tui_display_registers_from, tui_display_reg_element_at_line)
3423 (tui_check_register_values, tui_reg_command): Update.
3424 * tui/tui-layout.c (tui_default_win_height)
3425 (show_source_disasm_command, show_data, init_and_make_win)
3426 (show_source_or_disasm_and_command): Update.
3427 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3428 (tui_redisplay_readline, tui_mld_flush)
3429 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3430 (tui_getc): Update.
3431 * tui/tui-disasm.c (tui_set_disassem_content)
3432 (tui_disasm_window::do_scroll_vertical): Update.
3433 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3434 Now virtual.
3435 (struct tui_win_info): Derive from tui_gen_win_info.
3436 <~tui_win_info>: Mark as override.
3437 <generic>: Remove member.
3438 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3439 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3440 (~tui_data_window, ~tui_win_info)
3441 (tui_free_all_source_wins_content): Update.
3442 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3443
ab313b35
TT
34442019-06-25 Tom Tromey <tom@tromey.com>
3445
3446 * tui/tui-layout.c (init_and_make_win): Use new.
3447 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3448 destructor, initializers.
3449 (tui_alloc_generic_win_info): Don't declare.
3450 * tui/tui-data.c (_locator): Add argument to constructor.
3451 (source_win, disasm_win): New globals.
3452 (exec_info): Remove.
3453 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3454 Update.
3455 (tui_alloc_generic_win_info): Remove.
3456 (init_content_element): Use new.
3457 (tui_win_info::tui_win_info): Update.
3458 (free_content_elements) <case DATA_WIN>: Use delete.
3459
dc2c33e4
TT
34602019-06-25 Tom Tromey <tom@tromey.com>
3461
3462 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3463 * tui/tui-windata.c (tui_first_data_item_displayed)
3464 (tui_delete_data_content_windows): Update.
3465 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3466 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3467 (tui_display_registers_from, tui_check_register_values): Update.
3468 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3469 pointer.
3470 * tui/tui-data.c (init_content_element): Update. Allocate the new
3471 window.
3472 (tui_free_data_content): Update.
3473 (free_content_elements) <case DATA_WIN>: Free the window.
3474
214a5cbe
TT
34752019-06-25 Tom Tromey <tom@tromey.com>
3476
3477 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3478 Update.
3479 * tui/tui-layout.c (make_command_window)
3480 (show_source_disasm_command, show_data, init_and_make_win)
3481 (show_source_or_disasm_and_command): Update.
3482 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3483 method.
3484 <can_highight, is_highlighted>: Now bool.
3485 (tui_set_win_highlight): Don't declare.
3486 * tui/tui-data.c (tui_set_win_highlight): Remove.
3487
8e2daf15
TT
34882019-06-25 Tom Tromey <tom@tromey.com>
3489
3490 * tui/tui-wingeneral.c (make_visible): Remove check of window
3491 type.
3492
8903bd8a
TT
34932019-06-25 Tom Tromey <tom@tromey.com>
3494
3495 * tui/tui-win.c (tui_win_info::max_height)
3496 (tui_cmd_window::max_height): New methods.
3497 (new_height_ok): Call max_height.
3498 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3499 <max_height>: New method.
3500
3f02ce1e
TT
35012019-06-25 Tom Tromey <tom@tromey.com>
3502
3503 * tui/tui-win.c (tui_source_window_base::set_new_height)
3504 (tui_data_window::set_new_height): New methods.
3505 (make_invisible_and_set_new_height): Call set_new_height method.
3506 * tui/tui-data.h (struct tui_win_info)
3507 (struct tui_source_window_base, struct tui_data_window)
3508 <set_new_height>: New method.
3509
1825f487
TT
35102019-06-25 Tom Tromey <tom@tromey.com>
3511
3512 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3513 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3514 tui_refresh_data_win.
3515 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3516 method.
3517 (tui_refresh_all_win): Call the refresh_all method.
3518 (tui_set_focus): Likewise.
3519 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3520 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3521 Likewise.
3522
ad54d15b
TT
35232019-06-25 Tom Tromey <tom@tromey.com>
3524
3525 * tui/tui-winsource.h (tui_refill_source_window)
3526 (tui_set_is_exec_point_at): Don't declare.
3527 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3528 (tui_source_window_base::refill): Rename from
3529 tui_refill_source_window.
3530 (tui_source_window_base::do_scroll_horizontal): Update.
3531 (tui_source_window_base::set_is_exec_point_at): Rename from
3532 tui_set_is_exec_point_at.
3533 (tui_update_all_breakpoint_info): Update.
3534 * tui/tui-stack.c (tui_show_frame_info): Update.
3535 * tui/tui-layout.c (show_data): Add cast.
3536 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3537 * tui/tui-data.h (struct tui_source_window_base) <refill,
3538 set_is_exec_point_at>: New methods.
3539 (tui_source_windows, tui_add_to_source_windows): Update types.
3540 (tui_add_to_source_windows): Remove redundant declaration.
3541 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3542 (tui_source_windows): Change return type.
3543 (tui_clear_source_windows_detail): Update.
3544 (tui_add_to_source_windows): Change type of parameter.
3545 (tui_free_all_source_wins_content): Update.
3546
2042b506
TT
35472019-06-25 Tom Tromey <tom@tromey.com>
3548
3549 * tui/tui-wingeneral.c (tui_win_info::refresh)
3550 (tui_source_window_base::refresh): New methods.
3551 (tui_refresh_all): Call the refresh method.
3552 * tui/tui-data.h (struct tui_win_info)
3553 (struct tui_source_window_base) <refresh>: New method.
3554
56122977
TT
35552019-06-25 Tom Tromey <tom@tromey.com>
3556
3557 * tui/tui.h (tui_is_window_visible): Return bool.
3558 * tui/tui.c (tui_is_window_visible): Return bool.
3559 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3560 (tui_make_visible, tui_make_invisible)
3561 (tui_win_info::make_visible)
3562 (tui_source_window_base::make_visible, make_all_visible)
3563 (tui_make_all_visible, tui_make_all_invisible): Update.
3564 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3565 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3566 bool.
3567 (struct tui_win_info, struct tui_source_window_base)
3568 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3569 * tui/tui-data.c (tui_init_generic_part): Update.
3570
cda37efb
TT
35712019-06-25 Tom Tromey <tom@tromey.com>
3572
3573 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3574 (tui_source_window_base::make_visible): New methods.
3575 (make_all_visible): Make method call.
3576 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3577 (struct tui_source_window_base, struct tui_cmd_window): Override
3578 make_visible.
3579 (tui_win_is_source_type): Don't declare.
3580 * tui/tui-data.c (tui_win_is_source_type): Remove.
3581
6a0ee02c
TT
35822019-06-25 Tom Tromey <tom@tromey.com>
3583
3584 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3585 NULL check.
3586
63901aec
TT
35872019-06-25 Tom Tromey <tom@tromey.com>
3588
3589 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3590 Inline constructor. Add initializers for members.
3591 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3592 constructors; now inline in class.
3593
ceb13a13
TT
35942019-06-25 Tom Tromey <tom@tromey.com>
3595
3596 * tui/tui-regs.c (tui_show_registers): Update.
3597 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3598 bool.
3599 * tui/tui-data.c (tui_data_window::clear_detail)
3600 (tui_data_window): Update.
3601
238eb706
TT
36022019-06-25 Tom Tromey <tom@tromey.com>
3603
3604 * tui/tui-windata.c (tui_display_all_data)
3605 (tui_display_data_from_line, tui_display_data_from)
3606 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3607 Update.
3608 * tui/tui-regs.c (tui_last_regs_line_no)
3609 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3610 (tui_show_registers, tui_show_register_group)
3611 (tui_display_registers_from, tui_display_reg_element_at_line)
3612 (tui_display_registers_from_line, tui_check_register_values)
3613 (tui_reg_next, tui_reg_prev): Update.
3614 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3615 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3616 tui_data_window.
3617 (struct tui_win_info) <detail>: Remove. Add new fields from
3618 tui_data_info.
3619 (TUI_DATA_WIN): Add cast.
3620 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3621 (~tui_data_window): Simplify.
3622
81491aa0
TT
36232019-06-25 Tom Tromey <tom@tromey.com>
3624
3625 * tui/tui-layout.c (show_source_disasm_command)
3626 (show_source_or_disasm_and_command): Update.
3627 * tui/tui-io.c (update_cmdwin_start_line)
3628 (tui_redisplay_readline): Update.
3629 * tui/tui-data.h (struct tui_command_info): Remove.
3630 (struct tui_win_info) <detail>: Remove command_info member.
3631 (struct tui_data_window) <start_line>: New member, from
3632 tui_command_info.
3633 (TUI_CMD_WIN): Add casts.
3634
e6e41501
TT
36352019-06-25 Tom Tromey <tom@tromey.com>
3636
3637 * tui/tui-winsource.c (tui_update_source_window)
3638 (tui_refill_source_window)
3639 (tui_source_window_base::do_scroll_horizontal)
3640 (tui_update_breakpoint_info, tui_set_exec_info_content)
3641 (tui_show_exec_info_content, tui_erase_exec_info_content)
3642 (tui_clear_exec_info_content): Update.
3643 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3644 Update.
3645 * tui/tui-win.c (make_invisible_and_set_new_height)
3646 (make_visible_with_new_height): Update.
3647 * tui/tui-source.c (tui_set_source_content)
3648 (tui_show_symtab_source): Update.
3649 * tui/tui-layout.c (extract_display_start_addr)
3650 (show_source_disasm_command, show_data)
3651 (make_source_or_disasm_window)
3652 (show_source_or_disasm_and_command): Update.
3653 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3654 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3655 "gdbarch".
3656 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3657 to tui_source_window_base.
3658 (struct tui_win_info) <detail>: Remove source_info member.
3659 (struct tui_source_window_base) <has_locator>: Inline.
3660 Move contents from tui_source_info; rename has_locator member to
3661 m_has_locator.
3662 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3663 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3664 header file.
3665 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3666 Simplify.
3667 (tui_free_all_source_wins_content): Cast to
3668 tui_source_window_base.
3669
44f0e208
TT
36702019-06-25 Tom Tromey <tom@tromey.com>
3671
3672 * tui/tui-win.c (make_invisible_and_set_new_height)
3673 (make_visible_with_new_height): Call has_locator method.
3674 * tui/tui-layout.c (show_source_disasm_command, show_data)
3675 (show_source_or_disasm_and_command): Update for bool change.
3676 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3677 (tui_win_info) <has_locator>: New method.
3678 (struct tui_source_window_base) <has_locator>: New method.
3679 (tui_win_has_locator): Don't declare.
3680 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3681 from tui_win_has_locator.
3682 (tui_source_window_base): Use false, not FALSE.
3683
7778b912
TT
36842019-06-25 Tom Tromey <tom@tromey.com>
3685
3686 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3687 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3688 clear_detail method directly.
3689 (tui_clear_win_detail): Remove.
3690
f83d391c
TT
36912019-06-25 Tom Tromey <tom@tromey.com>
3692
3693 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3694 "this", not TUI_DISASM_WIN.
3695
13446e05
TT
36962019-06-25 Tom Tromey <tom@tromey.com>
3697
3698 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3699 declare.
3700 * tui/tui-winsource.c
3701 (tui_source_window_base::do_scroll_horizontal): Rename from
3702 tui_horizontal_source_scroll.
3703 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3704 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3705 from tui_vertical_data_scroll.
3706 * tui/tui-win.h (tui_scroll): Don't declare.
3707 * tui/tui-win.c (tui_win_info::forward_scroll)
3708 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3709 (tui_win_info::right_scroll): Rename and update.
3710 (tui_scroll_forward_command, tui_scroll_backward_command)
3711 (tui_scroll_left_command, tui_scroll_right_command): Update.
3712 (tui_scroll): Remove.
3713 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3714 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3715 from tui_vertical_source_scroll.
3716 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3717 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3718 from tui_vertical_disassem_scroll.
3719 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3720 do_scroll_horizontal>: New methods.
3721 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3722 Likewise.
3723 (struct tui_source_window_base): Add do_scroll_horizontal.
3724 (struct tui_source_window, struct tui_disasm_window): Add
3725 do_scroll_vertical.
3726 (struct tui_data_window, struct tui_cmd_window): Add
3727 do_scroll_horizontal and do_scroll_vertical.
3728 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3729
5cf82909
TT
37302019-06-25 Tom Tromey <tom@tromey.com>
3731
3732 * tui/tui-data.h (struct tui_source_window_base): New struct.
3733 (struct tui_source_window): Derive from tui_source_window_base.
3734 (struct tui_disasm_window): New struct.
3735 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3736 from tui_source_window::clear_detail.
3737 (tui_source_window_base): Rename from tui_source_window.
3738 (~tui_source_window_base): Rename from ~tui_source_window.
3739 (tui_alloc_win_info): Create a tui_disasm_window.
3740
ee1d42d6
TT
37412019-06-25 Tom Tromey <tom@tromey.com>
3742
3743 * tui/tui-data.h (struct tui_source_window)
3744 (struct tui_data_window): Declare destructors.
3745 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3746 destructors.
3747 (tui_win_info): Simplify.
3748
b4eb2452
TT
37492019-06-25 Tom Tromey <tom@tromey.com>
3750
3751 * tui/tui-winsource.c (tui_display_main)
3752 (tui_update_source_windows_with_addr)
3753 (tui_update_all_breakpoint_info): Update.
3754 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3755 (new_height_ok, parse_scrolling_args): Update.
3756 * tui/tui-stack.c (tui_show_frame_info): Update.
3757 * tui/tui-data.h (struct tui_list): Remove.
3758 (tui_source_windows): Return a reference to a std::vector.
3759 * tui/tui-data.c (source_windows): Now a std::vector.
3760 (tui_source_windows): Change return type.
3761 (tui_clear_source_windows): Rewrite.
3762 (tui_clear_source_windows_detail, tui_add_to_source_windows)
3763 (tui_free_all_source_wins_content): Rewrite.
3764
8761a91b
TT
37652019-06-25 Tom Tromey <tom@tromey.com>
3766
3767 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3768 (struct tui_data_window, struct tui_cmd_window): Declare
3769 clear_detail method.
3770 * tui/tui-data.c (tui_source_window::clear_detail)
3771 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3772 methods.
3773 (tui_clear_win_detail): Simplify.
3774
0ed69eda
TT
37752019-06-25 Tom Tromey <tom@tromey.com>
3776
3777 * tui/tui-layout.c (make_source_window, make_disasm_window)
3778 (make_source_or_disasm_window): Remove win_info_ptr parameter.
3779 Return the new window.
3780 (show_source_disasm_command, show_data)
3781 (show_source_or_disasm_and_command): Update.
3782
82432e10
TT
37832019-06-25 Tom Tromey <tom@tromey.com>
3784
3785 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3786 parameter. Return the new window.
3787 (show_source_disasm_command): Update and remove NULL check.
3788 (show_source_or_disasm_and_command): Update.
3789
ec328aa5
TT
37902019-06-25 Tom Tromey <tom@tromey.com>
3791
3792 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3793
33b906ab
TT
37942019-06-25 Tom Tromey <tom@tromey.com>
3795
3796 * tui/tui-data.h (struct tui_win_info): Make constructor
3797 protected. Make destructor virtual. Add initializers.
3798 (tui_source_window, tui_data_window, tui_cmd_window): New
3799 classes.
3800 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
3801 constructor. Add "type" parameter.
3802 (tui_source_window, tui_data_window, tui_cmd_window): New
3803 constructors.
3804 (tui_alloc_win_info): Instantiate the appropriate subclass.
3805
e7e11af4
TT
38062019-06-25 Tom Tromey <tom@tromey.com>
3807
3808 * tui/tui-win.c (tui_resize_all): Use delete.
3809 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3810 destructor.
3811 (tui_free_window): Don't declare.
3812 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3813 Update.
3814
6792b55e
TT
38152019-06-25 Tom Tromey <tom@tromey.com>
3816
3817 * tui/tui-data.h (struct tui_win_info): Add constructor.
3818 * tui/tui-data.c (tui_alloc_win_info): Use new.
3819 (tui_free_window): Use delete.
3820
f95675e1
TT
38212019-06-22 Tom Tromey <tom@tromey.com>
3822
3823 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3824 declare.
3825 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3826
5bff081c
TT
38272019-06-22 Tom Tromey <tom@tromey.com>
3828
3829 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3830 declare.
3831 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3832
47e3f474
TV
38332019-06-22 Tom de Vries <tdevries@suse.de>
3834
3835 * dwarf2read.c (create_addrmap_from_aranges)
3836 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3837 instead of '%zu'.
3838
fd5866f6
SM
38392019-06-21 Simon Marchi <simon.marchi@efficios.com>
3840
3841 * dwarf2read.h (dwarf2_section_info_def): Remove.
3842 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3843 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3844 std::vector<dwarf2_section_info>.
3845 (struct dwo_file) <~dwo_file>: Remove.
3846 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3847 types field.
3848 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3849 (dwarf2_read_debug_names): Likewise.
3850 (create_debug_types_hash_table): Change parameter type to
3851 array_view, adjust code accordingly.
3852 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3853 (partial_die_info::fixup): Likewise.
3854 (determine_prefix): Likewise.
3855 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3856
fb1eb2f9
SM
38572019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3858
3859 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3860 gdb_bfd_ref_ptr.
3861 <~dwo_file>: Remove call to gdb_bfd_unref.
3862 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3863 gdb_bfd_ref_ptr::get.
3864
51ac9db5
SM
38652019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3866
3867 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3868 type to htab_up.
3869 * dwarf2read.c (struct dwo_file): Initialize fields.
3870 <~dwo_file>: New.
3871 (free_dwo_file): Remove, move content to ~dwo_file.
3872 (struct dwo_file_deleter): Remove.
3873 (dwo_file_up>: Remove custom deleter.
3874 (free_dwo_files): Remove.
3875 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3876 dwo_files.
3877 (process_skeletonless_type_units): Call unique_ptr::get.
3878 (allocate_dwo_file_hash_table): Add deleter to created hash
3879 table. Change return type to htab_up.
3880 (lookup_dwo_file_slot): Don't memset dwo_file, call
3881 unique_ptr::get.
3882 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3883 (create_dwo_unit_in_dwp_v2): Likewise.
3884 (open_and_init_dwo_file): Likewise.
3885 (free_dwo_file_from_slot): Remove.
3886
dc4ccb6f
SM
38872019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3888
3889 * dwarf2read.h (struct dwarf2_section_info) <readin,
3890 is_virtual>: Change type to bool.
3891 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3892 true instead of 1.
3893
e6a1c5cb
TT
38942019-06-19 Tom Tromey <tom@tromey.com>
3895
3896 * tui/tui-data.h (tui_init_content_element): Don't declare.
3897
6f6ffbeb
TT
38982019-06-19 Tom Tromey <tom@tromey.com>
3899
3900 * tui/tui-data.h (tui_init_win_info): Don't declare.
3901
f23f598e
TV
39022019-06-19 Tom de Vries <tdevries@suse.de>
3903
3904 * dwarf2read.h (abstract_to_concrete): Change type to
3905 std::unordered_map<sect_offset, std::vector<sect_offset>,
3906 gdb::hash_enum<sect_offset>>.
3907
680e1bee
TT
39082019-06-19 Tom Tromey <tromey@adacore.com>
3909
3910 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3911 EVAL_AVOID_SIDE_EFFECTS specially.
3912
dcf37923
TT
39132019-06-19 Tom Tromey <tromey@adacore.com>
3914
3915 * source-cache.c (highlighter): New global.
3916 (source_cache::get_source_lines): Create a highlighter on demand.
3917
494986d5
AB
39182019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3919
3920 * defs.h (deprecated_interactive_hook): Delete declaration.
3921 * interps.c (clear_interpreter_hooks): Remove use of
3922 deprecated_interactive_hook.
3923 * top.c (deprecated_interactive_hook): Delete definition.
3924 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3925
3360b6e7
TV
39262019-06-18 Tom de Vries <tdevries@suse.de>
3927
3928 PR gdb/24515
3929 * dwarf2read.h (abstract_to_concrete): Change type from
3930 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3931 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3932 * dwarf2read.c (read_variable): Update.
3933 (dwarf2_fetch_die_loc_sect_off): Update.
3934
310b3441
TV
39352019-06-17 Tom de Vries <tdevries@suse.de>
3936
3937 PR gdb/24617
3938 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3939 accessing parent[parent_len - 1].
3940
ba9777be
PP
39412019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3942
3943 PR gdb/24364
3944 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3945 call dtrace_process_dof with NULL dof.
3946
2b9f6e89
TV
39472019-06-16 Tom de Vries <tdevries@suse.de>
3948
3949 PR gdb/24445
3950 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3951
431b3ead
TT
39522019-06-16 Tom Tromey <tom@tromey.com>
3953
3954 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3955 (make_all_visible): Use address of member.
3956
d04b44a1
TT
39572019-06-16 Tom Tromey <tom@tromey.com>
3958
3959 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3960 (tui_free_window, free_content, free_content_elements): Remove
3961 unnecessary cast.
3962 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3963 cast.
3964 * tui/tui-regs.c (tui_show_register_group)
3965 (tui_display_registers_from, tui_display_reg_element_at_line):
3966 Remove unnecessary cast.
3967
bf5142e7
AB
39682019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3969
3970 * linux-nat.c (normal_mask): Delete.
3971 (_initialize_linux_nat): Don't initialise normal_mask.
3972
c4973306
SM
39732019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3974
3975 PR gdb/24445
3976 * dwarf-index-write.h (write_psymtabs_to_index): Add
3977 dwz_basename parameter.
3978 * dwarf-index-write.c (write_gdbindex): Move file writing to
3979 write_gdbindex_1. Change return type void.
3980 (assert_file_size): Move up, remove filename parameter.
3981 (write_gdbindex_1): New function.
3982 (write_debug_names): Change return type to void, call
3983 assert_file_size.
3984 (struct index_wip_file): New struct.
3985 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3986 file logic to index_wip_file. Write index for dwz file if
3987 needed.
3988 (save_gdb_index_command): Pass basename of dwz file, if present.
3989 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3990 build-id of dwz file, if present.
3991 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3992 (dwarf2_get_dwz_file): Likewise.
3993 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3994 (dwarf2_get_dwz_file): Likewise.
3995
395f9c91
TT
39962019-06-16 Tom Tromey <tom@tromey.com>
3997
3998 * coffread.c (process_coff_symbol): Use xstrdup.
3999 * value.c (create_internalvar): Use xstrdup.
4000
cafb3438
TT
40012019-06-16 Tom Tromey <tom@tromey.com>
4002
4003 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4004 * breakpoint.c (stopin_command, stopat_command)
4005 (until_break_command, decode_location_default): Remove unnecessary
4006 cast.
4007 * utils.c (subset_compare): Remove unnecessary cast.
4008 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4009 cast.
4010 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4011 cast.
4012 * infcmd.c (path_command): Remove unnecessary cast.
4013 * coffread.c (decode_type): Remove unnecessary cast.
4014 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4015 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4016 * tui/tui-stack.c (tui_show_locator_content)
4017 (tui_show_frame_info): Remove unnecessary cast.
4018 * tui/tui-win.c (tui_scroll_forward_command)
4019 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4020 (parse_scrolling_args): Remove unnecessary cast.
4021 * tui/tui-data.c (init_win_info, tui_del_window)
4022 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4023 (free_content_elements): Remove unnecessary cast.
4024 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4025 unnecessary cast.
4026 * tui/tui-source.c (tui_set_source_content)
4027 (tui_vertical_source_scroll): Remove unnecessary cast.
4028 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4029 cast.
4030 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4031 * tui/tui-regs.c (tui_display_registers_from)
4032 (tui_display_register): Remove unnecessary cast.
4033 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4034 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4035 (make_visible): Remove unnecessary cast.
4036 * tui/tui-winsource.c (tui_erase_source_content)
4037 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4038 unnecessary cast.
4039 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4040 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4041 * stabsread.c (read_type, read_array_type, read_range_type):
4042 Remove unnecessary cast.
4043 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4044 (parse_symbol, parse_type, upgrade_type, parse_external)
4045 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4046 unnecessary cast.
4047 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4048
730ead81
TT
40492019-06-16 Tom Tromey <tom@tromey.com>
4050
4051 * tui/tui-data.c (tui_alloc_generic_win_info)
4052 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4053 checks.
4054
584a927c
AB
40552019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4056 Andrew Burgess <andrew.burgess@embecosm.com>
4057
4058 * f-typeprint.c (f_print_type): Don't return early for not
4059 associated or not allocated types.
4060 (f_type_print_varspec_suffix): Add print_rank parameter and print
4061 ranks of array types in case they dangling.
4062 (f_type_print_base): Add print_rank parameter.
4063
30056ea0
AB
40642019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4065
4066 * NEWS: Mention new MI commands.
4067 * break-catch-throw.c (enum exception_event_kind): Move to
4068 breakpoint.h.
4069 (print_mention_exception_catchpoint): Output text as a single
4070 message.
4071 (catch_exception_command_1): Rename to...
4072 (catch_exception_event): ...this, make non-static, update header
4073 command, and change some parameter types.
4074 (catch_catch_command): Update for changes to
4075 catch_exception_command_1.
4076 (catch_throw_command): Likewise.
4077 (catch_rethrow_command): Likewise.
4078 * breakpoint.c (enum exception_event_kind): Delete.
4079 * breakpoint.h (enum exception_event_kind): Moved here from
4080 break-catch-throw.c.
4081 (catch_exception_event): Declare.
4082 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4083 (mi_cmd_catch_throw): New function.
4084 (mi_cmd_catch_rethrow): New function.
4085 (mi_cmd_catch_catch): New function.
4086 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4087 'catch-catch' entries.
4088 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4089 (mi_cmd_catch_rethrow): Declare.
4090 (mi_cmd_catch_catch): Declare.
4091
ec8e2b6d
AB
40922019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4093
4094 * annotate.c (annotate_source_line): Change return type to void,
4095 update implementation to match.
4096 * annotate.h (annotate_source_line): Change return type to void,
4097 update header comment.
4098 * stack.c (print_frame_info): Don't change what frame information
4099 is printed based on whether annotations are on or not.
4100
0d3abd8c
AB
41012019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4102
4103 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4104 (annotate_source): Make static.
4105 (annotate_source_line): Moved from source.c and renamed from
4106 identify_source_line. Update the return type.
4107 * annotate.h (annotate_source): Delete declaration.
4108 (annotate_source_line): Declaration moved from source.h, and
4109 renamed from identify_source_line. Return type updated.
4110 * source.c (identify_source_line): Moved to annotate.c and renamed
4111 to annotate_source_line.
4112 (info_line_command): Remove check of annotation_level.
4113 * source.h (identify_source_line): Move declaration to annotate.h
4114 and rename to annotate_source_line.
4115 * stack.c: Add 'annotate.h' include.
4116 (print_frame_info): Remove check of annotation_level before
4117 calling annotate_source_line.
4118
00df30ae
AB
41192019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4120
4121 * source-cache.c (source_cache::get_plain_source_lines): Use
4122 open_source_file_with_line_charpos instead of just
4123 open_source_file, remove call to find_source_lines.
4124 (source_cache::get_source_lines): Likewise.
4125 * source.c (find_source_lines): Make static.
4126 (get_filename_and_charpos): Renamed into...
4127 (open_source_file_with_line_charpos): ..this along with changes to
4128 return a scoped_fd, and some other minor clean ups.
4129 (identify_source_line): Use open_source_file_with_line_charpos.
4130 (search_command_helper): Use open_source_file_with_line_charpos
4131 instead of just open_source_file, remove call to
4132 find_source_lines.
4133 * source.h (open_source_file_with_line_charpos): Declare new
4134 function.
4135 (find_source_lines): Delete declaration.
4136
afda45a2
AB
41372019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4138
4139 * source.c (get_filename_and_charpos): Remove fullname
4140 parameter.
4141 (identify_source_line): Update call to get_filename_and_charpos.
4142
0735b091
TT
41432019-06-14 Tom Tromey <tromey@adacore.com>
4144
4145 PR gdb/24502:
4146 * ui-style.h (skip_ansi_escape): Update comment.
4147 * ui-file.h (class no_terminal_escape_file): New class.
4148 * ui-file.c (no_terminal_escape_file::write)
4149 (no_terminal_escape_file::puts): New methods.
4150 * cli/cli-logging.c (handle_redirections): Use
4151 no_terminal_escape_file.
4152
52ce35e2
TT
41532019-06-14 Tom Tromey <tromey@adacore.com>
4154
4155 * NEWS: Move convenience variable news above Python news.
4156
73cc7272
TT
41572019-06-14 Tom Tromey <tom@tromey.com>
4158
4159 * gnulib: Move directory to top-level.
4160 * configure.ac: Don't configure gnulib.
4161 * configure: Rebuild.
4162 * common/common-defs.h: Use new path to gnulib.
4163 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4164 (GNULIB_H): Remove.
4165 (INCGNU): Look in new gnulib location.
4166 (HFILES_NO_SRCDIR): Remove gnulib files.
4167 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4168 (generated_files): Remove GNULIB_H.
4169 ($(LIBGNU), all-lib): Remove targets.
4170 (distclean): Don't mention GNULIB_BUILDDIR.
4171 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4172
f5686554
TT
41732019-06-14 Tom Tromey <tromey@adacore.com>
4174
4175 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4176 Warn if symbol file does not provide any symbols.
4177
a0c1ffed
TT
41782019-06-14 Tom Tromey <tromey@adacore.com>
4179
4180 * source.c (find_and_open_source): Respect basenames_may_differ.
4181
7c39e397
AB
41822019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4183
4184 * annotate.c (annotate_breakpoints_invalid): Make use of
4185 scoped_restore_terminal_state.
4186 (annotate_frames_invalid): Likewise.
4187
f411722c
TT
41882019-06-14 Tom Tromey <tromey@adacore.com>
4189
4190 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4191 allow assignment to an internalvar.
4192
4268ec18
TT
41932019-06-14 Tom Tromey <tromey@adacore.com>
4194
4195 * ada-lex.l: Allow "_" in attribute names.
4196
abdb711e
TT
41972019-06-14 Tom Tromey <tromey@adacore.com>
4198
4199 PR gdb/24653:
4200 * regcache.c (registers_changed): Don't call alloca.
4201 * top.c (execute_command): Don't call alloca.
4202
4c048731
PA
42032019-06-13 Pedro Alves <palves@redhat.com>
4204
4205 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4206 'expression'. When parsing an expression, error out if there's
4207 junk after "unlimited".
4208 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4209 (do_set_command): Adjust calls to is_unlimited_literal.
4210
66eb1ed3
PA
42112019-06-13 Pedro Alves <palves@redhat.com>
4212
4213 * compile/compile.c (make_compile_options_def_group): Add braces
4214 around array_view initializer.
4215 * thread.c (make_thread_apply_all_options_def_group)
4216 (make_thread_apply_all_options_def_group): Likewise.
4217
3345721a
PA
42182019-06-13 Pedro Alves <palves@redhat.com>
4219
4220 * NEWS (New commands): Mention "maint test-options
4221 require-delimiter", "maint test-options unknown-is-error", "maint
4222 test-options unknown-is-operand" and "maint show
4223 test-options-completion-result".
4224 (New command options, command completion): New section.
4225 (Completion improvements): New section.
4226 Mention that you can abbreviate "unlimited".
4227
6206060d
PA
42282019-06-13 Pedro Alves <palves@redhat.com>
4229
4230 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4231 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4232 * unittests/cli-utils-selftests.c (test_parse_flags)
4233 (test_parse_flags_qcs): Delete.
4234 (test_cli_utils): Don't call deleted functions.
4235
6665660a
PA
42362019-06-13 Pedro Alves <palves@redhat.com>
4237
4238 * thread.c: Include "cli/cli-option.h".
4239 (tp_array_compar_ascending): Global.
4240 (tp_array_compar): Delete function.
4241 (tp_array_compar_ascending, tp_array_compar_descending): New
4242 functions.
4243 (ascending_option_def, qcs_flag_option_def)
4244 (thr_qcs_flags_option_defs)
4245 (make_thread_apply_all_options_def_group)
4246 (make_thread_apply_options_def_group): New.
4247 (thread_apply_all_command): Use gdb::option::process_options.
4248 (thread_apply_command_completer)
4249 (thread_apply_all_command_completer): New.
4250 (thread_apply_command): Use gdb::option::process_options.
4251 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4252 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4253 to generate help text of "thread apply". Adjust "taas"'s help.
4254 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4255 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4256
f7e13587
PA
42572019-06-13 Pedro Alves <palves@redhat.com>
4258
4259 * thread.c (thread_apply_command): Check for invalid TID with
4260 isdigit instead of !isalpha.
4261
5d707134
PA
42622019-06-13 Pedro Alves <palves@redhat.com>
4263
4264 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4265 (validate_flags_qcs): New.
4266 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4267 (validate_flags_qcs): Declare.
4268 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4269 (make_frame_apply_options_def_group): New.
4270 (frame_apply_command_count): Process options with
4271 gdb::option::process_options.
4272 (frame_apply_completer): New.
4273 (frame_apply_level_completer, frame_apply_all_completer)
4274 (frame_apply_completer): New.
4275 (_initialize_stack): Update help of "frame apply", "frame apply
4276 level", "frame apply all" and "faas" to mention supported options
4277 and install command completers.
4278 * stack.h (frame_apply_all_completer): Declare.
4279 * thread.c: Include "stack.h".
4280 (tfaas_command): Add "--".
4281 (_initialize_thread): Update help "tfaas" to mention supported
4282 options and install command completer.
4283
272d4594
PA
42842019-06-13 Pedro Alves <palves@redhat.com>
4285
4286 * completer.c (complete_nested_command_line): New.
4287 (gdb_completion_word_break_characters_throw): Add assertion.
4288 * completer.h (complete_nested_command_line): Declare.
4289
90a1ef87
PA
42902019-06-13 Pedro Alves <palves@redhat.com>
4291
4292 * stack.c (parse_backtrace_qualifiers): New.
4293 (backtrace_command): Use it.
4294 (backtrace_command_completer): Complete on qualifiers.
4295
d4c16835
PA
42962019-06-13 Pedro Alves <palves@redhat.com>
4297
4298 * frame.c: Include "cli/cli-option.h.
4299 (user_set_backtrace_options): New.
4300 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4301 Delete.
4302 (get_prev_frame): Adjust.
4303 (boolean_option_def, uinteger_option_def)
4304 (set_backtrace_option_defs): New.
4305 (_initialize_frame): Adjust and use
4306 gdb::option::add_setshow_cmds_for_options to install "set
4307 backtrace past-main" and "set backtrace past-entry".
4308 * frame.h: Include "cli/cli-option.h".
4309 (struct frame_print_options): Forward declare.
4310 (print_frame_arguments_all, print_frame_arguments_scalars)
4311 (print_frame_arguments_none): Declare.
4312 (print_entry_values): Delete declaration.
4313 (struct frame_print_options, user_frame_print_options): New.
4314 (struct set_backtrace_options): New.
4315 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4316 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4317 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4318 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4319 (list_args_or_locals): Add frame_print_options parameter.
4320 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4321 * python/py-framefilter.c (enumerate_args): Pass down
4322 USER_FRAME_PRINT_OPTIONS.
4323 * stack.c: Include "cli/cli-option.h".
4324 (print_frame_arguments_all, print_frame_arguments_scalars)
4325 (print_frame_arguments_none): Declare.
4326 (print_raw_frame_arguments, print_entry_values): Delete.
4327 (user_frame_print_options): New.
4328 (boolean_option_def, enum_option_def, frame_print_option_defs):
4329 New.
4330 (struct backtrace_cmd_options): New.
4331 (bt_flag_option_def): New.
4332 (backtrace_command_option_defs): New.
4333 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4334 (print_frame_arg, read_frame_arg, print_frame_args)
4335 (print_frame_info, print_frame): Add frame_print_options parameter
4336 and use it.
4337 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4338 (backtrace_command_1): Add frame_print_options and
4339 backtrace_cmd_options parameters and use them.
4340 (make_backtrace_options_def_group): New.
4341 (backtrace_command): Process command options with
4342 gdb::option::process_options.
4343 (backtrace_command_completer): New.
4344 (_initialize_stack): Extend "backtrace"'s help to mention
4345 supported options. Install completer for "backtrace".
4346 Install some settings commands with add_setshow_cmds_for_options.
4347
2daf894e
PA
43482019-06-13 Pedro Alves <palves@redhat.com>
4349
4350 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4351 and that "set/show print raw frame-arguments" are now deprecated.
4352
4353 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4354 command.
4355 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4356 * stack.c (_initialize_stack): Install "set/show print
4357 raw-frame-arguments", and deprecate "set/show print raw
4358 frame-arguments".
4359 * valprint.c (_initialize_valprint): Deprecate "set/show print
4360 raw".
4361
e6ed716c
PA
43622019-06-13 Pedro Alves <palves@redhat.com>
4363
4364 * compile/compile.c (struct compile_options): New.
4365 (compile_flag_option_def, compile_command_option_defs)
4366 (make_compile_options_def_group): New.
4367 (compile_file_command): Handle options with
4368 gdb::option::process_options.
4369 (compile_file_command_completer): New function.
4370 (compile_code_command): Handle options with
4371 gdb::option::process_options.
4372 (compile_code_command_completer): New function.
4373 (_initialize_compiler): Install completers for "compile code" and
4374 "compile file". Mention available options in "compile code" and
4375 "compile code"'s help.
4376 * completer.c (advance_to_completion_word): New, factored out from
4377 ...
4378 (advance_to_expression_complete_word_point): ... this.
4379 (advance_to_filename_complete_word_point): New.
4380 * completer.h (advance_to_filename_complete_word_point): New
4381 declaration.
4382
7d8062de
PA
43832019-06-13 Pedro Alves <palves@redhat.com>
4384
4385 * compile/compile.c: Include "cli/cli-option.h".
4386 (compile_print_value): Scope data pointer is now a
4387 value_print_options pointer; adjust.
4388 (compile_print_command): Process options. Scope data pointer is
4389 now a value_print_options pointer; adjust.
4390 (_initialize_compile): Update "compile print"'s help to include
4391 supported options. Install a completer for "compile print".
4392 * cp-valprint.c (show_vtblprint, show_objectprint)
4393 (show_static_field_print): Delete.
4394 (_initialize_cp_valprint): Don't install "set print
4395 static-members", "set print vtbl", "set print object" here.
4396 * printcmd.c: Include "cli/cli-option.h" and
4397 "common/gdb_optional.h".
4398 (print_command_parse_format): Rework to fill in a
4399 value_print_options instead of a format_data.
4400 (print_value): Change parameter type from format_data pointer to
4401 value_print_options reference. Adjust.
4402 (print_command_1): Process options. Adjust to pass down a
4403 value_print_options.
4404 (print_command_completer): New.
4405 (_initialize_printcmd): Install print_command_completer as
4406 handle_brkchars completer for the "print" command. Update
4407 "print"'s help to include supported options.
4408 * valprint.c: Include "cli/cli-option.h".
4409 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4410 here from cp-valprint.c.
4411 (boolean_option_def, uinteger_option_def)
4412 (value_print_option_defs, make_value_print_options_def_group):
4413 New. Use gdb::option::add_setshow_cmds_for_options to install
4414 "set print elements", "set print null-stop", "set print repeats",
4415 "set print pretty", "set print union", "set print array", "set
4416 print address", "set print symbol", "set print array-indexes".
4417 * valprint.h: Include <string> and "cli/cli-option.h".
4418 (make_value_print_options_def_group): Declare.
4419 (print_value): Change parameter type from format_data pointer to
4420 value_print_options reference.
4421 (print_command_completer): Declare.
4422
9d0faba9
PA
44232019-06-13 Pedro Alves <palves@redhat.com>
4424
4425 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4426 (COMMON_SFILES): Add maint-test-settings.c.
4427 * cli/cli-decode.c (boolean_enums): New global, factored out from
4428 ...
4429 (add_setshow_boolean_cmd): ... here.
4430 * cli/cli-decode.h (boolean_enums): Declare.
4431 * cli/cli-option.c: New file.
4432 * cli/cli-option.h: New file.
4433 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4434 factored out from ...
4435 (parse_cli_boolean_value(const char *)): ... this.
4436 (is_unlimited_literal): Change parameter type to pointer to
4437 pointer. Adjust and advance ARG pointer.
4438 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4439 (parse_cli_var_enum): New, factored out from ...
4440 (do_set_command): ... this. Adjust.
4441 * cli/cli-setshow.h (parse_cli_boolean_value)
4442 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4443 (parse_cli_var_enum): Declare.
4444 * cli/cli-utils.c: Include "cli/cli-option.h".
4445 (get_ulongest): New.
4446 * cli/cli-utils.h (get_ulongest): Declare.
4447 (check_for_argument): New overloads.
4448 * maint-test-options.c: New file.
4449
2c722807
PA
44502019-06-13 Pedro Alves <palves@redhat.com>
4451
4452 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4453 parse a range if "-" is at the end of the string.
4454
dee7b4c8
PA
44552019-06-13 Pedro Alves <palves@redhat.com>
4456
4457 * cli/cli-setshow.c (parse_auto_binary_operation)
4458 (parse_cli_boolean_value): Don't allow "o".
4459
dca0f6c0
PA
44602019-06-13 Pedro Alves <palves@redhat.com>
4461
4462 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4463 * NEWS: Mention maint test-settings KIND.
4464 * maint-test-settings.c: New file.
4465
597bf39d
PA
44662019-06-13 Pedro Alves <palves@redhat.com>
4467
4468 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4469 completer.
4470 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4471 "set" completers.
4472
48c410fb
PA
44732019-06-13 Pedro Alves <palves@redhat.com>
4474
4475 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4476 after item.
4477
93bcb043
PA
44782019-06-13 Pedro Alves <palves@redhat.com>
4479
4480 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4481
cbba3ecd
PA
44822019-06-13 Pedro Alves <palves@redhat.com>
4483
4484 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4485 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4486 call.
4487 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4488 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4489 calls.
4490 (check_for_argument): Skip spaces after argument.
4491
b9a3f842
PA
44922019-06-13 Pedro Alves <palves@redhat.com>
4493
4494 * thread.c (thread_apply_command): Adjust TID parsing.
4495 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4496 detected before end of string.
4497 (tid_is_in_list): Error out if LIST is invalid.
4498
3844e605
PA
44992019-06-13 Pedro Alves <palves@redhat.com>
4500
4501 * completer.c (complete_line_internal_1): Rewind completion word
4502 point.
4503 (completion_tracker::advance_custom_word_point_by): Change
4504 parameter type to int.
4505 * completer.h (completion_tracker::advance_custom_word_point_by):
4506 Likewise.
4507
00b56dbe
PA
45082019-06-13 Pedro Alves <palves@redhat.com>
4509
4510 * completer.c (advance_to_completion_word): Handle delimiters.
4511
d106773e
PA
45122019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4513
4514 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4515
08f10e02
TT
45162019-06-11 Tom Tromey <tom@tromey.com>
4517
4518 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4519 (xmalloc_failed): Move to alloc.c.
4520 * alloc.c: New file.
4521 * Makefile.in (COMMON_SFILES): Add alloc.c.
4522
1c7fe951
TT
45232019-06-11 Tom Tromey <tom@tromey.com>
4524
4525 * nat/linux-waitpid.c: Don't include server.h.
4526 (linux_debug): Remove.
4527 (my_waitpid): Update.
4528
89549d7f
TT
45292019-06-11 Tom Tromey <tromey@adacore.com>
4530
4531 * infcall.c (_initialize_infcall): Remove trailing newline from
4532 help.
4533 * user-regs.c (_initialize_user_regs): Remove trailing newline
4534 from help.
4535 * typeprint.c (_initialize_typeprint): Remove trailing newline
4536 from help.
4537 * reverse.c (_initialize_reverse): Remove trailing newlines from
4538 help.
4539 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4540 from help.
4541 * language.c (add_set_language_command): Remove trailing newline
4542 from help.
4543 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4544 help.
4545 * disasm.c (_initialize_disasm): Remove trailing newline from
4546 help.
4547 * top.c (init_main): Remove trailing newline from help.
4548 * interps.c (_initialize_interpreter): Remove trailing newline
4549 from help.
4550 * btrace.c (_initialize_btrace): Remove trailing newlines from
4551 help.
4552 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4553 from help.
4554 * python/python.c (_initialize_python): Remove trailing newline
4555 from help.
4556 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4557 help.
4558 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4559 from help. Reformat some text.
4560 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4561 from help.
4562 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4563 newline from help.
4564
86108c13
TT
45652019-06-11 Tom Tromey <tromey@adacore.com>
4566
4567 * darwin-nat.c (darwin_decode_exception_message)
4568 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4569
a7067863
AB
45702019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4571
4572 * valops.c (value_slice): Check for not allocated or not
4573 associated values.
4574
9ab08412
TV
45752019-06-10 Tom de Vries <tdevries@suse.de>
4576
4577 PR gdb/24618
4578 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4579 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4580 invalid.
4581
f19e22e9
TV
45822019-06-10 Tom de Vries <tdevries@suse.de>
4583
4584 PR gdb/24611
4585 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4586 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4587
e99f9db0
TV
45882019-06-10 Tom de Vries <tdevries@suse.de>
4589
4590 PR symtab/24545
4591 * symtab.c (struct demangled_name_entry): Add language field.
4592 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4593 static minimal symbol". Set and use language field.
4594
9bf7038b
TT
45952019-06-10 Tom Tromey <tromey@adacore.com>
4596
4597 * ada-lang.c (_initialize_ada_language): Update help text.
4598
422186a9
TT
45992019-06-10 Tom Tromey <tromey@adacore.com>
4600
4601 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4602 with a newline.
4603 * guile/guile.c (handle_boot_error): Don't end warning with a
4604 newline.
4605 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4606 warning with a newline.
4607 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4608 newline.
4609 (s12z_frame_cache): Likewise.
4610 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4611 a newline.
4612 * solib-svr4.c (disable_probes_interface): Don't end warning with
4613 a newline.
4614 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4615 newline.
4616 * python/python.c (do_finish_initialization): Don't end warning
4617 with a newline.
4618
25ce02ee
TT
46192019-06-10 Tom Tromey <tom@tromey.com>
4620
4621 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4622 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4623 gdbpy_enter.
4624
caa429d8
TT
46252019-06-10 Tom Tromey <tromey@adacore.com>
4626
4627 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4628 data.
4629 (elf_new_init): Don't call stabsread_new_init.
4630 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4631 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4632 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4633
81873cc8
TV
46342019-06-10 Tom de Vries <tdevries@suse.de>
4635
4636 PR symtab/16264
4637 PR symtab/24517
4638 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4639
4fa0265e
РИ
46402019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4641
4642 * source.c (find_and_open_source): Also rewrite relative file
4643 names.
4644
1a3da2cd
AB
46452019-04-26 Amos Bird <amosbird@gmail.com>
4646
4647 * annotate.c (annotate_thread_exited): Add "thread-exited"
4648 annotation.
4649
3847a7bf
TT
46502019-06-06 Tom Tromey <tromey@adacore.com>
4651
4652 * maint.h (class scoped_command_stats): Use
4653 DISABLE_COPY_AND_ASSIGN.
4654 <print_time>: New method.
4655 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4656 print_time.
4657 (scoped_command_stats::print_time): New method.
4658
312617a3
AB
46592019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4660
4661 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4662 instructions of lengths 6 or 8 bytes.
4663
b02f78f9
PA
46642019-06-04 Pedro Alves <palves@redhat.com>
4665
4666 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4667
4668 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4669 * breakpoint.c (condition_completer): Likewise.
4670 * cli/cli-dump.c (scan_expression): Likewise.
4671 * common/filestuff.c (mkdir_recursive): Likewise.
4672 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4673 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4674 (gdb_abspath): Likewise.
4675 * compile/compile-cplus-types.c
4676 (compile_cplus_instance::decl_name): Likewise.
4677 * completer.c (complete_explicit_location):
4678 (signal_completer, reg_or_group_completer_1): Likewise.
4679 * cp-support.c (cp_remove_params_if_any): Likewise.
4680 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4681 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4682 * infcmd.c (strip_bg_char): Likewise.
4683 * linespec.c (copy_token_string): Likewise.
4684 * mi/mi-main.c (output_cores): Likewise.
4685 * psymtab.c (psymtab_search_name):
4686 * symfile.c (test_set_ext_lang_command): Likewise.
4687 * target.c (target_fileio_read_stralloc): Likewise.
4688 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4689 * value.c (complete_internalvar): Likewise.
4690
e1f2e1a2
CB
46912019-06-04 Christian Biesinger <cbiesinger@google.com>
4692
4693 Add objfile property to gdb.Type.
d3238f7d
PA
4694 * NEWS: Mention Python API addition.
4695 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 4696
e664d728
PW
46972019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4698
4699 * NEWS: Mention the new set|show style [title|highlight].
4700 Mention changes to "show style", "help" and "apropos".
4701
66d8c862
PW
47022019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4703
4704 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4705 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4706 instead of print_help_for_command.
4707 (print_doc_of_command): New function.
4708 (help_list): Add 'apropos -v word' suggestion.
4709 (print_help_for_command): Style the command name using title style.
4710 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4711 (_initialize_cli_cmds): Describe -v in apropos_command help.
4712
9303eb2f
PW
47132019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4714
4715 * cli/cli-style.h (cli_style_option): Add name in constructor,
4716 add m_name class member, add constructor with intensity,
4717 add name class function.
4718 (cli_style_option::add_setshow_commands): Remove name argument.
4719 (highlight_style, title_style): New styles.
4720 * cli/cli-style.c (do_show): New function that shows a style
4721 characteristic styling the style name with itself.
4722 (set_style_name): New function.
4723 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4724 Update all callers according to the changes in cli/cli-style.h.
4725 * utils.h (fputs_highlighted): New function.
4726 * utils.c (fputs_highlighted): Likewise.
4727
e2c52041
PW
47282019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4729
4730 * NEWS: Mention new pipe command and new convenience variables.
4731
947d3946
PW
47322019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4733
4734 * cli/cli-cmds.c (pipe_command): New function.
4735 (_initialize_cli_cmds): Call add_com for pipe_command.
4736 Define | as an alias for pipe.
4737 (exit_status_set_internal_vars): New function.
4738 (shell_escape): Call exit_status_set_internal_vars.
4739 cli/cli-decode.c (find_command_name_length): Recognize | as
4740 a single character command.
4741
b8fd0918
PW
47422019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4743
4744 * gdbcmd.h (execute_command_to_ui_file): New declaration.
4745 top.c (execute_command_to_ui_file): New function, mostly a copy
4746 of execute_command_to_string.
4747 (execute_command_to_string): Implement by calling
4748 execute_command_to_ui_file.
4749
68bb5386
PW
47502019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4751
4752 * top.h (saved_command_line): Remove declaration.
4753 * top.c (previous_saved_command_line, previous_repeat_arguments):
4754 New variables.
4755 (saved_command_line): Make static, define together with other
4756 'repeat variables'.
4757 (dont_repeat): Clear repeat_arguments.
4758 (repeat_previous, get_saved_command_line, save_command_line):
4759 New functions.
4760 (gdb_init): Initialize saved_command_line
4761 and previous_saved_command_line.
4762 * main.c (captured_main_1): Remove saved_command_line initialization.
4763 * event-top.c (handle_line_of_input): Update to use
4764 the new 'repeat' related functions instead of direct access to
4765 saved_command_line.
4766 * command.h (repeat_previous, get_saved_command_line,
4767 save_command_line): New declarations.
4768 (dont_repeat): Add comment.
4769
bfcdb852
TT
47702019-05-30 Tom Tromey <tromey@adacore.com>
4771
4772 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4773 Fix comment.
4774 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4775
0ef209f2
JV
47762019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
4777
4778 PR cli/24587
4779 * completer.c (complete): Initialize variable word.
4780
955b06fa
SDJ
47812019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
4782
4783 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4784 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4785 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4786 'body' is NULL to the outter 'if', protecting the '!is_define'
4787 situation as well.
4788
fa9c3fa0
TT
47892019-05-29 Tom Tromey <tromey@adacore.com>
4790
4791 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4792 (dwarf_unknown): New function.
4793 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4794 (dwarf_type_encoding_name): Use dwarf_unknown.
4795
4330d61d
TT
47962019-05-29 Tom Tromey <tromey@adacore.com>
4797
4798 PR c++/20020:
4799 * cp-valprint.c (cp_print_value_fields): Call
4800 cp_print_static_field inside "try".
4801
33a6bc35
TT
48022019-05-29 Tom Tromey <tromey@adacore.com>
4803
4804 * inflow.c (struct terminal_info): Add default operator=.
4805 * configure: Rebuild.
4806 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4807 -Wdeprecated-copy-dtor, -Wredundant-move.
4808
000439d5
TT
48092019-05-29 Tom Tromey <tromey@adacore.com>
4810
4811 * NEWS: Add entry.
4812 * infcmd.c (print_return_value_1): Handle finish_print
4813 option.
4814 (show_print_finish): New function.
4815 (_initialize_infcmd): Add "set/show print finish" commands.
4816 * valprint.c (user_print_options): Initialize new member.
4817 * valprint.h (struct value_print_options) <finish_print>: New
4818 member.
4819
c0e70c62
TT
48202019-05-28 Tom Tromey <tromey@adacore.com>
4821
4822 * ada-lang.c (ada_remove_Xbn_suffix)
4823 (find_old_style_renaming_symbol)
4824 (parse_old_style_renaming): Remove.
4825 (ada_find_renaming_symbol): Don't call
4826 find_old_style_renaming_symbol.
4827 (ada_is_renaming_symbol): Rename from
4828 ada_find_renaming_symbol. Remove "block" parameter. Return
4829 bool. Now static.
4830 (ada_read_var_value): Update and simplify.
4831 * ada-exp.y (write_var_or_type): Remove old code.
4832
766f8836
AH
48332019-05-28 Alan Hayward <alan.hayward@arm.com>
4834
4835 * event-top.c: Remove include comment.
4836 * inflow.c (class scoped_ignore_sigttou): Move from here...
4837 * inflow.h (class scoped_ignore_sigttou): ...to here.
4838 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4839 * top.c: Remove include comment.
4840
eb41253a
TT
48412019-05-27 Tom Tromey <tom@tromey.com>
4842
4843 * NEWS: Fix typo.
4844
4ca51187
TT
48452019-05-22 Tom Tromey <tromey@adacore.com>
4846
4847 * target.c (target_follow_exec): Constify parameter.
4848 * target-delegates.c: Rebuild.
4849 * remote.c (remote_target::follow_exec): Constify parameter.
4850 * infrun.c (follow_exec): Constify parameter.
4851 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4852 (target_follow_exec): Likewise.
4853
8fca4da0
AH
48542019-05-22 Alan Hayward <alan.hayward@arm.com>
4855
4856 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4857 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4858
b7060614
AH
48592019-05-22 Alan Hayward <alan.hayward@arm.com>
4860
4861 * NEWS: Add debugredirect and testsuite sections.
4862
0a5954bd
SC
48632019-05-22 Simon Cook <simon.cook@embecosm.com>
4864
4865 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4866 target descriptions using exclusively floating point register name
4867 aliases.
4868
dc42e902
AB
48692019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4870
4871 PR gdb/18644:
4872 * f-lang.c (build_fortran_types): Handle the case where
4873 gdbarch_floatformat_for_type returns a nullptr.
4874
fb7806c7
TV
48752019-05-21 Tom de Vries <tdevries@suse.de>
4876
4877 PR cli/24587
4878 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4879
34d11c68
AB
48802019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4881
4882 PR gdb/18644:
4883 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4884 16-byte floats.
4885 * i386-tdep.c (i386_floatformat_for_type): Use
4886 floatformats_ia64_quad for the 16-byte floating point component
4887 within a fortran 32-byte complex number.
4888
122cf0f2
AB
48892019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4890
4891 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4892 delete default constructor.
4893 (find_partial_die): Update to return const struct.
4894 (partial_die_parent_scope): Move variable declaration into scope
4895 of its use and change its type to auto.
4896 (guess_partial_die_structure_name): Likewise.
4897 (partial_die_info::fixup): Likewise.
4898
33d0e35a
TT
48992019-05-17 Tom Tromey <tromey@adacore.com>
4900
4901 * source.c (find_and_open_source): Remove cast.
4902
a45575b0
TT
49032019-05-17 Tom Tromey <tromey@adacore.com>
4904
4905 * annotate.c (annotate_source): Make "filename" const.
4906 * annotate.h (annotate_source): Use const.
4907
81f47ac2
AH
49082019-05-17 Alan Hayward <alan.hayward@arm.com>
4909
4910 * disasm.c (set_disassembler_options): Send errors to stderr.
4911
ca1285d1
AH
49122019-05-17 Alan Hayward <alan.hayward@arm.com>
4913
4914 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4915 (cli_interp_base::set_logging): Check debug_redirect.
4916 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4917 * cli/cli-logging.c (debug_redirect): Add static variable.
4918 (pop_output_files): Add default param.
4919 (handle_redirections): Print debug setting.
4920 (show_logging_command): Likewise.
4921 (_initialize_cli_logging): Add debugredirect command.
4922 * interps.c (current_interp_set_logging): Add debug_redirect
4923 parameter.
4924 * interps.h (set_logging): Add debug_redirect parameter.
4925 (current_interp_set_logging): Likewise.
4926 * mi/mi-common.h: Likewise.
4927 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4928
49292019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
4930 Tom Tromey <tromey@adacore.com>
4931
4932 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4933 directly.
4934 * cli/cli-interp.h (make_logging_output): Remove declaration.
4935 * cli/cli-logging.c (make_logging_output): Remove function.
4936 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4937 directly.
4938 * ui-file.c (tee_file::tee_file): Remove bools.
4939 (tee_file::~tee_file): Remove deletes.
4940 * ui-file.h (tee_file): Remove bools.
4941
26648588
JV
49422019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4943
4944 * mi/mi-cmds.h (mi_cmd_complete): New function.
4945 * mi/mi-main.c (mi_cmd_complete): Likewise.
4946 * mi/mi-cmds.c: Define new MI command -complete.
4947 * NEWS: Mention new -complete command.
4948
6e035501
JV
49492019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4950
4951 * completer.h (complete): New function.
4952 * completer.c (complete): Likewise.
4953 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4954 function defined in completer.h.
4955
7d0e2ece
JV
49562019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4957
e79be6e5 4958 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 4959
fb816e8b
TV
49602019-05-17 Tom de Vries <tdevries@suse.de>
4961
4962 PR gdb/24094
4963 * dwarf2read.c (struct cu_partial_die_info): New struct.
4964 (find_partial_die): Return cu_partial_die_info.
4965 (partial_die_parent_scope, guess_partial_die_structure_name)
4966 (partial_die_info::fixup): Handle new return type of find_partial_die.
4967
677052f2
SDJ
49682019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4969
4970 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4971 "std::string", simplifying the algorithm.
4972
f3da9116
SDJ
49732019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4974
4975 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4976 (stap_static_probe_ops::get_probes): Likewise.
4977
f1bb75ab
SDJ
49782019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4979
4980 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4981 '-')" and "else if".
4982 (stap_parse_single_operand): Join checks for
4983 "gdbarch_stap_parse_special_token_p" and
4984 "gdbarch_stap_parse_special_token" in the same "if" statement.
4985 Invert check when verifying for operation on register
4986 displacement.
4987
3ca58cde
SDJ
49882019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4989
4990 * stap-probe.c (stap_get_opcode): Update comment.
4991 (stap_get_expected_argument_type): Likewise.
4992 (handle_stap_probe): Likewise.
4993
af2d9bee
SDJ
49942019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4995
4996 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4997 return type to 'bool'. Adjust comment. Use 'bool' when
4998 appropriate.
4999 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5000 * stap-probe.c (stap_parse_argument_1): Likewise.
5001 (stap_is_operator): Likewise.
5002 (stap_is_generic_prefix): Likewise.
5003 (stap_is_register_prefix): Likewise.
5004 (stap_is_register_indirection_prefix): Likewise.
5005 (stap_is_integer_prefix): Likewise.
5006 (stap_generic_check_suffix): Likewise.
5007 (stap_check_integer_suffix): Likewise.
5008 (stap_check_register_suffix): Likewise.
5009 (stap_check_register_indirection_suffix): Likewise.
5010 (stap_parse_register_operand): Likewise.
5011 (stap_parse_single_operand): Likewise.
5012 (stap_parse_argument_1): Likewise.
5013 (stap_probe::get_argument_count): Likewise.
5014 (stap_is_operator): Likewise.
5015
61c9c421
TT
50162019-05-16 Tom Tromey <tromey@adacore.com>
5017
5018 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5019 keyword to foreach.
5020
9ddc1af1
SM
50212019-05-15 Simon Marchi <simon.marchi@efficios.com>
5022
5023 * linux-thread-db.c (try_thread_db_load_1): Change return type
5024 to bool.
5025 (try_thread_db_load): Likewise.
5026 (try_thread_db_load_from_pdir_1): Likewise.
5027 (try_thread_db_load_from_pdir): Likewise.
5028 (try_thread_db_load_from_sdir): Likewise.
5029 (try_thread_db_load_from_dir): Likewise.
5030 (thread_db_load_search): Likewise.
5031 (has_libpthread): Likewise.
5032 (thread_db_load): Likewise.
5033
7bede828
SDJ
50342019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5035
5036 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5037 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5038 NULL, and complain/return if that's the case.
5039
c5358db4
JD
50402019-05-15 John Darrington <john@darrington.wattle.id.au>
5041
5042 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5043 (advance, posn, abstract_read_memory): New functions.
5044 [struct mem_read_abstraction]: New struct.
5045 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5046
c408a94f
TT
50472019-05-14 Tom Tromey <tromey@adacore.com>
5048
5049 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5050 value is not lval_memory.
5051
e7bd7fba
TT
50522019-05-14 Tom Tromey <tromey@adacore.com>
5053
5054 * solib.c (info_sharedlibrary_command): Style the file name.
5055
a6d0f249
AH
50562019-05-14 Alan Hayward <alan.hayward@arm.com>
5057
5058 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5059 (aarch64_vnv_type): Likewise.
5060 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5061 * common/tdesc.c: Likewise.
5062 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5063 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5064 * features/aarch64-fpu.xml: Add ieee half view.
5065 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5066 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5067 * gdbtypes.h (struct builtin_type): Likewise.
5068 (struct objfile_type): Likewise.
5069
66b8bb74
SM
50702019-05-12 Paul Naert <paul.naert@polymtl.ca>
5071
5072 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5073 typo.
5074 * location.h (string_to_event_location): Likewise.
5075
21c219fd
JB
50762019-05-11 Joel Brobecker <brobecker@adacore.com>
5077
5078 GDB 8.3 released.
5079
13674803
SM
50802019-05-10 Simon Marchi <simon.marchi@efficios.com>
5081
5082 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5083 New variable declaration.
5084 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5085 New variable.
5086 (print_one_breakpoint): Use ui_out::test_flags and new global
5087 variable to compute use_fixed_output.
5088 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5089 Remove.
5090 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5091 (mi_multi_location_breakpoint_output_fixed): Remove.
5092 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5093 new variable.
5094 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5095 fix_multi_location_breakpoint_output flag if version >= 3.
5096 * ui-out.h (enum ui_out_flag)
5097 <fix_multi_location_breakpoint_output>: New enumerator.
5098
a9eac7f9
SM
50992019-05-10 Simon Marchi <simon.marchi@efficios.com>
5100
5101 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5102
71bed2db
TT
51032019-05-10 Tom Tromey <tromey@adacore.com>
5104
5105 * ada-lang.c (catch_ada_completer): New function.
5106 (_initialize_ada_language): Use it.
5107
24c54127
TT
51082019-05-10 Tom Tromey <tromey@adacore.com>
5109
5110 * thread.c (print_thread_info): Make "requested_threads" const.
5111 * gdbthread.h (print_thread_info): Make "requested_threads"
5112 const.
5113 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5114 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5115
7a102139
TT
51162019-05-08 Tom Tromey <tom@tromey.com>
5117
5118 * gdbtypes.c (objfile_type_data): Change type.
5119 (objfile_type, _initialize_gdbtypes): Update.
5120
924d79e2
TT
51212019-05-08 Tom Tromey <tom@tromey.com>
5122
5123 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5124 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5125 (_initialize_dwarf2_frame): Update.
5126
4c58e337
TT
51272019-05-08 Tom Tromey <tom@tromey.com>
5128
5129 * objc-lang.c (objc_objfile_data): Change type.
5130 (find_methods): Update.
5131 (_initialize_objc_lang): Remove.
5132
d772d2ab
TT
51332019-05-08 Tom Tromey <tom@tromey.com>
5134
5135 * stabsread.c (rs6000_builtin_type_data): Change type.
5136 (rs6000_builtin_type, _initialize_stabsread): Update.
5137
d11d83f4
TT
51382019-05-08 Tom Tromey <tom@tromey.com>
5139
5140 * mips-tdep.c (mips_pdr_data): Remove.
5141 (_initialize_mips_tdep): Update.
5142
9a73f0ad
TT
51432019-05-08 Tom Tromey <tom@tromey.com>
5144
5145 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5146 (hppa_init_objfile_priv_data, read_unwind_info)
5147 (find_unwind_entry, _initialize_hppa_tdep): Update.
5148
8127a2fa
TT
51492019-05-08 Tom Tromey <tom@tromey.com>
5150
5151 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5152 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5153 on obstack.
5154 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5155
91d3055d
TT
51562019-05-08 Tom Tromey <tom@tromey.com>
5157
5158 * mdebugread.c (basic_type_data): Change type.
5159 (basic_type, _initialize_mdebugread): Update.
5160
31930bd3
TT
51612019-05-08 Tom Tromey <tom@tromey.com>
5162
5163 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5164
bdb3ed9e
TT
51652019-05-08 Tom Tromey <tom@tromey.com>
5166
5167 * nto-tdep.c (nto_inferior_data_reg): Change type.
5168 (nto_inferior_data): Update.
5169 (nto_inferior_data_cleanup, nto_new_inferior_data)
5170 (_initialize_nto_tdep): Remove.
5171 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5172
f37b313d
TT
51732019-05-08 Tom Tromey <tom@tromey.com>
5174
5175 * ada-lang.c (struct ada_inferior_data): Add initializers.
5176 (ada_inferior_data): Change type.
5177 (ada_inferior_data_cleanup): Remove.
5178 (get_ada_inferior_data, ada_inferior_exit)
5179 (struct ada_pspace_data): Add initializers, destructor.
5180 (ada_pspace_data_handle): Change type.
5181 (get_ada_pspace_data): Update.
5182 (ada_pspace_data_cleanup): Remove.
5183
24699405
TT
51842019-05-08 Tom Tromey <tom@tromey.com>
5185
5186 * coffread.c (struct coff_symfile_info): Add initializers.
5187 (coff_objfile_data_key): Move lower. Change type.
5188 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5189 Update.
5190 (coff_free_info): Remove.
5191
d4e05d2f
TT
51922019-05-08 Tom Tromey <tom@tromey.com>
5193
5194 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5195 (fbsd_pspace_data_handle): Move lower. Change type.
5196 (get_fbsd_pspace_data): Update.
5197 (fbsd_pspace_data_cleanup): Remove.
5198 (_initialize_fbsd_tdep): Update.
5199
14ef6690
TT
52002019-05-08 Tom Tromey <tom@tromey.com>
5201
5202 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5203 (get_ada_tasks_pspace_data): Update.
5204 (ada_tasks_pspace_data_cleanup): Remove.
5205 (_initialize_tasks): Update.
5206 (ada_tasks_inferior_data_handle): Change type.
5207 (get_ada_tasks_inferior_data): Update.
5208 (ada_tasks_inferior_data_cleanup): Remove.
5209 (struct ada_tasks_pspace_data): Add initializers.
5210
814cf43a
TT
52112019-05-08 Tom Tromey <tom@tromey.com>
5212
5213 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5214 * symfile-debug.c (debug_sym_get_probes): Change type.
5215 * stap-probe.c (handle_stap_probe):
5216 (stap_static_probe_ops::get_probes): Change type.
5217 * probe.h (class static_probe_ops) <get_probes>: Change type.
5218 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5219 (parse_probes_in_pspace): Update.
5220 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5221 Update.
5222 (any_static_probe_ops::get_probes): Change type.
5223 * elfread.c (elfread_data): New typedef.
5224 (probe_key): Change type.
5225 (elf_get_probes): Likewise. Update.
5226 (probe_key_free): Remove.
5227 (_initialize_elfread): Update.
5228 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5229 Change type.
5230 (dtrace_process_dof_probe, dtrace_process_dof)
5231 (dtrace_static_probe_ops::get_probe): Change type.
5232
02dc647e
TT
52332019-05-08 Tom Tromey <tom@tromey.com>
5234
5235 * xcoffread.c (struct xcoff_symfile_info): Rename from
5236 coff_symfile_info. Add initializers.
5237 (xcoff_objfile_data_key): Move lower. Change type.
5238 (XCOFF_DATA): Rewrite.
5239 (xcoff_free_info): Remove.
5240 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5241 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5242 (xcoff_initial_scan): Update.
5243
09232438
TT
52442019-05-08 Tom Tromey <tom@tromey.com>
5245
5246 * solib-svr4.c (struct svr4_info): Add initializers and
5247 destructor.
5248 <probes_table>: Now an htab_up.
5249 (solib_svr4_pspace_data): Change type.
5250 (free_probes_table): Simplify.
5251 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5252 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5253 (probes_table_remove_objfile_probes, register_solib_event_probe)
5254 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5255 (_initialize_svr4_solib): Update.
5256
7b4a314f
TT
52572019-05-08 Tom Tromey <tom@tromey.com>
5258
5259 * remote.c (remote_pspace_data): Change type.
5260 (remote_pspace_data_cleanup): Remove.
5261 (get_remote_exec_file, set_pspace_remote_exec_file)
5262 (_initialize_remote): Update.
5263
51d3063a
TT
52642019-05-08 Tom Tromey <tom@tromey.com>
5265
5266 * breakpoint.c (breakpoint_objfile_key): Change type.
5267 (get_breakpoint_objfile_data): Update.
5268 (free_breakpoint_objfile_data): Remove.
5269 (_initialize_breakpoint): Update.
5270
89fb8848
TT
52712019-05-08 Tom Tromey <tom@tromey.com>
5272
5273 * linux-tdep.c (struct linux_info): Add initializers.
5274 (linux_inferior_data): Move. Change type.
5275 (invalidate_linux_cache_inf): Update.
5276 (linux_inferior_data_cleanup): Remove.
5277 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5278
e9b89e2d
TT
52792019-05-08 Tom Tromey <tom@tromey.com>
5280
5281 * auxv.c (auxv_inferior_data): Move. Change type.
5282 (auxv_inferior_data_cleanup): Remove.
5283 (invalidate_auxv_cache_inf): Rewrite.
5284 (get_auxv_inferior_data, _initialize_auxv): Update.
5285
8c42777c
TT
52862019-05-08 Tom Tromey <tom@tromey.com>
5287
5288 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5289 (symfile_debug_objfile_data_key): Change type.
5290 (symfile_debug_installed, debug_qf_has_symbols)
5291 (debug_qf_find_last_source_symtab)
5292 (debug_qf_forget_cached_source_info)
5293 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5294 (debug_qf_print_stats, debug_qf_dump)
5295 (debug_qf_expand_symtabs_for_function)
5296 (debug_qf_expand_all_symtabs)
5297 (debug_qf_expand_symtabs_with_fullname)
5298 (debug_qf_map_matching_symbols)
5299 (debug_qf_expand_symtabs_matching)
5300 (debug_qf_find_pc_sect_compunit_symtab)
5301 (debug_qf_map_symbol_filenames)
5302 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5303 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5304 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5305 (debug_sym_read_linetable, debug_sym_relocate): Update.
5306 (symfile_debug_free_objfile): Remove.
5307 (install_symfile_debug_logging, _initialize_symfile_debug):
5308 Update.
5309
5bfd760d
TT
53102019-05-08 Tom Tromey <tom@tromey.com>
5311
5312 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5313 allocate_on_obstack.
5314 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5315 (get_dwarf2_per_objfile): Update.
5316 (set_dwarf2_per_objfile): Remove.
5317 (dwarf2_has_info, dwarf2_get_section_info): Update.
5318 (dwarf2_free_objfile): Remove.
5319 (_initialize_dwarf2_read): Update.
5320
e85e19b4
TT
53212019-05-08 Tom Tromey <tom@tromey.com>
5322
5323 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5324 initializers.
5325 <unsupported_script_warning_printed,
5326 script_not_found_warning_printed>: Now bool.
5327 (auto_load_pspace_data): Change type.
5328 (~auto_load_pspace_info): Rename from
5329 auto_load_pspace_data_cleanup.
5330 (get_auto_load_pspace_data, init_loaded_scripts_info)
5331 (clear_section_scripts, maybe_print_unsupported_script_warning)
5332 (maybe_print_script_not_found_warning, _initialize_auto_load):
5333 Update.
5334
f6aa7436
TT
53352019-05-08 Tom Tromey <tom@tromey.com>
5336
5337 * objfiles.c (objfile_pspace_info): Add destructor and
5338 initializers.
5339 (objfiles_pspace_data): Change type.
5340 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5341 (get_objfile_pspace_data): Update.
5342 (objfiles_bfd_data): Change type.
5343 (get_objfile_bfd_data): Update.
5344 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5345
6ae614f6
TT
53462019-05-08 Tom Tromey <tom@tromey.com>
5347
5348 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5349 Change type.
5350 (get_catch_syscall_inferior_data): Update.
5351 (catch_syscall_inferior_data_cleanup): Remove.
5352 (_initialize_break_catch_syscall): Update.
5353
6509b8eb
TT
53542019-05-08 Tom Tromey <tom@tromey.com>
5355
5356 * inflow.c (struct terminal_info): Add destructor and
5357 initializers.
5358 (inflow_inferior_data): Change type.
5359 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5360 (get_inflow_inferior_data, inflow_inferior_exit)
5361 (swap_terminal_info, _initialize_inflow): Update.
5362
35632941
TT
53632019-05-08 Tom Tromey <tom@tromey.com>
5364
5365 * target-dcache.c (target_dcache_cleanup): Remove.
5366 (target_dcache_aspace_key): Change type.
5367 (target_dcache_init_p, target_dcache_invalidate)
5368 (target_dcache_get, target_dcache_get_or_init)
5369 (_initialize_target_dcache): Update.
5370 * dcache.h (struct dcache_deleter): New.
5371
3017b94d
TT
53722019-05-08 Tom Tromey <tom@tromey.com>
5373
5374 * symtab.c (struct symbol_cache): Add destructor and
5375 initializers.
5376 (symbol_cache_key): Move. Change type.
5377 (make_symbol_cache, free_symbol_cache): Remove.
5378 (get_symbol_cache): Update.
5379 (symbol_cache_cleanup): Remove.
5380 (ALL_PSPACES, symbol_cache_flush)
5381 (maintenance_print_symbol_cache)
5382 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5383 Update.
5384
a32ad8c5
TT
53852019-05-08 Tom Tromey <tom@tromey.com>
5386
5387 * symtab.c (struct main_info): Add destructor and initializers.
5388 (main_progspace_key): Move. Change type.
5389 (get_main_info): Update.
5390 (main_info_cleanup): Remove.
5391 (_initialize_symtab): Update.
5392
5f6e90a0
TT
53932019-05-08 Tom Tromey <tom@tromey.com>
5394
5395 * registry.h (DECLARE_REGISTRY): Define the _key class.
5396
1bd0c6e4
AB
53972019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5398
5399 * NEWS: Merge two 'New commands' sections.
5400
2228ef77
XR
54012019-05-08 Joel Brobecker <brobecker@adacore.com>
5402
5403 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5404 parameter and use Ada language definition instead.
5405 (ada_val_print_ptr): Remove unused language parameter.
5406 (ada_val_print_num): Remove language parameter and use Ada language
5407 definition instead.
5408 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5409 parameter.
5410 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5411 parameter and use Ada language definition instead.
5412 (ada_val_print_1): Update all ada_val_print_xxx calls.
5413 Remove language parameter.
5414 (ada_val_print): Update ada_val_print_1 call.
5415
60fcc1c3
TT
54162019-05-08 Tom Tromey <tromey@adacore.com>
5417
5418 * remote.c (remote_hw_watchpoint_limit)
5419 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5420 Now static.
5421
ed2b7c17
TT
54222019-05-08 Tom Tromey <tromey@adacore.com>
5423
5424 * maint.c (_initialize_maint_cmds): Move initialization code to
5425 remote.c.
5426 (watchdog, show_watchdog): Move to remote.c.
5427 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5428 "watchdog" static.
5429 (_initialize_remote): Move initialization code from maint.c.
5430 * defs.h (watchdog): Don't declare.
5431
b0be6c91
TT
54322019-05-08 Tom Tromey <tromey@adacore.com>
5433
5434 * tui/tui-interp.c: Include main.h.
5435 * interps.c: Include main.h.
5436 * main.h (interpreter_p): Declare.
5437 * defs.h (interpreter_p): Don't declare.
5438
587ee17b
TT
54392019-05-08 Tom Tromey <tromey@adacore.com>
5440
5441 * dwarf2loc.c: Include dwarf2read.h.
5442 * defs.h (read_unsigned_leb128): Don't declare.
5443 * dwarf2read.h (read_unsigned_leb128): Declare.
5444
ca1df239
TT
54452019-05-08 Tom Tromey <tromey@adacore.com>
5446
5447 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5448 method.
5449
99f20f08
TT
54502019-05-08 Tom Tromey <tromey@adacore.com>
5451
5452 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5453 when no wrap column is set.
5454
80e55b13
TT
54552019-05-08 Tom Tromey <tromey@adacore.com>
5456
5457 * c-lang.c (c_get_string): Handle non-C-style arrays.
5458
9d3421af
TT
54592019-05-08 Tom Tromey <tromey@adacore.com>
5460
5461 * typeprint.c (print_offset_data::update): Print the bit offset,
5462 not the number of bits remaining.
5463
844333e2
TT
54642019-05-08 Tom Tromey <tromey@adacore.com>
5465
5466 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5467 padding at end of comment.
5468
988915ee
TT
54692019-05-08 Tom Tromey <tromey@adacore.com>
5470
5471 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5472 Compare main types.
5473
26bfd823
TT
54742019-05-06 Tom Tromey <tom@tromey.com>
5475
5476 * common/scoped_mmap.c: Include common-defs.h.
5477 * common/scoped_mmap.h: Don't include config.h.
5478
89055eaa
TT
54792019-05-04 Tom Tromey <tom@tromey.com>
5480
5481 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5482 (struct aarch64_call_info): Add initializers.
5483 <si>: Now a std::vector.
5484 (pass_on_stack, aarch64_push_dummy_call): Update.
5485
5da01df5
TT
54862019-05-04 Simon Marchi <simon.marchi@efficios.com>
5487 Tom Tromey <tom@tromey.com>
5488
5489 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5490 (ppc_threads): Now a std::vector. Now static.
5491 (hwdebug_find_thread_points_by_tid)
5492 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5493 Update.
5494
fbdf05a1
TT
54952019-05-04 Tom Tromey <tom@tromey.com>
5496
5497 * arc-tdep.c (arc_tdesc_init): Return bool.
5498
06d16ec9
TT
54992019-05-04 Tom Tromey <tom@tromey.com>
5500
5501 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5502 Use gdb_assert_not_reached.
5503
9c056022
TT
55042019-05-04 Tom Tromey <tom@tromey.com>
5505
5506 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5507 "false".
5508
fa9c2a59
TT
55092019-05-04 Tom Tromey <tom@tromey.com>
5510
5511 * arc-tdep.c (arc_tdesc_init): Use bool.
5512
e2eb806a
TT
55132019-05-04 Tom Tromey <tom@tromey.com>
5514
5515 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5516
6fe87677
TT
55172019-05-04 Tom Tromey <tom@tromey.com>
5518
5519 * cli/cli-cmds.c (valid_command_p): Return bool.
5520
7f008c9e
TT
55212019-05-04 Tom Tromey <tom@tromey.com>
5522
5523 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5524 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5525
b6484282
RT
55262019-05-04 Raul Tambre <raul@tambre.ee>
5527
5528 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5529 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5530 operator for comparison.
5531
af97b416
TT
55322019-05-04 Tom Tromey <tom@tromey.com>
5533
5534 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5535 (lookup_partial_symbol, print_partial_symbols)
5536 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5537 (psymbol_compare): Update.
5538 (add_psymbol_to_bcache): Clear the entire psymbol.
5539 (maintenance_check_psymtabs): Update.
5540 * psympriv.h (struct partial_symbol): Don't derive from
5541 general_symbol_info.
5542 <obj_section, unrelocated_address, address,
5543 set_unrelocated_address>: Update.
5544 <ginfo>: New member.
5545 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5546 (debug_names::write_psymbols): Update.
5547
9d6d4be8
TV
55482019-05-04 Tom de Vries <tdevries@suse.de>
5549
5550 * contrib/cc-with-tweaks.sh: Support -n arg.
5551
66452beb
PW
55522019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5553
5554 * corelow.c (core_target::detach): Ensure frame cache and
5555 register caches are cleared.
5556 inferior.c (exit_inferior_1): Likewise.
5557
bde09ab7
TT
55582019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5559 Tom Tromey <tom@tromey.com>
5560
5561 * dictionary.c (collate_pending_symbols_by_language): Remove
5562 "struct" from foreach.
5563 * symtab.c (lookup_global_symbol_from_objfile)
5564 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5565 foreach.
5566 * ser-tcp.c (net_open): Remove "struct" from foreach.
5567 * objfiles.c (objfile_relocate, objfile_rebase)
5568 (objfile_has_symbols): Remove "struct" from foreach.
5569 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5570 from foreach.
5571 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5572 foreach.
5573 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5574 "struct" from foreach.
5575 * ada-lang.c (create_excep_cond_exprs)
5576 (ada_exception_catchpoint_cond_string): Remove "struct" from
5577 foreach.
5578
222a8d25
TT
55792019-05-03 Tom Tromey <tromey@adacore.com>
5580
5581 * ada-exp.y (convert_char_literal): Check suffix of each
5582 enumerator.
5583
fcd60b84
DP
55842019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5585
5586 PR ada/21406:
5587 * ada-exp.y (yywrap): Don't define.
5588 * ada-lex.l (%option): Add noyywrap
5589 (yywrap): Remove.
5590
5f2459c2
EZ
55912019-05-03 Eli Zaretskii <eliz@gnu.org>
5592
353ea2d1
EZ
5593 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5594 _WIN32_WINNT to the XP level, unless already defined to a higher
5595 level.
5596
5597 * unittests/parse-connection-spec-selftests.c:
5598 * ser-tcp.c:
5599 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5600 override.
5601
5f2459c2
EZ
5602 * symfile.c (find_separate_debug_file): Remove colon from the
5603 drive spec of DOS/Windows file names of the target, so that the
5604 file name produced from DEBUGDIR and the target's directory will
5605 be valid on DOS/Windows systems.
5606
80062eb9
AB
56072019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5608
5609 * rust-lang.c (val_print_struct): Handle printing structures
5610 containing strings.
5611
b8c05e85
TT
56122019-05-02 Tom Tromey <tromey@adacore.com>
5613
5614 * valarith.c (_initialize_valarith): Remove.
5615
4504bbde
TT
56162019-05-01 Tom Tromey <tromey@adacore.com>
5617
5618 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5619 bitfields.
5620
d48e62f4
TT
56212019-05-01 Tom Tromey <tromey@adacore.com>
5622
5623 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5624 for big-endian copies.
5625
15f18d14
AT
56262019-04-30 Ali Tamur <tamur@google.com>
5627 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5628 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5629 (read_3_bytes): New function.
5630
ab4ee614
JB
56312019-04-30 Joel Brobecker <brobecker@adacore.com>
5632
5633 * windows-nat.c (main_thread_id): Delete.
5634 (handle_output_debug_string): Replace main_thread_id by
5635 current_event.dwThreadId.
5636 (fake_create_process): Likewise.
5637 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5638 Do not set main_thread_id.
5639 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5640 current_event.dwThreadId.
5641 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5642
8ed5b76e
JB
56432019-04-30 Joel Brobecker <brobecker@adacore.com>
5644
5645 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5646 Use current_event.dwThreadId instead of main_thread_id.
5647
2ff0a947
TT
56482019-04-30 Tom Tromey <tromey@adacore.com>
5649
5650 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5651 (create_excep_cond_exprs): Iterate over program spaces.
5652 (ada_exception_catchpoint_cond_string): Examine all minimal
5653 symbols for exception types.
5654
a776957c
TT
56552019-04-30 Tom Tromey <tromey@adacore.com>
5656
5657 PR c++/24470:
5658 * dwarf2read.c (process_structure_scope): Handle case where type
5659 has template parameters but no symbol was created.
5660
bc68014d
AB
56612019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5662 Chris January <chris.january@arm.com>
5663
5664 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5665 qualifier.
5666 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5667
f1fdc960
AB
56682019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5669
5670 * f-typeprint.c (f_print_type): Update rules for printing
5671 whitespace.
5672 (f_type_print_varspec_suffix): Likewise.
5673
bf7a4de1
AB
56742019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5675 Chris January <chris.january@arm.com>
5676
5677 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5678 function arguments.
5679
bbe75b9d
AB
56802019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5681
5682 * f-lang.c (build_fortran_types): Change name of void type to
5683 lower case.
5684 * f-typeprint.c (f_type_print_base): Print the name of the void
5685 type, rather than a fixed string.
5686 * f-valprint.c (f_decorations): Use lower case void string.
5687
1db455a7
AB
56882019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5689 Chris January <chris.january@arm.com>
5690
5691 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5692 types for Fortran.
5693
b6d03bb2
AB
56942019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5695 Chris January <chris.january@arm.com>
5696 David Lecomber <david.lecomber@arm.com>
5697
5698 * f-exp.y (BINOP_INTRINSIC): New token.
5699 (exp): New parser rule handling BINOP_INTRINSIC.
5700 (f77_keywords): Add new builtin procedures.
5701 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5702 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5703 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5704 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5705 (print_unop_subexp_f): New function.
5706 (print_binop_subexp_f): New function.
5707 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5708 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5709 (dump_subexp_body_f): Likewise.
5710 (operator_check_f): Likewise.
5711 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5712 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5713
83228e93
AB
57142019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5715
5716 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5717 UNOP_KIND.
5718 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5719 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5720 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5721 (operator_length_f): New fuction.
5722 (print_subexp_f): New function.
5723 (op_name_f): New function.
5724 (dump_subexp_body_f): New function.
5725 (operator_check_f): New function.
5726 (exp_descriptor_f): Replace standard expression handling functions
5727 with new functions.
5728 * gdb/fortran-operator.def: New file.
5729 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5730 * gdb/std-operator.def: Remove UNOP_KIND.
5731
6fdcd7cc
AB
57322019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5733
5734 * std-operator.def: Remove unbalanced, stray double quote
5735 character.
5736
2e62ab40
AB
57372019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5738 Chris January <chris.january@arm.com>
5739 Daniel Everett <daniel.everett@arm.com>
5740 Nick Forrington <nick.forrington@arm.com>
5741 Richard Bunt <richard.bunt@arm.com>
5742
5743 * cp-valprint.c (cp_print_value_fields): Allow an additional level
5744 of depth when printing anonymous structs or unions.
5745 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5746 Don't print either the top-level value, or the children if the
5747 max-depth is exceeded.
5748 (ppscm_print_children): When printing the key of a map, allow one
5749 extra level of depth.
5750 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5751 print either the top-level value, or the children if the max-depth
5752 is exceeded.
5753 (print_children): When printing the key of a map, allow one extra
5754 level of depth.
5755 * python/py-value.c (valpy_format_string): Add max_depth keyword.
5756 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5757 (user_print_options): Initialise max_depth field.
5758 (val_print_scalar_or_string_type_p): New function.
5759 (val_print): Check to see if the max depth has been reached.
5760 (val_print_check_max_depth): Define new function.
5761 (show_print_max_depth): New function.
5762 (_initialize_valprint): Add 'print max-depth' option.
5763 * valprint.h (struct value_print_options) <max_depth>: New field.
5764 (val_print_check_max_depth): Declare new function.
5765 * NEWS: Document new feature.
5766
4be290b2
AB
57672019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5768
5769 * ada-lang.c (ada_language_defn): Initialise new field.
5770 * c-lang.c (c_is_string_type_p): New function.
5771 (c_language_defn): Initialise new field.
5772 (cplus_language_defn): Initialise new field.
5773 (asm_language_defn): Initialise new field.
5774 (minimal_language_defn): Initialise new field.
5775 * c-lang.h (c_is_string_type_p): Declare new function.
5776 * d-lang.c (d_language_defn): Initialise new field.
5777 * f-lang.c (f_is_string_type_p): New function.
5778 (f_language_defn): Initialise new field.
5779 * go-lang.c (go_is_string_type_p): New function.
5780 (go_language_defn): Initialise new field.
5781 * language.c (default_is_string_type_p): New function.
5782 (unknown_language_defn): Initialise new field.
5783 (auto_language_defn): Initialise new field.
5784 * language.h (struct language_defn) <la_is_string_type_p>: New
5785 member variable.
5786 (default_is_string_type_p): Declare new function.
5787 * m2-lang.c (m2_language_defn): Initialise new field.
5788 * objc-lang.c (objc_language_defn): Initialise new field.
5789 * opencl-lang.c (opencl_language_defn): Initialise new field.
5790 * p-lang.c (pascal_is_string_type_p): New function.
5791 (pascal_language_defn): Initialise new field.
5792 * rust-lang.c (rust_is_string_type_p): New function.
5793 (rust_language_defn): Initialise new field.
5794
721b08c6
AB
57952019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5796
5797 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5798 New field.
5799 * ada-lang.c (ada_language_defn): Initialise new field.
5800 * c-lang.c (c_language_defn): Likewise.
5801 (cplus_language_defn): Likewise.
5802 (asm_language_defn): Likewise.
5803 (minimal_language_defn): Likewise.
5804 * d-lang.c (d_language_defn): Likewise.
5805 * f-lang.c (f_language_defn): Likewise.
5806 * go-lang.c (go_language_defn): Likewise.
5807 * language.c (unknown_language_defn): Likewise.
5808 (auto_language_defn): Likewise.
5809 * m2-lang.c (m2_language_defn): Likewise.
5810 * objc-lang.c (objc_language_defn): Likewise.
5811 * opencl-lang.c (opencl_language_defn): Likewise.
5812 * p-lang.c (pascal_language_defn): Likewise.
5813 * rust-lang.c (rust_language_defn): Likewise.
5814
fc913e53
AB
58152019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5816
5817 * ada-lang.c (ada_is_character_type): Change return type to bool.
5818 (ada_is_string_type): Likewise.
5819 * ada-lang.h (ada_is_character_type): Update declaration
5820 (ada_is_string_type): Likewise.
5821
fa731fa0
PW
58222019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5823
5824 Support style in 'frame|thread apply'
5825
5826 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5827 * record.c (record_start, record_stop): Update callers of
5828 execute_command_to_string with false.
5829 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5830 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5831 methods.
5832 (class string_file): New constructor with term_out parameter.
5833 Override methods term_out and can_emit_style_escape. New member
5834 term_out.
5835 (class stdio_file): Override can_emit_style_escape.
5836 (class tee_file): Override term_out and can_emit_style_escape.
5837 * utils.h (can_emit_style_escape): Remove.
5838 * utils.c (can_emit_style_escape): Likewise.
5839 Update all callers of can_emit_style_escape (SOMESTREAM) to
5840 SOMESTREAM->can_emit_style_escape.
5841 * source-cache.c (source_cache::get_source_lines): Likewise.
5842 * stack.c (frame_apply_command_count): Call execute_command_to_string
5843 passing the term_out characteristic of the current gdb_stdout.
5844 * thread.c (thr_try_catch_cmd): Likewise.
5845 * top.c (execute_command_to_string): pass term_out parameter
5846 to construct the string_file for the command output.
5847 * ui-file.c (term_cli_styling): New function (most code moved
5848 from utils.c can_emit_style_escape).
5849 (string_file::string_file, string_file::can_emit_style_escape,
5850 stdio_file::can_emit_style_escape, tee_file::term_out,
5851 tee_file::can_emit_style_escape): New functions.
5852
136afab8
PW
58532019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5854
5855 * NEWS: Mention the new set|show may-call-functions.
5856 * infcall.c (may_call_functions_p): New variable.
5857 (show_may_call_functions_p): New function.
5858 (call_function_by_hand_dummy): Throws an error if not
5859 may-call-functions.
5860 (_initialize_infcall): Call add_setshow_boolean_cmd for
5861 may-call-functions.
5862
725cbb63
KS
58632019-04-25 Keith Seitz <keiths@redhat.com>
5864
5865 PR c++/24367
5866 * cp-support.c (inspect_type): Don't attempt substitutions
5867 of symbol with the same name.
5868
3d1cbb78
TT
58692019-04-25 Tom Tromey <tromey@adacore.com>
5870
5871 PR gdb/24475:
5872 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5873 static.
5874
94aeb44b
TT
58752019-04-25 Tom Tromey <tromey@adacore.com>
5876
5877 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5878 rvalue reference.
5879 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5880 (gdb_xml_parser::parse): Use std::move.
5881 * python/python-internal.h (gdbpy_convert_exception): Take a const
5882 reference.
5883 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5884 std::move.
5885 * python/py-utils.c (gdbpy_convert_exception): Take a const
5886 reference.
5887 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5888 Use std::move.
5889 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5890 Use std::move.
5891 * mi/mi-main.c (mi_print_exception): Take a const reference.
5892 * main.c (handle_command_errors): Take a const reference.
5893 * linespec.c (parse_linespec): Use std::move.
5894 * infcall.c (run_inferior_call): Use std::move.
5895 (call_function_by_hand_dummy): Use std::move.
5896 * exec.c (try_open_exec_file): Use std::move.
5897 * exceptions.h (exception_print, exception_fprintf)
5898 (exception_print_same): Update.
5899 * exceptions.c (print_exception, exception_print)
5900 (exception_fprintf, exception_print_same): Change parameters to
5901 const reference.
5902 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5903 * common/new-op.c: Use std::move.
5904 * common/common-exceptions.h (struct gdb_exception): Add move
5905 constructor.
5906 (struct gdb_exception_error, struct gdb_exception_quit, struct
5907 gdb_quit_bad_alloc): Change constructor to move constructor.
5908 (throw_exception): Change parameter to rvalue reference.
5909 * common/common-exceptions.c (throw_exception): Take rvalue
5910 reference.
5911 * cli/cli-interp.c (safe_execute_command): Use std::move.
5912 * breakpoint.c (insert_bp_location, location_to_sals): Use
5913 std::move.
5914
680d7fd5
TT
59152019-04-25 Tom Tromey <tromey@adacore.com>
5916
5917 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5918 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5919 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5920 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5921 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5922 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5923 guile/scm-value.c: Use unpack.
5924 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5925 gdbscm_gdb_exception.
5926 (gdbscm_throw_gdb_exception): Likewise.
5927 (struct gdbscm_gdb_exception): New.
5928 (unpack): New function.
5929 (gdbscm_wrap): Use unpack.
5930
c6fdd8b2
TT
59312019-04-25 Tom Tromey <tromey@adacore.com>
5932
5933 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5934 (gdb_rl_callback_handler): Use std::move.
5935 * common/common-exceptions.h (struct gdb_exception): Add move
5936 assignment operator.
5937 (throw_exception_sjlj): Change "exception" to const reference.
5938 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5939 (throw_exception_sjlj): Change "exception" to const reference.
5940
cc06b668
TT
59412019-04-25 Tom Tromey <tromey@adacore.com>
5942
5943 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5944 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5945 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5946 Update.
5947 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5948 Update.
5949 * mi/mi-interp.c (mi_interp::exec): Update.
5950 * linespec.c (parse_linespec): Update.
5951 * infcall.c (run_inferior_call): Update.
5952 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5953 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5954 (gdbscm_lookup_global_symbol): Update.
5955 * guile/scm-param.c (gdbscm_parameter_value): Update.
5956 * guile/scm-frame.c (gdbscm_frame_read_register)
5957 (gdbscm_frame_read_var): Update.
5958 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5959 * exec.c (try_open_exec_file): Update.
5960 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5961 (gdb_rl_callback_handler): Update.
5962 * common/common-exceptions.h (exception_none): Don't declare.
5963 * common/common-exceptions.c (exception_none): Don't define.
5964 (struct catcher) <exception>: Update.
5965 * cli/cli-interp.c (safe_execute_command): Update.
5966 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5967
cf532bd1
AT
59682019-04-25 Ali Tamur <tamur@google.com>
5969
5970 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5971 (read_attribute_value): Likewise.
5972 (dwarf2_read_addr_index): Update comment.
5973 (read_str_index): Add DW_FORM_strx.
5974 (dwarf2_string_attr): Likewise.
5975 (dwarf2_const_value_attr): Likewise.
5976 (dump_die_shallow): Likewise.
5977 (dwarf2_fetch_constant_bytes): Likewise.
5978 (skip_form_bytes): Likewise.
5979 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5980
82433e3e
SDJ
59812019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5982
5983 PR corefiles/11608
5984 PR corefiles/18187
5985 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5986 OFFSET. Verify if current mapping contains an ELF header.
5987 (linux_find_memory_regions_full): Adjust call to
5988 dump_mapping_p.
5989
723adb65
SL
59902019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5991 Kang Li <kanglictf@gmail.com>
5992
5993 PR gdb/21600
5994
5995 * dwarf2-frame.c (read_initial_length): Be consistent about using
5996 unsigned representation of length.
5997 (decode_frame_entry_1): Likewise. Check for wraparound of
5998 end pointer as well as buffer overflow.
5999
596179f7
SDJ
60002019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6001
6002 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6003 "vq".
6004
a59240a4
TT
60052019-04-24 Tom Tromey <tromey@adacore.com>
6006
6007 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6008
f872fdbb
AB
60092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6010
6011 * s12z-tdep.c (s12z_unwind_pc): Delete.
6012 (s12z_unwind_sp): Delete.
6013 (s12z_gdbarch_init): Don't register deleted functions with
6014 gdbarch.
6015
b614e6f3
AB
60162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6017
6018 * rl78-tdep.c (rl78_unwind_sp): Delete.
6019 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6020
14faed38
AB
60212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6022
6023 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6024 (xstormy16_unwind_pc): Delete.
6025 (xstormy16_dummy_id): Delete.
6026 (xstormy16_gdbarch_init): Don't register deleted functions with
6027 gdbarch.
6028
541aad8a
AB
60292019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6030
6031 * vax-tdep.c (vax_unwind_pc): Delete.
6032 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6033
29222070
AB
60342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6035
6036 * v850-tdep.c (v850_unwind_sp): Delete.
6037 (v850_unwind_pc): Delete.
6038 (v850_dummy_id): Delete.
6039 (v850_gdbarch_init): Don't register deleted functions with
6040 gdbarch.
6041
0f534d76
AB
60422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6043
6044 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6045 (tilegx_unwind_pc): Delete.
6046 (tilegx_unwind_dummy_id): Delete.
6047 (tilegx_gdbarch_init): Don't register deleted functions with
6048 gdbarch.
6049
1ba7b7f9
AB
60502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6051
6052 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6053 (tic6x_dummy_id): Delete.
6054 (tic6x_gdbarch_init): Don't register deleted functions with
6055 gdbarch.
6056
d31f262c
AB
60572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6058
6059 * sparc-tdep.c (sparc_unwind_pc): Delete.
6060 (sparc32_gdbarch_init): Don't register deleted function with
6061 gdbarch.
6062
6d14d64d
AB
60632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6064
6065 * sh-tdep.c (sh_unwind_sp): Delete.
6066 (sh_unwind_pc): Delete.
6067 (sh_dummy_id): Delete.
6068 (sh_gdbarch_init): Don't register deleted functions with
6069 gdbarch.
6070
a40dde9d
AB
60712019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6072
6073 * score-tdep.c (score_unwind_sp): Delete.
6074 (score_unwind_pc): Delete.
6075 (score_dummy_id): Delete.
6076 (score_gdbarch_init): Don't register deleted functions with
6077 gdbarch.
6078
47c47d69
AB
60792019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6080
6081 * rx-tdep.c (rx_unwind_pc): Delete.
6082 (rx_unwind_sp): Delete.
6083 (rx_dummy_id): Delete.
6084 (rx_gdbarch_init): Don't register deleted functions with
6085 gdbarch. Update comment.
6086
833a4480
AB
60872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6088
6089 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6090 (rs6000_dummy_id): Delete.
6091 (rs6000_gdbarch_init): Don't register deleted functions with
6092 gdbarch.
6093
3f2cef49
AB
60942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6095
6096 * or1k-tdep.c (or1k_dummy_id): Delete.
6097 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6098
96acf884
AB
60992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6100
6101 * nios2-tdep.c (nios2_dummy_id): Delete.
6102 (nios2_unwind_sp): Delete.
6103 (nios2_gdbarch_init): Don't register deleted functions with
6104 gdbarch.
6105
ca0ab0aa
AB
61062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6107
6108 * nds32-tdep.c (nds32_dummy_id): Delete.
6109 (nds32_unwind_pc): Delete.
6110 (nds32_unwind_sp): Delete.
6111 (nds32_gdbarch_init): Don't register deleted functions with
6112 gdbarch.
6113
c8259044
AB
61142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6115
6116 * msp430-tdep.c (msp430_unwind_pc): Delete.
6117 (msp430_unwind_sp): Delete.
6118 (msp430_dummy_id): Delete.
6119 (msp430_gdbarch_init): Don't register deleted functions with
6120 gdbarch.
6121
27f113c8
AB
61222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6123
6124 * moxie-tdep.c (moxie_unwind_sp): Delete.
6125 (moxie_unwind_pc): Delete.
6126 (moxie_dummy_id): Delete.
6127 (moxie_gdbarch_init): Don't register deleted functions with
6128 gdbarch.
6129
aee6c3cd
AB
61302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6131
6132 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6133 (mn10300_unwind_pc): Delete.
6134 (mn10300_unwind_sp): Delete.
6135 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6136 mn10300_unwind_sp.
6137 (mn10300_frame_unwind_init): Don't register deleted functions with
6138 gdbarch.
6139
8e2b5aea
AB
61402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6141
6142 * mep-tdep.c (mep_unwind_pc): Delete.
6143 (mep_unwind_sp): Delete.
6144 (mep_dummy_id): Delete.
6145 (mep_gdbarch_init): Don't register deleted functions with
6146 gdbarch.
6147
43cf3ede
AB
61482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6149
6150 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6151 (m68hc11_unwind_sp): Delete.
6152 (m68hc11_gdbarch_init): Don't register deleted functions with
6153 gdbarch.
6154
5e79b7bb
AB
61552019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6156
6157 * m32r-tdep.c (m32r_unwind_sp): Delete.
6158 (m32r_unwind_pc): Delete.
6159 (m32r_dummy_id): Delete.
6160 (m32r_gdbarch_init): Don't register deleted functions with
6161 gdbarch.
6162
89b268d8
AB
61632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6164
6165 * m32c-tdep.c (m32c_unwind_pc): Delete.
6166 (m32c_unwind_sp): Delete.
6167 (m32c_dummy_id): Delete.
6168 (m32c_gdbarch_init): Don't register deleted functions with
6169 gdbarch.
6170
946c28d2
AB
61712019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6172
6173 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6174 (lm32_unwind_pc): Delete.
6175 (lm32_dummy_id): Delete.
6176 (lm32_gdbarch_init): Don't register deleted functions with
6177 gdbarch.
6178
bf12844a
AB
61792019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6180
6181 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6182 (iq2000_unwind_pc): Delete.
6183 (iq2000_dummy_id): Delete.
6184 (iq2000_gdbarch_init): Don't register deleted functions with
6185 gdbarch.
6186
ecbc06d2
AB
61872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6188
6189 * nds32-tdep.c (nds32_type_align): Delete.
6190 (nds32_push_dummy_call): Use type_align instead.
6191
030197b4
AB
61922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6193
6194 * arm-tdep.c (arm_type_align): Only handle vector override case.
6195 (arm_push_dummy_call): Use type_align.
6196 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6197
b907456c
AB
61982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6199
6200 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6201 case.
6202 (pass_on_stack): Use type_align.
6203 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6204 function.
6205
9e97ba43
TT
62062019-04-23 Tom Tromey <tromey@adacore.com>
6207
6208 * dwarf2read.c (line_header::file_name_at): Remove unused
6209 overload.
6210
6892f601
TV
62112019-04-23 Tom de Vries <tdevries@suse.de>
6212
6213 PR gdb/24438
6214 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6215 invocation.
6216
336d760d
AT
6217
62182019-03-27 Ali Tamur <tamur@google.com>
6219
6220 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6221 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6222 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6223 (dwarf_expr_context::get_addr_index): Likewise
6224 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6225 (symbol_needs_eval_context::get_addr_index): Likewise
6226 (disassemble_dwarf_expression): Add DW_OP_addrx
6227 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6228 (read_cutu_die_from_dwo): Update comment
6229 (skip_one_die): Add DW_FORM_addrx
6230 (read_attribute_value): Likewise
6231 (var_decode_location): Add DW_OP_addrx
6232 (dwarf2_const_value_attr): Add DW_FORM_addrx
6233 (dump_die_shallow): Likewise
6234 (dwarf2_fetch_constant_bytes): Likewise
6235 (decode_locdesc): Add DW_OP_addrx
6236 (skip_form_bytes): Add DW_FORM_addrx
6237
ad9d13f8
AT
62382019-04-22 Ali Tamur <tamur@google.com>
6239
6240 * MAINTAINERS (Write After Approval): Add self.
6241
d70cc3ba
SM
62422019-04-22 Simon Marchi <simon.marchi@efficios.com>
6243
6244 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6245 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6246 (open_symbol_file_object): Likewise.
6247 (svr4_default_sos): Add info parameter.
6248 (svr4_read_so_list): Likewise.
6249 (svr4_current_sos_direct): Adjust functions calls to pass down
6250 info.
6251 (svr4_current_sos_1): Add info parameter.
6252 (svr4_current_sos): Call get_svr4_info, pass info down to
6253 svr4_current_sos_1.
6254 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6255 get_svr4_info.
6256 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6257 get_svr4_info.
6258 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6259 to get_svr4_info.
6260 (probes_table_remove_objfile_probes): Likewise.
6261 (register_solib_event_probe): Add info parameter.
6262 (solist_update_incremental): Pass info parameter down to
6263 svr4_read_so_list.
6264 (disable_probes_interface): Add info parameter.
6265 (svr4_handle_solib_event): Pass current_program_space to
6266 get_svr4_info. Adjust disable_probes_interface cleanup.
6267 (svr4_create_probe_breakpoints): Add info parameter, pass it
6268 down to register_solib_event_probe.
6269 (svr4_create_solib_event_breakpoints): Add info parameter,
6270 pass it down to svr4_create_probe_breakpoints.
6271 (enable_break): Pass info down to
6272 svr4_create_solib_event_breakpoints.
6273 (svr4_solib_create_inferior_hook): Pass current_program_space to
6274 get_svr4_info.
6275 (svr4_clear_solib): Likewise.
6276
7905fc35
PA
62772019-04-22 Pedro Alves <palves@redhat.com>
6278
6279 * solib-svr4.c (svr4_free_objfile_observer): New.
6280 (probe_and_action::objfile): New field.
6281 (probes_table_htab_remove_objfile_probes)
6282 (probes_table_remove_objfile_probes): New functions.
6283 (register_solib_event_probe): Add 'objfile' parameter. Store it
6284 in the new probe_and_action. Don't store the probe in 'lookup'.
6285 (svr4_create_probe_breakpoints): Pass objfile to
6286 register_solib_event_probe.
6287 (_initialize_svr4_solib): Register a free_objfile observer.
6288
fb881986
TT
62892019-04-19 Tom Tromey <tom@tromey.com>
6290
6291 * common/queue.h: Remove.
6292
8732db6c
TT
62932019-04-19 Tom Tromey <tom@tromey.com>
6294
6295 * event-loop.c: Don't include "common/queue.h".
6296
97dfbadd
TT
62972019-04-19 Tom Tromey <tom@tromey.com>
6298
6299 * remote.c (remote_target): Use delete.
6300 * remote-notif.h: Include <list>, not "common/queue.h".
6301 (notif_client_p): Remove typedef.
6302 (remote_notif_state): Add constructor, destructor, initializer.
6303 <notif_queue>: Now a std::list.
6304 (remote_notif_state_xfree): Don't declare.
6305 * remote-notif.c (remote_notif_process, handle_notification)
6306 (remote_notif_state_allocate): Update.
6307 (~remote_notif_state): Rename from remote_notif_state_xfree.
6308
cf250e36
TT
63092019-04-19 Tom Tromey <tom@tromey.com>
6310
6311 * symfile.c (reread_symbols): Update.
6312 * objfiles.c (objfile_register_static_link)
6313 (objfile_lookup_static_link): Update
6314 (~objfile) Don't delete static_links.
6315 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6316
61f4b350
TT
63172019-04-19 Tom Tromey <tom@tromey.com>
6318
6319 * type-stack.h (struct type_stack) <insert>: Constify string.
6320 * type-stack.c (type_stack::insert): Constify string.
6321 * gdbtypes.h (lookup_template_type): Update.
6322 (address_space_name_to_int): Update.
6323 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6324 const.
6325 (lookup_template_type): Make name const.
6326 * c-exp.y: Update rules.
6327 (lex_one_token, classify_name, classify_inner_name)
6328 (c_print_token): Update.
6329 * p-exp.y: Update rules.
6330 (yylex): Update.
6331 * f-exp.y: Update rules.
6332 (yylex): Update.
6333 * d-exp.y: Update rules.
6334 (lex_one_token, classify_name, classify_inner_name): Update.
6335 * parse.c (write_dollar_variable, copy_name): Return std::string.
6336 * parser-defs.h (copy_name): Change return type.
6337 * m2-exp.y: Update rules.
6338 (yylex): Update.
6339 * go-exp.y (lex_one_token): Update.
6340 Update rules.
6341 (classify_unsafe_function, classify_packaged_name)
6342 (classify_name, yylex): Update.
6343
189b8c2e
ST
63442019-04-19 Sergei Trofimovich <siarheit@google.com>
6345
6346 * configure.ac: add --enable-source-highlight switch.
6347 * configure: Regenerate.
6348 * top.c (print_gdb_version): plumb --enable-source-highlight
6349 status to "show configuration".
6350
8ecb59f8
TT
63512019-04-19 Tom Tromey <tromey@adacore.com>
6352
6353 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6354 Check ADA_TYPE_P.
6355 (empty_record, ada_template_to_fixed_record_type_1)
6356 (template_to_static_fixed_type)
6357 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6358 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6359 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6360 macros.
6361
62160ec9
TT
63622019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6363
6364 PR symtab/24423:
6365 * source.c (print_source_lines_base): Advance "iter" when a
6366 control character is seen.
6367
f2ae8bc8
PW
63682019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6369
6370 * inferior.h (struct infcall_suspend_state_deleter):
6371 Catch exception in destructor to avoid crash.
6372
d563b953
PW
63732019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6374
6375 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6376 close to the add_com "shell".
6377
dc34c897
TT
63782019-04-18 Tom Tromey <tromey@adacore.com>
6379
6380 * process-stratum-target.h (class process_stratum_target)
6381 <stratum>: Add "final".
6382
a12e5744
TT
63832019-04-17 Tom Tromey <tromey@adacore.com>
6384
6385 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6386 against nullptr before use.
6387
a7e559cc
AH
63882019-04-17 Alan Hayward <alan.hayward@arm.com>
6389
6390 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6391
c01660c6
AB
63922019-04-17 Jim Wilson <jimw@sifive.com>
6393 Andrew Burgess <andrew.burgess@embecosm.com>
6394
6395 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6396 code read might fail, assume 4-byte breakpoint in that case.
6397
4aa866af
LS
63982019-04-15 Leszek Swirski <leszeks@google.com>
6399
6400 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6401 rather than a hand-rolled POD check when checking for forced MEMORY
6402 classification.
6403
48574d91
AH
64042019-04-15 Alan Hayward <alan.hayward@arm.com>
6405
6406 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6407 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6408 function.
6409 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6410 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6411 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6412 declaration.
6413
4da037ef
AH
64142019-04-15 Alan Hayward <alan.hayward@arm.com>
6415
6416 * aarch64-linux-nat.c
6417 (aarch64_linux_nat_target::thread_architecture): Add override.
6418 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6419 each VQ.
6420
ccb8d7e8
AH
64212019-04-15 Alan Hayward <alan.hayward@arm.com>
6422
6423 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6424
35add35e
AB
64252019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6426
6427 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6428 target types of size 96-bits, add some additional comments, and
6429 check that the builtin type we found was the correct size.
6430
51196bbc
EZ
64312019-04-12 Eli Zaretskii <eliz@gnu.org>
6432
6433 * utils.c (prompt_for_continue): Don't restore the styling at the
6434 end, as applied_style has the wrong value. This fixes styling in
6435 long lists of file names that are interrupted by the "Continue?"
6436 prompt.
6437
62253a61
AB
64382019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6439
6440 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6441 * c-lang.c (c_language_defn): Likewise.
6442 (cplus_language_defn): Likewise.
6443 (asm_language_defn): Likewise.
6444 (minimal_language_defn): Likewise.
6445 * d-lang.c (d_language_defn): Likewise.
6446 * f-lang.c (f_language_defn): Likewise.
6447 * go-lang.c (go_language_defn): Likewise.
6448 * language.c (unknown_language_defn): Likewise.
6449 (auto_language_defn): Likewise.
6450 * language.h (struct language_defn): Remove la_magic field.
6451 (LANG_MAGIC): Delete.
6452 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6453 * objc-lang.c (objc_language_defn): Likewise.
6454 * opencl-lang.c (opencl_language_defn): Likewise.
6455 * p-lang.c (pascal_language_defn): Likewise.
6456 * rust-lang.c (rust_language_defn): Likewise.
6457
a9158a86
AB
64582019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6459
6460 * riscv-tdep.c (riscv_type_align): New function.
6461 (riscv_type_alignment): Delete.
6462 (riscv_arg_location): Use 'type_align'.
6463 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6464
41077b66
AB
64652019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6466
6467 * gdbtypes.c (type_align): A struct with no non-static fields also
6468 has alignment of 1.
6469
9f0272f8
AB
64702019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6471
6472 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6473 component to 0.
6474 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6475 member.
6476 (riscv_struct_info::analyse): New implementation using new
6477 analyse_inner member function.
6478 (riscv_struct_info::field_offset): New member function.
6479 (riscv_struct_info::m_offsets): New member variable.
6480 (riscv_struct_info::analyse_inner): New private member function,
6481 takes the old implementation of riscv_struct_info::analyse but
6482 extended to track field offsets.
6483 (riscv_call_arg_struct): Update the struct folding special cases
6484 to handle cases where empty C++ structs, which are non-zero
6485 length, are found.
6486 (riscv_arg_location): Initialise the length of each location, a
6487 non-zero length now indicates the location is in use.
6488 (riscv_push_dummy_call): Allow for the first location having a
6489 non-zero offset when setting up arguments.
6490 (riscv_return_value): Likewise, but for return values.
6491
02cf60c7
TT
64922019-04-11 Tom Tromey <tromey@adacore.com>
6493
6494 * utils.c (internal_vproblem): Make "msg" const.
6495
68811f8f
AH
64962019-04-11 Alan Hayward <alan.hayward@arm.com>
6497
6498 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6499 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6500 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6501 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6502
3f52fdbc
KB
65032019-04-10 Kevin Buettner <kevinb@redhat.com>
6504
6505 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6506 function.
6507 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6508 of amd64_collect_native_gregset.
6509 (amd64_linux_nat_target::store_registers): Likewise.
6510
e9ad22ee
TT
65112019-04-10 Tom Tromey <tom@tromey.com>
6512
6513 * symtab.c (lookup_global_symbol_from_objfile)
6514 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6515 * objfiles.h (class separate_debug_iterator): New.
6516 (class separate_debug_range): New.
6517 (struct objfile) <separate_debug_objfiles>: New method.
6518 (objfile_separate_debug_iterate): Don't declare.
6519 * objfiles.c (separate_debug_iterator::operator++): Rename from
6520 objfile_separate_debug_iterate.
6521 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6522 iterator.
6523 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6524 iterator.
6525
ee371134
TT
65262019-04-10 Tom Tromey <tom@tromey.com>
6527
6528 * symfile.c (reread_symbols): Remove old comment.
6529 * objfiles.c (free_all_objfiles): Fix a typo.
6530
bf227d61
TT
65312019-04-10 Tom Tromey <tom@tromey.com>
6532
6533 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6534 * minsyms.c (lookup_minimal_symbol): Use foreach.
6535 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6536 (lookup_minimal_symbol_solib_trampoline): Likewise.
6537 * symfile.c (reread_symbols): Use foreach.
6538
8dc433a0
TT
65392019-04-09 Ivan Begert <ivanbegert@gmail.com>
6540 Tom Tromey <tromey@adacore.com>
6541
6542 PR rust/24414:
6543 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6544 (rust_lex_int_test): Change "value" to be LONGEST.
6545 (rust_lex_tests): Add test for long integer literal.
6546
9ab8741a
TT
65472019-04-09 Tom Tromey <tromey@adacore.com>
6548
6549 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6550 to bool.
6551 (extended_remote_target::attach): Update.
6552 (remote_target::remote_notice_new_inferior): Update.
6553 (remote_target::add_current_inferior_and_thread): Update.
6554 * inferior.c (exit_inferior_1): Use "false".
6555 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6556
e242fd12
SM
65572019-04-09 Simon Marchi <simon.marchi@efficios.com>
6558
9ca1957f 6559 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
6560 the "start" command.
6561
2b0c8b01
KB
65622019-04-08 Kevin Buettner <kevinb@redhat.com>
6563
6564 * python/py-inferior.c (infpy_thread_from_thread_handle):
6565 Adjust comments to reflect renaming of thread_from_thread_handle
6566 to thread_from_handle. Adjust keywords. Fix type error message.
6567 (inferior_object_methods): Add thread_from_handle. Retain
6568 thread_from_thread_handle, but mark it as deprecated.
6569
50a82723
KB
65702019-04-08 Kevin Buettner <kevinb@redhat.com>
6571
6572 * gdbthread.h (find_thread_by_handle): Revise declaration.
6573 * thread.c (find_thread_by_handle): Likewise. Adjust
6574 implementation too.
6575 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6576 support for buffer objects as handles.
6577
cf63b016
KB
65782019-04-08 Kevin Buettner <kevinb@redhat.com>
6579
6580 * python/py-infthread.c (thpy_thread_handle): New function.
6581 (thread_object_methods): Register thpy_thread_handle.
6582
3d6c6204
KB
65832019-04-08 Kevin Buettner <kevinb@redhat.com>
6584
6585 * gdbthread.h (thread_to_thread_handle): Declare.
6586 * thread.c (gdbtypes.h): Include.
6587 (thread_to_thread_handle): New function.
6588
6589 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6590 (target_thread_info_to_thread_handle): Declare.
6591 * target.c (target_thread_info_to_thread_handle): New function.
6592 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6593 * target-delegates.c: Regenerate.
6594
6595 * linux-thread-db.c (class thread_db_target): Add method
6596 thread_info_to_thread_handle.
6597 (thread_db_target::thread_info_to_thread_handle): Define.
6598 * remote.c (class remote_target): Add new method
6599 thread_info_to_thread_handle.
6600 (remote_target::thread_info_to_thread_handle): Define.
6601
56be6ea8
PA
66022019-04-08 Pedro Alves <palves@redhat.com>
6603
6604 * common/common-exceptions.c (throw_exception): Don't create
6605 named object to throw; throw directly.
6606 (throw_it): Likewise. Don't initialize gdb_exception::message
6607 here, with new; pass FMT and AP to the ctor instead.
6608 * common/common-exceptions.h: Include <string>.
6609 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6610 const char *, va_list)): New ctor. Use std::make_shared.
6611 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6612 errors)): Delete.
6613 (gdb_exception_error::gdb_exception_error(enum errors, const char
6614 *, va_list)): New.
6615 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6616 Add assertion.
6617 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6618 errors)): Delete.
6619 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6620 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6621 Add assertion.
6622
eedc3f4f
TT
66232019-04-08 Tom Tromey <tom@tromey.com>
6624
6625 * valops.c (value_rtti_indirect_type): Replace throw_exception
6626 with throw.
6627 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6628 with throw.
6629 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6630 throw.
6631 * target.c (target_translate_tls_address): Replace throw_exception
6632 with throw.
6633 * stack.c (frame_apply_command_count): Replace throw_exception
6634 with throw.
6635 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6636 throw.
6637 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6638 with throw.
6639 * rs6000-tdep.c (rs6000_frame_cache)
6640 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6641 * remote.c: Replace throw_exception with throw.
6642 * record-full.c (record_full_message, record_full_wait_1)
6643 (record_full_restore): Replace throw_exception with throw.
6644 * record-btrace.c:
6645 (get_thread_current_frame_id, record_btrace_start_replaying)
6646 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6647 (cmd_record_btrace_start): Replace throw_exception with throw.
6648 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6649 throw.
6650 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6651 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6652 * linespec.c:
6653 (find_linespec_symbols): Replace throw_exception with throw.
6654 * infrun.c (displaced_step_prepare, resume): Replace
6655 throw_exception with throw.
6656 * infcmd.c (post_create_inferior): Replace throw_exception with
6657 throw.
6658 * inf-loop.c (inferior_event_handler): Replace throw_exception
6659 with throw.
6660 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6661 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6662 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6663 (get_prev_frame_always, get_frame_pc_if_available)
6664 (get_frame_address_in_block_if_available, get_frame_language):
6665 Replace throw_exception with throw.
6666 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6667 throw_exception with throw.
6668 * eval.c (fetch_subexp_value, evaluate_var_value)
6669 (evaluate_funcall, evaluate_subexp_standard): Replace
6670 throw_exception with throw.
6671 * dwarf2loc.c (call_site_find_chain)
6672 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6673 Replace throw_exception with throw.
6674 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6675 with throw.
6676 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6677 throw.
6678 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6679 * completer.c (complete_line_internal): Replace throw_exception
6680 with throw.
6681 * compile/compile-object-run.c (compile_object_run): Replace
6682 throw_exception with throw.
6683 * cli/cli-script.c (process_next_line): Replace throw_exception
6684 with throw.
6685 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6686 (btrace_enable, btrace_maint_update_pt_packets): Replace
6687 throw_exception with throw.
6688 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6689 throw_exception with throw.
6690 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6691 throw_exception with throw.
6692 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6693 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6694 * aarch64-tdep.c (aarch64_make_prologue_cache)
6695 (aarch64_make_stub_cache): Replace throw_exception with throw.
6696
26003a20
TT
66972019-04-08 Tom Tromey <tom@tromey.com>
6698
6699 * common/common-exceptions.c (throw_exception): Rename from
6700 throw_exception_cxx. Remove old copy. Make argument const.
6701 (throw_it): Create and throw exception objects directly.
6702 * common/common-exceptions.h (throw_exception): Make argument
6703 const.
6704 (struct gdb_exception_error): Add constructor.
6705 (struct gdb_exception_quit): Add constructor.
6706
d272eb37
TT
67072019-04-08 Tom Tromey <tom@tromey.com>
6708
6709 * common/common-exceptions.h (exception_rethrow): Don't declare.
6710 (TRY_SJLJ): Update comment.
6711 (TRY, CATCH, END_CATCH): Remove.
6712 * common/common-exceptions.c (exception_rethrow): Remove.
6713
230d2906
TT
67142019-04-08 Tom Tromey <tom@tromey.com>
6715
6716 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6717 Remove.
6718 (gdb_exception_error): Rename from
6719 gdb_exception_RETURN_MASK_ERROR.
6720 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6721 (gdb_quit_bad_alloc): Update.
6722 * aarch64-tdep.c: Update.
6723 * ada-lang.c: Update.
6724 * ada-typeprint.c: Update.
6725 * ada-valprint.c: Update.
6726 * amd64-tdep.c: Update.
6727 * arch-utils.c: Update.
6728 * break-catch-throw.c: Update.
6729 * breakpoint.c: Update.
6730 * btrace.c: Update.
6731 * c-varobj.c: Update.
6732 * cli/cli-cmds.c: Update.
6733 * cli/cli-interp.c: Update.
6734 * cli/cli-script.c: Update.
6735 * common/common-exceptions.c: Update.
6736 * common/new-op.c: Update.
6737 * common/selftest.c: Update.
6738 * compile/compile-c-symbols.c: Update.
6739 * compile/compile-cplus-symbols.c: Update.
6740 * compile/compile-object-load.c: Update.
6741 * compile/compile-object-run.c: Update.
6742 * completer.c: Update.
6743 * corelow.c: Update.
6744 * cp-abi.c: Update.
6745 * cp-support.c: Update.
6746 * cp-valprint.c: Update.
6747 * darwin-nat.c: Update.
6748 * disasm-selftests.c: Update.
6749 * dtrace-probe.c: Update.
6750 * dwarf-index-cache.c: Update.
6751 * dwarf-index-write.c: Update.
6752 * dwarf2-frame-tailcall.c: Update.
6753 * dwarf2-frame.c: Update.
6754 * dwarf2loc.c: Update.
6755 * dwarf2read.c: Update.
6756 * eval.c: Update.
6757 * event-loop.c: Update.
6758 * event-top.c: Update.
6759 * exec.c: Update.
6760 * f-valprint.c: Update.
6761 * fbsd-tdep.c: Update.
6762 * frame-unwind.c: Update.
6763 * frame.c: Update.
6764 * gdbtypes.c: Update.
6765 * gnu-v3-abi.c: Update.
6766 * guile/guile-internal.h: Update.
6767 * guile/scm-block.c: Update.
6768 * guile/scm-breakpoint.c: Update.
6769 * guile/scm-cmd.c: Update.
6770 * guile/scm-disasm.c: Update.
6771 * guile/scm-frame.c: Update.
6772 * guile/scm-lazy-string.c: Update.
6773 * guile/scm-math.c: Update.
6774 * guile/scm-param.c: Update.
6775 * guile/scm-ports.c: Update.
6776 * guile/scm-pretty-print.c: Update.
6777 * guile/scm-symbol.c: Update.
6778 * guile/scm-symtab.c: Update.
6779 * guile/scm-type.c: Update.
6780 * guile/scm-value.c: Update.
6781 * i386-linux-tdep.c: Update.
6782 * i386-tdep.c: Update.
6783 * inf-loop.c: Update.
6784 * infcall.c: Update.
6785 * infcmd.c: Update.
6786 * infrun.c: Update.
6787 * jit.c: Update.
6788 * language.c: Update.
6789 * linespec.c: Update.
6790 * linux-fork.c: Update.
6791 * linux-nat.c: Update.
6792 * linux-tdep.c: Update.
6793 * linux-thread-db.c: Update.
6794 * main.c: Update.
6795 * mi/mi-cmd-break.c: Update.
6796 * mi/mi-cmd-stack.c: Update.
6797 * mi/mi-interp.c: Update.
6798 * mi/mi-main.c: Update.
6799 * objc-lang.c: Update.
6800 * p-valprint.c: Update.
6801 * parse.c: Update.
6802 * ppc-linux-tdep.c: Update.
6803 * printcmd.c: Update.
6804 * python/py-arch.c: Update.
6805 * python/py-breakpoint.c: Update.
6806 * python/py-cmd.c: Update.
6807 * python/py-finishbreakpoint.c: Update.
6808 * python/py-frame.c: Update.
6809 * python/py-framefilter.c: Update.
6810 * python/py-gdb-readline.c: Update.
6811 * python/py-inferior.c: Update.
6812 * python/py-infthread.c: Update.
6813 * python/py-lazy-string.c: Update.
6814 * python/py-linetable.c: Update.
6815 * python/py-objfile.c: Update.
6816 * python/py-param.c: Update.
6817 * python/py-prettyprint.c: Update.
6818 * python/py-progspace.c: Update.
6819 * python/py-record-btrace.c: Update.
6820 * python/py-record.c: Update.
6821 * python/py-symbol.c: Update.
6822 * python/py-type.c: Update.
6823 * python/py-unwind.c: Update.
6824 * python/py-utils.c: Update.
6825 * python/py-value.c: Update.
6826 * python/python.c: Update.
6827 * record-btrace.c: Update.
6828 * record-full.c: Update.
6829 * remote-fileio.c: Update.
6830 * remote.c: Update.
6831 * riscv-tdep.c: Update.
6832 * rs6000-aix-tdep.c: Update.
6833 * rs6000-tdep.c: Update.
6834 * rust-exp.y: Update.
6835 * rust-lang.c: Update.
6836 * s390-tdep.c: Update.
6837 * selftest-arch.c: Update.
6838 * solib-dsbt.c: Update.
6839 * solib-frv.c: Update.
6840 * solib-spu.c: Update.
6841 * solib-svr4.c: Update.
6842 * solib.c: Update.
6843 * sparc64-linux-tdep.c: Update.
6844 * stack.c: Update.
6845 * symfile-mem.c: Update.
6846 * symmisc.c: Update.
6847 * target.c: Update.
6848 * thread.c: Update.
6849 * top.c: Update.
6850 * tracefile-tfile.c: Update.
6851 * tui/tui.c: Update.
6852 * typeprint.c: Update.
6853 * unittests/cli-utils-selftests.c: Update.
6854 * unittests/parse-connection-spec-selftests.c: Update.
6855 * valops.c: Update.
6856 * valprint.c: Update.
6857 * value.c: Update.
6858 * varobj.c: Update.
6859 * windows-nat.c: Update.
6860 * x86-linux-nat.c: Update.
6861 * xml-support.c: Update.
6862
a70b8144
TT
68632019-04-08 Tom Tromey <tom@tromey.com>
6864
6865 * xml-support.c: Use C++ exception handling.
6866 * x86-linux-nat.c: Use C++ exception handling.
6867 * windows-nat.c: Use C++ exception handling.
6868 * varobj.c: Use C++ exception handling.
6869 * value.c: Use C++ exception handling.
6870 * valprint.c: Use C++ exception handling.
6871 * valops.c: Use C++ exception handling.
6872 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6873 handling.
6874 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6875 * typeprint.c: Use C++ exception handling.
6876 * tui/tui.c: Use C++ exception handling.
6877 * tracefile-tfile.c: Use C++ exception handling.
6878 * top.c: Use C++ exception handling.
6879 * thread.c: Use C++ exception handling.
6880 * target.c: Use C++ exception handling.
6881 * symmisc.c: Use C++ exception handling.
6882 * symfile-mem.c: Use C++ exception handling.
6883 * stack.c: Use C++ exception handling.
6884 * sparc64-linux-tdep.c: Use C++ exception handling.
6885 * solib.c: Use C++ exception handling.
6886 * solib-svr4.c: Use C++ exception handling.
6887 * solib-spu.c: Use C++ exception handling.
6888 * solib-frv.c: Use C++ exception handling.
6889 * solib-dsbt.c: Use C++ exception handling.
6890 * selftest-arch.c: Use C++ exception handling.
6891 * s390-tdep.c: Use C++ exception handling.
6892 * rust-lang.c: Use C++ exception handling.
6893 * rust-exp.y: Use C++ exception handling.
6894 * rs6000-tdep.c: Use C++ exception handling.
6895 * rs6000-aix-tdep.c: Use C++ exception handling.
6896 * riscv-tdep.c: Use C++ exception handling.
6897 * remote.c: Use C++ exception handling.
6898 * remote-fileio.c: Use C++ exception handling.
6899 * record-full.c: Use C++ exception handling.
6900 * record-btrace.c: Use C++ exception handling.
6901 * python/python.c: Use C++ exception handling.
6902 * python/py-value.c: Use C++ exception handling.
6903 * python/py-utils.c: Use C++ exception handling.
6904 * python/py-unwind.c: Use C++ exception handling.
6905 * python/py-type.c: Use C++ exception handling.
6906 * python/py-symbol.c: Use C++ exception handling.
6907 * python/py-record.c: Use C++ exception handling.
6908 * python/py-record-btrace.c: Use C++ exception handling.
6909 * python/py-progspace.c: Use C++ exception handling.
6910 * python/py-prettyprint.c: Use C++ exception handling.
6911 * python/py-param.c: Use C++ exception handling.
6912 * python/py-objfile.c: Use C++ exception handling.
6913 * python/py-linetable.c: Use C++ exception handling.
6914 * python/py-lazy-string.c: Use C++ exception handling.
6915 * python/py-infthread.c: Use C++ exception handling.
6916 * python/py-inferior.c: Use C++ exception handling.
6917 * python/py-gdb-readline.c: Use C++ exception handling.
6918 * python/py-framefilter.c: Use C++ exception handling.
6919 * python/py-frame.c: Use C++ exception handling.
6920 * python/py-finishbreakpoint.c: Use C++ exception handling.
6921 * python/py-cmd.c: Use C++ exception handling.
6922 * python/py-breakpoint.c: Use C++ exception handling.
6923 * python/py-arch.c: Use C++ exception handling.
6924 * printcmd.c: Use C++ exception handling.
6925 * ppc-linux-tdep.c: Use C++ exception handling.
6926 * parse.c: Use C++ exception handling.
6927 * p-valprint.c: Use C++ exception handling.
6928 * objc-lang.c: Use C++ exception handling.
6929 * mi/mi-main.c: Use C++ exception handling.
6930 * mi/mi-interp.c: Use C++ exception handling.
6931 * mi/mi-cmd-stack.c: Use C++ exception handling.
6932 * mi/mi-cmd-break.c: Use C++ exception handling.
6933 * main.c: Use C++ exception handling.
6934 * linux-thread-db.c: Use C++ exception handling.
6935 * linux-tdep.c: Use C++ exception handling.
6936 * linux-nat.c: Use C++ exception handling.
6937 * linux-fork.c: Use C++ exception handling.
6938 * linespec.c: Use C++ exception handling.
6939 * language.c: Use C++ exception handling.
6940 * jit.c: Use C++ exception handling.
6941 * infrun.c: Use C++ exception handling.
6942 * infcmd.c: Use C++ exception handling.
6943 * infcall.c: Use C++ exception handling.
6944 * inf-loop.c: Use C++ exception handling.
6945 * i386-tdep.c: Use C++ exception handling.
6946 * i386-linux-tdep.c: Use C++ exception handling.
6947 * guile/scm-value.c: Use C++ exception handling.
6948 * guile/scm-type.c: Use C++ exception handling.
6949 * guile/scm-symtab.c: Use C++ exception handling.
6950 * guile/scm-symbol.c: Use C++ exception handling.
6951 * guile/scm-pretty-print.c: Use C++ exception handling.
6952 * guile/scm-ports.c: Use C++ exception handling.
6953 * guile/scm-param.c: Use C++ exception handling.
6954 * guile/scm-math.c: Use C++ exception handling.
6955 * guile/scm-lazy-string.c: Use C++ exception handling.
6956 * guile/scm-frame.c: Use C++ exception handling.
6957 * guile/scm-disasm.c: Use C++ exception handling.
6958 * guile/scm-cmd.c: Use C++ exception handling.
6959 * guile/scm-breakpoint.c: Use C++ exception handling.
6960 * guile/scm-block.c: Use C++ exception handling.
6961 * guile/guile-internal.h: Use C++ exception handling.
6962 * gnu-v3-abi.c: Use C++ exception handling.
6963 * gdbtypes.c: Use C++ exception handling.
6964 * frame.c: Use C++ exception handling.
6965 * frame-unwind.c: Use C++ exception handling.
6966 * fbsd-tdep.c: Use C++ exception handling.
6967 * f-valprint.c: Use C++ exception handling.
6968 * exec.c: Use C++ exception handling.
6969 * event-top.c: Use C++ exception handling.
6970 * event-loop.c: Use C++ exception handling.
6971 * eval.c: Use C++ exception handling.
6972 * dwarf2read.c: Use C++ exception handling.
6973 * dwarf2loc.c: Use C++ exception handling.
6974 * dwarf2-frame.c: Use C++ exception handling.
6975 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6976 * dwarf-index-write.c: Use C++ exception handling.
6977 * dwarf-index-cache.c: Use C++ exception handling.
6978 * dtrace-probe.c: Use C++ exception handling.
6979 * disasm-selftests.c: Use C++ exception handling.
6980 * darwin-nat.c: Use C++ exception handling.
6981 * cp-valprint.c: Use C++ exception handling.
6982 * cp-support.c: Use C++ exception handling.
6983 * cp-abi.c: Use C++ exception handling.
6984 * corelow.c: Use C++ exception handling.
6985 * completer.c: Use C++ exception handling.
6986 * compile/compile-object-run.c: Use C++ exception handling.
6987 * compile/compile-object-load.c: Use C++ exception handling.
6988 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6989 * compile/compile-c-symbols.c: Use C++ exception handling.
6990 * common/selftest.c: Use C++ exception handling.
6991 * common/new-op.c: Use C++ exception handling.
6992 * cli/cli-script.c: Use C++ exception handling.
6993 * cli/cli-interp.c: Use C++ exception handling.
6994 * cli/cli-cmds.c: Use C++ exception handling.
6995 * c-varobj.c: Use C++ exception handling.
6996 * btrace.c: Use C++ exception handling.
6997 * breakpoint.c: Use C++ exception handling.
6998 * break-catch-throw.c: Use C++ exception handling.
6999 * arch-utils.c: Use C++ exception handling.
7000 * amd64-tdep.c: Use C++ exception handling.
7001 * ada-valprint.c: Use C++ exception handling.
7002 * ada-typeprint.c: Use C++ exception handling.
7003 * ada-lang.c: Use C++ exception handling.
7004 * aarch64-tdep.c: Use C++ exception handling.
7005
3d6e9d23
TT
70062019-04-08 Tom Tromey <tom@tromey.com>
7007
7008 * xml-support.c (gdb_xml_parser::parse): Update.
7009 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7010 * value.c (show_convenience): Update.
7011 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7012 (test_parse_flags_qcs): Update.
7013 * thread.c (thr_try_catch_cmd): Update.
7014 * target.c (target_translate_tls_address): Update.
7015 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7016 (info_frame_command_core, frame_apply_command_count): Update.
7017 * rust-exp.y (rust_lex_exception_test): Update.
7018 * riscv-tdep.c (riscv_print_one_register_info): Update.
7019 * remote.c (remote_target::enable_btrace): Update.
7020 * record-btrace.c (record_btrace_enable_warn): Update.
7021 * python/py-utils.c (gdbpy_convert_exception): Update.
7022 * printcmd.c (do_one_display, print_variable_and_value): Update.
7023 * mi/mi-main.c (mi_print_exception): Update.
7024 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7025 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7026 * linux-nat.c (linux_nat_target::attach): Update.
7027 * linux-fork.c (class scoped_switch_fork_info): Update.
7028 * infrun.c (displaced_step_prepare): Update.
7029 * infcall.c (call_function_by_hand_dummy): Update.
7030 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7031 * gnu-v3-abi.c (print_one_vtable): Update.
7032 * frame.c (get_prev_frame_always): Update.
7033 * f-valprint.c (info_common_command_for_block): Update.
7034 * exec.c (try_open_exec_file): Update.
7035 * exceptions.c (print_exception, exception_print)
7036 (exception_fprintf, exception_print_same): Update.
7037 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7038 * dwarf-index-cache.c (index_cache::store)
7039 (index_cache::lookup_gdb_index): Update.
7040 * darwin-nat.c (maybe_cache_shell): Update.
7041 * cp-valprint.c (cp_print_value_fields): Update.
7042 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7043 (gcc_cplus_symbol_address): Update.
7044 * compile/compile-c-symbols.c (gcc_convert_symbol)
7045 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7046 * common/selftest.c: Update.
7047 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7048 a std::string.
7049 (exception_try_scope_entry, exception_try_scope_exit): Don't
7050 declare.
7051 (struct exception_try_scope): Remove.
7052 (TRY): Don't use exception_try_scope.
7053 (struct gdb_exception): Add constructor, operator=.
7054 <what>: New method.
7055 (struct gdb_exception_RETURN_MASK_ALL)
7056 (struct gdb_exception_RETURN_MASK_ERROR)
7057 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7058 (struct gdb_quit_bad_alloc): Update.
7059 * common/common-exceptions.c (exception_none): Change
7060 initializer.
7061 (struct catcher) <state, exception>: Initialize inline.
7062 <prev>: Remove member.
7063 (current_catcher): Remove.
7064 (catchers): New global.
7065 (exceptions_state_mc_init): Simplify.
7066 (catcher_pop): Remove.
7067 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7068 (try_scope_depth, exception_try_scope_entry)
7069 (exception_try_scope_exit): Remove.
7070 (throw_exception_sjlj): Update.
7071 (exception_messages, exception_messages_size): Remove.
7072 (throw_it): Simplify.
7073 (gdb_exception_sliced_copy): Remove.
7074 (throw_exception_cxx): Update.
7075 * cli/cli-script.c (script_from_file): Update.
7076 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7077 Update.
7078 * ada-valprint.c (ada_val_print): Update.
7079 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7080 (create_excep_cond_exprs): Update.
7081
c5c10118
TT
70822019-04-08 Tom Tromey <tom@tromey.com>
7083
7084 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7085 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7086 (TRY, CATCH, END_CATCH): Remove some definitions.
7087 * common/common-exceptions.c: Don't use GDB_XCPT.
7088 (catcher_list_size): Remove.
7089 (throw_exception, throw_it): Simplify.
7090
4de283e4
TT
70912019-04-05 Tom Tromey <tom@tromey.com>
7092
7093 Revert the header-sorting patch.
7094 * ft32-tdep.c: Revert.
7095 * frv-tdep.c: Revert.
7096 * frv-linux-tdep.c: Revert.
7097 * frame.c: Revert.
7098 * frame-unwind.c: Revert.
7099 * frame-base.c: Revert.
7100 * fork-child.c: Revert.
7101 * findvar.c: Revert.
7102 * findcmd.c: Revert.
7103 * filesystem.c: Revert.
7104 * filename-seen-cache.h: Revert.
7105 * filename-seen-cache.c: Revert.
7106 * fbsd-tdep.c: Revert.
7107 * fbsd-nat.h: Revert.
7108 * fbsd-nat.c: Revert.
7109 * f-valprint.c: Revert.
7110 * f-typeprint.c: Revert.
7111 * f-lang.c: Revert.
7112 * extension.h: Revert.
7113 * extension.c: Revert.
7114 * extension-priv.h: Revert.
7115 * expprint.c: Revert.
7116 * exec.h: Revert.
7117 * exec.c: Revert.
7118 * exceptions.c: Revert.
7119 * event-top.c: Revert.
7120 * event-loop.c: Revert.
7121 * eval.c: Revert.
7122 * elfread.c: Revert.
7123 * dwarf2read.h: Revert.
7124 * dwarf2read.c: Revert.
7125 * dwarf2loc.c: Revert.
7126 * dwarf2expr.h: Revert.
7127 * dwarf2expr.c: Revert.
7128 * dwarf2-frame.c: Revert.
7129 * dwarf2-frame-tailcall.c: Revert.
7130 * dwarf-index-write.h: Revert.
7131 * dwarf-index-write.c: Revert.
7132 * dwarf-index-common.c: Revert.
7133 * dwarf-index-cache.h: Revert.
7134 * dwarf-index-cache.c: Revert.
7135 * dummy-frame.c: Revert.
7136 * dtrace-probe.c: Revert.
7137 * disasm.h: Revert.
7138 * disasm.c: Revert.
7139 * disasm-selftests.c: Revert.
7140 * dictionary.c: Revert.
7141 * dicos-tdep.c: Revert.
7142 * demangle.c: Revert.
7143 * dcache.h: Revert.
7144 * dcache.c: Revert.
7145 * darwin-nat.h: Revert.
7146 * darwin-nat.c: Revert.
7147 * darwin-nat-info.c: Revert.
7148 * d-valprint.c: Revert.
7149 * d-namespace.c: Revert.
7150 * d-lang.c: Revert.
7151 * ctf.c: Revert.
7152 * csky-tdep.c: Revert.
7153 * csky-linux-tdep.c: Revert.
7154 * cris-tdep.c: Revert.
7155 * cris-linux-tdep.c: Revert.
7156 * cp-valprint.c: Revert.
7157 * cp-support.c: Revert.
7158 * cp-namespace.c: Revert.
7159 * cp-abi.c: Revert.
7160 * corelow.c: Revert.
7161 * corefile.c: Revert.
7162 * continuations.c: Revert.
7163 * completer.h: Revert.
7164 * completer.c: Revert.
7165 * complaints.c: Revert.
7166 * coffread.c: Revert.
7167 * coff-pe-read.c: Revert.
7168 * cli-out.h: Revert.
7169 * cli-out.c: Revert.
7170 * charset.c: Revert.
7171 * c-varobj.c: Revert.
7172 * c-valprint.c: Revert.
7173 * c-typeprint.c: Revert.
7174 * c-lang.c: Revert.
7175 * buildsym.c: Revert.
7176 * buildsym-legacy.c: Revert.
7177 * build-id.h: Revert.
7178 * build-id.c: Revert.
7179 * btrace.c: Revert.
7180 * bsd-uthread.c: Revert.
7181 * breakpoint.h: Revert.
7182 * breakpoint.c: Revert.
7183 * break-catch-throw.c: Revert.
7184 * break-catch-syscall.c: Revert.
7185 * break-catch-sig.c: Revert.
7186 * blockframe.c: Revert.
7187 * block.c: Revert.
7188 * bfin-tdep.c: Revert.
7189 * bfin-linux-tdep.c: Revert.
7190 * bfd-target.c: Revert.
7191 * bcache.c: Revert.
7192 * ax-general.c: Revert.
7193 * ax-gdb.h: Revert.
7194 * ax-gdb.c: Revert.
7195 * avr-tdep.c: Revert.
7196 * auxv.c: Revert.
7197 * auto-load.c: Revert.
7198 * arm-wince-tdep.c: Revert.
7199 * arm-tdep.c: Revert.
7200 * arm-symbian-tdep.c: Revert.
7201 * arm-pikeos-tdep.c: Revert.
7202 * arm-obsd-tdep.c: Revert.
7203 * arm-nbsd-tdep.c: Revert.
7204 * arm-nbsd-nat.c: Revert.
7205 * arm-linux-tdep.c: Revert.
7206 * arm-linux-nat.c: Revert.
7207 * arm-fbsd-tdep.c: Revert.
7208 * arm-fbsd-nat.c: Revert.
7209 * arm-bsd-tdep.c: Revert.
7210 * arch-utils.c: Revert.
7211 * arc-tdep.c: Revert.
7212 * arc-newlib-tdep.c: Revert.
7213 * annotate.h: Revert.
7214 * annotate.c: Revert.
7215 * amd64-windows-tdep.c: Revert.
7216 * amd64-windows-nat.c: Revert.
7217 * amd64-tdep.c: Revert.
7218 * amd64-sol2-tdep.c: Revert.
7219 * amd64-obsd-tdep.c: Revert.
7220 * amd64-obsd-nat.c: Revert.
7221 * amd64-nbsd-tdep.c: Revert.
7222 * amd64-nbsd-nat.c: Revert.
7223 * amd64-nat.c: Revert.
7224 * amd64-linux-tdep.c: Revert.
7225 * amd64-linux-nat.c: Revert.
7226 * amd64-fbsd-tdep.c: Revert.
7227 * amd64-fbsd-nat.c: Revert.
7228 * amd64-dicos-tdep.c: Revert.
7229 * amd64-darwin-tdep.c: Revert.
7230 * amd64-bsd-nat.c: Revert.
7231 * alpha-tdep.c: Revert.
7232 * alpha-obsd-tdep.c: Revert.
7233 * alpha-nbsd-tdep.c: Revert.
7234 * alpha-mdebug-tdep.c: Revert.
7235 * alpha-linux-tdep.c: Revert.
7236 * alpha-linux-nat.c: Revert.
7237 * alpha-bsd-tdep.c: Revert.
7238 * alpha-bsd-nat.c: Revert.
7239 * aix-thread.c: Revert.
7240 * agent.c: Revert.
7241 * addrmap.c: Revert.
7242 * ada-varobj.c: Revert.
7243 * ada-valprint.c: Revert.
7244 * ada-typeprint.c: Revert.
7245 * ada-tasks.c: Revert.
7246 * ada-lang.c: Revert.
7247 * aarch64-tdep.c: Revert.
7248 * aarch64-ravenscar-thread.c: Revert.
7249 * aarch64-newlib-tdep.c: Revert.
7250 * aarch64-linux-tdep.c: Revert.
7251 * aarch64-linux-nat.c: Revert.
7252 * aarch64-fbsd-tdep.c: Revert.
7253 * aarch64-fbsd-nat.c: Revert.
7254 * aarch32-linux-nat.c: Revert.
7255
d55e5aa6
TT
72562019-04-05 Tom Tromey <tom@tromey.com>
7257
7258 * ft32-tdep.c: Sort headers.
7259 * frv-tdep.c: Sort headers.
7260 * frv-linux-tdep.c: Sort headers.
7261 * frame.c: Sort headers.
7262 * frame-unwind.c: Sort headers.
7263 * frame-base.c: Sort headers.
7264 * fork-child.c: Sort headers.
7265 * findvar.c: Sort headers.
7266 * findcmd.c: Sort headers.
7267 * filesystem.c: Sort headers.
7268 * filename-seen-cache.h: Sort headers.
7269 * filename-seen-cache.c: Sort headers.
7270 * fbsd-tdep.c: Sort headers.
7271 * fbsd-nat.h: Sort headers.
7272 * fbsd-nat.c: Sort headers.
7273 * f-valprint.c: Sort headers.
7274 * f-typeprint.c: Sort headers.
7275 * f-lang.c: Sort headers.
7276 * extension.h: Sort headers.
7277 * extension.c: Sort headers.
7278 * extension-priv.h: Sort headers.
7279 * expprint.c: Sort headers.
7280 * exec.h: Sort headers.
7281 * exec.c: Sort headers.
7282 * exceptions.c: Sort headers.
7283 * event-top.c: Sort headers.
7284 * event-loop.c: Sort headers.
7285 * eval.c: Sort headers.
7286 * elfread.c: Sort headers.
7287 * dwarf2read.h: Sort headers.
7288 * dwarf2read.c: Sort headers.
7289 * dwarf2loc.c: Sort headers.
7290 * dwarf2expr.h: Sort headers.
7291 * dwarf2expr.c: Sort headers.
7292 * dwarf2-frame.c: Sort headers.
7293 * dwarf2-frame-tailcall.c: Sort headers.
7294 * dwarf-index-write.h: Sort headers.
7295 * dwarf-index-write.c: Sort headers.
7296 * dwarf-index-common.c: Sort headers.
7297 * dwarf-index-cache.h: Sort headers.
7298 * dwarf-index-cache.c: Sort headers.
7299 * dummy-frame.c: Sort headers.
7300 * dtrace-probe.c: Sort headers.
7301 * disasm.h: Sort headers.
7302 * disasm.c: Sort headers.
7303 * disasm-selftests.c: Sort headers.
7304 * dictionary.c: Sort headers.
7305 * dicos-tdep.c: Sort headers.
7306 * demangle.c: Sort headers.
7307 * dcache.h: Sort headers.
7308 * dcache.c: Sort headers.
7309 * darwin-nat.h: Sort headers.
7310 * darwin-nat.c: Sort headers.
7311 * darwin-nat-info.c: Sort headers.
7312 * d-valprint.c: Sort headers.
7313 * d-namespace.c: Sort headers.
7314 * d-lang.c: Sort headers.
7315 * ctf.c: Sort headers.
7316 * csky-tdep.c: Sort headers.
7317 * csky-linux-tdep.c: Sort headers.
7318 * cris-tdep.c: Sort headers.
7319 * cris-linux-tdep.c: Sort headers.
7320 * cp-valprint.c: Sort headers.
7321 * cp-support.c: Sort headers.
7322 * cp-namespace.c: Sort headers.
7323 * cp-abi.c: Sort headers.
7324 * corelow.c: Sort headers.
7325 * corefile.c: Sort headers.
7326 * continuations.c: Sort headers.
7327 * completer.h: Sort headers.
7328 * completer.c: Sort headers.
7329 * complaints.c: Sort headers.
7330 * coffread.c: Sort headers.
7331 * coff-pe-read.c: Sort headers.
7332 * cli-out.h: Sort headers.
7333 * cli-out.c: Sort headers.
7334 * charset.c: Sort headers.
7335 * c-varobj.c: Sort headers.
7336 * c-valprint.c: Sort headers.
7337 * c-typeprint.c: Sort headers.
7338 * c-lang.c: Sort headers.
7339 * buildsym.c: Sort headers.
7340 * buildsym-legacy.c: Sort headers.
7341 * build-id.h: Sort headers.
7342 * build-id.c: Sort headers.
7343 * btrace.c: Sort headers.
7344 * bsd-uthread.c: Sort headers.
7345 * breakpoint.h: Sort headers.
7346 * breakpoint.c: Sort headers.
7347 * break-catch-throw.c: Sort headers.
7348 * break-catch-syscall.c: Sort headers.
7349 * break-catch-sig.c: Sort headers.
7350 * blockframe.c: Sort headers.
7351 * block.c: Sort headers.
7352 * bfin-tdep.c: Sort headers.
7353 * bfin-linux-tdep.c: Sort headers.
7354 * bfd-target.c: Sort headers.
7355 * bcache.c: Sort headers.
7356 * ax-general.c: Sort headers.
7357 * ax-gdb.h: Sort headers.
7358 * ax-gdb.c: Sort headers.
7359 * avr-tdep.c: Sort headers.
7360 * auxv.c: Sort headers.
7361 * auto-load.c: Sort headers.
7362 * arm-wince-tdep.c: Sort headers.
7363 * arm-tdep.c: Sort headers.
7364 * arm-symbian-tdep.c: Sort headers.
7365 * arm-pikeos-tdep.c: Sort headers.
7366 * arm-obsd-tdep.c: Sort headers.
7367 * arm-nbsd-tdep.c: Sort headers.
7368 * arm-nbsd-nat.c: Sort headers.
7369 * arm-linux-tdep.c: Sort headers.
7370 * arm-linux-nat.c: Sort headers.
7371 * arm-fbsd-tdep.c: Sort headers.
7372 * arm-fbsd-nat.c: Sort headers.
7373 * arm-bsd-tdep.c: Sort headers.
7374 * arch-utils.c: Sort headers.
7375 * arc-tdep.c: Sort headers.
7376 * arc-newlib-tdep.c: Sort headers.
7377 * annotate.h: Sort headers.
7378 * annotate.c: Sort headers.
7379 * amd64-windows-tdep.c: Sort headers.
7380 * amd64-windows-nat.c: Sort headers.
7381 * amd64-tdep.c: Sort headers.
7382 * amd64-sol2-tdep.c: Sort headers.
7383 * amd64-obsd-tdep.c: Sort headers.
7384 * amd64-obsd-nat.c: Sort headers.
7385 * amd64-nbsd-tdep.c: Sort headers.
7386 * amd64-nbsd-nat.c: Sort headers.
7387 * amd64-nat.c: Sort headers.
7388 * amd64-linux-tdep.c: Sort headers.
7389 * amd64-linux-nat.c: Sort headers.
7390 * amd64-fbsd-tdep.c: Sort headers.
7391 * amd64-fbsd-nat.c: Sort headers.
7392 * amd64-dicos-tdep.c: Sort headers.
7393 * amd64-darwin-tdep.c: Sort headers.
7394 * amd64-bsd-nat.c: Sort headers.
7395 * alpha-tdep.c: Sort headers.
7396 * alpha-obsd-tdep.c: Sort headers.
7397 * alpha-nbsd-tdep.c: Sort headers.
7398 * alpha-mdebug-tdep.c: Sort headers.
7399 * alpha-linux-tdep.c: Sort headers.
7400 * alpha-linux-nat.c: Sort headers.
7401 * alpha-bsd-tdep.c: Sort headers.
7402 * alpha-bsd-nat.c: Sort headers.
7403 * aix-thread.c: Sort headers.
7404 * agent.c: Sort headers.
7405 * addrmap.c: Sort headers.
7406 * ada-varobj.c: Sort headers.
7407 * ada-valprint.c: Sort headers.
7408 * ada-typeprint.c: Sort headers.
7409 * ada-tasks.c: Sort headers.
7410 * ada-lang.c: Sort headers.
7411 * aarch64-tdep.c: Sort headers.
7412 * aarch64-ravenscar-thread.c: Sort headers.
7413 * aarch64-newlib-tdep.c: Sort headers.
7414 * aarch64-linux-tdep.c: Sort headers.
7415 * aarch64-linux-nat.c: Sort headers.
7416 * aarch64-fbsd-tdep.c: Sort headers.
7417 * aarch64-fbsd-nat.c: Sort headers.
7418 * aarch32-linux-nat.c: Sort headers.
7419
699bd4cf
TT
74202019-04-04 Tom Tromey <tom@tromey.com>
7421
7422 * varobj.c (varobj_create): Update.
7423 * rust-exp.y (struct rust_parser) <update_innermost_block,
7424 lookup_symbol>: New methods.
7425 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7426 Rename.
7427 (rust_parser::rust_lookup_type)
7428 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7429 * printcmd.c (display_command, do_one_display): Update.
7430 * parser-defs.h (struct parser_state) <parser_state>: Add
7431 "tracker" parameter.
7432 (block_tracker): New member.
7433 (class innermost_block_tracker) <innermost_block_tracker>: Add
7434 "types" parameter.
7435 <reset>: Remove method.
7436 (innermost_block): Don't declare.
7437 (null_post_parser): Update.
7438 * parse.c (innermost_block): Remove global.
7439 (write_dollar_variable): Update.
7440 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7441 Remove "tracker_types" parameter.
7442 (parse_expression): Add "tracker" parameter.
7443 (parse_expression_for_completion): Update.
7444 (null_post_parser): Add "tracker" parameter.
7445 * p-exp.y: Update rules.
7446 * m2-exp.y: Update rules.
7447 * language.h (struct language_defn) <la_post_parser>: Add
7448 "tracker" parameter.
7449 * go-exp.y: Update rules.
7450 * f-exp.y: Update rules.
7451 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7452 parameter.
7453 * d-exp.y: Update rules.
7454 * c-exp.y: Update rules.
7455 * breakpoint.c (set_breakpoint_condition): Create an
7456 innermost_block_tracker.
7457 (watch_command_1): Likewise.
7458 * ada-lang.c (resolve): Add "tracker" parameter.
7459 (resolve_subexp): Likewise.
7460 * ada-exp.y (write_var_from_sym): Update.
7461
dac43e32
TT
74622019-04-04 Tom Tromey <tom@tromey.com>
7463
7464 * type-stack.h: New file.
7465 * type-stack.c: New file.
7466 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7467 type-stack.h.
7468 (insert_into_type_stack, insert_type, push_type, push_type_int)
7469 (insert_type_address_space, pop_type, pop_type_int)
7470 (pop_typelist, pop_type_stack, append_type_stack)
7471 (push_type_stack, get_type_stack, push_typelist)
7472 (follow_type_instance_flags, follow_types): Don't declare.
7473 * parse.c (type_stack): Remove global.
7474 (parse_exp_in_context): Update.
7475 (insert_into_type_stack, insert_type, push_type, push_type_int)
7476 (insert_type_address_space, pop_type, pop_type_int)
7477 (pop_typelist, pop_type_stack, append_type_stack)
7478 (push_type_stack, get_type_stack, push_typelist)
7479 (follow_type_instance_flags, follow_types): Remove (moved to
7480 type-stack.c).
7481 * f-exp.y (type_stack): New global.
7482 Update rules.
7483 (push_kind_type, f_parse): Update.
7484 * d-exp.y (type_stack): New global.
7485 Update rules.
7486 (d_parse): Update.
7487 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7488 Update rules.
7489 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7490 (HFILES_NO_SRCDIR): Add type-stack.h.
7491
2a612529
TT
74922019-04-04 Tom Tromey <tom@tromey.com>
7493
7494 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7495 (rust_parser::convert_ast_to_expression, rust_parse)
7496 (rust_lex_test_completion, rust_lex_tests): Update.
7497 * parser-defs.h (struct expr_completion_state): New.
7498 (struct parser_state) <parser_state>: Add completion parameter.
7499 <mark_struct_expression, mark_completion_tag>: New methods.
7500 <parse_completion, m_completion_state>: New members.
7501 (prefixify_expression, null_post_parser): Update.
7502 (mark_struct_expression, mark_completion_tag): Don't declare.
7503 * parse.c (parse_completion, expout_last_struct)
7504 (expout_tag_completion_type, expout_completion_name): Remove
7505 globals.
7506 (parser_state::mark_struct_expression)
7507 (parser_state::mark_completion_tag): Now methods.
7508 (prefixify_expression): Add last_struct parameter.
7509 (prefixify_subexp): Likewise.
7510 (parse_exp_1): Update.
7511 (parse_exp_in_context): Add cstate parameter. Update.
7512 (parse_expression_for_completion): Create an
7513 expr_completion_state.
7514 (null_post_parser): Add "completion" parameter.
7515 * p-exp.y: Update rules.
7516 (yylex): Update.
7517 * language.h (struct language_defn) <la_post_parser>: Add
7518 "completing" parameter.
7519 * go-exp.y: Update rules.
7520 (lex_one_token): Update.
7521 * expression.h (parse_completion): Don't declare.
7522 * d-exp.y: Update rules.
7523 (lex_one_token): Update rules.
7524 * c-exp.y: Update rules.
7525 (lex_one_token): Update.
7526 * ada-lang.c (resolve): Add "parse_completion" parameter.
7527 (resolve_subexp): Likewise.
7528 (ada_resolve_function): Likewise.
7529
43476f0b
TT
75302019-04-04 Tom Tromey <tom@tromey.com>
7531
7532 * parser-defs.h (struct parser_state) <start_arglist,
7533 end_arglist>: New methods.
7534 <arglist_len, m_funcall_chain>: New members.
7535 (arglist_len, start_arglist, end_arglist): Don't declare.
7536 * parse.c (arglist_len, funcall_chain): Remove global.
7537 (start_arglist, end_arglist): Remove functions.
7538 (parse_exp_in_context): Update.
7539 * p-exp.y: Update rules.
7540 * m2-exp.y: Update rules.
7541 * go-exp.y: Update rules.
7542 * f-exp.y: Update rules.
7543 * d-exp.y: Update rules.
7544 * c-exp.y: Update rules.
7545
5776fca3
TT
75462019-04-04 Tom Tromey <tom@tromey.com>
7547
7548 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7549 lex_operator, push_back>: New methods.
7550 Update all rules.
7551 (rust_parser::lex_hex, lex_escape): Rename and update.
7552 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7553 (rust_parser::lex_operator): Rename and update.
7554 (rust_parser::lex_number, rustyylex, rustyyerror)
7555 (rust_lex_test_init, rust_lex_test_sequence)
7556 (rust_lex_test_push_back, rust_lex_tests): Update.
7557 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7558 parameter.
7559 <lexptr, prev_lexptr>: New members.
7560 (lexptr, prev_lexptr): Don't declare.
7561 * parse.c (lexptr, prev_lexptr): Remove globals.
7562 (parse_exp_in_context): Update.
7563 * p-exp.y (yylex, yyerror): Update.
7564 * m2-exp.y (parse_number, yylex, yyerror): Update.
7565 * go-exp.y (lex_one_token, yyerror): Update.
7566 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7567 * d-exp.y (lex_one_token, yyerror): Update.
7568 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7569 (lex_one_token, yyerror): Update.
7570 * ada-lex.l (YY_INPUT): Update.
7571 (rewind_to_char): Update.
7572 * ada-exp.y (yyerror): Update.
7573
8621b685
TT
75742019-04-04 Tom Tromey <tom@tromey.com>
7575
7576 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7577 * parser-defs.h (struct parser_state) <parser_state>: Add new
7578 parameter.
7579 <comma_terminates>: New member.
7580 (comma_terminates): Don't declare global.
7581 * parse.c (comma_terminates): Remove global.
7582 (parse_exp_in_context): Update.
7583 * p-exp.y (yylex): Update.
7584 * m2-exp.y (yylex): Update.
7585 * go-exp.y (lex_one_token): Update.
7586 * f-exp.y (yylex): Update.
7587 * d-exp.y (lex_one_token): Update.
7588 * c-exp.y (lex_one_token): Update.
7589 * ada-lex.l: Update.
7590
28aaf3fd
TT
75912019-04-04 Tom Tromey <tom@tromey.com>
7592
7593 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7594 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7595 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7596 * parser-defs.h (paren_depth): Don't declare.
7597 * parse.c (paren_depth): Remove global.
7598 (parse_exp_in_context): Update.
7599 * p-exp.y (paren_depth): New global.
7600 (pascal_parse): Initialize it.
7601 * m2-exp.y (paren_depth): New global.
7602 (m2_parse): Initialize it.
7603 * go-exp.y (paren_depth): New global.
7604 (go_parse): Initialize it.
7605 * f-exp.y (paren_depth): New global.
7606 (f_parse): Initialize it.
7607 * d-exp.y (paren_depth): New global.
7608 (d_parse): Initialize it.
7609 * c-exp.y (paren_depth): New global.
7610 (c_parse): Initialize it.
7611 * ada-lex.l (paren_depth): New global.
7612 (lexer_init): Initialize it.
7613
1e58a4a4
TT
76142019-04-04 Tom Tromey <tom@tromey.com>
7615
7616 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7617 (rust_parser::convert_ast_to_type)
7618 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7619 * parser-defs.h (struct parser_state) <parser_state>: Add
7620 parameters. Initialize new members.
7621 <expression_context_block, expression_context_pc>: New members.
7622 * parse.c (expression_context_block, expression_context_pc):
7623 Remove globals.
7624 (parse_exp_in_context): Update.
7625 * p-exp.y: Update all rules.
7626 (yylex): Update.
7627 * m2-exp.y: Update all rules.
7628 (yylex): Update.
7629 * go-exp.y (yylex): Update.
7630 * f-exp.y (yylex): Update.
7631 * d-exp.y: Update all rules.
7632 (yylex): Update.
7633 * c-exp.y: Update all rules.
7634 (lex_one_token, classify_name, yylex, c_parse): Update.
7635 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7636
37eedb39
TT
76372019-04-04 Tom Tromey <tom@tromey.com>
7638
7639 * gdbarch.h, gdbarch.c: Rebuild.
7640 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7641 * stap-probe.h:
7642 (struct stap_parse_info): Replace "parser_state" with
7643 "expr_builder".
7644 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7645 (parser_state): New class.
7646 * parse.c (expr_builder): Rename.
7647 (expr_builder::release): Rename.
7648 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7649 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7650 (write_exp_elt_longcst, write_exp_elt_floatcst)
7651 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7652 (write_exp_string_vector, write_exp_bitstring)
7653 (write_exp_msymbol, mark_struct_expression)
7654 (write_dollar_variable)
7655 (insert_type_address_space, increase_expout_size): Replace
7656 "parser_state" with "expr_builder".
7657 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7658 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7659 "parser_state" with "expr_builder".
7660
73923d7e
TT
76612019-04-04 Tom Tromey <tom@tromey.com>
7662
7663 * rust-exp.y: Replace "parse_language" with method call.
7664 * p-exp.y:
7665 (yylex): Replace "parse_language" with method call.
7666 * m2-exp.y:
7667 (yylex): Replace "parse_language" with method call.
7668 * go-exp.y (classify_name): Replace "parse_language" with method
7669 call.
7670 * f-exp.y (yylex): Replace "parse_language" with method call.
7671 * d-exp.y (lex_one_token): Replace "parse_language" with method
7672 call.
7673 * c-exp.y:
7674 (lex_one_token, classify_name, yylex): Replace "parse_language"
7675 with method call.
7676 * ada-exp.y (find_primitive_type, type_char)
7677 (type_system_address): Replace "parse_language" with method call.
7678
fa9f5be6
TT
76792019-04-04 Tom Tromey <tom@tromey.com>
7680
7681 * rust-exp.y: Replace "parse_gdbarch" with method call.
7682 * parse.c (write_dollar_variable, insert_type_address_space):
7683 Replace "parse_gdbarch" with method call.
7684 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7685 call.
7686 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7687 call.
7688 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7689 "parse_gdbarch" with method call.
7690 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7691 with method call.
7692 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7693 "parse_gdbarch" with method call.
7694 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7695 "parse_gdbarch" with method call.
7696 * c-exp.y (parse_type, parse_number, classify_name): Replace
7697 "parse_gdbarch" with method call.
7698 * ada-lex.l: Replace "parse_gdbarch" with method call.
7699 * ada-exp.y (parse_type, find_primitive_type, type_char)
7700 (type_system_address): Replace "parse_gdbarch" with method call.
7701
1201a264
TT
77022019-04-04 Tom Tromey <tom@tromey.com>
7703
7704 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7705 * stap-probe.c (stap_parse_argument): Update.
7706 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7707 initial_size parameter.
7708 * rust-exp.y (rust_lex_tests): Update.
7709 * parse.c (parser_state): Update.
7710 (parse_exp_in_context): Update.
7711 * parser-defs.h (struct parser_state) <parser_state>: Remove
7712 "initial_size" parameter.
7713
e3980ce2
TT
77142019-04-04 Tom Tromey <tom@tromey.com>
7715
7716 * parser-defs.h (increase_expout_size): Don't declare.
7717 * parse.c (increase_expout_size): Now static.
7718
e9f8e3f1
TS
77192019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7720
7721 * gnu-nat.c (gnu_nat_target::wait): Fix
7722 target_waitstatus_to_string call.
7723
d7df6549
AB
77242019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7725
7726 * eval.c (evaluate_subexp_standard): Handle internal functions
7727 during Fortran function call handling.
7728
8bdc1658
AB
77292019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7730
7731 * NEWS: Mention new internal functions.
7732 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7733 (read_base_type): Use dwarf2_init_complex_target_type.
7734 * value.c (creal_internal_fn): New function.
7735 (cimag_internal_fn): New function.
7736 (_initialize_values): Register new internal functions.
7737
c29705b7
PW
77382019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7739
7740 * infrun.c (stop_all_threads): If debug_infrun, always
7741 trace the wait status after wait_one, using
7742 target_waitstatus_to_string and target_pid_to_str.
7743 (handle_inferior_event): Replace various trace of
7744 wait status kind by a single trace.
7745 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7746 wait status kind image by target_waitstatus_to_string.
7747 * target/waitstatus.c (target_waitstatus_to_string): Fix
7748 obsolete comment.
7749
05caa1d2
TT
77502019-04-01 Tom Tromey <tromey@adacore.com>
7751
7752 PR symtab/23331:
7753 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7754
9d1447e0
SDJ
77552019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
7756 Pedro Alves <palves@redhat.com>
7757
7758 * top.c (quit_force): Call 'finalize_values'.
7759 * value.c (finalize_values): New function.
7760 * value.h (finalize_values): Declare.
7761
7734102d
EZ
77622019-03-30 Eli Zaretskii <eliz@gnu.org>
7763
7764 * NEWS: Announce $_gdb_major and $_gdb_minor.
7765
7766 * top.c (init_gdb_version_vars): New function.
7767 (gdb_init): Call init_gdb_version_vars.
7768
188e1fa9
TT
77692019-03-29 Tom Tromey <tromey@adacore.com>
7770
7771 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
7772 help text. Remove dead code.
7773
2880242d
KS
77742019-03-29 Keith Seitz <keiths@redhat.com>
7775
7776 From Siddhesh Poyarekar:
7777 * f-lang.h (f77_get_upperbound): Return LONGEST.
7778 (f77_get_lowerbound): Likewise.
7779 * f-typeprint.c (f_type_print_varspec_suffix): Expand
7780 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
7781 print them.
7782 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
7783 plongest to format print it.
7784 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7785 (f77_get_upperbound): Likewise.
7786 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7787 LOWER_BOUND to LONGEST.
7788 (f77_create_arrayprint_offset_tbl): Likewise.
7789
cc1defb1
KS
77902019-03-29 Keith Seitz <keiths@redhat.com>
7791
7792 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7793 %s/pulongest for TYPE_LENGTH instead of %d in format
7794 strings.
7795 * ada-typerint.c (ada_print_type): Likewise.
7796 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7797 * compile/compile-c-support.c (generate_register_struct): Likewise.
7798 * gdbtypes.c (recursive_dump_type): Likewise.
7799 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7800 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
7801 instead of %d in format strings.
7802 * riscv-tdep.c (riscv_type_alignment): Cast second argument
7803 to std::min to ULONGEST.
7804 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7805 instead of %d in format strings.
7806 * tracepoint.c (info_scope_command): Likewise.
7807 * typeprint.c (print_offset_data::update)
7808 (print_offset_data::finish): Likewise.
7809 * xtensa-tdep.c (xtensa_store_return_value)
7810 (xtensa_push_dummy_call): Likewise.
7811
e432ccf1
JT
78122019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
7813
7814 * windows-nat.c (display_selector): Fixed format specifications
7815 for 64-bit Cygwin.
7816
65d2b333
PW
78172019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7818
7819 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7820
f489207e
SL
78212019-03-28 Sandra Loosemore <sandra@codesourcery.com>
7822
7823 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7824 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7825 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7826 (nios2_linux_init_abi): Install it.
7827
bffa1015
AH
78282019-03-28 Alan Hayward <alan.hayward@arm.com>
7829
7830 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7831
fc96163a
AH
78322019-03-28 Alan Hayward <alan.hayward@arm.com>
7833
7834 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7835
20dc7e9b
PW
78362019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7837 Tom Tromey <tromey@adacore.com>
7838
7839 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7840
7f5331a8
JB
78412019-03-26 Joel Brobecker <brobecker@adacore.com>
7842
7843 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7844 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7845 method to compute the bounds of range types. Also print "[evaluated]"
7846 if the bounds' values come from a dynamic evaluation.
7847
18c77628
AB
78482019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7849
7850 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7851 whitespace when pretty printing is on.
7852
53c973f2
AH
78532019-03-26 Alan Hayward <alan.hayward@arm.com>
7854
e79be6e5 7855 * ppc-linux-nat.c: Add include.
53c973f2 7856
d851aa71
AH
78572019-03-26 Alan Hayward <alan.hayward@arm.com>
7858
e79be6e5 7859 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 7860
2fe7bab7
AH
78612019-03-26 Alan Hayward <alan.hayward@arm.com>
7862
e79be6e5 7863 * arm-linux-nat.c: Add include.
2fe7bab7 7864
068ef30e
SM
78652019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7866
7867 * source-cache.c (source_cache::get_source_lines): Re-read
7868 fullname after calling open_source_file.
7869
81a24d04
JB
78702019-03-25 John Baldwin <jhb@FreeBSD.org>
7871
7872 * NEWS: Mention TLS support for FreeBSD.
7873
79e7ae11
TT
78742019-03-25 Tom Tromey <tromey@adacore.com>
7875
7876 * minsyms.c (BUNCH_SIZE): Update comment.
7877 (~minimal_symbol_reader): Remove old comment.
7878 (compact_minimal_symbols): Update comment.
7879 (minimal_symbol_reader::install): Remove old comment. Update
7880 other comments.
7881
d45963c2
AH
78822019-03-25 Alan Hayward <alan.hayward@arm.com>
7883
7884 * s390-linux-nat.c: Add include.
7885
0f83012e
AH
78862019-03-25 Alan Hayward <alan.hayward@arm.com>
7887
7888 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7889 Call linux_get_hwcap.
7890 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7891 Likewise.
7892 (aarch64_linux_get_hwcap): Remove function.
7893 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7894 declaration.
7895 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7896 linux_get_hwcap.
7897 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7898 * linux-tdep.c (linux_get_hwcap): Add function.
7899 (linux_get_hwcap2): Likewise.
7900 * linux-tdep.h (linux_get_hwcap): Add declaration.
7901 (linux_get_hwcap2): Likewise.
7902 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7903 (ppc_linux_get_hwcap2): Likewise.
7904 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7905 linux_get_hwcap.
7906 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7907 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7908 (ppc_linux_nat_target::read_description): Likewise.
7909 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7910 * s390-linux-nat.c: Likewise.
7911 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7912
6640a367
TT
79132019-03-24 Tom Tromey <tom@tromey.com>
7914
7915 * ada-lang.c (standard_lookup): Simplify initialization.
7916 (ada_lookup_symbol_nonlocal): Simplify return.
7917 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7918 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7919 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7920 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7921 initialization.
7922 * solib.c (solib_global_lookup): Simplify.
7923 * symtab.c (null_block_symbol): Remove.
7924 (symbol_cache_lookup): Simplify returns.
7925 (lookup_language_this): Simplify returns.
7926 (lookup_symbol_aux): Simplify return.
7927 (lookup_local_symbol): Simplify returns.
7928 (lookup_global_symbol_from_objfile): Simplify return.
7929 (lookup_symbol_in_objfile_symtabs)
7930 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7931 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7932 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7933 * cp-namespace.c (cp_lookup_bare_symbol)
7934 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7935 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7936 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7937 (cp_lookup_symbol_via_imports): Simplify initialization.
7938 (find_symbol_in_baseclass): Likewise.
7939 * symtab.h (null_block_symbol): Remove.
7940 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7941 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7942 (d_lookup_symbol_module): Likewise.
7943 (find_symbol_in_baseclass): Simplify initialization.
7944
a930ebcd
TT
79452019-03-24 Tom Tromey <tom@tromey.com>
7946
7947 * expression.h: Don't include symtab.h.
7948 (struct block): Forward declare.
7949
582942f4
TT
79502019-03-24 Tom Tromey <tom@tromey.com>
7951
7952 * c-exp.y (typebase): Remove casts.
7953 * gdbtypes.c (lookup_unsigned_typename, )
7954 (lookup_signed_typename): Remove cast.
7955 * eval.c (parse_to_comma_and_eval): Remove cast.
7956 * parse.c (write_dollar_variable): Remove cast.
7957 * block.h (struct block) <superblock>: Now const.
7958 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7959 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7960 (map_block): Make "block" const.
7961 * symfile.h (struct quick_symbol_functions)
7962 <map_matching_symbols>: Constify block argument to "callback".
7963 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7964 const.
7965 (find_pc_sect_compunit_symtab): Make "b" const.
7966 (find_symbol_at_address): Likewise.
7967 (search_symbols): Likewise.
7968 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7969 (dw2_debug_names_lookup_symbol): Likewise.
7970 (dw2_map_matching_symbols): Update.
7971 * p-valprint.c (pascal_val_print): Remove "block".
7972 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7973 (aux_add_nonlocal_symbols): Make "block" const.
7974 (resolve_subexp): Remove cast.
7975 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7976 const.
7977 (iterate_over_file_blocks): Likewise.
7978 * f-exp.y (%union) <bval>: Remove.
7979 * coffread.c (patch_opaque_types): Make "b" const.
7980 * spu-tdep.c (spu_catch_start): Make "block" const.
7981 * c-valprint.c (print_unpacked_pointer): Remove "block".
7982 * symmisc.c (dump_symtab_1): Make "b" const.
7983 (block_depth): Make "block" const.
7984 * d-exp.y (%union) <bval>: Remove.
7985 * cp-support.h (cp_lookup_rtti_type): Update.
7986 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7987 * psymtab.c (psym_lookup_symbol): Make "block" const.
7988 (maintenance_check_psymtabs): Make "b" const.
7989 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7990 (enumerate_locals, enumerate_args): Update.
7991 * python/py-symtab.c (stpy_global_block): Make "block" const.
7992 (stpy_static_block): Likewise.
7993 * inline-frame.c (block_starting_point_at): Make "new_block"
7994 const.
7995 * block.c (find_block_in_blockvector): Make return type const.
7996 (blockvector_for_pc_sect): Make "b" const.
7997 (find_block_in_blockvector): Make "b" const.
7998
7ad417dd
TT
79992019-03-23 Tom Tromey <tom@tromey.com>
8000
8001 * varobj.c (varobj_create): Update.
8002 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8003 * printcmd.c (display_command, do_one_display): Don't reset
8004 innermost_block.
8005 * parser-defs.h (enum innermost_block_tracker_type): Move to
8006 expression.h.
8007 (innermost_block): Update comment.
8008 * parse.c (parse_exp_1): Add tracker_types parameter.
8009 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8010 tracker_types parameter. Reset innermost_block.
8011 (parse_exp_in_context): Remove.
8012 (parse_expression_for_completion): Update.
8013 * objfiles.c (~objfile): Don't reset expression_context_block or
8014 innermost_block.
8015 * expression.h (enum innermost_block_tracker_type): Move from
8016 parser-defs.h.
8017 (parse_exp_1): Add tracker_types parameter.
8018 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8019 reset innermost_block.
8020
b366c208
TT
80212019-03-23 Tom Tromey <tom@tromey.com>
8022
8023 * objfiles.h: Include bcache.h.
8024
9bb9b2f9
TT
80252019-03-23 Tom Tromey <tom@tromey.com>
8026
8027 * linespec.c (get_current_search_block): Use
8028 scoped_restore_current_language.
8029 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8030
59c28372
AH
80312019-03-22 Alan Hayward <alan.hayward@arm.com>
8032 Jiong Wang <jiong.wang@arm.com>
8033
8034 * aarch64-linux-tdep.c
8035 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8036 section.
8037 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8038
17e116a7
AH
80392019-03-22 Alan Hayward <alan.hayward@arm.com>
8040 Jiong Wang <jiong.wang@arm.com>
8041
8042 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8043 instructions.
8044 (aarch64_analyze_prologue_test): Add PACIASP test.
8045 (aarch64_prologue_prev_register): Unmask PC value.
8046
11e1b75f
AH
80472019-03-22 Alan Hayward <alan.hayward@arm.com>
8048 Jiong Wang <jiong.wang@arm.com>
8049
8050 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8051 (aarch64_dwarf2_prev_register): Unmask PC value.
8052 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8053 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8054 DW_CFA_AARCH64_negate_ra_state.
8055 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8056
34dcc7cf
AH
80572019-03-22 Alan Hayward <alan.hayward@arm.com>
8058 Jiong Wang <jiong.wang@arm.com>
8059
8060 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8061 registers.
8062 (aarch64_pseudo_register_name): Likewise.
8063 (aarch64_pseudo_register_type): Likewise.
8064 (aarch64_pseudo_register_reggroup_p): Likewise.
8065 (aarch64_gdbarch_init): Add pauth registers.
8066 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8067 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8068 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8069 (struct gdbarch_tdep): Add regnum for ra_state.
8070
1ef53e6b
AH
80712019-03-22 Alan Hayward <alan.hayward@arm.com>
8072 Jiong Wang <jiong.wang@arm.com>
8073
8074 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8075
76bed0fd
AH
80762019-03-22 Alan Hayward <alan.hayward@arm.com>
8077 Jiong Wang <jiong.wang@arm.com>
8078
8079 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8080 function.
8081 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8082 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8083 (aarch64_gdbarch_init): Add puth registers.
8084 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8085 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8086 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8087
ee4fbcfa
AH
80882019-03-22 Alan Hayward <alan.hayward@arm.com>
8089 Jiong Wang <jiong.wang@arm.com>
8090
8091 * aarch64-linux-nat.c
8092 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8093 * aarch64-linux-tdep.c
8094 (aarch64_linux_core_read_description): Likewise.
8095 (aarch64_linux_get_hwcap): New function.
8096 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8097 (aarch64_linux_get_hwcap): New declaration.
8098
6dc0ebde
AH
80992019-03-22 Alan Hayward <alan.hayward@arm.com>
8100 Jiong Wang <jiong.wang@arm.com>
8101
8102 * aarch64-linux-nat.c
8103 (aarch64_linux_nat_target::read_description): Add pauth param.
8104 * aarch64-linux-tdep.c
8105 (aarch64_linux_core_read_description): Likewise.
8106 * aarch64-tdep.c (struct target_desc): Add in pauth.
8107 (aarch64_read_description): Add pauth param.
8108 (aarch64_gdbarch_init): Likewise.
8109 * aarch64-tdep.h (aarch64_read_description): Likewise.
8110 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8111 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8112 * features/Makefile: Add new files.
8113 * features/aarch64-pauth.c: New file.
8114 * features/aarch64-pauth.xml: New file.
8115
595915c1
TT
81162019-03-20 Tom Tromey <tromey@adacore.com>
8117
8118 * infrun.c (handle_inferior_event): Rename from
8119 handle_inferior_event_1. Create a scoped_value_mark.
8120 (handle_inferior_event): Remove.
8121
4c7d57e7
TT
81222019-03-19 Tom Tromey <tromey@adacore.com>
8123
8124 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8125 * infrun.h (print_stop_event): Add "displays" parameter.
8126 * infrun.c (print_stop_event): Add "displays" parameter.
8127
cb246234
PA
81282019-03-19 Pedro Alves <palves@redhat.com>
8129
8130 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8131 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8132 to -1. Fix TABs vs spaces.
8133 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8134 * tui/tui-out.h (tui_ui_out) Add intro comments.
8135 <m_line, m_start_of_line>: In-class initialize, and add describing
8136 comment.
8137
3a0e45b2
AH
81382019-03-18 Alan Hayward <alan.hayward@arm.com>
8139
8140 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8141 variable names.
8142 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8143
5371b850
PA
81442019-03-18 Pedro Alves <palves@redhat.com>
8145 Eli Zaretskii <eliz@gnu.org>
8146
8147 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8148 m_line and m_start_of_line.
8149
b17c4cd0
EZ
81502019-03-18 Eli Zaretskii <eliz@gnu.org>
8151
8152 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8153 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8154 it returns a newline. This fixes a regression in TU mode, whereby
8155 the next line is output on the same screen line as the user input.
8156
4bd56d18
TT
81572019-03-18 Tom Tromey <tromey@adacore.com>
8158
8159 * minsyms.c (minimal_symbol_reader::install): Remove call to
8160 obstack_blank.
8161
55c10aca
PA
81622019-03-18 Pedro Alves <palves@redhat.com>
8163
8164 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8165 New globals.
8166 (apply_style): New, factored out from ...
8167 (apply_ansi_escape): ... this. Handle reverse video mode.
8168 (tui_set_reverse_mode): New function.
8169 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8170 * tui/tui-winsource.c (tui_show_source_line): Use
8171 tui_set_reverse_mode instead of setting A_STANDOUT.
8172 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8173 New setter methods.
8174
647bb750
HD
81752019-03-18 Hannes Domani <ssbssa@yahoo.de>
8176
8177 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8178 Handle tabs.
8179
bff8c71f
TT
81802019-03-18 Tom Tromey <tromey@adacore.com>
8181
8182 * ada-lang.c (empty_array): Add "high" parameter.
8183 (ada_evaluate_subexp): Update.
8184
58785d98
ST
81852019-03-17 Sergei Trofimovich <siarheit@google.com>
8186
8187 * unittests/string_view-selftests.c: Define
8188 _initialize_string_view_selftests unconditionally.
8189
d4cbef22
ВМ
81902019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8191
8192 PR gdb/24350
8193 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8194
fce4c071
ВМ
81952019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8196
8197 PR gdb/24351
8198 * windows-nat.c (display_selector): Fix format specifiers.
8199
f7f0a123
EZ
82002019-03-17 Eli Zaretskii <eliz@gnu.org>
8201
8202 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8203 tui_refill_source_window instead of tui_refresh_win, to update the
8204 current execution line. This fixes redisplay of the current line
8205 when stepping through the code with "next" or "step".
8206
ab42892f
EZ
82072019-03-16 Eli Zaretskii <eliz@gnu.org>
8208
8209 * source-cache.c (source_cache::get_source_lines): Call
8210 find_source_lines to initialize s->nlines. This fixes vertical
8211 scrolling of TUI source window when the DOWN arrow is pressed.
8212
8d8c087f
PW
82132019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8214
8215 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8216 linux-thread-db.c (_initialize_thread_db): Likewise.
8217
798e1c30
EZ
82182019-03-16 Eli Zaretskii <eliz@gnu.org>
8219
8220 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8221 wclrtoeol in tui_show_source_line". This reverts changes made in
8222 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8223
eefba3da
TT
82242019-03-15 Tom Tromey <tom@tromey.com>
8225
8226 * symtab.h (struct minimal_symbol): Derive from
8227 general_symbol_info.
8228 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8229 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8230 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8231 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8232 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8233 (MSYMBOL_SEARCH_NAME): Update.
8234 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8235 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8236 * minsyms.c (minimal_symbol_reader::record_full): Update.
8237
0de2420c
TT
82382019-03-15 Tom Tromey <tom@tromey.com>
8239
8240 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8241
042d75e4
TT
82422019-03-15 Tom Tromey <tom@tromey.com>
8243
8244 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8245 unique_xmalloc_ptr.
8246 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8247 Update.
8248 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8249 (build_minimal_symbol_hash_tables)
8250 (minimal_symbol_reader::install): Update.
8251
db92718b
TT
82522019-03-15 Tom Tromey <tom@tromey.com>
8253
8254 * symtab.c (create_demangled_names_hash): Update.
8255 (symbol_set_names): Update.
8256 * objfiles.h (struct objfile_per_bfd_storage)
8257 <demangled_names_hash>: Now an htab_up.
8258 * objfiles.c (objfile_per_bfd_storage): Simplify.
8259
d6797f46
TT
82602019-03-15 Tom Tromey <tom@tromey.com>
8261
8262 * objfiles.h (struct objfile_per_bfd_storage): Declare
8263 destructor.
8264 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8265 New.
8266 (get_objfile_bfd_data): Use new. Don't initialize
8267 language_of_main.
8268 (free_objfile_per_bfd_storage): Remove.
8269 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8270
741d7538
TT
82712019-03-15 Tom Tromey <tom@tromey.com>
8272
8273 * symfile.c (reread_symbols): Update.
8274 * objfiles.c (objfile::objfile): Update.
8275 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8276 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8277 comment.
8278 (minimal_symbol_reader::install): Update.
8279 (terminate_minimal_symbol_table): Remove.
8280 * jit.c (jit_object_close_impl): Update.
8281
788c80d1
TT
82822019-03-15 Tom Tromey <tom@tromey.com>
8283
8284 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8285 initializations.
8286
1b7a07cb
TT
82872019-03-15 Tom Tromey <tom@tromey.com>
8288
8289 * objfiles.h (struct objfile_per_bfd_storage)
8290 <demangled_hash_languages>: Now a bitset.
8291 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8292 (lookup_minimal_symbol): Update.
8293
3db066bc
TT
82942019-03-15 Tom Tromey <tom@tromey.com>
8295
8296 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8297 Don't return the symbol.
8298 * coffread.c (record_minimal_symbol): Use record_full.
8299
3fff2c37
EZ
83002019-03-14 Eli Zaretskii <eliz@gnu.org>
8301
8302 The MS-Windows port of ncurses fails to switch to a color pair if
8303 one or both of the colors are the implicit default colors. This
8304 change records the default colors when TUI is initialized, and
8305 then specifies them explicitly when a color pair uses the default
8306 colors. This allows color styling in TUI mode on MS-Windows.
8307
8308 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8309 ncurses_norm_attr.
8310 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8311 colors in ncurses_norm_attr.
8312 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8313 "none", replace it with the default color recorded in
8314 ncurses_norm_attr.
8315
3b336828
TT
83162019-03-14 Tom Tromey <tromey@adacore.com>
8317
8318 * source-cache.h (class source_cache) <get_source_lines>: Return
8319 std::string.
8320 * source-cache.c (source_cache::extract_lines): Handle case where
8321 first_pos==npos. Return std::string.
8322 (source_cache::get_source_lines): Update.
8323
d085f989
TT
83242019-03-14 Tom Tromey <tromey@adacore.com>
8325
8326 * NEWS: Add item for "style sources" commands.
8327 * source-cache.c (source_cache::get_source_lines): Check
8328 source_styling.
8329 * cli/cli-style.c (source_styling): New global.
8330 (_initialize_cli_style): Add "style sources" commands.
8331 (show_style_sources): New function.
8332 * cli/cli-style.h (source_styling): Declare.
8333
6f11e682
TT
83342019-03-14 Pedro Alves <palves@redhat.com>
8335 Tom Tromey <tromey@adacore.com>
8336
8337 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8338 * tui/tui-winsource.c (tui_refill_source_window): New function,
8339 from...
8340 (tui_horizontal_source_scroll): ... here. Move some logic.
8341 * cli/cli-style.c (set_style_enabled): Notify new observable.
8342 * tui/tui-hooks.c (tui_redisplay_source): New function.
8343 (tui_attach_detach_observers): Attach or detach
8344 tui_redisplay_source.
8345 * observable.h (source_styling_changed): New observable.
8346 * observable.c: Define source_styling_changed observable.
8347
a068643d
TT
83482019-03-13 Tom Tromey <tromey@adacore.com>
8349
8350 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8351 (i386_gnu_nat_target::store_registers): Update.
8352 * target-debug.h (target_debug_print_std_string): New macro.
8353 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8354 * windows-tdep.c (display_one_tib): Update.
8355 * tui/tui-stack.c (tui_make_status_line): Update.
8356 * top.c (print_inferior_quit_action): Update.
8357 * thread.c (thr_try_catch_cmd): Update.
8358 (add_thread_with_info): Update.
8359 (thread_target_id_str): Update.
8360 (thr_try_catch_cmd): Update.
8361 (thread_command): Update.
8362 (thread_find_command): Update.
8363 * record-btrace.c (record_btrace_target::info_record)
8364 (record_btrace_resume_thread, record_btrace_target::resume)
8365 (record_btrace_cancel_resume, record_btrace_step_thread)
8366 (record_btrace_target::wait, record_btrace_target::wait)
8367 (record_btrace_target::wait, record_btrace_target::stop): Update.
8368 * progspace.c (print_program_space): Update.
8369 * process-stratum-target.c
8370 (process_stratum_target::thread_address_space): Update.
8371 * linux-fork.c (linux_fork_mourn_inferior)
8372 (detach_checkpoint_command, info_checkpoints_command)
8373 (linux_fork_context): Update.
8374 (linux_fork_detach): Update.
8375 (class scoped_switch_fork_info): Update.
8376 (delete_checkpoint_command): Update.
8377 * infrun.c (follow_fork_inferior): Update.
8378 (follow_fork_inferior): Update.
8379 (proceed_after_vfork_done): Update.
8380 (handle_vfork_child_exec_or_exit): Update.
8381 (follow_exec): Update.
8382 (displaced_step_prepare_throw): Update.
8383 (displaced_step_restore): Update.
8384 (start_step_over): Update.
8385 (resume_1): Update.
8386 (clear_proceed_status_thread): Update.
8387 (proceed): Update.
8388 (print_target_wait_results): Update.
8389 (do_target_wait): Update.
8390 (context_switch): Update.
8391 (stop_all_threads): Update.
8392 (restart_threads): Update.
8393 (finish_step_over): Update.
8394 (handle_signal_stop): Update.
8395 (switch_back_to_stepped_thread): Update.
8396 (keep_going_pass_signal): Update.
8397 (print_exited_reason): Update.
8398 (normal_stop): Update.
8399 * inferior.c (inferior_pid_to_str): Change return type.
8400 (print_selected_inferior): Update.
8401 (add_inferior): Update.
8402 (detach_inferior): Update.
8403 * dummy-frame.c (fprint_dummy_frames): Update.
8404 * dcache.c (dcache_info_1): Update.
8405 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8406 (btrace_fetch, btrace_clear): Update.
8407 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8408 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8409 type.
8410 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8411 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8412 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8413 * gdbarch.c, gdbarch.h: Rebuild.
8414 * gdbarch.sh (core_pid_to_str): Change return type.
8415 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8416 return type.
8417 (windows_nat_target::pid_to_str): Change return type.
8418 (windows_delete_thread): Update.
8419 (windows_nat_target::attach): Update.
8420 (windows_nat_target::files_info): Update.
8421 * target-delegates.c: Rebuild.
8422 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8423 return type.
8424 (sol_thread_target::pid_to_str): Change return type.
8425 * remote.c (class remote_target) <pid_to_str>: Change return
8426 type.
8427 (remote_target::pid_to_str): Change return type.
8428 (extended_remote_target::attach, remote_target::remote_stop_ns)
8429 (remote_target::remote_notif_remove_queued_reply)
8430 (remote_target::push_stop_reply, remote_target::disable_btrace):
8431 Update.
8432 (extended_remote_target::attach): Update.
8433 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8434 type.
8435 (gdbsim_target::pid_to_str): Change return type.
8436 * ravenscar-thread.c (struct ravenscar_thread_target)
8437 <pid_to_str>: Change return type.
8438 (ravenscar_thread_target::pid_to_str): Change return type.
8439 * procfs.c (class procfs_target) <pid_to_str>: Change return
8440 type.
8441 (procfs_target::pid_to_str): Change return type.
8442 (procfs_target::attach): Update.
8443 (procfs_target::detach): Update.
8444 (procfs_target::fetch_registers): Update.
8445 (procfs_target::store_registers): Update.
8446 (procfs_target::wait): Update.
8447 (procfs_target::files_info): Update.
8448 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8449 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8450 return type.
8451 (nto_procfs_target::pid_to_str): Change return type.
8452 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8453 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8454 return type.
8455 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8456 (exit_lwp): Update.
8457 (attach_proc_task_lwp_callback, get_detach_signal)
8458 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8459 (linux_nat_target::resume, wait_lwp, stop_callback)
8460 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8461 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8462 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8463 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8464 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8465 type.
8466 (inf_ptrace_target::attach): Update.
8467 (inf_ptrace_target::files_info): Update.
8468 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8469 type.
8470 (go32_nat_target::pid_to_str): Change return type.
8471 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8472 (gnu_nat_target::wait): Update.
8473 (gnu_nat_target::wait): Update.
8474 (gnu_nat_target::resume): Update.
8475 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8476 (fbsd_nat_target::wait): Update.
8477 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8478 type.
8479 (darwin_nat_target::attach): Update.
8480 * corelow.c (class core_target) <pid_to_str>: Change return type.
8481 (core_target::pid_to_str): Change return type.
8482 * target.c (normal_pid_to_str): Change return type.
8483 (default_pid_to_str): Likewise.
8484 (target_pid_to_str): Change return type.
8485 (target_translate_tls_address): Update.
8486 (target_announce_detach): Update.
8487 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8488 return type.
8489 (bsd_uthread_target::pid_to_str): Change return type.
8490 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8491 type.
8492 (bsd_kvm_target::pid_to_str): Change return type.
8493 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8494 return type.
8495 (aix_thread_target::pid_to_str): Change return type.
8496 * target.h (struct target_ops) <pid_to_str>: Change return type.
8497 (target_pid_to_str, normal_pid_to_str): Likewise.
8498 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8499 type.
8500 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8501 type.
8502 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8503 return type.
8504 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8505 type.
8506 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8507 type.
8508 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8509 return type.
8510
b4be1b06
SM
85112019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8512
8513 * NEWS: Mention that the new default MI version is 3. Mention
8514 changes to the output of commands and events that deal with
8515 multi-location breakpoints.
8516 * breakpoint.c: Include "mi/mi-out.h".
8517 (print_one_breakpoint): Change output syntax if using MI version
8518 >= 3.
8519 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8520 New.
8521 (mi_multi_location_breakpoint_output_fixed): New.
8522 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8523 (mi_cmd_fix_multi_location_breakpoint_output): New.
8524 (mi_multi_location_breakpoint_output_fixed): New.
8525 * mi/mi-cmds.c (mi_cmds): Register command
8526 -fix-multi-location-breakpoint-output.
8527 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8528 interpreter "mi".
8529
8e5e5494
SM
85302019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8531
8532 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8533 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8534 instantiate mi_ui_out based on interpreter name.
8535 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8536 * mi/mi-main.c (mi_load_progress): Likewise.
8537
197df35e
JB
85382019-03-12 John Baldwin <jhb@FreeBSD.org>
8539
8540 * NEWS: Combine separate "New targets" sections for 8.3.
8541
8399425f
JB
85422019-03-12 John Baldwin <jhb@FreeBSD.org>
8543
8544 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8545 (ppcfbsd_init_abi): Install gdbarch
8546 "fetch_tls_load_module_address" and "get_thread_local_address"
8547 methods.
8548
b0f87ed0
JB
85492019-03-12 John Baldwin <jhb@FreeBSD.org>
8550
8551 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8552 (riscv_fbsd_init_abi): Install gdbarch
8553 "fetch_tls_load_module_address" and "get_thread_local_address"
8554 methods.
8555
ce25aa57
JB
85562019-03-12 John Baldwin <jhb@FreeBSD.org>
8557
8558 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8559 (i386fbsd_init_abi): Install gdbarch
8560 "fetch_tls_load_module_address" and "get_thread_local_address"
8561 methods.
8562
f5424cfa
JB
85632019-03-12 John Baldwin <jhb@FreeBSD.org>
8564
8565 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8566 (amd64fbsd_init_abi): Install gdbarch
8567 "fetch_tls_load_module_address" and "get_thread_local_address"
8568 methods.
8569
945f3901
JB
85702019-03-12 John Baldwin <jhb@FreeBSD.org>
8571
8572 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8573 (struct fbsd_pspace_data): New type.
8574 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8575 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8576 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8577 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8578 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8579
ef0bd204
JB
85802019-03-12 John Baldwin <jhb@FreeBSD.org>
8581
8582 * gdbtypes.c (lookup_struct_elt): New function.
8583 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8584 * gdbtypes.h (struct struct_elt): New type.
8585 (lookup_struct_elt): New prototype.
8586
36c53a02
JB
85872019-03-12 John Baldwin <jhb@FreeBSD.org>
8588
8589 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8590 remove disabled code block.
8591
6e056c81
JB
85922019-03-12 John Baldwin <jhb@FreeBSD.org>
8593
8594 * gdbarch.sh (get_thread_local_address): New method.
8595 * gdbarch.h, gdbarch.c: Regenerate.
8596 * target.c (target_translate_tls_address): Use
8597 gdbarch_get_thread_local_address if present instead of
8598 target::get_thread_local_address.
8599
cd250a18
JB
86002019-03-12 John Baldwin <jhb@FreeBSD.org>
8601
8602 * target.h (target::get_thread_local_address): Update comment.
8603
df22c1e5
JB
86042019-03-12 John Baldwin <jhb@FreeBSD.org>
8605
8606 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8607 objfile->separate_debug_objfile_backlink if not NULL.
8608
dd6876c9
JB
86092019-03-12 John Baldwin <jhb@FreeBSD.org>
8610
8611 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8612 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8613 (amd64bsd_store_inferior_registers): Likewise.
8614 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8615 Enable segment base registers.
8616 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8617 PT_GETFSBASE and PT_GETGSBASE.
8618 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8619 PT_SETGSBASE.
8620 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8621 segment base registers.
8622 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8623
1163a4b7
JB
86242019-03-12 John Baldwin <jhb@FreeBSD.org>
8625
8626 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8627 Update calls to i386_target_description to add 'segments'
8628 parameter.
8629 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8630 add segment base registers.
8631 * arch/i386.c (i386_create_target_description): Add 'segments'
8632 parameter to enable segment base registers.
8633 * arch/i386.h (i386_create_target_description): Likewise.
8634 * features/i386/32bit-segments.xml: New file.
8635 * features/i386/32bit-segments.c: Generate.
8636 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8637 call to i386_target_description to add 'segments' parameter.
8638 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8639 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8640 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8641 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8642 if feature is present.
8643 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8644 Add 'segments' parameter to call to i386_target_description.
8645 (i386_target_description): Add 'segments' parameter to enable
8646 segment base registers.
8647 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8648 to call to i386_target_description.
8649 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8650 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8651 Define I386_NUM_REGS.
8652 (i386_target_description): Add 'segments' parameter to enable
8653 segment base registers.
8654
3a350822
EZ
86552019-03-12 Eli Zaretskii <eliz@gnu.org>
8656
8657 PR/24325
8658 * source-cache.c: #undef open and close, to avoid unresolved
8659 externals during linking.
8660
ffdd69cf
TT
86612019-03-12 Tom Tromey <tromey@adacore.com>
8662
8663 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8664 const. Add initializers.
8665 (_initialize_remote): Don't initialize ptid globals.
8666
ec148c57
PA
86672019-03-12 Pedro Alves <palves@redhat.com>
8668
8669 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8670
32764270
PA
86712019-03-12 Pedro Alves <palves@redhat.com>
8672
8673 * cp-name-parser.y (main): Remove unused 'len' variable.
8674
17547186
TT
86752019-03-12 Tom Tromey <tromey@adacore.com>
8676
8677 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8678 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8679
d3a70e03
TT
86802019-03-12 Tom Tromey <tromey@adacore.com>
8681
8682 * linux-nat.c (iterate_over_lwps): Update.
8683 (stop_callback): Remove parameter.
8684 (stop_wait_callback, detach_callback, resume_set_callback)
8685 (select_singlestep_lwp_callback, set_ignore_sigint)
8686 (status_callback, resumed_callback, resume_clear_callback)
8687 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8688 data parameter.
8689 (linux_nat_target::detach, linux_nat_target::resume)
8690 (linux_stop_and_wait_all_lwps, select_event_lwp)
8691 (linux_nat_filter_event, linux_nat_wait_1)
8692 (linux_nat_target::kill, linux_nat_target::stop)
8693 (linux_nat_target::stop): Update.
8694 (linux_nat_resume_callback): Change type.
8695 (resume_stopped_resumed_lwps, count_events_callback)
8696 (select_event_lwp_callback): Likewise.
8697 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8698 * arm-linux-nat.c (struct update_registers_data): Remove.
8699 (update_registers_callback): Change type.
8700 (arm_linux_insert_hw_breakpoint1): Update.
8701 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8702 parameter.
8703 (x86_linux_dr_set_addr): Update.
8704 (x86_linux_dr_set_control): Update.
8705 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8706 (iterate_over_lwps): Use gdb::function_view.
8707 * nat/aarch64-linux-hw-point.c (struct
8708 aarch64_dr_update_callback_param): Remove.
8709 (debug_reg_change_callback): Change type.
8710 (aarch64_notify_debug_reg_change): Update.
8711 * s390-linux-nat.c (s390_refresh_per_info): Update.
8712
82cb27ff
TT
87132019-03-11 Tom Tromey <tromey@adacore.com>
8714
8715 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8716 redundant assignment to "this_cu".
8717
568c0683
SM
87182019-03-08 Simon Marchi <simon.marchi@efficios.com>
8719
8720 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8721
f09ce22d
SM
87222019-03-08 Simon Marchi <simon.marchi@efficios.com>
8723
8724 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8725 from...
8726 (rank_one_type): ... this.
8727
595f96a9
SM
87282019-03-08 Simon Marchi <simon.marchi@efficios.com>
8729
8730 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8731 from...
8732 (rank_one_type): ... this.
8733
2598a94b
SM
87342019-03-08 Simon Marchi <simon.marchi@efficios.com>
8735
8736 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8737 from...
8738 (rank_one_type): ... this.
8739
7f17b20d
SM
87402019-03-08 Simon Marchi <simon.marchi@efficios.com>
8741
8742 * gdbtypes.c (rank_one_type_parm_float): New function extracted
8743 from...
8744 (rank_one_type): ... this.
8745
2c509035
SM
87462019-03-08 Simon Marchi <simon.marchi@efficios.com>
8747
8748 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8749 from...
8750 (rank_one_type): ... this.
8751
0dd322dc
SM
87522019-03-08 Simon Marchi <simon.marchi@efficios.com>
8753
8754 * gdbtypes.c (rank_one_type_parm_range): New function extracted
8755 from...
8756 (rank_one_type): ... this.
8757
41ea4728
SM
87582019-03-08 Simon Marchi <simon.marchi@efficios.com>
8759
8760 * gdbtypes.c (rank_one_type_parm_char): New function extracted
8761 from...
8762 (rank_one_type): ... this.
8763
793cd1d2
SM
87642019-03-08 Simon Marchi <simon.marchi@efficios.com>
8765
8766 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8767 from...
8768 (rank_one_type): ... this.
8769
34910087
SM
87702019-03-08 Simon Marchi <simon.marchi@efficios.com>
8771
8772 * gdbtypes.c (rank_one_type_parm_int): New function extracted
8773 from...
8774 (rank_one_type): ... this.
8775
f1f832d6
SM
87762019-03-08 Simon Marchi <simon.marchi@efficios.com>
8777
8778 * gdbtypes.c (rank_one_type_parm_func): New function extracted
8779 from...
8780 (rank_one_type): ... this.
8781
b9f4512f
SM
87822019-03-08 Simon Marchi <simon.marchi@efficios.com>
8783
8784 * gdbtypes.c (rank_one_type_parm_array): New function extracted
8785 from...
8786 (rank_one_type): ... this.
8787
9293fc63
SM
87882019-03-08 Simon Marchi <simon.marchi@efficios.com>
8789
8790 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8791 from...
8792 (rank_one_type): ... this.
8793
e3abbe7e
PW
87942019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8795
8796 * inferior.c (initialize_inferiors): Ensure 'help set/show print
8797 inferior-events' shows the example events.
8798
e4adb939
EZ
87992019-03-08 Eli Zaretskii <eliz@gnu.org>
8800
8801 Support styling on native MS-Windows console
8802
8803 PR/24315
8804 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8805 on MS-Windows if $TERM is not defined.
8806
8807 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8808
8809 * posix-hdep.c (gdb_console_fputs):
8810 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8811 functions.
8812 * ui-file.h (gdb_console_fputs): Add prototype.
8813
8814 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8815 back to fputs only if the former returns zero.
8816
25629dfd
TT
88172019-03-07 Tom Tromey <tom@tromey.com>
8818
8819 * symmisc.c (print_symbol_bcache_statistics): Update.
8820 (print_objfile_statistics): Update.
8821 * symfile.c (allocate_symtab): Update.
8822 * stabsread.c: Don't include bcache.h.
8823 * psymtab.h (struct psymbol_bcache): Don't declare.
8824 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8825 (psymbol_bcache_init, psymbol_bcache_free)
8826 (psymbol_bcache_get_bcache): Don't declare.
8827 * psymtab.c (struct psymbol_bcache): Remove.
8828 (psymtab_storage::psymtab_storage): Update.
8829 (psymtab_storage::~psymtab_storage): Update.
8830 (psymbol_bcache_init, psymbol_bcache_free)
8831 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8832 (add_psymbol_to_bcache): Update.
8833 (allocate_psymtab): Update.
8834 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8835 macro_cache>: No longer pointers.
8836 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8837 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8838 * macrotab.c (macro_bcache): Update.
8839 * macroexp.c: Don't include bcache.h.
8840 * gdbtypes.c (check_types_worklist): Update.
8841 (types_deeply_equal): Remove TRY/CATCH. Update.
8842 * elfread.c (elf_symtab_read): Update.
8843 * dwarf2read.c: Don't include bcache.h.
8844 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8845 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8846 (print_bcache_statistics, bcache_memory_used): Don't declare.
8847 (struct bcache): Move from bcache.c. Add constructor, destructor,
8848 methods. Rename all data members.
8849 * bcache.c (struct bcache): Move to bcache.h.
8850 (bcache::expand_hash_table): Rename from expand_hash_table.
8851 (bcache): Remove.
8852 (bcache::insert): Rename from bcache_full.
8853 (bcache::compare): Rename from bcache_compare.
8854 (bcache_xmalloc): Remove.
8855 (bcache::~bcache): Rename from bcache_xfree.
8856 (bcache::print_statistics): Rename from print_bcache_statistics.
8857 (bcache::memory_used): Rename from bcache_memory_used.
8858
fe726667
PA
88592019-03-07 Pedro Alves <palves@redhat.com>
8860
8861 * infrun.c (normal_stop): Also check for
8862 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8863
7584bb30
AB
88642019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8865
8866 * f-lang.c (value_from_host_double): Moved to...
8867 * value.c (value_from_host_double): ...here.
8868 * value.h (value_from_host_double): Declare.
8869 * guile/scm-math.c (vlscm_convert_typed_number): Use
8870 value_from_host_double.
8871 (vlscm_convert_number): Likewise.
8872 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8873 * python/py-value.c (convert_value_from_python): Likewise.
8874
a7b1986e
TT
88752019-03-06 Tom Tromey <tom@tromey.com>
8876
8877 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8878
0ccf4211
TT
88792019-03-06 Tom Tromey <tom@tromey.com>
8880
8881 * utils.h (free_current_contents): Don't declare.
8882 * utils.c (free_current_contents): Remove.
8883
fe7b42e5
TT
88842019-03-06 Tom Tromey <tom@tromey.com>
8885
8886 * top.c (quit_force): Update.
8887 * main.c (captured_command_loop): Update.
8888 * common/new-op.c (operator new): Update.
8889 * common/common-exceptions.c (struct catcher)
8890 <save_cleanup_chain>: Remove member.
8891 (exceptions_state_mc_init): Update.
8892 (exception_try_scope_entry): Return nullptr.
8893 (exception_try_scope_exit, exception_rethrow)
8894 (throw_exception_sjlj, throw_exception_cxx): Update.
8895 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8896 (all_cleanups, do_cleanups, discard_cleanups)
8897 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8898 (restore_cleanups, restore_final_cleanups): Don't declare.
8899 (do_final_cleanups): Remove parameter.
8900 * common/cleanups.c (cleanup_chain, make_cleanup)
8901 (make_cleanup_dtor, all_cleanups, do_cleanups)
8902 (discard_my_cleanups, discard_cleanups)
8903 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8904 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8905 (null_cleanup): Remove.
8906 (do_final_cleanups): Remove parameter.
8907
c6321f19
TT
89082019-03-06 Tom Tromey <tom@tromey.com>
8909
8910 * remote.c (remote_target::remote_parse_stop_reply): Use
8911 unique_xmalloc_ptr.
8912
61b30099
TT
89132019-03-06 Tom Tromey <tom@tromey.com>
8914
8915 * stabsread.c (struct stabs_field_info): Rename from field_info.
8916 <list, fnlist>: Add initializers.
8917 <obstack>: New member.
8918 (read_member_functions, read_struct_fields, read_baseclasses):
8919 Allocate on obstack. Don't use cleanups.
8920 (read_one_struct_field, read_member_functions, read_struct_fields)
8921 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8922 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8923 (read_struct_type): Update.
8924
6cceac94
TT
89252019-03-06 Tom Tromey <tom@tromey.com>
8926
8927 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8928 * common/filestuff.h (make_cleanup_close): Don't declare.
8929 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8930 Remove.
8931
72412762
TT
89322019-03-06 Tom Tromey <tom@tromey.com>
8933
8934 * solib-aix.c: Use make_scope_exit.
8935
2b6ff1c0
TT
89362019-03-06 Tom Tromey <tom@tromey.com>
8937
8938 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8939 Use make_scope_exit.
8940
d01c5877
TT
89412019-03-06 Tom Tromey <tom@tromey.com>
8942
8943 * solib-svr4.c (disable_probes_interface): Remove parameter.
8944 (svr4_handle_solib_event): Use make_scope_exit.
8945
32603266
TT
89462019-03-06 Tom Tromey <tom@tromey.com>
8947
8948 * remote.c (struct stop_reply_deleter): Remove.
8949 (stop_reply_up): Update.
8950 (struct stop_reply): Derive from notif_event. Don't typedef.
8951 <regcache>: Now a std::vector.
8952 (stop_reply_xfree): Remove.
8953 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8954 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8955 (remote_target::discard_pending_stop_replies): Use delete.
8956 (remote_target::remote_parse_stop_reply): Update.
8957 (remote_target::process_stop_reply): Update.
8958 * remote-notif.h (struct notif_event): Add virtual destructor.
8959 Remove "dtr" member.
8960 (struct notif_client) <alloc_event>: Return a unique_ptr.
8961 (notif_event_xfree): Don't declare.
8962 (notif_event_up): New typedef.
8963 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8964 (notif_event_xfree, do_notif_event_xfree): Remove.
8965 (remote_notif_state_xfree): Update.
8966
9799571e
TT
89672019-03-06 Tom Tromey <tom@tromey.com>
8968
8969 * infrun.c (displaced_step_clear_cleanup): Now a
8970 forward_scope_exit type.
8971 (displaced_step_prepare_throw): Update.
8972 (displaced_step_fixup): Update.
8973
09e3c4ca
TT
89742019-03-06 Tom Tromey <tom@tromey.com>
8975
8976 * inferior.h (class inferior): Update comment.
8977 * gdbthread.h (class thread_info): Update comment.
8978
e2a03548
TT
89792019-03-06 Joel Brobecker <brobecker@adacore.com>
8980 Tom Tromey <tom@tromey.com>
8981
8982 * stabsread.h (struct stab_section_list): Remove.
8983 (coffstab_build_psymtabs): Update.
8984 * dbxread.c (symbuf_sections): Now a std::vector.
8985 (sect_idx): New global.
8986 (fill_symbuf): Update.
8987 (coffstab_build_psymtabs): Change type of stabsects parameter.
8988 Update.
8989 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8990 std::vector.
8991 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8992 (coff_locate_sections): Update.
8993 (coff_symfile_read): Remove cleanups. Update.
8994 (init_stringtab): Add storage parameter.
8995 (free_stringtab, free_stringtab_cleanup): Remove.
8996 (init_lineno): Add storage parameter.
8997 (free_linetab, free_linetab_cleanup): Remove.
8998
b7e60d85
PA
89992019-03-06 Pedro Alves <palves@redhat.com>
9000
9001 * linux-fork.c (fork_info::clobber_regs): Delete.
9002 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9003 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9004 comment. Adjust.
9005 (scoped_switch_fork_info::scoped_switch_fork_info)
9006 (checkpoint_command, linux_fork_context): Adjust
9007 fork_save_infrun_state calls.
9008
e52c971f
PA
90092019-03-06 Pedro Alves <palves@redhat.com>
9010
9011 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9012 (inf_has_multiple_threads): Return 'bool' and rewrite using
9013 inferior_info::threads().
9014
06974e6c
PA
90152019-03-06 Pedro Alves <palves@redhat.com>
9016
9017 * linux-fork.c: Include <list>.
9018 (fork_list): Now a std::list instance.
9019 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9020 (forks_exist_p, find_last_fork): Adjust.
9021 (new_fork): Delete.
9022 (one_fork_p): New.
9023 (add_fork): Adjust.
9024 (free_fork): Delete, folded into fork_info::~fork_info().
9025 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9026 Adjust.
9027 (init_fork_list): Delete.
9028 (linux_fork_killall, linux_fork_mourn_inferior)
9029 (linux_fork_detach, info_checkpoints_command): Adjust.
9030 (_initialize_linux_fork): No longer call init_fork_list.
9031
72f31aea
PA
90322019-03-06 Pedro Alves <palves@redhat.com>
9033
9034 * linux-fork.c (new_fork): New, split out of ...
9035 (add_fork): ... this. Return void. Move "first fork" special
9036 case from here, to ...
9037 (checkpoint_command): ... here.
9038 * linux-linux.h (add_fork): Return void.
9039
efbecbc1
AB
90402019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9041
9042 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9043
0841c79a
AB
90442019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9045 Chris January <chris.january@arm.com>
9046 David Lecomber <david.lecomber@arm.com>
9047
9048 * f-exp.y: New token, UNOP_INTRINSIC.
9049 (exp): New pattern using UNOP_INTRINSIC token.
9050 (f77_keywords): Add 'abs' keyword.
9051 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9052 (value_from_host_double): New function.
9053 (evaluate_subexp_f): Support UNOP_ABS.
9054
4a270568
AB
90552019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9056
9057 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9058 types.
9059
067630bd
AB
90602019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9061
9062 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9063 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9064 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9065
3be47f7a
AB
90662019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9067
9068 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9069
4d00f5d8
AB
90702019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9071 Chris January <chris.january@arm.com>
9072
9073 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9074 * f-exp.y: Define 'KIND' token.
9075 (exp): New pattern for KIND expressions.
9076 (ptype): Handle types with a kind extension.
9077 (direct_abs_decl): Extend to spot kind extensions.
9078 (f77_keywords): Add 'kind' to the list.
9079 (push_kind_type): New function.
9080 (convert_to_kind_type): New function.
9081 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9082 * parse.c (operator_length_standard): Likewise.
9083 * parser-defs.h (enum type_pieces): Add tp_kind.
9084 * std-operator.def: Add UNOP_KIND.
9085
e454224f
AB
90862019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9087
9088 * f-exp.y (f_parse): Set yydebug.
9089
9dad4a58
AB
90902019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9091
9092 * f-lang.c (evaluate_subexp_f): New function.
9093 (exp_descriptor_f): New global.
9094 (f_language_defn): Use exp_descriptor_f instead of
9095 exp_descriptor_standard.
9096
c8f91604
AB
90972019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9098
9099 * f-exp.y (struct token): Add comments.
9100 (dot_ops): Remove uppercase versions and the end marker.
9101 (f77_keywords): Likewise.
9102 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9103 entries in the dot_ops array are case insensitive, and use
9104 strncasecmp to compare strings. Also some whitespace cleanup in
9105 this area. Similar for the f77_keywords array, except entries in
9106 this list might be case sensitive.
9107
dd9f2c76
AB
91082019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9109
9110 * f-exp.y (struct f77_boolean_val): Add comments.
9111 (boolean_values): Remove uppercase versions, and end marker.
9112 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9113 and use strncasecmp to achieve case insensitivity. Additionally,
9114 perform whitespace cleanup around this code.
9115
67a3048c
TT
91162019-03-06 Tom Tromey <tromey@adacore.com>
9117
9118 * remote-sim.c (gdbsim_target_open): Use result of
9119 gdb_argv::release.
9120
aa3cfbda
RB
91212019-03-06 Richard Bunt <richard.bunt@arm.com>
9122 Dirk Schubert <dirk.schubert@arm.com>
9123 Chris January <chris.january@arm.com>
9124
9125 * eval.c (evaluate_subexp_standard): Call Fortran argument
9126 wrapping logic.
9127 * f-lang.c (struct value): A value which can be passed into a
9128 Fortran function call.
9129 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9130 where appropriate.
9131 (struct type): Value ready for a Fortran function call.
9132 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9133 is needed.
9134 * f-lang.h (fortran_argument_convert): Declaration.
9135 (fortran_preserve_arg_pointer): Declaration.
9136 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9137
ea38e5df
TT
91382019-03-05 Tom Tromey <tromey@adacore.com>
9139
9140 * python/py-prettyprint.c (print_string_repr): Remove #if.
9141 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9142
06b5b831
TT
91432019-03-05 Tom Tromey <tromey@adacore.com>
9144
9145 * target.c (the_dummy_target): Move later. Change type to
9146 "dummy_target".
9147 (initialize_targets): Don't initialize the_dummy_target.
9148
edbd9e45
TT
91492019-03-05 Tom Tromey <tromey@adacore.com>
9150
9151 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9152 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9153
c119e040
TT
91542019-03-05 Tom Tromey <tromey@adacore.com>
9155
9156 * windows-nat.c (windows_nat_target::attach)
9157 (windows_nat_target::detach): Don't call gdb_flush.
9158 * valprint.c (generic_val_print, val_print, val_print_string):
9159 Don't call gdb_flush.
9160 * utils.c (defaulted_query): Don't call gdb_flush.
9161 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9162 * target.c (target_announce_detach): Don't call gdb_flush.
9163 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9164 * remote.c (extended_remote_target::attach): Don't call
9165 gdb_flush.
9166 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9167 * printcmd.c (do_examine): Don't call gdb_flush.
9168 (info_display_command): Don't call gdb_flush.
9169 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9170 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9171 * memattr.c (info_mem_command): Don't call gdb_flush.
9172 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9173 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9174 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9175 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9176 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9177 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9178 (gnu_nat_target::detach): Don't call gdb_flush.
9179 * f-valprint.c (f_val_print): Don't call gdb_flush.
9180 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9181 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9182 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9183 gdb_flush.
9184 * c-valprint.c (c_val_print): Don't call gdb_flush.
9185 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9186
895dafa6
TT
91872019-03-05 Tom Tromey <tromey@adacore.com>
9188
9189 * varobj.c (update_dynamic_varobj_children): Update.
9190 (install_default_visualizer): Use reset, not release.
9191 * value.c (set_internalvar): Update.
9192 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9193 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9194 ATTRIBUTE_UNUSED_RESULT.
9195
88a774b9
TT
91962019-03-05 Tom Tromey <tromey@adacore.com>
9197
9198 * remote.c (class scoped_remote_fd) <release>: Add
9199 ATTRIBUTE_UNUSED_RESULT.
9200
4e4a8b93
TT
92012019-03-05 Tom Tromey <tromey@adacore.com>
9202
9203 * macroexp.c (struct macro_buffer) <release>: Add
9204 ATTRIBUTE_UNUSED_RESULT.
9205
083eef1f
TT
92062019-03-05 Tom Tromey <tromey@adacore.com>
9207
9208 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9209 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9210 ATTRIBUTE_UNUSED_RESULT.
9211
3cabd438
TT
92122019-03-05 Tom Tromey <tromey@adacore.com>
9213
9214 * common/scoped_fd.h (class scoped_fd) <release>: Add
9215 ATTRIBUTE_UNUSED_RESULT.
9216
41e3300a
TT
92172019-03-05 Tom Tromey <tromey@adacore.com>
9218
9219 * parser-defs.h (struct parser_state) <release>: Add
9220 ATTRIBUTE_UNUSED_RESULT.
9221
18cb7c9f
TT
92222019-03-05 Tom Tromey <tromey@adacore.com>
9223
9224 * utils.h (class gdb_argv) <release>: Add
9225 ATTRIBUTE_UNUSED_RESULT.
9226 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9227
41fa577f
EZ
92282019-03-02 Eli Zaretskii <eliz@gnu.org>
9229
a6a4b2c6
EZ
9230 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9231 for-loop range, to avoid compiler warnings.
9232
9233 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9234 avoid compiler warnings about unused variables.
9235
742a7df5
EZ
9236 * NEWS: Mention end of support for native debugging on MS-Windows
9237 before XP.
9238
41fa577f
EZ
9239 PR gdb/24292
9240 * common/netstuff.c:
9241 * gdbserver/gdbreplay.c
9242 * gdbserver/remote-utils.c:
9243 * ser-tcp.c:
9244 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9245 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9246 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9247 'getaddrinfo' and 'freeaddrinfo' were not available before
9248 Windows XP, and mingw.org's MinGW headers by default define
9249 _WIN32_WINNT to 0x500.
9250
827f438f
GB
92512019-03-01 Gary Benson <gbenson@redhat.com>
9252
9253 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9254
92137da0
RO
92552019-02-28 Brian Vandenberg <phantall@gmail.com>
9256 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9257
9258 PR gdb/8527
9259 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9260 set_sigint_trap, clear_sigint_trap.
9261
799efbe8
PW
92622019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9263
9264 * target.c (target_detach): Clear the regcache and the
9265 frame cache.
9266
8ed25214
PA
92672019-02-27 Pedro Alves <palves@redhat.com>
9268
9269 * utils.c (set_screen_size): When we cap the height/width sizes,
9270 tweak the corresponding command variable to show "unlimited":
9271
23031e31
SJ
92722019-02-27 Saagar Jha <saagar@saagarjha.com>
9273 Pedro Alves <palves@redhat.com>
9274
9275 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9276 before calling rl_set_screen_size.
9277
6c28e44a
TT
92782019-02-27 Tom Tromey <tromey@adacore.com>
9279
9280 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9281 define.
9282 * python/py-value.c: Remove Python 2.4 workaround.
9283 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9284 workaround.
9285 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9286 Python 2.4 workaround.
9287 * python/python-internal.h: Remove Python 2.4 comment.
9288 (Py_ssize_t): Don't define.
9289 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9290 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9291 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9292 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9293 * python/python.c (do_start_initialization): Remove Python 2.4
9294 workaround.
9295 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9296 (print_children): Remove Python 2.4 workaround.
9297 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9298 workaround.
9299 (CHARBUFFERPROC_NAME): Remove.
9300 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9301 Python 2.4 workaround.
9302
2c3fc25d 93032019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 9304
2c3fc25d
KB
9305 * NEWS: Note minimum Python version.
9306
6ca62222
KB
93072019-02-27 Kevin Buettner <kevinb@redhat.com>
9308
9309 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9310 code from these functions. Remove corresponding ifdefs. Use
9311 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9312 Remove gotos and target of gotos.
9313 (infpy_search_memory): Likewise.
9314
f4bc7d2c
AB
93152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9316
9317 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9318 (hppa_gdbarch_init): Don't register deleted functions with
9319 gdbarch.
9320
9734a586
AB
93212019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9322
9323 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9324 (h8300_unwind_sp): Delete.
9325 (h8300_dummy_id): Delete.
9326 (h8300_gdbarch_init): Don't register deleted functions with
9327 gdbarch.
9328
68b867f3
AB
93292019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9330
9331 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9332 (ft32_unwind_pc): Delete.
9333 (ft32_unwind_sp): Delete.
9334 (ft32_gdbarch_init): Don't register deleted functions with
9335 gdbarch.
9336
2fbe7ad0
AB
93372019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9338
9339 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9340 (frv_unwind_pc): Delete.
9341 (frv_unwind_sp): Delete.
9342 (frv_gdbarch_init): Don't register deleted functions with
9343 gdbarch.
9344
76055cbe
AB
93452019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9346
9347 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9348 (riscv_unwind_pc): Delete.
9349 (riscv_unwind_sp): Delete.
9350 (riscv_gdbarch_init): Don't register deleted functions with
9351 gdbarch.
9352
4133e5a1
AB
93532019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9354
9355 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9356 (csky_unwind_pc): Delete.
9357 (csky_unwind_sp): Delete.
9358 (csky_gdbarch_init): Don't register deleted functions with
9359 gdbarch.
9360
8010f576
AB
93612019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9362
9363 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9364 (cris_unwind_pc): Delete.
9365 (cris_unwind_sp): Delete.
9366 (cris_gdbarch_init): Don't register deleted functions with
9367 gdbarch.
9368
b56bf084
AB
93692019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9370
9371 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9372 (bfin_unwind_pc): Delete.
9373 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9374
a19a650f
AB
93752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9376
9377 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9378 (arm_unwind_pc): Delete.
9379 (arm_unwind_sp): Delete.
9380 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9381
f8278c3c
AB
93822019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9383
9384 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9385 (arc_unwind_pc): Delete.
9386 (arc_unwind_sp): Delete.
9387 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9388
480e46cf
AB
93892019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9390
9391 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9392 (alpha_unwind_pc): Delete.
9393 (alpha_gdbarch_init): Don't register deleted functions with
9394 gdbarch.
9395
7a995095
AB
93962019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9397
9398 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9399 (aarch64_unwind_pc): Delete.
9400 (aarch64_unwind_sp): Delete.
9401 (aarch64_gdbarch_init): Don't register deleted functions with
9402 gdbarch.
9403
bf9a735e
AB
94042019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9405
9406 * gdbtypes.c (type_align): Don't consider static members when
9407 computing structure alignment.
9408
5561fc30
AB
94092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9410
9411 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9412 return 0 for other types.
9413 * arch-utils.c (default_type_align): Always return 0.
9414 * gdbarch.h: Regenerate.
9415 * gdbarch.sh (type_align): Extend comment.
9416 * gdbtypes.c (type_align): Add additional comments, always call
9417 gdbarch_type_align before applying the default rules.
9418 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9419 generic code will then apply a suitable default.
9420 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9421 types, return 0 for other types.
9422
9335e75a
JB
94232019-02-27 Joel Brobecker <brobecker@adacore.com>
9424
9425 * NEWS: Create a new section for the next release branch.
9426 Rename the section of the current branch, now that it has
9427 been cut.
9428
3d34d8de
JB
94292019-02-27 Joel Brobecker <brobecker@adacore.com>
9430
9431 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9432 * version.in: Bump version to 8.3.50.DATE-git.
9433
143420fb
SM
94342019-02-26 Simon Marchi <simon.marchi@efficios.com>
9435
9436 * aix-thread.c (ptid_cmp): Remove unused variable.
9437 (get_signaled_thread): Likewise.
9438 (store_regs_user_thread): Likewise.
9439 (store_regs_kernel_thread): Likewise.
9440 (fetch_regs_kernel_thread): Remove shadowed variable.
9441
172fb711
AB
94422019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9443
9444 * features/riscv/32bit-cpu.xml: Add register numbers.
9445 * features/riscv/32bit-fpu.c: Regenerate.
9446 * features/riscv/32bit-fpu.xml: Add register numbers.
9447 * features/riscv/64bit-cpu.xml: Add register numbers.
9448 * features/riscv/64bit-fpu.c: Regenerate.
9449 * features/riscv/64bit-fpu.xml: Add register numbers.
9450
26c89782
KB
94512019-02-26 Kevin Buettner <kevinb@redhat.com>
9452
af54ade9 9453 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
9454 * python/py-value.c (convert_buffer_and_type_to_value): New
9455 function.
9456 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9457 Add support for handling an optional second argument. Call
9458 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
9459 * python/python-internal.h (Py_buffer_deleter): New struct.
9460 (Py_buffer_up): New typedef.
9461
0f58c9e8
JB
94622019-02-25 John Baldwin <jhb@FreeBSD.org>
9463
9464 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9465 instead of releasing ownership.
9466
0a0f4c01
JR
94672019-02-25 Jordan Rupprecht <rupprecht@google.com>
9468
9469 * dwarf2read.c (open_and_init_dwp_file): Call
9470 elf_numsections instead of bfd_count_sections to initialize
9471 dwp_file->num_sections.
9472
cd5a152c
TT
94732019-02-25 Tom Tromey <tromey@adacore.com>
9474
9475 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9476
8a6a8513
SDJ
94772019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9478
9479 * gcore.in: Add '--readnever' option when invoking GDB.
9480
04dcda9c
SM
94812019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9482
9483 * MAINTAINERS: Update my email address.
9484
07bc701d
SM
94852019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9486
9487 * build-id.c (build_id_to_debug_bfd_1): New function.
9488 (build_id_to_debug_bfd): Look for separate debug file in
9489 sysroot.
9490
c6f4a5d0
AB
94912019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9492
9493 * gdbarch.sh: Update the copyright year range that is placed into
9494 generated files.
9495
9600246d
KS
94962019-02-22 Keith Seitz <keiths@redhat.com>
9497
9498 PR symtab/23853
9499 * linespec.c (create_sals_line_offset): Search for the default
9500 symtab's filename instead of its fullname.
9501
7557a514
AH
95022019-02-21 Alan Hayward <alan.hayward@arm.com>
9503
9504 * NEWS: Update style defaults.
9505
ee2bcb0c
AH
95062019-02-21 Alan Hayward <alan.hayward@arm.com>
9507
9508 * main.c (captured_main_1): Disable styling in batch mode.
9509
0c95f9ed
TT
95102019-02-20 Tom Tromey <tom@tromey.com>
9511
9512 * symtab.c (symtab_symbol_info): Fix typos.
9513
c763b894
TT
95142019-02-20 Tom Tromey <tromey@adacore.com>
9515
9516 * findcmd.c (_initialize_mem_search): Use upper case for
9517 metasyntactic variables.
9518
0ef8a082
AH
95192019-02-20 Alan Hayward <alan.hayward@arm.com>
9520
9521 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9522 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9523
6caa91b6
SM
95242019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9525
9526 * top.h (source_file_name): Change to std::string.
9527 * top.c (source_file_name): Likewise.
9528 (command_line_input): Adjust.
9529 * cli/cli-script.c (script_from_file): Adjust.
9530
98814c6c
TT
95312019-02-19 Tom Tromey <tromey@adacore.com>
9532
9533 * ravenscar-thread.c
9534 (ravenscar_thread_target::update_thread_list): Don't call
9535 ada_build_task_list.
9536 * ada-lang.h (ada_build_task_list): Don't declare.
9537 * ada-tasks.c (struct ada_tasks_inferior_data)
9538 <task_list_valid_p>: Now bool.
9539 (read_known_tasks, ada_task_list_changed)
9540 (ada_tasks_invalidate_inferior_data): Update.
9541 (read_known_tasks_array): Return bool.
9542 (read_known_tasks_list): Likewise.
9543 (read_known_tasks): Return void.
9544 (ada_build_task_list): Now static.
9545
70cd633e
AB
95462019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9547
9548 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9549 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9550
040b3e95
PW
95512019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9552
9553 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9554 variant for ada_tasks_pspace_data_handle and
9555 ada_tasks_inferior_data_handle.
9556 (ada_tasks_pspace_data_cleanup): New function.
9557 (ada_tasks_inferior_data_cleanup): New function.
9558
9409233b
TT
95592019-02-17 Tom Tromey <tom@tromey.com>
9560
9561 * macrotab.h (macro_source_fullname): Return a std::string.
9562 * macrotab.c (macro_include, check_for_redefinition)
9563 (macro_undef, macro_lookup_definition, foreach_macro)
9564 (foreach_macro_in_scope): Update.
9565 (macro_source_fullname): Return a std::string.
9566 * macrocmd.c (show_pp_source_pos): Update.
9567
6506371f
TT
95682019-02-17 Tom Tromey <tom@tromey.com>
9569
9570 * macrocmd.c (show_pp_source_pos): Style the file names.
9571
0c820d67
TT
95722019-02-17 Tom Tromey <tom@tromey.com>
9573
9574 PR tui/24197:
9575 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9576
a0087920
TT
95772019-02-17 Tom Tromey <tom@tromey.com>
9578
9579 * ada-lang.c (user_select_syms): Use filtered printing.
9580 * utils.c (wrap_style): New global.
9581 (desired_style): Remove.
9582 (emit_style_escape): Add stream parameter.
9583 (set_output_style, reset_terminal_style, prompt_for_continue):
9584 Update.
9585 (flush_wrap_buffer): Only flush gdb_stdout.
9586 (wrap_here): Set wrap_style.
9587 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9588 treat escape sequences as a character. Change when wrap buffer is
9589 flushed.
9590 (fputs_styled): Do not set the output style when the default is
9591 requested.
9592 * ui-style.h (struct ui_file_style) <is_default>: New method.
9593 * source.c (print_source_lines_base): Emit escape sequences in one
9594 piece.
9595
75ba10dc
JB
95962019-02-17 Joel Brobecker <brobecker@adacore.com>
9597
9598 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9599 integers and enumeration types.
9600
a2cd4f14
JB
96012019-02-17 Joel Brobecker <brobecker@adacore.com>
9602
9603 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9604 instead of lookup_symbol_in_language
9605 (do_exact_match): New function.
9606 (ada_get_symbol_name_matcher): Return do_exact_match when
9607 doing a verbatim match.
9608
485b851b
TT
96092019-02-15 Tom Tromey <tromey@adacore.com>
9610
9611 * ravenscar-thread.c (ravenscar_thread_target::resume)
9612 (ravenscar_thread_target::wait): Special case wildcard requests.
9613
0b790b1e
TT
96142019-02-15 Tom Tromey <tromey@adacore.com>
9615
9616 * ravenscar-thread.c (base_ptid): Remove.
9617 (struct ravenscar_thread_target) <close>: New method.
9618 <m_base_ptid>: New member.
9619 <update_inferior_ptid, active_task, task_is_currently_active,
9620 runtime_initialized>: Declare methods.
9621 <ravenscar_thread_target>: Add constructor.
9622 (ravenscar_thread_target::task_is_currently_active)
9623 (ravenscar_thread_target::update_inferior_ptid)
9624 (ravenscar_runtime_initialized): Rename. Now methods.
9625 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9626 (ravenscar_thread_target::update_thread_list): Update.
9627 (ravenscar_thread_target::active_task): Now method.
9628 (ravenscar_thread_target::store_registers)
9629 (ravenscar_thread_target::prepare_to_store)
9630 (ravenscar_thread_target::prepare_to_store)
9631 (ravenscar_thread_target::mourn_inferior): Update.
9632 (ravenscar_inferior_created): Use "new" to create target.
9633 (ravenscar_thread_target::get_ada_task_ptid): Update.
9634 (_initialize_ravenscar): Don't initialize base_ptid.
9635 (ravenscar_ops): Remove global.
9636
dea57a62
TT
96372019-02-15 Tom Tromey <tromey@adacore.com>
9638
9639 * target.h (push_target): Declare new overload.
9640 * target.c (push_target): New overload, taking an rvalue reference.
9641 * remote.c (remote_target::open_1): Use push_target overload.
9642 * corelow.c (core_target_open): Use push_target overload.
9643
989f3c58
TT
96442019-02-15 Tom Tromey <tromey@adacore.com>
9645
9646 * ravenscar-thread.c (is_ravenscar_task)
9647 (ravenscar_task_is_currently_active): Return bool.
9648 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9649 (_initialize_ravenscar): Remove "(void)".
9650 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9651 Return bool.
9652
6cbcc006
TT
96532019-02-15 Tom Tromey <tromey@adacore.com>
9654
9655 * ravenscar-thread.c (ravenscar_runtime_initializer)
9656 (has_ravenscar_runtime, get_running_thread_id)
9657 (ravenscar_thread_target::resume): Fix indentation.
9658
7657f14d
TT
96592019-02-15 Tom Tromey <tromey@adacore.com>
9660
9661 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9662 from ravenscar_arch_ops.
9663 (sparc_ravenscar_ops::fetch_registers)
9664 (sparc_ravenscar_ops::store_registers): Now methods.
9665 (sparc_ravenscar_prepare_to_store): Remove.
9666 (sparc_ravenscar_ops): Redefine.
9667 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9668 methods and destructor. Remove members.
9669 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9670 (ravenscar_thread_target::store_registers)
9671 (ravenscar_thread_target::prepare_to_store): Update.
9672 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9673 Remove.
9674 (struct ppc_ravenscar_powerpc_ops): Derive from
9675 ravenscar_arch_ops.
9676 (ppc_ravenscar_powerpc_ops::fetch_registers)
9677 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9678 (ppc_ravenscar_powerpc_ops): Redefine.
9679 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9680 (ppc_ravenscar_e500_ops::fetch_registers)
9681 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9682 (ppc_ravenscar_e500_ops): Redefine.
9683 * aarch64-ravenscar-thread.c
9684 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9685 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9686 (aarch64_ravenscar_fetch_registers)
9687 (aarch64_ravenscar_store_registers): Now methods.
9688 (aarch64_ravenscar_ops): Redefine.
9689
5b6ea500
TT
96902019-02-15 Tom Tromey <tromey@adacore.com>
9691
9692 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9693 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9694 (ravenscar_thread_target::stopped_by_watchpoint)
9695 (ravenscar_thread_target::stopped_data_address)
9696 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9697
e397fd39
TT
96982019-02-15 Tom Tromey <tromey@adacore.com>
9699
9700 * ravenscar-thread.c: Fix some typos.
9701
cc12f4a8
TT
97022019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9703 Tom Tromey <tromey@adacore.com>
9704
9705 * ada-lang.c (ada_exception_sal): Change addr_string to a
9706 std::string.
9707 (create_ada_exception_catchpoint): Update.
9708
5f486660
TT
97092019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9710 Tom Tromey <tromey@adacore.com>
9711
9712 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9713 (bp_location_ops): Remove.
9714 (base_breakpoint_allocate_location): Update.
9715 (free_bp_location): Update.
9716 * ada-lang.c (class ada_catchpoint_location)
9717 <ada_catchpoint_location>: Remove ops parameter.
9718 (ada_catchpoint_location_dtor): Remove.
9719 (ada_catchpoint_location_ops): Remove.
9720 (allocate_location_exception): Update.
9721 * breakpoint.h (struct bp_location_ops): Remove.
9722 (class bp_location) <bp_location>: Remove bp_location_ops
9723 parameter.
9724 <~bp_location>: Add destructor.
9725 <ops>: Remove.
9726
b671c7fb
TS
97272019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9728 Pedro Alves <palves@redhat.com>
9729
9730 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9731 'PATH_MAX'.
9732
8071c5ce
DM
97332019-02-14 David Michael <fedora.dm0@gmail.com>
9734 Samuel Thibault <samuel.thibault@gnu.org>
9735 Thomas Schwinge <thomas@codesourcery.com>
9736
9737 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9738 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9739
b1041ae0
TS
97402019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9741
924514e1
TS
9742 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9743 (check_empty): Use "const char *".
9744
c29ee8d4
TS
9745 * gnu-nat.c (gnu_nat_target::detach): Instead of
9746 'detach_inferior (pid)' call
9747 'detach_inferior (find_inferior_pid (pid))'.
9748
6c6ef69f
TS
9749 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9750 'nat/fork-inferior.o'.
9751 * gnu-nat.c: #include "nat/fork-inferior.h".
9752
2d0a338c
TS
9753 * gnu-nat.c (gnu_nat_target::detach): Instead of
9754 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9755 * gnu-nat.h: #include "inf-child.h".
9756 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9757 'i386_gnu_nat_target::fetch_registers'.
9758 (gnu_store_registers): Rename/move to
9759 'i386_gnu_nat_target::store_registers'.
9760
cabb5f06
TS
9761 * config/i386/nm-i386gnu.h: Don't "#include" any files.
9762 * gnu-nat.h (mach_thread_info): New function.
9763 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9764
b1041ae0
TS
9765 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9766
2988d01e
KF
97672019-02-14 Frederic Konrad <konrad@adacore.com>
9768
9769 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9770
c559d709
JB
97712019-02-14 Joel Brobecker <brobecker@adacore.com>
9772
9773 * windows-nat.c (windows_add_thread): Add new parameter
9774 "main_thread_p" with default value set to false. Update
9775 function documentation as well as all callers.
9776 (windows_delete_thread): Likewise.
9777 (fake_create_process): Update call to windows_add_thread.
9778 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9779 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9780 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9781 call to windows_delete_thread.
9782
007024cc
SM
97832019-02-13 Simon Marchi <simon.marchi@ericsson.com>
9784
9785 * MAINTAINERS: Add Andrew Burgess as global maintainer.
9786
f62318e9
JB
97872019-02-12 John Baldwin <jhb@FreeBSD.org>
9788
9789 * symfile.c (find_separate_debug_file): Use canonical path of
9790 sysroot with child_path instead of gdb_sysroot if it is valid.
9791
cd4b7848
JB
97922019-02-12 John Baldwin <jhb@FreeBSD.org>
9793
9794 * symfile.c (find_separate_debug_file): Use child_path to
9795 determine if an object file is under a sysroot.
9796
efac4bfe
JB
97972019-02-12 John Baldwin <jhb@FreeBSD.org>
9798
9799 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9800 unittests/child-path-selftests.c.
9801 * common/pathstuff.c (child_path): New function.
9802 * common/pathstuff.h (child_path): New prototype.
9803 * unittests/child-path-selftests.c: New file.
9804
402d2bfe
JB
98052019-02-12 John Baldwin <jhb@FreeBSD.org>
9806
9807 * symfile.c (find_separate_debug_file): Look for separate debug
9808 files in debug directories under the sysroot.
9809
1ed9f74e
PW
98102019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9811
9812 * symtab.h (struct minimal_symbol data_p): New const method.
9813 (struct minimal_symbol text_p): Likewise.
9814 * symtab.c (output_source_filename): Use file name style
9815 to print file name.
9816 (print_symbol_info): Likewise.
9817 (print_msymbol_info): Use address style to print addresses.
9818 Use function name style to print executable text symbols.
9819 (expand_symtab_containing_pc): Use data_p.
9820 (find_pc_sect_compunit_symtab): Likewise.
9821
2636d81d
PW
98222019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9823
9824 * breakpoint.c (describe_other_breakpoints): Use address style
9825 to print addresses.
9826 (say_where): Likewise.
9827
ac8c53cc
PW
98282019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9829
9830 * ada-typeprint.c (print_func_type): Print function name
9831 style to print function name.
9832 * c-typeprint.c (c_print_type_1): Likewise.
9833
ea638c43
AH
98342019-02-11 Alan Hayward <alan.hayward@arm.com>
9835
9836 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9837 for execve.
9838
ab759ca8
PW
98392019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9840
9841 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9842 type_stack.
9843
aff29d1c
JB
98442019-02-10 Joel Brobecker <brobecker@adacore.com>
9845
9846 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9847 TYPE_CODE_REF types.
9848
617126bc
JW
98492019-02-08 Jim Wilson <jimw@sifive.com>
9850
9851 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9852 (riscv_linux_fregset): New.
9853 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9854
46e3ed7f
TT
98552019-02-07 Tom Tromey <tom@tromey.com>
9856
9857 * thread.c (thread_cancel_execution_command): Update.
9858 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9859 methods.
9860 (struct thread_fsm_ops): Remove.
9861 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9862 (thread_fsm_should_stop, thread_fsm_return_value)
9863 (thread_fsm_set_finished, thread_fsm_finished_p)
9864 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9865 Don't declare.
9866 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9867 * infrun.c (clear_proceed_status_thread)
9868 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9869 (print_stop_event): Update.
9870 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9871 Add constructor.
9872 (step_command_fsm_ops): Remove.
9873 (new_step_command_fsm): Remove.
9874 (step_1): Update.
9875 (step_command_fsm::should_stop): Rename from
9876 step_command_fsm_should_stop.
9877 (step_command_fsm::clean_up): Rename from
9878 step_command_fsm_clean_up.
9879 (step_command_fsm::do_async_reply_reason): Rename from
9880 step_command_fsm_async_reply_reason.
9881 (struct until_next_fsm): Inherit from thread_fsm. Add
9882 constructor.
9883 (until_next_fsm_ops): Remove.
9884 (new_until_next_fsm): Remove.
9885 (until_next_fsm::should_stop): Rename from
9886 until_next_fsm_should_stop.
9887 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9888 (until_next_fsm::do_async_reply_reason): Rename from
9889 until_next_fsm_async_reply_reason.
9890 (struct finish_command_fsm): Inherit from thread_fsm. Add
9891 constructor. Change type of breakpoint.
9892 (finish_command_fsm_ops): Remove.
9893 (new_finish_command_fsm): Remove.
9894 (finish_command_fsm::should_stop): Rename from
9895 finish_command_fsm_should_stop.
9896 (finish_command_fsm::clean_up): Rename from
9897 finish_command_fsm_clean_up.
9898 (finish_command_fsm::return_value): Rename from
9899 finish_command_fsm_return_value.
9900 (finish_command_fsm::do_async_reply_reason): Rename from
9901 finish_command_fsm_async_reply_reason.
9902 (finish_command): Update.
9903 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9904 Add constructor.
9905 (call_thread_fsm_ops): Remove.
9906 (call_thread_fsm::call_thread_fsm): Rename from
9907 new_call_thread_fsm.
9908 (call_thread_fsm::should_stop): Rename from
9909 call_thread_fsm_should_stop.
9910 (call_thread_fsm::should_notify_stop): Rename from
9911 call_thread_fsm_should_notify_stop.
9912 (run_inferior_call, call_function_by_hand_dummy): Update.
9913 * cli/cli-interp.c (should_print_stop_to_console): Update.
9914 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9915 Add constructor. Change type of location_breakpoint,
9916 caller_breakpoint.
9917 (until_break_fsm_ops): Remove.
9918 (new_until_break_fsm): Remove.
9919 (until_break_fsm::should_stop): Rename from
9920 until_break_fsm_should_stop.
9921 (until_break_fsm::clean_up): Rename from
9922 until_break_fsm_clean_up.
9923 (until_break_fsm::do_async_reply_reason): Rename from
9924 until_break_fsm_async_reply_reason.
9925 (until_break_command): Update.
9926 * thread-fsm.c: Remove.
9927 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9928
1a5c2598
TT
99292019-02-07 Tom Tromey <tom@tromey.com>
9930
9931 * yy-remap.h: Add include guard.
9932 * xtensa-tdep.h: Add include guard.
9933 * xcoffread.h: Rename include guard.
9934 * varobj-iter.h: Add include guard.
9935 * tui/tui.h: Rename include guard.
9936 * tui/tui-winsource.h: Rename include guard.
9937 * tui/tui-wingeneral.h: Rename include guard.
9938 * tui/tui-windata.h: Rename include guard.
9939 * tui/tui-win.h: Rename include guard.
9940 * tui/tui-stack.h: Rename include guard.
9941 * tui/tui-source.h: Rename include guard.
9942 * tui/tui-regs.h: Rename include guard.
9943 * tui/tui-out.h: Rename include guard.
9944 * tui/tui-layout.h: Rename include guard.
9945 * tui/tui-io.h: Rename include guard.
9946 * tui/tui-hooks.h: Rename include guard.
9947 * tui/tui-file.h: Rename include guard.
9948 * tui/tui-disasm.h: Rename include guard.
9949 * tui/tui-data.h: Rename include guard.
9950 * tui/tui-command.h: Rename include guard.
9951 * tic6x-tdep.h: Add include guard.
9952 * target/waitstatus.h: Rename include guard.
9953 * target/wait.h: Rename include guard.
9954 * target/target.h: Rename include guard.
9955 * target/resume.h: Rename include guard.
9956 * target-float.h: Rename include guard.
9957 * stabsread.h: Add include guard.
9958 * rs6000-tdep.h: Add include guard.
9959 * riscv-fbsd-tdep.h: Add include guard.
9960 * regformats/regdef.h: Rename include guard.
9961 * record.h: Rename include guard.
9962 * python/python.h: Rename include guard.
9963 * python/python-internal.h: Rename include guard.
9964 * python/py-stopevent.h: Rename include guard.
9965 * python/py-ref.h: Rename include guard.
9966 * python/py-record.h: Rename include guard.
9967 * python/py-record-full.h: Rename include guard.
9968 * python/py-record-btrace.h: Rename include guard.
9969 * python/py-instruction.h: Rename include guard.
9970 * python/py-events.h: Rename include guard.
9971 * python/py-event.h: Rename include guard.
9972 * procfs.h: Add include guard.
9973 * proc-utils.h: Add include guard.
9974 * p-lang.h: Add include guard.
9975 * or1k-tdep.h: Rename include guard.
9976 * observable.h: Rename include guard.
9977 * nto-tdep.h: Rename include guard.
9978 * nat/x86-linux.h: Rename include guard.
9979 * nat/x86-linux-dregs.h: Rename include guard.
9980 * nat/x86-gcc-cpuid.h: Add include guard.
9981 * nat/x86-dregs.h: Rename include guard.
9982 * nat/x86-cpuid.h: Rename include guard.
9983 * nat/ppc-linux.h: Rename include guard.
9984 * nat/mips-linux-watch.h: Rename include guard.
9985 * nat/linux-waitpid.h: Rename include guard.
9986 * nat/linux-ptrace.h: Rename include guard.
9987 * nat/linux-procfs.h: Rename include guard.
9988 * nat/linux-osdata.h: Rename include guard.
9989 * nat/linux-nat.h: Rename include guard.
9990 * nat/linux-namespaces.h: Rename include guard.
9991 * nat/linux-btrace.h: Rename include guard.
9992 * nat/glibc_thread_db.h: Rename include guard.
9993 * nat/gdb_thread_db.h: Rename include guard.
9994 * nat/gdb_ptrace.h: Rename include guard.
9995 * nat/fork-inferior.h: Rename include guard.
9996 * nat/amd64-linux-siginfo.h: Rename include guard.
9997 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9998 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9999 * nat/aarch64-linux.h: Rename include guard.
10000 * nat/aarch64-linux-hw-point.h: Rename include guard.
10001 * mn10300-tdep.h: Add include guard.
10002 * mips-linux-tdep.h: Add include guard.
10003 * mi/mi-parse.h: Rename include guard.
10004 * mi/mi-out.h: Rename include guard.
10005 * mi/mi-main.h: Rename include guard.
10006 * mi/mi-interp.h: Rename include guard.
10007 * mi/mi-getopt.h: Rename include guard.
10008 * mi/mi-console.h: Rename include guard.
10009 * mi/mi-common.h: Rename include guard.
10010 * mi/mi-cmds.h: Rename include guard.
10011 * mi/mi-cmd-break.h: Rename include guard.
10012 * m2-lang.h: Add include guard.
10013 * location.h: Rename include guard.
10014 * linux-record.h: Rename include guard.
10015 * linux-nat.h: Add include guard.
10016 * linux-fork.h: Add include guard.
10017 * i386-darwin-tdep.h: Rename include guard.
10018 * hppa-linux-offsets.h: Add include guard.
10019 * guile/guile.h: Rename include guard.
10020 * guile/guile-internal.h: Rename include guard.
10021 * gnu-nat.h: Rename include guard.
10022 * gdb-stabs.h: Rename include guard.
10023 * frv-tdep.h: Add include guard.
10024 * f-lang.h: Add include guard.
10025 * event-loop.h: Add include guard.
10026 * darwin-nat.h: Rename include guard.
10027 * cp-abi.h: Rename include guard.
10028 * config/sparc/nm-sol2.h: Rename include guard.
10029 * config/nm-nto.h: Rename include guard.
10030 * config/nm-linux.h: Add include guard.
10031 * config/i386/nm-i386gnu.h: Rename include guard.
10032 * config/djgpp/nl_types.h: Rename include guard.
10033 * config/djgpp/langinfo.h: Rename include guard.
10034 * compile/gcc-cp-plugin.h: Add include guard.
10035 * compile/gcc-c-plugin.h: Add include guard.
10036 * compile/compile.h: Rename include guard.
10037 * compile/compile-object-run.h: Rename include guard.
10038 * compile/compile-object-load.h: Rename include guard.
10039 * compile/compile-internal.h: Rename include guard.
10040 * compile/compile-cplus.h: Rename include guard.
10041 * compile/compile-c.h: Rename include guard.
10042 * common/xml-utils.h: Rename include guard.
10043 * common/x86-xstate.h: Rename include guard.
10044 * common/version.h: Rename include guard.
10045 * common/vec.h: Rename include guard.
10046 * common/tdesc.h: Rename include guard.
10047 * common/selftest.h: Rename include guard.
10048 * common/scoped_restore.h: Rename include guard.
10049 * common/scoped_mmap.h: Rename include guard.
10050 * common/scoped_fd.h: Rename include guard.
10051 * common/safe-iterator.h: Rename include guard.
10052 * common/run-time-clock.h: Rename include guard.
10053 * common/refcounted-object.h: Rename include guard.
10054 * common/queue.h: Rename include guard.
10055 * common/ptid.h: Rename include guard.
10056 * common/print-utils.h: Rename include guard.
10057 * common/preprocessor.h: Rename include guard.
10058 * common/pathstuff.h: Rename include guard.
10059 * common/observable.h: Rename include guard.
10060 * common/netstuff.h: Rename include guard.
10061 * common/job-control.h: Rename include guard.
10062 * common/host-defs.h: Rename include guard.
10063 * common/gdb_wait.h: Rename include guard.
10064 * common/gdb_vecs.h: Rename include guard.
10065 * common/gdb_unlinker.h: Rename include guard.
10066 * common/gdb_unique_ptr.h: Rename include guard.
10067 * common/gdb_tilde_expand.h: Rename include guard.
10068 * common/gdb_sys_time.h: Rename include guard.
10069 * common/gdb_string_view.h: Rename include guard.
10070 * common/gdb_splay_tree.h: Rename include guard.
10071 * common/gdb_setjmp.h: Rename include guard.
10072 * common/gdb_ref_ptr.h: Rename include guard.
10073 * common/gdb_optional.h: Rename include guard.
10074 * common/gdb_locale.h: Rename include guard.
10075 * common/gdb_assert.h: Rename include guard.
10076 * common/filtered-iterator.h: Rename include guard.
10077 * common/filestuff.h: Rename include guard.
10078 * common/fileio.h: Rename include guard.
10079 * common/environ.h: Rename include guard.
10080 * common/common-utils.h: Rename include guard.
10081 * common/common-types.h: Rename include guard.
10082 * common/common-regcache.h: Rename include guard.
10083 * common/common-inferior.h: Rename include guard.
10084 * common/common-gdbthread.h: Rename include guard.
10085 * common/common-exceptions.h: Rename include guard.
10086 * common/common-defs.h: Rename include guard.
10087 * common/common-debug.h: Rename include guard.
10088 * common/cleanups.h: Rename include guard.
10089 * common/buffer.h: Rename include guard.
10090 * common/btrace-common.h: Rename include guard.
10091 * common/break-common.h: Rename include guard.
10092 * cli/cli-utils.h: Rename include guard.
10093 * cli/cli-style.h: Rename include guard.
10094 * cli/cli-setshow.h: Rename include guard.
10095 * cli/cli-script.h: Rename include guard.
10096 * cli/cli-interp.h: Rename include guard.
10097 * cli/cli-decode.h: Rename include guard.
10098 * cli/cli-cmds.h: Rename include guard.
10099 * charset-list.h: Add include guard.
10100 * buildsym-legacy.h: Rename include guard.
10101 * bfin-tdep.h: Add include guard.
10102 * ax.h: Rename include guard.
10103 * arm-linux-tdep.h: Add include guard.
10104 * arm-fbsd-tdep.h: Add include guard.
10105 * arch/xtensa.h: Rename include guard.
10106 * arch/tic6x.h: Add include guard.
10107 * arch/i386.h: Add include guard.
10108 * arch/arm.h: Rename include guard.
10109 * arch/arm-linux.h: Rename include guard.
10110 * arch/arm-get-next-pcs.h: Rename include guard.
10111 * arch/amd64.h: Add include guard.
10112 * arch/aarch64-insn.h: Rename include guard.
10113 * arch-utils.h: Rename include guard.
10114 * annotate.h: Add include guard.
10115 * amd64-darwin-tdep.h: Rename include guard.
10116 * aarch64-linux-tdep.h: Add include guard.
10117 * aarch64-fbsd-tdep.h: Add include guard.
10118 * aarch32-linux-nat.h: Add include guard.
10119
ab9268d2
PW
101202019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10121
10122 * macrotab.c (macro_define_internal): New function that
10123 factorizes macro_define_object_internal and macro_define_function
10124 code.
10125 (macro_define_object_internal): Use macro_define_internal.
10126 (macro_define_function): Likewise.
10127
bb0da2b4
PW
101282019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10129
10130 * macrocmd.c (extract_identifier): Return
10131 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10132 callers.
10133
424eb552
JB
101342019-02-06 John Baldwin <jhb@FreeBSD.org>
10135
10136 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10137
1688cb29
TT
101382019-02-05 Tom Tromey <tom@tromey.com>
10139
10140 * target.c (target_stack::unpush): Move assertion earlier.
10141
b5eba2d8
TT
101422019-01-30 Tom Tromey <tom@tromey.com>
10143
10144 PR python/23615:
10145 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10146 (gdbpy_parse_and_eval): Likewise.
10147 * python/python-internal.h (gdbpy_allow_threads): New class.
10148
7054e2ff
JB
101492019-01-28 John Baldwin <jhb@FreeBSD.org>
10150
10151 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10152 (aarch64_fbsd_fpregmap): Move earlier.
10153 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10154 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10155 instead of individual calls to trad_frame_set_reg_addr.
10156 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10157 earlier.
10158 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10159 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10160 instead of individual calls to trad_frame_set_reg_addr.
10161
36c25ffa
AH
101622019-01-28 Alan Hayward <alan.hayward@arm.com>
10163
10164 * CONTRIBUTE: Replace contribution list with wiki link.
10165
a0707f3c
TT
101662019-01-25 Tom Tromey <tom@tromey.com>
10167
10168 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10169
0747795c
TT
101702019-01-25 Tom Tromey <tom@tromey.com>
10171
10172 * xtensa-linux-nat.c: Fix common/ includes.
10173 * xml-support.h: Fix common/ includes.
10174 * xml-support.c: Fix common/ includes.
10175 * x86-linux-nat.c: Fix common/ includes.
10176 * windows-nat.c: Fix common/ includes.
10177 * varobj.h: Fix common/ includes.
10178 * varobj.c: Fix common/ includes.
10179 * value.c: Fix common/ includes.
10180 * valops.c: Fix common/ includes.
10181 * utils.c: Fix common/ includes.
10182 * unittests/xml-utils-selftests.c: Fix common/ includes.
10183 * unittests/utils-selftests.c: Fix common/ includes.
10184 * unittests/unpack-selftests.c: Fix common/ includes.
10185 * unittests/tracepoint-selftests.c: Fix common/ includes.
10186 * unittests/style-selftests.c: Fix common/ includes.
10187 * unittests/string_view-selftests.c: Fix common/ includes.
10188 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10189 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10190 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10191 * unittests/rsp-low-selftests.c: Fix common/ includes.
10192 * unittests/parse-connection-spec-selftests.c: Fix common/
10193 includes.
10194 * unittests/optional-selftests.c: Fix common/ includes.
10195 * unittests/offset-type-selftests.c: Fix common/ includes.
10196 * unittests/observable-selftests.c: Fix common/ includes.
10197 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10198 * unittests/memrange-selftests.c: Fix common/ includes.
10199 * unittests/memory-map-selftests.c: Fix common/ includes.
10200 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10201 * unittests/function-view-selftests.c: Fix common/ includes.
10202 * unittests/environ-selftests.c: Fix common/ includes.
10203 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10204 * unittests/common-utils-selftests.c: Fix common/ includes.
10205 * unittests/cli-utils-selftests.c: Fix common/ includes.
10206 * unittests/array-view-selftests.c: Fix common/ includes.
10207 * ui-file.c: Fix common/ includes.
10208 * tui/tui-io.c: Fix common/ includes.
10209 * tracepoint.h: Fix common/ includes.
10210 * tracepoint.c: Fix common/ includes.
10211 * tracefile-tfile.c: Fix common/ includes.
10212 * top.h: Fix common/ includes.
10213 * top.c: Fix common/ includes.
10214 * thread.c: Fix common/ includes.
10215 * target/waitstatus.h: Fix common/ includes.
10216 * target/waitstatus.c: Fix common/ includes.
10217 * target.h: Fix common/ includes.
10218 * target.c: Fix common/ includes.
10219 * target-memory.c: Fix common/ includes.
10220 * target-descriptions.c: Fix common/ includes.
10221 * symtab.h: Fix common/ includes.
10222 * symfile.c: Fix common/ includes.
10223 * stap-probe.c: Fix common/ includes.
10224 * spu-linux-nat.c: Fix common/ includes.
10225 * sparc-nat.c: Fix common/ includes.
10226 * source.c: Fix common/ includes.
10227 * solib.c: Fix common/ includes.
10228 * solib-target.c: Fix common/ includes.
10229 * ser-unix.c: Fix common/ includes.
10230 * ser-tcp.c: Fix common/ includes.
10231 * ser-pipe.c: Fix common/ includes.
10232 * ser-base.c: Fix common/ includes.
10233 * selftest-arch.c: Fix common/ includes.
10234 * s12z-tdep.c: Fix common/ includes.
10235 * rust-exp.y: Fix common/ includes.
10236 * rs6000-aix-tdep.c: Fix common/ includes.
10237 * riscv-tdep.c: Fix common/ includes.
10238 * remote.c: Fix common/ includes.
10239 * remote-notif.h: Fix common/ includes.
10240 * remote-fileio.h: Fix common/ includes.
10241 * remote-fileio.c: Fix common/ includes.
10242 * regcache.h: Fix common/ includes.
10243 * regcache.c: Fix common/ includes.
10244 * record-btrace.c: Fix common/ includes.
10245 * python/python.c: Fix common/ includes.
10246 * python/py-type.c: Fix common/ includes.
10247 * python/py-inferior.c: Fix common/ includes.
10248 * progspace.h: Fix common/ includes.
10249 * producer.c: Fix common/ includes.
10250 * procfs.c: Fix common/ includes.
10251 * proc-api.c: Fix common/ includes.
10252 * printcmd.c: Fix common/ includes.
10253 * ppc-linux-nat.c: Fix common/ includes.
10254 * parser-defs.h: Fix common/ includes.
10255 * osdata.c: Fix common/ includes.
10256 * obsd-nat.c: Fix common/ includes.
10257 * nat/x86-linux.c: Fix common/ includes.
10258 * nat/x86-linux-dregs.c: Fix common/ includes.
10259 * nat/x86-dregs.h: Fix common/ includes.
10260 * nat/x86-dregs.c: Fix common/ includes.
10261 * nat/ppc-linux.c: Fix common/ includes.
10262 * nat/mips-linux-watch.h: Fix common/ includes.
10263 * nat/mips-linux-watch.c: Fix common/ includes.
10264 * nat/linux-waitpid.c: Fix common/ includes.
10265 * nat/linux-ptrace.h: Fix common/ includes.
10266 * nat/linux-ptrace.c: Fix common/ includes.
10267 * nat/linux-procfs.c: Fix common/ includes.
10268 * nat/linux-personality.c: Fix common/ includes.
10269 * nat/linux-osdata.c: Fix common/ includes.
10270 * nat/linux-namespaces.c: Fix common/ includes.
10271 * nat/linux-btrace.h: Fix common/ includes.
10272 * nat/linux-btrace.c: Fix common/ includes.
10273 * nat/fork-inferior.c: Fix common/ includes.
10274 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10275 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10276 * nat/aarch64-linux.c: Fix common/ includes.
10277 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10278 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10279 * namespace.h: Fix common/ includes.
10280 * mips-linux-tdep.c: Fix common/ includes.
10281 * minsyms.c: Fix common/ includes.
10282 * mi/mi-parse.h: Fix common/ includes.
10283 * mi/mi-main.c: Fix common/ includes.
10284 * mi/mi-cmd-env.c: Fix common/ includes.
10285 * memrange.h: Fix common/ includes.
10286 * memattr.c: Fix common/ includes.
10287 * maint.h: Fix common/ includes.
10288 * maint.c: Fix common/ includes.
10289 * main.c: Fix common/ includes.
10290 * machoread.c: Fix common/ includes.
10291 * location.c: Fix common/ includes.
10292 * linux-thread-db.c: Fix common/ includes.
10293 * linux-nat.c: Fix common/ includes.
10294 * linux-fork.c: Fix common/ includes.
10295 * inline-frame.c: Fix common/ includes.
10296 * infrun.c: Fix common/ includes.
10297 * inflow.c: Fix common/ includes.
10298 * inferior.h: Fix common/ includes.
10299 * inferior.c: Fix common/ includes.
10300 * infcmd.c: Fix common/ includes.
10301 * inf-ptrace.c: Fix common/ includes.
10302 * inf-child.c: Fix common/ includes.
10303 * ia64-linux-nat.c: Fix common/ includes.
10304 * i387-tdep.c: Fix common/ includes.
10305 * i386-tdep.c: Fix common/ includes.
10306 * i386-linux-tdep.c: Fix common/ includes.
10307 * i386-linux-nat.c: Fix common/ includes.
10308 * i386-go32-tdep.c: Fix common/ includes.
10309 * i386-fbsd-tdep.c: Fix common/ includes.
10310 * i386-fbsd-nat.c: Fix common/ includes.
10311 * guile/scm-type.c: Fix common/ includes.
10312 * guile/guile.c: Fix common/ includes.
10313 * go32-nat.c: Fix common/ includes.
10314 * gnu-nat.c: Fix common/ includes.
10315 * gdbthread.h: Fix common/ includes.
10316 * gdbarch-selftests.c: Fix common/ includes.
10317 * gdb_usleep.c: Fix common/ includes.
10318 * gdb_select.h: Fix common/ includes.
10319 * gdb_bfd.c: Fix common/ includes.
10320 * gcore.c: Fix common/ includes.
10321 * fork-child.c: Fix common/ includes.
10322 * findvar.c: Fix common/ includes.
10323 * fbsd-nat.c: Fix common/ includes.
10324 * event-top.c: Fix common/ includes.
10325 * event-loop.c: Fix common/ includes.
10326 * dwarf2read.c: Fix common/ includes.
10327 * dwarf2loc.c: Fix common/ includes.
10328 * dwarf2-frame.c: Fix common/ includes.
10329 * dwarf-index-cache.c: Fix common/ includes.
10330 * dtrace-probe.c: Fix common/ includes.
10331 * disasm-selftests.c: Fix common/ includes.
10332 * defs.h: Fix common/ includes.
10333 * csky-tdep.c: Fix common/ includes.
10334 * cp-valprint.c: Fix common/ includes.
10335 * cp-support.h: Fix common/ includes.
10336 * cp-support.c: Fix common/ includes.
10337 * corelow.c: Fix common/ includes.
10338 * completer.h: Fix common/ includes.
10339 * completer.c: Fix common/ includes.
10340 * compile/compile.c: Fix common/ includes.
10341 * compile/compile-loc2c.c: Fix common/ includes.
10342 * compile/compile-cplus-types.c: Fix common/ includes.
10343 * compile/compile-cplus-symbols.c: Fix common/ includes.
10344 * command.h: Fix common/ includes.
10345 * cli/cli-dump.c: Fix common/ includes.
10346 * cli/cli-cmds.c: Fix common/ includes.
10347 * charset.c: Fix common/ includes.
10348 * build-id.c: Fix common/ includes.
10349 * btrace.h: Fix common/ includes.
10350 * btrace.c: Fix common/ includes.
10351 * breakpoint.h: Fix common/ includes.
10352 * breakpoint.c: Fix common/ includes.
10353 * ax.h:
10354 (enum agent_op): Fix common/ includes.
10355 * ax-general.c (struct aop_map): Fix common/ includes.
10356 * ax-gdb.c: Fix common/ includes.
10357 * auxv.c: Fix common/ includes.
10358 * auto-load.c: Fix common/ includes.
10359 * arm-tdep.c: Fix common/ includes.
10360 * arch/riscv.c: Fix common/ includes.
10361 * arch/ppc-linux-common.c: Fix common/ includes.
10362 * arch/i386.c: Fix common/ includes.
10363 * arch/arm.c: Fix common/ includes.
10364 * arch/arm-linux.c: Fix common/ includes.
10365 * arch/arm-get-next-pcs.c: Fix common/ includes.
10366 * arch/amd64.c: Fix common/ includes.
10367 * arch/aarch64.c: Fix common/ includes.
10368 * arch/aarch64-insn.c: Fix common/ includes.
10369 * arch-utils.c: Fix common/ includes.
10370 * amd64-windows-tdep.c: Fix common/ includes.
10371 * amd64-tdep.c: Fix common/ includes.
10372 * amd64-sol2-tdep.c: Fix common/ includes.
10373 * amd64-obsd-tdep.c: Fix common/ includes.
10374 * amd64-nbsd-tdep.c: Fix common/ includes.
10375 * amd64-linux-tdep.c: Fix common/ includes.
10376 * amd64-linux-nat.c: Fix common/ includes.
10377 * amd64-fbsd-tdep.c: Fix common/ includes.
10378 * amd64-fbsd-nat.c: Fix common/ includes.
10379 * amd64-dicos-tdep.c: Fix common/ includes.
10380 * amd64-darwin-tdep.c: Fix common/ includes.
10381 * agent.c: Fix common/ includes.
10382 * ada-lang.h: Fix common/ includes.
10383 * ada-lang.c: Fix common/ includes.
10384 * aarch64-tdep.c: Fix common/ includes.
10385
2f5c153e
TT
103862019-01-25 Tom Tromey <tom@tromey.com>
10387
10388 * common/create-version.sh: Use common/version.h.
10389
adc6a863
PA
103902019-01-24 Pedro Alves <palves@redhat.com>
10391
10392 * infrun.c (signal_stop, signal_print, signal_program)
10393 (signal_catch, signal_pass): Now arrays instead of pointers.
10394 (update_signals_program_target, do_target_resume)
10395 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10396 * linux-nat.c (linux_nat_target::pass_signals)
10397 (linux_nat_target::create_inferior, linux_nat_target::attach):
10398 Adjust.
10399 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10400 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10401 * procfs.c (procfs_target::pass_signals): Adjust.
10402 * record-full.c (record_full_target::resume): Adjust.
10403 * remote.c (remote_target::pass_signals)
10404 (remote_target::program_signals): Adjust.
10405 * target-debug.h (target_debug_print_signals): Now takes a
10406 gdb::array_view as parameter. Adjust.
10407 * target.h (target_ops) <pass_signals, program_signals>: Replace
10408 pointer and length parameters with gdb::array_view.
10409 (target_pass_signals, target_program_signals): Likewise.
10410 * target-delegates.c: Regenerate.
10411
3046d67a
PA
104122019-01-24 Pedro Alves <palves@redhat.com>
10413
10414 * common/forward-scope-exit.h
10415 (forward_scope_exit::forward_scope_exit): Pass arguments to
10416 m_bind_function directly, instead of creating a std::bind and
10417 copying that.
10418
353229bf
AH
104192019-01-24 Alan Hayward <alan.hayward@arm.com>
10420
10421 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10422 for static members.
10423 (pass_in_v_vfp_candidate): Likewise.
10424
311dc83a
TT
104252019-01-23 Tom Tromey <tom@tromey.com>
10426 Pedro Alves <palves@redhat.com>
10427
10428 * regcache.c (class regcache_invalidator): Remove.
10429 (regcache::raw_write): Use make_scope_exit.
10430
296bd123
TT
104312019-01-23 Tom Tromey <tom@tromey.com>
10432
10433 * ui-out.h (class ui_out_emit_type): Update comment.
10434
979a0d13
TT
104352019-01-23 Tom Tromey <tom@tromey.com>
10436
10437 * infrun.c (fetch_inferior_event): Update comment.
10438
d238133d
TT
104392019-01-23 Tom Tromey <tom@tromey.com>
10440 Pedro Alves <palves@redhat.com>
10441
10442 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10443 parameter.
10444 (fetch_inferior_event): Use SCOPE_EXIT.
10445
10446
9885e6bb
TT
104472019-01-23 Tom Tromey <tom@tromey.com>
10448 Pedro Alves <palves@redhat.com>
10449
10450 * infrun.c (disable_thread_events): Delete.
10451 (stop_all_threads): Use SCOPE_EXIT.
10452
286526c1
TT
104532019-01-23 Tom Tromey <tom@tromey.com>
10454 Pedro Alves <palves@redhat.com>
10455
10456 * symfile.c: Include forward-scope-exit.h.
10457 (clear_symtab_users_cleanup): Replace forward declaration with
10458 a FORWARD_SCOPE_EXIT.
10459 (syms_from_objfile_1): Use the forward_scope_exit and
10460 gdb::optional instead of cleanup_function.
10461 (reread_symbols): Use the forward_scope_exit instead of
10462 cleanup_function.
10463 (clear_symtab_users_cleanup): Remove function.
10464
1db93f14
TT
104652019-01-23 Tom Tromey <tom@tromey.com>
10466 Pedro Alves <palves@redhat.com>
10467
10468 * linux-nat.c: Include scope-exit.h.
10469 (cleanup_target_stop): Remove.
10470 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10471 SCOPE_EXIT.
10472
2cc83d1e
TT
104732019-01-23 Tom Tromey <tom@tromey.com>
10474 Pedro Alves <palves@redhat.com>
10475
10476 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10477 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10478
694c6bf5
TT
104792019-01-23 Tom Tromey <tom@tromey.com>
10480 Andrew Burgess <andrew.burgess@embecosm.com>
10481 Pedro Alves <palves@redhat.com>
10482
10483 * infrun.c (fetch_inferior_event): Use scope_exit.
10484 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10485 * top.c (execute_command): Use scope_exit.
10486 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10487 * utils.c (do_bpstat_clear_actions_cleanup)
10488 (make_bpstat_clear_actions_cleanup): Remove.
10489
4c41382a
TT
104902019-01-23 Tom Tromey <tom@tromey.com>
10491 Pedro Alves <palves@redhat.com>
10492
10493 * infrun.c: Include "common/scope-exit.h"
10494 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10495 (wait_for_inferior): Use SCOPE_EXIT.
10496 (fetch_inferior_event): Use scope_exit.
10497
89f8fb50
TT
104982019-01-23 Tom Tromey <tom@tromey.com>
10499 Pedro Alves <palves@redhat.com>
10500
10501 * breakpoint.c (create_breakpoint): Remove cleanup.
10502
5419bdae
TT
105032019-01-23 Tom Tromey <tom@tromey.com>
10504 Andrew Burgess <andrew.burgess@embecosm.com>
10505 Pedro Alves <palves@redhat.com>
10506
e587ef42
PA
105072019-01-23 Pedro Alves <palves@redhat.com>
10508
10509 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10510
77f0e74c
PA
105112019-01-23 Pedro Alves <palves@redhat.com>
10512 Andrew Burgess <andrew.burgess@embecosm.com>
10513
10514 * gdbthread.h: Include "common/forward-scope-exit.h".
10515 (scoped_finish_thread_state): Redefine custom class in terms of
10516 forward_scope_exit.
10517
5b9b3e53
PA
105182019-01-23 Pedro Alves <palves@redhat.com>
10519 Andrew Burgess <andrew.burgess@embecosm.com>
10520
10521 * common/forward-scope-exit.h: New file.
10522
54b65c9b
PA
105232019-01-23 Pedro Alves <palves@redhat.com>
10524 Andrew Burgess <andrew.burgess@embecosm.com>
10525 Tom Tromey <tom@tromey.com>
10526
10527 * common/scope-exit.h: New file.
10528
cf08fb29
PA
105292019-01-23 Pedro Alves <palves@redhat.com>
10530
10531 * common/preprocessor.h (ESC): Rename to ...
10532 (ESC_PARENS): ... this.
10533 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10534 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10535
ae73e2e2
TT
105362019-01-23 Tom Tromey <tom@tromey.com>
10537
10538 * language.h (class scoped_switch_to_sym_language_if_auto):
10539 Initialize m_lang in both cases.
10540
6594e122
AH
105412019-01-23 Alan Hayward <alan.hayward@arm.com>
10542
10543 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10544 with XCNEW.
10545
a7c9855d
TT
105462019-01-22 Tom Tromey <tom@tromey.com>
10547
10548 * corelow.c: Do not include sys/file.h.
10549
93cc1d53
TT
105502019-01-22 Tom Tromey <tom@tromey.com>
10551
10552 * tui/tui-wingeneral.h: Include gdb_curses.h.
10553
38561778
TT
105542019-01-22 Tom Tromey <tom@tromey.com>
10555
10556 * source-cache.h (class source_cache) <get_source_lines,
10557 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10558
37b3ab5b
TT
105592019-01-22 Tom Tromey <tom@tromey.com>
10560
10561 * remote-fileio.h (struct remote_target): Declare.
10562
3fabc016
TT
105632019-01-22 Tom Tromey <tom@tromey.com>
10564
10565 * python/py-arch.c: Do not include py-ref.h.
10566 * python/py-bpevent.c: Do not include py-ref.h.
10567 * python/py-cmd.c: Do not include py-ref.h.
10568 * python/py-continueevent.c: Do not include py-ref.h.
10569 * python/py-event.h: Do not include py-ref.h.
10570 * python/py-evtregistry.c: Do not include py-ref.h.
10571 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10572 * python/py-frame.c: Do not include py-ref.h.
10573 * python/py-framefilter.c: Do not include py-ref.h.
10574 * python/py-function.c: Do not include py-ref.h.
10575 * python/py-infevents.c: Do not include py-ref.h.
10576 * python/py-linetable.c: Do not include py-ref.h.
10577 * python/py-objfile.c: Do not include py-ref.h.
10578 * python/py-param.c: Do not include py-ref.h.
10579 * python/py-prettyprint.c: Do not include py-ref.h.
10580 * python/py-progspace.c: Do not include py-ref.h.
10581 * python/py-symbol.c: Do not include py-ref.h.
10582 * python/py-symtab.c: Do not include py-ref.h.
10583 * python/py-type.c: Do not include py-ref.h.
10584 * python/py-unwind.c: Do not include py-ref.h.
10585 * python/py-utils.c: Do not include py-ref.h.
10586 * python/py-value.c: Do not include py-ref.h.
10587 * python/py-varobj.c: Do not include py-ref.h.
10588 * python/py-xmethods.c: Do not include py-ref.h.
10589 * python/python.c: Do not include py-ref.h.
10590 * varobj.c: Do not include py-ref.h.
10591
6b4d7774
TT
105922019-01-22 Tom Tromey <tom@tromey.com>
10593
10594 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10595 keyword for bcache.
10596
7af7e9b5
TT
105972019-01-22 Tom Tromey <tom@tromey.com>
10598
10599 * compile/compile-cplus-types.c: Remove a comment by #include.
10600
951d1049
TT
106012019-01-22 Tom Tromey <tom@tromey.com>
10602
10603 * compile/gcc-c-plugin.h: Include compile-internal.h.
10604
d65d5705
TT
106052019-01-22 Tom Tromey <tom@tromey.com>
10606
10607 * stabsread.c (EXTERN): Do not define.
10608 (symnum, next_symbol_text_func, processing_gcc_compilation)
10609 (within_function, global_sym_chain, global_stabs)
10610 (previous_stab_code, this_object_header_files)
10611 (n_this_object_header_files)
10612 (n_allocated_this_object_header_files): Define.
10613 * stabsread.h (EXTERN): Never define. Use "extern".
10614
b6fb1ee5
PW
106152019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10616
10617 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10618 history_value.
10619
be6d4f74
TT
106202019-01-21 Tom Tromey <tom@tromey.com>
10621
10622 * ui-out.c: Fix includes.
10623 * tui/tui-source.c: Fix includes.
10624 * target.c: Fix includes.
10625 * remote.c: Fix includes.
10626 * regcache.c: Fix includes.
10627 * python/py-block.c: Fix includes.
10628 * printcmd.c: Fix includes.
10629 * or1k-tdep.c: Fix includes.
10630 * mi/mi-main.c: Fix includes.
10631 * m32r-tdep.c: Fix includes.
10632 * csky-tdep.c: Fix includes.
10633 * compile/compile-cplus-types.c: Fix includes.
10634 * cli/cli-interp.c: Fix includes.
10635
73021deb
AH
106362019-01-21 Alan Hayward <alan.hayward@arm.com>
10637
10638 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10639 for padding.
10640
7932255d
TT
106412019-01-16 Tom Tromey <tom@tromey.com>
10642
10643 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10644 earlier.
10645 (struct objfile) <msymbols_range>: Move from top level.
10646 <msymbols>: New method.
10647 (class objfile_msymbols): Remove.
10648 * symtab.c (default_collect_symbol_completion_matches_break_on):
10649 Update.
10650 * symmisc.c (dump_msymbols): Update.
10651 * stabsread.c (scan_file_globals): Update.
10652 * objc-lang.c (info_selectors_command, info_classes_command)
10653 (find_methods): Update.
10654 * minsyms.c (find_solib_trampoline_target): Update.
10655 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10656 * coffread.c (coff_symfile_read): Update.
10657 * ada-lang.c (ada_lookup_simple_minsym)
10658 (ada_collect_symbol_completion_matches): Update.
10659
604b1bfb
TT
106602019-01-16 Tom Tromey <tom@tromey.com>
10661
10662 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10663 type. Remove no-argument constructor.
10664 <iterator::operator++>: Simplify.
10665 <begin>: Update.
10666 <end>: Use minimal_symbol_count.
10667
f252c6d5
TT
106682019-01-16 Tom Tromey <tom@tromey.com>
10669
10670 * objfiles.h (struct objfile) <psymtabs>: New method.
10671 (class objfile_psymtabs): Remove.
10672 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10673 typedef.
10674 <range>: New method.
10675 (require_partial_symbols): Change return type.
10676 * psymtab.c (require_partial_symbols)
10677 (psym_expand_symtabs_matching): Update.
10678 * mdebugread.c (parse_partial_symbols): Update.
10679 * dbxread.c (dbx_end_psymtab): Update.
10680
b669c953
TT
106812019-01-15 Tom Tromey <tom@tromey.com>
10682
10683 * symtab.c (lookup_objfile_from_block)
10684 (lookup_symbol_in_objfile_symtabs)
10685 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10686 (find_line_symtab, info_sources_command)
10687 (default_collect_symbol_completion_matches_break_on)
10688 (make_source_files_completion_list): Update.
10689 * symmisc.c (print_objfile_statistics, dump_objfile)
10690 (maintenance_print_symbols, maintenance_info_symtabs)
10691 (maintenance_check_symtabs, maintenance_info_line_tables):
10692 Update.
10693 * source.c (select_source_symtab)
10694 (forget_cached_source_info_for_objfile): Update.
10695 * objfiles.h (class objfile_compunits): Remove.
10696 (struct objfile) <compunits_range>: New typedef.
10697 (compunits): New method.
10698 * objfiles.c (objfile_relocate1): Update.
10699 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10700 * maint.c (count_symtabs_and_blocks): Update.
10701 * linespec.c (iterate_over_all_matching_symtabs): Update.
10702 * cp-support.c (add_symbol_overload_list_qualified): Update.
10703 * coffread.c (coff_symtab_read): Update.
10704 * ada-lang.c (add_nonlocal_symbols)
10705 (ada_collect_symbol_completion_matches)
10706 (ada_add_global_exceptions): Update.
10707
7e955d83
TT
107082019-01-15 Tom Tromey <tom@tromey.com>
10709
10710 * progspace.h (program_space) <objfiles_safe_range>: New
10711 typedef.
10712 <objfiles_safe>: New method.
10713 * objfiles.h (class all_objfiles_safe): Remove.
10714 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10715 * jit.c (jit_inferior_exit_hook): Update.
10716
2030c079
TT
107172019-01-17 Tom Tromey <tom@tromey.com>
10718
10719 * progspace.h (program_space) <objfiles_range>: New typedef.
10720 <objfiles>: New method.
10721 <objfiles_head>: Rename from objfiles.
10722 (object_files): Update.
10723 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10724 * guile/scm-pretty-print.c
10725 (ppscm_find_pretty_printer_from_objfiles): Update.
10726 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10727 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10728 Update.
10729 * python/py-progspace.c (pspy_get_objfiles): Update.
10730 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10731 Update.
10732 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10733 (objfpy_lookup_objfile_by_build_id): Update.
10734 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10735 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10736 Update.
10737 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10738 (expand_symtab_containing_pc, lookup_objfile_from_block)
10739 (lookup_static_symbol, basic_lookup_transparent_type)
10740 (find_pc_sect_compunit_symtab, find_symbol_at_address)
10741 (find_line_symtab, info_sources_command)
10742 (default_collect_symbol_completion_matches_break_on)
10743 (make_source_files_completion_list, find_main_name): Update.
10744 * symmisc.c (print_symbol_bcache_statistics)
10745 (print_objfile_statistics, maintenance_print_symbols)
10746 (maintenance_print_msymbols, maintenance_print_objfiles)
10747 (maintenance_info_symtabs, maintenance_check_symtabs)
10748 (maintenance_expand_symtabs, maintenance_info_line_tables):
10749 Update.
10750 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10751 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10752 (map_overlay_command, unmap_overlay_command)
10753 (simple_overlay_update, expand_symtabs_matching)
10754 (map_symbol_filenames): Update.
10755 * symfile-debug.c (set_debug_symfile): Update.
10756 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10757 Update.
10758 * source.c (select_source_symtab, forget_cached_source_info):
10759 Update.
10760 * solib.c (solib_read_symbols): Update.
10761 * solib-spu.c (append_ocl_sos): Update.
10762 * psymtab.c (maintenance_print_psymbols)
10763 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10764 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10765 * printcmd.c (info_symbol_command): Update.
10766 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10767 Update.
10768 * objfiles.h (class all_objfiles): Remove.
10769 * objfiles.c (have_partial_symbols, have_full_symbols)
10770 (have_minimal_symbols, qsort_cmp, update_section_map)
10771 (shared_objfile_contains_address_p)
10772 (default_iterate_over_objfiles_in_search_order): Update.
10773 * objc-lang.c (info_selectors_command, info_classes_command)
10774 (find_methods): Update.
10775 * minsyms.c (find_solib_trampoline_target): Update.
10776 * maint.c (maintenance_info_sections)
10777 (maintenance_translate_address, count_symtabs_and_blocks):
10778 Update.
10779 * main.c (captured_main_1): Update.
10780 * linux-thread-db.c (try_thread_db_load_from_pdir)
10781 (has_libpthread): Update.
10782 * linespec.c (iterate_over_all_matching_symtabs)
10783 (search_minsyms_for_name): Update.
10784 * jit.c (jit_find_objf_with_entry_addr): Update.
10785 * hppa-tdep.c (find_unwind_entry)
10786 (hppa_lookup_stub_minimal_symbol): Update.
10787 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10788 Update.
10789 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10790 (elf_gnu_ifunc_resolve_by_got): Update.
10791 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10792 * dwarf-index-write.c (save_gdb_index_command): Update.
10793 * cp-support.c (add_symbol_overload_list_qualified): Update.
10794 * breakpoint.c (create_overlay_event_breakpoint)
10795 (create_longjmp_master_breakpoint)
10796 (create_std_terminate_master_breakpoint)
10797 (create_exception_master_breakpoint): Update.
10798 * blockframe.c (find_pc_partial_function): Update.
10799 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10800 (ada_collect_symbol_completion_matches)
10801 (ada_add_global_exceptions): Update.
10802
776489e0
TT
108032019-01-17 Tom Tromey <tom@tromey.com>
10804
10805 * solib-target.c (lm_info_target_p): Remove typedef. Don't
10806 declare VEC.
10807 (solib_target_parse_libraries): Change return type.
10808 (library_list_start_segment, library_list_start_section)
10809 (library_list_end_library, library_list_start_library); Update.
10810 (solib_target_free_library_list): Remove.
10811 (solib_target_parse_libraries): Remove cleanup. Change return
10812 type.
10813 (solib_target_current_sos): Update.
10814
6471e7d2
TT
108152019-01-17 Tom Tromey <tromey@bapiya>
10816
10817 * valprint.c: Replace "the the" with "the".
10818 * symtab.c: Replace "the the" with "the".
10819 * solib.c: Replace "the the" with "the".
10820 * solib-dsbt.c: Replace "the the" with "the".
10821 * linespec.c: Replace "the the" with "the".
10822 * dwarf2loc.h: Replace "the the" with "the".
10823 * amd64-windows-tdep.c: Replace "the the" with "the".
10824 * aarch64-tdep.c: Replace "the the" with "the".
10825
c24bdb02
KS
108262019-01-16 Keith Seitz <keiths@redhat.com>
10827
10828 PR gdb/23773
10829 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10830 <builder>: Rename to ..
10831 <m_builder>: ... this and make private.
10832 (dwarf2_cu::get_builder): New method. Change all users of
10833 `builder' to use this method.
10834 (dwarf2_start_symtab): Move to ...
10835 (dwarf2_cu::start_symtab): ... here. Update all callers
10836 (setup_type_unit_groups): Move to ...
10837 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10838 callers.
10839 (dwarf2_cu::reset_builder): New method.
10840 (process_full_compunit, process_full_type_unit): Use
10841 dwarf2_cu::reset_builder.
10842 (follow_die_offset): Record the ancestor CU if it is different
10843 from the followed DIE's CU.
10844 (follow_die_sig_1): Likewise.
10845
8d64371b
TT
108462019-01-15 Tom Tromey <tom@tromey.com>
10847
10848 * remote.c (class remote_state) <buf>: Now a char_vector.
10849 <buf_size>: Remove.
10850 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10851 parameter.
10852 (remote_target::getpkt_or_notif_sane_1)
10853 (remote_target::getpkt_sane)
10854 (remote_target::getpkt_or_notif_sane): Likewise.
10855 (class remote_target) <putpkt>: New overload.
10856 (remote_target::read_frame): Change type of "buf_p". Remove
10857 sizeof_p parameter.
10858 (packet_ok): New overload.
10859 (packet_check_result): New overload.
10860 Update all uses.
10861
bb277751
TT
108622019-01-14 Tom Tromey <tom@tromey.com>
10863
10864 * remote-notif.c (handle_notification, remote_notif_ack)
10865 (remote_notif_parse): Make "buf" const.
10866 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10867 const.
10868 (remote_notif_parse, remote_notif_ack, handle_notification):
10869 Likewise.
10870 * remote.c (remote_notif_stop_parse): Make "buf" const.
10871 (remote_target::remote_parse_stop_reply): Make "buf" const.
10872 (remote_notif_stop_ack): Make "buf" const.
10873
05be00a8
TT
108742019-01-14 Tom Tromey <tom@tromey.com>
10875
10876 * remote.c (remote_console_output): Make parameter const.
10877
491adeca
TT
108782019-01-14 Tom Tromey <tom@tromey.com>
10879
10880 * target-debug.h (target_debug_print_signals): Constify.
10881 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10882 * procfs.c (procfs_target::pass_signals): Update.
10883 * linux-nat.c (linux_nat_target::pass_signals): Update.
10884 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10885 * target-delegates.c: Rebuild.
10886 * remote.c (remote_target::program_signals): Update.
10887 (remote_target::pass_signals): Update.
10888 * target.c (target_pass_signals): Constify argument.
10889 (target_program_signals): Likewise.
10890 * target.h (struct target_ops) <pass_signals, program_signals>:
10891 Constify argument.
10892 (target_pass_signals, target_program_signals): Constify argument.
10893
bbd94648
TT
108942019-01-14 Tom Tromey <tom@tromey.com>
10895
10896 PR tui/28819:
10897 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10898
6f072a10
PFC
108992019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10900
10901 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10902 field.
10903 * rs6000-tdep.c: Include reggroups.h.
10904 (IS_V_ALIAS_PSEUDOREG): Define.
10905 (rs6000_register_name): Return names for the "vX" aliases.
10906 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10907 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10908 aliases. Call default_register_reggroup_p for all other
10909 pseudo-registers.
10910 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10911 New functions.
10912 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10913 Handle "vX" aliases.
10914 (v_alias_pseudo_register_collect): New function.
10915 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10916 (rs6000_gdbarch_init): Initialize "vX" aliases as
10917 pseudo-registers. Restore registration of
10918 rs6000_pseudo_register_reggroup_p with
10919 set_tdesc_pseudo_register_reggroup_p.
10920
1a782351
MF
109212019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10922
10923 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10924 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10925 set_gdbarch_num_pseudo_regs.
10926
d73cff18
PW
109272019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10928
10929 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10930 Remove arg prefixname, add do_set and do_show.
10931 Add member functions set_list and show_list.
10932 * cli/cli-style.c (class cli_style_option): Update accordingly.
10933 (style_set_list): Move to file scope.
10934 (style_show_list): Likewise.
10935 (set_style): Call help_list.
10936 (show_style): Call cmd_show_list.
10937 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10938 Update to use the new macro.
10939
60a90376
JB
109402019-10-12 Joel Brobecker <brobecker@adacore.com>
10941
10942 * ada-lang.c (_initialize_ada_language): Expand the help text
10943 for the "catch exception" command.
10944
9d7c67bf
PW
109452019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10946
10947 * symtab.c (matching_obj_sections): Initialize obj,
10948 declare it closer to its usage.
10949
7cf47dc4
TT
109502019-01-10 Tom Tromey <tom@tromey.com>
10951
10952 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10953 (basic_inf_threads_range): Remove.
10954 (inf_threads_range, inf_non_exited_threads_range)
10955 (safe_inf_threads_range): Use next_adapter.
10956
d3cb6808
KS
109572019-01-10 Keith Seitz <keiths@redhat.com>
10958
10959 PR gdb/23712
10960 PR symtab/23010
10961 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10962 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10963
63a20375
KS
109642019-01-10 Keith Seitz <keiths@redhat.com>
10965
10966 PR gdb/23712
10967 PR symtab/23010
10968 * dictionary.c (pending_to_vector): Remove.
10969 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10970 Remove _1 suffix, replacing functions of the same name. Update
10971 all callers.
10972 (dict_create_hashed, dict_create_hashed_expandable)
10973 (dict_create_linear, dict_create_linear_expandable, dict_free)
10974 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10975 Make functions static.
10976
b026f593
KS
109772019-01-10 Keith Seitz <keiths@redhat.com>
10978
10979 PR gdb/23712
10980 PR symtab/23010
10981 * dictionary.h (struct dictionary): Replace declaration with
10982 multidictionary.
10983 (dict_create_hashed, dict_create_hashed_expandable)
10984 (dict_create_linear, dict_create_linear_expandable)
10985 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10986 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10987 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10988 taking multidictionary argument.
10989 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10990 * block.h (struct block) <dict>: Change to multidictionary
10991 and rename `multidict'.
10992 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10993 symmisc.c: Update all dictionary references to multidictionary.
10994
c7748ee9
KS
109952019-01-10 Keith Seitz <keiths@redhat.com>
10996
10997 PR gdb/23712
10998 PR symtab/23010
10999 * dictionary.c: Include unordered_map.
11000 (pending_to_vector): New function.
11001 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11002 Rewrite the non-"_1" functions to take vector instead
11003 of linked list.
11004 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11005 "new" _1 versions of the same name.
11006 (multidictionary): Define.
11007 (std::hash<enum language): New definition.
11008 (collate_pending_symbols_by_language, mdict_create_hashed)
11009 (mdict_create_hashed_expandable, mdict_create_linear)
11010 (mdict_create_linear_expandable, mdict_free)
11011 (find_language_dictionary, create_new_language_dictionary)
11012 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11013 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11014 (mdict_size, mdict_empty): New functions.
11015 * dictionary.h (mdict_iterator): Define.
11016
67aa1f3c
PA
110172019-01-10 Pedro Alves <palves@redhat.com>
11018
11019 * breakpoint.c (read_uploaded_action)
11020 (create_tracepoint_from_upload): Adjust to use
11021 gdb::unique_xmalloc_ptr.
11022 * ctf.c (ctf_write_uploaded_tp):
11023 (SET_ARRAY_FIELD): Use emplace_back.
11024 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11025 * tracefile-tfile.c (tfile_write_uploaded_tp):
11026 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11027 gdb::unique_xmalloc_ptr.
11028 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11029 at_string, cond_string, cmd_strings>: Replace char pointers
11030 with gdb::unique_xmalloc_ptr.
11031
2f667667
PA
110322019-01-10 Pedro Alves <palves@redhat.com>
11033
11034 * solib-target.c (library_list_start_library): Don't xstrdup name.
11035
36cb7237
PA
110362019-01-10 Pedro Alves <palves@redhat.com>
11037
11038 * mdebugread.c (parse_partial_symbols): Use
11039 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11040
da584958
AB
110412019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11042
11043 * linux-fork.c (scoped_switch_fork_info)
11044 <~scoped_switch_fork_info>: Fix incorrect variable name.
11045
1ef8573c
AB
110462019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11047
11048 * linux-fork.c (scoped_switch_fork_info)
11049 <scoped_switch_fork_info>: Make explicit.
11050 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11051
8d7bcccb
TT
110522019-01-10 Tom Tromey <tom@tromey.com>
11053
11054 * objfiles.h (objfile::reset_psymtabs): Update.
11055 * objfiles.c (objfile::objfile): Update.
11056 * psymtab.h (psymtab_storage::obstack): Update.
11057 (psymtab_storage::m_obstack): Use gdb::optional.
11058 (class psymtab_storage): Update comment. Remove objfile
11059 parameter.
11060 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11061
b596a3c7
TT
110622019-01-10 Tom Tromey <tom@tromey.com>
11063
11064 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11065 <free_psymtabs>: Now private.
11066 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11067 (allocate_psymtab): Use new method.
11068
a9342b62
TT
110692019-01-10 Tom Tromey <tom@tromey.com>
11070
11071 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11072 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11073 * mdebugread.c (parse_partial_symbols): Use
11074 allocate_dependencies.
11075 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11076 allocate_dependencies.
11077 (process_psymtab_comp_unit_reader)
11078 (build_type_psymtab_dependencies): Likewise.
11079 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11080
5af70966
TT
110812019-01-10 Tom Tromey <tom@tromey.com>
11082
11083 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11084 PSYMBOL_SET_LANGUAGE.
11085 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11086
5923a04c
TT
110872019-01-10 Tom Tromey <tom@tromey.com>
11088
11089 * psymtab.h (psymtab_storage::obstack): New method.
11090 <m_obstack>: Rename from obstack; now private.
11091 * psymtab.c (psymtab_storage): Update.
11092 * dwarf2read.c (create_addrmap_from_index)
11093 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11094 Update.
11095
6d6a12bf
TT
110962019-01-10 Tom Tromey <tom@tromey.com>
11097
11098 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11099 * objfiles.h (objfile::reset_psymtabs): New method.
11100
d320c2b5
TT
111012019-01-10 Tom Tromey <tom@tromey.com>
11102
11103 * symmisc.c (print_symbol_bcache_statistics): Update.
11104 (print_objfile_statistics): Update.
11105 * symfile.c (reread_symbols): Update.
11106 * psymtab.h (class psymtab_storage): New.
11107 * psymtab.c (psymtab_storage): New constructor.
11108 (~psymtab_storage): New destructor.
11109 (require_partial_symbols): Update.
11110 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11111 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11112 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11113 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11114 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11115 (start_psymtab_common, end_psymtab_common)
11116 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11117 (allocate_psymtab): Update.
11118 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11119 Update.
11120 (dump_psymtab_addrmap, maintenance_print_psymbols)
11121 (maintenance_check_psymtabs): Update.
11122 (class objfile_psymtabs): Move to objfiles.h.
11123 * psympriv.h (discard_psymtab): Now inline.
11124 (psymtab_discarder::psymtab_discarder): Update.
11125 (psymtab_discarder::~psymtab_discarder): Update.
11126 (ALL_OBJFILE_PSYMTABS): Rewrite.
11127 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11128 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11129 Remove fields.
11130 <partial_symtabs>: New field.
11131 (class objfile_psymtabs): Move from psymtab.h. Update.
11132 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11133 psymbol_cache.
11134 (objfile::~objfile): Don't destroy psymbol_cache.
11135 * mdebugread.c (parse_partial_symbols): Update.
11136 * dwarf2read.c (create_addrmap_from_index)
11137 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11138 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11139 (add_partial_subprogram, dwarf2_ranges_read): Update.
11140 * dwarf-index-write.c (write_address_map)
11141 (write_one_signatured_type, recursively_write_psymbols)
11142 (class debug_names, class debug_names, write_psymtabs_to_index):
11143 Update.
11144
1d94a5a3
TT
111452019-01-10 Tom Tromey <tom@tromey.com>
11146
11147 * symtab.h (SYMBOL_SET_NAMES): Update.
11148 (symbol_set_names): Update.
11149 (MSYMBOL_SET_NAMES): Update.
11150 * symtab.c (symbol_set_names): Change argument to be an
11151 objfile_per_bfd_storage.
11152 * psymtab.c (add_psymbol_to_bcache): Update.
11153 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11154
0f14768a
TT
111552019-01-10 Tom Tromey <tom@tromey.com>
11156
11157 * symtab.c (create_demangled_names_hash): Change argument to be an
11158 objfile_per_bfd_storage.
11159 (symbol_set_names): Update.
11160
6eee24ce
TT
111612019-01-10 Tom Tromey <tom@tromey.com>
11162
11163 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11164 init_psymbol_list.
11165 * psymtab.c (init_psymbol_list): Do nothing if already called.
11166 * psympriv.h (init_psymbol_list): Add comment.
11167 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11168 init_psymbol_list.
11169 * dbxread.c (dbx_symfile_read): Unconditionally call
11170 init_psymbol_list.
11171
75aedd27
TT
111722019-01-10 Tom Tromey <tom@tromey.com>
11173
11174 * xcoffread.c (scan_xcoff_symtab): Update.
11175 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11176 "where".
11177 * mdebugread.c (parse_partial_symbols)
11178 (handle_psymbol_enumerators): Update.
11179 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11180 * dbxread.c (read_dbx_symtab): Update.
11181 * psympriv.h (psymbol_placement): New enum.
11182 (add_psymbol_to_list): Update.
11183
939652a5
TT
111842019-01-10 Tom Tromey <tom@tromey.com>
11185
11186 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11187 static_psymbols parameters.
11188 (scan_xcoff_symtab): Update.
11189 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11190 static_psymbols parameters.
11191 * psympriv.h (start_psymtab_common): Update.
11192 * mdebugread.c (parse_partial_symbols): Update.
11193 * dwarf2read.c (create_partial_symtab): Update.
11194 * dbxread.c (read_dbx_symtab): Update.
11195 (start_psymtab): Remove global_psymbols and static_psymbols
11196 parameters.
11197
baa62830
TT
111982019-01-10 Tom Tromey <tom@tromey.com>
11199
11200 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11201 * psymtab.c (allocate_psymtab): Add comment.
11202 * psympriv.h (allocate_psymtab): Add comment.
11203 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11204 initializations.
11205 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11206
0e8f53ba
TT
112072019-01-10 Tom Tromey <tom@tromey.com>
11208
11209 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11210 Don't declare.
11211 * mipsread.c: Include mdebugread.h.
11212 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11213 Declare.
11214 * elfread.c: Include mdebugread.h.
11215
b22a7c6a
TT
112162019-01-09 Tom Tromey <tom@tromey.com>
11217
11218 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11219 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11220 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11221 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11222 (psym_lookup_symbol, psym_find_last_source_symtab)
11223 (psym_forget_cached_source_info, psym_print_stats)
11224 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11225 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11226 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11227 (psym_find_compunit_symtab_by_address)
11228 (maintenance_print_psymbols, maintenance_info_psymtabs)
11229 (maintenance_check_psymtabs): Use ranged for.
11230 * psymtab.h (class objfile_psymtabs): New.
11231 (require_partial_symbols): Return objfile_psymtabs.
11232 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11233
3b9d3ac2
TT
112342019-01-09 Tom Tromey <tom@tromey.com>
11235
11236 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11237 (find_pc_mapped_section, list_overlays_command)
11238 (map_overlay_command, unmap_overlay_command)
11239 (simple_overlay_update): Use all_objfiles.
11240 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11241 * printcmd.c (info_symbol_command): Use all_objfiles.
11242 * objfiles.h (ALL_OBJSECTIONS): Remove.
11243 * maint.c (maintenance_translate_address): Use all_objfiles.
11244 * gcore.c (gcore_create_callback): Use all_objfiles.
11245 (objfile_find_memory_regions): Likewise.
11246
8b31193a
TT
112472019-01-09 Tom Tromey <tom@tromey.com>
11248
11249 * symtab.c (find_line_symtab, info_sources_command)
11250 (make_source_files_completion_list): Use objfile_compunits.
11251 * source.c (select_source_symtab): Use objfile_compunits.
11252 * objfiles.h (struct objfile): Update comment.
11253 (ALL_OBJFILES): Remove.
11254 (ALL_FILETABS): Remove.
11255 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11256 objfile_compunits.
11257
d5da8b3c
TT
112582019-01-09 Tom Tromey <tom@tromey.com>
11259
11260 * symmisc.c (print_objfile_statistics, dump_objfile)
11261 (maintenance_print_symbols): Use compunit_filetabs.
11262 * source.c (forget_cached_source_info_for_objfile): Use
11263 compunit_filetabs.
11264 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11265 (ALL_FILETABS): Use compunit_filetabs.
11266 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11267 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11268
5accd1a0
TT
112692019-01-09 Tom Tromey <tom@tromey.com>
11270
11271 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11272 (compunit_filetabs): New.
11273 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11274 compunit_filetabs.
11275 (info_sources_command, make_source_files_completion_list): Remove
11276 declaration.
11277 * symmisc.c (print_objfile_statistics, dump_objfile)
11278 (maintenance_print_symbols): Remove declaration.
11279 (maintenance_info_symtabs): Use compunit_filetabs.
11280 (maintenance_info_line_tables): Likewise.
11281 * source.c (select_source_symtab): Change local variable name.
11282 (forget_cached_source_info_for_objfile): Remove declaration.
11283 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11284 * objfiles.c (objfile_relocate1): Remove declaration.
11285 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11286 declaration.
11287 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11288 * coffread.c (coff_symtab_read): Remove declaration.
11289 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11290 compunit_filetabs.
11291
d8aeb77f
TT
112922019-01-09 Tom Tromey <tom@tromey.com>
11293
11294 * symtab.c (lookup_objfile_from_block)
11295 (find_pc_sect_compunit_symtab, search_symbols)
11296 (default_collect_symbol_completion_matches_break_on): Use
11297 objfile_compunits.
11298 * objfiles.h (ALL_COMPUNITS): Remove.
11299 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11300 * cp-support.c (add_symbol_overload_list_qualified): Use
11301 objfile_compunits.
11302 * ada-lang.c (ada_collect_symbol_completion_matches)
11303 (ada_add_global_exceptions): Use objfile_compunits.
11304
592553c4
TT
113052019-01-09 Tom Tromey <tom@tromey.com>
11306
11307 * source.c (select_source_symtab)
11308 (forget_cached_source_info_for_objfile): Remove declaration.
11309 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11310 declaration.
11311 * maint.c (count_symtabs_and_blocks): Remove declaration.
11312 * cp-support.c (add_symbol_overload_list_qualified): Remove
11313 declaration.
11314 * coffread.c (coff_symtab_read): Remove declaration.
11315 * symtab.c (lookup_symbol_in_objfile_symtabs)
11316 (basic_lookup_transparent_type_1): Use objfile_compunits.
11317 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11318 (info_sources_command, search_symbols)
11319 (default_collect_symbol_completion_matches_break_on)
11320 (make_source_files_completion_list): Remove declaration.
11321 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11322 (ada_collect_symbol_completion_matches)
11323 (ada_add_global_exceptions): Remove declaration.
11324 * linespec.c (iterate_over_all_matching_symtabs): Use
11325 objfile_compunits.
11326 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11327 (class objfile_compunits): New.
11328 (ALL_COMPUNITS): Use objfile_compunits.
11329 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11330 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11331 objfile_compunits.
11332 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11333
5325b9bf
TT
113342019-01-09 Tom Tromey <tom@tromey.com>
11335
11336 * symtab.c (search_symbols)
11337 (default_collect_symbol_completion_matches_break_on): Use
11338 objfile_msymbols.
11339 * ada-lang.c (ada_lookup_simple_minsym)
11340 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11341 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11342 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11343 objfile_msymbols.
11344 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11345 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11346 * objc-lang.c (find_methods): Use objfile_msymbols.
11347 (info_selectors_command, info_classes_command): Likewise.
11348 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11349 * objfiles.h (class objfile_msymbols): New.
11350 (ALL_OBJFILE_MSYMBOLS): Remove.
11351 (ALL_MSYMBOLS): Remove.
11352
cac85af2
TT
113532019-01-09 Tom Tromey <tom@tromey.com>
11354
11355 * common/next-iterator.h (next_adapter): Add Iterator template
11356 parameter.
11357 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11358 (class all_objfiles_safe): New.
11359 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11360 * objfiles.c (put_objfile_before): Update comment.
11361 (add_separate_debug_objfile): Likewise.
11362 (free_all_objfiles): Use all_objfiles_safe.
11363 (objfile_purge_solibs): Likewise.
11364
aed57c53
TT
113652019-01-09 Tom Tromey <tom@tromey.com>
11366
11367 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11368 (expand_symtab_containing_pc, lookup_static_symbol)
11369 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11370 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11371 all_objfiles.
11372 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11373 * breakpoint.c (create_overlay_event_breakpoint)
11374 (create_longjmp_master_breakpoint)
11375 (create_std_terminate_master_breakpoint)
11376 (create_exception_master_breakpoint): Use all_objfiles.
11377 * linux-thread-db.c (try_thread_db_load_from_pdir)
11378 (has_libpthread): Use all_objfiles.
11379 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11380 * linespec.c (iterate_over_all_matching_symtabs)
11381 (search_minsyms_for_name): Use all_objfiles.
11382 * maint.c (maintenance_info_sections): Use all_objfiles.
11383 * main.c (captured_main_1): Use all_objfiles.
11384 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11385 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11386 * guile/scm-pretty-print.c
11387 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11388 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11389 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11390 (maintenance_print_msymbols): Use all_objfiles.
11391 * source.c (select_source_symtab): Use all_objfiles.
11392 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11393 * symfile.c (remove_symbol_file_command)
11394 (expand_symtabs_matching, map_symbol_filenames): Use
11395 all_objfiles.
11396 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11397 all_objfiles.
11398 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11399 * objc-lang.c (find_methods): Use all_objfiles.
11400 * objfiles.c (have_partial_symbols, have_full_symbols)
11401 (have_minimal_symbols, qsort_cmp)
11402 (default_iterate_over_objfiles_in_search_order): Use
11403 all_objfiles.
11404 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11405 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11406 (maintenance_check_psymtabs): Use all_objfiles.
11407 (ALL_PSYMTABS): Remove.
11408 * compile/compile-object-run.c (do_module_cleanup): Use
11409 all_objfiles.
11410 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11411 * cp-support.c (add_symbol_overload_list_qualified): Use
11412 all_objfiles.
11413 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11414 Use all_objfiles.
11415 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11416 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11417 all_objfiles.
11418 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11419 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11420 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11421 Uses all_objfiles.
11422 * solib.c (solib_read_symbols): Use all_objfiles
11423
99d89cde
TT
114242019-01-09 Tom Tromey <tom@tromey.com>
11425
11426 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11427 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11428 all_objfiles.
11429 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11430 * symmisc.c (print_symbol_bcache_statistics)
11431 (print_objfile_statistics, maintenance_print_objfiles)
11432 (maintenance_info_symtabs, maintenance_check_symtabs)
11433 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11434 all_objfiles.
11435 * source.c (forget_cached_source_info): Use all_objfiles.
11436 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11437 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11438 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11439 * objfiles.c (update_section_map): Use all_objfiles.
11440 (shared_objfile_contains_address_p): Likewise.
11441 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11442 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11443
21708325
TT
114442019-01-09 Tom Tromey <tom@tromey.com>
11445
11446 * common/next-iterator.h: New file.
11447 * objfiles.h (class all_objfiles): New.
11448 (struct objfile_iterator): New.
11449
669e09f6
PW
114502019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11451
11452 * NEWS: Move the description of the changed "frame", "select-frame",
11453 and "info frame" commands to the Changed commands section.
11454
041be526
SM
114552019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11456
11457 * gdbtypes.c (check_stub_method_group): Remove handling of old
11458 mangling schemes.
11459 * linespec.c (find_methods): Likewise.
11460 * stabsread.c (read_member_functions): Likewise.
11461 * valops.c (search_struct_method): Likewise.
11462 (value_struct_elt_for_reference): Likewise.
11463 * NEWS: Mention this change.
11464
0e2a2133
AB
114652019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11466
11467 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11468 print_source_lines.
11469 * source.c (print_source_lines_base): Update line number check.
11470 (print_source_lines): New function.
11471 (source_lines_range::source_lines_range): New function.
11472 * source.h (class source_lines_range): New class.
11473 (print_source_lines): New declaration.
11474
1055a3b4
PW
114752019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11476
11477 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11478
cfeadda5
TT
114792019-01-08 Tom Tromey <tom@tromey.com>
11480 Simon Marchi <simon.marchi@ericsson.com>
11481
11482 PR gdb/24060
11483 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11484 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11485 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11486 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11487 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11488 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11489
583068ca
AB
114902019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11491
11492 * source.c (select_source_symtab): Move header comment to
11493 declaration in source.h.
11494 (forget_cached_source_info_for_objfile): Likewise.
11495 (forget_cached_source_info): Likewise.
11496 (identify_source_line): Likewise.
11497 * source.h (identify_source_line): Move declaration from symtab.h
11498 and add comment from source.c
11499 (print_source_lines): Likewise.
11500 (forget_cached_source_info_for_objfile): Likewise.
11501 (forget_cached_source_info): Likewise.
11502 (select_source_symtab): Likewise.
11503 (enum print_source_lines_flag): Move definition from symtab.h.
11504 * symtab.h (identify_source_line): Move declaration to source.h.
11505 (print_source_lines): Likewise.
11506 (forget_cached_source_info_for_objfile): Likewise.
11507 (forget_cached_source_info): Likewise.
11508 (select_source_symtab): Likewise.
11509 (enum print_source_lines_flag): Move definition to source.h.
11510 * tui/tui-hooks.c: Add 'source.h' include.
11511
ec98a4ad
AB
115122019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11513
11514 * source.c (print_source_lines_base): Handle requests to print
11515 reverse line number sequences, and guard against empty lines
11516 string.
11517
62ea19c1
AB
115182019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11519
11520 * source.c (print_source_lines_base): Fix skip of '\r' if next
11521 character is '\n'.
11522
9d30e1fd
TT
115232019-01-06 Tom Tromey <tom@tromey.com>
11524
11525 * c-exp.y (struct c_parse_state) <macro_original_text,
11526 expansion_obstack>: New member.
11527 (macro_original_text, expansion_obstack): Remove globals.
11528 (scan_macro_expansion, scanning_macro_expansion)
11529 (finished_macro_expansion): Update.
11530 (scan_macro_cleanup): Remove.
11531 (yylex, c_parse): Update.
11532
c65bac38
TT
115332019-01-06 Tom Tromey <tom@tromey.com>
11534
11535 * c-exp.y (struct c_parse_state) <strings>: New member.
11536 (operator_stoken): Update.
11537
02e12e38
TT
115382019-01-06 Tom Tromey <tom@tromey.com>
11539
11540 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11541 (union type_stack_elt) <typelist_val>: Now a pointer to
11542 std::vector.
11543 (type_stack_cleanup): Don't declare.
11544 (push_typelist): Update.
11545 * parse.c (pop_typelist): Return a std::vector.
11546 (push_typelist): Take a std::vector.
11547 (follow_types): Update. Do not free args.
11548 (type_stack_cleanup): Remove.
11549 * c-exp.y (struct c_parse_state): New.
11550 (cpstate): New global.
11551 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11552 (nonempty_typelist): Update.
11553 (func_mod): Create a new vector.
11554 (c_parse): Create a c_parse_state.
11555 (check_parameter_typelist): Do not delete params.
11556 (function_method): Update. Do not delete type_list.
11557
f097f5ad
TT
115582019-01-06 Tom Tromey <tom@tromey.com>
11559
11560 PR gdb/28155:
11561 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11562 check_typedef.
11563 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11564 (print_return_value): Likewise.
11565
d2adf9f1
TT
115662019-01-05 Tom Tromey <tom@tromey.com>
11567
11568 * contrib/cleanup_check.py: Remove.
11569 * contrib/gcc-with-excheck: Remove.
11570 * contrib/exsummary.py: Remove.
11571 * contrib/excheck.py: Remove.
11572
2eab46b1
JB
115732019-01-05 Joel Brobecker <brobecker@adacore.com>
11574
11575 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11576 NULL. Initialize tpprev to NULL instead of assigning it
11577 to NULL on the next statement.
11578 * windows-nat.c (windows_delete_thread): Remove check for
11579 main_thread_id before printing thread exit notifications.
11580 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11581 Remove thread ID check against main_thread_id.
11582 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11583 windows_delete_thread.
11584 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11585
48c5e7e2
TT
115862019-01-04 Tom Tromey <tom@tromey.com>
11587
11588 * compile/compile.c (_initialize_compile): Use upper case for
11589 metasyntactic variables.
11590 * symmisc.c (_initialize_symmisc): Use upper case for
11591 metasyntactic variables.
11592 * psymtab.c (_initialize_psymtab): Use upper case for
11593 metasyntactic variables.
11594 * demangle.c (demangle_command): Use upper case for metasyntactic
11595 variables.
11596 (_initialize_demangler): Likewise.
11597 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11598 variables.
11599
986041cd
TT
116002019-01-03 Tom Tromey <tom@tromey.com>
11601
11602 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11603
7c711119
TT
116042019-01-03 Tom Tromey <tom@tromey.com>
11605
11606 * python/py-symtab.c (salpy_str): Update.
11607 (struct salpy_sal_object) <symtab>: Now a PyObject.
11608 (salpy_dealloc): Update.
11609 (del_objfile_sal): Use gdbpy_ref.
11610
1b20edf0
TT
116112019-01-03 Tom Tromey <tom@tromey.com>
11612
11613 * python/py-type.c (convert_field): Use new_reference. Return
11614 gdbpy_ref.
11615 (make_fielditem): Return gdbpy_ref.
11616 (typy_fields): Update.
11617 (typy_getitem): Update.
11618 (field_name): Return gdbpy_ref. Use new_reference.
11619 (typy_iterator_iternext): Update.
11620
ea41325b
TT
116212019-01-03 Tom Tromey <tom@tromey.com>
11622
11623 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11624
2a3c71d6
TT
116252019-01-03 Tom Tromey <tom@tromey.com>
11626
11627 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11628 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11629 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11630 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11631 (pspy_set_type_printers): Likewise.
11632 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11633 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11634 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11635 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11636 (objfpy_set_type_printers): Likewise.
11637
5c329e6a
TT
116382019-01-03 Tom Tromey <tom@tromey.com>
11639
11640 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11641 (gdbpy_print_stack): Use gdbpy_err_fetch.
11642 * python/python-internal.h (class gdbpy_err_fetch): New class.
11643 (class gdbpy_enter) <m_error_type, m_error_value,
11644 m_error_traceback>: Remove.
11645 <m_error>: New member.
11646 (gdbpy_exception_to_string): Don't declare.
11647 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11648 * python/py-value.c (convert_value_from_python): Use
11649 gdbpy_err_fetch.
11650 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11651 gdbpy_exception_to_string.
11652 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11653 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11654 gdbpy_err_fetch.
11655
169bb27b
AB
116562019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11657
11658 * linux-nat.c (delete_lwp_cleanup): Delete.
11659 (struct lwp_deleter): New struct.
11660 (lwp_info_up): New typedef.
11661 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11662 lwp_info_up.
11663
a07c8880
AB
116642019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11665
11666 * linux-fork.c (class scoped_switch_fork_info): New class.
11667 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11668
26089c49
AB
116692019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11670
11671 * valops.c (find_overload_match): Remove use of null_cleanup, and
11672 calls to do_cleanups.
11673
06d3e5b0
AB
116742019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11675
11676 * compile/compile-cplus-types.c
11677 (compile_cplus_instance::decl_name): Handle changes to
11678 cp_func_name.
11679 * cp-support.c (cp_func_name): Update header comment, update
11680 return type.
11681 * cp-support.h (cp_func_name): Update return type in declaration.
11682 * valops.c (find_overload_match): Move temp_func local to top
11683 level of function and change its type. Use temp_func to hold and
11684 delete temporary string obtained from cp_func_name.
11685
66644cd3
AB
116862019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11687
11688 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11689 gdb::char_vector, remove cleanup, and update uses of `msg`.
11690
592d8c0a
JW
116912019-01-03 Jim Wilson <jimw@sifive.com>
11692
11693 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11694
c55d06ec
TT
116952019-01-02 Tom Tromey <tom@tromey.com>
11696
11697 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11698 (tdesc_parse_xml): Remove cleanups.
11699 * target-descriptions.h (make_cleanup_free_target_description):
11700 Don't declare.
11701 (target_desc_deleter): New struct.
11702 (target_desc_up): New typedef.
11703 * target-descriptions.c (target_desc_deleter::operator()): Rename
11704 from free_target_description.
11705 (make_cleanup_free_target_description): Remove.
11706
3a6ae42d
TT
117072019-01-02 Tom Tromey <tom@tromey.com>
11708
11709 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11710 constructor, destructor.
11711 (linespec_parser): Remove typedef.
11712 (~linespec_parser): Rename from linespec_parser_delete.
11713 (linespec_lex_to_end, linespec_complete_label)
11714 (linespec_complete): Update.
11715 (decode_line_full): Remove cleanups.
11716 (decode_line_1): Update.
11717
61fd3e73
TT
117182019-01-02 Tom Tromey <tom@tromey.com>
11719
11720 * python/python-internal.h (inferior_to_inferior_object): Change
11721 return type.
11722 * python/py-exitedevent.c (create_exited_event_object): Update.
11723 * python/py-inferior.c (inferior_to_inferior_object): Return
11724 gdbpy_ref.
11725 (python_new_inferior, python_inferior_deleted)
11726 (thread_to_thread_object, delete_thread_object)
11727 (build_inferior_list, gdbpy_selected_inferior): Update.
11728 * python/py-infthread.c (create_thread_object): Update. Also fail
11729 if inferior_to_inferior_object fails.
11730
d20172fc
SM
117312019-01-02 Simon Marchi <simon.marchi@ericsson.com>
11732
11733 * inferior.h (class inferior) <displaced_step_state>: New field.
11734 * infrun.h (struct displaced_step_state): Move here from
11735 infrun.c. Initialize fields, add constructor.
11736 <inf>: Remove field.
11737 <reset>: New method.
11738 * infrun.c (struct displaced_step_inferior_state): Move to
11739 infrun.h.
11740 (displaced_step_inferior_states): Remove.
11741 (get_displaced_stepping_state): Adust.
11742 (displaced_step_in_progress_any_inferior): Adjust.
11743 (displaced_step_in_progress_thread): Adjust.
11744 (displaced_step_in_progress): Adjust.
11745 (add_displaced_stepping_state): Remove.
11746 (get_displaced_step_closure_by_addr): Adjust.
11747 (remove_displaced_stepping_state): Remove.
11748 (infrun_inferior_exit): Call displaced_step_state.reset.
11749 (use_displaced_stepping): Don't check for NULL.
11750 (displaced_step_prepare_throw): Call
11751 get_displaced_stepping_state.
11752 (displaced_step_fixup): Don't check for NULL.
11753 (prepare_for_detach): Don't check for NULL.
11754
e3319240
PW
117552019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11756
11757 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11758 in case of call that did not complete.
11759
5d36dfb9
AU
117602019-01-02 Andrey Utkin <autkin@undo.io>
11761
11762 * symfile.c (find_separate_debug_file): Fix search of debug files for
11763 remote debuggee.
11764
8833fbf0
TT
117652019-01-02 Tom Tromey <tom@tromey.com>
11766
11767 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11768 indentation.
11769 * python/py-frame.c (frapy_older): Remove cast.
11770 (frapy_newer): Likewise.
11771 * python/py-breakpoint.c (local_setattro): Remove cast.
11772 * python/py-arch.c (archpy_name): Remove local variable.
11773 * python/py-type.c (gdbpy_lookup_type): Remove cast.
11774
4ada3dfd
JB
117752019-01-02 Joel Brobecker <brobecker@adacore.com>
11776
11777 * unittests/basic_string_view/element_access/char/empty.cc:
11778 Fix year range in copyright header.
11779
113b7b81
AB
117802019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
11781
11782 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11783 Delete.
11784 <operator==>: Update with for removed field.
11785 <hash>: Likewise.
11786 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11787 <isa_features>: ...this.
11788 <abi_features>: New field.
11789 (riscv_isa_flen): Update comment.
11790 (riscv_abi_xlen): New declaration.
11791 (riscv_abi_flen): New declaration.
11792 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11793 isa_features.
11794 (riscv_abi_xlen): New function.
11795 (riscv_isa_flen): Update to get answer from isa_features.
11796 (riscv_abi_flen): New function.
11797 (riscv_has_fp_abi): Update to get answer from abi_features.
11798 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11799 xlen and flen.
11800 (riscv_call_info) <xlen, flen>: Update comment.
11801 (riscv_call_arg_struct): Remove invalid assertions
11802 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11803 is removed.
11804 (riscv_gdbarch_init): Gather isa features and abi features
11805 separately, ensure both match on the gdbarch when reusing an old
11806 gdbarch. Relax an error check to allow 32-bit abi float to run on
11807 a target with 64-bit float hardware.
11808
b18ca514
PW
118092019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11810
11811 * source.c (search_command_helper): Stop reverse search
11812 when line 1 has been searched.
11813
ec70d8db
PW
118142019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11815
11816 * record-full.c (record_full_base_target::close): Rewrite
11817 record_full_core_buf_list free logic.
11818
5b38f9c1
PW
118192019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11820
11821 * break-catch-syscall.c (print_one_catch_syscall): xfree
11822 the last text.
11823
66d91b39
JB
118242019-01-01 Joel Brobecker <brobecker@adacore.com>
11825
11826 * top.c (print_gdb_version): Update Copyright year in version
11827 message.
11828
42a4f53d
JB
118292019-01-01 Joel Brobecker <brobecker@adacore.com>
11830
11831 Update copyright year range in all GDB files.
11832
7e955d83 118332019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 11834
5bbd631d 11835 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 11836
5bbd631d 11837For older changes see ChangeLog-2018.
c906108c
SS
11838\f
11839Local Variables:
11840mode: change-log
11841left-margin: 8
11842fill-column: 74
11843version-control: never
57da7796 11844coding: utf-8
c906108c 11845End:
5bbd631d 11846
This page took 3.25368 seconds and 4 git commands to generate.