Implement a thread pool
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
a0b57563
CB
12019-11-26 Christian Biesinger <cbiesinger@google.com>
2 Tom Tromey <tom@tromey.com>
3
4 * gdbsupport/thread-pool.h: New file.
5 * gdbsupport/thread-pool.c: New file.
6 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
7 (HFILES_NO_SRCDIR): Add thread-pool.h.
8
3b3978bc
TT
92019-11-26 Tom Tromey <tom@tromey.com>
10
11 * event-top.h (thread_local_segv_handler): Declare.
12 * event-top.c (thread_local_segv_handler): New global.
13 (install_handle_sigsegv, handle_sigsegv): New functions.
14 (async_init_signals): Install SIGSEGV handler.
15 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
16 thread-local.
17 (report_failed_demangle): New function.
18 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
19 handler-setting code, instead use segv_handler. Run warning code
20 on main thread.
21
9411c49e
TT
222019-11-26 Tom Tromey <tom@tromey.com>
23
24 * run-on-main-thread.c: New file.
25 * run-on-main-thread.h: New file.
26 * unittests/main-thread-selftests.c: New file.
27 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
28 main-thread-selftests.c.
29 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
30 (COMMON_SFILES): Add run-on-main-thread.c.
31
c3efb965
TT
322019-11-26 Tom Tromey <tom@tromey.com>
33
34 * main.c (setup_alternate_signal_stack): Remove.
35 (captured_main_1): Use gdb::alternate_signal_stack.
36 * gdbsupport/alt-stack.h: New file.
37
21987b9c
TT
382019-11-26 Tom Tromey <tom@tromey.com>
39
40 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
41 Remove comment.
42 (save_original_signals_state, restore_original_signals_state): Use
43 gdb_sigmask.
44 * linux-nat.c (block_child_signals, restore_child_signals_mask)
45 (_initialize_linux_nat): Use gdb_sigmask.
46 * guile/guile.c (_initialize_guile): Use block_signals.
47 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
48 * gdbsupport/gdb-sigmask.h: New file.
49 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
50 * cp-support.c (gdb_demangle): Use gdb_sigmask.
51 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
52 pthread_sigmask.
53 * configure, config.in: Rebuild.
54 * gdbsupport/block-signals.h: New file.
55
5e030278
TT
562019-11-26 Tom Tromey <tom@tromey.com>
57
58 * acinclude.m4: Include ax_pthread.m4.
59 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
60 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
61 (CLIBS): Use PTHREAD_LIBS.
62 (aclocal_m4_deps): Add ax_pthread.m4.
63 * config.in, configure: Rebuild.
64 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
65
5a79c107
TT
662019-11-26 Tom Tromey <tom@tromey.com>
67
68 * symtab.h (struct minimal_symbol) <name_set>: New member.
69 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
70 Don't call symbol_set_names.
71 (minimal_symbol_reader::install): Call symbol_set_names.
72
aa369509
PW
732019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
74
75 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
76 restore_active_ext_lang, as GIL is needed for (indirectly)
77 called PyOS_InterruptOccurred.
78
cadc9cb8
SM
792019-11-26 Simon Marchi <simon.marchi@efficios.com>
80
81 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
82 definition.
83
d04afd58
SM
842019-11-26 Simon Marchi <simon.marchi@efficios.com>
85
86 * remote-sim.c (simulator_command): Make static, remove
87 declaration.
88
dd694d77
SM
892019-11-26 Simon Marchi <simon.marchi@efficios.com>
90
91 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
92 static.
93 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
94 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
95 (main): Likewise.
96 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
97 (main): Likewise.
98 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
99 (main): Likewise.
100 * unittests/basic_string_view/element_access/char/1.cc (test01):
101 Likewise.
102 (main): Likewise.
103 * unittests/basic_string_view/element_access/char/empty.cc (main):
104 Likewise.
105 * unittests/basic_string_view/element_access/char/front_back.cc
106 (test01): Likewise.
107 (main): Likewise.
108 * unittests/basic_string_view/inserters/char/2.cc (test05):
109 Likewise.
110 (main): Likewise.
111 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
112 (test01): Likewise.
113 (main): Likewise.
114 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
115 (test01): Likewise.
116 (main): Likewise.
117 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
118 Likewise.
119 * unittests/basic_string_view/operations/compare/char/1.cc
120 (test01): Likewise.
121 (main): Likewise.
122 * unittests/basic_string_view/operations/compare/char/13650.cc
123 (test01): Likewise.
124 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
125 Likewise.
126 (main): Likewise.
127 * unittests/basic_string_view/operations/data/char/1.cc (test01):
128 Likewise.
129 (main): Likewise.
130 * unittests/basic_string_view/operations/find/char/1.cc (test01):
131 Likewise.
132 (main): Likewise.
133 * unittests/basic_string_view/operations/find/char/2.cc (test02):
134 Likewise.
135 (main): Likewise.
136 * unittests/basic_string_view/operations/find/char/3.cc (test03):
137 Likewise.
138 (main): Likewise.
139 * unittests/basic_string_view/operations/find/char/4.cc (main):
140 Likewise.
141 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
142 Likewise.
143 (main): Likewise.
144 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
145 Likewise.
146 (main): Likewise.
147 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
148 Likewise.
149 (main): Likewise.
150 * unittests/basic_string_view/operations/substr/char/1.cc
151 (test01): Likewise.
152 (main): Likewise.
153 * unittests/basic_string_view/operators/char/2.cc (main):
154 Likewise.
155 * unittests/optional/assignment/1.cc (test): Likewise.
156 * unittests/optional/assignment/2.cc (test): Likewise.
157 * unittests/optional/assignment/3.cc (test): Likewise.
158 * unittests/optional/assignment/4.cc (test): Likewise.
159 * unittests/optional/assignment/5.cc (test): Likewise.
160 * unittests/optional/assignment/6.cc (test): Likewise.
161 * unittests/optional/assignment/7.cc (test): Likewise.
162 * unittests/optional/cons/copy.cc (test): Likewise.
163 * unittests/optional/cons/default.cc (test): Likewise.
164 * unittests/optional/cons/move.cc (test): Likewise.
165 * unittests/optional/cons/value.cc (test): Likewise.
166 * unittests/optional/in_place.cc (test): Likewise.
167 * unittests/optional/observers/1.cc (test): Likewise.
168 * unittests/optional/observers/2.cc (test): Likewise.
169
3b5c1d49
SM
1702019-11-26 Simon Marchi <simon.marchi@efficios.com>
171
172 * tui-win.h (tui_set_var_cmd): Remove.
173 * tui-win.c (tui_set_var_cmd): Make static.
174
adce99fe
SM
1752019-11-26 Simon Marchi <simon.marchi@efficios.com>
176
177 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
178 rbreak_command_wrapper): Remove.
179 * symtab.c (rbreak_command_wrapper): Remove.
180
fe3adccf
SM
1812019-11-26 Simon Marchi <simon.marchi@efficios.com>
182
183 * inferior.h (info_terminal_command): Remove declaration.
184 * inflow.c (info_terminal_command): Make static.
185
b926335f
SM
1862019-11-26 Simon Marchi <simon.marchi@efficios.com>
187
188 * inferior.c (exit_inferior_silent): Remove.
189
b62f6f54
SM
1902019-11-26 Simon Marchi <simon.marchi@efficios.com>
191
192 * dictionary.c (dict_empty, mdict_empty): Remove.
193 * dictionary.c (mdict_empty): Remove.
194
cb8c24b6
SM
1952019-11-26 Simon Marchi <simon.marchi@efficios.com>
196
197 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
198 (arc_insn_get_memory_offset): Likewise.
199 (arc_insn_dump): Likewise.
200 * cp-support.c (test_cp_symbol_name_matches): Likewise.
201 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
202 * dictionary.c (dict_iterator_next): Likewise.
203 (dict_iter_match_first): Likewise.
204 (dict_iter_match_next): Likewise.
205 * f-lang.c (evaluate_subexp_f): Likewise.
206 * hppa-tdep.c (hppa_read_pc): Likewise.
207 * i386-tdep.c (i386_floatformat_for_type): Likewise.
208 * parse.c (write_exp_elt_msym): Likewise.
209 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
210 * remote.c (remote_packet_size): Likewise.
211 (remote_notif_stop_parse): Likewise.
212 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
213 * s12z-tdep.c (s12z_disassemble_info): Likewise.
214 * source.c (prepare_path_for_appending): Likewise.
215 * sparc64-linux-tdep.c
216 (sparc64_linux_handle_segmentation_fault); Likewise.
217 * stack.c (frame_selection_by_function_completer): Likewise.
218
781597ff
SM
2192019-11-26 Simon Marchi <simon.marchi@efficios.com>
220
221 * completer.c (set_gdb_completion_word_break_characters):
222 Remove.
223
23baa4cc
SM
2242019-11-26 Simon Marchi <simon.marchi@efficios.com>
225
226 * dwarf-index-write.c: Include dwarf-index-write.h.
227 * mi/mi-interp.c: Include mi/mi-interp.h.
228
23767560
SM
2292019-11-26 Simon Marchi <simon.marchi@efficios.com>
230
231 * aarch32-tdep.c: Include aarch32-tdep.h.
232 * aarch32-tdep.h: Forward-declare struct target_desc.
233
6d91ce9a
CB
2342019-11-26 Christian Biesinger <cbiesinger@google.com>
235
236 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
237 strerror.
238 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
239 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
240
3cf2f237
TV
2412019-11-25 Tom de Vries <tdevries@suse.de>
242
243 * contrib/words.sh: Add -c option.
244
5b89c67a
CB
2452019-11-25 Christian Biesinger <cbiesinger@google.com>
246
247 * solib.c (solib_find_1): Change int to bool.
248 (exec_file_find): Change int to bool.
249 (solib_find): Change int to bool.
250 (solib_read_symbols): Change int to bool.
251 (solib_used): Change int to bool.
252 (solib_add): Change int to bool.
253 (info_sharedlibrary_command): Change int to bool.
254 (solib_contains_address_p): Change int to bool.
255 (solib_keep_data_in_core): Change int to bool.
256 (in_solib_dynsym_resolve_code): Change int to bool.
257 (reload_shared_libraries_1): Change int to bool.
258 (gdb_sysroot_changed): Change int to bool.
259 * solib.h (solib_read_symbols): Change int to bool.
260 (solib_contains_address_p): Change int to bool.
261 (solib_keep_data_in_core): Change int to bool.
262 (in_solib_dynsym_resolve_code): Change int to bool.
263 (libpthread_name_p): Change int to bool.
264
6cc8564b
LM
2652019-11-25 Luis Machado <luis.machado@linaro.org>
266
267 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
268 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
269 (remote_packet_max_chars): New static global.
270 (show_remote_packet_max_chars): New function.
271 (remote_target::putpkt_binary): Adjust to use new
272 remote_packet_max_chars option.
273 (remote_target::getpkt_or_notif_sane_1): Likewise.
274 (_initialize_remote): Register new remote-packet-max-chars option.
275
a7cdaa91
SM
2762019-11-24 Simon Marchi <simon.marchi@efficios.com>
277
278 * m68k-linux-nat.c: Include gdbarch.h.
279
26abc753
TT
2802019-11-24 Tom Tromey <tom@tromey.com>
281
282 * symfile.c (read_symbols): Update.
283 * psymtab.c (require_partial_symbols): Change type of "verbose" to
284 bool.
285 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
286 (psym_lookup_symbol, psym_find_last_source_symtab)
287 (psym_forget_cached_source_info, psym_print_stats)
288 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
289 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
290 (psym_map_matching_symbols, psym_expand_symtabs_matching)
291 (psym_find_compunit_symtab_by_address)
292 (maintenance_print_psymbols, maintenance_info_psymtabs)
293 (maintenance_check_psymtabs): Update.
294 * psymtab.h (require_partial_symbols): Change type of "verbose" to
295 bool.
296
012fc909
TT
2972019-11-22 Tom Tromey <tom@tromey.com>
298
299 * observable.h: Update comments.
300
c83d8d32
TT
3012019-11-22 Tom Tromey <tromey@adacore.com>
302
303 * ada-tasks.c (ada_task_is_alive): Make parameter const.
304 (print_ada_task_info): Don't try to fetch thread id if task is not
305 alive.
306
987012b8
CB
3072019-11-22 Christian Biesinger <cbiesinger@google.com>
308
309 * ada-exp.y: Update.
310 * ada-lang.c (sort_choices): Update.
311 (ada_print_symbol_signature): Update.
312 (resolve_subexp): Update.
313 (ada_parse_renaming): Update.
314 (ada_read_renaming_var_value): Update.
315 (lesseq_defined_than): Update.
316 (remove_extra_symbols): Update.
317 (remove_irrelevant_renamings): Update.
318 (ada_add_block_symbols): Update.
319 (ada_collect_symbol_completion_matches): Update.
320 (ada_is_renaming_symbol): Update.
321 (aggregate_assign_from_choices): Update.
322 (ada_evaluate_subexp): Update.
323 (ada_has_this_exception_support): Update.
324 (ada_is_non_standard_exception_sym): Update.
325 (ada_add_exceptions_from_frame): Update.
326 (ada_add_global_exceptions): Update.
327 (ada_print_subexp): Update.
328 * ax-gdb.c (gen_var_ref): Update.
329 (gen_maybe_namespace_elt): Update.
330 (gen_expr_for_cast): Update.
331 (gen_expr): Update.
332 * block.h: Update.
333 * blockframe.c (find_pc_partial_function): Update.
334 * breakpoint.c (print_breakpoint_location): Update.
335 (update_static_tracepoint): Update.
336 * btrace.c (ftrace_print_function_name): Update.
337 (ftrace_function_switched): Update.
338 * buildsym.c (find_symbol_in_list): Update.
339 * c-exp.y: Update.
340 * c-typeprint.c (c_print_typedef): Update.
341 (c_type_print_template_args): Update.
342 * cli/cli-cmds.c (edit_command): Update.
343 (list_command): Update.
344 (print_sal_location): Update.
345 * coffread.c (patch_opaque_types): Update.
346 (process_coff_symbol): Update.
347 (coff_read_enum_type): Update.
348 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
349 (convert_one_symbol): Update.
350 (hash_symname): Update.
351 (eq_symname): Update.
352 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
353 * compile/compile-cplus-types.c (debug_print_scope): Update.
354 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
355 * compile/compile-object-load.c (get_out_value_type): Update.
356 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
357 (search_symbol_list): Update.
358 (cp_lookup_symbol_imports_or_template): Update.
359 * cp-support.c (overload_list_add_symbol): Update.
360 * ctfread.c (psymtab_to_symtab): Update.
361 * dbxread.c (cp_set_block_scope): Update.
362 * dictionary.c (iter_match_first_hashed): Update.
363 (iter_match_next_hashed): Update.
364 (insert_symbol_hashed): Update.
365 (iter_match_next_linear): Update.
366 * dictionary.h: Update.
367 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
368 (locexpr_describe_location_piece): Update.
369 (locexpr_describe_location_1): Update.
370 (locexpr_generate_c_location): Update.
371 (loclist_describe_location): Update.
372 (loclist_generate_c_location): Update.
373 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
374 (read_func_scope): Update.
375 (process_enumeration_scope): Update.
376 (new_symbol): Update.
377 (dwarf2_const_value): Update.
378 (dwarf2_symbol_mark_computed): Update.
379 * eval.c (evaluate_funcall): Update.
380 (evaluate_subexp_standard): Update.
381 * expprint.c (print_subexp_standard): Update.
382 (dump_subexp_body_standard): Update.
383 * f-valprint.c (info_common_command_for_block): Update.
384 * findvar.c (get_hosting_frame): Update.
385 (default_read_var_value): Update.
386 * go-lang.c (go_symbol_package_name): Update.
387 * guile/scm-block.c (bkscm_print_block_smob): Update.
388 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
389 (gdbscm_symbol_name): Update.
390 (gdbscm_symbol_linkage_name): Update.
391 (gdbscm_symbol_print_name): Update.
392 * infcall.c (get_function_name): Update.
393 * infcmd.c (jump_command): Update.
394 (finish_command): Update.
395 * infrun.c (insert_exception_resume_breakpoint): Update.
396 * linespec.c (canonicalize_linespec): Update.
397 (create_sals_line_offset): Update.
398 (convert_linespec_to_sals): Update.
399 (complete_label): Update.
400 (find_label_symbols_in_block): Update.
401 * m2-typeprint.c (m2_print_typedef): Update.
402 * mdebugread.c (mdebug_reg_to_regnum): Update.
403 (parse_symbol): Update.
404 (mylookup_symbol): Update.
405 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
406 (list_args_or_locals): Update.
407 * objc-lang.c (compare_selectors): Update.
408 (info_selectors_command): Update.
409 (compare_classes): Update.
410 (info_classes_command): Update.
411 (find_imps): Update.
412 * p-typeprint.c (pascal_print_typedef): Update.
413 * printcmd.c (build_address_symbolic): Update.
414 (info_address_command): Update.
415 (print_variable_and_value): Update.
416 * python/py-framefilter.c (extract_sym): Update.
417 (py_print_single_arg): Update.
418 * python/py-symbol.c (sympy_str): Update.
419 (sympy_get_name): Update.
420 (sympy_get_linkage_name): Update.
421 * python/python.c (gdbpy_rbreak): Update.
422 * record-btrace.c (btrace_get_bfun_name): Update.
423 (btrace_call_history): Update.
424 * rust-lang.c (rust_print_typedef): Update.
425 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
426 * stabsread.c (stab_reg_to_regnum): Update.
427 (define_symbol): Update.
428 (read_enum_type): Update.
429 (common_block_end): Update.
430 (cleanup_undefined_types_1): Update.
431 (scan_file_globals): Update.
432 * stack.c (print_frame_arg): Update.
433 (print_frame_args): Update.
434 (find_frame_funname): Update.
435 (info_frame_command_core): Update.
436 (iterate_over_block_locals): Update.
437 (print_block_frame_labels): Update.
438 (do_print_variable_and_value): Update.
439 (iterate_over_block_arg_vars): Update.
440 (return_command): Update.
441 * symmisc.c (dump_symtab_1): Update.
442 (print_symbol): Update.
443 * symtab.c (eq_symbol_entry): Update.
444 (symbol_cache_dump): Update.
445 (lookup_language_this): Update.
446 (find_pc_sect_line): Update.
447 (skip_prologue_sal): Update.
448 (symbol_search::compare_search_syms): Update.
449 (treg_matches_sym_type_name): Update.
450 (search_symbols): Update.
451 (print_symbol_info): Update.
452 (rbreak_command): Update.
453 (completion_list_add_symbol): Update.
454 (find_gnu_ifunc): Update.
455 (get_symbol_address): Update.
456 (search_module_symbols): Update.
457 (info_module_subcommand): Update.
458 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
459 (SYMBOL_LINKAGE_NAME): Remove.
460 (SYMBOL_DEMANGLED_NAME): Remove.
461 (SYMBOL_PRINT_NAME): Remove.
462 (SYMBOL_SEARCH_NAME): Remove.
463 * tracepoint.c (set_traceframe_context): Update.
464 (validate_actionline): Update.
465 (collection_list::collect_symbol): Update.
466 (encode_actions_1): Update.
467 (info_scope_command): Update.
468 (print_one_static_tracepoint_marker): Update.
469 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
470 * valops.c (address_of_variable): Update.
471 (find_overload_match): Update.
472 (find_oload_champ): Update.
473
c9d95fa3
CB
4742019-11-22 Christian Biesinger <cbiesinger@google.com>
475
476 * ada-lang.c (ada_lookup_simple_minsym): Update.
477 (ada_collect_symbol_completion_matches): Update.
478 * ada-tasks.c (read_atcb): Update.
479 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
480 (amd64_windows_skip_trampoline_code): Update.
481 * arm-tdep.c (skip_prologue_function): Update.
482 (arm_skip_stack_protector): Update.
483 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
484 (arm_wince_skip_main_prologue): Update.
485 * ax-gdb.c (gen_expr): Update.
486 * block.c (call_site_for_pc): Update.
487 * blockframe.c (find_pc_partial_function): Update.
488 * breakpoint.c (set_breakpoint_location_function): Update.
489 * btrace.c (ftrace_print_function_name): Update.
490 (ftrace_function_switched): Update.
491 * c-valprint.c (print_unpacked_pointer): Update.
492 * coffread.c (coff_symfile_read): Update.
493 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
494 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
495 * dwarf-index-write.c (write_psymbols): Update.
496 * dwarf2loc.c (call_site_to_target_addr): Update.
497 (func_verify_no_selftailcall): Update.
498 (tailcall_dump): Update.
499 (call_site_find_chain_1): Update.
500 (dwarf_expr_reg_to_entry_parameter): Update.
501 * elfread.c (elf_gnu_ifunc_record_cache): Update.
502 * eval.c (evaluate_funcall): Update.
503 (evaluate_subexp_standard): Update.
504 (evaluate_subexp_for_sizeof): Update.
505 * expprint.c (print_subexp_standard): Update.
506 (dump_subexp_body_standard): Update.
507 * frame.c (get_prev_frame_always_1): Update.
508 * frv-tdep.c (frv_skip_main_prologue): Update.
509 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
510 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
511 (gnuv3_get_typename_from_type_info): Update.
512 (gnuv3_skip_trampoline): Update.
513 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
514 * i386-tdep.c (i386_skip_main_prologue): Update.
515 (i386_pe_skip_trampoline_code): Update.
516 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
517 * infcall.c (get_function_name): Update.
518 * linespec.c (minsym_found): Update.
519 * linux-fork.c (info_checkpoints_command): Update.
520 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
521 (m32c_m16c_pointer_to_address): Update.
522 * maint.c (maintenance_translate_address): Update.
523 * minsyms.c (add_minsym_to_hash_table): Update.
524 (add_minsym_to_demangled_hash_table): Update.
525 (lookup_minimal_symbol_mangled): Update.
526 (lookup_minimal_symbol_demangled): Update.
527 (lookup_minimal_symbol_linkage): Update.
528 (lookup_minimal_symbol_text): Update.
529 (lookup_minimal_symbol_by_pc_name): Update.
530 (minimal_symbol_is_less_than): Update.
531 (compact_minimal_symbols): Update.
532 (build_minimal_symbol_hash_tables): Update.
533 (find_solib_trampoline_target): Update.
534 * mips-tdep.c (mips_stub_frame_sniffer): Update.
535 (mips_skip_pic_trampoline_code): Update.
536 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
537 * objc-lang.c (info_selectors_command): Update.
538 (info_classes_command): Update.
539 (find_methods): Update.
540 (find_imps): Update.
541 * p-valprint.c (pascal_val_print): Update.
542 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
543 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
544 * printcmd.c (build_address_symbolic): Update.
545 (info_symbol_command): Update.
546 * psymtab.c (psymbol_name_matches): Update.
547 (match_partial_symbol): Update.
548 (lookup_partial_symbol): Update.
549 (print_partial_symbols): Update.
550 (sort_pst_symbols): Update.
551 (maintenance_check_psymtabs): Update.
552 * python/py-framefilter.c (py_print_frame): Update.
553 * python/python.c (gdbpy_rbreak): Update.
554 * record-btrace.c (btrace_get_bfun_name): Update.
555 (btrace_call_history): Update.
556 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
557 (rs6000_skip_trampoline_code): Update.
558 * sol-thread.c (info_cb): Update.
559 * stabsread.c (scan_file_globals): Update.
560 * stack.c (find_frame_funname): Update.
561 (info_frame_command_core): Update.
562 * symmisc.c (dump_msymbols): Update.
563 * symtab.c (symbol_natural_name): Rename to..,
564 (general_symbol_info::natural_name): ...this.
565 (symbol_demangled_name): Rename to...
566 (general_symbol_info::demangled_name): ...this.
567 (symbol_search_name): Rename to...
568 (general_symbol_info::search_name): ...this.
569 (symbol_matches_search_name): Update.
570 (find_pc_sect_line): Update.
571 (skip_prologue_sal): Update.
572 (search_symbols): Update.
573 (print_msymbol_info): Update.
574 (rbreak_command): Update.
575 (completion_list_add_msymbol): Update.
576 (completion_list_objc_symbol): Update.
577 (get_msymbol_address): Update.
578 * symtab.h (struct general_symbol_info): Add member functions
579 natural_name (), linkage_name (), print_name (), demangled_name (),
580 and search_name ().
581 (SYMBOL_NATURAL_NAME): Update.
582 (symbol_natural_name): Move to a member function on general_symbol_info.
583 (SYMBOL_DEMANGLED_NAME): Update.
584 (symbol_demangled_name): Move to a member function on
585 general_symbol_info.
586 (SYMBOL_SEARCH_NAME): Update.
587 (symbol_search_name): Move to a member function on general_symbol_info.
588 (MSYMBOL_NATURAL_NAME): Remove.
589 (MSYMBOL_LINKAGE_NAME): Remove.
590 (MSYMBOL_PRINT_NAME): Remove.
591 (MSYMBOL_DEMANGLED_NAME): Remove.
592 (MSYMBOL_SEARCH_NAME): Remove.
593 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
594
f8bab2d6
CB
5952019-11-22 Christian Biesinger <cbiesinger@google.com>
596
597 * symtab.c (create_demangled_names_hash): Use per_bfd->
598 minimal_symbol_count for computing the initial size, if greater
599 than our default size.
600
85e7588d
TV
6012019-11-22 Tom de Vries <tdevries@suse.de>
602
603 * contrib/words.sh: Improve words extraction.
604
f6180073
TV
6052019-11-22 Tom de Vries <tdevries@suse.de>
606
607 * contrib/words.sh: Combine sed invocations.
608
f10ffa41
CB
6092019-11-21 Christian Biesinger <cbiesinger@google.com>
610
611 * Makefile.in: Update.
612 * demangle.c: Rename to...
613 * gdb-demangle.c: ..this.
614 (is_cplus_marker): Change return type to bool.
615 (_initialize_demangler): Rename to...
616 (_initialize_gdb_demangle): ...this.
617 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
618 * symtab.h (demangle): Remove declaration; instead include
619 gdb-demangle.h.
620
6ba18521
TT
6212019-11-21 Tom Tromey <tromey@adacore.com>
622
623 * gdbsupport/format.c (format_pieces): Parse %I64d.
624 * unittests/format_pieces-selftests.c (test_windows_formats): New
625 function.
626 (run_tests): Call it.
627
34877895
PJ
6282019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
629
630 Byte reverse display of variables with DW_END_big, DW_END_little
631 (DW_AT_endianity) dwarf attributes if different than the native
632 byte order.
633 * ada-lang.c (ada_value_binop):
634 Use type_byte_order instead of gdbarch_byte_order.
635 * ada-valprint.c (printstr):
636 (ada_val_print_string):
637 * ada-lang.c (value_pointer):
638 (ada_value_binop):
639 Use type_byte_order instead of gdbarch_byte_order.
640 * c-lang.c (c_get_string):
641 Use type_byte_order instead of gdbarch_byte_order.
642 * c-valprint.c (c_val_print_array):
643 Use type_byte_order instead of gdbarch_byte_order.
644 * cp-valprint.c (cp_print_class_member):
645 Use type_byte_order instead of gdbarch_byte_order.
646 * dwarf2loc.c (rw_pieced_value):
647 Use type_byte_order instead of gdbarch_byte_order.
648 * dwarf2read.c (read_base_type): Handle DW_END_big,
649 DW_END_little
650 * f-lang.c (f_get_encoding):
651 Use type_byte_order instead of gdbarch_byte_order.
652 * findvar.c (default_read_var_value):
653 Use type_byte_order instead of gdbarch_byte_order.
654 * gdbtypes.c (check_types_equal):
655 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
656 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
657 and TYPE_ENDIANITY_LITTLE if set.
658 (type_byte_order): new function.
659 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
660 (struct main_type) <flag_endianity_not_default>:
661 New field.
662 (type_byte_order): New function.
663 * infcmd.c (default_print_one_register_info):
664 Use type_byte_order instead of gdbarch_byte_order.
665 * p-lang.c (pascal_printstr):
666 Use type_byte_order instead of gdbarch_byte_order.
667 * p-valprint.c (pascal_val_print):
668 Use type_byte_order instead of gdbarch_byte_order.
669 * printcmd.c (print_scalar_formatted):
670 Use type_byte_order instead of gdbarch_byte_order.
671 * solib-darwin.c (darwin_current_sos):
672 Use type_byte_order instead of gdbarch_byte_order.
673 * solib-svr4.c (solib_svr4_r_ldsomap):
674 Use type_byte_order instead of gdbarch_byte_order.
675 * stap-probe.c (stap_modify_semaphore):
676 Use type_byte_order instead of gdbarch_byte_order.
677 * target-float.c (target_float_same_format_p):
678 Use type_byte_order instead of gdbarch_byte_order.
679 * valarith.c (scalar_binop):
680 (value_bit_index):
681 Use type_byte_order instead of gdbarch_byte_order.
682 * valops.c (value_cast):
683 Use type_byte_order instead of gdbarch_byte_order.
684 * valprint.c (generic_emit_char):
685 (generic_printstr):
686 (val_print_string):
687 Use type_byte_order instead of gdbarch_byte_order.
688 * value.c (unpack_long):
689 (unpack_bits_as_long):
690 (unpack_value_bitfield):
691 (modify_field):
692 (pack_long):
693 (pack_unsigned_long):
694 Use type_byte_order instead of gdbarch_byte_order.
695 * findvar.c (unsigned_pointer_to_address):
696 (signed_pointer_to_address):
697 (unsigned_address_to_pointer):
698 (address_to_signed_pointer):
699 (default_read_var_value):
700 (default_value_from_register):
701 Use type_byte_order instead of gdbarch_byte_order.
702 * gnu-v3-abi.c (gnuv3_make_method_ptr):
703 Use type_byte_order instead of gdbarch_byte_order.
704 * riscv-tdep.c (riscv_print_one_register_info):
705 Use type_byte_order instead of gdbarch_byte_order.
706
87fb00ea
SM
7072019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
708
709 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
710 (current_ui_gdb_stdin_ptr): Likewise.
711 (current_ui_gdb_stderr_ptr): Likewise.
712 (current_ui_gdb_stdlog_ptr): Likewise.
713 (current_ui_current_uiout_ptr): Likewise.
714 (gen_ret_current_ui_field_ptr): Remove.
715
65d1cd5f
TV
7162019-11-21 Tom de Vries <tdevries@suse.de>
717
718 PR gdb/24956
719 * cli/cli-script.c (execute_control_command): Only switch to
720 INTERP_CONSOLE's ui_out when INTERP_MI is active.
721
9f6ad286
TT
7222019-11-19 Tom Tromey <tom@tromey.com>
723
724 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
725 Now static. Change type of "name".
726 (tui_set_win_height_command): Don't copy "arg".
727 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
728 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
729
435d3d88
AT
7302019-11-19 Ali Tamur <tamur@google.com>
731
732 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
733 "if (attr != nullptr)".
734 (dwarf2_find_base_address): Likewise.
735 (dwarf2_build_include_psymtabs): Likewise.
736 (read_cutu_die_from_dwo): Likewise.
737 (read_func_scope): Likewise.
738 (read_call_site_scope): Likewise.
739 (dwarf2_get_pc_bounds): Likewise.
740 (dwarf2_record_block_ranges): Likewise.
741 (dwarf2_add_field): Likewise.
742 (dwarf2_add_member_fn): Likewise.
743 (read_structure_type): Likewise.
744 (read_enumeration_type): Likewise.
745 (read_array_type): Likewise.
746 (read_array_order): Likewise.
747 (read_set_type): Likewise.
748 (read_common_block): Likewise.
749 (read_tag_reference_type): Likewise.
750 (read_tag_string_type): Likewise.
751 (read_subroutine_type): Likewise.
752 (read_base_type): Likewise.
753 (read_subrange_type): Likewise.
754 (new_symbol): Likewise.
755 (prepare_one_comp_unit): Likewise.
756
c9739b6a
TT
7572019-11-19 Tom Tromey <tromey@adacore.com>
758
759 * windows-nat.c (windows_nat_target::attach): Include GetLastError
760 result in error when DebugActiveProcess fails.
761
494409bb
SDJ
7622019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
763 Pedro Alves <palves@redhat.com>
764
765 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
766 * target.c (target_stack::push): Call 'unpush' if there's a
767 target on top of the stack.
768
2e953aca
PW
7692019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
770
771 * python/py-block.c (blpy_dealloc): Call tp_free.
772 (blpy_block_syms_dealloc): Likewise.
773 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
774 * python/py-inferior.c (infpy_dealloc): Likewise.
775 * python/py-lazy-string.c (stpy_dealloc): Likewise.
776 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
777 * python/py-symbol.c (sympy_dealloc): Likewise.
778 * python/py-symtab.c (stpy_dealloc): Likewise.
779 * python/py-type.c (typy_iterator_dealloc): Likewise.
780
6edc43ec
CB
7812019-11-18 Christian Biesinger <cbiesinger@google.com>
782
783 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
784 constructor instead of using a class initializer.
785
cd850b40
CB
7862019-11-15 Christian Biesinger <cbiesinger@google.com>
787
788 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
789 * configure: Regenerate.
790 * configure.ac: Don't source common.host.
791 * gdbsupport/common.host: Remove.
792 * gdbsupport/mingw-strerror.c: Remove.
793 * gdbsupport/posix-strerror.c: Rename to...
794 * gdbsupport/safe-strerror.c: ...this.
795
53fea9c7
CB
7962019-11-15 Christian Biesinger <cbiesinger@google.com>
797
798 * maint.c (scoped_command_stats::print_time): Use localtime_r
799 instead of localtime (provided through gnulib if necessary).
800 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
801 of ctime.
802
f8e27d88
CB
8032019-11-15 Christian Biesinger <cbiesinger@google.com>
804
805 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
806 avoid compile errors.
807
5abebf3c
CB
8082019-11-15 Christian Biesinger <cbiesinger@google.com>
809
810 * config.in: Regenerate.
811 * configure: Regenerate.
812 * gdbsupport/common.m4: No longer check for strerror_r.
813 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
814 POSIX version of strerror_r, now that gnulib provides it if
815 necessary.
816
9a351667
CB
8172019-11-14 Christian Biesinger <cbiesinger@google.com>
818
819 * README (`configure' options): Update.
820
55708e99
TT
8212019-11-14 Tom Tromey <tromey@adacore.com>
822
823 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
824 expected type for the RHS if the LHS is a convenience variable.
825
4b09bb2e
SM
8262019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
827
828 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
829 Provide explicit default and copy constructor.
830
bd454f8b
PW
8312019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
832
833 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
834 only call Py_INCREF (newbp) in the bppy_pending_object case.
835
d1aa3cf0
TT
8362019-11-13 Tom Tromey <tromey@adacore.com>
837
838 PR build/25182:
839 * psympriv.h (partial_symbol): Remove static assert.
840 * symtab.h (general_symbol_info, symbol): Remove static assert.
841
e06f3d6e
AB
8422019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
843
844 * gdbsupport/format.c (format_pieces::format_pieces): Support
845 printf 'z' size modifier.
846 * gdbsupport/format.h (enum argclass): Add size_t_arg.
847 * printcmd.c (ui_printf): Handle size_t_arg.
848 * ui-out.c (ui_out::vmessage): Likewise.
849 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
850 function.
851 (run_tests): Call test_format_int_sizes.
852
468c0cbb
CB
8532019-11-12 Christian Biesinger <cbiesinger@google.com>
854
855 * ada-exp.y (write_ambiguous_var): Update.
856 * buildsym.c (add_symbol_to_list): Update.
857 * dwarf2read.c (read_variable): Update.
858 (new_symbol): Update.
859 * jit.c (finalize_symtab): Update.
860 * language.c (language_alloc_type_symbol): Update.
861 * symtab.c (fixup_symbol_section): Update.
862 (initialize_objfile_symbol_1): Move code to...
863 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
864 (allocate_symbol): Update.
865 (allocate_template_symbol): Update.
866 (get_symbol_address): Update.
867 * symtab.h (struct symbol): Inherit from general_symbol_info instead
868 of having as a field, and add a constructor.
869 (SYMBOL_VALUE): Update.
870 (SYMBOL_VALUE_ADDRESS): Update.
871 (SET_SYMBOL_VALUE_ADDRESS): Update.
872 (SYMBOL_VALUE_BYTES): Update.
873 (SYMBOL_VALUE_COMMON_BLOCK): Update.
874 (SYMBOL_BLOCK_VALUE): Update.
875 (SYMBOL_VALUE_CHAIN): Update.
876 (SYMBOL_LANGUAGE): Update.
877 (SYMBOL_SECTION): Update.
878 (SYMBOL_OBJ_SECTION): Update.
879 (SYMBOL_SET_LANGUAGE): Update.
880 (SYMBOL_SET_LINKAGE_NAME): Update.
881 (SYMBOL_SET_NAMES): Update.
882 (SYMBOL_NATURAL_NAME): Update.
883 (SYMBOL_LINKAGE_NAME): Update.
884 (SYMBOL_DEMANGLED_NAME): Update.
885 (SYMBOL_SEARCH_NAME): Update.
886 (SYMBOL_MATCHES_SEARCH_NAME): Update.
887 (struct symbol): Update.
888 (struct template_symbol): Update.
889 (struct rust_vtable_symbol): Update.
890 * xcoffread.c (SYMBOL_DUP): Update.
891
ed2c82c3
TT
8922019-11-12 Tom Tromey <tom@tromey.com>
893
894 * tui/tui-layout.c (show_layout): Set current_layout.
895 (show_source_disasm_command, show_data)
896 (show_source_or_disasm_and_command): Don't set current_layout.
897
d9fcefd5
TT
8982019-11-12 Tom Tromey <tom@tromey.com>
899
900 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
901
45e42163
TT
9022019-11-12 Tom Tromey <tom@tromey.com>
903
904 * tui/tui-win.c (resize_message): New global.
905 (show_tui_resize_message): New function.
906 (tui_async_resize_screen): Print message if requested.
907 (_initialize_tui_win): Add tui-resize-message setting.
908 * NEWS: Add entry for new commands.
909
c86d74cc
TT
9102019-11-11 Tom Tromey <tom@tromey.com>
911
912 * tui/tui.c (tui_initialize_readline): Add new bindable readline
913 functions.
914
7b7b9424
CB
9152019-11-11 Christian Biesinger <cbiesinger@google.com>
916
917 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
918
086baaf1
AB
9192019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
920
921 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
922 function.
923 * python/python-internal.h (gdbpy_lookup_static_symbols):
924 Declare new function.
925 * python/python.c (python_GdbMethods): Add
926 gdb.lookup_static_symbols method.
927 * NEWS: Mention gdb.lookup_static_symbols.
928
09ff83af
AB
9292019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
930
931 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
932 static block of current object file first. Also fix typo in
933 header comment.
934
eb2dd8df
AB
9352019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
936
937 * stack.c (set_last_displayed_sal): Delete.
938 (last_displayed_sal_valid): Delete.
939 (last_displayed_pspace): Delete.
940 (last_displayed_addr): Delete.
941 (last_displayed_symtab): Delete.
942 (last_displayed_line): Delete.
943 (class last_displayed_symtab_info_type): New.
944 (last_displayed_symtab_info): New static global variable.
945 (print_frame_info): Call methods on last_displayed_symtab_info.
946 (clear_last_displayed_sal): Update header comment, and make use of
947 last_displayed_symtab_info.
948 (last_displayed_sal_is_valid): Likewise.
949 (get_last_displayed_pspace): Likewise.
950 (get_last_displayed_addr): Likewise.
951 (get_last_displayed_symtab): Likewise.
952 (get_last_displayed_line): Likewise.
953 (get_last_displayed_sal): Likewise.
954 * stack.h (clear_last_displayed_sal): Update header comment.
955 (last_displayed_sal_is_valid): Likewise.
956 (get_last_displayed_pspace): Likewise.
957 (get_last_displayed_addr): Likewise.
958 (get_last_displayed_symtab): Likewise.
959 (get_last_displayed_line): Likewise.
960 (get_last_displayed_sal): Likewise.
961
62137775
AB
9622019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
963
964 * stack.c (frame_show_address): Convert return type to bool.
965 * stack.h (frame_show_address): Likewise, and update header
966 comment.
967
cf57ad6d
AB
9682019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
969
970 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
971 * unittests/vec-utils-selftests.c: New file.
972 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
973
0b026263
TT
9742019-11-10 Tom Tromey <tom@tromey.com>
975
976 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
977 (tui_highlight_win): Likewise.
978 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
979 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
980 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
981 Don't set can_highlight.
982
b049ce2d
TT
9832019-11-10 Tom Tromey <tom@tromey.com>
984
985 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
986 Remove unused declaration.
987
992a7040
TT
9882019-11-08 Tom Tromey <tromey@adacore.com>
989
990 * top.c (read_command_file): Update.
991 (command_line_input): Make return type const.
992 * python/py-gdb-readline.c: Update.
993 * linespec.c (decode_line_2): Update.
994 * defs.h (command_line_input): Make return type const.
995 * cli/cli-script.c (read_next_line): Make return type const.
996 * ada-lang.c (get_selections): Update.
997
ca3a04f6
CB
9982019-11-06 Christian Biesinger <cbiesinger@google.com>
999
1000 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1001 * mi/mi-main.c (output_cores): Likewise.
1002 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1003 (linux_xfer_osdata_modules): Likewise.
1004 * remote.c (register_remote_support_xml): Likewise.
1005 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1006 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1007
e0eac551
TT
10082019-11-06 Tom Tromey <tom@tromey.com>
1009
1010 * tui/tui-interp.c: Don't include readline.h.
1011 * tui/tui-hooks.c: Don't include readline.h.
1012 * symmisc.c: Include tilde.h, not readline.h.
1013 * symfile.c: Include tilde.h, not readline.h.
1014 * source.c: Include tilde.h, not readline.h.
1015 * solib.c: Include tilde.h, not readline.h.
1016 * psymtab.c: Include tilde.h, not readline.h.
1017 * exec.c: Include tilde.h, not readline.h.
1018 * corelow.c: Include tilde.h, not readline.h.
1019 * cli/cli-dump.c: Include tilde.h, not readline.h.
1020 * cli/cli-cmds.c: Don't include readline.h.
1021
825165c5
TT
10222019-11-05 Tom Tromey <tom@tromey.com>
1023
1024 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1025 (tui_disassemble): Set addr_size.
1026 (tui_disasm_window::set_contents): Use addr_size.
1027
91ae903f
TT
10282019-11-05 Tom Tromey <tom@tromey.com>
1029
1030 * rust-lang.c (rust_language_defn): Update.
1031 * python/py-value.c (valpy_string): Call c_get_string.
1032 * p-lang.c (pascal_language_defn): Update.
1033 * opencl-lang.c (opencl_language_defn): Update.
1034 * objc-lang.c (objc_language_defn): Update.
1035 * m2-lang.c (m2_language_defn): Update.
1036 * language.c (unknown_language_defn, auto_language_defn): Update.
1037 (default_get_string): Remove.
1038 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1039 * go-lang.c (go_language_defn): Update.
1040 * f-lang.c (f_language_defn): Update.
1041 * d-lang.c (d_language_defn): Update.
1042 * c-lang.c (c_language_defn, cplus_language_defn)
1043 (asm_language_defn, minimal_language_defn): Update.
1044 * ada-lang.c (ada_language_defn): Update.
1045 * language.h (struct language_defn) <la_get_string>: Remove.
1046 (LA_GET_STRING): Remove.
1047 (default_get_string): Don't declare.
1048
1df2f9ef
TT
10492019-11-05 Tom Tromey <tom@tromey.com>
1050
1051 * tui/tui-source.h (struct tui_source_window): Inline
1052 constructor. Remove destructor.
1053 <style_changed, m_observable>: Move to superclass.
1054 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1055 (struct tui_source_window_base): Move private members to end.
1056 <style_changed, m_observable>: Move from tui_source_window.
1057 * tui/tui-winsource.c (tui_copy_source_line): Move from
1058 tui-source.c. Rename from copy_source_line. Add special handling
1059 for negative line number.
1060 (tui_source_window_base::style_changed): Move from
1061 tui_source_window.
1062 (tui_source_window_base): Register observer.
1063 (~tui_source_window_base): New.
1064 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1065 rename.
1066 (tui_source_window::set_contents): Use tui_copy_source_line.
1067 (tui_source_window::tui_source_window): Move to tui-source.h.
1068 (tui_source_window::~tui_source_window): Remove.
1069 (tui_source_window::style_changed): Move to superclass.
1070 * tui/tui-disasm.c (tui_disassemble): Create string file with
1071 styling, when possible. Add "addr_size" parameter.
1072 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1073 Don't compute maximum size.
1074 (len_without_escapes): New function
1075
5d051055
TT
10762019-11-05 Tom Tromey <tom@tromey.com>
1077
1078 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1079 std::string.
1080 * tui/tui-winsource.c (tui_show_source_line): Update.
1081 * tui/tui-source.c (tui_source_window::set_contents): Update.
1082 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1083
ade7beea
CB
10842019-11-05 Christian Biesinger <cbiesinger@google.com>
1085
1086 * symtab.h (gdb_static_assert): Put && operator at the beginning
1087 of the line instead of the end.
1088
3573abe1
CB
10892019-11-04 Christian Biesinger <cbiesinger@google.com>
1090
1091 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1092 and sizeof (symbol).
1093 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1094
dae8b3eb
RO
10952019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1096
1097 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1098 * configure.host: Mark *-*-solaris2.10* obsolete.
1099 * configure.tgt: Mark Solaris < 11 obsolete.
1100 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1101 Update target triplet.
1102
5df96a4e
TT
11032019-11-01 Tom Tromey <tromey@adacore.com>
1104
1105 * utils.c (print_sys_errmsg): Simplify.
1106
b7481649
TT
11072019-11-01 Tom Tromey <tromey@adacore.com>
1108
1109 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1110
e48f6033
CB
11112019-11-01 Christian Biesinger <cbiesinger@google.com>
1112
1113 * configure: Regenerate.
1114 * configure.ac: Remove check for strerror_r.
1115 * gdbsupport/common.m4: Check for strerror_r.
1116
bd5766ec
LM
11172019-11-01 Luis Machado <luis.machado@linaro.org>
1118
1119 PR gdb/25124
1120
1121 * arm-tdep.c (arm_per_objfile): Rename to ...
1122 (arm_per_bfd): ... this.
1123 (arm_objfile_data_key): Rename to ...
1124 (arm_bfd_data_key): ... this.
1125 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1126 data.
1127 (arm_record_special_symbol): Likewise.
1128
e1709896
AB
11292019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1130
1131 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1132 end.
1133 * c-typeprint.c (c_print_typedef): Likewise.
1134 * f-typeprint.c (f_print_typedef): Likewise.
1135 * m2-typeprint.c (m2_print_typedef): Likewise.
1136 * p-typeprint.c (pascal_print_typedef): Likewise.
1137 * rust-lang.c (rust_print_typedef): Likewise.
1138 * symtab.c (print_symbol_info): Print a newline after calling
1139 typedef_print.
1140
165f8965
AB
11412019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1142
1143 * symtab.c (info_module_cmdlist): New variable.
1144 (info_module_command): New function.
1145 (search_module_symbols): New function.
1146 (info_module_subcommand): New function.
1147 (struct info_modules_var_func_options): New struct.
1148 (info_modules_var_func_options_defs): New variable.
1149 (make_info_modules_var_func_options_def_group): New function.
1150 (info_module_functions_command): New function.
1151 (info_module_variables_command): New function.
1152 (info_module_var_func_command_completer): New function.
1153 (_initialize_symtab): Register new 'info module functions' and
1154 'info module variables' commands.
1155 * symtab.h (typedef symbol_search_in_module): New typedef.
1156 (search_module_symbols): Declare new function.
1157 * NEWS: Mention new commands.
1158
59c35742
AB
11592019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1160
1161 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1162 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1163 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1164 MODULES_DOMAIN.
1165 (scan_partial_symbols): Only create partial module symbols for non
1166 declarations.
1167 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1168 and MODULES_DOMAIN.
1169 * symtab.c (search_domain_name): Likewise.
1170 (search_symbols): Likewise.
1171 (print_symbol_info): Likewise.
1172 (symtab_symbol_info): Likewise.
1173 (info_modules_command): New function.
1174 (_initialize_symtab): Register 'info modules' command.
1175 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1176 * NEWS: Mention new 'info modules' command.
1177
aed61d02
PW
11782019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1179
1180 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1181 and $_gdb_maint_setting_str.
1182
9ad9b77d
PW
11832019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1184
1185 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1186 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1187 (str_value_from_setting, gdb_setting_str_internal_fn)
1188 (gdb_maint_setting_str_internal_fn): New functions.
1189 (_initialize_cli_cmds): Define the new convenience functions.
1190 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1191 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1192
8d6efaa2
CB
11932019-10-31 Christian Biesinger <cbiesinger@google.com>
1194
1195 * agent.c (set_can_use_agent): When the setting is turned on,
1196 look up agent symbols if we don't have them yet.
1197 (agent_new_objfile): Don't look up agent symbols when the agent
1198 setting is off.
1199
33cb1647
CB
12002019-10-31 Christian Biesinger <cbiesinger@google.com>
1201
1202 * config.in: Regenerate.
1203
b231e86a
CB
12042019-10-31 Christian Biesinger <cbiesinger@google.com>
1205
1206 * configure: Regenerate.
1207 * configure.ac: Check for strerror_r.
1208 * gdbsupport/common-utils.h (safe_strerror): Change return value
1209 to const char * and document that this function is now threadsafe.
1210 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1211 thread_local and call strerror_r, if available.
1212 * utils.c (perror_string): Update.
1213 (print_sys_errmsg): Update.
1214
a2726d4f
LM
12152019-10-31 Luis Machado <luis.machado@linaro.org>
1216
1217 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1218 objfile_key.
1219 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1220 objfile to fetch per-bfd data.
1221 (arm_find_exidx_entry): Likewise.
1222
75cafaa6
CB
12232019-10-31 Christian Biesinger <cbiesinger@google.com>
1224
1225 * gdbsupport/agent.c (debug_agent): Change type to bool.
1226 (use_agent): Likewise.
1227 (all_agent_symbols_look_up): Likewise.
1228 (agent_loaded_p): Change return value to bool.
1229 (agent_look_up_symbols): Update.
1230 (agent_capability_check): Change return value to bool.
1231 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1232 (debug_agent): Change type to bool.
1233 (use_agent): Likewise.
1234 (agent_capability_check): Change return value to bool.
1235
808590ec
CB
12362019-10-30 Christian Biesinger <cbiesinger@google.com>
1237
1238 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1239 (build_minimal_symbol_hash_tables): Code to clear the table moved
1240 to clear_minimal_symbol_hash_tables.
1241 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1242 when needed.
1243
f18ad8a1
SM
12442019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1245
1246 * infcmd.c: Remove includes.
1247 * infrun.c: Remove includes.
1248
de93309a
SM
12492019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1250
1251 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1252 (grow_vect): Remove declaration.
1253 (ada_type_of_array): Remove declaration.
1254 (ada_update_initial_language): Remove declaration.
1255 (ada_fold_name): Remove declaration.
1256 (ada_fill_in_ada_prototype): Remove declaration.
1257 (user_select_syms): Remove declaration.
1258 (get_selections): Remove declaration.
1259 (ada_tag_type): Remove declaration.
1260 (ada_value_tag): Remove declaration.
1261 (ada_is_others_clause): Remove declaration.
1262 (ada_in_variant): Remove declaration.
1263 (ada_value_struct_elt): Remove declaration.
1264 (ada_attribute_name): Remove declaration.
1265 (ada_system_address_type): Remove declaration.
1266 * ada-lang.c (ada_watch_location_expression): Make static.
1267 (GROW_VECT): Move here from ada-lang.h.
1268 (grow_vect): Make static.
1269 (ada_update_initial_language): Make static.
1270 (ada_fold_name): Make static.
1271 (ada_type_of_array): Make static.
1272 (encoded_ordered_before): Move up.
1273 (sort_choices): Move up.
1274 (print_signatures): Move up.
1275 (ada_print_symbol_signature): Move up.
1276 (get_selections): Move up and make static.
1277 (user_select_syms): Move up and make static.
1278 (ada_value_struct_elt): Move up and make static.
1279 (ada_tag_type): Make static.
1280 (ada_value_tag): Make static.
1281 (ada_is_others_clause): Make static.
1282 (ada_in_variant): Make static.
1283 (ada_attribute_name): Make static.
1284
cdc46a9f
SM
12852019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1286
1287 * ada-lang.c: Remove includes.
1288 * ada-typeprint.c: Remove includes.
1289 * ada-valprint.c: Remove includes.
1290
90421c56
SM
12912019-10-29 Simon Marchi <simon.marchi@efficios.com>
1292
1293 * addrmap.c: Add static assertions of type size, moved from
1294 _initialize_addrmap.
1295 (_initialize_addrmap): Remove.
1296
31edb802
CB
12972019-10-29 Christian Biesinger <cbiesinger@google.com>
1298
1299 * coffread.c (record_minimal_symbol): Update.
1300 (process_coff_symbol): Update.
1301 * dbxread.c (read_dbx_symtab): Update.
1302 * dwarf2read.c (add_partial_symbol): Update.
1303 (fixup_go_packaging): Update.
1304 (load_partial_dies): Update.
1305 (new_symbol): Update.
1306 * elfread.c (record_minimal_symbol): Change signature to use
1307 gdb::string_view instead of name+len.
1308 (elf_symtab_read): Update.
1309 (elf_rel_plt_read): Update.
1310 * mdebugread.c (parse_partial_symbols): Update.
1311 (handle_psymbol_enumerators): Update.
1312 (new_symbol): Update.
1313 * minsyms.c (minimal_symbol_reader::record_full): Change signature
1314 to use gdb::string_view instead of name+len.
1315 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1316 * psympriv.h (add_psymbol_to_list): Likewise.
1317 * psymtab.c (add_psymbol_to_bcache): Likewise.
1318 (add_psymbol_to_list): Likewise.
1319 * stabsread.c (define_symbol): Update.
1320 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1321 * symtab.h (SYMBOL_SET_NAMES): Likewise.
1322 (symbol_set_names): Likewise.
1323 * xcoffread.c (scan_xcoff_symtab): Update.
1324
0c921b21
CB
13252019-10-29 Christian Biesinger <cbiesinger@google.com>
1326
1327 * symtab.h (symbol_set_names): Document that copy_name must be
1328 set to true for non-nullterminated strings.
1329 * symtab.c (symbol_set_names): Only make a nullterminated copy of
1330 linkage_name if the entry was not found and we need to demangle.
1331
35e65c49
CB
13322019-10-29 Christian Biesinger <cbiesinger@google.com>
1333
1334 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1335 * dwarf2-frame.c (bsearch_fde_cmp): Update.
1336 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1337 * gdbsupport/gdb_binary_search.h: New file.
1338
ed2a2229
CB
13392019-10-29 Christian Biesinger <cbiesinger@google.com>
1340
1341 * NEWS: Mention new --with-system-gdbinit-dir option.
1342 * config.in: Regenerate.
1343 * configure: Regenerate.
1344 * configure.ac: Add new option --with-system-gdbinit-dir.
1345 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1346 for a ".gdb" suffix.
1347 * main.c (get_init_files): Change system_gdbinit argument to
1348 a vector and return the files in SYSTEM_GDBINIT_DIR in
1349 addition to SYSTEM_GDBINIT.
1350 (captured_main_1): Update.
1351 (print_gdb_help): Update.
1352 * top.c (print_gdb_configuration): Also print the value of
1353 SYSTEM_GDBINIT_DIR.
1354
87f34879
CB
13552019-10-28 Christian Biesinger <cbiesinger@google.com>
1356
1357 * gdbsupport/common-utils.h (startswith): Add an overloaded version
1358 that takes gdb::string_view arguments.
1359
30baf67b
TV
13602019-10-26 Tom de Vries <tdevries@suse.de>
1361
1362 * aarch64-linux-tdep.c: Fix typos in comments.
1363 * aarch64-tdep.c: Same.
1364 * ada-lang.c: Same.
1365 * amd64-nat.c: Same.
1366 * arc-tdep.c: Same.
1367 * arch/aarch64-insn.c: Same.
1368 * block.c: Same.
1369 * breakpoint.h: Same.
1370 * btrace.h: Same.
1371 * c-varobj.c: Same.
1372 * cli/cli-decode.c: Same.
1373 * cli/cli-script.c: Same.
1374 * cli/cli-utils.h: Same.
1375 * coff-pe-read.c: Same.
1376 * coffread.c: Same.
1377 * compile/compile-cplus-symbols.c: Same.
1378 * compile/compile-object-run.c: Same.
1379 * completer.c: Same.
1380 * corelow.c: Same.
1381 * cp-support.c: Same.
1382 * demangle.c: Same.
1383 * dwarf-index-write.c: Same.
1384 * dwarf2-frame.c: Same.
1385 * dwarf2-frame.h: Same.
1386 * eval.c: Same.
1387 * frame-base.h: Same.
1388 * frame.h: Same.
1389 * gdbcmd.h: Same.
1390 * gdbtypes.h: Same.
1391 * gnu-nat.c: Same.
1392 * guile/scm-objfile.c: Same.
1393 * i386-tdep.c: Same.
1394 * i386-tdep.h: Same.
1395 * infcall.c: Same.
1396 * infcall.h: Same.
1397 * linux-nat.c: Same.
1398 * m68k-tdep.c: Same.
1399 * macroexp.c: Same.
1400 * memattr.c: Same.
1401 * mi/mi-cmd-disas.c: Same.
1402 * mi/mi-getopt.h: Same.
1403 * mi/mi-main.c: Same.
1404 * minsyms.c: Same.
1405 * nat/aarch64-sve-linux-sigcontext.h: Same.
1406 * objfiles.h: Same.
1407 * ppc-linux-nat.c: Same.
1408 * ppc-linux-tdep.c: Same.
1409 * ppc-tdep.h: Same.
1410 * progspace.h: Same.
1411 * prologue-value.h: Same.
1412 * python/py-evtregistry.c: Same.
1413 * python/py-instruction.h: Same.
1414 * record-btrace.c: Same.
1415 * record-full.c: Same.
1416 * remote.c: Same.
1417 * rs6000-tdep.c: Same.
1418 * ser-tcp.c: Same.
1419 * sol-thread.c: Same.
1420 * sparc-sol2-tdep.c: Same.
1421 * sparc64-tdep.c: Same.
1422 * stabsread.c: Same.
1423 * symfile.c: Same.
1424 * symtab.h: Same.
1425 * target.c: Same.
1426 * tracepoint.c: Same.
1427 * tui/tui-data.h: Same.
1428 * tui/tui-io.c: Same.
1429 * tui/tui-win.c: Same.
1430 * tui/tui.c: Same.
1431 * unittests/rsp-low-selftests.c: Same.
1432 * user-regs.h: Same.
1433 * utils.c: Same.
1434 * utils.h: Same.
1435 * valarith.c: Same.
1436 * valops.c: Same.
1437 * valprint.c: Same.
1438 * valprint.h: Same.
1439 * value.c: Same.
1440 * value.h: Same.
1441 * varobj.c: Same.
1442 * x86-nat.h: Same.
1443 * xtensa-tdep.c: Same.
1444
1834d45f
AT
14452019-10-25 Ali Tamur <tamur@google.com>
1446
1447 * charset.c (find_charset_names): Reflect API change.
1448
5396ae17
CB
14492019-10-25 Christian Biesinger <cbiesinger@google.com>
1450
1451 * symtab.c (struct demangled_name_entry): Change demangled name
1452 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1453 part of the struct anymore.
1454 (symbol_set_names): No longer obstack allocate + copy the demangled
1455 name, just store the allocated name from bfd.
1456
93878f47
TT
14572019-10-25 Tom Tromey <tromey@adacore.com>
1458
1459 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1460 (bsearch_cie_cmp, add_cie): Remove.
1461 (find_cie): Reimplement.
1462 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
1463 (dwarf2_build_frame_info): Update.
1464
7b71fc97
L
14652019-10-24 H.J. Lu <hongjiu.lu@intel.com>
1466
1467 PR gdb/25126
1468 * symfile.c (reread_symbols): Call forget_cached_source_info to
1469 clear the stale source cache.
1470
cbb5a2ea
CB
14712019-10-24 Christian Biesinger <cbiesinger@google.com>
1472
1473 * configure: Regenerate.
1474 * configure.ac: Remove code that sets python_has_threads.
1475
71737c43
CB
14762019-10-24 Christian Biesinger <cbiesinger@google.com>
1477
1478 * config.in: Regenerate.
1479 * configure: Regenerate.
1480 * configure.ac: Remove the code that uses sed to get the python
1481 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1482
33d569b7
AB
14832019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
1484
1485 * python/py-progspace.c (pspy_block_for_pc): Return None for all
1486 error paths.
1487
f16f7b7c
TT
14882019-10-23 Tom Tromey <tom@tromey.com>
1489
1490 * arc-tdep.c: Remove ".." from include.
1491 * frv-tdep.c: Remove ".." from include.
1492 * lm32-tdep.c: Remove ".." from include.
1493 * microblaze-tdep.c: Remove ".." from include.
1494 * or1k-tdep.h: Remove ".." from include.
1495 * s12z-tdep.c: Remove ".." from include.
1496 * Makefile.in (OPCODES_CFLAGS): Add comment.
1497 (TOP_CFLAGS): New variable.
1498 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1499
6999161a
TT
15002019-10-23 Tom Tromey <tom@tromey.com>
1501
1502 * Makefile.in (READLINE_DIR): Update.
1503
12e7c35e
TBA
15042019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1505
1506 * infcall.c (call_function_by_hand_dummy): Fix the function
1507 comment. And extract out a code section into...
1508 (reserve_stack_space): ...this new function.
1509
37055cad
TBA
15102019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1511
1512 * infcall.c (value_arg_coerce): Remove an unused parameter.
1513 (call_function_by_hand_dummy): Update the call to
1514 'value_arg_coerce'.
1515
39bcc47c
TBA
15162019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1517
1518 * infcall.c (call_function_by_hand_dummy): Refactor.
1519
bd888c0f
TBA
15202019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1521
1522 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1523
c12d372d
TT
15242019-10-23 Tom Tromey <tom@tromey.com>
1525
1526 * configure: Rebuild.
1527 * configure.ac: Don't check for sigprocmask.
1528 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1529
4d0b984b
TT
15302019-10-23 Tom Tromey <tom@tromey.com>
1531
1532 * configure: Rebuild.
1533 * acinclude.m4: Use m4_include, not sinclude.
1534
7e785608
TV
15352019-10-23 Tom de Vries <tdevries@suse.de>
1536
1537 PR breakpoints/24687
1538 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1539
403772ef
CB
15402019-10-22 Christian Biesinger <cbiesinger@google.com>
1541
1542 * symtab.c (struct demangled_name_entry) <language>: Change from
1543 bitfield to regular variable.
1544
3a494279
CB
15452019-10-22 Christian Biesinger <cbiesinger@google.com>
1546
1547 * symtab.c (struct demangled_name_entry): Add a constructor.
1548 (free_demangled_name_entry): New function to call the destructor
1549 for demangled_name_entry.
1550 (create_demangled_names_hash): Pass free_demangled_name_entry to
1551 htab_create_alloc.
1552 (symbol_set_names): Call placement new for demangled_name_entry.
1553 * utils.c: No longer include xxhash.h here, now that fast_hash
1554 is inlined in the header.
1555 * utils.h: Instead, include it here.
1556
ccb1ba62
CB
15572019-10-22 Christian Biesinger <cbiesinger@google.com>
1558
1559 * Makefile.in: Link with libxxhash.
1560 * config.in: Regenerate.
1561 * configure: Regenerate.
1562 * configure.ac: Search for libxxhash.
1563 * utils.c (fast_hash): Use xxhash if present.
1564
1a6ff1a9
CB
15652019-10-22 Christian Biesinger <cbiesinger@google.com>
1566
1567 * utils.h (fast_hash): New function.
1568 * symtab.c (hash_demangled_name_entry): Call new function
1569 fast_hash.
1570
7bb43059
CB
15712019-10-22 Christian Biesinger <cbiesinger@google.com>
1572
1573 * symtab.c (struct demangled_name_entry): Change type of mangled
1574 to gdb::string_view. Also adds a constructor that takes the
1575 mangled name.
1576 (hash_demangled_name_entry): Update.
1577 (eq_demangled_name_entry): Update.
1578 (free_demangled_name_entry): New function to call the destructor
1579 now that this is not a POD anymore.
1580 (create_demangled_names_hash): Pass free_demangled_name_entry to
1581 htab_create_alloc.
1582 (symbol_set_names): Update.
1583
7ba99d21
AT
15842019-10-21 Ali Tamur <tamu@google.com>
1585
1586 * dwarf2read.c (dir_index): Change type.
1587 (file_name_index): Likewise.
1588 (line_header::include_dir_at): Change comment and implementation on
1589 whether it is DWARF 5.
1590 (line_header::is_valid_file_index): New function.
1591 (line_header::file_name_at): Change comment and implementation on
1592 whether it is DWARF 5.
1593 (line_header::file_names): Change to private field renamed as
1594 m_file_names and introduce a new accessor method.
1595 (line_header::file_names_size): New method.
1596 (line_header::include_dirs): Change to private field and rename as
1597 m_include_dirs.
1598 (dw2_get_file_names_reader): Define local var at a smaller scope and
1599 reflect API change.
1600 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1601 (process_structure_scope): Likewise.
1602 (line_header::add_include_dir): Change message and reflect renaming.
1603 (line_header::add_file_name): Likewise.
1604 (read_formatted_entries): Handle DW_FORM_data16.
1605 (dwarf_decode_line_header): Fix line header length calculation.
1606 (psymtab_include_file_name): Change comment and API.
1607 (lnp_state_machine::m_file): Update comment and reflect type change.
1608 (lnp_state_machine::record_line): Reflect type change.
1609 (dwarf_decode_lines): Reflect API change.
1610 (file_file_name): Likewise.
1611 (file_full_name): Likewise.
1612
45f47c3a
AB
16132019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
1614
1615 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1616
e5f3c0e3
TT
16172019-10-21 Tom Tromey <tom@tromey.com>
1618
1619 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1620
a0a461e5
TT
16212019-10-21 Tom Tromey <tom@tromey.com>
1622
1623 * configure.ac (nm.h): Conditionally create nm.h link. Subst
1624 NM_H. Use AC_CONFIG_LINKS.
1625 * configure: Rebuild.
1626 * Makefile.in (NM_H): New variable.
1627 (generated_files): Add NM_H. Remove gcore.
1628 (nm.h, stamp-nmh): New targets.
1629
54d83b8d
TT
16302019-10-20 Tom Tromey <tom@tromey.com>
1631
1632 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1633 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
1634 obsolete comment.
1635 (put_objfile_before): Now static.
1636
23771117
SM
16372019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
1638
1639 * gdbsupport/common-utils.h (startswith): Change return type to
1640 bool.
1641
39ef2f62
CB
16422019-10-19 Christian Biesinger <cbiesinger@google.com>
1643
1644 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1645 * breakpoint.c (bp_locations_compare): Rename to...
1646 (bp_location_is_less_than): ...this, and change to std::sort semantics.
1647 (update_global_location_list): Use std::sort instead of qsort.
1648 * buildsym.c (compare_line_numbers): Rename to...
1649 (lte_is_less_than): ...this, and change to std::sort semantics.
1650 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1651 instead of qsort.
1652 * disasm.c (compare_lines): Rename to...
1653 (line_is_less_than): ...this, and change to std::sort semantics.
1654 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1655 of qsort.
1656 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1657 (fde_is_less_than): ...this, and change to std::sort semantics.
1658 (dwarf2_build_frame_info): Call std::sort instead of qsort.
1659 * mdebugread.c (compare_blocks):
1660 (block_is_less_than): ...this, and change to std::sort semantics.
1661 (sort_blocks): Call std::sort instead of qsort.
1662 * objfiles.c (qsort_cmp): Rename to...
1663 (sort_cmp): ...this, and change to std::sort semantics.
1664 (update_section_map): Call std::sort instead of qsort.
1665 * remote.c (compare_pnums): Remove.
1666 (map_regcache_remote_table): Call std::sort instead of qsort.
1667 * utils.c (compare_positive_ints): Remove.
1668 * utils.h (compare_positive_ints): Remove.
1669 * xcoffread.c (compare_lte): Remove.
1670 (arrange_linetable): Call std::sort instead of qsort.
1671
f71433ee
SDJ
16722019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
1673
1674 * symfile.c (init_entry_point_info): Fix typo.
1675 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1676
85102364
TV
16772019-10-18 Tom de Vries <tdevries@suse.de>
1678
1679 * aarch64-tdep.c: Fix typos in comments.
1680 * ada-lang.c: Same.
1681 * ada-tasks.c: Same.
1682 * alpha-tdep.c: Same.
1683 * alpha-tdep.h: Same.
1684 * amd64-nat.c: Same.
1685 * amd64-windows-tdep.c: Same.
1686 * arc-tdep.c: Same.
1687 * arc-tdep.h: Same.
1688 * arch-utils.c: Same.
1689 * arm-nbsd-tdep.c: Same.
1690 * arm-tdep.c: Same.
1691 * ax-gdb.c: Same.
1692 * blockframe.c: Same.
1693 * btrace.c: Same.
1694 * c-varobj.c: Same.
1695 * coff-pe-read.c: Same.
1696 * coffread.c: Same.
1697 * cris-tdep.c: Same.
1698 * darwin-nat.c: Same.
1699 * dbxread.c: Same.
1700 * dcache.c: Same.
1701 * disasm.c: Same.
1702 * dtrace-probe.c: Same.
1703 * dwarf-index-write.c: Same.
1704 * dwarf2-frame-tailcall.c: Same.
1705 * dwarf2-frame.c: Same.
1706 * dwarf2read.c: Same.
1707 * eval.c: Same.
1708 * exceptions.c: Same.
1709 * fbsd-tdep.c: Same.
1710 * findvar.c: Same.
1711 * frame.c: Same.
1712 * frv-tdep.c: Same.
1713 * gnu-v3-abi.c: Same.
1714 * go32-nat.c: Same.
1715 * h8300-tdep.c: Same.
1716 * hppa-tdep.c: Same.
1717 * i386-linux-tdep.c: Same.
1718 * i386-tdep.c: Same.
1719 * ia64-libunwind-tdep.c: Same.
1720 * ia64-tdep.c: Same.
1721 * infcmd.c: Same.
1722 * infrun.c: Same.
1723 * linespec.c: Same.
1724 * linux-nat.c: Same.
1725 * linux-thread-db.c: Same.
1726 * machoread.c: Same.
1727 * mdebugread.c: Same.
1728 * mep-tdep.c: Same.
1729 * mn10300-tdep.c: Same.
1730 * namespace.c: Same.
1731 * objfiles.c: Same.
1732 * opencl-lang.c: Same.
1733 * or1k-tdep.c: Same.
1734 * osabi.c: Same.
1735 * ppc-linux-nat.c: Same.
1736 * ppc-linux-tdep.c: Same.
1737 * ppc-sysv-tdep.c: Same.
1738 * printcmd.c: Same.
1739 * procfs.c: Same.
1740 * record-btrace.c: Same.
1741 * record-full.c: Same.
1742 * remote-fileio.c: Same.
1743 * remote.c: Same.
1744 * rs6000-tdep.c: Same.
1745 * s12z-tdep.c: Same.
1746 * score-tdep.c: Same.
1747 * ser-base.c: Same.
1748 * ser-go32.c: Same.
1749 * skip.c: Same.
1750 * sol-thread.c: Same.
1751 * solib-svr4.c: Same.
1752 * solib.c: Same.
1753 * source.c: Same.
1754 * sparc-nat.c: Same.
1755 * sparc-sol2-tdep.c: Same.
1756 * sparc-tdep.c: Same.
1757 * sparc64-tdep.c: Same.
1758 * stabsread.c: Same.
1759 * stack.c: Same.
1760 * symfile.c: Same.
1761 * symtab.c: Same.
1762 * target-descriptions.c: Same.
1763 * target-float.c: Same.
1764 * thread.c: Same.
1765 * utils.c: Same.
1766 * valops.c: Same.
1767 * valprint.c: Same.
1768 * value.c: Same.
1769 * varobj.c: Same.
1770 * windows-nat.c: Same.
1771 * xcoffread.c: Same.
1772 * xstormy16-tdep.c: Same.
1773 * xtensa-tdep.c: Same.
1774
c5adaa19
TT
17752019-10-17 Tom Tromey <tromey@adacore.com>
1776
1777 * configure: Rebuild.
1778 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
1779 in AC_CONFIG_FILES invocation.
1780 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1781 new-style config.status invocation.
1782
405feb71
TV
17832019-10-17 Tom de Vries <tdevries@suse.de>
1784
1785 * arm-nbsd-nat.c: Fix typos in comments.
1786 * arm-tdep.c: Same.
1787 * darwin-nat-info.c: Same.
1788 * dwarf2read.c: Same.
1789 * elfread.c: Same.
1790 * event-top.c: Same.
1791 * findvar.c: Same.
1792 * gdbtypes.c: Same.
1793 * hppa-tdep.c: Same.
1794 * i386-tdep.c: Same.
1795 * jit.c: Same.
1796 * main.c: Same.
1797 * mdebugread.c: Same.
1798 * moxie-tdep.c: Same.
1799 * nto-procfs.c: Same.
1800 * osabi.c: Same.
1801 * ppc-linux-tdep.c: Same.
1802 * remote.c: Same.
1803 * riscv-tdep.c: Same.
1804 * s390-tdep.c: Same.
1805 * sh-tdep.c: Same.
1806 * sparc-linux-tdep.c: Same.
1807 * sparc-nat.c: Same.
1808 * stack.c: Same.
1809 * target-descriptions.c: Same.
1810 * top.c: Same.
1811 * varobj.c: Same.
1812
befcd486
TT
18132019-10-16 Tom Tromey <tom@tromey.com>
1814
1815 * objfiles.h (struct objfile) <original_name>: Now const.
1816
17bfe554
CB
18172019-10-16 Christian Biesinger <cbiesinger@google.com>
1818
1819 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1820 pass on to sigsetjmp's second argument.
1821 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1822
950b7495
KS
18232019-10-16 Keith Seitz <keiths@redhat.com>
1824
1825 PR gdb/23567
1826 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1827 sections whose size is greater than the file size.
1828
ff371ec9
JW
18292019-10-16 Jim Wilson <jimw@sifive.com>
1830
1831 * riscv-tdep.c (riscv_gcc_target_options): New.
1832 (riscv_gnu_triplet_regexp): New.
1833 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1834 set_gdbarch_gnu_triplet_regexp.
1835
fec4e896
CB
18362019-10-16 Christian Biesinger <cbiesinger@google.com>
1837
1838 * Makefile.in: Add xml-builtin.h.
1839 * features/feature_to_c.sh: Add an include for xml-builtin.h
1840 to ensure that the compiler checks that the types match.
1841 * xml-builtin.h: New file.
1842 * xml-support.c (fetch_xml_builtin): Add missing const.
1843 * xml-support.h: Remove declaration of xml_builtins.
1844
d10eccaa
TV
18452019-10-16 Tom de Vries <tdevries@suse.de>
1846
1847 PR tdep/25096
1848 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1849 (amd64_classify_aggregate): ... here.
1850 (amd64_classify_aggregate_field): Handled fiels of nested structs
1851 recursively.
1852
745ff14e
TV
18532019-10-16 Tom de Vries <tdevries@suse.de>
1854
1855 PR tdep/24104
1856 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1857 that handles 'theclass'.
1858
791b7405
AB
18592019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
1860
1861 * linespec.c (decode_digits_ordinary): Update comment.
1862 * make-target-delegates: No longer need to handle VEC case.
1863 * memrange.c (normalize_mem_ranges): Update comment.
1864 * namespace.c (add_using_directive): Update comment.
1865 * objc-lang.c (uniquify_strings): Update comment.
1866 * ppc-linux-nat.c (struct thread_points): Update comment.
1867 * probe.h (find_probes_in_objfile): Update comment.
1868 * target.h (enum flash_preserve_mode): Update comment.
1869 * varobj.c (varobj_restrict_range): Update comment.
1870 * varobj.h (varobj_list_children): Update comment.
1871
0dc32745
AB
18722019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
1873
1874 * Makefile.in: Remove references to vec.h and vec.c.
1875 * aarch64-tdep.c: No longer include vec.h.
1876 * ada-lang.c: Likewise.
1877 * ada-lang.h: Likewise.
1878 * arm-tdep.c: Likewise.
1879 * ax.h: Likewise.
1880 * breakpoint.h: Likewise.
1881 * charset.c: Likewise.
1882 * cp-support.h: Likewise.
1883 * dtrace-probe.c: Likewise.
1884 * dwarf2read.c: Likewise.
1885 * extension.h: Likewise.
1886 * gdb_bfd.c: Likewise.
1887 * gdbsupport/gdb_vecs.h: Likewise.
1888 * gdbsupport/vec.c: Remove.
1889 * gdbsupport/vec.h: Remove.
1890 * gdbthread.h: Likewise.
1891 * guile/scm-type.c: Likewise.
1892 * inline-frame.c: Likewise.
1893 * machoread.c: Likewise.
1894 * memattr.c: Likewise.
1895 * memrange.h: Likewise.
1896 * namespace.h: Likewise.
1897 * nat/linux-btrace.h: Likewise.
1898 * osdata.c: Likewise.
1899 * parser-defs.h: Likewise.
1900 * progspace.h: Likewise.
1901 * python/py-type.c: Likewise.
1902 * record-btrace.c: Likewise.
1903 * rust-exp.y: Likewise.
1904 * solib-target.c: Likewise.
1905 * stap-probe.c: Likewise.
1906 * target-descriptions.c: Likewise.
1907 * target-memory.c: Likewise.
1908 * target.h: Likewise.
1909 * varobj.c: Likewise.
1910 * varobj.h: Likewise.
1911 * xml-support.h: Likewise.
1912
ae640021
AB
19132019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
1914
1915 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1916 Update for new std::vector based implementation.
1917 (process_psymtab_comp_unit_reader): Likewise.
1918 (scan_partial_symbols): Likewise.
1919 (recursively_compute_inclusions): Likewise.
1920 (compute_compunit_symtab_includes): Likewise.
1921 (process_imported_unit_die): Likewise.
1922 (queue_and_load_dwo_tu): Likewise.
1923 (follow_die_sig_1): Likewise.
1924 * gdb/dwarf2read.h: Remove DEF_VEC_P.
1925 (typedef dwarf2_per_cu_ptr): Remove.
1926 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1927 function.
1928 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1929 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1930 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1931 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1932 std::vector.
1933
55dfc88f
TT
19342019-10-15 Tom Tromey <tromey@adacore.com>
1935
1936 * windows-nat.c (windows_nat_target::resume): Use %x when logging
1937 TID.
1938
96b49c5e
TT
19392019-10-15 Tom Tromey <tromey@adacore.com>
1940
1941 * windows-nat.c (windows_nat_target::fetch_registers)
1942 (windows_nat_target::store_registers): Rename "pid" to "tid".
1943
953cff56
TT
19442019-10-15 Tom Tromey <tromey@adacore.com>
1945
1946 * gdbarch.h, gdbarch.c: Rebuild.
1947 * gdbarch.sh (gcc_target_options): Change return type to
1948 std::string.
1949 * compile/compile.c (get_args): Update.
1950 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1951 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1952 std::string.
1953 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1954 std::string.
1955 * arch-utils.c (default_gcc_target_options): Return std::string.
1956 * arch-utils.h (default_gcc_target_options): Return std::string.
1957 * s390-tdep.c (s390_gcc_target_options): Return std::string.
1958
81e6b8eb
CB
19592019-10-15 Christian Biesinger <cbiesinger@google.com>
1960
1961 * breakpoint.c (breakpoint_chain): Make static.
1962 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1963 of accessing breakpoint_chain.
1964
95da600f
CB
19652019-10-15 Christian Biesinger <cbiesinger@google.com>
1966
1967 * breakpoint.c (iterate_over_breakpoints): Change function pointer
1968 to a gdb::function_view and return value to bool.
1969 * breakpoint.h (iterate_over_breakpoints): Likewise.
1970 * dummy-frame.c (pop_dummy_frame_bpt): Update.
1971 (pop_dummy_frame): Update.
1972 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1973 (gdbscm_breakpoints): Update.
1974 * python/py-breakpoint.c (build_bp_list): Update.
1975 (gdbpy_breakpoints): Update.
1976 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1977 Update.
1978 (bpfinishpy_handle_stop): Update.
1979 (bpfinishpy_handle_exit): Update.
1980 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1981 (svr4_update_solib_event_breakpoints): Update.
1982
ba18312d
AA
19832019-10-15 Andreas Arnez <arnez@linux.ibm.com>
1984
1985 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1986 when unwrapping single-field structs.
1987
6acc1a0b
SM
19882019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
1989
1990 * dwarf2read.c: Remove includes.
1991
284782de
SM
19922019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
1993
1994 * ui-out.c (ui_out::call_do_message): Silence
1995 -Wformat-nonliteral warning.
1996
073bbbb0
SM
19972019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
1998
1999 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2000 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2001 include: readline/tilde.h.
2002
7b9a15e1
CB
20032019-10-12 Christian Biesinger <cbiesinger@google.com>
2004
2005 * remote.c (remote_target::get_trace_status): Remove declaration of
2006 trace_regblock_size.
2007
cc8dee1f
CB
20082019-10-12 Christian Biesinger <cbiesinger@google.com>
2009
2010 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2011 (show_user): Remove declaration of cmdlist.
2012 * cli/cli-cmds.h (max_user_call_depth): Declare.
2013 * cli/cli-script.c (execute_user_command): Remove declaration
2014 of max_user_call_depth.
2015
a83d4ef6
JW
20162019-10-11 Jim Wilson <jimw@sifive.com>
2017
5f93c5a6
JW
2018 * gdbsupport/print-utils.h (pulongest): Fix comment.
2019 (plongest): Likewise.
2020 (phex): Add missing comment, mention leading zeros.
2021 (phex_nz): Add mention of no leading zeros to comment.
2022
a83d4ef6
JW
2023 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2024 plongest instead of unsigned long long cast.
2025
26344e0c
CB
20262019-10-10 Christian Biesinger <cbiesinger@google.com>
2027
2028 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2029 for external_editor_command and gdbtk_test.
2030
c2c440a9
CB
20312019-10-10 Christian Biesinger <cbiesinger@google.com>
2032
2033 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2034 * varobj.c (varobjdebug): Move comment to...
2035 * varobj.h (varobjdebug): ...here, and declare.
2036
a31bff9d
TT
20372019-10-09 Tom Tromey <tom@tromey.com>
2038
2039 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2040 erase_data_content.
2041
7523da63
TT
20422019-10-09 Tom Tromey <tom@tromey.com>
2043
2044 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2045 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2046 * tui/tui-command.c (tui_cmd_window::resize)
2047 (tui_refresh_cmd_win): Update.
2048 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2049 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2050 * tui/tui-data.c (~tui_gen_win_info): Remove.
2051 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2052 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2053 (tui_redisplay_readline, tui_mld_flush)
2054 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2055 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2056 (tui_data_window::erase_data_content)
2057 (tui_data_item_window::rerender)
2058 (tui_data_item_window::refresh_window): Update.
2059 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2060 (box_win, tui_gen_win_info::make_window)
2061 (tui_gen_win_info::make_visible): Update.
2062 (tui_delete_win): Remove.
2063 * tui/tui-winsource.c
2064 (tui_source_window_base::do_erase_source_content): Update.
2065 (tui_show_source_line, tui_source_window_base::update_tab_width)
2066 (tui_source_window_base::update_exec_info): Update.
2067 * tui/tui-data.h (struct curses_deleter): New.
2068 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2069 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2070
a7798e7f
TT
20712019-10-09 Tom Tromey <tom@tromey.com>
2072
2073 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2074
5c45899e
TT
20752019-10-09 Tom Tromey <tom@tromey.com>
2076
2077 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2078 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2079
6d7fd9aa
TT
20802019-10-09 Tom Tromey <tom@tromey.com>
2081
2082 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2083 window height directly.
2084 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2085 declare.
2086 * tui/tui-layout.c (tui_default_win_height): Remove.
2087 (tui_default_win_viewport_height): Remove.
2088
d2dd1084
TT
20892019-10-09 Tom Tromey <tom@tromey.com>
2090
2091 * tui/tui.h: Remove comments.
2092
cff32449
TV
20932019-10-09 Tom de Vries <tdevries@suse.de>
2094
2095 * python/lib/gdb/printer/bound_registers.py: Use
2096 '^builtin_type_bound128' as regexp argument for
2097 add_builtin_pretty_printer.
2098
6a25e8a2
CB
20992019-10-09 Christian Biesinger <cbiesinger@google.com>
2100
2101 * guile/guile.c (guile_extension_script_ops): Remove forward
2102 declaration and mark as static.
2103 (guile_script_ops): Likewise.
2104 (extension_language_guile): Move further down in the file so
2105 it can reference the definitions for guile_{extension_,}script_ops.
2106
6d9d6da4
AA
21072019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2108
2109 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2110 except SORTL, DFLTCC, and KDSA.
2111
3abea05d
TT
21122019-10-08 Tom Tromey <tromey@adacore.com>
2113
2114 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2115 (struct safe_symbol_file_add_args): Remove.
2116
dde996e2
TT
21172019-10-08 Tom Tromey <tromey@adacore.com>
2118
2119 * windows-nat.c: Don't include buildsym-legacy.h.
2120
cd6fdaa1
TT
21212019-10-08 Tom Tromey <tromey@adacore.com>
2122
2123 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2124
79bb1944
CB
21252019-10-08 Christian Biesinger <cbiesinger@google.com>
2126
2127 * gdbtypes.c (overload_debug): Move comment to header.
2128 * gdbtypes.h (overload_debug): Declare.
2129 * valops.c: Remove declaration of overload_debug, instead
2130 include gdbtypes.h.
2131
34916edc
CB
21322019-10-08 Christian Biesinger <cbiesinger@google.com>
2133
2134 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2135 through _().
2136 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2137 move comment...
2138 * language.h (lang_frame_mismatch_warn): ... here. Also add
2139 declaration.
2140 * top.c (lang_frame_mismatch_warn): Remove declaration.
2141 (check_frame_language_change): Pass lang_frame_mismatch_warn
2142 through _().
2143
bad5c026
CB
21442019-10-07 Christian Biesinger <cbiesinger@google.com>
2145
2146 * c-lang.h (vtbl_ptr_name): Declare.
2147 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2148 it from the header.
2149 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2150
51f1fdc3
CB
21512019-10-07 Christian Biesinger <cbiesinger@google.com>
2152
2153 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2154 gdb_static_assert.
2155
30d1f018
WP
21562019-10-07 Weimin Pan <weimin.pan@oracle.com>
2157
606813d5
WP
2158 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2159 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
2160 * ctfread.c: New file.
2161 * ctfread.h: New file.
2162 * elfread.c: Include ctfread.h.
2163 (struct elfinfo text_p): New member ctfsect.
2164 (elf_locate_sections): Mark CTF section.
2165 (elf_symfile_read): Call elfctf_build_psymtabs.
2166 * Makefile.in (LIBCTF): Add.
2167 (CLIBS): Use it.
2168 (CDEPS): Likewise.
2169 (DIST): Add ctfread.c.
606813d5
WP
2170
21712019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2172
2173 * ctfread.c (struct nextfield): Renamed to ...
2174 (struct ctf_nextfield): ... this.
2175 (struct field_info): Renamed to ...
2176 (strut ctf_field_info): ... this.
2177 (attach_fields_to_type): Update for renamed structures.
2178 (ctf_add_member_cb): Likewise.
2179 (ctf_add_enum_member_cb): Likewise.
2180 (process_struct_members): Likewise.
2181 (process_enum_type): Likewise.
30d1f018 2182
518fe38c
WP
21832019-10-07 Weimin Pan <weimin.pan@oracle.com>
2184
2185 * tracectf.h: Rename, was ctf.h.
2186 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2187 * tracefile.c: Likewise.
2188 * tracepoint.c: Remove unused include ctf.h.
2189 * mi/mi-main.c: Likewise.
2190 * Makefile.in Replace ctf.c with tracectf.c.
2191
225f296a
JB
21922019-10-06 Joel Brobecker <brobecker@adacore.com>
2193
2194 * version.in: Change version number to "9.0.50.DATE-git".
2195
77c2dba3
TT
21962019-10-03 Tom Tromey <tom@tromey.com>
2197
2198 PR rust/24976:
2199 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2200
179aed7f
AB
22012019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2202
2203 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2204 cp_search_name_hash.
2205 * NEWS: Add entry about nested function support.
2206
0a4b0913
AB
22072019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2208 Andrew Burgess <andrew.burgess@embecosm.com>
2209
2210 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2211 for nested static variables when searchin VAR_DOMAIN.
2212 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2213 global scope, update comment.
2214 (add_partial_subprogram): Call add_partial_subprogram recursively
2215 for nested subroutines when processinng Fortran.
2216 (load_partial_dies): Process the child entities of a subprogram
2217 when processing Fortran.
2218 (partial_die_parent_scope): Handle building scope
2219 for Fortran nested functions.
2220 (process_die): Record that nested functions have a scope.
2221 (new_symbol): Always record Fortran subprograms on the global
2222 symbol list.
2223 (determine_prefix): How to build the prefix for Fortran
2224 subprograms.
2225
d8c06f22
AB
22262019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2227
2228 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2229 have just sent the thread a SIGSTOP and are waiting for it to
2230 arrive.
2231
a8b3b8e9
AB
22322019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2233
2234 * btrace.c (btrace_add_pc): Remove whitespace before the template
2235 parameter in 'std::vector <...>'.
2236 (parse_xml_btrace_block): Likewise.
2237 (btrace_maint_decode_pt): Likewise.
2238 (btrace_maint_update_packets): Likewise.
2239 (btrace_maint_print_packets): Likewise.
2240 * btrace.h (struct btrace_maint_info): Likewise.
2241 * dwarf2read.c (struct type_unit_group): Likewise.
2242 (build_type_psymtabs_reader): Likewise.
2243 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2244 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2245 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2246
4d825eab
TV
22472019-10-03 Tom de Vries <tdevries@suse.de>
2248
2249 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2250 the first line of the help text for set/show style metadata.
2251
80fd2826
TT
22522019-10-02 Tom Tromey <tromey@adacore.com>
2253
2254 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2255 * gdbsupport/common-inferior.c: New file.
2256 * infcmd.c (startup_with_shell): Don't define.
2257 * nat/fork-inferior.h (startup_with_shell): Don't declare.
2258 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2259 * inferior.h (startup_with_shell): Don't declare.
2260
70054538
CB
22612019-10-02 Christian Biesinger <cbiesinger@google.com>
2262
2263 * gdbsupport/gdb_assert.h: Include errors.h.
2264 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2265
37f6a7f4
TT
22662019-10-02 Tom Tromey <tromey@adacore.com>
2267
2268 * NEWS: Add $_ada_exception entry.
2269 * ada-lang.c (struct ada_catchpoint): Add constructor.
2270 <m_kind>: New member.
2271 (allocate_location_exception, re_set_exception): Remove
2272 "ex" parameter.
2273 (should_stop_exception): Compute $_ada_exception.
2274 (check_status_exception, print_it_exception)
2275 (print_one_exception, print_mention_exception): Remove
2276 "ex" parameter.
2277 (allocate_location_catch_exception, re_set_catch_exception)
2278 (check_status_exception, print_it_catch_exception)
2279 (print_one_catch_exception, print_mention_catch_exception)
2280 (print_recreate_catch_exception)
2281 (allocate_location_catch_exception_unhandled)
2282 (re_set_catch_exception_unhandled)
2283 (check_status_exception, print_it_catch_exception_unhandled)
2284 (print_one_catch_exception_unhandled)
2285 (print_mention_catch_exception_unhandled)
2286 (print_recreate_catch_exception_unhandled)
2287 (allocate_location_catch_assert, re_set_catch_assert)
2288 (check_status_assert, print_it_catch_assert)
2289 (print_one_catch_assert, print_mention_catch_assert)
2290 (print_recreate_catch_assert)
2291 (allocate_location_catch_handlers, re_set_catch_handlers)
2292 (check_status_handlers, print_it_catch_handlers)
2293 (print_one_catch_handlers, print_mention_catch_handlers)
2294 (print_recreate_catch_handlers): Remove.
2295 (create_ada_exception_catchpoint): Update.
2296 (initialize_ada_catchpoint_ops): Update.
2297
fccf9de1
TT
22982019-10-02 Tom Tromey <tromey@adacore.com>
2299
2300 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2301 (create_excep_cond_exprs): Simplify exception string computation.
2302 (ada_exception_catchpoint_cond_string): Likewise.
2303
4b610737
TT
23042019-10-02 Tom Tromey <tromey@adacore.com>
2305
2306 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2307 * ada-lang.c (lesseq_defined_than): Handle
2308 LOC_STATIC.
2309 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2310 parameter.
2311 (dwarf2_has_info): Likewise.
2312 (new_symbol): Set maybe_copied on symbol when
2313 appropriate.
2314 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2315 parameter.
2316 <can_copy>: New member.
2317 * elfread.c (record_minimal_symbol): Set maybe_copied
2318 on symbol when appropriate.
2319 (elf_symfile_read): Update call to dwarf2_has_info.
2320 * minsyms.c (lookup_minimal_symbol_linkage): New
2321 function.
2322 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2323 * symtab.c (get_symbol_address, get_msymbol_address):
2324 New functions.
2325 * symtab.h (get_symbol_address, get_msymbol_address):
2326 Declare.
2327 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2328 maybe_copied.
2329 (struct symbol, struct minimal_symbol) <maybe_copied>:
2330 New member.
2331
1dd58850
TT
23322019-10-02 Tom Tromey <tromey@adacore.com>
2333
2334 * source.c (struct current_source_location): New.
2335 (current_source_key): New global.
2336 (current_source_symtab, current_source_line)
2337 (current_source_pspace): Remove.
2338 (get_source_location): New function.
2339 (get_current_source_symtab_and_line)
2340 (set_default_source_symtab_and_line)
2341 (set_current_source_symtab_and_line)
2342 (clear_current_source_symtab_and_line, select_source_symtab)
2343 (info_source_command, print_source_lines_base)
2344 (info_line_command, search_command_helper, _initialize_source):
2345 Update.
2346
5c281dbb
TT
23472019-10-02 Tom Tromey <tromey@adacore.com>
2348
2349 * source.c (select_source_symtab): Don't call
2350 decode_line_with_current_source.
2351
d3d32391
AB
23522019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2353
2354 * symtab.c (lookup_global_symbol): Search global block.
2355
38583298
TT
23562019-10-02 Tom Tromey <tromey@adacore.com>
2357
2358 * coffread.c (process_coff_symbol): Update.
2359 * dwarf2read.c (var_decode_location, new_symbol): Update.
2360 * mdebugread.c (parse_symbol): Update.
2361 * objfiles.c (relocate_one_symbol): Update.
2362 * stabsread.c (define_symbol, fix_common_block)
2363 (scan_file_globals): Update.
2364 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2365 (SET_SYMBOL_VALUE_ADDRESS): New macro.
2366 * xcoffread.c (process_xcoff_symbol): Update.
2367
9344c18f
AA
23682019-10-02 Andreas Arnez <arnez@linux.ibm.com>
2369
2370 * MAINTAINERS: Update my email address.
2371
df07e2c7
AB
23722019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2373
2374 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2375 std::vector.
2376 (build_type_psymtabs_reader): Update for std::vector.
2377 (build_type_psymtab_dependencies): Likewise.
2378 * dwarf2read.h: Remove use of DEF_VEC_P.
2379 (typedef sig_type_ptr): Delete.
2380
554ac434
AB
23812019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2382
2383 * btrace.c (btrace_maint_clear): Update to handle change from VEC
2384 to std::vector.
2385 (btrace_maint_decode_pt): Likewise, and move allocation of the
2386 vector outside of the loop.
2387 (btrace_maint_update_packets): Update to handle change from VEC to
2388 std::vector.
2389 (btrace_maint_print_packets): Likewise.
2390 (maint_info_btrace_cmd): Likewise.
2391 * btrace.h: Remove use of DEF_VEC_O.
2392 (typedef btrace_pt_packet_s): Delete.
2393 (struct btrace_maint_info) <packets>: Change fromm VEC to
2394 std::vector.
2395 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2396
46f29a9a
AB
23972019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2398
2399 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2400 make accesses into the vector constant references.
2401 (btrace_add_pc): Update for std::vector.
2402 (btrace_stitch_bts): Likewise.
2403 (parse_xml_btrace_block): Likewise.
2404 (btrace_maint_update_packets): Likewise.
2405 (btrace_maint_print_packets): Likewise.
2406 (maint_info_btrace_cmd): Likewise.
2407 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2408 std::vector.
2409 (btrace_data::empty): Likewise.
2410 (btrace_data_append): Likewise.
2411 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2412 (typedef btrace_block_s): Delete.
2413 (struct btrace_block): Add constructor.
2414 (struct btrace_data_bts) <blocks>: Change to std::vector.
2415 * nat/linux-btrace.c (perf_event_read_bts): Update for
2416 std::vector.
2417 (linux_read_bts): Likewise.
2418
d770d56f
TT
24192019-10-01 Tom Tromey <tom@tromey.com>
2420
2421 * cli/cli-logging.c (show_logging_filename): Use styled_string.
2422
9d636d67
TT
24232019-10-01 Tom Tromey <tom@tromey.com>
2424
2425 * stack.c (print_frame, info_frame_command_core): Use
2426 styled_string.
2427 * linux-thread-db.c (try_thread_db_load_1)
2428 (try_thread_db_load_from_pdir_1): Use styled_string.
2429 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2430 (auto_load_section_scripts, info_auto_load_local_gdbinit)
2431 (maybe_print_unsupported_script_warning)
2432 (maybe_print_script_not_found_warning): Use styled_string.
2433 * ada-lang.c (user_select_syms): Use styled_string.
2434
7f6aba03
TT
24352019-10-01 Tom Tromey <tom@tromey.com>
2436
2437 * p-lang.c (pascal_printstr): Use metadata style.
2438 * value.c (show_convenience): Use metadata style.
2439 * valprint.c (valprint_check_validity, val_print_optimized_out)
2440 (val_print_not_saved, val_print_unavailable)
2441 (val_print_invalid_address, generic_val_print, val_print)
2442 (value_check_printable, val_print_array_elements): Use metadata
2443 style.
2444 * ui-out.h (class ui_out) <field_fmt>: New overload.
2445 <do_field_fmt>: Add style parameter.
2446 * ui-out.c (ui_out::field_fmt): New overload.
2447 * typeprint.c (type_print_unknown_return_type)
2448 (val_print_not_allocated, val_print_not_associated): Use metadata
2449 style.
2450 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2451 parameter.
2452 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2453 * tracepoint.c (tvariables_info_1): Use metadata style.
2454 * stack.c (print_frame_arg, print_frame_info, print_frame)
2455 (info_frame_command_core): Use metadata style.
2456 * skip.c (info_skip_command): Use metadata style.
2457 * rust-lang.c (rust_print_enum): Use metadata style.
2458 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2459 metadata style.
2460 * python/py-framefilter.c (py_print_single_arg): Use metadata
2461 style.
2462 * printcmd.c (do_one_display, print_variable_and_value): Use
2463 metadata style.
2464 * p-valprint.c (pascal_val_print)
2465 (pascal_object_print_value_fields): Use metadata style.
2466 * p-typeprint.c (pascal_type_print_base): Use metadata style.
2467 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2468 parameter.
2469 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2470 * m2-valprint.c (m2_print_long_set): Use metadata style.
2471 * m2-typeprint.c (m2_print_type): Use metadata style.
2472 * infcmd.c (print_return_value_1): Use metadata style.
2473 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2474 * f-valprint.c (info_common_command_for_block): Use metadata
2475 style.
2476 * f-typeprint.c (f_type_print_base): Use metadata style.
2477 * expprint.c (print_subexp_standard): Use metadata style.
2478 * cp-valprint.c (cp_print_value_fields): Use metadata style.
2479 * cli/cli-style.h (class cli_style_option): Add constructor.
2480 (metadata_style): Declare.
2481 * cli/cli-style.c (metadata_style): New global.
2482 (_initialize_cli_style): Register metadata style.
2483 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2484 parameter.
2485 * cli-out.c (cli_ui_out::do_field_fmt): Update.
2486 * c-typeprint.c (c_type_print_base_struct_union)
2487 (c_type_print_base_1): Use metadata style.
2488 * breakpoint.c (watchpoint_value_print)
2489 (print_one_breakpoint_location): Use metadata style.
2490 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2491 style.
2492 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2493 style.
2494 * ada-valprint.c (val_print_packed_array_elements, printstr)
2495 (print_field_values, ada_val_print_ref, ada_val_print): Use
2496 metadata style.
2497 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2498 style.
2499 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2500 style.
2501 * ada-lang.c (user_select_syms): Use metadata style.
2502
14309bb6
TT
25032019-10-01 Tom Tromey <tom@tromey.com>
2504
2505 * cli/cli-cmds.c (pwd_command): Style output.
2506
6a831f06
PA
25072019-10-01 Pedro Alves <palves@redhat.com>
2508 Tom Tromey <tom@tromey.com>
2509
2510 * symtab.c (print_symbol_info): Use %ps.
2511 (print_msymbol_info): Use %ps.
2512 * symfile.c (symbol_file_add_with_addrs): Use %ps.
2513 * printcmd.c (print_variable_and_value): Use %ps.
2514 * macrocmd.c (show_pp_source_pos): Use %ps.
2515 * infrun.c (print_exited_reason): Use ui_out::message.
2516 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2517 (describe_other_breakpoints): Use ui_out::message and new
2518 formats.
2519 (say_where): Use new formats.
2520 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2521 and new formats.
2522
2a3c1174
PA
25232019-10-01 Pedro Alves <palves@redhat.com>
2524 Tom Tromey <tom@tromey.com>
2525
2526 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2527 (test_gdb_formats): New function.
2528 (run_tests): Call it.
2529 (test_format_specifier): Update.
2530 * utils.h (fputs_filtered): Update comment.
2531 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2532 (fputs_styled_unfiltered): Declare.
2533 * utils.c (fputs_styled_unfiltered): New function.
2534 (vfprintf_maybe_filtered): Add gdbfmt parameter.
2535 (vfprintf_filtered): Update.
2536 (vfprintf_unfiltered, vprintf_filtered): Update.
2537 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2538 * ui-out.h (enum ui_out_flag) <unfiltered_output,
2539 disallow_ui_out_field>: New constants.
2540 (enum class field_kind): New.
2541 (struct base_field_s, struct signed_field_s): New.
2542 (signed_field): New function.
2543 (struct string_field_s): New.
2544 (string_field): New function.
2545 (struct styled_string_s): New.
2546 (styled_string): New function.
2547 (class ui_out) <message>: Add comment.
2548 <vmessage, call_do_message>: New methods.
2549 <do_message>: Add style parameter.
2550 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2551 methods.
2552 (ui_out::message): Rewrite.
2553 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2554 parameter.
2555 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2556 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2557 gdb_extensions parameter.
2558 (class format_piece): Add parameter to constructor.
2559 (n_int_args): New field.
2560 * gdbsupport/format.c (format_pieces::format_pieces): Add
2561 gdb_extensions parameter. Handle '*'.
2562 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2563 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
2564 vfprintf_styled_no_gdbfmt.
2565 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2566 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2567 unfiltered output.
2568 * ui-style.h (struct ui_file_style) <ptr>: New method.
2569
0dfe5bfb
TT
25702019-10-01 Tom Tromey <tom@tromey.com>
2571
2572 * unittests/format_pieces-selftests.c: Update. Add final format.
2573 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2574 empty literal pieces.
2575
e43b10e1
TT
25762019-10-01 Tom Tromey <tom@tromey.com>
2577
2578 * ui-out.h (enum class ui_out_style_kind): Remove.
2579 (class ui_out) <field_string, field_stsream, do_field_string>:
2580 Change type of "style".
2581 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2582 (ui_out::field_string): Update.
2583 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2584 of "style".
2585 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2586 * tracepoint.c (print_one_static_tracepoint_marker): Update.
2587 * stack.c (print_frame_arg, print_frame_info, print_frame):
2588 Update.
2589 * source.c (print_source_lines_base): Update.
2590 * solib.c (info_sharedlibrary_command): Update.
2591 * skip.c (info_skip_command): Update.
2592 * record-btrace.c (btrace_call_history_src_line)
2593 (btrace_call_history): Update.
2594 * python/py-framefilter.c (py_print_frame): Update.
2595 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2596 "style".
2597 * mi/mi-out.c (mi_ui_out::do_table_header)
2598 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2599 (mi_ui_out::do_field_string): Update.
2600 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2601 Update.
2602 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2603 "style".
2604 * cli-out.c (cli_ui_out::do_table_header)
2605 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2606 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2607 (cli_ui_out::do_field_fmt): Update.
2608 * breakpoint.c (print_breakpoint_location): Update.
2609 (update_static_tracepoint): Update.
2610
cd7c32c3
PW
26112019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2612
2613 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2614 conversion of gdb_datadir.
2615 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2616 remove not needed c_str ().
2617
8fe0f950
AT
26182019-09-30 Ali Tamur <tamur@google.com>
2619
2620 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2621 (dwarf2_string_attr): Likewise.
2622
5f48f8f3
AT
26232019-09-30 Ali Tamur <tamur@google.com>
2624
2625 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2626 (process_full_type_unit): Likewise.
2627 (dump_die_shallow): Likewise.
2628 (cu_debug_loc_section): Likewise.
2629
6fb08628
CB
26302019-09-28 Christian Biesinger <cbiesinger@google.com>
2631
2632 * minsyms.c (compare_minimal_symbols): Rename to...
2633 (minimal_symbol_is_less_than): ...this, and adjust to STL
2634 conventions (return bool, take arguments as references)
2635 (minimal_symbol_reader::install): Call std::sort instead
2636 of qsort.
2637
c7ee338a
CB
26382019-09-29 Christian Biesinger <cbiesinger@google.com>
2639
2640 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2641 hash and why.
2642 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2643 msymbol_hash, msymbol_demangled_hash>: Improve comments.
2644
703a86c2
SM
26452019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
2646
2647 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2648 * psympriv.h (add_psymbol_to_list): Move comment here and update
2649 it.
2650
0df0352a
TV
26512019-09-29 Tom de Vries <tdevries@suse.de>
2652
2653 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2654 Use $tmpdir/$(basename "$output_file").dwz instead of
2655 "${output_file}.dwz".
2656
ad75efa6
SM
26572019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
2658
2659 PR gdb/25045
2660 * hppa-linux-nat.c: Include gdbarch.h.
2661
ececd218
CB
26622019-09-26 Christian Biesinger <cbiesinger@google.com>
2663
2664 * blockframe.c (find_pc_partial_function): Change return type to bool.
2665 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2666 * minsyms.c (in_gnu_ifunc_stub): Likewise.
2667 (stub_gnu_ifunc_resolve_name): Likewise.
2668 * symtab.c (compare_filenames_for_search): Likewise.
2669 (compare_glob_filenames_for_search): Likewise.
2670 (matching_obj_sections): Likewise.
2671 (symbol_matches_domain): Likewise.
2672 (find_line_symtab): Change out param EXACT_MATCH to bool *.
2673 (find_line_pc): Change return type to bool.
2674 (find_line_pc_range): Likewise.
2675 (producer_is_realview): Likewise.
2676 * symtab.h (symbol_matches_domain): Likewise.
2677 (find_pc_partial_function): Likewise.
2678 (find_pc_line_pc_range): Likewise.
2679 (in_gnu_ifunc_stub): Likewise.
2680 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2681 (find_line_pc): Likewise.
2682 (find_line_pc_range): Likewise.
2683 (matching_obj_sections): Likewise.
2684 (find_line_symtab): Change out parameter to bool.
2685 (producer_is_realview): Change return type to bool.
2686 (compare_filenames_for_search): Likewise.
2687 (compare_glob_filenames_for_search): Likewise.
2688
27a900b8
TT
26892019-09-26 Tom Tromey <tom@tromey.com>
2690
2691 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2692 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2693 * gdb_usleep.h: Remove.
2694 * gdb_usleep.c: Remove.
2695 * utils.c: Don't include gdb_usleep.h.
2696
5d63b30a
TT
26972019-09-26 Tom Tromey <tromey@adacore.com>
2698
2699 * python/py-type.c (type_to_type_object): Call check_typedef
2700 for stub types.
2701
12904d37
TT
27022019-09-26 Tom Tromey <tom@tromey.com>
2703
2704 * utils.h (initialize_utils): Don't declare.
2705 * top.c (gdb_init): Don't call initialize_utils.
2706 * utils.c (initialize_utils): Remove. Move contents...
2707 (_initialize_utils): ... here.
2708
858f25f0
TT
27092019-09-25 Tom Tromey <tom@tromey.com>
2710
2711 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2712 * utils.h (make_hex_string): Don't declare.
2713 * utils.c (make_hex_string): Remove.
2714
3d435220
TV
27152019-09-24 Tom de Vries <tdevries@suse.de>
2716
2717 PR gdb/23815
2718 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2719 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2720
ddd44b70
DD
27212019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
2722
2723 * NEWS: Mention new simulator port for PRU.
2724
f945dedf
CB
27252019-09-23 Christian Biesinger <cbiesinger@google.com>
2726
2727 * ada-exp.y (write_object_remaining): Update.
2728 * ada-lang.c (ada_decode): Return a std::string instead of a char*
2729 and eliminate the static buffer.
2730 (ada_decode_symbol): Update.
2731 (ada_la_decode): Update.
2732 (ada_sniff_from_mangled_name): Update.
2733 (is_valid_name_for_wild_match): Update.
2734 (ada_lookup_name_info::matches): Update and simplify.
2735 (name_matches_regex): Update.
2736 (ada_add_global_exceptions): Update.
2737 * ada-lang.h (ada_decode): Update signature.
2738 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2739 * dwarf-index-write.c (debug_names::insert): Update.
2740
7ab78ccb
SM
27412019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
2742
2743 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2744 formatting.
2745
9252448b
SM
27462019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
2747
2748 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2749 Change "nonzero" to "true" in documentation.
2750
626ca2c0
CB
27512019-09-20 Christian Biesinger <cbiesinger@google.com>
2752
2753 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2754 (_initialize_darwin_solib): Don't set
2755 darwin_so_ops.lookup_lib_global_symbol.
2756 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2757 set_gdbarch_iterate_over_objfiles_in_search_order.
2758 (elf_lookup_lib_symbol): Rename to...
2759 (svr4_iterate_over_objfiles_in_search_order): this, and update
2760 to iterate semantics.
2761 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2762 * solib.c (solib_global_lookup): Remove.
2763 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2764 (solib_global_lookup): Remove.
2765 * symtab.c (lookup_global_or_static_symbol): Remove call to
2766 solib_global_lookup.
2767
5a3a0d63
JB
27682019-09-20 Joel Brobecker <brobecker@adacore.com>
2769
2770 * NEWS: Move entries about default MI version now being
2771 version 3, and about the GDB/MI fix for multi-location
2772 breakpoints to the "since GDB 8.3" section.
2773
ffea1427
JB
27742019-09-20 Joel Brobecker <brobecker@adacore.com>
2775
2776 GDB 8.3.1 released.
2777
abf516c6
UW
27782019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
2779
2780 * NEWS: Mention that Cell/B.E. debugging support was removed.
2781 * MAINTAINERS: Remove spu target.
2782
2783 * config/djgpp/fnchange.lst: Remove entries for removed files.
2784
2785 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2786 spu-multiarch.o, and spu-tdep.o.
2787 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2788 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2789 spu-multiarch.c, and spu-tdep.c.
2790 * spu-linux-nat.c: Remove file.
2791 * spu-multiarch.c: Remove file.
2792 * spu-tdep.c: Remove file.
2793 * spu-tdep.h: Remove file.
2794 * solib-spu.c: Remove file.
2795 * solib-spu.h: Remove file.
2796
2797 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2798 * configure.nat (spu-linux): Remove.
2799 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2800 solib-multiarch.o from gdb_target_obs.
2801 (spu*-*-*): Remove.
2802
2803 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2804 feature flag.
2805 (ppc_linux_no_features): Update.
2806 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2807 Cell/B.E. support.
2808 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2809 (tdesc_powerpc_cell64l): Likewise.
2810 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2811 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2812 Cell/B.E. support.
2813 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2814 Do not include "features/rs6000/powerpc-cell32l.c" or
2815 "features/rs6000/powerpc-cell64l.c".
2816 (ppc_linux_spu_section): Remove.
2817 (ppc_linux_core_read_description): Remove Cell/B.E. support.
2818 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2819 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2820 (ppc_linux_spe_context_lookup): Remove.
2821 (ppc_linux_spe_context_inferior_created): Remove.
2822 (ppc_linux_spe_context_solib_loaded): Remove.
2823 (ppc_linux_spe_context_solib_unloaded): Remove.
2824 (ppc_linux_spe_context): Remove.
2825 (struct ppu2spu_cache): Remove.
2826 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2827 (struct ppu2spu_data): Remove.
2828 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2829 ppu2spu_unwind): Remove.
2830 (ppc_linux_init_abi): Remove Cell/B.E. support.
2831 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2832
2833 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2834 (rs6000/powerpc-cell64l-expedite): Likewise
2835 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2836 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2837 rs6000/powerpc-cell64l.xml.
2838 * features/rs6000/powerpc-cell32l.xml: Remove.
2839 * features/rs6000/powerpc-cell64l.xml: Likewise.
2840 * features/rs6000/powerpc-cell32l.c: Remove generated file.
2841 * features/rs6000/powerpc-cell64l.c: Likewise.
2842 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2843 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2844 * regformats/reg-spu.dat: Remove.
2845
2846 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2847 * corelow.c (struct spuid_list): Remove.
2848 (add_to_spuid_list): Remove.
2849 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2850 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2851 (remote_protocol_features): Remove associated entries.
2852 (_initialize_remote): No longer initialize them.
2853 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2854 * linux-nat.c (SPUFS_MAGIC): Remove.
2855 (linux_proc_xfer_spu): Remove.
2856 (spu_enumerate_spu_ids): Remove.
2857 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2858 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2859 (linux_make_corefile_notes): No longer call it.
2860
2861 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2862 (cooked_write_test): Likewise.
2863
78e8cb91
TT
28642019-09-20 Tom Tromey <tom@tromey.com>
2865
2866 * NEWS: Mention case-sensitivity of TUI commands.
2867 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2868 (tui_set_win_height_command, parse_scrolling_args): Likewise.
2869 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2870
f074b67e
TT
28712019-09-20 Tom Tromey <tom@tromey.com>
2872
2873 * tui/tui-source.c (tui_source_window::set_contents): Use
2874 make_unique_xstrdup.
2875 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2876 make_unique_xstrdup.
2877
63c4bf19
TT
28782019-09-20 Tom Tromey <tom@tromey.com>
2879
2880 * tui/tui-data.c: Remove separator comments.
2881 * tui/tui-layout.c: Remove separator comments.
2882 * tui/tui-win.c: Remove separator comments.
2883 * tui/tui-wingeneral.c: Remove separator comments.
2884
43df9b2f
TT
28852019-09-20 Tom Tromey <tom@tromey.com>
2886
2887 * tui/tui.h (strcat_to_buf): Don't declare.
2888 * tui/tui.c (strcat_to_buf): Remove.
2889
7226433c
TT
28902019-09-20 Tom Tromey <tom@tromey.com>
2891
2892 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2893 from "fullname".
2894 * tui/tui-source.c (tui_source_window::set_contents)
2895 (tui_source_window::location_matches_p)
2896 (tui_source_window::maybe_update): Update.
2897
80df3337
TT
28982019-09-20 Tom Tromey <tom@tromey.com>
2899
2900 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2901 Update.
2902 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2903 prefix.
2904 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2905 (tui_data_window::line_from_reg_element_no)
2906 (tui_data_window::first_reg_element_no_inline)
2907 (tui_data_window::show_registers)
2908 (tui_data_window::show_register_group)
2909 (tui_data_window::display_registers_from)
2910 (tui_data_window::display_registers_from_line)
2911 (tui_data_window::first_data_item_displayed)
2912 (tui_data_window::delete_data_content_windows)
2913 (tui_data_window::erase_data_content)
2914 (tui_data_window::do_scroll_vertical)
2915 (tui_data_window::refresh_window)
2916 (tui_data_window::check_register_values): Update.
2917
9923f347
TT
29182019-09-20 Tom Tromey <tom@tromey.com>
2919
2920 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2921 (struct tui_locator_window) <full_name, proc_name>: Now
2922 std::string.
2923 * tui/tui-stack.c (tui_locator_window::make_status_line)
2924 (tui_locator_window::set_locator_fullname)
2925 (tui_locator_window::set_locator_info): Update.
2926 * tui/tui-source.c (tui_source_window::set_contents)
2927 (tui_source_window::showing_source_p): Update.
2928
b76251ab
TT
29292019-09-20 Tom Tromey <tom@tromey.com>
2930
2931 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2932 Don't call tui_locator_win_info_ptr.
2933
0891be08
TT
29342019-09-20 Tom Tromey <tom@tromey.com>
2935
2936 * tui/tui-win.c (tui_resize_all): Don't call refresh.
2937
1b935acf
TT
29382019-09-20 Tom Tromey <tom@tromey.com>
2939
2940 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2941 height for locator.
2942 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2943 * tui/tui-layout.c (show_source_disasm_command, show_data)
2944 (show_source_or_disasm_and_command): Use 1 as height for locator.
2945
9abd8a65
TT
29462019-09-20 Tom Tromey <tom@tromey.com>
2947
2948 * tui/tui.c (tui_enable): Update.
2949 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2950 Update.
2951 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2952 Update.
2953 * tui/tui-data.c (win_resized): Now bool.
2954 (tui_win_resized): Return bool.
2955 (tui_set_win_resized_to): Accept a bool.
2956
b5457826
TT
29572019-09-20 Tom Tromey <tom@tromey.com>
2958
2959 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2960 Change type of "refresh_values_only".
2961 * tui/tui-regs.c (tui_data_window::show_register_group): Change
2962 type of "refresh_values_only".
2963
6b915f7d
TT
29642019-09-20 Tom Tromey <tom@tromey.com>
2965
2966 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2967 std::string.
2968 (tui_disassemble): Add "pos" parameter.
2969 (tui_disasm_window::set_contents): Simplify.
2970
2ad52f6f
TT
29712019-09-20 Tom Tromey <tom@tromey.com>
2972
2973 * tui/tui-winsource.h (struct tui_source_window_base)
2974 <show_source_content>: Now private.
2975 * tui/tui-winsource.c
2976 (tui_source_window_base::show_source_content): Don't handle empty
2977 content case.
2978
b3b1bde6
TT
29792019-09-20 Tom Tromey <tom@tromey.com>
2980
2981 * tui/tui-layout.c (show_source_disasm_command)
2982 (show_source_or_disasm_and_command): Don't call
2983 show_source_content.
2984
71a25ed2
TT
29852019-09-20 Tom Tromey <tom@tromey.com>
2986
2987 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2988 Declare.
2989 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2990 from tui_make_status_line.
2991 (tui_locator_window::rerender): Update.
2992
f8532154
TT
29932019-09-20 Tom Tromey <tom@tromey.com>
2994
2995 * tui/tui-stack.c (tui_make_status_line): Return std::string.
2996 (tui_locator_window::rerender): Update.
2997
2d81b349
TT
29982019-09-20 Tom Tromey <tom@tromey.com>
2999
3000 * tui/tui-winsource.h (struct tui_source_window_base)
3001 <~tui_source_window_base>: Don't declare.
3002 <fullname>: Remove.
3003 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3004 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3005 member.
3006 * tui/tui-source.c (tui_source_window::set_contents): Update.
3007 (tui_source_window::location_matches_p)
3008 (tui_source_window::maybe_update): Update.
3009
f14bec58
TT
30102019-09-20 Tom Tromey <tom@tromey.com>
3011
3012 * tui/tui-winsource.h (~tui_source_element): Remove.
3013 (tui_source_element): Update.
3014 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3015 * tui/tui-winsource.c (tui_show_source_line): Update.
3016 * tui/tui-source.c (tui_source_window::set_contents): Update.
3017 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3018
78d5933a
TT
30192019-09-20 Tom Tromey <tom@tromey.com>
3020
3021 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3022 declare.
3023 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3024 tui_clear_source_windows_detail.
3025 * tui/tui-winsource.h (struct tui_source_window_base)
3026 <clear_detail>: Don't declare.
3027 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3028 Remove.
3029 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3030
d4207696
TT
30312019-09-20 Tom Tromey <tromey@adacore.com>
3032
3033 PR ada/24919:
3034 * block.c (contained_in): Fix final return value.
3035
00f93c44
AM
30362019-09-20 Alan Modra <amodra@gmail.com>
3037
3038 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3039 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3040 (read_indirect_string_from_dwz): Use bfd accessor.
3041 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3042 * machoread.c (macho_symfile_read_all_oso): Likewise.
3043 * solib.c (solib_bfd_open): Likewise.
3044
e4153ae6
CB
30452019-09-19 Christian Biesinger <cbiesinger@google.com>
3046
3047 * eval.c: Move declaration of overload_resolution to...
3048 * value.h: ...here.
3049
c7ae7675
CB
30502019-09-19 Christian Biesinger <cbiesinger@google.com>
3051
3052 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3053 * arm-linux-tdep.c: Likewise.
3054 * arm-nbsd-nat.c: Likewise.
3055 * arm-tdep.h: Declare arm_apcs_32.
3056 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3057
e86f08d2
CB
30582019-09-19 Christian Biesinger <cbiesinger@google.com>
3059
3060 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3061 * dwarf2read.h: Declare dwarf_always_disassemble.
3062
f64e2f40
TV
30632019-09-19 Tom de Vries <tdevries@suse.de>
3064
3065 PR gdb/25009
3066 * source-cache.c (source_cache::ensure): Catch exception thrown during
3067 construction of the highlighter.
3068
fd361982
AM
30692019-09-18 Alan Modra <amodra@gmail.com>
3070
3071 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3072 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3073 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3074 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3075 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3076 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3077 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3078 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3079 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3080 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3081 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3082 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3083 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3084 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3085 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3086 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3087 * mi/mi-interp.c: Update throughout for bfd section macro and
3088 function changes.
3089 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3090 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3091
11061048
TT
30922019-09-18 Tom Tromey <tom@tromey.com>
3093
3094 * NEWS: Add entry.
3095 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3096 call rl_initialize.
3097 (tui_enable): Do not call rl_initialize.
3098
7a27b85f
CG
30992019-09-18 Christian Groessler <chris@groessler.org>
3100
3101 * alpha-linux-nat.c: Include gdbarch.h.
3102
f64eea3a
SM
31032019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3104
3105 * ui-file.c: Include cli/cli-style.h.
3106 (term_cli_styling): Remove cli_styling declaration.
3107
e6f7f6d1
AM
31082019-09-18 Alan Modra <amodra@gmail.com>
3109
3110 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3111 to bfd_asymbol_section.
3112
1d38e9d1
AM
31132019-09-18 Alan Modra <amodra@gmail.com>
3114
3115 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3116 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3117 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3118
90d92a63
AM
31192019-09-18 Alan Modra <amodra@gmail.com>
3120
3121 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3122 * spu-linux-nat.c (spu_bfd_open): Likewise.
3123
a3d181d2
CB
31242019-09-18 Christian Biesinger <cbiesinger@google.com>
3125
3126 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3127 to bool to match definition in dwarf2read.c.
3128
491144b5
CB
31292019-09-17 Christian Biesinger <cbiesinger@google.com>
3130
3131 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3132 (print_signatures): Likewise.
3133 (trust_pad_over_xvs): Likewise.
3134 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3135 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3136 * arm-linux-nat.c (arm_apcs_32): Likewise.
3137 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3138 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3139 * arm-tdep.c (arm_debug): Likewise.
3140 (arm_apcs_32): Likewise.
3141 * auto-load.c (debug_auto_load): Likewise.
3142 (auto_load_gdb_scripts): Likewise.
3143 (global_auto_load): Likewise.
3144 (auto_load_local_gdbinit): Likewise.
3145 (auto_load_local_gdbinit_loaded): Likewise.
3146 * auto-load.h (global_auto_load): Likewise.
3147 (auto_load_local_gdbinit): Likewise.
3148 (auto_load_local_gdbinit_loaded): Likewise.
3149 * breakpoint.c (disconnected_dprintf): Likewise.
3150 (breakpoint_proceeded): Likewise.
3151 (automatic_hardware_breakpoints): Likewise.
3152 (always_inserted_mode): Likewise.
3153 (target_exact_watchpoints): Likewise.
3154 (_initialize_breakpoint): Update.
3155 * breakpoint.h (target_exact_watchpoints): Change to bool.
3156 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3157 * cli/cli-cmds.c (trace_commands): Likewise.
3158 * cli/cli-cmds.h (trace_commands): Likewise.
3159 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3160 to bool*.
3161 * cli/cli-logging.c (logging_overwrite): Change to bool.
3162 (logging_redirect): Likewise.
3163 (debug_redirect): Likewise.
3164 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3165 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3166 to bool.
3167 <boolean_option_def>: Update.
3168 (struct flag_option_def): Change default type of Context to bool
3169 from int.
3170 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3171 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3172 (get_setshow_command_value_string): Likewise.
3173 * cli/cli-style.c (cli_styling): Change to bool.
3174 (source_styling): Likewise.
3175 * cli/cli-style.h (source_styling): Likewise.
3176 (cli_styling): Likewise.
3177 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3178 to bool.
3179 * command.h (var_types): Update comment.
3180 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3181 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3182 bool.
3183 (debug_compile_cplus_scopes): Likewise.
3184 * compile/compile-internal.h (compile_debug): Likewise.
3185 * compile/compile.c (compile_debug): Likewise.
3186 (struct compile_options) <raw>: Likewise.
3187 * cp-support.c (catch_demangler_crashes): Likewise.
3188 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3189 (usr_cmd_cris_dwarf2_cfi): Likewise.
3190 * csky-tdep.c (csky_debug): Likewise.
3191 * darwin-nat.c (enable_mach_exceptions): Likewise.
3192 * dcache.c (dcache_enabled_p): Likewise.
3193 * defs.h (info_verbose): Likewise.
3194 * demangle.c (demangle): Likewise.
3195 (asm_demangle): Likewise.
3196 * dwarf-index-cache.c (debug_index_cache): Likewise.
3197 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3198 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3199 * dwarf2read.c (check_physname): Likewise.
3200 (use_deprecated_index_sections): Likewise.
3201 (dwarf_always_disassemble): Likewise.
3202 * eval.c (overload_resolution): Likewise.
3203 * event-top.c (set_editing_cmd_var): Likewise.
3204 (exec_done_display_p): Likewise.
3205 * event-top.h (set_editing_cmd_var): Likewise.
3206 (exec_done_display_p): Likewise.
3207 * exec.c (write_files): Likewise.
3208 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3209 (debug_fbsd_nat): Likewise.
3210 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3211 Likewise.
3212 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3213 <backtrace_past_entry> Likewise.
3214 * gdb-demangle.h (demangle): Likewise.
3215 (asm_demangle): Likewise.
3216 * gdb_bfd.c (bfd_sharing): Likewise.
3217 * gdbcore.h (write_files): Likewise.
3218 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3219 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3220 * gdbthread.h (print_thread_events): Likewise.
3221 * gdbtypes.c (opaque_type_resolution): Likewise.
3222 (strict_type_checking): Likewise.
3223 * gnu-nat.c (gnu_debug_flag): Likewise.
3224 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3225 * guile/scm-param.c (pascm_variable): Add boolval.
3226 (add_setshow_generic): Update.
3227 (pascm_param_value): Update.
3228 (pascm_set_param_value_x): Update.
3229 * hppa-tdep.c (hppa_debug): Change to bool..
3230 * infcall.c (may_call_functions_p): Likewise.
3231 (coerce_float_to_double_p): Likewise.
3232 (unwind_on_signal_p): Likewise.
3233 (unwind_on_terminating_exception_p): Likewise.
3234 * infcmd.c (startup_with_shell): Likewise.
3235 * inferior.c (print_inferior_events): Likewise.
3236 * inferior.h (startup_with_shell): Likewise.
3237 (print_inferior_events): Likewise.
3238 * infrun.c (step_stop_if_no_debug): Likewise.
3239 (detach_fork): Likewise.
3240 (debug_displaced): Likewise.
3241 (disable_randomization): Likewise.
3242 (non_stop): Likewise.
3243 (non_stop_1): Likewise.
3244 (observer_mode): Likewise.
3245 (observer_mode_1): Likewise.
3246 (set_observer_mode): Update.
3247 (sched_multi): Change to bool.
3248 * infrun.h (debug_displaced): Likewise.
3249 (sched_multi): Likewise.
3250 (step_stop_if_no_debug): Likewise.
3251 (non_stop): Likewise.
3252 (disable_randomization): Likewise.
3253 * linux-tdep.c (use_coredump_filter): Likewise.
3254 (dump_excluded_mappings): Likewise.
3255 * linux-thread-db.c (auto_load_thread_db): Likewise.
3256 (check_thread_db_on_load): Likewise.
3257 * main.c (captured_main_1): Update.
3258 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3259 xx2_opt, boolean_opt>: Change to bool.
3260 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3261 * maint.c (maintenance_profile_p): Likewise.
3262 (per_command_time): Likewise.
3263 (per_command_space): Likewise.
3264 (per_command_symtab): Likewise.
3265 * memattr.c (inaccessible_by_default): Likewise.
3266 * mi/mi-main.c (mi_async): Likewise.
3267 (mi_async_1): Likewise.
3268 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3269 * nat/fork-inferior.h (startup_with_shell): Likewise.
3270 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3271 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3272 * nios2-tdep.c (nios2_debug): Likewise.
3273 * or1k-tdep.c (or1k_debug): Likewise.
3274 * parse.c (parser_debug): Likewise.
3275 * parser-defs.h (parser_debug): Likewise.
3276 * printcmd.c (print_symbol_filename): Likewise.
3277 * proc-api.c (procfs_trace): Likewise.
3278 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3279 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3280 (set_parameter_value): Update.
3281 (add_setshow_generic): Update.
3282 * python/py-value.c (copy_py_bool_obj): Change argument from int*
3283 to bool*.
3284 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3285 int*.
3286 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3287 * record-btrace.c (record_btrace_target::store_registers): Update.
3288 * record-full.c (record_full_memory_query): Change to bool.
3289 (record_full_stop_at_limit): Likewise.
3290 * record-full.h (record_full_memory_query): Likewise.
3291 * remote-notif.c (notif_debug): Likewise.
3292 * remote-notif.h (notif_debug): Likewise.
3293 * remote.c (use_range_stepping): Likewise.
3294 (interrupt_on_connect): Likewise.
3295 (remote_break): Likewise.
3296 * ser-tcp.c (tcp_auto_retry): Likewise.
3297 * ser-unix.c (serial_hwflow): Likewise.
3298 * skip.c (debug_skip): Likewise.
3299 * solib-aix.c (solib_aix_debug): Likewise.
3300 * spu-tdep.c (spu_stop_on_load_p): Likewise.
3301 (spu_auto_flush_cache_p): Likewise.
3302 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3303 Likewise.
3304 (struct info_print_options) <quiet>: Likewise.
3305 * symfile-debug.c (debug_symfile): Likewise.
3306 * symfile.c (auto_solib_add): Likewise.
3307 (separate_debug_file_debug): Likewise.
3308 * symfile.h (auto_solib_add): Likewise.
3309 (separate_debug_file_debug): Likewise.
3310 * symtab.c (basenames_may_differ): Likewise.
3311 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3312 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3313 (struct info_types_options) <quiet>: Likewise.
3314 * symtab.h (demangle): Likewise.
3315 (basenames_may_differ): Likewise.
3316 * target-dcache.c (stack_cache_enabled_1): Likewise.
3317 (code_cache_enabled_1): Likewise.
3318 * target.c (trust_readonly): Likewise.
3319 (may_write_registers): Likewise.
3320 (may_write_memory): Likewise.
3321 (may_insert_breakpoints): Likewise.
3322 (may_insert_tracepoints): Likewise.
3323 (may_insert_fast_tracepoints): Likewise.
3324 (may_stop): Likewise.
3325 (auto_connect_native_target): Likewise.
3326 (target_stop_and_wait): Update.
3327 (target_async_permitted): Change to bool.
3328 (target_async_permitted_1): Likewise.
3329 (may_write_registers_1): Likewise.
3330 (may_write_memory_1): Likewise.
3331 (may_insert_breakpoints_1): Likewise.
3332 (may_insert_tracepoints_1): Likewise.
3333 (may_insert_fast_tracepoints_1): Likewise.
3334 (may_stop_1): Likewise.
3335 * target.h (target_async_permitted): Likewise.
3336 (may_write_registers): Likewise.
3337 (may_write_memory): Likewise.
3338 (may_insert_breakpoints): Likewise.
3339 (may_insert_tracepoints): Likewise.
3340 (may_insert_fast_tracepoints): Likewise.
3341 (may_stop): Likewise.
3342 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3343 (make_thread_apply_all_options_def_group): Change argument from int*
3344 to bool*.
3345 (thread_apply_all_command): Update.
3346 (print_thread_events): Change to bool.
3347 * top.c (confirm): Likewise.
3348 (command_editing_p): Likewise.
3349 (history_expansion_p): Likewise.
3350 (write_history_p): Likewise.
3351 (info_verbose): Likewise.
3352 * top.h (confirm): Likewise.
3353 (history_expansion_p): Likewise.
3354 * tracepoint.c (disconnected_tracing): Likewise.
3355 (circular_trace_buffer): Likewise.
3356 * typeprint.c (print_methods): Likewise.
3357 (print_typedefs): Likewise.
3358 * utils.c (debug_timestamp): Likewise.
3359 (sevenbit_strings): Likewise.
3360 (pagination_enabled): Likewise.
3361 * utils.h (sevenbit_strings): Likewise.
3362 (pagination_enabled): Likewise.
3363 * valops.c (overload_resolution): Likewise.
3364 * valprint.h (struct value_print_options) <prettyformat_arrays,
3365 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3366 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3367 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3368 Likewise.
3369 * windows-nat.c (new_console): Likewise.
3370 (cygwin_exceptions): Likewise.
3371 (new_group): Likewise.
3372 (debug_exec): Likewise.
3373 (debug_events): Likewise.
3374 (debug_memory): Likewise.
3375 (debug_exceptions): Likewise.
3376 (useshell): Likewise.
3377 * windows-tdep.c (maint_display_all_tib): Likewise.
3378 * xml-support.c (debug_xml): Likewise.
3379
f1b620e9
MG
33802019-09-17 Mike Gulick <mgulick@mathworks.com>
3381
3382 * source.c (prepare_path_for_appending): New function.
3383 (openp): Make use of new function.
3384 (find_and_open_source): Search for the compilation directory and
3385 source file as a relative path beneath the directory search path.
3386
67f3ed6a
AB
33872019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
3388
3389 * source-cache.c (source_cache::get_line_charpos): Catch
3390 exceptions and return false, this matches the behaviour documented
3391 in the header file.
3392
74332189
JB
33932019-09-17 Joel Brobecker <brobecker@adacore.com>
3394
3395 * ada-tasks.c (info_task): Remove quoting of the task's name.
3396
f2f24aa9
CB
33972019-09-16 Christian Biesinger <cbiesinger@google.com>
3398
3399 * symfile.c (auto_solib_add): Replace comment with a reference
3400 to the header file.
3401
6a062a93
CB
34022019-09-14 Christian Biesinger <cbiesinger@google.com>
3403
3404 * NEWS: Mention that gdb can now be compiled with Python 3
3405 on Windows.
3406
ec6c8338
AB
34072019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3408
3409 * maint.c (maint_print_section_data::maint_print_section_data):
3410 Force use of 'float log10 (float)' by casting the argument to
3411 float.
3412
aa17805f
AB
34132019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3414
3415 * maint.c: Add 'cmath' include.
3416 (struct maint_print_section_data): New structure.
3417 (print_section_index): New function.
3418 (print_bfd_section_info): Add header comment, small whitespace
3419 cleanup, and update to call new print_section_index function.
3420 (print_objfile_section_info): Likewise.
3421 (maint_obj_section_from_bfd_section): New function.
3422 (print_bfd_section_info_maybe_relocated): New function.
3423 (maintenance_info_sections): Add header comment, always use
3424 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3425
3dd9bb46
AB
34262019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3427
3428 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3429 inner scope, add check that the objfile has psymtabs before
3430 checking psymtabs_addrmap.
3431 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3432
4993045d
PW
34332019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3434
3435 * NEWS: Announce that Ada task names are now shown at more places,
3436 and between quotes (except in info task output).
3437 * gdb/ada-tasks.c (task_to_str): New function.
3438 (display_current_task_id): Call task_to_str.
3439 (task_command_1): Likewise.
3440 (print_ada_task_info): In non-mi mode, Properly align headers and data
3441 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3442
7a289707
RO
34432019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
3444
3445 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3446 prstatus.pr_lwp.pr_info instead of making it up.
3447
f2aec7f6
CB
34482019-09-11 Christian Biesinger <cbiesinger@google.com>
3449
3450 * auto-load.c (auto_load_expand_dir_vars): Update.
3451 * defs.h (gdb_datadir): Change to std::string.
3452 (python_libdir): Likewise.
3453 (relocate_gdb_directory): Change return type to std::string.
3454 * guile/guile.c (gdbscm_data_directory): Update.
3455 (initialize_scheme_side): Update.
3456 * jit.c (jit_reader_dir): Change to std::string.
3457 (jit_reader_load_command): Update.
3458 * main.c (gdb_datadir): Change to std::string.
3459 (python_libdir): Likewise.
3460 (set_gdb_data_directory): Update.
3461 (relocate_path): Change to return std::string.
3462 (relocate_gdb_directory): Change to return std::string.
3463 (relocate_gdbinit_path_maybe_in_datadir): Update.
3464 (captured_main_1): Update.
3465 * python/python.c (do_start_initialization): Update.
3466 * top.c (show_gdb_datadir): Update.
3467 * xml-syscall.c (xml_init_syscalls_info): Update.
3468 (init_syscalls_info): Update.
3469
9224a013
CB
34702019-09-11 Christian Biesinger <cbiesinger@google.com>
3471
3472 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3473 out of get_init_files.
3474 (get_init_files): Update.
3475
f48cd836
CB
34762019-09-11 Christian Biesinger <cbiesinger@google.com>
3477
3478 * main.c (get_init_files): Change to use std::string.
3479 (captured_main_1): Update.
3480 (print_gdb_help): Update.
3481
9cab7ecd
AT
34822019-09-11 Ali Tamur <tamur@google.com>
3483
3484 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3485 implementation.
3486
67547d89
CB
34872019-09-11 Christian Biesinger <cbiesinger@google.com>
3488
3489 * dbxread.c (read_dbx_symtab): Update.
3490 * dwarf2read.c (load_partial_dies): Update.
3491 * mdebugread.c (parse_partial_symbols): Update.
3492 (handle_psymbol_enumerators): Update.
3493 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3494 * psymtab.c (add_psymbol_to_bcache): Likewise.
3495 (add_psymbol_to_list): Likewise.
3496 * symtab.c (symbol_set_names): Likewise.
3497 * symtab.h (symbol_set_names): Likewise.
3498 * xcoffread.c (scan_xcoff_symtab): Update.
3499
64b2d4a0
TT
35002019-09-11 Tom Tromey <tom@tromey.com>
3501
3502 * symfile-mem.c (symbol_file_add_from_memory): Use
3503 bfd_set_filename.
3504 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3505 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3506
3b00ef10
TT
35072019-09-10 Tom Tromey <tromey@adacore.com>
3508
3509 * dwarf-index-write.c (write_psymbols): Extend error message.
3510 (debug_names::insert): Add Ada code.
3511 (debug_names::write_psymbols): Remove Ada check.
3512 (debug_names) <m_string_obstack>: New member.
3513 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3514 (gdb_index_symbol_name_matcher::matches): Remove.
3515 (mapped_index_base::find_name_components_bounds): Add "lang"
3516 parameter.
3517 (mapped_index_base::build_name_components): Also split names
3518 according to Ada syntax.
3519 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
3520 type of "match_callback".
3521 (check_match, check_find_bounds_finds)
3522 (dw2_expand_symtabs_matching): Update.
3523 (dw2_debug_names_iterator): Add new constructor.
3524 (dw2_debug_names_map_matching_symbols): New function.
3525 (dw2_debug_names_expand_symtabs_matching): Update.
3526 (dwarf2_debug_names_functions): Use
3527 dw2_debug_names_map_matching_symbols.
3528
aa391654
TT
35292019-09-10 Tom Tromey <tromey@adacore.com>
3530
3531 * dwarf2read.c (dw2_get_file_names_reader): Add the
3532 CU's file name to the results.
3533
b054970d
TT
35342019-09-10 Tom Tromey <tromey@adacore.com>
3535
3536 * ada-lang.c (add_nonlocal_symbols): Combine calls to
3537 map_matching_symbols. Update.
3538 * dwarf2read.c (dw2_map_matching_symbols): Update.
3539 * psymtab.c (match_partial_symbol): Change type; update.
3540 (psym_map_matching_symbols): Likewise.
3541 * symfile-debug.c (debug_qf_map_matching_symbols): Change
3542 type; update.
3543 * symfile.h (struct quick_symbol_functions)
3544 <map_matching_symbols>: Change "name" to be a lookup_name_info.
3545 Remove "match".
3546
6a3dbf1b
TT
35472019-09-10 Tom Tromey <tromey@adacore.com>
3548
3549 * psymtab.c (map_block): Remove.
3550 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3551 * symtab.c (iterate_over_symbols_terminated): New function.
3552 * symtab.c (iterate_over_symbols_terminated): Declare.
3553
6969f124
TT
35542019-09-10 Tom Tromey <tromey@adacore.com>
3555
3556 * ada-lang.c (ada_iterate_over_symbols): Return bool.
3557 * language.h (struct language_defn) <la_iterate_over_symbols>:
3558 Return bool.
3559 * symtab.c (iterate_over_symbols): Return bool.
3560 * symtab.h (iterate_over_symbols): Return bool.
3561
199b4314
TT
35622019-09-10 Tom Tromey <tromey@adacore.com>
3563
3564 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3565 (add_nonlocal_symbols): Update.
3566 * dwarf2read.c (dw2_map_matching_symbols): Change type.
3567 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3568 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3569 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3570 Change type of "callback". Remove "data".
3571
a084a2a6
AT
3572
35732019-09-09 Ali Tamur <tamur@google.com>
3574
3575 * dwarf2read.c (comp_unit_head): Update comment.
3576 (dwarf2_dwo_name): New function declaration.
3577 (dwarf_unit_type_name): New function declaration.
3578 (read_comp_unit_head): Add support for new compilation units,
3579 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3580 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3581 (currently named as "signature") in their header. Also clarify error
3582 messages.
3583 (lookup_dwo_id): New function. Returns the dwo id of the given
3584 compile unit.
3585 (lookup_dwo_unit): Use the new lookup_dwo_id function.
3586 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3587 functions.
3588 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3589 (dwarf2_dwo_name): Get the dwo name if present.
3590 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3591 purposes.
3592
25a2915e
TT
35932019-09-09 Tom Tromey <tom@tromey.com>
3594
3595 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3596
e4df0874
PW
35972019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3598
3599 * python/python.c (do_start_initialization): Make progname_copy static,
3600 to avoid a leak report.
3601
8634b462
TT
36022019-09-08 Tom Tromey <tom@tromey.com>
3603
3604 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3605
c7f839cb
SM
36062019-09-07 Simon Marchi <simon.marchi@efficios.com>
3607
3608 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3609 Change type to gdb::optional<block_enum>.
3610 (dw2_symtab_iter_init): Change block_index parameter type
3611 to gdb::optional<block_enum>.
3612 (dw2_lookup_symbol): Change block_index parameter
3613 type to block_enum.c
3614 (dw2_debug_names_lookup_symbol): Likewise.
3615 * psymtab.c (psym_lookup_symbol): Likewise.
3616 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3617 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3618 Likewise.
3619
ead0e69a
CB
36202019-09-06 Christian Biesinger <cbiesinger@google.com>
3621
3622 * defs.h (relocate_gdb_directory): Change int to bool in
3623 signature and rename flag to relocatable.
3624 * main.c (relocate_path): Likewise.
3625 (relocate_gdb_directory): Likewise.
3626
b16c44de
AM
36272019-09-06 Alan Modra <amodra@gmail.com>
3628
3629 * coffread.c (coff_symfile_read): Constify filename variable.
3630 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3631 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3632 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3633 * solib.c (reload_shared_libraries_1): Likewise.
3634 * symfile.c (reread_symbols): Likewise.
3635 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3636 * solib-darwin.c (darwin_bfd_open): Likewise.
3637 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3638
06ff036e
AB
36392019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
3640
3641 * psymtab.c (print_partial_symbols): Handle missing domain_enum
3642 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3643
4e962e74
TT
36442019-09-03 Tom Tromey <tromey@adacore.com>
3645
3646 * ada-valprint.c (ada_val_print_num): Don't recurse for range
3647 types.
3648 (has_negatives): Unbias a range type bound.
3649 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3650 * gdbtypes.c (operator==): Handle new field.
3651 (create_range_type): Add "bias" parameter.
3652 (create_static_range_type, resolve_dynamic_range): Update.
3653 * gdbtypes.h (struct range_bounds) <bias>: New member.
3654 (create_range_type): Add bias parameter.
3655 * printcmd.c (print_scalar_formatted): Unbias range types.
3656 * value.c (unpack_long): Unbias range types.
3657 (pack_long): Bias range types.
3658
d90b8f26
AH
36592019-09-02 Alan Hayward <alan.hayward@arm.com>
3660
3661 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3662 probe arguments.
3663
fe01123e
AH
36642019-09-02 Alan Hayward <alan.hayward@arm.com>
3665
3666 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3667 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3668 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3669 (compile_probe_arg): Likewise.
3670 * probe.h (get_argument_count): Likewise.
3671 * solib-svr4.c (solib_event_probe_action): Likewise.
3672 * stap-probe.c (stap_probe::get_argument_count): Likewise.
3673
e661ef01
AH
36742019-09-02 Alan Hayward <alan.hayward@arm.com>
3675
3676 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3677 code to here...
3678 (svr4_create_solib_event_breakpoints): ...from here.
3679
47a536d9
SDJ
36802019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
3681
3682 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3683 suffix from warning message.
3684
d6a00eba
TT
36852019-08-30 Tom Tromey <tom@tromey.com>
3686
3687 * tui/tui-winsource.h (struct tui_source_window_base)
3688 <refresh_all>: Don't declare.
3689 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3690 Remove.
3691 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3692 tui_show_locator_content.
3693 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3694 declare.
3695 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3696 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3697 declare.
3698
55b2657b
TT
36992019-08-30 Tom Tromey <tom@tromey.com>
3700
3701 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3702
12a8555a
TT
37032019-08-30 Tom Tromey <tom@tromey.com>
3704
3705 * tui/tui-stack.c (_initialize_tui_stack): Move later.
3706 Remove unnecessary forward declarations.
3707
900ac242
TT
37082019-08-30 Tom Tromey <tom@tromey.com>
3709
3710 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3711 rerender.
3712 (tui_update_locator_fullname, tui_show_frame_info): Don't call
3713 tui_show_locator_content.
3714
99ab33fb
TT
37152019-08-30 Tom Tromey <tom@tromey.com>
3716
3717 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
3718 (tui_locator_window::rerender): Rewrite using body of previous
3719 tui_show_locator_content.
3720
e594a5d1
TT
37212019-08-30 Tom Tromey <tom@tromey.com>
3722
3723 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3724 set_locator_fullname>: New methods.
3725 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3726 Rename from tui_set_locator_fullname.
3727 (tui_locator_window::set_locator_info): Rename from
3728 tui_set_locator_info. Return bool.
3729 (tui_update_locator_fullname, tui_show_frame_info): Update.
3730
715bb467
TT
37312019-08-30 Tom Tromey <tom@tromey.com>
3732
3733 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3734
772f3f03
TT
37352019-08-30 Tom Tromey <tom@tromey.com>
3736
3737 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3738 call touchwin.
3739
108e13ab
TT
37402019-08-30 Tom Tromey <tom@tromey.com>
3741
3742 * tui/tui-wingeneral.c (box_win): Assume win_info and
3743 win_info->handle cannot be NULL.
3744
cdaa6eb4
TT
37452019-08-30 Tom Tromey <tom@tromey.com>
3746
3747 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3748 refresh_window>: Declare.
3749 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3750 resize.
3751 (tui_data_item_window::rerender): Rename from
3752 tui_display_register.
3753 (tui_data_item_window::refresh_window): New method.
3754 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3755 no-op.
3756
89df7f90
TT
37572019-08-30 Tom Tromey <tom@tromey.com>
3758
3759 * tui/tui-regs.h (struct tui_data_window) <regs_content,
3760 regs_column_count, current_group>: Move later. Now private.
3761 <get_current_group>: New method.
3762 * tui/tui-regs.c (tui_reg_command): Update.
3763 * tui/tui-layout.c (tui_set_layout): Update.
3764
1bf2866a
TT
37652019-08-30 Tom Tromey <tom@tromey.com>
3766
3767 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3768 (tui_data_window::rerender): Don't call
3769 check_and_display_highlight_if_needed.
3770 (tui_data_window::refresh_all): Remove call to
3771 erase_data_content.
3772
0670413d
TT
37732019-08-30 Tom Tromey <tom@tromey.com>
3774
3775 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3776 (tui_data_window::display_registers_from)
3777 (tui_data_window::display_reg_element_at_line)
3778 (tui_data_window::display_registers_from_line): Remove checks of
3779 "empty".
3780
18bb55c7
TT
37812019-08-30 Tom Tromey <tom@tromey.com>
3782
3783 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3784 Don't declare.
3785 * tui/tui-regs.c (tui_data_window::show_registers): Call
3786 rerender.
3787 (tui_data_window::rerender): Rename from display_all_data.
3788 (tui_data_window::rerender): Remove old implementation.
3789
1f6d2f10
TT
37902019-08-30 Tom Tromey <tom@tromey.com>
3791
3792 * tui/tui-regs.c (tui_data_window::display_all_data): Change
3793 text.
3794 * tui/tui-data.h (NO_DATA_STRING): Remove define.
3795
16d01f9c
BW
37962019-08-29 Bernhard Wodok <barto@gmx.net>
3797 Sergio Durigan Junior <sergiodj@redhat.com>
3798
3799 PR win32/24284
3800 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3801
d8f27c60
AB
38022019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
3803
3804 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3805 when searching for types.
3806
1f20c35e
AB
38072019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
3808
3809 * f-lang.c (f_language_defn): Use f_print_typedef.
3810 * f-lang.h (f_print_typedef): Declare.
3811 * f-typeprint.c (f_print_typedef): Define.
3812
550105b7
CB
38132019-08-27 Christian Biesinger <cbiesinger@google.com>
3814
3815 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3816
4acfdd20
AB
38172019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
3818
3819 * cli/cli-utils.c (info_print_options_defs): Delete.
3820 (make_info_print_options_def_group): Delete.
3821 (extract_info_print_options): Delete.
3822 (info_print_command_completer): Delete.
3823 (info_print_args_help): Add extra parameter, and optionally
3824 include text about -n flag.
3825 * cli/cli-utils.h (struct info_print_options): Delete.
3826 (extract_info_print_options): Delete declaration.
3827 (info_print_command_completer): Delete declaration.
3828 (info_print_args_help): Add extra parameter, extend header
3829 comment.
3830 * python/python.c (gdbpy_rbreak): Pass additional parameter to
3831 search_symbols.
3832 * stack.c (struct info_print_options): New type.
3833 (info_print_options_defs): New file scoped variable.
3834 (make_info_print_options_def_group): New static function.
3835 (info_print_command_completer): New static function.
3836 (info_locals_command): Update to use new local functions.
3837 (info_args_command): Likewise.
3838 (_initialize_stack): Add extra parameter to calls to
3839 info_print_args_help.
3840 * symtab.c (search_symbols): Add extra parameter, use this to
3841 possibly excluse non-debug symbols.
3842 (symtab_symbol_info): Add extra parameter, which is passed on to
3843 search_symbols.
3844 (struct info_print_options): New type.
3845 (info_print_options_defs): New file scoped variable.
3846 (make_info_print_options_def_group): New static function.
3847 (info_print_command_completer): New static function.
3848 (info_variables_command): Update to use local functions, and pass
3849 extra parameter through to symtab_symbol_info.
3850 (info_functions_command): Likewise.
3851 (info_types_command): Pass additional argument through to
3852 symtab_symbol_info.
3853 (rbreak_command): Pass extra argument to search_symbols.
3854 (_initialize_symtab): Add extra arguments for calls to
3855 info_print_args_help, and update help text for 'info variables',
3856 'whereis', and 'info functions' commands.
3857 * symtab.h (search_symbols): Add extra argument to declaration.
3858 * NEWS: Mention new flags.
3859
9aa55206
CB
38602019-08-26 Christian Biesinger <cbiesinger@google.com>
3861
3862 * symtab.c (lookup_static_symbol): Call the new function (and move
3863 it down to be next to lookup_global_symbol).
3864 (struct global_sym_lookup_data): Add block_enum member and rename to...
3865 (struct global_or_static_sym_lookup_data): ...this.
3866 (lookup_symbol_global_iterator_cb): Pass block_index instead of
3867 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3868 (lookup_symbol_global_or_static_iterator_cb): ...this.
3869 (lookup_global_or_static_symbol): New function.
3870 (lookup_global_symbol): Call new function.
3871
5c31b358
TV
38722019-08-26 Tom de Vries <tdevries@suse.de>
3873
3874 PR c++/24852
3875 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3876 when pc_probe.prob == NULL.
3877
23c13d42
SM
38782019-08-25 Simon Marchi <simon.marchi@efficios.com>
3879
3880 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3881 variable symbol_linkage to symbol_linkage_.
3882
beadd3e8
SM
38832019-08-25 Simon Marchi <simon.marchi@efficios.com>
3884
3885 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3886 represent whether the symbol is static, dynamic, or we don't
3887 know.
3888
e3ec872f
YS
38892019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
3890
3891 * gdb/rx-tdep.c (rx_register_names): New.
3892 (rx_register_name): Delete.
3893 (rx_psw_type): Delete.
3894 (rx_fpsw_type): Delete.
3895 (rx_register_type): Delete.
3896 (rx_gdbarch_init): Convert target-descriptions.
3897 (_initialize_rx_tdep): Add initialize_tdesc_rx.
3898 * gdb/features/Makefile: Add rx.xml.
3899 * gdb/features/rx.xml: New.
3900 * gdb/features/rx.c: Generated.
3901 * gdb/NEWS: Mention target description support.
3902
d0509ba4
CB
39032019-08-22 Christian Biesinger <cbiesinger@google.com>
3904
3905 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3906 *slot_ptr.
3907
2d41fa11
SDJ
39082019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
3909
3910 * configure.ac: Don't check for 'dlfcn.h' (moved to
3911 gdbsupport/common.m4).
3912 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3913 'gdbsupport/'.
3914 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3915 * compile/compile-c-support.c: Include
3916 'gdbsupport/gdb-dlfcn.h'.
3917 * gdbsupport/common.m4: Check for 'dlfcn.h'.
3918 * gdb-dlfcn.c: Move to...
3919 * gdbsupport/gdb-dlfcn.c: ... here.
3920 * gdb-dlfcn.h: Move to...
3921 * gdbsupport/gdb-dlfcn.h: ... here.
3922
de8af808
SL
39232019-08-23 Sandra Loosemore <sandra@codesourcery.com>
3924
3925 * nios2-tdep.c (struct reg_value): Improve comments. Make
3926 the offset field signed.
3927
27204489
CB
39282019-08-22 Christian Biesinger <cbiesinger@google.com>
3929
3930 * python/lib/gdb/__init__.py (_execute_file): New function.
3931 * python/python.c (python_run_simple_file): Call gdb._execute_file
3932 on Windows.
3933
43771869
AB
39342019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
3935
3936 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3937 all uses as this was never set to anything but a zero value.
3938
26c957f1
PA
39392019-08-21 Bogdan Harjoc <harjoc@gmail.com>
3940
3941 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3942
c07aae6e
CB
39432019-08-21 Christian Biesinger <cbiesinger@google.com>
3944
3945 * tui/tui-data.h (tui_gen_win_info): Add an =default
3946 move constructor, required by some GCC versions.
3947
3960cb7a
JF
39482019-08-21 Jinke Fan <fanjinke51@yeah.net>
3949
3950 * go32-nat.c (go32_sysinfo): Add hygon_p.
3951
04c72a68
TT
39522019-08-20 Tom Tromey <tom@tromey.com>
3953
3954 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3955 line_from_reg_element_no, first_reg_element_no_inline,
3956 display_all_data, delete_data_content_windows,
3957 erase_data_content>: Now private.
3958
072272ce
TT
39592019-08-20 Tom Tromey <tom@tromey.com>
3960
3961 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3962 (tui_unhighlight_win, tui_highlight_win)
3963 (tui_win_info::make_window): Update.
3964 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3965
973961bd
TT
39662019-08-20 Tom Tromey <tom@tromey.com>
3967
3968 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3969 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3970 (MAX_PID_WIDTH): Move to tui-stack.c.
3971 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3972 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3973 (MAX_PID_WIDTH): Move from tui-data.h.
3974
ab0e1f1a
TT
39752019-08-20 Tom Tromey <tom@tromey.com>
3976
3977 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3978 * tui/tui-wingeneral.c (box_win): Change type of win_info.
3979 (box_win): Update.
3980 (tui_gen_win_info::make_window): Rename from tui_make_window.
3981 (tui_win_info::make_window): New method.
3982 (tui_gen_win_info::make_visible): Update.
3983 * tui/tui-source.c (tui_source_window::set_contents): Update.
3984 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3985 (tui_data_window::display_registers_from): Update.
3986 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3987 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3988 Declare.
3989 <can_box>: Remove.
3990 <title>: Remove.
3991 (struct tui_win_info) <make_window>: Declare.
3992 <can_box>: Now virtual.
3993 <title>: New member.
3994 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3995 * tui/tui-command.c (tui_cmd_window::resize): Update.
3996
100c2bf3
TT
39972019-08-20 Tom Tromey <tom@tromey.com>
3998
3999 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4000 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4001 (tui_data_window::check_register_values): Update.
4002
fa4dc567
TT
40032019-08-20 Tom Tromey <tom@tromey.com>
4004
4005 * tui/tui-regs.h (struct tui_data_window): Use
4006 DISABLE_COPY_AND_ASSIGN.
4007 <regs_content>: Change type, removing unique_ptr.
4008 <tui_data_window>: Add move constructor.
4009 * tui/tui-regs.c (tui_data_window::show_registers)
4010 (tui_data_window::show_register_group)
4011 (tui_data_window::display_registers_from)
4012 (tui_data_window::display_registers_from)
4013 (tui_data_window::first_data_item_displayed)
4014 (tui_data_window::delete_data_content_windows)
4015 (tui_data_window::rerender, tui_data_window::refresh_window)
4016 (tui_data_window::check_register_values): Update.
4017
ca02d7c8
TT
40182019-08-20 Tom Tromey <tom@tromey.com>
4019
4020 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4021 show_register_group>: Declare.
4022 (tui_show_register_group): Don't declare.
4023 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4024 tui_show_registers.
4025 (tui_data_window::show_register_group): Rename from
4026 tui_show_register_group.
4027 (tui_data_window::check_register_values, tui_reg_command):
4028 Update.
4029 * tui/tui-layout.c (tui_set_layout): Update.
4030
63356bfd
TT
40312019-08-20 Tom Tromey <tom@tromey.com>
4032
4033 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4034 Declare.
4035 (tui_check_register_values): Don't declare.
4036 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4037 from tui_check_register_values.
4038 * tui/tui-hooks.c (tui_register_changed): Update.
4039
42cc14a7
TT
40402019-08-20 Tom Tromey <tom@tromey.com>
4041
4042 * tui/tui-regs.c (tui_reg_layout): Move later.
4043 (tui_show_registers): Don't enable TUI mode or change layout.
4044
b9ad3686
TT
40452019-08-20 Tom Tromey <tom@tromey.com>
4046
4047 * tui/tui-regs.h (struct tui_data_item_window)
4048 <~tui_data_item_window>: Remove.
4049 <content>: Now a unique_xmalloc_ptr.
4050 * tui/tui-regs.c (tui_register_format): Return a
4051 unique_xmalloc_ptr.
4052 (tui_get_register): Update.
4053 (~tui_data_item_window): Remove.
4054 (tui_data_window::display_registers_from, tui_display_register):
4055 Update.
4056 * tui/tui-io.h (tui_expand_tabs): Update.
4057 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4058 Remove "col" parameter.
4059
8e114aab
TT
40602019-08-20 Tom Tromey <tom@tromey.com>
4061
4062 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4063 field.
4064 * tui/tui-regs.c (~tui_data_item_window): Update.
4065
1a4f81dd
TT
40662019-08-20 Tom Tromey <tom@tromey.com>
4067
4068 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4069 earlier.
4070
0f8d8876
TT
40712019-08-20 Tom Tromey <tom@tromey.com>
4072
4073 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4074
605dc2c2
TT
40752019-08-20 Tom Tromey <tom@tromey.com>
4076
4077 * tui/tui-source.h (struct tui_source_window): Update.
4078 * tui/tui-regs.c (tui_show_registers): Update.
4079 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4080 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4081 (NO_REGS_STRING): Remove defines.
4082
aedbe3bb
CM
40832019-08-20 Conrad Meyer <cem@FreeBSD.org>
4084
4085 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4086 unnecessary thread walk if remote doesn't support the packet.
4087
7ce8f214
TT
40882019-08-19 Tom Tromey <tromey@adacore.com>
4089
4090 * python/py-value.c (value_has_field): Fix indentation.
4091
f21c2bd7
TT
40922019-08-19 Tom Tromey <tromey@adacore.com>
4093
4094 * printcmd.c (do_one_display, info_display_command): Update.
4095 * block.h (contained_in): Return bool. Add allow_nested
4096 parameter.
4097 * block.c (contained_in): Return bool. Add allow_nested
4098 parameter.
4099
d806ea2d
TT
41002019-08-19 Tom Tromey <tom@tromey.com>
4101
4102 * configure: Rebuild.
4103 * configure.ac: Disallow the combination of -static-libstdc++ and
4104 source highlight.
4105 * source-cache.c (get_language_name): Handle rust.
4106 (source_cache::get_source_lines): Ignore highlighting exceptions.
4107
398fdd60
TT
41082019-08-16 Tom Tromey <tom@tromey.com>
4109
4110 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4111 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4112 (struct tui_source_window_base) <make_visible, refresh_window,
4113 resize>: Remove methods.
4114 <execution_info>: Remove field.
4115 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4116 (tui_show_source_line, tui_source_window_base)
4117 (~tui_source_window_base): Update.
4118 (tui_source_window_base::resize)
4119 (tui_source_window_base::make_visible)
4120 (tui_source_window_base::refresh_window): Remove.
4121 (tui_source_window_base::update_exec_info): Update.
4122 * tui/tui-source.c (tui_source_window::set_contents): Update.
4123 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4124
e699d331
TT
41252019-08-16 Tom Tromey <tom@tromey.com>
4126
4127 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4128 deprecated_query_hook.
4129
bb01dbfc
TT
41302019-08-16 Tom Tromey <tom@tromey.com>
4131
4132 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4133 (tui_update_source_windows_with_line): Update.
4134 * tui/tui-source.h (struct tui_source_window)
4135 <show_symtab_source>: Declare.
4136 (tui_show_symtab_source): Don't declare.
4137 * tui/tui-source.c (tui_show_symtab_source): Rename from
4138 tui_show_symtab_source.
4139
81c82c4b
TT
41402019-08-16 Tom Tromey <tom@tromey.com>
4141
4142 * tui/tui-winsource.h (struct tui_source_window_base)
4143 <set_contents>: Declare.
4144 * tui/tui-winsource.c
4145 (tui_source_window_base::update_source_window_as_is): Update.
4146 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4147 Declare.
4148 (tui_set_source_content): Don't declare.
4149 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4150 tui_set_source_content.
4151 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4152 Declare.
4153 (tui_set_disassem_content): Don't declare.
4154 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4155 tui_set_disassem_content.
4156
2ddaf614
TT
41572019-08-16 Tom Tromey <tom@tromey.com>
4158
4159 * tui/tui-winsource.h (struct tui_source_window_base)
4160 <update_breakpoint_info>: Declare.
4161 (tui_update_breakpoint_info): Don't declare.
4162 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4163 (tui_update_all_breakpoint_info): Update.
4164 (tui_source_window_base::update_breakpoint_info): Rename from
4165 tui_update_breakpoint_info.
4166 (tui_source_window_base::update_exec_info): Update.
4167
017f9828
TT
41682019-08-16 Tom Tromey <tom@tromey.com>
4169
4170 * tui/tui-winsource.h (struct tui_source_window_base)
4171 <update_source_window>: Declare.
4172 (tui_update_source_window): Don't declare.
4173 * tui/tui-winsource.c
4174 (tui_source_window_base::update_source_window): Rename from
4175 tui_update_source_window.
4176 (tui_source_window_base::rerender): Update.
4177 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4178 * tui/tui-disasm.c (tui_show_disassem)
4179 (tui_show_disassem_and_update_source)
4180 (tui_disasm_window::maybe_update): Update.
4181
ed8358e9
TT
41822019-08-16 Tom Tromey <tom@tromey.com>
4183
4184 * tui/tui-winsource.h (struct tui_source_window_base)
4185 <update_source_window_as_is>: Declare.
4186 (tui_update_source_window_as_is): Don't declare.
4187 * tui/tui-winsource.c (tui_update_source_window): Update
4188 (tui_source_window_base::update_source_window_as_is): Rename from
4189 tui_update_source_window_as_is.
4190 (tui_source_window_base::refill): Update.
4191 * tui/tui-source.c (tui_show_symtab_source): Update.
4192 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4193 Update.
4194
20149b6b
TT
41952019-08-16 Tom Tromey <tom@tromey.com>
4196
4197 * tui/tui-winsource.h (tui_update_source_window)
4198 (tui_update_source_window_as_is): Remove "noerror" parameter.
4199 * tui/tui-winsource.c (tui_update_source_window)
4200 (tui_update_source_window_as_is): Remove "noerror" parameter.
4201 (tui_update_source_windows_with_addr)
4202 (tui_update_source_windows_with_line)
4203 (tui_source_window_base::rerender)
4204 (tui_source_window_base::refill): Update.
4205 * tui/tui-source.h (tui_set_source_content)
4206 (tui_show_symtab_source): Remove "noerror" parameter.
4207 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4208 parameter.
4209 (tui_show_symtab_source): Likewise.
4210 (tui_source_window::maybe_update): Update.
4211 * tui/tui-disasm.c (tui_show_disassem)
4212 (tui_show_disassem_and_update_source)
4213 (tui_disasm_window::do_scroll_vertical)
4214 (tui_disasm_window::maybe_update): Update.
4215
2d83e710
TT
42162019-08-16 Tom Tromey <tom@tromey.com>
4217
4218 * tui/tui.c (tui_is_window_visible): Update.
4219 * tui/tui-wingeneral.c (tui_make_window)
4220 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4221 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4222 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4223 (tui_set_win_height_command, parse_scrolling_args): Update.
4224 * tui/tui-source.c (tui_source_window::style_changed): Update.
4225 * tui/tui-regs.c (tui_show_registers)
4226 (tui_data_window::first_data_item_displayed)
4227 (tui_data_window::delete_data_content_windows)
4228 (tui_check_register_values, tui_reg_command): Update.
4229 * tui/tui-disasm.c (tui_show_disassem): Update.
4230 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4231 method.
4232 <is_visible>: Remove field.
4233 * tui/tui-data.c (tui_next_win, tui_prev_win)
4234 (tui_delete_invisible_windows): Update.
4235
d4ab829a
TT
42362019-08-16 Tom Tromey <tom@tromey.com>
4237
4238 * tui/tui-winsource.h (struct tui_source_window_base)
4239 <m_has_locator>: Remove.
4240 * tui/tui-layout.c (show_source_disasm_command, show_data)
4241 (show_source_or_disasm_and_command): Update.
4242
aa7ca1bb
AH
42432019-08-16 Alan Hayward <alan.hayward@arm.com>
4244
4245 * NEWS (Other MI changes): New subsection.
4246 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4247 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4248 * arch-utils.c (default_get_pc_address_flags): New function.
4249 * arch-utils.h (default_get_pc_address_flags): New declaration.
4250 * gdbarch.sh: Add get_pc_address_flags.
4251 * gdbarch.c: Regenerate.
4252 * gdbarch.h: Likewise.
4253 * stack.c (print_pc): New function.
4254 (print_frame_info) (print_frame): Call print_pc.
4255
6eac171f
TV
42562019-08-16 Tom de Vries <tdevries@suse.de>
4257
4258 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4259 print_objfile_section_info.
4260
3df505f6
TT
42612019-08-15 Tom Tromey <tom@tromey.com>
4262
4263 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4264 calling update_cmdwin_start_line.
4265 * tui/tui-winsource.h (struct tui_source_window_base)
4266 <do_make_visible_with_new_height, set_new_height>: Don't declare.
4267 <rerender>: Declare.
4268 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4269 Call rerender.
4270 (tui_source_window_base::set_new_height): Remove.
4271 (tui_source_window_base::rerender): Rename from
4272 do_make_visible_with_new_height.
4273 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4274 resize method.
4275 (tui_win_info::make_invisible_and_set_new_height)
4276 (tui_win_info::make_visible_with_new_height): Remove.
4277 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4278 Declare.
4279 * tui/tui-stack.c (tui_locator_window::rerender): New method.
4280 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4281 do_make_visible_with_new_height>: Don't declare.
4282 <rerender>: Declare.
4283 * tui/tui-regs.c (tui_data_window::rerender): Rename from
4284 set_new_height.
4285 (tui_data_window::do_make_visible_with_new_height): Remove.
4286 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4287 call tui_show_locator_content.
4288 (tui_gen_win_info::resize): Call rerender.
4289 (show_source_or_disasm_and_command): Don't call
4290 tui_show_locator_content.
4291 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4292 method.
4293 (struct tui_win_info) <rerender>: Declare.
4294 <set_new_height, make_invisible_and_set_new_height,
4295 make_visible_with_new_height>: Don't declare.
4296 * tui/tui-data.c (tui_win_list::rerender): New method.
4297 * tui/tui-command.h (struct tui_cmd_window)
4298 <do_make_visible_with_new_height>: Don't declare.
4299 * tui/tui-command.c
4300 (tui_cmd_window::do_make_visible_with_new_height): Remove.
4301
272560b5
TT
43022019-08-15 Tom Tromey <tromey@adacore.com>
4303
4304 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4305 * ada-lang.c (ada_enum_name): Likewise.
4306
08235187
CB
43072019-08-15 Christian Biesinger <cbiesinger@google.com>
4308
4309 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4310 leading underscore.
4311 (GdbOutputErrorFile): Likewise.
4312 (global scope): Adjust constructor calls to GdbOutput{,Error}File
4313 accordingly.
4314 (execute_unwinders): Rename to have a leading underscore.
4315 (auto_load_packages): Likewise.
4316 (global scope): Adjust call to auto_load_packages accordingly.
4317 (GdbSetPythonDirectory): Likewise.
4318 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4319 instead of execute_unwinders.
4320
db502012
TT
43212019-08-15 Tom Tromey <tom@tromey.com>
4322
4323 * tui/tui-layout.c (show_layout, show_source_disasm_command)
4324 (show_data): Don't change window visibility.
4325 (tui_gen_win_info::resize): Remove special case for command
4326 window. Use wresize, when available.
4327 (show_source_or_disasm_and_command): Don't change window
4328 visibility.
4329 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4330 <make_visible>: New method.
4331 * tui/tui-command.c (tui_cmd_window::resize): New method.
4332
3891b65e
TT
43332019-08-15 Tom Tromey <tom@tromey.com>
4334
4335 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4336 (struct tui_source_windows): New.
4337 * tui/tui-winsource.c (tui_display_main): Update.
4338 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4339 (new_height_ok, parse_scrolling_args): Update.
4340 * tui/tui-layout.c (show_layout, show_data): Update.
4341 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4342 (tui_add_to_source_windows): Don't declare.
4343 * tui/tui-data.c (source_windows, tui_source_windows)
4344 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4345
ee556432
TT
43462019-08-15 Tom Tromey <tom@tromey.com>
4347
4348 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4349 Rename from reset.
4350 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4351 * tui/tui-layout.c (show_source_disasm_command, show_data):
4352 Update.
4353 (tui_gen_win_info::resize): Rename.
4354 (show_source_or_disasm_and_command): Update.
4355 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4356 reset.
4357
46f438e3
TT
43582019-08-15 Tom Tromey <tom@tromey.com>
4359
4360 * tui/tui-stack.c (tui_initialize_static_data): Remove.
4361 * tui/tui-interp.c (tui_interp::init): Don't call
4362 tui_initialize_static_data.
4363 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4364
f4ce562c
TT
43652019-08-15 Tom Tromey <tom@tromey.com>
4366
4367 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4368 examine tui_win_list.
4369
c398c3d0
TT
43702019-08-15 Tom Tromey <tom@tromey.com>
4371
4372 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4373 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4374 tui_clear_source_content.
4375 (tui_clear_source_content): Remove.
4376 (tui_source_window_base::do_erase_source_content): Hoist call to
4377 content.clear().
4378 * tui/tui-stack.c (tui_show_frame_info): Don't call
4379 tui_clear_source_content.
4380
e25d2004
TT
43812019-08-15 Tom Tromey <tom@tromey.com>
4382
4383 * tui/tui-winsource.h (struct tui_source_window_base)
4384 <do_erase_source_content>: New method.
4385 <erase_source_content>: New method.
4386 (tui_erase_source_content): Don't declare.
4387 * tui/tui-winsource.c (tui_clear_source_content): Update.
4388 (tui_source_window_base::do_erase_source_content): Rename from
4389 tui_erase_source_content.
4390 (tui_source_window_base::show_source_content): Update.
4391 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4392 * tui/tui-source.h (struct tui_source_window)
4393 <erase_source_content>: New method.
4394 * tui/tui-disasm.h (struct tui_disasm_window)
4395 <erase_source_content>: New method.
4396
002f15c2
TT
43972019-08-15 Tom Tromey <tom@tromey.com>
4398
4399 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4400 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4401 constructor.
4402 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4403 * tui/tui-source.c (tui_set_source_content): Update.
4404 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4405
c9033fe8
TT
44062019-08-15 Tom Tromey <tom@tromey.com>
4407
4408 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4409 * tui/tui-winsource.c (tui_line_is_displayed): Move to
4410 tui-source.c.
4411 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4412 Declare.
4413 * tui/tui-source.c (tui_source_window::line_is_displayed): New
4414 method.
4415 (tui_source_window::maybe_update): Update.
4416
088f37dd
TT
44172019-08-15 Tom Tromey <tom@tromey.com>
4418
4419 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4420 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4421 tui-disasm.c.
4422 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4423 Declare.
4424 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4425 method.
4426 (tui_disasm_window::maybe_update): Update.
4427
a54700c6
TT
44282019-08-15 Tom Tromey <tom@tromey.com>
4429
4430 * tui/tui-winsource.h (struct tui_source_window_base)
4431 <maybe_update>: Declare.
4432 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4433 method.
4434 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4435 Declare.
4436 * tui/tui-source.c (tui_source_window::maybe_update): New method.
4437 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4438 Declare.
4439 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4440
e2a678a5
TT
44412019-08-15 Tom Tromey <tom@tromey.com>
4442
4443 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4444
f2dda477
TT
44452019-08-15 Tom Tromey <tom@tromey.com>
4446
4447 * tui/tui-wingeneral.c: Include tui-stack.h.
4448 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4449 (struct tui_locator_window): Move from tui-data.h.
4450 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4451 (tui_initialize_static_data): Move from tui-data.c.
4452 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4453 (struct tui_locator_window): Move to tui-stack.c.
4454 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4455 (tui_initialize_static_data): Move to tui-stack.c.
4456
ed4a1084
TT
44572019-08-15 Tom Tromey <tom@tromey.com>
4458
4459 * tui/tui-layout.c (show_source_disasm_command)
4460 (show_source_or_disasm_and_command): Use make_visible method, not
4461 tui_make_window.
4462 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4463 Remove.
4464
65962b20
TT
44652019-08-15 Tom Tromey <tom@tromey.com>
4466
4467 * tui/tui-wingeneral.h (tui_make_window): Update.
4468 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4469 parameter.
4470 (tui_gen_win_info::make_visible): Update.
4471 * tui/tui-regs.c (tui_data_window::display_registers_from):
4472 Update.
4473 * tui/tui-layout.c (show_source_disasm_command)
4474 (show_source_or_disasm_and_command): Update.
4475 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4476 (enum tui_box): Remove.
4477 (struct tui_win_info) <can_box>: New method.
4478 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4479 method.
4480
2208ee91
TV
44812019-08-15 Tom de Vries <tdevries@suse.de>
4482
4483 * linux-nat-trad.c: Include gdbarch.h.
4484
75faf5c4
AH
44852019-08-14 Alan Hayward <alan.hayward@arm.com>
4486
4487 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4488 register sizes.
4489
b1c896b3
TT
44902019-08-14 Tom Tromey <tromey@adacore.com>
4491
4492 * darwin-nat.c: Include gdbarch.h.
4493 * darwin-nat-info.c: Include gdbarch.h.
4494
6405cd73
TT
44952019-08-13 Tom Tromey <tom@tromey.com>
4496
4497 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4498 Remove.
4499 * tui/tui-data.c (tui_initialize_static_data): Update.
4500
5216580d
TT
45012019-08-13 Tom Tromey <tom@tromey.com>
4502
4503 * tui/tui-winsource.h (struct tui_exec_info_window)
4504 <~tui_exec_info_window, maybe_allocate_content, get_content,
4505 m_content>: Remove.
4506 (struct tui_source_window_base) <set_exec_info_content,
4507 show_exec_info_content>: Don't declare.
4508 * tui/tui-winsource.c
4509 (tui_exec_info_window::maybe_allocate_content): Remove.
4510 (tui_source_window_base::update_exec_info): Rename from
4511 set_exec_info_content.
4512 (tui_source_window_base::show_exec_info_content)
4513 (tui_source_window_base::update_exec_info): Remove.
4514
93858ad3
TT
45152019-08-13 Tom Tromey <tom@tromey.com>
4516
4517 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4518 declare.
4519 * tui/tui-winsource.c (tui_update_source_window_as_is)
4520 (tui_update_source_windows_with_addr, tui_erase_source_content):
4521 Update.
4522 (tui_clear_exec_info_content): Remove.
4523
e321e7ce
TT
45242019-08-13 Tom Tromey <tom@tromey.com>
4525
4526 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4527 declare.
4528 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4529 call tui_erase_exec_info_content.
4530 (tui_clear_exec_info_content): Rename from
4531 tui_erase_exec_info_content.
4532 (tui_clear_exec_info_content): Delete.
4533
8270ac62
TT
45342019-08-13 Tom Tromey <tom@tromey.com>
4535
4536 * tui/tui-winsource.h (struct tui_source_window_base)
4537 <show_exec_info_content>: Declare.
4538 (tui_show_exec_info_content): Don't declare.
4539 * tui/tui-winsource.c
4540 (tui_source_window_base::show_exec_info_content): Rename from
4541 tui_show_exec_info_content.
4542 (tui_source_window_base::update_exec_info): Update.
4543
7b56485d
TT
45442019-08-13 Tom Tromey <tom@tromey.com>
4545
4546 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4547 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4548 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4549 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4550 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4551 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4552 ... here.
4553
7ba913dc
TT
45542019-08-13 Tom Tromey <tom@tromey.com>
4555
4556 * tui/tui-winsource.h (struct tui_source_window_base)
4557 <update_exec_info>: Declare.
4558 (tui_update_exec_info): Don't declare.
4559 * tui/tui-winsource.c (tui_update_source_window_as_is)
4560 (tui_source_window_base::refresh_all)
4561 (tui_update_all_breakpoint_info): Update.
4562 (tui_source_window_base::update_exec_info): Rename from
4563 tui_update_exec_info.
4564 * tui/tui-stack.c (tui_show_frame_info): Update.
4565
37a4a131
TT
45662019-08-13 Tom Tromey <tom@tromey.com>
4567
4568 * tui/tui-winsource.h (struct tui_source_window_base)
4569 <set_exec_info_content>: Declare.
4570 (tui_set_exec_info_content): Don't declare.
4571 * tui/tui-winsource.c
4572 (tui_source_window_base::set_exec_info_content): Rename from
4573 tui_set_exec_info_content.
4574 (tui_update_exec_info): Update.
4575
0bd27e07
TT
45762019-08-13 Tom Tromey <tom@tromey.com>
4577
4578 * tui/tui-winsource.h (struct tui_source_window_base)
4579 <show_source_content>: Declare.
4580 (tui_show_source_content): Don't declare.
4581 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4582 (tui_source_window_base::show_source_content): Rename from
4583 tui_show_source_content.
4584 (tui_source_window_base::refresh_all): Update.
4585 * tui/tui-layout.c (show_source_disasm_command)
4586 (show_source_or_disasm_and_command): Update.
4587
b4ef5aeb
TT
45882019-08-13 Tom Tromey <tom@tromey.com>
4589
4590 * tui/tui-winsource.c (tui_erase_source_content)
4591 (tui_show_source_content, tui_source_window_base::refresh_all):
4592 Update.
4593 * tui/tui-wingeneral.h
4594 (tui_check_and_display_highlight_if_needed): Don't declare.
4595 * tui/tui-wingeneral.c
4596 (tui_win_info::check_and_display_highlight_if_needed): Rename from
4597 check_and_display_highlight_if_needed.
4598 * tui/tui-win.c (tui_rehighlight_all)
4599 (tui_win_info::make_visible_with_new_height): Update.
4600 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4601 (tui_data_window::erase_data_content)
4602 (tui_data_window::display_all_data): Update.
4603 * tui/tui-data.h (struct tui_win_info)
4604 <check_and_display_highlight_if_needed>: Declare.
4605
fede5273
TT
46062019-08-13 Tom Tromey <tom@tromey.com>
4607
4608 * tui/tui-win.c (tui_resize_all): Call
4609 tui_delete_invisible_windows.
4610 * tui/tui-layout.c (show_layout): Call
4611 tui_delete_invisible_windows.
4612 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4613 * tui/tui-data.c (tui_delete_invisible_windows): New function.
4614
22c3f490
TT
46152019-08-13 Tom Tromey <tom@tromey.com>
4616
4617 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
4618 tui_add_win_to_layout.
4619
16cb7910
TT
46202019-08-13 Tom Tromey <tom@tromey.com>
4621
4622 * tui/tui-layout.h (tui_default_win_height): Don't declare.
4623 * tui/tui-layout.c (tui_default_win_height): Now static.
4624
cc0c3ffb
TT
46252019-08-13 Tom Tromey <tom@tromey.com>
4626
4627 * tui/tui-layout.c (show_layout): Unify all layout cases into a
4628 single switch.
4629 (show_source_disasm_command, show_source_or_disasm_and_command):
4630 Don't check current layout.
4631
3f3ffe54
TT
46322019-08-13 Tom Tromey <tom@tromey.com>
4633
4634 * tui/tui-wingeneral.c (make_all_visible): Remove.
4635 (tui_make_all_invisible): Simplify.
4636 * tui/tui-layout.c (tui_make_all_invisible): Move from
4637 tui-wingeneral.c; simplify.
4638 (show_layout): Hoist call to tui_make_all_invisible.
4639 (show_data): Don't call tui_make_all_invisible.
4640
69258091
TT
46412019-08-13 Tom Tromey <tom@tromey.com>
4642
4643 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4644 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4645
62cf57fe
TT
46462019-08-13 Tom Tromey <tom@tromey.com>
4647
4648 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4649 tui-data.c.
4650 (show_source_disasm_command, show_data)
4651 (show_source_or_disasm_and_command): Don't use
4652 tui_set_current_layout_to.
4653 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4654 * tui/tui-data.c (current_layout, tui_current_layout): Move to
4655 tui-layout.c.
4656 (tui_set_current_layout_to): Remove.
4657
2afade5d
TT
46582019-08-13 Tom Tromey <tom@tromey.com>
4659
4660 * tui/tui-layout.c (tui_set_layout): Update.
4661 * tui/tui-data.h (struct tui_layout_def): Remove.
4662 (tui_layout_def): Don't declare.
4663 * tui/tui-data.c (layout_def): Remove.
4664 (tui_layout_def): Remove.
4665
a3504e96
TT
46662019-08-13 Tom Tromey <tom@tromey.com>
4667
4668 * tui/tui-winsource.h (struct tui_source_window_base)
4669 <clear_detail>: No longer "override".
4670 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4671 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4672 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4673 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4674 Remove.
4675 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4676
29c92911
TT
46772019-08-13 Tom Tromey <tromey@adacore.com>
4678
4679 * tracepoint.c: Don't include readline.h or history.h.
4680
86c6b807
TT
46812019-08-12 Tom Tromey <tom@tromey.com>
4682
4683 * configure: Rebuild.
4684 * configure.ac: Check for readline 7.
4685 * NEWS: Mention readline 7 requirement.
4686 * README: Update.
4687
5db2718c
TT
46882019-08-12 Tom Tromey <tom@tromey.com>
4689
4690 * mingw-hdep.c (gdb_select): Remove readline hack.
4691
dac36daf
PFC
46922019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
4693
4694 * blockframe.c (find_pc_partial_function): Set *block to nullptr
4695 when the function fails.
4696
1022c627
AA
46972019-08-09 Andreas Arnez <arnez@linux.ibm.com>
4698
4699 * s390-tdep.c (s390_type_align): New function.
4700 (s390_gdbarch_init): Set it as type_align gdbarch method.
4701
eba4caf2
TV
47022019-08-09 Tom de Vries <tdevries@suse.de>
4703
4704 PR gdb/24591
4705 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4706 pc_low with relocation offset.
4707
123cd851
TT
47082019-08-07 Tom Tromey <tromey@adacore.com>
4709
4710 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4711 (print_frame_args): Update.
4712 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4713 Update.
4714 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4715 * frame.h (struct frame_arg): Add initializers.
4716 <error>: Now a unique_xmalloc_ptr.
4717
3d31bc39
AH
47182019-08-07 Alan Hayward <alan.hayward@arm.com>
4719
4720 * NEWS: Expand the Pointer Authentication entry.
4721 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4722 (aarch64_frame_unmask_lr): ... to this.
4723 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4724 Call aarch64_frame_unmask_lr.
4725 * frame.c (struct frame_info): Add "masked" variable.
4726 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4727 (fprint_frame): Check for masked pc.
4728 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4729 declarations.
4730 * python/py-framefilter.c (py_print_frame): Check for masked pc.
4731 * stack.c (print_frame): Check for masked pc.
4732
0cf9feb9
TT
47332019-08-06 Tom Tromey <tom@tromey.com>
4734
4735 * stabsread.c (patch_block_stabs, read_one_struct_field)
4736 (read_enum_type): Use obstack_strndup.
4737 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4738 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4739 * dwarf2read.c (guess_full_die_structure_name)
4740 (anonymous_struct_prefix): Use obstack_strndup.
4741 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4742 * c-exp.y (yylex): Use obstack_strndup.
4743 * ada-exp.y (write_object_renaming, write_ambiguous_var)
4744 (write_var_or_type): Use obstack_strndup.
4745
efba19b0
TT
47462019-08-06 Tom Tromey <tom@tromey.com>
4747
4748 * symfile.c (reread_symbols): Use obstack_strdup.
4749 * stabsread.c (read_type): Use obstack_strdup.
4750 * gdb_obstack.h (obstack_strdup): New overload.
4751 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4752 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4753 (dwarf2_canonicalize_name): Use obstack_strdup.
4754 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4755 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4756 Use obstack_strdup.
4757
f25102f7
TT
47582019-08-06 Tom Tromey <tom@tromey.com>
4759
4760 * gdb_obstack.h (obstack_strdup): Define.
4761 * gdb_obstack.c (obstack_strdup): Don't define.
4762
021887d8
TT
47632019-08-06 Tom Tromey <tom@tromey.com>
4764
4765 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4766 obstack_strdup.
4767 * typeprint.c (typedef_hash_table::find_global_typedef): Use
4768 obstack_strdup.
4769 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4770 * stabsread.c (common_block_start): Use obstack_strdup.
4771 * objfiles.c (set_objfile_main_name, objfile): Use
4772 obstack_strdup.
4773 * namespace.c (add_using_directive): Use obstack_strdup.
4774 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4775 * jit.c (finalize_symtab): Use obstack_strdup.
4776 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4777 (guess_partial_die_structure_name, partial_die_info::fixup)
4778 (dwarf2_name): Use obstack_strdup.
4779 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4780 obstack_strdup.
4781 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4782 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4783 obstack_strdup.
4784 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4785
d2834edc
PW
47862019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4787
4788 * unittests/help-doc-selftests.c: New file.
4789 * Makefile.in: Add the new file.
4790
590042fc
PW
47912019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4792
4793 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4794 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
4795 the full first line, except when FOR_VALUE_PREFIX. In this case,
4796 the trailing '.' is not output, and the first character is uppercased.
4797 (print_help_for_command): Update call to print_doc_line.
4798 (print_doc_of_command): Likewise.
4799 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4800 * cli/cli-option.c (append_indented_doc): Do not append newline.
4801 (build_help_option): Append newline after first appended_indented_doc
4802 only if a second call is done.
4803 (build_help): Append 2 new lines before each option, except the first
4804 one.
4805 * compile/compile.c (_initialize_compile): Add new lines after
4806 %OPTIONS%, when not at the end of the help.
4807 Change help doc or code
4808 producing the help doc to respect the invariants.
4809 * maint-test-options.c (_initialize_maint_test_options): Likewise.
4810 Also removed the new line after 'Options:', as all other commands
4811 do not put an empty line between 'Options:' and the first option.
4812 * printcmd.c (_initialize_printcmd): Likewise.
4813 * stack.c (_initialize_stack): Likewise.
4814 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4815 incorrectly telling COMMAND is optional.
4816 * ada-lang.c (_initialize_ada_language): Change help doc or code
4817 producing the help doc to respect the invariants.
4818 * ada-tasks.c (_initialize_ada_tasks): Likewise.
4819 * breakpoint.c (_initialize_breakpoint): Likewise.
4820 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4821 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4822 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4823 * cli/cli-style.c (cli_style_option::add_setshow_commands,
4824 _initialize_cli_style): Likewise.
4825 * corelow.c (core_target_info): Likewise.
4826 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4827 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4828 * filesystem.c (_initialize_filesystem): Likewise.
4829 * frame.c (_initialize_frame): Likewise.
4830 * gnu-nat.c (add_task_commands): Likewise.
4831 * infcall.c (_initialize_infcall): Likewise.
4832 * infcmd.c (_initialize_infcmd): Likewise.
4833 * interps.c (_initialize_interpreter): Likewise.
4834 * language.c (_initialize_language): Likewise.
4835 * linux-fork.c (_initialize_linux_fork): Likewise.
4836 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4837 * maint.c (_initialize_maint_cmds): Likewise.
4838 * memattr.c (_initialize_mem): Likewise.
4839 * printcmd.c (_initialize_printcmd): Likewise.
4840 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4841 _RegEx): Likewise.
4842 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4843 * record-btrace.c (_initialize_record_btrace): Likewise.
4844 * record-full.c (_initialize_record_full): Likewise.
4845 * record.c (_initialize_record): Likewise.
4846 * regcache-dump.c (_initialize_regcache_dump): Likewise.
4847 * regcache.c (_initialize_regcache): Likewise.
4848 * remote.c (add_packet_config_cmd, init_remote_threadtests,
4849 _initialize_remote): Likewise.
4850 * ser-tcp.c (_initialize_ser_tcp): Likewise.
4851 * serial.c (_initialize_serial): Likewise.
4852 * skip.c (_initialize_step_skip): Likewise.
4853 * source.c (_initialize_source): Likewise.
4854 * stack.c (_initialize_stack): Likewise.
4855 * symfile.c (_initialize_symfile): Likewise.
4856 * symtab.c (_initialize_symtab): Likewise.
4857 * target-descriptions.c (_initialize_target_descriptions): Likewise.
4858 * top.c (init_main): Likewise.
4859 * tracefile-tfile.c (tfile_target_info): Likewise.
4860 * tracepoint.c (_initialize_tracepoint): Likewise.
4861 * tui/tui-win.c (_initialize_tui_win): Likewise.
4862 * utils.c (add_internal_problem_command): Likewise.
4863 * valprint.c (value_print_option_defs): Likewise.
4864
404f2902
FCE
48652019-08-06 Frank Ch. Eigler <fche@redhat.com>
4866
4867 PR build/24886
4868 * configure.ac: Drop enable-libmcheck support.
4869 * configure, config.in: Rebuild.
4870 * libmcheck.m4: Remove.
4871 * acinclude.m4: Don't include it.
4872 * Makefile.in: Don't distribute it.
4873 * top.c (print_gdb_configuration): Don't mention it.
4874
046bebe1
TT
48752019-08-06 Tom Tromey <tom@tromey.com>
4876
4877 * utils.c (set_output_style): Sometimes pass stream to
4878 emit_style_escape.
4879 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4880 * record-btrace.c (btrace_insn_history): Update.
4881 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4882 method.
4883 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4884 Update initializers.
4885 <m_uiout>: New field.
4886 <m_di>: Move lower.
4887 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4888 Remove "uiout" parameter.
4889 (dump_insns): Update.
4890 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4891 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4892
ddbcedf5
CB
48932019-08-06 Christian Biesinger <cbiesinger@google.com>
4894
4895 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4896 (error_in_psymtab_expansion): Likewise.
4897 (lookup_symbol_via_quick_fns): Likewise.
4898 (basic_lookup_transparent_type_quick): Likewise.
4899 (basic_lookup_transparent_type_1): Likewise.
4900
b08b16c8
TT
49012019-08-06 Tom Tromey <tromey@adacore.com>
4902
4903 * source.c (last_source_error): Now bool.
4904 (print_source_lines_base): Make "noprint" bool. Only open
4905 source file when last_source_visited changes.
4906
cb44333d
TT
49072019-08-06 Tom Tromey <tromey@adacore.com>
4908
4909 * annotate.c (annotate_source_line): Use g_source_cache.
4910 * source-cache.c (source_cache::get_plain_source_lines): Change
4911 parameters. Populate m_offset_cache.
4912 (source_cache::ensure): New method.
4913 (source_cache::get_line_charpos): New method.
4914 (extract_lines): Move lower. Change parameters.
4915 (source_cache::get_source_lines): Move lower.
4916 * source-cache.h (class source_cache): Update comment.
4917 <get_line_charpos>: New method.
4918 <get_source_lines>: Update comment.
4919 <clear>: Clear m_offset_cache.
4920 <get_plain_source_lines>: Change parameters.
4921 <ensure>: New method
4922 <m_offset_cache>: New member.
4923 * source.c (forget_cached_source_info_for_objfile): Update.
4924 (info_source_command): Use g_source_cache.
4925 (find_source_lines, open_source_file_with_line_charpos): Remove.
4926 (print_source_lines_base, search_command_helper): Use g_source_cache.
4927 * source.h (open_source_file_with_line_charpos): Don't declare.
4928 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4929 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4930 Use g_source_cache.
4931
872dceaa
TT
49322019-08-06 Tom Tromey <tromey@adacore.com>
4933
4934 * source-cache.c (source_cache::get_plain_source_lines):
4935 Remove "first_line" and "last_line" parameters.
4936 (source_cache::get_source_lines): Cache plain text.
4937 * source-cache.h (class source_cache)
4938 <get_plain_source_lines>: Update.
4939
269249d9
TT
49402019-08-06 Tom Tromey <tromey@adacore.com>
4941
4942 * source-cache.c (extract_lines): No longer a method.
4943 Changed type of parameter. Include final newline.
4944 (selftests::extract_lines_test): New function.
4945 (_initialize_source_cache): Likewise.
4946 * source-cache.h (class source_cache)
4947 <extract_lines>: Don't declare.
4948
c0e8dcd8
TT
49492019-08-06 Tom Tromey <tromey@adacore.com>
4950
4951 * breakpoint.c (init_breakpoint_sal): Update.
4952 (breakpoint): Update.
4953 * breakpoint.h (struct breakpoint) <filter>: Now a
4954 unique_xmalloc_ptr.
4955
0b27c27d
CB
49562019-08-05 Christian Biesinger <cbiesinger@google.com>
4957
4958 * NEWS: Mention dictionary access on blocks.
4959 * python/py-block.c (blpy_getitem): New function.
4960 (block_object_as_mapping): New struct.
4961 (block_object_type): Use new struct for tp_as_mapping field.
4962
4ee94178
CB
49632019-08-05 Christian Biesinger <cbiesinger@google.com>
4964
4965 * objfiles.h (objfile): Add a comment describing partial symbols.
4966
8abfcabc
TT
49672019-08-05 Tom Tromey <tromey@adacore.com>
4968
4969 * compile/compile.c (_initialize_compile): Use _(), not N_().
4970 * thread.c (_initialize_thread): Use _(), not N_().
4971 * stack.c (_initialize_stack): Use _(), not N_().
4972 * printcmd.c (_initialize_printcmd): Use _(), not N_().
4973
2b79f376
SM
49742019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
4975
4976 * dwarf2read.c (struct dw2_symtab_iterator):
4977 <want_specific_block>: Remove.
4978 <block_index>: Change type to gdb::optional.
4979 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4980 change type of BLOCK_INDEX parameter to gdb::optional.
4981 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4982 (dw2_lookup_symbol): Don't pass argument for
4983 WANT_SPECIFIC_BLOCK.
4984 (dw2_expand_symtabs_for_function): Don't pass argument for
4985 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4986 (class dw2_debug_names_iterator)
4987 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4988 parameter, change BLOCK_INDEX type to gdb::optional.
4989 <m_want_specific_block>: Remove.
4990 <m_block_index>: Change type to gdb::optional.
4991 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4992 gdb::optional. Re-write in function of gdb::optional.
4993 (dw2_debug_names_lookup_symbol): Don't pass argument for
4994 WANT_SPECIFIC_BLOCK.
4995 (dw2_debug_names_expand_symtabs_for_function): Don't pass
4996 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4997 BLOCK_INDEX.
4998
ae60f04e
PW
49992019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5000
5001 * NEWS: Mention changes to "info sources" command.
5002
28cd9371
PW
50032019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5004
5005 * symtab.c (filename_partial_match_opts): New struct type.
5006 (struct output_source_filename_data): New members
5007 regexp, c_regexp, partial_match.
5008 (output_source_filename): Use new members to decide to print file.
5009 (info_sources_option_defs): New variable.
5010 (make_info_sources_options_def_group, print_info_sources_header,
5011 info_sources_command_completer):
5012 New functions.
5013 (info_sources_command): Read new optional arguments.
5014 (_initialize_symtab): Update info sources help.
5015
ca683e3a
AO
50162019-08-02 Alexandre Oliva <oliva@adacore.com>
5017
5018 * ada-lang.c (exception_support_info_v0): Renamed from...
5019 (default_exception_support_info): ... this. Create new
5020 definition for v1.
5021 (ada_has_this_exception_support): Look up catch_handlers_sym.
5022 (ada_exception_support_info_sniffer): Try v0 after default.
5023
f1264162
TT
50242019-08-01 Tom Tromey <tromey@adacore.com>
5025
5026 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5027 gdbarch.h.
5028
0a7b2485
CB
50292019-08-01 Christian Biesinger <cbiesinger@google.com>
5030
5031 * s12z-tdep.c: Fix include path for s12z-opc.h.
5032
c6bdbeb7
AH
50332019-08-01 Alan Hayward <alan.hayward@arm.com>
5034
5035 * NEWS: Require GNU make 3.82.
5036
a2bd7b82
TT
50372019-07-16 Tom Tromey <tom@tromey.com>
5038
5039 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5040 declare.
5041
aa3b6533
TT
50422019-07-30 Tom Tromey <tromey@adacore.com>
5043
5044 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5045
a1530dc7
KB
50462019-07-30 Kevin Buettner <kevinb@redhat.com>
5047
5048 * printcmd.c (print_address_symbolic): Print negative offsets.
5049 (build_address_symbolic): Force signed arithmetic when computing
5050 offset.
5051
2906593f
CB
50522019-07-30 Christian Biesinger <cbiesinger@google.com>
5053
5054 PR/24474: Add a function to lookup static variables.
5055 * NEWS: Mention this new function.
5056 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5057 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5058 * python/python.c (python_GdbMethods): Add new function.
5059
c620ed88
CB
50602019-07-29 Christian Biesinger <cbiesinger@google.com>
5061
5062 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5063 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5064 (objfpy_lookup_static_symbol): New function.
5065 (objfile_object_methods): Add new functions.
5066
bc4268a5
PW
50672019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5068
5069 * NEWS: Mention 'set|show print frame-info'. Mention new
5070 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5071 backtrace argument. Mention that python frame filtering code
5072 is now consistent with what 'backtrace' command prints.
5073
4b5e8d19
PW
50742019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5075
5076 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5077 comments.
5078 (print_frame_info_auto, print_frame_info_source_line,
5079 print_frame_info_location, print_frame_info_source_and_location,
5080 print_frame_info_location_and_address, print_frame_info_short_location):
5081 New declarations.
5082 (struct frame_print_options): New member print_frame_info.
5083 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5084 * stack.h (get_user_print_what_frame_info): New declaration.
5085 (frame_show_address): New declaration.
5086 * stack.c (print_frame_arguments_choices): New value 'presence'.
5087 (print_frame_info_auto, print_frame_info_source_line,
5088 print_frame_info_location, print_frame_info_source_and_location,
5089 print_frame_info_location_and_address, print_frame_info_short_location,
5090 print_frame_info_choices, print_frame_info_print_what): New definitions.
5091 (print_frame_args): Only print dots for args if print frame-arguments
5092 is 'presence'.
5093 (frame_print_option_defs): New element for "frame-info".
5094 (get_user_print_what_frame_info): New function.
5095 (frame_show_address): Make non static. Move comment to stack.h.
5096 (print_frame_info_to_print_what): New function.
5097 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5098 to decide what to print.
5099 (backtrace_command_1): Handle the new print_frame_arguments_presence
5100 value.
5101 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5102 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5103 (py_print_frame): In non-mi mode, use LOCATION as default for
5104 print_what, similarly to frame information printed directly by
5105 backtrace command. Handle frame-info user option in non MI mode.
5106
6bdfee81
KB
51072019-07-27 Kevin Buettner <kevinb@redhat.com>
5108
5109 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5110 Add case for debugging 32-bit target on 64-bit host. Revise
5111 comment.
5112
98a617f8
KB
51132019-07-27 Kevin Buettner <kevinb@redhat.com>
5114
5115 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5116 instead of find_function_entry_range_from_pc.
5117
567238c9
KB
51182019-07-27 Kevin Buettner <kevinb@redhat.com>
5119
5120 * stack.c (find_frame_funname): Remove code which preferred
5121 minsym over symtab sym in "certain pathological cases".
5122
2dc80cf8
KB
5123 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5124 parameter. Change type of "do_demangle" to bool.
5125 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5126 Pass suitable "prefer_sym_over_minsym" flag to
5127 build_address_symbolic(). Don't output "+" for negative offsets.
5128 * printcmd.c (print_address_symbolic): Update invocation of
5129 build_address_symbolic to include a "prefer_sym_over_minsym"
5130 flag.
5131 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5132 Restrict cases in which use of minimal symbol is preferred to that
5133 of a found symbol. Update comments.
5134
1aff7173
KB
5135 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5136 for entry pc when entry pc is out of range for that FDE.
5137
89b085ac
BC
51382019-07-26 Brian Callahan <bcallah@openbsd.org>
5139
5140 PR gdb/24839:
5141 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5142 type.
5143
f32feb4a
CB
51442019-07-25 Christian Biesinger <cbiesinger@google.com>
5145
5146 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5147 this function's Python signature.
5148
5149
51502019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
5151
5152 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5153 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5154 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5155 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5156 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5157
5158
c54e4253
YS
51592019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5160
5161 * h8300-tdep.c (h8300_register_name_common): New.
5162 h8300_register_name): Use h8300_register_name_common.
5163 (h8300s_register_name): Likewise.
5164 (h8300sx_register_name): Likewise.
5165 (h8300h_register_nam): New.
5166 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5167
5168
40eadf04
SP
51692019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5170
5171 * arm-tdep.c (arm_skip_cmse_entry): New function.
5172 (arm_is_sgstubs_section): New function.
5173 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5174
bfa2a36d
TT
51752019-07-22 Tom Tromey <tom@tromey.com>
5176
5177 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5178 Don't self-assign.
5179
a8e9d247
AB
51802019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5181
5182 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5183 type_print.
5184
eb86c5e2
AB
51852019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5186
5187 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5188 so that GDB doesn't match any msymbols when searching in the
5189 TYPES_DOMAIN.
5190 (print_symbol_info): Print using typedef_print or type_print based
5191 on the type of the symbol. Add updated FIXME comment moved from...
5192 (_initialize_symtab): ... move and update FIXME comment to above.
5193
a8eab7c6
AB
51942019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5195
5196 * NEWS: Mention adding -q option to "info types".
5197 * symtab.c (struct info_types_options): New struct.
5198 (info_types_options_defs): New variable.
5199 (make_info_types_options_def_group): New function.
5200 (info_types_command): Use gdb::option framework to parse options.
5201 (info_types_command_completer): New function.
5202 (_initialize_symtab): Extend the help text on "info types" and
5203 register command completer.
5204
b4603c34
CB
52052019-07-21 Christian Biesinger <cbiesinger@google.com>
5206
5207 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5208 (lookup_symbol_in_objfile): Change int to block_enum and add a
5209 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5210
c8cdc1e0
CB
52112019-07-20 Christian Biesinger <cbiesinger@google.com>
5212
5213 * MAINTAINERS (Write After Approval): Add self.
5214
01e175fe
AB
52152019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5216
5217 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5218 instruction to the dummy code region.
5219
56f79b63
TT
52202019-07-19 Tom Tromey <tromey@adacore.com>
5221
5222 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5223 (ARGSUSED, PARAMS, __func__): Remove rules.
5224
4c5aa8e0
AH
52252019-07-19 Alan Hayward <alan.hayward@arm.com>
5226
5227 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5228 * features/arm/arm-with-iwmmxt.c: Remove.
5229 * features/arm/arm-with-iwmmxt.xml: Remove.
5230 * features/arm/arm-with-m-fpa-layout.c: Remove.
5231 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5232 * features/arm/arm-with-m-vfp-d16.c: Remove.
5233 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5234 * features/arm/arm-with-m.c: Remove.
5235 * features/arm/arm-with-m.xml: Remove.
5236 * features/arm/arm-with-neon.c: Remove.
5237 * features/arm/arm-with-neon.xml: Remove.
5238 * features/arm/arm-with-vfpv2.c: Remove.
5239 * features/arm/arm-with-vfpv2.xml: Remove.
5240 * features/arm/arm-with-vfpv3.c: Remove.
5241 * features/arm/arm-with-vfpv3.xml: Remove.
5242
f42b2617
AH
52432019-07-19 Alan Hayward <alan.hayward@arm.com>
5244
5245 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5246
f29ec966
AH
52472019-07-19 Alan Hayward <alan.hayward@arm.com>
5248
5249 * arch/aarch32.c (aarch32_create_target_description): Create
5250 target descriptions using features.
5251 * arch/arm.c (arm_create_target_description)
5252 (arm_create_mprofile_target_description): Likewise.
5253 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5254
d105cce5
AH
52552019-07-19 Alan Hayward <alan.hayward@arm.com>
5256
5257 * Makefile.in: Add new files.
5258 * aarch32-tdep.c: New file.
5259 * aarch32-tdep.h: New file.
5260 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5261 Call aarch32_read_description.
5262 * arch/aarch32.c: New file.
5263 * arch/aarch32.h: New file.
5264 * arch/arm.c (arm_create_target_description)
5265 (arm_create_mprofile_target_description): New function.
5266 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5267 (arm_create_target_description)
5268 (arm_create_mprofile_target_description): New declaration.
5269 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5270 read_description functions.
5271 * arm-linux-nat.c (arm_linux_nat_target::read_description):
5272 Likewise.
5273 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5274 * arm-tdep.c (tdesc_arm_list): New variable.
5275 (arm_register_g_packet_guesses): Call create description functions.
5276 (arm_read_description) (arm_read_mprofile_description): New
5277 function.
5278 * arm-tdep.h (arm_read_description)
5279 (arm_read_mprofile_description): Add declaration.
5280 * configure.tgt: Add new files.
5281
afe09f0b
GL
52822019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
5283
5284 * top.c (new_ui_command): Open specified terminal just once.
5285
cd215b2e
TT
52862019-07-18 Tom Tromey <tromey@adacore.com>
5287
5288 * symtab.c (main_name): Constify return type.
5289 * symfile.c (set_initial_language): Update.
5290 * symtab.h (main_name): Constify return type.
5291
d8f68fcb
TT
52922019-07-17 Tom Tromey <tom@tromey.com>
5293
5294 * tui/tui-winsource.c (tui_update_source_window)
5295 (tui_update_source_window_as_is)
5296 (tui_update_source_windows_with_line): Remove return.
5297 * tui/tui-disasm.c (tui_show_disassem)
5298 (tui_show_disassem_and_update_source): Remove return.
5299 * tui/tui.c (tui_reset): Remove return.
5300 * tui/tui-wingeneral.c
5301 (tui_check_and_display_highlight_if_needed): Remove return.
5302
ca5af91e
TT
53032019-07-17 Tom Tromey <tom@tromey.com>
5304
5305 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5306
5104fe36
TT
53072019-07-17 Tom Tromey <tom@tromey.com>
5308
5309 * tui/tui-winsource.h (struct tui_exec_info_window)
5310 (struct tui_source_window_base): Move from tui-data.h.
5311 * tui/tui-winsource.c: Move many method definitions from
5312 elsewhere. Remove "structuring" comments.
5313 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5314 (tui_source_window_base::refresh_window): Move to
5315 tui-winsource.c.
5316 * tui/tui-win.c (tui_source_window_base::refresh_all)
5317 (tui_source_window_base::update_tab_width)
5318 (tui_source_window_base::set_new_height)
5319 (tui_source_window_base::do_make_visible_with_new_height): Move to
5320 tui-winsource.c.
5321 * tui/tui-source.h: Update.
5322 * tui/tui-source.c (tui_source_window_base::reset): Move to
5323 tui-winsource.c.
5324 * tui/tui-disasm.h: Update.
5325 * tui/tui-data.h (struct tui_exec_info_window): Move to
5326 tui-winsource.h.
5327 (struct tui_source_window_base): Likewise.
5328 * tui/tui-data.c (tui_source_window_base::clear_detail)
5329 (tui_source_window_base, ~tui_source_window_base): Move to
5330 tui-winsource.c.
5331
daa15dde
TT
53322019-07-17 Tom Tromey <tom@tromey.com>
5333
5334 * tui/tui-win.c (tui_resize_all)
5335 (tui_source_window_base::update_tab_width)
5336 (tui_adjust_win_heights): Update.
5337 (tui_win_info::make_invisible_and_set_new_height): Rename from
5338 make_invisible_and_set_new_height.
5339 * tui/tui-data.h (struct tui_win_info)
5340 <make_invisible_and_set_new_height>: New method.
5341
bfad4537
TT
53422019-07-17 Tom Tromey <tom@tromey.com>
5343
5344 * tui/tui.c: Update.
5345 * tui/tui-source.h (struct tui_source_window): Move from
5346 tui-data.h.
5347 * tui/tui-layout.c: Update.
5348 * tui/tui-disasm.c: Update.
5349 * tui/tui-data.h (struct tui_source_window): Move to
5350 tui-source.h.
5351
88f7e873
TT
53522019-07-17 Tom Tromey <tom@tromey.com>
5353
5354 * tui/tui-disasm.h (struct tui_disasm_window): Move from
5355 tui-data.h.
5356 * tui/tui-data.h (struct tui_disasm_window): Move to
5357 tui-disasm.h.
5358
96bd6233
TT
53592019-07-17 Tom Tromey <tom@tromey.com>
5360
5361 * tui/tui-regs.h (struct tui_data_item_window): Move from
5362 tui-data.h.
5363 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5364 * tui/tui-data.h (struct tui_data_item_window): Move to
5365 tui-regs.h.
5366 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5367
ce38393b
TT
53682019-07-17 Tom Tromey <tom@tromey.com>
5369
5370 * tui/tui.c: Update.
5371 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5372 (tui_cmd_window::max_height): Move to tui-command.c.
5373 * tui/tui-layout.c: Update.
5374 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5375 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5376 tui-command.c.
5377 * tui/tui-command.h (struct tui_cmd_window): Move from
5378 tui-data.h.
5379 * tui/tui-command.c: Remove "structuring" comments.
5380 (tui_cmd_window::clear_detail)
5381 (tui_cmd_window::do_make_visible_with_new_height)
5382 (tui_cmd_window::max_height): Move from elsewhere.
5383
2d8b51cb
TT
53842019-07-17 Tom Tromey <tom@tromey.com>
5385
5386 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5387 Now static.
5388 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5389 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5390
18ab23af
TT
53912019-07-17 Tom Tromey <tom@tromey.com>
5392
5393 * tui/tui.c: Update.
5394 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5395 tui-regs.c.
5396 * tui/tui-windata.h: Remove file.
5397 * tui/tui-windata.c: Remove file.
5398 * tui/tui-win.c (tui_data_window::set_new_height)
5399 (tui_data_window::do_make_visible_with_new_height): Move to
5400 tui-regs.c.
5401 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5402 * tui/tui-regs.c: Remove "structuring" comments.
5403 (tui_data_window::first_data_item_displayed)
5404 (tui_data_window::delete_data_content_windows)
5405 (tui_data_window::erase_data_content)
5406 (tui_data_window::display_all_data)
5407 (tui_data_window::refresh_all)
5408 (tui_data_window::do_scroll_vertical)
5409 (tui_data_window::clear_detail, tui_data_window::set_new_height)
5410 (tui_data_window::do_make_visible_with_new_height)
5411 (tui_data_window::refresh_window): Move from elsewhere.
5412 (_initialize_tui_regs): Move to end of file.
5413 * tui/tui-layout.c: Update.
5414 * tui/tui-hooks.c: Update.
5415 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5416 * tui/tui-data.c (tui_data_window::clear_detail): Move to
5417 tui-regs.c.
5418 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5419
88b7e7cc
TT
54202019-07-17 Tom Tromey <tom@tromey.com>
5421
5422 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5423 seen.
5424
0fcd3711
TT
54252019-07-17 Tom Tromey <tom@tromey.com>
5426
5427 * tui/tui-win.c (tui_source_window_base::set_new_height)
5428 (tui_source_window_base::do_make_visible_with_new_height): Use
5429 m_has_locator field directly.
5430 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5431 method.
5432 (struct tui_source_window_base) <has_locator>: Likewise.
5433
4a38112d
TT
54342019-07-17 Tom Tromey <tom@tromey.com>
5435
5436 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5437 Don't declare.
5438 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5439 Remove.
5440 * tui/tui-win.c (tui_source_window_base::set_new_height)
5441 (tui_source_window_base::set_new_height)
5442 (make_invisible_and_set_new_height)
5443 (tui_source_window_base::do_make_visible_with_new_height)
5444 (tui_source_window_base::do_make_visible_with_new_height):
5445 Update.
5446 * tui/tui-layout.c (show_source_disasm_command, show_data)
5447 (show_source_or_disasm_and_command): Update.
5448 * tui/tui-layout.c (show_layout): Update.
5449
09129226
TT
54502019-07-17 Tom Tromey <tom@tromey.com>
5451
5452 * tui/tui-layout.c (make_data_window): Remove.
5453 (show_data): Unify creation and re-initialization cases.
5454
4a8a5e84
TT
54552019-07-17 Tom Tromey <tom@tromey.com>
5456
5457 * tui/tui-layout.c (make_source_window, make_disasm_window):
5458 Remove.
5459 (show_data): Unify creation and re-initialization cases.
5460
76d2be8e
TT
54612019-07-17 Tom Tromey <tom@tromey.com>
5462
5463 * tui/tui-layout.c (make_command_window): Remove.
5464 (show_source_disasm_command, show_source_or_disasm_and_command):
5465 Unify creation and re-initialization cases.
5466
890b8bde
TT
54672019-07-17 Tom Tromey <tom@tromey.com>
5468
5469 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5470 creation and re-initialization cases.
5471
2cdfa113
TT
54722019-07-17 Tom Tromey <tom@tromey.com>
5473
5474 * tui/tui-regs.c (tui_get_register): Return void.
5475
8e3cfd09
TT
54762019-07-17 Tom Tromey <tom@tromey.com>
5477
5478 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5479 Simplify.
5480
f4e04977
TT
54812019-07-17 Tom Tromey <tom@tromey.com>
5482
5483 * tui/tui-layout.c (show_source_disasm_command): Simplify window
5484 resetting.
5485
0379b883
TT
54862019-07-17 Tom Tromey <tom@tromey.com>
5487
5488 * tui/tui.h (tui_set_layout_by_name): Don't declare.
5489 * tui/tui-regs.c (tui_reg_layout): New function.
5490 (tui_show_registers, tui_reg_command): Use it.
5491 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5492 (tui_layout_command): Rename from tui_set_layout_by_name. Change
5493 parameters.
5494 (tui_layout_command): Remove.
5495
b7fbad91
TT
54962019-07-17 Tom Tromey <tom@tromey.com>
5497
5498 * tui/tui-layout.h (tui/tui-layout): Return void.
5499 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
5500
4e1e56b9
TT
55012019-07-17 Tom Tromey <tom@tromey.com>
5502
5503 * tui/tui-layout.c (show_source_disasm_command, show_data):
5504 Update.
5505 (reset_locator): Remove.
5506 (show_source_or_disasm_and_command): Update.
5507
1e0c09ba
TT
55082019-07-17 Tom Tromey <tom@tromey.com>
5509
5510 * tui/tui-source.c (tui_source_window_base::reset): Remove
5511 win_type parameter.
5512 * tui/tui-layout.c (make_command_window, make_source_window)
5513 (make_disasm_window, make_data_window)
5514 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5515 (reset_locator, show_source_or_disasm_and_command): Update.
5516 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5517 win_type parameter.
5518 (struct tui_source_window_base) <reset>: Likewise.
5519
1bf605de
TT
55202019-07-17 Tom Tromey <tom@tromey.com>
5521
5522 * tui/tui-layout.c (show_source_disasm_command): Use
5523 reset_locator.
5524 (reset_locator): New function.
5525 (init_and_make_win): Remove.
5526 (show_source_or_disasm_and_command): Use reset_locator.
5527
098f9ed4
TT
55282019-07-17 Tom Tromey <tom@tromey.com>
5529
5530 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5531 condition.
5532 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5533 Remove condition.
5534 * tui/tui-source.c (tui_source_window_base::reset): New method.
5535 * tui/tui-layout.c (make_command_window): Don't call
5536 init_and_make_win.
5537 (make_source_window, make_disasm_window): Don't call
5538 make_source_or_disasm_window.
5539 (make_data_window): Don't call init_and_make_win. Change calling
5540 convention.
5541 (show_source_disasm_command, show_data): Simplify.
5542 (make_source_or_disasm_window): Remove.
5543 (show_source_or_disasm_and_command): Simplify.
5544 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5545 (struct tui_source_window_base) <reset>: Likewise.
5546 <execution_info>: Remove initializer.
5547 * tui/tui-data.c (tui_source_window_base): Initialize
5548 execution_info.
5549
80110957
TT
55502019-07-17 Tom Tromey <tom@tromey.com>
5551
5552 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5553 variable.
5554
cf82af05
TT
55552019-07-17 Tom Tromey <tom@tromey.com>
5556
5557 * tui/tui.c (tui_rl_other_window): Update.
5558 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5559 superclass method first. Always iterate over regs_content.
5560 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5561 method.
5562 * tui/tui-win.c (tui_set_focus_command): Update.
5563
01aeb396
TT
55642019-07-17 Tom Tromey <tom@tromey.com>
5565
5566 * tui/tui-win.c (tui_set_focus_command): Rename from
5567 tui_set_focus. Call tui_enable.
5568 (tui_set_focus_command): Remove.
5569
fd6c75ee
TT
55702019-07-17 Tom Tromey <tom@tromey.com>
5571
5572 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5573 refresh_window.
5574 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5575 touchwin.
5576 (tui_data_window::refresh_window): Call refresh_window on data
5577 items. Always call superclass refresh_window.
5578 (tui_win_info::refresh): Remove.
5579 (tui_source_window_base::refresh_window): Update.
5580 (tui_refresh_all): Update.
5581 * tui/tui-layout.c (show_source_disasm_command): Remove call to
5582 refresh_window.
5583 (show_source_or_disasm_and_command): Likewise.
5584 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5585 (struct tui_source_window_base) <refresh>: Likewise.
5586
f6cc34a9
TT
55872019-07-17 Tom Tromey <tom@tromey.com>
5588
5589 * tui/tui-winsource.c (tui_clear_source_content)
5590 (tui_show_source_content): Update.
5591 * tui/tui-source.c (tui_source_window::showing_source_p): Check
5592 whether content is empty.
5593 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5594 Remove.
5595
f31ec9af
TT
55962019-07-17 Tom Tromey <tom@tromey.com>
5597
5598 * tui/tui-winsource.c (tui_erase_source_content): Clear the
5599 window's contents.
5600 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5601 * tui/tui-source.c (tui_set_source_content_nil): Remove.
5602
d1b6f1e5
TT
56032019-07-17 Tom Tromey <tom@tromey.com>
5604
5605 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5606 (struct tui_data_item_window): Update.
5607
d9743a13
TT
56082019-07-17 Tom Tromey <tom@tromey.com>
5609
5610 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5611 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5612 defines.
5613
caf0bc4e
TT
56142019-07-17 Tom Tromey <tom@tromey.com>
5615
5616 * tui/tui-winsource.h (tui_erase_source_content)
5617 (tui_clear_source_content): Remove "display_prompt" parameter.
5618 * tui/tui-winsource.c (tui_update_source_window_as_is)
5619 (tui_update_source_windows_with_addr): Update.
5620 (tui_clear_source_content): Remove "display_prompt" parameter.
5621 (tui_erase_source_content): Likewise. Simplify.
5622 (tui_show_source_content): Update.
5623 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5624 * tui/tui-stack.c (tui_show_frame_info): Update.
5625 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5626 Remove defines.
5627
9d391078
TT
56282019-07-17 Tom Tromey <tom@tromey.com>
5629
5630 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5631 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5632 parameter.
5633 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5634 parameter.
5635
a38da35d
TT
56362019-07-17 Tom Tromey <tom@tromey.com>
5637
5638 * tui/tui-winsource.c (tui_clear_source_content)
5639 (tui_show_source_content, tui_show_exec_info_content)
5640 (tui_clear_exec_info_content): Update.
5641 * tui/tui-stack.c (tui_show_locator_content): Update.
5642 (tui_show_frame_info): Update.
5643 * tui/tui-source.h (tui_source_window): Don't declare.
5644 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5645 from tui_source_is_displayed.
5646 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5647 Remove field.
5648 (struct tui_source_window_base) <content_in_use>: New field. Now
5649 bool.
5650 (struct tui_source_window) <showing_source_p>: New method.
5651 (TUI_SRC_WIN): Change cast.
5652 * tui/tui-data.c (tui_initialize_static_data): Update.
5653
c2cd8994
TT
56542019-07-17 Tom Tromey <tom@tromey.com>
5655
5656 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5657 location_matches_p.
5658 * tui/tui-source.c (tui_source_window::location_matches_p): New
5659 method.
5660 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5661 method.
5662 * tui/tui-data.h (struct tui_source_window_base)
5663 <location_matches_p>: New method.
5664 (struct tui_source_window, struct tui_disasm_window)
5665 <location_matches_p>: Likewise.
5666
4dde7b34
TT
56672019-07-17 Tom Tromey <tom@tromey.com>
5668
5669 * tui/tui-win.c (tui_set_win_height_command): Rename from
5670 tui_set_win_height.
5671 (tui_set_win_height_command): Remove.
5672
b73dd877
TT
56732019-07-17 Tom Tromey <tom@tromey.com>
5674
5675 * tui/tui-source.c (tui_source_window): New constructor. Add
5676 observer.
5677 (~tui_source_window): New destructor.
5678 (tui_source_window::style_changed): New method.
5679 * tui/tui-hooks.c (tui_redisplay_source): Remove.
5680 (tui_attach_detach_observers): Update.
5681 * tui/tui-data.h (struct tui_source_window): Make constructor not
5682 inline. Add destructor.
5683 (struct tui_source_window) <style_changed>: New method.
5684 <m_observable>: New member.
5685
ae2b5380
TT
56862019-07-17 Tom Tromey <tom@tromey.com>
5687
5688 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5689 * tui/tui-win.c (tui_resize_all): Fix typo.
5690
1ce3e844
TT
56912019-07-17 Tom Tromey <tom@tromey.com>
5692
5693 * tui/tui-wingeneral.h (tui_refresh_all): Update.
5694 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5695 (tui_refresh_all): Remove "list" parameter. Use foreach.
5696 * tui/tui-win.c (window_name_completer): Use foreach.
5697 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5698 (update_tab_width): Likewise.
5699 * tui/tui-layout.c (show_layout): Update.
5700 * tui/tui-data.h (class tui_window_iterator): New.
5701 (struct all_tui_windows): New.
5702 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5703
fe3eaf1c
TT
57042019-07-17 Tom Tromey <tom@tromey.com>
5705
5706 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5707 parameter. Don't reference globals.
5708 (tui_reg_command): Update.
5709
368c1354
TT
57102019-07-17 Tom Tromey <tom@tromey.com>
5711
5712 * tui/tui-regs.c (tui_show_registers): Simplify.
5713
e80cd204
TT
57142019-07-17 Tom Tromey <tom@tromey.com>
5715
5716 * tui/tui-regs.c (tui_show_registers): Update.
5717 (tui_show_register_group): Add win_info parameter.
5718
aca2dd16
TT
57192019-07-17 Tom Tromey <tom@tromey.com>
5720
5721 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5722 Rename from tui_display_reg_element_at_line.
5723 (tui_data_window::display_registers_from_line): Update.
5724 * tui/tui-data.h (struct tui_data_window)
5725 <display_reg_element_at_line>: New method.
5726
517e9505
TT
57272019-07-17 Tom Tromey <tom@tromey.com>
5728
5729 * tui/tui-regs.h (tui_display_registers_from)
5730 (tui_display_registers_from_line): Don't declare.
5731 * tui/tui-windata.c (tui_data_window::display_all_data)
5732 (tui_data_window::refresh_all)
5733 (tui_data_window::do_scroll_vertical): Update.
5734 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5735 from tui_display_registers_from.
5736 (tui_display_reg_element_at_line): Update.
5737 (tui_data_window::display_registers_from_line): Rename from
5738 tui_display_registers_from_line.
5739 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5740 display_registers_from_line>: New methods.
5741
f76d8b19
TT
57422019-07-17 Tom Tromey <tom@tromey.com>
5743
5744 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5745 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5746 from tui_erase_data_content.
5747 (tui_data_window::display_all_data)
5748 (tui_data_window::refresh_all)
5749 (tui_data_window::do_scroll_vertical): Update.
5750 * tui/tui-regs.c (tui_show_registers): Update.
5751 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5752 New method.
5753
b4094625
TT
57542019-07-17 Tom Tromey <tom@tromey.com>
5755
5756 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5757 declare.
5758 * tui/tui-windata.c
5759 (tui_data_window::delete_data_content_windows): Rename from
5760 tui_delete_data_content_windows.
5761 (tui_data_window::display_all_data)
5762 (tui_data_window::do_scroll_vertical): Update.
5763 * tui/tui-data.h (struct tui_data_window)
5764 <delete_data_content_windows>: New method.
5765
c223a729
TT
57662019-07-17 Tom Tromey <tom@tromey.com>
5767
5768 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5769 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5770
50daf268
TT
57712019-07-17 Tom Tromey <tom@tromey.com>
5772
5773 * tui/tui-windata.h (tui_display_all_data): Don't declare.
5774 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5775 from tui_display_all_data.
5776 * tui/tui-win.c
5777 (tui_data_window::do_make_visible_with_new_height): Update.
5778 * tui/tui-regs.c (tui_show_registers): Update.
5779 * tui/tui-layout.c (tui_set_layout): Update.
5780 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5781 method.
5782
df5f8cab
TT
57832019-07-17 Tom Tromey <tom@tromey.com>
5784
5785 * tui/tui-windata.h (tui_display_data_from): Don't declare.
5786 * tui/tui-windata.c (tui_display_data_from): Remove.
5787 (tui_data_window::refresh_all): Update.
5788
80cb6c27
TT
57892019-07-17 Tom Tromey <tom@tromey.com>
5790
5791 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5792 * tui/tui-windata.c (tui_display_data_from_line): Remove.
5793 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5794 tui_display_registers_from_line.
5795 * tui/tui-regs.h (tui_display_registers_from_line): Update.
5796 * tui/tui-regs.c (tui_display_registers_from_line): Remove
5797 "force_display" parameter.
5798
baff0c28
TT
57992019-07-17 Tom Tromey <tom@tromey.com>
5800
5801 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5802 declare.
5803 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5804 Rename from tui_first_reg_element_no_inline.
5805 (tui_display_reg_element_at_line)
5806 (tui_display_registers_from_line): Update.
5807 * tui/tui-data.h (struct tui_data_window)
5808 <first_reg_element_no_inline>: New method.
5809
3b23c5f2
TT
58102019-07-17 Tom Tromey <tom@tromey.com>
5811
5812 * tui/tui-windata.c (tui_display_data_from)
5813 (tui_data_window::do_scroll_vertical): Update.
5814 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5815 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5816 Rename from tui_line_from_reg_element_no.
5817 (tui_display_registers_from_line): Update.
5818 * tui/tui-data.h (struct tui_data_window)
5819 <line_from_reg_element_no>: New method.
5820
0b5ec218
TT
58212019-07-17 Tom Tromey <tom@tromey.com>
5822
5823 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5824 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5825 tui_last_regs_line_no.
5826 (tui_display_reg_element_at_line)
5827 (tui_display_registers_from_line): Update.
5828 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5829 method.
5830
0807ab7b
TT
58312019-07-17 Tom Tromey <tom@tromey.com>
5832
5833 PR tui/24722:
5834 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5835 (tui_update_breakpoint_info): Add "being_deleted" parameter.
5836 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5837 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5838 (tui_update_breakpoint_info): Likewise.
5839 * tui/tui-hooks.c (tui_event_create_breakpoint)
5840 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5841 Update.
5842
9ad7fdef
TT
58432019-07-17 Tom Tromey <tom@tromey.com>
5844
5845 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5846
5813316f
TT
58472019-07-17 Tom Tromey <tom@tromey.com>
5848
5849 * tui/tui-winsource.c (tui_update_source_window_as_is)
5850 (tui_update_source_windows_with_addr): Update.
5851 * tui/tui-source.h (tui_set_source_content)
5852 (tui_show_symtab_source): Add "win_info" parameter.
5853 * tui/tui-source.c (tui_set_source_content): Add "win_info"
5854 parameter.
5855 (tui_show_symtab_source): Likewise.
5856
00e264e7
TT
58572019-07-17 Tom Tromey <tom@tromey.com>
5858
5859 * tui/tui-wingeneral.c
5860 (tui_check_and_display_highlight_if_needed): Check can_highlight.
5861
06210ce4
TT
58622019-07-17 Tom Tromey <tom@tromey.com>
5863
5864 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5865 (struct tui_cmd_window) <can_scroll>: New method.
5866 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5867 method.
5868
381befee
TT
58692019-07-17 Tom Tromey <tromey@adacore.com>
5870
5871 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5872 do_field_signed>: Rename. Change type of "value".
5873 * ui-out.c (ui_out::field_signed): Rename from field_int.
5874 Change type of "value".
5875 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
5876 type of "value".
5877 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5878 do_field_int. Change type of "value".
5879 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5880 do_field_int. Change type of "value".
5881 * tracepoint.c (trace_status_mi, tfind_1)
5882 (print_one_static_tracepoint_marker): Update.
5883 * thread.c (print_thread_info_1, print_selected_thread_frame):
5884 Update.
5885 * stack.c (print_frame, print_frame_info): Update.
5886 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5887 Update.
5888 * source.c (print_source_lines_base): Update.
5889 * skip.c (info_skip_command): Update.
5890 * record-btrace.c (btrace_ui_out_decode_error)
5891 (btrace_call_history_src_line): Update.
5892 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5893 Update.
5894 * progspace.c (print_program_space): Update.
5895 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5896 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5897 do_field_int. Change type of "value".
5898 * mi/mi-out.c (mi_ui_out::do_table_begin)
5899 (mi_ui_out::do_table_header): Update.
5900 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
5901 type of "value".
5902 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5903 (mi_cmd_data_list_changed_registers, output_register)
5904 (mi_cmd_data_read_memory, mi_load_progress)
5905 (mi_cmd_trace_frame_collected): Update.
5906 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5907 Update.
5908 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5909 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5910 (mi_cmd_var_list_children, varobj_update_one): Update.
5911 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5912 (mi_cmd_stack_list_args, list_arg_or_local): Update.
5913 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5914 * inferior.c (print_inferior): Update.
5915 * gdb_bfd.c (print_one_bfd): Update.
5916 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5917 Update.
5918 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5919 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5920 do_field_int. Change type of "value".
5921 * cli-out.c (cli_ui_out::do_field_signed): Rename from
5922 do_field_int. Change type of "value".
5923 * breakpoint.c (watchpoint_check, print_breakpoint_location)
5924 (print_one_breakpoint_location, print_it_catch_fork)
5925 (print_one_catch_fork, print_it_catch_vfork)
5926 (print_one_catch_vfork, print_it_catch_solib)
5927 (print_it_catch_exec, print_it_ranged_breakpoint)
5928 (print_mention_watchpoint, print_mention_masked_watchpoint)
5929 (bkpt_print_it, update_static_tracepoint): Update.
5930 * break-catch-throw.c (print_it_exception_catchpoint): Update.
5931 * break-catch-syscall.c (print_it_catch_syscall): Update.
5932 * ada-tasks.c (print_ada_task_info): Update.
5933 * ada-lang.c (print_it_exception, print_mention_exception):
5934 Update.
5935
6b78c3f8
AB
59362019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
5937
5938 PR breakpoints/24541
5939 * gdbarch.c: Regenerate.
5940 * gdbarch.h: Regenerate.
5941 * gdbarch.sh: Adjust return type and parameter types for
5942 'stap_adjust_register'.
5943 (i386_stap_adjust_register): Adjust signature and return new
5944 register name.
5945 * stap-probe.c (stap_parse_register_operand): Adjust use of
5946 'gdbarch_stap_adjust_register'.
5947
d72a9b85
TT
59482019-07-17 Tom Tromey <tromey@adacore.com>
5949
5950 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
5951 declare VEC.
5952 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5953 std::vector.
5954 (struct s390_process_info): Add initializers.
5955 (s390_add_process): Use new.
5956 (s390_linux_nat_target::low_forget_process): Use delete.
5957 (s390_linux_nat_target::low_new_fork)
5958 (s390_linux_nat_target::stopped_by_watchpoint)
5959 (s390_linux_nat_target::low_prepare_to_resume)
5960 (s390_linux_nat_target::insert_watchpoint)
5961 (s390_linux_nat_target::insert_hw_breakpoint)
5962 (s390_linux_nat_target::remove_watchpoint)
5963 (s390_linux_nat_target::remove_hw_breakpoint): Update.
5964
206e6c58
JB
59652019-07-16 John Baldwin <jhb@FreeBSD.org>
5966
5967 * aarch64-fbsd-nat.c: Include regcache.h.
5968 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5969 argument.
5970 (aarch64_fbsd_nat_target::fetch_registers)
5971 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5972 variable.
5973 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5974
cbde90f2
JB
59752019-07-16 John Baldwin <jhb@FreeBSD.org>
5976
5977 * fbsd-nat.c: Include gdbarch.h.
5978
07128006
TT
59792019-07-15 Tom Tromey <tromey@adacore.com>
5980
5981 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5982
1f77b012
TT
59832019-07-15 Tom Tromey <tromey@adacore.com>
5984
5985 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5986 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5987 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5988 * cli-out.c (cli_ui_out::do_field_int): New method.
5989 * ui-out.c (ui_out::field_unsigned): New method.
5990 * symfile.c (generic_load): Use field_unsigned.
5991 (print_transfer_performance): Likewise.
5992 * record-btrace.c (ui_out_field_uint): Remove.
5993 (btrace_call_history_insn_range, btrace_call_history): Use
5994 field_unsigned.
5995 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5996 field_unsigned.
5997 * ui-out.h (class ui_out) <field_unsigned>: New method.
5998 <do_field_unsigned>: Likewise.
5999
33eca680
TT
60002019-07-15 Tom Tromey <tromey@adacore.com>
6001
6002 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6003 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6004 * target.c (flash_erase_command): Use field_string.
6005 * infrun.c (print_signal_received_reason): Use field_string.
6006 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6007 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6008 field_string.
6009 * ada-tasks.c (print_ada_task_info): Use field_string.
6010
ca8d69be
TT
60112019-07-15 Tom Tromey <tromey@adacore.com>
6012
6013 * target.c (flash_erase_command): Use field_core_addr.
6014 * symfile.c (generic_load): Use field_core_addr.
6015 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6016 Use field_core_addr.
6017 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6018 field_core_addr.
6019
0d4e84ed
AB
60202019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6021
6022 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6023 value if its desired type is smaller than a CORE_ADDR and signed.
6024
9a49df9d
AB
60252019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6026
6027 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6028 of changes to field names, and use new is_reference field to
6029 decide if a property is a reference or not.
6030 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6031 field.
6032 (struct dwarf2_property_baton): Update header comment, rename
6033 'referenced_type' to 'property_type' and update comments.
6034 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6035 default property type, store in property baton, update to take
6036 accound of renamed field.
6037 (read_func_scope): Update call to attr_to_dynamic_prop.
6038 (read_array_type): Likewise.
6039 (dwarf2_per_cu_addr_sized_int_type): New function.
6040 (read_subrange_index_type): Move type finding code to
6041 dwarf2_per_cu_addr_sized_int_type.
6042 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6043 (dwarf2_per_cu_addr_type): New function.
6044 (set_die_type): Update calls to attr_to_dynamic_prop.
6045
b86352cf
AB
60462019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6047
6048 * dwarf2read.c (read_subrange_index_type): New function.
6049 (read_subrange_type): Move code into new function and call it.
6050 * gdbtypes.c (create_range_type): Add some asserts.
6051
603490bf
AB
60522019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6053
6054 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6055 update return statements.
6056 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6057 declaration, and update comment to match.
6058 * gdbtypes.c (resolve_dynamic_array): Update call to
6059 dwarf2_evaluate_property to match new return type.
6060
592f9d27
AB
60612019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6062
6063 * valarith.c (value_subscripted_rvalue): Change lowerbound
6064 parameter type from int to LONGEST.
6065 * value.h (value_subscripted_rvalue): Likewise in declaration.
6066
60cfcb20
AB
60672019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6068
6069 * cli/cli-utils.c (info_print_command_completer): New function.
6070 * cli/cli-utils.h: Add 'completer.h' include, and forward
6071 declaration for 'struct cmd_list_element'.
6072 (info_print_command_completer): Declare.
6073 * stack.c (_initialize_stack): Add completer for 'info locals' and
6074 'info args'.
6075 * symtab.c (_initialize_symtab): Add completer for 'info
6076 variables' and 'info functions'.
6077 * NEWS: Mention completion for additional info commands.
6078
b16507e0
AB
60792019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6080
6081 * cli/cli-utils.c (extract_info_print_args): Delete.
6082 (extract_arg_maybe_quoted): Delete.
6083 (info_print_options_defs): New variable.
6084 (make_info_print_options_def_group): New function.
6085 (extract_info_print_options): Define new function.
6086 * cli/cli-utils.h (extract_info_print_args): Delete.
6087 (struct info_print_options): New structure.
6088 (extract_info_print_options): Declare new function.
6089 * stack.c (info_locals_command): Update to use new
6090 extract_info_print_options, also add a header comment.
6091 (info_args_command): Likewise.
6092 * symtab.c (info_variables_command): Likewise.
6093 (info_functions_command): Likewise.
6094
021d8588
AB
60952019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6096
6097 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6098 to extract string arguments.
6099 * common/common-utils.c (extract_string_maybe_quoted): New function.
6100 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6101
b777eb6d
TT
61022019-07-11 Tom Tromey <tromey@adacore.com>
6103
6104 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6105 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6106 * top.h (gdbinit): Don't declare.
6107 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6108 into...
6109 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6110 * top.c (gdb_init): Don't call init_cli_cmds.
6111 (gdbinit): Remove.
6112 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6113
72ee03ff
TT
61142019-07-11 Tom Tromey <tromey@adacore.com>
6115
6116 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6117 after it has been moved.
6118
00db9531
SM
61192019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6120
6121 * valops.c (value_must_coerce_to_target): Change return type to
6122 bool.
6123 * value.h (value_must_coerce_to_target): Likewise.
6124
f2478a7e
SM
61252019-07-10 Simon Marchi <simon.marchi@efficios.com>
6126
6127 * breakpoint.c (is_hardware_watchpoint): Remove
6128 forward-declaration.
6129 (is_masked_watchpoint): Change return type to bool.
6130 (is_tracepoint): Likewise.
6131 (is_breakpoint): Likewise.
6132 (is_hardware_watchpoint): Likewise.
6133 (is_watchpoint): Likewise.
6134 (is_no_memory_software_watchpoint): Likewise.
6135 (is_catchpoint): Likewise.
6136 (breakpoint_1): Make FILTER parameter's return type bool.
6137 is_masked_watchpoint): Change return type to bool.
6138 (save_breakpoints): Make FILTER parameter's return type bool.
6139 * breakpoint.h (is_breakpoint): Change return type to bool.
6140 (is_watchpoint): Likewise.
6141 (is_catchpoint): Likewise.
6142 (is_tracepoint): Likewise.
6143
0d12e84c
TT
61442019-07-10 Tom Tromey <tom@tromey.com>
6145
6146 * defs.h: Don't include gdbarch.h.
6147 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6148 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6149 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6150 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6151 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6152 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6153 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6154 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6155 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6156 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6157 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6158 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6159 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6160 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6161 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6162 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6163 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6164 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6165 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6166 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6167 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6168 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6169 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6170 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6171 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6172 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6173 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6174
f06f1252
TT
61752019-07-10 Tom Tromey <tromey@adacore.com>
6176
6177 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6178 * breakpoint.c (init_ada_exception_breakpoint): Register as
6179 bp_catchpoint.
6180 (print_one_breakpoint_location, print_one_breakpoint): Use
6181 is_ada_exception_catchpoint.
6182 * ada-lang.c (class ada_catchpoint_location): Pass
6183 bp_loc_software_breakpoint to bp_location constructor.
6184 (is_ada_exception_catchpoint): New function.
6185
7a5d944b
TT
61862019-07-10 Tom Tromey <tromey@adacore.com>
6187
6188 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6189 VEC.
6190 (struct arm_exidx_entry): New method operator<.
6191 (struct arm_exidx_data) <section_maps>: Change type.
6192 (arm_exidx_data_free): Remove.
6193 (arm_exidx_data_key): Change type. Move lower.
6194 (arm_exidx_new_objfile): Update.
6195 (arm_compare_exidx_entries): Remove.
6196 (arm_find_exidx_entry, _initialize_arm_tdep)
6197
48c66e1d
TT
61982019-07-10 Tom Tromey <tromey@adacore.com>
6199
6200 * solib-spu.c (ocl_program_data_key): Change type.
6201 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6202 Update.
6203
a269fbf1
TT
62042019-07-10 Tom Tromey <tromey@adacore.com>
6205
6206 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6207 (struct solib_aix_inferior_data) <library_list>: Change type.
6208 (solib_aix_inferior_data_handle): Change type.
6209 (get_solib_aix_inferior_data): Update.
6210 (solib_aix_free_library_list): Remove.
6211 (library_list_start_library): Update.
6212 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6213 return type.
6214 (solib_aix_get_library_list)
6215 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6216 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6217
c294730c
TT
62182019-07-10 Tom Tromey <tromey@adacore.com>
6219
6220 * solib-dsbt.c (struct dsbt_info): Add initializers.
6221 (solib_dsbt_pspace_data): Change type.
6222 (dsbt_pspace_data_cleanup): Remove.
6223 (get_dsbt_info, _initialize_dsbt_solib): Update.
6224
9d52077d
TT
62252019-07-10 Tom Tromey <tromey@adacore.com>
6226
6227 * spu-tdep.c (spu_overlay_data): Change type.
6228 (spu_get_overlay_table, spu_overlay_new_objfile)
6229 (_initialize_spu_tdep): Update.
6230
22a20dca
TT
62312019-07-10 Tom Tromey <tromey@adacore.com>
6232
6233 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6234 destructor.
6235 (dbx_objfile_data_key): Change type and declare later.
6236 (DBX_SYMFILE_INFO): Rewrite.
6237 * dbxread.c (dbx_objfile_data_key): Change type.
6238 (dbx_symfile_init): Update.
6239 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6240 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6241 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6242
cb60f420
TT
62432019-07-10 Tom Tromey <tromey@adacore.com>
6244
6245 * jit.c (jit_program_space_key): Change type. Move lower.
6246 (get_jit_program_space_data): Update.
6247 (jit_program_space_data_cleanup): Remove.
6248 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6249 Update.
6250 (struct jit_program_space_data): Add initializers.
6251
51df2ae3
TT
62522019-07-10 Tom Tromey <tromey@adacore.com>
6253
6254 * solib-darwin.c (struct darwin_info): Add initializers.
6255 (solib_darwin_pspace_data): Change type.
6256 (darwin_pspace_data_cleanup): Remove.
6257 (get_darwin_info, _initialize_darwin_solib): Update.
6258
18101a35
TT
62592019-07-10 Tom Tromey <tromey@adacore.com>
6260
6261 * remote-sim.c (struct sim_inferior_data): Add initializers,
6262 constructor, and destructor.
6263 (sim_inferior_data_key): Change type. Move lower.
6264 (check_for_duplicate_sim_descriptor): Update.
6265 (get_sim_inferior_data): Use new. Update.
6266 (~sim_inferior_data_cleanup): Rename from
6267 sim_inferior_data_cleanup. Simplify.
6268 (gdbsim_close_inferior, simulator_command)
6269 (sim_command_completer, _initialize_remote_sim): Update.
6270 (next_pid, INITIAL_PID): Move earlier.
6271
05b08ac1
TT
62722019-07-10 Tom Tromey <tromey@adacore.com>
6273
6274 * python/python-internal.h (create_thread_object): Return
6275 gdbpy_ref.
6276 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6277 * python/py-inferior.c (struct threadlist_entry): Add
6278 constructor.
6279 <thread_obj>: Now a gdbpy_ref.
6280 (thread_to_thread_object): Update.
6281 (add_thread_object): Use new.
6282 (delete_thread_object): Use delete.
6283 (infpy_threads): Update.
6284 (py_free_inferior): Update. Construct "inf_obj" after acquiring
6285 GIL.
6286
32372d80
TT
62872019-07-10 Tom Tromey <tromey@adacore.com>
6288
6289 * valops.c (value_cast): Specialize error message for Ada.
6290
5c458ae8
SM
62912019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6292
6293 * breakpoint.c (breakpoint_1): Update doc and parameter names.
6294
4c462cb0
SM
62952019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6296
6297 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6298 bpstat_should_step): Return bool, adjust comments.
6299 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6300 bpstat_should_step): Likewise.
6301
89abbcc2
AH
63022019-07-10 Alan Hayward <alan.hayward@arm.com>
6303
6304 * features/Makefile: Use feature target descriptions for Arm.
6305 * features/arm/arm-core.c: Generate new file.
6306 * features/arm/arm-fpa.c: Likewise.
6307 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6308 * features/arm/arm-m-profile.c: Likewise.
6309 * features/arm/arm-vfpv2.c: Likewise.
6310 * features/arm/arm-vfpv3.c: Likewise.
6311 * features/arm/xscale-iwmmxt.c: Likewise.
6312 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6313
166a82be
AH
63142019-07-10 Alan Hayward <alan.hayward@arm.com>
6315
6316 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6317 ptrace earlier.
6318
9fb4c7e9
AH
63192019-07-10 Alan Hayward <alan.hayward@arm.com>
6320
6321 * features/aarch64-pauth.c: Regenerate.
6322
e2d0f980
SM
63232019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
6324
6325 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6326 bool.
6327 (bpstat_what): Use false instead of 0.
6328
a38118e5
PA
63292019-07-09 Pedro Alves <palves@redhat.com>
6330
6331 * break-catch-throw.c (is_exception_catchpoint): New.
6332 * breakpoint.c (print_one_breakpoint_location): New parameter
6333 'raw_loc'. Handle it. Use
6334 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6335 looking at the breakpoint's type.
6336 (print_one_breakpoint): If handling "maint info breakpoints", also
6337 print locations of exception catchpoints.
6338 * breakpoint.h (is_exception_catchpoint): Declare.
6339
cb1e4e32
PA
63402019-07-09 Pedro Alves <palves@redhat.com>
6341
6342 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6343 "addr" field.
6344 (allocate_location_exception_catchpoint): New.
6345 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6346 (initialize_throw_catchpoint_ops): Install
6347 allocate_location_exception_catchpoint as allocate_location
6348 method.
6349 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6350 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6351 bp_loc_other.
6352 (breakpoint_address_is_meaningful): Delete.
6353 (bl_address_is_meaningful): New.
6354 (breakpoint_locations_match): Adjust comment.
6355 (bp_location_from_bp_type): New, factored out of...
6356 (bp_location::bp_location(breakpoint *)): ... this.
6357 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6358 factored out of...
6359 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
6360 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6361 breakpoint_address_is_meaningful.
6362 (bp_locations_compare): Adjust comment.
6363 (update_global_location_list): Use bl_address_is_meaningful
6364 instead of breakpoint_address_is_meaningful.
6365 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6366 explicit.
6367 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6368 * python/py-breakpoint.c (bppy_get_location): No longer check
6369 whether location is null.
6370
b58a68fe
PA
63712019-07-09 Pedro Alves <palves@redhat.com>
6372
6373 PR c++/15468
6374 * breakpoint.c (print_one_breakpoint_location): Remove
6375 single-location assert.
6376
268a13a5
TT
63772019-07-09 Tom Tromey <tom@tromey.com>
6378
6379 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6380 * configure: Rebuild.
6381 * configure.ac: Change common to gdbsupport.
6382 * gdbsupport: Rename from common.
6383 * acinclude.m4: Change common to gdbsupport.
6384 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6385 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6386 gdbsupport.
6387 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6388 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6389 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6390 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6391 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6392 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6393 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6394 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6395 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6396 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6397 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6398 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6399 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6400 coff-pe-read.c, command.h, compile/compile-c-support.c,
6401 compile/compile-c.h, compile/compile-cplus-symbols.c,
6402 compile/compile-cplus-types.c, compile/compile-cplus.h,
6403 compile/compile-loc2c.c, compile/compile.c, completer.c,
6404 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6405 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6406 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6407 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6408 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6409 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6410 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6411 features/aarch64-core.c, features/aarch64-fpu.c,
6412 features/aarch64-pauth.c, features/aarch64-sve.c,
6413 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6414 features/i386/32bit-core.c, features/i386/32bit-linux.c,
6415 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6416 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6417 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6418 features/i386/64bit-core.c, features/i386/64bit-linux.c,
6419 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6420 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6421 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6422 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6423 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6424 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6425 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6426 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6427 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6428 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6429 go32-nat.c, guile/guile.c, guile/scm-ports.c,
6430 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6431 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6432 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6433 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6434 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6435 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6436 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6437 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6438 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6439 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6440 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6441 minsyms.c, mips-linux-tdep.c, namespace.h,
6442 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6443 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6444 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6445 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6446 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6447 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6448 nat/linux-waitpid.c, nat/mips-linux-watch.c,
6449 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6450 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6451 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6452 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6453 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6454 procfs.c, producer.c, progspace.h, psymtab.h,
6455 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6456 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6457 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6458 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6459 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6460 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6461 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6462 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6463 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6464 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6465 target-memory.c, target.c, target.h, target/waitstatus.c,
6466 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6467 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6468 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6469 unittests/array-view-selftests.c,
6470 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6471 unittests/common-utils-selftests.c,
6472 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6473 unittests/format_pieces-selftests.c,
6474 unittests/function-view-selftests.c,
6475 unittests/lookup_name_info-selftests.c,
6476 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6477 unittests/mkdir-recursive-selftests.c,
6478 unittests/observable-selftests.c,
6479 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6480 unittests/parse-connection-spec-selftests.c,
6481 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6482 unittests/scoped_fd-selftests.c,
6483 unittests/scoped_mmap-selftests.c,
6484 unittests/scoped_restore-selftests.c,
6485 unittests/string_view-selftests.c, unittests/style-selftests.c,
6486 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6487 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6488 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6489 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6490 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6491 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6492
5b0e2db4
AB
64932019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6494
6495 * linespec.c (decode_digits_list_mode): Set explicit_line to a
6496 bool value.
6497 (decode_digits_ordinary): Set explicit_line field in sal.
6498 * symtab.c (skip_prologue_sal): Don't skip prologue for a
6499 symtab_and_line that was set on an explicit line number in
6500 assembler code. Do always update the recorded symtab and line if
6501 we do skip the prologue.
6502
0ba852ab
AB
65032019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6504
6505 * breakpoint.c (set_breakpoint_location_function): Remove
6506 explicit_loc parameter.
6507 (momentary_breakpoint_from_master): Update call to
6508 set_breakpoint_location_function.
6509 (add_location_to_breakpoint): Likewise.
6510
b3a7d171
AB
65112019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6512
6513 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6514 required features based on default bfd type when no specific bfd
6515 is present.
6516
1f6f6e21
PW
65172019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6518
6519 * NEWS: Mention that GDB printf and eval commands can now print
6520 C-style and Ada-style convenience var strings without
6521 calling the inferior.
6522 * printcmd.c (printf_c_string): Locally print GDB internal var
6523 instead of transiting via the inferior.
6524 (printf_wide_c_string): Likewise.
6525
65262019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 6527
5862c886 6528 PR breakpoints/25011
ea142fbf
AH
6529 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6530
0598af48
TT
65312019-07-04 Tom Tromey <tom@tromey.com>
6532
6533 PR tui/24724:
6534 * tui/tui-winsource.c (tui_clear_source_content): Update.
6535 (tui_source_window_base::set_is_exec_point_at): Fix comment.
6536 (tui_update_breakpoint_info): Update.
6537 (tui_set_exec_info_content): Update.
6538 * tui/tui-source.c (tui_set_source_content_nil): Update.
6539 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6540 has_break.
6541 * tui/tui-data.h (enum tui_bp_flag): New.
6542 (tui_bp_flags): New enum flags type.
6543 (struct tui_source_element) <break_mode>: Change type. Rename
6544 from has_break.
6545 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6546 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
6547 constants.
6548 * tui/tui-winsource.h: Fix comment.
6549
350fab54
AH
65502019-07-04 Alan Hayward <alan.hayward@arm.com>
6551
6552 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6553 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6554 (store_fpregs_to_thread)
6555 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6556 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6557 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6558 (IWMMXT_REGS_SIZE): Add define.
6559 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6560 (fetch_vfp_regs, store_vfp_regs)
6561 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6562 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6563
f0452268
AH
65642019-07-04 Alan Hayward <alan.hayward@arm.com>
6565
6566 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6567 defines.
6568 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6569 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6570 (ARM_INT_REGISTER_SIZE): ...to this.
6571 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6572 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6573 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6574 (arm_linux_collect_gregset, supply_nwfpe_register)
6575 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6576 defines.
6577 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6578 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6579 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6580 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6581 (arm_return_in_memory, arm_store_return_value)
6582 (arm_get_longjmp_target, arm_register_g_packet_guesses)
6583 (arm_record_ld_st_multiple): Likewise.
6584 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6585 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6586
e935475c
AH
65872019-07-04 Alan Hayward <alan.hayward@arm.com>
6588
6589 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6590 AARCH64_DISPLACED_MODIFIED_INSNS.
6591 * aarch64-tdep.c (struct aarch64_displaced_step_data)
6592 (aarch64_displaced_step_copy_insn): Likewise.
6593 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6594 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6595 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6596 ARM_DISPLACED_MODIFIED_INSNS.
6597 * arm-tdep.c (arm_gdbarch_init): Likewise.
6598 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6599 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6600 (struct arm_displaced_step_closure): Use
6601 ARM_DISPLACED_MODIFIED_INSNS.
6602
df0bb381
AH
66032019-07-04 Alan Hayward <alan.hayward@arm.com>
6604
6605 * features/Makefile: Remove unused xml files.
6606 * features/aarch64.xml: Remove.
6607 * features/i386/amd64-avx-avx512-linux.xml: Remove.
6608 * features/i386/amd64-avx-avx512.xml: Remove.
6609 * features/i386/amd64-avx-linux.xml: Remove.
6610 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6611 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6612 * features/i386/amd64-avx-mpx-linux.xml: Remove.
6613 * features/i386/amd64-avx-mpx.xml: Remove.
6614 * features/i386/amd64-avx.xml: Remove.
6615 * features/i386/amd64-linux.xml: Remove.
6616 * features/i386/amd64-mpx-linux.xml: Remove.
6617 * features/i386/amd64-mpx.xml: Remove.
6618 * features/i386/amd64.xml: Remove.
6619 * features/i386/i386-avx-avx512-linux.xml: Remove.
6620 * features/i386/i386-avx-avx512.xml: Remove.
6621 * features/i386/i386-avx-linux.xml: Remove.
6622 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6623 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6624 * features/i386/i386-avx-mpx-linux.xml: Remove.
6625 * features/i386/i386-avx-mpx.xml: Remove.
6626 * features/i386/i386-avx.xml: Remove.
6627 * features/i386/i386-linux.xml: Remove.
6628 * features/i386/i386-mmx-linux.xml: Remove.
6629 * features/i386/i386-mmx.xml: Remove.
6630 * features/i386/i386-mpx-linux.xml: Remove.
6631 * features/i386/i386-mpx.xml: Remove.
6632 * features/i386/i386.xml: Remove.
6633 * features/i386/x32-avx-avx512-linux.xml: Remove.
6634 * features/i386/x32-avx-linux.xml: Remove.
6635 * features/i386/x32-linux.xml: Remove.
6636
edd6266a
AH
66372019-07-04 Alan Hayward <alan.hayward@arm.com>
6638
6639 * regformats/aarch64.dat: Remove.
6640 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6641 * regformats/i386/amd64-avx-linux.dat: Remove.
6642 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6643 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6644 * regformats/i386/amd64-linux.dat: Remove.
6645 * regformats/i386/amd64-mpx-linux.dat: Remove.
6646 * regformats/i386/amd64.dat: Remove.
6647 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6648 * regformats/i386/i386-avx-linux.dat: Remove.
6649 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6650 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6651 * regformats/i386/i386-linux.dat: Remove.
6652 * regformats/i386/i386-mmx-linux.dat: Remove.
6653 * regformats/i386/i386-mpx-linux.dat: Remove.
6654 * regformats/i386/i386.dat: Remove.
6655 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6656 * regformats/i386/x32-avx-linux.dat: Remove.
6657 * regformats/i386/x32-linux.dat: Remove.
6658
2b40fda7
AH
66592019-07-04 Alan Hayward <alan.hayward@arm.com>
6660
6661 * aarch64-tdep.c: Remove xml self tests.
6662 * amd64-linux-tdep.c: Likewise.
6663 * amd64-tdep.c: Likewise.
6664 * i386-linux-tdep.c: Likewise.
6665 * i386-tdep.c: Likewise.
6666
5f4ba3e7
PA
66672019-07-03 Pedro Alves <palves@redhat.com>
6668
6669 PR cli/24732
6670 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6671 (pipe_cmd_option_defs): New.
6672 (make_pipe_cmd_options_def_group): New.
6673 (pipe_command): Use gdb::option::process_options.
6674 (pipe_command_completer): New function.
6675 (_initialize_cli_cmds): Install completer for "pipe" command.
6676
3d9be6f5
PA
66772019-07-03 Pedro Alves <palves@redhat.com>
6678
6679 * cli/cli-option.c (union option_value) <string>: New field.
6680 (struct option_def_and_value): Add ctor, move ctor, dtor and
6681 use DISABLE_COPY_AND_ASSIGN.
6682 (option_def_and_value::clear_value): New.
6683 (parse_option, save_option_value_in_ctx, get_val_type_str)
6684 (add_setshow_cmds_for_options): Handle var_string.
6685 * cli-option.h (union option_def::var_address) <string>: New
6686 field.
6687 (struct string_option_def): New.
6688 * maint-test-options.c (struct test_options_opts): Add default
6689 ctor and use DISABLE_COPY_AND_ASSIGN.
6690 <string_opt>: New field.
6691 (test_options_opts::~test_options_opts): New.
6692 (test_options_opts::dump): Also dump "-string".
6693 (test_options_option_defs): Install "string.
6694
41fc454c
PA
66952019-07-03 Pedro Alves <palves@redhat.com>
6696
6697 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6698 option_value with a null enumeration.
6699 (complete_options): Save the option values in the context.
6700 (save_option_value_in_ctx): New, factored out from ...
6701 (process_options): ... here.
6702 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6703 of the function.
6704 * maint-test-options.c (test_options_opts::dump): New, factored
6705 out from ...
6706 (maintenance_test_options_command_mode): ... here.
6707 (maintenance_test_options_command_completion_result): Delete.
6708 (maintenance_test_options_command_completion_text): Update
6709 comment.
6710 (maintenance_show_test_options_completion_result): Change
6711 prototype. Just print
6712 maintenance_test_options_command_completion_text.
6713 (save_completion_result): New.
6714 (maintenance_test_options_completer_mode): Pass options context to
6715 complete_options, and then save a dump.
6716 (_initialize_maint_test_options): Use add_cmd to install "maint
6717 show test-options-completion-result".
6718
fdbc9870
PA
67192019-07-03 Pedro Alves <palves@redhat.com>
6720
6721 * NEWS (New commands): Mention "with" and "maint with".
6722 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6723 (with_command, with_command_completer): New.
6724 (pipe_command): Adjust to new repeat_previous
6725 interface.
6726 (_initialize_cli_cmds): Install the "with" command and its "w"
6727 alias.
6728 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6729 declarations.
6730 * cli/cli-setshow.c (parse_cli_var_uinteger)
6731 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6732 argument strings for all var_types.
6733 (get_setshow_command_value_string): New, factored out from ...
6734 (do_show_command): ... this.
6735 * cli/cli-setshow.h: Include <string>.
6736 (get_setshow_command_value_string): Declare.
6737 * command.h (repeat_previous): Now returns const char *. Adjust
6738 comment.
6739 * maint.c: Include "cli/cli-cmds.h".
6740 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6741 (_initialize_maint_cmds): Register the "maintenance with" command.
6742 * top.c (repeat_previous): Move bits from pipe_command here:
6743 Return the saved command line, if any; error out if there's no
6744 command to relaunch.
6745
c6ac8931
PA
67462019-07-03 Pedro Alves <palves@redhat.com>
6747
6748 * NEWS (New commands): Mention "maint set/show test-settings"
6749 instead of "maint test-settings".
6750 * maint-test-settings.c (maintenance_test_settings_list): Delete.
6751 (maintenance_test_settings_set_list): Rename to ...
6752 (maintenance_set_test_settings_list): ... this.
6753 (maintenance_test_settings_show_list): Rename to ...
6754 (maintenance_show_test_settings_list): ... this.
6755 (maintenance_test_settings_cmd): Delete.
6756 (maintenance_test_settings_set_cmd): ...
6757 (maintenance_set_test_settings_cmd): ... this.
6758 (maintenance_test_settings_show_cmd): ...
6759 (maintenance_show_test_settings_cmd): ... this.
6760 (maintenance_test_settings_show_value_cmd):
6761 (maintenance_show_test_settings_value_cmd): ... this.
6762 (_initialize_maint_test_settings): No longer install the "maint
6763 test-settings" prefix command. Rename "maint test-settings set"
6764 to "maint set test-settings", and "maint test-settings show" to
6765 "maint show test-settings". Adjust all subcommands.
6766
d1fcf2fd
PA
67672019-07-03 Pedro Alves <palves@redhat.com>
6768
6769 * maint-test-settings.c: Fix file's intro comment. Replace all
6770 references to "test-options" with references to "test-settings",
6771 in comments.
6772
970f9d09
PA
67732019-07-03 Pedro Alves <palves@redhat.com>
6774
6775 * maint-test-settings.c (maintenance_test_settings_xxx)
6776 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6777 New.
6778 (maintenance_test_settings_enums): Use them.
6779 (maintenance_test_settings_enum): Default to
6780 maintenance_test_settings_xxx.
6781 (_initialize_maint_test_settings): Initialize
6782 MAINTENANCE_TEST_SETTINGS_FILENAME.
6783
f3869b1a
SM
67842019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
6785
6786 * breakpoint.h (remove_breakpoints_inf): Change return type to
6787 void, move function documentation here.
6788 * breakpoint.c (remove_breakpoints_inf): Change return type to
6789 void, move function documentation to header.
6790
54d66006
PA
67912019-07-02 Pedro Alves <palves@redhat.com>
6792
6793 * NEWS (Completion improvements): Mention "info threads".
6794 * thread.c (struct info_threads_opts, info_threads_option_defs)
6795 (make_info_threads_options_def_group): New.
6796 (info_threads_command): Use gdb::option::process_options.
6797 (info_threads_command_completer): New.
6798 (_initialize_thread): Use gdb::option::build_help to build the
6799 help text for "info threads".
6800
854f6088
SM
68012019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
6802
6803 * defs.h (generic_load): Move from here...
6804 * symfile.h (generic_load): ... to here. Rename name parameter
6805 to args.
6806 * symfile.c (generic_load): Add comment.
6807
54ee4252
TT
68082019-07-01 Tom Tromey <tromey@adacore.com>
6809
6810 * dwarf2read.c
6811 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6812 declaration of without_params. Fix formatting.
6813
65392b3e
TT
68142019-07-01 Tom Tromey <tromey@adacore.com>
6815
6816 * ada-exp.y (find_primitive_type): Update.
6817 * ada-lang.h (ada_lookup_symbol): Update.
6818 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6819 parameter.
6820 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6821
7d7571f0
SDJ
68222019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
6823
6824 PR breakpoints/24541
6825 * gdbarch.c: Regenerate.
6826 * gdbarch.h: Regenerate.
6827 * gdbarch.sh: Add 'stap_adjust_register'.
6828 * i386-tdep.c: Include '<unordered_set>'.
6829 (i386_stap_adjust_register): New function.
6830 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6831 * stap-probe.c (stap_parse_register_operand): Call
6832 'gdbarch_stap_adjust_register'.
6833
5af5392a
SDJ
68342019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
6835
6836 PR python/24742
6837 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6838 * python/python.c (do_start_initialization): Use 'xmalloc'
6839 instead of 'PyMem_Malloc'.
6840
10d06d82
TT
68412019-06-28 Tom Tromey <tromey@adacore.com>
6842
6843 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6844 for Ada.
6845
1b7f24cd
TT
68462019-06-27 Tom Tromey <tromey@adacore.com>
6847
6848 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
6849 objfile_key.
6850 (arm_find_mapping_symbol, arm_record_special_symbol)
6851 (_initialize_arm_tdep): Update.
6852 (arm_objfile_data_free): Remove.
6853
3d507ff2
TT
68542019-06-27 Tom Tromey <tromey@adacore.com>
6855
6856 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6857 to cp_print_static_field.
6858
762c164d
TT
68592019-06-26 Tom Tromey <tromey@adacore.com>
6860
6861 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6862 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6863 declare.
6864
aa2f9bcf
AH
68652019-06-26 Alan Hayward <alan.hayward@arm.com>
6866
6867 * features/aarch64-core.c (create_feature_aarch64_core):
6868 Regenerate.
6869 * features/aarch64-core.xml: Add cpsr flags.
6870
3426ae57
AH
68712019-06-26 Alan Hayward <alan.hayward@arm.com>
6872
6873 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6874 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6875
4838e44c
SM
68762019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
6877
6878 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6879 field.
6880 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6881 use.
6882 (arm_record_special_symbol): Don't insert new symbol in sorted
6883 position, push it at the end.
6884
54cc7474
SM
68852019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
6886
6887 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6888 (arm_mapping_symbol_s): Remove.
6889 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6890 (arm_mapping_symbol_vec): New typedef.
6891 (struct arm_per_objfile): Add constructor.
6892 <section_maps>: Change type to
6893 std::unique_ptr<arm_mapping_symbol_vec[]>.
6894 (arm_compare_mapping_symbols): Remove.
6895 (arm_find_mapping_symbol): Adjust to section_maps type change.
6896 (arm_objfile_data_free): Call delete on arm_per_objfile.
6897 (arm_record_special_symbol): Adjust to section_maps type change.
6898 Allocate arm_per_objfile with new.
6899
b65b566c
PW
69002019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6901
6902 * cli/cli-cmds.c (alias_command): Compare the alias prefix
6903 with the command prefix.
6904
c2fc64f5
TT
69052019-06-25 Tom Tromey <tom@tromey.com>
6906
6907 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6908 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6909
fb54fa76
TT
69102019-06-25 Tom Tromey <tom@tromey.com>
6911
6912 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6913 type.
6914 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6915 protected.
6916
f7952c57
TT
69172019-06-25 Tom Tromey <tom@tromey.com>
6918
6919 * tui/tui-winsource.c
6920 (tui_source_window_base::set_is_exec_point_at): Add check against
6921 LOA_ADDRESS.
6922
17568d78
TT
69232019-06-25 Tom Tromey <tom@tromey.com>
6924
6925 * tui/tui-source.c (tui_set_source_content): Don't check before
6926 xfree.
6927 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6928
53e7cdba
TT
69292019-06-25 Tom Tromey <tom@tromey.com>
6930
6931 * tui/tui-winsource.h (tui_update_source_window_as_is)
6932 (tui_alloc_source_buffer, tui_line_is_displayed)
6933 (tui_addr_is_displayed): Change type of win_info.
6934 * tui/tui-winsource.c (tui_update_source_window_as_is)
6935 (tui_clear_source_content, tui_show_source_line)
6936 (tui_show_source_content, tui_source_window_base::refill)
6937 (tui_source_window_base::set_is_exec_point_at)
6938 (tui_source_window_base::set_is_exec_point_at)
6939 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6940 (tui_alloc_source_buffer, tui_line_is_displayed)
6941 (tui_addr_is_displayed): Change type of win_info. Update.
6942 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6943 (tui_source_window_base::do_make_visible_with_new_height):
6944 Update.
6945 * tui/tui-source.c (tui_set_source_content)
6946 (tui_set_source_content_nil)
6947 (tui_source_window::do_scroll_vertical): Update.
6948 * tui/tui-layout.c (show_layout): Update.
6949 * tui/tui-disasm.c (tui_set_disassem_content)
6950 (tui_disasm_window::do_scroll_vertical): Update.
6951 * tui/tui-data.h (tui_win_content): Remove.
6952 (struct tui_gen_win_info) <content, content_size>: Remove.
6953 (struct tui_source_element): Add initializers and destructor.
6954 (union tui_which_element, struct tui_win_element): Remove.
6955 (struct tui_source_window_base) <content>: New field.
6956 (struct tui_data_window): Remove destructor.
6957 (tui_alloc_content, tui_free_win_content)
6958 (tui_free_all_source_wins_content): Don't declare.
6959 * tui/tui-data.c (tui_initialize_static_data): Update.
6960 (init_content_element, tui_alloc_content): Remove.
6961 (~tui_gen_win_info): Update.
6962 (~tui_data_window, tui_free_all_source_wins_content)
6963 (tui_free_win_content, free_content, free_content_elements):
6964 Remove.
6965
7908abbf
TT
69662019-06-25 Tom Tromey <tom@tromey.com>
6967
6968 * tui/tui-winsource.h (tui_clear_source_content)
6969 (tui_erase_source_content, tui_show_source_content): Change type
6970 of win_info.
6971 * tui/tui-winsource.c (tui_clear_source_content)
6972 (tui_erase_source_content, tui_show_source_content): Change type
6973 of win_info.
6974 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6975 * tui/tui-source.h (tui_set_source_content_nil): Change type of
6976 win_info.
6977 * tui/tui-source.c (tui_set_source_content_nil): Change type of
6978 win_info.
6979 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6980
02c28df0
TT
69812019-06-25 Tom Tromey <tom@tromey.com>
6982
6983 * tui/tui-winsource.c (tui_clear_source_content)
6984 (tui_source_window_base::set_is_exec_point_at): Update.
6985 * tui/tui-source.c (tui_set_source_content_nil): Update.
6986 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6987 a bool.
6988 * tui/tui-data.c (init_content_element): Update.
6989
6658b1bf
TT
69902019-06-25 Tom Tromey <tom@tromey.com>
6991
6992 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6993 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6994 * tui/tui-layout.c (init_and_make_win): Update.
6995 * tui/tui.h (enum tui_win_type): Update.
6996 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6997 tui_win_is_auxillary.
6998 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6999 tui_win_is_auxillary.
7000
21e1c91e
TT
70012019-06-25 Tom Tromey <tom@tromey.com>
7002
7003 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7004 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7005 (tui_delete_data_content_windows, tui_display_all_data)
7006 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7007 Update.
7008 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7009 * tui/tui-regs.c (tui_last_regs_line_no)
7010 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7011 (tui_show_registers): Update.
7012 (tui_show_register_group): Return void. Update.
7013 (tui_display_registers_from, tui_display_reg_element_at_line)
7014 (tui_display_registers_from_line, tui_check_register_values):
7015 Update.
7016 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7017 member.
7018 (struct tui_data_window) <regs_content>: Now a std::vector.
7019 <regs_content_count>: Remove.
7020 (tui_add_content_elements, tui_free_data_content): Don't declare.
7021 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7022 (init_content_element): Remove DATA_WIN case. Add assert.
7023 (tui_add_content_elements): Remove.
7024 (tui_data_window): Update.
7025 (tui_free_data_content): Remove.
7026 (free_content_elements): Remove DATA_WIN case.
7027
115ac53b
TT
70282019-06-25 Tom Tromey <tom@tromey.com>
7029
7030 * tui/tui-data.c (tui_data_item_window): Update.
7031 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7032 * tui/tui-windata.c (tui_display_all_data)
7033 (tui_display_data_from_line): Update.
7034 (tui_check_data_values): Remove.
7035 * tui/tui-regs.c (tui_show_register_group)
7036 (tui_display_reg_element_at_line): Update.
7037 * tui/tui-hooks.c (tui_register_changed)
7038 (tui_refresh_frame_and_register_information): Call
7039 tui_check_register_values.
7040 * tui/tui-data.h (struct tui_data_window) <data_content,
7041 data_content_count, data_type>: Remove.
7042 (enum tui_data_type): Remove.
7043
7044 * tui/tui-data.c (tui_data_window::clear_detail)
7045 (~tui_data_window): Update.
7046
eaf9738b
TT
70472019-06-25 Tom Tromey <tom@tromey.com>
7048
7049 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7050 declare.
7051 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7052 Rename from tui_first_data_item_displayed. Update.
7053 (tui_data_window::refresh_all)
7054 (tui_data_window::do_scroll_vertical): Update.
7055 * tui/tui-data.h (struct tui_data_window)
7056 <first_data_item_displayed>: Declare new method.
7057
31ca4723
TT
70582019-06-25 Tom Tromey <tom@tromey.com>
7059
7060 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7061 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7062 contents...
7063 (tui_initialize_static_data): ...here.
7064
41bcff7f
TT
70652019-06-25 Tom Tromey <tom@tromey.com>
7066
7067 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7068 (tui_display_registers_from, tui_check_register_values): Update.
7069 (tui_display_register): Remove win_info parameter; update.
7070 (tui_get_register): Change type of parameters.
7071 * tui/tui-data.h (struct tui_data_element): Remove.
7072 (union tui_which_element) <data>: Remove.
7073 <data_window>: Change type.
7074 (struct tui_data_item_window): New.
7075 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7076 case. Add assert.
7077 (~tui_data_item_window): New destructor.
7078 (free_content_elements): Remove DATA_ITEM_WIN case.
7079
d2802c33
TT
70802019-06-25 Tom Tromey <tom@tromey.com>
7081
7082 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7083 Remove.
7084
dd835f8b
TT
70852019-06-25 Tom Tromey <tom@tromey.com>
7086
7087 * tui/tui-data.h (struct tui_command_element): Remove.
7088 (union tui_which_element) <command>: Remove.
7089 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7090 assert.
7091 (free_content_elements): Remove CMD_WIN case.
7092
bd7db367
TT
70932019-06-25 Tom Tromey <tom@tromey.com>
7094
7095 * tui/tui-layout.c (tui_set_layout): Update.
7096 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7097 * tui/tui-data.c (layout_def): Update.
7098
3add462f
TT
70992019-06-25 Tom Tromey <tom@tromey.com>
7100
7101 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7102 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7103 (tui_source_window_base::set_new_height): Update.
7104 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7105 Update.
7106 (tui_set_locator_fullname, tui_set_locator_info)
7107 (tui_show_frame_info): Update.
7108 * tui/tui-source.c (tui_set_source_content)
7109 (tui_source_is_displayed): Update.
7110 * tui/tui-layout.c (show_source_disasm_command, show_data)
7111 (show_source_or_disasm_and_command): Update.
7112 * tui/tui-disasm.c (tui_set_disassem_content)
7113 (tui_get_begin_asm_address): Update.
7114 * tui/tui-data.h (struct tui_locator_element): Remove.
7115 (union tui_which_element) <locator>: Remove.
7116 (struct tui_locator_window): New.
7117 (tui_locator_win_info_ptr): Change return type.
7118 * tui/tui-data.c (_locator): Change type.
7119 (tui_locator_win_info_ptr): Change return type.
7120 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7121 (tui_alloc_content): Add assert.
7122
489e9d8b
TT
71232019-06-25 Tom Tromey <tom@tromey.com>
7124
7125 * tui/tui-winsource.c
7126 (tui_exec_info_window::maybe_allocate_content): New method.
7127 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7128 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7129 (make_source_or_disasm_window): Add cast.
7130 * tui/tui-data.h (union tui_which_element) <simple_string>:
7131 Remove.
7132 (struct tui_source_info): New.
7133 (struct tui_source_window_base) <execution_info>: Change type.
7134 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7135 case, and add assert.
7136 (tui_alloc_content): Add assert.
7137
c3fabb7d
TT
71382019-06-25 Tom Tromey <tom@tromey.com>
7139
7140 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7141 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7142 * tui/tui-data.c (tui_alloc_win_info): Remove.
7143
bbc228ee
TT
71442019-06-25 Tom Tromey <tom@tromey.com>
7145
7146 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7147 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7148 can_highlight.
7149
5fcee43a
TT
71502019-06-25 Tom Tromey <tom@tromey.com>
7151
7152 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7153 make_visible_with_new_height method.
7154 (tui_win_info::make_visible_with_new_height): New method.
7155 (tui_source_window_base::do_make_visible_with_new_height)
7156 (tui_data_window::do_make_visible_with_new_height)
7157 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7158 (make_visible_with_new_height): Remove.
7159 (tui_resize_all, tui_adjust_win_heights): Use
7160 make_visible_with_new_height method.
7161 * tui/tui-data.h (struct tui_win_info)
7162 <do_make_visible_with_new_height, make_visible_with_new_height>:
7163 New methods.
7164 (struct tui_source_window_base, struct tui_data_window)
7165 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7166 methods.
7167
d83f1fe6
TT
71682019-06-25 Tom Tromey <tom@tromey.com>
7169
7170 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7171 method.
7172 (update_tab_width): Call update_tab_width method.
7173 * tui/tui-data.h (struct tui_win_info)
7174 (struct tui_source_window_base) <update_tab_width>: New methods.
7175
17374de4
TT
71762019-06-25 Tom Tromey <tom@tromey.com>
7177
7178 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7179 parameter.
7180 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7181 parameter.
7182 (tui_gen_win_info::make_visible): Update.
7183 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7184 parameter.
7185 * tui/tui-data.h (enum tui_box): New enum.
7186 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7187
f936bca2
TT
71882019-06-25 Tom Tromey <tom@tromey.com>
7189
7190 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7191 init_and_make_win for EXEC_INFO_WIN.
7192 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7193 longer inline.
7194 (struct tui_win_info) <~tui_win_info>: Inline.
7195 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7196 Don't declare.
7197 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7198 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7199 Remove.
7200 (tui_initialize_static_data): Update.
7201 (~tui_gen_win_info): Handle more cleanup here.
7202 (~tui_source_window_base): Delete "execution_info".
7203 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7204
d6ba6a11
TT
72052019-06-25 Tom Tromey <tom@tromey.com>
7206
7207 * tui/tui-layout.c (make_command_window): Don't set
7208 can_highlight.
7209 (show_source_disasm_command): Call the reset method.
7210 (show_data): Don't set can_highlight. Call the reset method.
7211 (tui_gen_win_info::reset): Rename from init_gen_win_info
7212 (init_and_make_win): Simplify. Return tui_gen_win_info.
7213 (show_source_or_disasm_and_command): Call the reset method.
7214 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7215 (struct tui_cmd_window): Set can_highlight.
7216
48a3bd16
TT
72172019-06-25 Tom Tromey <tom@tromey.com>
7218
7219 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7220 from make_visible.
7221 (tui_make_visible, tui_make_invisible): Rewrite.
7222 (tui_win_info::make_visible): Remove.
7223 (tui_source_window_base::make_visible): Update.
7224 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7225 method. Moved from...
7226 (struct tui_win_info) <make_visible>: ...here.
7227
c3bd716f
TT
72282019-06-25 Tom Tromey <tom@tromey.com>
7229
7230 * tui/tui-winsource.c
7231 (tui_source_window_base::do_scroll_horizontal): Remove direction
7232 parameter.
7233 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7234 direction parameter.
7235 * tui/tui-win.c (tui_win_info::forward_scroll)
7236 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7237 (tui_win_info::right_scroll): Update.
7238 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7239 direction parameter.
7240 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7241 direction parameter.
7242 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7243 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7244 Remove direction parameter.
7245 (struct tui_source_window_base, struct tui_source_window)
7246 (struct tui_disasm_window, struct tui_data_window)
7247 (struct tui_cmd_window): Update.
7248
21c32dca
TT
72492019-06-25 Tom Tromey <tom@tromey.com>
7250
7251 * tui/tui-winsource.h (tui_set_exec_info_content)
7252 (tui_show_exec_info_content, tui_erase_exec_info_content)
7253 (tui_clear_exec_info_content, tui_update_exec_info): Change
7254 argument to tui_source_window_base.
7255 * tui/tui-winsource.c (tui_set_exec_info_content)
7256 (tui_show_exec_info_content, tui_erase_exec_info_content)
7257 (tui_clear_exec_info_content, tui_update_exec_info): Change
7258 argument to tui_source_window_base.
7259
73fbdc65
TT
72602019-06-25 Tom Tromey <tom@tromey.com>
7261
7262 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7263 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7264
33325343
TT
72652019-06-25 Tom Tromey <tom@tromey.com>
7266
7267 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7268 check.
7269
29d2c474
TT
72702019-06-25 Tom Tromey <tom@tromey.com>
7271
7272 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7273 type to void.
7274 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7275 type to void.
7276 * tui/tui-source.c (tui_set_source_content): Update.
7277 * tui/tui-disasm.c (tui_set_disassem_content): Update.
7278
152f3f4b
TT
72792019-06-25 Tom Tromey <tom@tromey.com>
7280
7281 * tui/tui-win.c (window_name_completer, tui_set_focus)
7282 (tui_all_windows_info): Use name method.
7283 * tui/tui-data.h (struct tui_gen_win_info)
7284 (struct tui_source_window, struct tui_disasm_window)
7285 (struct tui_data_window, struct tui_cmd_window) <name>: New
7286 method.
7287 (tui_win_name): Don't declare.
7288 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7289 (tui_win_name): Remove.
7290
be4da588
TT
72912019-06-25 Tom Tromey <tom@tromey.com>
7292
7293 * tui/tui-winsource.h (tui_update_source_window)
7294 (tui_update_source_window_as_is): Change parameter type.
7295 * tui/tui-winsource.c (tui_update_source_window): Change win_info
7296 to be a tui_source_window_base.
7297 (tui_update_source_window_as_is): Likewise.
7298 * tui/tui-win.c (make_visible_with_new_height): Update.
7299
5b81daba
TT
73002019-06-25 Tom Tromey <tom@tromey.com>
7301
7302 * tui/tui-winsource.c (tui_erase_source_content)
7303 (tui_show_source_content, tui_show_exec_info_content)
7304 (tui_erase_exec_info_content): Use refresh_window method.
7305 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7306 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7307 from tui_refresh_win.
7308 (tui_data_window::refresh_window): New method.
7309 (tui_win_info::refresh, tui_source_window_base::refresh)
7310 (tui_refresh_all): Use refresh_window method.
7311 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7312 method.
7313 * tui/tui-regs.c (tui_display_register): Call refresh_window
7314 method.
7315 * tui/tui-layout.c (show_source_disasm_command)
7316 (show_source_or_disasm_and_command): Call refresh_window method.
7317 * tui/tui-data.h (struct tui_gen_win_info)
7318 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7319 New method.
7320
cb2ce893
TT
73212019-06-25 Tom Tromey <tom@tromey.com>
7322
7323 * tui/tui.c (tui_rl_other_window, tui_enable)
7324 (tui_is_window_visible, tui_get_command_dimension): Update.
7325 * tui/tui-winsource.c (tui_update_source_window_as_is)
7326 (tui_clear_source_content, tui_erase_source_content)
7327 (tui_show_source_line, tui_source_window_base::refill)
7328 (tui_source_window_base::do_scroll_horizontal)
7329 (tui_source_window_base::set_is_exec_point_at)
7330 (tui_update_breakpoint_info, tui_set_exec_info_content)
7331 (tui_alloc_source_buffer, tui_line_is_displayed)
7332 (tui_addr_is_displayed): Update.
7333 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7334 (tui_check_and_display_highlight_if_needed)
7335 (tui_win_info::make_visible, tui_win_info::refresh)
7336 (tui_refresh_all): Update.
7337 * tui/tui-windata.c (tui_first_data_item_displayed)
7338 (tui_delete_data_content_windows, tui_erase_data_content)
7339 (tui_display_all_data, tui_data_window::refresh_all)
7340 (tui_check_data_values): Update.
7341 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7342 (tui_set_win_focus_to, tui_win_info::forward_scroll)
7343 (tui_win_info::backward_scroll, tui_refresh_all_win)
7344 (tui_resize_all, tui_set_focus, tui_all_windows_info)
7345 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7346 (tui_source_window_base::set_new_height)
7347 (tui_data_window::set_new_height)
7348 (make_invisible_and_set_new_height)
7349 (make_visible_with_new_height, new_height_ok)
7350 (parse_scrolling_args): Update.
7351 * tui/tui-stack.c (tui_show_frame_info): Update.
7352 * tui/tui-source.c (tui_set_source_content)
7353 (tui_set_source_content_nil, tui_source_is_displayed)
7354 (tui_source_window::do_scroll_vertical): Update.
7355 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7356 (tui_display_registers_from, tui_display_reg_element_at_line)
7357 (tui_check_register_values, tui_reg_command): Update.
7358 * tui/tui-layout.c (tui_default_win_height)
7359 (show_source_disasm_command, show_data, init_and_make_win)
7360 (show_source_or_disasm_and_command): Update.
7361 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7362 (tui_redisplay_readline, tui_mld_flush)
7363 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7364 (tui_getc): Update.
7365 * tui/tui-disasm.c (tui_set_disassem_content)
7366 (tui_disasm_window::do_scroll_vertical): Update.
7367 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7368 Now virtual.
7369 (struct tui_win_info): Derive from tui_gen_win_info.
7370 <~tui_win_info>: Mark as override.
7371 <generic>: Remove member.
7372 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7373 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7374 (~tui_data_window, ~tui_win_info)
7375 (tui_free_all_source_wins_content): Update.
7376 * tui/tui-command.c (tui_refresh_cmd_win): Update.
7377
ab313b35
TT
73782019-06-25 Tom Tromey <tom@tromey.com>
7379
7380 * tui/tui-layout.c (init_and_make_win): Use new.
7381 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7382 destructor, initializers.
7383 (tui_alloc_generic_win_info): Don't declare.
7384 * tui/tui-data.c (_locator): Add argument to constructor.
7385 (source_win, disasm_win): New globals.
7386 (exec_info): Remove.
7387 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7388 Update.
7389 (tui_alloc_generic_win_info): Remove.
7390 (init_content_element): Use new.
7391 (tui_win_info::tui_win_info): Update.
7392 (free_content_elements) <case DATA_WIN>: Use delete.
7393
dc2c33e4
TT
73942019-06-25 Tom Tromey <tom@tromey.com>
7395
7396 * tui/tui-wingeneral.c (tui_refresh_win): Update.
7397 * tui/tui-windata.c (tui_first_data_item_displayed)
7398 (tui_delete_data_content_windows): Update.
7399 * tui/tui-win.c (tui_data_window::set_new_height): Update.
7400 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7401 (tui_display_registers_from, tui_check_register_values): Update.
7402 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7403 pointer.
7404 * tui/tui-data.c (init_content_element): Update. Allocate the new
7405 window.
7406 (tui_free_data_content): Update.
7407 (free_content_elements) <case DATA_WIN>: Free the window.
7408
214a5cbe
TT
74092019-06-25 Tom Tromey <tom@tromey.com>
7410
7411 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7412 Update.
7413 * tui/tui-layout.c (make_command_window)
7414 (show_source_disasm_command, show_data, init_and_make_win)
7415 (show_source_or_disasm_and_command): Update.
7416 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7417 method.
7418 <can_highight, is_highlighted>: Now bool.
7419 (tui_set_win_highlight): Don't declare.
7420 * tui/tui-data.c (tui_set_win_highlight): Remove.
7421
8e2daf15
TT
74222019-06-25 Tom Tromey <tom@tromey.com>
7423
7424 * tui/tui-wingeneral.c (make_visible): Remove check of window
7425 type.
7426
8903bd8a
TT
74272019-06-25 Tom Tromey <tom@tromey.com>
7428
7429 * tui/tui-win.c (tui_win_info::max_height)
7430 (tui_cmd_window::max_height): New methods.
7431 (new_height_ok): Call max_height.
7432 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7433 <max_height>: New method.
7434
3f02ce1e
TT
74352019-06-25 Tom Tromey <tom@tromey.com>
7436
7437 * tui/tui-win.c (tui_source_window_base::set_new_height)
7438 (tui_data_window::set_new_height): New methods.
7439 (make_invisible_and_set_new_height): Call set_new_height method.
7440 * tui/tui-data.h (struct tui_win_info)
7441 (struct tui_source_window_base, struct tui_data_window)
7442 <set_new_height>: New method.
7443
1825f487
TT
74442019-06-25 Tom Tromey <tom@tromey.com>
7445
7446 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7447 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7448 tui_refresh_data_win.
7449 * tui/tui-win.c (tui_source_window_base::refresh_all): New
7450 method.
7451 (tui_refresh_all_win): Call the refresh_all method.
7452 (tui_set_focus): Likewise.
7453 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7454 (struct tui_source_window_base, struct tui_data_window) <refresh>:
7455 Likewise.
7456
ad54d15b
TT
74572019-06-25 Tom Tromey <tom@tromey.com>
7458
7459 * tui/tui-winsource.h (tui_refill_source_window)
7460 (tui_set_is_exec_point_at): Don't declare.
7461 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7462 (tui_source_window_base::refill): Rename from
7463 tui_refill_source_window.
7464 (tui_source_window_base::do_scroll_horizontal): Update.
7465 (tui_source_window_base::set_is_exec_point_at): Rename from
7466 tui_set_is_exec_point_at.
7467 (tui_update_all_breakpoint_info): Update.
7468 * tui/tui-stack.c (tui_show_frame_info): Update.
7469 * tui/tui-layout.c (show_data): Add cast.
7470 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7471 * tui/tui-data.h (struct tui_source_window_base) <refill,
7472 set_is_exec_point_at>: New methods.
7473 (tui_source_windows, tui_add_to_source_windows): Update types.
7474 (tui_add_to_source_windows): Remove redundant declaration.
7475 * tui/tui-data.c (source_windows): Store tui_source_window_base.
7476 (tui_source_windows): Change return type.
7477 (tui_clear_source_windows_detail): Update.
7478 (tui_add_to_source_windows): Change type of parameter.
7479 (tui_free_all_source_wins_content): Update.
7480
2042b506
TT
74812019-06-25 Tom Tromey <tom@tromey.com>
7482
7483 * tui/tui-wingeneral.c (tui_win_info::refresh)
7484 (tui_source_window_base::refresh): New methods.
7485 (tui_refresh_all): Call the refresh method.
7486 * tui/tui-data.h (struct tui_win_info)
7487 (struct tui_source_window_base) <refresh>: New method.
7488
56122977
TT
74892019-06-25 Tom Tromey <tom@tromey.com>
7490
7491 * tui/tui.h (tui_is_window_visible): Return bool.
7492 * tui/tui.c (tui_is_window_visible): Return bool.
7493 * tui/tui-wingeneral.c (tui_make_window, make_visible)
7494 (tui_make_visible, tui_make_invisible)
7495 (tui_win_info::make_visible)
7496 (tui_source_window_base::make_visible, make_all_visible)
7497 (tui_make_all_visible, tui_make_all_invisible): Update.
7498 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7499 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7500 bool.
7501 (struct tui_win_info, struct tui_source_window_base)
7502 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7503 * tui/tui-data.c (tui_init_generic_part): Update.
7504
cda37efb
TT
75052019-06-25 Tom Tromey <tom@tromey.com>
7506
7507 * tui/tui-wingeneral.c (tui_win_info::make_visible)
7508 (tui_source_window_base::make_visible): New methods.
7509 (make_all_visible): Make method call.
7510 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7511 (struct tui_source_window_base, struct tui_cmd_window): Override
7512 make_visible.
7513 (tui_win_is_source_type): Don't declare.
7514 * tui/tui-data.c (tui_win_is_source_type): Remove.
7515
6a0ee02c
TT
75162019-06-25 Tom Tromey <tom@tromey.com>
7517
7518 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7519 NULL check.
7520
63901aec
TT
75212019-06-25 Tom Tromey <tom@tromey.com>
7522
7523 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7524 Inline constructor. Add initializers for members.
7525 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7526 constructors; now inline in class.
7527
ceb13a13
TT
75282019-06-25 Tom Tromey <tom@tromey.com>
7529
7530 * tui/tui-regs.c (tui_show_registers): Update.
7531 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7532 bool.
7533 * tui/tui-data.c (tui_data_window::clear_detail)
7534 (tui_data_window): Update.
7535
238eb706
TT
75362019-06-25 Tom Tromey <tom@tromey.com>
7537
7538 * tui/tui-windata.c (tui_display_all_data)
7539 (tui_display_data_from_line, tui_display_data_from)
7540 (tui_check_data_values, tui_data_window::do_scroll_vertical):
7541 Update.
7542 * tui/tui-regs.c (tui_last_regs_line_no)
7543 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7544 (tui_show_registers, tui_show_register_group)
7545 (tui_display_registers_from, tui_display_reg_element_at_line)
7546 (tui_display_registers_from_line, tui_check_register_values)
7547 (tui_reg_next, tui_reg_prev): Update.
7548 * tui/tui-layout.c (tui_set_layout, show_data): Update.
7549 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
7550 tui_data_window.
7551 (struct tui_win_info) <detail>: Remove. Add new fields from
7552 tui_data_info.
7553 (TUI_DATA_WIN): Add cast.
7554 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7555 (~tui_data_window): Simplify.
7556
81491aa0
TT
75572019-06-25 Tom Tromey <tom@tromey.com>
7558
7559 * tui/tui-layout.c (show_source_disasm_command)
7560 (show_source_or_disasm_and_command): Update.
7561 * tui/tui-io.c (update_cmdwin_start_line)
7562 (tui_redisplay_readline): Update.
7563 * tui/tui-data.h (struct tui_command_info): Remove.
7564 (struct tui_win_info) <detail>: Remove command_info member.
7565 (struct tui_data_window) <start_line>: New member, from
7566 tui_command_info.
7567 (TUI_CMD_WIN): Add casts.
7568
e6e41501
TT
75692019-06-25 Tom Tromey <tom@tromey.com>
7570
7571 * tui/tui-winsource.c (tui_update_source_window)
7572 (tui_refill_source_window)
7573 (tui_source_window_base::do_scroll_horizontal)
7574 (tui_update_breakpoint_info, tui_set_exec_info_content)
7575 (tui_show_exec_info_content, tui_erase_exec_info_content)
7576 (tui_clear_exec_info_content): Update.
7577 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7578 Update.
7579 * tui/tui-win.c (make_invisible_and_set_new_height)
7580 (make_visible_with_new_height): Update.
7581 * tui/tui-source.c (tui_set_source_content)
7582 (tui_show_symtab_source): Update.
7583 * tui/tui-layout.c (extract_display_start_addr)
7584 (show_source_disasm_command, show_data)
7585 (make_source_or_disasm_window)
7586 (show_source_or_disasm_and_command): Update.
7587 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7588 (tui_disasm_window::do_scroll_vertical): Remove shadowing
7589 "gdbarch".
7590 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
7591 to tui_source_window_base.
7592 (struct tui_win_info) <detail>: Remove source_info member.
7593 (struct tui_source_window_base) <has_locator>: Inline.
7594 Move contents from tui_source_info; rename has_locator member to
7595 m_has_locator.
7596 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7597 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7598 header file.
7599 (tui_source_window_base::clear_detail, ~tui_source_window_base):
7600 Simplify.
7601 (tui_free_all_source_wins_content): Cast to
7602 tui_source_window_base.
7603
44f0e208
TT
76042019-06-25 Tom Tromey <tom@tromey.com>
7605
7606 * tui/tui-win.c (make_invisible_and_set_new_height)
7607 (make_visible_with_new_height): Call has_locator method.
7608 * tui/tui-layout.c (show_source_disasm_command, show_data)
7609 (show_source_or_disasm_and_command): Update for bool change.
7610 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7611 (tui_win_info) <has_locator>: New method.
7612 (struct tui_source_window_base) <has_locator>: New method.
7613 (tui_win_has_locator): Don't declare.
7614 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7615 from tui_win_has_locator.
7616 (tui_source_window_base): Use false, not FALSE.
7617
7778b912
TT
76182019-06-25 Tom Tromey <tom@tromey.com>
7619
7620 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7621 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7622 clear_detail method directly.
7623 (tui_clear_win_detail): Remove.
7624
f83d391c
TT
76252019-06-25 Tom Tromey <tom@tromey.com>
7626
7627 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7628 "this", not TUI_DISASM_WIN.
7629
13446e05
TT
76302019-06-25 Tom Tromey <tom@tromey.com>
7631
7632 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
7633 declare.
7634 * tui/tui-winsource.c
7635 (tui_source_window_base::do_scroll_horizontal): Rename from
7636 tui_horizontal_source_scroll.
7637 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7638 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7639 from tui_vertical_data_scroll.
7640 * tui/tui-win.h (tui_scroll): Don't declare.
7641 * tui/tui-win.c (tui_win_info::forward_scroll)
7642 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7643 (tui_win_info::right_scroll): Rename and update.
7644 (tui_scroll_forward_command, tui_scroll_backward_command)
7645 (tui_scroll_left_command, tui_scroll_right_command): Update.
7646 (tui_scroll): Remove.
7647 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7648 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7649 from tui_vertical_source_scroll.
7650 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7651 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7652 from tui_vertical_disassem_scroll.
7653 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7654 do_scroll_horizontal>: New methods.
7655 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7656 Likewise.
7657 (struct tui_source_window_base): Add do_scroll_horizontal.
7658 (struct tui_source_window, struct tui_disasm_window): Add
7659 do_scroll_vertical.
7660 (struct tui_data_window, struct tui_cmd_window): Add
7661 do_scroll_horizontal and do_scroll_vertical.
7662 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7663
5cf82909
TT
76642019-06-25 Tom Tromey <tom@tromey.com>
7665
7666 * tui/tui-data.h (struct tui_source_window_base): New struct.
7667 (struct tui_source_window): Derive from tui_source_window_base.
7668 (struct tui_disasm_window): New struct.
7669 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7670 from tui_source_window::clear_detail.
7671 (tui_source_window_base): Rename from tui_source_window.
7672 (~tui_source_window_base): Rename from ~tui_source_window.
7673 (tui_alloc_win_info): Create a tui_disasm_window.
7674
ee1d42d6
TT
76752019-06-25 Tom Tromey <tom@tromey.com>
7676
7677 * tui/tui-data.h (struct tui_source_window)
7678 (struct tui_data_window): Declare destructors.
7679 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7680 destructors.
7681 (tui_win_info): Simplify.
7682
b4eb2452
TT
76832019-06-25 Tom Tromey <tom@tromey.com>
7684
7685 * tui/tui-winsource.c (tui_display_main)
7686 (tui_update_source_windows_with_addr)
7687 (tui_update_all_breakpoint_info): Update.
7688 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7689 (new_height_ok, parse_scrolling_args): Update.
7690 * tui/tui-stack.c (tui_show_frame_info): Update.
7691 * tui/tui-data.h (struct tui_list): Remove.
7692 (tui_source_windows): Return a reference to a std::vector.
7693 * tui/tui-data.c (source_windows): Now a std::vector.
7694 (tui_source_windows): Change return type.
7695 (tui_clear_source_windows): Rewrite.
7696 (tui_clear_source_windows_detail, tui_add_to_source_windows)
7697 (tui_free_all_source_wins_content): Rewrite.
7698
8761a91b
TT
76992019-06-25 Tom Tromey <tom@tromey.com>
7700
7701 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7702 (struct tui_data_window, struct tui_cmd_window): Declare
7703 clear_detail method.
7704 * tui/tui-data.c (tui_source_window::clear_detail)
7705 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7706 methods.
7707 (tui_clear_win_detail): Simplify.
7708
0ed69eda
TT
77092019-06-25 Tom Tromey <tom@tromey.com>
7710
7711 * tui/tui-layout.c (make_source_window, make_disasm_window)
7712 (make_source_or_disasm_window): Remove win_info_ptr parameter.
7713 Return the new window.
7714 (show_source_disasm_command, show_data)
7715 (show_source_or_disasm_and_command): Update.
7716
82432e10
TT
77172019-06-25 Tom Tromey <tom@tromey.com>
7718
7719 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7720 parameter. Return the new window.
7721 (show_source_disasm_command): Update and remove NULL check.
7722 (show_source_or_disasm_and_command): Update.
7723
ec328aa5
TT
77242019-06-25 Tom Tromey <tom@tromey.com>
7725
7726 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7727
33b906ab
TT
77282019-06-25 Tom Tromey <tom@tromey.com>
7729
7730 * tui/tui-data.h (struct tui_win_info): Make constructor
7731 protected. Make destructor virtual. Add initializers.
7732 (tui_source_window, tui_data_window, tui_cmd_window): New
7733 classes.
7734 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
7735 constructor. Add "type" parameter.
7736 (tui_source_window, tui_data_window, tui_cmd_window): New
7737 constructors.
7738 (tui_alloc_win_info): Instantiate the appropriate subclass.
7739
e7e11af4
TT
77402019-06-25 Tom Tromey <tom@tromey.com>
7741
7742 * tui/tui-win.c (tui_resize_all): Use delete.
7743 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7744 destructor.
7745 (tui_free_window): Don't declare.
7746 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7747 Update.
7748
6792b55e
TT
77492019-06-25 Tom Tromey <tom@tromey.com>
7750
7751 * tui/tui-data.h (struct tui_win_info): Add constructor.
7752 * tui/tui-data.c (tui_alloc_win_info): Use new.
7753 (tui_free_window): Use delete.
7754
f95675e1
TT
77552019-06-22 Tom Tromey <tom@tromey.com>
7756
7757 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7758 declare.
7759 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7760
5bff081c
TT
77612019-06-22 Tom Tromey <tom@tromey.com>
7762
7763 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7764 declare.
7765 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7766
47e3f474
TV
77672019-06-22 Tom de Vries <tdevries@suse.de>
7768
7769 * dwarf2read.c (create_addrmap_from_aranges)
7770 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7771 instead of '%zu'.
7772
fd5866f6
SM
77732019-06-21 Simon Marchi <simon.marchi@efficios.com>
7774
7775 * dwarf2read.h (dwarf2_section_info_def): Remove.
7776 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7777 * dwarf2read.c (struct dwo_sections) <types>: Change type to
7778 std::vector<dwarf2_section_info>.
7779 (struct dwo_file) <~dwo_file>: Remove.
7780 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7781 types field.
7782 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7783 (dwarf2_read_debug_names): Likewise.
7784 (create_debug_types_hash_table): Change parameter type to
7785 array_view, adjust code accordingly.
7786 (dwarf2_locate_dwo_sections): Adjust to std::vector.
7787 (partial_die_info::fixup): Likewise.
7788 (determine_prefix): Likewise.
7789 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7790
fb1eb2f9
SM
77912019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
7792
7793 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7794 gdb_bfd_ref_ptr.
7795 <~dwo_file>: Remove call to gdb_bfd_unref.
7796 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7797 gdb_bfd_ref_ptr::get.
7798
51ac9db5
SM
77992019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
7800
7801 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7802 type to htab_up.
7803 * dwarf2read.c (struct dwo_file): Initialize fields.
7804 <~dwo_file>: New.
7805 (free_dwo_file): Remove, move content to ~dwo_file.
7806 (struct dwo_file_deleter): Remove.
7807 (dwo_file_up>: Remove custom deleter.
7808 (free_dwo_files): Remove.
7809 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7810 dwo_files.
7811 (process_skeletonless_type_units): Call unique_ptr::get.
7812 (allocate_dwo_file_hash_table): Add deleter to created hash
7813 table. Change return type to htab_up.
7814 (lookup_dwo_file_slot): Don't memset dwo_file, call
7815 unique_ptr::get.
7816 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7817 (create_dwo_unit_in_dwp_v2): Likewise.
7818 (open_and_init_dwo_file): Likewise.
7819 (free_dwo_file_from_slot): Remove.
7820
dc4ccb6f
SM
78212019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
7822
7823 * dwarf2read.h (struct dwarf2_section_info) <readin,
7824 is_virtual>: Change type to bool.
7825 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7826 true instead of 1.
7827
e6a1c5cb
TT
78282019-06-19 Tom Tromey <tom@tromey.com>
7829
7830 * tui/tui-data.h (tui_init_content_element): Don't declare.
7831
6f6ffbeb
TT
78322019-06-19 Tom Tromey <tom@tromey.com>
7833
7834 * tui/tui-data.h (tui_init_win_info): Don't declare.
7835
f23f598e
TV
78362019-06-19 Tom de Vries <tdevries@suse.de>
7837
7838 * dwarf2read.h (abstract_to_concrete): Change type to
7839 std::unordered_map<sect_offset, std::vector<sect_offset>,
7840 gdb::hash_enum<sect_offset>>.
7841
680e1bee
TT
78422019-06-19 Tom Tromey <tromey@adacore.com>
7843
7844 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7845 EVAL_AVOID_SIDE_EFFECTS specially.
7846
dcf37923
TT
78472019-06-19 Tom Tromey <tromey@adacore.com>
7848
7849 * source-cache.c (highlighter): New global.
7850 (source_cache::get_source_lines): Create a highlighter on demand.
7851
494986d5
AB
78522019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
7853
7854 * defs.h (deprecated_interactive_hook): Delete declaration.
7855 * interps.c (clear_interpreter_hooks): Remove use of
7856 deprecated_interactive_hook.
7857 * top.c (deprecated_interactive_hook): Delete definition.
7858 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7859
3360b6e7
TV
78602019-06-18 Tom de Vries <tdevries@suse.de>
7861
7862 PR gdb/24515
7863 * dwarf2read.h (abstract_to_concrete): Change type from
7864 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7865 std::unordered_map<sect_offset, std::vector<sect_offset>>.
7866 * dwarf2read.c (read_variable): Update.
7867 (dwarf2_fetch_die_loc_sect_off): Update.
7868
310b3441
TV
78692019-06-17 Tom de Vries <tdevries@suse.de>
7870
7871 PR gdb/24617
7872 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7873 accessing parent[parent_len - 1].
7874
ba9777be
PP
78752019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
7876
7877 PR gdb/24364
7878 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7879 call dtrace_process_dof with NULL dof.
7880
2b9f6e89
TV
78812019-06-16 Tom de Vries <tdevries@suse.de>
7882
7883 PR gdb/24445
7884 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7885
431b3ead
TT
78862019-06-16 Tom Tromey <tom@tromey.com>
7887
7888 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7889 (make_all_visible): Use address of member.
7890
d04b44a1
TT
78912019-06-16 Tom Tromey <tom@tromey.com>
7892
7893 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7894 (tui_free_window, free_content, free_content_elements): Remove
7895 unnecessary cast.
7896 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7897 cast.
7898 * tui/tui-regs.c (tui_show_register_group)
7899 (tui_display_registers_from, tui_display_reg_element_at_line):
7900 Remove unnecessary cast.
7901
bf5142e7
AB
79022019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
7903
7904 * linux-nat.c (normal_mask): Delete.
7905 (_initialize_linux_nat): Don't initialise normal_mask.
7906
c4973306
SM
79072019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
7908
7909 PR gdb/24445
7910 * dwarf-index-write.h (write_psymtabs_to_index): Add
7911 dwz_basename parameter.
7912 * dwarf-index-write.c (write_gdbindex): Move file writing to
7913 write_gdbindex_1. Change return type void.
7914 (assert_file_size): Move up, remove filename parameter.
7915 (write_gdbindex_1): New function.
7916 (write_debug_names): Change return type to void, call
7917 assert_file_size.
7918 (struct index_wip_file): New struct.
7919 (write_psymtabs_to_index): Add dwz_basename parameter. Move
7920 file logic to index_wip_file. Write index for dwz file if
7921 needed.
7922 (save_gdb_index_command): Pass basename of dwz file, if present.
7923 * dwarf-index-cache.c (index_cache::store): Obtain and pass
7924 build-id of dwz file, if present.
7925 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7926 (dwarf2_get_dwz_file): Likewise.
7927 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7928 (dwarf2_get_dwz_file): Likewise.
7929
395f9c91
TT
79302019-06-16 Tom Tromey <tom@tromey.com>
7931
7932 * coffread.c (process_coff_symbol): Use xstrdup.
7933 * value.c (create_internalvar): Use xstrdup.
7934
cafb3438
TT
79352019-06-16 Tom Tromey <tom@tromey.com>
7936
7937 * valops.c (value_cast, value_slice): Remove unnecessary cast.
7938 * breakpoint.c (stopin_command, stopat_command)
7939 (until_break_command, decode_location_default): Remove unnecessary
7940 cast.
7941 * utils.c (subset_compare): Remove unnecessary cast.
7942 * ada-lang.c (ada_update_initial_language): Remove unnecessary
7943 cast.
7944 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7945 cast.
7946 * infcmd.c (path_command): Remove unnecessary cast.
7947 * coffread.c (decode_type): Remove unnecessary cast.
7948 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7949 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7950 * tui/tui-stack.c (tui_show_locator_content)
7951 (tui_show_frame_info): Remove unnecessary cast.
7952 * tui/tui-win.c (tui_scroll_forward_command)
7953 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7954 (parse_scrolling_args): Remove unnecessary cast.
7955 * tui/tui-data.c (init_win_info, tui_del_window)
7956 (tui_free_window, tui_del_data_windows, tui_free_data_content)
7957 (free_content_elements): Remove unnecessary cast.
7958 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7959 unnecessary cast.
7960 * tui/tui-source.c (tui_set_source_content)
7961 (tui_vertical_source_scroll): Remove unnecessary cast.
7962 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7963 cast.
7964 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7965 * tui/tui-regs.c (tui_display_registers_from)
7966 (tui_display_register): Remove unnecessary cast.
7967 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7968 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7969 (make_visible): Remove unnecessary cast.
7970 * tui/tui-winsource.c (tui_erase_source_content)
7971 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7972 unnecessary cast.
7973 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7974 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7975 * stabsread.c (read_type, read_array_type, read_range_type):
7976 Remove unnecessary cast.
7977 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7978 (parse_symbol, parse_type, upgrade_type, parse_external)
7979 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7980 unnecessary cast.
7981 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7982
730ead81
TT
79832019-06-16 Tom Tromey <tom@tromey.com>
7984
7985 * tui/tui-data.c (tui_alloc_generic_win_info)
7986 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7987 checks.
7988
584a927c
AB
79892019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
7990 Andrew Burgess <andrew.burgess@embecosm.com>
7991
7992 * f-typeprint.c (f_print_type): Don't return early for not
7993 associated or not allocated types.
7994 (f_type_print_varspec_suffix): Add print_rank parameter and print
7995 ranks of array types in case they dangling.
7996 (f_type_print_base): Add print_rank parameter.
7997
30056ea0
AB
79982019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7999
8000 * NEWS: Mention new MI commands.
8001 * break-catch-throw.c (enum exception_event_kind): Move to
8002 breakpoint.h.
8003 (print_mention_exception_catchpoint): Output text as a single
8004 message.
8005 (catch_exception_command_1): Rename to...
8006 (catch_exception_event): ...this, make non-static, update header
8007 command, and change some parameter types.
8008 (catch_catch_command): Update for changes to
8009 catch_exception_command_1.
8010 (catch_throw_command): Likewise.
8011 (catch_rethrow_command): Likewise.
8012 * breakpoint.c (enum exception_event_kind): Delete.
8013 * breakpoint.h (enum exception_event_kind): Moved here from
8014 break-catch-throw.c.
8015 (catch_exception_event): Declare.
8016 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8017 (mi_cmd_catch_throw): New function.
8018 (mi_cmd_catch_rethrow): New function.
8019 (mi_cmd_catch_catch): New function.
8020 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8021 'catch-catch' entries.
8022 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8023 (mi_cmd_catch_rethrow): Declare.
8024 (mi_cmd_catch_catch): Declare.
8025
ec8e2b6d
AB
80262019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8027
8028 * annotate.c (annotate_source_line): Change return type to void,
8029 update implementation to match.
8030 * annotate.h (annotate_source_line): Change return type to void,
8031 update header comment.
8032 * stack.c (print_frame_info): Don't change what frame information
8033 is printed based on whether annotations are on or not.
8034
0d3abd8c
AB
80352019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8036
8037 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8038 (annotate_source): Make static.
8039 (annotate_source_line): Moved from source.c and renamed from
8040 identify_source_line. Update the return type.
8041 * annotate.h (annotate_source): Delete declaration.
8042 (annotate_source_line): Declaration moved from source.h, and
8043 renamed from identify_source_line. Return type updated.
8044 * source.c (identify_source_line): Moved to annotate.c and renamed
8045 to annotate_source_line.
8046 (info_line_command): Remove check of annotation_level.
8047 * source.h (identify_source_line): Move declaration to annotate.h
8048 and rename to annotate_source_line.
8049 * stack.c: Add 'annotate.h' include.
8050 (print_frame_info): Remove check of annotation_level before
8051 calling annotate_source_line.
8052
00df30ae
AB
80532019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8054
8055 * source-cache.c (source_cache::get_plain_source_lines): Use
8056 open_source_file_with_line_charpos instead of just
8057 open_source_file, remove call to find_source_lines.
8058 (source_cache::get_source_lines): Likewise.
8059 * source.c (find_source_lines): Make static.
8060 (get_filename_and_charpos): Renamed into...
8061 (open_source_file_with_line_charpos): ..this along with changes to
8062 return a scoped_fd, and some other minor clean ups.
8063 (identify_source_line): Use open_source_file_with_line_charpos.
8064 (search_command_helper): Use open_source_file_with_line_charpos
8065 instead of just open_source_file, remove call to
8066 find_source_lines.
8067 * source.h (open_source_file_with_line_charpos): Declare new
8068 function.
8069 (find_source_lines): Delete declaration.
8070
afda45a2
AB
80712019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8072
8073 * source.c (get_filename_and_charpos): Remove fullname
8074 parameter.
8075 (identify_source_line): Update call to get_filename_and_charpos.
8076
0735b091
TT
80772019-06-14 Tom Tromey <tromey@adacore.com>
8078
8079 PR gdb/24502:
8080 * ui-style.h (skip_ansi_escape): Update comment.
8081 * ui-file.h (class no_terminal_escape_file): New class.
8082 * ui-file.c (no_terminal_escape_file::write)
8083 (no_terminal_escape_file::puts): New methods.
8084 * cli/cli-logging.c (handle_redirections): Use
8085 no_terminal_escape_file.
8086
52ce35e2
TT
80872019-06-14 Tom Tromey <tromey@adacore.com>
8088
8089 * NEWS: Move convenience variable news above Python news.
8090
73cc7272
TT
80912019-06-14 Tom Tromey <tom@tromey.com>
8092
8093 * gnulib: Move directory to top-level.
8094 * configure.ac: Don't configure gnulib.
8095 * configure: Rebuild.
8096 * common/common-defs.h: Use new path to gnulib.
8097 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8098 (GNULIB_H): Remove.
8099 (INCGNU): Look in new gnulib location.
8100 (HFILES_NO_SRCDIR): Remove gnulib files.
8101 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8102 (generated_files): Remove GNULIB_H.
8103 ($(LIBGNU), all-lib): Remove targets.
8104 (distclean): Don't mention GNULIB_BUILDDIR.
8105 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8106
f5686554
TT
81072019-06-14 Tom Tromey <tromey@adacore.com>
8108
8109 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8110 Warn if symbol file does not provide any symbols.
8111
a0c1ffed
TT
81122019-06-14 Tom Tromey <tromey@adacore.com>
8113
8114 * source.c (find_and_open_source): Respect basenames_may_differ.
8115
7c39e397
AB
81162019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8117
8118 * annotate.c (annotate_breakpoints_invalid): Make use of
8119 scoped_restore_terminal_state.
8120 (annotate_frames_invalid): Likewise.
8121
f411722c
TT
81222019-06-14 Tom Tromey <tromey@adacore.com>
8123
8124 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8125 allow assignment to an internalvar.
8126
4268ec18
TT
81272019-06-14 Tom Tromey <tromey@adacore.com>
8128
8129 * ada-lex.l: Allow "_" in attribute names.
8130
abdb711e
TT
81312019-06-14 Tom Tromey <tromey@adacore.com>
8132
8133 PR gdb/24653:
8134 * regcache.c (registers_changed): Don't call alloca.
8135 * top.c (execute_command): Don't call alloca.
8136
4c048731
PA
81372019-06-13 Pedro Alves <palves@redhat.com>
8138
8139 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8140 'expression'. When parsing an expression, error out if there's
8141 junk after "unlimited".
8142 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8143 (do_set_command): Adjust calls to is_unlimited_literal.
8144
66eb1ed3
PA
81452019-06-13 Pedro Alves <palves@redhat.com>
8146
8147 * compile/compile.c (make_compile_options_def_group): Add braces
8148 around array_view initializer.
8149 * thread.c (make_thread_apply_all_options_def_group)
8150 (make_thread_apply_all_options_def_group): Likewise.
8151
3345721a
PA
81522019-06-13 Pedro Alves <palves@redhat.com>
8153
8154 * NEWS (New commands): Mention "maint test-options
8155 require-delimiter", "maint test-options unknown-is-error", "maint
8156 test-options unknown-is-operand" and "maint show
8157 test-options-completion-result".
8158 (New command options, command completion): New section.
8159 (Completion improvements): New section.
8160 Mention that you can abbreviate "unlimited".
8161
6206060d
PA
81622019-06-13 Pedro Alves <palves@redhat.com>
8163
8164 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8165 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8166 * unittests/cli-utils-selftests.c (test_parse_flags)
8167 (test_parse_flags_qcs): Delete.
8168 (test_cli_utils): Don't call deleted functions.
8169
6665660a
PA
81702019-06-13 Pedro Alves <palves@redhat.com>
8171
8172 * thread.c: Include "cli/cli-option.h".
8173 (tp_array_compar_ascending): Global.
8174 (tp_array_compar): Delete function.
8175 (tp_array_compar_ascending, tp_array_compar_descending): New
8176 functions.
8177 (ascending_option_def, qcs_flag_option_def)
8178 (thr_qcs_flags_option_defs)
8179 (make_thread_apply_all_options_def_group)
8180 (make_thread_apply_options_def_group): New.
8181 (thread_apply_all_command): Use gdb::option::process_options.
8182 (thread_apply_command_completer)
8183 (thread_apply_all_command_completer): New.
8184 (thread_apply_command): Use gdb::option::process_options.
8185 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8186 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8187 to generate help text of "thread apply". Adjust "taas"'s help.
8188 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8189 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8190
f7e13587
PA
81912019-06-13 Pedro Alves <palves@redhat.com>
8192
8193 * thread.c (thread_apply_command): Check for invalid TID with
8194 isdigit instead of !isalpha.
8195
5d707134
PA
81962019-06-13 Pedro Alves <palves@redhat.com>
8197
8198 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8199 (validate_flags_qcs): New.
8200 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8201 (validate_flags_qcs): Declare.
8202 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8203 (make_frame_apply_options_def_group): New.
8204 (frame_apply_command_count): Process options with
8205 gdb::option::process_options.
8206 (frame_apply_completer): New.
8207 (frame_apply_level_completer, frame_apply_all_completer)
8208 (frame_apply_completer): New.
8209 (_initialize_stack): Update help of "frame apply", "frame apply
8210 level", "frame apply all" and "faas" to mention supported options
8211 and install command completers.
8212 * stack.h (frame_apply_all_completer): Declare.
8213 * thread.c: Include "stack.h".
8214 (tfaas_command): Add "--".
8215 (_initialize_thread): Update help "tfaas" to mention supported
8216 options and install command completer.
8217
272d4594
PA
82182019-06-13 Pedro Alves <palves@redhat.com>
8219
8220 * completer.c (complete_nested_command_line): New.
8221 (gdb_completion_word_break_characters_throw): Add assertion.
8222 * completer.h (complete_nested_command_line): Declare.
8223
90a1ef87
PA
82242019-06-13 Pedro Alves <palves@redhat.com>
8225
8226 * stack.c (parse_backtrace_qualifiers): New.
8227 (backtrace_command): Use it.
8228 (backtrace_command_completer): Complete on qualifiers.
8229
d4c16835
PA
82302019-06-13 Pedro Alves <palves@redhat.com>
8231
8232 * frame.c: Include "cli/cli-option.h.
8233 (user_set_backtrace_options): New.
8234 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8235 Delete.
8236 (get_prev_frame): Adjust.
8237 (boolean_option_def, uinteger_option_def)
8238 (set_backtrace_option_defs): New.
8239 (_initialize_frame): Adjust and use
8240 gdb::option::add_setshow_cmds_for_options to install "set
8241 backtrace past-main" and "set backtrace past-entry".
8242 * frame.h: Include "cli/cli-option.h".
8243 (struct frame_print_options): Forward declare.
8244 (print_frame_arguments_all, print_frame_arguments_scalars)
8245 (print_frame_arguments_none): Declare.
8246 (print_entry_values): Delete declaration.
8247 (struct frame_print_options, user_frame_print_options): New.
8248 (struct set_backtrace_options): New.
8249 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8250 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8251 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8252 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8253 (list_args_or_locals): Add frame_print_options parameter.
8254 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8255 * python/py-framefilter.c (enumerate_args): Pass down
8256 USER_FRAME_PRINT_OPTIONS.
8257 * stack.c: Include "cli/cli-option.h".
8258 (print_frame_arguments_all, print_frame_arguments_scalars)
8259 (print_frame_arguments_none): Declare.
8260 (print_raw_frame_arguments, print_entry_values): Delete.
8261 (user_frame_print_options): New.
8262 (boolean_option_def, enum_option_def, frame_print_option_defs):
8263 New.
8264 (struct backtrace_cmd_options): New.
8265 (bt_flag_option_def): New.
8266 (backtrace_command_option_defs): New.
8267 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8268 (print_frame_arg, read_frame_arg, print_frame_args)
8269 (print_frame_info, print_frame): Add frame_print_options parameter
8270 and use it.
8271 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8272 (backtrace_command_1): Add frame_print_options and
8273 backtrace_cmd_options parameters and use them.
8274 (make_backtrace_options_def_group): New.
8275 (backtrace_command): Process command options with
8276 gdb::option::process_options.
8277 (backtrace_command_completer): New.
8278 (_initialize_stack): Extend "backtrace"'s help to mention
8279 supported options. Install completer for "backtrace".
8280 Install some settings commands with add_setshow_cmds_for_options.
8281
2daf894e
PA
82822019-06-13 Pedro Alves <palves@redhat.com>
8283
8284 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8285 and that "set/show print raw frame-arguments" are now deprecated.
8286
8287 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8288 command.
8289 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8290 * stack.c (_initialize_stack): Install "set/show print
8291 raw-frame-arguments", and deprecate "set/show print raw
8292 frame-arguments".
8293 * valprint.c (_initialize_valprint): Deprecate "set/show print
8294 raw".
8295
e6ed716c
PA
82962019-06-13 Pedro Alves <palves@redhat.com>
8297
8298 * compile/compile.c (struct compile_options): New.
8299 (compile_flag_option_def, compile_command_option_defs)
8300 (make_compile_options_def_group): New.
8301 (compile_file_command): Handle options with
8302 gdb::option::process_options.
8303 (compile_file_command_completer): New function.
8304 (compile_code_command): Handle options with
8305 gdb::option::process_options.
8306 (compile_code_command_completer): New function.
8307 (_initialize_compiler): Install completers for "compile code" and
8308 "compile file". Mention available options in "compile code" and
8309 "compile code"'s help.
8310 * completer.c (advance_to_completion_word): New, factored out from
8311 ...
8312 (advance_to_expression_complete_word_point): ... this.
8313 (advance_to_filename_complete_word_point): New.
8314 * completer.h (advance_to_filename_complete_word_point): New
8315 declaration.
8316
7d8062de
PA
83172019-06-13 Pedro Alves <palves@redhat.com>
8318
8319 * compile/compile.c: Include "cli/cli-option.h".
8320 (compile_print_value): Scope data pointer is now a
8321 value_print_options pointer; adjust.
8322 (compile_print_command): Process options. Scope data pointer is
8323 now a value_print_options pointer; adjust.
8324 (_initialize_compile): Update "compile print"'s help to include
8325 supported options. Install a completer for "compile print".
8326 * cp-valprint.c (show_vtblprint, show_objectprint)
8327 (show_static_field_print): Delete.
8328 (_initialize_cp_valprint): Don't install "set print
8329 static-members", "set print vtbl", "set print object" here.
8330 * printcmd.c: Include "cli/cli-option.h" and
8331 "common/gdb_optional.h".
8332 (print_command_parse_format): Rework to fill in a
8333 value_print_options instead of a format_data.
8334 (print_value): Change parameter type from format_data pointer to
8335 value_print_options reference. Adjust.
8336 (print_command_1): Process options. Adjust to pass down a
8337 value_print_options.
8338 (print_command_completer): New.
8339 (_initialize_printcmd): Install print_command_completer as
8340 handle_brkchars completer for the "print" command. Update
8341 "print"'s help to include supported options.
8342 * valprint.c: Include "cli/cli-option.h".
8343 (show_vtblprint, show_objectprint, show_static_field_print): Moved
8344 here from cp-valprint.c.
8345 (boolean_option_def, uinteger_option_def)
8346 (value_print_option_defs, make_value_print_options_def_group):
8347 New. Use gdb::option::add_setshow_cmds_for_options to install
8348 "set print elements", "set print null-stop", "set print repeats",
8349 "set print pretty", "set print union", "set print array", "set
8350 print address", "set print symbol", "set print array-indexes".
8351 * valprint.h: Include <string> and "cli/cli-option.h".
8352 (make_value_print_options_def_group): Declare.
8353 (print_value): Change parameter type from format_data pointer to
8354 value_print_options reference.
8355 (print_command_completer): Declare.
8356
9d0faba9
PA
83572019-06-13 Pedro Alves <palves@redhat.com>
8358
8359 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8360 (COMMON_SFILES): Add maint-test-settings.c.
8361 * cli/cli-decode.c (boolean_enums): New global, factored out from
8362 ...
8363 (add_setshow_boolean_cmd): ... here.
8364 * cli/cli-decode.h (boolean_enums): Declare.
8365 * cli/cli-option.c: New file.
8366 * cli/cli-option.h: New file.
8367 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8368 factored out from ...
8369 (parse_cli_boolean_value(const char *)): ... this.
8370 (is_unlimited_literal): Change parameter type to pointer to
8371 pointer. Adjust and advance ARG pointer.
8372 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8373 (parse_cli_var_enum): New, factored out from ...
8374 (do_set_command): ... this. Adjust.
8375 * cli/cli-setshow.h (parse_cli_boolean_value)
8376 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8377 (parse_cli_var_enum): Declare.
8378 * cli/cli-utils.c: Include "cli/cli-option.h".
8379 (get_ulongest): New.
8380 * cli/cli-utils.h (get_ulongest): Declare.
8381 (check_for_argument): New overloads.
8382 * maint-test-options.c: New file.
8383
2c722807
PA
83842019-06-13 Pedro Alves <palves@redhat.com>
8385
8386 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8387 parse a range if "-" is at the end of the string.
8388
dee7b4c8
PA
83892019-06-13 Pedro Alves <palves@redhat.com>
8390
8391 * cli/cli-setshow.c (parse_auto_binary_operation)
8392 (parse_cli_boolean_value): Don't allow "o".
8393
dca0f6c0
PA
83942019-06-13 Pedro Alves <palves@redhat.com>
8395
8396 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8397 * NEWS: Mention maint test-settings KIND.
8398 * maint-test-settings.c: New file.
8399
597bf39d
PA
84002019-06-13 Pedro Alves <palves@redhat.com>
8401
8402 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8403 completer.
8404 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8405 "set" completers.
8406
48c410fb
PA
84072019-06-13 Pedro Alves <palves@redhat.com>
8408
8409 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8410 after item.
8411
93bcb043
PA
84122019-06-13 Pedro Alves <palves@redhat.com>
8413
8414 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8415
cbba3ecd
PA
84162019-06-13 Pedro Alves <palves@redhat.com>
8417
8418 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8419 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8420 call.
8421 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8422 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8423 calls.
8424 (check_for_argument): Skip spaces after argument.
8425
b9a3f842
PA
84262019-06-13 Pedro Alves <palves@redhat.com>
8427
8428 * thread.c (thread_apply_command): Adjust TID parsing.
8429 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8430 detected before end of string.
8431 (tid_is_in_list): Error out if LIST is invalid.
8432
3844e605
PA
84332019-06-13 Pedro Alves <palves@redhat.com>
8434
8435 * completer.c (complete_line_internal_1): Rewind completion word
8436 point.
8437 (completion_tracker::advance_custom_word_point_by): Change
8438 parameter type to int.
8439 * completer.h (completion_tracker::advance_custom_word_point_by):
8440 Likewise.
8441
00b56dbe
PA
84422019-06-13 Pedro Alves <palves@redhat.com>
8443
8444 * completer.c (advance_to_completion_word): Handle delimiters.
8445
d106773e
PA
84462019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
8447
8448 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8449
08f10e02
TT
84502019-06-11 Tom Tromey <tom@tromey.com>
8451
8452 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8453 (xmalloc_failed): Move to alloc.c.
8454 * alloc.c: New file.
8455 * Makefile.in (COMMON_SFILES): Add alloc.c.
8456
1c7fe951
TT
84572019-06-11 Tom Tromey <tom@tromey.com>
8458
8459 * nat/linux-waitpid.c: Don't include server.h.
8460 (linux_debug): Remove.
8461 (my_waitpid): Update.
8462
89549d7f
TT
84632019-06-11 Tom Tromey <tromey@adacore.com>
8464
8465 * infcall.c (_initialize_infcall): Remove trailing newline from
8466 help.
8467 * user-regs.c (_initialize_user_regs): Remove trailing newline
8468 from help.
8469 * typeprint.c (_initialize_typeprint): Remove trailing newline
8470 from help.
8471 * reverse.c (_initialize_reverse): Remove trailing newlines from
8472 help.
8473 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8474 from help.
8475 * language.c (add_set_language_command): Remove trailing newline
8476 from help.
8477 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8478 help.
8479 * disasm.c (_initialize_disasm): Remove trailing newline from
8480 help.
8481 * top.c (init_main): Remove trailing newline from help.
8482 * interps.c (_initialize_interpreter): Remove trailing newline
8483 from help.
8484 * btrace.c (_initialize_btrace): Remove trailing newlines from
8485 help.
8486 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8487 from help.
8488 * python/python.c (_initialize_python): Remove trailing newline
8489 from help.
8490 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8491 help.
8492 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8493 from help. Reformat some text.
8494 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8495 from help.
8496 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8497 newline from help.
8498
86108c13
TT
84992019-06-11 Tom Tromey <tromey@adacore.com>
8500
8501 * darwin-nat.c (darwin_decode_exception_message)
8502 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8503
a7067863
AB
85042019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
8505
8506 * valops.c (value_slice): Check for not allocated or not
8507 associated values.
8508
9ab08412
TV
85092019-06-10 Tom de Vries <tdevries@suse.de>
8510
8511 PR gdb/24618
8512 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8513 sure an empty slot (defined by a 32-bit zero pair) is recognized as
8514 invalid.
8515
f19e22e9
TV
85162019-06-10 Tom de Vries <tdevries@suse.de>
8517
8518 PR gdb/24611
8519 * linespec.c (linespec_lexer_lex_string): Remove incorrect
8520 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
8521
e99f9db0
TV
85222019-06-10 Tom de Vries <tdevries@suse.de>
8523
8524 PR symtab/24545
8525 * symtab.c (struct demangled_name_entry): Add language field.
8526 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
8527 static minimal symbol". Set and use language field.
8528
9bf7038b
TT
85292019-06-10 Tom Tromey <tromey@adacore.com>
8530
8531 * ada-lang.c (_initialize_ada_language): Update help text.
8532
422186a9
TT
85332019-06-10 Tom Tromey <tromey@adacore.com>
8534
8535 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8536 with a newline.
8537 * guile/guile.c (handle_boot_error): Don't end warning with a
8538 newline.
8539 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8540 warning with a newline.
8541 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8542 newline.
8543 (s12z_frame_cache): Likewise.
8544 * dwarf-index-cache.c (index_cache::store): Don't end warning with
8545 a newline.
8546 * solib-svr4.c (disable_probes_interface): Don't end warning with
8547 a newline.
8548 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8549 newline.
8550 * python/python.c (do_finish_initialization): Don't end warning
8551 with a newline.
8552
25ce02ee
TT
85532019-06-10 Tom Tromey <tom@tromey.com>
8554
8555 * python/py-breakpoint.c (gdbpy_breakpoint_created)
8556 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8557 gdbpy_enter.
8558
caa429d8
TT
85592019-06-10 Tom Tromey <tromey@adacore.com>
8560
8561 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8562 data.
8563 (elf_new_init): Don't call stabsread_new_init.
8564 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8565 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
8566 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8567
81873cc8
TV
85682019-06-10 Tom de Vries <tdevries@suse.de>
8569
8570 PR symtab/16264
8571 PR symtab/24517
8572 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8573
4fa0265e
РИ
85742019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
8575
8576 * source.c (find_and_open_source): Also rewrite relative file
8577 names.
8578
1a3da2cd
AB
85792019-04-26 Amos Bird <amosbird@gmail.com>
8580
8581 * annotate.c (annotate_thread_exited): Add "thread-exited"
8582 annotation.
8583
3847a7bf
TT
85842019-06-06 Tom Tromey <tromey@adacore.com>
8585
8586 * maint.h (class scoped_command_stats): Use
8587 DISABLE_COPY_AND_ASSIGN.
8588 <print_time>: New method.
8589 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8590 print_time.
8591 (scoped_command_stats::print_time): New method.
8592
312617a3
AB
85932019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
8594
8595 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8596 instructions of lengths 6 or 8 bytes.
8597
b02f78f9
PA
85982019-06-04 Pedro Alves <palves@redhat.com>
8599
8600 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8601
8602 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8603 * breakpoint.c (condition_completer): Likewise.
8604 * cli/cli-dump.c (scan_expression): Likewise.
8605 * common/filestuff.c (mkdir_recursive): Likewise.
8606 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8607 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8608 (gdb_abspath): Likewise.
8609 * compile/compile-cplus-types.c
8610 (compile_cplus_instance::decl_name): Likewise.
8611 * completer.c (complete_explicit_location):
8612 (signal_completer, reg_or_group_completer_1): Likewise.
8613 * cp-support.c (cp_remove_params_if_any): Likewise.
8614 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8615 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8616 * infcmd.c (strip_bg_char): Likewise.
8617 * linespec.c (copy_token_string): Likewise.
8618 * mi/mi-main.c (output_cores): Likewise.
8619 * psymtab.c (psymtab_search_name):
8620 * symfile.c (test_set_ext_lang_command): Likewise.
8621 * target.c (target_fileio_read_stralloc): Likewise.
8622 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8623 * value.c (complete_internalvar): Likewise.
8624
e1f2e1a2
CB
86252019-06-04 Christian Biesinger <cbiesinger@google.com>
8626
8627 Add objfile property to gdb.Type.
d3238f7d
PA
8628 * NEWS: Mention Python API addition.
8629 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 8630
e664d728
PW
86312019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8632
8633 * NEWS: Mention the new set|show style [title|highlight].
8634 Mention changes to "show style", "help" and "apropos".
8635
66d8c862
PW
86362019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8637
8638 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8639 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
8640 instead of print_help_for_command.
8641 (print_doc_of_command): New function.
8642 (help_list): Add 'apropos -v word' suggestion.
8643 (print_help_for_command): Style the command name using title style.
8644 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8645 (_initialize_cli_cmds): Describe -v in apropos_command help.
8646
9303eb2f
PW
86472019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8648
8649 * cli/cli-style.h (cli_style_option): Add name in constructor,
8650 add m_name class member, add constructor with intensity,
8651 add name class function.
8652 (cli_style_option::add_setshow_commands): Remove name argument.
8653 (highlight_style, title_style): New styles.
8654 * cli/cli-style.c (do_show): New function that shows a style
8655 characteristic styling the style name with itself.
8656 (set_style_name): New function.
8657 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8658 Update all callers according to the changes in cli/cli-style.h.
8659 * utils.h (fputs_highlighted): New function.
8660 * utils.c (fputs_highlighted): Likewise.
8661
e2c52041
PW
86622019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8663
8664 * NEWS: Mention new pipe command and new convenience variables.
8665
947d3946
PW
86662019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8667
8668 * cli/cli-cmds.c (pipe_command): New function.
8669 (_initialize_cli_cmds): Call add_com for pipe_command.
8670 Define | as an alias for pipe.
8671 (exit_status_set_internal_vars): New function.
8672 (shell_escape): Call exit_status_set_internal_vars.
8673 cli/cli-decode.c (find_command_name_length): Recognize | as
8674 a single character command.
8675
b8fd0918
PW
86762019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8677
8678 * gdbcmd.h (execute_command_to_ui_file): New declaration.
8679 top.c (execute_command_to_ui_file): New function, mostly a copy
8680 of execute_command_to_string.
8681 (execute_command_to_string): Implement by calling
8682 execute_command_to_ui_file.
8683
68bb5386
PW
86842019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8685
8686 * top.h (saved_command_line): Remove declaration.
8687 * top.c (previous_saved_command_line, previous_repeat_arguments):
8688 New variables.
8689 (saved_command_line): Make static, define together with other
8690 'repeat variables'.
8691 (dont_repeat): Clear repeat_arguments.
8692 (repeat_previous, get_saved_command_line, save_command_line):
8693 New functions.
8694 (gdb_init): Initialize saved_command_line
8695 and previous_saved_command_line.
8696 * main.c (captured_main_1): Remove saved_command_line initialization.
8697 * event-top.c (handle_line_of_input): Update to use
8698 the new 'repeat' related functions instead of direct access to
8699 saved_command_line.
8700 * command.h (repeat_previous, get_saved_command_line,
8701 save_command_line): New declarations.
8702 (dont_repeat): Add comment.
8703
bfcdb852
TT
87042019-05-30 Tom Tromey <tromey@adacore.com>
8705
8706 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8707 Fix comment.
8708 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8709
0ef209f2
JV
87102019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
8711
8712 PR cli/24587
8713 * completer.c (complete): Initialize variable word.
8714
955b06fa
SDJ
87152019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
8716
8717 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8718 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8719 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8720 'body' is NULL to the outter 'if', protecting the '!is_define'
8721 situation as well.
8722
fa9c3fa0
TT
87232019-05-29 Tom Tromey <tromey@adacore.com>
8724
8725 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8726 (dwarf_unknown): New function.
8727 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8728 (dwarf_type_encoding_name): Use dwarf_unknown.
8729
4330d61d
TT
87302019-05-29 Tom Tromey <tromey@adacore.com>
8731
8732 PR c++/20020:
8733 * cp-valprint.c (cp_print_value_fields): Call
8734 cp_print_static_field inside "try".
8735
33a6bc35
TT
87362019-05-29 Tom Tromey <tromey@adacore.com>
8737
8738 * inflow.c (struct terminal_info): Add default operator=.
8739 * configure: Rebuild.
8740 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8741 -Wdeprecated-copy-dtor, -Wredundant-move.
8742
000439d5
TT
87432019-05-29 Tom Tromey <tromey@adacore.com>
8744
8745 * NEWS: Add entry.
8746 * infcmd.c (print_return_value_1): Handle finish_print
8747 option.
8748 (show_print_finish): New function.
8749 (_initialize_infcmd): Add "set/show print finish" commands.
8750 * valprint.c (user_print_options): Initialize new member.
8751 * valprint.h (struct value_print_options) <finish_print>: New
8752 member.
8753
c0e70c62
TT
87542019-05-28 Tom Tromey <tromey@adacore.com>
8755
8756 * ada-lang.c (ada_remove_Xbn_suffix)
8757 (find_old_style_renaming_symbol)
8758 (parse_old_style_renaming): Remove.
8759 (ada_find_renaming_symbol): Don't call
8760 find_old_style_renaming_symbol.
8761 (ada_is_renaming_symbol): Rename from
8762 ada_find_renaming_symbol. Remove "block" parameter. Return
8763 bool. Now static.
8764 (ada_read_var_value): Update and simplify.
8765 * ada-exp.y (write_var_or_type): Remove old code.
8766
766f8836
AH
87672019-05-28 Alan Hayward <alan.hayward@arm.com>
8768
68255adc 8769 PR gdb/25010
766f8836
AH
8770 * event-top.c: Remove include comment.
8771 * inflow.c (class scoped_ignore_sigttou): Move from here...
8772 * inflow.h (class scoped_ignore_sigttou): ...to here.
8773 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8774 * top.c: Remove include comment.
8775
eb41253a
TT
87762019-05-27 Tom Tromey <tom@tromey.com>
8777
8778 * NEWS: Fix typo.
8779
4ca51187
TT
87802019-05-22 Tom Tromey <tromey@adacore.com>
8781
8782 * target.c (target_follow_exec): Constify parameter.
8783 * target-delegates.c: Rebuild.
8784 * remote.c (remote_target::follow_exec): Constify parameter.
8785 * infrun.c (follow_exec): Constify parameter.
8786 * target.h (struct target_ops) <follow_exec>: Constify parameter.
8787 (target_follow_exec): Likewise.
8788
8fca4da0
AH
87892019-05-22 Alan Hayward <alan.hayward@arm.com>
8790
8791 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8792 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8793
b7060614
AH
87942019-05-22 Alan Hayward <alan.hayward@arm.com>
8795
8796 * NEWS: Add debugredirect and testsuite sections.
8797
0a5954bd
SC
87982019-05-22 Simon Cook <simon.cook@embecosm.com>
8799
8800 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8801 target descriptions using exclusively floating point register name
8802 aliases.
8803
dc42e902
AB
88042019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
8805
8806 PR gdb/18644:
8807 * f-lang.c (build_fortran_types): Handle the case where
8808 gdbarch_floatformat_for_type returns a nullptr.
8809
fb7806c7
TV
88102019-05-21 Tom de Vries <tdevries@suse.de>
8811
8812 PR cli/24587
8813 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8814
34d11c68
AB
88152019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
8816
8817 PR gdb/18644:
8818 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8819 16-byte floats.
8820 * i386-tdep.c (i386_floatformat_for_type): Use
8821 floatformats_ia64_quad for the 16-byte floating point component
8822 within a fortran 32-byte complex number.
8823
122cf0f2
AB
88242019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
8825
8826 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8827 delete default constructor.
8828 (find_partial_die): Update to return const struct.
8829 (partial_die_parent_scope): Move variable declaration into scope
8830 of its use and change its type to auto.
8831 (guess_partial_die_structure_name): Likewise.
8832 (partial_die_info::fixup): Likewise.
8833
33d0e35a
TT
88342019-05-17 Tom Tromey <tromey@adacore.com>
8835
8836 * source.c (find_and_open_source): Remove cast.
8837
a45575b0
TT
88382019-05-17 Tom Tromey <tromey@adacore.com>
8839
8840 * annotate.c (annotate_source): Make "filename" const.
8841 * annotate.h (annotate_source): Use const.
8842
81f47ac2
AH
88432019-05-17 Alan Hayward <alan.hayward@arm.com>
8844
8845 * disasm.c (set_disassembler_options): Send errors to stderr.
8846
ca1285d1
AH
88472019-05-17 Alan Hayward <alan.hayward@arm.com>
8848
8849 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8850 (cli_interp_base::set_logging): Check debug_redirect.
8851 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8852 * cli/cli-logging.c (debug_redirect): Add static variable.
8853 (pop_output_files): Add default param.
8854 (handle_redirections): Print debug setting.
8855 (show_logging_command): Likewise.
8856 (_initialize_cli_logging): Add debugredirect command.
8857 * interps.c (current_interp_set_logging): Add debug_redirect
8858 parameter.
8859 * interps.h (set_logging): Add debug_redirect parameter.
8860 (current_interp_set_logging): Likewise.
8861 * mi/mi-common.h: Likewise.
8862 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8863
88642019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
8865 Tom Tromey <tromey@adacore.com>
8866
8867 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8868 directly.
8869 * cli/cli-interp.h (make_logging_output): Remove declaration.
8870 * cli/cli-logging.c (make_logging_output): Remove function.
8871 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8872 directly.
8873 * ui-file.c (tee_file::tee_file): Remove bools.
8874 (tee_file::~tee_file): Remove deletes.
8875 * ui-file.h (tee_file): Remove bools.
8876
26648588
JV
88772019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
8878
8879 * mi/mi-cmds.h (mi_cmd_complete): New function.
8880 * mi/mi-main.c (mi_cmd_complete): Likewise.
8881 * mi/mi-cmds.c: Define new MI command -complete.
8882 * NEWS: Mention new -complete command.
8883
6e035501
JV
88842019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
8885
8886 * completer.h (complete): New function.
8887 * completer.c (complete): Likewise.
8888 * cli/cli-cmds.c: (complete_command): Update to use new complete()
8889 function defined in completer.h.
8890
7d0e2ece
JV
88912019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
8892
e79be6e5 8893 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 8894
fb816e8b
TV
88952019-05-17 Tom de Vries <tdevries@suse.de>
8896
8897 PR gdb/24094
8898 * dwarf2read.c (struct cu_partial_die_info): New struct.
8899 (find_partial_die): Return cu_partial_die_info.
8900 (partial_die_parent_scope, guess_partial_die_structure_name)
8901 (partial_die_info::fixup): Handle new return type of find_partial_die.
8902
677052f2
SDJ
89032019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8904
a1726c38 8905 PR breakpoints/24541
677052f2
SDJ
8906 * stap-probe.c (stap_parse_register_operand): Make "regname" an
8907 "std::string", simplifying the algorithm.
8908
f3da9116
SDJ
89092019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8910
8911 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8912 (stap_static_probe_ops::get_probes): Likewise.
8913
f1bb75ab
SDJ
89142019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8915
8916 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8917 '-')" and "else if".
8918 (stap_parse_single_operand): Join checks for
8919 "gdbarch_stap_parse_special_token_p" and
8920 "gdbarch_stap_parse_special_token" in the same "if" statement.
8921 Invert check when verifying for operation on register
8922 displacement.
8923
3ca58cde
SDJ
89242019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8925
8926 * stap-probe.c (stap_get_opcode): Update comment.
8927 (stap_get_expected_argument_type): Likewise.
8928 (handle_stap_probe): Likewise.
8929
af2d9bee
SDJ
89302019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8931
8932 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8933 return type to 'bool'. Adjust comment. Use 'bool' when
8934 appropriate.
8935 (i386_stap_parse_special_token_three_arg_disp): Likewise.
8936 * stap-probe.c (stap_parse_argument_1): Likewise.
8937 (stap_is_operator): Likewise.
8938 (stap_is_generic_prefix): Likewise.
8939 (stap_is_register_prefix): Likewise.
8940 (stap_is_register_indirection_prefix): Likewise.
8941 (stap_is_integer_prefix): Likewise.
8942 (stap_generic_check_suffix): Likewise.
8943 (stap_check_integer_suffix): Likewise.
8944 (stap_check_register_suffix): Likewise.
8945 (stap_check_register_indirection_suffix): Likewise.
8946 (stap_parse_register_operand): Likewise.
8947 (stap_parse_single_operand): Likewise.
8948 (stap_parse_argument_1): Likewise.
8949 (stap_probe::get_argument_count): Likewise.
8950 (stap_is_operator): Likewise.
8951
61c9c421
TT
89522019-05-16 Tom Tromey <tromey@adacore.com>
8953
8954 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8955 keyword to foreach.
8956
9ddc1af1
SM
89572019-05-15 Simon Marchi <simon.marchi@efficios.com>
8958
8959 * linux-thread-db.c (try_thread_db_load_1): Change return type
8960 to bool.
8961 (try_thread_db_load): Likewise.
8962 (try_thread_db_load_from_pdir_1): Likewise.
8963 (try_thread_db_load_from_pdir): Likewise.
8964 (try_thread_db_load_from_sdir): Likewise.
8965 (try_thread_db_load_from_dir): Likewise.
8966 (thread_db_load_search): Likewise.
8967 (has_libpthread): Likewise.
8968 (thread_db_load): Likewise.
8969
7bede828
SDJ
89702019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
8971
8972 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8973 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8974 NULL, and complain/return if that's the case.
8975
c5358db4
JD
89762019-05-15 John Darrington <john@darrington.wattle.id.au>
8977
8978 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8979 (advance, posn, abstract_read_memory): New functions.
8980 [struct mem_read_abstraction]: New struct.
8981 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8982
c408a94f
TT
89832019-05-14 Tom Tromey <tromey@adacore.com>
8984
8985 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8986 value is not lval_memory.
8987
e7bd7fba
TT
89882019-05-14 Tom Tromey <tromey@adacore.com>
8989
8990 * solib.c (info_sharedlibrary_command): Style the file name.
8991
a6d0f249
AH
89922019-05-14 Alan Hayward <alan.hayward@arm.com>
8993
8994 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8995 (aarch64_vnv_type): Likewise.
8996 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8997 * common/tdesc.c: Likewise.
8998 * common/tdesc.h (enum tdesc_type_kind): Likewise.
8999 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9000 * features/aarch64-fpu.xml: Add ieee half view.
9001 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9002 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9003 * gdbtypes.h (struct builtin_type): Likewise.
9004 (struct objfile_type): Likewise.
9005
66b8bb74
SM
90062019-05-12 Paul Naert <paul.naert@polymtl.ca>
9007
9008 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9009 typo.
9010 * location.h (string_to_event_location): Likewise.
9011
21c219fd
JB
90122019-05-11 Joel Brobecker <brobecker@adacore.com>
9013
9014 GDB 8.3 released.
9015
13674803
SM
90162019-05-10 Simon Marchi <simon.marchi@efficios.com>
9017
9018 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9019 New variable declaration.
9020 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9021 New variable.
9022 (print_one_breakpoint): Use ui_out::test_flags and new global
9023 variable to compute use_fixed_output.
9024 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9025 Remove.
9026 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9027 (mi_multi_location_breakpoint_output_fixed): Remove.
9028 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9029 new variable.
9030 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9031 fix_multi_location_breakpoint_output flag if version >= 3.
9032 * ui-out.h (enum ui_out_flag)
9033 <fix_multi_location_breakpoint_output>: New enumerator.
9034
a9eac7f9
SM
90352019-05-10 Simon Marchi <simon.marchi@efficios.com>
9036
9037 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9038
71bed2db
TT
90392019-05-10 Tom Tromey <tromey@adacore.com>
9040
9041 * ada-lang.c (catch_ada_completer): New function.
9042 (_initialize_ada_language): Use it.
9043
24c54127
TT
90442019-05-10 Tom Tromey <tromey@adacore.com>
9045
9046 * thread.c (print_thread_info): Make "requested_threads" const.
9047 * gdbthread.h (print_thread_info): Make "requested_threads"
9048 const.
9049 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9050 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9051
7a102139
TT
90522019-05-08 Tom Tromey <tom@tromey.com>
9053
9054 * gdbtypes.c (objfile_type_data): Change type.
9055 (objfile_type, _initialize_gdbtypes): Update.
9056
924d79e2
TT
90572019-05-08 Tom Tromey <tom@tromey.com>
9058
9059 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9060 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9061 (_initialize_dwarf2_frame): Update.
9062
4c58e337
TT
90632019-05-08 Tom Tromey <tom@tromey.com>
9064
9065 * objc-lang.c (objc_objfile_data): Change type.
9066 (find_methods): Update.
9067 (_initialize_objc_lang): Remove.
9068
d772d2ab
TT
90692019-05-08 Tom Tromey <tom@tromey.com>
9070
9071 * stabsread.c (rs6000_builtin_type_data): Change type.
9072 (rs6000_builtin_type, _initialize_stabsread): Update.
9073
d11d83f4
TT
90742019-05-08 Tom Tromey <tom@tromey.com>
9075
9076 * mips-tdep.c (mips_pdr_data): Remove.
9077 (_initialize_mips_tdep): Update.
9078
9a73f0ad
TT
90792019-05-08 Tom Tromey <tom@tromey.com>
9080
9081 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9082 (hppa_init_objfile_priv_data, read_unwind_info)
9083 (find_unwind_entry, _initialize_hppa_tdep): Update.
9084
8127a2fa
TT
90852019-05-08 Tom Tromey <tom@tromey.com>
9086
9087 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9088 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9089 on obstack.
9090 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9091
91d3055d
TT
90922019-05-08 Tom Tromey <tom@tromey.com>
9093
9094 * mdebugread.c (basic_type_data): Change type.
9095 (basic_type, _initialize_mdebugread): Update.
9096
31930bd3
TT
90972019-05-08 Tom Tromey <tom@tromey.com>
9098
9099 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9100
bdb3ed9e
TT
91012019-05-08 Tom Tromey <tom@tromey.com>
9102
9103 * nto-tdep.c (nto_inferior_data_reg): Change type.
9104 (nto_inferior_data): Update.
9105 (nto_inferior_data_cleanup, nto_new_inferior_data)
9106 (_initialize_nto_tdep): Remove.
9107 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9108
f37b313d
TT
91092019-05-08 Tom Tromey <tom@tromey.com>
9110
9111 * ada-lang.c (struct ada_inferior_data): Add initializers.
9112 (ada_inferior_data): Change type.
9113 (ada_inferior_data_cleanup): Remove.
9114 (get_ada_inferior_data, ada_inferior_exit)
9115 (struct ada_pspace_data): Add initializers, destructor.
9116 (ada_pspace_data_handle): Change type.
9117 (get_ada_pspace_data): Update.
9118 (ada_pspace_data_cleanup): Remove.
9119
24699405
TT
91202019-05-08 Tom Tromey <tom@tromey.com>
9121
9122 * coffread.c (struct coff_symfile_info): Add initializers.
9123 (coff_objfile_data_key): Move lower. Change type.
9124 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9125 Update.
9126 (coff_free_info): Remove.
9127
d4e05d2f
TT
91282019-05-08 Tom Tromey <tom@tromey.com>
9129
9130 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9131 (fbsd_pspace_data_handle): Move lower. Change type.
9132 (get_fbsd_pspace_data): Update.
9133 (fbsd_pspace_data_cleanup): Remove.
9134 (_initialize_fbsd_tdep): Update.
9135
14ef6690
TT
91362019-05-08 Tom Tromey <tom@tromey.com>
9137
9138 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9139 (get_ada_tasks_pspace_data): Update.
9140 (ada_tasks_pspace_data_cleanup): Remove.
9141 (_initialize_tasks): Update.
9142 (ada_tasks_inferior_data_handle): Change type.
9143 (get_ada_tasks_inferior_data): Update.
9144 (ada_tasks_inferior_data_cleanup): Remove.
9145 (struct ada_tasks_pspace_data): Add initializers.
9146
814cf43a
TT
91472019-05-08 Tom Tromey <tom@tromey.com>
9148
9149 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9150 * symfile-debug.c (debug_sym_get_probes): Change type.
9151 * stap-probe.c (handle_stap_probe):
9152 (stap_static_probe_ops::get_probes): Change type.
9153 * probe.h (class static_probe_ops) <get_probes>: Change type.
9154 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9155 (parse_probes_in_pspace): Update.
9156 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9157 Update.
9158 (any_static_probe_ops::get_probes): Change type.
9159 * elfread.c (elfread_data): New typedef.
9160 (probe_key): Change type.
9161 (elf_get_probes): Likewise. Update.
9162 (probe_key_free): Remove.
9163 (_initialize_elfread): Update.
9164 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9165 Change type.
9166 (dtrace_process_dof_probe, dtrace_process_dof)
9167 (dtrace_static_probe_ops::get_probe): Change type.
9168
02dc647e
TT
91692019-05-08 Tom Tromey <tom@tromey.com>
9170
9171 * xcoffread.c (struct xcoff_symfile_info): Rename from
9172 coff_symfile_info. Add initializers.
9173 (xcoff_objfile_data_key): Move lower. Change type.
9174 (XCOFF_DATA): Rewrite.
9175 (xcoff_free_info): Remove.
9176 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9177 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9178 (xcoff_initial_scan): Update.
9179
09232438
TT
91802019-05-08 Tom Tromey <tom@tromey.com>
9181
9182 * solib-svr4.c (struct svr4_info): Add initializers and
9183 destructor.
9184 <probes_table>: Now an htab_up.
9185 (solib_svr4_pspace_data): Change type.
9186 (free_probes_table): Simplify.
9187 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9188 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9189 (probes_table_remove_objfile_probes, register_solib_event_probe)
9190 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9191 (_initialize_svr4_solib): Update.
9192
7b4a314f
TT
91932019-05-08 Tom Tromey <tom@tromey.com>
9194
9195 * remote.c (remote_pspace_data): Change type.
9196 (remote_pspace_data_cleanup): Remove.
9197 (get_remote_exec_file, set_pspace_remote_exec_file)
9198 (_initialize_remote): Update.
9199
51d3063a
TT
92002019-05-08 Tom Tromey <tom@tromey.com>
9201
9202 * breakpoint.c (breakpoint_objfile_key): Change type.
9203 (get_breakpoint_objfile_data): Update.
9204 (free_breakpoint_objfile_data): Remove.
9205 (_initialize_breakpoint): Update.
9206
89fb8848
TT
92072019-05-08 Tom Tromey <tom@tromey.com>
9208
9209 * linux-tdep.c (struct linux_info): Add initializers.
9210 (linux_inferior_data): Move. Change type.
9211 (invalidate_linux_cache_inf): Update.
9212 (linux_inferior_data_cleanup): Remove.
9213 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9214
e9b89e2d
TT
92152019-05-08 Tom Tromey <tom@tromey.com>
9216
9217 * auxv.c (auxv_inferior_data): Move. Change type.
9218 (auxv_inferior_data_cleanup): Remove.
9219 (invalidate_auxv_cache_inf): Rewrite.
9220 (get_auxv_inferior_data, _initialize_auxv): Update.
9221
8c42777c
TT
92222019-05-08 Tom Tromey <tom@tromey.com>
9223
9224 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9225 (symfile_debug_objfile_data_key): Change type.
9226 (symfile_debug_installed, debug_qf_has_symbols)
9227 (debug_qf_find_last_source_symtab)
9228 (debug_qf_forget_cached_source_info)
9229 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9230 (debug_qf_print_stats, debug_qf_dump)
9231 (debug_qf_expand_symtabs_for_function)
9232 (debug_qf_expand_all_symtabs)
9233 (debug_qf_expand_symtabs_with_fullname)
9234 (debug_qf_map_matching_symbols)
9235 (debug_qf_expand_symtabs_matching)
9236 (debug_qf_find_pc_sect_compunit_symtab)
9237 (debug_qf_map_symbol_filenames)
9238 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9239 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9240 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9241 (debug_sym_read_linetable, debug_sym_relocate): Update.
9242 (symfile_debug_free_objfile): Remove.
9243 (install_symfile_debug_logging, _initialize_symfile_debug):
9244 Update.
9245
5bfd760d
TT
92462019-05-08 Tom Tromey <tom@tromey.com>
9247
9248 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9249 allocate_on_obstack.
9250 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9251 (get_dwarf2_per_objfile): Update.
9252 (set_dwarf2_per_objfile): Remove.
9253 (dwarf2_has_info, dwarf2_get_section_info): Update.
9254 (dwarf2_free_objfile): Remove.
9255 (_initialize_dwarf2_read): Update.
9256
e85e19b4
TT
92572019-05-08 Tom Tromey <tom@tromey.com>
9258
9259 * auto-load.c (struct auto_load_pspace_info): Add destructor and
9260 initializers.
9261 <unsupported_script_warning_printed,
9262 script_not_found_warning_printed>: Now bool.
9263 (auto_load_pspace_data): Change type.
9264 (~auto_load_pspace_info): Rename from
9265 auto_load_pspace_data_cleanup.
9266 (get_auto_load_pspace_data, init_loaded_scripts_info)
9267 (clear_section_scripts, maybe_print_unsupported_script_warning)
9268 (maybe_print_script_not_found_warning, _initialize_auto_load):
9269 Update.
9270
f6aa7436
TT
92712019-05-08 Tom Tromey <tom@tromey.com>
9272
9273 * objfiles.c (objfile_pspace_info): Add destructor and
9274 initializers.
9275 (objfiles_pspace_data): Change type.
9276 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9277 (get_objfile_pspace_data): Update.
9278 (objfiles_bfd_data): Change type.
9279 (get_objfile_bfd_data): Update.
9280 (objfile_bfd_data_free, _initialize_objfiles): Remove.
9281
6ae614f6
TT
92822019-05-08 Tom Tromey <tom@tromey.com>
9283
9284 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9285 Change type.
9286 (get_catch_syscall_inferior_data): Update.
9287 (catch_syscall_inferior_data_cleanup): Remove.
9288 (_initialize_break_catch_syscall): Update.
9289
6509b8eb
TT
92902019-05-08 Tom Tromey <tom@tromey.com>
9291
9292 * inflow.c (struct terminal_info): Add destructor and
9293 initializers.
9294 (inflow_inferior_data): Change type.
9295 (~terminal_info): Rename from inflow_inferior_data_cleanup.
9296 (get_inflow_inferior_data, inflow_inferior_exit)
9297 (swap_terminal_info, _initialize_inflow): Update.
9298
35632941
TT
92992019-05-08 Tom Tromey <tom@tromey.com>
9300
9301 * target-dcache.c (target_dcache_cleanup): Remove.
9302 (target_dcache_aspace_key): Change type.
9303 (target_dcache_init_p, target_dcache_invalidate)
9304 (target_dcache_get, target_dcache_get_or_init)
9305 (_initialize_target_dcache): Update.
9306 * dcache.h (struct dcache_deleter): New.
9307
3017b94d
TT
93082019-05-08 Tom Tromey <tom@tromey.com>
9309
9310 * symtab.c (struct symbol_cache): Add destructor and
9311 initializers.
9312 (symbol_cache_key): Move. Change type.
9313 (make_symbol_cache, free_symbol_cache): Remove.
9314 (get_symbol_cache): Update.
9315 (symbol_cache_cleanup): Remove.
9316 (ALL_PSPACES, symbol_cache_flush)
9317 (maintenance_print_symbol_cache)
9318 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9319 Update.
9320
a32ad8c5
TT
93212019-05-08 Tom Tromey <tom@tromey.com>
9322
9323 * symtab.c (struct main_info): Add destructor and initializers.
9324 (main_progspace_key): Move. Change type.
9325 (get_main_info): Update.
9326 (main_info_cleanup): Remove.
9327 (_initialize_symtab): Update.
9328
5f6e90a0
TT
93292019-05-08 Tom Tromey <tom@tromey.com>
9330
9331 * registry.h (DECLARE_REGISTRY): Define the _key class.
9332
1bd0c6e4
AB
93332019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
9334
9335 * NEWS: Merge two 'New commands' sections.
9336
2228ef77
XR
93372019-05-08 Joel Brobecker <brobecker@adacore.com>
9338
9339 * ada-valprint.c (ada_val_print_gnat_array): Remove language
9340 parameter and use Ada language definition instead.
9341 (ada_val_print_ptr): Remove unused language parameter.
9342 (ada_val_print_num): Remove language parameter and use Ada language
9343 definition instead.
9344 (ada_val_print_enum, ada_val_print_flt): Remove unused language
9345 parameter.
9346 (ada_val_print_struct_union, ada_val_print_ref): Remove language
9347 parameter and use Ada language definition instead.
9348 (ada_val_print_1): Update all ada_val_print_xxx calls.
9349 Remove language parameter.
9350 (ada_val_print): Update ada_val_print_1 call.
9351
60fcc1c3
TT
93522019-05-08 Tom Tromey <tromey@adacore.com>
9353
9354 * remote.c (remote_hw_watchpoint_limit)
9355 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9356 Now static.
9357
ed2b7c17
TT
93582019-05-08 Tom Tromey <tromey@adacore.com>
9359
9360 * maint.c (_initialize_maint_cmds): Move initialization code to
9361 remote.c.
9362 (watchdog, show_watchdog): Move to remote.c.
9363 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
9364 "watchdog" static.
9365 (_initialize_remote): Move initialization code from maint.c.
9366 * defs.h (watchdog): Don't declare.
9367
b0be6c91
TT
93682019-05-08 Tom Tromey <tromey@adacore.com>
9369
9370 * tui/tui-interp.c: Include main.h.
9371 * interps.c: Include main.h.
9372 * main.h (interpreter_p): Declare.
9373 * defs.h (interpreter_p): Don't declare.
9374
587ee17b
TT
93752019-05-08 Tom Tromey <tromey@adacore.com>
9376
9377 * dwarf2loc.c: Include dwarf2read.h.
9378 * defs.h (read_unsigned_leb128): Don't declare.
9379 * dwarf2read.h (read_unsigned_leb128): Declare.
9380
ca1df239
TT
93812019-05-08 Tom Tromey <tromey@adacore.com>
9382
9383 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9384 method.
9385
99f20f08
TT
93862019-05-08 Tom Tromey <tromey@adacore.com>
9387
9388 * utils.c (fputs_maybe_filtered): Reset style after paging, even
9389 when no wrap column is set.
9390
80e55b13
TT
93912019-05-08 Tom Tromey <tromey@adacore.com>
9392
9393 * c-lang.c (c_get_string): Handle non-C-style arrays.
9394
9d3421af
TT
93952019-05-08 Tom Tromey <tromey@adacore.com>
9396
9397 * typeprint.c (print_offset_data::update): Print the bit offset,
9398 not the number of bits remaining.
9399
844333e2
TT
94002019-05-08 Tom Tromey <tromey@adacore.com>
9401
9402 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9403 padding at end of comment.
9404
988915ee
TT
94052019-05-08 Tom Tromey <tromey@adacore.com>
9406
9407 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9408 Compare main types.
9409
26bfd823
TT
94102019-05-06 Tom Tromey <tom@tromey.com>
9411
9412 * common/scoped_mmap.c: Include common-defs.h.
9413 * common/scoped_mmap.h: Don't include config.h.
9414
89055eaa
TT
94152019-05-04 Tom Tromey <tom@tromey.com>
9416
9417 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9418 (struct aarch64_call_info): Add initializers.
9419 <si>: Now a std::vector.
9420 (pass_on_stack, aarch64_push_dummy_call): Update.
9421
5da01df5
TT
94222019-05-04 Simon Marchi <simon.marchi@efficios.com>
9423 Tom Tromey <tom@tromey.com>
9424
9425 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9426 (ppc_threads): Now a std::vector. Now static.
9427 (hwdebug_find_thread_points_by_tid)
9428 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9429 Update.
9430
fbdf05a1
TT
94312019-05-04 Tom Tromey <tom@tromey.com>
9432
9433 * arc-tdep.c (arc_tdesc_init): Return bool.
9434
06d16ec9
TT
94352019-05-04 Tom Tromey <tom@tromey.com>
9436
9437 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9438 Use gdb_assert_not_reached.
9439
9c056022
TT
94402019-05-04 Tom Tromey <tom@tromey.com>
9441
9442 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9443 "false".
9444
fa9c2a59
TT
94452019-05-04 Tom Tromey <tom@tromey.com>
9446
9447 * arc-tdep.c (arc_tdesc_init): Use bool.
9448
e2eb806a
TT
94492019-05-04 Tom Tromey <tom@tromey.com>
9450
9451 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9452
6fe87677
TT
94532019-05-04 Tom Tromey <tom@tromey.com>
9454
9455 * cli/cli-cmds.c (valid_command_p): Return bool.
9456
7f008c9e
TT
94572019-05-04 Tom Tromey <tom@tromey.com>
9458
9459 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9460 * command.h (valid_user_defined_cmd_name_p): Channge return type.
9461
b6484282
RT
94622019-05-04 Raul Tambre <raul@tambre.ee>
9463
9464 * python/lib/gdb/prompt.py (_ExtendedPrompt)
9465 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9466 operator for comparison.
9467
af97b416
TT
94682019-05-04 Tom Tromey <tom@tromey.com>
9469
9470 * psymtab.c (psymbol_name_matches, match_partial_symbol)
9471 (lookup_partial_symbol, print_partial_symbols)
9472 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9473 (psymbol_compare): Update.
9474 (add_psymbol_to_bcache): Clear the entire psymbol.
9475 (maintenance_check_psymtabs): Update.
9476 * psympriv.h (struct partial_symbol): Don't derive from
9477 general_symbol_info.
9478 <obj_section, unrelocated_address, address,
9479 set_unrelocated_address>: Update.
9480 <ginfo>: New member.
9481 * dwarf-index-write.c (write_psymbols, debug_names::insert)
9482 (debug_names::write_psymbols): Update.
9483
9d6d4be8
TV
94842019-05-04 Tom de Vries <tdevries@suse.de>
9485
9486 * contrib/cc-with-tweaks.sh: Support -n arg.
9487
66452beb
PW
94882019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9489
9490 * corelow.c (core_target::detach): Ensure frame cache and
9491 register caches are cleared.
9492 inferior.c (exit_inferior_1): Likewise.
9493
bde09ab7
TT
94942019-05-03 Sandra Loosemore <sandra@codesourcery.com>
9495 Tom Tromey <tom@tromey.com>
9496
9497 * dictionary.c (collate_pending_symbols_by_language): Remove
9498 "struct" from foreach.
9499 * symtab.c (lookup_global_symbol_from_objfile)
9500 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9501 foreach.
9502 * ser-tcp.c (net_open): Remove "struct" from foreach.
9503 * objfiles.c (objfile_relocate, objfile_rebase)
9504 (objfile_has_symbols): Remove "struct" from foreach.
9505 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9506 from foreach.
9507 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9508 foreach.
9509 * darwin-nat.c (thread_info_from_private_thread_info): Remove
9510 "struct" from foreach.
9511 * ada-lang.c (create_excep_cond_exprs)
9512 (ada_exception_catchpoint_cond_string): Remove "struct" from
9513 foreach.
9514
222a8d25
TT
95152019-05-03 Tom Tromey <tromey@adacore.com>
9516
9517 * ada-exp.y (convert_char_literal): Check suffix of each
9518 enumerator.
9519
fcd60b84
DP
95202019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
9521
9522 PR ada/21406:
9523 * ada-exp.y (yywrap): Don't define.
9524 * ada-lex.l (%option): Add noyywrap
9525 (yywrap): Remove.
9526
5f2459c2
EZ
95272019-05-03 Eli Zaretskii <eliz@gnu.org>
9528
353ea2d1
EZ
9529 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9530 _WIN32_WINNT to the XP level, unless already defined to a higher
9531 level.
9532
9533 * unittests/parse-connection-spec-selftests.c:
9534 * ser-tcp.c:
9535 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
9536 override.
9537
5f2459c2
EZ
9538 * symfile.c (find_separate_debug_file): Remove colon from the
9539 drive spec of DOS/Windows file names of the target, so that the
9540 file name produced from DEBUGDIR and the target's directory will
9541 be valid on DOS/Windows systems.
9542
80062eb9
AB
95432019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
9544
9545 * rust-lang.c (val_print_struct): Handle printing structures
9546 containing strings.
9547
b8c05e85
TT
95482019-05-02 Tom Tromey <tromey@adacore.com>
9549
9550 * valarith.c (_initialize_valarith): Remove.
9551
4504bbde
TT
95522019-05-01 Tom Tromey <tromey@adacore.com>
9553
9554 * ada-lang.c (ada_value_primitive_field): Treat more fields as
9555 bitfields.
9556
d48e62f4
TT
95572019-05-01 Tom Tromey <tromey@adacore.com>
9558
9559 * ada-lang.c (ada_value_assign): Correctly compute starting offset
9560 for big-endian copies.
9561
15f18d14
AT
95622019-04-30 Ali Tamur <tamur@google.com>
9563 * gdb/dwarf2read.c (read_3_bytes): New declaration.
9564 (read_attribute_value): Added DW_FORM_strx1-4 cases.
9565 (read_3_bytes): New function.
9566
ab4ee614
JB
95672019-04-30 Joel Brobecker <brobecker@adacore.com>
9568
9569 * windows-nat.c (main_thread_id): Delete.
9570 (handle_output_debug_string): Replace main_thread_id by
9571 current_event.dwThreadId.
9572 (fake_create_process): Likewise.
9573 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9574 Do not set main_thread_id.
9575 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9576 current_event.dwThreadId.
9577 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9578
8ed5b76e
JB
95792019-04-30 Joel Brobecker <brobecker@adacore.com>
9580
9581 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9582 Use current_event.dwThreadId instead of main_thread_id.
9583
2ff0a947
TT
95842019-04-30 Tom Tromey <tromey@adacore.com>
9585
9586 * ada-lang.c (ada_lookup_simple_minsyms): New function.
9587 (create_excep_cond_exprs): Iterate over program spaces.
9588 (ada_exception_catchpoint_cond_string): Examine all minimal
9589 symbols for exception types.
9590
a776957c
TT
95912019-04-30 Tom Tromey <tromey@adacore.com>
9592
9593 PR c++/24470:
9594 * dwarf2read.c (process_structure_scope): Handle case where type
9595 has template parameters but no symbol was created.
9596
bc68014d
AB
95972019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9598 Chris January <chris.january@arm.com>
9599
9600 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9601 qualifier.
9602 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9603
f1fdc960
AB
96042019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9605
9606 * f-typeprint.c (f_print_type): Update rules for printing
9607 whitespace.
9608 (f_type_print_varspec_suffix): Likewise.
9609
bf7a4de1
AB
96102019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9611 Chris January <chris.january@arm.com>
9612
9613 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9614 function arguments.
9615
bbe75b9d
AB
96162019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9617
9618 * f-lang.c (build_fortran_types): Change name of void type to
9619 lower case.
9620 * f-typeprint.c (f_type_print_base): Print the name of the void
9621 type, rather than a fixed string.
9622 * f-valprint.c (f_decorations): Use lower case void string.
9623
1db455a7
AB
96242019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9625 Chris January <chris.january@arm.com>
9626
9627 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9628 types for Fortran.
9629
b6d03bb2
AB
96302019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9631 Chris January <chris.january@arm.com>
9632 David Lecomber <david.lecomber@arm.com>
9633
9634 * f-exp.y (BINOP_INTRINSIC): New token.
9635 (exp): New parser rule handling BINOP_INTRINSIC.
9636 (f77_keywords): Add new builtin procedures.
9637 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9638 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9639 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9640 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9641 (print_unop_subexp_f): New function.
9642 (print_binop_subexp_f): New function.
9643 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9644 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9645 (dump_subexp_body_f): Likewise.
9646 (operator_check_f): Likewise.
9647 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9648 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9649
83228e93
AB
96502019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9651
9652 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9653 UNOP_KIND.
9654 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9655 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9656 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9657 (operator_length_f): New fuction.
9658 (print_subexp_f): New function.
9659 (op_name_f): New function.
9660 (dump_subexp_body_f): New function.
9661 (operator_check_f): New function.
9662 (exp_descriptor_f): Replace standard expression handling functions
9663 with new functions.
9664 * gdb/fortran-operator.def: New file.
9665 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9666 * gdb/std-operator.def: Remove UNOP_KIND.
9667
6fdcd7cc
AB
96682019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9669
9670 * std-operator.def: Remove unbalanced, stray double quote
9671 character.
9672
2e62ab40
AB
96732019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
9674 Chris January <chris.january@arm.com>
9675 Daniel Everett <daniel.everett@arm.com>
9676 Nick Forrington <nick.forrington@arm.com>
9677 Richard Bunt <richard.bunt@arm.com>
9678
9679 * cp-valprint.c (cp_print_value_fields): Allow an additional level
9680 of depth when printing anonymous structs or unions.
9681 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9682 Don't print either the top-level value, or the children if the
9683 max-depth is exceeded.
9684 (ppscm_print_children): When printing the key of a map, allow one
9685 extra level of depth.
9686 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9687 print either the top-level value, or the children if the max-depth
9688 is exceeded.
9689 (print_children): When printing the key of a map, allow one extra
9690 level of depth.
9691 * python/py-value.c (valpy_format_string): Add max_depth keyword.
9692 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9693 (user_print_options): Initialise max_depth field.
9694 (val_print_scalar_or_string_type_p): New function.
9695 (val_print): Check to see if the max depth has been reached.
9696 (val_print_check_max_depth): Define new function.
9697 (show_print_max_depth): New function.
9698 (_initialize_valprint): Add 'print max-depth' option.
9699 * valprint.h (struct value_print_options) <max_depth>: New field.
9700 (val_print_check_max_depth): Declare new function.
9701 * NEWS: Document new feature.
9702
4be290b2
AB
97032019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
9704
9705 * ada-lang.c (ada_language_defn): Initialise new field.
9706 * c-lang.c (c_is_string_type_p): New function.
9707 (c_language_defn): Initialise new field.
9708 (cplus_language_defn): Initialise new field.
9709 (asm_language_defn): Initialise new field.
9710 (minimal_language_defn): Initialise new field.
9711 * c-lang.h (c_is_string_type_p): Declare new function.
9712 * d-lang.c (d_language_defn): Initialise new field.
9713 * f-lang.c (f_is_string_type_p): New function.
9714 (f_language_defn): Initialise new field.
9715 * go-lang.c (go_is_string_type_p): New function.
9716 (go_language_defn): Initialise new field.
9717 * language.c (default_is_string_type_p): New function.
9718 (unknown_language_defn): Initialise new field.
9719 (auto_language_defn): Initialise new field.
9720 * language.h (struct language_defn) <la_is_string_type_p>: New
9721 member variable.
9722 (default_is_string_type_p): Declare new function.
9723 * m2-lang.c (m2_language_defn): Initialise new field.
9724 * objc-lang.c (objc_language_defn): Initialise new field.
9725 * opencl-lang.c (opencl_language_defn): Initialise new field.
9726 * p-lang.c (pascal_is_string_type_p): New function.
9727 (pascal_language_defn): Initialise new field.
9728 * rust-lang.c (rust_is_string_type_p): New function.
9729 (rust_language_defn): Initialise new field.
9730
721b08c6
AB
97312019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
9732
9733 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9734 New field.
9735 * ada-lang.c (ada_language_defn): Initialise new field.
9736 * c-lang.c (c_language_defn): Likewise.
9737 (cplus_language_defn): Likewise.
9738 (asm_language_defn): Likewise.
9739 (minimal_language_defn): Likewise.
9740 * d-lang.c (d_language_defn): Likewise.
9741 * f-lang.c (f_language_defn): Likewise.
9742 * go-lang.c (go_language_defn): Likewise.
9743 * language.c (unknown_language_defn): Likewise.
9744 (auto_language_defn): Likewise.
9745 * m2-lang.c (m2_language_defn): Likewise.
9746 * objc-lang.c (objc_language_defn): Likewise.
9747 * opencl-lang.c (opencl_language_defn): Likewise.
9748 * p-lang.c (pascal_language_defn): Likewise.
9749 * rust-lang.c (rust_language_defn): Likewise.
9750
fc913e53
AB
97512019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
9752
9753 * ada-lang.c (ada_is_character_type): Change return type to bool.
9754 (ada_is_string_type): Likewise.
9755 * ada-lang.h (ada_is_character_type): Update declaration
9756 (ada_is_string_type): Likewise.
9757
fa731fa0
PW
97582019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9759
9760 Support style in 'frame|thread apply'
9761
9762 * gdbcmd.h (execute_command_to_string): New term_out parameter.
9763 * record.c (record_start, record_stop): Update callers of
9764 execute_command_to_string with false.
9765 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9766 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9767 methods.
9768 (class string_file): New constructor with term_out parameter.
9769 Override methods term_out and can_emit_style_escape. New member
9770 term_out.
9771 (class stdio_file): Override can_emit_style_escape.
9772 (class tee_file): Override term_out and can_emit_style_escape.
9773 * utils.h (can_emit_style_escape): Remove.
9774 * utils.c (can_emit_style_escape): Likewise.
9775 Update all callers of can_emit_style_escape (SOMESTREAM) to
9776 SOMESTREAM->can_emit_style_escape.
9777 * source-cache.c (source_cache::get_source_lines): Likewise.
9778 * stack.c (frame_apply_command_count): Call execute_command_to_string
9779 passing the term_out characteristic of the current gdb_stdout.
9780 * thread.c (thr_try_catch_cmd): Likewise.
9781 * top.c (execute_command_to_string): pass term_out parameter
9782 to construct the string_file for the command output.
9783 * ui-file.c (term_cli_styling): New function (most code moved
9784 from utils.c can_emit_style_escape).
9785 (string_file::string_file, string_file::can_emit_style_escape,
9786 stdio_file::can_emit_style_escape, tee_file::term_out,
9787 tee_file::can_emit_style_escape): New functions.
9788
136afab8
PW
97892019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9790
9791 * NEWS: Mention the new set|show may-call-functions.
9792 * infcall.c (may_call_functions_p): New variable.
9793 (show_may_call_functions_p): New function.
9794 (call_function_by_hand_dummy): Throws an error if not
9795 may-call-functions.
9796 (_initialize_infcall): Call add_setshow_boolean_cmd for
9797 may-call-functions.
9798
725cbb63
KS
97992019-04-25 Keith Seitz <keiths@redhat.com>
9800
9801 PR c++/24367
9802 * cp-support.c (inspect_type): Don't attempt substitutions
9803 of symbol with the same name.
9804
3d1cbb78
TT
98052019-04-25 Tom Tromey <tromey@adacore.com>
9806
9807 PR gdb/24475:
9808 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9809 static.
9810
94aeb44b
TT
98112019-04-25 Tom Tromey <tromey@adacore.com>
9812
9813 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9814 rvalue reference.
9815 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9816 (gdb_xml_parser::parse): Use std::move.
9817 * python/python-internal.h (gdbpy_convert_exception): Take a const
9818 reference.
9819 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9820 std::move.
9821 * python/py-utils.c (gdbpy_convert_exception): Take a const
9822 reference.
9823 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9824 Use std::move.
9825 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9826 Use std::move.
9827 * mi/mi-main.c (mi_print_exception): Take a const reference.
9828 * main.c (handle_command_errors): Take a const reference.
9829 * linespec.c (parse_linespec): Use std::move.
9830 * infcall.c (run_inferior_call): Use std::move.
9831 (call_function_by_hand_dummy): Use std::move.
9832 * exec.c (try_open_exec_file): Use std::move.
9833 * exceptions.h (exception_print, exception_fprintf)
9834 (exception_print_same): Update.
9835 * exceptions.c (print_exception, exception_print)
9836 (exception_fprintf, exception_print_same): Change parameters to
9837 const reference.
9838 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9839 * common/new-op.c: Use std::move.
9840 * common/common-exceptions.h (struct gdb_exception): Add move
9841 constructor.
9842 (struct gdb_exception_error, struct gdb_exception_quit, struct
9843 gdb_quit_bad_alloc): Change constructor to move constructor.
9844 (throw_exception): Change parameter to rvalue reference.
9845 * common/common-exceptions.c (throw_exception): Take rvalue
9846 reference.
9847 * cli/cli-interp.c (safe_execute_command): Use std::move.
9848 * breakpoint.c (insert_bp_location, location_to_sals): Use
9849 std::move.
9850
680d7fd5
TT
98512019-04-25 Tom Tromey <tromey@adacore.com>
9852
9853 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9854 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9855 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9856 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9857 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9858 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9859 guile/scm-value.c: Use unpack.
9860 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9861 gdbscm_gdb_exception.
9862 (gdbscm_throw_gdb_exception): Likewise.
9863 (struct gdbscm_gdb_exception): New.
9864 (unpack): New function.
9865 (gdbscm_wrap): Use unpack.
9866
c6fdd8b2
TT
98672019-04-25 Tom Tromey <tromey@adacore.com>
9868
9869 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9870 (gdb_rl_callback_handler): Use std::move.
9871 * common/common-exceptions.h (struct gdb_exception): Add move
9872 assignment operator.
9873 (throw_exception_sjlj): Change "exception" to const reference.
9874 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9875 (throw_exception_sjlj): Change "exception" to const reference.
9876
cc06b668
TT
98772019-04-25 Tom Tromey <tromey@adacore.com>
9878
9879 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9880 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9881 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9882 Update.
9883 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9884 Update.
9885 * mi/mi-interp.c (mi_interp::exec): Update.
9886 * linespec.c (parse_linespec): Update.
9887 * infcall.c (run_inferior_call): Update.
9888 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9889 * guile/scm-symbol.c (gdbscm_lookup_symbol)
9890 (gdbscm_lookup_global_symbol): Update.
9891 * guile/scm-param.c (gdbscm_parameter_value): Update.
9892 * guile/scm-frame.c (gdbscm_frame_read_register)
9893 (gdbscm_frame_read_var): Update.
9894 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9895 * exec.c (try_open_exec_file): Update.
9896 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9897 (gdb_rl_callback_handler): Update.
9898 * common/common-exceptions.h (exception_none): Don't declare.
9899 * common/common-exceptions.c (exception_none): Don't define.
9900 (struct catcher) <exception>: Update.
9901 * cli/cli-interp.c (safe_execute_command): Update.
9902 * breakpoint.c (insert_bp_location, location_to_sals): Update.
9903
cf532bd1
AT
99042019-04-25 Ali Tamur <tamur@google.com>
9905
9906 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9907 (read_attribute_value): Likewise.
9908 (dwarf2_read_addr_index): Update comment.
9909 (read_str_index): Add DW_FORM_strx.
9910 (dwarf2_string_attr): Likewise.
9911 (dwarf2_const_value_attr): Likewise.
9912 (dump_die_shallow): Likewise.
9913 (dwarf2_fetch_constant_bytes): Likewise.
9914 (skip_form_bytes): Likewise.
9915 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9916
82433e3e
SDJ
99172019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
9918
9919 PR corefiles/11608
9920 PR corefiles/18187
9921 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9922 OFFSET. Verify if current mapping contains an ELF header.
9923 (linux_find_memory_regions_full): Adjust call to
9924 dump_mapping_p.
9925
723adb65
SL
99262019-04-25 Sandra Loosemore <sandra@codesourcery.com>
9927 Kang Li <kanglictf@gmail.com>
9928
9929 PR gdb/21600
9930
9931 * dwarf2-frame.c (read_initial_length): Be consistent about using
9932 unsigned representation of length.
9933 (decode_frame_entry_1): Likewise. Check for wraparound of
9934 end pointer as well as buffer overflow.
9935
596179f7
SDJ
99362019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
9937
9938 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9939 "vq".
9940
a59240a4
TT
99412019-04-24 Tom Tromey <tromey@adacore.com>
9942
9943 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9944
f872fdbb
AB
99452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9946
9947 * s12z-tdep.c (s12z_unwind_pc): Delete.
9948 (s12z_unwind_sp): Delete.
9949 (s12z_gdbarch_init): Don't register deleted functions with
9950 gdbarch.
9951
b614e6f3
AB
99522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9953
9954 * rl78-tdep.c (rl78_unwind_sp): Delete.
9955 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9956
14faed38
AB
99572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9958
9959 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9960 (xstormy16_unwind_pc): Delete.
9961 (xstormy16_dummy_id): Delete.
9962 (xstormy16_gdbarch_init): Don't register deleted functions with
9963 gdbarch.
9964
541aad8a
AB
99652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9966
9967 * vax-tdep.c (vax_unwind_pc): Delete.
9968 (vax_gdbarch_init): Don't register deleted function with gdbarch.
9969
29222070
AB
99702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9971
9972 * v850-tdep.c (v850_unwind_sp): Delete.
9973 (v850_unwind_pc): Delete.
9974 (v850_dummy_id): Delete.
9975 (v850_gdbarch_init): Don't register deleted functions with
9976 gdbarch.
9977
0f534d76
AB
99782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9979
9980 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9981 (tilegx_unwind_pc): Delete.
9982 (tilegx_unwind_dummy_id): Delete.
9983 (tilegx_gdbarch_init): Don't register deleted functions with
9984 gdbarch.
9985
1ba7b7f9
AB
99862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9987
9988 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9989 (tic6x_dummy_id): Delete.
9990 (tic6x_gdbarch_init): Don't register deleted functions with
9991 gdbarch.
9992
d31f262c
AB
99932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9994
9995 * sparc-tdep.c (sparc_unwind_pc): Delete.
9996 (sparc32_gdbarch_init): Don't register deleted function with
9997 gdbarch.
9998
6d14d64d
AB
99992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10000
10001 * sh-tdep.c (sh_unwind_sp): Delete.
10002 (sh_unwind_pc): Delete.
10003 (sh_dummy_id): Delete.
10004 (sh_gdbarch_init): Don't register deleted functions with
10005 gdbarch.
10006
a40dde9d
AB
100072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10008
10009 * score-tdep.c (score_unwind_sp): Delete.
10010 (score_unwind_pc): Delete.
10011 (score_dummy_id): Delete.
10012 (score_gdbarch_init): Don't register deleted functions with
10013 gdbarch.
10014
47c47d69
AB
100152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10016
10017 * rx-tdep.c (rx_unwind_pc): Delete.
10018 (rx_unwind_sp): Delete.
10019 (rx_dummy_id): Delete.
10020 (rx_gdbarch_init): Don't register deleted functions with
10021 gdbarch. Update comment.
10022
833a4480
AB
100232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10024
10025 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10026 (rs6000_dummy_id): Delete.
10027 (rs6000_gdbarch_init): Don't register deleted functions with
10028 gdbarch.
10029
3f2cef49
AB
100302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10031
10032 * or1k-tdep.c (or1k_dummy_id): Delete.
10033 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10034
96acf884
AB
100352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10036
10037 * nios2-tdep.c (nios2_dummy_id): Delete.
10038 (nios2_unwind_sp): Delete.
10039 (nios2_gdbarch_init): Don't register deleted functions with
10040 gdbarch.
10041
ca0ab0aa
AB
100422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10043
10044 * nds32-tdep.c (nds32_dummy_id): Delete.
10045 (nds32_unwind_pc): Delete.
10046 (nds32_unwind_sp): Delete.
10047 (nds32_gdbarch_init): Don't register deleted functions with
10048 gdbarch.
10049
c8259044
AB
100502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10051
10052 * msp430-tdep.c (msp430_unwind_pc): Delete.
10053 (msp430_unwind_sp): Delete.
10054 (msp430_dummy_id): Delete.
10055 (msp430_gdbarch_init): Don't register deleted functions with
10056 gdbarch.
10057
27f113c8
AB
100582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10059
10060 * moxie-tdep.c (moxie_unwind_sp): Delete.
10061 (moxie_unwind_pc): Delete.
10062 (moxie_dummy_id): Delete.
10063 (moxie_gdbarch_init): Don't register deleted functions with
10064 gdbarch.
10065
aee6c3cd
AB
100662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10067
10068 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10069 (mn10300_unwind_pc): Delete.
10070 (mn10300_unwind_sp): Delete.
10071 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10072 mn10300_unwind_sp.
10073 (mn10300_frame_unwind_init): Don't register deleted functions with
10074 gdbarch.
10075
8e2b5aea
AB
100762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10077
10078 * mep-tdep.c (mep_unwind_pc): Delete.
10079 (mep_unwind_sp): Delete.
10080 (mep_dummy_id): Delete.
10081 (mep_gdbarch_init): Don't register deleted functions with
10082 gdbarch.
10083
43cf3ede
AB
100842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10085
10086 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10087 (m68hc11_unwind_sp): Delete.
10088 (m68hc11_gdbarch_init): Don't register deleted functions with
10089 gdbarch.
10090
5e79b7bb
AB
100912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10092
10093 * m32r-tdep.c (m32r_unwind_sp): Delete.
10094 (m32r_unwind_pc): Delete.
10095 (m32r_dummy_id): Delete.
10096 (m32r_gdbarch_init): Don't register deleted functions with
10097 gdbarch.
10098
89b268d8
AB
100992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10100
10101 * m32c-tdep.c (m32c_unwind_pc): Delete.
10102 (m32c_unwind_sp): Delete.
10103 (m32c_dummy_id): Delete.
10104 (m32c_gdbarch_init): Don't register deleted functions with
10105 gdbarch.
10106
946c28d2
AB
101072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10108
10109 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10110 (lm32_unwind_pc): Delete.
10111 (lm32_dummy_id): Delete.
10112 (lm32_gdbarch_init): Don't register deleted functions with
10113 gdbarch.
10114
bf12844a
AB
101152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10116
10117 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10118 (iq2000_unwind_pc): Delete.
10119 (iq2000_dummy_id): Delete.
10120 (iq2000_gdbarch_init): Don't register deleted functions with
10121 gdbarch.
10122
ecbc06d2
AB
101232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10124
10125 * nds32-tdep.c (nds32_type_align): Delete.
10126 (nds32_push_dummy_call): Use type_align instead.
10127
030197b4
AB
101282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10129
10130 * arm-tdep.c (arm_type_align): Only handle vector override case.
10131 (arm_push_dummy_call): Use type_align.
10132 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10133
b907456c
AB
101342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10135
10136 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10137 case.
10138 (pass_on_stack): Use type_align.
10139 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10140 function.
10141
9e97ba43
TT
101422019-04-23 Tom Tromey <tromey@adacore.com>
10143
10144 * dwarf2read.c (line_header::file_name_at): Remove unused
10145 overload.
10146
6892f601
TV
101472019-04-23 Tom de Vries <tdevries@suse.de>
10148
10149 PR gdb/24438
10150 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10151 invocation.
10152
336d760d
AT
10153
101542019-03-27 Ali Tamur <tamur@google.com>
10155
10156 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10157 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10158 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10159 (dwarf_expr_context::get_addr_index): Likewise
10160 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10161 (symbol_needs_eval_context::get_addr_index): Likewise
10162 (disassemble_dwarf_expression): Add DW_OP_addrx
10163 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10164 (read_cutu_die_from_dwo): Update comment
10165 (skip_one_die): Add DW_FORM_addrx
10166 (read_attribute_value): Likewise
10167 (var_decode_location): Add DW_OP_addrx
10168 (dwarf2_const_value_attr): Add DW_FORM_addrx
10169 (dump_die_shallow): Likewise
10170 (dwarf2_fetch_constant_bytes): Likewise
10171 (decode_locdesc): Add DW_OP_addrx
10172 (skip_form_bytes): Add DW_FORM_addrx
10173
ad9d13f8
AT
101742019-04-22 Ali Tamur <tamur@google.com>
10175
10176 * MAINTAINERS (Write After Approval): Add self.
10177
d70cc3ba
SM
101782019-04-22 Simon Marchi <simon.marchi@efficios.com>
10179
10180 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10181 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10182 (open_symbol_file_object): Likewise.
10183 (svr4_default_sos): Add info parameter.
10184 (svr4_read_so_list): Likewise.
10185 (svr4_current_sos_direct): Adjust functions calls to pass down
10186 info.
10187 (svr4_current_sos_1): Add info parameter.
10188 (svr4_current_sos): Call get_svr4_info, pass info down to
10189 svr4_current_sos_1.
10190 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10191 get_svr4_info.
10192 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10193 get_svr4_info.
10194 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10195 to get_svr4_info.
10196 (probes_table_remove_objfile_probes): Likewise.
10197 (register_solib_event_probe): Add info parameter.
10198 (solist_update_incremental): Pass info parameter down to
10199 svr4_read_so_list.
10200 (disable_probes_interface): Add info parameter.
10201 (svr4_handle_solib_event): Pass current_program_space to
10202 get_svr4_info. Adjust disable_probes_interface cleanup.
10203 (svr4_create_probe_breakpoints): Add info parameter, pass it
10204 down to register_solib_event_probe.
10205 (svr4_create_solib_event_breakpoints): Add info parameter,
10206 pass it down to svr4_create_probe_breakpoints.
10207 (enable_break): Pass info down to
10208 svr4_create_solib_event_breakpoints.
10209 (svr4_solib_create_inferior_hook): Pass current_program_space to
10210 get_svr4_info.
10211 (svr4_clear_solib): Likewise.
10212
7905fc35
PA
102132019-04-22 Pedro Alves <palves@redhat.com>
10214
10215 * solib-svr4.c (svr4_free_objfile_observer): New.
10216 (probe_and_action::objfile): New field.
10217 (probes_table_htab_remove_objfile_probes)
10218 (probes_table_remove_objfile_probes): New functions.
10219 (register_solib_event_probe): Add 'objfile' parameter. Store it
10220 in the new probe_and_action. Don't store the probe in 'lookup'.
10221 (svr4_create_probe_breakpoints): Pass objfile to
10222 register_solib_event_probe.
10223 (_initialize_svr4_solib): Register a free_objfile observer.
10224
fb881986
TT
102252019-04-19 Tom Tromey <tom@tromey.com>
10226
10227 * common/queue.h: Remove.
10228
8732db6c
TT
102292019-04-19 Tom Tromey <tom@tromey.com>
10230
10231 * event-loop.c: Don't include "common/queue.h".
10232
97dfbadd
TT
102332019-04-19 Tom Tromey <tom@tromey.com>
10234
10235 * remote.c (remote_target): Use delete.
10236 * remote-notif.h: Include <list>, not "common/queue.h".
10237 (notif_client_p): Remove typedef.
10238 (remote_notif_state): Add constructor, destructor, initializer.
10239 <notif_queue>: Now a std::list.
10240 (remote_notif_state_xfree): Don't declare.
10241 * remote-notif.c (remote_notif_process, handle_notification)
10242 (remote_notif_state_allocate): Update.
10243 (~remote_notif_state): Rename from remote_notif_state_xfree.
10244
cf250e36
TT
102452019-04-19 Tom Tromey <tom@tromey.com>
10246
10247 * symfile.c (reread_symbols): Update.
10248 * objfiles.c (objfile_register_static_link)
10249 (objfile_lookup_static_link): Update
10250 (~objfile) Don't delete static_links.
10251 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10252
61f4b350
TT
102532019-04-19 Tom Tromey <tom@tromey.com>
10254
10255 * type-stack.h (struct type_stack) <insert>: Constify string.
10256 * type-stack.c (type_stack::insert): Constify string.
10257 * gdbtypes.h (lookup_template_type): Update.
10258 (address_space_name_to_int): Update.
10259 * gdbtypes.c (address_space_name_to_int): Make space_identifier
10260 const.
10261 (lookup_template_type): Make name const.
10262 * c-exp.y: Update rules.
10263 (lex_one_token, classify_name, classify_inner_name)
10264 (c_print_token): Update.
10265 * p-exp.y: Update rules.
10266 (yylex): Update.
10267 * f-exp.y: Update rules.
10268 (yylex): Update.
10269 * d-exp.y: Update rules.
10270 (lex_one_token, classify_name, classify_inner_name): Update.
10271 * parse.c (write_dollar_variable, copy_name): Return std::string.
10272 * parser-defs.h (copy_name): Change return type.
10273 * m2-exp.y: Update rules.
10274 (yylex): Update.
10275 * go-exp.y (lex_one_token): Update.
10276 Update rules.
10277 (classify_unsafe_function, classify_packaged_name)
10278 (classify_name, yylex): Update.
10279
189b8c2e
ST
102802019-04-19 Sergei Trofimovich <siarheit@google.com>
10281
10282 * configure.ac: add --enable-source-highlight switch.
10283 * configure: Regenerate.
10284 * top.c (print_gdb_version): plumb --enable-source-highlight
10285 status to "show configuration".
10286
8ecb59f8
TT
102872019-04-19 Tom Tromey <tromey@adacore.com>
10288
10289 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10290 Check ADA_TYPE_P.
10291 (empty_record, ada_template_to_fixed_record_type_1)
10292 (template_to_static_fixed_type)
10293 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10294 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10295 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10296 macros.
10297
62160ec9
TT
102982019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
10299
10300 PR symtab/24423:
10301 * source.c (print_source_lines_base): Advance "iter" when a
10302 control character is seen.
10303
f2ae8bc8
PW
103042019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10305
10306 * inferior.h (struct infcall_suspend_state_deleter):
10307 Catch exception in destructor to avoid crash.
10308
d563b953
PW
103092019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10310
10311 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10312 close to the add_com "shell".
10313
dc34c897
TT
103142019-04-18 Tom Tromey <tromey@adacore.com>
10315
10316 * process-stratum-target.h (class process_stratum_target)
10317 <stratum>: Add "final".
10318
a12e5744
TT
103192019-04-17 Tom Tromey <tromey@adacore.com>
10320
10321 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10322 against nullptr before use.
10323
a7e559cc
AH
103242019-04-17 Alan Hayward <alan.hayward@arm.com>
10325
10326 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10327
c01660c6
AB
103282019-04-17 Jim Wilson <jimw@sifive.com>
10329 Andrew Burgess <andrew.burgess@embecosm.com>
10330
10331 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10332 code read might fail, assume 4-byte breakpoint in that case.
10333
4aa866af
LS
103342019-04-15 Leszek Swirski <leszeks@google.com>
10335
10336 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10337 rather than a hand-rolled POD check when checking for forced MEMORY
10338 classification.
10339
48574d91
AH
103402019-04-15 Alan Hayward <alan.hayward@arm.com>
10341
10342 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10343 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10344 function.
10345 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10346 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10347 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10348 declaration.
10349
4da037ef
AH
103502019-04-15 Alan Hayward <alan.hayward@arm.com>
10351
10352 * aarch64-linux-nat.c
10353 (aarch64_linux_nat_target::thread_architecture): Add override.
10354 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10355 each VQ.
10356
ccb8d7e8
AH
103572019-04-15 Alan Hayward <alan.hayward@arm.com>
10358
10359 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10360
35add35e
AB
103612019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
10362
10363 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10364 target types of size 96-bits, add some additional comments, and
10365 check that the builtin type we found was the correct size.
10366
51196bbc
EZ
103672019-04-12 Eli Zaretskii <eliz@gnu.org>
10368
10369 * utils.c (prompt_for_continue): Don't restore the styling at the
10370 end, as applied_style has the wrong value. This fixes styling in
10371 long lists of file names that are interrupted by the "Continue?"
10372 prompt.
10373
62253a61
AB
103742019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
10375
10376 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10377 * c-lang.c (c_language_defn): Likewise.
10378 (cplus_language_defn): Likewise.
10379 (asm_language_defn): Likewise.
10380 (minimal_language_defn): Likewise.
10381 * d-lang.c (d_language_defn): Likewise.
10382 * f-lang.c (f_language_defn): Likewise.
10383 * go-lang.c (go_language_defn): Likewise.
10384 * language.c (unknown_language_defn): Likewise.
10385 (auto_language_defn): Likewise.
10386 * language.h (struct language_defn): Remove la_magic field.
10387 (LANG_MAGIC): Delete.
10388 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10389 * objc-lang.c (objc_language_defn): Likewise.
10390 * opencl-lang.c (opencl_language_defn): Likewise.
10391 * p-lang.c (pascal_language_defn): Likewise.
10392 * rust-lang.c (rust_language_defn): Likewise.
10393
a9158a86
AB
103942019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10395
10396 * riscv-tdep.c (riscv_type_align): New function.
10397 (riscv_type_alignment): Delete.
10398 (riscv_arg_location): Use 'type_align'.
10399 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10400
41077b66
AB
104012019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10402
10403 * gdbtypes.c (type_align): A struct with no non-static fields also
10404 has alignment of 1.
10405
9f0272f8
AB
104062019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10407
10408 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10409 component to 0.
10410 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10411 member.
10412 (riscv_struct_info::analyse): New implementation using new
10413 analyse_inner member function.
10414 (riscv_struct_info::field_offset): New member function.
10415 (riscv_struct_info::m_offsets): New member variable.
10416 (riscv_struct_info::analyse_inner): New private member function,
10417 takes the old implementation of riscv_struct_info::analyse but
10418 extended to track field offsets.
10419 (riscv_call_arg_struct): Update the struct folding special cases
10420 to handle cases where empty C++ structs, which are non-zero
10421 length, are found.
10422 (riscv_arg_location): Initialise the length of each location, a
10423 non-zero length now indicates the location is in use.
10424 (riscv_push_dummy_call): Allow for the first location having a
10425 non-zero offset when setting up arguments.
10426 (riscv_return_value): Likewise, but for return values.
10427
02cf60c7
TT
104282019-04-11 Tom Tromey <tromey@adacore.com>
10429
10430 * utils.c (internal_vproblem): Make "msg" const.
10431
68811f8f
AH
104322019-04-11 Alan Hayward <alan.hayward@arm.com>
10433
10434 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10435 * trad-frame.c (trad_frame_reset_saved_regs): New function.
10436 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10437 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10438
3f52fdbc
KB
104392019-04-10 Kevin Buettner <kevinb@redhat.com>
10440
10441 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10442 function.
10443 (fill_gregset): Call amd64_linux_collect_native_gregset instead
10444 of amd64_collect_native_gregset.
10445 (amd64_linux_nat_target::store_registers): Likewise.
10446
e9ad22ee
TT
104472019-04-10 Tom Tromey <tom@tromey.com>
10448
10449 * symtab.c (lookup_global_symbol_from_objfile)
10450 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10451 * objfiles.h (class separate_debug_iterator): New.
10452 (class separate_debug_range): New.
10453 (struct objfile) <separate_debug_objfiles>: New method.
10454 (objfile_separate_debug_iterate): Don't declare.
10455 * objfiles.c (separate_debug_iterator::operator++): Rename from
10456 objfile_separate_debug_iterate.
10457 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10458 iterator.
10459 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10460 iterator.
10461
ee371134
TT
104622019-04-10 Tom Tromey <tom@tromey.com>
10463
10464 * symfile.c (reread_symbols): Remove old comment.
10465 * objfiles.c (free_all_objfiles): Fix a typo.
10466
bf227d61
TT
104672019-04-10 Tom Tromey <tom@tromey.com>
10468
10469 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10470 * minsyms.c (lookup_minimal_symbol): Use foreach.
10471 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10472 (lookup_minimal_symbol_solib_trampoline): Likewise.
10473 * symfile.c (reread_symbols): Use foreach.
10474
8dc433a0
TT
104752019-04-09 Ivan Begert <ivanbegert@gmail.com>
10476 Tom Tromey <tromey@adacore.com>
10477
10478 PR rust/24414:
10479 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10480 (rust_lex_int_test): Change "value" to be LONGEST.
10481 (rust_lex_tests): Add test for long integer literal.
10482
9ab8741a
TT
104832019-04-09 Tom Tromey <tromey@adacore.com>
10484
10485 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10486 to bool.
10487 (extended_remote_target::attach): Update.
10488 (remote_target::remote_notice_new_inferior): Update.
10489 (remote_target::add_current_inferior_and_thread): Update.
10490 * inferior.c (exit_inferior_1): Use "false".
10491 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10492
e242fd12
SM
104932019-04-09 Simon Marchi <simon.marchi@efficios.com>
10494
9ca1957f 10495 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
10496 the "start" command.
10497
2b0c8b01
KB
104982019-04-08 Kevin Buettner <kevinb@redhat.com>
10499
10500 * python/py-inferior.c (infpy_thread_from_thread_handle):
10501 Adjust comments to reflect renaming of thread_from_thread_handle
10502 to thread_from_handle. Adjust keywords. Fix type error message.
10503 (inferior_object_methods): Add thread_from_handle. Retain
10504 thread_from_thread_handle, but mark it as deprecated.
10505
50a82723
KB
105062019-04-08 Kevin Buettner <kevinb@redhat.com>
10507
10508 * gdbthread.h (find_thread_by_handle): Revise declaration.
10509 * thread.c (find_thread_by_handle): Likewise. Adjust
10510 implementation too.
10511 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10512 support for buffer objects as handles.
10513
cf63b016
KB
105142019-04-08 Kevin Buettner <kevinb@redhat.com>
10515
10516 * python/py-infthread.c (thpy_thread_handle): New function.
10517 (thread_object_methods): Register thpy_thread_handle.
10518
3d6c6204
KB
105192019-04-08 Kevin Buettner <kevinb@redhat.com>
10520
10521 * gdbthread.h (thread_to_thread_handle): Declare.
10522 * thread.c (gdbtypes.h): Include.
10523 (thread_to_thread_handle): New function.
10524
10525 * target.h (struct target_ops): Add thread_info_to_thread_handle.
10526 (target_thread_info_to_thread_handle): Declare.
10527 * target.c (target_thread_info_to_thread_handle): New function.
10528 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10529 * target-delegates.c: Regenerate.
10530
10531 * linux-thread-db.c (class thread_db_target): Add method
10532 thread_info_to_thread_handle.
10533 (thread_db_target::thread_info_to_thread_handle): Define.
10534 * remote.c (class remote_target): Add new method
10535 thread_info_to_thread_handle.
10536 (remote_target::thread_info_to_thread_handle): Define.
10537
56be6ea8
PA
105382019-04-08 Pedro Alves <palves@redhat.com>
10539
10540 * common/common-exceptions.c (throw_exception): Don't create
10541 named object to throw; throw directly.
10542 (throw_it): Likewise. Don't initialize gdb_exception::message
10543 here, with new; pass FMT and AP to the ctor instead.
10544 * common/common-exceptions.h: Include <string>.
10545 (gdb_exception::gdb_exception(enum return_reason, enum errors,
10546 const char *, va_list)): New ctor. Use std::make_shared.
10547 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10548 errors)): Delete.
10549 (gdb_exception_error::gdb_exception_error(enum errors, const char
10550 *, va_list)): New.
10551 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10552 Add assertion.
10553 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10554 errors)): Delete.
10555 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10556 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10557 Add assertion.
10558
eedc3f4f
TT
105592019-04-08 Tom Tromey <tom@tromey.com>
10560
10561 * valops.c (value_rtti_indirect_type): Replace throw_exception
10562 with throw.
10563 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10564 with throw.
10565 * thread.c (thr_try_catch_cmd): Replace throw_exception with
10566 throw.
10567 * target.c (target_translate_tls_address): Replace throw_exception
10568 with throw.
10569 * stack.c (frame_apply_command_count): Replace throw_exception
10570 with throw.
10571 * solib-spu.c (append_ocl_sos): Replace throw_exception with
10572 throw.
10573 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10574 with throw.
10575 * rs6000-tdep.c (rs6000_frame_cache)
10576 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10577 * remote.c: Replace throw_exception with throw.
10578 * record-full.c (record_full_message, record_full_wait_1)
10579 (record_full_restore): Replace throw_exception with throw.
10580 * record-btrace.c:
10581 (get_thread_current_frame_id, record_btrace_start_replaying)
10582 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10583 (cmd_record_btrace_start): Replace throw_exception with throw.
10584 * parse.c (parse_exp_in_context_1): Replace throw_exception with
10585 throw.
10586 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10587 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10588 * linespec.c:
10589 (find_linespec_symbols): Replace throw_exception with throw.
10590 * infrun.c (displaced_step_prepare, resume): Replace
10591 throw_exception with throw.
10592 * infcmd.c (post_create_inferior): Replace throw_exception with
10593 throw.
10594 * inf-loop.c (inferior_event_handler): Replace throw_exception
10595 with throw.
10596 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10597 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10598 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10599 (get_prev_frame_always, get_frame_pc_if_available)
10600 (get_frame_address_in_block_if_available, get_frame_language):
10601 Replace throw_exception with throw.
10602 * frame-unwind.c (frame_unwind_try_unwinder): Replace
10603 throw_exception with throw.
10604 * eval.c (fetch_subexp_value, evaluate_var_value)
10605 (evaluate_funcall, evaluate_subexp_standard): Replace
10606 throw_exception with throw.
10607 * dwarf2loc.c (call_site_find_chain)
10608 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10609 Replace throw_exception with throw.
10610 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10611 with throw.
10612 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10613 throw.
10614 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10615 * completer.c (complete_line_internal): Replace throw_exception
10616 with throw.
10617 * compile/compile-object-run.c (compile_object_run): Replace
10618 throw_exception with throw.
10619 * cli/cli-script.c (process_next_line): Replace throw_exception
10620 with throw.
10621 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10622 (btrace_enable, btrace_maint_update_pt_packets): Replace
10623 throw_exception with throw.
10624 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10625 throw_exception with throw.
10626 * break-catch-throw.c (re_set_exception_catchpoint): Replace
10627 throw_exception with throw.
10628 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10629 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10630 * aarch64-tdep.c (aarch64_make_prologue_cache)
10631 (aarch64_make_stub_cache): Replace throw_exception with throw.
10632
26003a20
TT
106332019-04-08 Tom Tromey <tom@tromey.com>
10634
10635 * common/common-exceptions.c (throw_exception): Rename from
10636 throw_exception_cxx. Remove old copy. Make argument const.
10637 (throw_it): Create and throw exception objects directly.
10638 * common/common-exceptions.h (throw_exception): Make argument
10639 const.
10640 (struct gdb_exception_error): Add constructor.
10641 (struct gdb_exception_quit): Add constructor.
10642
d272eb37
TT
106432019-04-08 Tom Tromey <tom@tromey.com>
10644
10645 * common/common-exceptions.h (exception_rethrow): Don't declare.
10646 (TRY_SJLJ): Update comment.
10647 (TRY, CATCH, END_CATCH): Remove.
10648 * common/common-exceptions.c (exception_rethrow): Remove.
10649
230d2906
TT
106502019-04-08 Tom Tromey <tom@tromey.com>
10651
10652 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10653 Remove.
10654 (gdb_exception_error): Rename from
10655 gdb_exception_RETURN_MASK_ERROR.
10656 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10657 (gdb_quit_bad_alloc): Update.
10658 * aarch64-tdep.c: Update.
10659 * ada-lang.c: Update.
10660 * ada-typeprint.c: Update.
10661 * ada-valprint.c: Update.
10662 * amd64-tdep.c: Update.
10663 * arch-utils.c: Update.
10664 * break-catch-throw.c: Update.
10665 * breakpoint.c: Update.
10666 * btrace.c: Update.
10667 * c-varobj.c: Update.
10668 * cli/cli-cmds.c: Update.
10669 * cli/cli-interp.c: Update.
10670 * cli/cli-script.c: Update.
10671 * common/common-exceptions.c: Update.
10672 * common/new-op.c: Update.
10673 * common/selftest.c: Update.
10674 * compile/compile-c-symbols.c: Update.
10675 * compile/compile-cplus-symbols.c: Update.
10676 * compile/compile-object-load.c: Update.
10677 * compile/compile-object-run.c: Update.
10678 * completer.c: Update.
10679 * corelow.c: Update.
10680 * cp-abi.c: Update.
10681 * cp-support.c: Update.
10682 * cp-valprint.c: Update.
10683 * darwin-nat.c: Update.
10684 * disasm-selftests.c: Update.
10685 * dtrace-probe.c: Update.
10686 * dwarf-index-cache.c: Update.
10687 * dwarf-index-write.c: Update.
10688 * dwarf2-frame-tailcall.c: Update.
10689 * dwarf2-frame.c: Update.
10690 * dwarf2loc.c: Update.
10691 * dwarf2read.c: Update.
10692 * eval.c: Update.
10693 * event-loop.c: Update.
10694 * event-top.c: Update.
10695 * exec.c: Update.
10696 * f-valprint.c: Update.
10697 * fbsd-tdep.c: Update.
10698 * frame-unwind.c: Update.
10699 * frame.c: Update.
10700 * gdbtypes.c: Update.
10701 * gnu-v3-abi.c: Update.
10702 * guile/guile-internal.h: Update.
10703 * guile/scm-block.c: Update.
10704 * guile/scm-breakpoint.c: Update.
10705 * guile/scm-cmd.c: Update.
10706 * guile/scm-disasm.c: Update.
10707 * guile/scm-frame.c: Update.
10708 * guile/scm-lazy-string.c: Update.
10709 * guile/scm-math.c: Update.
10710 * guile/scm-param.c: Update.
10711 * guile/scm-ports.c: Update.
10712 * guile/scm-pretty-print.c: Update.
10713 * guile/scm-symbol.c: Update.
10714 * guile/scm-symtab.c: Update.
10715 * guile/scm-type.c: Update.
10716 * guile/scm-value.c: Update.
10717 * i386-linux-tdep.c: Update.
10718 * i386-tdep.c: Update.
10719 * inf-loop.c: Update.
10720 * infcall.c: Update.
10721 * infcmd.c: Update.
10722 * infrun.c: Update.
10723 * jit.c: Update.
10724 * language.c: Update.
10725 * linespec.c: Update.
10726 * linux-fork.c: Update.
10727 * linux-nat.c: Update.
10728 * linux-tdep.c: Update.
10729 * linux-thread-db.c: Update.
10730 * main.c: Update.
10731 * mi/mi-cmd-break.c: Update.
10732 * mi/mi-cmd-stack.c: Update.
10733 * mi/mi-interp.c: Update.
10734 * mi/mi-main.c: Update.
10735 * objc-lang.c: Update.
10736 * p-valprint.c: Update.
10737 * parse.c: Update.
10738 * ppc-linux-tdep.c: Update.
10739 * printcmd.c: Update.
10740 * python/py-arch.c: Update.
10741 * python/py-breakpoint.c: Update.
10742 * python/py-cmd.c: Update.
10743 * python/py-finishbreakpoint.c: Update.
10744 * python/py-frame.c: Update.
10745 * python/py-framefilter.c: Update.
10746 * python/py-gdb-readline.c: Update.
10747 * python/py-inferior.c: Update.
10748 * python/py-infthread.c: Update.
10749 * python/py-lazy-string.c: Update.
10750 * python/py-linetable.c: Update.
10751 * python/py-objfile.c: Update.
10752 * python/py-param.c: Update.
10753 * python/py-prettyprint.c: Update.
10754 * python/py-progspace.c: Update.
10755 * python/py-record-btrace.c: Update.
10756 * python/py-record.c: Update.
10757 * python/py-symbol.c: Update.
10758 * python/py-type.c: Update.
10759 * python/py-unwind.c: Update.
10760 * python/py-utils.c: Update.
10761 * python/py-value.c: Update.
10762 * python/python.c: Update.
10763 * record-btrace.c: Update.
10764 * record-full.c: Update.
10765 * remote-fileio.c: Update.
10766 * remote.c: Update.
10767 * riscv-tdep.c: Update.
10768 * rs6000-aix-tdep.c: Update.
10769 * rs6000-tdep.c: Update.
10770 * rust-exp.y: Update.
10771 * rust-lang.c: Update.
10772 * s390-tdep.c: Update.
10773 * selftest-arch.c: Update.
10774 * solib-dsbt.c: Update.
10775 * solib-frv.c: Update.
10776 * solib-spu.c: Update.
10777 * solib-svr4.c: Update.
10778 * solib.c: Update.
10779 * sparc64-linux-tdep.c: Update.
10780 * stack.c: Update.
10781 * symfile-mem.c: Update.
10782 * symmisc.c: Update.
10783 * target.c: Update.
10784 * thread.c: Update.
10785 * top.c: Update.
10786 * tracefile-tfile.c: Update.
10787 * tui/tui.c: Update.
10788 * typeprint.c: Update.
10789 * unittests/cli-utils-selftests.c: Update.
10790 * unittests/parse-connection-spec-selftests.c: Update.
10791 * valops.c: Update.
10792 * valprint.c: Update.
10793 * value.c: Update.
10794 * varobj.c: Update.
10795 * windows-nat.c: Update.
10796 * x86-linux-nat.c: Update.
10797 * xml-support.c: Update.
10798
a70b8144
TT
107992019-04-08 Tom Tromey <tom@tromey.com>
10800
10801 * xml-support.c: Use C++ exception handling.
10802 * x86-linux-nat.c: Use C++ exception handling.
10803 * windows-nat.c: Use C++ exception handling.
10804 * varobj.c: Use C++ exception handling.
10805 * value.c: Use C++ exception handling.
10806 * valprint.c: Use C++ exception handling.
10807 * valops.c: Use C++ exception handling.
10808 * unittests/parse-connection-spec-selftests.c: Use C++ exception
10809 handling.
10810 * unittests/cli-utils-selftests.c: Use C++ exception handling.
10811 * typeprint.c: Use C++ exception handling.
10812 * tui/tui.c: Use C++ exception handling.
10813 * tracefile-tfile.c: Use C++ exception handling.
10814 * top.c: Use C++ exception handling.
10815 * thread.c: Use C++ exception handling.
10816 * target.c: Use C++ exception handling.
10817 * symmisc.c: Use C++ exception handling.
10818 * symfile-mem.c: Use C++ exception handling.
10819 * stack.c: Use C++ exception handling.
10820 * sparc64-linux-tdep.c: Use C++ exception handling.
10821 * solib.c: Use C++ exception handling.
10822 * solib-svr4.c: Use C++ exception handling.
10823 * solib-spu.c: Use C++ exception handling.
10824 * solib-frv.c: Use C++ exception handling.
10825 * solib-dsbt.c: Use C++ exception handling.
10826 * selftest-arch.c: Use C++ exception handling.
10827 * s390-tdep.c: Use C++ exception handling.
10828 * rust-lang.c: Use C++ exception handling.
10829 * rust-exp.y: Use C++ exception handling.
10830 * rs6000-tdep.c: Use C++ exception handling.
10831 * rs6000-aix-tdep.c: Use C++ exception handling.
10832 * riscv-tdep.c: Use C++ exception handling.
10833 * remote.c: Use C++ exception handling.
10834 * remote-fileio.c: Use C++ exception handling.
10835 * record-full.c: Use C++ exception handling.
10836 * record-btrace.c: Use C++ exception handling.
10837 * python/python.c: Use C++ exception handling.
10838 * python/py-value.c: Use C++ exception handling.
10839 * python/py-utils.c: Use C++ exception handling.
10840 * python/py-unwind.c: Use C++ exception handling.
10841 * python/py-type.c: Use C++ exception handling.
10842 * python/py-symbol.c: Use C++ exception handling.
10843 * python/py-record.c: Use C++ exception handling.
10844 * python/py-record-btrace.c: Use C++ exception handling.
10845 * python/py-progspace.c: Use C++ exception handling.
10846 * python/py-prettyprint.c: Use C++ exception handling.
10847 * python/py-param.c: Use C++ exception handling.
10848 * python/py-objfile.c: Use C++ exception handling.
10849 * python/py-linetable.c: Use C++ exception handling.
10850 * python/py-lazy-string.c: Use C++ exception handling.
10851 * python/py-infthread.c: Use C++ exception handling.
10852 * python/py-inferior.c: Use C++ exception handling.
10853 * python/py-gdb-readline.c: Use C++ exception handling.
10854 * python/py-framefilter.c: Use C++ exception handling.
10855 * python/py-frame.c: Use C++ exception handling.
10856 * python/py-finishbreakpoint.c: Use C++ exception handling.
10857 * python/py-cmd.c: Use C++ exception handling.
10858 * python/py-breakpoint.c: Use C++ exception handling.
10859 * python/py-arch.c: Use C++ exception handling.
10860 * printcmd.c: Use C++ exception handling.
10861 * ppc-linux-tdep.c: Use C++ exception handling.
10862 * parse.c: Use C++ exception handling.
10863 * p-valprint.c: Use C++ exception handling.
10864 * objc-lang.c: Use C++ exception handling.
10865 * mi/mi-main.c: Use C++ exception handling.
10866 * mi/mi-interp.c: Use C++ exception handling.
10867 * mi/mi-cmd-stack.c: Use C++ exception handling.
10868 * mi/mi-cmd-break.c: Use C++ exception handling.
10869 * main.c: Use C++ exception handling.
10870 * linux-thread-db.c: Use C++ exception handling.
10871 * linux-tdep.c: Use C++ exception handling.
10872 * linux-nat.c: Use C++ exception handling.
10873 * linux-fork.c: Use C++ exception handling.
10874 * linespec.c: Use C++ exception handling.
10875 * language.c: Use C++ exception handling.
10876 * jit.c: Use C++ exception handling.
10877 * infrun.c: Use C++ exception handling.
10878 * infcmd.c: Use C++ exception handling.
10879 * infcall.c: Use C++ exception handling.
10880 * inf-loop.c: Use C++ exception handling.
10881 * i386-tdep.c: Use C++ exception handling.
10882 * i386-linux-tdep.c: Use C++ exception handling.
10883 * guile/scm-value.c: Use C++ exception handling.
10884 * guile/scm-type.c: Use C++ exception handling.
10885 * guile/scm-symtab.c: Use C++ exception handling.
10886 * guile/scm-symbol.c: Use C++ exception handling.
10887 * guile/scm-pretty-print.c: Use C++ exception handling.
10888 * guile/scm-ports.c: Use C++ exception handling.
10889 * guile/scm-param.c: Use C++ exception handling.
10890 * guile/scm-math.c: Use C++ exception handling.
10891 * guile/scm-lazy-string.c: Use C++ exception handling.
10892 * guile/scm-frame.c: Use C++ exception handling.
10893 * guile/scm-disasm.c: Use C++ exception handling.
10894 * guile/scm-cmd.c: Use C++ exception handling.
10895 * guile/scm-breakpoint.c: Use C++ exception handling.
10896 * guile/scm-block.c: Use C++ exception handling.
10897 * guile/guile-internal.h: Use C++ exception handling.
10898 * gnu-v3-abi.c: Use C++ exception handling.
10899 * gdbtypes.c: Use C++ exception handling.
10900 * frame.c: Use C++ exception handling.
10901 * frame-unwind.c: Use C++ exception handling.
10902 * fbsd-tdep.c: Use C++ exception handling.
10903 * f-valprint.c: Use C++ exception handling.
10904 * exec.c: Use C++ exception handling.
10905 * event-top.c: Use C++ exception handling.
10906 * event-loop.c: Use C++ exception handling.
10907 * eval.c: Use C++ exception handling.
10908 * dwarf2read.c: Use C++ exception handling.
10909 * dwarf2loc.c: Use C++ exception handling.
10910 * dwarf2-frame.c: Use C++ exception handling.
10911 * dwarf2-frame-tailcall.c: Use C++ exception handling.
10912 * dwarf-index-write.c: Use C++ exception handling.
10913 * dwarf-index-cache.c: Use C++ exception handling.
10914 * dtrace-probe.c: Use C++ exception handling.
10915 * disasm-selftests.c: Use C++ exception handling.
10916 * darwin-nat.c: Use C++ exception handling.
10917 * cp-valprint.c: Use C++ exception handling.
10918 * cp-support.c: Use C++ exception handling.
10919 * cp-abi.c: Use C++ exception handling.
10920 * corelow.c: Use C++ exception handling.
10921 * completer.c: Use C++ exception handling.
10922 * compile/compile-object-run.c: Use C++ exception handling.
10923 * compile/compile-object-load.c: Use C++ exception handling.
10924 * compile/compile-cplus-symbols.c: Use C++ exception handling.
10925 * compile/compile-c-symbols.c: Use C++ exception handling.
10926 * common/selftest.c: Use C++ exception handling.
10927 * common/new-op.c: Use C++ exception handling.
10928 * cli/cli-script.c: Use C++ exception handling.
10929 * cli/cli-interp.c: Use C++ exception handling.
10930 * cli/cli-cmds.c: Use C++ exception handling.
10931 * c-varobj.c: Use C++ exception handling.
10932 * btrace.c: Use C++ exception handling.
10933 * breakpoint.c: Use C++ exception handling.
10934 * break-catch-throw.c: Use C++ exception handling.
10935 * arch-utils.c: Use C++ exception handling.
10936 * amd64-tdep.c: Use C++ exception handling.
10937 * ada-valprint.c: Use C++ exception handling.
10938 * ada-typeprint.c: Use C++ exception handling.
10939 * ada-lang.c: Use C++ exception handling.
10940 * aarch64-tdep.c: Use C++ exception handling.
10941
3d6e9d23
TT
109422019-04-08 Tom Tromey <tom@tromey.com>
10943
10944 * xml-support.c (gdb_xml_parser::parse): Update.
10945 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10946 * value.c (show_convenience): Update.
10947 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10948 (test_parse_flags_qcs): Update.
10949 * thread.c (thr_try_catch_cmd): Update.
10950 * target.c (target_translate_tls_address): Update.
10951 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10952 (info_frame_command_core, frame_apply_command_count): Update.
10953 * rust-exp.y (rust_lex_exception_test): Update.
10954 * riscv-tdep.c (riscv_print_one_register_info): Update.
10955 * remote.c (remote_target::enable_btrace): Update.
10956 * record-btrace.c (record_btrace_enable_warn): Update.
10957 * python/py-utils.c (gdbpy_convert_exception): Update.
10958 * printcmd.c (do_one_display, print_variable_and_value): Update.
10959 * mi/mi-main.c (mi_print_exception): Update.
10960 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10961 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10962 * linux-nat.c (linux_nat_target::attach): Update.
10963 * linux-fork.c (class scoped_switch_fork_info): Update.
10964 * infrun.c (displaced_step_prepare): Update.
10965 * infcall.c (call_function_by_hand_dummy): Update.
10966 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10967 * gnu-v3-abi.c (print_one_vtable): Update.
10968 * frame.c (get_prev_frame_always): Update.
10969 * f-valprint.c (info_common_command_for_block): Update.
10970 * exec.c (try_open_exec_file): Update.
10971 * exceptions.c (print_exception, exception_print)
10972 (exception_fprintf, exception_print_same): Update.
10973 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10974 * dwarf-index-cache.c (index_cache::store)
10975 (index_cache::lookup_gdb_index): Update.
10976 * darwin-nat.c (maybe_cache_shell): Update.
10977 * cp-valprint.c (cp_print_value_fields): Update.
10978 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10979 (gcc_cplus_symbol_address): Update.
10980 * compile/compile-c-symbols.c (gcc_convert_symbol)
10981 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10982 * common/selftest.c: Update.
10983 * common/common-exceptions.h (struct gdb_exception) <message>: Now
10984 a std::string.
10985 (exception_try_scope_entry, exception_try_scope_exit): Don't
10986 declare.
10987 (struct exception_try_scope): Remove.
10988 (TRY): Don't use exception_try_scope.
10989 (struct gdb_exception): Add constructor, operator=.
10990 <what>: New method.
10991 (struct gdb_exception_RETURN_MASK_ALL)
10992 (struct gdb_exception_RETURN_MASK_ERROR)
10993 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10994 (struct gdb_quit_bad_alloc): Update.
10995 * common/common-exceptions.c (exception_none): Change
10996 initializer.
10997 (struct catcher) <state, exception>: Initialize inline.
10998 <prev>: Remove member.
10999 (current_catcher): Remove.
11000 (catchers): New global.
11001 (exceptions_state_mc_init): Simplify.
11002 (catcher_pop): Remove.
11003 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11004 (try_scope_depth, exception_try_scope_entry)
11005 (exception_try_scope_exit): Remove.
11006 (throw_exception_sjlj): Update.
11007 (exception_messages, exception_messages_size): Remove.
11008 (throw_it): Simplify.
11009 (gdb_exception_sliced_copy): Remove.
11010 (throw_exception_cxx): Update.
11011 * cli/cli-script.c (script_from_file): Update.
11012 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11013 Update.
11014 * ada-valprint.c (ada_val_print): Update.
11015 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11016 (create_excep_cond_exprs): Update.
11017
c5c10118
TT
110182019-04-08 Tom Tromey <tom@tromey.com>
11019
11020 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11021 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11022 (TRY, CATCH, END_CATCH): Remove some definitions.
11023 * common/common-exceptions.c: Don't use GDB_XCPT.
11024 (catcher_list_size): Remove.
11025 (throw_exception, throw_it): Simplify.
11026
4de283e4
TT
110272019-04-05 Tom Tromey <tom@tromey.com>
11028
11029 Revert the header-sorting patch.
11030 * ft32-tdep.c: Revert.
11031 * frv-tdep.c: Revert.
11032 * frv-linux-tdep.c: Revert.
11033 * frame.c: Revert.
11034 * frame-unwind.c: Revert.
11035 * frame-base.c: Revert.
11036 * fork-child.c: Revert.
11037 * findvar.c: Revert.
11038 * findcmd.c: Revert.
11039 * filesystem.c: Revert.
11040 * filename-seen-cache.h: Revert.
11041 * filename-seen-cache.c: Revert.
11042 * fbsd-tdep.c: Revert.
11043 * fbsd-nat.h: Revert.
11044 * fbsd-nat.c: Revert.
11045 * f-valprint.c: Revert.
11046 * f-typeprint.c: Revert.
11047 * f-lang.c: Revert.
11048 * extension.h: Revert.
11049 * extension.c: Revert.
11050 * extension-priv.h: Revert.
11051 * expprint.c: Revert.
11052 * exec.h: Revert.
11053 * exec.c: Revert.
11054 * exceptions.c: Revert.
11055 * event-top.c: Revert.
11056 * event-loop.c: Revert.
11057 * eval.c: Revert.
11058 * elfread.c: Revert.
11059 * dwarf2read.h: Revert.
11060 * dwarf2read.c: Revert.
11061 * dwarf2loc.c: Revert.
11062 * dwarf2expr.h: Revert.
11063 * dwarf2expr.c: Revert.
11064 * dwarf2-frame.c: Revert.
11065 * dwarf2-frame-tailcall.c: Revert.
11066 * dwarf-index-write.h: Revert.
11067 * dwarf-index-write.c: Revert.
11068 * dwarf-index-common.c: Revert.
11069 * dwarf-index-cache.h: Revert.
11070 * dwarf-index-cache.c: Revert.
11071 * dummy-frame.c: Revert.
11072 * dtrace-probe.c: Revert.
11073 * disasm.h: Revert.
11074 * disasm.c: Revert.
11075 * disasm-selftests.c: Revert.
11076 * dictionary.c: Revert.
11077 * dicos-tdep.c: Revert.
11078 * demangle.c: Revert.
11079 * dcache.h: Revert.
11080 * dcache.c: Revert.
11081 * darwin-nat.h: Revert.
11082 * darwin-nat.c: Revert.
11083 * darwin-nat-info.c: Revert.
11084 * d-valprint.c: Revert.
11085 * d-namespace.c: Revert.
11086 * d-lang.c: Revert.
11087 * ctf.c: Revert.
11088 * csky-tdep.c: Revert.
11089 * csky-linux-tdep.c: Revert.
11090 * cris-tdep.c: Revert.
11091 * cris-linux-tdep.c: Revert.
11092 * cp-valprint.c: Revert.
11093 * cp-support.c: Revert.
11094 * cp-namespace.c: Revert.
11095 * cp-abi.c: Revert.
11096 * corelow.c: Revert.
11097 * corefile.c: Revert.
11098 * continuations.c: Revert.
11099 * completer.h: Revert.
11100 * completer.c: Revert.
11101 * complaints.c: Revert.
11102 * coffread.c: Revert.
11103 * coff-pe-read.c: Revert.
11104 * cli-out.h: Revert.
11105 * cli-out.c: Revert.
11106 * charset.c: Revert.
11107 * c-varobj.c: Revert.
11108 * c-valprint.c: Revert.
11109 * c-typeprint.c: Revert.
11110 * c-lang.c: Revert.
11111 * buildsym.c: Revert.
11112 * buildsym-legacy.c: Revert.
11113 * build-id.h: Revert.
11114 * build-id.c: Revert.
11115 * btrace.c: Revert.
11116 * bsd-uthread.c: Revert.
11117 * breakpoint.h: Revert.
11118 * breakpoint.c: Revert.
11119 * break-catch-throw.c: Revert.
11120 * break-catch-syscall.c: Revert.
11121 * break-catch-sig.c: Revert.
11122 * blockframe.c: Revert.
11123 * block.c: Revert.
11124 * bfin-tdep.c: Revert.
11125 * bfin-linux-tdep.c: Revert.
11126 * bfd-target.c: Revert.
11127 * bcache.c: Revert.
11128 * ax-general.c: Revert.
11129 * ax-gdb.h: Revert.
11130 * ax-gdb.c: Revert.
11131 * avr-tdep.c: Revert.
11132 * auxv.c: Revert.
11133 * auto-load.c: Revert.
11134 * arm-wince-tdep.c: Revert.
11135 * arm-tdep.c: Revert.
11136 * arm-symbian-tdep.c: Revert.
11137 * arm-pikeos-tdep.c: Revert.
11138 * arm-obsd-tdep.c: Revert.
11139 * arm-nbsd-tdep.c: Revert.
11140 * arm-nbsd-nat.c: Revert.
11141 * arm-linux-tdep.c: Revert.
11142 * arm-linux-nat.c: Revert.
11143 * arm-fbsd-tdep.c: Revert.
11144 * arm-fbsd-nat.c: Revert.
11145 * arm-bsd-tdep.c: Revert.
11146 * arch-utils.c: Revert.
11147 * arc-tdep.c: Revert.
11148 * arc-newlib-tdep.c: Revert.
11149 * annotate.h: Revert.
11150 * annotate.c: Revert.
11151 * amd64-windows-tdep.c: Revert.
11152 * amd64-windows-nat.c: Revert.
11153 * amd64-tdep.c: Revert.
11154 * amd64-sol2-tdep.c: Revert.
11155 * amd64-obsd-tdep.c: Revert.
11156 * amd64-obsd-nat.c: Revert.
11157 * amd64-nbsd-tdep.c: Revert.
11158 * amd64-nbsd-nat.c: Revert.
11159 * amd64-nat.c: Revert.
11160 * amd64-linux-tdep.c: Revert.
11161 * amd64-linux-nat.c: Revert.
11162 * amd64-fbsd-tdep.c: Revert.
11163 * amd64-fbsd-nat.c: Revert.
11164 * amd64-dicos-tdep.c: Revert.
11165 * amd64-darwin-tdep.c: Revert.
11166 * amd64-bsd-nat.c: Revert.
11167 * alpha-tdep.c: Revert.
11168 * alpha-obsd-tdep.c: Revert.
11169 * alpha-nbsd-tdep.c: Revert.
11170 * alpha-mdebug-tdep.c: Revert.
11171 * alpha-linux-tdep.c: Revert.
11172 * alpha-linux-nat.c: Revert.
11173 * alpha-bsd-tdep.c: Revert.
11174 * alpha-bsd-nat.c: Revert.
11175 * aix-thread.c: Revert.
11176 * agent.c: Revert.
11177 * addrmap.c: Revert.
11178 * ada-varobj.c: Revert.
11179 * ada-valprint.c: Revert.
11180 * ada-typeprint.c: Revert.
11181 * ada-tasks.c: Revert.
11182 * ada-lang.c: Revert.
11183 * aarch64-tdep.c: Revert.
11184 * aarch64-ravenscar-thread.c: Revert.
11185 * aarch64-newlib-tdep.c: Revert.
11186 * aarch64-linux-tdep.c: Revert.
11187 * aarch64-linux-nat.c: Revert.
11188 * aarch64-fbsd-tdep.c: Revert.
11189 * aarch64-fbsd-nat.c: Revert.
11190 * aarch32-linux-nat.c: Revert.
11191
d55e5aa6
TT
111922019-04-05 Tom Tromey <tom@tromey.com>
11193
11194 * ft32-tdep.c: Sort headers.
11195 * frv-tdep.c: Sort headers.
11196 * frv-linux-tdep.c: Sort headers.
11197 * frame.c: Sort headers.
11198 * frame-unwind.c: Sort headers.
11199 * frame-base.c: Sort headers.
11200 * fork-child.c: Sort headers.
11201 * findvar.c: Sort headers.
11202 * findcmd.c: Sort headers.
11203 * filesystem.c: Sort headers.
11204 * filename-seen-cache.h: Sort headers.
11205 * filename-seen-cache.c: Sort headers.
11206 * fbsd-tdep.c: Sort headers.
11207 * fbsd-nat.h: Sort headers.
11208 * fbsd-nat.c: Sort headers.
11209 * f-valprint.c: Sort headers.
11210 * f-typeprint.c: Sort headers.
11211 * f-lang.c: Sort headers.
11212 * extension.h: Sort headers.
11213 * extension.c: Sort headers.
11214 * extension-priv.h: Sort headers.
11215 * expprint.c: Sort headers.
11216 * exec.h: Sort headers.
11217 * exec.c: Sort headers.
11218 * exceptions.c: Sort headers.
11219 * event-top.c: Sort headers.
11220 * event-loop.c: Sort headers.
11221 * eval.c: Sort headers.
11222 * elfread.c: Sort headers.
11223 * dwarf2read.h: Sort headers.
11224 * dwarf2read.c: Sort headers.
11225 * dwarf2loc.c: Sort headers.
11226 * dwarf2expr.h: Sort headers.
11227 * dwarf2expr.c: Sort headers.
11228 * dwarf2-frame.c: Sort headers.
11229 * dwarf2-frame-tailcall.c: Sort headers.
11230 * dwarf-index-write.h: Sort headers.
11231 * dwarf-index-write.c: Sort headers.
11232 * dwarf-index-common.c: Sort headers.
11233 * dwarf-index-cache.h: Sort headers.
11234 * dwarf-index-cache.c: Sort headers.
11235 * dummy-frame.c: Sort headers.
11236 * dtrace-probe.c: Sort headers.
11237 * disasm.h: Sort headers.
11238 * disasm.c: Sort headers.
11239 * disasm-selftests.c: Sort headers.
11240 * dictionary.c: Sort headers.
11241 * dicos-tdep.c: Sort headers.
11242 * demangle.c: Sort headers.
11243 * dcache.h: Sort headers.
11244 * dcache.c: Sort headers.
11245 * darwin-nat.h: Sort headers.
11246 * darwin-nat.c: Sort headers.
11247 * darwin-nat-info.c: Sort headers.
11248 * d-valprint.c: Sort headers.
11249 * d-namespace.c: Sort headers.
11250 * d-lang.c: Sort headers.
11251 * ctf.c: Sort headers.
11252 * csky-tdep.c: Sort headers.
11253 * csky-linux-tdep.c: Sort headers.
11254 * cris-tdep.c: Sort headers.
11255 * cris-linux-tdep.c: Sort headers.
11256 * cp-valprint.c: Sort headers.
11257 * cp-support.c: Sort headers.
11258 * cp-namespace.c: Sort headers.
11259 * cp-abi.c: Sort headers.
11260 * corelow.c: Sort headers.
11261 * corefile.c: Sort headers.
11262 * continuations.c: Sort headers.
11263 * completer.h: Sort headers.
11264 * completer.c: Sort headers.
11265 * complaints.c: Sort headers.
11266 * coffread.c: Sort headers.
11267 * coff-pe-read.c: Sort headers.
11268 * cli-out.h: Sort headers.
11269 * cli-out.c: Sort headers.
11270 * charset.c: Sort headers.
11271 * c-varobj.c: Sort headers.
11272 * c-valprint.c: Sort headers.
11273 * c-typeprint.c: Sort headers.
11274 * c-lang.c: Sort headers.
11275 * buildsym.c: Sort headers.
11276 * buildsym-legacy.c: Sort headers.
11277 * build-id.h: Sort headers.
11278 * build-id.c: Sort headers.
11279 * btrace.c: Sort headers.
11280 * bsd-uthread.c: Sort headers.
11281 * breakpoint.h: Sort headers.
11282 * breakpoint.c: Sort headers.
11283 * break-catch-throw.c: Sort headers.
11284 * break-catch-syscall.c: Sort headers.
11285 * break-catch-sig.c: Sort headers.
11286 * blockframe.c: Sort headers.
11287 * block.c: Sort headers.
11288 * bfin-tdep.c: Sort headers.
11289 * bfin-linux-tdep.c: Sort headers.
11290 * bfd-target.c: Sort headers.
11291 * bcache.c: Sort headers.
11292 * ax-general.c: Sort headers.
11293 * ax-gdb.h: Sort headers.
11294 * ax-gdb.c: Sort headers.
11295 * avr-tdep.c: Sort headers.
11296 * auxv.c: Sort headers.
11297 * auto-load.c: Sort headers.
11298 * arm-wince-tdep.c: Sort headers.
11299 * arm-tdep.c: Sort headers.
11300 * arm-symbian-tdep.c: Sort headers.
11301 * arm-pikeos-tdep.c: Sort headers.
11302 * arm-obsd-tdep.c: Sort headers.
11303 * arm-nbsd-tdep.c: Sort headers.
11304 * arm-nbsd-nat.c: Sort headers.
11305 * arm-linux-tdep.c: Sort headers.
11306 * arm-linux-nat.c: Sort headers.
11307 * arm-fbsd-tdep.c: Sort headers.
11308 * arm-fbsd-nat.c: Sort headers.
11309 * arm-bsd-tdep.c: Sort headers.
11310 * arch-utils.c: Sort headers.
11311 * arc-tdep.c: Sort headers.
11312 * arc-newlib-tdep.c: Sort headers.
11313 * annotate.h: Sort headers.
11314 * annotate.c: Sort headers.
11315 * amd64-windows-tdep.c: Sort headers.
11316 * amd64-windows-nat.c: Sort headers.
11317 * amd64-tdep.c: Sort headers.
11318 * amd64-sol2-tdep.c: Sort headers.
11319 * amd64-obsd-tdep.c: Sort headers.
11320 * amd64-obsd-nat.c: Sort headers.
11321 * amd64-nbsd-tdep.c: Sort headers.
11322 * amd64-nbsd-nat.c: Sort headers.
11323 * amd64-nat.c: Sort headers.
11324 * amd64-linux-tdep.c: Sort headers.
11325 * amd64-linux-nat.c: Sort headers.
11326 * amd64-fbsd-tdep.c: Sort headers.
11327 * amd64-fbsd-nat.c: Sort headers.
11328 * amd64-dicos-tdep.c: Sort headers.
11329 * amd64-darwin-tdep.c: Sort headers.
11330 * amd64-bsd-nat.c: Sort headers.
11331 * alpha-tdep.c: Sort headers.
11332 * alpha-obsd-tdep.c: Sort headers.
11333 * alpha-nbsd-tdep.c: Sort headers.
11334 * alpha-mdebug-tdep.c: Sort headers.
11335 * alpha-linux-tdep.c: Sort headers.
11336 * alpha-linux-nat.c: Sort headers.
11337 * alpha-bsd-tdep.c: Sort headers.
11338 * alpha-bsd-nat.c: Sort headers.
11339 * aix-thread.c: Sort headers.
11340 * agent.c: Sort headers.
11341 * addrmap.c: Sort headers.
11342 * ada-varobj.c: Sort headers.
11343 * ada-valprint.c: Sort headers.
11344 * ada-typeprint.c: Sort headers.
11345 * ada-tasks.c: Sort headers.
11346 * ada-lang.c: Sort headers.
11347 * aarch64-tdep.c: Sort headers.
11348 * aarch64-ravenscar-thread.c: Sort headers.
11349 * aarch64-newlib-tdep.c: Sort headers.
11350 * aarch64-linux-tdep.c: Sort headers.
11351 * aarch64-linux-nat.c: Sort headers.
11352 * aarch64-fbsd-tdep.c: Sort headers.
11353 * aarch64-fbsd-nat.c: Sort headers.
11354 * aarch32-linux-nat.c: Sort headers.
11355
699bd4cf
TT
113562019-04-04 Tom Tromey <tom@tromey.com>
11357
11358 * varobj.c (varobj_create): Update.
11359 * rust-exp.y (struct rust_parser) <update_innermost_block,
11360 lookup_symbol>: New methods.
11361 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11362 Rename.
11363 (rust_parser::rust_lookup_type)
11364 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11365 * printcmd.c (display_command, do_one_display): Update.
11366 * parser-defs.h (struct parser_state) <parser_state>: Add
11367 "tracker" parameter.
11368 (block_tracker): New member.
11369 (class innermost_block_tracker) <innermost_block_tracker>: Add
11370 "types" parameter.
11371 <reset>: Remove method.
11372 (innermost_block): Don't declare.
11373 (null_post_parser): Update.
11374 * parse.c (innermost_block): Remove global.
11375 (write_dollar_variable): Update.
11376 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11377 Remove "tracker_types" parameter.
11378 (parse_expression): Add "tracker" parameter.
11379 (parse_expression_for_completion): Update.
11380 (null_post_parser): Add "tracker" parameter.
11381 * p-exp.y: Update rules.
11382 * m2-exp.y: Update rules.
11383 * language.h (struct language_defn) <la_post_parser>: Add
11384 "tracker" parameter.
11385 * go-exp.y: Update rules.
11386 * f-exp.y: Update rules.
11387 * expression.h (parse_expression, parse_exp_1): Add "tracker"
11388 parameter.
11389 * d-exp.y: Update rules.
11390 * c-exp.y: Update rules.
11391 * breakpoint.c (set_breakpoint_condition): Create an
11392 innermost_block_tracker.
11393 (watch_command_1): Likewise.
11394 * ada-lang.c (resolve): Add "tracker" parameter.
11395 (resolve_subexp): Likewise.
11396 * ada-exp.y (write_var_from_sym): Update.
11397
dac43e32
TT
113982019-04-04 Tom Tromey <tom@tromey.com>
11399
11400 * type-stack.h: New file.
11401 * type-stack.c: New file.
11402 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11403 type-stack.h.
11404 (insert_into_type_stack, insert_type, push_type, push_type_int)
11405 (insert_type_address_space, pop_type, pop_type_int)
11406 (pop_typelist, pop_type_stack, append_type_stack)
11407 (push_type_stack, get_type_stack, push_typelist)
11408 (follow_type_instance_flags, follow_types): Don't declare.
11409 * parse.c (type_stack): Remove global.
11410 (parse_exp_in_context): Update.
11411 (insert_into_type_stack, insert_type, push_type, push_type_int)
11412 (insert_type_address_space, pop_type, pop_type_int)
11413 (pop_typelist, pop_type_stack, append_type_stack)
11414 (push_type_stack, get_type_stack, push_typelist)
11415 (follow_type_instance_flags, follow_types): Remove (moved to
11416 type-stack.c).
11417 * f-exp.y (type_stack): New global.
11418 Update rules.
11419 (push_kind_type, f_parse): Update.
11420 * d-exp.y (type_stack): New global.
11421 Update rules.
11422 (d_parse): Update.
11423 * c-exp.y (struct c_parse_state) <type_stack>: New member.
11424 Update rules.
11425 * Makefile.in (COMMON_SFILES): Add type-stack.c.
11426 (HFILES_NO_SRCDIR): Add type-stack.h.
11427
2a612529
TT
114282019-04-04 Tom Tromey <tom@tromey.com>
11429
11430 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11431 (rust_parser::convert_ast_to_expression, rust_parse)
11432 (rust_lex_test_completion, rust_lex_tests): Update.
11433 * parser-defs.h (struct expr_completion_state): New.
11434 (struct parser_state) <parser_state>: Add completion parameter.
11435 <mark_struct_expression, mark_completion_tag>: New methods.
11436 <parse_completion, m_completion_state>: New members.
11437 (prefixify_expression, null_post_parser): Update.
11438 (mark_struct_expression, mark_completion_tag): Don't declare.
11439 * parse.c (parse_completion, expout_last_struct)
11440 (expout_tag_completion_type, expout_completion_name): Remove
11441 globals.
11442 (parser_state::mark_struct_expression)
11443 (parser_state::mark_completion_tag): Now methods.
11444 (prefixify_expression): Add last_struct parameter.
11445 (prefixify_subexp): Likewise.
11446 (parse_exp_1): Update.
11447 (parse_exp_in_context): Add cstate parameter. Update.
11448 (parse_expression_for_completion): Create an
11449 expr_completion_state.
11450 (null_post_parser): Add "completion" parameter.
11451 * p-exp.y: Update rules.
11452 (yylex): Update.
11453 * language.h (struct language_defn) <la_post_parser>: Add
11454 "completing" parameter.
11455 * go-exp.y: Update rules.
11456 (lex_one_token): Update.
11457 * expression.h (parse_completion): Don't declare.
11458 * d-exp.y: Update rules.
11459 (lex_one_token): Update rules.
11460 * c-exp.y: Update rules.
11461 (lex_one_token): Update.
11462 * ada-lang.c (resolve): Add "parse_completion" parameter.
11463 (resolve_subexp): Likewise.
11464 (ada_resolve_function): Likewise.
11465
43476f0b
TT
114662019-04-04 Tom Tromey <tom@tromey.com>
11467
11468 * parser-defs.h (struct parser_state) <start_arglist,
11469 end_arglist>: New methods.
11470 <arglist_len, m_funcall_chain>: New members.
11471 (arglist_len, start_arglist, end_arglist): Don't declare.
11472 * parse.c (arglist_len, funcall_chain): Remove global.
11473 (start_arglist, end_arglist): Remove functions.
11474 (parse_exp_in_context): Update.
11475 * p-exp.y: Update rules.
11476 * m2-exp.y: Update rules.
11477 * go-exp.y: Update rules.
11478 * f-exp.y: Update rules.
11479 * d-exp.y: Update rules.
11480 * c-exp.y: Update rules.
11481
5776fca3
TT
114822019-04-04 Tom Tromey <tom@tromey.com>
11483
11484 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11485 lex_operator, push_back>: New methods.
11486 Update all rules.
11487 (rust_parser::lex_hex, lex_escape): Rename and update.
11488 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11489 (rust_parser::lex_operator): Rename and update.
11490 (rust_parser::lex_number, rustyylex, rustyyerror)
11491 (rust_lex_test_init, rust_lex_test_sequence)
11492 (rust_lex_test_push_back, rust_lex_tests): Update.
11493 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11494 parameter.
11495 <lexptr, prev_lexptr>: New members.
11496 (lexptr, prev_lexptr): Don't declare.
11497 * parse.c (lexptr, prev_lexptr): Remove globals.
11498 (parse_exp_in_context): Update.
11499 * p-exp.y (yylex, yyerror): Update.
11500 * m2-exp.y (parse_number, yylex, yyerror): Update.
11501 * go-exp.y (lex_one_token, yyerror): Update.
11502 * f-exp.y (match_string_literal, yylex, yyerror): Update.
11503 * d-exp.y (lex_one_token, yyerror): Update.
11504 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11505 (lex_one_token, yyerror): Update.
11506 * ada-lex.l (YY_INPUT): Update.
11507 (rewind_to_char): Update.
11508 * ada-exp.y (yyerror): Update.
11509
8621b685
TT
115102019-04-04 Tom Tromey <tom@tromey.com>
11511
11512 * rust-exp.y (rustyylex, rust_lex_tests): Update.
11513 * parser-defs.h (struct parser_state) <parser_state>: Add new
11514 parameter.
11515 <comma_terminates>: New member.
11516 (comma_terminates): Don't declare global.
11517 * parse.c (comma_terminates): Remove global.
11518 (parse_exp_in_context): Update.
11519 * p-exp.y (yylex): Update.
11520 * m2-exp.y (yylex): Update.
11521 * go-exp.y (lex_one_token): Update.
11522 * f-exp.y (yylex): Update.
11523 * d-exp.y (lex_one_token): Update.
11524 * c-exp.y (lex_one_token): Update.
11525 * ada-lex.l: Update.
11526
28aaf3fd
TT
115272019-04-04 Tom Tromey <tom@tromey.com>
11528
11529 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11530 (rustyylex, rust_lex_test_init, rust_lex_test_one)
11531 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11532 * parser-defs.h (paren_depth): Don't declare.
11533 * parse.c (paren_depth): Remove global.
11534 (parse_exp_in_context): Update.
11535 * p-exp.y (paren_depth): New global.
11536 (pascal_parse): Initialize it.
11537 * m2-exp.y (paren_depth): New global.
11538 (m2_parse): Initialize it.
11539 * go-exp.y (paren_depth): New global.
11540 (go_parse): Initialize it.
11541 * f-exp.y (paren_depth): New global.
11542 (f_parse): Initialize it.
11543 * d-exp.y (paren_depth): New global.
11544 (d_parse): Initialize it.
11545 * c-exp.y (paren_depth): New global.
11546 (c_parse): Initialize it.
11547 * ada-lex.l (paren_depth): New global.
11548 (lexer_init): Initialize it.
11549
1e58a4a4
TT
115502019-04-04 Tom Tromey <tom@tromey.com>
11551
11552 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11553 (rust_parser::convert_ast_to_type)
11554 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11555 * parser-defs.h (struct parser_state) <parser_state>: Add
11556 parameters. Initialize new members.
11557 <expression_context_block, expression_context_pc>: New members.
11558 * parse.c (expression_context_block, expression_context_pc):
11559 Remove globals.
11560 (parse_exp_in_context): Update.
11561 * p-exp.y: Update all rules.
11562 (yylex): Update.
11563 * m2-exp.y: Update all rules.
11564 (yylex): Update.
11565 * go-exp.y (yylex): Update.
11566 * f-exp.y (yylex): Update.
11567 * d-exp.y: Update all rules.
11568 (yylex): Update.
11569 * c-exp.y: Update all rules.
11570 (lex_one_token, classify_name, yylex, c_parse): Update.
11571 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11572
37eedb39
TT
115732019-04-04 Tom Tromey <tom@tromey.com>
11574
11575 * gdbarch.h, gdbarch.c: Rebuild.
11576 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11577 * stap-probe.h:
11578 (struct stap_parse_info): Replace "parser_state" with
11579 "expr_builder".
11580 * parser-defs.h (struct expr_builder): Rename from "parser_state".
11581 (parser_state): New class.
11582 * parse.c (expr_builder): Rename.
11583 (expr_builder::release): Rename.
11584 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11585 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11586 (write_exp_elt_longcst, write_exp_elt_floatcst)
11587 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11588 (write_exp_string_vector, write_exp_bitstring)
11589 (write_exp_msymbol, mark_struct_expression)
11590 (write_dollar_variable)
11591 (insert_type_address_space, increase_expout_size): Replace
11592 "parser_state" with "expr_builder".
11593 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11594 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11595 "parser_state" with "expr_builder".
11596
73923d7e
TT
115972019-04-04 Tom Tromey <tom@tromey.com>
11598
11599 * rust-exp.y: Replace "parse_language" with method call.
11600 * p-exp.y:
11601 (yylex): Replace "parse_language" with method call.
11602 * m2-exp.y:
11603 (yylex): Replace "parse_language" with method call.
11604 * go-exp.y (classify_name): Replace "parse_language" with method
11605 call.
11606 * f-exp.y (yylex): Replace "parse_language" with method call.
11607 * d-exp.y (lex_one_token): Replace "parse_language" with method
11608 call.
11609 * c-exp.y:
11610 (lex_one_token, classify_name, yylex): Replace "parse_language"
11611 with method call.
11612 * ada-exp.y (find_primitive_type, type_char)
11613 (type_system_address): Replace "parse_language" with method call.
11614
fa9f5be6
TT
116152019-04-04 Tom Tromey <tom@tromey.com>
11616
11617 * rust-exp.y: Replace "parse_gdbarch" with method call.
11618 * parse.c (write_dollar_variable, insert_type_address_space):
11619 Replace "parse_gdbarch" with method call.
11620 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11621 call.
11622 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11623 call.
11624 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11625 "parse_gdbarch" with method call.
11626 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11627 with method call.
11628 * f-exp.y (parse_type, parse_f_type, yylex): Replace
11629 "parse_gdbarch" with method call.
11630 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11631 "parse_gdbarch" with method call.
11632 * c-exp.y (parse_type, parse_number, classify_name): Replace
11633 "parse_gdbarch" with method call.
11634 * ada-lex.l: Replace "parse_gdbarch" with method call.
11635 * ada-exp.y (parse_type, find_primitive_type, type_char)
11636 (type_system_address): Replace "parse_gdbarch" with method call.
11637
1201a264
TT
116382019-04-04 Tom Tromey <tom@tromey.com>
11639
11640 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11641 * stap-probe.c (stap_parse_argument): Update.
11642 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11643 initial_size parameter.
11644 * rust-exp.y (rust_lex_tests): Update.
11645 * parse.c (parser_state): Update.
11646 (parse_exp_in_context): Update.
11647 * parser-defs.h (struct parser_state) <parser_state>: Remove
11648 "initial_size" parameter.
11649
e3980ce2
TT
116502019-04-04 Tom Tromey <tom@tromey.com>
11651
11652 * parser-defs.h (increase_expout_size): Don't declare.
11653 * parse.c (increase_expout_size): Now static.
11654
e9f8e3f1
TS
116552019-04-04 Thomas Schwinge <thomas@codesourcery.com>
11656
11657 * gnu-nat.c (gnu_nat_target::wait): Fix
11658 target_waitstatus_to_string call.
11659
d7df6549
AB
116602019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
11661
11662 * eval.c (evaluate_subexp_standard): Handle internal functions
11663 during Fortran function call handling.
11664
8bdc1658
AB
116652019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
11666
11667 * NEWS: Mention new internal functions.
11668 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11669 (read_base_type): Use dwarf2_init_complex_target_type.
11670 * value.c (creal_internal_fn): New function.
11671 (cimag_internal_fn): New function.
11672 (_initialize_values): Register new internal functions.
11673
c29705b7
PW
116742019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11675
11676 * infrun.c (stop_all_threads): If debug_infrun, always
11677 trace the wait status after wait_one, using
11678 target_waitstatus_to_string and target_pid_to_str.
11679 (handle_inferior_event): Replace various trace of
11680 wait status kind by a single trace.
11681 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11682 wait status kind image by target_waitstatus_to_string.
11683 * target/waitstatus.c (target_waitstatus_to_string): Fix
11684 obsolete comment.
11685
05caa1d2
TT
116862019-04-01 Tom Tromey <tromey@adacore.com>
11687
11688 PR symtab/23331:
11689 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11690
9d1447e0
SDJ
116912019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
11692 Pedro Alves <palves@redhat.com>
11693
11694 * top.c (quit_force): Call 'finalize_values'.
11695 * value.c (finalize_values): New function.
11696 * value.h (finalize_values): Declare.
11697
7734102d
EZ
116982019-03-30 Eli Zaretskii <eliz@gnu.org>
11699
11700 * NEWS: Announce $_gdb_major and $_gdb_minor.
11701
11702 * top.c (init_gdb_version_vars): New function.
11703 (gdb_init): Call init_gdb_version_vars.
11704
188e1fa9
TT
117052019-03-29 Tom Tromey <tromey@adacore.com>
11706
11707 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
11708 help text. Remove dead code.
11709
2880242d
KS
117102019-03-29 Keith Seitz <keiths@redhat.com>
11711
11712 From Siddhesh Poyarekar:
11713 * f-lang.h (f77_get_upperbound): Return LONGEST.
11714 (f77_get_lowerbound): Likewise.
11715 * f-typeprint.c (f_type_print_varspec_suffix): Expand
11716 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
11717 print them.
11718 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
11719 plongest to format print it.
11720 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11721 (f77_get_upperbound): Likewise.
11722 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11723 LOWER_BOUND to LONGEST.
11724 (f77_create_arrayprint_offset_tbl): Likewise.
11725
cc1defb1
KS
117262019-03-29 Keith Seitz <keiths@redhat.com>
11727
11728 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11729 %s/pulongest for TYPE_LENGTH instead of %d in format
11730 strings.
11731 * ada-typerint.c (ada_print_type): Likewise.
11732 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11733 * compile/compile-c-support.c (generate_register_struct): Likewise.
11734 * gdbtypes.c (recursive_dump_type): Likewise.
11735 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11736 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
11737 instead of %d in format strings.
11738 * riscv-tdep.c (riscv_type_alignment): Cast second argument
11739 to std::min to ULONGEST.
11740 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11741 instead of %d in format strings.
11742 * tracepoint.c (info_scope_command): Likewise.
11743 * typeprint.c (print_offset_data::update)
11744 (print_offset_data::finish): Likewise.
11745 * xtensa-tdep.c (xtensa_store_return_value)
11746 (xtensa_push_dummy_call): Likewise.
11747
e432ccf1
JT
117482019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
11749
11750 * windows-nat.c (display_selector): Fixed format specifications
11751 for 64-bit Cygwin.
11752
65d2b333
PW
117532019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11754
11755 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11756
f489207e
SL
117572019-03-28 Sandra Loosemore <sandra@codesourcery.com>
11758
11759 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11760 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11761 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11762 (nios2_linux_init_abi): Install it.
11763
bffa1015
AH
117642019-03-28 Alan Hayward <alan.hayward@arm.com>
11765
11766 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11767
fc96163a
AH
117682019-03-28 Alan Hayward <alan.hayward@arm.com>
11769
11770 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11771
20dc7e9b
PW
117722019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11773 Tom Tromey <tromey@adacore.com>
11774
11775 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11776
7f5331a8
JB
117772019-03-26 Joel Brobecker <brobecker@adacore.com>
11778
11779 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11780 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11781 method to compute the bounds of range types. Also print "[evaluated]"
11782 if the bounds' values come from a dynamic evaluation.
11783
18c77628
AB
117842019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
11785
11786 * cp-valprint.c (cp_print_value_fields): Don't print trailing
11787 whitespace when pretty printing is on.
11788
53c973f2
AH
117892019-03-26 Alan Hayward <alan.hayward@arm.com>
11790
e79be6e5 11791 * ppc-linux-nat.c: Add include.
53c973f2 11792
d851aa71
AH
117932019-03-26 Alan Hayward <alan.hayward@arm.com>
11794
e79be6e5 11795 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 11796
2fe7bab7
AH
117972019-03-26 Alan Hayward <alan.hayward@arm.com>
11798
e79be6e5 11799 * arm-linux-nat.c: Add include.
2fe7bab7 11800
068ef30e
SM
118012019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
11802
11803 * source-cache.c (source_cache::get_source_lines): Re-read
11804 fullname after calling open_source_file.
11805
81a24d04
JB
118062019-03-25 John Baldwin <jhb@FreeBSD.org>
11807
11808 * NEWS: Mention TLS support for FreeBSD.
11809
79e7ae11
TT
118102019-03-25 Tom Tromey <tromey@adacore.com>
11811
11812 * minsyms.c (BUNCH_SIZE): Update comment.
11813 (~minimal_symbol_reader): Remove old comment.
11814 (compact_minimal_symbols): Update comment.
11815 (minimal_symbol_reader::install): Remove old comment. Update
11816 other comments.
11817
d45963c2
AH
118182019-03-25 Alan Hayward <alan.hayward@arm.com>
11819
11820 * s390-linux-nat.c: Add include.
11821
0f83012e
AH
118222019-03-25 Alan Hayward <alan.hayward@arm.com>
11823
11824 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11825 Call linux_get_hwcap.
11826 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11827 Likewise.
11828 (aarch64_linux_get_hwcap): Remove function.
11829 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11830 declaration.
11831 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11832 linux_get_hwcap.
11833 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11834 * linux-tdep.c (linux_get_hwcap): Add function.
11835 (linux_get_hwcap2): Likewise.
11836 * linux-tdep.h (linux_get_hwcap): Add declaration.
11837 (linux_get_hwcap2): Likewise.
11838 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11839 (ppc_linux_get_hwcap2): Likewise.
11840 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11841 linux_get_hwcap.
11842 (ppc_linux_nat_target::insert_watchpoint): Likewise.
11843 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11844 (ppc_linux_nat_target::read_description): Likewise.
11845 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11846 * s390-linux-nat.c: Likewise.
11847 * s390-linux-tdep.c (s390_core_read_description): Likewise.
11848
6640a367
TT
118492019-03-24 Tom Tromey <tom@tromey.com>
11850
11851 * ada-lang.c (standard_lookup): Simplify initialization.
11852 (ada_lookup_symbol_nonlocal): Simplify return.
11853 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11854 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11855 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11856 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11857 initialization.
11858 * solib.c (solib_global_lookup): Simplify.
11859 * symtab.c (null_block_symbol): Remove.
11860 (symbol_cache_lookup): Simplify returns.
11861 (lookup_language_this): Simplify returns.
11862 (lookup_symbol_aux): Simplify return.
11863 (lookup_local_symbol): Simplify returns.
11864 (lookup_global_symbol_from_objfile): Simplify return.
11865 (lookup_symbol_in_objfile_symtabs)
11866 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11867 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11868 (lookup_static_symbol, lookup_global_symbol): Simplify return.
11869 * cp-namespace.c (cp_lookup_bare_symbol)
11870 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11871 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11872 (cp_lookup_nested_symbol): Don't use null_block_symbol.
11873 (cp_lookup_symbol_via_imports): Simplify initialization.
11874 (find_symbol_in_baseclass): Likewise.
11875 * symtab.h (null_block_symbol): Remove.
11876 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11877 (d_lookup_nested_symbol, d_lookup_symbol_imports)
11878 (d_lookup_symbol_module): Likewise.
11879 (find_symbol_in_baseclass): Simplify initialization.
11880
a930ebcd
TT
118812019-03-24 Tom Tromey <tom@tromey.com>
11882
11883 * expression.h: Don't include symtab.h.
11884 (struct block): Forward declare.
11885
582942f4
TT
118862019-03-24 Tom Tromey <tom@tromey.com>
11887
11888 * c-exp.y (typebase): Remove casts.
11889 * gdbtypes.c (lookup_unsigned_typename, )
11890 (lookup_signed_typename): Remove cast.
11891 * eval.c (parse_to_comma_and_eval): Remove cast.
11892 * parse.c (write_dollar_variable): Remove cast.
11893 * block.h (struct block) <superblock>: Now const.
11894 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11895 * psymtab.c (psym_map_matching_symbols): Make "block" const.
11896 (map_block): Make "block" const.
11897 * symfile.h (struct quick_symbol_functions)
11898 <map_matching_symbols>: Constify block argument to "callback".
11899 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11900 const.
11901 (find_pc_sect_compunit_symtab): Make "b" const.
11902 (find_symbol_at_address): Likewise.
11903 (search_symbols): Likewise.
11904 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11905 (dw2_debug_names_lookup_symbol): Likewise.
11906 (dw2_map_matching_symbols): Update.
11907 * p-valprint.c (pascal_val_print): Remove "block".
11908 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11909 (aux_add_nonlocal_symbols): Make "block" const.
11910 (resolve_subexp): Remove cast.
11911 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11912 const.
11913 (iterate_over_file_blocks): Likewise.
11914 * f-exp.y (%union) <bval>: Remove.
11915 * coffread.c (patch_opaque_types): Make "b" const.
11916 * spu-tdep.c (spu_catch_start): Make "block" const.
11917 * c-valprint.c (print_unpacked_pointer): Remove "block".
11918 * symmisc.c (dump_symtab_1): Make "b" const.
11919 (block_depth): Make "block" const.
11920 * d-exp.y (%union) <bval>: Remove.
11921 * cp-support.h (cp_lookup_rtti_type): Update.
11922 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11923 * psymtab.c (psym_lookup_symbol): Make "block" const.
11924 (maintenance_check_psymtabs): Make "b" const.
11925 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11926 (enumerate_locals, enumerate_args): Update.
11927 * python/py-symtab.c (stpy_global_block): Make "block" const.
11928 (stpy_static_block): Likewise.
11929 * inline-frame.c (block_starting_point_at): Make "new_block"
11930 const.
11931 * block.c (find_block_in_blockvector): Make return type const.
11932 (blockvector_for_pc_sect): Make "b" const.
11933 (find_block_in_blockvector): Make "b" const.
11934
7ad417dd
TT
119352019-03-23 Tom Tromey <tom@tromey.com>
11936
11937 * varobj.c (varobj_create): Update.
11938 * symfile.c (clear_symtab_users): Don't reset innermost_block.
11939 * printcmd.c (display_command, do_one_display): Don't reset
11940 innermost_block.
11941 * parser-defs.h (enum innermost_block_tracker_type): Move to
11942 expression.h.
11943 (innermost_block): Update comment.
11944 * parse.c (parse_exp_1): Add tracker_types parameter.
11945 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
11946 tracker_types parameter. Reset innermost_block.
11947 (parse_exp_in_context): Remove.
11948 (parse_expression_for_completion): Update.
11949 * objfiles.c (~objfile): Don't reset expression_context_block or
11950 innermost_block.
11951 * expression.h (enum innermost_block_tracker_type): Move from
11952 parser-defs.h.
11953 (parse_exp_1): Add tracker_types parameter.
11954 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11955 reset innermost_block.
11956
b366c208
TT
119572019-03-23 Tom Tromey <tom@tromey.com>
11958
11959 * objfiles.h: Include bcache.h.
11960
9bb9b2f9
TT
119612019-03-23 Tom Tromey <tom@tromey.com>
11962
11963 * linespec.c (get_current_search_block): Use
11964 scoped_restore_current_language.
11965 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11966
59c28372
AH
119672019-03-22 Alan Hayward <alan.hayward@arm.com>
11968 Jiong Wang <jiong.wang@arm.com>
11969
11970 * aarch64-linux-tdep.c
11971 (aarch64_linux_iterate_over_regset_sections): Check for pauth
11972 section.
11973 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11974
17e116a7
AH
119752019-03-22 Alan Hayward <alan.hayward@arm.com>
11976 Jiong Wang <jiong.wang@arm.com>
11977
11978 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11979 instructions.
11980 (aarch64_analyze_prologue_test): Add PACIASP test.
11981 (aarch64_prologue_prev_register): Unmask PC value.
11982
11e1b75f
AH
119832019-03-22 Alan Hayward <alan.hayward@arm.com>
11984 Jiong Wang <jiong.wang@arm.com>
11985
11986 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11987 (aarch64_dwarf2_prev_register): Unmask PC value.
11988 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11989 (aarch64_execute_dwarf_cfa_vendor_op): Check for
11990 DW_CFA_AARCH64_negate_ra_state.
11991 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11992
34dcc7cf
AH
119932019-03-22 Alan Hayward <alan.hayward@arm.com>
11994 Jiong Wang <jiong.wang@arm.com>
11995
11996 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11997 registers.
11998 (aarch64_pseudo_register_name): Likewise.
11999 (aarch64_pseudo_register_type): Likewise.
12000 (aarch64_pseudo_register_reggroup_p): Likewise.
12001 (aarch64_gdbarch_init): Add pauth registers.
12002 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12003 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12004 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12005 (struct gdbarch_tdep): Add regnum for ra_state.
12006
1ef53e6b
AH
120072019-03-22 Alan Hayward <alan.hayward@arm.com>
12008 Jiong Wang <jiong.wang@arm.com>
12009
12010 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12011
76bed0fd
AH
120122019-03-22 Alan Hayward <alan.hayward@arm.com>
12013 Jiong Wang <jiong.wang@arm.com>
12014
12015 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12016 function.
12017 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12018 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12019 (aarch64_gdbarch_init): Add puth registers.
12020 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12021 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12022 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12023
ee4fbcfa
AH
120242019-03-22 Alan Hayward <alan.hayward@arm.com>
12025 Jiong Wang <jiong.wang@arm.com>
12026
12027 * aarch64-linux-nat.c
12028 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12029 * aarch64-linux-tdep.c
12030 (aarch64_linux_core_read_description): Likewise.
12031 (aarch64_linux_get_hwcap): New function.
12032 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12033 (aarch64_linux_get_hwcap): New declaration.
12034
6dc0ebde
AH
120352019-03-22 Alan Hayward <alan.hayward@arm.com>
12036 Jiong Wang <jiong.wang@arm.com>
12037
12038 * aarch64-linux-nat.c
12039 (aarch64_linux_nat_target::read_description): Add pauth param.
12040 * aarch64-linux-tdep.c
12041 (aarch64_linux_core_read_description): Likewise.
12042 * aarch64-tdep.c (struct target_desc): Add in pauth.
12043 (aarch64_read_description): Add pauth param.
12044 (aarch64_gdbarch_init): Likewise.
12045 * aarch64-tdep.h (aarch64_read_description): Likewise.
12046 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12047 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12048 * features/Makefile: Add new files.
12049 * features/aarch64-pauth.c: New file.
12050 * features/aarch64-pauth.xml: New file.
12051
595915c1
TT
120522019-03-20 Tom Tromey <tromey@adacore.com>
12053
12054 * infrun.c (handle_inferior_event): Rename from
12055 handle_inferior_event_1. Create a scoped_value_mark.
12056 (handle_inferior_event): Remove.
12057
4c7d57e7
TT
120582019-03-19 Tom Tromey <tromey@adacore.com>
12059
12060 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12061 * infrun.h (print_stop_event): Add "displays" parameter.
12062 * infrun.c (print_stop_event): Add "displays" parameter.
12063
cb246234
PA
120642019-03-19 Pedro Alves <palves@redhat.com>
12065
12066 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12067 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12068 to -1. Fix TABs vs spaces.
12069 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12070 * tui/tui-out.h (tui_ui_out) Add intro comments.
12071 <m_line, m_start_of_line>: In-class initialize, and add describing
12072 comment.
12073
3a0e45b2
AH
120742019-03-18 Alan Hayward <alan.hayward@arm.com>
12075
12076 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12077 variable names.
12078 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12079
5371b850
PA
120802019-03-18 Pedro Alves <palves@redhat.com>
12081 Eli Zaretskii <eliz@gnu.org>
12082
12083 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12084 m_line and m_start_of_line.
12085
b17c4cd0
EZ
120862019-03-18 Eli Zaretskii <eliz@gnu.org>
12087
12088 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12089 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12090 it returns a newline. This fixes a regression in TU mode, whereby
12091 the next line is output on the same screen line as the user input.
12092
4bd56d18
TT
120932019-03-18 Tom Tromey <tromey@adacore.com>
12094
12095 * minsyms.c (minimal_symbol_reader::install): Remove call to
12096 obstack_blank.
12097
55c10aca
PA
120982019-03-18 Pedro Alves <palves@redhat.com>
12099
12100 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12101 New globals.
12102 (apply_style): New, factored out from ...
12103 (apply_ansi_escape): ... this. Handle reverse video mode.
12104 (tui_set_reverse_mode): New function.
12105 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12106 * tui/tui-winsource.c (tui_show_source_line): Use
12107 tui_set_reverse_mode instead of setting A_STANDOUT.
12108 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12109 New setter methods.
12110
647bb750
HD
121112019-03-18 Hannes Domani <ssbssa@yahoo.de>
12112
12113 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12114 Handle tabs.
12115
bff8c71f
TT
121162019-03-18 Tom Tromey <tromey@adacore.com>
12117
12118 * ada-lang.c (empty_array): Add "high" parameter.
12119 (ada_evaluate_subexp): Update.
12120
58785d98
ST
121212019-03-17 Sergei Trofimovich <siarheit@google.com>
12122
12123 * unittests/string_view-selftests.c: Define
12124 _initialize_string_view_selftests unconditionally.
12125
d4cbef22
ВМ
121262019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12127
12128 PR gdb/24350
12129 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12130
fce4c071
ВМ
121312019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12132
12133 PR gdb/24351
12134 * windows-nat.c (display_selector): Fix format specifiers.
12135
f7f0a123
EZ
121362019-03-17 Eli Zaretskii <eliz@gnu.org>
12137
12138 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12139 tui_refill_source_window instead of tui_refresh_win, to update the
12140 current execution line. This fixes redisplay of the current line
12141 when stepping through the code with "next" or "step".
12142
ab42892f
EZ
121432019-03-16 Eli Zaretskii <eliz@gnu.org>
12144
12145 * source-cache.c (source_cache::get_source_lines): Call
12146 find_source_lines to initialize s->nlines. This fixes vertical
12147 scrolling of TUI source window when the DOWN arrow is pressed.
12148
8d8c087f
PW
121492019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12150
12151 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12152 linux-thread-db.c (_initialize_thread_db): Likewise.
12153
798e1c30
EZ
121542019-03-16 Eli Zaretskii <eliz@gnu.org>
12155
12156 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12157 wclrtoeol in tui_show_source_line". This reverts changes made in
12158 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12159
eefba3da
TT
121602019-03-15 Tom Tromey <tom@tromey.com>
12161
12162 * symtab.h (struct minimal_symbol): Derive from
12163 general_symbol_info.
12164 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12165 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12166 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12167 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12168 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12169 (MSYMBOL_SEARCH_NAME): Update.
12170 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12171 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12172 * minsyms.c (minimal_symbol_reader::record_full): Update.
12173
0de2420c
TT
121742019-03-15 Tom Tromey <tom@tromey.com>
12175
12176 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12177
042d75e4
TT
121782019-03-15 Tom Tromey <tom@tromey.com>
12179
12180 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12181 unique_xmalloc_ptr.
12182 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12183 Update.
12184 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12185 (build_minimal_symbol_hash_tables)
12186 (minimal_symbol_reader::install): Update.
12187
db92718b
TT
121882019-03-15 Tom Tromey <tom@tromey.com>
12189
12190 * symtab.c (create_demangled_names_hash): Update.
12191 (symbol_set_names): Update.
12192 * objfiles.h (struct objfile_per_bfd_storage)
12193 <demangled_names_hash>: Now an htab_up.
12194 * objfiles.c (objfile_per_bfd_storage): Simplify.
12195
d6797f46
TT
121962019-03-15 Tom Tromey <tom@tromey.com>
12197
12198 * objfiles.h (struct objfile_per_bfd_storage): Declare
12199 destructor.
12200 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12201 New.
12202 (get_objfile_bfd_data): Use new. Don't initialize
12203 language_of_main.
12204 (free_objfile_per_bfd_storage): Remove.
12205 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12206
741d7538
TT
122072019-03-15 Tom Tromey <tom@tromey.com>
12208
12209 * symfile.c (reread_symbols): Update.
12210 * objfiles.c (objfile::objfile): Update.
12211 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12212 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12213 comment.
12214 (minimal_symbol_reader::install): Update.
12215 (terminate_minimal_symbol_table): Remove.
12216 * jit.c (jit_object_close_impl): Update.
12217
788c80d1
TT
122182019-03-15 Tom Tromey <tom@tromey.com>
12219
12220 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12221 initializations.
12222
1b7a07cb
TT
122232019-03-15 Tom Tromey <tom@tromey.com>
12224
12225 * objfiles.h (struct objfile_per_bfd_storage)
12226 <demangled_hash_languages>: Now a bitset.
12227 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12228 (lookup_minimal_symbol): Update.
12229
3db066bc
TT
122302019-03-15 Tom Tromey <tom@tromey.com>
12231
12232 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12233 Don't return the symbol.
12234 * coffread.c (record_minimal_symbol): Use record_full.
12235
3fff2c37
EZ
122362019-03-14 Eli Zaretskii <eliz@gnu.org>
12237
12238 The MS-Windows port of ncurses fails to switch to a color pair if
12239 one or both of the colors are the implicit default colors. This
12240 change records the default colors when TUI is initialized, and
12241 then specifies them explicitly when a color pair uses the default
12242 colors. This allows color styling in TUI mode on MS-Windows.
12243
12244 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12245 ncurses_norm_attr.
12246 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12247 colors in ncurses_norm_attr.
12248 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12249 "none", replace it with the default color recorded in
12250 ncurses_norm_attr.
12251
3b336828
TT
122522019-03-14 Tom Tromey <tromey@adacore.com>
12253
12254 * source-cache.h (class source_cache) <get_source_lines>: Return
12255 std::string.
12256 * source-cache.c (source_cache::extract_lines): Handle case where
12257 first_pos==npos. Return std::string.
12258 (source_cache::get_source_lines): Update.
12259
d085f989
TT
122602019-03-14 Tom Tromey <tromey@adacore.com>
12261
12262 * NEWS: Add item for "style sources" commands.
12263 * source-cache.c (source_cache::get_source_lines): Check
12264 source_styling.
12265 * cli/cli-style.c (source_styling): New global.
12266 (_initialize_cli_style): Add "style sources" commands.
12267 (show_style_sources): New function.
12268 * cli/cli-style.h (source_styling): Declare.
12269
6f11e682
TT
122702019-03-14 Pedro Alves <palves@redhat.com>
12271 Tom Tromey <tromey@adacore.com>
12272
12273 * tui/tui-winsource.h (tui_refill_source_window): Declare.
12274 * tui/tui-winsource.c (tui_refill_source_window): New function,
12275 from...
12276 (tui_horizontal_source_scroll): ... here. Move some logic.
12277 * cli/cli-style.c (set_style_enabled): Notify new observable.
12278 * tui/tui-hooks.c (tui_redisplay_source): New function.
12279 (tui_attach_detach_observers): Attach or detach
12280 tui_redisplay_source.
12281 * observable.h (source_styling_changed): New observable.
12282 * observable.c: Define source_styling_changed observable.
12283
a068643d
TT
122842019-03-13 Tom Tromey <tromey@adacore.com>
12285
12286 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12287 (i386_gnu_nat_target::store_registers): Update.
12288 * target-debug.h (target_debug_print_std_string): New macro.
12289 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12290 * windows-tdep.c (display_one_tib): Update.
12291 * tui/tui-stack.c (tui_make_status_line): Update.
12292 * top.c (print_inferior_quit_action): Update.
12293 * thread.c (thr_try_catch_cmd): Update.
12294 (add_thread_with_info): Update.
12295 (thread_target_id_str): Update.
12296 (thr_try_catch_cmd): Update.
12297 (thread_command): Update.
12298 (thread_find_command): Update.
12299 * record-btrace.c (record_btrace_target::info_record)
12300 (record_btrace_resume_thread, record_btrace_target::resume)
12301 (record_btrace_cancel_resume, record_btrace_step_thread)
12302 (record_btrace_target::wait, record_btrace_target::wait)
12303 (record_btrace_target::wait, record_btrace_target::stop): Update.
12304 * progspace.c (print_program_space): Update.
12305 * process-stratum-target.c
12306 (process_stratum_target::thread_address_space): Update.
12307 * linux-fork.c (linux_fork_mourn_inferior)
12308 (detach_checkpoint_command, info_checkpoints_command)
12309 (linux_fork_context): Update.
12310 (linux_fork_detach): Update.
12311 (class scoped_switch_fork_info): Update.
12312 (delete_checkpoint_command): Update.
12313 * infrun.c (follow_fork_inferior): Update.
12314 (follow_fork_inferior): Update.
12315 (proceed_after_vfork_done): Update.
12316 (handle_vfork_child_exec_or_exit): Update.
12317 (follow_exec): Update.
12318 (displaced_step_prepare_throw): Update.
12319 (displaced_step_restore): Update.
12320 (start_step_over): Update.
12321 (resume_1): Update.
12322 (clear_proceed_status_thread): Update.
12323 (proceed): Update.
12324 (print_target_wait_results): Update.
12325 (do_target_wait): Update.
12326 (context_switch): Update.
12327 (stop_all_threads): Update.
12328 (restart_threads): Update.
12329 (finish_step_over): Update.
12330 (handle_signal_stop): Update.
12331 (switch_back_to_stepped_thread): Update.
12332 (keep_going_pass_signal): Update.
12333 (print_exited_reason): Update.
12334 (normal_stop): Update.
12335 * inferior.c (inferior_pid_to_str): Change return type.
12336 (print_selected_inferior): Update.
12337 (add_inferior): Update.
12338 (detach_inferior): Update.
12339 * dummy-frame.c (fprint_dummy_frames): Update.
12340 * dcache.c (dcache_info_1): Update.
12341 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12342 (btrace_fetch, btrace_clear): Update.
12343 * linux-tdep.c (linux_core_pid_to_str): Change return type.
12344 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12345 type.
12346 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12347 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12348 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12349 * gdbarch.c, gdbarch.h: Rebuild.
12350 * gdbarch.sh (core_pid_to_str): Change return type.
12351 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12352 return type.
12353 (windows_nat_target::pid_to_str): Change return type.
12354 (windows_delete_thread): Update.
12355 (windows_nat_target::attach): Update.
12356 (windows_nat_target::files_info): Update.
12357 * target-delegates.c: Rebuild.
12358 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12359 return type.
12360 (sol_thread_target::pid_to_str): Change return type.
12361 * remote.c (class remote_target) <pid_to_str>: Change return
12362 type.
12363 (remote_target::pid_to_str): Change return type.
12364 (extended_remote_target::attach, remote_target::remote_stop_ns)
12365 (remote_target::remote_notif_remove_queued_reply)
12366 (remote_target::push_stop_reply, remote_target::disable_btrace):
12367 Update.
12368 (extended_remote_target::attach): Update.
12369 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12370 type.
12371 (gdbsim_target::pid_to_str): Change return type.
12372 * ravenscar-thread.c (struct ravenscar_thread_target)
12373 <pid_to_str>: Change return type.
12374 (ravenscar_thread_target::pid_to_str): Change return type.
12375 * procfs.c (class procfs_target) <pid_to_str>: Change return
12376 type.
12377 (procfs_target::pid_to_str): Change return type.
12378 (procfs_target::attach): Update.
12379 (procfs_target::detach): Update.
12380 (procfs_target::fetch_registers): Update.
12381 (procfs_target::store_registers): Update.
12382 (procfs_target::wait): Update.
12383 (procfs_target::files_info): Update.
12384 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12385 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12386 return type.
12387 (nto_procfs_target::pid_to_str): Change return type.
12388 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12389 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12390 return type.
12391 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12392 (exit_lwp): Update.
12393 (attach_proc_task_lwp_callback, get_detach_signal)
12394 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12395 (linux_nat_target::resume, wait_lwp, stop_callback)
12396 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12397 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12398 (linux_nat_wait_1, resume_stopped_resumed_lwps)
12399 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12400 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12401 type.
12402 (inf_ptrace_target::attach): Update.
12403 (inf_ptrace_target::files_info): Update.
12404 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12405 type.
12406 (go32_nat_target::pid_to_str): Change return type.
12407 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12408 (gnu_nat_target::wait): Update.
12409 (gnu_nat_target::wait): Update.
12410 (gnu_nat_target::resume): Update.
12411 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12412 (fbsd_nat_target::wait): Update.
12413 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12414 type.
12415 (darwin_nat_target::attach): Update.
12416 * corelow.c (class core_target) <pid_to_str>: Change return type.
12417 (core_target::pid_to_str): Change return type.
12418 * target.c (normal_pid_to_str): Change return type.
12419 (default_pid_to_str): Likewise.
12420 (target_pid_to_str): Change return type.
12421 (target_translate_tls_address): Update.
12422 (target_announce_detach): Update.
12423 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12424 return type.
12425 (bsd_uthread_target::pid_to_str): Change return type.
12426 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12427 type.
12428 (bsd_kvm_target::pid_to_str): Change return type.
12429 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12430 return type.
12431 (aix_thread_target::pid_to_str): Change return type.
12432 * target.h (struct target_ops) <pid_to_str>: Change return type.
12433 (target_pid_to_str, normal_pid_to_str): Likewise.
12434 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12435 type.
12436 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12437 type.
12438 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12439 return type.
12440 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12441 type.
12442 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12443 type.
12444 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12445 return type.
12446
b4be1b06
SM
124472019-03-13 Simon Marchi <simon.marchi@ericsson.com>
12448
12449 * NEWS: Mention that the new default MI version is 3. Mention
12450 changes to the output of commands and events that deal with
12451 multi-location breakpoints.
12452 * breakpoint.c: Include "mi/mi-out.h".
12453 (print_one_breakpoint): Change output syntax if using MI version
12454 >= 3.
12455 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12456 New.
12457 (mi_multi_location_breakpoint_output_fixed): New.
12458 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12459 (mi_cmd_fix_multi_location_breakpoint_output): New.
12460 (mi_multi_location_breakpoint_output_fixed): New.
12461 * mi/mi-cmds.c (mi_cmds): Register command
12462 -fix-multi-location-breakpoint-output.
12463 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12464 interpreter "mi".
12465
8e5e5494
SM
124662019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
12467
12468 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12469 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12470 instantiate mi_ui_out based on interpreter name.
12471 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12472 * mi/mi-main.c (mi_load_progress): Likewise.
12473
197df35e
JB
124742019-03-12 John Baldwin <jhb@FreeBSD.org>
12475
12476 * NEWS: Combine separate "New targets" sections for 8.3.
12477
8399425f
JB
124782019-03-12 John Baldwin <jhb@FreeBSD.org>
12479
12480 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12481 (ppcfbsd_init_abi): Install gdbarch
12482 "fetch_tls_load_module_address" and "get_thread_local_address"
12483 methods.
12484
b0f87ed0
JB
124852019-03-12 John Baldwin <jhb@FreeBSD.org>
12486
12487 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12488 (riscv_fbsd_init_abi): Install gdbarch
12489 "fetch_tls_load_module_address" and "get_thread_local_address"
12490 methods.
12491
ce25aa57
JB
124922019-03-12 John Baldwin <jhb@FreeBSD.org>
12493
12494 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12495 (i386fbsd_init_abi): Install gdbarch
12496 "fetch_tls_load_module_address" and "get_thread_local_address"
12497 methods.
12498
f5424cfa
JB
124992019-03-12 John Baldwin <jhb@FreeBSD.org>
12500
12501 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12502 (amd64fbsd_init_abi): Install gdbarch
12503 "fetch_tls_load_module_address" and "get_thread_local_address"
12504 methods.
12505
945f3901
JB
125062019-03-12 John Baldwin <jhb@FreeBSD.org>
12507
12508 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12509 (struct fbsd_pspace_data): New type.
12510 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12511 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12512 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12513 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12514 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12515
ef0bd204
JB
125162019-03-12 John Baldwin <jhb@FreeBSD.org>
12517
12518 * gdbtypes.c (lookup_struct_elt): New function.
12519 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12520 * gdbtypes.h (struct struct_elt): New type.
12521 (lookup_struct_elt): New prototype.
12522
36c53a02
JB
125232019-03-12 John Baldwin <jhb@FreeBSD.org>
12524
12525 * gdbtypes.c (lookup_struct_elt_type): Update comment and
12526 remove disabled code block.
12527
6e056c81
JB
125282019-03-12 John Baldwin <jhb@FreeBSD.org>
12529
12530 * gdbarch.sh (get_thread_local_address): New method.
12531 * gdbarch.h, gdbarch.c: Regenerate.
12532 * target.c (target_translate_tls_address): Use
12533 gdbarch_get_thread_local_address if present instead of
12534 target::get_thread_local_address.
12535
cd250a18
JB
125362019-03-12 John Baldwin <jhb@FreeBSD.org>
12537
12538 * target.h (target::get_thread_local_address): Update comment.
12539
df22c1e5
JB
125402019-03-12 John Baldwin <jhb@FreeBSD.org>
12541
12542 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12543 objfile->separate_debug_objfile_backlink if not NULL.
12544
dd6876c9
JB
125452019-03-12 John Baldwin <jhb@FreeBSD.org>
12546
12547 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12548 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12549 (amd64bsd_store_inferior_registers): Likewise.
12550 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12551 Enable segment base registers.
12552 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12553 PT_GETFSBASE and PT_GETGSBASE.
12554 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12555 PT_SETGSBASE.
12556 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12557 segment base registers.
12558 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12559
1163a4b7
JB
125602019-03-12 John Baldwin <jhb@FreeBSD.org>
12561
12562 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12563 Update calls to i386_target_description to add 'segments'
12564 parameter.
12565 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
12566 add segment base registers.
12567 * arch/i386.c (i386_create_target_description): Add 'segments'
12568 parameter to enable segment base registers.
12569 * arch/i386.h (i386_create_target_description): Likewise.
12570 * features/i386/32bit-segments.xml: New file.
12571 * features/i386/32bit-segments.c: Generate.
12572 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12573 call to i386_target_description to add 'segments' parameter.
12574 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12575 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12576 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12577 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12578 if feature is present.
12579 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12580 Add 'segments' parameter to call to i386_target_description.
12581 (i386_target_description): Add 'segments' parameter to enable
12582 segment base registers.
12583 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12584 to call to i386_target_description.
12585 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12586 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12587 Define I386_NUM_REGS.
12588 (i386_target_description): Add 'segments' parameter to enable
12589 segment base registers.
12590
3a350822
EZ
125912019-03-12 Eli Zaretskii <eliz@gnu.org>
12592
12593 PR/24325
12594 * source-cache.c: #undef open and close, to avoid unresolved
12595 externals during linking.
12596
ffdd69cf
TT
125972019-03-12 Tom Tromey <tromey@adacore.com>
12598
12599 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12600 const. Add initializers.
12601 (_initialize_remote): Don't initialize ptid globals.
12602
ec148c57
PA
126032019-03-12 Pedro Alves <palves@redhat.com>
12604
12605 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12606
32764270
PA
126072019-03-12 Pedro Alves <palves@redhat.com>
12608
12609 * cp-name-parser.y (main): Remove unused 'len' variable.
12610
17547186
TT
126112019-03-12 Tom Tromey <tromey@adacore.com>
12612
12613 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12614 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12615
d3a70e03
TT
126162019-03-12 Tom Tromey <tromey@adacore.com>
12617
12618 * linux-nat.c (iterate_over_lwps): Update.
12619 (stop_callback): Remove parameter.
12620 (stop_wait_callback, detach_callback, resume_set_callback)
12621 (select_singlestep_lwp_callback, set_ignore_sigint)
12622 (status_callback, resumed_callback, resume_clear_callback)
12623 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12624 data parameter.
12625 (linux_nat_target::detach, linux_nat_target::resume)
12626 (linux_stop_and_wait_all_lwps, select_event_lwp)
12627 (linux_nat_filter_event, linux_nat_wait_1)
12628 (linux_nat_target::kill, linux_nat_target::stop)
12629 (linux_nat_target::stop): Update.
12630 (linux_nat_resume_callback): Change type.
12631 (resume_stopped_resumed_lwps, count_events_callback)
12632 (select_event_lwp_callback): Likewise.
12633 (linux_stop_lwp, linux_nat_stop_lwp): Update.
12634 * arm-linux-nat.c (struct update_registers_data): Remove.
12635 (update_registers_callback): Change type.
12636 (arm_linux_insert_hw_breakpoint1): Update.
12637 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12638 parameter.
12639 (x86_linux_dr_set_addr): Update.
12640 (x86_linux_dr_set_control): Update.
12641 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12642 (iterate_over_lwps): Use gdb::function_view.
12643 * nat/aarch64-linux-hw-point.c (struct
12644 aarch64_dr_update_callback_param): Remove.
12645 (debug_reg_change_callback): Change type.
12646 (aarch64_notify_debug_reg_change): Update.
12647 * s390-linux-nat.c (s390_refresh_per_info): Update.
12648
82cb27ff
TT
126492019-03-11 Tom Tromey <tromey@adacore.com>
12650
12651 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12652 redundant assignment to "this_cu".
12653
568c0683
SM
126542019-03-08 Simon Marchi <simon.marchi@efficios.com>
12655
12656 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12657
f09ce22d
SM
126582019-03-08 Simon Marchi <simon.marchi@efficios.com>
12659
12660 * gdbtypes.c (rank_one_type_parm_set): New function extracted
12661 from...
12662 (rank_one_type): ... this.
12663
595f96a9
SM
126642019-03-08 Simon Marchi <simon.marchi@efficios.com>
12665
12666 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12667 from...
12668 (rank_one_type): ... this.
12669
2598a94b
SM
126702019-03-08 Simon Marchi <simon.marchi@efficios.com>
12671
12672 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12673 from...
12674 (rank_one_type): ... this.
12675
7f17b20d
SM
126762019-03-08 Simon Marchi <simon.marchi@efficios.com>
12677
12678 * gdbtypes.c (rank_one_type_parm_float): New function extracted
12679 from...
12680 (rank_one_type): ... this.
12681
2c509035
SM
126822019-03-08 Simon Marchi <simon.marchi@efficios.com>
12683
12684 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12685 from...
12686 (rank_one_type): ... this.
12687
0dd322dc
SM
126882019-03-08 Simon Marchi <simon.marchi@efficios.com>
12689
12690 * gdbtypes.c (rank_one_type_parm_range): New function extracted
12691 from...
12692 (rank_one_type): ... this.
12693
41ea4728
SM
126942019-03-08 Simon Marchi <simon.marchi@efficios.com>
12695
12696 * gdbtypes.c (rank_one_type_parm_char): New function extracted
12697 from...
12698 (rank_one_type): ... this.
12699
793cd1d2
SM
127002019-03-08 Simon Marchi <simon.marchi@efficios.com>
12701
12702 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12703 from...
12704 (rank_one_type): ... this.
12705
34910087
SM
127062019-03-08 Simon Marchi <simon.marchi@efficios.com>
12707
12708 * gdbtypes.c (rank_one_type_parm_int): New function extracted
12709 from...
12710 (rank_one_type): ... this.
12711
f1f832d6
SM
127122019-03-08 Simon Marchi <simon.marchi@efficios.com>
12713
12714 * gdbtypes.c (rank_one_type_parm_func): New function extracted
12715 from...
12716 (rank_one_type): ... this.
12717
b9f4512f
SM
127182019-03-08 Simon Marchi <simon.marchi@efficios.com>
12719
12720 * gdbtypes.c (rank_one_type_parm_array): New function extracted
12721 from...
12722 (rank_one_type): ... this.
12723
9293fc63
SM
127242019-03-08 Simon Marchi <simon.marchi@efficios.com>
12725
12726 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12727 from...
12728 (rank_one_type): ... this.
12729
e3abbe7e
PW
127302019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12731
12732 * inferior.c (initialize_inferiors): Ensure 'help set/show print
12733 inferior-events' shows the example events.
12734
e4adb939
EZ
127352019-03-08 Eli Zaretskii <eliz@gnu.org>
12736
12737 Support styling on native MS-Windows console
12738
12739 PR/24315
12740 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12741 on MS-Windows if $TERM is not defined.
12742
12743 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12744
12745 * posix-hdep.c (gdb_console_fputs):
12746 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12747 functions.
12748 * ui-file.h (gdb_console_fputs): Add prototype.
12749
12750 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12751 back to fputs only if the former returns zero.
12752
25629dfd
TT
127532019-03-07 Tom Tromey <tom@tromey.com>
12754
12755 * symmisc.c (print_symbol_bcache_statistics): Update.
12756 (print_objfile_statistics): Update.
12757 * symfile.c (allocate_symtab): Update.
12758 * stabsread.c: Don't include bcache.h.
12759 * psymtab.h (struct psymbol_bcache): Don't declare.
12760 (class psymtab_storage) <psymbol_cache>: Now a bcache.
12761 (psymbol_bcache_init, psymbol_bcache_free)
12762 (psymbol_bcache_get_bcache): Don't declare.
12763 * psymtab.c (struct psymbol_bcache): Remove.
12764 (psymtab_storage::psymtab_storage): Update.
12765 (psymtab_storage::~psymtab_storage): Update.
12766 (psymbol_bcache_init, psymbol_bcache_free)
12767 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12768 (add_psymbol_to_bcache): Update.
12769 (allocate_psymtab): Update.
12770 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12771 macro_cache>: No longer pointers.
12772 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12773 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12774 * macrotab.c (macro_bcache): Update.
12775 * macroexp.c: Don't include bcache.h.
12776 * gdbtypes.c (check_types_worklist): Update.
12777 (types_deeply_equal): Remove TRY/CATCH. Update.
12778 * elfread.c (elf_symtab_read): Update.
12779 * dwarf2read.c: Don't include bcache.h.
12780 * buildsym.c (buildsym_compunit::get_macro_table): Update.
12781 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12782 (print_bcache_statistics, bcache_memory_used): Don't declare.
12783 (struct bcache): Move from bcache.c. Add constructor, destructor,
12784 methods. Rename all data members.
12785 * bcache.c (struct bcache): Move to bcache.h.
12786 (bcache::expand_hash_table): Rename from expand_hash_table.
12787 (bcache): Remove.
12788 (bcache::insert): Rename from bcache_full.
12789 (bcache::compare): Rename from bcache_compare.
12790 (bcache_xmalloc): Remove.
12791 (bcache::~bcache): Rename from bcache_xfree.
12792 (bcache::print_statistics): Rename from print_bcache_statistics.
12793 (bcache::memory_used): Rename from bcache_memory_used.
12794
fe726667
PA
127952019-03-07 Pedro Alves <palves@redhat.com>
12796
12797 * infrun.c (normal_stop): Also check for
12798 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12799
7584bb30
AB
128002019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
12801
12802 * f-lang.c (value_from_host_double): Moved to...
12803 * value.c (value_from_host_double): ...here.
12804 * value.h (value_from_host_double): Declare.
12805 * guile/scm-math.c (vlscm_convert_typed_number): Use
12806 value_from_host_double.
12807 (vlscm_convert_number): Likewise.
12808 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12809 * python/py-value.c (convert_value_from_python): Likewise.
12810
a7b1986e
TT
128112019-03-06 Tom Tromey <tom@tromey.com>
12812
12813 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12814
0ccf4211
TT
128152019-03-06 Tom Tromey <tom@tromey.com>
12816
12817 * utils.h (free_current_contents): Don't declare.
12818 * utils.c (free_current_contents): Remove.
12819
fe7b42e5
TT
128202019-03-06 Tom Tromey <tom@tromey.com>
12821
12822 * top.c (quit_force): Update.
12823 * main.c (captured_command_loop): Update.
12824 * common/new-op.c (operator new): Update.
12825 * common/common-exceptions.c (struct catcher)
12826 <save_cleanup_chain>: Remove member.
12827 (exceptions_state_mc_init): Update.
12828 (exception_try_scope_entry): Return nullptr.
12829 (exception_try_scope_exit, exception_rethrow)
12830 (throw_exception_sjlj, throw_exception_cxx): Update.
12831 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12832 (all_cleanups, do_cleanups, discard_cleanups)
12833 (discard_final_cleanups, save_cleanups, save_final_cleanups)
12834 (restore_cleanups, restore_final_cleanups): Don't declare.
12835 (do_final_cleanups): Remove parameter.
12836 * common/cleanups.c (cleanup_chain, make_cleanup)
12837 (make_cleanup_dtor, all_cleanups, do_cleanups)
12838 (discard_my_cleanups, discard_cleanups)
12839 (discard_final_cleanups, save_my_cleanups, save_cleanups)
12840 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12841 (null_cleanup): Remove.
12842 (do_final_cleanups): Remove parameter.
12843
c6321f19
TT
128442019-03-06 Tom Tromey <tom@tromey.com>
12845
12846 * remote.c (remote_target::remote_parse_stop_reply): Use
12847 unique_xmalloc_ptr.
12848
61b30099
TT
128492019-03-06 Tom Tromey <tom@tromey.com>
12850
12851 * stabsread.c (struct stabs_field_info): Rename from field_info.
12852 <list, fnlist>: Add initializers.
12853 <obstack>: New member.
12854 (read_member_functions, read_struct_fields, read_baseclasses):
12855 Allocate on obstack. Don't use cleanups.
12856 (read_one_struct_field, read_member_functions, read_struct_fields)
12857 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12858 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12859 (read_struct_type): Update.
12860
6cceac94
TT
128612019-03-06 Tom Tromey <tom@tromey.com>
12862
12863 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12864 * common/filestuff.h (make_cleanup_close): Don't declare.
12865 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12866 Remove.
12867
72412762
TT
128682019-03-06 Tom Tromey <tom@tromey.com>
12869
12870 * solib-aix.c: Use make_scope_exit.
12871
2b6ff1c0
TT
128722019-03-06 Tom Tromey <tom@tromey.com>
12873
12874 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12875 Use make_scope_exit.
12876
d01c5877
TT
128772019-03-06 Tom Tromey <tom@tromey.com>
12878
12879 * solib-svr4.c (disable_probes_interface): Remove parameter.
12880 (svr4_handle_solib_event): Use make_scope_exit.
12881
32603266
TT
128822019-03-06 Tom Tromey <tom@tromey.com>
12883
12884 * remote.c (struct stop_reply_deleter): Remove.
12885 (stop_reply_up): Update.
12886 (struct stop_reply): Derive from notif_event. Don't typedef.
12887 <regcache>: Now a std::vector.
12888 (stop_reply_xfree): Remove.
12889 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12890 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
12891 (remote_target::discard_pending_stop_replies): Use delete.
12892 (remote_target::remote_parse_stop_reply): Update.
12893 (remote_target::process_stop_reply): Update.
12894 * remote-notif.h (struct notif_event): Add virtual destructor.
12895 Remove "dtr" member.
12896 (struct notif_client) <alloc_event>: Return a unique_ptr.
12897 (notif_event_xfree): Don't declare.
12898 (notif_event_up): New typedef.
12899 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12900 (notif_event_xfree, do_notif_event_xfree): Remove.
12901 (remote_notif_state_xfree): Update.
12902
9799571e
TT
129032019-03-06 Tom Tromey <tom@tromey.com>
12904
12905 * infrun.c (displaced_step_clear_cleanup): Now a
12906 forward_scope_exit type.
12907 (displaced_step_prepare_throw): Update.
12908 (displaced_step_fixup): Update.
12909
09e3c4ca
TT
129102019-03-06 Tom Tromey <tom@tromey.com>
12911
12912 * inferior.h (class inferior): Update comment.
12913 * gdbthread.h (class thread_info): Update comment.
12914
e2a03548
TT
129152019-03-06 Joel Brobecker <brobecker@adacore.com>
12916 Tom Tromey <tom@tromey.com>
12917
12918 * stabsread.h (struct stab_section_list): Remove.
12919 (coffstab_build_psymtabs): Update.
12920 * dbxread.c (symbuf_sections): Now a std::vector.
12921 (sect_idx): New global.
12922 (fill_symbuf): Update.
12923 (coffstab_build_psymtabs): Change type of stabsects parameter.
12924 Update.
12925 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12926 std::vector.
12927 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12928 (coff_locate_sections): Update.
12929 (coff_symfile_read): Remove cleanups. Update.
12930 (init_stringtab): Add storage parameter.
12931 (free_stringtab, free_stringtab_cleanup): Remove.
12932 (init_lineno): Add storage parameter.
12933 (free_linetab, free_linetab_cleanup): Remove.
12934
b7e60d85
PA
129352019-03-06 Pedro Alves <palves@redhat.com>
12936
12937 * linux-fork.c (fork_info::clobber_regs): Delete.
12938 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12939 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
12940 comment. Adjust.
12941 (scoped_switch_fork_info::scoped_switch_fork_info)
12942 (checkpoint_command, linux_fork_context): Adjust
12943 fork_save_infrun_state calls.
12944
e52c971f
PA
129452019-03-06 Pedro Alves <palves@redhat.com>
12946
12947 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12948 (inf_has_multiple_threads): Return 'bool' and rewrite using
12949 inferior_info::threads().
12950
06974e6c
PA
129512019-03-06 Pedro Alves <palves@redhat.com>
12952
12953 * linux-fork.c: Include <list>.
12954 (fork_list): Now a std::list instance.
12955 (fork_info): Add ctor, dtor, and in-class initialize all fields.
12956 (forks_exist_p, find_last_fork): Adjust.
12957 (new_fork): Delete.
12958 (one_fork_p): New.
12959 (add_fork): Adjust.
12960 (free_fork): Delete, folded into fork_info::~fork_info().
12961 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12962 Adjust.
12963 (init_fork_list): Delete.
12964 (linux_fork_killall, linux_fork_mourn_inferior)
12965 (linux_fork_detach, info_checkpoints_command): Adjust.
12966 (_initialize_linux_fork): No longer call init_fork_list.
12967
72f31aea
PA
129682019-03-06 Pedro Alves <palves@redhat.com>
12969
12970 * linux-fork.c (new_fork): New, split out of ...
12971 (add_fork): ... this. Return void. Move "first fork" special
12972 case from here, to ...
12973 (checkpoint_command): ... here.
12974 * linux-linux.h (add_fork): Return void.
12975
efbecbc1
AB
129762019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12977
12978 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12979
0841c79a
AB
129802019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12981 Chris January <chris.january@arm.com>
12982 David Lecomber <david.lecomber@arm.com>
12983
12984 * f-exp.y: New token, UNOP_INTRINSIC.
12985 (exp): New pattern using UNOP_INTRINSIC token.
12986 (f77_keywords): Add 'abs' keyword.
12987 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12988 (value_from_host_double): New function.
12989 (evaluate_subexp_f): Support UNOP_ABS.
12990
4a270568
AB
129912019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12992
12993 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12994 types.
12995
067630bd
AB
129962019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12997
12998 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12999 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13000 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13001
3be47f7a
AB
130022019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13003
13004 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13005
4d00f5d8
AB
130062019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13007 Chris January <chris.january@arm.com>
13008
13009 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13010 * f-exp.y: Define 'KIND' token.
13011 (exp): New pattern for KIND expressions.
13012 (ptype): Handle types with a kind extension.
13013 (direct_abs_decl): Extend to spot kind extensions.
13014 (f77_keywords): Add 'kind' to the list.
13015 (push_kind_type): New function.
13016 (convert_to_kind_type): New function.
13017 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13018 * parse.c (operator_length_standard): Likewise.
13019 * parser-defs.h (enum type_pieces): Add tp_kind.
13020 * std-operator.def: Add UNOP_KIND.
13021
e454224f
AB
130222019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13023
13024 * f-exp.y (f_parse): Set yydebug.
13025
9dad4a58
AB
130262019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13027
13028 * f-lang.c (evaluate_subexp_f): New function.
13029 (exp_descriptor_f): New global.
13030 (f_language_defn): Use exp_descriptor_f instead of
13031 exp_descriptor_standard.
13032
c8f91604
AB
130332019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13034
13035 * f-exp.y (struct token): Add comments.
13036 (dot_ops): Remove uppercase versions and the end marker.
13037 (f77_keywords): Likewise.
13038 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13039 entries in the dot_ops array are case insensitive, and use
13040 strncasecmp to compare strings. Also some whitespace cleanup in
13041 this area. Similar for the f77_keywords array, except entries in
13042 this list might be case sensitive.
13043
dd9f2c76
AB
130442019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13045
13046 * f-exp.y (struct f77_boolean_val): Add comments.
13047 (boolean_values): Remove uppercase versions, and end marker.
13048 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13049 and use strncasecmp to achieve case insensitivity. Additionally,
13050 perform whitespace cleanup around this code.
13051
67a3048c
TT
130522019-03-06 Tom Tromey <tromey@adacore.com>
13053
13054 * remote-sim.c (gdbsim_target_open): Use result of
13055 gdb_argv::release.
13056
aa3cfbda
RB
130572019-03-06 Richard Bunt <richard.bunt@arm.com>
13058 Dirk Schubert <dirk.schubert@arm.com>
13059 Chris January <chris.january@arm.com>
13060
13061 * eval.c (evaluate_subexp_standard): Call Fortran argument
13062 wrapping logic.
13063 * f-lang.c (struct value): A value which can be passed into a
13064 Fortran function call.
13065 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13066 where appropriate.
13067 (struct type): Value ready for a Fortran function call.
13068 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13069 is needed.
13070 * f-lang.h (fortran_argument_convert): Declaration.
13071 (fortran_preserve_arg_pointer): Declaration.
13072 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13073
ea38e5df
TT
130742019-03-05 Tom Tromey <tromey@adacore.com>
13075
13076 * python/py-prettyprint.c (print_string_repr): Remove #if.
13077 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13078
06b5b831
TT
130792019-03-05 Tom Tromey <tromey@adacore.com>
13080
13081 * target.c (the_dummy_target): Move later. Change type to
13082 "dummy_target".
13083 (initialize_targets): Don't initialize the_dummy_target.
13084
edbd9e45
TT
130852019-03-05 Tom Tromey <tromey@adacore.com>
13086
13087 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13088 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13089
c119e040
TT
130902019-03-05 Tom Tromey <tromey@adacore.com>
13091
13092 * windows-nat.c (windows_nat_target::attach)
13093 (windows_nat_target::detach): Don't call gdb_flush.
13094 * valprint.c (generic_val_print, val_print, val_print_string):
13095 Don't call gdb_flush.
13096 * utils.c (defaulted_query): Don't call gdb_flush.
13097 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13098 * target.c (target_announce_detach): Don't call gdb_flush.
13099 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13100 * remote.c (extended_remote_target::attach): Don't call
13101 gdb_flush.
13102 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13103 * printcmd.c (do_examine): Don't call gdb_flush.
13104 (info_display_command): Don't call gdb_flush.
13105 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13106 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13107 * memattr.c (info_mem_command): Don't call gdb_flush.
13108 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13109 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13110 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13111 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13112 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13113 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13114 (gnu_nat_target::detach): Don't call gdb_flush.
13115 * f-valprint.c (f_val_print): Don't call gdb_flush.
13116 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13117 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13118 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13119 gdb_flush.
13120 * c-valprint.c (c_val_print): Don't call gdb_flush.
13121 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13122
895dafa6
TT
131232019-03-05 Tom Tromey <tromey@adacore.com>
13124
13125 * varobj.c (update_dynamic_varobj_children): Update.
13126 (install_default_visualizer): Use reset, not release.
13127 * value.c (set_internalvar): Update.
13128 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13129 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13130 ATTRIBUTE_UNUSED_RESULT.
13131
88a774b9
TT
131322019-03-05 Tom Tromey <tromey@adacore.com>
13133
13134 * remote.c (class scoped_remote_fd) <release>: Add
13135 ATTRIBUTE_UNUSED_RESULT.
13136
4e4a8b93
TT
131372019-03-05 Tom Tromey <tromey@adacore.com>
13138
13139 * macroexp.c (struct macro_buffer) <release>: Add
13140 ATTRIBUTE_UNUSED_RESULT.
13141
083eef1f
TT
131422019-03-05 Tom Tromey <tromey@adacore.com>
13143
13144 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13145 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13146 ATTRIBUTE_UNUSED_RESULT.
13147
3cabd438
TT
131482019-03-05 Tom Tromey <tromey@adacore.com>
13149
13150 * common/scoped_fd.h (class scoped_fd) <release>: Add
13151 ATTRIBUTE_UNUSED_RESULT.
13152
41e3300a
TT
131532019-03-05 Tom Tromey <tromey@adacore.com>
13154
13155 * parser-defs.h (struct parser_state) <release>: Add
13156 ATTRIBUTE_UNUSED_RESULT.
13157
18cb7c9f
TT
131582019-03-05 Tom Tromey <tromey@adacore.com>
13159
13160 * utils.h (class gdb_argv) <release>: Add
13161 ATTRIBUTE_UNUSED_RESULT.
13162 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13163
41fa577f
EZ
131642019-03-02 Eli Zaretskii <eliz@gnu.org>
13165
a6a4b2c6
EZ
13166 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13167 for-loop range, to avoid compiler warnings.
13168
13169 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13170 avoid compiler warnings about unused variables.
13171
742a7df5
EZ
13172 * NEWS: Mention end of support for native debugging on MS-Windows
13173 before XP.
13174
41fa577f
EZ
13175 PR gdb/24292
13176 * common/netstuff.c:
13177 * gdbserver/gdbreplay.c
13178 * gdbserver/remote-utils.c:
13179 * ser-tcp.c:
13180 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13181 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13182 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13183 'getaddrinfo' and 'freeaddrinfo' were not available before
13184 Windows XP, and mingw.org's MinGW headers by default define
13185 _WIN32_WINNT to 0x500.
13186
827f438f
GB
131872019-03-01 Gary Benson <gbenson@redhat.com>
13188
13189 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13190
92137da0
RO
131912019-02-28 Brian Vandenberg <phantall@gmail.com>
13192 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13193
13194 PR gdb/8527
13195 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13196 set_sigint_trap, clear_sigint_trap.
13197
799efbe8
PW
131982019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13199
13200 * target.c (target_detach): Clear the regcache and the
13201 frame cache.
13202
8ed25214
PA
132032019-02-27 Pedro Alves <palves@redhat.com>
13204
13205 * utils.c (set_screen_size): When we cap the height/width sizes,
13206 tweak the corresponding command variable to show "unlimited":
13207
23031e31
SJ
132082019-02-27 Saagar Jha <saagar@saagarjha.com>
13209 Pedro Alves <palves@redhat.com>
13210
13211 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13212 before calling rl_set_screen_size.
13213
6c28e44a
TT
132142019-02-27 Tom Tromey <tromey@adacore.com>
13215
13216 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13217 define.
13218 * python/py-value.c: Remove Python 2.4 workaround.
13219 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13220 workaround.
13221 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13222 Python 2.4 workaround.
13223 * python/python-internal.h: Remove Python 2.4 comment.
13224 (Py_ssize_t): Don't define.
13225 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13226 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13227 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13228 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13229 * python/python.c (do_start_initialization): Remove Python 2.4
13230 workaround.
13231 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13232 (print_children): Remove Python 2.4 workaround.
13233 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13234 workaround.
13235 (CHARBUFFERPROC_NAME): Remove.
13236 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13237 Python 2.4 workaround.
13238
2c3fc25d 132392019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 13240
2c3fc25d
KB
13241 * NEWS: Note minimum Python version.
13242
6ca62222
KB
132432019-02-27 Kevin Buettner <kevinb@redhat.com>
13244
13245 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13246 code from these functions. Remove corresponding ifdefs. Use
13247 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13248 Remove gotos and target of gotos.
13249 (infpy_search_memory): Likewise.
13250
f4bc7d2c
AB
132512019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13252
13253 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13254 (hppa_gdbarch_init): Don't register deleted functions with
13255 gdbarch.
13256
9734a586
AB
132572019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13258
13259 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13260 (h8300_unwind_sp): Delete.
13261 (h8300_dummy_id): Delete.
13262 (h8300_gdbarch_init): Don't register deleted functions with
13263 gdbarch.
13264
68b867f3
AB
132652019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13266
13267 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13268 (ft32_unwind_pc): Delete.
13269 (ft32_unwind_sp): Delete.
13270 (ft32_gdbarch_init): Don't register deleted functions with
13271 gdbarch.
13272
2fbe7ad0
AB
132732019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13274
13275 * gdb/frv-tdep.c (frv_dummy_id): Delete.
13276 (frv_unwind_pc): Delete.
13277 (frv_unwind_sp): Delete.
13278 (frv_gdbarch_init): Don't register deleted functions with
13279 gdbarch.
13280
76055cbe
AB
132812019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13282
13283 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13284 (riscv_unwind_pc): Delete.
13285 (riscv_unwind_sp): Delete.
13286 (riscv_gdbarch_init): Don't register deleted functions with
13287 gdbarch.
13288
4133e5a1
AB
132892019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13290
13291 * gdb/csky-tdep.c (csky_dummy_id): Delete.
13292 (csky_unwind_pc): Delete.
13293 (csky_unwind_sp): Delete.
13294 (csky_gdbarch_init): Don't register deleted functions with
13295 gdbarch.
13296
8010f576
AB
132972019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13298
13299 * gdb/cris-tdep.c (cris_dummy_id): Delete.
13300 (cris_unwind_pc): Delete.
13301 (cris_unwind_sp): Delete.
13302 (cris_gdbarch_init): Don't register deleted functions with
13303 gdbarch.
13304
b56bf084
AB
133052019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13306
13307 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13308 (bfin_unwind_pc): Delete.
13309 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13310
a19a650f
AB
133112019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13312
13313 * gdb/arm-tdep.c (arm_dummy_id): Delete.
13314 (arm_unwind_pc): Delete.
13315 (arm_unwind_sp): Delete.
13316 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13317
f8278c3c
AB
133182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13319
13320 * gdb/arc-tdep.c (arc_dummy_id): Delete.
13321 (arc_unwind_pc): Delete.
13322 (arc_unwind_sp): Delete.
13323 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13324
480e46cf
AB
133252019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13326
13327 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13328 (alpha_unwind_pc): Delete.
13329 (alpha_gdbarch_init): Don't register deleted functions with
13330 gdbarch.
13331
7a995095
AB
133322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13333
13334 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13335 (aarch64_unwind_pc): Delete.
13336 (aarch64_unwind_sp): Delete.
13337 (aarch64_gdbarch_init): Don't register deleted functions with
13338 gdbarch.
13339
bf9a735e
AB
133402019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13341
13342 * gdbtypes.c (type_align): Don't consider static members when
13343 computing structure alignment.
13344
5561fc30
AB
133452019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13346
13347 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13348 return 0 for other types.
13349 * arch-utils.c (default_type_align): Always return 0.
13350 * gdbarch.h: Regenerate.
13351 * gdbarch.sh (type_align): Extend comment.
13352 * gdbtypes.c (type_align): Add additional comments, always call
13353 gdbarch_type_align before applying the default rules.
13354 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13355 generic code will then apply a suitable default.
13356 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13357 types, return 0 for other types.
13358
9335e75a
JB
133592019-02-27 Joel Brobecker <brobecker@adacore.com>
13360
13361 * NEWS: Create a new section for the next release branch.
13362 Rename the section of the current branch, now that it has
13363 been cut.
13364
3d34d8de
JB
133652019-02-27 Joel Brobecker <brobecker@adacore.com>
13366
13367 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13368 * version.in: Bump version to 8.3.50.DATE-git.
13369
143420fb
SM
133702019-02-26 Simon Marchi <simon.marchi@efficios.com>
13371
13372 * aix-thread.c (ptid_cmp): Remove unused variable.
13373 (get_signaled_thread): Likewise.
13374 (store_regs_user_thread): Likewise.
13375 (store_regs_kernel_thread): Likewise.
13376 (fetch_regs_kernel_thread): Remove shadowed variable.
13377
172fb711
AB
133782019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
13379
13380 * features/riscv/32bit-cpu.xml: Add register numbers.
13381 * features/riscv/32bit-fpu.c: Regenerate.
13382 * features/riscv/32bit-fpu.xml: Add register numbers.
13383 * features/riscv/64bit-cpu.xml: Add register numbers.
13384 * features/riscv/64bit-fpu.c: Regenerate.
13385 * features/riscv/64bit-fpu.xml: Add register numbers.
13386
26c89782
KB
133872019-02-26 Kevin Buettner <kevinb@redhat.com>
13388
af54ade9 13389 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
13390 * python/py-value.c (convert_buffer_and_type_to_value): New
13391 function.
13392 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13393 Add support for handling an optional second argument. Call
13394 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
13395 * python/python-internal.h (Py_buffer_deleter): New struct.
13396 (Py_buffer_up): New typedef.
13397
0f58c9e8
JB
133982019-02-25 John Baldwin <jhb@FreeBSD.org>
13399
13400 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13401 instead of releasing ownership.
13402
0a0f4c01
JR
134032019-02-25 Jordan Rupprecht <rupprecht@google.com>
13404
13405 * dwarf2read.c (open_and_init_dwp_file): Call
13406 elf_numsections instead of bfd_count_sections to initialize
13407 dwp_file->num_sections.
13408
cd5a152c
TT
134092019-02-25 Tom Tromey <tromey@adacore.com>
13410
13411 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13412
8a6a8513
SDJ
134132019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
13414
13415 * gcore.in: Add '--readnever' option when invoking GDB.
13416
04dcda9c
SM
134172019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
13418
13419 * MAINTAINERS: Update my email address.
13420
07bc701d
SM
134212019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
13422
13423 * build-id.c (build_id_to_debug_bfd_1): New function.
13424 (build_id_to_debug_bfd): Look for separate debug file in
13425 sysroot.
13426
c6f4a5d0
AB
134272019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
13428
13429 * gdbarch.sh: Update the copyright year range that is placed into
13430 generated files.
13431
9600246d
KS
134322019-02-22 Keith Seitz <keiths@redhat.com>
13433
13434 PR symtab/23853
13435 * linespec.c (create_sals_line_offset): Search for the default
13436 symtab's filename instead of its fullname.
13437
7557a514
AH
134382019-02-21 Alan Hayward <alan.hayward@arm.com>
13439
13440 * NEWS: Update style defaults.
13441
ee2bcb0c
AH
134422019-02-21 Alan Hayward <alan.hayward@arm.com>
13443
13444 * main.c (captured_main_1): Disable styling in batch mode.
13445
0c95f9ed
TT
134462019-02-20 Tom Tromey <tom@tromey.com>
13447
13448 * symtab.c (symtab_symbol_info): Fix typos.
13449
c763b894
TT
134502019-02-20 Tom Tromey <tromey@adacore.com>
13451
13452 * findcmd.c (_initialize_mem_search): Use upper case for
13453 metasyntactic variables.
13454
0ef8a082
AH
134552019-02-20 Alan Hayward <alan.hayward@arm.com>
13456
13457 * aarch64-tdep.c (aarch64_add_reggroups): New function.
13458 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13459
6caa91b6
SM
134602019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
13461
13462 * top.h (source_file_name): Change to std::string.
13463 * top.c (source_file_name): Likewise.
13464 (command_line_input): Adjust.
13465 * cli/cli-script.c (script_from_file): Adjust.
13466
98814c6c
TT
134672019-02-19 Tom Tromey <tromey@adacore.com>
13468
13469 * ravenscar-thread.c
13470 (ravenscar_thread_target::update_thread_list): Don't call
13471 ada_build_task_list.
13472 * ada-lang.h (ada_build_task_list): Don't declare.
13473 * ada-tasks.c (struct ada_tasks_inferior_data)
13474 <task_list_valid_p>: Now bool.
13475 (read_known_tasks, ada_task_list_changed)
13476 (ada_tasks_invalidate_inferior_data): Update.
13477 (read_known_tasks_array): Return bool.
13478 (read_known_tasks_list): Likewise.
13479 (read_known_tasks): Return void.
13480 (ada_build_task_list): Now static.
13481
70cd633e
AB
134822019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
13483
13484 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13485 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13486
040b3e95
PW
134872019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13488
13489 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13490 variant for ada_tasks_pspace_data_handle and
13491 ada_tasks_inferior_data_handle.
13492 (ada_tasks_pspace_data_cleanup): New function.
13493 (ada_tasks_inferior_data_cleanup): New function.
13494
9409233b
TT
134952019-02-17 Tom Tromey <tom@tromey.com>
13496
13497 * macrotab.h (macro_source_fullname): Return a std::string.
13498 * macrotab.c (macro_include, check_for_redefinition)
13499 (macro_undef, macro_lookup_definition, foreach_macro)
13500 (foreach_macro_in_scope): Update.
13501 (macro_source_fullname): Return a std::string.
13502 * macrocmd.c (show_pp_source_pos): Update.
13503
6506371f
TT
135042019-02-17 Tom Tromey <tom@tromey.com>
13505
13506 * macrocmd.c (show_pp_source_pos): Style the file names.
13507
0c820d67
TT
135082019-02-17 Tom Tromey <tom@tromey.com>
13509
13510 PR tui/24197:
13511 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13512
a0087920
TT
135132019-02-17 Tom Tromey <tom@tromey.com>
13514
13515 * ada-lang.c (user_select_syms): Use filtered printing.
13516 * utils.c (wrap_style): New global.
13517 (desired_style): Remove.
13518 (emit_style_escape): Add stream parameter.
13519 (set_output_style, reset_terminal_style, prompt_for_continue):
13520 Update.
13521 (flush_wrap_buffer): Only flush gdb_stdout.
13522 (wrap_here): Set wrap_style.
13523 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
13524 treat escape sequences as a character. Change when wrap buffer is
13525 flushed.
13526 (fputs_styled): Do not set the output style when the default is
13527 requested.
13528 * ui-style.h (struct ui_file_style) <is_default>: New method.
13529 * source.c (print_source_lines_base): Emit escape sequences in one
13530 piece.
13531
75ba10dc
JB
135322019-02-17 Joel Brobecker <brobecker@adacore.com>
13533
13534 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13535 integers and enumeration types.
13536
a2cd4f14
JB
135372019-02-17 Joel Brobecker <brobecker@adacore.com>
13538
13539 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13540 instead of lookup_symbol_in_language
13541 (do_exact_match): New function.
13542 (ada_get_symbol_name_matcher): Return do_exact_match when
13543 doing a verbatim match.
13544
485b851b
TT
135452019-02-15 Tom Tromey <tromey@adacore.com>
13546
13547 * ravenscar-thread.c (ravenscar_thread_target::resume)
13548 (ravenscar_thread_target::wait): Special case wildcard requests.
13549
0b790b1e
TT
135502019-02-15 Tom Tromey <tromey@adacore.com>
13551
13552 * ravenscar-thread.c (base_ptid): Remove.
13553 (struct ravenscar_thread_target) <close>: New method.
13554 <m_base_ptid>: New member.
13555 <update_inferior_ptid, active_task, task_is_currently_active,
13556 runtime_initialized>: Declare methods.
13557 <ravenscar_thread_target>: Add constructor.
13558 (ravenscar_thread_target::task_is_currently_active)
13559 (ravenscar_thread_target::update_inferior_ptid)
13560 (ravenscar_runtime_initialized): Rename. Now methods.
13561 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13562 (ravenscar_thread_target::update_thread_list): Update.
13563 (ravenscar_thread_target::active_task): Now method.
13564 (ravenscar_thread_target::store_registers)
13565 (ravenscar_thread_target::prepare_to_store)
13566 (ravenscar_thread_target::prepare_to_store)
13567 (ravenscar_thread_target::mourn_inferior): Update.
13568 (ravenscar_inferior_created): Use "new" to create target.
13569 (ravenscar_thread_target::get_ada_task_ptid): Update.
13570 (_initialize_ravenscar): Don't initialize base_ptid.
13571 (ravenscar_ops): Remove global.
13572
dea57a62
TT
135732019-02-15 Tom Tromey <tromey@adacore.com>
13574
13575 * target.h (push_target): Declare new overload.
13576 * target.c (push_target): New overload, taking an rvalue reference.
13577 * remote.c (remote_target::open_1): Use push_target overload.
13578 * corelow.c (core_target_open): Use push_target overload.
13579
989f3c58
TT
135802019-02-15 Tom Tromey <tromey@adacore.com>
13581
13582 * ravenscar-thread.c (is_ravenscar_task)
13583 (ravenscar_task_is_currently_active): Return bool.
13584 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13585 (_initialize_ravenscar): Remove "(void)".
13586 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13587 Return bool.
13588
6cbcc006
TT
135892019-02-15 Tom Tromey <tromey@adacore.com>
13590
13591 * ravenscar-thread.c (ravenscar_runtime_initializer)
13592 (has_ravenscar_runtime, get_running_thread_id)
13593 (ravenscar_thread_target::resume): Fix indentation.
13594
7657f14d
TT
135952019-02-15 Tom Tromey <tromey@adacore.com>
13596
13597 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13598 from ravenscar_arch_ops.
13599 (sparc_ravenscar_ops::fetch_registers)
13600 (sparc_ravenscar_ops::store_registers): Now methods.
13601 (sparc_ravenscar_prepare_to_store): Remove.
13602 (sparc_ravenscar_ops): Redefine.
13603 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13604 methods and destructor. Remove members.
13605 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13606 (ravenscar_thread_target::store_registers)
13607 (ravenscar_thread_target::prepare_to_store): Update.
13608 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13609 Remove.
13610 (struct ppc_ravenscar_powerpc_ops): Derive from
13611 ravenscar_arch_ops.
13612 (ppc_ravenscar_powerpc_ops::fetch_registers)
13613 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13614 (ppc_ravenscar_powerpc_ops): Redefine.
13615 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13616 (ppc_ravenscar_e500_ops::fetch_registers)
13617 (ppc_ravenscar_e500_ops::store_registers): Now methods.
13618 (ppc_ravenscar_e500_ops): Redefine.
13619 * aarch64-ravenscar-thread.c
13620 (aarch64_ravenscar_generic_prepare_to_store): Remove.
13621 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13622 (aarch64_ravenscar_fetch_registers)
13623 (aarch64_ravenscar_store_registers): Now methods.
13624 (aarch64_ravenscar_ops): Redefine.
13625
5b6ea500
TT
136262019-02-15 Tom Tromey <tromey@adacore.com>
13627
13628 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13629 (ravenscar_thread_target::stopped_by_hw_breakpoint)
13630 (ravenscar_thread_target::stopped_by_watchpoint)
13631 (ravenscar_thread_target::stopped_data_address)
13632 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13633
e397fd39
TT
136342019-02-15 Tom Tromey <tromey@adacore.com>
13635
13636 * ravenscar-thread.c: Fix some typos.
13637
cc12f4a8
TT
136382019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13639 Tom Tromey <tromey@adacore.com>
13640
13641 * ada-lang.c (ada_exception_sal): Change addr_string to a
13642 std::string.
13643 (create_ada_exception_catchpoint): Update.
13644
5f486660
TT
136452019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13646 Tom Tromey <tromey@adacore.com>
13647
13648 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13649 (bp_location_ops): Remove.
13650 (base_breakpoint_allocate_location): Update.
13651 (free_bp_location): Update.
13652 * ada-lang.c (class ada_catchpoint_location)
13653 <ada_catchpoint_location>: Remove ops parameter.
13654 (ada_catchpoint_location_dtor): Remove.
13655 (ada_catchpoint_location_ops): Remove.
13656 (allocate_location_exception): Update.
13657 * breakpoint.h (struct bp_location_ops): Remove.
13658 (class bp_location) <bp_location>: Remove bp_location_ops
13659 parameter.
13660 <~bp_location>: Add destructor.
13661 <ops>: Remove.
13662
b671c7fb
TS
136632019-02-14 Thomas Schwinge <thomas@codesourcery.com>
13664 Pedro Alves <palves@redhat.com>
13665
13666 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13667 'PATH_MAX'.
13668
8071c5ce
DM
136692019-02-14 David Michael <fedora.dm0@gmail.com>
13670 Samuel Thibault <samuel.thibault@gnu.org>
13671 Thomas Schwinge <thomas@codesourcery.com>
13672
13673 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13674 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13675
b1041ae0
TS
136762019-02-14 Thomas Schwinge <thomas@codesourcery.com>
13677
924514e1
TS
13678 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13679 (check_empty): Use "const char *".
13680
c29ee8d4
TS
13681 * gnu-nat.c (gnu_nat_target::detach): Instead of
13682 'detach_inferior (pid)' call
13683 'detach_inferior (find_inferior_pid (pid))'.
13684
6c6ef69f
TS
13685 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13686 'nat/fork-inferior.o'.
13687 * gnu-nat.c: #include "nat/fork-inferior.h".
13688
2d0a338c
TS
13689 * gnu-nat.c (gnu_nat_target::detach): Instead of
13690 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13691 * gnu-nat.h: #include "inf-child.h".
13692 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13693 'i386_gnu_nat_target::fetch_registers'.
13694 (gnu_store_registers): Rename/move to
13695 'i386_gnu_nat_target::store_registers'.
13696
cabb5f06
TS
13697 * config/i386/nm-i386gnu.h: Don't "#include" any files.
13698 * gnu-nat.h (mach_thread_info): New function.
13699 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13700
b1041ae0
TS
13701 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13702
2988d01e
KF
137032019-02-14 Frederic Konrad <konrad@adacore.com>
13704
13705 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13706
c559d709
JB
137072019-02-14 Joel Brobecker <brobecker@adacore.com>
13708
13709 * windows-nat.c (windows_add_thread): Add new parameter
13710 "main_thread_p" with default value set to false. Update
13711 function documentation as well as all callers.
13712 (windows_delete_thread): Likewise.
13713 (fake_create_process): Update call to windows_add_thread.
13714 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13715 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13716 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13717 call to windows_delete_thread.
13718
007024cc
SM
137192019-02-13 Simon Marchi <simon.marchi@ericsson.com>
13720
13721 * MAINTAINERS: Add Andrew Burgess as global maintainer.
13722
f62318e9
JB
137232019-02-12 John Baldwin <jhb@FreeBSD.org>
13724
13725 * symfile.c (find_separate_debug_file): Use canonical path of
13726 sysroot with child_path instead of gdb_sysroot if it is valid.
13727
cd4b7848
JB
137282019-02-12 John Baldwin <jhb@FreeBSD.org>
13729
13730 * symfile.c (find_separate_debug_file): Use child_path to
13731 determine if an object file is under a sysroot.
13732
efac4bfe
JB
137332019-02-12 John Baldwin <jhb@FreeBSD.org>
13734
13735 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13736 unittests/child-path-selftests.c.
13737 * common/pathstuff.c (child_path): New function.
13738 * common/pathstuff.h (child_path): New prototype.
13739 * unittests/child-path-selftests.c: New file.
13740
402d2bfe
JB
137412019-02-12 John Baldwin <jhb@FreeBSD.org>
13742
13743 * symfile.c (find_separate_debug_file): Look for separate debug
13744 files in debug directories under the sysroot.
13745
1ed9f74e
PW
137462019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13747
13748 * symtab.h (struct minimal_symbol data_p): New const method.
13749 (struct minimal_symbol text_p): Likewise.
13750 * symtab.c (output_source_filename): Use file name style
13751 to print file name.
13752 (print_symbol_info): Likewise.
13753 (print_msymbol_info): Use address style to print addresses.
13754 Use function name style to print executable text symbols.
13755 (expand_symtab_containing_pc): Use data_p.
13756 (find_pc_sect_compunit_symtab): Likewise.
13757
2636d81d
PW
137582019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13759
13760 * breakpoint.c (describe_other_breakpoints): Use address style
13761 to print addresses.
13762 (say_where): Likewise.
13763
ac8c53cc
PW
137642019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13765
13766 * ada-typeprint.c (print_func_type): Print function name
13767 style to print function name.
13768 * c-typeprint.c (c_print_type_1): Likewise.
13769
ea638c43
AH
137702019-02-11 Alan Hayward <alan.hayward@arm.com>
13771
13772 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13773 for execve.
13774
ab759ca8
PW
137752019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13776
13777 * c-exp.y (direct_abs_decl): Use emplace_back to record the
13778 type_stack.
13779
aff29d1c
JB
137802019-02-10 Joel Brobecker <brobecker@adacore.com>
13781
13782 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13783 TYPE_CODE_REF types.
13784
617126bc
JW
137852019-02-08 Jim Wilson <jimw@sifive.com>
13786
13787 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13788 (riscv_linux_fregset): New.
13789 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13790
46e3ed7f
TT
137912019-02-07 Tom Tromey <tom@tromey.com>
13792
13793 * thread.c (thread_cancel_execution_command): Update.
13794 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13795 methods.
13796 (struct thread_fsm_ops): Remove.
13797 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13798 (thread_fsm_should_stop, thread_fsm_return_value)
13799 (thread_fsm_set_finished, thread_fsm_finished_p)
13800 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13801 Don't declare.
13802 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13803 * infrun.c (clear_proceed_status_thread)
13804 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13805 (print_stop_event): Update.
13806 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13807 Add constructor.
13808 (step_command_fsm_ops): Remove.
13809 (new_step_command_fsm): Remove.
13810 (step_1): Update.
13811 (step_command_fsm::should_stop): Rename from
13812 step_command_fsm_should_stop.
13813 (step_command_fsm::clean_up): Rename from
13814 step_command_fsm_clean_up.
13815 (step_command_fsm::do_async_reply_reason): Rename from
13816 step_command_fsm_async_reply_reason.
13817 (struct until_next_fsm): Inherit from thread_fsm. Add
13818 constructor.
13819 (until_next_fsm_ops): Remove.
13820 (new_until_next_fsm): Remove.
13821 (until_next_fsm::should_stop): Rename from
13822 until_next_fsm_should_stop.
13823 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13824 (until_next_fsm::do_async_reply_reason): Rename from
13825 until_next_fsm_async_reply_reason.
13826 (struct finish_command_fsm): Inherit from thread_fsm. Add
13827 constructor. Change type of breakpoint.
13828 (finish_command_fsm_ops): Remove.
13829 (new_finish_command_fsm): Remove.
13830 (finish_command_fsm::should_stop): Rename from
13831 finish_command_fsm_should_stop.
13832 (finish_command_fsm::clean_up): Rename from
13833 finish_command_fsm_clean_up.
13834 (finish_command_fsm::return_value): Rename from
13835 finish_command_fsm_return_value.
13836 (finish_command_fsm::do_async_reply_reason): Rename from
13837 finish_command_fsm_async_reply_reason.
13838 (finish_command): Update.
13839 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13840 Add constructor.
13841 (call_thread_fsm_ops): Remove.
13842 (call_thread_fsm::call_thread_fsm): Rename from
13843 new_call_thread_fsm.
13844 (call_thread_fsm::should_stop): Rename from
13845 call_thread_fsm_should_stop.
13846 (call_thread_fsm::should_notify_stop): Rename from
13847 call_thread_fsm_should_notify_stop.
13848 (run_inferior_call, call_function_by_hand_dummy): Update.
13849 * cli/cli-interp.c (should_print_stop_to_console): Update.
13850 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13851 Add constructor. Change type of location_breakpoint,
13852 caller_breakpoint.
13853 (until_break_fsm_ops): Remove.
13854 (new_until_break_fsm): Remove.
13855 (until_break_fsm::should_stop): Rename from
13856 until_break_fsm_should_stop.
13857 (until_break_fsm::clean_up): Rename from
13858 until_break_fsm_clean_up.
13859 (until_break_fsm::do_async_reply_reason): Rename from
13860 until_break_fsm_async_reply_reason.
13861 (until_break_command): Update.
13862 * thread-fsm.c: Remove.
13863 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13864
1a5c2598
TT
138652019-02-07 Tom Tromey <tom@tromey.com>
13866
13867 * yy-remap.h: Add include guard.
13868 * xtensa-tdep.h: Add include guard.
13869 * xcoffread.h: Rename include guard.
13870 * varobj-iter.h: Add include guard.
13871 * tui/tui.h: Rename include guard.
13872 * tui/tui-winsource.h: Rename include guard.
13873 * tui/tui-wingeneral.h: Rename include guard.
13874 * tui/tui-windata.h: Rename include guard.
13875 * tui/tui-win.h: Rename include guard.
13876 * tui/tui-stack.h: Rename include guard.
13877 * tui/tui-source.h: Rename include guard.
13878 * tui/tui-regs.h: Rename include guard.
13879 * tui/tui-out.h: Rename include guard.
13880 * tui/tui-layout.h: Rename include guard.
13881 * tui/tui-io.h: Rename include guard.
13882 * tui/tui-hooks.h: Rename include guard.
13883 * tui/tui-file.h: Rename include guard.
13884 * tui/tui-disasm.h: Rename include guard.
13885 * tui/tui-data.h: Rename include guard.
13886 * tui/tui-command.h: Rename include guard.
13887 * tic6x-tdep.h: Add include guard.
13888 * target/waitstatus.h: Rename include guard.
13889 * target/wait.h: Rename include guard.
13890 * target/target.h: Rename include guard.
13891 * target/resume.h: Rename include guard.
13892 * target-float.h: Rename include guard.
13893 * stabsread.h: Add include guard.
13894 * rs6000-tdep.h: Add include guard.
13895 * riscv-fbsd-tdep.h: Add include guard.
13896 * regformats/regdef.h: Rename include guard.
13897 * record.h: Rename include guard.
13898 * python/python.h: Rename include guard.
13899 * python/python-internal.h: Rename include guard.
13900 * python/py-stopevent.h: Rename include guard.
13901 * python/py-ref.h: Rename include guard.
13902 * python/py-record.h: Rename include guard.
13903 * python/py-record-full.h: Rename include guard.
13904 * python/py-record-btrace.h: Rename include guard.
13905 * python/py-instruction.h: Rename include guard.
13906 * python/py-events.h: Rename include guard.
13907 * python/py-event.h: Rename include guard.
13908 * procfs.h: Add include guard.
13909 * proc-utils.h: Add include guard.
13910 * p-lang.h: Add include guard.
13911 * or1k-tdep.h: Rename include guard.
13912 * observable.h: Rename include guard.
13913 * nto-tdep.h: Rename include guard.
13914 * nat/x86-linux.h: Rename include guard.
13915 * nat/x86-linux-dregs.h: Rename include guard.
13916 * nat/x86-gcc-cpuid.h: Add include guard.
13917 * nat/x86-dregs.h: Rename include guard.
13918 * nat/x86-cpuid.h: Rename include guard.
13919 * nat/ppc-linux.h: Rename include guard.
13920 * nat/mips-linux-watch.h: Rename include guard.
13921 * nat/linux-waitpid.h: Rename include guard.
13922 * nat/linux-ptrace.h: Rename include guard.
13923 * nat/linux-procfs.h: Rename include guard.
13924 * nat/linux-osdata.h: Rename include guard.
13925 * nat/linux-nat.h: Rename include guard.
13926 * nat/linux-namespaces.h: Rename include guard.
13927 * nat/linux-btrace.h: Rename include guard.
13928 * nat/glibc_thread_db.h: Rename include guard.
13929 * nat/gdb_thread_db.h: Rename include guard.
13930 * nat/gdb_ptrace.h: Rename include guard.
13931 * nat/fork-inferior.h: Rename include guard.
13932 * nat/amd64-linux-siginfo.h: Rename include guard.
13933 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13934 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13935 * nat/aarch64-linux.h: Rename include guard.
13936 * nat/aarch64-linux-hw-point.h: Rename include guard.
13937 * mn10300-tdep.h: Add include guard.
13938 * mips-linux-tdep.h: Add include guard.
13939 * mi/mi-parse.h: Rename include guard.
13940 * mi/mi-out.h: Rename include guard.
13941 * mi/mi-main.h: Rename include guard.
13942 * mi/mi-interp.h: Rename include guard.
13943 * mi/mi-getopt.h: Rename include guard.
13944 * mi/mi-console.h: Rename include guard.
13945 * mi/mi-common.h: Rename include guard.
13946 * mi/mi-cmds.h: Rename include guard.
13947 * mi/mi-cmd-break.h: Rename include guard.
13948 * m2-lang.h: Add include guard.
13949 * location.h: Rename include guard.
13950 * linux-record.h: Rename include guard.
13951 * linux-nat.h: Add include guard.
13952 * linux-fork.h: Add include guard.
13953 * i386-darwin-tdep.h: Rename include guard.
13954 * hppa-linux-offsets.h: Add include guard.
13955 * guile/guile.h: Rename include guard.
13956 * guile/guile-internal.h: Rename include guard.
13957 * gnu-nat.h: Rename include guard.
13958 * gdb-stabs.h: Rename include guard.
13959 * frv-tdep.h: Add include guard.
13960 * f-lang.h: Add include guard.
13961 * event-loop.h: Add include guard.
13962 * darwin-nat.h: Rename include guard.
13963 * cp-abi.h: Rename include guard.
13964 * config/sparc/nm-sol2.h: Rename include guard.
13965 * config/nm-nto.h: Rename include guard.
13966 * config/nm-linux.h: Add include guard.
13967 * config/i386/nm-i386gnu.h: Rename include guard.
13968 * config/djgpp/nl_types.h: Rename include guard.
13969 * config/djgpp/langinfo.h: Rename include guard.
13970 * compile/gcc-cp-plugin.h: Add include guard.
13971 * compile/gcc-c-plugin.h: Add include guard.
13972 * compile/compile.h: Rename include guard.
13973 * compile/compile-object-run.h: Rename include guard.
13974 * compile/compile-object-load.h: Rename include guard.
13975 * compile/compile-internal.h: Rename include guard.
13976 * compile/compile-cplus.h: Rename include guard.
13977 * compile/compile-c.h: Rename include guard.
13978 * common/xml-utils.h: Rename include guard.
13979 * common/x86-xstate.h: Rename include guard.
13980 * common/version.h: Rename include guard.
13981 * common/vec.h: Rename include guard.
13982 * common/tdesc.h: Rename include guard.
13983 * common/selftest.h: Rename include guard.
13984 * common/scoped_restore.h: Rename include guard.
13985 * common/scoped_mmap.h: Rename include guard.
13986 * common/scoped_fd.h: Rename include guard.
13987 * common/safe-iterator.h: Rename include guard.
13988 * common/run-time-clock.h: Rename include guard.
13989 * common/refcounted-object.h: Rename include guard.
13990 * common/queue.h: Rename include guard.
13991 * common/ptid.h: Rename include guard.
13992 * common/print-utils.h: Rename include guard.
13993 * common/preprocessor.h: Rename include guard.
13994 * common/pathstuff.h: Rename include guard.
13995 * common/observable.h: Rename include guard.
13996 * common/netstuff.h: Rename include guard.
13997 * common/job-control.h: Rename include guard.
13998 * common/host-defs.h: Rename include guard.
13999 * common/gdb_wait.h: Rename include guard.
14000 * common/gdb_vecs.h: Rename include guard.
14001 * common/gdb_unlinker.h: Rename include guard.
14002 * common/gdb_unique_ptr.h: Rename include guard.
14003 * common/gdb_tilde_expand.h: Rename include guard.
14004 * common/gdb_sys_time.h: Rename include guard.
14005 * common/gdb_string_view.h: Rename include guard.
14006 * common/gdb_splay_tree.h: Rename include guard.
14007 * common/gdb_setjmp.h: Rename include guard.
14008 * common/gdb_ref_ptr.h: Rename include guard.
14009 * common/gdb_optional.h: Rename include guard.
14010 * common/gdb_locale.h: Rename include guard.
14011 * common/gdb_assert.h: Rename include guard.
14012 * common/filtered-iterator.h: Rename include guard.
14013 * common/filestuff.h: Rename include guard.
14014 * common/fileio.h: Rename include guard.
14015 * common/environ.h: Rename include guard.
14016 * common/common-utils.h: Rename include guard.
14017 * common/common-types.h: Rename include guard.
14018 * common/common-regcache.h: Rename include guard.
14019 * common/common-inferior.h: Rename include guard.
14020 * common/common-gdbthread.h: Rename include guard.
14021 * common/common-exceptions.h: Rename include guard.
14022 * common/common-defs.h: Rename include guard.
14023 * common/common-debug.h: Rename include guard.
14024 * common/cleanups.h: Rename include guard.
14025 * common/buffer.h: Rename include guard.
14026 * common/btrace-common.h: Rename include guard.
14027 * common/break-common.h: Rename include guard.
14028 * cli/cli-utils.h: Rename include guard.
14029 * cli/cli-style.h: Rename include guard.
14030 * cli/cli-setshow.h: Rename include guard.
14031 * cli/cli-script.h: Rename include guard.
14032 * cli/cli-interp.h: Rename include guard.
14033 * cli/cli-decode.h: Rename include guard.
14034 * cli/cli-cmds.h: Rename include guard.
14035 * charset-list.h: Add include guard.
14036 * buildsym-legacy.h: Rename include guard.
14037 * bfin-tdep.h: Add include guard.
14038 * ax.h: Rename include guard.
14039 * arm-linux-tdep.h: Add include guard.
14040 * arm-fbsd-tdep.h: Add include guard.
14041 * arch/xtensa.h: Rename include guard.
14042 * arch/tic6x.h: Add include guard.
14043 * arch/i386.h: Add include guard.
14044 * arch/arm.h: Rename include guard.
14045 * arch/arm-linux.h: Rename include guard.
14046 * arch/arm-get-next-pcs.h: Rename include guard.
14047 * arch/amd64.h: Add include guard.
14048 * arch/aarch64-insn.h: Rename include guard.
14049 * arch-utils.h: Rename include guard.
14050 * annotate.h: Add include guard.
14051 * amd64-darwin-tdep.h: Rename include guard.
14052 * aarch64-linux-tdep.h: Add include guard.
14053 * aarch64-fbsd-tdep.h: Add include guard.
14054 * aarch32-linux-nat.h: Add include guard.
14055
ab9268d2
PW
140562019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14057
14058 * macrotab.c (macro_define_internal): New function that
14059 factorizes macro_define_object_internal and macro_define_function
14060 code.
14061 (macro_define_object_internal): Use macro_define_internal.
14062 (macro_define_function): Likewise.
14063
bb0da2b4
PW
140642019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14065
14066 * macrocmd.c (extract_identifier): Return
14067 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14068 callers.
14069
424eb552
JB
140702019-02-06 John Baldwin <jhb@FreeBSD.org>
14071
14072 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14073
1688cb29
TT
140742019-02-05 Tom Tromey <tom@tromey.com>
14075
14076 * target.c (target_stack::unpush): Move assertion earlier.
14077
b5eba2d8
TT
140782019-01-30 Tom Tromey <tom@tromey.com>
14079
14080 PR python/23615:
14081 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14082 (gdbpy_parse_and_eval): Likewise.
14083 * python/python-internal.h (gdbpy_allow_threads): New class.
14084
7054e2ff
JB
140852019-01-28 John Baldwin <jhb@FreeBSD.org>
14086
14087 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14088 (aarch64_fbsd_fpregmap): Move earlier.
14089 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14090 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14091 instead of individual calls to trad_frame_set_reg_addr.
14092 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14093 earlier.
14094 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14095 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14096 instead of individual calls to trad_frame_set_reg_addr.
14097
36c25ffa
AH
140982019-01-28 Alan Hayward <alan.hayward@arm.com>
14099
14100 * CONTRIBUTE: Replace contribution list with wiki link.
14101
a0707f3c
TT
141022019-01-25 Tom Tromey <tom@tromey.com>
14103
14104 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14105
0747795c
TT
141062019-01-25 Tom Tromey <tom@tromey.com>
14107
14108 * xtensa-linux-nat.c: Fix common/ includes.
14109 * xml-support.h: Fix common/ includes.
14110 * xml-support.c: Fix common/ includes.
14111 * x86-linux-nat.c: Fix common/ includes.
14112 * windows-nat.c: Fix common/ includes.
14113 * varobj.h: Fix common/ includes.
14114 * varobj.c: Fix common/ includes.
14115 * value.c: Fix common/ includes.
14116 * valops.c: Fix common/ includes.
14117 * utils.c: Fix common/ includes.
14118 * unittests/xml-utils-selftests.c: Fix common/ includes.
14119 * unittests/utils-selftests.c: Fix common/ includes.
14120 * unittests/unpack-selftests.c: Fix common/ includes.
14121 * unittests/tracepoint-selftests.c: Fix common/ includes.
14122 * unittests/style-selftests.c: Fix common/ includes.
14123 * unittests/string_view-selftests.c: Fix common/ includes.
14124 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14125 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14126 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14127 * unittests/rsp-low-selftests.c: Fix common/ includes.
14128 * unittests/parse-connection-spec-selftests.c: Fix common/
14129 includes.
14130 * unittests/optional-selftests.c: Fix common/ includes.
14131 * unittests/offset-type-selftests.c: Fix common/ includes.
14132 * unittests/observable-selftests.c: Fix common/ includes.
14133 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14134 * unittests/memrange-selftests.c: Fix common/ includes.
14135 * unittests/memory-map-selftests.c: Fix common/ includes.
14136 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14137 * unittests/function-view-selftests.c: Fix common/ includes.
14138 * unittests/environ-selftests.c: Fix common/ includes.
14139 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14140 * unittests/common-utils-selftests.c: Fix common/ includes.
14141 * unittests/cli-utils-selftests.c: Fix common/ includes.
14142 * unittests/array-view-selftests.c: Fix common/ includes.
14143 * ui-file.c: Fix common/ includes.
14144 * tui/tui-io.c: Fix common/ includes.
14145 * tracepoint.h: Fix common/ includes.
14146 * tracepoint.c: Fix common/ includes.
14147 * tracefile-tfile.c: Fix common/ includes.
14148 * top.h: Fix common/ includes.
14149 * top.c: Fix common/ includes.
14150 * thread.c: Fix common/ includes.
14151 * target/waitstatus.h: Fix common/ includes.
14152 * target/waitstatus.c: Fix common/ includes.
14153 * target.h: Fix common/ includes.
14154 * target.c: Fix common/ includes.
14155 * target-memory.c: Fix common/ includes.
14156 * target-descriptions.c: Fix common/ includes.
14157 * symtab.h: Fix common/ includes.
14158 * symfile.c: Fix common/ includes.
14159 * stap-probe.c: Fix common/ includes.
14160 * spu-linux-nat.c: Fix common/ includes.
14161 * sparc-nat.c: Fix common/ includes.
14162 * source.c: Fix common/ includes.
14163 * solib.c: Fix common/ includes.
14164 * solib-target.c: Fix common/ includes.
14165 * ser-unix.c: Fix common/ includes.
14166 * ser-tcp.c: Fix common/ includes.
14167 * ser-pipe.c: Fix common/ includes.
14168 * ser-base.c: Fix common/ includes.
14169 * selftest-arch.c: Fix common/ includes.
14170 * s12z-tdep.c: Fix common/ includes.
14171 * rust-exp.y: Fix common/ includes.
14172 * rs6000-aix-tdep.c: Fix common/ includes.
14173 * riscv-tdep.c: Fix common/ includes.
14174 * remote.c: Fix common/ includes.
14175 * remote-notif.h: Fix common/ includes.
14176 * remote-fileio.h: Fix common/ includes.
14177 * remote-fileio.c: Fix common/ includes.
14178 * regcache.h: Fix common/ includes.
14179 * regcache.c: Fix common/ includes.
14180 * record-btrace.c: Fix common/ includes.
14181 * python/python.c: Fix common/ includes.
14182 * python/py-type.c: Fix common/ includes.
14183 * python/py-inferior.c: Fix common/ includes.
14184 * progspace.h: Fix common/ includes.
14185 * producer.c: Fix common/ includes.
14186 * procfs.c: Fix common/ includes.
14187 * proc-api.c: Fix common/ includes.
14188 * printcmd.c: Fix common/ includes.
14189 * ppc-linux-nat.c: Fix common/ includes.
14190 * parser-defs.h: Fix common/ includes.
14191 * osdata.c: Fix common/ includes.
14192 * obsd-nat.c: Fix common/ includes.
14193 * nat/x86-linux.c: Fix common/ includes.
14194 * nat/x86-linux-dregs.c: Fix common/ includes.
14195 * nat/x86-dregs.h: Fix common/ includes.
14196 * nat/x86-dregs.c: Fix common/ includes.
14197 * nat/ppc-linux.c: Fix common/ includes.
14198 * nat/mips-linux-watch.h: Fix common/ includes.
14199 * nat/mips-linux-watch.c: Fix common/ includes.
14200 * nat/linux-waitpid.c: Fix common/ includes.
14201 * nat/linux-ptrace.h: Fix common/ includes.
14202 * nat/linux-ptrace.c: Fix common/ includes.
14203 * nat/linux-procfs.c: Fix common/ includes.
14204 * nat/linux-personality.c: Fix common/ includes.
14205 * nat/linux-osdata.c: Fix common/ includes.
14206 * nat/linux-namespaces.c: Fix common/ includes.
14207 * nat/linux-btrace.h: Fix common/ includes.
14208 * nat/linux-btrace.c: Fix common/ includes.
14209 * nat/fork-inferior.c: Fix common/ includes.
14210 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14211 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14212 * nat/aarch64-linux.c: Fix common/ includes.
14213 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14214 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14215 * namespace.h: Fix common/ includes.
14216 * mips-linux-tdep.c: Fix common/ includes.
14217 * minsyms.c: Fix common/ includes.
14218 * mi/mi-parse.h: Fix common/ includes.
14219 * mi/mi-main.c: Fix common/ includes.
14220 * mi/mi-cmd-env.c: Fix common/ includes.
14221 * memrange.h: Fix common/ includes.
14222 * memattr.c: Fix common/ includes.
14223 * maint.h: Fix common/ includes.
14224 * maint.c: Fix common/ includes.
14225 * main.c: Fix common/ includes.
14226 * machoread.c: Fix common/ includes.
14227 * location.c: Fix common/ includes.
14228 * linux-thread-db.c: Fix common/ includes.
14229 * linux-nat.c: Fix common/ includes.
14230 * linux-fork.c: Fix common/ includes.
14231 * inline-frame.c: Fix common/ includes.
14232 * infrun.c: Fix common/ includes.
14233 * inflow.c: Fix common/ includes.
14234 * inferior.h: Fix common/ includes.
14235 * inferior.c: Fix common/ includes.
14236 * infcmd.c: Fix common/ includes.
14237 * inf-ptrace.c: Fix common/ includes.
14238 * inf-child.c: Fix common/ includes.
14239 * ia64-linux-nat.c: Fix common/ includes.
14240 * i387-tdep.c: Fix common/ includes.
14241 * i386-tdep.c: Fix common/ includes.
14242 * i386-linux-tdep.c: Fix common/ includes.
14243 * i386-linux-nat.c: Fix common/ includes.
14244 * i386-go32-tdep.c: Fix common/ includes.
14245 * i386-fbsd-tdep.c: Fix common/ includes.
14246 * i386-fbsd-nat.c: Fix common/ includes.
14247 * guile/scm-type.c: Fix common/ includes.
14248 * guile/guile.c: Fix common/ includes.
14249 * go32-nat.c: Fix common/ includes.
14250 * gnu-nat.c: Fix common/ includes.
14251 * gdbthread.h: Fix common/ includes.
14252 * gdbarch-selftests.c: Fix common/ includes.
14253 * gdb_usleep.c: Fix common/ includes.
14254 * gdb_select.h: Fix common/ includes.
14255 * gdb_bfd.c: Fix common/ includes.
14256 * gcore.c: Fix common/ includes.
14257 * fork-child.c: Fix common/ includes.
14258 * findvar.c: Fix common/ includes.
14259 * fbsd-nat.c: Fix common/ includes.
14260 * event-top.c: Fix common/ includes.
14261 * event-loop.c: Fix common/ includes.
14262 * dwarf2read.c: Fix common/ includes.
14263 * dwarf2loc.c: Fix common/ includes.
14264 * dwarf2-frame.c: Fix common/ includes.
14265 * dwarf-index-cache.c: Fix common/ includes.
14266 * dtrace-probe.c: Fix common/ includes.
14267 * disasm-selftests.c: Fix common/ includes.
14268 * defs.h: Fix common/ includes.
14269 * csky-tdep.c: Fix common/ includes.
14270 * cp-valprint.c: Fix common/ includes.
14271 * cp-support.h: Fix common/ includes.
14272 * cp-support.c: Fix common/ includes.
14273 * corelow.c: Fix common/ includes.
14274 * completer.h: Fix common/ includes.
14275 * completer.c: Fix common/ includes.
14276 * compile/compile.c: Fix common/ includes.
14277 * compile/compile-loc2c.c: Fix common/ includes.
14278 * compile/compile-cplus-types.c: Fix common/ includes.
14279 * compile/compile-cplus-symbols.c: Fix common/ includes.
14280 * command.h: Fix common/ includes.
14281 * cli/cli-dump.c: Fix common/ includes.
14282 * cli/cli-cmds.c: Fix common/ includes.
14283 * charset.c: Fix common/ includes.
14284 * build-id.c: Fix common/ includes.
14285 * btrace.h: Fix common/ includes.
14286 * btrace.c: Fix common/ includes.
14287 * breakpoint.h: Fix common/ includes.
14288 * breakpoint.c: Fix common/ includes.
14289 * ax.h:
14290 (enum agent_op): Fix common/ includes.
14291 * ax-general.c (struct aop_map): Fix common/ includes.
14292 * ax-gdb.c: Fix common/ includes.
14293 * auxv.c: Fix common/ includes.
14294 * auto-load.c: Fix common/ includes.
14295 * arm-tdep.c: Fix common/ includes.
14296 * arch/riscv.c: Fix common/ includes.
14297 * arch/ppc-linux-common.c: Fix common/ includes.
14298 * arch/i386.c: Fix common/ includes.
14299 * arch/arm.c: Fix common/ includes.
14300 * arch/arm-linux.c: Fix common/ includes.
14301 * arch/arm-get-next-pcs.c: Fix common/ includes.
14302 * arch/amd64.c: Fix common/ includes.
14303 * arch/aarch64.c: Fix common/ includes.
14304 * arch/aarch64-insn.c: Fix common/ includes.
14305 * arch-utils.c: Fix common/ includes.
14306 * amd64-windows-tdep.c: Fix common/ includes.
14307 * amd64-tdep.c: Fix common/ includes.
14308 * amd64-sol2-tdep.c: Fix common/ includes.
14309 * amd64-obsd-tdep.c: Fix common/ includes.
14310 * amd64-nbsd-tdep.c: Fix common/ includes.
14311 * amd64-linux-tdep.c: Fix common/ includes.
14312 * amd64-linux-nat.c: Fix common/ includes.
14313 * amd64-fbsd-tdep.c: Fix common/ includes.
14314 * amd64-fbsd-nat.c: Fix common/ includes.
14315 * amd64-dicos-tdep.c: Fix common/ includes.
14316 * amd64-darwin-tdep.c: Fix common/ includes.
14317 * agent.c: Fix common/ includes.
14318 * ada-lang.h: Fix common/ includes.
14319 * ada-lang.c: Fix common/ includes.
14320 * aarch64-tdep.c: Fix common/ includes.
14321
2f5c153e
TT
143222019-01-25 Tom Tromey <tom@tromey.com>
14323
14324 * common/create-version.sh: Use common/version.h.
14325
adc6a863
PA
143262019-01-24 Pedro Alves <palves@redhat.com>
14327
14328 * infrun.c (signal_stop, signal_print, signal_program)
14329 (signal_catch, signal_pass): Now arrays instead of pointers.
14330 (update_signals_program_target, do_target_resume)
14331 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14332 * linux-nat.c (linux_nat_target::pass_signals)
14333 (linux_nat_target::create_inferior, linux_nat_target::attach):
14334 Adjust.
14335 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14336 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14337 * procfs.c (procfs_target::pass_signals): Adjust.
14338 * record-full.c (record_full_target::resume): Adjust.
14339 * remote.c (remote_target::pass_signals)
14340 (remote_target::program_signals): Adjust.
14341 * target-debug.h (target_debug_print_signals): Now takes a
14342 gdb::array_view as parameter. Adjust.
14343 * target.h (target_ops) <pass_signals, program_signals>: Replace
14344 pointer and length parameters with gdb::array_view.
14345 (target_pass_signals, target_program_signals): Likewise.
14346 * target-delegates.c: Regenerate.
14347
3046d67a
PA
143482019-01-24 Pedro Alves <palves@redhat.com>
14349
14350 * common/forward-scope-exit.h
14351 (forward_scope_exit::forward_scope_exit): Pass arguments to
14352 m_bind_function directly, instead of creating a std::bind and
14353 copying that.
14354
353229bf
AH
143552019-01-24 Alan Hayward <alan.hayward@arm.com>
14356
14357 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14358 for static members.
14359 (pass_in_v_vfp_candidate): Likewise.
14360
311dc83a
TT
143612019-01-23 Tom Tromey <tom@tromey.com>
14362 Pedro Alves <palves@redhat.com>
14363
14364 * regcache.c (class regcache_invalidator): Remove.
14365 (regcache::raw_write): Use make_scope_exit.
14366
296bd123
TT
143672019-01-23 Tom Tromey <tom@tromey.com>
14368
14369 * ui-out.h (class ui_out_emit_type): Update comment.
14370
979a0d13
TT
143712019-01-23 Tom Tromey <tom@tromey.com>
14372
14373 * infrun.c (fetch_inferior_event): Update comment.
14374
d238133d
TT
143752019-01-23 Tom Tromey <tom@tromey.com>
14376 Pedro Alves <palves@redhat.com>
14377
14378 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14379 parameter.
14380 (fetch_inferior_event): Use SCOPE_EXIT.
14381
14382
9885e6bb
TT
143832019-01-23 Tom Tromey <tom@tromey.com>
14384 Pedro Alves <palves@redhat.com>
14385
14386 * infrun.c (disable_thread_events): Delete.
14387 (stop_all_threads): Use SCOPE_EXIT.
14388
286526c1
TT
143892019-01-23 Tom Tromey <tom@tromey.com>
14390 Pedro Alves <palves@redhat.com>
14391
14392 * symfile.c: Include forward-scope-exit.h.
14393 (clear_symtab_users_cleanup): Replace forward declaration with
14394 a FORWARD_SCOPE_EXIT.
14395 (syms_from_objfile_1): Use the forward_scope_exit and
14396 gdb::optional instead of cleanup_function.
14397 (reread_symbols): Use the forward_scope_exit instead of
14398 cleanup_function.
14399 (clear_symtab_users_cleanup): Remove function.
14400
1db93f14
TT
144012019-01-23 Tom Tromey <tom@tromey.com>
14402 Pedro Alves <palves@redhat.com>
14403
14404 * linux-nat.c: Include scope-exit.h.
14405 (cleanup_target_stop): Remove.
14406 (linux_nat_target::static_tracepoint_markers_by_strid): Use
14407 SCOPE_EXIT.
14408
2cc83d1e
TT
144092019-01-23 Tom Tromey <tom@tromey.com>
14410 Pedro Alves <palves@redhat.com>
14411
14412 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14413 (call_function_by_hand_dummy): Use SCOPE_EXIT.
14414
694c6bf5
TT
144152019-01-23 Tom Tromey <tom@tromey.com>
14416 Andrew Burgess <andrew.burgess@embecosm.com>
14417 Pedro Alves <palves@redhat.com>
14418
14419 * infrun.c (fetch_inferior_event): Use scope_exit.
14420 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14421 * top.c (execute_command): Use scope_exit.
14422 * breakpoint.c (bpstat_do_actions): Use scope_exit.
14423 * utils.c (do_bpstat_clear_actions_cleanup)
14424 (make_bpstat_clear_actions_cleanup): Remove.
14425
4c41382a
TT
144262019-01-23 Tom Tromey <tom@tromey.com>
14427 Pedro Alves <palves@redhat.com>
14428
14429 * infrun.c: Include "common/scope-exit.h"
14430 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14431 (wait_for_inferior): Use SCOPE_EXIT.
14432 (fetch_inferior_event): Use scope_exit.
14433
89f8fb50
TT
144342019-01-23 Tom Tromey <tom@tromey.com>
14435 Pedro Alves <palves@redhat.com>
14436
14437 * breakpoint.c (create_breakpoint): Remove cleanup.
14438
5419bdae
TT
144392019-01-23 Tom Tromey <tom@tromey.com>
14440 Andrew Burgess <andrew.burgess@embecosm.com>
14441 Pedro Alves <palves@redhat.com>
14442
e587ef42
PA
144432019-01-23 Pedro Alves <palves@redhat.com>
14444
14445 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14446
77f0e74c
PA
144472019-01-23 Pedro Alves <palves@redhat.com>
14448 Andrew Burgess <andrew.burgess@embecosm.com>
14449
14450 * gdbthread.h: Include "common/forward-scope-exit.h".
14451 (scoped_finish_thread_state): Redefine custom class in terms of
14452 forward_scope_exit.
14453
5b9b3e53
PA
144542019-01-23 Pedro Alves <palves@redhat.com>
14455 Andrew Burgess <andrew.burgess@embecosm.com>
14456
14457 * common/forward-scope-exit.h: New file.
14458
54b65c9b
PA
144592019-01-23 Pedro Alves <palves@redhat.com>
14460 Andrew Burgess <andrew.burgess@embecosm.com>
14461 Tom Tromey <tom@tromey.com>
14462
14463 * common/scope-exit.h: New file.
14464
cf08fb29
PA
144652019-01-23 Pedro Alves <palves@redhat.com>
14466
14467 * common/preprocessor.h (ESC): Rename to ...
14468 (ESC_PARENS): ... this.
14469 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14470 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14471
ae73e2e2
TT
144722019-01-23 Tom Tromey <tom@tromey.com>
14473
14474 * language.h (class scoped_switch_to_sym_language_if_auto):
14475 Initialize m_lang in both cases.
14476
6594e122
AH
144772019-01-23 Alan Hayward <alan.hayward@arm.com>
14478
14479 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14480 with XCNEW.
14481
a7c9855d
TT
144822019-01-22 Tom Tromey <tom@tromey.com>
14483
14484 * corelow.c: Do not include sys/file.h.
14485
93cc1d53
TT
144862019-01-22 Tom Tromey <tom@tromey.com>
14487
14488 * tui/tui-wingeneral.h: Include gdb_curses.h.
14489
38561778
TT
144902019-01-22 Tom Tromey <tom@tromey.com>
14491
14492 * source-cache.h (class source_cache) <get_source_lines,
14493 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14494
37b3ab5b
TT
144952019-01-22 Tom Tromey <tom@tromey.com>
14496
14497 * remote-fileio.h (struct remote_target): Declare.
14498
3fabc016
TT
144992019-01-22 Tom Tromey <tom@tromey.com>
14500
14501 * python/py-arch.c: Do not include py-ref.h.
14502 * python/py-bpevent.c: Do not include py-ref.h.
14503 * python/py-cmd.c: Do not include py-ref.h.
14504 * python/py-continueevent.c: Do not include py-ref.h.
14505 * python/py-event.h: Do not include py-ref.h.
14506 * python/py-evtregistry.c: Do not include py-ref.h.
14507 * python/py-finishbreakpoint.c: Do not include py-ref.h.
14508 * python/py-frame.c: Do not include py-ref.h.
14509 * python/py-framefilter.c: Do not include py-ref.h.
14510 * python/py-function.c: Do not include py-ref.h.
14511 * python/py-infevents.c: Do not include py-ref.h.
14512 * python/py-linetable.c: Do not include py-ref.h.
14513 * python/py-objfile.c: Do not include py-ref.h.
14514 * python/py-param.c: Do not include py-ref.h.
14515 * python/py-prettyprint.c: Do not include py-ref.h.
14516 * python/py-progspace.c: Do not include py-ref.h.
14517 * python/py-symbol.c: Do not include py-ref.h.
14518 * python/py-symtab.c: Do not include py-ref.h.
14519 * python/py-type.c: Do not include py-ref.h.
14520 * python/py-unwind.c: Do not include py-ref.h.
14521 * python/py-utils.c: Do not include py-ref.h.
14522 * python/py-value.c: Do not include py-ref.h.
14523 * python/py-varobj.c: Do not include py-ref.h.
14524 * python/py-xmethods.c: Do not include py-ref.h.
14525 * python/python.c: Do not include py-ref.h.
14526 * varobj.c: Do not include py-ref.h.
14527
6b4d7774
TT
145282019-01-22 Tom Tromey <tom@tromey.com>
14529
14530 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14531 keyword for bcache.
14532
7af7e9b5
TT
145332019-01-22 Tom Tromey <tom@tromey.com>
14534
14535 * compile/compile-cplus-types.c: Remove a comment by #include.
14536
951d1049
TT
145372019-01-22 Tom Tromey <tom@tromey.com>
14538
14539 * compile/gcc-c-plugin.h: Include compile-internal.h.
14540
d65d5705
TT
145412019-01-22 Tom Tromey <tom@tromey.com>
14542
14543 * stabsread.c (EXTERN): Do not define.
14544 (symnum, next_symbol_text_func, processing_gcc_compilation)
14545 (within_function, global_sym_chain, global_stabs)
14546 (previous_stab_code, this_object_header_files)
14547 (n_this_object_header_files)
14548 (n_allocated_this_object_header_files): Define.
14549 * stabsread.h (EXTERN): Never define. Use "extern".
14550
b6fb1ee5
PW
145512019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14552
14553 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14554 history_value.
14555
be6d4f74
TT
145562019-01-21 Tom Tromey <tom@tromey.com>
14557
14558 * ui-out.c: Fix includes.
14559 * tui/tui-source.c: Fix includes.
14560 * target.c: Fix includes.
14561 * remote.c: Fix includes.
14562 * regcache.c: Fix includes.
14563 * python/py-block.c: Fix includes.
14564 * printcmd.c: Fix includes.
14565 * or1k-tdep.c: Fix includes.
14566 * mi/mi-main.c: Fix includes.
14567 * m32r-tdep.c: Fix includes.
14568 * csky-tdep.c: Fix includes.
14569 * compile/compile-cplus-types.c: Fix includes.
14570 * cli/cli-interp.c: Fix includes.
14571
73021deb
AH
145722019-01-21 Alan Hayward <alan.hayward@arm.com>
14573
14574 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14575 for padding.
14576
7932255d
TT
145772019-01-16 Tom Tromey <tom@tromey.com>
14578
14579 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
14580 earlier.
14581 (struct objfile) <msymbols_range>: Move from top level.
14582 <msymbols>: New method.
14583 (class objfile_msymbols): Remove.
14584 * symtab.c (default_collect_symbol_completion_matches_break_on):
14585 Update.
14586 * symmisc.c (dump_msymbols): Update.
14587 * stabsread.c (scan_file_globals): Update.
14588 * objc-lang.c (info_selectors_command, info_classes_command)
14589 (find_methods): Update.
14590 * minsyms.c (find_solib_trampoline_target): Update.
14591 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14592 * coffread.c (coff_symfile_read): Update.
14593 * ada-lang.c (ada_lookup_simple_minsym)
14594 (ada_collect_symbol_completion_matches): Update.
14595
604b1bfb
TT
145962019-01-16 Tom Tromey <tom@tromey.com>
14597
14598 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14599 type. Remove no-argument constructor.
14600 <iterator::operator++>: Simplify.
14601 <begin>: Update.
14602 <end>: Use minimal_symbol_count.
14603
f252c6d5
TT
146042019-01-16 Tom Tromey <tom@tromey.com>
14605
14606 * objfiles.h (struct objfile) <psymtabs>: New method.
14607 (class objfile_psymtabs): Remove.
14608 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14609 typedef.
14610 <range>: New method.
14611 (require_partial_symbols): Change return type.
14612 * psymtab.c (require_partial_symbols)
14613 (psym_expand_symtabs_matching): Update.
14614 * mdebugread.c (parse_partial_symbols): Update.
14615 * dbxread.c (dbx_end_psymtab): Update.
14616
b669c953
TT
146172019-01-15 Tom Tromey <tom@tromey.com>
14618
14619 * symtab.c (lookup_objfile_from_block)
14620 (lookup_symbol_in_objfile_symtabs)
14621 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14622 (find_line_symtab, info_sources_command)
14623 (default_collect_symbol_completion_matches_break_on)
14624 (make_source_files_completion_list): Update.
14625 * symmisc.c (print_objfile_statistics, dump_objfile)
14626 (maintenance_print_symbols, maintenance_info_symtabs)
14627 (maintenance_check_symtabs, maintenance_info_line_tables):
14628 Update.
14629 * source.c (select_source_symtab)
14630 (forget_cached_source_info_for_objfile): Update.
14631 * objfiles.h (class objfile_compunits): Remove.
14632 (struct objfile) <compunits_range>: New typedef.
14633 (compunits): New method.
14634 * objfiles.c (objfile_relocate1): Update.
14635 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14636 * maint.c (count_symtabs_and_blocks): Update.
14637 * linespec.c (iterate_over_all_matching_symtabs): Update.
14638 * cp-support.c (add_symbol_overload_list_qualified): Update.
14639 * coffread.c (coff_symtab_read): Update.
14640 * ada-lang.c (add_nonlocal_symbols)
14641 (ada_collect_symbol_completion_matches)
14642 (ada_add_global_exceptions): Update.
14643
7e955d83
TT
146442019-01-15 Tom Tromey <tom@tromey.com>
14645
14646 * progspace.h (program_space) <objfiles_safe_range>: New
14647 typedef.
14648 <objfiles_safe>: New method.
14649 * objfiles.h (class all_objfiles_safe): Remove.
14650 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14651 * jit.c (jit_inferior_exit_hook): Update.
14652
2030c079
TT
146532019-01-17 Tom Tromey <tom@tromey.com>
14654
14655 * progspace.h (program_space) <objfiles_range>: New typedef.
14656 <objfiles>: New method.
14657 <objfiles_head>: Rename from objfiles.
14658 (object_files): Update.
14659 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14660 * guile/scm-pretty-print.c
14661 (ppscm_find_pretty_printer_from_objfiles): Update.
14662 * guile/scm-objfile.c (gdbscm_objfiles): Update.
14663 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14664 Update.
14665 * python/py-progspace.c (pspy_get_objfiles): Update.
14666 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14667 Update.
14668 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14669 (objfpy_lookup_objfile_by_build_id): Update.
14670 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14671 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14672 Update.
14673 * symtab.c (iterate_over_symtabs, matching_obj_sections)
14674 (expand_symtab_containing_pc, lookup_objfile_from_block)
14675 (lookup_static_symbol, basic_lookup_transparent_type)
14676 (find_pc_sect_compunit_symtab, find_symbol_at_address)
14677 (find_line_symtab, info_sources_command)
14678 (default_collect_symbol_completion_matches_break_on)
14679 (make_source_files_completion_list, find_main_name): Update.
14680 * symmisc.c (print_symbol_bcache_statistics)
14681 (print_objfile_statistics, maintenance_print_symbols)
14682 (maintenance_print_msymbols, maintenance_print_objfiles)
14683 (maintenance_info_symtabs, maintenance_check_symtabs)
14684 (maintenance_expand_symtabs, maintenance_info_line_tables):
14685 Update.
14686 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14687 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14688 (map_overlay_command, unmap_overlay_command)
14689 (simple_overlay_update, expand_symtabs_matching)
14690 (map_symbol_filenames): Update.
14691 * symfile-debug.c (set_debug_symfile): Update.
14692 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14693 Update.
14694 * source.c (select_source_symtab, forget_cached_source_info):
14695 Update.
14696 * solib.c (solib_read_symbols): Update.
14697 * solib-spu.c (append_ocl_sos): Update.
14698 * psymtab.c (maintenance_print_psymbols)
14699 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14700 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14701 * printcmd.c (info_symbol_command): Update.
14702 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14703 Update.
14704 * objfiles.h (class all_objfiles): Remove.
14705 * objfiles.c (have_partial_symbols, have_full_symbols)
14706 (have_minimal_symbols, qsort_cmp, update_section_map)
14707 (shared_objfile_contains_address_p)
14708 (default_iterate_over_objfiles_in_search_order): Update.
14709 * objc-lang.c (info_selectors_command, info_classes_command)
14710 (find_methods): Update.
14711 * minsyms.c (find_solib_trampoline_target): Update.
14712 * maint.c (maintenance_info_sections)
14713 (maintenance_translate_address, count_symtabs_and_blocks):
14714 Update.
14715 * main.c (captured_main_1): Update.
14716 * linux-thread-db.c (try_thread_db_load_from_pdir)
14717 (has_libpthread): Update.
14718 * linespec.c (iterate_over_all_matching_symtabs)
14719 (search_minsyms_for_name): Update.
14720 * jit.c (jit_find_objf_with_entry_addr): Update.
14721 * hppa-tdep.c (find_unwind_entry)
14722 (hppa_lookup_stub_minimal_symbol): Update.
14723 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14724 Update.
14725 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14726 (elf_gnu_ifunc_resolve_by_got): Update.
14727 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14728 * dwarf-index-write.c (save_gdb_index_command): Update.
14729 * cp-support.c (add_symbol_overload_list_qualified): Update.
14730 * breakpoint.c (create_overlay_event_breakpoint)
14731 (create_longjmp_master_breakpoint)
14732 (create_std_terminate_master_breakpoint)
14733 (create_exception_master_breakpoint): Update.
14734 * blockframe.c (find_pc_partial_function): Update.
14735 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14736 (ada_collect_symbol_completion_matches)
14737 (ada_add_global_exceptions): Update.
14738
776489e0
TT
147392019-01-17 Tom Tromey <tom@tromey.com>
14740
14741 * solib-target.c (lm_info_target_p): Remove typedef. Don't
14742 declare VEC.
14743 (solib_target_parse_libraries): Change return type.
14744 (library_list_start_segment, library_list_start_section)
14745 (library_list_end_library, library_list_start_library); Update.
14746 (solib_target_free_library_list): Remove.
14747 (solib_target_parse_libraries): Remove cleanup. Change return
14748 type.
14749 (solib_target_current_sos): Update.
14750
6471e7d2
TT
147512019-01-17 Tom Tromey <tromey@bapiya>
14752
14753 * valprint.c: Replace "the the" with "the".
14754 * symtab.c: Replace "the the" with "the".
14755 * solib.c: Replace "the the" with "the".
14756 * solib-dsbt.c: Replace "the the" with "the".
14757 * linespec.c: Replace "the the" with "the".
14758 * dwarf2loc.h: Replace "the the" with "the".
14759 * amd64-windows-tdep.c: Replace "the the" with "the".
14760 * aarch64-tdep.c: Replace "the the" with "the".
14761
c24bdb02
KS
147622019-01-16 Keith Seitz <keiths@redhat.com>
14763
14764 PR gdb/23773
14765 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14766 <builder>: Rename to ..
14767 <m_builder>: ... this and make private.
14768 (dwarf2_cu::get_builder): New method. Change all users of
14769 `builder' to use this method.
14770 (dwarf2_start_symtab): Move to ...
14771 (dwarf2_cu::start_symtab): ... here. Update all callers
14772 (setup_type_unit_groups): Move to ...
14773 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
14774 callers.
14775 (dwarf2_cu::reset_builder): New method.
14776 (process_full_compunit, process_full_type_unit): Use
14777 dwarf2_cu::reset_builder.
14778 (follow_die_offset): Record the ancestor CU if it is different
14779 from the followed DIE's CU.
14780 (follow_die_sig_1): Likewise.
14781
8d64371b
TT
147822019-01-15 Tom Tromey <tom@tromey.com>
14783
14784 * remote.c (class remote_state) <buf>: Now a char_vector.
14785 <buf_size>: Remove.
14786 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
14787 parameter.
14788 (remote_target::getpkt_or_notif_sane_1)
14789 (remote_target::getpkt_sane)
14790 (remote_target::getpkt_or_notif_sane): Likewise.
14791 (class remote_target) <putpkt>: New overload.
14792 (remote_target::read_frame): Change type of "buf_p". Remove
14793 sizeof_p parameter.
14794 (packet_ok): New overload.
14795 (packet_check_result): New overload.
14796 Update all uses.
14797
bb277751
TT
147982019-01-14 Tom Tromey <tom@tromey.com>
14799
14800 * remote-notif.c (handle_notification, remote_notif_ack)
14801 (remote_notif_parse): Make "buf" const.
14802 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14803 const.
14804 (remote_notif_parse, remote_notif_ack, handle_notification):
14805 Likewise.
14806 * remote.c (remote_notif_stop_parse): Make "buf" const.
14807 (remote_target::remote_parse_stop_reply): Make "buf" const.
14808 (remote_notif_stop_ack): Make "buf" const.
14809
05be00a8
TT
148102019-01-14 Tom Tromey <tom@tromey.com>
14811
14812 * remote.c (remote_console_output): Make parameter const.
14813
491adeca
TT
148142019-01-14 Tom Tromey <tom@tromey.com>
14815
14816 * target-debug.h (target_debug_print_signals): Constify.
14817 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14818 * procfs.c (procfs_target::pass_signals): Update.
14819 * linux-nat.c (linux_nat_target::pass_signals): Update.
14820 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14821 * target-delegates.c: Rebuild.
14822 * remote.c (remote_target::program_signals): Update.
14823 (remote_target::pass_signals): Update.
14824 * target.c (target_pass_signals): Constify argument.
14825 (target_program_signals): Likewise.
14826 * target.h (struct target_ops) <pass_signals, program_signals>:
14827 Constify argument.
14828 (target_pass_signals, target_program_signals): Constify argument.
14829
bbd94648
TT
148302019-01-14 Tom Tromey <tom@tromey.com>
14831
14832 PR tui/28819:
14833 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14834
6f072a10
PFC
148352019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
14836
14837 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14838 field.
14839 * rs6000-tdep.c: Include reggroups.h.
14840 (IS_V_ALIAS_PSEUDOREG): Define.
14841 (rs6000_register_name): Return names for the "vX" aliases.
14842 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14843 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
14844 aliases. Call default_register_reggroup_p for all other
14845 pseudo-registers.
14846 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14847 New functions.
14848 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14849 Handle "vX" aliases.
14850 (v_alias_pseudo_register_collect): New function.
14851 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14852 (rs6000_gdbarch_init): Initialize "vX" aliases as
14853 pseudo-registers. Restore registration of
14854 rs6000_pseudo_register_reggroup_p with
14855 set_tdesc_pseudo_register_reggroup_p.
14856
1a782351
MF
148572019-01-13 Max Filippov <jcmvbkbc@gmail.com>
14858
14859 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14860 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14861 set_gdbarch_num_pseudo_regs.
14862
d73cff18
PW
148632019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14864
14865 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14866 Remove arg prefixname, add do_set and do_show.
14867 Add member functions set_list and show_list.
14868 * cli/cli-style.c (class cli_style_option): Update accordingly.
14869 (style_set_list): Move to file scope.
14870 (style_show_list): Likewise.
14871 (set_style): Call help_list.
14872 (show_style): Call cmd_show_list.
14873 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14874 Update to use the new macro.
14875
60a90376
JB
148762019-10-12 Joel Brobecker <brobecker@adacore.com>
14877
14878 * ada-lang.c (_initialize_ada_language): Expand the help text
14879 for the "catch exception" command.
14880
9d7c67bf
PW
148812019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14882
14883 * symtab.c (matching_obj_sections): Initialize obj,
14884 declare it closer to its usage.
14885
7cf47dc4
TT
148862019-01-10 Tom Tromey <tom@tromey.com>
14887
14888 * thread-iter.h (inf_threads_iterator): Use next_iterator.
14889 (basic_inf_threads_range): Remove.
14890 (inf_threads_range, inf_non_exited_threads_range)
14891 (safe_inf_threads_range): Use next_adapter.
14892
d3cb6808
KS
148932019-01-10 Keith Seitz <keiths@redhat.com>
14894
14895 PR gdb/23712
14896 PR symtab/23010
14897 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14898 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14899
63a20375
KS
149002019-01-10 Keith Seitz <keiths@redhat.com>
14901
14902 PR gdb/23712
14903 PR symtab/23010
14904 * dictionary.c (pending_to_vector): Remove.
14905 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14906 Remove _1 suffix, replacing functions of the same name. Update
14907 all callers.
14908 (dict_create_hashed, dict_create_hashed_expandable)
14909 (dict_create_linear, dict_create_linear_expandable, dict_free)
14910 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14911 Make functions static.
14912
b026f593
KS
149132019-01-10 Keith Seitz <keiths@redhat.com>
14914
14915 PR gdb/23712
14916 PR symtab/23010
14917 * dictionary.h (struct dictionary): Replace declaration with
14918 multidictionary.
14919 (dict_create_hashed, dict_create_hashed_expandable)
14920 (dict_create_linear, dict_create_linear_expandable)
14921 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14922 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14923 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14924 taking multidictionary argument.
14925 [ALL_DICT_SYMBOLS]: Update for multidictionary.
14926 * block.h (struct block) <dict>: Change to multidictionary
14927 and rename `multidict'.
14928 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14929 symmisc.c: Update all dictionary references to multidictionary.
14930
c7748ee9
KS
149312019-01-10 Keith Seitz <keiths@redhat.com>
14932
14933 PR gdb/23712
14934 PR symtab/23010
14935 * dictionary.c: Include unordered_map.
14936 (pending_to_vector): New function.
14937 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14938 Rewrite the non-"_1" functions to take vector instead
14939 of linked list.
14940 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14941 "new" _1 versions of the same name.
14942 (multidictionary): Define.
14943 (std::hash<enum language): New definition.
14944 (collate_pending_symbols_by_language, mdict_create_hashed)
14945 (mdict_create_hashed_expandable, mdict_create_linear)
14946 (mdict_create_linear_expandable, mdict_free)
14947 (find_language_dictionary, create_new_language_dictionary)
14948 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14949 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14950 (mdict_size, mdict_empty): New functions.
14951 * dictionary.h (mdict_iterator): Define.
14952
67aa1f3c
PA
149532019-01-10 Pedro Alves <palves@redhat.com>
14954
14955 * breakpoint.c (read_uploaded_action)
14956 (create_tracepoint_from_upload): Adjust to use
14957 gdb::unique_xmalloc_ptr.
14958 * ctf.c (ctf_write_uploaded_tp):
14959 (SET_ARRAY_FIELD): Use emplace_back.
14960 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14961 * tracefile-tfile.c (tfile_write_uploaded_tp):
14962 * tracepoint.c (parse_tracepoint_definition): Adjust to use
14963 gdb::unique_xmalloc_ptr.
14964 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14965 at_string, cond_string, cmd_strings>: Replace char pointers
14966 with gdb::unique_xmalloc_ptr.
14967
2f667667
PA
149682019-01-10 Pedro Alves <palves@redhat.com>
14969
14970 * solib-target.c (library_list_start_library): Don't xstrdup name.
14971
36cb7237
PA
149722019-01-10 Pedro Alves <palves@redhat.com>
14973
14974 * mdebugread.c (parse_partial_symbols): Use
14975 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14976
da584958
AB
149772019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
14978
14979 * linux-fork.c (scoped_switch_fork_info)
14980 <~scoped_switch_fork_info>: Fix incorrect variable name.
14981
1ef8573c
AB
149822019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
14983
14984 * linux-fork.c (scoped_switch_fork_info)
14985 <scoped_switch_fork_info>: Make explicit.
14986 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14987
8d7bcccb
TT
149882019-01-10 Tom Tromey <tom@tromey.com>
14989
14990 * objfiles.h (objfile::reset_psymtabs): Update.
14991 * objfiles.c (objfile::objfile): Update.
14992 * psymtab.h (psymtab_storage::obstack): Update.
14993 (psymtab_storage::m_obstack): Use gdb::optional.
14994 (class psymtab_storage): Update comment. Remove objfile
14995 parameter.
14996 * psymtab.c (psymtab_storage::psymtab_storage): Update.
14997
b596a3c7
TT
149982019-01-10 Tom Tromey <tom@tromey.com>
14999
15000 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15001 <free_psymtabs>: Now private.
15002 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15003 (allocate_psymtab): Use new method.
15004
a9342b62
TT
150052019-01-10 Tom Tromey <tom@tromey.com>
15006
15007 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15008 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15009 * mdebugread.c (parse_partial_symbols): Use
15010 allocate_dependencies.
15011 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15012 allocate_dependencies.
15013 (process_psymtab_comp_unit_reader)
15014 (build_type_psymtab_dependencies): Likewise.
15015 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15016
5af70966
TT
150172019-01-10 Tom Tromey <tom@tromey.com>
15018
15019 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15020 PSYMBOL_SET_LANGUAGE.
15021 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15022
5923a04c
TT
150232019-01-10 Tom Tromey <tom@tromey.com>
15024
15025 * psymtab.h (psymtab_storage::obstack): New method.
15026 <m_obstack>: Rename from obstack; now private.
15027 * psymtab.c (psymtab_storage): Update.
15028 * dwarf2read.c (create_addrmap_from_index)
15029 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15030 Update.
15031
6d6a12bf
TT
150322019-01-10 Tom Tromey <tom@tromey.com>
15033
15034 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15035 * objfiles.h (objfile::reset_psymtabs): New method.
15036
d320c2b5
TT
150372019-01-10 Tom Tromey <tom@tromey.com>
15038
15039 * symmisc.c (print_symbol_bcache_statistics): Update.
15040 (print_objfile_statistics): Update.
15041 * symfile.c (reread_symbols): Update.
15042 * psymtab.h (class psymtab_storage): New.
15043 * psymtab.c (psymtab_storage): New constructor.
15044 (~psymtab_storage): New destructor.
15045 (require_partial_symbols): Update.
15046 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15047 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15048 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15049 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15050 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15051 (start_psymtab_common, end_psymtab_common)
15052 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15053 (allocate_psymtab): Update.
15054 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15055 Update.
15056 (dump_psymtab_addrmap, maintenance_print_psymbols)
15057 (maintenance_check_psymtabs): Update.
15058 (class objfile_psymtabs): Move to objfiles.h.
15059 * psympriv.h (discard_psymtab): Now inline.
15060 (psymtab_discarder::psymtab_discarder): Update.
15061 (psymtab_discarder::~psymtab_discarder): Update.
15062 (ALL_OBJFILE_PSYMTABS): Rewrite.
15063 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15064 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15065 Remove fields.
15066 <partial_symtabs>: New field.
15067 (class objfile_psymtabs): Move from psymtab.h. Update.
15068 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15069 psymbol_cache.
15070 (objfile::~objfile): Don't destroy psymbol_cache.
15071 * mdebugread.c (parse_partial_symbols): Update.
15072 * dwarf2read.c (create_addrmap_from_index)
15073 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15074 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15075 (add_partial_subprogram, dwarf2_ranges_read): Update.
15076 * dwarf-index-write.c (write_address_map)
15077 (write_one_signatured_type, recursively_write_psymbols)
15078 (class debug_names, class debug_names, write_psymtabs_to_index):
15079 Update.
15080
1d94a5a3
TT
150812019-01-10 Tom Tromey <tom@tromey.com>
15082
15083 * symtab.h (SYMBOL_SET_NAMES): Update.
15084 (symbol_set_names): Update.
15085 (MSYMBOL_SET_NAMES): Update.
15086 * symtab.c (symbol_set_names): Change argument to be an
15087 objfile_per_bfd_storage.
15088 * psymtab.c (add_psymbol_to_bcache): Update.
15089 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15090
0f14768a
TT
150912019-01-10 Tom Tromey <tom@tromey.com>
15092
15093 * symtab.c (create_demangled_names_hash): Change argument to be an
15094 objfile_per_bfd_storage.
15095 (symbol_set_names): Update.
15096
6eee24ce
TT
150972019-01-10 Tom Tromey <tom@tromey.com>
15098
15099 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15100 init_psymbol_list.
15101 * psymtab.c (init_psymbol_list): Do nothing if already called.
15102 * psympriv.h (init_psymbol_list): Add comment.
15103 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15104 init_psymbol_list.
15105 * dbxread.c (dbx_symfile_read): Unconditionally call
15106 init_psymbol_list.
15107
75aedd27
TT
151082019-01-10 Tom Tromey <tom@tromey.com>
15109
15110 * xcoffread.c (scan_xcoff_symtab): Update.
15111 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15112 "where".
15113 * mdebugread.c (parse_partial_symbols)
15114 (handle_psymbol_enumerators): Update.
15115 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15116 * dbxread.c (read_dbx_symtab): Update.
15117 * psympriv.h (psymbol_placement): New enum.
15118 (add_psymbol_to_list): Update.
15119
939652a5
TT
151202019-01-10 Tom Tromey <tom@tromey.com>
15121
15122 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15123 static_psymbols parameters.
15124 (scan_xcoff_symtab): Update.
15125 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15126 static_psymbols parameters.
15127 * psympriv.h (start_psymtab_common): Update.
15128 * mdebugread.c (parse_partial_symbols): Update.
15129 * dwarf2read.c (create_partial_symtab): Update.
15130 * dbxread.c (read_dbx_symtab): Update.
15131 (start_psymtab): Remove global_psymbols and static_psymbols
15132 parameters.
15133
baa62830
TT
151342019-01-10 Tom Tromey <tom@tromey.com>
15135
15136 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15137 * psymtab.c (allocate_psymtab): Add comment.
15138 * psympriv.h (allocate_psymtab): Add comment.
15139 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15140 initializations.
15141 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15142
0e8f53ba
TT
151432019-01-10 Tom Tromey <tom@tromey.com>
15144
15145 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15146 Don't declare.
15147 * mipsread.c: Include mdebugread.h.
15148 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15149 Declare.
15150 * elfread.c: Include mdebugread.h.
15151
b22a7c6a
TT
151522019-01-09 Tom Tromey <tom@tromey.com>
15153
15154 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15155 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15156 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15157 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15158 (psym_lookup_symbol, psym_find_last_source_symtab)
15159 (psym_forget_cached_source_info, psym_print_stats)
15160 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15161 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15162 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15163 (psym_find_compunit_symtab_by_address)
15164 (maintenance_print_psymbols, maintenance_info_psymtabs)
15165 (maintenance_check_psymtabs): Use ranged for.
15166 * psymtab.h (class objfile_psymtabs): New.
15167 (require_partial_symbols): Return objfile_psymtabs.
15168 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15169
3b9d3ac2
TT
151702019-01-09 Tom Tromey <tom@tromey.com>
15171
15172 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15173 (find_pc_mapped_section, list_overlays_command)
15174 (map_overlay_command, unmap_overlay_command)
15175 (simple_overlay_update): Use all_objfiles.
15176 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15177 * printcmd.c (info_symbol_command): Use all_objfiles.
15178 * objfiles.h (ALL_OBJSECTIONS): Remove.
15179 * maint.c (maintenance_translate_address): Use all_objfiles.
15180 * gcore.c (gcore_create_callback): Use all_objfiles.
15181 (objfile_find_memory_regions): Likewise.
15182
8b31193a
TT
151832019-01-09 Tom Tromey <tom@tromey.com>
15184
15185 * symtab.c (find_line_symtab, info_sources_command)
15186 (make_source_files_completion_list): Use objfile_compunits.
15187 * source.c (select_source_symtab): Use objfile_compunits.
15188 * objfiles.h (struct objfile): Update comment.
15189 (ALL_OBJFILES): Remove.
15190 (ALL_FILETABS): Remove.
15191 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15192 objfile_compunits.
15193
d5da8b3c
TT
151942019-01-09 Tom Tromey <tom@tromey.com>
15195
15196 * symmisc.c (print_objfile_statistics, dump_objfile)
15197 (maintenance_print_symbols): Use compunit_filetabs.
15198 * source.c (forget_cached_source_info_for_objfile): Use
15199 compunit_filetabs.
15200 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15201 (ALL_FILETABS): Use compunit_filetabs.
15202 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15203 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15204
5accd1a0
TT
152052019-01-09 Tom Tromey <tom@tromey.com>
15206
15207 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15208 (compunit_filetabs): New.
15209 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15210 compunit_filetabs.
15211 (info_sources_command, make_source_files_completion_list): Remove
15212 declaration.
15213 * symmisc.c (print_objfile_statistics, dump_objfile)
15214 (maintenance_print_symbols): Remove declaration.
15215 (maintenance_info_symtabs): Use compunit_filetabs.
15216 (maintenance_info_line_tables): Likewise.
15217 * source.c (select_source_symtab): Change local variable name.
15218 (forget_cached_source_info_for_objfile): Remove declaration.
15219 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15220 * objfiles.c (objfile_relocate1): Remove declaration.
15221 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15222 declaration.
15223 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15224 * coffread.c (coff_symtab_read): Remove declaration.
15225 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15226 compunit_filetabs.
15227
d8aeb77f
TT
152282019-01-09 Tom Tromey <tom@tromey.com>
15229
15230 * symtab.c (lookup_objfile_from_block)
15231 (find_pc_sect_compunit_symtab, search_symbols)
15232 (default_collect_symbol_completion_matches_break_on): Use
15233 objfile_compunits.
15234 * objfiles.h (ALL_COMPUNITS): Remove.
15235 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15236 * cp-support.c (add_symbol_overload_list_qualified): Use
15237 objfile_compunits.
15238 * ada-lang.c (ada_collect_symbol_completion_matches)
15239 (ada_add_global_exceptions): Use objfile_compunits.
15240
592553c4
TT
152412019-01-09 Tom Tromey <tom@tromey.com>
15242
15243 * source.c (select_source_symtab)
15244 (forget_cached_source_info_for_objfile): Remove declaration.
15245 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15246 declaration.
15247 * maint.c (count_symtabs_and_blocks): Remove declaration.
15248 * cp-support.c (add_symbol_overload_list_qualified): Remove
15249 declaration.
15250 * coffread.c (coff_symtab_read): Remove declaration.
15251 * symtab.c (lookup_symbol_in_objfile_symtabs)
15252 (basic_lookup_transparent_type_1): Use objfile_compunits.
15253 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15254 (info_sources_command, search_symbols)
15255 (default_collect_symbol_completion_matches_break_on)
15256 (make_source_files_completion_list): Remove declaration.
15257 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15258 (ada_collect_symbol_completion_matches)
15259 (ada_add_global_exceptions): Remove declaration.
15260 * linespec.c (iterate_over_all_matching_symtabs): Use
15261 objfile_compunits.
15262 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15263 (class objfile_compunits): New.
15264 (ALL_COMPUNITS): Use objfile_compunits.
15265 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15266 (maintenance_check_symtabs, maintenance_info_line_tables): Use
15267 objfile_compunits.
15268 * objfiles.c (objfile_relocate1): Use objfile_compunits.
15269
5325b9bf
TT
152702019-01-09 Tom Tromey <tom@tromey.com>
15271
15272 * symtab.c (search_symbols)
15273 (default_collect_symbol_completion_matches_break_on): Use
15274 objfile_msymbols.
15275 * ada-lang.c (ada_lookup_simple_minsym)
15276 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15277 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15278 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15279 objfile_msymbols.
15280 * coffread.c (coff_symfile_read): Use objfile_msymbols.
15281 * symmisc.c (dump_msymbols): Use objfile_msymbols.
15282 * objc-lang.c (find_methods): Use objfile_msymbols.
15283 (info_selectors_command, info_classes_command): Likewise.
15284 * stabsread.c (scan_file_globals): Use objfile_msymbols.
15285 * objfiles.h (class objfile_msymbols): New.
15286 (ALL_OBJFILE_MSYMBOLS): Remove.
15287 (ALL_MSYMBOLS): Remove.
15288
cac85af2
TT
152892019-01-09 Tom Tromey <tom@tromey.com>
15290
15291 * common/next-iterator.h (next_adapter): Add Iterator template
15292 parameter.
15293 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15294 (class all_objfiles_safe): New.
15295 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15296 * objfiles.c (put_objfile_before): Update comment.
15297 (add_separate_debug_objfile): Likewise.
15298 (free_all_objfiles): Use all_objfiles_safe.
15299 (objfile_purge_solibs): Likewise.
15300
aed57c53
TT
153012019-01-09 Tom Tromey <tom@tromey.com>
15302
15303 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15304 (expand_symtab_containing_pc, lookup_static_symbol)
15305 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15306 (find_symbol_at_address, find_line_symtab, find_main_name): Use
15307 all_objfiles.
15308 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15309 * breakpoint.c (create_overlay_event_breakpoint)
15310 (create_longjmp_master_breakpoint)
15311 (create_std_terminate_master_breakpoint)
15312 (create_exception_master_breakpoint): Use all_objfiles.
15313 * linux-thread-db.c (try_thread_db_load_from_pdir)
15314 (has_libpthread): Use all_objfiles.
15315 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15316 * linespec.c (iterate_over_all_matching_symtabs)
15317 (search_minsyms_for_name): Use all_objfiles.
15318 * maint.c (maintenance_info_sections): Use all_objfiles.
15319 * main.c (captured_main_1): Use all_objfiles.
15320 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15321 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15322 * guile/scm-pretty-print.c
15323 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15324 * solib-spu.c (append_ocl_sos): Use all_objfiles.
15325 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15326 (maintenance_print_msymbols): Use all_objfiles.
15327 * source.c (select_source_symtab): Use all_objfiles.
15328 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15329 * symfile.c (remove_symbol_file_command)
15330 (expand_symtabs_matching, map_symbol_filenames): Use
15331 all_objfiles.
15332 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15333 all_objfiles.
15334 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15335 * objc-lang.c (find_methods): Use all_objfiles.
15336 * objfiles.c (have_partial_symbols, have_full_symbols)
15337 (have_minimal_symbols, qsort_cmp)
15338 (default_iterate_over_objfiles_in_search_order): Use
15339 all_objfiles.
15340 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15341 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15342 (maintenance_check_psymtabs): Use all_objfiles.
15343 (ALL_PSYMTABS): Remove.
15344 * compile/compile-object-run.c (do_module_cleanup): Use
15345 all_objfiles.
15346 * blockframe.c (find_pc_partial_function): Use all_objfiles.
15347 * cp-support.c (add_symbol_overload_list_qualified): Use
15348 all_objfiles.
15349 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15350 Use all_objfiles.
15351 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15352 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15353 all_objfiles.
15354 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15355 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15356 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15357 Uses all_objfiles.
15358 * solib.c (solib_read_symbols): Use all_objfiles
15359
99d89cde
TT
153602019-01-09 Tom Tromey <tom@tromey.com>
15361
15362 * probe.c (parse_probes_in_pspace): Use all_objfiles.
15363 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15364 all_objfiles.
15365 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15366 * symmisc.c (print_symbol_bcache_statistics)
15367 (print_objfile_statistics, maintenance_print_objfiles)
15368 (maintenance_info_symtabs, maintenance_check_symtabs)
15369 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15370 all_objfiles.
15371 * source.c (forget_cached_source_info): Use all_objfiles.
15372 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15373 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15374 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15375 * objfiles.c (update_section_map): Use all_objfiles.
15376 (shared_objfile_contains_address_p): Likewise.
15377 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15378 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15379
21708325
TT
153802019-01-09 Tom Tromey <tom@tromey.com>
15381
15382 * common/next-iterator.h: New file.
15383 * objfiles.h (class all_objfiles): New.
15384 (struct objfile_iterator): New.
15385
669e09f6
PW
153862019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15387
15388 * NEWS: Move the description of the changed "frame", "select-frame",
15389 and "info frame" commands to the Changed commands section.
15390
041be526
SM
153912019-01-09 Simon Marchi <simon.marchi@ericsson.com>
15392
15393 * gdbtypes.c (check_stub_method_group): Remove handling of old
15394 mangling schemes.
15395 * linespec.c (find_methods): Likewise.
15396 * stabsread.c (read_member_functions): Likewise.
15397 * valops.c (search_struct_method): Likewise.
15398 (value_struct_elt_for_reference): Likewise.
15399 * NEWS: Mention this change.
15400
0e2a2133
AB
154012019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
15402
15403 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15404 print_source_lines.
15405 * source.c (print_source_lines_base): Update line number check.
15406 (print_source_lines): New function.
15407 (source_lines_range::source_lines_range): New function.
15408 * source.h (class source_lines_range): New class.
15409 (print_source_lines): New declaration.
15410
1055a3b4
PW
154112019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15412
15413 * linespec.c (linespec_state_destructor): Free self->canonical_names.
15414
cfeadda5
TT
154152019-01-08 Tom Tromey <tom@tromey.com>
15416 Simon Marchi <simon.marchi@ericsson.com>
15417
15418 PR gdb/24060
15419 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15420 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15421 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15422 * f-exp.y (DOLLAR_VARIABLE): Likewise.
15423 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15424 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15425
583068ca
AB
154262019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15427
15428 * source.c (select_source_symtab): Move header comment to
15429 declaration in source.h.
15430 (forget_cached_source_info_for_objfile): Likewise.
15431 (forget_cached_source_info): Likewise.
15432 (identify_source_line): Likewise.
15433 * source.h (identify_source_line): Move declaration from symtab.h
15434 and add comment from source.c
15435 (print_source_lines): Likewise.
15436 (forget_cached_source_info_for_objfile): Likewise.
15437 (forget_cached_source_info): Likewise.
15438 (select_source_symtab): Likewise.
15439 (enum print_source_lines_flag): Move definition from symtab.h.
15440 * symtab.h (identify_source_line): Move declaration to source.h.
15441 (print_source_lines): Likewise.
15442 (forget_cached_source_info_for_objfile): Likewise.
15443 (forget_cached_source_info): Likewise.
15444 (select_source_symtab): Likewise.
15445 (enum print_source_lines_flag): Move definition to source.h.
15446 * tui/tui-hooks.c: Add 'source.h' include.
15447
ec98a4ad
AB
154482019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15449
15450 * source.c (print_source_lines_base): Handle requests to print
15451 reverse line number sequences, and guard against empty lines
15452 string.
15453
62ea19c1
AB
154542019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15455
15456 * source.c (print_source_lines_base): Fix skip of '\r' if next
15457 character is '\n'.
15458
9d30e1fd
TT
154592019-01-06 Tom Tromey <tom@tromey.com>
15460
15461 * c-exp.y (struct c_parse_state) <macro_original_text,
15462 expansion_obstack>: New member.
15463 (macro_original_text, expansion_obstack): Remove globals.
15464 (scan_macro_expansion, scanning_macro_expansion)
15465 (finished_macro_expansion): Update.
15466 (scan_macro_cleanup): Remove.
15467 (yylex, c_parse): Update.
15468
c65bac38
TT
154692019-01-06 Tom Tromey <tom@tromey.com>
15470
15471 * c-exp.y (struct c_parse_state) <strings>: New member.
15472 (operator_stoken): Update.
15473
02e12e38
TT
154742019-01-06 Tom Tromey <tom@tromey.com>
15475
15476 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
15477 (union type_stack_elt) <typelist_val>: Now a pointer to
15478 std::vector.
15479 (type_stack_cleanup): Don't declare.
15480 (push_typelist): Update.
15481 * parse.c (pop_typelist): Return a std::vector.
15482 (push_typelist): Take a std::vector.
15483 (follow_types): Update. Do not free args.
15484 (type_stack_cleanup): Remove.
15485 * c-exp.y (struct c_parse_state): New.
15486 (cpstate): New global.
15487 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15488 (nonempty_typelist): Update.
15489 (func_mod): Create a new vector.
15490 (c_parse): Create a c_parse_state.
15491 (check_parameter_typelist): Do not delete params.
15492 (function_method): Update. Do not delete type_list.
15493
f097f5ad
TT
154942019-01-06 Tom Tromey <tom@tromey.com>
15495
15496 PR gdb/28155:
15497 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15498 check_typedef.
15499 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15500 (print_return_value): Likewise.
15501
d2adf9f1
TT
155022019-01-05 Tom Tromey <tom@tromey.com>
15503
15504 * contrib/cleanup_check.py: Remove.
15505 * contrib/gcc-with-excheck: Remove.
15506 * contrib/exsummary.py: Remove.
15507 * contrib/excheck.py: Remove.
15508
2eab46b1
JB
155092019-01-05 Joel Brobecker <brobecker@adacore.com>
15510
15511 * thread.c (delete_thread_1): Add gdb_assert that THR is not
15512 NULL. Initialize tpprev to NULL instead of assigning it
15513 to NULL on the next statement.
15514 * windows-nat.c (windows_delete_thread): Remove check for
15515 main_thread_id before printing thread exit notifications.
15516 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15517 Remove thread ID check against main_thread_id.
15518 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15519 windows_delete_thread.
15520 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15521
48c5e7e2
TT
155222019-01-04 Tom Tromey <tom@tromey.com>
15523
15524 * compile/compile.c (_initialize_compile): Use upper case for
15525 metasyntactic variables.
15526 * symmisc.c (_initialize_symmisc): Use upper case for
15527 metasyntactic variables.
15528 * psymtab.c (_initialize_psymtab): Use upper case for
15529 metasyntactic variables.
15530 * demangle.c (demangle_command): Use upper case for metasyntactic
15531 variables.
15532 (_initialize_demangler): Likewise.
15533 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15534 variables.
15535
986041cd
TT
155362019-01-03 Tom Tromey <tom@tromey.com>
15537
15538 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15539
7c711119
TT
155402019-01-03 Tom Tromey <tom@tromey.com>
15541
15542 * python/py-symtab.c (salpy_str): Update.
15543 (struct salpy_sal_object) <symtab>: Now a PyObject.
15544 (salpy_dealloc): Update.
15545 (del_objfile_sal): Use gdbpy_ref.
15546
1b20edf0
TT
155472019-01-03 Tom Tromey <tom@tromey.com>
15548
15549 * python/py-type.c (convert_field): Use new_reference. Return
15550 gdbpy_ref.
15551 (make_fielditem): Return gdbpy_ref.
15552 (typy_fields): Update.
15553 (typy_getitem): Update.
15554 (field_name): Return gdbpy_ref. Use new_reference.
15555 (typy_iterator_iternext): Update.
15556
ea41325b
TT
155572019-01-03 Tom Tromey <tom@tromey.com>
15558
15559 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15560
2a3c71d6
TT
155612019-01-03 Tom Tromey <tom@tromey.com>
15562
15563 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15564 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15565 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15566 (pspy_set_frame_filters, pspy_set_frame_unwinders)
15567 (pspy_set_type_printers): Likewise.
15568 * python/py-function.c (fnpy_init): Use gdbpy_ref.
15569 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15570 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15571 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15572 (objfpy_set_type_printers): Likewise.
15573
5c329e6a
TT
155742019-01-03 Tom Tromey <tom@tromey.com>
15575
15576 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15577 (gdbpy_print_stack): Use gdbpy_err_fetch.
15578 * python/python-internal.h (class gdbpy_err_fetch): New class.
15579 (class gdbpy_enter) <m_error_type, m_error_value,
15580 m_error_traceback>: Remove.
15581 <m_error>: New member.
15582 (gdbpy_exception_to_string): Don't declare.
15583 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15584 * python/py-value.c (convert_value_from_python): Use
15585 gdbpy_err_fetch.
15586 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15587 gdbpy_exception_to_string.
15588 (gdbpy_handle_exception): Use gdbpy_err_fetch.
15589 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15590 gdbpy_err_fetch.
15591
169bb27b
AB
155922019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15593
15594 * linux-nat.c (delete_lwp_cleanup): Delete.
15595 (struct lwp_deleter): New struct.
15596 (lwp_info_up): New typedef.
15597 (linux_nat_target::follow_fork): Delete cleanup, and make use of
15598 lwp_info_up.
15599
a07c8880
AB
156002019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15601
15602 * linux-fork.c (class scoped_switch_fork_info): New class.
15603 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15604
26089c49
AB
156052019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15606
15607 * valops.c (find_overload_match): Remove use of null_cleanup, and
15608 calls to do_cleanups.
15609
06d3e5b0
AB
156102019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15611
15612 * compile/compile-cplus-types.c
15613 (compile_cplus_instance::decl_name): Handle changes to
15614 cp_func_name.
15615 * cp-support.c (cp_func_name): Update header comment, update
15616 return type.
15617 * cp-support.h (cp_func_name): Update return type in declaration.
15618 * valops.c (find_overload_match): Move temp_func local to top
15619 level of function and change its type. Use temp_func to hold and
15620 delete temporary string obtained from cp_func_name.
15621
66644cd3
AB
156222019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15623
15624 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15625 gdb::char_vector, remove cleanup, and update uses of `msg`.
15626
592d8c0a
JW
156272019-01-03 Jim Wilson <jimw@sifive.com>
15628
15629 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15630
c55d06ec
TT
156312019-01-02 Tom Tromey <tom@tromey.com>
15632
15633 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15634 (tdesc_parse_xml): Remove cleanups.
15635 * target-descriptions.h (make_cleanup_free_target_description):
15636 Don't declare.
15637 (target_desc_deleter): New struct.
15638 (target_desc_up): New typedef.
15639 * target-descriptions.c (target_desc_deleter::operator()): Rename
15640 from free_target_description.
15641 (make_cleanup_free_target_description): Remove.
15642
3a6ae42d
TT
156432019-01-02 Tom Tromey <tom@tromey.com>
15644
15645 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
15646 constructor, destructor.
15647 (linespec_parser): Remove typedef.
15648 (~linespec_parser): Rename from linespec_parser_delete.
15649 (linespec_lex_to_end, linespec_complete_label)
15650 (linespec_complete): Update.
15651 (decode_line_full): Remove cleanups.
15652 (decode_line_1): Update.
15653
61fd3e73
TT
156542019-01-02 Tom Tromey <tom@tromey.com>
15655
15656 * python/python-internal.h (inferior_to_inferior_object): Change
15657 return type.
15658 * python/py-exitedevent.c (create_exited_event_object): Update.
15659 * python/py-inferior.c (inferior_to_inferior_object): Return
15660 gdbpy_ref.
15661 (python_new_inferior, python_inferior_deleted)
15662 (thread_to_thread_object, delete_thread_object)
15663 (build_inferior_list, gdbpy_selected_inferior): Update.
15664 * python/py-infthread.c (create_thread_object): Update. Also fail
15665 if inferior_to_inferior_object fails.
15666
d20172fc
SM
156672019-01-02 Simon Marchi <simon.marchi@ericsson.com>
15668
15669 * inferior.h (class inferior) <displaced_step_state>: New field.
15670 * infrun.h (struct displaced_step_state): Move here from
15671 infrun.c. Initialize fields, add constructor.
15672 <inf>: Remove field.
15673 <reset>: New method.
15674 * infrun.c (struct displaced_step_inferior_state): Move to
15675 infrun.h.
15676 (displaced_step_inferior_states): Remove.
15677 (get_displaced_stepping_state): Adust.
15678 (displaced_step_in_progress_any_inferior): Adjust.
15679 (displaced_step_in_progress_thread): Adjust.
15680 (displaced_step_in_progress): Adjust.
15681 (add_displaced_stepping_state): Remove.
15682 (get_displaced_step_closure_by_addr): Adjust.
15683 (remove_displaced_stepping_state): Remove.
15684 (infrun_inferior_exit): Call displaced_step_state.reset.
15685 (use_displaced_stepping): Don't check for NULL.
15686 (displaced_step_prepare_throw): Call
15687 get_displaced_stepping_state.
15688 (displaced_step_fixup): Don't check for NULL.
15689 (prepare_for_detach): Don't check for NULL.
15690
e3319240
PW
156912019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15692
15693 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15694 in case of call that did not complete.
15695
5d36dfb9
AU
156962019-01-02 Andrey Utkin <autkin@undo.io>
15697
15698 * symfile.c (find_separate_debug_file): Fix search of debug files for
15699 remote debuggee.
15700
8833fbf0
TT
157012019-01-02 Tom Tromey <tom@tromey.com>
15702
15703 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15704 indentation.
15705 * python/py-frame.c (frapy_older): Remove cast.
15706 (frapy_newer): Likewise.
15707 * python/py-breakpoint.c (local_setattro): Remove cast.
15708 * python/py-arch.c (archpy_name): Remove local variable.
15709 * python/py-type.c (gdbpy_lookup_type): Remove cast.
15710
4ada3dfd
JB
157112019-01-02 Joel Brobecker <brobecker@adacore.com>
15712
15713 * unittests/basic_string_view/element_access/char/empty.cc:
15714 Fix year range in copyright header.
15715
113b7b81
AB
157162019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
15717
15718 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15719 Delete.
15720 <operator==>: Update with for removed field.
15721 <hash>: Likewise.
15722 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15723 <isa_features>: ...this.
15724 <abi_features>: New field.
15725 (riscv_isa_flen): Update comment.
15726 (riscv_abi_xlen): New declaration.
15727 (riscv_abi_flen): New declaration.
15728 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15729 isa_features.
15730 (riscv_abi_xlen): New function.
15731 (riscv_isa_flen): Update to get answer from isa_features.
15732 (riscv_abi_flen): New function.
15733 (riscv_has_fp_abi): Update to get answer from abi_features.
15734 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15735 xlen and flen.
15736 (riscv_call_info) <xlen, flen>: Update comment.
15737 (riscv_call_arg_struct): Remove invalid assertions
15738 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15739 is removed.
15740 (riscv_gdbarch_init): Gather isa features and abi features
15741 separately, ensure both match on the gdbarch when reusing an old
15742 gdbarch. Relax an error check to allow 32-bit abi float to run on
15743 a target with 64-bit float hardware.
15744
b18ca514
PW
157452019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15746
15747 * source.c (search_command_helper): Stop reverse search
15748 when line 1 has been searched.
15749
ec70d8db
PW
157502019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15751
15752 * record-full.c (record_full_base_target::close): Rewrite
15753 record_full_core_buf_list free logic.
15754
5b38f9c1
PW
157552019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15756
15757 * break-catch-syscall.c (print_one_catch_syscall): xfree
15758 the last text.
15759
66d91b39
JB
157602019-01-01 Joel Brobecker <brobecker@adacore.com>
15761
15762 * top.c (print_gdb_version): Update Copyright year in version
15763 message.
15764
42a4f53d
JB
157652019-01-01 Joel Brobecker <brobecker@adacore.com>
15766
15767 Update copyright year range in all GDB files.
15768
7e955d83 157692019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 15770
5bbd631d 15771 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 15772
5bbd631d 15773For older changes see ChangeLog-2018.
c906108c
SS
15774\f
15775Local Variables:
15776mode: change-log
15777left-margin: 8
15778fill-column: 74
15779version-control: never
57da7796 15780coding: utf-8
c906108c 15781End:
5bbd631d 15782
This page took 3.006817 seconds and 4 git commands to generate.