libctf, link: redo cu-mapping handling
[deliverable/binutils-gdb.git] / libctf / ChangeLog
CommitLineData
5f54462c
NA
12020-07-22 Nick Alcock <nick.alcock@oracle.com>
2
3 * ctf-impl.h (ctf_file_t): Improve comments.
4 <ctf_link_cu_mapping>: Split into...
5 <ctf_link_in_cu_mapping>: ... this...
6 <ctf_link_out_cu_mapping>: ... and this.
7 * ctf-create.c (ctf_serialize): Adjust.
8 * ctf-open.c (ctf_file_close): Likewise.
9 * ctf-link.c (ctf_create_per_cu): Look things up in the
10 in_cu_mapping instead of the cu_mapping.
11 (ctf_link_add_cu_mapping): The deduplicating link will define
12 what happens if many FROMs share a TO.
13 (ctf_link_add_cu_mapping): Create in_cu_mapping and
14 out_cu_mapping. Do not create ctf_link_outputs here any more, or
15 create per-CU dicts here: they are already created when needed.
16 (ctf_link_one_variable): Log a debug message if we skip a
17 variable due to its type being concealed in a CU-mapped link.
18 (This is probably too common a case to make into a warning.)
19 (ctf_link): Create empty per-CU dicts if requested.
20
e3f17159
NA
212020-07-22 Nick Alcock <nick.alcock@oracle.com>
22
23 * ctf-link.c (ctf_link_write): Close the fd.
24
8d2229ad
NA
252020-07-22 Nick Alcock <nick.alcock@oracle.com>
26
27 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
28 * Makefile.in: Regenerated.
29 * ctf-impl.h (ctf_link_input_name): New.
30 (ctf_file_t) <ctf_link_flags>: New.
31 * ctf-create.c (ctf_serialize): Adjust accordingly.
32 * ctf-link.c: Define ctf_open as weak when PIC.
33 (ctf_arc_close_thunk): Remove unnecessary thunk.
34 (ctf_file_close_thunk): Likewise.
35 (ctf_link_input_name): New.
36 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
37 (ctf_link_input_close): Adjust accordingly.
38 (ctf_link_add_ctf_internal): New, split from...
39 (ctf_link_add_ctf): ... here. Return error if lazy loading of
40 CTF is not possible. Change to just call...
41 (ctf_link_add): ... this new function.
42 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
43 ctf_file_close_thunk.
44 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
45 <in_file_name>: ... this.
46 <arcname>: Drop.
47 <share_mode>: Likewise (migrated to ctf_link_flags).
48 <done_main_member>: Rename to...
49 <done_parent>: ... this.
50 <main_input_fp>: Rename to...
51 <in_fp_parent>: ... this.
52 <cu_mapped>: New.
53 (ctf_link_one_type): Adjuwt accordingly. Transition to
54 ctf_err_warn, removing a TODO.
55 (ctf_link_one_variable): Note a case too common to warn about.
56 Report in the debug stream if a cu-mapped link prevents addition
57 of a conflicting variable.
58 (ctf_link_one_input_archive_member): Adjust.
59 (ctf_link_lazy_open): New, open a CTF archive for linking when
60 needed.
61 (ctf_link_close_one_input_archive): New, close it again.
62 (ctf_link_one_input_archive): Adjust for lazy opening, member
63 renames, and ctf_err_warn transition. Move the
64 empty_link_type_mapping call to...
65 (ctf_link): ... here. Adjut for renamings and thunk removal.
66 Don't spuriously fail if some input contains no CTF data.
67 (ctf_link_write): ctf_err_warn transition.
68 * libctf.ver: Remove not-yet-stable comment.
69
e148b730
NA
702020-07-22 Nick Alcock <nick.alcock@oracle.com>
71
72 * ctf-impl.h (ctf_strerror): Delete.
73 * ctf-subr.c (ctf_strerror): Likewise.
74 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
75 strerror directly.
76
1fa7a0c2
NA
772020-07-22 Nick Alcock <nick.alcock@oracle.com>
78
79 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
80 (ctf_import_unref): New.
81 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
82 zero. Don't recurse back in if the refcount is already zero.
83 (ctf_import): Check ctf_parent_unreffed before deciding whether
84 to close a pre-existing parent. Set it to zero.
85 (ctf_import_unreffed): New, as above, setting
86 ctf_parent_unreffed to 1.
87 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
88 child: use direct assignment, and set unreffed on the new and
89 old children.
90 * ctf-link.c (ctf_create_per_cu): Import the parent using
91 ctf_import_unreffed.
92
3166467b
NA
932020-07-22 Nick Alcock <nick.alcock@oracle.com>
94
95 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
96 (ctf_link_type_key): ... this, adjusting member prefixes to
97 match.
98 (ctf_hash_type_mapping_key): Rename to...
99 (ctf_hash_type_key): ... this.
100 (ctf_hash_eq_type_mapping_key): Rename to...
101 (ctf_hash_eq_type_key): ... this.
102 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
103 (ctf_hash_type_key): ... this, and adjust for member name
104 changes.
105 (ctf_hash_eq_type_mapping_key): Rename to...
106 (ctf_hash_eq_type_key): ... this, and adjust for member name
107 changes.
108 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
109 need for out-of-memory checking in this code.
110 (ctf_type_mapping): Adjust.
111
43a61d7d
NA
1122020-07-22 Nick Alcock <nick.alcock@oracle.com>
113
114 configure.ac: Check for vasprintf.
115 configure: Regenerated.
116 config.h.in: Likewise.
117
ac2ff760
NA
1182020-07-22 Nick Alcock <nick.alcock@oracle.com>
119
120 * ctf-archive.c (ctf_arc_bufopen): Fix message.
121
d50c0802
NA
1222020-07-22 Nick Alcock <nick.alcock@oracle.com>
123
124 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
125 New.
126 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
127 if the input has no symtab, rather than dividing by
128 zero. Arrange to free it later via ctfi_free_ctfsect.
129 * ctf-archive.c (ctf_new_archive_internal): Do not
130 ctfi_free_strsect by default.
131 (ctf_arc_close): Possibly free it here.
132
70447401
NA
1332020-07-22 Nick Alcock <nick.alcock@oracle.com>
134
135 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
136 (ctf_dump_format_type): improve slice formatting. Always print
137 the type size, even of slices.
138 (ctf_dump_member): Print slices (-> bitfields) differently from
139 non-slices. Failure to format a type is not an OOM.
140
8e795b46
NA
1412020-07-22 Nick Alcock <nick.alcock@oracle.com>
142
143 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
144 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
145 (ctf_dump_objts): Likewise.
146 (ctf_dump_var): Likewise.
147 (ctf_dump_type): Do not emit a duplicate message. Move to
148 ctf_err_warning, and swallow all errors.
149
b255b35f
NA
1502020-07-22 Nick Alcock <nick.alcock@oracle.com>
151
152 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
153 (ctf_decl_buf): Once it escapes, don't try to free it later.
154
c6e9a1e5
NA
1552020-07-22 Nick Alcock <nick.alcock@oracle.com>
156
157 * ctf-types.c (ctf_type_aname): Print arg types here...
158 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
159 in the type name here.
160
8b37e7b6
NA
1612020-07-22 Nick Alcock <nick.alcock@oracle.com>
162
163 * ctf-impl.h (ctf_assert): New.
164 (ctf_err_warning_t): Likewise.
165 (ctf_file_t) <ctf_errs_warnings>: Likewise.
166 (ctf_err_warn): New prototype.
167 (ctf_assert_fail_internal): Likewise.
168 * ctf-inlines.h (ctf_assert_internal): Likewise.
169 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
170 * ctf-create.c (ctf_serialize): Copy it on serialization.
171 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
172 (ctf_errwarning_next): New iterator, free and pass back
173 errors/warnings in succession.
174 * libctf.ver (ctf_errwarning_next): Add.
175
b7190c82
EB
1762020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
177
178 * ctf-types.c (ctf_variable_iter): Fix error return.
179
ec388c16
NA
1802020-07-22 Nick Alcock <nick.alcock@oracle.com>
181
182 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
183
67d4cc67
NA
1842020-07-22 Nick Alcock <nick.alcock@oracle.com>
185
186 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
187
e28591b3
NA
1882020-07-22 Nick Alcock <nick.alcock@oracle.com>
189
190 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
191 sorting functions.
192 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
193 ctf_dynhash_next_sorted.
194 <cu.ctn_h>: New, pointer to the dynhash under iteration.
195 <cu.ctn_s>: New, pointer to the dynset under iteration.
196 (ctf_hash_sort_f): Sorting function passed to...
197 (ctf_dynhash_next_sorted): ... this new function.
198 (ctf_dynhash_next): New.
199 (ctf_dynset_next): New.
200 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
201 (ctf_dynhash_cnext): New.
202 (ctf_dynset_cnext): New.
203 * ctf-hash.c (ctf_dynhash_next_sorted): New.
204 (ctf_dynhash_next): New.
205 (ctf_dynset_next): New.
206 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
207 needed.
208 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
209
688d28f6
NA
2102020-07-22 Nick Alcock <nick.alcock@oracle.com>
211
212 * ctf-impl.h (ctf_next): New.
213 (ctf_get_dict): New prototype.
214 * ctf-lookup.c (ctf_get_dict): New, split out of...
215 (ctf_lookup_by_id): ... here.
216 * ctf-util.c (ctf_next_create): New.
217 (ctf_next_destroy): New.
218 (ctf_next_copy): New.
219 * ctf-types.c (includes): Add <assert.h>.
220 (ctf_member_next): New.
221 (ctf_enum_next): New.
222 (ctf_type_iter): Document the lack of iteration over parent
223 types.
224 (ctf_type_next): New.
225 (ctf_variable_next): New.
226 * ctf-archive.c (ctf_archive_next): New.
227 * libctf.ver: Add new public functions.
228
2399827b
NA
2292020-07-22 Nick Alcock <nick.alcock@oracle.com>
230
231 * libctf.ver (ctf_ref): New.
232 * ctf-open.c (ctf_ref): Implement it.
233
9850ce4d
NA
2342020-07-22 Nick Alcock <nick.alcock@oracle.com>
235
236 * ctf-inlines.h (ctf_forwardable_kind): New.
237 * ctf-create.c (ctf_add_forward): Use it.
238
2c9ca36b
NA
2392020-07-22 Nick Alcock <nick.alcock@oracle.com>
240
241 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
242 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
243
77648241
NA
2442020-07-22 Nick Alcock <nick.alcock@oracle.com>
245
246 * ctf-hash.c (ctf_dynset_eq_string): New.
247 (ctf_dynset_create): New.
248 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
249 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
250 (key_to_internal): New.
251 (internal_to_key): New.
252 (ctf_dynset_insert): New.
253 (ctf_dynset_remove): New.
254 (ctf_dynset_destroy): New.
255 (ctf_dynset_lookup): New.
256 (ctf_dynset_exists): New.
257 (ctf_dynset_lookup_any): New.
258 (ctf_hash_insert_type): Coding style.
259 (ctf_hash_define_type): Likewise.
260 * ctf-impl.h (ctf_dynset_t): New.
261 (ctf_dynset_eq_string): New.
262 (ctf_dynset_create): New.
263 (ctf_dynset_insert): New.
264 (ctf_dynset_remove): New.
265 (ctf_dynset_destroy): New.
266 (ctf_dynset_lookup): New.
267 (ctf_dynset_exists): New.
268 (ctf_dynset_lookup_any): New.
269 * ctf-inlines.h (ctf_dynset_cinsert): New.
270
a49c6c6a
NA
2712020-07-22 Nick Alcock <nick.alcock@oracle.com>
272
273 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
274 <value_free>: Likewise.
275 <owner>: New.
276 (ctf_dynhash_item_free): Indirect through the owner.
277 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
278 allocate space for the key_free and value_free fields fields
279 if necessary.
280 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
281 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
282 value_free if they will exist. Set the slot's owner, but only
283 if it exists.
284 (ctf_dynhash_remove): Adjust.
285
5ceee3db
NA
2862020-07-22 Nick Alcock <nick.alcock@oracle.com>
287
288 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
289 there is a key-freeing function and the key already exists.
290
809f6eb3
NA
2912020-07-22 Nick Alcock <nick.alcock@oracle.com>
292
293 * ctf-inlines.h: New file.
294 * ctf-impl.h: Include it.
295 (ctf_hash_iter_find_f): New typedef.
296 (ctf_dynhash_elements): New.
297 (ctf_dynhash_lookup_kv): New.
298 (ctf_dynhash_iter_find): New.
299 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
300 (ctf_traverse_find_cb_arg_t): New.
301 (ctf_hashtab_traverse_find): New.
302 (ctf_dynhash_iter_find): New.
303 (ctf_dynhash_elements): New.
304
469e75b6
NA
3052020-07-22 Nick Alcock <nick.alcock@oracle.com>
306
307 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
308
9c23dfa5
NA
3092020-07-22 Nick Alcock <nick.alcock@oracle.com>
310
311 * ctf-archive.c (ctf_archive_count): New.
312 * libctf.ver: New public function.
313
e0325e2c
NA
3142020-07-22 Nick Alcock <nick.alcock@oracle.com>
315
316 * ctf-types.c (ctf_member_count): New.
317 * libctf.ver: New public function.
318
9b15cbb7
NA
3192020-07-22 Nick Alcock <nick.alcock@oracle.com>
320
321 * ctf-types.c (ctf_type_kind_forwarded): New.
322
01d93174
NA
3232020-07-22 Nick Alcock <nick.alcock@oracle.com>
324
325 * ctf-types.c (ctf_type_name_raw): New.
326 (ctf_type_aname_raw): Reimplement accordingly.
327
5ec7465f
NA
3282020-07-22 Nick Alcock <nick.alcock@oracle.com>
329
330 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
331
601e455b
NA
3322020-07-22 Nick Alcock <nick.alcock@oracle.com>
333
334 * ctf-impl.h (struct ctf_archive_internal)
335 <ctfi_unmap_on_close>: New.
336 (ctf_new_archive_internal): Adjust.
337 * ctf-archive.c (ctf_new_archive_internal): Likewise.
338 Initialize ctfi_unmap_on_close. Adjust error path.
339 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
340 (unmap_on_close is 0).
341 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
342 * ctf-open-bfd.c (ctf_fdopen): Adjust.
343
96e3ec29
NA
3442020-07-22 Nick Alcock <nick.alcock@oracle.com>
345
346 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
347 ints, floats or typedefs have no name. Fix comment typo.
348
502e838e
NA
3492020-07-22 Nick Alcock <nick.alcock@oracle.com>
350
351 * ctf-create.c (ctf_add_slice): Support slices of any kind that
352 resolves to an integral type.
353 * ctf-types.c (ctf_type_encoding): Resolve the type before
354 fishing its encoding out.
355
dd987f00
NA
3562020-07-22 Nick Alcock <nick.alcock@oracle.com>
357
358 * ctf-create.c (ctf_create): Mark dirty.
359
f47ca311
NA
3602020-07-22 Nick Alcock <nick.alcock@oracle.com>
361
362 * ctf-create.c (membcmp) Skip nameless members.
363
ab769488
NA
3642020-07-22 Nick Alcock <nick.alcock@oracle.com>
365
366 * ctf-create.c (ctf_add_member_offset): Support names of ""
367 as if they were the null pointer.
368
2484ca43
NA
3692020-07-22 Nick Alcock <nick.alcock@oracle.com>
370
371 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
372 special-casing.
373
43706199
NA
3742020-07-22 Nick Alcock <nick.alcock@oracle.com>
375
376 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
377
9943fa3a
NA
3782020-07-22 Nick Alcock <nick.alcock@oracle.com>
379
380 * ctf-create.c (ctf_serialize): Add cast.
381 (ctf_add_slice): Likewise.
382
afd78bd6
NA
3832020-07-22 Nick Alcock <nick.alcock@oracle.com>
384
385 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
386 * ctf-create.c (ctf_add_function): Check for unimplemented type
387 and populate at the same time. Populate one-by-one, not via
388 memcpy.
389 (ctf_serialize): Remove unnecessary cast.
390 * ctf-types.c (ctf_func_type_info): Likewise.
391 (ctf_func_type_args): Likewise. Fix comment typo.
392
2361f1c8
NA
3932020-07-22 Nick Alcock <nick.alcock@oracle.com>
394
395 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
396 (ctf_add_array): Support array contents of type zero.
397 (ctf_add_function): Support arguments and return types of
398 type zero.
399 (ctf_add_typedef): Support typedefs to type zero.
400 (ctf_add_member_offset): Support members of type zero,
401 unless added at unspecified (naturally-aligned) offset.
402
7eea9d3b
NA
4032020-07-22 Nick Alcock <nick.alcock@oracle.com>
404
405 * ctf-error.c: Include <stddef.h>, for offsetof.
406 (_ctf_errlist): Migrate to...
407 (_ctf_errlist_t): ... this.
408 (_ctf_erridx): New, indexes into _ctf_errlist_t.
409 (_ctf_nerr): Remove.
410 (ctf_errmsg): Adjust accordingly.
411 * Makefile.am (BUILT_SOURCES): Note...
412 (ctf-error.h): ... this new rule.
413 * Makefile.in: Regenerate.
414 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
415 * .gitignore: New, ignore ctf-error.h.
416
b64751cf
NA
4172020-07-22 Nick Alcock <nick.alcock@oracle.com>
418
419 * ctf-impl.h: Fix typos in comments.
420
df16e041
NC
4212020-07-22 Nick Clifton <nickc@redhat.com>
422
423 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
424 same file descriptor.
425
b115b9fd
NC
4262020-07-04 Nick Clifton <nickc@redhat.com>
427
428 Binutils 2.35 branch created.
429
8e6635bd
NA
4302020-06-26 Nick Alcock <nick.alcock@oracle.com>
431
432 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
433 alphabetical order.
434 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
435 * config.h.in: Regenerated.
436 * Makefile.in: Likewise.
437 * configure: Likewise.
438
c1401ecc
NA
4392020-06-26 Nick Alcock <nick.alcock@oracle.com>
440
441 * ctf-create.c: Include <unistd.h>.
442 * ctf-open-bfd.c: Likewise.
443
e755667f
NA
4442020-06-26 Nick Alcock <nick.alcock@oracle.com>
445
446 PR libctf/25120
447 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
448 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
449 means this is declared.
450 (bswap_32): Likewise.
451 (bswap_64): Likewise.
452 (bswap_identity_64): Remove, unused.
453 * configure: Regenerated.
454 * config.h.in: Likewise.
455
86670658
NA
4562020-06-26 Nick Alcock <nick.alcock@oracle.com>
457
458 PR libctf/25120
459 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
460 (_libctf_unlikely_): Likewise.
461 (_libctf_unused): Likewise.
462 (_libctf_malloc_): Likewise.
463
2e428e74
NA
4642020-06-26 Nick Alcock <nick.alcock@oracle.com>
465
466 PR libctf/25120
467 * ctf-archive.c (search_nametbl): No longer global: declare...
468 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
469 (search_modent_by_name): Take and use ARG for the nametbl.
470
2f6ecaed
NA
4712020-06-26 Nick Alcock <nick.alcock@oracle.com>
472
473 * ctf-impl.h (ctf_new_archive_internal): Declare.
474 (ctf_arc_bufopen): Remove.
475 (ctf_archive_internal) <ctfi_free_symsect>: New.
476 * ctf-archive.c (ctf_arc_close): Use it.
477 (ctf_arc_bufopen): Fuse into...
478 (ctf_new_archive_internal): ... this, moved across from...
479 * ctf-open-bfd.c: ... here.
480 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
481 * libctf.ver: Add it.
482
8ffcdf18
NA
4832020-06-26 Nick Alcock <nick.alcock@oracle.com>
484
485 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
486 (ctf_dtd_delete): Remove correspondingly.
487 (ctf_rollback): Likewise.
488
d04a47ac
NA
4892020-06-26 Nick Alcock <nick.alcock@oracle.com>
490
491 * ctf-create.c (ctf_add_type_internal): Hand back existing types
492 unchanged.
493
6bbf9da8
NA
4942020-06-26 Nick Alcock <nick.alcock@oracle.com>
495
496 * ctf-create.c (ctf_add_forward): Don't add forwards to
497 types that already exist.
498
fe4c2d55
NA
4992020-06-26 Nick Alcock <nick.alcock@oracle.com>
500
501 * ctf-open.c (init_types): Only intern root-visible types.
502 * ctf-create.c (ctf_dtd_insert): Likewise.
503 (ctf_dtd_delete): Only remove root-visible types.
504 (ctf_rollback): Likewise.
505 (ctf_add_generic): Adjust.
506 (ctf_add_struct_sized): Adjust comment.
507 (ctf_add_union_sized): Likewise.
508 (ctf_add_enum): Likewise.
509 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
510
11978942
JB
5112020-03-11 John Baldwin <jhb@FreeBSD.org>
512
513 * swap.h (bswap_identity_64): Make static.
514
ae774686
NC
5152020-01-18 Nick Clifton <nickc@redhat.com>
516
517 Binutils 2.34 branch created.
518
eb9a7e35 5192020-01-05 Joel Brobecker <brobecker@adacore.com>
3a657c60
EZ
520
521 PR binutils/25155:
522 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
523 * configure, config.h.in: Regenerate.
524
b14ce8bf
AM
5252020-01-01 Alan Modra <amodra@gmail.com>
526
527 Update year range in copyright notice of all files.
528
cbbbc402
SM
5292019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
530
531 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
532
fa56cdcd
NA
5332019-09-30 Nick Alcock <nick.alcock@oracle.com>
534
535 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
536 * ctf-types.c (ctf_type_lname): Likewise.
537
ad613f1d
NA
5382019-09-23 Nick Alcock <nick.alcock@oracle.com>
539
540 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
541 ctf_import after the first for a given file.
542
9323dd86
NA
5432019-09-23 Nick Alcock <nick.alcock@oracle.com>
544
545 * ctf-impl.h (ctf_str_append_noerr): Declare.
546 * ctf-util.c (ctf_str_append_noerr): Define in terms of
547 ctf_str_append.
548 * ctf-dump.c (str_append): New, call it.
549 (ctf_dump_format_type): Use str_append, not ctf_str_append.
550 (ctf_dump_label): Likewise.
551 (ctf_dump_objts): Likewise.
552 (ctf_dump_funcs): Likewise.
553 (ctf_dump_var): Likewise.
554 (ctf_dump_member): Likewise.
555 (ctf_dump_type): Likewise.
556 (ctf_dump): Likewise.
557
de07e349
NA
5582019-09-23 Nick Alcock <nick.alcock@oracle.com>
559
560 * ctf-impl.h (ctf_alloc): Remove.
561 (ctf_free): Likewise.
562 (ctf_strdup): Likewise.
563 * ctf-subr.c (ctf_alloc): Remove.
564 (ctf_free): Likewise.
565 * ctf-util.c (ctf_strdup): Remove.
566
567 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
568 ctf_free; strdup, not ctf_strdup.
569 (ctf_dtd_delete): Likewise.
570 (ctf_dvd_delete): Likewise.
571 (ctf_add_generic): Likewise.
572 (ctf_add_function): Likewise.
573 (ctf_add_enumerator): Likewise.
574 (ctf_add_member_offset): Likewise.
575 (ctf_add_variable): Likewise.
576 (membadd): Likewise.
577 (ctf_compress_write): Likewise.
578 (ctf_write_mem): Likewise.
579 * ctf-decl.c (ctf_decl_push): Likewise.
580 (ctf_decl_fini): Likewise.
581 (ctf_decl_sprintf): Likewise. Check for OOM.
582 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
583 ctf_free; strdup, not ctf_strdup.
584 (ctf_dump_free): Likewise.
585 (ctf_dump): Likewise.
586 * ctf-open.c (upgrade_types_v1): Likewise.
587 (init_types): Likewise.
588 (ctf_file_close): Likewise.
589 (ctf_bufopen_internal): Likewise. Check for OOM.
590 (ctf_parent_name_set): Likewise: report the OOM to the caller.
591 (ctf_cuname_set): Likewise.
592 (ctf_import): Likewise.
593 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
594 free, not ctf_free; strdup, not ctf_strdup.
595 (ctf_str_free_atom): Likewise.
596 (ctf_str_create_atoms): Likewise.
597 (ctf_str_add_ref_internal): Likewise.
598 (ctf_str_remove_ref): Likewise.
599 (ctf_str_write_strtab): Likewise.
600
9c1a2295
NA
6012019-08-09 Nick Alcock <nick.alcock@oracle.com>
602
603 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
604 work right for non-int/fps.
605
1a6ab13e
NA
6062019-08-08 Nick Alcock <nick.alcock@oracle.com>
607
608 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
609 null pointer.
610
99dc3ebd
NA
6112019-08-07 Nick Alcock <nick.alcock@oracle.com>
612
613 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
614 * ctf-open.c (ctf_file_close): Free it.
615 * ctf-create.c (ctf_serialize): Adjust.
616 (membcmp): When reporting a conflict due to an error, report the
617 error.
618 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
619 (ctf_add_type_internal): ... this. Hand back types we are already
620 in the middle of adding immediately. Hand back structs/unions with
621 the same number of members immediately. Do not walk the dynamic
622 list. Call ctf_add_type_internal, not ctf_add_type. Handle
623 forwards promoted to other types and the inverse case identically.
624 Add structs to the mapping as soon as we intern them, before they
625 gain any members.
626
676c3ecb
NA
6272019-08-09 Nick Alcock <nick.alcock@oracle.com>
628
629 * ctf-impl.h (ctf_names_t): New.
630 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
631 (ctf_file_t) <ctf_structs>: Likewise.
632 <ctf_unions>: Likewise.
633 <ctf_enums>: Likewise.
634 <ctf_names>: Likewise.
635 <ctf_lookups>: Improve comment.
636 <ctf_ptrtab_len>: New.
637 <ctf_prov_strtab>: New.
638 <ctf_str_prov_offset>: New.
639 <ctf_dtbyname>: Remove, redundant to the names hashes.
640 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
641 (ctf_dtdef_t) <dtd_name>: Remove.
642 <dtd_data>: Note that the ctt_name is now populated.
643 (ctf_str_atom_t) <csa_offset>: This is now the strtab
644 offset for internal strings too.
645 <csa_external_offset>: New, the external strtab offset.
646 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
647 (ctf_name_table): New declaration.
648 (ctf_lookup_by_rawname): Likewise.
649 (ctf_lookup_by_rawhash): Likewise.
650 (ctf_set_ctl_hashes): Likewise.
651 (ctf_serialize): Likewise.
652 (ctf_dtd_insert): Adjust.
653 (ctf_simple_open_internal): Likewise.
654 (ctf_bufopen_internal): Likewise.
655 (ctf_list_empty_p): Likewise.
656 (ctf_str_remove_ref): Likewise.
657 (ctf_str_add): Returns uint32_t now.
658 (ctf_str_add_ref): Likewise.
659 (ctf_str_add_external): Now returns a boolean (int).
660 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
661 for strings in the appropriate range.
662 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
663 when adding the null string to the new strtab.
664 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
665 (ctf_str_add_ref_internal): Add make_provisional argument. If
666 make_provisional, populate the offset and fill in the
667 ctf_prov_strtab accordingly.
668 (ctf_str_add): Return the offset, not the string.
669 (ctf_str_add_ref): Likewise.
670 (ctf_str_add_external): Return a success integer.
671 (ctf_str_remove_ref): New, remove a single ref.
672 (ctf_str_count_strtab): Do not count the initial null string's
673 length or the existence or length of any unreferenced internal
674 atoms.
675 (ctf_str_populate_sorttab): Skip atoms with no refs.
676 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
677 to the cts_len for the null string, since it is no longer done
678 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
679 Populate the csa_offset for both internal and external cases.
680 Flush the ctf_prov_strtab afterwards, and reset the
681 ctf_str_prov_offset.
682 * ctf-create.c (ctf_grow_ptrtab): New.
683 (ctf_create): Call it. Initialize new fields rather than old
684 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
685 Set the ctl hashes and data model.
686 (ctf_update): Rename to...
687 (ctf_serialize): ... this. Leave a compatibility function behind.
688 Tell ctf_simple_open_internal that this is a writable dictionary.
689 Pass the new fields along from the old dictionary. Drop
690 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
691 Do not zero out the DTD's ctt_name.
692 (ctf_prefixed_name): Rename to...
693 (ctf_name_table): ... this. No longer return a prefixed name: return
694 the applicable name table instead.
695 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
696 kind we're adding. Migrate away from dtd_name.
697 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
698 deleted ctt_name.
699 (ctf_dtd_lookup_type_by_name): Remove.
700 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
701 No longer check ctf_dtnextid: check ctf_typemax instead.
702 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
703 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
704 ctf_name_table and the right name table, and migrate away from
705 dtd_name as in ctf_dtd_delete.
706 (ctf_add_generic): Pass in the kind explicitly and pass it to
707 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
708 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
709 Grow the ptrtab if needed.
710 (ctf_add_encoded): Pass in the kind.
711 (ctf_add_slice): Likewise.
712 (ctf_add_array): Likewise.
713 (ctf_add_function): Likewise.
714 (ctf_add_typedef): Likewise.
715 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
716 ctt_name rather than dtd_name.
717 (ctf_add_struct_sized): Pass in the kind. Use
718 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
719 ctf_dtd_lookup_type_by_name.
720 (ctf_add_union_sized): Likewise.
721 (ctf_add_enum): Likewise.
722 (ctf_add_enum_encoded): Likewise.
723 (ctf_add_forward): Likewise.
724 (ctf_add_type): Likewise.
725 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
726 being initialized until after the call.
727 (ctf_write_mem): Likewise.
728 (ctf_write): Likewise.
729 * ctf-archive.c (arc_write_one_ctf): Likewise.
730 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
731 ctf_hash_lookup_type.
732 (ctf_lookup_by_id): No longer check the readonly types if the
733 dictionary is writable.
734 * ctf-open.c (init_types): Assert that this dictionary is not
735 writable. Adjust to use the new name hashes, ctf_name_table,
736 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
737 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
738 if set. Drop out early when dictionary is writable. Split the
739 ctf_lookups initialization into...
740 (ctf_set_cth_hashes): ... this new function.
741 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
742 (ctf_simple_open): Adjust accordingly.
743 (ctf_bufopen): Likewise.
744 (ctf_file_close): Destroy the appropriate name hashes. No longer
745 destroy ctf_dtbyname, which is gone.
746 (ctf_getdatasect): Remove spurious "extern".
747 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
748 specified name table, given a kind.
749 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
750 (ctf_member_iter): Add support for iterating over the
751 dynamic type list.
752 (ctf_enum_iter): Likewise.
753 (ctf_variable_iter): Likewise.
754 (ctf_type_rvisit): Likewise.
755 (ctf_member_info): Add support for types in the dynamic type list.
756 (ctf_enum_name): Likewise.
757 (ctf_enum_value): Likewise.
758 (ctf_func_type_info): Likewise.
759 (ctf_func_type_args): Likewise.
760 * ctf-link.c (ctf_accumulate_archive_names): No longer call
761 ctf_update.
762 (ctf_link_write): Likewise.
763 (ctf_link_intern_extern_string): Adjust for new
764 ctf_str_add_external return value.
765 (ctf_link_add_strtab): Likewise.
766 * ctf-util.c (ctf_list_empty_p): New.
767
791915db
NA
7682019-08-05 Nick Alcock <nick.alcock@oracle.com>
769
770 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
771 type zero.
772 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
773 members and types.
774 (ctf_add_variable): Likewise for variables pointing to them.
775 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
776 type link failure, but do warn for others.
777 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
778 errors to be ENOMEM.
779 (ctf_dump_member): Likewise.
780 (ctf_dump_type): Likewise.
781 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
782 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
783 (ctf_dump_header): Likewise.
784 (ctf_dump_label): likewise.
785 (ctf_dump_objts): likewise.
786 (ctf_dump_funcs): likewise.
787 (ctf_dump_var): likewise.
788 (ctf_dump_str): Likewise.
789
87279e3c
NA
7902019-09-30 Nick Alcock <nick.alcock@oracle.com>
791
792 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
793 (LT_INIT): Likewise.
794 (AM_INSTALL_LIBBFD): Likewise.
795 (dlopen): Note why this is necessary in a comment.
796 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
797 opcodes/.
798 (SHARED_LDFLAGS): Likewise.
799 (BFD_LIBADD): Likewise, for libbfd.
800 (BFD_DEPENDENCIES): Likewise.
801 (VERSION_FLAGS): Initialize, using a version script if ld supports
802 one, or libtool -export-symbols-regex otherwise.
803 (AC_CONFIG_MACRO_DIR): Add ../BFD.
804 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
805 (INCDIR): New.
806 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
807 (noinst_LIBRARIES): Replace with...
808 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
809 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
810 libctf-nobfd.la as well.
811 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
812 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
813 (libctf_a_SOURCES): Rename to...
814 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
815 ctf-open-bfd.c.
816 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
817 with ctf-open-bfd.c added.
818 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
819 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
820 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
821 * Makefile.am [INSTALL_LIBCTF]: Use it.
822 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
823 libtool macros.
824 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
825 the unstable components).
826 * Makefile.in: Regenerated.
827 * config.h.in: Likewise.
828 * configure: Likewise.
829
8302019-07-30 Nick Alcock <nick.alcock@oracle.com>
831
832 * configure.ac (INSTALL_LIBCTF): New, controlled by
833 --enable-install-libctf.
834 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
835 * Makefile.in: Regenerated.
836 * configure: Regenerated.
837
f046147d
NA
8382019-07-30 Nick Alcock <nick.alcock@oracle.com>
839
840 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
841 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
842
edc8bbe9
NA
8432019-07-30 Nick Alcock <nick.alcock@oracle.com>
844
845 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
846
7e97445a
NA
8472019-07-13 Nick Alcock <nick.alcock@oracle.com>
848
849 * ctf-impl.h (includes): Include <sys/param.h> here.
850
5ae6af75
NA
8512019-07-30 Nick Alcock <nick.alcock@oracle.com>
852
853 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
854 (flip_objts): Likewise.
855 (flip_vars): Likewise.
856 (flip_types): Likewise.
857
1820745a
NA
8582019-07-30 Nick Alcock <nick.alcock@oracle.com>
859
860 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
861 freeing functions: if set, free the key and value if the slot
862 already exists. Always reassign the key.
863 (ctf_dynhash_insert): Adjust call appropriately.
864 (ctf_hash_insert_type): Likewise.
865
5de9eada
NA
8662019-08-03 Nick Alcock <nick.alcock@oracle.com>
867
868 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
869 type kind. Allow forwards to unify with pre-existing structs/
870 unions/enums.
871
49ea9b45
NA
8722019-07-30 Nick Alcock <nick.alcock@oracle.com>
873
874 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
875 <ctf_link_memb_name_changer>: Likewise.
876 <ctf_link_memb_name_changer_arg>: Likewise.
877 * ctf-create.c (ctf_update): Update accordingly.
878 * ctf-open.c (ctf_file_close): Likewise.
879 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
880 (ctf_link_add_cu_mapping): New.
881 (ctf_link_set_memb_name_changer): Likewise.
882 (ctf_change_parent_name): New.
883 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
884 allocated by the caller's ctf_link_memb_name_changer.
885 <ndynames>: Likewise.
886 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
887 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
888 ctf_change_parent_name. Free any resulting names.
889
eabb7154
NA
8902019-07-13 Nick Alcock <nick.alcock@oracle.com>
891
892 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
893 (ctf_link_one_type): ... here, with parent-name setting added.
894 (check_variable): New.
895 (ctf_link_one_variable): Likewise.
896 (ctf_link_one_input_archive_member): Call it.
897 * ctf-error.c (_ctf_errlist): Updated with new errors.
898
886453cb
NA
8992019-07-13 Nick Alcock <nick.alcock@oracle.com>
900
901 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
902 (struct ctf_link_type_mapping_key): New.
903 (ctf_hash_type_mapping_key): Likewise.
904 (ctf_hash_eq_type_mapping_key): Likewise.
905 (ctf_add_type_mapping): Likewise.
906 (ctf_type_mapping): Likewise.
907 (ctf_dynhash_empty): Likewise.
908 * ctf-open.c (ctf_file_close): Update accordingly.
909 * ctf-create.c (ctf_update): Likewise.
910 (ctf_add_type): Populate the mapping.
911 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
912 (ctf_hash_eq_type_mapping_key): Check the key for equality.
913 (ctf_dynhash_insert): Fix comment typo.
914 (ctf_dynhash_empty): New.
915 * ctf-link.c (ctf_add_type_mapping): New.
916 (ctf_type_mapping): Likewise.
917 (empty_link_type_mapping): New.
918 (ctf_link_one_input_archive): Call it.
919
72c83edd
NA
9202019-07-13 Nick Alcock <nick.alcock@oracle.com>
921
922 * ctf-link.c: New file, linking of the string and type sections.
923 * Makefile.am (libctf_a_SOURCES): Add it.
924 * Makefile.in: Regenerate.
925
926 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
927 ctf_link_outputs.
928 * ctf-create.c (ctf_update): Update accordingly.
929 * ctf-open.c (ctf_file_close): Likewise.
930 * ctf-error.c (_ctf_errlist): Updated with new errors.
931
d18f9f16
NA
9322019-07-13 Nick Alcock <nick.alcock@oracle.com>
933
934 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
935
b4f0e09c
NA
9362019-07-13 Nick Alcock <nick.alcock@oracle.com>
937
938 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
939 ctf_type_iter.
940 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
941 (ctf_dump_format_type): Add non-root-type { } notation.
942 Add root flag to prototype.
943 (ctf_dump_label): Adjust accordingly.
944 (ctf_dump_objts): Likewise.
945 (ctf_dump_var): Likewise.
946
3dde2c91
NA
9472019-07-13 Nick Alcock <nick.alcock@oracle.com>
948
949 * ctf-create.c (ctf_compress_write): Fix double-free.
950
5537f9b9
NA
9512019-07-13 Nick Alcock <nick.alcock@oracle.com>
952
953 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
954 of...
955 (ctf_arc_write_fd): ... this new function.
956 * ctf-create.c (ctf_write_mem): New.
957
d851ecd3
NA
9582019-07-13 Nick Alcock <nick.alcock@oracle.com>
959
960 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
961 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
962 (ctf_str_add_ref): Name the last arg.
963 (ctf_str_add_external) New.
964 (ctf_str_add_strraw_explicit): Likewise.
965 (ctf_simple_open_internal): Likewise.
966 (ctf_bufopen_internal): Likewise.
967
968 * ctf-string.c (ctf_strraw_explicit): Split from...
969 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
970 (ctf_str_add_ref_internal): Return the atom, not the
971 string.
972 (ctf_str_add): Adjust accordingly.
973 (ctf_str_add_ref): Likewise. Move up in the file.
974 (ctf_str_add_external): New: update the csa_offset.
975 (ctf_str_count_strtab): Only account for strings with no csa_offset
976 in the internal strtab length.
977 (ctf_str_write_strtab): If the csa_offset is set, update the
978 string's refs without writing the string out, and update the
979 ctf_syn_ext_strtab. Make OOM handling less ugly.
980 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
981 (ctf_update): Handle failure to populate the strtab. Pass in the
982 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
983 Call ctf_simple_open_internal, not ctf_simple_open.
984 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
985 strings by hand.
986 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
987 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
988 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
989 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
990 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
991 (ctf_simple_open_internal): ... this new function, which calls
992 ctf_bufopen_internal.
993 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
994 (ctf_bufopen_internal): ... this new function, which sets
995 ctf_syn_ext_strtab.
996
0ac62312
NA
9972019-07-13 Nick Alcock <nick.alcock@oracle.com>
998
999 * ctf_types.c (ctf_type_iter_all): New.
1000
2db912ba
NA
10012019-07-13 Nick Alcock <nick.alcock@oracle.com>
1002
1003 * ctf-open.c (init_symtab): Check for overflow against the right
1004 section.
1005 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1006 (upgrade_types_v1): Note that these sections are not checked.
1007 (flip_header): Endian-swap the header fields.
1008 (flip_ctf): Endian-swap the sections.
1009 (flip_objts): Update comment.
1010 (ctf_bufopen): Check header offsets and alignment for validity.
1011
6d5944fc
NA
10122019-07-13 Nick Alcock <nick.alcock@oracle.com>
1013
1014 * ctf-open-bfd.c: Add <assert.h>.
1015 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1016 techniques borrowed from bfd_elf_sym_name.
1017 (ctf_new_archive_internal): Improve comment.
1018 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1019 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1020 no symbol section, but not vice versa.
1021
9b32cba4
NA
10222019-07-08 Nick Alcock <nick.alcock@oracle.com>
1023
1024 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1025 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1026 * ctf-dump.c (dump_header): New function, dump the CTF header.
1027 (ctf_dump): Call it.
1028 (ctf_dump_header_strfield): New function.
1029 (ctf_dump_header_sectfield): Likewise.
1030
fd55eae8
NA
10312019-07-06 Nick Alcock <nick.alcock@oracle.com>
1032
1033 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1034 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1035 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1036 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1037 Print out ctf_cuname: only print out ctf_parname if set.
1038 (ctf_free_base): Removed, ctf_base is no longer freed: free
1039 ctf_dynbase instead.
1040 (ctf_set_version): Fix spacing.
1041 (upgrade_header): New, in-place header upgrading.
1042 (upgrade_types): Rename to...
1043 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1044 longer track old and new headers separately. No longer allow for
1045 header sizes explicitly: squeeze the headers out on upgrade (they
1046 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1047 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1048 (upgrade_types): New, also handle ctf_parmax updating.
1049 (flip_header): Flip ctf_cuname.
1050 (flip_types): Flip BUF explicitly rather than deriving BUF from
1051 BASE.
1052 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1053 required alignment of objtoff and funcoff. No longer store it in
1054 the ctf_buf unless that buf is derived unmodified from the input.
1055 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1056 that duplicate fields in ctf_file: move allocation of ctf_file
1057 further up instead. Call upgrade_header as needed. Move
1058 version-specific ctf_parmax initialization into upgrade_types. More
1059 concise error handling.
1060 (ctf_file_close): No longer test for null pointers before freeing.
1061 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1062 ctf_free_base.
1063 (ctf_cuname): New.
1064 (ctf_cuname_set): New.
1065 * ctf-create.c (ctf_update): Populate ctf_cuname.
1066 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1067 comment.
1068 (ctf_write): Likewise.
1069 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1070 Fix the compression length: fp->ctf_size never counted the CTF
1071 header. Simplify the compress call accordingly.
1072
a2230b5e
HPN
10732019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1074
1075 * ctf-endian.h: Don't assume htole64 and le64toh are always
1076 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1077 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1078 not bswap_identity_64.
1079
fd361982
AM
10802019-09-18 Alan Modra <amodra@gmail.com>
1081
1082 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1083
60391a25
PB
10842019-09-09 Phil Blundell <pb@pbcl.net>
1085
1086 binutils 2.33 branch created.
1087
12a0b67d
NA
10882019-07-18 Nick Alcock <nick.alcock@oracle.com>
1089
1090 * ctf-types.c (ctf_type_aname_raw): New.
1091 (ctf_func_type_info): Likewise.
1092 (ctf_func_type_args): Likewise.
1093 * ctf-error.c (_ctf_errlist): Fix description.
1094 * ctf-lookup.c: Fix file description.
1095
083114f8 10962019-06-28 Nick Alcock <nick.alcock@oracle.com>
f57cf0e3
NA
1097
1098 * ctf-create.c (ctf_create): Fix off-by-one error.
1099
083114f8 11002019-06-28 Nick Alcock <nick.alcock@oracle.com>
f5e9c9bd
NA
1101
1102 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1103 struct ctf_strs.
1104 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1105 (struct ctf_str_atom): New, disambiguated single string.
1106 (struct ctf_str_atom_ref): New, points to some other location that
1107 references this string's offset.
1108 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1109 Remove member ctf_dtvstrlen: we no longer track the total strlen
1110 as we add strings.
1111 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1112 (ctf_str_free_atoms): Likewise.
1113 (ctf_str_add): Likewise.
1114 (ctf_str_add_ref): Likewise.
1115 (ctf_str_rollback): Likewise.
1116 (ctf_str_purge_refs): Likewise.
1117 (ctf_str_write_strtab): Likewise.
1118 (ctf_realloc): Declare new function in ctf-util.c.
1119
1120 * ctf-open.c (ctf_bufopen): Create the atoms table.
1121 (ctf_file_close): Destroy it.
1122 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1123 special-case the position of the parname string. Construct the
1124 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1125 rest of each buffer element is constructed, not via open-coding:
1126 realloc the CTF buffer and append the strtab to it. No longer
1127 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1128 strtab construction.
1129 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1130 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1131 after buffer element construction instead.
1132 (ctf_copy_lmembers): Likewise.
1133 (ctf_copy_emembers): Likewise.
1134 (ctf_create): No longer maintain the ctf_dtvstrlen.
1135 (ctf_dtd_delete): Likewise.
1136 (ctf_dvd_delete): Likewise.
1137 (ctf_add_generic): Likewise.
1138 (ctf_add_enumerator): Likewise.
1139 (ctf_add_member_offset): Likewise.
1140 (ctf_add_variable): Likewise.
1141 (membadd): Likewise.
1142 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1143 if there are active ctf_str_num_refs.
1144 (ctf_strraw): Move to ctf-string.c.
1145 (ctf_strptr): Likewise.
1146 * ctf-string.c: New file, strtab manipulation.
1147
1148 * Makefile.am (libctf_a_SOURCES): Add it.
1149 * Makefile.in: Regenerate.
1150
083114f8 11512019-06-28 Nick Alcock <nick.alcock@oracle.com>
9658dc39
NA
1152
1153 * ctf-impl.h (ctf_hash_iter_f): New.
1154 (ctf_dynhash_iter): New declaration.
1155 (ctf_dynhash_iter_remove): New declaration.
1156 * ctf-hash.c (ctf_dynhash_iter): Define.
1157 (ctf_dynhash_iter_remove): Likewise.
1158 (ctf_hashtab_traverse): New.
1159 (ctf_hashtab_traverse_remove): Likewise.
1160 (struct ctf_traverse_cb_arg): Likewise.
1161 (struct ctf_traverse_remove_cb_arg): Likewise.
1162
083114f8 11632019-06-28 Nick Alcock <nick.alcock@oracle.com>
3e10cffc
NA
1164
1165 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1166
083114f8 11672019-06-28 Nick Alcock <nick.alcock@oracle.com>
c550e7ba
NA
1168
1169 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1170 (ctf_dump_funcs): Likewise.
1171
083114f8 11722019-06-19 Nick Alcock <nick.alcock@oracle.com>
cf02c44d
NA
1173
1174 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1175 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1176 little-endian CTF archive magic. Do not check the CTF version:
1177 ctf_simple_open does that in endian-safe ways. Do not dereference
1178 null pointers on open failure.
1179
083114f8 11802019-06-19 Nick Alcock <nick.alcock@oracle.com>
7cee1826
NA
1181
1182 * ctf-open.c (get_vbytes_common): Return the new slice size.
1183 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1184 Remember to copy in the CTF data when opening an uncompressed
1185 foreign-endian CTF file. Prune useless variable manipulation.
1186
083114f8 11872019-06-19 Nick Alcock <nick.alcock@oracle.com>
0b4fa56e
NA
1188
1189 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1190 seen.
1191
083114f8 11922019-06-19 Nick Alcock <nick.alcock@oracle.com>
364620bf
NA
1193
1194 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1195 output.
1196
083114f8 11972019-06-19 Nick Alcock <nick.alcock@oracle.com>
65365aa8
NA
1198
1199 * ctf-subr.c (_PAGESIZE): Remove.
1200 (ctf_data_alloc): Likewise.
1201 (ctf_data_free): Likewise.
1202 (ctf_data_protect): Likewise.
1203 * ctf-impl.h: Remove declarations.
1204 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1205 ctf_free, not ctf_data_free.
1206 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1207 the buffer again on compression error.
1208 * ctf-open.c (ctf_set_base): No longer track the size: call
1209 ctf_free, not ctf_data_free.
1210 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1211 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1212
083114f8 12132019-06-19 Nick Alcock <nick.alcock@oracle.com>
24865428
NA
1214
1215 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1216 ctf_dynhash_insert.
1217 (ctf_dvd_insert): Likewise.
1218 (ctf_add_generic): Likewise.
1219 (ctf_add_variable): Likewise.
1220 * ctf-impl.h: Adjust declarations.
1221
3a3a077c
AM
12222019-06-14 Alan Modra <amodra@gmail.com>
1223
1224 * configure: Regenerate.
1225
942d35f7
NA
12262019-06-06 Nick Alcock <nick.alcock@oracle.com>
1227
1228 * ctf-decls.h: Include <libiberty.h>.
1229 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1230
595a4d43
NA
12312019-06-06 Nick Alcock <nick.alcock@oracle.com>
1232
1233 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1234 (ctf_dump_objts): Likewise.
1235 (ctf_dump_funcs): Likewise.
1236 (ctf_dump_member): Likewise.
1237 (ctf_dump_str): Likewise.
1238
f5e73be1
NA
12392019-06-06 Nick Alcock <nick.alcock@oracle.com>
1240
1241 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1242 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1243
62d8e3b7
NA
12442019-06-05 Nick Alcock <nick.alcock@oracle.com>
1245
1246 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1247 (ctf_arc_open_by_offset): Likewise.
1248 * ctf-create.c (ctf_add_type): Likewise.
1249
76fad999
TT
12502019-06-04 Tom Tromey <tromey@adacore.com>
1251
1252 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1253 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1254
ad118caa
NA
12552019-06-04 Nick Alcock <nick.alcock@oracle.com>
1256
1257 * configure.ac: Check for O_CLOEXEC.
1258 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1259 * config.h.in: Regenerate.
1260 * configure: Likewise.
1261
6b22174f
NA
12622019-06-04 Nick Alcock <nick.alcock@oracle.com>
1263
1264 * qsort_r.c: Rename to...
1265 * ctf-qsort_r.c: ... this.
1266 (_quicksort): Define to ctf_qsort_r.
1267 * ctf-decls.h (qsort_r): Remove.
1268 (ctf_qsort_r): Add.
1269 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1270 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1271 * Makefile.am (libctf_a_LIBADD): Remove.
1272 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1273 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1274 * ctf-create.c (ctf_update): Likewise.
1275 * configure.ac: Check for BSD versus GNU qsort_r signature.
1276 * Makefile.in: Regenerate.
1277 * config.h.in: Likewise.
1278 * configure: Likewise.
1279
941accce
NA
12802019-06-03 Nick Alcock <nick.alcock@oracle.com>
1281
1282 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1283
a0486bac
JM
12842019-05-29 Nick Alcock <nick.alcock@oracle.com>
1285
1286 * Makefile.am (ZLIB): New.
1287 (ZLIBINC): Likewise.
1288 (AM_CFLAGS): Use them.
1289 (libctf_a_LIBADD): New, for LIBOBJS.
1290 * configure.ac: Check for zlib, endian.h, and qsort_r.
1291 * ctf-endian.h: New, providing htole64 and le64toh.
1292 * swap.h: Code style fixes.
1293 (bswap_identity_64): New.
1294 * qsort_r.c: New, from gnulib (with one added #include).
1295 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1296 and unconditional definitions of MIN and MAX.
1297 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1298 (ctf_set_errno): Now returns unsigned long.
1299 * ctf-util.c (ctf_set_errno): Adjust here too.
1300 * ctf-archive.c: Use ctf-endian.h.
1301 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1302 cts_flags and cts_offset.
1303 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1304 * ctf-create.c: Provide a definition of roundup if not defined.
1305 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1306 (ctf_add_reftype): Do not check if type IDs are below zero.
1307 (ctf_add_slice): Likewise.
1308 (ctf_add_typedef): Likewise.
1309 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1310 when known error-free. Drop CTF_ERR usage for functions returning
1311 int.
1312 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1313 int.
1314 (ctf_add_variable): Likewise.
1315 (enumcmp): Likewise.
1316 (enumadd): Likewise.
1317 (membcmp): Likewise.
1318 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1319 when known error-free.
1320 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1321 returning int: use CTF_ERR for functions returning ctf_type_id.
1322 (ctf_dump_label): Likewise.
1323 (ctf_dump_objts): Likewise.
1324 * ctf-labels.c (ctf_label_topmost): Likewise.
1325 (ctf_label_iter): Likewise.
1326 (ctf_label_info): Likewise.
1327 * ctf-lookup.c (ctf_func_args): Likewise.
1328 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1329 (ctf_bufopen): Likewise. Use zlib types as needed.
1330 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1331 returning int.
1332 (ctf_enum_iter): Likewise.
1333 (ctf_type_size): Likewise.
1334 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1335 (ctf_type_kind_unsliced): Likewise.
1336 (ctf_type_kind): Likewise.
1337 (ctf_type_encoding): Likewise.
1338 (ctf_member_info): Likewise.
1339 (ctf_array_info): Likewise.
1340 (ctf_enum_value): Likewise.
1341 (ctf_type_rvisit): Likewise.
1342 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1343 cts_offset.
1344 (ctf_simple_open): Likewise.
1345 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1346 * Makefile.in: Regenerate.
1347 * aclocal.m4: Likewise.
1348 * config.h: Likewise.
1349 * configure: Likewise.
1350
9698cf9b
NA
13512019-05-28 Nick Alcock <nick.alcock@oracle.com>
1352
1353 * configure.in: Check for bfd_section_from_elf_index.
1354 * configure: Regenerate.
1355 * config.h.in [HAVE_BFD_ELF]: Likewise.
1356 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1357 abfd is potentially unused now.
1358
0e65dfba
NA
13592019-05-28 Nick Alcock <nick.alcock@oracle.com>
1360
1361 * Makefile.am: New.
1362 * Makefile.in: Regenerated.
1363 * config.h.in: Likewise.
1364 * aclocal.m4: Likewise.
1365 * configure: Likewise.
1366
a30b3e18
NA
13672019-05-28 Nick Alcock <nick.alcock@oracle.com>
1368
1369 * ctf-dump.c: New.
1370
6dbf2b73
NA
13712019-05-28 Nick Alcock <nick.alcock@oracle.com>
1372
1373 * ctf-labels.c: New.
1374
6c33b742
NA
13752019-05-28 Nick Alcock <nick.alcock@oracle.com>
1376
1377 * ctf-impl.h (_libctf_version): New declaration.
1378 * ctf-subr.c (_libctf_version): Define it.
1379 (ctf_version): New.
1380
c499eb68
NA
13812019-05-28 Nick Alcock <nick.alcock@oracle.com>
1382
1383 * ctf-create.c (enumcmp): New.
1384 (enumadd): Likewise.
1385 (membcmp): Likewise.
1386 (membadd): Likewise.
1387 (ctf_add_type): Likewise.
1388
b437bfe0
NA
13892019-05-28 Nick Alcock <nick.alcock@oracle.com>
1390
1391 * ctf-lookup.c (isqualifier): New.
1392 (ctf_lookup_by_name): Likewise.
1393 (struct ctf_lookup_var_key): Likewise.
1394 (ctf_lookup_var): Likewise.
1395 (ctf_lookup_variable): Likewise.
1396 (ctf_lookup_symbol_name): Likewise.
1397 (ctf_lookup_by_symbol): Likewise.
1398 (ctf_func_info): Likewise.
1399 (ctf_func_args): Likewise.
1400
316afdb1
NA
14012019-05-28 Nick Alcock <nick.alcock@oracle.com>
1402
1403 * ctf-decl.c: New file.
1404 * ctf-types.c: Likewise.
1405 * ctf-impl.h: New declarations.
1406
143dce84
NA
14072019-05-28 Nick Alcock <nick.alcock@oracle.com>
1408
1409 * ctf-open-bfd.c: New file.
1410 * ctf-open.c (ctf_close): New.
1411 * ctf-impl.h: Include bfd.h.
1412 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1413 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1414 ctfi_bfd_close.
1415 (ctf_bfdopen_ctfsect): New declaration.
1416 (_CTF_SECTION): likewise.
1417
9402cc59
NA
14182019-05-28 Nick Alcock <nick.alcock@oracle.com>
1419
1420 * ctf-archive.c: New.
1421 * ctf-impl.h (ctf_archive_internal): New type.
1422 (ctf_arc_open_internal): New declaration.
1423 (ctf_arc_bufopen): Likewise.
1424 (ctf_arc_close_internal): Likewise.
1425
72f33921
NA
14262019-05-28 Nick Alcock <nick.alcock@oracle.com>
1427
1428 * ctf-open.c: New file.
1429 * swap.h: Likewise.
1430
47d546f4
NA
14312019-05-28 Nick Alcock <nick.alcock@oracle.com>
1432
1433 * ctf-create.c: New file.
1434 * ctf-lookup.c: New file.
1435
a5be9bbe
NA
14362019-05-28 Nick Alcock <nick.alcock@oracle.com>
1437
1438 * ctf-impl.h: New definitions and declarations for type creation
1439 and lookup.
1440
c0754cdd
NA
14412019-05-28 Nick Alcock <nick.alcock@oracle.com>
1442
1443 * ctf-hash.c: New file.
1444 * ctf-impl.h: New declarations.
1445
479604f4
NA
14462019-05-28 Nick Alcock <nick.alcock@oracle.com>
1447
1448 * ctf-error.c: New file.
1449
94585e7f
NA
14502019-05-28 Nick Alcock <nick.alcock@oracle.com>
1451
1452 * ctf-util.c: New file.
1453 * elf.h: Likewise.
1454 * ctf-impl.h: Include it, and add declarations.
1455
60da9d95
NA
14562019-05-28 Nick Alcock <nick.alcock@oracle.com>
1457
1458 * ctf-impl.h: New file.
1459 * ctf-subr.c: New file.
1460
1461\f
1462Local Variables:
1463mode: change-log
1464left-margin: 8
1465fill-column: 76
1466version-control: never
1467End:
This page took 0.16414 seconds and 4 git commands to generate.