[deliverable/linux.git] / net / dsa / slave.c

/*
 * net/dsa/slave.c - Slave device handling
 * Copyright (c) 2008-2009 Marvell Semiconductor
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/list.h>
#include <linux/etherdevice.h>
#include <linux/phy.h>
#include <linux/phy_fixed.h>
#include <linux/of_net.h>
#include <linux/of_mdio.h>
#include "dsa_priv.h"

/* slave mii_bus handling ***************************************************/
static int dsa_slave_phy_read(struct mii_bus *bus, int addr, int reg)
{
	struct dsa_switch *ds = bus->priv;

	if (ds->phys_mii_mask & (1 << addr))
		return ds->drv->phy_read(ds, addr, reg);

	return 0xffff;
}

static int dsa_slave_phy_write(struct mii_bus *bus, int addr, int reg, u16 val)
{
	struct dsa_switch *ds = bus->priv;

	if (ds->phys_mii_mask & (1 << addr))
		return ds->drv->phy_write(ds, addr, reg, val);

	return 0;
}

void dsa_slave_mii_bus_init(struct dsa_switch *ds)
{
	ds->slave_mii_bus->priv = (void *)ds;
	ds->slave_mii_bus->name = "dsa slave smi";
	ds->slave_mii_bus->read = dsa_slave_phy_read;
	ds->slave_mii_bus->write = dsa_slave_phy_write;
	snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "dsa-%d:%.2x",
			ds->index, ds->pd->sw_addr);
	ds->slave_mii_bus->parent = ds->master_dev;
	ds->slave_mii_bus->phy_mask = ~ds->phys_mii_mask;
}


/* slave device handling ****************************************************/
static int dsa_slave_init(struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);

	dev->iflink = p->parent->dst->master_netdev->ifindex;

	return 0;
}

static int dsa_slave_open(struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct net_device *master = p->parent->dst->master_netdev;
	struct dsa_switch *ds = p->parent;
	int err;

	if (!(master->flags & IFF_UP))
		return -ENETDOWN;

	if (!ether_addr_equal(dev->dev_addr, master->dev_addr)) {
		err = dev_uc_add(master, dev->dev_addr);
		if (err < 0)
			goto out;
	}

	if (dev->flags & IFF_ALLMULTI) {
		err = dev_set_allmulti(master, 1);
		if (err < 0)
			goto del_unicast;
	}
	if (dev->flags & IFF_PROMISC) {
		err = dev_set_promiscuity(master, 1);
		if (err < 0)
			goto clear_allmulti;
	}

	if (ds->drv->port_enable) {
		err = ds->drv->port_enable(ds, p->port, p->phy);
		if (err)
			goto clear_promisc;
	}

	if (p->phy)
		phy_start(p->phy);

	return 0;

clear_promisc:
	if (dev->flags & IFF_PROMISC)
		dev_set_promiscuity(master, 0);
clear_allmulti:
	if (dev->flags & IFF_ALLMULTI)
		dev_set_allmulti(master, -1);
del_unicast:
	if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
		dev_uc_del(master, dev->dev_addr);
out:
	return err;
}

static int dsa_slave_close(struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct net_device *master = p->parent->dst->master_netdev;
	struct dsa_switch *ds = p->parent;

	if (p->phy)
		phy_stop(p->phy);

	dev_mc_unsync(master, dev);
	dev_uc_unsync(master, dev);
	if (dev->flags & IFF_ALLMULTI)
		dev_set_allmulti(master, -1);
	if (dev->flags & IFF_PROMISC)
		dev_set_promiscuity(master, -1);

	if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
		dev_uc_del(master, dev->dev_addr);

	if (ds->drv->port_disable)
		ds->drv->port_disable(ds, p->port, p->phy);

	return 0;
}

static void dsa_slave_change_rx_flags(struct net_device *dev, int change)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct net_device *master = p->parent->dst->master_netdev;

	if (change & IFF_ALLMULTI)
		dev_set_allmulti(master, dev->flags & IFF_ALLMULTI ? 1 : -1);
	if (change & IFF_PROMISC)
		dev_set_promiscuity(master, dev->flags & IFF_PROMISC ? 1 : -1);
}

static void dsa_slave_set_rx_mode(struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct net_device *master = p->parent->dst->master_netdev;

	dev_mc_sync(master, dev);
	dev_uc_sync(master, dev);
}

static int dsa_slave_set_mac_address(struct net_device *dev, void *a)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct net_device *master = p->parent->dst->master_netdev;
	struct sockaddr *addr = a;
	int err;

	if (!is_valid_ether_addr(addr->sa_data))
		return -EADDRNOTAVAIL;

	if (!(dev->flags & IFF_UP))
		goto out;

	if (!ether_addr_equal(addr->sa_data, master->dev_addr)) {
		err = dev_uc_add(master, addr->sa_data);
		if (err < 0)
			return err;
	}

	if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
		dev_uc_del(master, dev->dev_addr);

out:
	ether_addr_copy(dev->dev_addr, addr->sa_data);

	return 0;
}

static int dsa_slave_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
{
	struct dsa_slave_priv *p = netdev_priv(dev);

	if (p->phy != NULL)
		return phy_mii_ioctl(p->phy, ifr, cmd);

	return -EOPNOTSUPP;
}

static netdev_tx_t dsa_slave_xmit(struct sk_buff *skb, struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);

	return p->xmit(skb, dev);
}

static netdev_tx_t dsa_slave_notag_xmit(struct sk_buff *skb,
					struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);

	skb->dev = p->parent->dst->master_netdev;
	dev_queue_xmit(skb);

	return NETDEV_TX_OK;
}


/* ethtool operations *******************************************************/
static int
dsa_slave_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	int err;

	err = -EOPNOTSUPP;
	if (p->phy != NULL) {
		err = phy_read_status(p->phy);
		if (err == 0)
			err = phy_ethtool_gset(p->phy, cmd);
	}

	return err;
}

static int
dsa_slave_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
{
	struct dsa_slave_priv *p = netdev_priv(dev);

	if (p->phy != NULL)
		return phy_ethtool_sset(p->phy, cmd);

	return -EOPNOTSUPP;
}

static void dsa_slave_get_drvinfo(struct net_device *dev,
				  struct ethtool_drvinfo *drvinfo)
{
	strlcpy(drvinfo->driver, "dsa", sizeof(drvinfo->driver));
	strlcpy(drvinfo->version, dsa_driver_version, sizeof(drvinfo->version));
	strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
	strlcpy(drvinfo->bus_info, "platform", sizeof(drvinfo->bus_info));
}

static int dsa_slave_get_regs_len(struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	if (ds->drv->get_regs_len)
		return ds->drv->get_regs_len(ds, p->port);

	return -EOPNOTSUPP;
}

static void
dsa_slave_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *_p)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	if (ds->drv->get_regs)
		ds->drv->get_regs(ds, p->port, regs, _p);
}

static int dsa_slave_nway_reset(struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);

	if (p->phy != NULL)
		return genphy_restart_aneg(p->phy);

	return -EOPNOTSUPP;
}

static u32 dsa_slave_get_link(struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);

	if (p->phy != NULL) {
		genphy_update_link(p->phy);
		return p->phy->link;
	}

	return -EOPNOTSUPP;
}

static int dsa_slave_get_eeprom_len(struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	if (ds->pd->eeprom_len)
		return ds->pd->eeprom_len;

	if (ds->drv->get_eeprom_len)
		return ds->drv->get_eeprom_len(ds);

	return 0;
}

static int dsa_slave_get_eeprom(struct net_device *dev,
				struct ethtool_eeprom *eeprom, u8 *data)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	if (ds->drv->get_eeprom)
		return ds->drv->get_eeprom(ds, eeprom, data);

	return -EOPNOTSUPP;
}

static int dsa_slave_set_eeprom(struct net_device *dev,
				struct ethtool_eeprom *eeprom, u8 *data)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	if (ds->drv->set_eeprom)
		return ds->drv->set_eeprom(ds, eeprom, data);

	return -EOPNOTSUPP;
}

static void dsa_slave_get_strings(struct net_device *dev,
				  uint32_t stringset, uint8_t *data)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	if (stringset == ETH_SS_STATS) {
		int len = ETH_GSTRING_LEN;

		strncpy(data, "tx_packets", len);
		strncpy(data + len, "tx_bytes", len);
		strncpy(data + 2 * len, "rx_packets", len);
		strncpy(data + 3 * len, "rx_bytes", len);
		if (ds->drv->get_strings != NULL)
			ds->drv->get_strings(ds, p->port, data + 4 * len);
	}
}

static void dsa_slave_get_ethtool_stats(struct net_device *dev,
					struct ethtool_stats *stats,
					uint64_t *data)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	data[0] = p->dev->stats.tx_packets;
	data[1] = p->dev->stats.tx_bytes;
	data[2] = p->dev->stats.rx_packets;
	data[3] = p->dev->stats.rx_bytes;
	if (ds->drv->get_ethtool_stats != NULL)
		ds->drv->get_ethtool_stats(ds, p->port, data + 4);
}

static int dsa_slave_get_sset_count(struct net_device *dev, int sset)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	if (sset == ETH_SS_STATS) {
		int count;

		count = 4;
		if (ds->drv->get_sset_count != NULL)
			count += ds->drv->get_sset_count(ds);

		return count;
	}

	return -EOPNOTSUPP;
}

static void dsa_slave_get_wol(struct net_device *dev, struct ethtool_wolinfo *w)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	if (ds->drv->get_wol)
		ds->drv->get_wol(ds, p->port, w);
}

static int dsa_slave_set_wol(struct net_device *dev, struct ethtool_wolinfo *w)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;
	int ret = -EOPNOTSUPP;

	if (ds->drv->set_wol)
		ret = ds->drv->set_wol(ds, p->port, w);

	return ret;
}

static int dsa_slave_set_eee(struct net_device *dev, struct ethtool_eee *e)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;
	int ret;

	if (!ds->drv->set_eee)
		return -EOPNOTSUPP;

	ret = ds->drv->set_eee(ds, p->port, p->phy, e);
	if (ret)
		return ret;

	if (p->phy)
		ret = phy_ethtool_set_eee(p->phy, e);

	return ret;
}

static int dsa_slave_get_eee(struct net_device *dev, struct ethtool_eee *e)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;
	int ret;

	if (!ds->drv->get_eee)
		return -EOPNOTSUPP;

	ret = ds->drv->get_eee(ds, p->port, e);
	if (ret)
		return ret;

	if (p->phy)
		ret = phy_ethtool_get_eee(p->phy, e);

	return ret;
}

static const struct ethtool_ops dsa_slave_ethtool_ops = {
	.get_settings		= dsa_slave_get_settings,
	.set_settings		= dsa_slave_set_settings,
	.get_drvinfo		= dsa_slave_get_drvinfo,
	.get_regs_len		= dsa_slave_get_regs_len,
	.get_regs		= dsa_slave_get_regs,
	.nway_reset		= dsa_slave_nway_reset,
	.get_link		= dsa_slave_get_link,
	.get_eeprom_len		= dsa_slave_get_eeprom_len,
	.get_eeprom		= dsa_slave_get_eeprom,
	.set_eeprom		= dsa_slave_set_eeprom,
	.get_strings		= dsa_slave_get_strings,
	.get_ethtool_stats	= dsa_slave_get_ethtool_stats,
	.get_sset_count		= dsa_slave_get_sset_count,
	.set_wol		= dsa_slave_set_wol,
	.get_wol		= dsa_slave_get_wol,
	.set_eee		= dsa_slave_set_eee,
	.get_eee		= dsa_slave_get_eee,
};

static const struct net_device_ops dsa_slave_netdev_ops = {
	.ndo_init		= dsa_slave_init,
	.ndo_open	 	= dsa_slave_open,
	.ndo_stop		= dsa_slave_close,
	.ndo_start_xmit		= dsa_slave_xmit,
	.ndo_change_rx_flags	= dsa_slave_change_rx_flags,
	.ndo_set_rx_mode	= dsa_slave_set_rx_mode,
	.ndo_set_mac_address	= dsa_slave_set_mac_address,
	.ndo_do_ioctl		= dsa_slave_ioctl,
};

static void dsa_slave_adjust_link(struct net_device *dev)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;
	unsigned int status_changed = 0;

	if (p->old_link != p->phy->link) {
		status_changed = 1;
		p->old_link = p->phy->link;
	}

	if (p->old_duplex != p->phy->duplex) {
		status_changed = 1;
		p->old_duplex = p->phy->duplex;
	}

	if (p->old_pause != p->phy->pause) {
		status_changed = 1;
		p->old_pause = p->phy->pause;
	}

	if (ds->drv->adjust_link && status_changed)
		ds->drv->adjust_link(ds, p->port, p->phy);

	if (status_changed)
		phy_print_status(p->phy);
}

static int dsa_slave_fixed_link_update(struct net_device *dev,
				       struct fixed_phy_status *status)
{
	struct dsa_slave_priv *p = netdev_priv(dev);
	struct dsa_switch *ds = p->parent;

	if (ds->drv->fixed_link_update)
		ds->drv->fixed_link_update(ds, p->port, status);

	return 0;
}

/* slave device setup *******************************************************/
static int dsa_slave_phy_setup(struct dsa_slave_priv *p,
				struct net_device *slave_dev)
{
	struct dsa_switch *ds = p->parent;
	struct dsa_chip_data *cd = ds->pd;
	struct device_node *phy_dn, *port_dn;
	bool phy_is_fixed = false;
	u32 phy_flags = 0;
	int mode, ret;

	port_dn = cd->port_dn[p->port];
	mode = of_get_phy_mode(port_dn);
	if (mode < 0)
		mode = PHY_INTERFACE_MODE_NA;
	p->phy_interface = mode;

	phy_dn = of_parse_phandle(port_dn, "phy-handle", 0);
	if (of_phy_is_fixed_link(port_dn)) {
		/* In the case of a fixed PHY, the DT node associated
		 * to the fixed PHY is the Port DT node
		 */
		ret = of_phy_register_fixed_link(port_dn);
		if (ret) {
			netdev_err(slave_dev, "failed to register fixed PHY\n");
			return ret;
		}
		phy_is_fixed = true;
		phy_dn = port_dn;
	}

	if (ds->drv->get_phy_flags)
		phy_flags = ds->drv->get_phy_flags(ds, p->port);

	if (phy_dn)
		p->phy = of_phy_connect(slave_dev, phy_dn,
					dsa_slave_adjust_link, phy_flags,
					p->phy_interface);

	if (p->phy && phy_is_fixed)
		fixed_phy_set_link_update(p->phy, dsa_slave_fixed_link_update);

	/* We could not connect to a designated PHY, so use the switch internal
	 * MDIO bus instead
	 */
	if (!p->phy) {
		p->phy = ds->slave_mii_bus->phy_map[p->port];
		if (!p->phy)
			return -ENODEV;

		/* Use already configured phy mode */
		p->phy_interface = p->phy->interface;
		phy_connect_direct(slave_dev, p->phy, dsa_slave_adjust_link,
				   p->phy_interface);
	} else {
		netdev_info(slave_dev, "attached PHY at address %d [%s]\n",
			    p->phy->addr, p->phy->drv->name);
	}

	return 0;
}

int dsa_slave_suspend(struct net_device *slave_dev)
{
	struct dsa_slave_priv *p = netdev_priv(slave_dev);

	netif_device_detach(slave_dev);

	if (p->phy) {
		phy_stop(p->phy);
		p->old_pause = -1;
		p->old_link = -1;
		p->old_duplex = -1;
		phy_suspend(p->phy);
	}

	return 0;
}

int dsa_slave_resume(struct net_device *slave_dev)
{
	struct dsa_slave_priv *p = netdev_priv(slave_dev);

	netif_device_attach(slave_dev);

	if (p->phy) {
		phy_resume(p->phy);
		phy_start(p->phy);
	}

	return 0;
}

int dsa_slave_create(struct dsa_switch *ds, struct device *parent,
		     int port, char *name)
{
	struct net_device *master = ds->dst->master_netdev;
	struct net_device *slave_dev;
	struct dsa_slave_priv *p;
	int ret;

	slave_dev = alloc_netdev(sizeof(struct dsa_slave_priv), name,
				 NET_NAME_UNKNOWN, ether_setup);
	if (slave_dev == NULL)
		return -ENOMEM;

	slave_dev->features = master->vlan_features;
	slave_dev->ethtool_ops = &dsa_slave_ethtool_ops;
	eth_hw_addr_inherit(slave_dev, master);
	slave_dev->tx_queue_len = 0;
	slave_dev->netdev_ops = &dsa_slave_netdev_ops;

	SET_NETDEV_DEV(slave_dev, parent);
	slave_dev->dev.of_node = ds->pd->port_dn[port];
	slave_dev->vlan_features = master->vlan_features;

	p = netdev_priv(slave_dev);
	p->dev = slave_dev;
	p->parent = ds;
	p->port = port;

	switch (ds->dst->tag_protocol) {
#ifdef CONFIG_NET_DSA_TAG_DSA
	case DSA_TAG_PROTO_DSA:
		p->xmit = dsa_netdev_ops.xmit;
		break;
#endif
#ifdef CONFIG_NET_DSA_TAG_EDSA
	case DSA_TAG_PROTO_EDSA:
		p->xmit = edsa_netdev_ops.xmit;
		break;
#endif
#ifdef CONFIG_NET_DSA_TAG_TRAILER
	case DSA_TAG_PROTO_TRAILER:
		p->xmit = trailer_netdev_ops.xmit;
		break;
#endif
#ifdef CONFIG_NET_DSA_TAG_BRCM
	case DSA_TAG_PROTO_BRCM:
		p->xmit = brcm_netdev_ops.xmit;
		break;
#endif
	default:
		p->xmit	= dsa_slave_notag_xmit;
		break;
	}

	p->old_pause = -1;
	p->old_link = -1;
	p->old_duplex = -1;

	ret = dsa_slave_phy_setup(p, slave_dev);
	if (ret) {
		free_netdev(slave_dev);
		return ret;
	}

	ds->ports[port] = slave_dev;
	ret = register_netdev(slave_dev);
	if (ret) {
		netdev_err(master, "error %d registering interface %s\n",
			   ret, slave_dev->name);
		phy_disconnect(p->phy);
		ds->ports[port] = NULL;
		free_netdev(slave_dev);
		return ret;
	}

	netif_carrier_off(slave_dev);

	return 0;
}
Commit	Line	Data
91da11f8 LB	1	/*
91da11f8 LB	2	* net/dsa/slave.c - Slave device handling
e84665c9	3	* Copyright (c) 2008-2009 Marvell Semiconductor
91da11f8 LB	4	*
	5	* This program is free software; you can redistribute it and/or modify
	6	* it under the terms of the GNU General Public License as published by
	7	* the Free Software Foundation; either version 2 of the License, or
	8	* (at your option) any later version.
	9	*/
	10
	11	#include <linux/list.h>
df02c6ff	12	#include <linux/etherdevice.h>
91da11f8	13	#include <linux/phy.h>
a2820543	14	#include <linux/phy_fixed.h>
0d8bcdd3 FF	15	#include <linux/of_net.h>
0d8bcdd3 FF	16	#include <linux/of_mdio.h>
91da11f8 LB	17	#include "dsa_priv.h"
	18
	19	/* slave mii_bus handling ***************************************************/
	20	static int dsa_slave_phy_read(struct mii_bus *bus, int addr, int reg)
	21	{
	22	struct dsa_switch *ds = bus->priv;
	23
0d8bcdd3	24	if (ds->phys_mii_mask & (1 << addr))
91da11f8 LB	25	return ds->drv->phy_read(ds, addr, reg);
	26
	27	return 0xffff;
	28	}
	29
	30	static int dsa_slave_phy_write(struct mii_bus *bus, int addr, int reg, u16 val)
	31	{
	32	struct dsa_switch *ds = bus->priv;
	33
0d8bcdd3	34	if (ds->phys_mii_mask & (1 << addr))
91da11f8 LB	35	return ds->drv->phy_write(ds, addr, reg, val);
	36
	37	return 0;
	38	}
	39
	40	void dsa_slave_mii_bus_init(struct dsa_switch *ds)
	41	{
	42	ds->slave_mii_bus->priv = (void *)ds;
	43	ds->slave_mii_bus->name = "dsa slave smi";
	44	ds->slave_mii_bus->read = dsa_slave_phy_read;
	45	ds->slave_mii_bus->write = dsa_slave_phy_write;
f490be04 FF	46	snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "dsa-%d:%.2x",
f490be04 FF	47	ds->index, ds->pd->sw_addr);
b4d2394d	48	ds->slave_mii_bus->parent = ds->master_dev;
24df8986	49	ds->slave_mii_bus->phy_mask = ~ds->phys_mii_mask;
91da11f8 LB	50	}
	51
	52
	53	/* slave device handling ****************************************************/
c0840801 LB	54	static int dsa_slave_init(struct net_device *dev)
	55	{
	56	struct dsa_slave_priv *p = netdev_priv(dev);
c0840801	57
e84665c9	58	dev->iflink = p->parent->dst->master_netdev->ifindex;
c0840801 LB	59
	60	return 0;
	61	}
	62
91da11f8 LB	63	static int dsa_slave_open(struct net_device *dev)
91da11f8 LB	64	{
df02c6ff	65	struct dsa_slave_priv *p = netdev_priv(dev);
e84665c9	66	struct net_device *master = p->parent->dst->master_netdev;
b2f2af21	67	struct dsa_switch *ds = p->parent;
df02c6ff LB	68	int err;
	69
	70	if (!(master->flags & IFF_UP))
	71	return -ENETDOWN;
	72
8feedbb4	73	if (!ether_addr_equal(dev->dev_addr, master->dev_addr)) {
a748ee24	74	err = dev_uc_add(master, dev->dev_addr);
df02c6ff LB	75	if (err < 0)
	76	goto out;
	77	}
	78
	79	if (dev->flags & IFF_ALLMULTI) {
	80	err = dev_set_allmulti(master, 1);
	81	if (err < 0)
	82	goto del_unicast;
	83	}
	84	if (dev->flags & IFF_PROMISC) {
	85	err = dev_set_promiscuity(master, 1);
	86	if (err < 0)
	87	goto clear_allmulti;
	88	}
	89
b2f2af21 FF	90	if (ds->drv->port_enable) {
	91	err = ds->drv->port_enable(ds, p->port, p->phy);
	92	if (err)
	93	goto clear_promisc;
	94	}
	95
f7f1de51 FF	96	if (p->phy)
	97	phy_start(p->phy);
	98
91da11f8	99	return 0;
df02c6ff	100
b2f2af21 FF	101	clear_promisc:
	102	if (dev->flags & IFF_PROMISC)
	103	dev_set_promiscuity(master, 0);
df02c6ff LB	104	clear_allmulti:
	105	if (dev->flags & IFF_ALLMULTI)
	106	dev_set_allmulti(master, -1);
	107	del_unicast:
8feedbb4	108	if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
a748ee24	109	dev_uc_del(master, dev->dev_addr);
df02c6ff LB	110	out:
df02c6ff LB	111	return err;
91da11f8 LB	112	}
	113
	114	static int dsa_slave_close(struct net_device *dev)
	115	{
df02c6ff	116	struct dsa_slave_priv *p = netdev_priv(dev);
e84665c9	117	struct net_device *master = p->parent->dst->master_netdev;
b2f2af21	118	struct dsa_switch *ds = p->parent;
df02c6ff	119
f7f1de51 FF	120	if (p->phy)
	121	phy_stop(p->phy);
	122
df02c6ff	123	dev_mc_unsync(master, dev);
a748ee24	124	dev_uc_unsync(master, dev);
df02c6ff LB	125	if (dev->flags & IFF_ALLMULTI)
	126	dev_set_allmulti(master, -1);
	127	if (dev->flags & IFF_PROMISC)
	128	dev_set_promiscuity(master, -1);
	129
8feedbb4	130	if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
a748ee24	131	dev_uc_del(master, dev->dev_addr);
df02c6ff	132
b2f2af21 FF	133	if (ds->drv->port_disable)
	134	ds->drv->port_disable(ds, p->port, p->phy);
	135
91da11f8 LB	136	return 0;
	137	}
	138
	139	static void dsa_slave_change_rx_flags(struct net_device *dev, int change)
	140	{
	141	struct dsa_slave_priv *p = netdev_priv(dev);
e84665c9	142	struct net_device *master = p->parent->dst->master_netdev;
91da11f8 LB	143
	144	if (change & IFF_ALLMULTI)
	145	dev_set_allmulti(master, dev->flags & IFF_ALLMULTI ? 1 : -1);
	146	if (change & IFF_PROMISC)
	147	dev_set_promiscuity(master, dev->flags & IFF_PROMISC ? 1 : -1);
	148	}
	149
	150	static void dsa_slave_set_rx_mode(struct net_device *dev)
	151	{
	152	struct dsa_slave_priv *p = netdev_priv(dev);
e84665c9	153	struct net_device *master = p->parent->dst->master_netdev;
91da11f8 LB	154
91da11f8 LB	155	dev_mc_sync(master, dev);
a748ee24	156	dev_uc_sync(master, dev);
91da11f8 LB	157	}
91da11f8 LB	158
df02c6ff	159	static int dsa_slave_set_mac_address(struct net_device dev, void a)
91da11f8	160	{
df02c6ff	161	struct dsa_slave_priv *p = netdev_priv(dev);
e84665c9	162	struct net_device *master = p->parent->dst->master_netdev;
df02c6ff LB	163	struct sockaddr *addr = a;
	164	int err;
	165
	166	if (!is_valid_ether_addr(addr->sa_data))
	167	return -EADDRNOTAVAIL;
	168
	169	if (!(dev->flags & IFF_UP))
	170	goto out;
	171
8feedbb4	172	if (!ether_addr_equal(addr->sa_data, master->dev_addr)) {
a748ee24	173	err = dev_uc_add(master, addr->sa_data);
df02c6ff LB	174	if (err < 0)
	175	return err;
	176	}
	177
8feedbb4	178	if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
a748ee24	179	dev_uc_del(master, dev->dev_addr);
df02c6ff LB	180
df02c6ff LB	181	out:
d08f161a	182	ether_addr_copy(dev->dev_addr, addr->sa_data);
91da11f8 LB	183
	184	return 0;
	185	}
	186
	187	static int dsa_slave_ioctl(struct net_device dev, struct ifreq ifr, int cmd)
	188	{
	189	struct dsa_slave_priv *p = netdev_priv(dev);
91da11f8 LB	190
91da11f8 LB	191	if (p->phy != NULL)
28b04113	192	return phy_mii_ioctl(p->phy, ifr, cmd);
91da11f8 LB	193
	194	return -EOPNOTSUPP;
	195	}
	196
3e8a72d1 FF	197	static netdev_tx_t dsa_slave_xmit(struct sk_buff skb, struct net_device dev)
	198	{
	199	struct dsa_slave_priv *p = netdev_priv(dev);
3e8a72d1	200
5075314e	201	return p->xmit(skb, dev);
3e8a72d1 FF	202	}
3e8a72d1 FF	203
5aed85ce FF	204	static netdev_tx_t dsa_slave_notag_xmit(struct sk_buff *skb,
	205	struct net_device *dev)
	206	{
	207	struct dsa_slave_priv *p = netdev_priv(dev);
	208
	209	skb->dev = p->parent->dst->master_netdev;
	210	dev_queue_xmit(skb);
	211
	212	return NETDEV_TX_OK;
	213	}
	214
91da11f8 LB	215
	216	/* ethtool operations *******************************************************/
	217	static int
	218	dsa_slave_get_settings(struct net_device dev, struct ethtool_cmd cmd)
	219	{
	220	struct dsa_slave_priv *p = netdev_priv(dev);
	221	int err;
	222
	223	err = -EOPNOTSUPP;
	224	if (p->phy != NULL) {
	225	err = phy_read_status(p->phy);
	226	if (err == 0)
	227	err = phy_ethtool_gset(p->phy, cmd);
	228	}
	229
	230	return err;
	231	}
	232
	233	static int
	234	dsa_slave_set_settings(struct net_device dev, struct ethtool_cmd cmd)
	235	{
	236	struct dsa_slave_priv *p = netdev_priv(dev);
	237
	238	if (p->phy != NULL)
	239	return phy_ethtool_sset(p->phy, cmd);
	240
	241	return -EOPNOTSUPP;
	242	}
	243
	244	static void dsa_slave_get_drvinfo(struct net_device *dev,
	245	struct ethtool_drvinfo *drvinfo)
	246	{
7826d43f JP	247	strlcpy(drvinfo->driver, "dsa", sizeof(drvinfo->driver));
	248	strlcpy(drvinfo->version, dsa_driver_version, sizeof(drvinfo->version));
	249	strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
	250	strlcpy(drvinfo->bus_info, "platform", sizeof(drvinfo->bus_info));
91da11f8 LB	251	}
91da11f8 LB	252
3d762a0f GR	253	static int dsa_slave_get_regs_len(struct net_device *dev)
	254	{
	255	struct dsa_slave_priv *p = netdev_priv(dev);
	256	struct dsa_switch *ds = p->parent;
	257
	258	if (ds->drv->get_regs_len)
	259	return ds->drv->get_regs_len(ds, p->port);
	260
	261	return -EOPNOTSUPP;
	262	}
	263
	264	static void
	265	dsa_slave_get_regs(struct net_device dev, struct ethtool_regs regs, void *_p)
	266	{
	267	struct dsa_slave_priv *p = netdev_priv(dev);
	268	struct dsa_switch *ds = p->parent;
	269
	270	if (ds->drv->get_regs)
	271	ds->drv->get_regs(ds, p->port, regs, _p);
	272	}
	273
91da11f8 LB	274	static int dsa_slave_nway_reset(struct net_device *dev)
	275	{
	276	struct dsa_slave_priv *p = netdev_priv(dev);
	277
	278	if (p->phy != NULL)
	279	return genphy_restart_aneg(p->phy);
	280
	281	return -EOPNOTSUPP;
	282	}
	283
	284	static u32 dsa_slave_get_link(struct net_device *dev)
	285	{
	286	struct dsa_slave_priv *p = netdev_priv(dev);
	287
	288	if (p->phy != NULL) {
	289	genphy_update_link(p->phy);
	290	return p->phy->link;
	291	}
	292
	293	return -EOPNOTSUPP;
	294	}
	295
6793abb4 GR	296	static int dsa_slave_get_eeprom_len(struct net_device *dev)
	297	{
	298	struct dsa_slave_priv *p = netdev_priv(dev);
	299	struct dsa_switch *ds = p->parent;
	300
	301	if (ds->pd->eeprom_len)
	302	return ds->pd->eeprom_len;
	303
	304	if (ds->drv->get_eeprom_len)
	305	return ds->drv->get_eeprom_len(ds);
	306
	307	return 0;
	308	}
	309
	310	static int dsa_slave_get_eeprom(struct net_device *dev,
	311	struct ethtool_eeprom eeprom, u8 data)
	312	{
	313	struct dsa_slave_priv *p = netdev_priv(dev);
	314	struct dsa_switch *ds = p->parent;
	315
	316	if (ds->drv->get_eeprom)
	317	return ds->drv->get_eeprom(ds, eeprom, data);
	318
	319	return -EOPNOTSUPP;
	320	}
	321
	322	static int dsa_slave_set_eeprom(struct net_device *dev,
	323	struct ethtool_eeprom eeprom, u8 data)
	324	{
	325	struct dsa_slave_priv *p = netdev_priv(dev);
	326	struct dsa_switch *ds = p->parent;
	327
	328	if (ds->drv->set_eeprom)
	329	return ds->drv->set_eeprom(ds, eeprom, data);
	330
	331	return -EOPNOTSUPP;
	332	}
	333
91da11f8 LB	334	static void dsa_slave_get_strings(struct net_device *dev,
	335	uint32_t stringset, uint8_t *data)
	336	{
	337	struct dsa_slave_priv *p = netdev_priv(dev);
	338	struct dsa_switch *ds = p->parent;
	339
	340	if (stringset == ETH_SS_STATS) {
	341	int len = ETH_GSTRING_LEN;
	342
	343	strncpy(data, "tx_packets", len);
	344	strncpy(data + len, "tx_bytes", len);
	345	strncpy(data + 2 * len, "rx_packets", len);
	346	strncpy(data + 3 * len, "rx_bytes", len);
	347	if (ds->drv->get_strings != NULL)
	348	ds->drv->get_strings(ds, p->port, data + 4 * len);
	349	}
	350	}
	351
	352	static void dsa_slave_get_ethtool_stats(struct net_device *dev,
	353	struct ethtool_stats *stats,
	354	uint64_t *data)
	355	{
	356	struct dsa_slave_priv *p = netdev_priv(dev);
	357	struct dsa_switch *ds = p->parent;
	358
	359	data[0] = p->dev->stats.tx_packets;
	360	data[1] = p->dev->stats.tx_bytes;
	361	data[2] = p->dev->stats.rx_packets;
	362	data[3] = p->dev->stats.rx_bytes;
	363	if (ds->drv->get_ethtool_stats != NULL)
	364	ds->drv->get_ethtool_stats(ds, p->port, data + 4);
	365	}
	366
	367	static int dsa_slave_get_sset_count(struct net_device *dev, int sset)
	368	{
	369	struct dsa_slave_priv *p = netdev_priv(dev);
	370	struct dsa_switch *ds = p->parent;
	371
	372	if (sset == ETH_SS_STATS) {
	373	int count;
	374
	375	count = 4;
	376	if (ds->drv->get_sset_count != NULL)
	377	count += ds->drv->get_sset_count(ds);
	378
	379	return count;
	380	}
	381
	382	return -EOPNOTSUPP;
	383	}
	384
19e57c4e FF	385	static void dsa_slave_get_wol(struct net_device dev, struct ethtool_wolinfo w)
	386	{
	387	struct dsa_slave_priv *p = netdev_priv(dev);
	388	struct dsa_switch *ds = p->parent;
	389
	390	if (ds->drv->get_wol)
	391	ds->drv->get_wol(ds, p->port, w);
	392	}
	393
	394	static int dsa_slave_set_wol(struct net_device dev, struct ethtool_wolinfo w)
	395	{
	396	struct dsa_slave_priv *p = netdev_priv(dev);
	397	struct dsa_switch *ds = p->parent;
	398	int ret = -EOPNOTSUPP;
	399
	400	if (ds->drv->set_wol)
	401	ret = ds->drv->set_wol(ds, p->port, w);
	402
	403	return ret;
	404	}
	405
7905288f FF	406	static int dsa_slave_set_eee(struct net_device dev, struct ethtool_eee e)
	407	{
	408	struct dsa_slave_priv *p = netdev_priv(dev);
	409	struct dsa_switch *ds = p->parent;
	410	int ret;
	411
	412	if (!ds->drv->set_eee)
	413	return -EOPNOTSUPP;
	414
	415	ret = ds->drv->set_eee(ds, p->port, p->phy, e);
	416	if (ret)
	417	return ret;
	418
	419	if (p->phy)
	420	ret = phy_ethtool_set_eee(p->phy, e);
	421
	422	return ret;
	423	}
	424
	425	static int dsa_slave_get_eee(struct net_device dev, struct ethtool_eee e)
	426	{
	427	struct dsa_slave_priv *p = netdev_priv(dev);
	428	struct dsa_switch *ds = p->parent;
	429	int ret;
	430
	431	if (!ds->drv->get_eee)
	432	return -EOPNOTSUPP;
	433
	434	ret = ds->drv->get_eee(ds, p->port, e);
	435	if (ret)
	436	return ret;
	437
	438	if (p->phy)
	439	ret = phy_ethtool_get_eee(p->phy, e);
	440
	441	return ret;
	442	}
	443
91da11f8 LB	444	static const struct ethtool_ops dsa_slave_ethtool_ops = {
	445	.get_settings = dsa_slave_get_settings,
	446	.set_settings = dsa_slave_set_settings,
	447	.get_drvinfo = dsa_slave_get_drvinfo,
3d762a0f GR	448	.get_regs_len = dsa_slave_get_regs_len,
3d762a0f GR	449	.get_regs = dsa_slave_get_regs,
91da11f8 LB	450	.nway_reset = dsa_slave_nway_reset,
91da11f8 LB	451	.get_link = dsa_slave_get_link,
6793abb4 GR	452	.get_eeprom_len = dsa_slave_get_eeprom_len,
	453	.get_eeprom = dsa_slave_get_eeprom,
	454	.set_eeprom = dsa_slave_set_eeprom,
91da11f8 LB	455	.get_strings = dsa_slave_get_strings,
	456	.get_ethtool_stats = dsa_slave_get_ethtool_stats,
	457	.get_sset_count = dsa_slave_get_sset_count,
19e57c4e FF	458	.set_wol = dsa_slave_set_wol,
19e57c4e FF	459	.get_wol = dsa_slave_get_wol,
7905288f FF	460	.set_eee = dsa_slave_set_eee,
7905288f FF	461	.get_eee = dsa_slave_get_eee,
91da11f8 LB	462	};
91da11f8 LB	463
3e8a72d1	464	static const struct net_device_ops dsa_slave_netdev_ops = {
c0840801	465	.ndo_init = dsa_slave_init,
d442ad4a SH	466	.ndo_open = dsa_slave_open,
d442ad4a SH	467	.ndo_stop = dsa_slave_close,
3e8a72d1	468	.ndo_start_xmit = dsa_slave_xmit,
d442ad4a SH	469	.ndo_change_rx_flags = dsa_slave_change_rx_flags,
d442ad4a SH	470	.ndo_set_rx_mode = dsa_slave_set_rx_mode,
d442ad4a SH	471	.ndo_set_mac_address = dsa_slave_set_mac_address,
	472	.ndo_do_ioctl = dsa_slave_ioctl,
	473	};
91da11f8	474
0d8bcdd3 FF	475	static void dsa_slave_adjust_link(struct net_device *dev)
	476	{
	477	struct dsa_slave_priv *p = netdev_priv(dev);
ec9436ba	478	struct dsa_switch *ds = p->parent;
0d8bcdd3 FF	479	unsigned int status_changed = 0;
	480
	481	if (p->old_link != p->phy->link) {
	482	status_changed = 1;
	483	p->old_link = p->phy->link;
	484	}
	485
	486	if (p->old_duplex != p->phy->duplex) {
	487	status_changed = 1;
	488	p->old_duplex = p->phy->duplex;
	489	}
	490
	491	if (p->old_pause != p->phy->pause) {
	492	status_changed = 1;
	493	p->old_pause = p->phy->pause;
	494	}
	495
ec9436ba FF	496	if (ds->drv->adjust_link && status_changed)
	497	ds->drv->adjust_link(ds, p->port, p->phy);
	498
0d8bcdd3 FF	499	if (status_changed)
	500	phy_print_status(p->phy);
	501	}
	502
ce31b31c FF	503	static int dsa_slave_fixed_link_update(struct net_device *dev,
	504	struct fixed_phy_status *status)
	505	{
	506	struct dsa_slave_priv *p = netdev_priv(dev);
	507	struct dsa_switch *ds = p->parent;
	508
	509	if (ds->drv->fixed_link_update)
	510	ds->drv->fixed_link_update(ds, p->port, status);
	511
	512	return 0;
	513	}
	514
91da11f8	515	/* slave device setup *******************************************************/
9697f1cd	516	static int dsa_slave_phy_setup(struct dsa_slave_priv *p,
0d8bcdd3 FF	517	struct net_device *slave_dev)
	518	{
	519	struct dsa_switch *ds = p->parent;
	520	struct dsa_chip_data *cd = ds->pd;
	521	struct device_node phy_dn, port_dn;
ce31b31c	522	bool phy_is_fixed = false;
6819563e	523	u32 phy_flags = 0;
19334920	524	int mode, ret;
0d8bcdd3 FF	525
0d8bcdd3 FF	526	port_dn = cd->port_dn[p->port];
19334920 GR	527	mode = of_get_phy_mode(port_dn);
	528	if (mode < 0)
	529	mode = PHY_INTERFACE_MODE_NA;
	530	p->phy_interface = mode;
0d8bcdd3 FF	531
	532	phy_dn = of_parse_phandle(port_dn, "phy-handle", 0);
	533	if (of_phy_is_fixed_link(port_dn)) {
	534	/* In the case of a fixed PHY, the DT node associated
	535	* to the fixed PHY is the Port DT node
	536	*/
	537	ret = of_phy_register_fixed_link(port_dn);
	538	if (ret) {
a2ae6007	539	netdev_err(slave_dev, "failed to register fixed PHY\n");
9697f1cd	540	return ret;
0d8bcdd3	541	}
ce31b31c	542	phy_is_fixed = true;
0d8bcdd3 FF	543	phy_dn = port_dn;
	544	}
	545
6819563e FF	546	if (ds->drv->get_phy_flags)
	547	phy_flags = ds->drv->get_phy_flags(ds, p->port);
	548
0d8bcdd3 FF	549	if (phy_dn)
0d8bcdd3 FF	550	p->phy = of_phy_connect(slave_dev, phy_dn,
6819563e	551	dsa_slave_adjust_link, phy_flags,
0d8bcdd3 FF	552	p->phy_interface);
0d8bcdd3 FF	553
ce31b31c FF	554	if (p->phy && phy_is_fixed)
	555	fixed_phy_set_link_update(p->phy, dsa_slave_fixed_link_update);
	556
0d8bcdd3 FF	557	/* We could not connect to a designated PHY, so use the switch internal
	558	* MDIO bus instead
	559	*/
b31f65fb	560	if (!p->phy) {
0d8bcdd3	561	p->phy = ds->slave_mii_bus->phy_map[p->port];
53013c77	562	if (!p->phy)
9697f1cd	563	return -ENODEV;
53013c77	564
19334920 GR	565	/* Use already configured phy mode */
19334920 GR	566	p->phy_interface = p->phy->interface;
b31f65fb AL	567	phy_connect_direct(slave_dev, p->phy, dsa_slave_adjust_link,
	568	p->phy_interface);
	569	} else {
a2ae6007 JP	570	netdev_info(slave_dev, "attached PHY at address %d [%s]\n",
a2ae6007 JP	571	p->phy->addr, p->phy->drv->name);
b31f65fb	572	}
9697f1cd FF	573
9697f1cd FF	574	return 0;
0d8bcdd3 FF	575	}
0d8bcdd3 FF	576
24462549 FF	577	int dsa_slave_suspend(struct net_device *slave_dev)
	578	{
	579	struct dsa_slave_priv *p = netdev_priv(slave_dev);
	580
	581	netif_device_detach(slave_dev);
	582
	583	if (p->phy) {
	584	phy_stop(p->phy);
	585	p->old_pause = -1;
	586	p->old_link = -1;
	587	p->old_duplex = -1;
	588	phy_suspend(p->phy);
	589	}
	590
	591	return 0;
	592	}
	593
	594	int dsa_slave_resume(struct net_device *slave_dev)
	595	{
	596	struct dsa_slave_priv *p = netdev_priv(slave_dev);
	597
	598	netif_device_attach(slave_dev);
	599
	600	if (p->phy) {
	601	phy_resume(p->phy);
	602	phy_start(p->phy);
	603	}
	604
	605	return 0;
	606	}
	607
d87d6f44 GR	608	int dsa_slave_create(struct dsa_switch ds, struct device parent,
d87d6f44 GR	609	int port, char *name)
91da11f8	610	{
e84665c9	611	struct net_device *master = ds->dst->master_netdev;
91da11f8 LB	612	struct net_device *slave_dev;
	613	struct dsa_slave_priv *p;
	614	int ret;
	615
c835a677 TG	616	slave_dev = alloc_netdev(sizeof(struct dsa_slave_priv), name,
c835a677 TG	617	NET_NAME_UNKNOWN, ether_setup);
91da11f8	618	if (slave_dev == NULL)
d87d6f44	619	return -ENOMEM;
91da11f8 LB	620
91da11f8 LB	621	slave_dev->features = master->vlan_features;
7ad24ea4	622	slave_dev->ethtool_ops = &dsa_slave_ethtool_ops;
2fcc8005	623	eth_hw_addr_inherit(slave_dev, master);
91da11f8	624	slave_dev->tx_queue_len = 0;
3e8a72d1	625	slave_dev->netdev_ops = &dsa_slave_netdev_ops;
d442ad4a	626
5075314e AD	627	SET_NETDEV_DEV(slave_dev, parent);
	628	slave_dev->dev.of_node = ds->pd->port_dn[port];
	629	slave_dev->vlan_features = master->vlan_features;
	630
	631	p = netdev_priv(slave_dev);
	632	p->dev = slave_dev;
	633	p->parent = ds;
	634	p->port = port;
	635
e84665c9	636	switch (ds->dst->tag_protocol) {
cf85d08f	637	#ifdef CONFIG_NET_DSA_TAG_DSA
ac7a04c3	638	case DSA_TAG_PROTO_DSA:
5075314e	639	p->xmit = dsa_netdev_ops.xmit;
cf85d08f LB	640	break;
cf85d08f LB	641	#endif
91da11f8	642	#ifdef CONFIG_NET_DSA_TAG_EDSA
ac7a04c3	643	case DSA_TAG_PROTO_EDSA:
5075314e	644	p->xmit = edsa_netdev_ops.xmit;
91da11f8	645	break;
396138f0 LB	646	#endif
396138f0 LB	647	#ifdef CONFIG_NET_DSA_TAG_TRAILER
ac7a04c3	648	case DSA_TAG_PROTO_TRAILER:
5075314e	649	p->xmit = trailer_netdev_ops.xmit;
396138f0	650	break;
5037d532 FF	651	#endif
5037d532 FF	652	#ifdef CONFIG_NET_DSA_TAG_BRCM
ac7a04c3	653	case DSA_TAG_PROTO_BRCM:
5075314e	654	p->xmit = brcm_netdev_ops.xmit;
5037d532	655	break;
91da11f8 LB	656	#endif
91da11f8 LB	657	default:
5075314e	658	p->xmit = dsa_slave_notag_xmit;
5aed85ce	659	break;
91da11f8	660	}
d442ad4a	661
0d8bcdd3 FF	662	p->old_pause = -1;
	663	p->old_link = -1;
	664	p->old_duplex = -1;
	665
9697f1cd FF	666	ret = dsa_slave_phy_setup(p, slave_dev);
	667	if (ret) {
	668	free_netdev(slave_dev);
d87d6f44	669	return ret;
9697f1cd	670	}
91da11f8	671
d87d6f44	672	ds->ports[port] = slave_dev;
91da11f8 LB	673	ret = register_netdev(slave_dev);
91da11f8 LB	674	if (ret) {
a2ae6007 JP	675	netdev_err(master, "error %d registering interface %s\n",
a2ae6007 JP	676	ret, slave_dev->name);
9697f1cd	677	phy_disconnect(p->phy);
d87d6f44	678	ds->ports[port] = NULL;
91da11f8	679	free_netdev(slave_dev);
d87d6f44	680	return ret;
91da11f8 LB	681	}
	682
	683	netif_carrier_off(slave_dev);
	684
d87d6f44	685	return 0;
91da11f8	686	}