use m4 rather than gm4
[deliverable/binutils-gdb.git] / standards.texi
CommitLineData
b42b3782
RP
1\input texinfo @c -*-texinfo-*-
2@c %**start of header
3@setfilename standards.text
4@settitle GNU Coding Standards
5@c %**end of header
6
7@setchapternewpage off
8
9@ifinfo
10Copyright (C) 1992 Free Software Foundation
11Permission is granted to make and distribute verbatim copies of
12this manual provided the copyright notice and this permission notice
13are preserved on all copies.
14
15@ignore
16Permission is granted to process this file through TeX and print the
17results, provided the printed document carries copying permission
18notice identical to this one except for the removal of this paragraph
19(this paragraph not being relevant to the printed manual).
20@end ignore
21
22Permission is granted to copy and distribute modified versions of this
23manual under the conditions for verbatim copying, provided that the entire
24resulting derived work is distributed under the terms of a permission
25notice identical to this one.
26
27Permission is granted to copy and distribute translations of this manual
28into another language, under the above conditions for modified versions,
29except that this permission notice may be stated in a translation approved
30by the Free Software Foundation.
31@end ifinfo
32
33@titlepage
34@sp 10
35@titlefont{GNU Coding Standards}
36@author{Richard Stallman}
a60ff512 37@author{last updated 3 May 1992}
b42b3782
RP
38@c Note date also appears below.
39@page
40
41@vskip 0pt plus 1filll
42Copyright @copyright{} 1992 Free Software Foundation
43
44Permission is granted to make and distribute verbatim copies of
45this manual provided the copyright notice and this permission notice
46are preserved on all copies.
47
48Permission is granted to copy and distribute modified versions of this
49manual under the conditions for verbatim copying, provided that the entire
50resulting derived work is distributed under the terms of a permission
51notice identical to this one.
52
53Permission is granted to copy and distribute translations of this manual
54into another language, under the above conditions for modified versions,
55except that this permission notice may be stated in a translation approved
56by Free Software Foundation.
57@end titlepage
58
59@ifinfo
95a3881d
RP
60@format
61START-INFO-DIR-ENTRY
62* standards: (standards.info). The GNU coding standards.
63END-INFO-DIR-ENTRY
64@end format
65
b42b3782
RP
66@node Top, Reading Non-Free Code, (dir), (dir)
67@top Version
68
a60ff512 69Last updated 3 May 1992.
b42b3782
RP
70@c Note date also appears above.
71@end ifinfo
72
73@menu
74* Reading Non-Free Code:: Referring to Proprietary Programs
75* Contributions:: Accepting Contributions
76* Change Logs:: Recording Changes
77* Compatibility:: Compatibility with Other Implementations
78* Makefiles:: Makefile Conventions
79* Configuration:: How Configuration Should Work
80* Source Language:: Using Languages Other Than C
81* Formatting:: Formatting Your Source Code
82* Comments:: Commenting Your Work
83* Syntactic Conventions:: Clean Use of C Constructs
84* Names:: Naming Variables and Functions
85* Using Extensions:: Using Non-standard Features
86* Semantics:: Program Behaviour for All Programs
87* Errors:: Formatting Error Messages
88* Libraries:: Library Behaviour
89* Portability:: Portability As It Applies to GNU
90* User Interfaces:: Standards for Command Line Interfaces
91* Documentation:: Documenting Programs
92* Releases:: Making Releases
93@end menu
94
95@node Reading Non-Free Code
96@chapter Referring to Proprietary Programs
97
98Don't in any circumstances refer to Unix source code for or during
99your work on GNU! (Or to any other proprietary programs.)
100
101If you have a vague recollection of the internals of a Unix program,
102this does not absolutely mean you can't write an imitation of it, but
103do try to organize the imitation internally along different lines,
104because this is likely to make the details of the Unix version
105irrelevant and dissimilar to your results.
106
107For example, Unix utilities were generally optimized to minimize
108memory use; if you go for speed instead, your program will be very
109different. You could keep the entire input file in core and scan it
110there instead of using stdio. Use a smarter algorithm discovered more
111recently than the Unix program. Eliminate use of temporary files. Do
112it in one pass instead of two (we did this in the assembler).
113
114Or, on the contrary, emphasize simplicity instead of speed. For some
115applications, the speed of today's computers makes simpler algorithms
116adequate.
117
118Or go for generality. For example, Unix programs often have static
119tables or fixed-size strings, which make for arbitrary limits; use
120dynamic allocation instead. Make sure your program handles NULs and
121other funny characters in the input files. Add a programming language
122for extensibility and write part of the program in that language.
123
124Or turn some parts of the program into independently usable libraries.
125Or use a simple garbage collector instead of tracking precisely when
126to free memory, or use a new GNU facility such as obstacks.
127
128
129@node Contributions
130@chapter Accepting Contributions
131
132If someone else sends you a piece of code to add to the program you are
133working on, we need legal papers to use it---the same sort of legal
134papers we will need to get from you. @emph{Each} significant
135contributor to a program must sign some sort of legal papers in order
136for us to have clear title to the program. The main author alone is not
137enough.
138
139So, before adding in any contributions from other people, tell us
140so we can arrange to get the papers. Then wait until we tell you
141that we have received the signed papers, before you actually use the
142contribution.
143
144This applies both before you release the program and afterward. If
145you receive diffs to fix a bug, and they make significant change, we
146need legal papers for it.
147
148You don't need papers for changes of a few lines here or there, since
149they are not significant for copyright purposes. Also, you don't need
150papers if all you get from the suggestion is some ideas, not actual code
151which you use. For example, if you write a different solution to the
152problem, you don't need to get papers.
153
154I know this is frustrating; it's frustrating for us as well. But if
155you don't wait, you are going out on a limb---for example, what if the
156contributor's employer won't sign a disclaimer? You might have to take
157that code out again!
158
159The very worst thing is if you forget to tell us about the other
160contributor. We could be very embarrassed in court some day as a
161result.
162
163@node Change Logs
164@chapter Change Logs
165
166Keep a change log for each directory, describing the changes made to
167source files in that directory. The purpose of this is so that people
168investigating bugs in the future will know about the changes that
169might have introduced the bug. Often a new bug can be found by
170looking at what was recently changed. More importantly, change logs
171can help eliminate conceptual inconsistencies between different parts
172of a program; they can give you a history of how the conflicting
173concepts arose.
174
175Use the Emacs command @kbd{M-x add-change} to start a new entry in the
176change log. An entry should have an asterisk, the name of the changed
177file, and then in parentheses the name of the changed functions,
178variables or whatever, followed by a colon. Then describe the changes
179you made to that function or variable.
180
181Separate unrelated entries with blank lines. When two entries
182represent parts of the same change, so that they work together, then
183don't put blank lines between them. Then you can omit the file name
184and the asterisk when successive entries are in the same file.
185
186Here are some examples:
187
188@example
189* register.el (insert-register): Return nil.
190(jump-to-register): Likewise.
191
192* sort.el (sort-subr): Return nil.
193
194* tex-mode.el (tex-bibtex-file, tex-file, tex-region):
195Restart the tex shell if process is gone or stopped.
196(tex-shell-running): New function.
197
198* expr.c (store_one_arg): Round size up for move_block_to_reg.
199(expand_call): Round up when emitting USE insns.
200* stmt.c (assign_parms): Round size up for move_block_from_reg.
201@end example
202
203There's no need to describe here the full purpose of the changes or how
204they work together. It is better to put this explanation in comments in
205the code. That's why just ``New function'' is enough; there is a
206comment with the function in the source to explain what it does.
207
208However, sometimes it is useful to write one line to describe the
209overall purpose of a large batch of changes.
210
211When you change the calling sequence of a function in a simple
212fashion, and you change all the callers of the function, there is no
213need to make individual entries for all the callers. Just write in
214the entry for the function being called, ``All callers changed.''
215
216When you change just comments or doc strings, it is enough to write an
217entry for the file, without mentioning the functions. Write just,
218``Doc fix.'' There's no need to keep a change log for documentation
219files. This is because documentation is not susceptible to bugs that
220are hard to fix. Documentation does not consist of parts that must
221interact in a precisely engineered fashion; to correct an error, you
222need not know the history of the erroneous passage.
223
224
225@node Compatibility
226@chapter Compatibility with Other Implementations
227
228With certain exceptions, utility programs and libraries for GNU should
229be upward compatible with those in Berkeley Unix, and upward compatible
230with @sc{ANSI} C if @sc{ANSI} C specifies their behavior, and upward
231compatible with @sc{POSIX} if @sc{POSIX} specifies their behavior.
232
233When these standards conflict, it is useful to offer compatibility
234modes for each of them.
235
236@sc{ANSI} C and @sc{POSIX} prohibit many kinds of extensions. Feel
237free to make the extensions anyway, and include a @samp{--ansi} or
238@samp{--compatible} option to turn them off. However, if the extension
239has a significant chance of breaking any real programs or scripts,
240then it is not really upward compatible. Try to redesign its
241interface.
242
243When a feature is used only by users (not by programs or command
244files), and it is done poorly in Unix, feel free to replace it
245completely with something totally different and better. (For example,
246vi is replaced with Emacs.) But it is nice to offer a compatible
247feature as well. (There is a free vi clone, so we offer it.)
248
249Additional useful features not in Berkeley Unix are welcome.
250Additional programs with no counterpart in Unix may be useful,
251but our first priority is usually to duplicate what Unix already
252has.
253
254
255@node Makefiles
256@chapter Makefile Conventions
257
258This chapter describes conventions for writing Makefiles.
259
260@menu
261* Makefile Basics::
262* Standard Targets::
263* Command Variables::
264* Directory Variables::
265@end menu
266
267@node Makefile Basics
268@section General Conventions for Makefiles
269
270Every Makefile should contain this line:
271
272@example
273SHELL = /bin/sh
274@end example
275
276@noindent
277to avoid trouble on systems where the @code{SHELL} variable might be
278inherited from the environment.
279
280Don't assume that @file{.} is in the path for command execution. When
281you need to run programs that are files in the current directory, always
282use @file{./} to make sure the proper file is run regardless of the
283current path.
284
285@node Standard Targets
286@section Standard Targets for Users
287
288All GNU programs should have the following targets in their Makefiles:
289
290@table @samp
291@item all
292Compile the entire program.
293
294@item install
295Compile the program and copy the executables, libraries, and so on to
296the file names where they should reside for actual use. If there is a
297simple test to verify that a program is properly installed then run that
298test.
299
300@item clean
301Delete all files from the current directory that are normally created by
302building the program. Don't delete the files that record the
303configuration. Also preserve files that could be made by building, but
304normally aren't because the distribution comes with them.
305
306@item distclean
307Delete all files from the current directory that are created by
308configuring or building the program. This should leave only the files
309that would be in the distribution.
310
311@item mostlyclean
312Like @samp{clean}, but may refrain from deleting a few files that people
313normally don't want to recompile. For example, the @samp{mostlyclean}
314target for GCC does not delete @file{libgcc.a}, because recompiling it
315is rarely necessary and takes a lot of time.
316
317@item realclean
318Delete everything from the current directory that can be reconstructed
319with this Makefile. This typically includes everything deleted by
320distclean, plus more: C source files produced by Bison, tags tables,
321info files, and so on.
322
323@item TAGS
324Update a tags table for this program.
325
326@item dist
327Create a distribution tar file for this program. The tar file should be
328set up so that the file names in the tar file start with a subdirectory
329name which is the name of the package it is a distribution for. This
330name can include the version number.
331
332For example, the distribution tar file of GCC version 1.40 unpacks into
333a subdirectory named @file{gcc-1.40}.
334
335The easiest way to do this is to create a subdirectory appropriately
336named, use @code{ln} or @code{cp} to install the proper files in it, and
337then @code{tar} that subdirectory.
338
339The @code{dist} target should explicitly depend on all non-source files
340that are in the distribution, to make sure they are up to date in the
341distribution. @xref{Releases}.
342
343@item check
344Perform self-tests (if any). The user must build the program before
345running the tests, but need not install the program; you should write
346the self-tests so that they work when the program is built but not
347installed.
348@end table
349
350@node Command Variables
351@section Variables for Specifying Commands
352
353Makefiles should provide variables for overriding certain commands, options,
354and so on.
355
356In particular, you should run most utility programs via variables.
357Thus, if you use Bison, have a variable named @code{BISON} whose default
358value is set with @samp{BISON = bison}, and refer to it with
359@code{$(BISON)} whenever you need to use Bison.
360
361Each program-name variable should come with an options variable that is
362used to supply options to the program. Append @samp{FLAGS} to the
363program-name variable name to get the options variable name---for
364example, @code{BISONFLAGS}. (The name @code{CFLAGS} is an exception to
365this rule, but we keep it because it is standard.)
366
367File-management utilities such as @code{ln}, @code{rm}, @code{mv}, and
368so on need not be referred to through variables in this way, since users
369don't need to replace them with other programs.
370
371Every Makefile should define the variable @code{INSTALL}, which is the
372basic command for installing a file into the system.
373
374Every Makefile should also define variables @code{INSTALL_PROGRAM} and
375@code{INSTALL_DATA}. (The default for each of these should be
376@code{$(INSTALL)}.) Then it should use those variables as the commands
377for actual installation, for executables and nonexecutables
378respectively. Use these variables as follows:
379
380@example
381$(INSTALL_PROGRAM) foo $@{bindir@}/foo
382$(INSTALL_DATA) libfoo.a $@{libdir@}/libfoo.a
383@end example
384
385@noindent
386(Always use a file name, not a directory name, as the second argument.
387Use a separate command for each file to be installed.)
388
389@node Directory Variables
390@section Variables for Installation Directories
391
392Installation directories should always be named by variables, so it is
393easy to install in a nonstandard place. The standard names for these
394variables are:
395
396@table @samp
a60ff512
RP
397@item prefix
398A prefix used in constructing the default values of the variables listed
399below. The default value of @code{prefix} should be @file{/usr/local}
400(at least for now).
401
402@item exec_prefix
403A prefix used in constructing the default values of the some of the
404variables listed below. The default value of @code{exec_prefix} should
405be @code{$(prefix)}.
406
407Generally, @code{$(exec_prefix)} is used for directories that contain
408machine-specific files (such as executables and subroutine libraries),
409while @code{$(prefix)} is used directly for other directories.
410
b42b3782
RP
411@item bindir
412The directory for installing executable programs that users can run.
a60ff512
RP
413This should normally be @file{/usr/local/bin}, but it should be written
414as @file{$(exec_prefix)/bin}.
415
416@item libdir
417The directory for installing executable files to be run by the program
418rather than by users. Object files and libraries of object code should
419also go in this directory. The idea is that this directory is used for
420files that pertain to a specific machine architecture, but need not be
421in the path for commands. The value of @code{libdir} should normally be
422@file{/usr/local/lib}, but it should be written as
423@file{$(exec_prefix)/lib}.
b42b3782
RP
424
425@item datadir
426The directory for installing read-only data files which the programs
427refer to while they run. This directory is used for files which are
428independent of the type of machine being used. This should normally be
a60ff512
RP
429@file{/usr/local/lib}, but it should be written as
430@file{$(prefix)/lib}.
b42b3782
RP
431
432@item statedir
433The directory for installing data files which the programs modify while
434they run. These files should be independent of the type of machine
435being used, and it should be possible to share them among machines at a
436network installation. This should normally be @file{/usr/local/lib},
a60ff512 437but it should be written as @file{$(prefix)/lib}.
b42b3782
RP
438
439@item includedir
440The directory for installing @samp{#include} header files to be included
441by user programs. This should normally be @file{/usr/local/include},
a60ff512 442but it should be written as @file{$(prefix)/include}.
b42b3782
RP
443
444Most compilers other than GCC do not look for header files in
445@file{/usr/local/include}. So installing the header files this way is
446only useful with GCC. Sometimes this is not a problem because some
447libraries are only really intended to work with GCC. But some libraries
448are intended to work with other compilers. They should install their
449header files in two places, one specified by includedir and one
450specified by oldincludedir
451
452@item oldincludedir
453The directory for installing @samp{#include} header files for use with
454compilers other than GCC. This should normally be @file{/usr/include}.
455
456The Makefile commands should check whether the value of
457@code{oldincludedir} is empty. If it is, they should not try to use
458it; they should cancel the second installation of the header files.
459
460@item mandir
461The directory for installing the man pages (if any) for this package.
462It should include the suffix for the proper section of the
463manual---usually @samp{1} for a utility.
464
465@item man1dir
466The directory for installing section 1 man pages.
467@item man2dir
468The directory for installing section 2 man pages.
469@item @dots{}
470Use these names instead of @samp{mandir} if the package needs to install man
471pages in more than one section of the manual.
472
473@strong{Don't make the primary documentation for any GNU software be a
474man page. Write a manual in Texinfo instead. Man pages are just for
475the sake of people running GNU software on Unix, which is a secondary
476application only.}
477
478@item manext
479The file name extension for the installed man page. This should contain
480a period followed by the appropriate digit.
481
482@item infodir
483The directory for installing the info files for this package. By
a60ff512
RP
484default, it should be @file{/usr/local/info}, but it should be written
485as @file{$(prefix)/info}.
b42b3782
RP
486
487@item srcdir
488The directory for the sources being compiled. The value of this
489variable is normally inserted by the @code{configure} shell script.
b42b3782
RP
490@end table
491
492For example:
493
494@example
495# Common prefix for installation directories.
496# NOTE: This directory must exist when you start installation.
497prefix = /usr/local
a60ff512 498exec_prefix = $(prefix)
b42b3782 499# Directory in which to put the executable for the command `gcc'
a60ff512 500bindir = $(exec_prefix)/bin
b42b3782 501# Directory in which to put the directories used by the compiler.
a60ff512
RP
502libdir = $(exec_prefix)/lib
503# Directory in which to put the Info files.
504infodir = $(prefix)/info
b42b3782
RP
505@end example
506
b42b3782
RP
507@node Configuration
508@chapter How Configuration Should Work
509
510Each GNU distribution should come with a shell script named
511@code{configure}. This script is given arguments which describe the
512kind of machine and system you want to compile the program for.
513
514The @code{configure} script must record the configuration options so
515that they affect compilation.
516
517One way to do this is to make a link from a standard name such as
518@file{config.h} to the proper configuration file for the chosen system.
519If you use this technique, the distribution should @emph{not} contain a
520file named @file{config.h}. This is so that people won't be able to
521build the program without configuring it first.
522
523Another thing that @code{configure} can do is to edit the Makefile. If
524you do this, the distribution should @emph{not} contain a file named
525@file{Makefile}. Instead, include a file @file{Makefile.in} which
526contains the input used for editing. Once again, this is so that people
527won't be able to build the program without configuring it first.
528
529If @code{configure} does write the @file{Makefile}, then @file{Makefile}
530should have a target named @file{Makefile} which causes @code{configure}
531to be rerun, setting up the same configuration that was set up last
532time. The files that @code{configure} reads should be listed as
533dependencies of @file{Makefile}.
534
535All the files which are output from the @code{configure} script should
536have comments at the beginning explaining that they were generated
537automatically using @code{configure}. This is so that users won't think
538of trying to edit them by hand.
539
540The @code{configure} script should write a file named @file{config.status}
541which describes which configuration options were specified when the
542program was last configured. This file should be a shell script which,
543if run, will recreate the same configuration.
544
545The @code{configure} script should accept an option of the form
546@samp{--srcdir=@var{dirname}} to specify the directory where sources are found
547(if it is not the current directory). This makes it possible to build
548the program in a separate directory, so that the actual source directory
549is not modified.
550
551If the user does not specify @samp{--srcdir}, then @code{configure} should
552check both @file{.} and @file{..} to see if it can find the sources. If
553it finds the sources in one of these places, it should use them from
554there. Otherwise, it should report that it cannot find the sources, and
555should exit with nonzero status.
556
557Usually the easy way to support @samp{--srcdir} is by editing a
558definition of @code{VPATH} into the Makefile. Some rules may need to
559refer explicitly to the specified source directory. To make this
560possible, @code{configure} can add to the Makefile a variable named
561@code{srcdir} whose value is precisely the specified directory.
562
563The @code{configure} script should also take an argument which specifies the
564type of system to build the program for. This argument should look like
565this:
566
567@example
568@var{cpu}-@var{company}-@var{system}
569@end example
570
571For example, a Sun 3 might be @samp{m68k-sun-sunos4.1}.
572
573The @code{configure} script needs to be able to decode all plausible
574alternatives for how to describe a machine. Thus, @samp{sun3-sunos4.1}
575would be a valid alias. So would @samp{sun3-bsd4.2}, since Sunos is
576basically @sc{BSD} and no other @sc{BSD} system is used on a Sun. For many
577programs, @samp{vax-dec-ultrix} would be an alias for
578@samp{vax-dec-bsd}, simply because the differences between Ultrix and
579@sc{BSD} are rarely noticeable, but a few programs might need to distinguish
580them.
581
582There is a shell script called @file{config.sub} that you can use
583as a subroutine to validate system types and canonicalize aliases.
584
585Other options are permitted to specify in more detail the software
586or hardware are present on the machine:
587
588@table @samp
589@item --with-@var{package}
590The package @var{package} will be installed, so configure this package
591to work with @var{package}.
592
593Possible values of @var{package} include @samp{x}, @samp{gnu-as} (or
594@samp{gas}), @samp{gnu-ld}, @samp{gnu-libc}, and @samp{gdb}.
595
596@item --nfp
597The target machine has no floating point processor.
598
599@item --gas
600The target machine assembler is GAS, the GNU assembler.
601This is obsolete; use @samp{--with-gnu-as} instead.
602
603@item --x
604The target machine has the X Window system installed.
605This is obsolete; use @samp{--with-x} instead.
606@end table
607
608All @code{configure} scripts should accept all of these ``detail''
609options, whether or not they make any difference to the particular
610package at hand. In particular, they should accept any option that
611starts with @samp{--with-}. This is so users will be able to configure
612an entire GNU source tree at once with a single set of options.
613
614Packages that perform part of compilation may support cross-compilation.
615In such a case, the host and target machines for the program may be
616different. The @code{configure} script should normally treat the
617specified type of system as both the host and the target, thus producing
618a program which works for the same type of machine that it runs on.
619
620The way to build a cross-compiler, cross-assembler, or what have you, is
621to specify the option @samp{--host=@var{hosttype}} when running
622@code{configure}. This specifies the host system without changing the
623type of target system. The syntax for @var{hosttype} is the same as
624described above.
625
626Programs for which cross-operation is not meaningful need not accept the
627@samp{--host} option, because configuring an entire operating system for
628cross-operation is not a meaningful thing.
629
630Some programs have ways of configuring themselves automatically. If
631your program is set up to do this, your @code{configure} script can simply
632ignore most of its arguments.
633
634
635@node Source Language
636@chapter Using Languages Other Than C
637
638Using a language other than C is like using a non-standard feature: it
639will cause trouble for users. Even if GCC supports the other language,
640users may find it inconvenient to have to install the compiler for that
641other language in order to build your program. So please write in C.
642
643There are three exceptions for this rule:
644
645@itemize @bullet
646@item
647It is okay to use a special language if the same program contains an
648interpreter for that language.
649
650Thus, it is not a problem that GNU Emacs contains code written in Emacs
651Lisp, because it comes with a Lisp interpreter.
652
653@item
654It is okay to use another language in a tool specifically intended for
655use with that language.
656
657This is okay because the only people who want to build the tool will be
658those who have installed the other language anyway.
659
660@item
661If an application is not of extremely widespread interest, then perhaps
662it's not important if the application is inconvenient to install.
663@end itemize
664
665@node Formatting
666@chapter Formatting Your Source Code
667
668It is important to put the open-brace that starts the body of a C
669function in column zero, and avoid putting any other open-brace or
670open-parenthesis or open-bracket in column zero. Several tools look
671for open-braces in column zero to find the beginnings of C functions.
672These tools will not work on code not formatted that way.
673
674It is also important for function definitions to start the name of the
675function in column zero. This helps people to search for function
676definitions, and may also help certain tools recognize them. Thus,
677the proper format is this:
678
679@example
680static char *
681concat (s1, s2) /* Name starts in column zero here */
682 char *s1, *s2;
683@{ /* Open brace in column zero here */
684 @dots{}
685@}
686@end example
687
688@noindent
689or, if you want to use @sc{ANSI} C, format the definition like this:
690
691@example
692static char *
693concat (char *s1, char *s2)
694@{
695 @dots{}
696@}
697@end example
698
699In @sc{ANSI} C, if the arguments don't fit nicely on one line,
700split it like this:
701
702@example
703int
704lots_of_args (int an_integer, long a_long, short a_short,
705 double a_double, float a_float)
706@dots{}
707@end example
708
709For the body of the function, we prefer code formatted like this:
710
711@example
712if (x < foo (y, z))
713 haha = bar[4] + 5;
714else
715 @{
716 while (z)
717 @{
718 haha += foo (z, z);
719 z--;
720 @}
721 return ++x + bar ();
722 @}
723@end example
724
725We find it easier to read a program when it has spaces before the
726open-parentheses and after the commas. Especially after the commas.
727
728When you split an expression into multiple lines, split it
729before an operator, not after one. Here is the right way:
730
731@example
732if (foo_this_is_long && bar > win (x, y, z)
733 && remaining_condition)
734@end example
735
736Try to avoid having two operators of different precedence at the same
737level of indentation. For example, don't write this:
738
739@example
740mode = (inmode[j] == VOIDmode
741 || GET_MODE_SIZE (outmode[j]) > GET_MODE_SIZE (inmode[j])
742 ? outmode[j] : inmode[j]);
743@end example
744
745Instead, use extra parentheses so that the indentation shows the nesting:
746
747@example
748mode = ((inmode[j] == VOIDmode
749 || (GET_MODE_SIZE (outmode[j]) > GET_MODE_SIZE (inmode[j])))
750 ? outmode[j] : inmode[j]);
751@end example
752
753Insert extra parentheses so that Emacs will indent the code properly.
754For example, the following indentation looks nice if you do it by hand,
755but Emacs would mess it up:
756
757@example
758v = rup->ru_utime.tv_sec*1000 + rup->ru_utime.tv_usec/1000
759 + rup->ru_stime.tv_sec*1000 + rup->ru_stime.tv_usec/1000;
760@end example
761
762But adding a set of parentheses solves the problem:
763
764@example
765v = (rup->ru_utime.tv_sec*1000 + rup->ru_utime.tv_usec/1000
766 + rup->ru_stime.tv_sec*1000 + rup->ru_stime.tv_usec/1000);
767@end example
768
769Format do-while statements like this:
770
771@example
772do
773 @{
774 a = foo (a);
775 @}
776while (a > 0);
777@end example
778
779Please use formfeed characters (control-L) to divide the program into
780pages at logical places (but not within a function). It does not matter
781just how long the pages are, since they do not have to fit on a printed
782page. The formfeeds should appear alone on lines by themselves.
783
784
785@node Comments
786@chapter Commenting Your Work
787
788Every program should start with a comment saying briefly what it is for.
789Example: @samp{fmt - filter for simple filling of text}.
790
791Please put a comment on each function saying what the function does,
792what sorts of arguments it gets, and what the possible values of
793arguments mean and are used for. It is not necessary to duplicate in
794words the meaning of the C argument declarations, if a C type is being
795used in its customary fashion. If there is anything nonstandard about
796its use (such as an argument of type @code{char *} which is really the
797address of the second character of a string, not the first), or any
798possible values that would not work the way one would expect (such as,
799that strings containing newlines are not guaranteed to work), be sure
800to say so.
801
802Also explain the significance of the return value, if there is one.
803
804Please put two spaces after the end of a sentence in your comments, so
805that the Emacs sentence commands will work. Also, please write
806complete sentences and capitalize the first word. If a lower-case
807identifer comes at the beginning of a sentence, don't capitalize it!
808Changing the spelling makes it a different identifier. If you don't
809like starting a sentence with a lower case letter, write the sentence
810differently (e.g. ``The identifier lower-case is @dots{}'').
811
812The comment on a function is much clearer if you use the argument
813names to speak about the argument values. The variable name itself
814should be lower case, but write it in upper case when you are speaking
815about the value rather than the variable itself. Thus, ``the inode
816number @var{node_num}'' rather than ``an inode''.
817
818There is usually no purpose in restating the name of the function in
819the comment before it, because the reader can see that for himself.
820There might be an exception when the comment is so long that the function
821itself would be off the bottom of the screen.
822
823There should be a comment on each static variable as well, like this:
824
825@example
826/* Nonzero means truncate lines in the display;
827 zero means continue them. */
828
829int truncate_lines;
830@end example
831
832Every @samp{#endif} should have a comment, except in the case of short
833conditionals (just a few lines) that are not nested. The comment should
834state the condition of the conditional that is ending, @emph{including
835its sense}. @samp{#else} should have a comment describing the condition
836@emph{and sense} of the code that follows. For example:
837
838@example
839#ifdef foo
840 @dots{}
841#else /* not foo */
842 @dots{}
843#endif /* not foo */
844@end example
845
846@noindent
847but, by contrast, write the comments this way for a @samp{#ifndef}:
848
849@example
850#ifndef foo
851 @dots{}
852#else /* foo */
853 @dots{}
854#endif /* foo */
855@end example
856
857
858@node Syntactic Conventions
859@chapter Clean Use of C Constructs
860
861Please explicitly declare all arguments to functions.
862Don't omit them just because they are ints.
863
864Declarations of external functions and functions to appear later
865in the source file should all go in one place near the beginning of
866the file (somewhere before the first function definition in the file),
867or else should go in a header file. Don't put extern declarations
868inside functions.
869
870Don't declare multiple variables in one declaration that spans lines.
871Start a new declaration on each line, instead. For example, instead
872of this:
873
874@example
875int foo,
876 bar;
877@end example
878
879@noindent
880write either this:
881
882@example
883int foo, bar;
884@end example
885
886@noindent
887or this:
888
889@example
890int foo;
891int bar;
892@end example
893
894@noindent
895(If they are global variables, each should have a comment preceding it
896anyway.)
897
898When you have an if-else statement nested in another if statement,
899always put braces around the if-else. Thus, never write like this:
900
901@example
902if (foo)
903 if (bar)
904 win ();
905 else
906 lose ();
907@end example
908
909@noindent
910always like this:
911
912@example
913if (foo)
914 @{
915 if (bar)
916 win ();
917 else
918 lose ();
919 @}
920@end example
921
922If you have an if statement nested inside of an else statement,
923either write @code{else if} on one line, like this,
924
925@example
926if (foo)
927 @dots{}
928else if (bar)
929 @dots{}
930@end example
931
932@noindent
933with its then-part indented like the preceding then-part, or write the
934nested if within braces like this:
935
936@example
937if (foo)
938 @dots{}
939else
940 @{
941 if (bar)
942 @dots{}
943 @}
944@end example
945
946Don't declare both a structure tag and variables or typedefs in the
947same declaration. Instead, declare the structure tag separately
948and then use it to declare the variables or typedefs.
949
950Try to avoid assignments inside if-conditions. For example, don't
951write this:
952
953@example
954if ((foo = (char *) malloc (sizeof *foo)) == 0)
955 fatal ("virtual memory exhausted");
956@end example
957
958@noindent
959instead, write this:
960
961@example
962foo = (char *) malloc (sizeof *foo);
963if (foo == 0)
964 fatal ("virtual memory exhausted");
965@end example
966
967Don't make the program ugly to placate lint. Please don't insert any
968casts to void. Zero without a cast is perfectly fine as a null
969pointer constant.
970
971
972@node Names
973@chapter Naming Variables and Functions
974
975Please use underscores to separate words in a name, so that the Emacs
976word commands can be useful within them. Stick to lower case; reserve
977upper case for macros and enum constants, and for name-prefixes that
978follow a uniform convention.
979
980For example, you should use names like @code{ignore_space_change_flag};
981don't use names like @code{iCantReadThis}.
982
983Variables that indicate whether command-line options have been
984specified should be named after the meaning of the option, not after
985the option-letter. A comment should state both the exact meaning of
986the option and its letter. For example,
987
988@example
989/* Ignore changes in horizontal whitespace (-b). */
990int ignore_space_change_flag;
991@end example
992
993When you want to define names with constant integer values, use
994@code{enum} rather than @samp{#define}. GDB knows about enumeration
995constants.
996
997Use file names of 14 characters or less, to avoid creating gratuitous
998problems on System V.
999
1000
1001@node Using Extensions
1002@chapter Using Non-standard Features
1003
1004Many GNU facilities that already exist support a number of convenient
1005extensions over the comparable Unix facilities. Whether to use these
1006extensions in implementing your program is a difficult question.
1007
1008On the one hand, using the extensions can make a cleaner program.
1009On the other hand, people will not be able to build the program
1010unless the other GNU tools are available. This might cause the
1011program to work on fewer kinds of machines.
1012
1013With some extensions, it might be easy to provide both alternatives.
1014For example, you can define functions with a ``keyword'' @code{INLINE}
1015and define that as a macro to expand into either @code{inline} or
1016nothing, depending on the compiler.
1017
1018In general, perhaps it is best not to use the extensions if you can
1019straightforwardly do without them, but to use the extensions if they
1020are a big improvement.
1021
1022An exception to this rule are the large, established programs (such as
1023Emacs) which run on a great variety of systems. Such programs would
1024be broken by use of GNU extensions.
1025
1026Another exception is for programs that are used as part of
1027compilation: anything that must be compiled with other compilers in
1028order to bootstrap the GNU compilation facilities. If these require
1029the GNU compiler, then no one can compile them without having them
1030installed already. That would be no good.
1031
1032Since most computer systems do not yet implement @sc{ANSI} C, using the
1033@sc{ANSI} C features is effectively using a GNU extension, so the
1034same considerations apply. (Except for @sc{ANSI} features that we
1035discourage, such as trigraphs---don't ever use them.)
1036
1037@node Semantics
1038@chapter Program Behaviour for All Programs
1039
1040Avoid arbitrary limits on the length or number of @emph{any} data
1041structure, including filenames, lines, files, and symbols, by allocating
1042all data structures dynamically. In most Unix utilities, ``long lines
1043are silently truncated''. This is not acceptable in a GNU utility.
1044
1045Utilities reading files should not drop NUL characters, or any other
1046nonprinting characters @emph{including those with codes above 0177}. The
1047only sensible exceptions would be utilities specifically intended for
1048interface to certain types of printers that can't handle those characters.
1049
1050Check every system call for an error return, unless you know you wish to
1051ignore errors. Include the system error text (from @code{perror} or
1052equivalent) in @emph{every} error message resulting from a failing
1053system call, as well as the name of the file if any and the name of the
1054utility. Just ``cannot open foo.c'' or ``stat failed'' is not
1055sufficient.
1056
1057Check every call to @code{malloc} or @code{realloc} to see if it
1058returned zero. Check @code{realloc} even if you are making the block
1059smaller; in a system that rounds block sizes to a power of 2,
1060@code{realloc} may get a different block if you ask for less space.
1061
1062In Unix, @code{realloc} can destroy the storage block if it returns
1063zero. GNU @code{realloc} does not have this bug: if it fails, the
1064original block is unchanged. Feel free to assume the bug is fixed. If
1065you wish to run your program on Unix, and wish to avoid lossage in this
1066case, you can use the GNU @code{malloc}.
1067
1068You must expect @code{free} to alter the contents of the block that was
1069freed. Anything you want to fetch from the block, you must fetch before
1070calling @code{free}.
1071
1072Use @code{getopt_long} to decode arguments, unless the argument syntax
1073makes this unreasonable.
1074
1075When static storage is to be written in during program execution, use
1076explicit C code to initialize it. Reserve C initialized declarations
1077for data that will not be changed.
1078
1079Try to avoid low-level interfaces to obscure Unix data structures (such
1080as file directories, utmp, or the layout of kernel memory), since these
1081are less likely to work compatibly. If you need to find all the files
1082in a directory, use @code{readdir} or some other high-level interface. These
1083will be supported compatibly by GNU.
1084
1085By default, the GNU system will provide the signal handling
1086functions of @sc{BSD} and of @sc{POSIX}. So GNU software should be
1087written to use these.
1088
1089In error checks that detect ``impossible'' conditions, just abort.
1090There is usually no point in printing any message. These checks
1091indicate the existence of bugs. Whoever wants to fix the bugs will have
1092to read the source code and run a debugger. So explain the problem with
1093comments in the source. The relevant data will be in variables, which
1094are easy to examine with the debugger, so there is no point moving them
1095elsewhere.
1096
1097
1098@node Errors
1099@chapter Formatting Error Messages
1100
1101Error messages from compilers should look like this:
1102
1103@example
1104@var{source-file-name}:@var{lineno}: @var{message}
1105@end example
1106
1107Error messages from other noninteractive programs should look like this:
1108
1109@example
1110@var{program}:@var{source-file-name}:@var{lineno}: @var{message}
1111@end example
1112
1113@noindent
1114when there is an appropriate source file, or like this:
1115
1116@example
1117@var{program}: @var{message}
1118@end example
1119
1120@noindent
1121when there is no relevant source file.
1122
1123In an interactive program (one that is reading commands from a
1124terminal), it is better not to include the program name in an error
1125message. The place to indicate which program is running is in the
1126prompt or with the screen layout. (When the same program runs with
1127input from a source other than a terminal, it is not interactive and
1128would do best to print error messages using the noninteractive style.)
1129
1130The string @var{message} should not begin with a capital letter when
1131it follows a program name and/or filename. Also, it should not end
1132with a period.
1133
1134Error messages from interactive programs, and other messages such as
1135usage messages, should start with a capital letter. But they should not
1136end with a period.
1137
1138
1139@node Libraries
1140@chapter Library Behaviour
1141
1142Try to make library functions reentrant. If they need to do dynamic
1143storage allocation, at least try to avoid any nonreentrancy aside from
1144that of @code{malloc} itself.
1145
1146Here are certain name conventions for libraries, to avoid name
1147conflicts.
1148
1149Choose a name prefix for the library, more than two characters long.
1150All external function and variable names should start with this
1151prefix. In addition, there should only be one of these in any given
1152library member. This usually means putting each one in a separate
1153source file.
1154
1155An exception can be made when two external symbols are always used
1156together, so that no reasonable program could use one without the
1157other; then they can both go in the same file.
1158
1159External symbols that are not documented entry points for the user
1160should have names beginning with @samp{_}. They should also contain
1161the chosen name prefix for the library, to prevent collisions with
1162other libraries. These can go in the same files with user entry
1163points if you like.
1164
1165Static functions and variables can be used as you like and need not
1166fit any naming convention.
1167
1168
1169@node Portability
1170@chapter Portability As It Applies to GNU
1171
1172Much of what is called ``portability'' in the Unix world refers to
1173porting to different Unix versions. This is not relevant to GNU
1174software, because its purpose is to run on top of one and only
1175one kernel, the GNU kernel, compiled with one and only one C
1176compiler, the GNU C compiler. The amount and kinds of variation
1177among GNU systems on different cpu's will be like the variation
1178among Berkeley 4.3 systems on different cpu's.
1179
1180It is difficult to be sure exactly what facilities the GNU kernel
1181will provide, since it isn't finished yet. Therefore, assume you can
1182use anything in 4.3; just avoid using the format of semi-internal data
1183bases (e.g., directories) when there is a higher-level alternative
1184(readdir).
1185
1186You can freely assume any reasonably standard facilities in the C
1187language, libraries or kernel, because we will find it necessary to
1188support these facilities in the full GNU system, whether or not we
1189have already done so. The fact that there may exist kernels or C
1190compilers that lack these facilities is irrelevant as long as the GNU
1191kernel and C compiler support them.
1192
1193It remains necessary to worry about differences among cpu types, such
1194as the difference in byte ordering and alignment restrictions. It's
1195unlikely that 16-bit machines will ever be supported by GNU, so there
1196is no point in spending any time to consider the possibility that an
1197int will be less than 32 bits.
1198
1199You can assume that all pointers have the same format, regardless
1200of the type they point to, and that this is really an integer.
1201There are some weird machines where this isn't true, but they aren't
1202important; don't waste time catering to them. Besides, eventually
1203we will put function prototypes into all GNU programs, and that will
1204probably make your program work even on weird machines.
1205
1206Since some important machines (including the 68000) are big-endian,
1207it is important not to assume that the address of an int object
1208is also the address of its least-significant byte. Thus, don't
1209make the following mistake:
1210
1211@example
1212int c;
1213@dots{}
1214while ((c = getchar()) != EOF)
1215 write(file_descriptor, &c, 1);
1216@end example
1217
1218You can assume that it is reasonable to use a meg of memory. Don't
1219strain to reduce memory usage unless it can get to that level. If
1220your program creates complicated data structures, just make them in
1221core and give a fatal error if malloc returns zero.
1222
1223If a program works by lines and could be applied to arbitrary
1224user-supplied input files, it should keep only a line in memory, because
1225this is not very hard and users will want to be able to operate on input
1226files that are bigger than will fit in core all at once.
1227
1228
1229@node User Interfaces
1230@chapter Standards for Command Line Interfaces
1231
1232Please don't make the behavior of a utility depend on the name used
1233to invoke it. It is useful sometimes to make a link to a utility
1234with a different name, and that should not change what it does.
1235
1236Instead, use a run time option or a compilation switch or both
1237to select among the alternate behaviors.
1238
1239It is a good idea to follow the @sc{POSIX} guidelines for the
1240command-line options of a program. The easiest way to do this is to use
1241@code{getopt} to parse them. Note that the GNU version of @code{getopt}
1242will normally permit options anywhere among the arguments unless the
1243special argument @samp{--} is used. This is not what @sc{POSIX}
1244specifies; it is a GNU extension.
1245
1246Please define long-named options that are equivalent to the
1247single-letter Unix-style options. We hope to make GNU more user
1248friendly this way. This is easy to do with the GNU function
1249@code{getopt_long}.
1250
1251It is usually a good idea for file names given as ordinary arguments
1252to be input files only; any output files would be specified using
1253options (preferably @samp{-o}). Even if you allow an output file name
1254as an ordinary argument for compatibility, try to provide a suitable
1255option as well. This will lead to more consistency among GNU
1256utilities, so that there are fewer idiosyncracies for users to
1257remember.
1258
1259Programs should support an option @samp{--version} which prints the
1260program's version number, and an option @samp{--help} which prints
1261option usage information.
1262
1263
1264@node Documentation
1265@chapter Documenting Programs
1266
1267Please use Texinfo for documenting GNU programs. See the Texinfo
1268manual, either the hardcopy or the version in the GNU Emacs Info
1269sub-system (@kbd{C-h i}).
1270
1271See existing GNU texinfo files (e.g. those under the @file{man/}
1272directory in the GNU Emacs Distribution) for examples.
1273
1274The title page of the manual should state the version of the program
1275which the manual applies to. The Top node of the manual should also
1276contain this information. If the manual is changing more frequently
1277than or independent of the program, also state a version number for
1278the manual in both of these places.
1279
1280The manual should document all command-line arguments and all
1281commands. It should give examples of their use. But don't organize
1282the manual as a list of features. Instead, organize it by the
1283concepts a user will have before reaching that point in the manual.
1284Address the goals that a user will have in mind, and explain how to
1285accomplish them.
1286
1287
1288@node Releases
1289@chapter Making Releases
1290
1291Package the distribution of Foo version 69.96 in a tar file named
1292@file{foo-69.96.tar}. It should unpack into a subdirectory named
1293@file{foo-69.96}.
1294
1295Building and installing the program should never modify any of the files
1296contained in the distribution. This means that all the files that form
1297part of the program in any way must be classified into @dfn{source
1298files} and @dfn{non-source files}. Source files are written by humans
1299and never changed automatically; non-source files are produced from
1300source files by programs under the control of the Makefile.
1301
1302Naturally, all the source files must be in the distribution. It is okay
1303to include non-source files in the distribution, provided they are
1304up-to-date and machine-independent, so that building the distribution
1305normally will never modify them. We commonly included non-source files
1306produced by Bison, Lex, @TeX{}, and Makeinfo; this helps avoid
1307unnecessary dependencies between our distributions, so that users can
1308install whichever packages they want to install.
1309
1310Non-source files that might actually be modified by building and
1311installing the program should @strong{never} be included in the
1312distribution. So if you do distribute non-source files, always make
1313sure they are up to date when you make a new distribution.
1314
1315Make sure that no file name in the distribution is no more than 14
1316characters long. Nowadays, there are systems that adhere to a foolish
1317interpretation of the POSIX standard which holds that they should refuse
1318to open a longer name, rather than truncating as they did in the past.
1319
1320Try to make sure that all the file names will be unique on MS-DOG. A
1321name on MS-DOG consists of up to 8 characters, optionally followed by a
1322period and up to three characters. MS-DOG will truncate extra
1323characters both before and after the period. Thus,
1324@file{foobarhacker.c} and @file{foobarhacker.o} are not ambiguous; they
1325are truncated to @file{foobarhac.c} and @file{foobarhac.o}, which are
1326distinct.
1327
1328Include in your distribution a copy of the @file{texinfo.tex} you used
1329to test print any @file{*.texinfo} files.
1330
a60ff512
RP
1331Likewise, if your program uses small GNU software packages like regex,
1332getopt, obstack, or termcap, include them in the distribution file.
1333Leaving them out would make the distribution file a little smaller at
1334the expense of possible inconvenience to a user who doesn't know what
1335other files to get.
b42b3782 1336@bye
This page took 0.070152 seconds and 4 git commands to generate.