| 1 | 2021-02-24 Kevin Buettner <kevinb@redhat.com> |
| 2 | |
| 3 | * nat/aarch64-linux-hw-point.c: Add comment regarding include |
| 4 | order for <sys/ptrace.h> and <asm/ptrace.h>. |
| 5 | |
| 6 | 2021-02-24 Kevin Buettner <kevinb@redhat.com> |
| 7 | |
| 8 | * nat/aarch64-linux-hw-point.c: Include <asm/ptrace.h> after |
| 9 | <sys/ptrace.h>. |
| 10 | |
| 11 | 2021-02-24 Andrew Burgess <andrew.burgess@embecosm.com> |
| 12 | |
| 13 | * exec.c (set_section_command): Move variable declarations into |
| 14 | the function body, and use std::string instead of a fixed size |
| 15 | buffer. |
| 16 | |
| 17 | 2021-02-24 Andrew Burgess <andrew.burgess@embecosm.com> |
| 18 | |
| 19 | * exec.c (exec_target::get_section_table): Delete member function. |
| 20 | (section_table_read_available_memory): Use current_top_target, not |
| 21 | just the exec_ops target. |
| 22 | * target-delegates.c: Regenerate. |
| 23 | * target.c (default_get_section_table): New function. |
| 24 | * target.h (target_ops::get_section_table): Change default |
| 25 | behaviour to call default_get_section_table. |
| 26 | (default_get_section_table): Declare. |
| 27 | |
| 28 | 2021-02-24 Andrew Burgess <andrew.burgess@embecosm.com> |
| 29 | |
| 30 | * exec.c (exec_target::close): Call new clear_target_sections |
| 31 | function. |
| 32 | (program_space::add_target_sections): Update name of member |
| 33 | variable. |
| 34 | (program_space::add_target_sections): Update name of member |
| 35 | variable. |
| 36 | (program_space::remove_target_sections): Likewise. |
| 37 | (exec_one_fork): Use new target_sections member function. |
| 38 | (exec_target::get_section_table): Likewise. |
| 39 | (exec_target::files_info): Likewise. |
| 40 | (set_section_command): Likewise. |
| 41 | (exec_set_section_address): Likewise. |
| 42 | (exec_target::has_memory): Use new target_sections member |
| 43 | function. |
| 44 | * progspace.h (program_space::clear_target_sections): New member |
| 45 | function. |
| 46 | (program_space::target_sections): Rename member variable to |
| 47 | m_target_sections, replace with a new member function. |
| 48 | (program_space::m_target_sections): New member variable. |
| 49 | * solib-dsbt.c (scan_dyntag): Use new member function. |
| 50 | * solib-svr4.c (scan_dyntag): Likewise. |
| 51 | |
| 52 | 2021-02-24 Andrew Burgess <andrew.burgess@embecosm.com> |
| 53 | |
| 54 | * gdb/bfd-target.c (class target_bfd) <get_section_table>: Make |
| 55 | return type const. |
| 56 | * gdb/exec.c (struct exec_target) <get_section_table>: Likewise. |
| 57 | (section_table_read_available_memory): Make local const. |
| 58 | (exec_target::xfer_partial): Make local const. |
| 59 | (print_section_info): Make parameter const. |
| 60 | * gdb/exec.h (print_section_info): Likewise. |
| 61 | * gdb/ppc64-tdep.c (ppc64_convert_from_func_ptr_addr): Make local |
| 62 | const. |
| 63 | * gdb/record-btrace.c (record_btrace_target::xfer_partial): |
| 64 | Likewise. |
| 65 | * gdb/remote.c (remote_target::remote_xfer_live_readonly_partial): |
| 66 | Likewise. |
| 67 | * gdb/s390-tdep.c (s390_load): Likewise. |
| 68 | * gdb/solib-dsbt.c (scan_dyntag): Likewise. |
| 69 | * gdb/solib-svr4.c (scan_dyntag): Likewise. |
| 70 | * gdb/target-debug.h (target_debug_print_target_section_table_p): |
| 71 | Rename to... |
| 72 | (target_debug_print_const_target_section_table_p): ...this. |
| 73 | * gdb/target-delegates.c: Regenerate. |
| 74 | * gdb/target.c (target_get_section_table): Make return type const. |
| 75 | (target_section_by_addr): Likewise. Also make some locals const. |
| 76 | (memory_xfer_partial_1): Make some locals const. |
| 77 | * gdb/target.h (struct target_ops) <get_section_table>: Make |
| 78 | return type const. |
| 79 | (target_section_by_addr): Likewise. |
| 80 | (target_get_section_table): Likewise. |
| 81 | |
| 82 | 2021-02-24 Andrew Burgess <andrew.burgess@embecosm.com> |
| 83 | |
| 84 | * NEWS: Mention new 'maint info target-sections' command. |
| 85 | * maint.c (maintenance_info_target_sections): New function. |
| 86 | (_initialize_maint_cmds): Register new command. |
| 87 | |
| 88 | 2021-02-24 Andrew Burgess <andrew.burgess@embecosm.com> |
| 89 | |
| 90 | * riscv-tdep.c (riscv_features_from_gdbarch_info): Rename to... |
| 91 | (riscv_features_from_bfd): ...this. Change parameter type to |
| 92 | 'bfd*', and update as required. |
| 93 | (riscv_find_default_target_description): Update call to |
| 94 | riscv_features_from_bfd. Select a default xlen based on |
| 95 | info.bfd_arch_info. |
| 96 | (riscv_gdbarch_init): Update call to riscv_features_from_bfd. |
| 97 | |
| 98 | 2021-02-24 Andrew Burgess <andrew.burgess@embecosm.com> |
| 99 | |
| 100 | * eval.c (evaluate_subexp_standard): Call value_ind for points to |
| 101 | dynamic types in UNOP_IND. |
| 102 | |
| 103 | 2021-02-23 Simon Marchi <simon.marchi@polymtl.ca> |
| 104 | |
| 105 | PR gdb/26828 |
| 106 | * dwarf2/read.c (dwarf2_queue_guard) <dwarf2_queue_guard>: |
| 107 | Instantiate queue. |
| 108 | (~dwarf2_queue_guard): Clear queue. |
| 109 | (queue_comp_unit): Assert that queue is |
| 110 | instantiated. |
| 111 | (process_queue): Adjust. |
| 112 | * dwarf2/read.h (struct dwarf2_per_bfd) <queue>: Make optional. |
| 113 | |
| 114 | 2021-02-23 Simon Marchi <simon.marchi@polymtl.ca> |
| 115 | |
| 116 | PR gdb/26828 |
| 117 | * dwarf2/read.c (maybe_queue_comp_unit): Check if CU is expanded |
| 118 | to decide whether or not to enqueue it for expansion. |
| 119 | (follow_die_offset, follow_die_sig_1): Ensure we load the DIEs |
| 120 | after calling maybe_queue_comp_unit. |
| 121 | |
| 122 | 2021-02-23 Simon Marchi <simon.marchi@polymtl.ca> |
| 123 | |
| 124 | * linux-nat.c (linux_nat_filter_event): Return void. |
| 125 | |
| 126 | 2021-02-22 Tom Tromey <tromey@adacore.com> |
| 127 | |
| 128 | * solib-svr4.c (enable_break): Update. |
| 129 | * bfd-target.c (class target_bfd) <target_bfd>: Change parameter |
| 130 | type. |
| 131 | (target_bfd_reopen): Change parameter type. |
| 132 | * bfd-target.h (target_bfd_reopen): Change parameter type. |
| 133 | |
| 134 | 2021-02-22 Simon Marchi <simon.marchi@polymtl.ca> |
| 135 | |
| 136 | * thread.c (add_thread_silent): Add assert. |
| 137 | (find_thread_ptid): Add assert. |
| 138 | |
| 139 | 2021-02-22 Simon Marchi <simon.marchi@polymtl.ca> |
| 140 | |
| 141 | PR gdb/27435 |
| 142 | * inf-ptrace.c (struct target_unpusher): Move to target.h. |
| 143 | (target_unpush_up): Likewise. |
| 144 | * procfs.c (procfs_target::attach): Push target early. Use |
| 145 | target_unpush_up to unpush target in case of error. |
| 146 | * target.h (struct target_unpusher): Move here. |
| 147 | (target_unpush_up): Likewise. |
| 148 | |
| 149 | 2021-02-19 Kevin Buettner <kevinb@redhat.com> |
| 150 | |
| 151 | * nat/amd64-linux-siginfo.c: Include "gdbsupport/common-defs.h" |
| 152 | (which in turn includes <gnulib/config.h>) before include |
| 153 | of <signal.h>. |
| 154 | |
| 155 | 2021-02-19 Nelson Chu <nelson.chu@sifive.com> |
| 156 | |
| 157 | PR 27158 |
| 158 | * riscv-tdep.c (decode_ci_type_insn): Updated encoding macros. |
| 159 | (decode_j_type_insn): Likewise. |
| 160 | (decode_cj_type_insn): Likewise. |
| 161 | (decode_b_type_insn): Likewise. |
| 162 | (decode): Likewise. |
| 163 | |
| 164 | 2021-02-18 Tom Tromey <tom@tromey.com> |
| 165 | |
| 166 | * expression.h (struct expression) <evaluate>: Declare method. |
| 167 | * eval.c (evaluate_subexp): Simplify. |
| 168 | (expression::evaluate): New method. |
| 169 | (evaluate_expression, evaluate_type): Use expression::evaluate. |
| 170 | |
| 171 | 2021-02-17 Kevin Buettner <kevinb@redhat.com> |
| 172 | |
| 173 | * ada-lang.c (ada_fold_name): Check for non-empty string prior |
| 174 | to accessing it. |
| 175 | (ada_lookup_name_info): Likewise. |
| 176 | |
| 177 | 2021-02-13 Mike Frysinger <vapier@gentoo.org> |
| 178 | |
| 179 | * aclocal.m4: Regenerate. |
| 180 | |
| 181 | 2021-02-12 Tom de Vries <tdevries@suse.de> |
| 182 | |
| 183 | PR threads/26228 |
| 184 | * linux-nat.c (lin_thread_get_thread_signals): Remove. |
| 185 | (lin_thread_signals): New static var. |
| 186 | (lin_thread_get_thread_signal_num, lin_thread_get_thread_signal): |
| 187 | New function. |
| 188 | * linux-nat.h (lin_thread_get_thread_signals): Remove. |
| 189 | (lin_thread_get_thread_signal_num, lin_thread_get_thread_signal): |
| 190 | Declare. |
| 191 | * linux-thread-db.c (check_thread_signals): Use |
| 192 | lin_thread_get_thread_signal_num and lin_thread_get_thread_signal. |
| 193 | |
| 194 | 2021-02-12 Andrew Burgess <andrew.burgess@embecosm.com> |
| 195 | |
| 196 | * f-exp.y (f77_keywords): Add allocated. |
| 197 | * f-lang.c (evaluate_subexp_f): Handle UNOP_FORTRAN_ALLOCATED. |
| 198 | (operator_length_f): Likewise. |
| 199 | (print_subexp_f): Likewise. |
| 200 | (dump_subexp_body_f): Likewise. |
| 201 | (operator_check_f): Likewise. |
| 202 | * std-operator.def (UNOP_FORTRAN_ALLOCATED): New operator. |
| 203 | |
| 204 | 2021-02-11 Tom de Vries <tdevries@suse.de> |
| 205 | |
| 206 | PR symtab/27353 |
| 207 | * dwarf2/attribute.c (attribute::form_requires_reprocessing): |
| 208 | Return true for DW_FORM_strx. |
| 209 | |
| 210 | 2021-02-11 Tom Tromey <tromey@adacore.com> |
| 211 | |
| 212 | PR gdb/27383: |
| 213 | * parse.c (write_exp_symbol_reference): Write sym.block. |
| 214 | |
| 215 | 2021-02-11 Andrew Burgess <andrew.burgess@embecosm.com> |
| 216 | |
| 217 | * NEWS: Mention changes to 'maint info sections'. |
| 218 | * maint.c (match_substring): Return a bool, fix whitespace issue. |
| 219 | (struct single_bfd_flag_info): New struct. |
| 220 | (bfd_flag_info): New static global. |
| 221 | (match_bfd_flags): Return a bool, use bfd_flag_info. |
| 222 | (print_bfd_flags): Use bfd_flag_info. |
| 223 | (maint_print_section_info): Delete trailing whitespace. |
| 224 | (struct maint_info_sections_opts): New struct. |
| 225 | (maint_info_sections_option_defs): New static global. |
| 226 | (maint_info_sections_completer): New function. |
| 227 | (maintenance_info_sections): Use option parsing mechanism. |
| 228 | (_initialize_maint_cmds): Update command help text for 'maint info |
| 229 | sections' and register a command completer. |
| 230 | |
| 231 | 2021-02-11 Andrew Burgess <andrew.burgess@embecosm.com> |
| 232 | |
| 233 | * maint.c (print_bfd_section_info_maybe_relocated): Delete, |
| 234 | functionality merged into... |
| 235 | (maint_print_all_sections): ...this new function. |
| 236 | (maintenance_info_sections): Make use of maint_print_all_sections, |
| 237 | allow all objects to be printed even where there's no executable. |
| 238 | |
| 239 | 2021-02-11 Andrew Burgess <andrew.burgess@embecosm.com> |
| 240 | |
| 241 | * breakpoint.c (resolve_sal_pc): Make use of |
| 242 | bound_minimal_symbol::obj_section. |
| 243 | * maint.c (maintenance_translate_address): Likewise. |
| 244 | * minsyms.c (minimal_symbol_upper_bound): Likewise. |
| 245 | * minsyms.h (struct bound_minimal_symbol) <obj_section>: New |
| 246 | member function. |
| 247 | * printcmd.c (info_address_command): Make use of |
| 248 | bound_minimal_symbol::obj_section. |
| 249 | |
| 250 | 2021-02-11 Alan Modra <amodra@gmail.com> |
| 251 | |
| 252 | * arm-symbian-tdep.c: Delete. |
| 253 | * NEWS: Mention arm-symbian removal. |
| 254 | * Makefile.in: Remove arm-symbian-tdep entries. |
| 255 | * configure.tgt: Remove arm*-*-symbianelf*. |
| 256 | * doc/gdb.texinfo: Remove mention of SymbianOS. |
| 257 | * osabi.c (gdb_osabi_names): Remove "Symbian". |
| 258 | * osabi.h (enum gdb_osabi): Remove GDB_OSABI_SYMBIAN. |
| 259 | * testsuite/gdb.base/ending-run.exp: Remove E32Main handling. |
| 260 | * testsuite/gdb.ada/catch_ex_std.exp: Remove arm*-*-symbianelf* |
| 261 | handling. |
| 262 | * testsuite/gdb.base/dup-sect.exp: Likewise. |
| 263 | * testsuite/gdb.base/long_long.exp: Likewise. |
| 264 | * testsuite/gdb.base/solib-weak.exp: Likewise. |
| 265 | * testsuite/gdb.guile/scm-section-script.exp: Likewise. |
| 266 | * testsuite/gdb.python/py-section-script.exp: Likewise. |
| 267 | * testsuite/lib/dwarf.exp: Likewise. |
| 268 | * testsuite/lib/gdb.exp: Likewise. |
| 269 | |
| 270 | 2021-02-10 Andrew Burgess <andrew.burgess@embecosm.com> |
| 271 | |
| 272 | * f-exp.y (UNOP_OR_BINOP_INTRINSIC): New token. |
| 273 | (exp): New pattern using UNOP_OR_BINOP_INTRINSIC. |
| 274 | (one_or_two_args): New pattern. |
| 275 | (f77_keywords): Add lbound and ubound. |
| 276 | * f-lang.c (fortran_bounds_all_dims): New function. |
| 277 | (fortran_bounds_for_dimension): New function. |
| 278 | (evaluate_subexp_f): Handle FORTRAN_LBOUND and FORTRAN_UBOUND. |
| 279 | (operator_length_f): Likewise. |
| 280 | (print_subexp_f): Likewise. |
| 281 | (dump_subexp_body_f): Likewise. |
| 282 | (operator_check_f): Likewise. |
| 283 | * std-operator.def (FORTRAN_LBOUND): Define. |
| 284 | (FORTRAN_UBOUND): Define. |
| 285 | |
| 286 | 2021-02-10 Andrew Burgess <andrew.burgess@embecosm.com> |
| 287 | |
| 288 | * coff-pe-read.c (add_pe_forwarded_sym): Make use of section_index |
| 289 | and set_section_index member functions where appropriate. |
| 290 | * coffread.c (coff_symtab_read): Likewise. |
| 291 | (process_coff_symbol): Likewise. |
| 292 | * ctfread.c (set_symbol_address): Likewise. |
| 293 | * dwarf2/read.c (add_partial_symbol): Likewise. |
| 294 | (var_decode_location): Likewise. |
| 295 | * language.c: Likewise. |
| 296 | * minsyms.c (minimal_symbol_reader::record_full): Likewise. |
| 297 | (compact_minimal_symbols): Likewise. |
| 298 | (minimal_symbol_upper_bound): Likewise. |
| 299 | * objfiles.c (relocate_one_symbol): Likewise. |
| 300 | * psympriv.h (partial_symbol::obj_section): Likewise. |
| 301 | (partial_symbol::address): Likewise. |
| 302 | * psymtab.c (partial_symtab::add_psymbol): Likewise. |
| 303 | * stabsread.c (scan_file_globals): Likewise. |
| 304 | * symmisc.c (dump_msymbols): Likewise. |
| 305 | * symtab.c (general_symbol_info::obj_section): Likewise. |
| 306 | (fixup_section): Likewise. |
| 307 | (get_msymbol_address): Likewise. |
| 308 | * symtab.h (general_symbol_info::section): Rename to... |
| 309 | (general_symbol_info::m_section): ...this. |
| 310 | (general_symbol_info::set_section_index): New member function. |
| 311 | (general_symbol_info::section_index): Likewise. |
| 312 | (SYMBOL_SECTION): Delete. |
| 313 | (MSYMBOL_VALUE_ADDRESS): Make use of section_index and |
| 314 | set_section_index member functions where appropriate. |
| 315 | (MSYMBOL_SECTION): Delete. |
| 316 | (symbol::symbol): Update to initialize 'm_section'. |
| 317 | * xcoffread.c (read_xcoff_symtab): Make use of set_section_index. |
| 318 | (process_xcoff_symbol): Likewise. |
| 319 | |
| 320 | 2021-02-10 Andrew Burgess <andrew.burgess@embecosm.com> |
| 321 | |
| 322 | * breakpoint.c (resolve_sal_pc): Replace SYMBOL_OBJ_SECTION and |
| 323 | MSYMBOL_OBJ_SECTION. |
| 324 | * findvar.c (language_defn::read_var_value): Likewise. |
| 325 | * infcmd.c (jump_command): Likewise. |
| 326 | * linespec.c (minsym_found): Likewise. |
| 327 | * maint.c (maintenance_translate_address): Likewise. |
| 328 | * minsyms.c (lookup_minimal_symbol_by_pc_section): Likewise. |
| 329 | (minimal_symbol_upper_bound): Likewise. |
| 330 | * parse.c (find_minsym_type_and_address): Likewise. |
| 331 | (operator_check_standard): Likewise. |
| 332 | * printcmd.c (info_address_command): Likewise. |
| 333 | * symmisc.c (dump_msymbols): Likewise. |
| 334 | (print_symbol): Likewise. |
| 335 | * symtab.c (general_symbol_info::obj_section): Define new |
| 336 | function. |
| 337 | (fixup_symbol_section): Replace SYMBOL_OBJ_SECTION. |
| 338 | (find_pc_sect_compunit_symtab): Likewise. |
| 339 | (find_function_start_sal): Likewise. |
| 340 | (skip_prologue_sal): Replace SYMBOL_OBJ_SECTION and |
| 341 | MSYMBOL_OBJ_SECTION. |
| 342 | * symtab.h (struct general_symbol_info) <obj_section>: Declare new |
| 343 | function. |
| 344 | (SYMBOL_OBJ_SECTION): Delete. |
| 345 | (MSYMBOL_OBJ_SECTION): Delete. |
| 346 | |
| 347 | 2021-02-09 Tom Tromey <tom@tromey.com> |
| 348 | |
| 349 | * stap-probe.c (stap_parse_argument_conditionally): Fix typo. |
| 350 | |
| 351 | 2021-02-09 Tom de Vries <tdevries@suse.de> |
| 352 | |
| 353 | PR symtab/27341 |
| 354 | * dwarf2/read.c (read_array_type): Return NULL when not being able to |
| 355 | construct an array type. Add assert to ensure that element_type is |
| 356 | not being modified. |
| 357 | |
| 358 | 2021-02-09 Andrew Burgess <andrew.burgess@embecosm.com> |
| 359 | |
| 360 | * gcore.c (struct gcore_collect_regset_section_cb_data): Delete. |
| 361 | (gcore_collect_regset_section_cb): Delete. |
| 362 | (gcore_collect_thread_registers): Delete. |
| 363 | (gcore_build_thread_register_notes): Delete. |
| 364 | (gcore_find_signalled_thread): Delete. |
| 365 | * gcore.h: Remove 'gdbsupport/gdb_signals.h' include and delete |
| 366 | 'gdbarch' and 'thread_info' declarations. |
| 367 | (gcore_build_thread_register_notes): Delete declaration. |
| 368 | (gcore_find_signalled_thread): Likewise. |
| 369 | * fbsd-tdep.c: Remove 'gcore.h' include. |
| 370 | (struct fbsd_collect_regset_section_cb_data): New struct. |
| 371 | (fbsd_collect_regset_section_cb): New function. |
| 372 | (fbsd_collect_thread_registers): New function. |
| 373 | (struct fbsd_corefile_thread_data): New struct. |
| 374 | (fbsd_corefile_thread): New function. |
| 375 | (fbsd_make_corefile_notes): Call FreeBSD specific code. |
| 376 | * linux-tdep.c: Remove 'gcore.h' include. |
| 377 | (struct linux_collect_regset_section_cb_data): New struct. |
| 378 | (linux_collect_regset_section_cb): New function. |
| 379 | (linux_collect_thread_registers): New function. |
| 380 | (linux_corefile_thread): Call Linux specific code. |
| 381 | (find_signalled_thread): New function. |
| 382 | (linux_make_corefile_notes): Call find_signalled_thread. |
| 383 | |
| 384 | 2021-02-09 Tom Tromey <tromey@adacore.com> |
| 385 | |
| 386 | * ada-lang.c (coerce_unspec_val_to_type): Avoid making lazy |
| 387 | not_lval value. |
| 388 | * value.c (value_contents_copy_raw): Now static. |
| 389 | * value.h (value_contents_copy_raw): Don't declare. |
| 390 | |
| 391 | 2021-02-09 Tom Tromey <tromey@adacore.com> |
| 392 | |
| 393 | * gdbtypes.c (resolve_dynamic_struct): Handle structure with no |
| 394 | fields. |
| 395 | |
| 396 | 2021-02-08 Shahab Vahedi <shahab@synopsys.com> |
| 397 | |
| 398 | PR tdep/27369 |
| 399 | * arc-linux-tdep.c (handle_atomic_sequence): New. |
| 400 | (arc_linux_software_single_step): Call handle_atomic_sequence(). |
| 401 | |
| 402 | 2021-02-08 Andrew Burgess <andrew.burgess@embecosm.com> |
| 403 | |
| 404 | * python/py-tui.c (gdbpy_tui_window) <is_valid>: New member |
| 405 | function. |
| 406 | (REQUIRE_WINDOW): Call is_valid member function. |
| 407 | (REQUIRE_WINDOW_FOR_SETTER): New define. |
| 408 | (gdbpy_tui_is_valid): Call is_valid member function. |
| 409 | (gdbpy_tui_set_title): Call REQUIRE_WINDOW_FOR_SETTER instead. |
| 410 | * tui/tui-data.h (struct tui_win_info) <is_visible>: Check |
| 411 | tui_active too. |
| 412 | * tui/tui-layout.c (tui_apply_current_layout): Add an assert. |
| 413 | * tui/tui.c (tui_enable): Move setting of tui_active earlier in |
| 414 | the function. |
| 415 | |
| 416 | 2021-02-08 Andrew Burgess <andrew.burgess@embecosm.com> |
| 417 | |
| 418 | * python/py-tui.c (gdbpy_tui_set_title): Check that the new value |
| 419 | for the title is not nullptr. |
| 420 | |
| 421 | 2021-02-08 Andrew Burgess <andrew.burgess@embecosm.com> |
| 422 | |
| 423 | * tui-layout.c (saved_tui_windows): Delete. |
| 424 | (tui_apply_current_layout): Don't make use of saved_tui_windows, |
| 425 | call new get_windows member function instead. |
| 426 | (tui_get_window_by_name): Check in tui_windows. |
| 427 | (tui_layout_window::apply): Don't add to tui_windows. |
| 428 | * tui-layout.h (tui_layout_base::get_windows): New member function. |
| 429 | (tui_layout_window::get_windows): Likewise. |
| 430 | (tui_layout_split::get_windows): Likewise. |
| 431 | |
| 432 | 2021-02-08 Andrew Burgess <andrew.burgess@embecosm.com> |
| 433 | |
| 434 | * tui/tui-layout.c (tui_apply_current_layout): Restore the delete |
| 435 | of the window objects. |
| 436 | |
| 437 | 2021-02-08 Andrew Burgess <andrew.burgess@embecosm.com> |
| 438 | |
| 439 | * python/python.c (gdbpy_print_stack): Reformat an error message. |
| 440 | |
| 441 | 2021-02-08 Andrew Burgess <andrew.burgess@embecosm.com> |
| 442 | |
| 443 | * tui/tui-interp.c (tui_command_line_handler): New function. |
| 444 | (tui_interp::resume): Register tui_command_line_handler as the |
| 445 | input_handler. |
| 446 | * tui/tui-io.c (tui_inject_newline_into_command_window): New |
| 447 | function. |
| 448 | (tui_getc_1): Delete handling of '\n' and '\r'. |
| 449 | * tui-io.h (tui_inject_newline_into_command_window): Declare. |
| 450 | |
| 451 | 2021-02-07 Hannes Domani <ssbssa@yahoo.de> |
| 452 | |
| 453 | * tui/tui-regs.c (tui_data_window::display_registers_from): |
| 454 | Mark invisible register sub windows. |
| 455 | (tui_data_window::check_register_values): Ignore invisible |
| 456 | register sub windows. |
| 457 | |
| 458 | 2021-02-07 Hannes Domani <ssbssa@yahoo.de> |
| 459 | |
| 460 | * tui/tui-regs.c (tui_data_item_window::rerender): Don't call |
| 461 | n_spaces with a negative value. |
| 462 | |
| 463 | 2021-02-07 Hannes Domani <ssbssa@yahoo.de> |
| 464 | |
| 465 | * tui/tui-regs.c (tui_data_window::display_registers_from): |
| 466 | Add refresh_window call. |
| 467 | |
| 468 | 2021-02-07 Hannes Domani <ssbssa@yahoo.de> |
| 469 | |
| 470 | * python/py-frame.c (frapy_richcompare): Compare frame_id_is_next. |
| 471 | |
| 472 | 2021-02-05 Simon Marchi <simon.marchi@polymtl.ca> |
| 473 | |
| 474 | * symmisc.c (std_in, std_out, std_err): Remove. |
| 475 | (_initialize_symmisc): Don't set std_in, std_out and std_err. |
| 476 | |
| 477 | 2021-02-05 Tom de Vries <tdevries@suse.de> |
| 478 | |
| 479 | PR breakpoints/27330 |
| 480 | * breakpoint.c (create_exception_master_breakpoint): Handle case that |
| 481 | glibc object file has debug info. |
| 482 | |
| 483 | 2021-02-05 Tom de Vries <tdevries@suse.de> |
| 484 | |
| 485 | PR symtab/27333 |
| 486 | * dwarf2/read.c (process_psymtab_comp_unit): Handle DW_TAG_type_unit. |
| 487 | |
| 488 | 2021-02-05 Tom de Vries <tdevries@suse.de> |
| 489 | |
| 490 | PR breakpoints/27313 |
| 491 | * break-catch-syscall.c (catch_syscall_split_args): Reject negative |
| 492 | syscall numbers. |
| 493 | |
| 494 | 2021-02-05 Tom Tromey <tom@tromey.com> |
| 495 | |
| 496 | * compile/compile-c-support.c (get_compile_context) |
| 497 | (c_get_compile_context, cplus_get_compile_context): Change return |
| 498 | type. |
| 499 | * language.c (language_defn::get_compile_instance): New method. |
| 500 | * language.h (language_defn::get_compile_instance): Change return |
| 501 | type. No longer inline. |
| 502 | * c-lang.c (c_language::get_compile_instance): Change return type. |
| 503 | (cplus_language::get_compile_instance): Change return type. |
| 504 | * c-lang.h (c_get_compile_context, cplus_get_compile_context): |
| 505 | Change return type. |
| 506 | * compile/compile.c (compile_to_object): Update. |
| 507 | |
| 508 | 2021-02-05 Tom Tromey <tom@tromey.com> |
| 509 | |
| 510 | * parser-defs.h (write_exp_symbol_reference): Declare. |
| 511 | * parse.c (write_exp_symbol_reference): New function. |
| 512 | * p-exp.y (variable): Use write_exp_symbol_reference. |
| 513 | * m2-exp.y (variable): Use write_exp_symbol_reference. |
| 514 | * f-exp.y (variable): Use write_exp_symbol_reference. |
| 515 | * d-exp.y (PrimaryExpression): Use write_exp_symbol_reference. |
| 516 | * c-exp.y (variable): Use write_exp_symbol_reference. |
| 517 | |
| 518 | 2021-02-05 Tom de Vries <tdevries@suse.de> |
| 519 | |
| 520 | PR exp/27265 |
| 521 | * valarith.c (complex_binop): Throw an error if complex type can't |
| 522 | be created. |
| 523 | |
| 524 | 2021-02-05 Tom de Vries <tdevries@suse.de> |
| 525 | |
| 526 | PR symtab/27307 |
| 527 | * dwarf2/read.c (create_cus_from_debug_names_list): Add missing |
| 528 | return. |
| 529 | |
| 530 | 2021-02-05 Tom de Vries <tdevries@suse.de> |
| 531 | |
| 532 | * dwarf2/read.c (create_cus_from_debug_names_list): Fix indentation. |
| 533 | |
| 534 | 2021-02-04 Mike Frysinger <vapier@gentoo.org> |
| 535 | |
| 536 | * configure.tgt (riscv*-*-*): Set gdb_sim. |
| 537 | |
| 538 | 2021-02-04 Simon Marchi <simon.marchi@polymtl.ca> |
| 539 | |
| 540 | * target.c (target_is_non_stop_p): Return bool. |
| 541 | * target.h (target_is_non_stop_p): Return bool. |
| 542 | |
| 543 | 2021-02-04 Simon Marchi <simon.marchi@efficios.com> |
| 544 | |
| 545 | * record-full.c (record_full_async_inferior_event_handler): |
| 546 | Don't clear async event handler. |
| 547 | (record_full_base_target::wait): Clear async event handler at |
| 548 | beginning. |
| 549 | |
| 550 | 2021-02-04 Simon Marchi <simon.marchi@efficios.com> |
| 551 | |
| 552 | * record-btrace.c (record_btrace_handle_async_inferior_event): |
| 553 | Don't clear async event handler. |
| 554 | (record_btrace_target::wait): Clear async event handler at |
| 555 | beginning. |
| 556 | |
| 557 | 2021-02-04 Simon Marchi <simon.marchi@efficios.com> |
| 558 | |
| 559 | * remote.c (remote_target::wait): Clear async event handler at |
| 560 | beginning, mark if needed at the end. |
| 561 | (remote_async_inferior_event_handler): Don't set or clear async |
| 562 | event handler. |
| 563 | |
| 564 | 2021-02-04 Simon Marchi <simon.marchi@efficios.com> |
| 565 | |
| 566 | * async-event.h (async_event_handler_func): Add documentation. |
| 567 | * async-event.c (check_async_event_handlers): Don't clear |
| 568 | async_event_handler ready flag. |
| 569 | * infrun.c (infrun_async_inferior_event_handler): Clear ready |
| 570 | flag. |
| 571 | * record-btrace.c (record_btrace_handle_async_inferior_event): |
| 572 | Likewise. |
| 573 | * record-full.c (record_full_async_inferior_event_handler): |
| 574 | Likewise. |
| 575 | * remote-notif.c (remote_async_get_pending_events_handler): |
| 576 | Likewise. |
| 577 | * remote.c (remote_async_inferior_event_handler): Likewise. |
| 578 | |
| 579 | 2021-02-03 Simon Marchi <simon.marchi@polymtl.ca> |
| 580 | |
| 581 | * infrun.c (handle_inferior_event): Move stop_soon variable to |
| 582 | inner scope. |
| 583 | |
| 584 | 2021-02-03 Pedro Alves <pedro@palves.net> |
| 585 | |
| 586 | * infcmd.c (detach_command): Hold strong reference to target, and |
| 587 | if all-stop on entry, restart threads on exit. |
| 588 | * infrun.c (switch_back_to_stepped_thread): Factor out bits to ... |
| 589 | (restart_stepped_thread): ... this new function. Also handle |
| 590 | trap_expected. |
| 591 | (restart_after_all_stop_detach): New function. |
| 592 | * infrun.h (restart_after_all_stop_detach): Declare. |
| 593 | |
| 594 | 2021-02-03 Pedro Alves <pedro@palves.net> |
| 595 | |
| 596 | * infrun.c (struct step_over_info): Initialize fields. |
| 597 | (prepare_for_detach): Handle ongoing in-line step over. |
| 598 | |
| 599 | 2021-02-03 Pedro Alves <pedro@palves.net> |
| 600 | |
| 601 | * linux-nat.c (linux_nat_target::detach): Remove breakpoints |
| 602 | here... |
| 603 | * remote.c (remote_target::remote_detach_1): ... and here ... |
| 604 | * target.c (target_detach): ... instead of here. |
| 605 | * target.h (target_ops::detach): Add comment. |
| 606 | |
| 607 | 2021-02-03 Pedro Alves <pedro@palves.net> |
| 608 | |
| 609 | * infrun.c (struct wait_one_event): Move higher up. |
| 610 | (prepare_for_detach): Abort in-progress displaced steps instead of |
| 611 | letting them complete. |
| 612 | (handle_one): If the inferior is detaching, don't add the thread |
| 613 | back to the global step-over chain. |
| 614 | (restart_threads): Don't restart threads if detaching. |
| 615 | (handle_signal_stop): Remove inferior::detaching reference. |
| 616 | |
| 617 | 2021-02-03 Pedro Alves <pedro@palves.net> |
| 618 | |
| 619 | * infrun.c (prepare_for_detach): Don't release scoped_restore |
| 620 | before returning. |
| 621 | |
| 622 | 2021-02-03 Pedro Alves <pedro@palves.net> |
| 623 | |
| 624 | * infrun.c (handle_one): New function, factored out from ... |
| 625 | (stop_all_threads): ... here. |
| 626 | |
| 627 | 2021-02-03 Pedro Alves <pedro@palves.net> |
| 628 | |
| 629 | * remote.c (remote_notif_stop_ack): Don't error out on |
| 630 | TARGET_WAITKIND_IGNORE; instead, just ignore the notification. |
| 631 | (remote_target::discard_pending_stop_replies): Don't delete |
| 632 | in-flight notification; instead, clear its contents. |
| 633 | |
| 634 | 2021-02-03 Pedro Alves <pedro@palves.net> |
| 635 | |
| 636 | * remote.c (extended_remote_target::attach): Set target async in |
| 637 | the target-non-stop path too. |
| 638 | |
| 639 | 2021-02-03 Pedro Alves <pedro@palves.net> |
| 640 | |
| 641 | PR gdb/27055 |
| 642 | * infrun.c (handle_signal_stop): Move main context_switch call |
| 643 | earlier, before STOP_QUIETLY_NO_SIGSTOP. |
| 644 | |
| 645 | 2021-02-02 Lancelot SIX <lsix@lancelotsix.com> |
| 646 | |
| 647 | * NEWS (Changed commands): Add entry for the behavior change of |
| 648 | the inferior command. |
| 649 | * inferior.c (inferior_command): When no argument is given to the |
| 650 | inferior command, display info about the currently selected |
| 651 | inferior. |
| 652 | |
| 653 | 2021-02-02 Simon Marchi <simon.marchi@efficios.com> |
| 654 | |
| 655 | * dwarf2/read.c (read_loclist_index, read_rnglist_index): Return |
| 656 | a sect_offset. |
| 657 | (read_attribute_reprocess): Adjust. |
| 658 | |
| 659 | 2021-02-02 Simon Marchi <simon.marchi@efficios.com> |
| 660 | |
| 661 | * dwarf2/die.h (struct die_info) <ranges_base>: Split in... |
| 662 | <gnu_ranges_base>: ... this... |
| 663 | <rnglists_base>: ... and this. |
| 664 | * dwarf2/read.c (struct dwarf2_cu) <ranges_base>: Split in... |
| 665 | <gnu_ranges_base>: ... this... |
| 666 | <rnglists_base>: ... and this. |
| 667 | (read_cutu_die_from_dwo): Adjust |
| 668 | (dwarf2_get_pc_bounds): Adjust |
| 669 | (dwarf2_record_block_ranges): Adjust. |
| 670 | (read_full_die_1): Adjust |
| 671 | (partial_die_info::read): Adjust. |
| 672 | (read_rnglist_index): Adjust. |
| 673 | |
| 674 | 2021-02-02 Simon Marchi <simon.marchi@efficios.com> |
| 675 | |
| 676 | PR gdb/26813 |
| 677 | * dwarf2/read.c (read_loclists_rnglists_header): Add |
| 678 | header_offset parameter and use it. |
| 679 | (read_loclist_index): Read header of the current contribution, |
| 680 | not the one at the beginning of the section. |
| 681 | (read_rnglist_index): Likewise. |
| 682 | |
| 683 | 2021-02-02 Simon Marchi <simon.marchi@efficios.com> |
| 684 | |
| 685 | PR gdb/26813 |
| 686 | * dwarf2/attribute.h (struct attribute) <set_unsigned>: Clear |
| 687 | requires_reprocessing flag. |
| 688 | * dwarf2/attribute.c (attribute::form_is_unsigned): Handle |
| 689 | DW_FORM_loclistx. |
| 690 | (attribute::form_requires_reprocessing): Handle DW_FORM_rnglistx |
| 691 | and DW_FORM_loclistx. |
| 692 | * dwarf2/read.c (read_attribute_reprocess): Use set_unsigned |
| 693 | instead of set_address for DW_FORM_loclistx and |
| 694 | DW_FORM_rnglistx. |
| 695 | |
| 696 | 2021-02-02 Simon Marchi <simon.marchi@efficios.com> |
| 697 | |
| 698 | * dwarf2/read.c (read_loclist_index): Remove bound check for |
| 699 | start of offset. |
| 700 | (read_rnglist_index): Likewise. |
| 701 | |
| 702 | 2021-02-02 Simon Marchi <simon.marchi@efficios.com> |
| 703 | |
| 704 | * dwarf2/read.c (read_loclist_index): Add bound check for the end |
| 705 | of the offset. |
| 706 | |
| 707 | 2021-02-02 Simon Marchi <simon.marchi@efficios.com> |
| 708 | |
| 709 | * dwarf2/read.c (read_rnglist_index): Fix bound check. |
| 710 | |
| 711 | 2021-02-02 Simon Marchi <simon.marchi@efficios.com> |
| 712 | |
| 713 | * dwarf2/read.c (read_loclist_index): Change complaints into |
| 714 | errors. |
| 715 | |
| 716 | 2021-02-02 Tom de Vries <tdevries@suse.de> |
| 717 | |
| 718 | PR symtab/24620 |
| 719 | * dwarf2/index-write.c (write_one_signatured_type): Skip if |
| 720 | psymtab == nullptr. |
| 721 | |
| 722 | 2021-02-01 Andrew Burgess <andrew.burgess@embecosm.com> |
| 723 | |
| 724 | * Makefile.in (HFILES_NO_SRCDIR): Add corefile.h. |
| 725 | * gcore.c (struct gcore_collect_regset_section_cb_data): Moved |
| 726 | here from linux-tdep.c and given a new name. Minor cleanups. |
| 727 | (gcore_collect_regset_section_cb): Likewise. |
| 728 | (gcore_collect_thread_registers): Likewise. |
| 729 | (gcore_build_thread_register_notes): Likewise. |
| 730 | (gcore_find_signalled_thread): Likewise. |
| 731 | * gcore.h (gcore_build_thread_register_notes): Declare. |
| 732 | (gcore_find_signalled_thread): Declare. |
| 733 | * fbsd-tdep.c: Add 'gcore.h' include. |
| 734 | (struct fbsd_collect_regset_section_cb_data): Delete. |
| 735 | (fbsd_collect_regset_section_cb): Delete. |
| 736 | (fbsd_collect_thread_registers): Delete. |
| 737 | (struct fbsd_corefile_thread_data): Delete. |
| 738 | (fbsd_corefile_thread): Delete. |
| 739 | (fbsd_make_corefile_notes): Call |
| 740 | gcore_build_thread_register_notes instead of the now deleted |
| 741 | FreeBSD code. |
| 742 | * linux-tdep.c: Add 'gcore.h' include. |
| 743 | (struct linux_collect_regset_section_cb_data): Delete. |
| 744 | (linux_collect_regset_section_cb): Delete. |
| 745 | (linux_collect_thread_registers): Delete. |
| 746 | (linux_corefile_thread): Call |
| 747 | gcore_build_thread_register_notes. |
| 748 | (find_signalled_thread): Delete. |
| 749 | (linux_make_corefile_notes): Call gcore_find_signalled_thread. |
| 750 | |
| 751 | 2021-01-29 Tom de Vries <tdevries@suse.de> |
| 752 | |
| 753 | PR breakpoints/26063 |
| 754 | * infrun.c (process_event_stop_test): Reset |
| 755 | ecs->event_thread->current_line to 0 if is-stmt=n and frame has |
| 756 | changed. |
| 757 | |
| 758 | 2021-01-28 Andrew Burgess <andrew.burgess@embecosm.com> |
| 759 | |
| 760 | * thread.c (thr_try_catch_cmd): Replace swith_to_thread with an |
| 761 | assert. Extend the header comment. |
| 762 | |
| 763 | 2021-01-28 Andrew Burgess <andrew.burgess@embecosm.com> |
| 764 | |
| 765 | * Makefile.in (SUBDIR_TUI_SRCS): Add tui/tui-location.c. |
| 766 | (HFILES_NO_SRCDIR): Add tui/tui-location.h. |
| 767 | * tui/tui-data.h (TUI_STATUS_WIN): Define. |
| 768 | (tui_locator_win_info_ptr): Delete declaration. |
| 769 | * tui/tui-disasm.c: Add 'tui/tui-location.h' include. |
| 770 | (tui_disasm_window::set_contents): Fetch state from tui_location |
| 771 | global. |
| 772 | (tui_get_begin_asm_address): Likewise. |
| 773 | * tui/tui-layout.c (tui_apply_current_layout): Remove special case |
| 774 | for locator window. |
| 775 | (get_locator_window): Delete. |
| 776 | (initialize_known_windows): Treat locator window just like all the |
| 777 | rest. |
| 778 | * tui/tui-source.c: Add 'tui/tui-location.h' include. |
| 779 | (tui_source_window::set_contents): Fetch state from tui_location |
| 780 | global. |
| 781 | (tui_source_window::showing_source_p): Likewise. |
| 782 | * tui/tui-stack.c: Add 'tui/tui-location.h' include. |
| 783 | (_locator): Delete. |
| 784 | (tui_locator_win_info_ptr): Delete. |
| 785 | (tui_locator_window::make_status_line): Fetch state from |
| 786 | tui_location global. |
| 787 | (tui_locator_window::rerender): Remove check of 'handle', |
| 788 | reindent function body. |
| 789 | (tui_locator_window::set_locator_fullname): Delete. |
| 790 | (tui_locator_window::set_locator_info): Delete. |
| 791 | (tui_update_locator_fullname): Delete. |
| 792 | (tui_show_frame_info): Likewise. |
| 793 | (tui_show_locator_content): Access window through TUI_STATUS_WIN. |
| 794 | * tui/tui-stack.h (tui_locator_window::set_locator_info): Moved to |
| 795 | tui/tui-location.h and renamed to |
| 796 | tui_location_tracker::set_location. |
| 797 | (tui_locator_window::set_locator_fullname): Moved to |
| 798 | tui/tui-location.h and renamed to |
| 799 | tui_location_tracker::set_fullname. |
| 800 | (tui_locator_window::full_name): Delete. |
| 801 | (tui_locator_window::proc_name): Delete. |
| 802 | (tui_locator_window::line_no): Delete. |
| 803 | (tui_locator_window::addr): Delete. |
| 804 | (tui_locator_window::gdbarch): Delete. |
| 805 | (tui_update_locator_fullname): Delete declaration. |
| 806 | * tui/tui-wingeneral.c (tui_refresh_all): Removed special handling |
| 807 | for locator window. |
| 808 | * tui/tui-winsource.c: Add 'tui/tui-location.h' include. |
| 809 | (tui_display_main): Call function on tui_location directly. |
| 810 | * tui/tui.h (enum tui_win_type): Add STATUS_WIN. |
| 811 | * tui/tui-location.c: New file. |
| 812 | * tui/tui-location.h: New file. |
| 813 | |
| 814 | 2021-01-28 Simon Marchi <simon.marchi@polymtl.ca> |
| 815 | |
| 816 | * gdbtypes.h (get_type_arch): Rename to... |
| 817 | (struct type) <arch>: ... this, update all users. |
| 818 | |
| 819 | 2021-01-28 Simon Marchi <simon.marchi@polymtl.ca> |
| 820 | |
| 821 | * gdbtypes.h (struct type) <arch>: Rename to... |
| 822 | <arch_owner>: ... this, update all users. |
| 823 | <objfile>: Rename to... |
| 824 | <objfile_owner>: ... this, update all users. |
| 825 | |
| 826 | 2021-01-28 Andrew Burgess <andrew.burgess@embecosm.com> |
| 827 | |
| 828 | * gdbcmd.h (execute_command_to_string): Update comment. |
| 829 | * top.c (execute_command_to_string): Update header comment. |
| 830 | |
| 831 | 2021-01-28 Tom de Vries <tdevries@suse.de> |
| 832 | |
| 833 | PR breakpoints/27205 |
| 834 | * breakpoint.c (create_longjmp_master_breakpoint_probe) |
| 835 | (create_longjmp_master_breakpoint_names): New function, factored out |
| 836 | of ... |
| 837 | (create_longjmp_master_breakpoint): ... here. Only try to install |
| 838 | longjmp_names breakpoints in libc.so/libc.so.debug if installing probe |
| 839 | breakpoint in libc.so failed. |
| 840 | |
| 841 | 2021-01-27 Lancelot SIX <lsix@lancelotsix.com> |
| 842 | |
| 843 | PR gdb/27133 |
| 844 | * cli/cli-interp.c (cli_interp_base::set_logging): Ensure the |
| 845 | unique_ptr is released when the wrapped pointer is kept for later |
| 846 | use. |
| 847 | |
| 848 | 2021-01-27 Matthew Malcomson <matthew.malcomson@arm.com> |
| 849 | |
| 850 | * aarch64-tdep.c (aarch64_displaced_step_others): Account for |
| 851 | BLR and BR instructions. |
| 852 | * arch/aarch64-insn.h (enum aarch64_opcodes): Add BR opcode. |
| 853 | (enum aarch64_masks): New. |
| 854 | |
| 855 | 2021-01-26 Tom Tromey <tromey@adacore.com> |
| 856 | |
| 857 | * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM) |
| 858 | (DEBUG_EXCEPT): Use debug_prefixed_printf_cond. |
| 859 | (windows_init_thread_list, windows_nat::handle_load_dll) |
| 860 | (windows_nat::handle_unload_dll, windows_nat_target::resume) |
| 861 | (windows_nat_target::resume) |
| 862 | (windows_nat_target::get_windows_debug_event) |
| 863 | (windows_nat_target::interrupt, windows_xfer_memory) |
| 864 | (windows_nat_target::close): Update. |
| 865 | * nat/windows-nat.c (DEBUG_EVENTS): Use |
| 866 | debug_prefixed_printf_cond. |
| 867 | (matching_pending_stop, fetch_pending_stop) |
| 868 | (continue_last_debug_event): Update. |
| 869 | |
| 870 | 2020-12-17 Mihails Strasuns <mihails.strasuns@intel.com> |
| 871 | |
| 872 | * linux-tdep.c (linux_make_mappings_corefile_notes): Start using |
| 873 | elfcore_write_file_note. |
| 874 | |
| 875 | 2021-01-26 Shahab Vahedi <shahab@synopsys.com> |
| 876 | |
| 877 | * arc-tdep.c (arc_add_reggroups): New function. |
| 878 | (arc_gdbarch_init): Call arc_add_reggroups. |
| 879 | |
| 880 | 2021-01-26 Anton Kolesov <anton.kolesov@synopsys.com> |
| 881 | |
| 882 | * arc-tdep.c (arc_skip_prologue): Log "pc" address. |
| 883 | |
| 884 | 2021-01-25 Bernd Edlinger <bernd.edlinger@hotmail.de> |
| 885 | Simon Marchi <simon.marchi@polymtl.ca> |
| 886 | Tom de Vries <tdevries@suse.de> |
| 887 | |
| 888 | * dwarf2/read.c (partial_die_info::read): Use as_unsigned () for |
| 889 | DW_AT_ranges. |
| 890 | |
| 891 | 2021-01-25 Tom Tromey <tromey@adacore.com> |
| 892 | |
| 893 | * dwarf2/read.c (get_mpz): New function. |
| 894 | (get_dwarf2_rational_constant): Use it. |
| 895 | |
| 896 | 2021-01-25 Tom Tromey <tromey@adacore.com> |
| 897 | |
| 898 | * ada-lang.c (resolve_subexp): Handle array context. |
| 899 | |
| 900 | 2021-01-23 Tom Tromey <tom@tromey.com> |
| 901 | |
| 902 | PR compile/25575 |
| 903 | * compile/compile-loc2c.c (note_register): New function. |
| 904 | (pushf_register_address, pushf_register): Use it. |
| 905 | |
| 906 | 2021-01-23 Tom Tromey <tom@tromey.com> |
| 907 | |
| 908 | * symtab.h (struct symbol_computed_ops) <generate_c_location>: |
| 909 | Change type of "registers_used". |
| 910 | * dwarf2/loc.h (dwarf2_compile_property_to_c): Update. |
| 911 | * dwarf2/loc.c (dwarf2_compile_property_to_c) |
| 912 | (locexpr_generate_c_location, loclist_generate_c_location): Change |
| 913 | type of "registers_used". |
| 914 | * compile/compile.h (compile_dwarf_expr_to_c) |
| 915 | (compile_dwarf_bounds_to_c): Update. |
| 916 | * compile/compile-loc2c.c (pushf_register_address) |
| 917 | (pushf_register, do_compile_dwarf_expr_to_c) |
| 918 | (compile_dwarf_expr_to_c, compile_dwarf_bounds_to_c): Change type |
| 919 | of "registers_used". |
| 920 | * compile/compile-c.h (generate_c_for_variable_locations): |
| 921 | Update. |
| 922 | * compile/compile-c-symbols.c (generate_vla_size) |
| 923 | (generate_c_for_for_one_variable): Change type of |
| 924 | "registers_used". |
| 925 | (generate_c_for_variable_locations): Return std::vector. |
| 926 | * compile/compile-c-support.c (generate_register_struct): Change |
| 927 | type of "registers_used". |
| 928 | (compute): Update. |
| 929 | |
| 930 | 2021-01-23 Tom Tromey <tom@tromey.com> |
| 931 | |
| 932 | * compile/compile-internal.h (class compile_instance) |
| 933 | <set_arguments>: Change return type. |
| 934 | * compile/compile.c (compile_to_object): Remove call to reset. |
| 935 | (compile_instance::set_arguments): Change return type. |
| 936 | |
| 937 | 2021-01-23 Simon Marchi <simon.marchi@polymtl.ca> |
| 938 | |
| 939 | * gdbtypes.c (copy_type_recursive): Use get_type_arch. |
| 940 | * gdbtypes.h (struct type) <set_owner>: Add asserts. |
| 941 | |
| 942 | 2021-01-23 Lancelot SIX <lsix@lancelotsix.com> |
| 943 | |
| 944 | * Makefile.in (SELFTESTS_SRCS): Add |
| 945 | unittests/gdb_tilde_expand-selftests.c. |
| 946 | * unittests/gdb_tilde_expand-selftests.c: New file. |
| 947 | |
| 948 | 2021-01-22 Andrew Burgess <andrew.burgess@embecosm.com> |
| 949 | |
| 950 | PR cli/25956 |
| 951 | * NEWS: Mention new command. |
| 952 | * cli/cli-style.c: Add 'cli/cli-setshow.h' include. |
| 953 | (version_style): Define. |
| 954 | (cli_style_option::cli_style_option): Add intensity parameter, and |
| 955 | use as appropriate. |
| 956 | (_initialize_cli_style): Register version style set/show commands. |
| 957 | * cli/cli-style.h (cli_style_option): Add intensity parameter. |
| 958 | (version_style): Declare. |
| 959 | * top.c (print_gdb_version): Use version_stype, and styled_string |
| 960 | to print the GDB version string. |
| 961 | |
| 962 | 2021-01-22 Andrew Burgess <andrew.burgess@embecosm.com> |
| 963 | |
| 964 | * utils.c (emit_style_escape): Only emit an escape sequence if the |
| 965 | requested style is different than the current applied style. |
| 966 | (fputs_maybe_filtered): Adjust the juggling of the wrap_style, and |
| 967 | current applied_style. |
| 968 | (fputs_styled): Remove is_default check. |
| 969 | (fputs_styled_unfiltered): Likewise. |
| 970 | (vfprintf_styled_no_gdbfmt): Likewise. |
| 971 | |
| 972 | 2021-01-22 Simon Marchi <simon.marchi@polymtl.ca> |
| 973 | |
| 974 | * remote.h (remote_debug_printf): New. |
| 975 | (remote_debug_printf_nofunc): New. |
| 976 | (REMOTE_SCOPED_DEBUG_ENTER_EXIT): New. |
| 977 | * remote.c: Use above macros throughout file. |
| 978 | |
| 979 | 2021-01-22 Simon Marchi <simon.marchi@polymtl.ca> |
| 980 | |
| 981 | * remote.h (remote_debug): Change to bool. |
| 982 | * remote.c (remote_debug): Change to bool. |
| 983 | (_initialize_remote): Adjust. |
| 984 | |
| 985 | 2021-01-22 Simon Marchi <simon.marchi@polymtl.ca> |
| 986 | |
| 987 | * target.h (remote_debug): Move to... |
| 988 | * remote.h (remote_debug): ... here. |
| 989 | * top.c (remote_debug): Move to... |
| 990 | * remote.c (remote_debug): ... here. |
| 991 | * remote-sim.c: Include remote.h. |
| 992 | |
| 993 | 2021-01-22 Simon Marchi <simon.marchi@polymtl.ca> |
| 994 | |
| 995 | * cli/cli-cmds.c (show_remote_debug): Remove. |
| 996 | (show_remote_timeout): Remove. |
| 997 | (_initialize_cli_cmds): Don't register commands. |
| 998 | * remote.c (show_remote_debug): Move here. |
| 999 | (show_remote_timeout): Move here. |
| 1000 | (_initialize_remote): Register commands. |
| 1001 | |
| 1002 | 2021-01-22 Simon Marchi <simon.marchi@polymtl.ca> |
| 1003 | |
| 1004 | * gdbtypes.h (TYPE_OBJFILE): Remove, change all users to use the |
| 1005 | type::objfile method instead. |
| 1006 | |
| 1007 | 2021-01-22 Simon Marchi <simon.marchi@polymtl.ca> |
| 1008 | |
| 1009 | * gdbtypes.h (TYPE_OBJFILE_OWNED): Remove, update all users to |
| 1010 | use the type::is_objfile_owned method. |
| 1011 | |
| 1012 | 2021-01-22 Simon Marchi <simon.marchi@efficios.com> |
| 1013 | |
| 1014 | * gdbtypes.h (TYPE_OBJFILE_OWNED): Adjust. |
| 1015 | (TYPE_OWNER): Remove. |
| 1016 | (TYPE_OBJFILE): Adjust. |
| 1017 | (struct main_type) <flag_objfile_owned>: Rename to... |
| 1018 | <m_flag_objfile_owned>: ... this. |
| 1019 | <owner>: Rename to... |
| 1020 | <m_owner>: ... this. |
| 1021 | (struct type) <is_objfile_owned, set_owner, objfile, arch>: New |
| 1022 | methods. |
| 1023 | (TYPE_ALLOC): Adjust. |
| 1024 | * gdbtypes.c (alloc_type): Adjust. |
| 1025 | (alloc_type_arch): Adjust. |
| 1026 | (alloc_type_copy): Adjust. |
| 1027 | (get_type_arch): Adjust. |
| 1028 | (smash_type): Adjust. |
| 1029 | (lookup_array_range_type): Adjust. |
| 1030 | (recursive_dump_type): Adjust. |
| 1031 | (copy_type_recursive): Adjust. |
| 1032 | * compile/compile-c-types.c (convert_func): Adjust. |
| 1033 | (convert_type_basic): Adjust. |
| 1034 | * compile/compile-cplus-types.c (compile_cplus_convert_func): |
| 1035 | Adjust. |
| 1036 | * language.c |
| 1037 | (language_arch_info::type_and_symbol::alloc_type_symbol): |
| 1038 | Adjust. |
| 1039 | |
| 1040 | 2021-01-21 Luis Machado <luis.machado@linaro.org> |
| 1041 | |
| 1042 | * coffread.c (enter_linenos): Passing string to complaint. |
| 1043 | * valops.c (value_assign): Make array view. |
| 1044 | |
| 1045 | 2021-01-21 Simon Marchi <simon.marchi@polymtl.ca> |
| 1046 | |
| 1047 | * auto-load.h (debug_auto_load): Move here. |
| 1048 | (auto_load_debug_printf): New. |
| 1049 | * auto-load.c: Use auto_load_debug_printf. |
| 1050 | (debug_auto_load): Move to header. |
| 1051 | * linux-thread-db.c (try_thread_db_load): Use |
| 1052 | auto_load_debug_printf. |
| 1053 | * main.c (captured_main_1): Likewise. |
| 1054 | |
| 1055 | 2021-01-21 Simon Marchi <simon.marchi@polymtl.ca> |
| 1056 | |
| 1057 | * f-valprint.c (f77_array_offset_tbl): Remove. |
| 1058 | |
| 1059 | 2021-01-21 Simon Marchi <simon.marchi@polymtl.ca> |
| 1060 | |
| 1061 | * gdb_bfd.c (bfd_cache_debug_printf): New, use throughout file. |
| 1062 | |
| 1063 | 2021-01-21 Simon Marchi <simon.marchi@polymtl.ca> |
| 1064 | |
| 1065 | * ser-tcp.c (wait_for_connect): Use interruptible_select instead |
| 1066 | of gdb_select. |
| 1067 | |
| 1068 | 2021-01-21 Hannes Domani <ssbssa@yahoo.de> |
| 1069 | |
| 1070 | PR python/19151 |
| 1071 | * python/py-breakpoint.c (bppy_get_location): Handle |
| 1072 | bp_hardware_breakpoint. |
| 1073 | (bppy_init): Likewise. |
| 1074 | (gdbpy_breakpoint_created): Likewise. |
| 1075 | |
| 1076 | 2021-01-21 Simon Marchi <simon.marchi@polymtl.ca> |
| 1077 | |
| 1078 | * arm-tdep.c (arm_debug_printf): Add and use throughout file. |
| 1079 | |
| 1080 | 2021-01-20 Simon Marchi <simon.marchi@polymtl.ca> |
| 1081 | |
| 1082 | * gdb_bfd.c (debug_bfd_cache): Change type to bool. |
| 1083 | (_initialize_gdb_bfd): Adjust. |
| 1084 | |
| 1085 | 2021-01-20 Simon Marchi <simon.marchi@polymtl.ca> |
| 1086 | |
| 1087 | PR gdb/26828 |
| 1088 | * dwarf2/read.c (maybe_queue_comp_unit): Add assertion. |
| 1089 | |
| 1090 | 2021-01-20 Simon Marchi <simon.marchi@polymtl.ca> |
| 1091 | |
| 1092 | * dwarf2/read.c (follow_die_offset): Add logging. |
| 1093 | (dwarf2_per_objfile::age_comp_units): Add logging. |
| 1094 | |
| 1095 | 2021-01-20 Simon Marchi <simon.marchi@polymtl.ca> |
| 1096 | |
| 1097 | * aarch64-linux-tdep.c (aarch64_linux_record_tdep): Make static. |
| 1098 | * aarch64-tdep.c (tdesc_aarch64_list, aarch64_prologue_unwind, |
| 1099 | aarch64_stub_unwind, aarch64_normal_base, ): Make static. |
| 1100 | * arm-linux-tdep.c (arm_prologue_unwind): Make static. |
| 1101 | * arm-tdep.c (struct frame_unwind): Make static. |
| 1102 | * auto-load.c (auto_load_safe_path_vec): Make static. |
| 1103 | * csky-tdep.c (csky_stub_unwind): Make static. |
| 1104 | * gdbarch.c (gdbarch_data_registry): Make static. |
| 1105 | * gnu-v2-abi.c (gnu_v2_abi_ops): Make static. |
| 1106 | * i386-netbsd-tdep.c (i386nbsd_mc_reg_offset): Make static. |
| 1107 | * i386-tdep.c (i386_frame_setup_skip_insns, |
| 1108 | i386_tramp_chain_in_reg_insns, i386_tramp_chain_on_stack_insns): |
| 1109 | Make static. |
| 1110 | * infrun.c (observer_mode): Make static. |
| 1111 | * linux-nat.c (sigchld_action): Make static. |
| 1112 | * linux-thread-db.c (thread_db_list): Make static. |
| 1113 | * maint-test-options.c (maintenance_test_options_list): |
| 1114 | * mep-tdep.c (mep_csr_registers): Make static. |
| 1115 | * mi/mi-cmds.c (struct mi_cmd_stats): Remove struct type name. |
| 1116 | (stats): Make static. |
| 1117 | * nat/linux-osdata.c (struct osdata_type): Make static. |
| 1118 | * ppc-netbsd-tdep.c (ppcnbsd_reg_offsets): Make static. |
| 1119 | * progspace.c (last_program_space_num): Make static. |
| 1120 | * python/py-param.c (struct parm_constant): Remove struct type |
| 1121 | name. |
| 1122 | (parm_constants): Make static. |
| 1123 | * python/py-record-btrace.c (btpy_list_methods): Make static. |
| 1124 | * python/py-record.c (recpy_gap_type): Make static. |
| 1125 | * record.c (record_goto_cmdlist): Make static. |
| 1126 | * regcache.c (regcache_descr_handle): Make static. |
| 1127 | * registry.h (DEFINE_REGISTRY): Make definition static. |
| 1128 | * symmisc.c (std_in, std_out, std_err): Make static. |
| 1129 | * top.c (previous_saved_command_line): Make static. |
| 1130 | * tracepoint.c (trace_user, trace_notes, trace_stop_notes): Make |
| 1131 | static. |
| 1132 | * unittests/command-def-selftests.c (nr_duplicates, |
| 1133 | nr_invalid_prefixcmd, lists): Make static. |
| 1134 | * unittests/observable-selftests.c (test_notification): Make |
| 1135 | static. |
| 1136 | * unittests/optional/assignment/1.cc (counter): Make static. |
| 1137 | * unittests/optional/assignment/2.cc (counter): Make static. |
| 1138 | * unittests/optional/assignment/3.cc (counter): Make static. |
| 1139 | * unittests/optional/assignment/4.cc (counter): Make static. |
| 1140 | * unittests/optional/assignment/5.cc (counter): Make static. |
| 1141 | * unittests/optional/assignment/6.cc (counter): Make static. |
| 1142 | |
| 1143 | 2021-01-20 Joel Sherrill <joel@rtems.org> |
| 1144 | |
| 1145 | PR gdb/27219 |
| 1146 | * remote.c (struct remote_thread_info) <resume_state>: Rename |
| 1147 | to... |
| 1148 | <get_resume_state>: ... this. |
| 1149 | (remote_target::resume): Adjust. |
| 1150 | (remote_target::commit_resume): Adjust. |
| 1151 | (remote_target::select_thread_for_ambiguous_stop_reply): Adjust. |
| 1152 | |
| 1153 | 2021-01-20 Sergio Durigan Junior <sergiodj@sergiodj.net> |
| 1154 | Tom Tromey <tom@tromey.com> |
| 1155 | |
| 1156 | * stap-probe.c (stap_parse_single_operand): Handle '!' |
| 1157 | operator. |
| 1158 | (stap_parse_argument_conditionally): Likewise. |
| 1159 | Skip spaces after processing open-parenthesis sub-expression. |
| 1160 | (stap_parse_argument_1): Skip spaces after call to |
| 1161 | stap_parse_argument_conditionally. |
| 1162 | Handle case when right-side expression is a parenthesized |
| 1163 | sub-expression. |
| 1164 | Skip spaces after call to stap_parse_argument_1. |
| 1165 | |
| 1166 | 2021-01-19 Lancelot SIX <lsix@lancelotsix.com> |
| 1167 | |
| 1168 | * top.h (switch_thru_all_uis): Use DISABLE_COPY_AND_ASSIGN. |
| 1169 | |
| 1170 | 2021-01-19 Luis Machado <luis.machado@linaro.org> |
| 1171 | |
| 1172 | * trad-frame.h (trad_frame_saved_reg) <set_value_bytes>: Allocate |
| 1173 | memory and save data. |
| 1174 | (trad_frame_set_value, trad_frame_set_realreg, trad_frame_set_addr) |
| 1175 | (trad_frame_set_unknown, trad_frame_set_value_bytes) |
| 1176 | (trad_frame_value_p, trad_frame_addr_p, trad_frame_realreg_p) |
| 1177 | (trad_frame_value_bytes_p): Remove. |
| 1178 | (trad_frame_reset_saved_regs): Adjust documentation. |
| 1179 | * trad-frame.c (trad_frame_alloc_saved_regs): Initialize via a |
| 1180 | constructor and reset the state of the registers. |
| 1181 | (trad_frame_value_p, trad_frame_addr_p, trad_frame_realreg_p) |
| 1182 | (trad_frame_value_bytes_p, trad_frame_set_value) |
| 1183 | (trad_frame_set_realreg, trad_frame_set_addr) |
| 1184 | (trad_frame_set_unknown, trad_frame_set_value_bytes): Remove. |
| 1185 | (trad_frame_set_reg_realreg): Update to call member function. |
| 1186 | (trad_frame_set_reg_addr, trad_frame_set_reg_value_bytes): Likewise. |
| 1187 | (trad_frame_get_prev_register): Likewise. |
| 1188 | |
| 1189 | * aarch64-tdep.c (aarch64_analyze_prologue) |
| 1190 | (aarch64_analyze_prologue_test, aarch64_make_prologue_cache_1) |
| 1191 | (aarch64_prologue_prev_register): Update to use member functions. |
| 1192 | * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Likewise. |
| 1193 | * alpha-tdep.c (alpha_heuristic_frame_unwind_cache): Likewise. |
| 1194 | * arc-tdep.c (arc_print_frame_cache, arc_make_frame_cache): Likewise. |
| 1195 | * arm-tdep.c (arm_make_prologue_cache, arm_exidx_fill_cache) |
| 1196 | (arm_make_epilogue_frame_cache): Likewise. |
| 1197 | * avr-tdep.c (avr_frame_unwind_cache) |
| 1198 | (avr_frame_prev_register): Likewise. |
| 1199 | * cris-tdep.c (cris_scan_prologue): Likewise. |
| 1200 | * csky-tdep.c (csky_frame_unwind_cache): Likewise. |
| 1201 | * frv-tdep.c (frv_analyze_prologue): Likewise. |
| 1202 | * hppa-tdep.c (hppa_frame_cache, hppa_fallback_frame_cache): Likewise. |
| 1203 | * lm32-tdep.c (lm32_frame_cache): Likewise. |
| 1204 | * m32r-tdep.c (m32r_frame_unwind_cache): Likewise. |
| 1205 | * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Likewise. |
| 1206 | * mips-tdep.c (set_reg_offset, mips_insn16_frame_cache) |
| 1207 | (mips_micro_frame_cache, mips_insn32_frame_cache): Likewise. |
| 1208 | (reset_saved_regs): Adjust to set realreg. |
| 1209 | * riscv-tdep.c (riscv_scan_prologue, riscv_frame_cache): Adjust to |
| 1210 | call member functions. |
| 1211 | * rs6000-tdep.c (rs6000_frame_cache, rs6000_epilogue_frame_cache) |
| 1212 | * s390-tdep.c (s390_prologue_frame_unwind_cache) |
| 1213 | (s390_backchain_frame_unwind_cache): Likewise. |
| 1214 | * score-tdep.c (score7_analyze_prologue) |
| 1215 | (score3_analyze_prologue, score_make_prologue_cache): Likewise. |
| 1216 | * sparc-netbsd-tdep.c (sparc32nbsd_sigcontext_saved_regs): Likewise. |
| 1217 | * sparc-sol2-tdep.c (sparc32_sol2_sigtramp_frame_cache): Likewise. |
| 1218 | * sparc64-netbsd-tdep.c (sparc64nbsd_sigcontext_saved_regs): Likewise. |
| 1219 | * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_cache): Likewise. |
| 1220 | * tilegx-tdep.c (tilegx_analyze_prologue) |
| 1221 | (tilegx_frame_cache): Likewise. |
| 1222 | * v850-tdep.c (v850_frame_cache): Likewise. |
| 1223 | * vax-tdep.c (vax_frame_cache): Likewise. |
| 1224 | |
| 1225 | 2021-01-19 Luis Machado <luis.machado@linaro.org> |
| 1226 | |
| 1227 | * frame.h (get_frame_register_bytes): Pass a gdb::array_view instead |
| 1228 | of buffer + length. |
| 1229 | (put_frame_register_bytes): Likewise. |
| 1230 | Adjust documentation. |
| 1231 | (get_frame_memory): Pass a gdb::array_view instead of buffer + length. |
| 1232 | (safe_frame_unwind_memory): Likewise. |
| 1233 | * frame.c (get_frame_register_bytes, put_frame_register_bytes) |
| 1234 | (get_frame_memory, safe_frame_unwind_memory): Adjust to use |
| 1235 | gdb::array_view. |
| 1236 | * amd64-fbsd-tdep.c (amd64fbsd_sigtramp_p): Likewise. |
| 1237 | * amd64-linux-tdep.c (amd64_linux_sigtramp_start): Likewise. |
| 1238 | * amd64-obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. |
| 1239 | * arc-linux-tdep.c (arc_linux_is_sigtramp): Likewise. |
| 1240 | * cris-tdep.c (cris_sigtramp_start, cris_rt_sigtramp_start): Likewise. |
| 1241 | * dwarf2/loc.c (rw_pieced_value): Likewise. |
| 1242 | * hppa-tdep.c (hppa_frame_cache): Likewise. |
| 1243 | * i386-fbsd-tdep.c (i386fbsd_sigtramp_p): Likewise. |
| 1244 | * i386-gnu-tdep.c (i386_gnu_sigtramp_start): Likewise. |
| 1245 | * i386-linux-tdep.c (i386_linux_sigtramp_start) |
| 1246 | (i386_linux_rt_sigtramp_start): Likewise. |
| 1247 | * i386-obsd-tdep.c (i386obsd_sigtramp_p): Likewise. |
| 1248 | * i386-tdep.c (i386_register_to_value): Likewise. |
| 1249 | * i387-tdep.c (i387_register_to_value): Likewise. |
| 1250 | * ia64-tdep.c (ia64_register_to_value): Likewise. |
| 1251 | * m32r-linux-tdep.c (m32r_linux_sigtramp_start) |
| 1252 | (m32r_linux_rt_sigtramp_start): Likewise. |
| 1253 | * m68k-linux-tdep.c (m68k_linux_pc_in_sigtramp): Likewise. |
| 1254 | * m68k-tdep.c (m68k_register_to_value): Likewise. |
| 1255 | * mips-tdep.c (mips_register_to_value) |
| 1256 | (mips_value_to_register): Likewise. |
| 1257 | * ppc-fbsd-tdep.c (ppcfbsd_sigtramp_frame_sniffer) |
| 1258 | (ppcfbsd_sigtramp_frame_cache): Likewise. |
| 1259 | * ppc-obsd-tdep.c (ppcobsd_sigtramp_frame_sniffer) |
| 1260 | (ppcobsd_sigtramp_frame_cache): Likewise. |
| 1261 | * rs6000-tdep.c (rs6000_in_function_epilogue_frame_p) |
| 1262 | (rs6000_register_to_value): Likewise. |
| 1263 | * tilegx-tdep.c (tilegx_analyze_prologue): Likewise. |
| 1264 | * tramp-frame.c (tramp_frame_start): Likewise. |
| 1265 | * valops.c (value_assign): Likewise. |
| 1266 | |
| 1267 | 2021-01-19 Luis Machado <luis.machado@linaro.org> |
| 1268 | |
| 1269 | * aarch64-linux-tdep.c (aarch64_linux_restore_vreg): Pass in an |
| 1270 | array_view. |
| 1271 | * trad-frame.c (trad_frame_set_value_bytes): Use gdb::array_view |
| 1272 | instead of buffer and size. |
| 1273 | (trad_frame_set_reg_value_bytes): Likewise. |
| 1274 | * trad-frame.h (trad_frame_set_reg_value_bytes): Likewise. |
| 1275 | (trad_frame_set_value_bytes): Likewise. |
| 1276 | |
| 1277 | 2021-01-18 Mike Frysinger <vapier@gentoo.org> |
| 1278 | |
| 1279 | * copyright.py (NOT_FSF_LIST): Delete sim/testsuite/sim/bfin/s21.s. |
| 1280 | |
| 1281 | 2021-01-18 Andrew Burgess <andrew.burgess@embecosm.com> |
| 1282 | |
| 1283 | * riscv-fbsd-tdep.c (riscv_fbsd_supply_gregset): Delete. |
| 1284 | (riscv_fbsd_gregset): Use riscv_supply_regset. |
| 1285 | (riscv_fbsd_fpregset): Likewise. |
| 1286 | * riscv-linux-tdep.c (riscv_linux_gregset): Likewise. |
| 1287 | (riscv_linux_fregset): Likewise. |
| 1288 | * riscv-tdep.c (riscv_supply_regset): Define new function. |
| 1289 | * riscv-tdep.h (riscv_supply_regset): Declare new function. |
| 1290 | |
| 1291 | 2021-01-18 Tom de Vries <tdevries@suse.de> |
| 1292 | |
| 1293 | PR tdep/27172 |
| 1294 | * nat/amd64-linux-siginfo.c (cpt_si_lower, cpt_si_upper, SEGV_BNDERR): |
| 1295 | New macro. |
| 1296 | (compat_siginfo_from_siginfo): Copy cpt_si_lower and cpt_si_upper |
| 1297 | for SEGV_BNDERR. |
| 1298 | |
| 1299 | 2021-01-18 Simon Marchi <simon.marchi@polymtl.ca> |
| 1300 | |
| 1301 | * remote.c (class remote_target) <remote_hostio_send_command, |
| 1302 | remote_hostio_parse_result>: Constify parameter. |
| 1303 | (remote_hostio_parse_result): Likewise. |
| 1304 | (remote_target::remote_hostio_send_command): Adjust. |
| 1305 | (remote_target::remote_hostio_pread_vFile): Adjust. |
| 1306 | (remote_target::fileio_readlink): Adjust. |
| 1307 | (remote_target::fileio_fstat): Adjust. |
| 1308 | |
| 1309 | 2021-01-18 Simon Marchi <simon.marchi@polymtl.ca> |
| 1310 | |
| 1311 | * remote.c (remote_target::start_remote): Move wait_status to |
| 1312 | narrower scope. |
| 1313 | |
| 1314 | 2021-01-18 Simon Marchi <simon.marchi@polymtl.ca> |
| 1315 | |
| 1316 | * remote.c (class remote_target): |
| 1317 | <add_current_inferior_and_thread>: Constify parameter. |
| 1318 | (stop_reply_extract_thread): Likewise. |
| 1319 | (remote_target::get_current_thread): Likewise. |
| 1320 | (remote_target::add_current_inferior_and_thread): Likewise. |
| 1321 | |
| 1322 | 2021-01-18 Simon Marchi <simon.marchi@polymtl.ca> |
| 1323 | |
| 1324 | * remote.c (class remote_target) |
| 1325 | <remote_unpack_thread_info_response, |
| 1326 | parse_threadlist_response>: Constify parameter and/or return |
| 1327 | value and or local variable. |
| 1328 | (stub_unpack_int): Likewise. |
| 1329 | (unpack_nibble): Likewise. |
| 1330 | (unpack_byte): Likewise. |
| 1331 | (unpack_int): Likewise. |
| 1332 | (unpack_string): Likewise. |
| 1333 | (unpack_threadid): Likewise. |
| 1334 | (remote_target::remote_unpack_thread_info_response): Likewise. |
| 1335 | (remote_target::parse_threadlist_response): Likewise. |
| 1336 | |
| 1337 | 2021-01-15 Andrew Burgess <andrew.burgess@embecosm.com> |
| 1338 | |
| 1339 | * tui/tui.c (tui_is_window_visible): Compare to nullptr, not 0. |
| 1340 | |
| 1341 | 2021-01-14 Lancelot Six <lsix@lancelotsix.com> |
| 1342 | |
| 1343 | * MAINTAINERS (Write After Approval): Add myself. |
| 1344 | |
| 1345 | 2021-01-14 Bernd Edlinger <bernd.edlinger@hotmail.de> |
| 1346 | |
| 1347 | * trad-frame.c (trad_frame_alloc_saved_regs): Avoid compile-error |
| 1348 | because is_trivially_default_constructible was first implemented with |
| 1349 | gcc-5. |
| 1350 | |
| 1351 | 2021-01-14 Tom de Vries <tdevries@suse.de> |
| 1352 | |
| 1353 | PR breakpoints/27151 |
| 1354 | * objfiles.h (in_plt_section): Handle .plt.sec. |
| 1355 | |
| 1356 | 2021-01-13 Andrew Burgess <andrew.burgess@embecosm.com> |
| 1357 | |
| 1358 | PR gdb/26819 |
| 1359 | * remote.c |
| 1360 | (remote_target::select_thread_for_ambiguous_stop_reply): New |
| 1361 | member function. |
| 1362 | (remote_target::process_stop_reply): Call |
| 1363 | select_thread_for_ambiguous_stop_reply. |
| 1364 | |
| 1365 | 2021-01-13 Simon Marchi <simon.marchi@efficios.com> |
| 1366 | |
| 1367 | * record-btrace.c (class record_btrace_target): Remove. |
| 1368 | (record_btrace_target::commit_resume): Remove. |
| 1369 | * record-full.c (class record_full_target): Remove. |
| 1370 | (record_full_target::commit_resume): Remove. |
| 1371 | |
| 1372 | 2021-01-13 Simon Marchi <simon.marchi@efficios.com> |
| 1373 | |
| 1374 | * remote.c (enum class resume_state): New. |
| 1375 | (struct resumed_pending_vcont_info): New. |
| 1376 | (struct remote_thread_info) <resume_state, set_not_resumed, |
| 1377 | set_resumed_pending_vcont, resumed_pending_vcont_info, |
| 1378 | set_resumed, m_resume_state, m_resumed_pending_vcont_info>: |
| 1379 | New. |
| 1380 | <last_resume_step, last_resume_sig, vcont_resumed>: Remove. |
| 1381 | (remote_target::remote_add_thread): Adjust. |
| 1382 | (remote_target::process_initial_stop_replies): Adjust. |
| 1383 | (remote_target::resume): Adjust. |
| 1384 | (remote_target::commit_resume): Rely on state in |
| 1385 | remote_thread_info and not on tp->executing. |
| 1386 | (remote_target::process_stop_reply): Adjust. |
| 1387 | |
| 1388 | 2021-01-13 Simon Marchi <simon.marchi@polymtl.ca> |
| 1389 | |
| 1390 | * arc-tdep.h (arc_debug_printf): New. |
| 1391 | * arc-tdep.c: Use arc_debug_printf. |
| 1392 | * arc-linux-nat.c (arc_linux_nat_debug_printf): Add and use. |
| 1393 | * arc-linux-tdep.c (arc_linux_debug_printf): Add and use. |
| 1394 | * arc-newlib-tdep.c (arc_newlib_debug_printf): Add and use. |
| 1395 | |
| 1396 | 2021-01-13 Simon Marchi <simon.marchi@polymtl.ca> |
| 1397 | |
| 1398 | * arc-tdep.h (arc_debug): Change type to bool. |
| 1399 | * arc-tdep.c (arc_debug): Change type to bool. |
| 1400 | (arc_analyze_prologue): Adjust. |
| 1401 | (_initialize_arc_tdep): Use add_setshow_boolean_cmd. |
| 1402 | * arc-linux-nat.c (ps_get_thread_area): Adjust. |
| 1403 | |
| 1404 | 2021-01-13 Simon Marchi <simon.marchi@polymtl.ca> |
| 1405 | |
| 1406 | * auto-load.c (auto_load_objfile_script_1): Use bool. |
| 1407 | (execute_script_contents): Use bool. |
| 1408 | |
| 1409 | 2021-01-13 Simon Marchi <simon.marchi@polymtl.ca> |
| 1410 | |
| 1411 | * auto-load.h (auto_load_gdb_scripts_enabled): Return bool, move |
| 1412 | comment here. |
| 1413 | * auto-load.c (auto_load_gdb_scripts_enabled): Return bool, move |
| 1414 | comment to header. |
| 1415 | * extension-priv.h (struct extension_language_script_ops) |
| 1416 | <auto_load_enabled>: Return bool. |
| 1417 | * extension.h (ext_lang_auto_load_enabled): Return bool, move |
| 1418 | comment here. |
| 1419 | * extension.c (ext_lang_auto_load_enabled): Return bool, move |
| 1420 | comment to header. |
| 1421 | * guile/guile-header.h (gdbscm_auto_load_enabled): Return bool, |
| 1422 | move comment here. |
| 1423 | * guile/scm-auto-load.c (gdbscm_auto_load_enabled): Return bool, |
| 1424 | move comment to header. |
| 1425 | * python/python-header.h (gdbpy_auto_load_enabled): Return bool, |
| 1426 | move comment here. |
| 1427 | * python/py-auto-load.c (gdbpy_auto_load_enabled): Return bool, |
| 1428 | move comment to header. |
| 1429 | |
| 1430 | 2021-01-13 Simon Marchi <simon.marchi@polymtl.ca> |
| 1431 | |
| 1432 | * auto-load.h (file_is_auto_load_safe): Change return type to |
| 1433 | bool, move comment here. |
| 1434 | * auto-load.c (file_is_auto_load_safe): Change return type and |
| 1435 | advice_printed to bool. Move comment to header. |
| 1436 | |
| 1437 | 2021-01-13 Simon Marchi <simon.marchi@polymtl.ca> |
| 1438 | |
| 1439 | * jit.c (jit_debug_printf): New, use throughout file. |
| 1440 | |
| 1441 | 2021-01-12 Simon Marchi <simon.marchi@polymtl.ca> |
| 1442 | |
| 1443 | * infrun.c (normal_stop): Fix indentation. |
| 1444 | |
| 1445 | 2021-01-12 Simon Marchi <simon.marchi@polymtl.ca> |
| 1446 | |
| 1447 | * top.h (readnow_symbol_files, readnever_symbol_files): Move |
| 1448 | declarations to ... |
| 1449 | * symfile.h: ... here. |
| 1450 | * symfile.c: Update doc. |
| 1451 | |
| 1452 | 2021-01-12 Simon Marchi <simon.marchi@polymtl.ca> |
| 1453 | |
| 1454 | * target.h (baud_rate, serial_parity): Move declarations... |
| 1455 | * serial.h: ... here. |
| 1456 | * main.c: Include serial.h. |
| 1457 | * serial.c (baud_rate, serial_parity): Update doc. |
| 1458 | |
| 1459 | 2021-01-12 Simon Marchi <simon.marchi@polymtl.ca> |
| 1460 | |
| 1461 | * top.c (pre_init_ui_hook): Remove. |
| 1462 | |
| 1463 | 2021-01-12 Srinath Parvathaneni <srinath.parvathaneni@arm.com> |
| 1464 | |
| 1465 | * aarch64-tdep.c (aarch64_vnh_type): Add "bf" field in h registers. |
| 1466 | (aarch64_vnv_type): Add "bf" type in h field of v registers. |
| 1467 | * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerated. |
| 1468 | * features/aarch64-fpu.xml: Add bfloat16 type. |
| 1469 | |
| 1470 | 2021-01-12 Andrew Burgess <andrew.burgess@embecosm.com> |
| 1471 | |
| 1472 | * expprint.c (dump_subexp_body_standard): Handle OP_BOOL. |
| 1473 | |
| 1474 | 2021-01-12 Andrew Burgess <andrew.burgess@embecosm.com> |
| 1475 | |
| 1476 | * f-exp.y (dot_ops): Rename to... |
| 1477 | (fortran_operators): ...this. Add a header comment. Add symbol |
| 1478 | based operators. |
| 1479 | (yylex): Update to use fortran_operators not dot_ops. Remove |
| 1480 | special handling for '**', this is now included in |
| 1481 | fortran_operators. |
| 1482 | |
| 1483 | 2021-01-11 Simon Marchi <simon.marchi@polymtl.ca> |
| 1484 | |
| 1485 | * arch/aarch64-insn.h (aarch64_debug_printf): New. |
| 1486 | * arch/aarch64-insn.c: Use aarch64_debug_printf. |
| 1487 | * aarch64-tdep.c: Use aarch64_debug_printf. |
| 1488 | |
| 1489 | 2021-01-11 Simon Marchi <simon.marchi@polymtl.ca> |
| 1490 | |
| 1491 | * solib-aix.c (solib_aix_debug_printf): New, use throughout |
| 1492 | file. |
| 1493 | |
| 1494 | 2021-01-11 Simon Marchi <simon.marchi@polymtl.ca> |
| 1495 | |
| 1496 | * jit.c (jit_debug): Change type to bool. |
| 1497 | (_initialize_jit): Adjust. |
| 1498 | |
| 1499 | 2021-01-09 Tom Tromey <tom@tromey.com> |
| 1500 | |
| 1501 | PR compile/23672 |
| 1502 | * compile/compile.c (compile_to_object): Avoid crash when |
| 1503 | osabi_triplet_regexp returns NULL. |
| 1504 | |
| 1505 | 2021-01-09 Tom Tromey <tom@tromey.com> |
| 1506 | |
| 1507 | * tracepoint.h (class collection_list) <append_exp>: Take a |
| 1508 | std::string. |
| 1509 | * tracepoint.c (collection_list::append_exp): Take a std::string. |
| 1510 | (encode_actions_1): Update. |
| 1511 | |
| 1512 | 2021-01-08 Tom Tromey <tromey@adacore.com> |
| 1513 | |
| 1514 | * parse.c (parse_expression): Add void_context_p parameter. Use |
| 1515 | parse_exp_in_context. |
| 1516 | * printcmd.c (print_command_1): Change voidprint to bool. Pass to |
| 1517 | parse_expression. |
| 1518 | (print_command, call_command): Update. |
| 1519 | * expression.h (parse_expression): Add void_context_p parameter. |
| 1520 | |
| 1521 | 2021-01-08 Andrew Burgess <andrew.burgess@embecosm.com> |
| 1522 | |
| 1523 | * value.c (set_value_component_location): Adjust the VALUE_LVAL |
| 1524 | for internalvar components that have a dynamic location. |
| 1525 | |
| 1526 | 2021-01-08 Tom de Vries <tdevries@suse.de> |
| 1527 | |
| 1528 | PR gdb/26881 |
| 1529 | * breakpoint.c (create_exception_master_breakpoint_probe) |
| 1530 | (create_exception_master_breakpoint_hook): Factor out |
| 1531 | of ... |
| 1532 | (create_exception_master_breakpoint): ... here. Only try to install |
| 1533 | the master exception breakpoint in objfile.debug using the |
| 1534 | _Unwind_DebugHook method, if the install using probes in objfile |
| 1535 | failed. |
| 1536 | |
| 1537 | 2021-01-08 Andrew Burgess <andrew.burgess@embecosm.com> |
| 1538 | |
| 1539 | * f-lang.c (fortran_value_subarray): Call value_from_component. |
| 1540 | |
| 1541 | 2021-01-07 Mike Frysinger <vapier@gentoo.org> |
| 1542 | |
| 1543 | * remote-sim.c: Include memory-map.h. |
| 1544 | (gdbsim_target): Define memory_map override. |
| 1545 | (gdbsim_target::memory_map): Define. |
| 1546 | |
| 1547 | 2021-01-07 Tom Tromey <tromey@adacore.com> |
| 1548 | |
| 1549 | * ada-lang.c (do_full_match): Conditionally skip "_ada_" prefix. |
| 1550 | |
| 1551 | 2021-01-07 Tom Tromey <tromey@adacore.com> |
| 1552 | |
| 1553 | * ada-lang.c (add_component_interval): Start loop using vector's |
| 1554 | updated size. |
| 1555 | |
| 1556 | 2021-01-06 Tom Tromey <tromey@adacore.com> |
| 1557 | |
| 1558 | * ada-lang.c (ada_evaluate_subexp) <BINOP_ADD, BINOP_SUB>: |
| 1559 | Do not cast result. |
| 1560 | * valarith.c (fixed_point_binop): Handle multiplication |
| 1561 | and division specially. |
| 1562 | * valops.c (value_to_gdb_mpq): New function. |
| 1563 | (value_cast_to_fixed_point): Use it. |
| 1564 | |
| 1565 | 2021-01-05 Hannes Domani <ssbssa@yahoo.de> |
| 1566 | |
| 1567 | * tui/tui-winsource.c (tui_source_window_base::refresh_window): |
| 1568 | Call wnoutrefresh instead of tui_win_info::refresh_window. |
| 1569 | |
| 1570 | 2021-01-05 Hannes Domani <ssbssa@yahoo.de> |
| 1571 | |
| 1572 | * tui/tui-source.c (tui_source_window::show_line_number): |
| 1573 | Redraw second space after line number. |
| 1574 | |
| 1575 | 2021-01-05 Hannes Domani <ssbssa@yahoo.de> |
| 1576 | |
| 1577 | PR tui/26927 |
| 1578 | * tui/tui-winsource.c (tui_source_window_base::refresh_window): |
| 1579 | Fix source pad size in prefresh. |
| 1580 | (tui_source_window_base::show_source_content): Grow source pad |
| 1581 | if necessary. |
| 1582 | |
| 1583 | 2021-01-04 Mike Frysinger <vapier@gentoo.org> |
| 1584 | |
| 1585 | * bfin-tdep.c (bfin_push_dummy_call): Use align_up. |
| 1586 | (bfin_frame_align): Use align_down. |
| 1587 | |
| 1588 | 2021-01-04 Tom de Vries <tdevries@suse.de> |
| 1589 | |
| 1590 | * buildsym.c (buildsym_compunit::record_line): Filter out end-of-seq |
| 1591 | terminators that do not terminate anything. |
| 1592 | |
| 1593 | 2021-01-04 Simon Marchi <simon.marchi@efficios.com> |
| 1594 | |
| 1595 | * debug.c (debug_print_depth): New. |
| 1596 | * infrun.h (INFRUN_SCOPED_DEBUG_START_END): New. |
| 1597 | (INFRUN_SCOPED_DEBUG_ENTER_EXIT): New. |
| 1598 | * infrun.c (start_step_over): Use |
| 1599 | INFRUN_SCOPED_DEBUG_ENTER_EXIT. |
| 1600 | (proceed): Use INFRUN_SCOPED_DEBUG_ENTER_EXIT and |
| 1601 | INFRUN_SCOPED_DEBUG_START_END. |
| 1602 | (fetch_inferior_event): Use INFRUN_SCOPED_DEBUG_ENTER_EXIT. |
| 1603 | |
| 1604 | 2021-01-04 Simon Marchi <simon.marchi@efficios.com> |
| 1605 | |
| 1606 | * infrun.c (print_target_wait_results): Use infrun_debug_printf. |
| 1607 | |
| 1608 | 2021-01-04 Simon Marchi <simon.marchi@efficios.com> |
| 1609 | |
| 1610 | * utils.c (vfprintf_unfiltered): Print timestamp only when |
| 1611 | previous debug output ended with a newline. |
| 1612 | |
| 1613 | 2021-01-04 Luis Machado <luis.machado@linaro.org> |
| 1614 | |
| 1615 | Update all users of trad_frame_saved_reg to use the new member |
| 1616 | functions. |
| 1617 | |
| 1618 | Remote all struct keywords from declarations of trad_frame_saved_reg |
| 1619 | types, except on forward declarations. |
| 1620 | |
| 1621 | * aarch64-tdep.c: Update. |
| 1622 | * alpha-mdebug-tdep.c: Update. |
| 1623 | * alpha-tdep.c: Update. |
| 1624 | * arc-tdep.c: Update. |
| 1625 | * arm-tdep.c: Update. |
| 1626 | * avr-tdep.c: Update. |
| 1627 | * cris-tdep.c: Update. |
| 1628 | * csky-tdep.c: Update. |
| 1629 | * frv-tdep.c: Update. |
| 1630 | * hppa-linux-tdep.c: Update. |
| 1631 | * hppa-tdep.c: Update. |
| 1632 | * hppa-tdep.h: Update. |
| 1633 | * lm32-tdep.c: Update. |
| 1634 | * m32r-linux-tdep.c: Update. |
| 1635 | * m32r-tdep.c: Update. |
| 1636 | * m68hc11-tdep.c: Update. |
| 1637 | * mips-tdep.c: Update. |
| 1638 | * moxie-tdep.c: Update. |
| 1639 | * riscv-tdep.c: Update. |
| 1640 | * rs6000-tdep.c: Update. |
| 1641 | * s390-linux-tdep.c: Update. |
| 1642 | * s390-tdep.c: Update. |
| 1643 | * score-tdep.c: Update. |
| 1644 | * sparc-netbsd-tdep.c: Update. |
| 1645 | * sparc-sol2-tdep.c: Update. |
| 1646 | * sparc64-fbsd-tdep.c: Update. |
| 1647 | * sparc64-netbsd-tdep.c: Update. |
| 1648 | * sparc64-obsd-tdep.c: Update. |
| 1649 | * sparc64-sol2-tdep.c: Update. |
| 1650 | * tilegx-tdep.c: Update. |
| 1651 | * v850-tdep.c: Update. |
| 1652 | * vax-tdep.c: Update. |
| 1653 | |
| 1654 | * frame-unwind.c (frame_unwind_got_bytes): Make parameter const. |
| 1655 | * frame-unwind.h (frame_unwind_got_bytes): Likewise. |
| 1656 | |
| 1657 | * trad-frame.c: Update. |
| 1658 | Remove TF_REG_* enum. |
| 1659 | (trad_frame_alloc_saved_regs): Add a static assertion to check for |
| 1660 | a trivially-constructible struct. |
| 1661 | (trad_frame_reset_saved_regs): Adjust to use member function. |
| 1662 | (trad_frame_value_p): Likewise. |
| 1663 | (trad_frame_addr_p): Likewise. |
| 1664 | (trad_frame_realreg_p): Likewise. |
| 1665 | (trad_frame_value_bytes_p): Likewise. |
| 1666 | (trad_frame_set_value): Likewise. |
| 1667 | (trad_frame_set_realreg): Likewise. |
| 1668 | (trad_frame_set_addr): Likewise. |
| 1669 | (trad_frame_set_unknown): Likewise. |
| 1670 | (trad_frame_set_value_bytes): Likewise. |
| 1671 | (trad_frame_get_prev_register): Likewise. |
| 1672 | * trad-frame.h: Update. |
| 1673 | (trad_frame_saved_reg_kind): New enum. |
| 1674 | (struct trad_frame_saved_reg) <addr, realreg, data>: Remove. |
| 1675 | <m_kind, m_reg>: New member fields. |
| 1676 | <set_value, set_realreg, set_addr, set_unknown, set_value_bytes> |
| 1677 | <kind, value, realreg, addr, value_bytes, is_value, is_realreg> |
| 1678 | <is_addr, is_unknown, is_value_bytes>: New member functions. |
| 1679 | |
| 1680 | 2021-01-02 Simon Marchi <simon.marchi@polymtl.ca> |
| 1681 | |
| 1682 | * target-float.c: Fix typos. |
| 1683 | |
| 1684 | 2021-01-02 Hannes Domani <ssbssa@yahoo.de> |
| 1685 | |
| 1686 | * gdb-gdb.py.in: Fix main_type.flds_bnds.bounds pretty printer. |
| 1687 | |
| 1688 | 2021-01-01 Joel Brobecker <brobecker@adacore.com> |
| 1689 | |
| 1690 | * gdbarch.sh: Update copyright year range. |
| 1691 | |
| 1692 | 2021-01-01 Joel Brobecker <brobecker@adacore.com> |
| 1693 | |
| 1694 | Update copyright year range in copyright header of all GDB files. |
| 1695 | |
| 1696 | 2021-01-01 Joel Brobecker <brobecker@adacore.com> |
| 1697 | |
| 1698 | * copyright.py (get_update_list): Add "gdbserver" and "gdbsupport" |
| 1699 | to the list of directories to update. |
| 1700 | |
| 1701 | 2021-01-01 Joel Brobecker <brobecker@adacore.com> |
| 1702 | |
| 1703 | * top.c (print_gdb_version): Update copyright year. |
| 1704 | |
| 1705 | 2021-01-01 Joel Brobecker <brobecker@adacore.com> |
| 1706 | |
| 1707 | * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2020. |
| 1708 | |
| 1709 | For older changes see ChangeLog-2020. |
| 1710 | \f |
| 1711 | Local Variables: |
| 1712 | mode: change-log |
| 1713 | left-margin: 8 |
| 1714 | fill-column: 74 |
| 1715 | version-control: never |
| 1716 | coding: utf-8 |
| 1717 | End: |