Fix the thread-pool.c compilation
[deliverable/binutils-gdb.git] / gdb / ChangeLog
... / ...
CommitLineData
12019-12-12 Tom Tromey <tromey@adacore.com>
2
3 * gdbsupport/thread-pool.c (set_thread_name): Use
4 ATTRIBUTE_UNUSED.
5
62019-12-12 Luis Machado <luis.machado@linaro.org>
7
8 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
9 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
10 macros.
11
122019-12-11 Tom Tromey <tom@tromey.com>
13
14 * tui/tui-win.c (tui_set_win_height_command): Call
15 tui_adjust_window_height.
16 (tui_adjust_win_heights, new_height_ok): Remove.
17 * tui/tui-layout.h (tui_adjust_window_height): Declare.
18 * tui/tui-layout.c (tui_adjust_window_height): New function.
19
202019-12-11 Tom Tromey <tom@tromey.com>
21
22 * tui/tui-win.c (tui_resize_all): Remove code, call
23 tui_apply_current_layout.
24
252019-12-11 Tom Tromey <tom@tromey.com>
26
27 * tui/tui-layout.h (tui_apply_current_layout): Declare.
28 * tui/tui-layout.c (standard_layouts, applied_layout): New
29 globals.
30 (tui_apply_current_layout): New function.
31 (show_layout): Set applied_layout. Call
32 tui_apply_current_layout.
33 (show_source_command, show_disasm_command)
34 (show_source_disasm_command, show_data)
35 (show_source_or_disasm_and_command): Remove.
36 (initialize_layouts): New function.
37 (_initialize_tui_layout): Call initialize_layouts.
38
392019-12-11 Tom Tromey <tom@tromey.com>
40
41 * tui/tui-layout.h (class tui_layout_base)
42 (class tui_layout_window, class tui_layout_split): New.
43 * tui/tui-layout.c (tui_get_window_by_name)
44 (tui_layout_window::clone, tui_layout_window::apply)
45 (tui_layout_window::get_sizes, tui_layout_window::add_split)
46 (tui_layout_split::add_window, tui_layout_split::clone)
47 (tui_layout_split::get_sizes)
48 (tui_layout_split::set_weights_from_heights)
49 (tui_layout_split::adjust_size, tui_layout_split::apply): New
50 functions.
51 (tui_layout_split::add_split, tui_layout_split::add_split)
52 (tui_layout_split::set_weights_from_heights)
53 (tui_layout_split::set_weights_from_heights): New functions.
54
552019-12-11 Tom Tromey <tom@tromey.com>
56
57 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
58 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
59 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
60 * tui/tui-data.h (struct tui_point): Remove.
61 (struct tui_gen_win_info) <origin>: Remove.
62 <x, y>: New fields.
63 * tui/tui-command.c (tui_cmd_window::resize): Update.
64
652019-12-11 Tom Tromey <tom@tromey.com>
66
67 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
68 Implement.
69 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
70 Implement.
71 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
72 method.
73 (struct tui_win_info) <min_height>: Implement.
74
752019-12-11 Tom Tromey <tom@tromey.com>
76
77 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
78 (struct tui_win_info) <can_box>: Update.
79
802019-12-11 Tom Tromey <tom@tromey.com>
81
82 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
83 method.
84 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
85 method.
86 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
87 method.
88 (struct tui_win_info) <max_height>: Now override.
89
902019-12-11 Joel Brobecker <brobecker@adacore.com>
91
92 * NEWS: Create a new section for the next release branch.
93 Rename the section of the current branch, now that it has
94 been cut.
95
962019-12-11 Joel Brobecker <brobecker@adacore.com>
97
98 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
99 * version.in: Bump version to 10.0.50.DATE-git.
100
1012019-12-11 Tom Tromey <tromey@adacore.com>
102
103 PR build/25268:
104 * gdbsupport/thread-pool.c (set_thread_name): New function.
105 (thread_pool::set_thread_count): Don't call pthread_setname_np.
106 (thread_pool::thread_function): Call set_thread_name.
107
1082019-12-11 Tom Tromey <tromey@adacore.com>
109
110 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
111 bfd_get_signed_8.
112
1132019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
114
115 * NEWS: Document -raw-values option and the related setting commands.
116 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
117 only set it on when /r is given.
118 * valprint.c (value_print_option_defs): New element raw-values.
119 * Makefile.in: Add the new file.
120
1212019-12-10 Christian Biesinger <cbiesinger@google.com>
122
123 * gdbsupport/safe-strerror.c: Supress the unused function warning
124 for select_strerror_r.
125
1262019-12-10 Christian Biesinger <cbiesinger@google.com>
127
128 * config.in: Regenerate.
129 * configure: Regenerate.
130 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
131 safe_strerror instead of strerror.
132 * gdbsupport/common.m4: Don't check for strerror.
133 * gdbsupport/safe-strerror.c: Support both the glibc version
134 of strerror_r and the XSI version.
135
1362019-12-10 Tom Tromey <tromey@adacore.com>
137
138 * ada-typeprint.c (print_choices): Use a single "?".
139 (print_variant_part): Print "?" if the discriminant name
140 is not known.
141
1422019-12-10 George Barrett <bob@bob131.so>
143
144 Fix scripted probe breakpoints.
145 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
146 declaration forward.
147 (breakpoint_ops_for_event_location_type)
148 (breakpoint_ops_for_event_location): Add function definitions.
149 (break_command_1, trace_command): Use
150 breakpoint_ops_for_event_location.
151 * breakpoint.h (breakpoint_ops_for_event_location): Add function
152 declarations.
153 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
154 breakpoint_ops_for_event_location.
155 * python/py-breakpoint.c (bppy_init): Use
156 breakpoint_ops_for_event_location.
157
1582019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
159
160 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
161 when ranking an lvalue argument for an rvalue parameter.
162
1632019-12-08 Wataru Ashihara <wataash@wataash.com>
164
165 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
166 template argument for scoped_restore_tmpl from bool to int.
167
1682019-12-07 Keith Seitz <keiths@redhat.com>
169
170 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
171 (build_id_to_debug_bfd): Make static, rewriting to use
172 build_id_to_bfd_suffix.
173 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
174 adding `suffix' parameter. Append SUFFIX to file names
175 when searching for matching files.
176 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
177 (build_id_to_exec_bfd): Likewise.
178 * build-id.h (build_id_to_debug_bfd): Clarify that function
179 searches for BFD of debug info file.
180 (build_id_to_exec_bfd): Declare.
181 * corelow.c: Include build-id.h.
182 (locate_exec_from_corefile_build_id): New function.
183 (core_target_open): If no executable BFD is found,
184 search for a core file BFD using build-id.
185
1862019-12-06 Christian Biesinger <cbiesinger@google.com>
187
188 * bcache.c: Put in namespace gdb.
189 * bcache.h: Likewise.
190 * gdbtypes.c (check_types_worklist): Update.
191 (types_deeply_equal): Update.
192 * macrotab.c (struct macro_table) <bcache>: Update.
193 (new_macro_table): Update.
194 * macrotab.h (struct bcache): Put this forward declaration
195 inside namespace gdb.
196 (new_macro_table): Update.
197 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
198 Update.
199 <macro_cache>: Update.
200 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
201
2022019-12-06 Tom de Vries <tdevries@suse.de>
203
204 PR symtab/24971
205 * block.c (best_symbol, better_symbol): New function.
206 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
207 decl.
208
2092019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
210
211 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
212 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
213 for ranking see-through reference cases.
214
2152019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
216 * stack.c (faas_command): Check a command is provided.
217 * thread.c (taas_command, tfaas_command): Likewise.
218
2192019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
220 * inferior.c (prune_inferiors): Only call delete_inferior,
221 Do not modify the inferior list.
222
2232019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
224
225 * c-exp.y: Update calls to lookup_typename,
226 lookup_signed_typename and lookup_unsigned_typename.
227 * c-lang.c (evaluate_subexp_c): Likewise.
228 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
229 Likewise.
230 * eval.c (binop_promote): Likewise.
231 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
232 (lookup_unsigned_typename): Likewise.
233 (lookup_signed_typename): Likewise.
234 * gdbtypes.h (lookup_unsigned_typename): Likewise.
235 (lookup_signed_typename): Likewise.
236 (lookup_typename): Likewise.
237 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
238 lookup_typename, lookup_signed_typename,
239 lookup_unsigned_typename.
240 * m2-exp.y: Likewise.
241 * printcmd.c (printf_wide_c_string): Likewise.
242 (ui_printf): Likewise.
243 * python/py-type.c (typy_lookup_typename): Likewise.
244 * python/py-xmethods.c (python_xmethod_worker::invoke):
245 Likewise.
246 * rust-exp.y: Likewise.
247
2482019-12-04 Christian Biesinger <cbiesinger@google.com>
249
250 * configure.nat (obsd64): Add missing files x86-nat.o and
251 nat/x86-dregs.o.
252
2532019-12-04 Tom Tromey <tom@tromey.com>
254
255 * valprint.c (val_print_string): Use metadata_style.
256 * go-valprint.c (print_go_string): Use metadata style.
257 * p-valprint.c (pascal_object_print_static_field): Use metadata
258 style.
259 * cp-valprint.c (cp_print_static_field): Use metadata style.
260
2612019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
262 Chris January <chris.january@arm.com>
263
264 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
265 tokens.
266 (typebase): New patterns for complex, single/double precision, and
267 single/double complex.
268 (f77_keywords): Change token for complex keyword, and add single,
269 double, and precision keywords.
270
2712019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
272
273 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
274 "info io_registers".
275
2762019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
277
278 * regcache.c (cooked_read_test): Initialize thread list of
279 mock_inferior.
280
2812019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
282
283 * aarch64-linux-tdep.c: Remove includes.
284
2852019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
286
287 * aarch64-tdep.c: Remove includes.
288
2892019-12-04 Simon Marchi <simon.marchi@efficios.com>
290
291 * filtered-iterator.h (filtered_iterator) <operator==,
292 operator!=>: Compare wrapped iterators, not wrapped pointers.
293 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
294 unittests/filtered_iterator-selftests.c.
295 * unittests/filtered_iterator-selftests.c: New file.
296
2972019-12-04 Tom Tromey <tromey@adacore.com>
298
299 * gdbtypes.c (create_range_type): Inherit endianity
300 from base type.
301
3022019-12-04 Tom Tromey <tromey@adacore.com>
303
304 * ada-lang.c (decode_constrained_packed_array)
305 (ada_value_assign, value_assign_to_component): Update.
306 * dwarf2loc.c (rw_pieced_value, access_memory)
307 (dwarf2_compile_expr_to_ax): Update.
308 * dwarf2read.c (dwarf2_add_field): Update.
309 * eval.c (evaluate_subexp_standard): Update.
310 * gdbarch.c, gdbarch.h: Rebuild.
311 * gdbarch.sh (bits_big_endian): Remove.
312 * gdbtypes.h (union field_location): Update comment.
313 * target-descriptions.c (make_gdb_type): Update.
314 * valarith.c (value_bit_index): Update.
315 * value.c (struct value) <bitpos>: Update comment.
316 (unpack_bits_as_long, modify_field): Update.
317 * value.h (value_bitpos): Update comment.
318
3192019-12-04 Tom Tromey <tromey@adacore.com>
320
321 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
322 endian-ness.
323
3242019-12-04 Tom Tromey <tromey@adacore.com>
325
326 * dwarf2read.c (dwarf2_init_float_type)
327 (dwarf2_init_complex_target_type): Add byte_order parameter.
328 (read_base_type): Compute byte order earlier.
329 * gdbtypes.c (init_float_type): Add byte_order parameter.
330 * gdbtypes.h (init_float_type): Add byte_order parameter.
331
3322019-12-04 Tom Tromey <tromey@adacore.com>
333
334 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
335
3362019-12-04 Tom Tromey <tromey@adacore.com>
337
338 * dwarf2read.c (process_structure_scope): Initialize
339 "discr_offset".
340
3412019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
342
343 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
344 add it into the search spec.
345 (parse_max_results_option): New function.
346 (mi_info_functions_or_variables): Parse -max-results flag and pass
347 it to mi_symbol_info.
348 (mi_cmd_symbol_info_modules): Likewise.
349 (mi_cmd_symbol_info_types): Likewise.
350 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
351 return type to bool, change result container into a set, and don't
352 add new results if we have enough already.
353 (global_symbol_searcher::add_matching_msymbols): Change return
354 type to bool, and don't add new results if we have enough already.
355 (sort_search_symbols_remove_dups): Delete.
356 (global_symbol_searcher::search): Early exit from search loop when
357 we have enough results. Use a std::set to collect the results
358 from calling add_matching_symbols.
359 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
360 member function.
361 (global_symbol_searcher) <m_max_search_results>: New member
362 variable.
363 (global_symbol_searcher) <add_matching_symbols>: Update header
364 comment and change return type to bool.
365 (global_symbol_searcher) <add_matching_msymbols>: Update header
366 comment and change return type to bool.
367
3682019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
369
370 * symtab.c (symbol_search::compare_search_syms): Update header
371 comment.
372 (global_symbol_searcher::is_suitable_msymbol): New function.
373 (global_symbol_searcher::expand_symtabs): New function.
374 (global_symbol_searcher::add_matching_symbols): New function.
375 (global_symbol_searcher::add_matching_msymbols): New function.
376 (global_symbol_searcher::search): Move most of the content
377 into the new functions above, and call them as needed.
378 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
379 function.
380 (global_symbol_searcher) <add_matching_symbols>: New member
381 function.
382 (global_symbol_searcher) <add_matching_msymbols>: New member
383 function.
384 (global_symbol_searcher) <is_suitable_msymbol>: New member
385 function.
386
3872019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
388
389 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
390 -symbol-info-module-variables entries.
391 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
392 (mi_cmd_symbol_info_module_variables): Declare.
393 * mi/mi-symbol-cmds.c
394 (module_symbol_search_iterator): New typedef.
395 (output_module_symbols_in_single_module_and_file): New function.
396 (output_module_symbols_in_single_module): New function.
397 (mi_info_module_functions_or_variables): New function.
398 (mi_cmd_symbol_info_module_functions): New function.
399 (mi_cmd_symbol_info_module_variables): New function.
400 * NEWS: Mention new MI command.
401
4022019-12-03 Christian Biesinger <cbiesinger@google.com>
403
404 * bcache.c (hash): Remove.
405 (hash_continue): Remove.
406 * bcache.h (hash): Remove.
407 (hash_continue): Remove.
408 (struct bcache) <ctor>: Update.
409 * psymtab.c (psymbol_hash): Update.
410 * stabsread.c (hashname): Update.
411 * utils.h (fast_hash): Add an argument for a start value,
412 defaulting to zero.
413
4142019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
415 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
416 (destroy_block_symbol_cache): New function.
417 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
418 (resize_symbol_cache): Likewise.
419
4202019-12-02 Tom Tromey <tom@tromey.com>
421
422 * unittests/tui-selftests.c (run_tests): Make conditional.
423 (_initialize_tui_selftest): Make conditional.
424
4252019-12-02 Christian Biesinger <cbiesinger@google.com>
426
427 * aix-thread.c (debug_aix_thread): Change type to bool.
428
4292019-12-02 Luis Machado <luis.machado@linaro.org>
430
431 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
432
4332019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
434
435 * dwarf2read.c (read_tag_string_type): Read the fields required to
436 make a dynamic string, and possibly create a dynamic range for the
437 string.
438 (attr_to_dynamic_prop): Setup is_reference based on the type of
439 attribute being processed.
440 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
441 (resolve_dynamic_array): Rename to...
442 (resolve_dynamic_array_or_string): ...this, update header comment,
443 and accept TYPE_CODE_STRING.
444 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
445
4462019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
447
448 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
449 of its implementation from...
450 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
451 the new function.
452
4532019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
454
455 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
456 create a range with stride where appropriate.
457 * f-valprint.c: Include 'gdbarch.h'.
458 (f77_print_array_1): Take the stride into account when walking the
459 array. Also convert the stride into addressable units.
460 * gdbtypes.c (create_range_type): Initialise the stride to
461 constant zero.
462 (create_range_type_with_stride): New function, initialise the
463 range as normal, and then setup the stride.
464 (has_static_range): Include the stride here. Also change the
465 return type to bool.
466 (create_array_type_with_stride): Consider the range stride if the
467 array isn't given its own stride.
468 (resolve_dynamic_range): Resolve the stride if needed.
469 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
470 (struct range_bounds) <flag_is_byte_stride>: New member variable.
471 (TYPE_BIT_STRIDE): Define.
472 (TYPE_ARRAY_BIT_STRIDE): Define.
473 (create_range_type_with_stride): Declare.
474 * valarith.c (value_subscripted_rvalue): Take range stride into
475 account when walking the array.
476
4772019-12-01 Tom Tromey <tom@tromey.com>
478
479 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
480 specially.
481
4822019-12-01 Tom Tromey <tom@tromey.com>
483
484 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
485 \0.
486 * unittests/tui-selftests.c: New file.
487 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
488
4892019-12-01 Tom Tromey <tom@tromey.com>
490
491 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
492
4932019-12-01 Tom Tromey <tom@tromey.com>
494
495 * NEWS: Document new settings.
496 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
497 * tui/tui-win.c (_initialize_tui_win): Add border style
498 observers.
499 * tui/tui-io.h (tui_apply_style): Declare.
500 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
501 longer static.
502 (apply_ansi_escape, tui_set_reverse_mode): Update.
503 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
504 Add "skip_intensity" parameter.
505 <changed>: New member.
506 <do_set_value>: Declare.
507 (tui_border_style, tui_active_border_style): Declare.
508 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
509 globals.
510 (cli_style_option): Initialize "changed".
511 (cli_style_option::do_set_value): New function.
512 (cli_style_option::add_setshow_commands): Add "skip_intensity"
513 parameter. Update.
514 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
515 (_initialize_cli_style): Update. Create TUI border style
516 commands.
517
5182019-12-01 Tom Tromey <tom@tromey.com>
519
520 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
521 parameter.
522 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
523 parameter.
524 * tui/tui-win.h (compact_source): Declare.
525 * tui/tui-win.c (compact_source): New global.
526 (tui_set_compact_source, tui_show_compact_source): New functions.
527 (_initialize_tui_win): Add "compact-source" setting.
528 * tui/tui-source.c (tui_source_window::set_contents): Handle
529 compact_source setting.
530 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
531 * NEWS: Document new setting.
532
5332019-11-30 Tom Tromey <tom@tromey.com>
534
535 * dwarf2read.c (dwarf2_add_field): Include field offset when
536 computing variant part length.
537
5382019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
539 * NEWS: Mention define-prefix. Tell that command names can now
540 contain a . character.
541
5422019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
543
544 * command.h (valid_cmd_char_p): Declare.
545 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
546 the check of valid command char.
547 (find_command_name_length, valid_user_defined_cmd_name_p): Use
548 valid_cmd_char_p.
549 * cli/cli-script.c (validate_comname): Likewise.
550 * completer.c (gdb_completer_command_word_break_characters):
551 Do not remove . from the word break char, update comments.
552 (complete_line_internal_1): Use valid_cmd_char_p.
553 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
554 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
555
5562019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
557
558 * cli/cli-script.c (do_define_command): Ensure a redefined
559 prefix command is kept as a prefix command.
560 (define_prefix_command): New function.
561 (show_user_1): Report user defined prefixes.
562 (_initialize_cli_script): Create the new 'define-prefix' command.
563 Add completers for 'define' and 'document'.
564 * top.c (execute_command): If command is a user-defined prefix only
565 command, report the list of commands for this prefix command.
566
5672019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
568
569 * valops.c (find_oload_champ): Improve debug output.
570
5712019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
572
573 * valops.c (find_oload_champ): Print part of debug messages
574 before the badness vector is std::move'd.
575
5762019-11-28 Tom Tromey <tom@tromey.com>
577
578 * value.c (creal_internal_fn): Fix comment.
579
5802019-11-28 Tom Tromey <tom@tromey.com>
581
582 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
583 flag_bound_evaluated>: Now unsigned.
584
5852019-11-28 Tom Tromey <tom@tromey.com>
586
587 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
588 declare.
589
5902019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
591
592 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
593 debug output.
594 * jit.c (jit_unregister_code): Add debug print to match
595 `jit_register_code`.
596
5972019-11-27 Christian Biesinger <cbiesinger@google.com>
598
599 * NEWS: Mention the new multithreaded symbol loading.
600
6012019-11-27 Christian Biesinger <cbiesinger@google.com>
602
603 * maint.c (n_worker_threads): Default to 0.
604 (worker_threads_disabled): New function.
605 * maint.h (worker_threads_disabled): New function.
606 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
607 here if worker_threads_disabled () is true.
608 (minimal_symbol_reader::install): Skip all threading if
609 worker_threads_disabled () is true.
610
6112019-11-27 Christian Biesinger <cbiesinger@google.com>
612
613 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
614 hash code if possible.
615 (add_minsym_to_demangled_hash_table): Likewise.
616 (minimal_symbol_reader::install): Compute the hash codes for msymbol
617 on the background thread.
618 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
619 Add these fields.
620
6212019-11-27 Christian Biesinger <cbiesinger@google.com>
622
623 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
624 of the mangled name on the background thread.
625 * symtab.c (symbol_set_names): Allow passing in the hash of the
626 linkage_name.
627 * symtab.h (symbol_set_names): Likewise.
628
6292019-11-27 Kevin Buettner <kevinb@redhat.com>
630
631 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
632 physnames are computed for inherited DIEs.
633
6342019-11-27 Tom Tromey <tromey@adacore.com>
635
636 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
637 backslashes.
638 * cp-support.c: Remove unnecessary backslashes.
639
6402019-11-27 Christian Biesinger <cbiesinger@google.com>
641
642 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
643 with sym->set_linkage_name.
644 * coffread.c (coff_read_enum_type): Likewise.
645 * mdebugread.c (parse_symbol): Likewise.
646 * stabsread.c (patch_block_stabs): Likewise.
647 (define_symbol): Likewise.
648 (read_enum_type): Likewise.
649 (common_block_end): Likewise.
650 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
651 function.
652 (SYMBOL_SET_LINKAGE_NAME): Remove.
653 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
654 with sym->set_linkage_name.
655
6562019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
657
658 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
659 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
660 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
661 * NEWS: Mention new MI command.
662
6632019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
664
665 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
666 '-symbol-info-types', and '-symbol-info-variables'.
667 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
668 (mi_cmd_symbol_info_types): Declare.
669 (mi_cmd_symbol_info_variables): Declare.
670 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
671 (output_debug_symbol): New function.
672 (output_nondebug_symbol): New function.
673 (mi_symbol_info): New function.
674 (mi_info_functions_or_variables): New function.
675 (mi_cmd_symbol_info_functions): New function.
676 (mi_cmd_symbol_info_types): New function.
677 (mi_cmd_symbol_info_variables): New function.
678 * NEWS: Mention new commands.
679
6802019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
681
682 * symtab.c (symbol_to_info_string): New function, most content
683 moved from print_symbol_info, but updated to return a std::string.
684 (print_symbol_info): Update to use symbol_to_info_string and print
685 returned string.
686 * symtab.h (symbol_to_info_string): Declare new function.
687
6882019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
689
690 * python/python.c (gdbpy_rbreak): Convert to using
691 global_symbol_searcher.
692 * symtab.c (file_matches): Convert return type to bool, change
693 file list to std::vector, update header comment.
694 (search_symbols): Rename to...
695 (global_symbol_searcher::search): ...this and update now its
696 a member function of global_symbol_searcher. Take account of the
697 changes to file_matches.
698 (symtab_symbol_info): Convert to using global_symbol_searcher.
699 (rbreak_command): Likewise.
700 (search_module_symbols): Likewise.
701 * symtab.h (enum symbol_search): Update comment.
702 (search_symbols): Remove declaration.
703 (class global_symbol_searcher): New class.
704
7052019-11-26 Tom Tromey <tromey@adacore.com>
706
707 * cp-support.c (_initialize_cp_support): Conditionally initialize
708 gdb_demangle_attempt_core_dump.
709
7102019-11-26 Tom Tromey <tom@tromey.com>
711
712 * python/py-function.c (fnpy_init): Update.
713 * value.h (add_internal_function): Adjust declaration.
714 * value.c (function_destroyer): Remove.
715 (do_add_internal_function): Don't set destroyer or copy name.
716 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
717 Set name_allocated.
718 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
719 (cmdpy_init): Set name_allocated.
720 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
721 member.
722 (~cmd_list_element): Free "name" if needed.
723
7242019-11-26 Tom Tromey <tom@tromey.com>
725
726 * value.h (add_internal_function): Add new overload. Move
727 documentation from value.h.
728 * value.c (do_add_internal_function): New function.
729 (add_internal_function): Use it. Add new overload.
730 (function_destroyer): Don't free doc.
731 * python/py-function.c (fnpy_init): Update.
732
7332019-11-26 Tom Tromey <tom@tromey.com>
734
735 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
736 (cmdpy_init): Set "doc_allocated".
737
7382019-11-26 Tom Tromey <tom@tromey.com>
739
740 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
741 name of worker thread.
742 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
743 pthread_setname_np.
744 * configure, config.in: Rebuild.
745
7462019-11-26 Tom Tromey <tom@tromey.com>
747
748 * python/python.c (class gdbpy_gil): New.
749 (struct gdbpy_event): Add constructor, destructor, operator().
750 (gdbpy_post_event): Use run_on_main_thread.
751 (gdbpy_initialize_events): Remove.
752 (do_start_initialization): Update.
753
7542019-11-26 Tom Tromey <tom@tromey.com>
755
756 * NEWS: Add entry.
757 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
758 commands. Call update_thread_pool_size.
759 (update_thread_pool_size, maintenance_set_worker_threads): New
760 functions.
761 (n_worker_threads): New global.
762
7632019-11-26 Christian Biesinger <cbiesinger@google.com>
764 Tom Tromey <tom@tromey.com>
765
766 * minsyms.c (minimal_symbol_reader::install): Use
767 parallel_for_each.
768 * gdbsupport/parallel-for.h: New file.
769 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
770
7712019-11-26 Christian Biesinger <cbiesinger@google.com>
772 Tom Tromey <tom@tromey.com>
773
774 * gdbsupport/thread-pool.h: New file.
775 * gdbsupport/thread-pool.c: New file.
776 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
777 (HFILES_NO_SRCDIR): Add thread-pool.h.
778
7792019-11-26 Tom Tromey <tom@tromey.com>
780
781 * event-top.h (thread_local_segv_handler): Declare.
782 * event-top.c (thread_local_segv_handler): New global.
783 (install_handle_sigsegv, handle_sigsegv): New functions.
784 (async_init_signals): Install SIGSEGV handler.
785 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
786 thread-local.
787 (report_failed_demangle): New function.
788 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
789 handler-setting code, instead use segv_handler. Run warning code
790 on main thread.
791
7922019-11-26 Tom Tromey <tom@tromey.com>
793
794 * run-on-main-thread.c: New file.
795 * run-on-main-thread.h: New file.
796 * unittests/main-thread-selftests.c: New file.
797 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
798 main-thread-selftests.c.
799 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
800 (COMMON_SFILES): Add run-on-main-thread.c.
801
8022019-11-26 Tom Tromey <tom@tromey.com>
803
804 * main.c (setup_alternate_signal_stack): Remove.
805 (captured_main_1): Use gdb::alternate_signal_stack.
806 * gdbsupport/alt-stack.h: New file.
807
8082019-11-26 Tom Tromey <tom@tromey.com>
809
810 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
811 Remove comment.
812 (save_original_signals_state, restore_original_signals_state): Use
813 gdb_sigmask.
814 * linux-nat.c (block_child_signals, restore_child_signals_mask)
815 (_initialize_linux_nat): Use gdb_sigmask.
816 * guile/guile.c (_initialize_guile): Use block_signals.
817 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
818 * gdbsupport/gdb-sigmask.h: New file.
819 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
820 * cp-support.c (gdb_demangle): Use gdb_sigmask.
821 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
822 pthread_sigmask.
823 * configure, config.in: Rebuild.
824 * gdbsupport/block-signals.h: New file.
825
8262019-11-26 Tom Tromey <tom@tromey.com>
827
828 * acinclude.m4: Include ax_pthread.m4.
829 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
830 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
831 (CLIBS): Use PTHREAD_LIBS.
832 (aclocal_m4_deps): Add ax_pthread.m4.
833 * config.in, configure: Rebuild.
834 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
835
8362019-11-26 Tom Tromey <tom@tromey.com>
837
838 * symtab.h (struct minimal_symbol) <name_set>: New member.
839 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
840 Don't call symbol_set_names.
841 (minimal_symbol_reader::install): Call symbol_set_names.
842
8432019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
844
845 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
846 restore_active_ext_lang, as GIL is needed for (indirectly)
847 called PyOS_InterruptOccurred.
848
8492019-11-26 Simon Marchi <simon.marchi@efficios.com>
850
851 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
852 definition.
853
8542019-11-26 Simon Marchi <simon.marchi@efficios.com>
855
856 * remote-sim.c (simulator_command): Make static, remove
857 declaration.
858
8592019-11-26 Simon Marchi <simon.marchi@efficios.com>
860
861 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
862 static.
863 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
864 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
865 (main): Likewise.
866 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
867 (main): Likewise.
868 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
869 (main): Likewise.
870 * unittests/basic_string_view/element_access/char/1.cc (test01):
871 Likewise.
872 (main): Likewise.
873 * unittests/basic_string_view/element_access/char/empty.cc (main):
874 Likewise.
875 * unittests/basic_string_view/element_access/char/front_back.cc
876 (test01): Likewise.
877 (main): Likewise.
878 * unittests/basic_string_view/inserters/char/2.cc (test05):
879 Likewise.
880 (main): Likewise.
881 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
882 (test01): Likewise.
883 (main): Likewise.
884 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
885 (test01): Likewise.
886 (main): Likewise.
887 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
888 Likewise.
889 * unittests/basic_string_view/operations/compare/char/1.cc
890 (test01): Likewise.
891 (main): Likewise.
892 * unittests/basic_string_view/operations/compare/char/13650.cc
893 (test01): Likewise.
894 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
895 Likewise.
896 (main): Likewise.
897 * unittests/basic_string_view/operations/data/char/1.cc (test01):
898 Likewise.
899 (main): Likewise.
900 * unittests/basic_string_view/operations/find/char/1.cc (test01):
901 Likewise.
902 (main): Likewise.
903 * unittests/basic_string_view/operations/find/char/2.cc (test02):
904 Likewise.
905 (main): Likewise.
906 * unittests/basic_string_view/operations/find/char/3.cc (test03):
907 Likewise.
908 (main): Likewise.
909 * unittests/basic_string_view/operations/find/char/4.cc (main):
910 Likewise.
911 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
912 Likewise.
913 (main): Likewise.
914 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
915 Likewise.
916 (main): Likewise.
917 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
918 Likewise.
919 (main): Likewise.
920 * unittests/basic_string_view/operations/substr/char/1.cc
921 (test01): Likewise.
922 (main): Likewise.
923 * unittests/basic_string_view/operators/char/2.cc (main):
924 Likewise.
925 * unittests/optional/assignment/1.cc (test): Likewise.
926 * unittests/optional/assignment/2.cc (test): Likewise.
927 * unittests/optional/assignment/3.cc (test): Likewise.
928 * unittests/optional/assignment/4.cc (test): Likewise.
929 * unittests/optional/assignment/5.cc (test): Likewise.
930 * unittests/optional/assignment/6.cc (test): Likewise.
931 * unittests/optional/assignment/7.cc (test): Likewise.
932 * unittests/optional/cons/copy.cc (test): Likewise.
933 * unittests/optional/cons/default.cc (test): Likewise.
934 * unittests/optional/cons/move.cc (test): Likewise.
935 * unittests/optional/cons/value.cc (test): Likewise.
936 * unittests/optional/in_place.cc (test): Likewise.
937 * unittests/optional/observers/1.cc (test): Likewise.
938 * unittests/optional/observers/2.cc (test): Likewise.
939
9402019-11-26 Simon Marchi <simon.marchi@efficios.com>
941
942 * tui-win.h (tui_set_var_cmd): Remove.
943 * tui-win.c (tui_set_var_cmd): Make static.
944
9452019-11-26 Simon Marchi <simon.marchi@efficios.com>
946
947 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
948 rbreak_command_wrapper): Remove.
949 * symtab.c (rbreak_command_wrapper): Remove.
950
9512019-11-26 Simon Marchi <simon.marchi@efficios.com>
952
953 * inferior.h (info_terminal_command): Remove declaration.
954 * inflow.c (info_terminal_command): Make static.
955
9562019-11-26 Simon Marchi <simon.marchi@efficios.com>
957
958 * inferior.c (exit_inferior_silent): Remove.
959
9602019-11-26 Simon Marchi <simon.marchi@efficios.com>
961
962 * dictionary.c (dict_empty, mdict_empty): Remove.
963 * dictionary.c (mdict_empty): Remove.
964
9652019-11-26 Simon Marchi <simon.marchi@efficios.com>
966
967 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
968 (arc_insn_get_memory_offset): Likewise.
969 (arc_insn_dump): Likewise.
970 * cp-support.c (test_cp_symbol_name_matches): Likewise.
971 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
972 * dictionary.c (dict_iterator_next): Likewise.
973 (dict_iter_match_first): Likewise.
974 (dict_iter_match_next): Likewise.
975 * f-lang.c (evaluate_subexp_f): Likewise.
976 * hppa-tdep.c (hppa_read_pc): Likewise.
977 * i386-tdep.c (i386_floatformat_for_type): Likewise.
978 * parse.c (write_exp_elt_msym): Likewise.
979 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
980 * remote.c (remote_packet_size): Likewise.
981 (remote_notif_stop_parse): Likewise.
982 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
983 * s12z-tdep.c (s12z_disassemble_info): Likewise.
984 * source.c (prepare_path_for_appending): Likewise.
985 * sparc64-linux-tdep.c
986 (sparc64_linux_handle_segmentation_fault); Likewise.
987 * stack.c (frame_selection_by_function_completer): Likewise.
988
9892019-11-26 Simon Marchi <simon.marchi@efficios.com>
990
991 * completer.c (set_gdb_completion_word_break_characters):
992 Remove.
993
9942019-11-26 Simon Marchi <simon.marchi@efficios.com>
995
996 * dwarf-index-write.c: Include dwarf-index-write.h.
997 * mi/mi-interp.c: Include mi/mi-interp.h.
998
9992019-11-26 Simon Marchi <simon.marchi@efficios.com>
1000
1001 * aarch32-tdep.c: Include aarch32-tdep.h.
1002 * aarch32-tdep.h: Forward-declare struct target_desc.
1003
10042019-11-26 Christian Biesinger <cbiesinger@google.com>
1005
1006 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1007 strerror.
1008 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1009 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1010
10112019-11-25 Tom de Vries <tdevries@suse.de>
1012
1013 * contrib/words.sh: Add -c option.
1014
10152019-11-25 Christian Biesinger <cbiesinger@google.com>
1016
1017 * solib.c (solib_find_1): Change int to bool.
1018 (exec_file_find): Change int to bool.
1019 (solib_find): Change int to bool.
1020 (solib_read_symbols): Change int to bool.
1021 (solib_used): Change int to bool.
1022 (solib_add): Change int to bool.
1023 (info_sharedlibrary_command): Change int to bool.
1024 (solib_contains_address_p): Change int to bool.
1025 (solib_keep_data_in_core): Change int to bool.
1026 (in_solib_dynsym_resolve_code): Change int to bool.
1027 (reload_shared_libraries_1): Change int to bool.
1028 (gdb_sysroot_changed): Change int to bool.
1029 * solib.h (solib_read_symbols): Change int to bool.
1030 (solib_contains_address_p): Change int to bool.
1031 (solib_keep_data_in_core): Change int to bool.
1032 (in_solib_dynsym_resolve_code): Change int to bool.
1033 (libpthread_name_p): Change int to bool.
1034
10352019-11-25 Luis Machado <luis.machado@linaro.org>
1036
1037 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1038 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1039 (remote_packet_max_chars): New static global.
1040 (show_remote_packet_max_chars): New function.
1041 (remote_target::putpkt_binary): Adjust to use new
1042 remote_packet_max_chars option.
1043 (remote_target::getpkt_or_notif_sane_1): Likewise.
1044 (_initialize_remote): Register new remote-packet-max-chars option.
1045
10462019-11-24 Simon Marchi <simon.marchi@efficios.com>
1047
1048 * m68k-linux-nat.c: Include gdbarch.h.
1049
10502019-11-24 Tom Tromey <tom@tromey.com>
1051
1052 * symfile.c (read_symbols): Update.
1053 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1054 bool.
1055 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1056 (psym_lookup_symbol, psym_find_last_source_symtab)
1057 (psym_forget_cached_source_info, psym_print_stats)
1058 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1059 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1060 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1061 (psym_find_compunit_symtab_by_address)
1062 (maintenance_print_psymbols, maintenance_info_psymtabs)
1063 (maintenance_check_psymtabs): Update.
1064 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1065 bool.
1066
10672019-11-22 Tom Tromey <tom@tromey.com>
1068
1069 * observable.h: Update comments.
1070
10712019-11-22 Tom Tromey <tromey@adacore.com>
1072
1073 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1074 (print_ada_task_info): Don't try to fetch thread id if task is not
1075 alive.
1076
10772019-11-22 Christian Biesinger <cbiesinger@google.com>
1078
1079 * ada-exp.y: Update.
1080 * ada-lang.c (sort_choices): Update.
1081 (ada_print_symbol_signature): Update.
1082 (resolve_subexp): Update.
1083 (ada_parse_renaming): Update.
1084 (ada_read_renaming_var_value): Update.
1085 (lesseq_defined_than): Update.
1086 (remove_extra_symbols): Update.
1087 (remove_irrelevant_renamings): Update.
1088 (ada_add_block_symbols): Update.
1089 (ada_collect_symbol_completion_matches): Update.
1090 (ada_is_renaming_symbol): Update.
1091 (aggregate_assign_from_choices): Update.
1092 (ada_evaluate_subexp): Update.
1093 (ada_has_this_exception_support): Update.
1094 (ada_is_non_standard_exception_sym): Update.
1095 (ada_add_exceptions_from_frame): Update.
1096 (ada_add_global_exceptions): Update.
1097 (ada_print_subexp): Update.
1098 * ax-gdb.c (gen_var_ref): Update.
1099 (gen_maybe_namespace_elt): Update.
1100 (gen_expr_for_cast): Update.
1101 (gen_expr): Update.
1102 * block.h: Update.
1103 * blockframe.c (find_pc_partial_function): Update.
1104 * breakpoint.c (print_breakpoint_location): Update.
1105 (update_static_tracepoint): Update.
1106 * btrace.c (ftrace_print_function_name): Update.
1107 (ftrace_function_switched): Update.
1108 * buildsym.c (find_symbol_in_list): Update.
1109 * c-exp.y: Update.
1110 * c-typeprint.c (c_print_typedef): Update.
1111 (c_type_print_template_args): Update.
1112 * cli/cli-cmds.c (edit_command): Update.
1113 (list_command): Update.
1114 (print_sal_location): Update.
1115 * coffread.c (patch_opaque_types): Update.
1116 (process_coff_symbol): Update.
1117 (coff_read_enum_type): Update.
1118 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1119 (convert_one_symbol): Update.
1120 (hash_symname): Update.
1121 (eq_symname): Update.
1122 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1123 * compile/compile-cplus-types.c (debug_print_scope): Update.
1124 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1125 * compile/compile-object-load.c (get_out_value_type): Update.
1126 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1127 (search_symbol_list): Update.
1128 (cp_lookup_symbol_imports_or_template): Update.
1129 * cp-support.c (overload_list_add_symbol): Update.
1130 * ctfread.c (psymtab_to_symtab): Update.
1131 * dbxread.c (cp_set_block_scope): Update.
1132 * dictionary.c (iter_match_first_hashed): Update.
1133 (iter_match_next_hashed): Update.
1134 (insert_symbol_hashed): Update.
1135 (iter_match_next_linear): Update.
1136 * dictionary.h: Update.
1137 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1138 (locexpr_describe_location_piece): Update.
1139 (locexpr_describe_location_1): Update.
1140 (locexpr_generate_c_location): Update.
1141 (loclist_describe_location): Update.
1142 (loclist_generate_c_location): Update.
1143 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1144 (read_func_scope): Update.
1145 (process_enumeration_scope): Update.
1146 (new_symbol): Update.
1147 (dwarf2_const_value): Update.
1148 (dwarf2_symbol_mark_computed): Update.
1149 * eval.c (evaluate_funcall): Update.
1150 (evaluate_subexp_standard): Update.
1151 * expprint.c (print_subexp_standard): Update.
1152 (dump_subexp_body_standard): Update.
1153 * f-valprint.c (info_common_command_for_block): Update.
1154 * findvar.c (get_hosting_frame): Update.
1155 (default_read_var_value): Update.
1156 * go-lang.c (go_symbol_package_name): Update.
1157 * guile/scm-block.c (bkscm_print_block_smob): Update.
1158 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1159 (gdbscm_symbol_name): Update.
1160 (gdbscm_symbol_linkage_name): Update.
1161 (gdbscm_symbol_print_name): Update.
1162 * infcall.c (get_function_name): Update.
1163 * infcmd.c (jump_command): Update.
1164 (finish_command): Update.
1165 * infrun.c (insert_exception_resume_breakpoint): Update.
1166 * linespec.c (canonicalize_linespec): Update.
1167 (create_sals_line_offset): Update.
1168 (convert_linespec_to_sals): Update.
1169 (complete_label): Update.
1170 (find_label_symbols_in_block): Update.
1171 * m2-typeprint.c (m2_print_typedef): Update.
1172 * mdebugread.c (mdebug_reg_to_regnum): Update.
1173 (parse_symbol): Update.
1174 (mylookup_symbol): Update.
1175 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1176 (list_args_or_locals): Update.
1177 * objc-lang.c (compare_selectors): Update.
1178 (info_selectors_command): Update.
1179 (compare_classes): Update.
1180 (info_classes_command): Update.
1181 (find_imps): Update.
1182 * p-typeprint.c (pascal_print_typedef): Update.
1183 * printcmd.c (build_address_symbolic): Update.
1184 (info_address_command): Update.
1185 (print_variable_and_value): Update.
1186 * python/py-framefilter.c (extract_sym): Update.
1187 (py_print_single_arg): Update.
1188 * python/py-symbol.c (sympy_str): Update.
1189 (sympy_get_name): Update.
1190 (sympy_get_linkage_name): Update.
1191 * python/python.c (gdbpy_rbreak): Update.
1192 * record-btrace.c (btrace_get_bfun_name): Update.
1193 (btrace_call_history): Update.
1194 * rust-lang.c (rust_print_typedef): Update.
1195 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1196 * stabsread.c (stab_reg_to_regnum): Update.
1197 (define_symbol): Update.
1198 (read_enum_type): Update.
1199 (common_block_end): Update.
1200 (cleanup_undefined_types_1): Update.
1201 (scan_file_globals): Update.
1202 * stack.c (print_frame_arg): Update.
1203 (print_frame_args): Update.
1204 (find_frame_funname): Update.
1205 (info_frame_command_core): Update.
1206 (iterate_over_block_locals): Update.
1207 (print_block_frame_labels): Update.
1208 (do_print_variable_and_value): Update.
1209 (iterate_over_block_arg_vars): Update.
1210 (return_command): Update.
1211 * symmisc.c (dump_symtab_1): Update.
1212 (print_symbol): Update.
1213 * symtab.c (eq_symbol_entry): Update.
1214 (symbol_cache_dump): Update.
1215 (lookup_language_this): Update.
1216 (find_pc_sect_line): Update.
1217 (skip_prologue_sal): Update.
1218 (symbol_search::compare_search_syms): Update.
1219 (treg_matches_sym_type_name): Update.
1220 (search_symbols): Update.
1221 (print_symbol_info): Update.
1222 (rbreak_command): Update.
1223 (completion_list_add_symbol): Update.
1224 (find_gnu_ifunc): Update.
1225 (get_symbol_address): Update.
1226 (search_module_symbols): Update.
1227 (info_module_subcommand): Update.
1228 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1229 (SYMBOL_LINKAGE_NAME): Remove.
1230 (SYMBOL_DEMANGLED_NAME): Remove.
1231 (SYMBOL_PRINT_NAME): Remove.
1232 (SYMBOL_SEARCH_NAME): Remove.
1233 * tracepoint.c (set_traceframe_context): Update.
1234 (validate_actionline): Update.
1235 (collection_list::collect_symbol): Update.
1236 (encode_actions_1): Update.
1237 (info_scope_command): Update.
1238 (print_one_static_tracepoint_marker): Update.
1239 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1240 * valops.c (address_of_variable): Update.
1241 (find_overload_match): Update.
1242 (find_oload_champ): Update.
1243
12442019-11-22 Christian Biesinger <cbiesinger@google.com>
1245
1246 * ada-lang.c (ada_lookup_simple_minsym): Update.
1247 (ada_collect_symbol_completion_matches): Update.
1248 * ada-tasks.c (read_atcb): Update.
1249 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1250 (amd64_windows_skip_trampoline_code): Update.
1251 * arm-tdep.c (skip_prologue_function): Update.
1252 (arm_skip_stack_protector): Update.
1253 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1254 (arm_wince_skip_main_prologue): Update.
1255 * ax-gdb.c (gen_expr): Update.
1256 * block.c (call_site_for_pc): Update.
1257 * blockframe.c (find_pc_partial_function): Update.
1258 * breakpoint.c (set_breakpoint_location_function): Update.
1259 * btrace.c (ftrace_print_function_name): Update.
1260 (ftrace_function_switched): Update.
1261 * c-valprint.c (print_unpacked_pointer): Update.
1262 * coffread.c (coff_symfile_read): Update.
1263 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1264 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1265 * dwarf-index-write.c (write_psymbols): Update.
1266 * dwarf2loc.c (call_site_to_target_addr): Update.
1267 (func_verify_no_selftailcall): Update.
1268 (tailcall_dump): Update.
1269 (call_site_find_chain_1): Update.
1270 (dwarf_expr_reg_to_entry_parameter): Update.
1271 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1272 * eval.c (evaluate_funcall): Update.
1273 (evaluate_subexp_standard): Update.
1274 (evaluate_subexp_for_sizeof): Update.
1275 * expprint.c (print_subexp_standard): Update.
1276 (dump_subexp_body_standard): Update.
1277 * frame.c (get_prev_frame_always_1): Update.
1278 * frv-tdep.c (frv_skip_main_prologue): Update.
1279 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1280 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1281 (gnuv3_get_typename_from_type_info): Update.
1282 (gnuv3_skip_trampoline): Update.
1283 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1284 * i386-tdep.c (i386_skip_main_prologue): Update.
1285 (i386_pe_skip_trampoline_code): Update.
1286 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1287 * infcall.c (get_function_name): Update.
1288 * linespec.c (minsym_found): Update.
1289 * linux-fork.c (info_checkpoints_command): Update.
1290 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1291 (m32c_m16c_pointer_to_address): Update.
1292 * maint.c (maintenance_translate_address): Update.
1293 * minsyms.c (add_minsym_to_hash_table): Update.
1294 (add_minsym_to_demangled_hash_table): Update.
1295 (lookup_minimal_symbol_mangled): Update.
1296 (lookup_minimal_symbol_demangled): Update.
1297 (lookup_minimal_symbol_linkage): Update.
1298 (lookup_minimal_symbol_text): Update.
1299 (lookup_minimal_symbol_by_pc_name): Update.
1300 (minimal_symbol_is_less_than): Update.
1301 (compact_minimal_symbols): Update.
1302 (build_minimal_symbol_hash_tables): Update.
1303 (find_solib_trampoline_target): Update.
1304 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1305 (mips_skip_pic_trampoline_code): Update.
1306 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1307 * objc-lang.c (info_selectors_command): Update.
1308 (info_classes_command): Update.
1309 (find_methods): Update.
1310 (find_imps): Update.
1311 * p-valprint.c (pascal_val_print): Update.
1312 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1313 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1314 * printcmd.c (build_address_symbolic): Update.
1315 (info_symbol_command): Update.
1316 * psymtab.c (psymbol_name_matches): Update.
1317 (match_partial_symbol): Update.
1318 (lookup_partial_symbol): Update.
1319 (print_partial_symbols): Update.
1320 (sort_pst_symbols): Update.
1321 (maintenance_check_psymtabs): Update.
1322 * python/py-framefilter.c (py_print_frame): Update.
1323 * python/python.c (gdbpy_rbreak): Update.
1324 * record-btrace.c (btrace_get_bfun_name): Update.
1325 (btrace_call_history): Update.
1326 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1327 (rs6000_skip_trampoline_code): Update.
1328 * sol-thread.c (info_cb): Update.
1329 * stabsread.c (scan_file_globals): Update.
1330 * stack.c (find_frame_funname): Update.
1331 (info_frame_command_core): Update.
1332 * symmisc.c (dump_msymbols): Update.
1333 * symtab.c (symbol_natural_name): Rename to..,
1334 (general_symbol_info::natural_name): ...this.
1335 (symbol_demangled_name): Rename to...
1336 (general_symbol_info::demangled_name): ...this.
1337 (symbol_search_name): Rename to...
1338 (general_symbol_info::search_name): ...this.
1339 (symbol_matches_search_name): Update.
1340 (find_pc_sect_line): Update.
1341 (skip_prologue_sal): Update.
1342 (search_symbols): Update.
1343 (print_msymbol_info): Update.
1344 (rbreak_command): Update.
1345 (completion_list_add_msymbol): Update.
1346 (completion_list_objc_symbol): Update.
1347 (get_msymbol_address): Update.
1348 * symtab.h (struct general_symbol_info): Add member functions
1349 natural_name (), linkage_name (), print_name (), demangled_name (),
1350 and search_name ().
1351 (SYMBOL_NATURAL_NAME): Update.
1352 (symbol_natural_name): Move to a member function on general_symbol_info.
1353 (SYMBOL_DEMANGLED_NAME): Update.
1354 (symbol_demangled_name): Move to a member function on
1355 general_symbol_info.
1356 (SYMBOL_SEARCH_NAME): Update.
1357 (symbol_search_name): Move to a member function on general_symbol_info.
1358 (MSYMBOL_NATURAL_NAME): Remove.
1359 (MSYMBOL_LINKAGE_NAME): Remove.
1360 (MSYMBOL_PRINT_NAME): Remove.
1361 (MSYMBOL_DEMANGLED_NAME): Remove.
1362 (MSYMBOL_SEARCH_NAME): Remove.
1363 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1364
13652019-11-22 Christian Biesinger <cbiesinger@google.com>
1366
1367 * symtab.c (create_demangled_names_hash): Use per_bfd->
1368 minimal_symbol_count for computing the initial size, if greater
1369 than our default size.
1370
13712019-11-22 Tom de Vries <tdevries@suse.de>
1372
1373 * contrib/words.sh: Improve words extraction.
1374
13752019-11-22 Tom de Vries <tdevries@suse.de>
1376
1377 * contrib/words.sh: Combine sed invocations.
1378
13792019-11-21 Christian Biesinger <cbiesinger@google.com>
1380
1381 * Makefile.in: Update.
1382 * demangle.c: Rename to...
1383 * gdb-demangle.c: ..this.
1384 (is_cplus_marker): Change return type to bool.
1385 (_initialize_demangler): Rename to...
1386 (_initialize_gdb_demangle): ...this.
1387 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1388 * symtab.h (demangle): Remove declaration; instead include
1389 gdb-demangle.h.
1390
13912019-11-21 Tom Tromey <tromey@adacore.com>
1392
1393 * gdbsupport/format.c (format_pieces): Parse %I64d.
1394 * unittests/format_pieces-selftests.c (test_windows_formats): New
1395 function.
1396 (run_tests): Call it.
1397
13982019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1399
1400 Byte reverse display of variables with DW_END_big, DW_END_little
1401 (DW_AT_endianity) dwarf attributes if different than the native
1402 byte order.
1403 * ada-lang.c (ada_value_binop):
1404 Use type_byte_order instead of gdbarch_byte_order.
1405 * ada-valprint.c (printstr):
1406 (ada_val_print_string):
1407 * ada-lang.c (value_pointer):
1408 (ada_value_binop):
1409 Use type_byte_order instead of gdbarch_byte_order.
1410 * c-lang.c (c_get_string):
1411 Use type_byte_order instead of gdbarch_byte_order.
1412 * c-valprint.c (c_val_print_array):
1413 Use type_byte_order instead of gdbarch_byte_order.
1414 * cp-valprint.c (cp_print_class_member):
1415 Use type_byte_order instead of gdbarch_byte_order.
1416 * dwarf2loc.c (rw_pieced_value):
1417 Use type_byte_order instead of gdbarch_byte_order.
1418 * dwarf2read.c (read_base_type): Handle DW_END_big,
1419 DW_END_little
1420 * f-lang.c (f_get_encoding):
1421 Use type_byte_order instead of gdbarch_byte_order.
1422 * findvar.c (default_read_var_value):
1423 Use type_byte_order instead of gdbarch_byte_order.
1424 * gdbtypes.c (check_types_equal):
1425 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1426 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1427 and TYPE_ENDIANITY_LITTLE if set.
1428 (type_byte_order): new function.
1429 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1430 (struct main_type) <flag_endianity_not_default>:
1431 New field.
1432 (type_byte_order): New function.
1433 * infcmd.c (default_print_one_register_info):
1434 Use type_byte_order instead of gdbarch_byte_order.
1435 * p-lang.c (pascal_printstr):
1436 Use type_byte_order instead of gdbarch_byte_order.
1437 * p-valprint.c (pascal_val_print):
1438 Use type_byte_order instead of gdbarch_byte_order.
1439 * printcmd.c (print_scalar_formatted):
1440 Use type_byte_order instead of gdbarch_byte_order.
1441 * solib-darwin.c (darwin_current_sos):
1442 Use type_byte_order instead of gdbarch_byte_order.
1443 * solib-svr4.c (solib_svr4_r_ldsomap):
1444 Use type_byte_order instead of gdbarch_byte_order.
1445 * stap-probe.c (stap_modify_semaphore):
1446 Use type_byte_order instead of gdbarch_byte_order.
1447 * target-float.c (target_float_same_format_p):
1448 Use type_byte_order instead of gdbarch_byte_order.
1449 * valarith.c (scalar_binop):
1450 (value_bit_index):
1451 Use type_byte_order instead of gdbarch_byte_order.
1452 * valops.c (value_cast):
1453 Use type_byte_order instead of gdbarch_byte_order.
1454 * valprint.c (generic_emit_char):
1455 (generic_printstr):
1456 (val_print_string):
1457 Use type_byte_order instead of gdbarch_byte_order.
1458 * value.c (unpack_long):
1459 (unpack_bits_as_long):
1460 (unpack_value_bitfield):
1461 (modify_field):
1462 (pack_long):
1463 (pack_unsigned_long):
1464 Use type_byte_order instead of gdbarch_byte_order.
1465 * findvar.c (unsigned_pointer_to_address):
1466 (signed_pointer_to_address):
1467 (unsigned_address_to_pointer):
1468 (address_to_signed_pointer):
1469 (default_read_var_value):
1470 (default_value_from_register):
1471 Use type_byte_order instead of gdbarch_byte_order.
1472 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1473 Use type_byte_order instead of gdbarch_byte_order.
1474 * riscv-tdep.c (riscv_print_one_register_info):
1475 Use type_byte_order instead of gdbarch_byte_order.
1476
14772019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1478
1479 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1480 (current_ui_gdb_stdin_ptr): Likewise.
1481 (current_ui_gdb_stderr_ptr): Likewise.
1482 (current_ui_gdb_stdlog_ptr): Likewise.
1483 (current_ui_current_uiout_ptr): Likewise.
1484 (gen_ret_current_ui_field_ptr): Remove.
1485
14862019-11-21 Tom de Vries <tdevries@suse.de>
1487
1488 PR gdb/24956
1489 * cli/cli-script.c (execute_control_command): Only switch to
1490 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1491
14922019-11-19 Tom Tromey <tom@tromey.com>
1493
1494 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1495 Now static. Change type of "name".
1496 (tui_set_win_height_command): Don't copy "arg".
1497 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1498 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1499
15002019-11-19 Ali Tamur <tamur@google.com>
1501
1502 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1503 "if (attr != nullptr)".
1504 (dwarf2_find_base_address): Likewise.
1505 (dwarf2_build_include_psymtabs): Likewise.
1506 (read_cutu_die_from_dwo): Likewise.
1507 (read_func_scope): Likewise.
1508 (read_call_site_scope): Likewise.
1509 (dwarf2_get_pc_bounds): Likewise.
1510 (dwarf2_record_block_ranges): Likewise.
1511 (dwarf2_add_field): Likewise.
1512 (dwarf2_add_member_fn): Likewise.
1513 (read_structure_type): Likewise.
1514 (read_enumeration_type): Likewise.
1515 (read_array_type): Likewise.
1516 (read_array_order): Likewise.
1517 (read_set_type): Likewise.
1518 (read_common_block): Likewise.
1519 (read_tag_reference_type): Likewise.
1520 (read_tag_string_type): Likewise.
1521 (read_subroutine_type): Likewise.
1522 (read_base_type): Likewise.
1523 (read_subrange_type): Likewise.
1524 (new_symbol): Likewise.
1525 (prepare_one_comp_unit): Likewise.
1526
15272019-11-19 Tom Tromey <tromey@adacore.com>
1528
1529 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1530 result in error when DebugActiveProcess fails.
1531
15322019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1533 Pedro Alves <palves@redhat.com>
1534
1535 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1536 * target.c (target_stack::push): Call 'unpush' if there's a
1537 target on top of the stack.
1538
15392019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1540
1541 * python/py-block.c (blpy_dealloc): Call tp_free.
1542 (blpy_block_syms_dealloc): Likewise.
1543 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1544 * python/py-inferior.c (infpy_dealloc): Likewise.
1545 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1546 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1547 * python/py-symbol.c (sympy_dealloc): Likewise.
1548 * python/py-symtab.c (stpy_dealloc): Likewise.
1549 * python/py-type.c (typy_iterator_dealloc): Likewise.
1550
15512019-11-18 Christian Biesinger <cbiesinger@google.com>
1552
1553 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1554 constructor instead of using a class initializer.
1555
15562019-11-15 Christian Biesinger <cbiesinger@google.com>
1557
1558 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1559 * configure: Regenerate.
1560 * configure.ac: Don't source common.host.
1561 * gdbsupport/common.host: Remove.
1562 * gdbsupport/mingw-strerror.c: Remove.
1563 * gdbsupport/posix-strerror.c: Rename to...
1564 * gdbsupport/safe-strerror.c: ...this.
1565
15662019-11-15 Christian Biesinger <cbiesinger@google.com>
1567
1568 * maint.c (scoped_command_stats::print_time): Use localtime_r
1569 instead of localtime (provided through gnulib if necessary).
1570 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1571 of ctime.
1572
15732019-11-15 Christian Biesinger <cbiesinger@google.com>
1574
1575 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1576 avoid compile errors.
1577
15782019-11-15 Christian Biesinger <cbiesinger@google.com>
1579
1580 * config.in: Regenerate.
1581 * configure: Regenerate.
1582 * gdbsupport/common.m4: No longer check for strerror_r.
1583 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1584 POSIX version of strerror_r, now that gnulib provides it if
1585 necessary.
1586
15872019-11-14 Christian Biesinger <cbiesinger@google.com>
1588
1589 * README (`configure' options): Update.
1590
15912019-11-14 Tom Tromey <tromey@adacore.com>
1592
1593 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1594 expected type for the RHS if the LHS is a convenience variable.
1595
15962019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1597
1598 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1599 Provide explicit default and copy constructor.
1600
16012019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1602
1603 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1604 only call Py_INCREF (newbp) in the bppy_pending_object case.
1605
16062019-11-13 Tom Tromey <tromey@adacore.com>
1607
1608 PR build/25182:
1609 * psympriv.h (partial_symbol): Remove static assert.
1610 * symtab.h (general_symbol_info, symbol): Remove static assert.
1611
16122019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1613
1614 * gdbsupport/format.c (format_pieces::format_pieces): Support
1615 printf 'z' size modifier.
1616 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1617 * printcmd.c (ui_printf): Handle size_t_arg.
1618 * ui-out.c (ui_out::vmessage): Likewise.
1619 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1620 function.
1621 (run_tests): Call test_format_int_sizes.
1622
16232019-11-12 Christian Biesinger <cbiesinger@google.com>
1624
1625 * ada-exp.y (write_ambiguous_var): Update.
1626 * buildsym.c (add_symbol_to_list): Update.
1627 * dwarf2read.c (read_variable): Update.
1628 (new_symbol): Update.
1629 * jit.c (finalize_symtab): Update.
1630 * language.c (language_alloc_type_symbol): Update.
1631 * symtab.c (fixup_symbol_section): Update.
1632 (initialize_objfile_symbol_1): Move code to...
1633 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1634 (allocate_symbol): Update.
1635 (allocate_template_symbol): Update.
1636 (get_symbol_address): Update.
1637 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1638 of having as a field, and add a constructor.
1639 (SYMBOL_VALUE): Update.
1640 (SYMBOL_VALUE_ADDRESS): Update.
1641 (SET_SYMBOL_VALUE_ADDRESS): Update.
1642 (SYMBOL_VALUE_BYTES): Update.
1643 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1644 (SYMBOL_BLOCK_VALUE): Update.
1645 (SYMBOL_VALUE_CHAIN): Update.
1646 (SYMBOL_LANGUAGE): Update.
1647 (SYMBOL_SECTION): Update.
1648 (SYMBOL_OBJ_SECTION): Update.
1649 (SYMBOL_SET_LANGUAGE): Update.
1650 (SYMBOL_SET_LINKAGE_NAME): Update.
1651 (SYMBOL_SET_NAMES): Update.
1652 (SYMBOL_NATURAL_NAME): Update.
1653 (SYMBOL_LINKAGE_NAME): Update.
1654 (SYMBOL_DEMANGLED_NAME): Update.
1655 (SYMBOL_SEARCH_NAME): Update.
1656 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1657 (struct symbol): Update.
1658 (struct template_symbol): Update.
1659 (struct rust_vtable_symbol): Update.
1660 * xcoffread.c (SYMBOL_DUP): Update.
1661
16622019-11-12 Tom Tromey <tom@tromey.com>
1663
1664 * tui/tui-layout.c (show_layout): Set current_layout.
1665 (show_source_disasm_command, show_data)
1666 (show_source_or_disasm_and_command): Don't set current_layout.
1667
16682019-11-12 Tom Tromey <tom@tromey.com>
1669
1670 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1671
16722019-11-12 Tom Tromey <tom@tromey.com>
1673
1674 * tui/tui-win.c (resize_message): New global.
1675 (show_tui_resize_message): New function.
1676 (tui_async_resize_screen): Print message if requested.
1677 (_initialize_tui_win): Add tui-resize-message setting.
1678 * NEWS: Add entry for new commands.
1679
16802019-11-11 Tom Tromey <tom@tromey.com>
1681
1682 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1683 functions.
1684
16852019-11-11 Christian Biesinger <cbiesinger@google.com>
1686
1687 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1688
16892019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1690
1691 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1692 function.
1693 * python/python-internal.h (gdbpy_lookup_static_symbols):
1694 Declare new function.
1695 * python/python.c (python_GdbMethods): Add
1696 gdb.lookup_static_symbols method.
1697 * NEWS: Mention gdb.lookup_static_symbols.
1698
16992019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1700
1701 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1702 static block of current object file first. Also fix typo in
1703 header comment.
1704
17052019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1706
1707 * stack.c (set_last_displayed_sal): Delete.
1708 (last_displayed_sal_valid): Delete.
1709 (last_displayed_pspace): Delete.
1710 (last_displayed_addr): Delete.
1711 (last_displayed_symtab): Delete.
1712 (last_displayed_line): Delete.
1713 (class last_displayed_symtab_info_type): New.
1714 (last_displayed_symtab_info): New static global variable.
1715 (print_frame_info): Call methods on last_displayed_symtab_info.
1716 (clear_last_displayed_sal): Update header comment, and make use of
1717 last_displayed_symtab_info.
1718 (last_displayed_sal_is_valid): Likewise.
1719 (get_last_displayed_pspace): Likewise.
1720 (get_last_displayed_addr): Likewise.
1721 (get_last_displayed_symtab): Likewise.
1722 (get_last_displayed_line): Likewise.
1723 (get_last_displayed_sal): Likewise.
1724 * stack.h (clear_last_displayed_sal): Update header comment.
1725 (last_displayed_sal_is_valid): Likewise.
1726 (get_last_displayed_pspace): Likewise.
1727 (get_last_displayed_addr): Likewise.
1728 (get_last_displayed_symtab): Likewise.
1729 (get_last_displayed_line): Likewise.
1730 (get_last_displayed_sal): Likewise.
1731
17322019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1733
1734 * stack.c (frame_show_address): Convert return type to bool.
1735 * stack.h (frame_show_address): Likewise, and update header
1736 comment.
1737
17382019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1739
1740 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1741 * unittests/vec-utils-selftests.c: New file.
1742 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1743
17442019-11-10 Tom Tromey <tom@tromey.com>
1745
1746 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1747 (tui_highlight_win): Likewise.
1748 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1749 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1750 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1751 Don't set can_highlight.
1752
17532019-11-10 Tom Tromey <tom@tromey.com>
1754
1755 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1756 Remove unused declaration.
1757
17582019-11-08 Tom Tromey <tromey@adacore.com>
1759
1760 * top.c (read_command_file): Update.
1761 (command_line_input): Make return type const.
1762 * python/py-gdb-readline.c: Update.
1763 * linespec.c (decode_line_2): Update.
1764 * defs.h (command_line_input): Make return type const.
1765 * cli/cli-script.c (read_next_line): Make return type const.
1766 * ada-lang.c (get_selections): Update.
1767
17682019-11-06 Christian Biesinger <cbiesinger@google.com>
1769
1770 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1771 * mi/mi-main.c (output_cores): Likewise.
1772 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1773 (linux_xfer_osdata_modules): Likewise.
1774 * remote.c (register_remote_support_xml): Likewise.
1775 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1776 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1777
17782019-11-06 Tom Tromey <tom@tromey.com>
1779
1780 * tui/tui-interp.c: Don't include readline.h.
1781 * tui/tui-hooks.c: Don't include readline.h.
1782 * symmisc.c: Include tilde.h, not readline.h.
1783 * symfile.c: Include tilde.h, not readline.h.
1784 * source.c: Include tilde.h, not readline.h.
1785 * solib.c: Include tilde.h, not readline.h.
1786 * psymtab.c: Include tilde.h, not readline.h.
1787 * exec.c: Include tilde.h, not readline.h.
1788 * corelow.c: Include tilde.h, not readline.h.
1789 * cli/cli-dump.c: Include tilde.h, not readline.h.
1790 * cli/cli-cmds.c: Don't include readline.h.
1791
17922019-11-05 Tom Tromey <tom@tromey.com>
1793
1794 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1795 (tui_disassemble): Set addr_size.
1796 (tui_disasm_window::set_contents): Use addr_size.
1797
17982019-11-05 Tom Tromey <tom@tromey.com>
1799
1800 * rust-lang.c (rust_language_defn): Update.
1801 * python/py-value.c (valpy_string): Call c_get_string.
1802 * p-lang.c (pascal_language_defn): Update.
1803 * opencl-lang.c (opencl_language_defn): Update.
1804 * objc-lang.c (objc_language_defn): Update.
1805 * m2-lang.c (m2_language_defn): Update.
1806 * language.c (unknown_language_defn, auto_language_defn): Update.
1807 (default_get_string): Remove.
1808 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1809 * go-lang.c (go_language_defn): Update.
1810 * f-lang.c (f_language_defn): Update.
1811 * d-lang.c (d_language_defn): Update.
1812 * c-lang.c (c_language_defn, cplus_language_defn)
1813 (asm_language_defn, minimal_language_defn): Update.
1814 * ada-lang.c (ada_language_defn): Update.
1815 * language.h (struct language_defn) <la_get_string>: Remove.
1816 (LA_GET_STRING): Remove.
1817 (default_get_string): Don't declare.
1818
18192019-11-05 Tom Tromey <tom@tromey.com>
1820
1821 * tui/tui-source.h (struct tui_source_window): Inline
1822 constructor. Remove destructor.
1823 <style_changed, m_observable>: Move to superclass.
1824 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1825 (struct tui_source_window_base): Move private members to end.
1826 <style_changed, m_observable>: Move from tui_source_window.
1827 * tui/tui-winsource.c (tui_copy_source_line): Move from
1828 tui-source.c. Rename from copy_source_line. Add special handling
1829 for negative line number.
1830 (tui_source_window_base::style_changed): Move from
1831 tui_source_window.
1832 (tui_source_window_base): Register observer.
1833 (~tui_source_window_base): New.
1834 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1835 rename.
1836 (tui_source_window::set_contents): Use tui_copy_source_line.
1837 (tui_source_window::tui_source_window): Move to tui-source.h.
1838 (tui_source_window::~tui_source_window): Remove.
1839 (tui_source_window::style_changed): Move to superclass.
1840 * tui/tui-disasm.c (tui_disassemble): Create string file with
1841 styling, when possible. Add "addr_size" parameter.
1842 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1843 Don't compute maximum size.
1844 (len_without_escapes): New function
1845
18462019-11-05 Tom Tromey <tom@tromey.com>
1847
1848 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1849 std::string.
1850 * tui/tui-winsource.c (tui_show_source_line): Update.
1851 * tui/tui-source.c (tui_source_window::set_contents): Update.
1852 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1853
18542019-11-05 Christian Biesinger <cbiesinger@google.com>
1855
1856 * symtab.h (gdb_static_assert): Put && operator at the beginning
1857 of the line instead of the end.
1858
18592019-11-04 Christian Biesinger <cbiesinger@google.com>
1860
1861 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1862 and sizeof (symbol).
1863 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1864
18652019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1866
1867 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1868 * configure.host: Mark *-*-solaris2.10* obsolete.
1869 * configure.tgt: Mark Solaris < 11 obsolete.
1870 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1871 Update target triplet.
1872
18732019-11-01 Tom Tromey <tromey@adacore.com>
1874
1875 * utils.c (print_sys_errmsg): Simplify.
1876
18772019-11-01 Tom Tromey <tromey@adacore.com>
1878
1879 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1880
18812019-11-01 Christian Biesinger <cbiesinger@google.com>
1882
1883 * configure: Regenerate.
1884 * configure.ac: Remove check for strerror_r.
1885 * gdbsupport/common.m4: Check for strerror_r.
1886
18872019-11-01 Luis Machado <luis.machado@linaro.org>
1888
1889 PR gdb/25124
1890
1891 * arm-tdep.c (arm_per_objfile): Rename to ...
1892 (arm_per_bfd): ... this.
1893 (arm_objfile_data_key): Rename to ...
1894 (arm_bfd_data_key): ... this.
1895 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1896 data.
1897 (arm_record_special_symbol): Likewise.
1898
18992019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1900
1901 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1902 end.
1903 * c-typeprint.c (c_print_typedef): Likewise.
1904 * f-typeprint.c (f_print_typedef): Likewise.
1905 * m2-typeprint.c (m2_print_typedef): Likewise.
1906 * p-typeprint.c (pascal_print_typedef): Likewise.
1907 * rust-lang.c (rust_print_typedef): Likewise.
1908 * symtab.c (print_symbol_info): Print a newline after calling
1909 typedef_print.
1910
19112019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1912
1913 * symtab.c (info_module_cmdlist): New variable.
1914 (info_module_command): New function.
1915 (search_module_symbols): New function.
1916 (info_module_subcommand): New function.
1917 (struct info_modules_var_func_options): New struct.
1918 (info_modules_var_func_options_defs): New variable.
1919 (make_info_modules_var_func_options_def_group): New function.
1920 (info_module_functions_command): New function.
1921 (info_module_variables_command): New function.
1922 (info_module_var_func_command_completer): New function.
1923 (_initialize_symtab): Register new 'info module functions' and
1924 'info module variables' commands.
1925 * symtab.h (typedef symbol_search_in_module): New typedef.
1926 (search_module_symbols): Declare new function.
1927 * NEWS: Mention new commands.
1928
19292019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1930
1931 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1932 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1933 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1934 MODULES_DOMAIN.
1935 (scan_partial_symbols): Only create partial module symbols for non
1936 declarations.
1937 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1938 and MODULES_DOMAIN.
1939 * symtab.c (search_domain_name): Likewise.
1940 (search_symbols): Likewise.
1941 (print_symbol_info): Likewise.
1942 (symtab_symbol_info): Likewise.
1943 (info_modules_command): New function.
1944 (_initialize_symtab): Register 'info modules' command.
1945 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1946 * NEWS: Mention new 'info modules' command.
1947
19482019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1949
1950 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1951 and $_gdb_maint_setting_str.
1952
19532019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1954
1955 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1956 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1957 (str_value_from_setting, gdb_setting_str_internal_fn)
1958 (gdb_maint_setting_str_internal_fn): New functions.
1959 (_initialize_cli_cmds): Define the new convenience functions.
1960 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1961 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1962
19632019-10-31 Christian Biesinger <cbiesinger@google.com>
1964
1965 * agent.c (set_can_use_agent): When the setting is turned on,
1966 look up agent symbols if we don't have them yet.
1967 (agent_new_objfile): Don't look up agent symbols when the agent
1968 setting is off.
1969
19702019-10-31 Christian Biesinger <cbiesinger@google.com>
1971
1972 * config.in: Regenerate.
1973
19742019-10-31 Christian Biesinger <cbiesinger@google.com>
1975
1976 * configure: Regenerate.
1977 * configure.ac: Check for strerror_r.
1978 * gdbsupport/common-utils.h (safe_strerror): Change return value
1979 to const char * and document that this function is now threadsafe.
1980 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1981 thread_local and call strerror_r, if available.
1982 * utils.c (perror_string): Update.
1983 (print_sys_errmsg): Update.
1984
19852019-10-31 Luis Machado <luis.machado@linaro.org>
1986
1987 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1988 objfile_key.
1989 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1990 objfile to fetch per-bfd data.
1991 (arm_find_exidx_entry): Likewise.
1992
19932019-10-31 Christian Biesinger <cbiesinger@google.com>
1994
1995 * gdbsupport/agent.c (debug_agent): Change type to bool.
1996 (use_agent): Likewise.
1997 (all_agent_symbols_look_up): Likewise.
1998 (agent_loaded_p): Change return value to bool.
1999 (agent_look_up_symbols): Update.
2000 (agent_capability_check): Change return value to bool.
2001 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2002 (debug_agent): Change type to bool.
2003 (use_agent): Likewise.
2004 (agent_capability_check): Change return value to bool.
2005
20062019-10-30 Christian Biesinger <cbiesinger@google.com>
2007
2008 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2009 (build_minimal_symbol_hash_tables): Code to clear the table moved
2010 to clear_minimal_symbol_hash_tables.
2011 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2012 when needed.
2013
20142019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2015
2016 * infcmd.c: Remove includes.
2017 * infrun.c: Remove includes.
2018
20192019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2020
2021 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2022 (grow_vect): Remove declaration.
2023 (ada_type_of_array): Remove declaration.
2024 (ada_update_initial_language): Remove declaration.
2025 (ada_fold_name): Remove declaration.
2026 (ada_fill_in_ada_prototype): Remove declaration.
2027 (user_select_syms): Remove declaration.
2028 (get_selections): Remove declaration.
2029 (ada_tag_type): Remove declaration.
2030 (ada_value_tag): Remove declaration.
2031 (ada_is_others_clause): Remove declaration.
2032 (ada_in_variant): Remove declaration.
2033 (ada_value_struct_elt): Remove declaration.
2034 (ada_attribute_name): Remove declaration.
2035 (ada_system_address_type): Remove declaration.
2036 * ada-lang.c (ada_watch_location_expression): Make static.
2037 (GROW_VECT): Move here from ada-lang.h.
2038 (grow_vect): Make static.
2039 (ada_update_initial_language): Make static.
2040 (ada_fold_name): Make static.
2041 (ada_type_of_array): Make static.
2042 (encoded_ordered_before): Move up.
2043 (sort_choices): Move up.
2044 (print_signatures): Move up.
2045 (ada_print_symbol_signature): Move up.
2046 (get_selections): Move up and make static.
2047 (user_select_syms): Move up and make static.
2048 (ada_value_struct_elt): Move up and make static.
2049 (ada_tag_type): Make static.
2050 (ada_value_tag): Make static.
2051 (ada_is_others_clause): Make static.
2052 (ada_in_variant): Make static.
2053 (ada_attribute_name): Make static.
2054
20552019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2056
2057 * ada-lang.c: Remove includes.
2058 * ada-typeprint.c: Remove includes.
2059 * ada-valprint.c: Remove includes.
2060
20612019-10-29 Simon Marchi <simon.marchi@efficios.com>
2062
2063 * addrmap.c: Add static assertions of type size, moved from
2064 _initialize_addrmap.
2065 (_initialize_addrmap): Remove.
2066
20672019-10-29 Christian Biesinger <cbiesinger@google.com>
2068
2069 * coffread.c (record_minimal_symbol): Update.
2070 (process_coff_symbol): Update.
2071 * dbxread.c (read_dbx_symtab): Update.
2072 * dwarf2read.c (add_partial_symbol): Update.
2073 (fixup_go_packaging): Update.
2074 (load_partial_dies): Update.
2075 (new_symbol): Update.
2076 * elfread.c (record_minimal_symbol): Change signature to use
2077 gdb::string_view instead of name+len.
2078 (elf_symtab_read): Update.
2079 (elf_rel_plt_read): Update.
2080 * mdebugread.c (parse_partial_symbols): Update.
2081 (handle_psymbol_enumerators): Update.
2082 (new_symbol): Update.
2083 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2084 to use gdb::string_view instead of name+len.
2085 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2086 * psympriv.h (add_psymbol_to_list): Likewise.
2087 * psymtab.c (add_psymbol_to_bcache): Likewise.
2088 (add_psymbol_to_list): Likewise.
2089 * stabsread.c (define_symbol): Update.
2090 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2091 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2092 (symbol_set_names): Likewise.
2093 * xcoffread.c (scan_xcoff_symtab): Update.
2094
20952019-10-29 Christian Biesinger <cbiesinger@google.com>
2096
2097 * symtab.h (symbol_set_names): Document that copy_name must be
2098 set to true for non-nullterminated strings.
2099 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2100 linkage_name if the entry was not found and we need to demangle.
2101
21022019-10-29 Christian Biesinger <cbiesinger@google.com>
2103
2104 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2105 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2106 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2107 * gdbsupport/gdb_binary_search.h: New file.
2108
21092019-10-29 Christian Biesinger <cbiesinger@google.com>
2110
2111 * NEWS: Mention new --with-system-gdbinit-dir option.
2112 * config.in: Regenerate.
2113 * configure: Regenerate.
2114 * configure.ac: Add new option --with-system-gdbinit-dir.
2115 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2116 for a ".gdb" suffix.
2117 * main.c (get_init_files): Change system_gdbinit argument to
2118 a vector and return the files in SYSTEM_GDBINIT_DIR in
2119 addition to SYSTEM_GDBINIT.
2120 (captured_main_1): Update.
2121 (print_gdb_help): Update.
2122 * top.c (print_gdb_configuration): Also print the value of
2123 SYSTEM_GDBINIT_DIR.
2124
21252019-10-28 Christian Biesinger <cbiesinger@google.com>
2126
2127 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2128 that takes gdb::string_view arguments.
2129
21302019-10-26 Tom de Vries <tdevries@suse.de>
2131
2132 * aarch64-linux-tdep.c: Fix typos in comments.
2133 * aarch64-tdep.c: Same.
2134 * ada-lang.c: Same.
2135 * amd64-nat.c: Same.
2136 * arc-tdep.c: Same.
2137 * arch/aarch64-insn.c: Same.
2138 * block.c: Same.
2139 * breakpoint.h: Same.
2140 * btrace.h: Same.
2141 * c-varobj.c: Same.
2142 * cli/cli-decode.c: Same.
2143 * cli/cli-script.c: Same.
2144 * cli/cli-utils.h: Same.
2145 * coff-pe-read.c: Same.
2146 * coffread.c: Same.
2147 * compile/compile-cplus-symbols.c: Same.
2148 * compile/compile-object-run.c: Same.
2149 * completer.c: Same.
2150 * corelow.c: Same.
2151 * cp-support.c: Same.
2152 * demangle.c: Same.
2153 * dwarf-index-write.c: Same.
2154 * dwarf2-frame.c: Same.
2155 * dwarf2-frame.h: Same.
2156 * eval.c: Same.
2157 * frame-base.h: Same.
2158 * frame.h: Same.
2159 * gdbcmd.h: Same.
2160 * gdbtypes.h: Same.
2161 * gnu-nat.c: Same.
2162 * guile/scm-objfile.c: Same.
2163 * i386-tdep.c: Same.
2164 * i386-tdep.h: Same.
2165 * infcall.c: Same.
2166 * infcall.h: Same.
2167 * linux-nat.c: Same.
2168 * m68k-tdep.c: Same.
2169 * macroexp.c: Same.
2170 * memattr.c: Same.
2171 * mi/mi-cmd-disas.c: Same.
2172 * mi/mi-getopt.h: Same.
2173 * mi/mi-main.c: Same.
2174 * minsyms.c: Same.
2175 * nat/aarch64-sve-linux-sigcontext.h: Same.
2176 * objfiles.h: Same.
2177 * ppc-linux-nat.c: Same.
2178 * ppc-linux-tdep.c: Same.
2179 * ppc-tdep.h: Same.
2180 * progspace.h: Same.
2181 * prologue-value.h: Same.
2182 * python/py-evtregistry.c: Same.
2183 * python/py-instruction.h: Same.
2184 * record-btrace.c: Same.
2185 * record-full.c: Same.
2186 * remote.c: Same.
2187 * rs6000-tdep.c: Same.
2188 * ser-tcp.c: Same.
2189 * sol-thread.c: Same.
2190 * sparc-sol2-tdep.c: Same.
2191 * sparc64-tdep.c: Same.
2192 * stabsread.c: Same.
2193 * symfile.c: Same.
2194 * symtab.h: Same.
2195 * target.c: Same.
2196 * tracepoint.c: Same.
2197 * tui/tui-data.h: Same.
2198 * tui/tui-io.c: Same.
2199 * tui/tui-win.c: Same.
2200 * tui/tui.c: Same.
2201 * unittests/rsp-low-selftests.c: Same.
2202 * user-regs.h: Same.
2203 * utils.c: Same.
2204 * utils.h: Same.
2205 * valarith.c: Same.
2206 * valops.c: Same.
2207 * valprint.c: Same.
2208 * valprint.h: Same.
2209 * value.c: Same.
2210 * value.h: Same.
2211 * varobj.c: Same.
2212 * x86-nat.h: Same.
2213 * xtensa-tdep.c: Same.
2214
22152019-10-25 Ali Tamur <tamur@google.com>
2216
2217 * charset.c (find_charset_names): Reflect API change.
2218
22192019-10-25 Christian Biesinger <cbiesinger@google.com>
2220
2221 * symtab.c (struct demangled_name_entry): Change demangled name
2222 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2223 part of the struct anymore.
2224 (symbol_set_names): No longer obstack allocate + copy the demangled
2225 name, just store the allocated name from bfd.
2226
22272019-10-25 Tom Tromey <tromey@adacore.com>
2228
2229 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2230 (bsearch_cie_cmp, add_cie): Remove.
2231 (find_cie): Reimplement.
2232 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2233 (dwarf2_build_frame_info): Update.
2234
22352019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2236
2237 PR gdb/25126
2238 * symfile.c (reread_symbols): Call forget_cached_source_info to
2239 clear the stale source cache.
2240
22412019-10-24 Christian Biesinger <cbiesinger@google.com>
2242
2243 * configure: Regenerate.
2244 * configure.ac: Remove code that sets python_has_threads.
2245
22462019-10-24 Christian Biesinger <cbiesinger@google.com>
2247
2248 * config.in: Regenerate.
2249 * configure: Regenerate.
2250 * configure.ac: Remove the code that uses sed to get the python
2251 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2252
22532019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2254
2255 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2256 error paths.
2257
22582019-10-23 Tom Tromey <tom@tromey.com>
2259
2260 * arc-tdep.c: Remove ".." from include.
2261 * frv-tdep.c: Remove ".." from include.
2262 * lm32-tdep.c: Remove ".." from include.
2263 * microblaze-tdep.c: Remove ".." from include.
2264 * or1k-tdep.h: Remove ".." from include.
2265 * s12z-tdep.c: Remove ".." from include.
2266 * Makefile.in (OPCODES_CFLAGS): Add comment.
2267 (TOP_CFLAGS): New variable.
2268 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2269
22702019-10-23 Tom Tromey <tom@tromey.com>
2271
2272 * Makefile.in (READLINE_DIR): Update.
2273
22742019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2275
2276 * infcall.c (call_function_by_hand_dummy): Fix the function
2277 comment. And extract out a code section into...
2278 (reserve_stack_space): ...this new function.
2279
22802019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2281
2282 * infcall.c (value_arg_coerce): Remove an unused parameter.
2283 (call_function_by_hand_dummy): Update the call to
2284 'value_arg_coerce'.
2285
22862019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2287
2288 * infcall.c (call_function_by_hand_dummy): Refactor.
2289
22902019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2291
2292 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2293
22942019-10-23 Tom Tromey <tom@tromey.com>
2295
2296 * configure: Rebuild.
2297 * configure.ac: Don't check for sigprocmask.
2298 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2299
23002019-10-23 Tom Tromey <tom@tromey.com>
2301
2302 * configure: Rebuild.
2303 * acinclude.m4: Use m4_include, not sinclude.
2304
23052019-10-23 Tom de Vries <tdevries@suse.de>
2306
2307 PR breakpoints/24687
2308 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2309
23102019-10-22 Christian Biesinger <cbiesinger@google.com>
2311
2312 * symtab.c (struct demangled_name_entry) <language>: Change from
2313 bitfield to regular variable.
2314
23152019-10-22 Christian Biesinger <cbiesinger@google.com>
2316
2317 * symtab.c (struct demangled_name_entry): Add a constructor.
2318 (free_demangled_name_entry): New function to call the destructor
2319 for demangled_name_entry.
2320 (create_demangled_names_hash): Pass free_demangled_name_entry to
2321 htab_create_alloc.
2322 (symbol_set_names): Call placement new for demangled_name_entry.
2323 * utils.c: No longer include xxhash.h here, now that fast_hash
2324 is inlined in the header.
2325 * utils.h: Instead, include it here.
2326
23272019-10-22 Christian Biesinger <cbiesinger@google.com>
2328
2329 * Makefile.in: Link with libxxhash.
2330 * config.in: Regenerate.
2331 * configure: Regenerate.
2332 * configure.ac: Search for libxxhash.
2333 * utils.c (fast_hash): Use xxhash if present.
2334
23352019-10-22 Christian Biesinger <cbiesinger@google.com>
2336
2337 * utils.h (fast_hash): New function.
2338 * symtab.c (hash_demangled_name_entry): Call new function
2339 fast_hash.
2340
23412019-10-22 Christian Biesinger <cbiesinger@google.com>
2342
2343 * symtab.c (struct demangled_name_entry): Change type of mangled
2344 to gdb::string_view. Also adds a constructor that takes the
2345 mangled name.
2346 (hash_demangled_name_entry): Update.
2347 (eq_demangled_name_entry): Update.
2348 (free_demangled_name_entry): New function to call the destructor
2349 now that this is not a POD anymore.
2350 (create_demangled_names_hash): Pass free_demangled_name_entry to
2351 htab_create_alloc.
2352 (symbol_set_names): Update.
2353
23542019-10-21 Ali Tamur <tamu@google.com>
2355
2356 * dwarf2read.c (dir_index): Change type.
2357 (file_name_index): Likewise.
2358 (line_header::include_dir_at): Change comment and implementation on
2359 whether it is DWARF 5.
2360 (line_header::is_valid_file_index): New function.
2361 (line_header::file_name_at): Change comment and implementation on
2362 whether it is DWARF 5.
2363 (line_header::file_names): Change to private field renamed as
2364 m_file_names and introduce a new accessor method.
2365 (line_header::file_names_size): New method.
2366 (line_header::include_dirs): Change to private field and rename as
2367 m_include_dirs.
2368 (dw2_get_file_names_reader): Define local var at a smaller scope and
2369 reflect API change.
2370 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2371 (process_structure_scope): Likewise.
2372 (line_header::add_include_dir): Change message and reflect renaming.
2373 (line_header::add_file_name): Likewise.
2374 (read_formatted_entries): Handle DW_FORM_data16.
2375 (dwarf_decode_line_header): Fix line header length calculation.
2376 (psymtab_include_file_name): Change comment and API.
2377 (lnp_state_machine::m_file): Update comment and reflect type change.
2378 (lnp_state_machine::record_line): Reflect type change.
2379 (dwarf_decode_lines): Reflect API change.
2380 (file_file_name): Likewise.
2381 (file_full_name): Likewise.
2382
23832019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2384
2385 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2386
23872019-10-21 Tom Tromey <tom@tromey.com>
2388
2389 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2390
23912019-10-21 Tom Tromey <tom@tromey.com>
2392
2393 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2394 NM_H. Use AC_CONFIG_LINKS.
2395 * configure: Rebuild.
2396 * Makefile.in (NM_H): New variable.
2397 (generated_files): Add NM_H. Remove gcore.
2398 (nm.h, stamp-nmh): New targets.
2399
24002019-10-20 Tom Tromey <tom@tromey.com>
2401
2402 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2403 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2404 obsolete comment.
2405 (put_objfile_before): Now static.
2406
24072019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2408
2409 * gdbsupport/common-utils.h (startswith): Change return type to
2410 bool.
2411
24122019-10-19 Christian Biesinger <cbiesinger@google.com>
2413
2414 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2415 * breakpoint.c (bp_locations_compare): Rename to...
2416 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2417 (update_global_location_list): Use std::sort instead of qsort.
2418 * buildsym.c (compare_line_numbers): Rename to...
2419 (lte_is_less_than): ...this, and change to std::sort semantics.
2420 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2421 instead of qsort.
2422 * disasm.c (compare_lines): Rename to...
2423 (line_is_less_than): ...this, and change to std::sort semantics.
2424 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2425 of qsort.
2426 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2427 (fde_is_less_than): ...this, and change to std::sort semantics.
2428 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2429 * mdebugread.c (compare_blocks):
2430 (block_is_less_than): ...this, and change to std::sort semantics.
2431 (sort_blocks): Call std::sort instead of qsort.
2432 * objfiles.c (qsort_cmp): Rename to...
2433 (sort_cmp): ...this, and change to std::sort semantics.
2434 (update_section_map): Call std::sort instead of qsort.
2435 * remote.c (compare_pnums): Remove.
2436 (map_regcache_remote_table): Call std::sort instead of qsort.
2437 * utils.c (compare_positive_ints): Remove.
2438 * utils.h (compare_positive_ints): Remove.
2439 * xcoffread.c (compare_lte): Remove.
2440 (arrange_linetable): Call std::sort instead of qsort.
2441
24422019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2443
2444 * symfile.c (init_entry_point_info): Fix typo.
2445 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2446
24472019-10-18 Tom de Vries <tdevries@suse.de>
2448
2449 * aarch64-tdep.c: Fix typos in comments.
2450 * ada-lang.c: Same.
2451 * ada-tasks.c: Same.
2452 * alpha-tdep.c: Same.
2453 * alpha-tdep.h: Same.
2454 * amd64-nat.c: Same.
2455 * amd64-windows-tdep.c: Same.
2456 * arc-tdep.c: Same.
2457 * arc-tdep.h: Same.
2458 * arch-utils.c: Same.
2459 * arm-nbsd-tdep.c: Same.
2460 * arm-tdep.c: Same.
2461 * ax-gdb.c: Same.
2462 * blockframe.c: Same.
2463 * btrace.c: Same.
2464 * c-varobj.c: Same.
2465 * coff-pe-read.c: Same.
2466 * coffread.c: Same.
2467 * cris-tdep.c: Same.
2468 * darwin-nat.c: Same.
2469 * dbxread.c: Same.
2470 * dcache.c: Same.
2471 * disasm.c: Same.
2472 * dtrace-probe.c: Same.
2473 * dwarf-index-write.c: Same.
2474 * dwarf2-frame-tailcall.c: Same.
2475 * dwarf2-frame.c: Same.
2476 * dwarf2read.c: Same.
2477 * eval.c: Same.
2478 * exceptions.c: Same.
2479 * fbsd-tdep.c: Same.
2480 * findvar.c: Same.
2481 * frame.c: Same.
2482 * frv-tdep.c: Same.
2483 * gnu-v3-abi.c: Same.
2484 * go32-nat.c: Same.
2485 * h8300-tdep.c: Same.
2486 * hppa-tdep.c: Same.
2487 * i386-linux-tdep.c: Same.
2488 * i386-tdep.c: Same.
2489 * ia64-libunwind-tdep.c: Same.
2490 * ia64-tdep.c: Same.
2491 * infcmd.c: Same.
2492 * infrun.c: Same.
2493 * linespec.c: Same.
2494 * linux-nat.c: Same.
2495 * linux-thread-db.c: Same.
2496 * machoread.c: Same.
2497 * mdebugread.c: Same.
2498 * mep-tdep.c: Same.
2499 * mn10300-tdep.c: Same.
2500 * namespace.c: Same.
2501 * objfiles.c: Same.
2502 * opencl-lang.c: Same.
2503 * or1k-tdep.c: Same.
2504 * osabi.c: Same.
2505 * ppc-linux-nat.c: Same.
2506 * ppc-linux-tdep.c: Same.
2507 * ppc-sysv-tdep.c: Same.
2508 * printcmd.c: Same.
2509 * procfs.c: Same.
2510 * record-btrace.c: Same.
2511 * record-full.c: Same.
2512 * remote-fileio.c: Same.
2513 * remote.c: Same.
2514 * rs6000-tdep.c: Same.
2515 * s12z-tdep.c: Same.
2516 * score-tdep.c: Same.
2517 * ser-base.c: Same.
2518 * ser-go32.c: Same.
2519 * skip.c: Same.
2520 * sol-thread.c: Same.
2521 * solib-svr4.c: Same.
2522 * solib.c: Same.
2523 * source.c: Same.
2524 * sparc-nat.c: Same.
2525 * sparc-sol2-tdep.c: Same.
2526 * sparc-tdep.c: Same.
2527 * sparc64-tdep.c: Same.
2528 * stabsread.c: Same.
2529 * stack.c: Same.
2530 * symfile.c: Same.
2531 * symtab.c: Same.
2532 * target-descriptions.c: Same.
2533 * target-float.c: Same.
2534 * thread.c: Same.
2535 * utils.c: Same.
2536 * valops.c: Same.
2537 * valprint.c: Same.
2538 * value.c: Same.
2539 * varobj.c: Same.
2540 * windows-nat.c: Same.
2541 * xcoffread.c: Same.
2542 * xstormy16-tdep.c: Same.
2543 * xtensa-tdep.c: Same.
2544
25452019-10-17 Tom Tromey <tromey@adacore.com>
2546
2547 * configure: Rebuild.
2548 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2549 in AC_CONFIG_FILES invocation.
2550 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2551 new-style config.status invocation.
2552
25532019-10-17 Tom de Vries <tdevries@suse.de>
2554
2555 * arm-nbsd-nat.c: Fix typos in comments.
2556 * arm-tdep.c: Same.
2557 * darwin-nat-info.c: Same.
2558 * dwarf2read.c: Same.
2559 * elfread.c: Same.
2560 * event-top.c: Same.
2561 * findvar.c: Same.
2562 * gdbtypes.c: Same.
2563 * hppa-tdep.c: Same.
2564 * i386-tdep.c: Same.
2565 * jit.c: Same.
2566 * main.c: Same.
2567 * mdebugread.c: Same.
2568 * moxie-tdep.c: Same.
2569 * nto-procfs.c: Same.
2570 * osabi.c: Same.
2571 * ppc-linux-tdep.c: Same.
2572 * remote.c: Same.
2573 * riscv-tdep.c: Same.
2574 * s390-tdep.c: Same.
2575 * sh-tdep.c: Same.
2576 * sparc-linux-tdep.c: Same.
2577 * sparc-nat.c: Same.
2578 * stack.c: Same.
2579 * target-descriptions.c: Same.
2580 * top.c: Same.
2581 * varobj.c: Same.
2582
25832019-10-16 Tom Tromey <tom@tromey.com>
2584
2585 * objfiles.h (struct objfile) <original_name>: Now const.
2586
25872019-10-16 Christian Biesinger <cbiesinger@google.com>
2588
2589 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2590 pass on to sigsetjmp's second argument.
2591 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2592
25932019-10-16 Keith Seitz <keiths@redhat.com>
2594
2595 PR gdb/23567
2596 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2597 sections whose size is greater than the file size.
2598
25992019-10-16 Jim Wilson <jimw@sifive.com>
2600
2601 * riscv-tdep.c (riscv_gcc_target_options): New.
2602 (riscv_gnu_triplet_regexp): New.
2603 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2604 set_gdbarch_gnu_triplet_regexp.
2605
26062019-10-16 Christian Biesinger <cbiesinger@google.com>
2607
2608 * Makefile.in: Add xml-builtin.h.
2609 * features/feature_to_c.sh: Add an include for xml-builtin.h
2610 to ensure that the compiler checks that the types match.
2611 * xml-builtin.h: New file.
2612 * xml-support.c (fetch_xml_builtin): Add missing const.
2613 * xml-support.h: Remove declaration of xml_builtins.
2614
26152019-10-16 Tom de Vries <tdevries@suse.de>
2616
2617 PR tdep/25096
2618 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2619 (amd64_classify_aggregate): ... here.
2620 (amd64_classify_aggregate_field): Handled fiels of nested structs
2621 recursively.
2622
26232019-10-16 Tom de Vries <tdevries@suse.de>
2624
2625 PR tdep/24104
2626 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2627 that handles 'theclass'.
2628
26292019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2630
2631 * linespec.c (decode_digits_ordinary): Update comment.
2632 * make-target-delegates: No longer need to handle VEC case.
2633 * memrange.c (normalize_mem_ranges): Update comment.
2634 * namespace.c (add_using_directive): Update comment.
2635 * objc-lang.c (uniquify_strings): Update comment.
2636 * ppc-linux-nat.c (struct thread_points): Update comment.
2637 * probe.h (find_probes_in_objfile): Update comment.
2638 * target.h (enum flash_preserve_mode): Update comment.
2639 * varobj.c (varobj_restrict_range): Update comment.
2640 * varobj.h (varobj_list_children): Update comment.
2641
26422019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2643
2644 * Makefile.in: Remove references to vec.h and vec.c.
2645 * aarch64-tdep.c: No longer include vec.h.
2646 * ada-lang.c: Likewise.
2647 * ada-lang.h: Likewise.
2648 * arm-tdep.c: Likewise.
2649 * ax.h: Likewise.
2650 * breakpoint.h: Likewise.
2651 * charset.c: Likewise.
2652 * cp-support.h: Likewise.
2653 * dtrace-probe.c: Likewise.
2654 * dwarf2read.c: Likewise.
2655 * extension.h: Likewise.
2656 * gdb_bfd.c: Likewise.
2657 * gdbsupport/gdb_vecs.h: Likewise.
2658 * gdbsupport/vec.c: Remove.
2659 * gdbsupport/vec.h: Remove.
2660 * gdbthread.h: Likewise.
2661 * guile/scm-type.c: Likewise.
2662 * inline-frame.c: Likewise.
2663 * machoread.c: Likewise.
2664 * memattr.c: Likewise.
2665 * memrange.h: Likewise.
2666 * namespace.h: Likewise.
2667 * nat/linux-btrace.h: Likewise.
2668 * osdata.c: Likewise.
2669 * parser-defs.h: Likewise.
2670 * progspace.h: Likewise.
2671 * python/py-type.c: Likewise.
2672 * record-btrace.c: Likewise.
2673 * rust-exp.y: Likewise.
2674 * solib-target.c: Likewise.
2675 * stap-probe.c: Likewise.
2676 * target-descriptions.c: Likewise.
2677 * target-memory.c: Likewise.
2678 * target.h: Likewise.
2679 * varobj.c: Likewise.
2680 * varobj.h: Likewise.
2681 * xml-support.h: Likewise.
2682
26832019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2684
2685 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2686 Update for new std::vector based implementation.
2687 (process_psymtab_comp_unit_reader): Likewise.
2688 (scan_partial_symbols): Likewise.
2689 (recursively_compute_inclusions): Likewise.
2690 (compute_compunit_symtab_includes): Likewise.
2691 (process_imported_unit_die): Likewise.
2692 (queue_and_load_dwo_tu): Likewise.
2693 (follow_die_sig_1): Likewise.
2694 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2695 (typedef dwarf2_per_cu_ptr): Remove.
2696 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2697 function.
2698 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2699 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2700 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2701 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2702 std::vector.
2703
27042019-10-15 Tom Tromey <tromey@adacore.com>
2705
2706 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2707 TID.
2708
27092019-10-15 Tom Tromey <tromey@adacore.com>
2710
2711 * windows-nat.c (windows_nat_target::fetch_registers)
2712 (windows_nat_target::store_registers): Rename "pid" to "tid".
2713
27142019-10-15 Tom Tromey <tromey@adacore.com>
2715
2716 * gdbarch.h, gdbarch.c: Rebuild.
2717 * gdbarch.sh (gcc_target_options): Change return type to
2718 std::string.
2719 * compile/compile.c (get_args): Update.
2720 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2721 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2722 std::string.
2723 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2724 std::string.
2725 * arch-utils.c (default_gcc_target_options): Return std::string.
2726 * arch-utils.h (default_gcc_target_options): Return std::string.
2727 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2728
27292019-10-15 Christian Biesinger <cbiesinger@google.com>
2730
2731 * breakpoint.c (breakpoint_chain): Make static.
2732 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2733 of accessing breakpoint_chain.
2734
27352019-10-15 Christian Biesinger <cbiesinger@google.com>
2736
2737 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2738 to a gdb::function_view and return value to bool.
2739 * breakpoint.h (iterate_over_breakpoints): Likewise.
2740 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2741 (pop_dummy_frame): Update.
2742 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2743 (gdbscm_breakpoints): Update.
2744 * python/py-breakpoint.c (build_bp_list): Update.
2745 (gdbpy_breakpoints): Update.
2746 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2747 Update.
2748 (bpfinishpy_handle_stop): Update.
2749 (bpfinishpy_handle_exit): Update.
2750 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2751 (svr4_update_solib_event_breakpoints): Update.
2752
27532019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2754
2755 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2756 when unwrapping single-field structs.
2757
27582019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2759
2760 * dwarf2read.c: Remove includes.
2761
27622019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2763
2764 * ui-out.c (ui_out::call_do_message): Silence
2765 -Wformat-nonliteral warning.
2766
27672019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2768
2769 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2770 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2771 include: readline/tilde.h.
2772
27732019-10-12 Christian Biesinger <cbiesinger@google.com>
2774
2775 * remote.c (remote_target::get_trace_status): Remove declaration of
2776 trace_regblock_size.
2777
27782019-10-12 Christian Biesinger <cbiesinger@google.com>
2779
2780 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2781 (show_user): Remove declaration of cmdlist.
2782 * cli/cli-cmds.h (max_user_call_depth): Declare.
2783 * cli/cli-script.c (execute_user_command): Remove declaration
2784 of max_user_call_depth.
2785
27862019-10-11 Jim Wilson <jimw@sifive.com>
2787
2788 * gdbsupport/print-utils.h (pulongest): Fix comment.
2789 (plongest): Likewise.
2790 (phex): Add missing comment, mention leading zeros.
2791 (phex_nz): Add mention of no leading zeros to comment.
2792
2793 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2794 plongest instead of unsigned long long cast.
2795
27962019-10-10 Christian Biesinger <cbiesinger@google.com>
2797
2798 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2799 for external_editor_command and gdbtk_test.
2800
28012019-10-10 Christian Biesinger <cbiesinger@google.com>
2802
2803 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2804 * varobj.c (varobjdebug): Move comment to...
2805 * varobj.h (varobjdebug): ...here, and declare.
2806
28072019-10-09 Tom Tromey <tom@tromey.com>
2808
2809 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2810 erase_data_content.
2811
28122019-10-09 Tom Tromey <tom@tromey.com>
2813
2814 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2815 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2816 * tui/tui-command.c (tui_cmd_window::resize)
2817 (tui_refresh_cmd_win): Update.
2818 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2819 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2820 * tui/tui-data.c (~tui_gen_win_info): Remove.
2821 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2822 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2823 (tui_redisplay_readline, tui_mld_flush)
2824 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2825 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2826 (tui_data_window::erase_data_content)
2827 (tui_data_item_window::rerender)
2828 (tui_data_item_window::refresh_window): Update.
2829 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2830 (box_win, tui_gen_win_info::make_window)
2831 (tui_gen_win_info::make_visible): Update.
2832 (tui_delete_win): Remove.
2833 * tui/tui-winsource.c
2834 (tui_source_window_base::do_erase_source_content): Update.
2835 (tui_show_source_line, tui_source_window_base::update_tab_width)
2836 (tui_source_window_base::update_exec_info): Update.
2837 * tui/tui-data.h (struct curses_deleter): New.
2838 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2839 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2840
28412019-10-09 Tom Tromey <tom@tromey.com>
2842
2843 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2844
28452019-10-09 Tom Tromey <tom@tromey.com>
2846
2847 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2848 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2849
28502019-10-09 Tom Tromey <tom@tromey.com>
2851
2852 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2853 window height directly.
2854 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2855 declare.
2856 * tui/tui-layout.c (tui_default_win_height): Remove.
2857 (tui_default_win_viewport_height): Remove.
2858
28592019-10-09 Tom Tromey <tom@tromey.com>
2860
2861 * tui/tui.h: Remove comments.
2862
28632019-10-09 Tom de Vries <tdevries@suse.de>
2864
2865 * python/lib/gdb/printer/bound_registers.py: Use
2866 '^builtin_type_bound128' as regexp argument for
2867 add_builtin_pretty_printer.
2868
28692019-10-09 Christian Biesinger <cbiesinger@google.com>
2870
2871 * guile/guile.c (guile_extension_script_ops): Remove forward
2872 declaration and mark as static.
2873 (guile_script_ops): Likewise.
2874 (extension_language_guile): Move further down in the file so
2875 it can reference the definitions for guile_{extension_,}script_ops.
2876
28772019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2878
2879 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2880 except SORTL, DFLTCC, and KDSA.
2881
28822019-10-08 Tom Tromey <tromey@adacore.com>
2883
2884 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2885 (struct safe_symbol_file_add_args): Remove.
2886
28872019-10-08 Tom Tromey <tromey@adacore.com>
2888
2889 * windows-nat.c: Don't include buildsym-legacy.h.
2890
28912019-10-08 Tom Tromey <tromey@adacore.com>
2892
2893 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2894
28952019-10-08 Christian Biesinger <cbiesinger@google.com>
2896
2897 * gdbtypes.c (overload_debug): Move comment to header.
2898 * gdbtypes.h (overload_debug): Declare.
2899 * valops.c: Remove declaration of overload_debug, instead
2900 include gdbtypes.h.
2901
29022019-10-08 Christian Biesinger <cbiesinger@google.com>
2903
2904 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2905 through _().
2906 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2907 move comment...
2908 * language.h (lang_frame_mismatch_warn): ... here. Also add
2909 declaration.
2910 * top.c (lang_frame_mismatch_warn): Remove declaration.
2911 (check_frame_language_change): Pass lang_frame_mismatch_warn
2912 through _().
2913
29142019-10-07 Christian Biesinger <cbiesinger@google.com>
2915
2916 * c-lang.h (vtbl_ptr_name): Declare.
2917 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2918 it from the header.
2919 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2920
29212019-10-07 Christian Biesinger <cbiesinger@google.com>
2922
2923 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2924 gdb_static_assert.
2925
29262019-10-07 Weimin Pan <weimin.pan@oracle.com>
2927
2928 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2929 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2930 * ctfread.c: New file.
2931 * ctfread.h: New file.
2932 * elfread.c: Include ctfread.h.
2933 (struct elfinfo text_p): New member ctfsect.
2934 (elf_locate_sections): Mark CTF section.
2935 (elf_symfile_read): Call elfctf_build_psymtabs.
2936 * Makefile.in (LIBCTF): Add.
2937 (CLIBS): Use it.
2938 (CDEPS): Likewise.
2939 (DIST): Add ctfread.c.
2940
29412019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2942
2943 * ctfread.c (struct nextfield): Renamed to ...
2944 (struct ctf_nextfield): ... this.
2945 (struct field_info): Renamed to ...
2946 (strut ctf_field_info): ... this.
2947 (attach_fields_to_type): Update for renamed structures.
2948 (ctf_add_member_cb): Likewise.
2949 (ctf_add_enum_member_cb): Likewise.
2950 (process_struct_members): Likewise.
2951 (process_enum_type): Likewise.
2952
29532019-10-07 Weimin Pan <weimin.pan@oracle.com>
2954
2955 * tracectf.h: Rename, was ctf.h.
2956 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2957 * tracefile.c: Likewise.
2958 * tracepoint.c: Remove unused include ctf.h.
2959 * mi/mi-main.c: Likewise.
2960 * Makefile.in Replace ctf.c with tracectf.c.
2961
29622019-10-06 Joel Brobecker <brobecker@adacore.com>
2963
2964 * version.in: Change version number to "9.0.50.DATE-git".
2965
29662019-10-03 Tom Tromey <tom@tromey.com>
2967
2968 PR rust/24976:
2969 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2970
29712019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2972
2973 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2974 cp_search_name_hash.
2975 * NEWS: Add entry about nested function support.
2976
29772019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2978 Andrew Burgess <andrew.burgess@embecosm.com>
2979
2980 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2981 for nested static variables when searchin VAR_DOMAIN.
2982 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2983 global scope, update comment.
2984 (add_partial_subprogram): Call add_partial_subprogram recursively
2985 for nested subroutines when processinng Fortran.
2986 (load_partial_dies): Process the child entities of a subprogram
2987 when processing Fortran.
2988 (partial_die_parent_scope): Handle building scope
2989 for Fortran nested functions.
2990 (process_die): Record that nested functions have a scope.
2991 (new_symbol): Always record Fortran subprograms on the global
2992 symbol list.
2993 (determine_prefix): How to build the prefix for Fortran
2994 subprograms.
2995
29962019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2997
2998 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2999 have just sent the thread a SIGSTOP and are waiting for it to
3000 arrive.
3001
30022019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3003
3004 * btrace.c (btrace_add_pc): Remove whitespace before the template
3005 parameter in 'std::vector <...>'.
3006 (parse_xml_btrace_block): Likewise.
3007 (btrace_maint_decode_pt): Likewise.
3008 (btrace_maint_update_packets): Likewise.
3009 (btrace_maint_print_packets): Likewise.
3010 * btrace.h (struct btrace_maint_info): Likewise.
3011 * dwarf2read.c (struct type_unit_group): Likewise.
3012 (build_type_psymtabs_reader): Likewise.
3013 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3014 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3015 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3016
30172019-10-03 Tom de Vries <tdevries@suse.de>
3018
3019 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3020 the first line of the help text for set/show style metadata.
3021
30222019-10-02 Tom Tromey <tromey@adacore.com>
3023
3024 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3025 * gdbsupport/common-inferior.c: New file.
3026 * infcmd.c (startup_with_shell): Don't define.
3027 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3028 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3029 * inferior.h (startup_with_shell): Don't declare.
3030
30312019-10-02 Christian Biesinger <cbiesinger@google.com>
3032
3033 * gdbsupport/gdb_assert.h: Include errors.h.
3034 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3035
30362019-10-02 Tom Tromey <tromey@adacore.com>
3037
3038 * NEWS: Add $_ada_exception entry.
3039 * ada-lang.c (struct ada_catchpoint): Add constructor.
3040 <m_kind>: New member.
3041 (allocate_location_exception, re_set_exception): Remove
3042 "ex" parameter.
3043 (should_stop_exception): Compute $_ada_exception.
3044 (check_status_exception, print_it_exception)
3045 (print_one_exception, print_mention_exception): Remove
3046 "ex" parameter.
3047 (allocate_location_catch_exception, re_set_catch_exception)
3048 (check_status_exception, print_it_catch_exception)
3049 (print_one_catch_exception, print_mention_catch_exception)
3050 (print_recreate_catch_exception)
3051 (allocate_location_catch_exception_unhandled)
3052 (re_set_catch_exception_unhandled)
3053 (check_status_exception, print_it_catch_exception_unhandled)
3054 (print_one_catch_exception_unhandled)
3055 (print_mention_catch_exception_unhandled)
3056 (print_recreate_catch_exception_unhandled)
3057 (allocate_location_catch_assert, re_set_catch_assert)
3058 (check_status_assert, print_it_catch_assert)
3059 (print_one_catch_assert, print_mention_catch_assert)
3060 (print_recreate_catch_assert)
3061 (allocate_location_catch_handlers, re_set_catch_handlers)
3062 (check_status_handlers, print_it_catch_handlers)
3063 (print_one_catch_handlers, print_mention_catch_handlers)
3064 (print_recreate_catch_handlers): Remove.
3065 (create_ada_exception_catchpoint): Update.
3066 (initialize_ada_catchpoint_ops): Update.
3067
30682019-10-02 Tom Tromey <tromey@adacore.com>
3069
3070 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3071 (create_excep_cond_exprs): Simplify exception string computation.
3072 (ada_exception_catchpoint_cond_string): Likewise.
3073
30742019-10-02 Tom Tromey <tromey@adacore.com>
3075
3076 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3077 * ada-lang.c (lesseq_defined_than): Handle
3078 LOC_STATIC.
3079 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3080 parameter.
3081 (dwarf2_has_info): Likewise.
3082 (new_symbol): Set maybe_copied on symbol when
3083 appropriate.
3084 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3085 parameter.
3086 <can_copy>: New member.
3087 * elfread.c (record_minimal_symbol): Set maybe_copied
3088 on symbol when appropriate.
3089 (elf_symfile_read): Update call to dwarf2_has_info.
3090 * minsyms.c (lookup_minimal_symbol_linkage): New
3091 function.
3092 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3093 * symtab.c (get_symbol_address, get_msymbol_address):
3094 New functions.
3095 * symtab.h (get_symbol_address, get_msymbol_address):
3096 Declare.
3097 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3098 maybe_copied.
3099 (struct symbol, struct minimal_symbol) <maybe_copied>:
3100 New member.
3101
31022019-10-02 Tom Tromey <tromey@adacore.com>
3103
3104 * source.c (struct current_source_location): New.
3105 (current_source_key): New global.
3106 (current_source_symtab, current_source_line)
3107 (current_source_pspace): Remove.
3108 (get_source_location): New function.
3109 (get_current_source_symtab_and_line)
3110 (set_default_source_symtab_and_line)
3111 (set_current_source_symtab_and_line)
3112 (clear_current_source_symtab_and_line, select_source_symtab)
3113 (info_source_command, print_source_lines_base)
3114 (info_line_command, search_command_helper, _initialize_source):
3115 Update.
3116
31172019-10-02 Tom Tromey <tromey@adacore.com>
3118
3119 * source.c (select_source_symtab): Don't call
3120 decode_line_with_current_source.
3121
31222019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3123
3124 * symtab.c (lookup_global_symbol): Search global block.
3125
31262019-10-02 Tom Tromey <tromey@adacore.com>
3127
3128 * coffread.c (process_coff_symbol): Update.
3129 * dwarf2read.c (var_decode_location, new_symbol): Update.
3130 * mdebugread.c (parse_symbol): Update.
3131 * objfiles.c (relocate_one_symbol): Update.
3132 * stabsread.c (define_symbol, fix_common_block)
3133 (scan_file_globals): Update.
3134 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3135 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3136 * xcoffread.c (process_xcoff_symbol): Update.
3137
31382019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3139
3140 * MAINTAINERS: Update my email address.
3141
31422019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3143
3144 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3145 std::vector.
3146 (build_type_psymtabs_reader): Update for std::vector.
3147 (build_type_psymtab_dependencies): Likewise.
3148 * dwarf2read.h: Remove use of DEF_VEC_P.
3149 (typedef sig_type_ptr): Delete.
3150
31512019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3152
3153 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3154 to std::vector.
3155 (btrace_maint_decode_pt): Likewise, and move allocation of the
3156 vector outside of the loop.
3157 (btrace_maint_update_packets): Update to handle change from VEC to
3158 std::vector.
3159 (btrace_maint_print_packets): Likewise.
3160 (maint_info_btrace_cmd): Likewise.
3161 * btrace.h: Remove use of DEF_VEC_O.
3162 (typedef btrace_pt_packet_s): Delete.
3163 (struct btrace_maint_info) <packets>: Change fromm VEC to
3164 std::vector.
3165 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3166
31672019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3168
3169 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3170 make accesses into the vector constant references.
3171 (btrace_add_pc): Update for std::vector.
3172 (btrace_stitch_bts): Likewise.
3173 (parse_xml_btrace_block): Likewise.
3174 (btrace_maint_update_packets): Likewise.
3175 (btrace_maint_print_packets): Likewise.
3176 (maint_info_btrace_cmd): Likewise.
3177 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3178 std::vector.
3179 (btrace_data::empty): Likewise.
3180 (btrace_data_append): Likewise.
3181 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3182 (typedef btrace_block_s): Delete.
3183 (struct btrace_block): Add constructor.
3184 (struct btrace_data_bts) <blocks>: Change to std::vector.
3185 * nat/linux-btrace.c (perf_event_read_bts): Update for
3186 std::vector.
3187 (linux_read_bts): Likewise.
3188
31892019-10-01 Tom Tromey <tom@tromey.com>
3190
3191 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3192
31932019-10-01 Tom Tromey <tom@tromey.com>
3194
3195 * stack.c (print_frame, info_frame_command_core): Use
3196 styled_string.
3197 * linux-thread-db.c (try_thread_db_load_1)
3198 (try_thread_db_load_from_pdir_1): Use styled_string.
3199 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3200 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3201 (maybe_print_unsupported_script_warning)
3202 (maybe_print_script_not_found_warning): Use styled_string.
3203 * ada-lang.c (user_select_syms): Use styled_string.
3204
32052019-10-01 Tom Tromey <tom@tromey.com>
3206
3207 * p-lang.c (pascal_printstr): Use metadata style.
3208 * value.c (show_convenience): Use metadata style.
3209 * valprint.c (valprint_check_validity, val_print_optimized_out)
3210 (val_print_not_saved, val_print_unavailable)
3211 (val_print_invalid_address, generic_val_print, val_print)
3212 (value_check_printable, val_print_array_elements): Use metadata
3213 style.
3214 * ui-out.h (class ui_out) <field_fmt>: New overload.
3215 <do_field_fmt>: Add style parameter.
3216 * ui-out.c (ui_out::field_fmt): New overload.
3217 * typeprint.c (type_print_unknown_return_type)
3218 (val_print_not_allocated, val_print_not_associated): Use metadata
3219 style.
3220 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3221 parameter.
3222 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3223 * tracepoint.c (tvariables_info_1): Use metadata style.
3224 * stack.c (print_frame_arg, print_frame_info, print_frame)
3225 (info_frame_command_core): Use metadata style.
3226 * skip.c (info_skip_command): Use metadata style.
3227 * rust-lang.c (rust_print_enum): Use metadata style.
3228 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3229 metadata style.
3230 * python/py-framefilter.c (py_print_single_arg): Use metadata
3231 style.
3232 * printcmd.c (do_one_display, print_variable_and_value): Use
3233 metadata style.
3234 * p-valprint.c (pascal_val_print)
3235 (pascal_object_print_value_fields): Use metadata style.
3236 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3237 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3238 parameter.
3239 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3240 * m2-valprint.c (m2_print_long_set): Use metadata style.
3241 * m2-typeprint.c (m2_print_type): Use metadata style.
3242 * infcmd.c (print_return_value_1): Use metadata style.
3243 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3244 * f-valprint.c (info_common_command_for_block): Use metadata
3245 style.
3246 * f-typeprint.c (f_type_print_base): Use metadata style.
3247 * expprint.c (print_subexp_standard): Use metadata style.
3248 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3249 * cli/cli-style.h (class cli_style_option): Add constructor.
3250 (metadata_style): Declare.
3251 * cli/cli-style.c (metadata_style): New global.
3252 (_initialize_cli_style): Register metadata style.
3253 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3254 parameter.
3255 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3256 * c-typeprint.c (c_type_print_base_struct_union)
3257 (c_type_print_base_1): Use metadata style.
3258 * breakpoint.c (watchpoint_value_print)
3259 (print_one_breakpoint_location): Use metadata style.
3260 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3261 style.
3262 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3263 style.
3264 * ada-valprint.c (val_print_packed_array_elements, printstr)
3265 (print_field_values, ada_val_print_ref, ada_val_print): Use
3266 metadata style.
3267 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3268 style.
3269 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3270 style.
3271 * ada-lang.c (user_select_syms): Use metadata style.
3272
32732019-10-01 Tom Tromey <tom@tromey.com>
3274
3275 * cli/cli-cmds.c (pwd_command): Style output.
3276
32772019-10-01 Pedro Alves <palves@redhat.com>
3278 Tom Tromey <tom@tromey.com>
3279
3280 * symtab.c (print_symbol_info): Use %ps.
3281 (print_msymbol_info): Use %ps.
3282 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3283 * printcmd.c (print_variable_and_value): Use %ps.
3284 * macrocmd.c (show_pp_source_pos): Use %ps.
3285 * infrun.c (print_exited_reason): Use ui_out::message.
3286 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3287 (describe_other_breakpoints): Use ui_out::message and new
3288 formats.
3289 (say_where): Use new formats.
3290 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3291 and new formats.
3292
32932019-10-01 Pedro Alves <palves@redhat.com>
3294 Tom Tromey <tom@tromey.com>
3295
3296 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3297 (test_gdb_formats): New function.
3298 (run_tests): Call it.
3299 (test_format_specifier): Update.
3300 * utils.h (fputs_filtered): Update comment.
3301 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3302 (fputs_styled_unfiltered): Declare.
3303 * utils.c (fputs_styled_unfiltered): New function.
3304 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3305 (vfprintf_filtered): Update.
3306 (vfprintf_unfiltered, vprintf_filtered): Update.
3307 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3308 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3309 disallow_ui_out_field>: New constants.
3310 (enum class field_kind): New.
3311 (struct base_field_s, struct signed_field_s): New.
3312 (signed_field): New function.
3313 (struct string_field_s): New.
3314 (string_field): New function.
3315 (struct styled_string_s): New.
3316 (styled_string): New function.
3317 (class ui_out) <message>: Add comment.
3318 <vmessage, call_do_message>: New methods.
3319 <do_message>: Add style parameter.
3320 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3321 methods.
3322 (ui_out::message): Rewrite.
3323 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3324 parameter.
3325 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3326 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3327 gdb_extensions parameter.
3328 (class format_piece): Add parameter to constructor.
3329 (n_int_args): New field.
3330 * gdbsupport/format.c (format_pieces::format_pieces): Add
3331 gdb_extensions parameter. Handle '*'.
3332 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3333 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3334 vfprintf_styled_no_gdbfmt.
3335 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3336 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3337 unfiltered output.
3338 * ui-style.h (struct ui_file_style) <ptr>: New method.
3339
33402019-10-01 Tom Tromey <tom@tromey.com>
3341
3342 * unittests/format_pieces-selftests.c: Update. Add final format.
3343 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3344 empty literal pieces.
3345
33462019-10-01 Tom Tromey <tom@tromey.com>
3347
3348 * ui-out.h (enum class ui_out_style_kind): Remove.
3349 (class ui_out) <field_string, field_stsream, do_field_string>:
3350 Change type of "style".
3351 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3352 (ui_out::field_string): Update.
3353 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3354 of "style".
3355 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3356 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3357 * stack.c (print_frame_arg, print_frame_info, print_frame):
3358 Update.
3359 * source.c (print_source_lines_base): Update.
3360 * solib.c (info_sharedlibrary_command): Update.
3361 * skip.c (info_skip_command): Update.
3362 * record-btrace.c (btrace_call_history_src_line)
3363 (btrace_call_history): Update.
3364 * python/py-framefilter.c (py_print_frame): Update.
3365 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3366 "style".
3367 * mi/mi-out.c (mi_ui_out::do_table_header)
3368 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3369 (mi_ui_out::do_field_string): Update.
3370 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3371 Update.
3372 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3373 "style".
3374 * cli-out.c (cli_ui_out::do_table_header)
3375 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3376 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3377 (cli_ui_out::do_field_fmt): Update.
3378 * breakpoint.c (print_breakpoint_location): Update.
3379 (update_static_tracepoint): Update.
3380
33812019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3382
3383 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3384 conversion of gdb_datadir.
3385 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3386 remove not needed c_str ().
3387
33882019-09-30 Ali Tamur <tamur@google.com>
3389
3390 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3391 (dwarf2_string_attr): Likewise.
3392
33932019-09-30 Ali Tamur <tamur@google.com>
3394
3395 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3396 (process_full_type_unit): Likewise.
3397 (dump_die_shallow): Likewise.
3398 (cu_debug_loc_section): Likewise.
3399
34002019-09-28 Christian Biesinger <cbiesinger@google.com>
3401
3402 * minsyms.c (compare_minimal_symbols): Rename to...
3403 (minimal_symbol_is_less_than): ...this, and adjust to STL
3404 conventions (return bool, take arguments as references)
3405 (minimal_symbol_reader::install): Call std::sort instead
3406 of qsort.
3407
34082019-09-29 Christian Biesinger <cbiesinger@google.com>
3409
3410 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3411 hash and why.
3412 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3413 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3414
34152019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3416
3417 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3418 * psympriv.h (add_psymbol_to_list): Move comment here and update
3419 it.
3420
34212019-09-29 Tom de Vries <tdevries@suse.de>
3422
3423 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3424 Use $tmpdir/$(basename "$output_file").dwz instead of
3425 "${output_file}.dwz".
3426
34272019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3428
3429 PR gdb/25045
3430 * hppa-linux-nat.c: Include gdbarch.h.
3431
34322019-09-26 Christian Biesinger <cbiesinger@google.com>
3433
3434 * blockframe.c (find_pc_partial_function): Change return type to bool.
3435 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3436 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3437 (stub_gnu_ifunc_resolve_name): Likewise.
3438 * symtab.c (compare_filenames_for_search): Likewise.
3439 (compare_glob_filenames_for_search): Likewise.
3440 (matching_obj_sections): Likewise.
3441 (symbol_matches_domain): Likewise.
3442 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3443 (find_line_pc): Change return type to bool.
3444 (find_line_pc_range): Likewise.
3445 (producer_is_realview): Likewise.
3446 * symtab.h (symbol_matches_domain): Likewise.
3447 (find_pc_partial_function): Likewise.
3448 (find_pc_line_pc_range): Likewise.
3449 (in_gnu_ifunc_stub): Likewise.
3450 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3451 (find_line_pc): Likewise.
3452 (find_line_pc_range): Likewise.
3453 (matching_obj_sections): Likewise.
3454 (find_line_symtab): Change out parameter to bool.
3455 (producer_is_realview): Change return type to bool.
3456 (compare_filenames_for_search): Likewise.
3457 (compare_glob_filenames_for_search): Likewise.
3458
34592019-09-26 Tom Tromey <tom@tromey.com>
3460
3461 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3462 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3463 * gdb_usleep.h: Remove.
3464 * gdb_usleep.c: Remove.
3465 * utils.c: Don't include gdb_usleep.h.
3466
34672019-09-26 Tom Tromey <tromey@adacore.com>
3468
3469 * python/py-type.c (type_to_type_object): Call check_typedef
3470 for stub types.
3471
34722019-09-26 Tom Tromey <tom@tromey.com>
3473
3474 * utils.h (initialize_utils): Don't declare.
3475 * top.c (gdb_init): Don't call initialize_utils.
3476 * utils.c (initialize_utils): Remove. Move contents...
3477 (_initialize_utils): ... here.
3478
34792019-09-25 Tom Tromey <tom@tromey.com>
3480
3481 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3482 * utils.h (make_hex_string): Don't declare.
3483 * utils.c (make_hex_string): Remove.
3484
34852019-09-24 Tom de Vries <tdevries@suse.de>
3486
3487 PR gdb/23815
3488 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3489 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3490
34912019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3492
3493 * NEWS: Mention new simulator port for PRU.
3494
34952019-09-23 Christian Biesinger <cbiesinger@google.com>
3496
3497 * ada-exp.y (write_object_remaining): Update.
3498 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3499 and eliminate the static buffer.
3500 (ada_decode_symbol): Update.
3501 (ada_la_decode): Update.
3502 (ada_sniff_from_mangled_name): Update.
3503 (is_valid_name_for_wild_match): Update.
3504 (ada_lookup_name_info::matches): Update and simplify.
3505 (name_matches_regex): Update.
3506 (ada_add_global_exceptions): Update.
3507 * ada-lang.h (ada_decode): Update signature.
3508 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3509 * dwarf-index-write.c (debug_names::insert): Update.
3510
35112019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3512
3513 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3514 formatting.
3515
35162019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3517
3518 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3519 Change "nonzero" to "true" in documentation.
3520
35212019-09-20 Christian Biesinger <cbiesinger@google.com>
3522
3523 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3524 (_initialize_darwin_solib): Don't set
3525 darwin_so_ops.lookup_lib_global_symbol.
3526 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3527 set_gdbarch_iterate_over_objfiles_in_search_order.
3528 (elf_lookup_lib_symbol): Rename to...
3529 (svr4_iterate_over_objfiles_in_search_order): this, and update
3530 to iterate semantics.
3531 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3532 * solib.c (solib_global_lookup): Remove.
3533 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3534 (solib_global_lookup): Remove.
3535 * symtab.c (lookup_global_or_static_symbol): Remove call to
3536 solib_global_lookup.
3537
35382019-09-20 Joel Brobecker <brobecker@adacore.com>
3539
3540 * NEWS: Move entries about default MI version now being
3541 version 3, and about the GDB/MI fix for multi-location
3542 breakpoints to the "since GDB 8.3" section.
3543
35442019-09-20 Joel Brobecker <brobecker@adacore.com>
3545
3546 GDB 8.3.1 released.
3547
35482019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3549
3550 * NEWS: Mention that Cell/B.E. debugging support was removed.
3551 * MAINTAINERS: Remove spu target.
3552
3553 * config/djgpp/fnchange.lst: Remove entries for removed files.
3554
3555 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3556 spu-multiarch.o, and spu-tdep.o.
3557 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3558 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3559 spu-multiarch.c, and spu-tdep.c.
3560 * spu-linux-nat.c: Remove file.
3561 * spu-multiarch.c: Remove file.
3562 * spu-tdep.c: Remove file.
3563 * spu-tdep.h: Remove file.
3564 * solib-spu.c: Remove file.
3565 * solib-spu.h: Remove file.
3566
3567 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3568 * configure.nat (spu-linux): Remove.
3569 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3570 solib-multiarch.o from gdb_target_obs.
3571 (spu*-*-*): Remove.
3572
3573 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3574 feature flag.
3575 (ppc_linux_no_features): Update.
3576 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3577 Cell/B.E. support.
3578 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3579 (tdesc_powerpc_cell64l): Likewise.
3580 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3581 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3582 Cell/B.E. support.
3583 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3584 Do not include "features/rs6000/powerpc-cell32l.c" or
3585 "features/rs6000/powerpc-cell64l.c".
3586 (ppc_linux_spu_section): Remove.
3587 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3588 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3589 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3590 (ppc_linux_spe_context_lookup): Remove.
3591 (ppc_linux_spe_context_inferior_created): Remove.
3592 (ppc_linux_spe_context_solib_loaded): Remove.
3593 (ppc_linux_spe_context_solib_unloaded): Remove.
3594 (ppc_linux_spe_context): Remove.
3595 (struct ppu2spu_cache): Remove.
3596 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3597 (struct ppu2spu_data): Remove.
3598 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3599 ppu2spu_unwind): Remove.
3600 (ppc_linux_init_abi): Remove Cell/B.E. support.
3601 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3602
3603 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3604 (rs6000/powerpc-cell64l-expedite): Likewise
3605 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3606 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3607 rs6000/powerpc-cell64l.xml.
3608 * features/rs6000/powerpc-cell32l.xml: Remove.
3609 * features/rs6000/powerpc-cell64l.xml: Likewise.
3610 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3611 * features/rs6000/powerpc-cell64l.c: Likewise.
3612 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3613 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3614 * regformats/reg-spu.dat: Remove.
3615
3616 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3617 * corelow.c (struct spuid_list): Remove.
3618 (add_to_spuid_list): Remove.
3619 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3620 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3621 (remote_protocol_features): Remove associated entries.
3622 (_initialize_remote): No longer initialize them.
3623 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3624 * linux-nat.c (SPUFS_MAGIC): Remove.
3625 (linux_proc_xfer_spu): Remove.
3626 (spu_enumerate_spu_ids): Remove.
3627 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3628 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3629 (linux_make_corefile_notes): No longer call it.
3630
3631 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3632 (cooked_write_test): Likewise.
3633
36342019-09-20 Tom Tromey <tom@tromey.com>
3635
3636 * NEWS: Mention case-sensitivity of TUI commands.
3637 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3638 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3639 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3640
36412019-09-20 Tom Tromey <tom@tromey.com>
3642
3643 * tui/tui-source.c (tui_source_window::set_contents): Use
3644 make_unique_xstrdup.
3645 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3646 make_unique_xstrdup.
3647
36482019-09-20 Tom Tromey <tom@tromey.com>
3649
3650 * tui/tui-data.c: Remove separator comments.
3651 * tui/tui-layout.c: Remove separator comments.
3652 * tui/tui-win.c: Remove separator comments.
3653 * tui/tui-wingeneral.c: Remove separator comments.
3654
36552019-09-20 Tom Tromey <tom@tromey.com>
3656
3657 * tui/tui.h (strcat_to_buf): Don't declare.
3658 * tui/tui.c (strcat_to_buf): Remove.
3659
36602019-09-20 Tom Tromey <tom@tromey.com>
3661
3662 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3663 from "fullname".
3664 * tui/tui-source.c (tui_source_window::set_contents)
3665 (tui_source_window::location_matches_p)
3666 (tui_source_window::maybe_update): Update.
3667
36682019-09-20 Tom Tromey <tom@tromey.com>
3669
3670 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3671 Update.
3672 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3673 prefix.
3674 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3675 (tui_data_window::line_from_reg_element_no)
3676 (tui_data_window::first_reg_element_no_inline)
3677 (tui_data_window::show_registers)
3678 (tui_data_window::show_register_group)
3679 (tui_data_window::display_registers_from)
3680 (tui_data_window::display_registers_from_line)
3681 (tui_data_window::first_data_item_displayed)
3682 (tui_data_window::delete_data_content_windows)
3683 (tui_data_window::erase_data_content)
3684 (tui_data_window::do_scroll_vertical)
3685 (tui_data_window::refresh_window)
3686 (tui_data_window::check_register_values): Update.
3687
36882019-09-20 Tom Tromey <tom@tromey.com>
3689
3690 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3691 (struct tui_locator_window) <full_name, proc_name>: Now
3692 std::string.
3693 * tui/tui-stack.c (tui_locator_window::make_status_line)
3694 (tui_locator_window::set_locator_fullname)
3695 (tui_locator_window::set_locator_info): Update.
3696 * tui/tui-source.c (tui_source_window::set_contents)
3697 (tui_source_window::showing_source_p): Update.
3698
36992019-09-20 Tom Tromey <tom@tromey.com>
3700
3701 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3702 Don't call tui_locator_win_info_ptr.
3703
37042019-09-20 Tom Tromey <tom@tromey.com>
3705
3706 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3707
37082019-09-20 Tom Tromey <tom@tromey.com>
3709
3710 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3711 height for locator.
3712 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3713 * tui/tui-layout.c (show_source_disasm_command, show_data)
3714 (show_source_or_disasm_and_command): Use 1 as height for locator.
3715
37162019-09-20 Tom Tromey <tom@tromey.com>
3717
3718 * tui/tui.c (tui_enable): Update.
3719 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3720 Update.
3721 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3722 Update.
3723 * tui/tui-data.c (win_resized): Now bool.
3724 (tui_win_resized): Return bool.
3725 (tui_set_win_resized_to): Accept a bool.
3726
37272019-09-20 Tom Tromey <tom@tromey.com>
3728
3729 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3730 Change type of "refresh_values_only".
3731 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3732 type of "refresh_values_only".
3733
37342019-09-20 Tom Tromey <tom@tromey.com>
3735
3736 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3737 std::string.
3738 (tui_disassemble): Add "pos" parameter.
3739 (tui_disasm_window::set_contents): Simplify.
3740
37412019-09-20 Tom Tromey <tom@tromey.com>
3742
3743 * tui/tui-winsource.h (struct tui_source_window_base)
3744 <show_source_content>: Now private.
3745 * tui/tui-winsource.c
3746 (tui_source_window_base::show_source_content): Don't handle empty
3747 content case.
3748
37492019-09-20 Tom Tromey <tom@tromey.com>
3750
3751 * tui/tui-layout.c (show_source_disasm_command)
3752 (show_source_or_disasm_and_command): Don't call
3753 show_source_content.
3754
37552019-09-20 Tom Tromey <tom@tromey.com>
3756
3757 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3758 Declare.
3759 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3760 from tui_make_status_line.
3761 (tui_locator_window::rerender): Update.
3762
37632019-09-20 Tom Tromey <tom@tromey.com>
3764
3765 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3766 (tui_locator_window::rerender): Update.
3767
37682019-09-20 Tom Tromey <tom@tromey.com>
3769
3770 * tui/tui-winsource.h (struct tui_source_window_base)
3771 <~tui_source_window_base>: Don't declare.
3772 <fullname>: Remove.
3773 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3774 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3775 member.
3776 * tui/tui-source.c (tui_source_window::set_contents): Update.
3777 (tui_source_window::location_matches_p)
3778 (tui_source_window::maybe_update): Update.
3779
37802019-09-20 Tom Tromey <tom@tromey.com>
3781
3782 * tui/tui-winsource.h (~tui_source_element): Remove.
3783 (tui_source_element): Update.
3784 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3785 * tui/tui-winsource.c (tui_show_source_line): Update.
3786 * tui/tui-source.c (tui_source_window::set_contents): Update.
3787 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3788
37892019-09-20 Tom Tromey <tom@tromey.com>
3790
3791 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3792 declare.
3793 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3794 tui_clear_source_windows_detail.
3795 * tui/tui-winsource.h (struct tui_source_window_base)
3796 <clear_detail>: Don't declare.
3797 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3798 Remove.
3799 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3800
38012019-09-20 Tom Tromey <tromey@adacore.com>
3802
3803 PR ada/24919:
3804 * block.c (contained_in): Fix final return value.
3805
38062019-09-20 Alan Modra <amodra@gmail.com>
3807
3808 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3809 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3810 (read_indirect_string_from_dwz): Use bfd accessor.
3811 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3812 * machoread.c (macho_symfile_read_all_oso): Likewise.
3813 * solib.c (solib_bfd_open): Likewise.
3814
38152019-09-19 Christian Biesinger <cbiesinger@google.com>
3816
3817 * eval.c: Move declaration of overload_resolution to...
3818 * value.h: ...here.
3819
38202019-09-19 Christian Biesinger <cbiesinger@google.com>
3821
3822 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3823 * arm-linux-tdep.c: Likewise.
3824 * arm-nbsd-nat.c: Likewise.
3825 * arm-tdep.h: Declare arm_apcs_32.
3826 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3827
38282019-09-19 Christian Biesinger <cbiesinger@google.com>
3829
3830 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3831 * dwarf2read.h: Declare dwarf_always_disassemble.
3832
38332019-09-19 Tom de Vries <tdevries@suse.de>
3834
3835 PR gdb/25009
3836 * source-cache.c (source_cache::ensure): Catch exception thrown during
3837 construction of the highlighter.
3838
38392019-09-18 Alan Modra <amodra@gmail.com>
3840
3841 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3842 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3843 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3844 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3845 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3846 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3847 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3848 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3849 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3850 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3851 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3852 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3853 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3854 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3855 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3856 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3857 * mi/mi-interp.c: Update throughout for bfd section macro and
3858 function changes.
3859 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3860 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3861
38622019-09-18 Tom Tromey <tom@tromey.com>
3863
3864 * NEWS: Add entry.
3865 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3866 call rl_initialize.
3867 (tui_enable): Do not call rl_initialize.
3868
38692019-09-18 Christian Groessler <chris@groessler.org>
3870
3871 * alpha-linux-nat.c: Include gdbarch.h.
3872
38732019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3874
3875 * ui-file.c: Include cli/cli-style.h.
3876 (term_cli_styling): Remove cli_styling declaration.
3877
38782019-09-18 Alan Modra <amodra@gmail.com>
3879
3880 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3881 to bfd_asymbol_section.
3882
38832019-09-18 Alan Modra <amodra@gmail.com>
3884
3885 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3886 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3887 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3888
38892019-09-18 Alan Modra <amodra@gmail.com>
3890
3891 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3892 * spu-linux-nat.c (spu_bfd_open): Likewise.
3893
38942019-09-18 Christian Biesinger <cbiesinger@google.com>
3895
3896 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3897 to bool to match definition in dwarf2read.c.
3898
38992019-09-17 Christian Biesinger <cbiesinger@google.com>
3900
3901 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3902 (print_signatures): Likewise.
3903 (trust_pad_over_xvs): Likewise.
3904 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3905 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3906 * arm-linux-nat.c (arm_apcs_32): Likewise.
3907 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3908 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3909 * arm-tdep.c (arm_debug): Likewise.
3910 (arm_apcs_32): Likewise.
3911 * auto-load.c (debug_auto_load): Likewise.
3912 (auto_load_gdb_scripts): Likewise.
3913 (global_auto_load): Likewise.
3914 (auto_load_local_gdbinit): Likewise.
3915 (auto_load_local_gdbinit_loaded): Likewise.
3916 * auto-load.h (global_auto_load): Likewise.
3917 (auto_load_local_gdbinit): Likewise.
3918 (auto_load_local_gdbinit_loaded): Likewise.
3919 * breakpoint.c (disconnected_dprintf): Likewise.
3920 (breakpoint_proceeded): Likewise.
3921 (automatic_hardware_breakpoints): Likewise.
3922 (always_inserted_mode): Likewise.
3923 (target_exact_watchpoints): Likewise.
3924 (_initialize_breakpoint): Update.
3925 * breakpoint.h (target_exact_watchpoints): Change to bool.
3926 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3927 * cli/cli-cmds.c (trace_commands): Likewise.
3928 * cli/cli-cmds.h (trace_commands): Likewise.
3929 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3930 to bool*.
3931 * cli/cli-logging.c (logging_overwrite): Change to bool.
3932 (logging_redirect): Likewise.
3933 (debug_redirect): Likewise.
3934 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3935 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3936 to bool.
3937 <boolean_option_def>: Update.
3938 (struct flag_option_def): Change default type of Context to bool
3939 from int.
3940 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3941 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3942 (get_setshow_command_value_string): Likewise.
3943 * cli/cli-style.c (cli_styling): Change to bool.
3944 (source_styling): Likewise.
3945 * cli/cli-style.h (source_styling): Likewise.
3946 (cli_styling): Likewise.
3947 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3948 to bool.
3949 * command.h (var_types): Update comment.
3950 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3951 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3952 bool.
3953 (debug_compile_cplus_scopes): Likewise.
3954 * compile/compile-internal.h (compile_debug): Likewise.
3955 * compile/compile.c (compile_debug): Likewise.
3956 (struct compile_options) <raw>: Likewise.
3957 * cp-support.c (catch_demangler_crashes): Likewise.
3958 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3959 (usr_cmd_cris_dwarf2_cfi): Likewise.
3960 * csky-tdep.c (csky_debug): Likewise.
3961 * darwin-nat.c (enable_mach_exceptions): Likewise.
3962 * dcache.c (dcache_enabled_p): Likewise.
3963 * defs.h (info_verbose): Likewise.
3964 * demangle.c (demangle): Likewise.
3965 (asm_demangle): Likewise.
3966 * dwarf-index-cache.c (debug_index_cache): Likewise.
3967 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3968 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3969 * dwarf2read.c (check_physname): Likewise.
3970 (use_deprecated_index_sections): Likewise.
3971 (dwarf_always_disassemble): Likewise.
3972 * eval.c (overload_resolution): Likewise.
3973 * event-top.c (set_editing_cmd_var): Likewise.
3974 (exec_done_display_p): Likewise.
3975 * event-top.h (set_editing_cmd_var): Likewise.
3976 (exec_done_display_p): Likewise.
3977 * exec.c (write_files): Likewise.
3978 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3979 (debug_fbsd_nat): Likewise.
3980 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3981 Likewise.
3982 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3983 <backtrace_past_entry> Likewise.
3984 * gdb-demangle.h (demangle): Likewise.
3985 (asm_demangle): Likewise.
3986 * gdb_bfd.c (bfd_sharing): Likewise.
3987 * gdbcore.h (write_files): Likewise.
3988 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3989 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3990 * gdbthread.h (print_thread_events): Likewise.
3991 * gdbtypes.c (opaque_type_resolution): Likewise.
3992 (strict_type_checking): Likewise.
3993 * gnu-nat.c (gnu_debug_flag): Likewise.
3994 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3995 * guile/scm-param.c (pascm_variable): Add boolval.
3996 (add_setshow_generic): Update.
3997 (pascm_param_value): Update.
3998 (pascm_set_param_value_x): Update.
3999 * hppa-tdep.c (hppa_debug): Change to bool..
4000 * infcall.c (may_call_functions_p): Likewise.
4001 (coerce_float_to_double_p): Likewise.
4002 (unwind_on_signal_p): Likewise.
4003 (unwind_on_terminating_exception_p): Likewise.
4004 * infcmd.c (startup_with_shell): Likewise.
4005 * inferior.c (print_inferior_events): Likewise.
4006 * inferior.h (startup_with_shell): Likewise.
4007 (print_inferior_events): Likewise.
4008 * infrun.c (step_stop_if_no_debug): Likewise.
4009 (detach_fork): Likewise.
4010 (debug_displaced): Likewise.
4011 (disable_randomization): Likewise.
4012 (non_stop): Likewise.
4013 (non_stop_1): Likewise.
4014 (observer_mode): Likewise.
4015 (observer_mode_1): Likewise.
4016 (set_observer_mode): Update.
4017 (sched_multi): Change to bool.
4018 * infrun.h (debug_displaced): Likewise.
4019 (sched_multi): Likewise.
4020 (step_stop_if_no_debug): Likewise.
4021 (non_stop): Likewise.
4022 (disable_randomization): Likewise.
4023 * linux-tdep.c (use_coredump_filter): Likewise.
4024 (dump_excluded_mappings): Likewise.
4025 * linux-thread-db.c (auto_load_thread_db): Likewise.
4026 (check_thread_db_on_load): Likewise.
4027 * main.c (captured_main_1): Update.
4028 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4029 xx2_opt, boolean_opt>: Change to bool.
4030 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4031 * maint.c (maintenance_profile_p): Likewise.
4032 (per_command_time): Likewise.
4033 (per_command_space): Likewise.
4034 (per_command_symtab): Likewise.
4035 * memattr.c (inaccessible_by_default): Likewise.
4036 * mi/mi-main.c (mi_async): Likewise.
4037 (mi_async_1): Likewise.
4038 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4039 * nat/fork-inferior.h (startup_with_shell): Likewise.
4040 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4041 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4042 * nios2-tdep.c (nios2_debug): Likewise.
4043 * or1k-tdep.c (or1k_debug): Likewise.
4044 * parse.c (parser_debug): Likewise.
4045 * parser-defs.h (parser_debug): Likewise.
4046 * printcmd.c (print_symbol_filename): Likewise.
4047 * proc-api.c (procfs_trace): Likewise.
4048 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4049 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4050 (set_parameter_value): Update.
4051 (add_setshow_generic): Update.
4052 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4053 to bool*.
4054 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4055 int*.
4056 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4057 * record-btrace.c (record_btrace_target::store_registers): Update.
4058 * record-full.c (record_full_memory_query): Change to bool.
4059 (record_full_stop_at_limit): Likewise.
4060 * record-full.h (record_full_memory_query): Likewise.
4061 * remote-notif.c (notif_debug): Likewise.
4062 * remote-notif.h (notif_debug): Likewise.
4063 * remote.c (use_range_stepping): Likewise.
4064 (interrupt_on_connect): Likewise.
4065 (remote_break): Likewise.
4066 * ser-tcp.c (tcp_auto_retry): Likewise.
4067 * ser-unix.c (serial_hwflow): Likewise.
4068 * skip.c (debug_skip): Likewise.
4069 * solib-aix.c (solib_aix_debug): Likewise.
4070 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4071 (spu_auto_flush_cache_p): Likewise.
4072 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4073 Likewise.
4074 (struct info_print_options) <quiet>: Likewise.
4075 * symfile-debug.c (debug_symfile): Likewise.
4076 * symfile.c (auto_solib_add): Likewise.
4077 (separate_debug_file_debug): Likewise.
4078 * symfile.h (auto_solib_add): Likewise.
4079 (separate_debug_file_debug): Likewise.
4080 * symtab.c (basenames_may_differ): Likewise.
4081 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4082 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4083 (struct info_types_options) <quiet>: Likewise.
4084 * symtab.h (demangle): Likewise.
4085 (basenames_may_differ): Likewise.
4086 * target-dcache.c (stack_cache_enabled_1): Likewise.
4087 (code_cache_enabled_1): Likewise.
4088 * target.c (trust_readonly): Likewise.
4089 (may_write_registers): Likewise.
4090 (may_write_memory): Likewise.
4091 (may_insert_breakpoints): Likewise.
4092 (may_insert_tracepoints): Likewise.
4093 (may_insert_fast_tracepoints): Likewise.
4094 (may_stop): Likewise.
4095 (auto_connect_native_target): Likewise.
4096 (target_stop_and_wait): Update.
4097 (target_async_permitted): Change to bool.
4098 (target_async_permitted_1): Likewise.
4099 (may_write_registers_1): Likewise.
4100 (may_write_memory_1): Likewise.
4101 (may_insert_breakpoints_1): Likewise.
4102 (may_insert_tracepoints_1): Likewise.
4103 (may_insert_fast_tracepoints_1): Likewise.
4104 (may_stop_1): Likewise.
4105 * target.h (target_async_permitted): Likewise.
4106 (may_write_registers): Likewise.
4107 (may_write_memory): Likewise.
4108 (may_insert_breakpoints): Likewise.
4109 (may_insert_tracepoints): Likewise.
4110 (may_insert_fast_tracepoints): Likewise.
4111 (may_stop): Likewise.
4112 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4113 (make_thread_apply_all_options_def_group): Change argument from int*
4114 to bool*.
4115 (thread_apply_all_command): Update.
4116 (print_thread_events): Change to bool.
4117 * top.c (confirm): Likewise.
4118 (command_editing_p): Likewise.
4119 (history_expansion_p): Likewise.
4120 (write_history_p): Likewise.
4121 (info_verbose): Likewise.
4122 * top.h (confirm): Likewise.
4123 (history_expansion_p): Likewise.
4124 * tracepoint.c (disconnected_tracing): Likewise.
4125 (circular_trace_buffer): Likewise.
4126 * typeprint.c (print_methods): Likewise.
4127 (print_typedefs): Likewise.
4128 * utils.c (debug_timestamp): Likewise.
4129 (sevenbit_strings): Likewise.
4130 (pagination_enabled): Likewise.
4131 * utils.h (sevenbit_strings): Likewise.
4132 (pagination_enabled): Likewise.
4133 * valops.c (overload_resolution): Likewise.
4134 * valprint.h (struct value_print_options) <prettyformat_arrays,
4135 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4136 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4137 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4138 Likewise.
4139 * windows-nat.c (new_console): Likewise.
4140 (cygwin_exceptions): Likewise.
4141 (new_group): Likewise.
4142 (debug_exec): Likewise.
4143 (debug_events): Likewise.
4144 (debug_memory): Likewise.
4145 (debug_exceptions): Likewise.
4146 (useshell): Likewise.
4147 * windows-tdep.c (maint_display_all_tib): Likewise.
4148 * xml-support.c (debug_xml): Likewise.
4149
41502019-09-17 Mike Gulick <mgulick@mathworks.com>
4151
4152 * source.c (prepare_path_for_appending): New function.
4153 (openp): Make use of new function.
4154 (find_and_open_source): Search for the compilation directory and
4155 source file as a relative path beneath the directory search path.
4156
41572019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4158
4159 * source-cache.c (source_cache::get_line_charpos): Catch
4160 exceptions and return false, this matches the behaviour documented
4161 in the header file.
4162
41632019-09-17 Joel Brobecker <brobecker@adacore.com>
4164
4165 * ada-tasks.c (info_task): Remove quoting of the task's name.
4166
41672019-09-16 Christian Biesinger <cbiesinger@google.com>
4168
4169 * symfile.c (auto_solib_add): Replace comment with a reference
4170 to the header file.
4171
41722019-09-14 Christian Biesinger <cbiesinger@google.com>
4173
4174 * NEWS: Mention that gdb can now be compiled with Python 3
4175 on Windows.
4176
41772019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4178
4179 * maint.c (maint_print_section_data::maint_print_section_data):
4180 Force use of 'float log10 (float)' by casting the argument to
4181 float.
4182
41832019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4184
4185 * maint.c: Add 'cmath' include.
4186 (struct maint_print_section_data): New structure.
4187 (print_section_index): New function.
4188 (print_bfd_section_info): Add header comment, small whitespace
4189 cleanup, and update to call new print_section_index function.
4190 (print_objfile_section_info): Likewise.
4191 (maint_obj_section_from_bfd_section): New function.
4192 (print_bfd_section_info_maybe_relocated): New function.
4193 (maintenance_info_sections): Add header comment, always use
4194 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4195
41962019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4197
4198 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4199 inner scope, add check that the objfile has psymtabs before
4200 checking psymtabs_addrmap.
4201 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4202
42032019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4204
4205 * NEWS: Announce that Ada task names are now shown at more places,
4206 and between quotes (except in info task output).
4207 * gdb/ada-tasks.c (task_to_str): New function.
4208 (display_current_task_id): Call task_to_str.
4209 (task_command_1): Likewise.
4210 (print_ada_task_info): In non-mi mode, Properly align headers and data
4211 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4212
42132019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4214
4215 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4216 prstatus.pr_lwp.pr_info instead of making it up.
4217
42182019-09-11 Christian Biesinger <cbiesinger@google.com>
4219
4220 * auto-load.c (auto_load_expand_dir_vars): Update.
4221 * defs.h (gdb_datadir): Change to std::string.
4222 (python_libdir): Likewise.
4223 (relocate_gdb_directory): Change return type to std::string.
4224 * guile/guile.c (gdbscm_data_directory): Update.
4225 (initialize_scheme_side): Update.
4226 * jit.c (jit_reader_dir): Change to std::string.
4227 (jit_reader_load_command): Update.
4228 * main.c (gdb_datadir): Change to std::string.
4229 (python_libdir): Likewise.
4230 (set_gdb_data_directory): Update.
4231 (relocate_path): Change to return std::string.
4232 (relocate_gdb_directory): Change to return std::string.
4233 (relocate_gdbinit_path_maybe_in_datadir): Update.
4234 (captured_main_1): Update.
4235 * python/python.c (do_start_initialization): Update.
4236 * top.c (show_gdb_datadir): Update.
4237 * xml-syscall.c (xml_init_syscalls_info): Update.
4238 (init_syscalls_info): Update.
4239
42402019-09-11 Christian Biesinger <cbiesinger@google.com>
4241
4242 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4243 out of get_init_files.
4244 (get_init_files): Update.
4245
42462019-09-11 Christian Biesinger <cbiesinger@google.com>
4247
4248 * main.c (get_init_files): Change to use std::string.
4249 (captured_main_1): Update.
4250 (print_gdb_help): Update.
4251
42522019-09-11 Ali Tamur <tamur@google.com>
4253
4254 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4255 implementation.
4256
42572019-09-11 Christian Biesinger <cbiesinger@google.com>
4258
4259 * dbxread.c (read_dbx_symtab): Update.
4260 * dwarf2read.c (load_partial_dies): Update.
4261 * mdebugread.c (parse_partial_symbols): Update.
4262 (handle_psymbol_enumerators): Update.
4263 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4264 * psymtab.c (add_psymbol_to_bcache): Likewise.
4265 (add_psymbol_to_list): Likewise.
4266 * symtab.c (symbol_set_names): Likewise.
4267 * symtab.h (symbol_set_names): Likewise.
4268 * xcoffread.c (scan_xcoff_symtab): Update.
4269
42702019-09-11 Tom Tromey <tom@tromey.com>
4271
4272 * symfile-mem.c (symbol_file_add_from_memory): Use
4273 bfd_set_filename.
4274 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4275 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4276
42772019-09-10 Tom Tromey <tromey@adacore.com>
4278
4279 * dwarf-index-write.c (write_psymbols): Extend error message.
4280 (debug_names::insert): Add Ada code.
4281 (debug_names::write_psymbols): Remove Ada check.
4282 (debug_names) <m_string_obstack>: New member.
4283 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4284 (gdb_index_symbol_name_matcher::matches): Remove.
4285 (mapped_index_base::find_name_components_bounds): Add "lang"
4286 parameter.
4287 (mapped_index_base::build_name_components): Also split names
4288 according to Ada syntax.
4289 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4290 type of "match_callback".
4291 (check_match, check_find_bounds_finds)
4292 (dw2_expand_symtabs_matching): Update.
4293 (dw2_debug_names_iterator): Add new constructor.
4294 (dw2_debug_names_map_matching_symbols): New function.
4295 (dw2_debug_names_expand_symtabs_matching): Update.
4296 (dwarf2_debug_names_functions): Use
4297 dw2_debug_names_map_matching_symbols.
4298
42992019-09-10 Tom Tromey <tromey@adacore.com>
4300
4301 * dwarf2read.c (dw2_get_file_names_reader): Add the
4302 CU's file name to the results.
4303
43042019-09-10 Tom Tromey <tromey@adacore.com>
4305
4306 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4307 map_matching_symbols. Update.
4308 * dwarf2read.c (dw2_map_matching_symbols): Update.
4309 * psymtab.c (match_partial_symbol): Change type; update.
4310 (psym_map_matching_symbols): Likewise.
4311 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4312 type; update.
4313 * symfile.h (struct quick_symbol_functions)
4314 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4315 Remove "match".
4316
43172019-09-10 Tom Tromey <tromey@adacore.com>
4318
4319 * psymtab.c (map_block): Remove.
4320 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4321 * symtab.c (iterate_over_symbols_terminated): New function.
4322 * symtab.c (iterate_over_symbols_terminated): Declare.
4323
43242019-09-10 Tom Tromey <tromey@adacore.com>
4325
4326 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4327 * language.h (struct language_defn) <la_iterate_over_symbols>:
4328 Return bool.
4329 * symtab.c (iterate_over_symbols): Return bool.
4330 * symtab.h (iterate_over_symbols): Return bool.
4331
43322019-09-10 Tom Tromey <tromey@adacore.com>
4333
4334 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4335 (add_nonlocal_symbols): Update.
4336 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4337 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4338 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4339 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4340 Change type of "callback". Remove "data".
4341
4342
43432019-09-09 Ali Tamur <tamur@google.com>
4344
4345 * dwarf2read.c (comp_unit_head): Update comment.
4346 (dwarf2_dwo_name): New function declaration.
4347 (dwarf_unit_type_name): New function declaration.
4348 (read_comp_unit_head): Add support for new compilation units,
4349 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4350 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4351 (currently named as "signature") in their header. Also clarify error
4352 messages.
4353 (lookup_dwo_id): New function. Returns the dwo id of the given
4354 compile unit.
4355 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4356 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4357 functions.
4358 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4359 (dwarf2_dwo_name): Get the dwo name if present.
4360 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4361 purposes.
4362
43632019-09-09 Tom Tromey <tom@tromey.com>
4364
4365 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4366
43672019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4368
4369 * python/python.c (do_start_initialization): Make progname_copy static,
4370 to avoid a leak report.
4371
43722019-09-08 Tom Tromey <tom@tromey.com>
4373
4374 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4375
43762019-09-07 Simon Marchi <simon.marchi@efficios.com>
4377
4378 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4379 Change type to gdb::optional<block_enum>.
4380 (dw2_symtab_iter_init): Change block_index parameter type
4381 to gdb::optional<block_enum>.
4382 (dw2_lookup_symbol): Change block_index parameter
4383 type to block_enum.c
4384 (dw2_debug_names_lookup_symbol): Likewise.
4385 * psymtab.c (psym_lookup_symbol): Likewise.
4386 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4387 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4388 Likewise.
4389
43902019-09-06 Christian Biesinger <cbiesinger@google.com>
4391
4392 * defs.h (relocate_gdb_directory): Change int to bool in
4393 signature and rename flag to relocatable.
4394 * main.c (relocate_path): Likewise.
4395 (relocate_gdb_directory): Likewise.
4396
43972019-09-06 Alan Modra <amodra@gmail.com>
4398
4399 * coffread.c (coff_symfile_read): Constify filename variable.
4400 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4401 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4402 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4403 * solib.c (reload_shared_libraries_1): Likewise.
4404 * symfile.c (reread_symbols): Likewise.
4405 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4406 * solib-darwin.c (darwin_bfd_open): Likewise.
4407 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4408
44092019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4410
4411 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4412 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4413
44142019-09-03 Tom Tromey <tromey@adacore.com>
4415
4416 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4417 types.
4418 (has_negatives): Unbias a range type bound.
4419 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4420 * gdbtypes.c (operator==): Handle new field.
4421 (create_range_type): Add "bias" parameter.
4422 (create_static_range_type, resolve_dynamic_range): Update.
4423 * gdbtypes.h (struct range_bounds) <bias>: New member.
4424 (create_range_type): Add bias parameter.
4425 * printcmd.c (print_scalar_formatted): Unbias range types.
4426 * value.c (unpack_long): Unbias range types.
4427 (pack_long): Bias range types.
4428
44292019-09-02 Alan Hayward <alan.hayward@arm.com>
4430
4431 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4432 probe arguments.
4433
44342019-09-02 Alan Hayward <alan.hayward@arm.com>
4435
4436 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4437 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4438 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4439 (compile_probe_arg): Likewise.
4440 * probe.h (get_argument_count): Likewise.
4441 * solib-svr4.c (solib_event_probe_action): Likewise.
4442 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4443
44442019-09-02 Alan Hayward <alan.hayward@arm.com>
4445
4446 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4447 code to here...
4448 (svr4_create_solib_event_breakpoints): ...from here.
4449
44502019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4451
4452 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4453 suffix from warning message.
4454
44552019-08-30 Tom Tromey <tom@tromey.com>
4456
4457 * tui/tui-winsource.h (struct tui_source_window_base)
4458 <refresh_all>: Don't declare.
4459 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4460 Remove.
4461 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4462 tui_show_locator_content.
4463 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4464 declare.
4465 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4466 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4467 declare.
4468
44692019-08-30 Tom Tromey <tom@tromey.com>
4470
4471 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4472
44732019-08-30 Tom Tromey <tom@tromey.com>
4474
4475 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4476 Remove unnecessary forward declarations.
4477
44782019-08-30 Tom Tromey <tom@tromey.com>
4479
4480 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4481 rerender.
4482 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4483 tui_show_locator_content.
4484
44852019-08-30 Tom Tromey <tom@tromey.com>
4486
4487 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4488 (tui_locator_window::rerender): Rewrite using body of previous
4489 tui_show_locator_content.
4490
44912019-08-30 Tom Tromey <tom@tromey.com>
4492
4493 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4494 set_locator_fullname>: New methods.
4495 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4496 Rename from tui_set_locator_fullname.
4497 (tui_locator_window::set_locator_info): Rename from
4498 tui_set_locator_info. Return bool.
4499 (tui_update_locator_fullname, tui_show_frame_info): Update.
4500
45012019-08-30 Tom Tromey <tom@tromey.com>
4502
4503 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4504
45052019-08-30 Tom Tromey <tom@tromey.com>
4506
4507 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4508 call touchwin.
4509
45102019-08-30 Tom Tromey <tom@tromey.com>
4511
4512 * tui/tui-wingeneral.c (box_win): Assume win_info and
4513 win_info->handle cannot be NULL.
4514
45152019-08-30 Tom Tromey <tom@tromey.com>
4516
4517 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4518 refresh_window>: Declare.
4519 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4520 resize.
4521 (tui_data_item_window::rerender): Rename from
4522 tui_display_register.
4523 (tui_data_item_window::refresh_window): New method.
4524 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4525 no-op.
4526
45272019-08-30 Tom Tromey <tom@tromey.com>
4528
4529 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4530 regs_column_count, current_group>: Move later. Now private.
4531 <get_current_group>: New method.
4532 * tui/tui-regs.c (tui_reg_command): Update.
4533 * tui/tui-layout.c (tui_set_layout): Update.
4534
45352019-08-30 Tom Tromey <tom@tromey.com>
4536
4537 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4538 (tui_data_window::rerender): Don't call
4539 check_and_display_highlight_if_needed.
4540 (tui_data_window::refresh_all): Remove call to
4541 erase_data_content.
4542
45432019-08-30 Tom Tromey <tom@tromey.com>
4544
4545 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4546 (tui_data_window::display_registers_from)
4547 (tui_data_window::display_reg_element_at_line)
4548 (tui_data_window::display_registers_from_line): Remove checks of
4549 "empty".
4550
45512019-08-30 Tom Tromey <tom@tromey.com>
4552
4553 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4554 Don't declare.
4555 * tui/tui-regs.c (tui_data_window::show_registers): Call
4556 rerender.
4557 (tui_data_window::rerender): Rename from display_all_data.
4558 (tui_data_window::rerender): Remove old implementation.
4559
45602019-08-30 Tom Tromey <tom@tromey.com>
4561
4562 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4563 text.
4564 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4565
45662019-08-29 Bernhard Wodok <barto@gmx.net>
4567 Sergio Durigan Junior <sergiodj@redhat.com>
4568
4569 PR win32/24284
4570 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4571
45722019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4573
4574 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4575 when searching for types.
4576
45772019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4578
4579 * f-lang.c (f_language_defn): Use f_print_typedef.
4580 * f-lang.h (f_print_typedef): Declare.
4581 * f-typeprint.c (f_print_typedef): Define.
4582
45832019-08-27 Christian Biesinger <cbiesinger@google.com>
4584
4585 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4586
45872019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4588
4589 * cli/cli-utils.c (info_print_options_defs): Delete.
4590 (make_info_print_options_def_group): Delete.
4591 (extract_info_print_options): Delete.
4592 (info_print_command_completer): Delete.
4593 (info_print_args_help): Add extra parameter, and optionally
4594 include text about -n flag.
4595 * cli/cli-utils.h (struct info_print_options): Delete.
4596 (extract_info_print_options): Delete declaration.
4597 (info_print_command_completer): Delete declaration.
4598 (info_print_args_help): Add extra parameter, extend header
4599 comment.
4600 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4601 search_symbols.
4602 * stack.c (struct info_print_options): New type.
4603 (info_print_options_defs): New file scoped variable.
4604 (make_info_print_options_def_group): New static function.
4605 (info_print_command_completer): New static function.
4606 (info_locals_command): Update to use new local functions.
4607 (info_args_command): Likewise.
4608 (_initialize_stack): Add extra parameter to calls to
4609 info_print_args_help.
4610 * symtab.c (search_symbols): Add extra parameter, use this to
4611 possibly excluse non-debug symbols.
4612 (symtab_symbol_info): Add extra parameter, which is passed on to
4613 search_symbols.
4614 (struct info_print_options): New type.
4615 (info_print_options_defs): New file scoped variable.
4616 (make_info_print_options_def_group): New static function.
4617 (info_print_command_completer): New static function.
4618 (info_variables_command): Update to use local functions, and pass
4619 extra parameter through to symtab_symbol_info.
4620 (info_functions_command): Likewise.
4621 (info_types_command): Pass additional argument through to
4622 symtab_symbol_info.
4623 (rbreak_command): Pass extra argument to search_symbols.
4624 (_initialize_symtab): Add extra arguments for calls to
4625 info_print_args_help, and update help text for 'info variables',
4626 'whereis', and 'info functions' commands.
4627 * symtab.h (search_symbols): Add extra argument to declaration.
4628 * NEWS: Mention new flags.
4629
46302019-08-26 Christian Biesinger <cbiesinger@google.com>
4631
4632 * symtab.c (lookup_static_symbol): Call the new function (and move
4633 it down to be next to lookup_global_symbol).
4634 (struct global_sym_lookup_data): Add block_enum member and rename to...
4635 (struct global_or_static_sym_lookup_data): ...this.
4636 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4637 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4638 (lookup_symbol_global_or_static_iterator_cb): ...this.
4639 (lookup_global_or_static_symbol): New function.
4640 (lookup_global_symbol): Call new function.
4641
46422019-08-26 Tom de Vries <tdevries@suse.de>
4643
4644 PR c++/24852
4645 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4646 when pc_probe.prob == NULL.
4647
46482019-08-25 Simon Marchi <simon.marchi@efficios.com>
4649
4650 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4651 variable symbol_linkage to symbol_linkage_.
4652
46532019-08-25 Simon Marchi <simon.marchi@efficios.com>
4654
4655 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4656 represent whether the symbol is static, dynamic, or we don't
4657 know.
4658
46592019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4660
4661 * gdb/rx-tdep.c (rx_register_names): New.
4662 (rx_register_name): Delete.
4663 (rx_psw_type): Delete.
4664 (rx_fpsw_type): Delete.
4665 (rx_register_type): Delete.
4666 (rx_gdbarch_init): Convert target-descriptions.
4667 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4668 * gdb/features/Makefile: Add rx.xml.
4669 * gdb/features/rx.xml: New.
4670 * gdb/features/rx.c: Generated.
4671 * gdb/NEWS: Mention target description support.
4672
46732019-08-22 Christian Biesinger <cbiesinger@google.com>
4674
4675 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4676 *slot_ptr.
4677
46782019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4679
4680 * configure.ac: Don't check for 'dlfcn.h' (moved to
4681 gdbsupport/common.m4).
4682 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4683 'gdbsupport/'.
4684 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4685 * compile/compile-c-support.c: Include
4686 'gdbsupport/gdb-dlfcn.h'.
4687 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4688 * gdb-dlfcn.c: Move to...
4689 * gdbsupport/gdb-dlfcn.c: ... here.
4690 * gdb-dlfcn.h: Move to...
4691 * gdbsupport/gdb-dlfcn.h: ... here.
4692
46932019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4694
4695 * nios2-tdep.c (struct reg_value): Improve comments. Make
4696 the offset field signed.
4697
46982019-08-22 Christian Biesinger <cbiesinger@google.com>
4699
4700 * python/lib/gdb/__init__.py (_execute_file): New function.
4701 * python/python.c (python_run_simple_file): Call gdb._execute_file
4702 on Windows.
4703
47042019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4705
4706 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4707 all uses as this was never set to anything but a zero value.
4708
47092019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4710
4711 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4712
47132019-08-21 Christian Biesinger <cbiesinger@google.com>
4714
4715 * tui/tui-data.h (tui_gen_win_info): Add an =default
4716 move constructor, required by some GCC versions.
4717
47182019-08-21 Jinke Fan <fanjinke51@yeah.net>
4719
4720 * go32-nat.c (go32_sysinfo): Add hygon_p.
4721
47222019-08-20 Tom Tromey <tom@tromey.com>
4723
4724 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4725 line_from_reg_element_no, first_reg_element_no_inline,
4726 display_all_data, delete_data_content_windows,
4727 erase_data_content>: Now private.
4728
47292019-08-20 Tom Tromey <tom@tromey.com>
4730
4731 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4732 (tui_unhighlight_win, tui_highlight_win)
4733 (tui_win_info::make_window): Update.
4734 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4735
47362019-08-20 Tom Tromey <tom@tromey.com>
4737
4738 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4739 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4740 (MAX_PID_WIDTH): Move to tui-stack.c.
4741 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4742 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4743 (MAX_PID_WIDTH): Move from tui-data.h.
4744
47452019-08-20 Tom Tromey <tom@tromey.com>
4746
4747 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4748 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4749 (box_win): Update.
4750 (tui_gen_win_info::make_window): Rename from tui_make_window.
4751 (tui_win_info::make_window): New method.
4752 (tui_gen_win_info::make_visible): Update.
4753 * tui/tui-source.c (tui_source_window::set_contents): Update.
4754 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4755 (tui_data_window::display_registers_from): Update.
4756 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4757 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4758 Declare.
4759 <can_box>: Remove.
4760 <title>: Remove.
4761 (struct tui_win_info) <make_window>: Declare.
4762 <can_box>: Now virtual.
4763 <title>: New member.
4764 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4765 * tui/tui-command.c (tui_cmd_window::resize): Update.
4766
47672019-08-20 Tom Tromey <tom@tromey.com>
4768
4769 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4770 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4771 (tui_data_window::check_register_values): Update.
4772
47732019-08-20 Tom Tromey <tom@tromey.com>
4774
4775 * tui/tui-regs.h (struct tui_data_window): Use
4776 DISABLE_COPY_AND_ASSIGN.
4777 <regs_content>: Change type, removing unique_ptr.
4778 <tui_data_window>: Add move constructor.
4779 * tui/tui-regs.c (tui_data_window::show_registers)
4780 (tui_data_window::show_register_group)
4781 (tui_data_window::display_registers_from)
4782 (tui_data_window::display_registers_from)
4783 (tui_data_window::first_data_item_displayed)
4784 (tui_data_window::delete_data_content_windows)
4785 (tui_data_window::rerender, tui_data_window::refresh_window)
4786 (tui_data_window::check_register_values): Update.
4787
47882019-08-20 Tom Tromey <tom@tromey.com>
4789
4790 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4791 show_register_group>: Declare.
4792 (tui_show_register_group): Don't declare.
4793 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4794 tui_show_registers.
4795 (tui_data_window::show_register_group): Rename from
4796 tui_show_register_group.
4797 (tui_data_window::check_register_values, tui_reg_command):
4798 Update.
4799 * tui/tui-layout.c (tui_set_layout): Update.
4800
48012019-08-20 Tom Tromey <tom@tromey.com>
4802
4803 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4804 Declare.
4805 (tui_check_register_values): Don't declare.
4806 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4807 from tui_check_register_values.
4808 * tui/tui-hooks.c (tui_register_changed): Update.
4809
48102019-08-20 Tom Tromey <tom@tromey.com>
4811
4812 * tui/tui-regs.c (tui_reg_layout): Move later.
4813 (tui_show_registers): Don't enable TUI mode or change layout.
4814
48152019-08-20 Tom Tromey <tom@tromey.com>
4816
4817 * tui/tui-regs.h (struct tui_data_item_window)
4818 <~tui_data_item_window>: Remove.
4819 <content>: Now a unique_xmalloc_ptr.
4820 * tui/tui-regs.c (tui_register_format): Return a
4821 unique_xmalloc_ptr.
4822 (tui_get_register): Update.
4823 (~tui_data_item_window): Remove.
4824 (tui_data_window::display_registers_from, tui_display_register):
4825 Update.
4826 * tui/tui-io.h (tui_expand_tabs): Update.
4827 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4828 Remove "col" parameter.
4829
48302019-08-20 Tom Tromey <tom@tromey.com>
4831
4832 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4833 field.
4834 * tui/tui-regs.c (~tui_data_item_window): Update.
4835
48362019-08-20 Tom Tromey <tom@tromey.com>
4837
4838 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4839 earlier.
4840
48412019-08-20 Tom Tromey <tom@tromey.com>
4842
4843 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4844
48452019-08-20 Tom Tromey <tom@tromey.com>
4846
4847 * tui/tui-source.h (struct tui_source_window): Update.
4848 * tui/tui-regs.c (tui_show_registers): Update.
4849 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4850 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4851 (NO_REGS_STRING): Remove defines.
4852
48532019-08-20 Conrad Meyer <cem@FreeBSD.org>
4854
4855 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4856 unnecessary thread walk if remote doesn't support the packet.
4857
48582019-08-19 Tom Tromey <tromey@adacore.com>
4859
4860 * python/py-value.c (value_has_field): Fix indentation.
4861
48622019-08-19 Tom Tromey <tromey@adacore.com>
4863
4864 * printcmd.c (do_one_display, info_display_command): Update.
4865 * block.h (contained_in): Return bool. Add allow_nested
4866 parameter.
4867 * block.c (contained_in): Return bool. Add allow_nested
4868 parameter.
4869
48702019-08-19 Tom Tromey <tom@tromey.com>
4871
4872 * configure: Rebuild.
4873 * configure.ac: Disallow the combination of -static-libstdc++ and
4874 source highlight.
4875 * source-cache.c (get_language_name): Handle rust.
4876 (source_cache::get_source_lines): Ignore highlighting exceptions.
4877
48782019-08-16 Tom Tromey <tom@tromey.com>
4879
4880 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4881 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4882 (struct tui_source_window_base) <make_visible, refresh_window,
4883 resize>: Remove methods.
4884 <execution_info>: Remove field.
4885 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4886 (tui_show_source_line, tui_source_window_base)
4887 (~tui_source_window_base): Update.
4888 (tui_source_window_base::resize)
4889 (tui_source_window_base::make_visible)
4890 (tui_source_window_base::refresh_window): Remove.
4891 (tui_source_window_base::update_exec_info): Update.
4892 * tui/tui-source.c (tui_source_window::set_contents): Update.
4893 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4894
48952019-08-16 Tom Tromey <tom@tromey.com>
4896
4897 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4898 deprecated_query_hook.
4899
49002019-08-16 Tom Tromey <tom@tromey.com>
4901
4902 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4903 (tui_update_source_windows_with_line): Update.
4904 * tui/tui-source.h (struct tui_source_window)
4905 <show_symtab_source>: Declare.
4906 (tui_show_symtab_source): Don't declare.
4907 * tui/tui-source.c (tui_show_symtab_source): Rename from
4908 tui_show_symtab_source.
4909
49102019-08-16 Tom Tromey <tom@tromey.com>
4911
4912 * tui/tui-winsource.h (struct tui_source_window_base)
4913 <set_contents>: Declare.
4914 * tui/tui-winsource.c
4915 (tui_source_window_base::update_source_window_as_is): Update.
4916 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4917 Declare.
4918 (tui_set_source_content): Don't declare.
4919 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4920 tui_set_source_content.
4921 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4922 Declare.
4923 (tui_set_disassem_content): Don't declare.
4924 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4925 tui_set_disassem_content.
4926
49272019-08-16 Tom Tromey <tom@tromey.com>
4928
4929 * tui/tui-winsource.h (struct tui_source_window_base)
4930 <update_breakpoint_info>: Declare.
4931 (tui_update_breakpoint_info): Don't declare.
4932 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4933 (tui_update_all_breakpoint_info): Update.
4934 (tui_source_window_base::update_breakpoint_info): Rename from
4935 tui_update_breakpoint_info.
4936 (tui_source_window_base::update_exec_info): Update.
4937
49382019-08-16 Tom Tromey <tom@tromey.com>
4939
4940 * tui/tui-winsource.h (struct tui_source_window_base)
4941 <update_source_window>: Declare.
4942 (tui_update_source_window): Don't declare.
4943 * tui/tui-winsource.c
4944 (tui_source_window_base::update_source_window): Rename from
4945 tui_update_source_window.
4946 (tui_source_window_base::rerender): Update.
4947 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4948 * tui/tui-disasm.c (tui_show_disassem)
4949 (tui_show_disassem_and_update_source)
4950 (tui_disasm_window::maybe_update): Update.
4951
49522019-08-16 Tom Tromey <tom@tromey.com>
4953
4954 * tui/tui-winsource.h (struct tui_source_window_base)
4955 <update_source_window_as_is>: Declare.
4956 (tui_update_source_window_as_is): Don't declare.
4957 * tui/tui-winsource.c (tui_update_source_window): Update
4958 (tui_source_window_base::update_source_window_as_is): Rename from
4959 tui_update_source_window_as_is.
4960 (tui_source_window_base::refill): Update.
4961 * tui/tui-source.c (tui_show_symtab_source): Update.
4962 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4963 Update.
4964
49652019-08-16 Tom Tromey <tom@tromey.com>
4966
4967 * tui/tui-winsource.h (tui_update_source_window)
4968 (tui_update_source_window_as_is): Remove "noerror" parameter.
4969 * tui/tui-winsource.c (tui_update_source_window)
4970 (tui_update_source_window_as_is): Remove "noerror" parameter.
4971 (tui_update_source_windows_with_addr)
4972 (tui_update_source_windows_with_line)
4973 (tui_source_window_base::rerender)
4974 (tui_source_window_base::refill): Update.
4975 * tui/tui-source.h (tui_set_source_content)
4976 (tui_show_symtab_source): Remove "noerror" parameter.
4977 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4978 parameter.
4979 (tui_show_symtab_source): Likewise.
4980 (tui_source_window::maybe_update): Update.
4981 * tui/tui-disasm.c (tui_show_disassem)
4982 (tui_show_disassem_and_update_source)
4983 (tui_disasm_window::do_scroll_vertical)
4984 (tui_disasm_window::maybe_update): Update.
4985
49862019-08-16 Tom Tromey <tom@tromey.com>
4987
4988 * tui/tui.c (tui_is_window_visible): Update.
4989 * tui/tui-wingeneral.c (tui_make_window)
4990 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4991 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4992 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4993 (tui_set_win_height_command, parse_scrolling_args): Update.
4994 * tui/tui-source.c (tui_source_window::style_changed): Update.
4995 * tui/tui-regs.c (tui_show_registers)
4996 (tui_data_window::first_data_item_displayed)
4997 (tui_data_window::delete_data_content_windows)
4998 (tui_check_register_values, tui_reg_command): Update.
4999 * tui/tui-disasm.c (tui_show_disassem): Update.
5000 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5001 method.
5002 <is_visible>: Remove field.
5003 * tui/tui-data.c (tui_next_win, tui_prev_win)
5004 (tui_delete_invisible_windows): Update.
5005
50062019-08-16 Tom Tromey <tom@tromey.com>
5007
5008 * tui/tui-winsource.h (struct tui_source_window_base)
5009 <m_has_locator>: Remove.
5010 * tui/tui-layout.c (show_source_disasm_command, show_data)
5011 (show_source_or_disasm_and_command): Update.
5012
50132019-08-16 Alan Hayward <alan.hayward@arm.com>
5014
5015 * NEWS (Other MI changes): New subsection.
5016 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5017 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5018 * arch-utils.c (default_get_pc_address_flags): New function.
5019 * arch-utils.h (default_get_pc_address_flags): New declaration.
5020 * gdbarch.sh: Add get_pc_address_flags.
5021 * gdbarch.c: Regenerate.
5022 * gdbarch.h: Likewise.
5023 * stack.c (print_pc): New function.
5024 (print_frame_info) (print_frame): Call print_pc.
5025
50262019-08-16 Tom de Vries <tdevries@suse.de>
5027
5028 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5029 print_objfile_section_info.
5030
50312019-08-15 Tom Tromey <tom@tromey.com>
5032
5033 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5034 calling update_cmdwin_start_line.
5035 * tui/tui-winsource.h (struct tui_source_window_base)
5036 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5037 <rerender>: Declare.
5038 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5039 Call rerender.
5040 (tui_source_window_base::set_new_height): Remove.
5041 (tui_source_window_base::rerender): Rename from
5042 do_make_visible_with_new_height.
5043 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5044 resize method.
5045 (tui_win_info::make_invisible_and_set_new_height)
5046 (tui_win_info::make_visible_with_new_height): Remove.
5047 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5048 Declare.
5049 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5050 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5051 do_make_visible_with_new_height>: Don't declare.
5052 <rerender>: Declare.
5053 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5054 set_new_height.
5055 (tui_data_window::do_make_visible_with_new_height): Remove.
5056 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5057 call tui_show_locator_content.
5058 (tui_gen_win_info::resize): Call rerender.
5059 (show_source_or_disasm_and_command): Don't call
5060 tui_show_locator_content.
5061 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5062 method.
5063 (struct tui_win_info) <rerender>: Declare.
5064 <set_new_height, make_invisible_and_set_new_height,
5065 make_visible_with_new_height>: Don't declare.
5066 * tui/tui-data.c (tui_win_list::rerender): New method.
5067 * tui/tui-command.h (struct tui_cmd_window)
5068 <do_make_visible_with_new_height>: Don't declare.
5069 * tui/tui-command.c
5070 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5071
50722019-08-15 Tom Tromey <tromey@adacore.com>
5073
5074 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5075 * ada-lang.c (ada_enum_name): Likewise.
5076
50772019-08-15 Christian Biesinger <cbiesinger@google.com>
5078
5079 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5080 leading underscore.
5081 (GdbOutputErrorFile): Likewise.
5082 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5083 accordingly.
5084 (execute_unwinders): Rename to have a leading underscore.
5085 (auto_load_packages): Likewise.
5086 (global scope): Adjust call to auto_load_packages accordingly.
5087 (GdbSetPythonDirectory): Likewise.
5088 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5089 instead of execute_unwinders.
5090
50912019-08-15 Tom Tromey <tom@tromey.com>
5092
5093 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5094 (show_data): Don't change window visibility.
5095 (tui_gen_win_info::resize): Remove special case for command
5096 window. Use wresize, when available.
5097 (show_source_or_disasm_and_command): Don't change window
5098 visibility.
5099 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5100 <make_visible>: New method.
5101 * tui/tui-command.c (tui_cmd_window::resize): New method.
5102
51032019-08-15 Tom Tromey <tom@tromey.com>
5104
5105 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5106 (struct tui_source_windows): New.
5107 * tui/tui-winsource.c (tui_display_main): Update.
5108 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5109 (new_height_ok, parse_scrolling_args): Update.
5110 * tui/tui-layout.c (show_layout, show_data): Update.
5111 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5112 (tui_add_to_source_windows): Don't declare.
5113 * tui/tui-data.c (source_windows, tui_source_windows)
5114 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5115
51162019-08-15 Tom Tromey <tom@tromey.com>
5117
5118 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5119 Rename from reset.
5120 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5121 * tui/tui-layout.c (show_source_disasm_command, show_data):
5122 Update.
5123 (tui_gen_win_info::resize): Rename.
5124 (show_source_or_disasm_and_command): Update.
5125 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5126 reset.
5127
51282019-08-15 Tom Tromey <tom@tromey.com>
5129
5130 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5131 * tui/tui-interp.c (tui_interp::init): Don't call
5132 tui_initialize_static_data.
5133 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5134
51352019-08-15 Tom Tromey <tom@tromey.com>
5136
5137 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5138 examine tui_win_list.
5139
51402019-08-15 Tom Tromey <tom@tromey.com>
5141
5142 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5143 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5144 tui_clear_source_content.
5145 (tui_clear_source_content): Remove.
5146 (tui_source_window_base::do_erase_source_content): Hoist call to
5147 content.clear().
5148 * tui/tui-stack.c (tui_show_frame_info): Don't call
5149 tui_clear_source_content.
5150
51512019-08-15 Tom Tromey <tom@tromey.com>
5152
5153 * tui/tui-winsource.h (struct tui_source_window_base)
5154 <do_erase_source_content>: New method.
5155 <erase_source_content>: New method.
5156 (tui_erase_source_content): Don't declare.
5157 * tui/tui-winsource.c (tui_clear_source_content): Update.
5158 (tui_source_window_base::do_erase_source_content): Rename from
5159 tui_erase_source_content.
5160 (tui_source_window_base::show_source_content): Update.
5161 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5162 * tui/tui-source.h (struct tui_source_window)
5163 <erase_source_content>: New method.
5164 * tui/tui-disasm.h (struct tui_disasm_window)
5165 <erase_source_content>: New method.
5166
51672019-08-15 Tom Tromey <tom@tromey.com>
5168
5169 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5170 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5171 constructor.
5172 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5173 * tui/tui-source.c (tui_set_source_content): Update.
5174 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5175
51762019-08-15 Tom Tromey <tom@tromey.com>
5177
5178 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5179 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5180 tui-source.c.
5181 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5182 Declare.
5183 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5184 method.
5185 (tui_source_window::maybe_update): Update.
5186
51872019-08-15 Tom Tromey <tom@tromey.com>
5188
5189 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5190 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5191 tui-disasm.c.
5192 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5193 Declare.
5194 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5195 method.
5196 (tui_disasm_window::maybe_update): Update.
5197
51982019-08-15 Tom Tromey <tom@tromey.com>
5199
5200 * tui/tui-winsource.h (struct tui_source_window_base)
5201 <maybe_update>: Declare.
5202 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5203 method.
5204 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5205 Declare.
5206 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5207 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5208 Declare.
5209 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5210
52112019-08-15 Tom Tromey <tom@tromey.com>
5212
5213 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5214
52152019-08-15 Tom Tromey <tom@tromey.com>
5216
5217 * tui/tui-wingeneral.c: Include tui-stack.h.
5218 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5219 (struct tui_locator_window): Move from tui-data.h.
5220 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5221 (tui_initialize_static_data): Move from tui-data.c.
5222 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5223 (struct tui_locator_window): Move to tui-stack.c.
5224 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5225 (tui_initialize_static_data): Move to tui-stack.c.
5226
52272019-08-15 Tom Tromey <tom@tromey.com>
5228
5229 * tui/tui-layout.c (show_source_disasm_command)
5230 (show_source_or_disasm_and_command): Use make_visible method, not
5231 tui_make_window.
5232 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5233 Remove.
5234
52352019-08-15 Tom Tromey <tom@tromey.com>
5236
5237 * tui/tui-wingeneral.h (tui_make_window): Update.
5238 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5239 parameter.
5240 (tui_gen_win_info::make_visible): Update.
5241 * tui/tui-regs.c (tui_data_window::display_registers_from):
5242 Update.
5243 * tui/tui-layout.c (show_source_disasm_command)
5244 (show_source_or_disasm_and_command): Update.
5245 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5246 (enum tui_box): Remove.
5247 (struct tui_win_info) <can_box>: New method.
5248 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5249 method.
5250
52512019-08-15 Tom de Vries <tdevries@suse.de>
5252
5253 * linux-nat-trad.c: Include gdbarch.h.
5254
52552019-08-14 Alan Hayward <alan.hayward@arm.com>
5256
5257 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5258 register sizes.
5259
52602019-08-14 Tom Tromey <tromey@adacore.com>
5261
5262 * darwin-nat.c: Include gdbarch.h.
5263 * darwin-nat-info.c: Include gdbarch.h.
5264
52652019-08-13 Tom Tromey <tom@tromey.com>
5266
5267 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5268 Remove.
5269 * tui/tui-data.c (tui_initialize_static_data): Update.
5270
52712019-08-13 Tom Tromey <tom@tromey.com>
5272
5273 * tui/tui-winsource.h (struct tui_exec_info_window)
5274 <~tui_exec_info_window, maybe_allocate_content, get_content,
5275 m_content>: Remove.
5276 (struct tui_source_window_base) <set_exec_info_content,
5277 show_exec_info_content>: Don't declare.
5278 * tui/tui-winsource.c
5279 (tui_exec_info_window::maybe_allocate_content): Remove.
5280 (tui_source_window_base::update_exec_info): Rename from
5281 set_exec_info_content.
5282 (tui_source_window_base::show_exec_info_content)
5283 (tui_source_window_base::update_exec_info): Remove.
5284
52852019-08-13 Tom Tromey <tom@tromey.com>
5286
5287 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5288 declare.
5289 * tui/tui-winsource.c (tui_update_source_window_as_is)
5290 (tui_update_source_windows_with_addr, tui_erase_source_content):
5291 Update.
5292 (tui_clear_exec_info_content): Remove.
5293
52942019-08-13 Tom Tromey <tom@tromey.com>
5295
5296 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5297 declare.
5298 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5299 call tui_erase_exec_info_content.
5300 (tui_clear_exec_info_content): Rename from
5301 tui_erase_exec_info_content.
5302 (tui_clear_exec_info_content): Delete.
5303
53042019-08-13 Tom Tromey <tom@tromey.com>
5305
5306 * tui/tui-winsource.h (struct tui_source_window_base)
5307 <show_exec_info_content>: Declare.
5308 (tui_show_exec_info_content): Don't declare.
5309 * tui/tui-winsource.c
5310 (tui_source_window_base::show_exec_info_content): Rename from
5311 tui_show_exec_info_content.
5312 (tui_source_window_base::update_exec_info): Update.
5313
53142019-08-13 Tom Tromey <tom@tromey.com>
5315
5316 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5317 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5318 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5319 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5320 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5321 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5322 ... here.
5323
53242019-08-13 Tom Tromey <tom@tromey.com>
5325
5326 * tui/tui-winsource.h (struct tui_source_window_base)
5327 <update_exec_info>: Declare.
5328 (tui_update_exec_info): Don't declare.
5329 * tui/tui-winsource.c (tui_update_source_window_as_is)
5330 (tui_source_window_base::refresh_all)
5331 (tui_update_all_breakpoint_info): Update.
5332 (tui_source_window_base::update_exec_info): Rename from
5333 tui_update_exec_info.
5334 * tui/tui-stack.c (tui_show_frame_info): Update.
5335
53362019-08-13 Tom Tromey <tom@tromey.com>
5337
5338 * tui/tui-winsource.h (struct tui_source_window_base)
5339 <set_exec_info_content>: Declare.
5340 (tui_set_exec_info_content): Don't declare.
5341 * tui/tui-winsource.c
5342 (tui_source_window_base::set_exec_info_content): Rename from
5343 tui_set_exec_info_content.
5344 (tui_update_exec_info): Update.
5345
53462019-08-13 Tom Tromey <tom@tromey.com>
5347
5348 * tui/tui-winsource.h (struct tui_source_window_base)
5349 <show_source_content>: Declare.
5350 (tui_show_source_content): Don't declare.
5351 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5352 (tui_source_window_base::show_source_content): Rename from
5353 tui_show_source_content.
5354 (tui_source_window_base::refresh_all): Update.
5355 * tui/tui-layout.c (show_source_disasm_command)
5356 (show_source_or_disasm_and_command): Update.
5357
53582019-08-13 Tom Tromey <tom@tromey.com>
5359
5360 * tui/tui-winsource.c (tui_erase_source_content)
5361 (tui_show_source_content, tui_source_window_base::refresh_all):
5362 Update.
5363 * tui/tui-wingeneral.h
5364 (tui_check_and_display_highlight_if_needed): Don't declare.
5365 * tui/tui-wingeneral.c
5366 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5367 check_and_display_highlight_if_needed.
5368 * tui/tui-win.c (tui_rehighlight_all)
5369 (tui_win_info::make_visible_with_new_height): Update.
5370 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5371 (tui_data_window::erase_data_content)
5372 (tui_data_window::display_all_data): Update.
5373 * tui/tui-data.h (struct tui_win_info)
5374 <check_and_display_highlight_if_needed>: Declare.
5375
53762019-08-13 Tom Tromey <tom@tromey.com>
5377
5378 * tui/tui-win.c (tui_resize_all): Call
5379 tui_delete_invisible_windows.
5380 * tui/tui-layout.c (show_layout): Call
5381 tui_delete_invisible_windows.
5382 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5383 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5384
53852019-08-13 Tom Tromey <tom@tromey.com>
5386
5387 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5388 tui_add_win_to_layout.
5389
53902019-08-13 Tom Tromey <tom@tromey.com>
5391
5392 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5393 * tui/tui-layout.c (tui_default_win_height): Now static.
5394
53952019-08-13 Tom Tromey <tom@tromey.com>
5396
5397 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5398 single switch.
5399 (show_source_disasm_command, show_source_or_disasm_and_command):
5400 Don't check current layout.
5401
54022019-08-13 Tom Tromey <tom@tromey.com>
5403
5404 * tui/tui-wingeneral.c (make_all_visible): Remove.
5405 (tui_make_all_invisible): Simplify.
5406 * tui/tui-layout.c (tui_make_all_invisible): Move from
5407 tui-wingeneral.c; simplify.
5408 (show_layout): Hoist call to tui_make_all_invisible.
5409 (show_data): Don't call tui_make_all_invisible.
5410
54112019-08-13 Tom Tromey <tom@tromey.com>
5412
5413 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5414 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5415
54162019-08-13 Tom Tromey <tom@tromey.com>
5417
5418 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5419 tui-data.c.
5420 (show_source_disasm_command, show_data)
5421 (show_source_or_disasm_and_command): Don't use
5422 tui_set_current_layout_to.
5423 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5424 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5425 tui-layout.c.
5426 (tui_set_current_layout_to): Remove.
5427
54282019-08-13 Tom Tromey <tom@tromey.com>
5429
5430 * tui/tui-layout.c (tui_set_layout): Update.
5431 * tui/tui-data.h (struct tui_layout_def): Remove.
5432 (tui_layout_def): Don't declare.
5433 * tui/tui-data.c (layout_def): Remove.
5434 (tui_layout_def): Remove.
5435
54362019-08-13 Tom Tromey <tom@tromey.com>
5437
5438 * tui/tui-winsource.h (struct tui_source_window_base)
5439 <clear_detail>: No longer "override".
5440 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5441 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5442 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5443 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5444 Remove.
5445 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5446
54472019-08-13 Tom Tromey <tromey@adacore.com>
5448
5449 * tracepoint.c: Don't include readline.h or history.h.
5450
54512019-08-12 Tom Tromey <tom@tromey.com>
5452
5453 * configure: Rebuild.
5454 * configure.ac: Check for readline 7.
5455 * NEWS: Mention readline 7 requirement.
5456 * README: Update.
5457
54582019-08-12 Tom Tromey <tom@tromey.com>
5459
5460 * mingw-hdep.c (gdb_select): Remove readline hack.
5461
54622019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5463
5464 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5465 when the function fails.
5466
54672019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5468
5469 * s390-tdep.c (s390_type_align): New function.
5470 (s390_gdbarch_init): Set it as type_align gdbarch method.
5471
54722019-08-09 Tom de Vries <tdevries@suse.de>
5473
5474 PR gdb/24591
5475 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5476 pc_low with relocation offset.
5477
54782019-08-07 Tom Tromey <tromey@adacore.com>
5479
5480 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5481 (print_frame_args): Update.
5482 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5483 Update.
5484 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5485 * frame.h (struct frame_arg): Add initializers.
5486 <error>: Now a unique_xmalloc_ptr.
5487
54882019-08-07 Alan Hayward <alan.hayward@arm.com>
5489
5490 * NEWS: Expand the Pointer Authentication entry.
5491 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5492 (aarch64_frame_unmask_lr): ... to this.
5493 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5494 Call aarch64_frame_unmask_lr.
5495 * frame.c (struct frame_info): Add "masked" variable.
5496 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5497 (fprint_frame): Check for masked pc.
5498 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5499 declarations.
5500 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5501 * stack.c (print_frame): Check for masked pc.
5502
55032019-08-06 Tom Tromey <tom@tromey.com>
5504
5505 * stabsread.c (patch_block_stabs, read_one_struct_field)
5506 (read_enum_type): Use obstack_strndup.
5507 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5508 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5509 * dwarf2read.c (guess_full_die_structure_name)
5510 (anonymous_struct_prefix): Use obstack_strndup.
5511 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5512 * c-exp.y (yylex): Use obstack_strndup.
5513 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5514 (write_var_or_type): Use obstack_strndup.
5515
55162019-08-06 Tom Tromey <tom@tromey.com>
5517
5518 * symfile.c (reread_symbols): Use obstack_strdup.
5519 * stabsread.c (read_type): Use obstack_strdup.
5520 * gdb_obstack.h (obstack_strdup): New overload.
5521 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5522 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5523 (dwarf2_canonicalize_name): Use obstack_strdup.
5524 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5525 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5526 Use obstack_strdup.
5527
55282019-08-06 Tom Tromey <tom@tromey.com>
5529
5530 * gdb_obstack.h (obstack_strdup): Define.
5531 * gdb_obstack.c (obstack_strdup): Don't define.
5532
55332019-08-06 Tom Tromey <tom@tromey.com>
5534
5535 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5536 obstack_strdup.
5537 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5538 obstack_strdup.
5539 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5540 * stabsread.c (common_block_start): Use obstack_strdup.
5541 * objfiles.c (set_objfile_main_name, objfile): Use
5542 obstack_strdup.
5543 * namespace.c (add_using_directive): Use obstack_strdup.
5544 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5545 * jit.c (finalize_symtab): Use obstack_strdup.
5546 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5547 (guess_partial_die_structure_name, partial_die_info::fixup)
5548 (dwarf2_name): Use obstack_strdup.
5549 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5550 obstack_strdup.
5551 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5552 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5553 obstack_strdup.
5554 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5555
55562019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5557
5558 * unittests/help-doc-selftests.c: New file.
5559 * Makefile.in: Add the new file.
5560
55612019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5562
5563 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5564 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5565 the full first line, except when FOR_VALUE_PREFIX. In this case,
5566 the trailing '.' is not output, and the first character is uppercased.
5567 (print_help_for_command): Update call to print_doc_line.
5568 (print_doc_of_command): Likewise.
5569 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5570 * cli/cli-option.c (append_indented_doc): Do not append newline.
5571 (build_help_option): Append newline after first appended_indented_doc
5572 only if a second call is done.
5573 (build_help): Append 2 new lines before each option, except the first
5574 one.
5575 * compile/compile.c (_initialize_compile): Add new lines after
5576 %OPTIONS%, when not at the end of the help.
5577 Change help doc or code
5578 producing the help doc to respect the invariants.
5579 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5580 Also removed the new line after 'Options:', as all other commands
5581 do not put an empty line between 'Options:' and the first option.
5582 * printcmd.c (_initialize_printcmd): Likewise.
5583 * stack.c (_initialize_stack): Likewise.
5584 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5585 incorrectly telling COMMAND is optional.
5586 * ada-lang.c (_initialize_ada_language): Change help doc or code
5587 producing the help doc to respect the invariants.
5588 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5589 * breakpoint.c (_initialize_breakpoint): Likewise.
5590 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5591 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5592 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5593 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5594 _initialize_cli_style): Likewise.
5595 * corelow.c (core_target_info): Likewise.
5596 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5597 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5598 * filesystem.c (_initialize_filesystem): Likewise.
5599 * frame.c (_initialize_frame): Likewise.
5600 * gnu-nat.c (add_task_commands): Likewise.
5601 * infcall.c (_initialize_infcall): Likewise.
5602 * infcmd.c (_initialize_infcmd): Likewise.
5603 * interps.c (_initialize_interpreter): Likewise.
5604 * language.c (_initialize_language): Likewise.
5605 * linux-fork.c (_initialize_linux_fork): Likewise.
5606 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5607 * maint.c (_initialize_maint_cmds): Likewise.
5608 * memattr.c (_initialize_mem): Likewise.
5609 * printcmd.c (_initialize_printcmd): Likewise.
5610 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5611 _RegEx): Likewise.
5612 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5613 * record-btrace.c (_initialize_record_btrace): Likewise.
5614 * record-full.c (_initialize_record_full): Likewise.
5615 * record.c (_initialize_record): Likewise.
5616 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5617 * regcache.c (_initialize_regcache): Likewise.
5618 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5619 _initialize_remote): Likewise.
5620 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5621 * serial.c (_initialize_serial): Likewise.
5622 * skip.c (_initialize_step_skip): Likewise.
5623 * source.c (_initialize_source): Likewise.
5624 * stack.c (_initialize_stack): Likewise.
5625 * symfile.c (_initialize_symfile): Likewise.
5626 * symtab.c (_initialize_symtab): Likewise.
5627 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5628 * top.c (init_main): Likewise.
5629 * tracefile-tfile.c (tfile_target_info): Likewise.
5630 * tracepoint.c (_initialize_tracepoint): Likewise.
5631 * tui/tui-win.c (_initialize_tui_win): Likewise.
5632 * utils.c (add_internal_problem_command): Likewise.
5633 * valprint.c (value_print_option_defs): Likewise.
5634
56352019-08-06 Frank Ch. Eigler <fche@redhat.com>
5636
5637 PR build/24886
5638 * configure.ac: Drop enable-libmcheck support.
5639 * configure, config.in: Rebuild.
5640 * libmcheck.m4: Remove.
5641 * acinclude.m4: Don't include it.
5642 * Makefile.in: Don't distribute it.
5643 * top.c (print_gdb_configuration): Don't mention it.
5644
56452019-08-06 Tom Tromey <tom@tromey.com>
5646
5647 * utils.c (set_output_style): Sometimes pass stream to
5648 emit_style_escape.
5649 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5650 * record-btrace.c (btrace_insn_history): Update.
5651 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5652 method.
5653 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5654 Update initializers.
5655 <m_uiout>: New field.
5656 <m_di>: Move lower.
5657 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5658 Remove "uiout" parameter.
5659 (dump_insns): Update.
5660 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5661 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5662
56632019-08-06 Christian Biesinger <cbiesinger@google.com>
5664
5665 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5666 (error_in_psymtab_expansion): Likewise.
5667 (lookup_symbol_via_quick_fns): Likewise.
5668 (basic_lookup_transparent_type_quick): Likewise.
5669 (basic_lookup_transparent_type_1): Likewise.
5670
56712019-08-06 Tom Tromey <tromey@adacore.com>
5672
5673 * source.c (last_source_error): Now bool.
5674 (print_source_lines_base): Make "noprint" bool. Only open
5675 source file when last_source_visited changes.
5676
56772019-08-06 Tom Tromey <tromey@adacore.com>
5678
5679 * annotate.c (annotate_source_line): Use g_source_cache.
5680 * source-cache.c (source_cache::get_plain_source_lines): Change
5681 parameters. Populate m_offset_cache.
5682 (source_cache::ensure): New method.
5683 (source_cache::get_line_charpos): New method.
5684 (extract_lines): Move lower. Change parameters.
5685 (source_cache::get_source_lines): Move lower.
5686 * source-cache.h (class source_cache): Update comment.
5687 <get_line_charpos>: New method.
5688 <get_source_lines>: Update comment.
5689 <clear>: Clear m_offset_cache.
5690 <get_plain_source_lines>: Change parameters.
5691 <ensure>: New method
5692 <m_offset_cache>: New member.
5693 * source.c (forget_cached_source_info_for_objfile): Update.
5694 (info_source_command): Use g_source_cache.
5695 (find_source_lines, open_source_file_with_line_charpos): Remove.
5696 (print_source_lines_base, search_command_helper): Use g_source_cache.
5697 * source.h (open_source_file_with_line_charpos): Don't declare.
5698 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5699 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5700 Use g_source_cache.
5701
57022019-08-06 Tom Tromey <tromey@adacore.com>
5703
5704 * source-cache.c (source_cache::get_plain_source_lines):
5705 Remove "first_line" and "last_line" parameters.
5706 (source_cache::get_source_lines): Cache plain text.
5707 * source-cache.h (class source_cache)
5708 <get_plain_source_lines>: Update.
5709
57102019-08-06 Tom Tromey <tromey@adacore.com>
5711
5712 * source-cache.c (extract_lines): No longer a method.
5713 Changed type of parameter. Include final newline.
5714 (selftests::extract_lines_test): New function.
5715 (_initialize_source_cache): Likewise.
5716 * source-cache.h (class source_cache)
5717 <extract_lines>: Don't declare.
5718
57192019-08-06 Tom Tromey <tromey@adacore.com>
5720
5721 * breakpoint.c (init_breakpoint_sal): Update.
5722 (breakpoint): Update.
5723 * breakpoint.h (struct breakpoint) <filter>: Now a
5724 unique_xmalloc_ptr.
5725
57262019-08-05 Christian Biesinger <cbiesinger@google.com>
5727
5728 * NEWS: Mention dictionary access on blocks.
5729 * python/py-block.c (blpy_getitem): New function.
5730 (block_object_as_mapping): New struct.
5731 (block_object_type): Use new struct for tp_as_mapping field.
5732
57332019-08-05 Christian Biesinger <cbiesinger@google.com>
5734
5735 * objfiles.h (objfile): Add a comment describing partial symbols.
5736
57372019-08-05 Tom Tromey <tromey@adacore.com>
5738
5739 * compile/compile.c (_initialize_compile): Use _(), not N_().
5740 * thread.c (_initialize_thread): Use _(), not N_().
5741 * stack.c (_initialize_stack): Use _(), not N_().
5742 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5743
57442019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5745
5746 * dwarf2read.c (struct dw2_symtab_iterator):
5747 <want_specific_block>: Remove.
5748 <block_index>: Change type to gdb::optional.
5749 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5750 change type of BLOCK_INDEX parameter to gdb::optional.
5751 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5752 (dw2_lookup_symbol): Don't pass argument for
5753 WANT_SPECIFIC_BLOCK.
5754 (dw2_expand_symtabs_for_function): Don't pass argument for
5755 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5756 (class dw2_debug_names_iterator)
5757 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5758 parameter, change BLOCK_INDEX type to gdb::optional.
5759 <m_want_specific_block>: Remove.
5760 <m_block_index>: Change type to gdb::optional.
5761 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5762 gdb::optional. Re-write in function of gdb::optional.
5763 (dw2_debug_names_lookup_symbol): Don't pass argument for
5764 WANT_SPECIFIC_BLOCK.
5765 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5766 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5767 BLOCK_INDEX.
5768
57692019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5770
5771 * NEWS: Mention changes to "info sources" command.
5772
57732019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5774
5775 * symtab.c (filename_partial_match_opts): New struct type.
5776 (struct output_source_filename_data): New members
5777 regexp, c_regexp, partial_match.
5778 (output_source_filename): Use new members to decide to print file.
5779 (info_sources_option_defs): New variable.
5780 (make_info_sources_options_def_group, print_info_sources_header,
5781 info_sources_command_completer):
5782 New functions.
5783 (info_sources_command): Read new optional arguments.
5784 (_initialize_symtab): Update info sources help.
5785
57862019-08-02 Alexandre Oliva <oliva@adacore.com>
5787
5788 * ada-lang.c (exception_support_info_v0): Renamed from...
5789 (default_exception_support_info): ... this. Create new
5790 definition for v1.
5791 (ada_has_this_exception_support): Look up catch_handlers_sym.
5792 (ada_exception_support_info_sniffer): Try v0 after default.
5793
57942019-08-01 Tom Tromey <tromey@adacore.com>
5795
5796 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5797 gdbarch.h.
5798
57992019-08-01 Christian Biesinger <cbiesinger@google.com>
5800
5801 * s12z-tdep.c: Fix include path for s12z-opc.h.
5802
58032019-08-01 Alan Hayward <alan.hayward@arm.com>
5804
5805 * NEWS: Require GNU make 3.82.
5806
58072019-07-16 Tom Tromey <tom@tromey.com>
5808
5809 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5810 declare.
5811
58122019-07-30 Tom Tromey <tromey@adacore.com>
5813
5814 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5815
58162019-07-30 Kevin Buettner <kevinb@redhat.com>
5817
5818 * printcmd.c (print_address_symbolic): Print negative offsets.
5819 (build_address_symbolic): Force signed arithmetic when computing
5820 offset.
5821
58222019-07-30 Christian Biesinger <cbiesinger@google.com>
5823
5824 PR/24474: Add a function to lookup static variables.
5825 * NEWS: Mention this new function.
5826 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5827 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5828 * python/python.c (python_GdbMethods): Add new function.
5829
58302019-07-29 Christian Biesinger <cbiesinger@google.com>
5831
5832 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5833 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5834 (objfpy_lookup_static_symbol): New function.
5835 (objfile_object_methods): Add new functions.
5836
58372019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5838
5839 * NEWS: Mention 'set|show print frame-info'. Mention new
5840 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5841 backtrace argument. Mention that python frame filtering code
5842 is now consistent with what 'backtrace' command prints.
5843
58442019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5845
5846 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5847 comments.
5848 (print_frame_info_auto, print_frame_info_source_line,
5849 print_frame_info_location, print_frame_info_source_and_location,
5850 print_frame_info_location_and_address, print_frame_info_short_location):
5851 New declarations.
5852 (struct frame_print_options): New member print_frame_info.
5853 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5854 * stack.h (get_user_print_what_frame_info): New declaration.
5855 (frame_show_address): New declaration.
5856 * stack.c (print_frame_arguments_choices): New value 'presence'.
5857 (print_frame_info_auto, print_frame_info_source_line,
5858 print_frame_info_location, print_frame_info_source_and_location,
5859 print_frame_info_location_and_address, print_frame_info_short_location,
5860 print_frame_info_choices, print_frame_info_print_what): New definitions.
5861 (print_frame_args): Only print dots for args if print frame-arguments
5862 is 'presence'.
5863 (frame_print_option_defs): New element for "frame-info".
5864 (get_user_print_what_frame_info): New function.
5865 (frame_show_address): Make non static. Move comment to stack.h.
5866 (print_frame_info_to_print_what): New function.
5867 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5868 to decide what to print.
5869 (backtrace_command_1): Handle the new print_frame_arguments_presence
5870 value.
5871 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5872 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5873 (py_print_frame): In non-mi mode, use LOCATION as default for
5874 print_what, similarly to frame information printed directly by
5875 backtrace command. Handle frame-info user option in non MI mode.
5876
58772019-07-27 Kevin Buettner <kevinb@redhat.com>
5878
5879 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5880 Add case for debugging 32-bit target on 64-bit host. Revise
5881 comment.
5882
58832019-07-27 Kevin Buettner <kevinb@redhat.com>
5884
5885 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5886 instead of find_function_entry_range_from_pc.
5887
58882019-07-27 Kevin Buettner <kevinb@redhat.com>
5889
5890 * stack.c (find_frame_funname): Remove code which preferred
5891 minsym over symtab sym in "certain pathological cases".
5892
5893 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5894 parameter. Change type of "do_demangle" to bool.
5895 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5896 Pass suitable "prefer_sym_over_minsym" flag to
5897 build_address_symbolic(). Don't output "+" for negative offsets.
5898 * printcmd.c (print_address_symbolic): Update invocation of
5899 build_address_symbolic to include a "prefer_sym_over_minsym"
5900 flag.
5901 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5902 Restrict cases in which use of minimal symbol is preferred to that
5903 of a found symbol. Update comments.
5904
5905 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5906 for entry pc when entry pc is out of range for that FDE.
5907
59082019-07-26 Brian Callahan <bcallah@openbsd.org>
5909
5910 PR gdb/24839:
5911 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5912 type.
5913
59142019-07-25 Christian Biesinger <cbiesinger@google.com>
5915
5916 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5917 this function's Python signature.
5918
5919
59202019-07-24 Christian Biesinger <cbiesinger@google.com>
5921
5922 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5923 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5924 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5925 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5926 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5927
5928
59292019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5930
5931 * h8300-tdep.c (h8300_register_name_common): New.
5932 h8300_register_name): Use h8300_register_name_common.
5933 (h8300s_register_name): Likewise.
5934 (h8300sx_register_name): Likewise.
5935 (h8300h_register_nam): New.
5936 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5937
5938
59392019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5940
5941 * arm-tdep.c (arm_skip_cmse_entry): New function.
5942 (arm_is_sgstubs_section): New function.
5943 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5944
59452019-07-22 Tom Tromey <tom@tromey.com>
5946
5947 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5948 Don't self-assign.
5949
59502019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5951
5952 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5953 type_print.
5954
59552019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5956
5957 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5958 so that GDB doesn't match any msymbols when searching in the
5959 TYPES_DOMAIN.
5960 (print_symbol_info): Print using typedef_print or type_print based
5961 on the type of the symbol. Add updated FIXME comment moved from...
5962 (_initialize_symtab): ... move and update FIXME comment to above.
5963
59642019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5965
5966 * NEWS: Mention adding -q option to "info types".
5967 * symtab.c (struct info_types_options): New struct.
5968 (info_types_options_defs): New variable.
5969 (make_info_types_options_def_group): New function.
5970 (info_types_command): Use gdb::option framework to parse options.
5971 (info_types_command_completer): New function.
5972 (_initialize_symtab): Extend the help text on "info types" and
5973 register command completer.
5974
59752019-07-21 Christian Biesinger <cbiesinger@google.com>
5976
5977 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5978 (lookup_symbol_in_objfile): Change int to block_enum and add a
5979 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5980
59812019-07-20 Christian Biesinger <cbiesinger@google.com>
5982
5983 * MAINTAINERS (Write After Approval): Add self.
5984
59852019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5986
5987 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5988 instruction to the dummy code region.
5989
59902019-07-19 Tom Tromey <tromey@adacore.com>
5991
5992 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5993 (ARGSUSED, PARAMS, __func__): Remove rules.
5994
59952019-07-19 Alan Hayward <alan.hayward@arm.com>
5996
5997 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5998 * features/arm/arm-with-iwmmxt.c: Remove.
5999 * features/arm/arm-with-iwmmxt.xml: Remove.
6000 * features/arm/arm-with-m-fpa-layout.c: Remove.
6001 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6002 * features/arm/arm-with-m-vfp-d16.c: Remove.
6003 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6004 * features/arm/arm-with-m.c: Remove.
6005 * features/arm/arm-with-m.xml: Remove.
6006 * features/arm/arm-with-neon.c: Remove.
6007 * features/arm/arm-with-neon.xml: Remove.
6008 * features/arm/arm-with-vfpv2.c: Remove.
6009 * features/arm/arm-with-vfpv2.xml: Remove.
6010 * features/arm/arm-with-vfpv3.c: Remove.
6011 * features/arm/arm-with-vfpv3.xml: Remove.
6012
60132019-07-19 Alan Hayward <alan.hayward@arm.com>
6014
6015 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6016
60172019-07-19 Alan Hayward <alan.hayward@arm.com>
6018
6019 * arch/aarch32.c (aarch32_create_target_description): Create
6020 target descriptions using features.
6021 * arch/arm.c (arm_create_target_description)
6022 (arm_create_mprofile_target_description): Likewise.
6023 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6024
60252019-07-19 Alan Hayward <alan.hayward@arm.com>
6026
6027 * Makefile.in: Add new files.
6028 * aarch32-tdep.c: New file.
6029 * aarch32-tdep.h: New file.
6030 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6031 Call aarch32_read_description.
6032 * arch/aarch32.c: New file.
6033 * arch/aarch32.h: New file.
6034 * arch/arm.c (arm_create_target_description)
6035 (arm_create_mprofile_target_description): New function.
6036 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6037 (arm_create_target_description)
6038 (arm_create_mprofile_target_description): New declaration.
6039 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6040 read_description functions.
6041 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6042 Likewise.
6043 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6044 * arm-tdep.c (tdesc_arm_list): New variable.
6045 (arm_register_g_packet_guesses): Call create description functions.
6046 (arm_read_description) (arm_read_mprofile_description): New
6047 function.
6048 * arm-tdep.h (arm_read_description)
6049 (arm_read_mprofile_description): Add declaration.
6050 * configure.tgt: Add new files.
6051
60522019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6053
6054 * top.c (new_ui_command): Open specified terminal just once.
6055
60562019-07-18 Tom Tromey <tromey@adacore.com>
6057
6058 * symtab.c (main_name): Constify return type.
6059 * symfile.c (set_initial_language): Update.
6060 * symtab.h (main_name): Constify return type.
6061
60622019-07-17 Tom Tromey <tom@tromey.com>
6063
6064 * tui/tui-winsource.c (tui_update_source_window)
6065 (tui_update_source_window_as_is)
6066 (tui_update_source_windows_with_line): Remove return.
6067 * tui/tui-disasm.c (tui_show_disassem)
6068 (tui_show_disassem_and_update_source): Remove return.
6069 * tui/tui.c (tui_reset): Remove return.
6070 * tui/tui-wingeneral.c
6071 (tui_check_and_display_highlight_if_needed): Remove return.
6072
60732019-07-17 Tom Tromey <tom@tromey.com>
6074
6075 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6076
60772019-07-17 Tom Tromey <tom@tromey.com>
6078
6079 * tui/tui-winsource.h (struct tui_exec_info_window)
6080 (struct tui_source_window_base): Move from tui-data.h.
6081 * tui/tui-winsource.c: Move many method definitions from
6082 elsewhere. Remove "structuring" comments.
6083 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6084 (tui_source_window_base::refresh_window): Move to
6085 tui-winsource.c.
6086 * tui/tui-win.c (tui_source_window_base::refresh_all)
6087 (tui_source_window_base::update_tab_width)
6088 (tui_source_window_base::set_new_height)
6089 (tui_source_window_base::do_make_visible_with_new_height): Move to
6090 tui-winsource.c.
6091 * tui/tui-source.h: Update.
6092 * tui/tui-source.c (tui_source_window_base::reset): Move to
6093 tui-winsource.c.
6094 * tui/tui-disasm.h: Update.
6095 * tui/tui-data.h (struct tui_exec_info_window): Move to
6096 tui-winsource.h.
6097 (struct tui_source_window_base): Likewise.
6098 * tui/tui-data.c (tui_source_window_base::clear_detail)
6099 (tui_source_window_base, ~tui_source_window_base): Move to
6100 tui-winsource.c.
6101
61022019-07-17 Tom Tromey <tom@tromey.com>
6103
6104 * tui/tui-win.c (tui_resize_all)
6105 (tui_source_window_base::update_tab_width)
6106 (tui_adjust_win_heights): Update.
6107 (tui_win_info::make_invisible_and_set_new_height): Rename from
6108 make_invisible_and_set_new_height.
6109 * tui/tui-data.h (struct tui_win_info)
6110 <make_invisible_and_set_new_height>: New method.
6111
61122019-07-17 Tom Tromey <tom@tromey.com>
6113
6114 * tui/tui.c: Update.
6115 * tui/tui-source.h (struct tui_source_window): Move from
6116 tui-data.h.
6117 * tui/tui-layout.c: Update.
6118 * tui/tui-disasm.c: Update.
6119 * tui/tui-data.h (struct tui_source_window): Move to
6120 tui-source.h.
6121
61222019-07-17 Tom Tromey <tom@tromey.com>
6123
6124 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6125 tui-data.h.
6126 * tui/tui-data.h (struct tui_disasm_window): Move to
6127 tui-disasm.h.
6128
61292019-07-17 Tom Tromey <tom@tromey.com>
6130
6131 * tui/tui-regs.h (struct tui_data_item_window): Move from
6132 tui-data.h.
6133 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6134 * tui/tui-data.h (struct tui_data_item_window): Move to
6135 tui-regs.h.
6136 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6137
61382019-07-17 Tom Tromey <tom@tromey.com>
6139
6140 * tui/tui.c: Update.
6141 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6142 (tui_cmd_window::max_height): Move to tui-command.c.
6143 * tui/tui-layout.c: Update.
6144 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6145 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6146 tui-command.c.
6147 * tui/tui-command.h (struct tui_cmd_window): Move from
6148 tui-data.h.
6149 * tui/tui-command.c: Remove "structuring" comments.
6150 (tui_cmd_window::clear_detail)
6151 (tui_cmd_window::do_make_visible_with_new_height)
6152 (tui_cmd_window::max_height): Move from elsewhere.
6153
61542019-07-17 Tom Tromey <tom@tromey.com>
6155
6156 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6157 Now static.
6158 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6159 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6160
61612019-07-17 Tom Tromey <tom@tromey.com>
6162
6163 * tui/tui.c: Update.
6164 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6165 tui-regs.c.
6166 * tui/tui-windata.h: Remove file.
6167 * tui/tui-windata.c: Remove file.
6168 * tui/tui-win.c (tui_data_window::set_new_height)
6169 (tui_data_window::do_make_visible_with_new_height): Move to
6170 tui-regs.c.
6171 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6172 * tui/tui-regs.c: Remove "structuring" comments.
6173 (tui_data_window::first_data_item_displayed)
6174 (tui_data_window::delete_data_content_windows)
6175 (tui_data_window::erase_data_content)
6176 (tui_data_window::display_all_data)
6177 (tui_data_window::refresh_all)
6178 (tui_data_window::do_scroll_vertical)
6179 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6180 (tui_data_window::do_make_visible_with_new_height)
6181 (tui_data_window::refresh_window): Move from elsewhere.
6182 (_initialize_tui_regs): Move to end of file.
6183 * tui/tui-layout.c: Update.
6184 * tui/tui-hooks.c: Update.
6185 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6186 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6187 tui-regs.c.
6188 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6189
61902019-07-17 Tom Tromey <tom@tromey.com>
6191
6192 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6193 seen.
6194
61952019-07-17 Tom Tromey <tom@tromey.com>
6196
6197 * tui/tui-win.c (tui_source_window_base::set_new_height)
6198 (tui_source_window_base::do_make_visible_with_new_height): Use
6199 m_has_locator field directly.
6200 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6201 method.
6202 (struct tui_source_window_base) <has_locator>: Likewise.
6203
62042019-07-17 Tom Tromey <tom@tromey.com>
6205
6206 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6207 Don't declare.
6208 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6209 Remove.
6210 * tui/tui-win.c (tui_source_window_base::set_new_height)
6211 (tui_source_window_base::set_new_height)
6212 (make_invisible_and_set_new_height)
6213 (tui_source_window_base::do_make_visible_with_new_height)
6214 (tui_source_window_base::do_make_visible_with_new_height):
6215 Update.
6216 * tui/tui-layout.c (show_source_disasm_command, show_data)
6217 (show_source_or_disasm_and_command): Update.
6218 * tui/tui-layout.c (show_layout): Update.
6219
62202019-07-17 Tom Tromey <tom@tromey.com>
6221
6222 * tui/tui-layout.c (make_data_window): Remove.
6223 (show_data): Unify creation and re-initialization cases.
6224
62252019-07-17 Tom Tromey <tom@tromey.com>
6226
6227 * tui/tui-layout.c (make_source_window, make_disasm_window):
6228 Remove.
6229 (show_data): Unify creation and re-initialization cases.
6230
62312019-07-17 Tom Tromey <tom@tromey.com>
6232
6233 * tui/tui-layout.c (make_command_window): Remove.
6234 (show_source_disasm_command, show_source_or_disasm_and_command):
6235 Unify creation and re-initialization cases.
6236
62372019-07-17 Tom Tromey <tom@tromey.com>
6238
6239 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6240 creation and re-initialization cases.
6241
62422019-07-17 Tom Tromey <tom@tromey.com>
6243
6244 * tui/tui-regs.c (tui_get_register): Return void.
6245
62462019-07-17 Tom Tromey <tom@tromey.com>
6247
6248 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6249 Simplify.
6250
62512019-07-17 Tom Tromey <tom@tromey.com>
6252
6253 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6254 resetting.
6255
62562019-07-17 Tom Tromey <tom@tromey.com>
6257
6258 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6259 * tui/tui-regs.c (tui_reg_layout): New function.
6260 (tui_show_registers, tui_reg_command): Use it.
6261 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6262 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6263 parameters.
6264 (tui_layout_command): Remove.
6265
62662019-07-17 Tom Tromey <tom@tromey.com>
6267
6268 * tui/tui-layout.h (tui/tui-layout): Return void.
6269 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6270
62712019-07-17 Tom Tromey <tom@tromey.com>
6272
6273 * tui/tui-layout.c (show_source_disasm_command, show_data):
6274 Update.
6275 (reset_locator): Remove.
6276 (show_source_or_disasm_and_command): Update.
6277
62782019-07-17 Tom Tromey <tom@tromey.com>
6279
6280 * tui/tui-source.c (tui_source_window_base::reset): Remove
6281 win_type parameter.
6282 * tui/tui-layout.c (make_command_window, make_source_window)
6283 (make_disasm_window, make_data_window)
6284 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6285 (reset_locator, show_source_or_disasm_and_command): Update.
6286 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6287 win_type parameter.
6288 (struct tui_source_window_base) <reset>: Likewise.
6289
62902019-07-17 Tom Tromey <tom@tromey.com>
6291
6292 * tui/tui-layout.c (show_source_disasm_command): Use
6293 reset_locator.
6294 (reset_locator): New function.
6295 (init_and_make_win): Remove.
6296 (show_source_or_disasm_and_command): Use reset_locator.
6297
62982019-07-17 Tom Tromey <tom@tromey.com>
6299
6300 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6301 condition.
6302 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6303 Remove condition.
6304 * tui/tui-source.c (tui_source_window_base::reset): New method.
6305 * tui/tui-layout.c (make_command_window): Don't call
6306 init_and_make_win.
6307 (make_source_window, make_disasm_window): Don't call
6308 make_source_or_disasm_window.
6309 (make_data_window): Don't call init_and_make_win. Change calling
6310 convention.
6311 (show_source_disasm_command, show_data): Simplify.
6312 (make_source_or_disasm_window): Remove.
6313 (show_source_or_disasm_and_command): Simplify.
6314 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6315 (struct tui_source_window_base) <reset>: Likewise.
6316 <execution_info>: Remove initializer.
6317 * tui/tui-data.c (tui_source_window_base): Initialize
6318 execution_info.
6319
63202019-07-17 Tom Tromey <tom@tromey.com>
6321
6322 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6323 variable.
6324
63252019-07-17 Tom Tromey <tom@tromey.com>
6326
6327 * tui/tui.c (tui_rl_other_window): Update.
6328 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6329 superclass method first. Always iterate over regs_content.
6330 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6331 method.
6332 * tui/tui-win.c (tui_set_focus_command): Update.
6333
63342019-07-17 Tom Tromey <tom@tromey.com>
6335
6336 * tui/tui-win.c (tui_set_focus_command): Rename from
6337 tui_set_focus. Call tui_enable.
6338 (tui_set_focus_command): Remove.
6339
63402019-07-17 Tom Tromey <tom@tromey.com>
6341
6342 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6343 refresh_window.
6344 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6345 touchwin.
6346 (tui_data_window::refresh_window): Call refresh_window on data
6347 items. Always call superclass refresh_window.
6348 (tui_win_info::refresh): Remove.
6349 (tui_source_window_base::refresh_window): Update.
6350 (tui_refresh_all): Update.
6351 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6352 refresh_window.
6353 (show_source_or_disasm_and_command): Likewise.
6354 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6355 (struct tui_source_window_base) <refresh>: Likewise.
6356
63572019-07-17 Tom Tromey <tom@tromey.com>
6358
6359 * tui/tui-winsource.c (tui_clear_source_content)
6360 (tui_show_source_content): Update.
6361 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6362 whether content is empty.
6363 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6364 Remove.
6365
63662019-07-17 Tom Tromey <tom@tromey.com>
6367
6368 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6369 window's contents.
6370 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6371 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6372
63732019-07-17 Tom Tromey <tom@tromey.com>
6374
6375 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6376 (struct tui_data_item_window): Update.
6377
63782019-07-17 Tom Tromey <tom@tromey.com>
6379
6380 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6381 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6382 defines.
6383
63842019-07-17 Tom Tromey <tom@tromey.com>
6385
6386 * tui/tui-winsource.h (tui_erase_source_content)
6387 (tui_clear_source_content): Remove "display_prompt" parameter.
6388 * tui/tui-winsource.c (tui_update_source_window_as_is)
6389 (tui_update_source_windows_with_addr): Update.
6390 (tui_clear_source_content): Remove "display_prompt" parameter.
6391 (tui_erase_source_content): Likewise. Simplify.
6392 (tui_show_source_content): Update.
6393 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6394 * tui/tui-stack.c (tui_show_frame_info): Update.
6395 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6396 Remove defines.
6397
63982019-07-17 Tom Tromey <tom@tromey.com>
6399
6400 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6401 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6402 parameter.
6403 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6404 parameter.
6405
64062019-07-17 Tom Tromey <tom@tromey.com>
6407
6408 * tui/tui-winsource.c (tui_clear_source_content)
6409 (tui_show_source_content, tui_show_exec_info_content)
6410 (tui_clear_exec_info_content): Update.
6411 * tui/tui-stack.c (tui_show_locator_content): Update.
6412 (tui_show_frame_info): Update.
6413 * tui/tui-source.h (tui_source_window): Don't declare.
6414 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6415 from tui_source_is_displayed.
6416 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6417 Remove field.
6418 (struct tui_source_window_base) <content_in_use>: New field. Now
6419 bool.
6420 (struct tui_source_window) <showing_source_p>: New method.
6421 (TUI_SRC_WIN): Change cast.
6422 * tui/tui-data.c (tui_initialize_static_data): Update.
6423
64242019-07-17 Tom Tromey <tom@tromey.com>
6425
6426 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6427 location_matches_p.
6428 * tui/tui-source.c (tui_source_window::location_matches_p): New
6429 method.
6430 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6431 method.
6432 * tui/tui-data.h (struct tui_source_window_base)
6433 <location_matches_p>: New method.
6434 (struct tui_source_window, struct tui_disasm_window)
6435 <location_matches_p>: Likewise.
6436
64372019-07-17 Tom Tromey <tom@tromey.com>
6438
6439 * tui/tui-win.c (tui_set_win_height_command): Rename from
6440 tui_set_win_height.
6441 (tui_set_win_height_command): Remove.
6442
64432019-07-17 Tom Tromey <tom@tromey.com>
6444
6445 * tui/tui-source.c (tui_source_window): New constructor. Add
6446 observer.
6447 (~tui_source_window): New destructor.
6448 (tui_source_window::style_changed): New method.
6449 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6450 (tui_attach_detach_observers): Update.
6451 * tui/tui-data.h (struct tui_source_window): Make constructor not
6452 inline. Add destructor.
6453 (struct tui_source_window) <style_changed>: New method.
6454 <m_observable>: New member.
6455
64562019-07-17 Tom Tromey <tom@tromey.com>
6457
6458 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6459 * tui/tui-win.c (tui_resize_all): Fix typo.
6460
64612019-07-17 Tom Tromey <tom@tromey.com>
6462
6463 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6464 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6465 (tui_refresh_all): Remove "list" parameter. Use foreach.
6466 * tui/tui-win.c (window_name_completer): Use foreach.
6467 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6468 (update_tab_width): Likewise.
6469 * tui/tui-layout.c (show_layout): Update.
6470 * tui/tui-data.h (class tui_window_iterator): New.
6471 (struct all_tui_windows): New.
6472 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6473
64742019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6477 parameter. Don't reference globals.
6478 (tui_reg_command): Update.
6479
64802019-07-17 Tom Tromey <tom@tromey.com>
6481
6482 * tui/tui-regs.c (tui_show_registers): Simplify.
6483
64842019-07-17 Tom Tromey <tom@tromey.com>
6485
6486 * tui/tui-regs.c (tui_show_registers): Update.
6487 (tui_show_register_group): Add win_info parameter.
6488
64892019-07-17 Tom Tromey <tom@tromey.com>
6490
6491 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6492 Rename from tui_display_reg_element_at_line.
6493 (tui_data_window::display_registers_from_line): Update.
6494 * tui/tui-data.h (struct tui_data_window)
6495 <display_reg_element_at_line>: New method.
6496
64972019-07-17 Tom Tromey <tom@tromey.com>
6498
6499 * tui/tui-regs.h (tui_display_registers_from)
6500 (tui_display_registers_from_line): Don't declare.
6501 * tui/tui-windata.c (tui_data_window::display_all_data)
6502 (tui_data_window::refresh_all)
6503 (tui_data_window::do_scroll_vertical): Update.
6504 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6505 from tui_display_registers_from.
6506 (tui_display_reg_element_at_line): Update.
6507 (tui_data_window::display_registers_from_line): Rename from
6508 tui_display_registers_from_line.
6509 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6510 display_registers_from_line>: New methods.
6511
65122019-07-17 Tom Tromey <tom@tromey.com>
6513
6514 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6515 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6516 from tui_erase_data_content.
6517 (tui_data_window::display_all_data)
6518 (tui_data_window::refresh_all)
6519 (tui_data_window::do_scroll_vertical): Update.
6520 * tui/tui-regs.c (tui_show_registers): Update.
6521 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6522 New method.
6523
65242019-07-17 Tom Tromey <tom@tromey.com>
6525
6526 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6527 declare.
6528 * tui/tui-windata.c
6529 (tui_data_window::delete_data_content_windows): Rename from
6530 tui_delete_data_content_windows.
6531 (tui_data_window::display_all_data)
6532 (tui_data_window::do_scroll_vertical): Update.
6533 * tui/tui-data.h (struct tui_data_window)
6534 <delete_data_content_windows>: New method.
6535
65362019-07-17 Tom Tromey <tom@tromey.com>
6537
6538 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6539 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6540
65412019-07-17 Tom Tromey <tom@tromey.com>
6542
6543 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6544 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6545 from tui_display_all_data.
6546 * tui/tui-win.c
6547 (tui_data_window::do_make_visible_with_new_height): Update.
6548 * tui/tui-regs.c (tui_show_registers): Update.
6549 * tui/tui-layout.c (tui_set_layout): Update.
6550 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6551 method.
6552
65532019-07-17 Tom Tromey <tom@tromey.com>
6554
6555 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6556 * tui/tui-windata.c (tui_display_data_from): Remove.
6557 (tui_data_window::refresh_all): Update.
6558
65592019-07-17 Tom Tromey <tom@tromey.com>
6560
6561 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6562 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6563 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6564 tui_display_registers_from_line.
6565 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6566 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6567 "force_display" parameter.
6568
65692019-07-17 Tom Tromey <tom@tromey.com>
6570
6571 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6572 declare.
6573 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6574 Rename from tui_first_reg_element_no_inline.
6575 (tui_display_reg_element_at_line)
6576 (tui_display_registers_from_line): Update.
6577 * tui/tui-data.h (struct tui_data_window)
6578 <first_reg_element_no_inline>: New method.
6579
65802019-07-17 Tom Tromey <tom@tromey.com>
6581
6582 * tui/tui-windata.c (tui_display_data_from)
6583 (tui_data_window::do_scroll_vertical): Update.
6584 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6585 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6586 Rename from tui_line_from_reg_element_no.
6587 (tui_display_registers_from_line): Update.
6588 * tui/tui-data.h (struct tui_data_window)
6589 <line_from_reg_element_no>: New method.
6590
65912019-07-17 Tom Tromey <tom@tromey.com>
6592
6593 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6594 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6595 tui_last_regs_line_no.
6596 (tui_display_reg_element_at_line)
6597 (tui_display_registers_from_line): Update.
6598 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6599 method.
6600
66012019-07-17 Tom Tromey <tom@tromey.com>
6602
6603 PR tui/24722:
6604 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6605 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6606 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6607 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6608 (tui_update_breakpoint_info): Likewise.
6609 * tui/tui-hooks.c (tui_event_create_breakpoint)
6610 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6611 Update.
6612
66132019-07-17 Tom Tromey <tom@tromey.com>
6614
6615 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6616
66172019-07-17 Tom Tromey <tom@tromey.com>
6618
6619 * tui/tui-winsource.c (tui_update_source_window_as_is)
6620 (tui_update_source_windows_with_addr): Update.
6621 * tui/tui-source.h (tui_set_source_content)
6622 (tui_show_symtab_source): Add "win_info" parameter.
6623 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6624 parameter.
6625 (tui_show_symtab_source): Likewise.
6626
66272019-07-17 Tom Tromey <tom@tromey.com>
6628
6629 * tui/tui-wingeneral.c
6630 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6631
66322019-07-17 Tom Tromey <tom@tromey.com>
6633
6634 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6635 (struct tui_cmd_window) <can_scroll>: New method.
6636 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6637 method.
6638
66392019-07-17 Tom Tromey <tromey@adacore.com>
6640
6641 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6642 do_field_signed>: Rename. Change type of "value".
6643 * ui-out.c (ui_out::field_signed): Rename from field_int.
6644 Change type of "value".
6645 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6646 type of "value".
6647 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6648 do_field_int. Change type of "value".
6649 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6650 do_field_int. Change type of "value".
6651 * tracepoint.c (trace_status_mi, tfind_1)
6652 (print_one_static_tracepoint_marker): Update.
6653 * thread.c (print_thread_info_1, print_selected_thread_frame):
6654 Update.
6655 * stack.c (print_frame, print_frame_info): Update.
6656 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6657 Update.
6658 * source.c (print_source_lines_base): Update.
6659 * skip.c (info_skip_command): Update.
6660 * record-btrace.c (btrace_ui_out_decode_error)
6661 (btrace_call_history_src_line): Update.
6662 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6663 Update.
6664 * progspace.c (print_program_space): Update.
6665 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6666 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6667 do_field_int. Change type of "value".
6668 * mi/mi-out.c (mi_ui_out::do_table_begin)
6669 (mi_ui_out::do_table_header): Update.
6670 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6671 type of "value".
6672 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6673 (mi_cmd_data_list_changed_registers, output_register)
6674 (mi_cmd_data_read_memory, mi_load_progress)
6675 (mi_cmd_trace_frame_collected): Update.
6676 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6677 Update.
6678 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6679 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6680 (mi_cmd_var_list_children, varobj_update_one): Update.
6681 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6682 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6683 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6684 * inferior.c (print_inferior): Update.
6685 * gdb_bfd.c (print_one_bfd): Update.
6686 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6687 Update.
6688 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6689 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6690 do_field_int. Change type of "value".
6691 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6692 do_field_int. Change type of "value".
6693 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6694 (print_one_breakpoint_location, print_it_catch_fork)
6695 (print_one_catch_fork, print_it_catch_vfork)
6696 (print_one_catch_vfork, print_it_catch_solib)
6697 (print_it_catch_exec, print_it_ranged_breakpoint)
6698 (print_mention_watchpoint, print_mention_masked_watchpoint)
6699 (bkpt_print_it, update_static_tracepoint): Update.
6700 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6701 * break-catch-syscall.c (print_it_catch_syscall): Update.
6702 * ada-tasks.c (print_ada_task_info): Update.
6703 * ada-lang.c (print_it_exception, print_mention_exception):
6704 Update.
6705
67062019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6707
6708 PR breakpoints/24541
6709 * gdbarch.c: Regenerate.
6710 * gdbarch.h: Regenerate.
6711 * gdbarch.sh: Adjust return type and parameter types for
6712 'stap_adjust_register'.
6713 (i386_stap_adjust_register): Adjust signature and return new
6714 register name.
6715 * stap-probe.c (stap_parse_register_operand): Adjust use of
6716 'gdbarch_stap_adjust_register'.
6717
67182019-07-17 Tom Tromey <tromey@adacore.com>
6719
6720 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6721 declare VEC.
6722 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6723 std::vector.
6724 (struct s390_process_info): Add initializers.
6725 (s390_add_process): Use new.
6726 (s390_linux_nat_target::low_forget_process): Use delete.
6727 (s390_linux_nat_target::low_new_fork)
6728 (s390_linux_nat_target::stopped_by_watchpoint)
6729 (s390_linux_nat_target::low_prepare_to_resume)
6730 (s390_linux_nat_target::insert_watchpoint)
6731 (s390_linux_nat_target::insert_hw_breakpoint)
6732 (s390_linux_nat_target::remove_watchpoint)
6733 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6734
67352019-07-16 John Baldwin <jhb@FreeBSD.org>
6736
6737 * aarch64-fbsd-nat.c: Include regcache.h.
6738 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6739 argument.
6740 (aarch64_fbsd_nat_target::fetch_registers)
6741 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6742 variable.
6743 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6744
67452019-07-16 John Baldwin <jhb@FreeBSD.org>
6746
6747 * fbsd-nat.c: Include gdbarch.h.
6748
67492019-07-15 Tom Tromey <tromey@adacore.com>
6750
6751 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6752
67532019-07-15 Tom Tromey <tromey@adacore.com>
6754
6755 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6756 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6757 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6758 * cli-out.c (cli_ui_out::do_field_int): New method.
6759 * ui-out.c (ui_out::field_unsigned): New method.
6760 * symfile.c (generic_load): Use field_unsigned.
6761 (print_transfer_performance): Likewise.
6762 * record-btrace.c (ui_out_field_uint): Remove.
6763 (btrace_call_history_insn_range, btrace_call_history): Use
6764 field_unsigned.
6765 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6766 field_unsigned.
6767 * ui-out.h (class ui_out) <field_unsigned>: New method.
6768 <do_field_unsigned>: Likewise.
6769
67702019-07-15 Tom Tromey <tromey@adacore.com>
6771
6772 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6773 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6774 * target.c (flash_erase_command): Use field_string.
6775 * infrun.c (print_signal_received_reason): Use field_string.
6776 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6777 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6778 field_string.
6779 * ada-tasks.c (print_ada_task_info): Use field_string.
6780
67812019-07-15 Tom Tromey <tromey@adacore.com>
6782
6783 * target.c (flash_erase_command): Use field_core_addr.
6784 * symfile.c (generic_load): Use field_core_addr.
6785 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6786 Use field_core_addr.
6787 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6788 field_core_addr.
6789
67902019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6791
6792 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6793 value if its desired type is smaller than a CORE_ADDR and signed.
6794
67952019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6796
6797 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6798 of changes to field names, and use new is_reference field to
6799 decide if a property is a reference or not.
6800 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6801 field.
6802 (struct dwarf2_property_baton): Update header comment, rename
6803 'referenced_type' to 'property_type' and update comments.
6804 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6805 default property type, store in property baton, update to take
6806 accound of renamed field.
6807 (read_func_scope): Update call to attr_to_dynamic_prop.
6808 (read_array_type): Likewise.
6809 (dwarf2_per_cu_addr_sized_int_type): New function.
6810 (read_subrange_index_type): Move type finding code to
6811 dwarf2_per_cu_addr_sized_int_type.
6812 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6813 (dwarf2_per_cu_addr_type): New function.
6814 (set_die_type): Update calls to attr_to_dynamic_prop.
6815
68162019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6817
6818 * dwarf2read.c (read_subrange_index_type): New function.
6819 (read_subrange_type): Move code into new function and call it.
6820 * gdbtypes.c (create_range_type): Add some asserts.
6821
68222019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6823
6824 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6825 update return statements.
6826 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6827 declaration, and update comment to match.
6828 * gdbtypes.c (resolve_dynamic_array): Update call to
6829 dwarf2_evaluate_property to match new return type.
6830
68312019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6832
6833 * valarith.c (value_subscripted_rvalue): Change lowerbound
6834 parameter type from int to LONGEST.
6835 * value.h (value_subscripted_rvalue): Likewise in declaration.
6836
68372019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6838
6839 * cli/cli-utils.c (info_print_command_completer): New function.
6840 * cli/cli-utils.h: Add 'completer.h' include, and forward
6841 declaration for 'struct cmd_list_element'.
6842 (info_print_command_completer): Declare.
6843 * stack.c (_initialize_stack): Add completer for 'info locals' and
6844 'info args'.
6845 * symtab.c (_initialize_symtab): Add completer for 'info
6846 variables' and 'info functions'.
6847 * NEWS: Mention completion for additional info commands.
6848
68492019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6850
6851 * cli/cli-utils.c (extract_info_print_args): Delete.
6852 (extract_arg_maybe_quoted): Delete.
6853 (info_print_options_defs): New variable.
6854 (make_info_print_options_def_group): New function.
6855 (extract_info_print_options): Define new function.
6856 * cli/cli-utils.h (extract_info_print_args): Delete.
6857 (struct info_print_options): New structure.
6858 (extract_info_print_options): Declare new function.
6859 * stack.c (info_locals_command): Update to use new
6860 extract_info_print_options, also add a header comment.
6861 (info_args_command): Likewise.
6862 * symtab.c (info_variables_command): Likewise.
6863 (info_functions_command): Likewise.
6864
68652019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6866
6867 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6868 to extract string arguments.
6869 * common/common-utils.c (extract_string_maybe_quoted): New function.
6870 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6871
68722019-07-11 Tom Tromey <tromey@adacore.com>
6873
6874 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6875 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6876 * top.h (gdbinit): Don't declare.
6877 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6878 into...
6879 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6880 * top.c (gdb_init): Don't call init_cli_cmds.
6881 (gdbinit): Remove.
6882 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6883
68842019-07-11 Tom Tromey <tromey@adacore.com>
6885
6886 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6887 after it has been moved.
6888
68892019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6890
6891 * valops.c (value_must_coerce_to_target): Change return type to
6892 bool.
6893 * value.h (value_must_coerce_to_target): Likewise.
6894
68952019-07-10 Simon Marchi <simon.marchi@efficios.com>
6896
6897 * breakpoint.c (is_hardware_watchpoint): Remove
6898 forward-declaration.
6899 (is_masked_watchpoint): Change return type to bool.
6900 (is_tracepoint): Likewise.
6901 (is_breakpoint): Likewise.
6902 (is_hardware_watchpoint): Likewise.
6903 (is_watchpoint): Likewise.
6904 (is_no_memory_software_watchpoint): Likewise.
6905 (is_catchpoint): Likewise.
6906 (breakpoint_1): Make FILTER parameter's return type bool.
6907 is_masked_watchpoint): Change return type to bool.
6908 (save_breakpoints): Make FILTER parameter's return type bool.
6909 * breakpoint.h (is_breakpoint): Change return type to bool.
6910 (is_watchpoint): Likewise.
6911 (is_catchpoint): Likewise.
6912 (is_tracepoint): Likewise.
6913
69142019-07-10 Tom Tromey <tom@tromey.com>
6915
6916 * defs.h: Don't include gdbarch.h.
6917 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6918 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6919 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6920 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6921 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6922 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6923 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6924 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6925 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6926 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6927 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6928 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6929 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6930 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6931 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6932 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6933 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6934 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6935 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6936 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6937 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6938 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6939 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6940 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6941 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6942 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6943 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6944
69452019-07-10 Tom Tromey <tromey@adacore.com>
6946
6947 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6948 * breakpoint.c (init_ada_exception_breakpoint): Register as
6949 bp_catchpoint.
6950 (print_one_breakpoint_location, print_one_breakpoint): Use
6951 is_ada_exception_catchpoint.
6952 * ada-lang.c (class ada_catchpoint_location): Pass
6953 bp_loc_software_breakpoint to bp_location constructor.
6954 (is_ada_exception_catchpoint): New function.
6955
69562019-07-10 Tom Tromey <tromey@adacore.com>
6957
6958 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6959 VEC.
6960 (struct arm_exidx_entry): New method operator<.
6961 (struct arm_exidx_data) <section_maps>: Change type.
6962 (arm_exidx_data_free): Remove.
6963 (arm_exidx_data_key): Change type. Move lower.
6964 (arm_exidx_new_objfile): Update.
6965 (arm_compare_exidx_entries): Remove.
6966 (arm_find_exidx_entry, _initialize_arm_tdep)
6967
69682019-07-10 Tom Tromey <tromey@adacore.com>
6969
6970 * solib-spu.c (ocl_program_data_key): Change type.
6971 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6972 Update.
6973
69742019-07-10 Tom Tromey <tromey@adacore.com>
6975
6976 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6977 (struct solib_aix_inferior_data) <library_list>: Change type.
6978 (solib_aix_inferior_data_handle): Change type.
6979 (get_solib_aix_inferior_data): Update.
6980 (solib_aix_free_library_list): Remove.
6981 (library_list_start_library): Update.
6982 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6983 return type.
6984 (solib_aix_get_library_list)
6985 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6986 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6987
69882019-07-10 Tom Tromey <tromey@adacore.com>
6989
6990 * solib-dsbt.c (struct dsbt_info): Add initializers.
6991 (solib_dsbt_pspace_data): Change type.
6992 (dsbt_pspace_data_cleanup): Remove.
6993 (get_dsbt_info, _initialize_dsbt_solib): Update.
6994
69952019-07-10 Tom Tromey <tromey@adacore.com>
6996
6997 * spu-tdep.c (spu_overlay_data): Change type.
6998 (spu_get_overlay_table, spu_overlay_new_objfile)
6999 (_initialize_spu_tdep): Update.
7000
70012019-07-10 Tom Tromey <tromey@adacore.com>
7002
7003 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7004 destructor.
7005 (dbx_objfile_data_key): Change type and declare later.
7006 (DBX_SYMFILE_INFO): Rewrite.
7007 * dbxread.c (dbx_objfile_data_key): Change type.
7008 (dbx_symfile_init): Update.
7009 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7010 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7011 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7012
70132019-07-10 Tom Tromey <tromey@adacore.com>
7014
7015 * jit.c (jit_program_space_key): Change type. Move lower.
7016 (get_jit_program_space_data): Update.
7017 (jit_program_space_data_cleanup): Remove.
7018 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7019 Update.
7020 (struct jit_program_space_data): Add initializers.
7021
70222019-07-10 Tom Tromey <tromey@adacore.com>
7023
7024 * solib-darwin.c (struct darwin_info): Add initializers.
7025 (solib_darwin_pspace_data): Change type.
7026 (darwin_pspace_data_cleanup): Remove.
7027 (get_darwin_info, _initialize_darwin_solib): Update.
7028
70292019-07-10 Tom Tromey <tromey@adacore.com>
7030
7031 * remote-sim.c (struct sim_inferior_data): Add initializers,
7032 constructor, and destructor.
7033 (sim_inferior_data_key): Change type. Move lower.
7034 (check_for_duplicate_sim_descriptor): Update.
7035 (get_sim_inferior_data): Use new. Update.
7036 (~sim_inferior_data_cleanup): Rename from
7037 sim_inferior_data_cleanup. Simplify.
7038 (gdbsim_close_inferior, simulator_command)
7039 (sim_command_completer, _initialize_remote_sim): Update.
7040 (next_pid, INITIAL_PID): Move earlier.
7041
70422019-07-10 Tom Tromey <tromey@adacore.com>
7043
7044 * python/python-internal.h (create_thread_object): Return
7045 gdbpy_ref.
7046 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7047 * python/py-inferior.c (struct threadlist_entry): Add
7048 constructor.
7049 <thread_obj>: Now a gdbpy_ref.
7050 (thread_to_thread_object): Update.
7051 (add_thread_object): Use new.
7052 (delete_thread_object): Use delete.
7053 (infpy_threads): Update.
7054 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7055 GIL.
7056
70572019-07-10 Tom Tromey <tromey@adacore.com>
7058
7059 * valops.c (value_cast): Specialize error message for Ada.
7060
70612019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7062
7063 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7064
70652019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7066
7067 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7068 bpstat_should_step): Return bool, adjust comments.
7069 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7070 bpstat_should_step): Likewise.
7071
70722019-07-10 Alan Hayward <alan.hayward@arm.com>
7073
7074 * features/Makefile: Use feature target descriptions for Arm.
7075 * features/arm/arm-core.c: Generate new file.
7076 * features/arm/arm-fpa.c: Likewise.
7077 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7078 * features/arm/arm-m-profile.c: Likewise.
7079 * features/arm/arm-vfpv2.c: Likewise.
7080 * features/arm/arm-vfpv3.c: Likewise.
7081 * features/arm/xscale-iwmmxt.c: Likewise.
7082 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7083
70842019-07-10 Alan Hayward <alan.hayward@arm.com>
7085
7086 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7087 ptrace earlier.
7088
70892019-07-10 Alan Hayward <alan.hayward@arm.com>
7090
7091 * features/aarch64-pauth.c: Regenerate.
7092
70932019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7094
7095 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7096 bool.
7097 (bpstat_what): Use false instead of 0.
7098
70992019-07-09 Pedro Alves <palves@redhat.com>
7100
7101 * break-catch-throw.c (is_exception_catchpoint): New.
7102 * breakpoint.c (print_one_breakpoint_location): New parameter
7103 'raw_loc'. Handle it. Use
7104 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7105 looking at the breakpoint's type.
7106 (print_one_breakpoint): If handling "maint info breakpoints", also
7107 print locations of exception catchpoints.
7108 * breakpoint.h (is_exception_catchpoint): Declare.
7109
71102019-07-09 Pedro Alves <palves@redhat.com>
7111
7112 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7113 "addr" field.
7114 (allocate_location_exception_catchpoint): New.
7115 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7116 (initialize_throw_catchpoint_ops): Install
7117 allocate_location_exception_catchpoint as allocate_location
7118 method.
7119 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7120 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7121 bp_loc_other.
7122 (breakpoint_address_is_meaningful): Delete.
7123 (bl_address_is_meaningful): New.
7124 (breakpoint_locations_match): Adjust comment.
7125 (bp_location_from_bp_type): New, factored out of...
7126 (bp_location::bp_location(breakpoint *)): ... this.
7127 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7128 factored out of...
7129 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7130 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7131 breakpoint_address_is_meaningful.
7132 (bp_locations_compare): Adjust comment.
7133 (update_global_location_list): Use bl_address_is_meaningful
7134 instead of breakpoint_address_is_meaningful.
7135 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7136 explicit.
7137 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7138 * python/py-breakpoint.c (bppy_get_location): No longer check
7139 whether location is null.
7140
71412019-07-09 Pedro Alves <palves@redhat.com>
7142
7143 PR c++/15468
7144 * breakpoint.c (print_one_breakpoint_location): Remove
7145 single-location assert.
7146
71472019-07-09 Tom Tromey <tom@tromey.com>
7148
7149 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7150 * configure: Rebuild.
7151 * configure.ac: Change common to gdbsupport.
7152 * gdbsupport: Rename from common.
7153 * acinclude.m4: Change common to gdbsupport.
7154 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7155 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7156 gdbsupport.
7157 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7158 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7159 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7160 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7161 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7162 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7163 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7164 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7165 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7166 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7167 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7168 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7169 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7170 coff-pe-read.c, command.h, compile/compile-c-support.c,
7171 compile/compile-c.h, compile/compile-cplus-symbols.c,
7172 compile/compile-cplus-types.c, compile/compile-cplus.h,
7173 compile/compile-loc2c.c, compile/compile.c, completer.c,
7174 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7175 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7176 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7177 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7178 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7179 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7180 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7181 features/aarch64-core.c, features/aarch64-fpu.c,
7182 features/aarch64-pauth.c, features/aarch64-sve.c,
7183 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7184 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7185 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7186 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7187 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7188 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7189 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7190 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7191 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7192 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7193 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7194 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7195 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7196 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7197 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7198 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7199 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7200 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7201 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7202 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7203 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7204 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7205 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7206 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7207 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7208 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7209 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7210 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7211 minsyms.c, mips-linux-tdep.c, namespace.h,
7212 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7213 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7214 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7215 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7216 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7217 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7218 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7219 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7220 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7221 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7222 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7223 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7224 procfs.c, producer.c, progspace.h, psymtab.h,
7225 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7226 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7227 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7228 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7229 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7230 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7231 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7232 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7233 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7234 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7235 target-memory.c, target.c, target.h, target/waitstatus.c,
7236 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7237 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7238 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7239 unittests/array-view-selftests.c,
7240 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7241 unittests/common-utils-selftests.c,
7242 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7243 unittests/format_pieces-selftests.c,
7244 unittests/function-view-selftests.c,
7245 unittests/lookup_name_info-selftests.c,
7246 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7247 unittests/mkdir-recursive-selftests.c,
7248 unittests/observable-selftests.c,
7249 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7250 unittests/parse-connection-spec-selftests.c,
7251 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7252 unittests/scoped_fd-selftests.c,
7253 unittests/scoped_mmap-selftests.c,
7254 unittests/scoped_restore-selftests.c,
7255 unittests/string_view-selftests.c, unittests/style-selftests.c,
7256 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7257 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7258 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7259 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7260 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7261 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7262
72632019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7264
7265 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7266 bool value.
7267 (decode_digits_ordinary): Set explicit_line field in sal.
7268 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7269 symtab_and_line that was set on an explicit line number in
7270 assembler code. Do always update the recorded symtab and line if
7271 we do skip the prologue.
7272
72732019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7274
7275 * breakpoint.c (set_breakpoint_location_function): Remove
7276 explicit_loc parameter.
7277 (momentary_breakpoint_from_master): Update call to
7278 set_breakpoint_location_function.
7279 (add_location_to_breakpoint): Likewise.
7280
72812019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7282
7283 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7284 required features based on default bfd type when no specific bfd
7285 is present.
7286
72872019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7288
7289 * NEWS: Mention that GDB printf and eval commands can now print
7290 C-style and Ada-style convenience var strings without
7291 calling the inferior.
7292 * printcmd.c (printf_c_string): Locally print GDB internal var
7293 instead of transiting via the inferior.
7294 (printf_wide_c_string): Likewise.
7295
72962019-07-04 Alan Hayward <alan.hayward@arm.com>
7297
7298 PR breakpoints/25011
7299 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7300
73012019-07-04 Tom Tromey <tom@tromey.com>
7302
7303 PR tui/24724:
7304 * tui/tui-winsource.c (tui_clear_source_content): Update.
7305 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7306 (tui_update_breakpoint_info): Update.
7307 (tui_set_exec_info_content): Update.
7308 * tui/tui-source.c (tui_set_source_content_nil): Update.
7309 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7310 has_break.
7311 * tui/tui-data.h (enum tui_bp_flag): New.
7312 (tui_bp_flags): New enum flags type.
7313 (struct tui_source_element) <break_mode>: Change type. Rename
7314 from has_break.
7315 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7316 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7317 constants.
7318 * tui/tui-winsource.h: Fix comment.
7319
73202019-07-04 Alan Hayward <alan.hayward@arm.com>
7321
7322 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7323 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7324 (store_fpregs_to_thread)
7325 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7326 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7327 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7328 (IWMMXT_REGS_SIZE): Add define.
7329 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7330 (fetch_vfp_regs, store_vfp_regs)
7331 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7332 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7333
73342019-07-04 Alan Hayward <alan.hayward@arm.com>
7335
7336 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7337 defines.
7338 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7339 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7340 (ARM_INT_REGISTER_SIZE): ...to this.
7341 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7342 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7343 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7344 (arm_linux_collect_gregset, supply_nwfpe_register)
7345 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7346 defines.
7347 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7348 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7349 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7350 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7351 (arm_return_in_memory, arm_store_return_value)
7352 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7353 (arm_record_ld_st_multiple): Likewise.
7354 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7355 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7356
73572019-07-04 Alan Hayward <alan.hayward@arm.com>
7358
7359 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7360 AARCH64_DISPLACED_MODIFIED_INSNS.
7361 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7362 (aarch64_displaced_step_copy_insn): Likewise.
7363 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7364 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7365 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7366 ARM_DISPLACED_MODIFIED_INSNS.
7367 * arm-tdep.c (arm_gdbarch_init): Likewise.
7368 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7369 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7370 (struct arm_displaced_step_closure): Use
7371 ARM_DISPLACED_MODIFIED_INSNS.
7372
73732019-07-04 Alan Hayward <alan.hayward@arm.com>
7374
7375 * features/Makefile: Remove unused xml files.
7376 * features/aarch64.xml: Remove.
7377 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7378 * features/i386/amd64-avx-avx512.xml: Remove.
7379 * features/i386/amd64-avx-linux.xml: Remove.
7380 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7381 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7382 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7383 * features/i386/amd64-avx-mpx.xml: Remove.
7384 * features/i386/amd64-avx.xml: Remove.
7385 * features/i386/amd64-linux.xml: Remove.
7386 * features/i386/amd64-mpx-linux.xml: Remove.
7387 * features/i386/amd64-mpx.xml: Remove.
7388 * features/i386/amd64.xml: Remove.
7389 * features/i386/i386-avx-avx512-linux.xml: Remove.
7390 * features/i386/i386-avx-avx512.xml: Remove.
7391 * features/i386/i386-avx-linux.xml: Remove.
7392 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7393 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7394 * features/i386/i386-avx-mpx-linux.xml: Remove.
7395 * features/i386/i386-avx-mpx.xml: Remove.
7396 * features/i386/i386-avx.xml: Remove.
7397 * features/i386/i386-linux.xml: Remove.
7398 * features/i386/i386-mmx-linux.xml: Remove.
7399 * features/i386/i386-mmx.xml: Remove.
7400 * features/i386/i386-mpx-linux.xml: Remove.
7401 * features/i386/i386-mpx.xml: Remove.
7402 * features/i386/i386.xml: Remove.
7403 * features/i386/x32-avx-avx512-linux.xml: Remove.
7404 * features/i386/x32-avx-linux.xml: Remove.
7405 * features/i386/x32-linux.xml: Remove.
7406
74072019-07-04 Alan Hayward <alan.hayward@arm.com>
7408
7409 * regformats/aarch64.dat: Remove.
7410 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7411 * regformats/i386/amd64-avx-linux.dat: Remove.
7412 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7413 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7414 * regformats/i386/amd64-linux.dat: Remove.
7415 * regformats/i386/amd64-mpx-linux.dat: Remove.
7416 * regformats/i386/amd64.dat: Remove.
7417 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7418 * regformats/i386/i386-avx-linux.dat: Remove.
7419 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7420 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7421 * regformats/i386/i386-linux.dat: Remove.
7422 * regformats/i386/i386-mmx-linux.dat: Remove.
7423 * regformats/i386/i386-mpx-linux.dat: Remove.
7424 * regformats/i386/i386.dat: Remove.
7425 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7426 * regformats/i386/x32-avx-linux.dat: Remove.
7427 * regformats/i386/x32-linux.dat: Remove.
7428
74292019-07-04 Alan Hayward <alan.hayward@arm.com>
7430
7431 * aarch64-tdep.c: Remove xml self tests.
7432 * amd64-linux-tdep.c: Likewise.
7433 * amd64-tdep.c: Likewise.
7434 * i386-linux-tdep.c: Likewise.
7435 * i386-tdep.c: Likewise.
7436
74372019-07-03 Pedro Alves <palves@redhat.com>
7438
7439 PR cli/24732
7440 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7441 (pipe_cmd_option_defs): New.
7442 (make_pipe_cmd_options_def_group): New.
7443 (pipe_command): Use gdb::option::process_options.
7444 (pipe_command_completer): New function.
7445 (_initialize_cli_cmds): Install completer for "pipe" command.
7446
74472019-07-03 Pedro Alves <palves@redhat.com>
7448
7449 * cli/cli-option.c (union option_value) <string>: New field.
7450 (struct option_def_and_value): Add ctor, move ctor, dtor and
7451 use DISABLE_COPY_AND_ASSIGN.
7452 (option_def_and_value::clear_value): New.
7453 (parse_option, save_option_value_in_ctx, get_val_type_str)
7454 (add_setshow_cmds_for_options): Handle var_string.
7455 * cli-option.h (union option_def::var_address) <string>: New
7456 field.
7457 (struct string_option_def): New.
7458 * maint-test-options.c (struct test_options_opts): Add default
7459 ctor and use DISABLE_COPY_AND_ASSIGN.
7460 <string_opt>: New field.
7461 (test_options_opts::~test_options_opts): New.
7462 (test_options_opts::dump): Also dump "-string".
7463 (test_options_option_defs): Install "string.
7464
74652019-07-03 Pedro Alves <palves@redhat.com>
7466
7467 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7468 option_value with a null enumeration.
7469 (complete_options): Save the option values in the context.
7470 (save_option_value_in_ctx): New, factored out from ...
7471 (process_options): ... here.
7472 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7473 of the function.
7474 * maint-test-options.c (test_options_opts::dump): New, factored
7475 out from ...
7476 (maintenance_test_options_command_mode): ... here.
7477 (maintenance_test_options_command_completion_result): Delete.
7478 (maintenance_test_options_command_completion_text): Update
7479 comment.
7480 (maintenance_show_test_options_completion_result): Change
7481 prototype. Just print
7482 maintenance_test_options_command_completion_text.
7483 (save_completion_result): New.
7484 (maintenance_test_options_completer_mode): Pass options context to
7485 complete_options, and then save a dump.
7486 (_initialize_maint_test_options): Use add_cmd to install "maint
7487 show test-options-completion-result".
7488
74892019-07-03 Pedro Alves <palves@redhat.com>
7490
7491 * NEWS (New commands): Mention "with" and "maint with".
7492 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7493 (with_command, with_command_completer): New.
7494 (pipe_command): Adjust to new repeat_previous
7495 interface.
7496 (_initialize_cli_cmds): Install the "with" command and its "w"
7497 alias.
7498 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7499 declarations.
7500 * cli/cli-setshow.c (parse_cli_var_uinteger)
7501 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7502 argument strings for all var_types.
7503 (get_setshow_command_value_string): New, factored out from ...
7504 (do_show_command): ... this.
7505 * cli/cli-setshow.h: Include <string>.
7506 (get_setshow_command_value_string): Declare.
7507 * command.h (repeat_previous): Now returns const char *. Adjust
7508 comment.
7509 * maint.c: Include "cli/cli-cmds.h".
7510 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7511 (_initialize_maint_cmds): Register the "maintenance with" command.
7512 * top.c (repeat_previous): Move bits from pipe_command here:
7513 Return the saved command line, if any; error out if there's no
7514 command to relaunch.
7515
75162019-07-03 Pedro Alves <palves@redhat.com>
7517
7518 * NEWS (New commands): Mention "maint set/show test-settings"
7519 instead of "maint test-settings".
7520 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7521 (maintenance_test_settings_set_list): Rename to ...
7522 (maintenance_set_test_settings_list): ... this.
7523 (maintenance_test_settings_show_list): Rename to ...
7524 (maintenance_show_test_settings_list): ... this.
7525 (maintenance_test_settings_cmd): Delete.
7526 (maintenance_test_settings_set_cmd): ...
7527 (maintenance_set_test_settings_cmd): ... this.
7528 (maintenance_test_settings_show_cmd): ...
7529 (maintenance_show_test_settings_cmd): ... this.
7530 (maintenance_test_settings_show_value_cmd):
7531 (maintenance_show_test_settings_value_cmd): ... this.
7532 (_initialize_maint_test_settings): No longer install the "maint
7533 test-settings" prefix command. Rename "maint test-settings set"
7534 to "maint set test-settings", and "maint test-settings show" to
7535 "maint show test-settings". Adjust all subcommands.
7536
75372019-07-03 Pedro Alves <palves@redhat.com>
7538
7539 * maint-test-settings.c: Fix file's intro comment. Replace all
7540 references to "test-options" with references to "test-settings",
7541 in comments.
7542
75432019-07-03 Pedro Alves <palves@redhat.com>
7544
7545 * maint-test-settings.c (maintenance_test_settings_xxx)
7546 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7547 New.
7548 (maintenance_test_settings_enums): Use them.
7549 (maintenance_test_settings_enum): Default to
7550 maintenance_test_settings_xxx.
7551 (_initialize_maint_test_settings): Initialize
7552 MAINTENANCE_TEST_SETTINGS_FILENAME.
7553
75542019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7555
7556 * breakpoint.h (remove_breakpoints_inf): Change return type to
7557 void, move function documentation here.
7558 * breakpoint.c (remove_breakpoints_inf): Change return type to
7559 void, move function documentation to header.
7560
75612019-07-02 Pedro Alves <palves@redhat.com>
7562
7563 * NEWS (Completion improvements): Mention "info threads".
7564 * thread.c (struct info_threads_opts, info_threads_option_defs)
7565 (make_info_threads_options_def_group): New.
7566 (info_threads_command): Use gdb::option::process_options.
7567 (info_threads_command_completer): New.
7568 (_initialize_thread): Use gdb::option::build_help to build the
7569 help text for "info threads".
7570
75712019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7572
7573 * defs.h (generic_load): Move from here...
7574 * symfile.h (generic_load): ... to here. Rename name parameter
7575 to args.
7576 * symfile.c (generic_load): Add comment.
7577
75782019-07-01 Tom Tromey <tromey@adacore.com>
7579
7580 * dwarf2read.c
7581 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7582 declaration of without_params. Fix formatting.
7583
75842019-07-01 Tom Tromey <tromey@adacore.com>
7585
7586 * ada-exp.y (find_primitive_type): Update.
7587 * ada-lang.h (ada_lookup_symbol): Update.
7588 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7589 parameter.
7590 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7591
75922019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7593
7594 PR breakpoints/24541
7595 * gdbarch.c: Regenerate.
7596 * gdbarch.h: Regenerate.
7597 * gdbarch.sh: Add 'stap_adjust_register'.
7598 * i386-tdep.c: Include '<unordered_set>'.
7599 (i386_stap_adjust_register): New function.
7600 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7601 * stap-probe.c (stap_parse_register_operand): Call
7602 'gdbarch_stap_adjust_register'.
7603
76042019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7605
7606 PR python/24742
7607 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7608 * python/python.c (do_start_initialization): Use 'xmalloc'
7609 instead of 'PyMem_Malloc'.
7610
76112019-06-28 Tom Tromey <tromey@adacore.com>
7612
7613 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7614 for Ada.
7615
76162019-06-27 Tom Tromey <tromey@adacore.com>
7617
7618 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7619 objfile_key.
7620 (arm_find_mapping_symbol, arm_record_special_symbol)
7621 (_initialize_arm_tdep): Update.
7622 (arm_objfile_data_free): Remove.
7623
76242019-06-27 Tom Tromey <tromey@adacore.com>
7625
7626 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7627 to cp_print_static_field.
7628
76292019-06-26 Tom Tromey <tromey@adacore.com>
7630
7631 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7632 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7633 declare.
7634
76352019-06-26 Alan Hayward <alan.hayward@arm.com>
7636
7637 * features/aarch64-core.c (create_feature_aarch64_core):
7638 Regenerate.
7639 * features/aarch64-core.xml: Add cpsr flags.
7640
76412019-06-26 Alan Hayward <alan.hayward@arm.com>
7642
7643 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7644 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7645
76462019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7647
7648 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7649 field.
7650 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7651 use.
7652 (arm_record_special_symbol): Don't insert new symbol in sorted
7653 position, push it at the end.
7654
76552019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7656
7657 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7658 (arm_mapping_symbol_s): Remove.
7659 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7660 (arm_mapping_symbol_vec): New typedef.
7661 (struct arm_per_objfile): Add constructor.
7662 <section_maps>: Change type to
7663 std::unique_ptr<arm_mapping_symbol_vec[]>.
7664 (arm_compare_mapping_symbols): Remove.
7665 (arm_find_mapping_symbol): Adjust to section_maps type change.
7666 (arm_objfile_data_free): Call delete on arm_per_objfile.
7667 (arm_record_special_symbol): Adjust to section_maps type change.
7668 Allocate arm_per_objfile with new.
7669
76702019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7671
7672 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7673 with the command prefix.
7674
76752019-06-25 Tom Tromey <tom@tromey.com>
7676
7677 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7678 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7679
76802019-06-25 Tom Tromey <tom@tromey.com>
7681
7682 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7683 type.
7684 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7685 protected.
7686
76872019-06-25 Tom Tromey <tom@tromey.com>
7688
7689 * tui/tui-winsource.c
7690 (tui_source_window_base::set_is_exec_point_at): Add check against
7691 LOA_ADDRESS.
7692
76932019-06-25 Tom Tromey <tom@tromey.com>
7694
7695 * tui/tui-source.c (tui_set_source_content): Don't check before
7696 xfree.
7697 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7698
76992019-06-25 Tom Tromey <tom@tromey.com>
7700
7701 * tui/tui-winsource.h (tui_update_source_window_as_is)
7702 (tui_alloc_source_buffer, tui_line_is_displayed)
7703 (tui_addr_is_displayed): Change type of win_info.
7704 * tui/tui-winsource.c (tui_update_source_window_as_is)
7705 (tui_clear_source_content, tui_show_source_line)
7706 (tui_show_source_content, tui_source_window_base::refill)
7707 (tui_source_window_base::set_is_exec_point_at)
7708 (tui_source_window_base::set_is_exec_point_at)
7709 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7710 (tui_alloc_source_buffer, tui_line_is_displayed)
7711 (tui_addr_is_displayed): Change type of win_info. Update.
7712 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7713 (tui_source_window_base::do_make_visible_with_new_height):
7714 Update.
7715 * tui/tui-source.c (tui_set_source_content)
7716 (tui_set_source_content_nil)
7717 (tui_source_window::do_scroll_vertical): Update.
7718 * tui/tui-layout.c (show_layout): Update.
7719 * tui/tui-disasm.c (tui_set_disassem_content)
7720 (tui_disasm_window::do_scroll_vertical): Update.
7721 * tui/tui-data.h (tui_win_content): Remove.
7722 (struct tui_gen_win_info) <content, content_size>: Remove.
7723 (struct tui_source_element): Add initializers and destructor.
7724 (union tui_which_element, struct tui_win_element): Remove.
7725 (struct tui_source_window_base) <content>: New field.
7726 (struct tui_data_window): Remove destructor.
7727 (tui_alloc_content, tui_free_win_content)
7728 (tui_free_all_source_wins_content): Don't declare.
7729 * tui/tui-data.c (tui_initialize_static_data): Update.
7730 (init_content_element, tui_alloc_content): Remove.
7731 (~tui_gen_win_info): Update.
7732 (~tui_data_window, tui_free_all_source_wins_content)
7733 (tui_free_win_content, free_content, free_content_elements):
7734 Remove.
7735
77362019-06-25 Tom Tromey <tom@tromey.com>
7737
7738 * tui/tui-winsource.h (tui_clear_source_content)
7739 (tui_erase_source_content, tui_show_source_content): Change type
7740 of win_info.
7741 * tui/tui-winsource.c (tui_clear_source_content)
7742 (tui_erase_source_content, tui_show_source_content): Change type
7743 of win_info.
7744 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7745 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7746 win_info.
7747 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7748 win_info.
7749 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7750
77512019-06-25 Tom Tromey <tom@tromey.com>
7752
7753 * tui/tui-winsource.c (tui_clear_source_content)
7754 (tui_source_window_base::set_is_exec_point_at): Update.
7755 * tui/tui-source.c (tui_set_source_content_nil): Update.
7756 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7757 a bool.
7758 * tui/tui-data.c (init_content_element): Update.
7759
77602019-06-25 Tom Tromey <tom@tromey.com>
7761
7762 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7763 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7764 * tui/tui-layout.c (init_and_make_win): Update.
7765 * tui/tui.h (enum tui_win_type): Update.
7766 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7767 tui_win_is_auxillary.
7768 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7769 tui_win_is_auxillary.
7770
77712019-06-25 Tom Tromey <tom@tromey.com>
7772
7773 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7774 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7775 (tui_delete_data_content_windows, tui_display_all_data)
7776 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7777 Update.
7778 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7779 * tui/tui-regs.c (tui_last_regs_line_no)
7780 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7781 (tui_show_registers): Update.
7782 (tui_show_register_group): Return void. Update.
7783 (tui_display_registers_from, tui_display_reg_element_at_line)
7784 (tui_display_registers_from_line, tui_check_register_values):
7785 Update.
7786 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7787 member.
7788 (struct tui_data_window) <regs_content>: Now a std::vector.
7789 <regs_content_count>: Remove.
7790 (tui_add_content_elements, tui_free_data_content): Don't declare.
7791 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7792 (init_content_element): Remove DATA_WIN case. Add assert.
7793 (tui_add_content_elements): Remove.
7794 (tui_data_window): Update.
7795 (tui_free_data_content): Remove.
7796 (free_content_elements): Remove DATA_WIN case.
7797
77982019-06-25 Tom Tromey <tom@tromey.com>
7799
7800 * tui/tui-data.c (tui_data_item_window): Update.
7801 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7802 * tui/tui-windata.c (tui_display_all_data)
7803 (tui_display_data_from_line): Update.
7804 (tui_check_data_values): Remove.
7805 * tui/tui-regs.c (tui_show_register_group)
7806 (tui_display_reg_element_at_line): Update.
7807 * tui/tui-hooks.c (tui_register_changed)
7808 (tui_refresh_frame_and_register_information): Call
7809 tui_check_register_values.
7810 * tui/tui-data.h (struct tui_data_window) <data_content,
7811 data_content_count, data_type>: Remove.
7812 (enum tui_data_type): Remove.
7813
7814 * tui/tui-data.c (tui_data_window::clear_detail)
7815 (~tui_data_window): Update.
7816
78172019-06-25 Tom Tromey <tom@tromey.com>
7818
7819 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7820 declare.
7821 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7822 Rename from tui_first_data_item_displayed. Update.
7823 (tui_data_window::refresh_all)
7824 (tui_data_window::do_scroll_vertical): Update.
7825 * tui/tui-data.h (struct tui_data_window)
7826 <first_data_item_displayed>: Declare new method.
7827
78282019-06-25 Tom Tromey <tom@tromey.com>
7829
7830 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7831 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7832 contents...
7833 (tui_initialize_static_data): ...here.
7834
78352019-06-25 Tom Tromey <tom@tromey.com>
7836
7837 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7838 (tui_display_registers_from, tui_check_register_values): Update.
7839 (tui_display_register): Remove win_info parameter; update.
7840 (tui_get_register): Change type of parameters.
7841 * tui/tui-data.h (struct tui_data_element): Remove.
7842 (union tui_which_element) <data>: Remove.
7843 <data_window>: Change type.
7844 (struct tui_data_item_window): New.
7845 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7846 case. Add assert.
7847 (~tui_data_item_window): New destructor.
7848 (free_content_elements): Remove DATA_ITEM_WIN case.
7849
78502019-06-25 Tom Tromey <tom@tromey.com>
7851
7852 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7853 Remove.
7854
78552019-06-25 Tom Tromey <tom@tromey.com>
7856
7857 * tui/tui-data.h (struct tui_command_element): Remove.
7858 (union tui_which_element) <command>: Remove.
7859 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7860 assert.
7861 (free_content_elements): Remove CMD_WIN case.
7862
78632019-06-25 Tom Tromey <tom@tromey.com>
7864
7865 * tui/tui-layout.c (tui_set_layout): Update.
7866 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7867 * tui/tui-data.c (layout_def): Update.
7868
78692019-06-25 Tom Tromey <tom@tromey.com>
7870
7871 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7872 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7873 (tui_source_window_base::set_new_height): Update.
7874 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7875 Update.
7876 (tui_set_locator_fullname, tui_set_locator_info)
7877 (tui_show_frame_info): Update.
7878 * tui/tui-source.c (tui_set_source_content)
7879 (tui_source_is_displayed): Update.
7880 * tui/tui-layout.c (show_source_disasm_command, show_data)
7881 (show_source_or_disasm_and_command): Update.
7882 * tui/tui-disasm.c (tui_set_disassem_content)
7883 (tui_get_begin_asm_address): Update.
7884 * tui/tui-data.h (struct tui_locator_element): Remove.
7885 (union tui_which_element) <locator>: Remove.
7886 (struct tui_locator_window): New.
7887 (tui_locator_win_info_ptr): Change return type.
7888 * tui/tui-data.c (_locator): Change type.
7889 (tui_locator_win_info_ptr): Change return type.
7890 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7891 (tui_alloc_content): Add assert.
7892
78932019-06-25 Tom Tromey <tom@tromey.com>
7894
7895 * tui/tui-winsource.c
7896 (tui_exec_info_window::maybe_allocate_content): New method.
7897 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7898 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7899 (make_source_or_disasm_window): Add cast.
7900 * tui/tui-data.h (union tui_which_element) <simple_string>:
7901 Remove.
7902 (struct tui_source_info): New.
7903 (struct tui_source_window_base) <execution_info>: Change type.
7904 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7905 case, and add assert.
7906 (tui_alloc_content): Add assert.
7907
79082019-06-25 Tom Tromey <tom@tromey.com>
7909
7910 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7911 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7912 * tui/tui-data.c (tui_alloc_win_info): Remove.
7913
79142019-06-25 Tom Tromey <tom@tromey.com>
7915
7916 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7917 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7918 can_highlight.
7919
79202019-06-25 Tom Tromey <tom@tromey.com>
7921
7922 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7923 make_visible_with_new_height method.
7924 (tui_win_info::make_visible_with_new_height): New method.
7925 (tui_source_window_base::do_make_visible_with_new_height)
7926 (tui_data_window::do_make_visible_with_new_height)
7927 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7928 (make_visible_with_new_height): Remove.
7929 (tui_resize_all, tui_adjust_win_heights): Use
7930 make_visible_with_new_height method.
7931 * tui/tui-data.h (struct tui_win_info)
7932 <do_make_visible_with_new_height, make_visible_with_new_height>:
7933 New methods.
7934 (struct tui_source_window_base, struct tui_data_window)
7935 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7936 methods.
7937
79382019-06-25 Tom Tromey <tom@tromey.com>
7939
7940 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7941 method.
7942 (update_tab_width): Call update_tab_width method.
7943 * tui/tui-data.h (struct tui_win_info)
7944 (struct tui_source_window_base) <update_tab_width>: New methods.
7945
79462019-06-25 Tom Tromey <tom@tromey.com>
7947
7948 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7949 parameter.
7950 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7951 parameter.
7952 (tui_gen_win_info::make_visible): Update.
7953 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7954 parameter.
7955 * tui/tui-data.h (enum tui_box): New enum.
7956 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7957
79582019-06-25 Tom Tromey <tom@tromey.com>
7959
7960 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7961 init_and_make_win for EXEC_INFO_WIN.
7962 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7963 longer inline.
7964 (struct tui_win_info) <~tui_win_info>: Inline.
7965 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7966 Don't declare.
7967 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7968 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7969 Remove.
7970 (tui_initialize_static_data): Update.
7971 (~tui_gen_win_info): Handle more cleanup here.
7972 (~tui_source_window_base): Delete "execution_info".
7973 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7974
79752019-06-25 Tom Tromey <tom@tromey.com>
7976
7977 * tui/tui-layout.c (make_command_window): Don't set
7978 can_highlight.
7979 (show_source_disasm_command): Call the reset method.
7980 (show_data): Don't set can_highlight. Call the reset method.
7981 (tui_gen_win_info::reset): Rename from init_gen_win_info
7982 (init_and_make_win): Simplify. Return tui_gen_win_info.
7983 (show_source_or_disasm_and_command): Call the reset method.
7984 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7985 (struct tui_cmd_window): Set can_highlight.
7986
79872019-06-25 Tom Tromey <tom@tromey.com>
7988
7989 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7990 from make_visible.
7991 (tui_make_visible, tui_make_invisible): Rewrite.
7992 (tui_win_info::make_visible): Remove.
7993 (tui_source_window_base::make_visible): Update.
7994 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7995 method. Moved from...
7996 (struct tui_win_info) <make_visible>: ...here.
7997
79982019-06-25 Tom Tromey <tom@tromey.com>
7999
8000 * tui/tui-winsource.c
8001 (tui_source_window_base::do_scroll_horizontal): Remove direction
8002 parameter.
8003 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8004 direction parameter.
8005 * tui/tui-win.c (tui_win_info::forward_scroll)
8006 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8007 (tui_win_info::right_scroll): Update.
8008 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8009 direction parameter.
8010 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8011 direction parameter.
8012 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8013 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8014 Remove direction parameter.
8015 (struct tui_source_window_base, struct tui_source_window)
8016 (struct tui_disasm_window, struct tui_data_window)
8017 (struct tui_cmd_window): Update.
8018
80192019-06-25 Tom Tromey <tom@tromey.com>
8020
8021 * tui/tui-winsource.h (tui_set_exec_info_content)
8022 (tui_show_exec_info_content, tui_erase_exec_info_content)
8023 (tui_clear_exec_info_content, tui_update_exec_info): Change
8024 argument to tui_source_window_base.
8025 * tui/tui-winsource.c (tui_set_exec_info_content)
8026 (tui_show_exec_info_content, tui_erase_exec_info_content)
8027 (tui_clear_exec_info_content, tui_update_exec_info): Change
8028 argument to tui_source_window_base.
8029
80302019-06-25 Tom Tromey <tom@tromey.com>
8031
8032 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8033 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8034
80352019-06-25 Tom Tromey <tom@tromey.com>
8036
8037 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8038 check.
8039
80402019-06-25 Tom Tromey <tom@tromey.com>
8041
8042 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8043 type to void.
8044 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8045 type to void.
8046 * tui/tui-source.c (tui_set_source_content): Update.
8047 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8048
80492019-06-25 Tom Tromey <tom@tromey.com>
8050
8051 * tui/tui-win.c (window_name_completer, tui_set_focus)
8052 (tui_all_windows_info): Use name method.
8053 * tui/tui-data.h (struct tui_gen_win_info)
8054 (struct tui_source_window, struct tui_disasm_window)
8055 (struct tui_data_window, struct tui_cmd_window) <name>: New
8056 method.
8057 (tui_win_name): Don't declare.
8058 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8059 (tui_win_name): Remove.
8060
80612019-06-25 Tom Tromey <tom@tromey.com>
8062
8063 * tui/tui-winsource.h (tui_update_source_window)
8064 (tui_update_source_window_as_is): Change parameter type.
8065 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8066 to be a tui_source_window_base.
8067 (tui_update_source_window_as_is): Likewise.
8068 * tui/tui-win.c (make_visible_with_new_height): Update.
8069
80702019-06-25 Tom Tromey <tom@tromey.com>
8071
8072 * tui/tui-winsource.c (tui_erase_source_content)
8073 (tui_show_source_content, tui_show_exec_info_content)
8074 (tui_erase_exec_info_content): Use refresh_window method.
8075 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8076 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8077 from tui_refresh_win.
8078 (tui_data_window::refresh_window): New method.
8079 (tui_win_info::refresh, tui_source_window_base::refresh)
8080 (tui_refresh_all): Use refresh_window method.
8081 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8082 method.
8083 * tui/tui-regs.c (tui_display_register): Call refresh_window
8084 method.
8085 * tui/tui-layout.c (show_source_disasm_command)
8086 (show_source_or_disasm_and_command): Call refresh_window method.
8087 * tui/tui-data.h (struct tui_gen_win_info)
8088 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8089 New method.
8090
80912019-06-25 Tom Tromey <tom@tromey.com>
8092
8093 * tui/tui.c (tui_rl_other_window, tui_enable)
8094 (tui_is_window_visible, tui_get_command_dimension): Update.
8095 * tui/tui-winsource.c (tui_update_source_window_as_is)
8096 (tui_clear_source_content, tui_erase_source_content)
8097 (tui_show_source_line, tui_source_window_base::refill)
8098 (tui_source_window_base::do_scroll_horizontal)
8099 (tui_source_window_base::set_is_exec_point_at)
8100 (tui_update_breakpoint_info, tui_set_exec_info_content)
8101 (tui_alloc_source_buffer, tui_line_is_displayed)
8102 (tui_addr_is_displayed): Update.
8103 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8104 (tui_check_and_display_highlight_if_needed)
8105 (tui_win_info::make_visible, tui_win_info::refresh)
8106 (tui_refresh_all): Update.
8107 * tui/tui-windata.c (tui_first_data_item_displayed)
8108 (tui_delete_data_content_windows, tui_erase_data_content)
8109 (tui_display_all_data, tui_data_window::refresh_all)
8110 (tui_check_data_values): Update.
8111 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8112 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8113 (tui_win_info::backward_scroll, tui_refresh_all_win)
8114 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8115 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8116 (tui_source_window_base::set_new_height)
8117 (tui_data_window::set_new_height)
8118 (make_invisible_and_set_new_height)
8119 (make_visible_with_new_height, new_height_ok)
8120 (parse_scrolling_args): Update.
8121 * tui/tui-stack.c (tui_show_frame_info): Update.
8122 * tui/tui-source.c (tui_set_source_content)
8123 (tui_set_source_content_nil, tui_source_is_displayed)
8124 (tui_source_window::do_scroll_vertical): Update.
8125 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8126 (tui_display_registers_from, tui_display_reg_element_at_line)
8127 (tui_check_register_values, tui_reg_command): Update.
8128 * tui/tui-layout.c (tui_default_win_height)
8129 (show_source_disasm_command, show_data, init_and_make_win)
8130 (show_source_or_disasm_and_command): Update.
8131 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8132 (tui_redisplay_readline, tui_mld_flush)
8133 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8134 (tui_getc): Update.
8135 * tui/tui-disasm.c (tui_set_disassem_content)
8136 (tui_disasm_window::do_scroll_vertical): Update.
8137 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8138 Now virtual.
8139 (struct tui_win_info): Derive from tui_gen_win_info.
8140 <~tui_win_info>: Mark as override.
8141 <generic>: Remove member.
8142 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8143 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8144 (~tui_data_window, ~tui_win_info)
8145 (tui_free_all_source_wins_content): Update.
8146 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8147
81482019-06-25 Tom Tromey <tom@tromey.com>
8149
8150 * tui/tui-layout.c (init_and_make_win): Use new.
8151 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8152 destructor, initializers.
8153 (tui_alloc_generic_win_info): Don't declare.
8154 * tui/tui-data.c (_locator): Add argument to constructor.
8155 (source_win, disasm_win): New globals.
8156 (exec_info): Remove.
8157 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8158 Update.
8159 (tui_alloc_generic_win_info): Remove.
8160 (init_content_element): Use new.
8161 (tui_win_info::tui_win_info): Update.
8162 (free_content_elements) <case DATA_WIN>: Use delete.
8163
81642019-06-25 Tom Tromey <tom@tromey.com>
8165
8166 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8167 * tui/tui-windata.c (tui_first_data_item_displayed)
8168 (tui_delete_data_content_windows): Update.
8169 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8170 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8171 (tui_display_registers_from, tui_check_register_values): Update.
8172 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8173 pointer.
8174 * tui/tui-data.c (init_content_element): Update. Allocate the new
8175 window.
8176 (tui_free_data_content): Update.
8177 (free_content_elements) <case DATA_WIN>: Free the window.
8178
81792019-06-25 Tom Tromey <tom@tromey.com>
8180
8181 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8182 Update.
8183 * tui/tui-layout.c (make_command_window)
8184 (show_source_disasm_command, show_data, init_and_make_win)
8185 (show_source_or_disasm_and_command): Update.
8186 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8187 method.
8188 <can_highight, is_highlighted>: Now bool.
8189 (tui_set_win_highlight): Don't declare.
8190 * tui/tui-data.c (tui_set_win_highlight): Remove.
8191
81922019-06-25 Tom Tromey <tom@tromey.com>
8193
8194 * tui/tui-wingeneral.c (make_visible): Remove check of window
8195 type.
8196
81972019-06-25 Tom Tromey <tom@tromey.com>
8198
8199 * tui/tui-win.c (tui_win_info::max_height)
8200 (tui_cmd_window::max_height): New methods.
8201 (new_height_ok): Call max_height.
8202 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8203 <max_height>: New method.
8204
82052019-06-25 Tom Tromey <tom@tromey.com>
8206
8207 * tui/tui-win.c (tui_source_window_base::set_new_height)
8208 (tui_data_window::set_new_height): New methods.
8209 (make_invisible_and_set_new_height): Call set_new_height method.
8210 * tui/tui-data.h (struct tui_win_info)
8211 (struct tui_source_window_base, struct tui_data_window)
8212 <set_new_height>: New method.
8213
82142019-06-25 Tom Tromey <tom@tromey.com>
8215
8216 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8217 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8218 tui_refresh_data_win.
8219 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8220 method.
8221 (tui_refresh_all_win): Call the refresh_all method.
8222 (tui_set_focus): Likewise.
8223 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8224 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8225 Likewise.
8226
82272019-06-25 Tom Tromey <tom@tromey.com>
8228
8229 * tui/tui-winsource.h (tui_refill_source_window)
8230 (tui_set_is_exec_point_at): Don't declare.
8231 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8232 (tui_source_window_base::refill): Rename from
8233 tui_refill_source_window.
8234 (tui_source_window_base::do_scroll_horizontal): Update.
8235 (tui_source_window_base::set_is_exec_point_at): Rename from
8236 tui_set_is_exec_point_at.
8237 (tui_update_all_breakpoint_info): Update.
8238 * tui/tui-stack.c (tui_show_frame_info): Update.
8239 * tui/tui-layout.c (show_data): Add cast.
8240 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8241 * tui/tui-data.h (struct tui_source_window_base) <refill,
8242 set_is_exec_point_at>: New methods.
8243 (tui_source_windows, tui_add_to_source_windows): Update types.
8244 (tui_add_to_source_windows): Remove redundant declaration.
8245 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8246 (tui_source_windows): Change return type.
8247 (tui_clear_source_windows_detail): Update.
8248 (tui_add_to_source_windows): Change type of parameter.
8249 (tui_free_all_source_wins_content): Update.
8250
82512019-06-25 Tom Tromey <tom@tromey.com>
8252
8253 * tui/tui-wingeneral.c (tui_win_info::refresh)
8254 (tui_source_window_base::refresh): New methods.
8255 (tui_refresh_all): Call the refresh method.
8256 * tui/tui-data.h (struct tui_win_info)
8257 (struct tui_source_window_base) <refresh>: New method.
8258
82592019-06-25 Tom Tromey <tom@tromey.com>
8260
8261 * tui/tui.h (tui_is_window_visible): Return bool.
8262 * tui/tui.c (tui_is_window_visible): Return bool.
8263 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8264 (tui_make_visible, tui_make_invisible)
8265 (tui_win_info::make_visible)
8266 (tui_source_window_base::make_visible, make_all_visible)
8267 (tui_make_all_visible, tui_make_all_invisible): Update.
8268 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8269 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8270 bool.
8271 (struct tui_win_info, struct tui_source_window_base)
8272 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8273 * tui/tui-data.c (tui_init_generic_part): Update.
8274
82752019-06-25 Tom Tromey <tom@tromey.com>
8276
8277 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8278 (tui_source_window_base::make_visible): New methods.
8279 (make_all_visible): Make method call.
8280 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8281 (struct tui_source_window_base, struct tui_cmd_window): Override
8282 make_visible.
8283 (tui_win_is_source_type): Don't declare.
8284 * tui/tui-data.c (tui_win_is_source_type): Remove.
8285
82862019-06-25 Tom Tromey <tom@tromey.com>
8287
8288 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8289 NULL check.
8290
82912019-06-25 Tom Tromey <tom@tromey.com>
8292
8293 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8294 Inline constructor. Add initializers for members.
8295 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8296 constructors; now inline in class.
8297
82982019-06-25 Tom Tromey <tom@tromey.com>
8299
8300 * tui/tui-regs.c (tui_show_registers): Update.
8301 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8302 bool.
8303 * tui/tui-data.c (tui_data_window::clear_detail)
8304 (tui_data_window): Update.
8305
83062019-06-25 Tom Tromey <tom@tromey.com>
8307
8308 * tui/tui-windata.c (tui_display_all_data)
8309 (tui_display_data_from_line, tui_display_data_from)
8310 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8311 Update.
8312 * tui/tui-regs.c (tui_last_regs_line_no)
8313 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8314 (tui_show_registers, tui_show_register_group)
8315 (tui_display_registers_from, tui_display_reg_element_at_line)
8316 (tui_display_registers_from_line, tui_check_register_values)
8317 (tui_reg_next, tui_reg_prev): Update.
8318 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8319 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8320 tui_data_window.
8321 (struct tui_win_info) <detail>: Remove. Add new fields from
8322 tui_data_info.
8323 (TUI_DATA_WIN): Add cast.
8324 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8325 (~tui_data_window): Simplify.
8326
83272019-06-25 Tom Tromey <tom@tromey.com>
8328
8329 * tui/tui-layout.c (show_source_disasm_command)
8330 (show_source_or_disasm_and_command): Update.
8331 * tui/tui-io.c (update_cmdwin_start_line)
8332 (tui_redisplay_readline): Update.
8333 * tui/tui-data.h (struct tui_command_info): Remove.
8334 (struct tui_win_info) <detail>: Remove command_info member.
8335 (struct tui_data_window) <start_line>: New member, from
8336 tui_command_info.
8337 (TUI_CMD_WIN): Add casts.
8338
83392019-06-25 Tom Tromey <tom@tromey.com>
8340
8341 * tui/tui-winsource.c (tui_update_source_window)
8342 (tui_refill_source_window)
8343 (tui_source_window_base::do_scroll_horizontal)
8344 (tui_update_breakpoint_info, tui_set_exec_info_content)
8345 (tui_show_exec_info_content, tui_erase_exec_info_content)
8346 (tui_clear_exec_info_content): Update.
8347 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8348 Update.
8349 * tui/tui-win.c (make_invisible_and_set_new_height)
8350 (make_visible_with_new_height): Update.
8351 * tui/tui-source.c (tui_set_source_content)
8352 (tui_show_symtab_source): Update.
8353 * tui/tui-layout.c (extract_display_start_addr)
8354 (show_source_disasm_command, show_data)
8355 (make_source_or_disasm_window)
8356 (show_source_or_disasm_and_command): Update.
8357 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8358 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8359 "gdbarch".
8360 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8361 to tui_source_window_base.
8362 (struct tui_win_info) <detail>: Remove source_info member.
8363 (struct tui_source_window_base) <has_locator>: Inline.
8364 Move contents from tui_source_info; rename has_locator member to
8365 m_has_locator.
8366 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8367 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8368 header file.
8369 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8370 Simplify.
8371 (tui_free_all_source_wins_content): Cast to
8372 tui_source_window_base.
8373
83742019-06-25 Tom Tromey <tom@tromey.com>
8375
8376 * tui/tui-win.c (make_invisible_and_set_new_height)
8377 (make_visible_with_new_height): Call has_locator method.
8378 * tui/tui-layout.c (show_source_disasm_command, show_data)
8379 (show_source_or_disasm_and_command): Update for bool change.
8380 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8381 (tui_win_info) <has_locator>: New method.
8382 (struct tui_source_window_base) <has_locator>: New method.
8383 (tui_win_has_locator): Don't declare.
8384 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8385 from tui_win_has_locator.
8386 (tui_source_window_base): Use false, not FALSE.
8387
83882019-06-25 Tom Tromey <tom@tromey.com>
8389
8390 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8391 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8392 clear_detail method directly.
8393 (tui_clear_win_detail): Remove.
8394
83952019-06-25 Tom Tromey <tom@tromey.com>
8396
8397 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8398 "this", not TUI_DISASM_WIN.
8399
84002019-06-25 Tom Tromey <tom@tromey.com>
8401
8402 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8403 declare.
8404 * tui/tui-winsource.c
8405 (tui_source_window_base::do_scroll_horizontal): Rename from
8406 tui_horizontal_source_scroll.
8407 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8408 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8409 from tui_vertical_data_scroll.
8410 * tui/tui-win.h (tui_scroll): Don't declare.
8411 * tui/tui-win.c (tui_win_info::forward_scroll)
8412 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8413 (tui_win_info::right_scroll): Rename and update.
8414 (tui_scroll_forward_command, tui_scroll_backward_command)
8415 (tui_scroll_left_command, tui_scroll_right_command): Update.
8416 (tui_scroll): Remove.
8417 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8418 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8419 from tui_vertical_source_scroll.
8420 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8421 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8422 from tui_vertical_disassem_scroll.
8423 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8424 do_scroll_horizontal>: New methods.
8425 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8426 Likewise.
8427 (struct tui_source_window_base): Add do_scroll_horizontal.
8428 (struct tui_source_window, struct tui_disasm_window): Add
8429 do_scroll_vertical.
8430 (struct tui_data_window, struct tui_cmd_window): Add
8431 do_scroll_horizontal and do_scroll_vertical.
8432 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8433
84342019-06-25 Tom Tromey <tom@tromey.com>
8435
8436 * tui/tui-data.h (struct tui_source_window_base): New struct.
8437 (struct tui_source_window): Derive from tui_source_window_base.
8438 (struct tui_disasm_window): New struct.
8439 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8440 from tui_source_window::clear_detail.
8441 (tui_source_window_base): Rename from tui_source_window.
8442 (~tui_source_window_base): Rename from ~tui_source_window.
8443 (tui_alloc_win_info): Create a tui_disasm_window.
8444
84452019-06-25 Tom Tromey <tom@tromey.com>
8446
8447 * tui/tui-data.h (struct tui_source_window)
8448 (struct tui_data_window): Declare destructors.
8449 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8450 destructors.
8451 (tui_win_info): Simplify.
8452
84532019-06-25 Tom Tromey <tom@tromey.com>
8454
8455 * tui/tui-winsource.c (tui_display_main)
8456 (tui_update_source_windows_with_addr)
8457 (tui_update_all_breakpoint_info): Update.
8458 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8459 (new_height_ok, parse_scrolling_args): Update.
8460 * tui/tui-stack.c (tui_show_frame_info): Update.
8461 * tui/tui-data.h (struct tui_list): Remove.
8462 (tui_source_windows): Return a reference to a std::vector.
8463 * tui/tui-data.c (source_windows): Now a std::vector.
8464 (tui_source_windows): Change return type.
8465 (tui_clear_source_windows): Rewrite.
8466 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8467 (tui_free_all_source_wins_content): Rewrite.
8468
84692019-06-25 Tom Tromey <tom@tromey.com>
8470
8471 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8472 (struct tui_data_window, struct tui_cmd_window): Declare
8473 clear_detail method.
8474 * tui/tui-data.c (tui_source_window::clear_detail)
8475 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8476 methods.
8477 (tui_clear_win_detail): Simplify.
8478
84792019-06-25 Tom Tromey <tom@tromey.com>
8480
8481 * tui/tui-layout.c (make_source_window, make_disasm_window)
8482 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8483 Return the new window.
8484 (show_source_disasm_command, show_data)
8485 (show_source_or_disasm_and_command): Update.
8486
84872019-06-25 Tom Tromey <tom@tromey.com>
8488
8489 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8490 parameter. Return the new window.
8491 (show_source_disasm_command): Update and remove NULL check.
8492 (show_source_or_disasm_and_command): Update.
8493
84942019-06-25 Tom Tromey <tom@tromey.com>
8495
8496 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8497
84982019-06-25 Tom Tromey <tom@tromey.com>
8499
8500 * tui/tui-data.h (struct tui_win_info): Make constructor
8501 protected. Make destructor virtual. Add initializers.
8502 (tui_source_window, tui_data_window, tui_cmd_window): New
8503 classes.
8504 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8505 constructor. Add "type" parameter.
8506 (tui_source_window, tui_data_window, tui_cmd_window): New
8507 constructors.
8508 (tui_alloc_win_info): Instantiate the appropriate subclass.
8509
85102019-06-25 Tom Tromey <tom@tromey.com>
8511
8512 * tui/tui-win.c (tui_resize_all): Use delete.
8513 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8514 destructor.
8515 (tui_free_window): Don't declare.
8516 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8517 Update.
8518
85192019-06-25 Tom Tromey <tom@tromey.com>
8520
8521 * tui/tui-data.h (struct tui_win_info): Add constructor.
8522 * tui/tui-data.c (tui_alloc_win_info): Use new.
8523 (tui_free_window): Use delete.
8524
85252019-06-22 Tom Tromey <tom@tromey.com>
8526
8527 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8528 declare.
8529 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8530
85312019-06-22 Tom Tromey <tom@tromey.com>
8532
8533 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8534 declare.
8535 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8536
85372019-06-22 Tom de Vries <tdevries@suse.de>
8538
8539 * dwarf2read.c (create_addrmap_from_aranges)
8540 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8541 instead of '%zu'.
8542
85432019-06-21 Simon Marchi <simon.marchi@efficios.com>
8544
8545 * dwarf2read.h (dwarf2_section_info_def): Remove.
8546 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8547 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8548 std::vector<dwarf2_section_info>.
8549 (struct dwo_file) <~dwo_file>: Remove.
8550 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8551 types field.
8552 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8553 (dwarf2_read_debug_names): Likewise.
8554 (create_debug_types_hash_table): Change parameter type to
8555 array_view, adjust code accordingly.
8556 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8557 (partial_die_info::fixup): Likewise.
8558 (determine_prefix): Likewise.
8559 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8560
85612019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8562
8563 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8564 gdb_bfd_ref_ptr.
8565 <~dwo_file>: Remove call to gdb_bfd_unref.
8566 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8567 gdb_bfd_ref_ptr::get.
8568
85692019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8570
8571 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8572 type to htab_up.
8573 * dwarf2read.c (struct dwo_file): Initialize fields.
8574 <~dwo_file>: New.
8575 (free_dwo_file): Remove, move content to ~dwo_file.
8576 (struct dwo_file_deleter): Remove.
8577 (dwo_file_up>: Remove custom deleter.
8578 (free_dwo_files): Remove.
8579 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8580 dwo_files.
8581 (process_skeletonless_type_units): Call unique_ptr::get.
8582 (allocate_dwo_file_hash_table): Add deleter to created hash
8583 table. Change return type to htab_up.
8584 (lookup_dwo_file_slot): Don't memset dwo_file, call
8585 unique_ptr::get.
8586 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8587 (create_dwo_unit_in_dwp_v2): Likewise.
8588 (open_and_init_dwo_file): Likewise.
8589 (free_dwo_file_from_slot): Remove.
8590
85912019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8592
8593 * dwarf2read.h (struct dwarf2_section_info) <readin,
8594 is_virtual>: Change type to bool.
8595 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8596 true instead of 1.
8597
85982019-06-19 Tom Tromey <tom@tromey.com>
8599
8600 * tui/tui-data.h (tui_init_content_element): Don't declare.
8601
86022019-06-19 Tom Tromey <tom@tromey.com>
8603
8604 * tui/tui-data.h (tui_init_win_info): Don't declare.
8605
86062019-06-19 Tom de Vries <tdevries@suse.de>
8607
8608 * dwarf2read.h (abstract_to_concrete): Change type to
8609 std::unordered_map<sect_offset, std::vector<sect_offset>,
8610 gdb::hash_enum<sect_offset>>.
8611
86122019-06-19 Tom Tromey <tromey@adacore.com>
8613
8614 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8615 EVAL_AVOID_SIDE_EFFECTS specially.
8616
86172019-06-19 Tom Tromey <tromey@adacore.com>
8618
8619 * source-cache.c (highlighter): New global.
8620 (source_cache::get_source_lines): Create a highlighter on demand.
8621
86222019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8623
8624 * defs.h (deprecated_interactive_hook): Delete declaration.
8625 * interps.c (clear_interpreter_hooks): Remove use of
8626 deprecated_interactive_hook.
8627 * top.c (deprecated_interactive_hook): Delete definition.
8628 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8629
86302019-06-18 Tom de Vries <tdevries@suse.de>
8631
8632 PR gdb/24515
8633 * dwarf2read.h (abstract_to_concrete): Change type from
8634 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8635 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8636 * dwarf2read.c (read_variable): Update.
8637 (dwarf2_fetch_die_loc_sect_off): Update.
8638
86392019-06-17 Tom de Vries <tdevries@suse.de>
8640
8641 PR gdb/24617
8642 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8643 accessing parent[parent_len - 1].
8644
86452019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8646
8647 PR gdb/24364
8648 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8649 call dtrace_process_dof with NULL dof.
8650
86512019-06-16 Tom de Vries <tdevries@suse.de>
8652
8653 PR gdb/24445
8654 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8655
86562019-06-16 Tom Tromey <tom@tromey.com>
8657
8658 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8659 (make_all_visible): Use address of member.
8660
86612019-06-16 Tom Tromey <tom@tromey.com>
8662
8663 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8664 (tui_free_window, free_content, free_content_elements): Remove
8665 unnecessary cast.
8666 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8667 cast.
8668 * tui/tui-regs.c (tui_show_register_group)
8669 (tui_display_registers_from, tui_display_reg_element_at_line):
8670 Remove unnecessary cast.
8671
86722019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8673
8674 * linux-nat.c (normal_mask): Delete.
8675 (_initialize_linux_nat): Don't initialise normal_mask.
8676
86772019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8678
8679 PR gdb/24445
8680 * dwarf-index-write.h (write_psymtabs_to_index): Add
8681 dwz_basename parameter.
8682 * dwarf-index-write.c (write_gdbindex): Move file writing to
8683 write_gdbindex_1. Change return type void.
8684 (assert_file_size): Move up, remove filename parameter.
8685 (write_gdbindex_1): New function.
8686 (write_debug_names): Change return type to void, call
8687 assert_file_size.
8688 (struct index_wip_file): New struct.
8689 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8690 file logic to index_wip_file. Write index for dwz file if
8691 needed.
8692 (save_gdb_index_command): Pass basename of dwz file, if present.
8693 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8694 build-id of dwz file, if present.
8695 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8696 (dwarf2_get_dwz_file): Likewise.
8697 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8698 (dwarf2_get_dwz_file): Likewise.
8699
87002019-06-16 Tom Tromey <tom@tromey.com>
8701
8702 * coffread.c (process_coff_symbol): Use xstrdup.
8703 * value.c (create_internalvar): Use xstrdup.
8704
87052019-06-16 Tom Tromey <tom@tromey.com>
8706
8707 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8708 * breakpoint.c (stopin_command, stopat_command)
8709 (until_break_command, decode_location_default): Remove unnecessary
8710 cast.
8711 * utils.c (subset_compare): Remove unnecessary cast.
8712 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8713 cast.
8714 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8715 cast.
8716 * infcmd.c (path_command): Remove unnecessary cast.
8717 * coffread.c (decode_type): Remove unnecessary cast.
8718 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8719 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8720 * tui/tui-stack.c (tui_show_locator_content)
8721 (tui_show_frame_info): Remove unnecessary cast.
8722 * tui/tui-win.c (tui_scroll_forward_command)
8723 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8724 (parse_scrolling_args): Remove unnecessary cast.
8725 * tui/tui-data.c (init_win_info, tui_del_window)
8726 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8727 (free_content_elements): Remove unnecessary cast.
8728 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8729 unnecessary cast.
8730 * tui/tui-source.c (tui_set_source_content)
8731 (tui_vertical_source_scroll): Remove unnecessary cast.
8732 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8733 cast.
8734 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8735 * tui/tui-regs.c (tui_display_registers_from)
8736 (tui_display_register): Remove unnecessary cast.
8737 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8738 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8739 (make_visible): Remove unnecessary cast.
8740 * tui/tui-winsource.c (tui_erase_source_content)
8741 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8742 unnecessary cast.
8743 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8744 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8745 * stabsread.c (read_type, read_array_type, read_range_type):
8746 Remove unnecessary cast.
8747 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8748 (parse_symbol, parse_type, upgrade_type, parse_external)
8749 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8750 unnecessary cast.
8751 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8752
87532019-06-16 Tom Tromey <tom@tromey.com>
8754
8755 * tui/tui-data.c (tui_alloc_generic_win_info)
8756 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8757 checks.
8758
87592019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8760 Andrew Burgess <andrew.burgess@embecosm.com>
8761
8762 * f-typeprint.c (f_print_type): Don't return early for not
8763 associated or not allocated types.
8764 (f_type_print_varspec_suffix): Add print_rank parameter and print
8765 ranks of array types in case they dangling.
8766 (f_type_print_base): Add print_rank parameter.
8767
87682019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8769
8770 * NEWS: Mention new MI commands.
8771 * break-catch-throw.c (enum exception_event_kind): Move to
8772 breakpoint.h.
8773 (print_mention_exception_catchpoint): Output text as a single
8774 message.
8775 (catch_exception_command_1): Rename to...
8776 (catch_exception_event): ...this, make non-static, update header
8777 command, and change some parameter types.
8778 (catch_catch_command): Update for changes to
8779 catch_exception_command_1.
8780 (catch_throw_command): Likewise.
8781 (catch_rethrow_command): Likewise.
8782 * breakpoint.c (enum exception_event_kind): Delete.
8783 * breakpoint.h (enum exception_event_kind): Moved here from
8784 break-catch-throw.c.
8785 (catch_exception_event): Declare.
8786 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8787 (mi_cmd_catch_throw): New function.
8788 (mi_cmd_catch_rethrow): New function.
8789 (mi_cmd_catch_catch): New function.
8790 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8791 'catch-catch' entries.
8792 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8793 (mi_cmd_catch_rethrow): Declare.
8794 (mi_cmd_catch_catch): Declare.
8795
87962019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8797
8798 * annotate.c (annotate_source_line): Change return type to void,
8799 update implementation to match.
8800 * annotate.h (annotate_source_line): Change return type to void,
8801 update header comment.
8802 * stack.c (print_frame_info): Don't change what frame information
8803 is printed based on whether annotations are on or not.
8804
88052019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8806
8807 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8808 (annotate_source): Make static.
8809 (annotate_source_line): Moved from source.c and renamed from
8810 identify_source_line. Update the return type.
8811 * annotate.h (annotate_source): Delete declaration.
8812 (annotate_source_line): Declaration moved from source.h, and
8813 renamed from identify_source_line. Return type updated.
8814 * source.c (identify_source_line): Moved to annotate.c and renamed
8815 to annotate_source_line.
8816 (info_line_command): Remove check of annotation_level.
8817 * source.h (identify_source_line): Move declaration to annotate.h
8818 and rename to annotate_source_line.
8819 * stack.c: Add 'annotate.h' include.
8820 (print_frame_info): Remove check of annotation_level before
8821 calling annotate_source_line.
8822
88232019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8824
8825 * source-cache.c (source_cache::get_plain_source_lines): Use
8826 open_source_file_with_line_charpos instead of just
8827 open_source_file, remove call to find_source_lines.
8828 (source_cache::get_source_lines): Likewise.
8829 * source.c (find_source_lines): Make static.
8830 (get_filename_and_charpos): Renamed into...
8831 (open_source_file_with_line_charpos): ..this along with changes to
8832 return a scoped_fd, and some other minor clean ups.
8833 (identify_source_line): Use open_source_file_with_line_charpos.
8834 (search_command_helper): Use open_source_file_with_line_charpos
8835 instead of just open_source_file, remove call to
8836 find_source_lines.
8837 * source.h (open_source_file_with_line_charpos): Declare new
8838 function.
8839 (find_source_lines): Delete declaration.
8840
88412019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8842
8843 * source.c (get_filename_and_charpos): Remove fullname
8844 parameter.
8845 (identify_source_line): Update call to get_filename_and_charpos.
8846
88472019-06-14 Tom Tromey <tromey@adacore.com>
8848
8849 PR gdb/24502:
8850 * ui-style.h (skip_ansi_escape): Update comment.
8851 * ui-file.h (class no_terminal_escape_file): New class.
8852 * ui-file.c (no_terminal_escape_file::write)
8853 (no_terminal_escape_file::puts): New methods.
8854 * cli/cli-logging.c (handle_redirections): Use
8855 no_terminal_escape_file.
8856
88572019-06-14 Tom Tromey <tromey@adacore.com>
8858
8859 * NEWS: Move convenience variable news above Python news.
8860
88612019-06-14 Tom Tromey <tom@tromey.com>
8862
8863 * gnulib: Move directory to top-level.
8864 * configure.ac: Don't configure gnulib.
8865 * configure: Rebuild.
8866 * common/common-defs.h: Use new path to gnulib.
8867 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8868 (GNULIB_H): Remove.
8869 (INCGNU): Look in new gnulib location.
8870 (HFILES_NO_SRCDIR): Remove gnulib files.
8871 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8872 (generated_files): Remove GNULIB_H.
8873 ($(LIBGNU), all-lib): Remove targets.
8874 (distclean): Don't mention GNULIB_BUILDDIR.
8875 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8876
88772019-06-14 Tom Tromey <tromey@adacore.com>
8878
8879 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8880 Warn if symbol file does not provide any symbols.
8881
88822019-06-14 Tom Tromey <tromey@adacore.com>
8883
8884 * source.c (find_and_open_source): Respect basenames_may_differ.
8885
88862019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8887
8888 * annotate.c (annotate_breakpoints_invalid): Make use of
8889 scoped_restore_terminal_state.
8890 (annotate_frames_invalid): Likewise.
8891
88922019-06-14 Tom Tromey <tromey@adacore.com>
8893
8894 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8895 allow assignment to an internalvar.
8896
88972019-06-14 Tom Tromey <tromey@adacore.com>
8898
8899 * ada-lex.l: Allow "_" in attribute names.
8900
89012019-06-14 Tom Tromey <tromey@adacore.com>
8902
8903 PR gdb/24653:
8904 * regcache.c (registers_changed): Don't call alloca.
8905 * top.c (execute_command): Don't call alloca.
8906
89072019-06-13 Pedro Alves <palves@redhat.com>
8908
8909 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8910 'expression'. When parsing an expression, error out if there's
8911 junk after "unlimited".
8912 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8913 (do_set_command): Adjust calls to is_unlimited_literal.
8914
89152019-06-13 Pedro Alves <palves@redhat.com>
8916
8917 * compile/compile.c (make_compile_options_def_group): Add braces
8918 around array_view initializer.
8919 * thread.c (make_thread_apply_all_options_def_group)
8920 (make_thread_apply_all_options_def_group): Likewise.
8921
89222019-06-13 Pedro Alves <palves@redhat.com>
8923
8924 * NEWS (New commands): Mention "maint test-options
8925 require-delimiter", "maint test-options unknown-is-error", "maint
8926 test-options unknown-is-operand" and "maint show
8927 test-options-completion-result".
8928 (New command options, command completion): New section.
8929 (Completion improvements): New section.
8930 Mention that you can abbreviate "unlimited".
8931
89322019-06-13 Pedro Alves <palves@redhat.com>
8933
8934 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8935 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8936 * unittests/cli-utils-selftests.c (test_parse_flags)
8937 (test_parse_flags_qcs): Delete.
8938 (test_cli_utils): Don't call deleted functions.
8939
89402019-06-13 Pedro Alves <palves@redhat.com>
8941
8942 * thread.c: Include "cli/cli-option.h".
8943 (tp_array_compar_ascending): Global.
8944 (tp_array_compar): Delete function.
8945 (tp_array_compar_ascending, tp_array_compar_descending): New
8946 functions.
8947 (ascending_option_def, qcs_flag_option_def)
8948 (thr_qcs_flags_option_defs)
8949 (make_thread_apply_all_options_def_group)
8950 (make_thread_apply_options_def_group): New.
8951 (thread_apply_all_command): Use gdb::option::process_options.
8952 (thread_apply_command_completer)
8953 (thread_apply_all_command_completer): New.
8954 (thread_apply_command): Use gdb::option::process_options.
8955 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8956 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8957 to generate help text of "thread apply". Adjust "taas"'s help.
8958 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8959 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8960
89612019-06-13 Pedro Alves <palves@redhat.com>
8962
8963 * thread.c (thread_apply_command): Check for invalid TID with
8964 isdigit instead of !isalpha.
8965
89662019-06-13 Pedro Alves <palves@redhat.com>
8967
8968 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8969 (validate_flags_qcs): New.
8970 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8971 (validate_flags_qcs): Declare.
8972 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8973 (make_frame_apply_options_def_group): New.
8974 (frame_apply_command_count): Process options with
8975 gdb::option::process_options.
8976 (frame_apply_completer): New.
8977 (frame_apply_level_completer, frame_apply_all_completer)
8978 (frame_apply_completer): New.
8979 (_initialize_stack): Update help of "frame apply", "frame apply
8980 level", "frame apply all" and "faas" to mention supported options
8981 and install command completers.
8982 * stack.h (frame_apply_all_completer): Declare.
8983 * thread.c: Include "stack.h".
8984 (tfaas_command): Add "--".
8985 (_initialize_thread): Update help "tfaas" to mention supported
8986 options and install command completer.
8987
89882019-06-13 Pedro Alves <palves@redhat.com>
8989
8990 * completer.c (complete_nested_command_line): New.
8991 (gdb_completion_word_break_characters_throw): Add assertion.
8992 * completer.h (complete_nested_command_line): Declare.
8993
89942019-06-13 Pedro Alves <palves@redhat.com>
8995
8996 * stack.c (parse_backtrace_qualifiers): New.
8997 (backtrace_command): Use it.
8998 (backtrace_command_completer): Complete on qualifiers.
8999
90002019-06-13 Pedro Alves <palves@redhat.com>
9001
9002 * frame.c: Include "cli/cli-option.h.
9003 (user_set_backtrace_options): New.
9004 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9005 Delete.
9006 (get_prev_frame): Adjust.
9007 (boolean_option_def, uinteger_option_def)
9008 (set_backtrace_option_defs): New.
9009 (_initialize_frame): Adjust and use
9010 gdb::option::add_setshow_cmds_for_options to install "set
9011 backtrace past-main" and "set backtrace past-entry".
9012 * frame.h: Include "cli/cli-option.h".
9013 (struct frame_print_options): Forward declare.
9014 (print_frame_arguments_all, print_frame_arguments_scalars)
9015 (print_frame_arguments_none): Declare.
9016 (print_entry_values): Delete declaration.
9017 (struct frame_print_options, user_frame_print_options): New.
9018 (struct set_backtrace_options): New.
9019 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9020 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9021 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9022 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9023 (list_args_or_locals): Add frame_print_options parameter.
9024 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9025 * python/py-framefilter.c (enumerate_args): Pass down
9026 USER_FRAME_PRINT_OPTIONS.
9027 * stack.c: Include "cli/cli-option.h".
9028 (print_frame_arguments_all, print_frame_arguments_scalars)
9029 (print_frame_arguments_none): Declare.
9030 (print_raw_frame_arguments, print_entry_values): Delete.
9031 (user_frame_print_options): New.
9032 (boolean_option_def, enum_option_def, frame_print_option_defs):
9033 New.
9034 (struct backtrace_cmd_options): New.
9035 (bt_flag_option_def): New.
9036 (backtrace_command_option_defs): New.
9037 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9038 (print_frame_arg, read_frame_arg, print_frame_args)
9039 (print_frame_info, print_frame): Add frame_print_options parameter
9040 and use it.
9041 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9042 (backtrace_command_1): Add frame_print_options and
9043 backtrace_cmd_options parameters and use them.
9044 (make_backtrace_options_def_group): New.
9045 (backtrace_command): Process command options with
9046 gdb::option::process_options.
9047 (backtrace_command_completer): New.
9048 (_initialize_stack): Extend "backtrace"'s help to mention
9049 supported options. Install completer for "backtrace".
9050 Install some settings commands with add_setshow_cmds_for_options.
9051
90522019-06-13 Pedro Alves <palves@redhat.com>
9053
9054 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9055 and that "set/show print raw frame-arguments" are now deprecated.
9056
9057 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9058 command.
9059 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9060 * stack.c (_initialize_stack): Install "set/show print
9061 raw-frame-arguments", and deprecate "set/show print raw
9062 frame-arguments".
9063 * valprint.c (_initialize_valprint): Deprecate "set/show print
9064 raw".
9065
90662019-06-13 Pedro Alves <palves@redhat.com>
9067
9068 * compile/compile.c (struct compile_options): New.
9069 (compile_flag_option_def, compile_command_option_defs)
9070 (make_compile_options_def_group): New.
9071 (compile_file_command): Handle options with
9072 gdb::option::process_options.
9073 (compile_file_command_completer): New function.
9074 (compile_code_command): Handle options with
9075 gdb::option::process_options.
9076 (compile_code_command_completer): New function.
9077 (_initialize_compiler): Install completers for "compile code" and
9078 "compile file". Mention available options in "compile code" and
9079 "compile code"'s help.
9080 * completer.c (advance_to_completion_word): New, factored out from
9081 ...
9082 (advance_to_expression_complete_word_point): ... this.
9083 (advance_to_filename_complete_word_point): New.
9084 * completer.h (advance_to_filename_complete_word_point): New
9085 declaration.
9086
90872019-06-13 Pedro Alves <palves@redhat.com>
9088
9089 * compile/compile.c: Include "cli/cli-option.h".
9090 (compile_print_value): Scope data pointer is now a
9091 value_print_options pointer; adjust.
9092 (compile_print_command): Process options. Scope data pointer is
9093 now a value_print_options pointer; adjust.
9094 (_initialize_compile): Update "compile print"'s help to include
9095 supported options. Install a completer for "compile print".
9096 * cp-valprint.c (show_vtblprint, show_objectprint)
9097 (show_static_field_print): Delete.
9098 (_initialize_cp_valprint): Don't install "set print
9099 static-members", "set print vtbl", "set print object" here.
9100 * printcmd.c: Include "cli/cli-option.h" and
9101 "common/gdb_optional.h".
9102 (print_command_parse_format): Rework to fill in a
9103 value_print_options instead of a format_data.
9104 (print_value): Change parameter type from format_data pointer to
9105 value_print_options reference. Adjust.
9106 (print_command_1): Process options. Adjust to pass down a
9107 value_print_options.
9108 (print_command_completer): New.
9109 (_initialize_printcmd): Install print_command_completer as
9110 handle_brkchars completer for the "print" command. Update
9111 "print"'s help to include supported options.
9112 * valprint.c: Include "cli/cli-option.h".
9113 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9114 here from cp-valprint.c.
9115 (boolean_option_def, uinteger_option_def)
9116 (value_print_option_defs, make_value_print_options_def_group):
9117 New. Use gdb::option::add_setshow_cmds_for_options to install
9118 "set print elements", "set print null-stop", "set print repeats",
9119 "set print pretty", "set print union", "set print array", "set
9120 print address", "set print symbol", "set print array-indexes".
9121 * valprint.h: Include <string> and "cli/cli-option.h".
9122 (make_value_print_options_def_group): Declare.
9123 (print_value): Change parameter type from format_data pointer to
9124 value_print_options reference.
9125 (print_command_completer): Declare.
9126
91272019-06-13 Pedro Alves <palves@redhat.com>
9128
9129 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9130 (COMMON_SFILES): Add maint-test-settings.c.
9131 * cli/cli-decode.c (boolean_enums): New global, factored out from
9132 ...
9133 (add_setshow_boolean_cmd): ... here.
9134 * cli/cli-decode.h (boolean_enums): Declare.
9135 * cli/cli-option.c: New file.
9136 * cli/cli-option.h: New file.
9137 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9138 factored out from ...
9139 (parse_cli_boolean_value(const char *)): ... this.
9140 (is_unlimited_literal): Change parameter type to pointer to
9141 pointer. Adjust and advance ARG pointer.
9142 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9143 (parse_cli_var_enum): New, factored out from ...
9144 (do_set_command): ... this. Adjust.
9145 * cli/cli-setshow.h (parse_cli_boolean_value)
9146 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9147 (parse_cli_var_enum): Declare.
9148 * cli/cli-utils.c: Include "cli/cli-option.h".
9149 (get_ulongest): New.
9150 * cli/cli-utils.h (get_ulongest): Declare.
9151 (check_for_argument): New overloads.
9152 * maint-test-options.c: New file.
9153
91542019-06-13 Pedro Alves <palves@redhat.com>
9155
9156 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9157 parse a range if "-" is at the end of the string.
9158
91592019-06-13 Pedro Alves <palves@redhat.com>
9160
9161 * cli/cli-setshow.c (parse_auto_binary_operation)
9162 (parse_cli_boolean_value): Don't allow "o".
9163
91642019-06-13 Pedro Alves <palves@redhat.com>
9165
9166 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9167 * NEWS: Mention maint test-settings KIND.
9168 * maint-test-settings.c: New file.
9169
91702019-06-13 Pedro Alves <palves@redhat.com>
9171
9172 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9173 completer.
9174 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9175 "set" completers.
9176
91772019-06-13 Pedro Alves <palves@redhat.com>
9178
9179 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9180 after item.
9181
91822019-06-13 Pedro Alves <palves@redhat.com>
9183
9184 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9185
91862019-06-13 Pedro Alves <palves@redhat.com>
9187
9188 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9189 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9190 call.
9191 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9192 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9193 calls.
9194 (check_for_argument): Skip spaces after argument.
9195
91962019-06-13 Pedro Alves <palves@redhat.com>
9197
9198 * thread.c (thread_apply_command): Adjust TID parsing.
9199 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9200 detected before end of string.
9201 (tid_is_in_list): Error out if LIST is invalid.
9202
92032019-06-13 Pedro Alves <palves@redhat.com>
9204
9205 * completer.c (complete_line_internal_1): Rewind completion word
9206 point.
9207 (completion_tracker::advance_custom_word_point_by): Change
9208 parameter type to int.
9209 * completer.h (completion_tracker::advance_custom_word_point_by):
9210 Likewise.
9211
92122019-06-13 Pedro Alves <palves@redhat.com>
9213
9214 * completer.c (advance_to_completion_word): Handle delimiters.
9215
92162019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9217
9218 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9219
92202019-06-11 Tom Tromey <tom@tromey.com>
9221
9222 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9223 (xmalloc_failed): Move to alloc.c.
9224 * alloc.c: New file.
9225 * Makefile.in (COMMON_SFILES): Add alloc.c.
9226
92272019-06-11 Tom Tromey <tom@tromey.com>
9228
9229 * nat/linux-waitpid.c: Don't include server.h.
9230 (linux_debug): Remove.
9231 (my_waitpid): Update.
9232
92332019-06-11 Tom Tromey <tromey@adacore.com>
9234
9235 * infcall.c (_initialize_infcall): Remove trailing newline from
9236 help.
9237 * user-regs.c (_initialize_user_regs): Remove trailing newline
9238 from help.
9239 * typeprint.c (_initialize_typeprint): Remove trailing newline
9240 from help.
9241 * reverse.c (_initialize_reverse): Remove trailing newlines from
9242 help.
9243 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9244 from help.
9245 * language.c (add_set_language_command): Remove trailing newline
9246 from help.
9247 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9248 help.
9249 * disasm.c (_initialize_disasm): Remove trailing newline from
9250 help.
9251 * top.c (init_main): Remove trailing newline from help.
9252 * interps.c (_initialize_interpreter): Remove trailing newline
9253 from help.
9254 * btrace.c (_initialize_btrace): Remove trailing newlines from
9255 help.
9256 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9257 from help.
9258 * python/python.c (_initialize_python): Remove trailing newline
9259 from help.
9260 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9261 help.
9262 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9263 from help. Reformat some text.
9264 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9265 from help.
9266 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9267 newline from help.
9268
92692019-06-11 Tom Tromey <tromey@adacore.com>
9270
9271 * darwin-nat.c (darwin_decode_exception_message)
9272 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9273
92742019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9275
9276 * valops.c (value_slice): Check for not allocated or not
9277 associated values.
9278
92792019-06-10 Tom de Vries <tdevries@suse.de>
9280
9281 PR gdb/24618
9282 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9283 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9284 invalid.
9285
92862019-06-10 Tom de Vries <tdevries@suse.de>
9287
9288 PR gdb/24611
9289 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9290 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9291
92922019-06-10 Tom de Vries <tdevries@suse.de>
9293
9294 PR symtab/24545
9295 * symtab.c (struct demangled_name_entry): Add language field.
9296 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9297 static minimal symbol". Set and use language field.
9298
92992019-06-10 Tom Tromey <tromey@adacore.com>
9300
9301 * ada-lang.c (_initialize_ada_language): Update help text.
9302
93032019-06-10 Tom Tromey <tromey@adacore.com>
9304
9305 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9306 with a newline.
9307 * guile/guile.c (handle_boot_error): Don't end warning with a
9308 newline.
9309 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9310 warning with a newline.
9311 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9312 newline.
9313 (s12z_frame_cache): Likewise.
9314 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9315 a newline.
9316 * solib-svr4.c (disable_probes_interface): Don't end warning with
9317 a newline.
9318 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9319 newline.
9320 * python/python.c (do_finish_initialization): Don't end warning
9321 with a newline.
9322
93232019-06-10 Tom Tromey <tom@tromey.com>
9324
9325 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9326 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9327 gdbpy_enter.
9328
93292019-06-10 Tom Tromey <tromey@adacore.com>
9330
9331 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9332 data.
9333 (elf_new_init): Don't call stabsread_new_init.
9334 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9335 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9336 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9337
93382019-06-10 Tom de Vries <tdevries@suse.de>
9339
9340 PR symtab/16264
9341 PR symtab/24517
9342 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9343
93442019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9345
9346 * source.c (find_and_open_source): Also rewrite relative file
9347 names.
9348
93492019-04-26 Amos Bird <amosbird@gmail.com>
9350
9351 * annotate.c (annotate_thread_exited): Add "thread-exited"
9352 annotation.
9353
93542019-06-06 Tom Tromey <tromey@adacore.com>
9355
9356 * maint.h (class scoped_command_stats): Use
9357 DISABLE_COPY_AND_ASSIGN.
9358 <print_time>: New method.
9359 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9360 print_time.
9361 (scoped_command_stats::print_time): New method.
9362
93632019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9364
9365 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9366 instructions of lengths 6 or 8 bytes.
9367
93682019-06-04 Pedro Alves <palves@redhat.com>
9369
9370 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9371
9372 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9373 * breakpoint.c (condition_completer): Likewise.
9374 * cli/cli-dump.c (scan_expression): Likewise.
9375 * common/filestuff.c (mkdir_recursive): Likewise.
9376 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9377 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9378 (gdb_abspath): Likewise.
9379 * compile/compile-cplus-types.c
9380 (compile_cplus_instance::decl_name): Likewise.
9381 * completer.c (complete_explicit_location):
9382 (signal_completer, reg_or_group_completer_1): Likewise.
9383 * cp-support.c (cp_remove_params_if_any): Likewise.
9384 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9385 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9386 * infcmd.c (strip_bg_char): Likewise.
9387 * linespec.c (copy_token_string): Likewise.
9388 * mi/mi-main.c (output_cores): Likewise.
9389 * psymtab.c (psymtab_search_name):
9390 * symfile.c (test_set_ext_lang_command): Likewise.
9391 * target.c (target_fileio_read_stralloc): Likewise.
9392 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9393 * value.c (complete_internalvar): Likewise.
9394
93952019-06-04 Christian Biesinger <cbiesinger@google.com>
9396
9397 Add objfile property to gdb.Type.
9398 * NEWS: Mention Python API addition.
9399 * python/py-type.c (typy_get_objfile): New method.
9400
94012019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9402
9403 * NEWS: Mention the new set|show style [title|highlight].
9404 Mention changes to "show style", "help" and "apropos".
9405
94062019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9407
9408 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9409 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9410 instead of print_help_for_command.
9411 (print_doc_of_command): New function.
9412 (help_list): Add 'apropos -v word' suggestion.
9413 (print_help_for_command): Style the command name using title style.
9414 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9415 (_initialize_cli_cmds): Describe -v in apropos_command help.
9416
94172019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9418
9419 * cli/cli-style.h (cli_style_option): Add name in constructor,
9420 add m_name class member, add constructor with intensity,
9421 add name class function.
9422 (cli_style_option::add_setshow_commands): Remove name argument.
9423 (highlight_style, title_style): New styles.
9424 * cli/cli-style.c (do_show): New function that shows a style
9425 characteristic styling the style name with itself.
9426 (set_style_name): New function.
9427 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9428 Update all callers according to the changes in cli/cli-style.h.
9429 * utils.h (fputs_highlighted): New function.
9430 * utils.c (fputs_highlighted): Likewise.
9431
94322019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9433
9434 * NEWS: Mention new pipe command and new convenience variables.
9435
94362019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9437
9438 * cli/cli-cmds.c (pipe_command): New function.
9439 (_initialize_cli_cmds): Call add_com for pipe_command.
9440 Define | as an alias for pipe.
9441 (exit_status_set_internal_vars): New function.
9442 (shell_escape): Call exit_status_set_internal_vars.
9443 cli/cli-decode.c (find_command_name_length): Recognize | as
9444 a single character command.
9445
94462019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9447
9448 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9449 top.c (execute_command_to_ui_file): New function, mostly a copy
9450 of execute_command_to_string.
9451 (execute_command_to_string): Implement by calling
9452 execute_command_to_ui_file.
9453
94542019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9455
9456 * top.h (saved_command_line): Remove declaration.
9457 * top.c (previous_saved_command_line, previous_repeat_arguments):
9458 New variables.
9459 (saved_command_line): Make static, define together with other
9460 'repeat variables'.
9461 (dont_repeat): Clear repeat_arguments.
9462 (repeat_previous, get_saved_command_line, save_command_line):
9463 New functions.
9464 (gdb_init): Initialize saved_command_line
9465 and previous_saved_command_line.
9466 * main.c (captured_main_1): Remove saved_command_line initialization.
9467 * event-top.c (handle_line_of_input): Update to use
9468 the new 'repeat' related functions instead of direct access to
9469 saved_command_line.
9470 * command.h (repeat_previous, get_saved_command_line,
9471 save_command_line): New declarations.
9472 (dont_repeat): Add comment.
9473
94742019-05-30 Tom Tromey <tromey@adacore.com>
9475
9476 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9477 Fix comment.
9478 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9479
94802019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9481
9482 PR cli/24587
9483 * completer.c (complete): Initialize variable word.
9484
94852019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9486
9487 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9488 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9489 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9490 'body' is NULL to the outter 'if', protecting the '!is_define'
9491 situation as well.
9492
94932019-05-29 Tom Tromey <tromey@adacore.com>
9494
9495 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9496 (dwarf_unknown): New function.
9497 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9498 (dwarf_type_encoding_name): Use dwarf_unknown.
9499
95002019-05-29 Tom Tromey <tromey@adacore.com>
9501
9502 PR c++/20020:
9503 * cp-valprint.c (cp_print_value_fields): Call
9504 cp_print_static_field inside "try".
9505
95062019-05-29 Tom Tromey <tromey@adacore.com>
9507
9508 * inflow.c (struct terminal_info): Add default operator=.
9509 * configure: Rebuild.
9510 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9511 -Wdeprecated-copy-dtor, -Wredundant-move.
9512
95132019-05-29 Tom Tromey <tromey@adacore.com>
9514
9515 * NEWS: Add entry.
9516 * infcmd.c (print_return_value_1): Handle finish_print
9517 option.
9518 (show_print_finish): New function.
9519 (_initialize_infcmd): Add "set/show print finish" commands.
9520 * valprint.c (user_print_options): Initialize new member.
9521 * valprint.h (struct value_print_options) <finish_print>: New
9522 member.
9523
95242019-05-28 Tom Tromey <tromey@adacore.com>
9525
9526 * ada-lang.c (ada_remove_Xbn_suffix)
9527 (find_old_style_renaming_symbol)
9528 (parse_old_style_renaming): Remove.
9529 (ada_find_renaming_symbol): Don't call
9530 find_old_style_renaming_symbol.
9531 (ada_is_renaming_symbol): Rename from
9532 ada_find_renaming_symbol. Remove "block" parameter. Return
9533 bool. Now static.
9534 (ada_read_var_value): Update and simplify.
9535 * ada-exp.y (write_var_or_type): Remove old code.
9536
95372019-05-28 Alan Hayward <alan.hayward@arm.com>
9538
9539 PR gdb/25010
9540 * event-top.c: Remove include comment.
9541 * inflow.c (class scoped_ignore_sigttou): Move from here...
9542 * inflow.h (class scoped_ignore_sigttou): ...to here.
9543 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9544 * top.c: Remove include comment.
9545
95462019-05-27 Tom Tromey <tom@tromey.com>
9547
9548 * NEWS: Fix typo.
9549
95502019-05-22 Tom Tromey <tromey@adacore.com>
9551
9552 * target.c (target_follow_exec): Constify parameter.
9553 * target-delegates.c: Rebuild.
9554 * remote.c (remote_target::follow_exec): Constify parameter.
9555 * infrun.c (follow_exec): Constify parameter.
9556 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9557 (target_follow_exec): Likewise.
9558
95592019-05-22 Alan Hayward <alan.hayward@arm.com>
9560
9561 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9562 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9563
95642019-05-22 Alan Hayward <alan.hayward@arm.com>
9565
9566 * NEWS: Add debugredirect and testsuite sections.
9567
95682019-05-22 Simon Cook <simon.cook@embecosm.com>
9569
9570 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9571 target descriptions using exclusively floating point register name
9572 aliases.
9573
95742019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9575
9576 PR gdb/18644:
9577 * f-lang.c (build_fortran_types): Handle the case where
9578 gdbarch_floatformat_for_type returns a nullptr.
9579
95802019-05-21 Tom de Vries <tdevries@suse.de>
9581
9582 PR cli/24587
9583 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9584
95852019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9586
9587 PR gdb/18644:
9588 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9589 16-byte floats.
9590 * i386-tdep.c (i386_floatformat_for_type): Use
9591 floatformats_ia64_quad for the 16-byte floating point component
9592 within a fortran 32-byte complex number.
9593
95942019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9595
9596 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9597 delete default constructor.
9598 (find_partial_die): Update to return const struct.
9599 (partial_die_parent_scope): Move variable declaration into scope
9600 of its use and change its type to auto.
9601 (guess_partial_die_structure_name): Likewise.
9602 (partial_die_info::fixup): Likewise.
9603
96042019-05-17 Tom Tromey <tromey@adacore.com>
9605
9606 * source.c (find_and_open_source): Remove cast.
9607
96082019-05-17 Tom Tromey <tromey@adacore.com>
9609
9610 * annotate.c (annotate_source): Make "filename" const.
9611 * annotate.h (annotate_source): Use const.
9612
96132019-05-17 Alan Hayward <alan.hayward@arm.com>
9614
9615 * disasm.c (set_disassembler_options): Send errors to stderr.
9616
96172019-05-17 Alan Hayward <alan.hayward@arm.com>
9618
9619 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9620 (cli_interp_base::set_logging): Check debug_redirect.
9621 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9622 * cli/cli-logging.c (debug_redirect): Add static variable.
9623 (pop_output_files): Add default param.
9624 (handle_redirections): Print debug setting.
9625 (show_logging_command): Likewise.
9626 (_initialize_cli_logging): Add debugredirect command.
9627 * interps.c (current_interp_set_logging): Add debug_redirect
9628 parameter.
9629 * interps.h (set_logging): Add debug_redirect parameter.
9630 (current_interp_set_logging): Likewise.
9631 * mi/mi-common.h: Likewise.
9632 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9633
96342019-05-17 Alan Hayward <alan.hayward@arm.com>
9635 Tom Tromey <tromey@adacore.com>
9636
9637 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9638 directly.
9639 * cli/cli-interp.h (make_logging_output): Remove declaration.
9640 * cli/cli-logging.c (make_logging_output): Remove function.
9641 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9642 directly.
9643 * ui-file.c (tee_file::tee_file): Remove bools.
9644 (tee_file::~tee_file): Remove deletes.
9645 * ui-file.h (tee_file): Remove bools.
9646
96472019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9648
9649 * mi/mi-cmds.h (mi_cmd_complete): New function.
9650 * mi/mi-main.c (mi_cmd_complete): Likewise.
9651 * mi/mi-cmds.c: Define new MI command -complete.
9652 * NEWS: Mention new -complete command.
9653
96542019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9655
9656 * completer.h (complete): New function.
9657 * completer.c (complete): Likewise.
9658 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9659 function defined in completer.h.
9660
96612019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9662
9663 * MAINTAINERS (Write After Approval): Add myself.
9664
96652019-05-17 Tom de Vries <tdevries@suse.de>
9666
9667 PR gdb/24094
9668 * dwarf2read.c (struct cu_partial_die_info): New struct.
9669 (find_partial_die): Return cu_partial_die_info.
9670 (partial_die_parent_scope, guess_partial_die_structure_name)
9671 (partial_die_info::fixup): Handle new return type of find_partial_die.
9672
96732019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9674
9675 PR breakpoints/24541
9676 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9677 "std::string", simplifying the algorithm.
9678
96792019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9680
9681 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9682 (stap_static_probe_ops::get_probes): Likewise.
9683
96842019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9685
9686 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9687 '-')" and "else if".
9688 (stap_parse_single_operand): Join checks for
9689 "gdbarch_stap_parse_special_token_p" and
9690 "gdbarch_stap_parse_special_token" in the same "if" statement.
9691 Invert check when verifying for operation on register
9692 displacement.
9693
96942019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9695
9696 * stap-probe.c (stap_get_opcode): Update comment.
9697 (stap_get_expected_argument_type): Likewise.
9698 (handle_stap_probe): Likewise.
9699
97002019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9701
9702 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9703 return type to 'bool'. Adjust comment. Use 'bool' when
9704 appropriate.
9705 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9706 * stap-probe.c (stap_parse_argument_1): Likewise.
9707 (stap_is_operator): Likewise.
9708 (stap_is_generic_prefix): Likewise.
9709 (stap_is_register_prefix): Likewise.
9710 (stap_is_register_indirection_prefix): Likewise.
9711 (stap_is_integer_prefix): Likewise.
9712 (stap_generic_check_suffix): Likewise.
9713 (stap_check_integer_suffix): Likewise.
9714 (stap_check_register_suffix): Likewise.
9715 (stap_check_register_indirection_suffix): Likewise.
9716 (stap_parse_register_operand): Likewise.
9717 (stap_parse_single_operand): Likewise.
9718 (stap_parse_argument_1): Likewise.
9719 (stap_probe::get_argument_count): Likewise.
9720 (stap_is_operator): Likewise.
9721
97222019-05-16 Tom Tromey <tromey@adacore.com>
9723
9724 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9725 keyword to foreach.
9726
97272019-05-15 Simon Marchi <simon.marchi@efficios.com>
9728
9729 * linux-thread-db.c (try_thread_db_load_1): Change return type
9730 to bool.
9731 (try_thread_db_load): Likewise.
9732 (try_thread_db_load_from_pdir_1): Likewise.
9733 (try_thread_db_load_from_pdir): Likewise.
9734 (try_thread_db_load_from_sdir): Likewise.
9735 (try_thread_db_load_from_dir): Likewise.
9736 (thread_db_load_search): Likewise.
9737 (has_libpthread): Likewise.
9738 (thread_db_load): Likewise.
9739
97402019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9741
9742 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9743 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9744 NULL, and complain/return if that's the case.
9745
97462019-05-15 John Darrington <john@darrington.wattle.id.au>
9747
9748 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9749 (advance, posn, abstract_read_memory): New functions.
9750 [struct mem_read_abstraction]: New struct.
9751 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9752
97532019-05-14 Tom Tromey <tromey@adacore.com>
9754
9755 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9756 value is not lval_memory.
9757
97582019-05-14 Tom Tromey <tromey@adacore.com>
9759
9760 * solib.c (info_sharedlibrary_command): Style the file name.
9761
97622019-05-14 Alan Hayward <alan.hayward@arm.com>
9763
9764 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9765 (aarch64_vnv_type): Likewise.
9766 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9767 * common/tdesc.c: Likewise.
9768 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9769 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9770 * features/aarch64-fpu.xml: Add ieee half view.
9771 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9772 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9773 * gdbtypes.h (struct builtin_type): Likewise.
9774 (struct objfile_type): Likewise.
9775
97762019-05-12 Paul Naert <paul.naert@polymtl.ca>
9777
9778 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9779 typo.
9780 * location.h (string_to_event_location): Likewise.
9781
97822019-05-11 Joel Brobecker <brobecker@adacore.com>
9783
9784 GDB 8.3 released.
9785
97862019-05-10 Simon Marchi <simon.marchi@efficios.com>
9787
9788 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9789 New variable declaration.
9790 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9791 New variable.
9792 (print_one_breakpoint): Use ui_out::test_flags and new global
9793 variable to compute use_fixed_output.
9794 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9795 Remove.
9796 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9797 (mi_multi_location_breakpoint_output_fixed): Remove.
9798 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9799 new variable.
9800 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9801 fix_multi_location_breakpoint_output flag if version >= 3.
9802 * ui-out.h (enum ui_out_flag)
9803 <fix_multi_location_breakpoint_output>: New enumerator.
9804
98052019-05-10 Simon Marchi <simon.marchi@efficios.com>
9806
9807 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9808
98092019-05-10 Tom Tromey <tromey@adacore.com>
9810
9811 * ada-lang.c (catch_ada_completer): New function.
9812 (_initialize_ada_language): Use it.
9813
98142019-05-10 Tom Tromey <tromey@adacore.com>
9815
9816 * thread.c (print_thread_info): Make "requested_threads" const.
9817 * gdbthread.h (print_thread_info): Make "requested_threads"
9818 const.
9819 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9820 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9821
98222019-05-08 Tom Tromey <tom@tromey.com>
9823
9824 * gdbtypes.c (objfile_type_data): Change type.
9825 (objfile_type, _initialize_gdbtypes): Update.
9826
98272019-05-08 Tom Tromey <tom@tromey.com>
9828
9829 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9830 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9831 (_initialize_dwarf2_frame): Update.
9832
98332019-05-08 Tom Tromey <tom@tromey.com>
9834
9835 * objc-lang.c (objc_objfile_data): Change type.
9836 (find_methods): Update.
9837 (_initialize_objc_lang): Remove.
9838
98392019-05-08 Tom Tromey <tom@tromey.com>
9840
9841 * stabsread.c (rs6000_builtin_type_data): Change type.
9842 (rs6000_builtin_type, _initialize_stabsread): Update.
9843
98442019-05-08 Tom Tromey <tom@tromey.com>
9845
9846 * mips-tdep.c (mips_pdr_data): Remove.
9847 (_initialize_mips_tdep): Update.
9848
98492019-05-08 Tom Tromey <tom@tromey.com>
9850
9851 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9852 (hppa_init_objfile_priv_data, read_unwind_info)
9853 (find_unwind_entry, _initialize_hppa_tdep): Update.
9854
98552019-05-08 Tom Tromey <tom@tromey.com>
9856
9857 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9858 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9859 on obstack.
9860 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9861
98622019-05-08 Tom Tromey <tom@tromey.com>
9863
9864 * mdebugread.c (basic_type_data): Change type.
9865 (basic_type, _initialize_mdebugread): Update.
9866
98672019-05-08 Tom Tromey <tom@tromey.com>
9868
9869 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9870
98712019-05-08 Tom Tromey <tom@tromey.com>
9872
9873 * nto-tdep.c (nto_inferior_data_reg): Change type.
9874 (nto_inferior_data): Update.
9875 (nto_inferior_data_cleanup, nto_new_inferior_data)
9876 (_initialize_nto_tdep): Remove.
9877 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9878
98792019-05-08 Tom Tromey <tom@tromey.com>
9880
9881 * ada-lang.c (struct ada_inferior_data): Add initializers.
9882 (ada_inferior_data): Change type.
9883 (ada_inferior_data_cleanup): Remove.
9884 (get_ada_inferior_data, ada_inferior_exit)
9885 (struct ada_pspace_data): Add initializers, destructor.
9886 (ada_pspace_data_handle): Change type.
9887 (get_ada_pspace_data): Update.
9888 (ada_pspace_data_cleanup): Remove.
9889
98902019-05-08 Tom Tromey <tom@tromey.com>
9891
9892 * coffread.c (struct coff_symfile_info): Add initializers.
9893 (coff_objfile_data_key): Move lower. Change type.
9894 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9895 Update.
9896 (coff_free_info): Remove.
9897
98982019-05-08 Tom Tromey <tom@tromey.com>
9899
9900 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9901 (fbsd_pspace_data_handle): Move lower. Change type.
9902 (get_fbsd_pspace_data): Update.
9903 (fbsd_pspace_data_cleanup): Remove.
9904 (_initialize_fbsd_tdep): Update.
9905
99062019-05-08 Tom Tromey <tom@tromey.com>
9907
9908 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9909 (get_ada_tasks_pspace_data): Update.
9910 (ada_tasks_pspace_data_cleanup): Remove.
9911 (_initialize_tasks): Update.
9912 (ada_tasks_inferior_data_handle): Change type.
9913 (get_ada_tasks_inferior_data): Update.
9914 (ada_tasks_inferior_data_cleanup): Remove.
9915 (struct ada_tasks_pspace_data): Add initializers.
9916
99172019-05-08 Tom Tromey <tom@tromey.com>
9918
9919 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9920 * symfile-debug.c (debug_sym_get_probes): Change type.
9921 * stap-probe.c (handle_stap_probe):
9922 (stap_static_probe_ops::get_probes): Change type.
9923 * probe.h (class static_probe_ops) <get_probes>: Change type.
9924 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9925 (parse_probes_in_pspace): Update.
9926 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9927 Update.
9928 (any_static_probe_ops::get_probes): Change type.
9929 * elfread.c (elfread_data): New typedef.
9930 (probe_key): Change type.
9931 (elf_get_probes): Likewise. Update.
9932 (probe_key_free): Remove.
9933 (_initialize_elfread): Update.
9934 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9935 Change type.
9936 (dtrace_process_dof_probe, dtrace_process_dof)
9937 (dtrace_static_probe_ops::get_probe): Change type.
9938
99392019-05-08 Tom Tromey <tom@tromey.com>
9940
9941 * xcoffread.c (struct xcoff_symfile_info): Rename from
9942 coff_symfile_info. Add initializers.
9943 (xcoff_objfile_data_key): Move lower. Change type.
9944 (XCOFF_DATA): Rewrite.
9945 (xcoff_free_info): Remove.
9946 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9947 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9948 (xcoff_initial_scan): Update.
9949
99502019-05-08 Tom Tromey <tom@tromey.com>
9951
9952 * solib-svr4.c (struct svr4_info): Add initializers and
9953 destructor.
9954 <probes_table>: Now an htab_up.
9955 (solib_svr4_pspace_data): Change type.
9956 (free_probes_table): Simplify.
9957 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9958 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9959 (probes_table_remove_objfile_probes, register_solib_event_probe)
9960 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9961 (_initialize_svr4_solib): Update.
9962
99632019-05-08 Tom Tromey <tom@tromey.com>
9964
9965 * remote.c (remote_pspace_data): Change type.
9966 (remote_pspace_data_cleanup): Remove.
9967 (get_remote_exec_file, set_pspace_remote_exec_file)
9968 (_initialize_remote): Update.
9969
99702019-05-08 Tom Tromey <tom@tromey.com>
9971
9972 * breakpoint.c (breakpoint_objfile_key): Change type.
9973 (get_breakpoint_objfile_data): Update.
9974 (free_breakpoint_objfile_data): Remove.
9975 (_initialize_breakpoint): Update.
9976
99772019-05-08 Tom Tromey <tom@tromey.com>
9978
9979 * linux-tdep.c (struct linux_info): Add initializers.
9980 (linux_inferior_data): Move. Change type.
9981 (invalidate_linux_cache_inf): Update.
9982 (linux_inferior_data_cleanup): Remove.
9983 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9984
99852019-05-08 Tom Tromey <tom@tromey.com>
9986
9987 * auxv.c (auxv_inferior_data): Move. Change type.
9988 (auxv_inferior_data_cleanup): Remove.
9989 (invalidate_auxv_cache_inf): Rewrite.
9990 (get_auxv_inferior_data, _initialize_auxv): Update.
9991
99922019-05-08 Tom Tromey <tom@tromey.com>
9993
9994 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9995 (symfile_debug_objfile_data_key): Change type.
9996 (symfile_debug_installed, debug_qf_has_symbols)
9997 (debug_qf_find_last_source_symtab)
9998 (debug_qf_forget_cached_source_info)
9999 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10000 (debug_qf_print_stats, debug_qf_dump)
10001 (debug_qf_expand_symtabs_for_function)
10002 (debug_qf_expand_all_symtabs)
10003 (debug_qf_expand_symtabs_with_fullname)
10004 (debug_qf_map_matching_symbols)
10005 (debug_qf_expand_symtabs_matching)
10006 (debug_qf_find_pc_sect_compunit_symtab)
10007 (debug_qf_map_symbol_filenames)
10008 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10009 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10010 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10011 (debug_sym_read_linetable, debug_sym_relocate): Update.
10012 (symfile_debug_free_objfile): Remove.
10013 (install_symfile_debug_logging, _initialize_symfile_debug):
10014 Update.
10015
100162019-05-08 Tom Tromey <tom@tromey.com>
10017
10018 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10019 allocate_on_obstack.
10020 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10021 (get_dwarf2_per_objfile): Update.
10022 (set_dwarf2_per_objfile): Remove.
10023 (dwarf2_has_info, dwarf2_get_section_info): Update.
10024 (dwarf2_free_objfile): Remove.
10025 (_initialize_dwarf2_read): Update.
10026
100272019-05-08 Tom Tromey <tom@tromey.com>
10028
10029 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10030 initializers.
10031 <unsupported_script_warning_printed,
10032 script_not_found_warning_printed>: Now bool.
10033 (auto_load_pspace_data): Change type.
10034 (~auto_load_pspace_info): Rename from
10035 auto_load_pspace_data_cleanup.
10036 (get_auto_load_pspace_data, init_loaded_scripts_info)
10037 (clear_section_scripts, maybe_print_unsupported_script_warning)
10038 (maybe_print_script_not_found_warning, _initialize_auto_load):
10039 Update.
10040
100412019-05-08 Tom Tromey <tom@tromey.com>
10042
10043 * objfiles.c (objfile_pspace_info): Add destructor and
10044 initializers.
10045 (objfiles_pspace_data): Change type.
10046 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10047 (get_objfile_pspace_data): Update.
10048 (objfiles_bfd_data): Change type.
10049 (get_objfile_bfd_data): Update.
10050 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10051
100522019-05-08 Tom Tromey <tom@tromey.com>
10053
10054 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10055 Change type.
10056 (get_catch_syscall_inferior_data): Update.
10057 (catch_syscall_inferior_data_cleanup): Remove.
10058 (_initialize_break_catch_syscall): Update.
10059
100602019-05-08 Tom Tromey <tom@tromey.com>
10061
10062 * inflow.c (struct terminal_info): Add destructor and
10063 initializers.
10064 (inflow_inferior_data): Change type.
10065 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10066 (get_inflow_inferior_data, inflow_inferior_exit)
10067 (swap_terminal_info, _initialize_inflow): Update.
10068
100692019-05-08 Tom Tromey <tom@tromey.com>
10070
10071 * target-dcache.c (target_dcache_cleanup): Remove.
10072 (target_dcache_aspace_key): Change type.
10073 (target_dcache_init_p, target_dcache_invalidate)
10074 (target_dcache_get, target_dcache_get_or_init)
10075 (_initialize_target_dcache): Update.
10076 * dcache.h (struct dcache_deleter): New.
10077
100782019-05-08 Tom Tromey <tom@tromey.com>
10079
10080 * symtab.c (struct symbol_cache): Add destructor and
10081 initializers.
10082 (symbol_cache_key): Move. Change type.
10083 (make_symbol_cache, free_symbol_cache): Remove.
10084 (get_symbol_cache): Update.
10085 (symbol_cache_cleanup): Remove.
10086 (ALL_PSPACES, symbol_cache_flush)
10087 (maintenance_print_symbol_cache)
10088 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10089 Update.
10090
100912019-05-08 Tom Tromey <tom@tromey.com>
10092
10093 * symtab.c (struct main_info): Add destructor and initializers.
10094 (main_progspace_key): Move. Change type.
10095 (get_main_info): Update.
10096 (main_info_cleanup): Remove.
10097 (_initialize_symtab): Update.
10098
100992019-05-08 Tom Tromey <tom@tromey.com>
10100
10101 * registry.h (DECLARE_REGISTRY): Define the _key class.
10102
101032019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10104
10105 * NEWS: Merge two 'New commands' sections.
10106
101072019-05-08 Joel Brobecker <brobecker@adacore.com>
10108
10109 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10110 parameter and use Ada language definition instead.
10111 (ada_val_print_ptr): Remove unused language parameter.
10112 (ada_val_print_num): Remove language parameter and use Ada language
10113 definition instead.
10114 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10115 parameter.
10116 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10117 parameter and use Ada language definition instead.
10118 (ada_val_print_1): Update all ada_val_print_xxx calls.
10119 Remove language parameter.
10120 (ada_val_print): Update ada_val_print_1 call.
10121
101222019-05-08 Tom Tromey <tromey@adacore.com>
10123
10124 * remote.c (remote_hw_watchpoint_limit)
10125 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10126 Now static.
10127
101282019-05-08 Tom Tromey <tromey@adacore.com>
10129
10130 * maint.c (_initialize_maint_cmds): Move initialization code to
10131 remote.c.
10132 (watchdog, show_watchdog): Move to remote.c.
10133 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10134 "watchdog" static.
10135 (_initialize_remote): Move initialization code from maint.c.
10136 * defs.h (watchdog): Don't declare.
10137
101382019-05-08 Tom Tromey <tromey@adacore.com>
10139
10140 * tui/tui-interp.c: Include main.h.
10141 * interps.c: Include main.h.
10142 * main.h (interpreter_p): Declare.
10143 * defs.h (interpreter_p): Don't declare.
10144
101452019-05-08 Tom Tromey <tromey@adacore.com>
10146
10147 * dwarf2loc.c: Include dwarf2read.h.
10148 * defs.h (read_unsigned_leb128): Don't declare.
10149 * dwarf2read.h (read_unsigned_leb128): Declare.
10150
101512019-05-08 Tom Tromey <tromey@adacore.com>
10152
10153 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10154 method.
10155
101562019-05-08 Tom Tromey <tromey@adacore.com>
10157
10158 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10159 when no wrap column is set.
10160
101612019-05-08 Tom Tromey <tromey@adacore.com>
10162
10163 * c-lang.c (c_get_string): Handle non-C-style arrays.
10164
101652019-05-08 Tom Tromey <tromey@adacore.com>
10166
10167 * typeprint.c (print_offset_data::update): Print the bit offset,
10168 not the number of bits remaining.
10169
101702019-05-08 Tom Tromey <tromey@adacore.com>
10171
10172 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10173 padding at end of comment.
10174
101752019-05-08 Tom Tromey <tromey@adacore.com>
10176
10177 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10178 Compare main types.
10179
101802019-05-06 Tom Tromey <tom@tromey.com>
10181
10182 * common/scoped_mmap.c: Include common-defs.h.
10183 * common/scoped_mmap.h: Don't include config.h.
10184
101852019-05-04 Tom Tromey <tom@tromey.com>
10186
10187 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10188 (struct aarch64_call_info): Add initializers.
10189 <si>: Now a std::vector.
10190 (pass_on_stack, aarch64_push_dummy_call): Update.
10191
101922019-05-04 Simon Marchi <simon.marchi@efficios.com>
10193 Tom Tromey <tom@tromey.com>
10194
10195 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10196 (ppc_threads): Now a std::vector. Now static.
10197 (hwdebug_find_thread_points_by_tid)
10198 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10199 Update.
10200
102012019-05-04 Tom Tromey <tom@tromey.com>
10202
10203 * arc-tdep.c (arc_tdesc_init): Return bool.
10204
102052019-05-04 Tom Tromey <tom@tromey.com>
10206
10207 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10208 Use gdb_assert_not_reached.
10209
102102019-05-04 Tom Tromey <tom@tromey.com>
10211
10212 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10213 "false".
10214
102152019-05-04 Tom Tromey <tom@tromey.com>
10216
10217 * arc-tdep.c (arc_tdesc_init): Use bool.
10218
102192019-05-04 Tom Tromey <tom@tromey.com>
10220
10221 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10222
102232019-05-04 Tom Tromey <tom@tromey.com>
10224
10225 * cli/cli-cmds.c (valid_command_p): Return bool.
10226
102272019-05-04 Tom Tromey <tom@tromey.com>
10228
10229 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10230 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10231
102322019-05-04 Raul Tambre <raul@tambre.ee>
10233
10234 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10235 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10236 operator for comparison.
10237
102382019-05-04 Tom Tromey <tom@tromey.com>
10239
10240 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10241 (lookup_partial_symbol, print_partial_symbols)
10242 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10243 (psymbol_compare): Update.
10244 (add_psymbol_to_bcache): Clear the entire psymbol.
10245 (maintenance_check_psymtabs): Update.
10246 * psympriv.h (struct partial_symbol): Don't derive from
10247 general_symbol_info.
10248 <obj_section, unrelocated_address, address,
10249 set_unrelocated_address>: Update.
10250 <ginfo>: New member.
10251 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10252 (debug_names::write_psymbols): Update.
10253
102542019-05-04 Tom de Vries <tdevries@suse.de>
10255
10256 * contrib/cc-with-tweaks.sh: Support -n arg.
10257
102582019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10259
10260 * corelow.c (core_target::detach): Ensure frame cache and
10261 register caches are cleared.
10262 inferior.c (exit_inferior_1): Likewise.
10263
102642019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10265 Tom Tromey <tom@tromey.com>
10266
10267 * dictionary.c (collate_pending_symbols_by_language): Remove
10268 "struct" from foreach.
10269 * symtab.c (lookup_global_symbol_from_objfile)
10270 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10271 foreach.
10272 * ser-tcp.c (net_open): Remove "struct" from foreach.
10273 * objfiles.c (objfile_relocate, objfile_rebase)
10274 (objfile_has_symbols): Remove "struct" from foreach.
10275 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10276 from foreach.
10277 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10278 foreach.
10279 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10280 "struct" from foreach.
10281 * ada-lang.c (create_excep_cond_exprs)
10282 (ada_exception_catchpoint_cond_string): Remove "struct" from
10283 foreach.
10284
102852019-05-03 Tom Tromey <tromey@adacore.com>
10286
10287 * ada-exp.y (convert_char_literal): Check suffix of each
10288 enumerator.
10289
102902019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10291
10292 PR ada/21406:
10293 * ada-exp.y (yywrap): Don't define.
10294 * ada-lex.l (%option): Add noyywrap
10295 (yywrap): Remove.
10296
102972019-05-03 Eli Zaretskii <eliz@gnu.org>
10298
10299 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10300 _WIN32_WINNT to the XP level, unless already defined to a higher
10301 level.
10302
10303 * unittests/parse-connection-spec-selftests.c:
10304 * ser-tcp.c:
10305 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10306 override.
10307
10308 * symfile.c (find_separate_debug_file): Remove colon from the
10309 drive spec of DOS/Windows file names of the target, so that the
10310 file name produced from DEBUGDIR and the target's directory will
10311 be valid on DOS/Windows systems.
10312
103132019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10314
10315 * rust-lang.c (val_print_struct): Handle printing structures
10316 containing strings.
10317
103182019-05-02 Tom Tromey <tromey@adacore.com>
10319
10320 * valarith.c (_initialize_valarith): Remove.
10321
103222019-05-01 Tom Tromey <tromey@adacore.com>
10323
10324 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10325 bitfields.
10326
103272019-05-01 Tom Tromey <tromey@adacore.com>
10328
10329 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10330 for big-endian copies.
10331
103322019-04-30 Ali Tamur <tamur@google.com>
10333 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10334 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10335 (read_3_bytes): New function.
10336
103372019-04-30 Joel Brobecker <brobecker@adacore.com>
10338
10339 * windows-nat.c (main_thread_id): Delete.
10340 (handle_output_debug_string): Replace main_thread_id by
10341 current_event.dwThreadId.
10342 (fake_create_process): Likewise.
10343 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10344 Do not set main_thread_id.
10345 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10346 current_event.dwThreadId.
10347 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10348
103492019-04-30 Joel Brobecker <brobecker@adacore.com>
10350
10351 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10352 Use current_event.dwThreadId instead of main_thread_id.
10353
103542019-04-30 Tom Tromey <tromey@adacore.com>
10355
10356 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10357 (create_excep_cond_exprs): Iterate over program spaces.
10358 (ada_exception_catchpoint_cond_string): Examine all minimal
10359 symbols for exception types.
10360
103612019-04-30 Tom Tromey <tromey@adacore.com>
10362
10363 PR c++/24470:
10364 * dwarf2read.c (process_structure_scope): Handle case where type
10365 has template parameters but no symbol was created.
10366
103672019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10368 Chris January <chris.january@arm.com>
10369
10370 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10371 qualifier.
10372 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10373
103742019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10375
10376 * f-typeprint.c (f_print_type): Update rules for printing
10377 whitespace.
10378 (f_type_print_varspec_suffix): Likewise.
10379
103802019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10381 Chris January <chris.january@arm.com>
10382
10383 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10384 function arguments.
10385
103862019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10387
10388 * f-lang.c (build_fortran_types): Change name of void type to
10389 lower case.
10390 * f-typeprint.c (f_type_print_base): Print the name of the void
10391 type, rather than a fixed string.
10392 * f-valprint.c (f_decorations): Use lower case void string.
10393
103942019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10395 Chris January <chris.january@arm.com>
10396
10397 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10398 types for Fortran.
10399
104002019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10401 Chris January <chris.january@arm.com>
10402 David Lecomber <david.lecomber@arm.com>
10403
10404 * f-exp.y (BINOP_INTRINSIC): New token.
10405 (exp): New parser rule handling BINOP_INTRINSIC.
10406 (f77_keywords): Add new builtin procedures.
10407 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10408 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10409 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10410 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10411 (print_unop_subexp_f): New function.
10412 (print_binop_subexp_f): New function.
10413 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10414 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10415 (dump_subexp_body_f): Likewise.
10416 (operator_check_f): Likewise.
10417 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10418 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10419
104202019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10421
10422 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10423 UNOP_KIND.
10424 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10425 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10426 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10427 (operator_length_f): New fuction.
10428 (print_subexp_f): New function.
10429 (op_name_f): New function.
10430 (dump_subexp_body_f): New function.
10431 (operator_check_f): New function.
10432 (exp_descriptor_f): Replace standard expression handling functions
10433 with new functions.
10434 * gdb/fortran-operator.def: New file.
10435 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10436 * gdb/std-operator.def: Remove UNOP_KIND.
10437
104382019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10439
10440 * std-operator.def: Remove unbalanced, stray double quote
10441 character.
10442
104432019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10444 Chris January <chris.january@arm.com>
10445 Daniel Everett <daniel.everett@arm.com>
10446 Nick Forrington <nick.forrington@arm.com>
10447 Richard Bunt <richard.bunt@arm.com>
10448
10449 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10450 of depth when printing anonymous structs or unions.
10451 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10452 Don't print either the top-level value, or the children if the
10453 max-depth is exceeded.
10454 (ppscm_print_children): When printing the key of a map, allow one
10455 extra level of depth.
10456 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10457 print either the top-level value, or the children if the max-depth
10458 is exceeded.
10459 (print_children): When printing the key of a map, allow one extra
10460 level of depth.
10461 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10462 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10463 (user_print_options): Initialise max_depth field.
10464 (val_print_scalar_or_string_type_p): New function.
10465 (val_print): Check to see if the max depth has been reached.
10466 (val_print_check_max_depth): Define new function.
10467 (show_print_max_depth): New function.
10468 (_initialize_valprint): Add 'print max-depth' option.
10469 * valprint.h (struct value_print_options) <max_depth>: New field.
10470 (val_print_check_max_depth): Declare new function.
10471 * NEWS: Document new feature.
10472
104732019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10474
10475 * ada-lang.c (ada_language_defn): Initialise new field.
10476 * c-lang.c (c_is_string_type_p): New function.
10477 (c_language_defn): Initialise new field.
10478 (cplus_language_defn): Initialise new field.
10479 (asm_language_defn): Initialise new field.
10480 (minimal_language_defn): Initialise new field.
10481 * c-lang.h (c_is_string_type_p): Declare new function.
10482 * d-lang.c (d_language_defn): Initialise new field.
10483 * f-lang.c (f_is_string_type_p): New function.
10484 (f_language_defn): Initialise new field.
10485 * go-lang.c (go_is_string_type_p): New function.
10486 (go_language_defn): Initialise new field.
10487 * language.c (default_is_string_type_p): New function.
10488 (unknown_language_defn): Initialise new field.
10489 (auto_language_defn): Initialise new field.
10490 * language.h (struct language_defn) <la_is_string_type_p>: New
10491 member variable.
10492 (default_is_string_type_p): Declare new function.
10493 * m2-lang.c (m2_language_defn): Initialise new field.
10494 * objc-lang.c (objc_language_defn): Initialise new field.
10495 * opencl-lang.c (opencl_language_defn): Initialise new field.
10496 * p-lang.c (pascal_is_string_type_p): New function.
10497 (pascal_language_defn): Initialise new field.
10498 * rust-lang.c (rust_is_string_type_p): New function.
10499 (rust_language_defn): Initialise new field.
10500
105012019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10502
10503 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10504 New field.
10505 * ada-lang.c (ada_language_defn): Initialise new field.
10506 * c-lang.c (c_language_defn): Likewise.
10507 (cplus_language_defn): Likewise.
10508 (asm_language_defn): Likewise.
10509 (minimal_language_defn): Likewise.
10510 * d-lang.c (d_language_defn): Likewise.
10511 * f-lang.c (f_language_defn): Likewise.
10512 * go-lang.c (go_language_defn): Likewise.
10513 * language.c (unknown_language_defn): Likewise.
10514 (auto_language_defn): Likewise.
10515 * m2-lang.c (m2_language_defn): Likewise.
10516 * objc-lang.c (objc_language_defn): Likewise.
10517 * opencl-lang.c (opencl_language_defn): Likewise.
10518 * p-lang.c (pascal_language_defn): Likewise.
10519 * rust-lang.c (rust_language_defn): Likewise.
10520
105212019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10522
10523 * ada-lang.c (ada_is_character_type): Change return type to bool.
10524 (ada_is_string_type): Likewise.
10525 * ada-lang.h (ada_is_character_type): Update declaration
10526 (ada_is_string_type): Likewise.
10527
105282019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10529
10530 Support style in 'frame|thread apply'
10531
10532 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10533 * record.c (record_start, record_stop): Update callers of
10534 execute_command_to_string with false.
10535 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10536 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10537 methods.
10538 (class string_file): New constructor with term_out parameter.
10539 Override methods term_out and can_emit_style_escape. New member
10540 term_out.
10541 (class stdio_file): Override can_emit_style_escape.
10542 (class tee_file): Override term_out and can_emit_style_escape.
10543 * utils.h (can_emit_style_escape): Remove.
10544 * utils.c (can_emit_style_escape): Likewise.
10545 Update all callers of can_emit_style_escape (SOMESTREAM) to
10546 SOMESTREAM->can_emit_style_escape.
10547 * source-cache.c (source_cache::get_source_lines): Likewise.
10548 * stack.c (frame_apply_command_count): Call execute_command_to_string
10549 passing the term_out characteristic of the current gdb_stdout.
10550 * thread.c (thr_try_catch_cmd): Likewise.
10551 * top.c (execute_command_to_string): pass term_out parameter
10552 to construct the string_file for the command output.
10553 * ui-file.c (term_cli_styling): New function (most code moved
10554 from utils.c can_emit_style_escape).
10555 (string_file::string_file, string_file::can_emit_style_escape,
10556 stdio_file::can_emit_style_escape, tee_file::term_out,
10557 tee_file::can_emit_style_escape): New functions.
10558
105592019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10560
10561 * NEWS: Mention the new set|show may-call-functions.
10562 * infcall.c (may_call_functions_p): New variable.
10563 (show_may_call_functions_p): New function.
10564 (call_function_by_hand_dummy): Throws an error if not
10565 may-call-functions.
10566 (_initialize_infcall): Call add_setshow_boolean_cmd for
10567 may-call-functions.
10568
105692019-04-25 Keith Seitz <keiths@redhat.com>
10570
10571 PR c++/24367
10572 * cp-support.c (inspect_type): Don't attempt substitutions
10573 of symbol with the same name.
10574
105752019-04-25 Tom Tromey <tromey@adacore.com>
10576
10577 PR gdb/24475:
10578 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10579 static.
10580
105812019-04-25 Tom Tromey <tromey@adacore.com>
10582
10583 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10584 rvalue reference.
10585 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10586 (gdb_xml_parser::parse): Use std::move.
10587 * python/python-internal.h (gdbpy_convert_exception): Take a const
10588 reference.
10589 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10590 std::move.
10591 * python/py-utils.c (gdbpy_convert_exception): Take a const
10592 reference.
10593 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10594 Use std::move.
10595 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10596 Use std::move.
10597 * mi/mi-main.c (mi_print_exception): Take a const reference.
10598 * main.c (handle_command_errors): Take a const reference.
10599 * linespec.c (parse_linespec): Use std::move.
10600 * infcall.c (run_inferior_call): Use std::move.
10601 (call_function_by_hand_dummy): Use std::move.
10602 * exec.c (try_open_exec_file): Use std::move.
10603 * exceptions.h (exception_print, exception_fprintf)
10604 (exception_print_same): Update.
10605 * exceptions.c (print_exception, exception_print)
10606 (exception_fprintf, exception_print_same): Change parameters to
10607 const reference.
10608 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10609 * common/new-op.c: Use std::move.
10610 * common/common-exceptions.h (struct gdb_exception): Add move
10611 constructor.
10612 (struct gdb_exception_error, struct gdb_exception_quit, struct
10613 gdb_quit_bad_alloc): Change constructor to move constructor.
10614 (throw_exception): Change parameter to rvalue reference.
10615 * common/common-exceptions.c (throw_exception): Take rvalue
10616 reference.
10617 * cli/cli-interp.c (safe_execute_command): Use std::move.
10618 * breakpoint.c (insert_bp_location, location_to_sals): Use
10619 std::move.
10620
106212019-04-25 Tom Tromey <tromey@adacore.com>
10622
10623 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10624 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10625 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10626 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10627 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10628 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10629 guile/scm-value.c: Use unpack.
10630 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10631 gdbscm_gdb_exception.
10632 (gdbscm_throw_gdb_exception): Likewise.
10633 (struct gdbscm_gdb_exception): New.
10634 (unpack): New function.
10635 (gdbscm_wrap): Use unpack.
10636
106372019-04-25 Tom Tromey <tromey@adacore.com>
10638
10639 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10640 (gdb_rl_callback_handler): Use std::move.
10641 * common/common-exceptions.h (struct gdb_exception): Add move
10642 assignment operator.
10643 (throw_exception_sjlj): Change "exception" to const reference.
10644 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10645 (throw_exception_sjlj): Change "exception" to const reference.
10646
106472019-04-25 Tom Tromey <tromey@adacore.com>
10648
10649 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10650 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10651 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10652 Update.
10653 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10654 Update.
10655 * mi/mi-interp.c (mi_interp::exec): Update.
10656 * linespec.c (parse_linespec): Update.
10657 * infcall.c (run_inferior_call): Update.
10658 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10659 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10660 (gdbscm_lookup_global_symbol): Update.
10661 * guile/scm-param.c (gdbscm_parameter_value): Update.
10662 * guile/scm-frame.c (gdbscm_frame_read_register)
10663 (gdbscm_frame_read_var): Update.
10664 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10665 * exec.c (try_open_exec_file): Update.
10666 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10667 (gdb_rl_callback_handler): Update.
10668 * common/common-exceptions.h (exception_none): Don't declare.
10669 * common/common-exceptions.c (exception_none): Don't define.
10670 (struct catcher) <exception>: Update.
10671 * cli/cli-interp.c (safe_execute_command): Update.
10672 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10673
106742019-04-25 Ali Tamur <tamur@google.com>
10675
10676 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10677 (read_attribute_value): Likewise.
10678 (dwarf2_read_addr_index): Update comment.
10679 (read_str_index): Add DW_FORM_strx.
10680 (dwarf2_string_attr): Likewise.
10681 (dwarf2_const_value_attr): Likewise.
10682 (dump_die_shallow): Likewise.
10683 (dwarf2_fetch_constant_bytes): Likewise.
10684 (skip_form_bytes): Likewise.
10685 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10686
106872019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10688
10689 PR corefiles/11608
10690 PR corefiles/18187
10691 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10692 OFFSET. Verify if current mapping contains an ELF header.
10693 (linux_find_memory_regions_full): Adjust call to
10694 dump_mapping_p.
10695
106962019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10697 Kang Li <kanglictf@gmail.com>
10698
10699 PR gdb/21600
10700
10701 * dwarf2-frame.c (read_initial_length): Be consistent about using
10702 unsigned representation of length.
10703 (decode_frame_entry_1): Likewise. Check for wraparound of
10704 end pointer as well as buffer overflow.
10705
107062019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10707
10708 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10709 "vq".
10710
107112019-04-24 Tom Tromey <tromey@adacore.com>
10712
10713 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10714
107152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10716
10717 * s12z-tdep.c (s12z_unwind_pc): Delete.
10718 (s12z_unwind_sp): Delete.
10719 (s12z_gdbarch_init): Don't register deleted functions with
10720 gdbarch.
10721
107222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10723
10724 * rl78-tdep.c (rl78_unwind_sp): Delete.
10725 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10726
107272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10728
10729 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10730 (xstormy16_unwind_pc): Delete.
10731 (xstormy16_dummy_id): Delete.
10732 (xstormy16_gdbarch_init): Don't register deleted functions with
10733 gdbarch.
10734
107352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10736
10737 * vax-tdep.c (vax_unwind_pc): Delete.
10738 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10739
107402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10741
10742 * v850-tdep.c (v850_unwind_sp): Delete.
10743 (v850_unwind_pc): Delete.
10744 (v850_dummy_id): Delete.
10745 (v850_gdbarch_init): Don't register deleted functions with
10746 gdbarch.
10747
107482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10749
10750 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10751 (tilegx_unwind_pc): Delete.
10752 (tilegx_unwind_dummy_id): Delete.
10753 (tilegx_gdbarch_init): Don't register deleted functions with
10754 gdbarch.
10755
107562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10757
10758 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10759 (tic6x_dummy_id): Delete.
10760 (tic6x_gdbarch_init): Don't register deleted functions with
10761 gdbarch.
10762
107632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10764
10765 * sparc-tdep.c (sparc_unwind_pc): Delete.
10766 (sparc32_gdbarch_init): Don't register deleted function with
10767 gdbarch.
10768
107692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10770
10771 * sh-tdep.c (sh_unwind_sp): Delete.
10772 (sh_unwind_pc): Delete.
10773 (sh_dummy_id): Delete.
10774 (sh_gdbarch_init): Don't register deleted functions with
10775 gdbarch.
10776
107772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10778
10779 * score-tdep.c (score_unwind_sp): Delete.
10780 (score_unwind_pc): Delete.
10781 (score_dummy_id): Delete.
10782 (score_gdbarch_init): Don't register deleted functions with
10783 gdbarch.
10784
107852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10786
10787 * rx-tdep.c (rx_unwind_pc): Delete.
10788 (rx_unwind_sp): Delete.
10789 (rx_dummy_id): Delete.
10790 (rx_gdbarch_init): Don't register deleted functions with
10791 gdbarch. Update comment.
10792
107932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10794
10795 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10796 (rs6000_dummy_id): Delete.
10797 (rs6000_gdbarch_init): Don't register deleted functions with
10798 gdbarch.
10799
108002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10801
10802 * or1k-tdep.c (or1k_dummy_id): Delete.
10803 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10804
108052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10806
10807 * nios2-tdep.c (nios2_dummy_id): Delete.
10808 (nios2_unwind_sp): Delete.
10809 (nios2_gdbarch_init): Don't register deleted functions with
10810 gdbarch.
10811
108122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10813
10814 * nds32-tdep.c (nds32_dummy_id): Delete.
10815 (nds32_unwind_pc): Delete.
10816 (nds32_unwind_sp): Delete.
10817 (nds32_gdbarch_init): Don't register deleted functions with
10818 gdbarch.
10819
108202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10821
10822 * msp430-tdep.c (msp430_unwind_pc): Delete.
10823 (msp430_unwind_sp): Delete.
10824 (msp430_dummy_id): Delete.
10825 (msp430_gdbarch_init): Don't register deleted functions with
10826 gdbarch.
10827
108282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10829
10830 * moxie-tdep.c (moxie_unwind_sp): Delete.
10831 (moxie_unwind_pc): Delete.
10832 (moxie_dummy_id): Delete.
10833 (moxie_gdbarch_init): Don't register deleted functions with
10834 gdbarch.
10835
108362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10837
10838 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10839 (mn10300_unwind_pc): Delete.
10840 (mn10300_unwind_sp): Delete.
10841 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10842 mn10300_unwind_sp.
10843 (mn10300_frame_unwind_init): Don't register deleted functions with
10844 gdbarch.
10845
108462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10847
10848 * mep-tdep.c (mep_unwind_pc): Delete.
10849 (mep_unwind_sp): Delete.
10850 (mep_dummy_id): Delete.
10851 (mep_gdbarch_init): Don't register deleted functions with
10852 gdbarch.
10853
108542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10855
10856 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10857 (m68hc11_unwind_sp): Delete.
10858 (m68hc11_gdbarch_init): Don't register deleted functions with
10859 gdbarch.
10860
108612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10862
10863 * m32r-tdep.c (m32r_unwind_sp): Delete.
10864 (m32r_unwind_pc): Delete.
10865 (m32r_dummy_id): Delete.
10866 (m32r_gdbarch_init): Don't register deleted functions with
10867 gdbarch.
10868
108692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10870
10871 * m32c-tdep.c (m32c_unwind_pc): Delete.
10872 (m32c_unwind_sp): Delete.
10873 (m32c_dummy_id): Delete.
10874 (m32c_gdbarch_init): Don't register deleted functions with
10875 gdbarch.
10876
108772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10878
10879 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10880 (lm32_unwind_pc): Delete.
10881 (lm32_dummy_id): Delete.
10882 (lm32_gdbarch_init): Don't register deleted functions with
10883 gdbarch.
10884
108852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10886
10887 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10888 (iq2000_unwind_pc): Delete.
10889 (iq2000_dummy_id): Delete.
10890 (iq2000_gdbarch_init): Don't register deleted functions with
10891 gdbarch.
10892
108932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10894
10895 * nds32-tdep.c (nds32_type_align): Delete.
10896 (nds32_push_dummy_call): Use type_align instead.
10897
108982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10899
10900 * arm-tdep.c (arm_type_align): Only handle vector override case.
10901 (arm_push_dummy_call): Use type_align.
10902 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10903
109042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10905
10906 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10907 case.
10908 (pass_on_stack): Use type_align.
10909 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10910 function.
10911
109122019-04-23 Tom Tromey <tromey@adacore.com>
10913
10914 * dwarf2read.c (line_header::file_name_at): Remove unused
10915 overload.
10916
109172019-04-23 Tom de Vries <tdevries@suse.de>
10918
10919 PR gdb/24438
10920 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10921 invocation.
10922
10923
109242019-03-27 Ali Tamur <tamur@google.com>
10925
10926 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10927 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10928 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10929 (dwarf_expr_context::get_addr_index): Likewise
10930 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10931 (symbol_needs_eval_context::get_addr_index): Likewise
10932 (disassemble_dwarf_expression): Add DW_OP_addrx
10933 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10934 (read_cutu_die_from_dwo): Update comment
10935 (skip_one_die): Add DW_FORM_addrx
10936 (read_attribute_value): Likewise
10937 (var_decode_location): Add DW_OP_addrx
10938 (dwarf2_const_value_attr): Add DW_FORM_addrx
10939 (dump_die_shallow): Likewise
10940 (dwarf2_fetch_constant_bytes): Likewise
10941 (decode_locdesc): Add DW_OP_addrx
10942 (skip_form_bytes): Add DW_FORM_addrx
10943
109442019-04-22 Ali Tamur <tamur@google.com>
10945
10946 * MAINTAINERS (Write After Approval): Add self.
10947
109482019-04-22 Simon Marchi <simon.marchi@efficios.com>
10949
10950 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10951 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10952 (open_symbol_file_object): Likewise.
10953 (svr4_default_sos): Add info parameter.
10954 (svr4_read_so_list): Likewise.
10955 (svr4_current_sos_direct): Adjust functions calls to pass down
10956 info.
10957 (svr4_current_sos_1): Add info parameter.
10958 (svr4_current_sos): Call get_svr4_info, pass info down to
10959 svr4_current_sos_1.
10960 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10961 get_svr4_info.
10962 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10963 get_svr4_info.
10964 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10965 to get_svr4_info.
10966 (probes_table_remove_objfile_probes): Likewise.
10967 (register_solib_event_probe): Add info parameter.
10968 (solist_update_incremental): Pass info parameter down to
10969 svr4_read_so_list.
10970 (disable_probes_interface): Add info parameter.
10971 (svr4_handle_solib_event): Pass current_program_space to
10972 get_svr4_info. Adjust disable_probes_interface cleanup.
10973 (svr4_create_probe_breakpoints): Add info parameter, pass it
10974 down to register_solib_event_probe.
10975 (svr4_create_solib_event_breakpoints): Add info parameter,
10976 pass it down to svr4_create_probe_breakpoints.
10977 (enable_break): Pass info down to
10978 svr4_create_solib_event_breakpoints.
10979 (svr4_solib_create_inferior_hook): Pass current_program_space to
10980 get_svr4_info.
10981 (svr4_clear_solib): Likewise.
10982
109832019-04-22 Pedro Alves <palves@redhat.com>
10984
10985 * solib-svr4.c (svr4_free_objfile_observer): New.
10986 (probe_and_action::objfile): New field.
10987 (probes_table_htab_remove_objfile_probes)
10988 (probes_table_remove_objfile_probes): New functions.
10989 (register_solib_event_probe): Add 'objfile' parameter. Store it
10990 in the new probe_and_action. Don't store the probe in 'lookup'.
10991 (svr4_create_probe_breakpoints): Pass objfile to
10992 register_solib_event_probe.
10993 (_initialize_svr4_solib): Register a free_objfile observer.
10994
109952019-04-19 Tom Tromey <tom@tromey.com>
10996
10997 * common/queue.h: Remove.
10998
109992019-04-19 Tom Tromey <tom@tromey.com>
11000
11001 * event-loop.c: Don't include "common/queue.h".
11002
110032019-04-19 Tom Tromey <tom@tromey.com>
11004
11005 * remote.c (remote_target): Use delete.
11006 * remote-notif.h: Include <list>, not "common/queue.h".
11007 (notif_client_p): Remove typedef.
11008 (remote_notif_state): Add constructor, destructor, initializer.
11009 <notif_queue>: Now a std::list.
11010 (remote_notif_state_xfree): Don't declare.
11011 * remote-notif.c (remote_notif_process, handle_notification)
11012 (remote_notif_state_allocate): Update.
11013 (~remote_notif_state): Rename from remote_notif_state_xfree.
11014
110152019-04-19 Tom Tromey <tom@tromey.com>
11016
11017 * symfile.c (reread_symbols): Update.
11018 * objfiles.c (objfile_register_static_link)
11019 (objfile_lookup_static_link): Update
11020 (~objfile) Don't delete static_links.
11021 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11022
110232019-04-19 Tom Tromey <tom@tromey.com>
11024
11025 * type-stack.h (struct type_stack) <insert>: Constify string.
11026 * type-stack.c (type_stack::insert): Constify string.
11027 * gdbtypes.h (lookup_template_type): Update.
11028 (address_space_name_to_int): Update.
11029 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11030 const.
11031 (lookup_template_type): Make name const.
11032 * c-exp.y: Update rules.
11033 (lex_one_token, classify_name, classify_inner_name)
11034 (c_print_token): Update.
11035 * p-exp.y: Update rules.
11036 (yylex): Update.
11037 * f-exp.y: Update rules.
11038 (yylex): Update.
11039 * d-exp.y: Update rules.
11040 (lex_one_token, classify_name, classify_inner_name): Update.
11041 * parse.c (write_dollar_variable, copy_name): Return std::string.
11042 * parser-defs.h (copy_name): Change return type.
11043 * m2-exp.y: Update rules.
11044 (yylex): Update.
11045 * go-exp.y (lex_one_token): Update.
11046 Update rules.
11047 (classify_unsafe_function, classify_packaged_name)
11048 (classify_name, yylex): Update.
11049
110502019-04-19 Sergei Trofimovich <siarheit@google.com>
11051
11052 * configure.ac: add --enable-source-highlight switch.
11053 * configure: Regenerate.
11054 * top.c (print_gdb_version): plumb --enable-source-highlight
11055 status to "show configuration".
11056
110572019-04-19 Tom Tromey <tromey@adacore.com>
11058
11059 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11060 Check ADA_TYPE_P.
11061 (empty_record, ada_template_to_fixed_record_type_1)
11062 (template_to_static_fixed_type)
11063 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11064 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11065 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11066 macros.
11067
110682019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11069
11070 PR symtab/24423:
11071 * source.c (print_source_lines_base): Advance "iter" when a
11072 control character is seen.
11073
110742019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11075
11076 * inferior.h (struct infcall_suspend_state_deleter):
11077 Catch exception in destructor to avoid crash.
11078
110792019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11080
11081 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11082 close to the add_com "shell".
11083
110842019-04-18 Tom Tromey <tromey@adacore.com>
11085
11086 * process-stratum-target.h (class process_stratum_target)
11087 <stratum>: Add "final".
11088
110892019-04-17 Tom Tromey <tromey@adacore.com>
11090
11091 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11092 against nullptr before use.
11093
110942019-04-17 Alan Hayward <alan.hayward@arm.com>
11095
11096 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11097
110982019-04-17 Jim Wilson <jimw@sifive.com>
11099 Andrew Burgess <andrew.burgess@embecosm.com>
11100
11101 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11102 code read might fail, assume 4-byte breakpoint in that case.
11103
111042019-04-15 Leszek Swirski <leszeks@google.com>
11105
11106 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11107 rather than a hand-rolled POD check when checking for forced MEMORY
11108 classification.
11109
111102019-04-15 Alan Hayward <alan.hayward@arm.com>
11111
11112 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11113 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11114 function.
11115 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11116 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11117 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11118 declaration.
11119
111202019-04-15 Alan Hayward <alan.hayward@arm.com>
11121
11122 * aarch64-linux-nat.c
11123 (aarch64_linux_nat_target::thread_architecture): Add override.
11124 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11125 each VQ.
11126
111272019-04-15 Alan Hayward <alan.hayward@arm.com>
11128
11129 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11130
111312019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11132
11133 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11134 target types of size 96-bits, add some additional comments, and
11135 check that the builtin type we found was the correct size.
11136
111372019-04-12 Eli Zaretskii <eliz@gnu.org>
11138
11139 * utils.c (prompt_for_continue): Don't restore the styling at the
11140 end, as applied_style has the wrong value. This fixes styling in
11141 long lists of file names that are interrupted by the "Continue?"
11142 prompt.
11143
111442019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11145
11146 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11147 * c-lang.c (c_language_defn): Likewise.
11148 (cplus_language_defn): Likewise.
11149 (asm_language_defn): Likewise.
11150 (minimal_language_defn): Likewise.
11151 * d-lang.c (d_language_defn): Likewise.
11152 * f-lang.c (f_language_defn): Likewise.
11153 * go-lang.c (go_language_defn): Likewise.
11154 * language.c (unknown_language_defn): Likewise.
11155 (auto_language_defn): Likewise.
11156 * language.h (struct language_defn): Remove la_magic field.
11157 (LANG_MAGIC): Delete.
11158 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11159 * objc-lang.c (objc_language_defn): Likewise.
11160 * opencl-lang.c (opencl_language_defn): Likewise.
11161 * p-lang.c (pascal_language_defn): Likewise.
11162 * rust-lang.c (rust_language_defn): Likewise.
11163
111642019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11165
11166 * riscv-tdep.c (riscv_type_align): New function.
11167 (riscv_type_alignment): Delete.
11168 (riscv_arg_location): Use 'type_align'.
11169 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11170
111712019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11172
11173 * gdbtypes.c (type_align): A struct with no non-static fields also
11174 has alignment of 1.
11175
111762019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11177
11178 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11179 component to 0.
11180 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11181 member.
11182 (riscv_struct_info::analyse): New implementation using new
11183 analyse_inner member function.
11184 (riscv_struct_info::field_offset): New member function.
11185 (riscv_struct_info::m_offsets): New member variable.
11186 (riscv_struct_info::analyse_inner): New private member function,
11187 takes the old implementation of riscv_struct_info::analyse but
11188 extended to track field offsets.
11189 (riscv_call_arg_struct): Update the struct folding special cases
11190 to handle cases where empty C++ structs, which are non-zero
11191 length, are found.
11192 (riscv_arg_location): Initialise the length of each location, a
11193 non-zero length now indicates the location is in use.
11194 (riscv_push_dummy_call): Allow for the first location having a
11195 non-zero offset when setting up arguments.
11196 (riscv_return_value): Likewise, but for return values.
11197
111982019-04-11 Tom Tromey <tromey@adacore.com>
11199
11200 * utils.c (internal_vproblem): Make "msg" const.
11201
112022019-04-11 Alan Hayward <alan.hayward@arm.com>
11203
11204 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11205 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11206 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11207 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11208
112092019-04-10 Kevin Buettner <kevinb@redhat.com>
11210
11211 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11212 function.
11213 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11214 of amd64_collect_native_gregset.
11215 (amd64_linux_nat_target::store_registers): Likewise.
11216
112172019-04-10 Tom Tromey <tom@tromey.com>
11218
11219 * symtab.c (lookup_global_symbol_from_objfile)
11220 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11221 * objfiles.h (class separate_debug_iterator): New.
11222 (class separate_debug_range): New.
11223 (struct objfile) <separate_debug_objfiles>: New method.
11224 (objfile_separate_debug_iterate): Don't declare.
11225 * objfiles.c (separate_debug_iterator::operator++): Rename from
11226 objfile_separate_debug_iterate.
11227 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11228 iterator.
11229 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11230 iterator.
11231
112322019-04-10 Tom Tromey <tom@tromey.com>
11233
11234 * symfile.c (reread_symbols): Remove old comment.
11235 * objfiles.c (free_all_objfiles): Fix a typo.
11236
112372019-04-10 Tom Tromey <tom@tromey.com>
11238
11239 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11240 * minsyms.c (lookup_minimal_symbol): Use foreach.
11241 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11242 (lookup_minimal_symbol_solib_trampoline): Likewise.
11243 * symfile.c (reread_symbols): Use foreach.
11244
112452019-04-09 Ivan Begert <ivanbegert@gmail.com>
11246 Tom Tromey <tromey@adacore.com>
11247
11248 PR rust/24414:
11249 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11250 (rust_lex_int_test): Change "value" to be LONGEST.
11251 (rust_lex_tests): Add test for long integer literal.
11252
112532019-04-09 Tom Tromey <tromey@adacore.com>
11254
11255 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11256 to bool.
11257 (extended_remote_target::attach): Update.
11258 (remote_target::remote_notice_new_inferior): Update.
11259 (remote_target::add_current_inferior_and_thread): Update.
11260 * inferior.c (exit_inferior_1): Use "false".
11261 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11262
112632019-04-09 Simon Marchi <simon.marchi@efficios.com>
11264
11265 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11266 the "start" command.
11267
112682019-04-08 Kevin Buettner <kevinb@redhat.com>
11269
11270 * python/py-inferior.c (infpy_thread_from_thread_handle):
11271 Adjust comments to reflect renaming of thread_from_thread_handle
11272 to thread_from_handle. Adjust keywords. Fix type error message.
11273 (inferior_object_methods): Add thread_from_handle. Retain
11274 thread_from_thread_handle, but mark it as deprecated.
11275
112762019-04-08 Kevin Buettner <kevinb@redhat.com>
11277
11278 * gdbthread.h (find_thread_by_handle): Revise declaration.
11279 * thread.c (find_thread_by_handle): Likewise. Adjust
11280 implementation too.
11281 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11282 support for buffer objects as handles.
11283
112842019-04-08 Kevin Buettner <kevinb@redhat.com>
11285
11286 * python/py-infthread.c (thpy_thread_handle): New function.
11287 (thread_object_methods): Register thpy_thread_handle.
11288
112892019-04-08 Kevin Buettner <kevinb@redhat.com>
11290
11291 * gdbthread.h (thread_to_thread_handle): Declare.
11292 * thread.c (gdbtypes.h): Include.
11293 (thread_to_thread_handle): New function.
11294
11295 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11296 (target_thread_info_to_thread_handle): Declare.
11297 * target.c (target_thread_info_to_thread_handle): New function.
11298 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11299 * target-delegates.c: Regenerate.
11300
11301 * linux-thread-db.c (class thread_db_target): Add method
11302 thread_info_to_thread_handle.
11303 (thread_db_target::thread_info_to_thread_handle): Define.
11304 * remote.c (class remote_target): Add new method
11305 thread_info_to_thread_handle.
11306 (remote_target::thread_info_to_thread_handle): Define.
11307
113082019-04-08 Pedro Alves <palves@redhat.com>
11309
11310 * common/common-exceptions.c (throw_exception): Don't create
11311 named object to throw; throw directly.
11312 (throw_it): Likewise. Don't initialize gdb_exception::message
11313 here, with new; pass FMT and AP to the ctor instead.
11314 * common/common-exceptions.h: Include <string>.
11315 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11316 const char *, va_list)): New ctor. Use std::make_shared.
11317 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11318 errors)): Delete.
11319 (gdb_exception_error::gdb_exception_error(enum errors, const char
11320 *, va_list)): New.
11321 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11322 Add assertion.
11323 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11324 errors)): Delete.
11325 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11326 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11327 Add assertion.
11328
113292019-04-08 Tom Tromey <tom@tromey.com>
11330
11331 * valops.c (value_rtti_indirect_type): Replace throw_exception
11332 with throw.
11333 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11334 with throw.
11335 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11336 throw.
11337 * target.c (target_translate_tls_address): Replace throw_exception
11338 with throw.
11339 * stack.c (frame_apply_command_count): Replace throw_exception
11340 with throw.
11341 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11342 throw.
11343 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11344 with throw.
11345 * rs6000-tdep.c (rs6000_frame_cache)
11346 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11347 * remote.c: Replace throw_exception with throw.
11348 * record-full.c (record_full_message, record_full_wait_1)
11349 (record_full_restore): Replace throw_exception with throw.
11350 * record-btrace.c:
11351 (get_thread_current_frame_id, record_btrace_start_replaying)
11352 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11353 (cmd_record_btrace_start): Replace throw_exception with throw.
11354 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11355 throw.
11356 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11357 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11358 * linespec.c:
11359 (find_linespec_symbols): Replace throw_exception with throw.
11360 * infrun.c (displaced_step_prepare, resume): Replace
11361 throw_exception with throw.
11362 * infcmd.c (post_create_inferior): Replace throw_exception with
11363 throw.
11364 * inf-loop.c (inferior_event_handler): Replace throw_exception
11365 with throw.
11366 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11367 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11368 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11369 (get_prev_frame_always, get_frame_pc_if_available)
11370 (get_frame_address_in_block_if_available, get_frame_language):
11371 Replace throw_exception with throw.
11372 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11373 throw_exception with throw.
11374 * eval.c (fetch_subexp_value, evaluate_var_value)
11375 (evaluate_funcall, evaluate_subexp_standard): Replace
11376 throw_exception with throw.
11377 * dwarf2loc.c (call_site_find_chain)
11378 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11379 Replace throw_exception with throw.
11380 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11381 with throw.
11382 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11383 throw.
11384 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11385 * completer.c (complete_line_internal): Replace throw_exception
11386 with throw.
11387 * compile/compile-object-run.c (compile_object_run): Replace
11388 throw_exception with throw.
11389 * cli/cli-script.c (process_next_line): Replace throw_exception
11390 with throw.
11391 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11392 (btrace_enable, btrace_maint_update_pt_packets): Replace
11393 throw_exception with throw.
11394 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11395 throw_exception with throw.
11396 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11397 throw_exception with throw.
11398 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11399 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11400 * aarch64-tdep.c (aarch64_make_prologue_cache)
11401 (aarch64_make_stub_cache): Replace throw_exception with throw.
11402
114032019-04-08 Tom Tromey <tom@tromey.com>
11404
11405 * common/common-exceptions.c (throw_exception): Rename from
11406 throw_exception_cxx. Remove old copy. Make argument const.
11407 (throw_it): Create and throw exception objects directly.
11408 * common/common-exceptions.h (throw_exception): Make argument
11409 const.
11410 (struct gdb_exception_error): Add constructor.
11411 (struct gdb_exception_quit): Add constructor.
11412
114132019-04-08 Tom Tromey <tom@tromey.com>
11414
11415 * common/common-exceptions.h (exception_rethrow): Don't declare.
11416 (TRY_SJLJ): Update comment.
11417 (TRY, CATCH, END_CATCH): Remove.
11418 * common/common-exceptions.c (exception_rethrow): Remove.
11419
114202019-04-08 Tom Tromey <tom@tromey.com>
11421
11422 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11423 Remove.
11424 (gdb_exception_error): Rename from
11425 gdb_exception_RETURN_MASK_ERROR.
11426 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11427 (gdb_quit_bad_alloc): Update.
11428 * aarch64-tdep.c: Update.
11429 * ada-lang.c: Update.
11430 * ada-typeprint.c: Update.
11431 * ada-valprint.c: Update.
11432 * amd64-tdep.c: Update.
11433 * arch-utils.c: Update.
11434 * break-catch-throw.c: Update.
11435 * breakpoint.c: Update.
11436 * btrace.c: Update.
11437 * c-varobj.c: Update.
11438 * cli/cli-cmds.c: Update.
11439 * cli/cli-interp.c: Update.
11440 * cli/cli-script.c: Update.
11441 * common/common-exceptions.c: Update.
11442 * common/new-op.c: Update.
11443 * common/selftest.c: Update.
11444 * compile/compile-c-symbols.c: Update.
11445 * compile/compile-cplus-symbols.c: Update.
11446 * compile/compile-object-load.c: Update.
11447 * compile/compile-object-run.c: Update.
11448 * completer.c: Update.
11449 * corelow.c: Update.
11450 * cp-abi.c: Update.
11451 * cp-support.c: Update.
11452 * cp-valprint.c: Update.
11453 * darwin-nat.c: Update.
11454 * disasm-selftests.c: Update.
11455 * dtrace-probe.c: Update.
11456 * dwarf-index-cache.c: Update.
11457 * dwarf-index-write.c: Update.
11458 * dwarf2-frame-tailcall.c: Update.
11459 * dwarf2-frame.c: Update.
11460 * dwarf2loc.c: Update.
11461 * dwarf2read.c: Update.
11462 * eval.c: Update.
11463 * event-loop.c: Update.
11464 * event-top.c: Update.
11465 * exec.c: Update.
11466 * f-valprint.c: Update.
11467 * fbsd-tdep.c: Update.
11468 * frame-unwind.c: Update.
11469 * frame.c: Update.
11470 * gdbtypes.c: Update.
11471 * gnu-v3-abi.c: Update.
11472 * guile/guile-internal.h: Update.
11473 * guile/scm-block.c: Update.
11474 * guile/scm-breakpoint.c: Update.
11475 * guile/scm-cmd.c: Update.
11476 * guile/scm-disasm.c: Update.
11477 * guile/scm-frame.c: Update.
11478 * guile/scm-lazy-string.c: Update.
11479 * guile/scm-math.c: Update.
11480 * guile/scm-param.c: Update.
11481 * guile/scm-ports.c: Update.
11482 * guile/scm-pretty-print.c: Update.
11483 * guile/scm-symbol.c: Update.
11484 * guile/scm-symtab.c: Update.
11485 * guile/scm-type.c: Update.
11486 * guile/scm-value.c: Update.
11487 * i386-linux-tdep.c: Update.
11488 * i386-tdep.c: Update.
11489 * inf-loop.c: Update.
11490 * infcall.c: Update.
11491 * infcmd.c: Update.
11492 * infrun.c: Update.
11493 * jit.c: Update.
11494 * language.c: Update.
11495 * linespec.c: Update.
11496 * linux-fork.c: Update.
11497 * linux-nat.c: Update.
11498 * linux-tdep.c: Update.
11499 * linux-thread-db.c: Update.
11500 * main.c: Update.
11501 * mi/mi-cmd-break.c: Update.
11502 * mi/mi-cmd-stack.c: Update.
11503 * mi/mi-interp.c: Update.
11504 * mi/mi-main.c: Update.
11505 * objc-lang.c: Update.
11506 * p-valprint.c: Update.
11507 * parse.c: Update.
11508 * ppc-linux-tdep.c: Update.
11509 * printcmd.c: Update.
11510 * python/py-arch.c: Update.
11511 * python/py-breakpoint.c: Update.
11512 * python/py-cmd.c: Update.
11513 * python/py-finishbreakpoint.c: Update.
11514 * python/py-frame.c: Update.
11515 * python/py-framefilter.c: Update.
11516 * python/py-gdb-readline.c: Update.
11517 * python/py-inferior.c: Update.
11518 * python/py-infthread.c: Update.
11519 * python/py-lazy-string.c: Update.
11520 * python/py-linetable.c: Update.
11521 * python/py-objfile.c: Update.
11522 * python/py-param.c: Update.
11523 * python/py-prettyprint.c: Update.
11524 * python/py-progspace.c: Update.
11525 * python/py-record-btrace.c: Update.
11526 * python/py-record.c: Update.
11527 * python/py-symbol.c: Update.
11528 * python/py-type.c: Update.
11529 * python/py-unwind.c: Update.
11530 * python/py-utils.c: Update.
11531 * python/py-value.c: Update.
11532 * python/python.c: Update.
11533 * record-btrace.c: Update.
11534 * record-full.c: Update.
11535 * remote-fileio.c: Update.
11536 * remote.c: Update.
11537 * riscv-tdep.c: Update.
11538 * rs6000-aix-tdep.c: Update.
11539 * rs6000-tdep.c: Update.
11540 * rust-exp.y: Update.
11541 * rust-lang.c: Update.
11542 * s390-tdep.c: Update.
11543 * selftest-arch.c: Update.
11544 * solib-dsbt.c: Update.
11545 * solib-frv.c: Update.
11546 * solib-spu.c: Update.
11547 * solib-svr4.c: Update.
11548 * solib.c: Update.
11549 * sparc64-linux-tdep.c: Update.
11550 * stack.c: Update.
11551 * symfile-mem.c: Update.
11552 * symmisc.c: Update.
11553 * target.c: Update.
11554 * thread.c: Update.
11555 * top.c: Update.
11556 * tracefile-tfile.c: Update.
11557 * tui/tui.c: Update.
11558 * typeprint.c: Update.
11559 * unittests/cli-utils-selftests.c: Update.
11560 * unittests/parse-connection-spec-selftests.c: Update.
11561 * valops.c: Update.
11562 * valprint.c: Update.
11563 * value.c: Update.
11564 * varobj.c: Update.
11565 * windows-nat.c: Update.
11566 * x86-linux-nat.c: Update.
11567 * xml-support.c: Update.
11568
115692019-04-08 Tom Tromey <tom@tromey.com>
11570
11571 * xml-support.c: Use C++ exception handling.
11572 * x86-linux-nat.c: Use C++ exception handling.
11573 * windows-nat.c: Use C++ exception handling.
11574 * varobj.c: Use C++ exception handling.
11575 * value.c: Use C++ exception handling.
11576 * valprint.c: Use C++ exception handling.
11577 * valops.c: Use C++ exception handling.
11578 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11579 handling.
11580 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11581 * typeprint.c: Use C++ exception handling.
11582 * tui/tui.c: Use C++ exception handling.
11583 * tracefile-tfile.c: Use C++ exception handling.
11584 * top.c: Use C++ exception handling.
11585 * thread.c: Use C++ exception handling.
11586 * target.c: Use C++ exception handling.
11587 * symmisc.c: Use C++ exception handling.
11588 * symfile-mem.c: Use C++ exception handling.
11589 * stack.c: Use C++ exception handling.
11590 * sparc64-linux-tdep.c: Use C++ exception handling.
11591 * solib.c: Use C++ exception handling.
11592 * solib-svr4.c: Use C++ exception handling.
11593 * solib-spu.c: Use C++ exception handling.
11594 * solib-frv.c: Use C++ exception handling.
11595 * solib-dsbt.c: Use C++ exception handling.
11596 * selftest-arch.c: Use C++ exception handling.
11597 * s390-tdep.c: Use C++ exception handling.
11598 * rust-lang.c: Use C++ exception handling.
11599 * rust-exp.y: Use C++ exception handling.
11600 * rs6000-tdep.c: Use C++ exception handling.
11601 * rs6000-aix-tdep.c: Use C++ exception handling.
11602 * riscv-tdep.c: Use C++ exception handling.
11603 * remote.c: Use C++ exception handling.
11604 * remote-fileio.c: Use C++ exception handling.
11605 * record-full.c: Use C++ exception handling.
11606 * record-btrace.c: Use C++ exception handling.
11607 * python/python.c: Use C++ exception handling.
11608 * python/py-value.c: Use C++ exception handling.
11609 * python/py-utils.c: Use C++ exception handling.
11610 * python/py-unwind.c: Use C++ exception handling.
11611 * python/py-type.c: Use C++ exception handling.
11612 * python/py-symbol.c: Use C++ exception handling.
11613 * python/py-record.c: Use C++ exception handling.
11614 * python/py-record-btrace.c: Use C++ exception handling.
11615 * python/py-progspace.c: Use C++ exception handling.
11616 * python/py-prettyprint.c: Use C++ exception handling.
11617 * python/py-param.c: Use C++ exception handling.
11618 * python/py-objfile.c: Use C++ exception handling.
11619 * python/py-linetable.c: Use C++ exception handling.
11620 * python/py-lazy-string.c: Use C++ exception handling.
11621 * python/py-infthread.c: Use C++ exception handling.
11622 * python/py-inferior.c: Use C++ exception handling.
11623 * python/py-gdb-readline.c: Use C++ exception handling.
11624 * python/py-framefilter.c: Use C++ exception handling.
11625 * python/py-frame.c: Use C++ exception handling.
11626 * python/py-finishbreakpoint.c: Use C++ exception handling.
11627 * python/py-cmd.c: Use C++ exception handling.
11628 * python/py-breakpoint.c: Use C++ exception handling.
11629 * python/py-arch.c: Use C++ exception handling.
11630 * printcmd.c: Use C++ exception handling.
11631 * ppc-linux-tdep.c: Use C++ exception handling.
11632 * parse.c: Use C++ exception handling.
11633 * p-valprint.c: Use C++ exception handling.
11634 * objc-lang.c: Use C++ exception handling.
11635 * mi/mi-main.c: Use C++ exception handling.
11636 * mi/mi-interp.c: Use C++ exception handling.
11637 * mi/mi-cmd-stack.c: Use C++ exception handling.
11638 * mi/mi-cmd-break.c: Use C++ exception handling.
11639 * main.c: Use C++ exception handling.
11640 * linux-thread-db.c: Use C++ exception handling.
11641 * linux-tdep.c: Use C++ exception handling.
11642 * linux-nat.c: Use C++ exception handling.
11643 * linux-fork.c: Use C++ exception handling.
11644 * linespec.c: Use C++ exception handling.
11645 * language.c: Use C++ exception handling.
11646 * jit.c: Use C++ exception handling.
11647 * infrun.c: Use C++ exception handling.
11648 * infcmd.c: Use C++ exception handling.
11649 * infcall.c: Use C++ exception handling.
11650 * inf-loop.c: Use C++ exception handling.
11651 * i386-tdep.c: Use C++ exception handling.
11652 * i386-linux-tdep.c: Use C++ exception handling.
11653 * guile/scm-value.c: Use C++ exception handling.
11654 * guile/scm-type.c: Use C++ exception handling.
11655 * guile/scm-symtab.c: Use C++ exception handling.
11656 * guile/scm-symbol.c: Use C++ exception handling.
11657 * guile/scm-pretty-print.c: Use C++ exception handling.
11658 * guile/scm-ports.c: Use C++ exception handling.
11659 * guile/scm-param.c: Use C++ exception handling.
11660 * guile/scm-math.c: Use C++ exception handling.
11661 * guile/scm-lazy-string.c: Use C++ exception handling.
11662 * guile/scm-frame.c: Use C++ exception handling.
11663 * guile/scm-disasm.c: Use C++ exception handling.
11664 * guile/scm-cmd.c: Use C++ exception handling.
11665 * guile/scm-breakpoint.c: Use C++ exception handling.
11666 * guile/scm-block.c: Use C++ exception handling.
11667 * guile/guile-internal.h: Use C++ exception handling.
11668 * gnu-v3-abi.c: Use C++ exception handling.
11669 * gdbtypes.c: Use C++ exception handling.
11670 * frame.c: Use C++ exception handling.
11671 * frame-unwind.c: Use C++ exception handling.
11672 * fbsd-tdep.c: Use C++ exception handling.
11673 * f-valprint.c: Use C++ exception handling.
11674 * exec.c: Use C++ exception handling.
11675 * event-top.c: Use C++ exception handling.
11676 * event-loop.c: Use C++ exception handling.
11677 * eval.c: Use C++ exception handling.
11678 * dwarf2read.c: Use C++ exception handling.
11679 * dwarf2loc.c: Use C++ exception handling.
11680 * dwarf2-frame.c: Use C++ exception handling.
11681 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11682 * dwarf-index-write.c: Use C++ exception handling.
11683 * dwarf-index-cache.c: Use C++ exception handling.
11684 * dtrace-probe.c: Use C++ exception handling.
11685 * disasm-selftests.c: Use C++ exception handling.
11686 * darwin-nat.c: Use C++ exception handling.
11687 * cp-valprint.c: Use C++ exception handling.
11688 * cp-support.c: Use C++ exception handling.
11689 * cp-abi.c: Use C++ exception handling.
11690 * corelow.c: Use C++ exception handling.
11691 * completer.c: Use C++ exception handling.
11692 * compile/compile-object-run.c: Use C++ exception handling.
11693 * compile/compile-object-load.c: Use C++ exception handling.
11694 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11695 * compile/compile-c-symbols.c: Use C++ exception handling.
11696 * common/selftest.c: Use C++ exception handling.
11697 * common/new-op.c: Use C++ exception handling.
11698 * cli/cli-script.c: Use C++ exception handling.
11699 * cli/cli-interp.c: Use C++ exception handling.
11700 * cli/cli-cmds.c: Use C++ exception handling.
11701 * c-varobj.c: Use C++ exception handling.
11702 * btrace.c: Use C++ exception handling.
11703 * breakpoint.c: Use C++ exception handling.
11704 * break-catch-throw.c: Use C++ exception handling.
11705 * arch-utils.c: Use C++ exception handling.
11706 * amd64-tdep.c: Use C++ exception handling.
11707 * ada-valprint.c: Use C++ exception handling.
11708 * ada-typeprint.c: Use C++ exception handling.
11709 * ada-lang.c: Use C++ exception handling.
11710 * aarch64-tdep.c: Use C++ exception handling.
11711
117122019-04-08 Tom Tromey <tom@tromey.com>
11713
11714 * xml-support.c (gdb_xml_parser::parse): Update.
11715 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11716 * value.c (show_convenience): Update.
11717 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11718 (test_parse_flags_qcs): Update.
11719 * thread.c (thr_try_catch_cmd): Update.
11720 * target.c (target_translate_tls_address): Update.
11721 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11722 (info_frame_command_core, frame_apply_command_count): Update.
11723 * rust-exp.y (rust_lex_exception_test): Update.
11724 * riscv-tdep.c (riscv_print_one_register_info): Update.
11725 * remote.c (remote_target::enable_btrace): Update.
11726 * record-btrace.c (record_btrace_enable_warn): Update.
11727 * python/py-utils.c (gdbpy_convert_exception): Update.
11728 * printcmd.c (do_one_display, print_variable_and_value): Update.
11729 * mi/mi-main.c (mi_print_exception): Update.
11730 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11731 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11732 * linux-nat.c (linux_nat_target::attach): Update.
11733 * linux-fork.c (class scoped_switch_fork_info): Update.
11734 * infrun.c (displaced_step_prepare): Update.
11735 * infcall.c (call_function_by_hand_dummy): Update.
11736 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11737 * gnu-v3-abi.c (print_one_vtable): Update.
11738 * frame.c (get_prev_frame_always): Update.
11739 * f-valprint.c (info_common_command_for_block): Update.
11740 * exec.c (try_open_exec_file): Update.
11741 * exceptions.c (print_exception, exception_print)
11742 (exception_fprintf, exception_print_same): Update.
11743 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11744 * dwarf-index-cache.c (index_cache::store)
11745 (index_cache::lookup_gdb_index): Update.
11746 * darwin-nat.c (maybe_cache_shell): Update.
11747 * cp-valprint.c (cp_print_value_fields): Update.
11748 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11749 (gcc_cplus_symbol_address): Update.
11750 * compile/compile-c-symbols.c (gcc_convert_symbol)
11751 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11752 * common/selftest.c: Update.
11753 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11754 a std::string.
11755 (exception_try_scope_entry, exception_try_scope_exit): Don't
11756 declare.
11757 (struct exception_try_scope): Remove.
11758 (TRY): Don't use exception_try_scope.
11759 (struct gdb_exception): Add constructor, operator=.
11760 <what>: New method.
11761 (struct gdb_exception_RETURN_MASK_ALL)
11762 (struct gdb_exception_RETURN_MASK_ERROR)
11763 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11764 (struct gdb_quit_bad_alloc): Update.
11765 * common/common-exceptions.c (exception_none): Change
11766 initializer.
11767 (struct catcher) <state, exception>: Initialize inline.
11768 <prev>: Remove member.
11769 (current_catcher): Remove.
11770 (catchers): New global.
11771 (exceptions_state_mc_init): Simplify.
11772 (catcher_pop): Remove.
11773 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11774 (try_scope_depth, exception_try_scope_entry)
11775 (exception_try_scope_exit): Remove.
11776 (throw_exception_sjlj): Update.
11777 (exception_messages, exception_messages_size): Remove.
11778 (throw_it): Simplify.
11779 (gdb_exception_sliced_copy): Remove.
11780 (throw_exception_cxx): Update.
11781 * cli/cli-script.c (script_from_file): Update.
11782 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11783 Update.
11784 * ada-valprint.c (ada_val_print): Update.
11785 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11786 (create_excep_cond_exprs): Update.
11787
117882019-04-08 Tom Tromey <tom@tromey.com>
11789
11790 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11791 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11792 (TRY, CATCH, END_CATCH): Remove some definitions.
11793 * common/common-exceptions.c: Don't use GDB_XCPT.
11794 (catcher_list_size): Remove.
11795 (throw_exception, throw_it): Simplify.
11796
117972019-04-05 Tom Tromey <tom@tromey.com>
11798
11799 Revert the header-sorting patch.
11800 * ft32-tdep.c: Revert.
11801 * frv-tdep.c: Revert.
11802 * frv-linux-tdep.c: Revert.
11803 * frame.c: Revert.
11804 * frame-unwind.c: Revert.
11805 * frame-base.c: Revert.
11806 * fork-child.c: Revert.
11807 * findvar.c: Revert.
11808 * findcmd.c: Revert.
11809 * filesystem.c: Revert.
11810 * filename-seen-cache.h: Revert.
11811 * filename-seen-cache.c: Revert.
11812 * fbsd-tdep.c: Revert.
11813 * fbsd-nat.h: Revert.
11814 * fbsd-nat.c: Revert.
11815 * f-valprint.c: Revert.
11816 * f-typeprint.c: Revert.
11817 * f-lang.c: Revert.
11818 * extension.h: Revert.
11819 * extension.c: Revert.
11820 * extension-priv.h: Revert.
11821 * expprint.c: Revert.
11822 * exec.h: Revert.
11823 * exec.c: Revert.
11824 * exceptions.c: Revert.
11825 * event-top.c: Revert.
11826 * event-loop.c: Revert.
11827 * eval.c: Revert.
11828 * elfread.c: Revert.
11829 * dwarf2read.h: Revert.
11830 * dwarf2read.c: Revert.
11831 * dwarf2loc.c: Revert.
11832 * dwarf2expr.h: Revert.
11833 * dwarf2expr.c: Revert.
11834 * dwarf2-frame.c: Revert.
11835 * dwarf2-frame-tailcall.c: Revert.
11836 * dwarf-index-write.h: Revert.
11837 * dwarf-index-write.c: Revert.
11838 * dwarf-index-common.c: Revert.
11839 * dwarf-index-cache.h: Revert.
11840 * dwarf-index-cache.c: Revert.
11841 * dummy-frame.c: Revert.
11842 * dtrace-probe.c: Revert.
11843 * disasm.h: Revert.
11844 * disasm.c: Revert.
11845 * disasm-selftests.c: Revert.
11846 * dictionary.c: Revert.
11847 * dicos-tdep.c: Revert.
11848 * demangle.c: Revert.
11849 * dcache.h: Revert.
11850 * dcache.c: Revert.
11851 * darwin-nat.h: Revert.
11852 * darwin-nat.c: Revert.
11853 * darwin-nat-info.c: Revert.
11854 * d-valprint.c: Revert.
11855 * d-namespace.c: Revert.
11856 * d-lang.c: Revert.
11857 * ctf.c: Revert.
11858 * csky-tdep.c: Revert.
11859 * csky-linux-tdep.c: Revert.
11860 * cris-tdep.c: Revert.
11861 * cris-linux-tdep.c: Revert.
11862 * cp-valprint.c: Revert.
11863 * cp-support.c: Revert.
11864 * cp-namespace.c: Revert.
11865 * cp-abi.c: Revert.
11866 * corelow.c: Revert.
11867 * corefile.c: Revert.
11868 * continuations.c: Revert.
11869 * completer.h: Revert.
11870 * completer.c: Revert.
11871 * complaints.c: Revert.
11872 * coffread.c: Revert.
11873 * coff-pe-read.c: Revert.
11874 * cli-out.h: Revert.
11875 * cli-out.c: Revert.
11876 * charset.c: Revert.
11877 * c-varobj.c: Revert.
11878 * c-valprint.c: Revert.
11879 * c-typeprint.c: Revert.
11880 * c-lang.c: Revert.
11881 * buildsym.c: Revert.
11882 * buildsym-legacy.c: Revert.
11883 * build-id.h: Revert.
11884 * build-id.c: Revert.
11885 * btrace.c: Revert.
11886 * bsd-uthread.c: Revert.
11887 * breakpoint.h: Revert.
11888 * breakpoint.c: Revert.
11889 * break-catch-throw.c: Revert.
11890 * break-catch-syscall.c: Revert.
11891 * break-catch-sig.c: Revert.
11892 * blockframe.c: Revert.
11893 * block.c: Revert.
11894 * bfin-tdep.c: Revert.
11895 * bfin-linux-tdep.c: Revert.
11896 * bfd-target.c: Revert.
11897 * bcache.c: Revert.
11898 * ax-general.c: Revert.
11899 * ax-gdb.h: Revert.
11900 * ax-gdb.c: Revert.
11901 * avr-tdep.c: Revert.
11902 * auxv.c: Revert.
11903 * auto-load.c: Revert.
11904 * arm-wince-tdep.c: Revert.
11905 * arm-tdep.c: Revert.
11906 * arm-symbian-tdep.c: Revert.
11907 * arm-pikeos-tdep.c: Revert.
11908 * arm-obsd-tdep.c: Revert.
11909 * arm-nbsd-tdep.c: Revert.
11910 * arm-nbsd-nat.c: Revert.
11911 * arm-linux-tdep.c: Revert.
11912 * arm-linux-nat.c: Revert.
11913 * arm-fbsd-tdep.c: Revert.
11914 * arm-fbsd-nat.c: Revert.
11915 * arm-bsd-tdep.c: Revert.
11916 * arch-utils.c: Revert.
11917 * arc-tdep.c: Revert.
11918 * arc-newlib-tdep.c: Revert.
11919 * annotate.h: Revert.
11920 * annotate.c: Revert.
11921 * amd64-windows-tdep.c: Revert.
11922 * amd64-windows-nat.c: Revert.
11923 * amd64-tdep.c: Revert.
11924 * amd64-sol2-tdep.c: Revert.
11925 * amd64-obsd-tdep.c: Revert.
11926 * amd64-obsd-nat.c: Revert.
11927 * amd64-nbsd-tdep.c: Revert.
11928 * amd64-nbsd-nat.c: Revert.
11929 * amd64-nat.c: Revert.
11930 * amd64-linux-tdep.c: Revert.
11931 * amd64-linux-nat.c: Revert.
11932 * amd64-fbsd-tdep.c: Revert.
11933 * amd64-fbsd-nat.c: Revert.
11934 * amd64-dicos-tdep.c: Revert.
11935 * amd64-darwin-tdep.c: Revert.
11936 * amd64-bsd-nat.c: Revert.
11937 * alpha-tdep.c: Revert.
11938 * alpha-obsd-tdep.c: Revert.
11939 * alpha-nbsd-tdep.c: Revert.
11940 * alpha-mdebug-tdep.c: Revert.
11941 * alpha-linux-tdep.c: Revert.
11942 * alpha-linux-nat.c: Revert.
11943 * alpha-bsd-tdep.c: Revert.
11944 * alpha-bsd-nat.c: Revert.
11945 * aix-thread.c: Revert.
11946 * agent.c: Revert.
11947 * addrmap.c: Revert.
11948 * ada-varobj.c: Revert.
11949 * ada-valprint.c: Revert.
11950 * ada-typeprint.c: Revert.
11951 * ada-tasks.c: Revert.
11952 * ada-lang.c: Revert.
11953 * aarch64-tdep.c: Revert.
11954 * aarch64-ravenscar-thread.c: Revert.
11955 * aarch64-newlib-tdep.c: Revert.
11956 * aarch64-linux-tdep.c: Revert.
11957 * aarch64-linux-nat.c: Revert.
11958 * aarch64-fbsd-tdep.c: Revert.
11959 * aarch64-fbsd-nat.c: Revert.
11960 * aarch32-linux-nat.c: Revert.
11961
119622019-04-05 Tom Tromey <tom@tromey.com>
11963
11964 * ft32-tdep.c: Sort headers.
11965 * frv-tdep.c: Sort headers.
11966 * frv-linux-tdep.c: Sort headers.
11967 * frame.c: Sort headers.
11968 * frame-unwind.c: Sort headers.
11969 * frame-base.c: Sort headers.
11970 * fork-child.c: Sort headers.
11971 * findvar.c: Sort headers.
11972 * findcmd.c: Sort headers.
11973 * filesystem.c: Sort headers.
11974 * filename-seen-cache.h: Sort headers.
11975 * filename-seen-cache.c: Sort headers.
11976 * fbsd-tdep.c: Sort headers.
11977 * fbsd-nat.h: Sort headers.
11978 * fbsd-nat.c: Sort headers.
11979 * f-valprint.c: Sort headers.
11980 * f-typeprint.c: Sort headers.
11981 * f-lang.c: Sort headers.
11982 * extension.h: Sort headers.
11983 * extension.c: Sort headers.
11984 * extension-priv.h: Sort headers.
11985 * expprint.c: Sort headers.
11986 * exec.h: Sort headers.
11987 * exec.c: Sort headers.
11988 * exceptions.c: Sort headers.
11989 * event-top.c: Sort headers.
11990 * event-loop.c: Sort headers.
11991 * eval.c: Sort headers.
11992 * elfread.c: Sort headers.
11993 * dwarf2read.h: Sort headers.
11994 * dwarf2read.c: Sort headers.
11995 * dwarf2loc.c: Sort headers.
11996 * dwarf2expr.h: Sort headers.
11997 * dwarf2expr.c: Sort headers.
11998 * dwarf2-frame.c: Sort headers.
11999 * dwarf2-frame-tailcall.c: Sort headers.
12000 * dwarf-index-write.h: Sort headers.
12001 * dwarf-index-write.c: Sort headers.
12002 * dwarf-index-common.c: Sort headers.
12003 * dwarf-index-cache.h: Sort headers.
12004 * dwarf-index-cache.c: Sort headers.
12005 * dummy-frame.c: Sort headers.
12006 * dtrace-probe.c: Sort headers.
12007 * disasm.h: Sort headers.
12008 * disasm.c: Sort headers.
12009 * disasm-selftests.c: Sort headers.
12010 * dictionary.c: Sort headers.
12011 * dicos-tdep.c: Sort headers.
12012 * demangle.c: Sort headers.
12013 * dcache.h: Sort headers.
12014 * dcache.c: Sort headers.
12015 * darwin-nat.h: Sort headers.
12016 * darwin-nat.c: Sort headers.
12017 * darwin-nat-info.c: Sort headers.
12018 * d-valprint.c: Sort headers.
12019 * d-namespace.c: Sort headers.
12020 * d-lang.c: Sort headers.
12021 * ctf.c: Sort headers.
12022 * csky-tdep.c: Sort headers.
12023 * csky-linux-tdep.c: Sort headers.
12024 * cris-tdep.c: Sort headers.
12025 * cris-linux-tdep.c: Sort headers.
12026 * cp-valprint.c: Sort headers.
12027 * cp-support.c: Sort headers.
12028 * cp-namespace.c: Sort headers.
12029 * cp-abi.c: Sort headers.
12030 * corelow.c: Sort headers.
12031 * corefile.c: Sort headers.
12032 * continuations.c: Sort headers.
12033 * completer.h: Sort headers.
12034 * completer.c: Sort headers.
12035 * complaints.c: Sort headers.
12036 * coffread.c: Sort headers.
12037 * coff-pe-read.c: Sort headers.
12038 * cli-out.h: Sort headers.
12039 * cli-out.c: Sort headers.
12040 * charset.c: Sort headers.
12041 * c-varobj.c: Sort headers.
12042 * c-valprint.c: Sort headers.
12043 * c-typeprint.c: Sort headers.
12044 * c-lang.c: Sort headers.
12045 * buildsym.c: Sort headers.
12046 * buildsym-legacy.c: Sort headers.
12047 * build-id.h: Sort headers.
12048 * build-id.c: Sort headers.
12049 * btrace.c: Sort headers.
12050 * bsd-uthread.c: Sort headers.
12051 * breakpoint.h: Sort headers.
12052 * breakpoint.c: Sort headers.
12053 * break-catch-throw.c: Sort headers.
12054 * break-catch-syscall.c: Sort headers.
12055 * break-catch-sig.c: Sort headers.
12056 * blockframe.c: Sort headers.
12057 * block.c: Sort headers.
12058 * bfin-tdep.c: Sort headers.
12059 * bfin-linux-tdep.c: Sort headers.
12060 * bfd-target.c: Sort headers.
12061 * bcache.c: Sort headers.
12062 * ax-general.c: Sort headers.
12063 * ax-gdb.h: Sort headers.
12064 * ax-gdb.c: Sort headers.
12065 * avr-tdep.c: Sort headers.
12066 * auxv.c: Sort headers.
12067 * auto-load.c: Sort headers.
12068 * arm-wince-tdep.c: Sort headers.
12069 * arm-tdep.c: Sort headers.
12070 * arm-symbian-tdep.c: Sort headers.
12071 * arm-pikeos-tdep.c: Sort headers.
12072 * arm-obsd-tdep.c: Sort headers.
12073 * arm-nbsd-tdep.c: Sort headers.
12074 * arm-nbsd-nat.c: Sort headers.
12075 * arm-linux-tdep.c: Sort headers.
12076 * arm-linux-nat.c: Sort headers.
12077 * arm-fbsd-tdep.c: Sort headers.
12078 * arm-fbsd-nat.c: Sort headers.
12079 * arm-bsd-tdep.c: Sort headers.
12080 * arch-utils.c: Sort headers.
12081 * arc-tdep.c: Sort headers.
12082 * arc-newlib-tdep.c: Sort headers.
12083 * annotate.h: Sort headers.
12084 * annotate.c: Sort headers.
12085 * amd64-windows-tdep.c: Sort headers.
12086 * amd64-windows-nat.c: Sort headers.
12087 * amd64-tdep.c: Sort headers.
12088 * amd64-sol2-tdep.c: Sort headers.
12089 * amd64-obsd-tdep.c: Sort headers.
12090 * amd64-obsd-nat.c: Sort headers.
12091 * amd64-nbsd-tdep.c: Sort headers.
12092 * amd64-nbsd-nat.c: Sort headers.
12093 * amd64-nat.c: Sort headers.
12094 * amd64-linux-tdep.c: Sort headers.
12095 * amd64-linux-nat.c: Sort headers.
12096 * amd64-fbsd-tdep.c: Sort headers.
12097 * amd64-fbsd-nat.c: Sort headers.
12098 * amd64-dicos-tdep.c: Sort headers.
12099 * amd64-darwin-tdep.c: Sort headers.
12100 * amd64-bsd-nat.c: Sort headers.
12101 * alpha-tdep.c: Sort headers.
12102 * alpha-obsd-tdep.c: Sort headers.
12103 * alpha-nbsd-tdep.c: Sort headers.
12104 * alpha-mdebug-tdep.c: Sort headers.
12105 * alpha-linux-tdep.c: Sort headers.
12106 * alpha-linux-nat.c: Sort headers.
12107 * alpha-bsd-tdep.c: Sort headers.
12108 * alpha-bsd-nat.c: Sort headers.
12109 * aix-thread.c: Sort headers.
12110 * agent.c: Sort headers.
12111 * addrmap.c: Sort headers.
12112 * ada-varobj.c: Sort headers.
12113 * ada-valprint.c: Sort headers.
12114 * ada-typeprint.c: Sort headers.
12115 * ada-tasks.c: Sort headers.
12116 * ada-lang.c: Sort headers.
12117 * aarch64-tdep.c: Sort headers.
12118 * aarch64-ravenscar-thread.c: Sort headers.
12119 * aarch64-newlib-tdep.c: Sort headers.
12120 * aarch64-linux-tdep.c: Sort headers.
12121 * aarch64-linux-nat.c: Sort headers.
12122 * aarch64-fbsd-tdep.c: Sort headers.
12123 * aarch64-fbsd-nat.c: Sort headers.
12124 * aarch32-linux-nat.c: Sort headers.
12125
121262019-04-04 Tom Tromey <tom@tromey.com>
12127
12128 * varobj.c (varobj_create): Update.
12129 * rust-exp.y (struct rust_parser) <update_innermost_block,
12130 lookup_symbol>: New methods.
12131 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12132 Rename.
12133 (rust_parser::rust_lookup_type)
12134 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12135 * printcmd.c (display_command, do_one_display): Update.
12136 * parser-defs.h (struct parser_state) <parser_state>: Add
12137 "tracker" parameter.
12138 (block_tracker): New member.
12139 (class innermost_block_tracker) <innermost_block_tracker>: Add
12140 "types" parameter.
12141 <reset>: Remove method.
12142 (innermost_block): Don't declare.
12143 (null_post_parser): Update.
12144 * parse.c (innermost_block): Remove global.
12145 (write_dollar_variable): Update.
12146 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12147 Remove "tracker_types" parameter.
12148 (parse_expression): Add "tracker" parameter.
12149 (parse_expression_for_completion): Update.
12150 (null_post_parser): Add "tracker" parameter.
12151 * p-exp.y: Update rules.
12152 * m2-exp.y: Update rules.
12153 * language.h (struct language_defn) <la_post_parser>: Add
12154 "tracker" parameter.
12155 * go-exp.y: Update rules.
12156 * f-exp.y: Update rules.
12157 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12158 parameter.
12159 * d-exp.y: Update rules.
12160 * c-exp.y: Update rules.
12161 * breakpoint.c (set_breakpoint_condition): Create an
12162 innermost_block_tracker.
12163 (watch_command_1): Likewise.
12164 * ada-lang.c (resolve): Add "tracker" parameter.
12165 (resolve_subexp): Likewise.
12166 * ada-exp.y (write_var_from_sym): Update.
12167
121682019-04-04 Tom Tromey <tom@tromey.com>
12169
12170 * type-stack.h: New file.
12171 * type-stack.c: New file.
12172 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12173 type-stack.h.
12174 (insert_into_type_stack, insert_type, push_type, push_type_int)
12175 (insert_type_address_space, pop_type, pop_type_int)
12176 (pop_typelist, pop_type_stack, append_type_stack)
12177 (push_type_stack, get_type_stack, push_typelist)
12178 (follow_type_instance_flags, follow_types): Don't declare.
12179 * parse.c (type_stack): Remove global.
12180 (parse_exp_in_context): Update.
12181 (insert_into_type_stack, insert_type, push_type, push_type_int)
12182 (insert_type_address_space, pop_type, pop_type_int)
12183 (pop_typelist, pop_type_stack, append_type_stack)
12184 (push_type_stack, get_type_stack, push_typelist)
12185 (follow_type_instance_flags, follow_types): Remove (moved to
12186 type-stack.c).
12187 * f-exp.y (type_stack): New global.
12188 Update rules.
12189 (push_kind_type, f_parse): Update.
12190 * d-exp.y (type_stack): New global.
12191 Update rules.
12192 (d_parse): Update.
12193 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12194 Update rules.
12195 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12196 (HFILES_NO_SRCDIR): Add type-stack.h.
12197
121982019-04-04 Tom Tromey <tom@tromey.com>
12199
12200 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12201 (rust_parser::convert_ast_to_expression, rust_parse)
12202 (rust_lex_test_completion, rust_lex_tests): Update.
12203 * parser-defs.h (struct expr_completion_state): New.
12204 (struct parser_state) <parser_state>: Add completion parameter.
12205 <mark_struct_expression, mark_completion_tag>: New methods.
12206 <parse_completion, m_completion_state>: New members.
12207 (prefixify_expression, null_post_parser): Update.
12208 (mark_struct_expression, mark_completion_tag): Don't declare.
12209 * parse.c (parse_completion, expout_last_struct)
12210 (expout_tag_completion_type, expout_completion_name): Remove
12211 globals.
12212 (parser_state::mark_struct_expression)
12213 (parser_state::mark_completion_tag): Now methods.
12214 (prefixify_expression): Add last_struct parameter.
12215 (prefixify_subexp): Likewise.
12216 (parse_exp_1): Update.
12217 (parse_exp_in_context): Add cstate parameter. Update.
12218 (parse_expression_for_completion): Create an
12219 expr_completion_state.
12220 (null_post_parser): Add "completion" parameter.
12221 * p-exp.y: Update rules.
12222 (yylex): Update.
12223 * language.h (struct language_defn) <la_post_parser>: Add
12224 "completing" parameter.
12225 * go-exp.y: Update rules.
12226 (lex_one_token): Update.
12227 * expression.h (parse_completion): Don't declare.
12228 * d-exp.y: Update rules.
12229 (lex_one_token): Update rules.
12230 * c-exp.y: Update rules.
12231 (lex_one_token): Update.
12232 * ada-lang.c (resolve): Add "parse_completion" parameter.
12233 (resolve_subexp): Likewise.
12234 (ada_resolve_function): Likewise.
12235
122362019-04-04 Tom Tromey <tom@tromey.com>
12237
12238 * parser-defs.h (struct parser_state) <start_arglist,
12239 end_arglist>: New methods.
12240 <arglist_len, m_funcall_chain>: New members.
12241 (arglist_len, start_arglist, end_arglist): Don't declare.
12242 * parse.c (arglist_len, funcall_chain): Remove global.
12243 (start_arglist, end_arglist): Remove functions.
12244 (parse_exp_in_context): Update.
12245 * p-exp.y: Update rules.
12246 * m2-exp.y: Update rules.
12247 * go-exp.y: Update rules.
12248 * f-exp.y: Update rules.
12249 * d-exp.y: Update rules.
12250 * c-exp.y: Update rules.
12251
122522019-04-04 Tom Tromey <tom@tromey.com>
12253
12254 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12255 lex_operator, push_back>: New methods.
12256 Update all rules.
12257 (rust_parser::lex_hex, lex_escape): Rename and update.
12258 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12259 (rust_parser::lex_operator): Rename and update.
12260 (rust_parser::lex_number, rustyylex, rustyyerror)
12261 (rust_lex_test_init, rust_lex_test_sequence)
12262 (rust_lex_test_push_back, rust_lex_tests): Update.
12263 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12264 parameter.
12265 <lexptr, prev_lexptr>: New members.
12266 (lexptr, prev_lexptr): Don't declare.
12267 * parse.c (lexptr, prev_lexptr): Remove globals.
12268 (parse_exp_in_context): Update.
12269 * p-exp.y (yylex, yyerror): Update.
12270 * m2-exp.y (parse_number, yylex, yyerror): Update.
12271 * go-exp.y (lex_one_token, yyerror): Update.
12272 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12273 * d-exp.y (lex_one_token, yyerror): Update.
12274 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12275 (lex_one_token, yyerror): Update.
12276 * ada-lex.l (YY_INPUT): Update.
12277 (rewind_to_char): Update.
12278 * ada-exp.y (yyerror): Update.
12279
122802019-04-04 Tom Tromey <tom@tromey.com>
12281
12282 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12283 * parser-defs.h (struct parser_state) <parser_state>: Add new
12284 parameter.
12285 <comma_terminates>: New member.
12286 (comma_terminates): Don't declare global.
12287 * parse.c (comma_terminates): Remove global.
12288 (parse_exp_in_context): Update.
12289 * p-exp.y (yylex): Update.
12290 * m2-exp.y (yylex): Update.
12291 * go-exp.y (lex_one_token): Update.
12292 * f-exp.y (yylex): Update.
12293 * d-exp.y (lex_one_token): Update.
12294 * c-exp.y (lex_one_token): Update.
12295 * ada-lex.l: Update.
12296
122972019-04-04 Tom Tromey <tom@tromey.com>
12298
12299 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12300 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12301 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12302 * parser-defs.h (paren_depth): Don't declare.
12303 * parse.c (paren_depth): Remove global.
12304 (parse_exp_in_context): Update.
12305 * p-exp.y (paren_depth): New global.
12306 (pascal_parse): Initialize it.
12307 * m2-exp.y (paren_depth): New global.
12308 (m2_parse): Initialize it.
12309 * go-exp.y (paren_depth): New global.
12310 (go_parse): Initialize it.
12311 * f-exp.y (paren_depth): New global.
12312 (f_parse): Initialize it.
12313 * d-exp.y (paren_depth): New global.
12314 (d_parse): Initialize it.
12315 * c-exp.y (paren_depth): New global.
12316 (c_parse): Initialize it.
12317 * ada-lex.l (paren_depth): New global.
12318 (lexer_init): Initialize it.
12319
123202019-04-04 Tom Tromey <tom@tromey.com>
12321
12322 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12323 (rust_parser::convert_ast_to_type)
12324 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12325 * parser-defs.h (struct parser_state) <parser_state>: Add
12326 parameters. Initialize new members.
12327 <expression_context_block, expression_context_pc>: New members.
12328 * parse.c (expression_context_block, expression_context_pc):
12329 Remove globals.
12330 (parse_exp_in_context): Update.
12331 * p-exp.y: Update all rules.
12332 (yylex): Update.
12333 * m2-exp.y: Update all rules.
12334 (yylex): Update.
12335 * go-exp.y (yylex): Update.
12336 * f-exp.y (yylex): Update.
12337 * d-exp.y: Update all rules.
12338 (yylex): Update.
12339 * c-exp.y: Update all rules.
12340 (lex_one_token, classify_name, yylex, c_parse): Update.
12341 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12342
123432019-04-04 Tom Tromey <tom@tromey.com>
12344
12345 * gdbarch.h, gdbarch.c: Rebuild.
12346 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12347 * stap-probe.h:
12348 (struct stap_parse_info): Replace "parser_state" with
12349 "expr_builder".
12350 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12351 (parser_state): New class.
12352 * parse.c (expr_builder): Rename.
12353 (expr_builder::release): Rename.
12354 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12355 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12356 (write_exp_elt_longcst, write_exp_elt_floatcst)
12357 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12358 (write_exp_string_vector, write_exp_bitstring)
12359 (write_exp_msymbol, mark_struct_expression)
12360 (write_dollar_variable)
12361 (insert_type_address_space, increase_expout_size): Replace
12362 "parser_state" with "expr_builder".
12363 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12364 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12365 "parser_state" with "expr_builder".
12366
123672019-04-04 Tom Tromey <tom@tromey.com>
12368
12369 * rust-exp.y: Replace "parse_language" with method call.
12370 * p-exp.y:
12371 (yylex): Replace "parse_language" with method call.
12372 * m2-exp.y:
12373 (yylex): Replace "parse_language" with method call.
12374 * go-exp.y (classify_name): Replace "parse_language" with method
12375 call.
12376 * f-exp.y (yylex): Replace "parse_language" with method call.
12377 * d-exp.y (lex_one_token): Replace "parse_language" with method
12378 call.
12379 * c-exp.y:
12380 (lex_one_token, classify_name, yylex): Replace "parse_language"
12381 with method call.
12382 * ada-exp.y (find_primitive_type, type_char)
12383 (type_system_address): Replace "parse_language" with method call.
12384
123852019-04-04 Tom Tromey <tom@tromey.com>
12386
12387 * rust-exp.y: Replace "parse_gdbarch" with method call.
12388 * parse.c (write_dollar_variable, insert_type_address_space):
12389 Replace "parse_gdbarch" with method call.
12390 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12391 call.
12392 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12393 call.
12394 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12395 "parse_gdbarch" with method call.
12396 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12397 with method call.
12398 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12399 "parse_gdbarch" with method call.
12400 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12401 "parse_gdbarch" with method call.
12402 * c-exp.y (parse_type, parse_number, classify_name): Replace
12403 "parse_gdbarch" with method call.
12404 * ada-lex.l: Replace "parse_gdbarch" with method call.
12405 * ada-exp.y (parse_type, find_primitive_type, type_char)
12406 (type_system_address): Replace "parse_gdbarch" with method call.
12407
124082019-04-04 Tom Tromey <tom@tromey.com>
12409
12410 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12411 * stap-probe.c (stap_parse_argument): Update.
12412 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12413 initial_size parameter.
12414 * rust-exp.y (rust_lex_tests): Update.
12415 * parse.c (parser_state): Update.
12416 (parse_exp_in_context): Update.
12417 * parser-defs.h (struct parser_state) <parser_state>: Remove
12418 "initial_size" parameter.
12419
124202019-04-04 Tom Tromey <tom@tromey.com>
12421
12422 * parser-defs.h (increase_expout_size): Don't declare.
12423 * parse.c (increase_expout_size): Now static.
12424
124252019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12426
12427 * gnu-nat.c (gnu_nat_target::wait): Fix
12428 target_waitstatus_to_string call.
12429
124302019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12431
12432 * eval.c (evaluate_subexp_standard): Handle internal functions
12433 during Fortran function call handling.
12434
124352019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12436
12437 * NEWS: Mention new internal functions.
12438 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12439 (read_base_type): Use dwarf2_init_complex_target_type.
12440 * value.c (creal_internal_fn): New function.
12441 (cimag_internal_fn): New function.
12442 (_initialize_values): Register new internal functions.
12443
124442019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12445
12446 * infrun.c (stop_all_threads): If debug_infrun, always
12447 trace the wait status after wait_one, using
12448 target_waitstatus_to_string and target_pid_to_str.
12449 (handle_inferior_event): Replace various trace of
12450 wait status kind by a single trace.
12451 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12452 wait status kind image by target_waitstatus_to_string.
12453 * target/waitstatus.c (target_waitstatus_to_string): Fix
12454 obsolete comment.
12455
124562019-04-01 Tom Tromey <tromey@adacore.com>
12457
12458 PR symtab/23331:
12459 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12460
124612019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12462 Pedro Alves <palves@redhat.com>
12463
12464 * top.c (quit_force): Call 'finalize_values'.
12465 * value.c (finalize_values): New function.
12466 * value.h (finalize_values): Declare.
12467
124682019-03-30 Eli Zaretskii <eliz@gnu.org>
12469
12470 * NEWS: Announce $_gdb_major and $_gdb_minor.
12471
12472 * top.c (init_gdb_version_vars): New function.
12473 (gdb_init): Call init_gdb_version_vars.
12474
124752019-03-29 Tom Tromey <tromey@adacore.com>
12476
12477 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12478 help text. Remove dead code.
12479
124802019-03-29 Keith Seitz <keiths@redhat.com>
12481
12482 From Siddhesh Poyarekar:
12483 * f-lang.h (f77_get_upperbound): Return LONGEST.
12484 (f77_get_lowerbound): Likewise.
12485 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12486 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12487 print them.
12488 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12489 plongest to format print it.
12490 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12491 (f77_get_upperbound): Likewise.
12492 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12493 LOWER_BOUND to LONGEST.
12494 (f77_create_arrayprint_offset_tbl): Likewise.
12495
124962019-03-29 Keith Seitz <keiths@redhat.com>
12497
12498 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12499 %s/pulongest for TYPE_LENGTH instead of %d in format
12500 strings.
12501 * ada-typerint.c (ada_print_type): Likewise.
12502 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12503 * compile/compile-c-support.c (generate_register_struct): Likewise.
12504 * gdbtypes.c (recursive_dump_type): Likewise.
12505 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12506 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12507 instead of %d in format strings.
12508 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12509 to std::min to ULONGEST.
12510 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12511 instead of %d in format strings.
12512 * tracepoint.c (info_scope_command): Likewise.
12513 * typeprint.c (print_offset_data::update)
12514 (print_offset_data::finish): Likewise.
12515 * xtensa-tdep.c (xtensa_store_return_value)
12516 (xtensa_push_dummy_call): Likewise.
12517
125182019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12519
12520 * windows-nat.c (display_selector): Fixed format specifications
12521 for 64-bit Cygwin.
12522
125232019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12524
12525 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12526
125272019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12528
12529 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12530 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12531 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12532 (nios2_linux_init_abi): Install it.
12533
125342019-03-28 Alan Hayward <alan.hayward@arm.com>
12535
12536 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12537
125382019-03-28 Alan Hayward <alan.hayward@arm.com>
12539
12540 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12541
125422019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12543 Tom Tromey <tromey@adacore.com>
12544
12545 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12546
125472019-03-26 Joel Brobecker <brobecker@adacore.com>
12548
12549 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12550 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12551 method to compute the bounds of range types. Also print "[evaluated]"
12552 if the bounds' values come from a dynamic evaluation.
12553
125542019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12555
12556 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12557 whitespace when pretty printing is on.
12558
125592019-03-26 Alan Hayward <alan.hayward@arm.com>
12560
12561 * ppc-linux-nat.c: Add include.
12562
125632019-03-26 Alan Hayward <alan.hayward@arm.com>
12564
12565 * NEWS: Mention AArch64 Pointer Authentication.
12566
125672019-03-26 Alan Hayward <alan.hayward@arm.com>
12568
12569 * arm-linux-nat.c: Add include.
12570
125712019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12572
12573 * source-cache.c (source_cache::get_source_lines): Re-read
12574 fullname after calling open_source_file.
12575
125762019-03-25 John Baldwin <jhb@FreeBSD.org>
12577
12578 * NEWS: Mention TLS support for FreeBSD.
12579
125802019-03-25 Tom Tromey <tromey@adacore.com>
12581
12582 * minsyms.c (BUNCH_SIZE): Update comment.
12583 (~minimal_symbol_reader): Remove old comment.
12584 (compact_minimal_symbols): Update comment.
12585 (minimal_symbol_reader::install): Remove old comment. Update
12586 other comments.
12587
125882019-03-25 Alan Hayward <alan.hayward@arm.com>
12589
12590 * s390-linux-nat.c: Add include.
12591
125922019-03-25 Alan Hayward <alan.hayward@arm.com>
12593
12594 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12595 Call linux_get_hwcap.
12596 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12597 Likewise.
12598 (aarch64_linux_get_hwcap): Remove function.
12599 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12600 declaration.
12601 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12602 linux_get_hwcap.
12603 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12604 * linux-tdep.c (linux_get_hwcap): Add function.
12605 (linux_get_hwcap2): Likewise.
12606 * linux-tdep.h (linux_get_hwcap): Add declaration.
12607 (linux_get_hwcap2): Likewise.
12608 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12609 (ppc_linux_get_hwcap2): Likewise.
12610 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12611 linux_get_hwcap.
12612 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12613 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12614 (ppc_linux_nat_target::read_description): Likewise.
12615 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12616 * s390-linux-nat.c: Likewise.
12617 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12618
126192019-03-24 Tom Tromey <tom@tromey.com>
12620
12621 * ada-lang.c (standard_lookup): Simplify initialization.
12622 (ada_lookup_symbol_nonlocal): Simplify return.
12623 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12624 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12625 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12626 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12627 initialization.
12628 * solib.c (solib_global_lookup): Simplify.
12629 * symtab.c (null_block_symbol): Remove.
12630 (symbol_cache_lookup): Simplify returns.
12631 (lookup_language_this): Simplify returns.
12632 (lookup_symbol_aux): Simplify return.
12633 (lookup_local_symbol): Simplify returns.
12634 (lookup_global_symbol_from_objfile): Simplify return.
12635 (lookup_symbol_in_objfile_symtabs)
12636 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12637 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12638 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12639 * cp-namespace.c (cp_lookup_bare_symbol)
12640 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12641 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12642 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12643 (cp_lookup_symbol_via_imports): Simplify initialization.
12644 (find_symbol_in_baseclass): Likewise.
12645 * symtab.h (null_block_symbol): Remove.
12646 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12647 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12648 (d_lookup_symbol_module): Likewise.
12649 (find_symbol_in_baseclass): Simplify initialization.
12650
126512019-03-24 Tom Tromey <tom@tromey.com>
12652
12653 * expression.h: Don't include symtab.h.
12654 (struct block): Forward declare.
12655
126562019-03-24 Tom Tromey <tom@tromey.com>
12657
12658 * c-exp.y (typebase): Remove casts.
12659 * gdbtypes.c (lookup_unsigned_typename, )
12660 (lookup_signed_typename): Remove cast.
12661 * eval.c (parse_to_comma_and_eval): Remove cast.
12662 * parse.c (write_dollar_variable): Remove cast.
12663 * block.h (struct block) <superblock>: Now const.
12664 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12665 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12666 (map_block): Make "block" const.
12667 * symfile.h (struct quick_symbol_functions)
12668 <map_matching_symbols>: Constify block argument to "callback".
12669 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12670 const.
12671 (find_pc_sect_compunit_symtab): Make "b" const.
12672 (find_symbol_at_address): Likewise.
12673 (search_symbols): Likewise.
12674 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12675 (dw2_debug_names_lookup_symbol): Likewise.
12676 (dw2_map_matching_symbols): Update.
12677 * p-valprint.c (pascal_val_print): Remove "block".
12678 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12679 (aux_add_nonlocal_symbols): Make "block" const.
12680 (resolve_subexp): Remove cast.
12681 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12682 const.
12683 (iterate_over_file_blocks): Likewise.
12684 * f-exp.y (%union) <bval>: Remove.
12685 * coffread.c (patch_opaque_types): Make "b" const.
12686 * spu-tdep.c (spu_catch_start): Make "block" const.
12687 * c-valprint.c (print_unpacked_pointer): Remove "block".
12688 * symmisc.c (dump_symtab_1): Make "b" const.
12689 (block_depth): Make "block" const.
12690 * d-exp.y (%union) <bval>: Remove.
12691 * cp-support.h (cp_lookup_rtti_type): Update.
12692 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12693 * psymtab.c (psym_lookup_symbol): Make "block" const.
12694 (maintenance_check_psymtabs): Make "b" const.
12695 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12696 (enumerate_locals, enumerate_args): Update.
12697 * python/py-symtab.c (stpy_global_block): Make "block" const.
12698 (stpy_static_block): Likewise.
12699 * inline-frame.c (block_starting_point_at): Make "new_block"
12700 const.
12701 * block.c (find_block_in_blockvector): Make return type const.
12702 (blockvector_for_pc_sect): Make "b" const.
12703 (find_block_in_blockvector): Make "b" const.
12704
127052019-03-23 Tom Tromey <tom@tromey.com>
12706
12707 * varobj.c (varobj_create): Update.
12708 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12709 * printcmd.c (display_command, do_one_display): Don't reset
12710 innermost_block.
12711 * parser-defs.h (enum innermost_block_tracker_type): Move to
12712 expression.h.
12713 (innermost_block): Update comment.
12714 * parse.c (parse_exp_1): Add tracker_types parameter.
12715 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12716 tracker_types parameter. Reset innermost_block.
12717 (parse_exp_in_context): Remove.
12718 (parse_expression_for_completion): Update.
12719 * objfiles.c (~objfile): Don't reset expression_context_block or
12720 innermost_block.
12721 * expression.h (enum innermost_block_tracker_type): Move from
12722 parser-defs.h.
12723 (parse_exp_1): Add tracker_types parameter.
12724 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12725 reset innermost_block.
12726
127272019-03-23 Tom Tromey <tom@tromey.com>
12728
12729 * objfiles.h: Include bcache.h.
12730
127312019-03-23 Tom Tromey <tom@tromey.com>
12732
12733 * linespec.c (get_current_search_block): Use
12734 scoped_restore_current_language.
12735 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12736
127372019-03-22 Alan Hayward <alan.hayward@arm.com>
12738 Jiong Wang <jiong.wang@arm.com>
12739
12740 * aarch64-linux-tdep.c
12741 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12742 section.
12743 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12744
127452019-03-22 Alan Hayward <alan.hayward@arm.com>
12746 Jiong Wang <jiong.wang@arm.com>
12747
12748 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12749 instructions.
12750 (aarch64_analyze_prologue_test): Add PACIASP test.
12751 (aarch64_prologue_prev_register): Unmask PC value.
12752
127532019-03-22 Alan Hayward <alan.hayward@arm.com>
12754 Jiong Wang <jiong.wang@arm.com>
12755
12756 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12757 (aarch64_dwarf2_prev_register): Unmask PC value.
12758 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12759 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12760 DW_CFA_AARCH64_negate_ra_state.
12761 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12762
127632019-03-22 Alan Hayward <alan.hayward@arm.com>
12764 Jiong Wang <jiong.wang@arm.com>
12765
12766 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12767 registers.
12768 (aarch64_pseudo_register_name): Likewise.
12769 (aarch64_pseudo_register_type): Likewise.
12770 (aarch64_pseudo_register_reggroup_p): Likewise.
12771 (aarch64_gdbarch_init): Add pauth registers.
12772 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12773 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12774 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12775 (struct gdbarch_tdep): Add regnum for ra_state.
12776
127772019-03-22 Alan Hayward <alan.hayward@arm.com>
12778 Jiong Wang <jiong.wang@arm.com>
12779
12780 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12781
127822019-03-22 Alan Hayward <alan.hayward@arm.com>
12783 Jiong Wang <jiong.wang@arm.com>
12784
12785 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12786 function.
12787 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12788 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12789 (aarch64_gdbarch_init): Add puth registers.
12790 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12791 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12792 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12793
127942019-03-22 Alan Hayward <alan.hayward@arm.com>
12795 Jiong Wang <jiong.wang@arm.com>
12796
12797 * aarch64-linux-nat.c
12798 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12799 * aarch64-linux-tdep.c
12800 (aarch64_linux_core_read_description): Likewise.
12801 (aarch64_linux_get_hwcap): New function.
12802 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12803 (aarch64_linux_get_hwcap): New declaration.
12804
128052019-03-22 Alan Hayward <alan.hayward@arm.com>
12806 Jiong Wang <jiong.wang@arm.com>
12807
12808 * aarch64-linux-nat.c
12809 (aarch64_linux_nat_target::read_description): Add pauth param.
12810 * aarch64-linux-tdep.c
12811 (aarch64_linux_core_read_description): Likewise.
12812 * aarch64-tdep.c (struct target_desc): Add in pauth.
12813 (aarch64_read_description): Add pauth param.
12814 (aarch64_gdbarch_init): Likewise.
12815 * aarch64-tdep.h (aarch64_read_description): Likewise.
12816 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12817 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12818 * features/Makefile: Add new files.
12819 * features/aarch64-pauth.c: New file.
12820 * features/aarch64-pauth.xml: New file.
12821
128222019-03-20 Tom Tromey <tromey@adacore.com>
12823
12824 * infrun.c (handle_inferior_event): Rename from
12825 handle_inferior_event_1. Create a scoped_value_mark.
12826 (handle_inferior_event): Remove.
12827
128282019-03-19 Tom Tromey <tromey@adacore.com>
12829
12830 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12831 * infrun.h (print_stop_event): Add "displays" parameter.
12832 * infrun.c (print_stop_event): Add "displays" parameter.
12833
128342019-03-19 Pedro Alves <palves@redhat.com>
12835
12836 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12837 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12838 to -1. Fix TABs vs spaces.
12839 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12840 * tui/tui-out.h (tui_ui_out) Add intro comments.
12841 <m_line, m_start_of_line>: In-class initialize, and add describing
12842 comment.
12843
128442019-03-18 Alan Hayward <alan.hayward@arm.com>
12845
12846 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12847 variable names.
12848 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12849
128502019-03-18 Pedro Alves <palves@redhat.com>
12851 Eli Zaretskii <eliz@gnu.org>
12852
12853 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12854 m_line and m_start_of_line.
12855
128562019-03-18 Eli Zaretskii <eliz@gnu.org>
12857
12858 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12859 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12860 it returns a newline. This fixes a regression in TU mode, whereby
12861 the next line is output on the same screen line as the user input.
12862
128632019-03-18 Tom Tromey <tromey@adacore.com>
12864
12865 * minsyms.c (minimal_symbol_reader::install): Remove call to
12866 obstack_blank.
12867
128682019-03-18 Pedro Alves <palves@redhat.com>
12869
12870 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12871 New globals.
12872 (apply_style): New, factored out from ...
12873 (apply_ansi_escape): ... this. Handle reverse video mode.
12874 (tui_set_reverse_mode): New function.
12875 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12876 * tui/tui-winsource.c (tui_show_source_line): Use
12877 tui_set_reverse_mode instead of setting A_STANDOUT.
12878 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12879 New setter methods.
12880
128812019-03-18 Hannes Domani <ssbssa@yahoo.de>
12882
12883 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12884 Handle tabs.
12885
128862019-03-18 Tom Tromey <tromey@adacore.com>
12887
12888 * ada-lang.c (empty_array): Add "high" parameter.
12889 (ada_evaluate_subexp): Update.
12890
128912019-03-17 Sergei Trofimovich <siarheit@google.com>
12892
12893 * unittests/string_view-selftests.c: Define
12894 _initialize_string_view_selftests unconditionally.
12895
128962019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12897
12898 PR gdb/24350
12899 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12900
129012019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12902
12903 PR gdb/24351
12904 * windows-nat.c (display_selector): Fix format specifiers.
12905
129062019-03-17 Eli Zaretskii <eliz@gnu.org>
12907
12908 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12909 tui_refill_source_window instead of tui_refresh_win, to update the
12910 current execution line. This fixes redisplay of the current line
12911 when stepping through the code with "next" or "step".
12912
129132019-03-16 Eli Zaretskii <eliz@gnu.org>
12914
12915 * source-cache.c (source_cache::get_source_lines): Call
12916 find_source_lines to initialize s->nlines. This fixes vertical
12917 scrolling of TUI source window when the DOWN arrow is pressed.
12918
129192019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12920
12921 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12922 linux-thread-db.c (_initialize_thread_db): Likewise.
12923
129242019-03-16 Eli Zaretskii <eliz@gnu.org>
12925
12926 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12927 wclrtoeol in tui_show_source_line". This reverts changes made in
12928 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12929
129302019-03-15 Tom Tromey <tom@tromey.com>
12931
12932 * symtab.h (struct minimal_symbol): Derive from
12933 general_symbol_info.
12934 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12935 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12936 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12937 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12938 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12939 (MSYMBOL_SEARCH_NAME): Update.
12940 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12941 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12942 * minsyms.c (minimal_symbol_reader::record_full): Update.
12943
129442019-03-15 Tom Tromey <tom@tromey.com>
12945
12946 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12947
129482019-03-15 Tom Tromey <tom@tromey.com>
12949
12950 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12951 unique_xmalloc_ptr.
12952 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12953 Update.
12954 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12955 (build_minimal_symbol_hash_tables)
12956 (minimal_symbol_reader::install): Update.
12957
129582019-03-15 Tom Tromey <tom@tromey.com>
12959
12960 * symtab.c (create_demangled_names_hash): Update.
12961 (symbol_set_names): Update.
12962 * objfiles.h (struct objfile_per_bfd_storage)
12963 <demangled_names_hash>: Now an htab_up.
12964 * objfiles.c (objfile_per_bfd_storage): Simplify.
12965
129662019-03-15 Tom Tromey <tom@tromey.com>
12967
12968 * objfiles.h (struct objfile_per_bfd_storage): Declare
12969 destructor.
12970 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12971 New.
12972 (get_objfile_bfd_data): Use new. Don't initialize
12973 language_of_main.
12974 (free_objfile_per_bfd_storage): Remove.
12975 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12976
129772019-03-15 Tom Tromey <tom@tromey.com>
12978
12979 * symfile.c (reread_symbols): Update.
12980 * objfiles.c (objfile::objfile): Update.
12981 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12982 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12983 comment.
12984 (minimal_symbol_reader::install): Update.
12985 (terminate_minimal_symbol_table): Remove.
12986 * jit.c (jit_object_close_impl): Update.
12987
129882019-03-15 Tom Tromey <tom@tromey.com>
12989
12990 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12991 initializations.
12992
129932019-03-15 Tom Tromey <tom@tromey.com>
12994
12995 * objfiles.h (struct objfile_per_bfd_storage)
12996 <demangled_hash_languages>: Now a bitset.
12997 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12998 (lookup_minimal_symbol): Update.
12999
130002019-03-15 Tom Tromey <tom@tromey.com>
13001
13002 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13003 Don't return the symbol.
13004 * coffread.c (record_minimal_symbol): Use record_full.
13005
130062019-03-14 Eli Zaretskii <eliz@gnu.org>
13007
13008 The MS-Windows port of ncurses fails to switch to a color pair if
13009 one or both of the colors are the implicit default colors. This
13010 change records the default colors when TUI is initialized, and
13011 then specifies them explicitly when a color pair uses the default
13012 colors. This allows color styling in TUI mode on MS-Windows.
13013
13014 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13015 ncurses_norm_attr.
13016 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13017 colors in ncurses_norm_attr.
13018 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13019 "none", replace it with the default color recorded in
13020 ncurses_norm_attr.
13021
130222019-03-14 Tom Tromey <tromey@adacore.com>
13023
13024 * source-cache.h (class source_cache) <get_source_lines>: Return
13025 std::string.
13026 * source-cache.c (source_cache::extract_lines): Handle case where
13027 first_pos==npos. Return std::string.
13028 (source_cache::get_source_lines): Update.
13029
130302019-03-14 Tom Tromey <tromey@adacore.com>
13031
13032 * NEWS: Add item for "style sources" commands.
13033 * source-cache.c (source_cache::get_source_lines): Check
13034 source_styling.
13035 * cli/cli-style.c (source_styling): New global.
13036 (_initialize_cli_style): Add "style sources" commands.
13037 (show_style_sources): New function.
13038 * cli/cli-style.h (source_styling): Declare.
13039
130402019-03-14 Pedro Alves <palves@redhat.com>
13041 Tom Tromey <tromey@adacore.com>
13042
13043 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13044 * tui/tui-winsource.c (tui_refill_source_window): New function,
13045 from...
13046 (tui_horizontal_source_scroll): ... here. Move some logic.
13047 * cli/cli-style.c (set_style_enabled): Notify new observable.
13048 * tui/tui-hooks.c (tui_redisplay_source): New function.
13049 (tui_attach_detach_observers): Attach or detach
13050 tui_redisplay_source.
13051 * observable.h (source_styling_changed): New observable.
13052 * observable.c: Define source_styling_changed observable.
13053
130542019-03-13 Tom Tromey <tromey@adacore.com>
13055
13056 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13057 (i386_gnu_nat_target::store_registers): Update.
13058 * target-debug.h (target_debug_print_std_string): New macro.
13059 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13060 * windows-tdep.c (display_one_tib): Update.
13061 * tui/tui-stack.c (tui_make_status_line): Update.
13062 * top.c (print_inferior_quit_action): Update.
13063 * thread.c (thr_try_catch_cmd): Update.
13064 (add_thread_with_info): Update.
13065 (thread_target_id_str): Update.
13066 (thr_try_catch_cmd): Update.
13067 (thread_command): Update.
13068 (thread_find_command): Update.
13069 * record-btrace.c (record_btrace_target::info_record)
13070 (record_btrace_resume_thread, record_btrace_target::resume)
13071 (record_btrace_cancel_resume, record_btrace_step_thread)
13072 (record_btrace_target::wait, record_btrace_target::wait)
13073 (record_btrace_target::wait, record_btrace_target::stop): Update.
13074 * progspace.c (print_program_space): Update.
13075 * process-stratum-target.c
13076 (process_stratum_target::thread_address_space): Update.
13077 * linux-fork.c (linux_fork_mourn_inferior)
13078 (detach_checkpoint_command, info_checkpoints_command)
13079 (linux_fork_context): Update.
13080 (linux_fork_detach): Update.
13081 (class scoped_switch_fork_info): Update.
13082 (delete_checkpoint_command): Update.
13083 * infrun.c (follow_fork_inferior): Update.
13084 (follow_fork_inferior): Update.
13085 (proceed_after_vfork_done): Update.
13086 (handle_vfork_child_exec_or_exit): Update.
13087 (follow_exec): Update.
13088 (displaced_step_prepare_throw): Update.
13089 (displaced_step_restore): Update.
13090 (start_step_over): Update.
13091 (resume_1): Update.
13092 (clear_proceed_status_thread): Update.
13093 (proceed): Update.
13094 (print_target_wait_results): Update.
13095 (do_target_wait): Update.
13096 (context_switch): Update.
13097 (stop_all_threads): Update.
13098 (restart_threads): Update.
13099 (finish_step_over): Update.
13100 (handle_signal_stop): Update.
13101 (switch_back_to_stepped_thread): Update.
13102 (keep_going_pass_signal): Update.
13103 (print_exited_reason): Update.
13104 (normal_stop): Update.
13105 * inferior.c (inferior_pid_to_str): Change return type.
13106 (print_selected_inferior): Update.
13107 (add_inferior): Update.
13108 (detach_inferior): Update.
13109 * dummy-frame.c (fprint_dummy_frames): Update.
13110 * dcache.c (dcache_info_1): Update.
13111 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13112 (btrace_fetch, btrace_clear): Update.
13113 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13114 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13115 type.
13116 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13117 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13118 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13119 * gdbarch.c, gdbarch.h: Rebuild.
13120 * gdbarch.sh (core_pid_to_str): Change return type.
13121 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13122 return type.
13123 (windows_nat_target::pid_to_str): Change return type.
13124 (windows_delete_thread): Update.
13125 (windows_nat_target::attach): Update.
13126 (windows_nat_target::files_info): Update.
13127 * target-delegates.c: Rebuild.
13128 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13129 return type.
13130 (sol_thread_target::pid_to_str): Change return type.
13131 * remote.c (class remote_target) <pid_to_str>: Change return
13132 type.
13133 (remote_target::pid_to_str): Change return type.
13134 (extended_remote_target::attach, remote_target::remote_stop_ns)
13135 (remote_target::remote_notif_remove_queued_reply)
13136 (remote_target::push_stop_reply, remote_target::disable_btrace):
13137 Update.
13138 (extended_remote_target::attach): Update.
13139 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13140 type.
13141 (gdbsim_target::pid_to_str): Change return type.
13142 * ravenscar-thread.c (struct ravenscar_thread_target)
13143 <pid_to_str>: Change return type.
13144 (ravenscar_thread_target::pid_to_str): Change return type.
13145 * procfs.c (class procfs_target) <pid_to_str>: Change return
13146 type.
13147 (procfs_target::pid_to_str): Change return type.
13148 (procfs_target::attach): Update.
13149 (procfs_target::detach): Update.
13150 (procfs_target::fetch_registers): Update.
13151 (procfs_target::store_registers): Update.
13152 (procfs_target::wait): Update.
13153 (procfs_target::files_info): Update.
13154 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13155 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13156 return type.
13157 (nto_procfs_target::pid_to_str): Change return type.
13158 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13159 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13160 return type.
13161 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13162 (exit_lwp): Update.
13163 (attach_proc_task_lwp_callback, get_detach_signal)
13164 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13165 (linux_nat_target::resume, wait_lwp, stop_callback)
13166 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13167 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13168 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13169 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13170 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13171 type.
13172 (inf_ptrace_target::attach): Update.
13173 (inf_ptrace_target::files_info): Update.
13174 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13175 type.
13176 (go32_nat_target::pid_to_str): Change return type.
13177 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13178 (gnu_nat_target::wait): Update.
13179 (gnu_nat_target::wait): Update.
13180 (gnu_nat_target::resume): Update.
13181 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13182 (fbsd_nat_target::wait): Update.
13183 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13184 type.
13185 (darwin_nat_target::attach): Update.
13186 * corelow.c (class core_target) <pid_to_str>: Change return type.
13187 (core_target::pid_to_str): Change return type.
13188 * target.c (normal_pid_to_str): Change return type.
13189 (default_pid_to_str): Likewise.
13190 (target_pid_to_str): Change return type.
13191 (target_translate_tls_address): Update.
13192 (target_announce_detach): Update.
13193 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13194 return type.
13195 (bsd_uthread_target::pid_to_str): Change return type.
13196 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13197 type.
13198 (bsd_kvm_target::pid_to_str): Change return type.
13199 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13200 return type.
13201 (aix_thread_target::pid_to_str): Change return type.
13202 * target.h (struct target_ops) <pid_to_str>: Change return type.
13203 (target_pid_to_str, normal_pid_to_str): Likewise.
13204 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13205 type.
13206 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13207 type.
13208 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13209 return type.
13210 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13211 type.
13212 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13213 type.
13214 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13215 return type.
13216
132172019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13218
13219 * NEWS: Mention that the new default MI version is 3. Mention
13220 changes to the output of commands and events that deal with
13221 multi-location breakpoints.
13222 * breakpoint.c: Include "mi/mi-out.h".
13223 (print_one_breakpoint): Change output syntax if using MI version
13224 >= 3.
13225 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13226 New.
13227 (mi_multi_location_breakpoint_output_fixed): New.
13228 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13229 (mi_cmd_fix_multi_location_breakpoint_output): New.
13230 (mi_multi_location_breakpoint_output_fixed): New.
13231 * mi/mi-cmds.c (mi_cmds): Register command
13232 -fix-multi-location-breakpoint-output.
13233 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13234 interpreter "mi".
13235
132362019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13237
13238 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13239 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13240 instantiate mi_ui_out based on interpreter name.
13241 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13242 * mi/mi-main.c (mi_load_progress): Likewise.
13243
132442019-03-12 John Baldwin <jhb@FreeBSD.org>
13245
13246 * NEWS: Combine separate "New targets" sections for 8.3.
13247
132482019-03-12 John Baldwin <jhb@FreeBSD.org>
13249
13250 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13251 (ppcfbsd_init_abi): Install gdbarch
13252 "fetch_tls_load_module_address" and "get_thread_local_address"
13253 methods.
13254
132552019-03-12 John Baldwin <jhb@FreeBSD.org>
13256
13257 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13258 (riscv_fbsd_init_abi): Install gdbarch
13259 "fetch_tls_load_module_address" and "get_thread_local_address"
13260 methods.
13261
132622019-03-12 John Baldwin <jhb@FreeBSD.org>
13263
13264 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13265 (i386fbsd_init_abi): Install gdbarch
13266 "fetch_tls_load_module_address" and "get_thread_local_address"
13267 methods.
13268
132692019-03-12 John Baldwin <jhb@FreeBSD.org>
13270
13271 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13272 (amd64fbsd_init_abi): Install gdbarch
13273 "fetch_tls_load_module_address" and "get_thread_local_address"
13274 methods.
13275
132762019-03-12 John Baldwin <jhb@FreeBSD.org>
13277
13278 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13279 (struct fbsd_pspace_data): New type.
13280 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13281 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13282 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13283 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13284 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13285
132862019-03-12 John Baldwin <jhb@FreeBSD.org>
13287
13288 * gdbtypes.c (lookup_struct_elt): New function.
13289 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13290 * gdbtypes.h (struct struct_elt): New type.
13291 (lookup_struct_elt): New prototype.
13292
132932019-03-12 John Baldwin <jhb@FreeBSD.org>
13294
13295 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13296 remove disabled code block.
13297
132982019-03-12 John Baldwin <jhb@FreeBSD.org>
13299
13300 * gdbarch.sh (get_thread_local_address): New method.
13301 * gdbarch.h, gdbarch.c: Regenerate.
13302 * target.c (target_translate_tls_address): Use
13303 gdbarch_get_thread_local_address if present instead of
13304 target::get_thread_local_address.
13305
133062019-03-12 John Baldwin <jhb@FreeBSD.org>
13307
13308 * target.h (target::get_thread_local_address): Update comment.
13309
133102019-03-12 John Baldwin <jhb@FreeBSD.org>
13311
13312 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13313 objfile->separate_debug_objfile_backlink if not NULL.
13314
133152019-03-12 John Baldwin <jhb@FreeBSD.org>
13316
13317 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13318 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13319 (amd64bsd_store_inferior_registers): Likewise.
13320 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13321 Enable segment base registers.
13322 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13323 PT_GETFSBASE and PT_GETGSBASE.
13324 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13325 PT_SETGSBASE.
13326 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13327 segment base registers.
13328 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13329
133302019-03-12 John Baldwin <jhb@FreeBSD.org>
13331
13332 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13333 Update calls to i386_target_description to add 'segments'
13334 parameter.
13335 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13336 add segment base registers.
13337 * arch/i386.c (i386_create_target_description): Add 'segments'
13338 parameter to enable segment base registers.
13339 * arch/i386.h (i386_create_target_description): Likewise.
13340 * features/i386/32bit-segments.xml: New file.
13341 * features/i386/32bit-segments.c: Generate.
13342 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13343 call to i386_target_description to add 'segments' parameter.
13344 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13345 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13346 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13347 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13348 if feature is present.
13349 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13350 Add 'segments' parameter to call to i386_target_description.
13351 (i386_target_description): Add 'segments' parameter to enable
13352 segment base registers.
13353 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13354 to call to i386_target_description.
13355 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13356 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13357 Define I386_NUM_REGS.
13358 (i386_target_description): Add 'segments' parameter to enable
13359 segment base registers.
13360
133612019-03-12 Eli Zaretskii <eliz@gnu.org>
13362
13363 PR/24325
13364 * source-cache.c: #undef open and close, to avoid unresolved
13365 externals during linking.
13366
133672019-03-12 Tom Tromey <tromey@adacore.com>
13368
13369 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13370 const. Add initializers.
13371 (_initialize_remote): Don't initialize ptid globals.
13372
133732019-03-12 Pedro Alves <palves@redhat.com>
13374
13375 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13376
133772019-03-12 Pedro Alves <palves@redhat.com>
13378
13379 * cp-name-parser.y (main): Remove unused 'len' variable.
13380
133812019-03-12 Tom Tromey <tromey@adacore.com>
13382
13383 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13384 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13385
133862019-03-12 Tom Tromey <tromey@adacore.com>
13387
13388 * linux-nat.c (iterate_over_lwps): Update.
13389 (stop_callback): Remove parameter.
13390 (stop_wait_callback, detach_callback, resume_set_callback)
13391 (select_singlestep_lwp_callback, set_ignore_sigint)
13392 (status_callback, resumed_callback, resume_clear_callback)
13393 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13394 data parameter.
13395 (linux_nat_target::detach, linux_nat_target::resume)
13396 (linux_stop_and_wait_all_lwps, select_event_lwp)
13397 (linux_nat_filter_event, linux_nat_wait_1)
13398 (linux_nat_target::kill, linux_nat_target::stop)
13399 (linux_nat_target::stop): Update.
13400 (linux_nat_resume_callback): Change type.
13401 (resume_stopped_resumed_lwps, count_events_callback)
13402 (select_event_lwp_callback): Likewise.
13403 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13404 * arm-linux-nat.c (struct update_registers_data): Remove.
13405 (update_registers_callback): Change type.
13406 (arm_linux_insert_hw_breakpoint1): Update.
13407 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13408 parameter.
13409 (x86_linux_dr_set_addr): Update.
13410 (x86_linux_dr_set_control): Update.
13411 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13412 (iterate_over_lwps): Use gdb::function_view.
13413 * nat/aarch64-linux-hw-point.c (struct
13414 aarch64_dr_update_callback_param): Remove.
13415 (debug_reg_change_callback): Change type.
13416 (aarch64_notify_debug_reg_change): Update.
13417 * s390-linux-nat.c (s390_refresh_per_info): Update.
13418
134192019-03-11 Tom Tromey <tromey@adacore.com>
13420
13421 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13422 redundant assignment to "this_cu".
13423
134242019-03-08 Simon Marchi <simon.marchi@efficios.com>
13425
13426 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13427
134282019-03-08 Simon Marchi <simon.marchi@efficios.com>
13429
13430 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13431 from...
13432 (rank_one_type): ... this.
13433
134342019-03-08 Simon Marchi <simon.marchi@efficios.com>
13435
13436 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13437 from...
13438 (rank_one_type): ... this.
13439
134402019-03-08 Simon Marchi <simon.marchi@efficios.com>
13441
13442 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13443 from...
13444 (rank_one_type): ... this.
13445
134462019-03-08 Simon Marchi <simon.marchi@efficios.com>
13447
13448 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13449 from...
13450 (rank_one_type): ... this.
13451
134522019-03-08 Simon Marchi <simon.marchi@efficios.com>
13453
13454 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13455 from...
13456 (rank_one_type): ... this.
13457
134582019-03-08 Simon Marchi <simon.marchi@efficios.com>
13459
13460 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13461 from...
13462 (rank_one_type): ... this.
13463
134642019-03-08 Simon Marchi <simon.marchi@efficios.com>
13465
13466 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13467 from...
13468 (rank_one_type): ... this.
13469
134702019-03-08 Simon Marchi <simon.marchi@efficios.com>
13471
13472 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13473 from...
13474 (rank_one_type): ... this.
13475
134762019-03-08 Simon Marchi <simon.marchi@efficios.com>
13477
13478 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13479 from...
13480 (rank_one_type): ... this.
13481
134822019-03-08 Simon Marchi <simon.marchi@efficios.com>
13483
13484 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13485 from...
13486 (rank_one_type): ... this.
13487
134882019-03-08 Simon Marchi <simon.marchi@efficios.com>
13489
13490 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13491 from...
13492 (rank_one_type): ... this.
13493
134942019-03-08 Simon Marchi <simon.marchi@efficios.com>
13495
13496 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13497 from...
13498 (rank_one_type): ... this.
13499
135002019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13501
13502 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13503 inferior-events' shows the example events.
13504
135052019-03-08 Eli Zaretskii <eliz@gnu.org>
13506
13507 Support styling on native MS-Windows console
13508
13509 PR/24315
13510 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13511 on MS-Windows if $TERM is not defined.
13512
13513 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13514
13515 * posix-hdep.c (gdb_console_fputs):
13516 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13517 functions.
13518 * ui-file.h (gdb_console_fputs): Add prototype.
13519
13520 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13521 back to fputs only if the former returns zero.
13522
135232019-03-07 Tom Tromey <tom@tromey.com>
13524
13525 * symmisc.c (print_symbol_bcache_statistics): Update.
13526 (print_objfile_statistics): Update.
13527 * symfile.c (allocate_symtab): Update.
13528 * stabsread.c: Don't include bcache.h.
13529 * psymtab.h (struct psymbol_bcache): Don't declare.
13530 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13531 (psymbol_bcache_init, psymbol_bcache_free)
13532 (psymbol_bcache_get_bcache): Don't declare.
13533 * psymtab.c (struct psymbol_bcache): Remove.
13534 (psymtab_storage::psymtab_storage): Update.
13535 (psymtab_storage::~psymtab_storage): Update.
13536 (psymbol_bcache_init, psymbol_bcache_free)
13537 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13538 (add_psymbol_to_bcache): Update.
13539 (allocate_psymtab): Update.
13540 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13541 macro_cache>: No longer pointers.
13542 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13543 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13544 * macrotab.c (macro_bcache): Update.
13545 * macroexp.c: Don't include bcache.h.
13546 * gdbtypes.c (check_types_worklist): Update.
13547 (types_deeply_equal): Remove TRY/CATCH. Update.
13548 * elfread.c (elf_symtab_read): Update.
13549 * dwarf2read.c: Don't include bcache.h.
13550 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13551 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13552 (print_bcache_statistics, bcache_memory_used): Don't declare.
13553 (struct bcache): Move from bcache.c. Add constructor, destructor,
13554 methods. Rename all data members.
13555 * bcache.c (struct bcache): Move to bcache.h.
13556 (bcache::expand_hash_table): Rename from expand_hash_table.
13557 (bcache): Remove.
13558 (bcache::insert): Rename from bcache_full.
13559 (bcache::compare): Rename from bcache_compare.
13560 (bcache_xmalloc): Remove.
13561 (bcache::~bcache): Rename from bcache_xfree.
13562 (bcache::print_statistics): Rename from print_bcache_statistics.
13563 (bcache::memory_used): Rename from bcache_memory_used.
13564
135652019-03-07 Pedro Alves <palves@redhat.com>
13566
13567 * infrun.c (normal_stop): Also check for
13568 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13569
135702019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13571
13572 * f-lang.c (value_from_host_double): Moved to...
13573 * value.c (value_from_host_double): ...here.
13574 * value.h (value_from_host_double): Declare.
13575 * guile/scm-math.c (vlscm_convert_typed_number): Use
13576 value_from_host_double.
13577 (vlscm_convert_number): Likewise.
13578 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13579 * python/py-value.c (convert_value_from_python): Likewise.
13580
135812019-03-06 Tom Tromey <tom@tromey.com>
13582
13583 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13584
135852019-03-06 Tom Tromey <tom@tromey.com>
13586
13587 * utils.h (free_current_contents): Don't declare.
13588 * utils.c (free_current_contents): Remove.
13589
135902019-03-06 Tom Tromey <tom@tromey.com>
13591
13592 * top.c (quit_force): Update.
13593 * main.c (captured_command_loop): Update.
13594 * common/new-op.c (operator new): Update.
13595 * common/common-exceptions.c (struct catcher)
13596 <save_cleanup_chain>: Remove member.
13597 (exceptions_state_mc_init): Update.
13598 (exception_try_scope_entry): Return nullptr.
13599 (exception_try_scope_exit, exception_rethrow)
13600 (throw_exception_sjlj, throw_exception_cxx): Update.
13601 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13602 (all_cleanups, do_cleanups, discard_cleanups)
13603 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13604 (restore_cleanups, restore_final_cleanups): Don't declare.
13605 (do_final_cleanups): Remove parameter.
13606 * common/cleanups.c (cleanup_chain, make_cleanup)
13607 (make_cleanup_dtor, all_cleanups, do_cleanups)
13608 (discard_my_cleanups, discard_cleanups)
13609 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13610 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13611 (null_cleanup): Remove.
13612 (do_final_cleanups): Remove parameter.
13613
136142019-03-06 Tom Tromey <tom@tromey.com>
13615
13616 * remote.c (remote_target::remote_parse_stop_reply): Use
13617 unique_xmalloc_ptr.
13618
136192019-03-06 Tom Tromey <tom@tromey.com>
13620
13621 * stabsread.c (struct stabs_field_info): Rename from field_info.
13622 <list, fnlist>: Add initializers.
13623 <obstack>: New member.
13624 (read_member_functions, read_struct_fields, read_baseclasses):
13625 Allocate on obstack. Don't use cleanups.
13626 (read_one_struct_field, read_member_functions, read_struct_fields)
13627 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13628 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13629 (read_struct_type): Update.
13630
136312019-03-06 Tom Tromey <tom@tromey.com>
13632
13633 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13634 * common/filestuff.h (make_cleanup_close): Don't declare.
13635 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13636 Remove.
13637
136382019-03-06 Tom Tromey <tom@tromey.com>
13639
13640 * solib-aix.c: Use make_scope_exit.
13641
136422019-03-06 Tom Tromey <tom@tromey.com>
13643
13644 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13645 Use make_scope_exit.
13646
136472019-03-06 Tom Tromey <tom@tromey.com>
13648
13649 * solib-svr4.c (disable_probes_interface): Remove parameter.
13650 (svr4_handle_solib_event): Use make_scope_exit.
13651
136522019-03-06 Tom Tromey <tom@tromey.com>
13653
13654 * remote.c (struct stop_reply_deleter): Remove.
13655 (stop_reply_up): Update.
13656 (struct stop_reply): Derive from notif_event. Don't typedef.
13657 <regcache>: Now a std::vector.
13658 (stop_reply_xfree): Remove.
13659 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13660 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13661 (remote_target::discard_pending_stop_replies): Use delete.
13662 (remote_target::remote_parse_stop_reply): Update.
13663 (remote_target::process_stop_reply): Update.
13664 * remote-notif.h (struct notif_event): Add virtual destructor.
13665 Remove "dtr" member.
13666 (struct notif_client) <alloc_event>: Return a unique_ptr.
13667 (notif_event_xfree): Don't declare.
13668 (notif_event_up): New typedef.
13669 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13670 (notif_event_xfree, do_notif_event_xfree): Remove.
13671 (remote_notif_state_xfree): Update.
13672
136732019-03-06 Tom Tromey <tom@tromey.com>
13674
13675 * infrun.c (displaced_step_clear_cleanup): Now a
13676 forward_scope_exit type.
13677 (displaced_step_prepare_throw): Update.
13678 (displaced_step_fixup): Update.
13679
136802019-03-06 Tom Tromey <tom@tromey.com>
13681
13682 * inferior.h (class inferior): Update comment.
13683 * gdbthread.h (class thread_info): Update comment.
13684
136852019-03-06 Joel Brobecker <brobecker@adacore.com>
13686 Tom Tromey <tom@tromey.com>
13687
13688 * stabsread.h (struct stab_section_list): Remove.
13689 (coffstab_build_psymtabs): Update.
13690 * dbxread.c (symbuf_sections): Now a std::vector.
13691 (sect_idx): New global.
13692 (fill_symbuf): Update.
13693 (coffstab_build_psymtabs): Change type of stabsects parameter.
13694 Update.
13695 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13696 std::vector.
13697 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13698 (coff_locate_sections): Update.
13699 (coff_symfile_read): Remove cleanups. Update.
13700 (init_stringtab): Add storage parameter.
13701 (free_stringtab, free_stringtab_cleanup): Remove.
13702 (init_lineno): Add storage parameter.
13703 (free_linetab, free_linetab_cleanup): Remove.
13704
137052019-03-06 Pedro Alves <palves@redhat.com>
13706
13707 * linux-fork.c (fork_info::clobber_regs): Delete.
13708 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13709 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13710 comment. Adjust.
13711 (scoped_switch_fork_info::scoped_switch_fork_info)
13712 (checkpoint_command, linux_fork_context): Adjust
13713 fork_save_infrun_state calls.
13714
137152019-03-06 Pedro Alves <palves@redhat.com>
13716
13717 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13718 (inf_has_multiple_threads): Return 'bool' and rewrite using
13719 inferior_info::threads().
13720
137212019-03-06 Pedro Alves <palves@redhat.com>
13722
13723 * linux-fork.c: Include <list>.
13724 (fork_list): Now a std::list instance.
13725 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13726 (forks_exist_p, find_last_fork): Adjust.
13727 (new_fork): Delete.
13728 (one_fork_p): New.
13729 (add_fork): Adjust.
13730 (free_fork): Delete, folded into fork_info::~fork_info().
13731 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13732 Adjust.
13733 (init_fork_list): Delete.
13734 (linux_fork_killall, linux_fork_mourn_inferior)
13735 (linux_fork_detach, info_checkpoints_command): Adjust.
13736 (_initialize_linux_fork): No longer call init_fork_list.
13737
137382019-03-06 Pedro Alves <palves@redhat.com>
13739
13740 * linux-fork.c (new_fork): New, split out of ...
13741 (add_fork): ... this. Return void. Move "first fork" special
13742 case from here, to ...
13743 (checkpoint_command): ... here.
13744 * linux-linux.h (add_fork): Return void.
13745
137462019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13747
13748 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13749
137502019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13751 Chris January <chris.january@arm.com>
13752 David Lecomber <david.lecomber@arm.com>
13753
13754 * f-exp.y: New token, UNOP_INTRINSIC.
13755 (exp): New pattern using UNOP_INTRINSIC token.
13756 (f77_keywords): Add 'abs' keyword.
13757 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13758 (value_from_host_double): New function.
13759 (evaluate_subexp_f): Support UNOP_ABS.
13760
137612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13762
13763 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13764 types.
13765
137662019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13767
13768 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13769 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13770 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13771
137722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13773
13774 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13775
137762019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13777 Chris January <chris.january@arm.com>
13778
13779 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13780 * f-exp.y: Define 'KIND' token.
13781 (exp): New pattern for KIND expressions.
13782 (ptype): Handle types with a kind extension.
13783 (direct_abs_decl): Extend to spot kind extensions.
13784 (f77_keywords): Add 'kind' to the list.
13785 (push_kind_type): New function.
13786 (convert_to_kind_type): New function.
13787 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13788 * parse.c (operator_length_standard): Likewise.
13789 * parser-defs.h (enum type_pieces): Add tp_kind.
13790 * std-operator.def: Add UNOP_KIND.
13791
137922019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13793
13794 * f-exp.y (f_parse): Set yydebug.
13795
137962019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13797
13798 * f-lang.c (evaluate_subexp_f): New function.
13799 (exp_descriptor_f): New global.
13800 (f_language_defn): Use exp_descriptor_f instead of
13801 exp_descriptor_standard.
13802
138032019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13804
13805 * f-exp.y (struct token): Add comments.
13806 (dot_ops): Remove uppercase versions and the end marker.
13807 (f77_keywords): Likewise.
13808 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13809 entries in the dot_ops array are case insensitive, and use
13810 strncasecmp to compare strings. Also some whitespace cleanup in
13811 this area. Similar for the f77_keywords array, except entries in
13812 this list might be case sensitive.
13813
138142019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13815
13816 * f-exp.y (struct f77_boolean_val): Add comments.
13817 (boolean_values): Remove uppercase versions, and end marker.
13818 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13819 and use strncasecmp to achieve case insensitivity. Additionally,
13820 perform whitespace cleanup around this code.
13821
138222019-03-06 Tom Tromey <tromey@adacore.com>
13823
13824 * remote-sim.c (gdbsim_target_open): Use result of
13825 gdb_argv::release.
13826
138272019-03-06 Richard Bunt <richard.bunt@arm.com>
13828 Dirk Schubert <dirk.schubert@arm.com>
13829 Chris January <chris.january@arm.com>
13830
13831 * eval.c (evaluate_subexp_standard): Call Fortran argument
13832 wrapping logic.
13833 * f-lang.c (struct value): A value which can be passed into a
13834 Fortran function call.
13835 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13836 where appropriate.
13837 (struct type): Value ready for a Fortran function call.
13838 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13839 is needed.
13840 * f-lang.h (fortran_argument_convert): Declaration.
13841 (fortran_preserve_arg_pointer): Declaration.
13842 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13843
138442019-03-05 Tom Tromey <tromey@adacore.com>
13845
13846 * python/py-prettyprint.c (print_string_repr): Remove #if.
13847 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13848
138492019-03-05 Tom Tromey <tromey@adacore.com>
13850
13851 * target.c (the_dummy_target): Move later. Change type to
13852 "dummy_target".
13853 (initialize_targets): Don't initialize the_dummy_target.
13854
138552019-03-05 Tom Tromey <tromey@adacore.com>
13856
13857 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13858 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13859
138602019-03-05 Tom Tromey <tromey@adacore.com>
13861
13862 * windows-nat.c (windows_nat_target::attach)
13863 (windows_nat_target::detach): Don't call gdb_flush.
13864 * valprint.c (generic_val_print, val_print, val_print_string):
13865 Don't call gdb_flush.
13866 * utils.c (defaulted_query): Don't call gdb_flush.
13867 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13868 * target.c (target_announce_detach): Don't call gdb_flush.
13869 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13870 * remote.c (extended_remote_target::attach): Don't call
13871 gdb_flush.
13872 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13873 * printcmd.c (do_examine): Don't call gdb_flush.
13874 (info_display_command): Don't call gdb_flush.
13875 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13876 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13877 * memattr.c (info_mem_command): Don't call gdb_flush.
13878 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13879 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13880 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13881 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13882 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13883 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13884 (gnu_nat_target::detach): Don't call gdb_flush.
13885 * f-valprint.c (f_val_print): Don't call gdb_flush.
13886 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13887 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13888 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13889 gdb_flush.
13890 * c-valprint.c (c_val_print): Don't call gdb_flush.
13891 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13892
138932019-03-05 Tom Tromey <tromey@adacore.com>
13894
13895 * varobj.c (update_dynamic_varobj_children): Update.
13896 (install_default_visualizer): Use reset, not release.
13897 * value.c (set_internalvar): Update.
13898 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13899 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13900 ATTRIBUTE_UNUSED_RESULT.
13901
139022019-03-05 Tom Tromey <tromey@adacore.com>
13903
13904 * remote.c (class scoped_remote_fd) <release>: Add
13905 ATTRIBUTE_UNUSED_RESULT.
13906
139072019-03-05 Tom Tromey <tromey@adacore.com>
13908
13909 * macroexp.c (struct macro_buffer) <release>: Add
13910 ATTRIBUTE_UNUSED_RESULT.
13911
139122019-03-05 Tom Tromey <tromey@adacore.com>
13913
13914 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13915 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13916 ATTRIBUTE_UNUSED_RESULT.
13917
139182019-03-05 Tom Tromey <tromey@adacore.com>
13919
13920 * common/scoped_fd.h (class scoped_fd) <release>: Add
13921 ATTRIBUTE_UNUSED_RESULT.
13922
139232019-03-05 Tom Tromey <tromey@adacore.com>
13924
13925 * parser-defs.h (struct parser_state) <release>: Add
13926 ATTRIBUTE_UNUSED_RESULT.
13927
139282019-03-05 Tom Tromey <tromey@adacore.com>
13929
13930 * utils.h (class gdb_argv) <release>: Add
13931 ATTRIBUTE_UNUSED_RESULT.
13932 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13933
139342019-03-02 Eli Zaretskii <eliz@gnu.org>
13935
13936 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13937 for-loop range, to avoid compiler warnings.
13938
13939 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13940 avoid compiler warnings about unused variables.
13941
13942 * NEWS: Mention end of support for native debugging on MS-Windows
13943 before XP.
13944
13945 PR gdb/24292
13946 * common/netstuff.c:
13947 * gdbserver/gdbreplay.c
13948 * gdbserver/remote-utils.c:
13949 * ser-tcp.c:
13950 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13951 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13952 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13953 'getaddrinfo' and 'freeaddrinfo' were not available before
13954 Windows XP, and mingw.org's MinGW headers by default define
13955 _WIN32_WINNT to 0x500.
13956
139572019-03-01 Gary Benson <gbenson@redhat.com>
13958
13959 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13960
139612019-02-28 Brian Vandenberg <phantall@gmail.com>
13962 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13963
13964 PR gdb/8527
13965 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13966 set_sigint_trap, clear_sigint_trap.
13967
139682019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13969
13970 * target.c (target_detach): Clear the regcache and the
13971 frame cache.
13972
139732019-02-27 Pedro Alves <palves@redhat.com>
13974
13975 * utils.c (set_screen_size): When we cap the height/width sizes,
13976 tweak the corresponding command variable to show "unlimited":
13977
139782019-02-27 Saagar Jha <saagar@saagarjha.com>
13979 Pedro Alves <palves@redhat.com>
13980
13981 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13982 before calling rl_set_screen_size.
13983
139842019-02-27 Tom Tromey <tromey@adacore.com>
13985
13986 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13987 define.
13988 * python/py-value.c: Remove Python 2.4 workaround.
13989 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13990 workaround.
13991 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13992 Python 2.4 workaround.
13993 * python/python-internal.h: Remove Python 2.4 comment.
13994 (Py_ssize_t): Don't define.
13995 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13996 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13997 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13998 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13999 * python/python.c (do_start_initialization): Remove Python 2.4
14000 workaround.
14001 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14002 (print_children): Remove Python 2.4 workaround.
14003 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14004 workaround.
14005 (CHARBUFFERPROC_NAME): Remove.
14006 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14007 Python 2.4 workaround.
14008
140092019-02-27 Kevin Buettner <kevinb@redhat.com>
14010
14011 * NEWS: Note minimum Python version.
14012
140132019-02-27 Kevin Buettner <kevinb@redhat.com>
14014
14015 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14016 code from these functions. Remove corresponding ifdefs. Use
14017 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14018 Remove gotos and target of gotos.
14019 (infpy_search_memory): Likewise.
14020
140212019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14022
14023 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14024 (hppa_gdbarch_init): Don't register deleted functions with
14025 gdbarch.
14026
140272019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14028
14029 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14030 (h8300_unwind_sp): Delete.
14031 (h8300_dummy_id): Delete.
14032 (h8300_gdbarch_init): Don't register deleted functions with
14033 gdbarch.
14034
140352019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14036
14037 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14038 (ft32_unwind_pc): Delete.
14039 (ft32_unwind_sp): Delete.
14040 (ft32_gdbarch_init): Don't register deleted functions with
14041 gdbarch.
14042
140432019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14044
14045 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14046 (frv_unwind_pc): Delete.
14047 (frv_unwind_sp): Delete.
14048 (frv_gdbarch_init): Don't register deleted functions with
14049 gdbarch.
14050
140512019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14052
14053 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14054 (riscv_unwind_pc): Delete.
14055 (riscv_unwind_sp): Delete.
14056 (riscv_gdbarch_init): Don't register deleted functions with
14057 gdbarch.
14058
140592019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14060
14061 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14062 (csky_unwind_pc): Delete.
14063 (csky_unwind_sp): Delete.
14064 (csky_gdbarch_init): Don't register deleted functions with
14065 gdbarch.
14066
140672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14068
14069 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14070 (cris_unwind_pc): Delete.
14071 (cris_unwind_sp): Delete.
14072 (cris_gdbarch_init): Don't register deleted functions with
14073 gdbarch.
14074
140752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14076
14077 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14078 (bfin_unwind_pc): Delete.
14079 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14080
140812019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14082
14083 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14084 (arm_unwind_pc): Delete.
14085 (arm_unwind_sp): Delete.
14086 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14087
140882019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14089
14090 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14091 (arc_unwind_pc): Delete.
14092 (arc_unwind_sp): Delete.
14093 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14094
140952019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14096
14097 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14098 (alpha_unwind_pc): Delete.
14099 (alpha_gdbarch_init): Don't register deleted functions with
14100 gdbarch.
14101
141022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14103
14104 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14105 (aarch64_unwind_pc): Delete.
14106 (aarch64_unwind_sp): Delete.
14107 (aarch64_gdbarch_init): Don't register deleted functions with
14108 gdbarch.
14109
141102019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14111
14112 * gdbtypes.c (type_align): Don't consider static members when
14113 computing structure alignment.
14114
141152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14116
14117 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14118 return 0 for other types.
14119 * arch-utils.c (default_type_align): Always return 0.
14120 * gdbarch.h: Regenerate.
14121 * gdbarch.sh (type_align): Extend comment.
14122 * gdbtypes.c (type_align): Add additional comments, always call
14123 gdbarch_type_align before applying the default rules.
14124 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14125 generic code will then apply a suitable default.
14126 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14127 types, return 0 for other types.
14128
141292019-02-27 Joel Brobecker <brobecker@adacore.com>
14130
14131 * NEWS: Create a new section for the next release branch.
14132 Rename the section of the current branch, now that it has
14133 been cut.
14134
141352019-02-27 Joel Brobecker <brobecker@adacore.com>
14136
14137 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14138 * version.in: Bump version to 8.3.50.DATE-git.
14139
141402019-02-26 Simon Marchi <simon.marchi@efficios.com>
14141
14142 * aix-thread.c (ptid_cmp): Remove unused variable.
14143 (get_signaled_thread): Likewise.
14144 (store_regs_user_thread): Likewise.
14145 (store_regs_kernel_thread): Likewise.
14146 (fetch_regs_kernel_thread): Remove shadowed variable.
14147
141482019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14149
14150 * features/riscv/32bit-cpu.xml: Add register numbers.
14151 * features/riscv/32bit-fpu.c: Regenerate.
14152 * features/riscv/32bit-fpu.xml: Add register numbers.
14153 * features/riscv/64bit-cpu.xml: Add register numbers.
14154 * features/riscv/64bit-fpu.c: Regenerate.
14155 * features/riscv/64bit-fpu.xml: Add register numbers.
14156
141572019-02-26 Kevin Buettner <kevinb@redhat.com>
14158
14159 * NEWS: Mention two argument form of gdb.Value constructor.
14160 * python/py-value.c (convert_buffer_and_type_to_value): New
14161 function.
14162 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14163 Add support for handling an optional second argument. Call
14164 convert_buffer_and_type_to_value as appropriate.
14165 * python/python-internal.h (Py_buffer_deleter): New struct.
14166 (Py_buffer_up): New typedef.
14167
141682019-02-25 John Baldwin <jhb@FreeBSD.org>
14169
14170 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14171 instead of releasing ownership.
14172
141732019-02-25 Jordan Rupprecht <rupprecht@google.com>
14174
14175 * dwarf2read.c (open_and_init_dwp_file): Call
14176 elf_numsections instead of bfd_count_sections to initialize
14177 dwp_file->num_sections.
14178
141792019-02-25 Tom Tromey <tromey@adacore.com>
14180
14181 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14182
141832019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14184
14185 * gcore.in: Add '--readnever' option when invoking GDB.
14186
141872019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14188
14189 * MAINTAINERS: Update my email address.
14190
141912019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14192
14193 * build-id.c (build_id_to_debug_bfd_1): New function.
14194 (build_id_to_debug_bfd): Look for separate debug file in
14195 sysroot.
14196
141972019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14198
14199 * gdbarch.sh: Update the copyright year range that is placed into
14200 generated files.
14201
142022019-02-22 Keith Seitz <keiths@redhat.com>
14203
14204 PR symtab/23853
14205 * linespec.c (create_sals_line_offset): Search for the default
14206 symtab's filename instead of its fullname.
14207
142082019-02-21 Alan Hayward <alan.hayward@arm.com>
14209
14210 * NEWS: Update style defaults.
14211
142122019-02-21 Alan Hayward <alan.hayward@arm.com>
14213
14214 * main.c (captured_main_1): Disable styling in batch mode.
14215
142162019-02-20 Tom Tromey <tom@tromey.com>
14217
14218 * symtab.c (symtab_symbol_info): Fix typos.
14219
142202019-02-20 Tom Tromey <tromey@adacore.com>
14221
14222 * findcmd.c (_initialize_mem_search): Use upper case for
14223 metasyntactic variables.
14224
142252019-02-20 Alan Hayward <alan.hayward@arm.com>
14226
14227 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14228 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14229
142302019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14231
14232 * top.h (source_file_name): Change to std::string.
14233 * top.c (source_file_name): Likewise.
14234 (command_line_input): Adjust.
14235 * cli/cli-script.c (script_from_file): Adjust.
14236
142372019-02-19 Tom Tromey <tromey@adacore.com>
14238
14239 * ravenscar-thread.c
14240 (ravenscar_thread_target::update_thread_list): Don't call
14241 ada_build_task_list.
14242 * ada-lang.h (ada_build_task_list): Don't declare.
14243 * ada-tasks.c (struct ada_tasks_inferior_data)
14244 <task_list_valid_p>: Now bool.
14245 (read_known_tasks, ada_task_list_changed)
14246 (ada_tasks_invalidate_inferior_data): Update.
14247 (read_known_tasks_array): Return bool.
14248 (read_known_tasks_list): Likewise.
14249 (read_known_tasks): Return void.
14250 (ada_build_task_list): Now static.
14251
142522019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14253
14254 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14255 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14256
142572019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14258
14259 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14260 variant for ada_tasks_pspace_data_handle and
14261 ada_tasks_inferior_data_handle.
14262 (ada_tasks_pspace_data_cleanup): New function.
14263 (ada_tasks_inferior_data_cleanup): New function.
14264
142652019-02-17 Tom Tromey <tom@tromey.com>
14266
14267 * macrotab.h (macro_source_fullname): Return a std::string.
14268 * macrotab.c (macro_include, check_for_redefinition)
14269 (macro_undef, macro_lookup_definition, foreach_macro)
14270 (foreach_macro_in_scope): Update.
14271 (macro_source_fullname): Return a std::string.
14272 * macrocmd.c (show_pp_source_pos): Update.
14273
142742019-02-17 Tom Tromey <tom@tromey.com>
14275
14276 * macrocmd.c (show_pp_source_pos): Style the file names.
14277
142782019-02-17 Tom Tromey <tom@tromey.com>
14279
14280 PR tui/24197:
14281 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14282
142832019-02-17 Tom Tromey <tom@tromey.com>
14284
14285 * ada-lang.c (user_select_syms): Use filtered printing.
14286 * utils.c (wrap_style): New global.
14287 (desired_style): Remove.
14288 (emit_style_escape): Add stream parameter.
14289 (set_output_style, reset_terminal_style, prompt_for_continue):
14290 Update.
14291 (flush_wrap_buffer): Only flush gdb_stdout.
14292 (wrap_here): Set wrap_style.
14293 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14294 treat escape sequences as a character. Change when wrap buffer is
14295 flushed.
14296 (fputs_styled): Do not set the output style when the default is
14297 requested.
14298 * ui-style.h (struct ui_file_style) <is_default>: New method.
14299 * source.c (print_source_lines_base): Emit escape sequences in one
14300 piece.
14301
143022019-02-17 Joel Brobecker <brobecker@adacore.com>
14303
14304 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14305 integers and enumeration types.
14306
143072019-02-17 Joel Brobecker <brobecker@adacore.com>
14308
14309 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14310 instead of lookup_symbol_in_language
14311 (do_exact_match): New function.
14312 (ada_get_symbol_name_matcher): Return do_exact_match when
14313 doing a verbatim match.
14314
143152019-02-15 Tom Tromey <tromey@adacore.com>
14316
14317 * ravenscar-thread.c (ravenscar_thread_target::resume)
14318 (ravenscar_thread_target::wait): Special case wildcard requests.
14319
143202019-02-15 Tom Tromey <tromey@adacore.com>
14321
14322 * ravenscar-thread.c (base_ptid): Remove.
14323 (struct ravenscar_thread_target) <close>: New method.
14324 <m_base_ptid>: New member.
14325 <update_inferior_ptid, active_task, task_is_currently_active,
14326 runtime_initialized>: Declare methods.
14327 <ravenscar_thread_target>: Add constructor.
14328 (ravenscar_thread_target::task_is_currently_active)
14329 (ravenscar_thread_target::update_inferior_ptid)
14330 (ravenscar_runtime_initialized): Rename. Now methods.
14331 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14332 (ravenscar_thread_target::update_thread_list): Update.
14333 (ravenscar_thread_target::active_task): Now method.
14334 (ravenscar_thread_target::store_registers)
14335 (ravenscar_thread_target::prepare_to_store)
14336 (ravenscar_thread_target::prepare_to_store)
14337 (ravenscar_thread_target::mourn_inferior): Update.
14338 (ravenscar_inferior_created): Use "new" to create target.
14339 (ravenscar_thread_target::get_ada_task_ptid): Update.
14340 (_initialize_ravenscar): Don't initialize base_ptid.
14341 (ravenscar_ops): Remove global.
14342
143432019-02-15 Tom Tromey <tromey@adacore.com>
14344
14345 * target.h (push_target): Declare new overload.
14346 * target.c (push_target): New overload, taking an rvalue reference.
14347 * remote.c (remote_target::open_1): Use push_target overload.
14348 * corelow.c (core_target_open): Use push_target overload.
14349
143502019-02-15 Tom Tromey <tromey@adacore.com>
14351
14352 * ravenscar-thread.c (is_ravenscar_task)
14353 (ravenscar_task_is_currently_active): Return bool.
14354 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14355 (_initialize_ravenscar): Remove "(void)".
14356 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14357 Return bool.
14358
143592019-02-15 Tom Tromey <tromey@adacore.com>
14360
14361 * ravenscar-thread.c (ravenscar_runtime_initializer)
14362 (has_ravenscar_runtime, get_running_thread_id)
14363 (ravenscar_thread_target::resume): Fix indentation.
14364
143652019-02-15 Tom Tromey <tromey@adacore.com>
14366
14367 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14368 from ravenscar_arch_ops.
14369 (sparc_ravenscar_ops::fetch_registers)
14370 (sparc_ravenscar_ops::store_registers): Now methods.
14371 (sparc_ravenscar_prepare_to_store): Remove.
14372 (sparc_ravenscar_ops): Redefine.
14373 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14374 methods and destructor. Remove members.
14375 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14376 (ravenscar_thread_target::store_registers)
14377 (ravenscar_thread_target::prepare_to_store): Update.
14378 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14379 Remove.
14380 (struct ppc_ravenscar_powerpc_ops): Derive from
14381 ravenscar_arch_ops.
14382 (ppc_ravenscar_powerpc_ops::fetch_registers)
14383 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14384 (ppc_ravenscar_powerpc_ops): Redefine.
14385 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14386 (ppc_ravenscar_e500_ops::fetch_registers)
14387 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14388 (ppc_ravenscar_e500_ops): Redefine.
14389 * aarch64-ravenscar-thread.c
14390 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14391 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14392 (aarch64_ravenscar_fetch_registers)
14393 (aarch64_ravenscar_store_registers): Now methods.
14394 (aarch64_ravenscar_ops): Redefine.
14395
143962019-02-15 Tom Tromey <tromey@adacore.com>
14397
14398 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14399 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14400 (ravenscar_thread_target::stopped_by_watchpoint)
14401 (ravenscar_thread_target::stopped_data_address)
14402 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14403
144042019-02-15 Tom Tromey <tromey@adacore.com>
14405
14406 * ravenscar-thread.c: Fix some typos.
14407
144082019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14409 Tom Tromey <tromey@adacore.com>
14410
14411 * ada-lang.c (ada_exception_sal): Change addr_string to a
14412 std::string.
14413 (create_ada_exception_catchpoint): Update.
14414
144152019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14416 Tom Tromey <tromey@adacore.com>
14417
14418 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14419 (bp_location_ops): Remove.
14420 (base_breakpoint_allocate_location): Update.
14421 (free_bp_location): Update.
14422 * ada-lang.c (class ada_catchpoint_location)
14423 <ada_catchpoint_location>: Remove ops parameter.
14424 (ada_catchpoint_location_dtor): Remove.
14425 (ada_catchpoint_location_ops): Remove.
14426 (allocate_location_exception): Update.
14427 * breakpoint.h (struct bp_location_ops): Remove.
14428 (class bp_location) <bp_location>: Remove bp_location_ops
14429 parameter.
14430 <~bp_location>: Add destructor.
14431 <ops>: Remove.
14432
144332019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14434 Pedro Alves <palves@redhat.com>
14435
14436 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14437 'PATH_MAX'.
14438
144392019-02-14 David Michael <fedora.dm0@gmail.com>
14440 Samuel Thibault <samuel.thibault@gnu.org>
14441 Thomas Schwinge <thomas@codesourcery.com>
14442
14443 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14444 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14445
144462019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14447
14448 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14449 (check_empty): Use "const char *".
14450
14451 * gnu-nat.c (gnu_nat_target::detach): Instead of
14452 'detach_inferior (pid)' call
14453 'detach_inferior (find_inferior_pid (pid))'.
14454
14455 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14456 'nat/fork-inferior.o'.
14457 * gnu-nat.c: #include "nat/fork-inferior.h".
14458
14459 * gnu-nat.c (gnu_nat_target::detach): Instead of
14460 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14461 * gnu-nat.h: #include "inf-child.h".
14462 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14463 'i386_gnu_nat_target::fetch_registers'.
14464 (gnu_store_registers): Rename/move to
14465 'i386_gnu_nat_target::store_registers'.
14466
14467 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14468 * gnu-nat.h (mach_thread_info): New function.
14469 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14470
14471 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14472
144732019-02-14 Frederic Konrad <konrad@adacore.com>
14474
14475 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14476
144772019-02-14 Joel Brobecker <brobecker@adacore.com>
14478
14479 * windows-nat.c (windows_add_thread): Add new parameter
14480 "main_thread_p" with default value set to false. Update
14481 function documentation as well as all callers.
14482 (windows_delete_thread): Likewise.
14483 (fake_create_process): Update call to windows_add_thread.
14484 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14485 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14486 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14487 call to windows_delete_thread.
14488
144892019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14490
14491 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14492
144932019-02-12 John Baldwin <jhb@FreeBSD.org>
14494
14495 * symfile.c (find_separate_debug_file): Use canonical path of
14496 sysroot with child_path instead of gdb_sysroot if it is valid.
14497
144982019-02-12 John Baldwin <jhb@FreeBSD.org>
14499
14500 * symfile.c (find_separate_debug_file): Use child_path to
14501 determine if an object file is under a sysroot.
14502
145032019-02-12 John Baldwin <jhb@FreeBSD.org>
14504
14505 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14506 unittests/child-path-selftests.c.
14507 * common/pathstuff.c (child_path): New function.
14508 * common/pathstuff.h (child_path): New prototype.
14509 * unittests/child-path-selftests.c: New file.
14510
145112019-02-12 John Baldwin <jhb@FreeBSD.org>
14512
14513 * symfile.c (find_separate_debug_file): Look for separate debug
14514 files in debug directories under the sysroot.
14515
145162019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14517
14518 * symtab.h (struct minimal_symbol data_p): New const method.
14519 (struct minimal_symbol text_p): Likewise.
14520 * symtab.c (output_source_filename): Use file name style
14521 to print file name.
14522 (print_symbol_info): Likewise.
14523 (print_msymbol_info): Use address style to print addresses.
14524 Use function name style to print executable text symbols.
14525 (expand_symtab_containing_pc): Use data_p.
14526 (find_pc_sect_compunit_symtab): Likewise.
14527
145282019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14529
14530 * breakpoint.c (describe_other_breakpoints): Use address style
14531 to print addresses.
14532 (say_where): Likewise.
14533
145342019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14535
14536 * ada-typeprint.c (print_func_type): Print function name
14537 style to print function name.
14538 * c-typeprint.c (c_print_type_1): Likewise.
14539
145402019-02-11 Alan Hayward <alan.hayward@arm.com>
14541
14542 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14543 for execve.
14544
145452019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14546
14547 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14548 type_stack.
14549
145502019-02-10 Joel Brobecker <brobecker@adacore.com>
14551
14552 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14553 TYPE_CODE_REF types.
14554
145552019-02-08 Jim Wilson <jimw@sifive.com>
14556
14557 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14558 (riscv_linux_fregset): New.
14559 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14560
145612019-02-07 Tom Tromey <tom@tromey.com>
14562
14563 * thread.c (thread_cancel_execution_command): Update.
14564 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14565 methods.
14566 (struct thread_fsm_ops): Remove.
14567 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14568 (thread_fsm_should_stop, thread_fsm_return_value)
14569 (thread_fsm_set_finished, thread_fsm_finished_p)
14570 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14571 Don't declare.
14572 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14573 * infrun.c (clear_proceed_status_thread)
14574 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14575 (print_stop_event): Update.
14576 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14577 Add constructor.
14578 (step_command_fsm_ops): Remove.
14579 (new_step_command_fsm): Remove.
14580 (step_1): Update.
14581 (step_command_fsm::should_stop): Rename from
14582 step_command_fsm_should_stop.
14583 (step_command_fsm::clean_up): Rename from
14584 step_command_fsm_clean_up.
14585 (step_command_fsm::do_async_reply_reason): Rename from
14586 step_command_fsm_async_reply_reason.
14587 (struct until_next_fsm): Inherit from thread_fsm. Add
14588 constructor.
14589 (until_next_fsm_ops): Remove.
14590 (new_until_next_fsm): Remove.
14591 (until_next_fsm::should_stop): Rename from
14592 until_next_fsm_should_stop.
14593 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14594 (until_next_fsm::do_async_reply_reason): Rename from
14595 until_next_fsm_async_reply_reason.
14596 (struct finish_command_fsm): Inherit from thread_fsm. Add
14597 constructor. Change type of breakpoint.
14598 (finish_command_fsm_ops): Remove.
14599 (new_finish_command_fsm): Remove.
14600 (finish_command_fsm::should_stop): Rename from
14601 finish_command_fsm_should_stop.
14602 (finish_command_fsm::clean_up): Rename from
14603 finish_command_fsm_clean_up.
14604 (finish_command_fsm::return_value): Rename from
14605 finish_command_fsm_return_value.
14606 (finish_command_fsm::do_async_reply_reason): Rename from
14607 finish_command_fsm_async_reply_reason.
14608 (finish_command): Update.
14609 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14610 Add constructor.
14611 (call_thread_fsm_ops): Remove.
14612 (call_thread_fsm::call_thread_fsm): Rename from
14613 new_call_thread_fsm.
14614 (call_thread_fsm::should_stop): Rename from
14615 call_thread_fsm_should_stop.
14616 (call_thread_fsm::should_notify_stop): Rename from
14617 call_thread_fsm_should_notify_stop.
14618 (run_inferior_call, call_function_by_hand_dummy): Update.
14619 * cli/cli-interp.c (should_print_stop_to_console): Update.
14620 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14621 Add constructor. Change type of location_breakpoint,
14622 caller_breakpoint.
14623 (until_break_fsm_ops): Remove.
14624 (new_until_break_fsm): Remove.
14625 (until_break_fsm::should_stop): Rename from
14626 until_break_fsm_should_stop.
14627 (until_break_fsm::clean_up): Rename from
14628 until_break_fsm_clean_up.
14629 (until_break_fsm::do_async_reply_reason): Rename from
14630 until_break_fsm_async_reply_reason.
14631 (until_break_command): Update.
14632 * thread-fsm.c: Remove.
14633 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14634
146352019-02-07 Tom Tromey <tom@tromey.com>
14636
14637 * yy-remap.h: Add include guard.
14638 * xtensa-tdep.h: Add include guard.
14639 * xcoffread.h: Rename include guard.
14640 * varobj-iter.h: Add include guard.
14641 * tui/tui.h: Rename include guard.
14642 * tui/tui-winsource.h: Rename include guard.
14643 * tui/tui-wingeneral.h: Rename include guard.
14644 * tui/tui-windata.h: Rename include guard.
14645 * tui/tui-win.h: Rename include guard.
14646 * tui/tui-stack.h: Rename include guard.
14647 * tui/tui-source.h: Rename include guard.
14648 * tui/tui-regs.h: Rename include guard.
14649 * tui/tui-out.h: Rename include guard.
14650 * tui/tui-layout.h: Rename include guard.
14651 * tui/tui-io.h: Rename include guard.
14652 * tui/tui-hooks.h: Rename include guard.
14653 * tui/tui-file.h: Rename include guard.
14654 * tui/tui-disasm.h: Rename include guard.
14655 * tui/tui-data.h: Rename include guard.
14656 * tui/tui-command.h: Rename include guard.
14657 * tic6x-tdep.h: Add include guard.
14658 * target/waitstatus.h: Rename include guard.
14659 * target/wait.h: Rename include guard.
14660 * target/target.h: Rename include guard.
14661 * target/resume.h: Rename include guard.
14662 * target-float.h: Rename include guard.
14663 * stabsread.h: Add include guard.
14664 * rs6000-tdep.h: Add include guard.
14665 * riscv-fbsd-tdep.h: Add include guard.
14666 * regformats/regdef.h: Rename include guard.
14667 * record.h: Rename include guard.
14668 * python/python.h: Rename include guard.
14669 * python/python-internal.h: Rename include guard.
14670 * python/py-stopevent.h: Rename include guard.
14671 * python/py-ref.h: Rename include guard.
14672 * python/py-record.h: Rename include guard.
14673 * python/py-record-full.h: Rename include guard.
14674 * python/py-record-btrace.h: Rename include guard.
14675 * python/py-instruction.h: Rename include guard.
14676 * python/py-events.h: Rename include guard.
14677 * python/py-event.h: Rename include guard.
14678 * procfs.h: Add include guard.
14679 * proc-utils.h: Add include guard.
14680 * p-lang.h: Add include guard.
14681 * or1k-tdep.h: Rename include guard.
14682 * observable.h: Rename include guard.
14683 * nto-tdep.h: Rename include guard.
14684 * nat/x86-linux.h: Rename include guard.
14685 * nat/x86-linux-dregs.h: Rename include guard.
14686 * nat/x86-gcc-cpuid.h: Add include guard.
14687 * nat/x86-dregs.h: Rename include guard.
14688 * nat/x86-cpuid.h: Rename include guard.
14689 * nat/ppc-linux.h: Rename include guard.
14690 * nat/mips-linux-watch.h: Rename include guard.
14691 * nat/linux-waitpid.h: Rename include guard.
14692 * nat/linux-ptrace.h: Rename include guard.
14693 * nat/linux-procfs.h: Rename include guard.
14694 * nat/linux-osdata.h: Rename include guard.
14695 * nat/linux-nat.h: Rename include guard.
14696 * nat/linux-namespaces.h: Rename include guard.
14697 * nat/linux-btrace.h: Rename include guard.
14698 * nat/glibc_thread_db.h: Rename include guard.
14699 * nat/gdb_thread_db.h: Rename include guard.
14700 * nat/gdb_ptrace.h: Rename include guard.
14701 * nat/fork-inferior.h: Rename include guard.
14702 * nat/amd64-linux-siginfo.h: Rename include guard.
14703 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14704 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14705 * nat/aarch64-linux.h: Rename include guard.
14706 * nat/aarch64-linux-hw-point.h: Rename include guard.
14707 * mn10300-tdep.h: Add include guard.
14708 * mips-linux-tdep.h: Add include guard.
14709 * mi/mi-parse.h: Rename include guard.
14710 * mi/mi-out.h: Rename include guard.
14711 * mi/mi-main.h: Rename include guard.
14712 * mi/mi-interp.h: Rename include guard.
14713 * mi/mi-getopt.h: Rename include guard.
14714 * mi/mi-console.h: Rename include guard.
14715 * mi/mi-common.h: Rename include guard.
14716 * mi/mi-cmds.h: Rename include guard.
14717 * mi/mi-cmd-break.h: Rename include guard.
14718 * m2-lang.h: Add include guard.
14719 * location.h: Rename include guard.
14720 * linux-record.h: Rename include guard.
14721 * linux-nat.h: Add include guard.
14722 * linux-fork.h: Add include guard.
14723 * i386-darwin-tdep.h: Rename include guard.
14724 * hppa-linux-offsets.h: Add include guard.
14725 * guile/guile.h: Rename include guard.
14726 * guile/guile-internal.h: Rename include guard.
14727 * gnu-nat.h: Rename include guard.
14728 * gdb-stabs.h: Rename include guard.
14729 * frv-tdep.h: Add include guard.
14730 * f-lang.h: Add include guard.
14731 * event-loop.h: Add include guard.
14732 * darwin-nat.h: Rename include guard.
14733 * cp-abi.h: Rename include guard.
14734 * config/sparc/nm-sol2.h: Rename include guard.
14735 * config/nm-nto.h: Rename include guard.
14736 * config/nm-linux.h: Add include guard.
14737 * config/i386/nm-i386gnu.h: Rename include guard.
14738 * config/djgpp/nl_types.h: Rename include guard.
14739 * config/djgpp/langinfo.h: Rename include guard.
14740 * compile/gcc-cp-plugin.h: Add include guard.
14741 * compile/gcc-c-plugin.h: Add include guard.
14742 * compile/compile.h: Rename include guard.
14743 * compile/compile-object-run.h: Rename include guard.
14744 * compile/compile-object-load.h: Rename include guard.
14745 * compile/compile-internal.h: Rename include guard.
14746 * compile/compile-cplus.h: Rename include guard.
14747 * compile/compile-c.h: Rename include guard.
14748 * common/xml-utils.h: Rename include guard.
14749 * common/x86-xstate.h: Rename include guard.
14750 * common/version.h: Rename include guard.
14751 * common/vec.h: Rename include guard.
14752 * common/tdesc.h: Rename include guard.
14753 * common/selftest.h: Rename include guard.
14754 * common/scoped_restore.h: Rename include guard.
14755 * common/scoped_mmap.h: Rename include guard.
14756 * common/scoped_fd.h: Rename include guard.
14757 * common/safe-iterator.h: Rename include guard.
14758 * common/run-time-clock.h: Rename include guard.
14759 * common/refcounted-object.h: Rename include guard.
14760 * common/queue.h: Rename include guard.
14761 * common/ptid.h: Rename include guard.
14762 * common/print-utils.h: Rename include guard.
14763 * common/preprocessor.h: Rename include guard.
14764 * common/pathstuff.h: Rename include guard.
14765 * common/observable.h: Rename include guard.
14766 * common/netstuff.h: Rename include guard.
14767 * common/job-control.h: Rename include guard.
14768 * common/host-defs.h: Rename include guard.
14769 * common/gdb_wait.h: Rename include guard.
14770 * common/gdb_vecs.h: Rename include guard.
14771 * common/gdb_unlinker.h: Rename include guard.
14772 * common/gdb_unique_ptr.h: Rename include guard.
14773 * common/gdb_tilde_expand.h: Rename include guard.
14774 * common/gdb_sys_time.h: Rename include guard.
14775 * common/gdb_string_view.h: Rename include guard.
14776 * common/gdb_splay_tree.h: Rename include guard.
14777 * common/gdb_setjmp.h: Rename include guard.
14778 * common/gdb_ref_ptr.h: Rename include guard.
14779 * common/gdb_optional.h: Rename include guard.
14780 * common/gdb_locale.h: Rename include guard.
14781 * common/gdb_assert.h: Rename include guard.
14782 * common/filtered-iterator.h: Rename include guard.
14783 * common/filestuff.h: Rename include guard.
14784 * common/fileio.h: Rename include guard.
14785 * common/environ.h: Rename include guard.
14786 * common/common-utils.h: Rename include guard.
14787 * common/common-types.h: Rename include guard.
14788 * common/common-regcache.h: Rename include guard.
14789 * common/common-inferior.h: Rename include guard.
14790 * common/common-gdbthread.h: Rename include guard.
14791 * common/common-exceptions.h: Rename include guard.
14792 * common/common-defs.h: Rename include guard.
14793 * common/common-debug.h: Rename include guard.
14794 * common/cleanups.h: Rename include guard.
14795 * common/buffer.h: Rename include guard.
14796 * common/btrace-common.h: Rename include guard.
14797 * common/break-common.h: Rename include guard.
14798 * cli/cli-utils.h: Rename include guard.
14799 * cli/cli-style.h: Rename include guard.
14800 * cli/cli-setshow.h: Rename include guard.
14801 * cli/cli-script.h: Rename include guard.
14802 * cli/cli-interp.h: Rename include guard.
14803 * cli/cli-decode.h: Rename include guard.
14804 * cli/cli-cmds.h: Rename include guard.
14805 * charset-list.h: Add include guard.
14806 * buildsym-legacy.h: Rename include guard.
14807 * bfin-tdep.h: Add include guard.
14808 * ax.h: Rename include guard.
14809 * arm-linux-tdep.h: Add include guard.
14810 * arm-fbsd-tdep.h: Add include guard.
14811 * arch/xtensa.h: Rename include guard.
14812 * arch/tic6x.h: Add include guard.
14813 * arch/i386.h: Add include guard.
14814 * arch/arm.h: Rename include guard.
14815 * arch/arm-linux.h: Rename include guard.
14816 * arch/arm-get-next-pcs.h: Rename include guard.
14817 * arch/amd64.h: Add include guard.
14818 * arch/aarch64-insn.h: Rename include guard.
14819 * arch-utils.h: Rename include guard.
14820 * annotate.h: Add include guard.
14821 * amd64-darwin-tdep.h: Rename include guard.
14822 * aarch64-linux-tdep.h: Add include guard.
14823 * aarch64-fbsd-tdep.h: Add include guard.
14824 * aarch32-linux-nat.h: Add include guard.
14825
148262019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14827
14828 * macrotab.c (macro_define_internal): New function that
14829 factorizes macro_define_object_internal and macro_define_function
14830 code.
14831 (macro_define_object_internal): Use macro_define_internal.
14832 (macro_define_function): Likewise.
14833
148342019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14835
14836 * macrocmd.c (extract_identifier): Return
14837 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14838 callers.
14839
148402019-02-06 John Baldwin <jhb@FreeBSD.org>
14841
14842 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14843
148442019-02-05 Tom Tromey <tom@tromey.com>
14845
14846 * target.c (target_stack::unpush): Move assertion earlier.
14847
148482019-01-30 Tom Tromey <tom@tromey.com>
14849
14850 PR python/23615:
14851 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14852 (gdbpy_parse_and_eval): Likewise.
14853 * python/python-internal.h (gdbpy_allow_threads): New class.
14854
148552019-01-28 John Baldwin <jhb@FreeBSD.org>
14856
14857 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14858 (aarch64_fbsd_fpregmap): Move earlier.
14859 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14860 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14861 instead of individual calls to trad_frame_set_reg_addr.
14862 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14863 earlier.
14864 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14865 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14866 instead of individual calls to trad_frame_set_reg_addr.
14867
148682019-01-28 Alan Hayward <alan.hayward@arm.com>
14869
14870 * CONTRIBUTE: Replace contribution list with wiki link.
14871
148722019-01-25 Tom Tromey <tom@tromey.com>
14873
14874 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14875
148762019-01-25 Tom Tromey <tom@tromey.com>
14877
14878 * xtensa-linux-nat.c: Fix common/ includes.
14879 * xml-support.h: Fix common/ includes.
14880 * xml-support.c: Fix common/ includes.
14881 * x86-linux-nat.c: Fix common/ includes.
14882 * windows-nat.c: Fix common/ includes.
14883 * varobj.h: Fix common/ includes.
14884 * varobj.c: Fix common/ includes.
14885 * value.c: Fix common/ includes.
14886 * valops.c: Fix common/ includes.
14887 * utils.c: Fix common/ includes.
14888 * unittests/xml-utils-selftests.c: Fix common/ includes.
14889 * unittests/utils-selftests.c: Fix common/ includes.
14890 * unittests/unpack-selftests.c: Fix common/ includes.
14891 * unittests/tracepoint-selftests.c: Fix common/ includes.
14892 * unittests/style-selftests.c: Fix common/ includes.
14893 * unittests/string_view-selftests.c: Fix common/ includes.
14894 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14895 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14896 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14897 * unittests/rsp-low-selftests.c: Fix common/ includes.
14898 * unittests/parse-connection-spec-selftests.c: Fix common/
14899 includes.
14900 * unittests/optional-selftests.c: Fix common/ includes.
14901 * unittests/offset-type-selftests.c: Fix common/ includes.
14902 * unittests/observable-selftests.c: Fix common/ includes.
14903 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14904 * unittests/memrange-selftests.c: Fix common/ includes.
14905 * unittests/memory-map-selftests.c: Fix common/ includes.
14906 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14907 * unittests/function-view-selftests.c: Fix common/ includes.
14908 * unittests/environ-selftests.c: Fix common/ includes.
14909 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14910 * unittests/common-utils-selftests.c: Fix common/ includes.
14911 * unittests/cli-utils-selftests.c: Fix common/ includes.
14912 * unittests/array-view-selftests.c: Fix common/ includes.
14913 * ui-file.c: Fix common/ includes.
14914 * tui/tui-io.c: Fix common/ includes.
14915 * tracepoint.h: Fix common/ includes.
14916 * tracepoint.c: Fix common/ includes.
14917 * tracefile-tfile.c: Fix common/ includes.
14918 * top.h: Fix common/ includes.
14919 * top.c: Fix common/ includes.
14920 * thread.c: Fix common/ includes.
14921 * target/waitstatus.h: Fix common/ includes.
14922 * target/waitstatus.c: Fix common/ includes.
14923 * target.h: Fix common/ includes.
14924 * target.c: Fix common/ includes.
14925 * target-memory.c: Fix common/ includes.
14926 * target-descriptions.c: Fix common/ includes.
14927 * symtab.h: Fix common/ includes.
14928 * symfile.c: Fix common/ includes.
14929 * stap-probe.c: Fix common/ includes.
14930 * spu-linux-nat.c: Fix common/ includes.
14931 * sparc-nat.c: Fix common/ includes.
14932 * source.c: Fix common/ includes.
14933 * solib.c: Fix common/ includes.
14934 * solib-target.c: Fix common/ includes.
14935 * ser-unix.c: Fix common/ includes.
14936 * ser-tcp.c: Fix common/ includes.
14937 * ser-pipe.c: Fix common/ includes.
14938 * ser-base.c: Fix common/ includes.
14939 * selftest-arch.c: Fix common/ includes.
14940 * s12z-tdep.c: Fix common/ includes.
14941 * rust-exp.y: Fix common/ includes.
14942 * rs6000-aix-tdep.c: Fix common/ includes.
14943 * riscv-tdep.c: Fix common/ includes.
14944 * remote.c: Fix common/ includes.
14945 * remote-notif.h: Fix common/ includes.
14946 * remote-fileio.h: Fix common/ includes.
14947 * remote-fileio.c: Fix common/ includes.
14948 * regcache.h: Fix common/ includes.
14949 * regcache.c: Fix common/ includes.
14950 * record-btrace.c: Fix common/ includes.
14951 * python/python.c: Fix common/ includes.
14952 * python/py-type.c: Fix common/ includes.
14953 * python/py-inferior.c: Fix common/ includes.
14954 * progspace.h: Fix common/ includes.
14955 * producer.c: Fix common/ includes.
14956 * procfs.c: Fix common/ includes.
14957 * proc-api.c: Fix common/ includes.
14958 * printcmd.c: Fix common/ includes.
14959 * ppc-linux-nat.c: Fix common/ includes.
14960 * parser-defs.h: Fix common/ includes.
14961 * osdata.c: Fix common/ includes.
14962 * obsd-nat.c: Fix common/ includes.
14963 * nat/x86-linux.c: Fix common/ includes.
14964 * nat/x86-linux-dregs.c: Fix common/ includes.
14965 * nat/x86-dregs.h: Fix common/ includes.
14966 * nat/x86-dregs.c: Fix common/ includes.
14967 * nat/ppc-linux.c: Fix common/ includes.
14968 * nat/mips-linux-watch.h: Fix common/ includes.
14969 * nat/mips-linux-watch.c: Fix common/ includes.
14970 * nat/linux-waitpid.c: Fix common/ includes.
14971 * nat/linux-ptrace.h: Fix common/ includes.
14972 * nat/linux-ptrace.c: Fix common/ includes.
14973 * nat/linux-procfs.c: Fix common/ includes.
14974 * nat/linux-personality.c: Fix common/ includes.
14975 * nat/linux-osdata.c: Fix common/ includes.
14976 * nat/linux-namespaces.c: Fix common/ includes.
14977 * nat/linux-btrace.h: Fix common/ includes.
14978 * nat/linux-btrace.c: Fix common/ includes.
14979 * nat/fork-inferior.c: Fix common/ includes.
14980 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14981 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14982 * nat/aarch64-linux.c: Fix common/ includes.
14983 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14984 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14985 * namespace.h: Fix common/ includes.
14986 * mips-linux-tdep.c: Fix common/ includes.
14987 * minsyms.c: Fix common/ includes.
14988 * mi/mi-parse.h: Fix common/ includes.
14989 * mi/mi-main.c: Fix common/ includes.
14990 * mi/mi-cmd-env.c: Fix common/ includes.
14991 * memrange.h: Fix common/ includes.
14992 * memattr.c: Fix common/ includes.
14993 * maint.h: Fix common/ includes.
14994 * maint.c: Fix common/ includes.
14995 * main.c: Fix common/ includes.
14996 * machoread.c: Fix common/ includes.
14997 * location.c: Fix common/ includes.
14998 * linux-thread-db.c: Fix common/ includes.
14999 * linux-nat.c: Fix common/ includes.
15000 * linux-fork.c: Fix common/ includes.
15001 * inline-frame.c: Fix common/ includes.
15002 * infrun.c: Fix common/ includes.
15003 * inflow.c: Fix common/ includes.
15004 * inferior.h: Fix common/ includes.
15005 * inferior.c: Fix common/ includes.
15006 * infcmd.c: Fix common/ includes.
15007 * inf-ptrace.c: Fix common/ includes.
15008 * inf-child.c: Fix common/ includes.
15009 * ia64-linux-nat.c: Fix common/ includes.
15010 * i387-tdep.c: Fix common/ includes.
15011 * i386-tdep.c: Fix common/ includes.
15012 * i386-linux-tdep.c: Fix common/ includes.
15013 * i386-linux-nat.c: Fix common/ includes.
15014 * i386-go32-tdep.c: Fix common/ includes.
15015 * i386-fbsd-tdep.c: Fix common/ includes.
15016 * i386-fbsd-nat.c: Fix common/ includes.
15017 * guile/scm-type.c: Fix common/ includes.
15018 * guile/guile.c: Fix common/ includes.
15019 * go32-nat.c: Fix common/ includes.
15020 * gnu-nat.c: Fix common/ includes.
15021 * gdbthread.h: Fix common/ includes.
15022 * gdbarch-selftests.c: Fix common/ includes.
15023 * gdb_usleep.c: Fix common/ includes.
15024 * gdb_select.h: Fix common/ includes.
15025 * gdb_bfd.c: Fix common/ includes.
15026 * gcore.c: Fix common/ includes.
15027 * fork-child.c: Fix common/ includes.
15028 * findvar.c: Fix common/ includes.
15029 * fbsd-nat.c: Fix common/ includes.
15030 * event-top.c: Fix common/ includes.
15031 * event-loop.c: Fix common/ includes.
15032 * dwarf2read.c: Fix common/ includes.
15033 * dwarf2loc.c: Fix common/ includes.
15034 * dwarf2-frame.c: Fix common/ includes.
15035 * dwarf-index-cache.c: Fix common/ includes.
15036 * dtrace-probe.c: Fix common/ includes.
15037 * disasm-selftests.c: Fix common/ includes.
15038 * defs.h: Fix common/ includes.
15039 * csky-tdep.c: Fix common/ includes.
15040 * cp-valprint.c: Fix common/ includes.
15041 * cp-support.h: Fix common/ includes.
15042 * cp-support.c: Fix common/ includes.
15043 * corelow.c: Fix common/ includes.
15044 * completer.h: Fix common/ includes.
15045 * completer.c: Fix common/ includes.
15046 * compile/compile.c: Fix common/ includes.
15047 * compile/compile-loc2c.c: Fix common/ includes.
15048 * compile/compile-cplus-types.c: Fix common/ includes.
15049 * compile/compile-cplus-symbols.c: Fix common/ includes.
15050 * command.h: Fix common/ includes.
15051 * cli/cli-dump.c: Fix common/ includes.
15052 * cli/cli-cmds.c: Fix common/ includes.
15053 * charset.c: Fix common/ includes.
15054 * build-id.c: Fix common/ includes.
15055 * btrace.h: Fix common/ includes.
15056 * btrace.c: Fix common/ includes.
15057 * breakpoint.h: Fix common/ includes.
15058 * breakpoint.c: Fix common/ includes.
15059 * ax.h:
15060 (enum agent_op): Fix common/ includes.
15061 * ax-general.c (struct aop_map): Fix common/ includes.
15062 * ax-gdb.c: Fix common/ includes.
15063 * auxv.c: Fix common/ includes.
15064 * auto-load.c: Fix common/ includes.
15065 * arm-tdep.c: Fix common/ includes.
15066 * arch/riscv.c: Fix common/ includes.
15067 * arch/ppc-linux-common.c: Fix common/ includes.
15068 * arch/i386.c: Fix common/ includes.
15069 * arch/arm.c: Fix common/ includes.
15070 * arch/arm-linux.c: Fix common/ includes.
15071 * arch/arm-get-next-pcs.c: Fix common/ includes.
15072 * arch/amd64.c: Fix common/ includes.
15073 * arch/aarch64.c: Fix common/ includes.
15074 * arch/aarch64-insn.c: Fix common/ includes.
15075 * arch-utils.c: Fix common/ includes.
15076 * amd64-windows-tdep.c: Fix common/ includes.
15077 * amd64-tdep.c: Fix common/ includes.
15078 * amd64-sol2-tdep.c: Fix common/ includes.
15079 * amd64-obsd-tdep.c: Fix common/ includes.
15080 * amd64-nbsd-tdep.c: Fix common/ includes.
15081 * amd64-linux-tdep.c: Fix common/ includes.
15082 * amd64-linux-nat.c: Fix common/ includes.
15083 * amd64-fbsd-tdep.c: Fix common/ includes.
15084 * amd64-fbsd-nat.c: Fix common/ includes.
15085 * amd64-dicos-tdep.c: Fix common/ includes.
15086 * amd64-darwin-tdep.c: Fix common/ includes.
15087 * agent.c: Fix common/ includes.
15088 * ada-lang.h: Fix common/ includes.
15089 * ada-lang.c: Fix common/ includes.
15090 * aarch64-tdep.c: Fix common/ includes.
15091
150922019-01-25 Tom Tromey <tom@tromey.com>
15093
15094 * common/create-version.sh: Use common/version.h.
15095
150962019-01-24 Pedro Alves <palves@redhat.com>
15097
15098 * infrun.c (signal_stop, signal_print, signal_program)
15099 (signal_catch, signal_pass): Now arrays instead of pointers.
15100 (update_signals_program_target, do_target_resume)
15101 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15102 * linux-nat.c (linux_nat_target::pass_signals)
15103 (linux_nat_target::create_inferior, linux_nat_target::attach):
15104 Adjust.
15105 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15106 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15107 * procfs.c (procfs_target::pass_signals): Adjust.
15108 * record-full.c (record_full_target::resume): Adjust.
15109 * remote.c (remote_target::pass_signals)
15110 (remote_target::program_signals): Adjust.
15111 * target-debug.h (target_debug_print_signals): Now takes a
15112 gdb::array_view as parameter. Adjust.
15113 * target.h (target_ops) <pass_signals, program_signals>: Replace
15114 pointer and length parameters with gdb::array_view.
15115 (target_pass_signals, target_program_signals): Likewise.
15116 * target-delegates.c: Regenerate.
15117
151182019-01-24 Pedro Alves <palves@redhat.com>
15119
15120 * common/forward-scope-exit.h
15121 (forward_scope_exit::forward_scope_exit): Pass arguments to
15122 m_bind_function directly, instead of creating a std::bind and
15123 copying that.
15124
151252019-01-24 Alan Hayward <alan.hayward@arm.com>
15126
15127 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15128 for static members.
15129 (pass_in_v_vfp_candidate): Likewise.
15130
151312019-01-23 Tom Tromey <tom@tromey.com>
15132 Pedro Alves <palves@redhat.com>
15133
15134 * regcache.c (class regcache_invalidator): Remove.
15135 (regcache::raw_write): Use make_scope_exit.
15136
151372019-01-23 Tom Tromey <tom@tromey.com>
15138
15139 * ui-out.h (class ui_out_emit_type): Update comment.
15140
151412019-01-23 Tom Tromey <tom@tromey.com>
15142
15143 * infrun.c (fetch_inferior_event): Update comment.
15144
151452019-01-23 Tom Tromey <tom@tromey.com>
15146 Pedro Alves <palves@redhat.com>
15147
15148 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15149 parameter.
15150 (fetch_inferior_event): Use SCOPE_EXIT.
15151
15152
151532019-01-23 Tom Tromey <tom@tromey.com>
15154 Pedro Alves <palves@redhat.com>
15155
15156 * infrun.c (disable_thread_events): Delete.
15157 (stop_all_threads): Use SCOPE_EXIT.
15158
151592019-01-23 Tom Tromey <tom@tromey.com>
15160 Pedro Alves <palves@redhat.com>
15161
15162 * symfile.c: Include forward-scope-exit.h.
15163 (clear_symtab_users_cleanup): Replace forward declaration with
15164 a FORWARD_SCOPE_EXIT.
15165 (syms_from_objfile_1): Use the forward_scope_exit and
15166 gdb::optional instead of cleanup_function.
15167 (reread_symbols): Use the forward_scope_exit instead of
15168 cleanup_function.
15169 (clear_symtab_users_cleanup): Remove function.
15170
151712019-01-23 Tom Tromey <tom@tromey.com>
15172 Pedro Alves <palves@redhat.com>
15173
15174 * linux-nat.c: Include scope-exit.h.
15175 (cleanup_target_stop): Remove.
15176 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15177 SCOPE_EXIT.
15178
151792019-01-23 Tom Tromey <tom@tromey.com>
15180 Pedro Alves <palves@redhat.com>
15181
15182 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15183 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15184
151852019-01-23 Tom Tromey <tom@tromey.com>
15186 Andrew Burgess <andrew.burgess@embecosm.com>
15187 Pedro Alves <palves@redhat.com>
15188
15189 * infrun.c (fetch_inferior_event): Use scope_exit.
15190 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15191 * top.c (execute_command): Use scope_exit.
15192 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15193 * utils.c (do_bpstat_clear_actions_cleanup)
15194 (make_bpstat_clear_actions_cleanup): Remove.
15195
151962019-01-23 Tom Tromey <tom@tromey.com>
15197 Pedro Alves <palves@redhat.com>
15198
15199 * infrun.c: Include "common/scope-exit.h"
15200 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15201 (wait_for_inferior): Use SCOPE_EXIT.
15202 (fetch_inferior_event): Use scope_exit.
15203
152042019-01-23 Tom Tromey <tom@tromey.com>
15205 Pedro Alves <palves@redhat.com>
15206
15207 * breakpoint.c (create_breakpoint): Remove cleanup.
15208
152092019-01-23 Tom Tromey <tom@tromey.com>
15210 Andrew Burgess <andrew.burgess@embecosm.com>
15211 Pedro Alves <palves@redhat.com>
15212
152132019-01-23 Pedro Alves <palves@redhat.com>
15214
15215 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15216
152172019-01-23 Pedro Alves <palves@redhat.com>
15218 Andrew Burgess <andrew.burgess@embecosm.com>
15219
15220 * gdbthread.h: Include "common/forward-scope-exit.h".
15221 (scoped_finish_thread_state): Redefine custom class in terms of
15222 forward_scope_exit.
15223
152242019-01-23 Pedro Alves <palves@redhat.com>
15225 Andrew Burgess <andrew.burgess@embecosm.com>
15226
15227 * common/forward-scope-exit.h: New file.
15228
152292019-01-23 Pedro Alves <palves@redhat.com>
15230 Andrew Burgess <andrew.burgess@embecosm.com>
15231 Tom Tromey <tom@tromey.com>
15232
15233 * common/scope-exit.h: New file.
15234
152352019-01-23 Pedro Alves <palves@redhat.com>
15236
15237 * common/preprocessor.h (ESC): Rename to ...
15238 (ESC_PARENS): ... this.
15239 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15240 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15241
152422019-01-23 Tom Tromey <tom@tromey.com>
15243
15244 * language.h (class scoped_switch_to_sym_language_if_auto):
15245 Initialize m_lang in both cases.
15246
152472019-01-23 Alan Hayward <alan.hayward@arm.com>
15248
15249 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15250 with XCNEW.
15251
152522019-01-22 Tom Tromey <tom@tromey.com>
15253
15254 * corelow.c: Do not include sys/file.h.
15255
152562019-01-22 Tom Tromey <tom@tromey.com>
15257
15258 * tui/tui-wingeneral.h: Include gdb_curses.h.
15259
152602019-01-22 Tom Tromey <tom@tromey.com>
15261
15262 * source-cache.h (class source_cache) <get_source_lines,
15263 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15264
152652019-01-22 Tom Tromey <tom@tromey.com>
15266
15267 * remote-fileio.h (struct remote_target): Declare.
15268
152692019-01-22 Tom Tromey <tom@tromey.com>
15270
15271 * python/py-arch.c: Do not include py-ref.h.
15272 * python/py-bpevent.c: Do not include py-ref.h.
15273 * python/py-cmd.c: Do not include py-ref.h.
15274 * python/py-continueevent.c: Do not include py-ref.h.
15275 * python/py-event.h: Do not include py-ref.h.
15276 * python/py-evtregistry.c: Do not include py-ref.h.
15277 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15278 * python/py-frame.c: Do not include py-ref.h.
15279 * python/py-framefilter.c: Do not include py-ref.h.
15280 * python/py-function.c: Do not include py-ref.h.
15281 * python/py-infevents.c: Do not include py-ref.h.
15282 * python/py-linetable.c: Do not include py-ref.h.
15283 * python/py-objfile.c: Do not include py-ref.h.
15284 * python/py-param.c: Do not include py-ref.h.
15285 * python/py-prettyprint.c: Do not include py-ref.h.
15286 * python/py-progspace.c: Do not include py-ref.h.
15287 * python/py-symbol.c: Do not include py-ref.h.
15288 * python/py-symtab.c: Do not include py-ref.h.
15289 * python/py-type.c: Do not include py-ref.h.
15290 * python/py-unwind.c: Do not include py-ref.h.
15291 * python/py-utils.c: Do not include py-ref.h.
15292 * python/py-value.c: Do not include py-ref.h.
15293 * python/py-varobj.c: Do not include py-ref.h.
15294 * python/py-xmethods.c: Do not include py-ref.h.
15295 * python/python.c: Do not include py-ref.h.
15296 * varobj.c: Do not include py-ref.h.
15297
152982019-01-22 Tom Tromey <tom@tromey.com>
15299
15300 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15301 keyword for bcache.
15302
153032019-01-22 Tom Tromey <tom@tromey.com>
15304
15305 * compile/compile-cplus-types.c: Remove a comment by #include.
15306
153072019-01-22 Tom Tromey <tom@tromey.com>
15308
15309 * compile/gcc-c-plugin.h: Include compile-internal.h.
15310
153112019-01-22 Tom Tromey <tom@tromey.com>
15312
15313 * stabsread.c (EXTERN): Do not define.
15314 (symnum, next_symbol_text_func, processing_gcc_compilation)
15315 (within_function, global_sym_chain, global_stabs)
15316 (previous_stab_code, this_object_header_files)
15317 (n_this_object_header_files)
15318 (n_allocated_this_object_header_files): Define.
15319 * stabsread.h (EXTERN): Never define. Use "extern".
15320
153212019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15322
15323 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15324 history_value.
15325
153262019-01-21 Tom Tromey <tom@tromey.com>
15327
15328 * ui-out.c: Fix includes.
15329 * tui/tui-source.c: Fix includes.
15330 * target.c: Fix includes.
15331 * remote.c: Fix includes.
15332 * regcache.c: Fix includes.
15333 * python/py-block.c: Fix includes.
15334 * printcmd.c: Fix includes.
15335 * or1k-tdep.c: Fix includes.
15336 * mi/mi-main.c: Fix includes.
15337 * m32r-tdep.c: Fix includes.
15338 * csky-tdep.c: Fix includes.
15339 * compile/compile-cplus-types.c: Fix includes.
15340 * cli/cli-interp.c: Fix includes.
15341
153422019-01-21 Alan Hayward <alan.hayward@arm.com>
15343
15344 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15345 for padding.
15346
153472019-01-16 Tom Tromey <tom@tromey.com>
15348
15349 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15350 earlier.
15351 (struct objfile) <msymbols_range>: Move from top level.
15352 <msymbols>: New method.
15353 (class objfile_msymbols): Remove.
15354 * symtab.c (default_collect_symbol_completion_matches_break_on):
15355 Update.
15356 * symmisc.c (dump_msymbols): Update.
15357 * stabsread.c (scan_file_globals): Update.
15358 * objc-lang.c (info_selectors_command, info_classes_command)
15359 (find_methods): Update.
15360 * minsyms.c (find_solib_trampoline_target): Update.
15361 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15362 * coffread.c (coff_symfile_read): Update.
15363 * ada-lang.c (ada_lookup_simple_minsym)
15364 (ada_collect_symbol_completion_matches): Update.
15365
153662019-01-16 Tom Tromey <tom@tromey.com>
15367
15368 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15369 type. Remove no-argument constructor.
15370 <iterator::operator++>: Simplify.
15371 <begin>: Update.
15372 <end>: Use minimal_symbol_count.
15373
153742019-01-16 Tom Tromey <tom@tromey.com>
15375
15376 * objfiles.h (struct objfile) <psymtabs>: New method.
15377 (class objfile_psymtabs): Remove.
15378 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15379 typedef.
15380 <range>: New method.
15381 (require_partial_symbols): Change return type.
15382 * psymtab.c (require_partial_symbols)
15383 (psym_expand_symtabs_matching): Update.
15384 * mdebugread.c (parse_partial_symbols): Update.
15385 * dbxread.c (dbx_end_psymtab): Update.
15386
153872019-01-15 Tom Tromey <tom@tromey.com>
15388
15389 * symtab.c (lookup_objfile_from_block)
15390 (lookup_symbol_in_objfile_symtabs)
15391 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15392 (find_line_symtab, info_sources_command)
15393 (default_collect_symbol_completion_matches_break_on)
15394 (make_source_files_completion_list): Update.
15395 * symmisc.c (print_objfile_statistics, dump_objfile)
15396 (maintenance_print_symbols, maintenance_info_symtabs)
15397 (maintenance_check_symtabs, maintenance_info_line_tables):
15398 Update.
15399 * source.c (select_source_symtab)
15400 (forget_cached_source_info_for_objfile): Update.
15401 * objfiles.h (class objfile_compunits): Remove.
15402 (struct objfile) <compunits_range>: New typedef.
15403 (compunits): New method.
15404 * objfiles.c (objfile_relocate1): Update.
15405 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15406 * maint.c (count_symtabs_and_blocks): Update.
15407 * linespec.c (iterate_over_all_matching_symtabs): Update.
15408 * cp-support.c (add_symbol_overload_list_qualified): Update.
15409 * coffread.c (coff_symtab_read): Update.
15410 * ada-lang.c (add_nonlocal_symbols)
15411 (ada_collect_symbol_completion_matches)
15412 (ada_add_global_exceptions): Update.
15413
154142019-01-15 Tom Tromey <tom@tromey.com>
15415
15416 * progspace.h (program_space) <objfiles_safe_range>: New
15417 typedef.
15418 <objfiles_safe>: New method.
15419 * objfiles.h (class all_objfiles_safe): Remove.
15420 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15421 * jit.c (jit_inferior_exit_hook): Update.
15422
154232019-01-17 Tom Tromey <tom@tromey.com>
15424
15425 * progspace.h (program_space) <objfiles_range>: New typedef.
15426 <objfiles>: New method.
15427 <objfiles_head>: Rename from objfiles.
15428 (object_files): Update.
15429 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15430 * guile/scm-pretty-print.c
15431 (ppscm_find_pretty_printer_from_objfiles): Update.
15432 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15433 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15434 Update.
15435 * python/py-progspace.c (pspy_get_objfiles): Update.
15436 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15437 Update.
15438 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15439 (objfpy_lookup_objfile_by_build_id): Update.
15440 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15441 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15442 Update.
15443 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15444 (expand_symtab_containing_pc, lookup_objfile_from_block)
15445 (lookup_static_symbol, basic_lookup_transparent_type)
15446 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15447 (find_line_symtab, info_sources_command)
15448 (default_collect_symbol_completion_matches_break_on)
15449 (make_source_files_completion_list, find_main_name): Update.
15450 * symmisc.c (print_symbol_bcache_statistics)
15451 (print_objfile_statistics, maintenance_print_symbols)
15452 (maintenance_print_msymbols, maintenance_print_objfiles)
15453 (maintenance_info_symtabs, maintenance_check_symtabs)
15454 (maintenance_expand_symtabs, maintenance_info_line_tables):
15455 Update.
15456 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15457 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15458 (map_overlay_command, unmap_overlay_command)
15459 (simple_overlay_update, expand_symtabs_matching)
15460 (map_symbol_filenames): Update.
15461 * symfile-debug.c (set_debug_symfile): Update.
15462 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15463 Update.
15464 * source.c (select_source_symtab, forget_cached_source_info):
15465 Update.
15466 * solib.c (solib_read_symbols): Update.
15467 * solib-spu.c (append_ocl_sos): Update.
15468 * psymtab.c (maintenance_print_psymbols)
15469 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15470 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15471 * printcmd.c (info_symbol_command): Update.
15472 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15473 Update.
15474 * objfiles.h (class all_objfiles): Remove.
15475 * objfiles.c (have_partial_symbols, have_full_symbols)
15476 (have_minimal_symbols, qsort_cmp, update_section_map)
15477 (shared_objfile_contains_address_p)
15478 (default_iterate_over_objfiles_in_search_order): Update.
15479 * objc-lang.c (info_selectors_command, info_classes_command)
15480 (find_methods): Update.
15481 * minsyms.c (find_solib_trampoline_target): Update.
15482 * maint.c (maintenance_info_sections)
15483 (maintenance_translate_address, count_symtabs_and_blocks):
15484 Update.
15485 * main.c (captured_main_1): Update.
15486 * linux-thread-db.c (try_thread_db_load_from_pdir)
15487 (has_libpthread): Update.
15488 * linespec.c (iterate_over_all_matching_symtabs)
15489 (search_minsyms_for_name): Update.
15490 * jit.c (jit_find_objf_with_entry_addr): Update.
15491 * hppa-tdep.c (find_unwind_entry)
15492 (hppa_lookup_stub_minimal_symbol): Update.
15493 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15494 Update.
15495 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15496 (elf_gnu_ifunc_resolve_by_got): Update.
15497 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15498 * dwarf-index-write.c (save_gdb_index_command): Update.
15499 * cp-support.c (add_symbol_overload_list_qualified): Update.
15500 * breakpoint.c (create_overlay_event_breakpoint)
15501 (create_longjmp_master_breakpoint)
15502 (create_std_terminate_master_breakpoint)
15503 (create_exception_master_breakpoint): Update.
15504 * blockframe.c (find_pc_partial_function): Update.
15505 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15506 (ada_collect_symbol_completion_matches)
15507 (ada_add_global_exceptions): Update.
15508
155092019-01-17 Tom Tromey <tom@tromey.com>
15510
15511 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15512 declare VEC.
15513 (solib_target_parse_libraries): Change return type.
15514 (library_list_start_segment, library_list_start_section)
15515 (library_list_end_library, library_list_start_library); Update.
15516 (solib_target_free_library_list): Remove.
15517 (solib_target_parse_libraries): Remove cleanup. Change return
15518 type.
15519 (solib_target_current_sos): Update.
15520
155212019-01-17 Tom Tromey <tromey@bapiya>
15522
15523 * valprint.c: Replace "the the" with "the".
15524 * symtab.c: Replace "the the" with "the".
15525 * solib.c: Replace "the the" with "the".
15526 * solib-dsbt.c: Replace "the the" with "the".
15527 * linespec.c: Replace "the the" with "the".
15528 * dwarf2loc.h: Replace "the the" with "the".
15529 * amd64-windows-tdep.c: Replace "the the" with "the".
15530 * aarch64-tdep.c: Replace "the the" with "the".
15531
155322019-01-16 Keith Seitz <keiths@redhat.com>
15533
15534 PR gdb/23773
15535 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15536 <builder>: Rename to ..
15537 <m_builder>: ... this and make private.
15538 (dwarf2_cu::get_builder): New method. Change all users of
15539 `builder' to use this method.
15540 (dwarf2_start_symtab): Move to ...
15541 (dwarf2_cu::start_symtab): ... here. Update all callers
15542 (setup_type_unit_groups): Move to ...
15543 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15544 callers.
15545 (dwarf2_cu::reset_builder): New method.
15546 (process_full_compunit, process_full_type_unit): Use
15547 dwarf2_cu::reset_builder.
15548 (follow_die_offset): Record the ancestor CU if it is different
15549 from the followed DIE's CU.
15550 (follow_die_sig_1): Likewise.
15551
155522019-01-15 Tom Tromey <tom@tromey.com>
15553
15554 * remote.c (class remote_state) <buf>: Now a char_vector.
15555 <buf_size>: Remove.
15556 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15557 parameter.
15558 (remote_target::getpkt_or_notif_sane_1)
15559 (remote_target::getpkt_sane)
15560 (remote_target::getpkt_or_notif_sane): Likewise.
15561 (class remote_target) <putpkt>: New overload.
15562 (remote_target::read_frame): Change type of "buf_p". Remove
15563 sizeof_p parameter.
15564 (packet_ok): New overload.
15565 (packet_check_result): New overload.
15566 Update all uses.
15567
155682019-01-14 Tom Tromey <tom@tromey.com>
15569
15570 * remote-notif.c (handle_notification, remote_notif_ack)
15571 (remote_notif_parse): Make "buf" const.
15572 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15573 const.
15574 (remote_notif_parse, remote_notif_ack, handle_notification):
15575 Likewise.
15576 * remote.c (remote_notif_stop_parse): Make "buf" const.
15577 (remote_target::remote_parse_stop_reply): Make "buf" const.
15578 (remote_notif_stop_ack): Make "buf" const.
15579
155802019-01-14 Tom Tromey <tom@tromey.com>
15581
15582 * remote.c (remote_console_output): Make parameter const.
15583
155842019-01-14 Tom Tromey <tom@tromey.com>
15585
15586 * target-debug.h (target_debug_print_signals): Constify.
15587 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15588 * procfs.c (procfs_target::pass_signals): Update.
15589 * linux-nat.c (linux_nat_target::pass_signals): Update.
15590 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15591 * target-delegates.c: Rebuild.
15592 * remote.c (remote_target::program_signals): Update.
15593 (remote_target::pass_signals): Update.
15594 * target.c (target_pass_signals): Constify argument.
15595 (target_program_signals): Likewise.
15596 * target.h (struct target_ops) <pass_signals, program_signals>:
15597 Constify argument.
15598 (target_pass_signals, target_program_signals): Constify argument.
15599
156002019-01-14 Tom Tromey <tom@tromey.com>
15601
15602 PR tui/28819:
15603 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15604
156052019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15606
15607 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15608 field.
15609 * rs6000-tdep.c: Include reggroups.h.
15610 (IS_V_ALIAS_PSEUDOREG): Define.
15611 (rs6000_register_name): Return names for the "vX" aliases.
15612 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15613 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15614 aliases. Call default_register_reggroup_p for all other
15615 pseudo-registers.
15616 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15617 New functions.
15618 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15619 Handle "vX" aliases.
15620 (v_alias_pseudo_register_collect): New function.
15621 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15622 (rs6000_gdbarch_init): Initialize "vX" aliases as
15623 pseudo-registers. Restore registration of
15624 rs6000_pseudo_register_reggroup_p with
15625 set_tdesc_pseudo_register_reggroup_p.
15626
156272019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15628
15629 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15630 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15631 set_gdbarch_num_pseudo_regs.
15632
156332019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15634
15635 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15636 Remove arg prefixname, add do_set and do_show.
15637 Add member functions set_list and show_list.
15638 * cli/cli-style.c (class cli_style_option): Update accordingly.
15639 (style_set_list): Move to file scope.
15640 (style_show_list): Likewise.
15641 (set_style): Call help_list.
15642 (show_style): Call cmd_show_list.
15643 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15644 Update to use the new macro.
15645
156462019-10-12 Joel Brobecker <brobecker@adacore.com>
15647
15648 * ada-lang.c (_initialize_ada_language): Expand the help text
15649 for the "catch exception" command.
15650
156512019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15652
15653 * symtab.c (matching_obj_sections): Initialize obj,
15654 declare it closer to its usage.
15655
156562019-01-10 Tom Tromey <tom@tromey.com>
15657
15658 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15659 (basic_inf_threads_range): Remove.
15660 (inf_threads_range, inf_non_exited_threads_range)
15661 (safe_inf_threads_range): Use next_adapter.
15662
156632019-01-10 Keith Seitz <keiths@redhat.com>
15664
15665 PR gdb/23712
15666 PR symtab/23010
15667 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15668 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15669
156702019-01-10 Keith Seitz <keiths@redhat.com>
15671
15672 PR gdb/23712
15673 PR symtab/23010
15674 * dictionary.c (pending_to_vector): Remove.
15675 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15676 Remove _1 suffix, replacing functions of the same name. Update
15677 all callers.
15678 (dict_create_hashed, dict_create_hashed_expandable)
15679 (dict_create_linear, dict_create_linear_expandable, dict_free)
15680 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15681 Make functions static.
15682
156832019-01-10 Keith Seitz <keiths@redhat.com>
15684
15685 PR gdb/23712
15686 PR symtab/23010
15687 * dictionary.h (struct dictionary): Replace declaration with
15688 multidictionary.
15689 (dict_create_hashed, dict_create_hashed_expandable)
15690 (dict_create_linear, dict_create_linear_expandable)
15691 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15692 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15693 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15694 taking multidictionary argument.
15695 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15696 * block.h (struct block) <dict>: Change to multidictionary
15697 and rename `multidict'.
15698 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15699 symmisc.c: Update all dictionary references to multidictionary.
15700
157012019-01-10 Keith Seitz <keiths@redhat.com>
15702
15703 PR gdb/23712
15704 PR symtab/23010
15705 * dictionary.c: Include unordered_map.
15706 (pending_to_vector): New function.
15707 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15708 Rewrite the non-"_1" functions to take vector instead
15709 of linked list.
15710 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15711 "new" _1 versions of the same name.
15712 (multidictionary): Define.
15713 (std::hash<enum language): New definition.
15714 (collate_pending_symbols_by_language, mdict_create_hashed)
15715 (mdict_create_hashed_expandable, mdict_create_linear)
15716 (mdict_create_linear_expandable, mdict_free)
15717 (find_language_dictionary, create_new_language_dictionary)
15718 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15719 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15720 (mdict_size, mdict_empty): New functions.
15721 * dictionary.h (mdict_iterator): Define.
15722
157232019-01-10 Pedro Alves <palves@redhat.com>
15724
15725 * breakpoint.c (read_uploaded_action)
15726 (create_tracepoint_from_upload): Adjust to use
15727 gdb::unique_xmalloc_ptr.
15728 * ctf.c (ctf_write_uploaded_tp):
15729 (SET_ARRAY_FIELD): Use emplace_back.
15730 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15731 * tracefile-tfile.c (tfile_write_uploaded_tp):
15732 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15733 gdb::unique_xmalloc_ptr.
15734 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15735 at_string, cond_string, cmd_strings>: Replace char pointers
15736 with gdb::unique_xmalloc_ptr.
15737
157382019-01-10 Pedro Alves <palves@redhat.com>
15739
15740 * solib-target.c (library_list_start_library): Don't xstrdup name.
15741
157422019-01-10 Pedro Alves <palves@redhat.com>
15743
15744 * mdebugread.c (parse_partial_symbols): Use
15745 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15746
157472019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15748
15749 * linux-fork.c (scoped_switch_fork_info)
15750 <~scoped_switch_fork_info>: Fix incorrect variable name.
15751
157522019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15753
15754 * linux-fork.c (scoped_switch_fork_info)
15755 <scoped_switch_fork_info>: Make explicit.
15756 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15757
157582019-01-10 Tom Tromey <tom@tromey.com>
15759
15760 * objfiles.h (objfile::reset_psymtabs): Update.
15761 * objfiles.c (objfile::objfile): Update.
15762 * psymtab.h (psymtab_storage::obstack): Update.
15763 (psymtab_storage::m_obstack): Use gdb::optional.
15764 (class psymtab_storage): Update comment. Remove objfile
15765 parameter.
15766 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15767
157682019-01-10 Tom Tromey <tom@tromey.com>
15769
15770 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15771 <free_psymtabs>: Now private.
15772 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15773 (allocate_psymtab): Use new method.
15774
157752019-01-10 Tom Tromey <tom@tromey.com>
15776
15777 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15778 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15779 * mdebugread.c (parse_partial_symbols): Use
15780 allocate_dependencies.
15781 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15782 allocate_dependencies.
15783 (process_psymtab_comp_unit_reader)
15784 (build_type_psymtab_dependencies): Likewise.
15785 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15786
157872019-01-10 Tom Tromey <tom@tromey.com>
15788
15789 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15790 PSYMBOL_SET_LANGUAGE.
15791 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15792
157932019-01-10 Tom Tromey <tom@tromey.com>
15794
15795 * psymtab.h (psymtab_storage::obstack): New method.
15796 <m_obstack>: Rename from obstack; now private.
15797 * psymtab.c (psymtab_storage): Update.
15798 * dwarf2read.c (create_addrmap_from_index)
15799 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15800 Update.
15801
158022019-01-10 Tom Tromey <tom@tromey.com>
15803
15804 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15805 * objfiles.h (objfile::reset_psymtabs): New method.
15806
158072019-01-10 Tom Tromey <tom@tromey.com>
15808
15809 * symmisc.c (print_symbol_bcache_statistics): Update.
15810 (print_objfile_statistics): Update.
15811 * symfile.c (reread_symbols): Update.
15812 * psymtab.h (class psymtab_storage): New.
15813 * psymtab.c (psymtab_storage): New constructor.
15814 (~psymtab_storage): New destructor.
15815 (require_partial_symbols): Update.
15816 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15817 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15818 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15819 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15820 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15821 (start_psymtab_common, end_psymtab_common)
15822 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15823 (allocate_psymtab): Update.
15824 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15825 Update.
15826 (dump_psymtab_addrmap, maintenance_print_psymbols)
15827 (maintenance_check_psymtabs): Update.
15828 (class objfile_psymtabs): Move to objfiles.h.
15829 * psympriv.h (discard_psymtab): Now inline.
15830 (psymtab_discarder::psymtab_discarder): Update.
15831 (psymtab_discarder::~psymtab_discarder): Update.
15832 (ALL_OBJFILE_PSYMTABS): Rewrite.
15833 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15834 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15835 Remove fields.
15836 <partial_symtabs>: New field.
15837 (class objfile_psymtabs): Move from psymtab.h. Update.
15838 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15839 psymbol_cache.
15840 (objfile::~objfile): Don't destroy psymbol_cache.
15841 * mdebugread.c (parse_partial_symbols): Update.
15842 * dwarf2read.c (create_addrmap_from_index)
15843 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15844 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15845 (add_partial_subprogram, dwarf2_ranges_read): Update.
15846 * dwarf-index-write.c (write_address_map)
15847 (write_one_signatured_type, recursively_write_psymbols)
15848 (class debug_names, class debug_names, write_psymtabs_to_index):
15849 Update.
15850
158512019-01-10 Tom Tromey <tom@tromey.com>
15852
15853 * symtab.h (SYMBOL_SET_NAMES): Update.
15854 (symbol_set_names): Update.
15855 (MSYMBOL_SET_NAMES): Update.
15856 * symtab.c (symbol_set_names): Change argument to be an
15857 objfile_per_bfd_storage.
15858 * psymtab.c (add_psymbol_to_bcache): Update.
15859 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15860
158612019-01-10 Tom Tromey <tom@tromey.com>
15862
15863 * symtab.c (create_demangled_names_hash): Change argument to be an
15864 objfile_per_bfd_storage.
15865 (symbol_set_names): Update.
15866
158672019-01-10 Tom Tromey <tom@tromey.com>
15868
15869 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15870 init_psymbol_list.
15871 * psymtab.c (init_psymbol_list): Do nothing if already called.
15872 * psympriv.h (init_psymbol_list): Add comment.
15873 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15874 init_psymbol_list.
15875 * dbxread.c (dbx_symfile_read): Unconditionally call
15876 init_psymbol_list.
15877
158782019-01-10 Tom Tromey <tom@tromey.com>
15879
15880 * xcoffread.c (scan_xcoff_symtab): Update.
15881 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15882 "where".
15883 * mdebugread.c (parse_partial_symbols)
15884 (handle_psymbol_enumerators): Update.
15885 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15886 * dbxread.c (read_dbx_symtab): Update.
15887 * psympriv.h (psymbol_placement): New enum.
15888 (add_psymbol_to_list): Update.
15889
158902019-01-10 Tom Tromey <tom@tromey.com>
15891
15892 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15893 static_psymbols parameters.
15894 (scan_xcoff_symtab): Update.
15895 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15896 static_psymbols parameters.
15897 * psympriv.h (start_psymtab_common): Update.
15898 * mdebugread.c (parse_partial_symbols): Update.
15899 * dwarf2read.c (create_partial_symtab): Update.
15900 * dbxread.c (read_dbx_symtab): Update.
15901 (start_psymtab): Remove global_psymbols and static_psymbols
15902 parameters.
15903
159042019-01-10 Tom Tromey <tom@tromey.com>
15905
15906 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15907 * psymtab.c (allocate_psymtab): Add comment.
15908 * psympriv.h (allocate_psymtab): Add comment.
15909 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15910 initializations.
15911 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15912
159132019-01-10 Tom Tromey <tom@tromey.com>
15914
15915 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15916 Don't declare.
15917 * mipsread.c: Include mdebugread.h.
15918 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15919 Declare.
15920 * elfread.c: Include mdebugread.h.
15921
159222019-01-09 Tom Tromey <tom@tromey.com>
15923
15924 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15925 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15926 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15927 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15928 (psym_lookup_symbol, psym_find_last_source_symtab)
15929 (psym_forget_cached_source_info, psym_print_stats)
15930 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15931 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15932 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15933 (psym_find_compunit_symtab_by_address)
15934 (maintenance_print_psymbols, maintenance_info_psymtabs)
15935 (maintenance_check_psymtabs): Use ranged for.
15936 * psymtab.h (class objfile_psymtabs): New.
15937 (require_partial_symbols): Return objfile_psymtabs.
15938 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15939
159402019-01-09 Tom Tromey <tom@tromey.com>
15941
15942 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15943 (find_pc_mapped_section, list_overlays_command)
15944 (map_overlay_command, unmap_overlay_command)
15945 (simple_overlay_update): Use all_objfiles.
15946 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15947 * printcmd.c (info_symbol_command): Use all_objfiles.
15948 * objfiles.h (ALL_OBJSECTIONS): Remove.
15949 * maint.c (maintenance_translate_address): Use all_objfiles.
15950 * gcore.c (gcore_create_callback): Use all_objfiles.
15951 (objfile_find_memory_regions): Likewise.
15952
159532019-01-09 Tom Tromey <tom@tromey.com>
15954
15955 * symtab.c (find_line_symtab, info_sources_command)
15956 (make_source_files_completion_list): Use objfile_compunits.
15957 * source.c (select_source_symtab): Use objfile_compunits.
15958 * objfiles.h (struct objfile): Update comment.
15959 (ALL_OBJFILES): Remove.
15960 (ALL_FILETABS): Remove.
15961 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15962 objfile_compunits.
15963
159642019-01-09 Tom Tromey <tom@tromey.com>
15965
15966 * symmisc.c (print_objfile_statistics, dump_objfile)
15967 (maintenance_print_symbols): Use compunit_filetabs.
15968 * source.c (forget_cached_source_info_for_objfile): Use
15969 compunit_filetabs.
15970 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15971 (ALL_FILETABS): Use compunit_filetabs.
15972 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15973 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15974
159752019-01-09 Tom Tromey <tom@tromey.com>
15976
15977 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15978 (compunit_filetabs): New.
15979 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15980 compunit_filetabs.
15981 (info_sources_command, make_source_files_completion_list): Remove
15982 declaration.
15983 * symmisc.c (print_objfile_statistics, dump_objfile)
15984 (maintenance_print_symbols): Remove declaration.
15985 (maintenance_info_symtabs): Use compunit_filetabs.
15986 (maintenance_info_line_tables): Likewise.
15987 * source.c (select_source_symtab): Change local variable name.
15988 (forget_cached_source_info_for_objfile): Remove declaration.
15989 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15990 * objfiles.c (objfile_relocate1): Remove declaration.
15991 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15992 declaration.
15993 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15994 * coffread.c (coff_symtab_read): Remove declaration.
15995 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15996 compunit_filetabs.
15997
159982019-01-09 Tom Tromey <tom@tromey.com>
15999
16000 * symtab.c (lookup_objfile_from_block)
16001 (find_pc_sect_compunit_symtab, search_symbols)
16002 (default_collect_symbol_completion_matches_break_on): Use
16003 objfile_compunits.
16004 * objfiles.h (ALL_COMPUNITS): Remove.
16005 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16006 * cp-support.c (add_symbol_overload_list_qualified): Use
16007 objfile_compunits.
16008 * ada-lang.c (ada_collect_symbol_completion_matches)
16009 (ada_add_global_exceptions): Use objfile_compunits.
16010
160112019-01-09 Tom Tromey <tom@tromey.com>
16012
16013 * source.c (select_source_symtab)
16014 (forget_cached_source_info_for_objfile): Remove declaration.
16015 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16016 declaration.
16017 * maint.c (count_symtabs_and_blocks): Remove declaration.
16018 * cp-support.c (add_symbol_overload_list_qualified): Remove
16019 declaration.
16020 * coffread.c (coff_symtab_read): Remove declaration.
16021 * symtab.c (lookup_symbol_in_objfile_symtabs)
16022 (basic_lookup_transparent_type_1): Use objfile_compunits.
16023 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16024 (info_sources_command, search_symbols)
16025 (default_collect_symbol_completion_matches_break_on)
16026 (make_source_files_completion_list): Remove declaration.
16027 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16028 (ada_collect_symbol_completion_matches)
16029 (ada_add_global_exceptions): Remove declaration.
16030 * linespec.c (iterate_over_all_matching_symtabs): Use
16031 objfile_compunits.
16032 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16033 (class objfile_compunits): New.
16034 (ALL_COMPUNITS): Use objfile_compunits.
16035 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16036 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16037 objfile_compunits.
16038 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16039
160402019-01-09 Tom Tromey <tom@tromey.com>
16041
16042 * symtab.c (search_symbols)
16043 (default_collect_symbol_completion_matches_break_on): Use
16044 objfile_msymbols.
16045 * ada-lang.c (ada_lookup_simple_minsym)
16046 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16047 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16048 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16049 objfile_msymbols.
16050 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16051 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16052 * objc-lang.c (find_methods): Use objfile_msymbols.
16053 (info_selectors_command, info_classes_command): Likewise.
16054 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16055 * objfiles.h (class objfile_msymbols): New.
16056 (ALL_OBJFILE_MSYMBOLS): Remove.
16057 (ALL_MSYMBOLS): Remove.
16058
160592019-01-09 Tom Tromey <tom@tromey.com>
16060
16061 * common/next-iterator.h (next_adapter): Add Iterator template
16062 parameter.
16063 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16064 (class all_objfiles_safe): New.
16065 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16066 * objfiles.c (put_objfile_before): Update comment.
16067 (add_separate_debug_objfile): Likewise.
16068 (free_all_objfiles): Use all_objfiles_safe.
16069 (objfile_purge_solibs): Likewise.
16070
160712019-01-09 Tom Tromey <tom@tromey.com>
16072
16073 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16074 (expand_symtab_containing_pc, lookup_static_symbol)
16075 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16076 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16077 all_objfiles.
16078 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16079 * breakpoint.c (create_overlay_event_breakpoint)
16080 (create_longjmp_master_breakpoint)
16081 (create_std_terminate_master_breakpoint)
16082 (create_exception_master_breakpoint): Use all_objfiles.
16083 * linux-thread-db.c (try_thread_db_load_from_pdir)
16084 (has_libpthread): Use all_objfiles.
16085 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16086 * linespec.c (iterate_over_all_matching_symtabs)
16087 (search_minsyms_for_name): Use all_objfiles.
16088 * maint.c (maintenance_info_sections): Use all_objfiles.
16089 * main.c (captured_main_1): Use all_objfiles.
16090 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16091 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16092 * guile/scm-pretty-print.c
16093 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16094 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16095 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16096 (maintenance_print_msymbols): Use all_objfiles.
16097 * source.c (select_source_symtab): Use all_objfiles.
16098 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16099 * symfile.c (remove_symbol_file_command)
16100 (expand_symtabs_matching, map_symbol_filenames): Use
16101 all_objfiles.
16102 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16103 all_objfiles.
16104 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16105 * objc-lang.c (find_methods): Use all_objfiles.
16106 * objfiles.c (have_partial_symbols, have_full_symbols)
16107 (have_minimal_symbols, qsort_cmp)
16108 (default_iterate_over_objfiles_in_search_order): Use
16109 all_objfiles.
16110 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16111 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16112 (maintenance_check_psymtabs): Use all_objfiles.
16113 (ALL_PSYMTABS): Remove.
16114 * compile/compile-object-run.c (do_module_cleanup): Use
16115 all_objfiles.
16116 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16117 * cp-support.c (add_symbol_overload_list_qualified): Use
16118 all_objfiles.
16119 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16120 Use all_objfiles.
16121 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16122 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16123 all_objfiles.
16124 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16125 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16126 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16127 Uses all_objfiles.
16128 * solib.c (solib_read_symbols): Use all_objfiles
16129
161302019-01-09 Tom Tromey <tom@tromey.com>
16131
16132 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16133 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16134 all_objfiles.
16135 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16136 * symmisc.c (print_symbol_bcache_statistics)
16137 (print_objfile_statistics, maintenance_print_objfiles)
16138 (maintenance_info_symtabs, maintenance_check_symtabs)
16139 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16140 all_objfiles.
16141 * source.c (forget_cached_source_info): Use all_objfiles.
16142 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16143 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16144 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16145 * objfiles.c (update_section_map): Use all_objfiles.
16146 (shared_objfile_contains_address_p): Likewise.
16147 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16148 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16149
161502019-01-09 Tom Tromey <tom@tromey.com>
16151
16152 * common/next-iterator.h: New file.
16153 * objfiles.h (class all_objfiles): New.
16154 (struct objfile_iterator): New.
16155
161562019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16157
16158 * NEWS: Move the description of the changed "frame", "select-frame",
16159 and "info frame" commands to the Changed commands section.
16160
161612019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16162
16163 * gdbtypes.c (check_stub_method_group): Remove handling of old
16164 mangling schemes.
16165 * linespec.c (find_methods): Likewise.
16166 * stabsread.c (read_member_functions): Likewise.
16167 * valops.c (search_struct_method): Likewise.
16168 (value_struct_elt_for_reference): Likewise.
16169 * NEWS: Mention this change.
16170
161712019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16172
16173 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16174 print_source_lines.
16175 * source.c (print_source_lines_base): Update line number check.
16176 (print_source_lines): New function.
16177 (source_lines_range::source_lines_range): New function.
16178 * source.h (class source_lines_range): New class.
16179 (print_source_lines): New declaration.
16180
161812019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16182
16183 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16184
161852019-01-08 Tom Tromey <tom@tromey.com>
16186 Simon Marchi <simon.marchi@ericsson.com>
16187
16188 PR gdb/24060
16189 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16190 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16191 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16192 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16193 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16194 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16195
161962019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16197
16198 * source.c (select_source_symtab): Move header comment to
16199 declaration in source.h.
16200 (forget_cached_source_info_for_objfile): Likewise.
16201 (forget_cached_source_info): Likewise.
16202 (identify_source_line): Likewise.
16203 * source.h (identify_source_line): Move declaration from symtab.h
16204 and add comment from source.c
16205 (print_source_lines): Likewise.
16206 (forget_cached_source_info_for_objfile): Likewise.
16207 (forget_cached_source_info): Likewise.
16208 (select_source_symtab): Likewise.
16209 (enum print_source_lines_flag): Move definition from symtab.h.
16210 * symtab.h (identify_source_line): Move declaration to source.h.
16211 (print_source_lines): Likewise.
16212 (forget_cached_source_info_for_objfile): Likewise.
16213 (forget_cached_source_info): Likewise.
16214 (select_source_symtab): Likewise.
16215 (enum print_source_lines_flag): Move definition to source.h.
16216 * tui/tui-hooks.c: Add 'source.h' include.
16217
162182019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16219
16220 * source.c (print_source_lines_base): Handle requests to print
16221 reverse line number sequences, and guard against empty lines
16222 string.
16223
162242019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16225
16226 * source.c (print_source_lines_base): Fix skip of '\r' if next
16227 character is '\n'.
16228
162292019-01-06 Tom Tromey <tom@tromey.com>
16230
16231 * c-exp.y (struct c_parse_state) <macro_original_text,
16232 expansion_obstack>: New member.
16233 (macro_original_text, expansion_obstack): Remove globals.
16234 (scan_macro_expansion, scanning_macro_expansion)
16235 (finished_macro_expansion): Update.
16236 (scan_macro_cleanup): Remove.
16237 (yylex, c_parse): Update.
16238
162392019-01-06 Tom Tromey <tom@tromey.com>
16240
16241 * c-exp.y (struct c_parse_state) <strings>: New member.
16242 (operator_stoken): Update.
16243
162442019-01-06 Tom Tromey <tom@tromey.com>
16245
16246 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16247 (union type_stack_elt) <typelist_val>: Now a pointer to
16248 std::vector.
16249 (type_stack_cleanup): Don't declare.
16250 (push_typelist): Update.
16251 * parse.c (pop_typelist): Return a std::vector.
16252 (push_typelist): Take a std::vector.
16253 (follow_types): Update. Do not free args.
16254 (type_stack_cleanup): Remove.
16255 * c-exp.y (struct c_parse_state): New.
16256 (cpstate): New global.
16257 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16258 (nonempty_typelist): Update.
16259 (func_mod): Create a new vector.
16260 (c_parse): Create a c_parse_state.
16261 (check_parameter_typelist): Do not delete params.
16262 (function_method): Update. Do not delete type_list.
16263
162642019-01-06 Tom Tromey <tom@tromey.com>
16265
16266 PR gdb/28155:
16267 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16268 check_typedef.
16269 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16270 (print_return_value): Likewise.
16271
162722019-01-05 Tom Tromey <tom@tromey.com>
16273
16274 * contrib/cleanup_check.py: Remove.
16275 * contrib/gcc-with-excheck: Remove.
16276 * contrib/exsummary.py: Remove.
16277 * contrib/excheck.py: Remove.
16278
162792019-01-05 Joel Brobecker <brobecker@adacore.com>
16280
16281 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16282 NULL. Initialize tpprev to NULL instead of assigning it
16283 to NULL on the next statement.
16284 * windows-nat.c (windows_delete_thread): Remove check for
16285 main_thread_id before printing thread exit notifications.
16286 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16287 Remove thread ID check against main_thread_id.
16288 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16289 windows_delete_thread.
16290 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16291
162922019-01-04 Tom Tromey <tom@tromey.com>
16293
16294 * compile/compile.c (_initialize_compile): Use upper case for
16295 metasyntactic variables.
16296 * symmisc.c (_initialize_symmisc): Use upper case for
16297 metasyntactic variables.
16298 * psymtab.c (_initialize_psymtab): Use upper case for
16299 metasyntactic variables.
16300 * demangle.c (demangle_command): Use upper case for metasyntactic
16301 variables.
16302 (_initialize_demangler): Likewise.
16303 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16304 variables.
16305
163062019-01-03 Tom Tromey <tom@tromey.com>
16307
16308 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16309
163102019-01-03 Tom Tromey <tom@tromey.com>
16311
16312 * python/py-symtab.c (salpy_str): Update.
16313 (struct salpy_sal_object) <symtab>: Now a PyObject.
16314 (salpy_dealloc): Update.
16315 (del_objfile_sal): Use gdbpy_ref.
16316
163172019-01-03 Tom Tromey <tom@tromey.com>
16318
16319 * python/py-type.c (convert_field): Use new_reference. Return
16320 gdbpy_ref.
16321 (make_fielditem): Return gdbpy_ref.
16322 (typy_fields): Update.
16323 (typy_getitem): Update.
16324 (field_name): Return gdbpy_ref. Use new_reference.
16325 (typy_iterator_iternext): Update.
16326
163272019-01-03 Tom Tromey <tom@tromey.com>
16328
16329 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16330
163312019-01-03 Tom Tromey <tom@tromey.com>
16332
16333 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16334 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16335 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16336 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16337 (pspy_set_type_printers): Likewise.
16338 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16339 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16340 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16341 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16342 (objfpy_set_type_printers): Likewise.
16343
163442019-01-03 Tom Tromey <tom@tromey.com>
16345
16346 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16347 (gdbpy_print_stack): Use gdbpy_err_fetch.
16348 * python/python-internal.h (class gdbpy_err_fetch): New class.
16349 (class gdbpy_enter) <m_error_type, m_error_value,
16350 m_error_traceback>: Remove.
16351 <m_error>: New member.
16352 (gdbpy_exception_to_string): Don't declare.
16353 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16354 * python/py-value.c (convert_value_from_python): Use
16355 gdbpy_err_fetch.
16356 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16357 gdbpy_exception_to_string.
16358 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16359 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16360 gdbpy_err_fetch.
16361
163622019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16363
16364 * linux-nat.c (delete_lwp_cleanup): Delete.
16365 (struct lwp_deleter): New struct.
16366 (lwp_info_up): New typedef.
16367 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16368 lwp_info_up.
16369
163702019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16371
16372 * linux-fork.c (class scoped_switch_fork_info): New class.
16373 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16374
163752019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16376
16377 * valops.c (find_overload_match): Remove use of null_cleanup, and
16378 calls to do_cleanups.
16379
163802019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16381
16382 * compile/compile-cplus-types.c
16383 (compile_cplus_instance::decl_name): Handle changes to
16384 cp_func_name.
16385 * cp-support.c (cp_func_name): Update header comment, update
16386 return type.
16387 * cp-support.h (cp_func_name): Update return type in declaration.
16388 * valops.c (find_overload_match): Move temp_func local to top
16389 level of function and change its type. Use temp_func to hold and
16390 delete temporary string obtained from cp_func_name.
16391
163922019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16393
16394 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16395 gdb::char_vector, remove cleanup, and update uses of `msg`.
16396
163972019-01-03 Jim Wilson <jimw@sifive.com>
16398
16399 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16400
164012019-01-02 Tom Tromey <tom@tromey.com>
16402
16403 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16404 (tdesc_parse_xml): Remove cleanups.
16405 * target-descriptions.h (make_cleanup_free_target_description):
16406 Don't declare.
16407 (target_desc_deleter): New struct.
16408 (target_desc_up): New typedef.
16409 * target-descriptions.c (target_desc_deleter::operator()): Rename
16410 from free_target_description.
16411 (make_cleanup_free_target_description): Remove.
16412
164132019-01-02 Tom Tromey <tom@tromey.com>
16414
16415 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16416 constructor, destructor.
16417 (linespec_parser): Remove typedef.
16418 (~linespec_parser): Rename from linespec_parser_delete.
16419 (linespec_lex_to_end, linespec_complete_label)
16420 (linespec_complete): Update.
16421 (decode_line_full): Remove cleanups.
16422 (decode_line_1): Update.
16423
164242019-01-02 Tom Tromey <tom@tromey.com>
16425
16426 * python/python-internal.h (inferior_to_inferior_object): Change
16427 return type.
16428 * python/py-exitedevent.c (create_exited_event_object): Update.
16429 * python/py-inferior.c (inferior_to_inferior_object): Return
16430 gdbpy_ref.
16431 (python_new_inferior, python_inferior_deleted)
16432 (thread_to_thread_object, delete_thread_object)
16433 (build_inferior_list, gdbpy_selected_inferior): Update.
16434 * python/py-infthread.c (create_thread_object): Update. Also fail
16435 if inferior_to_inferior_object fails.
16436
164372019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16438
16439 * inferior.h (class inferior) <displaced_step_state>: New field.
16440 * infrun.h (struct displaced_step_state): Move here from
16441 infrun.c. Initialize fields, add constructor.
16442 <inf>: Remove field.
16443 <reset>: New method.
16444 * infrun.c (struct displaced_step_inferior_state): Move to
16445 infrun.h.
16446 (displaced_step_inferior_states): Remove.
16447 (get_displaced_stepping_state): Adust.
16448 (displaced_step_in_progress_any_inferior): Adjust.
16449 (displaced_step_in_progress_thread): Adjust.
16450 (displaced_step_in_progress): Adjust.
16451 (add_displaced_stepping_state): Remove.
16452 (get_displaced_step_closure_by_addr): Adjust.
16453 (remove_displaced_stepping_state): Remove.
16454 (infrun_inferior_exit): Call displaced_step_state.reset.
16455 (use_displaced_stepping): Don't check for NULL.
16456 (displaced_step_prepare_throw): Call
16457 get_displaced_stepping_state.
16458 (displaced_step_fixup): Don't check for NULL.
16459 (prepare_for_detach): Don't check for NULL.
16460
164612019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16462
16463 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16464 in case of call that did not complete.
16465
164662019-01-02 Andrey Utkin <autkin@undo.io>
16467
16468 * symfile.c (find_separate_debug_file): Fix search of debug files for
16469 remote debuggee.
16470
164712019-01-02 Tom Tromey <tom@tromey.com>
16472
16473 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16474 indentation.
16475 * python/py-frame.c (frapy_older): Remove cast.
16476 (frapy_newer): Likewise.
16477 * python/py-breakpoint.c (local_setattro): Remove cast.
16478 * python/py-arch.c (archpy_name): Remove local variable.
16479 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16480
164812019-01-02 Joel Brobecker <brobecker@adacore.com>
16482
16483 * unittests/basic_string_view/element_access/char/empty.cc:
16484 Fix year range in copyright header.
16485
164862019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16487
16488 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16489 Delete.
16490 <operator==>: Update with for removed field.
16491 <hash>: Likewise.
16492 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16493 <isa_features>: ...this.
16494 <abi_features>: New field.
16495 (riscv_isa_flen): Update comment.
16496 (riscv_abi_xlen): New declaration.
16497 (riscv_abi_flen): New declaration.
16498 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16499 isa_features.
16500 (riscv_abi_xlen): New function.
16501 (riscv_isa_flen): Update to get answer from isa_features.
16502 (riscv_abi_flen): New function.
16503 (riscv_has_fp_abi): Update to get answer from abi_features.
16504 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16505 xlen and flen.
16506 (riscv_call_info) <xlen, flen>: Update comment.
16507 (riscv_call_arg_struct): Remove invalid assertions
16508 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16509 is removed.
16510 (riscv_gdbarch_init): Gather isa features and abi features
16511 separately, ensure both match on the gdbarch when reusing an old
16512 gdbarch. Relax an error check to allow 32-bit abi float to run on
16513 a target with 64-bit float hardware.
16514
165152019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16516
16517 * source.c (search_command_helper): Stop reverse search
16518 when line 1 has been searched.
16519
165202019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16521
16522 * record-full.c (record_full_base_target::close): Rewrite
16523 record_full_core_buf_list free logic.
16524
165252019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16526
16527 * break-catch-syscall.c (print_one_catch_syscall): xfree
16528 the last text.
16529
165302019-01-01 Joel Brobecker <brobecker@adacore.com>
16531
16532 * top.c (print_gdb_version): Update Copyright year in version
16533 message.
16534
165352019-01-01 Joel Brobecker <brobecker@adacore.com>
16536
16537 Update copyright year range in all GDB files.
16538
165392019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16540
16541 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16542
16543For older changes see ChangeLog-2018.
16544\f
16545Local Variables:
16546mode: change-log
16547left-margin: 8
16548fill-column: 74
16549version-control: never
16550coding: utf-8
16551End:
16552
This page took 0.081612 seconds and 4 git commands to generate.