bfd/ChangeLog

   1 2010-02-08  Nathan Sidwell  <nathan@codesourcery.com>
   2
   3         * elf32-ppc.c (ppc_elf_begin_write_processing): Allow empty
   4         apuinfo sections, only scan input sections once and reuse the
   5         buffer.
   6
   7 2010-02-08  Philipp Tomsich  <philipp.tomsich@theobroma-systems.com>
   8
   9         * archures.c (bfd_mach_ppc_titan): Define.
  10         * bfd-in2.h: Regenerate.
  11         * cpu-powerpc.c (bfd_powerpc_archs): Add titan entry.
  12
  13 2010-02-08  Alan Modra  <amodra@gmail.com>
  14
  15         * elf32-ppc.c (ppc_elf_check_relocs): Remove dead ifunc code.
  16
  17 2010-02-05  Sterling Augustine  <sterling@tensilica.com>
  18
  19         * elf.c (assign_file_positions_for_load_sections) Update lma of
  20         section if necessary.  Fixes Bugzilla 11219.
  21
  22 2010-02-05  H.J. Lu  <hongjiu.lu@intel.com>
  23
  24         * elf32-i386.c: Remove trailing white spaces.
  25         * elf64-x86-64.c: Likewise.
  26
  27 2010-02-03  Nick Clifton  <nickc@redhat.com>
  28
  29         * elf-bfd.h (emum elf_object_id): Rename to elf_target_id.  Add
  30         entries for other architectures.
  31         (struct elf_link_hash_table): Add hash_table_id field.
  32         (elf_hash_table_id): New accessor macro.
  33         * elflink.c (_bfd_elf_link_hash_table_init): Add target_id
  34         parameter.
  35         * elf-m10300.c (elf32_mn10300_hash_table): Check table id before
  36         returning cast pointer.
  37         (elf32_mn10300_link_hash_table_create): Identify new table as
  38         containing MN10300 extensions.
  39         (mn10300_elf_relax_section): Check pointer returned by
  40         elf32_mn10300_hash_table.
  41         * elf32-arm.c: Likewise, except using ARM extensions.
  42         * elf32-avr.c: Likewise, except using AVR extensions.
  43         * elf32-bfin.c: Likewise, except using BFIN extensions.
  44         * elf32-cris.c: Likewise, except using CRIS extensions.
  45         * elf32-frv.c: Likewise, except using FRV extensions.
  46         * elf32-hppa.c: Likewise, except using HPPA32 extensions.
  47         * elf32-i386.c: Likewise, except using I386 extensions.
  48         * elf32-lm32.c: Likewise, except using LM32 extensions.
  49         * elf32-m32r.c: Likewise, except using M32RM extensions.
  50         * elf32-m68hc11.c: Likewise, except using M68HC11 extensions.
  51         * elf32-m68hc1x.c: Likewise, except using M68HC11 extensions.
  52         * elf32-m68hc1x.h: Likewise, except using M68HC11 extensions.
  53         * elf32-m68k.c: Likewise, except using M68K extensions.
  54         * elf32-microblaze.c: Likewise, except using MICROBLAZE extensions.
  55         * elf32-ppc.c: Likewise, except using PPC32 extensions.
  56         * elf32-s390.c: Likewise, except using S390 extensions.
  57         * elf32-sh.c: Likewise, except using SH extensions.
  58         * elf32-spu.c: Likewise, except using SPU extensions.
  59         * elf32-xtensa.c: Likewise, except using XTENSA extensions.
  60         * elf64-alpha.c: Likewise, except using ALPHA extensions.
  61         * elf64-hppa.c: Likewise, except using HPPA64 extensions.
  62         * elf64-ppc.c: Likewise, except using PPC64 extensions.
  63         * elf64-s390.c: Likewise, except using S390 extensions.
  64         * elf64-x86-64.c: Likewise, except using X86_64 extensions.
  65         * elfxx-ia64.c: Likewise, except using IA64 extensions.
  66         * elfxx-mips.c: Likewise, except using MIPS extensions.
  67         * elfxx-sparc.c: Likewise, except using SPARC extensions.
  68         * elfxx-sparc.h: Likewise, except using SPARC extensions.
  69         * elf32-cr16.c (struct elf32_cr16_link_hash_table): Delete
  70         redundant structure.
  71         (elf32_cr16_hash_table): Delete unused macro.
  72         (elf32_cr16_link_hash_traverse): Delete unused macro.
  73         * elf32-score.c: Likewise.
  74         * elf32-score7.c: Likewise.
  75         * elf32-vax.c: Likewise.
  76         * elf64-sh64.c: Likewise.
  77
  78 2010-02-03  Alan Modra  <amodra@gmail.com>
  79
  80         * elf64-ppc.c (struct plt_entry): Move earlier in file.
  81         (struct got_entry): Likewise.  Add is_indirect and got.ent fields.
  82         (struct ppc64_elf_obj_tdata): Change tlsld_got to be a struct got_entry.
  83         Update all uses.
  84         (struct ppc_link_hash_table): Add got_reli_size and second_toc_pass.
  85         Remove no_multi_toc.
  86         (update_local_sym_info, ppc64_elf_check_relocs): Clear is_indirect
  87         when allocating a new struct got_entry.
  88         (allocate_got): New function, extracted from..
  89         (allocate_dynrelocs): ..here.  Abort on got entry in non-ppc64 bfd.
  90         (ppc64_elf_size_dynamic_sections): Track got relocs allocated in
  91         .reliplt by got_reli_size.  Set owner on ppc64_tlsld_got entries.
  92         (ppc64_elf_setup_section_lists): Remove output_bfd param and
  93         no_multi_toc, add add_stub_section and layout_sections_again.  Stash
  94         new params in htab.  Extract some code to..
  95         (ppc64_elf_start_multitoc_partition): ..here.  New function.
  96         (ppc64_elf_next_toc_section): Check for linker script errors.  Handle
  97         second pass toc scan.
  98         (merge_got_entries, merge_global_got, reallocate_got): New functions.
  99         (ppc64_elf_reinit_toc): Rename to..
 100         (ppc64_elf_finish_multitoc_partition): ..this.
 101         (ppc64_elf_layout_multitoc): New function.
 102         (ppc64_elf_size_stubs): Delete output_bfd, add_stub_section and
 103         layout_sections_again params.
 104         (ppc64_elf_relocate_section): Handle indirect got entries.
 105         * elf64-ppc.h: Update prototypes.  Declare new functions.
 106
 107 2010-02-02  H.J. Lu  <hongjiu.lu@intel.com>
 108
 109         * elf-bfd.h (elfcore_write_xstatereg): New.
 110
 111         * elf.c (elfcore_grok_xstatereg): New.
 112         (elfcore_write_xstatereg): Likewise.
 113         (elfcore_grok_note): Handle NT_X86_XSTATE.
 114         (elfcore_write_register_note): Handle .reg-xstate section.
 115
 116 2010-02-01  Tristan Gingold  <gingold@adacore.com>
 117
 118         * som.c (som_write_ar_hdr): Define this macro.
 119
 120 2010-01-30  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>
 121
 122         * elf32-hppa.c (final_link_relocate): Convert R_PARISC_TLS_GD21L,
 123         R_PARISC_TLS_LDM21L and R_PARISC_TLS_IE21L relocations that use the
 124         linkage table pointer to use the global table pointer if not doing
 125         a shared link.
 126
 127 2010-01-29  Joel Brobecker  <brobecker@adacore.com>
 128
 129         * elf.c (elfcore_grok_lwpstatus): Do not overwrite the core signal
 130         if it has already been set.
 131
 132 2010-01-27  Tristan Gingold  <gingold@adacore.com>
 133
 134         * vms.h: Remove trailing spaces.
 135         (struct hdr_struct): Remove unused hdr_c_cpr field.
 136         (enum file_format_enum): Add comments.
 137         * vms.c (vms_bfd_print_private_bfd_data): New function that
 138         replaces the macro.
 139         Remove trailing spaces.
 140         * vms-misc.c: Improve comments.
 141         (_bfd_vms_get_object_record): Also handle files without pads.
 142         * vms-hdr.c (_bfd_vms_write_dbg): Fix format string.
 143         * vms-gsd.c (struct flagdescstruct): Make name field const.
 144         (gsyflagdesc): Fix typo.
 145
 146 2010-01-27  Alan Modra  <amodra@gmail.com>
 147
 148         PR ld/11217
 149         * elf64-ppc.c (struct ppc_link_hash_table): Add toc_bfd, toc_first_sec.
 150         (ppc64_elf_setup_section_lists): Init them.
 151         (ppc64_elf_next_toc_section): Don't partition multi-toc between .got
 152         and .toc on the same input file.
 153         (ppc64_elf_relocate_section): Correct GOT entry offset.
 154
 155 2010-01-26  Tristan Gingold  <gingold@adacore.com>
 156
 157         * targets.c (BFD_JUMP_TABLE_ARCHIVE): Add initializer for write_ar_hdr.
 158         (bfd_target): Add _bfd_write_ar_hdr_fn field.
 159         * archive.c (is_bsd44_extended_name): New macro.
 160         (_bfd_generic_read_ar_hdr_mag): Use it.  Add extra_size.
 161         (bfd_slurp_armap): Also check for "__.SYMDEF" as a BSD4.4 extended
 162         name.
 163         (_bfd_archive_bsd44_construct_extended_name_table): New function.
 164         (_bfd_generic_write_ar_hdr): Ditto.
 165         (_bfd_bsd44_write_ar_hdr): Ditto.
 166         (_bfd_write_archive_contents): Call _bfd_write_ar_hdr.
 167         (bsd_write_armap): Adjust firstreal computation.
 168         * libbfd-in.h (struct areltdata): Add extra_size field.
 169         (_bfd_generic_write_ar_hdr): Add prototype.
 170         (_bfd_bsd44_write_ar_hdr): Ditto.
 171         (_bfd_write_ar_hdr): Define.
 172         (_bfd_noarchive_write_ar_hdr): Ditto.
 173         (_bfd_archive_bsd_write_ar_hdr): Ditto.
 174         (_bfd_archive_coff_write_ar_hdr): Ditto.
 175         (_bfd_archive_bsd44_slurp_armap): Ditto.
 176         (_bfd_archive_bsd44_slurp_extended_name_table): Ditto.
 177         (_bfd_archive_bsd44_construct_extended_name_table): New prototype.
 178         (_bfd_archive_bsd44_truncate_arname): Ditto.
 179         (_bfd_archive_bsd44_write_armap): Ditto.
 180         (_bfd_archive_bsd44_read_ar_hdr): Ditto.
 181         (_bfd_archive_bsd44_write_ar_hdr): Ditto.
 182         (_bfd_archive_bsd44_openr_next_archived_file): Ditto.
 183         (_bfd_archive_bsd44_get_elt_at_index): Ditto.
 184         (_bfd_archive_bsd44_generic_stat_arch_elt): Ditto.
 185         (_bfd_archive_bsd44_update_armap_timestamp): Ditto.
 186         * libbfd.h: Regenerate.
 187         * oasys.c (oasys_write_ar_hdr): Define.
 188         * libecoff.h (_bfd_ecoff_write_ar_hdr): Define.
 189         * ieee.c (ieee_write_ar_hdr): Define.
 190         * elf64-mips.c (bfd_elf64_archive_write_ar_hdr): Define.
 191         * coff-rs6000.c (rs6000coff_vec): Adjust for write_ar_hdr field.
 192         (bfd_pmac_xcoff_backend_data): Ditto.
 193         * coff64-rs6000.c (rs6000coff64_vec): Ditto.
 194         (bfd_xcoff_aix5_backend_data): Ditto.
 195         * coff-alpha.c (alpha_ecoff_write_ar_hdr): Define.
 196         * aout-target.h (MY_write_ar_hdr): Define it if not defined.
 197         * aout-tic30.c (MY_write_ar_hdr): Ditto.
 198         * mach-o-target.c (TARGET_NAME): Use _bfd_archive_bsd44 archive.
 199         (bfd_mach_o_mkarchive, bfd_mach_o_read_ar_hdr)
 200         (bfd_mach_o_slurp_armap, bfd_mach_o_slurp_extended_name_table)
 201         (bfd_mach_o_construct_extended_name_table)
 202         (bfd_mach_o_truncate_arname, bfd_mach_o_write_armap)
 203         (bfd_mach_o_get_elt_at_index, bfd_mach_o_generic_stat_arch_elt)
 204         (bfd_mach_o_update_armap_timestamp): Moved to mach-o.c
 205         * mach-o.c (bfd_mach_o_mkarchive, bfd_mach_o_read_ar_hdr)
 206         (bfd_mach_o_slurp_armap, bfd_mach_o_slurp_extended_name_table)
 207         (bfd_mach_o_construct_extended_name_table)
 208         (bfd_mach_o_truncate_arname, bfd_mach_o_write_armap)
 209         (bfd_mach_o_get_elt_at_index, bfd_mach_o_generic_stat_arch_elt)
 210         (bfd_mach_o_update_armap_timestamp): Moved from mach-o-target.c
 211         * bfd-in2.h: Regenerate.
 212
 213 2010-01-26  Alan Modra  <amodra@gmail.com>
 214             H.J. Lu  <hongjiu.lu@intel.com>
 215
 216         PR ld/11218
 217         * elflink.c (elf_link_output_extsym): Do not ignore undefined
 218         symbols with ref_regular set when gc_sections is active.
 219
 220 2010-01-25  Alan Modra  <amodra@gmail.com>
 221
 222         PR ld/11217
 223         * elf64-ppc.c (ppc64_elf_tls_optimize): Optimize tls sequences
 224         with relocations against undefined weak symbols.
 225         (ppc64_elf_relocate_section): Don't optimize calls to undefined
 226         weak functions if the symbol is dynamic.
 227         (ppc64_elf_relocate_section): Edit tprel tls sequences.
 228         * elf32-ppc.c (ppc_elf_relocate_section): Likewise.
 229         (_bfd_elf_ppc_at_tprel_transform): New function.
 230         * bfd-in.h (_bfd_elf_ppc_at_tprel_transform): Declare.
 231         * bfd-in2.h: Regenerate.
 232
 233 2010-01-23  Richard Sandiford  <r.sandiford@uk.ibm.com>
 234
 235         * coff-rs6000.c (xcoff_howto_table): Change size to 0 and bitsize to 1.
 236         (_bfd_xcoff_reloc_type_lookup): Handle BFD_RELOC_NONE.
 237         * coff64-rs6000.c (xcoff64_howto_table): Change size to 0 and
 238         bitsize to 1.
 239         (xcoff64_reloc_type_lookup): Handle BFD_RELOC_NONE.
 240
 241 2010-01-21  Nick Clifton  <nickc@redhat.com>
 242
 243         * elflink.c (elf_link_add_object_symbols): Look up name of
 244         undefined symbol both before and after versioning has been
 245         applied.  Do not bother with symbols that are weakly undefined.
 246
 247 2010-01-21  Andreas Krebbel  <Andreas.Krebbel@de.ibm.com>
 248
 249         * elf32-s390.c (elf32_s390_merge_private_bfd_data): New function.
 250         (bfd_elf32_bfd_merge_private_bfd_data): New macro definition.
 251
 252 2010-01-19  Cary Coutant  <ccoutant@google.com>
 253
 254         * dwarf2.c (read_attribute_value): Add DW_FORM_ref_sig8.
 255
 256 2010-01-19  Daisuke Hatayama  <d.hatayama@jp.fujitsu.com>
 257             Alan Modra <amodra@gmail.com>
 258
 259         * elfcode.h (elf_swap_ehdr_out): Handle e_phnum > 0xffff.
 260         (elf_object_p): Read e_phnum extension.
 261         (elf_write_shdrs_and_ehdr): Write e_phnum extension.
 262         * elfcore.h (elf_core_file_p): Read e_phnum extension.  Sanity check
 263         that we can read last program header.
 264
 265 2010-01-19  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
 266
 267         * elf32-arm.c (elf32_arm_howto_table_1): Correct bitsize of
 268         R_ARM_THM_CALL entry.
 269         (elf32_arm_final_link_relocate): Correct calculation of
 270         reloc_signed_max when doing a R_ARM_THM_CALL, R_ARM_THM_XPC22,
 271         or R_ARM_THM_JUMP24 relocation.
 272
 273 2010-01-18  Alan Modra  <amodra@gmail.com>
 274
 275         PR 11168
 276         * coffcode.h (coff_compute_section_file_positions): Move Rs6000COFF_C
 277         block past vars in COFF_IMAGE_WITH_PE block.  Report error on more
 278         than 32k sections.
 279
 280 2010-01-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
 281
 282         Fix compilation warning on gcc-3.4.
 283         * vms-tir.c (start_etir_record, sto_imm): Rename the prototype
 284         parameter index to sec_index according to the function definition.
 285
 286 2010-01-13  Chao-ying Fu  <fu@mips.com>
 287
 288         * elfxx-mips.c (JR_TO_B_P): New define to transform JR to B.
 289         It is true for all CPUs.
 290         (jal_reloc_p): New function.
 291         (mips_elf_calculate_relocation): Rename require_jalxp to
 292         cross_mode_jump_p.
 293         Update comment for CROSS_MODE_JUMP_P.
 294         Set up cross_mode_jump_p based on the mode change.
 295         (mips_elf_perform_relocation): Rename require_jalx to cross_mode_jump_p.
 296         Update comment for CROSS_MODE_JUMP_P.
 297         Test cross_mode_jump_p and jal_reloc_p to turn jal to jalx.
 298         Use !cross_mode_jump_p to guard conversion.
 299         Convert "jr t9" to "b", if possible.
 300         (_bfd_mips_elf_relocate_section): Rename require_jalx to
 301         cross_mode_jump_p.
 302         Pass &cross_mode_jump_p to call mips_elf_calculate_relocation.
 303         Pass cross_mode_jump_p to call mips_elf_perform_relocation.
 304
 305 2010-01-13  Nick Clifton  <nickc@redhat.com>
 306
 307         * cpu-m32c.c (m32c_scan): New function.  Ensures that a scan for
 308         "m32c" returns the m32c arch_info_struct and not the m16c
 309         arch_info_struct.
 310         (arch_info_struct): Use the new scan function.
 311         (bfd_m32c_arch): Likewise.
 312
 313 2010-01-13  Tristan Gingold  <gingold@adacore.com>
 314
 315         * config.bfd: Remove duplicated target vector for i386-*-darwin.
 316         Appends new arch instead of overriding.
 317         Use mach_o_x86_64_vec for x86_64-*-darwin.
 318         * configure.in: Add mach_o_x86_64_vec.
 319         * configure: Regenerate.
 320         * targets.c: Declare mach_o_x86_64_vec, add it to _bfd_target_vector.
 321         * Makefile.am (BFD64_BACKENDS): Add mach-o-x86-64.lo
 322         (BFD64_BACKENDS_CFILES): Add mach-o-x86-64.c
 323         * Makefile.in: Regenerate.
 324         * mach-o-x86-64.c: New file.
 325
 326 2010-01-13  Tristan Gingold  <gingold@adacore.com>
 327
 328         * reloc.c: Add MACH_O_X86_64 relocations.
 329         * bfd-in2.h: Regenerate.
 330         * libbfd.h: Regenerate.
 331
 332 2010-01-13  Tristan Gingold  <gingold@adacore.com>
 333
 334         * archive.c (normalize): Use lbasename.
 335         (bfd_bsd_truncate_arname): Ditto.
 336         (bfd_gnu_truncate_arname): Ditto.
 337
 338 2010-01-12  Tristan Gingold  <gingold@adacore.com>
 339
 340         * makefile.vms (CFLAGS): Turns warnings into informational messages.
 341
 342 2010-01-11  Tristan Gingold  <gingold@adacore.com>
 343
 344         * mach-o.h: Add x86-64 relocation types.
 345
 346 2010-01-11  Tristan Gingold  <gingold@adacore.com>
 347
 348         * mach-o.h (bfd_mach_o_backend_data): Add arch field.
 349         (bfd_mach_o_set_arch_mach): New prototype.
 350         * mach-o.c (bfd_mach_o_mkobject): Define with bfd_mach_o_gen_mkobject.
 351         (bfd_mach_o_set_arch_mach): New function.
 352         (bfd_mach_o_gen_mkobject): New function.
 353         Set TARGET_ARCHITECTURE for the generic back-ends.
 354         * mach-o-target.c (bfd_mach_o_set_arch_mach): Remove define.
 355         Check that TARGET_ARCHITECTURE is defined.
 356         Add TARGET_ARCHITECTURE in TARGET_NAME_BACKEND structure.
 357         * mach-o-i386.c (TARGET_ARCHITECTURE): Define.
 358
 359 2010-01-11  Tristan Gingold  <gingold@adacore.com>
 360
 361         * archive.c (bfd_slurp_armap): Also check for Mach-O sorted armap.
 362
 363 2010-01-11  Nick Clifton  <nickc@redhat.com>
 364
 365         * elf32-v850.c (v850_elf_perform_relocation): Fix overflow
 366         handling of R_V850_HI16_S relocation.
 367
 368 2010-01-11  Alan Modra  <amodra@gmail.com>
 369
 370         PR 11103
 371         * dwarf1.c (parse_die): Correct FORM_STRING data pointer increment.
 372
 373 2010-01-11  Alan Modra  <amodra@gmail.com>
 374
 375         PR 6832
 376         * dwarf2.c (struct comp_unit): Add sec_info_ptr.
 377         (find_abstract_instance_name): Use it.
 378         (parse_comp_unit): Set it.
 379
 380 2010-01-09  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
 381
 382         * Makefile.in: Regenerate.
 383         * configure: Regenerate.
 384
 385 2010-01-08  Tristan Gingold  <gingold@adacore.com>
 386
 387         * archive.c: Remove bfd_special_undocumented_glue.
 388
 389 2010-01-08  Alan Modra  <amodra@gmail.com>
 390
 391         PR ld/11133
 392         * elf32-cr16.c (elf32_cr16_gc_mark_hook): Call _bfd_elf_gc_mark_hook.
 393         * elf32-microblaze.c (microblaze_elf_gc_mark_hook): Likewise.
 394         * elf64-ppc.c (ppc64_elf_gc_mark_hook): Likewise.
 395
 396 2010-01-07  H.J. Lu  <hongjiu.lu@intel.com>
 397
 398         PR ld/11138
 399         * elflink.c (elf_link_check_versioned_symbol): Don't abort if
 400         a symbol referenced by DSO is is defined in a non-shared object
 401         and forced local.
 402
 403 2010-01-07  H.J. Lu  <hongjiu.lu@intel.com>
 404
 405         PR ld/11133
 406         * elflink.c (_bfd_elf_gc_mark_hook): Check section XXX for
 407         undefined __start_XXX/__stop_XXX in all input files and set
 408         SEC_KEEP.
 409
 410 2010-01-07  H.J. Lu  <hongjiu.lu@intel.com>
 411
 412         PR ld/11143
 413         * elflink.c (elf_gc_sweep): Keep SHT_NOTE section.
 414
 415 2010-01-04  Daniel Gutson  <dgutson@codesourcery.com>
 416
 417         * bfd.m4 (BFD_HAVE_SYS_PROCFS_TYPE): Define _STRUCTURE_PROC
 418         before including procfs.h.
 419         (BFD_HAVE_SYS_PROCFS_TYPE_MEMBER): Likewise.
 420         * configure.in: Added autoconf probe for the pr_fpreg member.
 421         * configure: Regenerated.
 422         * config.in: Regenerated.
 423         * elf.c: Define _STRUCTURE_PROC before including procfs.h.
 424
 425 2010-01-04  Joel Brobecker  <brobecker@adacore.com>
 426
 427         Fix -Wshadow warnings in dwarf2.c (seen on alpha-tru64).
 428         * dwarf2.c (concat_filename): Rename dirname with dir_name
 429         to void shadowing the dirname function.
 430         Rename subdirname with subdir_name to stay consistent with
 431         the new dir_name variable name.
 432
 433 2010-01-04  Edmar Wienskoski  <edmar@freescale.com>
 434
 435         * archures.c: Add bfd_mach_ppc_e500mc64.
 436         * bfd-in2.h: Regenerate.
 437         * cpu-powerpc.c (bfd_powerpc_archs): Add entry for
 438         bfd_mach_ppc_e500mc64.
 439
 440 2010-01-01  Joel Brobecker  <brobecker@adacore.com>
 441
 442         Fix -Wshadow warnings (seen on ppc-aix)
 443         * xcofflink.c: Replace finfo by flinfo throughout.
 444
 445 For older changes see ChangeLog-2009
 446 \f
 447 Local Variables:
 448 mode: change-log
 449 left-margin: 8
 450 fill-column: 74
 451 version-control: never
 452 End: