1 2020-11-03 Howard Chu <hyc@symas.com>
3 * ar.c (long_options): Add --record-libdeps.
4 (usage): Mention the new option.
5 (decode_options): Handle the new option.
6 (replace_members): If necessary, create a bfd to hold the libdeps
8 * binemul.c (ar_emul_append_bfd): New function.
9 (ar_emul_replace_bfd): New function.
10 (ar_emul_default_append): Replace file_name and target arguments
11 with new_bfd argument.
12 (ar_emul_default_replace): Likewise.
13 * binemul.h: Update prototypes.
14 (struct bin_emulation_xfer_struct): Update fields.
15 * doc/binutils.texi: Document the new option.
16 * NEWS: Mention the new feature.
17 * emul_aix.c (ar_emul_aix_append): Update.
18 (ar_emul_aix_replace): Likewise.
19 * testsuite/binutils-all/ar.exp: Add test of new feature.
21 2020-10-30 H.J. Lu <hongjiu.lu@intel.com>
24 * readelf.c (decode_x86_isa): Handle
25 * GNU_PROPERTY_X86_ISA_1_BASELINE.
26 * testsuite/binutils-all/i386/empty.d: Updated.
27 * testsuite/binutils-all/i386/ibt.d: Likewise.
28 * testsuite/binutils-all/i386/pr21231a.d: Likewise.
29 * testsuite/binutils-all/i386/pr21231b.d: Likewise.
30 * testsuite/binutils-all/i386/shstk.d: Likewise.
31 * testsuite/binutils-all/x86-64/empty-x32.d: Likewise.
32 * testsuite/binutils-all/x86-64/empty.d: Likewise.
33 * testsuite/binutils-all/x86-64/ibt-x32.d: Likewise.
34 * testsuite/binutils-all/x86-64/ibt.d: Likewise.
35 * testsuite/binutils-all/x86-64/pr21231a.d: Likewise.
36 * testsuite/binutils-all/x86-64/pr21231b.d: Likewise.
37 * testsuite/binutils-all/x86-64/pr23494a-x32.d: Likewise.
38 * testsuite/binutils-all/x86-64/pr23494a.d: Likewise.
39 * testsuite/binutils-all/x86-64/pr23494c-x32.d: Likewise.
40 * testsuite/binutils-all/x86-64/pr23494c.d: Likewise.
41 * testsuite/binutils-all/x86-64/pr23494d-x32.d: Likewise.
42 * testsuite/binutils-all/x86-64/pr23494d.d: Likewise.
43 * testsuite/binutils-all/x86-64/pr23494e-x32.d: Likewise.
44 * testsuite/binutils-all/x86-64/pr23494e.d: Likewise.
45 * testsuite/binutils-all/x86-64/shstk-x32.d: Likewise.
46 * testsuite/binutils-all/x86-64/shstk.d: Likewise.
48 2020-10-29 H.J. Lu <hongjiu.lu@intel.com>
51 * dwarf.c (abbrev_list): Add abbrev_base.
52 (new_abbrev_list): Add an abbrev_base argument and record it.
53 (find_abbrev_list_by_abbrev_offset): Add an abbrev_base argument
55 (process_debug_info): Pass abbrev_base to new_abbrev_list and
56 find_abbrev_list_by_abbrev_offset.
57 (display_debug_abbrev): Pass 0 abbrev_base to new_abbrev_list
58 and find_abbrev_list_by_abbrev_offset.
59 * testsuite/binutils-all/x86-64/pr26808.dump: New file.
60 * testsuite/binutils-all/x86-64/pr26808.dwp.bz2: Likewise.
61 * testsuite/binutils-all/x86-64/x86-64.exp: Run PR binutils/26808
64 2020-10-29 Nick Clifton <nickc@redhat.com>
67 * objcopy.c (is_dwo_section): Check for missing or short section
70 2020-10-26 Andreas Rammhold <andreas@rammhold.de>
72 * README-how-to-make-a-release: Use sha256sum instead of md5sum.
74 2020-10-28 Nick Clifton <nickc@redhat.com>
77 * elfedit.c (process_archive): Remove spurious call to free().
79 2020-10-27 Nick Clifton <nickc@redhat.com>
81 * dwarf.c (struct abbrev_list): New structure. Used to collect
82 lists of abbreviation sets.
83 (struct abbrev_map): New structure. Used to map CU offsets to
85 (record_abbrev_list): New function. A new entry to an
87 (free_all_abbrevs): Update to free abbreviation lists.
88 (new_abbrev_list): New function. Start a new abbreviation
90 (find_abbrev_list_by_abbrev_offset): New function.
91 (find_abbrev_map_by_offset): New function.
92 (add_abbrev): Add abbrev_list parameter.
93 (add_abbrev_attr): Likewise.
94 (process_abbrev_section): Rename to process_abbrev_set and add
96 (get_type_abbrev_from_form): New function. Attempts to decode the
97 forms used by DW_AT_type attributes.
98 (get_type_signedness): Display type names if operating in wide
99 mode. Use get_type_abbrev_from_form.
100 (read_and_display_attr_value): Use get_type_abbrev_from_form.
101 (process_debug_info): Pre-parse the CU headers to collate all the
102 abbrevs before starting the main scan.
103 (process_debug_abbrev): Do not free any loaded abbrevs.
104 (free_debug_memory): Free the abbrev maps.
106 2020-10-22 H.J. Lu <hongjiu.lu@intel.com>
108 * testsuite/binutils-all/objcopy.exp (objcopy_test): Report
109 error message on error.
111 2020-10-22 Dr. David Alan Gilbert <dgilbert@redhat.com>
113 * windmc.c (write_header_define): Fix printf format.
114 (write_header): Likewise.
116 2020-10-21 Nick Clifton <nickc@redhat.com>
118 * dwarf.c (skip_attr_bytes): Accept DWARF versions higher than 4
119 when processing the DW_FORM_ref_addr form.
120 Skip bytes in DW_FORM_block and DW_FORM_exprloc forms.
121 Handle DW_FORM_indirect.
122 (get_type_signedness): Allow a limited amount of recursion.
123 Do not attempt to decode types that use the DW_FORM_ref_addr form.
124 (read_and_display_attr_value): Do not attempt to decode types
125 that use the DW_FORM_ref_addr form.
127 2020-10-20 Alan Modra <amodra@gmail.com>
129 * readelf.c: Delete whitespace at end of line throughout.
130 (SECTION_NAME, SECTION_NAME_VALID): New.
131 (SECTION_NAME_PRINT): Rename from SECTION_NAME. Formatting.
132 (printable_section_name, dump_relocations): Use SECTION_NAME_PRINT.
133 (process_section_headers, process_section_groups): Likewise.
134 (shdr_to_ctf_sect): Likewise.
135 (find_section, find_section_in_set): Use SECTION_NAME_VALID.
136 (ia64_process_unwind, hppa_process_unwind): Likewise.
137 (display_debug_section, initialise_dumps_byname): Likewise.
138 (process_lto_symbol_tables): Likewise. Check trailing period of
139 lto symbol table names.
140 (display_lto_symtab): Use sizeof instead of strlen.
142 2020-10-20 Nelson Chu <nelson.chu@sifive.com>
144 * MAINTAINERS (RISC-V): Add myself as RISC-V co-maintainer.
146 2020-10-19 Nick Clifton <nickc@redhat.com>
148 * readelf.c (do_lto_syms): New local.
149 (long_option_values): Add OPTION_LTO_SYMS.
150 (options): Add --lto-syms.
151 (usage): Mention the new option.
152 (parse_args): Parse the new option.
153 (get_lto_kind): New function.
154 (get_lto_visibility): New function.
155 (get_lto_sym_type): New function.
156 (display_lto_symtab): New function - displays the contents of an
157 LTo symbol table section.
158 (process_lto_symbol_tables): New functions. Calls
159 dipslay_lto_symtab on any LTO symbol table section.
160 (process_object_file): Call process_lto_symbol_tables.
161 * doc/binutils.texi: Document the new option.
162 * NEWS: Mention the new feature.
164 2020-10-09 H.J. Lu <hongjiu.lu@intel.com>
167 * readelf.c (decode_x86_compat_2_isa): New function.
168 (decode_x86_isa): Updated for new X86_ISA_1_XXX bits.
169 (decode_x86_feature_1): Handle GNU_PROPERTY_X86_FEATURE_2_MASK.
170 (print_gnu_property_note): Handle X86_COMPAT_2_ISA_1_USED,
171 and X86_COMPAT_2_ISA_1_NEEDED.
172 * testsuite/binutils-all/i386/pr21231b.s: Updated to the current
173 GNU_PROPERTY_X86_ISA_1_USED and GNU_PROPERTY_X86_ISA_1_NEEDED
175 * testsuite/binutils-all/x86-64/pr21231b.s: Likewise.
176 * testsuite/binutils-all/x86-64/pr23494a.s: Likewise.
177 * testsuite/binutils-all/x86-64/pr23494b.s: Likewise.
178 * testsuite/binutils-all/x86-64/pr23494c.s: Likewise.
179 * testsuite/binutils-all/i386/empty.d: Updated.
180 * testsuite/binutils-all/i386/ibt.d: Likewise.
181 * testsuite/binutils-all/i386/pr21231a.d: Likewise.
182 * testsuite/binutils-all/i386/pr21231b.d: Likewise.
183 * testsuite/binutils-all/i386/shstk.d: Likewise.
184 * testsuite/binutils-all/x86-64/empty-x32.d: Likewise.
185 * testsuite/binutils-all/x86-64/empty.d: Likewise.
186 * testsuite/binutils-all/x86-64/ibt-x32.d: Likewise.
187 * testsuite/binutils-all/x86-64/ibt.d: Likewise.
188 * testsuite/binutils-all/x86-64/pr21231a.d: Likewise.
189 * testsuite/binutils-all/x86-64/pr21231b.d: Likewise.
190 * testsuite/binutils-all/x86-64/pr23494a-x32.d: Likewise.
191 * testsuite/binutils-all/x86-64/pr23494a.d: Likewise.
192 * testsuite/binutils-all/x86-64/pr23494c-x32.d: Likewise.
193 * testsuite/binutils-all/x86-64/pr23494c.d: Likewise.
194 * testsuite/binutils-all/x86-64/pr23494d-x32.d: Likewise.
195 * testsuite/binutils-all/x86-64/pr23494d.d: Likewise.
196 * testsuite/binutils-all/x86-64/pr23494e-x32.d: Likewise.
197 * testsuite/binutils-all/x86-64/pr23494e.d: Likewise.
198 * testsuite/binutils-all/x86-64/shstk-x32.d: Likewise.
199 * testsuite/binutils-all/x86-64/shstk.d: Likewise.
201 2020-10-06 Nick Clifton <nickc@redhat.com>
203 * objcopy.c (copy_object): Compare input and output sections by
204 pointer rather than name.
206 2020-10-05 Nick Clifton <nickc@redhat.com>
209 * windmc.c (mc_unify_path): Fix typo checking character at end of
212 2020-10-05 Samanta Navarro <ferivoz@riseup.net>
214 * doc/binutils.texi: Fix spelling mistakes.
216 2020-09-29 Mark Wielaard <mark@klomp.org>
218 * dwarf.c (display_loclists_list): Handle DW_LLE_start_end and
219 DW_LLE_start_length. Only add base_address for DW_LLE_offset_pair.
221 2020-09-25 Alan Modra <amodra@gmail.com>
223 * elfcomm.c (byte_put_little_endian, byte_put_big_endian): Support
225 * readelf.c (target_specific_reloc_handling <MSP430>): Limit
226 allowed reloc_size. Don't read_leb128 outside of section.
228 2020-09-23 Mark Wielaard <mark@klomp.org>
230 * dwarf.c (process_debug_info): Print Unit Type for DWARF5.
231 * testsuite/binutils-all/dw5.W: Adjust expected output.
232 * testsuite/binutils-all/dwarf-attributes.W: Likewise.
234 2020-09-23 Mark Wielaard <mark@klomp.org>
236 * dwarf.c (read_and_display_attr_value): Handle DW_FORM_ref_addr
237 for dwarf_version 5 just as version 3 and 4 (only 2 is
239 (process_debug_info): Allow DW_UT_partial.
241 2020-09-24 Nick Clifton <nickc@redhat.com>
244 * doc/binutils.texi (nm): Document that 'c' is used for small
247 2020-09-21 Ludovic Courtès <ludo@gnu.org>
249 * doc/binutils.texi (objcopy, strip): Say that
250 '--strip-unneeded' implies '--strip-debug'.
252 2020-09-16 Anatoly Parshintsev <kupokupokupopo@gmail.com>
254 * verilog.c (verilog_write_address): Properly handle 64-bit
255 addresses to avoid truncation of the high part.
257 2020-09-16 Alan Modra <amodra@gmail.com>
259 * nm.c (print_symbol): Adjust elf_symbol_from invocation.
260 * objcopy.c (is_hidden_symbol): Likewise.
262 2020-09-15 Nick Clifton <nickc@redhat.com>
264 * README-how-to-make-a-release (https): Add a reminder to create a
265 new Bugzilla tag for the point release, once it has been published.
267 2020-09-11 H.J. Lu <hongjiu.lu@intel.com>
269 * readelf.c (get_note_type): Support NT_X86_CET.
271 2020-09-11 Nick Clifton <nickc@redhat.com>
274 * dwarf.c (load_separate_debug_info): Return NULL rather than
275 FALSE in error situations.
276 (load_separate_debug_file): Move code to load debug links to ...
277 (check_for_and_load_links): ... here. New function. Load
278 separate debug information pointed to by debuglink and
279 debugaltlink sections. Recursively scan newly loaded debug
280 information for more links and load them too.
282 2020-09-09 Alan Modra <amodra@gmail.com>
285 * dwarf.c (parse_gnu_debugaltlink): Don't alloc build_id_data.
286 (load_separate_debug_files): Use a stack var for build_id_data.
288 2020-09-08 H.J. Lu <hongjiu.lu@intel.com>
291 * testsuite/binutils-all/objcopy.exp: Pass --disable-reloc-section
292 to ld on PE targets for PR 25662 test.
294 2020-09-08 Jozef Lawrynowicz <jozef.l@mittosystems.com>
295 Kuan-Lin Chen <kuanlinchentw@gmail.com>
297 * readelf.c (target_specific_reloc_handling): Handle
298 R_MSP430{,X}_GNU_{SET,SUB}_ULEB128.
300 2020-09-02 Alan Modra <amodra@gmail.com>
302 * objdump.c (disassemble_bytes): Use an unsigned type for "addend".
304 2020-08-30 Alan Modra <amodra@gmail.com>
306 * readelf.c (print_gnu_build_attribute_name): Use unsigned long
309 2020-08-28 Nick Clifton <nickc@redhat.com>
312 * dwarf.c (read_leb128): When checking for overflow of a signed
313 read, use a signed shift.
315 2020-08-28 Cooper Qu <cooper.qu@linux.alibaba.com>
317 * readelf.c (get_csky_section_type_name): New.
318 (get_section_type_name): Add handler for CSKY.
319 (display_csky_attribute): New.
320 (process_arch_specific): Add handler for CSKY.
321 * testsuite/binutils-all/strip-3.d: Remove .csky.attributes
324 2020-08-27 Jozef Lawrynowicz <jozef.l@mittosystems.com>
326 * readelf.c (get_msp430x_section_type_name): Rename to ...
327 (get_msp430_section_type_name): ... this.
328 (get_section_type_name): Use get_msp430_section_type_name.
329 (display_msp430x_attribute): Rename to ...
330 (display_msp430_attribute): ... this.
331 (process_arch_specific): Use display_msp430_attribute.
333 2020-08-27 John David Anglin <danglin@gcc.gnu.org>
336 * testsuite/binutils-all/objcopy.exp (objcopy --reverse-bytes): Add
337 "-j $PRIVATE$" to command on hppa*-*-hpux*.
338 * testsuite/lib/utils-lib.exp (default_binutils_run): Remove existing
339 dollar-sign quotes before quoting. Do this prior to generating log
342 2020-08-27 Ralf Habacker <ralf.habacker@freenet.de>
345 * mclex.c (skip_until_eol): If eol was found, increment line
348 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
350 * objdump.c (dump_ctf_errs): Unquote CTF error messages.
351 * readelf.c (dump_ctf_errs): Likewise.
353 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
355 * objdump.c (dump_ctf_archive_member): Move error-
357 (dump_ctf_errs): ... into this separate function.
358 (dump_ctf): Call it on open errors.
359 * readelf.c (dump_ctf_archive_member): Move error-
361 (dump_ctf_errs): ... into this separate function. Support
362 calls with NULL fp. Adjust for new err parameter to
364 (dump_section_as_ctf): Call it on open errors.
366 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
368 * Makefile.am (readelf_LDADD): Move $(LIBINTL) after $(LIBCTF_NOBFD).
369 * Makefile.in: Regenerated.
371 2020-08-26 Nick Clifton <nickc@redhat.com>
374 * readelf.c (get_segment_type): Handle OpenBSD segment types.
376 2020-08-26 Alan Modra <amodra@gmail.com>
379 * objcopy.c (copy_object): Don't fwrite NULL contents.
381 2020-08-26 Katayama Hirofumi <katayama.hirofumi.mz@gmail.com>
384 * rcparse.y (AUTOCHECKBOX): Add WS_TABSTOP to the base style.
386 2020-08-24 Alan Modra <amodra@gmail.com>
388 * readelf.c (dump_section_as_strings) Avoid false positive
389 "may be used uninitialised".
391 2020-08-22 H.J. Lu <hongjiu.lu@intel.com>
394 * nm.c (print_symname): Display only one '@' for undefined
396 * doc/binutils.texi: Update nm version information.
398 2020-08-21 Mark Wielaard <mark@klomp.org>
400 * testsuite/binutils-all/readelf.exp (readelf_wi_test): Also
401 recognize DW_LANG_C11.
403 2020-08-19 Alan Modra <amodra@gmail.com>
406 * readelf.c (dump_relocations): Use BFD_VMA_FMT to print offset
408 (dump_section_as_strings): Don't use %tx to display offset.
410 2020-08-14 Alan Modra <amodra@gmail.com>
413 * dwarf.c (free_debug_memory): Free alloc_num_debug_info_entries
414 of debug_information. Correct test of max_loc_offsets and
416 * rddbg.c (read_debugging_info): Free dhandle on error.
418 2020-08-14 Alan Modra <amodra@gmail.com>
420 * testsuite/binutils-all/mangled.s: Use dc.a rather than dc.d.
422 2020-08-13 Alan Modra <amodra@gmail.com>
425 * objcopy.c (copy_object): Report file name with endian error.
426 Error and return on abfd->read_only.
428 2020-08-12 Tom Tromey <tromey@adacore.com>
430 * dwarf-mode.el (Version): Now 1.6.
431 (dwarf-die-button-action): Tighten DIE reference regexp.
432 (dwarf-font-lock-keywords): Update name regexp.
434 2020-08-12 Nick Clifton <nickc@redhat.com>
437 * readelf.c (do_demangle): New option flag.
438 (print_symbol): If do_demangle is enabled, demangle the symbol.
439 (enum long_option_values): New enum to hold long option values.
440 (options): Add demangle, no-demangle, recursion-limit and
441 no-recursion-limit options. Alpha sort the table.
442 (usage): Describe the new options.
443 (parse_args): Handle the new options.
444 * NEWS: Mention the new feature.
445 * doc/binutils.texi: Document the new feature.
446 * testsuite/binutils-all/readelf.exp: Test the new feature.
447 * testsuite/binutils-all/mangled.s: New file - assembler source.
448 * testsuite/binutils-all/readelf.demangled: New file - expected
451 2020-08-12 Nick Clifton <nickc@redhat.com>
453 * po/sr.po: Updated Serbian translation.
455 2020-08-10 H.J. Lu <hongjiu.lu@intel.com>
458 * nm.c (with_symbol_versions): Removed.
459 (long_option_values): Add OPTION_WITH_SYMBOL_VERSIONS.
460 (long_options): Update --with-symbol-versions entry.
461 (print_symbol): Remove the with_symbol_versions check.
462 (main): Add OPTION_WITH_SYMBOL_VERSIONS for backward
464 * doc/binutils.texi: Remove --with-symbol-versions.
466 2020-08-05 Alan Modra <amodra@gmail.com>
469 * objdump.c (load_specific_debug_section): Revert last change.
471 2020-08-05 Alan Modra <amodra@gmail.com>
474 * objdump.c (load_specific_debug_section): Don't malloc space for
475 section contents, use bfd_malloc_and_get_section.
477 2020-07-30 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
479 * Makefile.am (AM_CPPFLAGS): Add LARGEFILE_CPPFLAGS.
480 * Makefile.in, doc/Makefile.in: Regenerate.
481 * configure: Regenerate.
483 2020-07-30 H.J. Lu <hongjiu.lu@intel.com>
485 * testsuite/binutils-all/i386/compressed-1a.d: Pass --gdwarf-3
487 * testsuite/binutils-all/i386/compressed-1b.d: Likewise.
488 * testsuite/binutils-all/i386/compressed-1c.d: Likewise.
489 * testsuite/binutils-all/x86-64/compressed-1a.d: Likewise.
490 * testsuite/binutils-all/x86-64/compressed-1b.d: Likewise.
491 * testsuite/binutils-all/x86-64/compressed-1c.d: Likewise.
493 2020-07-29 Maciej W. Rozycki <macro@linux-mips.org>
495 * testsuite/binutils-all/mips/global-local-symtab-sort-o32.d:
497 * testsuite/binutils-all/mips/global-local-symtab-sort-o32t.d:
499 * testsuite/binutils-all/mips/global-local-symtab-sort-n32.d:
501 * testsuite/binutils-all/mips/global-local-symtab-sort-n32t.d:
503 * testsuite/binutils-all/mips/global-local-symtab-sort-n64.d:
505 * testsuite/binutils-all/mips/global-local-symtab-sort-n64t.d:
507 * testsuite/binutils-all/mips/global-local-symtab-final-o32.d:
509 * testsuite/binutils-all/mips/global-local-symtab-final-n32.d:
511 * testsuite/binutils-all/mips/global-local-symtab-final-n64.d:
513 * testsuite/binutils-all/mips/mips.exp: Run the new tests.
515 2020-07-29 Maciej W. Rozycki <macro@linux-mips.org>
517 * testsuite/binutils-all/mips/global-local-symtab-o32.d: New
519 * testsuite/binutils-all/mips/global-local-symtab-o32t.d: New
521 * testsuite/binutils-all/mips/global-local-symtab-n32.d: New
523 * testsuite/binutils-all/mips/global-local-symtab-n32t.d: New
525 * testsuite/binutils-all/mips/global-local-symtab-n64.d: New
527 * testsuite/binutils-all/mips/mips.exp: Run the new tests.
529 2020-07-28 H.J. Lu <hongjiu.lu@intel.com>
532 * configure: Regenerated.
534 2020-07-28 H.J. Lu <hongjiu.lu@intel.com>
537 * configure: Regenerated.
539 2020-07-27 Alan Modra <amodra@gmail.com>
541 * objdump.c (dump_section): Don't return without calling
544 2020-07-27 H.J. Lu <hongjiu.lu@intel.com>
546 * doc/binutils.texi: Replace preceeded with preceded.
548 2020-07-26 Maciej W. Rozycki <macro@linux-mips.org>
550 * testsuite/binutils-all/mips/mips.exp (run_dump_test_abi)
551 (run_dump_test_o32, run_dump_test_n32, run_dump_test_n64): New
553 (has_newabi): Remove variable.
554 (has_abi, abi_asflags, abi_ldflags): New associative array
556 (irixemul): New variable.
557 Replace `run_dump_test' calls where applicable throughout with
558 `run_dump_test_o32', `run_dump_test_n32' and `run_dump_test_n64'
559 as appropriate. Use `noarch' for tests that require their own
560 architecture setting.
561 * testsuite/binutils-all/mips/mips-ase-1.d: Remove GAS flags.
562 * testsuite/binutils-all/mips/mips-ase-2.d: Likewise.
563 * testsuite/binutils-all/mips/mips-ase-3.d: Likewise.
564 * testsuite/binutils-all/mips/mips-note-2-n32.d: Likewise.
565 * testsuite/binutils-all/mips/mips-note-2-n64.d: Likewise.
566 * testsuite/binutils-all/mips/mips-note-2.d: Likewise.
567 * testsuite/binutils-all/mips/mips-note-2r-n32.d: Likewise.
568 * testsuite/binutils-all/mips/mips-note-2r-n64.d: Likewise.
569 * testsuite/binutils-all/mips/mips-note-2r.d: Likewise.
570 * testsuite/binutils-all/mips/mips-reginfo-n32.d: Likewise.
571 * testsuite/binutils-all/mips/mips-reginfo.d: Likewise.
572 * testsuite/binutils-all/mips/mips16-extend-noinsn.d: Likewise.
573 * testsuite/binutils-all/mips/mips16-pcrel.d: Likewise.
574 * testsuite/binutils-all/mips/mips16-alias.d: Remove `-32' from
576 * testsuite/binutils-all/mips/mips16-extend-insn.d: Likewise.
577 * testsuite/binutils-all/mips/mips16-noalias.d: Likewise.
578 * testsuite/binutils-all/mips/mips16-undecoded.d: Likewise.
579 * testsuite/binutils-all/mips/mips16e2-extend-insn.d: Likewise.
580 * testsuite/binutils-all/mips/mips16e2-undecoded.d: Likewise.
581 * testsuite/binutils-all/mips/mixed-micromips.d: Likewise.
582 * testsuite/binutils-all/mips/mixed-mips16.d: Likewise.
584 2020-07-24 Aaron Merey <amerey@redhat.com>
586 * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS.
587 * Makefile.in: Rebuild.
588 * configure: Rebuild.
589 * doc/Makefile.in: Rebuild.
591 2020-07-24 Nick Clifton <nickc@redhat.com>
593 * README-how-to-make-a-release: Various small updates whilst
594 creating the 2.35 release.
596 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
598 * testsuite/lib/binutils-common.exp (run_dump_test): Add 'cc'
601 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
603 * objdump.c (dump_ctf_archive_member): Remove linefeeds.
604 (dump_ctf): Likewise.
606 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
608 * objdump.c (ctf_archive_member): Print CTF errors and warnings.
609 * readelf.c (dump_ctf_archive_member): Likewise.
611 2020-07-22 Nick Clifton <nickc@redhat.com>
613 * readelf.c (parse_args): Silence potential warnings about a
614 memory resource leak when allocating space for ctf option values.
615 (dump_section_as_ctf): Fix typo checking dump_ctf_strtab_name
618 2020-07-21 Nick Clifton <nickc@redhat.com>
620 * po/sv.po: Updated Swedish translation.
622 2020-07-14 Claudiu Zissulescu <claziss@gmail.com>
624 * testsuite/binutils-all/arc/double_regs.s: New test.
625 * testsuite/binutils-all/arc/objdump.exp: Add the above test.
627 2020-07-13 Nick Clifton <nickc@redhat.com>
629 * po/fr.po: Updated French translation.
631 2020-07-13 Alan Modra <amodra@gmail.com>
633 * testsuite/lib/binutils-common.exp (is_pecoff_format): Accept
634 optional machine-os arg.
636 2020-07-11 H.J. Lu <hongjiu.lu@intel.com>
638 * readelf.c (decode_x86_feature_2): Handle
639 GNU_PROPERTY_X86_FEATURE_2_TMM.
641 2020-07-10 Tom de Vries <tdevries@suse.de>
643 * dwarf.c (display_debug_lines_decoded): Don't emit meaningless
644 information in the end_sequence row.
645 * testsuite/binutils-all/dw5.W: Update.
646 * testsuite/binutils-all/objdump.WL: Update.
648 2020-07-09 Alan Modra <amodra@gmail.com>
650 * dlltool.c: Remove powerpc PE support and comments.
651 * configure.ac: Remove powerpc PE dlltool config.
652 * configure: Regenerate.
654 2020-07-09 Nick Clifton <nickc@redhat.com>
656 * rclex.c: Add OWNERDRAW keyword.
657 * rcparse.y: Add OWNERDRAW token.
658 (menuitem_flag) Add BITMAP and OWNERDRAW entries.
659 * resrc.c (write_rc_menuitems): Add support for OWNERDRAW and
661 * windres.c (extended_menuitems): Likewise.
662 * testsuite/binutils-all/windres/menuitem_flags.rc: New test.
664 2020-07-09 Alan Modra <amodra@gmail.com>
666 * readelf (slurp_hppa_unwind_table): Set table_len before use
667 in relocation sanity checks.
669 2020-07-07 Alan Modra <amodra@gmail.com>
671 * testsuite/binutils-all/ar.exp: Use is_xcoff_format.
672 * testsuite/binutils-all/nm.exp: Likewise.
673 * testsuite/binutils-all/copy-2.d: Run only for elf and pe targets.
674 * testsuite/binutils-all/copy-3.d: Run only for elf targets.
675 * testsuite/binutils-all/set-section-alignment.d: Likewise.
676 * testsuite/binutils-all/copy-4.d: Don't run for xcoff.
678 2020-07-07 Alan Modra <amodra@gmail.com>
680 * testsuite/lib/binutils-common.exp (is_xcoff_format): New.
681 * testsuite/binutils-all/objcopy.exp (pr25662): Exclude xcoff.
683 2020-07-06 Nick Clifton <nickc@redhat.com>
685 * po/bg.po: Updated Bulgarian translation.
686 * po/pt.po: Updated Portuguese translation.
687 * po/uk.po: Updated Ukranian translation.
689 2020-07-06 Alan Modra <amodra@gmail.com>
691 * readelf.c (print_dynamic_symbol): Don't sprintf to buffer to
694 2020-07-04 Nick Clifton <nickc@redhat.com>
696 * configure: Regenerate.
697 * po/binutils.pot: Regenerate.
699 2020-07-04 Nick Clifton <nickc@redhat.com>
701 Binutils 2.35 branch created.
703 2020-07-02 Nick Clifton <nickc@redhat.com>
706 * readelf.c (print_symbol): Handle truncation of symbol names.
707 (options): Add -T/--silent-truncation option.
708 (parse_args): Handle the option.
709 (print_dynamic_symbol): Correct calculation of width available to
711 * doc/binutils.texi: Document the -T option to readelf.
712 * NEWS: Mention the new feature.
714 2020-06-30 H.J. Lu <hongjiu.lu@intel.com>
716 * NEWS: Mention x86 NaCl target support removal.
717 * dwarf.c (init_dwarf_regnames_by_bfd_arch_and_mach): Remove
718 x86 NaCl target support.
719 * testsuite/binutils-all/elfedit-1.d: Likewise.
720 * testsuite/binutils-all/i386/i386.exp: Likewise.
721 * testsuite/binutils-all/x86-64/objects.exp: Likewise.
722 * testsuite/binutils-all/x86-64/pr23494a-x32.d: Likewise.
723 * testsuite/binutils-all/x86-64/pr23494a.d: Likewise.
724 * testsuite/binutils-all/x86-64/pr23494b-x32.d: Likewise.
725 * testsuite/binutils-all/x86-64/pr23494b.d: Likewise.
726 * testsuite/binutils-all/x86-64/pr23494c-x32.d: Likewise.
727 * testsuite/binutils-all/x86-64/pr23494c.d: Likewise.
728 * testsuite/binutils-all/x86-64/pr23494d-x32.d: Likewise.
729 * testsuite/binutils-all/x86-64/pr23494d.d: Likewise.
730 * testsuite/binutils-all/x86-64/pr23494e-x32.d: Likewise.
731 * testsuite/binutils-all/x86-64/pr23494e.d: Likewise.
732 * testsuite/binutils-all/x86-64/x86-64.exp: Likewise.
734 2020-06-30 Nick Clifton <nickc@redhat.com>
736 * dwarf.c (read_and_display_attr_value): Support
737 DW_FORM_GNU_strp_alt when used with DW_AT_dwo_name and
740 2020-06-30 Alan Modra <amodra@gmail.com>
742 * testsuite/binutils-all/readelf.exp (readelf_dump_test): Remove
745 2020-06-29 Hans-Peter Nilsson <hp@bitrange.com>
747 * dwarf.c (display_debug_str_offsets): Rename local variable
748 index to idx. Move to top of function.
750 2020-06-29 Alan Modra <amodra@gmail.com>
752 * dwarf.c: Use C style comments.
755 2020-06-27 Alan Modra <amodra@gmail.com>
757 * elfcomm.c (setup_nested_archive): Set nested_arch->file to NULL
759 (release_archive): Set fields of arch to NULL after freeing.
761 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
763 * readelf.c (dump_section_as_ctf): Support .ctf archives using
764 ctf_arc_bufopen. Automatically load the .ctf member of such
765 archives as the parent of all other members, unless specifically
766 overridden via --ctf-parent. Split out dumping code into...
767 (dump_ctf_archive_member): ... here, as in objdump, and call
768 it once per archive member.
769 (dump_ctf_indent_lines): Code style fix.
771 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
773 * configure.ac [--enable-libctf]: New, default yes.
774 Set ENABLE_LIBCTF accordingly.
775 * Makefile.am [!ENABLE_LIBCTF]: Empty LIBCTF and LIBCTF_NOBFD.
776 * configure: Regenerate.
777 * config.in: Regenerate.
778 * Makefile.in: Regenerate.
779 * aclocal.m4: Regenerate.
780 * objdump.c (usage): Conditionalize portions on ENABLE_LIBCTF.
781 (option_values): Likewise.
782 (long_options): Likewise.
784 (dump_ctf_indent_lines): Conditionalize out when !ENABLE_LIBCTF.
785 (make_ctfsect): Likewise.
786 (dump_ctf_archive_member): Likewise.
787 (dump_ctf) [ENABLE_LIBCTF]: Likewise.
788 (dump_ctf) [!ENABLE_LIBCTF]: New empty stub.
789 * readelf.c (options): Conditionalize portions on ENABLE_LIBCTF.
791 (process_section_contents): Likewise.
792 (shdr_to_ctf_sect): Conditionalize out when !ENABLE_LIBCTF.
793 (dump_ctf_indent_lines): Likewise.
794 (dump_section_as_ctf) [ENABLE_LIBCTF]: Likewise.
796 2020-06-26 Jan Beulich <jbeulich@suse.com>
798 * doc/binutils.texi: Adjust description of x86's -Msuffix. Drop
799 redundant text from x86 specific part of -M section.
801 2020-06-26 Pat Bernardi <bernardi@adacore.com>
803 * readelf.c (display_m68k_gnu_attribute): New function.
804 (process_arch_specific): Call display_m68k_gnu_attribute for EM_68K.
806 2020-06-23 H.J. Lu <hongjiu.lu@intel.com>
809 * testsuite/binutils-all/pr26160.dwp.bz2: New file.
810 * testsuite/binutils-all/pr26160.r: Likewise.
811 * testsuite/binutils-all/readelf.exp: Run PR binutils/26160 test.
813 2020-06-23 Nick Clifton <nickc@redhat.com>
816 * dwarf.c (fetch_indexed_string): Detect and handle old style
817 .debug_str_offset tables.
818 (display_debug_str_offsets): Likewise. Also add support for
819 .debug_str_offsets.dwo sections.
821 2020-06-23 H.J. Lu <hongjiu.lu@intel.com>
824 * testsuite/binutils-all/pr26112.o.bz2: New file.
825 * testsuite/binutils-all/pr26112.r: Likewise.
826 * testsuite/binutils-all/readelf.exp: Run PR binutils/26112 test.
828 2020-06-23 Alan Modra <amodra@gmail.com>
830 * testsuite/binutils-all/objdump.exp (bintest.a): Correct
831 remote_file delete command.
833 2020-06-22 Nick Clifton <nickc@redhat.com>
836 * dwarf.c (display_debug_str_offsets): Add code to display the
837 contents of the .debug_str_offsets section.
838 (display_debug_macro): Add support for DW_MACRO_define_strx and
841 2020-06-22 Saagar Jha <saagar@saagarjha.com>
843 * od-macho.c: Dump linkedit data for new load commands.
845 2020-06-19 Alan Modra <amodra@gmail.com>
847 * testsuite/config/default.exp (ld_elf_shared_opt): Don't set.
848 * testsuite/lib/binutils-common.exp (check_relro_support): New proc.
849 (run_dump_test): Use check_relro_support to decide whether to pass
850 extra ld option "-z norelro".
852 2020-06-11 Alan Modra <amodra@gmail.com>
854 * readelf.c (process_mips_specific): Don't alloc memory for
855 Elf_Internal_Options.
857 2020-06-11 Alan Modra <amodra@gmail.com>
859 * readelf.c (process_mips_specific): Assert size of internal
860 types match size of external types, and simplify allocation of
861 internal buffer. Catch possible integer overflow when sanity
862 checking option size. Don't assume options are a regular array.
863 Sanity check reginfo option against option size. Use PRI macros
866 2020-06-10 Ralf Habacker <ralf.habacker@freenet.de>
869 * mclex.c (yylex): Reject lines that reach end-of-file without a
870 terminating newline character.
872 2020-06-08 Nick Clifton <nickc@redhat.com>
875 * doc/binutils.texi (strings): Fix typo.
877 2020-06-08 Nick Clifton <nickc@redhat.com>
880 * dwarf.c (process_debug_info): Check that there is space in the
881 debug_information array before filling in an entry.
883 2020-06-06 Alan Modra <amodra@gmail.com>
885 * doc/binutils.texi (PowerPC -M option): Mention power10 and pwr10.
887 2020-06-05 Joel Anderson <joelanderson333@gmail.com>
890 * mclex.c (yylex): Add test for an empty input stream.
892 2020-06-04 Stephen Casner <casner@acm.org>
894 * testsuite/binutils-all/pr25662-pdp11.s: Alternate source file
895 for test using section pseudo-ops compatible with pdp11.
896 * testsuite/binutils-all/objcopy.exp: Select alternate source.
898 2020-06-04 Jose E. Marchesi <jose.marchesi@oracle.com>
900 * objdump.c (disassemble_data): Set disasm_info.endian_code to
901 disasm_info.endian after the latter is initialized to the
902 endianness reported by BFD.
904 2020-06-04 Alan Modra <amodra@gmail.com>
906 * testsuite/binutils-all/i386/i386.exp: Remove global directive
908 * testsuite/binutils-all/x86-64/objects.exp: Likewise.
909 * testsuite/binutils-all/x86-64/x86-64.exp: Likewise.
911 2020-06-03 Joel Anderson <joelanderson333@gmail.com>
913 * windmc.h (struct mc_node): Add id_typecast field.
914 * mcparse.y (message): Initialise the id_typecast field.
915 * windmc.c (write_dbg): Use the id_typecast field as a parameter
916 when calling write_dbg_define.
917 (write_header): Likewise.
919 2020-06-03 Alan Modra <amodra@gmail.com>
922 * objcopy.c (copy_relocations_in_section): Free relpp on error.
923 Don't accidentally free isection->orelocation.
925 2020-06-02 Alan Modra <amodra@gmail.com>
927 * testsuite/binutils-all/ar.exp (obj): Set up object file name
928 extension. Use throughout. Don't completely exclude non-ELF
929 alpha targets. Run long_filenames test for tic30. Exclude thin
930 archive tests for aix, ecoff and vms.
931 * estsuite/binutils-all/objdump.exp (obj): Set up object file name
932 extension. Use throughout. Don't exclude non-ELF alpha targets
935 2020-05-28 Max Filippov <jcmvbkbc@gmail.com>
937 * MAINTAINERS (Xtensa): Add myself as maintainer.
939 2020-05-23 Alan Modra <amodra@gmail.com>
941 * testsuite/binutils-all/ar.exp (many_files): New test.
943 2020-05-21 Alan Modra <amodra@gmail.com>
945 * addr2line.c: Replace "if (x) free (x)" with "free (x)" throughout.
946 * dlltool.c: Likewise.
947 * elfcomm.c: Likewise.
949 * readelf.c: Likewise.
951 * windmc.c: Likewise.
952 * windres.c: Likewise.
953 * wrstabs.c: Likewise.
955 2020-05-21 Alan Modra <amodra@gmail.com>
957 * readelf.c (get_num_dynamic_syms): Bounds check mipsxlat array
960 2020-05-20 Nelson Chu <nelson.chu@sifive.com>
962 * dwarf.c: Updated since DECLARE_CSR is changed.
964 2020-05-19 H.J. Lu <hjl.tools@gmail.com>
967 * readelf.c (process_program_headers): Warn if the PT_DYNAMIC
968 segment doesn't match the .dynamic section and checks are
970 (struct filedata): Add dynamic_symtab_section and
971 dynamic_strtab_section fields.
972 (process_section_headers): Set dynamic_symtab_section to the
973 .dynsym section. Set dynamic_strtab_section to the .dynstr
975 (process_dynamic_section): Warn if the .dynsym section doesn't
976 match DT_SYMTAB and DT_SYMENT or the .dynstr section doesn't
977 DT_STRTAB and DT_STRSZ. But only if checks are enabled.
979 2020-05-19 Alan Modra <amodra@gmail.com>
981 * ar.c (map_over_members, get_pos_bfd, delete_members, move_members),
982 (replace_members): Use bfd_get_filename rather than accessing
983 bfd->filename directly.
984 * arsup.c (map_over_list, ar_delete, ar_replace, ar_extract): Likewise.
985 * binemul.c (do_ar_emul_append): Likewise.
986 * coffgrok.c (coff_grok): Likewise.
988 2020-05-18 Stafford Horne <shorne@gmail.com>
990 * MAINTAINERS (OR1K): Add myself as maintainer.
992 2020-05-07 Andrew Burgess <andrew.burgess@embecosm.com>
994 * doc/binutils.texi: Mention 'entry address' in the set-start and
995 adjust-start options descriptions.
997 2020-05-05 Nick Clifton <nickc@redhat.com>
999 * dwarf.c (do_checks): New global variable.
1000 (display_formatted_table): Warn about an unexpected number of
1001 columns in the table, if checks are enabled. Do not complain
1002 about the lack of data following the number of entries in the
1003 table if the table is empty.
1004 (display_debug_lines_decoded): Only warn about an unexpected
1005 number of columns in a table if checks are enabled.
1006 * dwarf.h (do_checks): Add a prototype.
1007 * elfcomm.c (error): Remove weak attribute.
1009 * readelf.c (do_checks): Delete.
1011 (process_section_headers): Only warn about empty sections if
1014 2020-05-04 Fangrui Song <maskray@google.com>
1016 * objcopy.c (copy_object): Allow empty section.
1017 * testsuite/binutils-all/update-section.exp: Add test.
1019 2020-05-04 Nick Clifton <nickc@redhat.com>
1022 * dwarf.c (display_debug_lines_decoded): Warn if encountering a
1023 supicious number of entries for DWARF-5 format directory and file
1024 name tables. Do not display file name table header if the table
1025 is empty. Do not allocate space for empty tables.
1027 2020-05-04 Alan Modra <amodra@gmail.com>
1029 * readelf.c (process_nds32_specific): Check size of .nds32_e_flags
1030 section. Don't assume endian of host matches nds32 target. Free
1033 2020-05-01 Alan Modra <amodra@gmail.com>
1034 Haim Shimonovich <Haim.Shimonovich@ceva-dsp.com>
1036 * objdump.c (disassemble_bytes): Don't scan for zeros when
1037 disassembling zeros. Translate "resuming at file offset" message.
1038 Formatting. Replace some signed variables with unsigned.
1040 2020-04-30 Alex Coplan <alex.coplan@arm.com>
1042 * testsuite/binutils-all/aarch64/in-order-all.d: Update to use new
1044 * testsuite/binutils-all/aarch64/out-of-order-all.d: Likewise.
1046 2020-04-30 Nick Clifton <nickc@redhat.com>
1048 * testsuite/lib/binutils-common.exp (check_pie_support): New
1051 2020-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
1053 * dwarf.c (display_debug_ranges): Ignore duplicate entries in
1054 range_entries for the same offset.
1056 2020-04-29 Nick Clifton <nickc@redhat.com>
1058 * readelf.c (warn): New function - like elfcomm.c version but only
1059 produces output if warnings are enabled.
1060 (struct options): Add --lint and --enable-checks.
1061 (usage): Add entry for --lint.
1062 (parse_args): Handle -L. If checks are enabled but no dumps have
1063 been selected then enable all dumps.
1064 (process_section_headers): Replace long if-then-else sequence with
1065 a switch. Add warning messages for empty SHT_REL, SHT_RELA and
1066 SHT_PROGBITS sections.
1067 (process_file): Do not complain if the file is an archive and lint
1068 mode has been enabled.
1069 * elfcomm.c (error): Make the function weak.
1071 * NEWS: Mention the new feature.
1072 * doc/binutils.texi: Document the new feature.
1073 * dwarf.h (report_leb_status): Add file name and line number
1074 parameters. Include them in the diagnostic output.
1075 (READ_ULEB): Pass file and line number to report_leb_status.
1076 (READ_SLEB): Likewise.
1077 * dwarf.c (read_and_print_leb128): Pass file and line number to
1079 * testsuite/binutils-all/readelf.exp: Add test of new feature.
1080 * testsuite/binutils-all/zero-sec.s: New test source file.
1081 * testsuite/binutils-all/zero-sec.r: Expected output from new
1084 2020-04-29 Nick Clifton <nickc@redhat.com>
1086 * po/sr.po: Updated Serbian translation.
1088 2020-04-26 Alan Modra <amodra@gmail.com>
1090 * readelf.c (get_num_dynamic_syms): Check DT_MIPS_XHASH was
1091 read before dereferencing, and gracefully return. Remove
1092 gnu_hash_error variable. Free gnu hash arrays if number of
1095 2020-04-24 Alan Modra <amodra@gmail.com>
1097 * readelf.c (get_num_dynamic_syms): Check for nbuckets and nchains
1099 (process_dynamic_section): Call get_num_dynamic_syms once rather
1100 than in segment loop. Break out of segment loop on a successful
1101 load of dynamic symbols. Formatting.
1102 (process_object): Return error status from process_dynamic_section.
1104 2020-04-23 Anton Kolesov <anton.kolesov@synopsys.com>
1106 * elf-bfd.h (elfcore_write_arc_v2): Add prototype.
1107 * elf.c (elfcore_grok_arc_v2): New function.
1108 (elfcore_grok_note): Call the new function to handle the corresponding
1110 (elfcore_write_arc_v2): New function.
1111 (elfcore_write_register_note): Call the new function to handle the
1112 corresponding pseudo-sections.
1114 2020-04-22 Max Filippov <jcmvbkbc@gmail.com>
1117 * readelf.c (is_none_reloc): Recognize
1118 BFD_RELOC_XTENSA_PDIFF{8,16,32} and
1119 BFD_RELOC_XTENSA_NDIFF{8,16,32}.
1121 2020-04-22 Nick Clifton <nickc@redhat.com>
1123 * MAINTAINERS: Remove Chris Faylor as the ix86 PE maintainer.
1125 2020-04-22 Alan Modra <amodra@gmail.com>
1127 * readelf.c (archive_file_offset, archive_file_size, dynamic_addr),
1128 (dynamic_size, dynamic_nent, dynamic_strings, dynamic_strings_length),
1129 (num_dynamic_syms, nbuckets, nchains, buckets, chains),
1130 (ngnubuckets, gnubuckets, gnuchains, mipsxlat, ngnuchains),
1131 (gnusymidx, dynamic_symbols, dynamic_syminfo, dynamic_syminfo_offset),
1132 (dynamic_syminfo_nent, program_interpreter, dynamic_info),
1133 (dynamic_info_DT_GNU_HASH, dynamic_info_DT_MIPS_XHASH, version_info),
1134 (dynamic_section, symtab_shndx_list, group_count, section_groups),
1135 (section_headers_groups): Move to struct filedata. Update use
1138 2020-04-22 Alan Modra <amodra@gmail.com>
1140 * readelf.c (struct dump_data): New, used..
1141 (cmdline): ..here, and..
1142 (struct filedata): ..here. Adjust all uses.
1143 (request_dump_bynumber, request_dump, parse_args): Pass in a
1144 struct dump_data* rather than Filedata*. Adjust callers.
1145 (main): Don't set cmdline.file_name.
1147 2020-04-20 Alan Modra <amodra@gmail.com>
1149 * readelf.c (process_symbol_table): Clear ngnuchains, ngnubuckets
1152 2020-04-20 Alan Modra <amodra@gmail.com>
1154 * readelf.c (process_section_headers): Free dynamic symbols etc.
1157 2020-04-20 Alan Modra <amodra@gmail.com>
1159 * readelf.c (get_num_dynamic_syms): Formatting. Don't return
1160 on error without freeing.
1161 (process_dynamic_section): Don't recreate dynamic symbols from
1162 dynamic tag info when the dynamic symbols have already been
1163 read via section headers.
1165 2020-04-17 Fredrik Strupe <fredrik@strupe.net>
1167 * testsuite/binutils-all/arm/vdup-cond.d: New test for testing that
1168 conditional VDUP instructions are disassembled correctly.
1169 * testsuite/binutils-all/arm/vdup-cond.s: New file used by
1171 * testsuite/binutils-all/arm/vdup-thumb.d: New test for testing
1172 that VDUP instructions (which are conditional in A32) can be
1173 disassembled in thumb mode.
1174 * testsuite/binutils-all/arm/vdup-cond.s: New file used by
1177 2020-04-17 Alan Modra <amodra@gmail.com>
1180 * debug.c (debug_class_type_samep): Don't segfault on NULL type.
1182 2020-04-16 Alan Modra <amodra@gmail.com>
1184 * doc/binutils.texi: Mention --no-show-raw-insn in objdump
1185 --no-addresses description.
1187 2020-04-15 Alan Modra <amodra@gmail.com>
1189 * objdump.c (no_addresses): New static var.
1190 (usage): Print help for --no-addresses.
1191 (long_options): Add --no-addresses entry.
1192 (objdump_print_addr_with_sym, objdump_print_addr): Omit symbol address.
1193 (disassemble_bytes): Don't print current line address, or reloc
1195 * doc/binutils.texi: Document objdump --no-addresses.
1197 2020-04-15 Alan Modra <amodra@gmail.com>
1200 * readelf.c (get_num_dynamic_syms): Don't set num_of_syms when
1201 reading buckets or chains fails.
1203 2020-04-15 Alan Modra <amodra@gmail.com>
1205 * readelf.c (process_symbol_table): Zero gnubuckets, gnuchains
1208 2020-04-15 Alan Modra <amodra@gmail.com>
1210 * readelf.c (get_group_flags): Translate text.
1211 (get_file_type, get_symbol_binding, get_symbol_type),
1212 (get_ppc64_symbol_other, get_symbol_other): Increase size of buffer.
1214 2020-04-15 Alan Modra <amodra@gmail.com>
1217 * readelf.c (get_num_dynamic_syms): Typo fix.
1219 2020-04-14 Alan Modra <amodra@gmail.com>
1221 * readelf.c (process_mips_specific): Free eopt and iopt. Avoid
1222 possibility of overflow when checking number of conflicts.
1224 2020-04-14 H.J. Lu <hongjiu.lu@intel.com>
1227 * readelf.c (nbuckets): New.
1228 (nchains): Likewise.
1229 (buckets): Likewise.
1231 (ngnubuckets): Likewise.
1232 (gnubuckets): Likewise.
1233 (gnuchains): Likewise.
1234 (mipsxlat): Likewise.
1235 (ngnuchains): Likewise.
1236 (gnusymidx): Likewise.
1237 (VALID_SYMBOL_NAME): Likewise.
1238 (VALID_DYNAMIC_NAME): Use it.
1239 (get_dynamic_data): Moved before process_dynamic_section.
1240 (get_num_dynamic_syms): New function.
1241 (process_dynamic_section): Use DT_SYMTAB, DT_SYMENT, DT_HASH,
1242 DT_GNU_HASH and DT_MIPS_XHASH to reconstruct dynamic symbol
1243 table. Use DT_STRTAB and DT_STRSZ to reconstruct dynamic string
1245 (get_symbol_index_type): Don't print "bad section index" when
1246 there is no section header.
1247 (print_dynamic_symbol): Rewrite.
1248 (process_symbol_table): Call print_dynamic_symbol to dump dynamic
1251 2020-04-02 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1253 * testsuite/lib/binutils-common.exp (supports_gnu_osabi): Don't
1254 enable on *-*-solaris*.
1256 2020-03-30 Nick Clifton <nickc@redhat.com>
1259 * objcopy.c (copy_object): When copying PE format files set the
1260 timestamp field in the pe_data structure if the preserve_dates
1262 * testsuite/binutils-all/objcopy.exp (objcopy_test) Use
1263 --preserve-dates in place of the -p option, in order to make its
1264 effect more obvious.
1266 2020-03-28 Alan Modra <amodra@gmail.com>
1268 * testsuite/binutils-all/objcopy.exp (objcopy_test): Only
1269 clear_xfail hppa*-*-*elf*. Revert mips xfails.
1271 2020-03-28 Alan Modra <amodra@gmail.com>
1273 * testsuite/binutils-all/objcopy.exp (objcopy_test): Move xfails
1274 from here to calls. Remove "m8*-*-*" entry. Don't xfail tic54x
1275 but do xfail spu, mipstx39 and mips-sgi-irix for the executable
1276 test. Pass "-p" to objcopy for the executable test.
1278 2020-03-27 Jozef Lawrynowicz <jozef.l@mittosystems.com>
1281 * testsuite/binutils-all/objcopy.exp (objcopy_test): Add argument to
1282 specify whether an object file or executable should be built and tested.
1283 Change test names to report whether an object file or executable is
1285 * testsuite/binutils-all/pr25662.ld: New test.
1286 * testsuite/binutils-all/pr25662.s: New test.
1288 2020-03-27 Alan Modra <amodra@gmail.com>
1290 * readelf.c (process_archive): Don't double free qualified_name.
1291 Don't break out of loop with "negative" archive_file_size, just
1292 set file offset to max.
1294 2020-03-25 Alan Modra <amodra@gmail.com>
1296 * readelf.c (process_archive): Prevent endless loop.
1298 2020-03-24 H.J. Lu <hongjiu.lu@intel.com>
1301 * nm.c (print_symname): Replace _bfd_elf_get_symbol_version_name
1302 with bfd_get_symbol_version_string.
1303 (print_symbo): Pass TRUE to bfd_get_symbol_version_string.
1304 * objdump.c (objdump_print_symname): Likewise.
1306 2020-03-24 H.J. Lu <hongjiu.lu@intel.com>
1309 * nm.c (SYM_NAME): Removed.
1310 (print_symname): Add a pointer to struct extended_symbol_info
1311 argument. Call _bfd_elf_get_symbol_version_name to get symbol
1313 (print_symdef_entry): Pass NULL to print_symname.
1314 (print_symbol_info_bsd): Update call to print_symname.
1315 (print_symbol_info_sysv): Likewise.
1316 (print_symbol_info_posix): Likewise.
1318 2020-03-24 Alan Modra <amodra@gmail.com>
1320 * readelf.c (process_mips_specific): Free iconf on error path.
1322 2020-03-23 Nick Clifton <nickc@redhat.com>
1325 * wrstabs.c (stab_pop_type): Replace assertion with error return.
1326 * write_stabs_in_sections_debugging_info: Likewise.
1327 * stab_enum_type: Likewise.
1328 * stab_modify_type: Likewise.
1329 * stab_struct_field: Likewise.
1330 * stab_end_struct_type: Likewise.
1331 * stab_start_class_type: Likewise.
1332 * stab_class_static_member: Likewise.
1333 * stab_class_baseclass: Likewise.
1334 * stab_class_start_method: Likewise.
1335 * stab_class_method_var: Likewise.
1336 * stab_class_end_method: Likewise.
1337 * stab_end_class_type: Likewise.
1338 * stab_typedef_type: Likewise.
1339 * stab_start_function: Likewise.
1340 * stab_end_block: Likewise.
1341 * stab_lineno: Likewise.
1343 2020-03-20 Nick Clifton <nickc@redhat.com>
1345 * readelf.c (get_compression_header): Add ATTRIBUTE_WARN_UNUSED_RESULT.
1346 (process_section_headers): Check the return value from
1347 get_compression_header.
1348 (dump_section_as_strings): Likewise.
1349 (dump_section_as_bytes): Likewise.
1350 (load_specific_debug_section): Likewise.
1352 2020-03-20 H.J. Lu <hongjiu.lu@intel.com>
1354 * ar.c (main): Update bfd_plugin_set_program_name call.
1355 * nm.c (main): Likewise.
1357 2020-03-19 Nick Clifton <nickc@redhat.com>
1360 * testsuite/binutils-all/dw4.s: New test source file.
1361 * testsuite/binutils-all/nm.exp: Run the new test.
1363 2020-03-19 H.J. Lu <hongjiu.lu@intel.com>
1365 * readelf.c (process_symbol_table): Use unsigned long for si.
1367 2020-03-19 Alan Modra <amodra@gmail.com>
1369 * elfcomm.c: Don't include bfd.h or bucomm.h.
1370 (program_name): Declare.
1371 (process_archive_index_and_symbols): Replace bfd_boolean with int,
1372 and substitute FALSE and TRUE.
1373 (setup_archive, setup_nested_archive): Likewise.
1374 * elfcomm.h: Likewise.
1376 2020-03-19 Alan Modra <amodra@gmail.com>
1378 * readelf.c (process_archive): Always return via path freeing
1381 2020-03-19 Alan Modra <amodra@gmail.com>
1383 * readelf.c (process_netbsd_elf_note): Validate descsz before
1384 accessing descdata. Formatting.
1386 2020-03-19 Alan Modra <amodra@gmail.com>
1388 * elfcomm.c (setup_archive): Make file_size an off_t. Comment.
1389 * elfcomm.h (setup_archive): Update prototype.
1391 2020-03-16 Alan Modra <amodra@gmail.com>
1393 * readelf.c (get_symbols): New function.
1394 (process_relocs, ia64_process_unwind, hppa_process_unwind),
1395 (arm_process_unwind, get_symbol_for_build_attribute): Use it.
1397 2020-03-16 Alan Modra <amodra@gmail.com>
1399 * unwind-ia64.c (unw_decode_uleb128): Prevent overlarge shifts.
1400 Detect shift overflows and check that terminating byte is found.
1401 Print an error on a bad uleb128.
1403 2020-03-14 Alan Modra <amodra@gmail.com>
1405 * readelf.c (process_file): Clean ba_cache.
1407 2020-03-14 Alan Modra <amodra@gmail.com>
1409 * elfcomm.h (setup_archive): Update prototype.
1410 * elfcomm.c (setup_archive): Add file_size parameter and sanity
1411 check longnames_size.
1412 (setup_nested_archive): Get file size and pass to setup_archive.
1413 * elfedit.c (process_archive): Likewise.
1414 * readelf.c (process_archive): Pass filedata->file_size to
1417 2020-03-14 Alan Modra <amodra@gmail.com>
1419 * readelf.c (dump_section_as_strings): Free memory on error exit.
1420 (dump_section_as_bytes, process_notes_at): Likewise.
1421 (get_build_id): Free enote.
1423 2020-03-13 Kamil Rytarowski <n54@gmx.com>
1425 * readelf.c (get_netbsd_elfcore_note_type): Add support for
1426 NT_NETBSDCORE_LWPSTATUS notes.
1428 2020-03-13 Alan Modra <amodra@gmail.com>
1430 * elfcomm.c (get_archive_member_name): Always return malloc'd
1432 * elfedit.c (process_archive): Tidy memory on all return paths.
1433 * readelf.c (process_archive): Likewise.
1434 (process_symbol_table): Likewise.
1435 (ba_cache): New, replacing ..
1436 (get_symbol_for_build_attribute): ..static vars here. Free
1437 strtab and symtab before loading new ones. Reject symtab without
1438 valid strtab in loop, breaking out of loop on valid symtab.
1439 (process_file): Free ba_cache symtab and strtab here, resetting
1442 2020-03-12 Alan Modra <amodra@gmail.com>
1444 * readelf.c (process_section_headers): Don't just set
1445 filedata->section_headers NULL, free it first. Similarly for
1446 dynamic_symbols, dynamic_strings, dynamic_syminfo and
1447 symtab_shndx_list. Zero associated counts too.
1448 (process_object): Free symtab_shndx_list.
1449 (process_file): Free various allocated filedata tables.
1451 2020-03-11 Nick Clifton <nickc@redhat.com>
1455 * dwarf.h (DWARF2_Internal_LineInfo): Add li_address_size and
1456 li_segment_size fields.
1457 * dwarf.c (read_debug_line_header): Record the address size and
1458 segment selector size values (if present) in the lineinfo
1460 (display_formatted_table): Warn if the format count is empty but
1461 the table itself is not empty.
1462 Display the format count and entry count at the start of the table
1464 (display_debug_lines_raw): Display the address size and segement
1465 selector size fields, if present.
1466 * testsuite/binutils-all/dw5.W: Update expected output.
1468 2020-03-11 Alan Modra <amodra@gmail.com>
1471 * objcopy.c (copy_object): Test "gaps" not gap_fill_set or
1472 pad_to_set on second block of code dealing with padding.
1473 Replace "c" with "num_sec" and don't recalculate number of
1474 sections on second block. Size arrays using sizeof (element)
1475 rather than sizeof (element type).
1477 2020-03-10 Alan Modra <amodra@gmail.com>
1479 * objdump.c (disassemble_section): Don't call qsort unless
1480 sym count is at least two.
1481 (disassemble_data): Don't call memcpy with NULL src.
1483 2020-03-09 Alan Modra <amodra@gmail.com>
1486 * readelf.c (dump_ia64_vms_dynamic_fixups): Pass size and nmemb
1487 to get_data rather than multiplying.
1488 (dump_ia64_vms_dynamic_relocs): Likewise.
1489 (process_version_sections): Correct order of size and nmemb args
1491 (process_mips_specific): Likewise.
1493 2020-03-08 H.J. Lu <hongjiu.lu@intel.com>
1495 * readelf.c (get_dynamic_data): Replace "memory chekers" with
1496 "memory checkers" in comments.
1498 2020-03-06 Simon Marchi <simon.marchi@efficios.com>
1501 * doc/Makefile.am: Rename MOSTLYCLEANFILES to MAINTAINERCLEANFILES.
1502 * doc/Makefile.in: Re-generate.
1504 2020-03-06 Nick Clifton <nickc@redhat.com>
1506 * objcopy.c (check_new_section_flags): New function. Reject the
1507 SEC_COFF_SHARED flag if the target is not a COFF binary.
1508 (copy_object): Call check_new_section_flags.
1509 (setup_section): Likewise.
1510 * doc/binutils.texi (objcopy): Add a note that the 'share' section
1511 flag cannot be applied to ELF binaries.
1513 2020-03-06 Alan Modra <amodra@gmail.com>
1516 * objcopy.c (filter_symbols): Correct rem_leading_char logic.
1518 2020-03-05 Alan Modra <amodra@gmail.com>
1521 * objcopy.c (filter_symbols): Don't segfault on NULL
1522 prefix_symbols_string.
1524 2020-03-04 Christian Eggers <ceggers@gmx.de>
1526 * objcopy.c (copy_object): Convert from bytes to octets for
1527 --gap-fill and --pad-to.
1529 2020-03-03 Nick Clifton <nickc@redhat.com>
1532 * prdbg.c (pr_tag_type): Remove call to abort.
1534 2020-03-02 Aaron Merey <amerey@redhat.com>
1536 * binutils/testsuite/binutils-all/debuginfod.exp: Improve port
1539 2020-03-02 Nick Clifton <nickc@redhat.com>
1542 * readelf.c (dump_section_as_strings): Display new-line characters
1543 as \n and then insert a line break.
1544 * testsuite/binutils-all/pr25543.s: New test.
1545 * testsuite/binutils-all/pr25543.d: Test driver.
1546 * testsuite/binutils-all/readelf.exp: Run the new test.
1548 2020-02-27 Nick Clifton <nickc@redhat.com>
1551 * readelf.c (process_ia64_vms_dynamic_relocs): Check to see if
1552 get_data is unable to load the string table.
1554 2020-02-26 Alan Modra <amodra@gmail.com>
1556 * elfedit.c: Indent labels correctly.
1557 * readelf.c: Likewise.
1558 * resres.c: Likewise.
1560 2020-02-25 H.J. Lu <hongjiu.lu@intel.com>
1563 * ar.c (main): Pass 0 to bfd_plugin_set_program_name.
1564 * nm.c (main): Pass 1 to bfd_plugin_set_program_name.
1566 2020-02-24 Nick Clifton <nickc@redhat.com>
1569 * doc/binutils.texi (objdump): Fix typo in description of
1570 objdump's -g option.
1572 2020-02-20 Nelson Chu <nelson.chu@sifive.com>
1574 * dwarf.c (regname_internal_riscv): Updated since the DECLARE_CSR
1577 2020-02-19 Jordan Rupprecht <rupprecht@google.com>
1579 * objdump.c (show_line): call bfd_demangle when using do_demangle.
1581 2020-02-19 Andrew Burgess <andrew.burgess@embecosm.com>
1583 * configure: Regenerate.
1585 2020-02-10 Fangrui Song <maskray@google.com>
1587 * objcopy.c (parse_flags): Handle "exclude".
1588 * doc/binutils.texi: Document the support.
1590 2020-02-10 Aaron Merey <amerey@redhat.com>
1592 * binutils/testsuite/binutils-all/debuginfod.exp:
1593 Replace set ::env with setenv.
1594 Start server before setting environment variable.
1595 Specify tmpdir as the location of the server's
1597 Check additional server metrics at start-up.
1599 2020-02-07 Nick Clifton <nickc@redhat.com>
1601 * README-how-to-make-a-release: Add note about updating the
1602 GAS/NEWS URL in the next release.
1604 2020-02-07 Sergey Belyashov <sergey.belyashov@gmail.com>
1607 * readelf.c (get_machine_flags): Add support for Z80N machine
1610 2020-02-07 Nick Clifton <nickc@redhat.com>
1612 * dwarf.c (display_debug_lines_decoded): Force a NUL termination
1613 of the truncated file name.
1615 2020-02-06 Andrew Burgess <andrew.burgess@embecosm.com>
1617 * objdump.c (print_jump_visualisation): New function.
1618 (disassemble_bytes): Call new function.
1620 2020-02-06 Alan Modra <amodra@gmail.com>
1622 * testsuite/lib/binutils-common.exp (match_target): Accept '!' before
1624 (supports_gnu_osabi): New procedure.
1625 (is_generic): New, from ld-lib.exp.
1626 (supports_gnu_unique): Use the above.
1628 2020-02-04 Alan Modra <amodra@gmail.com>
1630 * Makefile.am (CFILES): Add od-elf32_avr.c.
1631 * Makefile.in: Regenerate.
1632 * po/POTFILES.in: Regenerate.
1634 2020-02-03 Andreas Schwab <schwab@linux-m68k.org>
1636 * readelf.c (dump_relocations, dump_relocations)
1637 (decode_arm_unwind_bytecode, process_dynamic_section)
1638 (get_symbol_visibility, get_alpha_symbol_other): Add newline to
1641 2020-02-03 Sergei Trofimovich <siarheit@google.com>
1643 * coffdump.c (program_name): Drop redundant definition.
1644 * srconv.c (program_name): Likewise
1645 * sysdump.c (program_name): Likewise
1647 2020-02-02 H.J. Lu <hongjiu.lu@intel.com>
1650 * objdump.c (sym_ok): Return FALSE if 2 sections are in the
1651 same file with different section pointers.
1653 2020-02-01 Nick Clifton <nickc@redhat.com>
1655 * README-how-to-make-a-release: Update with more details on the
1656 release making process.
1658 2020-01-31 Nick Clifton <nickc@redhat.com>
1660 * po/sv.po: Updated Swedish translation.
1662 2020-01-28 Nick Clifton <nickc@redhat.com>
1664 * readelf.c (get_build_id): Simplify warning message about corrupt
1665 notes encountered whilst scanning for the build-id.
1667 2020-01-27 Roland McGrath <mcgrathr@google.com>
1669 * objcopy.c (compare_gnu_build_notes): Fix comparison results
1670 for overlapping ranges so that (A == B) == (B == A) holds.
1672 2020-01-27 Alan Modra <amodra@gmail.com>
1674 * testsuite/lib/binutils-common.exp (big_or_little_endian): Replace
1675 case statement with switch statement.
1677 2020-01-24 Nick Clifton <nickc@redhat.com>
1679 * readelf.c (get_build_id): Fix warning messages about corrupt
1682 2020-01-23 Nick Clifton <nickc@redhat.com>
1684 * po/fr.po: Updated French translation.
1686 2020-01-22 Yuri Chornoivan <yurchor@mageia.org>
1689 * readelf.c (get_alpha_symbol_other): Fix error message typo.
1691 2020-01-20 Nick Clifton <nickc@redhat.com>
1693 * po/pt.po: Updated Portuguese translation.
1694 * po/uk.po: Updated Ukranian translation.
1696 2020-01-18 Nick Clifton <nickc@redhat.com>
1698 * README-how-to-make-a-release: Update notes on how to cut a
1699 branch for a release.
1701 2020-01-18 Nick Clifton <nickc@redhat.com>
1703 * configure: Regenerate.
1704 * po/binutils.pot: Regenerate.
1706 2020-01-18 Nick Clifton <nickc@redhat.com>
1708 Binutils 2.34 branch created.
1710 2020-01-17 Thomas Troeger <tstroege@gmx.de>
1712 * objdump.c (jump_info_visualize_address): Discard jumps that are
1714 (disassemble_bytes): Only compute the maximum level if jumps were
1717 2020-01-13 Nick Clifton <nickc@redhat.com>
1719 * objdump.c (disassemble_bytes): Remove C99-ism.
1720 * testsuite/binutils-all/debuginfod.exp: New tests.
1722 2020-01-13 Thomas Troeger <tstroege@gmx.de>
1724 * objdump.c (visualize_jumps, color_output, extended_color_output)
1725 (detected_jumps): New variables.
1726 (usage): Add the new jump visualization options.
1727 (option_values): Add new option value.
1728 (long_options): Add the new option.
1729 (jump_info_new, jump_info_free): New functions.
1730 (jump_info_min_address, jump_info_max_address): Likewise.
1731 (jump_info_end_address, jump_info_is_start_address): Likewise.
1732 (jump_info_is_end_address, jump_info_size): Likewise.
1733 (jump_info_unlink, jump_info_insert): Likewise.
1734 (jump_info_add_front, jump_info_move_linked): Likewise.
1735 (jump_info_intersect, jump_info_merge): Likewise.
1736 (jump_info_sort, jump_info_visualize_address): Likewise.
1737 (disassemble_jumps): New function - used to locate jumps.
1738 (disassemble_bytes): Add ascii art generation.
1739 (disassemble_section): Add scan to locate jumps.
1740 (main): Parse the new visualization option.
1741 * doc/binutils.texi: Document the new feature.
1742 * NEWS: Mention the new feature.
1744 2020-01-13 Alan Modra <amodra@gmail.com>
1748 * dwarf.c (display_debug_frames): Move fde_fc earlier. Free
1749 fde_fc col_type and col_offset.
1750 * readelf.c (apply_relocations): Move symsec check earlier.
1751 (free_debug_section): Free reloc_info.
1752 (process_notes_at): Free pnotes on error path.
1753 (process_object): Free dump_sects here..
1754 (process_archive): ..not here.
1756 2020-01-13 Alan Modra <amodra@gmail.com>
1759 * nm.c (display_rel_file): Free dyn_syms.
1761 2020-01-09 Nick Clifton <nickc@redhat.com>
1764 * objcopy.c (empty_name): New variable.
1765 (need_sym_before): Prevent an attempt to free a static variable.
1766 (filter_symbols): Avoid strcmp test by checking for pointer
1769 2020-01-09 Nick Clifton <nickc@redhat.com>
1771 * po/zh_TW.po: Updated Traditional Chinese translation.
1773 2020-01-09 Aaron Merey <amerey@redhat.com>
1775 * Makefile.am (readelf_LDADD, objdump_LDADD): Add libdebuginfod.
1776 * Makefile.in: Regenerate.
1778 * config.in: Regenerate.
1779 * configure: Regenerate.
1780 * configure.ac: Call AC_DEBUGINFOD.
1781 * doc/Makefile.in: Regenerate.
1782 * doc/binutils.texi: Add section on using binutils
1784 * dwarf.c (debuginfod_fetch_separate_debug_info): New function.
1785 Query debuginfod servers for the target debug file.
1786 (load_separate_debug_info): Call
1787 debuginfod_fetch_separate_debug_info if configured with
1789 (load_separate_debug_files): Add file argument to
1790 load_separate_debug_info calls.
1791 * dwarf.h (get_build_id): Add declaration.
1792 * objdump.c (get_build_id): New function. Get build-id of file.
1793 * readelf.c (get_build_id): Likewise.
1794 * testsuite/binutils-all/debuginfod.exp: New tests.
1795 * testsuite/binutils-all/linkdebug.s: Add .note.gnu.build-id
1798 2020-01-02 Sergey Belyashov <sergey.belyashov@gmail.com>
1800 * readelf.c: Add support for new Z*) relocations and machine
1803 2020-01-01 Alan Modra <amodra@gmail.com>
1805 Update year range in copyright notice of all files.
1807 For older changes see ChangeLog-2019
1809 Copyright (C) 2020 Free Software Foundation, Inc.
1811 Copying and distribution of this file, with or without modification,
1812 are permitted in any medium without royalty provided the copyright
1813 notice and this notice are preserved.
1819 version-control: never