drivers/gpu/drm/i915/i915_sysfs.c

   1 /*
   2  * Copyright © 2012 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  *
  23  * Authors:
  24  *    Ben Widawsky <ben@bwidawsk.net>
  25  *
  26  */
  27
  28 #include <linux/device.h>
  29 #include <linux/module.h>
  30 #include <linux/stat.h>
  31 #include <linux/sysfs.h>
  32 #include "intel_drv.h"
  33 #include "i915_drv.h"
  34
  35 #define dev_to_drm_minor(d) dev_get_drvdata((d))
  36
  37 #ifdef CONFIG_PM
  38 static u32 calc_residency(struct drm_device *dev, const u32 reg)
  39 {
  40         struct drm_i915_private *dev_priv = dev->dev_private;
  41         u64 raw_time; /* 32b value may overflow during fixed point math */
  42         u64 units = 128ULL, div = 100000ULL, bias = 100ULL;
  43
  44         if (!intel_enable_rc6(dev))
  45                 return 0;
  46
  47         /* On VLV, residency time is in CZ units rather than 1.28us */
  48         if (IS_VALLEYVIEW(dev)) {
  49                 u32 clkctl2;
  50
  51                 clkctl2 = I915_READ(VLV_CLK_CTL2) >>
  52                         CLK_CTL2_CZCOUNT_30NS_SHIFT;
  53                 if (!clkctl2) {
  54                         WARN(!clkctl2, "bogus CZ count value");
  55                         return 0;
  56                 }
  57                 units = DIV_ROUND_UP_ULL(30ULL * bias, (u64)clkctl2);
  58                 if (I915_READ(VLV_COUNTER_CONTROL) & VLV_COUNT_RANGE_HIGH)
  59                         units <<= 8;
  60
  61                 div = 1000000ULL * bias;
  62         }
  63
  64         raw_time = I915_READ(reg) * units;
  65         return DIV_ROUND_UP_ULL(raw_time, div);
  66 }
  67
  68 static ssize_t
  69 show_rc6_mask(struct device *kdev, struct device_attribute *attr, char *buf)
  70 {
  71         struct drm_minor *dminor = dev_to_drm_minor(kdev);
  72         return snprintf(buf, PAGE_SIZE, "%x\n", intel_enable_rc6(dminor->dev));
  73 }
  74
  75 static ssize_t
  76 show_rc6_ms(struct device *kdev, struct device_attribute *attr, char *buf)
  77 {
  78         struct drm_minor *dminor = dev_get_drvdata(kdev);
  79         u32 rc6_residency = calc_residency(dminor->dev, GEN6_GT_GFX_RC6);
  80         return snprintf(buf, PAGE_SIZE, "%u\n", rc6_residency);
  81 }
  82
  83 static ssize_t
  84 show_rc6p_ms(struct device *kdev, struct device_attribute *attr, char *buf)
  85 {
  86         struct drm_minor *dminor = dev_to_drm_minor(kdev);
  87         u32 rc6p_residency = calc_residency(dminor->dev, GEN6_GT_GFX_RC6p);
  88         if (IS_VALLEYVIEW(dminor->dev))
  89                 rc6p_residency = 0;
  90         return snprintf(buf, PAGE_SIZE, "%u\n", rc6p_residency);
  91 }
  92
  93 static ssize_t
  94 show_rc6pp_ms(struct device *kdev, struct device_attribute *attr, char *buf)
  95 {
  96         struct drm_minor *dminor = dev_to_drm_minor(kdev);
  97         u32 rc6pp_residency = calc_residency(dminor->dev, GEN6_GT_GFX_RC6pp);
  98         if (IS_VALLEYVIEW(dminor->dev))
  99                 rc6pp_residency = 0;
 100         return snprintf(buf, PAGE_SIZE, "%u\n", rc6pp_residency);
 101 }
 102
 103 static DEVICE_ATTR(rc6_enable, S_IRUGO, show_rc6_mask, NULL);
 104 static DEVICE_ATTR(rc6_residency_ms, S_IRUGO, show_rc6_ms, NULL);
 105 static DEVICE_ATTR(rc6p_residency_ms, S_IRUGO, show_rc6p_ms, NULL);
 106 static DEVICE_ATTR(rc6pp_residency_ms, S_IRUGO, show_rc6pp_ms, NULL);
 107
 108 static struct attribute *rc6_attrs[] = {
 109         &dev_attr_rc6_enable.attr,
 110         &dev_attr_rc6_residency_ms.attr,
 111         &dev_attr_rc6p_residency_ms.attr,
 112         &dev_attr_rc6pp_residency_ms.attr,
 113         NULL
 114 };
 115
 116 static struct attribute_group rc6_attr_group = {
 117         .name = power_group_name,
 118         .attrs =  rc6_attrs
 119 };
 120 #endif
 121
 122 static int l3_access_valid(struct drm_device *dev, loff_t offset)
 123 {
 124         if (!HAS_L3_DPF(dev))
 125                 return -EPERM;
 126
 127         if (offset % 4 != 0)
 128                 return -EINVAL;
 129
 130         if (offset >= GEN7_L3LOG_SIZE)
 131                 return -ENXIO;
 132
 133         return 0;
 134 }
 135
 136 static ssize_t
 137 i915_l3_read(struct file *filp, struct kobject *kobj,
 138              struct bin_attribute *attr, char *buf,
 139              loff_t offset, size_t count)
 140 {
 141         struct device *dev = container_of(kobj, struct device, kobj);
 142         struct drm_minor *dminor = dev_to_drm_minor(dev);
 143         struct drm_device *drm_dev = dminor->dev;
 144         struct drm_i915_private *dev_priv = drm_dev->dev_private;
 145         int slice = (int)(uintptr_t)attr->private;
 146         int ret;
 147
 148         count = round_down(count, 4);
 149
 150         ret = l3_access_valid(drm_dev, offset);
 151         if (ret)
 152                 return ret;
 153
 154         count = min_t(size_t, GEN7_L3LOG_SIZE - offset, count);
 155
 156         ret = i915_mutex_lock_interruptible(drm_dev);
 157         if (ret)
 158                 return ret;
 159
 160         if (dev_priv->l3_parity.remap_info[slice])
 161                 memcpy(buf,
 162                        dev_priv->l3_parity.remap_info[slice] + (offset/4),
 163                        count);
 164         else
 165                 memset(buf, 0, count);
 166
 167         mutex_unlock(&drm_dev->struct_mutex);
 168
 169         return count;
 170 }
 171
 172 static ssize_t
 173 i915_l3_write(struct file *filp, struct kobject *kobj,
 174               struct bin_attribute *attr, char *buf,
 175               loff_t offset, size_t count)
 176 {
 177         struct device *dev = container_of(kobj, struct device, kobj);
 178         struct drm_minor *dminor = dev_to_drm_minor(dev);
 179         struct drm_device *drm_dev = dminor->dev;
 180         struct drm_i915_private *dev_priv = drm_dev->dev_private;
 181         struct i915_hw_context *ctx;
 182         u32 *temp = NULL; /* Just here to make handling failures easy */
 183         int slice = (int)(uintptr_t)attr->private;
 184         int ret;
 185
 186         ret = l3_access_valid(drm_dev, offset);
 187         if (ret)
 188                 return ret;
 189
 190         if (dev_priv->hw_contexts_disabled)
 191                 return -ENXIO;
 192
 193         ret = i915_mutex_lock_interruptible(drm_dev);
 194         if (ret)
 195                 return ret;
 196
 197         if (!dev_priv->l3_parity.remap_info[slice]) {
 198                 temp = kzalloc(GEN7_L3LOG_SIZE, GFP_KERNEL);
 199                 if (!temp) {
 200                         mutex_unlock(&drm_dev->struct_mutex);
 201                         return -ENOMEM;
 202                 }
 203         }
 204
 205         ret = i915_gpu_idle(drm_dev);
 206         if (ret) {
 207                 kfree(temp);
 208                 mutex_unlock(&drm_dev->struct_mutex);
 209                 return ret;
 210         }
 211
 212         /* TODO: Ideally we really want a GPU reset here to make sure errors
 213          * aren't propagated. Since I cannot find a stable way to reset the GPU
 214          * at this point it is left as a TODO.
 215         */
 216         if (temp)
 217                 dev_priv->l3_parity.remap_info[slice] = temp;
 218
 219         memcpy(dev_priv->l3_parity.remap_info[slice] + (offset/4), buf, count);
 220
 221         /* NB: We defer the remapping until we switch to the context */
 222         list_for_each_entry(ctx, &dev_priv->context_list, link)
 223                 ctx->remap_slice |= (1<<slice);
 224
 225         mutex_unlock(&drm_dev->struct_mutex);
 226
 227         return count;
 228 }
 229
 230 static struct bin_attribute dpf_attrs = {
 231         .attr = {.name = "l3_parity", .mode = (S_IRUSR | S_IWUSR)},
 232         .size = GEN7_L3LOG_SIZE,
 233         .read = i915_l3_read,
 234         .write = i915_l3_write,
 235         .mmap = NULL,
 236         .private = (void *)0
 237 };
 238
 239 static struct bin_attribute dpf_attrs_1 = {
 240         .attr = {.name = "l3_parity_slice_1", .mode = (S_IRUSR | S_IWUSR)},
 241         .size = GEN7_L3LOG_SIZE,
 242         .read = i915_l3_read,
 243         .write = i915_l3_write,
 244         .mmap = NULL,
 245         .private = (void *)1
 246 };
 247
 248 static ssize_t gt_cur_freq_mhz_show(struct device *kdev,
 249                                     struct device_attribute *attr, char *buf)
 250 {
 251         struct drm_minor *minor = dev_to_drm_minor(kdev);
 252         struct drm_device *dev = minor->dev;
 253         struct drm_i915_private *dev_priv = dev->dev_private;
 254         int ret;
 255
 256         mutex_lock(&dev_priv->rps.hw_lock);
 257         if (IS_VALLEYVIEW(dev_priv->dev)) {
 258                 u32 freq;
 259                 freq = vlv_punit_read(dev_priv, PUNIT_REG_GPU_FREQ_STS);
 260                 ret = vlv_gpu_freq(dev_priv->mem_freq, (freq >> 8) & 0xff);
 261         } else {
 262                 ret = dev_priv->rps.cur_delay * GT_FREQUENCY_MULTIPLIER;
 263         }
 264         mutex_unlock(&dev_priv->rps.hw_lock);
 265
 266         return snprintf(buf, PAGE_SIZE, "%d\n", ret);
 267 }
 268
 269 static ssize_t vlv_rpe_freq_mhz_show(struct device *kdev,
 270                                      struct device_attribute *attr, char *buf)
 271 {
 272         struct drm_minor *minor = dev_to_drm_minor(kdev);
 273         struct drm_device *dev = minor->dev;
 274         struct drm_i915_private *dev_priv = dev->dev_private;
 275
 276         return snprintf(buf, PAGE_SIZE, "%d\n",
 277                         vlv_gpu_freq(dev_priv->mem_freq,
 278                                      dev_priv->rps.rpe_delay));
 279 }
 280
 281 static ssize_t gt_max_freq_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf)
 282 {
 283         struct drm_minor *minor = dev_to_drm_minor(kdev);
 284         struct drm_device *dev = minor->dev;
 285         struct drm_i915_private *dev_priv = dev->dev_private;
 286         int ret;
 287
 288         mutex_lock(&dev_priv->rps.hw_lock);
 289         if (IS_VALLEYVIEW(dev_priv->dev))
 290                 ret = vlv_gpu_freq(dev_priv->mem_freq, dev_priv->rps.max_delay);
 291         else
 292                 ret = dev_priv->rps.max_delay * GT_FREQUENCY_MULTIPLIER;
 293         mutex_unlock(&dev_priv->rps.hw_lock);
 294
 295         return snprintf(buf, PAGE_SIZE, "%d\n", ret);
 296 }
 297
 298 static ssize_t gt_max_freq_mhz_store(struct device *kdev,
 299                                      struct device_attribute *attr,
 300                                      const char *buf, size_t count)
 301 {
 302         struct drm_minor *minor = dev_to_drm_minor(kdev);
 303         struct drm_device *dev = minor->dev;
 304         struct drm_i915_private *dev_priv = dev->dev_private;
 305         u32 val, rp_state_cap, hw_max, hw_min, non_oc_max;
 306         ssize_t ret;
 307
 308         ret = kstrtou32(buf, 0, &val);
 309         if (ret)
 310                 return ret;
 311
 312         mutex_lock(&dev_priv->rps.hw_lock);
 313
 314         if (IS_VALLEYVIEW(dev_priv->dev)) {
 315                 val = vlv_freq_opcode(dev_priv->mem_freq, val);
 316
 317                 hw_max = valleyview_rps_max_freq(dev_priv);
 318                 hw_min = valleyview_rps_min_freq(dev_priv);
 319                 non_oc_max = hw_max;
 320         } else {
 321                 val /= GT_FREQUENCY_MULTIPLIER;
 322
 323                 rp_state_cap = I915_READ(GEN6_RP_STATE_CAP);
 324                 hw_max = dev_priv->rps.hw_max;
 325                 non_oc_max = (rp_state_cap & 0xff);
 326                 hw_min = ((rp_state_cap & 0xff0000) >> 16);
 327         }
 328
 329         if (val < hw_min || val > hw_max ||
 330             val < dev_priv->rps.min_delay) {
 331                 mutex_unlock(&dev_priv->rps.hw_lock);
 332                 return -EINVAL;
 333         }
 334
 335         if (val > non_oc_max)
 336                 DRM_DEBUG("User requested overclocking to %d\n",
 337                           val * GT_FREQUENCY_MULTIPLIER);
 338
 339         if (dev_priv->rps.cur_delay > val) {
 340                 if (IS_VALLEYVIEW(dev_priv->dev))
 341                         valleyview_set_rps(dev_priv->dev, val);
 342                 else
 343                         gen6_set_rps(dev_priv->dev, val);
 344         }
 345
 346         dev_priv->rps.max_delay = val;
 347
 348         mutex_unlock(&dev_priv->rps.hw_lock);
 349
 350         return count;
 351 }
 352
 353 static ssize_t gt_min_freq_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf)
 354 {
 355         struct drm_minor *minor = dev_to_drm_minor(kdev);
 356         struct drm_device *dev = minor->dev;
 357         struct drm_i915_private *dev_priv = dev->dev_private;
 358         int ret;
 359
 360         mutex_lock(&dev_priv->rps.hw_lock);
 361         if (IS_VALLEYVIEW(dev_priv->dev))
 362                 ret = vlv_gpu_freq(dev_priv->mem_freq, dev_priv->rps.min_delay);
 363         else
 364                 ret = dev_priv->rps.min_delay * GT_FREQUENCY_MULTIPLIER;
 365         mutex_unlock(&dev_priv->rps.hw_lock);
 366
 367         return snprintf(buf, PAGE_SIZE, "%d\n", ret);
 368 }
 369
 370 static ssize_t gt_min_freq_mhz_store(struct device *kdev,
 371                                      struct device_attribute *attr,
 372                                      const char *buf, size_t count)
 373 {
 374         struct drm_minor *minor = dev_to_drm_minor(kdev);
 375         struct drm_device *dev = minor->dev;
 376         struct drm_i915_private *dev_priv = dev->dev_private;
 377         u32 val, rp_state_cap, hw_max, hw_min;
 378         ssize_t ret;
 379
 380         ret = kstrtou32(buf, 0, &val);
 381         if (ret)
 382                 return ret;
 383
 384         mutex_lock(&dev_priv->rps.hw_lock);
 385
 386         if (IS_VALLEYVIEW(dev)) {
 387                 val = vlv_freq_opcode(dev_priv->mem_freq, val);
 388
 389                 hw_max = valleyview_rps_max_freq(dev_priv);
 390                 hw_min = valleyview_rps_min_freq(dev_priv);
 391         } else {
 392                 val /= GT_FREQUENCY_MULTIPLIER;
 393
 394                 rp_state_cap = I915_READ(GEN6_RP_STATE_CAP);
 395                 hw_max = dev_priv->rps.hw_max;
 396                 hw_min = ((rp_state_cap & 0xff0000) >> 16);
 397         }
 398
 399         if (val < hw_min || val > hw_max || val > dev_priv->rps.max_delay) {
 400                 mutex_unlock(&dev_priv->rps.hw_lock);
 401                 return -EINVAL;
 402         }
 403
 404         if (dev_priv->rps.cur_delay < val) {
 405                 if (IS_VALLEYVIEW(dev))
 406                         valleyview_set_rps(dev, val);
 407                 else
 408                         gen6_set_rps(dev_priv->dev, val);
 409         }
 410
 411         dev_priv->rps.min_delay = val;
 412
 413         mutex_unlock(&dev_priv->rps.hw_lock);
 414
 415         return count;
 416
 417 }
 418
 419 static DEVICE_ATTR(gt_cur_freq_mhz, S_IRUGO, gt_cur_freq_mhz_show, NULL);
 420 static DEVICE_ATTR(gt_max_freq_mhz, S_IRUGO | S_IWUSR, gt_max_freq_mhz_show, gt_max_freq_mhz_store);
 421 static DEVICE_ATTR(gt_min_freq_mhz, S_IRUGO | S_IWUSR, gt_min_freq_mhz_show, gt_min_freq_mhz_store);
 422
 423 static DEVICE_ATTR(vlv_rpe_freq_mhz, S_IRUGO, vlv_rpe_freq_mhz_show, NULL);
 424
 425 static ssize_t gt_rp_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf);
 426 static DEVICE_ATTR(gt_RP0_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL);
 427 static DEVICE_ATTR(gt_RP1_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL);
 428 static DEVICE_ATTR(gt_RPn_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL);
 429
 430 /* For now we have a static number of RP states */
 431 static ssize_t gt_rp_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf)
 432 {
 433         struct drm_minor *minor = dev_to_drm_minor(kdev);
 434         struct drm_device *dev = minor->dev;
 435         struct drm_i915_private *dev_priv = dev->dev_private;
 436         u32 val, rp_state_cap;
 437         ssize_t ret;
 438
 439         ret = mutex_lock_interruptible(&dev->struct_mutex);
 440         if (ret)
 441                 return ret;
 442         rp_state_cap = I915_READ(GEN6_RP_STATE_CAP);
 443         mutex_unlock(&dev->struct_mutex);
 444
 445         if (attr == &dev_attr_gt_RP0_freq_mhz) {
 446                 val = ((rp_state_cap & 0x0000ff) >> 0) * GT_FREQUENCY_MULTIPLIER;
 447         } else if (attr == &dev_attr_gt_RP1_freq_mhz) {
 448                 val = ((rp_state_cap & 0x00ff00) >> 8) * GT_FREQUENCY_MULTIPLIER;
 449         } else if (attr == &dev_attr_gt_RPn_freq_mhz) {
 450                 val = ((rp_state_cap & 0xff0000) >> 16) * GT_FREQUENCY_MULTIPLIER;
 451         } else {
 452                 BUG();
 453         }
 454         return snprintf(buf, PAGE_SIZE, "%d\n", val);
 455 }
 456
 457 static const struct attribute *gen6_attrs[] = {
 458         &dev_attr_gt_cur_freq_mhz.attr,
 459         &dev_attr_gt_max_freq_mhz.attr,
 460         &dev_attr_gt_min_freq_mhz.attr,
 461         &dev_attr_gt_RP0_freq_mhz.attr,
 462         &dev_attr_gt_RP1_freq_mhz.attr,
 463         &dev_attr_gt_RPn_freq_mhz.attr,
 464         NULL,
 465 };
 466
 467 static const struct attribute *vlv_attrs[] = {
 468         &dev_attr_gt_cur_freq_mhz.attr,
 469         &dev_attr_gt_max_freq_mhz.attr,
 470         &dev_attr_gt_min_freq_mhz.attr,
 471         &dev_attr_vlv_rpe_freq_mhz.attr,
 472         NULL,
 473 };
 474
 475 static ssize_t error_state_read(struct file *filp, struct kobject *kobj,
 476                                 struct bin_attribute *attr, char *buf,
 477                                 loff_t off, size_t count)
 478 {
 479
 480         struct device *kdev = container_of(kobj, struct device, kobj);
 481         struct drm_minor *minor = dev_to_drm_minor(kdev);
 482         struct drm_device *dev = minor->dev;
 483         struct i915_error_state_file_priv error_priv;
 484         struct drm_i915_error_state_buf error_str;
 485         ssize_t ret_count = 0;
 486         int ret;
 487
 488         memset(&error_priv, 0, sizeof(error_priv));
 489
 490         ret = i915_error_state_buf_init(&error_str, count, off);
 491         if (ret)
 492                 return ret;
 493
 494         error_priv.dev = dev;
 495         i915_error_state_get(dev, &error_priv);
 496
 497         ret = i915_error_state_to_str(&error_str, &error_priv);
 498         if (ret)
 499                 goto out;
 500
 501         ret_count = count < error_str.bytes ? count : error_str.bytes;
 502
 503         memcpy(buf, error_str.buf, ret_count);
 504 out:
 505         i915_error_state_put(&error_priv);
 506         i915_error_state_buf_release(&error_str);
 507
 508         return ret ?: ret_count;
 509 }
 510
 511 static ssize_t error_state_write(struct file *file, struct kobject *kobj,
 512                                  struct bin_attribute *attr, char *buf,
 513                                  loff_t off, size_t count)
 514 {
 515         struct device *kdev = container_of(kobj, struct device, kobj);
 516         struct drm_minor *minor = dev_to_drm_minor(kdev);
 517         struct drm_device *dev = minor->dev;
 518         int ret;
 519
 520         DRM_DEBUG_DRIVER("Resetting error state\n");
 521
 522         ret = mutex_lock_interruptible(&dev->struct_mutex);
 523         if (ret)
 524                 return ret;
 525
 526         i915_destroy_error_state(dev);
 527         mutex_unlock(&dev->struct_mutex);
 528
 529         return count;
 530 }
 531
 532 static struct bin_attribute error_state_attr = {
 533         .attr.name = "error",
 534         .attr.mode = S_IRUSR | S_IWUSR,
 535         .size = 0,
 536         .read = error_state_read,
 537         .write = error_state_write,
 538 };
 539
 540 void i915_setup_sysfs(struct drm_device *dev)
 541 {
 542         int ret;
 543
 544 #ifdef CONFIG_PM
 545         if (INTEL_INFO(dev)->gen >= 6) {
 546                 ret = sysfs_merge_group(&dev->primary->kdev->kobj,
 547                                         &rc6_attr_group);
 548                 if (ret)
 549                         DRM_ERROR("RC6 residency sysfs setup failed\n");
 550         }
 551 #endif
 552         if (HAS_L3_DPF(dev)) {
 553                 ret = device_create_bin_file(dev->primary->kdev, &dpf_attrs);
 554                 if (ret)
 555                         DRM_ERROR("l3 parity sysfs setup failed\n");
 556
 557                 if (NUM_L3_SLICES(dev) > 1) {
 558                         ret = device_create_bin_file(dev->primary->kdev,
 559                                                      &dpf_attrs_1);
 560                         if (ret)
 561                                 DRM_ERROR("l3 parity slice 1 setup failed\n");
 562                 }
 563         }
 564
 565         ret = 0;
 566         if (IS_VALLEYVIEW(dev))
 567                 ret = sysfs_create_files(&dev->primary->kdev->kobj, vlv_attrs);
 568         else if (INTEL_INFO(dev)->gen >= 6)
 569                 ret = sysfs_create_files(&dev->primary->kdev->kobj, gen6_attrs);
 570         if (ret)
 571                 DRM_ERROR("RPS sysfs setup failed\n");
 572
 573         ret = sysfs_create_bin_file(&dev->primary->kdev->kobj,
 574                                     &error_state_attr);
 575         if (ret)
 576                 DRM_ERROR("error_state sysfs setup failed\n");
 577 }
 578
 579 void i915_teardown_sysfs(struct drm_device *dev)
 580 {
 581         sysfs_remove_bin_file(&dev->primary->kdev->kobj, &error_state_attr);
 582         if (IS_VALLEYVIEW(dev))
 583                 sysfs_remove_files(&dev->primary->kdev->kobj, vlv_attrs);
 584         else
 585                 sysfs_remove_files(&dev->primary->kdev->kobj, gen6_attrs);
 586         device_remove_bin_file(dev->primary->kdev,  &dpf_attrs_1);
 587         device_remove_bin_file(dev->primary->kdev,  &dpf_attrs);
 588 #ifdef CONFIG_PM
 589         sysfs_unmerge_group(&dev->primary->kdev->kobj, &rc6_attr_group);
 590 #endif
 591 }