drm/imx: parallel-display: check return code from of_get_drm_display_mode()
[deliverable/linux.git] / drivers / gpu / drm / imx / parallel-display.c
1 /*
2 * i.MX drm driver - parallel display implementation
3 *
4 * Copyright (C) 2012 Sascha Hauer, Pengutronix
5 *
6 * This program is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU General Public License
8 * as published by the Free Software Foundation; either version 2
9 * of the License, or (at your option) any later version.
10 * This program is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 */
15
16 #include <linux/component.h>
17 #include <linux/module.h>
18 #include <drm/drmP.h>
19 #include <drm/drm_atomic_helper.h>
20 #include <drm/drm_fb_helper.h>
21 #include <drm/drm_crtc_helper.h>
22 #include <drm/drm_panel.h>
23 #include <linux/videodev2.h>
24 #include <video/of_display_timing.h>
25 #include <linux/of_graph.h>
26
27 #include "imx-drm.h"
28
29 struct imx_parallel_display {
30 struct drm_connector connector;
31 struct drm_encoder encoder;
32 struct device *dev;
33 void *edid;
34 int edid_len;
35 u32 bus_format;
36 struct drm_display_mode mode;
37 struct drm_panel *panel;
38 };
39
40 static inline struct imx_parallel_display *con_to_imxpd(struct drm_connector *c)
41 {
42 return container_of(c, struct imx_parallel_display, connector);
43 }
44
45 static inline struct imx_parallel_display *enc_to_imxpd(struct drm_encoder *e)
46 {
47 return container_of(e, struct imx_parallel_display, encoder);
48 }
49
50 static enum drm_connector_status imx_pd_connector_detect(
51 struct drm_connector *connector, bool force)
52 {
53 return connector_status_connected;
54 }
55
56 static int imx_pd_connector_get_modes(struct drm_connector *connector)
57 {
58 struct imx_parallel_display *imxpd = con_to_imxpd(connector);
59 struct device_node *np = imxpd->dev->of_node;
60 int num_modes = 0;
61
62 if (imxpd->panel && imxpd->panel->funcs &&
63 imxpd->panel->funcs->get_modes) {
64 num_modes = imxpd->panel->funcs->get_modes(imxpd->panel);
65 if (num_modes > 0)
66 return num_modes;
67 }
68
69 if (imxpd->edid) {
70 drm_mode_connector_update_edid_property(connector, imxpd->edid);
71 num_modes = drm_add_edid_modes(connector, imxpd->edid);
72 }
73
74 if (np) {
75 struct drm_display_mode *mode = drm_mode_create(connector->dev);
76 int ret;
77
78 if (!mode)
79 return -EINVAL;
80
81 ret = of_get_drm_display_mode(np, &imxpd->mode,
82 OF_USE_NATIVE_MODE);
83 if (ret)
84 return ret;
85
86 drm_mode_copy(mode, &imxpd->mode);
87 mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
88 drm_mode_probed_add(connector, mode);
89 num_modes++;
90 }
91
92 return num_modes;
93 }
94
95 static struct drm_encoder *imx_pd_connector_best_encoder(
96 struct drm_connector *connector)
97 {
98 struct imx_parallel_display *imxpd = con_to_imxpd(connector);
99
100 return &imxpd->encoder;
101 }
102
103 static void imx_pd_encoder_enable(struct drm_encoder *encoder)
104 {
105 struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
106
107 drm_panel_prepare(imxpd->panel);
108 drm_panel_enable(imxpd->panel);
109 }
110
111 static void imx_pd_encoder_disable(struct drm_encoder *encoder)
112 {
113 struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
114
115 drm_panel_disable(imxpd->panel);
116 drm_panel_unprepare(imxpd->panel);
117 }
118
119 static int imx_pd_encoder_atomic_check(struct drm_encoder *encoder,
120 struct drm_crtc_state *crtc_state,
121 struct drm_connector_state *conn_state)
122 {
123 struct imx_crtc_state *imx_crtc_state = to_imx_crtc_state(crtc_state);
124 struct drm_display_info *di = &conn_state->connector->display_info;
125 struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
126
127 imx_crtc_state->bus_flags = di->bus_flags;
128 if (!imxpd->bus_format && di->num_bus_formats)
129 imx_crtc_state->bus_format = di->bus_formats[0];
130 else
131 imx_crtc_state->bus_format = imxpd->bus_format;
132 imx_crtc_state->di_hsync_pin = 2;
133 imx_crtc_state->di_vsync_pin = 3;
134
135 return 0;
136 }
137
138 static const struct drm_connector_funcs imx_pd_connector_funcs = {
139 .dpms = drm_atomic_helper_connector_dpms,
140 .fill_modes = drm_helper_probe_single_connector_modes,
141 .detect = imx_pd_connector_detect,
142 .destroy = imx_drm_connector_destroy,
143 .reset = drm_atomic_helper_connector_reset,
144 .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
145 .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
146 };
147
148 static const struct drm_connector_helper_funcs imx_pd_connector_helper_funcs = {
149 .get_modes = imx_pd_connector_get_modes,
150 .best_encoder = imx_pd_connector_best_encoder,
151 };
152
153 static const struct drm_encoder_funcs imx_pd_encoder_funcs = {
154 .destroy = imx_drm_encoder_destroy,
155 };
156
157 static const struct drm_encoder_helper_funcs imx_pd_encoder_helper_funcs = {
158 .enable = imx_pd_encoder_enable,
159 .disable = imx_pd_encoder_disable,
160 .atomic_check = imx_pd_encoder_atomic_check,
161 };
162
163 static int imx_pd_register(struct drm_device *drm,
164 struct imx_parallel_display *imxpd)
165 {
166 struct drm_encoder *encoder = &imxpd->encoder;
167 int ret;
168
169 ret = imx_drm_encoder_parse_of(drm, encoder, imxpd->dev->of_node);
170 if (ret)
171 return ret;
172
173 /* set the connector's dpms to OFF so that
174 * drm_helper_connector_dpms() won't return
175 * immediately since the current state is ON
176 * at this point.
177 */
178 imxpd->connector.dpms = DRM_MODE_DPMS_OFF;
179
180 drm_encoder_helper_add(encoder, &imx_pd_encoder_helper_funcs);
181 drm_encoder_init(drm, encoder, &imx_pd_encoder_funcs,
182 DRM_MODE_ENCODER_NONE, NULL);
183
184 drm_connector_helper_add(&imxpd->connector,
185 &imx_pd_connector_helper_funcs);
186 drm_connector_init(drm, &imxpd->connector, &imx_pd_connector_funcs,
187 DRM_MODE_CONNECTOR_VGA);
188
189 if (imxpd->panel)
190 drm_panel_attach(imxpd->panel, &imxpd->connector);
191
192 drm_mode_connector_attach_encoder(&imxpd->connector, encoder);
193
194 return 0;
195 }
196
197 static int imx_pd_bind(struct device *dev, struct device *master, void *data)
198 {
199 struct drm_device *drm = data;
200 struct device_node *np = dev->of_node;
201 struct device_node *ep;
202 const u8 *edidp;
203 struct imx_parallel_display *imxpd;
204 int ret;
205 u32 bus_format = 0;
206 const char *fmt;
207
208 imxpd = devm_kzalloc(dev, sizeof(*imxpd), GFP_KERNEL);
209 if (!imxpd)
210 return -ENOMEM;
211
212 edidp = of_get_property(np, "edid", &imxpd->edid_len);
213 if (edidp)
214 imxpd->edid = kmemdup(edidp, imxpd->edid_len, GFP_KERNEL);
215
216 ret = of_property_read_string(np, "interface-pix-fmt", &fmt);
217 if (!ret) {
218 if (!strcmp(fmt, "rgb24"))
219 bus_format = MEDIA_BUS_FMT_RGB888_1X24;
220 else if (!strcmp(fmt, "rgb565"))
221 bus_format = MEDIA_BUS_FMT_RGB565_1X16;
222 else if (!strcmp(fmt, "bgr666"))
223 bus_format = MEDIA_BUS_FMT_RGB666_1X18;
224 else if (!strcmp(fmt, "lvds666"))
225 bus_format = MEDIA_BUS_FMT_RGB666_1X24_CPADHI;
226 }
227 imxpd->bus_format = bus_format;
228
229 /* port@1 is the output port */
230 ep = of_graph_get_endpoint_by_regs(np, 1, -1);
231 if (ep) {
232 struct device_node *remote;
233
234 remote = of_graph_get_remote_port_parent(ep);
235 of_node_put(ep);
236 if (remote) {
237 imxpd->panel = of_drm_find_panel(remote);
238 of_node_put(remote);
239 }
240 if (!imxpd->panel)
241 return -EPROBE_DEFER;
242 }
243
244 imxpd->dev = dev;
245
246 ret = imx_pd_register(drm, imxpd);
247 if (ret)
248 return ret;
249
250 dev_set_drvdata(dev, imxpd);
251
252 return 0;
253 }
254
255 static void imx_pd_unbind(struct device *dev, struct device *master,
256 void *data)
257 {
258 struct imx_parallel_display *imxpd = dev_get_drvdata(dev);
259
260 imxpd->encoder.funcs->destroy(&imxpd->encoder);
261 imxpd->connector.funcs->destroy(&imxpd->connector);
262
263 kfree(imxpd->edid);
264 }
265
266 static const struct component_ops imx_pd_ops = {
267 .bind = imx_pd_bind,
268 .unbind = imx_pd_unbind,
269 };
270
271 static int imx_pd_probe(struct platform_device *pdev)
272 {
273 return component_add(&pdev->dev, &imx_pd_ops);
274 }
275
276 static int imx_pd_remove(struct platform_device *pdev)
277 {
278 component_del(&pdev->dev, &imx_pd_ops);
279
280 return 0;
281 }
282
283 static const struct of_device_id imx_pd_dt_ids[] = {
284 { .compatible = "fsl,imx-parallel-display", },
285 { /* sentinel */ }
286 };
287 MODULE_DEVICE_TABLE(of, imx_pd_dt_ids);
288
289 static struct platform_driver imx_pd_driver = {
290 .probe = imx_pd_probe,
291 .remove = imx_pd_remove,
292 .driver = {
293 .of_match_table = imx_pd_dt_ids,
294 .name = "imx-parallel-display",
295 },
296 };
297
298 module_platform_driver(imx_pd_driver);
299
300 MODULE_DESCRIPTION("i.MX parallel display driver");
301 MODULE_AUTHOR("Sascha Hauer, Pengutronix");
302 MODULE_LICENSE("GPL");
303 MODULE_ALIAS("platform:imx-parallel-display");
This page took 0.037501 seconds and 6 git commands to generate.