99c9db003394603dd37e0ca13bae4100cfa01aca
[deliverable/linux.git] / drivers / target / target_core_file.c
1 /*******************************************************************************
2 * Filename: target_core_file.c
3 *
4 * This file contains the Storage Engine <-> FILEIO transport specific functions
5 *
6 * Copyright (c) 2005 PyX Technologies, Inc.
7 * Copyright (c) 2005-2006 SBE, Inc. All Rights Reserved.
8 * Copyright (c) 2007-2010 Rising Tide Systems
9 * Copyright (c) 2008-2010 Linux-iSCSI.org
10 *
11 * Nicholas A. Bellinger <nab@kernel.org>
12 *
13 * This program is free software; you can redistribute it and/or modify
14 * it under the terms of the GNU General Public License as published by
15 * the Free Software Foundation; either version 2 of the License, or
16 * (at your option) any later version.
17 *
18 * This program is distributed in the hope that it will be useful,
19 * but WITHOUT ANY WARRANTY; without even the implied warranty of
20 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 * GNU General Public License for more details.
22 *
23 * You should have received a copy of the GNU General Public License
24 * along with this program; if not, write to the Free Software
25 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
26 *
27 ******************************************************************************/
28
29 #include <linux/string.h>
30 #include <linux/parser.h>
31 #include <linux/timer.h>
32 #include <linux/blkdev.h>
33 #include <linux/slab.h>
34 #include <linux/spinlock.h>
35 #include <scsi/scsi.h>
36 #include <scsi/scsi_host.h>
37
38 #include <target/target_core_base.h>
39 #include <target/target_core_device.h>
40 #include <target/target_core_transport.h>
41
42 #include "target_core_file.h"
43
44 static struct se_subsystem_api fileio_template;
45
46 /* fd_attach_hba(): (Part of se_subsystem_api_t template)
47 *
48 *
49 */
50 static int fd_attach_hba(struct se_hba *hba, u32 host_id)
51 {
52 struct fd_host *fd_host;
53
54 fd_host = kzalloc(sizeof(struct fd_host), GFP_KERNEL);
55 if (!fd_host) {
56 pr_err("Unable to allocate memory for struct fd_host\n");
57 return -ENOMEM;
58 }
59
60 fd_host->fd_host_id = host_id;
61
62 hba->hba_ptr = fd_host;
63
64 pr_debug("CORE_HBA[%d] - TCM FILEIO HBA Driver %s on Generic"
65 " Target Core Stack %s\n", hba->hba_id, FD_VERSION,
66 TARGET_CORE_MOD_VERSION);
67 pr_debug("CORE_HBA[%d] - Attached FILEIO HBA: %u to Generic"
68 " MaxSectors: %u\n",
69 hba->hba_id, fd_host->fd_host_id, FD_MAX_SECTORS);
70
71 return 0;
72 }
73
74 static void fd_detach_hba(struct se_hba *hba)
75 {
76 struct fd_host *fd_host = hba->hba_ptr;
77
78 pr_debug("CORE_HBA[%d] - Detached FILEIO HBA: %u from Generic"
79 " Target Core\n", hba->hba_id, fd_host->fd_host_id);
80
81 kfree(fd_host);
82 hba->hba_ptr = NULL;
83 }
84
85 static void *fd_allocate_virtdevice(struct se_hba *hba, const char *name)
86 {
87 struct fd_dev *fd_dev;
88 struct fd_host *fd_host = (struct fd_host *) hba->hba_ptr;
89
90 fd_dev = kzalloc(sizeof(struct fd_dev), GFP_KERNEL);
91 if (!fd_dev) {
92 pr_err("Unable to allocate memory for struct fd_dev\n");
93 return NULL;
94 }
95
96 fd_dev->fd_host = fd_host;
97
98 pr_debug("FILEIO: Allocated fd_dev for %p\n", name);
99
100 return fd_dev;
101 }
102
103 /* fd_create_virtdevice(): (Part of se_subsystem_api_t template)
104 *
105 *
106 */
107 static struct se_device *fd_create_virtdevice(
108 struct se_hba *hba,
109 struct se_subsystem_dev *se_dev,
110 void *p)
111 {
112 char *dev_p = NULL;
113 struct se_device *dev;
114 struct se_dev_limits dev_limits;
115 struct queue_limits *limits;
116 struct fd_dev *fd_dev = (struct fd_dev *) p;
117 struct fd_host *fd_host = (struct fd_host *) hba->hba_ptr;
118 mm_segment_t old_fs;
119 struct file *file;
120 struct inode *inode = NULL;
121 int dev_flags = 0, flags, ret = -EINVAL;
122
123 memset(&dev_limits, 0, sizeof(struct se_dev_limits));
124
125 old_fs = get_fs();
126 set_fs(get_ds());
127 dev_p = getname(fd_dev->fd_dev_name);
128 set_fs(old_fs);
129
130 if (IS_ERR(dev_p)) {
131 pr_err("getname(%s) failed: %lu\n",
132 fd_dev->fd_dev_name, IS_ERR(dev_p));
133 ret = PTR_ERR(dev_p);
134 goto fail;
135 }
136 #if 0
137 if (di->no_create_file)
138 flags = O_RDWR | O_LARGEFILE;
139 else
140 flags = O_RDWR | O_CREAT | O_LARGEFILE;
141 #else
142 flags = O_RDWR | O_CREAT | O_LARGEFILE;
143 #endif
144 /* flags |= O_DIRECT; */
145 /*
146 * If fd_buffered_io=1 has not been set explicitly (the default),
147 * use O_SYNC to force FILEIO writes to disk.
148 */
149 if (!(fd_dev->fbd_flags & FDBD_USE_BUFFERED_IO))
150 flags |= O_SYNC;
151
152 file = filp_open(dev_p, flags, 0600);
153 if (IS_ERR(file)) {
154 pr_err("filp_open(%s) failed\n", dev_p);
155 ret = PTR_ERR(file);
156 goto fail;
157 }
158 if (!file || !file->f_dentry) {
159 pr_err("filp_open(%s) failed\n", dev_p);
160 goto fail;
161 }
162 fd_dev->fd_file = file;
163 /*
164 * If using a block backend with this struct file, we extract
165 * fd_dev->fd_[block,dev]_size from struct block_device.
166 *
167 * Otherwise, we use the passed fd_size= from configfs
168 */
169 inode = file->f_mapping->host;
170 if (S_ISBLK(inode->i_mode)) {
171 struct request_queue *q;
172 /*
173 * Setup the local scope queue_limits from struct request_queue->limits
174 * to pass into transport_add_device_to_core_hba() as struct se_dev_limits.
175 */
176 q = bdev_get_queue(inode->i_bdev);
177 limits = &dev_limits.limits;
178 limits->logical_block_size = bdev_logical_block_size(inode->i_bdev);
179 limits->max_hw_sectors = queue_max_hw_sectors(q);
180 limits->max_sectors = queue_max_sectors(q);
181 /*
182 * Determine the number of bytes from i_size_read() minus
183 * one (1) logical sector from underlying struct block_device
184 */
185 fd_dev->fd_block_size = bdev_logical_block_size(inode->i_bdev);
186 fd_dev->fd_dev_size = (i_size_read(file->f_mapping->host) -
187 fd_dev->fd_block_size);
188
189 pr_debug("FILEIO: Using size: %llu bytes from struct"
190 " block_device blocks: %llu logical_block_size: %d\n",
191 fd_dev->fd_dev_size,
192 div_u64(fd_dev->fd_dev_size, fd_dev->fd_block_size),
193 fd_dev->fd_block_size);
194 } else {
195 if (!(fd_dev->fbd_flags & FBDF_HAS_SIZE)) {
196 pr_err("FILEIO: Missing fd_dev_size="
197 " parameter, and no backing struct"
198 " block_device\n");
199 goto fail;
200 }
201
202 limits = &dev_limits.limits;
203 limits->logical_block_size = FD_BLOCKSIZE;
204 limits->max_hw_sectors = FD_MAX_SECTORS;
205 limits->max_sectors = FD_MAX_SECTORS;
206 fd_dev->fd_block_size = FD_BLOCKSIZE;
207 }
208
209 dev_limits.hw_queue_depth = FD_MAX_DEVICE_QUEUE_DEPTH;
210 dev_limits.queue_depth = FD_DEVICE_QUEUE_DEPTH;
211
212 dev = transport_add_device_to_core_hba(hba, &fileio_template,
213 se_dev, dev_flags, fd_dev,
214 &dev_limits, "FILEIO", FD_VERSION);
215 if (!dev)
216 goto fail;
217
218 fd_dev->fd_dev_id = fd_host->fd_host_dev_id_count++;
219 fd_dev->fd_queue_depth = dev->queue_depth;
220
221 pr_debug("CORE_FILE[%u] - Added TCM FILEIO Device ID: %u at %s,"
222 " %llu total bytes\n", fd_host->fd_host_id, fd_dev->fd_dev_id,
223 fd_dev->fd_dev_name, fd_dev->fd_dev_size);
224
225 putname(dev_p);
226 return dev;
227 fail:
228 if (fd_dev->fd_file) {
229 filp_close(fd_dev->fd_file, NULL);
230 fd_dev->fd_file = NULL;
231 }
232 putname(dev_p);
233 return ERR_PTR(ret);
234 }
235
236 /* fd_free_device(): (Part of se_subsystem_api_t template)
237 *
238 *
239 */
240 static void fd_free_device(void *p)
241 {
242 struct fd_dev *fd_dev = (struct fd_dev *) p;
243
244 if (fd_dev->fd_file) {
245 filp_close(fd_dev->fd_file, NULL);
246 fd_dev->fd_file = NULL;
247 }
248
249 kfree(fd_dev);
250 }
251
252 static inline struct fd_request *FILE_REQ(struct se_task *task)
253 {
254 return container_of(task, struct fd_request, fd_task);
255 }
256
257
258 static struct se_task *
259 fd_alloc_task(unsigned char *cdb)
260 {
261 struct fd_request *fd_req;
262
263 fd_req = kzalloc(sizeof(struct fd_request), GFP_KERNEL);
264 if (!fd_req) {
265 pr_err("Unable to allocate struct fd_request\n");
266 return NULL;
267 }
268
269 return &fd_req->fd_task;
270 }
271
272 static int fd_do_readv(struct se_task *task)
273 {
274 struct fd_request *req = FILE_REQ(task);
275 struct fd_dev *dev = req->fd_task.se_dev->dev_ptr;
276 struct file *fd = dev->fd_file;
277 struct scatterlist *sg = task->task_sg;
278 struct iovec *iov;
279 mm_segment_t old_fs;
280 loff_t pos = (task->task_lba *
281 task->se_dev->se_sub_dev->se_dev_attrib.block_size);
282 int ret = 0, i;
283
284 iov = kzalloc(sizeof(struct iovec) * task->task_sg_nents, GFP_KERNEL);
285 if (!iov) {
286 pr_err("Unable to allocate fd_do_readv iov[]\n");
287 return -ENOMEM;
288 }
289
290 for (i = 0; i < task->task_sg_nents; i++) {
291 iov[i].iov_len = sg[i].length;
292 iov[i].iov_base = sg_virt(&sg[i]);
293 }
294
295 old_fs = get_fs();
296 set_fs(get_ds());
297 ret = vfs_readv(fd, &iov[0], task->task_sg_nents, &pos);
298 set_fs(old_fs);
299
300 kfree(iov);
301 /*
302 * Return zeros and GOOD status even if the READ did not return
303 * the expected virt_size for struct file w/o a backing struct
304 * block_device.
305 */
306 if (S_ISBLK(fd->f_dentry->d_inode->i_mode)) {
307 if (ret < 0 || ret != task->task_size) {
308 pr_err("vfs_readv() returned %d,"
309 " expecting %d for S_ISBLK\n", ret,
310 (int)task->task_size);
311 return (ret < 0 ? ret : -EINVAL);
312 }
313 } else {
314 if (ret < 0) {
315 pr_err("vfs_readv() returned %d for non"
316 " S_ISBLK\n", ret);
317 return ret;
318 }
319 }
320
321 return 1;
322 }
323
324 static int fd_do_writev(struct se_task *task)
325 {
326 struct fd_request *req = FILE_REQ(task);
327 struct fd_dev *dev = req->fd_task.se_dev->dev_ptr;
328 struct file *fd = dev->fd_file;
329 struct scatterlist *sg = task->task_sg;
330 struct iovec *iov;
331 mm_segment_t old_fs;
332 loff_t pos = (task->task_lba *
333 task->se_dev->se_sub_dev->se_dev_attrib.block_size);
334 int ret, i = 0;
335
336 iov = kzalloc(sizeof(struct iovec) * task->task_sg_nents, GFP_KERNEL);
337 if (!iov) {
338 pr_err("Unable to allocate fd_do_writev iov[]\n");
339 return -ENOMEM;
340 }
341
342 for (i = 0; i < task->task_sg_nents; i++) {
343 iov[i].iov_len = sg[i].length;
344 iov[i].iov_base = sg_virt(&sg[i]);
345 }
346
347 old_fs = get_fs();
348 set_fs(get_ds());
349 ret = vfs_writev(fd, &iov[0], task->task_sg_nents, &pos);
350 set_fs(old_fs);
351
352 kfree(iov);
353
354 if (ret < 0 || ret != task->task_size) {
355 pr_err("vfs_writev() returned %d\n", ret);
356 return (ret < 0 ? ret : -EINVAL);
357 }
358
359 return 1;
360 }
361
362 static void fd_emulate_sync_cache(struct se_task *task)
363 {
364 struct se_cmd *cmd = task->task_se_cmd;
365 struct se_device *dev = cmd->se_dev;
366 struct fd_dev *fd_dev = dev->dev_ptr;
367 int immed = (cmd->t_task_cdb[1] & 0x2);
368 loff_t start, end;
369 int ret;
370
371 /*
372 * If the Immediate bit is set, queue up the GOOD response
373 * for this SYNCHRONIZE_CACHE op
374 */
375 if (immed)
376 transport_complete_sync_cache(cmd, 1);
377
378 /*
379 * Determine if we will be flushing the entire device.
380 */
381 if (cmd->t_task_lba == 0 && cmd->data_length == 0) {
382 start = 0;
383 end = LLONG_MAX;
384 } else {
385 start = cmd->t_task_lba * dev->se_sub_dev->se_dev_attrib.block_size;
386 if (cmd->data_length)
387 end = start + cmd->data_length;
388 else
389 end = LLONG_MAX;
390 }
391
392 ret = vfs_fsync_range(fd_dev->fd_file, start, end, 1);
393 if (ret != 0)
394 pr_err("FILEIO: vfs_fsync_range() failed: %d\n", ret);
395
396 if (!immed)
397 transport_complete_sync_cache(cmd, ret == 0);
398 }
399
400 /*
401 * Tell TCM Core that we are capable of WriteCache emulation for
402 * an underlying struct se_device.
403 */
404 static int fd_emulated_write_cache(struct se_device *dev)
405 {
406 return 1;
407 }
408
409 static int fd_emulated_dpo(struct se_device *dev)
410 {
411 return 0;
412 }
413 /*
414 * Tell TCM Core that we will be emulating Forced Unit Access (FUA) for WRITEs
415 * for TYPE_DISK.
416 */
417 static int fd_emulated_fua_write(struct se_device *dev)
418 {
419 return 1;
420 }
421
422 static int fd_emulated_fua_read(struct se_device *dev)
423 {
424 return 0;
425 }
426
427 /*
428 * WRITE Force Unit Access (FUA) emulation on a per struct se_task
429 * LBA range basis..
430 */
431 static void fd_emulate_write_fua(struct se_cmd *cmd, struct se_task *task)
432 {
433 struct se_device *dev = cmd->se_dev;
434 struct fd_dev *fd_dev = dev->dev_ptr;
435 loff_t start = task->task_lba * dev->se_sub_dev->se_dev_attrib.block_size;
436 loff_t end = start + task->task_size;
437 int ret;
438
439 pr_debug("FILEIO: FUA WRITE LBA: %llu, bytes: %u\n",
440 task->task_lba, task->task_size);
441
442 ret = vfs_fsync_range(fd_dev->fd_file, start, end, 1);
443 if (ret != 0)
444 pr_err("FILEIO: vfs_fsync_range() failed: %d\n", ret);
445 }
446
447 static int fd_do_task(struct se_task *task)
448 {
449 struct se_cmd *cmd = task->task_se_cmd;
450 struct se_device *dev = cmd->se_dev;
451 int ret = 0;
452
453 /*
454 * Call vectorized fileio functions to map struct scatterlist
455 * physical memory addresses to struct iovec virtual memory.
456 */
457 if (task->task_data_direction == DMA_FROM_DEVICE) {
458 ret = fd_do_readv(task);
459 } else {
460 ret = fd_do_writev(task);
461
462 if (ret > 0 &&
463 dev->se_sub_dev->se_dev_attrib.emulate_write_cache > 0 &&
464 dev->se_sub_dev->se_dev_attrib.emulate_fua_write > 0 &&
465 cmd->t_tasks_fua) {
466 /*
467 * We might need to be a bit smarter here
468 * and return some sense data to let the initiator
469 * know the FUA WRITE cache sync failed..?
470 */
471 fd_emulate_write_fua(cmd, task);
472 }
473
474 }
475
476 if (ret < 0)
477 return ret;
478 if (ret) {
479 task->task_scsi_status = GOOD;
480 transport_complete_task(task, 1);
481 }
482 return PYX_TRANSPORT_SENT_TO_TRANSPORT;
483 }
484
485 /* fd_free_task(): (Part of se_subsystem_api_t template)
486 *
487 *
488 */
489 static void fd_free_task(struct se_task *task)
490 {
491 struct fd_request *req = FILE_REQ(task);
492
493 kfree(req);
494 }
495
496 enum {
497 Opt_fd_dev_name, Opt_fd_dev_size, Opt_fd_buffered_io, Opt_err
498 };
499
500 static match_table_t tokens = {
501 {Opt_fd_dev_name, "fd_dev_name=%s"},
502 {Opt_fd_dev_size, "fd_dev_size=%s"},
503 {Opt_fd_buffered_io, "fd_buffered_io=%d"},
504 {Opt_err, NULL}
505 };
506
507 static ssize_t fd_set_configfs_dev_params(
508 struct se_hba *hba,
509 struct se_subsystem_dev *se_dev,
510 const char *page, ssize_t count)
511 {
512 struct fd_dev *fd_dev = se_dev->se_dev_su_ptr;
513 char *orig, *ptr, *arg_p, *opts;
514 substring_t args[MAX_OPT_ARGS];
515 int ret = 0, arg, token;
516
517 opts = kstrdup(page, GFP_KERNEL);
518 if (!opts)
519 return -ENOMEM;
520
521 orig = opts;
522
523 while ((ptr = strsep(&opts, ",")) != NULL) {
524 if (!*ptr)
525 continue;
526
527 token = match_token(ptr, tokens, args);
528 switch (token) {
529 case Opt_fd_dev_name:
530 arg_p = match_strdup(&args[0]);
531 if (!arg_p) {
532 ret = -ENOMEM;
533 break;
534 }
535 snprintf(fd_dev->fd_dev_name, FD_MAX_DEV_NAME,
536 "%s", arg_p);
537 kfree(arg_p);
538 pr_debug("FILEIO: Referencing Path: %s\n",
539 fd_dev->fd_dev_name);
540 fd_dev->fbd_flags |= FBDF_HAS_PATH;
541 break;
542 case Opt_fd_dev_size:
543 arg_p = match_strdup(&args[0]);
544 if (!arg_p) {
545 ret = -ENOMEM;
546 break;
547 }
548 ret = strict_strtoull(arg_p, 0, &fd_dev->fd_dev_size);
549 kfree(arg_p);
550 if (ret < 0) {
551 pr_err("strict_strtoull() failed for"
552 " fd_dev_size=\n");
553 goto out;
554 }
555 pr_debug("FILEIO: Referencing Size: %llu"
556 " bytes\n", fd_dev->fd_dev_size);
557 fd_dev->fbd_flags |= FBDF_HAS_SIZE;
558 break;
559 case Opt_fd_buffered_io:
560 match_int(args, &arg);
561 if (arg != 1) {
562 pr_err("bogus fd_buffered_io=%d value\n", arg);
563 ret = -EINVAL;
564 goto out;
565 }
566
567 pr_debug("FILEIO: Using buffered I/O"
568 " operations for struct fd_dev\n");
569
570 fd_dev->fbd_flags |= FDBD_USE_BUFFERED_IO;
571 break;
572 default:
573 break;
574 }
575 }
576
577 out:
578 kfree(orig);
579 return (!ret) ? count : ret;
580 }
581
582 static ssize_t fd_check_configfs_dev_params(struct se_hba *hba, struct se_subsystem_dev *se_dev)
583 {
584 struct fd_dev *fd_dev = (struct fd_dev *) se_dev->se_dev_su_ptr;
585
586 if (!(fd_dev->fbd_flags & FBDF_HAS_PATH)) {
587 pr_err("Missing fd_dev_name=\n");
588 return -EINVAL;
589 }
590
591 return 0;
592 }
593
594 static ssize_t fd_show_configfs_dev_params(
595 struct se_hba *hba,
596 struct se_subsystem_dev *se_dev,
597 char *b)
598 {
599 struct fd_dev *fd_dev = se_dev->se_dev_su_ptr;
600 ssize_t bl = 0;
601
602 bl = sprintf(b + bl, "TCM FILEIO ID: %u", fd_dev->fd_dev_id);
603 bl += sprintf(b + bl, " File: %s Size: %llu Mode: %s\n",
604 fd_dev->fd_dev_name, fd_dev->fd_dev_size,
605 (fd_dev->fbd_flags & FDBD_USE_BUFFERED_IO) ?
606 "Buffered" : "Synchronous");
607 return bl;
608 }
609
610 /* fd_get_cdb(): (Part of se_subsystem_api_t template)
611 *
612 *
613 */
614 static unsigned char *fd_get_cdb(struct se_task *task)
615 {
616 struct fd_request *req = FILE_REQ(task);
617
618 return req->fd_scsi_cdb;
619 }
620
621 /* fd_get_device_rev(): (Part of se_subsystem_api_t template)
622 *
623 *
624 */
625 static u32 fd_get_device_rev(struct se_device *dev)
626 {
627 return SCSI_SPC_2; /* Returns SPC-3 in Initiator Data */
628 }
629
630 /* fd_get_device_type(): (Part of se_subsystem_api_t template)
631 *
632 *
633 */
634 static u32 fd_get_device_type(struct se_device *dev)
635 {
636 return TYPE_DISK;
637 }
638
639 static sector_t fd_get_blocks(struct se_device *dev)
640 {
641 struct fd_dev *fd_dev = dev->dev_ptr;
642 unsigned long long blocks_long = div_u64(fd_dev->fd_dev_size,
643 dev->se_sub_dev->se_dev_attrib.block_size);
644
645 return blocks_long;
646 }
647
648 static struct se_subsystem_api fileio_template = {
649 .name = "fileio",
650 .owner = THIS_MODULE,
651 .transport_type = TRANSPORT_PLUGIN_VHBA_PDEV,
652 .attach_hba = fd_attach_hba,
653 .detach_hba = fd_detach_hba,
654 .allocate_virtdevice = fd_allocate_virtdevice,
655 .create_virtdevice = fd_create_virtdevice,
656 .free_device = fd_free_device,
657 .dpo_emulated = fd_emulated_dpo,
658 .fua_write_emulated = fd_emulated_fua_write,
659 .fua_read_emulated = fd_emulated_fua_read,
660 .write_cache_emulated = fd_emulated_write_cache,
661 .alloc_task = fd_alloc_task,
662 .do_task = fd_do_task,
663 .do_sync_cache = fd_emulate_sync_cache,
664 .free_task = fd_free_task,
665 .check_configfs_dev_params = fd_check_configfs_dev_params,
666 .set_configfs_dev_params = fd_set_configfs_dev_params,
667 .show_configfs_dev_params = fd_show_configfs_dev_params,
668 .get_cdb = fd_get_cdb,
669 .get_device_rev = fd_get_device_rev,
670 .get_device_type = fd_get_device_type,
671 .get_blocks = fd_get_blocks,
672 };
673
674 static int __init fileio_module_init(void)
675 {
676 return transport_subsystem_register(&fileio_template);
677 }
678
679 static void fileio_module_exit(void)
680 {
681 transport_subsystem_release(&fileio_template);
682 }
683
684 MODULE_DESCRIPTION("TCM FILEIO subsystem plugin");
685 MODULE_AUTHOR("nab@Linux-iSCSI.org");
686 MODULE_LICENSE("GPL");
687
688 module_init(fileio_module_init);
689 module_exit(fileio_module_exit);
This page took 0.073264 seconds and 4 git commands to generate.