gdb/ChangeLog

   1 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
   4         (build_minimal_symbol_hash_tables): Code to clear the table moved
   5         to clear_minimal_symbol_hash_tables.
   6         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
   7         when needed.
   8
   9 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  10
  11         * infcmd.c: Remove includes.
  12         * infrun.c: Remove includes.
  13
  14 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  15
  16         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
  17         (grow_vect): Remove declaration.
  18         (ada_type_of_array): Remove declaration.
  19         (ada_update_initial_language): Remove declaration.
  20         (ada_fold_name): Remove declaration.
  21         (ada_fill_in_ada_prototype): Remove declaration.
  22         (user_select_syms): Remove declaration.
  23         (get_selections): Remove declaration.
  24         (ada_tag_type): Remove declaration.
  25         (ada_value_tag): Remove declaration.
  26         (ada_is_others_clause): Remove declaration.
  27         (ada_in_variant): Remove declaration.
  28         (ada_value_struct_elt): Remove declaration.
  29         (ada_attribute_name): Remove declaration.
  30         (ada_system_address_type): Remove declaration.
  31         * ada-lang.c (ada_watch_location_expression): Make static.
  32         (GROW_VECT): Move here from ada-lang.h.
  33         (grow_vect): Make static.
  34         (ada_update_initial_language): Make static.
  35         (ada_fold_name): Make static.
  36         (ada_type_of_array): Make static.
  37         (encoded_ordered_before): Move up.
  38         (sort_choices): Move up.
  39         (print_signatures): Move up.
  40         (ada_print_symbol_signature): Move up.
  41         (get_selections): Move up and make static.
  42         (user_select_syms): Move up and make static.
  43         (ada_value_struct_elt): Move up and make static.
  44         (ada_tag_type): Make static.
  45         (ada_value_tag): Make static.
  46         (ada_is_others_clause): Make static.
  47         (ada_in_variant): Make static.
  48         (ada_attribute_name): Make static.
  49
  50 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  51
  52         * ada-lang.c: Remove includes.
  53         * ada-typeprint.c: Remove includes.
  54         * ada-valprint.c: Remove includes.
  55
  56 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
  57
  58         * addrmap.c: Add static assertions of type size, moved from
  59         _initialize_addrmap.
  60         (_initialize_addrmap): Remove.
  61
  62 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  63
  64         * coffread.c (record_minimal_symbol): Update.
  65         (process_coff_symbol): Update.
  66         * dbxread.c (read_dbx_symtab): Update.
  67         * dwarf2read.c (add_partial_symbol): Update.
  68         (fixup_go_packaging): Update.
  69         (load_partial_dies): Update.
  70         (new_symbol): Update.
  71         * elfread.c (record_minimal_symbol): Change signature to use
  72         gdb::string_view instead of name+len.
  73         (elf_symtab_read): Update.
  74         (elf_rel_plt_read): Update.
  75         * mdebugread.c (parse_partial_symbols): Update.
  76         (handle_psymbol_enumerators): Update.
  77         (new_symbol): Update.
  78         * minsyms.c (minimal_symbol_reader::record_full): Change signature
  79         to use gdb::string_view instead of name+len.
  80         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
  81         * psympriv.h (add_psymbol_to_list): Likewise.
  82         * psymtab.c (add_psymbol_to_bcache): Likewise.
  83         (add_psymbol_to_list): Likewise.
  84         * stabsread.c (define_symbol): Update.
  85         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
  86         * symtab.h (SYMBOL_SET_NAMES): Likewise.
  87         (symbol_set_names): Likewise.
  88         * xcoffread.c (scan_xcoff_symtab): Update.
  89
  90 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  91
  92         * symtab.h (symbol_set_names): Document that copy_name must be
  93         set to true for non-nullterminated strings.
  94         * symtab.c (symbol_set_names): Only make a nullterminated copy of
  95         linkage_name if the entry was not found and we need to demangle.
  96
  97 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 100         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 101         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 102         * gdbsupport/gdb_binary_search.h: New file.
 103
 104 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 105
 106         * NEWS: Mention new --with-system-gdbinit-dir option.
 107         * config.in: Regenerate.
 108         * configure: Regenerate.
 109         * configure.ac: Add new option --with-system-gdbinit-dir.
 110         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 111         for a ".gdb" suffix.
 112         * main.c (get_init_files): Change system_gdbinit argument to
 113         a vector and return the files in SYSTEM_GDBINIT_DIR in
 114         addition to SYSTEM_GDBINIT.
 115         (captured_main_1): Update.
 116         (print_gdb_help): Update.
 117         * top.c (print_gdb_configuration): Also print the value of
 118         SYSTEM_GDBINIT_DIR.
 119
 120 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 121
 122         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 123         that takes gdb::string_view arguments.
 124
 125 2019-10-26  Tom de Vries  <tdevries@suse.de>
 126
 127         * aarch64-linux-tdep.c: Fix typos in comments.
 128         * aarch64-tdep.c: Same.
 129         * ada-lang.c: Same.
 130         * amd64-nat.c: Same.
 131         * arc-tdep.c: Same.
 132         * arch/aarch64-insn.c: Same.
 133         * block.c: Same.
 134         * breakpoint.h: Same.
 135         * btrace.h: Same.
 136         * c-varobj.c: Same.
 137         * cli/cli-decode.c: Same.
 138         * cli/cli-script.c: Same.
 139         * cli/cli-utils.h: Same.
 140         * coff-pe-read.c: Same.
 141         * coffread.c: Same.
 142         * compile/compile-cplus-symbols.c: Same.
 143         * compile/compile-object-run.c: Same.
 144         * completer.c: Same.
 145         * corelow.c: Same.
 146         * cp-support.c: Same.
 147         * demangle.c: Same.
 148         * dwarf-index-write.c: Same.
 149         * dwarf2-frame.c: Same.
 150         * dwarf2-frame.h: Same.
 151         * eval.c: Same.
 152         * frame-base.h: Same.
 153         * frame.h: Same.
 154         * gdbcmd.h: Same.
 155         * gdbtypes.h: Same.
 156         * gnu-nat.c: Same.
 157         * guile/scm-objfile.c: Same.
 158         * i386-tdep.c: Same.
 159         * i386-tdep.h: Same.
 160         * infcall.c: Same.
 161         * infcall.h: Same.
 162         * linux-nat.c: Same.
 163         * m68k-tdep.c: Same.
 164         * macroexp.c: Same.
 165         * memattr.c: Same.
 166         * mi/mi-cmd-disas.c: Same.
 167         * mi/mi-getopt.h: Same.
 168         * mi/mi-main.c: Same.
 169         * minsyms.c: Same.
 170         * nat/aarch64-sve-linux-sigcontext.h: Same.
 171         * objfiles.h: Same.
 172         * ppc-linux-nat.c: Same.
 173         * ppc-linux-tdep.c: Same.
 174         * ppc-tdep.h: Same.
 175         * progspace.h: Same.
 176         * prologue-value.h: Same.
 177         * python/py-evtregistry.c: Same.
 178         * python/py-instruction.h: Same.
 179         * record-btrace.c: Same.
 180         * record-full.c: Same.
 181         * remote.c: Same.
 182         * rs6000-tdep.c: Same.
 183         * ser-tcp.c: Same.
 184         * sol-thread.c: Same.
 185         * sparc-sol2-tdep.c: Same.
 186         * sparc64-tdep.c: Same.
 187         * stabsread.c: Same.
 188         * symfile.c: Same.
 189         * symtab.h: Same.
 190         * target.c: Same.
 191         * tracepoint.c: Same.
 192         * tui/tui-data.h: Same.
 193         * tui/tui-io.c: Same.
 194         * tui/tui-win.c: Same.
 195         * tui/tui.c: Same.
 196         * unittests/rsp-low-selftests.c: Same.
 197         * user-regs.h: Same.
 198         * utils.c: Same.
 199         * utils.h: Same.
 200         * valarith.c: Same.
 201         * valops.c: Same.
 202         * valprint.c: Same.
 203         * valprint.h: Same.
 204         * value.c: Same.
 205         * value.h: Same.
 206         * varobj.c: Same.
 207         * x86-nat.h: Same.
 208         * xtensa-tdep.c: Same.
 209
 210 2019-10-25  Ali Tamur <tamur@google.com>
 211
 212         * charset.c (find_charset_names): Reflect API change.
 213
 214 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 215
 216         * symtab.c (struct demangled_name_entry): Change demangled name
 217         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 218         part of the struct anymore.
 219         (symbol_set_names): No longer obstack allocate + copy the demangled
 220         name, just store the allocated name from bfd.
 221
 222 2019-10-25  Tom Tromey  <tromey@adacore.com>
 223
 224         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 225         (bsearch_cie_cmp, add_cie): Remove.
 226         (find_cie): Reimplement.
 227         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 228         (dwarf2_build_frame_info): Update.
 229
 230 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 231
 232         PR gdb/25126
 233         * symfile.c (reread_symbols): Call forget_cached_source_info to
 234         clear the stale source cache.
 235
 236 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 237
 238         * configure: Regenerate.
 239         * configure.ac: Remove code that sets python_has_threads.
 240
 241 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 242
 243         * config.in: Regenerate.
 244         * configure: Regenerate.
 245         * configure.ac: Remove the code that uses sed to get the python
 246         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 247
 248 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 249
 250         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 251         error paths.
 252
 253 2019-10-23  Tom Tromey  <tom@tromey.com>
 254
 255         * arc-tdep.c: Remove ".." from include.
 256         * frv-tdep.c: Remove ".." from include.
 257         * lm32-tdep.c: Remove ".." from include.
 258         * microblaze-tdep.c: Remove ".." from include.
 259         * or1k-tdep.h: Remove ".." from include.
 260         * s12z-tdep.c: Remove ".." from include.
 261         * Makefile.in (OPCODES_CFLAGS): Add comment.
 262         (TOP_CFLAGS): New variable.
 263         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 264
 265 2019-10-23  Tom Tromey  <tom@tromey.com>
 266
 267         * Makefile.in (READLINE_DIR): Update.
 268
 269 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 270
 271         * infcall.c (call_function_by_hand_dummy): Fix the function
 272         comment.  And extract out a code section into...
 273         (reserve_stack_space): ...this new function.
 274
 275 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 276
 277         * infcall.c (value_arg_coerce): Remove an unused parameter.
 278         (call_function_by_hand_dummy): Update the call to
 279         'value_arg_coerce'.
 280
 281 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 282
 283         * infcall.c (call_function_by_hand_dummy): Refactor.
 284
 285 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 286
 287         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 288
 289 2019-10-23  Tom Tromey  <tom@tromey.com>
 290
 291         * configure: Rebuild.
 292         * configure.ac: Don't check for sigprocmask.
 293         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 294
 295 2019-10-23  Tom Tromey  <tom@tromey.com>
 296
 297         * configure: Rebuild.
 298         * acinclude.m4: Use m4_include, not sinclude.
 299
 300 2019-10-23  Tom de Vries  <tdevries@suse.de>
 301
 302         PR breakpoints/24687
 303         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 304
 305 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 306
 307         * symtab.c (struct demangled_name_entry) <language>: Change from
 308         bitfield to regular variable.
 309
 310 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 311
 312         * symtab.c (struct demangled_name_entry): Add a constructor.
 313         (free_demangled_name_entry): New function to call the destructor
 314         for demangled_name_entry.
 315         (create_demangled_names_hash): Pass free_demangled_name_entry to
 316         htab_create_alloc.
 317         (symbol_set_names): Call placement new for demangled_name_entry.
 318         * utils.c: No longer include xxhash.h here, now that fast_hash
 319         is inlined in the header.
 320         * utils.h: Instead, include it here.
 321
 322 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 323
 324         * Makefile.in: Link with libxxhash.
 325         * config.in: Regenerate.
 326         * configure: Regenerate.
 327         * configure.ac: Search for libxxhash.
 328         * utils.c (fast_hash): Use xxhash if present.
 329
 330 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 331
 332         * utils.h (fast_hash): New function.
 333         * symtab.c (hash_demangled_name_entry): Call new function
 334         fast_hash.
 335
 336 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 337
 338         * symtab.c (struct demangled_name_entry): Change type of mangled
 339         to gdb::string_view. Also adds a constructor that takes the
 340         mangled name.
 341         (hash_demangled_name_entry): Update.
 342         (eq_demangled_name_entry): Update.
 343         (free_demangled_name_entry): New function to call the destructor
 344         now that this is not a POD anymore.
 345         (create_demangled_names_hash): Pass free_demangled_name_entry to
 346         htab_create_alloc.
 347         (symbol_set_names): Update.
 348
 349 2019-10-21  Ali Tamur  <tamu@google.com>
 350
 351         * dwarf2read.c (dir_index): Change type.
 352         (file_name_index): Likewise.
 353         (line_header::include_dir_at): Change comment and implementation on
 354         whether it is DWARF 5.
 355         (line_header::is_valid_file_index): New function.
 356         (line_header::file_name_at): Change comment and implementation on
 357         whether it is DWARF 5.
 358         (line_header::file_names): Change to private field renamed as
 359         m_file_names and introduce a new accessor method.
 360         (line_header::file_names_size): New method.
 361         (line_header::include_dirs): Change to private field and rename as
 362         m_include_dirs.
 363         (dw2_get_file_names_reader): Define local var at a smaller scope and
 364         reflect API change.
 365         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 366         (process_structure_scope): Likewise.
 367         (line_header::add_include_dir): Change message and reflect renaming.
 368         (line_header::add_file_name): Likewise.
 369         (read_formatted_entries): Handle DW_FORM_data16.
 370         (dwarf_decode_line_header): Fix line header length calculation.
 371         (psymtab_include_file_name): Change comment and API.
 372         (lnp_state_machine::m_file): Update comment and reflect type change.
 373         (lnp_state_machine::record_line): Reflect type change.
 374         (dwarf_decode_lines): Reflect API change.
 375         (file_file_name): Likewise.
 376         (file_full_name): Likewise.
 377
 378 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 379
 380         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 381
 382 2019-10-21  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 385
 386 2019-10-21  Tom Tromey  <tom@tromey.com>
 387
 388         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 389         NM_H.   Use AC_CONFIG_LINKS.
 390         * configure: Rebuild.
 391         * Makefile.in (NM_H): New variable.
 392         (generated_files): Add NM_H.  Remove gcore.
 393         (nm.h, stamp-nmh): New targets.
 394
 395 2019-10-20  Tom Tromey  <tom@tromey.com>
 396
 397         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 398         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 399         obsolete comment.
 400         (put_objfile_before): Now static.
 401
 402 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 403
 404         * gdbsupport/common-utils.h (startswith): Change return type to
 405         bool.
 406
 407 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 408
 409         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 410         * breakpoint.c (bp_locations_compare): Rename to...
 411         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 412         (update_global_location_list): Use std::sort instead of qsort.
 413         * buildsym.c (compare_line_numbers): Rename to...
 414         (lte_is_less_than): ...this, and change to std::sort semantics.
 415         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 416         instead of qsort.
 417         * disasm.c (compare_lines): Rename to...
 418         (line_is_less_than): ...this, and change to std::sort semantics.
 419         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 420         of qsort.
 421         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 422         (fde_is_less_than): ...this, and change to std::sort semantics.
 423         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 424         * mdebugread.c (compare_blocks):
 425         (block_is_less_than): ...this, and change to std::sort semantics.
 426         (sort_blocks): Call std::sort instead of qsort.
 427         * objfiles.c (qsort_cmp): Rename to...
 428         (sort_cmp): ...this, and change to std::sort semantics.
 429         (update_section_map): Call std::sort instead of qsort.
 430         * remote.c (compare_pnums): Remove.
 431         (map_regcache_remote_table): Call std::sort instead of qsort.
 432         * utils.c (compare_positive_ints): Remove.
 433         * utils.h (compare_positive_ints): Remove.
 434         * xcoffread.c (compare_lte): Remove.
 435         (arrange_linetable): Call std::sort instead of qsort.
 436
 437 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 438
 439         * symfile.c (init_entry_point_info): Fix typo.
 440         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 441
 442 2019-10-18  Tom de Vries  <tdevries@suse.de>
 443
 444         * aarch64-tdep.c: Fix typos in comments.
 445         * ada-lang.c: Same.
 446         * ada-tasks.c: Same.
 447         * alpha-tdep.c: Same.
 448         * alpha-tdep.h: Same.
 449         * amd64-nat.c: Same.
 450         * amd64-windows-tdep.c: Same.
 451         * arc-tdep.c: Same.
 452         * arc-tdep.h: Same.
 453         * arch-utils.c: Same.
 454         * arm-nbsd-tdep.c: Same.
 455         * arm-tdep.c: Same.
 456         * ax-gdb.c: Same.
 457         * blockframe.c: Same.
 458         * btrace.c: Same.
 459         * c-varobj.c: Same.
 460         * coff-pe-read.c: Same.
 461         * coffread.c: Same.
 462         * cris-tdep.c: Same.
 463         * darwin-nat.c: Same.
 464         * dbxread.c: Same.
 465         * dcache.c: Same.
 466         * disasm.c: Same.
 467         * dtrace-probe.c: Same.
 468         * dwarf-index-write.c: Same.
 469         * dwarf2-frame-tailcall.c: Same.
 470         * dwarf2-frame.c: Same.
 471         * dwarf2read.c: Same.
 472         * eval.c: Same.
 473         * exceptions.c: Same.
 474         * fbsd-tdep.c: Same.
 475         * findvar.c: Same.
 476         * frame.c: Same.
 477         * frv-tdep.c: Same.
 478         * gnu-v3-abi.c: Same.
 479         * go32-nat.c: Same.
 480         * h8300-tdep.c: Same.
 481         * hppa-tdep.c: Same.
 482         * i386-linux-tdep.c: Same.
 483         * i386-tdep.c: Same.
 484         * ia64-libunwind-tdep.c: Same.
 485         * ia64-tdep.c: Same.
 486         * infcmd.c: Same.
 487         * infrun.c: Same.
 488         * linespec.c: Same.
 489         * linux-nat.c: Same.
 490         * linux-thread-db.c: Same.
 491         * machoread.c: Same.
 492         * mdebugread.c: Same.
 493         * mep-tdep.c: Same.
 494         * mn10300-tdep.c: Same.
 495         * namespace.c: Same.
 496         * objfiles.c: Same.
 497         * opencl-lang.c: Same.
 498         * or1k-tdep.c: Same.
 499         * osabi.c: Same.
 500         * ppc-linux-nat.c: Same.
 501         * ppc-linux-tdep.c: Same.
 502         * ppc-sysv-tdep.c: Same.
 503         * printcmd.c: Same.
 504         * procfs.c: Same.
 505         * record-btrace.c: Same.
 506         * record-full.c: Same.
 507         * remote-fileio.c: Same.
 508         * remote.c: Same.
 509         * rs6000-tdep.c: Same.
 510         * s12z-tdep.c: Same.
 511         * score-tdep.c: Same.
 512         * ser-base.c: Same.
 513         * ser-go32.c: Same.
 514         * skip.c: Same.
 515         * sol-thread.c: Same.
 516         * solib-svr4.c: Same.
 517         * solib.c: Same.
 518         * source.c: Same.
 519         * sparc-nat.c: Same.
 520         * sparc-sol2-tdep.c: Same.
 521         * sparc-tdep.c: Same.
 522         * sparc64-tdep.c: Same.
 523         * stabsread.c: Same.
 524         * stack.c: Same.
 525         * symfile.c: Same.
 526         * symtab.c: Same.
 527         * target-descriptions.c: Same.
 528         * target-float.c: Same.
 529         * thread.c: Same.
 530         * utils.c: Same.
 531         * valops.c: Same.
 532         * valprint.c: Same.
 533         * value.c: Same.
 534         * varobj.c: Same.
 535         * windows-nat.c: Same.
 536         * xcoffread.c: Same.
 537         * xstormy16-tdep.c: Same.
 538         * xtensa-tdep.c: Same.
 539
 540 2019-10-17  Tom Tromey  <tromey@adacore.com>
 541
 542         * configure: Rebuild.
 543         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 544         in AC_CONFIG_FILES invocation.
 545         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 546         new-style config.status invocation.
 547
 548 2019-10-17  Tom de Vries  <tdevries@suse.de>
 549
 550         * arm-nbsd-nat.c: Fix typos in comments.
 551         * arm-tdep.c: Same.
 552         * darwin-nat-info.c: Same.
 553         * dwarf2read.c: Same.
 554         * elfread.c: Same.
 555         * event-top.c: Same.
 556         * findvar.c: Same.
 557         * gdbtypes.c: Same.
 558         * hppa-tdep.c: Same.
 559         * i386-tdep.c: Same.
 560         * jit.c: Same.
 561         * main.c: Same.
 562         * mdebugread.c: Same.
 563         * moxie-tdep.c: Same.
 564         * nto-procfs.c: Same.
 565         * osabi.c: Same.
 566         * ppc-linux-tdep.c: Same.
 567         * remote.c: Same.
 568         * riscv-tdep.c: Same.
 569         * s390-tdep.c: Same.
 570         * sh-tdep.c: Same.
 571         * sparc-linux-tdep.c: Same.
 572         * sparc-nat.c: Same.
 573         * stack.c: Same.
 574         * target-descriptions.c: Same.
 575         * top.c: Same.
 576         * varobj.c: Same.
 577
 578 2019-10-16  Tom Tromey  <tom@tromey.com>
 579
 580         * objfiles.h (struct objfile) <original_name>: Now const.
 581
 582 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 583
 584         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 585         pass on to sigsetjmp's second argument.
 586         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 587
 588 2019-10-16  Keith Seitz  <keiths@redhat.com>
 589
 590         PR gdb/23567
 591         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 592         sections whose size is greater than the file size.
 593
 594 2019-10-16  Jim Wilson  <jimw@sifive.com>
 595
 596         * riscv-tdep.c (riscv_gcc_target_options): New.
 597         (riscv_gnu_triplet_regexp): New.
 598         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 599         set_gdbarch_gnu_triplet_regexp.
 600
 601 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 602
 603         * Makefile.in: Add xml-builtin.h.
 604         * features/feature_to_c.sh: Add an include for xml-builtin.h
 605         to ensure that the compiler checks that the types match.
 606         * xml-builtin.h: New file.
 607         * xml-support.c (fetch_xml_builtin): Add missing const.
 608         * xml-support.h: Remove declaration of xml_builtins.
 609
 610 2019-10-16  Tom de Vries  <tdevries@suse.de>
 611
 612         PR tdep/25096
 613         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 614         (amd64_classify_aggregate): ... here.
 615         (amd64_classify_aggregate_field): Handled fiels of nested structs
 616         recursively.
 617
 618 2019-10-16  Tom de Vries  <tdevries@suse.de>
 619
 620         PR tdep/24104
 621         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 622         that handles 'theclass'.
 623
 624 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * linespec.c (decode_digits_ordinary): Update comment.
 627         * make-target-delegates: No longer need to handle VEC case.
 628         * memrange.c (normalize_mem_ranges): Update comment.
 629         * namespace.c (add_using_directive): Update comment.
 630         * objc-lang.c (uniquify_strings): Update comment.
 631         * ppc-linux-nat.c (struct thread_points): Update comment.
 632         * probe.h (find_probes_in_objfile): Update comment.
 633         * target.h (enum flash_preserve_mode): Update comment.
 634         * varobj.c (varobj_restrict_range): Update comment.
 635         * varobj.h (varobj_list_children): Update comment.
 636
 637 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * Makefile.in: Remove references to vec.h and vec.c.
 640         * aarch64-tdep.c: No longer include vec.h.
 641         * ada-lang.c: Likewise.
 642         * ada-lang.h: Likewise.
 643         * arm-tdep.c: Likewise.
 644         * ax.h: Likewise.
 645         * breakpoint.h: Likewise.
 646         * charset.c: Likewise.
 647         * cp-support.h: Likewise.
 648         * dtrace-probe.c: Likewise.
 649         * dwarf2read.c: Likewise.
 650         * extension.h: Likewise.
 651         * gdb_bfd.c: Likewise.
 652         * gdbsupport/gdb_vecs.h: Likewise.
 653         * gdbsupport/vec.c: Remove.
 654         * gdbsupport/vec.h: Remove.
 655         * gdbthread.h: Likewise.
 656         * guile/scm-type.c: Likewise.
 657         * inline-frame.c: Likewise.
 658         * machoread.c: Likewise.
 659         * memattr.c: Likewise.
 660         * memrange.h: Likewise.
 661         * namespace.h: Likewise.
 662         * nat/linux-btrace.h: Likewise.
 663         * osdata.c: Likewise.
 664         * parser-defs.h: Likewise.
 665         * progspace.h: Likewise.
 666         * python/py-type.c: Likewise.
 667         * record-btrace.c: Likewise.
 668         * rust-exp.y: Likewise.
 669         * solib-target.c: Likewise.
 670         * stap-probe.c: Likewise.
 671         * target-descriptions.c: Likewise.
 672         * target-memory.c: Likewise.
 673         * target.h: Likewise.
 674         * varobj.c: Likewise.
 675         * varobj.h: Likewise.
 676         * xml-support.h: Likewise.
 677
 678 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 679
 680         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 681         Update for new std::vector based implementation.
 682         (process_psymtab_comp_unit_reader): Likewise.
 683         (scan_partial_symbols): Likewise.
 684         (recursively_compute_inclusions): Likewise.
 685         (compute_compunit_symtab_includes): Likewise.
 686         (process_imported_unit_die): Likewise.
 687         (queue_and_load_dwo_tu): Likewise.
 688         (follow_die_sig_1): Likewise.
 689         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 690         (typedef dwarf2_per_cu_ptr): Remove.
 691         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 692         function.
 693         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 694         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 695         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 696         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 697         std::vector.
 698
 699 2019-10-15  Tom Tromey  <tromey@adacore.com>
 700
 701         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 702         TID.
 703
 704 2019-10-15  Tom Tromey  <tromey@adacore.com>
 705
 706         * windows-nat.c (windows_nat_target::fetch_registers)
 707         (windows_nat_target::store_registers): Rename "pid" to "tid".
 708
 709 2019-10-15  Tom Tromey  <tromey@adacore.com>
 710
 711         * gdbarch.h, gdbarch.c: Rebuild.
 712         * gdbarch.sh (gcc_target_options): Change return type to
 713         std::string.
 714         * compile/compile.c (get_args): Update.
 715         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 716         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 717         std::string.
 718         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 719         std::string.
 720         * arch-utils.c (default_gcc_target_options): Return std::string.
 721         * arch-utils.h (default_gcc_target_options): Return std::string.
 722         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 723
 724 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 725
 726         * breakpoint.c (breakpoint_chain): Make static.
 727         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 728         of accessing breakpoint_chain.
 729
 730 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 731
 732         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 733         to a gdb::function_view and return value to bool.
 734         * breakpoint.h (iterate_over_breakpoints): Likewise.
 735         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 736         (pop_dummy_frame): Update.
 737         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 738         (gdbscm_breakpoints): Update.
 739         * python/py-breakpoint.c (build_bp_list): Update.
 740         (gdbpy_breakpoints): Update.
 741         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 742         Update.
 743         (bpfinishpy_handle_stop): Update.
 744         (bpfinishpy_handle_exit): Update.
 745         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 746         (svr4_update_solib_event_breakpoints): Update.
 747
 748 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 749
 750         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 751         when unwrapping single-field structs.
 752
 753 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 754
 755         * dwarf2read.c: Remove includes.
 756
 757 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 758
 759         * ui-out.c (ui_out::call_do_message): Silence
 760         -Wformat-nonliteral warning.
 761
 762 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 763
 764         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 765         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 766         include: readline/tilde.h.
 767
 768 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 769
 770         * remote.c (remote_target::get_trace_status): Remove declaration of
 771         trace_regblock_size.
 772
 773 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 774
 775         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 776         (show_user): Remove declaration of cmdlist.
 777         * cli/cli-cmds.h (max_user_call_depth): Declare.
 778         * cli/cli-script.c (execute_user_command): Remove declaration
 779         of max_user_call_depth.
 780
 781 2019-10-11  Jim Wilson  <jimw@sifive.com>
 782
 783         * gdbsupport/print-utils.h (pulongest): Fix comment.
 784         (plongest): Likewise.
 785         (phex): Add missing comment, mention leading zeros.
 786         (phex_nz): Add mention of no leading zeros to comment.
 787
 788         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 789         plongest instead of unsigned long long cast.
 790
 791 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 792
 793         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 794         for external_editor_command and gdbtk_test.
 795
 796 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 797
 798         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 799         * varobj.c (varobjdebug): Move comment to...
 800         * varobj.h (varobjdebug): ...here, and declare.
 801
 802 2019-10-09  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 805         erase_data_content.
 806
 807 2019-10-09  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 810         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 811         * tui/tui-command.c (tui_cmd_window::resize)
 812         (tui_refresh_cmd_win): Update.
 813         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 814         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 815         * tui/tui-data.c (~tui_gen_win_info): Remove.
 816         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 817         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 818         (tui_redisplay_readline, tui_mld_flush)
 819         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 820         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 821         (tui_data_window::erase_data_content)
 822         (tui_data_item_window::rerender)
 823         (tui_data_item_window::refresh_window): Update.
 824         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 825         (box_win, tui_gen_win_info::make_window)
 826         (tui_gen_win_info::make_visible): Update.
 827         (tui_delete_win): Remove.
 828         * tui/tui-winsource.c
 829         (tui_source_window_base::do_erase_source_content): Update.
 830         (tui_show_source_line, tui_source_window_base::update_tab_width)
 831         (tui_source_window_base::update_exec_info): Update.
 832         * tui/tui-data.h (struct curses_deleter): New.
 833         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 834         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 835
 836 2019-10-09  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 839
 840 2019-10-09  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 843         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 844
 845 2019-10-09  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 848         window height directly.
 849         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 850         declare.
 851         * tui/tui-layout.c (tui_default_win_height): Remove.
 852         (tui_default_win_viewport_height): Remove.
 853
 854 2019-10-09  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui.h: Remove comments.
 857
 858 2019-10-09  Tom de Vries  <tdevries@suse.de>
 859
 860         * python/lib/gdb/printer/bound_registers.py: Use
 861         '^builtin_type_bound128' as regexp argument for
 862         add_builtin_pretty_printer.
 863
 864 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 865
 866         * guile/guile.c (guile_extension_script_ops): Remove forward
 867         declaration and mark as static.
 868         (guile_script_ops): Likewise.
 869         (extension_language_guile): Move further down in the file so
 870         it can reference the definitions for guile_{extension_,}script_ops.
 871
 872 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 873
 874         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 875         except SORTL, DFLTCC, and KDSA.
 876
 877 2019-10-08  Tom Tromey  <tromey@adacore.com>
 878
 879         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 880         (struct safe_symbol_file_add_args): Remove.
 881
 882 2019-10-08  Tom Tromey  <tromey@adacore.com>
 883
 884         * windows-nat.c: Don't include buildsym-legacy.h.
 885
 886 2019-10-08  Tom Tromey  <tromey@adacore.com>
 887
 888         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 889
 890 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 891
 892         * gdbtypes.c (overload_debug): Move comment to header.
 893         * gdbtypes.h (overload_debug): Declare.
 894         * valops.c: Remove declaration of overload_debug, instead
 895         include gdbtypes.h.
 896
 897 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 898
 899         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 900         through _().
 901         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 902         move comment...
 903         * language.h (lang_frame_mismatch_warn): ... here. Also add
 904         declaration.
 905         * top.c (lang_frame_mismatch_warn): Remove declaration.
 906         (check_frame_language_change): Pass lang_frame_mismatch_warn
 907         through _().
 908
 909 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 910
 911         * c-lang.h (vtbl_ptr_name): Declare.
 912         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 913         it from the header.
 914         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 915
 916 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 917
 918         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 919         gdb_static_assert.
 920
 921 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 922
 923         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 924         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 925         * ctfread.c: New file.
 926         * ctfread.h: New file.
 927         * elfread.c: Include ctfread.h.
 928         (struct elfinfo text_p): New member ctfsect.
 929         (elf_locate_sections): Mark CTF section.
 930         (elf_symfile_read): Call elfctf_build_psymtabs.
 931         * Makefile.in (LIBCTF): Add.
 932         (CLIBS): Use it.
 933         (CDEPS): Likewise.
 934         (DIST): Add ctfread.c.
 935
 936 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 937
 938         * ctfread.c (struct nextfield): Renamed to ...
 939         (struct ctf_nextfield): ... this.
 940         (struct field_info): Renamed to ...
 941         (strut ctf_field_info): ... this.
 942         (attach_fields_to_type): Update for renamed structures.
 943         (ctf_add_member_cb): Likewise.
 944         (ctf_add_enum_member_cb): Likewise.
 945         (process_struct_members): Likewise.
 946         (process_enum_type): Likewise.
 947
 948 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 949
 950         * tracectf.h: Rename, was ctf.h.
 951         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 952         * tracefile.c: Likewise.
 953         * tracepoint.c: Remove unused include ctf.h.
 954         * mi/mi-main.c: Likewise.
 955         * Makefile.in Replace ctf.c with tracectf.c.
 956
 957 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 958
 959         * version.in: Change version number to "9.0.50.DATE-git".
 960
 961 2019-10-03  Tom Tromey  <tom@tromey.com>
 962
 963         PR rust/24976:
 964         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 965
 966 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 967
 968         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 969         cp_search_name_hash.
 970         * NEWS: Add entry about nested function support.
 971
 972 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 973             Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 976         for nested static variables when searchin VAR_DOMAIN.
 977         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 978         global scope, update comment.
 979         (add_partial_subprogram): Call add_partial_subprogram recursively
 980         for nested subroutines when processinng Fortran.
 981         (load_partial_dies): Process the child entities of a subprogram
 982         when processing Fortran.
 983         (partial_die_parent_scope): Handle building scope
 984         for Fortran nested functions.
 985         (process_die): Record that nested functions have a scope.
 986         (new_symbol): Always record Fortran subprograms on the global
 987         symbol list.
 988         (determine_prefix): How to build the prefix for Fortran
 989         subprograms.
 990
 991 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 992
 993         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 994         have just sent the thread a SIGSTOP and are waiting for it to
 995         arrive.
 996
 997 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 998
 999         * btrace.c (btrace_add_pc): Remove whitespace before the template
1000         parameter in 'std::vector <...>'.
1001         (parse_xml_btrace_block): Likewise.
1002         (btrace_maint_decode_pt): Likewise.
1003         (btrace_maint_update_packets): Likewise.
1004         (btrace_maint_print_packets): Likewise.
1005         * btrace.h (struct btrace_maint_info): Likewise.
1006         * dwarf2read.c (struct type_unit_group): Likewise.
1007         (build_type_psymtabs_reader): Likewise.
1008         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1009         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1010         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1011
1012 2019-10-03  Tom de Vries  <tdevries@suse.de>
1013
1014         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1015         the first line of the help text for set/show style metadata.
1016
1017 2019-10-02  Tom Tromey  <tromey@adacore.com>
1018
1019         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1020         * gdbsupport/common-inferior.c: New file.
1021         * infcmd.c (startup_with_shell): Don't define.
1022         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1023         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1024         * inferior.h (startup_with_shell): Don't declare.
1025
1026 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1027
1028         * gdbsupport/gdb_assert.h: Include errors.h.
1029         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1030
1031 2019-10-02  Tom Tromey  <tromey@adacore.com>
1032
1033         * NEWS: Add $_ada_exception entry.
1034         * ada-lang.c (struct ada_catchpoint): Add constructor.
1035         <m_kind>: New member.
1036         (allocate_location_exception, re_set_exception): Remove
1037         "ex" parameter.
1038         (should_stop_exception): Compute $_ada_exception.
1039         (check_status_exception, print_it_exception)
1040         (print_one_exception, print_mention_exception): Remove
1041         "ex" parameter.
1042         (allocate_location_catch_exception, re_set_catch_exception)
1043         (check_status_exception, print_it_catch_exception)
1044         (print_one_catch_exception, print_mention_catch_exception)
1045         (print_recreate_catch_exception)
1046         (allocate_location_catch_exception_unhandled)
1047         (re_set_catch_exception_unhandled)
1048         (check_status_exception, print_it_catch_exception_unhandled)
1049         (print_one_catch_exception_unhandled)
1050         (print_mention_catch_exception_unhandled)
1051         (print_recreate_catch_exception_unhandled)
1052         (allocate_location_catch_assert, re_set_catch_assert)
1053         (check_status_assert, print_it_catch_assert)
1054         (print_one_catch_assert, print_mention_catch_assert)
1055         (print_recreate_catch_assert)
1056         (allocate_location_catch_handlers, re_set_catch_handlers)
1057         (check_status_handlers, print_it_catch_handlers)
1058         (print_one_catch_handlers, print_mention_catch_handlers)
1059         (print_recreate_catch_handlers): Remove.
1060         (create_ada_exception_catchpoint): Update.
1061         (initialize_ada_catchpoint_ops): Update.
1062
1063 2019-10-02  Tom Tromey  <tromey@adacore.com>
1064
1065         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1066         (create_excep_cond_exprs): Simplify exception string computation.
1067         (ada_exception_catchpoint_cond_string): Likewise.
1068
1069 2019-10-02  Tom Tromey  <tromey@adacore.com>
1070
1071         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1072         * ada-lang.c (lesseq_defined_than): Handle
1073         LOC_STATIC.
1074         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1075         parameter.
1076         (dwarf2_has_info): Likewise.
1077         (new_symbol): Set maybe_copied on symbol when
1078         appropriate.
1079         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1080         parameter.
1081         <can_copy>: New member.
1082         * elfread.c (record_minimal_symbol): Set maybe_copied
1083         on symbol when appropriate.
1084         (elf_symfile_read): Update call to dwarf2_has_info.
1085         * minsyms.c (lookup_minimal_symbol_linkage): New
1086         function.
1087         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1088         * symtab.c (get_symbol_address, get_msymbol_address):
1089         New functions.
1090         * symtab.h (get_symbol_address, get_msymbol_address):
1091         Declare.
1092         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1093         maybe_copied.
1094         (struct symbol, struct minimal_symbol) <maybe_copied>:
1095         New member.
1096
1097 2019-10-02  Tom Tromey  <tromey@adacore.com>
1098
1099         * source.c (struct current_source_location): New.
1100         (current_source_key): New global.
1101         (current_source_symtab, current_source_line)
1102         (current_source_pspace): Remove.
1103         (get_source_location): New function.
1104         (get_current_source_symtab_and_line)
1105         (set_default_source_symtab_and_line)
1106         (set_current_source_symtab_and_line)
1107         (clear_current_source_symtab_and_line, select_source_symtab)
1108         (info_source_command, print_source_lines_base)
1109         (info_line_command, search_command_helper, _initialize_source):
1110         Update.
1111
1112 2019-10-02  Tom Tromey  <tromey@adacore.com>
1113
1114         * source.c (select_source_symtab): Don't call
1115         decode_line_with_current_source.
1116
1117 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1118
1119         * symtab.c (lookup_global_symbol): Search global block.
1120
1121 2019-10-02  Tom Tromey  <tromey@adacore.com>
1122
1123         * coffread.c (process_coff_symbol): Update.
1124         * dwarf2read.c (var_decode_location, new_symbol): Update.
1125         * mdebugread.c (parse_symbol): Update.
1126         * objfiles.c (relocate_one_symbol): Update.
1127         * stabsread.c (define_symbol, fix_common_block)
1128         (scan_file_globals): Update.
1129         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1130         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1131         * xcoffread.c (process_xcoff_symbol): Update.
1132
1133 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1134
1135         * MAINTAINERS: Update my email address.
1136
1137 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1140         std::vector.
1141         (build_type_psymtabs_reader): Update for std::vector.
1142         (build_type_psymtab_dependencies): Likewise.
1143         * dwarf2read.h: Remove use of DEF_VEC_P.
1144         (typedef sig_type_ptr): Delete.
1145
1146 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1149         to std::vector.
1150         (btrace_maint_decode_pt): Likewise, and move allocation of the
1151         vector outside of the loop.
1152         (btrace_maint_update_packets): Update to handle change from VEC to
1153         std::vector.
1154         (btrace_maint_print_packets): Likewise.
1155         (maint_info_btrace_cmd): Likewise.
1156         * btrace.h: Remove use of DEF_VEC_O.
1157         (typedef btrace_pt_packet_s): Delete.
1158         (struct btrace_maint_info) <packets>: Change fromm VEC to
1159         std::vector.
1160         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1161
1162 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1165         make accesses into the vector constant references.
1166         (btrace_add_pc): Update for std::vector.
1167         (btrace_stitch_bts): Likewise.
1168         (parse_xml_btrace_block): Likewise.
1169         (btrace_maint_update_packets): Likewise.
1170         (btrace_maint_print_packets): Likewise.
1171         (maint_info_btrace_cmd): Likewise.
1172         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1173         std::vector.
1174         (btrace_data::empty): Likewise.
1175         (btrace_data_append): Likewise.
1176         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1177         (typedef btrace_block_s): Delete.
1178         (struct btrace_block): Add constructor.
1179         (struct btrace_data_bts) <blocks>: Change to std::vector.
1180         * nat/linux-btrace.c (perf_event_read_bts): Update for
1181         std::vector.
1182         (linux_read_bts): Likewise.
1183
1184 2019-10-01  Tom Tromey  <tom@tromey.com>
1185
1186         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1187
1188 2019-10-01  Tom Tromey  <tom@tromey.com>
1189
1190         * stack.c (print_frame, info_frame_command_core): Use
1191         styled_string.
1192         * linux-thread-db.c (try_thread_db_load_1)
1193         (try_thread_db_load_from_pdir_1): Use styled_string.
1194         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1195         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1196         (maybe_print_unsupported_script_warning)
1197         (maybe_print_script_not_found_warning): Use styled_string.
1198         * ada-lang.c (user_select_syms): Use styled_string.
1199
1200 2019-10-01  Tom Tromey  <tom@tromey.com>
1201
1202         * p-lang.c (pascal_printstr): Use metadata style.
1203         * value.c (show_convenience): Use metadata style.
1204         * valprint.c (valprint_check_validity, val_print_optimized_out)
1205         (val_print_not_saved, val_print_unavailable)
1206         (val_print_invalid_address, generic_val_print, val_print)
1207         (value_check_printable, val_print_array_elements): Use metadata
1208         style.
1209         * ui-out.h (class ui_out) <field_fmt>: New overload.
1210         <do_field_fmt>: Add style parameter.
1211         * ui-out.c (ui_out::field_fmt): New overload.
1212         * typeprint.c (type_print_unknown_return_type)
1213         (val_print_not_allocated, val_print_not_associated): Use metadata
1214         style.
1215         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1216         parameter.
1217         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1218         * tracepoint.c (tvariables_info_1): Use metadata style.
1219         * stack.c (print_frame_arg, print_frame_info, print_frame)
1220         (info_frame_command_core): Use metadata style.
1221         * skip.c (info_skip_command): Use metadata style.
1222         * rust-lang.c (rust_print_enum): Use metadata style.
1223         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1224         metadata style.
1225         * python/py-framefilter.c (py_print_single_arg): Use metadata
1226         style.
1227         * printcmd.c (do_one_display, print_variable_and_value): Use
1228         metadata style.
1229         * p-valprint.c (pascal_val_print)
1230         (pascal_object_print_value_fields): Use metadata style.
1231         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1232         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1233         parameter.
1234         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1235         * m2-valprint.c (m2_print_long_set): Use metadata style.
1236         * m2-typeprint.c (m2_print_type): Use metadata style.
1237         * infcmd.c (print_return_value_1): Use metadata style.
1238         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1239         * f-valprint.c (info_common_command_for_block): Use metadata
1240         style.
1241         * f-typeprint.c (f_type_print_base): Use metadata style.
1242         * expprint.c (print_subexp_standard): Use metadata style.
1243         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1244         * cli/cli-style.h (class cli_style_option): Add constructor.
1245         (metadata_style): Declare.
1246         * cli/cli-style.c (metadata_style): New global.
1247         (_initialize_cli_style): Register metadata style.
1248         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1249         parameter.
1250         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1251         * c-typeprint.c (c_type_print_base_struct_union)
1252         (c_type_print_base_1): Use metadata style.
1253         * breakpoint.c (watchpoint_value_print)
1254         (print_one_breakpoint_location): Use metadata style.
1255         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1256         style.
1257         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1258         style.
1259         * ada-valprint.c (val_print_packed_array_elements, printstr)
1260         (print_field_values, ada_val_print_ref, ada_val_print): Use
1261         metadata style.
1262         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1263         style.
1264         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1265         style.
1266         * ada-lang.c (user_select_syms): Use metadata style.
1267
1268 2019-10-01  Tom Tromey  <tom@tromey.com>
1269
1270         * cli/cli-cmds.c (pwd_command): Style output.
1271
1272 2019-10-01  Pedro Alves  <palves@redhat.com>
1273             Tom Tromey  <tom@tromey.com>
1274
1275         * symtab.c (print_symbol_info): Use %ps.
1276         (print_msymbol_info): Use %ps.
1277         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1278         * printcmd.c (print_variable_and_value): Use %ps.
1279         * macrocmd.c (show_pp_source_pos): Use %ps.
1280         * infrun.c (print_exited_reason): Use ui_out::message.
1281         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1282         (describe_other_breakpoints): Use ui_out::message and new
1283         formats.
1284         (say_where): Use new formats.
1285         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1286         and new formats.
1287
1288 2019-10-01  Pedro Alves  <palves@redhat.com>
1289             Tom Tromey  <tom@tromey.com>
1290
1291         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1292         (test_gdb_formats): New function.
1293         (run_tests): Call it.
1294         (test_format_specifier): Update.
1295         * utils.h (fputs_filtered): Update comment.
1296         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1297         (fputs_styled_unfiltered): Declare.
1298         * utils.c (fputs_styled_unfiltered): New function.
1299         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1300         (vfprintf_filtered): Update.
1301         (vfprintf_unfiltered, vprintf_filtered): Update.
1302         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1303         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1304         disallow_ui_out_field>: New constants.
1305         (enum class field_kind): New.
1306         (struct base_field_s, struct signed_field_s): New.
1307         (signed_field): New function.
1308         (struct string_field_s): New.
1309         (string_field): New function.
1310         (struct styled_string_s): New.
1311         (styled_string): New function.
1312         (class ui_out) <message>: Add comment.
1313         <vmessage, call_do_message>: New methods.
1314         <do_message>: Add style parameter.
1315         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1316         methods.
1317         (ui_out::message): Rewrite.
1318         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1319         parameter.
1320         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1321         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1322         gdb_extensions parameter.
1323         (class format_piece): Add parameter to constructor.
1324         (n_int_args): New field.
1325         * gdbsupport/format.c (format_pieces::format_pieces): Add
1326         gdb_extensions parameter.  Handle '*'.
1327         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1328         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1329         vfprintf_styled_no_gdbfmt.
1330         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1331         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1332         unfiltered output.
1333         * ui-style.h (struct ui_file_style) <ptr>: New method.
1334
1335 2019-10-01  Tom Tromey  <tom@tromey.com>
1336
1337         * unittests/format_pieces-selftests.c: Update.  Add final format.
1338         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1339         empty literal pieces.
1340
1341 2019-10-01  Tom Tromey  <tom@tromey.com>
1342
1343         * ui-out.h (enum class ui_out_style_kind): Remove.
1344         (class ui_out) <field_string, field_stsream, do_field_string>:
1345         Change type of "style".
1346         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1347         (ui_out::field_string): Update.
1348         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1349         of "style".
1350         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1351         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1352         * stack.c (print_frame_arg, print_frame_info, print_frame):
1353         Update.
1354         * source.c (print_source_lines_base): Update.
1355         * solib.c (info_sharedlibrary_command): Update.
1356         * skip.c (info_skip_command): Update.
1357         * record-btrace.c (btrace_call_history_src_line)
1358         (btrace_call_history): Update.
1359         * python/py-framefilter.c (py_print_frame): Update.
1360         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1361         "style".
1362         * mi/mi-out.c (mi_ui_out::do_table_header)
1363         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1364         (mi_ui_out::do_field_string): Update.
1365         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1366         Update.
1367         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1368         "style".
1369         * cli-out.c (cli_ui_out::do_table_header)
1370         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1371         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1372         (cli_ui_out::do_field_fmt): Update.
1373         * breakpoint.c (print_breakpoint_location): Update.
1374         (update_static_tracepoint): Update.
1375
1376 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1377
1378         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1379         conversion of gdb_datadir.
1380         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1381         remove not needed c_str ().
1382
1383 2019-09-30  Ali Tamur <tamur@google.com>
1384
1385         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1386         (dwarf2_string_attr): Likewise.
1387
1388 2019-09-30  Ali Tamur <tamur@google.com>
1389
1390         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1391         (process_full_type_unit): Likewise.
1392         (dump_die_shallow): Likewise.
1393         (cu_debug_loc_section): Likewise.
1394
1395 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1396
1397         * minsyms.c (compare_minimal_symbols): Rename to...
1398         (minimal_symbol_is_less_than): ...this, and adjust to STL
1399         conventions (return bool, take arguments as references)
1400         (minimal_symbol_reader::install): Call std::sort instead
1401         of qsort.
1402
1403 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1404
1405         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1406         hash and why.
1407         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1408         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1409
1410 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1411
1412         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1413         * psympriv.h (add_psymbol_to_list): Move comment here and update
1414         it.
1415
1416 2019-09-29  Tom de Vries  <tdevries@suse.de>
1417
1418         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1419         Use $tmpdir/$(basename "$output_file").dwz instead of
1420         "${output_file}.dwz".
1421
1422 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1423
1424         PR gdb/25045
1425         * hppa-linux-nat.c: Include gdbarch.h.
1426
1427 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1428
1429         * blockframe.c (find_pc_partial_function): Change return type to bool.
1430         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1431         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1432         (stub_gnu_ifunc_resolve_name): Likewise.
1433         * symtab.c (compare_filenames_for_search): Likewise.
1434         (compare_glob_filenames_for_search): Likewise.
1435         (matching_obj_sections): Likewise.
1436         (symbol_matches_domain): Likewise.
1437         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1438         (find_line_pc): Change return type to bool.
1439         (find_line_pc_range): Likewise.
1440         (producer_is_realview): Likewise.
1441         * symtab.h (symbol_matches_domain): Likewise.
1442         (find_pc_partial_function): Likewise.
1443         (find_pc_line_pc_range): Likewise.
1444         (in_gnu_ifunc_stub): Likewise.
1445         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1446         (find_line_pc): Likewise.
1447         (find_line_pc_range): Likewise.
1448         (matching_obj_sections): Likewise.
1449         (find_line_symtab): Change out parameter to bool.
1450         (producer_is_realview): Change return type to bool.
1451         (compare_filenames_for_search): Likewise.
1452         (compare_glob_filenames_for_search): Likewise.
1453
1454 2019-09-26  Tom Tromey  <tom@tromey.com>
1455
1456         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1457         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1458         * gdb_usleep.h: Remove.
1459         * gdb_usleep.c: Remove.
1460         * utils.c: Don't include gdb_usleep.h.
1461
1462 2019-09-26  Tom Tromey  <tromey@adacore.com>
1463
1464         * python/py-type.c (type_to_type_object): Call check_typedef
1465         for stub types.
1466
1467 2019-09-26  Tom Tromey  <tom@tromey.com>
1468
1469         * utils.h (initialize_utils): Don't declare.
1470         * top.c (gdb_init): Don't call initialize_utils.
1471         * utils.c (initialize_utils): Remove.  Move contents...
1472         (_initialize_utils): ... here.
1473
1474 2019-09-25  Tom Tromey  <tom@tromey.com>
1475
1476         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1477         * utils.h (make_hex_string): Don't declare.
1478         * utils.c (make_hex_string): Remove.
1479
1480 2019-09-24  Tom de Vries  <tdevries@suse.de>
1481
1482         PR gdb/23815
1483         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1484         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1485
1486 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1487
1488         * NEWS: Mention new simulator port for PRU.
1489
1490 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1491
1492         * ada-exp.y (write_object_remaining): Update.
1493         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1494         and eliminate the static buffer.
1495         (ada_decode_symbol): Update.
1496         (ada_la_decode): Update.
1497         (ada_sniff_from_mangled_name): Update.
1498         (is_valid_name_for_wild_match): Update.
1499         (ada_lookup_name_info::matches): Update and simplify.
1500         (name_matches_regex): Update.
1501         (ada_add_global_exceptions): Update.
1502         * ada-lang.h (ada_decode): Update signature.
1503         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1504         * dwarf-index-write.c (debug_names::insert): Update.
1505
1506 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1507
1508         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1509         formatting.
1510
1511 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1512
1513         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1514         Change "nonzero" to "true" in documentation.
1515
1516 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1517
1518         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1519         (_initialize_darwin_solib): Don't set
1520         darwin_so_ops.lookup_lib_global_symbol.
1521         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1522         set_gdbarch_iterate_over_objfiles_in_search_order.
1523         (elf_lookup_lib_symbol): Rename to...
1524         (svr4_iterate_over_objfiles_in_search_order): this, and update
1525         to iterate semantics.
1526         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1527         * solib.c (solib_global_lookup): Remove.
1528         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1529         (solib_global_lookup): Remove.
1530         * symtab.c (lookup_global_or_static_symbol): Remove call to
1531         solib_global_lookup.
1532
1533 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1534
1535         * NEWS: Move entries about default MI version now being
1536         version 3, and about the GDB/MI fix for multi-location
1537         breakpoints to the "since GDB 8.3" section.
1538
1539 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1540
1541         GDB 8.3.1 released.
1542
1543 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1544
1545         * NEWS: Mention that Cell/B.E. debugging support was removed.
1546         * MAINTAINERS: Remove spu target.
1547
1548         * config/djgpp/fnchange.lst: Remove entries for removed files.
1549
1550         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1551         spu-multiarch.o, and spu-tdep.o.
1552         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1553         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1554         spu-multiarch.c, and spu-tdep.c.
1555         * spu-linux-nat.c: Remove file.
1556         * spu-multiarch.c: Remove file.
1557         * spu-tdep.c: Remove file.
1558         * spu-tdep.h: Remove file.
1559         * solib-spu.c: Remove file.
1560         * solib-spu.h: Remove file.
1561
1562         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1563         * configure.nat (spu-linux): Remove.
1564         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1565         solib-multiarch.o from gdb_target_obs.
1566         (spu*-*-*): Remove.
1567
1568         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1569         feature flag.
1570         (ppc_linux_no_features): Update.
1571         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1572         Cell/B.E. support.
1573         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1574         (tdesc_powerpc_cell64l): Likewise.
1575         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1576         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1577         Cell/B.E. support.
1578         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1579         Do not include "features/rs6000/powerpc-cell32l.c" or
1580         "features/rs6000/powerpc-cell64l.c".
1581         (ppc_linux_spu_section): Remove.
1582         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1583         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1584         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1585         (ppc_linux_spe_context_lookup): Remove.
1586         (ppc_linux_spe_context_inferior_created): Remove.
1587         (ppc_linux_spe_context_solib_loaded): Remove.
1588         (ppc_linux_spe_context_solib_unloaded): Remove.
1589         (ppc_linux_spe_context): Remove.
1590         (struct ppu2spu_cache): Remove.
1591         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1592         (struct ppu2spu_data): Remove.
1593         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1594         ppu2spu_unwind): Remove.
1595         (ppc_linux_init_abi): Remove Cell/B.E. support.
1596         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1597
1598         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1599         (rs6000/powerpc-cell64l-expedite): Likewise
1600         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1601         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1602         rs6000/powerpc-cell64l.xml.
1603         * features/rs6000/powerpc-cell32l.xml: Remove.
1604         * features/rs6000/powerpc-cell64l.xml: Likewise.
1605         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1606         * features/rs6000/powerpc-cell64l.c: Likewise.
1607         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1608         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1609         * regformats/reg-spu.dat: Remove.
1610
1611         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1612         * corelow.c (struct spuid_list): Remove.
1613         (add_to_spuid_list): Remove.
1614         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1615         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1616         (remote_protocol_features): Remove associated entries.
1617         (_initialize_remote): No longer initialize them.
1618         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1619         * linux-nat.c (SPUFS_MAGIC): Remove.
1620         (linux_proc_xfer_spu): Remove.
1621         (spu_enumerate_spu_ids): Remove.
1622         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1623         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1624         (linux_make_corefile_notes): No longer call it.
1625
1626         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1627         (cooked_write_test): Likewise.
1628
1629 2019-09-20  Tom Tromey  <tom@tromey.com>
1630
1631         * NEWS: Mention case-sensitivity of TUI commands.
1632         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1633         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1634         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1635
1636 2019-09-20  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-source.c (tui_source_window::set_contents): Use
1639         make_unique_xstrdup.
1640         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1641         make_unique_xstrdup.
1642
1643 2019-09-20  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-data.c: Remove separator comments.
1646         * tui/tui-layout.c: Remove separator comments.
1647         * tui/tui-win.c: Remove separator comments.
1648         * tui/tui-wingeneral.c: Remove separator comments.
1649
1650 2019-09-20  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui.h (strcat_to_buf): Don't declare.
1653         * tui/tui.c (strcat_to_buf): Remove.
1654
1655 2019-09-20  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1658         from "fullname".
1659         * tui/tui-source.c (tui_source_window::set_contents)
1660         (tui_source_window::location_matches_p)
1661         (tui_source_window::maybe_update): Update.
1662
1663 2019-09-20  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1666         Update.
1667         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1668         prefix.
1669         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1670         (tui_data_window::line_from_reg_element_no)
1671         (tui_data_window::first_reg_element_no_inline)
1672         (tui_data_window::show_registers)
1673         (tui_data_window::show_register_group)
1674         (tui_data_window::display_registers_from)
1675         (tui_data_window::display_registers_from_line)
1676         (tui_data_window::first_data_item_displayed)
1677         (tui_data_window::delete_data_content_windows)
1678         (tui_data_window::erase_data_content)
1679         (tui_data_window::do_scroll_vertical)
1680         (tui_data_window::refresh_window)
1681         (tui_data_window::check_register_values): Update.
1682
1683 2019-09-20  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1686         (struct tui_locator_window) <full_name, proc_name>: Now
1687         std::string.
1688         * tui/tui-stack.c (tui_locator_window::make_status_line)
1689         (tui_locator_window::set_locator_fullname)
1690         (tui_locator_window::set_locator_info): Update.
1691         * tui/tui-source.c (tui_source_window::set_contents)
1692         (tui_source_window::showing_source_p): Update.
1693
1694 2019-09-20  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1697         Don't call tui_locator_win_info_ptr.
1698
1699 2019-09-20  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1702
1703 2019-09-20  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1706         height for locator.
1707         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1708         * tui/tui-layout.c (show_source_disasm_command, show_data)
1709         (show_source_or_disasm_and_command): Use 1 as height for locator.
1710
1711 2019-09-20  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui.c (tui_enable): Update.
1714         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1715         Update.
1716         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1717         Update.
1718         * tui/tui-data.c (win_resized): Now bool.
1719         (tui_win_resized): Return bool.
1720         (tui_set_win_resized_to): Accept a bool.
1721
1722 2019-09-20  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1725         Change type of "refresh_values_only".
1726         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1727         type of "refresh_values_only".
1728
1729 2019-09-20  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1732         std::string.
1733         (tui_disassemble): Add "pos" parameter.
1734         (tui_disasm_window::set_contents): Simplify.
1735
1736 2019-09-20  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-winsource.h (struct tui_source_window_base)
1739         <show_source_content>: Now private.
1740         * tui/tui-winsource.c
1741         (tui_source_window_base::show_source_content): Don't handle empty
1742         content case.
1743
1744 2019-09-20  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-layout.c (show_source_disasm_command)
1747         (show_source_or_disasm_and_command): Don't call
1748         show_source_content.
1749
1750 2019-09-20  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1753         Declare.
1754         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1755         from tui_make_status_line.
1756         (tui_locator_window::rerender): Update.
1757
1758 2019-09-20  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1761         (tui_locator_window::rerender): Update.
1762
1763 2019-09-20  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-winsource.h (struct tui_source_window_base)
1766         <~tui_source_window_base>: Don't declare.
1767         <fullname>: Remove.
1768         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1769         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1770         member.
1771         * tui/tui-source.c (tui_source_window::set_contents): Update.
1772         (tui_source_window::location_matches_p)
1773         (tui_source_window::maybe_update): Update.
1774
1775 2019-09-20  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-winsource.h (~tui_source_element): Remove.
1778         (tui_source_element): Update.
1779         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1780         * tui/tui-winsource.c (tui_show_source_line): Update.
1781         * tui/tui-source.c (tui_source_window::set_contents): Update.
1782         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1783
1784 2019-09-20  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1787         declare.
1788         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1789         tui_clear_source_windows_detail.
1790         * tui/tui-winsource.h (struct tui_source_window_base)
1791         <clear_detail>: Don't declare.
1792         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1793         Remove.
1794         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1795
1796 2019-09-20  Tom Tromey  <tromey@adacore.com>
1797
1798         PR ada/24919:
1799         * block.c (contained_in): Fix final return value.
1800
1801 2019-09-20  Alan Modra  <amodra@gmail.com>
1802
1803         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1804         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1805         (read_indirect_string_from_dwz): Use bfd accessor.
1806         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1807         * machoread.c (macho_symfile_read_all_oso): Likewise.
1808         * solib.c (solib_bfd_open): Likewise.
1809
1810 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1811
1812         * eval.c: Move declaration of overload_resolution to...
1813         * value.h: ...here.
1814
1815 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1816
1817         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1818         * arm-linux-tdep.c: Likewise.
1819         * arm-nbsd-nat.c: Likewise.
1820         * arm-tdep.h: Declare arm_apcs_32.
1821         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1822
1823 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1824
1825         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1826         * dwarf2read.h: Declare dwarf_always_disassemble.
1827
1828 2019-09-19  Tom de Vries  <tdevries@suse.de>
1829
1830         PR gdb/25009
1831         * source-cache.c (source_cache::ensure): Catch exception thrown during
1832         construction of the highlighter.
1833
1834 2019-09-18  Alan Modra  <amodra@gmail.com>
1835
1836         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1837         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1838         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1839         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1840         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1841         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1842         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1843         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1844         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1845         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1846         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1847         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1848         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1849         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1850         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1851         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1852         * mi/mi-interp.c: Update throughout for bfd section macro and
1853         function changes.
1854         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1855         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1856
1857 2019-09-18  Tom Tromey  <tom@tromey.com>
1858
1859         * NEWS: Add entry.
1860         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1861         call rl_initialize.
1862         (tui_enable): Do not call rl_initialize.
1863
1864 2019-09-18  Christian Groessler  <chris@groessler.org>
1865
1866         * alpha-linux-nat.c: Include gdbarch.h.
1867
1868 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1869
1870         * ui-file.c: Include cli/cli-style.h.
1871         (term_cli_styling): Remove cli_styling declaration.
1872
1873 2019-09-18  Alan Modra  <amodra@gmail.com>
1874
1875         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1876         to bfd_asymbol_section.
1877
1878 2019-09-18  Alan Modra  <amodra@gmail.com>
1879
1880         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1881         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1882         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1883
1884 2019-09-18  Alan Modra  <amodra@gmail.com>
1885
1886         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1887         * spu-linux-nat.c (spu_bfd_open): Likewise.
1888
1889 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1890
1891         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1892         to bool to match definition in dwarf2read.c.
1893
1894 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1895
1896         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1897         (print_signatures): Likewise.
1898         (trust_pad_over_xvs): Likewise.
1899         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1900         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1901         * arm-linux-nat.c (arm_apcs_32): Likewise.
1902         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1903         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1904         * arm-tdep.c (arm_debug): Likewise.
1905         (arm_apcs_32): Likewise.
1906         * auto-load.c (debug_auto_load): Likewise.
1907         (auto_load_gdb_scripts): Likewise.
1908         (global_auto_load): Likewise.
1909         (auto_load_local_gdbinit): Likewise.
1910         (auto_load_local_gdbinit_loaded): Likewise.
1911         * auto-load.h (global_auto_load): Likewise.
1912         (auto_load_local_gdbinit): Likewise.
1913         (auto_load_local_gdbinit_loaded): Likewise.
1914         * breakpoint.c (disconnected_dprintf): Likewise.
1915         (breakpoint_proceeded): Likewise.
1916         (automatic_hardware_breakpoints): Likewise.
1917         (always_inserted_mode): Likewise.
1918         (target_exact_watchpoints): Likewise.
1919         (_initialize_breakpoint): Update.
1920         * breakpoint.h (target_exact_watchpoints): Change to bool.
1921         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1922         * cli/cli-cmds.c (trace_commands): Likewise.
1923         * cli/cli-cmds.h (trace_commands): Likewise.
1924         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1925         to bool*.
1926         * cli/cli-logging.c (logging_overwrite): Change to bool.
1927         (logging_redirect): Likewise.
1928         (debug_redirect): Likewise.
1929         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1930         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1931         to bool.
1932         <boolean_option_def>: Update.
1933         (struct flag_option_def): Change default type of Context to bool
1934         from int.
1935         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1936         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1937         (get_setshow_command_value_string): Likewise.
1938         * cli/cli-style.c (cli_styling): Change to bool.
1939         (source_styling): Likewise.
1940         * cli/cli-style.h (source_styling): Likewise.
1941         (cli_styling): Likewise.
1942         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1943         to bool.
1944         * command.h (var_types): Update comment.
1945         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1946         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1947         bool.
1948         (debug_compile_cplus_scopes): Likewise.
1949         * compile/compile-internal.h (compile_debug): Likewise.
1950         * compile/compile.c (compile_debug): Likewise.
1951         (struct compile_options) <raw>: Likewise.
1952         * cp-support.c (catch_demangler_crashes): Likewise.
1953         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1954         (usr_cmd_cris_dwarf2_cfi): Likewise.
1955         * csky-tdep.c (csky_debug): Likewise.
1956         * darwin-nat.c (enable_mach_exceptions): Likewise.
1957         * dcache.c (dcache_enabled_p): Likewise.
1958         * defs.h (info_verbose): Likewise.
1959         * demangle.c (demangle): Likewise.
1960         (asm_demangle): Likewise.
1961         * dwarf-index-cache.c (debug_index_cache): Likewise.
1962         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1963         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1964         * dwarf2read.c (check_physname): Likewise.
1965         (use_deprecated_index_sections): Likewise.
1966         (dwarf_always_disassemble): Likewise.
1967         * eval.c (overload_resolution): Likewise.
1968         * event-top.c (set_editing_cmd_var): Likewise.
1969         (exec_done_display_p): Likewise.
1970         * event-top.h (set_editing_cmd_var): Likewise.
1971         (exec_done_display_p): Likewise.
1972         * exec.c (write_files): Likewise.
1973         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1974         (debug_fbsd_nat): Likewise.
1975         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1976         Likewise.
1977         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1978         <backtrace_past_entry> Likewise.
1979         * gdb-demangle.h (demangle): Likewise.
1980         (asm_demangle): Likewise.
1981         * gdb_bfd.c (bfd_sharing): Likewise.
1982         * gdbcore.h (write_files): Likewise.
1983         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1984         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1985         * gdbthread.h (print_thread_events): Likewise.
1986         * gdbtypes.c (opaque_type_resolution): Likewise.
1987         (strict_type_checking): Likewise.
1988         * gnu-nat.c (gnu_debug_flag): Likewise.
1989         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1990         * guile/scm-param.c (pascm_variable): Add boolval.
1991         (add_setshow_generic): Update.
1992         (pascm_param_value): Update.
1993         (pascm_set_param_value_x): Update.
1994         * hppa-tdep.c (hppa_debug): Change to bool..
1995         * infcall.c (may_call_functions_p): Likewise.
1996         (coerce_float_to_double_p): Likewise.
1997         (unwind_on_signal_p): Likewise.
1998         (unwind_on_terminating_exception_p): Likewise.
1999         * infcmd.c (startup_with_shell): Likewise.
2000         * inferior.c (print_inferior_events): Likewise.
2001         * inferior.h (startup_with_shell): Likewise.
2002         (print_inferior_events): Likewise.
2003         * infrun.c (step_stop_if_no_debug): Likewise.
2004         (detach_fork): Likewise.
2005         (debug_displaced): Likewise.
2006         (disable_randomization): Likewise.
2007         (non_stop): Likewise.
2008         (non_stop_1): Likewise.
2009         (observer_mode): Likewise.
2010         (observer_mode_1): Likewise.
2011         (set_observer_mode): Update.
2012         (sched_multi): Change to bool.
2013         * infrun.h (debug_displaced): Likewise.
2014         (sched_multi): Likewise.
2015         (step_stop_if_no_debug): Likewise.
2016         (non_stop): Likewise.
2017         (disable_randomization): Likewise.
2018         * linux-tdep.c (use_coredump_filter): Likewise.
2019         (dump_excluded_mappings): Likewise.
2020         * linux-thread-db.c (auto_load_thread_db): Likewise.
2021         (check_thread_db_on_load): Likewise.
2022         * main.c (captured_main_1): Update.
2023         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2024         xx2_opt, boolean_opt>: Change to bool.
2025         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2026         * maint.c (maintenance_profile_p): Likewise.
2027         (per_command_time): Likewise.
2028         (per_command_space): Likewise.
2029         (per_command_symtab): Likewise.
2030         * memattr.c (inaccessible_by_default): Likewise.
2031         * mi/mi-main.c (mi_async): Likewise.
2032         (mi_async_1): Likewise.
2033         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2034         * nat/fork-inferior.h (startup_with_shell): Likewise.
2035         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2036         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2037         * nios2-tdep.c (nios2_debug): Likewise.
2038         * or1k-tdep.c (or1k_debug): Likewise.
2039         * parse.c (parser_debug): Likewise.
2040         * parser-defs.h (parser_debug): Likewise.
2041         * printcmd.c (print_symbol_filename): Likewise.
2042         * proc-api.c (procfs_trace): Likewise.
2043         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2044         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2045         (set_parameter_value): Update.
2046         (add_setshow_generic): Update.
2047         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2048         to bool*.
2049         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2050         int*.
2051         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2052         * record-btrace.c (record_btrace_target::store_registers): Update.
2053         * record-full.c (record_full_memory_query): Change to bool.
2054         (record_full_stop_at_limit): Likewise.
2055         * record-full.h (record_full_memory_query): Likewise.
2056         * remote-notif.c (notif_debug): Likewise.
2057         * remote-notif.h (notif_debug): Likewise.
2058         * remote.c (use_range_stepping): Likewise.
2059         (interrupt_on_connect): Likewise.
2060         (remote_break): Likewise.
2061         * ser-tcp.c (tcp_auto_retry): Likewise.
2062         * ser-unix.c (serial_hwflow): Likewise.
2063         * skip.c (debug_skip): Likewise.
2064         * solib-aix.c (solib_aix_debug): Likewise.
2065         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2066         (spu_auto_flush_cache_p): Likewise.
2067         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2068         Likewise.
2069         (struct info_print_options) <quiet>: Likewise.
2070         * symfile-debug.c (debug_symfile): Likewise.
2071         * symfile.c (auto_solib_add): Likewise.
2072         (separate_debug_file_debug): Likewise.
2073         * symfile.h (auto_solib_add): Likewise.
2074         (separate_debug_file_debug): Likewise.
2075         * symtab.c (basenames_may_differ): Likewise.
2076         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2077         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2078         (struct info_types_options) <quiet>: Likewise.
2079         * symtab.h (demangle): Likewise.
2080         (basenames_may_differ): Likewise.
2081         * target-dcache.c (stack_cache_enabled_1): Likewise.
2082         (code_cache_enabled_1): Likewise.
2083         * target.c (trust_readonly): Likewise.
2084         (may_write_registers): Likewise.
2085         (may_write_memory): Likewise.
2086         (may_insert_breakpoints): Likewise.
2087         (may_insert_tracepoints): Likewise.
2088         (may_insert_fast_tracepoints): Likewise.
2089         (may_stop): Likewise.
2090         (auto_connect_native_target): Likewise.
2091         (target_stop_and_wait): Update.
2092         (target_async_permitted): Change to bool.
2093         (target_async_permitted_1): Likewise.
2094         (may_write_registers_1): Likewise.
2095         (may_write_memory_1): Likewise.
2096         (may_insert_breakpoints_1): Likewise.
2097         (may_insert_tracepoints_1): Likewise.
2098         (may_insert_fast_tracepoints_1): Likewise.
2099         (may_stop_1): Likewise.
2100         * target.h (target_async_permitted): Likewise.
2101         (may_write_registers): Likewise.
2102         (may_write_memory): Likewise.
2103         (may_insert_breakpoints): Likewise.
2104         (may_insert_tracepoints): Likewise.
2105         (may_insert_fast_tracepoints): Likewise.
2106         (may_stop): Likewise.
2107         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2108         (make_thread_apply_all_options_def_group): Change argument from int*
2109         to bool*.
2110         (thread_apply_all_command): Update.
2111         (print_thread_events): Change to bool.
2112         * top.c (confirm): Likewise.
2113         (command_editing_p): Likewise.
2114         (history_expansion_p): Likewise.
2115         (write_history_p): Likewise.
2116         (info_verbose): Likewise.
2117         * top.h (confirm): Likewise.
2118         (history_expansion_p): Likewise.
2119         * tracepoint.c (disconnected_tracing): Likewise.
2120         (circular_trace_buffer): Likewise.
2121         * typeprint.c (print_methods): Likewise.
2122         (print_typedefs): Likewise.
2123         * utils.c (debug_timestamp): Likewise.
2124         (sevenbit_strings): Likewise.
2125         (pagination_enabled): Likewise.
2126         * utils.h (sevenbit_strings): Likewise.
2127         (pagination_enabled): Likewise.
2128         * valops.c (overload_resolution): Likewise.
2129         * valprint.h (struct value_print_options) <prettyformat_arrays,
2130         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2131         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2132         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2133         Likewise.
2134         * windows-nat.c (new_console): Likewise.
2135         (cygwin_exceptions): Likewise.
2136         (new_group): Likewise.
2137         (debug_exec): Likewise.
2138         (debug_events): Likewise.
2139         (debug_memory): Likewise.
2140         (debug_exceptions): Likewise.
2141         (useshell): Likewise.
2142         * windows-tdep.c (maint_display_all_tib): Likewise.
2143         * xml-support.c (debug_xml): Likewise.
2144
2145 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2146
2147         * source.c (prepare_path_for_appending): New function.
2148         (openp): Make use of new function.
2149         (find_and_open_source): Search for the compilation directory and
2150         source file as a relative path beneath the directory search path.
2151
2152 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2153
2154         * source-cache.c (source_cache::get_line_charpos): Catch
2155         exceptions and return false, this matches the behaviour documented
2156         in the header file.
2157
2158 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2159
2160         * ada-tasks.c (info_task): Remove quoting of the task's name.
2161
2162 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2163
2164         * symfile.c (auto_solib_add): Replace comment with a reference
2165         to the header file.
2166
2167 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2168
2169         * NEWS: Mention that gdb can now be compiled with Python 3
2170         on Windows.
2171
2172 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         * maint.c (maint_print_section_data::maint_print_section_data):
2175         Force use of 'float log10 (float)' by casting the argument to
2176         float.
2177
2178 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * maint.c: Add 'cmath' include.
2181         (struct maint_print_section_data): New structure.
2182         (print_section_index): New function.
2183         (print_bfd_section_info): Add header comment, small whitespace
2184         cleanup, and update to call new print_section_index function.
2185         (print_objfile_section_info): Likewise.
2186         (maint_obj_section_from_bfd_section): New function.
2187         (print_bfd_section_info_maybe_relocated): New function.
2188         (maintenance_info_sections): Add header comment, always use
2189         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2190
2191 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2194         inner scope, add check that the objfile has psymtabs before
2195         checking psymtabs_addrmap.
2196         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2197
2198 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2199
2200         * NEWS: Announce that Ada task names are now shown at more places,
2201         and between quotes (except in info task output).
2202         * gdb/ada-tasks.c (task_to_str): New function.
2203         (display_current_task_id): Call task_to_str.
2204         (task_command_1): Likewise.
2205         (print_ada_task_info): In non-mi mode, Properly align headers and data
2206         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2207
2208 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2209
2210         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2211         prstatus.pr_lwp.pr_info instead of making it up.
2212
2213 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2214
2215         * auto-load.c (auto_load_expand_dir_vars): Update.
2216         * defs.h (gdb_datadir): Change to std::string.
2217         (python_libdir): Likewise.
2218         (relocate_gdb_directory): Change return type to std::string.
2219         * guile/guile.c (gdbscm_data_directory): Update.
2220         (initialize_scheme_side): Update.
2221         * jit.c (jit_reader_dir): Change to std::string.
2222         (jit_reader_load_command): Update.
2223         * main.c (gdb_datadir): Change to std::string.
2224         (python_libdir): Likewise.
2225         (set_gdb_data_directory): Update.
2226         (relocate_path): Change to return std::string.
2227         (relocate_gdb_directory): Change to return std::string.
2228         (relocate_gdbinit_path_maybe_in_datadir): Update.
2229         (captured_main_1): Update.
2230         * python/python.c (do_start_initialization): Update.
2231         * top.c (show_gdb_datadir): Update.
2232         * xml-syscall.c (xml_init_syscalls_info): Update.
2233         (init_syscalls_info): Update.
2234
2235 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2236
2237         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2238         out of get_init_files.
2239         (get_init_files): Update.
2240
2241 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2242
2243         * main.c (get_init_files): Change to use std::string.
2244         (captured_main_1): Update.
2245         (print_gdb_help): Update.
2246
2247 2019-09-11  Ali Tamur  <tamur@google.com>
2248
2249         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2250         implementation.
2251
2252 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2253
2254         * dbxread.c (read_dbx_symtab): Update.
2255         * dwarf2read.c (load_partial_dies): Update.
2256         * mdebugread.c (parse_partial_symbols): Update.
2257         (handle_psymbol_enumerators): Update.
2258         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2259         * psymtab.c (add_psymbol_to_bcache): Likewise.
2260         (add_psymbol_to_list): Likewise.
2261         * symtab.c (symbol_set_names): Likewise.
2262         * symtab.h (symbol_set_names): Likewise.
2263         * xcoffread.c (scan_xcoff_symtab): Update.
2264
2265 2019-09-11  Tom Tromey  <tom@tromey.com>
2266
2267         * symfile-mem.c (symbol_file_add_from_memory): Use
2268         bfd_set_filename.
2269         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2270         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2271
2272 2019-09-10  Tom Tromey  <tromey@adacore.com>
2273
2274         * dwarf-index-write.c (write_psymbols): Extend error message.
2275         (debug_names::insert): Add Ada code.
2276         (debug_names::write_psymbols): Remove Ada check.
2277         (debug_names) <m_string_obstack>: New member.
2278         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2279         (gdb_index_symbol_name_matcher::matches): Remove.
2280         (mapped_index_base::find_name_components_bounds): Add "lang"
2281         parameter.
2282         (mapped_index_base::build_name_components): Also split names
2283         according to Ada syntax.
2284         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2285         type of "match_callback".
2286         (check_match, check_find_bounds_finds)
2287         (dw2_expand_symtabs_matching): Update.
2288         (dw2_debug_names_iterator): Add new constructor.
2289         (dw2_debug_names_map_matching_symbols): New function.
2290         (dw2_debug_names_expand_symtabs_matching): Update.
2291         (dwarf2_debug_names_functions): Use
2292         dw2_debug_names_map_matching_symbols.
2293
2294 2019-09-10  Tom Tromey  <tromey@adacore.com>
2295
2296         * dwarf2read.c (dw2_get_file_names_reader): Add the
2297         CU's file name to the results.
2298
2299 2019-09-10  Tom Tromey  <tromey@adacore.com>
2300
2301         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2302         map_matching_symbols.  Update.
2303         * dwarf2read.c (dw2_map_matching_symbols): Update.
2304         * psymtab.c (match_partial_symbol): Change type; update.
2305         (psym_map_matching_symbols): Likewise.
2306         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2307         type; update.
2308         * symfile.h (struct quick_symbol_functions)
2309         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2310         Remove "match".
2311
2312 2019-09-10  Tom Tromey  <tromey@adacore.com>
2313
2314         * psymtab.c (map_block): Remove.
2315         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2316         * symtab.c (iterate_over_symbols_terminated): New function.
2317         * symtab.c (iterate_over_symbols_terminated): Declare.
2318
2319 2019-09-10  Tom Tromey  <tromey@adacore.com>
2320
2321         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2322         * language.h (struct language_defn) <la_iterate_over_symbols>:
2323         Return bool.
2324         * symtab.c (iterate_over_symbols): Return bool.
2325         * symtab.h (iterate_over_symbols): Return bool.
2326
2327 2019-09-10  Tom Tromey  <tromey@adacore.com>
2328
2329         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2330         (add_nonlocal_symbols): Update.
2331         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2332         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2333         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2334         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2335         Change type of "callback".  Remove "data".
2336
2337
2338 2019-09-09  Ali Tamur  <tamur@google.com>
2339
2340         * dwarf2read.c (comp_unit_head): Update comment.
2341         (dwarf2_dwo_name): New function declaration.
2342         (dwarf_unit_type_name): New function declaration.
2343         (read_comp_unit_head): Add support for new compilation units,
2344         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2345         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2346         (currently named as "signature") in their header. Also clarify error
2347         messages.
2348         (lookup_dwo_id): New function. Returns the dwo id of the given
2349         compile unit.
2350         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2351         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2352         functions.
2353         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2354         (dwarf2_dwo_name): Get the dwo name if present.
2355         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2356         purposes.
2357
2358 2019-09-09  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2361
2362 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2363
2364         * python/python.c (do_start_initialization): Make progname_copy static,
2365         to avoid a leak report.
2366
2367 2019-09-08  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2370
2371 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2372
2373         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2374         Change type to gdb::optional<block_enum>.
2375         (dw2_symtab_iter_init): Change block_index parameter type
2376         to gdb::optional<block_enum>.
2377         (dw2_lookup_symbol): Change block_index parameter
2378         type to block_enum.c
2379         (dw2_debug_names_lookup_symbol): Likewise.
2380         * psymtab.c (psym_lookup_symbol): Likewise.
2381         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2382         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2383         Likewise.
2384
2385 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2386
2387         * defs.h (relocate_gdb_directory): Change int to bool in
2388         signature and rename flag to relocatable.
2389         * main.c (relocate_path): Likewise.
2390         (relocate_gdb_directory): Likewise.
2391
2392 2019-09-06  Alan Modra  <amodra@gmail.com>
2393
2394         * coffread.c (coff_symfile_read): Constify filename variable.
2395         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2396         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2397         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2398         * solib.c (reload_shared_libraries_1): Likewise.
2399         * symfile.c (reread_symbols): Likewise.
2400         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2401         * solib-darwin.c (darwin_bfd_open): Likewise.
2402         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2403
2404 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2407         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2408
2409 2019-09-03  Tom Tromey  <tromey@adacore.com>
2410
2411         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2412         types.
2413         (has_negatives): Unbias a range type bound.
2414         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2415         * gdbtypes.c (operator==): Handle new field.
2416         (create_range_type): Add "bias" parameter.
2417         (create_static_range_type, resolve_dynamic_range): Update.
2418         * gdbtypes.h (struct range_bounds) <bias>: New member.
2419         (create_range_type): Add bias parameter.
2420         * printcmd.c (print_scalar_formatted): Unbias range types.
2421         * value.c (unpack_long): Unbias range types.
2422         (pack_long): Bias range types.
2423
2424 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2425
2426         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2427         probe arguments.
2428
2429 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2430
2431         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2432         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2433         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2434         (compile_probe_arg): Likewise.
2435         * probe.h (get_argument_count): Likewise.
2436         * solib-svr4.c (solib_event_probe_action): Likewise.
2437         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2438
2439 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2440
2441         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2442         code to here...
2443         (svr4_create_solib_event_breakpoints): ...from here.
2444
2445 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2446
2447         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2448         suffix from warning message.
2449
2450 2019-08-30  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-winsource.h (struct tui_source_window_base)
2453         <refresh_all>: Don't declare.
2454         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2455         Remove.
2456         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2457         tui_show_locator_content.
2458         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2459         declare.
2460         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2461         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2462         declare.
2463
2464 2019-08-30  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2467
2468 2019-08-30  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2471         Remove unnecessary forward declarations.
2472
2473 2019-08-30  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2476         rerender.
2477         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2478         tui_show_locator_content.
2479
2480 2019-08-30  Tom Tromey  <tom@tromey.com>
2481
2482         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2483         (tui_locator_window::rerender): Rewrite using body of previous
2484         tui_show_locator_content.
2485
2486 2019-08-30  Tom Tromey  <tom@tromey.com>
2487
2488         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2489         set_locator_fullname>: New methods.
2490         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2491         Rename from tui_set_locator_fullname.
2492         (tui_locator_window::set_locator_info): Rename from
2493         tui_set_locator_info.  Return bool.
2494         (tui_update_locator_fullname, tui_show_frame_info): Update.
2495
2496 2019-08-30  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2499
2500 2019-08-30  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2503         call touchwin.
2504
2505 2019-08-30  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-wingeneral.c (box_win): Assume win_info and
2508         win_info->handle cannot be NULL.
2509
2510 2019-08-30  Tom Tromey  <tom@tromey.com>
2511
2512         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2513         refresh_window>: Declare.
2514         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2515         resize.
2516         (tui_data_item_window::rerender): Rename from
2517         tui_display_register.
2518         (tui_data_item_window::refresh_window): New method.
2519         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2520         no-op.
2521
2522 2019-08-30  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2525         regs_column_count, current_group>: Move later.  Now private.
2526         <get_current_group>: New method.
2527         * tui/tui-regs.c (tui_reg_command): Update.
2528         * tui/tui-layout.c (tui_set_layout): Update.
2529
2530 2019-08-30  Tom Tromey  <tom@tromey.com>
2531
2532         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2533         (tui_data_window::rerender): Don't call
2534         check_and_display_highlight_if_needed.
2535         (tui_data_window::refresh_all): Remove call to
2536         erase_data_content.
2537
2538 2019-08-30  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2541         (tui_data_window::display_registers_from)
2542         (tui_data_window::display_reg_element_at_line)
2543         (tui_data_window::display_registers_from_line): Remove checks of
2544         "empty".
2545
2546 2019-08-30  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2549         Don't declare.
2550         * tui/tui-regs.c (tui_data_window::show_registers): Call
2551         rerender.
2552         (tui_data_window::rerender): Rename from display_all_data.
2553         (tui_data_window::rerender): Remove old implementation.
2554
2555 2019-08-30  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2558         text.
2559         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2560
2561 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2562             Sergio Durigan Junior  <sergiodj@redhat.com>
2563
2564         PR win32/24284
2565         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2566
2567 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2570         when searching for types.
2571
2572 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2573
2574         * f-lang.c (f_language_defn): Use f_print_typedef.
2575         * f-lang.h (f_print_typedef): Declare.
2576         * f-typeprint.c (f_print_typedef): Define.
2577
2578 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2579
2580         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2581
2582 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2583
2584         * cli/cli-utils.c (info_print_options_defs): Delete.
2585         (make_info_print_options_def_group): Delete.
2586         (extract_info_print_options): Delete.
2587         (info_print_command_completer): Delete.
2588         (info_print_args_help): Add extra parameter, and optionally
2589         include text about -n flag.
2590         * cli/cli-utils.h (struct info_print_options): Delete.
2591         (extract_info_print_options): Delete declaration.
2592         (info_print_command_completer): Delete declaration.
2593         (info_print_args_help): Add extra parameter, extend header
2594         comment.
2595         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2596         search_symbols.
2597         * stack.c (struct info_print_options): New type.
2598         (info_print_options_defs): New file scoped variable.
2599         (make_info_print_options_def_group): New static function.
2600         (info_print_command_completer): New static function.
2601         (info_locals_command): Update to use new local functions.
2602         (info_args_command): Likewise.
2603         (_initialize_stack): Add extra parameter to calls to
2604         info_print_args_help.
2605         * symtab.c (search_symbols): Add extra parameter, use this to
2606         possibly excluse non-debug symbols.
2607         (symtab_symbol_info): Add extra parameter, which is passed on to
2608         search_symbols.
2609         (struct info_print_options): New type.
2610         (info_print_options_defs): New file scoped variable.
2611         (make_info_print_options_def_group): New static function.
2612         (info_print_command_completer): New static function.
2613         (info_variables_command): Update to use local functions, and pass
2614         extra parameter through to symtab_symbol_info.
2615         (info_functions_command): Likewise.
2616         (info_types_command): Pass additional argument through to
2617         symtab_symbol_info.
2618         (rbreak_command): Pass extra argument to search_symbols.
2619         (_initialize_symtab): Add extra arguments for calls to
2620         info_print_args_help, and update help text for 'info variables',
2621         'whereis', and 'info functions' commands.
2622         * symtab.h (search_symbols): Add extra argument to declaration.
2623         * NEWS: Mention new flags.
2624
2625 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2626
2627         * symtab.c (lookup_static_symbol): Call the new function (and move
2628         it down to be next to lookup_global_symbol).
2629         (struct global_sym_lookup_data): Add block_enum member and rename to...
2630         (struct global_or_static_sym_lookup_data): ...this.
2631         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2632         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2633         (lookup_symbol_global_or_static_iterator_cb): ...this.
2634         (lookup_global_or_static_symbol): New function.
2635         (lookup_global_symbol): Call new function.
2636
2637 2019-08-26  Tom de Vries  <tdevries@suse.de>
2638
2639         PR c++/24852
2640         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2641         when pc_probe.prob == NULL.
2642
2643 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2644
2645         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2646         variable symbol_linkage to symbol_linkage_.
2647
2648 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2649
2650         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2651         represent whether the symbol is static, dynamic, or we don't
2652         know.
2653
2654 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2655
2656         * gdb/rx-tdep.c (rx_register_names): New.
2657         (rx_register_name): Delete.
2658         (rx_psw_type): Delete.
2659         (rx_fpsw_type): Delete.
2660         (rx_register_type): Delete.
2661         (rx_gdbarch_init): Convert target-descriptions.
2662         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2663         * gdb/features/Makefile: Add rx.xml.
2664         * gdb/features/rx.xml: New.
2665         * gdb/features/rx.c: Generated.
2666         * gdb/NEWS: Mention target description support.
2667
2668 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2669
2670         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2671         *slot_ptr.
2672
2673 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2674
2675         * configure.ac: Don't check for 'dlfcn.h' (moved to
2676         gdbsupport/common.m4).
2677         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2678         'gdbsupport/'.
2679         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2680         * compile/compile-c-support.c: Include
2681         'gdbsupport/gdb-dlfcn.h'.
2682         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2683         * gdb-dlfcn.c: Move to...
2684         * gdbsupport/gdb-dlfcn.c: ... here.
2685         * gdb-dlfcn.h: Move to...
2686         * gdbsupport/gdb-dlfcn.h: ... here.
2687
2688 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2689
2690         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2691         the offset field signed.
2692
2693 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2694
2695         * python/lib/gdb/__init__.py (_execute_file): New function.
2696         * python/python.c (python_run_simple_file): Call gdb._execute_file
2697         on Windows.
2698
2699 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2700
2701         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2702         all uses as this was never set to anything but a zero value.
2703
2704 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2705
2706         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2707
2708 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2709
2710         * tui/tui-data.h (tui_gen_win_info): Add an =default
2711         move constructor, required by some GCC versions.
2712
2713 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2714
2715         * go32-nat.c (go32_sysinfo): Add hygon_p.
2716
2717 2019-08-20  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2720         line_from_reg_element_no, first_reg_element_no_inline,
2721         display_all_data, delete_data_content_windows,
2722         erase_data_content>: Now private.
2723
2724 2019-08-20  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2727         (tui_unhighlight_win, tui_highlight_win)
2728         (tui_win_info::make_window): Update.
2729         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2730
2731 2019-08-20  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2734         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2735         (MAX_PID_WIDTH): Move to tui-stack.c.
2736         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2737         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2738         (MAX_PID_WIDTH): Move from tui-data.h.
2739
2740 2019-08-20  Tom Tromey  <tom@tromey.com>
2741
2742         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2743         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2744         (box_win): Update.
2745         (tui_gen_win_info::make_window): Rename from tui_make_window.
2746         (tui_win_info::make_window): New method.
2747         (tui_gen_win_info::make_visible): Update.
2748         * tui/tui-source.c (tui_source_window::set_contents): Update.
2749         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2750         (tui_data_window::display_registers_from): Update.
2751         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2752         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2753         Declare.
2754         <can_box>: Remove.
2755         <title>: Remove.
2756         (struct tui_win_info) <make_window>: Declare.
2757         <can_box>: Now virtual.
2758         <title>: New member.
2759         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2760         * tui/tui-command.c (tui_cmd_window::resize): Update.
2761
2762 2019-08-20  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2765         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2766         (tui_data_window::check_register_values): Update.
2767
2768 2019-08-20  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-regs.h (struct tui_data_window): Use
2771         DISABLE_COPY_AND_ASSIGN.
2772         <regs_content>: Change type, removing unique_ptr.
2773         <tui_data_window>: Add move constructor.
2774         * tui/tui-regs.c (tui_data_window::show_registers)
2775         (tui_data_window::show_register_group)
2776         (tui_data_window::display_registers_from)
2777         (tui_data_window::display_registers_from)
2778         (tui_data_window::first_data_item_displayed)
2779         (tui_data_window::delete_data_content_windows)
2780         (tui_data_window::rerender, tui_data_window::refresh_window)
2781         (tui_data_window::check_register_values): Update.
2782
2783 2019-08-20  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2786         show_register_group>: Declare.
2787         (tui_show_register_group): Don't declare.
2788         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2789         tui_show_registers.
2790         (tui_data_window::show_register_group): Rename from
2791         tui_show_register_group.
2792         (tui_data_window::check_register_values, tui_reg_command):
2793         Update.
2794         * tui/tui-layout.c (tui_set_layout): Update.
2795
2796 2019-08-20  Tom Tromey  <tom@tromey.com>
2797
2798         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2799         Declare.
2800         (tui_check_register_values): Don't declare.
2801         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2802         from tui_check_register_values.
2803         * tui/tui-hooks.c (tui_register_changed): Update.
2804
2805 2019-08-20  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-regs.c (tui_reg_layout): Move later.
2808         (tui_show_registers): Don't enable TUI mode or change layout.
2809
2810 2019-08-20  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-regs.h (struct tui_data_item_window)
2813         <~tui_data_item_window>: Remove.
2814         <content>: Now a unique_xmalloc_ptr.
2815         * tui/tui-regs.c (tui_register_format): Return a
2816         unique_xmalloc_ptr.
2817         (tui_get_register): Update.
2818         (~tui_data_item_window): Remove.
2819         (tui_data_window::display_registers_from, tui_display_register):
2820         Update.
2821         * tui/tui-io.h (tui_expand_tabs): Update.
2822         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2823         Remove "col" parameter.
2824
2825 2019-08-20  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2828         field.
2829         * tui/tui-regs.c (~tui_data_item_window): Update.
2830
2831 2019-08-20  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2834         earlier.
2835
2836 2019-08-20  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2839
2840 2019-08-20  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-source.h (struct tui_source_window): Update.
2843         * tui/tui-regs.c (tui_show_registers): Update.
2844         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2845         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2846         (NO_REGS_STRING): Remove defines.
2847
2848 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2849
2850         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2851         unnecessary thread walk if remote doesn't support the packet.
2852
2853 2019-08-19  Tom Tromey  <tromey@adacore.com>
2854
2855         * python/py-value.c (value_has_field): Fix indentation.
2856
2857 2019-08-19  Tom Tromey  <tromey@adacore.com>
2858
2859         * printcmd.c (do_one_display, info_display_command): Update.
2860         * block.h (contained_in): Return bool.  Add allow_nested
2861         parameter.
2862         * block.c (contained_in): Return bool.  Add allow_nested
2863         parameter.
2864
2865 2019-08-19  Tom Tromey  <tom@tromey.com>
2866
2867         * configure: Rebuild.
2868         * configure.ac: Disallow the combination of -static-libstdc++ and
2869         source highlight.
2870         * source-cache.c (get_language_name): Handle rust.
2871         (source_cache::get_source_lines): Ignore highlighting exceptions.
2872
2873 2019-08-16  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2876         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2877         (struct tui_source_window_base) <make_visible, refresh_window,
2878         resize>: Remove methods.
2879         <execution_info>: Remove field.
2880         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2881         (tui_show_source_line, tui_source_window_base)
2882         (~tui_source_window_base): Update.
2883         (tui_source_window_base::resize)
2884         (tui_source_window_base::make_visible)
2885         (tui_source_window_base::refresh_window): Remove.
2886         (tui_source_window_base::update_exec_info): Update.
2887         * tui/tui-source.c (tui_source_window::set_contents): Update.
2888         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2889
2890 2019-08-16  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2893         deprecated_query_hook.
2894
2895 2019-08-16  Tom Tromey  <tom@tromey.com>
2896
2897         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2898         (tui_update_source_windows_with_line): Update.
2899         * tui/tui-source.h (struct tui_source_window)
2900         <show_symtab_source>: Declare.
2901         (tui_show_symtab_source): Don't declare.
2902         * tui/tui-source.c (tui_show_symtab_source): Rename from
2903         tui_show_symtab_source.
2904
2905 2019-08-16  Tom Tromey  <tom@tromey.com>
2906
2907         * tui/tui-winsource.h (struct tui_source_window_base)
2908         <set_contents>: Declare.
2909         * tui/tui-winsource.c
2910         (tui_source_window_base::update_source_window_as_is): Update.
2911         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2912         Declare.
2913         (tui_set_source_content): Don't declare.
2914         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2915         tui_set_source_content.
2916         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2917         Declare.
2918         (tui_set_disassem_content): Don't declare.
2919         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2920         tui_set_disassem_content.
2921
2922 2019-08-16  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui-winsource.h (struct tui_source_window_base)
2925         <update_breakpoint_info>: Declare.
2926         (tui_update_breakpoint_info): Don't declare.
2927         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2928         (tui_update_all_breakpoint_info): Update.
2929         (tui_source_window_base::update_breakpoint_info): Rename from
2930         tui_update_breakpoint_info.
2931         (tui_source_window_base::update_exec_info): Update.
2932
2933 2019-08-16  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-winsource.h (struct tui_source_window_base)
2936         <update_source_window>: Declare.
2937         (tui_update_source_window): Don't declare.
2938         * tui/tui-winsource.c
2939         (tui_source_window_base::update_source_window): Rename from
2940         tui_update_source_window.
2941         (tui_source_window_base::rerender): Update.
2942         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2943         * tui/tui-disasm.c (tui_show_disassem)
2944         (tui_show_disassem_and_update_source)
2945         (tui_disasm_window::maybe_update): Update.
2946
2947 2019-08-16  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-winsource.h (struct tui_source_window_base)
2950         <update_source_window_as_is>: Declare.
2951         (tui_update_source_window_as_is): Don't declare.
2952         * tui/tui-winsource.c (tui_update_source_window): Update
2953         (tui_source_window_base::update_source_window_as_is): Rename from
2954         tui_update_source_window_as_is.
2955         (tui_source_window_base::refill): Update.
2956         * tui/tui-source.c (tui_show_symtab_source): Update.
2957         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2958         Update.
2959
2960 2019-08-16  Tom Tromey  <tom@tromey.com>
2961
2962         * tui/tui-winsource.h (tui_update_source_window)
2963         (tui_update_source_window_as_is): Remove "noerror" parameter.
2964         * tui/tui-winsource.c (tui_update_source_window)
2965         (tui_update_source_window_as_is): Remove "noerror" parameter.
2966         (tui_update_source_windows_with_addr)
2967         (tui_update_source_windows_with_line)
2968         (tui_source_window_base::rerender)
2969         (tui_source_window_base::refill): Update.
2970         * tui/tui-source.h (tui_set_source_content)
2971         (tui_show_symtab_source): Remove "noerror" parameter.
2972         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2973         parameter.
2974         (tui_show_symtab_source): Likewise.
2975         (tui_source_window::maybe_update): Update.
2976         * tui/tui-disasm.c (tui_show_disassem)
2977         (tui_show_disassem_and_update_source)
2978         (tui_disasm_window::do_scroll_vertical)
2979         (tui_disasm_window::maybe_update): Update.
2980
2981 2019-08-16  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui.c (tui_is_window_visible): Update.
2984         * tui/tui-wingeneral.c (tui_make_window)
2985         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2986         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2987         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2988         (tui_set_win_height_command, parse_scrolling_args): Update.
2989         * tui/tui-source.c (tui_source_window::style_changed): Update.
2990         * tui/tui-regs.c (tui_show_registers)
2991         (tui_data_window::first_data_item_displayed)
2992         (tui_data_window::delete_data_content_windows)
2993         (tui_check_register_values, tui_reg_command): Update.
2994         * tui/tui-disasm.c (tui_show_disassem): Update.
2995         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2996         method.
2997         <is_visible>: Remove field.
2998         * tui/tui-data.c (tui_next_win, tui_prev_win)
2999         (tui_delete_invisible_windows): Update.
3000
3001 2019-08-16  Tom Tromey  <tom@tromey.com>
3002
3003         * tui/tui-winsource.h (struct tui_source_window_base)
3004         <m_has_locator>: Remove.
3005         * tui/tui-layout.c (show_source_disasm_command, show_data)
3006         (show_source_or_disasm_and_command): Update.
3007
3008 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3009
3010         * NEWS (Other MI changes): New subsection.
3011         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3012         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3013         * arch-utils.c (default_get_pc_address_flags): New function.
3014         * arch-utils.h (default_get_pc_address_flags): New declaration.
3015         * gdbarch.sh: Add get_pc_address_flags.
3016         * gdbarch.c: Regenerate.
3017         * gdbarch.h: Likewise.
3018         * stack.c (print_pc): New function.
3019         (print_frame_info) (print_frame): Call print_pc.
3020
3021 2019-08-16  Tom de Vries  <tdevries@suse.de>
3022
3023         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3024         print_objfile_section_info.
3025
3026 2019-08-15  Tom Tromey  <tom@tromey.com>
3027
3028         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3029         calling update_cmdwin_start_line.
3030         * tui/tui-winsource.h (struct tui_source_window_base)
3031         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3032         <rerender>: Declare.
3033         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3034         Call rerender.
3035         (tui_source_window_base::set_new_height): Remove.
3036         (tui_source_window_base::rerender): Rename from
3037         do_make_visible_with_new_height.
3038         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3039         resize method.
3040         (tui_win_info::make_invisible_and_set_new_height)
3041         (tui_win_info::make_visible_with_new_height): Remove.
3042         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3043         Declare.
3044         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3045         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3046         do_make_visible_with_new_height>: Don't declare.
3047         <rerender>: Declare.
3048         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3049         set_new_height.
3050         (tui_data_window::do_make_visible_with_new_height): Remove.
3051         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3052         call tui_show_locator_content.
3053         (tui_gen_win_info::resize): Call rerender.
3054         (show_source_or_disasm_and_command): Don't call
3055         tui_show_locator_content.
3056         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3057         method.
3058         (struct tui_win_info) <rerender>: Declare.
3059         <set_new_height, make_invisible_and_set_new_height,
3060         make_visible_with_new_height>: Don't declare.
3061         * tui/tui-data.c (tui_win_list::rerender): New method.
3062         * tui/tui-command.h (struct tui_cmd_window)
3063         <do_make_visible_with_new_height>: Don't declare.
3064         * tui/tui-command.c
3065         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3066
3067 2019-08-15  Tom Tromey  <tromey@adacore.com>
3068
3069         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3070         * ada-lang.c (ada_enum_name): Likewise.
3071
3072 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3073
3074         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3075         leading underscore.
3076         (GdbOutputErrorFile): Likewise.
3077         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3078         accordingly.
3079         (execute_unwinders): Rename to have a leading underscore.
3080         (auto_load_packages): Likewise.
3081         (global scope): Adjust call to auto_load_packages accordingly.
3082         (GdbSetPythonDirectory): Likewise.
3083         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3084         instead of execute_unwinders.
3085
3086 2019-08-15  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3089         (show_data): Don't change window visibility.
3090         (tui_gen_win_info::resize): Remove special case for command
3091         window.  Use wresize, when available.
3092         (show_source_or_disasm_and_command): Don't change window
3093         visibility.
3094         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3095         <make_visible>: New method.
3096         * tui/tui-command.c (tui_cmd_window::resize): New method.
3097
3098 2019-08-15  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3101         (struct tui_source_windows): New.
3102         * tui/tui-winsource.c (tui_display_main): Update.
3103         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3104         (new_height_ok, parse_scrolling_args): Update.
3105         * tui/tui-layout.c (show_layout, show_data): Update.
3106         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3107         (tui_add_to_source_windows): Don't declare.
3108         * tui/tui-data.c (source_windows, tui_source_windows)
3109         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3110
3111 2019-08-15  Tom Tromey  <tom@tromey.com>
3112
3113         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3114         Rename from reset.
3115         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3116         * tui/tui-layout.c (show_source_disasm_command, show_data):
3117         Update.
3118         (tui_gen_win_info::resize): Rename.
3119         (show_source_or_disasm_and_command): Update.
3120         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3121         reset.
3122
3123 2019-08-15  Tom Tromey  <tom@tromey.com>
3124
3125         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3126         * tui/tui-interp.c (tui_interp::init): Don't call
3127         tui_initialize_static_data.
3128         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3129
3130 2019-08-15  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3133         examine tui_win_list.
3134
3135 2019-08-15  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3138         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3139         tui_clear_source_content.
3140         (tui_clear_source_content): Remove.
3141         (tui_source_window_base::do_erase_source_content): Hoist call to
3142         content.clear().
3143         * tui/tui-stack.c (tui_show_frame_info): Don't call
3144         tui_clear_source_content.
3145
3146 2019-08-15  Tom Tromey  <tom@tromey.com>
3147
3148         * tui/tui-winsource.h (struct tui_source_window_base)
3149         <do_erase_source_content>: New method.
3150         <erase_source_content>: New method.
3151         (tui_erase_source_content): Don't declare.
3152         * tui/tui-winsource.c (tui_clear_source_content): Update.
3153         (tui_source_window_base::do_erase_source_content): Rename from
3154         tui_erase_source_content.
3155         (tui_source_window_base::show_source_content): Update.
3156         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3157         * tui/tui-source.h (struct tui_source_window)
3158         <erase_source_content>: New method.
3159         * tui/tui-disasm.h (struct tui_disasm_window)
3160         <erase_source_content>: New method.
3161
3162 2019-08-15  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3165         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3166         constructor.
3167         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3168         * tui/tui-source.c (tui_set_source_content): Update.
3169         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3170
3171 2019-08-15  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3174         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3175         tui-source.c.
3176         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3177         Declare.
3178         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3179         method.
3180         (tui_source_window::maybe_update): Update.
3181
3182 2019-08-15  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3185         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3186         tui-disasm.c.
3187         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3188         Declare.
3189         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3190         method.
3191         (tui_disasm_window::maybe_update): Update.
3192
3193 2019-08-15  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-winsource.h (struct tui_source_window_base)
3196         <maybe_update>: Declare.
3197         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3198         method.
3199         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3200         Declare.
3201         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3202         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3203         Declare.
3204         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3205
3206 2019-08-15  Tom Tromey  <tom@tromey.com>
3207
3208         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3209
3210 2019-08-15  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-wingeneral.c: Include tui-stack.h.
3213         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3214         (struct tui_locator_window): Move from tui-data.h.
3215         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3216         (tui_initialize_static_data): Move from tui-data.c.
3217         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3218         (struct tui_locator_window): Move to tui-stack.c.
3219         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3220         (tui_initialize_static_data): Move to tui-stack.c.
3221
3222 2019-08-15  Tom Tromey  <tom@tromey.com>
3223
3224         * tui/tui-layout.c (show_source_disasm_command)
3225         (show_source_or_disasm_and_command): Use make_visible method, not
3226         tui_make_window.
3227         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3228         Remove.
3229
3230 2019-08-15  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-wingeneral.h (tui_make_window): Update.
3233         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3234         parameter.
3235         (tui_gen_win_info::make_visible): Update.
3236         * tui/tui-regs.c (tui_data_window::display_registers_from):
3237         Update.
3238         * tui/tui-layout.c (show_source_disasm_command)
3239         (show_source_or_disasm_and_command): Update.
3240         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3241         (enum tui_box): Remove.
3242         (struct tui_win_info) <can_box>: New method.
3243         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3244         method.
3245
3246 2019-08-15  Tom de Vries  <tdevries@suse.de>
3247
3248         * linux-nat-trad.c: Include gdbarch.h.
3249
3250 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3251
3252         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3253         register sizes.
3254
3255 2019-08-14  Tom Tromey  <tromey@adacore.com>
3256
3257         * darwin-nat.c: Include gdbarch.h.
3258         * darwin-nat-info.c: Include gdbarch.h.
3259
3260 2019-08-13  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3263         Remove.
3264         * tui/tui-data.c (tui_initialize_static_data): Update.
3265
3266 2019-08-13  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-winsource.h (struct tui_exec_info_window)
3269         <~tui_exec_info_window, maybe_allocate_content, get_content,
3270         m_content>: Remove.
3271         (struct tui_source_window_base) <set_exec_info_content,
3272         show_exec_info_content>: Don't declare.
3273         * tui/tui-winsource.c
3274         (tui_exec_info_window::maybe_allocate_content): Remove.
3275         (tui_source_window_base::update_exec_info): Rename from
3276         set_exec_info_content.
3277         (tui_source_window_base::show_exec_info_content)
3278         (tui_source_window_base::update_exec_info): Remove.
3279
3280 2019-08-13  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3283         declare.
3284         * tui/tui-winsource.c (tui_update_source_window_as_is)
3285         (tui_update_source_windows_with_addr, tui_erase_source_content):
3286         Update.
3287         (tui_clear_exec_info_content): Remove.
3288
3289 2019-08-13  Tom Tromey  <tom@tromey.com>
3290
3291         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3292         declare.
3293         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3294         call tui_erase_exec_info_content.
3295         (tui_clear_exec_info_content): Rename from
3296         tui_erase_exec_info_content.
3297         (tui_clear_exec_info_content): Delete.
3298
3299 2019-08-13  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-winsource.h (struct tui_source_window_base)
3302         <show_exec_info_content>: Declare.
3303         (tui_show_exec_info_content): Don't declare.
3304         * tui/tui-winsource.c
3305         (tui_source_window_base::show_exec_info_content): Rename from
3306         tui_show_exec_info_content.
3307         (tui_source_window_base::update_exec_info): Update.
3308
3309 2019-08-13  Tom Tromey  <tom@tromey.com>
3310
3311         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3312         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3313         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3314         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3315         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3316         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3317         ... here.
3318
3319 2019-08-13  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-winsource.h (struct tui_source_window_base)
3322         <update_exec_info>: Declare.
3323         (tui_update_exec_info): Don't declare.
3324         * tui/tui-winsource.c (tui_update_source_window_as_is)
3325         (tui_source_window_base::refresh_all)
3326         (tui_update_all_breakpoint_info): Update.
3327         (tui_source_window_base::update_exec_info): Rename from
3328         tui_update_exec_info.
3329         * tui/tui-stack.c (tui_show_frame_info): Update.
3330
3331 2019-08-13  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-winsource.h (struct tui_source_window_base)
3334         <set_exec_info_content>: Declare.
3335         (tui_set_exec_info_content): Don't declare.
3336         * tui/tui-winsource.c
3337         (tui_source_window_base::set_exec_info_content): Rename from
3338         tui_set_exec_info_content.
3339         (tui_update_exec_info): Update.
3340
3341 2019-08-13  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-winsource.h (struct tui_source_window_base)
3344         <show_source_content>: Declare.
3345         (tui_show_source_content): Don't declare.
3346         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3347         (tui_source_window_base::show_source_content): Rename from
3348         tui_show_source_content.
3349         (tui_source_window_base::refresh_all): Update.
3350         * tui/tui-layout.c (show_source_disasm_command)
3351         (show_source_or_disasm_and_command): Update.
3352
3353 2019-08-13  Tom Tromey  <tom@tromey.com>
3354
3355         * tui/tui-winsource.c (tui_erase_source_content)
3356         (tui_show_source_content, tui_source_window_base::refresh_all):
3357         Update.
3358         * tui/tui-wingeneral.h
3359         (tui_check_and_display_highlight_if_needed): Don't declare.
3360         * tui/tui-wingeneral.c
3361         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3362         check_and_display_highlight_if_needed.
3363         * tui/tui-win.c (tui_rehighlight_all)
3364         (tui_win_info::make_visible_with_new_height): Update.
3365         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3366         (tui_data_window::erase_data_content)
3367         (tui_data_window::display_all_data): Update.
3368         * tui/tui-data.h (struct tui_win_info)
3369         <check_and_display_highlight_if_needed>: Declare.
3370
3371 2019-08-13  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-win.c (tui_resize_all): Call
3374         tui_delete_invisible_windows.
3375         * tui/tui-layout.c (show_layout): Call
3376         tui_delete_invisible_windows.
3377         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3378         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3379
3380 2019-08-13  Tom Tromey  <tom@tromey.com>
3381
3382         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3383         tui_add_win_to_layout.
3384
3385 2019-08-13  Tom Tromey  <tom@tromey.com>
3386
3387         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3388         * tui/tui-layout.c (tui_default_win_height): Now static.
3389
3390 2019-08-13  Tom Tromey  <tom@tromey.com>
3391
3392         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3393         single switch.
3394         (show_source_disasm_command, show_source_or_disasm_and_command):
3395         Don't check current layout.
3396
3397 2019-08-13  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-wingeneral.c (make_all_visible): Remove.
3400         (tui_make_all_invisible): Simplify.
3401         * tui/tui-layout.c (tui_make_all_invisible): Move from
3402         tui-wingeneral.c; simplify.
3403         (show_layout): Hoist call to tui_make_all_invisible.
3404         (show_data): Don't call tui_make_all_invisible.
3405
3406 2019-08-13  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3409         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3410
3411 2019-08-13  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3414         tui-data.c.
3415         (show_source_disasm_command, show_data)
3416         (show_source_or_disasm_and_command): Don't use
3417         tui_set_current_layout_to.
3418         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3419         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3420         tui-layout.c.
3421         (tui_set_current_layout_to): Remove.
3422
3423 2019-08-13  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-layout.c (tui_set_layout): Update.
3426         * tui/tui-data.h (struct tui_layout_def): Remove.
3427         (tui_layout_def): Don't declare.
3428         * tui/tui-data.c (layout_def): Remove.
3429         (tui_layout_def): Remove.
3430
3431 2019-08-13  Tom Tromey  <tom@tromey.com>
3432
3433         * tui/tui-winsource.h (struct tui_source_window_base)
3434         <clear_detail>: No longer "override".
3435         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3436         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3437         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3438         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3439         Remove.
3440         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3441
3442 2019-08-13  Tom Tromey  <tromey@adacore.com>
3443
3444         * tracepoint.c: Don't include readline.h or history.h.
3445
3446 2019-08-12  Tom Tromey  <tom@tromey.com>
3447
3448         * configure: Rebuild.
3449         * configure.ac: Check for readline 7.
3450         * NEWS: Mention readline 7 requirement.
3451         * README: Update.
3452
3453 2019-08-12  Tom Tromey  <tom@tromey.com>
3454
3455         * mingw-hdep.c (gdb_select): Remove readline hack.
3456
3457 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3458
3459         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3460         when the function fails.
3461
3462 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3463
3464         * s390-tdep.c (s390_type_align): New function.
3465         (s390_gdbarch_init): Set it as type_align gdbarch method.
3466
3467 2019-08-09  Tom de Vries  <tdevries@suse.de>
3468
3469         PR gdb/24591
3470         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3471         pc_low with relocation offset.
3472
3473 2019-08-07  Tom Tromey  <tromey@adacore.com>
3474
3475         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3476         (print_frame_args): Update.
3477         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3478         Update.
3479         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3480         * frame.h (struct frame_arg): Add initializers.
3481         <error>: Now a unique_xmalloc_ptr.
3482
3483 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3484
3485         * NEWS: Expand the Pointer Authentication entry.
3486         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3487         (aarch64_frame_unmask_lr): ... to this.
3488         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3489         Call aarch64_frame_unmask_lr.
3490         * frame.c (struct frame_info): Add "masked" variable.
3491         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3492         (fprint_frame): Check for masked pc.
3493         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3494         declarations.
3495         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3496         * stack.c (print_frame): Check for masked pc.
3497
3498 2019-08-06  Tom Tromey  <tom@tromey.com>
3499
3500         * stabsread.c (patch_block_stabs, read_one_struct_field)
3501         (read_enum_type): Use obstack_strndup.
3502         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3503         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3504         * dwarf2read.c (guess_full_die_structure_name)
3505         (anonymous_struct_prefix): Use obstack_strndup.
3506         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3507         * c-exp.y (yylex): Use obstack_strndup.
3508         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3509         (write_var_or_type): Use obstack_strndup.
3510
3511 2019-08-06  Tom Tromey  <tom@tromey.com>
3512
3513         * symfile.c (reread_symbols): Use obstack_strdup.
3514         * stabsread.c (read_type): Use obstack_strdup.
3515         * gdb_obstack.h (obstack_strdup): New overload.
3516         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3517         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3518         (dwarf2_canonicalize_name): Use obstack_strdup.
3519         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3520         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3521         Use obstack_strdup.
3522
3523 2019-08-06  Tom Tromey  <tom@tromey.com>
3524
3525         * gdb_obstack.h (obstack_strdup): Define.
3526         * gdb_obstack.c (obstack_strdup): Don't define.
3527
3528 2019-08-06  Tom Tromey  <tom@tromey.com>
3529
3530         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3531         obstack_strdup.
3532         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3533         obstack_strdup.
3534         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3535         * stabsread.c (common_block_start): Use obstack_strdup.
3536         * objfiles.c (set_objfile_main_name, objfile): Use
3537         obstack_strdup.
3538         * namespace.c (add_using_directive): Use obstack_strdup.
3539         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3540         * jit.c (finalize_symtab): Use obstack_strdup.
3541         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3542         (guess_partial_die_structure_name, partial_die_info::fixup)
3543         (dwarf2_name): Use obstack_strdup.
3544         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3545         obstack_strdup.
3546         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3547         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3548         obstack_strdup.
3549         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3550
3551 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3552
3553         * unittests/help-doc-selftests.c: New file.
3554         * Makefile.in: Add the new file.
3555
3556 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3557
3558         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3559         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3560         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3561         the trailing '.' is not output, and the first character is uppercased.
3562         (print_help_for_command): Update call to print_doc_line.
3563         (print_doc_of_command): Likewise.
3564         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3565         * cli/cli-option.c (append_indented_doc): Do not append newline.
3566         (build_help_option): Append newline after first appended_indented_doc
3567         only if a second call is done.
3568         (build_help): Append 2 new lines before each option, except the first
3569         one.
3570         * compile/compile.c (_initialize_compile): Add new lines after
3571         %OPTIONS%, when not at the end of the help.
3572         Change help doc or code
3573         producing the help doc to respect the invariants.
3574         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3575         Also removed the new line after 'Options:', as all other commands
3576         do not put an empty line between 'Options:' and the first option.
3577         * printcmd.c (_initialize_printcmd): Likewise.
3578         * stack.c (_initialize_stack): Likewise.
3579         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3580         incorrectly telling COMMAND is optional.
3581         * ada-lang.c (_initialize_ada_language): Change help doc or code
3582         producing the help doc to respect the invariants.
3583         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3584         * breakpoint.c (_initialize_breakpoint): Likewise.
3585         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3586         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3587         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3588         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3589         _initialize_cli_style): Likewise.
3590         * corelow.c (core_target_info): Likewise.
3591         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3592         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3593         * filesystem.c (_initialize_filesystem): Likewise.
3594         * frame.c (_initialize_frame): Likewise.
3595         * gnu-nat.c (add_task_commands): Likewise.
3596         * infcall.c (_initialize_infcall): Likewise.
3597         * infcmd.c (_initialize_infcmd): Likewise.
3598         * interps.c (_initialize_interpreter): Likewise.
3599         * language.c (_initialize_language): Likewise.
3600         * linux-fork.c (_initialize_linux_fork): Likewise.
3601         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3602         * maint.c (_initialize_maint_cmds): Likewise.
3603         * memattr.c (_initialize_mem): Likewise.
3604         * printcmd.c (_initialize_printcmd): Likewise.
3605         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3606         _RegEx): Likewise.
3607         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3608         * record-btrace.c (_initialize_record_btrace): Likewise.
3609         * record-full.c (_initialize_record_full): Likewise.
3610         * record.c (_initialize_record): Likewise.
3611         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3612         * regcache.c (_initialize_regcache): Likewise.
3613         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3614         _initialize_remote): Likewise.
3615         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3616         * serial.c (_initialize_serial): Likewise.
3617         * skip.c (_initialize_step_skip): Likewise.
3618         * source.c (_initialize_source): Likewise.
3619         * stack.c (_initialize_stack): Likewise.
3620         * symfile.c (_initialize_symfile): Likewise.
3621         * symtab.c (_initialize_symtab): Likewise.
3622         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3623         * top.c (init_main): Likewise.
3624         * tracefile-tfile.c (tfile_target_info): Likewise.
3625         * tracepoint.c (_initialize_tracepoint): Likewise.
3626         * tui/tui-win.c (_initialize_tui_win): Likewise.
3627         * utils.c (add_internal_problem_command): Likewise.
3628         * valprint.c (value_print_option_defs): Likewise.
3629
3630 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3631
3632         PR build/24886
3633         * configure.ac: Drop enable-libmcheck support.
3634         * configure, config.in: Rebuild.
3635         * libmcheck.m4: Remove.
3636         * acinclude.m4: Don't include it.
3637         * Makefile.in: Don't distribute it.
3638         * top.c (print_gdb_configuration): Don't mention it.
3639
3640 2019-08-06  Tom Tromey  <tom@tromey.com>
3641
3642         * utils.c (set_output_style): Sometimes pass stream to
3643         emit_style_escape.
3644         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3645         * record-btrace.c (btrace_insn_history): Update.
3646         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3647         method.
3648         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3649         Update initializers.
3650         <m_uiout>: New field.
3651         <m_di>: Move lower.
3652         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3653         Remove "uiout" parameter.
3654         (dump_insns): Update.
3655         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3656         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3657
3658 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3659
3660         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3661         (error_in_psymtab_expansion): Likewise.
3662         (lookup_symbol_via_quick_fns): Likewise.
3663         (basic_lookup_transparent_type_quick): Likewise.
3664         (basic_lookup_transparent_type_1): Likewise.
3665
3666 2019-08-06  Tom Tromey  <tromey@adacore.com>
3667
3668         * source.c (last_source_error): Now bool.
3669         (print_source_lines_base): Make "noprint" bool.  Only open
3670         source file when last_source_visited changes.
3671
3672 2019-08-06  Tom Tromey  <tromey@adacore.com>
3673
3674         * annotate.c (annotate_source_line): Use g_source_cache.
3675         * source-cache.c (source_cache::get_plain_source_lines): Change
3676         parameters.  Populate m_offset_cache.
3677         (source_cache::ensure): New method.
3678         (source_cache::get_line_charpos): New method.
3679         (extract_lines): Move lower.  Change parameters.
3680         (source_cache::get_source_lines): Move lower.
3681         * source-cache.h (class source_cache): Update comment.
3682         <get_line_charpos>: New method.
3683         <get_source_lines>: Update comment.
3684         <clear>: Clear m_offset_cache.
3685         <get_plain_source_lines>: Change parameters.
3686         <ensure>: New method
3687         <m_offset_cache>: New member.
3688         * source.c (forget_cached_source_info_for_objfile): Update.
3689         (info_source_command): Use g_source_cache.
3690         (find_source_lines, open_source_file_with_line_charpos): Remove.
3691         (print_source_lines_base, search_command_helper): Use g_source_cache.
3692         * source.h (open_source_file_with_line_charpos): Don't declare.
3693         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3694         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3695         Use g_source_cache.
3696
3697 2019-08-06  Tom Tromey  <tromey@adacore.com>
3698
3699         * source-cache.c (source_cache::get_plain_source_lines):
3700         Remove "first_line" and "last_line" parameters.
3701         (source_cache::get_source_lines): Cache plain text.
3702         * source-cache.h (class source_cache)
3703         <get_plain_source_lines>: Update.
3704
3705 2019-08-06  Tom Tromey  <tromey@adacore.com>
3706
3707         * source-cache.c (extract_lines): No longer a method.
3708         Changed type of parameter.  Include final newline.
3709         (selftests::extract_lines_test): New function.
3710         (_initialize_source_cache): Likewise.
3711         * source-cache.h (class source_cache)
3712         <extract_lines>: Don't declare.
3713
3714 2019-08-06  Tom Tromey  <tromey@adacore.com>
3715
3716         * breakpoint.c (init_breakpoint_sal): Update.
3717         (breakpoint): Update.
3718         * breakpoint.h (struct breakpoint) <filter>: Now a
3719         unique_xmalloc_ptr.
3720
3721 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3722
3723         * NEWS: Mention dictionary access on blocks.
3724         * python/py-block.c (blpy_getitem): New function.
3725         (block_object_as_mapping): New struct.
3726         (block_object_type): Use new struct for tp_as_mapping field.
3727
3728 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3729
3730         * objfiles.h (objfile): Add a comment describing partial symbols.
3731
3732 2019-08-05  Tom Tromey  <tromey@adacore.com>
3733
3734         * compile/compile.c (_initialize_compile): Use _(), not N_().
3735         * thread.c (_initialize_thread): Use _(), not N_().
3736         * stack.c (_initialize_stack): Use _(), not N_().
3737         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3738
3739 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3740
3741         * dwarf2read.c (struct dw2_symtab_iterator):
3742         <want_specific_block>: Remove.
3743         <block_index>: Change type to gdb::optional.
3744         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3745         change type of BLOCK_INDEX parameter to gdb::optional.
3746         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3747         (dw2_lookup_symbol): Don't pass argument for
3748         WANT_SPECIFIC_BLOCK.
3749         (dw2_expand_symtabs_for_function): Don't pass argument for
3750         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3751         (class dw2_debug_names_iterator)
3752         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3753         parameter, change BLOCK_INDEX type to gdb::optional.
3754         <m_want_specific_block>: Remove.
3755         <m_block_index>: Change type to gdb::optional.
3756         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3757         gdb::optional.  Re-write in function of gdb::optional.
3758         (dw2_debug_names_lookup_symbol): Don't pass argument for
3759         WANT_SPECIFIC_BLOCK.
3760         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3761         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3762         BLOCK_INDEX.
3763
3764 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3765
3766         * NEWS: Mention changes to "info sources" command.
3767
3768 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3769
3770         * symtab.c (filename_partial_match_opts): New struct type.
3771         (struct output_source_filename_data): New members
3772         regexp, c_regexp, partial_match.
3773         (output_source_filename): Use new members to decide to print file.
3774         (info_sources_option_defs): New variable.
3775         (make_info_sources_options_def_group, print_info_sources_header,
3776         info_sources_command_completer):
3777         New functions.
3778         (info_sources_command): Read new optional arguments.
3779         (_initialize_symtab): Update info sources help.
3780
3781 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3782
3783         * ada-lang.c (exception_support_info_v0): Renamed from...
3784         (default_exception_support_info): ... this.  Create new
3785         definition for v1.
3786         (ada_has_this_exception_support): Look up catch_handlers_sym.
3787         (ada_exception_support_info_sniffer): Try v0 after default.
3788
3789 2019-08-01  Tom Tromey  <tromey@adacore.com>
3790
3791         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3792         gdbarch.h.
3793
3794 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3795
3796         * s12z-tdep.c: Fix include path for s12z-opc.h.
3797
3798 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3799
3800         * NEWS: Require GNU make 3.82.
3801
3802 2019-07-16  Tom Tromey  <tom@tromey.com>
3803
3804         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3805         declare.
3806
3807 2019-07-30  Tom Tromey  <tromey@adacore.com>
3808
3809         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3810
3811 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3812
3813         * printcmd.c (print_address_symbolic): Print negative offsets.
3814         (build_address_symbolic): Force signed arithmetic when computing
3815         offset.
3816
3817 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3818
3819         PR/24474: Add a function to lookup static variables.
3820         * NEWS: Mention this new function.
3821         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3822         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3823         * python/python.c (python_GdbMethods): Add new function.
3824
3825 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3826
3827         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3828         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3829         (objfpy_lookup_static_symbol): New function.
3830         (objfile_object_methods): Add new functions.
3831
3832 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3833
3834         * NEWS: Mention 'set|show print frame-info'.  Mention new
3835         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3836         backtrace argument.  Mention that python frame filtering code
3837         is now consistent with what 'backtrace' command prints.
3838
3839 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3840
3841         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3842         comments.
3843         (print_frame_info_auto, print_frame_info_source_line,
3844         print_frame_info_location, print_frame_info_source_and_location,
3845         print_frame_info_location_and_address, print_frame_info_short_location):
3846         New declarations.
3847         (struct frame_print_options): New member print_frame_info.
3848         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3849         * stack.h (get_user_print_what_frame_info): New declaration.
3850         (frame_show_address): New declaration.
3851         * stack.c (print_frame_arguments_choices): New value 'presence'.
3852         (print_frame_info_auto, print_frame_info_source_line,
3853         print_frame_info_location, print_frame_info_source_and_location,
3854         print_frame_info_location_and_address, print_frame_info_short_location,
3855         print_frame_info_choices, print_frame_info_print_what): New definitions.
3856         (print_frame_args): Only print dots for args if print frame-arguments
3857         is 'presence'.
3858         (frame_print_option_defs): New element for "frame-info".
3859         (get_user_print_what_frame_info): New function.
3860         (frame_show_address): Make non static.  Move comment to stack.h.
3861         (print_frame_info_to_print_what): New function.
3862         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3863         to decide what to print.
3864         (backtrace_command_1): Handle the new print_frame_arguments_presence
3865         value.
3866         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3867         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3868         (py_print_frame): In non-mi mode, use LOCATION as default for
3869         print_what, similarly to frame information printed directly by
3870         backtrace command. Handle frame-info user option in non MI mode.
3871
3872 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3873
3874         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3875         Add case for debugging 32-bit target on 64-bit host.  Revise
3876         comment.
3877
3878 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3879
3880         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3881         instead of find_function_entry_range_from_pc.
3882
3883 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3884
3885         * stack.c (find_frame_funname): Remove code which preferred
3886         minsym over symtab sym in "certain pathological cases".
3887
3888         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3889         parameter.  Change type of "do_demangle" to bool.
3890         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3891         Pass suitable "prefer_sym_over_minsym" flag to
3892         build_address_symbolic().  Don't output "+" for negative offsets.
3893         * printcmd.c (print_address_symbolic): Update invocation of
3894         build_address_symbolic to include a "prefer_sym_over_minsym"
3895         flag.
3896         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3897         Restrict cases in which use of minimal symbol is preferred to that
3898         of a found symbol.  Update comments.
3899
3900         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3901         for entry pc when entry pc is out of range for that FDE.
3902
3903 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3904
3905         PR gdb/24839:
3906         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3907         type.
3908
3909 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3910
3911         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3912         this function's Python signature.
3913
3914
3915 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3916
3917         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3918         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3919         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3920         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3921         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3922
3923
3924 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3925
3926         * h8300-tdep.c (h8300_register_name_common): New.
3927         h8300_register_name): Use h8300_register_name_common.
3928         (h8300s_register_name): Likewise.
3929         (h8300sx_register_name): Likewise.
3930         (h8300h_register_nam): New.
3931         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3932
3933
3934 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3935
3936         * arm-tdep.c (arm_skip_cmse_entry): New function.
3937         (arm_is_sgstubs_section): New function.
3938         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3939
3940 2019-07-22  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3943         Don't self-assign.
3944
3945 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3948         type_print.
3949
3950 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3951
3952         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3953         so that GDB doesn't match any msymbols when searching in the
3954         TYPES_DOMAIN.
3955         (print_symbol_info): Print using typedef_print or type_print based
3956         on the type of the symbol.  Add updated FIXME comment moved from...
3957         (_initialize_symtab): ... move and update FIXME comment to above.
3958
3959 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3960
3961         * NEWS: Mention adding -q option to "info types".
3962         * symtab.c (struct info_types_options): New struct.
3963         (info_types_options_defs): New variable.
3964         (make_info_types_options_def_group): New function.
3965         (info_types_command): Use gdb::option framework to parse options.
3966         (info_types_command_completer): New function.
3967         (_initialize_symtab): Extend the help text on "info types" and
3968         register command completer.
3969
3970 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3971
3972         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3973         (lookup_symbol_in_objfile): Change int to block_enum and add a
3974         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3975
3976 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3977
3978         * MAINTAINERS (Write After Approval): Add self.
3979
3980 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3983         instruction to the dummy code region.
3984
3985 2019-07-19  Tom Tromey  <tromey@adacore.com>
3986
3987         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3988         (ARGSUSED, PARAMS, __func__): Remove rules.
3989
3990 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3991
3992         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3993         * features/arm/arm-with-iwmmxt.c: Remove.
3994         * features/arm/arm-with-iwmmxt.xml: Remove.
3995         * features/arm/arm-with-m-fpa-layout.c: Remove.
3996         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3997         * features/arm/arm-with-m-vfp-d16.c: Remove.
3998         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3999         * features/arm/arm-with-m.c: Remove.
4000         * features/arm/arm-with-m.xml: Remove.
4001         * features/arm/arm-with-neon.c: Remove.
4002         * features/arm/arm-with-neon.xml: Remove.
4003         * features/arm/arm-with-vfpv2.c: Remove.
4004         * features/arm/arm-with-vfpv2.xml: Remove.
4005         * features/arm/arm-with-vfpv3.c: Remove.
4006         * features/arm/arm-with-vfpv3.xml: Remove.
4007
4008 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4009
4010         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4011
4012 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4013
4014         * arch/aarch32.c (aarch32_create_target_description): Create
4015         target descriptions using features.
4016         * arch/arm.c (arm_create_target_description)
4017         (arm_create_mprofile_target_description): Likewise.
4018         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4019
4020 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4021
4022         * Makefile.in: Add new files.
4023         * aarch32-tdep.c: New file.
4024         * aarch32-tdep.h: New file.
4025         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4026         Call aarch32_read_description.
4027         * arch/aarch32.c: New file.
4028         * arch/aarch32.h: New file.
4029         * arch/arm.c (arm_create_target_description)
4030         (arm_create_mprofile_target_description): New function.
4031         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4032         (arm_create_target_description)
4033         (arm_create_mprofile_target_description): New declaration.
4034         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4035         read_description functions.
4036         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4037         Likewise.
4038         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4039         * arm-tdep.c (tdesc_arm_list): New variable.
4040         (arm_register_g_packet_guesses): Call create description functions.
4041         (arm_read_description) (arm_read_mprofile_description): New
4042         function.
4043         * arm-tdep.h (arm_read_description)
4044         (arm_read_mprofile_description): Add declaration.
4045         * configure.tgt: Add new files.
4046
4047 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4048
4049         * top.c (new_ui_command): Open specified terminal just once.
4050
4051 2019-07-18  Tom Tromey  <tromey@adacore.com>
4052
4053         * symtab.c (main_name): Constify return type.
4054         * symfile.c (set_initial_language): Update.
4055         * symtab.h (main_name): Constify return type.
4056
4057 2019-07-17  Tom Tromey  <tom@tromey.com>
4058
4059         * tui/tui-winsource.c (tui_update_source_window)
4060         (tui_update_source_window_as_is)
4061         (tui_update_source_windows_with_line): Remove return.
4062         * tui/tui-disasm.c (tui_show_disassem)
4063         (tui_show_disassem_and_update_source): Remove return.
4064         * tui/tui.c (tui_reset): Remove return.
4065         * tui/tui-wingeneral.c
4066         (tui_check_and_display_highlight_if_needed): Remove return.
4067
4068 2019-07-17  Tom Tromey  <tom@tromey.com>
4069
4070         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4071
4072 2019-07-17  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-winsource.h (struct tui_exec_info_window)
4075         (struct tui_source_window_base): Move from tui-data.h.
4076         * tui/tui-winsource.c: Move many method definitions from
4077         elsewhere.  Remove "structuring" comments.
4078         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4079         (tui_source_window_base::refresh_window): Move to
4080         tui-winsource.c.
4081         * tui/tui-win.c (tui_source_window_base::refresh_all)
4082         (tui_source_window_base::update_tab_width)
4083         (tui_source_window_base::set_new_height)
4084         (tui_source_window_base::do_make_visible_with_new_height): Move to
4085         tui-winsource.c.
4086         * tui/tui-source.h: Update.
4087         * tui/tui-source.c (tui_source_window_base::reset): Move to
4088         tui-winsource.c.
4089         * tui/tui-disasm.h: Update.
4090         * tui/tui-data.h (struct tui_exec_info_window): Move to
4091         tui-winsource.h.
4092         (struct tui_source_window_base): Likewise.
4093         * tui/tui-data.c (tui_source_window_base::clear_detail)
4094         (tui_source_window_base, ~tui_source_window_base): Move to
4095         tui-winsource.c.
4096
4097 2019-07-17  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-win.c (tui_resize_all)
4100         (tui_source_window_base::update_tab_width)
4101         (tui_adjust_win_heights): Update.
4102         (tui_win_info::make_invisible_and_set_new_height): Rename from
4103         make_invisible_and_set_new_height.
4104         * tui/tui-data.h (struct tui_win_info)
4105         <make_invisible_and_set_new_height>: New method.
4106
4107 2019-07-17  Tom Tromey  <tom@tromey.com>
4108
4109         * tui/tui.c: Update.
4110         * tui/tui-source.h (struct tui_source_window): Move from
4111         tui-data.h.
4112         * tui/tui-layout.c: Update.
4113         * tui/tui-disasm.c: Update.
4114         * tui/tui-data.h (struct tui_source_window): Move to
4115         tui-source.h.
4116
4117 2019-07-17  Tom Tromey  <tom@tromey.com>
4118
4119         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4120         tui-data.h.
4121         * tui/tui-data.h (struct tui_disasm_window): Move to
4122         tui-disasm.h.
4123
4124 2019-07-17  Tom Tromey  <tom@tromey.com>
4125
4126         * tui/tui-regs.h (struct tui_data_item_window): Move from
4127         tui-data.h.
4128         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4129         * tui/tui-data.h (struct tui_data_item_window): Move to
4130         tui-regs.h.
4131         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4132
4133 2019-07-17  Tom Tromey  <tom@tromey.com>
4134
4135         * tui/tui.c: Update.
4136         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4137         (tui_cmd_window::max_height): Move to tui-command.c.
4138         * tui/tui-layout.c: Update.
4139         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4140         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4141         tui-command.c.
4142         * tui/tui-command.h (struct tui_cmd_window): Move from
4143         tui-data.h.
4144         * tui/tui-command.c: Remove "structuring" comments.
4145         (tui_cmd_window::clear_detail)
4146         (tui_cmd_window::do_make_visible_with_new_height)
4147         (tui_cmd_window::max_height): Move from elsewhere.
4148
4149 2019-07-17  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4152         Now static.
4153         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4154         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4155
4156 2019-07-17  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui.c: Update.
4159         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4160         tui-regs.c.
4161         * tui/tui-windata.h: Remove file.
4162         * tui/tui-windata.c: Remove file.
4163         * tui/tui-win.c (tui_data_window::set_new_height)
4164         (tui_data_window::do_make_visible_with_new_height): Move to
4165         tui-regs.c.
4166         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4167         * tui/tui-regs.c: Remove "structuring" comments.
4168         (tui_data_window::first_data_item_displayed)
4169         (tui_data_window::delete_data_content_windows)
4170         (tui_data_window::erase_data_content)
4171         (tui_data_window::display_all_data)
4172         (tui_data_window::refresh_all)
4173         (tui_data_window::do_scroll_vertical)
4174         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4175         (tui_data_window::do_make_visible_with_new_height)
4176         (tui_data_window::refresh_window): Move from elsewhere.
4177         (_initialize_tui_regs): Move to end of file.
4178         * tui/tui-layout.c: Update.
4179         * tui/tui-hooks.c: Update.
4180         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4181         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4182         tui-regs.c.
4183         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4184
4185 2019-07-17  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4188         seen.
4189
4190 2019-07-17  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui-win.c (tui_source_window_base::set_new_height)
4193         (tui_source_window_base::do_make_visible_with_new_height): Use
4194         m_has_locator field directly.
4195         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4196         method.
4197         (struct tui_source_window_base) <has_locator>: Likewise.
4198
4199 2019-07-17  Tom Tromey  <tom@tromey.com>
4200
4201         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4202         Don't declare.
4203         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4204         Remove.
4205         * tui/tui-win.c (tui_source_window_base::set_new_height)
4206         (tui_source_window_base::set_new_height)
4207         (make_invisible_and_set_new_height)
4208         (tui_source_window_base::do_make_visible_with_new_height)
4209         (tui_source_window_base::do_make_visible_with_new_height):
4210         Update.
4211         * tui/tui-layout.c (show_source_disasm_command, show_data)
4212         (show_source_or_disasm_and_command): Update.
4213         * tui/tui-layout.c (show_layout): Update.
4214
4215 2019-07-17  Tom Tromey  <tom@tromey.com>
4216
4217         * tui/tui-layout.c (make_data_window): Remove.
4218         (show_data): Unify creation and re-initialization cases.
4219
4220 2019-07-17  Tom Tromey  <tom@tromey.com>
4221
4222         * tui/tui-layout.c (make_source_window, make_disasm_window):
4223         Remove.
4224         (show_data): Unify creation and re-initialization cases.
4225
4226 2019-07-17  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-layout.c (make_command_window): Remove.
4229         (show_source_disasm_command, show_source_or_disasm_and_command):
4230         Unify creation and re-initialization cases.
4231
4232 2019-07-17  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4235         creation and re-initialization cases.
4236
4237 2019-07-17  Tom Tromey  <tom@tromey.com>
4238
4239         * tui/tui-regs.c (tui_get_register): Return void.
4240
4241 2019-07-17  Tom Tromey  <tom@tromey.com>
4242
4243         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4244         Simplify.
4245
4246 2019-07-17  Tom Tromey  <tom@tromey.com>
4247
4248         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4249         resetting.
4250
4251 2019-07-17  Tom Tromey  <tom@tromey.com>
4252
4253         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4254         * tui/tui-regs.c (tui_reg_layout): New function.
4255         (tui_show_registers, tui_reg_command): Use it.
4256         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4257         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4258         parameters.
4259         (tui_layout_command): Remove.
4260
4261 2019-07-17  Tom Tromey  <tom@tromey.com>
4262
4263         * tui/tui-layout.h (tui/tui-layout): Return void.
4264         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4265
4266 2019-07-17  Tom Tromey  <tom@tromey.com>
4267
4268         * tui/tui-layout.c (show_source_disasm_command, show_data):
4269         Update.
4270         (reset_locator): Remove.
4271         (show_source_or_disasm_and_command): Update.
4272
4273 2019-07-17  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-source.c (tui_source_window_base::reset): Remove
4276         win_type parameter.
4277         * tui/tui-layout.c (make_command_window, make_source_window)
4278         (make_disasm_window, make_data_window)
4279         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4280         (reset_locator, show_source_or_disasm_and_command): Update.
4281         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4282         win_type parameter.
4283         (struct tui_source_window_base) <reset>: Likewise.
4284
4285 2019-07-17  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-layout.c (show_source_disasm_command): Use
4288         reset_locator.
4289         (reset_locator): New function.
4290         (init_and_make_win): Remove.
4291         (show_source_or_disasm_and_command): Use reset_locator.
4292
4293 2019-07-17  Tom Tromey  <tom@tromey.com>
4294
4295         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4296         condition.
4297         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4298         Remove condition.
4299         * tui/tui-source.c (tui_source_window_base::reset): New method.
4300         * tui/tui-layout.c (make_command_window): Don't call
4301         init_and_make_win.
4302         (make_source_window, make_disasm_window): Don't call
4303         make_source_or_disasm_window.
4304         (make_data_window): Don't call init_and_make_win.  Change calling
4305         convention.
4306         (show_source_disasm_command, show_data): Simplify.
4307         (make_source_or_disasm_window): Remove.
4308         (show_source_or_disasm_and_command): Simplify.
4309         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4310         (struct tui_source_window_base) <reset>: Likewise.
4311         <execution_info>: Remove initializer.
4312         * tui/tui-data.c (tui_source_window_base): Initialize
4313         execution_info.
4314
4315 2019-07-17  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4318         variable.
4319
4320 2019-07-17  Tom Tromey  <tom@tromey.com>
4321
4322         * tui/tui.c (tui_rl_other_window): Update.
4323         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4324         superclass method first.  Always iterate over regs_content.
4325         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4326         method.
4327         * tui/tui-win.c (tui_set_focus_command): Update.
4328
4329 2019-07-17  Tom Tromey  <tom@tromey.com>
4330
4331         * tui/tui-win.c (tui_set_focus_command): Rename from
4332         tui_set_focus.  Call tui_enable.
4333         (tui_set_focus_command): Remove.
4334
4335 2019-07-17  Tom Tromey  <tom@tromey.com>
4336
4337         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4338         refresh_window.
4339         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4340         touchwin.
4341         (tui_data_window::refresh_window): Call refresh_window on data
4342         items.  Always call superclass refresh_window.
4343         (tui_win_info::refresh): Remove.
4344         (tui_source_window_base::refresh_window): Update.
4345         (tui_refresh_all): Update.
4346         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4347         refresh_window.
4348         (show_source_or_disasm_and_command): Likewise.
4349         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4350         (struct tui_source_window_base) <refresh>: Likewise.
4351
4352 2019-07-17  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui-winsource.c (tui_clear_source_content)
4355         (tui_show_source_content): Update.
4356         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4357         whether content is empty.
4358         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4359         Remove.
4360
4361 2019-07-17  Tom Tromey  <tom@tromey.com>
4362
4363         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4364         window's contents.
4365         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4366         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4367
4368 2019-07-17  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4371         (struct tui_data_item_window): Update.
4372
4373 2019-07-17  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4376         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4377         defines.
4378
4379 2019-07-17  Tom Tromey  <tom@tromey.com>
4380
4381         * tui/tui-winsource.h (tui_erase_source_content)
4382         (tui_clear_source_content): Remove "display_prompt" parameter.
4383         * tui/tui-winsource.c (tui_update_source_window_as_is)
4384         (tui_update_source_windows_with_addr): Update.
4385         (tui_clear_source_content): Remove "display_prompt" parameter.
4386         (tui_erase_source_content): Likewise.  Simplify.
4387         (tui_show_source_content): Update.
4388         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4389         * tui/tui-stack.c (tui_show_frame_info): Update.
4390         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4391         Remove defines.
4392
4393 2019-07-17  Tom Tromey  <tom@tromey.com>
4394
4395         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4396         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4397         parameter.
4398         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4399         parameter.
4400
4401 2019-07-17  Tom Tromey  <tom@tromey.com>
4402
4403         * tui/tui-winsource.c (tui_clear_source_content)
4404         (tui_show_source_content, tui_show_exec_info_content)
4405         (tui_clear_exec_info_content): Update.
4406         * tui/tui-stack.c (tui_show_locator_content): Update.
4407         (tui_show_frame_info): Update.
4408         * tui/tui-source.h (tui_source_window): Don't declare.
4409         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4410         from tui_source_is_displayed.
4411         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4412         Remove field.
4413         (struct tui_source_window_base) <content_in_use>: New field.  Now
4414         bool.
4415         (struct tui_source_window) <showing_source_p>: New method.
4416         (TUI_SRC_WIN): Change cast.
4417         * tui/tui-data.c (tui_initialize_static_data): Update.
4418
4419 2019-07-17  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4422         location_matches_p.
4423         * tui/tui-source.c (tui_source_window::location_matches_p): New
4424         method.
4425         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4426         method.
4427         * tui/tui-data.h (struct tui_source_window_base)
4428         <location_matches_p>: New method.
4429         (struct tui_source_window, struct tui_disasm_window)
4430         <location_matches_p>: Likewise.
4431
4432 2019-07-17  Tom Tromey  <tom@tromey.com>
4433
4434         * tui/tui-win.c (tui_set_win_height_command): Rename from
4435         tui_set_win_height.
4436         (tui_set_win_height_command): Remove.
4437
4438 2019-07-17  Tom Tromey  <tom@tromey.com>
4439
4440         * tui/tui-source.c (tui_source_window): New constructor.  Add
4441         observer.
4442         (~tui_source_window): New destructor.
4443         (tui_source_window::style_changed): New method.
4444         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4445         (tui_attach_detach_observers): Update.
4446         * tui/tui-data.h (struct tui_source_window): Make constructor not
4447         inline.  Add destructor.
4448         (struct tui_source_window) <style_changed>: New method.
4449         <m_observable>: New member.
4450
4451 2019-07-17  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4454         * tui/tui-win.c (tui_resize_all): Fix typo.
4455
4456 2019-07-17  Tom Tromey  <tom@tromey.com>
4457
4458         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4459         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4460         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4461         * tui/tui-win.c (window_name_completer): Use foreach.
4462         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4463         (update_tab_width): Likewise.
4464         * tui/tui-layout.c (show_layout): Update.
4465         * tui/tui-data.h (class tui_window_iterator): New.
4466         (struct all_tui_windows): New.
4467         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4468
4469 2019-07-17  Tom Tromey  <tom@tromey.com>
4470
4471         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4472         parameter.  Don't reference globals.
4473         (tui_reg_command): Update.
4474
4475 2019-07-17  Tom Tromey  <tom@tromey.com>
4476
4477         * tui/tui-regs.c (tui_show_registers): Simplify.
4478
4479 2019-07-17  Tom Tromey  <tom@tromey.com>
4480
4481         * tui/tui-regs.c (tui_show_registers): Update.
4482         (tui_show_register_group): Add win_info parameter.
4483
4484 2019-07-17  Tom Tromey  <tom@tromey.com>
4485
4486         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4487         Rename from tui_display_reg_element_at_line.
4488         (tui_data_window::display_registers_from_line): Update.
4489         * tui/tui-data.h (struct tui_data_window)
4490         <display_reg_element_at_line>: New method.
4491
4492 2019-07-17  Tom Tromey  <tom@tromey.com>
4493
4494         * tui/tui-regs.h (tui_display_registers_from)
4495         (tui_display_registers_from_line): Don't declare.
4496         * tui/tui-windata.c (tui_data_window::display_all_data)
4497         (tui_data_window::refresh_all)
4498         (tui_data_window::do_scroll_vertical): Update.
4499         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4500         from tui_display_registers_from.
4501         (tui_display_reg_element_at_line): Update.
4502         (tui_data_window::display_registers_from_line): Rename from
4503         tui_display_registers_from_line.
4504         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4505         display_registers_from_line>: New methods.
4506
4507 2019-07-17  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4510         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4511         from tui_erase_data_content.
4512         (tui_data_window::display_all_data)
4513         (tui_data_window::refresh_all)
4514         (tui_data_window::do_scroll_vertical): Update.
4515         * tui/tui-regs.c (tui_show_registers): Update.
4516         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4517         New method.
4518
4519 2019-07-17  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4522         declare.
4523         * tui/tui-windata.c
4524         (tui_data_window::delete_data_content_windows): Rename from
4525         tui_delete_data_content_windows.
4526         (tui_data_window::display_all_data)
4527         (tui_data_window::do_scroll_vertical): Update.
4528         * tui/tui-data.h (struct tui_data_window)
4529         <delete_data_content_windows>: New method.
4530
4531 2019-07-17  Tom Tromey  <tom@tromey.com>
4532
4533         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4534         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4535
4536 2019-07-17  Tom Tromey  <tom@tromey.com>
4537
4538         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4539         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4540         from tui_display_all_data.
4541         * tui/tui-win.c
4542         (tui_data_window::do_make_visible_with_new_height): Update.
4543         * tui/tui-regs.c (tui_show_registers): Update.
4544         * tui/tui-layout.c (tui_set_layout): Update.
4545         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4546         method.
4547
4548 2019-07-17  Tom Tromey  <tom@tromey.com>
4549
4550         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4551         * tui/tui-windata.c (tui_display_data_from): Remove.
4552         (tui_data_window::refresh_all): Update.
4553
4554 2019-07-17  Tom Tromey  <tom@tromey.com>
4555
4556         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4557         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4558         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4559         tui_display_registers_from_line.
4560         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4561         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4562         "force_display" parameter.
4563
4564 2019-07-17  Tom Tromey  <tom@tromey.com>
4565
4566         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4567         declare.
4568         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4569         Rename from tui_first_reg_element_no_inline.
4570         (tui_display_reg_element_at_line)
4571         (tui_display_registers_from_line): Update.
4572         * tui/tui-data.h (struct tui_data_window)
4573         <first_reg_element_no_inline>: New method.
4574
4575 2019-07-17  Tom Tromey  <tom@tromey.com>
4576
4577         * tui/tui-windata.c (tui_display_data_from)
4578         (tui_data_window::do_scroll_vertical): Update.
4579         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4580         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4581         Rename from tui_line_from_reg_element_no.
4582         (tui_display_registers_from_line): Update.
4583         * tui/tui-data.h (struct tui_data_window)
4584         <line_from_reg_element_no>: New method.
4585
4586 2019-07-17  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4589         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4590         tui_last_regs_line_no.
4591         (tui_display_reg_element_at_line)
4592         (tui_display_registers_from_line): Update.
4593         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4594         method.
4595
4596 2019-07-17  Tom Tromey  <tom@tromey.com>
4597
4598         PR tui/24722:
4599         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4600         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4601         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4602         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4603         (tui_update_breakpoint_info): Likewise.
4604         * tui/tui-hooks.c (tui_event_create_breakpoint)
4605         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4606         Update.
4607
4608 2019-07-17  Tom Tromey  <tom@tromey.com>
4609
4610         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4611
4612 2019-07-17  Tom Tromey  <tom@tromey.com>
4613
4614         * tui/tui-winsource.c (tui_update_source_window_as_is)
4615         (tui_update_source_windows_with_addr): Update.
4616         * tui/tui-source.h (tui_set_source_content)
4617         (tui_show_symtab_source): Add "win_info" parameter.
4618         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4619         parameter.
4620         (tui_show_symtab_source): Likewise.
4621
4622 2019-07-17  Tom Tromey  <tom@tromey.com>
4623
4624         * tui/tui-wingeneral.c
4625         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4626
4627 2019-07-17  Tom Tromey  <tom@tromey.com>
4628
4629         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4630         (struct tui_cmd_window) <can_scroll>: New method.
4631         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4632         method.
4633
4634 2019-07-17  Tom Tromey  <tromey@adacore.com>
4635
4636         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4637         do_field_signed>: Rename.  Change type of "value".
4638         * ui-out.c (ui_out::field_signed): Rename from field_int.
4639         Change type of "value".
4640         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4641         type of "value".
4642         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4643         do_field_int.  Change type of "value".
4644         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4645         do_field_int.  Change type of "value".
4646         * tracepoint.c (trace_status_mi, tfind_1)
4647         (print_one_static_tracepoint_marker): Update.
4648         * thread.c (print_thread_info_1, print_selected_thread_frame):
4649         Update.
4650         * stack.c (print_frame, print_frame_info): Update.
4651         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4652         Update.
4653         * source.c (print_source_lines_base): Update.
4654         * skip.c (info_skip_command): Update.
4655         * record-btrace.c (btrace_ui_out_decode_error)
4656         (btrace_call_history_src_line): Update.
4657         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4658         Update.
4659         * progspace.c (print_program_space): Update.
4660         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4661         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4662         do_field_int.  Change type of "value".
4663         * mi/mi-out.c (mi_ui_out::do_table_begin)
4664         (mi_ui_out::do_table_header): Update.
4665         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4666         type of "value".
4667         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4668         (mi_cmd_data_list_changed_registers, output_register)
4669         (mi_cmd_data_read_memory, mi_load_progress)
4670         (mi_cmd_trace_frame_collected): Update.
4671         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4672         Update.
4673         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4674         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4675         (mi_cmd_var_list_children, varobj_update_one): Update.
4676         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4677         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4678         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4679         * inferior.c (print_inferior): Update.
4680         * gdb_bfd.c (print_one_bfd): Update.
4681         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4682         Update.
4683         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4684         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4685         do_field_int.  Change type of "value".
4686         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4687         do_field_int.  Change type of "value".
4688         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4689         (print_one_breakpoint_location, print_it_catch_fork)
4690         (print_one_catch_fork, print_it_catch_vfork)
4691         (print_one_catch_vfork, print_it_catch_solib)
4692         (print_it_catch_exec, print_it_ranged_breakpoint)
4693         (print_mention_watchpoint, print_mention_masked_watchpoint)
4694         (bkpt_print_it, update_static_tracepoint): Update.
4695         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4696         * break-catch-syscall.c (print_it_catch_syscall): Update.
4697         * ada-tasks.c (print_ada_task_info): Update.
4698         * ada-lang.c (print_it_exception, print_mention_exception):
4699         Update.
4700
4701 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4702
4703         PR breakpoints/24541
4704         * gdbarch.c: Regenerate.
4705         * gdbarch.h: Regenerate.
4706         * gdbarch.sh: Adjust return type and parameter types for
4707         'stap_adjust_register'.
4708         (i386_stap_adjust_register): Adjust signature and return new
4709         register name.
4710         * stap-probe.c (stap_parse_register_operand): Adjust use of
4711         'gdbarch_stap_adjust_register'.
4712
4713 2019-07-17  Tom Tromey  <tromey@adacore.com>
4714
4715         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4716         declare VEC.
4717         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4718         std::vector.
4719         (struct s390_process_info): Add initializers.
4720         (s390_add_process): Use new.
4721         (s390_linux_nat_target::low_forget_process): Use delete.
4722         (s390_linux_nat_target::low_new_fork)
4723         (s390_linux_nat_target::stopped_by_watchpoint)
4724         (s390_linux_nat_target::low_prepare_to_resume)
4725         (s390_linux_nat_target::insert_watchpoint)
4726         (s390_linux_nat_target::insert_hw_breakpoint)
4727         (s390_linux_nat_target::remove_watchpoint)
4728         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4729
4730 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4731
4732         * aarch64-fbsd-nat.c: Include regcache.h.
4733         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4734         argument.
4735         (aarch64_fbsd_nat_target::fetch_registers)
4736         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4737         variable.
4738         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4739
4740 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4741
4742         * fbsd-nat.c: Include gdbarch.h.
4743
4744 2019-07-15  Tom Tromey  <tromey@adacore.com>
4745
4746         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4747
4748 2019-07-15  Tom Tromey  <tromey@adacore.com>
4749
4750         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4751         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4752         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4753         * cli-out.c (cli_ui_out::do_field_int): New method.
4754         * ui-out.c (ui_out::field_unsigned): New method.
4755         * symfile.c (generic_load): Use field_unsigned.
4756         (print_transfer_performance): Likewise.
4757         * record-btrace.c (ui_out_field_uint): Remove.
4758         (btrace_call_history_insn_range, btrace_call_history): Use
4759         field_unsigned.
4760         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4761         field_unsigned.
4762         * ui-out.h (class ui_out) <field_unsigned>: New method.
4763         <do_field_unsigned>: Likewise.
4764
4765 2019-07-15  Tom Tromey  <tromey@adacore.com>
4766
4767         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4768         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4769         * target.c (flash_erase_command): Use field_string.
4770         * infrun.c (print_signal_received_reason): Use field_string.
4771         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4772         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4773         field_string.
4774         * ada-tasks.c (print_ada_task_info): Use field_string.
4775
4776 2019-07-15  Tom Tromey  <tromey@adacore.com>
4777
4778         * target.c (flash_erase_command): Use field_core_addr.
4779         * symfile.c (generic_load): Use field_core_addr.
4780         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4781         Use field_core_addr.
4782         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4783         field_core_addr.
4784
4785 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4786
4787         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4788         value if its desired type is smaller than a CORE_ADDR and signed.
4789
4790 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4791
4792         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4793         of changes to field names, and use new is_reference field to
4794         decide if a property is a reference or not.
4795         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4796         field.
4797         (struct dwarf2_property_baton): Update header comment, rename
4798         'referenced_type' to 'property_type' and update comments.
4799         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4800         default property type, store in property baton, update to take
4801         accound of renamed field.
4802         (read_func_scope): Update call to attr_to_dynamic_prop.
4803         (read_array_type): Likewise.
4804         (dwarf2_per_cu_addr_sized_int_type): New function.
4805         (read_subrange_index_type): Move type finding code to
4806         dwarf2_per_cu_addr_sized_int_type.
4807         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4808         (dwarf2_per_cu_addr_type): New function.
4809         (set_die_type): Update calls to attr_to_dynamic_prop.
4810
4811 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4812
4813         * dwarf2read.c (read_subrange_index_type): New function.
4814         (read_subrange_type): Move code into new function and call it.
4815         * gdbtypes.c (create_range_type): Add some asserts.
4816
4817 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4820         update return statements.
4821         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4822         declaration, and update comment to match.
4823         * gdbtypes.c (resolve_dynamic_array): Update call to
4824         dwarf2_evaluate_property to match new return type.
4825
4826 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4827
4828         * valarith.c (value_subscripted_rvalue): Change lowerbound
4829         parameter type from int to LONGEST.
4830         * value.h (value_subscripted_rvalue): Likewise in declaration.
4831
4832 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4833
4834         * cli/cli-utils.c (info_print_command_completer): New function.
4835         * cli/cli-utils.h: Add 'completer.h' include, and forward
4836         declaration for 'struct cmd_list_element'.
4837         (info_print_command_completer): Declare.
4838         * stack.c (_initialize_stack): Add completer for 'info locals' and
4839         'info args'.
4840         * symtab.c (_initialize_symtab): Add completer for 'info
4841         variables' and 'info functions'.
4842         * NEWS: Mention completion for additional info commands.
4843
4844 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4845
4846         * cli/cli-utils.c (extract_info_print_args): Delete.
4847         (extract_arg_maybe_quoted): Delete.
4848         (info_print_options_defs): New variable.
4849         (make_info_print_options_def_group): New function.
4850         (extract_info_print_options): Define new function.
4851         * cli/cli-utils.h (extract_info_print_args): Delete.
4852         (struct info_print_options): New structure.
4853         (extract_info_print_options): Declare new function.
4854         * stack.c (info_locals_command): Update to use new
4855         extract_info_print_options, also add a header comment.
4856         (info_args_command): Likewise.
4857         * symtab.c (info_variables_command): Likewise.
4858         (info_functions_command): Likewise.
4859
4860 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4863         to extract string arguments.
4864         * common/common-utils.c (extract_string_maybe_quoted): New function.
4865         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4866
4867 2019-07-11  Tom Tromey  <tromey@adacore.com>
4868
4869         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4870         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4871         * top.h (gdbinit): Don't declare.
4872         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4873         into...
4874         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4875         * top.c (gdb_init): Don't call init_cli_cmds.
4876         (gdbinit): Remove.
4877         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4878
4879 2019-07-11  Tom Tromey  <tromey@adacore.com>
4880
4881         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4882         after it has been moved.
4883
4884 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4885
4886         * valops.c (value_must_coerce_to_target): Change return type to
4887         bool.
4888         * value.h (value_must_coerce_to_target): Likewise.
4889
4890 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4891
4892         * breakpoint.c (is_hardware_watchpoint): Remove
4893         forward-declaration.
4894         (is_masked_watchpoint): Change return type to bool.
4895         (is_tracepoint): Likewise.
4896         (is_breakpoint): Likewise.
4897         (is_hardware_watchpoint): Likewise.
4898         (is_watchpoint): Likewise.
4899         (is_no_memory_software_watchpoint): Likewise.
4900         (is_catchpoint): Likewise.
4901         (breakpoint_1): Make FILTER parameter's return type bool.
4902         is_masked_watchpoint): Change return type to bool.
4903         (save_breakpoints): Make FILTER parameter's return type bool.
4904         * breakpoint.h (is_breakpoint): Change return type to bool.
4905         (is_watchpoint): Likewise.
4906         (is_catchpoint): Likewise.
4907         (is_tracepoint): Likewise.
4908
4909 2019-07-10  Tom Tromey  <tom@tromey.com>
4910
4911         * defs.h: Don't include gdbarch.h.
4912         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4913         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4914         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4915         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4916         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4917         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4918         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4919         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4920         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4921         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4922         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4923         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4924         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4925         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4926         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4927         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4928         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4929         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4930         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4931         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4932         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4933         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4934         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4935         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4936         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4937         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4938         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4939
4940 2019-07-10  Tom Tromey  <tromey@adacore.com>
4941
4942         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4943         * breakpoint.c (init_ada_exception_breakpoint): Register as
4944         bp_catchpoint.
4945         (print_one_breakpoint_location, print_one_breakpoint): Use
4946         is_ada_exception_catchpoint.
4947         * ada-lang.c (class ada_catchpoint_location): Pass
4948         bp_loc_software_breakpoint to bp_location constructor.
4949         (is_ada_exception_catchpoint): New function.
4950
4951 2019-07-10  Tom Tromey  <tromey@adacore.com>
4952
4953         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4954         VEC.
4955         (struct arm_exidx_entry): New method operator<.
4956         (struct arm_exidx_data) <section_maps>: Change type.
4957         (arm_exidx_data_free): Remove.
4958         (arm_exidx_data_key): Change type.  Move lower.
4959         (arm_exidx_new_objfile): Update.
4960         (arm_compare_exidx_entries): Remove.
4961         (arm_find_exidx_entry, _initialize_arm_tdep)
4962
4963 2019-07-10  Tom Tromey  <tromey@adacore.com>
4964
4965         * solib-spu.c (ocl_program_data_key): Change type.
4966         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4967         Update.
4968
4969 2019-07-10  Tom Tromey  <tromey@adacore.com>
4970
4971         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4972         (struct solib_aix_inferior_data) <library_list>: Change type.
4973         (solib_aix_inferior_data_handle): Change type.
4974         (get_solib_aix_inferior_data): Update.
4975         (solib_aix_free_library_list): Remove.
4976         (library_list_start_library): Update.
4977         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4978         return type.
4979         (solib_aix_get_library_list)
4980         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4981         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4982
4983 2019-07-10  Tom Tromey  <tromey@adacore.com>
4984
4985         * solib-dsbt.c (struct dsbt_info): Add initializers.
4986         (solib_dsbt_pspace_data): Change type.
4987         (dsbt_pspace_data_cleanup): Remove.
4988         (get_dsbt_info, _initialize_dsbt_solib): Update.
4989
4990 2019-07-10  Tom Tromey  <tromey@adacore.com>
4991
4992         * spu-tdep.c (spu_overlay_data): Change type.
4993         (spu_get_overlay_table, spu_overlay_new_objfile)
4994         (_initialize_spu_tdep): Update.
4995
4996 2019-07-10  Tom Tromey  <tromey@adacore.com>
4997
4998         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4999         destructor.
5000         (dbx_objfile_data_key): Change type and declare later.
5001         (DBX_SYMFILE_INFO): Rewrite.
5002         * dbxread.c (dbx_objfile_data_key): Change type.
5003         (dbx_symfile_init): Update.
5004         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5005         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5006         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5007
5008 2019-07-10  Tom Tromey  <tromey@adacore.com>
5009
5010         * jit.c (jit_program_space_key): Change type.  Move lower.
5011         (get_jit_program_space_data): Update.
5012         (jit_program_space_data_cleanup): Remove.
5013         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5014         Update.
5015         (struct jit_program_space_data): Add initializers.
5016
5017 2019-07-10  Tom Tromey  <tromey@adacore.com>
5018
5019         * solib-darwin.c (struct darwin_info): Add initializers.
5020         (solib_darwin_pspace_data): Change type.
5021         (darwin_pspace_data_cleanup): Remove.
5022         (get_darwin_info, _initialize_darwin_solib): Update.
5023
5024 2019-07-10  Tom Tromey  <tromey@adacore.com>
5025
5026         * remote-sim.c (struct sim_inferior_data): Add initializers,
5027         constructor, and destructor.
5028         (sim_inferior_data_key): Change type.  Move lower.
5029         (check_for_duplicate_sim_descriptor): Update.
5030         (get_sim_inferior_data): Use new.  Update.
5031         (~sim_inferior_data_cleanup): Rename from
5032         sim_inferior_data_cleanup.  Simplify.
5033         (gdbsim_close_inferior, simulator_command)
5034         (sim_command_completer, _initialize_remote_sim): Update.
5035         (next_pid, INITIAL_PID): Move earlier.
5036
5037 2019-07-10  Tom Tromey  <tromey@adacore.com>
5038
5039         * python/python-internal.h (create_thread_object): Return
5040         gdbpy_ref.
5041         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5042         * python/py-inferior.c (struct threadlist_entry): Add
5043         constructor.
5044         <thread_obj>: Now a gdbpy_ref.
5045         (thread_to_thread_object): Update.
5046         (add_thread_object): Use new.
5047         (delete_thread_object): Use delete.
5048         (infpy_threads): Update.
5049         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5050         GIL.
5051
5052 2019-07-10  Tom Tromey  <tromey@adacore.com>
5053
5054         * valops.c (value_cast): Specialize error message for Ada.
5055
5056 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5057
5058         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5059
5060 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5061
5062         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5063         bpstat_should_step): Return bool, adjust comments.
5064         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5065         bpstat_should_step): Likewise.
5066
5067 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5068
5069         * features/Makefile: Use feature target descriptions for Arm.
5070         * features/arm/arm-core.c: Generate new file.
5071         * features/arm/arm-fpa.c: Likewise.
5072         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5073         * features/arm/arm-m-profile.c: Likewise.
5074         * features/arm/arm-vfpv2.c: Likewise.
5075         * features/arm/arm-vfpv3.c: Likewise.
5076         * features/arm/xscale-iwmmxt.c: Likewise.
5077         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5078
5079 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5080
5081         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5082         ptrace earlier.
5083
5084 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5085
5086         * features/aarch64-pauth.c: Regenerate.
5087
5088 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5089
5090         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5091         bool.
5092         (bpstat_what): Use false instead of 0.
5093
5094 2019-07-09  Pedro Alves  <palves@redhat.com>
5095
5096         * break-catch-throw.c (is_exception_catchpoint): New.
5097         * breakpoint.c (print_one_breakpoint_location): New parameter
5098         'raw_loc'.  Handle it.  Use
5099         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5100         looking at the breakpoint's type.
5101         (print_one_breakpoint): If handling "maint info breakpoints", also
5102         print locations of exception catchpoints.
5103         * breakpoint.h (is_exception_catchpoint): Declare.
5104
5105 2019-07-09  Pedro Alves  <palves@redhat.com>
5106
5107         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5108         "addr" field.
5109         (allocate_location_exception_catchpoint): New.
5110         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5111         (initialize_throw_catchpoint_ops): Install
5112         allocate_location_exception_catchpoint as allocate_location
5113         method.
5114         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5115         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5116         bp_loc_other.
5117         (breakpoint_address_is_meaningful): Delete.
5118         (bl_address_is_meaningful): New.
5119         (breakpoint_locations_match): Adjust comment.
5120         (bp_location_from_bp_type): New, factored out of...
5121         (bp_location::bp_location(breakpoint *)): ... this.
5122         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5123         factored out of...
5124         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5125         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5126         breakpoint_address_is_meaningful.
5127         (bp_locations_compare): Adjust comment.
5128         (update_global_location_list): Use bl_address_is_meaningful
5129         instead of breakpoint_address_is_meaningful.
5130         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5131         explicit.
5132         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5133         * python/py-breakpoint.c (bppy_get_location): No longer check
5134         whether location is null.
5135
5136 2019-07-09  Pedro Alves  <palves@redhat.com>
5137
5138         PR c++/15468
5139         * breakpoint.c (print_one_breakpoint_location): Remove
5140         single-location assert.
5141
5142 2019-07-09  Tom Tromey  <tom@tromey.com>
5143
5144         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5145         * configure: Rebuild.
5146         * configure.ac: Change common to gdbsupport.
5147         * gdbsupport: Rename from common.
5148         * acinclude.m4: Change common to gdbsupport.
5149         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5150         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5151         gdbsupport.
5152         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5153         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5154         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5155         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5156         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5157         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5158         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5159         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5160         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5161         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5162         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5163         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5164         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5165         coff-pe-read.c, command.h, compile/compile-c-support.c,
5166         compile/compile-c.h, compile/compile-cplus-symbols.c,
5167         compile/compile-cplus-types.c, compile/compile-cplus.h,
5168         compile/compile-loc2c.c, compile/compile.c, completer.c,
5169         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5170         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5171         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5172         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5173         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5174         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5175         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5176         features/aarch64-core.c, features/aarch64-fpu.c,
5177         features/aarch64-pauth.c, features/aarch64-sve.c,
5178         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5179         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5180         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5181         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5182         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5183         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5184         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5185         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5186         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5187         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5188         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5189         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5190         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5191         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5192         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5193         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5194         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5195         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5196         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5197         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5198         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5199         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5200         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5201         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5202         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5203         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5204         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5205         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5206         minsyms.c, mips-linux-tdep.c, namespace.h,
5207         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5208         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5209         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5210         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5211         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5212         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5213         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5214         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5215         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5216         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5217         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5218         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5219         procfs.c, producer.c, progspace.h, psymtab.h,
5220         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5221         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5222         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5223         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5224         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5225         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5226         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5227         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5228         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5229         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5230         target-memory.c, target.c, target.h, target/waitstatus.c,
5231         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5232         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5233         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5234         unittests/array-view-selftests.c,
5235         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5236         unittests/common-utils-selftests.c,
5237         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5238         unittests/format_pieces-selftests.c,
5239         unittests/function-view-selftests.c,
5240         unittests/lookup_name_info-selftests.c,
5241         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5242         unittests/mkdir-recursive-selftests.c,
5243         unittests/observable-selftests.c,
5244         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5245         unittests/parse-connection-spec-selftests.c,
5246         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5247         unittests/scoped_fd-selftests.c,
5248         unittests/scoped_mmap-selftests.c,
5249         unittests/scoped_restore-selftests.c,
5250         unittests/string_view-selftests.c, unittests/style-selftests.c,
5251         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5252         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5253         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5254         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5255         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5256         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5257
5258 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5261         bool value.
5262         (decode_digits_ordinary): Set explicit_line field in sal.
5263         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5264         symtab_and_line that was set on an explicit line number in
5265         assembler code.  Do always update the recorded symtab and line if
5266         we do skip the prologue.
5267
5268 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5269
5270         * breakpoint.c (set_breakpoint_location_function): Remove
5271         explicit_loc parameter.
5272         (momentary_breakpoint_from_master): Update call to
5273         set_breakpoint_location_function.
5274         (add_location_to_breakpoint): Likewise.
5275
5276 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5277
5278         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5279         required features based on default bfd type when no specific bfd
5280         is present.
5281
5282 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5283
5284         * NEWS: Mention that GDB printf and eval commands can now print
5285         C-style and Ada-style convenience var strings without
5286         calling the inferior.
5287         * printcmd.c (printf_c_string): Locally print GDB internal var
5288         instead of transiting via the inferior.
5289         (printf_wide_c_string): Likewise.
5290
5291 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5292
5293         PR breakpoints/25011
5294         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5295
5296 2019-07-04  Tom Tromey  <tom@tromey.com>
5297
5298         PR tui/24724:
5299         * tui/tui-winsource.c (tui_clear_source_content): Update.
5300         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5301         (tui_update_breakpoint_info): Update.
5302         (tui_set_exec_info_content): Update.
5303         * tui/tui-source.c (tui_set_source_content_nil): Update.
5304         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5305         has_break.
5306         * tui/tui-data.h (enum tui_bp_flag): New.
5307         (tui_bp_flags): New enum flags type.
5308         (struct tui_source_element) <break_mode>: Change type.  Rename
5309         from has_break.
5310         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5311         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5312         constants.
5313         * tui/tui-winsource.h: Fix comment.
5314
5315 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5316
5317         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5318         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5319         (store_fpregs_to_thread)
5320         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5321         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5322         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5323         (IWMMXT_REGS_SIZE): Add define.
5324         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5325         (fetch_vfp_regs, store_vfp_regs)
5326         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5327         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5328
5329 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5330
5331         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5332         defines.
5333         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5334         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5335         (ARM_INT_REGISTER_SIZE): ...to this.
5336         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5337         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5338         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5339         (arm_linux_collect_gregset, supply_nwfpe_register)
5340         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5341         defines.
5342         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5343         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5344         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5345         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5346         (arm_return_in_memory, arm_store_return_value)
5347         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5348         (arm_record_ld_st_multiple): Likewise.
5349         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5350         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5351
5352 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5353
5354         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5355         AARCH64_DISPLACED_MODIFIED_INSNS.
5356         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5357         (aarch64_displaced_step_copy_insn): Likewise.
5358         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5359         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5360         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5361         ARM_DISPLACED_MODIFIED_INSNS.
5362         * arm-tdep.c (arm_gdbarch_init): Likewise.
5363         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5364         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5365         (struct arm_displaced_step_closure): Use
5366         ARM_DISPLACED_MODIFIED_INSNS.
5367
5368 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5369
5370         * features/Makefile: Remove unused xml files.
5371         * features/aarch64.xml: Remove.
5372         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5373         * features/i386/amd64-avx-avx512.xml: Remove.
5374         * features/i386/amd64-avx-linux.xml: Remove.
5375         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5376         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5377         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5378         * features/i386/amd64-avx-mpx.xml: Remove.
5379         * features/i386/amd64-avx.xml: Remove.
5380         * features/i386/amd64-linux.xml: Remove.
5381         * features/i386/amd64-mpx-linux.xml: Remove.
5382         * features/i386/amd64-mpx.xml: Remove.
5383         * features/i386/amd64.xml: Remove.
5384         * features/i386/i386-avx-avx512-linux.xml: Remove.
5385         * features/i386/i386-avx-avx512.xml: Remove.
5386         * features/i386/i386-avx-linux.xml: Remove.
5387         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5388         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5389         * features/i386/i386-avx-mpx-linux.xml: Remove.
5390         * features/i386/i386-avx-mpx.xml: Remove.
5391         * features/i386/i386-avx.xml: Remove.
5392         * features/i386/i386-linux.xml: Remove.
5393         * features/i386/i386-mmx-linux.xml: Remove.
5394         * features/i386/i386-mmx.xml: Remove.
5395         * features/i386/i386-mpx-linux.xml: Remove.
5396         * features/i386/i386-mpx.xml: Remove.
5397         * features/i386/i386.xml: Remove.
5398         * features/i386/x32-avx-avx512-linux.xml: Remove.
5399         * features/i386/x32-avx-linux.xml: Remove.
5400         * features/i386/x32-linux.xml: Remove.
5401
5402 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5403
5404         * regformats/aarch64.dat: Remove.
5405         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5406         * regformats/i386/amd64-avx-linux.dat: Remove.
5407         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5408         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5409         * regformats/i386/amd64-linux.dat: Remove.
5410         * regformats/i386/amd64-mpx-linux.dat: Remove.
5411         * regformats/i386/amd64.dat: Remove.
5412         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5413         * regformats/i386/i386-avx-linux.dat: Remove.
5414         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5415         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5416         * regformats/i386/i386-linux.dat: Remove.
5417         * regformats/i386/i386-mmx-linux.dat: Remove.
5418         * regformats/i386/i386-mpx-linux.dat: Remove.
5419         * regformats/i386/i386.dat: Remove.
5420         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5421         * regformats/i386/x32-avx-linux.dat: Remove.
5422         * regformats/i386/x32-linux.dat: Remove.
5423
5424 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5425
5426         * aarch64-tdep.c: Remove xml self tests.
5427         * amd64-linux-tdep.c: Likewise.
5428         * amd64-tdep.c: Likewise.
5429         * i386-linux-tdep.c: Likewise.
5430         * i386-tdep.c: Likewise.
5431
5432 2019-07-03  Pedro Alves  <palves@redhat.com>
5433
5434         PR cli/24732
5435         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5436         (pipe_cmd_option_defs): New.
5437         (make_pipe_cmd_options_def_group): New.
5438         (pipe_command): Use gdb::option::process_options.
5439         (pipe_command_completer): New function.
5440         (_initialize_cli_cmds): Install completer for "pipe" command.
5441
5442 2019-07-03  Pedro Alves  <palves@redhat.com>
5443
5444         * cli/cli-option.c (union option_value) <string>: New field.
5445         (struct option_def_and_value): Add ctor, move ctor, dtor and
5446         use DISABLE_COPY_AND_ASSIGN.
5447         (option_def_and_value::clear_value): New.
5448         (parse_option, save_option_value_in_ctx, get_val_type_str)
5449         (add_setshow_cmds_for_options): Handle var_string.
5450         * cli-option.h (union option_def::var_address) <string>: New
5451         field.
5452         (struct string_option_def): New.
5453         * maint-test-options.c (struct test_options_opts): Add default
5454         ctor and use DISABLE_COPY_AND_ASSIGN.
5455         <string_opt>: New field.
5456         (test_options_opts::~test_options_opts): New.
5457         (test_options_opts::dump): Also dump "-string".
5458         (test_options_option_defs): Install "string.
5459
5460 2019-07-03  Pedro Alves  <palves@redhat.com>
5461
5462         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5463         option_value with a null enumeration.
5464         (complete_options): Save the option values in the context.
5465         (save_option_value_in_ctx): New, factored out from ...
5466         (process_options): ... here.
5467         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5468         of the function.
5469         * maint-test-options.c (test_options_opts::dump): New, factored
5470         out from ...
5471         (maintenance_test_options_command_mode): ... here.
5472         (maintenance_test_options_command_completion_result): Delete.
5473         (maintenance_test_options_command_completion_text): Update
5474         comment.
5475         (maintenance_show_test_options_completion_result): Change
5476         prototype.  Just print
5477         maintenance_test_options_command_completion_text.
5478         (save_completion_result): New.
5479         (maintenance_test_options_completer_mode): Pass options context to
5480         complete_options, and then save a dump.
5481         (_initialize_maint_test_options): Use add_cmd to install "maint
5482         show test-options-completion-result".
5483
5484 2019-07-03  Pedro Alves  <palves@redhat.com>
5485
5486         * NEWS (New commands): Mention "with" and "maint with".
5487         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5488         (with_command, with_command_completer): New.
5489         (pipe_command): Adjust to new repeat_previous
5490         interface.
5491         (_initialize_cli_cmds): Install the "with" command and its "w"
5492         alias.
5493         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5494         declarations.
5495         * cli/cli-setshow.c (parse_cli_var_uinteger)
5496         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5497         argument strings for all var_types.
5498         (get_setshow_command_value_string): New, factored out from ...
5499         (do_show_command): ... this.
5500         * cli/cli-setshow.h: Include <string>.
5501         (get_setshow_command_value_string): Declare.
5502         * command.h (repeat_previous): Now returns const char *.  Adjust
5503         comment.
5504         * maint.c: Include "cli/cli-cmds.h".
5505         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5506         (_initialize_maint_cmds): Register the "maintenance with" command.
5507         * top.c (repeat_previous): Move bits from pipe_command here:
5508         Return the saved command line, if any; error out if there's no
5509         command to relaunch.
5510
5511 2019-07-03  Pedro Alves  <palves@redhat.com>
5512
5513         * NEWS (New commands): Mention "maint set/show test-settings"
5514         instead of "maint test-settings".
5515         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5516         (maintenance_test_settings_set_list): Rename to ...
5517         (maintenance_set_test_settings_list): ... this.
5518         (maintenance_test_settings_show_list): Rename to  ...
5519         (maintenance_show_test_settings_list): ... this.
5520         (maintenance_test_settings_cmd): Delete.
5521         (maintenance_test_settings_set_cmd): ...
5522         (maintenance_set_test_settings_cmd): ... this.
5523         (maintenance_test_settings_show_cmd): ...
5524         (maintenance_show_test_settings_cmd): ... this.
5525         (maintenance_test_settings_show_value_cmd):
5526         (maintenance_show_test_settings_value_cmd): ... this.
5527         (_initialize_maint_test_settings): No longer install the "maint
5528         test-settings" prefix command.  Rename "maint test-settings set"
5529         to "maint set test-settings", and "maint test-settings show" to
5530         "maint show test-settings".  Adjust all subcommands.
5531
5532 2019-07-03  Pedro Alves  <palves@redhat.com>
5533
5534         * maint-test-settings.c: Fix file's intro comment.  Replace all
5535         references to "test-options" with references to "test-settings",
5536         in comments.
5537
5538 2019-07-03  Pedro Alves  <palves@redhat.com>
5539
5540         * maint-test-settings.c (maintenance_test_settings_xxx)
5541         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5542         New.
5543         (maintenance_test_settings_enums): Use them.
5544         (maintenance_test_settings_enum): Default to
5545         maintenance_test_settings_xxx.
5546         (_initialize_maint_test_settings): Initialize
5547         MAINTENANCE_TEST_SETTINGS_FILENAME.
5548
5549 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5550
5551         * breakpoint.h (remove_breakpoints_inf): Change return type to
5552         void, move function documentation here.
5553         * breakpoint.c (remove_breakpoints_inf): Change return type to
5554         void, move function documentation to header.
5555
5556 2019-07-02  Pedro Alves  <palves@redhat.com>
5557
5558         * NEWS (Completion improvements): Mention "info threads".
5559         * thread.c (struct info_threads_opts, info_threads_option_defs)
5560         (make_info_threads_options_def_group): New.
5561         (info_threads_command): Use gdb::option::process_options.
5562         (info_threads_command_completer): New.
5563         (_initialize_thread): Use gdb::option::build_help to build the
5564         help text for "info threads".
5565
5566 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5567
5568         * defs.h (generic_load): Move from here...
5569         * symfile.h (generic_load): ... to here.  Rename name parameter
5570         to args.
5571         * symfile.c (generic_load): Add comment.
5572
5573 2019-07-01  Tom Tromey  <tromey@adacore.com>
5574
5575         * dwarf2read.c
5576         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5577         declaration of without_params.  Fix formatting.
5578
5579 2019-07-01  Tom Tromey  <tromey@adacore.com>
5580
5581         * ada-exp.y (find_primitive_type): Update.
5582         * ada-lang.h (ada_lookup_symbol): Update.
5583         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5584         parameter.
5585         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5586
5587 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5588
5589         PR breakpoints/24541
5590         * gdbarch.c: Regenerate.
5591         * gdbarch.h: Regenerate.
5592         * gdbarch.sh: Add 'stap_adjust_register'.
5593         * i386-tdep.c: Include '<unordered_set>'.
5594         (i386_stap_adjust_register): New function.
5595         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5596         * stap-probe.c (stap_parse_register_operand): Call
5597         'gdbarch_stap_adjust_register'.
5598
5599 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5600
5601         PR python/24742
5602         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5603         * python/python.c (do_start_initialization): Use 'xmalloc'
5604         instead of 'PyMem_Malloc'.
5605
5606 2019-06-28  Tom Tromey  <tromey@adacore.com>
5607
5608         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5609         for Ada.
5610
5611 2019-06-27  Tom Tromey  <tromey@adacore.com>
5612
5613         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5614         objfile_key.
5615         (arm_find_mapping_symbol, arm_record_special_symbol)
5616         (_initialize_arm_tdep): Update.
5617         (arm_objfile_data_free): Remove.
5618
5619 2019-06-27  Tom Tromey  <tromey@adacore.com>
5620
5621         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5622         to cp_print_static_field.
5623
5624 2019-06-26  Tom Tromey  <tromey@adacore.com>
5625
5626         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5627         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5628         declare.
5629
5630 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5631
5632         * features/aarch64-core.c (create_feature_aarch64_core):
5633         Regenerate.
5634         * features/aarch64-core.xml: Add cpsr flags.
5635
5636 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5637
5638         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5639         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5640
5641 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5642
5643         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5644         field.
5645         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5646         use.
5647         (arm_record_special_symbol): Don't insert new symbol in sorted
5648         position, push it at the end.
5649
5650 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5651
5652         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5653         (arm_mapping_symbol_s): Remove.
5654         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5655         (arm_mapping_symbol_vec): New typedef.
5656         (struct arm_per_objfile): Add constructor.
5657         <section_maps>: Change type to
5658         std::unique_ptr<arm_mapping_symbol_vec[]>.
5659         (arm_compare_mapping_symbols): Remove.
5660         (arm_find_mapping_symbol): Adjust to section_maps type change.
5661         (arm_objfile_data_free): Call delete on arm_per_objfile.
5662         (arm_record_special_symbol): Adjust to section_maps type change.
5663         Allocate arm_per_objfile with new.
5664
5665 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5666
5667         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5668         with the command prefix.
5669
5670 2019-06-25  Tom Tromey  <tom@tromey.com>
5671
5672         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5673         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5674
5675 2019-06-25  Tom Tromey  <tom@tromey.com>
5676
5677         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5678         type.
5679         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5680         protected.
5681
5682 2019-06-25  Tom Tromey  <tom@tromey.com>
5683
5684         * tui/tui-winsource.c
5685         (tui_source_window_base::set_is_exec_point_at): Add check against
5686         LOA_ADDRESS.
5687
5688 2019-06-25  Tom Tromey  <tom@tromey.com>
5689
5690         * tui/tui-source.c (tui_set_source_content): Don't check before
5691         xfree.
5692         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5693
5694 2019-06-25  Tom Tromey  <tom@tromey.com>
5695
5696         * tui/tui-winsource.h (tui_update_source_window_as_is)
5697         (tui_alloc_source_buffer, tui_line_is_displayed)
5698         (tui_addr_is_displayed): Change type of win_info.
5699         * tui/tui-winsource.c (tui_update_source_window_as_is)
5700         (tui_clear_source_content, tui_show_source_line)
5701         (tui_show_source_content, tui_source_window_base::refill)
5702         (tui_source_window_base::set_is_exec_point_at)
5703         (tui_source_window_base::set_is_exec_point_at)
5704         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5705         (tui_alloc_source_buffer, tui_line_is_displayed)
5706         (tui_addr_is_displayed): Change type of win_info.  Update.
5707         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5708         (tui_source_window_base::do_make_visible_with_new_height):
5709         Update.
5710         * tui/tui-source.c (tui_set_source_content)
5711         (tui_set_source_content_nil)
5712         (tui_source_window::do_scroll_vertical): Update.
5713         * tui/tui-layout.c (show_layout): Update.
5714         * tui/tui-disasm.c (tui_set_disassem_content)
5715         (tui_disasm_window::do_scroll_vertical): Update.
5716         * tui/tui-data.h (tui_win_content): Remove.
5717         (struct tui_gen_win_info) <content, content_size>: Remove.
5718         (struct tui_source_element): Add initializers and destructor.
5719         (union tui_which_element, struct tui_win_element): Remove.
5720         (struct tui_source_window_base) <content>: New field.
5721         (struct tui_data_window): Remove destructor.
5722         (tui_alloc_content, tui_free_win_content)
5723         (tui_free_all_source_wins_content): Don't declare.
5724         * tui/tui-data.c (tui_initialize_static_data): Update.
5725         (init_content_element, tui_alloc_content): Remove.
5726         (~tui_gen_win_info): Update.
5727         (~tui_data_window, tui_free_all_source_wins_content)
5728         (tui_free_win_content, free_content, free_content_elements):
5729         Remove.
5730
5731 2019-06-25  Tom Tromey  <tom@tromey.com>
5732
5733         * tui/tui-winsource.h (tui_clear_source_content)
5734         (tui_erase_source_content, tui_show_source_content): Change type
5735         of win_info.
5736         * tui/tui-winsource.c (tui_clear_source_content)
5737         (tui_erase_source_content, tui_show_source_content): Change type
5738         of win_info.
5739         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5740         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5741         win_info.
5742         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5743         win_info.
5744         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5745
5746 2019-06-25  Tom Tromey  <tom@tromey.com>
5747
5748         * tui/tui-winsource.c (tui_clear_source_content)
5749         (tui_source_window_base::set_is_exec_point_at): Update.
5750         * tui/tui-source.c (tui_set_source_content_nil): Update.
5751         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5752         a bool.
5753         * tui/tui-data.c (init_content_element): Update.
5754
5755 2019-06-25  Tom Tromey  <tom@tromey.com>
5756
5757         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5758         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5759         * tui/tui-layout.c (init_and_make_win): Update.
5760         * tui/tui.h (enum tui_win_type): Update.
5761         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5762         tui_win_is_auxillary.
5763         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5764         tui_win_is_auxillary.
5765
5766 2019-06-25  Tom Tromey  <tom@tromey.com>
5767
5768         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5769         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5770         (tui_delete_data_content_windows, tui_display_all_data)
5771         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5772         Update.
5773         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5774         * tui/tui-regs.c (tui_last_regs_line_no)
5775         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5776         (tui_show_registers): Update.
5777         (tui_show_register_group): Return void.  Update.
5778         (tui_display_registers_from, tui_display_reg_element_at_line)
5779         (tui_display_registers_from_line, tui_check_register_values):
5780         Update.
5781         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5782         member.
5783         (struct tui_data_window) <regs_content>: Now a std::vector.
5784         <regs_content_count>: Remove.
5785         (tui_add_content_elements, tui_free_data_content): Don't declare.
5786         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5787         (init_content_element): Remove DATA_WIN case.  Add assert.
5788         (tui_add_content_elements): Remove.
5789         (tui_data_window): Update.
5790         (tui_free_data_content): Remove.
5791         (free_content_elements): Remove DATA_WIN case.
5792
5793 2019-06-25  Tom Tromey  <tom@tromey.com>
5794
5795         * tui/tui-data.c (tui_data_item_window): Update.
5796         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5797         * tui/tui-windata.c (tui_display_all_data)
5798         (tui_display_data_from_line): Update.
5799         (tui_check_data_values): Remove.
5800         * tui/tui-regs.c (tui_show_register_group)
5801         (tui_display_reg_element_at_line): Update.
5802         * tui/tui-hooks.c (tui_register_changed)
5803         (tui_refresh_frame_and_register_information): Call
5804         tui_check_register_values.
5805         * tui/tui-data.h (struct tui_data_window) <data_content,
5806         data_content_count, data_type>: Remove.
5807         (enum tui_data_type): Remove.
5808
5809         * tui/tui-data.c (tui_data_window::clear_detail)
5810         (~tui_data_window): Update.
5811
5812 2019-06-25  Tom Tromey  <tom@tromey.com>
5813
5814         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5815         declare.
5816         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5817         Rename from tui_first_data_item_displayed.  Update.
5818         (tui_data_window::refresh_all)
5819         (tui_data_window::do_scroll_vertical): Update.
5820         * tui/tui-data.h (struct tui_data_window)
5821         <first_data_item_displayed>: Declare new method.
5822
5823 2019-06-25  Tom Tromey  <tom@tromey.com>
5824
5825         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5826         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5827         contents...
5828         (tui_initialize_static_data): ...here.
5829
5830 2019-06-25  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5833         (tui_display_registers_from, tui_check_register_values): Update.
5834         (tui_display_register): Remove win_info parameter; update.
5835         (tui_get_register): Change type of parameters.
5836         * tui/tui-data.h (struct tui_data_element): Remove.
5837         (union tui_which_element) <data>: Remove.
5838         <data_window>: Change type.
5839         (struct tui_data_item_window): New.
5840         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5841         case.  Add assert.
5842         (~tui_data_item_window): New destructor.
5843         (free_content_elements): Remove DATA_ITEM_WIN case.
5844
5845 2019-06-25  Tom Tromey  <tom@tromey.com>
5846
5847         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5848         Remove.
5849
5850 2019-06-25  Tom Tromey  <tom@tromey.com>
5851
5852         * tui/tui-data.h (struct tui_command_element): Remove.
5853         (union tui_which_element) <command>: Remove.
5854         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5855         assert.
5856         (free_content_elements): Remove CMD_WIN case.
5857
5858 2019-06-25  Tom Tromey  <tom@tromey.com>
5859
5860         * tui/tui-layout.c (tui_set_layout): Update.
5861         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5862         * tui/tui-data.c (layout_def): Update.
5863
5864 2019-06-25  Tom Tromey  <tom@tromey.com>
5865
5866         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5867         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5868         (tui_source_window_base::set_new_height): Update.
5869         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5870         Update.
5871         (tui_set_locator_fullname, tui_set_locator_info)
5872         (tui_show_frame_info): Update.
5873         * tui/tui-source.c (tui_set_source_content)
5874         (tui_source_is_displayed): Update.
5875         * tui/tui-layout.c (show_source_disasm_command, show_data)
5876         (show_source_or_disasm_and_command): Update.
5877         * tui/tui-disasm.c (tui_set_disassem_content)
5878         (tui_get_begin_asm_address): Update.
5879         * tui/tui-data.h (struct tui_locator_element): Remove.
5880         (union tui_which_element) <locator>: Remove.
5881         (struct tui_locator_window): New.
5882         (tui_locator_win_info_ptr): Change return type.
5883         * tui/tui-data.c (_locator): Change type.
5884         (tui_locator_win_info_ptr): Change return type.
5885         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5886         (tui_alloc_content): Add assert.
5887
5888 2019-06-25  Tom Tromey  <tom@tromey.com>
5889
5890         * tui/tui-winsource.c
5891         (tui_exec_info_window::maybe_allocate_content): New method.
5892         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5893         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5894         (make_source_or_disasm_window): Add cast.
5895         * tui/tui-data.h (union tui_which_element) <simple_string>:
5896         Remove.
5897         (struct tui_source_info): New.
5898         (struct tui_source_window_base) <execution_info>: Change type.
5899         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5900         case, and add assert.
5901         (tui_alloc_content): Add assert.
5902
5903 2019-06-25  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5906         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5907         * tui/tui-data.c (tui_alloc_win_info): Remove.
5908
5909 2019-06-25  Tom Tromey  <tom@tromey.com>
5910
5911         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5912         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5913         can_highlight.
5914
5915 2019-06-25  Tom Tromey  <tom@tromey.com>
5916
5917         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5918         make_visible_with_new_height method.
5919         (tui_win_info::make_visible_with_new_height): New method.
5920         (tui_source_window_base::do_make_visible_with_new_height)
5921         (tui_data_window::do_make_visible_with_new_height)
5922         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5923         (make_visible_with_new_height): Remove.
5924         (tui_resize_all, tui_adjust_win_heights): Use
5925         make_visible_with_new_height method.
5926         * tui/tui-data.h (struct tui_win_info)
5927         <do_make_visible_with_new_height, make_visible_with_new_height>:
5928         New methods.
5929         (struct tui_source_window_base, struct tui_data_window)
5930         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5931         methods.
5932
5933 2019-06-25  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5936         method.
5937         (update_tab_width): Call update_tab_width method.
5938         * tui/tui-data.h (struct tui_win_info)
5939         (struct tui_source_window_base) <update_tab_width>: New methods.
5940
5941 2019-06-25  Tom Tromey  <tom@tromey.com>
5942
5943         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5944         parameter.
5945         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5946         parameter.
5947         (tui_gen_win_info::make_visible): Update.
5948         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5949         parameter.
5950         * tui/tui-data.h (enum tui_box): New enum.
5951         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5956         init_and_make_win for EXEC_INFO_WIN.
5957         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5958         longer inline.
5959         (struct tui_win_info) <~tui_win_info>: Inline.
5960         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5961         Don't declare.
5962         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5963         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5964         Remove.
5965         (tui_initialize_static_data): Update.
5966         (~tui_gen_win_info): Handle more cleanup here.
5967         (~tui_source_window_base): Delete "execution_info".
5968         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5969
5970 2019-06-25  Tom Tromey  <tom@tromey.com>
5971
5972         * tui/tui-layout.c (make_command_window): Don't set
5973         can_highlight.
5974         (show_source_disasm_command): Call the reset method.
5975         (show_data): Don't set can_highlight.  Call the reset method.
5976         (tui_gen_win_info::reset): Rename from init_gen_win_info
5977         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5978         (show_source_or_disasm_and_command): Call the reset method.
5979         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5980         (struct tui_cmd_window): Set can_highlight.
5981
5982 2019-06-25  Tom Tromey  <tom@tromey.com>
5983
5984         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5985         from make_visible.
5986         (tui_make_visible, tui_make_invisible): Rewrite.
5987         (tui_win_info::make_visible): Remove.
5988         (tui_source_window_base::make_visible): Update.
5989         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5990         method.  Moved from...
5991         (struct tui_win_info) <make_visible>: ...here.
5992
5993 2019-06-25  Tom Tromey  <tom@tromey.com>
5994
5995         * tui/tui-winsource.c
5996         (tui_source_window_base::do_scroll_horizontal): Remove direction
5997         parameter.
5998         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5999         direction parameter.
6000         * tui/tui-win.c (tui_win_info::forward_scroll)
6001         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6002         (tui_win_info::right_scroll): Update.
6003         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6004         direction parameter.
6005         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6006         direction parameter.
6007         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6008         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6009         Remove direction parameter.
6010         (struct tui_source_window_base, struct tui_source_window)
6011         (struct tui_disasm_window, struct tui_data_window)
6012         (struct tui_cmd_window): Update.
6013
6014 2019-06-25  Tom Tromey  <tom@tromey.com>
6015
6016         * tui/tui-winsource.h (tui_set_exec_info_content)
6017         (tui_show_exec_info_content, tui_erase_exec_info_content)
6018         (tui_clear_exec_info_content, tui_update_exec_info): Change
6019         argument to tui_source_window_base.
6020         * tui/tui-winsource.c (tui_set_exec_info_content)
6021         (tui_show_exec_info_content, tui_erase_exec_info_content)
6022         (tui_clear_exec_info_content, tui_update_exec_info): Change
6023         argument to tui_source_window_base.
6024
6025 2019-06-25  Tom Tromey  <tom@tromey.com>
6026
6027         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6028         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6029
6030 2019-06-25  Tom Tromey  <tom@tromey.com>
6031
6032         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6033         check.
6034
6035 2019-06-25  Tom Tromey  <tom@tromey.com>
6036
6037         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6038         type to void.
6039         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6040         type to void.
6041         * tui/tui-source.c (tui_set_source_content): Update.
6042         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6043
6044 2019-06-25  Tom Tromey  <tom@tromey.com>
6045
6046         * tui/tui-win.c (window_name_completer, tui_set_focus)
6047         (tui_all_windows_info): Use name method.
6048         * tui/tui-data.h (struct tui_gen_win_info)
6049         (struct tui_source_window, struct tui_disasm_window)
6050         (struct tui_data_window, struct tui_cmd_window) <name>: New
6051         method.
6052         (tui_win_name): Don't declare.
6053         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6054         (tui_win_name): Remove.
6055
6056 2019-06-25  Tom Tromey  <tom@tromey.com>
6057
6058         * tui/tui-winsource.h (tui_update_source_window)
6059         (tui_update_source_window_as_is): Change parameter type.
6060         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6061         to be a tui_source_window_base.
6062         (tui_update_source_window_as_is): Likewise.
6063         * tui/tui-win.c (make_visible_with_new_height): Update.
6064
6065 2019-06-25  Tom Tromey  <tom@tromey.com>
6066
6067         * tui/tui-winsource.c (tui_erase_source_content)
6068         (tui_show_source_content, tui_show_exec_info_content)
6069         (tui_erase_exec_info_content): Use refresh_window method.
6070         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6071         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6072         from tui_refresh_win.
6073         (tui_data_window::refresh_window): New method.
6074         (tui_win_info::refresh, tui_source_window_base::refresh)
6075         (tui_refresh_all): Use refresh_window method.
6076         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6077         method.
6078         * tui/tui-regs.c (tui_display_register): Call refresh_window
6079         method.
6080         * tui/tui-layout.c (show_source_disasm_command)
6081         (show_source_or_disasm_and_command): Call refresh_window method.
6082         * tui/tui-data.h (struct tui_gen_win_info)
6083         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6084         New method.
6085
6086 2019-06-25  Tom Tromey  <tom@tromey.com>
6087
6088         * tui/tui.c (tui_rl_other_window, tui_enable)
6089         (tui_is_window_visible, tui_get_command_dimension): Update.
6090         * tui/tui-winsource.c (tui_update_source_window_as_is)
6091         (tui_clear_source_content, tui_erase_source_content)
6092         (tui_show_source_line, tui_source_window_base::refill)
6093         (tui_source_window_base::do_scroll_horizontal)
6094         (tui_source_window_base::set_is_exec_point_at)
6095         (tui_update_breakpoint_info, tui_set_exec_info_content)
6096         (tui_alloc_source_buffer, tui_line_is_displayed)
6097         (tui_addr_is_displayed): Update.
6098         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6099         (tui_check_and_display_highlight_if_needed)
6100         (tui_win_info::make_visible, tui_win_info::refresh)
6101         (tui_refresh_all): Update.
6102         * tui/tui-windata.c (tui_first_data_item_displayed)
6103         (tui_delete_data_content_windows, tui_erase_data_content)
6104         (tui_display_all_data, tui_data_window::refresh_all)
6105         (tui_check_data_values): Update.
6106         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6107         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6108         (tui_win_info::backward_scroll, tui_refresh_all_win)
6109         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6110         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6111         (tui_source_window_base::set_new_height)
6112         (tui_data_window::set_new_height)
6113         (make_invisible_and_set_new_height)
6114         (make_visible_with_new_height, new_height_ok)
6115         (parse_scrolling_args): Update.
6116         * tui/tui-stack.c (tui_show_frame_info): Update.
6117         * tui/tui-source.c (tui_set_source_content)
6118         (tui_set_source_content_nil, tui_source_is_displayed)
6119         (tui_source_window::do_scroll_vertical): Update.
6120         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6121         (tui_display_registers_from, tui_display_reg_element_at_line)
6122         (tui_check_register_values, tui_reg_command): Update.
6123         * tui/tui-layout.c (tui_default_win_height)
6124         (show_source_disasm_command, show_data, init_and_make_win)
6125         (show_source_or_disasm_and_command): Update.
6126         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6127         (tui_redisplay_readline, tui_mld_flush)
6128         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6129         (tui_getc): Update.
6130         * tui/tui-disasm.c (tui_set_disassem_content)
6131         (tui_disasm_window::do_scroll_vertical): Update.
6132         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6133         Now virtual.
6134         (struct tui_win_info): Derive from tui_gen_win_info.
6135         <~tui_win_info>: Mark as override.
6136         <generic>: Remove member.
6137         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6138         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6139         (~tui_data_window, ~tui_win_info)
6140         (tui_free_all_source_wins_content): Update.
6141         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6142
6143 2019-06-25  Tom Tromey  <tom@tromey.com>
6144
6145         * tui/tui-layout.c (init_and_make_win): Use new.
6146         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6147         destructor, initializers.
6148         (tui_alloc_generic_win_info): Don't declare.
6149         * tui/tui-data.c (_locator): Add argument to constructor.
6150         (source_win, disasm_win): New globals.
6151         (exec_info): Remove.
6152         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6153         Update.
6154         (tui_alloc_generic_win_info): Remove.
6155         (init_content_element): Use new.
6156         (tui_win_info::tui_win_info): Update.
6157         (free_content_elements) <case DATA_WIN>: Use delete.
6158
6159 2019-06-25  Tom Tromey  <tom@tromey.com>
6160
6161         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6162         * tui/tui-windata.c (tui_first_data_item_displayed)
6163         (tui_delete_data_content_windows): Update.
6164         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6165         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6166         (tui_display_registers_from, tui_check_register_values): Update.
6167         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6168         pointer.
6169         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6170         window.
6171         (tui_free_data_content): Update.
6172         (free_content_elements) <case DATA_WIN>: Free the window.
6173
6174 2019-06-25  Tom Tromey  <tom@tromey.com>
6175
6176         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6177         Update.
6178         * tui/tui-layout.c (make_command_window)
6179         (show_source_disasm_command, show_data, init_and_make_win)
6180         (show_source_or_disasm_and_command): Update.
6181         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6182         method.
6183         <can_highight, is_highlighted>: Now bool.
6184         (tui_set_win_highlight): Don't declare.
6185         * tui/tui-data.c (tui_set_win_highlight): Remove.
6186
6187 2019-06-25  Tom Tromey  <tom@tromey.com>
6188
6189         * tui/tui-wingeneral.c (make_visible): Remove check of window
6190         type.
6191
6192 2019-06-25  Tom Tromey  <tom@tromey.com>
6193
6194         * tui/tui-win.c (tui_win_info::max_height)
6195         (tui_cmd_window::max_height): New methods.
6196         (new_height_ok): Call max_height.
6197         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6198         <max_height>: New method.
6199
6200 2019-06-25  Tom Tromey  <tom@tromey.com>
6201
6202         * tui/tui-win.c (tui_source_window_base::set_new_height)
6203         (tui_data_window::set_new_height): New methods.
6204         (make_invisible_and_set_new_height): Call set_new_height method.
6205         * tui/tui-data.h (struct tui_win_info)
6206         (struct tui_source_window_base, struct tui_data_window)
6207         <set_new_height>: New method.
6208
6209 2019-06-25  Tom Tromey  <tom@tromey.com>
6210
6211         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6212         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6213         tui_refresh_data_win.
6214         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6215         method.
6216         (tui_refresh_all_win): Call the refresh_all method.
6217         (tui_set_focus): Likewise.
6218         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6219         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6220         Likewise.
6221
6222 2019-06-25  Tom Tromey  <tom@tromey.com>
6223
6224         * tui/tui-winsource.h (tui_refill_source_window)
6225         (tui_set_is_exec_point_at): Don't declare.
6226         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6227         (tui_source_window_base::refill): Rename from
6228         tui_refill_source_window.
6229         (tui_source_window_base::do_scroll_horizontal): Update.
6230         (tui_source_window_base::set_is_exec_point_at): Rename from
6231         tui_set_is_exec_point_at.
6232         (tui_update_all_breakpoint_info): Update.
6233         * tui/tui-stack.c (tui_show_frame_info): Update.
6234         * tui/tui-layout.c (show_data): Add cast.
6235         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6236         * tui/tui-data.h (struct tui_source_window_base) <refill,
6237         set_is_exec_point_at>: New methods.
6238         (tui_source_windows, tui_add_to_source_windows): Update types.
6239         (tui_add_to_source_windows): Remove redundant declaration.
6240         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6241         (tui_source_windows): Change return type.
6242         (tui_clear_source_windows_detail): Update.
6243         (tui_add_to_source_windows): Change type of parameter.
6244         (tui_free_all_source_wins_content): Update.
6245
6246 2019-06-25  Tom Tromey  <tom@tromey.com>
6247
6248         * tui/tui-wingeneral.c (tui_win_info::refresh)
6249         (tui_source_window_base::refresh): New methods.
6250         (tui_refresh_all): Call the refresh method.
6251         * tui/tui-data.h (struct tui_win_info)
6252         (struct tui_source_window_base) <refresh>: New method.
6253
6254 2019-06-25  Tom Tromey  <tom@tromey.com>
6255
6256         * tui/tui.h (tui_is_window_visible): Return bool.
6257         * tui/tui.c (tui_is_window_visible): Return bool.
6258         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6259         (tui_make_visible, tui_make_invisible)
6260         (tui_win_info::make_visible)
6261         (tui_source_window_base::make_visible, make_all_visible)
6262         (tui_make_all_visible, tui_make_all_invisible): Update.
6263         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6264         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6265         bool.
6266         (struct tui_win_info, struct tui_source_window_base)
6267         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6268         * tui/tui-data.c (tui_init_generic_part): Update.
6269
6270 2019-06-25  Tom Tromey  <tom@tromey.com>
6271
6272         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6273         (tui_source_window_base::make_visible): New methods.
6274         (make_all_visible): Make method call.
6275         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6276         (struct tui_source_window_base, struct tui_cmd_window): Override
6277         make_visible.
6278         (tui_win_is_source_type): Don't declare.
6279         * tui/tui-data.c (tui_win_is_source_type): Remove.
6280
6281 2019-06-25  Tom Tromey  <tom@tromey.com>
6282
6283         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6284         NULL check.
6285
6286 2019-06-25  Tom Tromey  <tom@tromey.com>
6287
6288         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6289         Inline constructor.  Add initializers for members.
6290         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6291         constructors; now inline in class.
6292
6293 2019-06-25  Tom Tromey  <tom@tromey.com>
6294
6295         * tui/tui-regs.c (tui_show_registers): Update.
6296         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6297         bool.
6298         * tui/tui-data.c (tui_data_window::clear_detail)
6299         (tui_data_window): Update.
6300
6301 2019-06-25  Tom Tromey  <tom@tromey.com>
6302
6303         * tui/tui-windata.c (tui_display_all_data)
6304         (tui_display_data_from_line, tui_display_data_from)
6305         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6306         Update.
6307         * tui/tui-regs.c (tui_last_regs_line_no)
6308         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6309         (tui_show_registers, tui_show_register_group)
6310         (tui_display_registers_from, tui_display_reg_element_at_line)
6311         (tui_display_registers_from_line, tui_check_register_values)
6312         (tui_reg_next, tui_reg_prev): Update.
6313         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6314         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6315         tui_data_window.
6316         (struct tui_win_info) <detail>: Remove.  Add new fields from
6317         tui_data_info.
6318         (TUI_DATA_WIN): Add cast.
6319         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6320         (~tui_data_window): Simplify.
6321
6322 2019-06-25  Tom Tromey  <tom@tromey.com>
6323
6324         * tui/tui-layout.c (show_source_disasm_command)
6325         (show_source_or_disasm_and_command): Update.
6326         * tui/tui-io.c (update_cmdwin_start_line)
6327         (tui_redisplay_readline): Update.
6328         * tui/tui-data.h (struct tui_command_info): Remove.
6329         (struct tui_win_info) <detail>: Remove command_info member.
6330         (struct tui_data_window) <start_line>: New member, from
6331         tui_command_info.
6332         (TUI_CMD_WIN): Add casts.
6333
6334 2019-06-25  Tom Tromey  <tom@tromey.com>
6335
6336         * tui/tui-winsource.c (tui_update_source_window)
6337         (tui_refill_source_window)
6338         (tui_source_window_base::do_scroll_horizontal)
6339         (tui_update_breakpoint_info, tui_set_exec_info_content)
6340         (tui_show_exec_info_content, tui_erase_exec_info_content)
6341         (tui_clear_exec_info_content): Update.
6342         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6343         Update.
6344         * tui/tui-win.c (make_invisible_and_set_new_height)
6345         (make_visible_with_new_height): Update.
6346         * tui/tui-source.c (tui_set_source_content)
6347         (tui_show_symtab_source): Update.
6348         * tui/tui-layout.c (extract_display_start_addr)
6349         (show_source_disasm_command, show_data)
6350         (make_source_or_disasm_window)
6351         (show_source_or_disasm_and_command): Update.
6352         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6353         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6354         "gdbarch".
6355         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6356         to tui_source_window_base.
6357         (struct tui_win_info) <detail>: Remove source_info member.
6358         (struct tui_source_window_base) <has_locator>: Inline.
6359         Move contents from tui_source_info; rename has_locator member to
6360         m_has_locator.
6361         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6362         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6363         header file.
6364         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6365         Simplify.
6366         (tui_free_all_source_wins_content): Cast to
6367         tui_source_window_base.
6368
6369 2019-06-25  Tom Tromey  <tom@tromey.com>
6370
6371         * tui/tui-win.c (make_invisible_and_set_new_height)
6372         (make_visible_with_new_height): Call has_locator method.
6373         * tui/tui-layout.c (show_source_disasm_command, show_data)
6374         (show_source_or_disasm_and_command): Update for bool change.
6375         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6376         (tui_win_info) <has_locator>: New method.
6377         (struct tui_source_window_base) <has_locator>: New method.
6378         (tui_win_has_locator): Don't declare.
6379         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6380         from tui_win_has_locator.
6381         (tui_source_window_base): Use false, not FALSE.
6382
6383 2019-06-25  Tom Tromey  <tom@tromey.com>
6384
6385         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6386         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6387         clear_detail method directly.
6388         (tui_clear_win_detail): Remove.
6389
6390 2019-06-25  Tom Tromey  <tom@tromey.com>
6391
6392         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6393         "this", not TUI_DISASM_WIN.
6394
6395 2019-06-25  Tom Tromey  <tom@tromey.com>
6396
6397         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6398         declare.
6399         * tui/tui-winsource.c
6400         (tui_source_window_base::do_scroll_horizontal): Rename from
6401         tui_horizontal_source_scroll.
6402         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6403         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6404         from tui_vertical_data_scroll.
6405         * tui/tui-win.h (tui_scroll): Don't declare.
6406         * tui/tui-win.c (tui_win_info::forward_scroll)
6407         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6408         (tui_win_info::right_scroll): Rename and update.
6409         (tui_scroll_forward_command, tui_scroll_backward_command)
6410         (tui_scroll_left_command, tui_scroll_right_command): Update.
6411         (tui_scroll): Remove.
6412         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6413         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6414         from tui_vertical_source_scroll.
6415         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6416         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6417         from tui_vertical_disassem_scroll.
6418         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6419         do_scroll_horizontal>: New methods.
6420         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6421         Likewise.
6422         (struct tui_source_window_base): Add do_scroll_horizontal.
6423         (struct tui_source_window, struct tui_disasm_window): Add
6424         do_scroll_vertical.
6425         (struct tui_data_window, struct tui_cmd_window): Add
6426         do_scroll_horizontal and do_scroll_vertical.
6427         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6428
6429 2019-06-25  Tom Tromey  <tom@tromey.com>
6430
6431         * tui/tui-data.h (struct tui_source_window_base): New struct.
6432         (struct tui_source_window): Derive from tui_source_window_base.
6433         (struct tui_disasm_window): New struct.
6434         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6435         from tui_source_window::clear_detail.
6436         (tui_source_window_base): Rename from tui_source_window.
6437         (~tui_source_window_base): Rename from ~tui_source_window.
6438         (tui_alloc_win_info): Create a tui_disasm_window.
6439
6440 2019-06-25  Tom Tromey  <tom@tromey.com>
6441
6442         * tui/tui-data.h (struct tui_source_window)
6443         (struct tui_data_window): Declare destructors.
6444         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6445         destructors.
6446         (tui_win_info): Simplify.
6447
6448 2019-06-25  Tom Tromey  <tom@tromey.com>
6449
6450         * tui/tui-winsource.c (tui_display_main)
6451         (tui_update_source_windows_with_addr)
6452         (tui_update_all_breakpoint_info): Update.
6453         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6454         (new_height_ok, parse_scrolling_args): Update.
6455         * tui/tui-stack.c (tui_show_frame_info): Update.
6456         * tui/tui-data.h (struct tui_list): Remove.
6457         (tui_source_windows): Return a reference to a std::vector.
6458         * tui/tui-data.c (source_windows): Now a std::vector.
6459         (tui_source_windows): Change return type.
6460         (tui_clear_source_windows): Rewrite.
6461         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6462         (tui_free_all_source_wins_content): Rewrite.
6463
6464 2019-06-25  Tom Tromey  <tom@tromey.com>
6465
6466         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6467         (struct tui_data_window, struct tui_cmd_window): Declare
6468         clear_detail method.
6469         * tui/tui-data.c (tui_source_window::clear_detail)
6470         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6471         methods.
6472         (tui_clear_win_detail): Simplify.
6473
6474 2019-06-25  Tom Tromey  <tom@tromey.com>
6475
6476         * tui/tui-layout.c (make_source_window, make_disasm_window)
6477         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6478         Return the new window.
6479         (show_source_disasm_command, show_data)
6480         (show_source_or_disasm_and_command): Update.
6481
6482 2019-06-25  Tom Tromey  <tom@tromey.com>
6483
6484         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6485         parameter.  Return the new window.
6486         (show_source_disasm_command): Update and remove NULL check.
6487         (show_source_or_disasm_and_command): Update.
6488
6489 2019-06-25  Tom Tromey  <tom@tromey.com>
6490
6491         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6492
6493 2019-06-25  Tom Tromey  <tom@tromey.com>
6494
6495         * tui/tui-data.h (struct tui_win_info): Make constructor
6496         protected.  Make destructor virtual.  Add initializers.
6497         (tui_source_window, tui_data_window, tui_cmd_window): New
6498         classes.
6499         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6500         constructor.  Add "type" parameter.
6501         (tui_source_window, tui_data_window, tui_cmd_window): New
6502         constructors.
6503         (tui_alloc_win_info): Instantiate the appropriate subclass.
6504
6505 2019-06-25  Tom Tromey  <tom@tromey.com>
6506
6507         * tui/tui-win.c (tui_resize_all): Use delete.
6508         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6509         destructor.
6510         (tui_free_window): Don't declare.
6511         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6512         Update.
6513
6514 2019-06-25  Tom Tromey  <tom@tromey.com>
6515
6516         * tui/tui-data.h (struct tui_win_info): Add constructor.
6517         * tui/tui-data.c (tui_alloc_win_info): Use new.
6518         (tui_free_window): Use delete.
6519
6520 2019-06-22  Tom Tromey  <tom@tromey.com>
6521
6522         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6523         declare.
6524         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6525
6526 2019-06-22  Tom Tromey  <tom@tromey.com>
6527
6528         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6529         declare.
6530         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6531
6532 2019-06-22  Tom de Vries  <tdevries@suse.de>
6533
6534         * dwarf2read.c (create_addrmap_from_aranges)
6535         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6536         instead of '%zu'.
6537
6538 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6539
6540         * dwarf2read.h (dwarf2_section_info_def): Remove.
6541         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6542         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6543         std::vector<dwarf2_section_info>.
6544         (struct dwo_file) <~dwo_file>: Remove.
6545         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6546         types field.
6547         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6548         (dwarf2_read_debug_names): Likewise.
6549         (create_debug_types_hash_table): Change parameter type to
6550         array_view, adjust code accordingly.
6551         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6552         (partial_die_info::fixup): Likewise.
6553         (determine_prefix): Likewise.
6554         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6555
6556 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6557
6558         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6559         gdb_bfd_ref_ptr.
6560         <~dwo_file>: Remove call to gdb_bfd_unref.
6561         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6562         gdb_bfd_ref_ptr::get.
6563
6564 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6565
6566         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6567         type to htab_up.
6568         * dwarf2read.c (struct dwo_file): Initialize fields.
6569         <~dwo_file>: New.
6570         (free_dwo_file): Remove, move content to ~dwo_file.
6571         (struct dwo_file_deleter): Remove.
6572         (dwo_file_up>: Remove custom deleter.
6573         (free_dwo_files): Remove.
6574         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6575         dwo_files.
6576         (process_skeletonless_type_units): Call unique_ptr::get.
6577         (allocate_dwo_file_hash_table): Add deleter to created hash
6578         table.  Change return type to htab_up.
6579         (lookup_dwo_file_slot): Don't memset dwo_file, call
6580         unique_ptr::get.
6581         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6582         (create_dwo_unit_in_dwp_v2): Likewise.
6583         (open_and_init_dwo_file): Likewise.
6584         (free_dwo_file_from_slot): Remove.
6585
6586 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6587
6588         * dwarf2read.h (struct dwarf2_section_info) <readin,
6589         is_virtual>: Change type to bool.
6590         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6591         true instead of 1.
6592
6593 2019-06-19  Tom Tromey  <tom@tromey.com>
6594
6595         * tui/tui-data.h (tui_init_content_element): Don't declare.
6596
6597 2019-06-19  Tom Tromey  <tom@tromey.com>
6598
6599         * tui/tui-data.h (tui_init_win_info): Don't declare.
6600
6601 2019-06-19  Tom de Vries  <tdevries@suse.de>
6602
6603         * dwarf2read.h (abstract_to_concrete): Change type to
6604         std::unordered_map<sect_offset, std::vector<sect_offset>,
6605         gdb::hash_enum<sect_offset>>.
6606
6607 2019-06-19  Tom Tromey  <tromey@adacore.com>
6608
6609         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6610         EVAL_AVOID_SIDE_EFFECTS specially.
6611
6612 2019-06-19  Tom Tromey  <tromey@adacore.com>
6613
6614         * source-cache.c (highlighter): New global.
6615         (source_cache::get_source_lines): Create a highlighter on demand.
6616
6617 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6618
6619         * defs.h (deprecated_interactive_hook): Delete declaration.
6620         * interps.c (clear_interpreter_hooks): Remove use of
6621         deprecated_interactive_hook.
6622         * top.c (deprecated_interactive_hook): Delete definition.
6623         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6624
6625 2019-06-18  Tom de Vries  <tdevries@suse.de>
6626
6627         PR gdb/24515
6628         * dwarf2read.h (abstract_to_concrete): Change type from
6629         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6630         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6631         * dwarf2read.c (read_variable): Update.
6632         (dwarf2_fetch_die_loc_sect_off): Update.
6633
6634 2019-06-17  Tom de Vries  <tdevries@suse.de>
6635
6636         PR gdb/24617
6637         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6638         accessing parent[parent_len - 1].
6639
6640 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6641
6642         PR gdb/24364
6643         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6644         call dtrace_process_dof with NULL dof.
6645
6646 2019-06-16  Tom de Vries  <tdevries@suse.de>
6647
6648         PR gdb/24445
6649         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6650
6651 2019-06-16  Tom Tromey  <tom@tromey.com>
6652
6653         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6654         (make_all_visible): Use address of member.
6655
6656 2019-06-16  Tom Tromey  <tom@tromey.com>
6657
6658         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6659         (tui_free_window, free_content, free_content_elements): Remove
6660         unnecessary cast.
6661         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6662         cast.
6663         * tui/tui-regs.c (tui_show_register_group)
6664         (tui_display_registers_from, tui_display_reg_element_at_line):
6665         Remove unnecessary cast.
6666
6667 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6668
6669         * linux-nat.c (normal_mask): Delete.
6670         (_initialize_linux_nat): Don't initialise normal_mask.
6671
6672 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6673
6674         PR gdb/24445
6675         * dwarf-index-write.h (write_psymtabs_to_index): Add
6676         dwz_basename parameter.
6677         * dwarf-index-write.c (write_gdbindex): Move file writing to
6678         write_gdbindex_1.  Change return type void.
6679         (assert_file_size): Move up, remove filename parameter.
6680         (write_gdbindex_1): New function.
6681         (write_debug_names): Change return type to void, call
6682         assert_file_size.
6683         (struct index_wip_file): New struct.
6684         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6685         file logic to index_wip_file.  Write index for dwz file if
6686         needed.
6687         (save_gdb_index_command): Pass basename of dwz file, if present.
6688         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6689         build-id of dwz file, if present.
6690         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6691         (dwarf2_get_dwz_file): Likewise.
6692         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6693         (dwarf2_get_dwz_file): Likewise.
6694
6695 2019-06-16  Tom Tromey  <tom@tromey.com>
6696
6697         * coffread.c (process_coff_symbol): Use xstrdup.
6698         * value.c (create_internalvar): Use xstrdup.
6699
6700 2019-06-16  Tom Tromey  <tom@tromey.com>
6701
6702         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6703         * breakpoint.c (stopin_command, stopat_command)
6704         (until_break_command, decode_location_default): Remove unnecessary
6705         cast.
6706         * utils.c (subset_compare): Remove unnecessary cast.
6707         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6708         cast.
6709         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6710         cast.
6711         * infcmd.c (path_command): Remove unnecessary cast.
6712         * coffread.c (decode_type): Remove unnecessary cast.
6713         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6714         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6715         * tui/tui-stack.c (tui_show_locator_content)
6716         (tui_show_frame_info): Remove unnecessary cast.
6717         * tui/tui-win.c (tui_scroll_forward_command)
6718         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6719         (parse_scrolling_args): Remove unnecessary cast.
6720         * tui/tui-data.c (init_win_info, tui_del_window)
6721         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6722         (free_content_elements): Remove unnecessary cast.
6723         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6724         unnecessary cast.
6725         * tui/tui-source.c (tui_set_source_content)
6726         (tui_vertical_source_scroll): Remove unnecessary cast.
6727         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6728         cast.
6729         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6730         * tui/tui-regs.c (tui_display_registers_from)
6731         (tui_display_register): Remove unnecessary cast.
6732         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6733         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6734         (make_visible): Remove unnecessary cast.
6735         * tui/tui-winsource.c (tui_erase_source_content)
6736         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6737         unnecessary cast.
6738         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6739         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6740         * stabsread.c (read_type, read_array_type, read_range_type):
6741         Remove unnecessary cast.
6742         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6743         (parse_symbol, parse_type, upgrade_type, parse_external)
6744         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6745         unnecessary cast.
6746         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6747
6748 2019-06-16  Tom Tromey  <tom@tromey.com>
6749
6750         * tui/tui-data.c (tui_alloc_generic_win_info)
6751         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6752         checks.
6753
6754 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6755             Andrew Burgess  <andrew.burgess@embecosm.com>
6756
6757         * f-typeprint.c (f_print_type): Don't return early for not
6758         associated or not allocated types.
6759         (f_type_print_varspec_suffix): Add print_rank parameter and print
6760         ranks of array types in case they dangling.
6761         (f_type_print_base): Add print_rank parameter.
6762
6763 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6764
6765         * NEWS: Mention new MI commands.
6766         * break-catch-throw.c (enum exception_event_kind): Move to
6767         breakpoint.h.
6768         (print_mention_exception_catchpoint): Output text as a single
6769         message.
6770         (catch_exception_command_1): Rename to...
6771         (catch_exception_event): ...this, make non-static, update header
6772         command, and change some parameter types.
6773         (catch_catch_command): Update for changes to
6774         catch_exception_command_1.
6775         (catch_throw_command): Likewise.
6776         (catch_rethrow_command): Likewise.
6777         * breakpoint.c (enum exception_event_kind): Delete.
6778         * breakpoint.h (enum exception_event_kind): Moved here from
6779         break-catch-throw.c.
6780         (catch_exception_event): Declare.
6781         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6782         (mi_cmd_catch_throw): New function.
6783         (mi_cmd_catch_rethrow): New function.
6784         (mi_cmd_catch_catch): New function.
6785         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6786         'catch-catch' entries.
6787         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6788         (mi_cmd_catch_rethrow): Declare.
6789         (mi_cmd_catch_catch): Declare.
6790
6791 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6792
6793         * annotate.c (annotate_source_line): Change return type to void,
6794         update implementation to match.
6795         * annotate.h (annotate_source_line): Change return type to void,
6796         update header comment.
6797         * stack.c (print_frame_info): Don't change what frame information
6798         is printed based on whether annotations are on or not.
6799
6800 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6801
6802         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6803         (annotate_source): Make static.
6804         (annotate_source_line): Moved from source.c and renamed from
6805         identify_source_line.  Update the return type.
6806         * annotate.h (annotate_source): Delete declaration.
6807         (annotate_source_line): Declaration moved from source.h, and
6808         renamed from identify_source_line.  Return type updated.
6809         * source.c (identify_source_line): Moved to annotate.c and renamed
6810         to annotate_source_line.
6811         (info_line_command): Remove check of annotation_level.
6812         * source.h (identify_source_line): Move declaration to annotate.h
6813         and rename to annotate_source_line.
6814         * stack.c: Add 'annotate.h' include.
6815         (print_frame_info): Remove check of annotation_level before
6816         calling annotate_source_line.
6817
6818 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6819
6820         * source-cache.c (source_cache::get_plain_source_lines): Use
6821         open_source_file_with_line_charpos instead of just
6822         open_source_file, remove call to find_source_lines.
6823         (source_cache::get_source_lines): Likewise.
6824         * source.c (find_source_lines): Make static.
6825         (get_filename_and_charpos): Renamed into...
6826         (open_source_file_with_line_charpos): ..this along with changes to
6827         return a scoped_fd, and some other minor clean ups.
6828         (identify_source_line): Use open_source_file_with_line_charpos.
6829         (search_command_helper): Use open_source_file_with_line_charpos
6830         instead of just open_source_file, remove call to
6831         find_source_lines.
6832         * source.h (open_source_file_with_line_charpos): Declare new
6833         function.
6834         (find_source_lines): Delete declaration.
6835
6836 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6837
6838         * source.c (get_filename_and_charpos): Remove fullname
6839         parameter.
6840         (identify_source_line): Update call to get_filename_and_charpos.
6841
6842 2019-06-14  Tom Tromey  <tromey@adacore.com>
6843
6844         PR gdb/24502:
6845         * ui-style.h (skip_ansi_escape): Update comment.
6846         * ui-file.h (class no_terminal_escape_file): New class.
6847         * ui-file.c (no_terminal_escape_file::write)
6848         (no_terminal_escape_file::puts): New methods.
6849         * cli/cli-logging.c (handle_redirections): Use
6850         no_terminal_escape_file.
6851
6852 2019-06-14  Tom Tromey  <tromey@adacore.com>
6853
6854         * NEWS: Move convenience variable news above Python news.
6855
6856 2019-06-14  Tom Tromey  <tom@tromey.com>
6857
6858         * gnulib: Move directory to top-level.
6859         * configure.ac: Don't configure gnulib.
6860         * configure: Rebuild.
6861         * common/common-defs.h: Use new path to gnulib.
6862         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6863         (GNULIB_H): Remove.
6864         (INCGNU): Look in new gnulib location.
6865         (HFILES_NO_SRCDIR): Remove gnulib files.
6866         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6867         (generated_files): Remove GNULIB_H.
6868         ($(LIBGNU), all-lib): Remove targets.
6869         (distclean): Don't mention GNULIB_BUILDDIR.
6870         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6871
6872 2019-06-14  Tom Tromey  <tromey@adacore.com>
6873
6874         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6875         Warn if symbol file does not provide any symbols.
6876
6877 2019-06-14  Tom Tromey  <tromey@adacore.com>
6878
6879         * source.c (find_and_open_source): Respect basenames_may_differ.
6880
6881 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6882
6883         * annotate.c (annotate_breakpoints_invalid): Make use of
6884         scoped_restore_terminal_state.
6885         (annotate_frames_invalid): Likewise.
6886
6887 2019-06-14  Tom Tromey  <tromey@adacore.com>
6888
6889         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6890         allow assignment to an internalvar.
6891
6892 2019-06-14  Tom Tromey  <tromey@adacore.com>
6893
6894         * ada-lex.l: Allow "_" in attribute names.
6895
6896 2019-06-14  Tom Tromey  <tromey@adacore.com>
6897
6898         PR gdb/24653:
6899         * regcache.c (registers_changed): Don't call alloca.
6900         * top.c (execute_command): Don't call alloca.
6901
6902 2019-06-13  Pedro Alves  <palves@redhat.com>
6903
6904         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6905         'expression'.  When parsing an expression, error out if there's
6906         junk after "unlimited".
6907         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6908         (do_set_command): Adjust calls to is_unlimited_literal.
6909
6910 2019-06-13  Pedro Alves  <palves@redhat.com>
6911
6912         * compile/compile.c (make_compile_options_def_group): Add braces
6913         around array_view initializer.
6914         * thread.c (make_thread_apply_all_options_def_group)
6915         (make_thread_apply_all_options_def_group): Likewise.
6916
6917 2019-06-13  Pedro Alves  <palves@redhat.com>
6918
6919         * NEWS (New commands): Mention "maint test-options
6920         require-delimiter", "maint test-options unknown-is-error", "maint
6921         test-options unknown-is-operand" and "maint show
6922         test-options-completion-result".
6923         (New command options, command completion): New section.
6924         (Completion improvements): New section.
6925         Mention that you can abbreviate "unlimited".
6926
6927 2019-06-13  Pedro Alves  <palves@redhat.com>
6928
6929         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6930         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6931         * unittests/cli-utils-selftests.c (test_parse_flags)
6932         (test_parse_flags_qcs): Delete.
6933         (test_cli_utils): Don't call deleted functions.
6934
6935 2019-06-13  Pedro Alves  <palves@redhat.com>
6936
6937         * thread.c: Include "cli/cli-option.h".
6938         (tp_array_compar_ascending): Global.
6939         (tp_array_compar): Delete function.
6940         (tp_array_compar_ascending, tp_array_compar_descending): New
6941         functions.
6942         (ascending_option_def, qcs_flag_option_def)
6943         (thr_qcs_flags_option_defs)
6944         (make_thread_apply_all_options_def_group)
6945         (make_thread_apply_options_def_group): New.
6946         (thread_apply_all_command): Use gdb::option::process_options.
6947         (thread_apply_command_completer)
6948         (thread_apply_all_command_completer): New.
6949         (thread_apply_command): Use gdb::option::process_options.
6950         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6951         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6952         to generate help text of "thread apply".  Adjust "taas"'s help.
6953         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6954         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6955
6956 2019-06-13  Pedro Alves  <palves@redhat.com>
6957
6958         * thread.c (thread_apply_command): Check for invalid TID with
6959         isdigit instead of !isalpha.
6960
6961 2019-06-13  Pedro Alves  <palves@redhat.com>
6962
6963         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6964         (validate_flags_qcs): New.
6965         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6966         (validate_flags_qcs): Declare.
6967         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6968         (make_frame_apply_options_def_group): New.
6969         (frame_apply_command_count): Process options with
6970         gdb::option::process_options.
6971         (frame_apply_completer): New.
6972         (frame_apply_level_completer, frame_apply_all_completer)
6973         (frame_apply_completer): New.
6974         (_initialize_stack): Update help of "frame apply", "frame apply
6975         level", "frame apply all" and "faas" to mention supported options
6976         and install command completers.
6977         * stack.h (frame_apply_all_completer): Declare.
6978         * thread.c: Include "stack.h".
6979         (tfaas_command): Add "--".
6980         (_initialize_thread): Update help "tfaas" to mention supported
6981         options and install command completer.
6982
6983 2019-06-13  Pedro Alves  <palves@redhat.com>
6984
6985         * completer.c (complete_nested_command_line): New.
6986         (gdb_completion_word_break_characters_throw): Add assertion.
6987         * completer.h (complete_nested_command_line): Declare.
6988
6989 2019-06-13  Pedro Alves  <palves@redhat.com>
6990
6991         * stack.c (parse_backtrace_qualifiers): New.
6992         (backtrace_command): Use it.
6993         (backtrace_command_completer): Complete on qualifiers.
6994
6995 2019-06-13  Pedro Alves  <palves@redhat.com>
6996
6997         * frame.c: Include "cli/cli-option.h.
6998         (user_set_backtrace_options): New.
6999         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7000         Delete.
7001         (get_prev_frame): Adjust.
7002         (boolean_option_def, uinteger_option_def)
7003         (set_backtrace_option_defs): New.
7004         (_initialize_frame): Adjust and use
7005         gdb::option::add_setshow_cmds_for_options to install "set
7006         backtrace past-main" and "set backtrace past-entry".
7007         * frame.h: Include "cli/cli-option.h".
7008         (struct frame_print_options): Forward declare.
7009         (print_frame_arguments_all, print_frame_arguments_scalars)
7010         (print_frame_arguments_none): Declare.
7011         (print_entry_values): Delete declaration.
7012         (struct frame_print_options, user_frame_print_options): New.
7013         (struct set_backtrace_options): New.
7014         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7015         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7016         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7017         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7018         (list_args_or_locals): Add frame_print_options parameter.
7019         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7020         * python/py-framefilter.c (enumerate_args): Pass down
7021         USER_FRAME_PRINT_OPTIONS.
7022         * stack.c: Include "cli/cli-option.h".
7023         (print_frame_arguments_all, print_frame_arguments_scalars)
7024         (print_frame_arguments_none): Declare.
7025         (print_raw_frame_arguments, print_entry_values): Delete.
7026         (user_frame_print_options): New.
7027         (boolean_option_def, enum_option_def, frame_print_option_defs):
7028         New.
7029         (struct backtrace_cmd_options): New.
7030         (bt_flag_option_def): New.
7031         (backtrace_command_option_defs): New.
7032         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7033         (print_frame_arg, read_frame_arg, print_frame_args)
7034         (print_frame_info, print_frame): Add frame_print_options parameter
7035         and use it.
7036         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7037         (backtrace_command_1): Add frame_print_options and
7038         backtrace_cmd_options parameters and use them.
7039         (make_backtrace_options_def_group): New.
7040         (backtrace_command): Process command options with
7041         gdb::option::process_options.
7042         (backtrace_command_completer): New.
7043         (_initialize_stack): Extend "backtrace"'s help to mention
7044         supported options.  Install completer for "backtrace".
7045         Install some settings commands with add_setshow_cmds_for_options.
7046
7047 2019-06-13  Pedro Alves  <palves@redhat.com>
7048
7049         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7050         and that "set/show print raw frame-arguments" are now deprecated.
7051
7052         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7053         command.
7054         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7055         * stack.c (_initialize_stack): Install "set/show print
7056         raw-frame-arguments", and deprecate "set/show print raw
7057         frame-arguments".
7058         * valprint.c (_initialize_valprint): Deprecate "set/show print
7059         raw".
7060
7061 2019-06-13  Pedro Alves  <palves@redhat.com>
7062
7063         * compile/compile.c (struct compile_options): New.
7064         (compile_flag_option_def, compile_command_option_defs)
7065         (make_compile_options_def_group): New.
7066         (compile_file_command): Handle options with
7067         gdb::option::process_options.
7068         (compile_file_command_completer): New function.
7069         (compile_code_command): Handle options with
7070         gdb::option::process_options.
7071         (compile_code_command_completer): New function.
7072         (_initialize_compiler): Install completers for "compile code" and
7073         "compile file".  Mention available options in "compile code" and
7074         "compile code"'s help.
7075         * completer.c (advance_to_completion_word): New, factored out from
7076         ...
7077         (advance_to_expression_complete_word_point): ... this.
7078         (advance_to_filename_complete_word_point): New.
7079         * completer.h (advance_to_filename_complete_word_point): New
7080         declaration.
7081
7082 2019-06-13  Pedro Alves  <palves@redhat.com>
7083
7084         * compile/compile.c: Include "cli/cli-option.h".
7085         (compile_print_value): Scope data pointer is now a
7086         value_print_options pointer; adjust.
7087         (compile_print_command): Process options.  Scope data pointer is
7088         now a value_print_options pointer; adjust.
7089         (_initialize_compile): Update "compile print"'s help to include
7090         supported options.  Install a completer for "compile print".
7091         * cp-valprint.c (show_vtblprint, show_objectprint)
7092         (show_static_field_print): Delete.
7093         (_initialize_cp_valprint): Don't install "set print
7094         static-members", "set print vtbl", "set print object" here.
7095         * printcmd.c: Include "cli/cli-option.h" and
7096         "common/gdb_optional.h".
7097         (print_command_parse_format): Rework to fill in a
7098         value_print_options instead of a format_data.
7099         (print_value): Change parameter type from format_data pointer to
7100         value_print_options reference.  Adjust.
7101         (print_command_1): Process options.  Adjust to pass down a
7102         value_print_options.
7103         (print_command_completer): New.
7104         (_initialize_printcmd): Install print_command_completer as
7105         handle_brkchars completer for the "print" command.  Update
7106         "print"'s help to include supported options.
7107         * valprint.c: Include "cli/cli-option.h".
7108         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7109         here from cp-valprint.c.
7110         (boolean_option_def, uinteger_option_def)
7111         (value_print_option_defs, make_value_print_options_def_group):
7112         New.  Use gdb::option::add_setshow_cmds_for_options to install
7113         "set print elements", "set print null-stop", "set print repeats",
7114         "set print pretty", "set print union", "set print array", "set
7115         print address", "set print symbol", "set print array-indexes".
7116         * valprint.h: Include <string> and "cli/cli-option.h".
7117         (make_value_print_options_def_group): Declare.
7118         (print_value): Change parameter type from format_data pointer to
7119         value_print_options reference.
7120         (print_command_completer): Declare.
7121
7122 2019-06-13  Pedro Alves  <palves@redhat.com>
7123
7124         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7125         (COMMON_SFILES): Add maint-test-settings.c.
7126         * cli/cli-decode.c (boolean_enums): New global, factored out from
7127         ...
7128         (add_setshow_boolean_cmd): ... here.
7129         * cli/cli-decode.h (boolean_enums): Declare.
7130         * cli/cli-option.c: New file.
7131         * cli/cli-option.h: New file.
7132         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7133         factored out from ...
7134         (parse_cli_boolean_value(const char *)): ... this.
7135         (is_unlimited_literal): Change parameter type to pointer to
7136         pointer.  Adjust and advance ARG pointer.
7137         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7138         (parse_cli_var_enum): New, factored out from ...
7139         (do_set_command): ... this.  Adjust.
7140         * cli/cli-setshow.h (parse_cli_boolean_value)
7141         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7142         (parse_cli_var_enum): Declare.
7143         * cli/cli-utils.c: Include "cli/cli-option.h".
7144         (get_ulongest): New.
7145         * cli/cli-utils.h (get_ulongest): Declare.
7146         (check_for_argument): New overloads.
7147         * maint-test-options.c: New file.
7148
7149 2019-06-13  Pedro Alves  <palves@redhat.com>
7150
7151         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7152         parse a range if "-" is at the end of the string.
7153
7154 2019-06-13  Pedro Alves  <palves@redhat.com>
7155
7156         * cli/cli-setshow.c (parse_auto_binary_operation)
7157         (parse_cli_boolean_value): Don't allow "o".
7158
7159 2019-06-13  Pedro Alves  <palves@redhat.com>
7160
7161         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7162         * NEWS: Mention maint test-settings KIND.
7163         * maint-test-settings.c: New file.
7164
7165 2019-06-13  Pedro Alves  <palves@redhat.com>
7166
7167         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7168         completer.
7169         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7170         "set" completers.
7171
7172 2019-06-13  Pedro Alves  <palves@redhat.com>
7173
7174         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7175         after item.
7176
7177 2019-06-13  Pedro Alves  <palves@redhat.com>
7178
7179         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7180
7181 2019-06-13  Pedro Alves <palves@redhat.com>
7182
7183         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7184         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7185         call.
7186         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7187         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7188         calls.
7189         (check_for_argument): Skip spaces after argument.
7190
7191 2019-06-13  Pedro Alves  <palves@redhat.com>
7192
7193         * thread.c (thread_apply_command): Adjust TID parsing.
7194         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7195         detected before end of string.
7196         (tid_is_in_list): Error out if LIST is invalid.
7197
7198 2019-06-13  Pedro Alves  <palves@redhat.com>
7199
7200         * completer.c (complete_line_internal_1): Rewind completion word
7201         point.
7202         (completion_tracker::advance_custom_word_point_by): Change
7203         parameter type to int.
7204         * completer.h (completion_tracker::advance_custom_word_point_by):
7205         Likewise.
7206
7207 2019-06-13  Pedro Alves  <palves@redhat.com>
7208
7209         * completer.c (advance_to_completion_word): Handle delimiters.
7210
7211 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7212
7213         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7214
7215 2019-06-11  Tom Tromey  <tom@tromey.com>
7216
7217         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7218         (xmalloc_failed): Move to alloc.c.
7219         * alloc.c: New file.
7220         * Makefile.in (COMMON_SFILES): Add alloc.c.
7221
7222 2019-06-11  Tom Tromey  <tom@tromey.com>
7223
7224         * nat/linux-waitpid.c: Don't include server.h.
7225         (linux_debug): Remove.
7226         (my_waitpid): Update.
7227
7228 2019-06-11  Tom Tromey  <tromey@adacore.com>
7229
7230         * infcall.c (_initialize_infcall): Remove trailing newline from
7231         help.
7232         * user-regs.c (_initialize_user_regs): Remove trailing newline
7233         from help.
7234         * typeprint.c (_initialize_typeprint): Remove trailing newline
7235         from help.
7236         * reverse.c (_initialize_reverse): Remove trailing newlines from
7237         help.
7238         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7239         from help.
7240         * language.c (add_set_language_command): Remove trailing newline
7241         from help.
7242         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7243         help.
7244         * disasm.c (_initialize_disasm): Remove trailing newline from
7245         help.
7246         * top.c (init_main): Remove trailing newline from help.
7247         * interps.c (_initialize_interpreter): Remove trailing newline
7248         from help.
7249         * btrace.c (_initialize_btrace): Remove trailing newlines from
7250         help.
7251         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7252         from help.
7253         * python/python.c (_initialize_python): Remove trailing newline
7254         from help.
7255         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7256         help.
7257         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7258         from help.  Reformat some text.
7259         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7260         from help.
7261         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7262         newline from help.
7263
7264 2019-06-11  Tom Tromey  <tromey@adacore.com>
7265
7266         * darwin-nat.c (darwin_decode_exception_message)
7267         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7268
7269 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7270
7271         * valops.c (value_slice): Check for not allocated or not
7272         associated values.
7273
7274 2019-06-10  Tom de Vries  <tdevries@suse.de>
7275
7276         PR gdb/24618
7277         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7278         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7279         invalid.
7280
7281 2019-06-10  Tom de Vries  <tdevries@suse.de>
7282
7283         PR gdb/24611
7284         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7285         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7286
7287 2019-06-10  Tom de Vries  <tdevries@suse.de>
7288
7289         PR symtab/24545
7290         * symtab.c (struct demangled_name_entry): Add language field.
7291         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7292         static minimal symbol".  Set and use language field.
7293
7294 2019-06-10  Tom Tromey  <tromey@adacore.com>
7295
7296         * ada-lang.c (_initialize_ada_language): Update help text.
7297
7298 2019-06-10  Tom Tromey  <tromey@adacore.com>
7299
7300         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7301         with a newline.
7302         * guile/guile.c (handle_boot_error): Don't end warning with a
7303         newline.
7304         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7305         warning with a newline.
7306         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7307         newline.
7308         (s12z_frame_cache): Likewise.
7309         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7310         a newline.
7311         * solib-svr4.c (disable_probes_interface): Don't end warning with
7312         a newline.
7313         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7314         newline.
7315         * python/python.c (do_finish_initialization): Don't end warning
7316         with a newline.
7317
7318 2019-06-10  Tom Tromey  <tom@tromey.com>
7319
7320         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7321         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7322         gdbpy_enter.
7323
7324 2019-06-10  Tom Tromey  <tromey@adacore.com>
7325
7326         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7327         data.
7328         (elf_new_init): Don't call stabsread_new_init.
7329         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7330         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7331         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7332
7333 2019-06-10  Tom de Vries  <tdevries@suse.de>
7334
7335         PR symtab/16264
7336         PR symtab/24517
7337         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7338
7339 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7340
7341         * source.c (find_and_open_source): Also rewrite relative file
7342         names.
7343
7344 2019-04-26  Amos Bird  <amosbird@gmail.com>
7345
7346         * annotate.c (annotate_thread_exited): Add "thread-exited"
7347         annotation.
7348
7349 2019-06-06  Tom Tromey  <tromey@adacore.com>
7350
7351         * maint.h (class scoped_command_stats): Use
7352         DISABLE_COPY_AND_ASSIGN.
7353         <print_time>: New method.
7354         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7355         print_time.
7356         (scoped_command_stats::print_time): New method.
7357
7358 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7359
7360         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7361         instructions of lengths 6 or 8 bytes.
7362
7363 2019-06-04  Pedro Alves  <palves@redhat.com>
7364
7365         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7366
7367         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7368         * breakpoint.c (condition_completer): Likewise.
7369         * cli/cli-dump.c (scan_expression): Likewise.
7370         * common/filestuff.c (mkdir_recursive): Likewise.
7371         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7372         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7373         (gdb_abspath): Likewise.
7374         * compile/compile-cplus-types.c
7375         (compile_cplus_instance::decl_name): Likewise.
7376         * completer.c (complete_explicit_location):
7377         (signal_completer, reg_or_group_completer_1): Likewise.
7378         * cp-support.c (cp_remove_params_if_any): Likewise.
7379         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7380         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7381         * infcmd.c (strip_bg_char): Likewise.
7382         * linespec.c (copy_token_string): Likewise.
7383         * mi/mi-main.c (output_cores): Likewise.
7384         * psymtab.c (psymtab_search_name):
7385         * symfile.c (test_set_ext_lang_command): Likewise.
7386         * target.c (target_fileio_read_stralloc): Likewise.
7387         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7388         * value.c (complete_internalvar): Likewise.
7389
7390 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7391
7392         Add objfile property to gdb.Type.
7393         * NEWS: Mention Python API addition.
7394         * python/py-type.c (typy_get_objfile): New method.
7395
7396 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7397
7398         * NEWS: Mention the new set|show style [title|highlight].
7399         Mention changes to "show style", "help" and "apropos".
7400
7401 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7402
7403         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7404         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7405         instead of print_help_for_command.
7406         (print_doc_of_command): New function.
7407         (help_list): Add 'apropos -v word' suggestion.
7408         (print_help_for_command): Style the command name using title style.
7409         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7410         (_initialize_cli_cmds): Describe -v in apropos_command help.
7411
7412 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7413
7414         * cli/cli-style.h (cli_style_option): Add name in constructor,
7415         add m_name class member, add constructor with intensity,
7416         add name class function.
7417         (cli_style_option::add_setshow_commands): Remove name argument.
7418         (highlight_style, title_style): New styles.
7419         * cli/cli-style.c (do_show): New function that shows a style
7420         characteristic styling the style name with itself.
7421         (set_style_name): New function.
7422         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7423         Update all callers according to the changes in cli/cli-style.h.
7424         * utils.h (fputs_highlighted): New function.
7425         * utils.c (fputs_highlighted): Likewise.
7426
7427 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7428
7429         * NEWS: Mention new pipe command and new convenience variables.
7430
7431 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7432
7433         * cli/cli-cmds.c (pipe_command): New function.
7434         (_initialize_cli_cmds): Call add_com for pipe_command.
7435         Define | as an alias for pipe.
7436         (exit_status_set_internal_vars): New function.
7437         (shell_escape): Call exit_status_set_internal_vars.
7438         cli/cli-decode.c (find_command_name_length): Recognize | as
7439         a single character command.
7440
7441 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7442
7443         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7444         top.c (execute_command_to_ui_file): New function, mostly a copy
7445         of execute_command_to_string.
7446         (execute_command_to_string): Implement by calling
7447         execute_command_to_ui_file.
7448
7449 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7450
7451         * top.h (saved_command_line): Remove declaration.
7452         * top.c (previous_saved_command_line, previous_repeat_arguments):
7453         New variables.
7454         (saved_command_line): Make static, define together with other
7455         'repeat variables'.
7456         (dont_repeat): Clear repeat_arguments.
7457         (repeat_previous, get_saved_command_line, save_command_line):
7458         New functions.
7459         (gdb_init): Initialize saved_command_line
7460         and previous_saved_command_line.
7461         * main.c (captured_main_1): Remove saved_command_line initialization.
7462         * event-top.c (handle_line_of_input): Update to use
7463         the new 'repeat' related functions instead of direct access to
7464         saved_command_line.
7465         * command.h (repeat_previous, get_saved_command_line,
7466         save_command_line): New declarations.
7467         (dont_repeat): Add comment.
7468
7469 2019-05-30  Tom Tromey  <tromey@adacore.com>
7470
7471         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7472         Fix comment.
7473         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7474
7475 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7476
7477         PR cli/24587
7478         * completer.c (complete): Initialize variable word.
7479
7480 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7481
7482         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7483         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7484         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7485         'body' is NULL to the outter 'if', protecting the '!is_define'
7486         situation as well.
7487
7488 2019-05-29  Tom Tromey  <tromey@adacore.com>
7489
7490         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7491         (dwarf_unknown): New function.
7492         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7493         (dwarf_type_encoding_name): Use dwarf_unknown.
7494
7495 2019-05-29  Tom Tromey  <tromey@adacore.com>
7496
7497         PR c++/20020:
7498         * cp-valprint.c (cp_print_value_fields): Call
7499         cp_print_static_field inside "try".
7500
7501 2019-05-29  Tom Tromey  <tromey@adacore.com>
7502
7503         * inflow.c (struct terminal_info): Add default operator=.
7504         * configure: Rebuild.
7505         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7506         -Wdeprecated-copy-dtor, -Wredundant-move.
7507
7508 2019-05-29  Tom Tromey  <tromey@adacore.com>
7509
7510         * NEWS: Add entry.
7511         * infcmd.c (print_return_value_1): Handle finish_print
7512         option.
7513         (show_print_finish): New function.
7514         (_initialize_infcmd): Add "set/show print finish" commands.
7515         * valprint.c (user_print_options): Initialize new member.
7516         * valprint.h (struct value_print_options) <finish_print>: New
7517         member.
7518
7519 2019-05-28  Tom Tromey  <tromey@adacore.com>
7520
7521         * ada-lang.c (ada_remove_Xbn_suffix)
7522         (find_old_style_renaming_symbol)
7523         (parse_old_style_renaming): Remove.
7524         (ada_find_renaming_symbol): Don't call
7525         find_old_style_renaming_symbol.
7526         (ada_is_renaming_symbol): Rename from
7527         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7528         bool.  Now static.
7529         (ada_read_var_value): Update and simplify.
7530         * ada-exp.y (write_var_or_type): Remove old code.
7531
7532 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7533
7534         PR gdb/25010
7535         * event-top.c: Remove include comment.
7536         * inflow.c (class scoped_ignore_sigttou): Move from here...
7537         * inflow.h (class scoped_ignore_sigttou): ...to here.
7538         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7539         * top.c:  Remove include comment.
7540
7541 2019-05-27  Tom Tromey  <tom@tromey.com>
7542
7543         * NEWS: Fix typo.
7544
7545 2019-05-22  Tom Tromey  <tromey@adacore.com>
7546
7547         * target.c (target_follow_exec): Constify parameter.
7548         * target-delegates.c: Rebuild.
7549         * remote.c (remote_target::follow_exec): Constify parameter.
7550         * infrun.c (follow_exec): Constify parameter.
7551         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7552         (target_follow_exec): Likewise.
7553
7554 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7555
7556         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7557         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7558
7559 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7560
7561         * NEWS: Add debugredirect and testsuite sections.
7562
7563 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7564
7565         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7566         target descriptions using exclusively floating point register name
7567         aliases.
7568
7569 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7570
7571         PR gdb/18644:
7572         * f-lang.c (build_fortran_types): Handle the case where
7573         gdbarch_floatformat_for_type returns a nullptr.
7574
7575 2019-05-21  Tom de Vries  <tdevries@suse.de>
7576
7577         PR cli/24587
7578         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7579
7580 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7581
7582         PR gdb/18644:
7583         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7584         16-byte floats.
7585         * i386-tdep.c (i386_floatformat_for_type): Use
7586         floatformats_ia64_quad for the 16-byte floating point component
7587         within a fortran 32-byte complex number.
7588
7589 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7590
7591         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7592         delete default constructor.
7593         (find_partial_die): Update to return const struct.
7594         (partial_die_parent_scope): Move variable declaration into scope
7595         of its use and change its type to auto.
7596         (guess_partial_die_structure_name): Likewise.
7597         (partial_die_info::fixup): Likewise.
7598
7599 2019-05-17  Tom Tromey  <tromey@adacore.com>
7600
7601         * source.c (find_and_open_source): Remove cast.
7602
7603 2019-05-17  Tom Tromey  <tromey@adacore.com>
7604
7605         * annotate.c (annotate_source): Make "filename" const.
7606         * annotate.h (annotate_source): Use const.
7607
7608 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7609
7610         * disasm.c (set_disassembler_options): Send errors to stderr.
7611
7612 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7613
7614         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7615         (cli_interp_base::set_logging): Check debug_redirect.
7616         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7617         * cli/cli-logging.c (debug_redirect): Add static variable.
7618         (pop_output_files): Add default param.
7619         (handle_redirections): Print debug setting.
7620         (show_logging_command): Likewise.
7621         (_initialize_cli_logging): Add debugredirect command.
7622         * interps.c (current_interp_set_logging): Add debug_redirect
7623         parameter.
7624         * interps.h (set_logging): Add debug_redirect parameter.
7625         (current_interp_set_logging): Likewise.
7626         * mi/mi-common.h: Likewise.
7627         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7628
7629 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7630             Tom Tromey  <tromey@adacore.com>
7631
7632         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7633         directly.
7634         * cli/cli-interp.h (make_logging_output): Remove declaration.
7635         * cli/cli-logging.c (make_logging_output): Remove function.
7636         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7637         directly.
7638         * ui-file.c (tee_file::tee_file): Remove bools.
7639         (tee_file::~tee_file): Remove deletes.
7640         * ui-file.h (tee_file): Remove bools.
7641
7642 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7643
7644         * mi/mi-cmds.h (mi_cmd_complete): New function.
7645         * mi/mi-main.c (mi_cmd_complete): Likewise.
7646         * mi/mi-cmds.c: Define new MI command -complete.
7647         * NEWS: Mention new -complete command.
7648
7649 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7650
7651         * completer.h (complete): New function.
7652         * completer.c (complete): Likewise.
7653         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7654         function defined in completer.h.
7655
7656 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7657
7658         * MAINTAINERS (Write After Approval): Add myself.
7659
7660 2019-05-17  Tom de Vries  <tdevries@suse.de>
7661
7662         PR gdb/24094
7663         * dwarf2read.c (struct cu_partial_die_info): New struct.
7664         (find_partial_die): Return cu_partial_die_info.
7665         (partial_die_parent_scope, guess_partial_die_structure_name)
7666         (partial_die_info::fixup): Handle new return type of find_partial_die.
7667
7668 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7669
7670         PR breakpoints/24541
7671         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7672         "std::string", simplifying the algorithm.
7673
7674 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7675
7676         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7677         (stap_static_probe_ops::get_probes): Likewise.
7678
7679 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7680
7681         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7682         '-')" and "else if".
7683         (stap_parse_single_operand): Join checks for
7684         "gdbarch_stap_parse_special_token_p" and
7685         "gdbarch_stap_parse_special_token" in the same "if" statement.
7686         Invert check when verifying for operation on register
7687         displacement.
7688
7689 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7690
7691         * stap-probe.c (stap_get_opcode): Update comment.
7692         (stap_get_expected_argument_type): Likewise.
7693         (handle_stap_probe): Likewise.
7694
7695 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7696
7697         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7698         return type to 'bool'.  Adjust comment.  Use 'bool' when
7699         appropriate.
7700         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7701         * stap-probe.c (stap_parse_argument_1): Likewise.
7702         (stap_is_operator): Likewise.
7703         (stap_is_generic_prefix): Likewise.
7704         (stap_is_register_prefix): Likewise.
7705         (stap_is_register_indirection_prefix): Likewise.
7706         (stap_is_integer_prefix): Likewise.
7707         (stap_generic_check_suffix): Likewise.
7708         (stap_check_integer_suffix): Likewise.
7709         (stap_check_register_suffix): Likewise.
7710         (stap_check_register_indirection_suffix): Likewise.
7711         (stap_parse_register_operand): Likewise.
7712         (stap_parse_single_operand): Likewise.
7713         (stap_parse_argument_1): Likewise.
7714         (stap_probe::get_argument_count): Likewise.
7715         (stap_is_operator): Likewise.
7716
7717 2019-05-16  Tom Tromey  <tromey@adacore.com>
7718
7719         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7720         keyword to foreach.
7721
7722 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7723
7724         * linux-thread-db.c (try_thread_db_load_1): Change return type
7725         to bool.
7726         (try_thread_db_load): Likewise.
7727         (try_thread_db_load_from_pdir_1): Likewise.
7728         (try_thread_db_load_from_pdir): Likewise.
7729         (try_thread_db_load_from_sdir): Likewise.
7730         (try_thread_db_load_from_dir): Likewise.
7731         (thread_db_load_search): Likewise.
7732         (has_libpthread): Likewise.
7733         (thread_db_load): Likewise.
7734
7735 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7736
7737         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7738         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7739         NULL, and complain/return if that's the case.
7740
7741 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7742
7743         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7744         (advance, posn, abstract_read_memory): New functions.
7745         [struct mem_read_abstraction]: New struct.
7746         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7747
7748 2019-05-14  Tom Tromey  <tromey@adacore.com>
7749
7750         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7751         value is not lval_memory.
7752
7753 2019-05-14  Tom Tromey  <tromey@adacore.com>
7754
7755         * solib.c (info_sharedlibrary_command): Style the file name.
7756
7757 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7758
7759         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7760         (aarch64_vnv_type): Likewise.
7761         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7762         * common/tdesc.c: Likewise.
7763         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7764         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7765         * features/aarch64-fpu.xml: Add ieee half view.
7766         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7767         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7768         * gdbtypes.h (struct builtin_type): Likewise.
7769         (struct objfile_type): Likewise.
7770
7771 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7772
7773         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7774         typo.
7775         * location.h (string_to_event_location): Likewise.
7776
7777 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7778
7779         GDB 8.3 released.
7780
7781 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7782
7783         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7784         New variable declaration.
7785         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7786         New variable.
7787         (print_one_breakpoint): Use ui_out::test_flags and new global
7788         variable to compute use_fixed_output.
7789         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7790         Remove.
7791         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7792         (mi_multi_location_breakpoint_output_fixed): Remove.
7793         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7794         new variable.
7795         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7796         fix_multi_location_breakpoint_output flag if version >= 3.
7797         * ui-out.h (enum ui_out_flag)
7798         <fix_multi_location_breakpoint_output>: New enumerator.
7799
7800 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7801
7802         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7803
7804 2019-05-10  Tom Tromey  <tromey@adacore.com>
7805
7806         * ada-lang.c (catch_ada_completer): New function.
7807         (_initialize_ada_language): Use it.
7808
7809 2019-05-10  Tom Tromey  <tromey@adacore.com>
7810
7811         * thread.c (print_thread_info): Make "requested_threads" const.
7812         * gdbthread.h (print_thread_info): Make "requested_threads"
7813         const.
7814         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7815         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7816
7817 2019-05-08  Tom Tromey  <tom@tromey.com>
7818
7819         * gdbtypes.c (objfile_type_data): Change type.
7820         (objfile_type, _initialize_gdbtypes): Update.
7821
7822 2019-05-08  Tom Tromey  <tom@tromey.com>
7823
7824         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7825         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7826         (_initialize_dwarf2_frame): Update.
7827
7828 2019-05-08  Tom Tromey  <tom@tromey.com>
7829
7830         * objc-lang.c (objc_objfile_data): Change type.
7831         (find_methods): Update.
7832         (_initialize_objc_lang): Remove.
7833
7834 2019-05-08  Tom Tromey  <tom@tromey.com>
7835
7836         * stabsread.c (rs6000_builtin_type_data): Change type.
7837         (rs6000_builtin_type, _initialize_stabsread): Update.
7838
7839 2019-05-08  Tom Tromey  <tom@tromey.com>
7840
7841         * mips-tdep.c (mips_pdr_data): Remove.
7842         (_initialize_mips_tdep): Update.
7843
7844 2019-05-08  Tom Tromey  <tom@tromey.com>
7845
7846         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7847         (hppa_init_objfile_priv_data, read_unwind_info)
7848         (find_unwind_entry, _initialize_hppa_tdep): Update.
7849
7850 2019-05-08  Tom Tromey  <tom@tromey.com>
7851
7852         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7853         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7854         on obstack.
7855         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7856
7857 2019-05-08  Tom Tromey  <tom@tromey.com>
7858
7859         * mdebugread.c (basic_type_data): Change type.
7860         (basic_type, _initialize_mdebugread): Update.
7861
7862 2019-05-08  Tom Tromey  <tom@tromey.com>
7863
7864         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7865
7866 2019-05-08  Tom Tromey  <tom@tromey.com>
7867
7868         * nto-tdep.c (nto_inferior_data_reg): Change type.
7869         (nto_inferior_data): Update.
7870         (nto_inferior_data_cleanup, nto_new_inferior_data)
7871         (_initialize_nto_tdep): Remove.
7872         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7873
7874 2019-05-08  Tom Tromey  <tom@tromey.com>
7875
7876         * ada-lang.c (struct ada_inferior_data): Add initializers.
7877         (ada_inferior_data): Change type.
7878         (ada_inferior_data_cleanup): Remove.
7879         (get_ada_inferior_data, ada_inferior_exit)
7880         (struct ada_pspace_data): Add initializers, destructor.
7881         (ada_pspace_data_handle): Change type.
7882         (get_ada_pspace_data): Update.
7883         (ada_pspace_data_cleanup): Remove.
7884
7885 2019-05-08  Tom Tromey  <tom@tromey.com>
7886
7887         * coffread.c (struct coff_symfile_info): Add initializers.
7888         (coff_objfile_data_key): Move lower.  Change type.
7889         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7890         Update.
7891         (coff_free_info): Remove.
7892
7893 2019-05-08  Tom Tromey  <tom@tromey.com>
7894
7895         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7896         (fbsd_pspace_data_handle): Move lower.  Change type.
7897         (get_fbsd_pspace_data): Update.
7898         (fbsd_pspace_data_cleanup): Remove.
7899         (_initialize_fbsd_tdep): Update.
7900
7901 2019-05-08  Tom Tromey  <tom@tromey.com>
7902
7903         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7904         (get_ada_tasks_pspace_data): Update.
7905         (ada_tasks_pspace_data_cleanup): Remove.
7906         (_initialize_tasks): Update.
7907         (ada_tasks_inferior_data_handle): Change type.
7908         (get_ada_tasks_inferior_data): Update.
7909         (ada_tasks_inferior_data_cleanup): Remove.
7910         (struct ada_tasks_pspace_data): Add initializers.
7911
7912 2019-05-08  Tom Tromey  <tom@tromey.com>
7913
7914         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7915         * symfile-debug.c (debug_sym_get_probes): Change type.
7916         * stap-probe.c (handle_stap_probe):
7917         (stap_static_probe_ops::get_probes): Change type.
7918         * probe.h (class static_probe_ops) <get_probes>: Change type.
7919         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7920         (parse_probes_in_pspace): Update.
7921         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7922         Update.
7923         (any_static_probe_ops::get_probes): Change type.
7924         * elfread.c (elfread_data): New typedef.
7925         (probe_key): Change type.
7926         (elf_get_probes): Likewise.  Update.
7927         (probe_key_free): Remove.
7928         (_initialize_elfread): Update.
7929         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7930         Change type.
7931         (dtrace_process_dof_probe, dtrace_process_dof)
7932         (dtrace_static_probe_ops::get_probe): Change type.
7933
7934 2019-05-08  Tom Tromey  <tom@tromey.com>
7935
7936         * xcoffread.c (struct xcoff_symfile_info): Rename from
7937         coff_symfile_info.  Add initializers.
7938         (xcoff_objfile_data_key): Move lower.  Change type.
7939         (XCOFF_DATA): Rewrite.
7940         (xcoff_free_info): Remove.
7941         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7942         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7943         (xcoff_initial_scan): Update.
7944
7945 2019-05-08  Tom Tromey  <tom@tromey.com>
7946
7947         * solib-svr4.c (struct svr4_info): Add initializers and
7948         destructor.
7949         <probes_table>: Now an htab_up.
7950         (solib_svr4_pspace_data): Change type.
7951         (free_probes_table): Simplify.
7952         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7953         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7954         (probes_table_remove_objfile_probes, register_solib_event_probe)
7955         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7956         (_initialize_svr4_solib): Update.
7957
7958 2019-05-08  Tom Tromey  <tom@tromey.com>
7959
7960         * remote.c (remote_pspace_data): Change type.
7961         (remote_pspace_data_cleanup): Remove.
7962         (get_remote_exec_file, set_pspace_remote_exec_file)
7963         (_initialize_remote): Update.
7964
7965 2019-05-08  Tom Tromey  <tom@tromey.com>
7966
7967         * breakpoint.c (breakpoint_objfile_key): Change type.
7968         (get_breakpoint_objfile_data): Update.
7969         (free_breakpoint_objfile_data): Remove.
7970         (_initialize_breakpoint): Update.
7971
7972 2019-05-08  Tom Tromey  <tom@tromey.com>
7973
7974         * linux-tdep.c (struct linux_info): Add initializers.
7975         (linux_inferior_data): Move.  Change type.
7976         (invalidate_linux_cache_inf): Update.
7977         (linux_inferior_data_cleanup): Remove.
7978         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7979
7980 2019-05-08  Tom Tromey  <tom@tromey.com>
7981
7982         * auxv.c (auxv_inferior_data): Move.  Change type.
7983         (auxv_inferior_data_cleanup): Remove.
7984         (invalidate_auxv_cache_inf): Rewrite.
7985         (get_auxv_inferior_data, _initialize_auxv): Update.
7986
7987 2019-05-08  Tom Tromey  <tom@tromey.com>
7988
7989         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7990         (symfile_debug_objfile_data_key): Change type.
7991         (symfile_debug_installed, debug_qf_has_symbols)
7992         (debug_qf_find_last_source_symtab)
7993         (debug_qf_forget_cached_source_info)
7994         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7995         (debug_qf_print_stats, debug_qf_dump)
7996         (debug_qf_expand_symtabs_for_function)
7997         (debug_qf_expand_all_symtabs)
7998         (debug_qf_expand_symtabs_with_fullname)
7999         (debug_qf_map_matching_symbols)
8000         (debug_qf_expand_symtabs_matching)
8001         (debug_qf_find_pc_sect_compunit_symtab)
8002         (debug_qf_map_symbol_filenames)
8003         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8004         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8005         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8006         (debug_sym_read_linetable, debug_sym_relocate): Update.
8007         (symfile_debug_free_objfile): Remove.
8008         (install_symfile_debug_logging, _initialize_symfile_debug):
8009         Update.
8010
8011 2019-05-08  Tom Tromey  <tom@tromey.com>
8012
8013         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8014         allocate_on_obstack.
8015         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8016         (get_dwarf2_per_objfile): Update.
8017         (set_dwarf2_per_objfile): Remove.
8018         (dwarf2_has_info, dwarf2_get_section_info): Update.
8019         (dwarf2_free_objfile): Remove.
8020         (_initialize_dwarf2_read): Update.
8021
8022 2019-05-08  Tom Tromey  <tom@tromey.com>
8023
8024         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8025         initializers.
8026         <unsupported_script_warning_printed,
8027         script_not_found_warning_printed>: Now bool.
8028         (auto_load_pspace_data): Change type.
8029         (~auto_load_pspace_info): Rename from
8030         auto_load_pspace_data_cleanup.
8031         (get_auto_load_pspace_data, init_loaded_scripts_info)
8032         (clear_section_scripts, maybe_print_unsupported_script_warning)
8033         (maybe_print_script_not_found_warning, _initialize_auto_load):
8034         Update.
8035
8036 2019-05-08  Tom Tromey  <tom@tromey.com>
8037
8038         * objfiles.c (objfile_pspace_info): Add destructor and
8039         initializers.
8040         (objfiles_pspace_data): Change type.
8041         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8042         (get_objfile_pspace_data): Update.
8043         (objfiles_bfd_data): Change type.
8044         (get_objfile_bfd_data): Update.
8045         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8046
8047 2019-05-08  Tom Tromey  <tom@tromey.com>
8048
8049         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8050         Change type.
8051         (get_catch_syscall_inferior_data): Update.
8052         (catch_syscall_inferior_data_cleanup): Remove.
8053         (_initialize_break_catch_syscall): Update.
8054
8055 2019-05-08  Tom Tromey  <tom@tromey.com>
8056
8057         * inflow.c (struct terminal_info): Add destructor and
8058         initializers.
8059         (inflow_inferior_data): Change type.
8060         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8061         (get_inflow_inferior_data, inflow_inferior_exit)
8062         (swap_terminal_info, _initialize_inflow): Update.
8063
8064 2019-05-08  Tom Tromey  <tom@tromey.com>
8065
8066         * target-dcache.c (target_dcache_cleanup): Remove.
8067         (target_dcache_aspace_key): Change type.
8068         (target_dcache_init_p, target_dcache_invalidate)
8069         (target_dcache_get, target_dcache_get_or_init)
8070         (_initialize_target_dcache): Update.
8071         * dcache.h (struct dcache_deleter): New.
8072
8073 2019-05-08  Tom Tromey  <tom@tromey.com>
8074
8075         * symtab.c (struct symbol_cache): Add destructor and
8076         initializers.
8077         (symbol_cache_key): Move.  Change type.
8078         (make_symbol_cache, free_symbol_cache): Remove.
8079         (get_symbol_cache): Update.
8080         (symbol_cache_cleanup): Remove.
8081         (ALL_PSPACES, symbol_cache_flush)
8082         (maintenance_print_symbol_cache)
8083         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8084         Update.
8085
8086 2019-05-08  Tom Tromey  <tom@tromey.com>
8087
8088         * symtab.c (struct main_info): Add destructor and initializers.
8089         (main_progspace_key): Move.  Change type.
8090         (get_main_info): Update.
8091         (main_info_cleanup): Remove.
8092         (_initialize_symtab): Update.
8093
8094 2019-05-08  Tom Tromey  <tom@tromey.com>
8095
8096         * registry.h (DECLARE_REGISTRY): Define the _key class.
8097
8098 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8099
8100         * NEWS: Merge two 'New commands' sections.
8101
8102 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8103
8104         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8105         parameter and use Ada language definition instead.
8106         (ada_val_print_ptr): Remove unused language parameter.
8107         (ada_val_print_num): Remove language parameter and use Ada language
8108         definition instead.
8109         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8110         parameter.
8111         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8112         parameter and use Ada language definition instead.
8113         (ada_val_print_1): Update all ada_val_print_xxx calls.
8114         Remove language parameter.
8115         (ada_val_print): Update ada_val_print_1 call.
8116
8117 2019-05-08  Tom Tromey  <tromey@adacore.com>
8118
8119         * remote.c (remote_hw_watchpoint_limit)
8120         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8121         Now static.
8122
8123 2019-05-08  Tom Tromey  <tromey@adacore.com>
8124
8125         * maint.c (_initialize_maint_cmds): Move initialization code to
8126         remote.c.
8127         (watchdog, show_watchdog): Move to remote.c.
8128         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8129         "watchdog" static.
8130         (_initialize_remote): Move initialization code from maint.c.
8131         * defs.h (watchdog): Don't declare.
8132
8133 2019-05-08  Tom Tromey  <tromey@adacore.com>
8134
8135         * tui/tui-interp.c: Include main.h.
8136         * interps.c: Include main.h.
8137         * main.h (interpreter_p): Declare.
8138         * defs.h (interpreter_p): Don't declare.
8139
8140 2019-05-08  Tom Tromey  <tromey@adacore.com>
8141
8142         * dwarf2loc.c: Include dwarf2read.h.
8143         * defs.h (read_unsigned_leb128): Don't declare.
8144         * dwarf2read.h (read_unsigned_leb128): Declare.
8145
8146 2019-05-08  Tom Tromey  <tromey@adacore.com>
8147
8148         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8149         method.
8150
8151 2019-05-08  Tom Tromey  <tromey@adacore.com>
8152
8153         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8154         when no wrap column is set.
8155
8156 2019-05-08  Tom Tromey  <tromey@adacore.com>
8157
8158         * c-lang.c (c_get_string): Handle non-C-style arrays.
8159
8160 2019-05-08  Tom Tromey  <tromey@adacore.com>
8161
8162         * typeprint.c (print_offset_data::update): Print the bit offset,
8163         not the number of bits remaining.
8164
8165 2019-05-08  Tom Tromey  <tromey@adacore.com>
8166
8167         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8168         padding at end of comment.
8169
8170 2019-05-08  Tom Tromey  <tromey@adacore.com>
8171
8172         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8173         Compare main types.
8174
8175 2019-05-06  Tom Tromey  <tom@tromey.com>
8176
8177         * common/scoped_mmap.c: Include common-defs.h.
8178         * common/scoped_mmap.h: Don't include config.h.
8179
8180 2019-05-04  Tom Tromey  <tom@tromey.com>
8181
8182         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8183         (struct aarch64_call_info): Add initializers.
8184         <si>: Now a std::vector.
8185         (pass_on_stack, aarch64_push_dummy_call): Update.
8186
8187 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8188             Tom Tromey  <tom@tromey.com>
8189
8190         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8191         (ppc_threads): Now a std::vector.  Now static.
8192         (hwdebug_find_thread_points_by_tid)
8193         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8194         Update.
8195
8196 2019-05-04  Tom Tromey  <tom@tromey.com>
8197
8198         * arc-tdep.c (arc_tdesc_init): Return bool.
8199
8200 2019-05-04  Tom Tromey  <tom@tromey.com>
8201
8202         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8203         Use gdb_assert_not_reached.
8204
8205 2019-05-04  Tom Tromey  <tom@tromey.com>
8206
8207         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8208         "false".
8209
8210 2019-05-04  Tom Tromey  <tom@tromey.com>
8211
8212         * arc-tdep.c (arc_tdesc_init): Use bool.
8213
8214 2019-05-04  Tom Tromey  <tom@tromey.com>
8215
8216         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8217
8218 2019-05-04  Tom Tromey  <tom@tromey.com>
8219
8220         * cli/cli-cmds.c (valid_command_p): Return bool.
8221
8222 2019-05-04  Tom Tromey  <tom@tromey.com>
8223
8224         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8225         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8226
8227 2019-05-04  Raul Tambre  <raul@tambre.ee>
8228
8229         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8230         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8231         operator for comparison.
8232
8233 2019-05-04  Tom Tromey  <tom@tromey.com>
8234
8235         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8236         (lookup_partial_symbol, print_partial_symbols)
8237         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8238         (psymbol_compare): Update.
8239         (add_psymbol_to_bcache): Clear the entire psymbol.
8240         (maintenance_check_psymtabs): Update.
8241         * psympriv.h (struct partial_symbol): Don't derive from
8242         general_symbol_info.
8243         <obj_section, unrelocated_address, address,
8244         set_unrelocated_address>: Update.
8245         <ginfo>: New member.
8246         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8247         (debug_names::write_psymbols): Update.
8248
8249 2019-05-04  Tom de Vries  <tdevries@suse.de>
8250
8251         * contrib/cc-with-tweaks.sh: Support -n arg.
8252
8253 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8254
8255         * corelow.c (core_target::detach): Ensure frame cache and
8256         register caches are cleared.
8257         inferior.c (exit_inferior_1): Likewise.
8258
8259 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8260             Tom Tromey  <tom@tromey.com>
8261
8262         * dictionary.c (collate_pending_symbols_by_language): Remove
8263         "struct" from foreach.
8264         * symtab.c (lookup_global_symbol_from_objfile)
8265         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8266         foreach.
8267         * ser-tcp.c (net_open): Remove "struct" from foreach.
8268         * objfiles.c (objfile_relocate, objfile_rebase)
8269         (objfile_has_symbols): Remove "struct" from foreach.
8270         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8271         from foreach.
8272         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8273         foreach.
8274         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8275         "struct" from foreach.
8276         * ada-lang.c (create_excep_cond_exprs)
8277         (ada_exception_catchpoint_cond_string): Remove "struct" from
8278         foreach.
8279
8280 2019-05-03  Tom Tromey  <tromey@adacore.com>
8281
8282         * ada-exp.y (convert_char_literal): Check suffix of each
8283         enumerator.
8284
8285 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8286
8287         PR ada/21406:
8288         * ada-exp.y (yywrap): Don't define.
8289         * ada-lex.l (%option): Add noyywrap
8290         (yywrap): Remove.
8291
8292 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8293
8294         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8295         _WIN32_WINNT to the XP level, unless already defined to a higher
8296         level.
8297
8298         * unittests/parse-connection-spec-selftests.c:
8299         * ser-tcp.c:
8300         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8301         override.
8302
8303         * symfile.c (find_separate_debug_file): Remove colon from the
8304         drive spec of DOS/Windows file names of the target, so that the
8305         file name produced from DEBUGDIR and the target's directory will
8306         be valid on DOS/Windows systems.
8307
8308 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8309
8310         * rust-lang.c (val_print_struct): Handle printing structures
8311         containing strings.
8312
8313 2019-05-02  Tom Tromey  <tromey@adacore.com>
8314
8315         * valarith.c (_initialize_valarith): Remove.
8316
8317 2019-05-01  Tom Tromey  <tromey@adacore.com>
8318
8319         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8320         bitfields.
8321
8322 2019-05-01  Tom Tromey  <tromey@adacore.com>
8323
8324         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8325         for big-endian copies.
8326
8327 2019-04-30  Ali Tamur  <tamur@google.com>
8328         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8329         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8330         (read_3_bytes): New function.
8331
8332 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8333
8334         * windows-nat.c (main_thread_id): Delete.
8335         (handle_output_debug_string): Replace main_thread_id by
8336         current_event.dwThreadId.
8337         (fake_create_process): Likewise.
8338         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8339         Do not set main_thread_id.
8340         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8341         current_event.dwThreadId.
8342         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8343
8344 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8345
8346         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8347         Use current_event.dwThreadId instead of main_thread_id.
8348
8349 2019-04-30  Tom Tromey  <tromey@adacore.com>
8350
8351         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8352         (create_excep_cond_exprs): Iterate over program spaces.
8353         (ada_exception_catchpoint_cond_string): Examine all minimal
8354         symbols for exception types.
8355
8356 2019-04-30  Tom Tromey  <tromey@adacore.com>
8357
8358         PR c++/24470:
8359         * dwarf2read.c (process_structure_scope): Handle case where type
8360         has template parameters but no symbol was created.
8361
8362 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8363             Chris January  <chris.january@arm.com>
8364
8365         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8366         qualifier.
8367         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8368
8369 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8370
8371         * f-typeprint.c (f_print_type): Update rules for printing
8372         whitespace.
8373         (f_type_print_varspec_suffix): Likewise.
8374
8375 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8376             Chris January  <chris.january@arm.com>
8377
8378         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8379         function arguments.
8380
8381 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8382
8383         * f-lang.c (build_fortran_types): Change name of void type to
8384         lower case.
8385         * f-typeprint.c (f_type_print_base): Print the name of the void
8386         type, rather than a fixed string.
8387         * f-valprint.c (f_decorations): Use lower case void string.
8388
8389 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8390             Chris January  <chris.january@arm.com>
8391
8392         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8393         types for Fortran.
8394
8395 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8396             Chris January  <chris.january@arm.com>
8397             David Lecomber  <david.lecomber@arm.com>
8398
8399         * f-exp.y (BINOP_INTRINSIC): New token.
8400         (exp): New parser rule handling BINOP_INTRINSIC.
8401         (f77_keywords): Add new builtin procedures.
8402         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8403         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8404         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8405         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8406         (print_unop_subexp_f): New function.
8407         (print_binop_subexp_f): New function.
8408         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8409         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8410         (dump_subexp_body_f): Likewise.
8411         (operator_check_f): Likewise.
8412         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8413         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8414
8415 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8416
8417         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8418         UNOP_KIND.
8419         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8420         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8421         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8422         (operator_length_f): New fuction.
8423         (print_subexp_f): New function.
8424         (op_name_f): New function.
8425         (dump_subexp_body_f): New function.
8426         (operator_check_f): New function.
8427         (exp_descriptor_f): Replace standard expression handling functions
8428         with new functions.
8429         * gdb/fortran-operator.def: New file.
8430         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8431         * gdb/std-operator.def: Remove UNOP_KIND.
8432
8433 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8434
8435         * std-operator.def: Remove unbalanced, stray double quote
8436         character.
8437
8438 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8439             Chris January  <chris.january@arm.com>
8440             Daniel Everett  <daniel.everett@arm.com>
8441             Nick Forrington  <nick.forrington@arm.com>
8442             Richard Bunt  <richard.bunt@arm.com>
8443
8444         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8445         of depth when printing anonymous structs or unions.
8446         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8447         Don't print either the top-level value, or the children if the
8448         max-depth is exceeded.
8449         (ppscm_print_children): When printing the key of a map, allow one
8450         extra level of depth.
8451         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8452         print either the top-level value, or the children if the max-depth
8453         is exceeded.
8454         (print_children): When printing the key of a map, allow one extra
8455         level of depth.
8456         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8457         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8458         (user_print_options): Initialise max_depth field.
8459         (val_print_scalar_or_string_type_p): New function.
8460         (val_print): Check to see if the max depth has been reached.
8461         (val_print_check_max_depth): Define new function.
8462         (show_print_max_depth): New function.
8463         (_initialize_valprint): Add 'print max-depth' option.
8464         * valprint.h (struct value_print_options) <max_depth>: New field.
8465         (val_print_check_max_depth): Declare new function.
8466         * NEWS: Document new feature.
8467
8468 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8469
8470         * ada-lang.c (ada_language_defn): Initialise new field.
8471         * c-lang.c (c_is_string_type_p): New function.
8472         (c_language_defn): Initialise new field.
8473         (cplus_language_defn): Initialise new field.
8474         (asm_language_defn): Initialise new field.
8475         (minimal_language_defn): Initialise new field.
8476         * c-lang.h (c_is_string_type_p): Declare new function.
8477         * d-lang.c (d_language_defn): Initialise new field.
8478         * f-lang.c (f_is_string_type_p): New function.
8479         (f_language_defn): Initialise new field.
8480         * go-lang.c (go_is_string_type_p): New function.
8481         (go_language_defn): Initialise new field.
8482         * language.c (default_is_string_type_p): New function.
8483         (unknown_language_defn): Initialise new field.
8484         (auto_language_defn): Initialise new field.
8485         * language.h (struct language_defn) <la_is_string_type_p>: New
8486         member variable.
8487         (default_is_string_type_p): Declare new function.
8488         * m2-lang.c (m2_language_defn): Initialise new field.
8489         * objc-lang.c (objc_language_defn): Initialise new field.
8490         * opencl-lang.c (opencl_language_defn): Initialise new field.
8491         * p-lang.c (pascal_is_string_type_p): New function.
8492         (pascal_language_defn): Initialise new field.
8493         * rust-lang.c (rust_is_string_type_p): New function.
8494         (rust_language_defn): Initialise new field.
8495
8496 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8497
8498         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8499         New field.
8500         * ada-lang.c (ada_language_defn): Initialise new field.
8501         * c-lang.c (c_language_defn): Likewise.
8502         (cplus_language_defn): Likewise.
8503         (asm_language_defn): Likewise.
8504         (minimal_language_defn): Likewise.
8505         * d-lang.c (d_language_defn): Likewise.
8506         * f-lang.c (f_language_defn): Likewise.
8507         * go-lang.c (go_language_defn): Likewise.
8508         * language.c (unknown_language_defn): Likewise.
8509         (auto_language_defn): Likewise.
8510         * m2-lang.c (m2_language_defn): Likewise.
8511         * objc-lang.c (objc_language_defn): Likewise.
8512         * opencl-lang.c (opencl_language_defn): Likewise.
8513         * p-lang.c (pascal_language_defn): Likewise.
8514         * rust-lang.c (rust_language_defn): Likewise.
8515
8516 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8517
8518         * ada-lang.c (ada_is_character_type): Change return type to bool.
8519         (ada_is_string_type): Likewise.
8520         * ada-lang.h (ada_is_character_type): Update declaration
8521         (ada_is_string_type): Likewise.
8522
8523 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8524
8525         Support style in 'frame|thread apply'
8526
8527         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8528         * record.c (record_start, record_stop): Update callers of
8529         execute_command_to_string with false.
8530         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8531         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8532         methods.
8533         (class string_file): New constructor with term_out parameter.
8534         Override methods term_out and can_emit_style_escape.  New member
8535         term_out.
8536         (class stdio_file): Override can_emit_style_escape.
8537         (class tee_file): Override term_out and can_emit_style_escape.
8538         * utils.h (can_emit_style_escape): Remove.
8539         * utils.c (can_emit_style_escape): Likewise.
8540         Update all callers of can_emit_style_escape (SOMESTREAM) to
8541         SOMESTREAM->can_emit_style_escape.
8542         * source-cache.c (source_cache::get_source_lines): Likewise.
8543         * stack.c (frame_apply_command_count): Call execute_command_to_string
8544         passing the term_out characteristic of the current gdb_stdout.
8545         * thread.c (thr_try_catch_cmd): Likewise.
8546         * top.c (execute_command_to_string): pass term_out parameter
8547         to construct the string_file for the command output.
8548         * ui-file.c (term_cli_styling): New function (most code moved
8549         from utils.c can_emit_style_escape).
8550         (string_file::string_file, string_file::can_emit_style_escape,
8551         stdio_file::can_emit_style_escape, tee_file::term_out,
8552         tee_file::can_emit_style_escape): New functions.
8553
8554 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8555
8556         * NEWS: Mention the new set|show may-call-functions.
8557         * infcall.c (may_call_functions_p): New variable.
8558         (show_may_call_functions_p): New function.
8559         (call_function_by_hand_dummy): Throws an error if not
8560         may-call-functions.
8561         (_initialize_infcall): Call add_setshow_boolean_cmd for
8562         may-call-functions.
8563
8564 2019-04-25  Keith Seitz  <keiths@redhat.com>
8565
8566         PR c++/24367
8567         * cp-support.c (inspect_type): Don't attempt substitutions
8568         of symbol with the same name.
8569
8570 2019-04-25  Tom Tromey  <tromey@adacore.com>
8571
8572         PR gdb/24475:
8573         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8574         static.
8575
8576 2019-04-25  Tom Tromey  <tromey@adacore.com>
8577
8578         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8579         rvalue reference.
8580         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8581         (gdb_xml_parser::parse): Use std::move.
8582         * python/python-internal.h (gdbpy_convert_exception): Take a const
8583         reference.
8584         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8585         std::move.
8586         * python/py-utils.c (gdbpy_convert_exception): Take a const
8587         reference.
8588         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8589         Use std::move.
8590         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8591         Use std::move.
8592         * mi/mi-main.c (mi_print_exception): Take a const reference.
8593         * main.c (handle_command_errors): Take a const reference.
8594         * linespec.c (parse_linespec): Use std::move.
8595         * infcall.c (run_inferior_call): Use std::move.
8596         (call_function_by_hand_dummy): Use std::move.
8597         * exec.c (try_open_exec_file): Use std::move.
8598         * exceptions.h (exception_print, exception_fprintf)
8599         (exception_print_same): Update.
8600         * exceptions.c (print_exception, exception_print)
8601         (exception_fprintf, exception_print_same): Change parameters to
8602         const reference.
8603         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8604         * common/new-op.c: Use std::move.
8605         * common/common-exceptions.h (struct gdb_exception): Add move
8606         constructor.
8607         (struct gdb_exception_error, struct gdb_exception_quit, struct
8608         gdb_quit_bad_alloc): Change constructor to move constructor.
8609         (throw_exception): Change parameter to rvalue reference.
8610         * common/common-exceptions.c (throw_exception): Take rvalue
8611         reference.
8612         * cli/cli-interp.c (safe_execute_command): Use std::move.
8613         * breakpoint.c (insert_bp_location, location_to_sals): Use
8614         std::move.
8615
8616 2019-04-25  Tom Tromey  <tromey@adacore.com>
8617
8618         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8619         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8620         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8621         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8622         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8623         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8624         guile/scm-value.c: Use unpack.
8625         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8626         gdbscm_gdb_exception.
8627         (gdbscm_throw_gdb_exception): Likewise.
8628         (struct gdbscm_gdb_exception): New.
8629         (unpack): New function.
8630         (gdbscm_wrap): Use unpack.
8631
8632 2019-04-25  Tom Tromey  <tromey@adacore.com>
8633
8634         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8635         (gdb_rl_callback_handler): Use std::move.
8636         * common/common-exceptions.h (struct gdb_exception): Add move
8637         assignment operator.
8638         (throw_exception_sjlj): Change "exception" to const reference.
8639         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8640         (throw_exception_sjlj): Change "exception" to const reference.
8641
8642 2019-04-25  Tom Tromey  <tromey@adacore.com>
8643
8644         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8645         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8646         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8647         Update.
8648         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8649         Update.
8650         * mi/mi-interp.c (mi_interp::exec): Update.
8651         * linespec.c (parse_linespec): Update.
8652         * infcall.c (run_inferior_call): Update.
8653         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8654         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8655         (gdbscm_lookup_global_symbol): Update.
8656         * guile/scm-param.c (gdbscm_parameter_value): Update.
8657         * guile/scm-frame.c (gdbscm_frame_read_register)
8658         (gdbscm_frame_read_var): Update.
8659         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8660         * exec.c (try_open_exec_file): Update.
8661         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8662         (gdb_rl_callback_handler): Update.
8663         * common/common-exceptions.h (exception_none): Don't declare.
8664         * common/common-exceptions.c (exception_none): Don't define.
8665         (struct catcher) <exception>: Update.
8666         * cli/cli-interp.c (safe_execute_command): Update.
8667         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8668
8669 2019-04-25  Ali Tamur  <tamur@google.com>
8670
8671         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8672         (read_attribute_value): Likewise.
8673         (dwarf2_read_addr_index): Update comment.
8674         (read_str_index): Add DW_FORM_strx.
8675         (dwarf2_string_attr): Likewise.
8676         (dwarf2_const_value_attr): Likewise.
8677         (dump_die_shallow): Likewise.
8678         (dwarf2_fetch_constant_bytes): Likewise.
8679         (skip_form_bytes): Likewise.
8680         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8681
8682 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8683
8684         PR corefiles/11608
8685         PR corefiles/18187
8686         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8687         OFFSET.  Verify if current mapping contains an ELF header.
8688         (linux_find_memory_regions_full): Adjust call to
8689         dump_mapping_p.
8690
8691 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8692             Kang Li <kanglictf@gmail.com>
8693
8694         PR gdb/21600
8695
8696         * dwarf2-frame.c (read_initial_length): Be consistent about using
8697         unsigned representation of length.
8698         (decode_frame_entry_1): Likewise.  Check for wraparound of
8699         end pointer as well as buffer overflow.
8700
8701 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8702
8703         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8704         "vq".
8705
8706 2019-04-24  Tom Tromey  <tromey@adacore.com>
8707
8708         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8709
8710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8711
8712         * s12z-tdep.c (s12z_unwind_pc): Delete.
8713         (s12z_unwind_sp): Delete.
8714         (s12z_gdbarch_init): Don't register deleted functions with
8715         gdbarch.
8716
8717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8718
8719         * rl78-tdep.c (rl78_unwind_sp): Delete.
8720         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8721
8722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8723
8724         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8725         (xstormy16_unwind_pc): Delete.
8726         (xstormy16_dummy_id): Delete.
8727         (xstormy16_gdbarch_init): Don't register deleted functions with
8728         gdbarch.
8729
8730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8731
8732         * vax-tdep.c (vax_unwind_pc): Delete.
8733         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8734
8735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8736
8737         * v850-tdep.c (v850_unwind_sp): Delete.
8738         (v850_unwind_pc): Delete.
8739         (v850_dummy_id): Delete.
8740         (v850_gdbarch_init): Don't register deleted functions with
8741         gdbarch.
8742
8743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8744
8745         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8746         (tilegx_unwind_pc): Delete.
8747         (tilegx_unwind_dummy_id): Delete.
8748         (tilegx_gdbarch_init): Don't register deleted functions with
8749         gdbarch.
8750
8751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8752
8753         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8754         (tic6x_dummy_id): Delete.
8755         (tic6x_gdbarch_init): Don't register deleted functions with
8756         gdbarch.
8757
8758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8759
8760         * sparc-tdep.c (sparc_unwind_pc): Delete.
8761         (sparc32_gdbarch_init): Don't register deleted function with
8762         gdbarch.
8763
8764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * sh-tdep.c (sh_unwind_sp): Delete.
8767         (sh_unwind_pc): Delete.
8768         (sh_dummy_id): Delete.
8769         (sh_gdbarch_init): Don't register deleted functions with
8770         gdbarch.
8771
8772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8773
8774         * score-tdep.c (score_unwind_sp): Delete.
8775         (score_unwind_pc): Delete.
8776         (score_dummy_id): Delete.
8777         (score_gdbarch_init): Don't register deleted functions with
8778         gdbarch.
8779
8780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8781
8782         * rx-tdep.c (rx_unwind_pc): Delete.
8783         (rx_unwind_sp): Delete.
8784         (rx_dummy_id): Delete.
8785         (rx_gdbarch_init): Don't register deleted functions with
8786         gdbarch.  Update comment.
8787
8788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8789
8790         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8791         (rs6000_dummy_id): Delete.
8792         (rs6000_gdbarch_init): Don't register deleted functions with
8793         gdbarch.
8794
8795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8796
8797         * or1k-tdep.c (or1k_dummy_id): Delete.
8798         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8799
8800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8801
8802         * nios2-tdep.c (nios2_dummy_id): Delete.
8803         (nios2_unwind_sp): Delete.
8804         (nios2_gdbarch_init): Don't register deleted functions with
8805         gdbarch.
8806
8807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8808
8809         * nds32-tdep.c (nds32_dummy_id): Delete.
8810         (nds32_unwind_pc): Delete.
8811         (nds32_unwind_sp): Delete.
8812         (nds32_gdbarch_init): Don't register deleted functions with
8813         gdbarch.
8814
8815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8816
8817         * msp430-tdep.c (msp430_unwind_pc): Delete.
8818         (msp430_unwind_sp): Delete.
8819         (msp430_dummy_id): Delete.
8820         (msp430_gdbarch_init): Don't register deleted functions with
8821         gdbarch.
8822
8823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8824
8825         * moxie-tdep.c (moxie_unwind_sp): Delete.
8826         (moxie_unwind_pc): Delete.
8827         (moxie_dummy_id): Delete.
8828         (moxie_gdbarch_init): Don't register deleted functions with
8829         gdbarch.
8830
8831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8832
8833         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8834         (mn10300_unwind_pc): Delete.
8835         (mn10300_unwind_sp): Delete.
8836         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8837         mn10300_unwind_sp.
8838         (mn10300_frame_unwind_init): Don't register deleted functions with
8839         gdbarch.
8840
8841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8842
8843         * mep-tdep.c (mep_unwind_pc): Delete.
8844         (mep_unwind_sp): Delete.
8845         (mep_dummy_id): Delete.
8846         (mep_gdbarch_init): Don't register deleted functions with
8847         gdbarch.
8848
8849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8850
8851         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8852         (m68hc11_unwind_sp): Delete.
8853         (m68hc11_gdbarch_init): Don't register deleted functions with
8854         gdbarch.
8855
8856 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8857
8858         * m32r-tdep.c (m32r_unwind_sp): Delete.
8859         (m32r_unwind_pc): Delete.
8860         (m32r_dummy_id): Delete.
8861         (m32r_gdbarch_init): Don't register deleted functions with
8862         gdbarch.
8863
8864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8865
8866         * m32c-tdep.c (m32c_unwind_pc): Delete.
8867         (m32c_unwind_sp): Delete.
8868         (m32c_dummy_id): Delete.
8869         (m32c_gdbarch_init): Don't register deleted functions with
8870         gdbarch.
8871
8872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8873
8874         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8875         (lm32_unwind_pc): Delete.
8876         (lm32_dummy_id): Delete.
8877         (lm32_gdbarch_init): Don't register deleted functions with
8878         gdbarch.
8879
8880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8881
8882         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8883         (iq2000_unwind_pc): Delete.
8884         (iq2000_dummy_id): Delete.
8885         (iq2000_gdbarch_init): Don't register deleted functions with
8886         gdbarch.
8887
8888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8889
8890         * nds32-tdep.c (nds32_type_align): Delete.
8891         (nds32_push_dummy_call): Use type_align instead.
8892
8893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8894
8895         * arm-tdep.c (arm_type_align): Only handle vector override case.
8896         (arm_push_dummy_call): Use type_align.
8897         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8898
8899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8900
8901         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8902         case.
8903         (pass_on_stack): Use type_align.
8904         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8905         function.
8906
8907 2019-04-23  Tom Tromey  <tromey@adacore.com>
8908
8909         * dwarf2read.c (line_header::file_name_at): Remove unused
8910         overload.
8911
8912 2019-04-23  Tom de Vries  <tdevries@suse.de>
8913
8914         PR gdb/24438
8915         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8916         invocation.
8917
8918
8919 2019-03-27  Ali Tamur  <tamur@google.com>
8920
8921         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8922         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8923         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8924         (dwarf_expr_context::get_addr_index): Likewise
8925         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8926         (symbol_needs_eval_context::get_addr_index): Likewise
8927         (disassemble_dwarf_expression): Add DW_OP_addrx
8928         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8929         (read_cutu_die_from_dwo): Update comment
8930         (skip_one_die): Add DW_FORM_addrx
8931         (read_attribute_value): Likewise
8932         (var_decode_location): Add DW_OP_addrx
8933         (dwarf2_const_value_attr): Add DW_FORM_addrx
8934         (dump_die_shallow): Likewise
8935         (dwarf2_fetch_constant_bytes): Likewise
8936         (decode_locdesc): Add DW_OP_addrx
8937         (skip_form_bytes): Add DW_FORM_addrx
8938
8939 2019-04-22  Ali Tamur  <tamur@google.com>
8940
8941         * MAINTAINERS (Write After Approval): Add self.
8942
8943 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8944
8945         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8946         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8947         (open_symbol_file_object): Likewise.
8948         (svr4_default_sos): Add info parameter.
8949         (svr4_read_so_list): Likewise.
8950         (svr4_current_sos_direct): Adjust functions calls to pass down
8951         info.
8952         (svr4_current_sos_1): Add info parameter.
8953         (svr4_current_sos): Call get_svr4_info, pass info down to
8954         svr4_current_sos_1.
8955         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8956         get_svr4_info.
8957         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8958         get_svr4_info.
8959         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8960         to get_svr4_info.
8961         (probes_table_remove_objfile_probes): Likewise.
8962         (register_solib_event_probe): Add info parameter.
8963         (solist_update_incremental): Pass info parameter down to
8964         svr4_read_so_list.
8965         (disable_probes_interface): Add info parameter.
8966         (svr4_handle_solib_event): Pass current_program_space to
8967         get_svr4_info.  Adjust disable_probes_interface cleanup.
8968         (svr4_create_probe_breakpoints): Add info parameter, pass it
8969         down to register_solib_event_probe.
8970         (svr4_create_solib_event_breakpoints): Add info parameter,
8971         pass it down to svr4_create_probe_breakpoints.
8972         (enable_break): Pass info down to
8973         svr4_create_solib_event_breakpoints.
8974         (svr4_solib_create_inferior_hook): Pass current_program_space to
8975         get_svr4_info.
8976         (svr4_clear_solib): Likewise.
8977
8978 2019-04-22  Pedro Alves  <palves@redhat.com>
8979
8980         * solib-svr4.c (svr4_free_objfile_observer): New.
8981         (probe_and_action::objfile): New field.
8982         (probes_table_htab_remove_objfile_probes)
8983         (probes_table_remove_objfile_probes): New functions.
8984         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8985         in the new probe_and_action.  Don't store the probe in 'lookup'.
8986         (svr4_create_probe_breakpoints): Pass objfile to
8987         register_solib_event_probe.
8988         (_initialize_svr4_solib): Register a free_objfile observer.
8989
8990 2019-04-19  Tom Tromey  <tom@tromey.com>
8991
8992         * common/queue.h: Remove.
8993
8994 2019-04-19  Tom Tromey  <tom@tromey.com>
8995
8996         * event-loop.c: Don't include "common/queue.h".
8997
8998 2019-04-19  Tom Tromey  <tom@tromey.com>
8999
9000         * remote.c (remote_target): Use delete.
9001         * remote-notif.h: Include <list>, not "common/queue.h".
9002         (notif_client_p): Remove typedef.
9003         (remote_notif_state): Add constructor, destructor, initializer.
9004         <notif_queue>: Now a std::list.
9005         (remote_notif_state_xfree): Don't declare.
9006         * remote-notif.c (remote_notif_process, handle_notification)
9007         (remote_notif_state_allocate): Update.
9008         (~remote_notif_state): Rename from remote_notif_state_xfree.
9009
9010 2019-04-19  Tom Tromey  <tom@tromey.com>
9011
9012         * symfile.c (reread_symbols): Update.
9013         * objfiles.c (objfile_register_static_link)
9014         (objfile_lookup_static_link): Update
9015         (~objfile) Don't delete static_links.
9016         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9017
9018 2019-04-19  Tom Tromey  <tom@tromey.com>
9019
9020         * type-stack.h (struct type_stack) <insert>: Constify string.
9021         * type-stack.c (type_stack::insert): Constify string.
9022         * gdbtypes.h (lookup_template_type): Update.
9023         (address_space_name_to_int): Update.
9024         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9025         const.
9026         (lookup_template_type): Make name const.
9027         * c-exp.y: Update rules.
9028         (lex_one_token, classify_name, classify_inner_name)
9029         (c_print_token): Update.
9030         * p-exp.y: Update rules.
9031         (yylex): Update.
9032         * f-exp.y: Update rules.
9033         (yylex): Update.
9034         * d-exp.y: Update rules.
9035         (lex_one_token, classify_name, classify_inner_name): Update.
9036         * parse.c (write_dollar_variable, copy_name): Return std::string.
9037         * parser-defs.h (copy_name): Change return type.
9038         * m2-exp.y: Update rules.
9039         (yylex): Update.
9040         * go-exp.y (lex_one_token): Update.
9041         Update rules.
9042         (classify_unsafe_function, classify_packaged_name)
9043         (classify_name, yylex): Update.
9044
9045 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9046
9047         * configure.ac: add --enable-source-highlight switch.
9048         * configure: Regenerate.
9049         * top.c (print_gdb_version): plumb --enable-source-highlight
9050         status to "show configuration".
9051
9052 2019-04-19  Tom Tromey  <tromey@adacore.com>
9053
9054         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9055         Check ADA_TYPE_P.
9056         (empty_record, ada_template_to_fixed_record_type_1)
9057         (template_to_static_fixed_type)
9058         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9059         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9060         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9061         macros.
9062
9063 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9064
9065         PR symtab/24423:
9066         * source.c (print_source_lines_base): Advance "iter" when a
9067         control character is seen.
9068
9069 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9070
9071         * inferior.h (struct infcall_suspend_state_deleter):
9072         Catch exception in destructor to avoid crash.
9073
9074 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9075
9076         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9077         close to the add_com "shell".
9078
9079 2019-04-18  Tom Tromey  <tromey@adacore.com>
9080
9081         * process-stratum-target.h (class process_stratum_target)
9082         <stratum>: Add "final".
9083
9084 2019-04-17  Tom Tromey  <tromey@adacore.com>
9085
9086         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9087         against nullptr before use.
9088
9089 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9090
9091         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9092
9093 2019-04-17  Jim Wilson  <jimw@sifive.com>
9094             Andrew Burgess  <andrew.burgess@embecosm.com>
9095
9096         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9097         code read might fail, assume 4-byte breakpoint in that case.
9098
9099 2019-04-15  Leszek Swirski  <leszeks@google.com>
9100
9101         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9102         rather than a hand-rolled POD check when checking for forced MEMORY
9103         classification.
9104
9105 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9106
9107         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9108         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9109         function.
9110         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9111         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9112         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9113         declaration.
9114
9115 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9116
9117         * aarch64-linux-nat.c
9118         (aarch64_linux_nat_target::thread_architecture): Add override.
9119         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9120         each VQ.
9121
9122 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9123
9124         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9125
9126 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9127
9128         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9129         target types of size 96-bits, add some additional comments, and
9130         check that the builtin type we found was the correct size.
9131
9132 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9133
9134         * utils.c (prompt_for_continue): Don't restore the styling at the
9135         end, as applied_style has the wrong value.  This fixes styling in
9136         long lists of file names that are interrupted by the "Continue?"
9137         prompt.
9138
9139 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9140
9141         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9142         * c-lang.c (c_language_defn): Likewise.
9143         (cplus_language_defn): Likewise.
9144         (asm_language_defn): Likewise.
9145         (minimal_language_defn): Likewise.
9146         * d-lang.c (d_language_defn): Likewise.
9147         * f-lang.c (f_language_defn): Likewise.
9148         * go-lang.c (go_language_defn): Likewise.
9149         * language.c (unknown_language_defn): Likewise.
9150         (auto_language_defn): Likewise.
9151         * language.h (struct language_defn): Remove la_magic field.
9152         (LANG_MAGIC): Delete.
9153         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9154         * objc-lang.c (objc_language_defn): Likewise.
9155         * opencl-lang.c (opencl_language_defn): Likewise.
9156         * p-lang.c (pascal_language_defn): Likewise.
9157         * rust-lang.c (rust_language_defn): Likewise.
9158
9159 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9160
9161         * riscv-tdep.c (riscv_type_align): New function.
9162         (riscv_type_alignment): Delete.
9163         (riscv_arg_location): Use 'type_align'.
9164         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9165
9166 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9167
9168         * gdbtypes.c (type_align): A struct with no non-static fields also
9169         has alignment of 1.
9170
9171 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9172
9173         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9174         component to 0.
9175         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9176         member.
9177         (riscv_struct_info::analyse): New implementation using new
9178         analyse_inner member function.
9179         (riscv_struct_info::field_offset): New member function.
9180         (riscv_struct_info::m_offsets): New member variable.
9181         (riscv_struct_info::analyse_inner): New private member function,
9182         takes the old implementation of riscv_struct_info::analyse but
9183         extended to track field offsets.
9184         (riscv_call_arg_struct): Update the struct folding special cases
9185         to handle cases where empty C++ structs, which are non-zero
9186         length, are found.
9187         (riscv_arg_location): Initialise the length of each location, a
9188         non-zero length now indicates the location is in use.
9189         (riscv_push_dummy_call): Allow for the first location having a
9190         non-zero offset when setting up arguments.
9191         (riscv_return_value): Likewise, but for return values.
9192
9193 2019-04-11  Tom Tromey  <tromey@adacore.com>
9194
9195         * utils.c (internal_vproblem): Make "msg" const.
9196
9197 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9198
9199         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9200         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9201         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9202         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9203
9204 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9205
9206         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9207         function.
9208         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9209         of amd64_collect_native_gregset.
9210         (amd64_linux_nat_target::store_registers): Likewise.
9211
9212 2019-04-10  Tom Tromey  <tom@tromey.com>
9213
9214         * symtab.c (lookup_global_symbol_from_objfile)
9215         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9216         * objfiles.h (class separate_debug_iterator): New.
9217         (class separate_debug_range): New.
9218         (struct objfile) <separate_debug_objfiles>: New method.
9219         (objfile_separate_debug_iterate): Don't declare.
9220         * objfiles.c (separate_debug_iterator::operator++): Rename from
9221         objfile_separate_debug_iterate.
9222         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9223         iterator.
9224         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9225         iterator.
9226
9227 2019-04-10  Tom Tromey  <tom@tromey.com>
9228
9229         * symfile.c (reread_symbols): Remove old comment.
9230         * objfiles.c (free_all_objfiles): Fix a typo.
9231
9232 2019-04-10  Tom Tromey  <tom@tromey.com>
9233
9234         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9235         * minsyms.c (lookup_minimal_symbol): Use foreach.
9236         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9237         (lookup_minimal_symbol_solib_trampoline): Likewise.
9238         * symfile.c (reread_symbols): Use foreach.
9239
9240 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9241             Tom Tromey  <tromey@adacore.com>
9242
9243         PR rust/24414:
9244         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9245         (rust_lex_int_test): Change "value" to be LONGEST.
9246         (rust_lex_tests): Add test for long integer literal.
9247
9248 2019-04-09  Tom Tromey  <tromey@adacore.com>
9249
9250         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9251         to bool.
9252         (extended_remote_target::attach): Update.
9253         (remote_target::remote_notice_new_inferior): Update.
9254         (remote_target::add_current_inferior_and_thread): Update.
9255         * inferior.c (exit_inferior_1): Use "false".
9256         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9257
9258 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9259
9260         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9261         the "start" command.
9262
9263 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9264
9265         * python/py-inferior.c (infpy_thread_from_thread_handle):
9266         Adjust comments to reflect renaming of thread_from_thread_handle
9267         to thread_from_handle.  Adjust keywords.  Fix type error message.
9268         (inferior_object_methods): Add thread_from_handle.  Retain
9269         thread_from_thread_handle, but mark it as deprecated.
9270
9271 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9272
9273         * gdbthread.h (find_thread_by_handle): Revise declaration.
9274         * thread.c (find_thread_by_handle): Likewise.  Adjust
9275         implementation too.
9276         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9277         support for buffer objects as handles.
9278
9279 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9280
9281         * python/py-infthread.c (thpy_thread_handle): New function.
9282         (thread_object_methods): Register thpy_thread_handle.
9283
9284 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9285
9286         * gdbthread.h (thread_to_thread_handle): Declare.
9287         * thread.c (gdbtypes.h): Include.
9288         (thread_to_thread_handle): New function.
9289
9290         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9291         (target_thread_info_to_thread_handle): Declare.
9292         * target.c (target_thread_info_to_thread_handle): New function.
9293         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9294         * target-delegates.c: Regenerate.
9295
9296         * linux-thread-db.c (class thread_db_target): Add method
9297         thread_info_to_thread_handle.
9298         (thread_db_target::thread_info_to_thread_handle): Define.
9299         * remote.c (class remote_target): Add new method
9300         thread_info_to_thread_handle.
9301         (remote_target::thread_info_to_thread_handle): Define.
9302
9303 2019-04-08  Pedro Alves  <palves@redhat.com>
9304
9305         * common/common-exceptions.c (throw_exception): Don't create
9306         named object to throw; throw directly.
9307         (throw_it): Likewise.  Don't initialize gdb_exception::message
9308         here, with new; pass FMT and AP to the ctor instead.
9309         * common/common-exceptions.h: Include <string>.
9310         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9311         const char *, va_list)): New ctor.  Use std::make_shared.
9312         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9313         errors)): Delete.
9314         (gdb_exception_error::gdb_exception_error(enum errors, const char
9315         *, va_list)): New.
9316         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9317         Add assertion.
9318         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9319         errors)): Delete.
9320         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9321         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9322         Add assertion.
9323
9324 2019-04-08  Tom Tromey  <tom@tromey.com>
9325
9326         * valops.c (value_rtti_indirect_type): Replace throw_exception
9327         with throw.
9328         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9329         with throw.
9330         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9331         throw.
9332         * target.c (target_translate_tls_address): Replace throw_exception
9333         with throw.
9334         * stack.c (frame_apply_command_count): Replace throw_exception
9335         with throw.
9336         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9337         throw.
9338         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9339         with throw.
9340         * rs6000-tdep.c (rs6000_frame_cache)
9341         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9342         * remote.c: Replace throw_exception with throw.
9343         * record-full.c (record_full_message, record_full_wait_1)
9344         (record_full_restore): Replace throw_exception with throw.
9345         * record-btrace.c:
9346         (get_thread_current_frame_id, record_btrace_start_replaying)
9347         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9348         (cmd_record_btrace_start): Replace throw_exception with throw.
9349         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9350         throw.
9351         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9352         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9353         * linespec.c:
9354         (find_linespec_symbols): Replace throw_exception with throw.
9355         * infrun.c (displaced_step_prepare, resume): Replace
9356         throw_exception with throw.
9357         * infcmd.c (post_create_inferior): Replace throw_exception with
9358         throw.
9359         * inf-loop.c (inferior_event_handler): Replace throw_exception
9360         with throw.
9361         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9362         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9363         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9364         (get_prev_frame_always, get_frame_pc_if_available)
9365         (get_frame_address_in_block_if_available, get_frame_language):
9366         Replace throw_exception with throw.
9367         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9368         throw_exception with throw.
9369         * eval.c (fetch_subexp_value, evaluate_var_value)
9370         (evaluate_funcall, evaluate_subexp_standard): Replace
9371         throw_exception with throw.
9372         * dwarf2loc.c (call_site_find_chain)
9373         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9374         Replace throw_exception with throw.
9375         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9376         with throw.
9377         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9378         throw.
9379         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9380         * completer.c (complete_line_internal): Replace throw_exception
9381         with throw.
9382         * compile/compile-object-run.c (compile_object_run): Replace
9383         throw_exception with throw.
9384         * cli/cli-script.c (process_next_line): Replace throw_exception
9385         with throw.
9386         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9387         (btrace_enable, btrace_maint_update_pt_packets): Replace
9388         throw_exception with throw.
9389         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9390         throw_exception with throw.
9391         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9392         throw_exception with throw.
9393         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9394         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9395         * aarch64-tdep.c (aarch64_make_prologue_cache)
9396         (aarch64_make_stub_cache): Replace throw_exception with throw.
9397
9398 2019-04-08  Tom Tromey  <tom@tromey.com>
9399
9400         * common/common-exceptions.c (throw_exception): Rename from
9401         throw_exception_cxx.  Remove old copy.  Make argument const.
9402         (throw_it): Create and throw exception objects directly.
9403         * common/common-exceptions.h (throw_exception): Make argument
9404         const.
9405         (struct gdb_exception_error): Add constructor.
9406         (struct gdb_exception_quit): Add constructor.
9407
9408 2019-04-08  Tom Tromey  <tom@tromey.com>
9409
9410         * common/common-exceptions.h (exception_rethrow): Don't declare.
9411         (TRY_SJLJ): Update comment.
9412         (TRY, CATCH, END_CATCH): Remove.
9413         * common/common-exceptions.c (exception_rethrow): Remove.
9414
9415 2019-04-08  Tom Tromey  <tom@tromey.com>
9416
9417         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9418         Remove.
9419         (gdb_exception_error): Rename from
9420         gdb_exception_RETURN_MASK_ERROR.
9421         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9422         (gdb_quit_bad_alloc): Update.
9423         * aarch64-tdep.c: Update.
9424         * ada-lang.c: Update.
9425         * ada-typeprint.c: Update.
9426         * ada-valprint.c: Update.
9427         * amd64-tdep.c: Update.
9428         * arch-utils.c: Update.
9429         * break-catch-throw.c: Update.
9430         * breakpoint.c: Update.
9431         * btrace.c: Update.
9432         * c-varobj.c: Update.
9433         * cli/cli-cmds.c: Update.
9434         * cli/cli-interp.c: Update.
9435         * cli/cli-script.c: Update.
9436         * common/common-exceptions.c: Update.
9437         * common/new-op.c: Update.
9438         * common/selftest.c: Update.
9439         * compile/compile-c-symbols.c: Update.
9440         * compile/compile-cplus-symbols.c: Update.
9441         * compile/compile-object-load.c: Update.
9442         * compile/compile-object-run.c: Update.
9443         * completer.c: Update.
9444         * corelow.c: Update.
9445         * cp-abi.c: Update.
9446         * cp-support.c: Update.
9447         * cp-valprint.c: Update.
9448         * darwin-nat.c: Update.
9449         * disasm-selftests.c: Update.
9450         * dtrace-probe.c: Update.
9451         * dwarf-index-cache.c: Update.
9452         * dwarf-index-write.c: Update.
9453         * dwarf2-frame-tailcall.c: Update.
9454         * dwarf2-frame.c: Update.
9455         * dwarf2loc.c: Update.
9456         * dwarf2read.c: Update.
9457         * eval.c: Update.
9458         * event-loop.c: Update.
9459         * event-top.c: Update.
9460         * exec.c: Update.
9461         * f-valprint.c: Update.
9462         * fbsd-tdep.c: Update.
9463         * frame-unwind.c: Update.
9464         * frame.c: Update.
9465         * gdbtypes.c: Update.
9466         * gnu-v3-abi.c: Update.
9467         * guile/guile-internal.h: Update.
9468         * guile/scm-block.c: Update.
9469         * guile/scm-breakpoint.c: Update.
9470         * guile/scm-cmd.c: Update.
9471         * guile/scm-disasm.c: Update.
9472         * guile/scm-frame.c: Update.
9473         * guile/scm-lazy-string.c: Update.
9474         * guile/scm-math.c: Update.
9475         * guile/scm-param.c: Update.
9476         * guile/scm-ports.c: Update.
9477         * guile/scm-pretty-print.c: Update.
9478         * guile/scm-symbol.c: Update.
9479         * guile/scm-symtab.c: Update.
9480         * guile/scm-type.c: Update.
9481         * guile/scm-value.c: Update.
9482         * i386-linux-tdep.c: Update.
9483         * i386-tdep.c: Update.
9484         * inf-loop.c: Update.
9485         * infcall.c: Update.
9486         * infcmd.c: Update.
9487         * infrun.c: Update.
9488         * jit.c: Update.
9489         * language.c: Update.
9490         * linespec.c: Update.
9491         * linux-fork.c: Update.
9492         * linux-nat.c: Update.
9493         * linux-tdep.c: Update.
9494         * linux-thread-db.c: Update.
9495         * main.c: Update.
9496         * mi/mi-cmd-break.c: Update.
9497         * mi/mi-cmd-stack.c: Update.
9498         * mi/mi-interp.c: Update.
9499         * mi/mi-main.c: Update.
9500         * objc-lang.c: Update.
9501         * p-valprint.c: Update.
9502         * parse.c: Update.
9503         * ppc-linux-tdep.c: Update.
9504         * printcmd.c: Update.
9505         * python/py-arch.c: Update.
9506         * python/py-breakpoint.c: Update.
9507         * python/py-cmd.c: Update.
9508         * python/py-finishbreakpoint.c: Update.
9509         * python/py-frame.c: Update.
9510         * python/py-framefilter.c: Update.
9511         * python/py-gdb-readline.c: Update.
9512         * python/py-inferior.c: Update.
9513         * python/py-infthread.c: Update.
9514         * python/py-lazy-string.c: Update.
9515         * python/py-linetable.c: Update.
9516         * python/py-objfile.c: Update.
9517         * python/py-param.c: Update.
9518         * python/py-prettyprint.c: Update.
9519         * python/py-progspace.c: Update.
9520         * python/py-record-btrace.c: Update.
9521         * python/py-record.c: Update.
9522         * python/py-symbol.c: Update.
9523         * python/py-type.c: Update.
9524         * python/py-unwind.c: Update.
9525         * python/py-utils.c: Update.
9526         * python/py-value.c: Update.
9527         * python/python.c: Update.
9528         * record-btrace.c: Update.
9529         * record-full.c: Update.
9530         * remote-fileio.c: Update.
9531         * remote.c: Update.
9532         * riscv-tdep.c: Update.
9533         * rs6000-aix-tdep.c: Update.
9534         * rs6000-tdep.c: Update.
9535         * rust-exp.y: Update.
9536         * rust-lang.c: Update.
9537         * s390-tdep.c: Update.
9538         * selftest-arch.c: Update.
9539         * solib-dsbt.c: Update.
9540         * solib-frv.c: Update.
9541         * solib-spu.c: Update.
9542         * solib-svr4.c: Update.
9543         * solib.c: Update.
9544         * sparc64-linux-tdep.c: Update.
9545         * stack.c: Update.
9546         * symfile-mem.c: Update.
9547         * symmisc.c: Update.
9548         * target.c: Update.
9549         * thread.c: Update.
9550         * top.c: Update.
9551         * tracefile-tfile.c: Update.
9552         * tui/tui.c: Update.
9553         * typeprint.c: Update.
9554         * unittests/cli-utils-selftests.c: Update.
9555         * unittests/parse-connection-spec-selftests.c: Update.
9556         * valops.c: Update.
9557         * valprint.c: Update.
9558         * value.c: Update.
9559         * varobj.c: Update.
9560         * windows-nat.c: Update.
9561         * x86-linux-nat.c: Update.
9562         * xml-support.c: Update.
9563
9564 2019-04-08  Tom Tromey  <tom@tromey.com>
9565
9566         * xml-support.c: Use C++ exception handling.
9567         * x86-linux-nat.c: Use C++ exception handling.
9568         * windows-nat.c: Use C++ exception handling.
9569         * varobj.c: Use C++ exception handling.
9570         * value.c: Use C++ exception handling.
9571         * valprint.c: Use C++ exception handling.
9572         * valops.c: Use C++ exception handling.
9573         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9574         handling.
9575         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9576         * typeprint.c: Use C++ exception handling.
9577         * tui/tui.c: Use C++ exception handling.
9578         * tracefile-tfile.c: Use C++ exception handling.
9579         * top.c: Use C++ exception handling.
9580         * thread.c: Use C++ exception handling.
9581         * target.c: Use C++ exception handling.
9582         * symmisc.c: Use C++ exception handling.
9583         * symfile-mem.c: Use C++ exception handling.
9584         * stack.c: Use C++ exception handling.
9585         * sparc64-linux-tdep.c: Use C++ exception handling.
9586         * solib.c: Use C++ exception handling.
9587         * solib-svr4.c: Use C++ exception handling.
9588         * solib-spu.c: Use C++ exception handling.
9589         * solib-frv.c: Use C++ exception handling.
9590         * solib-dsbt.c: Use C++ exception handling.
9591         * selftest-arch.c: Use C++ exception handling.
9592         * s390-tdep.c: Use C++ exception handling.
9593         * rust-lang.c: Use C++ exception handling.
9594         * rust-exp.y: Use C++ exception handling.
9595         * rs6000-tdep.c: Use C++ exception handling.
9596         * rs6000-aix-tdep.c: Use C++ exception handling.
9597         * riscv-tdep.c: Use C++ exception handling.
9598         * remote.c: Use C++ exception handling.
9599         * remote-fileio.c: Use C++ exception handling.
9600         * record-full.c: Use C++ exception handling.
9601         * record-btrace.c: Use C++ exception handling.
9602         * python/python.c: Use C++ exception handling.
9603         * python/py-value.c: Use C++ exception handling.
9604         * python/py-utils.c: Use C++ exception handling.
9605         * python/py-unwind.c: Use C++ exception handling.
9606         * python/py-type.c: Use C++ exception handling.
9607         * python/py-symbol.c: Use C++ exception handling.
9608         * python/py-record.c: Use C++ exception handling.
9609         * python/py-record-btrace.c: Use C++ exception handling.
9610         * python/py-progspace.c: Use C++ exception handling.
9611         * python/py-prettyprint.c: Use C++ exception handling.
9612         * python/py-param.c: Use C++ exception handling.
9613         * python/py-objfile.c: Use C++ exception handling.
9614         * python/py-linetable.c: Use C++ exception handling.
9615         * python/py-lazy-string.c: Use C++ exception handling.
9616         * python/py-infthread.c: Use C++ exception handling.
9617         * python/py-inferior.c: Use C++ exception handling.
9618         * python/py-gdb-readline.c: Use C++ exception handling.
9619         * python/py-framefilter.c: Use C++ exception handling.
9620         * python/py-frame.c: Use C++ exception handling.
9621         * python/py-finishbreakpoint.c: Use C++ exception handling.
9622         * python/py-cmd.c: Use C++ exception handling.
9623         * python/py-breakpoint.c: Use C++ exception handling.
9624         * python/py-arch.c: Use C++ exception handling.
9625         * printcmd.c: Use C++ exception handling.
9626         * ppc-linux-tdep.c: Use C++ exception handling.
9627         * parse.c: Use C++ exception handling.
9628         * p-valprint.c: Use C++ exception handling.
9629         * objc-lang.c: Use C++ exception handling.
9630         * mi/mi-main.c: Use C++ exception handling.
9631         * mi/mi-interp.c: Use C++ exception handling.
9632         * mi/mi-cmd-stack.c: Use C++ exception handling.
9633         * mi/mi-cmd-break.c: Use C++ exception handling.
9634         * main.c: Use C++ exception handling.
9635         * linux-thread-db.c: Use C++ exception handling.
9636         * linux-tdep.c: Use C++ exception handling.
9637         * linux-nat.c: Use C++ exception handling.
9638         * linux-fork.c: Use C++ exception handling.
9639         * linespec.c: Use C++ exception handling.
9640         * language.c: Use C++ exception handling.
9641         * jit.c: Use C++ exception handling.
9642         * infrun.c: Use C++ exception handling.
9643         * infcmd.c: Use C++ exception handling.
9644         * infcall.c: Use C++ exception handling.
9645         * inf-loop.c: Use C++ exception handling.
9646         * i386-tdep.c: Use C++ exception handling.
9647         * i386-linux-tdep.c: Use C++ exception handling.
9648         * guile/scm-value.c: Use C++ exception handling.
9649         * guile/scm-type.c: Use C++ exception handling.
9650         * guile/scm-symtab.c: Use C++ exception handling.
9651         * guile/scm-symbol.c: Use C++ exception handling.
9652         * guile/scm-pretty-print.c: Use C++ exception handling.
9653         * guile/scm-ports.c: Use C++ exception handling.
9654         * guile/scm-param.c: Use C++ exception handling.
9655         * guile/scm-math.c: Use C++ exception handling.
9656         * guile/scm-lazy-string.c: Use C++ exception handling.
9657         * guile/scm-frame.c: Use C++ exception handling.
9658         * guile/scm-disasm.c: Use C++ exception handling.
9659         * guile/scm-cmd.c: Use C++ exception handling.
9660         * guile/scm-breakpoint.c: Use C++ exception handling.
9661         * guile/scm-block.c: Use C++ exception handling.
9662         * guile/guile-internal.h: Use C++ exception handling.
9663         * gnu-v3-abi.c: Use C++ exception handling.
9664         * gdbtypes.c: Use C++ exception handling.
9665         * frame.c: Use C++ exception handling.
9666         * frame-unwind.c: Use C++ exception handling.
9667         * fbsd-tdep.c: Use C++ exception handling.
9668         * f-valprint.c: Use C++ exception handling.
9669         * exec.c: Use C++ exception handling.
9670         * event-top.c: Use C++ exception handling.
9671         * event-loop.c: Use C++ exception handling.
9672         * eval.c: Use C++ exception handling.
9673         * dwarf2read.c: Use C++ exception handling.
9674         * dwarf2loc.c: Use C++ exception handling.
9675         * dwarf2-frame.c: Use C++ exception handling.
9676         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9677         * dwarf-index-write.c: Use C++ exception handling.
9678         * dwarf-index-cache.c: Use C++ exception handling.
9679         * dtrace-probe.c: Use C++ exception handling.
9680         * disasm-selftests.c: Use C++ exception handling.
9681         * darwin-nat.c: Use C++ exception handling.
9682         * cp-valprint.c: Use C++ exception handling.
9683         * cp-support.c: Use C++ exception handling.
9684         * cp-abi.c: Use C++ exception handling.
9685         * corelow.c: Use C++ exception handling.
9686         * completer.c: Use C++ exception handling.
9687         * compile/compile-object-run.c: Use C++ exception handling.
9688         * compile/compile-object-load.c: Use C++ exception handling.
9689         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9690         * compile/compile-c-symbols.c: Use C++ exception handling.
9691         * common/selftest.c: Use C++ exception handling.
9692         * common/new-op.c: Use C++ exception handling.
9693         * cli/cli-script.c: Use C++ exception handling.
9694         * cli/cli-interp.c: Use C++ exception handling.
9695         * cli/cli-cmds.c: Use C++ exception handling.
9696         * c-varobj.c: Use C++ exception handling.
9697         * btrace.c: Use C++ exception handling.
9698         * breakpoint.c: Use C++ exception handling.
9699         * break-catch-throw.c: Use C++ exception handling.
9700         * arch-utils.c: Use C++ exception handling.
9701         * amd64-tdep.c: Use C++ exception handling.
9702         * ada-valprint.c: Use C++ exception handling.
9703         * ada-typeprint.c: Use C++ exception handling.
9704         * ada-lang.c: Use C++ exception handling.
9705         * aarch64-tdep.c: Use C++ exception handling.
9706
9707 2019-04-08  Tom Tromey  <tom@tromey.com>
9708
9709         * xml-support.c (gdb_xml_parser::parse): Update.
9710         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9711         * value.c (show_convenience): Update.
9712         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9713         (test_parse_flags_qcs): Update.
9714         * thread.c (thr_try_catch_cmd): Update.
9715         * target.c (target_translate_tls_address): Update.
9716         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9717         (info_frame_command_core, frame_apply_command_count): Update.
9718         * rust-exp.y (rust_lex_exception_test): Update.
9719         * riscv-tdep.c (riscv_print_one_register_info): Update.
9720         * remote.c (remote_target::enable_btrace): Update.
9721         * record-btrace.c (record_btrace_enable_warn): Update.
9722         * python/py-utils.c (gdbpy_convert_exception): Update.
9723         * printcmd.c (do_one_display, print_variable_and_value): Update.
9724         * mi/mi-main.c (mi_print_exception): Update.
9725         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9726         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9727         * linux-nat.c (linux_nat_target::attach): Update.
9728         * linux-fork.c (class scoped_switch_fork_info): Update.
9729         * infrun.c (displaced_step_prepare): Update.
9730         * infcall.c (call_function_by_hand_dummy): Update.
9731         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9732         * gnu-v3-abi.c (print_one_vtable): Update.
9733         * frame.c (get_prev_frame_always): Update.
9734         * f-valprint.c (info_common_command_for_block): Update.
9735         * exec.c (try_open_exec_file): Update.
9736         * exceptions.c (print_exception, exception_print)
9737         (exception_fprintf, exception_print_same): Update.
9738         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9739         * dwarf-index-cache.c (index_cache::store)
9740         (index_cache::lookup_gdb_index): Update.
9741         * darwin-nat.c (maybe_cache_shell): Update.
9742         * cp-valprint.c (cp_print_value_fields): Update.
9743         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9744         (gcc_cplus_symbol_address): Update.
9745         * compile/compile-c-symbols.c (gcc_convert_symbol)
9746         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9747         * common/selftest.c: Update.
9748         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9749         a std::string.
9750         (exception_try_scope_entry, exception_try_scope_exit): Don't
9751         declare.
9752         (struct exception_try_scope): Remove.
9753         (TRY): Don't use exception_try_scope.
9754         (struct gdb_exception): Add constructor, operator=.
9755         <what>: New method.
9756         (struct gdb_exception_RETURN_MASK_ALL)
9757         (struct gdb_exception_RETURN_MASK_ERROR)
9758         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9759         (struct gdb_quit_bad_alloc): Update.
9760         * common/common-exceptions.c (exception_none): Change
9761         initializer.
9762         (struct catcher) <state, exception>: Initialize inline.
9763         <prev>: Remove member.
9764         (current_catcher): Remove.
9765         (catchers): New global.
9766         (exceptions_state_mc_init): Simplify.
9767         (catcher_pop): Remove.
9768         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9769         (try_scope_depth, exception_try_scope_entry)
9770         (exception_try_scope_exit): Remove.
9771         (throw_exception_sjlj): Update.
9772         (exception_messages, exception_messages_size): Remove.
9773         (throw_it): Simplify.
9774         (gdb_exception_sliced_copy): Remove.
9775         (throw_exception_cxx): Update.
9776         * cli/cli-script.c (script_from_file): Update.
9777         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9778         Update.
9779         * ada-valprint.c (ada_val_print): Update.
9780         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9781         (create_excep_cond_exprs): Update.
9782
9783 2019-04-08  Tom Tromey  <tom@tromey.com>
9784
9785         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9786         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9787         (TRY, CATCH, END_CATCH): Remove some definitions.
9788         * common/common-exceptions.c: Don't use GDB_XCPT.
9789         (catcher_list_size): Remove.
9790         (throw_exception, throw_it): Simplify.
9791
9792 2019-04-05  Tom Tromey  <tom@tromey.com>
9793
9794         Revert the header-sorting patch.
9795         * ft32-tdep.c: Revert.
9796         * frv-tdep.c: Revert.
9797         * frv-linux-tdep.c: Revert.
9798         * frame.c: Revert.
9799         * frame-unwind.c: Revert.
9800         * frame-base.c: Revert.
9801         * fork-child.c: Revert.
9802         * findvar.c: Revert.
9803         * findcmd.c: Revert.
9804         * filesystem.c: Revert.
9805         * filename-seen-cache.h: Revert.
9806         * filename-seen-cache.c: Revert.
9807         * fbsd-tdep.c: Revert.
9808         * fbsd-nat.h: Revert.
9809         * fbsd-nat.c: Revert.
9810         * f-valprint.c: Revert.
9811         * f-typeprint.c: Revert.
9812         * f-lang.c: Revert.
9813         * extension.h: Revert.
9814         * extension.c: Revert.
9815         * extension-priv.h: Revert.
9816         * expprint.c: Revert.
9817         * exec.h: Revert.
9818         * exec.c: Revert.
9819         * exceptions.c: Revert.
9820         * event-top.c: Revert.
9821         * event-loop.c: Revert.
9822         * eval.c: Revert.
9823         * elfread.c: Revert.
9824         * dwarf2read.h: Revert.
9825         * dwarf2read.c: Revert.
9826         * dwarf2loc.c: Revert.
9827         * dwarf2expr.h: Revert.
9828         * dwarf2expr.c: Revert.
9829         * dwarf2-frame.c: Revert.
9830         * dwarf2-frame-tailcall.c: Revert.
9831         * dwarf-index-write.h: Revert.
9832         * dwarf-index-write.c: Revert.
9833         * dwarf-index-common.c: Revert.
9834         * dwarf-index-cache.h: Revert.
9835         * dwarf-index-cache.c: Revert.
9836         * dummy-frame.c: Revert.
9837         * dtrace-probe.c: Revert.
9838         * disasm.h: Revert.
9839         * disasm.c: Revert.
9840         * disasm-selftests.c: Revert.
9841         * dictionary.c: Revert.
9842         * dicos-tdep.c: Revert.
9843         * demangle.c: Revert.
9844         * dcache.h: Revert.
9845         * dcache.c: Revert.
9846         * darwin-nat.h: Revert.
9847         * darwin-nat.c: Revert.
9848         * darwin-nat-info.c: Revert.
9849         * d-valprint.c: Revert.
9850         * d-namespace.c: Revert.
9851         * d-lang.c: Revert.
9852         * ctf.c: Revert.
9853         * csky-tdep.c: Revert.
9854         * csky-linux-tdep.c: Revert.
9855         * cris-tdep.c: Revert.
9856         * cris-linux-tdep.c: Revert.
9857         * cp-valprint.c: Revert.
9858         * cp-support.c: Revert.
9859         * cp-namespace.c: Revert.
9860         * cp-abi.c: Revert.
9861         * corelow.c: Revert.
9862         * corefile.c: Revert.
9863         * continuations.c: Revert.
9864         * completer.h: Revert.
9865         * completer.c: Revert.
9866         * complaints.c: Revert.
9867         * coffread.c: Revert.
9868         * coff-pe-read.c: Revert.
9869         * cli-out.h: Revert.
9870         * cli-out.c: Revert.
9871         * charset.c: Revert.
9872         * c-varobj.c: Revert.
9873         * c-valprint.c: Revert.
9874         * c-typeprint.c: Revert.
9875         * c-lang.c: Revert.
9876         * buildsym.c: Revert.
9877         * buildsym-legacy.c: Revert.
9878         * build-id.h: Revert.
9879         * build-id.c: Revert.
9880         * btrace.c: Revert.
9881         * bsd-uthread.c: Revert.
9882         * breakpoint.h: Revert.
9883         * breakpoint.c: Revert.
9884         * break-catch-throw.c: Revert.
9885         * break-catch-syscall.c: Revert.
9886         * break-catch-sig.c: Revert.
9887         * blockframe.c: Revert.
9888         * block.c: Revert.
9889         * bfin-tdep.c: Revert.
9890         * bfin-linux-tdep.c: Revert.
9891         * bfd-target.c: Revert.
9892         * bcache.c: Revert.
9893         * ax-general.c: Revert.
9894         * ax-gdb.h: Revert.
9895         * ax-gdb.c: Revert.
9896         * avr-tdep.c: Revert.
9897         * auxv.c: Revert.
9898         * auto-load.c: Revert.
9899         * arm-wince-tdep.c: Revert.
9900         * arm-tdep.c: Revert.
9901         * arm-symbian-tdep.c: Revert.
9902         * arm-pikeos-tdep.c: Revert.
9903         * arm-obsd-tdep.c: Revert.
9904         * arm-nbsd-tdep.c: Revert.
9905         * arm-nbsd-nat.c: Revert.
9906         * arm-linux-tdep.c: Revert.
9907         * arm-linux-nat.c: Revert.
9908         * arm-fbsd-tdep.c: Revert.
9909         * arm-fbsd-nat.c: Revert.
9910         * arm-bsd-tdep.c: Revert.
9911         * arch-utils.c: Revert.
9912         * arc-tdep.c: Revert.
9913         * arc-newlib-tdep.c: Revert.
9914         * annotate.h: Revert.
9915         * annotate.c: Revert.
9916         * amd64-windows-tdep.c: Revert.
9917         * amd64-windows-nat.c: Revert.
9918         * amd64-tdep.c: Revert.
9919         * amd64-sol2-tdep.c: Revert.
9920         * amd64-obsd-tdep.c: Revert.
9921         * amd64-obsd-nat.c: Revert.
9922         * amd64-nbsd-tdep.c: Revert.
9923         * amd64-nbsd-nat.c: Revert.
9924         * amd64-nat.c: Revert.
9925         * amd64-linux-tdep.c: Revert.
9926         * amd64-linux-nat.c: Revert.
9927         * amd64-fbsd-tdep.c: Revert.
9928         * amd64-fbsd-nat.c: Revert.
9929         * amd64-dicos-tdep.c: Revert.
9930         * amd64-darwin-tdep.c: Revert.
9931         * amd64-bsd-nat.c: Revert.
9932         * alpha-tdep.c: Revert.
9933         * alpha-obsd-tdep.c: Revert.
9934         * alpha-nbsd-tdep.c: Revert.
9935         * alpha-mdebug-tdep.c: Revert.
9936         * alpha-linux-tdep.c: Revert.
9937         * alpha-linux-nat.c: Revert.
9938         * alpha-bsd-tdep.c: Revert.
9939         * alpha-bsd-nat.c: Revert.
9940         * aix-thread.c: Revert.
9941         * agent.c: Revert.
9942         * addrmap.c: Revert.
9943         * ada-varobj.c: Revert.
9944         * ada-valprint.c: Revert.
9945         * ada-typeprint.c: Revert.
9946         * ada-tasks.c: Revert.
9947         * ada-lang.c: Revert.
9948         * aarch64-tdep.c: Revert.
9949         * aarch64-ravenscar-thread.c: Revert.
9950         * aarch64-newlib-tdep.c: Revert.
9951         * aarch64-linux-tdep.c: Revert.
9952         * aarch64-linux-nat.c: Revert.
9953         * aarch64-fbsd-tdep.c: Revert.
9954         * aarch64-fbsd-nat.c: Revert.
9955         * aarch32-linux-nat.c: Revert.
9956
9957 2019-04-05  Tom Tromey  <tom@tromey.com>
9958
9959         * ft32-tdep.c: Sort headers.
9960         * frv-tdep.c: Sort headers.
9961         * frv-linux-tdep.c: Sort headers.
9962         * frame.c: Sort headers.
9963         * frame-unwind.c: Sort headers.
9964         * frame-base.c: Sort headers.
9965         * fork-child.c: Sort headers.
9966         * findvar.c: Sort headers.
9967         * findcmd.c: Sort headers.
9968         * filesystem.c: Sort headers.
9969         * filename-seen-cache.h: Sort headers.
9970         * filename-seen-cache.c: Sort headers.
9971         * fbsd-tdep.c: Sort headers.
9972         * fbsd-nat.h: Sort headers.
9973         * fbsd-nat.c: Sort headers.
9974         * f-valprint.c: Sort headers.
9975         * f-typeprint.c: Sort headers.
9976         * f-lang.c: Sort headers.
9977         * extension.h: Sort headers.
9978         * extension.c: Sort headers.
9979         * extension-priv.h: Sort headers.
9980         * expprint.c: Sort headers.
9981         * exec.h: Sort headers.
9982         * exec.c: Sort headers.
9983         * exceptions.c: Sort headers.
9984         * event-top.c: Sort headers.
9985         * event-loop.c: Sort headers.
9986         * eval.c: Sort headers.
9987         * elfread.c: Sort headers.
9988         * dwarf2read.h: Sort headers.
9989         * dwarf2read.c: Sort headers.
9990         * dwarf2loc.c: Sort headers.
9991         * dwarf2expr.h: Sort headers.
9992         * dwarf2expr.c: Sort headers.
9993         * dwarf2-frame.c: Sort headers.
9994         * dwarf2-frame-tailcall.c: Sort headers.
9995         * dwarf-index-write.h: Sort headers.
9996         * dwarf-index-write.c: Sort headers.
9997         * dwarf-index-common.c: Sort headers.
9998         * dwarf-index-cache.h: Sort headers.
9999         * dwarf-index-cache.c: Sort headers.
10000         * dummy-frame.c: Sort headers.
10001         * dtrace-probe.c: Sort headers.
10002         * disasm.h: Sort headers.
10003         * disasm.c: Sort headers.
10004         * disasm-selftests.c: Sort headers.
10005         * dictionary.c: Sort headers.
10006         * dicos-tdep.c: Sort headers.
10007         * demangle.c: Sort headers.
10008         * dcache.h: Sort headers.
10009         * dcache.c: Sort headers.
10010         * darwin-nat.h: Sort headers.
10011         * darwin-nat.c: Sort headers.
10012         * darwin-nat-info.c: Sort headers.
10013         * d-valprint.c: Sort headers.
10014         * d-namespace.c: Sort headers.
10015         * d-lang.c: Sort headers.
10016         * ctf.c: Sort headers.
10017         * csky-tdep.c: Sort headers.
10018         * csky-linux-tdep.c: Sort headers.
10019         * cris-tdep.c: Sort headers.
10020         * cris-linux-tdep.c: Sort headers.
10021         * cp-valprint.c: Sort headers.
10022         * cp-support.c: Sort headers.
10023         * cp-namespace.c: Sort headers.
10024         * cp-abi.c: Sort headers.
10025         * corelow.c: Sort headers.
10026         * corefile.c: Sort headers.
10027         * continuations.c: Sort headers.
10028         * completer.h: Sort headers.
10029         * completer.c: Sort headers.
10030         * complaints.c: Sort headers.
10031         * coffread.c: Sort headers.
10032         * coff-pe-read.c: Sort headers.
10033         * cli-out.h: Sort headers.
10034         * cli-out.c: Sort headers.
10035         * charset.c: Sort headers.
10036         * c-varobj.c: Sort headers.
10037         * c-valprint.c: Sort headers.
10038         * c-typeprint.c: Sort headers.
10039         * c-lang.c: Sort headers.
10040         * buildsym.c: Sort headers.
10041         * buildsym-legacy.c: Sort headers.
10042         * build-id.h: Sort headers.
10043         * build-id.c: Sort headers.
10044         * btrace.c: Sort headers.
10045         * bsd-uthread.c: Sort headers.
10046         * breakpoint.h: Sort headers.
10047         * breakpoint.c: Sort headers.
10048         * break-catch-throw.c: Sort headers.
10049         * break-catch-syscall.c: Sort headers.
10050         * break-catch-sig.c: Sort headers.
10051         * blockframe.c: Sort headers.
10052         * block.c: Sort headers.
10053         * bfin-tdep.c: Sort headers.
10054         * bfin-linux-tdep.c: Sort headers.
10055         * bfd-target.c: Sort headers.
10056         * bcache.c: Sort headers.
10057         * ax-general.c: Sort headers.
10058         * ax-gdb.h: Sort headers.
10059         * ax-gdb.c: Sort headers.
10060         * avr-tdep.c: Sort headers.
10061         * auxv.c: Sort headers.
10062         * auto-load.c: Sort headers.
10063         * arm-wince-tdep.c: Sort headers.
10064         * arm-tdep.c: Sort headers.
10065         * arm-symbian-tdep.c: Sort headers.
10066         * arm-pikeos-tdep.c: Sort headers.
10067         * arm-obsd-tdep.c: Sort headers.
10068         * arm-nbsd-tdep.c: Sort headers.
10069         * arm-nbsd-nat.c: Sort headers.
10070         * arm-linux-tdep.c: Sort headers.
10071         * arm-linux-nat.c: Sort headers.
10072         * arm-fbsd-tdep.c: Sort headers.
10073         * arm-fbsd-nat.c: Sort headers.
10074         * arm-bsd-tdep.c: Sort headers.
10075         * arch-utils.c: Sort headers.
10076         * arc-tdep.c: Sort headers.
10077         * arc-newlib-tdep.c: Sort headers.
10078         * annotate.h: Sort headers.
10079         * annotate.c: Sort headers.
10080         * amd64-windows-tdep.c: Sort headers.
10081         * amd64-windows-nat.c: Sort headers.
10082         * amd64-tdep.c: Sort headers.
10083         * amd64-sol2-tdep.c: Sort headers.
10084         * amd64-obsd-tdep.c: Sort headers.
10085         * amd64-obsd-nat.c: Sort headers.
10086         * amd64-nbsd-tdep.c: Sort headers.
10087         * amd64-nbsd-nat.c: Sort headers.
10088         * amd64-nat.c: Sort headers.
10089         * amd64-linux-tdep.c: Sort headers.
10090         * amd64-linux-nat.c: Sort headers.
10091         * amd64-fbsd-tdep.c: Sort headers.
10092         * amd64-fbsd-nat.c: Sort headers.
10093         * amd64-dicos-tdep.c: Sort headers.
10094         * amd64-darwin-tdep.c: Sort headers.
10095         * amd64-bsd-nat.c: Sort headers.
10096         * alpha-tdep.c: Sort headers.
10097         * alpha-obsd-tdep.c: Sort headers.
10098         * alpha-nbsd-tdep.c: Sort headers.
10099         * alpha-mdebug-tdep.c: Sort headers.
10100         * alpha-linux-tdep.c: Sort headers.
10101         * alpha-linux-nat.c: Sort headers.
10102         * alpha-bsd-tdep.c: Sort headers.
10103         * alpha-bsd-nat.c: Sort headers.
10104         * aix-thread.c: Sort headers.
10105         * agent.c: Sort headers.
10106         * addrmap.c: Sort headers.
10107         * ada-varobj.c: Sort headers.
10108         * ada-valprint.c: Sort headers.
10109         * ada-typeprint.c: Sort headers.
10110         * ada-tasks.c: Sort headers.
10111         * ada-lang.c: Sort headers.
10112         * aarch64-tdep.c: Sort headers.
10113         * aarch64-ravenscar-thread.c: Sort headers.
10114         * aarch64-newlib-tdep.c: Sort headers.
10115         * aarch64-linux-tdep.c: Sort headers.
10116         * aarch64-linux-nat.c: Sort headers.
10117         * aarch64-fbsd-tdep.c: Sort headers.
10118         * aarch64-fbsd-nat.c: Sort headers.
10119         * aarch32-linux-nat.c: Sort headers.
10120
10121 2019-04-04  Tom Tromey  <tom@tromey.com>
10122
10123         * varobj.c (varobj_create): Update.
10124         * rust-exp.y (struct rust_parser) <update_innermost_block,
10125         lookup_symbol>: New methods.
10126         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10127         Rename.
10128         (rust_parser::rust_lookup_type)
10129         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10130         * printcmd.c (display_command, do_one_display): Update.
10131         * parser-defs.h (struct parser_state) <parser_state>: Add
10132         "tracker" parameter.
10133         (block_tracker): New member.
10134         (class innermost_block_tracker) <innermost_block_tracker>: Add
10135         "types" parameter.
10136         <reset>: Remove method.
10137         (innermost_block): Don't declare.
10138         (null_post_parser): Update.
10139         * parse.c (innermost_block): Remove global.
10140         (write_dollar_variable): Update.
10141         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10142         Remove "tracker_types" parameter.
10143         (parse_expression): Add "tracker" parameter.
10144         (parse_expression_for_completion): Update.
10145         (null_post_parser): Add "tracker" parameter.
10146         * p-exp.y: Update rules.
10147         * m2-exp.y: Update rules.
10148         * language.h (struct language_defn) <la_post_parser>: Add
10149         "tracker" parameter.
10150         * go-exp.y: Update rules.
10151         * f-exp.y: Update rules.
10152         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10153         parameter.
10154         * d-exp.y: Update rules.
10155         * c-exp.y: Update rules.
10156         * breakpoint.c (set_breakpoint_condition): Create an
10157         innermost_block_tracker.
10158         (watch_command_1): Likewise.
10159         * ada-lang.c (resolve): Add "tracker" parameter.
10160         (resolve_subexp): Likewise.
10161         * ada-exp.y (write_var_from_sym): Update.
10162
10163 2019-04-04  Tom Tromey  <tom@tromey.com>
10164
10165         * type-stack.h: New file.
10166         * type-stack.c: New file.
10167         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10168         type-stack.h.
10169         (insert_into_type_stack, insert_type, push_type, push_type_int)
10170         (insert_type_address_space, pop_type, pop_type_int)
10171         (pop_typelist, pop_type_stack, append_type_stack)
10172         (push_type_stack, get_type_stack, push_typelist)
10173         (follow_type_instance_flags, follow_types): Don't declare.
10174         * parse.c (type_stack): Remove global.
10175         (parse_exp_in_context): Update.
10176         (insert_into_type_stack, insert_type, push_type, push_type_int)
10177         (insert_type_address_space, pop_type, pop_type_int)
10178         (pop_typelist, pop_type_stack, append_type_stack)
10179         (push_type_stack, get_type_stack, push_typelist)
10180         (follow_type_instance_flags, follow_types): Remove (moved to
10181         type-stack.c).
10182         * f-exp.y (type_stack): New global.
10183         Update rules.
10184         (push_kind_type, f_parse): Update.
10185         * d-exp.y (type_stack): New global.
10186         Update rules.
10187         (d_parse): Update.
10188         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10189         Update rules.
10190         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10191         (HFILES_NO_SRCDIR): Add type-stack.h.
10192
10193 2019-04-04  Tom Tromey  <tom@tromey.com>
10194
10195         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10196         (rust_parser::convert_ast_to_expression, rust_parse)
10197         (rust_lex_test_completion, rust_lex_tests): Update.
10198         * parser-defs.h (struct expr_completion_state): New.
10199         (struct parser_state) <parser_state>: Add completion parameter.
10200         <mark_struct_expression, mark_completion_tag>: New methods.
10201         <parse_completion, m_completion_state>: New members.
10202         (prefixify_expression, null_post_parser): Update.
10203         (mark_struct_expression, mark_completion_tag): Don't declare.
10204         * parse.c (parse_completion, expout_last_struct)
10205         (expout_tag_completion_type, expout_completion_name): Remove
10206         globals.
10207         (parser_state::mark_struct_expression)
10208         (parser_state::mark_completion_tag): Now methods.
10209         (prefixify_expression): Add last_struct parameter.
10210         (prefixify_subexp): Likewise.
10211         (parse_exp_1): Update.
10212         (parse_exp_in_context): Add cstate parameter.  Update.
10213         (parse_expression_for_completion): Create an
10214         expr_completion_state.
10215         (null_post_parser): Add "completion" parameter.
10216         * p-exp.y: Update rules.
10217         (yylex): Update.
10218         * language.h (struct language_defn) <la_post_parser>: Add
10219         "completing" parameter.
10220         * go-exp.y: Update rules.
10221         (lex_one_token): Update.
10222         * expression.h (parse_completion): Don't declare.
10223         * d-exp.y: Update rules.
10224         (lex_one_token): Update rules.
10225         * c-exp.y: Update rules.
10226         (lex_one_token): Update.
10227         * ada-lang.c (resolve): Add "parse_completion" parameter.
10228         (resolve_subexp): Likewise.
10229         (ada_resolve_function): Likewise.
10230
10231 2019-04-04  Tom Tromey  <tom@tromey.com>
10232
10233         * parser-defs.h (struct parser_state) <start_arglist,
10234         end_arglist>: New methods.
10235         <arglist_len, m_funcall_chain>: New members.
10236         (arglist_len, start_arglist, end_arglist): Don't declare.
10237         * parse.c (arglist_len, funcall_chain): Remove global.
10238         (start_arglist, end_arglist): Remove functions.
10239         (parse_exp_in_context): Update.
10240         * p-exp.y: Update rules.
10241         * m2-exp.y: Update rules.
10242         * go-exp.y: Update rules.
10243         * f-exp.y: Update rules.
10244         * d-exp.y: Update rules.
10245         * c-exp.y: Update rules.
10246
10247 2019-04-04  Tom Tromey  <tom@tromey.com>
10248
10249         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10250         lex_operator, push_back>: New methods.
10251         Update all rules.
10252         (rust_parser::lex_hex, lex_escape): Rename and update.
10253         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10254         (rust_parser::lex_operator): Rename and update.
10255         (rust_parser::lex_number, rustyylex, rustyyerror)
10256         (rust_lex_test_init, rust_lex_test_sequence)
10257         (rust_lex_test_push_back, rust_lex_tests): Update.
10258         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10259         parameter.
10260         <lexptr, prev_lexptr>: New members.
10261         (lexptr, prev_lexptr): Don't declare.
10262         * parse.c (lexptr, prev_lexptr): Remove globals.
10263         (parse_exp_in_context): Update.
10264         * p-exp.y (yylex, yyerror): Update.
10265         * m2-exp.y (parse_number, yylex, yyerror): Update.
10266         * go-exp.y (lex_one_token, yyerror): Update.
10267         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10268         * d-exp.y (lex_one_token, yyerror): Update.
10269         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10270         (lex_one_token, yyerror): Update.
10271         * ada-lex.l (YY_INPUT): Update.
10272         (rewind_to_char): Update.
10273         * ada-exp.y (yyerror): Update.
10274
10275 2019-04-04  Tom Tromey  <tom@tromey.com>
10276
10277         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10278         * parser-defs.h (struct parser_state) <parser_state>: Add new
10279         parameter.
10280         <comma_terminates>: New member.
10281         (comma_terminates): Don't declare global.
10282         * parse.c (comma_terminates): Remove global.
10283         (parse_exp_in_context): Update.
10284         * p-exp.y (yylex): Update.
10285         * m2-exp.y (yylex): Update.
10286         * go-exp.y (lex_one_token): Update.
10287         * f-exp.y (yylex): Update.
10288         * d-exp.y (lex_one_token): Update.
10289         * c-exp.y (lex_one_token): Update.
10290         * ada-lex.l: Update.
10291
10292 2019-04-04  Tom Tromey  <tom@tromey.com>
10293
10294         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10295         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10296         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10297         * parser-defs.h (paren_depth): Don't declare.
10298         * parse.c (paren_depth): Remove global.
10299         (parse_exp_in_context): Update.
10300         * p-exp.y (paren_depth): New global.
10301         (pascal_parse): Initialize it.
10302         * m2-exp.y (paren_depth): New global.
10303         (m2_parse): Initialize it.
10304         * go-exp.y (paren_depth): New global.
10305         (go_parse): Initialize it.
10306         * f-exp.y (paren_depth): New global.
10307         (f_parse): Initialize it.
10308         * d-exp.y (paren_depth): New global.
10309         (d_parse): Initialize it.
10310         * c-exp.y (paren_depth): New global.
10311         (c_parse): Initialize it.
10312         * ada-lex.l (paren_depth): New global.
10313         (lexer_init): Initialize it.
10314
10315 2019-04-04  Tom Tromey  <tom@tromey.com>
10316
10317         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10318         (rust_parser::convert_ast_to_type)
10319         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10320         * parser-defs.h (struct parser_state) <parser_state>: Add
10321         parameters.  Initialize new members.
10322         <expression_context_block, expression_context_pc>: New members.
10323         * parse.c (expression_context_block, expression_context_pc):
10324         Remove globals.
10325         (parse_exp_in_context): Update.
10326         * p-exp.y: Update all rules.
10327         (yylex): Update.
10328         * m2-exp.y: Update all rules.
10329         (yylex): Update.
10330         * go-exp.y (yylex): Update.
10331         * f-exp.y (yylex): Update.
10332         * d-exp.y: Update all rules.
10333         (yylex): Update.
10334         * c-exp.y: Update all rules.
10335         (lex_one_token, classify_name, yylex, c_parse): Update.
10336         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10337
10338 2019-04-04  Tom Tromey  <tom@tromey.com>
10339
10340         * gdbarch.h, gdbarch.c: Rebuild.
10341         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10342         * stap-probe.h:
10343         (struct stap_parse_info): Replace "parser_state" with
10344         "expr_builder".
10345         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10346         (parser_state): New class.
10347         * parse.c (expr_builder): Rename.
10348         (expr_builder::release): Rename.
10349         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10350         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10351         (write_exp_elt_longcst, write_exp_elt_floatcst)
10352         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10353         (write_exp_string_vector, write_exp_bitstring)
10354         (write_exp_msymbol, mark_struct_expression)
10355         (write_dollar_variable)
10356         (insert_type_address_space, increase_expout_size): Replace
10357         "parser_state" with "expr_builder".
10358         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10359         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10360         "parser_state" with "expr_builder".
10361
10362 2019-04-04  Tom Tromey  <tom@tromey.com>
10363
10364         * rust-exp.y: Replace "parse_language" with method call.
10365         * p-exp.y:
10366         (yylex): Replace "parse_language" with method call.
10367         * m2-exp.y:
10368         (yylex): Replace "parse_language" with method call.
10369         * go-exp.y (classify_name): Replace "parse_language" with method
10370         call.
10371         * f-exp.y (yylex): Replace "parse_language" with method call.
10372         * d-exp.y (lex_one_token): Replace "parse_language" with method
10373         call.
10374         * c-exp.y:
10375         (lex_one_token, classify_name, yylex): Replace "parse_language"
10376         with method call.
10377         * ada-exp.y (find_primitive_type, type_char)
10378         (type_system_address): Replace "parse_language" with method call.
10379
10380 2019-04-04  Tom Tromey  <tom@tromey.com>
10381
10382         * rust-exp.y: Replace "parse_gdbarch" with method call.
10383         * parse.c (write_dollar_variable, insert_type_address_space):
10384         Replace "parse_gdbarch" with method call.
10385         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10386         call.
10387         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10388         call.
10389         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10390         "parse_gdbarch" with method call.
10391         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10392         with method call.
10393         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10394         "parse_gdbarch" with method call.
10395         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10396         "parse_gdbarch" with method call.
10397         * c-exp.y (parse_type, parse_number, classify_name): Replace
10398         "parse_gdbarch" with method call.
10399         * ada-lex.l: Replace "parse_gdbarch" with method call.
10400         * ada-exp.y (parse_type, find_primitive_type, type_char)
10401         (type_system_address): Replace "parse_gdbarch" with method call.
10402
10403 2019-04-04  Tom Tromey  <tom@tromey.com>
10404
10405         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10406         * stap-probe.c (stap_parse_argument): Update.
10407         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10408         initial_size parameter.
10409         * rust-exp.y (rust_lex_tests): Update.
10410         * parse.c (parser_state): Update.
10411         (parse_exp_in_context): Update.
10412         * parser-defs.h (struct parser_state) <parser_state>: Remove
10413         "initial_size" parameter.
10414
10415 2019-04-04  Tom Tromey  <tom@tromey.com>
10416
10417         * parser-defs.h (increase_expout_size): Don't declare.
10418         * parse.c (increase_expout_size): Now static.
10419
10420 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10421
10422         * gnu-nat.c (gnu_nat_target::wait): Fix
10423         target_waitstatus_to_string call.
10424
10425 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10426
10427         * eval.c (evaluate_subexp_standard): Handle internal functions
10428         during Fortran function call handling.
10429
10430 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10431
10432         * NEWS: Mention new internal functions.
10433         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10434         (read_base_type): Use dwarf2_init_complex_target_type.
10435         * value.c (creal_internal_fn): New function.
10436         (cimag_internal_fn): New function.
10437         (_initialize_values): Register new internal functions.
10438
10439 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10440
10441         * infrun.c (stop_all_threads): If debug_infrun, always
10442         trace the wait status after wait_one, using
10443         target_waitstatus_to_string and target_pid_to_str.
10444         (handle_inferior_event): Replace various trace of
10445         wait status kind by a single trace.
10446         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10447         wait status kind image by target_waitstatus_to_string.
10448         * target/waitstatus.c (target_waitstatus_to_string): Fix
10449         obsolete comment.
10450
10451 2019-04-01  Tom Tromey  <tromey@adacore.com>
10452
10453         PR symtab/23331:
10454         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10455
10456 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10457             Pedro Alves  <palves@redhat.com>
10458
10459         * top.c (quit_force): Call 'finalize_values'.
10460         * value.c (finalize_values): New function.
10461         * value.h (finalize_values): Declare.
10462
10463 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10464
10465         * NEWS: Announce $_gdb_major and $_gdb_minor.
10466
10467         * top.c (init_gdb_version_vars): New function.
10468         (gdb_init): Call init_gdb_version_vars.
10469
10470 2019-03-29  Tom Tromey  <tromey@adacore.com>
10471
10472         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10473         help text.  Remove dead code.
10474
10475 2019-03-29  Keith Seitz  <keiths@redhat.com>
10476
10477         From Siddhesh Poyarekar:
10478         * f-lang.h (f77_get_upperbound): Return LONGEST.
10479         (f77_get_lowerbound): Likewise.
10480         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10481         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10482         print them.
10483         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10484         plongest to format print it.
10485         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10486         (f77_get_upperbound): Likewise.
10487         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10488         LOWER_BOUND to LONGEST.
10489         (f77_create_arrayprint_offset_tbl): Likewise.
10490
10491 2019-03-29  Keith Seitz  <keiths@redhat.com>
10492
10493         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10494         %s/pulongest for TYPE_LENGTH instead of %d in format
10495         strings.
10496         * ada-typerint.c (ada_print_type): Likewise.
10497         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10498         * compile/compile-c-support.c (generate_register_struct): Likewise.
10499         * gdbtypes.c (recursive_dump_type): Likewise.
10500         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10501         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10502         instead of %d in format strings.
10503         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10504         to std::min to ULONGEST.
10505         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10506         instead of %d in format strings.
10507         * tracepoint.c (info_scope_command): Likewise.
10508         * typeprint.c (print_offset_data::update)
10509         (print_offset_data::finish): Likewise.
10510         * xtensa-tdep.c (xtensa_store_return_value)
10511         (xtensa_push_dummy_call): Likewise.
10512
10513 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10514
10515         * windows-nat.c (display_selector): Fixed format specifications
10516         for 64-bit Cygwin.
10517
10518 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10519
10520         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10521
10522 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10523
10524         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10525         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10526         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10527         (nios2_linux_init_abi): Install it.
10528
10529 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10530
10531         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10532
10533 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10534
10535         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10536
10537 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10538             Tom Tromey  <tromey@adacore.com>
10539
10540         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10541
10542 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10543
10544         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10545         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10546         method to compute the bounds of range types. Also print "[evaluated]"
10547         if the bounds' values come from a dynamic evaluation.
10548
10549 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10550
10551         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10552         whitespace when pretty printing is on.
10553
10554 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10555
10556         * ppc-linux-nat.c: Add include.
10557
10558 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10559
10560         * NEWS: Mention AArch64 Pointer Authentication.
10561
10562 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10563
10564         * arm-linux-nat.c: Add include.
10565
10566 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10567
10568         * source-cache.c (source_cache::get_source_lines): Re-read
10569         fullname after calling open_source_file.
10570
10571 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10572
10573         * NEWS: Mention TLS support for FreeBSD.
10574
10575 2019-03-25  Tom Tromey  <tromey@adacore.com>
10576
10577         * minsyms.c (BUNCH_SIZE): Update comment.
10578         (~minimal_symbol_reader): Remove old comment.
10579         (compact_minimal_symbols): Update comment.
10580         (minimal_symbol_reader::install): Remove old comment.  Update
10581         other comments.
10582
10583 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10584
10585         * s390-linux-nat.c: Add include.
10586
10587 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10588
10589         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10590         Call linux_get_hwcap.
10591         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10592         Likewise.
10593         (aarch64_linux_get_hwcap): Remove function.
10594         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10595         declaration.
10596         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10597         linux_get_hwcap.
10598         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10599         * linux-tdep.c (linux_get_hwcap): Add function.
10600         (linux_get_hwcap2): Likewise.
10601         * linux-tdep.h (linux_get_hwcap): Add declaration.
10602         (linux_get_hwcap2): Likewise.
10603         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10604         (ppc_linux_get_hwcap2): Likewise.
10605         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10606         linux_get_hwcap.
10607         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10608         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10609         (ppc_linux_nat_target::read_description): Likewise.
10610         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10611         * s390-linux-nat.c: Likewise.
10612         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10613
10614 2019-03-24  Tom Tromey  <tom@tromey.com>
10615
10616         * ada-lang.c (standard_lookup): Simplify initialization.
10617         (ada_lookup_symbol_nonlocal): Simplify return.
10618         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10619         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10620         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10621         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10622         initialization.
10623         * solib.c (solib_global_lookup): Simplify.
10624         * symtab.c (null_block_symbol): Remove.
10625         (symbol_cache_lookup): Simplify returns.
10626         (lookup_language_this): Simplify returns.
10627         (lookup_symbol_aux): Simplify return.
10628         (lookup_local_symbol): Simplify returns.
10629         (lookup_global_symbol_from_objfile): Simplify return.
10630         (lookup_symbol_in_objfile_symtabs)
10631         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10632         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10633         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10634         * cp-namespace.c (cp_lookup_bare_symbol)
10635         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10636         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10637         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10638         (cp_lookup_symbol_via_imports): Simplify initialization.
10639         (find_symbol_in_baseclass): Likewise.
10640         * symtab.h (null_block_symbol): Remove.
10641         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10642         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10643         (d_lookup_symbol_module): Likewise.
10644         (find_symbol_in_baseclass): Simplify initialization.
10645
10646 2019-03-24  Tom Tromey  <tom@tromey.com>
10647
10648         * expression.h: Don't include symtab.h.
10649         (struct block): Forward declare.
10650
10651 2019-03-24  Tom Tromey  <tom@tromey.com>
10652
10653         * c-exp.y (typebase): Remove casts.
10654         * gdbtypes.c (lookup_unsigned_typename, )
10655         (lookup_signed_typename): Remove cast.
10656         * eval.c (parse_to_comma_and_eval): Remove cast.
10657         * parse.c (write_dollar_variable): Remove cast.
10658         * block.h (struct block) <superblock>: Now const.
10659         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10660         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10661         (map_block): Make "block" const.
10662         * symfile.h (struct quick_symbol_functions)
10663         <map_matching_symbols>: Constify block argument to "callback".
10664         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10665         const.
10666         (find_pc_sect_compunit_symtab): Make "b" const.
10667         (find_symbol_at_address): Likewise.
10668         (search_symbols): Likewise.
10669         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10670         (dw2_debug_names_lookup_symbol): Likewise.
10671         (dw2_map_matching_symbols): Update.
10672         * p-valprint.c (pascal_val_print): Remove "block".
10673         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10674         (aux_add_nonlocal_symbols): Make "block" const.
10675         (resolve_subexp): Remove cast.
10676         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10677         const.
10678         (iterate_over_file_blocks): Likewise.
10679         * f-exp.y (%union) <bval>: Remove.
10680         * coffread.c (patch_opaque_types): Make "b" const.
10681         * spu-tdep.c (spu_catch_start): Make "block" const.
10682         * c-valprint.c (print_unpacked_pointer): Remove "block".
10683         * symmisc.c (dump_symtab_1): Make "b" const.
10684         (block_depth): Make "block" const.
10685         * d-exp.y (%union) <bval>: Remove.
10686         * cp-support.h (cp_lookup_rtti_type): Update.
10687         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10688         * psymtab.c (psym_lookup_symbol): Make "block" const.
10689         (maintenance_check_psymtabs): Make "b" const.
10690         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10691         (enumerate_locals, enumerate_args): Update.
10692         * python/py-symtab.c (stpy_global_block): Make "block" const.
10693         (stpy_static_block): Likewise.
10694         * inline-frame.c (block_starting_point_at): Make "new_block"
10695         const.
10696         * block.c (find_block_in_blockvector): Make return type const.
10697         (blockvector_for_pc_sect): Make "b" const.
10698         (find_block_in_blockvector): Make "b" const.
10699
10700 2019-03-23  Tom Tromey  <tom@tromey.com>
10701
10702         * varobj.c (varobj_create): Update.
10703         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10704         * printcmd.c (display_command, do_one_display): Don't reset
10705         innermost_block.
10706         * parser-defs.h (enum innermost_block_tracker_type): Move to
10707         expression.h.
10708         (innermost_block): Update comment.
10709         * parse.c (parse_exp_1): Add tracker_types parameter.
10710         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10711         tracker_types parameter.  Reset innermost_block.
10712         (parse_exp_in_context): Remove.
10713         (parse_expression_for_completion): Update.
10714         * objfiles.c (~objfile): Don't reset expression_context_block or
10715         innermost_block.
10716         * expression.h (enum innermost_block_tracker_type): Move from
10717         parser-defs.h.
10718         (parse_exp_1): Add tracker_types parameter.
10719         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10720         reset innermost_block.
10721
10722 2019-03-23  Tom Tromey  <tom@tromey.com>
10723
10724         * objfiles.h: Include bcache.h.
10725
10726 2019-03-23  Tom Tromey  <tom@tromey.com>
10727
10728         * linespec.c (get_current_search_block): Use
10729         scoped_restore_current_language.
10730         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10731
10732 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10733             Jiong Wang  <jiong.wang@arm.com>
10734
10735         * aarch64-linux-tdep.c
10736         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10737         section.
10738         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10739
10740 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10741             Jiong Wang  <jiong.wang@arm.com>
10742
10743         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10744         instructions.
10745         (aarch64_analyze_prologue_test): Add PACIASP test.
10746         (aarch64_prologue_prev_register): Unmask PC value.
10747
10748 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10749             Jiong Wang  <jiong.wang@arm.com>
10750
10751         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10752         (aarch64_dwarf2_prev_register): Unmask PC value.
10753         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10754         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10755         DW_CFA_AARCH64_negate_ra_state.
10756         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10757
10758 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10759             Jiong Wang  <jiong.wang@arm.com>
10760
10761         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10762         registers.
10763         (aarch64_pseudo_register_name): Likewise.
10764         (aarch64_pseudo_register_type): Likewise.
10765         (aarch64_pseudo_register_reggroup_p): Likewise.
10766         (aarch64_gdbarch_init): Add pauth registers.
10767         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10768         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10769         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10770         (struct gdbarch_tdep): Add regnum for ra_state.
10771
10772 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10773             Jiong Wang  <jiong.wang@arm.com>
10774
10775         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10776
10777 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10778             Jiong Wang  <jiong.wang@arm.com>
10779
10780         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10781         function.
10782         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10783         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10784         (aarch64_gdbarch_init): Add puth registers.
10785         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10786         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10787         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10788
10789 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10790             Jiong Wang  <jiong.wang@arm.com>
10791
10792         * aarch64-linux-nat.c
10793         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10794         * aarch64-linux-tdep.c
10795         (aarch64_linux_core_read_description): Likewise.
10796         (aarch64_linux_get_hwcap): New function.
10797         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10798         (aarch64_linux_get_hwcap): New declaration.
10799
10800 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10801             Jiong Wang  <jiong.wang@arm.com>
10802
10803         * aarch64-linux-nat.c
10804         (aarch64_linux_nat_target::read_description): Add pauth param.
10805         * aarch64-linux-tdep.c
10806         (aarch64_linux_core_read_description): Likewise.
10807         * aarch64-tdep.c (struct target_desc): Add in pauth.
10808         (aarch64_read_description): Add pauth param.
10809         (aarch64_gdbarch_init): Likewise.
10810         * aarch64-tdep.h (aarch64_read_description): Likewise.
10811         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10812         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10813         * features/Makefile: Add new files.
10814         * features/aarch64-pauth.c: New file.
10815         * features/aarch64-pauth.xml: New file.
10816
10817 2019-03-20  Tom Tromey  <tromey@adacore.com>
10818
10819         * infrun.c (handle_inferior_event): Rename from
10820         handle_inferior_event_1.  Create a scoped_value_mark.
10821         (handle_inferior_event): Remove.
10822
10823 2019-03-19  Tom Tromey  <tromey@adacore.com>
10824
10825         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10826         * infrun.h (print_stop_event): Add "displays" parameter.
10827         * infrun.c (print_stop_event): Add "displays" parameter.
10828
10829 2019-03-19  Pedro Alves  <palves@redhat.com>
10830
10831         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10832         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10833         to -1.  Fix TABs vs spaces.
10834         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10835         * tui/tui-out.h (tui_ui_out) Add intro comments.
10836         <m_line, m_start_of_line>: In-class initialize, and add describing
10837         comment.
10838
10839 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10840
10841         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10842         variable names.
10843         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10844
10845 2019-03-18  Pedro Alves  <palves@redhat.com>
10846             Eli Zaretskii <eliz@gnu.org>
10847
10848         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10849         m_line and m_start_of_line.
10850
10851 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10852
10853         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10854         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10855         it returns a newline.  This fixes a regression in TU mode, whereby
10856         the next line is output on the same screen line as the user input.
10857
10858 2019-03-18  Tom Tromey  <tromey@adacore.com>
10859
10860         * minsyms.c (minimal_symbol_reader::install): Remove call to
10861         obstack_blank.
10862
10863 2019-03-18  Pedro Alves  <palves@redhat.com>
10864
10865         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10866         New globals.
10867         (apply_style): New, factored out from ...
10868         (apply_ansi_escape): ... this.  Handle reverse video mode.
10869         (tui_set_reverse_mode): New function.
10870         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10871         * tui/tui-winsource.c (tui_show_source_line): Use
10872         tui_set_reverse_mode instead of setting A_STANDOUT.
10873         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10874         New setter methods.
10875
10876 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10877
10878         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10879         Handle tabs.
10880
10881 2019-03-18  Tom Tromey  <tromey@adacore.com>
10882
10883         * ada-lang.c (empty_array): Add "high" parameter.
10884         (ada_evaluate_subexp): Update.
10885
10886 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10887
10888         * unittests/string_view-selftests.c: Define
10889         _initialize_string_view_selftests unconditionally.
10890
10891 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10892
10893         PR gdb/24350
10894         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10895
10896 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10897
10898         PR gdb/24351
10899         * windows-nat.c (display_selector): Fix format specifiers.
10900
10901 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10902
10903         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10904         tui_refill_source_window instead of tui_refresh_win, to update the
10905         current execution line.  This fixes redisplay of the current line
10906         when stepping through the code with "next" or "step".
10907
10908 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10909
10910         * source-cache.c (source_cache::get_source_lines): Call
10911         find_source_lines to initialize s->nlines.  This fixes vertical
10912         scrolling of TUI source window when the DOWN arrow is pressed.
10913
10914 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10915
10916         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10917         linux-thread-db.c (_initialize_thread_db): Likewise.
10918
10919 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10920
10921         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10922         wclrtoeol in tui_show_source_line".  This reverts changes made in
10923         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10924
10925 2019-03-15  Tom Tromey  <tom@tromey.com>
10926
10927         * symtab.h (struct minimal_symbol): Derive from
10928         general_symbol_info.
10929         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10930         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10931         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10932         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10933         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10934         (MSYMBOL_SEARCH_NAME): Update.
10935         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10936         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10937         * minsyms.c (minimal_symbol_reader::record_full): Update.
10938
10939 2019-03-15  Tom Tromey  <tom@tromey.com>
10940
10941         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10942
10943 2019-03-15  Tom Tromey  <tom@tromey.com>
10944
10945         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10946         unique_xmalloc_ptr.
10947         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10948         Update.
10949         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10950         (build_minimal_symbol_hash_tables)
10951         (minimal_symbol_reader::install): Update.
10952
10953 2019-03-15  Tom Tromey  <tom@tromey.com>
10954
10955         * symtab.c (create_demangled_names_hash): Update.
10956         (symbol_set_names): Update.
10957         * objfiles.h (struct objfile_per_bfd_storage)
10958         <demangled_names_hash>: Now an htab_up.
10959         * objfiles.c (objfile_per_bfd_storage): Simplify.
10960
10961 2019-03-15  Tom Tromey  <tom@tromey.com>
10962
10963         * objfiles.h (struct objfile_per_bfd_storage): Declare
10964         destructor.
10965         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10966         New.
10967         (get_objfile_bfd_data): Use new.  Don't initialize
10968         language_of_main.
10969         (free_objfile_per_bfd_storage): Remove.
10970         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10971
10972 2019-03-15  Tom Tromey  <tom@tromey.com>
10973
10974         * symfile.c (reread_symbols): Update.
10975         * objfiles.c (objfile::objfile): Update.
10976         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10977         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10978         comment.
10979         (minimal_symbol_reader::install): Update.
10980         (terminate_minimal_symbol_table): Remove.
10981         * jit.c (jit_object_close_impl): Update.
10982
10983 2019-03-15  Tom Tromey  <tom@tromey.com>
10984
10985         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10986         initializations.
10987
10988 2019-03-15  Tom Tromey  <tom@tromey.com>
10989
10990         * objfiles.h (struct objfile_per_bfd_storage)
10991         <demangled_hash_languages>: Now a bitset.
10992         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10993         (lookup_minimal_symbol): Update.
10994
10995 2019-03-15  Tom Tromey  <tom@tromey.com>
10996
10997         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10998         Don't return the symbol.
10999         * coffread.c (record_minimal_symbol): Use record_full.
11000
11001 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11002
11003         The MS-Windows port of ncurses fails to switch to a color pair if
11004         one or both of the colors are the implicit default colors.  This
11005         change records the default colors when TUI is initialized, and
11006         then specifies them explicitly when a color pair uses the default
11007         colors.  This allows color styling in TUI mode on MS-Windows.
11008
11009         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11010         ncurses_norm_attr.
11011         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11012         colors in ncurses_norm_attr.
11013         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11014         "none", replace it with the default color recorded in
11015         ncurses_norm_attr.
11016
11017 2019-03-14  Tom Tromey  <tromey@adacore.com>
11018
11019         * source-cache.h (class source_cache) <get_source_lines>: Return
11020         std::string.
11021         * source-cache.c (source_cache::extract_lines): Handle case where
11022         first_pos==npos.  Return std::string.
11023         (source_cache::get_source_lines): Update.
11024
11025 2019-03-14  Tom Tromey  <tromey@adacore.com>
11026
11027         * NEWS: Add item for "style sources" commands.
11028         * source-cache.c (source_cache::get_source_lines): Check
11029         source_styling.
11030         * cli/cli-style.c (source_styling): New global.
11031         (_initialize_cli_style): Add "style sources" commands.
11032         (show_style_sources): New function.
11033         * cli/cli-style.h (source_styling): Declare.
11034
11035 2019-03-14  Pedro Alves  <palves@redhat.com>
11036             Tom Tromey  <tromey@adacore.com>
11037
11038         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11039         * tui/tui-winsource.c (tui_refill_source_window): New function,
11040         from...
11041         (tui_horizontal_source_scroll): ... here.  Move some logic.
11042         * cli/cli-style.c (set_style_enabled): Notify new observable.
11043         * tui/tui-hooks.c (tui_redisplay_source): New function.
11044         (tui_attach_detach_observers): Attach or detach
11045         tui_redisplay_source.
11046         * observable.h (source_styling_changed): New observable.
11047         * observable.c: Define source_styling_changed observable.
11048
11049 2019-03-13  Tom Tromey  <tromey@adacore.com>
11050
11051         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11052         (i386_gnu_nat_target::store_registers): Update.
11053         * target-debug.h (target_debug_print_std_string): New macro.
11054         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11055         * windows-tdep.c (display_one_tib): Update.
11056         * tui/tui-stack.c (tui_make_status_line): Update.
11057         * top.c (print_inferior_quit_action): Update.
11058         * thread.c (thr_try_catch_cmd): Update.
11059         (add_thread_with_info): Update.
11060         (thread_target_id_str): Update.
11061         (thr_try_catch_cmd): Update.
11062         (thread_command): Update.
11063         (thread_find_command): Update.
11064         * record-btrace.c (record_btrace_target::info_record)
11065         (record_btrace_resume_thread, record_btrace_target::resume)
11066         (record_btrace_cancel_resume, record_btrace_step_thread)
11067         (record_btrace_target::wait, record_btrace_target::wait)
11068         (record_btrace_target::wait, record_btrace_target::stop): Update.
11069         * progspace.c (print_program_space): Update.
11070         * process-stratum-target.c
11071         (process_stratum_target::thread_address_space): Update.
11072         * linux-fork.c (linux_fork_mourn_inferior)
11073         (detach_checkpoint_command, info_checkpoints_command)
11074         (linux_fork_context): Update.
11075         (linux_fork_detach): Update.
11076         (class scoped_switch_fork_info): Update.
11077         (delete_checkpoint_command): Update.
11078         * infrun.c (follow_fork_inferior): Update.
11079         (follow_fork_inferior): Update.
11080         (proceed_after_vfork_done): Update.
11081         (handle_vfork_child_exec_or_exit): Update.
11082         (follow_exec): Update.
11083         (displaced_step_prepare_throw): Update.
11084         (displaced_step_restore): Update.
11085         (start_step_over): Update.
11086         (resume_1): Update.
11087         (clear_proceed_status_thread): Update.
11088         (proceed): Update.
11089         (print_target_wait_results): Update.
11090         (do_target_wait): Update.
11091         (context_switch): Update.
11092         (stop_all_threads): Update.
11093         (restart_threads): Update.
11094         (finish_step_over): Update.
11095         (handle_signal_stop): Update.
11096         (switch_back_to_stepped_thread): Update.
11097         (keep_going_pass_signal): Update.
11098         (print_exited_reason): Update.
11099         (normal_stop): Update.
11100         * inferior.c (inferior_pid_to_str): Change return type.
11101         (print_selected_inferior): Update.
11102         (add_inferior): Update.
11103         (detach_inferior): Update.
11104         * dummy-frame.c (fprint_dummy_frames): Update.
11105         * dcache.c (dcache_info_1): Update.
11106         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11107         (btrace_fetch, btrace_clear): Update.
11108         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11109         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11110         type.
11111         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11112         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11113         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11114         * gdbarch.c, gdbarch.h: Rebuild.
11115         * gdbarch.sh (core_pid_to_str): Change return type.
11116         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11117         return type.
11118         (windows_nat_target::pid_to_str): Change return type.
11119         (windows_delete_thread): Update.
11120         (windows_nat_target::attach): Update.
11121         (windows_nat_target::files_info): Update.
11122         * target-delegates.c: Rebuild.
11123         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11124         return type.
11125         (sol_thread_target::pid_to_str): Change return type.
11126         * remote.c (class remote_target) <pid_to_str>: Change return
11127         type.
11128         (remote_target::pid_to_str): Change return type.
11129         (extended_remote_target::attach, remote_target::remote_stop_ns)
11130         (remote_target::remote_notif_remove_queued_reply)
11131         (remote_target::push_stop_reply, remote_target::disable_btrace):
11132         Update.
11133         (extended_remote_target::attach): Update.
11134         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11135         type.
11136         (gdbsim_target::pid_to_str): Change return type.
11137         * ravenscar-thread.c (struct ravenscar_thread_target)
11138         <pid_to_str>: Change return type.
11139         (ravenscar_thread_target::pid_to_str): Change return type.
11140         * procfs.c (class procfs_target) <pid_to_str>: Change return
11141         type.
11142         (procfs_target::pid_to_str): Change return type.
11143         (procfs_target::attach): Update.
11144         (procfs_target::detach): Update.
11145         (procfs_target::fetch_registers): Update.
11146         (procfs_target::store_registers): Update.
11147         (procfs_target::wait): Update.
11148         (procfs_target::files_info): Update.
11149         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11150         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11151         return type.
11152         (nto_procfs_target::pid_to_str): Change return type.
11153         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11154         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11155         return type.
11156         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11157         (exit_lwp): Update.
11158         (attach_proc_task_lwp_callback, get_detach_signal)
11159         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11160         (linux_nat_target::resume, wait_lwp, stop_callback)
11161         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11162         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11163         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11164         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11165         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11166         type.
11167         (inf_ptrace_target::attach): Update.
11168         (inf_ptrace_target::files_info): Update.
11169         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11170         type.
11171         (go32_nat_target::pid_to_str): Change return type.
11172         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11173         (gnu_nat_target::wait): Update.
11174         (gnu_nat_target::wait): Update.
11175         (gnu_nat_target::resume): Update.
11176         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11177         (fbsd_nat_target::wait): Update.
11178         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11179         type.
11180         (darwin_nat_target::attach): Update.
11181         * corelow.c (class core_target) <pid_to_str>: Change return type.
11182         (core_target::pid_to_str): Change return type.
11183         * target.c (normal_pid_to_str): Change return type.
11184         (default_pid_to_str): Likewise.
11185         (target_pid_to_str): Change return type.
11186         (target_translate_tls_address): Update.
11187         (target_announce_detach): Update.
11188         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11189         return type.
11190         (bsd_uthread_target::pid_to_str): Change return type.
11191         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11192         type.
11193         (bsd_kvm_target::pid_to_str): Change return type.
11194         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11195         return type.
11196         (aix_thread_target::pid_to_str): Change return type.
11197         * target.h (struct target_ops) <pid_to_str>: Change return type.
11198         (target_pid_to_str, normal_pid_to_str): Likewise.
11199         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11200         type.
11201         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11202         type.
11203         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11204         return type.
11205         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11206         type.
11207         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11208         type.
11209         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11210         return type.
11211
11212 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11213
11214         * NEWS: Mention that the new default MI version is 3.  Mention
11215         changes to the output of commands and events that deal with
11216         multi-location breakpoints.
11217         * breakpoint.c: Include "mi/mi-out.h".
11218         (print_one_breakpoint): Change output syntax if using MI version
11219         >= 3.
11220         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11221         New.
11222         (mi_multi_location_breakpoint_output_fixed): New.
11223         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11224         (mi_cmd_fix_multi_location_breakpoint_output): New.
11225         (mi_multi_location_breakpoint_output_fixed): New.
11226         * mi/mi-cmds.c (mi_cmds): Register command
11227         -fix-multi-location-breakpoint-output.
11228         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11229         interpreter "mi".
11230
11231 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11232
11233         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11234         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11235         instantiate mi_ui_out based on interpreter name.
11236         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11237         * mi/mi-main.c (mi_load_progress): Likewise.
11238
11239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11240
11241         * NEWS: Combine separate "New targets" sections for 8.3.
11242
11243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11244
11245         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11246         (ppcfbsd_init_abi): Install gdbarch
11247         "fetch_tls_load_module_address" and "get_thread_local_address"
11248         methods.
11249
11250 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11251
11252         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11253         (riscv_fbsd_init_abi): Install gdbarch
11254         "fetch_tls_load_module_address" and "get_thread_local_address"
11255         methods.
11256
11257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11258
11259         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11260         (i386fbsd_init_abi): Install gdbarch
11261         "fetch_tls_load_module_address" and "get_thread_local_address"
11262         methods.
11263
11264 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11265
11266         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11267         (amd64fbsd_init_abi): Install gdbarch
11268         "fetch_tls_load_module_address" and "get_thread_local_address"
11269         methods.
11270
11271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11272
11273         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11274         (struct fbsd_pspace_data): New type.
11275         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11276         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11277         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11278         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11279         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11280
11281 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11282
11283         * gdbtypes.c (lookup_struct_elt): New function.
11284         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11285         * gdbtypes.h (struct struct_elt): New type.
11286         (lookup_struct_elt): New prototype.
11287
11288 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11289
11290         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11291         remove disabled code block.
11292
11293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11294
11295         * gdbarch.sh (get_thread_local_address): New method.
11296         * gdbarch.h, gdbarch.c: Regenerate.
11297         * target.c (target_translate_tls_address): Use
11298         gdbarch_get_thread_local_address if present instead of
11299         target::get_thread_local_address.
11300
11301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11302
11303         * target.h (target::get_thread_local_address): Update comment.
11304
11305 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11306
11307         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11308         objfile->separate_debug_objfile_backlink if not NULL.
11309
11310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11311
11312         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11313         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11314         (amd64bsd_store_inferior_registers): Likewise.
11315         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11316         Enable segment base registers.
11317         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11318         PT_GETFSBASE and PT_GETGSBASE.
11319         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11320         PT_SETGSBASE.
11321         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11322         segment base registers.
11323         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11324
11325 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11326
11327         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11328         Update calls to i386_target_description to add 'segments'
11329         parameter.
11330         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11331         add segment base registers.
11332         * arch/i386.c (i386_create_target_description): Add 'segments'
11333         parameter to enable segment base registers.
11334         * arch/i386.h (i386_create_target_description): Likewise.
11335         * features/i386/32bit-segments.xml: New file.
11336         * features/i386/32bit-segments.c: Generate.
11337         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11338         call to i386_target_description to add 'segments' parameter.
11339         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11340         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11341         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11342         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11343         if feature is present.
11344         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11345         Add 'segments' parameter to call to i386_target_description.
11346         (i386_target_description): Add 'segments' parameter to enable
11347         segment base registers.
11348         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11349         to call to i386_target_description.
11350         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11351         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11352         Define I386_NUM_REGS.
11353         (i386_target_description): Add 'segments' parameter to enable
11354         segment base registers.
11355
11356 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11357
11358         PR/24325
11359         * source-cache.c: #undef open and close, to avoid unresolved
11360         externals during linking.
11361
11362 2019-03-12  Tom Tromey  <tromey@adacore.com>
11363
11364         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11365         const.  Add initializers.
11366         (_initialize_remote): Don't initialize ptid globals.
11367
11368 2019-03-12  Pedro Alves  <palves@redhat.com>
11369
11370         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11371
11372 2019-03-12  Pedro Alves  <palves@redhat.com>
11373
11374         * cp-name-parser.y (main): Remove unused 'len' variable.
11375
11376 2019-03-12  Tom Tromey  <tromey@adacore.com>
11377
11378         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11379         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11380
11381 2019-03-12  Tom Tromey  <tromey@adacore.com>
11382
11383         * linux-nat.c (iterate_over_lwps): Update.
11384         (stop_callback): Remove parameter.
11385         (stop_wait_callback, detach_callback, resume_set_callback)
11386         (select_singlestep_lwp_callback, set_ignore_sigint)
11387         (status_callback, resumed_callback, resume_clear_callback)
11388         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11389         data parameter.
11390         (linux_nat_target::detach, linux_nat_target::resume)
11391         (linux_stop_and_wait_all_lwps, select_event_lwp)
11392         (linux_nat_filter_event, linux_nat_wait_1)
11393         (linux_nat_target::kill, linux_nat_target::stop)
11394         (linux_nat_target::stop): Update.
11395         (linux_nat_resume_callback): Change type.
11396         (resume_stopped_resumed_lwps, count_events_callback)
11397         (select_event_lwp_callback): Likewise.
11398         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11399         * arm-linux-nat.c (struct update_registers_data): Remove.
11400         (update_registers_callback): Change type.
11401         (arm_linux_insert_hw_breakpoint1): Update.
11402         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11403         parameter.
11404         (x86_linux_dr_set_addr): Update.
11405         (x86_linux_dr_set_control): Update.
11406         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11407         (iterate_over_lwps): Use gdb::function_view.
11408         * nat/aarch64-linux-hw-point.c (struct
11409         aarch64_dr_update_callback_param): Remove.
11410         (debug_reg_change_callback): Change type.
11411         (aarch64_notify_debug_reg_change): Update.
11412         * s390-linux-nat.c (s390_refresh_per_info): Update.
11413
11414 2019-03-11  Tom Tromey  <tromey@adacore.com>
11415
11416         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11417         redundant assignment to "this_cu".
11418
11419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11420
11421         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11422
11423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11424
11425         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11426         from...
11427         (rank_one_type): ... this.
11428
11429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11430
11431         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11432         from...
11433         (rank_one_type): ... this.
11434
11435 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11436
11437         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11438         from...
11439         (rank_one_type): ... this.
11440
11441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11442
11443         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11444         from...
11445         (rank_one_type): ... this.
11446
11447 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11448
11449         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11450         from...
11451         (rank_one_type): ... this.
11452
11453 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11454
11455         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11456         from...
11457         (rank_one_type): ... this.
11458
11459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11460
11461         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11462         from...
11463         (rank_one_type): ... this.
11464
11465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11466
11467         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11468         from...
11469         (rank_one_type): ... this.
11470
11471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11472
11473         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11474         from...
11475         (rank_one_type): ... this.
11476
11477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11478
11479         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11480         from...
11481         (rank_one_type): ... this.
11482
11483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11484
11485         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11486         from...
11487         (rank_one_type): ... this.
11488
11489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11490
11491         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11492         from...
11493         (rank_one_type): ... this.
11494
11495 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11496
11497         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11498         inferior-events' shows the example events.
11499
11500 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11501
11502         Support styling on native MS-Windows console
11503
11504         PR/24315
11505         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11506         on MS-Windows if $TERM is not defined.
11507
11508         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11509
11510         * posix-hdep.c (gdb_console_fputs):
11511         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11512         functions.
11513         * ui-file.h (gdb_console_fputs): Add prototype.
11514
11515         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11516         back to fputs only if the former returns zero.
11517
11518 2019-03-07  Tom Tromey  <tom@tromey.com>
11519
11520         * symmisc.c (print_symbol_bcache_statistics): Update.
11521         (print_objfile_statistics): Update.
11522         * symfile.c (allocate_symtab): Update.
11523         * stabsread.c: Don't include bcache.h.
11524         * psymtab.h (struct psymbol_bcache): Don't declare.
11525         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11526         (psymbol_bcache_init, psymbol_bcache_free)
11527         (psymbol_bcache_get_bcache): Don't declare.
11528         * psymtab.c (struct psymbol_bcache): Remove.
11529         (psymtab_storage::psymtab_storage): Update.
11530         (psymtab_storage::~psymtab_storage): Update.
11531         (psymbol_bcache_init, psymbol_bcache_free)
11532         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11533         (add_psymbol_to_bcache): Update.
11534         (allocate_psymtab): Update.
11535         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11536         macro_cache>: No longer pointers.
11537         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11538         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11539         * macrotab.c (macro_bcache): Update.
11540         * macroexp.c: Don't include bcache.h.
11541         * gdbtypes.c (check_types_worklist): Update.
11542         (types_deeply_equal): Remove TRY/CATCH.  Update.
11543         * elfread.c (elf_symtab_read): Update.
11544         * dwarf2read.c: Don't include bcache.h.
11545         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11546         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11547         (print_bcache_statistics, bcache_memory_used): Don't declare.
11548         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11549         methods.  Rename all data members.
11550         * bcache.c (struct bcache): Move to bcache.h.
11551         (bcache::expand_hash_table): Rename from expand_hash_table.
11552         (bcache): Remove.
11553         (bcache::insert): Rename from bcache_full.
11554         (bcache::compare): Rename from bcache_compare.
11555         (bcache_xmalloc): Remove.
11556         (bcache::~bcache): Rename from bcache_xfree.
11557         (bcache::print_statistics): Rename from print_bcache_statistics.
11558         (bcache::memory_used): Rename from bcache_memory_used.
11559
11560 2019-03-07  Pedro Alves  <palves@redhat.com>
11561
11562         * infrun.c (normal_stop): Also check for
11563         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11564
11565 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11566
11567         * f-lang.c (value_from_host_double): Moved to...
11568         * value.c (value_from_host_double): ...here.
11569         * value.h (value_from_host_double): Declare.
11570         * guile/scm-math.c (vlscm_convert_typed_number): Use
11571         value_from_host_double.
11572         (vlscm_convert_number): Likewise.
11573         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11574         * python/py-value.c (convert_value_from_python): Likewise.
11575
11576 2019-03-06  Tom Tromey  <tom@tromey.com>
11577
11578         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11579
11580 2019-03-06  Tom Tromey  <tom@tromey.com>
11581
11582         * utils.h (free_current_contents): Don't declare.
11583         * utils.c (free_current_contents): Remove.
11584
11585 2019-03-06  Tom Tromey  <tom@tromey.com>
11586
11587         * top.c (quit_force): Update.
11588         * main.c (captured_command_loop): Update.
11589         * common/new-op.c (operator new): Update.
11590         * common/common-exceptions.c (struct catcher)
11591         <save_cleanup_chain>: Remove member.
11592         (exceptions_state_mc_init): Update.
11593         (exception_try_scope_entry): Return nullptr.
11594         (exception_try_scope_exit, exception_rethrow)
11595         (throw_exception_sjlj, throw_exception_cxx): Update.
11596         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11597         (all_cleanups, do_cleanups, discard_cleanups)
11598         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11599         (restore_cleanups, restore_final_cleanups): Don't declare.
11600         (do_final_cleanups): Remove parameter.
11601         * common/cleanups.c (cleanup_chain, make_cleanup)
11602         (make_cleanup_dtor, all_cleanups, do_cleanups)
11603         (discard_my_cleanups, discard_cleanups)
11604         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11605         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11606         (null_cleanup): Remove.
11607         (do_final_cleanups): Remove parameter.
11608
11609 2019-03-06  Tom Tromey  <tom@tromey.com>
11610
11611         * remote.c (remote_target::remote_parse_stop_reply): Use
11612         unique_xmalloc_ptr.
11613
11614 2019-03-06  Tom Tromey  <tom@tromey.com>
11615
11616         * stabsread.c (struct stabs_field_info): Rename from field_info.
11617         <list, fnlist>: Add initializers.
11618         <obstack>: New member.
11619         (read_member_functions, read_struct_fields, read_baseclasses):
11620         Allocate on obstack.  Don't use cleanups.
11621         (read_one_struct_field, read_member_functions, read_struct_fields)
11622         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11623         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11624         (read_struct_type): Update.
11625
11626 2019-03-06  Tom Tromey  <tom@tromey.com>
11627
11628         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11629         * common/filestuff.h (make_cleanup_close): Don't declare.
11630         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11631         Remove.
11632
11633 2019-03-06  Tom Tromey  <tom@tromey.com>
11634
11635         * solib-aix.c: Use make_scope_exit.
11636
11637 2019-03-06  Tom Tromey  <tom@tromey.com>
11638
11639         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11640         Use make_scope_exit.
11641
11642 2019-03-06  Tom Tromey  <tom@tromey.com>
11643
11644         * solib-svr4.c (disable_probes_interface): Remove parameter.
11645         (svr4_handle_solib_event): Use make_scope_exit.
11646
11647 2019-03-06  Tom Tromey  <tom@tromey.com>
11648
11649         * remote.c (struct stop_reply_deleter): Remove.
11650         (stop_reply_up): Update.
11651         (struct stop_reply): Derive from notif_event.  Don't typedef.
11652         <regcache>: Now a std::vector.
11653         (stop_reply_xfree): Remove.
11654         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11655         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11656         (remote_target::discard_pending_stop_replies): Use delete.
11657         (remote_target::remote_parse_stop_reply): Update.
11658         (remote_target::process_stop_reply): Update.
11659         * remote-notif.h (struct notif_event): Add virtual destructor.
11660         Remove "dtr" member.
11661         (struct notif_client) <alloc_event>: Return a unique_ptr.
11662         (notif_event_xfree): Don't declare.
11663         (notif_event_up): New typedef.
11664         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11665         (notif_event_xfree, do_notif_event_xfree): Remove.
11666         (remote_notif_state_xfree): Update.
11667
11668 2019-03-06  Tom Tromey  <tom@tromey.com>
11669
11670         * infrun.c (displaced_step_clear_cleanup): Now a
11671         forward_scope_exit type.
11672         (displaced_step_prepare_throw): Update.
11673         (displaced_step_fixup): Update.
11674
11675 2019-03-06  Tom Tromey  <tom@tromey.com>
11676
11677         * inferior.h (class inferior): Update comment.
11678         * gdbthread.h (class thread_info): Update comment.
11679
11680 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11681             Tom Tromey  <tom@tromey.com>
11682
11683         * stabsread.h (struct stab_section_list): Remove.
11684         (coffstab_build_psymtabs): Update.
11685         * dbxread.c (symbuf_sections): Now a std::vector.
11686         (sect_idx): New global.
11687         (fill_symbuf): Update.
11688         (coffstab_build_psymtabs): Change type of stabsects parameter.
11689         Update.
11690         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11691         std::vector.
11692         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11693         (coff_locate_sections): Update.
11694         (coff_symfile_read): Remove cleanups.  Update.
11695         (init_stringtab): Add storage parameter.
11696         (free_stringtab, free_stringtab_cleanup): Remove.
11697         (init_lineno): Add storage parameter.
11698         (free_linetab, free_linetab_cleanup): Remove.
11699
11700 2019-03-06  Pedro Alves  <palves@redhat.com>
11701
11702         * linux-fork.c (fork_info::clobber_regs): Delete.
11703         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11704         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11705         comment.  Adjust.
11706         (scoped_switch_fork_info::scoped_switch_fork_info)
11707         (checkpoint_command, linux_fork_context): Adjust
11708         fork_save_infrun_state calls.
11709
11710 2019-03-06  Pedro Alves  <palves@redhat.com>
11711
11712         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11713         (inf_has_multiple_threads): Return 'bool' and rewrite using
11714         inferior_info::threads().
11715
11716 2019-03-06  Pedro Alves  <palves@redhat.com>
11717
11718         * linux-fork.c: Include <list>.
11719         (fork_list): Now a std::list instance.
11720         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11721         (forks_exist_p, find_last_fork): Adjust.
11722         (new_fork): Delete.
11723         (one_fork_p): New.
11724         (add_fork): Adjust.
11725         (free_fork): Delete, folded into fork_info::~fork_info().
11726         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11727         Adjust.
11728         (init_fork_list): Delete.
11729         (linux_fork_killall, linux_fork_mourn_inferior)
11730         (linux_fork_detach, info_checkpoints_command): Adjust.
11731         (_initialize_linux_fork): No longer call init_fork_list.
11732
11733 2019-03-06  Pedro Alves  <palves@redhat.com>
11734
11735         * linux-fork.c (new_fork): New, split out of ...
11736         (add_fork): ... this.  Return void.  Move "first fork" special
11737         case from here, to ...
11738         (checkpoint_command): ... here.
11739         * linux-linux.h (add_fork): Return void.
11740
11741 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11742
11743         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11744
11745 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11746             Chris January  <chris.january@arm.com>
11747             David Lecomber  <david.lecomber@arm.com>
11748
11749         * f-exp.y: New token, UNOP_INTRINSIC.
11750         (exp): New pattern using UNOP_INTRINSIC token.
11751         (f77_keywords): Add 'abs' keyword.
11752         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11753         (value_from_host_double): New function.
11754         (evaluate_subexp_f): Support UNOP_ABS.
11755
11756 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11757
11758         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11759         types.
11760
11761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11762
11763         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11764         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11765         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11766
11767 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11768
11769         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11770
11771 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11772             Chris January  <chris.january@arm.com>
11773
11774         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11775         * f-exp.y: Define 'KIND' token.
11776         (exp): New pattern for KIND expressions.
11777         (ptype): Handle types with a kind extension.
11778         (direct_abs_decl): Extend to spot kind extensions.
11779         (f77_keywords): Add 'kind' to the list.
11780         (push_kind_type): New function.
11781         (convert_to_kind_type): New function.
11782         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11783         * parse.c (operator_length_standard): Likewise.
11784         * parser-defs.h (enum type_pieces): Add tp_kind.
11785         * std-operator.def: Add UNOP_KIND.
11786
11787 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11788
11789         * f-exp.y (f_parse): Set yydebug.
11790
11791 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11792
11793         * f-lang.c (evaluate_subexp_f): New function.
11794         (exp_descriptor_f): New global.
11795         (f_language_defn): Use exp_descriptor_f instead of
11796         exp_descriptor_standard.
11797
11798 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11799
11800         * f-exp.y (struct token): Add comments.
11801         (dot_ops): Remove uppercase versions and the end marker.
11802         (f77_keywords): Likewise.
11803         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11804         entries in the dot_ops array are case insensitive, and use
11805         strncasecmp to compare strings.  Also some whitespace cleanup in
11806         this area.  Similar for the f77_keywords array, except entries in
11807         this list might be case sensitive.
11808
11809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11810
11811         * f-exp.y (struct f77_boolean_val): Add comments.
11812         (boolean_values): Remove uppercase versions, and end marker.
11813         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11814         and use strncasecmp to achieve case insensitivity.  Additionally,
11815         perform whitespace cleanup around this code.
11816
11817 2019-03-06  Tom Tromey  <tromey@adacore.com>
11818
11819         * remote-sim.c (gdbsim_target_open): Use result of
11820         gdb_argv::release.
11821
11822 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11823         Dirk Schubert  <dirk.schubert@arm.com>
11824         Chris January  <chris.january@arm.com>
11825
11826         * eval.c (evaluate_subexp_standard): Call Fortran argument
11827         wrapping logic.
11828         * f-lang.c (struct value): A value which can be passed into a
11829         Fortran function call.
11830         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11831         where appropriate.
11832         (struct type): Value ready for a Fortran function call.
11833         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11834         is needed.
11835         * f-lang.h (fortran_argument_convert): Declaration.
11836         (fortran_preserve_arg_pointer): Declaration.
11837         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11838
11839 2019-03-05  Tom Tromey  <tromey@adacore.com>
11840
11841         * python/py-prettyprint.c (print_string_repr): Remove #if.
11842         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11843
11844 2019-03-05  Tom Tromey  <tromey@adacore.com>
11845
11846         * target.c (the_dummy_target): Move later.  Change type to
11847         "dummy_target".
11848         (initialize_targets): Don't initialize the_dummy_target.
11849
11850 2019-03-05  Tom Tromey  <tromey@adacore.com>
11851
11852         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11853         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11854
11855 2019-03-05  Tom Tromey  <tromey@adacore.com>
11856
11857         * windows-nat.c (windows_nat_target::attach)
11858         (windows_nat_target::detach): Don't call gdb_flush.
11859         * valprint.c (generic_val_print, val_print, val_print_string):
11860         Don't call gdb_flush.
11861         * utils.c (defaulted_query): Don't call gdb_flush.
11862         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11863         * target.c (target_announce_detach): Don't call gdb_flush.
11864         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11865         * remote.c (extended_remote_target::attach): Don't call
11866         gdb_flush.
11867         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11868         * printcmd.c (do_examine): Don't call gdb_flush.
11869         (info_display_command): Don't call gdb_flush.
11870         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11871         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11872         * memattr.c (info_mem_command): Don't call gdb_flush.
11873         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11874         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11875         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11876         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11877         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11878         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11879         (gnu_nat_target::detach): Don't call gdb_flush.
11880         * f-valprint.c (f_val_print): Don't call gdb_flush.
11881         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11882         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11883         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11884         gdb_flush.
11885         * c-valprint.c (c_val_print): Don't call gdb_flush.
11886         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11887
11888 2019-03-05  Tom Tromey  <tromey@adacore.com>
11889
11890         * varobj.c (update_dynamic_varobj_children): Update.
11891         (install_default_visualizer): Use reset, not release.
11892         * value.c (set_internalvar): Update.
11893         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11894         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11895         ATTRIBUTE_UNUSED_RESULT.
11896
11897 2019-03-05  Tom Tromey  <tromey@adacore.com>
11898
11899         * remote.c (class scoped_remote_fd) <release>: Add
11900         ATTRIBUTE_UNUSED_RESULT.
11901
11902 2019-03-05  Tom Tromey  <tromey@adacore.com>
11903
11904         * macroexp.c (struct macro_buffer) <release>: Add
11905         ATTRIBUTE_UNUSED_RESULT.
11906
11907 2019-03-05  Tom Tromey  <tromey@adacore.com>
11908
11909         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11910         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11911         ATTRIBUTE_UNUSED_RESULT.
11912
11913 2019-03-05  Tom Tromey  <tromey@adacore.com>
11914
11915         * common/scoped_fd.h (class scoped_fd) <release>: Add
11916         ATTRIBUTE_UNUSED_RESULT.
11917
11918 2019-03-05  Tom Tromey  <tromey@adacore.com>
11919
11920         * parser-defs.h (struct parser_state) <release>: Add
11921         ATTRIBUTE_UNUSED_RESULT.
11922
11923 2019-03-05  Tom Tromey  <tromey@adacore.com>
11924
11925         * utils.h (class gdb_argv) <release>: Add
11926         ATTRIBUTE_UNUSED_RESULT.
11927         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11928
11929 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11930
11931         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11932         for-loop range, to avoid compiler warnings.
11933
11934         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11935         avoid compiler warnings about unused variables.
11936
11937         * NEWS: Mention end of support for native debugging on MS-Windows
11938         before XP.
11939
11940         PR gdb/24292
11941         * common/netstuff.c:
11942         * gdbserver/gdbreplay.c
11943         * gdbserver/remote-utils.c:
11944         * ser-tcp.c:
11945         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11946         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11947         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11948         'getaddrinfo' and 'freeaddrinfo' were not available before
11949         Windows XP, and mingw.org's MinGW headers by default define
11950         _WIN32_WINNT to 0x500.
11951
11952 2019-03-01  Gary Benson <gbenson@redhat.com>
11953
11954         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11955
11956 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11957             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11958
11959         PR gdb/8527
11960         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11961         set_sigint_trap, clear_sigint_trap.
11962
11963 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11964
11965         * target.c (target_detach): Clear the regcache and the
11966         frame cache.
11967
11968 2019-02-27  Pedro Alves  <palves@redhat.com>
11969
11970         * utils.c (set_screen_size): When we cap the height/width sizes,
11971         tweak the corresponding command variable to show "unlimited":
11972
11973 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11974             Pedro Alves  <palves@redhat.com>
11975
11976         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11977         before calling rl_set_screen_size.
11978
11979 2019-02-27  Tom Tromey  <tromey@adacore.com>
11980
11981         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11982         define.
11983         * python/py-value.c: Remove Python 2.4 workaround.
11984         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11985         workaround.
11986         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11987         Python 2.4 workaround.
11988         * python/python-internal.h: Remove Python 2.4 comment.
11989         (Py_ssize_t): Don't define.
11990         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11991         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11992         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11993         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11994         * python/python.c (do_start_initialization): Remove Python 2.4
11995         workaround.
11996         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11997         (print_children): Remove Python 2.4 workaround.
11998         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11999         workaround.
12000         (CHARBUFFERPROC_NAME): Remove.
12001         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12002         Python 2.4 workaround.
12003
12004 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12005
12006         * NEWS: Note minimum Python version.
12007
12008 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12009
12010         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12011         code from these functions.  Remove corresponding ifdefs.  Use
12012         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12013         Remove gotos and target of gotos.
12014         (infpy_search_memory): Likewise.
12015
12016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12017
12018         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12019         (hppa_gdbarch_init): Don't register deleted functions with
12020         gdbarch.
12021
12022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12023
12024         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12025         (h8300_unwind_sp): Delete.
12026         (h8300_dummy_id): Delete.
12027         (h8300_gdbarch_init): Don't register deleted functions with
12028         gdbarch.
12029
12030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12031
12032         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12033         (ft32_unwind_pc): Delete.
12034         (ft32_unwind_sp): Delete.
12035         (ft32_gdbarch_init): Don't register deleted functions with
12036         gdbarch.
12037
12038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12039
12040         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12041         (frv_unwind_pc): Delete.
12042         (frv_unwind_sp): Delete.
12043         (frv_gdbarch_init): Don't register deleted functions with
12044         gdbarch.
12045
12046 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12047
12048         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12049         (riscv_unwind_pc): Delete.
12050         (riscv_unwind_sp): Delete.
12051         (riscv_gdbarch_init): Don't register deleted functions with
12052         gdbarch.
12053
12054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12055
12056         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12057         (csky_unwind_pc): Delete.
12058         (csky_unwind_sp): Delete.
12059         (csky_gdbarch_init): Don't register deleted functions with
12060         gdbarch.
12061
12062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12063
12064         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12065         (cris_unwind_pc): Delete.
12066         (cris_unwind_sp): Delete.
12067         (cris_gdbarch_init): Don't register deleted functions with
12068         gdbarch.
12069
12070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12071
12072         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12073         (bfin_unwind_pc): Delete.
12074         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12075
12076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12077
12078         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12079         (arm_unwind_pc): Delete.
12080         (arm_unwind_sp): Delete.
12081         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12082
12083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12084
12085         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12086         (arc_unwind_pc): Delete.
12087         (arc_unwind_sp): Delete.
12088         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12089
12090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12091
12092         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12093         (alpha_unwind_pc): Delete.
12094         (alpha_gdbarch_init): Don't register deleted functions with
12095         gdbarch.
12096
12097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12098
12099         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12100         (aarch64_unwind_pc): Delete.
12101         (aarch64_unwind_sp): Delete.
12102         (aarch64_gdbarch_init): Don't register deleted functions with
12103         gdbarch.
12104
12105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12106
12107         * gdbtypes.c (type_align): Don't consider static members when
12108         computing structure alignment.
12109
12110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12111
12112         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12113         return 0 for other types.
12114         * arch-utils.c (default_type_align): Always return 0.
12115         * gdbarch.h: Regenerate.
12116         * gdbarch.sh (type_align): Extend comment.
12117         * gdbtypes.c (type_align): Add additional comments, always call
12118         gdbarch_type_align before applying the default rules.
12119         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12120         generic code will then apply a suitable default.
12121         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12122         types, return 0 for other types.
12123
12124 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12125
12126         * NEWS: Create a new section for the next release branch.
12127         Rename the section of the current branch, now that it has
12128         been cut.
12129
12130 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12131
12132         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12133         * version.in: Bump version to 8.3.50.DATE-git.
12134
12135 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12136
12137         * aix-thread.c (ptid_cmp): Remove unused variable.
12138         (get_signaled_thread): Likewise.
12139         (store_regs_user_thread): Likewise.
12140         (store_regs_kernel_thread): Likewise.
12141         (fetch_regs_kernel_thread): Remove shadowed variable.
12142
12143 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12144
12145         * features/riscv/32bit-cpu.xml: Add register numbers.
12146         * features/riscv/32bit-fpu.c: Regenerate.
12147         * features/riscv/32bit-fpu.xml: Add register numbers.
12148         * features/riscv/64bit-cpu.xml: Add register numbers.
12149         * features/riscv/64bit-fpu.c: Regenerate.
12150         * features/riscv/64bit-fpu.xml: Add register numbers.
12151
12152 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12153
12154         * NEWS: Mention two argument form of gdb.Value constructor.
12155         * python/py-value.c (convert_buffer_and_type_to_value): New
12156         function.
12157         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12158         Add support for handling an optional second argument.  Call
12159         convert_buffer_and_type_to_value as appropriate.
12160         * python/python-internal.h (Py_buffer_deleter): New struct.
12161         (Py_buffer_up): New typedef.
12162
12163 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12164
12165         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12166         instead of releasing ownership.
12167
12168 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12169
12170         * dwarf2read.c (open_and_init_dwp_file): Call
12171         elf_numsections instead of bfd_count_sections to initialize
12172         dwp_file->num_sections.
12173
12174 2019-02-25  Tom Tromey  <tromey@adacore.com>
12175
12176         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12177
12178 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12179
12180         * gcore.in: Add '--readnever' option when invoking GDB.
12181
12182 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12183
12184         * MAINTAINERS: Update my email address.
12185
12186 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12187
12188         * build-id.c (build_id_to_debug_bfd_1): New function.
12189         (build_id_to_debug_bfd): Look for separate debug file in
12190         sysroot.
12191
12192 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12193
12194         * gdbarch.sh: Update the copyright year range that is placed into
12195         generated files.
12196
12197 2019-02-22  Keith Seitz  <keiths@redhat.com>
12198
12199         PR symtab/23853
12200         * linespec.c (create_sals_line_offset): Search for the default
12201         symtab's filename instead of its fullname.
12202
12203 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12204
12205         * NEWS: Update style defaults.
12206
12207 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12208
12209         * main.c (captured_main_1): Disable styling in batch mode.
12210
12211 2019-02-20  Tom Tromey  <tom@tromey.com>
12212
12213         * symtab.c (symtab_symbol_info): Fix typos.
12214
12215 2019-02-20  Tom Tromey  <tromey@adacore.com>
12216
12217         * findcmd.c (_initialize_mem_search): Use upper case for
12218         metasyntactic variables.
12219
12220 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12221
12222         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12223         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12224
12225 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12226
12227         * top.h (source_file_name): Change to std::string.
12228         * top.c (source_file_name): Likewise.
12229         (command_line_input): Adjust.
12230         * cli/cli-script.c (script_from_file): Adjust.
12231
12232 2019-02-19  Tom Tromey  <tromey@adacore.com>
12233
12234         * ravenscar-thread.c
12235         (ravenscar_thread_target::update_thread_list): Don't call
12236         ada_build_task_list.
12237         * ada-lang.h (ada_build_task_list): Don't declare.
12238         * ada-tasks.c (struct ada_tasks_inferior_data)
12239         <task_list_valid_p>: Now bool.
12240         (read_known_tasks, ada_task_list_changed)
12241         (ada_tasks_invalidate_inferior_data): Update.
12242         (read_known_tasks_array): Return bool.
12243         (read_known_tasks_list): Likewise.
12244         (read_known_tasks): Return void.
12245         (ada_build_task_list): Now static.
12246
12247 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12248
12249         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12250         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12251
12252 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12253
12254         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12255         variant for ada_tasks_pspace_data_handle and
12256         ada_tasks_inferior_data_handle.
12257         (ada_tasks_pspace_data_cleanup): New function.
12258         (ada_tasks_inferior_data_cleanup): New function.
12259
12260 2019-02-17  Tom Tromey  <tom@tromey.com>
12261
12262         * macrotab.h (macro_source_fullname): Return a std::string.
12263         * macrotab.c (macro_include, check_for_redefinition)
12264         (macro_undef, macro_lookup_definition, foreach_macro)
12265         (foreach_macro_in_scope): Update.
12266         (macro_source_fullname): Return a std::string.
12267         * macrocmd.c (show_pp_source_pos): Update.
12268
12269 2019-02-17  Tom Tromey  <tom@tromey.com>
12270
12271         * macrocmd.c (show_pp_source_pos): Style the file names.
12272
12273 2019-02-17  Tom Tromey  <tom@tromey.com>
12274
12275         PR tui/24197:
12276         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12277
12278 2019-02-17  Tom Tromey  <tom@tromey.com>
12279
12280         * ada-lang.c (user_select_syms): Use filtered printing.
12281         * utils.c (wrap_style): New global.
12282         (desired_style): Remove.
12283         (emit_style_escape): Add stream parameter.
12284         (set_output_style, reset_terminal_style, prompt_for_continue):
12285         Update.
12286         (flush_wrap_buffer): Only flush gdb_stdout.
12287         (wrap_here): Set wrap_style.
12288         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12289         treat escape sequences as a character.  Change when wrap buffer is
12290         flushed.
12291         (fputs_styled): Do not set the output style when the default is
12292         requested.
12293         * ui-style.h (struct ui_file_style) <is_default>: New method.
12294         * source.c (print_source_lines_base): Emit escape sequences in one
12295         piece.
12296
12297 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12298
12299         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12300         integers and enumeration types.
12301
12302 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12303
12304         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12305         instead of lookup_symbol_in_language
12306         (do_exact_match): New function.
12307         (ada_get_symbol_name_matcher): Return do_exact_match when
12308         doing a verbatim match.
12309
12310 2019-02-15  Tom Tromey  <tromey@adacore.com>
12311
12312         * ravenscar-thread.c (ravenscar_thread_target::resume)
12313         (ravenscar_thread_target::wait): Special case wildcard requests.
12314
12315 2019-02-15  Tom Tromey  <tromey@adacore.com>
12316
12317         * ravenscar-thread.c (base_ptid): Remove.
12318         (struct ravenscar_thread_target) <close>: New method.
12319         <m_base_ptid>: New member.
12320         <update_inferior_ptid, active_task, task_is_currently_active,
12321         runtime_initialized>: Declare methods.
12322         <ravenscar_thread_target>: Add constructor.
12323         (ravenscar_thread_target::task_is_currently_active)
12324         (ravenscar_thread_target::update_inferior_ptid)
12325         (ravenscar_runtime_initialized): Rename.  Now methods.
12326         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12327         (ravenscar_thread_target::update_thread_list): Update.
12328         (ravenscar_thread_target::active_task): Now method.
12329         (ravenscar_thread_target::store_registers)
12330         (ravenscar_thread_target::prepare_to_store)
12331         (ravenscar_thread_target::prepare_to_store)
12332         (ravenscar_thread_target::mourn_inferior): Update.
12333         (ravenscar_inferior_created): Use "new" to create target.
12334         (ravenscar_thread_target::get_ada_task_ptid): Update.
12335         (_initialize_ravenscar): Don't initialize base_ptid.
12336         (ravenscar_ops): Remove global.
12337
12338 2019-02-15  Tom Tromey  <tromey@adacore.com>
12339
12340         * target.h (push_target): Declare new overload.
12341         * target.c (push_target): New overload, taking an rvalue reference.
12342         * remote.c (remote_target::open_1): Use push_target overload.
12343         * corelow.c (core_target_open): Use push_target overload.
12344
12345 2019-02-15  Tom Tromey  <tromey@adacore.com>
12346
12347         * ravenscar-thread.c (is_ravenscar_task)
12348         (ravenscar_task_is_currently_active): Return bool.
12349         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12350         (_initialize_ravenscar): Remove "(void)".
12351         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12352         Return bool.
12353
12354 2019-02-15  Tom Tromey  <tromey@adacore.com>
12355
12356         * ravenscar-thread.c (ravenscar_runtime_initializer)
12357         (has_ravenscar_runtime, get_running_thread_id)
12358         (ravenscar_thread_target::resume): Fix indentation.
12359
12360 2019-02-15  Tom Tromey  <tromey@adacore.com>
12361
12362         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12363         from ravenscar_arch_ops.
12364         (sparc_ravenscar_ops::fetch_registers)
12365         (sparc_ravenscar_ops::store_registers): Now methods.
12366         (sparc_ravenscar_prepare_to_store): Remove.
12367         (sparc_ravenscar_ops): Redefine.
12368         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12369         methods and destructor.  Remove members.
12370         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12371         (ravenscar_thread_target::store_registers)
12372         (ravenscar_thread_target::prepare_to_store): Update.
12373         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12374         Remove.
12375         (struct ppc_ravenscar_powerpc_ops): Derive from
12376         ravenscar_arch_ops.
12377         (ppc_ravenscar_powerpc_ops::fetch_registers)
12378         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12379         (ppc_ravenscar_powerpc_ops): Redefine.
12380         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12381         (ppc_ravenscar_e500_ops::fetch_registers)
12382         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12383         (ppc_ravenscar_e500_ops): Redefine.
12384         * aarch64-ravenscar-thread.c
12385         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12386         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12387         (aarch64_ravenscar_fetch_registers)
12388         (aarch64_ravenscar_store_registers): Now methods.
12389         (aarch64_ravenscar_ops): Redefine.
12390
12391 2019-02-15  Tom Tromey  <tromey@adacore.com>
12392
12393         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12394         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12395         (ravenscar_thread_target::stopped_by_watchpoint)
12396         (ravenscar_thread_target::stopped_data_address)
12397         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12398
12399 2019-02-15  Tom Tromey  <tromey@adacore.com>
12400
12401         * ravenscar-thread.c: Fix some typos.
12402
12403 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12404             Tom Tromey  <tromey@adacore.com>
12405
12406         * ada-lang.c (ada_exception_sal): Change addr_string to a
12407         std::string.
12408         (create_ada_exception_catchpoint): Update.
12409
12410 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12411             Tom Tromey  <tromey@adacore.com>
12412
12413         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12414         (bp_location_ops): Remove.
12415         (base_breakpoint_allocate_location): Update.
12416         (free_bp_location): Update.
12417         * ada-lang.c (class ada_catchpoint_location)
12418         <ada_catchpoint_location>: Remove ops parameter.
12419         (ada_catchpoint_location_dtor): Remove.
12420         (ada_catchpoint_location_ops): Remove.
12421         (allocate_location_exception): Update.
12422         * breakpoint.h (struct bp_location_ops): Remove.
12423         (class bp_location) <bp_location>: Remove bp_location_ops
12424         parameter.
12425         <~bp_location>: Add destructor.
12426         <ops>: Remove.
12427
12428 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12429             Pedro Alves  <palves@redhat.com>
12430
12431         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12432         'PATH_MAX'.
12433
12434 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12435             Samuel Thibault  <samuel.thibault@gnu.org>
12436             Thomas Schwinge  <thomas@codesourcery.com>
12437
12438         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12439         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12440
12441 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12442
12443         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12444         (check_empty): Use "const char *".
12445
12446         * gnu-nat.c (gnu_nat_target::detach): Instead of
12447         'detach_inferior (pid)' call
12448         'detach_inferior (find_inferior_pid (pid))'.
12449
12450         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12451         'nat/fork-inferior.o'.
12452         * gnu-nat.c: #include "nat/fork-inferior.h".
12453
12454         * gnu-nat.c (gnu_nat_target::detach): Instead of
12455         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12456         * gnu-nat.h: #include "inf-child.h".
12457         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12458         'i386_gnu_nat_target::fetch_registers'.
12459         (gnu_store_registers): Rename/move to
12460         'i386_gnu_nat_target::store_registers'.
12461
12462         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12463         * gnu-nat.h (mach_thread_info): New function.
12464         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12465
12466         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12467
12468 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12469
12470         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12471
12472 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12473
12474         * windows-nat.c (windows_add_thread): Add new parameter
12475         "main_thread_p" with default value set to false.  Update
12476         function documentation as well as all callers.
12477         (windows_delete_thread): Likewise.
12478         (fake_create_process): Update call to windows_add_thread.
12479         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12480         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12481         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12482         call to windows_delete_thread.
12483
12484 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12485
12486         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12487
12488 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12489
12490         * symfile.c (find_separate_debug_file): Use canonical path of
12491         sysroot with child_path instead of gdb_sysroot if it is valid.
12492
12493 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12494
12495         * symfile.c (find_separate_debug_file): Use child_path to
12496         determine if an object file is under a sysroot.
12497
12498 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12499
12500         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12501         unittests/child-path-selftests.c.
12502         * common/pathstuff.c (child_path): New function.
12503         * common/pathstuff.h (child_path): New prototype.
12504         * unittests/child-path-selftests.c: New file.
12505
12506 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12507
12508         * symfile.c (find_separate_debug_file): Look for separate debug
12509         files in debug directories under the sysroot.
12510
12511 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12512
12513         * symtab.h (struct minimal_symbol data_p): New const method.
12514         (struct minimal_symbol text_p): Likewise.
12515         * symtab.c (output_source_filename): Use file name style
12516         to print file name.
12517         (print_symbol_info): Likewise.
12518         (print_msymbol_info): Use address style to print addresses.
12519         Use function name style to print executable text symbols.
12520         (expand_symtab_containing_pc): Use data_p.
12521         (find_pc_sect_compunit_symtab): Likewise.
12522
12523 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12524
12525         * breakpoint.c (describe_other_breakpoints): Use address style
12526         to print addresses.
12527         (say_where): Likewise.
12528
12529 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12530
12531         * ada-typeprint.c (print_func_type): Print function name
12532         style to print function name.
12533         * c-typeprint.c (c_print_type_1): Likewise.
12534
12535 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12536
12537         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12538         for execve.
12539
12540 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12541
12542         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12543         type_stack.
12544
12545 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12546
12547         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12548         TYPE_CODE_REF types.
12549
12550 2019-02-08  Jim Wilson  <jimw@sifive.com>
12551
12552         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12553         (riscv_linux_fregset): New.
12554         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12555
12556 2019-02-07  Tom Tromey  <tom@tromey.com>
12557
12558         * thread.c (thread_cancel_execution_command): Update.
12559         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12560         methods.
12561         (struct thread_fsm_ops): Remove.
12562         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12563         (thread_fsm_should_stop, thread_fsm_return_value)
12564         (thread_fsm_set_finished, thread_fsm_finished_p)
12565         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12566         Don't declare.
12567         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12568         * infrun.c (clear_proceed_status_thread)
12569         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12570         (print_stop_event): Update.
12571         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12572         Add constructor.
12573         (step_command_fsm_ops): Remove.
12574         (new_step_command_fsm): Remove.
12575         (step_1): Update.
12576         (step_command_fsm::should_stop): Rename from
12577         step_command_fsm_should_stop.
12578         (step_command_fsm::clean_up): Rename from
12579         step_command_fsm_clean_up.
12580         (step_command_fsm::do_async_reply_reason): Rename from
12581         step_command_fsm_async_reply_reason.
12582         (struct until_next_fsm): Inherit from thread_fsm.  Add
12583         constructor.
12584         (until_next_fsm_ops): Remove.
12585         (new_until_next_fsm): Remove.
12586         (until_next_fsm::should_stop): Rename from
12587         until_next_fsm_should_stop.
12588         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12589         (until_next_fsm::do_async_reply_reason): Rename from
12590         until_next_fsm_async_reply_reason.
12591         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12592         constructor.  Change type of breakpoint.
12593         (finish_command_fsm_ops): Remove.
12594         (new_finish_command_fsm): Remove.
12595         (finish_command_fsm::should_stop): Rename from
12596         finish_command_fsm_should_stop.
12597         (finish_command_fsm::clean_up): Rename from
12598         finish_command_fsm_clean_up.
12599         (finish_command_fsm::return_value): Rename from
12600         finish_command_fsm_return_value.
12601         (finish_command_fsm::do_async_reply_reason): Rename from
12602         finish_command_fsm_async_reply_reason.
12603         (finish_command): Update.
12604         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12605         Add constructor.
12606         (call_thread_fsm_ops): Remove.
12607         (call_thread_fsm::call_thread_fsm): Rename from
12608         new_call_thread_fsm.
12609         (call_thread_fsm::should_stop): Rename from
12610         call_thread_fsm_should_stop.
12611         (call_thread_fsm::should_notify_stop): Rename from
12612         call_thread_fsm_should_notify_stop.
12613         (run_inferior_call, call_function_by_hand_dummy): Update.
12614         * cli/cli-interp.c (should_print_stop_to_console): Update.
12615         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12616         Add constructor.  Change type of location_breakpoint,
12617         caller_breakpoint.
12618         (until_break_fsm_ops): Remove.
12619         (new_until_break_fsm): Remove.
12620         (until_break_fsm::should_stop): Rename from
12621         until_break_fsm_should_stop.
12622         (until_break_fsm::clean_up): Rename from
12623         until_break_fsm_clean_up.
12624         (until_break_fsm::do_async_reply_reason): Rename from
12625         until_break_fsm_async_reply_reason.
12626         (until_break_command): Update.
12627         * thread-fsm.c: Remove.
12628         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12629
12630 2019-02-07  Tom Tromey  <tom@tromey.com>
12631
12632         * yy-remap.h: Add include guard.
12633         * xtensa-tdep.h: Add include guard.
12634         * xcoffread.h: Rename include guard.
12635         * varobj-iter.h: Add include guard.
12636         * tui/tui.h: Rename include guard.
12637         * tui/tui-winsource.h: Rename include guard.
12638         * tui/tui-wingeneral.h: Rename include guard.
12639         * tui/tui-windata.h: Rename include guard.
12640         * tui/tui-win.h: Rename include guard.
12641         * tui/tui-stack.h: Rename include guard.
12642         * tui/tui-source.h: Rename include guard.
12643         * tui/tui-regs.h: Rename include guard.
12644         * tui/tui-out.h: Rename include guard.
12645         * tui/tui-layout.h: Rename include guard.
12646         * tui/tui-io.h: Rename include guard.
12647         * tui/tui-hooks.h: Rename include guard.
12648         * tui/tui-file.h: Rename include guard.
12649         * tui/tui-disasm.h: Rename include guard.
12650         * tui/tui-data.h: Rename include guard.
12651         * tui/tui-command.h: Rename include guard.
12652         * tic6x-tdep.h: Add include guard.
12653         * target/waitstatus.h: Rename include guard.
12654         * target/wait.h: Rename include guard.
12655         * target/target.h: Rename include guard.
12656         * target/resume.h: Rename include guard.
12657         * target-float.h: Rename include guard.
12658         * stabsread.h: Add include guard.
12659         * rs6000-tdep.h: Add include guard.
12660         * riscv-fbsd-tdep.h: Add include guard.
12661         * regformats/regdef.h: Rename include guard.
12662         * record.h: Rename include guard.
12663         * python/python.h: Rename include guard.
12664         * python/python-internal.h: Rename include guard.
12665         * python/py-stopevent.h: Rename include guard.
12666         * python/py-ref.h: Rename include guard.
12667         * python/py-record.h: Rename include guard.
12668         * python/py-record-full.h: Rename include guard.
12669         * python/py-record-btrace.h: Rename include guard.
12670         * python/py-instruction.h: Rename include guard.
12671         * python/py-events.h: Rename include guard.
12672         * python/py-event.h: Rename include guard.
12673         * procfs.h: Add include guard.
12674         * proc-utils.h: Add include guard.
12675         * p-lang.h: Add include guard.
12676         * or1k-tdep.h: Rename include guard.
12677         * observable.h: Rename include guard.
12678         * nto-tdep.h: Rename include guard.
12679         * nat/x86-linux.h: Rename include guard.
12680         * nat/x86-linux-dregs.h: Rename include guard.
12681         * nat/x86-gcc-cpuid.h: Add include guard.
12682         * nat/x86-dregs.h: Rename include guard.
12683         * nat/x86-cpuid.h: Rename include guard.
12684         * nat/ppc-linux.h: Rename include guard.
12685         * nat/mips-linux-watch.h: Rename include guard.
12686         * nat/linux-waitpid.h: Rename include guard.
12687         * nat/linux-ptrace.h: Rename include guard.
12688         * nat/linux-procfs.h: Rename include guard.
12689         * nat/linux-osdata.h: Rename include guard.
12690         * nat/linux-nat.h: Rename include guard.
12691         * nat/linux-namespaces.h: Rename include guard.
12692         * nat/linux-btrace.h: Rename include guard.
12693         * nat/glibc_thread_db.h: Rename include guard.
12694         * nat/gdb_thread_db.h: Rename include guard.
12695         * nat/gdb_ptrace.h: Rename include guard.
12696         * nat/fork-inferior.h: Rename include guard.
12697         * nat/amd64-linux-siginfo.h: Rename include guard.
12698         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12699         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12700         * nat/aarch64-linux.h: Rename include guard.
12701         * nat/aarch64-linux-hw-point.h: Rename include guard.
12702         * mn10300-tdep.h: Add include guard.
12703         * mips-linux-tdep.h: Add include guard.
12704         * mi/mi-parse.h: Rename include guard.
12705         * mi/mi-out.h: Rename include guard.
12706         * mi/mi-main.h: Rename include guard.
12707         * mi/mi-interp.h: Rename include guard.
12708         * mi/mi-getopt.h: Rename include guard.
12709         * mi/mi-console.h: Rename include guard.
12710         * mi/mi-common.h: Rename include guard.
12711         * mi/mi-cmds.h: Rename include guard.
12712         * mi/mi-cmd-break.h: Rename include guard.
12713         * m2-lang.h: Add include guard.
12714         * location.h: Rename include guard.
12715         * linux-record.h: Rename include guard.
12716         * linux-nat.h: Add include guard.
12717         * linux-fork.h: Add include guard.
12718         * i386-darwin-tdep.h: Rename include guard.
12719         * hppa-linux-offsets.h: Add include guard.
12720         * guile/guile.h: Rename include guard.
12721         * guile/guile-internal.h: Rename include guard.
12722         * gnu-nat.h: Rename include guard.
12723         * gdb-stabs.h: Rename include guard.
12724         * frv-tdep.h: Add include guard.
12725         * f-lang.h: Add include guard.
12726         * event-loop.h: Add include guard.
12727         * darwin-nat.h: Rename include guard.
12728         * cp-abi.h: Rename include guard.
12729         * config/sparc/nm-sol2.h: Rename include guard.
12730         * config/nm-nto.h: Rename include guard.
12731         * config/nm-linux.h: Add include guard.
12732         * config/i386/nm-i386gnu.h: Rename include guard.
12733         * config/djgpp/nl_types.h: Rename include guard.
12734         * config/djgpp/langinfo.h: Rename include guard.
12735         * compile/gcc-cp-plugin.h: Add include guard.
12736         * compile/gcc-c-plugin.h: Add include guard.
12737         * compile/compile.h: Rename include guard.
12738         * compile/compile-object-run.h: Rename include guard.
12739         * compile/compile-object-load.h: Rename include guard.
12740         * compile/compile-internal.h: Rename include guard.
12741         * compile/compile-cplus.h: Rename include guard.
12742         * compile/compile-c.h: Rename include guard.
12743         * common/xml-utils.h: Rename include guard.
12744         * common/x86-xstate.h: Rename include guard.
12745         * common/version.h: Rename include guard.
12746         * common/vec.h: Rename include guard.
12747         * common/tdesc.h: Rename include guard.
12748         * common/selftest.h: Rename include guard.
12749         * common/scoped_restore.h: Rename include guard.
12750         * common/scoped_mmap.h: Rename include guard.
12751         * common/scoped_fd.h: Rename include guard.
12752         * common/safe-iterator.h: Rename include guard.
12753         * common/run-time-clock.h: Rename include guard.
12754         * common/refcounted-object.h: Rename include guard.
12755         * common/queue.h: Rename include guard.
12756         * common/ptid.h: Rename include guard.
12757         * common/print-utils.h: Rename include guard.
12758         * common/preprocessor.h: Rename include guard.
12759         * common/pathstuff.h: Rename include guard.
12760         * common/observable.h: Rename include guard.
12761         * common/netstuff.h: Rename include guard.
12762         * common/job-control.h: Rename include guard.
12763         * common/host-defs.h: Rename include guard.
12764         * common/gdb_wait.h: Rename include guard.
12765         * common/gdb_vecs.h: Rename include guard.
12766         * common/gdb_unlinker.h: Rename include guard.
12767         * common/gdb_unique_ptr.h: Rename include guard.
12768         * common/gdb_tilde_expand.h: Rename include guard.
12769         * common/gdb_sys_time.h: Rename include guard.
12770         * common/gdb_string_view.h: Rename include guard.
12771         * common/gdb_splay_tree.h: Rename include guard.
12772         * common/gdb_setjmp.h: Rename include guard.
12773         * common/gdb_ref_ptr.h: Rename include guard.
12774         * common/gdb_optional.h: Rename include guard.
12775         * common/gdb_locale.h: Rename include guard.
12776         * common/gdb_assert.h: Rename include guard.
12777         * common/filtered-iterator.h: Rename include guard.
12778         * common/filestuff.h: Rename include guard.
12779         * common/fileio.h: Rename include guard.
12780         * common/environ.h: Rename include guard.
12781         * common/common-utils.h: Rename include guard.
12782         * common/common-types.h: Rename include guard.
12783         * common/common-regcache.h: Rename include guard.
12784         * common/common-inferior.h: Rename include guard.
12785         * common/common-gdbthread.h: Rename include guard.
12786         * common/common-exceptions.h: Rename include guard.
12787         * common/common-defs.h: Rename include guard.
12788         * common/common-debug.h: Rename include guard.
12789         * common/cleanups.h: Rename include guard.
12790         * common/buffer.h: Rename include guard.
12791         * common/btrace-common.h: Rename include guard.
12792         * common/break-common.h: Rename include guard.
12793         * cli/cli-utils.h: Rename include guard.
12794         * cli/cli-style.h: Rename include guard.
12795         * cli/cli-setshow.h: Rename include guard.
12796         * cli/cli-script.h: Rename include guard.
12797         * cli/cli-interp.h: Rename include guard.
12798         * cli/cli-decode.h: Rename include guard.
12799         * cli/cli-cmds.h: Rename include guard.
12800         * charset-list.h: Add include guard.
12801         * buildsym-legacy.h: Rename include guard.
12802         * bfin-tdep.h: Add include guard.
12803         * ax.h: Rename include guard.
12804         * arm-linux-tdep.h: Add include guard.
12805         * arm-fbsd-tdep.h: Add include guard.
12806         * arch/xtensa.h: Rename include guard.
12807         * arch/tic6x.h: Add include guard.
12808         * arch/i386.h: Add include guard.
12809         * arch/arm.h: Rename include guard.
12810         * arch/arm-linux.h: Rename include guard.
12811         * arch/arm-get-next-pcs.h: Rename include guard.
12812         * arch/amd64.h: Add include guard.
12813         * arch/aarch64-insn.h: Rename include guard.
12814         * arch-utils.h: Rename include guard.
12815         * annotate.h: Add include guard.
12816         * amd64-darwin-tdep.h: Rename include guard.
12817         * aarch64-linux-tdep.h: Add include guard.
12818         * aarch64-fbsd-tdep.h: Add include guard.
12819         * aarch32-linux-nat.h: Add include guard.
12820
12821 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12822
12823         * macrotab.c (macro_define_internal): New function that
12824         factorizes macro_define_object_internal and macro_define_function
12825         code.
12826         (macro_define_object_internal): Use macro_define_internal.
12827         (macro_define_function): Likewise.
12828
12829 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12830
12831         * macrocmd.c (extract_identifier): Return
12832         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12833         callers.
12834
12835 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12836
12837         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12838
12839 2019-02-05  Tom Tromey  <tom@tromey.com>
12840
12841         * target.c (target_stack::unpush): Move assertion earlier.
12842
12843 2019-01-30  Tom Tromey  <tom@tromey.com>
12844
12845         PR python/23615:
12846         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12847         (gdbpy_parse_and_eval): Likewise.
12848         * python/python-internal.h (gdbpy_allow_threads): New class.
12849
12850 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12851
12852         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12853         (aarch64_fbsd_fpregmap): Move earlier.
12854         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12855         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12856         instead of individual calls to trad_frame_set_reg_addr.
12857         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12858         earlier.
12859         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12860         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12861         instead of individual calls to trad_frame_set_reg_addr.
12862
12863 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12864
12865         * CONTRIBUTE: Replace contribution list with wiki link.
12866
12867 2019-01-25  Tom Tromey  <tom@tromey.com>
12868
12869         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12870
12871 2019-01-25  Tom Tromey  <tom@tromey.com>
12872
12873         * xtensa-linux-nat.c: Fix common/ includes.
12874         * xml-support.h: Fix common/ includes.
12875         * xml-support.c: Fix common/ includes.
12876         * x86-linux-nat.c: Fix common/ includes.
12877         * windows-nat.c: Fix common/ includes.
12878         * varobj.h: Fix common/ includes.
12879         * varobj.c: Fix common/ includes.
12880         * value.c: Fix common/ includes.
12881         * valops.c: Fix common/ includes.
12882         * utils.c: Fix common/ includes.
12883         * unittests/xml-utils-selftests.c: Fix common/ includes.
12884         * unittests/utils-selftests.c: Fix common/ includes.
12885         * unittests/unpack-selftests.c: Fix common/ includes.
12886         * unittests/tracepoint-selftests.c: Fix common/ includes.
12887         * unittests/style-selftests.c: Fix common/ includes.
12888         * unittests/string_view-selftests.c: Fix common/ includes.
12889         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12890         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12891         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12892         * unittests/rsp-low-selftests.c: Fix common/ includes.
12893         * unittests/parse-connection-spec-selftests.c: Fix common/
12894         includes.
12895         * unittests/optional-selftests.c: Fix common/ includes.
12896         * unittests/offset-type-selftests.c: Fix common/ includes.
12897         * unittests/observable-selftests.c: Fix common/ includes.
12898         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12899         * unittests/memrange-selftests.c: Fix common/ includes.
12900         * unittests/memory-map-selftests.c: Fix common/ includes.
12901         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12902         * unittests/function-view-selftests.c: Fix common/ includes.
12903         * unittests/environ-selftests.c: Fix common/ includes.
12904         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12905         * unittests/common-utils-selftests.c: Fix common/ includes.
12906         * unittests/cli-utils-selftests.c: Fix common/ includes.
12907         * unittests/array-view-selftests.c: Fix common/ includes.
12908         * ui-file.c: Fix common/ includes.
12909         * tui/tui-io.c: Fix common/ includes.
12910         * tracepoint.h: Fix common/ includes.
12911         * tracepoint.c: Fix common/ includes.
12912         * tracefile-tfile.c: Fix common/ includes.
12913         * top.h: Fix common/ includes.
12914         * top.c: Fix common/ includes.
12915         * thread.c: Fix common/ includes.
12916         * target/waitstatus.h: Fix common/ includes.
12917         * target/waitstatus.c: Fix common/ includes.
12918         * target.h: Fix common/ includes.
12919         * target.c: Fix common/ includes.
12920         * target-memory.c: Fix common/ includes.
12921         * target-descriptions.c: Fix common/ includes.
12922         * symtab.h: Fix common/ includes.
12923         * symfile.c: Fix common/ includes.
12924         * stap-probe.c: Fix common/ includes.
12925         * spu-linux-nat.c: Fix common/ includes.
12926         * sparc-nat.c: Fix common/ includes.
12927         * source.c: Fix common/ includes.
12928         * solib.c: Fix common/ includes.
12929         * solib-target.c: Fix common/ includes.
12930         * ser-unix.c: Fix common/ includes.
12931         * ser-tcp.c: Fix common/ includes.
12932         * ser-pipe.c: Fix common/ includes.
12933         * ser-base.c: Fix common/ includes.
12934         * selftest-arch.c: Fix common/ includes.
12935         * s12z-tdep.c: Fix common/ includes.
12936         * rust-exp.y: Fix common/ includes.
12937         * rs6000-aix-tdep.c: Fix common/ includes.
12938         * riscv-tdep.c: Fix common/ includes.
12939         * remote.c: Fix common/ includes.
12940         * remote-notif.h: Fix common/ includes.
12941         * remote-fileio.h: Fix common/ includes.
12942         * remote-fileio.c: Fix common/ includes.
12943         * regcache.h: Fix common/ includes.
12944         * regcache.c: Fix common/ includes.
12945         * record-btrace.c: Fix common/ includes.
12946         * python/python.c: Fix common/ includes.
12947         * python/py-type.c: Fix common/ includes.
12948         * python/py-inferior.c: Fix common/ includes.
12949         * progspace.h: Fix common/ includes.
12950         * producer.c: Fix common/ includes.
12951         * procfs.c: Fix common/ includes.
12952         * proc-api.c: Fix common/ includes.
12953         * printcmd.c: Fix common/ includes.
12954         * ppc-linux-nat.c: Fix common/ includes.
12955         * parser-defs.h: Fix common/ includes.
12956         * osdata.c: Fix common/ includes.
12957         * obsd-nat.c: Fix common/ includes.
12958         * nat/x86-linux.c: Fix common/ includes.
12959         * nat/x86-linux-dregs.c: Fix common/ includes.
12960         * nat/x86-dregs.h: Fix common/ includes.
12961         * nat/x86-dregs.c: Fix common/ includes.
12962         * nat/ppc-linux.c: Fix common/ includes.
12963         * nat/mips-linux-watch.h: Fix common/ includes.
12964         * nat/mips-linux-watch.c: Fix common/ includes.
12965         * nat/linux-waitpid.c: Fix common/ includes.
12966         * nat/linux-ptrace.h: Fix common/ includes.
12967         * nat/linux-ptrace.c: Fix common/ includes.
12968         * nat/linux-procfs.c: Fix common/ includes.
12969         * nat/linux-personality.c: Fix common/ includes.
12970         * nat/linux-osdata.c: Fix common/ includes.
12971         * nat/linux-namespaces.c: Fix common/ includes.
12972         * nat/linux-btrace.h: Fix common/ includes.
12973         * nat/linux-btrace.c: Fix common/ includes.
12974         * nat/fork-inferior.c: Fix common/ includes.
12975         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12976         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12977         * nat/aarch64-linux.c: Fix common/ includes.
12978         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12979         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12980         * namespace.h: Fix common/ includes.
12981         * mips-linux-tdep.c: Fix common/ includes.
12982         * minsyms.c: Fix common/ includes.
12983         * mi/mi-parse.h: Fix common/ includes.
12984         * mi/mi-main.c: Fix common/ includes.
12985         * mi/mi-cmd-env.c: Fix common/ includes.
12986         * memrange.h: Fix common/ includes.
12987         * memattr.c: Fix common/ includes.
12988         * maint.h: Fix common/ includes.
12989         * maint.c: Fix common/ includes.
12990         * main.c: Fix common/ includes.
12991         * machoread.c: Fix common/ includes.
12992         * location.c: Fix common/ includes.
12993         * linux-thread-db.c: Fix common/ includes.
12994         * linux-nat.c: Fix common/ includes.
12995         * linux-fork.c: Fix common/ includes.
12996         * inline-frame.c: Fix common/ includes.
12997         * infrun.c: Fix common/ includes.
12998         * inflow.c: Fix common/ includes.
12999         * inferior.h: Fix common/ includes.
13000         * inferior.c: Fix common/ includes.
13001         * infcmd.c: Fix common/ includes.
13002         * inf-ptrace.c: Fix common/ includes.
13003         * inf-child.c: Fix common/ includes.
13004         * ia64-linux-nat.c: Fix common/ includes.
13005         * i387-tdep.c: Fix common/ includes.
13006         * i386-tdep.c: Fix common/ includes.
13007         * i386-linux-tdep.c: Fix common/ includes.
13008         * i386-linux-nat.c: Fix common/ includes.
13009         * i386-go32-tdep.c: Fix common/ includes.
13010         * i386-fbsd-tdep.c: Fix common/ includes.
13011         * i386-fbsd-nat.c: Fix common/ includes.
13012         * guile/scm-type.c: Fix common/ includes.
13013         * guile/guile.c: Fix common/ includes.
13014         * go32-nat.c: Fix common/ includes.
13015         * gnu-nat.c: Fix common/ includes.
13016         * gdbthread.h: Fix common/ includes.
13017         * gdbarch-selftests.c: Fix common/ includes.
13018         * gdb_usleep.c: Fix common/ includes.
13019         * gdb_select.h: Fix common/ includes.
13020         * gdb_bfd.c: Fix common/ includes.
13021         * gcore.c: Fix common/ includes.
13022         * fork-child.c: Fix common/ includes.
13023         * findvar.c: Fix common/ includes.
13024         * fbsd-nat.c: Fix common/ includes.
13025         * event-top.c: Fix common/ includes.
13026         * event-loop.c: Fix common/ includes.
13027         * dwarf2read.c: Fix common/ includes.
13028         * dwarf2loc.c: Fix common/ includes.
13029         * dwarf2-frame.c: Fix common/ includes.
13030         * dwarf-index-cache.c: Fix common/ includes.
13031         * dtrace-probe.c: Fix common/ includes.
13032         * disasm-selftests.c: Fix common/ includes.
13033         * defs.h: Fix common/ includes.
13034         * csky-tdep.c: Fix common/ includes.
13035         * cp-valprint.c: Fix common/ includes.
13036         * cp-support.h: Fix common/ includes.
13037         * cp-support.c: Fix common/ includes.
13038         * corelow.c: Fix common/ includes.
13039         * completer.h: Fix common/ includes.
13040         * completer.c: Fix common/ includes.
13041         * compile/compile.c: Fix common/ includes.
13042         * compile/compile-loc2c.c: Fix common/ includes.
13043         * compile/compile-cplus-types.c: Fix common/ includes.
13044         * compile/compile-cplus-symbols.c: Fix common/ includes.
13045         * command.h: Fix common/ includes.
13046         * cli/cli-dump.c: Fix common/ includes.
13047         * cli/cli-cmds.c: Fix common/ includes.
13048         * charset.c: Fix common/ includes.
13049         * build-id.c: Fix common/ includes.
13050         * btrace.h: Fix common/ includes.
13051         * btrace.c: Fix common/ includes.
13052         * breakpoint.h: Fix common/ includes.
13053         * breakpoint.c: Fix common/ includes.
13054         * ax.h:
13055         (enum agent_op): Fix common/ includes.
13056         * ax-general.c (struct aop_map): Fix common/ includes.
13057         * ax-gdb.c: Fix common/ includes.
13058         * auxv.c: Fix common/ includes.
13059         * auto-load.c: Fix common/ includes.
13060         * arm-tdep.c: Fix common/ includes.
13061         * arch/riscv.c: Fix common/ includes.
13062         * arch/ppc-linux-common.c: Fix common/ includes.
13063         * arch/i386.c: Fix common/ includes.
13064         * arch/arm.c: Fix common/ includes.
13065         * arch/arm-linux.c: Fix common/ includes.
13066         * arch/arm-get-next-pcs.c: Fix common/ includes.
13067         * arch/amd64.c: Fix common/ includes.
13068         * arch/aarch64.c: Fix common/ includes.
13069         * arch/aarch64-insn.c: Fix common/ includes.
13070         * arch-utils.c: Fix common/ includes.
13071         * amd64-windows-tdep.c: Fix common/ includes.
13072         * amd64-tdep.c: Fix common/ includes.
13073         * amd64-sol2-tdep.c: Fix common/ includes.
13074         * amd64-obsd-tdep.c: Fix common/ includes.
13075         * amd64-nbsd-tdep.c: Fix common/ includes.
13076         * amd64-linux-tdep.c: Fix common/ includes.
13077         * amd64-linux-nat.c: Fix common/ includes.
13078         * amd64-fbsd-tdep.c: Fix common/ includes.
13079         * amd64-fbsd-nat.c: Fix common/ includes.
13080         * amd64-dicos-tdep.c: Fix common/ includes.
13081         * amd64-darwin-tdep.c: Fix common/ includes.
13082         * agent.c: Fix common/ includes.
13083         * ada-lang.h: Fix common/ includes.
13084         * ada-lang.c: Fix common/ includes.
13085         * aarch64-tdep.c: Fix common/ includes.
13086
13087 2019-01-25  Tom Tromey  <tom@tromey.com>
13088
13089         * common/create-version.sh: Use common/version.h.
13090
13091 2019-01-24  Pedro Alves  <palves@redhat.com>
13092
13093         * infrun.c (signal_stop, signal_print, signal_program)
13094         (signal_catch, signal_pass): Now arrays instead of pointers.
13095         (update_signals_program_target, do_target_resume)
13096         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13097         * linux-nat.c (linux_nat_target::pass_signals)
13098         (linux_nat_target::create_inferior, linux_nat_target::attach):
13099         Adjust.
13100         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13101         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13102         * procfs.c (procfs_target::pass_signals): Adjust.
13103         * record-full.c (record_full_target::resume): Adjust.
13104         * remote.c (remote_target::pass_signals)
13105         (remote_target::program_signals): Adjust.
13106         * target-debug.h (target_debug_print_signals): Now takes a
13107         gdb::array_view as parameter.  Adjust.
13108         * target.h (target_ops) <pass_signals, program_signals>: Replace
13109         pointer and length parameters with gdb::array_view.
13110         (target_pass_signals, target_program_signals): Likewise.
13111         * target-delegates.c: Regenerate.
13112
13113 2019-01-24  Pedro Alves  <palves@redhat.com>
13114
13115         * common/forward-scope-exit.h
13116         (forward_scope_exit::forward_scope_exit): Pass arguments to
13117         m_bind_function directly, instead of creating a std::bind and
13118         copying that.
13119
13120 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13121
13122         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13123         for static members.
13124         (pass_in_v_vfp_candidate): Likewise.
13125
13126 2019-01-23  Tom Tromey  <tom@tromey.com>
13127             Pedro Alves  <palves@redhat.com>
13128
13129         * regcache.c (class regcache_invalidator): Remove.
13130         (regcache::raw_write): Use make_scope_exit.
13131
13132 2019-01-23  Tom Tromey  <tom@tromey.com>
13133
13134         * ui-out.h (class ui_out_emit_type): Update comment.
13135
13136 2019-01-23  Tom Tromey  <tom@tromey.com>
13137
13138         * infrun.c (fetch_inferior_event): Update comment.
13139
13140 2019-01-23  Tom Tromey  <tom@tromey.com>
13141             Pedro Alves  <palves@redhat.com>
13142
13143         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13144         parameter.
13145         (fetch_inferior_event): Use SCOPE_EXIT.
13146
13147
13148 2019-01-23  Tom Tromey  <tom@tromey.com>
13149             Pedro Alves  <palves@redhat.com>
13150
13151         * infrun.c (disable_thread_events): Delete.
13152         (stop_all_threads): Use SCOPE_EXIT.
13153
13154 2019-01-23  Tom Tromey  <tom@tromey.com>
13155             Pedro Alves  <palves@redhat.com>
13156
13157         * symfile.c: Include forward-scope-exit.h.
13158         (clear_symtab_users_cleanup): Replace forward declaration with
13159         a FORWARD_SCOPE_EXIT.
13160         (syms_from_objfile_1): Use the forward_scope_exit and
13161         gdb::optional instead of cleanup_function.
13162         (reread_symbols): Use the forward_scope_exit instead of
13163         cleanup_function.
13164         (clear_symtab_users_cleanup): Remove function.
13165
13166 2019-01-23  Tom Tromey  <tom@tromey.com>
13167             Pedro Alves  <palves@redhat.com>
13168
13169         * linux-nat.c: Include scope-exit.h.
13170         (cleanup_target_stop): Remove.
13171         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13172         SCOPE_EXIT.
13173
13174 2019-01-23  Tom Tromey  <tom@tromey.com>
13175             Pedro Alves  <palves@redhat.com>
13176
13177         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13178         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13179
13180 2019-01-23  Tom Tromey  <tom@tromey.com>
13181             Andrew Burgess  <andrew.burgess@embecosm.com>
13182             Pedro Alves  <palves@redhat.com>
13183
13184         * infrun.c (fetch_inferior_event): Use scope_exit.
13185         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13186         * top.c (execute_command): Use scope_exit.
13187         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13188         * utils.c (do_bpstat_clear_actions_cleanup)
13189         (make_bpstat_clear_actions_cleanup): Remove.
13190
13191 2019-01-23  Tom Tromey  <tom@tromey.com>
13192             Pedro Alves  <palves@redhat.com>
13193
13194         * infrun.c: Include "common/scope-exit.h"
13195         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13196         (wait_for_inferior): Use SCOPE_EXIT.
13197         (fetch_inferior_event): Use scope_exit.
13198
13199 2019-01-23  Tom Tromey  <tom@tromey.com>
13200             Pedro Alves  <palves@redhat.com>
13201
13202         * breakpoint.c (create_breakpoint): Remove cleanup.
13203
13204 2019-01-23  Tom Tromey  <tom@tromey.com>
13205             Andrew Burgess  <andrew.burgess@embecosm.com>
13206             Pedro Alves  <palves@redhat.com>
13207
13208 2019-01-23  Pedro Alves  <palves@redhat.com>
13209
13210         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13211
13212 2019-01-23  Pedro Alves  <palves@redhat.com>
13213             Andrew Burgess  <andrew.burgess@embecosm.com>
13214
13215         * gdbthread.h: Include "common/forward-scope-exit.h".
13216         (scoped_finish_thread_state): Redefine custom class in terms of
13217         forward_scope_exit.
13218
13219 2019-01-23  Pedro Alves  <palves@redhat.com>
13220             Andrew Burgess  <andrew.burgess@embecosm.com>
13221
13222         * common/forward-scope-exit.h: New file.
13223
13224 2019-01-23  Pedro Alves  <palves@redhat.com>
13225             Andrew Burgess  <andrew.burgess@embecosm.com>
13226             Tom Tromey  <tom@tromey.com>
13227
13228         * common/scope-exit.h: New file.
13229
13230 2019-01-23  Pedro Alves  <palves@redhat.com>
13231
13232         * common/preprocessor.h (ESC): Rename to ...
13233         (ESC_PARENS): ... this.
13234         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13235         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13236
13237 2019-01-23  Tom Tromey  <tom@tromey.com>
13238
13239         * language.h (class scoped_switch_to_sym_language_if_auto):
13240         Initialize m_lang in both cases.
13241
13242 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13243
13244         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13245         with XCNEW.
13246
13247 2019-01-22  Tom Tromey  <tom@tromey.com>
13248
13249         * corelow.c: Do not include sys/file.h.
13250
13251 2019-01-22  Tom Tromey  <tom@tromey.com>
13252
13253         * tui/tui-wingeneral.h: Include gdb_curses.h.
13254
13255 2019-01-22  Tom Tromey  <tom@tromey.com>
13256
13257         * source-cache.h (class source_cache) <get_source_lines,
13258         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13259
13260 2019-01-22  Tom Tromey  <tom@tromey.com>
13261
13262         * remote-fileio.h (struct remote_target): Declare.
13263
13264 2019-01-22  Tom Tromey  <tom@tromey.com>
13265
13266         * python/py-arch.c: Do not include py-ref.h.
13267         * python/py-bpevent.c: Do not include py-ref.h.
13268         * python/py-cmd.c: Do not include py-ref.h.
13269         * python/py-continueevent.c: Do not include py-ref.h.
13270         * python/py-event.h: Do not include py-ref.h.
13271         * python/py-evtregistry.c: Do not include py-ref.h.
13272         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13273         * python/py-frame.c: Do not include py-ref.h.
13274         * python/py-framefilter.c: Do not include py-ref.h.
13275         * python/py-function.c: Do not include py-ref.h.
13276         * python/py-infevents.c: Do not include py-ref.h.
13277         * python/py-linetable.c: Do not include py-ref.h.
13278         * python/py-objfile.c: Do not include py-ref.h.
13279         * python/py-param.c: Do not include py-ref.h.
13280         * python/py-prettyprint.c: Do not include py-ref.h.
13281         * python/py-progspace.c: Do not include py-ref.h.
13282         * python/py-symbol.c: Do not include py-ref.h.
13283         * python/py-symtab.c: Do not include py-ref.h.
13284         * python/py-type.c: Do not include py-ref.h.
13285         * python/py-unwind.c: Do not include py-ref.h.
13286         * python/py-utils.c: Do not include py-ref.h.
13287         * python/py-value.c: Do not include py-ref.h.
13288         * python/py-varobj.c: Do not include py-ref.h.
13289         * python/py-xmethods.c: Do not include py-ref.h.
13290         * python/python.c: Do not include py-ref.h.
13291         * varobj.c: Do not include py-ref.h.
13292
13293 2019-01-22  Tom Tromey  <tom@tromey.com>
13294
13295         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13296         keyword for bcache.
13297
13298 2019-01-22  Tom Tromey  <tom@tromey.com>
13299
13300         * compile/compile-cplus-types.c: Remove a comment by #include.
13301
13302 2019-01-22  Tom Tromey  <tom@tromey.com>
13303
13304         * compile/gcc-c-plugin.h: Include compile-internal.h.
13305
13306 2019-01-22  Tom Tromey  <tom@tromey.com>
13307
13308         * stabsread.c (EXTERN): Do not define.
13309         (symnum, next_symbol_text_func, processing_gcc_compilation)
13310         (within_function, global_sym_chain, global_stabs)
13311         (previous_stab_code, this_object_header_files)
13312         (n_this_object_header_files)
13313         (n_allocated_this_object_header_files): Define.
13314         * stabsread.h (EXTERN): Never define.  Use "extern".
13315
13316 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13317
13318         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13319         history_value.
13320
13321 2019-01-21  Tom Tromey  <tom@tromey.com>
13322
13323         * ui-out.c: Fix includes.
13324         * tui/tui-source.c: Fix includes.
13325         * target.c: Fix includes.
13326         * remote.c: Fix includes.
13327         * regcache.c: Fix includes.
13328         * python/py-block.c: Fix includes.
13329         * printcmd.c: Fix includes.
13330         * or1k-tdep.c: Fix includes.
13331         * mi/mi-main.c: Fix includes.
13332         * m32r-tdep.c: Fix includes.
13333         * csky-tdep.c: Fix includes.
13334         * compile/compile-cplus-types.c: Fix includes.
13335         * cli/cli-interp.c: Fix includes.
13336
13337 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13338
13339         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13340         for padding.
13341
13342 2019-01-16  Tom Tromey  <tom@tromey.com>
13343
13344         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13345         earlier.
13346         (struct objfile) <msymbols_range>: Move from top level.
13347         <msymbols>: New method.
13348         (class objfile_msymbols): Remove.
13349         * symtab.c (default_collect_symbol_completion_matches_break_on):
13350         Update.
13351         * symmisc.c (dump_msymbols): Update.
13352         * stabsread.c (scan_file_globals): Update.
13353         * objc-lang.c (info_selectors_command, info_classes_command)
13354         (find_methods): Update.
13355         * minsyms.c (find_solib_trampoline_target): Update.
13356         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13357         * coffread.c (coff_symfile_read): Update.
13358         * ada-lang.c (ada_lookup_simple_minsym)
13359         (ada_collect_symbol_completion_matches): Update.
13360
13361 2019-01-16  Tom Tromey  <tom@tromey.com>
13362
13363         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13364         type.  Remove no-argument constructor.
13365         <iterator::operator++>: Simplify.
13366         <begin>: Update.
13367         <end>: Use minimal_symbol_count.
13368
13369 2019-01-16  Tom Tromey  <tom@tromey.com>
13370
13371         * objfiles.h (struct objfile) <psymtabs>: New method.
13372         (class objfile_psymtabs): Remove.
13373         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13374         typedef.
13375         <range>: New method.
13376         (require_partial_symbols): Change return type.
13377         * psymtab.c (require_partial_symbols)
13378         (psym_expand_symtabs_matching): Update.
13379         * mdebugread.c (parse_partial_symbols): Update.
13380         * dbxread.c (dbx_end_psymtab): Update.
13381
13382 2019-01-15  Tom Tromey  <tom@tromey.com>
13383
13384         * symtab.c (lookup_objfile_from_block)
13385         (lookup_symbol_in_objfile_symtabs)
13386         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13387         (find_line_symtab, info_sources_command)
13388         (default_collect_symbol_completion_matches_break_on)
13389         (make_source_files_completion_list): Update.
13390         * symmisc.c (print_objfile_statistics, dump_objfile)
13391         (maintenance_print_symbols, maintenance_info_symtabs)
13392         (maintenance_check_symtabs, maintenance_info_line_tables):
13393         Update.
13394         * source.c (select_source_symtab)
13395         (forget_cached_source_info_for_objfile): Update.
13396         * objfiles.h (class objfile_compunits): Remove.
13397         (struct objfile) <compunits_range>: New typedef.
13398         (compunits): New method.
13399         * objfiles.c (objfile_relocate1): Update.
13400         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13401         * maint.c (count_symtabs_and_blocks): Update.
13402         * linespec.c (iterate_over_all_matching_symtabs): Update.
13403         * cp-support.c (add_symbol_overload_list_qualified): Update.
13404         * coffread.c (coff_symtab_read): Update.
13405         * ada-lang.c (add_nonlocal_symbols)
13406         (ada_collect_symbol_completion_matches)
13407         (ada_add_global_exceptions): Update.
13408
13409 2019-01-15  Tom Tromey  <tom@tromey.com>
13410
13411         * progspace.h (program_space) <objfiles_safe_range>: New
13412         typedef.
13413         <objfiles_safe>: New method.
13414         * objfiles.h (class all_objfiles_safe): Remove.
13415         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13416         * jit.c (jit_inferior_exit_hook): Update.
13417
13418 2019-01-17  Tom Tromey  <tom@tromey.com>
13419
13420         * progspace.h (program_space) <objfiles_range>: New typedef.
13421         <objfiles>: New method.
13422         <objfiles_head>: Rename from objfiles.
13423         (object_files): Update.
13424         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13425         * guile/scm-pretty-print.c
13426         (ppscm_find_pretty_printer_from_objfiles): Update.
13427         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13428         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13429         Update.
13430         * python/py-progspace.c (pspy_get_objfiles): Update.
13431         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13432         Update.
13433         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13434         (objfpy_lookup_objfile_by_build_id): Update.
13435         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13436         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13437         Update.
13438         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13439         (expand_symtab_containing_pc, lookup_objfile_from_block)
13440         (lookup_static_symbol, basic_lookup_transparent_type)
13441         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13442         (find_line_symtab, info_sources_command)
13443         (default_collect_symbol_completion_matches_break_on)
13444         (make_source_files_completion_list, find_main_name): Update.
13445         * symmisc.c (print_symbol_bcache_statistics)
13446         (print_objfile_statistics, maintenance_print_symbols)
13447         (maintenance_print_msymbols, maintenance_print_objfiles)
13448         (maintenance_info_symtabs, maintenance_check_symtabs)
13449         (maintenance_expand_symtabs, maintenance_info_line_tables):
13450         Update.
13451         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13452         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13453         (map_overlay_command, unmap_overlay_command)
13454         (simple_overlay_update, expand_symtabs_matching)
13455         (map_symbol_filenames): Update.
13456         * symfile-debug.c (set_debug_symfile): Update.
13457         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13458         Update.
13459         * source.c (select_source_symtab, forget_cached_source_info):
13460         Update.
13461         * solib.c (solib_read_symbols): Update.
13462         * solib-spu.c (append_ocl_sos): Update.
13463         * psymtab.c (maintenance_print_psymbols)
13464         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13465         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13466         * printcmd.c (info_symbol_command): Update.
13467         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13468         Update.
13469         * objfiles.h (class all_objfiles): Remove.
13470         * objfiles.c (have_partial_symbols, have_full_symbols)
13471         (have_minimal_symbols, qsort_cmp, update_section_map)
13472         (shared_objfile_contains_address_p)
13473         (default_iterate_over_objfiles_in_search_order): Update.
13474         * objc-lang.c (info_selectors_command, info_classes_command)
13475         (find_methods): Update.
13476         * minsyms.c (find_solib_trampoline_target): Update.
13477         * maint.c (maintenance_info_sections)
13478         (maintenance_translate_address, count_symtabs_and_blocks):
13479         Update.
13480         * main.c (captured_main_1): Update.
13481         * linux-thread-db.c (try_thread_db_load_from_pdir)
13482         (has_libpthread): Update.
13483         * linespec.c (iterate_over_all_matching_symtabs)
13484         (search_minsyms_for_name): Update.
13485         * jit.c (jit_find_objf_with_entry_addr): Update.
13486         * hppa-tdep.c (find_unwind_entry)
13487         (hppa_lookup_stub_minimal_symbol): Update.
13488         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13489         Update.
13490         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13491         (elf_gnu_ifunc_resolve_by_got): Update.
13492         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13493         * dwarf-index-write.c (save_gdb_index_command): Update.
13494         * cp-support.c (add_symbol_overload_list_qualified): Update.
13495         * breakpoint.c (create_overlay_event_breakpoint)
13496         (create_longjmp_master_breakpoint)
13497         (create_std_terminate_master_breakpoint)
13498         (create_exception_master_breakpoint): Update.
13499         * blockframe.c (find_pc_partial_function): Update.
13500         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13501         (ada_collect_symbol_completion_matches)
13502         (ada_add_global_exceptions): Update.
13503
13504 2019-01-17  Tom Tromey  <tom@tromey.com>
13505
13506         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13507         declare VEC.
13508         (solib_target_parse_libraries): Change return type.
13509         (library_list_start_segment, library_list_start_section)
13510         (library_list_end_library, library_list_start_library); Update.
13511         (solib_target_free_library_list): Remove.
13512         (solib_target_parse_libraries): Remove cleanup.  Change return
13513         type.
13514         (solib_target_current_sos): Update.
13515
13516 2019-01-17  Tom Tromey  <tromey@bapiya>
13517
13518         * valprint.c: Replace "the the" with "the".
13519         * symtab.c: Replace "the the" with "the".
13520         * solib.c: Replace "the the" with "the".
13521         * solib-dsbt.c: Replace "the the" with "the".
13522         * linespec.c: Replace "the the" with "the".
13523         * dwarf2loc.h: Replace "the the" with "the".
13524         * amd64-windows-tdep.c: Replace "the the" with "the".
13525         * aarch64-tdep.c: Replace "the the" with "the".
13526
13527 2019-01-16  Keith Seitz  <keiths@redhat.com>
13528
13529         PR gdb/23773
13530         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13531         <builder>: Rename to ..
13532         <m_builder>: ... this and make private.
13533         (dwarf2_cu::get_builder): New method.  Change all users of
13534         `builder' to use this method.
13535         (dwarf2_start_symtab): Move to ...
13536         (dwarf2_cu::start_symtab): ... here.  Update all callers
13537         (setup_type_unit_groups): Move to ...
13538         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13539         callers.
13540         (dwarf2_cu::reset_builder): New method.
13541         (process_full_compunit, process_full_type_unit): Use
13542         dwarf2_cu::reset_builder.
13543         (follow_die_offset): Record the ancestor CU if it is different
13544         from the followed DIE's CU.
13545         (follow_die_sig_1): Likewise.
13546
13547 2019-01-15  Tom Tromey  <tom@tromey.com>
13548
13549         * remote.c (class remote_state) <buf>: Now a char_vector.
13550         <buf_size>: Remove.
13551         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13552         parameter.
13553         (remote_target::getpkt_or_notif_sane_1)
13554         (remote_target::getpkt_sane)
13555         (remote_target::getpkt_or_notif_sane): Likewise.
13556         (class remote_target) <putpkt>: New overload.
13557         (remote_target::read_frame): Change type of "buf_p".  Remove
13558         sizeof_p parameter.
13559         (packet_ok): New overload.
13560         (packet_check_result): New overload.
13561         Update all uses.
13562
13563 2019-01-14  Tom Tromey  <tom@tromey.com>
13564
13565         * remote-notif.c (handle_notification, remote_notif_ack)
13566         (remote_notif_parse): Make "buf" const.
13567         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13568         const.
13569         (remote_notif_parse, remote_notif_ack, handle_notification):
13570         Likewise.
13571         * remote.c (remote_notif_stop_parse): Make "buf" const.
13572         (remote_target::remote_parse_stop_reply): Make "buf" const.
13573         (remote_notif_stop_ack): Make "buf" const.
13574
13575 2019-01-14  Tom Tromey  <tom@tromey.com>
13576
13577         * remote.c (remote_console_output): Make parameter const.
13578
13579 2019-01-14  Tom Tromey  <tom@tromey.com>
13580
13581         * target-debug.h (target_debug_print_signals): Constify.
13582         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13583         * procfs.c (procfs_target::pass_signals): Update.
13584         * linux-nat.c (linux_nat_target::pass_signals): Update.
13585         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13586         * target-delegates.c: Rebuild.
13587         * remote.c (remote_target::program_signals): Update.
13588         (remote_target::pass_signals): Update.
13589         * target.c (target_pass_signals): Constify argument.
13590         (target_program_signals): Likewise.
13591         * target.h (struct target_ops) <pass_signals, program_signals>:
13592         Constify argument.
13593         (target_pass_signals, target_program_signals): Constify argument.
13594
13595 2019-01-14  Tom Tromey  <tom@tromey.com>
13596
13597         PR tui/28819:
13598         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13599
13600 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13601
13602         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13603         field.
13604         * rs6000-tdep.c: Include reggroups.h.
13605         (IS_V_ALIAS_PSEUDOREG): Define.
13606         (rs6000_register_name): Return names for the "vX" aliases.
13607         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13608         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13609         aliases.  Call default_register_reggroup_p for all other
13610         pseudo-registers.
13611         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13612         New functions.
13613         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13614         Handle "vX" aliases.
13615         (v_alias_pseudo_register_collect): New function.
13616         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13617         (rs6000_gdbarch_init): Initialize "vX" aliases as
13618         pseudo-registers.  Restore registration of
13619         rs6000_pseudo_register_reggroup_p with
13620         set_tdesc_pseudo_register_reggroup_p.
13621
13622 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13623
13624         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13625         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13626         set_gdbarch_num_pseudo_regs.
13627
13628 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13629
13630         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13631         Remove arg prefixname, add do_set and do_show.
13632         Add member functions set_list and show_list.
13633         * cli/cli-style.c (class cli_style_option): Update accordingly.
13634         (style_set_list): Move to file scope.
13635         (style_show_list): Likewise.
13636         (set_style): Call help_list.
13637         (show_style): Call cmd_show_list.
13638         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13639         Update to use the new macro.
13640
13641 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13642
13643         * ada-lang.c (_initialize_ada_language): Expand the help text
13644         for the "catch exception" command.
13645
13646 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13647
13648         * symtab.c (matching_obj_sections): Initialize obj,
13649         declare it closer to its usage.
13650
13651 2019-01-10  Tom Tromey  <tom@tromey.com>
13652
13653         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13654         (basic_inf_threads_range): Remove.
13655         (inf_threads_range, inf_non_exited_threads_range)
13656         (safe_inf_threads_range): Use next_adapter.
13657
13658 2019-01-10  Keith Seitz  <keiths@redhat.com>
13659
13660         PR gdb/23712
13661         PR symtab/23010
13662         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13663         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13664
13665 2019-01-10  Keith Seitz  <keiths@redhat.com>
13666
13667         PR gdb/23712
13668         PR symtab/23010
13669         * dictionary.c (pending_to_vector): Remove.
13670         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13671         Remove _1 suffix, replacing functions of the same name.  Update
13672         all callers.
13673         (dict_create_hashed, dict_create_hashed_expandable)
13674         (dict_create_linear, dict_create_linear_expandable, dict_free)
13675         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13676         Make functions static.
13677
13678 2019-01-10  Keith Seitz  <keiths@redhat.com>
13679
13680         PR gdb/23712
13681         PR symtab/23010
13682         * dictionary.h (struct dictionary): Replace declaration with
13683         multidictionary.
13684         (dict_create_hashed, dict_create_hashed_expandable)
13685         (dict_create_linear, dict_create_linear_expandable)
13686         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13687         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13688         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13689         taking multidictionary argument.
13690         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13691         * block.h (struct block) <dict>: Change to multidictionary
13692         and rename `multidict'.
13693         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13694         symmisc.c: Update all dictionary references to multidictionary.
13695
13696 2019-01-10  Keith Seitz  <keiths@redhat.com>
13697
13698         PR gdb/23712
13699         PR symtab/23010
13700         * dictionary.c: Include unordered_map.
13701         (pending_to_vector): New function.
13702         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13703         Rewrite the non-"_1" functions to take vector instead
13704         of linked list.
13705         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13706         "new" _1 versions of the same name.
13707         (multidictionary): Define.
13708         (std::hash<enum language): New definition.
13709         (collate_pending_symbols_by_language, mdict_create_hashed)
13710         (mdict_create_hashed_expandable, mdict_create_linear)
13711         (mdict_create_linear_expandable, mdict_free)
13712         (find_language_dictionary, create_new_language_dictionary)
13713         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13714         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13715         (mdict_size, mdict_empty): New functions.
13716         * dictionary.h (mdict_iterator): Define.
13717
13718 2019-01-10  Pedro Alves  <palves@redhat.com>
13719
13720         * breakpoint.c (read_uploaded_action)
13721         (create_tracepoint_from_upload): Adjust to use
13722         gdb::unique_xmalloc_ptr.
13723         * ctf.c (ctf_write_uploaded_tp):
13724         (SET_ARRAY_FIELD): Use emplace_back.
13725         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13726         * tracefile-tfile.c (tfile_write_uploaded_tp):
13727         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13728         gdb::unique_xmalloc_ptr.
13729         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13730         at_string, cond_string, cmd_strings>: Replace char pointers
13731         with gdb::unique_xmalloc_ptr.
13732
13733 2019-01-10  Pedro Alves  <palves@redhat.com>
13734
13735         * solib-target.c (library_list_start_library): Don't xstrdup name.
13736
13737 2019-01-10  Pedro Alves  <palves@redhat.com>
13738
13739         * mdebugread.c (parse_partial_symbols): Use
13740         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13741
13742 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13743
13744         * linux-fork.c (scoped_switch_fork_info)
13745         <~scoped_switch_fork_info>: Fix incorrect variable name.
13746
13747 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13748
13749         * linux-fork.c (scoped_switch_fork_info)
13750         <scoped_switch_fork_info>: Make explicit.
13751         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13752
13753 2019-01-10  Tom Tromey  <tom@tromey.com>
13754
13755         * objfiles.h (objfile::reset_psymtabs): Update.
13756         * objfiles.c (objfile::objfile): Update.
13757         * psymtab.h (psymtab_storage::obstack): Update.
13758         (psymtab_storage::m_obstack): Use gdb::optional.
13759         (class psymtab_storage): Update comment.  Remove objfile
13760         parameter.
13761         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13762
13763 2019-01-10  Tom Tromey  <tom@tromey.com>
13764
13765         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13766         <free_psymtabs>: Now private.
13767         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13768         (allocate_psymtab): Use new method.
13769
13770 2019-01-10  Tom Tromey  <tom@tromey.com>
13771
13772         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13773         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13774         * mdebugread.c (parse_partial_symbols): Use
13775         allocate_dependencies.
13776         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13777         allocate_dependencies.
13778         (process_psymtab_comp_unit_reader)
13779         (build_type_psymtab_dependencies): Likewise.
13780         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13781
13782 2019-01-10  Tom Tromey  <tom@tromey.com>
13783
13784         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13785         PSYMBOL_SET_LANGUAGE.
13786         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13787
13788 2019-01-10  Tom Tromey  <tom@tromey.com>
13789
13790         * psymtab.h (psymtab_storage::obstack): New method.
13791         <m_obstack>: Rename from obstack; now private.
13792         * psymtab.c (psymtab_storage): Update.
13793         * dwarf2read.c (create_addrmap_from_index)
13794         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13795         Update.
13796
13797 2019-01-10  Tom Tromey  <tom@tromey.com>
13798
13799         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13800         * objfiles.h (objfile::reset_psymtabs): New method.
13801
13802 2019-01-10  Tom Tromey  <tom@tromey.com>
13803
13804         * symmisc.c (print_symbol_bcache_statistics): Update.
13805         (print_objfile_statistics): Update.
13806         * symfile.c (reread_symbols): Update.
13807         * psymtab.h (class psymtab_storage): New.
13808         * psymtab.c (psymtab_storage): New constructor.
13809         (~psymtab_storage): New destructor.
13810         (require_partial_symbols): Update.
13811         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13812         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13813         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13814         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13815         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13816         (start_psymtab_common, end_psymtab_common)
13817         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13818         (allocate_psymtab): Update.
13819         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13820         Update.
13821         (dump_psymtab_addrmap, maintenance_print_psymbols)
13822         (maintenance_check_psymtabs): Update.
13823         (class objfile_psymtabs): Move to objfiles.h.
13824         * psympriv.h (discard_psymtab): Now inline.
13825         (psymtab_discarder::psymtab_discarder): Update.
13826         (psymtab_discarder::~psymtab_discarder): Update.
13827         (ALL_OBJFILE_PSYMTABS): Rewrite.
13828         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13829         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13830         Remove fields.
13831         <partial_symtabs>: New field.
13832         (class objfile_psymtabs): Move from psymtab.h.  Update.
13833         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13834         psymbol_cache.
13835         (objfile::~objfile): Don't destroy psymbol_cache.
13836         * mdebugread.c (parse_partial_symbols): Update.
13837         * dwarf2read.c (create_addrmap_from_index)
13838         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13839         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13840         (add_partial_subprogram, dwarf2_ranges_read): Update.
13841         * dwarf-index-write.c (write_address_map)
13842         (write_one_signatured_type, recursively_write_psymbols)
13843         (class debug_names, class debug_names, write_psymtabs_to_index):
13844         Update.
13845
13846 2019-01-10  Tom Tromey  <tom@tromey.com>
13847
13848         * symtab.h (SYMBOL_SET_NAMES): Update.
13849         (symbol_set_names): Update.
13850         (MSYMBOL_SET_NAMES): Update.
13851         * symtab.c (symbol_set_names): Change argument to be an
13852         objfile_per_bfd_storage.
13853         * psymtab.c (add_psymbol_to_bcache): Update.
13854         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13855
13856 2019-01-10  Tom Tromey  <tom@tromey.com>
13857
13858         * symtab.c (create_demangled_names_hash): Change argument to be an
13859         objfile_per_bfd_storage.
13860         (symbol_set_names): Update.
13861
13862 2019-01-10  Tom Tromey  <tom@tromey.com>
13863
13864         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13865         init_psymbol_list.
13866         * psymtab.c (init_psymbol_list): Do nothing if already called.
13867         * psympriv.h (init_psymbol_list): Add comment.
13868         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13869         init_psymbol_list.
13870         * dbxread.c (dbx_symfile_read): Unconditionally call
13871         init_psymbol_list.
13872
13873 2019-01-10  Tom Tromey  <tom@tromey.com>
13874
13875         * xcoffread.c (scan_xcoff_symtab): Update.
13876         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13877         "where".
13878         * mdebugread.c (parse_partial_symbols)
13879         (handle_psymbol_enumerators): Update.
13880         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13881         * dbxread.c (read_dbx_symtab): Update.
13882         * psympriv.h (psymbol_placement): New enum.
13883         (add_psymbol_to_list): Update.
13884
13885 2019-01-10  Tom Tromey  <tom@tromey.com>
13886
13887         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13888         static_psymbols parameters.
13889         (scan_xcoff_symtab): Update.
13890         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13891         static_psymbols parameters.
13892         * psympriv.h (start_psymtab_common): Update.
13893         * mdebugread.c (parse_partial_symbols): Update.
13894         * dwarf2read.c (create_partial_symtab): Update.
13895         * dbxread.c (read_dbx_symtab): Update.
13896         (start_psymtab): Remove global_psymbols and static_psymbols
13897         parameters.
13898
13899 2019-01-10  Tom Tromey  <tom@tromey.com>
13900
13901         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13902         * psymtab.c (allocate_psymtab): Add comment.
13903         * psympriv.h (allocate_psymtab): Add comment.
13904         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13905         initializations.
13906         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13907
13908 2019-01-10  Tom Tromey  <tom@tromey.com>
13909
13910         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13911         Don't declare.
13912         * mipsread.c: Include mdebugread.h.
13913         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13914         Declare.
13915         * elfread.c: Include mdebugread.h.
13916
13917 2019-01-09  Tom Tromey  <tom@tromey.com>
13918
13919         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13920         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13921         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13922         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13923         (psym_lookup_symbol, psym_find_last_source_symtab)
13924         (psym_forget_cached_source_info, psym_print_stats)
13925         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13926         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13927         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13928         (psym_find_compunit_symtab_by_address)
13929         (maintenance_print_psymbols, maintenance_info_psymtabs)
13930         (maintenance_check_psymtabs): Use ranged for.
13931         * psymtab.h (class objfile_psymtabs): New.
13932         (require_partial_symbols): Return objfile_psymtabs.
13933         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13934
13935 2019-01-09  Tom Tromey  <tom@tromey.com>
13936
13937         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13938         (find_pc_mapped_section, list_overlays_command)
13939         (map_overlay_command, unmap_overlay_command)
13940         (simple_overlay_update): Use all_objfiles.
13941         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13942         * printcmd.c (info_symbol_command): Use all_objfiles.
13943         * objfiles.h (ALL_OBJSECTIONS): Remove.
13944         * maint.c (maintenance_translate_address): Use all_objfiles.
13945         * gcore.c (gcore_create_callback): Use all_objfiles.
13946         (objfile_find_memory_regions): Likewise.
13947
13948 2019-01-09  Tom Tromey  <tom@tromey.com>
13949
13950         * symtab.c (find_line_symtab, info_sources_command)
13951         (make_source_files_completion_list): Use objfile_compunits.
13952         * source.c (select_source_symtab): Use objfile_compunits.
13953         * objfiles.h (struct objfile): Update comment.
13954         (ALL_OBJFILES): Remove.
13955         (ALL_FILETABS): Remove.
13956         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13957         objfile_compunits.
13958
13959 2019-01-09  Tom Tromey  <tom@tromey.com>
13960
13961         * symmisc.c (print_objfile_statistics, dump_objfile)
13962         (maintenance_print_symbols): Use compunit_filetabs.
13963         * source.c (forget_cached_source_info_for_objfile): Use
13964         compunit_filetabs.
13965         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13966         (ALL_FILETABS): Use compunit_filetabs.
13967         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13968         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13969
13970 2019-01-09  Tom Tromey  <tom@tromey.com>
13971
13972         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13973         (compunit_filetabs): New.
13974         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13975         compunit_filetabs.
13976         (info_sources_command, make_source_files_completion_list): Remove
13977         declaration.
13978         * symmisc.c (print_objfile_statistics, dump_objfile)
13979         (maintenance_print_symbols): Remove declaration.
13980         (maintenance_info_symtabs): Use compunit_filetabs.
13981         (maintenance_info_line_tables): Likewise.
13982         * source.c (select_source_symtab): Change local variable name.
13983         (forget_cached_source_info_for_objfile): Remove declaration.
13984         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13985         * objfiles.c (objfile_relocate1): Remove declaration.
13986         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13987         declaration.
13988         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13989         * coffread.c (coff_symtab_read): Remove declaration.
13990         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13991         compunit_filetabs.
13992
13993 2019-01-09  Tom Tromey  <tom@tromey.com>
13994
13995         * symtab.c (lookup_objfile_from_block)
13996         (find_pc_sect_compunit_symtab, search_symbols)
13997         (default_collect_symbol_completion_matches_break_on): Use
13998         objfile_compunits.
13999         * objfiles.h (ALL_COMPUNITS): Remove.
14000         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14001         * cp-support.c (add_symbol_overload_list_qualified): Use
14002         objfile_compunits.
14003         * ada-lang.c (ada_collect_symbol_completion_matches)
14004         (ada_add_global_exceptions): Use objfile_compunits.
14005
14006 2019-01-09  Tom Tromey  <tom@tromey.com>
14007
14008         * source.c (select_source_symtab)
14009         (forget_cached_source_info_for_objfile): Remove declaration.
14010         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14011         declaration.
14012         * maint.c (count_symtabs_and_blocks): Remove declaration.
14013         * cp-support.c (add_symbol_overload_list_qualified): Remove
14014         declaration.
14015         * coffread.c (coff_symtab_read): Remove declaration.
14016         * symtab.c (lookup_symbol_in_objfile_symtabs)
14017         (basic_lookup_transparent_type_1): Use objfile_compunits.
14018         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14019         (info_sources_command, search_symbols)
14020         (default_collect_symbol_completion_matches_break_on)
14021         (make_source_files_completion_list): Remove declaration.
14022         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14023         (ada_collect_symbol_completion_matches)
14024         (ada_add_global_exceptions): Remove declaration.
14025         * linespec.c (iterate_over_all_matching_symtabs): Use
14026         objfile_compunits.
14027         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14028         (class objfile_compunits): New.
14029         (ALL_COMPUNITS): Use objfile_compunits.
14030         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14031         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14032         objfile_compunits.
14033         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14034
14035 2019-01-09  Tom Tromey  <tom@tromey.com>
14036
14037         * symtab.c (search_symbols)
14038         (default_collect_symbol_completion_matches_break_on): Use
14039         objfile_msymbols.
14040         * ada-lang.c (ada_lookup_simple_minsym)
14041         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14042         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14043         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14044         objfile_msymbols.
14045         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14046         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14047         * objc-lang.c (find_methods): Use objfile_msymbols.
14048         (info_selectors_command, info_classes_command): Likewise.
14049         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14050         * objfiles.h (class objfile_msymbols): New.
14051         (ALL_OBJFILE_MSYMBOLS): Remove.
14052         (ALL_MSYMBOLS): Remove.
14053
14054 2019-01-09  Tom Tromey  <tom@tromey.com>
14055
14056         * common/next-iterator.h (next_adapter): Add Iterator template
14057         parameter.
14058         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14059         (class all_objfiles_safe): New.
14060         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14061         * objfiles.c (put_objfile_before): Update comment.
14062         (add_separate_debug_objfile): Likewise.
14063         (free_all_objfiles): Use all_objfiles_safe.
14064         (objfile_purge_solibs): Likewise.
14065
14066 2019-01-09  Tom Tromey  <tom@tromey.com>
14067
14068         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14069         (expand_symtab_containing_pc, lookup_static_symbol)
14070         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14071         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14072         all_objfiles.
14073         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14074         * breakpoint.c (create_overlay_event_breakpoint)
14075         (create_longjmp_master_breakpoint)
14076         (create_std_terminate_master_breakpoint)
14077         (create_exception_master_breakpoint): Use all_objfiles.
14078         * linux-thread-db.c (try_thread_db_load_from_pdir)
14079         (has_libpthread): Use all_objfiles.
14080         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14081         * linespec.c (iterate_over_all_matching_symtabs)
14082         (search_minsyms_for_name): Use all_objfiles.
14083         * maint.c (maintenance_info_sections): Use all_objfiles.
14084         * main.c (captured_main_1): Use all_objfiles.
14085         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14086         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14087         * guile/scm-pretty-print.c
14088         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14089         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14090         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14091         (maintenance_print_msymbols): Use all_objfiles.
14092         * source.c (select_source_symtab): Use all_objfiles.
14093         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14094         * symfile.c (remove_symbol_file_command)
14095         (expand_symtabs_matching, map_symbol_filenames): Use
14096         all_objfiles.
14097         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14098         all_objfiles.
14099         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14100         * objc-lang.c (find_methods): Use all_objfiles.
14101         * objfiles.c (have_partial_symbols, have_full_symbols)
14102         (have_minimal_symbols, qsort_cmp)
14103         (default_iterate_over_objfiles_in_search_order): Use
14104         all_objfiles.
14105         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14106         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14107         (maintenance_check_psymtabs): Use all_objfiles.
14108         (ALL_PSYMTABS): Remove.
14109         * compile/compile-object-run.c (do_module_cleanup): Use
14110         all_objfiles.
14111         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14112         * cp-support.c (add_symbol_overload_list_qualified): Use
14113         all_objfiles.
14114         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14115         Use all_objfiles.
14116         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14117         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14118         all_objfiles.
14119         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14120         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14121         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14122         Uses all_objfiles.
14123         * solib.c (solib_read_symbols): Use all_objfiles
14124
14125 2019-01-09  Tom Tromey  <tom@tromey.com>
14126
14127         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14128         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14129         all_objfiles.
14130         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14131         * symmisc.c (print_symbol_bcache_statistics)
14132         (print_objfile_statistics, maintenance_print_objfiles)
14133         (maintenance_info_symtabs, maintenance_check_symtabs)
14134         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14135         all_objfiles.
14136         * source.c (forget_cached_source_info): Use all_objfiles.
14137         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14138         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14139         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14140         * objfiles.c (update_section_map): Use all_objfiles.
14141         (shared_objfile_contains_address_p): Likewise.
14142         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14143         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14144
14145 2019-01-09  Tom Tromey  <tom@tromey.com>
14146
14147         * common/next-iterator.h: New file.
14148         * objfiles.h (class all_objfiles): New.
14149         (struct objfile_iterator): New.
14150
14151 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14152
14153         * NEWS: Move the description of the changed "frame", "select-frame",
14154          and "info frame" commands to the Changed commands section.
14155
14156 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14157
14158         * gdbtypes.c (check_stub_method_group): Remove handling of old
14159         mangling schemes.
14160         * linespec.c (find_methods): Likewise.
14161         * stabsread.c (read_member_functions): Likewise.
14162         * valops.c (search_struct_method): Likewise.
14163         (value_struct_elt_for_reference): Likewise.
14164         * NEWS: Mention this change.
14165
14166 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14167
14168         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14169         print_source_lines.
14170         * source.c (print_source_lines_base): Update line number check.
14171         (print_source_lines): New function.
14172         (source_lines_range::source_lines_range): New function.
14173         * source.h (class source_lines_range): New class.
14174         (print_source_lines): New declaration.
14175
14176 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14177
14178         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14179
14180 2019-01-08  Tom Tromey  <tom@tromey.com>
14181             Simon Marchi  <simon.marchi@ericsson.com>
14182
14183         PR gdb/24060
14184         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14185         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14186         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14187         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14188         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14189         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14190
14191 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14192
14193         * source.c (select_source_symtab): Move header comment to
14194         declaration in source.h.
14195         (forget_cached_source_info_for_objfile): Likewise.
14196         (forget_cached_source_info): Likewise.
14197         (identify_source_line): Likewise.
14198         * source.h (identify_source_line): Move declaration from symtab.h
14199         and add comment from source.c
14200         (print_source_lines): Likewise.
14201         (forget_cached_source_info_for_objfile): Likewise.
14202         (forget_cached_source_info): Likewise.
14203         (select_source_symtab): Likewise.
14204         (enum print_source_lines_flag): Move definition from symtab.h.
14205         * symtab.h (identify_source_line): Move declaration to source.h.
14206         (print_source_lines): Likewise.
14207         (forget_cached_source_info_for_objfile): Likewise.
14208         (forget_cached_source_info): Likewise.
14209         (select_source_symtab): Likewise.
14210         (enum print_source_lines_flag): Move definition to source.h.
14211         * tui/tui-hooks.c: Add 'source.h' include.
14212
14213 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14214
14215         * source.c (print_source_lines_base): Handle requests to print
14216         reverse line number sequences, and guard against empty lines
14217         string.
14218
14219 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14220
14221         * source.c (print_source_lines_base): Fix skip of '\r' if next
14222         character is '\n'.
14223
14224 2019-01-06  Tom Tromey  <tom@tromey.com>
14225
14226         * c-exp.y (struct c_parse_state) <macro_original_text,
14227         expansion_obstack>: New member.
14228         (macro_original_text, expansion_obstack): Remove globals.
14229         (scan_macro_expansion, scanning_macro_expansion)
14230         (finished_macro_expansion): Update.
14231         (scan_macro_cleanup): Remove.
14232         (yylex, c_parse): Update.
14233
14234 2019-01-06  Tom Tromey  <tom@tromey.com>
14235
14236         * c-exp.y (struct c_parse_state) <strings>: New member.
14237         (operator_stoken): Update.
14238
14239 2019-01-06  Tom Tromey  <tom@tromey.com>
14240
14241         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14242         (union type_stack_elt) <typelist_val>: Now a pointer to
14243         std::vector.
14244         (type_stack_cleanup): Don't declare.
14245         (push_typelist): Update.
14246         * parse.c (pop_typelist): Return a std::vector.
14247         (push_typelist): Take a std::vector.
14248         (follow_types): Update.  Do not free args.
14249         (type_stack_cleanup): Remove.
14250         * c-exp.y (struct c_parse_state): New.
14251         (cpstate): New global.
14252         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14253         (nonempty_typelist): Update.
14254         (func_mod): Create a new vector.
14255         (c_parse): Create a c_parse_state.
14256         (check_parameter_typelist): Do not delete params.
14257         (function_method): Update.  Do not delete type_list.
14258
14259 2019-01-06  Tom Tromey  <tom@tromey.com>
14260
14261         PR gdb/28155:
14262         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14263         check_typedef.
14264         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14265         (print_return_value): Likewise.
14266
14267 2019-01-05  Tom Tromey  <tom@tromey.com>
14268
14269         * contrib/cleanup_check.py: Remove.
14270         * contrib/gcc-with-excheck: Remove.
14271         * contrib/exsummary.py: Remove.
14272         * contrib/excheck.py: Remove.
14273
14274 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14275
14276         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14277         NULL. Initialize tpprev to NULL instead of assigning it
14278         to NULL on the next statement.
14279         * windows-nat.c (windows_delete_thread): Remove check for
14280         main_thread_id before printing thread exit notifications.
14281         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14282         Remove thread ID check against main_thread_id.
14283         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14284         windows_delete_thread.
14285         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14286
14287 2019-01-04  Tom Tromey  <tom@tromey.com>
14288
14289         * compile/compile.c (_initialize_compile): Use upper case for
14290         metasyntactic variables.
14291         * symmisc.c (_initialize_symmisc): Use upper case for
14292         metasyntactic variables.
14293         * psymtab.c (_initialize_psymtab): Use upper case for
14294         metasyntactic variables.
14295         * demangle.c (demangle_command): Use upper case for metasyntactic
14296         variables.
14297         (_initialize_demangler): Likewise.
14298         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14299         variables.
14300
14301 2019-01-03  Tom Tromey  <tom@tromey.com>
14302
14303         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14304
14305 2019-01-03  Tom Tromey  <tom@tromey.com>
14306
14307         * python/py-symtab.c (salpy_str): Update.
14308         (struct salpy_sal_object) <symtab>: Now a PyObject.
14309         (salpy_dealloc): Update.
14310         (del_objfile_sal): Use gdbpy_ref.
14311
14312 2019-01-03  Tom Tromey  <tom@tromey.com>
14313
14314         * python/py-type.c (convert_field): Use new_reference.  Return
14315         gdbpy_ref.
14316         (make_fielditem): Return gdbpy_ref.
14317         (typy_fields): Update.
14318         (typy_getitem): Update.
14319         (field_name): Return gdbpy_ref.  Use new_reference.
14320         (typy_iterator_iternext): Update.
14321
14322 2019-01-03  Tom Tromey  <tom@tromey.com>
14323
14324         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14325
14326 2019-01-03  Tom Tromey  <tom@tromey.com>
14327
14328         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14329         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14330         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14331         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14332         (pspy_set_type_printers): Likewise.
14333         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14334         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14335         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14336         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14337         (objfpy_set_type_printers): Likewise.
14338
14339 2019-01-03  Tom Tromey  <tom@tromey.com>
14340
14341         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14342         (gdbpy_print_stack): Use gdbpy_err_fetch.
14343         * python/python-internal.h (class gdbpy_err_fetch): New class.
14344         (class gdbpy_enter) <m_error_type, m_error_value,
14345         m_error_traceback>: Remove.
14346         <m_error>: New member.
14347         (gdbpy_exception_to_string): Don't declare.
14348         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14349         * python/py-value.c (convert_value_from_python): Use
14350         gdbpy_err_fetch.
14351         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14352         gdbpy_exception_to_string.
14353         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14354         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14355         gdbpy_err_fetch.
14356
14357 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14358
14359         * linux-nat.c (delete_lwp_cleanup): Delete.
14360         (struct lwp_deleter): New struct.
14361         (lwp_info_up): New typedef.
14362         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14363         lwp_info_up.
14364
14365 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14366
14367         * linux-fork.c (class scoped_switch_fork_info): New class.
14368         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14369
14370 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14371
14372         * valops.c (find_overload_match): Remove use of null_cleanup, and
14373         calls to do_cleanups.
14374
14375 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14376
14377         * compile/compile-cplus-types.c
14378         (compile_cplus_instance::decl_name): Handle changes to
14379         cp_func_name.
14380         * cp-support.c (cp_func_name): Update header comment, update
14381         return type.
14382         * cp-support.h (cp_func_name): Update return type in declaration.
14383         * valops.c (find_overload_match): Move temp_func local to top
14384         level of function and change its type.  Use temp_func to hold and
14385         delete temporary string obtained from cp_func_name.
14386
14387 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14388
14389         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14390         gdb::char_vector, remove cleanup, and update uses of `msg`.
14391
14392 2019-01-03  Jim Wilson  <jimw@sifive.com>
14393
14394         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14395
14396 2019-01-02  Tom Tromey  <tom@tromey.com>
14397
14398         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14399         (tdesc_parse_xml): Remove cleanups.
14400         * target-descriptions.h (make_cleanup_free_target_description):
14401         Don't declare.
14402         (target_desc_deleter): New struct.
14403         (target_desc_up): New typedef.
14404         * target-descriptions.c (target_desc_deleter::operator()): Rename
14405         from free_target_description.
14406         (make_cleanup_free_target_description): Remove.
14407
14408 2019-01-02  Tom Tromey  <tom@tromey.com>
14409
14410         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14411         constructor, destructor.
14412         (linespec_parser): Remove typedef.
14413         (~linespec_parser): Rename from linespec_parser_delete.
14414         (linespec_lex_to_end, linespec_complete_label)
14415         (linespec_complete): Update.
14416         (decode_line_full): Remove cleanups.
14417         (decode_line_1): Update.
14418
14419 2019-01-02  Tom Tromey  <tom@tromey.com>
14420
14421         * python/python-internal.h (inferior_to_inferior_object): Change
14422         return type.
14423         * python/py-exitedevent.c (create_exited_event_object): Update.
14424         * python/py-inferior.c (inferior_to_inferior_object): Return
14425         gdbpy_ref.
14426         (python_new_inferior, python_inferior_deleted)
14427         (thread_to_thread_object, delete_thread_object)
14428         (build_inferior_list, gdbpy_selected_inferior): Update.
14429         * python/py-infthread.c (create_thread_object): Update.  Also fail
14430         if inferior_to_inferior_object fails.
14431
14432 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14433
14434         * inferior.h (class inferior) <displaced_step_state>: New field.
14435         * infrun.h (struct displaced_step_state): Move here from
14436         infrun.c.  Initialize fields, add constructor.
14437         <inf>: Remove field.
14438         <reset>: New method.
14439         * infrun.c (struct displaced_step_inferior_state): Move to
14440         infrun.h.
14441         (displaced_step_inferior_states): Remove.
14442         (get_displaced_stepping_state): Adust.
14443         (displaced_step_in_progress_any_inferior): Adjust.
14444         (displaced_step_in_progress_thread): Adjust.
14445         (displaced_step_in_progress): Adjust.
14446         (add_displaced_stepping_state): Remove.
14447         (get_displaced_step_closure_by_addr): Adjust.
14448         (remove_displaced_stepping_state): Remove.
14449         (infrun_inferior_exit): Call displaced_step_state.reset.
14450         (use_displaced_stepping): Don't check for NULL.
14451         (displaced_step_prepare_throw): Call
14452         get_displaced_stepping_state.
14453         (displaced_step_fixup): Don't check for NULL.
14454         (prepare_for_detach): Don't check for NULL.
14455
14456 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14457
14458         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14459          in case of call that did not complete.
14460
14461 2019-01-02  Andrey Utkin  <autkin@undo.io>
14462
14463         * symfile.c (find_separate_debug_file): Fix search of debug files for
14464         remote debuggee.
14465
14466 2019-01-02  Tom Tromey  <tom@tromey.com>
14467
14468         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14469         indentation.
14470         * python/py-frame.c (frapy_older): Remove cast.
14471         (frapy_newer): Likewise.
14472         * python/py-breakpoint.c (local_setattro): Remove cast.
14473         * python/py-arch.c (archpy_name): Remove local variable.
14474         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14475
14476 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14477
14478         * unittests/basic_string_view/element_access/char/empty.cc:
14479         Fix year range in copyright header.
14480
14481 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14482
14483         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14484         Delete.
14485         <operator==>: Update with for removed field.
14486         <hash>: Likewise.
14487         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14488         <isa_features>: ...this.
14489         <abi_features>: New field.
14490         (riscv_isa_flen): Update comment.
14491         (riscv_abi_xlen): New declaration.
14492         (riscv_abi_flen): New declaration.
14493         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14494         isa_features.
14495         (riscv_abi_xlen): New function.
14496         (riscv_isa_flen): Update to get answer from isa_features.
14497         (riscv_abi_flen): New function.
14498         (riscv_has_fp_abi): Update to get answer from abi_features.
14499         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14500         xlen and flen.
14501         (riscv_call_info) <xlen, flen>: Update comment.
14502         (riscv_call_arg_struct): Remove invalid assertions
14503         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14504         is removed.
14505         (riscv_gdbarch_init): Gather isa features and abi features
14506         separately, ensure both match on the gdbarch when reusing an old
14507         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14508         a target with 64-bit float hardware.
14509
14510 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14511
14512         * source.c (search_command_helper): Stop reverse search
14513         when line 1 has been searched.
14514
14515 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14516
14517         * record-full.c (record_full_base_target::close): Rewrite
14518         record_full_core_buf_list free logic.
14519
14520 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14521
14522         * break-catch-syscall.c (print_one_catch_syscall): xfree
14523         the last text.
14524
14525 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14526
14527         * top.c (print_gdb_version): Update Copyright year in version
14528         message.
14529
14530 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14531
14532         Update copyright year range in all GDB files.
14533
14534 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14535
14536         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14537
14538 For older changes see ChangeLog-2018.
14539 \f
14540 Local Variables:
14541 mode: change-log
14542 left-margin: 8
14543 fill-column: 74
14544 version-control: never
14545 coding: utf-8
14546 End:
14547