1 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
3 * stack.c (set_last_displayed_sal): Delete.
4 (last_displayed_sal_valid): Delete.
5 (last_displayed_pspace): Delete.
6 (last_displayed_addr): Delete.
7 (last_displayed_symtab): Delete.
8 (last_displayed_line): Delete.
9 (class last_displayed_symtab_info_type): New.
10 (last_displayed_symtab_info): New static global variable.
11 (print_frame_info): Call methods on last_displayed_symtab_info.
12 (clear_last_displayed_sal): Update header comment, and make use of
13 last_displayed_symtab_info.
14 (last_displayed_sal_is_valid): Likewise.
15 (get_last_displayed_pspace): Likewise.
16 (get_last_displayed_addr): Likewise.
17 (get_last_displayed_symtab): Likewise.
18 (get_last_displayed_line): Likewise.
19 (get_last_displayed_sal): Likewise.
20 * stack.h (clear_last_displayed_sal): Update header comment.
21 (last_displayed_sal_is_valid): Likewise.
22 (get_last_displayed_pspace): Likewise.
23 (get_last_displayed_addr): Likewise.
24 (get_last_displayed_symtab): Likewise.
25 (get_last_displayed_line): Likewise.
26 (get_last_displayed_sal): Likewise.
28 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
30 * stack.c (frame_show_address): Convert return type to bool.
31 * stack.h (frame_show_address): Likewise, and update header
34 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
36 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
37 * unittests/vec-utils-selftests.c: New file.
38 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
40 2019-11-10 Tom Tromey <tom@tromey.com>
42 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
43 (tui_highlight_win): Likewise.
44 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
45 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
46 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
47 Don't set can_highlight.
49 2019-11-10 Tom Tromey <tom@tromey.com>
51 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
52 Remove unused declaration.
54 2019-11-08 Tom Tromey <tromey@adacore.com>
56 * top.c (read_command_file): Update.
57 (command_line_input): Make return type const.
58 * python/py-gdb-readline.c: Update.
59 * linespec.c (decode_line_2): Update.
60 * defs.h (command_line_input): Make return type const.
61 * cli/cli-script.c (read_next_line): Make return type const.
62 * ada-lang.c (get_selections): Update.
64 2019-11-06 Christian Biesinger <cbiesinger@google.com>
66 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
67 * mi/mi-main.c (output_cores): Likewise.
68 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
69 (linux_xfer_osdata_modules): Likewise.
70 * remote.c (register_remote_support_xml): Likewise.
71 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
72 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
74 2019-11-06 Tom Tromey <tom@tromey.com>
76 * tui/tui-interp.c: Don't include readline.h.
77 * tui/tui-hooks.c: Don't include readline.h.
78 * symmisc.c: Include tilde.h, not readline.h.
79 * symfile.c: Include tilde.h, not readline.h.
80 * source.c: Include tilde.h, not readline.h.
81 * solib.c: Include tilde.h, not readline.h.
82 * psymtab.c: Include tilde.h, not readline.h.
83 * exec.c: Include tilde.h, not readline.h.
84 * corelow.c: Include tilde.h, not readline.h.
85 * cli/cli-dump.c: Include tilde.h, not readline.h.
86 * cli/cli-cmds.c: Don't include readline.h.
88 2019-11-05 Tom Tromey <tom@tromey.com>
90 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
91 (tui_disassemble): Set addr_size.
92 (tui_disasm_window::set_contents): Use addr_size.
94 2019-11-05 Tom Tromey <tom@tromey.com>
96 * rust-lang.c (rust_language_defn): Update.
97 * python/py-value.c (valpy_string): Call c_get_string.
98 * p-lang.c (pascal_language_defn): Update.
99 * opencl-lang.c (opencl_language_defn): Update.
100 * objc-lang.c (objc_language_defn): Update.
101 * m2-lang.c (m2_language_defn): Update.
102 * language.c (unknown_language_defn, auto_language_defn): Update.
103 (default_get_string): Remove.
104 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
105 * go-lang.c (go_language_defn): Update.
106 * f-lang.c (f_language_defn): Update.
107 * d-lang.c (d_language_defn): Update.
108 * c-lang.c (c_language_defn, cplus_language_defn)
109 (asm_language_defn, minimal_language_defn): Update.
110 * ada-lang.c (ada_language_defn): Update.
111 * language.h (struct language_defn) <la_get_string>: Remove.
112 (LA_GET_STRING): Remove.
113 (default_get_string): Don't declare.
115 2019-11-05 Tom Tromey <tom@tromey.com>
117 * tui/tui-source.h (struct tui_source_window): Inline
118 constructor. Remove destructor.
119 <style_changed, m_observable>: Move to superclass.
120 * tui/tui-winsource.h (tui_copy_source_line): Declare.
121 (struct tui_source_window_base): Move private members to end.
122 <style_changed, m_observable>: Move from tui_source_window.
123 * tui/tui-winsource.c (tui_copy_source_line): Move from
124 tui-source.c. Rename from copy_source_line. Add special handling
125 for negative line number.
126 (tui_source_window_base::style_changed): Move from
128 (tui_source_window_base): Register observer.
129 (~tui_source_window_base): New.
130 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
132 (tui_source_window::set_contents): Use tui_copy_source_line.
133 (tui_source_window::tui_source_window): Move to tui-source.h.
134 (tui_source_window::~tui_source_window): Remove.
135 (tui_source_window::style_changed): Move to superclass.
136 * tui/tui-disasm.c (tui_disassemble): Create string file with
137 styling, when possible. Add "addr_size" parameter.
138 (tui_disasm_window::set_contents): Use tui_copy_source_line.
139 Don't compute maximum size.
140 (len_without_escapes): New function
142 2019-11-05 Tom Tromey <tom@tromey.com>
144 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
146 * tui/tui-winsource.c (tui_show_source_line): Update.
147 * tui/tui-source.c (tui_source_window::set_contents): Update.
148 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
150 2019-11-05 Christian Biesinger <cbiesinger@google.com>
152 * symtab.h (gdb_static_assert): Put && operator at the beginning
153 of the line instead of the end.
155 2019-11-04 Christian Biesinger <cbiesinger@google.com>
157 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
159 * symtab.h: Add a static_assert for sizeof (partial_symbol).
161 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
163 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
164 * configure.host: Mark *-*-solaris2.10* obsolete.
165 * configure.tgt: Mark Solaris < 11 obsolete.
166 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
167 Update target triplet.
169 2019-11-01 Tom Tromey <tromey@adacore.com>
171 * utils.c (print_sys_errmsg): Simplify.
173 2019-11-01 Tom Tromey <tromey@adacore.com>
175 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
177 2019-11-01 Christian Biesinger <cbiesinger@google.com>
179 * configure: Regenerate.
180 * configure.ac: Remove check for strerror_r.
181 * gdbsupport/common.m4: Check for strerror_r.
183 2019-11-01 Luis Machado <luis.machado@linaro.org>
187 * arm-tdep.c (arm_per_objfile): Rename to ...
188 (arm_per_bfd): ... this.
189 (arm_objfile_data_key): Rename to ...
190 (arm_bfd_data_key): ... this.
191 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
193 (arm_record_special_symbol): Likewise.
195 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
197 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
199 * c-typeprint.c (c_print_typedef): Likewise.
200 * f-typeprint.c (f_print_typedef): Likewise.
201 * m2-typeprint.c (m2_print_typedef): Likewise.
202 * p-typeprint.c (pascal_print_typedef): Likewise.
203 * rust-lang.c (rust_print_typedef): Likewise.
204 * symtab.c (print_symbol_info): Print a newline after calling
207 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
209 * symtab.c (info_module_cmdlist): New variable.
210 (info_module_command): New function.
211 (search_module_symbols): New function.
212 (info_module_subcommand): New function.
213 (struct info_modules_var_func_options): New struct.
214 (info_modules_var_func_options_defs): New variable.
215 (make_info_modules_var_func_options_def_group): New function.
216 (info_module_functions_command): New function.
217 (info_module_variables_command): New function.
218 (info_module_var_func_command_completer): New function.
219 (_initialize_symtab): Register new 'info module functions' and
220 'info module variables' commands.
221 * symtab.h (typedef symbol_search_in_module): New typedef.
222 (search_module_symbols): Declare new function.
223 * NEWS: Mention new commands.
225 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
227 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
228 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
229 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
231 (scan_partial_symbols): Only create partial module symbols for non
233 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
235 * symtab.c (search_domain_name): Likewise.
236 (search_symbols): Likewise.
237 (print_symbol_info): Likewise.
238 (symtab_symbol_info): Likewise.
239 (info_modules_command): New function.
240 (_initialize_symtab): Register 'info modules' command.
241 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
242 * NEWS: Mention new 'info modules' command.
244 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
246 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
247 and $_gdb_maint_setting_str.
249 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
251 * cli/cli-cmds.c (setting_cmd, value_from_setting)
252 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
253 (str_value_from_setting, gdb_setting_str_internal_fn)
254 (gdb_maint_setting_str_internal_fn): New functions.
255 (_initialize_cli_cmds): Define the new convenience functions.
256 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
257 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
259 2019-10-31 Christian Biesinger <cbiesinger@google.com>
261 * agent.c (set_can_use_agent): When the setting is turned on,
262 look up agent symbols if we don't have them yet.
263 (agent_new_objfile): Don't look up agent symbols when the agent
266 2019-10-31 Christian Biesinger <cbiesinger@google.com>
268 * config.in: Regenerate.
270 2019-10-31 Christian Biesinger <cbiesinger@google.com>
272 * configure: Regenerate.
273 * configure.ac: Check for strerror_r.
274 * gdbsupport/common-utils.h (safe_strerror): Change return value
275 to const char * and document that this function is now threadsafe.
276 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
277 thread_local and call strerror_r, if available.
278 * utils.c (perror_string): Update.
279 (print_sys_errmsg): Update.
281 2019-10-31 Luis Machado <luis.machado@linaro.org>
283 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
285 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
286 objfile to fetch per-bfd data.
287 (arm_find_exidx_entry): Likewise.
289 2019-10-31 Christian Biesinger <cbiesinger@google.com>
291 * gdbsupport/agent.c (debug_agent): Change type to bool.
292 (use_agent): Likewise.
293 (all_agent_symbols_look_up): Likewise.
294 (agent_loaded_p): Change return value to bool.
295 (agent_look_up_symbols): Update.
296 (agent_capability_check): Change return value to bool.
297 * gdbsupport/agent.h (agent_loaded_p): Likewise.
298 (debug_agent): Change type to bool.
299 (use_agent): Likewise.
300 (agent_capability_check): Change return value to bool.
302 2019-10-30 Christian Biesinger <cbiesinger@google.com>
304 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
305 (build_minimal_symbol_hash_tables): Code to clear the table moved
306 to clear_minimal_symbol_hash_tables.
307 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
310 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
312 * infcmd.c: Remove includes.
313 * infrun.c: Remove includes.
315 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
317 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
318 (grow_vect): Remove declaration.
319 (ada_type_of_array): Remove declaration.
320 (ada_update_initial_language): Remove declaration.
321 (ada_fold_name): Remove declaration.
322 (ada_fill_in_ada_prototype): Remove declaration.
323 (user_select_syms): Remove declaration.
324 (get_selections): Remove declaration.
325 (ada_tag_type): Remove declaration.
326 (ada_value_tag): Remove declaration.
327 (ada_is_others_clause): Remove declaration.
328 (ada_in_variant): Remove declaration.
329 (ada_value_struct_elt): Remove declaration.
330 (ada_attribute_name): Remove declaration.
331 (ada_system_address_type): Remove declaration.
332 * ada-lang.c (ada_watch_location_expression): Make static.
333 (GROW_VECT): Move here from ada-lang.h.
334 (grow_vect): Make static.
335 (ada_update_initial_language): Make static.
336 (ada_fold_name): Make static.
337 (ada_type_of_array): Make static.
338 (encoded_ordered_before): Move up.
339 (sort_choices): Move up.
340 (print_signatures): Move up.
341 (ada_print_symbol_signature): Move up.
342 (get_selections): Move up and make static.
343 (user_select_syms): Move up and make static.
344 (ada_value_struct_elt): Move up and make static.
345 (ada_tag_type): Make static.
346 (ada_value_tag): Make static.
347 (ada_is_others_clause): Make static.
348 (ada_in_variant): Make static.
349 (ada_attribute_name): Make static.
351 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
353 * ada-lang.c: Remove includes.
354 * ada-typeprint.c: Remove includes.
355 * ada-valprint.c: Remove includes.
357 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
359 * addrmap.c: Add static assertions of type size, moved from
361 (_initialize_addrmap): Remove.
363 2019-10-29 Christian Biesinger <cbiesinger@google.com>
365 * coffread.c (record_minimal_symbol): Update.
366 (process_coff_symbol): Update.
367 * dbxread.c (read_dbx_symtab): Update.
368 * dwarf2read.c (add_partial_symbol): Update.
369 (fixup_go_packaging): Update.
370 (load_partial_dies): Update.
371 (new_symbol): Update.
372 * elfread.c (record_minimal_symbol): Change signature to use
373 gdb::string_view instead of name+len.
374 (elf_symtab_read): Update.
375 (elf_rel_plt_read): Update.
376 * mdebugread.c (parse_partial_symbols): Update.
377 (handle_psymbol_enumerators): Update.
378 (new_symbol): Update.
379 * minsyms.c (minimal_symbol_reader::record_full): Change signature
380 to use gdb::string_view instead of name+len.
381 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
382 * psympriv.h (add_psymbol_to_list): Likewise.
383 * psymtab.c (add_psymbol_to_bcache): Likewise.
384 (add_psymbol_to_list): Likewise.
385 * stabsread.c (define_symbol): Update.
386 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
387 * symtab.h (SYMBOL_SET_NAMES): Likewise.
388 (symbol_set_names): Likewise.
389 * xcoffread.c (scan_xcoff_symtab): Update.
391 2019-10-29 Christian Biesinger <cbiesinger@google.com>
393 * symtab.h (symbol_set_names): Document that copy_name must be
394 set to true for non-nullterminated strings.
395 * symtab.c (symbol_set_names): Only make a nullterminated copy of
396 linkage_name if the entry was not found and we need to demangle.
398 2019-10-29 Christian Biesinger <cbiesinger@google.com>
400 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
401 * dwarf2-frame.c (bsearch_fde_cmp): Update.
402 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
403 * gdbsupport/gdb_binary_search.h: New file.
405 2019-10-29 Christian Biesinger <cbiesinger@google.com>
407 * NEWS: Mention new --with-system-gdbinit-dir option.
408 * config.in: Regenerate.
409 * configure: Regenerate.
410 * configure.ac: Add new option --with-system-gdbinit-dir.
411 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
413 * main.c (get_init_files): Change system_gdbinit argument to
414 a vector and return the files in SYSTEM_GDBINIT_DIR in
415 addition to SYSTEM_GDBINIT.
416 (captured_main_1): Update.
417 (print_gdb_help): Update.
418 * top.c (print_gdb_configuration): Also print the value of
421 2019-10-28 Christian Biesinger <cbiesinger@google.com>
423 * gdbsupport/common-utils.h (startswith): Add an overloaded version
424 that takes gdb::string_view arguments.
426 2019-10-26 Tom de Vries <tdevries@suse.de>
428 * aarch64-linux-tdep.c: Fix typos in comments.
429 * aarch64-tdep.c: Same.
433 * arch/aarch64-insn.c: Same.
435 * breakpoint.h: Same.
438 * cli/cli-decode.c: Same.
439 * cli/cli-script.c: Same.
440 * cli/cli-utils.h: Same.
441 * coff-pe-read.c: Same.
443 * compile/compile-cplus-symbols.c: Same.
444 * compile/compile-object-run.c: Same.
447 * cp-support.c: Same.
449 * dwarf-index-write.c: Same.
450 * dwarf2-frame.c: Same.
451 * dwarf2-frame.h: Same.
453 * frame-base.h: Same.
458 * guile/scm-objfile.c: Same.
467 * mi/mi-cmd-disas.c: Same.
468 * mi/mi-getopt.h: Same.
469 * mi/mi-main.c: Same.
471 * nat/aarch64-sve-linux-sigcontext.h: Same.
473 * ppc-linux-nat.c: Same.
474 * ppc-linux-tdep.c: Same.
477 * prologue-value.h: Same.
478 * python/py-evtregistry.c: Same.
479 * python/py-instruction.h: Same.
480 * record-btrace.c: Same.
481 * record-full.c: Same.
483 * rs6000-tdep.c: Same.
485 * sol-thread.c: Same.
486 * sparc-sol2-tdep.c: Same.
487 * sparc64-tdep.c: Same.
492 * tracepoint.c: Same.
493 * tui/tui-data.h: Same.
494 * tui/tui-io.c: Same.
495 * tui/tui-win.c: Same.
497 * unittests/rsp-low-selftests.c: Same.
509 * xtensa-tdep.c: Same.
511 2019-10-25 Ali Tamur <tamur@google.com>
513 * charset.c (find_charset_names): Reflect API change.
515 2019-10-25 Christian Biesinger <cbiesinger@google.com>
517 * symtab.c (struct demangled_name_entry): Change demangled name
518 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
519 part of the struct anymore.
520 (symbol_set_names): No longer obstack allocate + copy the demangled
521 name, just store the allocated name from bfd.
523 2019-10-25 Tom Tromey <tromey@adacore.com>
525 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
526 (bsearch_cie_cmp, add_cie): Remove.
527 (find_cie): Reimplement.
528 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
529 (dwarf2_build_frame_info): Update.
531 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
534 * symfile.c (reread_symbols): Call forget_cached_source_info to
535 clear the stale source cache.
537 2019-10-24 Christian Biesinger <cbiesinger@google.com>
539 * configure: Regenerate.
540 * configure.ac: Remove code that sets python_has_threads.
542 2019-10-24 Christian Biesinger <cbiesinger@google.com>
544 * config.in: Regenerate.
545 * configure: Regenerate.
546 * configure.ac: Remove the code that uses sed to get the python
547 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
549 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
551 * python/py-progspace.c (pspy_block_for_pc): Return None for all
554 2019-10-23 Tom Tromey <tom@tromey.com>
556 * arc-tdep.c: Remove ".." from include.
557 * frv-tdep.c: Remove ".." from include.
558 * lm32-tdep.c: Remove ".." from include.
559 * microblaze-tdep.c: Remove ".." from include.
560 * or1k-tdep.h: Remove ".." from include.
561 * s12z-tdep.c: Remove ".." from include.
562 * Makefile.in (OPCODES_CFLAGS): Add comment.
563 (TOP_CFLAGS): New variable.
564 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
566 2019-10-23 Tom Tromey <tom@tromey.com>
568 * Makefile.in (READLINE_DIR): Update.
570 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
572 * infcall.c (call_function_by_hand_dummy): Fix the function
573 comment. And extract out a code section into...
574 (reserve_stack_space): ...this new function.
576 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
578 * infcall.c (value_arg_coerce): Remove an unused parameter.
579 (call_function_by_hand_dummy): Update the call to
582 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
584 * infcall.c (call_function_by_hand_dummy): Refactor.
586 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
588 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
590 2019-10-23 Tom Tromey <tom@tromey.com>
592 * configure: Rebuild.
593 * configure.ac: Don't check for sigprocmask.
594 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
596 2019-10-23 Tom Tromey <tom@tromey.com>
598 * configure: Rebuild.
599 * acinclude.m4: Use m4_include, not sinclude.
601 2019-10-23 Tom de Vries <tdevries@suse.de>
604 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
606 2019-10-22 Christian Biesinger <cbiesinger@google.com>
608 * symtab.c (struct demangled_name_entry) <language>: Change from
609 bitfield to regular variable.
611 2019-10-22 Christian Biesinger <cbiesinger@google.com>
613 * symtab.c (struct demangled_name_entry): Add a constructor.
614 (free_demangled_name_entry): New function to call the destructor
615 for demangled_name_entry.
616 (create_demangled_names_hash): Pass free_demangled_name_entry to
618 (symbol_set_names): Call placement new for demangled_name_entry.
619 * utils.c: No longer include xxhash.h here, now that fast_hash
620 is inlined in the header.
621 * utils.h: Instead, include it here.
623 2019-10-22 Christian Biesinger <cbiesinger@google.com>
625 * Makefile.in: Link with libxxhash.
626 * config.in: Regenerate.
627 * configure: Regenerate.
628 * configure.ac: Search for libxxhash.
629 * utils.c (fast_hash): Use xxhash if present.
631 2019-10-22 Christian Biesinger <cbiesinger@google.com>
633 * utils.h (fast_hash): New function.
634 * symtab.c (hash_demangled_name_entry): Call new function
637 2019-10-22 Christian Biesinger <cbiesinger@google.com>
639 * symtab.c (struct demangled_name_entry): Change type of mangled
640 to gdb::string_view. Also adds a constructor that takes the
642 (hash_demangled_name_entry): Update.
643 (eq_demangled_name_entry): Update.
644 (free_demangled_name_entry): New function to call the destructor
645 now that this is not a POD anymore.
646 (create_demangled_names_hash): Pass free_demangled_name_entry to
648 (symbol_set_names): Update.
650 2019-10-21 Ali Tamur <tamu@google.com>
652 * dwarf2read.c (dir_index): Change type.
653 (file_name_index): Likewise.
654 (line_header::include_dir_at): Change comment and implementation on
655 whether it is DWARF 5.
656 (line_header::is_valid_file_index): New function.
657 (line_header::file_name_at): Change comment and implementation on
658 whether it is DWARF 5.
659 (line_header::file_names): Change to private field renamed as
660 m_file_names and introduce a new accessor method.
661 (line_header::file_names_size): New method.
662 (line_header::include_dirs): Change to private field and rename as
664 (dw2_get_file_names_reader): Define local var at a smaller scope and
666 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
667 (process_structure_scope): Likewise.
668 (line_header::add_include_dir): Change message and reflect renaming.
669 (line_header::add_file_name): Likewise.
670 (read_formatted_entries): Handle DW_FORM_data16.
671 (dwarf_decode_line_header): Fix line header length calculation.
672 (psymtab_include_file_name): Change comment and API.
673 (lnp_state_machine::m_file): Update comment and reflect type change.
674 (lnp_state_machine::record_line): Reflect type change.
675 (dwarf_decode_lines): Reflect API change.
676 (file_file_name): Likewise.
677 (file_full_name): Likewise.
679 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
681 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
683 2019-10-21 Tom Tromey <tom@tromey.com>
685 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
687 2019-10-21 Tom Tromey <tom@tromey.com>
689 * configure.ac (nm.h): Conditionally create nm.h link. Subst
690 NM_H. Use AC_CONFIG_LINKS.
691 * configure: Rebuild.
692 * Makefile.in (NM_H): New variable.
693 (generated_files): Add NM_H. Remove gcore.
694 (nm.h, stamp-nmh): New targets.
696 2019-10-20 Tom Tromey <tom@tromey.com>
698 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
699 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
701 (put_objfile_before): Now static.
703 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
705 * gdbsupport/common-utils.h (startswith): Change return type to
708 2019-10-19 Christian Biesinger <cbiesinger@google.com>
710 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
711 * breakpoint.c (bp_locations_compare): Rename to...
712 (bp_location_is_less_than): ...this, and change to std::sort semantics.
713 (update_global_location_list): Use std::sort instead of qsort.
714 * buildsym.c (compare_line_numbers): Rename to...
715 (lte_is_less_than): ...this, and change to std::sort semantics.
716 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
718 * disasm.c (compare_lines): Rename to...
719 (line_is_less_than): ...this, and change to std::sort semantics.
720 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
722 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
723 (fde_is_less_than): ...this, and change to std::sort semantics.
724 (dwarf2_build_frame_info): Call std::sort instead of qsort.
725 * mdebugread.c (compare_blocks):
726 (block_is_less_than): ...this, and change to std::sort semantics.
727 (sort_blocks): Call std::sort instead of qsort.
728 * objfiles.c (qsort_cmp): Rename to...
729 (sort_cmp): ...this, and change to std::sort semantics.
730 (update_section_map): Call std::sort instead of qsort.
731 * remote.c (compare_pnums): Remove.
732 (map_regcache_remote_table): Call std::sort instead of qsort.
733 * utils.c (compare_positive_ints): Remove.
734 * utils.h (compare_positive_ints): Remove.
735 * xcoffread.c (compare_lte): Remove.
736 (arrange_linetable): Call std::sort instead of qsort.
738 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
740 * symfile.c (init_entry_point_info): Fix typo.
741 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
743 2019-10-18 Tom de Vries <tdevries@suse.de>
745 * aarch64-tdep.c: Fix typos in comments.
748 * alpha-tdep.c: Same.
749 * alpha-tdep.h: Same.
751 * amd64-windows-tdep.c: Same.
754 * arch-utils.c: Same.
755 * arm-nbsd-tdep.c: Same.
758 * blockframe.c: Same.
761 * coff-pe-read.c: Same.
764 * darwin-nat.c: Same.
768 * dtrace-probe.c: Same.
769 * dwarf-index-write.c: Same.
770 * dwarf2-frame-tailcall.c: Same.
771 * dwarf2-frame.c: Same.
772 * dwarf2read.c: Same.
774 * exceptions.c: Same.
779 * gnu-v3-abi.c: Same.
781 * h8300-tdep.c: Same.
783 * i386-linux-tdep.c: Same.
785 * ia64-libunwind-tdep.c: Same.
791 * linux-thread-db.c: Same.
793 * mdebugread.c: Same.
795 * mn10300-tdep.c: Same.
798 * opencl-lang.c: Same.
801 * ppc-linux-nat.c: Same.
802 * ppc-linux-tdep.c: Same.
803 * ppc-sysv-tdep.c: Same.
806 * record-btrace.c: Same.
807 * record-full.c: Same.
808 * remote-fileio.c: Same.
810 * rs6000-tdep.c: Same.
812 * score-tdep.c: Same.
816 * sol-thread.c: Same.
817 * solib-svr4.c: Same.
821 * sparc-sol2-tdep.c: Same.
822 * sparc-tdep.c: Same.
823 * sparc64-tdep.c: Same.
828 * target-descriptions.c: Same.
829 * target-float.c: Same.
836 * windows-nat.c: Same.
838 * xstormy16-tdep.c: Same.
839 * xtensa-tdep.c: Same.
841 2019-10-17 Tom Tromey <tromey@adacore.com>
843 * configure: Rebuild.
844 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
845 in AC_CONFIG_FILES invocation.
846 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
847 new-style config.status invocation.
849 2019-10-17 Tom de Vries <tdevries@suse.de>
851 * arm-nbsd-nat.c: Fix typos in comments.
853 * darwin-nat-info.c: Same.
854 * dwarf2read.c: Same.
863 * mdebugread.c: Same.
864 * moxie-tdep.c: Same.
865 * nto-procfs.c: Same.
867 * ppc-linux-tdep.c: Same.
869 * riscv-tdep.c: Same.
872 * sparc-linux-tdep.c: Same.
875 * target-descriptions.c: Same.
879 2019-10-16 Tom Tromey <tom@tromey.com>
881 * objfiles.h (struct objfile) <original_name>: Now const.
883 2019-10-16 Christian Biesinger <cbiesinger@google.com>
885 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
886 pass on to sigsetjmp's second argument.
887 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
889 2019-10-16 Keith Seitz <keiths@redhat.com>
892 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
893 sections whose size is greater than the file size.
895 2019-10-16 Jim Wilson <jimw@sifive.com>
897 * riscv-tdep.c (riscv_gcc_target_options): New.
898 (riscv_gnu_triplet_regexp): New.
899 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
900 set_gdbarch_gnu_triplet_regexp.
902 2019-10-16 Christian Biesinger <cbiesinger@google.com>
904 * Makefile.in: Add xml-builtin.h.
905 * features/feature_to_c.sh: Add an include for xml-builtin.h
906 to ensure that the compiler checks that the types match.
907 * xml-builtin.h: New file.
908 * xml-support.c (fetch_xml_builtin): Add missing const.
909 * xml-support.h: Remove declaration of xml_builtins.
911 2019-10-16 Tom de Vries <tdevries@suse.de>
914 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
915 (amd64_classify_aggregate): ... here.
916 (amd64_classify_aggregate_field): Handled fiels of nested structs
919 2019-10-16 Tom de Vries <tdevries@suse.de>
922 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
923 that handles 'theclass'.
925 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
927 * linespec.c (decode_digits_ordinary): Update comment.
928 * make-target-delegates: No longer need to handle VEC case.
929 * memrange.c (normalize_mem_ranges): Update comment.
930 * namespace.c (add_using_directive): Update comment.
931 * objc-lang.c (uniquify_strings): Update comment.
932 * ppc-linux-nat.c (struct thread_points): Update comment.
933 * probe.h (find_probes_in_objfile): Update comment.
934 * target.h (enum flash_preserve_mode): Update comment.
935 * varobj.c (varobj_restrict_range): Update comment.
936 * varobj.h (varobj_list_children): Update comment.
938 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
940 * Makefile.in: Remove references to vec.h and vec.c.
941 * aarch64-tdep.c: No longer include vec.h.
942 * ada-lang.c: Likewise.
943 * ada-lang.h: Likewise.
944 * arm-tdep.c: Likewise.
946 * breakpoint.h: Likewise.
947 * charset.c: Likewise.
948 * cp-support.h: Likewise.
949 * dtrace-probe.c: Likewise.
950 * dwarf2read.c: Likewise.
951 * extension.h: Likewise.
952 * gdb_bfd.c: Likewise.
953 * gdbsupport/gdb_vecs.h: Likewise.
954 * gdbsupport/vec.c: Remove.
955 * gdbsupport/vec.h: Remove.
956 * gdbthread.h: Likewise.
957 * guile/scm-type.c: Likewise.
958 * inline-frame.c: Likewise.
959 * machoread.c: Likewise.
960 * memattr.c: Likewise.
961 * memrange.h: Likewise.
962 * namespace.h: Likewise.
963 * nat/linux-btrace.h: Likewise.
964 * osdata.c: Likewise.
965 * parser-defs.h: Likewise.
966 * progspace.h: Likewise.
967 * python/py-type.c: Likewise.
968 * record-btrace.c: Likewise.
969 * rust-exp.y: Likewise.
970 * solib-target.c: Likewise.
971 * stap-probe.c: Likewise.
972 * target-descriptions.c: Likewise.
973 * target-memory.c: Likewise.
974 * target.h: Likewise.
975 * varobj.c: Likewise.
976 * varobj.h: Likewise.
977 * xml-support.h: Likewise.
979 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
981 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
982 Update for new std::vector based implementation.
983 (process_psymtab_comp_unit_reader): Likewise.
984 (scan_partial_symbols): Likewise.
985 (recursively_compute_inclusions): Likewise.
986 (compute_compunit_symtab_includes): Likewise.
987 (process_imported_unit_die): Likewise.
988 (queue_and_load_dwo_tu): Likewise.
989 (follow_die_sig_1): Likewise.
990 * gdb/dwarf2read.h: Remove DEF_VEC_P.
991 (typedef dwarf2_per_cu_ptr): Remove.
992 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
994 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
995 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
996 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
997 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1000 2019-10-15 Tom Tromey <tromey@adacore.com>
1002 * windows-nat.c (windows_nat_target::resume): Use %x when logging
1005 2019-10-15 Tom Tromey <tromey@adacore.com>
1007 * windows-nat.c (windows_nat_target::fetch_registers)
1008 (windows_nat_target::store_registers): Rename "pid" to "tid".
1010 2019-10-15 Tom Tromey <tromey@adacore.com>
1012 * gdbarch.h, gdbarch.c: Rebuild.
1013 * gdbarch.sh (gcc_target_options): Change return type to
1015 * compile/compile.c (get_args): Update.
1016 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1017 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1019 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1021 * arch-utils.c (default_gcc_target_options): Return std::string.
1022 * arch-utils.h (default_gcc_target_options): Return std::string.
1023 * s390-tdep.c (s390_gcc_target_options): Return std::string.
1025 2019-10-15 Christian Biesinger <cbiesinger@google.com>
1027 * breakpoint.c (breakpoint_chain): Make static.
1028 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1029 of accessing breakpoint_chain.
1031 2019-10-15 Christian Biesinger <cbiesinger@google.com>
1033 * breakpoint.c (iterate_over_breakpoints): Change function pointer
1034 to a gdb::function_view and return value to bool.
1035 * breakpoint.h (iterate_over_breakpoints): Likewise.
1036 * dummy-frame.c (pop_dummy_frame_bpt): Update.
1037 (pop_dummy_frame): Update.
1038 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1039 (gdbscm_breakpoints): Update.
1040 * python/py-breakpoint.c (build_bp_list): Update.
1041 (gdbpy_breakpoints): Update.
1042 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1044 (bpfinishpy_handle_stop): Update.
1045 (bpfinishpy_handle_exit): Update.
1046 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1047 (svr4_update_solib_event_breakpoints): Update.
1049 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
1051 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1052 when unwrapping single-field structs.
1054 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
1056 * dwarf2read.c: Remove includes.
1058 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
1060 * ui-out.c (ui_out::call_do_message): Silence
1061 -Wformat-nonliteral warning.
1063 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
1065 * breakpoint.c: Remove some includes: continuations.h, skip.h,
1066 mi/mi-main.h, readline/readline.h, readline/history.h. Add
1067 include: readline/tilde.h.
1069 2019-10-12 Christian Biesinger <cbiesinger@google.com>
1071 * remote.c (remote_target::get_trace_status): Remove declaration of
1072 trace_regblock_size.
1074 2019-10-12 Christian Biesinger <cbiesinger@google.com>
1076 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1077 (show_user): Remove declaration of cmdlist.
1078 * cli/cli-cmds.h (max_user_call_depth): Declare.
1079 * cli/cli-script.c (execute_user_command): Remove declaration
1080 of max_user_call_depth.
1082 2019-10-11 Jim Wilson <jimw@sifive.com>
1084 * gdbsupport/print-utils.h (pulongest): Fix comment.
1085 (plongest): Likewise.
1086 (phex): Add missing comment, mention leading zeros.
1087 (phex_nz): Add mention of no leading zeros to comment.
1089 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1090 plongest instead of unsigned long long cast.
1092 2019-10-10 Christian Biesinger <cbiesinger@google.com>
1094 * main.c (captured_main_1): Include gdbtk.h and remove declarations
1095 for external_editor_command and gdbtk_test.
1097 2019-10-10 Christian Biesinger <cbiesinger@google.com>
1099 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1100 * varobj.c (varobjdebug): Move comment to...
1101 * varobj.h (varobjdebug): ...here, and declare.
1103 2019-10-09 Tom Tromey <tom@tromey.com>
1105 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1108 2019-10-09 Tom Tromey <tom@tromey.com>
1110 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1111 * tui/tui-stack.c (tui_locator_window::rerender): Update.
1112 * tui/tui-command.c (tui_cmd_window::resize)
1113 (tui_refresh_cmd_win): Update.
1114 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1115 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1116 * tui/tui-data.c (~tui_gen_win_info): Remove.
1117 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1118 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1119 (tui_redisplay_readline, tui_mld_flush)
1120 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1121 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1122 (tui_data_window::erase_data_content)
1123 (tui_data_item_window::rerender)
1124 (tui_data_item_window::refresh_window): Update.
1125 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1126 (box_win, tui_gen_win_info::make_window)
1127 (tui_gen_win_info::make_visible): Update.
1128 (tui_delete_win): Remove.
1129 * tui/tui-winsource.c
1130 (tui_source_window_base::do_erase_source_content): Update.
1131 (tui_show_source_line, tui_source_window_base::update_tab_width)
1132 (tui_source_window_base::update_exec_info): Update.
1133 * tui/tui-data.h (struct curses_deleter): New.
1134 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1135 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1137 2019-10-09 Tom Tromey <tom@tromey.com>
1139 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1141 2019-10-09 Tom Tromey <tom@tromey.com>
1143 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1144 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1146 2019-10-09 Tom Tromey <tom@tromey.com>
1148 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1149 window height directly.
1150 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1152 * tui/tui-layout.c (tui_default_win_height): Remove.
1153 (tui_default_win_viewport_height): Remove.
1155 2019-10-09 Tom Tromey <tom@tromey.com>
1157 * tui/tui.h: Remove comments.
1159 2019-10-09 Tom de Vries <tdevries@suse.de>
1161 * python/lib/gdb/printer/bound_registers.py: Use
1162 '^builtin_type_bound128' as regexp argument for
1163 add_builtin_pretty_printer.
1165 2019-10-09 Christian Biesinger <cbiesinger@google.com>
1167 * guile/guile.c (guile_extension_script_ops): Remove forward
1168 declaration and mark as static.
1169 (guile_script_ops): Likewise.
1170 (extension_language_guile): Move further down in the file so
1171 it can reference the definitions for guile_{extension_,}script_ops.
1173 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
1175 * s390-tdep.c (390_process_record): Handle new arch13 instructions
1176 except SORTL, DFLTCC, and KDSA.
1178 2019-10-08 Tom Tromey <tromey@adacore.com>
1180 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1181 (struct safe_symbol_file_add_args): Remove.
1183 2019-10-08 Tom Tromey <tromey@adacore.com>
1185 * windows-nat.c: Don't include buildsym-legacy.h.
1187 2019-10-08 Tom Tromey <tromey@adacore.com>
1189 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1191 2019-10-08 Christian Biesinger <cbiesinger@google.com>
1193 * gdbtypes.c (overload_debug): Move comment to header.
1194 * gdbtypes.h (overload_debug): Declare.
1195 * valops.c: Remove declaration of overload_debug, instead
1198 2019-10-08 Christian Biesinger <cbiesinger@google.com>
1200 * language.c (show_language_command): Pass lang_frame_mismatch_warn
1202 (lang_frame_mismatch_warn): Make const, mark with N_(), and
1204 * language.h (lang_frame_mismatch_warn): ... here. Also add
1206 * top.c (lang_frame_mismatch_warn): Remove declaration.
1207 (check_frame_language_change): Pass lang_frame_mismatch_warn
1210 2019-10-07 Christian Biesinger <cbiesinger@google.com>
1212 * c-lang.h (vtbl_ptr_name): Declare.
1213 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1215 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1217 2019-10-07 Christian Biesinger <cbiesinger@google.com>
1219 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1222 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
1224 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1225 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1226 * ctfread.c: New file.
1227 * ctfread.h: New file.
1228 * elfread.c: Include ctfread.h.
1229 (struct elfinfo text_p): New member ctfsect.
1230 (elf_locate_sections): Mark CTF section.
1231 (elf_symfile_read): Call elfctf_build_psymtabs.
1232 * Makefile.in (LIBCTF): Add.
1235 (DIST): Add ctfread.c.
1237 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
1239 * ctfread.c (struct nextfield): Renamed to ...
1240 (struct ctf_nextfield): ... this.
1241 (struct field_info): Renamed to ...
1242 (strut ctf_field_info): ... this.
1243 (attach_fields_to_type): Update for renamed structures.
1244 (ctf_add_member_cb): Likewise.
1245 (ctf_add_enum_member_cb): Likewise.
1246 (process_struct_members): Likewise.
1247 (process_enum_type): Likewise.
1249 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
1251 * tracectf.h: Rename, was ctf.h.
1252 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1253 * tracefile.c: Likewise.
1254 * tracepoint.c: Remove unused include ctf.h.
1255 * mi/mi-main.c: Likewise.
1256 * Makefile.in Replace ctf.c with tracectf.c.
1258 2019-10-06 Joel Brobecker <brobecker@adacore.com>
1260 * version.in: Change version number to "9.0.50.DATE-git".
1262 2019-10-03 Tom Tromey <tom@tromey.com>
1265 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1267 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
1269 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1270 cp_search_name_hash.
1271 * NEWS: Add entry about nested function support.
1273 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
1274 Andrew Burgess <andrew.burgess@embecosm.com>
1276 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1277 for nested static variables when searchin VAR_DOMAIN.
1278 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1279 global scope, update comment.
1280 (add_partial_subprogram): Call add_partial_subprogram recursively
1281 for nested subroutines when processinng Fortran.
1282 (load_partial_dies): Process the child entities of a subprogram
1283 when processing Fortran.
1284 (partial_die_parent_scope): Handle building scope
1285 for Fortran nested functions.
1286 (process_die): Record that nested functions have a scope.
1287 (new_symbol): Always record Fortran subprograms on the global
1289 (determine_prefix): How to build the prefix for Fortran
1292 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
1294 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1295 have just sent the thread a SIGSTOP and are waiting for it to
1298 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
1300 * btrace.c (btrace_add_pc): Remove whitespace before the template
1301 parameter in 'std::vector <...>'.
1302 (parse_xml_btrace_block): Likewise.
1303 (btrace_maint_decode_pt): Likewise.
1304 (btrace_maint_update_packets): Likewise.
1305 (btrace_maint_print_packets): Likewise.
1306 * btrace.h (struct btrace_maint_info): Likewise.
1307 * dwarf2read.c (struct type_unit_group): Likewise.
1308 (build_type_psymtabs_reader): Likewise.
1309 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1310 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1311 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1313 2019-10-03 Tom de Vries <tdevries@suse.de>
1315 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1316 the first line of the help text for set/show style metadata.
1318 2019-10-02 Tom Tromey <tromey@adacore.com>
1320 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1321 * gdbsupport/common-inferior.c: New file.
1322 * infcmd.c (startup_with_shell): Don't define.
1323 * nat/fork-inferior.h (startup_with_shell): Don't declare.
1324 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1325 * inferior.h (startup_with_shell): Don't declare.
1327 2019-10-02 Christian Biesinger <cbiesinger@google.com>
1329 * gdbsupport/gdb_assert.h: Include errors.h.
1330 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1332 2019-10-02 Tom Tromey <tromey@adacore.com>
1334 * NEWS: Add $_ada_exception entry.
1335 * ada-lang.c (struct ada_catchpoint): Add constructor.
1336 <m_kind>: New member.
1337 (allocate_location_exception, re_set_exception): Remove
1339 (should_stop_exception): Compute $_ada_exception.
1340 (check_status_exception, print_it_exception)
1341 (print_one_exception, print_mention_exception): Remove
1343 (allocate_location_catch_exception, re_set_catch_exception)
1344 (check_status_exception, print_it_catch_exception)
1345 (print_one_catch_exception, print_mention_catch_exception)
1346 (print_recreate_catch_exception)
1347 (allocate_location_catch_exception_unhandled)
1348 (re_set_catch_exception_unhandled)
1349 (check_status_exception, print_it_catch_exception_unhandled)
1350 (print_one_catch_exception_unhandled)
1351 (print_mention_catch_exception_unhandled)
1352 (print_recreate_catch_exception_unhandled)
1353 (allocate_location_catch_assert, re_set_catch_assert)
1354 (check_status_assert, print_it_catch_assert)
1355 (print_one_catch_assert, print_mention_catch_assert)
1356 (print_recreate_catch_assert)
1357 (allocate_location_catch_handlers, re_set_catch_handlers)
1358 (check_status_handlers, print_it_catch_handlers)
1359 (print_one_catch_handlers, print_mention_catch_handlers)
1360 (print_recreate_catch_handlers): Remove.
1361 (create_ada_exception_catchpoint): Update.
1362 (initialize_ada_catchpoint_ops): Update.
1364 2019-10-02 Tom Tromey <tromey@adacore.com>
1366 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1367 (create_excep_cond_exprs): Simplify exception string computation.
1368 (ada_exception_catchpoint_cond_string): Likewise.
1370 2019-10-02 Tom Tromey <tromey@adacore.com>
1372 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1373 * ada-lang.c (lesseq_defined_than): Handle
1375 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1377 (dwarf2_has_info): Likewise.
1378 (new_symbol): Set maybe_copied on symbol when
1380 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1382 <can_copy>: New member.
1383 * elfread.c (record_minimal_symbol): Set maybe_copied
1384 on symbol when appropriate.
1385 (elf_symfile_read): Update call to dwarf2_has_info.
1386 * minsyms.c (lookup_minimal_symbol_linkage): New
1388 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1389 * symtab.c (get_symbol_address, get_msymbol_address):
1391 * symtab.h (get_symbol_address, get_msymbol_address):
1393 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1395 (struct symbol, struct minimal_symbol) <maybe_copied>:
1398 2019-10-02 Tom Tromey <tromey@adacore.com>
1400 * source.c (struct current_source_location): New.
1401 (current_source_key): New global.
1402 (current_source_symtab, current_source_line)
1403 (current_source_pspace): Remove.
1404 (get_source_location): New function.
1405 (get_current_source_symtab_and_line)
1406 (set_default_source_symtab_and_line)
1407 (set_current_source_symtab_and_line)
1408 (clear_current_source_symtab_and_line, select_source_symtab)
1409 (info_source_command, print_source_lines_base)
1410 (info_line_command, search_command_helper, _initialize_source):
1413 2019-10-02 Tom Tromey <tromey@adacore.com>
1415 * source.c (select_source_symtab): Don't call
1416 decode_line_with_current_source.
1418 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
1420 * symtab.c (lookup_global_symbol): Search global block.
1422 2019-10-02 Tom Tromey <tromey@adacore.com>
1424 * coffread.c (process_coff_symbol): Update.
1425 * dwarf2read.c (var_decode_location, new_symbol): Update.
1426 * mdebugread.c (parse_symbol): Update.
1427 * objfiles.c (relocate_one_symbol): Update.
1428 * stabsread.c (define_symbol, fix_common_block)
1429 (scan_file_globals): Update.
1430 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1431 (SET_SYMBOL_VALUE_ADDRESS): New macro.
1432 * xcoffread.c (process_xcoff_symbol): Update.
1434 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
1436 * MAINTAINERS: Update my email address.
1438 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
1440 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1442 (build_type_psymtabs_reader): Update for std::vector.
1443 (build_type_psymtab_dependencies): Likewise.
1444 * dwarf2read.h: Remove use of DEF_VEC_P.
1445 (typedef sig_type_ptr): Delete.
1447 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
1449 * btrace.c (btrace_maint_clear): Update to handle change from VEC
1451 (btrace_maint_decode_pt): Likewise, and move allocation of the
1452 vector outside of the loop.
1453 (btrace_maint_update_packets): Update to handle change from VEC to
1455 (btrace_maint_print_packets): Likewise.
1456 (maint_info_btrace_cmd): Likewise.
1457 * btrace.h: Remove use of DEF_VEC_O.
1458 (typedef btrace_pt_packet_s): Delete.
1459 (struct btrace_maint_info) <packets>: Change fromm VEC to
1461 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1463 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
1465 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1466 make accesses into the vector constant references.
1467 (btrace_add_pc): Update for std::vector.
1468 (btrace_stitch_bts): Likewise.
1469 (parse_xml_btrace_block): Likewise.
1470 (btrace_maint_update_packets): Likewise.
1471 (btrace_maint_print_packets): Likewise.
1472 (maint_info_btrace_cmd): Likewise.
1473 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1475 (btrace_data::empty): Likewise.
1476 (btrace_data_append): Likewise.
1477 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1478 (typedef btrace_block_s): Delete.
1479 (struct btrace_block): Add constructor.
1480 (struct btrace_data_bts) <blocks>: Change to std::vector.
1481 * nat/linux-btrace.c (perf_event_read_bts): Update for
1483 (linux_read_bts): Likewise.
1485 2019-10-01 Tom Tromey <tom@tromey.com>
1487 * cli/cli-logging.c (show_logging_filename): Use styled_string.
1489 2019-10-01 Tom Tromey <tom@tromey.com>
1491 * stack.c (print_frame, info_frame_command_core): Use
1493 * linux-thread-db.c (try_thread_db_load_1)
1494 (try_thread_db_load_from_pdir_1): Use styled_string.
1495 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1496 (auto_load_section_scripts, info_auto_load_local_gdbinit)
1497 (maybe_print_unsupported_script_warning)
1498 (maybe_print_script_not_found_warning): Use styled_string.
1499 * ada-lang.c (user_select_syms): Use styled_string.
1501 2019-10-01 Tom Tromey <tom@tromey.com>
1503 * p-lang.c (pascal_printstr): Use metadata style.
1504 * value.c (show_convenience): Use metadata style.
1505 * valprint.c (valprint_check_validity, val_print_optimized_out)
1506 (val_print_not_saved, val_print_unavailable)
1507 (val_print_invalid_address, generic_val_print, val_print)
1508 (value_check_printable, val_print_array_elements): Use metadata
1510 * ui-out.h (class ui_out) <field_fmt>: New overload.
1511 <do_field_fmt>: Add style parameter.
1512 * ui-out.c (ui_out::field_fmt): New overload.
1513 * typeprint.c (type_print_unknown_return_type)
1514 (val_print_not_allocated, val_print_not_associated): Use metadata
1516 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1518 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1519 * tracepoint.c (tvariables_info_1): Use metadata style.
1520 * stack.c (print_frame_arg, print_frame_info, print_frame)
1521 (info_frame_command_core): Use metadata style.
1522 * skip.c (info_skip_command): Use metadata style.
1523 * rust-lang.c (rust_print_enum): Use metadata style.
1524 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1526 * python/py-framefilter.c (py_print_single_arg): Use metadata
1528 * printcmd.c (do_one_display, print_variable_and_value): Use
1530 * p-valprint.c (pascal_val_print)
1531 (pascal_object_print_value_fields): Use metadata style.
1532 * p-typeprint.c (pascal_type_print_base): Use metadata style.
1533 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1535 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1536 * m2-valprint.c (m2_print_long_set): Use metadata style.
1537 * m2-typeprint.c (m2_print_type): Use metadata style.
1538 * infcmd.c (print_return_value_1): Use metadata style.
1539 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1540 * f-valprint.c (info_common_command_for_block): Use metadata
1542 * f-typeprint.c (f_type_print_base): Use metadata style.
1543 * expprint.c (print_subexp_standard): Use metadata style.
1544 * cp-valprint.c (cp_print_value_fields): Use metadata style.
1545 * cli/cli-style.h (class cli_style_option): Add constructor.
1546 (metadata_style): Declare.
1547 * cli/cli-style.c (metadata_style): New global.
1548 (_initialize_cli_style): Register metadata style.
1549 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1551 * cli-out.c (cli_ui_out::do_field_fmt): Update.
1552 * c-typeprint.c (c_type_print_base_struct_union)
1553 (c_type_print_base_1): Use metadata style.
1554 * breakpoint.c (watchpoint_value_print)
1555 (print_one_breakpoint_location): Use metadata style.
1556 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1558 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1560 * ada-valprint.c (val_print_packed_array_elements, printstr)
1561 (print_field_values, ada_val_print_ref, ada_val_print): Use
1563 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1565 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1567 * ada-lang.c (user_select_syms): Use metadata style.
1569 2019-10-01 Tom Tromey <tom@tromey.com>
1571 * cli/cli-cmds.c (pwd_command): Style output.
1573 2019-10-01 Pedro Alves <palves@redhat.com>
1574 Tom Tromey <tom@tromey.com>
1576 * symtab.c (print_symbol_info): Use %ps.
1577 (print_msymbol_info): Use %ps.
1578 * symfile.c (symbol_file_add_with_addrs): Use %ps.
1579 * printcmd.c (print_variable_and_value): Use %ps.
1580 * macrocmd.c (show_pp_source_pos): Use %ps.
1581 * infrun.c (print_exited_reason): Use ui_out::message.
1582 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1583 (describe_other_breakpoints): Use ui_out::message and new
1585 (say_where): Use new formats.
1586 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1589 2019-10-01 Pedro Alves <palves@redhat.com>
1590 Tom Tromey <tom@tromey.com>
1592 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1593 (test_gdb_formats): New function.
1594 (run_tests): Call it.
1595 (test_format_specifier): Update.
1596 * utils.h (fputs_filtered): Update comment.
1597 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1598 (fputs_styled_unfiltered): Declare.
1599 * utils.c (fputs_styled_unfiltered): New function.
1600 (vfprintf_maybe_filtered): Add gdbfmt parameter.
1601 (vfprintf_filtered): Update.
1602 (vfprintf_unfiltered, vprintf_filtered): Update.
1603 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1604 * ui-out.h (enum ui_out_flag) <unfiltered_output,
1605 disallow_ui_out_field>: New constants.
1606 (enum class field_kind): New.
1607 (struct base_field_s, struct signed_field_s): New.
1608 (signed_field): New function.
1609 (struct string_field_s): New.
1610 (string_field): New function.
1611 (struct styled_string_s): New.
1612 (styled_string): New function.
1613 (class ui_out) <message>: Add comment.
1614 <vmessage, call_do_message>: New methods.
1615 <do_message>: Add style parameter.
1616 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1618 (ui_out::message): Rewrite.
1619 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1621 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1622 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1623 gdb_extensions parameter.
1624 (class format_piece): Add parameter to constructor.
1625 (n_int_args): New field.
1626 * gdbsupport/format.c (format_pieces::format_pieces): Add
1627 gdb_extensions parameter. Handle '*'.
1628 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1629 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
1630 vfprintf_styled_no_gdbfmt.
1631 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1632 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1634 * ui-style.h (struct ui_file_style) <ptr>: New method.
1636 2019-10-01 Tom Tromey <tom@tromey.com>
1638 * unittests/format_pieces-selftests.c: Update. Add final format.
1639 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1640 empty literal pieces.
1642 2019-10-01 Tom Tromey <tom@tromey.com>
1644 * ui-out.h (enum class ui_out_style_kind): Remove.
1645 (class ui_out) <field_string, field_stsream, do_field_string>:
1646 Change type of "style".
1647 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1648 (ui_out::field_string): Update.
1649 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1651 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1652 * tracepoint.c (print_one_static_tracepoint_marker): Update.
1653 * stack.c (print_frame_arg, print_frame_info, print_frame):
1655 * source.c (print_source_lines_base): Update.
1656 * solib.c (info_sharedlibrary_command): Update.
1657 * skip.c (info_skip_command): Update.
1658 * record-btrace.c (btrace_call_history_src_line)
1659 (btrace_call_history): Update.
1660 * python/py-framefilter.c (py_print_frame): Update.
1661 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1663 * mi/mi-out.c (mi_ui_out::do_table_header)
1664 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1665 (mi_ui_out::do_field_string): Update.
1666 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1668 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1670 * cli-out.c (cli_ui_out::do_table_header)
1671 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1672 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1673 (cli_ui_out::do_field_fmt): Update.
1674 * breakpoint.c (print_breakpoint_location): Update.
1675 (update_static_tracepoint): Update.
1677 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1679 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1680 conversion of gdb_datadir.
1681 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1682 remove not needed c_str ().
1684 2019-09-30 Ali Tamur <tamur@google.com>
1686 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1687 (dwarf2_string_attr): Likewise.
1689 2019-09-30 Ali Tamur <tamur@google.com>
1691 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1692 (process_full_type_unit): Likewise.
1693 (dump_die_shallow): Likewise.
1694 (cu_debug_loc_section): Likewise.
1696 2019-09-28 Christian Biesinger <cbiesinger@google.com>
1698 * minsyms.c (compare_minimal_symbols): Rename to...
1699 (minimal_symbol_is_less_than): ...this, and adjust to STL
1700 conventions (return bool, take arguments as references)
1701 (minimal_symbol_reader::install): Call std::sort instead
1704 2019-09-29 Christian Biesinger <cbiesinger@google.com>
1706 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1708 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1709 msymbol_hash, msymbol_demangled_hash>: Improve comments.
1711 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
1713 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1714 * psympriv.h (add_psymbol_to_list): Move comment here and update
1717 2019-09-29 Tom de Vries <tdevries@suse.de>
1719 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1720 Use $tmpdir/$(basename "$output_file").dwz instead of
1721 "${output_file}.dwz".
1723 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
1726 * hppa-linux-nat.c: Include gdbarch.h.
1728 2019-09-26 Christian Biesinger <cbiesinger@google.com>
1730 * blockframe.c (find_pc_partial_function): Change return type to bool.
1731 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1732 * minsyms.c (in_gnu_ifunc_stub): Likewise.
1733 (stub_gnu_ifunc_resolve_name): Likewise.
1734 * symtab.c (compare_filenames_for_search): Likewise.
1735 (compare_glob_filenames_for_search): Likewise.
1736 (matching_obj_sections): Likewise.
1737 (symbol_matches_domain): Likewise.
1738 (find_line_symtab): Change out param EXACT_MATCH to bool *.
1739 (find_line_pc): Change return type to bool.
1740 (find_line_pc_range): Likewise.
1741 (producer_is_realview): Likewise.
1742 * symtab.h (symbol_matches_domain): Likewise.
1743 (find_pc_partial_function): Likewise.
1744 (find_pc_line_pc_range): Likewise.
1745 (in_gnu_ifunc_stub): Likewise.
1746 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1747 (find_line_pc): Likewise.
1748 (find_line_pc_range): Likewise.
1749 (matching_obj_sections): Likewise.
1750 (find_line_symtab): Change out parameter to bool.
1751 (producer_is_realview): Change return type to bool.
1752 (compare_filenames_for_search): Likewise.
1753 (compare_glob_filenames_for_search): Likewise.
1755 2019-09-26 Tom Tromey <tom@tromey.com>
1757 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1758 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1759 * gdb_usleep.h: Remove.
1760 * gdb_usleep.c: Remove.
1761 * utils.c: Don't include gdb_usleep.h.
1763 2019-09-26 Tom Tromey <tromey@adacore.com>
1765 * python/py-type.c (type_to_type_object): Call check_typedef
1768 2019-09-26 Tom Tromey <tom@tromey.com>
1770 * utils.h (initialize_utils): Don't declare.
1771 * top.c (gdb_init): Don't call initialize_utils.
1772 * utils.c (initialize_utils): Remove. Move contents...
1773 (_initialize_utils): ... here.
1775 2019-09-25 Tom Tromey <tom@tromey.com>
1777 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1778 * utils.h (make_hex_string): Don't declare.
1779 * utils.c (make_hex_string): Remove.
1781 2019-09-24 Tom de Vries <tdevries@suse.de>
1784 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1785 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1787 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
1789 * NEWS: Mention new simulator port for PRU.
1791 2019-09-23 Christian Biesinger <cbiesinger@google.com>
1793 * ada-exp.y (write_object_remaining): Update.
1794 * ada-lang.c (ada_decode): Return a std::string instead of a char*
1795 and eliminate the static buffer.
1796 (ada_decode_symbol): Update.
1797 (ada_la_decode): Update.
1798 (ada_sniff_from_mangled_name): Update.
1799 (is_valid_name_for_wild_match): Update.
1800 (ada_lookup_name_info::matches): Update and simplify.
1801 (name_matches_regex): Update.
1802 (ada_add_global_exceptions): Update.
1803 * ada-lang.h (ada_decode): Update signature.
1804 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1805 * dwarf-index-write.c (debug_names::insert): Update.
1807 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
1809 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1812 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
1814 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1815 Change "nonzero" to "true" in documentation.
1817 2019-09-20 Christian Biesinger <cbiesinger@google.com>
1819 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1820 (_initialize_darwin_solib): Don't set
1821 darwin_so_ops.lookup_lib_global_symbol.
1822 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1823 set_gdbarch_iterate_over_objfiles_in_search_order.
1824 (elf_lookup_lib_symbol): Rename to...
1825 (svr4_iterate_over_objfiles_in_search_order): this, and update
1826 to iterate semantics.
1827 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1828 * solib.c (solib_global_lookup): Remove.
1829 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1830 (solib_global_lookup): Remove.
1831 * symtab.c (lookup_global_or_static_symbol): Remove call to
1832 solib_global_lookup.
1834 2019-09-20 Joel Brobecker <brobecker@adacore.com>
1836 * NEWS: Move entries about default MI version now being
1837 version 3, and about the GDB/MI fix for multi-location
1838 breakpoints to the "since GDB 8.3" section.
1840 2019-09-20 Joel Brobecker <brobecker@adacore.com>
1844 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
1846 * NEWS: Mention that Cell/B.E. debugging support was removed.
1847 * MAINTAINERS: Remove spu target.
1849 * config/djgpp/fnchange.lst: Remove entries for removed files.
1851 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1852 spu-multiarch.o, and spu-tdep.o.
1853 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1854 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1855 spu-multiarch.c, and spu-tdep.c.
1856 * spu-linux-nat.c: Remove file.
1857 * spu-multiarch.c: Remove file.
1858 * spu-tdep.c: Remove file.
1859 * spu-tdep.h: Remove file.
1860 * solib-spu.c: Remove file.
1861 * solib-spu.h: Remove file.
1863 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1864 * configure.nat (spu-linux): Remove.
1865 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1866 solib-multiarch.o from gdb_target_obs.
1869 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1871 (ppc_linux_no_features): Update.
1872 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1874 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1875 (tdesc_powerpc_cell64l): Likewise.
1876 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1877 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1879 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1880 Do not include "features/rs6000/powerpc-cell32l.c" or
1881 "features/rs6000/powerpc-cell64l.c".
1882 (ppc_linux_spu_section): Remove.
1883 (ppc_linux_core_read_description): Remove Cell/B.E. support.
1884 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1885 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1886 (ppc_linux_spe_context_lookup): Remove.
1887 (ppc_linux_spe_context_inferior_created): Remove.
1888 (ppc_linux_spe_context_solib_loaded): Remove.
1889 (ppc_linux_spe_context_solib_unloaded): Remove.
1890 (ppc_linux_spe_context): Remove.
1891 (struct ppu2spu_cache): Remove.
1892 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1893 (struct ppu2spu_data): Remove.
1894 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1895 ppu2spu_unwind): Remove.
1896 (ppc_linux_init_abi): Remove Cell/B.E. support.
1897 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1899 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1900 (rs6000/powerpc-cell64l-expedite): Likewise
1901 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1902 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1903 rs6000/powerpc-cell64l.xml.
1904 * features/rs6000/powerpc-cell32l.xml: Remove.
1905 * features/rs6000/powerpc-cell64l.xml: Likewise.
1906 * features/rs6000/powerpc-cell32l.c: Remove generated file.
1907 * features/rs6000/powerpc-cell64l.c: Likewise.
1908 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1909 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1910 * regformats/reg-spu.dat: Remove.
1912 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1913 * corelow.c (struct spuid_list): Remove.
1914 (add_to_spuid_list): Remove.
1915 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1916 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1917 (remote_protocol_features): Remove associated entries.
1918 (_initialize_remote): No longer initialize them.
1919 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1920 * linux-nat.c (SPUFS_MAGIC): Remove.
1921 (linux_proc_xfer_spu): Remove.
1922 (spu_enumerate_spu_ids): Remove.
1923 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1924 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1925 (linux_make_corefile_notes): No longer call it.
1927 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1928 (cooked_write_test): Likewise.
1930 2019-09-20 Tom Tromey <tom@tromey.com>
1932 * NEWS: Mention case-sensitivity of TUI commands.
1933 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1934 (tui_set_win_height_command, parse_scrolling_args): Likewise.
1935 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1937 2019-09-20 Tom Tromey <tom@tromey.com>
1939 * tui/tui-source.c (tui_source_window::set_contents): Use
1940 make_unique_xstrdup.
1941 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1942 make_unique_xstrdup.
1944 2019-09-20 Tom Tromey <tom@tromey.com>
1946 * tui/tui-data.c: Remove separator comments.
1947 * tui/tui-layout.c: Remove separator comments.
1948 * tui/tui-win.c: Remove separator comments.
1949 * tui/tui-wingeneral.c: Remove separator comments.
1951 2019-09-20 Tom Tromey <tom@tromey.com>
1953 * tui/tui.h (strcat_to_buf): Don't declare.
1954 * tui/tui.c (strcat_to_buf): Remove.
1956 2019-09-20 Tom Tromey <tom@tromey.com>
1958 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1960 * tui/tui-source.c (tui_source_window::set_contents)
1961 (tui_source_window::location_matches_p)
1962 (tui_source_window::maybe_update): Update.
1964 2019-09-20 Tom Tromey <tom@tromey.com>
1966 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1968 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1970 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1971 (tui_data_window::line_from_reg_element_no)
1972 (tui_data_window::first_reg_element_no_inline)
1973 (tui_data_window::show_registers)
1974 (tui_data_window::show_register_group)
1975 (tui_data_window::display_registers_from)
1976 (tui_data_window::display_registers_from_line)
1977 (tui_data_window::first_data_item_displayed)
1978 (tui_data_window::delete_data_content_windows)
1979 (tui_data_window::erase_data_content)
1980 (tui_data_window::do_scroll_vertical)
1981 (tui_data_window::refresh_window)
1982 (tui_data_window::check_register_values): Update.
1984 2019-09-20 Tom Tromey <tom@tromey.com>
1986 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1987 (struct tui_locator_window) <full_name, proc_name>: Now
1989 * tui/tui-stack.c (tui_locator_window::make_status_line)
1990 (tui_locator_window::set_locator_fullname)
1991 (tui_locator_window::set_locator_info): Update.
1992 * tui/tui-source.c (tui_source_window::set_contents)
1993 (tui_source_window::showing_source_p): Update.
1995 2019-09-20 Tom Tromey <tom@tromey.com>
1997 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1998 Don't call tui_locator_win_info_ptr.
2000 2019-09-20 Tom Tromey <tom@tromey.com>
2002 * tui/tui-win.c (tui_resize_all): Don't call refresh.
2004 2019-09-20 Tom Tromey <tom@tromey.com>
2006 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2008 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2009 * tui/tui-layout.c (show_source_disasm_command, show_data)
2010 (show_source_or_disasm_and_command): Use 1 as height for locator.
2012 2019-09-20 Tom Tromey <tom@tromey.com>
2014 * tui/tui.c (tui_enable): Update.
2015 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2017 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2019 * tui/tui-data.c (win_resized): Now bool.
2020 (tui_win_resized): Return bool.
2021 (tui_set_win_resized_to): Accept a bool.
2023 2019-09-20 Tom Tromey <tom@tromey.com>
2025 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2026 Change type of "refresh_values_only".
2027 * tui/tui-regs.c (tui_data_window::show_register_group): Change
2028 type of "refresh_values_only".
2030 2019-09-20 Tom Tromey <tom@tromey.com>
2032 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2034 (tui_disassemble): Add "pos" parameter.
2035 (tui_disasm_window::set_contents): Simplify.
2037 2019-09-20 Tom Tromey <tom@tromey.com>
2039 * tui/tui-winsource.h (struct tui_source_window_base)
2040 <show_source_content>: Now private.
2041 * tui/tui-winsource.c
2042 (tui_source_window_base::show_source_content): Don't handle empty
2045 2019-09-20 Tom Tromey <tom@tromey.com>
2047 * tui/tui-layout.c (show_source_disasm_command)
2048 (show_source_or_disasm_and_command): Don't call
2049 show_source_content.
2051 2019-09-20 Tom Tromey <tom@tromey.com>
2053 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2055 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2056 from tui_make_status_line.
2057 (tui_locator_window::rerender): Update.
2059 2019-09-20 Tom Tromey <tom@tromey.com>
2061 * tui/tui-stack.c (tui_make_status_line): Return std::string.
2062 (tui_locator_window::rerender): Update.
2064 2019-09-20 Tom Tromey <tom@tromey.com>
2066 * tui/tui-winsource.h (struct tui_source_window_base)
2067 <~tui_source_window_base>: Don't declare.
2069 * tui/tui-winsource.c (~tui_source_window_base): Remove.
2070 * tui/tui-source.h (struct tui_source_window) <fullname>: New
2072 * tui/tui-source.c (tui_source_window::set_contents): Update.
2073 (tui_source_window::location_matches_p)
2074 (tui_source_window::maybe_update): Update.
2076 2019-09-20 Tom Tromey <tom@tromey.com>
2078 * tui/tui-winsource.h (~tui_source_element): Remove.
2079 (tui_source_element): Update.
2080 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2081 * tui/tui-winsource.c (tui_show_source_line): Update.
2082 * tui/tui-source.c (tui_source_window::set_contents): Update.
2083 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2085 2019-09-20 Tom Tromey <tom@tromey.com>
2087 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2089 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2090 tui_clear_source_windows_detail.
2091 * tui/tui-winsource.h (struct tui_source_window_base)
2092 <clear_detail>: Don't declare.
2093 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2095 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2097 2019-09-20 Tom Tromey <tromey@adacore.com>
2100 * block.c (contained_in): Fix final return value.
2102 2019-09-20 Alan Modra <amodra@gmail.com>
2104 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2105 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2106 (read_indirect_string_from_dwz): Use bfd accessor.
2107 * dwarf2read.h (struct dwz_file <filename>): Likewise.
2108 * machoread.c (macho_symfile_read_all_oso): Likewise.
2109 * solib.c (solib_bfd_open): Likewise.
2111 2019-09-19 Christian Biesinger <cbiesinger@google.com>
2113 * eval.c: Move declaration of overload_resolution to...
2116 2019-09-19 Christian Biesinger <cbiesinger@google.com>
2118 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2119 * arm-linux-tdep.c: Likewise.
2120 * arm-nbsd-nat.c: Likewise.
2121 * arm-tdep.h: Declare arm_apcs_32.
2122 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2124 2019-09-19 Christian Biesinger <cbiesinger@google.com>
2126 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2127 * dwarf2read.h: Declare dwarf_always_disassemble.
2129 2019-09-19 Tom de Vries <tdevries@suse.de>
2132 * source-cache.c (source_cache::ensure): Catch exception thrown during
2133 construction of the highlighter.
2135 2019-09-18 Alan Modra <amodra@gmail.com>
2137 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2138 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2139 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2140 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2141 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2142 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2143 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2144 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2145 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2146 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2147 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2148 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2149 * solib-spu.c, * solib-svr4.c, * solib-target.c,
2150 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2151 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2152 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2153 * mi/mi-interp.c: Update throughout for bfd section macro and
2155 * gcore (gcore_create_callback): Use bfd_set_section_lma.
2156 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2158 2019-09-18 Tom Tromey <tom@tromey.com>
2161 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
2163 (tui_enable): Do not call rl_initialize.
2165 2019-09-18 Christian Groessler <chris@groessler.org>
2167 * alpha-linux-nat.c: Include gdbarch.h.
2169 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
2171 * ui-file.c: Include cli/cli-style.h.
2172 (term_cli_styling): Remove cli_styling declaration.
2174 2019-09-18 Alan Modra <amodra@gmail.com>
2176 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2177 to bfd_asymbol_section.
2179 2019-09-18 Alan Modra <amodra@gmail.com>
2181 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2182 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2183 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2185 2019-09-18 Alan Modra <amodra@gmail.com>
2187 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2188 * spu-linux-nat.c (spu_bfd_open): Likewise.
2190 2019-09-18 Christian Biesinger <cbiesinger@google.com>
2192 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2193 to bool to match definition in dwarf2read.c.
2195 2019-09-17 Christian Biesinger <cbiesinger@google.com>
2197 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2198 (print_signatures): Likewise.
2199 (trust_pad_over_xvs): Likewise.
2200 * arch/aarch64-insn.c (aarch64_debug): Likewise.
2201 * arch/aarch64-insn.h (aarch64_debug): Likewise.
2202 * arm-linux-nat.c (arm_apcs_32): Likewise.
2203 * arm-linux-tdep.c (arm_apcs_32): Likewise.
2204 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2205 * arm-tdep.c (arm_debug): Likewise.
2206 (arm_apcs_32): Likewise.
2207 * auto-load.c (debug_auto_load): Likewise.
2208 (auto_load_gdb_scripts): Likewise.
2209 (global_auto_load): Likewise.
2210 (auto_load_local_gdbinit): Likewise.
2211 (auto_load_local_gdbinit_loaded): Likewise.
2212 * auto-load.h (global_auto_load): Likewise.
2213 (auto_load_local_gdbinit): Likewise.
2214 (auto_load_local_gdbinit_loaded): Likewise.
2215 * breakpoint.c (disconnected_dprintf): Likewise.
2216 (breakpoint_proceeded): Likewise.
2217 (automatic_hardware_breakpoints): Likewise.
2218 (always_inserted_mode): Likewise.
2219 (target_exact_watchpoints): Likewise.
2220 (_initialize_breakpoint): Update.
2221 * breakpoint.h (target_exact_watchpoints): Change to bool.
2222 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2223 * cli/cli-cmds.c (trace_commands): Likewise.
2224 * cli/cli-cmds.h (trace_commands): Likewise.
2225 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2227 * cli/cli-logging.c (logging_overwrite): Change to bool.
2228 (logging_redirect): Likewise.
2229 (debug_redirect): Likewise.
2230 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2231 (struct boolean_option_def) <get_var_address_cb_>: Change return type
2233 <boolean_option_def>: Update.
2234 (struct flag_option_def): Change default type of Context to bool
2236 <flag_option_def>: Change return type of var_address_cb_ to bool*.
2237 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2238 (get_setshow_command_value_string): Likewise.
2239 * cli/cli-style.c (cli_styling): Change to bool.
2240 (source_styling): Likewise.
2241 * cli/cli-style.h (source_styling): Likewise.
2242 (cli_styling): Likewise.
2243 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2245 * command.h (var_types): Update comment.
2246 (add_setshow_boolean_cmd): Change int* var argument to bool*.
2247 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2249 (debug_compile_cplus_scopes): Likewise.
2250 * compile/compile-internal.h (compile_debug): Likewise.
2251 * compile/compile.c (compile_debug): Likewise.
2252 (struct compile_options) <raw>: Likewise.
2253 * cp-support.c (catch_demangler_crashes): Likewise.
2254 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2255 (usr_cmd_cris_dwarf2_cfi): Likewise.
2256 * csky-tdep.c (csky_debug): Likewise.
2257 * darwin-nat.c (enable_mach_exceptions): Likewise.
2258 * dcache.c (dcache_enabled_p): Likewise.
2259 * defs.h (info_verbose): Likewise.
2260 * demangle.c (demangle): Likewise.
2261 (asm_demangle): Likewise.
2262 * dwarf-index-cache.c (debug_index_cache): Likewise.
2263 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2264 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2265 * dwarf2read.c (check_physname): Likewise.
2266 (use_deprecated_index_sections): Likewise.
2267 (dwarf_always_disassemble): Likewise.
2268 * eval.c (overload_resolution): Likewise.
2269 * event-top.c (set_editing_cmd_var): Likewise.
2270 (exec_done_display_p): Likewise.
2271 * event-top.h (set_editing_cmd_var): Likewise.
2272 (exec_done_display_p): Likewise.
2273 * exec.c (write_files): Likewise.
2274 * fbsd-nat.c (debug_fbsd_lwp): Likewise
2275 (debug_fbsd_nat): Likewise.
2276 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2278 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2279 <backtrace_past_entry> Likewise.
2280 * gdb-demangle.h (demangle): Likewise.
2281 (asm_demangle): Likewise.
2282 * gdb_bfd.c (bfd_sharing): Likewise.
2283 * gdbcore.h (write_files): Likewise.
2284 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2285 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2286 * gdbthread.h (print_thread_events): Likewise.
2287 * gdbtypes.c (opaque_type_resolution): Likewise.
2288 (strict_type_checking): Likewise.
2289 * gnu-nat.c (gnu_debug_flag): Likewise.
2290 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2291 * guile/scm-param.c (pascm_variable): Add boolval.
2292 (add_setshow_generic): Update.
2293 (pascm_param_value): Update.
2294 (pascm_set_param_value_x): Update.
2295 * hppa-tdep.c (hppa_debug): Change to bool..
2296 * infcall.c (may_call_functions_p): Likewise.
2297 (coerce_float_to_double_p): Likewise.
2298 (unwind_on_signal_p): Likewise.
2299 (unwind_on_terminating_exception_p): Likewise.
2300 * infcmd.c (startup_with_shell): Likewise.
2301 * inferior.c (print_inferior_events): Likewise.
2302 * inferior.h (startup_with_shell): Likewise.
2303 (print_inferior_events): Likewise.
2304 * infrun.c (step_stop_if_no_debug): Likewise.
2305 (detach_fork): Likewise.
2306 (debug_displaced): Likewise.
2307 (disable_randomization): Likewise.
2308 (non_stop): Likewise.
2309 (non_stop_1): Likewise.
2310 (observer_mode): Likewise.
2311 (observer_mode_1): Likewise.
2312 (set_observer_mode): Update.
2313 (sched_multi): Change to bool.
2314 * infrun.h (debug_displaced): Likewise.
2315 (sched_multi): Likewise.
2316 (step_stop_if_no_debug): Likewise.
2317 (non_stop): Likewise.
2318 (disable_randomization): Likewise.
2319 * linux-tdep.c (use_coredump_filter): Likewise.
2320 (dump_excluded_mappings): Likewise.
2321 * linux-thread-db.c (auto_load_thread_db): Likewise.
2322 (check_thread_db_on_load): Likewise.
2323 * main.c (captured_main_1): Update.
2324 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2325 xx2_opt, boolean_opt>: Change to bool.
2326 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2327 * maint.c (maintenance_profile_p): Likewise.
2328 (per_command_time): Likewise.
2329 (per_command_space): Likewise.
2330 (per_command_symtab): Likewise.
2331 * memattr.c (inaccessible_by_default): Likewise.
2332 * mi/mi-main.c (mi_async): Likewise.
2333 (mi_async_1): Likewise.
2334 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2335 * nat/fork-inferior.h (startup_with_shell): Likewise.
2336 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2337 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2338 * nios2-tdep.c (nios2_debug): Likewise.
2339 * or1k-tdep.c (or1k_debug): Likewise.
2340 * parse.c (parser_debug): Likewise.
2341 * parser-defs.h (parser_debug): Likewise.
2342 * printcmd.c (print_symbol_filename): Likewise.
2343 * proc-api.c (procfs_trace): Likewise.
2344 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2345 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2346 (set_parameter_value): Update.
2347 (add_setshow_generic): Update.
2348 * python/py-value.c (copy_py_bool_obj): Change argument from int*
2350 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2352 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2353 * record-btrace.c (record_btrace_target::store_registers): Update.
2354 * record-full.c (record_full_memory_query): Change to bool.
2355 (record_full_stop_at_limit): Likewise.
2356 * record-full.h (record_full_memory_query): Likewise.
2357 * remote-notif.c (notif_debug): Likewise.
2358 * remote-notif.h (notif_debug): Likewise.
2359 * remote.c (use_range_stepping): Likewise.
2360 (interrupt_on_connect): Likewise.
2361 (remote_break): Likewise.
2362 * ser-tcp.c (tcp_auto_retry): Likewise.
2363 * ser-unix.c (serial_hwflow): Likewise.
2364 * skip.c (debug_skip): Likewise.
2365 * solib-aix.c (solib_aix_debug): Likewise.
2366 * spu-tdep.c (spu_stop_on_load_p): Likewise.
2367 (spu_auto_flush_cache_p): Likewise.
2368 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2370 (struct info_print_options) <quiet>: Likewise.
2371 * symfile-debug.c (debug_symfile): Likewise.
2372 * symfile.c (auto_solib_add): Likewise.
2373 (separate_debug_file_debug): Likewise.
2374 * symfile.h (auto_solib_add): Likewise.
2375 (separate_debug_file_debug): Likewise.
2376 * symtab.c (basenames_may_differ): Likewise.
2377 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2378 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2379 (struct info_types_options) <quiet>: Likewise.
2380 * symtab.h (demangle): Likewise.
2381 (basenames_may_differ): Likewise.
2382 * target-dcache.c (stack_cache_enabled_1): Likewise.
2383 (code_cache_enabled_1): Likewise.
2384 * target.c (trust_readonly): Likewise.
2385 (may_write_registers): Likewise.
2386 (may_write_memory): Likewise.
2387 (may_insert_breakpoints): Likewise.
2388 (may_insert_tracepoints): Likewise.
2389 (may_insert_fast_tracepoints): Likewise.
2390 (may_stop): Likewise.
2391 (auto_connect_native_target): Likewise.
2392 (target_stop_and_wait): Update.
2393 (target_async_permitted): Change to bool.
2394 (target_async_permitted_1): Likewise.
2395 (may_write_registers_1): Likewise.
2396 (may_write_memory_1): Likewise.
2397 (may_insert_breakpoints_1): Likewise.
2398 (may_insert_tracepoints_1): Likewise.
2399 (may_insert_fast_tracepoints_1): Likewise.
2400 (may_stop_1): Likewise.
2401 * target.h (target_async_permitted): Likewise.
2402 (may_write_registers): Likewise.
2403 (may_write_memory): Likewise.
2404 (may_insert_breakpoints): Likewise.
2405 (may_insert_tracepoints): Likewise.
2406 (may_insert_fast_tracepoints): Likewise.
2407 (may_stop): Likewise.
2408 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2409 (make_thread_apply_all_options_def_group): Change argument from int*
2411 (thread_apply_all_command): Update.
2412 (print_thread_events): Change to bool.
2413 * top.c (confirm): Likewise.
2414 (command_editing_p): Likewise.
2415 (history_expansion_p): Likewise.
2416 (write_history_p): Likewise.
2417 (info_verbose): Likewise.
2418 * top.h (confirm): Likewise.
2419 (history_expansion_p): Likewise.
2420 * tracepoint.c (disconnected_tracing): Likewise.
2421 (circular_trace_buffer): Likewise.
2422 * typeprint.c (print_methods): Likewise.
2423 (print_typedefs): Likewise.
2424 * utils.c (debug_timestamp): Likewise.
2425 (sevenbit_strings): Likewise.
2426 (pagination_enabled): Likewise.
2427 * utils.h (sevenbit_strings): Likewise.
2428 (pagination_enabled): Likewise.
2429 * valops.c (overload_resolution): Likewise.
2430 * valprint.h (struct value_print_options) <prettyformat_arrays,
2431 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2432 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2433 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2435 * windows-nat.c (new_console): Likewise.
2436 (cygwin_exceptions): Likewise.
2437 (new_group): Likewise.
2438 (debug_exec): Likewise.
2439 (debug_events): Likewise.
2440 (debug_memory): Likewise.
2441 (debug_exceptions): Likewise.
2442 (useshell): Likewise.
2443 * windows-tdep.c (maint_display_all_tib): Likewise.
2444 * xml-support.c (debug_xml): Likewise.
2446 2019-09-17 Mike Gulick <mgulick@mathworks.com>
2448 * source.c (prepare_path_for_appending): New function.
2449 (openp): Make use of new function.
2450 (find_and_open_source): Search for the compilation directory and
2451 source file as a relative path beneath the directory search path.
2453 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
2455 * source-cache.c (source_cache::get_line_charpos): Catch
2456 exceptions and return false, this matches the behaviour documented
2459 2019-09-17 Joel Brobecker <brobecker@adacore.com>
2461 * ada-tasks.c (info_task): Remove quoting of the task's name.
2463 2019-09-16 Christian Biesinger <cbiesinger@google.com>
2465 * symfile.c (auto_solib_add): Replace comment with a reference
2468 2019-09-14 Christian Biesinger <cbiesinger@google.com>
2470 * NEWS: Mention that gdb can now be compiled with Python 3
2473 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
2475 * maint.c (maint_print_section_data::maint_print_section_data):
2476 Force use of 'float log10 (float)' by casting the argument to
2479 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
2481 * maint.c: Add 'cmath' include.
2482 (struct maint_print_section_data): New structure.
2483 (print_section_index): New function.
2484 (print_bfd_section_info): Add header comment, small whitespace
2485 cleanup, and update to call new print_section_index function.
2486 (print_objfile_section_info): Likewise.
2487 (maint_obj_section_from_bfd_section): New function.
2488 (print_bfd_section_info_maybe_relocated): New function.
2489 (maintenance_info_sections): Add header comment, always use
2490 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2492 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
2494 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2495 inner scope, add check that the objfile has psymtabs before
2496 checking psymtabs_addrmap.
2497 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2499 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2501 * NEWS: Announce that Ada task names are now shown at more places,
2502 and between quotes (except in info task output).
2503 * gdb/ada-tasks.c (task_to_str): New function.
2504 (display_current_task_id): Call task_to_str.
2505 (task_command_1): Likewise.
2506 (print_ada_task_info): In non-mi mode, Properly align headers and data
2507 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2509 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2511 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2512 prstatus.pr_lwp.pr_info instead of making it up.
2514 2019-09-11 Christian Biesinger <cbiesinger@google.com>
2516 * auto-load.c (auto_load_expand_dir_vars): Update.
2517 * defs.h (gdb_datadir): Change to std::string.
2518 (python_libdir): Likewise.
2519 (relocate_gdb_directory): Change return type to std::string.
2520 * guile/guile.c (gdbscm_data_directory): Update.
2521 (initialize_scheme_side): Update.
2522 * jit.c (jit_reader_dir): Change to std::string.
2523 (jit_reader_load_command): Update.
2524 * main.c (gdb_datadir): Change to std::string.
2525 (python_libdir): Likewise.
2526 (set_gdb_data_directory): Update.
2527 (relocate_path): Change to return std::string.
2528 (relocate_gdb_directory): Change to return std::string.
2529 (relocate_gdbinit_path_maybe_in_datadir): Update.
2530 (captured_main_1): Update.
2531 * python/python.c (do_start_initialization): Update.
2532 * top.c (show_gdb_datadir): Update.
2533 * xml-syscall.c (xml_init_syscalls_info): Update.
2534 (init_syscalls_info): Update.
2536 2019-09-11 Christian Biesinger <cbiesinger@google.com>
2538 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2539 out of get_init_files.
2540 (get_init_files): Update.
2542 2019-09-11 Christian Biesinger <cbiesinger@google.com>
2544 * main.c (get_init_files): Change to use std::string.
2545 (captured_main_1): Update.
2546 (print_gdb_help): Update.
2548 2019-09-11 Ali Tamur <tamur@google.com>
2550 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2553 2019-09-11 Christian Biesinger <cbiesinger@google.com>
2555 * dbxread.c (read_dbx_symtab): Update.
2556 * dwarf2read.c (load_partial_dies): Update.
2557 * mdebugread.c (parse_partial_symbols): Update.
2558 (handle_psymbol_enumerators): Update.
2559 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2560 * psymtab.c (add_psymbol_to_bcache): Likewise.
2561 (add_psymbol_to_list): Likewise.
2562 * symtab.c (symbol_set_names): Likewise.
2563 * symtab.h (symbol_set_names): Likewise.
2564 * xcoffread.c (scan_xcoff_symtab): Update.
2566 2019-09-11 Tom Tromey <tom@tromey.com>
2568 * symfile-mem.c (symbol_file_add_from_memory): Use
2570 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2571 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2573 2019-09-10 Tom Tromey <tromey@adacore.com>
2575 * dwarf-index-write.c (write_psymbols): Extend error message.
2576 (debug_names::insert): Add Ada code.
2577 (debug_names::write_psymbols): Remove Ada check.
2578 (debug_names) <m_string_obstack>: New member.
2579 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2580 (gdb_index_symbol_name_matcher::matches): Remove.
2581 (mapped_index_base::find_name_components_bounds): Add "lang"
2583 (mapped_index_base::build_name_components): Also split names
2584 according to Ada syntax.
2585 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
2586 type of "match_callback".
2587 (check_match, check_find_bounds_finds)
2588 (dw2_expand_symtabs_matching): Update.
2589 (dw2_debug_names_iterator): Add new constructor.
2590 (dw2_debug_names_map_matching_symbols): New function.
2591 (dw2_debug_names_expand_symtabs_matching): Update.
2592 (dwarf2_debug_names_functions): Use
2593 dw2_debug_names_map_matching_symbols.
2595 2019-09-10 Tom Tromey <tromey@adacore.com>
2597 * dwarf2read.c (dw2_get_file_names_reader): Add the
2598 CU's file name to the results.
2600 2019-09-10 Tom Tromey <tromey@adacore.com>
2602 * ada-lang.c (add_nonlocal_symbols): Combine calls to
2603 map_matching_symbols. Update.
2604 * dwarf2read.c (dw2_map_matching_symbols): Update.
2605 * psymtab.c (match_partial_symbol): Change type; update.
2606 (psym_map_matching_symbols): Likewise.
2607 * symfile-debug.c (debug_qf_map_matching_symbols): Change
2609 * symfile.h (struct quick_symbol_functions)
2610 <map_matching_symbols>: Change "name" to be a lookup_name_info.
2613 2019-09-10 Tom Tromey <tromey@adacore.com>
2615 * psymtab.c (map_block): Remove.
2616 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2617 * symtab.c (iterate_over_symbols_terminated): New function.
2618 * symtab.c (iterate_over_symbols_terminated): Declare.
2620 2019-09-10 Tom Tromey <tromey@adacore.com>
2622 * ada-lang.c (ada_iterate_over_symbols): Return bool.
2623 * language.h (struct language_defn) <la_iterate_over_symbols>:
2625 * symtab.c (iterate_over_symbols): Return bool.
2626 * symtab.h (iterate_over_symbols): Return bool.
2628 2019-09-10 Tom Tromey <tromey@adacore.com>
2630 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2631 (add_nonlocal_symbols): Update.
2632 * dwarf2read.c (dw2_map_matching_symbols): Change type.
2633 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2634 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2635 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2636 Change type of "callback". Remove "data".
2639 2019-09-09 Ali Tamur <tamur@google.com>
2641 * dwarf2read.c (comp_unit_head): Update comment.
2642 (dwarf2_dwo_name): New function declaration.
2643 (dwarf_unit_type_name): New function declaration.
2644 (read_comp_unit_head): Add support for new compilation units,
2645 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2646 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2647 (currently named as "signature") in their header. Also clarify error
2649 (lookup_dwo_id): New function. Returns the dwo id of the given
2651 (lookup_dwo_unit): Use the new lookup_dwo_id function.
2652 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2654 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2655 (dwarf2_dwo_name): Get the dwo name if present.
2656 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2659 2019-09-09 Tom Tromey <tom@tromey.com>
2661 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2663 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2665 * python/python.c (do_start_initialization): Make progname_copy static,
2666 to avoid a leak report.
2668 2019-09-08 Tom Tromey <tom@tromey.com>
2670 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2672 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
2674 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2675 Change type to gdb::optional<block_enum>.
2676 (dw2_symtab_iter_init): Change block_index parameter type
2677 to gdb::optional<block_enum>.
2678 (dw2_lookup_symbol): Change block_index parameter
2679 type to block_enum.c
2680 (dw2_debug_names_lookup_symbol): Likewise.
2681 * psymtab.c (psym_lookup_symbol): Likewise.
2682 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2683 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2686 2019-09-06 Christian Biesinger <cbiesinger@google.com>
2688 * defs.h (relocate_gdb_directory): Change int to bool in
2689 signature and rename flag to relocatable.
2690 * main.c (relocate_path): Likewise.
2691 (relocate_gdb_directory): Likewise.
2693 2019-09-06 Alan Modra <amodra@gmail.com>
2695 * coffread.c (coff_symfile_read): Constify filename variable.
2696 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2697 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2698 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2699 * solib.c (reload_shared_libraries_1): Likewise.
2700 * symfile.c (reread_symbols): Likewise.
2701 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2702 * solib-darwin.c (darwin_bfd_open): Likewise.
2703 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2705 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
2707 * psymtab.c (print_partial_symbols): Handle missing domain_enum
2708 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2710 2019-09-03 Tom Tromey <tromey@adacore.com>
2712 * ada-valprint.c (ada_val_print_num): Don't recurse for range
2714 (has_negatives): Unbias a range type bound.
2715 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2716 * gdbtypes.c (operator==): Handle new field.
2717 (create_range_type): Add "bias" parameter.
2718 (create_static_range_type, resolve_dynamic_range): Update.
2719 * gdbtypes.h (struct range_bounds) <bias>: New member.
2720 (create_range_type): Add bias parameter.
2721 * printcmd.c (print_scalar_formatted): Unbias range types.
2722 * value.c (unpack_long): Unbias range types.
2723 (pack_long): Bias range types.
2725 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2727 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2730 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2732 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2733 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2734 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2735 (compile_probe_arg): Likewise.
2736 * probe.h (get_argument_count): Likewise.
2737 * solib-svr4.c (solib_event_probe_action): Likewise.
2738 * stap-probe.c (stap_probe::get_argument_count): Likewise.
2740 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2742 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2744 (svr4_create_solib_event_breakpoints): ...from here.
2746 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
2748 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2749 suffix from warning message.
2751 2019-08-30 Tom Tromey <tom@tromey.com>
2753 * tui/tui-winsource.h (struct tui_source_window_base)
2754 <refresh_all>: Don't declare.
2755 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2757 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2758 tui_show_locator_content.
2759 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2761 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2762 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2765 2019-08-30 Tom Tromey <tom@tromey.com>
2767 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2769 2019-08-30 Tom Tromey <tom@tromey.com>
2771 * tui/tui-stack.c (_initialize_tui_stack): Move later.
2772 Remove unnecessary forward declarations.
2774 2019-08-30 Tom Tromey <tom@tromey.com>
2776 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2778 (tui_update_locator_fullname, tui_show_frame_info): Don't call
2779 tui_show_locator_content.
2781 2019-08-30 Tom Tromey <tom@tromey.com>
2783 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
2784 (tui_locator_window::rerender): Rewrite using body of previous
2785 tui_show_locator_content.
2787 2019-08-30 Tom Tromey <tom@tromey.com>
2789 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2790 set_locator_fullname>: New methods.
2791 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2792 Rename from tui_set_locator_fullname.
2793 (tui_locator_window::set_locator_info): Rename from
2794 tui_set_locator_info. Return bool.
2795 (tui_update_locator_fullname, tui_show_frame_info): Update.
2797 2019-08-30 Tom Tromey <tom@tromey.com>
2799 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2801 2019-08-30 Tom Tromey <tom@tromey.com>
2803 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2806 2019-08-30 Tom Tromey <tom@tromey.com>
2808 * tui/tui-wingeneral.c (box_win): Assume win_info and
2809 win_info->handle cannot be NULL.
2811 2019-08-30 Tom Tromey <tom@tromey.com>
2813 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2814 refresh_window>: Declare.
2815 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2817 (tui_data_item_window::rerender): Rename from
2818 tui_display_register.
2819 (tui_data_item_window::refresh_window): New method.
2820 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2823 2019-08-30 Tom Tromey <tom@tromey.com>
2825 * tui/tui-regs.h (struct tui_data_window) <regs_content,
2826 regs_column_count, current_group>: Move later. Now private.
2827 <get_current_group>: New method.
2828 * tui/tui-regs.c (tui_reg_command): Update.
2829 * tui/tui-layout.c (tui_set_layout): Update.
2831 2019-08-30 Tom Tromey <tom@tromey.com>
2833 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2834 (tui_data_window::rerender): Don't call
2835 check_and_display_highlight_if_needed.
2836 (tui_data_window::refresh_all): Remove call to
2839 2019-08-30 Tom Tromey <tom@tromey.com>
2841 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2842 (tui_data_window::display_registers_from)
2843 (tui_data_window::display_reg_element_at_line)
2844 (tui_data_window::display_registers_from_line): Remove checks of
2847 2019-08-30 Tom Tromey <tom@tromey.com>
2849 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2851 * tui/tui-regs.c (tui_data_window::show_registers): Call
2853 (tui_data_window::rerender): Rename from display_all_data.
2854 (tui_data_window::rerender): Remove old implementation.
2856 2019-08-30 Tom Tromey <tom@tromey.com>
2858 * tui/tui-regs.c (tui_data_window::display_all_data): Change
2860 * tui/tui-data.h (NO_DATA_STRING): Remove define.
2862 2019-08-29 Bernhard Wodok <barto@gmx.net>
2863 Sergio Durigan Junior <sergiodj@redhat.com>
2866 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2868 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
2870 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2871 when searching for types.
2873 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
2875 * f-lang.c (f_language_defn): Use f_print_typedef.
2876 * f-lang.h (f_print_typedef): Declare.
2877 * f-typeprint.c (f_print_typedef): Define.
2879 2019-08-27 Christian Biesinger <cbiesinger@google.com>
2881 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2883 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
2885 * cli/cli-utils.c (info_print_options_defs): Delete.
2886 (make_info_print_options_def_group): Delete.
2887 (extract_info_print_options): Delete.
2888 (info_print_command_completer): Delete.
2889 (info_print_args_help): Add extra parameter, and optionally
2890 include text about -n flag.
2891 * cli/cli-utils.h (struct info_print_options): Delete.
2892 (extract_info_print_options): Delete declaration.
2893 (info_print_command_completer): Delete declaration.
2894 (info_print_args_help): Add extra parameter, extend header
2896 * python/python.c (gdbpy_rbreak): Pass additional parameter to
2898 * stack.c (struct info_print_options): New type.
2899 (info_print_options_defs): New file scoped variable.
2900 (make_info_print_options_def_group): New static function.
2901 (info_print_command_completer): New static function.
2902 (info_locals_command): Update to use new local functions.
2903 (info_args_command): Likewise.
2904 (_initialize_stack): Add extra parameter to calls to
2905 info_print_args_help.
2906 * symtab.c (search_symbols): Add extra parameter, use this to
2907 possibly excluse non-debug symbols.
2908 (symtab_symbol_info): Add extra parameter, which is passed on to
2910 (struct info_print_options): New type.
2911 (info_print_options_defs): New file scoped variable.
2912 (make_info_print_options_def_group): New static function.
2913 (info_print_command_completer): New static function.
2914 (info_variables_command): Update to use local functions, and pass
2915 extra parameter through to symtab_symbol_info.
2916 (info_functions_command): Likewise.
2917 (info_types_command): Pass additional argument through to
2919 (rbreak_command): Pass extra argument to search_symbols.
2920 (_initialize_symtab): Add extra arguments for calls to
2921 info_print_args_help, and update help text for 'info variables',
2922 'whereis', and 'info functions' commands.
2923 * symtab.h (search_symbols): Add extra argument to declaration.
2924 * NEWS: Mention new flags.
2926 2019-08-26 Christian Biesinger <cbiesinger@google.com>
2928 * symtab.c (lookup_static_symbol): Call the new function (and move
2929 it down to be next to lookup_global_symbol).
2930 (struct global_sym_lookup_data): Add block_enum member and rename to...
2931 (struct global_or_static_sym_lookup_data): ...this.
2932 (lookup_symbol_global_iterator_cb): Pass block_index instead of
2933 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2934 (lookup_symbol_global_or_static_iterator_cb): ...this.
2935 (lookup_global_or_static_symbol): New function.
2936 (lookup_global_symbol): Call new function.
2938 2019-08-26 Tom de Vries <tdevries@suse.de>
2941 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2942 when pc_probe.prob == NULL.
2944 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
2946 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2947 variable symbol_linkage to symbol_linkage_.
2949 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
2951 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2952 represent whether the symbol is static, dynamic, or we don't
2955 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
2957 * gdb/rx-tdep.c (rx_register_names): New.
2958 (rx_register_name): Delete.
2959 (rx_psw_type): Delete.
2960 (rx_fpsw_type): Delete.
2961 (rx_register_type): Delete.
2962 (rx_gdbarch_init): Convert target-descriptions.
2963 (_initialize_rx_tdep): Add initialize_tdesc_rx.
2964 * gdb/features/Makefile: Add rx.xml.
2965 * gdb/features/rx.xml: New.
2966 * gdb/features/rx.c: Generated.
2967 * gdb/NEWS: Mention target description support.
2969 2019-08-22 Christian Biesinger <cbiesinger@google.com>
2971 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2974 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
2976 * configure.ac: Don't check for 'dlfcn.h' (moved to
2977 gdbsupport/common.m4).
2978 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2980 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2981 * compile/compile-c-support.c: Include
2982 'gdbsupport/gdb-dlfcn.h'.
2983 * gdbsupport/common.m4: Check for 'dlfcn.h'.
2984 * gdb-dlfcn.c: Move to...
2985 * gdbsupport/gdb-dlfcn.c: ... here.
2986 * gdb-dlfcn.h: Move to...
2987 * gdbsupport/gdb-dlfcn.h: ... here.
2989 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
2991 * nios2-tdep.c (struct reg_value): Improve comments. Make
2992 the offset field signed.
2994 2019-08-22 Christian Biesinger <cbiesinger@google.com>
2996 * python/lib/gdb/__init__.py (_execute_file): New function.
2997 * python/python.c (python_run_simple_file): Call gdb._execute_file
3000 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
3002 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3003 all uses as this was never set to anything but a zero value.
3005 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
3007 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3009 2019-08-21 Christian Biesinger <cbiesinger@google.com>
3011 * tui/tui-data.h (tui_gen_win_info): Add an =default
3012 move constructor, required by some GCC versions.
3014 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
3016 * go32-nat.c (go32_sysinfo): Add hygon_p.
3018 2019-08-20 Tom Tromey <tom@tromey.com>
3020 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3021 line_from_reg_element_no, first_reg_element_no_inline,
3022 display_all_data, delete_data_content_windows,
3023 erase_data_content>: Now private.
3025 2019-08-20 Tom Tromey <tom@tromey.com>
3027 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3028 (tui_unhighlight_win, tui_highlight_win)
3029 (tui_win_info::make_window): Update.
3030 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3032 2019-08-20 Tom Tromey <tom@tromey.com>
3034 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3035 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3036 (MAX_PID_WIDTH): Move to tui-stack.c.
3037 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3038 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3039 (MAX_PID_WIDTH): Move from tui-data.h.
3041 2019-08-20 Tom Tromey <tom@tromey.com>
3043 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3044 * tui/tui-wingeneral.c (box_win): Change type of win_info.
3046 (tui_gen_win_info::make_window): Rename from tui_make_window.
3047 (tui_win_info::make_window): New method.
3048 (tui_gen_win_info::make_visible): Update.
3049 * tui/tui-source.c (tui_source_window::set_contents): Update.
3050 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3051 (tui_data_window::display_registers_from): Update.
3052 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3053 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3057 (struct tui_win_info) <make_window>: Declare.
3058 <can_box>: Now virtual.
3059 <title>: New member.
3060 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3061 * tui/tui-command.c (tui_cmd_window::resize): Update.
3063 2019-08-20 Tom Tromey <tom@tromey.com>
3065 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3066 * tui/tui-regs.c (tui_data_window::show_registers): Update.
3067 (tui_data_window::check_register_values): Update.
3069 2019-08-20 Tom Tromey <tom@tromey.com>
3071 * tui/tui-regs.h (struct tui_data_window): Use
3072 DISABLE_COPY_AND_ASSIGN.
3073 <regs_content>: Change type, removing unique_ptr.
3074 <tui_data_window>: Add move constructor.
3075 * tui/tui-regs.c (tui_data_window::show_registers)
3076 (tui_data_window::show_register_group)
3077 (tui_data_window::display_registers_from)
3078 (tui_data_window::display_registers_from)
3079 (tui_data_window::first_data_item_displayed)
3080 (tui_data_window::delete_data_content_windows)
3081 (tui_data_window::rerender, tui_data_window::refresh_window)
3082 (tui_data_window::check_register_values): Update.
3084 2019-08-20 Tom Tromey <tom@tromey.com>
3086 * tui/tui-regs.h (struct tui_data_window) <show_registers,
3087 show_register_group>: Declare.
3088 (tui_show_register_group): Don't declare.
3089 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3091 (tui_data_window::show_register_group): Rename from
3092 tui_show_register_group.
3093 (tui_data_window::check_register_values, tui_reg_command):
3095 * tui/tui-layout.c (tui_set_layout): Update.
3097 2019-08-20 Tom Tromey <tom@tromey.com>
3099 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3101 (tui_check_register_values): Don't declare.
3102 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3103 from tui_check_register_values.
3104 * tui/tui-hooks.c (tui_register_changed): Update.
3106 2019-08-20 Tom Tromey <tom@tromey.com>
3108 * tui/tui-regs.c (tui_reg_layout): Move later.
3109 (tui_show_registers): Don't enable TUI mode or change layout.
3111 2019-08-20 Tom Tromey <tom@tromey.com>
3113 * tui/tui-regs.h (struct tui_data_item_window)
3114 <~tui_data_item_window>: Remove.
3115 <content>: Now a unique_xmalloc_ptr.
3116 * tui/tui-regs.c (tui_register_format): Return a
3118 (tui_get_register): Update.
3119 (~tui_data_item_window): Remove.
3120 (tui_data_window::display_registers_from, tui_display_register):
3122 * tui/tui-io.h (tui_expand_tabs): Update.
3123 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3124 Remove "col" parameter.
3126 2019-08-20 Tom Tromey <tom@tromey.com>
3128 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3130 * tui/tui-regs.c (~tui_data_item_window): Update.
3132 2019-08-20 Tom Tromey <tom@tromey.com>
3134 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3137 2019-08-20 Tom Tromey <tom@tromey.com>
3139 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3141 2019-08-20 Tom Tromey <tom@tromey.com>
3143 * tui/tui-source.h (struct tui_source_window): Update.
3144 * tui/tui-regs.c (tui_show_registers): Update.
3145 * tui/tui-disasm.h (struct tui_disasm_window): Update.
3146 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3147 (NO_REGS_STRING): Remove defines.
3149 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
3151 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3152 unnecessary thread walk if remote doesn't support the packet.
3154 2019-08-19 Tom Tromey <tromey@adacore.com>
3156 * python/py-value.c (value_has_field): Fix indentation.
3158 2019-08-19 Tom Tromey <tromey@adacore.com>
3160 * printcmd.c (do_one_display, info_display_command): Update.
3161 * block.h (contained_in): Return bool. Add allow_nested
3163 * block.c (contained_in): Return bool. Add allow_nested
3166 2019-08-19 Tom Tromey <tom@tromey.com>
3168 * configure: Rebuild.
3169 * configure.ac: Disallow the combination of -static-libstdc++ and
3171 * source-cache.c (get_language_name): Handle rust.
3172 (source_cache::get_source_lines): Ignore highlighting exceptions.
3174 2019-08-16 Tom Tromey <tom@tromey.com>
3176 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3177 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3178 (struct tui_source_window_base) <make_visible, refresh_window,
3179 resize>: Remove methods.
3180 <execution_info>: Remove field.
3181 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3182 (tui_show_source_line, tui_source_window_base)
3183 (~tui_source_window_base): Update.
3184 (tui_source_window_base::resize)
3185 (tui_source_window_base::make_visible)
3186 (tui_source_window_base::refresh_window): Remove.
3187 (tui_source_window_base::update_exec_info): Update.
3188 * tui/tui-source.c (tui_source_window::set_contents): Update.
3189 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3191 2019-08-16 Tom Tromey <tom@tromey.com>
3193 * tui/tui-hooks.c (tui_remove_hooks): Don't set
3194 deprecated_query_hook.
3196 2019-08-16 Tom Tromey <tom@tromey.com>
3198 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3199 (tui_update_source_windows_with_line): Update.
3200 * tui/tui-source.h (struct tui_source_window)
3201 <show_symtab_source>: Declare.
3202 (tui_show_symtab_source): Don't declare.
3203 * tui/tui-source.c (tui_show_symtab_source): Rename from
3204 tui_show_symtab_source.
3206 2019-08-16 Tom Tromey <tom@tromey.com>
3208 * tui/tui-winsource.h (struct tui_source_window_base)
3209 <set_contents>: Declare.
3210 * tui/tui-winsource.c
3211 (tui_source_window_base::update_source_window_as_is): Update.
3212 * tui/tui-source.h (struct tui_source_window) <set_contents>:
3214 (tui_set_source_content): Don't declare.
3215 * tui/tui-source.c (tui_source_window::set_contents): Rename from
3216 tui_set_source_content.
3217 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3219 (tui_set_disassem_content): Don't declare.
3220 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3221 tui_set_disassem_content.
3223 2019-08-16 Tom Tromey <tom@tromey.com>
3225 * tui/tui-winsource.h (struct tui_source_window_base)
3226 <update_breakpoint_info>: Declare.
3227 (tui_update_breakpoint_info): Don't declare.
3228 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3229 (tui_update_all_breakpoint_info): Update.
3230 (tui_source_window_base::update_breakpoint_info): Rename from
3231 tui_update_breakpoint_info.
3232 (tui_source_window_base::update_exec_info): Update.
3234 2019-08-16 Tom Tromey <tom@tromey.com>
3236 * tui/tui-winsource.h (struct tui_source_window_base)
3237 <update_source_window>: Declare.
3238 (tui_update_source_window): Don't declare.
3239 * tui/tui-winsource.c
3240 (tui_source_window_base::update_source_window): Rename from
3241 tui_update_source_window.
3242 (tui_source_window_base::rerender): Update.
3243 * tui/tui-source.c (tui_source_window::maybe_update): Update.
3244 * tui/tui-disasm.c (tui_show_disassem)
3245 (tui_show_disassem_and_update_source)
3246 (tui_disasm_window::maybe_update): Update.
3248 2019-08-16 Tom Tromey <tom@tromey.com>
3250 * tui/tui-winsource.h (struct tui_source_window_base)
3251 <update_source_window_as_is>: Declare.
3252 (tui_update_source_window_as_is): Don't declare.
3253 * tui/tui-winsource.c (tui_update_source_window): Update
3254 (tui_source_window_base::update_source_window_as_is): Rename from
3255 tui_update_source_window_as_is.
3256 (tui_source_window_base::refill): Update.
3257 * tui/tui-source.c (tui_show_symtab_source): Update.
3258 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3261 2019-08-16 Tom Tromey <tom@tromey.com>
3263 * tui/tui-winsource.h (tui_update_source_window)
3264 (tui_update_source_window_as_is): Remove "noerror" parameter.
3265 * tui/tui-winsource.c (tui_update_source_window)
3266 (tui_update_source_window_as_is): Remove "noerror" parameter.
3267 (tui_update_source_windows_with_addr)
3268 (tui_update_source_windows_with_line)
3269 (tui_source_window_base::rerender)
3270 (tui_source_window_base::refill): Update.
3271 * tui/tui-source.h (tui_set_source_content)
3272 (tui_show_symtab_source): Remove "noerror" parameter.
3273 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3275 (tui_show_symtab_source): Likewise.
3276 (tui_source_window::maybe_update): Update.
3277 * tui/tui-disasm.c (tui_show_disassem)
3278 (tui_show_disassem_and_update_source)
3279 (tui_disasm_window::do_scroll_vertical)
3280 (tui_disasm_window::maybe_update): Update.
3282 2019-08-16 Tom Tromey <tom@tromey.com>
3284 * tui/tui.c (tui_is_window_visible): Update.
3285 * tui/tui-wingeneral.c (tui_make_window)
3286 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3287 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3288 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3289 (tui_set_win_height_command, parse_scrolling_args): Update.
3290 * tui/tui-source.c (tui_source_window::style_changed): Update.
3291 * tui/tui-regs.c (tui_show_registers)
3292 (tui_data_window::first_data_item_displayed)
3293 (tui_data_window::delete_data_content_windows)
3294 (tui_check_register_values, tui_reg_command): Update.
3295 * tui/tui-disasm.c (tui_show_disassem): Update.
3296 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3298 <is_visible>: Remove field.
3299 * tui/tui-data.c (tui_next_win, tui_prev_win)
3300 (tui_delete_invisible_windows): Update.
3302 2019-08-16 Tom Tromey <tom@tromey.com>
3304 * tui/tui-winsource.h (struct tui_source_window_base)
3305 <m_has_locator>: Remove.
3306 * tui/tui-layout.c (show_source_disasm_command, show_data)
3307 (show_source_or_disasm_and_command): Update.
3309 2019-08-16 Alan Hayward <alan.hayward@arm.com>
3311 * NEWS (Other MI changes): New subsection.
3312 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3313 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3314 * arch-utils.c (default_get_pc_address_flags): New function.
3315 * arch-utils.h (default_get_pc_address_flags): New declaration.
3316 * gdbarch.sh: Add get_pc_address_flags.
3317 * gdbarch.c: Regenerate.
3318 * gdbarch.h: Likewise.
3319 * stack.c (print_pc): New function.
3320 (print_frame_info) (print_frame): Call print_pc.
3322 2019-08-16 Tom de Vries <tdevries@suse.de>
3324 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3325 print_objfile_section_info.
3327 2019-08-15 Tom Tromey <tom@tromey.com>
3329 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3330 calling update_cmdwin_start_line.
3331 * tui/tui-winsource.h (struct tui_source_window_base)
3332 <do_make_visible_with_new_height, set_new_height>: Don't declare.
3333 <rerender>: Declare.
3334 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3336 (tui_source_window_base::set_new_height): Remove.
3337 (tui_source_window_base::rerender): Rename from
3338 do_make_visible_with_new_height.
3339 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3341 (tui_win_info::make_invisible_and_set_new_height)
3342 (tui_win_info::make_visible_with_new_height): Remove.
3343 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3345 * tui/tui-stack.c (tui_locator_window::rerender): New method.
3346 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3347 do_make_visible_with_new_height>: Don't declare.
3348 <rerender>: Declare.
3349 * tui/tui-regs.c (tui_data_window::rerender): Rename from
3351 (tui_data_window::do_make_visible_with_new_height): Remove.
3352 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3353 call tui_show_locator_content.
3354 (tui_gen_win_info::resize): Call rerender.
3355 (show_source_or_disasm_and_command): Don't call
3356 tui_show_locator_content.
3357 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3359 (struct tui_win_info) <rerender>: Declare.
3360 <set_new_height, make_invisible_and_set_new_height,
3361 make_visible_with_new_height>: Don't declare.
3362 * tui/tui-data.c (tui_win_list::rerender): New method.
3363 * tui/tui-command.h (struct tui_cmd_window)
3364 <do_make_visible_with_new_height>: Don't declare.
3366 (tui_cmd_window::do_make_visible_with_new_height): Remove.
3368 2019-08-15 Tom Tromey <tromey@adacore.com>
3370 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3371 * ada-lang.c (ada_enum_name): Likewise.
3373 2019-08-15 Christian Biesinger <cbiesinger@google.com>
3375 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3377 (GdbOutputErrorFile): Likewise.
3378 (global scope): Adjust constructor calls to GdbOutput{,Error}File
3380 (execute_unwinders): Rename to have a leading underscore.
3381 (auto_load_packages): Likewise.
3382 (global scope): Adjust call to auto_load_packages accordingly.
3383 (GdbSetPythonDirectory): Likewise.
3384 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3385 instead of execute_unwinders.
3387 2019-08-15 Tom Tromey <tom@tromey.com>
3389 * tui/tui-layout.c (show_layout, show_source_disasm_command)
3390 (show_data): Don't change window visibility.
3391 (tui_gen_win_info::resize): Remove special case for command
3392 window. Use wresize, when available.
3393 (show_source_or_disasm_and_command): Don't change window
3395 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3396 <make_visible>: New method.
3397 * tui/tui-command.c (tui_cmd_window::resize): New method.
3399 2019-08-15 Tom Tromey <tom@tromey.com>
3401 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3402 (struct tui_source_windows): New.
3403 * tui/tui-winsource.c (tui_display_main): Update.
3404 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3405 (new_height_ok, parse_scrolling_args): Update.
3406 * tui/tui-layout.c (show_layout, show_data): Update.
3407 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3408 (tui_add_to_source_windows): Don't declare.
3409 * tui/tui-data.c (source_windows, tui_source_windows)
3410 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3412 2019-08-15 Tom Tromey <tom@tromey.com>
3414 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3416 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3417 * tui/tui-layout.c (show_source_disasm_command, show_data):
3419 (tui_gen_win_info::resize): Rename.
3420 (show_source_or_disasm_and_command): Update.
3421 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3424 2019-08-15 Tom Tromey <tom@tromey.com>
3426 * tui/tui-stack.c (tui_initialize_static_data): Remove.
3427 * tui/tui-interp.c (tui_interp::init): Don't call
3428 tui_initialize_static_data.
3429 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3431 2019-08-15 Tom Tromey <tom@tromey.com>
3433 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3434 examine tui_win_list.
3436 2019-08-15 Tom Tromey <tom@tromey.com>
3438 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3439 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3440 tui_clear_source_content.
3441 (tui_clear_source_content): Remove.
3442 (tui_source_window_base::do_erase_source_content): Hoist call to
3444 * tui/tui-stack.c (tui_show_frame_info): Don't call
3445 tui_clear_source_content.
3447 2019-08-15 Tom Tromey <tom@tromey.com>
3449 * tui/tui-winsource.h (struct tui_source_window_base)
3450 <do_erase_source_content>: New method.
3451 <erase_source_content>: New method.
3452 (tui_erase_source_content): Don't declare.
3453 * tui/tui-winsource.c (tui_clear_source_content): Update.
3454 (tui_source_window_base::do_erase_source_content): Rename from
3455 tui_erase_source_content.
3456 (tui_source_window_base::show_source_content): Update.
3457 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3458 * tui/tui-source.h (struct tui_source_window)
3459 <erase_source_content>: New method.
3460 * tui/tui-disasm.h (struct tui_disasm_window)
3461 <erase_source_content>: New method.
3463 2019-08-15 Tom Tromey <tom@tromey.com>
3465 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3466 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3468 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3469 * tui/tui-source.c (tui_set_source_content): Update.
3470 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3472 2019-08-15 Tom Tromey <tom@tromey.com>
3474 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3475 * tui/tui-winsource.c (tui_line_is_displayed): Move to
3477 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3479 * tui/tui-source.c (tui_source_window::line_is_displayed): New
3481 (tui_source_window::maybe_update): Update.
3483 2019-08-15 Tom Tromey <tom@tromey.com>
3485 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3486 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3488 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3490 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3492 (tui_disasm_window::maybe_update): Update.
3494 2019-08-15 Tom Tromey <tom@tromey.com>
3496 * tui/tui-winsource.h (struct tui_source_window_base)
3497 <maybe_update>: Declare.
3498 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3500 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3502 * tui/tui-source.c (tui_source_window::maybe_update): New method.
3503 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3505 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3507 2019-08-15 Tom Tromey <tom@tromey.com>
3509 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3511 2019-08-15 Tom Tromey <tom@tromey.com>
3513 * tui/tui-wingeneral.c: Include tui-stack.h.
3514 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3515 (struct tui_locator_window): Move from tui-data.h.
3516 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3517 (tui_initialize_static_data): Move from tui-data.c.
3518 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3519 (struct tui_locator_window): Move to tui-stack.c.
3520 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3521 (tui_initialize_static_data): Move to tui-stack.c.
3523 2019-08-15 Tom Tromey <tom@tromey.com>
3525 * tui/tui-layout.c (show_source_disasm_command)
3526 (show_source_or_disasm_and_command): Use make_visible method, not
3528 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3531 2019-08-15 Tom Tromey <tom@tromey.com>
3533 * tui/tui-wingeneral.h (tui_make_window): Update.
3534 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3536 (tui_gen_win_info::make_visible): Update.
3537 * tui/tui-regs.c (tui_data_window::display_registers_from):
3539 * tui/tui-layout.c (show_source_disasm_command)
3540 (show_source_or_disasm_and_command): Update.
3541 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3542 (enum tui_box): Remove.
3543 (struct tui_win_info) <can_box>: New method.
3544 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3547 2019-08-15 Tom de Vries <tdevries@suse.de>
3549 * linux-nat-trad.c: Include gdbarch.h.
3551 2019-08-14 Alan Hayward <alan.hayward@arm.com>
3553 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3556 2019-08-14 Tom Tromey <tromey@adacore.com>
3558 * darwin-nat.c: Include gdbarch.h.
3559 * darwin-nat-info.c: Include gdbarch.h.
3561 2019-08-13 Tom Tromey <tom@tromey.com>
3563 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3565 * tui/tui-data.c (tui_initialize_static_data): Update.
3567 2019-08-13 Tom Tromey <tom@tromey.com>
3569 * tui/tui-winsource.h (struct tui_exec_info_window)
3570 <~tui_exec_info_window, maybe_allocate_content, get_content,
3572 (struct tui_source_window_base) <set_exec_info_content,
3573 show_exec_info_content>: Don't declare.
3574 * tui/tui-winsource.c
3575 (tui_exec_info_window::maybe_allocate_content): Remove.
3576 (tui_source_window_base::update_exec_info): Rename from
3577 set_exec_info_content.
3578 (tui_source_window_base::show_exec_info_content)
3579 (tui_source_window_base::update_exec_info): Remove.
3581 2019-08-13 Tom Tromey <tom@tromey.com>
3583 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3585 * tui/tui-winsource.c (tui_update_source_window_as_is)
3586 (tui_update_source_windows_with_addr, tui_erase_source_content):
3588 (tui_clear_exec_info_content): Remove.
3590 2019-08-13 Tom Tromey <tom@tromey.com>
3592 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3594 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3595 call tui_erase_exec_info_content.
3596 (tui_clear_exec_info_content): Rename from
3597 tui_erase_exec_info_content.
3598 (tui_clear_exec_info_content): Delete.
3600 2019-08-13 Tom Tromey <tom@tromey.com>
3602 * tui/tui-winsource.h (struct tui_source_window_base)
3603 <show_exec_info_content>: Declare.
3604 (tui_show_exec_info_content): Don't declare.
3605 * tui/tui-winsource.c
3606 (tui_source_window_base::show_exec_info_content): Rename from
3607 tui_show_exec_info_content.
3608 (tui_source_window_base::update_exec_info): Update.
3610 2019-08-13 Tom Tromey <tom@tromey.com>
3612 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3613 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3614 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3615 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3616 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3617 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3620 2019-08-13 Tom Tromey <tom@tromey.com>
3622 * tui/tui-winsource.h (struct tui_source_window_base)
3623 <update_exec_info>: Declare.
3624 (tui_update_exec_info): Don't declare.
3625 * tui/tui-winsource.c (tui_update_source_window_as_is)
3626 (tui_source_window_base::refresh_all)
3627 (tui_update_all_breakpoint_info): Update.
3628 (tui_source_window_base::update_exec_info): Rename from
3629 tui_update_exec_info.
3630 * tui/tui-stack.c (tui_show_frame_info): Update.
3632 2019-08-13 Tom Tromey <tom@tromey.com>
3634 * tui/tui-winsource.h (struct tui_source_window_base)
3635 <set_exec_info_content>: Declare.
3636 (tui_set_exec_info_content): Don't declare.
3637 * tui/tui-winsource.c
3638 (tui_source_window_base::set_exec_info_content): Rename from
3639 tui_set_exec_info_content.
3640 (tui_update_exec_info): Update.
3642 2019-08-13 Tom Tromey <tom@tromey.com>
3644 * tui/tui-winsource.h (struct tui_source_window_base)
3645 <show_source_content>: Declare.
3646 (tui_show_source_content): Don't declare.
3647 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3648 (tui_source_window_base::show_source_content): Rename from
3649 tui_show_source_content.
3650 (tui_source_window_base::refresh_all): Update.
3651 * tui/tui-layout.c (show_source_disasm_command)
3652 (show_source_or_disasm_and_command): Update.
3654 2019-08-13 Tom Tromey <tom@tromey.com>
3656 * tui/tui-winsource.c (tui_erase_source_content)
3657 (tui_show_source_content, tui_source_window_base::refresh_all):
3659 * tui/tui-wingeneral.h
3660 (tui_check_and_display_highlight_if_needed): Don't declare.
3661 * tui/tui-wingeneral.c
3662 (tui_win_info::check_and_display_highlight_if_needed): Rename from
3663 check_and_display_highlight_if_needed.
3664 * tui/tui-win.c (tui_rehighlight_all)
3665 (tui_win_info::make_visible_with_new_height): Update.
3666 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3667 (tui_data_window::erase_data_content)
3668 (tui_data_window::display_all_data): Update.
3669 * tui/tui-data.h (struct tui_win_info)
3670 <check_and_display_highlight_if_needed>: Declare.
3672 2019-08-13 Tom Tromey <tom@tromey.com>
3674 * tui/tui-win.c (tui_resize_all): Call
3675 tui_delete_invisible_windows.
3676 * tui/tui-layout.c (show_layout): Call
3677 tui_delete_invisible_windows.
3678 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3679 * tui/tui-data.c (tui_delete_invisible_windows): New function.
3681 2019-08-13 Tom Tromey <tom@tromey.com>
3683 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
3684 tui_add_win_to_layout.
3686 2019-08-13 Tom Tromey <tom@tromey.com>
3688 * tui/tui-layout.h (tui_default_win_height): Don't declare.
3689 * tui/tui-layout.c (tui_default_win_height): Now static.
3691 2019-08-13 Tom Tromey <tom@tromey.com>
3693 * tui/tui-layout.c (show_layout): Unify all layout cases into a
3695 (show_source_disasm_command, show_source_or_disasm_and_command):
3696 Don't check current layout.
3698 2019-08-13 Tom Tromey <tom@tromey.com>
3700 * tui/tui-wingeneral.c (make_all_visible): Remove.
3701 (tui_make_all_invisible): Simplify.
3702 * tui/tui-layout.c (tui_make_all_invisible): Move from
3703 tui-wingeneral.c; simplify.
3704 (show_layout): Hoist call to tui_make_all_invisible.
3705 (show_data): Don't call tui_make_all_invisible.
3707 2019-08-13 Tom Tromey <tom@tromey.com>
3709 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3710 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3712 2019-08-13 Tom Tromey <tom@tromey.com>
3714 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3716 (show_source_disasm_command, show_data)
3717 (show_source_or_disasm_and_command): Don't use
3718 tui_set_current_layout_to.
3719 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3720 * tui/tui-data.c (current_layout, tui_current_layout): Move to
3722 (tui_set_current_layout_to): Remove.
3724 2019-08-13 Tom Tromey <tom@tromey.com>
3726 * tui/tui-layout.c (tui_set_layout): Update.
3727 * tui/tui-data.h (struct tui_layout_def): Remove.
3728 (tui_layout_def): Don't declare.
3729 * tui/tui-data.c (layout_def): Remove.
3730 (tui_layout_def): Remove.
3732 2019-08-13 Tom Tromey <tom@tromey.com>
3734 * tui/tui-winsource.h (struct tui_source_window_base)
3735 <clear_detail>: No longer "override".
3736 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3737 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3738 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3739 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3741 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3743 2019-08-13 Tom Tromey <tromey@adacore.com>
3745 * tracepoint.c: Don't include readline.h or history.h.
3747 2019-08-12 Tom Tromey <tom@tromey.com>
3749 * configure: Rebuild.
3750 * configure.ac: Check for readline 7.
3751 * NEWS: Mention readline 7 requirement.
3754 2019-08-12 Tom Tromey <tom@tromey.com>
3756 * mingw-hdep.c (gdb_select): Remove readline hack.
3758 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
3760 * blockframe.c (find_pc_partial_function): Set *block to nullptr
3761 when the function fails.
3763 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
3765 * s390-tdep.c (s390_type_align): New function.
3766 (s390_gdbarch_init): Set it as type_align gdbarch method.
3768 2019-08-09 Tom de Vries <tdevries@suse.de>
3771 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3772 pc_low with relocation offset.
3774 2019-08-07 Tom Tromey <tromey@adacore.com>
3776 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3777 (print_frame_args): Update.
3778 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3780 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3781 * frame.h (struct frame_arg): Add initializers.
3782 <error>: Now a unique_xmalloc_ptr.
3784 2019-08-07 Alan Hayward <alan.hayward@arm.com>
3786 * NEWS: Expand the Pointer Authentication entry.
3787 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3788 (aarch64_frame_unmask_lr): ... to this.
3789 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3790 Call aarch64_frame_unmask_lr.
3791 * frame.c (struct frame_info): Add "masked" variable.
3792 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3793 (fprint_frame): Check for masked pc.
3794 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3796 * python/py-framefilter.c (py_print_frame): Check for masked pc.
3797 * stack.c (print_frame): Check for masked pc.
3799 2019-08-06 Tom Tromey <tom@tromey.com>
3801 * stabsread.c (patch_block_stabs, read_one_struct_field)
3802 (read_enum_type): Use obstack_strndup.
3803 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3804 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3805 * dwarf2read.c (guess_full_die_structure_name)
3806 (anonymous_struct_prefix): Use obstack_strndup.
3807 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3808 * c-exp.y (yylex): Use obstack_strndup.
3809 * ada-exp.y (write_object_renaming, write_ambiguous_var)
3810 (write_var_or_type): Use obstack_strndup.
3812 2019-08-06 Tom Tromey <tom@tromey.com>
3814 * symfile.c (reread_symbols): Use obstack_strdup.
3815 * stabsread.c (read_type): Use obstack_strdup.
3816 * gdb_obstack.h (obstack_strdup): New overload.
3817 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3818 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3819 (dwarf2_canonicalize_name): Use obstack_strdup.
3820 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3821 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3824 2019-08-06 Tom Tromey <tom@tromey.com>
3826 * gdb_obstack.h (obstack_strdup): Define.
3827 * gdb_obstack.c (obstack_strdup): Don't define.
3829 2019-08-06 Tom Tromey <tom@tromey.com>
3831 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3833 * typeprint.c (typedef_hash_table::find_global_typedef): Use
3835 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3836 * stabsread.c (common_block_start): Use obstack_strdup.
3837 * objfiles.c (set_objfile_main_name, objfile): Use
3839 * namespace.c (add_using_directive): Use obstack_strdup.
3840 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3841 * jit.c (finalize_symtab): Use obstack_strdup.
3842 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3843 (guess_partial_die_structure_name, partial_die_info::fixup)
3844 (dwarf2_name): Use obstack_strdup.
3845 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3847 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3848 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3850 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3852 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3854 * unittests/help-doc-selftests.c: New file.
3855 * Makefile.in: Add the new file.
3857 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3859 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3860 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
3861 the full first line, except when FOR_VALUE_PREFIX. In this case,
3862 the trailing '.' is not output, and the first character is uppercased.
3863 (print_help_for_command): Update call to print_doc_line.
3864 (print_doc_of_command): Likewise.
3865 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3866 * cli/cli-option.c (append_indented_doc): Do not append newline.
3867 (build_help_option): Append newline after first appended_indented_doc
3868 only if a second call is done.
3869 (build_help): Append 2 new lines before each option, except the first
3871 * compile/compile.c (_initialize_compile): Add new lines after
3872 %OPTIONS%, when not at the end of the help.
3873 Change help doc or code
3874 producing the help doc to respect the invariants.
3875 * maint-test-options.c (_initialize_maint_test_options): Likewise.
3876 Also removed the new line after 'Options:', as all other commands
3877 do not put an empty line between 'Options:' and the first option.
3878 * printcmd.c (_initialize_printcmd): Likewise.
3879 * stack.c (_initialize_stack): Likewise.
3880 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3881 incorrectly telling COMMAND is optional.
3882 * ada-lang.c (_initialize_ada_language): Change help doc or code
3883 producing the help doc to respect the invariants.
3884 * ada-tasks.c (_initialize_ada_tasks): Likewise.
3885 * breakpoint.c (_initialize_breakpoint): Likewise.
3886 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3887 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3888 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3889 * cli/cli-style.c (cli_style_option::add_setshow_commands,
3890 _initialize_cli_style): Likewise.
3891 * corelow.c (core_target_info): Likewise.
3892 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3893 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3894 * filesystem.c (_initialize_filesystem): Likewise.
3895 * frame.c (_initialize_frame): Likewise.
3896 * gnu-nat.c (add_task_commands): Likewise.
3897 * infcall.c (_initialize_infcall): Likewise.
3898 * infcmd.c (_initialize_infcmd): Likewise.
3899 * interps.c (_initialize_interpreter): Likewise.
3900 * language.c (_initialize_language): Likewise.
3901 * linux-fork.c (_initialize_linux_fork): Likewise.
3902 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3903 * maint.c (_initialize_maint_cmds): Likewise.
3904 * memattr.c (_initialize_mem): Likewise.
3905 * printcmd.c (_initialize_printcmd): Likewise.
3906 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3908 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3909 * record-btrace.c (_initialize_record_btrace): Likewise.
3910 * record-full.c (_initialize_record_full): Likewise.
3911 * record.c (_initialize_record): Likewise.
3912 * regcache-dump.c (_initialize_regcache_dump): Likewise.
3913 * regcache.c (_initialize_regcache): Likewise.
3914 * remote.c (add_packet_config_cmd, init_remote_threadtests,
3915 _initialize_remote): Likewise.
3916 * ser-tcp.c (_initialize_ser_tcp): Likewise.
3917 * serial.c (_initialize_serial): Likewise.
3918 * skip.c (_initialize_step_skip): Likewise.
3919 * source.c (_initialize_source): Likewise.
3920 * stack.c (_initialize_stack): Likewise.
3921 * symfile.c (_initialize_symfile): Likewise.
3922 * symtab.c (_initialize_symtab): Likewise.
3923 * target-descriptions.c (_initialize_target_descriptions): Likewise.
3924 * top.c (init_main): Likewise.
3925 * tracefile-tfile.c (tfile_target_info): Likewise.
3926 * tracepoint.c (_initialize_tracepoint): Likewise.
3927 * tui/tui-win.c (_initialize_tui_win): Likewise.
3928 * utils.c (add_internal_problem_command): Likewise.
3929 * valprint.c (value_print_option_defs): Likewise.
3931 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
3934 * configure.ac: Drop enable-libmcheck support.
3935 * configure, config.in: Rebuild.
3936 * libmcheck.m4: Remove.
3937 * acinclude.m4: Don't include it.
3938 * Makefile.in: Don't distribute it.
3939 * top.c (print_gdb_configuration): Don't mention it.
3941 2019-08-06 Tom Tromey <tom@tromey.com>
3943 * utils.c (set_output_style): Sometimes pass stream to
3945 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3946 * record-btrace.c (btrace_insn_history): Update.
3947 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3949 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3950 Update initializers.
3951 <m_uiout>: New field.
3953 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3954 Remove "uiout" parameter.
3955 (dump_insns): Update.
3956 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3957 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3959 2019-08-06 Christian Biesinger <cbiesinger@google.com>
3961 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3962 (error_in_psymtab_expansion): Likewise.
3963 (lookup_symbol_via_quick_fns): Likewise.
3964 (basic_lookup_transparent_type_quick): Likewise.
3965 (basic_lookup_transparent_type_1): Likewise.
3967 2019-08-06 Tom Tromey <tromey@adacore.com>
3969 * source.c (last_source_error): Now bool.
3970 (print_source_lines_base): Make "noprint" bool. Only open
3971 source file when last_source_visited changes.
3973 2019-08-06 Tom Tromey <tromey@adacore.com>
3975 * annotate.c (annotate_source_line): Use g_source_cache.
3976 * source-cache.c (source_cache::get_plain_source_lines): Change
3977 parameters. Populate m_offset_cache.
3978 (source_cache::ensure): New method.
3979 (source_cache::get_line_charpos): New method.
3980 (extract_lines): Move lower. Change parameters.
3981 (source_cache::get_source_lines): Move lower.
3982 * source-cache.h (class source_cache): Update comment.
3983 <get_line_charpos>: New method.
3984 <get_source_lines>: Update comment.
3985 <clear>: Clear m_offset_cache.
3986 <get_plain_source_lines>: Change parameters.
3987 <ensure>: New method
3988 <m_offset_cache>: New member.
3989 * source.c (forget_cached_source_info_for_objfile): Update.
3990 (info_source_command): Use g_source_cache.
3991 (find_source_lines, open_source_file_with_line_charpos): Remove.
3992 (print_source_lines_base, search_command_helper): Use g_source_cache.
3993 * source.h (open_source_file_with_line_charpos): Don't declare.
3994 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3995 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3998 2019-08-06 Tom Tromey <tromey@adacore.com>
4000 * source-cache.c (source_cache::get_plain_source_lines):
4001 Remove "first_line" and "last_line" parameters.
4002 (source_cache::get_source_lines): Cache plain text.
4003 * source-cache.h (class source_cache)
4004 <get_plain_source_lines>: Update.
4006 2019-08-06 Tom Tromey <tromey@adacore.com>
4008 * source-cache.c (extract_lines): No longer a method.
4009 Changed type of parameter. Include final newline.
4010 (selftests::extract_lines_test): New function.
4011 (_initialize_source_cache): Likewise.
4012 * source-cache.h (class source_cache)
4013 <extract_lines>: Don't declare.
4015 2019-08-06 Tom Tromey <tromey@adacore.com>
4017 * breakpoint.c (init_breakpoint_sal): Update.
4018 (breakpoint): Update.
4019 * breakpoint.h (struct breakpoint) <filter>: Now a
4022 2019-08-05 Christian Biesinger <cbiesinger@google.com>
4024 * NEWS: Mention dictionary access on blocks.
4025 * python/py-block.c (blpy_getitem): New function.
4026 (block_object_as_mapping): New struct.
4027 (block_object_type): Use new struct for tp_as_mapping field.
4029 2019-08-05 Christian Biesinger <cbiesinger@google.com>
4031 * objfiles.h (objfile): Add a comment describing partial symbols.
4033 2019-08-05 Tom Tromey <tromey@adacore.com>
4035 * compile/compile.c (_initialize_compile): Use _(), not N_().
4036 * thread.c (_initialize_thread): Use _(), not N_().
4037 * stack.c (_initialize_stack): Use _(), not N_().
4038 * printcmd.c (_initialize_printcmd): Use _(), not N_().
4040 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
4042 * dwarf2read.c (struct dw2_symtab_iterator):
4043 <want_specific_block>: Remove.
4044 <block_index>: Change type to gdb::optional.
4045 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4046 change type of BLOCK_INDEX parameter to gdb::optional.
4047 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4048 (dw2_lookup_symbol): Don't pass argument for
4049 WANT_SPECIFIC_BLOCK.
4050 (dw2_expand_symtabs_for_function): Don't pass argument for
4051 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4052 (class dw2_debug_names_iterator)
4053 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4054 parameter, change BLOCK_INDEX type to gdb::optional.
4055 <m_want_specific_block>: Remove.
4056 <m_block_index>: Change type to gdb::optional.
4057 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4058 gdb::optional. Re-write in function of gdb::optional.
4059 (dw2_debug_names_lookup_symbol): Don't pass argument for
4060 WANT_SPECIFIC_BLOCK.
4061 (dw2_debug_names_expand_symtabs_for_function): Don't pass
4062 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4065 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4067 * NEWS: Mention changes to "info sources" command.
4069 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4071 * symtab.c (filename_partial_match_opts): New struct type.
4072 (struct output_source_filename_data): New members
4073 regexp, c_regexp, partial_match.
4074 (output_source_filename): Use new members to decide to print file.
4075 (info_sources_option_defs): New variable.
4076 (make_info_sources_options_def_group, print_info_sources_header,
4077 info_sources_command_completer):
4079 (info_sources_command): Read new optional arguments.
4080 (_initialize_symtab): Update info sources help.
4082 2019-08-02 Alexandre Oliva <oliva@adacore.com>
4084 * ada-lang.c (exception_support_info_v0): Renamed from...
4085 (default_exception_support_info): ... this. Create new
4087 (ada_has_this_exception_support): Look up catch_handlers_sym.
4088 (ada_exception_support_info_sniffer): Try v0 after default.
4090 2019-08-01 Tom Tromey <tromey@adacore.com>
4092 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4095 2019-08-01 Christian Biesinger <cbiesinger@google.com>
4097 * s12z-tdep.c: Fix include path for s12z-opc.h.
4099 2019-08-01 Alan Hayward <alan.hayward@arm.com>
4101 * NEWS: Require GNU make 3.82.
4103 2019-07-16 Tom Tromey <tom@tromey.com>
4105 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4108 2019-07-30 Tom Tromey <tromey@adacore.com>
4110 * block.c (contained_in): Remove BLOCK_FUNCTION check.
4112 2019-07-30 Kevin Buettner <kevinb@redhat.com>
4114 * printcmd.c (print_address_symbolic): Print negative offsets.
4115 (build_address_symbolic): Force signed arithmetic when computing
4118 2019-07-30 Christian Biesinger <cbiesinger@google.com>
4120 PR/24474: Add a function to lookup static variables.
4121 * NEWS: Mention this new function.
4122 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4123 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4124 * python/python.c (python_GdbMethods): Add new function.
4126 2019-07-29 Christian Biesinger <cbiesinger@google.com>
4128 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4129 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4130 (objfpy_lookup_static_symbol): New function.
4131 (objfile_object_methods): Add new functions.
4133 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4135 * NEWS: Mention 'set|show print frame-info'. Mention new
4136 'presence' value for 'frame-arguments'. Mention new '-frame-info'
4137 backtrace argument. Mention that python frame filtering code
4138 is now consistent with what 'backtrace' command prints.
4140 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4142 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4144 (print_frame_info_auto, print_frame_info_source_line,
4145 print_frame_info_location, print_frame_info_source_and_location,
4146 print_frame_info_location_and_address, print_frame_info_short_location):
4148 (struct frame_print_options): New member print_frame_info.
4149 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4150 * stack.h (get_user_print_what_frame_info): New declaration.
4151 (frame_show_address): New declaration.
4152 * stack.c (print_frame_arguments_choices): New value 'presence'.
4153 (print_frame_info_auto, print_frame_info_source_line,
4154 print_frame_info_location, print_frame_info_source_and_location,
4155 print_frame_info_location_and_address, print_frame_info_short_location,
4156 print_frame_info_choices, print_frame_info_print_what): New definitions.
4157 (print_frame_args): Only print dots for args if print frame-arguments
4159 (frame_print_option_defs): New element for "frame-info".
4160 (get_user_print_what_frame_info): New function.
4161 (frame_show_address): Make non static. Move comment to stack.h.
4162 (print_frame_info_to_print_what): New function.
4163 (print_frame_info): Update comment. Use fp_opts.print_frame_info
4164 to decide what to print.
4165 (backtrace_command_1): Handle the new print_frame_arguments_presence
4167 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4168 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4169 (py_print_frame): In non-mi mode, use LOCATION as default for
4170 print_what, similarly to frame information printed directly by
4171 backtrace command. Handle frame-info user option in non MI mode.
4173 2019-07-27 Kevin Buettner <kevinb@redhat.com>
4175 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4176 Add case for debugging 32-bit target on 64-bit host. Revise
4179 2019-07-27 Kevin Buettner <kevinb@redhat.com>
4181 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4182 instead of find_function_entry_range_from_pc.
4184 2019-07-27 Kevin Buettner <kevinb@redhat.com>
4186 * stack.c (find_frame_funname): Remove code which preferred
4187 minsym over symtab sym in "certain pathological cases".
4189 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4190 parameter. Change type of "do_demangle" to bool.
4191 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4192 Pass suitable "prefer_sym_over_minsym" flag to
4193 build_address_symbolic(). Don't output "+" for negative offsets.
4194 * printcmd.c (print_address_symbolic): Update invocation of
4195 build_address_symbolic to include a "prefer_sym_over_minsym"
4197 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4198 Restrict cases in which use of minimal symbol is preferred to that
4199 of a found symbol. Update comments.
4201 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4202 for entry pc when entry pc is out of range for that FDE.
4204 2019-07-26 Brian Callahan <bcallah@openbsd.org>
4207 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4210 2019-07-25 Christian Biesinger <cbiesinger@google.com>
4212 * python/py-objfile.c (add_separate_debug_file): Fix comment about
4213 this function's Python signature.
4216 2019-07-24 Christian Biesinger <cbiesinger@google.com>
4218 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4219 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4220 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4221 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4222 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4225 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
4227 * h8300-tdep.c (h8300_register_name_common): New.
4228 h8300_register_name): Use h8300_register_name_common.
4229 (h8300s_register_name): Likewise.
4230 (h8300sx_register_name): Likewise.
4231 (h8300h_register_nam): New.
4232 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4235 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
4237 * arm-tdep.c (arm_skip_cmse_entry): New function.
4238 (arm_is_sgstubs_section): New function.
4239 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4241 2019-07-22 Tom Tromey <tom@tromey.com>
4243 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4246 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
4248 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4251 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
4253 * symtab.c (search_symbols): Adjust msymbol matching type arrays
4254 so that GDB doesn't match any msymbols when searching in the
4256 (print_symbol_info): Print using typedef_print or type_print based
4257 on the type of the symbol. Add updated FIXME comment moved from...
4258 (_initialize_symtab): ... move and update FIXME comment to above.
4260 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
4262 * NEWS: Mention adding -q option to "info types".
4263 * symtab.c (struct info_types_options): New struct.
4264 (info_types_options_defs): New variable.
4265 (make_info_types_options_def_group): New function.
4266 (info_types_command): Use gdb::option framework to parse options.
4267 (info_types_command_completer): New function.
4268 (_initialize_symtab): Extend the help text on "info types" and
4269 register command completer.
4271 2019-07-21 Christian Biesinger <cbiesinger@google.com>
4273 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4274 (lookup_symbol_in_objfile): Change int to block_enum and add a
4275 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4277 2019-07-20 Christian Biesinger <cbiesinger@google.com>
4279 * MAINTAINERS (Write After Approval): Add self.
4281 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
4283 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4284 instruction to the dummy code region.
4286 2019-07-19 Tom Tromey <tromey@adacore.com>
4288 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4289 (ARGSUSED, PARAMS, __func__): Remove rules.
4291 2019-07-19 Alan Hayward <alan.hayward@arm.com>
4293 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4294 * features/arm/arm-with-iwmmxt.c: Remove.
4295 * features/arm/arm-with-iwmmxt.xml: Remove.
4296 * features/arm/arm-with-m-fpa-layout.c: Remove.
4297 * features/arm/arm-with-m-fpa-layout.xml: Remove.
4298 * features/arm/arm-with-m-vfp-d16.c: Remove.
4299 * features/arm/arm-with-m-vfp-d16.xml: Remove.
4300 * features/arm/arm-with-m.c: Remove.
4301 * features/arm/arm-with-m.xml: Remove.
4302 * features/arm/arm-with-neon.c: Remove.
4303 * features/arm/arm-with-neon.xml: Remove.
4304 * features/arm/arm-with-vfpv2.c: Remove.
4305 * features/arm/arm-with-vfpv2.xml: Remove.
4306 * features/arm/arm-with-vfpv3.c: Remove.
4307 * features/arm/arm-with-vfpv3.xml: Remove.
4309 2019-07-19 Alan Hayward <alan.hayward@arm.com>
4311 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4313 2019-07-19 Alan Hayward <alan.hayward@arm.com>
4315 * arch/aarch32.c (aarch32_create_target_description): Create
4316 target descriptions using features.
4317 * arch/arm.c (arm_create_target_description)
4318 (arm_create_mprofile_target_description): Likewise.
4319 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4321 2019-07-19 Alan Hayward <alan.hayward@arm.com>
4323 * Makefile.in: Add new files.
4324 * aarch32-tdep.c: New file.
4325 * aarch32-tdep.h: New file.
4326 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4327 Call aarch32_read_description.
4328 * arch/aarch32.c: New file.
4329 * arch/aarch32.h: New file.
4330 * arch/arm.c (arm_create_target_description)
4331 (arm_create_mprofile_target_description): New function.
4332 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4333 (arm_create_target_description)
4334 (arm_create_mprofile_target_description): New declaration.
4335 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4336 read_description functions.
4337 * arm-linux-nat.c (arm_linux_nat_target::read_description):
4339 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4340 * arm-tdep.c (tdesc_arm_list): New variable.
4341 (arm_register_g_packet_guesses): Call create description functions.
4342 (arm_read_description) (arm_read_mprofile_description): New
4344 * arm-tdep.h (arm_read_description)
4345 (arm_read_mprofile_description): Add declaration.
4346 * configure.tgt: Add new files.
4348 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
4350 * top.c (new_ui_command): Open specified terminal just once.
4352 2019-07-18 Tom Tromey <tromey@adacore.com>
4354 * symtab.c (main_name): Constify return type.
4355 * symfile.c (set_initial_language): Update.
4356 * symtab.h (main_name): Constify return type.
4358 2019-07-17 Tom Tromey <tom@tromey.com>
4360 * tui/tui-winsource.c (tui_update_source_window)
4361 (tui_update_source_window_as_is)
4362 (tui_update_source_windows_with_line): Remove return.
4363 * tui/tui-disasm.c (tui_show_disassem)
4364 (tui_show_disassem_and_update_source): Remove return.
4365 * tui/tui.c (tui_reset): Remove return.
4366 * tui/tui-wingeneral.c
4367 (tui_check_and_display_highlight_if_needed): Remove return.
4369 2019-07-17 Tom Tromey <tom@tromey.com>
4371 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4373 2019-07-17 Tom Tromey <tom@tromey.com>
4375 * tui/tui-winsource.h (struct tui_exec_info_window)
4376 (struct tui_source_window_base): Move from tui-data.h.
4377 * tui/tui-winsource.c: Move many method definitions from
4378 elsewhere. Remove "structuring" comments.
4379 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4380 (tui_source_window_base::refresh_window): Move to
4382 * tui/tui-win.c (tui_source_window_base::refresh_all)
4383 (tui_source_window_base::update_tab_width)
4384 (tui_source_window_base::set_new_height)
4385 (tui_source_window_base::do_make_visible_with_new_height): Move to
4387 * tui/tui-source.h: Update.
4388 * tui/tui-source.c (tui_source_window_base::reset): Move to
4390 * tui/tui-disasm.h: Update.
4391 * tui/tui-data.h (struct tui_exec_info_window): Move to
4393 (struct tui_source_window_base): Likewise.
4394 * tui/tui-data.c (tui_source_window_base::clear_detail)
4395 (tui_source_window_base, ~tui_source_window_base): Move to
4398 2019-07-17 Tom Tromey <tom@tromey.com>
4400 * tui/tui-win.c (tui_resize_all)
4401 (tui_source_window_base::update_tab_width)
4402 (tui_adjust_win_heights): Update.
4403 (tui_win_info::make_invisible_and_set_new_height): Rename from
4404 make_invisible_and_set_new_height.
4405 * tui/tui-data.h (struct tui_win_info)
4406 <make_invisible_and_set_new_height>: New method.
4408 2019-07-17 Tom Tromey <tom@tromey.com>
4410 * tui/tui.c: Update.
4411 * tui/tui-source.h (struct tui_source_window): Move from
4413 * tui/tui-layout.c: Update.
4414 * tui/tui-disasm.c: Update.
4415 * tui/tui-data.h (struct tui_source_window): Move to
4418 2019-07-17 Tom Tromey <tom@tromey.com>
4420 * tui/tui-disasm.h (struct tui_disasm_window): Move from
4422 * tui/tui-data.h (struct tui_disasm_window): Move to
4425 2019-07-17 Tom Tromey <tom@tromey.com>
4427 * tui/tui-regs.h (struct tui_data_item_window): Move from
4429 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4430 * tui/tui-data.h (struct tui_data_item_window): Move to
4432 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4434 2019-07-17 Tom Tromey <tom@tromey.com>
4436 * tui/tui.c: Update.
4437 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4438 (tui_cmd_window::max_height): Move to tui-command.c.
4439 * tui/tui-layout.c: Update.
4440 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4441 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4443 * tui/tui-command.h (struct tui_cmd_window): Move from
4445 * tui/tui-command.c: Remove "structuring" comments.
4446 (tui_cmd_window::clear_detail)
4447 (tui_cmd_window::do_make_visible_with_new_height)
4448 (tui_cmd_window::max_height): Move from elsewhere.
4450 2019-07-17 Tom Tromey <tom@tromey.com>
4452 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4454 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4455 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4457 2019-07-17 Tom Tromey <tom@tromey.com>
4459 * tui/tui.c: Update.
4460 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4462 * tui/tui-windata.h: Remove file.
4463 * tui/tui-windata.c: Remove file.
4464 * tui/tui-win.c (tui_data_window::set_new_height)
4465 (tui_data_window::do_make_visible_with_new_height): Move to
4467 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4468 * tui/tui-regs.c: Remove "structuring" comments.
4469 (tui_data_window::first_data_item_displayed)
4470 (tui_data_window::delete_data_content_windows)
4471 (tui_data_window::erase_data_content)
4472 (tui_data_window::display_all_data)
4473 (tui_data_window::refresh_all)
4474 (tui_data_window::do_scroll_vertical)
4475 (tui_data_window::clear_detail, tui_data_window::set_new_height)
4476 (tui_data_window::do_make_visible_with_new_height)
4477 (tui_data_window::refresh_window): Move from elsewhere.
4478 (_initialize_tui_regs): Move to end of file.
4479 * tui/tui-layout.c: Update.
4480 * tui/tui-hooks.c: Update.
4481 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4482 * tui/tui-data.c (tui_data_window::clear_detail): Move to
4484 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4486 2019-07-17 Tom Tromey <tom@tromey.com>
4488 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4491 2019-07-17 Tom Tromey <tom@tromey.com>
4493 * tui/tui-win.c (tui_source_window_base::set_new_height)
4494 (tui_source_window_base::do_make_visible_with_new_height): Use
4495 m_has_locator field directly.
4496 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4498 (struct tui_source_window_base) <has_locator>: Likewise.
4500 2019-07-17 Tom Tromey <tom@tromey.com>
4502 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4504 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4506 * tui/tui-win.c (tui_source_window_base::set_new_height)
4507 (tui_source_window_base::set_new_height)
4508 (make_invisible_and_set_new_height)
4509 (tui_source_window_base::do_make_visible_with_new_height)
4510 (tui_source_window_base::do_make_visible_with_new_height):
4512 * tui/tui-layout.c (show_source_disasm_command, show_data)
4513 (show_source_or_disasm_and_command): Update.
4514 * tui/tui-layout.c (show_layout): Update.
4516 2019-07-17 Tom Tromey <tom@tromey.com>
4518 * tui/tui-layout.c (make_data_window): Remove.
4519 (show_data): Unify creation and re-initialization cases.
4521 2019-07-17 Tom Tromey <tom@tromey.com>
4523 * tui/tui-layout.c (make_source_window, make_disasm_window):
4525 (show_data): Unify creation and re-initialization cases.
4527 2019-07-17 Tom Tromey <tom@tromey.com>
4529 * tui/tui-layout.c (make_command_window): Remove.
4530 (show_source_disasm_command, show_source_or_disasm_and_command):
4531 Unify creation and re-initialization cases.
4533 2019-07-17 Tom Tromey <tom@tromey.com>
4535 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4536 creation and re-initialization cases.
4538 2019-07-17 Tom Tromey <tom@tromey.com>
4540 * tui/tui-regs.c (tui_get_register): Return void.
4542 2019-07-17 Tom Tromey <tom@tromey.com>
4544 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4547 2019-07-17 Tom Tromey <tom@tromey.com>
4549 * tui/tui-layout.c (show_source_disasm_command): Simplify window
4552 2019-07-17 Tom Tromey <tom@tromey.com>
4554 * tui/tui.h (tui_set_layout_by_name): Don't declare.
4555 * tui/tui-regs.c (tui_reg_layout): New function.
4556 (tui_show_registers, tui_reg_command): Use it.
4557 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4558 (tui_layout_command): Rename from tui_set_layout_by_name. Change
4560 (tui_layout_command): Remove.
4562 2019-07-17 Tom Tromey <tom@tromey.com>
4564 * tui/tui-layout.h (tui/tui-layout): Return void.
4565 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
4567 2019-07-17 Tom Tromey <tom@tromey.com>
4569 * tui/tui-layout.c (show_source_disasm_command, show_data):
4571 (reset_locator): Remove.
4572 (show_source_or_disasm_and_command): Update.
4574 2019-07-17 Tom Tromey <tom@tromey.com>
4576 * tui/tui-source.c (tui_source_window_base::reset): Remove
4578 * tui/tui-layout.c (make_command_window, make_source_window)
4579 (make_disasm_window, make_data_window)
4580 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4581 (reset_locator, show_source_or_disasm_and_command): Update.
4582 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4584 (struct tui_source_window_base) <reset>: Likewise.
4586 2019-07-17 Tom Tromey <tom@tromey.com>
4588 * tui/tui-layout.c (show_source_disasm_command): Use
4590 (reset_locator): New function.
4591 (init_and_make_win): Remove.
4592 (show_source_or_disasm_and_command): Use reset_locator.
4594 2019-07-17 Tom Tromey <tom@tromey.com>
4596 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4598 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4600 * tui/tui-source.c (tui_source_window_base::reset): New method.
4601 * tui/tui-layout.c (make_command_window): Don't call
4603 (make_source_window, make_disasm_window): Don't call
4604 make_source_or_disasm_window.
4605 (make_data_window): Don't call init_and_make_win. Change calling
4607 (show_source_disasm_command, show_data): Simplify.
4608 (make_source_or_disasm_window): Remove.
4609 (show_source_or_disasm_and_command): Simplify.
4610 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4611 (struct tui_source_window_base) <reset>: Likewise.
4612 <execution_info>: Remove initializer.
4613 * tui/tui-data.c (tui_source_window_base): Initialize
4616 2019-07-17 Tom Tromey <tom@tromey.com>
4618 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4621 2019-07-17 Tom Tromey <tom@tromey.com>
4623 * tui/tui.c (tui_rl_other_window): Update.
4624 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4625 superclass method first. Always iterate over regs_content.
4626 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4628 * tui/tui-win.c (tui_set_focus_command): Update.
4630 2019-07-17 Tom Tromey <tom@tromey.com>
4632 * tui/tui-win.c (tui_set_focus_command): Rename from
4633 tui_set_focus. Call tui_enable.
4634 (tui_set_focus_command): Remove.
4636 2019-07-17 Tom Tromey <tom@tromey.com>
4638 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4640 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4642 (tui_data_window::refresh_window): Call refresh_window on data
4643 items. Always call superclass refresh_window.
4644 (tui_win_info::refresh): Remove.
4645 (tui_source_window_base::refresh_window): Update.
4646 (tui_refresh_all): Update.
4647 * tui/tui-layout.c (show_source_disasm_command): Remove call to
4649 (show_source_or_disasm_and_command): Likewise.
4650 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4651 (struct tui_source_window_base) <refresh>: Likewise.
4653 2019-07-17 Tom Tromey <tom@tromey.com>
4655 * tui/tui-winsource.c (tui_clear_source_content)
4656 (tui_show_source_content): Update.
4657 * tui/tui-source.c (tui_source_window::showing_source_p): Check
4658 whether content is empty.
4659 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4662 2019-07-17 Tom Tromey <tom@tromey.com>
4664 * tui/tui-winsource.c (tui_erase_source_content): Clear the
4666 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4667 * tui/tui-source.c (tui_set_source_content_nil): Remove.
4669 2019-07-17 Tom Tromey <tom@tromey.com>
4671 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4672 (struct tui_data_item_window): Update.
4674 2019-07-17 Tom Tromey <tom@tromey.com>
4676 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4677 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4680 2019-07-17 Tom Tromey <tom@tromey.com>
4682 * tui/tui-winsource.h (tui_erase_source_content)
4683 (tui_clear_source_content): Remove "display_prompt" parameter.
4684 * tui/tui-winsource.c (tui_update_source_window_as_is)
4685 (tui_update_source_windows_with_addr): Update.
4686 (tui_clear_source_content): Remove "display_prompt" parameter.
4687 (tui_erase_source_content): Likewise. Simplify.
4688 (tui_show_source_content): Update.
4689 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4690 * tui/tui-stack.c (tui_show_frame_info): Update.
4691 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4694 2019-07-17 Tom Tromey <tom@tromey.com>
4696 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4697 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4699 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4702 2019-07-17 Tom Tromey <tom@tromey.com>
4704 * tui/tui-winsource.c (tui_clear_source_content)
4705 (tui_show_source_content, tui_show_exec_info_content)
4706 (tui_clear_exec_info_content): Update.
4707 * tui/tui-stack.c (tui_show_locator_content): Update.
4708 (tui_show_frame_info): Update.
4709 * tui/tui-source.h (tui_source_window): Don't declare.
4710 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4711 from tui_source_is_displayed.
4712 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4714 (struct tui_source_window_base) <content_in_use>: New field. Now
4716 (struct tui_source_window) <showing_source_p>: New method.
4717 (TUI_SRC_WIN): Change cast.
4718 * tui/tui-data.c (tui_initialize_static_data): Update.
4720 2019-07-17 Tom Tromey <tom@tromey.com>
4722 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4724 * tui/tui-source.c (tui_source_window::location_matches_p): New
4726 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4728 * tui/tui-data.h (struct tui_source_window_base)
4729 <location_matches_p>: New method.
4730 (struct tui_source_window, struct tui_disasm_window)
4731 <location_matches_p>: Likewise.
4733 2019-07-17 Tom Tromey <tom@tromey.com>
4735 * tui/tui-win.c (tui_set_win_height_command): Rename from
4737 (tui_set_win_height_command): Remove.
4739 2019-07-17 Tom Tromey <tom@tromey.com>
4741 * tui/tui-source.c (tui_source_window): New constructor. Add
4743 (~tui_source_window): New destructor.
4744 (tui_source_window::style_changed): New method.
4745 * tui/tui-hooks.c (tui_redisplay_source): Remove.
4746 (tui_attach_detach_observers): Update.
4747 * tui/tui-data.h (struct tui_source_window): Make constructor not
4748 inline. Add destructor.
4749 (struct tui_source_window) <style_changed>: New method.
4750 <m_observable>: New member.
4752 2019-07-17 Tom Tromey <tom@tromey.com>
4754 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4755 * tui/tui-win.c (tui_resize_all): Fix typo.
4757 2019-07-17 Tom Tromey <tom@tromey.com>
4759 * tui/tui-wingeneral.h (tui_refresh_all): Update.
4760 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4761 (tui_refresh_all): Remove "list" parameter. Use foreach.
4762 * tui/tui-win.c (window_name_completer): Use foreach.
4763 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4764 (update_tab_width): Likewise.
4765 * tui/tui-layout.c (show_layout): Update.
4766 * tui/tui-data.h (class tui_window_iterator): New.
4767 (struct all_tui_windows): New.
4768 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4770 2019-07-17 Tom Tromey <tom@tromey.com>
4772 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4773 parameter. Don't reference globals.
4774 (tui_reg_command): Update.
4776 2019-07-17 Tom Tromey <tom@tromey.com>
4778 * tui/tui-regs.c (tui_show_registers): Simplify.
4780 2019-07-17 Tom Tromey <tom@tromey.com>
4782 * tui/tui-regs.c (tui_show_registers): Update.
4783 (tui_show_register_group): Add win_info parameter.
4785 2019-07-17 Tom Tromey <tom@tromey.com>
4787 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4788 Rename from tui_display_reg_element_at_line.
4789 (tui_data_window::display_registers_from_line): Update.
4790 * tui/tui-data.h (struct tui_data_window)
4791 <display_reg_element_at_line>: New method.
4793 2019-07-17 Tom Tromey <tom@tromey.com>
4795 * tui/tui-regs.h (tui_display_registers_from)
4796 (tui_display_registers_from_line): Don't declare.
4797 * tui/tui-windata.c (tui_data_window::display_all_data)
4798 (tui_data_window::refresh_all)
4799 (tui_data_window::do_scroll_vertical): Update.
4800 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4801 from tui_display_registers_from.
4802 (tui_display_reg_element_at_line): Update.
4803 (tui_data_window::display_registers_from_line): Rename from
4804 tui_display_registers_from_line.
4805 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4806 display_registers_from_line>: New methods.
4808 2019-07-17 Tom Tromey <tom@tromey.com>
4810 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4811 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4812 from tui_erase_data_content.
4813 (tui_data_window::display_all_data)
4814 (tui_data_window::refresh_all)
4815 (tui_data_window::do_scroll_vertical): Update.
4816 * tui/tui-regs.c (tui_show_registers): Update.
4817 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4820 2019-07-17 Tom Tromey <tom@tromey.com>
4822 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4825 (tui_data_window::delete_data_content_windows): Rename from
4826 tui_delete_data_content_windows.
4827 (tui_data_window::display_all_data)
4828 (tui_data_window::do_scroll_vertical): Update.
4829 * tui/tui-data.h (struct tui_data_window)
4830 <delete_data_content_windows>: New method.
4832 2019-07-17 Tom Tromey <tom@tromey.com>
4834 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4835 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4837 2019-07-17 Tom Tromey <tom@tromey.com>
4839 * tui/tui-windata.h (tui_display_all_data): Don't declare.
4840 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4841 from tui_display_all_data.
4843 (tui_data_window::do_make_visible_with_new_height): Update.
4844 * tui/tui-regs.c (tui_show_registers): Update.
4845 * tui/tui-layout.c (tui_set_layout): Update.
4846 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4849 2019-07-17 Tom Tromey <tom@tromey.com>
4851 * tui/tui-windata.h (tui_display_data_from): Don't declare.
4852 * tui/tui-windata.c (tui_display_data_from): Remove.
4853 (tui_data_window::refresh_all): Update.
4855 2019-07-17 Tom Tromey <tom@tromey.com>
4857 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4858 * tui/tui-windata.c (tui_display_data_from_line): Remove.
4859 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4860 tui_display_registers_from_line.
4861 * tui/tui-regs.h (tui_display_registers_from_line): Update.
4862 * tui/tui-regs.c (tui_display_registers_from_line): Remove
4863 "force_display" parameter.
4865 2019-07-17 Tom Tromey <tom@tromey.com>
4867 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4869 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4870 Rename from tui_first_reg_element_no_inline.
4871 (tui_display_reg_element_at_line)
4872 (tui_display_registers_from_line): Update.
4873 * tui/tui-data.h (struct tui_data_window)
4874 <first_reg_element_no_inline>: New method.
4876 2019-07-17 Tom Tromey <tom@tromey.com>
4878 * tui/tui-windata.c (tui_display_data_from)
4879 (tui_data_window::do_scroll_vertical): Update.
4880 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4881 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4882 Rename from tui_line_from_reg_element_no.
4883 (tui_display_registers_from_line): Update.
4884 * tui/tui-data.h (struct tui_data_window)
4885 <line_from_reg_element_no>: New method.
4887 2019-07-17 Tom Tromey <tom@tromey.com>
4889 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4890 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4891 tui_last_regs_line_no.
4892 (tui_display_reg_element_at_line)
4893 (tui_display_registers_from_line): Update.
4894 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4897 2019-07-17 Tom Tromey <tom@tromey.com>
4900 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4901 (tui_update_breakpoint_info): Add "being_deleted" parameter.
4902 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4903 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4904 (tui_update_breakpoint_info): Likewise.
4905 * tui/tui-hooks.c (tui_event_create_breakpoint)
4906 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4909 2019-07-17 Tom Tromey <tom@tromey.com>
4911 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4913 2019-07-17 Tom Tromey <tom@tromey.com>
4915 * tui/tui-winsource.c (tui_update_source_window_as_is)
4916 (tui_update_source_windows_with_addr): Update.
4917 * tui/tui-source.h (tui_set_source_content)
4918 (tui_show_symtab_source): Add "win_info" parameter.
4919 * tui/tui-source.c (tui_set_source_content): Add "win_info"
4921 (tui_show_symtab_source): Likewise.
4923 2019-07-17 Tom Tromey <tom@tromey.com>
4925 * tui/tui-wingeneral.c
4926 (tui_check_and_display_highlight_if_needed): Check can_highlight.
4928 2019-07-17 Tom Tromey <tom@tromey.com>
4930 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4931 (struct tui_cmd_window) <can_scroll>: New method.
4932 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4935 2019-07-17 Tom Tromey <tromey@adacore.com>
4937 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4938 do_field_signed>: Rename. Change type of "value".
4939 * ui-out.c (ui_out::field_signed): Rename from field_int.
4940 Change type of "value".
4941 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
4943 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4944 do_field_int. Change type of "value".
4945 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4946 do_field_int. Change type of "value".
4947 * tracepoint.c (trace_status_mi, tfind_1)
4948 (print_one_static_tracepoint_marker): Update.
4949 * thread.c (print_thread_info_1, print_selected_thread_frame):
4951 * stack.c (print_frame, print_frame_info): Update.
4952 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4954 * source.c (print_source_lines_base): Update.
4955 * skip.c (info_skip_command): Update.
4956 * record-btrace.c (btrace_ui_out_decode_error)
4957 (btrace_call_history_src_line): Update.
4958 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4960 * progspace.c (print_program_space): Update.
4961 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4962 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4963 do_field_int. Change type of "value".
4964 * mi/mi-out.c (mi_ui_out::do_table_begin)
4965 (mi_ui_out::do_table_header): Update.
4966 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
4968 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4969 (mi_cmd_data_list_changed_registers, output_register)
4970 (mi_cmd_data_read_memory, mi_load_progress)
4971 (mi_cmd_trace_frame_collected): Update.
4972 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4974 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4975 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4976 (mi_cmd_var_list_children, varobj_update_one): Update.
4977 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4978 (mi_cmd_stack_list_args, list_arg_or_local): Update.
4979 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4980 * inferior.c (print_inferior): Update.
4981 * gdb_bfd.c (print_one_bfd): Update.
4982 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4984 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4985 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4986 do_field_int. Change type of "value".
4987 * cli-out.c (cli_ui_out::do_field_signed): Rename from
4988 do_field_int. Change type of "value".
4989 * breakpoint.c (watchpoint_check, print_breakpoint_location)
4990 (print_one_breakpoint_location, print_it_catch_fork)
4991 (print_one_catch_fork, print_it_catch_vfork)
4992 (print_one_catch_vfork, print_it_catch_solib)
4993 (print_it_catch_exec, print_it_ranged_breakpoint)
4994 (print_mention_watchpoint, print_mention_masked_watchpoint)
4995 (bkpt_print_it, update_static_tracepoint): Update.
4996 * break-catch-throw.c (print_it_exception_catchpoint): Update.
4997 * break-catch-syscall.c (print_it_catch_syscall): Update.
4998 * ada-tasks.c (print_ada_task_info): Update.
4999 * ada-lang.c (print_it_exception, print_mention_exception):
5002 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
5004 PR breakpoints/24541
5005 * gdbarch.c: Regenerate.
5006 * gdbarch.h: Regenerate.
5007 * gdbarch.sh: Adjust return type and parameter types for
5008 'stap_adjust_register'.
5009 (i386_stap_adjust_register): Adjust signature and return new
5011 * stap-probe.c (stap_parse_register_operand): Adjust use of
5012 'gdbarch_stap_adjust_register'.
5014 2019-07-17 Tom Tromey <tromey@adacore.com>
5016 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
5018 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5020 (struct s390_process_info): Add initializers.
5021 (s390_add_process): Use new.
5022 (s390_linux_nat_target::low_forget_process): Use delete.
5023 (s390_linux_nat_target::low_new_fork)
5024 (s390_linux_nat_target::stopped_by_watchpoint)
5025 (s390_linux_nat_target::low_prepare_to_resume)
5026 (s390_linux_nat_target::insert_watchpoint)
5027 (s390_linux_nat_target::insert_hw_breakpoint)
5028 (s390_linux_nat_target::remove_watchpoint)
5029 (s390_linux_nat_target::remove_hw_breakpoint): Update.
5031 2019-07-16 John Baldwin <jhb@FreeBSD.org>
5033 * aarch64-fbsd-nat.c: Include regcache.h.
5034 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5036 (aarch64_fbsd_nat_target::fetch_registers)
5037 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5039 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5041 2019-07-16 John Baldwin <jhb@FreeBSD.org>
5043 * fbsd-nat.c: Include gdbarch.h.
5045 2019-07-15 Tom Tromey <tromey@adacore.com>
5047 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5049 2019-07-15 Tom Tromey <tromey@adacore.com>
5051 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5052 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5053 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5054 * cli-out.c (cli_ui_out::do_field_int): New method.
5055 * ui-out.c (ui_out::field_unsigned): New method.
5056 * symfile.c (generic_load): Use field_unsigned.
5057 (print_transfer_performance): Likewise.
5058 * record-btrace.c (ui_out_field_uint): Remove.
5059 (btrace_call_history_insn_range, btrace_call_history): Use
5061 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5063 * ui-out.h (class ui_out) <field_unsigned>: New method.
5064 <do_field_unsigned>: Likewise.
5066 2019-07-15 Tom Tromey <tromey@adacore.com>
5068 * mi/mi-main.c (list_available_thread_groups): Use field_string.
5069 * mi/mi-interp.c (mi_memory_changed): Use field_string.
5070 * target.c (flash_erase_command): Use field_string.
5071 * infrun.c (print_signal_received_reason): Use field_string.
5072 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5073 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5075 * ada-tasks.c (print_ada_task_info): Use field_string.
5077 2019-07-15 Tom Tromey <tromey@adacore.com>
5079 * target.c (flash_erase_command): Use field_core_addr.
5080 * symfile.c (generic_load): Use field_core_addr.
5081 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5082 Use field_core_addr.
5083 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5086 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5088 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5089 value if its desired type is smaller than a CORE_ADDR and signed.
5091 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5093 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5094 of changes to field names, and use new is_reference field to
5095 decide if a property is a reference or not.
5096 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5098 (struct dwarf2_property_baton): Update header comment, rename
5099 'referenced_type' to 'property_type' and update comments.
5100 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5101 default property type, store in property baton, update to take
5102 accound of renamed field.
5103 (read_func_scope): Update call to attr_to_dynamic_prop.
5104 (read_array_type): Likewise.
5105 (dwarf2_per_cu_addr_sized_int_type): New function.
5106 (read_subrange_index_type): Move type finding code to
5107 dwarf2_per_cu_addr_sized_int_type.
5108 (read_subrange_type): Update calls to attr_to_dynamic_prop.
5109 (dwarf2_per_cu_addr_type): New function.
5110 (set_die_type): Update calls to attr_to_dynamic_prop.
5112 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5114 * dwarf2read.c (read_subrange_index_type): New function.
5115 (read_subrange_type): Move code into new function and call it.
5116 * gdbtypes.c (create_range_type): Add some asserts.
5118 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5120 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5121 update return statements.
5122 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5123 declaration, and update comment to match.
5124 * gdbtypes.c (resolve_dynamic_array): Update call to
5125 dwarf2_evaluate_property to match new return type.
5127 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5129 * valarith.c (value_subscripted_rvalue): Change lowerbound
5130 parameter type from int to LONGEST.
5131 * value.h (value_subscripted_rvalue): Likewise in declaration.
5133 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
5135 * cli/cli-utils.c (info_print_command_completer): New function.
5136 * cli/cli-utils.h: Add 'completer.h' include, and forward
5137 declaration for 'struct cmd_list_element'.
5138 (info_print_command_completer): Declare.
5139 * stack.c (_initialize_stack): Add completer for 'info locals' and
5141 * symtab.c (_initialize_symtab): Add completer for 'info
5142 variables' and 'info functions'.
5143 * NEWS: Mention completion for additional info commands.
5145 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
5147 * cli/cli-utils.c (extract_info_print_args): Delete.
5148 (extract_arg_maybe_quoted): Delete.
5149 (info_print_options_defs): New variable.
5150 (make_info_print_options_def_group): New function.
5151 (extract_info_print_options): Define new function.
5152 * cli/cli-utils.h (extract_info_print_args): Delete.
5153 (struct info_print_options): New structure.
5154 (extract_info_print_options): Declare new function.
5155 * stack.c (info_locals_command): Update to use new
5156 extract_info_print_options, also add a header comment.
5157 (info_args_command): Likewise.
5158 * symtab.c (info_variables_command): Likewise.
5159 (info_functions_command): Likewise.
5161 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
5163 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5164 to extract string arguments.
5165 * common/common-utils.c (extract_string_maybe_quoted): New function.
5166 * common/common-utils.h (extract_string_maybe_quoted): Declare.
5168 2019-07-11 Tom Tromey <tromey@adacore.com>
5170 * main.c (get_init_files): Use GDBINIT, not gdbinit.
5171 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5172 * top.h (gdbinit): Don't declare.
5173 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5175 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
5176 * top.c (gdb_init): Don't call init_cli_cmds.
5178 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5180 2019-07-11 Tom Tromey <tromey@adacore.com>
5182 * python/py-inferior.c (add_thread_object): Don't use thread_obj
5183 after it has been moved.
5185 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
5187 * valops.c (value_must_coerce_to_target): Change return type to
5189 * value.h (value_must_coerce_to_target): Likewise.
5191 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
5193 * breakpoint.c (is_hardware_watchpoint): Remove
5194 forward-declaration.
5195 (is_masked_watchpoint): Change return type to bool.
5196 (is_tracepoint): Likewise.
5197 (is_breakpoint): Likewise.
5198 (is_hardware_watchpoint): Likewise.
5199 (is_watchpoint): Likewise.
5200 (is_no_memory_software_watchpoint): Likewise.
5201 (is_catchpoint): Likewise.
5202 (breakpoint_1): Make FILTER parameter's return type bool.
5203 is_masked_watchpoint): Change return type to bool.
5204 (save_breakpoints): Make FILTER parameter's return type bool.
5205 * breakpoint.h (is_breakpoint): Change return type to bool.
5206 (is_watchpoint): Likewise.
5207 (is_catchpoint): Likewise.
5208 (is_tracepoint): Likewise.
5210 2019-07-10 Tom Tromey <tom@tromey.com>
5212 * defs.h: Don't include gdbarch.h.
5213 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5214 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5215 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5216 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5217 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5218 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5219 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5220 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5221 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5222 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5223 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5224 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5225 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5226 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5227 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5228 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5229 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5230 record-btrace.c, record.h, regcache-dump.c, regcache.h,
5231 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5232 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5233 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5234 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5235 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5236 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5237 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5238 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5239 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5241 2019-07-10 Tom Tromey <tromey@adacore.com>
5243 * ada-lang.h (is_ada_exception_catchpoint): Declare.
5244 * breakpoint.c (init_ada_exception_breakpoint): Register as
5246 (print_one_breakpoint_location, print_one_breakpoint): Use
5247 is_ada_exception_catchpoint.
5248 * ada-lang.c (class ada_catchpoint_location): Pass
5249 bp_loc_software_breakpoint to bp_location constructor.
5250 (is_ada_exception_catchpoint): New function.
5252 2019-07-10 Tom Tromey <tromey@adacore.com>
5254 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
5256 (struct arm_exidx_entry): New method operator<.
5257 (struct arm_exidx_data) <section_maps>: Change type.
5258 (arm_exidx_data_free): Remove.
5259 (arm_exidx_data_key): Change type. Move lower.
5260 (arm_exidx_new_objfile): Update.
5261 (arm_compare_exidx_entries): Remove.
5262 (arm_find_exidx_entry, _initialize_arm_tdep)
5264 2019-07-10 Tom Tromey <tromey@adacore.com>
5266 * solib-spu.c (ocl_program_data_key): Change type.
5267 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5270 2019-07-10 Tom Tromey <tromey@adacore.com>
5272 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
5273 (struct solib_aix_inferior_data) <library_list>: Change type.
5274 (solib_aix_inferior_data_handle): Change type.
5275 (get_solib_aix_inferior_data): Update.
5276 (solib_aix_free_library_list): Remove.
5277 (library_list_start_library): Update.
5278 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5280 (solib_aix_get_library_list)
5281 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5282 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5284 2019-07-10 Tom Tromey <tromey@adacore.com>
5286 * solib-dsbt.c (struct dsbt_info): Add initializers.
5287 (solib_dsbt_pspace_data): Change type.
5288 (dsbt_pspace_data_cleanup): Remove.
5289 (get_dsbt_info, _initialize_dsbt_solib): Update.
5291 2019-07-10 Tom Tromey <tromey@adacore.com>
5293 * spu-tdep.c (spu_overlay_data): Change type.
5294 (spu_get_overlay_table, spu_overlay_new_objfile)
5295 (_initialize_spu_tdep): Update.
5297 2019-07-10 Tom Tromey <tromey@adacore.com>
5299 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5301 (dbx_objfile_data_key): Change type and declare later.
5302 (DBX_SYMFILE_INFO): Rewrite.
5303 * dbxread.c (dbx_objfile_data_key): Change type.
5304 (dbx_symfile_init): Update.
5305 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
5306 (coffstab_build_psymtabs, elfstab_build_psymtabs)
5307 (stabsect_build_psymtabs, _initialize_dbxread): Update.
5309 2019-07-10 Tom Tromey <tromey@adacore.com>
5311 * jit.c (jit_program_space_key): Change type. Move lower.
5312 (get_jit_program_space_data): Update.
5313 (jit_program_space_data_cleanup): Remove.
5314 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5316 (struct jit_program_space_data): Add initializers.
5318 2019-07-10 Tom Tromey <tromey@adacore.com>
5320 * solib-darwin.c (struct darwin_info): Add initializers.
5321 (solib_darwin_pspace_data): Change type.
5322 (darwin_pspace_data_cleanup): Remove.
5323 (get_darwin_info, _initialize_darwin_solib): Update.
5325 2019-07-10 Tom Tromey <tromey@adacore.com>
5327 * remote-sim.c (struct sim_inferior_data): Add initializers,
5328 constructor, and destructor.
5329 (sim_inferior_data_key): Change type. Move lower.
5330 (check_for_duplicate_sim_descriptor): Update.
5331 (get_sim_inferior_data): Use new. Update.
5332 (~sim_inferior_data_cleanup): Rename from
5333 sim_inferior_data_cleanup. Simplify.
5334 (gdbsim_close_inferior, simulator_command)
5335 (sim_command_completer, _initialize_remote_sim): Update.
5336 (next_pid, INITIAL_PID): Move earlier.
5338 2019-07-10 Tom Tromey <tromey@adacore.com>
5340 * python/python-internal.h (create_thread_object): Return
5342 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5343 * python/py-inferior.c (struct threadlist_entry): Add
5345 <thread_obj>: Now a gdbpy_ref.
5346 (thread_to_thread_object): Update.
5347 (add_thread_object): Use new.
5348 (delete_thread_object): Use delete.
5349 (infpy_threads): Update.
5350 (py_free_inferior): Update. Construct "inf_obj" after acquiring
5353 2019-07-10 Tom Tromey <tromey@adacore.com>
5355 * valops.c (value_cast): Specialize error message for Ada.
5357 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
5359 * breakpoint.c (breakpoint_1): Update doc and parameter names.
5361 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
5363 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5364 bpstat_should_step): Return bool, adjust comments.
5365 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5366 bpstat_should_step): Likewise.
5368 2019-07-10 Alan Hayward <alan.hayward@arm.com>
5370 * features/Makefile: Use feature target descriptions for Arm.
5371 * features/arm/arm-core.c: Generate new file.
5372 * features/arm/arm-fpa.c: Likewise.
5373 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5374 * features/arm/arm-m-profile.c: Likewise.
5375 * features/arm/arm-vfpv2.c: Likewise.
5376 * features/arm/arm-vfpv3.c: Likewise.
5377 * features/arm/xscale-iwmmxt.c: Likewise.
5378 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5380 2019-07-10 Alan Hayward <alan.hayward@arm.com>
5382 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5385 2019-07-10 Alan Hayward <alan.hayward@arm.com>
5387 * features/aarch64-pauth.c: Regenerate.
5389 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
5391 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5393 (bpstat_what): Use false instead of 0.
5395 2019-07-09 Pedro Alves <palves@redhat.com>
5397 * break-catch-throw.c (is_exception_catchpoint): New.
5398 * breakpoint.c (print_one_breakpoint_location): New parameter
5399 'raw_loc'. Handle it. Use
5400 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5401 looking at the breakpoint's type.
5402 (print_one_breakpoint): If handling "maint info breakpoints", also
5403 print locations of exception catchpoints.
5404 * breakpoint.h (is_exception_catchpoint): Declare.
5406 2019-07-09 Pedro Alves <palves@redhat.com>
5408 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5410 (allocate_location_exception_catchpoint): New.
5411 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5412 (initialize_throw_catchpoint_ops): Install
5413 allocate_location_exception_catchpoint as allocate_location
5415 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5416 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5418 (breakpoint_address_is_meaningful): Delete.
5419 (bl_address_is_meaningful): New.
5420 (breakpoint_locations_match): Adjust comment.
5421 (bp_location_from_bp_type): New, factored out of...
5422 (bp_location::bp_location(breakpoint *)): ... this.
5423 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5425 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
5426 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5427 breakpoint_address_is_meaningful.
5428 (bp_locations_compare): Adjust comment.
5429 (update_global_location_list): Use bl_address_is_meaningful
5430 instead of breakpoint_address_is_meaningful.
5431 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5433 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5434 * python/py-breakpoint.c (bppy_get_location): No longer check
5435 whether location is null.
5437 2019-07-09 Pedro Alves <palves@redhat.com>
5440 * breakpoint.c (print_one_breakpoint_location): Remove
5441 single-location assert.
5443 2019-07-09 Tom Tromey <tom@tromey.com>
5445 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5446 * configure: Rebuild.
5447 * configure.ac: Change common to gdbsupport.
5448 * gdbsupport: Rename from common.
5449 * acinclude.m4: Change common to gdbsupport.
5450 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5451 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5453 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5454 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5455 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5456 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5457 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5458 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5459 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5460 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5461 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5462 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5463 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5464 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5465 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5466 coff-pe-read.c, command.h, compile/compile-c-support.c,
5467 compile/compile-c.h, compile/compile-cplus-symbols.c,
5468 compile/compile-cplus-types.c, compile/compile-cplus.h,
5469 compile/compile-loc2c.c, compile/compile.c, completer.c,
5470 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5471 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5472 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5473 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5474 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5475 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5476 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5477 features/aarch64-core.c, features/aarch64-fpu.c,
5478 features/aarch64-pauth.c, features/aarch64-sve.c,
5479 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5480 features/i386/32bit-core.c, features/i386/32bit-linux.c,
5481 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5482 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5483 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5484 features/i386/64bit-core.c, features/i386/64bit-linux.c,
5485 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5486 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5487 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5488 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5489 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5490 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5491 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5492 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5493 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5494 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5495 go32-nat.c, guile/guile.c, guile/scm-ports.c,
5496 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5497 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5498 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5499 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5500 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5501 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5502 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5503 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5504 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5505 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5506 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5507 minsyms.c, mips-linux-tdep.c, namespace.h,
5508 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5509 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5510 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5511 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5512 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5513 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5514 nat/linux-waitpid.c, nat/mips-linux-watch.c,
5515 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5516 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5517 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5518 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5519 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5520 procfs.c, producer.c, progspace.h, psymtab.h,
5521 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5522 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5523 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5524 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5525 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5526 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5527 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5528 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5529 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5530 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5531 target-memory.c, target.c, target.h, target/waitstatus.c,
5532 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5533 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5534 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5535 unittests/array-view-selftests.c,
5536 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5537 unittests/common-utils-selftests.c,
5538 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5539 unittests/format_pieces-selftests.c,
5540 unittests/function-view-selftests.c,
5541 unittests/lookup_name_info-selftests.c,
5542 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5543 unittests/mkdir-recursive-selftests.c,
5544 unittests/observable-selftests.c,
5545 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5546 unittests/parse-connection-spec-selftests.c,
5547 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5548 unittests/scoped_fd-selftests.c,
5549 unittests/scoped_mmap-selftests.c,
5550 unittests/scoped_restore-selftests.c,
5551 unittests/string_view-selftests.c, unittests/style-selftests.c,
5552 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5553 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5554 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5555 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5556 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5557 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5559 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
5561 * linespec.c (decode_digits_list_mode): Set explicit_line to a
5563 (decode_digits_ordinary): Set explicit_line field in sal.
5564 * symtab.c (skip_prologue_sal): Don't skip prologue for a
5565 symtab_and_line that was set on an explicit line number in
5566 assembler code. Do always update the recorded symtab and line if
5567 we do skip the prologue.
5569 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
5571 * breakpoint.c (set_breakpoint_location_function): Remove
5572 explicit_loc parameter.
5573 (momentary_breakpoint_from_master): Update call to
5574 set_breakpoint_location_function.
5575 (add_location_to_breakpoint): Likewise.
5577 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
5579 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5580 required features based on default bfd type when no specific bfd
5583 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5585 * NEWS: Mention that GDB printf and eval commands can now print
5586 C-style and Ada-style convenience var strings without
5587 calling the inferior.
5588 * printcmd.c (printf_c_string): Locally print GDB internal var
5589 instead of transiting via the inferior.
5590 (printf_wide_c_string): Likewise.
5592 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5594 PR breakpoints/25011
5595 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5597 2019-07-04 Tom Tromey <tom@tromey.com>
5600 * tui/tui-winsource.c (tui_clear_source_content): Update.
5601 (tui_source_window_base::set_is_exec_point_at): Fix comment.
5602 (tui_update_breakpoint_info): Update.
5603 (tui_set_exec_info_content): Update.
5604 * tui/tui-source.c (tui_set_source_content_nil): Update.
5605 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5607 * tui/tui-data.h (enum tui_bp_flag): New.
5608 (tui_bp_flags): New enum flags type.
5609 (struct tui_source_element) <break_mode>: Change type. Rename
5611 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5612 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
5614 * tui/tui-winsource.h: Fix comment.
5616 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5618 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5619 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5620 (store_fpregs_to_thread)
5621 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5622 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5623 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5624 (IWMMXT_REGS_SIZE): Add define.
5625 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5626 (fetch_vfp_regs, store_vfp_regs)
5627 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5628 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5630 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5632 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5634 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5635 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5636 (ARM_INT_REGISTER_SIZE): ...to this.
5637 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5638 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5639 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5640 (arm_linux_collect_gregset, supply_nwfpe_register)
5641 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5643 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5644 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5645 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5646 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5647 (arm_return_in_memory, arm_store_return_value)
5648 (arm_get_longjmp_target, arm_register_g_packet_guesses)
5649 (arm_record_ld_st_multiple): Likewise.
5650 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5651 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5653 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5655 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5656 AARCH64_DISPLACED_MODIFIED_INSNS.
5657 * aarch64-tdep.c (struct aarch64_displaced_step_data)
5658 (aarch64_displaced_step_copy_insn): Likewise.
5659 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5660 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5661 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5662 ARM_DISPLACED_MODIFIED_INSNS.
5663 * arm-tdep.c (arm_gdbarch_init): Likewise.
5664 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5665 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5666 (struct arm_displaced_step_closure): Use
5667 ARM_DISPLACED_MODIFIED_INSNS.
5669 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5671 * features/Makefile: Remove unused xml files.
5672 * features/aarch64.xml: Remove.
5673 * features/i386/amd64-avx-avx512-linux.xml: Remove.
5674 * features/i386/amd64-avx-avx512.xml: Remove.
5675 * features/i386/amd64-avx-linux.xml: Remove.
5676 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5677 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5678 * features/i386/amd64-avx-mpx-linux.xml: Remove.
5679 * features/i386/amd64-avx-mpx.xml: Remove.
5680 * features/i386/amd64-avx.xml: Remove.
5681 * features/i386/amd64-linux.xml: Remove.
5682 * features/i386/amd64-mpx-linux.xml: Remove.
5683 * features/i386/amd64-mpx.xml: Remove.
5684 * features/i386/amd64.xml: Remove.
5685 * features/i386/i386-avx-avx512-linux.xml: Remove.
5686 * features/i386/i386-avx-avx512.xml: Remove.
5687 * features/i386/i386-avx-linux.xml: Remove.
5688 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5689 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5690 * features/i386/i386-avx-mpx-linux.xml: Remove.
5691 * features/i386/i386-avx-mpx.xml: Remove.
5692 * features/i386/i386-avx.xml: Remove.
5693 * features/i386/i386-linux.xml: Remove.
5694 * features/i386/i386-mmx-linux.xml: Remove.
5695 * features/i386/i386-mmx.xml: Remove.
5696 * features/i386/i386-mpx-linux.xml: Remove.
5697 * features/i386/i386-mpx.xml: Remove.
5698 * features/i386/i386.xml: Remove.
5699 * features/i386/x32-avx-avx512-linux.xml: Remove.
5700 * features/i386/x32-avx-linux.xml: Remove.
5701 * features/i386/x32-linux.xml: Remove.
5703 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5705 * regformats/aarch64.dat: Remove.
5706 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5707 * regformats/i386/amd64-avx-linux.dat: Remove.
5708 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5709 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5710 * regformats/i386/amd64-linux.dat: Remove.
5711 * regformats/i386/amd64-mpx-linux.dat: Remove.
5712 * regformats/i386/amd64.dat: Remove.
5713 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5714 * regformats/i386/i386-avx-linux.dat: Remove.
5715 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5716 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5717 * regformats/i386/i386-linux.dat: Remove.
5718 * regformats/i386/i386-mmx-linux.dat: Remove.
5719 * regformats/i386/i386-mpx-linux.dat: Remove.
5720 * regformats/i386/i386.dat: Remove.
5721 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5722 * regformats/i386/x32-avx-linux.dat: Remove.
5723 * regformats/i386/x32-linux.dat: Remove.
5725 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5727 * aarch64-tdep.c: Remove xml self tests.
5728 * amd64-linux-tdep.c: Likewise.
5729 * amd64-tdep.c: Likewise.
5730 * i386-linux-tdep.c: Likewise.
5731 * i386-tdep.c: Likewise.
5733 2019-07-03 Pedro Alves <palves@redhat.com>
5736 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5737 (pipe_cmd_option_defs): New.
5738 (make_pipe_cmd_options_def_group): New.
5739 (pipe_command): Use gdb::option::process_options.
5740 (pipe_command_completer): New function.
5741 (_initialize_cli_cmds): Install completer for "pipe" command.
5743 2019-07-03 Pedro Alves <palves@redhat.com>
5745 * cli/cli-option.c (union option_value) <string>: New field.
5746 (struct option_def_and_value): Add ctor, move ctor, dtor and
5747 use DISABLE_COPY_AND_ASSIGN.
5748 (option_def_and_value::clear_value): New.
5749 (parse_option, save_option_value_in_ctx, get_val_type_str)
5750 (add_setshow_cmds_for_options): Handle var_string.
5751 * cli-option.h (union option_def::var_address) <string>: New
5753 (struct string_option_def): New.
5754 * maint-test-options.c (struct test_options_opts): Add default
5755 ctor and use DISABLE_COPY_AND_ASSIGN.
5756 <string_opt>: New field.
5757 (test_options_opts::~test_options_opts): New.
5758 (test_options_opts::dump): Also dump "-string".
5759 (test_options_option_defs): Install "string.
5761 2019-07-03 Pedro Alves <palves@redhat.com>
5763 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5764 option_value with a null enumeration.
5765 (complete_options): Save the option values in the context.
5766 (save_option_value_in_ctx): New, factored out from ...
5767 (process_options): ... here.
5768 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5770 * maint-test-options.c (test_options_opts::dump): New, factored
5772 (maintenance_test_options_command_mode): ... here.
5773 (maintenance_test_options_command_completion_result): Delete.
5774 (maintenance_test_options_command_completion_text): Update
5776 (maintenance_show_test_options_completion_result): Change
5777 prototype. Just print
5778 maintenance_test_options_command_completion_text.
5779 (save_completion_result): New.
5780 (maintenance_test_options_completer_mode): Pass options context to
5781 complete_options, and then save a dump.
5782 (_initialize_maint_test_options): Use add_cmd to install "maint
5783 show test-options-completion-result".
5785 2019-07-03 Pedro Alves <palves@redhat.com>
5787 * NEWS (New commands): Mention "with" and "maint with".
5788 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5789 (with_command, with_command_completer): New.
5790 (pipe_command): Adjust to new repeat_previous
5792 (_initialize_cli_cmds): Install the "with" command and its "w"
5794 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5796 * cli/cli-setshow.c (parse_cli_var_uinteger)
5797 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5798 argument strings for all var_types.
5799 (get_setshow_command_value_string): New, factored out from ...
5800 (do_show_command): ... this.
5801 * cli/cli-setshow.h: Include <string>.
5802 (get_setshow_command_value_string): Declare.
5803 * command.h (repeat_previous): Now returns const char *. Adjust
5805 * maint.c: Include "cli/cli-cmds.h".
5806 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5807 (_initialize_maint_cmds): Register the "maintenance with" command.
5808 * top.c (repeat_previous): Move bits from pipe_command here:
5809 Return the saved command line, if any; error out if there's no
5810 command to relaunch.
5812 2019-07-03 Pedro Alves <palves@redhat.com>
5814 * NEWS (New commands): Mention "maint set/show test-settings"
5815 instead of "maint test-settings".
5816 * maint-test-settings.c (maintenance_test_settings_list): Delete.
5817 (maintenance_test_settings_set_list): Rename to ...
5818 (maintenance_set_test_settings_list): ... this.
5819 (maintenance_test_settings_show_list): Rename to ...
5820 (maintenance_show_test_settings_list): ... this.
5821 (maintenance_test_settings_cmd): Delete.
5822 (maintenance_test_settings_set_cmd): ...
5823 (maintenance_set_test_settings_cmd): ... this.
5824 (maintenance_test_settings_show_cmd): ...
5825 (maintenance_show_test_settings_cmd): ... this.
5826 (maintenance_test_settings_show_value_cmd):
5827 (maintenance_show_test_settings_value_cmd): ... this.
5828 (_initialize_maint_test_settings): No longer install the "maint
5829 test-settings" prefix command. Rename "maint test-settings set"
5830 to "maint set test-settings", and "maint test-settings show" to
5831 "maint show test-settings". Adjust all subcommands.
5833 2019-07-03 Pedro Alves <palves@redhat.com>
5835 * maint-test-settings.c: Fix file's intro comment. Replace all
5836 references to "test-options" with references to "test-settings",
5839 2019-07-03 Pedro Alves <palves@redhat.com>
5841 * maint-test-settings.c (maintenance_test_settings_xxx)
5842 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5844 (maintenance_test_settings_enums): Use them.
5845 (maintenance_test_settings_enum): Default to
5846 maintenance_test_settings_xxx.
5847 (_initialize_maint_test_settings): Initialize
5848 MAINTENANCE_TEST_SETTINGS_FILENAME.
5850 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
5852 * breakpoint.h (remove_breakpoints_inf): Change return type to
5853 void, move function documentation here.
5854 * breakpoint.c (remove_breakpoints_inf): Change return type to
5855 void, move function documentation to header.
5857 2019-07-02 Pedro Alves <palves@redhat.com>
5859 * NEWS (Completion improvements): Mention "info threads".
5860 * thread.c (struct info_threads_opts, info_threads_option_defs)
5861 (make_info_threads_options_def_group): New.
5862 (info_threads_command): Use gdb::option::process_options.
5863 (info_threads_command_completer): New.
5864 (_initialize_thread): Use gdb::option::build_help to build the
5865 help text for "info threads".
5867 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
5869 * defs.h (generic_load): Move from here...
5870 * symfile.h (generic_load): ... to here. Rename name parameter
5872 * symfile.c (generic_load): Add comment.
5874 2019-07-01 Tom Tromey <tromey@adacore.com>
5877 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5878 declaration of without_params. Fix formatting.
5880 2019-07-01 Tom Tromey <tromey@adacore.com>
5882 * ada-exp.y (find_primitive_type): Update.
5883 * ada-lang.h (ada_lookup_symbol): Update.
5884 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5886 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5888 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
5890 PR breakpoints/24541
5891 * gdbarch.c: Regenerate.
5892 * gdbarch.h: Regenerate.
5893 * gdbarch.sh: Add 'stap_adjust_register'.
5894 * i386-tdep.c: Include '<unordered_set>'.
5895 (i386_stap_adjust_register): New function.
5896 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5897 * stap-probe.c (stap_parse_register_operand): Call
5898 'gdbarch_stap_adjust_register'.
5900 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
5903 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5904 * python/python.c (do_start_initialization): Use 'xmalloc'
5905 instead of 'PyMem_Malloc'.
5907 2019-06-28 Tom Tromey <tromey@adacore.com>
5909 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5912 2019-06-27 Tom Tromey <tromey@adacore.com>
5914 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
5916 (arm_find_mapping_symbol, arm_record_special_symbol)
5917 (_initialize_arm_tdep): Update.
5918 (arm_objfile_data_free): Remove.
5920 2019-06-27 Tom Tromey <tromey@adacore.com>
5922 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5923 to cp_print_static_field.
5925 2019-06-26 Tom Tromey <tromey@adacore.com>
5927 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5928 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5931 2019-06-26 Alan Hayward <alan.hayward@arm.com>
5933 * features/aarch64-core.c (create_feature_aarch64_core):
5935 * features/aarch64-core.xml: Add cpsr flags.
5937 2019-06-26 Alan Hayward <alan.hayward@arm.com>
5939 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5940 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5942 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
5944 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5946 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5948 (arm_record_special_symbol): Don't insert new symbol in sorted
5949 position, push it at the end.
5951 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
5953 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5954 (arm_mapping_symbol_s): Remove.
5955 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5956 (arm_mapping_symbol_vec): New typedef.
5957 (struct arm_per_objfile): Add constructor.
5958 <section_maps>: Change type to
5959 std::unique_ptr<arm_mapping_symbol_vec[]>.
5960 (arm_compare_mapping_symbols): Remove.
5961 (arm_find_mapping_symbol): Adjust to section_maps type change.
5962 (arm_objfile_data_free): Call delete on arm_per_objfile.
5963 (arm_record_special_symbol): Adjust to section_maps type change.
5964 Allocate arm_per_objfile with new.
5966 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5968 * cli/cli-cmds.c (alias_command): Compare the alias prefix
5969 with the command prefix.
5971 2019-06-25 Tom Tromey <tom@tromey.com>
5973 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5974 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5976 2019-06-25 Tom Tromey <tom@tromey.com>
5978 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5980 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5983 2019-06-25 Tom Tromey <tom@tromey.com>
5985 * tui/tui-winsource.c
5986 (tui_source_window_base::set_is_exec_point_at): Add check against
5989 2019-06-25 Tom Tromey <tom@tromey.com>
5991 * tui/tui-source.c (tui_set_source_content): Don't check before
5993 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5995 2019-06-25 Tom Tromey <tom@tromey.com>
5997 * tui/tui-winsource.h (tui_update_source_window_as_is)
5998 (tui_alloc_source_buffer, tui_line_is_displayed)
5999 (tui_addr_is_displayed): Change type of win_info.
6000 * tui/tui-winsource.c (tui_update_source_window_as_is)
6001 (tui_clear_source_content, tui_show_source_line)
6002 (tui_show_source_content, tui_source_window_base::refill)
6003 (tui_source_window_base::set_is_exec_point_at)
6004 (tui_source_window_base::set_is_exec_point_at)
6005 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6006 (tui_alloc_source_buffer, tui_line_is_displayed)
6007 (tui_addr_is_displayed): Change type of win_info. Update.
6008 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6009 (tui_source_window_base::do_make_visible_with_new_height):
6011 * tui/tui-source.c (tui_set_source_content)
6012 (tui_set_source_content_nil)
6013 (tui_source_window::do_scroll_vertical): Update.
6014 * tui/tui-layout.c (show_layout): Update.
6015 * tui/tui-disasm.c (tui_set_disassem_content)
6016 (tui_disasm_window::do_scroll_vertical): Update.
6017 * tui/tui-data.h (tui_win_content): Remove.
6018 (struct tui_gen_win_info) <content, content_size>: Remove.
6019 (struct tui_source_element): Add initializers and destructor.
6020 (union tui_which_element, struct tui_win_element): Remove.
6021 (struct tui_source_window_base) <content>: New field.
6022 (struct tui_data_window): Remove destructor.
6023 (tui_alloc_content, tui_free_win_content)
6024 (tui_free_all_source_wins_content): Don't declare.
6025 * tui/tui-data.c (tui_initialize_static_data): Update.
6026 (init_content_element, tui_alloc_content): Remove.
6027 (~tui_gen_win_info): Update.
6028 (~tui_data_window, tui_free_all_source_wins_content)
6029 (tui_free_win_content, free_content, free_content_elements):
6032 2019-06-25 Tom Tromey <tom@tromey.com>
6034 * tui/tui-winsource.h (tui_clear_source_content)
6035 (tui_erase_source_content, tui_show_source_content): Change type
6037 * tui/tui-winsource.c (tui_clear_source_content)
6038 (tui_erase_source_content, tui_show_source_content): Change type
6040 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6041 * tui/tui-source.h (tui_set_source_content_nil): Change type of
6043 * tui/tui-source.c (tui_set_source_content_nil): Change type of
6045 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6047 2019-06-25 Tom Tromey <tom@tromey.com>
6049 * tui/tui-winsource.c (tui_clear_source_content)
6050 (tui_source_window_base::set_is_exec_point_at): Update.
6051 * tui/tui-source.c (tui_set_source_content_nil): Update.
6052 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6054 * tui/tui-data.c (init_content_element): Update.
6056 2019-06-25 Tom Tromey <tom@tromey.com>
6058 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6059 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6060 * tui/tui-layout.c (init_and_make_win): Update.
6061 * tui/tui.h (enum tui_win_type): Update.
6062 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6063 tui_win_is_auxillary.
6064 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6065 tui_win_is_auxillary.
6067 2019-06-25 Tom Tromey <tom@tromey.com>
6069 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6070 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6071 (tui_delete_data_content_windows, tui_display_all_data)
6072 (tui_data_window::do_scroll_vertical, tui_display_data_from):
6074 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6075 * tui/tui-regs.c (tui_last_regs_line_no)
6076 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6077 (tui_show_registers): Update.
6078 (tui_show_register_group): Return void. Update.
6079 (tui_display_registers_from, tui_display_reg_element_at_line)
6080 (tui_display_registers_from_line, tui_check_register_values):
6082 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6084 (struct tui_data_window) <regs_content>: Now a std::vector.
6085 <regs_content_count>: Remove.
6086 (tui_add_content_elements, tui_free_data_content): Don't declare.
6087 * tui/tui-data.c (tui_data_window::clear_detail): Update.
6088 (init_content_element): Remove DATA_WIN case. Add assert.
6089 (tui_add_content_elements): Remove.
6090 (tui_data_window): Update.
6091 (tui_free_data_content): Remove.
6092 (free_content_elements): Remove DATA_WIN case.
6094 2019-06-25 Tom Tromey <tom@tromey.com>
6096 * tui/tui-data.c (tui_data_item_window): Update.
6097 * tui/tui-windata.h (tui_check_data_values): Don't declare.
6098 * tui/tui-windata.c (tui_display_all_data)
6099 (tui_display_data_from_line): Update.
6100 (tui_check_data_values): Remove.
6101 * tui/tui-regs.c (tui_show_register_group)
6102 (tui_display_reg_element_at_line): Update.
6103 * tui/tui-hooks.c (tui_register_changed)
6104 (tui_refresh_frame_and_register_information): Call
6105 tui_check_register_values.
6106 * tui/tui-data.h (struct tui_data_window) <data_content,
6107 data_content_count, data_type>: Remove.
6108 (enum tui_data_type): Remove.
6110 * tui/tui-data.c (tui_data_window::clear_detail)
6111 (~tui_data_window): Update.
6113 2019-06-25 Tom Tromey <tom@tromey.com>
6115 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6117 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6118 Rename from tui_first_data_item_displayed. Update.
6119 (tui_data_window::refresh_all)
6120 (tui_data_window::do_scroll_vertical): Update.
6121 * tui/tui-data.h (struct tui_data_window)
6122 <first_data_item_displayed>: Declare new method.
6124 2019-06-25 Tom Tromey <tom@tromey.com>
6126 * tui/tui-data.h (tui_init_generic_part): Don't declare.
6127 * tui/tui-data.c (tui_init_generic_part): Remove, moving
6129 (tui_initialize_static_data): ...here.
6131 2019-06-25 Tom Tromey <tom@tromey.com>
6133 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6134 (tui_display_registers_from, tui_check_register_values): Update.
6135 (tui_display_register): Remove win_info parameter; update.
6136 (tui_get_register): Change type of parameters.
6137 * tui/tui-data.h (struct tui_data_element): Remove.
6138 (union tui_which_element) <data>: Remove.
6139 <data_window>: Change type.
6140 (struct tui_data_item_window): New.
6141 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6143 (~tui_data_item_window): New destructor.
6144 (free_content_elements): Remove DATA_ITEM_WIN case.
6146 2019-06-25 Tom Tromey <tom@tromey.com>
6148 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6151 2019-06-25 Tom Tromey <tom@tromey.com>
6153 * tui/tui-data.h (struct tui_command_element): Remove.
6154 (union tui_which_element) <command>: Remove.
6155 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
6157 (free_content_elements): Remove CMD_WIN case.
6159 2019-06-25 Tom Tromey <tom@tromey.com>
6161 * tui/tui-layout.c (tui_set_layout): Update.
6162 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6163 * tui/tui-data.c (layout_def): Update.
6165 2019-06-25 Tom Tromey <tom@tromey.com>
6167 * tui/tui-wingeneral.c (tui_refresh_all): Update.
6168 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6169 (tui_source_window_base::set_new_height): Update.
6170 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6172 (tui_set_locator_fullname, tui_set_locator_info)
6173 (tui_show_frame_info): Update.
6174 * tui/tui-source.c (tui_set_source_content)
6175 (tui_source_is_displayed): Update.
6176 * tui/tui-layout.c (show_source_disasm_command, show_data)
6177 (show_source_or_disasm_and_command): Update.
6178 * tui/tui-disasm.c (tui_set_disassem_content)
6179 (tui_get_begin_asm_address): Update.
6180 * tui/tui-data.h (struct tui_locator_element): Remove.
6181 (union tui_which_element) <locator>: Remove.
6182 (struct tui_locator_window): New.
6183 (tui_locator_win_info_ptr): Change return type.
6184 * tui/tui-data.c (_locator): Change type.
6185 (tui_locator_win_info_ptr): Change return type.
6186 (init_content_element): Remove LOCATOR_WIN case. Add assert.
6187 (tui_alloc_content): Add assert.
6189 2019-06-25 Tom Tromey <tom@tromey.com>
6191 * tui/tui-winsource.c
6192 (tui_exec_info_window::maybe_allocate_content): New method.
6193 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6194 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6195 (make_source_or_disasm_window): Add cast.
6196 * tui/tui-data.h (union tui_which_element) <simple_string>:
6198 (struct tui_source_info): New.
6199 (struct tui_source_window_base) <execution_info>: Change type.
6200 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6201 case, and add assert.
6202 (tui_alloc_content): Add assert.
6204 2019-06-25 Tom Tromey <tom@tromey.com>
6206 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6207 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6208 * tui/tui-data.c (tui_alloc_win_info): Remove.
6210 2019-06-25 Tom Tromey <tom@tromey.com>
6212 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6213 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6216 2019-06-25 Tom Tromey <tom@tromey.com>
6218 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6219 make_visible_with_new_height method.
6220 (tui_win_info::make_visible_with_new_height): New method.
6221 (tui_source_window_base::do_make_visible_with_new_height)
6222 (tui_data_window::do_make_visible_with_new_height)
6223 (tui_cmd_window::do_make_visible_with_new_height): New methods.
6224 (make_visible_with_new_height): Remove.
6225 (tui_resize_all, tui_adjust_win_heights): Use
6226 make_visible_with_new_height method.
6227 * tui/tui-data.h (struct tui_win_info)
6228 <do_make_visible_with_new_height, make_visible_with_new_height>:
6230 (struct tui_source_window_base, struct tui_data_window)
6231 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6234 2019-06-25 Tom Tromey <tom@tromey.com>
6236 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6238 (update_tab_width): Call update_tab_width method.
6239 * tui/tui-data.h (struct tui_win_info)
6240 (struct tui_source_window_base) <update_tab_width>: New methods.
6242 2019-06-25 Tom Tromey <tom@tromey.com>
6244 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6246 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6248 (tui_gen_win_info::make_visible): Update.
6249 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6251 * tui/tui-data.h (enum tui_box): New enum.
6252 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6254 2019-06-25 Tom Tromey <tom@tromey.com>
6256 * tui/tui-layout.c (make_source_or_disasm_window): Always use
6257 init_and_make_win for EXEC_INFO_WIN.
6258 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6260 (struct tui_win_info) <~tui_win_info>: Inline.
6261 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6263 * tui/tui-data.c (source_win, disasm_win): Remove globals.
6264 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6266 (tui_initialize_static_data): Update.
6267 (~tui_gen_win_info): Handle more cleanup here.
6268 (~tui_source_window_base): Delete "execution_info".
6269 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6271 2019-06-25 Tom Tromey <tom@tromey.com>
6273 * tui/tui-layout.c (make_command_window): Don't set
6275 (show_source_disasm_command): Call the reset method.
6276 (show_data): Don't set can_highlight. Call the reset method.
6277 (tui_gen_win_info::reset): Rename from init_gen_win_info
6278 (init_and_make_win): Simplify. Return tui_gen_win_info.
6279 (show_source_or_disasm_and_command): Call the reset method.
6280 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6281 (struct tui_cmd_window): Set can_highlight.
6283 2019-06-25 Tom Tromey <tom@tromey.com>
6285 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6287 (tui_make_visible, tui_make_invisible): Rewrite.
6288 (tui_win_info::make_visible): Remove.
6289 (tui_source_window_base::make_visible): Update.
6290 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6291 method. Moved from...
6292 (struct tui_win_info) <make_visible>: ...here.
6294 2019-06-25 Tom Tromey <tom@tromey.com>
6296 * tui/tui-winsource.c
6297 (tui_source_window_base::do_scroll_horizontal): Remove direction
6299 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6300 direction parameter.
6301 * tui/tui-win.c (tui_win_info::forward_scroll)
6302 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6303 (tui_win_info::right_scroll): Update.
6304 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6305 direction parameter.
6306 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6307 direction parameter.
6308 * tui/tui-data.h (enum tui_scroll_direction): Remove.
6309 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6310 Remove direction parameter.
6311 (struct tui_source_window_base, struct tui_source_window)
6312 (struct tui_disasm_window, struct tui_data_window)
6313 (struct tui_cmd_window): Update.
6315 2019-06-25 Tom Tromey <tom@tromey.com>
6317 * tui/tui-winsource.h (tui_set_exec_info_content)
6318 (tui_show_exec_info_content, tui_erase_exec_info_content)
6319 (tui_clear_exec_info_content, tui_update_exec_info): Change
6320 argument to tui_source_window_base.
6321 * tui/tui-winsource.c (tui_set_exec_info_content)
6322 (tui_show_exec_info_content, tui_erase_exec_info_content)
6323 (tui_clear_exec_info_content, tui_update_exec_info): Change
6324 argument to tui_source_window_base.
6326 2019-06-25 Tom Tromey <tom@tromey.com>
6328 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6329 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6331 2019-06-25 Tom Tromey <tom@tromey.com>
6333 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6336 2019-06-25 Tom Tromey <tom@tromey.com>
6338 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6340 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6342 * tui/tui-source.c (tui_set_source_content): Update.
6343 * tui/tui-disasm.c (tui_set_disassem_content): Update.
6345 2019-06-25 Tom Tromey <tom@tromey.com>
6347 * tui/tui-win.c (window_name_completer, tui_set_focus)
6348 (tui_all_windows_info): Use name method.
6349 * tui/tui-data.h (struct tui_gen_win_info)
6350 (struct tui_source_window, struct tui_disasm_window)
6351 (struct tui_data_window, struct tui_cmd_window) <name>: New
6353 (tui_win_name): Don't declare.
6354 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6355 (tui_win_name): Remove.
6357 2019-06-25 Tom Tromey <tom@tromey.com>
6359 * tui/tui-winsource.h (tui_update_source_window)
6360 (tui_update_source_window_as_is): Change parameter type.
6361 * tui/tui-winsource.c (tui_update_source_window): Change win_info
6362 to be a tui_source_window_base.
6363 (tui_update_source_window_as_is): Likewise.
6364 * tui/tui-win.c (make_visible_with_new_height): Update.
6366 2019-06-25 Tom Tromey <tom@tromey.com>
6368 * tui/tui-winsource.c (tui_erase_source_content)
6369 (tui_show_source_content, tui_show_exec_info_content)
6370 (tui_erase_exec_info_content): Use refresh_window method.
6371 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6372 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6373 from tui_refresh_win.
6374 (tui_data_window::refresh_window): New method.
6375 (tui_win_info::refresh, tui_source_window_base::refresh)
6376 (tui_refresh_all): Use refresh_window method.
6377 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6379 * tui/tui-regs.c (tui_display_register): Call refresh_window
6381 * tui/tui-layout.c (show_source_disasm_command)
6382 (show_source_or_disasm_and_command): Call refresh_window method.
6383 * tui/tui-data.h (struct tui_gen_win_info)
6384 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6387 2019-06-25 Tom Tromey <tom@tromey.com>
6389 * tui/tui.c (tui_rl_other_window, tui_enable)
6390 (tui_is_window_visible, tui_get_command_dimension): Update.
6391 * tui/tui-winsource.c (tui_update_source_window_as_is)
6392 (tui_clear_source_content, tui_erase_source_content)
6393 (tui_show_source_line, tui_source_window_base::refill)
6394 (tui_source_window_base::do_scroll_horizontal)
6395 (tui_source_window_base::set_is_exec_point_at)
6396 (tui_update_breakpoint_info, tui_set_exec_info_content)
6397 (tui_alloc_source_buffer, tui_line_is_displayed)
6398 (tui_addr_is_displayed): Update.
6399 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6400 (tui_check_and_display_highlight_if_needed)
6401 (tui_win_info::make_visible, tui_win_info::refresh)
6402 (tui_refresh_all): Update.
6403 * tui/tui-windata.c (tui_first_data_item_displayed)
6404 (tui_delete_data_content_windows, tui_erase_data_content)
6405 (tui_display_all_data, tui_data_window::refresh_all)
6406 (tui_check_data_values): Update.
6407 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6408 (tui_set_win_focus_to, tui_win_info::forward_scroll)
6409 (tui_win_info::backward_scroll, tui_refresh_all_win)
6410 (tui_resize_all, tui_set_focus, tui_all_windows_info)
6411 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6412 (tui_source_window_base::set_new_height)
6413 (tui_data_window::set_new_height)
6414 (make_invisible_and_set_new_height)
6415 (make_visible_with_new_height, new_height_ok)
6416 (parse_scrolling_args): Update.
6417 * tui/tui-stack.c (tui_show_frame_info): Update.
6418 * tui/tui-source.c (tui_set_source_content)
6419 (tui_set_source_content_nil, tui_source_is_displayed)
6420 (tui_source_window::do_scroll_vertical): Update.
6421 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6422 (tui_display_registers_from, tui_display_reg_element_at_line)
6423 (tui_check_register_values, tui_reg_command): Update.
6424 * tui/tui-layout.c (tui_default_win_height)
6425 (show_source_disasm_command, show_data, init_and_make_win)
6426 (show_source_or_disasm_and_command): Update.
6427 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6428 (tui_redisplay_readline, tui_mld_flush)
6429 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6431 * tui/tui-disasm.c (tui_set_disassem_content)
6432 (tui_disasm_window::do_scroll_vertical): Update.
6433 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6435 (struct tui_win_info): Derive from tui_gen_win_info.
6436 <~tui_win_info>: Mark as override.
6437 <generic>: Remove member.
6438 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6439 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6440 (~tui_data_window, ~tui_win_info)
6441 (tui_free_all_source_wins_content): Update.
6442 * tui/tui-command.c (tui_refresh_cmd_win): Update.
6444 2019-06-25 Tom Tromey <tom@tromey.com>
6446 * tui/tui-layout.c (init_and_make_win): Use new.
6447 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6448 destructor, initializers.
6449 (tui_alloc_generic_win_info): Don't declare.
6450 * tui/tui-data.c (_locator): Add argument to constructor.
6451 (source_win, disasm_win): New globals.
6452 (exec_info): Remove.
6453 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6455 (tui_alloc_generic_win_info): Remove.
6456 (init_content_element): Use new.
6457 (tui_win_info::tui_win_info): Update.
6458 (free_content_elements) <case DATA_WIN>: Use delete.
6460 2019-06-25 Tom Tromey <tom@tromey.com>
6462 * tui/tui-wingeneral.c (tui_refresh_win): Update.
6463 * tui/tui-windata.c (tui_first_data_item_displayed)
6464 (tui_delete_data_content_windows): Update.
6465 * tui/tui-win.c (tui_data_window::set_new_height): Update.
6466 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6467 (tui_display_registers_from, tui_check_register_values): Update.
6468 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6470 * tui/tui-data.c (init_content_element): Update. Allocate the new
6472 (tui_free_data_content): Update.
6473 (free_content_elements) <case DATA_WIN>: Free the window.
6475 2019-06-25 Tom Tromey <tom@tromey.com>
6477 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6479 * tui/tui-layout.c (make_command_window)
6480 (show_source_disasm_command, show_data, init_and_make_win)
6481 (show_source_or_disasm_and_command): Update.
6482 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6484 <can_highight, is_highlighted>: Now bool.
6485 (tui_set_win_highlight): Don't declare.
6486 * tui/tui-data.c (tui_set_win_highlight): Remove.
6488 2019-06-25 Tom Tromey <tom@tromey.com>
6490 * tui/tui-wingeneral.c (make_visible): Remove check of window
6493 2019-06-25 Tom Tromey <tom@tromey.com>
6495 * tui/tui-win.c (tui_win_info::max_height)
6496 (tui_cmd_window::max_height): New methods.
6497 (new_height_ok): Call max_height.
6498 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6499 <max_height>: New method.
6501 2019-06-25 Tom Tromey <tom@tromey.com>
6503 * tui/tui-win.c (tui_source_window_base::set_new_height)
6504 (tui_data_window::set_new_height): New methods.
6505 (make_invisible_and_set_new_height): Call set_new_height method.
6506 * tui/tui-data.h (struct tui_win_info)
6507 (struct tui_source_window_base, struct tui_data_window)
6508 <set_new_height>: New method.
6510 2019-06-25 Tom Tromey <tom@tromey.com>
6512 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6513 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6514 tui_refresh_data_win.
6515 * tui/tui-win.c (tui_source_window_base::refresh_all): New
6517 (tui_refresh_all_win): Call the refresh_all method.
6518 (tui_set_focus): Likewise.
6519 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6520 (struct tui_source_window_base, struct tui_data_window) <refresh>:
6523 2019-06-25 Tom Tromey <tom@tromey.com>
6525 * tui/tui-winsource.h (tui_refill_source_window)
6526 (tui_set_is_exec_point_at): Don't declare.
6527 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6528 (tui_source_window_base::refill): Rename from
6529 tui_refill_source_window.
6530 (tui_source_window_base::do_scroll_horizontal): Update.
6531 (tui_source_window_base::set_is_exec_point_at): Rename from
6532 tui_set_is_exec_point_at.
6533 (tui_update_all_breakpoint_info): Update.
6534 * tui/tui-stack.c (tui_show_frame_info): Update.
6535 * tui/tui-layout.c (show_data): Add cast.
6536 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6537 * tui/tui-data.h (struct tui_source_window_base) <refill,
6538 set_is_exec_point_at>: New methods.
6539 (tui_source_windows, tui_add_to_source_windows): Update types.
6540 (tui_add_to_source_windows): Remove redundant declaration.
6541 * tui/tui-data.c (source_windows): Store tui_source_window_base.
6542 (tui_source_windows): Change return type.
6543 (tui_clear_source_windows_detail): Update.
6544 (tui_add_to_source_windows): Change type of parameter.
6545 (tui_free_all_source_wins_content): Update.
6547 2019-06-25 Tom Tromey <tom@tromey.com>
6549 * tui/tui-wingeneral.c (tui_win_info::refresh)
6550 (tui_source_window_base::refresh): New methods.
6551 (tui_refresh_all): Call the refresh method.
6552 * tui/tui-data.h (struct tui_win_info)
6553 (struct tui_source_window_base) <refresh>: New method.
6555 2019-06-25 Tom Tromey <tom@tromey.com>
6557 * tui/tui.h (tui_is_window_visible): Return bool.
6558 * tui/tui.c (tui_is_window_visible): Return bool.
6559 * tui/tui-wingeneral.c (tui_make_window, make_visible)
6560 (tui_make_visible, tui_make_invisible)
6561 (tui_win_info::make_visible)
6562 (tui_source_window_base::make_visible, make_all_visible)
6563 (tui_make_all_visible, tui_make_all_invisible): Update.
6564 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6565 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6567 (struct tui_win_info, struct tui_source_window_base)
6568 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6569 * tui/tui-data.c (tui_init_generic_part): Update.
6571 2019-06-25 Tom Tromey <tom@tromey.com>
6573 * tui/tui-wingeneral.c (tui_win_info::make_visible)
6574 (tui_source_window_base::make_visible): New methods.
6575 (make_all_visible): Make method call.
6576 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6577 (struct tui_source_window_base, struct tui_cmd_window): Override
6579 (tui_win_is_source_type): Don't declare.
6580 * tui/tui-data.c (tui_win_is_source_type): Remove.
6582 2019-06-25 Tom Tromey <tom@tromey.com>
6584 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6587 2019-06-25 Tom Tromey <tom@tromey.com>
6589 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6590 Inline constructor. Add initializers for members.
6591 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6592 constructors; now inline in class.
6594 2019-06-25 Tom Tromey <tom@tromey.com>
6596 * tui/tui-regs.c (tui_show_registers): Update.
6597 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6599 * tui/tui-data.c (tui_data_window::clear_detail)
6600 (tui_data_window): Update.
6602 2019-06-25 Tom Tromey <tom@tromey.com>
6604 * tui/tui-windata.c (tui_display_all_data)
6605 (tui_display_data_from_line, tui_display_data_from)
6606 (tui_check_data_values, tui_data_window::do_scroll_vertical):
6608 * tui/tui-regs.c (tui_last_regs_line_no)
6609 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6610 (tui_show_registers, tui_show_register_group)
6611 (tui_display_registers_from, tui_display_reg_element_at_line)
6612 (tui_display_registers_from_line, tui_check_register_values)
6613 (tui_reg_next, tui_reg_prev): Update.
6614 * tui/tui-layout.c (tui_set_layout, show_data): Update.
6615 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
6617 (struct tui_win_info) <detail>: Remove. Add new fields from
6619 (TUI_DATA_WIN): Add cast.
6620 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6621 (~tui_data_window): Simplify.
6623 2019-06-25 Tom Tromey <tom@tromey.com>
6625 * tui/tui-layout.c (show_source_disasm_command)
6626 (show_source_or_disasm_and_command): Update.
6627 * tui/tui-io.c (update_cmdwin_start_line)
6628 (tui_redisplay_readline): Update.
6629 * tui/tui-data.h (struct tui_command_info): Remove.
6630 (struct tui_win_info) <detail>: Remove command_info member.
6631 (struct tui_data_window) <start_line>: New member, from
6633 (TUI_CMD_WIN): Add casts.
6635 2019-06-25 Tom Tromey <tom@tromey.com>
6637 * tui/tui-winsource.c (tui_update_source_window)
6638 (tui_refill_source_window)
6639 (tui_source_window_base::do_scroll_horizontal)
6640 (tui_update_breakpoint_info, tui_set_exec_info_content)
6641 (tui_show_exec_info_content, tui_erase_exec_info_content)
6642 (tui_clear_exec_info_content): Update.
6643 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6645 * tui/tui-win.c (make_invisible_and_set_new_height)
6646 (make_visible_with_new_height): Update.
6647 * tui/tui-source.c (tui_set_source_content)
6648 (tui_show_symtab_source): Update.
6649 * tui/tui-layout.c (extract_display_start_addr)
6650 (show_source_disasm_command, show_data)
6651 (make_source_or_disasm_window)
6652 (show_source_or_disasm_and_command): Update.
6653 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6654 (tui_disasm_window::do_scroll_vertical): Remove shadowing
6656 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
6657 to tui_source_window_base.
6658 (struct tui_win_info) <detail>: Remove source_info member.
6659 (struct tui_source_window_base) <has_locator>: Inline.
6660 Move contents from tui_source_info; rename has_locator member to
6662 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6663 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6665 (tui_source_window_base::clear_detail, ~tui_source_window_base):
6667 (tui_free_all_source_wins_content): Cast to
6668 tui_source_window_base.
6670 2019-06-25 Tom Tromey <tom@tromey.com>
6672 * tui/tui-win.c (make_invisible_and_set_new_height)
6673 (make_visible_with_new_height): Call has_locator method.
6674 * tui/tui-layout.c (show_source_disasm_command, show_data)
6675 (show_source_or_disasm_and_command): Update for bool change.
6676 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6677 (tui_win_info) <has_locator>: New method.
6678 (struct tui_source_window_base) <has_locator>: New method.
6679 (tui_win_has_locator): Don't declare.
6680 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6681 from tui_win_has_locator.
6682 (tui_source_window_base): Use false, not FALSE.
6684 2019-06-25 Tom Tromey <tom@tromey.com>
6686 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6687 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6688 clear_detail method directly.
6689 (tui_clear_win_detail): Remove.
6691 2019-06-25 Tom Tromey <tom@tromey.com>
6693 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6694 "this", not TUI_DISASM_WIN.
6696 2019-06-25 Tom Tromey <tom@tromey.com>
6698 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
6700 * tui/tui-winsource.c
6701 (tui_source_window_base::do_scroll_horizontal): Rename from
6702 tui_horizontal_source_scroll.
6703 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6704 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6705 from tui_vertical_data_scroll.
6706 * tui/tui-win.h (tui_scroll): Don't declare.
6707 * tui/tui-win.c (tui_win_info::forward_scroll)
6708 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6709 (tui_win_info::right_scroll): Rename and update.
6710 (tui_scroll_forward_command, tui_scroll_backward_command)
6711 (tui_scroll_left_command, tui_scroll_right_command): Update.
6712 (tui_scroll): Remove.
6713 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6714 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6715 from tui_vertical_source_scroll.
6716 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6717 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6718 from tui_vertical_disassem_scroll.
6719 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6720 do_scroll_horizontal>: New methods.
6721 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6723 (struct tui_source_window_base): Add do_scroll_horizontal.
6724 (struct tui_source_window, struct tui_disasm_window): Add
6726 (struct tui_data_window, struct tui_cmd_window): Add
6727 do_scroll_horizontal and do_scroll_vertical.
6728 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6730 2019-06-25 Tom Tromey <tom@tromey.com>
6732 * tui/tui-data.h (struct tui_source_window_base): New struct.
6733 (struct tui_source_window): Derive from tui_source_window_base.
6734 (struct tui_disasm_window): New struct.
6735 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6736 from tui_source_window::clear_detail.
6737 (tui_source_window_base): Rename from tui_source_window.
6738 (~tui_source_window_base): Rename from ~tui_source_window.
6739 (tui_alloc_win_info): Create a tui_disasm_window.
6741 2019-06-25 Tom Tromey <tom@tromey.com>
6743 * tui/tui-data.h (struct tui_source_window)
6744 (struct tui_data_window): Declare destructors.
6745 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6747 (tui_win_info): Simplify.
6749 2019-06-25 Tom Tromey <tom@tromey.com>
6751 * tui/tui-winsource.c (tui_display_main)
6752 (tui_update_source_windows_with_addr)
6753 (tui_update_all_breakpoint_info): Update.
6754 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6755 (new_height_ok, parse_scrolling_args): Update.
6756 * tui/tui-stack.c (tui_show_frame_info): Update.
6757 * tui/tui-data.h (struct tui_list): Remove.
6758 (tui_source_windows): Return a reference to a std::vector.
6759 * tui/tui-data.c (source_windows): Now a std::vector.
6760 (tui_source_windows): Change return type.
6761 (tui_clear_source_windows): Rewrite.
6762 (tui_clear_source_windows_detail, tui_add_to_source_windows)
6763 (tui_free_all_source_wins_content): Rewrite.
6765 2019-06-25 Tom Tromey <tom@tromey.com>
6767 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6768 (struct tui_data_window, struct tui_cmd_window): Declare
6769 clear_detail method.
6770 * tui/tui-data.c (tui_source_window::clear_detail)
6771 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6773 (tui_clear_win_detail): Simplify.
6775 2019-06-25 Tom Tromey <tom@tromey.com>
6777 * tui/tui-layout.c (make_source_window, make_disasm_window)
6778 (make_source_or_disasm_window): Remove win_info_ptr parameter.
6779 Return the new window.
6780 (show_source_disasm_command, show_data)
6781 (show_source_or_disasm_and_command): Update.
6783 2019-06-25 Tom Tromey <tom@tromey.com>
6785 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6786 parameter. Return the new window.
6787 (show_source_disasm_command): Update and remove NULL check.
6788 (show_source_or_disasm_and_command): Update.
6790 2019-06-25 Tom Tromey <tom@tromey.com>
6792 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6794 2019-06-25 Tom Tromey <tom@tromey.com>
6796 * tui/tui-data.h (struct tui_win_info): Make constructor
6797 protected. Make destructor virtual. Add initializers.
6798 (tui_source_window, tui_data_window, tui_cmd_window): New
6800 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
6801 constructor. Add "type" parameter.
6802 (tui_source_window, tui_data_window, tui_cmd_window): New
6804 (tui_alloc_win_info): Instantiate the appropriate subclass.
6806 2019-06-25 Tom Tromey <tom@tromey.com>
6808 * tui/tui-win.c (tui_resize_all): Use delete.
6809 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6811 (tui_free_window): Don't declare.
6812 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6815 2019-06-25 Tom Tromey <tom@tromey.com>
6817 * tui/tui-data.h (struct tui_win_info): Add constructor.
6818 * tui/tui-data.c (tui_alloc_win_info): Use new.
6819 (tui_free_window): Use delete.
6821 2019-06-22 Tom Tromey <tom@tromey.com>
6823 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6825 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6827 2019-06-22 Tom Tromey <tom@tromey.com>
6829 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6831 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6833 2019-06-22 Tom de Vries <tdevries@suse.de>
6835 * dwarf2read.c (create_addrmap_from_aranges)
6836 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6839 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
6841 * dwarf2read.h (dwarf2_section_info_def): Remove.
6842 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6843 * dwarf2read.c (struct dwo_sections) <types>: Change type to
6844 std::vector<dwarf2_section_info>.
6845 (struct dwo_file) <~dwo_file>: Remove.
6846 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6848 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6849 (dwarf2_read_debug_names): Likewise.
6850 (create_debug_types_hash_table): Change parameter type to
6851 array_view, adjust code accordingly.
6852 (dwarf2_locate_dwo_sections): Adjust to std::vector.
6853 (partial_die_info::fixup): Likewise.
6854 (determine_prefix): Likewise.
6855 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6857 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6859 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6861 <~dwo_file>: Remove call to gdb_bfd_unref.
6862 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6863 gdb_bfd_ref_ptr::get.
6865 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6867 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6869 * dwarf2read.c (struct dwo_file): Initialize fields.
6871 (free_dwo_file): Remove, move content to ~dwo_file.
6872 (struct dwo_file_deleter): Remove.
6873 (dwo_file_up>: Remove custom deleter.
6874 (free_dwo_files): Remove.
6875 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6877 (process_skeletonless_type_units): Call unique_ptr::get.
6878 (allocate_dwo_file_hash_table): Add deleter to created hash
6879 table. Change return type to htab_up.
6880 (lookup_dwo_file_slot): Don't memset dwo_file, call
6882 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6883 (create_dwo_unit_in_dwp_v2): Likewise.
6884 (open_and_init_dwo_file): Likewise.
6885 (free_dwo_file_from_slot): Remove.
6887 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6889 * dwarf2read.h (struct dwarf2_section_info) <readin,
6890 is_virtual>: Change type to bool.
6891 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6894 2019-06-19 Tom Tromey <tom@tromey.com>
6896 * tui/tui-data.h (tui_init_content_element): Don't declare.
6898 2019-06-19 Tom Tromey <tom@tromey.com>
6900 * tui/tui-data.h (tui_init_win_info): Don't declare.
6902 2019-06-19 Tom de Vries <tdevries@suse.de>
6904 * dwarf2read.h (abstract_to_concrete): Change type to
6905 std::unordered_map<sect_offset, std::vector<sect_offset>,
6906 gdb::hash_enum<sect_offset>>.
6908 2019-06-19 Tom Tromey <tromey@adacore.com>
6910 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6911 EVAL_AVOID_SIDE_EFFECTS specially.
6913 2019-06-19 Tom Tromey <tromey@adacore.com>
6915 * source-cache.c (highlighter): New global.
6916 (source_cache::get_source_lines): Create a highlighter on demand.
6918 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
6920 * defs.h (deprecated_interactive_hook): Delete declaration.
6921 * interps.c (clear_interpreter_hooks): Remove use of
6922 deprecated_interactive_hook.
6923 * top.c (deprecated_interactive_hook): Delete definition.
6924 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6926 2019-06-18 Tom de Vries <tdevries@suse.de>
6929 * dwarf2read.h (abstract_to_concrete): Change type from
6930 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6931 std::unordered_map<sect_offset, std::vector<sect_offset>>.
6932 * dwarf2read.c (read_variable): Update.
6933 (dwarf2_fetch_die_loc_sect_off): Update.
6935 2019-06-17 Tom de Vries <tdevries@suse.de>
6938 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6939 accessing parent[parent_len - 1].
6941 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
6944 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6945 call dtrace_process_dof with NULL dof.
6947 2019-06-16 Tom de Vries <tdevries@suse.de>
6950 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6952 2019-06-16 Tom Tromey <tom@tromey.com>
6954 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6955 (make_all_visible): Use address of member.
6957 2019-06-16 Tom Tromey <tom@tromey.com>
6959 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6960 (tui_free_window, free_content, free_content_elements): Remove
6962 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6964 * tui/tui-regs.c (tui_show_register_group)
6965 (tui_display_registers_from, tui_display_reg_element_at_line):
6966 Remove unnecessary cast.
6968 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
6970 * linux-nat.c (normal_mask): Delete.
6971 (_initialize_linux_nat): Don't initialise normal_mask.
6973 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
6976 * dwarf-index-write.h (write_psymtabs_to_index): Add
6977 dwz_basename parameter.
6978 * dwarf-index-write.c (write_gdbindex): Move file writing to
6979 write_gdbindex_1. Change return type void.
6980 (assert_file_size): Move up, remove filename parameter.
6981 (write_gdbindex_1): New function.
6982 (write_debug_names): Change return type to void, call
6984 (struct index_wip_file): New struct.
6985 (write_psymtabs_to_index): Add dwz_basename parameter. Move
6986 file logic to index_wip_file. Write index for dwz file if
6988 (save_gdb_index_command): Pass basename of dwz file, if present.
6989 * dwarf-index-cache.c (index_cache::store): Obtain and pass
6990 build-id of dwz file, if present.
6991 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6992 (dwarf2_get_dwz_file): Likewise.
6993 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6994 (dwarf2_get_dwz_file): Likewise.
6996 2019-06-16 Tom Tromey <tom@tromey.com>
6998 * coffread.c (process_coff_symbol): Use xstrdup.
6999 * value.c (create_internalvar): Use xstrdup.
7001 2019-06-16 Tom Tromey <tom@tromey.com>
7003 * valops.c (value_cast, value_slice): Remove unnecessary cast.
7004 * breakpoint.c (stopin_command, stopat_command)
7005 (until_break_command, decode_location_default): Remove unnecessary
7007 * utils.c (subset_compare): Remove unnecessary cast.
7008 * ada-lang.c (ada_update_initial_language): Remove unnecessary
7010 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7012 * infcmd.c (path_command): Remove unnecessary cast.
7013 * coffread.c (decode_type): Remove unnecessary cast.
7014 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7015 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7016 * tui/tui-stack.c (tui_show_locator_content)
7017 (tui_show_frame_info): Remove unnecessary cast.
7018 * tui/tui-win.c (tui_scroll_forward_command)
7019 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7020 (parse_scrolling_args): Remove unnecessary cast.
7021 * tui/tui-data.c (init_win_info, tui_del_window)
7022 (tui_free_window, tui_del_data_windows, tui_free_data_content)
7023 (free_content_elements): Remove unnecessary cast.
7024 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7026 * tui/tui-source.c (tui_set_source_content)
7027 (tui_vertical_source_scroll): Remove unnecessary cast.
7028 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7030 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7031 * tui/tui-regs.c (tui_display_registers_from)
7032 (tui_display_register): Remove unnecessary cast.
7033 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7034 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7035 (make_visible): Remove unnecessary cast.
7036 * tui/tui-winsource.c (tui_erase_source_content)
7037 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7039 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7040 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7041 * stabsread.c (read_type, read_array_type, read_range_type):
7042 Remove unnecessary cast.
7043 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7044 (parse_symbol, parse_type, upgrade_type, parse_external)
7045 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7047 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7049 2019-06-16 Tom Tromey <tom@tromey.com>
7051 * tui/tui-data.c (tui_alloc_generic_win_info)
7052 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7055 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
7056 Andrew Burgess <andrew.burgess@embecosm.com>
7058 * f-typeprint.c (f_print_type): Don't return early for not
7059 associated or not allocated types.
7060 (f_type_print_varspec_suffix): Add print_rank parameter and print
7061 ranks of array types in case they dangling.
7062 (f_type_print_base): Add print_rank parameter.
7064 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7066 * NEWS: Mention new MI commands.
7067 * break-catch-throw.c (enum exception_event_kind): Move to
7069 (print_mention_exception_catchpoint): Output text as a single
7071 (catch_exception_command_1): Rename to...
7072 (catch_exception_event): ...this, make non-static, update header
7073 command, and change some parameter types.
7074 (catch_catch_command): Update for changes to
7075 catch_exception_command_1.
7076 (catch_throw_command): Likewise.
7077 (catch_rethrow_command): Likewise.
7078 * breakpoint.c (enum exception_event_kind): Delete.
7079 * breakpoint.h (enum exception_event_kind): Moved here from
7080 break-catch-throw.c.
7081 (catch_exception_event): Declare.
7082 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7083 (mi_cmd_catch_throw): New function.
7084 (mi_cmd_catch_rethrow): New function.
7085 (mi_cmd_catch_catch): New function.
7086 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7087 'catch-catch' entries.
7088 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7089 (mi_cmd_catch_rethrow): Declare.
7090 (mi_cmd_catch_catch): Declare.
7092 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7094 * annotate.c (annotate_source_line): Change return type to void,
7095 update implementation to match.
7096 * annotate.h (annotate_source_line): Change return type to void,
7097 update header comment.
7098 * stack.c (print_frame_info): Don't change what frame information
7099 is printed based on whether annotations are on or not.
7101 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7103 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7104 (annotate_source): Make static.
7105 (annotate_source_line): Moved from source.c and renamed from
7106 identify_source_line. Update the return type.
7107 * annotate.h (annotate_source): Delete declaration.
7108 (annotate_source_line): Declaration moved from source.h, and
7109 renamed from identify_source_line. Return type updated.
7110 * source.c (identify_source_line): Moved to annotate.c and renamed
7111 to annotate_source_line.
7112 (info_line_command): Remove check of annotation_level.
7113 * source.h (identify_source_line): Move declaration to annotate.h
7114 and rename to annotate_source_line.
7115 * stack.c: Add 'annotate.h' include.
7116 (print_frame_info): Remove check of annotation_level before
7117 calling annotate_source_line.
7119 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7121 * source-cache.c (source_cache::get_plain_source_lines): Use
7122 open_source_file_with_line_charpos instead of just
7123 open_source_file, remove call to find_source_lines.
7124 (source_cache::get_source_lines): Likewise.
7125 * source.c (find_source_lines): Make static.
7126 (get_filename_and_charpos): Renamed into...
7127 (open_source_file_with_line_charpos): ..this along with changes to
7128 return a scoped_fd, and some other minor clean ups.
7129 (identify_source_line): Use open_source_file_with_line_charpos.
7130 (search_command_helper): Use open_source_file_with_line_charpos
7131 instead of just open_source_file, remove call to
7133 * source.h (open_source_file_with_line_charpos): Declare new
7135 (find_source_lines): Delete declaration.
7137 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7139 * source.c (get_filename_and_charpos): Remove fullname
7141 (identify_source_line): Update call to get_filename_and_charpos.
7143 2019-06-14 Tom Tromey <tromey@adacore.com>
7146 * ui-style.h (skip_ansi_escape): Update comment.
7147 * ui-file.h (class no_terminal_escape_file): New class.
7148 * ui-file.c (no_terminal_escape_file::write)
7149 (no_terminal_escape_file::puts): New methods.
7150 * cli/cli-logging.c (handle_redirections): Use
7151 no_terminal_escape_file.
7153 2019-06-14 Tom Tromey <tromey@adacore.com>
7155 * NEWS: Move convenience variable news above Python news.
7157 2019-06-14 Tom Tromey <tom@tromey.com>
7159 * gnulib: Move directory to top-level.
7160 * configure.ac: Don't configure gnulib.
7161 * configure: Rebuild.
7162 * common/common-defs.h: Use new path to gnulib.
7163 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7165 (INCGNU): Look in new gnulib location.
7166 (HFILES_NO_SRCDIR): Remove gnulib files.
7167 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7168 (generated_files): Remove GNULIB_H.
7169 ($(LIBGNU), all-lib): Remove targets.
7170 (distclean): Don't mention GNULIB_BUILDDIR.
7171 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7173 2019-06-14 Tom Tromey <tromey@adacore.com>
7175 * symfile.c (add_symbol_file_command): Remove obsolete comment.
7176 Warn if symbol file does not provide any symbols.
7178 2019-06-14 Tom Tromey <tromey@adacore.com>
7180 * source.c (find_and_open_source): Respect basenames_may_differ.
7182 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
7184 * annotate.c (annotate_breakpoints_invalid): Make use of
7185 scoped_restore_terminal_state.
7186 (annotate_frames_invalid): Likewise.
7188 2019-06-14 Tom Tromey <tromey@adacore.com>
7190 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7191 allow assignment to an internalvar.
7193 2019-06-14 Tom Tromey <tromey@adacore.com>
7195 * ada-lex.l: Allow "_" in attribute names.
7197 2019-06-14 Tom Tromey <tromey@adacore.com>
7200 * regcache.c (registers_changed): Don't call alloca.
7201 * top.c (execute_command): Don't call alloca.
7203 2019-06-13 Pedro Alves <palves@redhat.com>
7205 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7206 'expression'. When parsing an expression, error out if there's
7207 junk after "unlimited".
7208 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7209 (do_set_command): Adjust calls to is_unlimited_literal.
7211 2019-06-13 Pedro Alves <palves@redhat.com>
7213 * compile/compile.c (make_compile_options_def_group): Add braces
7214 around array_view initializer.
7215 * thread.c (make_thread_apply_all_options_def_group)
7216 (make_thread_apply_all_options_def_group): Likewise.
7218 2019-06-13 Pedro Alves <palves@redhat.com>
7220 * NEWS (New commands): Mention "maint test-options
7221 require-delimiter", "maint test-options unknown-is-error", "maint
7222 test-options unknown-is-operand" and "maint show
7223 test-options-completion-result".
7224 (New command options, command completion): New section.
7225 (Completion improvements): New section.
7226 Mention that you can abbreviate "unlimited".
7228 2019-06-13 Pedro Alves <palves@redhat.com>
7230 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7231 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7232 * unittests/cli-utils-selftests.c (test_parse_flags)
7233 (test_parse_flags_qcs): Delete.
7234 (test_cli_utils): Don't call deleted functions.
7236 2019-06-13 Pedro Alves <palves@redhat.com>
7238 * thread.c: Include "cli/cli-option.h".
7239 (tp_array_compar_ascending): Global.
7240 (tp_array_compar): Delete function.
7241 (tp_array_compar_ascending, tp_array_compar_descending): New
7243 (ascending_option_def, qcs_flag_option_def)
7244 (thr_qcs_flags_option_defs)
7245 (make_thread_apply_all_options_def_group)
7246 (make_thread_apply_options_def_group): New.
7247 (thread_apply_all_command): Use gdb::option::process_options.
7248 (thread_apply_command_completer)
7249 (thread_apply_all_command_completer): New.
7250 (thread_apply_command): Use gdb::option::process_options.
7251 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7252 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
7253 to generate help text of "thread apply". Adjust "taas"'s help.
7254 * tid-parse.c (tid_range_parser::in_thread_range): New method.
7255 * tid-parse.h (tid_range_parser::in_thread_range): New method.
7257 2019-06-13 Pedro Alves <palves@redhat.com>
7259 * thread.c (thread_apply_command): Check for invalid TID with
7260 isdigit instead of !isalpha.
7262 2019-06-13 Pedro Alves <palves@redhat.com>
7264 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7265 (validate_flags_qcs): New.
7266 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7267 (validate_flags_qcs): Declare.
7268 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7269 (make_frame_apply_options_def_group): New.
7270 (frame_apply_command_count): Process options with
7271 gdb::option::process_options.
7272 (frame_apply_completer): New.
7273 (frame_apply_level_completer, frame_apply_all_completer)
7274 (frame_apply_completer): New.
7275 (_initialize_stack): Update help of "frame apply", "frame apply
7276 level", "frame apply all" and "faas" to mention supported options
7277 and install command completers.
7278 * stack.h (frame_apply_all_completer): Declare.
7279 * thread.c: Include "stack.h".
7280 (tfaas_command): Add "--".
7281 (_initialize_thread): Update help "tfaas" to mention supported
7282 options and install command completer.
7284 2019-06-13 Pedro Alves <palves@redhat.com>
7286 * completer.c (complete_nested_command_line): New.
7287 (gdb_completion_word_break_characters_throw): Add assertion.
7288 * completer.h (complete_nested_command_line): Declare.
7290 2019-06-13 Pedro Alves <palves@redhat.com>
7292 * stack.c (parse_backtrace_qualifiers): New.
7293 (backtrace_command): Use it.
7294 (backtrace_command_completer): Complete on qualifiers.
7296 2019-06-13 Pedro Alves <palves@redhat.com>
7298 * frame.c: Include "cli/cli-option.h.
7299 (user_set_backtrace_options): New.
7300 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7302 (get_prev_frame): Adjust.
7303 (boolean_option_def, uinteger_option_def)
7304 (set_backtrace_option_defs): New.
7305 (_initialize_frame): Adjust and use
7306 gdb::option::add_setshow_cmds_for_options to install "set
7307 backtrace past-main" and "set backtrace past-entry".
7308 * frame.h: Include "cli/cli-option.h".
7309 (struct frame_print_options): Forward declare.
7310 (print_frame_arguments_all, print_frame_arguments_scalars)
7311 (print_frame_arguments_none): Declare.
7312 (print_entry_values): Delete declaration.
7313 (struct frame_print_options, user_frame_print_options): New.
7314 (struct set_backtrace_options): New.
7315 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7316 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7317 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7318 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7319 (list_args_or_locals): Add frame_print_options parameter.
7320 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7321 * python/py-framefilter.c (enumerate_args): Pass down
7322 USER_FRAME_PRINT_OPTIONS.
7323 * stack.c: Include "cli/cli-option.h".
7324 (print_frame_arguments_all, print_frame_arguments_scalars)
7325 (print_frame_arguments_none): Declare.
7326 (print_raw_frame_arguments, print_entry_values): Delete.
7327 (user_frame_print_options): New.
7328 (boolean_option_def, enum_option_def, frame_print_option_defs):
7330 (struct backtrace_cmd_options): New.
7331 (bt_flag_option_def): New.
7332 (backtrace_command_option_defs): New.
7333 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7334 (print_frame_arg, read_frame_arg, print_frame_args)
7335 (print_frame_info, print_frame): Add frame_print_options parameter
7337 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7338 (backtrace_command_1): Add frame_print_options and
7339 backtrace_cmd_options parameters and use them.
7340 (make_backtrace_options_def_group): New.
7341 (backtrace_command): Process command options with
7342 gdb::option::process_options.
7343 (backtrace_command_completer): New.
7344 (_initialize_stack): Extend "backtrace"'s help to mention
7345 supported options. Install completer for "backtrace".
7346 Install some settings commands with add_setshow_cmds_for_options.
7348 2019-06-13 Pedro Alves <palves@redhat.com>
7350 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7351 and that "set/show print raw frame-arguments" are now deprecated.
7353 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7355 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7356 * stack.c (_initialize_stack): Install "set/show print
7357 raw-frame-arguments", and deprecate "set/show print raw
7359 * valprint.c (_initialize_valprint): Deprecate "set/show print
7362 2019-06-13 Pedro Alves <palves@redhat.com>
7364 * compile/compile.c (struct compile_options): New.
7365 (compile_flag_option_def, compile_command_option_defs)
7366 (make_compile_options_def_group): New.
7367 (compile_file_command): Handle options with
7368 gdb::option::process_options.
7369 (compile_file_command_completer): New function.
7370 (compile_code_command): Handle options with
7371 gdb::option::process_options.
7372 (compile_code_command_completer): New function.
7373 (_initialize_compiler): Install completers for "compile code" and
7374 "compile file". Mention available options in "compile code" and
7375 "compile code"'s help.
7376 * completer.c (advance_to_completion_word): New, factored out from
7378 (advance_to_expression_complete_word_point): ... this.
7379 (advance_to_filename_complete_word_point): New.
7380 * completer.h (advance_to_filename_complete_word_point): New
7383 2019-06-13 Pedro Alves <palves@redhat.com>
7385 * compile/compile.c: Include "cli/cli-option.h".
7386 (compile_print_value): Scope data pointer is now a
7387 value_print_options pointer; adjust.
7388 (compile_print_command): Process options. Scope data pointer is
7389 now a value_print_options pointer; adjust.
7390 (_initialize_compile): Update "compile print"'s help to include
7391 supported options. Install a completer for "compile print".
7392 * cp-valprint.c (show_vtblprint, show_objectprint)
7393 (show_static_field_print): Delete.
7394 (_initialize_cp_valprint): Don't install "set print
7395 static-members", "set print vtbl", "set print object" here.
7396 * printcmd.c: Include "cli/cli-option.h" and
7397 "common/gdb_optional.h".
7398 (print_command_parse_format): Rework to fill in a
7399 value_print_options instead of a format_data.
7400 (print_value): Change parameter type from format_data pointer to
7401 value_print_options reference. Adjust.
7402 (print_command_1): Process options. Adjust to pass down a
7403 value_print_options.
7404 (print_command_completer): New.
7405 (_initialize_printcmd): Install print_command_completer as
7406 handle_brkchars completer for the "print" command. Update
7407 "print"'s help to include supported options.
7408 * valprint.c: Include "cli/cli-option.h".
7409 (show_vtblprint, show_objectprint, show_static_field_print): Moved
7410 here from cp-valprint.c.
7411 (boolean_option_def, uinteger_option_def)
7412 (value_print_option_defs, make_value_print_options_def_group):
7413 New. Use gdb::option::add_setshow_cmds_for_options to install
7414 "set print elements", "set print null-stop", "set print repeats",
7415 "set print pretty", "set print union", "set print array", "set
7416 print address", "set print symbol", "set print array-indexes".
7417 * valprint.h: Include <string> and "cli/cli-option.h".
7418 (make_value_print_options_def_group): Declare.
7419 (print_value): Change parameter type from format_data pointer to
7420 value_print_options reference.
7421 (print_command_completer): Declare.
7423 2019-06-13 Pedro Alves <palves@redhat.com>
7425 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7426 (COMMON_SFILES): Add maint-test-settings.c.
7427 * cli/cli-decode.c (boolean_enums): New global, factored out from
7429 (add_setshow_boolean_cmd): ... here.
7430 * cli/cli-decode.h (boolean_enums): Declare.
7431 * cli/cli-option.c: New file.
7432 * cli/cli-option.h: New file.
7433 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7434 factored out from ...
7435 (parse_cli_boolean_value(const char *)): ... this.
7436 (is_unlimited_literal): Change parameter type to pointer to
7437 pointer. Adjust and advance ARG pointer.
7438 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7439 (parse_cli_var_enum): New, factored out from ...
7440 (do_set_command): ... this. Adjust.
7441 * cli/cli-setshow.h (parse_cli_boolean_value)
7442 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7443 (parse_cli_var_enum): Declare.
7444 * cli/cli-utils.c: Include "cli/cli-option.h".
7445 (get_ulongest): New.
7446 * cli/cli-utils.h (get_ulongest): Declare.
7447 (check_for_argument): New overloads.
7448 * maint-test-options.c: New file.
7450 2019-06-13 Pedro Alves <palves@redhat.com>
7452 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7453 parse a range if "-" is at the end of the string.
7455 2019-06-13 Pedro Alves <palves@redhat.com>
7457 * cli/cli-setshow.c (parse_auto_binary_operation)
7458 (parse_cli_boolean_value): Don't allow "o".
7460 2019-06-13 Pedro Alves <palves@redhat.com>
7462 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7463 * NEWS: Mention maint test-settings KIND.
7464 * maint-test-settings.c: New file.
7466 2019-06-13 Pedro Alves <palves@redhat.com>
7468 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7470 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7473 2019-06-13 Pedro Alves <palves@redhat.com>
7475 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7478 2019-06-13 Pedro Alves <palves@redhat.com>
7480 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7482 2019-06-13 Pedro Alves <palves@redhat.com>
7484 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7485 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7487 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7488 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7490 (check_for_argument): Skip spaces after argument.
7492 2019-06-13 Pedro Alves <palves@redhat.com>
7494 * thread.c (thread_apply_command): Adjust TID parsing.
7495 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7496 detected before end of string.
7497 (tid_is_in_list): Error out if LIST is invalid.
7499 2019-06-13 Pedro Alves <palves@redhat.com>
7501 * completer.c (complete_line_internal_1): Rewind completion word
7503 (completion_tracker::advance_custom_word_point_by): Change
7504 parameter type to int.
7505 * completer.h (completion_tracker::advance_custom_word_point_by):
7508 2019-06-13 Pedro Alves <palves@redhat.com>
7510 * completer.c (advance_to_completion_word): Handle delimiters.
7512 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
7514 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7516 2019-06-11 Tom Tromey <tom@tromey.com>
7518 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7519 (xmalloc_failed): Move to alloc.c.
7520 * alloc.c: New file.
7521 * Makefile.in (COMMON_SFILES): Add alloc.c.
7523 2019-06-11 Tom Tromey <tom@tromey.com>
7525 * nat/linux-waitpid.c: Don't include server.h.
7526 (linux_debug): Remove.
7527 (my_waitpid): Update.
7529 2019-06-11 Tom Tromey <tromey@adacore.com>
7531 * infcall.c (_initialize_infcall): Remove trailing newline from
7533 * user-regs.c (_initialize_user_regs): Remove trailing newline
7535 * typeprint.c (_initialize_typeprint): Remove trailing newline
7537 * reverse.c (_initialize_reverse): Remove trailing newlines from
7539 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7541 * language.c (add_set_language_command): Remove trailing newline
7543 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7545 * disasm.c (_initialize_disasm): Remove trailing newline from
7547 * top.c (init_main): Remove trailing newline from help.
7548 * interps.c (_initialize_interpreter): Remove trailing newline
7550 * btrace.c (_initialize_btrace): Remove trailing newlines from
7552 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7554 * python/python.c (_initialize_python): Remove trailing newline
7556 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7558 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7559 from help. Reformat some text.
7560 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7562 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7565 2019-06-11 Tom Tromey <tromey@adacore.com>
7567 * darwin-nat.c (darwin_decode_exception_message)
7568 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7570 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
7572 * valops.c (value_slice): Check for not allocated or not
7575 2019-06-10 Tom de Vries <tdevries@suse.de>
7578 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7579 sure an empty slot (defined by a 32-bit zero pair) is recognized as
7582 2019-06-10 Tom de Vries <tdevries@suse.de>
7585 * linespec.c (linespec_lexer_lex_string): Remove incorrect
7586 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
7588 2019-06-10 Tom de Vries <tdevries@suse.de>
7591 * symtab.c (struct demangled_name_entry): Add language field.
7592 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
7593 static minimal symbol". Set and use language field.
7595 2019-06-10 Tom Tromey <tromey@adacore.com>
7597 * ada-lang.c (_initialize_ada_language): Update help text.
7599 2019-06-10 Tom Tromey <tromey@adacore.com>
7601 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7603 * guile/guile.c (handle_boot_error): Don't end warning with a
7605 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7606 warning with a newline.
7607 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7609 (s12z_frame_cache): Likewise.
7610 * dwarf-index-cache.c (index_cache::store): Don't end warning with
7612 * solib-svr4.c (disable_probes_interface): Don't end warning with
7614 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7616 * python/python.c (do_finish_initialization): Don't end warning
7619 2019-06-10 Tom Tromey <tom@tromey.com>
7621 * python/py-breakpoint.c (gdbpy_breakpoint_created)
7622 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7625 2019-06-10 Tom Tromey <tromey@adacore.com>
7627 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7629 (elf_new_init): Don't call stabsread_new_init.
7630 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7631 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
7632 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7634 2019-06-10 Tom de Vries <tdevries@suse.de>
7638 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7640 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
7642 * source.c (find_and_open_source): Also rewrite relative file
7645 2019-04-26 Amos Bird <amosbird@gmail.com>
7647 * annotate.c (annotate_thread_exited): Add "thread-exited"
7650 2019-06-06 Tom Tromey <tromey@adacore.com>
7652 * maint.h (class scoped_command_stats): Use
7653 DISABLE_COPY_AND_ASSIGN.
7654 <print_time>: New method.
7655 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7657 (scoped_command_stats::print_time): New method.
7659 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
7661 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7662 instructions of lengths 6 or 8 bytes.
7664 2019-06-04 Pedro Alves <palves@redhat.com>
7666 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7668 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7669 * breakpoint.c (condition_completer): Likewise.
7670 * cli/cli-dump.c (scan_expression): Likewise.
7671 * common/filestuff.c (mkdir_recursive): Likewise.
7672 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7673 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7674 (gdb_abspath): Likewise.
7675 * compile/compile-cplus-types.c
7676 (compile_cplus_instance::decl_name): Likewise.
7677 * completer.c (complete_explicit_location):
7678 (signal_completer, reg_or_group_completer_1): Likewise.
7679 * cp-support.c (cp_remove_params_if_any): Likewise.
7680 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7681 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7682 * infcmd.c (strip_bg_char): Likewise.
7683 * linespec.c (copy_token_string): Likewise.
7684 * mi/mi-main.c (output_cores): Likewise.
7685 * psymtab.c (psymtab_search_name):
7686 * symfile.c (test_set_ext_lang_command): Likewise.
7687 * target.c (target_fileio_read_stralloc): Likewise.
7688 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7689 * value.c (complete_internalvar): Likewise.
7691 2019-06-04 Christian Biesinger <cbiesinger@google.com>
7693 Add objfile property to gdb.Type.
7694 * NEWS: Mention Python API addition.
7695 * python/py-type.c (typy_get_objfile): New method.
7697 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7699 * NEWS: Mention the new set|show style [title|highlight].
7700 Mention changes to "show style", "help" and "apropos".
7702 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7704 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7705 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
7706 instead of print_help_for_command.
7707 (print_doc_of_command): New function.
7708 (help_list): Add 'apropos -v word' suggestion.
7709 (print_help_for_command): Style the command name using title style.
7710 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7711 (_initialize_cli_cmds): Describe -v in apropos_command help.
7713 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7715 * cli/cli-style.h (cli_style_option): Add name in constructor,
7716 add m_name class member, add constructor with intensity,
7717 add name class function.
7718 (cli_style_option::add_setshow_commands): Remove name argument.
7719 (highlight_style, title_style): New styles.
7720 * cli/cli-style.c (do_show): New function that shows a style
7721 characteristic styling the style name with itself.
7722 (set_style_name): New function.
7723 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7724 Update all callers according to the changes in cli/cli-style.h.
7725 * utils.h (fputs_highlighted): New function.
7726 * utils.c (fputs_highlighted): Likewise.
7728 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7730 * NEWS: Mention new pipe command and new convenience variables.
7732 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7734 * cli/cli-cmds.c (pipe_command): New function.
7735 (_initialize_cli_cmds): Call add_com for pipe_command.
7736 Define | as an alias for pipe.
7737 (exit_status_set_internal_vars): New function.
7738 (shell_escape): Call exit_status_set_internal_vars.
7739 cli/cli-decode.c (find_command_name_length): Recognize | as
7740 a single character command.
7742 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7744 * gdbcmd.h (execute_command_to_ui_file): New declaration.
7745 top.c (execute_command_to_ui_file): New function, mostly a copy
7746 of execute_command_to_string.
7747 (execute_command_to_string): Implement by calling
7748 execute_command_to_ui_file.
7750 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7752 * top.h (saved_command_line): Remove declaration.
7753 * top.c (previous_saved_command_line, previous_repeat_arguments):
7755 (saved_command_line): Make static, define together with other
7757 (dont_repeat): Clear repeat_arguments.
7758 (repeat_previous, get_saved_command_line, save_command_line):
7760 (gdb_init): Initialize saved_command_line
7761 and previous_saved_command_line.
7762 * main.c (captured_main_1): Remove saved_command_line initialization.
7763 * event-top.c (handle_line_of_input): Update to use
7764 the new 'repeat' related functions instead of direct access to
7766 * command.h (repeat_previous, get_saved_command_line,
7767 save_command_line): New declarations.
7768 (dont_repeat): Add comment.
7770 2019-05-30 Tom Tromey <tromey@adacore.com>
7772 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7774 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7776 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
7779 * completer.c (complete): Initialize variable word.
7781 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
7783 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7784 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7785 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7786 'body' is NULL to the outter 'if', protecting the '!is_define'
7789 2019-05-29 Tom Tromey <tromey@adacore.com>
7791 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7792 (dwarf_unknown): New function.
7793 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7794 (dwarf_type_encoding_name): Use dwarf_unknown.
7796 2019-05-29 Tom Tromey <tromey@adacore.com>
7799 * cp-valprint.c (cp_print_value_fields): Call
7800 cp_print_static_field inside "try".
7802 2019-05-29 Tom Tromey <tromey@adacore.com>
7804 * inflow.c (struct terminal_info): Add default operator=.
7805 * configure: Rebuild.
7806 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7807 -Wdeprecated-copy-dtor, -Wredundant-move.
7809 2019-05-29 Tom Tromey <tromey@adacore.com>
7812 * infcmd.c (print_return_value_1): Handle finish_print
7814 (show_print_finish): New function.
7815 (_initialize_infcmd): Add "set/show print finish" commands.
7816 * valprint.c (user_print_options): Initialize new member.
7817 * valprint.h (struct value_print_options) <finish_print>: New
7820 2019-05-28 Tom Tromey <tromey@adacore.com>
7822 * ada-lang.c (ada_remove_Xbn_suffix)
7823 (find_old_style_renaming_symbol)
7824 (parse_old_style_renaming): Remove.
7825 (ada_find_renaming_symbol): Don't call
7826 find_old_style_renaming_symbol.
7827 (ada_is_renaming_symbol): Rename from
7828 ada_find_renaming_symbol. Remove "block" parameter. Return
7830 (ada_read_var_value): Update and simplify.
7831 * ada-exp.y (write_var_or_type): Remove old code.
7833 2019-05-28 Alan Hayward <alan.hayward@arm.com>
7836 * event-top.c: Remove include comment.
7837 * inflow.c (class scoped_ignore_sigttou): Move from here...
7838 * inflow.h (class scoped_ignore_sigttou): ...to here.
7839 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7840 * top.c: Remove include comment.
7842 2019-05-27 Tom Tromey <tom@tromey.com>
7846 2019-05-22 Tom Tromey <tromey@adacore.com>
7848 * target.c (target_follow_exec): Constify parameter.
7849 * target-delegates.c: Rebuild.
7850 * remote.c (remote_target::follow_exec): Constify parameter.
7851 * infrun.c (follow_exec): Constify parameter.
7852 * target.h (struct target_ops) <follow_exec>: Constify parameter.
7853 (target_follow_exec): Likewise.
7855 2019-05-22 Alan Hayward <alan.hayward@arm.com>
7857 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7858 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7860 2019-05-22 Alan Hayward <alan.hayward@arm.com>
7862 * NEWS: Add debugredirect and testsuite sections.
7864 2019-05-22 Simon Cook <simon.cook@embecosm.com>
7866 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7867 target descriptions using exclusively floating point register name
7870 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
7873 * f-lang.c (build_fortran_types): Handle the case where
7874 gdbarch_floatformat_for_type returns a nullptr.
7876 2019-05-21 Tom de Vries <tdevries@suse.de>
7879 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7881 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
7884 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7886 * i386-tdep.c (i386_floatformat_for_type): Use
7887 floatformats_ia64_quad for the 16-byte floating point component
7888 within a fortran 32-byte complex number.
7890 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
7892 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7893 delete default constructor.
7894 (find_partial_die): Update to return const struct.
7895 (partial_die_parent_scope): Move variable declaration into scope
7896 of its use and change its type to auto.
7897 (guess_partial_die_structure_name): Likewise.
7898 (partial_die_info::fixup): Likewise.
7900 2019-05-17 Tom Tromey <tromey@adacore.com>
7902 * source.c (find_and_open_source): Remove cast.
7904 2019-05-17 Tom Tromey <tromey@adacore.com>
7906 * annotate.c (annotate_source): Make "filename" const.
7907 * annotate.h (annotate_source): Use const.
7909 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7911 * disasm.c (set_disassembler_options): Send errors to stderr.
7913 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7915 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7916 (cli_interp_base::set_logging): Check debug_redirect.
7917 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7918 * cli/cli-logging.c (debug_redirect): Add static variable.
7919 (pop_output_files): Add default param.
7920 (handle_redirections): Print debug setting.
7921 (show_logging_command): Likewise.
7922 (_initialize_cli_logging): Add debugredirect command.
7923 * interps.c (current_interp_set_logging): Add debug_redirect
7925 * interps.h (set_logging): Add debug_redirect parameter.
7926 (current_interp_set_logging): Likewise.
7927 * mi/mi-common.h: Likewise.
7928 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7930 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7931 Tom Tromey <tromey@adacore.com>
7933 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7935 * cli/cli-interp.h (make_logging_output): Remove declaration.
7936 * cli/cli-logging.c (make_logging_output): Remove function.
7937 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7939 * ui-file.c (tee_file::tee_file): Remove bools.
7940 (tee_file::~tee_file): Remove deletes.
7941 * ui-file.h (tee_file): Remove bools.
7943 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
7945 * mi/mi-cmds.h (mi_cmd_complete): New function.
7946 * mi/mi-main.c (mi_cmd_complete): Likewise.
7947 * mi/mi-cmds.c: Define new MI command -complete.
7948 * NEWS: Mention new -complete command.
7950 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
7952 * completer.h (complete): New function.
7953 * completer.c (complete): Likewise.
7954 * cli/cli-cmds.c: (complete_command): Update to use new complete()
7955 function defined in completer.h.
7957 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
7959 * MAINTAINERS (Write After Approval): Add myself.
7961 2019-05-17 Tom de Vries <tdevries@suse.de>
7964 * dwarf2read.c (struct cu_partial_die_info): New struct.
7965 (find_partial_die): Return cu_partial_die_info.
7966 (partial_die_parent_scope, guess_partial_die_structure_name)
7967 (partial_die_info::fixup): Handle new return type of find_partial_die.
7969 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7971 PR breakpoints/24541
7972 * stap-probe.c (stap_parse_register_operand): Make "regname" an
7973 "std::string", simplifying the algorithm.
7975 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7977 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7978 (stap_static_probe_ops::get_probes): Likewise.
7980 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7982 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7983 '-')" and "else if".
7984 (stap_parse_single_operand): Join checks for
7985 "gdbarch_stap_parse_special_token_p" and
7986 "gdbarch_stap_parse_special_token" in the same "if" statement.
7987 Invert check when verifying for operation on register
7990 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7992 * stap-probe.c (stap_get_opcode): Update comment.
7993 (stap_get_expected_argument_type): Likewise.
7994 (handle_stap_probe): Likewise.
7996 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7998 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7999 return type to 'bool'. Adjust comment. Use 'bool' when
8001 (i386_stap_parse_special_token_three_arg_disp): Likewise.
8002 * stap-probe.c (stap_parse_argument_1): Likewise.
8003 (stap_is_operator): Likewise.
8004 (stap_is_generic_prefix): Likewise.
8005 (stap_is_register_prefix): Likewise.
8006 (stap_is_register_indirection_prefix): Likewise.
8007 (stap_is_integer_prefix): Likewise.
8008 (stap_generic_check_suffix): Likewise.
8009 (stap_check_integer_suffix): Likewise.
8010 (stap_check_register_suffix): Likewise.
8011 (stap_check_register_indirection_suffix): Likewise.
8012 (stap_parse_register_operand): Likewise.
8013 (stap_parse_single_operand): Likewise.
8014 (stap_parse_argument_1): Likewise.
8015 (stap_probe::get_argument_count): Likewise.
8016 (stap_is_operator): Likewise.
8018 2019-05-16 Tom Tromey <tromey@adacore.com>
8020 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8023 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
8025 * linux-thread-db.c (try_thread_db_load_1): Change return type
8027 (try_thread_db_load): Likewise.
8028 (try_thread_db_load_from_pdir_1): Likewise.
8029 (try_thread_db_load_from_pdir): Likewise.
8030 (try_thread_db_load_from_sdir): Likewise.
8031 (try_thread_db_load_from_dir): Likewise.
8032 (thread_db_load_search): Likewise.
8033 (has_libpthread): Likewise.
8034 (thread_db_load): Likewise.
8036 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
8038 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8039 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8040 NULL, and complain/return if that's the case.
8042 2019-05-15 John Darrington <john@darrington.wattle.id.au>
8044 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8045 (advance, posn, abstract_read_memory): New functions.
8046 [struct mem_read_abstraction]: New struct.
8047 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8049 2019-05-14 Tom Tromey <tromey@adacore.com>
8051 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8052 value is not lval_memory.
8054 2019-05-14 Tom Tromey <tromey@adacore.com>
8056 * solib.c (info_sharedlibrary_command): Style the file name.
8058 2019-05-14 Alan Hayward <alan.hayward@arm.com>
8060 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8061 (aarch64_vnv_type): Likewise.
8062 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8063 * common/tdesc.c: Likewise.
8064 * common/tdesc.h (enum tdesc_type_kind): Likewise.
8065 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8066 * features/aarch64-fpu.xml: Add ieee half view.
8067 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8068 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8069 * gdbtypes.h (struct builtin_type): Likewise.
8070 (struct objfile_type): Likewise.
8072 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
8074 * language.c (language_sniff_from_mangled_name): Fix "langauge"
8076 * location.h (string_to_event_location): Likewise.
8078 2019-05-11 Joel Brobecker <brobecker@adacore.com>
8082 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
8084 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8085 New variable declaration.
8086 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8088 (print_one_breakpoint): Use ui_out::test_flags and new global
8089 variable to compute use_fixed_output.
8090 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8092 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8093 (mi_multi_location_breakpoint_output_fixed): Remove.
8094 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8096 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8097 fix_multi_location_breakpoint_output flag if version >= 3.
8098 * ui-out.h (enum ui_out_flag)
8099 <fix_multi_location_breakpoint_output>: New enumerator.
8101 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
8103 * contrib/cc-with-tweaks.sh: Validate dwz's work.
8105 2019-05-10 Tom Tromey <tromey@adacore.com>
8107 * ada-lang.c (catch_ada_completer): New function.
8108 (_initialize_ada_language): Use it.
8110 2019-05-10 Tom Tromey <tromey@adacore.com>
8112 * thread.c (print_thread_info): Make "requested_threads" const.
8113 * gdbthread.h (print_thread_info): Make "requested_threads"
8115 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8116 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8118 2019-05-08 Tom Tromey <tom@tromey.com>
8120 * gdbtypes.c (objfile_type_data): Change type.
8121 (objfile_type, _initialize_gdbtypes): Update.
8123 2019-05-08 Tom Tromey <tom@tromey.com>
8125 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8126 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8127 (_initialize_dwarf2_frame): Update.
8129 2019-05-08 Tom Tromey <tom@tromey.com>
8131 * objc-lang.c (objc_objfile_data): Change type.
8132 (find_methods): Update.
8133 (_initialize_objc_lang): Remove.
8135 2019-05-08 Tom Tromey <tom@tromey.com>
8137 * stabsread.c (rs6000_builtin_type_data): Change type.
8138 (rs6000_builtin_type, _initialize_stabsread): Update.
8140 2019-05-08 Tom Tromey <tom@tromey.com>
8142 * mips-tdep.c (mips_pdr_data): Remove.
8143 (_initialize_mips_tdep): Update.
8145 2019-05-08 Tom Tromey <tom@tromey.com>
8147 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8148 (hppa_init_objfile_priv_data, read_unwind_info)
8149 (find_unwind_entry, _initialize_hppa_tdep): Update.
8151 2019-05-08 Tom Tromey <tom@tromey.com>
8153 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8154 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
8156 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8158 2019-05-08 Tom Tromey <tom@tromey.com>
8160 * mdebugread.c (basic_type_data): Change type.
8161 (basic_type, _initialize_mdebugread): Update.
8163 2019-05-08 Tom Tromey <tom@tromey.com>
8165 * common/gdb_unique_ptr.h (struct noop_deleter): New.
8167 2019-05-08 Tom Tromey <tom@tromey.com>
8169 * nto-tdep.c (nto_inferior_data_reg): Change type.
8170 (nto_inferior_data): Update.
8171 (nto_inferior_data_cleanup, nto_new_inferior_data)
8172 (_initialize_nto_tdep): Remove.
8173 * nto-tdep.h (struct nto_inferior_data): Add initializers.
8175 2019-05-08 Tom Tromey <tom@tromey.com>
8177 * ada-lang.c (struct ada_inferior_data): Add initializers.
8178 (ada_inferior_data): Change type.
8179 (ada_inferior_data_cleanup): Remove.
8180 (get_ada_inferior_data, ada_inferior_exit)
8181 (struct ada_pspace_data): Add initializers, destructor.
8182 (ada_pspace_data_handle): Change type.
8183 (get_ada_pspace_data): Update.
8184 (ada_pspace_data_cleanup): Remove.
8186 2019-05-08 Tom Tromey <tom@tromey.com>
8188 * coffread.c (struct coff_symfile_info): Add initializers.
8189 (coff_objfile_data_key): Move lower. Change type.
8190 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8192 (coff_free_info): Remove.
8194 2019-05-08 Tom Tromey <tom@tromey.com>
8196 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8197 (fbsd_pspace_data_handle): Move lower. Change type.
8198 (get_fbsd_pspace_data): Update.
8199 (fbsd_pspace_data_cleanup): Remove.
8200 (_initialize_fbsd_tdep): Update.
8202 2019-05-08 Tom Tromey <tom@tromey.com>
8204 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8205 (get_ada_tasks_pspace_data): Update.
8206 (ada_tasks_pspace_data_cleanup): Remove.
8207 (_initialize_tasks): Update.
8208 (ada_tasks_inferior_data_handle): Change type.
8209 (get_ada_tasks_inferior_data): Update.
8210 (ada_tasks_inferior_data_cleanup): Remove.
8211 (struct ada_tasks_pspace_data): Add initializers.
8213 2019-05-08 Tom Tromey <tom@tromey.com>
8215 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8216 * symfile-debug.c (debug_sym_get_probes): Change type.
8217 * stap-probe.c (handle_stap_probe):
8218 (stap_static_probe_ops::get_probes): Change type.
8219 * probe.h (class static_probe_ops) <get_probes>: Change type.
8220 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8221 (parse_probes_in_pspace): Update.
8222 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8224 (any_static_probe_ops::get_probes): Change type.
8225 * elfread.c (elfread_data): New typedef.
8226 (probe_key): Change type.
8227 (elf_get_probes): Likewise. Update.
8228 (probe_key_free): Remove.
8229 (_initialize_elfread): Update.
8230 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8232 (dtrace_process_dof_probe, dtrace_process_dof)
8233 (dtrace_static_probe_ops::get_probe): Change type.
8235 2019-05-08 Tom Tromey <tom@tromey.com>
8237 * xcoffread.c (struct xcoff_symfile_info): Rename from
8238 coff_symfile_info. Add initializers.
8239 (xcoff_objfile_data_key): Move lower. Change type.
8240 (XCOFF_DATA): Rewrite.
8241 (xcoff_free_info): Remove.
8242 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8243 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8244 (xcoff_initial_scan): Update.
8246 2019-05-08 Tom Tromey <tom@tromey.com>
8248 * solib-svr4.c (struct svr4_info): Add initializers and
8250 <probes_table>: Now an htab_up.
8251 (solib_svr4_pspace_data): Change type.
8252 (free_probes_table): Simplify.
8253 (~svr4_info): Rename from svr4_pspace_data_cleanup.
8254 (get_svr4_info, probes_table_htab_remove_objfile_probes)
8255 (probes_table_remove_objfile_probes, register_solib_event_probe)
8256 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8257 (_initialize_svr4_solib): Update.
8259 2019-05-08 Tom Tromey <tom@tromey.com>
8261 * remote.c (remote_pspace_data): Change type.
8262 (remote_pspace_data_cleanup): Remove.
8263 (get_remote_exec_file, set_pspace_remote_exec_file)
8264 (_initialize_remote): Update.
8266 2019-05-08 Tom Tromey <tom@tromey.com>
8268 * breakpoint.c (breakpoint_objfile_key): Change type.
8269 (get_breakpoint_objfile_data): Update.
8270 (free_breakpoint_objfile_data): Remove.
8271 (_initialize_breakpoint): Update.
8273 2019-05-08 Tom Tromey <tom@tromey.com>
8275 * linux-tdep.c (struct linux_info): Add initializers.
8276 (linux_inferior_data): Move. Change type.
8277 (invalidate_linux_cache_inf): Update.
8278 (linux_inferior_data_cleanup): Remove.
8279 (get_linux_inferior_data, _initialize_linux_tdep): Update.
8281 2019-05-08 Tom Tromey <tom@tromey.com>
8283 * auxv.c (auxv_inferior_data): Move. Change type.
8284 (auxv_inferior_data_cleanup): Remove.
8285 (invalidate_auxv_cache_inf): Rewrite.
8286 (get_auxv_inferior_data, _initialize_auxv): Update.
8288 2019-05-08 Tom Tromey <tom@tromey.com>
8290 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8291 (symfile_debug_objfile_data_key): Change type.
8292 (symfile_debug_installed, debug_qf_has_symbols)
8293 (debug_qf_find_last_source_symtab)
8294 (debug_qf_forget_cached_source_info)
8295 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8296 (debug_qf_print_stats, debug_qf_dump)
8297 (debug_qf_expand_symtabs_for_function)
8298 (debug_qf_expand_all_symtabs)
8299 (debug_qf_expand_symtabs_with_fullname)
8300 (debug_qf_map_matching_symbols)
8301 (debug_qf_expand_symtabs_matching)
8302 (debug_qf_find_pc_sect_compunit_symtab)
8303 (debug_qf_map_symbol_filenames)
8304 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8305 (debug_sym_new_init, debug_sym_init, debug_sym_read)
8306 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8307 (debug_sym_read_linetable, debug_sym_relocate): Update.
8308 (symfile_debug_free_objfile): Remove.
8309 (install_symfile_debug_logging, _initialize_symfile_debug):
8312 2019-05-08 Tom Tromey <tom@tromey.com>
8314 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8315 allocate_on_obstack.
8316 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8317 (get_dwarf2_per_objfile): Update.
8318 (set_dwarf2_per_objfile): Remove.
8319 (dwarf2_has_info, dwarf2_get_section_info): Update.
8320 (dwarf2_free_objfile): Remove.
8321 (_initialize_dwarf2_read): Update.
8323 2019-05-08 Tom Tromey <tom@tromey.com>
8325 * auto-load.c (struct auto_load_pspace_info): Add destructor and
8327 <unsupported_script_warning_printed,
8328 script_not_found_warning_printed>: Now bool.
8329 (auto_load_pspace_data): Change type.
8330 (~auto_load_pspace_info): Rename from
8331 auto_load_pspace_data_cleanup.
8332 (get_auto_load_pspace_data, init_loaded_scripts_info)
8333 (clear_section_scripts, maybe_print_unsupported_script_warning)
8334 (maybe_print_script_not_found_warning, _initialize_auto_load):
8337 2019-05-08 Tom Tromey <tom@tromey.com>
8339 * objfiles.c (objfile_pspace_info): Add destructor and
8341 (objfiles_pspace_data): Change type.
8342 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8343 (get_objfile_pspace_data): Update.
8344 (objfiles_bfd_data): Change type.
8345 (get_objfile_bfd_data): Update.
8346 (objfile_bfd_data_free, _initialize_objfiles): Remove.
8348 2019-05-08 Tom Tromey <tom@tromey.com>
8350 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8352 (get_catch_syscall_inferior_data): Update.
8353 (catch_syscall_inferior_data_cleanup): Remove.
8354 (_initialize_break_catch_syscall): Update.
8356 2019-05-08 Tom Tromey <tom@tromey.com>
8358 * inflow.c (struct terminal_info): Add destructor and
8360 (inflow_inferior_data): Change type.
8361 (~terminal_info): Rename from inflow_inferior_data_cleanup.
8362 (get_inflow_inferior_data, inflow_inferior_exit)
8363 (swap_terminal_info, _initialize_inflow): Update.
8365 2019-05-08 Tom Tromey <tom@tromey.com>
8367 * target-dcache.c (target_dcache_cleanup): Remove.
8368 (target_dcache_aspace_key): Change type.
8369 (target_dcache_init_p, target_dcache_invalidate)
8370 (target_dcache_get, target_dcache_get_or_init)
8371 (_initialize_target_dcache): Update.
8372 * dcache.h (struct dcache_deleter): New.
8374 2019-05-08 Tom Tromey <tom@tromey.com>
8376 * symtab.c (struct symbol_cache): Add destructor and
8378 (symbol_cache_key): Move. Change type.
8379 (make_symbol_cache, free_symbol_cache): Remove.
8380 (get_symbol_cache): Update.
8381 (symbol_cache_cleanup): Remove.
8382 (ALL_PSPACES, symbol_cache_flush)
8383 (maintenance_print_symbol_cache)
8384 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8387 2019-05-08 Tom Tromey <tom@tromey.com>
8389 * symtab.c (struct main_info): Add destructor and initializers.
8390 (main_progspace_key): Move. Change type.
8391 (get_main_info): Update.
8392 (main_info_cleanup): Remove.
8393 (_initialize_symtab): Update.
8395 2019-05-08 Tom Tromey <tom@tromey.com>
8397 * registry.h (DECLARE_REGISTRY): Define the _key class.
8399 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
8401 * NEWS: Merge two 'New commands' sections.
8403 2019-05-08 Joel Brobecker <brobecker@adacore.com>
8405 * ada-valprint.c (ada_val_print_gnat_array): Remove language
8406 parameter and use Ada language definition instead.
8407 (ada_val_print_ptr): Remove unused language parameter.
8408 (ada_val_print_num): Remove language parameter and use Ada language
8410 (ada_val_print_enum, ada_val_print_flt): Remove unused language
8412 (ada_val_print_struct_union, ada_val_print_ref): Remove language
8413 parameter and use Ada language definition instead.
8414 (ada_val_print_1): Update all ada_val_print_xxx calls.
8415 Remove language parameter.
8416 (ada_val_print): Update ada_val_print_1 call.
8418 2019-05-08 Tom Tromey <tromey@adacore.com>
8420 * remote.c (remote_hw_watchpoint_limit)
8421 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8424 2019-05-08 Tom Tromey <tromey@adacore.com>
8426 * maint.c (_initialize_maint_cmds): Move initialization code to
8428 (watchdog, show_watchdog): Move to remote.c.
8429 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
8431 (_initialize_remote): Move initialization code from maint.c.
8432 * defs.h (watchdog): Don't declare.
8434 2019-05-08 Tom Tromey <tromey@adacore.com>
8436 * tui/tui-interp.c: Include main.h.
8437 * interps.c: Include main.h.
8438 * main.h (interpreter_p): Declare.
8439 * defs.h (interpreter_p): Don't declare.
8441 2019-05-08 Tom Tromey <tromey@adacore.com>
8443 * dwarf2loc.c: Include dwarf2read.h.
8444 * defs.h (read_unsigned_leb128): Don't declare.
8445 * dwarf2read.h (read_unsigned_leb128): Declare.
8447 2019-05-08 Tom Tromey <tromey@adacore.com>
8449 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8452 2019-05-08 Tom Tromey <tromey@adacore.com>
8454 * utils.c (fputs_maybe_filtered): Reset style after paging, even
8455 when no wrap column is set.
8457 2019-05-08 Tom Tromey <tromey@adacore.com>
8459 * c-lang.c (c_get_string): Handle non-C-style arrays.
8461 2019-05-08 Tom Tromey <tromey@adacore.com>
8463 * typeprint.c (print_offset_data::update): Print the bit offset,
8464 not the number of bits remaining.
8466 2019-05-08 Tom Tromey <tromey@adacore.com>
8468 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8469 padding at end of comment.
8471 2019-05-08 Tom Tromey <tromey@adacore.com>
8473 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8476 2019-05-06 Tom Tromey <tom@tromey.com>
8478 * common/scoped_mmap.c: Include common-defs.h.
8479 * common/scoped_mmap.h: Don't include config.h.
8481 2019-05-04 Tom Tromey <tom@tromey.com>
8483 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8484 (struct aarch64_call_info): Add initializers.
8485 <si>: Now a std::vector.
8486 (pass_on_stack, aarch64_push_dummy_call): Update.
8488 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
8489 Tom Tromey <tom@tromey.com>
8491 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8492 (ppc_threads): Now a std::vector. Now static.
8493 (hwdebug_find_thread_points_by_tid)
8494 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8497 2019-05-04 Tom Tromey <tom@tromey.com>
8499 * arc-tdep.c (arc_tdesc_init): Return bool.
8501 2019-05-04 Tom Tromey <tom@tromey.com>
8503 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8504 Use gdb_assert_not_reached.
8506 2019-05-04 Tom Tromey <tom@tromey.com>
8508 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8511 2019-05-04 Tom Tromey <tom@tromey.com>
8513 * arc-tdep.c (arc_tdesc_init): Use bool.
8515 2019-05-04 Tom Tromey <tom@tromey.com>
8517 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8519 2019-05-04 Tom Tromey <tom@tromey.com>
8521 * cli/cli-cmds.c (valid_command_p): Return bool.
8523 2019-05-04 Tom Tromey <tom@tromey.com>
8525 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8526 * command.h (valid_user_defined_cmd_name_p): Channge return type.
8528 2019-05-04 Raul Tambre <raul@tambre.ee>
8530 * python/lib/gdb/prompt.py (_ExtendedPrompt)
8531 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8532 operator for comparison.
8534 2019-05-04 Tom Tromey <tom@tromey.com>
8536 * psymtab.c (psymbol_name_matches, match_partial_symbol)
8537 (lookup_partial_symbol, print_partial_symbols)
8538 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8539 (psymbol_compare): Update.
8540 (add_psymbol_to_bcache): Clear the entire psymbol.
8541 (maintenance_check_psymtabs): Update.
8542 * psympriv.h (struct partial_symbol): Don't derive from
8543 general_symbol_info.
8544 <obj_section, unrelocated_address, address,
8545 set_unrelocated_address>: Update.
8546 <ginfo>: New member.
8547 * dwarf-index-write.c (write_psymbols, debug_names::insert)
8548 (debug_names::write_psymbols): Update.
8550 2019-05-04 Tom de Vries <tdevries@suse.de>
8552 * contrib/cc-with-tweaks.sh: Support -n arg.
8554 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8556 * corelow.c (core_target::detach): Ensure frame cache and
8557 register caches are cleared.
8558 inferior.c (exit_inferior_1): Likewise.
8560 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
8561 Tom Tromey <tom@tromey.com>
8563 * dictionary.c (collate_pending_symbols_by_language): Remove
8564 "struct" from foreach.
8565 * symtab.c (lookup_global_symbol_from_objfile)
8566 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8568 * ser-tcp.c (net_open): Remove "struct" from foreach.
8569 * objfiles.c (objfile_relocate, objfile_rebase)
8570 (objfile_has_symbols): Remove "struct" from foreach.
8571 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8573 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8575 * darwin-nat.c (thread_info_from_private_thread_info): Remove
8576 "struct" from foreach.
8577 * ada-lang.c (create_excep_cond_exprs)
8578 (ada_exception_catchpoint_cond_string): Remove "struct" from
8581 2019-05-03 Tom Tromey <tromey@adacore.com>
8583 * ada-exp.y (convert_char_literal): Check suffix of each
8586 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
8589 * ada-exp.y (yywrap): Don't define.
8590 * ada-lex.l (%option): Add noyywrap
8593 2019-05-03 Eli Zaretskii <eliz@gnu.org>
8595 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8596 _WIN32_WINNT to the XP level, unless already defined to a higher
8599 * unittests/parse-connection-spec-selftests.c:
8601 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
8604 * symfile.c (find_separate_debug_file): Remove colon from the
8605 drive spec of DOS/Windows file names of the target, so that the
8606 file name produced from DEBUGDIR and the target's directory will
8607 be valid on DOS/Windows systems.
8609 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
8611 * rust-lang.c (val_print_struct): Handle printing structures
8614 2019-05-02 Tom Tromey <tromey@adacore.com>
8616 * valarith.c (_initialize_valarith): Remove.
8618 2019-05-01 Tom Tromey <tromey@adacore.com>
8620 * ada-lang.c (ada_value_primitive_field): Treat more fields as
8623 2019-05-01 Tom Tromey <tromey@adacore.com>
8625 * ada-lang.c (ada_value_assign): Correctly compute starting offset
8626 for big-endian copies.
8628 2019-04-30 Ali Tamur <tamur@google.com>
8629 * gdb/dwarf2read.c (read_3_bytes): New declaration.
8630 (read_attribute_value): Added DW_FORM_strx1-4 cases.
8631 (read_3_bytes): New function.
8633 2019-04-30 Joel Brobecker <brobecker@adacore.com>
8635 * windows-nat.c (main_thread_id): Delete.
8636 (handle_output_debug_string): Replace main_thread_id by
8637 current_event.dwThreadId.
8638 (fake_create_process): Likewise.
8639 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8640 Do not set main_thread_id.
8641 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8642 current_event.dwThreadId.
8643 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8645 2019-04-30 Joel Brobecker <brobecker@adacore.com>
8647 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8648 Use current_event.dwThreadId instead of main_thread_id.
8650 2019-04-30 Tom Tromey <tromey@adacore.com>
8652 * ada-lang.c (ada_lookup_simple_minsyms): New function.
8653 (create_excep_cond_exprs): Iterate over program spaces.
8654 (ada_exception_catchpoint_cond_string): Examine all minimal
8655 symbols for exception types.
8657 2019-04-30 Tom Tromey <tromey@adacore.com>
8660 * dwarf2read.c (process_structure_scope): Handle case where type
8661 has template parameters but no symbol was created.
8663 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8664 Chris January <chris.january@arm.com>
8666 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8668 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8670 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8672 * f-typeprint.c (f_print_type): Update rules for printing
8674 (f_type_print_varspec_suffix): Likewise.
8676 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8677 Chris January <chris.january@arm.com>
8679 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8682 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8684 * f-lang.c (build_fortran_types): Change name of void type to
8686 * f-typeprint.c (f_type_print_base): Print the name of the void
8687 type, rather than a fixed string.
8688 * f-valprint.c (f_decorations): Use lower case void string.
8690 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8691 Chris January <chris.january@arm.com>
8693 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8696 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8697 Chris January <chris.january@arm.com>
8698 David Lecomber <david.lecomber@arm.com>
8700 * f-exp.y (BINOP_INTRINSIC): New token.
8701 (exp): New parser rule handling BINOP_INTRINSIC.
8702 (f77_keywords): Add new builtin procedures.
8703 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8704 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8705 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8706 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8707 (print_unop_subexp_f): New function.
8708 (print_binop_subexp_f): New function.
8709 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8710 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8711 (dump_subexp_body_f): Likewise.
8712 (operator_check_f): Likewise.
8713 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8714 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8716 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8718 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8720 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8721 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8722 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8723 (operator_length_f): New fuction.
8724 (print_subexp_f): New function.
8725 (op_name_f): New function.
8726 (dump_subexp_body_f): New function.
8727 (operator_check_f): New function.
8728 (exp_descriptor_f): Replace standard expression handling functions
8730 * gdb/fortran-operator.def: New file.
8731 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8732 * gdb/std-operator.def: Remove UNOP_KIND.
8734 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8736 * std-operator.def: Remove unbalanced, stray double quote
8739 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8740 Chris January <chris.january@arm.com>
8741 Daniel Everett <daniel.everett@arm.com>
8742 Nick Forrington <nick.forrington@arm.com>
8743 Richard Bunt <richard.bunt@arm.com>
8745 * cp-valprint.c (cp_print_value_fields): Allow an additional level
8746 of depth when printing anonymous structs or unions.
8747 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8748 Don't print either the top-level value, or the children if the
8749 max-depth is exceeded.
8750 (ppscm_print_children): When printing the key of a map, allow one
8751 extra level of depth.
8752 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8753 print either the top-level value, or the children if the max-depth
8755 (print_children): When printing the key of a map, allow one extra
8757 * python/py-value.c (valpy_format_string): Add max_depth keyword.
8758 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8759 (user_print_options): Initialise max_depth field.
8760 (val_print_scalar_or_string_type_p): New function.
8761 (val_print): Check to see if the max depth has been reached.
8762 (val_print_check_max_depth): Define new function.
8763 (show_print_max_depth): New function.
8764 (_initialize_valprint): Add 'print max-depth' option.
8765 * valprint.h (struct value_print_options) <max_depth>: New field.
8766 (val_print_check_max_depth): Declare new function.
8767 * NEWS: Document new feature.
8769 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8771 * ada-lang.c (ada_language_defn): Initialise new field.
8772 * c-lang.c (c_is_string_type_p): New function.
8773 (c_language_defn): Initialise new field.
8774 (cplus_language_defn): Initialise new field.
8775 (asm_language_defn): Initialise new field.
8776 (minimal_language_defn): Initialise new field.
8777 * c-lang.h (c_is_string_type_p): Declare new function.
8778 * d-lang.c (d_language_defn): Initialise new field.
8779 * f-lang.c (f_is_string_type_p): New function.
8780 (f_language_defn): Initialise new field.
8781 * go-lang.c (go_is_string_type_p): New function.
8782 (go_language_defn): Initialise new field.
8783 * language.c (default_is_string_type_p): New function.
8784 (unknown_language_defn): Initialise new field.
8785 (auto_language_defn): Initialise new field.
8786 * language.h (struct language_defn) <la_is_string_type_p>: New
8788 (default_is_string_type_p): Declare new function.
8789 * m2-lang.c (m2_language_defn): Initialise new field.
8790 * objc-lang.c (objc_language_defn): Initialise new field.
8791 * opencl-lang.c (opencl_language_defn): Initialise new field.
8792 * p-lang.c (pascal_is_string_type_p): New function.
8793 (pascal_language_defn): Initialise new field.
8794 * rust-lang.c (rust_is_string_type_p): New function.
8795 (rust_language_defn): Initialise new field.
8797 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8799 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8801 * ada-lang.c (ada_language_defn): Initialise new field.
8802 * c-lang.c (c_language_defn): Likewise.
8803 (cplus_language_defn): Likewise.
8804 (asm_language_defn): Likewise.
8805 (minimal_language_defn): Likewise.
8806 * d-lang.c (d_language_defn): Likewise.
8807 * f-lang.c (f_language_defn): Likewise.
8808 * go-lang.c (go_language_defn): Likewise.
8809 * language.c (unknown_language_defn): Likewise.
8810 (auto_language_defn): Likewise.
8811 * m2-lang.c (m2_language_defn): Likewise.
8812 * objc-lang.c (objc_language_defn): Likewise.
8813 * opencl-lang.c (opencl_language_defn): Likewise.
8814 * p-lang.c (pascal_language_defn): Likewise.
8815 * rust-lang.c (rust_language_defn): Likewise.
8817 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8819 * ada-lang.c (ada_is_character_type): Change return type to bool.
8820 (ada_is_string_type): Likewise.
8821 * ada-lang.h (ada_is_character_type): Update declaration
8822 (ada_is_string_type): Likewise.
8824 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8826 Support style in 'frame|thread apply'
8828 * gdbcmd.h (execute_command_to_string): New term_out parameter.
8829 * record.c (record_start, record_stop): Update callers of
8830 execute_command_to_string with false.
8831 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8832 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8834 (class string_file): New constructor with term_out parameter.
8835 Override methods term_out and can_emit_style_escape. New member
8837 (class stdio_file): Override can_emit_style_escape.
8838 (class tee_file): Override term_out and can_emit_style_escape.
8839 * utils.h (can_emit_style_escape): Remove.
8840 * utils.c (can_emit_style_escape): Likewise.
8841 Update all callers of can_emit_style_escape (SOMESTREAM) to
8842 SOMESTREAM->can_emit_style_escape.
8843 * source-cache.c (source_cache::get_source_lines): Likewise.
8844 * stack.c (frame_apply_command_count): Call execute_command_to_string
8845 passing the term_out characteristic of the current gdb_stdout.
8846 * thread.c (thr_try_catch_cmd): Likewise.
8847 * top.c (execute_command_to_string): pass term_out parameter
8848 to construct the string_file for the command output.
8849 * ui-file.c (term_cli_styling): New function (most code moved
8850 from utils.c can_emit_style_escape).
8851 (string_file::string_file, string_file::can_emit_style_escape,
8852 stdio_file::can_emit_style_escape, tee_file::term_out,
8853 tee_file::can_emit_style_escape): New functions.
8855 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8857 * NEWS: Mention the new set|show may-call-functions.
8858 * infcall.c (may_call_functions_p): New variable.
8859 (show_may_call_functions_p): New function.
8860 (call_function_by_hand_dummy): Throws an error if not
8862 (_initialize_infcall): Call add_setshow_boolean_cmd for
8865 2019-04-25 Keith Seitz <keiths@redhat.com>
8868 * cp-support.c (inspect_type): Don't attempt substitutions
8869 of symbol with the same name.
8871 2019-04-25 Tom Tromey <tromey@adacore.com>
8874 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8877 2019-04-25 Tom Tromey <tromey@adacore.com>
8879 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8881 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8882 (gdb_xml_parser::parse): Use std::move.
8883 * python/python-internal.h (gdbpy_convert_exception): Take a const
8885 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8887 * python/py-utils.c (gdbpy_convert_exception): Take a const
8889 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8891 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8893 * mi/mi-main.c (mi_print_exception): Take a const reference.
8894 * main.c (handle_command_errors): Take a const reference.
8895 * linespec.c (parse_linespec): Use std::move.
8896 * infcall.c (run_inferior_call): Use std::move.
8897 (call_function_by_hand_dummy): Use std::move.
8898 * exec.c (try_open_exec_file): Use std::move.
8899 * exceptions.h (exception_print, exception_fprintf)
8900 (exception_print_same): Update.
8901 * exceptions.c (print_exception, exception_print)
8902 (exception_fprintf, exception_print_same): Change parameters to
8904 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8905 * common/new-op.c: Use std::move.
8906 * common/common-exceptions.h (struct gdb_exception): Add move
8908 (struct gdb_exception_error, struct gdb_exception_quit, struct
8909 gdb_quit_bad_alloc): Change constructor to move constructor.
8910 (throw_exception): Change parameter to rvalue reference.
8911 * common/common-exceptions.c (throw_exception): Take rvalue
8913 * cli/cli-interp.c (safe_execute_command): Use std::move.
8914 * breakpoint.c (insert_bp_location, location_to_sals): Use
8917 2019-04-25 Tom Tromey <tromey@adacore.com>
8919 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8920 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8921 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8922 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8923 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8924 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8925 guile/scm-value.c: Use unpack.
8926 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8927 gdbscm_gdb_exception.
8928 (gdbscm_throw_gdb_exception): Likewise.
8929 (struct gdbscm_gdb_exception): New.
8930 (unpack): New function.
8931 (gdbscm_wrap): Use unpack.
8933 2019-04-25 Tom Tromey <tromey@adacore.com>
8935 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8936 (gdb_rl_callback_handler): Use std::move.
8937 * common/common-exceptions.h (struct gdb_exception): Add move
8938 assignment operator.
8939 (throw_exception_sjlj): Change "exception" to const reference.
8940 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8941 (throw_exception_sjlj): Change "exception" to const reference.
8943 2019-04-25 Tom Tromey <tromey@adacore.com>
8945 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8946 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8947 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8949 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8951 * mi/mi-interp.c (mi_interp::exec): Update.
8952 * linespec.c (parse_linespec): Update.
8953 * infcall.c (run_inferior_call): Update.
8954 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8955 * guile/scm-symbol.c (gdbscm_lookup_symbol)
8956 (gdbscm_lookup_global_symbol): Update.
8957 * guile/scm-param.c (gdbscm_parameter_value): Update.
8958 * guile/scm-frame.c (gdbscm_frame_read_register)
8959 (gdbscm_frame_read_var): Update.
8960 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8961 * exec.c (try_open_exec_file): Update.
8962 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8963 (gdb_rl_callback_handler): Update.
8964 * common/common-exceptions.h (exception_none): Don't declare.
8965 * common/common-exceptions.c (exception_none): Don't define.
8966 (struct catcher) <exception>: Update.
8967 * cli/cli-interp.c (safe_execute_command): Update.
8968 * breakpoint.c (insert_bp_location, location_to_sals): Update.
8970 2019-04-25 Ali Tamur <tamur@google.com>
8972 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8973 (read_attribute_value): Likewise.
8974 (dwarf2_read_addr_index): Update comment.
8975 (read_str_index): Add DW_FORM_strx.
8976 (dwarf2_string_attr): Likewise.
8977 (dwarf2_const_value_attr): Likewise.
8978 (dump_die_shallow): Likewise.
8979 (dwarf2_fetch_constant_bytes): Likewise.
8980 (skip_form_bytes): Likewise.
8981 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8983 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
8987 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8988 OFFSET. Verify if current mapping contains an ELF header.
8989 (linux_find_memory_regions_full): Adjust call to
8992 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
8993 Kang Li <kanglictf@gmail.com>
8997 * dwarf2-frame.c (read_initial_length): Be consistent about using
8998 unsigned representation of length.
8999 (decode_frame_entry_1): Likewise. Check for wraparound of
9000 end pointer as well as buffer overflow.
9002 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
9004 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9007 2019-04-24 Tom Tromey <tromey@adacore.com>
9009 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9011 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9013 * s12z-tdep.c (s12z_unwind_pc): Delete.
9014 (s12z_unwind_sp): Delete.
9015 (s12z_gdbarch_init): Don't register deleted functions with
9018 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9020 * rl78-tdep.c (rl78_unwind_sp): Delete.
9021 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9023 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9025 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9026 (xstormy16_unwind_pc): Delete.
9027 (xstormy16_dummy_id): Delete.
9028 (xstormy16_gdbarch_init): Don't register deleted functions with
9031 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9033 * vax-tdep.c (vax_unwind_pc): Delete.
9034 (vax_gdbarch_init): Don't register deleted function with gdbarch.
9036 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9038 * v850-tdep.c (v850_unwind_sp): Delete.
9039 (v850_unwind_pc): Delete.
9040 (v850_dummy_id): Delete.
9041 (v850_gdbarch_init): Don't register deleted functions with
9044 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9046 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9047 (tilegx_unwind_pc): Delete.
9048 (tilegx_unwind_dummy_id): Delete.
9049 (tilegx_gdbarch_init): Don't register deleted functions with
9052 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9054 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9055 (tic6x_dummy_id): Delete.
9056 (tic6x_gdbarch_init): Don't register deleted functions with
9059 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9061 * sparc-tdep.c (sparc_unwind_pc): Delete.
9062 (sparc32_gdbarch_init): Don't register deleted function with
9065 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9067 * sh-tdep.c (sh_unwind_sp): Delete.
9068 (sh_unwind_pc): Delete.
9069 (sh_dummy_id): Delete.
9070 (sh_gdbarch_init): Don't register deleted functions with
9073 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9075 * score-tdep.c (score_unwind_sp): Delete.
9076 (score_unwind_pc): Delete.
9077 (score_dummy_id): Delete.
9078 (score_gdbarch_init): Don't register deleted functions with
9081 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9083 * rx-tdep.c (rx_unwind_pc): Delete.
9084 (rx_unwind_sp): Delete.
9085 (rx_dummy_id): Delete.
9086 (rx_gdbarch_init): Don't register deleted functions with
9087 gdbarch. Update comment.
9089 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9091 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9092 (rs6000_dummy_id): Delete.
9093 (rs6000_gdbarch_init): Don't register deleted functions with
9096 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9098 * or1k-tdep.c (or1k_dummy_id): Delete.
9099 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9101 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9103 * nios2-tdep.c (nios2_dummy_id): Delete.
9104 (nios2_unwind_sp): Delete.
9105 (nios2_gdbarch_init): Don't register deleted functions with
9108 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9110 * nds32-tdep.c (nds32_dummy_id): Delete.
9111 (nds32_unwind_pc): Delete.
9112 (nds32_unwind_sp): Delete.
9113 (nds32_gdbarch_init): Don't register deleted functions with
9116 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9118 * msp430-tdep.c (msp430_unwind_pc): Delete.
9119 (msp430_unwind_sp): Delete.
9120 (msp430_dummy_id): Delete.
9121 (msp430_gdbarch_init): Don't register deleted functions with
9124 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9126 * moxie-tdep.c (moxie_unwind_sp): Delete.
9127 (moxie_unwind_pc): Delete.
9128 (moxie_dummy_id): Delete.
9129 (moxie_gdbarch_init): Don't register deleted functions with
9132 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9134 * mn10300-tdep.c (mn10300_dummy_id): Delete.
9135 (mn10300_unwind_pc): Delete.
9136 (mn10300_unwind_sp): Delete.
9137 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9139 (mn10300_frame_unwind_init): Don't register deleted functions with
9142 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9144 * mep-tdep.c (mep_unwind_pc): Delete.
9145 (mep_unwind_sp): Delete.
9146 (mep_dummy_id): Delete.
9147 (mep_gdbarch_init): Don't register deleted functions with
9150 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9152 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9153 (m68hc11_unwind_sp): Delete.
9154 (m68hc11_gdbarch_init): Don't register deleted functions with
9157 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9159 * m32r-tdep.c (m32r_unwind_sp): Delete.
9160 (m32r_unwind_pc): Delete.
9161 (m32r_dummy_id): Delete.
9162 (m32r_gdbarch_init): Don't register deleted functions with
9165 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9167 * m32c-tdep.c (m32c_unwind_pc): Delete.
9168 (m32c_unwind_sp): Delete.
9169 (m32c_dummy_id): Delete.
9170 (m32c_gdbarch_init): Don't register deleted functions with
9173 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9175 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9176 (lm32_unwind_pc): Delete.
9177 (lm32_dummy_id): Delete.
9178 (lm32_gdbarch_init): Don't register deleted functions with
9181 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9183 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9184 (iq2000_unwind_pc): Delete.
9185 (iq2000_dummy_id): Delete.
9186 (iq2000_gdbarch_init): Don't register deleted functions with
9189 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9191 * nds32-tdep.c (nds32_type_align): Delete.
9192 (nds32_push_dummy_call): Use type_align instead.
9194 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9196 * arm-tdep.c (arm_type_align): Only handle vector override case.
9197 (arm_push_dummy_call): Use type_align.
9198 (arm_gdbarch_init): Register arm_type_align gdbarch function.
9200 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9202 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9204 (pass_on_stack): Use type_align.
9205 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9208 2019-04-23 Tom Tromey <tromey@adacore.com>
9210 * dwarf2read.c (line_header::file_name_at): Remove unused
9213 2019-04-23 Tom de Vries <tdevries@suse.de>
9216 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9220 2019-03-27 Ali Tamur <tamur@google.com>
9222 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9223 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9224 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9225 (dwarf_expr_context::get_addr_index): Likewise
9226 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9227 (symbol_needs_eval_context::get_addr_index): Likewise
9228 (disassemble_dwarf_expression): Add DW_OP_addrx
9229 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9230 (read_cutu_die_from_dwo): Update comment
9231 (skip_one_die): Add DW_FORM_addrx
9232 (read_attribute_value): Likewise
9233 (var_decode_location): Add DW_OP_addrx
9234 (dwarf2_const_value_attr): Add DW_FORM_addrx
9235 (dump_die_shallow): Likewise
9236 (dwarf2_fetch_constant_bytes): Likewise
9237 (decode_locdesc): Add DW_OP_addrx
9238 (skip_form_bytes): Add DW_FORM_addrx
9240 2019-04-22 Ali Tamur <tamur@google.com>
9242 * MAINTAINERS (Write After Approval): Add self.
9244 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
9246 * solib-svr4.c (get_svr4_info): Add pspace parameter.
9247 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9248 (open_symbol_file_object): Likewise.
9249 (svr4_default_sos): Add info parameter.
9250 (svr4_read_so_list): Likewise.
9251 (svr4_current_sos_direct): Adjust functions calls to pass down
9253 (svr4_current_sos_1): Add info parameter.
9254 (svr4_current_sos): Call get_svr4_info, pass info down to
9256 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9258 (svr4_in_dynsym_resolve_code): Pass current_program_space to
9260 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9262 (probes_table_remove_objfile_probes): Likewise.
9263 (register_solib_event_probe): Add info parameter.
9264 (solist_update_incremental): Pass info parameter down to
9266 (disable_probes_interface): Add info parameter.
9267 (svr4_handle_solib_event): Pass current_program_space to
9268 get_svr4_info. Adjust disable_probes_interface cleanup.
9269 (svr4_create_probe_breakpoints): Add info parameter, pass it
9270 down to register_solib_event_probe.
9271 (svr4_create_solib_event_breakpoints): Add info parameter,
9272 pass it down to svr4_create_probe_breakpoints.
9273 (enable_break): Pass info down to
9274 svr4_create_solib_event_breakpoints.
9275 (svr4_solib_create_inferior_hook): Pass current_program_space to
9277 (svr4_clear_solib): Likewise.
9279 2019-04-22 Pedro Alves <palves@redhat.com>
9281 * solib-svr4.c (svr4_free_objfile_observer): New.
9282 (probe_and_action::objfile): New field.
9283 (probes_table_htab_remove_objfile_probes)
9284 (probes_table_remove_objfile_probes): New functions.
9285 (register_solib_event_probe): Add 'objfile' parameter. Store it
9286 in the new probe_and_action. Don't store the probe in 'lookup'.
9287 (svr4_create_probe_breakpoints): Pass objfile to
9288 register_solib_event_probe.
9289 (_initialize_svr4_solib): Register a free_objfile observer.
9291 2019-04-19 Tom Tromey <tom@tromey.com>
9293 * common/queue.h: Remove.
9295 2019-04-19 Tom Tromey <tom@tromey.com>
9297 * event-loop.c: Don't include "common/queue.h".
9299 2019-04-19 Tom Tromey <tom@tromey.com>
9301 * remote.c (remote_target): Use delete.
9302 * remote-notif.h: Include <list>, not "common/queue.h".
9303 (notif_client_p): Remove typedef.
9304 (remote_notif_state): Add constructor, destructor, initializer.
9305 <notif_queue>: Now a std::list.
9306 (remote_notif_state_xfree): Don't declare.
9307 * remote-notif.c (remote_notif_process, handle_notification)
9308 (remote_notif_state_allocate): Update.
9309 (~remote_notif_state): Rename from remote_notif_state_xfree.
9311 2019-04-19 Tom Tromey <tom@tromey.com>
9313 * symfile.c (reread_symbols): Update.
9314 * objfiles.c (objfile_register_static_link)
9315 (objfile_lookup_static_link): Update
9316 (~objfile) Don't delete static_links.
9317 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9319 2019-04-19 Tom Tromey <tom@tromey.com>
9321 * type-stack.h (struct type_stack) <insert>: Constify string.
9322 * type-stack.c (type_stack::insert): Constify string.
9323 * gdbtypes.h (lookup_template_type): Update.
9324 (address_space_name_to_int): Update.
9325 * gdbtypes.c (address_space_name_to_int): Make space_identifier
9327 (lookup_template_type): Make name const.
9328 * c-exp.y: Update rules.
9329 (lex_one_token, classify_name, classify_inner_name)
9330 (c_print_token): Update.
9331 * p-exp.y: Update rules.
9333 * f-exp.y: Update rules.
9335 * d-exp.y: Update rules.
9336 (lex_one_token, classify_name, classify_inner_name): Update.
9337 * parse.c (write_dollar_variable, copy_name): Return std::string.
9338 * parser-defs.h (copy_name): Change return type.
9339 * m2-exp.y: Update rules.
9341 * go-exp.y (lex_one_token): Update.
9343 (classify_unsafe_function, classify_packaged_name)
9344 (classify_name, yylex): Update.
9346 2019-04-19 Sergei Trofimovich <siarheit@google.com>
9348 * configure.ac: add --enable-source-highlight switch.
9349 * configure: Regenerate.
9350 * top.c (print_gdb_version): plumb --enable-source-highlight
9351 status to "show configuration".
9353 2019-04-19 Tom Tromey <tromey@adacore.com>
9355 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9357 (empty_record, ada_template_to_fixed_record_type_1)
9358 (template_to_static_fixed_type)
9359 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9360 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9361 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9364 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
9367 * source.c (print_source_lines_base): Advance "iter" when a
9368 control character is seen.
9370 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9372 * inferior.h (struct infcall_suspend_state_deleter):
9373 Catch exception in destructor to avoid crash.
9375 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9377 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9378 close to the add_com "shell".
9380 2019-04-18 Tom Tromey <tromey@adacore.com>
9382 * process-stratum-target.h (class process_stratum_target)
9383 <stratum>: Add "final".
9385 2019-04-17 Tom Tromey <tromey@adacore.com>
9387 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9388 against nullptr before use.
9390 2019-04-17 Alan Hayward <alan.hayward@arm.com>
9392 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9394 2019-04-17 Jim Wilson <jimw@sifive.com>
9395 Andrew Burgess <andrew.burgess@embecosm.com>
9397 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9398 code read might fail, assume 4-byte breakpoint in that case.
9400 2019-04-15 Leszek Swirski <leszeks@google.com>
9402 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9403 rather than a hand-rolled POD check when checking for forced MEMORY
9406 2019-04-15 Alan Hayward <alan.hayward@arm.com>
9408 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9409 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9411 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9412 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9413 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9416 2019-04-15 Alan Hayward <alan.hayward@arm.com>
9418 * aarch64-linux-nat.c
9419 (aarch64_linux_nat_target::thread_architecture): Add override.
9420 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9423 2019-04-15 Alan Hayward <alan.hayward@arm.com>
9425 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9427 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
9429 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9430 target types of size 96-bits, add some additional comments, and
9431 check that the builtin type we found was the correct size.
9433 2019-04-12 Eli Zaretskii <eliz@gnu.org>
9435 * utils.c (prompt_for_continue): Don't restore the styling at the
9436 end, as applied_style has the wrong value. This fixes styling in
9437 long lists of file names that are interrupted by the "Continue?"
9440 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
9442 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9443 * c-lang.c (c_language_defn): Likewise.
9444 (cplus_language_defn): Likewise.
9445 (asm_language_defn): Likewise.
9446 (minimal_language_defn): Likewise.
9447 * d-lang.c (d_language_defn): Likewise.
9448 * f-lang.c (f_language_defn): Likewise.
9449 * go-lang.c (go_language_defn): Likewise.
9450 * language.c (unknown_language_defn): Likewise.
9451 (auto_language_defn): Likewise.
9452 * language.h (struct language_defn): Remove la_magic field.
9453 (LANG_MAGIC): Delete.
9454 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9455 * objc-lang.c (objc_language_defn): Likewise.
9456 * opencl-lang.c (opencl_language_defn): Likewise.
9457 * p-lang.c (pascal_language_defn): Likewise.
9458 * rust-lang.c (rust_language_defn): Likewise.
9460 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
9462 * riscv-tdep.c (riscv_type_align): New function.
9463 (riscv_type_alignment): Delete.
9464 (riscv_arg_location): Use 'type_align'.
9465 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9467 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
9469 * gdbtypes.c (type_align): A struct with no non-static fields also
9472 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
9474 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9476 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9478 (riscv_struct_info::analyse): New implementation using new
9479 analyse_inner member function.
9480 (riscv_struct_info::field_offset): New member function.
9481 (riscv_struct_info::m_offsets): New member variable.
9482 (riscv_struct_info::analyse_inner): New private member function,
9483 takes the old implementation of riscv_struct_info::analyse but
9484 extended to track field offsets.
9485 (riscv_call_arg_struct): Update the struct folding special cases
9486 to handle cases where empty C++ structs, which are non-zero
9488 (riscv_arg_location): Initialise the length of each location, a
9489 non-zero length now indicates the location is in use.
9490 (riscv_push_dummy_call): Allow for the first location having a
9491 non-zero offset when setting up arguments.
9492 (riscv_return_value): Likewise, but for return values.
9494 2019-04-11 Tom Tromey <tromey@adacore.com>
9496 * utils.c (internal_vproblem): Make "msg" const.
9498 2019-04-11 Alan Hayward <alan.hayward@arm.com>
9500 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9501 * trad-frame.c (trad_frame_reset_saved_regs): New function.
9502 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9503 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9505 2019-04-10 Kevin Buettner <kevinb@redhat.com>
9507 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9509 (fill_gregset): Call amd64_linux_collect_native_gregset instead
9510 of amd64_collect_native_gregset.
9511 (amd64_linux_nat_target::store_registers): Likewise.
9513 2019-04-10 Tom Tromey <tom@tromey.com>
9515 * symtab.c (lookup_global_symbol_from_objfile)
9516 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9517 * objfiles.h (class separate_debug_iterator): New.
9518 (class separate_debug_range): New.
9519 (struct objfile) <separate_debug_objfiles>: New method.
9520 (objfile_separate_debug_iterate): Don't declare.
9521 * objfiles.c (separate_debug_iterator::operator++): Rename from
9522 objfile_separate_debug_iterate.
9523 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9525 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9528 2019-04-10 Tom Tromey <tom@tromey.com>
9530 * symfile.c (reread_symbols): Remove old comment.
9531 * objfiles.c (free_all_objfiles): Fix a typo.
9533 2019-04-10 Tom Tromey <tom@tromey.com>
9535 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9536 * minsyms.c (lookup_minimal_symbol): Use foreach.
9537 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9538 (lookup_minimal_symbol_solib_trampoline): Likewise.
9539 * symfile.c (reread_symbols): Use foreach.
9541 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
9542 Tom Tromey <tromey@adacore.com>
9545 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9546 (rust_lex_int_test): Change "value" to be LONGEST.
9547 (rust_lex_tests): Add test for long integer literal.
9549 2019-04-09 Tom Tromey <tromey@adacore.com>
9551 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9553 (extended_remote_target::attach): Update.
9554 (remote_target::remote_notice_new_inferior): Update.
9555 (remote_target::add_current_inferior_and_thread): Update.
9556 * inferior.c (exit_inferior_1): Use "false".
9557 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9559 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
9561 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9562 the "start" command.
9564 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9566 * python/py-inferior.c (infpy_thread_from_thread_handle):
9567 Adjust comments to reflect renaming of thread_from_thread_handle
9568 to thread_from_handle. Adjust keywords. Fix type error message.
9569 (inferior_object_methods): Add thread_from_handle. Retain
9570 thread_from_thread_handle, but mark it as deprecated.
9572 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9574 * gdbthread.h (find_thread_by_handle): Revise declaration.
9575 * thread.c (find_thread_by_handle): Likewise. Adjust
9577 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9578 support for buffer objects as handles.
9580 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9582 * python/py-infthread.c (thpy_thread_handle): New function.
9583 (thread_object_methods): Register thpy_thread_handle.
9585 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9587 * gdbthread.h (thread_to_thread_handle): Declare.
9588 * thread.c (gdbtypes.h): Include.
9589 (thread_to_thread_handle): New function.
9591 * target.h (struct target_ops): Add thread_info_to_thread_handle.
9592 (target_thread_info_to_thread_handle): Declare.
9593 * target.c (target_thread_info_to_thread_handle): New function.
9594 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9595 * target-delegates.c: Regenerate.
9597 * linux-thread-db.c (class thread_db_target): Add method
9598 thread_info_to_thread_handle.
9599 (thread_db_target::thread_info_to_thread_handle): Define.
9600 * remote.c (class remote_target): Add new method
9601 thread_info_to_thread_handle.
9602 (remote_target::thread_info_to_thread_handle): Define.
9604 2019-04-08 Pedro Alves <palves@redhat.com>
9606 * common/common-exceptions.c (throw_exception): Don't create
9607 named object to throw; throw directly.
9608 (throw_it): Likewise. Don't initialize gdb_exception::message
9609 here, with new; pass FMT and AP to the ctor instead.
9610 * common/common-exceptions.h: Include <string>.
9611 (gdb_exception::gdb_exception(enum return_reason, enum errors,
9612 const char *, va_list)): New ctor. Use std::make_shared.
9613 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9615 (gdb_exception_error::gdb_exception_error(enum errors, const char
9617 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9619 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9621 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9622 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9625 2019-04-08 Tom Tromey <tom@tromey.com>
9627 * valops.c (value_rtti_indirect_type): Replace throw_exception
9629 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9631 * thread.c (thr_try_catch_cmd): Replace throw_exception with
9633 * target.c (target_translate_tls_address): Replace throw_exception
9635 * stack.c (frame_apply_command_count): Replace throw_exception
9637 * solib-spu.c (append_ocl_sos): Replace throw_exception with
9639 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9641 * rs6000-tdep.c (rs6000_frame_cache)
9642 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9643 * remote.c: Replace throw_exception with throw.
9644 * record-full.c (record_full_message, record_full_wait_1)
9645 (record_full_restore): Replace throw_exception with throw.
9647 (get_thread_current_frame_id, record_btrace_start_replaying)
9648 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9649 (cmd_record_btrace_start): Replace throw_exception with throw.
9650 * parse.c (parse_exp_in_context_1): Replace throw_exception with
9652 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9653 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9655 (find_linespec_symbols): Replace throw_exception with throw.
9656 * infrun.c (displaced_step_prepare, resume): Replace
9657 throw_exception with throw.
9658 * infcmd.c (post_create_inferior): Replace throw_exception with
9660 * inf-loop.c (inferior_event_handler): Replace throw_exception
9662 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9663 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9664 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9665 (get_prev_frame_always, get_frame_pc_if_available)
9666 (get_frame_address_in_block_if_available, get_frame_language):
9667 Replace throw_exception with throw.
9668 * frame-unwind.c (frame_unwind_try_unwinder): Replace
9669 throw_exception with throw.
9670 * eval.c (fetch_subexp_value, evaluate_var_value)
9671 (evaluate_funcall, evaluate_subexp_standard): Replace
9672 throw_exception with throw.
9673 * dwarf2loc.c (call_site_find_chain)
9674 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9675 Replace throw_exception with throw.
9676 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9678 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9680 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9681 * completer.c (complete_line_internal): Replace throw_exception
9683 * compile/compile-object-run.c (compile_object_run): Replace
9684 throw_exception with throw.
9685 * cli/cli-script.c (process_next_line): Replace throw_exception
9687 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9688 (btrace_enable, btrace_maint_update_pt_packets): Replace
9689 throw_exception with throw.
9690 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9691 throw_exception with throw.
9692 * break-catch-throw.c (re_set_exception_catchpoint): Replace
9693 throw_exception with throw.
9694 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9695 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9696 * aarch64-tdep.c (aarch64_make_prologue_cache)
9697 (aarch64_make_stub_cache): Replace throw_exception with throw.
9699 2019-04-08 Tom Tromey <tom@tromey.com>
9701 * common/common-exceptions.c (throw_exception): Rename from
9702 throw_exception_cxx. Remove old copy. Make argument const.
9703 (throw_it): Create and throw exception objects directly.
9704 * common/common-exceptions.h (throw_exception): Make argument
9706 (struct gdb_exception_error): Add constructor.
9707 (struct gdb_exception_quit): Add constructor.
9709 2019-04-08 Tom Tromey <tom@tromey.com>
9711 * common/common-exceptions.h (exception_rethrow): Don't declare.
9712 (TRY_SJLJ): Update comment.
9713 (TRY, CATCH, END_CATCH): Remove.
9714 * common/common-exceptions.c (exception_rethrow): Remove.
9716 2019-04-08 Tom Tromey <tom@tromey.com>
9718 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9720 (gdb_exception_error): Rename from
9721 gdb_exception_RETURN_MASK_ERROR.
9722 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9723 (gdb_quit_bad_alloc): Update.
9724 * aarch64-tdep.c: Update.
9725 * ada-lang.c: Update.
9726 * ada-typeprint.c: Update.
9727 * ada-valprint.c: Update.
9728 * amd64-tdep.c: Update.
9729 * arch-utils.c: Update.
9730 * break-catch-throw.c: Update.
9731 * breakpoint.c: Update.
9733 * c-varobj.c: Update.
9734 * cli/cli-cmds.c: Update.
9735 * cli/cli-interp.c: Update.
9736 * cli/cli-script.c: Update.
9737 * common/common-exceptions.c: Update.
9738 * common/new-op.c: Update.
9739 * common/selftest.c: Update.
9740 * compile/compile-c-symbols.c: Update.
9741 * compile/compile-cplus-symbols.c: Update.
9742 * compile/compile-object-load.c: Update.
9743 * compile/compile-object-run.c: Update.
9744 * completer.c: Update.
9745 * corelow.c: Update.
9747 * cp-support.c: Update.
9748 * cp-valprint.c: Update.
9749 * darwin-nat.c: Update.
9750 * disasm-selftests.c: Update.
9751 * dtrace-probe.c: Update.
9752 * dwarf-index-cache.c: Update.
9753 * dwarf-index-write.c: Update.
9754 * dwarf2-frame-tailcall.c: Update.
9755 * dwarf2-frame.c: Update.
9756 * dwarf2loc.c: Update.
9757 * dwarf2read.c: Update.
9759 * event-loop.c: Update.
9760 * event-top.c: Update.
9762 * f-valprint.c: Update.
9763 * fbsd-tdep.c: Update.
9764 * frame-unwind.c: Update.
9766 * gdbtypes.c: Update.
9767 * gnu-v3-abi.c: Update.
9768 * guile/guile-internal.h: Update.
9769 * guile/scm-block.c: Update.
9770 * guile/scm-breakpoint.c: Update.
9771 * guile/scm-cmd.c: Update.
9772 * guile/scm-disasm.c: Update.
9773 * guile/scm-frame.c: Update.
9774 * guile/scm-lazy-string.c: Update.
9775 * guile/scm-math.c: Update.
9776 * guile/scm-param.c: Update.
9777 * guile/scm-ports.c: Update.
9778 * guile/scm-pretty-print.c: Update.
9779 * guile/scm-symbol.c: Update.
9780 * guile/scm-symtab.c: Update.
9781 * guile/scm-type.c: Update.
9782 * guile/scm-value.c: Update.
9783 * i386-linux-tdep.c: Update.
9784 * i386-tdep.c: Update.
9785 * inf-loop.c: Update.
9786 * infcall.c: Update.
9790 * language.c: Update.
9791 * linespec.c: Update.
9792 * linux-fork.c: Update.
9793 * linux-nat.c: Update.
9794 * linux-tdep.c: Update.
9795 * linux-thread-db.c: Update.
9797 * mi/mi-cmd-break.c: Update.
9798 * mi/mi-cmd-stack.c: Update.
9799 * mi/mi-interp.c: Update.
9800 * mi/mi-main.c: Update.
9801 * objc-lang.c: Update.
9802 * p-valprint.c: Update.
9804 * ppc-linux-tdep.c: Update.
9805 * printcmd.c: Update.
9806 * python/py-arch.c: Update.
9807 * python/py-breakpoint.c: Update.
9808 * python/py-cmd.c: Update.
9809 * python/py-finishbreakpoint.c: Update.
9810 * python/py-frame.c: Update.
9811 * python/py-framefilter.c: Update.
9812 * python/py-gdb-readline.c: Update.
9813 * python/py-inferior.c: Update.
9814 * python/py-infthread.c: Update.
9815 * python/py-lazy-string.c: Update.
9816 * python/py-linetable.c: Update.
9817 * python/py-objfile.c: Update.
9818 * python/py-param.c: Update.
9819 * python/py-prettyprint.c: Update.
9820 * python/py-progspace.c: Update.
9821 * python/py-record-btrace.c: Update.
9822 * python/py-record.c: Update.
9823 * python/py-symbol.c: Update.
9824 * python/py-type.c: Update.
9825 * python/py-unwind.c: Update.
9826 * python/py-utils.c: Update.
9827 * python/py-value.c: Update.
9828 * python/python.c: Update.
9829 * record-btrace.c: Update.
9830 * record-full.c: Update.
9831 * remote-fileio.c: Update.
9833 * riscv-tdep.c: Update.
9834 * rs6000-aix-tdep.c: Update.
9835 * rs6000-tdep.c: Update.
9836 * rust-exp.y: Update.
9837 * rust-lang.c: Update.
9838 * s390-tdep.c: Update.
9839 * selftest-arch.c: Update.
9840 * solib-dsbt.c: Update.
9841 * solib-frv.c: Update.
9842 * solib-spu.c: Update.
9843 * solib-svr4.c: Update.
9845 * sparc64-linux-tdep.c: Update.
9847 * symfile-mem.c: Update.
9848 * symmisc.c: Update.
9852 * tracefile-tfile.c: Update.
9853 * tui/tui.c: Update.
9854 * typeprint.c: Update.
9855 * unittests/cli-utils-selftests.c: Update.
9856 * unittests/parse-connection-spec-selftests.c: Update.
9858 * valprint.c: Update.
9861 * windows-nat.c: Update.
9862 * x86-linux-nat.c: Update.
9863 * xml-support.c: Update.
9865 2019-04-08 Tom Tromey <tom@tromey.com>
9867 * xml-support.c: Use C++ exception handling.
9868 * x86-linux-nat.c: Use C++ exception handling.
9869 * windows-nat.c: Use C++ exception handling.
9870 * varobj.c: Use C++ exception handling.
9871 * value.c: Use C++ exception handling.
9872 * valprint.c: Use C++ exception handling.
9873 * valops.c: Use C++ exception handling.
9874 * unittests/parse-connection-spec-selftests.c: Use C++ exception
9876 * unittests/cli-utils-selftests.c: Use C++ exception handling.
9877 * typeprint.c: Use C++ exception handling.
9878 * tui/tui.c: Use C++ exception handling.
9879 * tracefile-tfile.c: Use C++ exception handling.
9880 * top.c: Use C++ exception handling.
9881 * thread.c: Use C++ exception handling.
9882 * target.c: Use C++ exception handling.
9883 * symmisc.c: Use C++ exception handling.
9884 * symfile-mem.c: Use C++ exception handling.
9885 * stack.c: Use C++ exception handling.
9886 * sparc64-linux-tdep.c: Use C++ exception handling.
9887 * solib.c: Use C++ exception handling.
9888 * solib-svr4.c: Use C++ exception handling.
9889 * solib-spu.c: Use C++ exception handling.
9890 * solib-frv.c: Use C++ exception handling.
9891 * solib-dsbt.c: Use C++ exception handling.
9892 * selftest-arch.c: Use C++ exception handling.
9893 * s390-tdep.c: Use C++ exception handling.
9894 * rust-lang.c: Use C++ exception handling.
9895 * rust-exp.y: Use C++ exception handling.
9896 * rs6000-tdep.c: Use C++ exception handling.
9897 * rs6000-aix-tdep.c: Use C++ exception handling.
9898 * riscv-tdep.c: Use C++ exception handling.
9899 * remote.c: Use C++ exception handling.
9900 * remote-fileio.c: Use C++ exception handling.
9901 * record-full.c: Use C++ exception handling.
9902 * record-btrace.c: Use C++ exception handling.
9903 * python/python.c: Use C++ exception handling.
9904 * python/py-value.c: Use C++ exception handling.
9905 * python/py-utils.c: Use C++ exception handling.
9906 * python/py-unwind.c: Use C++ exception handling.
9907 * python/py-type.c: Use C++ exception handling.
9908 * python/py-symbol.c: Use C++ exception handling.
9909 * python/py-record.c: Use C++ exception handling.
9910 * python/py-record-btrace.c: Use C++ exception handling.
9911 * python/py-progspace.c: Use C++ exception handling.
9912 * python/py-prettyprint.c: Use C++ exception handling.
9913 * python/py-param.c: Use C++ exception handling.
9914 * python/py-objfile.c: Use C++ exception handling.
9915 * python/py-linetable.c: Use C++ exception handling.
9916 * python/py-lazy-string.c: Use C++ exception handling.
9917 * python/py-infthread.c: Use C++ exception handling.
9918 * python/py-inferior.c: Use C++ exception handling.
9919 * python/py-gdb-readline.c: Use C++ exception handling.
9920 * python/py-framefilter.c: Use C++ exception handling.
9921 * python/py-frame.c: Use C++ exception handling.
9922 * python/py-finishbreakpoint.c: Use C++ exception handling.
9923 * python/py-cmd.c: Use C++ exception handling.
9924 * python/py-breakpoint.c: Use C++ exception handling.
9925 * python/py-arch.c: Use C++ exception handling.
9926 * printcmd.c: Use C++ exception handling.
9927 * ppc-linux-tdep.c: Use C++ exception handling.
9928 * parse.c: Use C++ exception handling.
9929 * p-valprint.c: Use C++ exception handling.
9930 * objc-lang.c: Use C++ exception handling.
9931 * mi/mi-main.c: Use C++ exception handling.
9932 * mi/mi-interp.c: Use C++ exception handling.
9933 * mi/mi-cmd-stack.c: Use C++ exception handling.
9934 * mi/mi-cmd-break.c: Use C++ exception handling.
9935 * main.c: Use C++ exception handling.
9936 * linux-thread-db.c: Use C++ exception handling.
9937 * linux-tdep.c: Use C++ exception handling.
9938 * linux-nat.c: Use C++ exception handling.
9939 * linux-fork.c: Use C++ exception handling.
9940 * linespec.c: Use C++ exception handling.
9941 * language.c: Use C++ exception handling.
9942 * jit.c: Use C++ exception handling.
9943 * infrun.c: Use C++ exception handling.
9944 * infcmd.c: Use C++ exception handling.
9945 * infcall.c: Use C++ exception handling.
9946 * inf-loop.c: Use C++ exception handling.
9947 * i386-tdep.c: Use C++ exception handling.
9948 * i386-linux-tdep.c: Use C++ exception handling.
9949 * guile/scm-value.c: Use C++ exception handling.
9950 * guile/scm-type.c: Use C++ exception handling.
9951 * guile/scm-symtab.c: Use C++ exception handling.
9952 * guile/scm-symbol.c: Use C++ exception handling.
9953 * guile/scm-pretty-print.c: Use C++ exception handling.
9954 * guile/scm-ports.c: Use C++ exception handling.
9955 * guile/scm-param.c: Use C++ exception handling.
9956 * guile/scm-math.c: Use C++ exception handling.
9957 * guile/scm-lazy-string.c: Use C++ exception handling.
9958 * guile/scm-frame.c: Use C++ exception handling.
9959 * guile/scm-disasm.c: Use C++ exception handling.
9960 * guile/scm-cmd.c: Use C++ exception handling.
9961 * guile/scm-breakpoint.c: Use C++ exception handling.
9962 * guile/scm-block.c: Use C++ exception handling.
9963 * guile/guile-internal.h: Use C++ exception handling.
9964 * gnu-v3-abi.c: Use C++ exception handling.
9965 * gdbtypes.c: Use C++ exception handling.
9966 * frame.c: Use C++ exception handling.
9967 * frame-unwind.c: Use C++ exception handling.
9968 * fbsd-tdep.c: Use C++ exception handling.
9969 * f-valprint.c: Use C++ exception handling.
9970 * exec.c: Use C++ exception handling.
9971 * event-top.c: Use C++ exception handling.
9972 * event-loop.c: Use C++ exception handling.
9973 * eval.c: Use C++ exception handling.
9974 * dwarf2read.c: Use C++ exception handling.
9975 * dwarf2loc.c: Use C++ exception handling.
9976 * dwarf2-frame.c: Use C++ exception handling.
9977 * dwarf2-frame-tailcall.c: Use C++ exception handling.
9978 * dwarf-index-write.c: Use C++ exception handling.
9979 * dwarf-index-cache.c: Use C++ exception handling.
9980 * dtrace-probe.c: Use C++ exception handling.
9981 * disasm-selftests.c: Use C++ exception handling.
9982 * darwin-nat.c: Use C++ exception handling.
9983 * cp-valprint.c: Use C++ exception handling.
9984 * cp-support.c: Use C++ exception handling.
9985 * cp-abi.c: Use C++ exception handling.
9986 * corelow.c: Use C++ exception handling.
9987 * completer.c: Use C++ exception handling.
9988 * compile/compile-object-run.c: Use C++ exception handling.
9989 * compile/compile-object-load.c: Use C++ exception handling.
9990 * compile/compile-cplus-symbols.c: Use C++ exception handling.
9991 * compile/compile-c-symbols.c: Use C++ exception handling.
9992 * common/selftest.c: Use C++ exception handling.
9993 * common/new-op.c: Use C++ exception handling.
9994 * cli/cli-script.c: Use C++ exception handling.
9995 * cli/cli-interp.c: Use C++ exception handling.
9996 * cli/cli-cmds.c: Use C++ exception handling.
9997 * c-varobj.c: Use C++ exception handling.
9998 * btrace.c: Use C++ exception handling.
9999 * breakpoint.c: Use C++ exception handling.
10000 * break-catch-throw.c: Use C++ exception handling.
10001 * arch-utils.c: Use C++ exception handling.
10002 * amd64-tdep.c: Use C++ exception handling.
10003 * ada-valprint.c: Use C++ exception handling.
10004 * ada-typeprint.c: Use C++ exception handling.
10005 * ada-lang.c: Use C++ exception handling.
10006 * aarch64-tdep.c: Use C++ exception handling.
10008 2019-04-08 Tom Tromey <tom@tromey.com>
10010 * xml-support.c (gdb_xml_parser::parse): Update.
10011 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10012 * value.c (show_convenience): Update.
10013 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10014 (test_parse_flags_qcs): Update.
10015 * thread.c (thr_try_catch_cmd): Update.
10016 * target.c (target_translate_tls_address): Update.
10017 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10018 (info_frame_command_core, frame_apply_command_count): Update.
10019 * rust-exp.y (rust_lex_exception_test): Update.
10020 * riscv-tdep.c (riscv_print_one_register_info): Update.
10021 * remote.c (remote_target::enable_btrace): Update.
10022 * record-btrace.c (record_btrace_enable_warn): Update.
10023 * python/py-utils.c (gdbpy_convert_exception): Update.
10024 * printcmd.c (do_one_display, print_variable_and_value): Update.
10025 * mi/mi-main.c (mi_print_exception): Update.
10026 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10027 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10028 * linux-nat.c (linux_nat_target::attach): Update.
10029 * linux-fork.c (class scoped_switch_fork_info): Update.
10030 * infrun.c (displaced_step_prepare): Update.
10031 * infcall.c (call_function_by_hand_dummy): Update.
10032 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10033 * gnu-v3-abi.c (print_one_vtable): Update.
10034 * frame.c (get_prev_frame_always): Update.
10035 * f-valprint.c (info_common_command_for_block): Update.
10036 * exec.c (try_open_exec_file): Update.
10037 * exceptions.c (print_exception, exception_print)
10038 (exception_fprintf, exception_print_same): Update.
10039 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10040 * dwarf-index-cache.c (index_cache::store)
10041 (index_cache::lookup_gdb_index): Update.
10042 * darwin-nat.c (maybe_cache_shell): Update.
10043 * cp-valprint.c (cp_print_value_fields): Update.
10044 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10045 (gcc_cplus_symbol_address): Update.
10046 * compile/compile-c-symbols.c (gcc_convert_symbol)
10047 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10048 * common/selftest.c: Update.
10049 * common/common-exceptions.h (struct gdb_exception) <message>: Now
10051 (exception_try_scope_entry, exception_try_scope_exit): Don't
10053 (struct exception_try_scope): Remove.
10054 (TRY): Don't use exception_try_scope.
10055 (struct gdb_exception): Add constructor, operator=.
10056 <what>: New method.
10057 (struct gdb_exception_RETURN_MASK_ALL)
10058 (struct gdb_exception_RETURN_MASK_ERROR)
10059 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10060 (struct gdb_quit_bad_alloc): Update.
10061 * common/common-exceptions.c (exception_none): Change
10063 (struct catcher) <state, exception>: Initialize inline.
10064 <prev>: Remove member.
10065 (current_catcher): Remove.
10066 (catchers): New global.
10067 (exceptions_state_mc_init): Simplify.
10068 (catcher_pop): Remove.
10069 (exceptions_state_mc, exceptions_state_mc_catch): Update.
10070 (try_scope_depth, exception_try_scope_entry)
10071 (exception_try_scope_exit): Remove.
10072 (throw_exception_sjlj): Update.
10073 (exception_messages, exception_messages_size): Remove.
10074 (throw_it): Simplify.
10075 (gdb_exception_sliced_copy): Remove.
10076 (throw_exception_cxx): Update.
10077 * cli/cli-script.c (script_from_file): Update.
10078 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10080 * ada-valprint.c (ada_val_print): Update.
10081 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10082 (create_excep_cond_exprs): Update.
10084 2019-04-08 Tom Tromey <tom@tromey.com>
10086 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10087 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10088 (TRY, CATCH, END_CATCH): Remove some definitions.
10089 * common/common-exceptions.c: Don't use GDB_XCPT.
10090 (catcher_list_size): Remove.
10091 (throw_exception, throw_it): Simplify.
10093 2019-04-05 Tom Tromey <tom@tromey.com>
10095 Revert the header-sorting patch.
10096 * ft32-tdep.c: Revert.
10097 * frv-tdep.c: Revert.
10098 * frv-linux-tdep.c: Revert.
10100 * frame-unwind.c: Revert.
10101 * frame-base.c: Revert.
10102 * fork-child.c: Revert.
10103 * findvar.c: Revert.
10104 * findcmd.c: Revert.
10105 * filesystem.c: Revert.
10106 * filename-seen-cache.h: Revert.
10107 * filename-seen-cache.c: Revert.
10108 * fbsd-tdep.c: Revert.
10109 * fbsd-nat.h: Revert.
10110 * fbsd-nat.c: Revert.
10111 * f-valprint.c: Revert.
10112 * f-typeprint.c: Revert.
10113 * f-lang.c: Revert.
10114 * extension.h: Revert.
10115 * extension.c: Revert.
10116 * extension-priv.h: Revert.
10117 * expprint.c: Revert.
10120 * exceptions.c: Revert.
10121 * event-top.c: Revert.
10122 * event-loop.c: Revert.
10124 * elfread.c: Revert.
10125 * dwarf2read.h: Revert.
10126 * dwarf2read.c: Revert.
10127 * dwarf2loc.c: Revert.
10128 * dwarf2expr.h: Revert.
10129 * dwarf2expr.c: Revert.
10130 * dwarf2-frame.c: Revert.
10131 * dwarf2-frame-tailcall.c: Revert.
10132 * dwarf-index-write.h: Revert.
10133 * dwarf-index-write.c: Revert.
10134 * dwarf-index-common.c: Revert.
10135 * dwarf-index-cache.h: Revert.
10136 * dwarf-index-cache.c: Revert.
10137 * dummy-frame.c: Revert.
10138 * dtrace-probe.c: Revert.
10139 * disasm.h: Revert.
10140 * disasm.c: Revert.
10141 * disasm-selftests.c: Revert.
10142 * dictionary.c: Revert.
10143 * dicos-tdep.c: Revert.
10144 * demangle.c: Revert.
10145 * dcache.h: Revert.
10146 * dcache.c: Revert.
10147 * darwin-nat.h: Revert.
10148 * darwin-nat.c: Revert.
10149 * darwin-nat-info.c: Revert.
10150 * d-valprint.c: Revert.
10151 * d-namespace.c: Revert.
10152 * d-lang.c: Revert.
10154 * csky-tdep.c: Revert.
10155 * csky-linux-tdep.c: Revert.
10156 * cris-tdep.c: Revert.
10157 * cris-linux-tdep.c: Revert.
10158 * cp-valprint.c: Revert.
10159 * cp-support.c: Revert.
10160 * cp-namespace.c: Revert.
10161 * cp-abi.c: Revert.
10162 * corelow.c: Revert.
10163 * corefile.c: Revert.
10164 * continuations.c: Revert.
10165 * completer.h: Revert.
10166 * completer.c: Revert.
10167 * complaints.c: Revert.
10168 * coffread.c: Revert.
10169 * coff-pe-read.c: Revert.
10170 * cli-out.h: Revert.
10171 * cli-out.c: Revert.
10172 * charset.c: Revert.
10173 * c-varobj.c: Revert.
10174 * c-valprint.c: Revert.
10175 * c-typeprint.c: Revert.
10176 * c-lang.c: Revert.
10177 * buildsym.c: Revert.
10178 * buildsym-legacy.c: Revert.
10179 * build-id.h: Revert.
10180 * build-id.c: Revert.
10181 * btrace.c: Revert.
10182 * bsd-uthread.c: Revert.
10183 * breakpoint.h: Revert.
10184 * breakpoint.c: Revert.
10185 * break-catch-throw.c: Revert.
10186 * break-catch-syscall.c: Revert.
10187 * break-catch-sig.c: Revert.
10188 * blockframe.c: Revert.
10190 * bfin-tdep.c: Revert.
10191 * bfin-linux-tdep.c: Revert.
10192 * bfd-target.c: Revert.
10193 * bcache.c: Revert.
10194 * ax-general.c: Revert.
10195 * ax-gdb.h: Revert.
10196 * ax-gdb.c: Revert.
10197 * avr-tdep.c: Revert.
10199 * auto-load.c: Revert.
10200 * arm-wince-tdep.c: Revert.
10201 * arm-tdep.c: Revert.
10202 * arm-symbian-tdep.c: Revert.
10203 * arm-pikeos-tdep.c: Revert.
10204 * arm-obsd-tdep.c: Revert.
10205 * arm-nbsd-tdep.c: Revert.
10206 * arm-nbsd-nat.c: Revert.
10207 * arm-linux-tdep.c: Revert.
10208 * arm-linux-nat.c: Revert.
10209 * arm-fbsd-tdep.c: Revert.
10210 * arm-fbsd-nat.c: Revert.
10211 * arm-bsd-tdep.c: Revert.
10212 * arch-utils.c: Revert.
10213 * arc-tdep.c: Revert.
10214 * arc-newlib-tdep.c: Revert.
10215 * annotate.h: Revert.
10216 * annotate.c: Revert.
10217 * amd64-windows-tdep.c: Revert.
10218 * amd64-windows-nat.c: Revert.
10219 * amd64-tdep.c: Revert.
10220 * amd64-sol2-tdep.c: Revert.
10221 * amd64-obsd-tdep.c: Revert.
10222 * amd64-obsd-nat.c: Revert.
10223 * amd64-nbsd-tdep.c: Revert.
10224 * amd64-nbsd-nat.c: Revert.
10225 * amd64-nat.c: Revert.
10226 * amd64-linux-tdep.c: Revert.
10227 * amd64-linux-nat.c: Revert.
10228 * amd64-fbsd-tdep.c: Revert.
10229 * amd64-fbsd-nat.c: Revert.
10230 * amd64-dicos-tdep.c: Revert.
10231 * amd64-darwin-tdep.c: Revert.
10232 * amd64-bsd-nat.c: Revert.
10233 * alpha-tdep.c: Revert.
10234 * alpha-obsd-tdep.c: Revert.
10235 * alpha-nbsd-tdep.c: Revert.
10236 * alpha-mdebug-tdep.c: Revert.
10237 * alpha-linux-tdep.c: Revert.
10238 * alpha-linux-nat.c: Revert.
10239 * alpha-bsd-tdep.c: Revert.
10240 * alpha-bsd-nat.c: Revert.
10241 * aix-thread.c: Revert.
10243 * addrmap.c: Revert.
10244 * ada-varobj.c: Revert.
10245 * ada-valprint.c: Revert.
10246 * ada-typeprint.c: Revert.
10247 * ada-tasks.c: Revert.
10248 * ada-lang.c: Revert.
10249 * aarch64-tdep.c: Revert.
10250 * aarch64-ravenscar-thread.c: Revert.
10251 * aarch64-newlib-tdep.c: Revert.
10252 * aarch64-linux-tdep.c: Revert.
10253 * aarch64-linux-nat.c: Revert.
10254 * aarch64-fbsd-tdep.c: Revert.
10255 * aarch64-fbsd-nat.c: Revert.
10256 * aarch32-linux-nat.c: Revert.
10258 2019-04-05 Tom Tromey <tom@tromey.com>
10260 * ft32-tdep.c: Sort headers.
10261 * frv-tdep.c: Sort headers.
10262 * frv-linux-tdep.c: Sort headers.
10263 * frame.c: Sort headers.
10264 * frame-unwind.c: Sort headers.
10265 * frame-base.c: Sort headers.
10266 * fork-child.c: Sort headers.
10267 * findvar.c: Sort headers.
10268 * findcmd.c: Sort headers.
10269 * filesystem.c: Sort headers.
10270 * filename-seen-cache.h: Sort headers.
10271 * filename-seen-cache.c: Sort headers.
10272 * fbsd-tdep.c: Sort headers.
10273 * fbsd-nat.h: Sort headers.
10274 * fbsd-nat.c: Sort headers.
10275 * f-valprint.c: Sort headers.
10276 * f-typeprint.c: Sort headers.
10277 * f-lang.c: Sort headers.
10278 * extension.h: Sort headers.
10279 * extension.c: Sort headers.
10280 * extension-priv.h: Sort headers.
10281 * expprint.c: Sort headers.
10282 * exec.h: Sort headers.
10283 * exec.c: Sort headers.
10284 * exceptions.c: Sort headers.
10285 * event-top.c: Sort headers.
10286 * event-loop.c: Sort headers.
10287 * eval.c: Sort headers.
10288 * elfread.c: Sort headers.
10289 * dwarf2read.h: Sort headers.
10290 * dwarf2read.c: Sort headers.
10291 * dwarf2loc.c: Sort headers.
10292 * dwarf2expr.h: Sort headers.
10293 * dwarf2expr.c: Sort headers.
10294 * dwarf2-frame.c: Sort headers.
10295 * dwarf2-frame-tailcall.c: Sort headers.
10296 * dwarf-index-write.h: Sort headers.
10297 * dwarf-index-write.c: Sort headers.
10298 * dwarf-index-common.c: Sort headers.
10299 * dwarf-index-cache.h: Sort headers.
10300 * dwarf-index-cache.c: Sort headers.
10301 * dummy-frame.c: Sort headers.
10302 * dtrace-probe.c: Sort headers.
10303 * disasm.h: Sort headers.
10304 * disasm.c: Sort headers.
10305 * disasm-selftests.c: Sort headers.
10306 * dictionary.c: Sort headers.
10307 * dicos-tdep.c: Sort headers.
10308 * demangle.c: Sort headers.
10309 * dcache.h: Sort headers.
10310 * dcache.c: Sort headers.
10311 * darwin-nat.h: Sort headers.
10312 * darwin-nat.c: Sort headers.
10313 * darwin-nat-info.c: Sort headers.
10314 * d-valprint.c: Sort headers.
10315 * d-namespace.c: Sort headers.
10316 * d-lang.c: Sort headers.
10317 * ctf.c: Sort headers.
10318 * csky-tdep.c: Sort headers.
10319 * csky-linux-tdep.c: Sort headers.
10320 * cris-tdep.c: Sort headers.
10321 * cris-linux-tdep.c: Sort headers.
10322 * cp-valprint.c: Sort headers.
10323 * cp-support.c: Sort headers.
10324 * cp-namespace.c: Sort headers.
10325 * cp-abi.c: Sort headers.
10326 * corelow.c: Sort headers.
10327 * corefile.c: Sort headers.
10328 * continuations.c: Sort headers.
10329 * completer.h: Sort headers.
10330 * completer.c: Sort headers.
10331 * complaints.c: Sort headers.
10332 * coffread.c: Sort headers.
10333 * coff-pe-read.c: Sort headers.
10334 * cli-out.h: Sort headers.
10335 * cli-out.c: Sort headers.
10336 * charset.c: Sort headers.
10337 * c-varobj.c: Sort headers.
10338 * c-valprint.c: Sort headers.
10339 * c-typeprint.c: Sort headers.
10340 * c-lang.c: Sort headers.
10341 * buildsym.c: Sort headers.
10342 * buildsym-legacy.c: Sort headers.
10343 * build-id.h: Sort headers.
10344 * build-id.c: Sort headers.
10345 * btrace.c: Sort headers.
10346 * bsd-uthread.c: Sort headers.
10347 * breakpoint.h: Sort headers.
10348 * breakpoint.c: Sort headers.
10349 * break-catch-throw.c: Sort headers.
10350 * break-catch-syscall.c: Sort headers.
10351 * break-catch-sig.c: Sort headers.
10352 * blockframe.c: Sort headers.
10353 * block.c: Sort headers.
10354 * bfin-tdep.c: Sort headers.
10355 * bfin-linux-tdep.c: Sort headers.
10356 * bfd-target.c: Sort headers.
10357 * bcache.c: Sort headers.
10358 * ax-general.c: Sort headers.
10359 * ax-gdb.h: Sort headers.
10360 * ax-gdb.c: Sort headers.
10361 * avr-tdep.c: Sort headers.
10362 * auxv.c: Sort headers.
10363 * auto-load.c: Sort headers.
10364 * arm-wince-tdep.c: Sort headers.
10365 * arm-tdep.c: Sort headers.
10366 * arm-symbian-tdep.c: Sort headers.
10367 * arm-pikeos-tdep.c: Sort headers.
10368 * arm-obsd-tdep.c: Sort headers.
10369 * arm-nbsd-tdep.c: Sort headers.
10370 * arm-nbsd-nat.c: Sort headers.
10371 * arm-linux-tdep.c: Sort headers.
10372 * arm-linux-nat.c: Sort headers.
10373 * arm-fbsd-tdep.c: Sort headers.
10374 * arm-fbsd-nat.c: Sort headers.
10375 * arm-bsd-tdep.c: Sort headers.
10376 * arch-utils.c: Sort headers.
10377 * arc-tdep.c: Sort headers.
10378 * arc-newlib-tdep.c: Sort headers.
10379 * annotate.h: Sort headers.
10380 * annotate.c: Sort headers.
10381 * amd64-windows-tdep.c: Sort headers.
10382 * amd64-windows-nat.c: Sort headers.
10383 * amd64-tdep.c: Sort headers.
10384 * amd64-sol2-tdep.c: Sort headers.
10385 * amd64-obsd-tdep.c: Sort headers.
10386 * amd64-obsd-nat.c: Sort headers.
10387 * amd64-nbsd-tdep.c: Sort headers.
10388 * amd64-nbsd-nat.c: Sort headers.
10389 * amd64-nat.c: Sort headers.
10390 * amd64-linux-tdep.c: Sort headers.
10391 * amd64-linux-nat.c: Sort headers.
10392 * amd64-fbsd-tdep.c: Sort headers.
10393 * amd64-fbsd-nat.c: Sort headers.
10394 * amd64-dicos-tdep.c: Sort headers.
10395 * amd64-darwin-tdep.c: Sort headers.
10396 * amd64-bsd-nat.c: Sort headers.
10397 * alpha-tdep.c: Sort headers.
10398 * alpha-obsd-tdep.c: Sort headers.
10399 * alpha-nbsd-tdep.c: Sort headers.
10400 * alpha-mdebug-tdep.c: Sort headers.
10401 * alpha-linux-tdep.c: Sort headers.
10402 * alpha-linux-nat.c: Sort headers.
10403 * alpha-bsd-tdep.c: Sort headers.
10404 * alpha-bsd-nat.c: Sort headers.
10405 * aix-thread.c: Sort headers.
10406 * agent.c: Sort headers.
10407 * addrmap.c: Sort headers.
10408 * ada-varobj.c: Sort headers.
10409 * ada-valprint.c: Sort headers.
10410 * ada-typeprint.c: Sort headers.
10411 * ada-tasks.c: Sort headers.
10412 * ada-lang.c: Sort headers.
10413 * aarch64-tdep.c: Sort headers.
10414 * aarch64-ravenscar-thread.c: Sort headers.
10415 * aarch64-newlib-tdep.c: Sort headers.
10416 * aarch64-linux-tdep.c: Sort headers.
10417 * aarch64-linux-nat.c: Sort headers.
10418 * aarch64-fbsd-tdep.c: Sort headers.
10419 * aarch64-fbsd-nat.c: Sort headers.
10420 * aarch32-linux-nat.c: Sort headers.
10422 2019-04-04 Tom Tromey <tom@tromey.com>
10424 * varobj.c (varobj_create): Update.
10425 * rust-exp.y (struct rust_parser) <update_innermost_block,
10426 lookup_symbol>: New methods.
10427 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10429 (rust_parser::rust_lookup_type)
10430 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10431 * printcmd.c (display_command, do_one_display): Update.
10432 * parser-defs.h (struct parser_state) <parser_state>: Add
10433 "tracker" parameter.
10434 (block_tracker): New member.
10435 (class innermost_block_tracker) <innermost_block_tracker>: Add
10437 <reset>: Remove method.
10438 (innermost_block): Don't declare.
10439 (null_post_parser): Update.
10440 * parse.c (innermost_block): Remove global.
10441 (write_dollar_variable): Update.
10442 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10443 Remove "tracker_types" parameter.
10444 (parse_expression): Add "tracker" parameter.
10445 (parse_expression_for_completion): Update.
10446 (null_post_parser): Add "tracker" parameter.
10447 * p-exp.y: Update rules.
10448 * m2-exp.y: Update rules.
10449 * language.h (struct language_defn) <la_post_parser>: Add
10450 "tracker" parameter.
10451 * go-exp.y: Update rules.
10452 * f-exp.y: Update rules.
10453 * expression.h (parse_expression, parse_exp_1): Add "tracker"
10455 * d-exp.y: Update rules.
10456 * c-exp.y: Update rules.
10457 * breakpoint.c (set_breakpoint_condition): Create an
10458 innermost_block_tracker.
10459 (watch_command_1): Likewise.
10460 * ada-lang.c (resolve): Add "tracker" parameter.
10461 (resolve_subexp): Likewise.
10462 * ada-exp.y (write_var_from_sym): Update.
10464 2019-04-04 Tom Tromey <tom@tromey.com>
10466 * type-stack.h: New file.
10467 * type-stack.c: New file.
10468 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10470 (insert_into_type_stack, insert_type, push_type, push_type_int)
10471 (insert_type_address_space, pop_type, pop_type_int)
10472 (pop_typelist, pop_type_stack, append_type_stack)
10473 (push_type_stack, get_type_stack, push_typelist)
10474 (follow_type_instance_flags, follow_types): Don't declare.
10475 * parse.c (type_stack): Remove global.
10476 (parse_exp_in_context): Update.
10477 (insert_into_type_stack, insert_type, push_type, push_type_int)
10478 (insert_type_address_space, pop_type, pop_type_int)
10479 (pop_typelist, pop_type_stack, append_type_stack)
10480 (push_type_stack, get_type_stack, push_typelist)
10481 (follow_type_instance_flags, follow_types): Remove (moved to
10483 * f-exp.y (type_stack): New global.
10485 (push_kind_type, f_parse): Update.
10486 * d-exp.y (type_stack): New global.
10489 * c-exp.y (struct c_parse_state) <type_stack>: New member.
10491 * Makefile.in (COMMON_SFILES): Add type-stack.c.
10492 (HFILES_NO_SRCDIR): Add type-stack.h.
10494 2019-04-04 Tom Tromey <tom@tromey.com>
10496 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10497 (rust_parser::convert_ast_to_expression, rust_parse)
10498 (rust_lex_test_completion, rust_lex_tests): Update.
10499 * parser-defs.h (struct expr_completion_state): New.
10500 (struct parser_state) <parser_state>: Add completion parameter.
10501 <mark_struct_expression, mark_completion_tag>: New methods.
10502 <parse_completion, m_completion_state>: New members.
10503 (prefixify_expression, null_post_parser): Update.
10504 (mark_struct_expression, mark_completion_tag): Don't declare.
10505 * parse.c (parse_completion, expout_last_struct)
10506 (expout_tag_completion_type, expout_completion_name): Remove
10508 (parser_state::mark_struct_expression)
10509 (parser_state::mark_completion_tag): Now methods.
10510 (prefixify_expression): Add last_struct parameter.
10511 (prefixify_subexp): Likewise.
10512 (parse_exp_1): Update.
10513 (parse_exp_in_context): Add cstate parameter. Update.
10514 (parse_expression_for_completion): Create an
10515 expr_completion_state.
10516 (null_post_parser): Add "completion" parameter.
10517 * p-exp.y: Update rules.
10519 * language.h (struct language_defn) <la_post_parser>: Add
10520 "completing" parameter.
10521 * go-exp.y: Update rules.
10522 (lex_one_token): Update.
10523 * expression.h (parse_completion): Don't declare.
10524 * d-exp.y: Update rules.
10525 (lex_one_token): Update rules.
10526 * c-exp.y: Update rules.
10527 (lex_one_token): Update.
10528 * ada-lang.c (resolve): Add "parse_completion" parameter.
10529 (resolve_subexp): Likewise.
10530 (ada_resolve_function): Likewise.
10532 2019-04-04 Tom Tromey <tom@tromey.com>
10534 * parser-defs.h (struct parser_state) <start_arglist,
10535 end_arglist>: New methods.
10536 <arglist_len, m_funcall_chain>: New members.
10537 (arglist_len, start_arglist, end_arglist): Don't declare.
10538 * parse.c (arglist_len, funcall_chain): Remove global.
10539 (start_arglist, end_arglist): Remove functions.
10540 (parse_exp_in_context): Update.
10541 * p-exp.y: Update rules.
10542 * m2-exp.y: Update rules.
10543 * go-exp.y: Update rules.
10544 * f-exp.y: Update rules.
10545 * d-exp.y: Update rules.
10546 * c-exp.y: Update rules.
10548 2019-04-04 Tom Tromey <tom@tromey.com>
10550 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10551 lex_operator, push_back>: New methods.
10553 (rust_parser::lex_hex, lex_escape): Rename and update.
10554 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10555 (rust_parser::lex_operator): Rename and update.
10556 (rust_parser::lex_number, rustyylex, rustyyerror)
10557 (rust_lex_test_init, rust_lex_test_sequence)
10558 (rust_lex_test_push_back, rust_lex_tests): Update.
10559 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10561 <lexptr, prev_lexptr>: New members.
10562 (lexptr, prev_lexptr): Don't declare.
10563 * parse.c (lexptr, prev_lexptr): Remove globals.
10564 (parse_exp_in_context): Update.
10565 * p-exp.y (yylex, yyerror): Update.
10566 * m2-exp.y (parse_number, yylex, yyerror): Update.
10567 * go-exp.y (lex_one_token, yyerror): Update.
10568 * f-exp.y (match_string_literal, yylex, yyerror): Update.
10569 * d-exp.y (lex_one_token, yyerror): Update.
10570 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10571 (lex_one_token, yyerror): Update.
10572 * ada-lex.l (YY_INPUT): Update.
10573 (rewind_to_char): Update.
10574 * ada-exp.y (yyerror): Update.
10576 2019-04-04 Tom Tromey <tom@tromey.com>
10578 * rust-exp.y (rustyylex, rust_lex_tests): Update.
10579 * parser-defs.h (struct parser_state) <parser_state>: Add new
10581 <comma_terminates>: New member.
10582 (comma_terminates): Don't declare global.
10583 * parse.c (comma_terminates): Remove global.
10584 (parse_exp_in_context): Update.
10585 * p-exp.y (yylex): Update.
10586 * m2-exp.y (yylex): Update.
10587 * go-exp.y (lex_one_token): Update.
10588 * f-exp.y (yylex): Update.
10589 * d-exp.y (lex_one_token): Update.
10590 * c-exp.y (lex_one_token): Update.
10591 * ada-lex.l: Update.
10593 2019-04-04 Tom Tromey <tom@tromey.com>
10595 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10596 (rustyylex, rust_lex_test_init, rust_lex_test_one)
10597 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10598 * parser-defs.h (paren_depth): Don't declare.
10599 * parse.c (paren_depth): Remove global.
10600 (parse_exp_in_context): Update.
10601 * p-exp.y (paren_depth): New global.
10602 (pascal_parse): Initialize it.
10603 * m2-exp.y (paren_depth): New global.
10604 (m2_parse): Initialize it.
10605 * go-exp.y (paren_depth): New global.
10606 (go_parse): Initialize it.
10607 * f-exp.y (paren_depth): New global.
10608 (f_parse): Initialize it.
10609 * d-exp.y (paren_depth): New global.
10610 (d_parse): Initialize it.
10611 * c-exp.y (paren_depth): New global.
10612 (c_parse): Initialize it.
10613 * ada-lex.l (paren_depth): New global.
10614 (lexer_init): Initialize it.
10616 2019-04-04 Tom Tromey <tom@tromey.com>
10618 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10619 (rust_parser::convert_ast_to_type)
10620 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10621 * parser-defs.h (struct parser_state) <parser_state>: Add
10622 parameters. Initialize new members.
10623 <expression_context_block, expression_context_pc>: New members.
10624 * parse.c (expression_context_block, expression_context_pc):
10626 (parse_exp_in_context): Update.
10627 * p-exp.y: Update all rules.
10629 * m2-exp.y: Update all rules.
10631 * go-exp.y (yylex): Update.
10632 * f-exp.y (yylex): Update.
10633 * d-exp.y: Update all rules.
10635 * c-exp.y: Update all rules.
10636 (lex_one_token, classify_name, yylex, c_parse): Update.
10637 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10639 2019-04-04 Tom Tromey <tom@tromey.com>
10641 * gdbarch.h, gdbarch.c: Rebuild.
10642 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10644 (struct stap_parse_info): Replace "parser_state" with
10646 * parser-defs.h (struct expr_builder): Rename from "parser_state".
10647 (parser_state): New class.
10648 * parse.c (expr_builder): Rename.
10649 (expr_builder::release): Rename.
10650 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10651 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10652 (write_exp_elt_longcst, write_exp_elt_floatcst)
10653 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10654 (write_exp_string_vector, write_exp_bitstring)
10655 (write_exp_msymbol, mark_struct_expression)
10656 (write_dollar_variable)
10657 (insert_type_address_space, increase_expout_size): Replace
10658 "parser_state" with "expr_builder".
10659 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10660 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10661 "parser_state" with "expr_builder".
10663 2019-04-04 Tom Tromey <tom@tromey.com>
10665 * rust-exp.y: Replace "parse_language" with method call.
10667 (yylex): Replace "parse_language" with method call.
10669 (yylex): Replace "parse_language" with method call.
10670 * go-exp.y (classify_name): Replace "parse_language" with method
10672 * f-exp.y (yylex): Replace "parse_language" with method call.
10673 * d-exp.y (lex_one_token): Replace "parse_language" with method
10676 (lex_one_token, classify_name, yylex): Replace "parse_language"
10678 * ada-exp.y (find_primitive_type, type_char)
10679 (type_system_address): Replace "parse_language" with method call.
10681 2019-04-04 Tom Tromey <tom@tromey.com>
10683 * rust-exp.y: Replace "parse_gdbarch" with method call.
10684 * parse.c (write_dollar_variable, insert_type_address_space):
10685 Replace "parse_gdbarch" with method call.
10686 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10688 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10690 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10691 "parse_gdbarch" with method call.
10692 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10694 * f-exp.y (parse_type, parse_f_type, yylex): Replace
10695 "parse_gdbarch" with method call.
10696 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10697 "parse_gdbarch" with method call.
10698 * c-exp.y (parse_type, parse_number, classify_name): Replace
10699 "parse_gdbarch" with method call.
10700 * ada-lex.l: Replace "parse_gdbarch" with method call.
10701 * ada-exp.y (parse_type, find_primitive_type, type_char)
10702 (type_system_address): Replace "parse_gdbarch" with method call.
10704 2019-04-04 Tom Tromey <tom@tromey.com>
10706 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10707 * stap-probe.c (stap_parse_argument): Update.
10708 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10709 initial_size parameter.
10710 * rust-exp.y (rust_lex_tests): Update.
10711 * parse.c (parser_state): Update.
10712 (parse_exp_in_context): Update.
10713 * parser-defs.h (struct parser_state) <parser_state>: Remove
10714 "initial_size" parameter.
10716 2019-04-04 Tom Tromey <tom@tromey.com>
10718 * parser-defs.h (increase_expout_size): Don't declare.
10719 * parse.c (increase_expout_size): Now static.
10721 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
10723 * gnu-nat.c (gnu_nat_target::wait): Fix
10724 target_waitstatus_to_string call.
10726 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
10728 * eval.c (evaluate_subexp_standard): Handle internal functions
10729 during Fortran function call handling.
10731 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
10733 * NEWS: Mention new internal functions.
10734 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10735 (read_base_type): Use dwarf2_init_complex_target_type.
10736 * value.c (creal_internal_fn): New function.
10737 (cimag_internal_fn): New function.
10738 (_initialize_values): Register new internal functions.
10740 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10742 * infrun.c (stop_all_threads): If debug_infrun, always
10743 trace the wait status after wait_one, using
10744 target_waitstatus_to_string and target_pid_to_str.
10745 (handle_inferior_event): Replace various trace of
10746 wait status kind by a single trace.
10747 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10748 wait status kind image by target_waitstatus_to_string.
10749 * target/waitstatus.c (target_waitstatus_to_string): Fix
10752 2019-04-01 Tom Tromey <tromey@adacore.com>
10755 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10757 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
10758 Pedro Alves <palves@redhat.com>
10760 * top.c (quit_force): Call 'finalize_values'.
10761 * value.c (finalize_values): New function.
10762 * value.h (finalize_values): Declare.
10764 2019-03-30 Eli Zaretskii <eliz@gnu.org>
10766 * NEWS: Announce $_gdb_major and $_gdb_minor.
10768 * top.c (init_gdb_version_vars): New function.
10769 (gdb_init): Call init_gdb_version_vars.
10771 2019-03-29 Tom Tromey <tromey@adacore.com>
10773 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
10774 help text. Remove dead code.
10776 2019-03-29 Keith Seitz <keiths@redhat.com>
10778 From Siddhesh Poyarekar:
10779 * f-lang.h (f77_get_upperbound): Return LONGEST.
10780 (f77_get_lowerbound): Likewise.
10781 * f-typeprint.c (f_type_print_varspec_suffix): Expand
10782 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
10784 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
10785 plongest to format print it.
10786 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10787 (f77_get_upperbound): Likewise.
10788 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10789 LOWER_BOUND to LONGEST.
10790 (f77_create_arrayprint_offset_tbl): Likewise.
10792 2019-03-29 Keith Seitz <keiths@redhat.com>
10794 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10795 %s/pulongest for TYPE_LENGTH instead of %d in format
10797 * ada-typerint.c (ada_print_type): Likewise.
10798 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10799 * compile/compile-c-support.c (generate_register_struct): Likewise.
10800 * gdbtypes.c (recursive_dump_type): Likewise.
10801 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10802 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
10803 instead of %d in format strings.
10804 * riscv-tdep.c (riscv_type_alignment): Cast second argument
10805 to std::min to ULONGEST.
10806 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10807 instead of %d in format strings.
10808 * tracepoint.c (info_scope_command): Likewise.
10809 * typeprint.c (print_offset_data::update)
10810 (print_offset_data::finish): Likewise.
10811 * xtensa-tdep.c (xtensa_store_return_value)
10812 (xtensa_push_dummy_call): Likewise.
10814 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
10816 * windows-nat.c (display_selector): Fixed format specifications
10819 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10821 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10823 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
10825 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10826 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10827 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10828 (nios2_linux_init_abi): Install it.
10830 2019-03-28 Alan Hayward <alan.hayward@arm.com>
10832 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10834 2019-03-28 Alan Hayward <alan.hayward@arm.com>
10836 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10838 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10839 Tom Tromey <tromey@adacore.com>
10841 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10843 2019-03-26 Joel Brobecker <brobecker@adacore.com>
10845 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10846 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10847 method to compute the bounds of range types. Also print "[evaluated]"
10848 if the bounds' values come from a dynamic evaluation.
10850 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
10852 * cp-valprint.c (cp_print_value_fields): Don't print trailing
10853 whitespace when pretty printing is on.
10855 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10857 * ppc-linux-nat.c: Add include.
10859 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10861 * NEWS: Mention AArch64 Pointer Authentication.
10863 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10865 * arm-linux-nat.c: Add include.
10867 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
10869 * source-cache.c (source_cache::get_source_lines): Re-read
10870 fullname after calling open_source_file.
10872 2019-03-25 John Baldwin <jhb@FreeBSD.org>
10874 * NEWS: Mention TLS support for FreeBSD.
10876 2019-03-25 Tom Tromey <tromey@adacore.com>
10878 * minsyms.c (BUNCH_SIZE): Update comment.
10879 (~minimal_symbol_reader): Remove old comment.
10880 (compact_minimal_symbols): Update comment.
10881 (minimal_symbol_reader::install): Remove old comment. Update
10884 2019-03-25 Alan Hayward <alan.hayward@arm.com>
10886 * s390-linux-nat.c: Add include.
10888 2019-03-25 Alan Hayward <alan.hayward@arm.com>
10890 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10891 Call linux_get_hwcap.
10892 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10894 (aarch64_linux_get_hwcap): Remove function.
10895 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10897 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10899 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10900 * linux-tdep.c (linux_get_hwcap): Add function.
10901 (linux_get_hwcap2): Likewise.
10902 * linux-tdep.h (linux_get_hwcap): Add declaration.
10903 (linux_get_hwcap2): Likewise.
10904 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10905 (ppc_linux_get_hwcap2): Likewise.
10906 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10908 (ppc_linux_nat_target::insert_watchpoint): Likewise.
10909 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10910 (ppc_linux_nat_target::read_description): Likewise.
10911 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10912 * s390-linux-nat.c: Likewise.
10913 * s390-linux-tdep.c (s390_core_read_description): Likewise.
10915 2019-03-24 Tom Tromey <tom@tromey.com>
10917 * ada-lang.c (standard_lookup): Simplify initialization.
10918 (ada_lookup_symbol_nonlocal): Simplify return.
10919 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10920 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10921 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10922 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10924 * solib.c (solib_global_lookup): Simplify.
10925 * symtab.c (null_block_symbol): Remove.
10926 (symbol_cache_lookup): Simplify returns.
10927 (lookup_language_this): Simplify returns.
10928 (lookup_symbol_aux): Simplify return.
10929 (lookup_local_symbol): Simplify returns.
10930 (lookup_global_symbol_from_objfile): Simplify return.
10931 (lookup_symbol_in_objfile_symtabs)
10932 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10933 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10934 (lookup_static_symbol, lookup_global_symbol): Simplify return.
10935 * cp-namespace.c (cp_lookup_bare_symbol)
10936 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10937 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10938 (cp_lookup_nested_symbol): Don't use null_block_symbol.
10939 (cp_lookup_symbol_via_imports): Simplify initialization.
10940 (find_symbol_in_baseclass): Likewise.
10941 * symtab.h (null_block_symbol): Remove.
10942 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10943 (d_lookup_nested_symbol, d_lookup_symbol_imports)
10944 (d_lookup_symbol_module): Likewise.
10945 (find_symbol_in_baseclass): Simplify initialization.
10947 2019-03-24 Tom Tromey <tom@tromey.com>
10949 * expression.h: Don't include symtab.h.
10950 (struct block): Forward declare.
10952 2019-03-24 Tom Tromey <tom@tromey.com>
10954 * c-exp.y (typebase): Remove casts.
10955 * gdbtypes.c (lookup_unsigned_typename, )
10956 (lookup_signed_typename): Remove cast.
10957 * eval.c (parse_to_comma_and_eval): Remove cast.
10958 * parse.c (write_dollar_variable): Remove cast.
10959 * block.h (struct block) <superblock>: Now const.
10960 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10961 * psymtab.c (psym_map_matching_symbols): Make "block" const.
10962 (map_block): Make "block" const.
10963 * symfile.h (struct quick_symbol_functions)
10964 <map_matching_symbols>: Constify block argument to "callback".
10965 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10967 (find_pc_sect_compunit_symtab): Make "b" const.
10968 (find_symbol_at_address): Likewise.
10969 (search_symbols): Likewise.
10970 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10971 (dw2_debug_names_lookup_symbol): Likewise.
10972 (dw2_map_matching_symbols): Update.
10973 * p-valprint.c (pascal_val_print): Remove "block".
10974 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10975 (aux_add_nonlocal_symbols): Make "block" const.
10976 (resolve_subexp): Remove cast.
10977 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10979 (iterate_over_file_blocks): Likewise.
10980 * f-exp.y (%union) <bval>: Remove.
10981 * coffread.c (patch_opaque_types): Make "b" const.
10982 * spu-tdep.c (spu_catch_start): Make "block" const.
10983 * c-valprint.c (print_unpacked_pointer): Remove "block".
10984 * symmisc.c (dump_symtab_1): Make "b" const.
10985 (block_depth): Make "block" const.
10986 * d-exp.y (%union) <bval>: Remove.
10987 * cp-support.h (cp_lookup_rtti_type): Update.
10988 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10989 * psymtab.c (psym_lookup_symbol): Make "block" const.
10990 (maintenance_check_psymtabs): Make "b" const.
10991 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10992 (enumerate_locals, enumerate_args): Update.
10993 * python/py-symtab.c (stpy_global_block): Make "block" const.
10994 (stpy_static_block): Likewise.
10995 * inline-frame.c (block_starting_point_at): Make "new_block"
10997 * block.c (find_block_in_blockvector): Make return type const.
10998 (blockvector_for_pc_sect): Make "b" const.
10999 (find_block_in_blockvector): Make "b" const.
11001 2019-03-23 Tom Tromey <tom@tromey.com>
11003 * varobj.c (varobj_create): Update.
11004 * symfile.c (clear_symtab_users): Don't reset innermost_block.
11005 * printcmd.c (display_command, do_one_display): Don't reset
11007 * parser-defs.h (enum innermost_block_tracker_type): Move to
11009 (innermost_block): Update comment.
11010 * parse.c (parse_exp_1): Add tracker_types parameter.
11011 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
11012 tracker_types parameter. Reset innermost_block.
11013 (parse_exp_in_context): Remove.
11014 (parse_expression_for_completion): Update.
11015 * objfiles.c (~objfile): Don't reset expression_context_block or
11017 * expression.h (enum innermost_block_tracker_type): Move from
11019 (parse_exp_1): Add tracker_types parameter.
11020 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11021 reset innermost_block.
11023 2019-03-23 Tom Tromey <tom@tromey.com>
11025 * objfiles.h: Include bcache.h.
11027 2019-03-23 Tom Tromey <tom@tromey.com>
11029 * linespec.c (get_current_search_block): Use
11030 scoped_restore_current_language.
11031 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11033 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11034 Jiong Wang <jiong.wang@arm.com>
11036 * aarch64-linux-tdep.c
11037 (aarch64_linux_iterate_over_regset_sections): Check for pauth
11039 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11041 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11042 Jiong Wang <jiong.wang@arm.com>
11044 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11046 (aarch64_analyze_prologue_test): Add PACIASP test.
11047 (aarch64_prologue_prev_register): Unmask PC value.
11049 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11050 Jiong Wang <jiong.wang@arm.com>
11052 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11053 (aarch64_dwarf2_prev_register): Unmask PC value.
11054 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11055 (aarch64_execute_dwarf_cfa_vendor_op): Check for
11056 DW_CFA_AARCH64_negate_ra_state.
11057 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11059 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11060 Jiong Wang <jiong.wang@arm.com>
11062 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11064 (aarch64_pseudo_register_name): Likewise.
11065 (aarch64_pseudo_register_type): Likewise.
11066 (aarch64_pseudo_register_reggroup_p): Likewise.
11067 (aarch64_gdbarch_init): Add pauth registers.
11068 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11069 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11070 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11071 (struct gdbarch_tdep): Add regnum for ra_state.
11073 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11074 Jiong Wang <jiong.wang@arm.com>
11076 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11078 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11079 Jiong Wang <jiong.wang@arm.com>
11081 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11083 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11084 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11085 (aarch64_gdbarch_init): Add puth registers.
11086 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11087 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11088 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11090 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11091 Jiong Wang <jiong.wang@arm.com>
11093 * aarch64-linux-nat.c
11094 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11095 * aarch64-linux-tdep.c
11096 (aarch64_linux_core_read_description): Likewise.
11097 (aarch64_linux_get_hwcap): New function.
11098 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11099 (aarch64_linux_get_hwcap): New declaration.
11101 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11102 Jiong Wang <jiong.wang@arm.com>
11104 * aarch64-linux-nat.c
11105 (aarch64_linux_nat_target::read_description): Add pauth param.
11106 * aarch64-linux-tdep.c
11107 (aarch64_linux_core_read_description): Likewise.
11108 * aarch64-tdep.c (struct target_desc): Add in pauth.
11109 (aarch64_read_description): Add pauth param.
11110 (aarch64_gdbarch_init): Likewise.
11111 * aarch64-tdep.h (aarch64_read_description): Likewise.
11112 * arch/aarch64.c (aarch64_create_target_description): Likewise.
11113 * arch/aarch64.h (aarch64_create_target_description): Likewise.
11114 * features/Makefile: Add new files.
11115 * features/aarch64-pauth.c: New file.
11116 * features/aarch64-pauth.xml: New file.
11118 2019-03-20 Tom Tromey <tromey@adacore.com>
11120 * infrun.c (handle_inferior_event): Rename from
11121 handle_inferior_event_1. Create a scoped_value_mark.
11122 (handle_inferior_event): Remove.
11124 2019-03-19 Tom Tromey <tromey@adacore.com>
11126 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11127 * infrun.h (print_stop_event): Add "displays" parameter.
11128 * infrun.c (print_stop_event): Add "displays" parameter.
11130 2019-03-19 Pedro Alves <palves@redhat.com>
11132 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11133 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
11134 to -1. Fix TABs vs spaces.
11135 (tui_ui_out::tui_ui_out): Don't initialize fields here.
11136 * tui/tui-out.h (tui_ui_out) Add intro comments.
11137 <m_line, m_start_of_line>: In-class initialize, and add describing
11140 2019-03-18 Alan Hayward <alan.hayward@arm.com>
11142 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11144 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11146 2019-03-18 Pedro Alves <palves@redhat.com>
11147 Eli Zaretskii <eliz@gnu.org>
11149 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11150 m_line and m_start_of_line.
11152 2019-03-18 Eli Zaretskii <eliz@gnu.org>
11154 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11155 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11156 it returns a newline. This fixes a regression in TU mode, whereby
11157 the next line is output on the same screen line as the user input.
11159 2019-03-18 Tom Tromey <tromey@adacore.com>
11161 * minsyms.c (minimal_symbol_reader::install): Remove call to
11164 2019-03-18 Pedro Alves <palves@redhat.com>
11166 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11168 (apply_style): New, factored out from ...
11169 (apply_ansi_escape): ... this. Handle reverse video mode.
11170 (tui_set_reverse_mode): New function.
11171 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11172 * tui/tui-winsource.c (tui_show_source_line): Use
11173 tui_set_reverse_mode instead of setting A_STANDOUT.
11174 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11175 New setter methods.
11177 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
11179 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11182 2019-03-18 Tom Tromey <tromey@adacore.com>
11184 * ada-lang.c (empty_array): Add "high" parameter.
11185 (ada_evaluate_subexp): Update.
11187 2019-03-17 Sergei Trofimovich <siarheit@google.com>
11189 * unittests/string_view-selftests.c: Define
11190 _initialize_string_view_selftests unconditionally.
11192 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
11195 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11197 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
11200 * windows-nat.c (display_selector): Fix format specifiers.
11202 2019-03-17 Eli Zaretskii <eliz@gnu.org>
11204 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11205 tui_refill_source_window instead of tui_refresh_win, to update the
11206 current execution line. This fixes redisplay of the current line
11207 when stepping through the code with "next" or "step".
11209 2019-03-16 Eli Zaretskii <eliz@gnu.org>
11211 * source-cache.c (source_cache::get_source_lines): Call
11212 find_source_lines to initialize s->nlines. This fixes vertical
11213 scrolling of TUI source window when the DOWN arrow is pressed.
11215 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11217 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11218 linux-thread-db.c (_initialize_thread_db): Likewise.
11220 2019-03-16 Eli Zaretskii <eliz@gnu.org>
11222 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11223 wclrtoeol in tui_show_source_line". This reverts changes made in
11224 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11226 2019-03-15 Tom Tromey <tom@tromey.com>
11228 * symtab.h (struct minimal_symbol): Derive from
11229 general_symbol_info.
11230 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11231 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11232 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11233 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11234 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11235 (MSYMBOL_SEARCH_NAME): Update.
11236 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11237 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11238 * minsyms.c (minimal_symbol_reader::record_full): Update.
11240 2019-03-15 Tom Tromey <tom@tromey.com>
11242 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11244 2019-03-15 Tom Tromey <tom@tromey.com>
11246 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11247 unique_xmalloc_ptr.
11248 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11250 * minsyms.c (lookup_minimal_symbol_by_pc_section)
11251 (build_minimal_symbol_hash_tables)
11252 (minimal_symbol_reader::install): Update.
11254 2019-03-15 Tom Tromey <tom@tromey.com>
11256 * symtab.c (create_demangled_names_hash): Update.
11257 (symbol_set_names): Update.
11258 * objfiles.h (struct objfile_per_bfd_storage)
11259 <demangled_names_hash>: Now an htab_up.
11260 * objfiles.c (objfile_per_bfd_storage): Simplify.
11262 2019-03-15 Tom Tromey <tom@tromey.com>
11264 * objfiles.h (struct objfile_per_bfd_storage): Declare
11266 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11268 (get_objfile_bfd_data): Use new. Don't initialize
11270 (free_objfile_per_bfd_storage): Remove.
11271 (objfile_bfd_data_free, objfile::~objfile): Use delete.
11273 2019-03-15 Tom Tromey <tom@tromey.com>
11275 * symfile.c (reread_symbols): Update.
11276 * objfiles.c (objfile::objfile): Update.
11277 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11278 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11280 (minimal_symbol_reader::install): Update.
11281 (terminate_minimal_symbol_table): Remove.
11282 * jit.c (jit_object_close_impl): Update.
11284 2019-03-15 Tom Tromey <tom@tromey.com>
11286 * minsyms.c (minimal_symbol_reader::record_full): Remove some
11289 2019-03-15 Tom Tromey <tom@tromey.com>
11291 * objfiles.h (struct objfile_per_bfd_storage)
11292 <demangled_hash_languages>: Now a bitset.
11293 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11294 (lookup_minimal_symbol): Update.
11296 2019-03-15 Tom Tromey <tom@tromey.com>
11298 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11299 Don't return the symbol.
11300 * coffread.c (record_minimal_symbol): Use record_full.
11302 2019-03-14 Eli Zaretskii <eliz@gnu.org>
11304 The MS-Windows port of ncurses fails to switch to a color pair if
11305 one or both of the colors are the implicit default colors. This
11306 change records the default colors when TUI is initialized, and
11307 then specifies them explicitly when a color pair uses the default
11308 colors. This allows color styling in TUI mode on MS-Windows.
11310 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
11312 (tui_initialize_io) [__MINGW32__]: Record the default terminal
11313 colors in ncurses_norm_attr.
11314 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11315 "none", replace it with the default color recorded in
11318 2019-03-14 Tom Tromey <tromey@adacore.com>
11320 * source-cache.h (class source_cache) <get_source_lines>: Return
11322 * source-cache.c (source_cache::extract_lines): Handle case where
11323 first_pos==npos. Return std::string.
11324 (source_cache::get_source_lines): Update.
11326 2019-03-14 Tom Tromey <tromey@adacore.com>
11328 * NEWS: Add item for "style sources" commands.
11329 * source-cache.c (source_cache::get_source_lines): Check
11331 * cli/cli-style.c (source_styling): New global.
11332 (_initialize_cli_style): Add "style sources" commands.
11333 (show_style_sources): New function.
11334 * cli/cli-style.h (source_styling): Declare.
11336 2019-03-14 Pedro Alves <palves@redhat.com>
11337 Tom Tromey <tromey@adacore.com>
11339 * tui/tui-winsource.h (tui_refill_source_window): Declare.
11340 * tui/tui-winsource.c (tui_refill_source_window): New function,
11342 (tui_horizontal_source_scroll): ... here. Move some logic.
11343 * cli/cli-style.c (set_style_enabled): Notify new observable.
11344 * tui/tui-hooks.c (tui_redisplay_source): New function.
11345 (tui_attach_detach_observers): Attach or detach
11346 tui_redisplay_source.
11347 * observable.h (source_styling_changed): New observable.
11348 * observable.c: Define source_styling_changed observable.
11350 2019-03-13 Tom Tromey <tromey@adacore.com>
11352 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11353 (i386_gnu_nat_target::store_registers): Update.
11354 * target-debug.h (target_debug_print_std_string): New macro.
11355 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11356 * windows-tdep.c (display_one_tib): Update.
11357 * tui/tui-stack.c (tui_make_status_line): Update.
11358 * top.c (print_inferior_quit_action): Update.
11359 * thread.c (thr_try_catch_cmd): Update.
11360 (add_thread_with_info): Update.
11361 (thread_target_id_str): Update.
11362 (thr_try_catch_cmd): Update.
11363 (thread_command): Update.
11364 (thread_find_command): Update.
11365 * record-btrace.c (record_btrace_target::info_record)
11366 (record_btrace_resume_thread, record_btrace_target::resume)
11367 (record_btrace_cancel_resume, record_btrace_step_thread)
11368 (record_btrace_target::wait, record_btrace_target::wait)
11369 (record_btrace_target::wait, record_btrace_target::stop): Update.
11370 * progspace.c (print_program_space): Update.
11371 * process-stratum-target.c
11372 (process_stratum_target::thread_address_space): Update.
11373 * linux-fork.c (linux_fork_mourn_inferior)
11374 (detach_checkpoint_command, info_checkpoints_command)
11375 (linux_fork_context): Update.
11376 (linux_fork_detach): Update.
11377 (class scoped_switch_fork_info): Update.
11378 (delete_checkpoint_command): Update.
11379 * infrun.c (follow_fork_inferior): Update.
11380 (follow_fork_inferior): Update.
11381 (proceed_after_vfork_done): Update.
11382 (handle_vfork_child_exec_or_exit): Update.
11383 (follow_exec): Update.
11384 (displaced_step_prepare_throw): Update.
11385 (displaced_step_restore): Update.
11386 (start_step_over): Update.
11387 (resume_1): Update.
11388 (clear_proceed_status_thread): Update.
11390 (print_target_wait_results): Update.
11391 (do_target_wait): Update.
11392 (context_switch): Update.
11393 (stop_all_threads): Update.
11394 (restart_threads): Update.
11395 (finish_step_over): Update.
11396 (handle_signal_stop): Update.
11397 (switch_back_to_stepped_thread): Update.
11398 (keep_going_pass_signal): Update.
11399 (print_exited_reason): Update.
11400 (normal_stop): Update.
11401 * inferior.c (inferior_pid_to_str): Change return type.
11402 (print_selected_inferior): Update.
11403 (add_inferior): Update.
11404 (detach_inferior): Update.
11405 * dummy-frame.c (fprint_dummy_frames): Update.
11406 * dcache.c (dcache_info_1): Update.
11407 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11408 (btrace_fetch, btrace_clear): Update.
11409 * linux-tdep.c (linux_core_pid_to_str): Change return type.
11410 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11412 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11413 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11414 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11415 * gdbarch.c, gdbarch.h: Rebuild.
11416 * gdbarch.sh (core_pid_to_str): Change return type.
11417 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11419 (windows_nat_target::pid_to_str): Change return type.
11420 (windows_delete_thread): Update.
11421 (windows_nat_target::attach): Update.
11422 (windows_nat_target::files_info): Update.
11423 * target-delegates.c: Rebuild.
11424 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11426 (sol_thread_target::pid_to_str): Change return type.
11427 * remote.c (class remote_target) <pid_to_str>: Change return
11429 (remote_target::pid_to_str): Change return type.
11430 (extended_remote_target::attach, remote_target::remote_stop_ns)
11431 (remote_target::remote_notif_remove_queued_reply)
11432 (remote_target::push_stop_reply, remote_target::disable_btrace):
11434 (extended_remote_target::attach): Update.
11435 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11437 (gdbsim_target::pid_to_str): Change return type.
11438 * ravenscar-thread.c (struct ravenscar_thread_target)
11439 <pid_to_str>: Change return type.
11440 (ravenscar_thread_target::pid_to_str): Change return type.
11441 * procfs.c (class procfs_target) <pid_to_str>: Change return
11443 (procfs_target::pid_to_str): Change return type.
11444 (procfs_target::attach): Update.
11445 (procfs_target::detach): Update.
11446 (procfs_target::fetch_registers): Update.
11447 (procfs_target::store_registers): Update.
11448 (procfs_target::wait): Update.
11449 (procfs_target::files_info): Update.
11450 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11451 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11453 (nto_procfs_target::pid_to_str): Change return type.
11454 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11455 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11457 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11458 (exit_lwp): Update.
11459 (attach_proc_task_lwp_callback, get_detach_signal)
11460 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11461 (linux_nat_target::resume, wait_lwp, stop_callback)
11462 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11463 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11464 (linux_nat_wait_1, resume_stopped_resumed_lwps)
11465 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11466 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11468 (inf_ptrace_target::attach): Update.
11469 (inf_ptrace_target::files_info): Update.
11470 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11472 (go32_nat_target::pid_to_str): Change return type.
11473 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11474 (gnu_nat_target::wait): Update.
11475 (gnu_nat_target::wait): Update.
11476 (gnu_nat_target::resume): Update.
11477 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11478 (fbsd_nat_target::wait): Update.
11479 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11481 (darwin_nat_target::attach): Update.
11482 * corelow.c (class core_target) <pid_to_str>: Change return type.
11483 (core_target::pid_to_str): Change return type.
11484 * target.c (normal_pid_to_str): Change return type.
11485 (default_pid_to_str): Likewise.
11486 (target_pid_to_str): Change return type.
11487 (target_translate_tls_address): Update.
11488 (target_announce_detach): Update.
11489 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11491 (bsd_uthread_target::pid_to_str): Change return type.
11492 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11494 (bsd_kvm_target::pid_to_str): Change return type.
11495 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11497 (aix_thread_target::pid_to_str): Change return type.
11498 * target.h (struct target_ops) <pid_to_str>: Change return type.
11499 (target_pid_to_str, normal_pid_to_str): Likewise.
11500 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11502 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11504 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11506 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11508 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11510 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11513 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
11515 * NEWS: Mention that the new default MI version is 3. Mention
11516 changes to the output of commands and events that deal with
11517 multi-location breakpoints.
11518 * breakpoint.c: Include "mi/mi-out.h".
11519 (print_one_breakpoint): Change output syntax if using MI version
11521 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11523 (mi_multi_location_breakpoint_output_fixed): New.
11524 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11525 (mi_cmd_fix_multi_location_breakpoint_output): New.
11526 (mi_multi_location_breakpoint_output_fixed): New.
11527 * mi/mi-cmds.c (mi_cmds): Register command
11528 -fix-multi-location-breakpoint-output.
11529 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11532 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
11534 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11535 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11536 instantiate mi_ui_out based on interpreter name.
11537 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11538 * mi/mi-main.c (mi_load_progress): Likewise.
11540 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11542 * NEWS: Combine separate "New targets" sections for 8.3.
11544 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11546 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11547 (ppcfbsd_init_abi): Install gdbarch
11548 "fetch_tls_load_module_address" and "get_thread_local_address"
11551 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11553 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11554 (riscv_fbsd_init_abi): Install gdbarch
11555 "fetch_tls_load_module_address" and "get_thread_local_address"
11558 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11560 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11561 (i386fbsd_init_abi): Install gdbarch
11562 "fetch_tls_load_module_address" and "get_thread_local_address"
11565 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11567 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11568 (amd64fbsd_init_abi): Install gdbarch
11569 "fetch_tls_load_module_address" and "get_thread_local_address"
11572 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11574 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11575 (struct fbsd_pspace_data): New type.
11576 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11577 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11578 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11579 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11580 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11582 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11584 * gdbtypes.c (lookup_struct_elt): New function.
11585 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11586 * gdbtypes.h (struct struct_elt): New type.
11587 (lookup_struct_elt): New prototype.
11589 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11591 * gdbtypes.c (lookup_struct_elt_type): Update comment and
11592 remove disabled code block.
11594 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11596 * gdbarch.sh (get_thread_local_address): New method.
11597 * gdbarch.h, gdbarch.c: Regenerate.
11598 * target.c (target_translate_tls_address): Use
11599 gdbarch_get_thread_local_address if present instead of
11600 target::get_thread_local_address.
11602 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11604 * target.h (target::get_thread_local_address): Update comment.
11606 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11608 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11609 objfile->separate_debug_objfile_backlink if not NULL.
11611 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11613 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11614 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11615 (amd64bsd_store_inferior_registers): Likewise.
11616 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11617 Enable segment base registers.
11618 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11619 PT_GETFSBASE and PT_GETGSBASE.
11620 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11622 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11623 segment base registers.
11624 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11626 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11628 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11629 Update calls to i386_target_description to add 'segments'
11631 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
11632 add segment base registers.
11633 * arch/i386.c (i386_create_target_description): Add 'segments'
11634 parameter to enable segment base registers.
11635 * arch/i386.h (i386_create_target_description): Likewise.
11636 * features/i386/32bit-segments.xml: New file.
11637 * features/i386/32bit-segments.c: Generate.
11638 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11639 call to i386_target_description to add 'segments' parameter.
11640 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11641 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11642 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11643 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11644 if feature is present.
11645 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11646 Add 'segments' parameter to call to i386_target_description.
11647 (i386_target_description): Add 'segments' parameter to enable
11648 segment base registers.
11649 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11650 to call to i386_target_description.
11651 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11652 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11653 Define I386_NUM_REGS.
11654 (i386_target_description): Add 'segments' parameter to enable
11655 segment base registers.
11657 2019-03-12 Eli Zaretskii <eliz@gnu.org>
11660 * source-cache.c: #undef open and close, to avoid unresolved
11661 externals during linking.
11663 2019-03-12 Tom Tromey <tromey@adacore.com>
11665 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11666 const. Add initializers.
11667 (_initialize_remote): Don't initialize ptid globals.
11669 2019-03-12 Pedro Alves <palves@redhat.com>
11671 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11673 2019-03-12 Pedro Alves <palves@redhat.com>
11675 * cp-name-parser.y (main): Remove unused 'len' variable.
11677 2019-03-12 Tom Tromey <tromey@adacore.com>
11679 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11680 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11682 2019-03-12 Tom Tromey <tromey@adacore.com>
11684 * linux-nat.c (iterate_over_lwps): Update.
11685 (stop_callback): Remove parameter.
11686 (stop_wait_callback, detach_callback, resume_set_callback)
11687 (select_singlestep_lwp_callback, set_ignore_sigint)
11688 (status_callback, resumed_callback, resume_clear_callback)
11689 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11691 (linux_nat_target::detach, linux_nat_target::resume)
11692 (linux_stop_and_wait_all_lwps, select_event_lwp)
11693 (linux_nat_filter_event, linux_nat_wait_1)
11694 (linux_nat_target::kill, linux_nat_target::stop)
11695 (linux_nat_target::stop): Update.
11696 (linux_nat_resume_callback): Change type.
11697 (resume_stopped_resumed_lwps, count_events_callback)
11698 (select_event_lwp_callback): Likewise.
11699 (linux_stop_lwp, linux_nat_stop_lwp): Update.
11700 * arm-linux-nat.c (struct update_registers_data): Remove.
11701 (update_registers_callback): Change type.
11702 (arm_linux_insert_hw_breakpoint1): Update.
11703 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11705 (x86_linux_dr_set_addr): Update.
11706 (x86_linux_dr_set_control): Update.
11707 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11708 (iterate_over_lwps): Use gdb::function_view.
11709 * nat/aarch64-linux-hw-point.c (struct
11710 aarch64_dr_update_callback_param): Remove.
11711 (debug_reg_change_callback): Change type.
11712 (aarch64_notify_debug_reg_change): Update.
11713 * s390-linux-nat.c (s390_refresh_per_info): Update.
11715 2019-03-11 Tom Tromey <tromey@adacore.com>
11717 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11718 redundant assignment to "this_cu".
11720 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11722 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11724 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11726 * gdbtypes.c (rank_one_type_parm_set): New function extracted
11728 (rank_one_type): ... this.
11730 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11732 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11734 (rank_one_type): ... this.
11736 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11738 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11740 (rank_one_type): ... this.
11742 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11744 * gdbtypes.c (rank_one_type_parm_float): New function extracted
11746 (rank_one_type): ... this.
11748 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11750 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11752 (rank_one_type): ... this.
11754 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11756 * gdbtypes.c (rank_one_type_parm_range): New function extracted
11758 (rank_one_type): ... this.
11760 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11762 * gdbtypes.c (rank_one_type_parm_char): New function extracted
11764 (rank_one_type): ... this.
11766 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11768 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11770 (rank_one_type): ... this.
11772 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11774 * gdbtypes.c (rank_one_type_parm_int): New function extracted
11776 (rank_one_type): ... this.
11778 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11780 * gdbtypes.c (rank_one_type_parm_func): New function extracted
11782 (rank_one_type): ... this.
11784 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11786 * gdbtypes.c (rank_one_type_parm_array): New function extracted
11788 (rank_one_type): ... this.
11790 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11792 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11794 (rank_one_type): ... this.
11796 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11798 * inferior.c (initialize_inferiors): Ensure 'help set/show print
11799 inferior-events' shows the example events.
11801 2019-03-08 Eli Zaretskii <eliz@gnu.org>
11803 Support styling on native MS-Windows console
11806 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11807 on MS-Windows if $TERM is not defined.
11809 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11811 * posix-hdep.c (gdb_console_fputs):
11812 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11814 * ui-file.h (gdb_console_fputs): Add prototype.
11816 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11817 back to fputs only if the former returns zero.
11819 2019-03-07 Tom Tromey <tom@tromey.com>
11821 * symmisc.c (print_symbol_bcache_statistics): Update.
11822 (print_objfile_statistics): Update.
11823 * symfile.c (allocate_symtab): Update.
11824 * stabsread.c: Don't include bcache.h.
11825 * psymtab.h (struct psymbol_bcache): Don't declare.
11826 (class psymtab_storage) <psymbol_cache>: Now a bcache.
11827 (psymbol_bcache_init, psymbol_bcache_free)
11828 (psymbol_bcache_get_bcache): Don't declare.
11829 * psymtab.c (struct psymbol_bcache): Remove.
11830 (psymtab_storage::psymtab_storage): Update.
11831 (psymtab_storage::~psymtab_storage): Update.
11832 (psymbol_bcache_init, psymbol_bcache_free)
11833 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11834 (add_psymbol_to_bcache): Update.
11835 (allocate_psymtab): Update.
11836 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11837 macro_cache>: No longer pointers.
11838 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11839 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11840 * macrotab.c (macro_bcache): Update.
11841 * macroexp.c: Don't include bcache.h.
11842 * gdbtypes.c (check_types_worklist): Update.
11843 (types_deeply_equal): Remove TRY/CATCH. Update.
11844 * elfread.c (elf_symtab_read): Update.
11845 * dwarf2read.c: Don't include bcache.h.
11846 * buildsym.c (buildsym_compunit::get_macro_table): Update.
11847 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11848 (print_bcache_statistics, bcache_memory_used): Don't declare.
11849 (struct bcache): Move from bcache.c. Add constructor, destructor,
11850 methods. Rename all data members.
11851 * bcache.c (struct bcache): Move to bcache.h.
11852 (bcache::expand_hash_table): Rename from expand_hash_table.
11854 (bcache::insert): Rename from bcache_full.
11855 (bcache::compare): Rename from bcache_compare.
11856 (bcache_xmalloc): Remove.
11857 (bcache::~bcache): Rename from bcache_xfree.
11858 (bcache::print_statistics): Rename from print_bcache_statistics.
11859 (bcache::memory_used): Rename from bcache_memory_used.
11861 2019-03-07 Pedro Alves <palves@redhat.com>
11863 * infrun.c (normal_stop): Also check for
11864 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11866 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
11868 * f-lang.c (value_from_host_double): Moved to...
11869 * value.c (value_from_host_double): ...here.
11870 * value.h (value_from_host_double): Declare.
11871 * guile/scm-math.c (vlscm_convert_typed_number): Use
11872 value_from_host_double.
11873 (vlscm_convert_number): Likewise.
11874 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11875 * python/py-value.c (convert_value_from_python): Likewise.
11877 2019-03-06 Tom Tromey <tom@tromey.com>
11879 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11881 2019-03-06 Tom Tromey <tom@tromey.com>
11883 * utils.h (free_current_contents): Don't declare.
11884 * utils.c (free_current_contents): Remove.
11886 2019-03-06 Tom Tromey <tom@tromey.com>
11888 * top.c (quit_force): Update.
11889 * main.c (captured_command_loop): Update.
11890 * common/new-op.c (operator new): Update.
11891 * common/common-exceptions.c (struct catcher)
11892 <save_cleanup_chain>: Remove member.
11893 (exceptions_state_mc_init): Update.
11894 (exception_try_scope_entry): Return nullptr.
11895 (exception_try_scope_exit, exception_rethrow)
11896 (throw_exception_sjlj, throw_exception_cxx): Update.
11897 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11898 (all_cleanups, do_cleanups, discard_cleanups)
11899 (discard_final_cleanups, save_cleanups, save_final_cleanups)
11900 (restore_cleanups, restore_final_cleanups): Don't declare.
11901 (do_final_cleanups): Remove parameter.
11902 * common/cleanups.c (cleanup_chain, make_cleanup)
11903 (make_cleanup_dtor, all_cleanups, do_cleanups)
11904 (discard_my_cleanups, discard_cleanups)
11905 (discard_final_cleanups, save_my_cleanups, save_cleanups)
11906 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11907 (null_cleanup): Remove.
11908 (do_final_cleanups): Remove parameter.
11910 2019-03-06 Tom Tromey <tom@tromey.com>
11912 * remote.c (remote_target::remote_parse_stop_reply): Use
11913 unique_xmalloc_ptr.
11915 2019-03-06 Tom Tromey <tom@tromey.com>
11917 * stabsread.c (struct stabs_field_info): Rename from field_info.
11918 <list, fnlist>: Add initializers.
11919 <obstack>: New member.
11920 (read_member_functions, read_struct_fields, read_baseclasses):
11921 Allocate on obstack. Don't use cleanups.
11922 (read_one_struct_field, read_member_functions, read_struct_fields)
11923 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11924 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11925 (read_struct_type): Update.
11927 2019-03-06 Tom Tromey <tom@tromey.com>
11929 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11930 * common/filestuff.h (make_cleanup_close): Don't declare.
11931 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11934 2019-03-06 Tom Tromey <tom@tromey.com>
11936 * solib-aix.c: Use make_scope_exit.
11938 2019-03-06 Tom Tromey <tom@tromey.com>
11940 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11941 Use make_scope_exit.
11943 2019-03-06 Tom Tromey <tom@tromey.com>
11945 * solib-svr4.c (disable_probes_interface): Remove parameter.
11946 (svr4_handle_solib_event): Use make_scope_exit.
11948 2019-03-06 Tom Tromey <tom@tromey.com>
11950 * remote.c (struct stop_reply_deleter): Remove.
11951 (stop_reply_up): Update.
11952 (struct stop_reply): Derive from notif_event. Don't typedef.
11953 <regcache>: Now a std::vector.
11954 (stop_reply_xfree): Remove.
11955 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11956 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
11957 (remote_target::discard_pending_stop_replies): Use delete.
11958 (remote_target::remote_parse_stop_reply): Update.
11959 (remote_target::process_stop_reply): Update.
11960 * remote-notif.h (struct notif_event): Add virtual destructor.
11961 Remove "dtr" member.
11962 (struct notif_client) <alloc_event>: Return a unique_ptr.
11963 (notif_event_xfree): Don't declare.
11964 (notif_event_up): New typedef.
11965 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11966 (notif_event_xfree, do_notif_event_xfree): Remove.
11967 (remote_notif_state_xfree): Update.
11969 2019-03-06 Tom Tromey <tom@tromey.com>
11971 * infrun.c (displaced_step_clear_cleanup): Now a
11972 forward_scope_exit type.
11973 (displaced_step_prepare_throw): Update.
11974 (displaced_step_fixup): Update.
11976 2019-03-06 Tom Tromey <tom@tromey.com>
11978 * inferior.h (class inferior): Update comment.
11979 * gdbthread.h (class thread_info): Update comment.
11981 2019-03-06 Joel Brobecker <brobecker@adacore.com>
11982 Tom Tromey <tom@tromey.com>
11984 * stabsread.h (struct stab_section_list): Remove.
11985 (coffstab_build_psymtabs): Update.
11986 * dbxread.c (symbuf_sections): Now a std::vector.
11987 (sect_idx): New global.
11988 (fill_symbuf): Update.
11989 (coffstab_build_psymtabs): Change type of stabsects parameter.
11991 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11993 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11994 (coff_locate_sections): Update.
11995 (coff_symfile_read): Remove cleanups. Update.
11996 (init_stringtab): Add storage parameter.
11997 (free_stringtab, free_stringtab_cleanup): Remove.
11998 (init_lineno): Add storage parameter.
11999 (free_linetab, free_linetab_cleanup): Remove.
12001 2019-03-06 Pedro Alves <palves@redhat.com>
12003 * linux-fork.c (fork_info::clobber_regs): Delete.
12004 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12005 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
12007 (scoped_switch_fork_info::scoped_switch_fork_info)
12008 (checkpoint_command, linux_fork_context): Adjust
12009 fork_save_infrun_state calls.
12011 2019-03-06 Pedro Alves <palves@redhat.com>
12013 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12014 (inf_has_multiple_threads): Return 'bool' and rewrite using
12015 inferior_info::threads().
12017 2019-03-06 Pedro Alves <palves@redhat.com>
12019 * linux-fork.c: Include <list>.
12020 (fork_list): Now a std::list instance.
12021 (fork_info): Add ctor, dtor, and in-class initialize all fields.
12022 (forks_exist_p, find_last_fork): Adjust.
12023 (new_fork): Delete.
12025 (add_fork): Adjust.
12026 (free_fork): Delete, folded into fork_info::~fork_info().
12027 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12029 (init_fork_list): Delete.
12030 (linux_fork_killall, linux_fork_mourn_inferior)
12031 (linux_fork_detach, info_checkpoints_command): Adjust.
12032 (_initialize_linux_fork): No longer call init_fork_list.
12034 2019-03-06 Pedro Alves <palves@redhat.com>
12036 * linux-fork.c (new_fork): New, split out of ...
12037 (add_fork): ... this. Return void. Move "first fork" special
12038 case from here, to ...
12039 (checkpoint_command): ... here.
12040 * linux-linux.h (add_fork): Return void.
12042 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12044 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12046 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12047 Chris January <chris.january@arm.com>
12048 David Lecomber <david.lecomber@arm.com>
12050 * f-exp.y: New token, UNOP_INTRINSIC.
12051 (exp): New pattern using UNOP_INTRINSIC token.
12052 (f77_keywords): Add 'abs' keyword.
12053 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12054 (value_from_host_double): New function.
12055 (evaluate_subexp_f): Support UNOP_ABS.
12057 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12059 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12062 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12064 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12065 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12066 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12068 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12070 * f-exp.y (convert_to_kind_type): Handle more type kinds.
12072 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12073 Chris January <chris.january@arm.com>
12075 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12076 * f-exp.y: Define 'KIND' token.
12077 (exp): New pattern for KIND expressions.
12078 (ptype): Handle types with a kind extension.
12079 (direct_abs_decl): Extend to spot kind extensions.
12080 (f77_keywords): Add 'kind' to the list.
12081 (push_kind_type): New function.
12082 (convert_to_kind_type): New function.
12083 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12084 * parse.c (operator_length_standard): Likewise.
12085 * parser-defs.h (enum type_pieces): Add tp_kind.
12086 * std-operator.def: Add UNOP_KIND.
12088 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12090 * f-exp.y (f_parse): Set yydebug.
12092 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12094 * f-lang.c (evaluate_subexp_f): New function.
12095 (exp_descriptor_f): New global.
12096 (f_language_defn): Use exp_descriptor_f instead of
12097 exp_descriptor_standard.
12099 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12101 * f-exp.y (struct token): Add comments.
12102 (dot_ops): Remove uppercase versions and the end marker.
12103 (f77_keywords): Likewise.
12104 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12105 entries in the dot_ops array are case insensitive, and use
12106 strncasecmp to compare strings. Also some whitespace cleanup in
12107 this area. Similar for the f77_keywords array, except entries in
12108 this list might be case sensitive.
12110 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12112 * f-exp.y (struct f77_boolean_val): Add comments.
12113 (boolean_values): Remove uppercase versions, and end marker.
12114 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12115 and use strncasecmp to achieve case insensitivity. Additionally,
12116 perform whitespace cleanup around this code.
12118 2019-03-06 Tom Tromey <tromey@adacore.com>
12120 * remote-sim.c (gdbsim_target_open): Use result of
12123 2019-03-06 Richard Bunt <richard.bunt@arm.com>
12124 Dirk Schubert <dirk.schubert@arm.com>
12125 Chris January <chris.january@arm.com>
12127 * eval.c (evaluate_subexp_standard): Call Fortran argument
12129 * f-lang.c (struct value): A value which can be passed into a
12130 Fortran function call.
12131 (fortran_argument_convert): Wrap Fortran arguments in a pointer
12133 (struct type): Value ready for a Fortran function call.
12134 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12136 * f-lang.h (fortran_argument_convert): Declaration.
12137 (fortran_preserve_arg_pointer): Declaration.
12138 * infcall.c (value_arg_coerce): Call Fortran argument logic.
12140 2019-03-05 Tom Tromey <tromey@adacore.com>
12142 * python/py-prettyprint.c (print_string_repr): Remove #if.
12143 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12145 2019-03-05 Tom Tromey <tromey@adacore.com>
12147 * target.c (the_dummy_target): Move later. Change type to
12149 (initialize_targets): Don't initialize the_dummy_target.
12151 2019-03-05 Tom Tromey <tromey@adacore.com>
12153 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12154 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12156 2019-03-05 Tom Tromey <tromey@adacore.com>
12158 * windows-nat.c (windows_nat_target::attach)
12159 (windows_nat_target::detach): Don't call gdb_flush.
12160 * valprint.c (generic_val_print, val_print, val_print_string):
12161 Don't call gdb_flush.
12162 * utils.c (defaulted_query): Don't call gdb_flush.
12163 * typeprint.c (print_type_scalar): Don't call gdb_flush.
12164 * target.c (target_announce_detach): Don't call gdb_flush.
12165 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12166 * remote.c (extended_remote_target::attach): Don't call
12168 * procfs.c (procfs_target::detach): Don't call gdb_flush.
12169 * printcmd.c (do_examine): Don't call gdb_flush.
12170 (info_display_command): Don't call gdb_flush.
12171 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12172 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12173 * memattr.c (info_mem_command): Don't call gdb_flush.
12174 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12175 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12176 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12177 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12178 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12179 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12180 (gnu_nat_target::detach): Don't call gdb_flush.
12181 * f-valprint.c (f_val_print): Don't call gdb_flush.
12182 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12183 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12184 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12186 * c-valprint.c (c_val_print): Don't call gdb_flush.
12187 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12189 2019-03-05 Tom Tromey <tromey@adacore.com>
12191 * varobj.c (update_dynamic_varobj_children): Update.
12192 (install_default_visualizer): Use reset, not release.
12193 * value.c (set_internalvar): Update.
12194 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12195 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12196 ATTRIBUTE_UNUSED_RESULT.
12198 2019-03-05 Tom Tromey <tromey@adacore.com>
12200 * remote.c (class scoped_remote_fd) <release>: Add
12201 ATTRIBUTE_UNUSED_RESULT.
12203 2019-03-05 Tom Tromey <tromey@adacore.com>
12205 * macroexp.c (struct macro_buffer) <release>: Add
12206 ATTRIBUTE_UNUSED_RESULT.
12208 2019-03-05 Tom Tromey <tromey@adacore.com>
12210 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12211 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12212 ATTRIBUTE_UNUSED_RESULT.
12214 2019-03-05 Tom Tromey <tromey@adacore.com>
12216 * common/scoped_fd.h (class scoped_fd) <release>: Add
12217 ATTRIBUTE_UNUSED_RESULT.
12219 2019-03-05 Tom Tromey <tromey@adacore.com>
12221 * parser-defs.h (struct parser_state) <release>: Add
12222 ATTRIBUTE_UNUSED_RESULT.
12224 2019-03-05 Tom Tromey <tromey@adacore.com>
12226 * utils.h (class gdb_argv) <release>: Add
12227 ATTRIBUTE_UNUSED_RESULT.
12228 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12230 2019-03-02 Eli Zaretskii <eliz@gnu.org>
12232 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12233 for-loop range, to avoid compiler warnings.
12235 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12236 avoid compiler warnings about unused variables.
12238 * NEWS: Mention end of support for native debugging on MS-Windows
12242 * common/netstuff.c:
12243 * gdbserver/gdbreplay.c
12244 * gdbserver/remote-utils.c:
12246 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12247 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
12248 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12249 'getaddrinfo' and 'freeaddrinfo' were not available before
12250 Windows XP, and mingw.org's MinGW headers by default define
12251 _WIN32_WINNT to 0x500.
12253 2019-03-01 Gary Benson <gbenson@redhat.com>
12255 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12257 2019-02-28 Brian Vandenberg <phantall@gmail.com>
12258 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
12261 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12262 set_sigint_trap, clear_sigint_trap.
12264 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12266 * target.c (target_detach): Clear the regcache and the
12269 2019-02-27 Pedro Alves <palves@redhat.com>
12271 * utils.c (set_screen_size): When we cap the height/width sizes,
12272 tweak the corresponding command variable to show "unlimited":
12274 2019-02-27 Saagar Jha <saagar@saagarjha.com>
12275 Pedro Alves <palves@redhat.com>
12277 * utils.c (set_screen_size): Reduce "infinite" rows and columns
12278 before calling rl_set_screen_size.
12280 2019-02-27 Tom Tromey <tromey@adacore.com>
12282 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12284 * python/py-value.c: Remove Python 2.4 workaround.
12285 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12287 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12288 Python 2.4 workaround.
12289 * python/python-internal.h: Remove Python 2.4 comment.
12290 (Py_ssize_t): Don't define.
12291 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12292 (gdb_Py_DECREF): Remove Python 2.4 workaround.
12293 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12294 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12295 * python/python.c (do_start_initialization): Remove Python 2.4
12297 * python/py-prettyprint.c (class dummy_python_frame): Remove.
12298 (print_children): Remove Python 2.4 workaround.
12299 * python/py-inferior.c (buffer_procs): Remove Python 2.4
12301 (CHARBUFFERPROC_NAME): Remove.
12302 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12303 Python 2.4 workaround.
12305 2019-02-27 Kevin Buettner <kevinb@redhat.com>
12307 * NEWS: Note minimum Python version.
12309 2019-02-27 Kevin Buettner <kevinb@redhat.com>
12311 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12312 code from these functions. Remove corresponding ifdefs. Use
12313 Py_buffer_up instead of explicit calls to PyBuffer_Release.
12314 Remove gotos and target of gotos.
12315 (infpy_search_memory): Likewise.
12317 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12319 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12320 (hppa_gdbarch_init): Don't register deleted functions with
12323 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12325 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12326 (h8300_unwind_sp): Delete.
12327 (h8300_dummy_id): Delete.
12328 (h8300_gdbarch_init): Don't register deleted functions with
12331 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12333 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12334 (ft32_unwind_pc): Delete.
12335 (ft32_unwind_sp): Delete.
12336 (ft32_gdbarch_init): Don't register deleted functions with
12339 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12341 * gdb/frv-tdep.c (frv_dummy_id): Delete.
12342 (frv_unwind_pc): Delete.
12343 (frv_unwind_sp): Delete.
12344 (frv_gdbarch_init): Don't register deleted functions with
12347 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12349 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12350 (riscv_unwind_pc): Delete.
12351 (riscv_unwind_sp): Delete.
12352 (riscv_gdbarch_init): Don't register deleted functions with
12355 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12357 * gdb/csky-tdep.c (csky_dummy_id): Delete.
12358 (csky_unwind_pc): Delete.
12359 (csky_unwind_sp): Delete.
12360 (csky_gdbarch_init): Don't register deleted functions with
12363 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12365 * gdb/cris-tdep.c (cris_dummy_id): Delete.
12366 (cris_unwind_pc): Delete.
12367 (cris_unwind_sp): Delete.
12368 (cris_gdbarch_init): Don't register deleted functions with
12371 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12373 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12374 (bfin_unwind_pc): Delete.
12375 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12377 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12379 * gdb/arm-tdep.c (arm_dummy_id): Delete.
12380 (arm_unwind_pc): Delete.
12381 (arm_unwind_sp): Delete.
12382 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12384 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12386 * gdb/arc-tdep.c (arc_dummy_id): Delete.
12387 (arc_unwind_pc): Delete.
12388 (arc_unwind_sp): Delete.
12389 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12391 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12393 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12394 (alpha_unwind_pc): Delete.
12395 (alpha_gdbarch_init): Don't register deleted functions with
12398 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12400 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12401 (aarch64_unwind_pc): Delete.
12402 (aarch64_unwind_sp): Delete.
12403 (aarch64_gdbarch_init): Don't register deleted functions with
12406 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12408 * gdbtypes.c (type_align): Don't consider static members when
12409 computing structure alignment.
12411 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12413 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12414 return 0 for other types.
12415 * arch-utils.c (default_type_align): Always return 0.
12416 * gdbarch.h: Regenerate.
12417 * gdbarch.sh (type_align): Extend comment.
12418 * gdbtypes.c (type_align): Add additional comments, always call
12419 gdbarch_type_align before applying the default rules.
12420 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12421 generic code will then apply a suitable default.
12422 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12423 types, return 0 for other types.
12425 2019-02-27 Joel Brobecker <brobecker@adacore.com>
12427 * NEWS: Create a new section for the next release branch.
12428 Rename the section of the current branch, now that it has
12431 2019-02-27 Joel Brobecker <brobecker@adacore.com>
12433 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12434 * version.in: Bump version to 8.3.50.DATE-git.
12436 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
12438 * aix-thread.c (ptid_cmp): Remove unused variable.
12439 (get_signaled_thread): Likewise.
12440 (store_regs_user_thread): Likewise.
12441 (store_regs_kernel_thread): Likewise.
12442 (fetch_regs_kernel_thread): Remove shadowed variable.
12444 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
12446 * features/riscv/32bit-cpu.xml: Add register numbers.
12447 * features/riscv/32bit-fpu.c: Regenerate.
12448 * features/riscv/32bit-fpu.xml: Add register numbers.
12449 * features/riscv/64bit-cpu.xml: Add register numbers.
12450 * features/riscv/64bit-fpu.c: Regenerate.
12451 * features/riscv/64bit-fpu.xml: Add register numbers.
12453 2019-02-26 Kevin Buettner <kevinb@redhat.com>
12455 * NEWS: Mention two argument form of gdb.Value constructor.
12456 * python/py-value.c (convert_buffer_and_type_to_value): New
12458 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12459 Add support for handling an optional second argument. Call
12460 convert_buffer_and_type_to_value as appropriate.
12461 * python/python-internal.h (Py_buffer_deleter): New struct.
12462 (Py_buffer_up): New typedef.
12464 2019-02-25 John Baldwin <jhb@FreeBSD.org>
12466 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12467 instead of releasing ownership.
12469 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
12471 * dwarf2read.c (open_and_init_dwp_file): Call
12472 elf_numsections instead of bfd_count_sections to initialize
12473 dwp_file->num_sections.
12475 2019-02-25 Tom Tromey <tromey@adacore.com>
12477 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12479 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
12481 * gcore.in: Add '--readnever' option when invoking GDB.
12483 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
12485 * MAINTAINERS: Update my email address.
12487 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
12489 * build-id.c (build_id_to_debug_bfd_1): New function.
12490 (build_id_to_debug_bfd): Look for separate debug file in
12493 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
12495 * gdbarch.sh: Update the copyright year range that is placed into
12498 2019-02-22 Keith Seitz <keiths@redhat.com>
12501 * linespec.c (create_sals_line_offset): Search for the default
12502 symtab's filename instead of its fullname.
12504 2019-02-21 Alan Hayward <alan.hayward@arm.com>
12506 * NEWS: Update style defaults.
12508 2019-02-21 Alan Hayward <alan.hayward@arm.com>
12510 * main.c (captured_main_1): Disable styling in batch mode.
12512 2019-02-20 Tom Tromey <tom@tromey.com>
12514 * symtab.c (symtab_symbol_info): Fix typos.
12516 2019-02-20 Tom Tromey <tromey@adacore.com>
12518 * findcmd.c (_initialize_mem_search): Use upper case for
12519 metasyntactic variables.
12521 2019-02-20 Alan Hayward <alan.hayward@arm.com>
12523 * aarch64-tdep.c (aarch64_add_reggroups): New function.
12524 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12526 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
12528 * top.h (source_file_name): Change to std::string.
12529 * top.c (source_file_name): Likewise.
12530 (command_line_input): Adjust.
12531 * cli/cli-script.c (script_from_file): Adjust.
12533 2019-02-19 Tom Tromey <tromey@adacore.com>
12535 * ravenscar-thread.c
12536 (ravenscar_thread_target::update_thread_list): Don't call
12537 ada_build_task_list.
12538 * ada-lang.h (ada_build_task_list): Don't declare.
12539 * ada-tasks.c (struct ada_tasks_inferior_data)
12540 <task_list_valid_p>: Now bool.
12541 (read_known_tasks, ada_task_list_changed)
12542 (ada_tasks_invalidate_inferior_data): Update.
12543 (read_known_tasks_array): Return bool.
12544 (read_known_tasks_list): Likewise.
12545 (read_known_tasks): Return void.
12546 (ada_build_task_list): Now static.
12548 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
12550 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12551 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12553 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12555 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12556 variant for ada_tasks_pspace_data_handle and
12557 ada_tasks_inferior_data_handle.
12558 (ada_tasks_pspace_data_cleanup): New function.
12559 (ada_tasks_inferior_data_cleanup): New function.
12561 2019-02-17 Tom Tromey <tom@tromey.com>
12563 * macrotab.h (macro_source_fullname): Return a std::string.
12564 * macrotab.c (macro_include, check_for_redefinition)
12565 (macro_undef, macro_lookup_definition, foreach_macro)
12566 (foreach_macro_in_scope): Update.
12567 (macro_source_fullname): Return a std::string.
12568 * macrocmd.c (show_pp_source_pos): Update.
12570 2019-02-17 Tom Tromey <tom@tromey.com>
12572 * macrocmd.c (show_pp_source_pos): Style the file names.
12574 2019-02-17 Tom Tromey <tom@tromey.com>
12577 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12579 2019-02-17 Tom Tromey <tom@tromey.com>
12581 * ada-lang.c (user_select_syms): Use filtered printing.
12582 * utils.c (wrap_style): New global.
12583 (desired_style): Remove.
12584 (emit_style_escape): Add stream parameter.
12585 (set_output_style, reset_terminal_style, prompt_for_continue):
12587 (flush_wrap_buffer): Only flush gdb_stdout.
12588 (wrap_here): Set wrap_style.
12589 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
12590 treat escape sequences as a character. Change when wrap buffer is
12592 (fputs_styled): Do not set the output style when the default is
12594 * ui-style.h (struct ui_file_style) <is_default>: New method.
12595 * source.c (print_source_lines_base): Emit escape sequences in one
12598 2019-02-17 Joel Brobecker <brobecker@adacore.com>
12600 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12601 integers and enumeration types.
12603 2019-02-17 Joel Brobecker <brobecker@adacore.com>
12605 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12606 instead of lookup_symbol_in_language
12607 (do_exact_match): New function.
12608 (ada_get_symbol_name_matcher): Return do_exact_match when
12609 doing a verbatim match.
12611 2019-02-15 Tom Tromey <tromey@adacore.com>
12613 * ravenscar-thread.c (ravenscar_thread_target::resume)
12614 (ravenscar_thread_target::wait): Special case wildcard requests.
12616 2019-02-15 Tom Tromey <tromey@adacore.com>
12618 * ravenscar-thread.c (base_ptid): Remove.
12619 (struct ravenscar_thread_target) <close>: New method.
12620 <m_base_ptid>: New member.
12621 <update_inferior_ptid, active_task, task_is_currently_active,
12622 runtime_initialized>: Declare methods.
12623 <ravenscar_thread_target>: Add constructor.
12624 (ravenscar_thread_target::task_is_currently_active)
12625 (ravenscar_thread_target::update_inferior_ptid)
12626 (ravenscar_runtime_initialized): Rename. Now methods.
12627 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12628 (ravenscar_thread_target::update_thread_list): Update.
12629 (ravenscar_thread_target::active_task): Now method.
12630 (ravenscar_thread_target::store_registers)
12631 (ravenscar_thread_target::prepare_to_store)
12632 (ravenscar_thread_target::prepare_to_store)
12633 (ravenscar_thread_target::mourn_inferior): Update.
12634 (ravenscar_inferior_created): Use "new" to create target.
12635 (ravenscar_thread_target::get_ada_task_ptid): Update.
12636 (_initialize_ravenscar): Don't initialize base_ptid.
12637 (ravenscar_ops): Remove global.
12639 2019-02-15 Tom Tromey <tromey@adacore.com>
12641 * target.h (push_target): Declare new overload.
12642 * target.c (push_target): New overload, taking an rvalue reference.
12643 * remote.c (remote_target::open_1): Use push_target overload.
12644 * corelow.c (core_target_open): Use push_target overload.
12646 2019-02-15 Tom Tromey <tromey@adacore.com>
12648 * ravenscar-thread.c (is_ravenscar_task)
12649 (ravenscar_task_is_currently_active): Return bool.
12650 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12651 (_initialize_ravenscar): Remove "(void)".
12652 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12655 2019-02-15 Tom Tromey <tromey@adacore.com>
12657 * ravenscar-thread.c (ravenscar_runtime_initializer)
12658 (has_ravenscar_runtime, get_running_thread_id)
12659 (ravenscar_thread_target::resume): Fix indentation.
12661 2019-02-15 Tom Tromey <tromey@adacore.com>
12663 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12664 from ravenscar_arch_ops.
12665 (sparc_ravenscar_ops::fetch_registers)
12666 (sparc_ravenscar_ops::store_registers): Now methods.
12667 (sparc_ravenscar_prepare_to_store): Remove.
12668 (sparc_ravenscar_ops): Redefine.
12669 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12670 methods and destructor. Remove members.
12671 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12672 (ravenscar_thread_target::store_registers)
12673 (ravenscar_thread_target::prepare_to_store): Update.
12674 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12676 (struct ppc_ravenscar_powerpc_ops): Derive from
12677 ravenscar_arch_ops.
12678 (ppc_ravenscar_powerpc_ops::fetch_registers)
12679 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12680 (ppc_ravenscar_powerpc_ops): Redefine.
12681 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12682 (ppc_ravenscar_e500_ops::fetch_registers)
12683 (ppc_ravenscar_e500_ops::store_registers): Now methods.
12684 (ppc_ravenscar_e500_ops): Redefine.
12685 * aarch64-ravenscar-thread.c
12686 (aarch64_ravenscar_generic_prepare_to_store): Remove.
12687 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12688 (aarch64_ravenscar_fetch_registers)
12689 (aarch64_ravenscar_store_registers): Now methods.
12690 (aarch64_ravenscar_ops): Redefine.
12692 2019-02-15 Tom Tromey <tromey@adacore.com>
12694 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12695 (ravenscar_thread_target::stopped_by_hw_breakpoint)
12696 (ravenscar_thread_target::stopped_by_watchpoint)
12697 (ravenscar_thread_target::stopped_data_address)
12698 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12700 2019-02-15 Tom Tromey <tromey@adacore.com>
12702 * ravenscar-thread.c: Fix some typos.
12704 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12705 Tom Tromey <tromey@adacore.com>
12707 * ada-lang.c (ada_exception_sal): Change addr_string to a
12709 (create_ada_exception_catchpoint): Update.
12711 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12712 Tom Tromey <tromey@adacore.com>
12714 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12715 (bp_location_ops): Remove.
12716 (base_breakpoint_allocate_location): Update.
12717 (free_bp_location): Update.
12718 * ada-lang.c (class ada_catchpoint_location)
12719 <ada_catchpoint_location>: Remove ops parameter.
12720 (ada_catchpoint_location_dtor): Remove.
12721 (ada_catchpoint_location_ops): Remove.
12722 (allocate_location_exception): Update.
12723 * breakpoint.h (struct bp_location_ops): Remove.
12724 (class bp_location) <bp_location>: Remove bp_location_ops
12726 <~bp_location>: Add destructor.
12729 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
12730 Pedro Alves <palves@redhat.com>
12732 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12735 2019-02-14 David Michael <fedora.dm0@gmail.com>
12736 Samuel Thibault <samuel.thibault@gnu.org>
12737 Thomas Schwinge <thomas@codesourcery.com>
12739 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12740 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12742 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
12744 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12745 (check_empty): Use "const char *".
12747 * gnu-nat.c (gnu_nat_target::detach): Instead of
12748 'detach_inferior (pid)' call
12749 'detach_inferior (find_inferior_pid (pid))'.
12751 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12752 'nat/fork-inferior.o'.
12753 * gnu-nat.c: #include "nat/fork-inferior.h".
12755 * gnu-nat.c (gnu_nat_target::detach): Instead of
12756 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12757 * gnu-nat.h: #include "inf-child.h".
12758 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12759 'i386_gnu_nat_target::fetch_registers'.
12760 (gnu_store_registers): Rename/move to
12761 'i386_gnu_nat_target::store_registers'.
12763 * config/i386/nm-i386gnu.h: Don't "#include" any files.
12764 * gnu-nat.h (mach_thread_info): New function.
12765 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12767 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12769 2019-02-14 Frederic Konrad <konrad@adacore.com>
12771 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12773 2019-02-14 Joel Brobecker <brobecker@adacore.com>
12775 * windows-nat.c (windows_add_thread): Add new parameter
12776 "main_thread_p" with default value set to false. Update
12777 function documentation as well as all callers.
12778 (windows_delete_thread): Likewise.
12779 (fake_create_process): Update call to windows_add_thread.
12780 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12781 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12782 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12783 call to windows_delete_thread.
12785 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
12787 * MAINTAINERS: Add Andrew Burgess as global maintainer.
12789 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12791 * symfile.c (find_separate_debug_file): Use canonical path of
12792 sysroot with child_path instead of gdb_sysroot if it is valid.
12794 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12796 * symfile.c (find_separate_debug_file): Use child_path to
12797 determine if an object file is under a sysroot.
12799 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12801 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12802 unittests/child-path-selftests.c.
12803 * common/pathstuff.c (child_path): New function.
12804 * common/pathstuff.h (child_path): New prototype.
12805 * unittests/child-path-selftests.c: New file.
12807 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12809 * symfile.c (find_separate_debug_file): Look for separate debug
12810 files in debug directories under the sysroot.
12812 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12814 * symtab.h (struct minimal_symbol data_p): New const method.
12815 (struct minimal_symbol text_p): Likewise.
12816 * symtab.c (output_source_filename): Use file name style
12817 to print file name.
12818 (print_symbol_info): Likewise.
12819 (print_msymbol_info): Use address style to print addresses.
12820 Use function name style to print executable text symbols.
12821 (expand_symtab_containing_pc): Use data_p.
12822 (find_pc_sect_compunit_symtab): Likewise.
12824 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12826 * breakpoint.c (describe_other_breakpoints): Use address style
12827 to print addresses.
12828 (say_where): Likewise.
12830 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12832 * ada-typeprint.c (print_func_type): Print function name
12833 style to print function name.
12834 * c-typeprint.c (c_print_type_1): Likewise.
12836 2019-02-11 Alan Hayward <alan.hayward@arm.com>
12838 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12841 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12843 * c-exp.y (direct_abs_decl): Use emplace_back to record the
12846 2019-02-10 Joel Brobecker <brobecker@adacore.com>
12848 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12849 TYPE_CODE_REF types.
12851 2019-02-08 Jim Wilson <jimw@sifive.com>
12853 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12854 (riscv_linux_fregset): New.
12855 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12857 2019-02-07 Tom Tromey <tom@tromey.com>
12859 * thread.c (thread_cancel_execution_command): Update.
12860 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12862 (struct thread_fsm_ops): Remove.
12863 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12864 (thread_fsm_should_stop, thread_fsm_return_value)
12865 (thread_fsm_set_finished, thread_fsm_finished_p)
12866 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12868 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12869 * infrun.c (clear_proceed_status_thread)
12870 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12871 (print_stop_event): Update.
12872 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12874 (step_command_fsm_ops): Remove.
12875 (new_step_command_fsm): Remove.
12877 (step_command_fsm::should_stop): Rename from
12878 step_command_fsm_should_stop.
12879 (step_command_fsm::clean_up): Rename from
12880 step_command_fsm_clean_up.
12881 (step_command_fsm::do_async_reply_reason): Rename from
12882 step_command_fsm_async_reply_reason.
12883 (struct until_next_fsm): Inherit from thread_fsm. Add
12885 (until_next_fsm_ops): Remove.
12886 (new_until_next_fsm): Remove.
12887 (until_next_fsm::should_stop): Rename from
12888 until_next_fsm_should_stop.
12889 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12890 (until_next_fsm::do_async_reply_reason): Rename from
12891 until_next_fsm_async_reply_reason.
12892 (struct finish_command_fsm): Inherit from thread_fsm. Add
12893 constructor. Change type of breakpoint.
12894 (finish_command_fsm_ops): Remove.
12895 (new_finish_command_fsm): Remove.
12896 (finish_command_fsm::should_stop): Rename from
12897 finish_command_fsm_should_stop.
12898 (finish_command_fsm::clean_up): Rename from
12899 finish_command_fsm_clean_up.
12900 (finish_command_fsm::return_value): Rename from
12901 finish_command_fsm_return_value.
12902 (finish_command_fsm::do_async_reply_reason): Rename from
12903 finish_command_fsm_async_reply_reason.
12904 (finish_command): Update.
12905 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12907 (call_thread_fsm_ops): Remove.
12908 (call_thread_fsm::call_thread_fsm): Rename from
12909 new_call_thread_fsm.
12910 (call_thread_fsm::should_stop): Rename from
12911 call_thread_fsm_should_stop.
12912 (call_thread_fsm::should_notify_stop): Rename from
12913 call_thread_fsm_should_notify_stop.
12914 (run_inferior_call, call_function_by_hand_dummy): Update.
12915 * cli/cli-interp.c (should_print_stop_to_console): Update.
12916 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12917 Add constructor. Change type of location_breakpoint,
12919 (until_break_fsm_ops): Remove.
12920 (new_until_break_fsm): Remove.
12921 (until_break_fsm::should_stop): Rename from
12922 until_break_fsm_should_stop.
12923 (until_break_fsm::clean_up): Rename from
12924 until_break_fsm_clean_up.
12925 (until_break_fsm::do_async_reply_reason): Rename from
12926 until_break_fsm_async_reply_reason.
12927 (until_break_command): Update.
12928 * thread-fsm.c: Remove.
12929 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12931 2019-02-07 Tom Tromey <tom@tromey.com>
12933 * yy-remap.h: Add include guard.
12934 * xtensa-tdep.h: Add include guard.
12935 * xcoffread.h: Rename include guard.
12936 * varobj-iter.h: Add include guard.
12937 * tui/tui.h: Rename include guard.
12938 * tui/tui-winsource.h: Rename include guard.
12939 * tui/tui-wingeneral.h: Rename include guard.
12940 * tui/tui-windata.h: Rename include guard.
12941 * tui/tui-win.h: Rename include guard.
12942 * tui/tui-stack.h: Rename include guard.
12943 * tui/tui-source.h: Rename include guard.
12944 * tui/tui-regs.h: Rename include guard.
12945 * tui/tui-out.h: Rename include guard.
12946 * tui/tui-layout.h: Rename include guard.
12947 * tui/tui-io.h: Rename include guard.
12948 * tui/tui-hooks.h: Rename include guard.
12949 * tui/tui-file.h: Rename include guard.
12950 * tui/tui-disasm.h: Rename include guard.
12951 * tui/tui-data.h: Rename include guard.
12952 * tui/tui-command.h: Rename include guard.
12953 * tic6x-tdep.h: Add include guard.
12954 * target/waitstatus.h: Rename include guard.
12955 * target/wait.h: Rename include guard.
12956 * target/target.h: Rename include guard.
12957 * target/resume.h: Rename include guard.
12958 * target-float.h: Rename include guard.
12959 * stabsread.h: Add include guard.
12960 * rs6000-tdep.h: Add include guard.
12961 * riscv-fbsd-tdep.h: Add include guard.
12962 * regformats/regdef.h: Rename include guard.
12963 * record.h: Rename include guard.
12964 * python/python.h: Rename include guard.
12965 * python/python-internal.h: Rename include guard.
12966 * python/py-stopevent.h: Rename include guard.
12967 * python/py-ref.h: Rename include guard.
12968 * python/py-record.h: Rename include guard.
12969 * python/py-record-full.h: Rename include guard.
12970 * python/py-record-btrace.h: Rename include guard.
12971 * python/py-instruction.h: Rename include guard.
12972 * python/py-events.h: Rename include guard.
12973 * python/py-event.h: Rename include guard.
12974 * procfs.h: Add include guard.
12975 * proc-utils.h: Add include guard.
12976 * p-lang.h: Add include guard.
12977 * or1k-tdep.h: Rename include guard.
12978 * observable.h: Rename include guard.
12979 * nto-tdep.h: Rename include guard.
12980 * nat/x86-linux.h: Rename include guard.
12981 * nat/x86-linux-dregs.h: Rename include guard.
12982 * nat/x86-gcc-cpuid.h: Add include guard.
12983 * nat/x86-dregs.h: Rename include guard.
12984 * nat/x86-cpuid.h: Rename include guard.
12985 * nat/ppc-linux.h: Rename include guard.
12986 * nat/mips-linux-watch.h: Rename include guard.
12987 * nat/linux-waitpid.h: Rename include guard.
12988 * nat/linux-ptrace.h: Rename include guard.
12989 * nat/linux-procfs.h: Rename include guard.
12990 * nat/linux-osdata.h: Rename include guard.
12991 * nat/linux-nat.h: Rename include guard.
12992 * nat/linux-namespaces.h: Rename include guard.
12993 * nat/linux-btrace.h: Rename include guard.
12994 * nat/glibc_thread_db.h: Rename include guard.
12995 * nat/gdb_thread_db.h: Rename include guard.
12996 * nat/gdb_ptrace.h: Rename include guard.
12997 * nat/fork-inferior.h: Rename include guard.
12998 * nat/amd64-linux-siginfo.h: Rename include guard.
12999 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13000 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13001 * nat/aarch64-linux.h: Rename include guard.
13002 * nat/aarch64-linux-hw-point.h: Rename include guard.
13003 * mn10300-tdep.h: Add include guard.
13004 * mips-linux-tdep.h: Add include guard.
13005 * mi/mi-parse.h: Rename include guard.
13006 * mi/mi-out.h: Rename include guard.
13007 * mi/mi-main.h: Rename include guard.
13008 * mi/mi-interp.h: Rename include guard.
13009 * mi/mi-getopt.h: Rename include guard.
13010 * mi/mi-console.h: Rename include guard.
13011 * mi/mi-common.h: Rename include guard.
13012 * mi/mi-cmds.h: Rename include guard.
13013 * mi/mi-cmd-break.h: Rename include guard.
13014 * m2-lang.h: Add include guard.
13015 * location.h: Rename include guard.
13016 * linux-record.h: Rename include guard.
13017 * linux-nat.h: Add include guard.
13018 * linux-fork.h: Add include guard.
13019 * i386-darwin-tdep.h: Rename include guard.
13020 * hppa-linux-offsets.h: Add include guard.
13021 * guile/guile.h: Rename include guard.
13022 * guile/guile-internal.h: Rename include guard.
13023 * gnu-nat.h: Rename include guard.
13024 * gdb-stabs.h: Rename include guard.
13025 * frv-tdep.h: Add include guard.
13026 * f-lang.h: Add include guard.
13027 * event-loop.h: Add include guard.
13028 * darwin-nat.h: Rename include guard.
13029 * cp-abi.h: Rename include guard.
13030 * config/sparc/nm-sol2.h: Rename include guard.
13031 * config/nm-nto.h: Rename include guard.
13032 * config/nm-linux.h: Add include guard.
13033 * config/i386/nm-i386gnu.h: Rename include guard.
13034 * config/djgpp/nl_types.h: Rename include guard.
13035 * config/djgpp/langinfo.h: Rename include guard.
13036 * compile/gcc-cp-plugin.h: Add include guard.
13037 * compile/gcc-c-plugin.h: Add include guard.
13038 * compile/compile.h: Rename include guard.
13039 * compile/compile-object-run.h: Rename include guard.
13040 * compile/compile-object-load.h: Rename include guard.
13041 * compile/compile-internal.h: Rename include guard.
13042 * compile/compile-cplus.h: Rename include guard.
13043 * compile/compile-c.h: Rename include guard.
13044 * common/xml-utils.h: Rename include guard.
13045 * common/x86-xstate.h: Rename include guard.
13046 * common/version.h: Rename include guard.
13047 * common/vec.h: Rename include guard.
13048 * common/tdesc.h: Rename include guard.
13049 * common/selftest.h: Rename include guard.
13050 * common/scoped_restore.h: Rename include guard.
13051 * common/scoped_mmap.h: Rename include guard.
13052 * common/scoped_fd.h: Rename include guard.
13053 * common/safe-iterator.h: Rename include guard.
13054 * common/run-time-clock.h: Rename include guard.
13055 * common/refcounted-object.h: Rename include guard.
13056 * common/queue.h: Rename include guard.
13057 * common/ptid.h: Rename include guard.
13058 * common/print-utils.h: Rename include guard.
13059 * common/preprocessor.h: Rename include guard.
13060 * common/pathstuff.h: Rename include guard.
13061 * common/observable.h: Rename include guard.
13062 * common/netstuff.h: Rename include guard.
13063 * common/job-control.h: Rename include guard.
13064 * common/host-defs.h: Rename include guard.
13065 * common/gdb_wait.h: Rename include guard.
13066 * common/gdb_vecs.h: Rename include guard.
13067 * common/gdb_unlinker.h: Rename include guard.
13068 * common/gdb_unique_ptr.h: Rename include guard.
13069 * common/gdb_tilde_expand.h: Rename include guard.
13070 * common/gdb_sys_time.h: Rename include guard.
13071 * common/gdb_string_view.h: Rename include guard.
13072 * common/gdb_splay_tree.h: Rename include guard.
13073 * common/gdb_setjmp.h: Rename include guard.
13074 * common/gdb_ref_ptr.h: Rename include guard.
13075 * common/gdb_optional.h: Rename include guard.
13076 * common/gdb_locale.h: Rename include guard.
13077 * common/gdb_assert.h: Rename include guard.
13078 * common/filtered-iterator.h: Rename include guard.
13079 * common/filestuff.h: Rename include guard.
13080 * common/fileio.h: Rename include guard.
13081 * common/environ.h: Rename include guard.
13082 * common/common-utils.h: Rename include guard.
13083 * common/common-types.h: Rename include guard.
13084 * common/common-regcache.h: Rename include guard.
13085 * common/common-inferior.h: Rename include guard.
13086 * common/common-gdbthread.h: Rename include guard.
13087 * common/common-exceptions.h: Rename include guard.
13088 * common/common-defs.h: Rename include guard.
13089 * common/common-debug.h: Rename include guard.
13090 * common/cleanups.h: Rename include guard.
13091 * common/buffer.h: Rename include guard.
13092 * common/btrace-common.h: Rename include guard.
13093 * common/break-common.h: Rename include guard.
13094 * cli/cli-utils.h: Rename include guard.
13095 * cli/cli-style.h: Rename include guard.
13096 * cli/cli-setshow.h: Rename include guard.
13097 * cli/cli-script.h: Rename include guard.
13098 * cli/cli-interp.h: Rename include guard.
13099 * cli/cli-decode.h: Rename include guard.
13100 * cli/cli-cmds.h: Rename include guard.
13101 * charset-list.h: Add include guard.
13102 * buildsym-legacy.h: Rename include guard.
13103 * bfin-tdep.h: Add include guard.
13104 * ax.h: Rename include guard.
13105 * arm-linux-tdep.h: Add include guard.
13106 * arm-fbsd-tdep.h: Add include guard.
13107 * arch/xtensa.h: Rename include guard.
13108 * arch/tic6x.h: Add include guard.
13109 * arch/i386.h: Add include guard.
13110 * arch/arm.h: Rename include guard.
13111 * arch/arm-linux.h: Rename include guard.
13112 * arch/arm-get-next-pcs.h: Rename include guard.
13113 * arch/amd64.h: Add include guard.
13114 * arch/aarch64-insn.h: Rename include guard.
13115 * arch-utils.h: Rename include guard.
13116 * annotate.h: Add include guard.
13117 * amd64-darwin-tdep.h: Rename include guard.
13118 * aarch64-linux-tdep.h: Add include guard.
13119 * aarch64-fbsd-tdep.h: Add include guard.
13120 * aarch32-linux-nat.h: Add include guard.
13122 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13124 * macrotab.c (macro_define_internal): New function that
13125 factorizes macro_define_object_internal and macro_define_function
13127 (macro_define_object_internal): Use macro_define_internal.
13128 (macro_define_function): Likewise.
13130 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13132 * macrocmd.c (extract_identifier): Return
13133 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13136 2019-02-06 John Baldwin <jhb@FreeBSD.org>
13138 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13140 2019-02-05 Tom Tromey <tom@tromey.com>
13142 * target.c (target_stack::unpush): Move assertion earlier.
13144 2019-01-30 Tom Tromey <tom@tromey.com>
13147 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13148 (gdbpy_parse_and_eval): Likewise.
13149 * python/python-internal.h (gdbpy_allow_threads): New class.
13151 2019-01-28 John Baldwin <jhb@FreeBSD.org>
13153 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13154 (aarch64_fbsd_fpregmap): Move earlier.
13155 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13156 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13157 instead of individual calls to trad_frame_set_reg_addr.
13158 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13160 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13161 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13162 instead of individual calls to trad_frame_set_reg_addr.
13164 2019-01-28 Alan Hayward <alan.hayward@arm.com>
13166 * CONTRIBUTE: Replace contribution list with wiki link.
13168 2019-01-25 Tom Tromey <tom@tromey.com>
13170 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13172 2019-01-25 Tom Tromey <tom@tromey.com>
13174 * xtensa-linux-nat.c: Fix common/ includes.
13175 * xml-support.h: Fix common/ includes.
13176 * xml-support.c: Fix common/ includes.
13177 * x86-linux-nat.c: Fix common/ includes.
13178 * windows-nat.c: Fix common/ includes.
13179 * varobj.h: Fix common/ includes.
13180 * varobj.c: Fix common/ includes.
13181 * value.c: Fix common/ includes.
13182 * valops.c: Fix common/ includes.
13183 * utils.c: Fix common/ includes.
13184 * unittests/xml-utils-selftests.c: Fix common/ includes.
13185 * unittests/utils-selftests.c: Fix common/ includes.
13186 * unittests/unpack-selftests.c: Fix common/ includes.
13187 * unittests/tracepoint-selftests.c: Fix common/ includes.
13188 * unittests/style-selftests.c: Fix common/ includes.
13189 * unittests/string_view-selftests.c: Fix common/ includes.
13190 * unittests/scoped_restore-selftests.c: Fix common/ includes.
13191 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13192 * unittests/scoped_fd-selftests.c: Fix common/ includes.
13193 * unittests/rsp-low-selftests.c: Fix common/ includes.
13194 * unittests/parse-connection-spec-selftests.c: Fix common/
13196 * unittests/optional-selftests.c: Fix common/ includes.
13197 * unittests/offset-type-selftests.c: Fix common/ includes.
13198 * unittests/observable-selftests.c: Fix common/ includes.
13199 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13200 * unittests/memrange-selftests.c: Fix common/ includes.
13201 * unittests/memory-map-selftests.c: Fix common/ includes.
13202 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13203 * unittests/function-view-selftests.c: Fix common/ includes.
13204 * unittests/environ-selftests.c: Fix common/ includes.
13205 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13206 * unittests/common-utils-selftests.c: Fix common/ includes.
13207 * unittests/cli-utils-selftests.c: Fix common/ includes.
13208 * unittests/array-view-selftests.c: Fix common/ includes.
13209 * ui-file.c: Fix common/ includes.
13210 * tui/tui-io.c: Fix common/ includes.
13211 * tracepoint.h: Fix common/ includes.
13212 * tracepoint.c: Fix common/ includes.
13213 * tracefile-tfile.c: Fix common/ includes.
13214 * top.h: Fix common/ includes.
13215 * top.c: Fix common/ includes.
13216 * thread.c: Fix common/ includes.
13217 * target/waitstatus.h: Fix common/ includes.
13218 * target/waitstatus.c: Fix common/ includes.
13219 * target.h: Fix common/ includes.
13220 * target.c: Fix common/ includes.
13221 * target-memory.c: Fix common/ includes.
13222 * target-descriptions.c: Fix common/ includes.
13223 * symtab.h: Fix common/ includes.
13224 * symfile.c: Fix common/ includes.
13225 * stap-probe.c: Fix common/ includes.
13226 * spu-linux-nat.c: Fix common/ includes.
13227 * sparc-nat.c: Fix common/ includes.
13228 * source.c: Fix common/ includes.
13229 * solib.c: Fix common/ includes.
13230 * solib-target.c: Fix common/ includes.
13231 * ser-unix.c: Fix common/ includes.
13232 * ser-tcp.c: Fix common/ includes.
13233 * ser-pipe.c: Fix common/ includes.
13234 * ser-base.c: Fix common/ includes.
13235 * selftest-arch.c: Fix common/ includes.
13236 * s12z-tdep.c: Fix common/ includes.
13237 * rust-exp.y: Fix common/ includes.
13238 * rs6000-aix-tdep.c: Fix common/ includes.
13239 * riscv-tdep.c: Fix common/ includes.
13240 * remote.c: Fix common/ includes.
13241 * remote-notif.h: Fix common/ includes.
13242 * remote-fileio.h: Fix common/ includes.
13243 * remote-fileio.c: Fix common/ includes.
13244 * regcache.h: Fix common/ includes.
13245 * regcache.c: Fix common/ includes.
13246 * record-btrace.c: Fix common/ includes.
13247 * python/python.c: Fix common/ includes.
13248 * python/py-type.c: Fix common/ includes.
13249 * python/py-inferior.c: Fix common/ includes.
13250 * progspace.h: Fix common/ includes.
13251 * producer.c: Fix common/ includes.
13252 * procfs.c: Fix common/ includes.
13253 * proc-api.c: Fix common/ includes.
13254 * printcmd.c: Fix common/ includes.
13255 * ppc-linux-nat.c: Fix common/ includes.
13256 * parser-defs.h: Fix common/ includes.
13257 * osdata.c: Fix common/ includes.
13258 * obsd-nat.c: Fix common/ includes.
13259 * nat/x86-linux.c: Fix common/ includes.
13260 * nat/x86-linux-dregs.c: Fix common/ includes.
13261 * nat/x86-dregs.h: Fix common/ includes.
13262 * nat/x86-dregs.c: Fix common/ includes.
13263 * nat/ppc-linux.c: Fix common/ includes.
13264 * nat/mips-linux-watch.h: Fix common/ includes.
13265 * nat/mips-linux-watch.c: Fix common/ includes.
13266 * nat/linux-waitpid.c: Fix common/ includes.
13267 * nat/linux-ptrace.h: Fix common/ includes.
13268 * nat/linux-ptrace.c: Fix common/ includes.
13269 * nat/linux-procfs.c: Fix common/ includes.
13270 * nat/linux-personality.c: Fix common/ includes.
13271 * nat/linux-osdata.c: Fix common/ includes.
13272 * nat/linux-namespaces.c: Fix common/ includes.
13273 * nat/linux-btrace.h: Fix common/ includes.
13274 * nat/linux-btrace.c: Fix common/ includes.
13275 * nat/fork-inferior.c: Fix common/ includes.
13276 * nat/amd64-linux-siginfo.c: Fix common/ includes.
13277 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13278 * nat/aarch64-linux.c: Fix common/ includes.
13279 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13280 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13281 * namespace.h: Fix common/ includes.
13282 * mips-linux-tdep.c: Fix common/ includes.
13283 * minsyms.c: Fix common/ includes.
13284 * mi/mi-parse.h: Fix common/ includes.
13285 * mi/mi-main.c: Fix common/ includes.
13286 * mi/mi-cmd-env.c: Fix common/ includes.
13287 * memrange.h: Fix common/ includes.
13288 * memattr.c: Fix common/ includes.
13289 * maint.h: Fix common/ includes.
13290 * maint.c: Fix common/ includes.
13291 * main.c: Fix common/ includes.
13292 * machoread.c: Fix common/ includes.
13293 * location.c: Fix common/ includes.
13294 * linux-thread-db.c: Fix common/ includes.
13295 * linux-nat.c: Fix common/ includes.
13296 * linux-fork.c: Fix common/ includes.
13297 * inline-frame.c: Fix common/ includes.
13298 * infrun.c: Fix common/ includes.
13299 * inflow.c: Fix common/ includes.
13300 * inferior.h: Fix common/ includes.
13301 * inferior.c: Fix common/ includes.
13302 * infcmd.c: Fix common/ includes.
13303 * inf-ptrace.c: Fix common/ includes.
13304 * inf-child.c: Fix common/ includes.
13305 * ia64-linux-nat.c: Fix common/ includes.
13306 * i387-tdep.c: Fix common/ includes.
13307 * i386-tdep.c: Fix common/ includes.
13308 * i386-linux-tdep.c: Fix common/ includes.
13309 * i386-linux-nat.c: Fix common/ includes.
13310 * i386-go32-tdep.c: Fix common/ includes.
13311 * i386-fbsd-tdep.c: Fix common/ includes.
13312 * i386-fbsd-nat.c: Fix common/ includes.
13313 * guile/scm-type.c: Fix common/ includes.
13314 * guile/guile.c: Fix common/ includes.
13315 * go32-nat.c: Fix common/ includes.
13316 * gnu-nat.c: Fix common/ includes.
13317 * gdbthread.h: Fix common/ includes.
13318 * gdbarch-selftests.c: Fix common/ includes.
13319 * gdb_usleep.c: Fix common/ includes.
13320 * gdb_select.h: Fix common/ includes.
13321 * gdb_bfd.c: Fix common/ includes.
13322 * gcore.c: Fix common/ includes.
13323 * fork-child.c: Fix common/ includes.
13324 * findvar.c: Fix common/ includes.
13325 * fbsd-nat.c: Fix common/ includes.
13326 * event-top.c: Fix common/ includes.
13327 * event-loop.c: Fix common/ includes.
13328 * dwarf2read.c: Fix common/ includes.
13329 * dwarf2loc.c: Fix common/ includes.
13330 * dwarf2-frame.c: Fix common/ includes.
13331 * dwarf-index-cache.c: Fix common/ includes.
13332 * dtrace-probe.c: Fix common/ includes.
13333 * disasm-selftests.c: Fix common/ includes.
13334 * defs.h: Fix common/ includes.
13335 * csky-tdep.c: Fix common/ includes.
13336 * cp-valprint.c: Fix common/ includes.
13337 * cp-support.h: Fix common/ includes.
13338 * cp-support.c: Fix common/ includes.
13339 * corelow.c: Fix common/ includes.
13340 * completer.h: Fix common/ includes.
13341 * completer.c: Fix common/ includes.
13342 * compile/compile.c: Fix common/ includes.
13343 * compile/compile-loc2c.c: Fix common/ includes.
13344 * compile/compile-cplus-types.c: Fix common/ includes.
13345 * compile/compile-cplus-symbols.c: Fix common/ includes.
13346 * command.h: Fix common/ includes.
13347 * cli/cli-dump.c: Fix common/ includes.
13348 * cli/cli-cmds.c: Fix common/ includes.
13349 * charset.c: Fix common/ includes.
13350 * build-id.c: Fix common/ includes.
13351 * btrace.h: Fix common/ includes.
13352 * btrace.c: Fix common/ includes.
13353 * breakpoint.h: Fix common/ includes.
13354 * breakpoint.c: Fix common/ includes.
13356 (enum agent_op): Fix common/ includes.
13357 * ax-general.c (struct aop_map): Fix common/ includes.
13358 * ax-gdb.c: Fix common/ includes.
13359 * auxv.c: Fix common/ includes.
13360 * auto-load.c: Fix common/ includes.
13361 * arm-tdep.c: Fix common/ includes.
13362 * arch/riscv.c: Fix common/ includes.
13363 * arch/ppc-linux-common.c: Fix common/ includes.
13364 * arch/i386.c: Fix common/ includes.
13365 * arch/arm.c: Fix common/ includes.
13366 * arch/arm-linux.c: Fix common/ includes.
13367 * arch/arm-get-next-pcs.c: Fix common/ includes.
13368 * arch/amd64.c: Fix common/ includes.
13369 * arch/aarch64.c: Fix common/ includes.
13370 * arch/aarch64-insn.c: Fix common/ includes.
13371 * arch-utils.c: Fix common/ includes.
13372 * amd64-windows-tdep.c: Fix common/ includes.
13373 * amd64-tdep.c: Fix common/ includes.
13374 * amd64-sol2-tdep.c: Fix common/ includes.
13375 * amd64-obsd-tdep.c: Fix common/ includes.
13376 * amd64-nbsd-tdep.c: Fix common/ includes.
13377 * amd64-linux-tdep.c: Fix common/ includes.
13378 * amd64-linux-nat.c: Fix common/ includes.
13379 * amd64-fbsd-tdep.c: Fix common/ includes.
13380 * amd64-fbsd-nat.c: Fix common/ includes.
13381 * amd64-dicos-tdep.c: Fix common/ includes.
13382 * amd64-darwin-tdep.c: Fix common/ includes.
13383 * agent.c: Fix common/ includes.
13384 * ada-lang.h: Fix common/ includes.
13385 * ada-lang.c: Fix common/ includes.
13386 * aarch64-tdep.c: Fix common/ includes.
13388 2019-01-25 Tom Tromey <tom@tromey.com>
13390 * common/create-version.sh: Use common/version.h.
13392 2019-01-24 Pedro Alves <palves@redhat.com>
13394 * infrun.c (signal_stop, signal_print, signal_program)
13395 (signal_catch, signal_pass): Now arrays instead of pointers.
13396 (update_signals_program_target, do_target_resume)
13397 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13398 * linux-nat.c (linux_nat_target::pass_signals)
13399 (linux_nat_target::create_inferior, linux_nat_target::attach):
13401 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13402 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13403 * procfs.c (procfs_target::pass_signals): Adjust.
13404 * record-full.c (record_full_target::resume): Adjust.
13405 * remote.c (remote_target::pass_signals)
13406 (remote_target::program_signals): Adjust.
13407 * target-debug.h (target_debug_print_signals): Now takes a
13408 gdb::array_view as parameter. Adjust.
13409 * target.h (target_ops) <pass_signals, program_signals>: Replace
13410 pointer and length parameters with gdb::array_view.
13411 (target_pass_signals, target_program_signals): Likewise.
13412 * target-delegates.c: Regenerate.
13414 2019-01-24 Pedro Alves <palves@redhat.com>
13416 * common/forward-scope-exit.h
13417 (forward_scope_exit::forward_scope_exit): Pass arguments to
13418 m_bind_function directly, instead of creating a std::bind and
13421 2019-01-24 Alan Hayward <alan.hayward@arm.com>
13423 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13424 for static members.
13425 (pass_in_v_vfp_candidate): Likewise.
13427 2019-01-23 Tom Tromey <tom@tromey.com>
13428 Pedro Alves <palves@redhat.com>
13430 * regcache.c (class regcache_invalidator): Remove.
13431 (regcache::raw_write): Use make_scope_exit.
13433 2019-01-23 Tom Tromey <tom@tromey.com>
13435 * ui-out.h (class ui_out_emit_type): Update comment.
13437 2019-01-23 Tom Tromey <tom@tromey.com>
13439 * infrun.c (fetch_inferior_event): Update comment.
13441 2019-01-23 Tom Tromey <tom@tromey.com>
13442 Pedro Alves <palves@redhat.com>
13444 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13446 (fetch_inferior_event): Use SCOPE_EXIT.
13449 2019-01-23 Tom Tromey <tom@tromey.com>
13450 Pedro Alves <palves@redhat.com>
13452 * infrun.c (disable_thread_events): Delete.
13453 (stop_all_threads): Use SCOPE_EXIT.
13455 2019-01-23 Tom Tromey <tom@tromey.com>
13456 Pedro Alves <palves@redhat.com>
13458 * symfile.c: Include forward-scope-exit.h.
13459 (clear_symtab_users_cleanup): Replace forward declaration with
13460 a FORWARD_SCOPE_EXIT.
13461 (syms_from_objfile_1): Use the forward_scope_exit and
13462 gdb::optional instead of cleanup_function.
13463 (reread_symbols): Use the forward_scope_exit instead of
13465 (clear_symtab_users_cleanup): Remove function.
13467 2019-01-23 Tom Tromey <tom@tromey.com>
13468 Pedro Alves <palves@redhat.com>
13470 * linux-nat.c: Include scope-exit.h.
13471 (cleanup_target_stop): Remove.
13472 (linux_nat_target::static_tracepoint_markers_by_strid): Use
13475 2019-01-23 Tom Tromey <tom@tromey.com>
13476 Pedro Alves <palves@redhat.com>
13478 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13479 (call_function_by_hand_dummy): Use SCOPE_EXIT.
13481 2019-01-23 Tom Tromey <tom@tromey.com>
13482 Andrew Burgess <andrew.burgess@embecosm.com>
13483 Pedro Alves <palves@redhat.com>
13485 * infrun.c (fetch_inferior_event): Use scope_exit.
13486 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13487 * top.c (execute_command): Use scope_exit.
13488 * breakpoint.c (bpstat_do_actions): Use scope_exit.
13489 * utils.c (do_bpstat_clear_actions_cleanup)
13490 (make_bpstat_clear_actions_cleanup): Remove.
13492 2019-01-23 Tom Tromey <tom@tromey.com>
13493 Pedro Alves <palves@redhat.com>
13495 * infrun.c: Include "common/scope-exit.h"
13496 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13497 (wait_for_inferior): Use SCOPE_EXIT.
13498 (fetch_inferior_event): Use scope_exit.
13500 2019-01-23 Tom Tromey <tom@tromey.com>
13501 Pedro Alves <palves@redhat.com>
13503 * breakpoint.c (create_breakpoint): Remove cleanup.
13505 2019-01-23 Tom Tromey <tom@tromey.com>
13506 Andrew Burgess <andrew.burgess@embecosm.com>
13507 Pedro Alves <palves@redhat.com>
13509 2019-01-23 Pedro Alves <palves@redhat.com>
13511 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13513 2019-01-23 Pedro Alves <palves@redhat.com>
13514 Andrew Burgess <andrew.burgess@embecosm.com>
13516 * gdbthread.h: Include "common/forward-scope-exit.h".
13517 (scoped_finish_thread_state): Redefine custom class in terms of
13518 forward_scope_exit.
13520 2019-01-23 Pedro Alves <palves@redhat.com>
13521 Andrew Burgess <andrew.burgess@embecosm.com>
13523 * common/forward-scope-exit.h: New file.
13525 2019-01-23 Pedro Alves <palves@redhat.com>
13526 Andrew Burgess <andrew.burgess@embecosm.com>
13527 Tom Tromey <tom@tromey.com>
13529 * common/scope-exit.h: New file.
13531 2019-01-23 Pedro Alves <palves@redhat.com>
13533 * common/preprocessor.h (ESC): Rename to ...
13534 (ESC_PARENS): ... this.
13535 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13536 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13538 2019-01-23 Tom Tromey <tom@tromey.com>
13540 * language.h (class scoped_switch_to_sym_language_if_auto):
13541 Initialize m_lang in both cases.
13543 2019-01-23 Alan Hayward <alan.hayward@arm.com>
13545 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13548 2019-01-22 Tom Tromey <tom@tromey.com>
13550 * corelow.c: Do not include sys/file.h.
13552 2019-01-22 Tom Tromey <tom@tromey.com>
13554 * tui/tui-wingeneral.h: Include gdb_curses.h.
13556 2019-01-22 Tom Tromey <tom@tromey.com>
13558 * source-cache.h (class source_cache) <get_source_lines,
13559 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13561 2019-01-22 Tom Tromey <tom@tromey.com>
13563 * remote-fileio.h (struct remote_target): Declare.
13565 2019-01-22 Tom Tromey <tom@tromey.com>
13567 * python/py-arch.c: Do not include py-ref.h.
13568 * python/py-bpevent.c: Do not include py-ref.h.
13569 * python/py-cmd.c: Do not include py-ref.h.
13570 * python/py-continueevent.c: Do not include py-ref.h.
13571 * python/py-event.h: Do not include py-ref.h.
13572 * python/py-evtregistry.c: Do not include py-ref.h.
13573 * python/py-finishbreakpoint.c: Do not include py-ref.h.
13574 * python/py-frame.c: Do not include py-ref.h.
13575 * python/py-framefilter.c: Do not include py-ref.h.
13576 * python/py-function.c: Do not include py-ref.h.
13577 * python/py-infevents.c: Do not include py-ref.h.
13578 * python/py-linetable.c: Do not include py-ref.h.
13579 * python/py-objfile.c: Do not include py-ref.h.
13580 * python/py-param.c: Do not include py-ref.h.
13581 * python/py-prettyprint.c: Do not include py-ref.h.
13582 * python/py-progspace.c: Do not include py-ref.h.
13583 * python/py-symbol.c: Do not include py-ref.h.
13584 * python/py-symtab.c: Do not include py-ref.h.
13585 * python/py-type.c: Do not include py-ref.h.
13586 * python/py-unwind.c: Do not include py-ref.h.
13587 * python/py-utils.c: Do not include py-ref.h.
13588 * python/py-value.c: Do not include py-ref.h.
13589 * python/py-varobj.c: Do not include py-ref.h.
13590 * python/py-xmethods.c: Do not include py-ref.h.
13591 * python/python.c: Do not include py-ref.h.
13592 * varobj.c: Do not include py-ref.h.
13594 2019-01-22 Tom Tromey <tom@tromey.com>
13596 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13597 keyword for bcache.
13599 2019-01-22 Tom Tromey <tom@tromey.com>
13601 * compile/compile-cplus-types.c: Remove a comment by #include.
13603 2019-01-22 Tom Tromey <tom@tromey.com>
13605 * compile/gcc-c-plugin.h: Include compile-internal.h.
13607 2019-01-22 Tom Tromey <tom@tromey.com>
13609 * stabsread.c (EXTERN): Do not define.
13610 (symnum, next_symbol_text_func, processing_gcc_compilation)
13611 (within_function, global_sym_chain, global_stabs)
13612 (previous_stab_code, this_object_header_files)
13613 (n_this_object_header_files)
13614 (n_allocated_this_object_header_files): Define.
13615 * stabsread.h (EXTERN): Never define. Use "extern".
13617 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13619 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13622 2019-01-21 Tom Tromey <tom@tromey.com>
13624 * ui-out.c: Fix includes.
13625 * tui/tui-source.c: Fix includes.
13626 * target.c: Fix includes.
13627 * remote.c: Fix includes.
13628 * regcache.c: Fix includes.
13629 * python/py-block.c: Fix includes.
13630 * printcmd.c: Fix includes.
13631 * or1k-tdep.c: Fix includes.
13632 * mi/mi-main.c: Fix includes.
13633 * m32r-tdep.c: Fix includes.
13634 * csky-tdep.c: Fix includes.
13635 * compile/compile-cplus-types.c: Fix includes.
13636 * cli/cli-interp.c: Fix includes.
13638 2019-01-21 Alan Hayward <alan.hayward@arm.com>
13640 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13643 2019-01-16 Tom Tromey <tom@tromey.com>
13645 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
13647 (struct objfile) <msymbols_range>: Move from top level.
13648 <msymbols>: New method.
13649 (class objfile_msymbols): Remove.
13650 * symtab.c (default_collect_symbol_completion_matches_break_on):
13652 * symmisc.c (dump_msymbols): Update.
13653 * stabsread.c (scan_file_globals): Update.
13654 * objc-lang.c (info_selectors_command, info_classes_command)
13655 (find_methods): Update.
13656 * minsyms.c (find_solib_trampoline_target): Update.
13657 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13658 * coffread.c (coff_symfile_read): Update.
13659 * ada-lang.c (ada_lookup_simple_minsym)
13660 (ada_collect_symbol_completion_matches): Update.
13662 2019-01-16 Tom Tromey <tom@tromey.com>
13664 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13665 type. Remove no-argument constructor.
13666 <iterator::operator++>: Simplify.
13668 <end>: Use minimal_symbol_count.
13670 2019-01-16 Tom Tromey <tom@tromey.com>
13672 * objfiles.h (struct objfile) <psymtabs>: New method.
13673 (class objfile_psymtabs): Remove.
13674 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13676 <range>: New method.
13677 (require_partial_symbols): Change return type.
13678 * psymtab.c (require_partial_symbols)
13679 (psym_expand_symtabs_matching): Update.
13680 * mdebugread.c (parse_partial_symbols): Update.
13681 * dbxread.c (dbx_end_psymtab): Update.
13683 2019-01-15 Tom Tromey <tom@tromey.com>
13685 * symtab.c (lookup_objfile_from_block)
13686 (lookup_symbol_in_objfile_symtabs)
13687 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13688 (find_line_symtab, info_sources_command)
13689 (default_collect_symbol_completion_matches_break_on)
13690 (make_source_files_completion_list): Update.
13691 * symmisc.c (print_objfile_statistics, dump_objfile)
13692 (maintenance_print_symbols, maintenance_info_symtabs)
13693 (maintenance_check_symtabs, maintenance_info_line_tables):
13695 * source.c (select_source_symtab)
13696 (forget_cached_source_info_for_objfile): Update.
13697 * objfiles.h (class objfile_compunits): Remove.
13698 (struct objfile) <compunits_range>: New typedef.
13699 (compunits): New method.
13700 * objfiles.c (objfile_relocate1): Update.
13701 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13702 * maint.c (count_symtabs_and_blocks): Update.
13703 * linespec.c (iterate_over_all_matching_symtabs): Update.
13704 * cp-support.c (add_symbol_overload_list_qualified): Update.
13705 * coffread.c (coff_symtab_read): Update.
13706 * ada-lang.c (add_nonlocal_symbols)
13707 (ada_collect_symbol_completion_matches)
13708 (ada_add_global_exceptions): Update.
13710 2019-01-15 Tom Tromey <tom@tromey.com>
13712 * progspace.h (program_space) <objfiles_safe_range>: New
13714 <objfiles_safe>: New method.
13715 * objfiles.h (class all_objfiles_safe): Remove.
13716 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13717 * jit.c (jit_inferior_exit_hook): Update.
13719 2019-01-17 Tom Tromey <tom@tromey.com>
13721 * progspace.h (program_space) <objfiles_range>: New typedef.
13722 <objfiles>: New method.
13723 <objfiles_head>: Rename from objfiles.
13724 (object_files): Update.
13725 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13726 * guile/scm-pretty-print.c
13727 (ppscm_find_pretty_printer_from_objfiles): Update.
13728 * guile/scm-objfile.c (gdbscm_objfiles): Update.
13729 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13731 * python/py-progspace.c (pspy_get_objfiles): Update.
13732 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13734 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13735 (objfpy_lookup_objfile_by_build_id): Update.
13736 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13737 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13739 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13740 (expand_symtab_containing_pc, lookup_objfile_from_block)
13741 (lookup_static_symbol, basic_lookup_transparent_type)
13742 (find_pc_sect_compunit_symtab, find_symbol_at_address)
13743 (find_line_symtab, info_sources_command)
13744 (default_collect_symbol_completion_matches_break_on)
13745 (make_source_files_completion_list, find_main_name): Update.
13746 * symmisc.c (print_symbol_bcache_statistics)
13747 (print_objfile_statistics, maintenance_print_symbols)
13748 (maintenance_print_msymbols, maintenance_print_objfiles)
13749 (maintenance_info_symtabs, maintenance_check_symtabs)
13750 (maintenance_expand_symtabs, maintenance_info_line_tables):
13752 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13753 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13754 (map_overlay_command, unmap_overlay_command)
13755 (simple_overlay_update, expand_symtabs_matching)
13756 (map_symbol_filenames): Update.
13757 * symfile-debug.c (set_debug_symfile): Update.
13758 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13760 * source.c (select_source_symtab, forget_cached_source_info):
13762 * solib.c (solib_read_symbols): Update.
13763 * solib-spu.c (append_ocl_sos): Update.
13764 * psymtab.c (maintenance_print_psymbols)
13765 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13766 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13767 * printcmd.c (info_symbol_command): Update.
13768 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13770 * objfiles.h (class all_objfiles): Remove.
13771 * objfiles.c (have_partial_symbols, have_full_symbols)
13772 (have_minimal_symbols, qsort_cmp, update_section_map)
13773 (shared_objfile_contains_address_p)
13774 (default_iterate_over_objfiles_in_search_order): Update.
13775 * objc-lang.c (info_selectors_command, info_classes_command)
13776 (find_methods): Update.
13777 * minsyms.c (find_solib_trampoline_target): Update.
13778 * maint.c (maintenance_info_sections)
13779 (maintenance_translate_address, count_symtabs_and_blocks):
13781 * main.c (captured_main_1): Update.
13782 * linux-thread-db.c (try_thread_db_load_from_pdir)
13783 (has_libpthread): Update.
13784 * linespec.c (iterate_over_all_matching_symtabs)
13785 (search_minsyms_for_name): Update.
13786 * jit.c (jit_find_objf_with_entry_addr): Update.
13787 * hppa-tdep.c (find_unwind_entry)
13788 (hppa_lookup_stub_minimal_symbol): Update.
13789 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13791 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13792 (elf_gnu_ifunc_resolve_by_got): Update.
13793 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13794 * dwarf-index-write.c (save_gdb_index_command): Update.
13795 * cp-support.c (add_symbol_overload_list_qualified): Update.
13796 * breakpoint.c (create_overlay_event_breakpoint)
13797 (create_longjmp_master_breakpoint)
13798 (create_std_terminate_master_breakpoint)
13799 (create_exception_master_breakpoint): Update.
13800 * blockframe.c (find_pc_partial_function): Update.
13801 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13802 (ada_collect_symbol_completion_matches)
13803 (ada_add_global_exceptions): Update.
13805 2019-01-17 Tom Tromey <tom@tromey.com>
13807 * solib-target.c (lm_info_target_p): Remove typedef. Don't
13809 (solib_target_parse_libraries): Change return type.
13810 (library_list_start_segment, library_list_start_section)
13811 (library_list_end_library, library_list_start_library); Update.
13812 (solib_target_free_library_list): Remove.
13813 (solib_target_parse_libraries): Remove cleanup. Change return
13815 (solib_target_current_sos): Update.
13817 2019-01-17 Tom Tromey <tromey@bapiya>
13819 * valprint.c: Replace "the the" with "the".
13820 * symtab.c: Replace "the the" with "the".
13821 * solib.c: Replace "the the" with "the".
13822 * solib-dsbt.c: Replace "the the" with "the".
13823 * linespec.c: Replace "the the" with "the".
13824 * dwarf2loc.h: Replace "the the" with "the".
13825 * amd64-windows-tdep.c: Replace "the the" with "the".
13826 * aarch64-tdep.c: Replace "the the" with "the".
13828 2019-01-16 Keith Seitz <keiths@redhat.com>
13831 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13832 <builder>: Rename to ..
13833 <m_builder>: ... this and make private.
13834 (dwarf2_cu::get_builder): New method. Change all users of
13835 `builder' to use this method.
13836 (dwarf2_start_symtab): Move to ...
13837 (dwarf2_cu::start_symtab): ... here. Update all callers
13838 (setup_type_unit_groups): Move to ...
13839 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
13841 (dwarf2_cu::reset_builder): New method.
13842 (process_full_compunit, process_full_type_unit): Use
13843 dwarf2_cu::reset_builder.
13844 (follow_die_offset): Record the ancestor CU if it is different
13845 from the followed DIE's CU.
13846 (follow_die_sig_1): Likewise.
13848 2019-01-15 Tom Tromey <tom@tromey.com>
13850 * remote.c (class remote_state) <buf>: Now a char_vector.
13851 <buf_size>: Remove.
13852 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
13854 (remote_target::getpkt_or_notif_sane_1)
13855 (remote_target::getpkt_sane)
13856 (remote_target::getpkt_or_notif_sane): Likewise.
13857 (class remote_target) <putpkt>: New overload.
13858 (remote_target::read_frame): Change type of "buf_p". Remove
13859 sizeof_p parameter.
13860 (packet_ok): New overload.
13861 (packet_check_result): New overload.
13864 2019-01-14 Tom Tromey <tom@tromey.com>
13866 * remote-notif.c (handle_notification, remote_notif_ack)
13867 (remote_notif_parse): Make "buf" const.
13868 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13870 (remote_notif_parse, remote_notif_ack, handle_notification):
13872 * remote.c (remote_notif_stop_parse): Make "buf" const.
13873 (remote_target::remote_parse_stop_reply): Make "buf" const.
13874 (remote_notif_stop_ack): Make "buf" const.
13876 2019-01-14 Tom Tromey <tom@tromey.com>
13878 * remote.c (remote_console_output): Make parameter const.
13880 2019-01-14 Tom Tromey <tom@tromey.com>
13882 * target-debug.h (target_debug_print_signals): Constify.
13883 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13884 * procfs.c (procfs_target::pass_signals): Update.
13885 * linux-nat.c (linux_nat_target::pass_signals): Update.
13886 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13887 * target-delegates.c: Rebuild.
13888 * remote.c (remote_target::program_signals): Update.
13889 (remote_target::pass_signals): Update.
13890 * target.c (target_pass_signals): Constify argument.
13891 (target_program_signals): Likewise.
13892 * target.h (struct target_ops) <pass_signals, program_signals>:
13894 (target_pass_signals, target_program_signals): Constify argument.
13896 2019-01-14 Tom Tromey <tom@tromey.com>
13899 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13901 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
13903 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13905 * rs6000-tdep.c: Include reggroups.h.
13906 (IS_V_ALIAS_PSEUDOREG): Define.
13907 (rs6000_register_name): Return names for the "vX" aliases.
13908 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13909 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
13910 aliases. Call default_register_reggroup_p for all other
13912 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13914 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13915 Handle "vX" aliases.
13916 (v_alias_pseudo_register_collect): New function.
13917 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13918 (rs6000_gdbarch_init): Initialize "vX" aliases as
13919 pseudo-registers. Restore registration of
13920 rs6000_pseudo_register_reggroup_p with
13921 set_tdesc_pseudo_register_reggroup_p.
13923 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
13925 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13926 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13927 set_gdbarch_num_pseudo_regs.
13929 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13931 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13932 Remove arg prefixname, add do_set and do_show.
13933 Add member functions set_list and show_list.
13934 * cli/cli-style.c (class cli_style_option): Update accordingly.
13935 (style_set_list): Move to file scope.
13936 (style_show_list): Likewise.
13937 (set_style): Call help_list.
13938 (show_style): Call cmd_show_list.
13939 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13940 Update to use the new macro.
13942 2019-10-12 Joel Brobecker <brobecker@adacore.com>
13944 * ada-lang.c (_initialize_ada_language): Expand the help text
13945 for the "catch exception" command.
13947 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13949 * symtab.c (matching_obj_sections): Initialize obj,
13950 declare it closer to its usage.
13952 2019-01-10 Tom Tromey <tom@tromey.com>
13954 * thread-iter.h (inf_threads_iterator): Use next_iterator.
13955 (basic_inf_threads_range): Remove.
13956 (inf_threads_range, inf_non_exited_threads_range)
13957 (safe_inf_threads_range): Use next_adapter.
13959 2019-01-10 Keith Seitz <keiths@redhat.com>
13963 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13964 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13966 2019-01-10 Keith Seitz <keiths@redhat.com>
13970 * dictionary.c (pending_to_vector): Remove.
13971 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13972 Remove _1 suffix, replacing functions of the same name. Update
13974 (dict_create_hashed, dict_create_hashed_expandable)
13975 (dict_create_linear, dict_create_linear_expandable, dict_free)
13976 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13977 Make functions static.
13979 2019-01-10 Keith Seitz <keiths@redhat.com>
13983 * dictionary.h (struct dictionary): Replace declaration with
13985 (dict_create_hashed, dict_create_hashed_expandable)
13986 (dict_create_linear, dict_create_linear_expandable)
13987 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13988 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13989 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13990 taking multidictionary argument.
13991 [ALL_DICT_SYMBOLS]: Update for multidictionary.
13992 * block.h (struct block) <dict>: Change to multidictionary
13993 and rename `multidict'.
13994 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13995 symmisc.c: Update all dictionary references to multidictionary.
13997 2019-01-10 Keith Seitz <keiths@redhat.com>
14001 * dictionary.c: Include unordered_map.
14002 (pending_to_vector): New function.
14003 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14004 Rewrite the non-"_1" functions to take vector instead
14006 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14007 "new" _1 versions of the same name.
14008 (multidictionary): Define.
14009 (std::hash<enum language): New definition.
14010 (collate_pending_symbols_by_language, mdict_create_hashed)
14011 (mdict_create_hashed_expandable, mdict_create_linear)
14012 (mdict_create_linear_expandable, mdict_free)
14013 (find_language_dictionary, create_new_language_dictionary)
14014 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14015 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14016 (mdict_size, mdict_empty): New functions.
14017 * dictionary.h (mdict_iterator): Define.
14019 2019-01-10 Pedro Alves <palves@redhat.com>
14021 * breakpoint.c (read_uploaded_action)
14022 (create_tracepoint_from_upload): Adjust to use
14023 gdb::unique_xmalloc_ptr.
14024 * ctf.c (ctf_write_uploaded_tp):
14025 (SET_ARRAY_FIELD): Use emplace_back.
14026 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14027 * tracefile-tfile.c (tfile_write_uploaded_tp):
14028 * tracepoint.c (parse_tracepoint_definition): Adjust to use
14029 gdb::unique_xmalloc_ptr.
14030 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14031 at_string, cond_string, cmd_strings>: Replace char pointers
14032 with gdb::unique_xmalloc_ptr.
14034 2019-01-10 Pedro Alves <palves@redhat.com>
14036 * solib-target.c (library_list_start_library): Don't xstrdup name.
14038 2019-01-10 Pedro Alves <palves@redhat.com>
14040 * mdebugread.c (parse_partial_symbols): Use
14041 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14043 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
14045 * linux-fork.c (scoped_switch_fork_info)
14046 <~scoped_switch_fork_info>: Fix incorrect variable name.
14048 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
14050 * linux-fork.c (scoped_switch_fork_info)
14051 <scoped_switch_fork_info>: Make explicit.
14052 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14054 2019-01-10 Tom Tromey <tom@tromey.com>
14056 * objfiles.h (objfile::reset_psymtabs): Update.
14057 * objfiles.c (objfile::objfile): Update.
14058 * psymtab.h (psymtab_storage::obstack): Update.
14059 (psymtab_storage::m_obstack): Use gdb::optional.
14060 (class psymtab_storage): Update comment. Remove objfile
14062 * psymtab.c (psymtab_storage::psymtab_storage): Update.
14064 2019-01-10 Tom Tromey <tom@tromey.com>
14066 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14067 <free_psymtabs>: Now private.
14068 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14069 (allocate_psymtab): Use new method.
14071 2019-01-10 Tom Tromey <tom@tromey.com>
14073 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14074 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14075 * mdebugread.c (parse_partial_symbols): Use
14076 allocate_dependencies.
14077 * dwarf2read.c (dwarf2_create_include_psymtab): Use
14078 allocate_dependencies.
14079 (process_psymtab_comp_unit_reader)
14080 (build_type_psymtab_dependencies): Likewise.
14081 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14083 2019-01-10 Tom Tromey <tom@tromey.com>
14085 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14086 PSYMBOL_SET_LANGUAGE.
14087 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14089 2019-01-10 Tom Tromey <tom@tromey.com>
14091 * psymtab.h (psymtab_storage::obstack): New method.
14092 <m_obstack>: Rename from obstack; now private.
14093 * psymtab.c (psymtab_storage): Update.
14094 * dwarf2read.c (create_addrmap_from_index)
14095 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14098 2019-01-10 Tom Tromey <tom@tromey.com>
14100 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14101 * objfiles.h (objfile::reset_psymtabs): New method.
14103 2019-01-10 Tom Tromey <tom@tromey.com>
14105 * symmisc.c (print_symbol_bcache_statistics): Update.
14106 (print_objfile_statistics): Update.
14107 * symfile.c (reread_symbols): Update.
14108 * psymtab.h (class psymtab_storage): New.
14109 * psymtab.c (psymtab_storage): New constructor.
14110 (~psymtab_storage): New destructor.
14111 (require_partial_symbols): Update.
14112 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14113 (find_pc_sect_psymtab, find_pc_sect_psymbol)
14114 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14115 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14116 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14117 (start_psymtab_common, end_psymtab_common)
14118 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14119 (allocate_psymtab): Update.
14120 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14122 (dump_psymtab_addrmap, maintenance_print_psymbols)
14123 (maintenance_check_psymtabs): Update.
14124 (class objfile_psymtabs): Move to objfiles.h.
14125 * psympriv.h (discard_psymtab): Now inline.
14126 (psymtab_discarder::psymtab_discarder): Update.
14127 (psymtab_discarder::~psymtab_discarder): Update.
14128 (ALL_OBJFILE_PSYMTABS): Rewrite.
14129 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14130 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14132 <partial_symtabs>: New field.
14133 (class objfile_psymtabs): Move from psymtab.h. Update.
14134 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14136 (objfile::~objfile): Don't destroy psymbol_cache.
14137 * mdebugread.c (parse_partial_symbols): Update.
14138 * dwarf2read.c (create_addrmap_from_index)
14139 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14140 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14141 (add_partial_subprogram, dwarf2_ranges_read): Update.
14142 * dwarf-index-write.c (write_address_map)
14143 (write_one_signatured_type, recursively_write_psymbols)
14144 (class debug_names, class debug_names, write_psymtabs_to_index):
14147 2019-01-10 Tom Tromey <tom@tromey.com>
14149 * symtab.h (SYMBOL_SET_NAMES): Update.
14150 (symbol_set_names): Update.
14151 (MSYMBOL_SET_NAMES): Update.
14152 * symtab.c (symbol_set_names): Change argument to be an
14153 objfile_per_bfd_storage.
14154 * psymtab.c (add_psymbol_to_bcache): Update.
14155 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14157 2019-01-10 Tom Tromey <tom@tromey.com>
14159 * symtab.c (create_demangled_names_hash): Change argument to be an
14160 objfile_per_bfd_storage.
14161 (symbol_set_names): Update.
14163 2019-01-10 Tom Tromey <tom@tromey.com>
14165 * xcoffread.c (xcoff_initial_scan): Unconditionally call
14167 * psymtab.c (init_psymbol_list): Do nothing if already called.
14168 * psympriv.h (init_psymbol_list): Add comment.
14169 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14171 * dbxread.c (dbx_symfile_read): Unconditionally call
14174 2019-01-10 Tom Tromey <tom@tromey.com>
14176 * xcoffread.c (scan_xcoff_symtab): Update.
14177 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14179 * mdebugread.c (parse_partial_symbols)
14180 (handle_psymbol_enumerators): Update.
14181 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14182 * dbxread.c (read_dbx_symtab): Update.
14183 * psympriv.h (psymbol_placement): New enum.
14184 (add_psymbol_to_list): Update.
14186 2019-01-10 Tom Tromey <tom@tromey.com>
14188 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14189 static_psymbols parameters.
14190 (scan_xcoff_symtab): Update.
14191 * psymtab.c (start_psymtab_common): Remove global_psymbols and
14192 static_psymbols parameters.
14193 * psympriv.h (start_psymtab_common): Update.
14194 * mdebugread.c (parse_partial_symbols): Update.
14195 * dwarf2read.c (create_partial_symtab): Update.
14196 * dbxread.c (read_dbx_symtab): Update.
14197 (start_psymtab): Remove global_psymbols and static_psymbols
14200 2019-01-10 Tom Tromey <tom@tromey.com>
14202 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14203 * psymtab.c (allocate_psymtab): Add comment.
14204 * psympriv.h (allocate_psymtab): Add comment.
14205 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14207 * dbxread.c (dbx_end_psymtab): Remove some initializations.
14209 2019-01-10 Tom Tromey <tom@tromey.com>
14211 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14213 * mipsread.c: Include mdebugread.h.
14214 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14216 * elfread.c: Include mdebugread.h.
14218 2019-01-09 Tom Tromey <tom@tromey.com>
14220 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14221 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14222 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14223 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14224 (psym_lookup_symbol, psym_find_last_source_symtab)
14225 (psym_forget_cached_source_info, psym_print_stats)
14226 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14227 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14228 (psym_map_matching_symbols, psym_expand_symtabs_matching)
14229 (psym_find_compunit_symtab_by_address)
14230 (maintenance_print_psymbols, maintenance_info_psymtabs)
14231 (maintenance_check_psymtabs): Use ranged for.
14232 * psymtab.h (class objfile_psymtabs): New.
14233 (require_partial_symbols): Return objfile_psymtabs.
14234 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14236 2019-01-09 Tom Tromey <tom@tromey.com>
14238 * symfile.c (overlay_invalidate_all, find_pc_overlay)
14239 (find_pc_mapped_section, list_overlays_command)
14240 (map_overlay_command, unmap_overlay_command)
14241 (simple_overlay_update): Use all_objfiles.
14242 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14243 * printcmd.c (info_symbol_command): Use all_objfiles.
14244 * objfiles.h (ALL_OBJSECTIONS): Remove.
14245 * maint.c (maintenance_translate_address): Use all_objfiles.
14246 * gcore.c (gcore_create_callback): Use all_objfiles.
14247 (objfile_find_memory_regions): Likewise.
14249 2019-01-09 Tom Tromey <tom@tromey.com>
14251 * symtab.c (find_line_symtab, info_sources_command)
14252 (make_source_files_completion_list): Use objfile_compunits.
14253 * source.c (select_source_symtab): Use objfile_compunits.
14254 * objfiles.h (struct objfile): Update comment.
14255 (ALL_OBJFILES): Remove.
14256 (ALL_FILETABS): Remove.
14257 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14260 2019-01-09 Tom Tromey <tom@tromey.com>
14262 * symmisc.c (print_objfile_statistics, dump_objfile)
14263 (maintenance_print_symbols): Use compunit_filetabs.
14264 * source.c (forget_cached_source_info_for_objfile): Use
14266 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14267 (ALL_FILETABS): Use compunit_filetabs.
14268 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14269 * coffread.c (coff_symtab_read): Use compunit_filetabs.
14271 2019-01-09 Tom Tromey <tom@tromey.com>
14273 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14274 (compunit_filetabs): New.
14275 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14277 (info_sources_command, make_source_files_completion_list): Remove
14279 * symmisc.c (print_objfile_statistics, dump_objfile)
14280 (maintenance_print_symbols): Remove declaration.
14281 (maintenance_info_symtabs): Use compunit_filetabs.
14282 (maintenance_info_line_tables): Likewise.
14283 * source.c (select_source_symtab): Change local variable name.
14284 (forget_cached_source_info_for_objfile): Remove declaration.
14285 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14286 * objfiles.c (objfile_relocate1): Remove declaration.
14287 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14289 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14290 * coffread.c (coff_symtab_read): Remove declaration.
14291 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14294 2019-01-09 Tom Tromey <tom@tromey.com>
14296 * symtab.c (lookup_objfile_from_block)
14297 (find_pc_sect_compunit_symtab, search_symbols)
14298 (default_collect_symbol_completion_matches_break_on): Use
14300 * objfiles.h (ALL_COMPUNITS): Remove.
14301 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14302 * cp-support.c (add_symbol_overload_list_qualified): Use
14304 * ada-lang.c (ada_collect_symbol_completion_matches)
14305 (ada_add_global_exceptions): Use objfile_compunits.
14307 2019-01-09 Tom Tromey <tom@tromey.com>
14309 * source.c (select_source_symtab)
14310 (forget_cached_source_info_for_objfile): Remove declaration.
14311 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14313 * maint.c (count_symtabs_and_blocks): Remove declaration.
14314 * cp-support.c (add_symbol_overload_list_qualified): Remove
14316 * coffread.c (coff_symtab_read): Remove declaration.
14317 * symtab.c (lookup_symbol_in_objfile_symtabs)
14318 (basic_lookup_transparent_type_1): Use objfile_compunits.
14319 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14320 (info_sources_command, search_symbols)
14321 (default_collect_symbol_completion_matches_break_on)
14322 (make_source_files_completion_list): Remove declaration.
14323 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14324 (ada_collect_symbol_completion_matches)
14325 (ada_add_global_exceptions): Remove declaration.
14326 * linespec.c (iterate_over_all_matching_symtabs): Use
14328 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14329 (class objfile_compunits): New.
14330 (ALL_COMPUNITS): Use objfile_compunits.
14331 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14332 (maintenance_check_symtabs, maintenance_info_line_tables): Use
14334 * objfiles.c (objfile_relocate1): Use objfile_compunits.
14336 2019-01-09 Tom Tromey <tom@tromey.com>
14338 * symtab.c (search_symbols)
14339 (default_collect_symbol_completion_matches_break_on): Use
14341 * ada-lang.c (ada_lookup_simple_minsym)
14342 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14343 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14344 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14346 * coffread.c (coff_symfile_read): Use objfile_msymbols.
14347 * symmisc.c (dump_msymbols): Use objfile_msymbols.
14348 * objc-lang.c (find_methods): Use objfile_msymbols.
14349 (info_selectors_command, info_classes_command): Likewise.
14350 * stabsread.c (scan_file_globals): Use objfile_msymbols.
14351 * objfiles.h (class objfile_msymbols): New.
14352 (ALL_OBJFILE_MSYMBOLS): Remove.
14353 (ALL_MSYMBOLS): Remove.
14355 2019-01-09 Tom Tromey <tom@tromey.com>
14357 * common/next-iterator.h (next_adapter): Add Iterator template
14359 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14360 (class all_objfiles_safe): New.
14361 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14362 * objfiles.c (put_objfile_before): Update comment.
14363 (add_separate_debug_objfile): Likewise.
14364 (free_all_objfiles): Use all_objfiles_safe.
14365 (objfile_purge_solibs): Likewise.
14367 2019-01-09 Tom Tromey <tom@tromey.com>
14369 * symtab.c (iterate_over_symtabs, matching_obj_sections)
14370 (expand_symtab_containing_pc, lookup_static_symbol)
14371 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14372 (find_symbol_at_address, find_line_symtab, find_main_name): Use
14374 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14375 * breakpoint.c (create_overlay_event_breakpoint)
14376 (create_longjmp_master_breakpoint)
14377 (create_std_terminate_master_breakpoint)
14378 (create_exception_master_breakpoint): Use all_objfiles.
14379 * linux-thread-db.c (try_thread_db_load_from_pdir)
14380 (has_libpthread): Use all_objfiles.
14381 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14382 * linespec.c (iterate_over_all_matching_symtabs)
14383 (search_minsyms_for_name): Use all_objfiles.
14384 * maint.c (maintenance_info_sections): Use all_objfiles.
14385 * main.c (captured_main_1): Use all_objfiles.
14386 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14387 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14388 * guile/scm-pretty-print.c
14389 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14390 * solib-spu.c (append_ocl_sos): Use all_objfiles.
14391 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14392 (maintenance_print_msymbols): Use all_objfiles.
14393 * source.c (select_source_symtab): Use all_objfiles.
14394 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14395 * symfile.c (remove_symbol_file_command)
14396 (expand_symtabs_matching, map_symbol_filenames): Use
14398 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14400 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14401 * objc-lang.c (find_methods): Use all_objfiles.
14402 * objfiles.c (have_partial_symbols, have_full_symbols)
14403 (have_minimal_symbols, qsort_cmp)
14404 (default_iterate_over_objfiles_in_search_order): Use
14406 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14407 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14408 (maintenance_check_psymtabs): Use all_objfiles.
14409 (ALL_PSYMTABS): Remove.
14410 * compile/compile-object-run.c (do_module_cleanup): Use
14412 * blockframe.c (find_pc_partial_function): Use all_objfiles.
14413 * cp-support.c (add_symbol_overload_list_qualified): Use
14415 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14417 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14418 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14420 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14421 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14422 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14424 * solib.c (solib_read_symbols): Use all_objfiles
14426 2019-01-09 Tom Tromey <tom@tromey.com>
14428 * probe.c (parse_probes_in_pspace): Use all_objfiles.
14429 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14431 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14432 * symmisc.c (print_symbol_bcache_statistics)
14433 (print_objfile_statistics, maintenance_print_objfiles)
14434 (maintenance_info_symtabs, maintenance_check_symtabs)
14435 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14437 * source.c (forget_cached_source_info): Use all_objfiles.
14438 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14439 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14440 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14441 * objfiles.c (update_section_map): Use all_objfiles.
14442 (shared_objfile_contains_address_p): Likewise.
14443 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14444 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14446 2019-01-09 Tom Tromey <tom@tromey.com>
14448 * common/next-iterator.h: New file.
14449 * objfiles.h (class all_objfiles): New.
14450 (struct objfile_iterator): New.
14452 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14454 * NEWS: Move the description of the changed "frame", "select-frame",
14455 and "info frame" commands to the Changed commands section.
14457 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
14459 * gdbtypes.c (check_stub_method_group): Remove handling of old
14461 * linespec.c (find_methods): Likewise.
14462 * stabsread.c (read_member_functions): Likewise.
14463 * valops.c (search_struct_method): Likewise.
14464 (value_struct_elt_for_reference): Likewise.
14465 * NEWS: Mention this change.
14467 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
14469 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14470 print_source_lines.
14471 * source.c (print_source_lines_base): Update line number check.
14472 (print_source_lines): New function.
14473 (source_lines_range::source_lines_range): New function.
14474 * source.h (class source_lines_range): New class.
14475 (print_source_lines): New declaration.
14477 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14479 * linespec.c (linespec_state_destructor): Free self->canonical_names.
14481 2019-01-08 Tom Tromey <tom@tromey.com>
14482 Simon Marchi <simon.marchi@ericsson.com>
14485 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14486 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14487 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14488 * f-exp.y (DOLLAR_VARIABLE): Likewise.
14489 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14490 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14492 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
14494 * source.c (select_source_symtab): Move header comment to
14495 declaration in source.h.
14496 (forget_cached_source_info_for_objfile): Likewise.
14497 (forget_cached_source_info): Likewise.
14498 (identify_source_line): Likewise.
14499 * source.h (identify_source_line): Move declaration from symtab.h
14500 and add comment from source.c
14501 (print_source_lines): Likewise.
14502 (forget_cached_source_info_for_objfile): Likewise.
14503 (forget_cached_source_info): Likewise.
14504 (select_source_symtab): Likewise.
14505 (enum print_source_lines_flag): Move definition from symtab.h.
14506 * symtab.h (identify_source_line): Move declaration to source.h.
14507 (print_source_lines): Likewise.
14508 (forget_cached_source_info_for_objfile): Likewise.
14509 (forget_cached_source_info): Likewise.
14510 (select_source_symtab): Likewise.
14511 (enum print_source_lines_flag): Move definition to source.h.
14512 * tui/tui-hooks.c: Add 'source.h' include.
14514 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
14516 * source.c (print_source_lines_base): Handle requests to print
14517 reverse line number sequences, and guard against empty lines
14520 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
14522 * source.c (print_source_lines_base): Fix skip of '\r' if next
14525 2019-01-06 Tom Tromey <tom@tromey.com>
14527 * c-exp.y (struct c_parse_state) <macro_original_text,
14528 expansion_obstack>: New member.
14529 (macro_original_text, expansion_obstack): Remove globals.
14530 (scan_macro_expansion, scanning_macro_expansion)
14531 (finished_macro_expansion): Update.
14532 (scan_macro_cleanup): Remove.
14533 (yylex, c_parse): Update.
14535 2019-01-06 Tom Tromey <tom@tromey.com>
14537 * c-exp.y (struct c_parse_state) <strings>: New member.
14538 (operator_stoken): Update.
14540 2019-01-06 Tom Tromey <tom@tromey.com>
14542 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
14543 (union type_stack_elt) <typelist_val>: Now a pointer to
14545 (type_stack_cleanup): Don't declare.
14546 (push_typelist): Update.
14547 * parse.c (pop_typelist): Return a std::vector.
14548 (push_typelist): Take a std::vector.
14549 (follow_types): Update. Do not free args.
14550 (type_stack_cleanup): Remove.
14551 * c-exp.y (struct c_parse_state): New.
14552 (cpstate): New global.
14553 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14554 (nonempty_typelist): Update.
14555 (func_mod): Create a new vector.
14556 (c_parse): Create a c_parse_state.
14557 (check_parameter_typelist): Do not delete params.
14558 (function_method): Update. Do not delete type_list.
14560 2019-01-06 Tom Tromey <tom@tromey.com>
14563 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14565 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14566 (print_return_value): Likewise.
14568 2019-01-05 Tom Tromey <tom@tromey.com>
14570 * contrib/cleanup_check.py: Remove.
14571 * contrib/gcc-with-excheck: Remove.
14572 * contrib/exsummary.py: Remove.
14573 * contrib/excheck.py: Remove.
14575 2019-01-05 Joel Brobecker <brobecker@adacore.com>
14577 * thread.c (delete_thread_1): Add gdb_assert that THR is not
14578 NULL. Initialize tpprev to NULL instead of assigning it
14579 to NULL on the next statement.
14580 * windows-nat.c (windows_delete_thread): Remove check for
14581 main_thread_id before printing thread exit notifications.
14582 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14583 Remove thread ID check against main_thread_id.
14584 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14585 windows_delete_thread.
14586 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14588 2019-01-04 Tom Tromey <tom@tromey.com>
14590 * compile/compile.c (_initialize_compile): Use upper case for
14591 metasyntactic variables.
14592 * symmisc.c (_initialize_symmisc): Use upper case for
14593 metasyntactic variables.
14594 * psymtab.c (_initialize_psymtab): Use upper case for
14595 metasyntactic variables.
14596 * demangle.c (demangle_command): Use upper case for metasyntactic
14598 (_initialize_demangler): Likewise.
14599 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14602 2019-01-03 Tom Tromey <tom@tromey.com>
14604 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14606 2019-01-03 Tom Tromey <tom@tromey.com>
14608 * python/py-symtab.c (salpy_str): Update.
14609 (struct salpy_sal_object) <symtab>: Now a PyObject.
14610 (salpy_dealloc): Update.
14611 (del_objfile_sal): Use gdbpy_ref.
14613 2019-01-03 Tom Tromey <tom@tromey.com>
14615 * python/py-type.c (convert_field): Use new_reference. Return
14617 (make_fielditem): Return gdbpy_ref.
14618 (typy_fields): Update.
14619 (typy_getitem): Update.
14620 (field_name): Return gdbpy_ref. Use new_reference.
14621 (typy_iterator_iternext): Update.
14623 2019-01-03 Tom Tromey <tom@tromey.com>
14625 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14627 2019-01-03 Tom Tromey <tom@tromey.com>
14629 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14630 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14631 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14632 (pspy_set_frame_filters, pspy_set_frame_unwinders)
14633 (pspy_set_type_printers): Likewise.
14634 * python/py-function.c (fnpy_init): Use gdbpy_ref.
14635 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14636 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14637 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14638 (objfpy_set_type_printers): Likewise.
14640 2019-01-03 Tom Tromey <tom@tromey.com>
14642 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14643 (gdbpy_print_stack): Use gdbpy_err_fetch.
14644 * python/python-internal.h (class gdbpy_err_fetch): New class.
14645 (class gdbpy_enter) <m_error_type, m_error_value,
14646 m_error_traceback>: Remove.
14647 <m_error>: New member.
14648 (gdbpy_exception_to_string): Don't declare.
14649 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14650 * python/py-value.c (convert_value_from_python): Use
14652 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14653 gdbpy_exception_to_string.
14654 (gdbpy_handle_exception): Use gdbpy_err_fetch.
14655 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14658 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14660 * linux-nat.c (delete_lwp_cleanup): Delete.
14661 (struct lwp_deleter): New struct.
14662 (lwp_info_up): New typedef.
14663 (linux_nat_target::follow_fork): Delete cleanup, and make use of
14666 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14668 * linux-fork.c (class scoped_switch_fork_info): New class.
14669 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14671 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14673 * valops.c (find_overload_match): Remove use of null_cleanup, and
14674 calls to do_cleanups.
14676 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14678 * compile/compile-cplus-types.c
14679 (compile_cplus_instance::decl_name): Handle changes to
14681 * cp-support.c (cp_func_name): Update header comment, update
14683 * cp-support.h (cp_func_name): Update return type in declaration.
14684 * valops.c (find_overload_match): Move temp_func local to top
14685 level of function and change its type. Use temp_func to hold and
14686 delete temporary string obtained from cp_func_name.
14688 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14690 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14691 gdb::char_vector, remove cleanup, and update uses of `msg`.
14693 2019-01-03 Jim Wilson <jimw@sifive.com>
14695 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14697 2019-01-02 Tom Tromey <tom@tromey.com>
14699 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14700 (tdesc_parse_xml): Remove cleanups.
14701 * target-descriptions.h (make_cleanup_free_target_description):
14703 (target_desc_deleter): New struct.
14704 (target_desc_up): New typedef.
14705 * target-descriptions.c (target_desc_deleter::operator()): Rename
14706 from free_target_description.
14707 (make_cleanup_free_target_description): Remove.
14709 2019-01-02 Tom Tromey <tom@tromey.com>
14711 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
14712 constructor, destructor.
14713 (linespec_parser): Remove typedef.
14714 (~linespec_parser): Rename from linespec_parser_delete.
14715 (linespec_lex_to_end, linespec_complete_label)
14716 (linespec_complete): Update.
14717 (decode_line_full): Remove cleanups.
14718 (decode_line_1): Update.
14720 2019-01-02 Tom Tromey <tom@tromey.com>
14722 * python/python-internal.h (inferior_to_inferior_object): Change
14724 * python/py-exitedevent.c (create_exited_event_object): Update.
14725 * python/py-inferior.c (inferior_to_inferior_object): Return
14727 (python_new_inferior, python_inferior_deleted)
14728 (thread_to_thread_object, delete_thread_object)
14729 (build_inferior_list, gdbpy_selected_inferior): Update.
14730 * python/py-infthread.c (create_thread_object): Update. Also fail
14731 if inferior_to_inferior_object fails.
14733 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
14735 * inferior.h (class inferior) <displaced_step_state>: New field.
14736 * infrun.h (struct displaced_step_state): Move here from
14737 infrun.c. Initialize fields, add constructor.
14738 <inf>: Remove field.
14739 <reset>: New method.
14740 * infrun.c (struct displaced_step_inferior_state): Move to
14742 (displaced_step_inferior_states): Remove.
14743 (get_displaced_stepping_state): Adust.
14744 (displaced_step_in_progress_any_inferior): Adjust.
14745 (displaced_step_in_progress_thread): Adjust.
14746 (displaced_step_in_progress): Adjust.
14747 (add_displaced_stepping_state): Remove.
14748 (get_displaced_step_closure_by_addr): Adjust.
14749 (remove_displaced_stepping_state): Remove.
14750 (infrun_inferior_exit): Call displaced_step_state.reset.
14751 (use_displaced_stepping): Don't check for NULL.
14752 (displaced_step_prepare_throw): Call
14753 get_displaced_stepping_state.
14754 (displaced_step_fixup): Don't check for NULL.
14755 (prepare_for_detach): Don't check for NULL.
14757 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14759 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14760 in case of call that did not complete.
14762 2019-01-02 Andrey Utkin <autkin@undo.io>
14764 * symfile.c (find_separate_debug_file): Fix search of debug files for
14767 2019-01-02 Tom Tromey <tom@tromey.com>
14769 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14771 * python/py-frame.c (frapy_older): Remove cast.
14772 (frapy_newer): Likewise.
14773 * python/py-breakpoint.c (local_setattro): Remove cast.
14774 * python/py-arch.c (archpy_name): Remove local variable.
14775 * python/py-type.c (gdbpy_lookup_type): Remove cast.
14777 2019-01-02 Joel Brobecker <brobecker@adacore.com>
14779 * unittests/basic_string_view/element_access/char/empty.cc:
14780 Fix year range in copyright header.
14782 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
14784 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14786 <operator==>: Update with for removed field.
14788 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14789 <isa_features>: ...this.
14790 <abi_features>: New field.
14791 (riscv_isa_flen): Update comment.
14792 (riscv_abi_xlen): New declaration.
14793 (riscv_abi_flen): New declaration.
14794 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14796 (riscv_abi_xlen): New function.
14797 (riscv_isa_flen): Update to get answer from isa_features.
14798 (riscv_abi_flen): New function.
14799 (riscv_has_fp_abi): Update to get answer from abi_features.
14800 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14802 (riscv_call_info) <xlen, flen>: Update comment.
14803 (riscv_call_arg_struct): Remove invalid assertions
14804 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14806 (riscv_gdbarch_init): Gather isa features and abi features
14807 separately, ensure both match on the gdbarch when reusing an old
14808 gdbarch. Relax an error check to allow 32-bit abi float to run on
14809 a target with 64-bit float hardware.
14811 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14813 * source.c (search_command_helper): Stop reverse search
14814 when line 1 has been searched.
14816 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14818 * record-full.c (record_full_base_target::close): Rewrite
14819 record_full_core_buf_list free logic.
14821 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14823 * break-catch-syscall.c (print_one_catch_syscall): xfree
14826 2019-01-01 Joel Brobecker <brobecker@adacore.com>
14828 * top.c (print_gdb_version): Update Copyright year in version
14831 2019-01-01 Joel Brobecker <brobecker@adacore.com>
14833 Update copyright year range in all GDB files.
14835 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
14837 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14839 For older changes see ChangeLog-2018.
14845 version-control: never