gdb/ChangeLog

   1 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
   4         New field.
   5         * ada-lang.c (ada_language_defn): Initialise new field.
   6         * c-lang.c (c_language_defn): Likewise.
   7         (cplus_language_defn): Likewise.
   8         (asm_language_defn): Likewise.
   9         (minimal_language_defn): Likewise.
  10         * d-lang.c (d_language_defn): Likewise.
  11         * f-lang.c (f_language_defn): Likewise.
  12         * go-lang.c (go_language_defn): Likewise.
  13         * language.c (unknown_language_defn): Likewise.
  14         (auto_language_defn): Likewise.
  15         * m2-lang.c (m2_language_defn): Likewise.
  16         * objc-lang.c (objc_language_defn): Likewise.
  17         * opencl-lang.c (opencl_language_defn): Likewise.
  18         * p-lang.c (pascal_language_defn): Likewise.
  19         * rust-lang.c (rust_language_defn): Likewise.
  20
  21 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  22
  23         * ada-lang.c (ada_is_character_type): Change return type to bool.
  24         (ada_is_string_type): Likewise.
  25         * ada-lang.h (ada_is_character_type): Update declaration
  26         (ada_is_string_type): Likewise.
  27
  28 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  29
  30         Support style in 'frame|thread apply'
  31
  32         * gdbcmd.h (execute_command_to_string): New term_out parameter.
  33         * record.c (record_start, record_stop): Update callers of
  34         execute_command_to_string with false.
  35         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
  36         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
  37         methods.
  38         (class string_file): New constructor with term_out parameter.
  39         Override methods term_out and can_emit_style_escape.  New member
  40         term_out.
  41         (class stdio_file): Override can_emit_style_escape.
  42         (class tee_file): Override term_out and can_emit_style_escape.
  43         * utils.h (can_emit_style_escape): Remove.
  44         * utils.c (can_emit_style_escape): Likewise.
  45         Update all callers of can_emit_style_escape (SOMESTREAM) to
  46         SOMESTREAM->can_emit_style_escape.
  47         * source-cache.c (source_cache::get_source_lines): Likewise.
  48         * stack.c (frame_apply_command_count): Call execute_command_to_string
  49         passing the term_out characteristic of the current gdb_stdout.
  50         * thread.c (thr_try_catch_cmd): Likewise.
  51         * top.c (execute_command_to_string): pass term_out parameter
  52         to construct the string_file for the command output.
  53         * ui-file.c (term_cli_styling): New function (most code moved
  54         from utils.c can_emit_style_escape).
  55         (string_file::string_file, string_file::can_emit_style_escape,
  56         stdio_file::can_emit_style_escape, tee_file::term_out,
  57         tee_file::can_emit_style_escape): New functions.
  58
  59 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  60
  61         * NEWS: Mention the new set|show may-call-functions.
  62         * infcall.c (may_call_functions_p): New variable.
  63         (show_may_call_functions_p): New function.
  64         (call_function_by_hand_dummy): Throws an error if not
  65         may-call-functions.
  66         (_initialize_infcall): Call add_setshow_boolean_cmd for
  67         may-call-functions.
  68
  69 2019-04-25  Keith Seitz  <keiths@redhat.com>
  70
  71         PR c++/24367
  72         * cp-support.c (inspect_type): Don't attempt substitutions
  73         of symbol with the same name.
  74
  75 2019-04-25  Tom Tromey  <tromey@adacore.com>
  76
  77         PR gdb/24475:
  78         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
  79         static.
  80
  81 2019-04-25  Tom Tromey  <tromey@adacore.com>
  82
  83         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
  84         rvalue reference.
  85         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
  86         (gdb_xml_parser::parse): Use std::move.
  87         * python/python-internal.h (gdbpy_convert_exception): Take a const
  88         reference.
  89         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
  90         std::move.
  91         * python/py-utils.c (gdbpy_convert_exception): Take a const
  92         reference.
  93         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
  94         Use std::move.
  95         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
  96         Use std::move.
  97         * mi/mi-main.c (mi_print_exception): Take a const reference.
  98         * main.c (handle_command_errors): Take a const reference.
  99         * linespec.c (parse_linespec): Use std::move.
 100         * infcall.c (run_inferior_call): Use std::move.
 101         (call_function_by_hand_dummy): Use std::move.
 102         * exec.c (try_open_exec_file): Use std::move.
 103         * exceptions.h (exception_print, exception_fprintf)
 104         (exception_print_same): Update.
 105         * exceptions.c (print_exception, exception_print)
 106         (exception_fprintf, exception_print_same): Change parameters to
 107         const reference.
 108         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 109         * common/new-op.c: Use std::move.
 110         * common/common-exceptions.h (struct gdb_exception): Add move
 111         constructor.
 112         (struct gdb_exception_error, struct gdb_exception_quit, struct
 113         gdb_quit_bad_alloc): Change constructor to move constructor.
 114         (throw_exception): Change parameter to rvalue reference.
 115         * common/common-exceptions.c (throw_exception): Take rvalue
 116         reference.
 117         * cli/cli-interp.c (safe_execute_command): Use std::move.
 118         * breakpoint.c (insert_bp_location, location_to_sals): Use
 119         std::move.
 120
 121 2019-04-25  Tom Tromey  <tromey@adacore.com>
 122
 123         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 124         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 125         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 126         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 127         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 128         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 129         guile/scm-value.c: Use unpack.
 130         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 131         gdbscm_gdb_exception.
 132         (gdbscm_throw_gdb_exception): Likewise.
 133         (struct gdbscm_gdb_exception): New.
 134         (unpack): New function.
 135         (gdbscm_wrap): Use unpack.
 136
 137 2019-04-25  Tom Tromey  <tromey@adacore.com>
 138
 139         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 140         (gdb_rl_callback_handler): Use std::move.
 141         * common/common-exceptions.h (struct gdb_exception): Add move
 142         assignment operator.
 143         (throw_exception_sjlj): Change "exception" to const reference.
 144         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 145         (throw_exception_sjlj): Change "exception" to const reference.
 146
 147 2019-04-25  Tom Tromey  <tromey@adacore.com>
 148
 149         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 150         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 151         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 152         Update.
 153         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 154         Update.
 155         * mi/mi-interp.c (mi_interp::exec): Update.
 156         * linespec.c (parse_linespec): Update.
 157         * infcall.c (run_inferior_call): Update.
 158         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 159         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 160         (gdbscm_lookup_global_symbol): Update.
 161         * guile/scm-param.c (gdbscm_parameter_value): Update.
 162         * guile/scm-frame.c (gdbscm_frame_read_register)
 163         (gdbscm_frame_read_var): Update.
 164         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 165         * exec.c (try_open_exec_file): Update.
 166         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 167         (gdb_rl_callback_handler): Update.
 168         * common/common-exceptions.h (exception_none): Don't declare.
 169         * common/common-exceptions.c (exception_none): Don't define.
 170         (struct catcher) <exception>: Update.
 171         * cli/cli-interp.c (safe_execute_command): Update.
 172         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 173
 174 2019-04-25  Ali Tamur  <tamur@google.com>
 175
 176         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 177         (read_attribute_value): Likewise.
 178         (dwarf2_read_addr_index): Update comment.
 179         (read_str_index): Add DW_FORM_strx.
 180         (dwarf2_string_attr): Likewise.
 181         (dwarf2_const_value_attr): Likewise.
 182         (dump_die_shallow): Likewise.
 183         (dwarf2_fetch_constant_bytes): Likewise.
 184         (skip_form_bytes): Likewise.
 185         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 186
 187 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 188
 189         PR corefiles/11608
 190         PR corefiles/18187
 191         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 192         OFFSET.  Verify if current mapping contains an ELF header.
 193         (linux_find_memory_regions_full): Adjust call to
 194         dump_mapping_p.
 195
 196 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 197             Kang Li <kanglictf@gmail.com>
 198
 199         PR gdb/21600
 200
 201         * dwarf2-frame.c (read_initial_length): Be consistent about using
 202         unsigned representation of length.
 203         (decode_frame_entry_1): Likewise.  Check for wraparound of
 204         end pointer as well as buffer overflow.
 205
 206 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 207
 208         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 209         "vq".
 210
 211 2019-04-24  Tom Tromey  <tromey@adacore.com>
 212
 213         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 214
 215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 216
 217         * s12z-tdep.c (s12z_unwind_pc): Delete.
 218         (s12z_unwind_sp): Delete.
 219         (s12z_gdbarch_init): Don't register deleted functions with
 220         gdbarch.
 221
 222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 223
 224         * rl78-tdep.c (rl78_unwind_sp): Delete.
 225         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 226
 227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 228
 229         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 230         (xstormy16_unwind_pc): Delete.
 231         (xstormy16_dummy_id): Delete.
 232         (xstormy16_gdbarch_init): Don't register deleted functions with
 233         gdbarch.
 234
 235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 236
 237         * vax-tdep.c (vax_unwind_pc): Delete.
 238         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 239
 240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 241
 242         * v850-tdep.c (v850_unwind_sp): Delete.
 243         (v850_unwind_pc): Delete.
 244         (v850_dummy_id): Delete.
 245         (v850_gdbarch_init): Don't register deleted functions with
 246         gdbarch.
 247
 248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 249
 250         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 251         (tilegx_unwind_pc): Delete.
 252         (tilegx_unwind_dummy_id): Delete.
 253         (tilegx_gdbarch_init): Don't register deleted functions with
 254         gdbarch.
 255
 256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 257
 258         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 259         (tic6x_dummy_id): Delete.
 260         (tic6x_gdbarch_init): Don't register deleted functions with
 261         gdbarch.
 262
 263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 264
 265         * sparc-tdep.c (sparc_unwind_pc): Delete.
 266         (sparc32_gdbarch_init): Don't register deleted function with
 267         gdbarch.
 268
 269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 270
 271         * sh-tdep.c (sh_unwind_sp): Delete.
 272         (sh_unwind_pc): Delete.
 273         (sh_dummy_id): Delete.
 274         (sh_gdbarch_init): Don't register deleted functions with
 275         gdbarch.
 276
 277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 278
 279         * score-tdep.c (score_unwind_sp): Delete.
 280         (score_unwind_pc): Delete.
 281         (score_dummy_id): Delete.
 282         (score_gdbarch_init): Don't register deleted functions with
 283         gdbarch.
 284
 285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * rx-tdep.c (rx_unwind_pc): Delete.
 288         (rx_unwind_sp): Delete.
 289         (rx_dummy_id): Delete.
 290         (rx_gdbarch_init): Don't register deleted functions with
 291         gdbarch.  Update comment.
 292
 293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 294
 295         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 296         (rs6000_dummy_id): Delete.
 297         (rs6000_gdbarch_init): Don't register deleted functions with
 298         gdbarch.
 299
 300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 301
 302         * or1k-tdep.c (or1k_dummy_id): Delete.
 303         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 304
 305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 306
 307         * nios2-tdep.c (nios2_dummy_id): Delete.
 308         (nios2_unwind_sp): Delete.
 309         (nios2_gdbarch_init): Don't register deleted functions with
 310         gdbarch.
 311
 312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 313
 314         * nds32-tdep.c (nds32_dummy_id): Delete.
 315         (nds32_unwind_pc): Delete.
 316         (nds32_unwind_sp): Delete.
 317         (nds32_gdbarch_init): Don't register deleted functions with
 318         gdbarch.
 319
 320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 321
 322         * msp430-tdep.c (msp430_unwind_pc): Delete.
 323         (msp430_unwind_sp): Delete.
 324         (msp430_dummy_id): Delete.
 325         (msp430_gdbarch_init): Don't register deleted functions with
 326         gdbarch.
 327
 328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 329
 330         * moxie-tdep.c (moxie_unwind_sp): Delete.
 331         (moxie_unwind_pc): Delete.
 332         (moxie_dummy_id): Delete.
 333         (moxie_gdbarch_init): Don't register deleted functions with
 334         gdbarch.
 335
 336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 337
 338         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 339         (mn10300_unwind_pc): Delete.
 340         (mn10300_unwind_sp): Delete.
 341         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 342         mn10300_unwind_sp.
 343         (mn10300_frame_unwind_init): Don't register deleted functions with
 344         gdbarch.
 345
 346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 347
 348         * mep-tdep.c (mep_unwind_pc): Delete.
 349         (mep_unwind_sp): Delete.
 350         (mep_dummy_id): Delete.
 351         (mep_gdbarch_init): Don't register deleted functions with
 352         gdbarch.
 353
 354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 355
 356         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 357         (m68hc11_unwind_sp): Delete.
 358         (m68hc11_gdbarch_init): Don't register deleted functions with
 359         gdbarch.
 360
 361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * m32r-tdep.c (m32r_unwind_sp): Delete.
 364         (m32r_unwind_pc): Delete.
 365         (m32r_dummy_id): Delete.
 366         (m32r_gdbarch_init): Don't register deleted functions with
 367         gdbarch.
 368
 369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 370
 371         * m32c-tdep.c (m32c_unwind_pc): Delete.
 372         (m32c_unwind_sp): Delete.
 373         (m32c_dummy_id): Delete.
 374         (m32c_gdbarch_init): Don't register deleted functions with
 375         gdbarch.
 376
 377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 378
 379         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 380         (lm32_unwind_pc): Delete.
 381         (lm32_dummy_id): Delete.
 382         (lm32_gdbarch_init): Don't register deleted functions with
 383         gdbarch.
 384
 385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 386
 387         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 388         (iq2000_unwind_pc): Delete.
 389         (iq2000_dummy_id): Delete.
 390         (iq2000_gdbarch_init): Don't register deleted functions with
 391         gdbarch.
 392
 393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 394
 395         * nds32-tdep.c (nds32_type_align): Delete.
 396         (nds32_push_dummy_call): Use type_align instead.
 397
 398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * arm-tdep.c (arm_type_align): Only handle vector override case.
 401         (arm_push_dummy_call): Use type_align.
 402         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 403
 404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 407         case.
 408         (pass_on_stack): Use type_align.
 409         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 410         function.
 411
 412 2019-04-23  Tom Tromey  <tromey@adacore.com>
 413
 414         * dwarf2read.c (line_header::file_name_at): Remove unused
 415         overload.
 416
 417 2019-04-23  Tom de Vries  <tdevries@suse.de>
 418
 419         PR gdb/24438
 420         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 421         invocation.
 422
 423
 424 2019-03-27  Ali Tamur  <tamur@google.com>
 425
 426         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 427         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 428         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 429         (dwarf_expr_context::get_addr_index): Likewise
 430         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 431         (symbol_needs_eval_context::get_addr_index): Likewise
 432         (disassemble_dwarf_expression): Add DW_OP_addrx
 433         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 434         (read_cutu_die_from_dwo): Update comment
 435         (skip_one_die): Add DW_FORM_addrx
 436         (read_attribute_value): Likewise
 437         (var_decode_location): Add DW_OP_addrx
 438         (dwarf2_const_value_attr): Add DW_FORM_addrx
 439         (dump_die_shallow): Likewise
 440         (dwarf2_fetch_constant_bytes): Likewise
 441         (decode_locdesc): Add DW_OP_addrx
 442         (skip_form_bytes): Add DW_FORM_addrx
 443
 444 2019-04-22  Ali Tamur  <tamur@google.com>
 445
 446         * MAINTAINERS (Write After Approval): Add self.
 447
 448 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 449
 450         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 451         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 452         (open_symbol_file_object): Likewise.
 453         (svr4_default_sos): Add info parameter.
 454         (svr4_read_so_list): Likewise.
 455         (svr4_current_sos_direct): Adjust functions calls to pass down
 456         info.
 457         (svr4_current_sos_1): Add info parameter.
 458         (svr4_current_sos): Call get_svr4_info, pass info down to
 459         svr4_current_sos_1.
 460         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 461         get_svr4_info.
 462         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 463         get_svr4_info.
 464         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 465         to get_svr4_info.
 466         (probes_table_remove_objfile_probes): Likewise.
 467         (register_solib_event_probe): Add info parameter.
 468         (solist_update_incremental): Pass info parameter down to
 469         svr4_read_so_list.
 470         (disable_probes_interface): Add info parameter.
 471         (svr4_handle_solib_event): Pass current_program_space to
 472         get_svr4_info.  Adjust disable_probes_interface cleanup.
 473         (svr4_create_probe_breakpoints): Add info parameter, pass it
 474         down to register_solib_event_probe.
 475         (svr4_create_solib_event_breakpoints): Add info parameter,
 476         pass it down to svr4_create_probe_breakpoints.
 477         (enable_break): Pass info down to
 478         svr4_create_solib_event_breakpoints.
 479         (svr4_solib_create_inferior_hook): Pass current_program_space to
 480         get_svr4_info.
 481         (svr4_clear_solib): Likewise.
 482
 483 2019-04-22  Pedro Alves  <palves@redhat.com>
 484
 485         * solib-svr4.c (svr4_free_objfile_observer): New.
 486         (probe_and_action::objfile): New field.
 487         (probes_table_htab_remove_objfile_probes)
 488         (probes_table_remove_objfile_probes): New functions.
 489         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 490         in the new probe_and_action.  Don't store the probe in 'lookup'.
 491         (svr4_create_probe_breakpoints): Pass objfile to
 492         register_solib_event_probe.
 493         (_initialize_svr4_solib): Register a free_objfile observer.
 494
 495 2019-04-19  Tom Tromey  <tom@tromey.com>
 496
 497         * common/queue.h: Remove.
 498
 499 2019-04-19  Tom Tromey  <tom@tromey.com>
 500
 501         * event-loop.c: Don't include "common/queue.h".
 502
 503 2019-04-19  Tom Tromey  <tom@tromey.com>
 504
 505         * remote.c (remote_target): Use delete.
 506         * remote-notif.h: Include <list>, not "common/queue.h".
 507         (notif_client_p): Remove typedef.
 508         (remote_notif_state): Add constructor, destructor, initializer.
 509         <notif_queue>: Now a std::list.
 510         (remote_notif_state_xfree): Don't declare.
 511         * remote-notif.c (remote_notif_process, handle_notification)
 512         (remote_notif_state_allocate): Update.
 513         (~remote_notif_state): Rename from remote_notif_state_xfree.
 514
 515 2019-04-19  Tom Tromey  <tom@tromey.com>
 516
 517         * symfile.c (reread_symbols): Update.
 518         * objfiles.c (objfile_register_static_link)
 519         (objfile_lookup_static_link): Update
 520         (~objfile) Don't delete static_links.
 521         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 522
 523 2019-04-19  Tom Tromey  <tom@tromey.com>
 524
 525         * type-stack.h (struct type_stack) <insert>: Constify string.
 526         * type-stack.c (type_stack::insert): Constify string.
 527         * gdbtypes.h (lookup_template_type): Update.
 528         (address_space_name_to_int): Update.
 529         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 530         const.
 531         (lookup_template_type): Make name const.
 532         * c-exp.y: Update rules.
 533         (lex_one_token, classify_name, classify_inner_name)
 534         (c_print_token): Update.
 535         * p-exp.y: Update rules.
 536         (yylex): Update.
 537         * f-exp.y: Update rules.
 538         (yylex): Update.
 539         * d-exp.y: Update rules.
 540         (lex_one_token, classify_name, classify_inner_name): Update.
 541         * parse.c (write_dollar_variable, copy_name): Return std::string.
 542         * parser-defs.h (copy_name): Change return type.
 543         * m2-exp.y: Update rules.
 544         (yylex): Update.
 545         * go-exp.y (lex_one_token): Update.
 546         Update rules.
 547         (classify_unsafe_function, classify_packaged_name)
 548         (classify_name, yylex): Update.
 549
 550 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 551
 552         * configure.ac: add --enable-source-highlight switch.
 553         * configure: Regenerate.
 554         * top.c (print_gdb_version): plumb --enable-source-highlight
 555         status to "show configuration".
 556
 557 2019-04-19  Tom Tromey  <tromey@adacore.com>
 558
 559         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 560         Check ADA_TYPE_P.
 561         (empty_record, ada_template_to_fixed_record_type_1)
 562         (template_to_static_fixed_type)
 563         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 564         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 565         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 566         macros.
 567
 568 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 569
 570         PR symtab/24423:
 571         * source.c (print_source_lines_base): Advance "iter" when a
 572         control character is seen.
 573
 574 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 575
 576         * inferior.h (struct infcall_suspend_state_deleter):
 577         Catch exception in destructor to avoid crash.
 578
 579 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 580
 581         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 582         close to the add_com "shell".
 583
 584 2019-04-18  Tom Tromey  <tromey@adacore.com>
 585
 586         * process-stratum-target.h (class process_stratum_target)
 587         <stratum>: Add "final".
 588
 589 2019-04-17  Tom Tromey  <tromey@adacore.com>
 590
 591         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 592         against nullptr before use.
 593
 594 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 595
 596         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 597
 598 2019-04-17  Jim Wilson  <jimw@sifive.com>
 599             Andrew Burgess  <andrew.burgess@embecosm.com>
 600
 601         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 602         code read might fail, assume 4-byte breakpoint in that case.
 603
 604 2019-04-15  Leszek Swirski  <leszeks@google.com>
 605
 606         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 607         rather than a hand-rolled POD check when checking for forced MEMORY
 608         classification.
 609
 610 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 611
 612         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 613         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 614         function.
 615         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 616         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 617         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 618         declaration.
 619
 620 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 621
 622         * aarch64-linux-nat.c
 623         (aarch64_linux_nat_target::thread_architecture): Add override.
 624         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 625         each VQ.
 626
 627 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 628
 629         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 630
 631 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 632
 633         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 634         target types of size 96-bits, add some additional comments, and
 635         check that the builtin type we found was the correct size.
 636
 637 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 638
 639         * utils.c (prompt_for_continue): Don't restore the styling at the
 640         end, as applied_style has the wrong value.  This fixes styling in
 641         long lists of file names that are interrupted by the "Continue?"
 642         prompt.
 643
 644 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 645
 646         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 647         * c-lang.c (c_language_defn): Likewise.
 648         (cplus_language_defn): Likewise.
 649         (asm_language_defn): Likewise.
 650         (minimal_language_defn): Likewise.
 651         * d-lang.c (d_language_defn): Likewise.
 652         * f-lang.c (f_language_defn): Likewise.
 653         * go-lang.c (go_language_defn): Likewise.
 654         * language.c (unknown_language_defn): Likewise.
 655         (auto_language_defn): Likewise.
 656         * language.h (struct language_defn): Remove la_magic field.
 657         (LANG_MAGIC): Delete.
 658         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 659         * objc-lang.c (objc_language_defn): Likewise.
 660         * opencl-lang.c (opencl_language_defn): Likewise.
 661         * p-lang.c (pascal_language_defn): Likewise.
 662         * rust-lang.c (rust_language_defn): Likewise.
 663
 664 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 665
 666         * riscv-tdep.c (riscv_type_align): New function.
 667         (riscv_type_alignment): Delete.
 668         (riscv_arg_location): Use 'type_align'.
 669         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 670
 671 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 672
 673         * gdbtypes.c (type_align): A struct with no non-static fields also
 674         has alignment of 1.
 675
 676 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 677
 678         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 679         component to 0.
 680         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 681         member.
 682         (riscv_struct_info::analyse): New implementation using new
 683         analyse_inner member function.
 684         (riscv_struct_info::field_offset): New member function.
 685         (riscv_struct_info::m_offsets): New member variable.
 686         (riscv_struct_info::analyse_inner): New private member function,
 687         takes the old implementation of riscv_struct_info::analyse but
 688         extended to track field offsets.
 689         (riscv_call_arg_struct): Update the struct folding special cases
 690         to handle cases where empty C++ structs, which are non-zero
 691         length, are found.
 692         (riscv_arg_location): Initialise the length of each location, a
 693         non-zero length now indicates the location is in use.
 694         (riscv_push_dummy_call): Allow for the first location having a
 695         non-zero offset when setting up arguments.
 696         (riscv_return_value): Likewise, but for return values.
 697
 698 2019-04-11  Tom Tromey  <tromey@adacore.com>
 699
 700         * utils.c (internal_vproblem): Make "msg" const.
 701
 702 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 703
 704         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 705         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 706         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 707         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 708
 709 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 710
 711         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 712         function.
 713         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 714         of amd64_collect_native_gregset.
 715         (amd64_linux_nat_target::store_registers): Likewise.
 716
 717 2019-04-10  Tom Tromey  <tom@tromey.com>
 718
 719         * symtab.c (lookup_global_symbol_from_objfile)
 720         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 721         * objfiles.h (class separate_debug_iterator): New.
 722         (class separate_debug_range): New.
 723         (struct objfile) <separate_debug_objfiles>: New method.
 724         (objfile_separate_debug_iterate): Don't declare.
 725         * objfiles.c (separate_debug_iterator::operator++): Rename from
 726         objfile_separate_debug_iterate.
 727         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 728         iterator.
 729         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 730         iterator.
 731
 732 2019-04-10  Tom Tromey  <tom@tromey.com>
 733
 734         * symfile.c (reread_symbols): Remove old comment.
 735         * objfiles.c (free_all_objfiles): Fix a typo.
 736
 737 2019-04-10  Tom Tromey  <tom@tromey.com>
 738
 739         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 740         * minsyms.c (lookup_minimal_symbol): Use foreach.
 741         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 742         (lookup_minimal_symbol_solib_trampoline): Likewise.
 743         * symfile.c (reread_symbols): Use foreach.
 744
 745 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 746             Tom Tromey  <tromey@adacore.com>
 747
 748         PR rust/24414:
 749         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 750         (rust_lex_int_test): Change "value" to be LONGEST.
 751         (rust_lex_tests): Add test for long integer literal.
 752
 753 2019-04-09  Tom Tromey  <tromey@adacore.com>
 754
 755         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 756         to bool.
 757         (extended_remote_target::attach): Update.
 758         (remote_target::remote_notice_new_inferior): Update.
 759         (remote_target::add_current_inferior_and_thread): Update.
 760         * inferior.c (exit_inferior_1): Use "false".
 761         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 762
 763 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 764
 765         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 766         the "start" command.
 767
 768 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 769
 770         * python/py-inferior.c (infpy_thread_from_thread_handle):
 771         Adjust comments to reflect renaming of thread_from_thread_handle
 772         to thread_from_handle.  Adjust keywords.  Fix type error message.
 773         (inferior_object_methods): Add thread_from_handle.  Retain
 774         thread_from_thread_handle, but mark it as deprecated.
 775
 776 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 777
 778         * gdbthread.h (find_thread_by_handle): Revise declaration.
 779         * thread.c (find_thread_by_handle): Likewise.  Adjust
 780         implementation too.
 781         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 782         support for buffer objects as handles.
 783
 784 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 785
 786         * python/py-infthread.c (thpy_thread_handle): New function.
 787         (thread_object_methods): Register thpy_thread_handle.
 788
 789 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 790
 791         * gdbthread.h (thread_to_thread_handle): Declare.
 792         * thread.c (gdbtypes.h): Include.
 793         (thread_to_thread_handle): New function.
 794
 795         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 796         (target_thread_info_to_thread_handle): Declare.
 797         * target.c (target_thread_info_to_thread_handle): New function.
 798         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 799         * target-delegates.c: Regenerate.
 800
 801         * linux-thread-db.c (class thread_db_target): Add method
 802         thread_info_to_thread_handle.
 803         (thread_db_target::thread_info_to_thread_handle): Define.
 804         * remote.c (class remote_target): Add new method
 805         thread_info_to_thread_handle.
 806         (remote_target::thread_info_to_thread_handle): Define.
 807
 808 2019-04-08  Pedro Alves  <palves@redhat.com>
 809
 810         * common/common-exceptions.c (throw_exception): Don't create
 811         named object to throw; throw directly.
 812         (throw_it): Likewise.  Don't initialize gdb_exception::message
 813         here, with new; pass FMT and AP to the ctor instead.
 814         * common/common-exceptions.h: Include <string>.
 815         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 816         const char *, va_list)): New ctor.  Use std::make_shared.
 817         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 818         errors)): Delete.
 819         (gdb_exception_error::gdb_exception_error(enum errors, const char
 820         *, va_list)): New.
 821         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 822         Add assertion.
 823         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 824         errors)): Delete.
 825         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 826         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 827         Add assertion.
 828
 829 2019-04-08  Tom Tromey  <tom@tromey.com>
 830
 831         * valops.c (value_rtti_indirect_type): Replace throw_exception
 832         with throw.
 833         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 834         with throw.
 835         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 836         throw.
 837         * target.c (target_translate_tls_address): Replace throw_exception
 838         with throw.
 839         * stack.c (frame_apply_command_count): Replace throw_exception
 840         with throw.
 841         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 842         throw.
 843         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 844         with throw.
 845         * rs6000-tdep.c (rs6000_frame_cache)
 846         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 847         * remote.c: Replace throw_exception with throw.
 848         * record-full.c (record_full_message, record_full_wait_1)
 849         (record_full_restore): Replace throw_exception with throw.
 850         * record-btrace.c:
 851         (get_thread_current_frame_id, record_btrace_start_replaying)
 852         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 853         (cmd_record_btrace_start): Replace throw_exception with throw.
 854         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 855         throw.
 856         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 857         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 858         * linespec.c:
 859         (find_linespec_symbols): Replace throw_exception with throw.
 860         * infrun.c (displaced_step_prepare, resume): Replace
 861         throw_exception with throw.
 862         * infcmd.c (post_create_inferior): Replace throw_exception with
 863         throw.
 864         * inf-loop.c (inferior_event_handler): Replace throw_exception
 865         with throw.
 866         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 867         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 868         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 869         (get_prev_frame_always, get_frame_pc_if_available)
 870         (get_frame_address_in_block_if_available, get_frame_language):
 871         Replace throw_exception with throw.
 872         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 873         throw_exception with throw.
 874         * eval.c (fetch_subexp_value, evaluate_var_value)
 875         (evaluate_funcall, evaluate_subexp_standard): Replace
 876         throw_exception with throw.
 877         * dwarf2loc.c (call_site_find_chain)
 878         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 879         Replace throw_exception with throw.
 880         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 881         with throw.
 882         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 883         throw.
 884         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 885         * completer.c (complete_line_internal): Replace throw_exception
 886         with throw.
 887         * compile/compile-object-run.c (compile_object_run): Replace
 888         throw_exception with throw.
 889         * cli/cli-script.c (process_next_line): Replace throw_exception
 890         with throw.
 891         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 892         (btrace_enable, btrace_maint_update_pt_packets): Replace
 893         throw_exception with throw.
 894         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 895         throw_exception with throw.
 896         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 897         throw_exception with throw.
 898         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 899         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 900         * aarch64-tdep.c (aarch64_make_prologue_cache)
 901         (aarch64_make_stub_cache): Replace throw_exception with throw.
 902
 903 2019-04-08  Tom Tromey  <tom@tromey.com>
 904
 905         * common/common-exceptions.c (throw_exception): Rename from
 906         throw_exception_cxx.  Remove old copy.  Make argument const.
 907         (throw_it): Create and throw exception objects directly.
 908         * common/common-exceptions.h (throw_exception): Make argument
 909         const.
 910         (struct gdb_exception_error): Add constructor.
 911         (struct gdb_exception_quit): Add constructor.
 912
 913 2019-04-08  Tom Tromey  <tom@tromey.com>
 914
 915         * common/common-exceptions.h (exception_rethrow): Don't declare.
 916         (TRY_SJLJ): Update comment.
 917         (TRY, CATCH, END_CATCH): Remove.
 918         * common/common-exceptions.c (exception_rethrow): Remove.
 919
 920 2019-04-08  Tom Tromey  <tom@tromey.com>
 921
 922         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 923         Remove.
 924         (gdb_exception_error): Rename from
 925         gdb_exception_RETURN_MASK_ERROR.
 926         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 927         (gdb_quit_bad_alloc): Update.
 928         * aarch64-tdep.c: Update.
 929         * ada-lang.c: Update.
 930         * ada-typeprint.c: Update.
 931         * ada-valprint.c: Update.
 932         * amd64-tdep.c: Update.
 933         * arch-utils.c: Update.
 934         * break-catch-throw.c: Update.
 935         * breakpoint.c: Update.
 936         * btrace.c: Update.
 937         * c-varobj.c: Update.
 938         * cli/cli-cmds.c: Update.
 939         * cli/cli-interp.c: Update.
 940         * cli/cli-script.c: Update.
 941         * common/common-exceptions.c: Update.
 942         * common/new-op.c: Update.
 943         * common/selftest.c: Update.
 944         * compile/compile-c-symbols.c: Update.
 945         * compile/compile-cplus-symbols.c: Update.
 946         * compile/compile-object-load.c: Update.
 947         * compile/compile-object-run.c: Update.
 948         * completer.c: Update.
 949         * corelow.c: Update.
 950         * cp-abi.c: Update.
 951         * cp-support.c: Update.
 952         * cp-valprint.c: Update.
 953         * darwin-nat.c: Update.
 954         * disasm-selftests.c: Update.
 955         * dtrace-probe.c: Update.
 956         * dwarf-index-cache.c: Update.
 957         * dwarf-index-write.c: Update.
 958         * dwarf2-frame-tailcall.c: Update.
 959         * dwarf2-frame.c: Update.
 960         * dwarf2loc.c: Update.
 961         * dwarf2read.c: Update.
 962         * eval.c: Update.
 963         * event-loop.c: Update.
 964         * event-top.c: Update.
 965         * exec.c: Update.
 966         * f-valprint.c: Update.
 967         * fbsd-tdep.c: Update.
 968         * frame-unwind.c: Update.
 969         * frame.c: Update.
 970         * gdbtypes.c: Update.
 971         * gnu-v3-abi.c: Update.
 972         * guile/guile-internal.h: Update.
 973         * guile/scm-block.c: Update.
 974         * guile/scm-breakpoint.c: Update.
 975         * guile/scm-cmd.c: Update.
 976         * guile/scm-disasm.c: Update.
 977         * guile/scm-frame.c: Update.
 978         * guile/scm-lazy-string.c: Update.
 979         * guile/scm-math.c: Update.
 980         * guile/scm-param.c: Update.
 981         * guile/scm-ports.c: Update.
 982         * guile/scm-pretty-print.c: Update.
 983         * guile/scm-symbol.c: Update.
 984         * guile/scm-symtab.c: Update.
 985         * guile/scm-type.c: Update.
 986         * guile/scm-value.c: Update.
 987         * i386-linux-tdep.c: Update.
 988         * i386-tdep.c: Update.
 989         * inf-loop.c: Update.
 990         * infcall.c: Update.
 991         * infcmd.c: Update.
 992         * infrun.c: Update.
 993         * jit.c: Update.
 994         * language.c: Update.
 995         * linespec.c: Update.
 996         * linux-fork.c: Update.
 997         * linux-nat.c: Update.
 998         * linux-tdep.c: Update.
 999         * linux-thread-db.c: Update.
1000         * main.c: Update.
1001         * mi/mi-cmd-break.c: Update.
1002         * mi/mi-cmd-stack.c: Update.
1003         * mi/mi-interp.c: Update.
1004         * mi/mi-main.c: Update.
1005         * objc-lang.c: Update.
1006         * p-valprint.c: Update.
1007         * parse.c: Update.
1008         * ppc-linux-tdep.c: Update.
1009         * printcmd.c: Update.
1010         * python/py-arch.c: Update.
1011         * python/py-breakpoint.c: Update.
1012         * python/py-cmd.c: Update.
1013         * python/py-finishbreakpoint.c: Update.
1014         * python/py-frame.c: Update.
1015         * python/py-framefilter.c: Update.
1016         * python/py-gdb-readline.c: Update.
1017         * python/py-inferior.c: Update.
1018         * python/py-infthread.c: Update.
1019         * python/py-lazy-string.c: Update.
1020         * python/py-linetable.c: Update.
1021         * python/py-objfile.c: Update.
1022         * python/py-param.c: Update.
1023         * python/py-prettyprint.c: Update.
1024         * python/py-progspace.c: Update.
1025         * python/py-record-btrace.c: Update.
1026         * python/py-record.c: Update.
1027         * python/py-symbol.c: Update.
1028         * python/py-type.c: Update.
1029         * python/py-unwind.c: Update.
1030         * python/py-utils.c: Update.
1031         * python/py-value.c: Update.
1032         * python/python.c: Update.
1033         * record-btrace.c: Update.
1034         * record-full.c: Update.
1035         * remote-fileio.c: Update.
1036         * remote.c: Update.
1037         * riscv-tdep.c: Update.
1038         * rs6000-aix-tdep.c: Update.
1039         * rs6000-tdep.c: Update.
1040         * rust-exp.y: Update.
1041         * rust-lang.c: Update.
1042         * s390-tdep.c: Update.
1043         * selftest-arch.c: Update.
1044         * solib-dsbt.c: Update.
1045         * solib-frv.c: Update.
1046         * solib-spu.c: Update.
1047         * solib-svr4.c: Update.
1048         * solib.c: Update.
1049         * sparc64-linux-tdep.c: Update.
1050         * stack.c: Update.
1051         * symfile-mem.c: Update.
1052         * symmisc.c: Update.
1053         * target.c: Update.
1054         * thread.c: Update.
1055         * top.c: Update.
1056         * tracefile-tfile.c: Update.
1057         * tui/tui.c: Update.
1058         * typeprint.c: Update.
1059         * unittests/cli-utils-selftests.c: Update.
1060         * unittests/parse-connection-spec-selftests.c: Update.
1061         * valops.c: Update.
1062         * valprint.c: Update.
1063         * value.c: Update.
1064         * varobj.c: Update.
1065         * windows-nat.c: Update.
1066         * x86-linux-nat.c: Update.
1067         * xml-support.c: Update.
1068
1069 2019-04-08  Tom Tromey  <tom@tromey.com>
1070
1071         * xml-support.c: Use C++ exception handling.
1072         * x86-linux-nat.c: Use C++ exception handling.
1073         * windows-nat.c: Use C++ exception handling.
1074         * varobj.c: Use C++ exception handling.
1075         * value.c: Use C++ exception handling.
1076         * valprint.c: Use C++ exception handling.
1077         * valops.c: Use C++ exception handling.
1078         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1079         handling.
1080         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1081         * typeprint.c: Use C++ exception handling.
1082         * tui/tui.c: Use C++ exception handling.
1083         * tracefile-tfile.c: Use C++ exception handling.
1084         * top.c: Use C++ exception handling.
1085         * thread.c: Use C++ exception handling.
1086         * target.c: Use C++ exception handling.
1087         * symmisc.c: Use C++ exception handling.
1088         * symfile-mem.c: Use C++ exception handling.
1089         * stack.c: Use C++ exception handling.
1090         * sparc64-linux-tdep.c: Use C++ exception handling.
1091         * solib.c: Use C++ exception handling.
1092         * solib-svr4.c: Use C++ exception handling.
1093         * solib-spu.c: Use C++ exception handling.
1094         * solib-frv.c: Use C++ exception handling.
1095         * solib-dsbt.c: Use C++ exception handling.
1096         * selftest-arch.c: Use C++ exception handling.
1097         * s390-tdep.c: Use C++ exception handling.
1098         * rust-lang.c: Use C++ exception handling.
1099         * rust-exp.y: Use C++ exception handling.
1100         * rs6000-tdep.c: Use C++ exception handling.
1101         * rs6000-aix-tdep.c: Use C++ exception handling.
1102         * riscv-tdep.c: Use C++ exception handling.
1103         * remote.c: Use C++ exception handling.
1104         * remote-fileio.c: Use C++ exception handling.
1105         * record-full.c: Use C++ exception handling.
1106         * record-btrace.c: Use C++ exception handling.
1107         * python/python.c: Use C++ exception handling.
1108         * python/py-value.c: Use C++ exception handling.
1109         * python/py-utils.c: Use C++ exception handling.
1110         * python/py-unwind.c: Use C++ exception handling.
1111         * python/py-type.c: Use C++ exception handling.
1112         * python/py-symbol.c: Use C++ exception handling.
1113         * python/py-record.c: Use C++ exception handling.
1114         * python/py-record-btrace.c: Use C++ exception handling.
1115         * python/py-progspace.c: Use C++ exception handling.
1116         * python/py-prettyprint.c: Use C++ exception handling.
1117         * python/py-param.c: Use C++ exception handling.
1118         * python/py-objfile.c: Use C++ exception handling.
1119         * python/py-linetable.c: Use C++ exception handling.
1120         * python/py-lazy-string.c: Use C++ exception handling.
1121         * python/py-infthread.c: Use C++ exception handling.
1122         * python/py-inferior.c: Use C++ exception handling.
1123         * python/py-gdb-readline.c: Use C++ exception handling.
1124         * python/py-framefilter.c: Use C++ exception handling.
1125         * python/py-frame.c: Use C++ exception handling.
1126         * python/py-finishbreakpoint.c: Use C++ exception handling.
1127         * python/py-cmd.c: Use C++ exception handling.
1128         * python/py-breakpoint.c: Use C++ exception handling.
1129         * python/py-arch.c: Use C++ exception handling.
1130         * printcmd.c: Use C++ exception handling.
1131         * ppc-linux-tdep.c: Use C++ exception handling.
1132         * parse.c: Use C++ exception handling.
1133         * p-valprint.c: Use C++ exception handling.
1134         * objc-lang.c: Use C++ exception handling.
1135         * mi/mi-main.c: Use C++ exception handling.
1136         * mi/mi-interp.c: Use C++ exception handling.
1137         * mi/mi-cmd-stack.c: Use C++ exception handling.
1138         * mi/mi-cmd-break.c: Use C++ exception handling.
1139         * main.c: Use C++ exception handling.
1140         * linux-thread-db.c: Use C++ exception handling.
1141         * linux-tdep.c: Use C++ exception handling.
1142         * linux-nat.c: Use C++ exception handling.
1143         * linux-fork.c: Use C++ exception handling.
1144         * linespec.c: Use C++ exception handling.
1145         * language.c: Use C++ exception handling.
1146         * jit.c: Use C++ exception handling.
1147         * infrun.c: Use C++ exception handling.
1148         * infcmd.c: Use C++ exception handling.
1149         * infcall.c: Use C++ exception handling.
1150         * inf-loop.c: Use C++ exception handling.
1151         * i386-tdep.c: Use C++ exception handling.
1152         * i386-linux-tdep.c: Use C++ exception handling.
1153         * guile/scm-value.c: Use C++ exception handling.
1154         * guile/scm-type.c: Use C++ exception handling.
1155         * guile/scm-symtab.c: Use C++ exception handling.
1156         * guile/scm-symbol.c: Use C++ exception handling.
1157         * guile/scm-pretty-print.c: Use C++ exception handling.
1158         * guile/scm-ports.c: Use C++ exception handling.
1159         * guile/scm-param.c: Use C++ exception handling.
1160         * guile/scm-math.c: Use C++ exception handling.
1161         * guile/scm-lazy-string.c: Use C++ exception handling.
1162         * guile/scm-frame.c: Use C++ exception handling.
1163         * guile/scm-disasm.c: Use C++ exception handling.
1164         * guile/scm-cmd.c: Use C++ exception handling.
1165         * guile/scm-breakpoint.c: Use C++ exception handling.
1166         * guile/scm-block.c: Use C++ exception handling.
1167         * guile/guile-internal.h: Use C++ exception handling.
1168         * gnu-v3-abi.c: Use C++ exception handling.
1169         * gdbtypes.c: Use C++ exception handling.
1170         * frame.c: Use C++ exception handling.
1171         * frame-unwind.c: Use C++ exception handling.
1172         * fbsd-tdep.c: Use C++ exception handling.
1173         * f-valprint.c: Use C++ exception handling.
1174         * exec.c: Use C++ exception handling.
1175         * event-top.c: Use C++ exception handling.
1176         * event-loop.c: Use C++ exception handling.
1177         * eval.c: Use C++ exception handling.
1178         * dwarf2read.c: Use C++ exception handling.
1179         * dwarf2loc.c: Use C++ exception handling.
1180         * dwarf2-frame.c: Use C++ exception handling.
1181         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1182         * dwarf-index-write.c: Use C++ exception handling.
1183         * dwarf-index-cache.c: Use C++ exception handling.
1184         * dtrace-probe.c: Use C++ exception handling.
1185         * disasm-selftests.c: Use C++ exception handling.
1186         * darwin-nat.c: Use C++ exception handling.
1187         * cp-valprint.c: Use C++ exception handling.
1188         * cp-support.c: Use C++ exception handling.
1189         * cp-abi.c: Use C++ exception handling.
1190         * corelow.c: Use C++ exception handling.
1191         * completer.c: Use C++ exception handling.
1192         * compile/compile-object-run.c: Use C++ exception handling.
1193         * compile/compile-object-load.c: Use C++ exception handling.
1194         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1195         * compile/compile-c-symbols.c: Use C++ exception handling.
1196         * common/selftest.c: Use C++ exception handling.
1197         * common/new-op.c: Use C++ exception handling.
1198         * cli/cli-script.c: Use C++ exception handling.
1199         * cli/cli-interp.c: Use C++ exception handling.
1200         * cli/cli-cmds.c: Use C++ exception handling.
1201         * c-varobj.c: Use C++ exception handling.
1202         * btrace.c: Use C++ exception handling.
1203         * breakpoint.c: Use C++ exception handling.
1204         * break-catch-throw.c: Use C++ exception handling.
1205         * arch-utils.c: Use C++ exception handling.
1206         * amd64-tdep.c: Use C++ exception handling.
1207         * ada-valprint.c: Use C++ exception handling.
1208         * ada-typeprint.c: Use C++ exception handling.
1209         * ada-lang.c: Use C++ exception handling.
1210         * aarch64-tdep.c: Use C++ exception handling.
1211
1212 2019-04-08  Tom Tromey  <tom@tromey.com>
1213
1214         * xml-support.c (gdb_xml_parser::parse): Update.
1215         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1216         * value.c (show_convenience): Update.
1217         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1218         (test_parse_flags_qcs): Update.
1219         * thread.c (thr_try_catch_cmd): Update.
1220         * target.c (target_translate_tls_address): Update.
1221         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1222         (info_frame_command_core, frame_apply_command_count): Update.
1223         * rust-exp.y (rust_lex_exception_test): Update.
1224         * riscv-tdep.c (riscv_print_one_register_info): Update.
1225         * remote.c (remote_target::enable_btrace): Update.
1226         * record-btrace.c (record_btrace_enable_warn): Update.
1227         * python/py-utils.c (gdbpy_convert_exception): Update.
1228         * printcmd.c (do_one_display, print_variable_and_value): Update.
1229         * mi/mi-main.c (mi_print_exception): Update.
1230         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1231         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1232         * linux-nat.c (linux_nat_target::attach): Update.
1233         * linux-fork.c (class scoped_switch_fork_info): Update.
1234         * infrun.c (displaced_step_prepare): Update.
1235         * infcall.c (call_function_by_hand_dummy): Update.
1236         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1237         * gnu-v3-abi.c (print_one_vtable): Update.
1238         * frame.c (get_prev_frame_always): Update.
1239         * f-valprint.c (info_common_command_for_block): Update.
1240         * exec.c (try_open_exec_file): Update.
1241         * exceptions.c (print_exception, exception_print)
1242         (exception_fprintf, exception_print_same): Update.
1243         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1244         * dwarf-index-cache.c (index_cache::store)
1245         (index_cache::lookup_gdb_index): Update.
1246         * darwin-nat.c (maybe_cache_shell): Update.
1247         * cp-valprint.c (cp_print_value_fields): Update.
1248         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1249         (gcc_cplus_symbol_address): Update.
1250         * compile/compile-c-symbols.c (gcc_convert_symbol)
1251         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1252         * common/selftest.c: Update.
1253         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1254         a std::string.
1255         (exception_try_scope_entry, exception_try_scope_exit): Don't
1256         declare.
1257         (struct exception_try_scope): Remove.
1258         (TRY): Don't use exception_try_scope.
1259         (struct gdb_exception): Add constructor, operator=.
1260         <what>: New method.
1261         (struct gdb_exception_RETURN_MASK_ALL)
1262         (struct gdb_exception_RETURN_MASK_ERROR)
1263         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1264         (struct gdb_quit_bad_alloc): Update.
1265         * common/common-exceptions.c (exception_none): Change
1266         initializer.
1267         (struct catcher) <state, exception>: Initialize inline.
1268         <prev>: Remove member.
1269         (current_catcher): Remove.
1270         (catchers): New global.
1271         (exceptions_state_mc_init): Simplify.
1272         (catcher_pop): Remove.
1273         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1274         (try_scope_depth, exception_try_scope_entry)
1275         (exception_try_scope_exit): Remove.
1276         (throw_exception_sjlj): Update.
1277         (exception_messages, exception_messages_size): Remove.
1278         (throw_it): Simplify.
1279         (gdb_exception_sliced_copy): Remove.
1280         (throw_exception_cxx): Update.
1281         * cli/cli-script.c (script_from_file): Update.
1282         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1283         Update.
1284         * ada-valprint.c (ada_val_print): Update.
1285         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1286         (create_excep_cond_exprs): Update.
1287
1288 2019-04-08  Tom Tromey  <tom@tromey.com>
1289
1290         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1291         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1292         (TRY, CATCH, END_CATCH): Remove some definitions.
1293         * common/common-exceptions.c: Don't use GDB_XCPT.
1294         (catcher_list_size): Remove.
1295         (throw_exception, throw_it): Simplify.
1296
1297 2019-04-05  Tom Tromey  <tom@tromey.com>
1298
1299         Revert the header-sorting patch.
1300         * ft32-tdep.c: Revert.
1301         * frv-tdep.c: Revert.
1302         * frv-linux-tdep.c: Revert.
1303         * frame.c: Revert.
1304         * frame-unwind.c: Revert.
1305         * frame-base.c: Revert.
1306         * fork-child.c: Revert.
1307         * findvar.c: Revert.
1308         * findcmd.c: Revert.
1309         * filesystem.c: Revert.
1310         * filename-seen-cache.h: Revert.
1311         * filename-seen-cache.c: Revert.
1312         * fbsd-tdep.c: Revert.
1313         * fbsd-nat.h: Revert.
1314         * fbsd-nat.c: Revert.
1315         * f-valprint.c: Revert.
1316         * f-typeprint.c: Revert.
1317         * f-lang.c: Revert.
1318         * extension.h: Revert.
1319         * extension.c: Revert.
1320         * extension-priv.h: Revert.
1321         * expprint.c: Revert.
1322         * exec.h: Revert.
1323         * exec.c: Revert.
1324         * exceptions.c: Revert.
1325         * event-top.c: Revert.
1326         * event-loop.c: Revert.
1327         * eval.c: Revert.
1328         * elfread.c: Revert.
1329         * dwarf2read.h: Revert.
1330         * dwarf2read.c: Revert.
1331         * dwarf2loc.c: Revert.
1332         * dwarf2expr.h: Revert.
1333         * dwarf2expr.c: Revert.
1334         * dwarf2-frame.c: Revert.
1335         * dwarf2-frame-tailcall.c: Revert.
1336         * dwarf-index-write.h: Revert.
1337         * dwarf-index-write.c: Revert.
1338         * dwarf-index-common.c: Revert.
1339         * dwarf-index-cache.h: Revert.
1340         * dwarf-index-cache.c: Revert.
1341         * dummy-frame.c: Revert.
1342         * dtrace-probe.c: Revert.
1343         * disasm.h: Revert.
1344         * disasm.c: Revert.
1345         * disasm-selftests.c: Revert.
1346         * dictionary.c: Revert.
1347         * dicos-tdep.c: Revert.
1348         * demangle.c: Revert.
1349         * dcache.h: Revert.
1350         * dcache.c: Revert.
1351         * darwin-nat.h: Revert.
1352         * darwin-nat.c: Revert.
1353         * darwin-nat-info.c: Revert.
1354         * d-valprint.c: Revert.
1355         * d-namespace.c: Revert.
1356         * d-lang.c: Revert.
1357         * ctf.c: Revert.
1358         * csky-tdep.c: Revert.
1359         * csky-linux-tdep.c: Revert.
1360         * cris-tdep.c: Revert.
1361         * cris-linux-tdep.c: Revert.
1362         * cp-valprint.c: Revert.
1363         * cp-support.c: Revert.
1364         * cp-namespace.c: Revert.
1365         * cp-abi.c: Revert.
1366         * corelow.c: Revert.
1367         * corefile.c: Revert.
1368         * continuations.c: Revert.
1369         * completer.h: Revert.
1370         * completer.c: Revert.
1371         * complaints.c: Revert.
1372         * coffread.c: Revert.
1373         * coff-pe-read.c: Revert.
1374         * cli-out.h: Revert.
1375         * cli-out.c: Revert.
1376         * charset.c: Revert.
1377         * c-varobj.c: Revert.
1378         * c-valprint.c: Revert.
1379         * c-typeprint.c: Revert.
1380         * c-lang.c: Revert.
1381         * buildsym.c: Revert.
1382         * buildsym-legacy.c: Revert.
1383         * build-id.h: Revert.
1384         * build-id.c: Revert.
1385         * btrace.c: Revert.
1386         * bsd-uthread.c: Revert.
1387         * breakpoint.h: Revert.
1388         * breakpoint.c: Revert.
1389         * break-catch-throw.c: Revert.
1390         * break-catch-syscall.c: Revert.
1391         * break-catch-sig.c: Revert.
1392         * blockframe.c: Revert.
1393         * block.c: Revert.
1394         * bfin-tdep.c: Revert.
1395         * bfin-linux-tdep.c: Revert.
1396         * bfd-target.c: Revert.
1397         * bcache.c: Revert.
1398         * ax-general.c: Revert.
1399         * ax-gdb.h: Revert.
1400         * ax-gdb.c: Revert.
1401         * avr-tdep.c: Revert.
1402         * auxv.c: Revert.
1403         * auto-load.c: Revert.
1404         * arm-wince-tdep.c: Revert.
1405         * arm-tdep.c: Revert.
1406         * arm-symbian-tdep.c: Revert.
1407         * arm-pikeos-tdep.c: Revert.
1408         * arm-obsd-tdep.c: Revert.
1409         * arm-nbsd-tdep.c: Revert.
1410         * arm-nbsd-nat.c: Revert.
1411         * arm-linux-tdep.c: Revert.
1412         * arm-linux-nat.c: Revert.
1413         * arm-fbsd-tdep.c: Revert.
1414         * arm-fbsd-nat.c: Revert.
1415         * arm-bsd-tdep.c: Revert.
1416         * arch-utils.c: Revert.
1417         * arc-tdep.c: Revert.
1418         * arc-newlib-tdep.c: Revert.
1419         * annotate.h: Revert.
1420         * annotate.c: Revert.
1421         * amd64-windows-tdep.c: Revert.
1422         * amd64-windows-nat.c: Revert.
1423         * amd64-tdep.c: Revert.
1424         * amd64-sol2-tdep.c: Revert.
1425         * amd64-obsd-tdep.c: Revert.
1426         * amd64-obsd-nat.c: Revert.
1427         * amd64-nbsd-tdep.c: Revert.
1428         * amd64-nbsd-nat.c: Revert.
1429         * amd64-nat.c: Revert.
1430         * amd64-linux-tdep.c: Revert.
1431         * amd64-linux-nat.c: Revert.
1432         * amd64-fbsd-tdep.c: Revert.
1433         * amd64-fbsd-nat.c: Revert.
1434         * amd64-dicos-tdep.c: Revert.
1435         * amd64-darwin-tdep.c: Revert.
1436         * amd64-bsd-nat.c: Revert.
1437         * alpha-tdep.c: Revert.
1438         * alpha-obsd-tdep.c: Revert.
1439         * alpha-nbsd-tdep.c: Revert.
1440         * alpha-mdebug-tdep.c: Revert.
1441         * alpha-linux-tdep.c: Revert.
1442         * alpha-linux-nat.c: Revert.
1443         * alpha-bsd-tdep.c: Revert.
1444         * alpha-bsd-nat.c: Revert.
1445         * aix-thread.c: Revert.
1446         * agent.c: Revert.
1447         * addrmap.c: Revert.
1448         * ada-varobj.c: Revert.
1449         * ada-valprint.c: Revert.
1450         * ada-typeprint.c: Revert.
1451         * ada-tasks.c: Revert.
1452         * ada-lang.c: Revert.
1453         * aarch64-tdep.c: Revert.
1454         * aarch64-ravenscar-thread.c: Revert.
1455         * aarch64-newlib-tdep.c: Revert.
1456         * aarch64-linux-tdep.c: Revert.
1457         * aarch64-linux-nat.c: Revert.
1458         * aarch64-fbsd-tdep.c: Revert.
1459         * aarch64-fbsd-nat.c: Revert.
1460         * aarch32-linux-nat.c: Revert.
1461
1462 2019-04-05  Tom Tromey  <tom@tromey.com>
1463
1464         * ft32-tdep.c: Sort headers.
1465         * frv-tdep.c: Sort headers.
1466         * frv-linux-tdep.c: Sort headers.
1467         * frame.c: Sort headers.
1468         * frame-unwind.c: Sort headers.
1469         * frame-base.c: Sort headers.
1470         * fork-child.c: Sort headers.
1471         * findvar.c: Sort headers.
1472         * findcmd.c: Sort headers.
1473         * filesystem.c: Sort headers.
1474         * filename-seen-cache.h: Sort headers.
1475         * filename-seen-cache.c: Sort headers.
1476         * fbsd-tdep.c: Sort headers.
1477         * fbsd-nat.h: Sort headers.
1478         * fbsd-nat.c: Sort headers.
1479         * f-valprint.c: Sort headers.
1480         * f-typeprint.c: Sort headers.
1481         * f-lang.c: Sort headers.
1482         * extension.h: Sort headers.
1483         * extension.c: Sort headers.
1484         * extension-priv.h: Sort headers.
1485         * expprint.c: Sort headers.
1486         * exec.h: Sort headers.
1487         * exec.c: Sort headers.
1488         * exceptions.c: Sort headers.
1489         * event-top.c: Sort headers.
1490         * event-loop.c: Sort headers.
1491         * eval.c: Sort headers.
1492         * elfread.c: Sort headers.
1493         * dwarf2read.h: Sort headers.
1494         * dwarf2read.c: Sort headers.
1495         * dwarf2loc.c: Sort headers.
1496         * dwarf2expr.h: Sort headers.
1497         * dwarf2expr.c: Sort headers.
1498         * dwarf2-frame.c: Sort headers.
1499         * dwarf2-frame-tailcall.c: Sort headers.
1500         * dwarf-index-write.h: Sort headers.
1501         * dwarf-index-write.c: Sort headers.
1502         * dwarf-index-common.c: Sort headers.
1503         * dwarf-index-cache.h: Sort headers.
1504         * dwarf-index-cache.c: Sort headers.
1505         * dummy-frame.c: Sort headers.
1506         * dtrace-probe.c: Sort headers.
1507         * disasm.h: Sort headers.
1508         * disasm.c: Sort headers.
1509         * disasm-selftests.c: Sort headers.
1510         * dictionary.c: Sort headers.
1511         * dicos-tdep.c: Sort headers.
1512         * demangle.c: Sort headers.
1513         * dcache.h: Sort headers.
1514         * dcache.c: Sort headers.
1515         * darwin-nat.h: Sort headers.
1516         * darwin-nat.c: Sort headers.
1517         * darwin-nat-info.c: Sort headers.
1518         * d-valprint.c: Sort headers.
1519         * d-namespace.c: Sort headers.
1520         * d-lang.c: Sort headers.
1521         * ctf.c: Sort headers.
1522         * csky-tdep.c: Sort headers.
1523         * csky-linux-tdep.c: Sort headers.
1524         * cris-tdep.c: Sort headers.
1525         * cris-linux-tdep.c: Sort headers.
1526         * cp-valprint.c: Sort headers.
1527         * cp-support.c: Sort headers.
1528         * cp-namespace.c: Sort headers.
1529         * cp-abi.c: Sort headers.
1530         * corelow.c: Sort headers.
1531         * corefile.c: Sort headers.
1532         * continuations.c: Sort headers.
1533         * completer.h: Sort headers.
1534         * completer.c: Sort headers.
1535         * complaints.c: Sort headers.
1536         * coffread.c: Sort headers.
1537         * coff-pe-read.c: Sort headers.
1538         * cli-out.h: Sort headers.
1539         * cli-out.c: Sort headers.
1540         * charset.c: Sort headers.
1541         * c-varobj.c: Sort headers.
1542         * c-valprint.c: Sort headers.
1543         * c-typeprint.c: Sort headers.
1544         * c-lang.c: Sort headers.
1545         * buildsym.c: Sort headers.
1546         * buildsym-legacy.c: Sort headers.
1547         * build-id.h: Sort headers.
1548         * build-id.c: Sort headers.
1549         * btrace.c: Sort headers.
1550         * bsd-uthread.c: Sort headers.
1551         * breakpoint.h: Sort headers.
1552         * breakpoint.c: Sort headers.
1553         * break-catch-throw.c: Sort headers.
1554         * break-catch-syscall.c: Sort headers.
1555         * break-catch-sig.c: Sort headers.
1556         * blockframe.c: Sort headers.
1557         * block.c: Sort headers.
1558         * bfin-tdep.c: Sort headers.
1559         * bfin-linux-tdep.c: Sort headers.
1560         * bfd-target.c: Sort headers.
1561         * bcache.c: Sort headers.
1562         * ax-general.c: Sort headers.
1563         * ax-gdb.h: Sort headers.
1564         * ax-gdb.c: Sort headers.
1565         * avr-tdep.c: Sort headers.
1566         * auxv.c: Sort headers.
1567         * auto-load.c: Sort headers.
1568         * arm-wince-tdep.c: Sort headers.
1569         * arm-tdep.c: Sort headers.
1570         * arm-symbian-tdep.c: Sort headers.
1571         * arm-pikeos-tdep.c: Sort headers.
1572         * arm-obsd-tdep.c: Sort headers.
1573         * arm-nbsd-tdep.c: Sort headers.
1574         * arm-nbsd-nat.c: Sort headers.
1575         * arm-linux-tdep.c: Sort headers.
1576         * arm-linux-nat.c: Sort headers.
1577         * arm-fbsd-tdep.c: Sort headers.
1578         * arm-fbsd-nat.c: Sort headers.
1579         * arm-bsd-tdep.c: Sort headers.
1580         * arch-utils.c: Sort headers.
1581         * arc-tdep.c: Sort headers.
1582         * arc-newlib-tdep.c: Sort headers.
1583         * annotate.h: Sort headers.
1584         * annotate.c: Sort headers.
1585         * amd64-windows-tdep.c: Sort headers.
1586         * amd64-windows-nat.c: Sort headers.
1587         * amd64-tdep.c: Sort headers.
1588         * amd64-sol2-tdep.c: Sort headers.
1589         * amd64-obsd-tdep.c: Sort headers.
1590         * amd64-obsd-nat.c: Sort headers.
1591         * amd64-nbsd-tdep.c: Sort headers.
1592         * amd64-nbsd-nat.c: Sort headers.
1593         * amd64-nat.c: Sort headers.
1594         * amd64-linux-tdep.c: Sort headers.
1595         * amd64-linux-nat.c: Sort headers.
1596         * amd64-fbsd-tdep.c: Sort headers.
1597         * amd64-fbsd-nat.c: Sort headers.
1598         * amd64-dicos-tdep.c: Sort headers.
1599         * amd64-darwin-tdep.c: Sort headers.
1600         * amd64-bsd-nat.c: Sort headers.
1601         * alpha-tdep.c: Sort headers.
1602         * alpha-obsd-tdep.c: Sort headers.
1603         * alpha-nbsd-tdep.c: Sort headers.
1604         * alpha-mdebug-tdep.c: Sort headers.
1605         * alpha-linux-tdep.c: Sort headers.
1606         * alpha-linux-nat.c: Sort headers.
1607         * alpha-bsd-tdep.c: Sort headers.
1608         * alpha-bsd-nat.c: Sort headers.
1609         * aix-thread.c: Sort headers.
1610         * agent.c: Sort headers.
1611         * addrmap.c: Sort headers.
1612         * ada-varobj.c: Sort headers.
1613         * ada-valprint.c: Sort headers.
1614         * ada-typeprint.c: Sort headers.
1615         * ada-tasks.c: Sort headers.
1616         * ada-lang.c: Sort headers.
1617         * aarch64-tdep.c: Sort headers.
1618         * aarch64-ravenscar-thread.c: Sort headers.
1619         * aarch64-newlib-tdep.c: Sort headers.
1620         * aarch64-linux-tdep.c: Sort headers.
1621         * aarch64-linux-nat.c: Sort headers.
1622         * aarch64-fbsd-tdep.c: Sort headers.
1623         * aarch64-fbsd-nat.c: Sort headers.
1624         * aarch32-linux-nat.c: Sort headers.
1625
1626 2019-04-04  Tom Tromey  <tom@tromey.com>
1627
1628         * varobj.c (varobj_create): Update.
1629         * rust-exp.y (struct rust_parser) <update_innermost_block,
1630         lookup_symbol>: New methods.
1631         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1632         Rename.
1633         (rust_parser::rust_lookup_type)
1634         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1635         * printcmd.c (display_command, do_one_display): Update.
1636         * parser-defs.h (struct parser_state) <parser_state>: Add
1637         "tracker" parameter.
1638         (block_tracker): New member.
1639         (class innermost_block_tracker) <innermost_block_tracker>: Add
1640         "types" parameter.
1641         <reset>: Remove method.
1642         (innermost_block): Don't declare.
1643         (null_post_parser): Update.
1644         * parse.c (innermost_block): Remove global.
1645         (write_dollar_variable): Update.
1646         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1647         Remove "tracker_types" parameter.
1648         (parse_expression): Add "tracker" parameter.
1649         (parse_expression_for_completion): Update.
1650         (null_post_parser): Add "tracker" parameter.
1651         * p-exp.y: Update rules.
1652         * m2-exp.y: Update rules.
1653         * language.h (struct language_defn) <la_post_parser>: Add
1654         "tracker" parameter.
1655         * go-exp.y: Update rules.
1656         * f-exp.y: Update rules.
1657         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1658         parameter.
1659         * d-exp.y: Update rules.
1660         * c-exp.y: Update rules.
1661         * breakpoint.c (set_breakpoint_condition): Create an
1662         innermost_block_tracker.
1663         (watch_command_1): Likewise.
1664         * ada-lang.c (resolve): Add "tracker" parameter.
1665         (resolve_subexp): Likewise.
1666         * ada-exp.y (write_var_from_sym): Update.
1667
1668 2019-04-04  Tom Tromey  <tom@tromey.com>
1669
1670         * type-stack.h: New file.
1671         * type-stack.c: New file.
1672         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1673         type-stack.h.
1674         (insert_into_type_stack, insert_type, push_type, push_type_int)
1675         (insert_type_address_space, pop_type, pop_type_int)
1676         (pop_typelist, pop_type_stack, append_type_stack)
1677         (push_type_stack, get_type_stack, push_typelist)
1678         (follow_type_instance_flags, follow_types): Don't declare.
1679         * parse.c (type_stack): Remove global.
1680         (parse_exp_in_context): Update.
1681         (insert_into_type_stack, insert_type, push_type, push_type_int)
1682         (insert_type_address_space, pop_type, pop_type_int)
1683         (pop_typelist, pop_type_stack, append_type_stack)
1684         (push_type_stack, get_type_stack, push_typelist)
1685         (follow_type_instance_flags, follow_types): Remove (moved to
1686         type-stack.c).
1687         * f-exp.y (type_stack): New global.
1688         Update rules.
1689         (push_kind_type, f_parse): Update.
1690         * d-exp.y (type_stack): New global.
1691         Update rules.
1692         (d_parse): Update.
1693         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1694         Update rules.
1695         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1696         (HFILES_NO_SRCDIR): Add type-stack.h.
1697
1698 2019-04-04  Tom Tromey  <tom@tromey.com>
1699
1700         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1701         (rust_parser::convert_ast_to_expression, rust_parse)
1702         (rust_lex_test_completion, rust_lex_tests): Update.
1703         * parser-defs.h (struct expr_completion_state): New.
1704         (struct parser_state) <parser_state>: Add completion parameter.
1705         <mark_struct_expression, mark_completion_tag>: New methods.
1706         <parse_completion, m_completion_state>: New members.
1707         (prefixify_expression, null_post_parser): Update.
1708         (mark_struct_expression, mark_completion_tag): Don't declare.
1709         * parse.c (parse_completion, expout_last_struct)
1710         (expout_tag_completion_type, expout_completion_name): Remove
1711         globals.
1712         (parser_state::mark_struct_expression)
1713         (parser_state::mark_completion_tag): Now methods.
1714         (prefixify_expression): Add last_struct parameter.
1715         (prefixify_subexp): Likewise.
1716         (parse_exp_1): Update.
1717         (parse_exp_in_context): Add cstate parameter.  Update.
1718         (parse_expression_for_completion): Create an
1719         expr_completion_state.
1720         (null_post_parser): Add "completion" parameter.
1721         * p-exp.y: Update rules.
1722         (yylex): Update.
1723         * language.h (struct language_defn) <la_post_parser>: Add
1724         "completing" parameter.
1725         * go-exp.y: Update rules.
1726         (lex_one_token): Update.
1727         * expression.h (parse_completion): Don't declare.
1728         * d-exp.y: Update rules.
1729         (lex_one_token): Update rules.
1730         * c-exp.y: Update rules.
1731         (lex_one_token): Update.
1732         * ada-lang.c (resolve): Add "parse_completion" parameter.
1733         (resolve_subexp): Likewise.
1734         (ada_resolve_function): Likewise.
1735
1736 2019-04-04  Tom Tromey  <tom@tromey.com>
1737
1738         * parser-defs.h (struct parser_state) <start_arglist,
1739         end_arglist>: New methods.
1740         <arglist_len, m_funcall_chain>: New members.
1741         (arglist_len, start_arglist, end_arglist): Don't declare.
1742         * parse.c (arglist_len, funcall_chain): Remove global.
1743         (start_arglist, end_arglist): Remove functions.
1744         (parse_exp_in_context): Update.
1745         * p-exp.y: Update rules.
1746         * m2-exp.y: Update rules.
1747         * go-exp.y: Update rules.
1748         * f-exp.y: Update rules.
1749         * d-exp.y: Update rules.
1750         * c-exp.y: Update rules.
1751
1752 2019-04-04  Tom Tromey  <tom@tromey.com>
1753
1754         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1755         lex_operator, push_back>: New methods.
1756         Update all rules.
1757         (rust_parser::lex_hex, lex_escape): Rename and update.
1758         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1759         (rust_parser::lex_operator): Rename and update.
1760         (rust_parser::lex_number, rustyylex, rustyyerror)
1761         (rust_lex_test_init, rust_lex_test_sequence)
1762         (rust_lex_test_push_back, rust_lex_tests): Update.
1763         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1764         parameter.
1765         <lexptr, prev_lexptr>: New members.
1766         (lexptr, prev_lexptr): Don't declare.
1767         * parse.c (lexptr, prev_lexptr): Remove globals.
1768         (parse_exp_in_context): Update.
1769         * p-exp.y (yylex, yyerror): Update.
1770         * m2-exp.y (parse_number, yylex, yyerror): Update.
1771         * go-exp.y (lex_one_token, yyerror): Update.
1772         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1773         * d-exp.y (lex_one_token, yyerror): Update.
1774         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1775         (lex_one_token, yyerror): Update.
1776         * ada-lex.l (YY_INPUT): Update.
1777         (rewind_to_char): Update.
1778         * ada-exp.y (yyerror): Update.
1779
1780 2019-04-04  Tom Tromey  <tom@tromey.com>
1781
1782         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1783         * parser-defs.h (struct parser_state) <parser_state>: Add new
1784         parameter.
1785         <comma_terminates>: New member.
1786         (comma_terminates): Don't declare global.
1787         * parse.c (comma_terminates): Remove global.
1788         (parse_exp_in_context): Update.
1789         * p-exp.y (yylex): Update.
1790         * m2-exp.y (yylex): Update.
1791         * go-exp.y (lex_one_token): Update.
1792         * f-exp.y (yylex): Update.
1793         * d-exp.y (lex_one_token): Update.
1794         * c-exp.y (lex_one_token): Update.
1795         * ada-lex.l: Update.
1796
1797 2019-04-04  Tom Tromey  <tom@tromey.com>
1798
1799         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1800         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1801         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1802         * parser-defs.h (paren_depth): Don't declare.
1803         * parse.c (paren_depth): Remove global.
1804         (parse_exp_in_context): Update.
1805         * p-exp.y (paren_depth): New global.
1806         (pascal_parse): Initialize it.
1807         * m2-exp.y (paren_depth): New global.
1808         (m2_parse): Initialize it.
1809         * go-exp.y (paren_depth): New global.
1810         (go_parse): Initialize it.
1811         * f-exp.y (paren_depth): New global.
1812         (f_parse): Initialize it.
1813         * d-exp.y (paren_depth): New global.
1814         (d_parse): Initialize it.
1815         * c-exp.y (paren_depth): New global.
1816         (c_parse): Initialize it.
1817         * ada-lex.l (paren_depth): New global.
1818         (lexer_init): Initialize it.
1819
1820 2019-04-04  Tom Tromey  <tom@tromey.com>
1821
1822         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1823         (rust_parser::convert_ast_to_type)
1824         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1825         * parser-defs.h (struct parser_state) <parser_state>: Add
1826         parameters.  Initialize new members.
1827         <expression_context_block, expression_context_pc>: New members.
1828         * parse.c (expression_context_block, expression_context_pc):
1829         Remove globals.
1830         (parse_exp_in_context): Update.
1831         * p-exp.y: Update all rules.
1832         (yylex): Update.
1833         * m2-exp.y: Update all rules.
1834         (yylex): Update.
1835         * go-exp.y (yylex): Update.
1836         * f-exp.y (yylex): Update.
1837         * d-exp.y: Update all rules.
1838         (yylex): Update.
1839         * c-exp.y: Update all rules.
1840         (lex_one_token, classify_name, yylex, c_parse): Update.
1841         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1842
1843 2019-04-04  Tom Tromey  <tom@tromey.com>
1844
1845         * gdbarch.h, gdbarch.c: Rebuild.
1846         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1847         * stap-probe.h:
1848         (struct stap_parse_info): Replace "parser_state" with
1849         "expr_builder".
1850         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1851         (parser_state): New class.
1852         * parse.c (expr_builder): Rename.
1853         (expr_builder::release): Rename.
1854         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1855         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1856         (write_exp_elt_longcst, write_exp_elt_floatcst)
1857         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1858         (write_exp_string_vector, write_exp_bitstring)
1859         (write_exp_msymbol, mark_struct_expression)
1860         (write_dollar_variable)
1861         (insert_type_address_space, increase_expout_size): Replace
1862         "parser_state" with "expr_builder".
1863         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1864         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1865         "parser_state" with "expr_builder".
1866
1867 2019-04-04  Tom Tromey  <tom@tromey.com>
1868
1869         * rust-exp.y: Replace "parse_language" with method call.
1870         * p-exp.y:
1871         (yylex): Replace "parse_language" with method call.
1872         * m2-exp.y:
1873         (yylex): Replace "parse_language" with method call.
1874         * go-exp.y (classify_name): Replace "parse_language" with method
1875         call.
1876         * f-exp.y (yylex): Replace "parse_language" with method call.
1877         * d-exp.y (lex_one_token): Replace "parse_language" with method
1878         call.
1879         * c-exp.y:
1880         (lex_one_token, classify_name, yylex): Replace "parse_language"
1881         with method call.
1882         * ada-exp.y (find_primitive_type, type_char)
1883         (type_system_address): Replace "parse_language" with method call.
1884
1885 2019-04-04  Tom Tromey  <tom@tromey.com>
1886
1887         * rust-exp.y: Replace "parse_gdbarch" with method call.
1888         * parse.c (write_dollar_variable, insert_type_address_space):
1889         Replace "parse_gdbarch" with method call.
1890         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1891         call.
1892         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1893         call.
1894         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1895         "parse_gdbarch" with method call.
1896         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1897         with method call.
1898         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1899         "parse_gdbarch" with method call.
1900         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1901         "parse_gdbarch" with method call.
1902         * c-exp.y (parse_type, parse_number, classify_name): Replace
1903         "parse_gdbarch" with method call.
1904         * ada-lex.l: Replace "parse_gdbarch" with method call.
1905         * ada-exp.y (parse_type, find_primitive_type, type_char)
1906         (type_system_address): Replace "parse_gdbarch" with method call.
1907
1908 2019-04-04  Tom Tromey  <tom@tromey.com>
1909
1910         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1911         * stap-probe.c (stap_parse_argument): Update.
1912         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1913         initial_size parameter.
1914         * rust-exp.y (rust_lex_tests): Update.
1915         * parse.c (parser_state): Update.
1916         (parse_exp_in_context): Update.
1917         * parser-defs.h (struct parser_state) <parser_state>: Remove
1918         "initial_size" parameter.
1919
1920 2019-04-04  Tom Tromey  <tom@tromey.com>
1921
1922         * parser-defs.h (increase_expout_size): Don't declare.
1923         * parse.c (increase_expout_size): Now static.
1924
1925 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1926
1927         * gnu-nat.c (gnu_nat_target::wait): Fix
1928         target_waitstatus_to_string call.
1929
1930 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1931
1932         * eval.c (evaluate_subexp_standard): Handle internal functions
1933         during Fortran function call handling.
1934
1935 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1936
1937         * NEWS: Mention new internal functions.
1938         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1939         (read_base_type): Use dwarf2_init_complex_target_type.
1940         * value.c (creal_internal_fn): New function.
1941         (cimag_internal_fn): New function.
1942         (_initialize_values): Register new internal functions.
1943
1944 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1945
1946         * infrun.c (stop_all_threads): If debug_infrun, always
1947         trace the wait status after wait_one, using
1948         target_waitstatus_to_string and target_pid_to_str.
1949         (handle_inferior_event): Replace various trace of
1950         wait status kind by a single trace.
1951         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1952         wait status kind image by target_waitstatus_to_string.
1953         * target/waitstatus.c (target_waitstatus_to_string): Fix
1954         obsolete comment.
1955
1956 2019-04-01  Tom Tromey  <tromey@adacore.com>
1957
1958         PR symtab/23331:
1959         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1960
1961 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1962             Pedro Alves  <palves@redhat.com>
1963
1964         * top.c (quit_force): Call 'finalize_values'.
1965         * value.c (finalize_values): New function.
1966         * value.h (finalize_values): Declare.
1967
1968 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1969
1970         * NEWS: Announce $_gdb_major and $_gdb_minor.
1971
1972         * top.c (init_gdb_version_vars): New function.
1973         (gdb_init): Call init_gdb_version_vars.
1974
1975 2019-03-29  Tom Tromey  <tromey@adacore.com>
1976
1977         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1978         help text.  Remove dead code.
1979
1980 2019-03-29  Keith Seitz  <keiths@redhat.com>
1981
1982         From Siddhesh Poyarekar:
1983         * f-lang.h (f77_get_upperbound): Return LONGEST.
1984         (f77_get_lowerbound): Likewise.
1985         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1986         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1987         print them.
1988         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1989         plongest to format print it.
1990         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1991         (f77_get_upperbound): Likewise.
1992         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1993         LOWER_BOUND to LONGEST.
1994         (f77_create_arrayprint_offset_tbl): Likewise.
1995
1996 2019-03-29  Keith Seitz  <keiths@redhat.com>
1997
1998         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1999         %s/pulongest for TYPE_LENGTH instead of %d in format
2000         strings.
2001         * ada-typerint.c (ada_print_type): Likewise.
2002         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2003         * compile/compile-c-support.c (generate_register_struct): Likewise.
2004         * gdbtypes.c (recursive_dump_type): Likewise.
2005         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2006         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2007         instead of %d in format strings.
2008         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2009         to std::min to ULONGEST.
2010         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2011         instead of %d in format strings.
2012         * tracepoint.c (info_scope_command): Likewise.
2013         * typeprint.c (print_offset_data::update)
2014         (print_offset_data::finish): Likewise.
2015         * xtensa-tdep.c (xtensa_store_return_value)
2016         (xtensa_push_dummy_call): Likewise.
2017
2018 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2019
2020         * windows-nat.c (display_selector): Fixed format specifications
2021         for 64-bit Cygwin.
2022
2023 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2024
2025         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2026
2027 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2028
2029         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2030         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2031         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2032         (nios2_linux_init_abi): Install it.
2033
2034 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2035
2036         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2037
2038 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2039
2040         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2041
2042 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2043             Tom Tromey  <tromey@adacore.com>
2044
2045         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2046
2047 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2048
2049         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2050         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2051         method to compute the bounds of range types. Also print "[evaluated]"
2052         if the bounds' values come from a dynamic evaluation.
2053
2054 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2055
2056         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2057         whitespace when pretty printing is on.
2058
2059 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2060
2061         * ppc-linux-nat.c: Add include.
2062
2063 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2064
2065         * NEWS: Mention AArch64 Pointer Authentication.
2066
2067 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2068
2069         * arm-linux-nat.c: Add include.
2070
2071 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2072
2073         * source-cache.c (source_cache::get_source_lines): Re-read
2074         fullname after calling open_source_file.
2075
2076 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2077
2078         * NEWS: Mention TLS support for FreeBSD.
2079
2080 2019-03-25  Tom Tromey  <tromey@adacore.com>
2081
2082         * minsyms.c (BUNCH_SIZE): Update comment.
2083         (~minimal_symbol_reader): Remove old comment.
2084         (compact_minimal_symbols): Update comment.
2085         (minimal_symbol_reader::install): Remove old comment.  Update
2086         other comments.
2087
2088 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2089
2090         * s390-linux-nat.c: Add include.
2091
2092 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2093
2094         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2095         Call linux_get_hwcap.
2096         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2097         Likewise.
2098         (aarch64_linux_get_hwcap): Remove function.
2099         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2100         declaration.
2101         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2102         linux_get_hwcap.
2103         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2104         * linux-tdep.c (linux_get_hwcap): Add function.
2105         (linux_get_hwcap2): Likewise.
2106         * linux-tdep.h (linux_get_hwcap): Add declaration.
2107         (linux_get_hwcap2): Likewise.
2108         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2109         (ppc_linux_get_hwcap2): Likewise.
2110         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2111         linux_get_hwcap.
2112         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2113         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2114         (ppc_linux_nat_target::read_description): Likewise.
2115         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2116         * s390-linux-nat.c: Likewise.
2117         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2118
2119 2019-03-24  Tom Tromey  <tom@tromey.com>
2120
2121         * ada-lang.c (standard_lookup): Simplify initialization.
2122         (ada_lookup_symbol_nonlocal): Simplify return.
2123         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2124         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2125         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2126         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2127         initialization.
2128         * solib.c (solib_global_lookup): Simplify.
2129         * symtab.c (null_block_symbol): Remove.
2130         (symbol_cache_lookup): Simplify returns.
2131         (lookup_language_this): Simplify returns.
2132         (lookup_symbol_aux): Simplify return.
2133         (lookup_local_symbol): Simplify returns.
2134         (lookup_global_symbol_from_objfile): Simplify return.
2135         (lookup_symbol_in_objfile_symtabs)
2136         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2137         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2138         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2139         * cp-namespace.c (cp_lookup_bare_symbol)
2140         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2141         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2142         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2143         (cp_lookup_symbol_via_imports): Simplify initialization.
2144         (find_symbol_in_baseclass): Likewise.
2145         * symtab.h (null_block_symbol): Remove.
2146         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2147         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2148         (d_lookup_symbol_module): Likewise.
2149         (find_symbol_in_baseclass): Simplify initialization.
2150
2151 2019-03-24  Tom Tromey  <tom@tromey.com>
2152
2153         * expression.h: Don't include symtab.h.
2154         (struct block): Forward declare.
2155
2156 2019-03-24  Tom Tromey  <tom@tromey.com>
2157
2158         * c-exp.y (typebase): Remove casts.
2159         * gdbtypes.c (lookup_unsigned_typename, )
2160         (lookup_signed_typename): Remove cast.
2161         * eval.c (parse_to_comma_and_eval): Remove cast.
2162         * parse.c (write_dollar_variable): Remove cast.
2163         * block.h (struct block) <superblock>: Now const.
2164         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2165         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2166         (map_block): Make "block" const.
2167         * symfile.h (struct quick_symbol_functions)
2168         <map_matching_symbols>: Constify block argument to "callback".
2169         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2170         const.
2171         (find_pc_sect_compunit_symtab): Make "b" const.
2172         (find_symbol_at_address): Likewise.
2173         (search_symbols): Likewise.
2174         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2175         (dw2_debug_names_lookup_symbol): Likewise.
2176         (dw2_map_matching_symbols): Update.
2177         * p-valprint.c (pascal_val_print): Remove "block".
2178         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2179         (aux_add_nonlocal_symbols): Make "block" const.
2180         (resolve_subexp): Remove cast.
2181         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2182         const.
2183         (iterate_over_file_blocks): Likewise.
2184         * f-exp.y (%union) <bval>: Remove.
2185         * coffread.c (patch_opaque_types): Make "b" const.
2186         * spu-tdep.c (spu_catch_start): Make "block" const.
2187         * c-valprint.c (print_unpacked_pointer): Remove "block".
2188         * symmisc.c (dump_symtab_1): Make "b" const.
2189         (block_depth): Make "block" const.
2190         * d-exp.y (%union) <bval>: Remove.
2191         * cp-support.h (cp_lookup_rtti_type): Update.
2192         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2193         * psymtab.c (psym_lookup_symbol): Make "block" const.
2194         (maintenance_check_psymtabs): Make "b" const.
2195         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2196         (enumerate_locals, enumerate_args): Update.
2197         * python/py-symtab.c (stpy_global_block): Make "block" const.
2198         (stpy_static_block): Likewise.
2199         * inline-frame.c (block_starting_point_at): Make "new_block"
2200         const.
2201         * block.c (find_block_in_blockvector): Make return type const.
2202         (blockvector_for_pc_sect): Make "b" const.
2203         (find_block_in_blockvector): Make "b" const.
2204
2205 2019-03-23  Tom Tromey  <tom@tromey.com>
2206
2207         * varobj.c (varobj_create): Update.
2208         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2209         * printcmd.c (display_command, do_one_display): Don't reset
2210         innermost_block.
2211         * parser-defs.h (enum innermost_block_tracker_type): Move to
2212         expression.h.
2213         (innermost_block): Update comment.
2214         * parse.c (parse_exp_1): Add tracker_types parameter.
2215         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2216         tracker_types parameter.  Reset innermost_block.
2217         (parse_exp_in_context): Remove.
2218         (parse_expression_for_completion): Update.
2219         * objfiles.c (~objfile): Don't reset expression_context_block or
2220         innermost_block.
2221         * expression.h (enum innermost_block_tracker_type): Move from
2222         parser-defs.h.
2223         (parse_exp_1): Add tracker_types parameter.
2224         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2225         reset innermost_block.
2226
2227 2019-03-23  Tom Tromey  <tom@tromey.com>
2228
2229         * objfiles.h: Include bcache.h.
2230
2231 2019-03-23  Tom Tromey  <tom@tromey.com>
2232
2233         * linespec.c (get_current_search_block): Use
2234         scoped_restore_current_language.
2235         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2236
2237 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2238             Jiong Wang  <jiong.wang@arm.com>
2239
2240         * aarch64-linux-tdep.c
2241         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2242         section.
2243         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2244
2245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2246             Jiong Wang  <jiong.wang@arm.com>
2247
2248         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2249         instructions.
2250         (aarch64_analyze_prologue_test): Add PACIASP test.
2251         (aarch64_prologue_prev_register): Unmask PC value.
2252
2253 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2254             Jiong Wang  <jiong.wang@arm.com>
2255
2256         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2257         (aarch64_dwarf2_prev_register): Unmask PC value.
2258         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2259         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2260         DW_CFA_AARCH64_negate_ra_state.
2261         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2262
2263 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2264             Jiong Wang  <jiong.wang@arm.com>
2265
2266         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2267         registers.
2268         (aarch64_pseudo_register_name): Likewise.
2269         (aarch64_pseudo_register_type): Likewise.
2270         (aarch64_pseudo_register_reggroup_p): Likewise.
2271         (aarch64_gdbarch_init): Add pauth registers.
2272         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2273         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2274         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2275         (struct gdbarch_tdep): Add regnum for ra_state.
2276
2277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2278             Jiong Wang  <jiong.wang@arm.com>
2279
2280         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2281
2282 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2283             Jiong Wang  <jiong.wang@arm.com>
2284
2285         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2286         function.
2287         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2288         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2289         (aarch64_gdbarch_init): Add puth registers.
2290         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2291         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2292         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2293
2294 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2295             Jiong Wang  <jiong.wang@arm.com>
2296
2297         * aarch64-linux-nat.c
2298         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2299         * aarch64-linux-tdep.c
2300         (aarch64_linux_core_read_description): Likewise.
2301         (aarch64_linux_get_hwcap): New function.
2302         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2303         (aarch64_linux_get_hwcap): New declaration.
2304
2305 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2306             Jiong Wang  <jiong.wang@arm.com>
2307
2308         * aarch64-linux-nat.c
2309         (aarch64_linux_nat_target::read_description): Add pauth param.
2310         * aarch64-linux-tdep.c
2311         (aarch64_linux_core_read_description): Likewise.
2312         * aarch64-tdep.c (struct target_desc): Add in pauth.
2313         (aarch64_read_description): Add pauth param.
2314         (aarch64_gdbarch_init): Likewise.
2315         * aarch64-tdep.h (aarch64_read_description): Likewise.
2316         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2317         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2318         * features/Makefile: Add new files.
2319         * features/aarch64-pauth.c: New file.
2320         * features/aarch64-pauth.xml: New file.
2321
2322 2019-03-20  Tom Tromey  <tromey@adacore.com>
2323
2324         * infrun.c (handle_inferior_event): Rename from
2325         handle_inferior_event_1.  Create a scoped_value_mark.
2326         (handle_inferior_event): Remove.
2327
2328 2019-03-19  Tom Tromey  <tromey@adacore.com>
2329
2330         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2331         * infrun.h (print_stop_event): Add "displays" parameter.
2332         * infrun.c (print_stop_event): Add "displays" parameter.
2333
2334 2019-03-19  Pedro Alves  <palves@redhat.com>
2335
2336         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2337         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2338         to -1.  Fix TABs vs spaces.
2339         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2340         * tui/tui-out.h (tui_ui_out) Add intro comments.
2341         <m_line, m_start_of_line>: In-class initialize, and add describing
2342         comment.
2343
2344 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2345
2346         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2347         variable names.
2348         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2349
2350 2019-03-18  Pedro Alves  <palves@redhat.com>
2351             Eli Zaretskii <eliz@gnu.org>
2352
2353         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2354         m_line and m_start_of_line.
2355
2356 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2357
2358         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2359         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2360         it returns a newline.  This fixes a regression in TU mode, whereby
2361         the next line is output on the same screen line as the user input.
2362
2363 2019-03-18  Tom Tromey  <tromey@adacore.com>
2364
2365         * minsyms.c (minimal_symbol_reader::install): Remove call to
2366         obstack_blank.
2367
2368 2019-03-18  Pedro Alves  <palves@redhat.com>
2369
2370         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2371         New globals.
2372         (apply_style): New, factored out from ...
2373         (apply_ansi_escape): ... this.  Handle reverse video mode.
2374         (tui_set_reverse_mode): New function.
2375         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2376         * tui/tui-winsource.c (tui_show_source_line): Use
2377         tui_set_reverse_mode instead of setting A_STANDOUT.
2378         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2379         New setter methods.
2380
2381 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2382
2383         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2384         Handle tabs.
2385
2386 2019-03-18  Tom Tromey  <tromey@adacore.com>
2387
2388         * ada-lang.c (empty_array): Add "high" parameter.
2389         (ada_evaluate_subexp): Update.
2390
2391 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2392
2393         * unittests/string_view-selftests.c: Define
2394         _initialize_string_view_selftests unconditionally.
2395
2396 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2397
2398         PR gdb/24350
2399         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2400
2401 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2402
2403         PR gdb/24351
2404         * windows-nat.c (display_selector): Fix format specifiers.
2405
2406 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2407
2408         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2409         tui_refill_source_window instead of tui_refresh_win, to update the
2410         current execution line.  This fixes redisplay of the current line
2411         when stepping through the code with "next" or "step".
2412
2413 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2414
2415         * source-cache.c (source_cache::get_source_lines): Call
2416         find_source_lines to initialize s->nlines.  This fixes vertical
2417         scrolling of TUI source window when the DOWN arrow is pressed.
2418
2419 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2420
2421         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2422         linux-thread-db.c (_initialize_thread_db): Likewise.
2423
2424 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2425
2426         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2427         wclrtoeol in tui_show_source_line".  This reverts changes made in
2428         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2429
2430 2019-03-15  Tom Tromey  <tom@tromey.com>
2431
2432         * symtab.h (struct minimal_symbol): Derive from
2433         general_symbol_info.
2434         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2435         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2436         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2437         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2438         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2439         (MSYMBOL_SEARCH_NAME): Update.
2440         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2441         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2442         * minsyms.c (minimal_symbol_reader::record_full): Update.
2443
2444 2019-03-15  Tom Tromey  <tom@tromey.com>
2445
2446         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2447
2448 2019-03-15  Tom Tromey  <tom@tromey.com>
2449
2450         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2451         unique_xmalloc_ptr.
2452         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2453         Update.
2454         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2455         (build_minimal_symbol_hash_tables)
2456         (minimal_symbol_reader::install): Update.
2457
2458 2019-03-15  Tom Tromey  <tom@tromey.com>
2459
2460         * symtab.c (create_demangled_names_hash): Update.
2461         (symbol_set_names): Update.
2462         * objfiles.h (struct objfile_per_bfd_storage)
2463         <demangled_names_hash>: Now an htab_up.
2464         * objfiles.c (objfile_per_bfd_storage): Simplify.
2465
2466 2019-03-15  Tom Tromey  <tom@tromey.com>
2467
2468         * objfiles.h (struct objfile_per_bfd_storage): Declare
2469         destructor.
2470         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2471         New.
2472         (get_objfile_bfd_data): Use new.  Don't initialize
2473         language_of_main.
2474         (free_objfile_per_bfd_storage): Remove.
2475         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2476
2477 2019-03-15  Tom Tromey  <tom@tromey.com>
2478
2479         * symfile.c (reread_symbols): Update.
2480         * objfiles.c (objfile::objfile): Update.
2481         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2482         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2483         comment.
2484         (minimal_symbol_reader::install): Update.
2485         (terminate_minimal_symbol_table): Remove.
2486         * jit.c (jit_object_close_impl): Update.
2487
2488 2019-03-15  Tom Tromey  <tom@tromey.com>
2489
2490         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2491         initializations.
2492
2493 2019-03-15  Tom Tromey  <tom@tromey.com>
2494
2495         * objfiles.h (struct objfile_per_bfd_storage)
2496         <demangled_hash_languages>: Now a bitset.
2497         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2498         (lookup_minimal_symbol): Update.
2499
2500 2019-03-15  Tom Tromey  <tom@tromey.com>
2501
2502         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2503         Don't return the symbol.
2504         * coffread.c (record_minimal_symbol): Use record_full.
2505
2506 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2507
2508         The MS-Windows port of ncurses fails to switch to a color pair if
2509         one or both of the colors are the implicit default colors.  This
2510         change records the default colors when TUI is initialized, and
2511         then specifies them explicitly when a color pair uses the default
2512         colors.  This allows color styling in TUI mode on MS-Windows.
2513
2514         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2515         ncurses_norm_attr.
2516         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2517         colors in ncurses_norm_attr.
2518         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2519         "none", replace it with the default color recorded in
2520         ncurses_norm_attr.
2521
2522 2019-03-14  Tom Tromey  <tromey@adacore.com>
2523
2524         * source-cache.h (class source_cache) <get_source_lines>: Return
2525         std::string.
2526         * source-cache.c (source_cache::extract_lines): Handle case where
2527         first_pos==npos.  Return std::string.
2528         (source_cache::get_source_lines): Update.
2529
2530 2019-03-14  Tom Tromey  <tromey@adacore.com>
2531
2532         * NEWS: Add item for "style sources" commands.
2533         * source-cache.c (source_cache::get_source_lines): Check
2534         source_styling.
2535         * cli/cli-style.c (source_styling): New global.
2536         (_initialize_cli_style): Add "style sources" commands.
2537         (show_style_sources): New function.
2538         * cli/cli-style.h (source_styling): Declare.
2539
2540 2019-03-14  Pedro Alves  <palves@redhat.com>
2541             Tom Tromey  <tromey@adacore.com>
2542
2543         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2544         * tui/tui-winsource.c (tui_refill_source_window): New function,
2545         from...
2546         (tui_horizontal_source_scroll): ... here.  Move some logic.
2547         * cli/cli-style.c (set_style_enabled): Notify new observable.
2548         * tui/tui-hooks.c (tui_redisplay_source): New function.
2549         (tui_attach_detach_observers): Attach or detach
2550         tui_redisplay_source.
2551         * observable.h (source_styling_changed): New observable.
2552         * observable.c: Define source_styling_changed observable.
2553
2554 2019-03-13  Tom Tromey  <tromey@adacore.com>
2555
2556         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2557         (i386_gnu_nat_target::store_registers): Update.
2558         * target-debug.h (target_debug_print_std_string): New macro.
2559         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2560         * windows-tdep.c (display_one_tib): Update.
2561         * tui/tui-stack.c (tui_make_status_line): Update.
2562         * top.c (print_inferior_quit_action): Update.
2563         * thread.c (thr_try_catch_cmd): Update.
2564         (add_thread_with_info): Update.
2565         (thread_target_id_str): Update.
2566         (thr_try_catch_cmd): Update.
2567         (thread_command): Update.
2568         (thread_find_command): Update.
2569         * record-btrace.c (record_btrace_target::info_record)
2570         (record_btrace_resume_thread, record_btrace_target::resume)
2571         (record_btrace_cancel_resume, record_btrace_step_thread)
2572         (record_btrace_target::wait, record_btrace_target::wait)
2573         (record_btrace_target::wait, record_btrace_target::stop): Update.
2574         * progspace.c (print_program_space): Update.
2575         * process-stratum-target.c
2576         (process_stratum_target::thread_address_space): Update.
2577         * linux-fork.c (linux_fork_mourn_inferior)
2578         (detach_checkpoint_command, info_checkpoints_command)
2579         (linux_fork_context): Update.
2580         (linux_fork_detach): Update.
2581         (class scoped_switch_fork_info): Update.
2582         (delete_checkpoint_command): Update.
2583         * infrun.c (follow_fork_inferior): Update.
2584         (follow_fork_inferior): Update.
2585         (proceed_after_vfork_done): Update.
2586         (handle_vfork_child_exec_or_exit): Update.
2587         (follow_exec): Update.
2588         (displaced_step_prepare_throw): Update.
2589         (displaced_step_restore): Update.
2590         (start_step_over): Update.
2591         (resume_1): Update.
2592         (clear_proceed_status_thread): Update.
2593         (proceed): Update.
2594         (print_target_wait_results): Update.
2595         (do_target_wait): Update.
2596         (context_switch): Update.
2597         (stop_all_threads): Update.
2598         (restart_threads): Update.
2599         (finish_step_over): Update.
2600         (handle_signal_stop): Update.
2601         (switch_back_to_stepped_thread): Update.
2602         (keep_going_pass_signal): Update.
2603         (print_exited_reason): Update.
2604         (normal_stop): Update.
2605         * inferior.c (inferior_pid_to_str): Change return type.
2606         (print_selected_inferior): Update.
2607         (add_inferior): Update.
2608         (detach_inferior): Update.
2609         * dummy-frame.c (fprint_dummy_frames): Update.
2610         * dcache.c (dcache_info_1): Update.
2611         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2612         (btrace_fetch, btrace_clear): Update.
2613         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2614         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2615         type.
2616         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2617         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2618         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2619         * gdbarch.c, gdbarch.h: Rebuild.
2620         * gdbarch.sh (core_pid_to_str): Change return type.
2621         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2622         return type.
2623         (windows_nat_target::pid_to_str): Change return type.
2624         (windows_delete_thread): Update.
2625         (windows_nat_target::attach): Update.
2626         (windows_nat_target::files_info): Update.
2627         * target-delegates.c: Rebuild.
2628         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2629         return type.
2630         (sol_thread_target::pid_to_str): Change return type.
2631         * remote.c (class remote_target) <pid_to_str>: Change return
2632         type.
2633         (remote_target::pid_to_str): Change return type.
2634         (extended_remote_target::attach, remote_target::remote_stop_ns)
2635         (remote_target::remote_notif_remove_queued_reply)
2636         (remote_target::push_stop_reply, remote_target::disable_btrace):
2637         Update.
2638         (extended_remote_target::attach): Update.
2639         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2640         type.
2641         (gdbsim_target::pid_to_str): Change return type.
2642         * ravenscar-thread.c (struct ravenscar_thread_target)
2643         <pid_to_str>: Change return type.
2644         (ravenscar_thread_target::pid_to_str): Change return type.
2645         * procfs.c (class procfs_target) <pid_to_str>: Change return
2646         type.
2647         (procfs_target::pid_to_str): Change return type.
2648         (procfs_target::attach): Update.
2649         (procfs_target::detach): Update.
2650         (procfs_target::fetch_registers): Update.
2651         (procfs_target::store_registers): Update.
2652         (procfs_target::wait): Update.
2653         (procfs_target::files_info): Update.
2654         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2655         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2656         return type.
2657         (nto_procfs_target::pid_to_str): Change return type.
2658         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2659         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2660         return type.
2661         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2662         (exit_lwp): Update.
2663         (attach_proc_task_lwp_callback, get_detach_signal)
2664         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2665         (linux_nat_target::resume, wait_lwp, stop_callback)
2666         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2667         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2668         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2669         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2670         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2671         type.
2672         (inf_ptrace_target::attach): Update.
2673         (inf_ptrace_target::files_info): Update.
2674         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2675         type.
2676         (go32_nat_target::pid_to_str): Change return type.
2677         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2678         (gnu_nat_target::wait): Update.
2679         (gnu_nat_target::wait): Update.
2680         (gnu_nat_target::resume): Update.
2681         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2682         (fbsd_nat_target::wait): Update.
2683         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2684         type.
2685         (darwin_nat_target::attach): Update.
2686         * corelow.c (class core_target) <pid_to_str>: Change return type.
2687         (core_target::pid_to_str): Change return type.
2688         * target.c (normal_pid_to_str): Change return type.
2689         (default_pid_to_str): Likewise.
2690         (target_pid_to_str): Change return type.
2691         (target_translate_tls_address): Update.
2692         (target_announce_detach): Update.
2693         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2694         return type.
2695         (bsd_uthread_target::pid_to_str): Change return type.
2696         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2697         type.
2698         (bsd_kvm_target::pid_to_str): Change return type.
2699         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2700         return type.
2701         (aix_thread_target::pid_to_str): Change return type.
2702         * target.h (struct target_ops) <pid_to_str>: Change return type.
2703         (target_pid_to_str, normal_pid_to_str): Likewise.
2704         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2705         type.
2706         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2707         type.
2708         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2709         return type.
2710         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2711         type.
2712         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2713         type.
2714         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2715         return type.
2716
2717 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2718
2719         * NEWS: Mention that the new default MI version is 3.  Mention
2720         changes to the output of commands and events that deal with
2721         multi-location breakpoints.
2722         * breakpoint.c: Include "mi/mi-out.h".
2723         (print_one_breakpoint): Change output syntax if using MI version
2724         >= 3.
2725         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2726         New.
2727         (mi_multi_location_breakpoint_output_fixed): New.
2728         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2729         (mi_cmd_fix_multi_location_breakpoint_output): New.
2730         (mi_multi_location_breakpoint_output_fixed): New.
2731         * mi/mi-cmds.c (mi_cmds): Register command
2732         -fix-multi-location-breakpoint-output.
2733         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2734         interpreter "mi".
2735
2736 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2737
2738         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2739         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2740         instantiate mi_ui_out based on interpreter name.
2741         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2742         * mi/mi-main.c (mi_load_progress): Likewise.
2743
2744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2745
2746         * NEWS: Combine separate "New targets" sections for 8.3.
2747
2748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2749
2750         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2751         (ppcfbsd_init_abi): Install gdbarch
2752         "fetch_tls_load_module_address" and "get_thread_local_address"
2753         methods.
2754
2755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2756
2757         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2758         (riscv_fbsd_init_abi): Install gdbarch
2759         "fetch_tls_load_module_address" and "get_thread_local_address"
2760         methods.
2761
2762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2763
2764         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2765         (i386fbsd_init_abi): Install gdbarch
2766         "fetch_tls_load_module_address" and "get_thread_local_address"
2767         methods.
2768
2769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2770
2771         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2772         (amd64fbsd_init_abi): Install gdbarch
2773         "fetch_tls_load_module_address" and "get_thread_local_address"
2774         methods.
2775
2776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2777
2778         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2779         (struct fbsd_pspace_data): New type.
2780         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2781         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2782         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2783         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2784         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2785
2786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2787
2788         * gdbtypes.c (lookup_struct_elt): New function.
2789         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2790         * gdbtypes.h (struct struct_elt): New type.
2791         (lookup_struct_elt): New prototype.
2792
2793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2794
2795         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2796         remove disabled code block.
2797
2798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2799
2800         * gdbarch.sh (get_thread_local_address): New method.
2801         * gdbarch.h, gdbarch.c: Regenerate.
2802         * target.c (target_translate_tls_address): Use
2803         gdbarch_get_thread_local_address if present instead of
2804         target::get_thread_local_address.
2805
2806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2807
2808         * target.h (target::get_thread_local_address): Update comment.
2809
2810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2811
2812         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2813         objfile->separate_debug_objfile_backlink if not NULL.
2814
2815 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2816
2817         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2818         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2819         (amd64bsd_store_inferior_registers): Likewise.
2820         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2821         Enable segment base registers.
2822         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2823         PT_GETFSBASE and PT_GETGSBASE.
2824         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2825         PT_SETGSBASE.
2826         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2827         segment base registers.
2828         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2829
2830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2831
2832         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2833         Update calls to i386_target_description to add 'segments'
2834         parameter.
2835         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2836         add segment base registers.
2837         * arch/i386.c (i386_create_target_description): Add 'segments'
2838         parameter to enable segment base registers.
2839         * arch/i386.h (i386_create_target_description): Likewise.
2840         * features/i386/32bit-segments.xml: New file.
2841         * features/i386/32bit-segments.c: Generate.
2842         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2843         call to i386_target_description to add 'segments' parameter.
2844         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2845         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2846         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2847         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2848         if feature is present.
2849         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2850         Add 'segments' parameter to call to i386_target_description.
2851         (i386_target_description): Add 'segments' parameter to enable
2852         segment base registers.
2853         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2854         to call to i386_target_description.
2855         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2856         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2857         Define I386_NUM_REGS.
2858         (i386_target_description): Add 'segments' parameter to enable
2859         segment base registers.
2860
2861 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2862
2863         PR/24325
2864         * source-cache.c: #undef open and close, to avoid unresolved
2865         externals during linking.
2866
2867 2019-03-12  Tom Tromey  <tromey@adacore.com>
2868
2869         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2870         const.  Add initializers.
2871         (_initialize_remote): Don't initialize ptid globals.
2872
2873 2019-03-12  Pedro Alves  <palves@redhat.com>
2874
2875         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2876
2877 2019-03-12  Pedro Alves  <palves@redhat.com>
2878
2879         * cp-name-parser.y (main): Remove unused 'len' variable.
2880
2881 2019-03-12  Tom Tromey  <tromey@adacore.com>
2882
2883         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2884         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2885
2886 2019-03-12  Tom Tromey  <tromey@adacore.com>
2887
2888         * linux-nat.c (iterate_over_lwps): Update.
2889         (stop_callback): Remove parameter.
2890         (stop_wait_callback, detach_callback, resume_set_callback)
2891         (select_singlestep_lwp_callback, set_ignore_sigint)
2892         (status_callback, resumed_callback, resume_clear_callback)
2893         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2894         data parameter.
2895         (linux_nat_target::detach, linux_nat_target::resume)
2896         (linux_stop_and_wait_all_lwps, select_event_lwp)
2897         (linux_nat_filter_event, linux_nat_wait_1)
2898         (linux_nat_target::kill, linux_nat_target::stop)
2899         (linux_nat_target::stop): Update.
2900         (linux_nat_resume_callback): Change type.
2901         (resume_stopped_resumed_lwps, count_events_callback)
2902         (select_event_lwp_callback): Likewise.
2903         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2904         * arm-linux-nat.c (struct update_registers_data): Remove.
2905         (update_registers_callback): Change type.
2906         (arm_linux_insert_hw_breakpoint1): Update.
2907         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2908         parameter.
2909         (x86_linux_dr_set_addr): Update.
2910         (x86_linux_dr_set_control): Update.
2911         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2912         (iterate_over_lwps): Use gdb::function_view.
2913         * nat/aarch64-linux-hw-point.c (struct
2914         aarch64_dr_update_callback_param): Remove.
2915         (debug_reg_change_callback): Change type.
2916         (aarch64_notify_debug_reg_change): Update.
2917         * s390-linux-nat.c (s390_refresh_per_info): Update.
2918
2919 2019-03-11  Tom Tromey  <tromey@adacore.com>
2920
2921         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2922         redundant assignment to "this_cu".
2923
2924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2925
2926         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2927
2928 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2929
2930         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2931         from...
2932         (rank_one_type): ... this.
2933
2934 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2935
2936         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2937         from...
2938         (rank_one_type): ... this.
2939
2940 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2941
2942         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2943         from...
2944         (rank_one_type): ... this.
2945
2946 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2947
2948         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2949         from...
2950         (rank_one_type): ... this.
2951
2952 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2953
2954         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2955         from...
2956         (rank_one_type): ... this.
2957
2958 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2959
2960         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2961         from...
2962         (rank_one_type): ... this.
2963
2964 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2965
2966         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2967         from...
2968         (rank_one_type): ... this.
2969
2970 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2971
2972         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2973         from...
2974         (rank_one_type): ... this.
2975
2976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2977
2978         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2979         from...
2980         (rank_one_type): ... this.
2981
2982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2983
2984         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2985         from...
2986         (rank_one_type): ... this.
2987
2988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2989
2990         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2991         from...
2992         (rank_one_type): ... this.
2993
2994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2995
2996         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2997         from...
2998         (rank_one_type): ... this.
2999
3000 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3001
3002         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3003         inferior-events' shows the example events.
3004
3005 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3006
3007         Support styling on native MS-Windows console
3008
3009         PR/24315
3010         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3011         on MS-Windows if $TERM is not defined.
3012
3013         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3014
3015         * posix-hdep.c (gdb_console_fputs):
3016         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3017         functions.
3018         * ui-file.h (gdb_console_fputs): Add prototype.
3019
3020         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3021         back to fputs only if the former returns zero.
3022
3023 2019-03-07  Tom Tromey  <tom@tromey.com>
3024
3025         * symmisc.c (print_symbol_bcache_statistics): Update.
3026         (print_objfile_statistics): Update.
3027         * symfile.c (allocate_symtab): Update.
3028         * stabsread.c: Don't include bcache.h.
3029         * psymtab.h (struct psymbol_bcache): Don't declare.
3030         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3031         (psymbol_bcache_init, psymbol_bcache_free)
3032         (psymbol_bcache_get_bcache): Don't declare.
3033         * psymtab.c (struct psymbol_bcache): Remove.
3034         (psymtab_storage::psymtab_storage): Update.
3035         (psymtab_storage::~psymtab_storage): Update.
3036         (psymbol_bcache_init, psymbol_bcache_free)
3037         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3038         (add_psymbol_to_bcache): Update.
3039         (allocate_psymtab): Update.
3040         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3041         macro_cache>: No longer pointers.
3042         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3043         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3044         * macrotab.c (macro_bcache): Update.
3045         * macroexp.c: Don't include bcache.h.
3046         * gdbtypes.c (check_types_worklist): Update.
3047         (types_deeply_equal): Remove TRY/CATCH.  Update.
3048         * elfread.c (elf_symtab_read): Update.
3049         * dwarf2read.c: Don't include bcache.h.
3050         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3051         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3052         (print_bcache_statistics, bcache_memory_used): Don't declare.
3053         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3054         methods.  Rename all data members.
3055         * bcache.c (struct bcache): Move to bcache.h.
3056         (bcache::expand_hash_table): Rename from expand_hash_table.
3057         (bcache): Remove.
3058         (bcache::insert): Rename from bcache_full.
3059         (bcache::compare): Rename from bcache_compare.
3060         (bcache_xmalloc): Remove.
3061         (bcache::~bcache): Rename from bcache_xfree.
3062         (bcache::print_statistics): Rename from print_bcache_statistics.
3063         (bcache::memory_used): Rename from bcache_memory_used.
3064
3065 2019-03-07  Pedro Alves  <palves@redhat.com>
3066
3067         * infrun.c (normal_stop): Also check for
3068         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3069
3070 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3071
3072         * f-lang.c (value_from_host_double): Moved to...
3073         * value.c (value_from_host_double): ...here.
3074         * value.h (value_from_host_double): Declare.
3075         * guile/scm-math.c (vlscm_convert_typed_number): Use
3076         value_from_host_double.
3077         (vlscm_convert_number): Likewise.
3078         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3079         * python/py-value.c (convert_value_from_python): Likewise.
3080
3081 2019-03-06  Tom Tromey  <tom@tromey.com>
3082
3083         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3084
3085 2019-03-06  Tom Tromey  <tom@tromey.com>
3086
3087         * utils.h (free_current_contents): Don't declare.
3088         * utils.c (free_current_contents): Remove.
3089
3090 2019-03-06  Tom Tromey  <tom@tromey.com>
3091
3092         * top.c (quit_force): Update.
3093         * main.c (captured_command_loop): Update.
3094         * common/new-op.c (operator new): Update.
3095         * common/common-exceptions.c (struct catcher)
3096         <save_cleanup_chain>: Remove member.
3097         (exceptions_state_mc_init): Update.
3098         (exception_try_scope_entry): Return nullptr.
3099         (exception_try_scope_exit, exception_rethrow)
3100         (throw_exception_sjlj, throw_exception_cxx): Update.
3101         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3102         (all_cleanups, do_cleanups, discard_cleanups)
3103         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3104         (restore_cleanups, restore_final_cleanups): Don't declare.
3105         (do_final_cleanups): Remove parameter.
3106         * common/cleanups.c (cleanup_chain, make_cleanup)
3107         (make_cleanup_dtor, all_cleanups, do_cleanups)
3108         (discard_my_cleanups, discard_cleanups)
3109         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3110         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3111         (null_cleanup): Remove.
3112         (do_final_cleanups): Remove parameter.
3113
3114 2019-03-06  Tom Tromey  <tom@tromey.com>
3115
3116         * remote.c (remote_target::remote_parse_stop_reply): Use
3117         unique_xmalloc_ptr.
3118
3119 2019-03-06  Tom Tromey  <tom@tromey.com>
3120
3121         * stabsread.c (struct stabs_field_info): Rename from field_info.
3122         <list, fnlist>: Add initializers.
3123         <obstack>: New member.
3124         (read_member_functions, read_struct_fields, read_baseclasses):
3125         Allocate on obstack.  Don't use cleanups.
3126         (read_one_struct_field, read_member_functions, read_struct_fields)
3127         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3128         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3129         (read_struct_type): Update.
3130
3131 2019-03-06  Tom Tromey  <tom@tromey.com>
3132
3133         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3134         * common/filestuff.h (make_cleanup_close): Don't declare.
3135         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3136         Remove.
3137
3138 2019-03-06  Tom Tromey  <tom@tromey.com>
3139
3140         * solib-aix.c: Use make_scope_exit.
3141
3142 2019-03-06  Tom Tromey  <tom@tromey.com>
3143
3144         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3145         Use make_scope_exit.
3146
3147 2019-03-06  Tom Tromey  <tom@tromey.com>
3148
3149         * solib-svr4.c (disable_probes_interface): Remove parameter.
3150         (svr4_handle_solib_event): Use make_scope_exit.
3151
3152 2019-03-06  Tom Tromey  <tom@tromey.com>
3153
3154         * remote.c (struct stop_reply_deleter): Remove.
3155         (stop_reply_up): Update.
3156         (struct stop_reply): Derive from notif_event.  Don't typedef.
3157         <regcache>: Now a std::vector.
3158         (stop_reply_xfree): Remove.
3159         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3160         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3161         (remote_target::discard_pending_stop_replies): Use delete.
3162         (remote_target::remote_parse_stop_reply): Update.
3163         (remote_target::process_stop_reply): Update.
3164         * remote-notif.h (struct notif_event): Add virtual destructor.
3165         Remove "dtr" member.
3166         (struct notif_client) <alloc_event>: Return a unique_ptr.
3167         (notif_event_xfree): Don't declare.
3168         (notif_event_up): New typedef.
3169         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3170         (notif_event_xfree, do_notif_event_xfree): Remove.
3171         (remote_notif_state_xfree): Update.
3172
3173 2019-03-06  Tom Tromey  <tom@tromey.com>
3174
3175         * infrun.c (displaced_step_clear_cleanup): Now a
3176         forward_scope_exit type.
3177         (displaced_step_prepare_throw): Update.
3178         (displaced_step_fixup): Update.
3179
3180 2019-03-06  Tom Tromey  <tom@tromey.com>
3181
3182         * inferior.h (class inferior): Update comment.
3183         * gdbthread.h (class thread_info): Update comment.
3184
3185 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3186             Tom Tromey  <tom@tromey.com>
3187
3188         * stabsread.h (struct stab_section_list): Remove.
3189         (coffstab_build_psymtabs): Update.
3190         * dbxread.c (symbuf_sections): Now a std::vector.
3191         (sect_idx): New global.
3192         (fill_symbuf): Update.
3193         (coffstab_build_psymtabs): Change type of stabsects parameter.
3194         Update.
3195         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3196         std::vector.
3197         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3198         (coff_locate_sections): Update.
3199         (coff_symfile_read): Remove cleanups.  Update.
3200         (init_stringtab): Add storage parameter.
3201         (free_stringtab, free_stringtab_cleanup): Remove.
3202         (init_lineno): Add storage parameter.
3203         (free_linetab, free_linetab_cleanup): Remove.
3204
3205 2019-03-06  Pedro Alves  <palves@redhat.com>
3206
3207         * linux-fork.c (fork_info::clobber_regs): Delete.
3208         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3209         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3210         comment.  Adjust.
3211         (scoped_switch_fork_info::scoped_switch_fork_info)
3212         (checkpoint_command, linux_fork_context): Adjust
3213         fork_save_infrun_state calls.
3214
3215 2019-03-06  Pedro Alves  <palves@redhat.com>
3216
3217         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3218         (inf_has_multiple_threads): Return 'bool' and rewrite using
3219         inferior_info::threads().
3220
3221 2019-03-06  Pedro Alves  <palves@redhat.com>
3222
3223         * linux-fork.c: Include <list>.
3224         (fork_list): Now a std::list instance.
3225         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3226         (forks_exist_p, find_last_fork): Adjust.
3227         (new_fork): Delete.
3228         (one_fork_p): New.
3229         (add_fork): Adjust.
3230         (free_fork): Delete, folded into fork_info::~fork_info().
3231         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3232         Adjust.
3233         (init_fork_list): Delete.
3234         (linux_fork_killall, linux_fork_mourn_inferior)
3235         (linux_fork_detach, info_checkpoints_command): Adjust.
3236         (_initialize_linux_fork): No longer call init_fork_list.
3237
3238 2019-03-06  Pedro Alves  <palves@redhat.com>
3239
3240         * linux-fork.c (new_fork): New, split out of ...
3241         (add_fork): ... this.  Return void.  Move "first fork" special
3242         case from here, to ...
3243         (checkpoint_command): ... here.
3244         * linux-linux.h (add_fork): Return void.
3245
3246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3247
3248         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3249
3250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3251             Chris January  <chris.january@arm.com>
3252             David Lecomber  <david.lecomber@arm.com>
3253
3254         * f-exp.y: New token, UNOP_INTRINSIC.
3255         (exp): New pattern using UNOP_INTRINSIC token.
3256         (f77_keywords): Add 'abs' keyword.
3257         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3258         (value_from_host_double): New function.
3259         (evaluate_subexp_f): Support UNOP_ABS.
3260
3261 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3264         types.
3265
3266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3267
3268         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3269         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3270         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3271
3272 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3273
3274         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3275
3276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3277             Chris January  <chris.january@arm.com>
3278
3279         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3280         * f-exp.y: Define 'KIND' token.
3281         (exp): New pattern for KIND expressions.
3282         (ptype): Handle types with a kind extension.
3283         (direct_abs_decl): Extend to spot kind extensions.
3284         (f77_keywords): Add 'kind' to the list.
3285         (push_kind_type): New function.
3286         (convert_to_kind_type): New function.
3287         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3288         * parse.c (operator_length_standard): Likewise.
3289         * parser-defs.h (enum type_pieces): Add tp_kind.
3290         * std-operator.def: Add UNOP_KIND.
3291
3292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * f-exp.y (f_parse): Set yydebug.
3295
3296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3297
3298         * f-lang.c (evaluate_subexp_f): New function.
3299         (exp_descriptor_f): New global.
3300         (f_language_defn): Use exp_descriptor_f instead of
3301         exp_descriptor_standard.
3302
3303 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3304
3305         * f-exp.y (struct token): Add comments.
3306         (dot_ops): Remove uppercase versions and the end marker.
3307         (f77_keywords): Likewise.
3308         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3309         entries in the dot_ops array are case insensitive, and use
3310         strncasecmp to compare strings.  Also some whitespace cleanup in
3311         this area.  Similar for the f77_keywords array, except entries in
3312         this list might be case sensitive.
3313
3314 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3315
3316         * f-exp.y (struct f77_boolean_val): Add comments.
3317         (boolean_values): Remove uppercase versions, and end marker.
3318         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3319         and use strncasecmp to achieve case insensitivity.  Additionally,
3320         perform whitespace cleanup around this code.
3321
3322 2019-03-06  Tom Tromey  <tromey@adacore.com>
3323
3324         * remote-sim.c (gdbsim_target_open): Use result of
3325         gdb_argv::release.
3326
3327 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3328         Dirk Schubert  <dirk.schubert@arm.com>
3329         Chris January  <chris.january@arm.com>
3330
3331         * eval.c (evaluate_subexp_standard): Call Fortran argument
3332         wrapping logic.
3333         * f-lang.c (struct value): A value which can be passed into a
3334         Fortran function call.
3335         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3336         where appropriate.
3337         (struct type): Value ready for a Fortran function call.
3338         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3339         is needed.
3340         * f-lang.h (fortran_argument_convert): Declaration.
3341         (fortran_preserve_arg_pointer): Declaration.
3342         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3343
3344 2019-03-05  Tom Tromey  <tromey@adacore.com>
3345
3346         * python/py-prettyprint.c (print_string_repr): Remove #if.
3347         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3348
3349 2019-03-05  Tom Tromey  <tromey@adacore.com>
3350
3351         * target.c (the_dummy_target): Move later.  Change type to
3352         "dummy_target".
3353         (initialize_targets): Don't initialize the_dummy_target.
3354
3355 2019-03-05  Tom Tromey  <tromey@adacore.com>
3356
3357         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3358         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3359
3360 2019-03-05  Tom Tromey  <tromey@adacore.com>
3361
3362         * windows-nat.c (windows_nat_target::attach)
3363         (windows_nat_target::detach): Don't call gdb_flush.
3364         * valprint.c (generic_val_print, val_print, val_print_string):
3365         Don't call gdb_flush.
3366         * utils.c (defaulted_query): Don't call gdb_flush.
3367         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3368         * target.c (target_announce_detach): Don't call gdb_flush.
3369         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3370         * remote.c (extended_remote_target::attach): Don't call
3371         gdb_flush.
3372         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3373         * printcmd.c (do_examine): Don't call gdb_flush.
3374         (info_display_command): Don't call gdb_flush.
3375         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3376         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3377         * memattr.c (info_mem_command): Don't call gdb_flush.
3378         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3379         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3380         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3381         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3382         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3383         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3384         (gnu_nat_target::detach): Don't call gdb_flush.
3385         * f-valprint.c (f_val_print): Don't call gdb_flush.
3386         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3387         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3388         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3389         gdb_flush.
3390         * c-valprint.c (c_val_print): Don't call gdb_flush.
3391         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3392
3393 2019-03-05  Tom Tromey  <tromey@adacore.com>
3394
3395         * varobj.c (update_dynamic_varobj_children): Update.
3396         (install_default_visualizer): Use reset, not release.
3397         * value.c (set_internalvar): Update.
3398         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3399         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3400         ATTRIBUTE_UNUSED_RESULT.
3401
3402 2019-03-05  Tom Tromey  <tromey@adacore.com>
3403
3404         * remote.c (class scoped_remote_fd) <release>: Add
3405         ATTRIBUTE_UNUSED_RESULT.
3406
3407 2019-03-05  Tom Tromey  <tromey@adacore.com>
3408
3409         * macroexp.c (struct macro_buffer) <release>: Add
3410         ATTRIBUTE_UNUSED_RESULT.
3411
3412 2019-03-05  Tom Tromey  <tromey@adacore.com>
3413
3414         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3415         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3416         ATTRIBUTE_UNUSED_RESULT.
3417
3418 2019-03-05  Tom Tromey  <tromey@adacore.com>
3419
3420         * common/scoped_fd.h (class scoped_fd) <release>: Add
3421         ATTRIBUTE_UNUSED_RESULT.
3422
3423 2019-03-05  Tom Tromey  <tromey@adacore.com>
3424
3425         * parser-defs.h (struct parser_state) <release>: Add
3426         ATTRIBUTE_UNUSED_RESULT.
3427
3428 2019-03-05  Tom Tromey  <tromey@adacore.com>
3429
3430         * utils.h (class gdb_argv) <release>: Add
3431         ATTRIBUTE_UNUSED_RESULT.
3432         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3433
3434 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3435
3436         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3437         for-loop range, to avoid compiler warnings.
3438
3439         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3440         avoid compiler warnings about unused variables.
3441
3442         * NEWS: Mention end of support for native debugging on MS-Windows
3443         before XP.
3444
3445         PR gdb/24292
3446         * common/netstuff.c:
3447         * gdbserver/gdbreplay.c
3448         * gdbserver/remote-utils.c:
3449         * ser-tcp.c:
3450         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3451         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3452         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3453         'getaddrinfo' and 'freeaddrinfo' were not available before
3454         Windows XP, and mingw.org's MinGW headers by default define
3455         _WIN32_WINNT to 0x500.
3456
3457 2019-03-01  Gary Benson <gbenson@redhat.com>
3458
3459         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3460
3461 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3462             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3463
3464         PR gdb/8527
3465         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3466         set_sigint_trap, clear_sigint_trap.
3467
3468 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3469
3470         * target.c (target_detach): Clear the regcache and the
3471         frame cache.
3472
3473 2019-02-27  Pedro Alves  <palves@redhat.com>
3474
3475         * utils.c (set_screen_size): When we cap the height/width sizes,
3476         tweak the corresponding command variable to show "unlimited":
3477
3478 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3479             Pedro Alves  <palves@redhat.com>
3480
3481         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3482         before calling rl_set_screen_size.
3483
3484 2019-02-27  Tom Tromey  <tromey@adacore.com>
3485
3486         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3487         define.
3488         * python/py-value.c: Remove Python 2.4 workaround.
3489         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3490         workaround.
3491         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3492         Python 2.4 workaround.
3493         * python/python-internal.h: Remove Python 2.4 comment.
3494         (Py_ssize_t): Don't define.
3495         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3496         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3497         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3498         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3499         * python/python.c (do_start_initialization): Remove Python 2.4
3500         workaround.
3501         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3502         (print_children): Remove Python 2.4 workaround.
3503         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3504         workaround.
3505         (CHARBUFFERPROC_NAME): Remove.
3506         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3507         Python 2.4 workaround.
3508
3509 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3510
3511         * NEWS: Note minimum Python version.
3512
3513 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3514
3515         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3516         code from these functions.  Remove corresponding ifdefs.  Use
3517         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3518         Remove gotos and target of gotos.
3519         (infpy_search_memory): Likewise.
3520
3521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3522
3523         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3524         (hppa_gdbarch_init): Don't register deleted functions with
3525         gdbarch.
3526
3527 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3528
3529         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3530         (h8300_unwind_sp): Delete.
3531         (h8300_dummy_id): Delete.
3532         (h8300_gdbarch_init): Don't register deleted functions with
3533         gdbarch.
3534
3535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3538         (ft32_unwind_pc): Delete.
3539         (ft32_unwind_sp): Delete.
3540         (ft32_gdbarch_init): Don't register deleted functions with
3541         gdbarch.
3542
3543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3544
3545         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3546         (frv_unwind_pc): Delete.
3547         (frv_unwind_sp): Delete.
3548         (frv_gdbarch_init): Don't register deleted functions with
3549         gdbarch.
3550
3551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3552
3553         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3554         (riscv_unwind_pc): Delete.
3555         (riscv_unwind_sp): Delete.
3556         (riscv_gdbarch_init): Don't register deleted functions with
3557         gdbarch.
3558
3559 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3562         (csky_unwind_pc): Delete.
3563         (csky_unwind_sp): Delete.
3564         (csky_gdbarch_init): Don't register deleted functions with
3565         gdbarch.
3566
3567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3568
3569         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3570         (cris_unwind_pc): Delete.
3571         (cris_unwind_sp): Delete.
3572         (cris_gdbarch_init): Don't register deleted functions with
3573         gdbarch.
3574
3575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3576
3577         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3578         (bfin_unwind_pc): Delete.
3579         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3580
3581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3582
3583         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3584         (arm_unwind_pc): Delete.
3585         (arm_unwind_sp): Delete.
3586         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3587
3588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3589
3590         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3591         (arc_unwind_pc): Delete.
3592         (arc_unwind_sp): Delete.
3593         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3594
3595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3596
3597         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3598         (alpha_unwind_pc): Delete.
3599         (alpha_gdbarch_init): Don't register deleted functions with
3600         gdbarch.
3601
3602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3605         (aarch64_unwind_pc): Delete.
3606         (aarch64_unwind_sp): Delete.
3607         (aarch64_gdbarch_init): Don't register deleted functions with
3608         gdbarch.
3609
3610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3611
3612         * gdbtypes.c (type_align): Don't consider static members when
3613         computing structure alignment.
3614
3615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3616
3617         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3618         return 0 for other types.
3619         * arch-utils.c (default_type_align): Always return 0.
3620         * gdbarch.h: Regenerate.
3621         * gdbarch.sh (type_align): Extend comment.
3622         * gdbtypes.c (type_align): Add additional comments, always call
3623         gdbarch_type_align before applying the default rules.
3624         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3625         generic code will then apply a suitable default.
3626         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3627         types, return 0 for other types.
3628
3629 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3630
3631         * NEWS: Create a new section for the next release branch.
3632         Rename the section of the current branch, now that it has
3633         been cut.
3634
3635 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3636
3637         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3638         * version.in: Bump version to 8.3.50.DATE-git.
3639
3640 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3641
3642         * aix-thread.c (ptid_cmp): Remove unused variable.
3643         (get_signaled_thread): Likewise.
3644         (store_regs_user_thread): Likewise.
3645         (store_regs_kernel_thread): Likewise.
3646         (fetch_regs_kernel_thread): Remove shadowed variable.
3647
3648 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3649
3650         * features/riscv/32bit-cpu.xml: Add register numbers.
3651         * features/riscv/32bit-fpu.c: Regenerate.
3652         * features/riscv/32bit-fpu.xml: Add register numbers.
3653         * features/riscv/64bit-cpu.xml: Add register numbers.
3654         * features/riscv/64bit-fpu.c: Regenerate.
3655         * features/riscv/64bit-fpu.xml: Add register numbers.
3656
3657 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3658
3659         * NEWS: Mention two argument form of gdb.Value constructor.
3660         * python/py-value.c (convert_buffer_and_type_to_value): New
3661         function.
3662         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3663         Add support for handling an optional second argument.  Call
3664         convert_buffer_and_type_to_value as appropriate.
3665         * python/python-internal.h (Py_buffer_deleter): New struct.
3666         (Py_buffer_up): New typedef.
3667
3668 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3669
3670         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3671         instead of releasing ownership.
3672
3673 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3674
3675         * dwarf2read.c (open_and_init_dwp_file): Call
3676         elf_numsections instead of bfd_count_sections to initialize
3677         dwp_file->num_sections.
3678
3679 2019-02-25  Tom Tromey  <tromey@adacore.com>
3680
3681         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3682
3683 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3684
3685         * gcore.in: Add '--readnever' option when invoking GDB.
3686
3687 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3688
3689         * MAINTAINERS: Update my email address.
3690
3691 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3692
3693         * build-id.c (build_id_to_debug_bfd_1): New function.
3694         (build_id_to_debug_bfd): Look for separate debug file in
3695         sysroot.
3696
3697 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3698
3699         * gdbarch.sh: Update the copyright year range that is placed into
3700         generated files.
3701
3702 2019-02-22  Keith Seitz  <keiths@redhat.com>
3703
3704         PR symtab/23853
3705         * linespec.c (create_sals_line_offset): Search for the default
3706         symtab's filename instead of its fullname.
3707
3708 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3709
3710         * NEWS: Update style defaults.
3711
3712 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3713
3714         * main.c (captured_main_1): Disable styling in batch mode.
3715
3716 2019-02-20  Tom Tromey  <tom@tromey.com>
3717
3718         * symtab.c (symtab_symbol_info): Fix typos.
3719
3720 2019-02-20  Tom Tromey  <tromey@adacore.com>
3721
3722         * findcmd.c (_initialize_mem_search): Use upper case for
3723         metasyntactic variables.
3724
3725 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3726
3727         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3728         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3729
3730 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3731
3732         * top.h (source_file_name): Change to std::string.
3733         * top.c (source_file_name): Likewise.
3734         (command_line_input): Adjust.
3735         * cli/cli-script.c (script_from_file): Adjust.
3736
3737 2019-02-19  Tom Tromey  <tromey@adacore.com>
3738
3739         * ravenscar-thread.c
3740         (ravenscar_thread_target::update_thread_list): Don't call
3741         ada_build_task_list.
3742         * ada-lang.h (ada_build_task_list): Don't declare.
3743         * ada-tasks.c (struct ada_tasks_inferior_data)
3744         <task_list_valid_p>: Now bool.
3745         (read_known_tasks, ada_task_list_changed)
3746         (ada_tasks_invalidate_inferior_data): Update.
3747         (read_known_tasks_array): Return bool.
3748         (read_known_tasks_list): Likewise.
3749         (read_known_tasks): Return void.
3750         (ada_build_task_list): Now static.
3751
3752 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3755         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3756
3757 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3758
3759         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3760         variant for ada_tasks_pspace_data_handle and
3761         ada_tasks_inferior_data_handle.
3762         (ada_tasks_pspace_data_cleanup): New function.
3763         (ada_tasks_inferior_data_cleanup): New function.
3764
3765 2019-02-17  Tom Tromey  <tom@tromey.com>
3766
3767         * macrotab.h (macro_source_fullname): Return a std::string.
3768         * macrotab.c (macro_include, check_for_redefinition)
3769         (macro_undef, macro_lookup_definition, foreach_macro)
3770         (foreach_macro_in_scope): Update.
3771         (macro_source_fullname): Return a std::string.
3772         * macrocmd.c (show_pp_source_pos): Update.
3773
3774 2019-02-17  Tom Tromey  <tom@tromey.com>
3775
3776         * macrocmd.c (show_pp_source_pos): Style the file names.
3777
3778 2019-02-17  Tom Tromey  <tom@tromey.com>
3779
3780         PR tui/24197:
3781         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3782
3783 2019-02-17  Tom Tromey  <tom@tromey.com>
3784
3785         * ada-lang.c (user_select_syms): Use filtered printing.
3786         * utils.c (wrap_style): New global.
3787         (desired_style): Remove.
3788         (emit_style_escape): Add stream parameter.
3789         (set_output_style, reset_terminal_style, prompt_for_continue):
3790         Update.
3791         (flush_wrap_buffer): Only flush gdb_stdout.
3792         (wrap_here): Set wrap_style.
3793         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3794         treat escape sequences as a character.  Change when wrap buffer is
3795         flushed.
3796         (fputs_styled): Do not set the output style when the default is
3797         requested.
3798         * ui-style.h (struct ui_file_style) <is_default>: New method.
3799         * source.c (print_source_lines_base): Emit escape sequences in one
3800         piece.
3801
3802 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3803
3804         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3805         integers and enumeration types.
3806
3807 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3808
3809         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3810         instead of lookup_symbol_in_language
3811         (do_exact_match): New function.
3812         (ada_get_symbol_name_matcher): Return do_exact_match when
3813         doing a verbatim match.
3814
3815 2019-02-15  Tom Tromey  <tromey@adacore.com>
3816
3817         * ravenscar-thread.c (ravenscar_thread_target::resume)
3818         (ravenscar_thread_target::wait): Special case wildcard requests.
3819
3820 2019-02-15  Tom Tromey  <tromey@adacore.com>
3821
3822         * ravenscar-thread.c (base_ptid): Remove.
3823         (struct ravenscar_thread_target) <close>: New method.
3824         <m_base_ptid>: New member.
3825         <update_inferior_ptid, active_task, task_is_currently_active,
3826         runtime_initialized>: Declare methods.
3827         <ravenscar_thread_target>: Add constructor.
3828         (ravenscar_thread_target::task_is_currently_active)
3829         (ravenscar_thread_target::update_inferior_ptid)
3830         (ravenscar_runtime_initialized): Rename.  Now methods.
3831         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3832         (ravenscar_thread_target::update_thread_list): Update.
3833         (ravenscar_thread_target::active_task): Now method.
3834         (ravenscar_thread_target::store_registers)
3835         (ravenscar_thread_target::prepare_to_store)
3836         (ravenscar_thread_target::prepare_to_store)
3837         (ravenscar_thread_target::mourn_inferior): Update.
3838         (ravenscar_inferior_created): Use "new" to create target.
3839         (ravenscar_thread_target::get_ada_task_ptid): Update.
3840         (_initialize_ravenscar): Don't initialize base_ptid.
3841         (ravenscar_ops): Remove global.
3842
3843 2019-02-15  Tom Tromey  <tromey@adacore.com>
3844
3845         * target.h (push_target): Declare new overload.
3846         * target.c (push_target): New overload, taking an rvalue reference.
3847         * remote.c (remote_target::open_1): Use push_target overload.
3848         * corelow.c (core_target_open): Use push_target overload.
3849
3850 2019-02-15  Tom Tromey  <tromey@adacore.com>
3851
3852         * ravenscar-thread.c (is_ravenscar_task)
3853         (ravenscar_task_is_currently_active): Return bool.
3854         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3855         (_initialize_ravenscar): Remove "(void)".
3856         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3857         Return bool.
3858
3859 2019-02-15  Tom Tromey  <tromey@adacore.com>
3860
3861         * ravenscar-thread.c (ravenscar_runtime_initializer)
3862         (has_ravenscar_runtime, get_running_thread_id)
3863         (ravenscar_thread_target::resume): Fix indentation.
3864
3865 2019-02-15  Tom Tromey  <tromey@adacore.com>
3866
3867         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3868         from ravenscar_arch_ops.
3869         (sparc_ravenscar_ops::fetch_registers)
3870         (sparc_ravenscar_ops::store_registers): Now methods.
3871         (sparc_ravenscar_prepare_to_store): Remove.
3872         (sparc_ravenscar_ops): Redefine.
3873         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3874         methods and destructor.  Remove members.
3875         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3876         (ravenscar_thread_target::store_registers)
3877         (ravenscar_thread_target::prepare_to_store): Update.
3878         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3879         Remove.
3880         (struct ppc_ravenscar_powerpc_ops): Derive from
3881         ravenscar_arch_ops.
3882         (ppc_ravenscar_powerpc_ops::fetch_registers)
3883         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3884         (ppc_ravenscar_powerpc_ops): Redefine.
3885         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3886         (ppc_ravenscar_e500_ops::fetch_registers)
3887         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3888         (ppc_ravenscar_e500_ops): Redefine.
3889         * aarch64-ravenscar-thread.c
3890         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3891         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3892         (aarch64_ravenscar_fetch_registers)
3893         (aarch64_ravenscar_store_registers): Now methods.
3894         (aarch64_ravenscar_ops): Redefine.
3895
3896 2019-02-15  Tom Tromey  <tromey@adacore.com>
3897
3898         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3899         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3900         (ravenscar_thread_target::stopped_by_watchpoint)
3901         (ravenscar_thread_target::stopped_data_address)
3902         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3903
3904 2019-02-15  Tom Tromey  <tromey@adacore.com>
3905
3906         * ravenscar-thread.c: Fix some typos.
3907
3908 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3909             Tom Tromey  <tromey@adacore.com>
3910
3911         * ada-lang.c (ada_exception_sal): Change addr_string to a
3912         std::string.
3913         (create_ada_exception_catchpoint): Update.
3914
3915 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3916             Tom Tromey  <tromey@adacore.com>
3917
3918         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3919         (bp_location_ops): Remove.
3920         (base_breakpoint_allocate_location): Update.
3921         (free_bp_location): Update.
3922         * ada-lang.c (class ada_catchpoint_location)
3923         <ada_catchpoint_location>: Remove ops parameter.
3924         (ada_catchpoint_location_dtor): Remove.
3925         (ada_catchpoint_location_ops): Remove.
3926         (allocate_location_exception): Update.
3927         * breakpoint.h (struct bp_location_ops): Remove.
3928         (class bp_location) <bp_location>: Remove bp_location_ops
3929         parameter.
3930         <~bp_location>: Add destructor.
3931         <ops>: Remove.
3932
3933 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3934             Pedro Alves  <palves@redhat.com>
3935
3936         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3937         'PATH_MAX'.
3938
3939 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3940             Samuel Thibault  <samuel.thibault@gnu.org>
3941             Thomas Schwinge  <thomas@codesourcery.com>
3942
3943         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3944         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3945
3946 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3947
3948         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3949         (check_empty): Use "const char *".
3950
3951         * gnu-nat.c (gnu_nat_target::detach): Instead of
3952         'detach_inferior (pid)' call
3953         'detach_inferior (find_inferior_pid (pid))'.
3954
3955         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3956         'nat/fork-inferior.o'.
3957         * gnu-nat.c: #include "nat/fork-inferior.h".
3958
3959         * gnu-nat.c (gnu_nat_target::detach): Instead of
3960         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3961         * gnu-nat.h: #include "inf-child.h".
3962         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3963         'i386_gnu_nat_target::fetch_registers'.
3964         (gnu_store_registers): Rename/move to
3965         'i386_gnu_nat_target::store_registers'.
3966
3967         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3968         * gnu-nat.h (mach_thread_info): New function.
3969         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3970
3971         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3972
3973 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3974
3975         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3976
3977 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3978
3979         * windows-nat.c (windows_add_thread): Add new parameter
3980         "main_thread_p" with default value set to false.  Update
3981         function documentation as well as all callers.
3982         (windows_delete_thread): Likewise.
3983         (fake_create_process): Update call to windows_add_thread.
3984         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3985         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3986         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3987         call to windows_delete_thread.
3988
3989 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3990
3991         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3992
3993 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3994
3995         * symfile.c (find_separate_debug_file): Use canonical path of
3996         sysroot with child_path instead of gdb_sysroot if it is valid.
3997
3998 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3999
4000         * symfile.c (find_separate_debug_file): Use child_path to
4001         determine if an object file is under a sysroot.
4002
4003 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4004
4005         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4006         unittests/child-path-selftests.c.
4007         * common/pathstuff.c (child_path): New function.
4008         * common/pathstuff.h (child_path): New prototype.
4009         * unittests/child-path-selftests.c: New file.
4010
4011 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4012
4013         * symfile.c (find_separate_debug_file): Look for separate debug
4014         files in debug directories under the sysroot.
4015
4016 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4017
4018         * symtab.h (struct minimal_symbol data_p): New const method.
4019         (struct minimal_symbol text_p): Likewise.
4020         * symtab.c (output_source_filename): Use file name style
4021         to print file name.
4022         (print_symbol_info): Likewise.
4023         (print_msymbol_info): Use address style to print addresses.
4024         Use function name style to print executable text symbols.
4025         (expand_symtab_containing_pc): Use data_p.
4026         (find_pc_sect_compunit_symtab): Likewise.
4027
4028 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4029
4030         * breakpoint.c (describe_other_breakpoints): Use address style
4031         to print addresses.
4032         (say_where): Likewise.
4033
4034 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4035
4036         * ada-typeprint.c (print_func_type): Print function name
4037         style to print function name.
4038         * c-typeprint.c (c_print_type_1): Likewise.
4039
4040 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4041
4042         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4043         for execve.
4044
4045 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4046
4047         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4048         type_stack.
4049
4050 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4051
4052         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4053         TYPE_CODE_REF types.
4054
4055 2019-02-08  Jim Wilson  <jimw@sifive.com>
4056
4057         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4058         (riscv_linux_fregset): New.
4059         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4060
4061 2019-02-07  Tom Tromey  <tom@tromey.com>
4062
4063         * thread.c (thread_cancel_execution_command): Update.
4064         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4065         methods.
4066         (struct thread_fsm_ops): Remove.
4067         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4068         (thread_fsm_should_stop, thread_fsm_return_value)
4069         (thread_fsm_set_finished, thread_fsm_finished_p)
4070         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4071         Don't declare.
4072         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4073         * infrun.c (clear_proceed_status_thread)
4074         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4075         (print_stop_event): Update.
4076         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4077         Add constructor.
4078         (step_command_fsm_ops): Remove.
4079         (new_step_command_fsm): Remove.
4080         (step_1): Update.
4081         (step_command_fsm::should_stop): Rename from
4082         step_command_fsm_should_stop.
4083         (step_command_fsm::clean_up): Rename from
4084         step_command_fsm_clean_up.
4085         (step_command_fsm::do_async_reply_reason): Rename from
4086         step_command_fsm_async_reply_reason.
4087         (struct until_next_fsm): Inherit from thread_fsm.  Add
4088         constructor.
4089         (until_next_fsm_ops): Remove.
4090         (new_until_next_fsm): Remove.
4091         (until_next_fsm::should_stop): Rename from
4092         until_next_fsm_should_stop.
4093         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4094         (until_next_fsm::do_async_reply_reason): Rename from
4095         until_next_fsm_async_reply_reason.
4096         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4097         constructor.  Change type of breakpoint.
4098         (finish_command_fsm_ops): Remove.
4099         (new_finish_command_fsm): Remove.
4100         (finish_command_fsm::should_stop): Rename from
4101         finish_command_fsm_should_stop.
4102         (finish_command_fsm::clean_up): Rename from
4103         finish_command_fsm_clean_up.
4104         (finish_command_fsm::return_value): Rename from
4105         finish_command_fsm_return_value.
4106         (finish_command_fsm::do_async_reply_reason): Rename from
4107         finish_command_fsm_async_reply_reason.
4108         (finish_command): Update.
4109         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4110         Add constructor.
4111         (call_thread_fsm_ops): Remove.
4112         (call_thread_fsm::call_thread_fsm): Rename from
4113         new_call_thread_fsm.
4114         (call_thread_fsm::should_stop): Rename from
4115         call_thread_fsm_should_stop.
4116         (call_thread_fsm::should_notify_stop): Rename from
4117         call_thread_fsm_should_notify_stop.
4118         (run_inferior_call, call_function_by_hand_dummy): Update.
4119         * cli/cli-interp.c (should_print_stop_to_console): Update.
4120         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4121         Add constructor.  Change type of location_breakpoint,
4122         caller_breakpoint.
4123         (until_break_fsm_ops): Remove.
4124         (new_until_break_fsm): Remove.
4125         (until_break_fsm::should_stop): Rename from
4126         until_break_fsm_should_stop.
4127         (until_break_fsm::clean_up): Rename from
4128         until_break_fsm_clean_up.
4129         (until_break_fsm::do_async_reply_reason): Rename from
4130         until_break_fsm_async_reply_reason.
4131         (until_break_command): Update.
4132         * thread-fsm.c: Remove.
4133         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4134
4135 2019-02-07  Tom Tromey  <tom@tromey.com>
4136
4137         * yy-remap.h: Add include guard.
4138         * xtensa-tdep.h: Add include guard.
4139         * xcoffread.h: Rename include guard.
4140         * varobj-iter.h: Add include guard.
4141         * tui/tui.h: Rename include guard.
4142         * tui/tui-winsource.h: Rename include guard.
4143         * tui/tui-wingeneral.h: Rename include guard.
4144         * tui/tui-windata.h: Rename include guard.
4145         * tui/tui-win.h: Rename include guard.
4146         * tui/tui-stack.h: Rename include guard.
4147         * tui/tui-source.h: Rename include guard.
4148         * tui/tui-regs.h: Rename include guard.
4149         * tui/tui-out.h: Rename include guard.
4150         * tui/tui-layout.h: Rename include guard.
4151         * tui/tui-io.h: Rename include guard.
4152         * tui/tui-hooks.h: Rename include guard.
4153         * tui/tui-file.h: Rename include guard.
4154         * tui/tui-disasm.h: Rename include guard.
4155         * tui/tui-data.h: Rename include guard.
4156         * tui/tui-command.h: Rename include guard.
4157         * tic6x-tdep.h: Add include guard.
4158         * target/waitstatus.h: Rename include guard.
4159         * target/wait.h: Rename include guard.
4160         * target/target.h: Rename include guard.
4161         * target/resume.h: Rename include guard.
4162         * target-float.h: Rename include guard.
4163         * stabsread.h: Add include guard.
4164         * rs6000-tdep.h: Add include guard.
4165         * riscv-fbsd-tdep.h: Add include guard.
4166         * regformats/regdef.h: Rename include guard.
4167         * record.h: Rename include guard.
4168         * python/python.h: Rename include guard.
4169         * python/python-internal.h: Rename include guard.
4170         * python/py-stopevent.h: Rename include guard.
4171         * python/py-ref.h: Rename include guard.
4172         * python/py-record.h: Rename include guard.
4173         * python/py-record-full.h: Rename include guard.
4174         * python/py-record-btrace.h: Rename include guard.
4175         * python/py-instruction.h: Rename include guard.
4176         * python/py-events.h: Rename include guard.
4177         * python/py-event.h: Rename include guard.
4178         * procfs.h: Add include guard.
4179         * proc-utils.h: Add include guard.
4180         * p-lang.h: Add include guard.
4181         * or1k-tdep.h: Rename include guard.
4182         * observable.h: Rename include guard.
4183         * nto-tdep.h: Rename include guard.
4184         * nat/x86-linux.h: Rename include guard.
4185         * nat/x86-linux-dregs.h: Rename include guard.
4186         * nat/x86-gcc-cpuid.h: Add include guard.
4187         * nat/x86-dregs.h: Rename include guard.
4188         * nat/x86-cpuid.h: Rename include guard.
4189         * nat/ppc-linux.h: Rename include guard.
4190         * nat/mips-linux-watch.h: Rename include guard.
4191         * nat/linux-waitpid.h: Rename include guard.
4192         * nat/linux-ptrace.h: Rename include guard.
4193         * nat/linux-procfs.h: Rename include guard.
4194         * nat/linux-osdata.h: Rename include guard.
4195         * nat/linux-nat.h: Rename include guard.
4196         * nat/linux-namespaces.h: Rename include guard.
4197         * nat/linux-btrace.h: Rename include guard.
4198         * nat/glibc_thread_db.h: Rename include guard.
4199         * nat/gdb_thread_db.h: Rename include guard.
4200         * nat/gdb_ptrace.h: Rename include guard.
4201         * nat/fork-inferior.h: Rename include guard.
4202         * nat/amd64-linux-siginfo.h: Rename include guard.
4203         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4204         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4205         * nat/aarch64-linux.h: Rename include guard.
4206         * nat/aarch64-linux-hw-point.h: Rename include guard.
4207         * mn10300-tdep.h: Add include guard.
4208         * mips-linux-tdep.h: Add include guard.
4209         * mi/mi-parse.h: Rename include guard.
4210         * mi/mi-out.h: Rename include guard.
4211         * mi/mi-main.h: Rename include guard.
4212         * mi/mi-interp.h: Rename include guard.
4213         * mi/mi-getopt.h: Rename include guard.
4214         * mi/mi-console.h: Rename include guard.
4215         * mi/mi-common.h: Rename include guard.
4216         * mi/mi-cmds.h: Rename include guard.
4217         * mi/mi-cmd-break.h: Rename include guard.
4218         * m2-lang.h: Add include guard.
4219         * location.h: Rename include guard.
4220         * linux-record.h: Rename include guard.
4221         * linux-nat.h: Add include guard.
4222         * linux-fork.h: Add include guard.
4223         * i386-darwin-tdep.h: Rename include guard.
4224         * hppa-linux-offsets.h: Add include guard.
4225         * guile/guile.h: Rename include guard.
4226         * guile/guile-internal.h: Rename include guard.
4227         * gnu-nat.h: Rename include guard.
4228         * gdb-stabs.h: Rename include guard.
4229         * frv-tdep.h: Add include guard.
4230         * f-lang.h: Add include guard.
4231         * event-loop.h: Add include guard.
4232         * darwin-nat.h: Rename include guard.
4233         * cp-abi.h: Rename include guard.
4234         * config/sparc/nm-sol2.h: Rename include guard.
4235         * config/nm-nto.h: Rename include guard.
4236         * config/nm-linux.h: Add include guard.
4237         * config/i386/nm-i386gnu.h: Rename include guard.
4238         * config/djgpp/nl_types.h: Rename include guard.
4239         * config/djgpp/langinfo.h: Rename include guard.
4240         * compile/gcc-cp-plugin.h: Add include guard.
4241         * compile/gcc-c-plugin.h: Add include guard.
4242         * compile/compile.h: Rename include guard.
4243         * compile/compile-object-run.h: Rename include guard.
4244         * compile/compile-object-load.h: Rename include guard.
4245         * compile/compile-internal.h: Rename include guard.
4246         * compile/compile-cplus.h: Rename include guard.
4247         * compile/compile-c.h: Rename include guard.
4248         * common/xml-utils.h: Rename include guard.
4249         * common/x86-xstate.h: Rename include guard.
4250         * common/version.h: Rename include guard.
4251         * common/vec.h: Rename include guard.
4252         * common/tdesc.h: Rename include guard.
4253         * common/selftest.h: Rename include guard.
4254         * common/scoped_restore.h: Rename include guard.
4255         * common/scoped_mmap.h: Rename include guard.
4256         * common/scoped_fd.h: Rename include guard.
4257         * common/safe-iterator.h: Rename include guard.
4258         * common/run-time-clock.h: Rename include guard.
4259         * common/refcounted-object.h: Rename include guard.
4260         * common/queue.h: Rename include guard.
4261         * common/ptid.h: Rename include guard.
4262         * common/print-utils.h: Rename include guard.
4263         * common/preprocessor.h: Rename include guard.
4264         * common/pathstuff.h: Rename include guard.
4265         * common/observable.h: Rename include guard.
4266         * common/netstuff.h: Rename include guard.
4267         * common/job-control.h: Rename include guard.
4268         * common/host-defs.h: Rename include guard.
4269         * common/gdb_wait.h: Rename include guard.
4270         * common/gdb_vecs.h: Rename include guard.
4271         * common/gdb_unlinker.h: Rename include guard.
4272         * common/gdb_unique_ptr.h: Rename include guard.
4273         * common/gdb_tilde_expand.h: Rename include guard.
4274         * common/gdb_sys_time.h: Rename include guard.
4275         * common/gdb_string_view.h: Rename include guard.
4276         * common/gdb_splay_tree.h: Rename include guard.
4277         * common/gdb_setjmp.h: Rename include guard.
4278         * common/gdb_ref_ptr.h: Rename include guard.
4279         * common/gdb_optional.h: Rename include guard.
4280         * common/gdb_locale.h: Rename include guard.
4281         * common/gdb_assert.h: Rename include guard.
4282         * common/filtered-iterator.h: Rename include guard.
4283         * common/filestuff.h: Rename include guard.
4284         * common/fileio.h: Rename include guard.
4285         * common/environ.h: Rename include guard.
4286         * common/common-utils.h: Rename include guard.
4287         * common/common-types.h: Rename include guard.
4288         * common/common-regcache.h: Rename include guard.
4289         * common/common-inferior.h: Rename include guard.
4290         * common/common-gdbthread.h: Rename include guard.
4291         * common/common-exceptions.h: Rename include guard.
4292         * common/common-defs.h: Rename include guard.
4293         * common/common-debug.h: Rename include guard.
4294         * common/cleanups.h: Rename include guard.
4295         * common/buffer.h: Rename include guard.
4296         * common/btrace-common.h: Rename include guard.
4297         * common/break-common.h: Rename include guard.
4298         * cli/cli-utils.h: Rename include guard.
4299         * cli/cli-style.h: Rename include guard.
4300         * cli/cli-setshow.h: Rename include guard.
4301         * cli/cli-script.h: Rename include guard.
4302         * cli/cli-interp.h: Rename include guard.
4303         * cli/cli-decode.h: Rename include guard.
4304         * cli/cli-cmds.h: Rename include guard.
4305         * charset-list.h: Add include guard.
4306         * buildsym-legacy.h: Rename include guard.
4307         * bfin-tdep.h: Add include guard.
4308         * ax.h: Rename include guard.
4309         * arm-linux-tdep.h: Add include guard.
4310         * arm-fbsd-tdep.h: Add include guard.
4311         * arch/xtensa.h: Rename include guard.
4312         * arch/tic6x.h: Add include guard.
4313         * arch/i386.h: Add include guard.
4314         * arch/arm.h: Rename include guard.
4315         * arch/arm-linux.h: Rename include guard.
4316         * arch/arm-get-next-pcs.h: Rename include guard.
4317         * arch/amd64.h: Add include guard.
4318         * arch/aarch64-insn.h: Rename include guard.
4319         * arch-utils.h: Rename include guard.
4320         * annotate.h: Add include guard.
4321         * amd64-darwin-tdep.h: Rename include guard.
4322         * aarch64-linux-tdep.h: Add include guard.
4323         * aarch64-fbsd-tdep.h: Add include guard.
4324         * aarch32-linux-nat.h: Add include guard.
4325
4326 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4327
4328         * macrotab.c (macro_define_internal): New function that
4329         factorizes macro_define_object_internal and macro_define_function
4330         code.
4331         (macro_define_object_internal): Use macro_define_internal.
4332         (macro_define_function): Likewise.
4333
4334 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4335
4336         * macrocmd.c (extract_identifier): Return
4337         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4338         callers.
4339
4340 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4341
4342         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4343
4344 2019-02-05  Tom Tromey  <tom@tromey.com>
4345
4346         * target.c (target_stack::unpush): Move assertion earlier.
4347
4348 2019-01-30  Tom Tromey  <tom@tromey.com>
4349
4350         PR python/23615:
4351         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4352         (gdbpy_parse_and_eval): Likewise.
4353         * python/python-internal.h (gdbpy_allow_threads): New class.
4354
4355 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4356
4357         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4358         (aarch64_fbsd_fpregmap): Move earlier.
4359         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4360         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4361         instead of individual calls to trad_frame_set_reg_addr.
4362         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4363         earlier.
4364         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4365         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4366         instead of individual calls to trad_frame_set_reg_addr.
4367
4368 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4369
4370         * CONTRIBUTE: Replace contribution list with wiki link.
4371
4372 2019-01-25  Tom Tromey  <tom@tromey.com>
4373
4374         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4375
4376 2019-01-25  Tom Tromey  <tom@tromey.com>
4377
4378         * xtensa-linux-nat.c: Fix common/ includes.
4379         * xml-support.h: Fix common/ includes.
4380         * xml-support.c: Fix common/ includes.
4381         * x86-linux-nat.c: Fix common/ includes.
4382         * windows-nat.c: Fix common/ includes.
4383         * varobj.h: Fix common/ includes.
4384         * varobj.c: Fix common/ includes.
4385         * value.c: Fix common/ includes.
4386         * valops.c: Fix common/ includes.
4387         * utils.c: Fix common/ includes.
4388         * unittests/xml-utils-selftests.c: Fix common/ includes.
4389         * unittests/utils-selftests.c: Fix common/ includes.
4390         * unittests/unpack-selftests.c: Fix common/ includes.
4391         * unittests/tracepoint-selftests.c: Fix common/ includes.
4392         * unittests/style-selftests.c: Fix common/ includes.
4393         * unittests/string_view-selftests.c: Fix common/ includes.
4394         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4395         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4396         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4397         * unittests/rsp-low-selftests.c: Fix common/ includes.
4398         * unittests/parse-connection-spec-selftests.c: Fix common/
4399         includes.
4400         * unittests/optional-selftests.c: Fix common/ includes.
4401         * unittests/offset-type-selftests.c: Fix common/ includes.
4402         * unittests/observable-selftests.c: Fix common/ includes.
4403         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4404         * unittests/memrange-selftests.c: Fix common/ includes.
4405         * unittests/memory-map-selftests.c: Fix common/ includes.
4406         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4407         * unittests/function-view-selftests.c: Fix common/ includes.
4408         * unittests/environ-selftests.c: Fix common/ includes.
4409         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4410         * unittests/common-utils-selftests.c: Fix common/ includes.
4411         * unittests/cli-utils-selftests.c: Fix common/ includes.
4412         * unittests/array-view-selftests.c: Fix common/ includes.
4413         * ui-file.c: Fix common/ includes.
4414         * tui/tui-io.c: Fix common/ includes.
4415         * tracepoint.h: Fix common/ includes.
4416         * tracepoint.c: Fix common/ includes.
4417         * tracefile-tfile.c: Fix common/ includes.
4418         * top.h: Fix common/ includes.
4419         * top.c: Fix common/ includes.
4420         * thread.c: Fix common/ includes.
4421         * target/waitstatus.h: Fix common/ includes.
4422         * target/waitstatus.c: Fix common/ includes.
4423         * target.h: Fix common/ includes.
4424         * target.c: Fix common/ includes.
4425         * target-memory.c: Fix common/ includes.
4426         * target-descriptions.c: Fix common/ includes.
4427         * symtab.h: Fix common/ includes.
4428         * symfile.c: Fix common/ includes.
4429         * stap-probe.c: Fix common/ includes.
4430         * spu-linux-nat.c: Fix common/ includes.
4431         * sparc-nat.c: Fix common/ includes.
4432         * source.c: Fix common/ includes.
4433         * solib.c: Fix common/ includes.
4434         * solib-target.c: Fix common/ includes.
4435         * ser-unix.c: Fix common/ includes.
4436         * ser-tcp.c: Fix common/ includes.
4437         * ser-pipe.c: Fix common/ includes.
4438         * ser-base.c: Fix common/ includes.
4439         * selftest-arch.c: Fix common/ includes.
4440         * s12z-tdep.c: Fix common/ includes.
4441         * rust-exp.y: Fix common/ includes.
4442         * rs6000-aix-tdep.c: Fix common/ includes.
4443         * riscv-tdep.c: Fix common/ includes.
4444         * remote.c: Fix common/ includes.
4445         * remote-notif.h: Fix common/ includes.
4446         * remote-fileio.h: Fix common/ includes.
4447         * remote-fileio.c: Fix common/ includes.
4448         * regcache.h: Fix common/ includes.
4449         * regcache.c: Fix common/ includes.
4450         * record-btrace.c: Fix common/ includes.
4451         * python/python.c: Fix common/ includes.
4452         * python/py-type.c: Fix common/ includes.
4453         * python/py-inferior.c: Fix common/ includes.
4454         * progspace.h: Fix common/ includes.
4455         * producer.c: Fix common/ includes.
4456         * procfs.c: Fix common/ includes.
4457         * proc-api.c: Fix common/ includes.
4458         * printcmd.c: Fix common/ includes.
4459         * ppc-linux-nat.c: Fix common/ includes.
4460         * parser-defs.h: Fix common/ includes.
4461         * osdata.c: Fix common/ includes.
4462         * obsd-nat.c: Fix common/ includes.
4463         * nat/x86-linux.c: Fix common/ includes.
4464         * nat/x86-linux-dregs.c: Fix common/ includes.
4465         * nat/x86-dregs.h: Fix common/ includes.
4466         * nat/x86-dregs.c: Fix common/ includes.
4467         * nat/ppc-linux.c: Fix common/ includes.
4468         * nat/mips-linux-watch.h: Fix common/ includes.
4469         * nat/mips-linux-watch.c: Fix common/ includes.
4470         * nat/linux-waitpid.c: Fix common/ includes.
4471         * nat/linux-ptrace.h: Fix common/ includes.
4472         * nat/linux-ptrace.c: Fix common/ includes.
4473         * nat/linux-procfs.c: Fix common/ includes.
4474         * nat/linux-personality.c: Fix common/ includes.
4475         * nat/linux-osdata.c: Fix common/ includes.
4476         * nat/linux-namespaces.c: Fix common/ includes.
4477         * nat/linux-btrace.h: Fix common/ includes.
4478         * nat/linux-btrace.c: Fix common/ includes.
4479         * nat/fork-inferior.c: Fix common/ includes.
4480         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4481         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4482         * nat/aarch64-linux.c: Fix common/ includes.
4483         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4484         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4485         * namespace.h: Fix common/ includes.
4486         * mips-linux-tdep.c: Fix common/ includes.
4487         * minsyms.c: Fix common/ includes.
4488         * mi/mi-parse.h: Fix common/ includes.
4489         * mi/mi-main.c: Fix common/ includes.
4490         * mi/mi-cmd-env.c: Fix common/ includes.
4491         * memrange.h: Fix common/ includes.
4492         * memattr.c: Fix common/ includes.
4493         * maint.h: Fix common/ includes.
4494         * maint.c: Fix common/ includes.
4495         * main.c: Fix common/ includes.
4496         * machoread.c: Fix common/ includes.
4497         * location.c: Fix common/ includes.
4498         * linux-thread-db.c: Fix common/ includes.
4499         * linux-nat.c: Fix common/ includes.
4500         * linux-fork.c: Fix common/ includes.
4501         * inline-frame.c: Fix common/ includes.
4502         * infrun.c: Fix common/ includes.
4503         * inflow.c: Fix common/ includes.
4504         * inferior.h: Fix common/ includes.
4505         * inferior.c: Fix common/ includes.
4506         * infcmd.c: Fix common/ includes.
4507         * inf-ptrace.c: Fix common/ includes.
4508         * inf-child.c: Fix common/ includes.
4509         * ia64-linux-nat.c: Fix common/ includes.
4510         * i387-tdep.c: Fix common/ includes.
4511         * i386-tdep.c: Fix common/ includes.
4512         * i386-linux-tdep.c: Fix common/ includes.
4513         * i386-linux-nat.c: Fix common/ includes.
4514         * i386-go32-tdep.c: Fix common/ includes.
4515         * i386-fbsd-tdep.c: Fix common/ includes.
4516         * i386-fbsd-nat.c: Fix common/ includes.
4517         * guile/scm-type.c: Fix common/ includes.
4518         * guile/guile.c: Fix common/ includes.
4519         * go32-nat.c: Fix common/ includes.
4520         * gnu-nat.c: Fix common/ includes.
4521         * gdbthread.h: Fix common/ includes.
4522         * gdbarch-selftests.c: Fix common/ includes.
4523         * gdb_usleep.c: Fix common/ includes.
4524         * gdb_select.h: Fix common/ includes.
4525         * gdb_bfd.c: Fix common/ includes.
4526         * gcore.c: Fix common/ includes.
4527         * fork-child.c: Fix common/ includes.
4528         * findvar.c: Fix common/ includes.
4529         * fbsd-nat.c: Fix common/ includes.
4530         * event-top.c: Fix common/ includes.
4531         * event-loop.c: Fix common/ includes.
4532         * dwarf2read.c: Fix common/ includes.
4533         * dwarf2loc.c: Fix common/ includes.
4534         * dwarf2-frame.c: Fix common/ includes.
4535         * dwarf-index-cache.c: Fix common/ includes.
4536         * dtrace-probe.c: Fix common/ includes.
4537         * disasm-selftests.c: Fix common/ includes.
4538         * defs.h: Fix common/ includes.
4539         * csky-tdep.c: Fix common/ includes.
4540         * cp-valprint.c: Fix common/ includes.
4541         * cp-support.h: Fix common/ includes.
4542         * cp-support.c: Fix common/ includes.
4543         * corelow.c: Fix common/ includes.
4544         * completer.h: Fix common/ includes.
4545         * completer.c: Fix common/ includes.
4546         * compile/compile.c: Fix common/ includes.
4547         * compile/compile-loc2c.c: Fix common/ includes.
4548         * compile/compile-cplus-types.c: Fix common/ includes.
4549         * compile/compile-cplus-symbols.c: Fix common/ includes.
4550         * command.h: Fix common/ includes.
4551         * cli/cli-dump.c: Fix common/ includes.
4552         * cli/cli-cmds.c: Fix common/ includes.
4553         * charset.c: Fix common/ includes.
4554         * build-id.c: Fix common/ includes.
4555         * btrace.h: Fix common/ includes.
4556         * btrace.c: Fix common/ includes.
4557         * breakpoint.h: Fix common/ includes.
4558         * breakpoint.c: Fix common/ includes.
4559         * ax.h:
4560         (enum agent_op): Fix common/ includes.
4561         * ax-general.c (struct aop_map): Fix common/ includes.
4562         * ax-gdb.c: Fix common/ includes.
4563         * auxv.c: Fix common/ includes.
4564         * auto-load.c: Fix common/ includes.
4565         * arm-tdep.c: Fix common/ includes.
4566         * arch/riscv.c: Fix common/ includes.
4567         * arch/ppc-linux-common.c: Fix common/ includes.
4568         * arch/i386.c: Fix common/ includes.
4569         * arch/arm.c: Fix common/ includes.
4570         * arch/arm-linux.c: Fix common/ includes.
4571         * arch/arm-get-next-pcs.c: Fix common/ includes.
4572         * arch/amd64.c: Fix common/ includes.
4573         * arch/aarch64.c: Fix common/ includes.
4574         * arch/aarch64-insn.c: Fix common/ includes.
4575         * arch-utils.c: Fix common/ includes.
4576         * amd64-windows-tdep.c: Fix common/ includes.
4577         * amd64-tdep.c: Fix common/ includes.
4578         * amd64-sol2-tdep.c: Fix common/ includes.
4579         * amd64-obsd-tdep.c: Fix common/ includes.
4580         * amd64-nbsd-tdep.c: Fix common/ includes.
4581         * amd64-linux-tdep.c: Fix common/ includes.
4582         * amd64-linux-nat.c: Fix common/ includes.
4583         * amd64-fbsd-tdep.c: Fix common/ includes.
4584         * amd64-fbsd-nat.c: Fix common/ includes.
4585         * amd64-dicos-tdep.c: Fix common/ includes.
4586         * amd64-darwin-tdep.c: Fix common/ includes.
4587         * agent.c: Fix common/ includes.
4588         * ada-lang.h: Fix common/ includes.
4589         * ada-lang.c: Fix common/ includes.
4590         * aarch64-tdep.c: Fix common/ includes.
4591
4592 2019-01-25  Tom Tromey  <tom@tromey.com>
4593
4594         * common/create-version.sh: Use common/version.h.
4595
4596 2019-01-24  Pedro Alves  <palves@redhat.com>
4597
4598         * infrun.c (signal_stop, signal_print, signal_program)
4599         (signal_catch, signal_pass): Now arrays instead of pointers.
4600         (update_signals_program_target, do_target_resume)
4601         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4602         * linux-nat.c (linux_nat_target::pass_signals)
4603         (linux_nat_target::create_inferior, linux_nat_target::attach):
4604         Adjust.
4605         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4606         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4607         * procfs.c (procfs_target::pass_signals): Adjust.
4608         * record-full.c (record_full_target::resume): Adjust.
4609         * remote.c (remote_target::pass_signals)
4610         (remote_target::program_signals): Adjust.
4611         * target-debug.h (target_debug_print_signals): Now takes a
4612         gdb::array_view as parameter.  Adjust.
4613         * target.h (target_ops) <pass_signals, program_signals>: Replace
4614         pointer and length parameters with gdb::array_view.
4615         (target_pass_signals, target_program_signals): Likewise.
4616         * target-delegates.c: Regenerate.
4617
4618 2019-01-24  Pedro Alves  <palves@redhat.com>
4619
4620         * common/forward-scope-exit.h
4621         (forward_scope_exit::forward_scope_exit): Pass arguments to
4622         m_bind_function directly, instead of creating a std::bind and
4623         copying that.
4624
4625 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4626
4627         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4628         for static members.
4629         (pass_in_v_vfp_candidate): Likewise.
4630
4631 2019-01-23  Tom Tromey  <tom@tromey.com>
4632             Pedro Alves  <palves@redhat.com>
4633
4634         * regcache.c (class regcache_invalidator): Remove.
4635         (regcache::raw_write): Use make_scope_exit.
4636
4637 2019-01-23  Tom Tromey  <tom@tromey.com>
4638
4639         * ui-out.h (class ui_out_emit_type): Update comment.
4640
4641 2019-01-23  Tom Tromey  <tom@tromey.com>
4642
4643         * infrun.c (fetch_inferior_event): Update comment.
4644
4645 2019-01-23  Tom Tromey  <tom@tromey.com>
4646             Pedro Alves  <palves@redhat.com>
4647
4648         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4649         parameter.
4650         (fetch_inferior_event): Use SCOPE_EXIT.
4651
4652
4653 2019-01-23  Tom Tromey  <tom@tromey.com>
4654             Pedro Alves  <palves@redhat.com>
4655
4656         * infrun.c (disable_thread_events): Delete.
4657         (stop_all_threads): Use SCOPE_EXIT.
4658
4659 2019-01-23  Tom Tromey  <tom@tromey.com>
4660             Pedro Alves  <palves@redhat.com>
4661
4662         * symfile.c: Include forward-scope-exit.h.
4663         (clear_symtab_users_cleanup): Replace forward declaration with
4664         a FORWARD_SCOPE_EXIT.
4665         (syms_from_objfile_1): Use the forward_scope_exit and
4666         gdb::optional instead of cleanup_function.
4667         (reread_symbols): Use the forward_scope_exit instead of
4668         cleanup_function.
4669         (clear_symtab_users_cleanup): Remove function.
4670
4671 2019-01-23  Tom Tromey  <tom@tromey.com>
4672             Pedro Alves  <palves@redhat.com>
4673
4674         * linux-nat.c: Include scope-exit.h.
4675         (cleanup_target_stop): Remove.
4676         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4677         SCOPE_EXIT.
4678
4679 2019-01-23  Tom Tromey  <tom@tromey.com>
4680             Pedro Alves  <palves@redhat.com>
4681
4682         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4683         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4684
4685 2019-01-23  Tom Tromey  <tom@tromey.com>
4686             Andrew Burgess  <andrew.burgess@embecosm.com>
4687             Pedro Alves  <palves@redhat.com>
4688
4689         * infrun.c (fetch_inferior_event): Use scope_exit.
4690         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4691         * top.c (execute_command): Use scope_exit.
4692         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4693         * utils.c (do_bpstat_clear_actions_cleanup)
4694         (make_bpstat_clear_actions_cleanup): Remove.
4695
4696 2019-01-23  Tom Tromey  <tom@tromey.com>
4697             Pedro Alves  <palves@redhat.com>
4698
4699         * infrun.c: Include "common/scope-exit.h"
4700         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4701         (wait_for_inferior): Use SCOPE_EXIT.
4702         (fetch_inferior_event): Use scope_exit.
4703
4704 2019-01-23  Tom Tromey  <tom@tromey.com>
4705             Pedro Alves  <palves@redhat.com>
4706
4707         * breakpoint.c (create_breakpoint): Remove cleanup.
4708
4709 2019-01-23  Tom Tromey  <tom@tromey.com>
4710             Andrew Burgess  <andrew.burgess@embecosm.com>
4711             Pedro Alves  <palves@redhat.com>
4712
4713 2019-01-23  Pedro Alves  <palves@redhat.com>
4714
4715         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4716
4717 2019-01-23  Pedro Alves  <palves@redhat.com>
4718             Andrew Burgess  <andrew.burgess@embecosm.com>
4719
4720         * gdbthread.h: Include "common/forward-scope-exit.h".
4721         (scoped_finish_thread_state): Redefine custom class in terms of
4722         forward_scope_exit.
4723
4724 2019-01-23  Pedro Alves  <palves@redhat.com>
4725             Andrew Burgess  <andrew.burgess@embecosm.com>
4726
4727         * common/forward-scope-exit.h: New file.
4728
4729 2019-01-23  Pedro Alves  <palves@redhat.com>
4730             Andrew Burgess  <andrew.burgess@embecosm.com>
4731             Tom Tromey  <tom@tromey.com>
4732
4733         * common/scope-exit.h: New file.
4734
4735 2019-01-23  Pedro Alves  <palves@redhat.com>
4736
4737         * common/preprocessor.h (ESC): Rename to ...
4738         (ESC_PARENS): ... this.
4739         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4740         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4741
4742 2019-01-23  Tom Tromey  <tom@tromey.com>
4743
4744         * language.h (class scoped_switch_to_sym_language_if_auto):
4745         Initialize m_lang in both cases.
4746
4747 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4748
4749         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4750         with XCNEW.
4751
4752 2019-01-22  Tom Tromey  <tom@tromey.com>
4753
4754         * corelow.c: Do not include sys/file.h.
4755
4756 2019-01-22  Tom Tromey  <tom@tromey.com>
4757
4758         * tui/tui-wingeneral.h: Include gdb_curses.h.
4759
4760 2019-01-22  Tom Tromey  <tom@tromey.com>
4761
4762         * source-cache.h (class source_cache) <get_source_lines,
4763         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4764
4765 2019-01-22  Tom Tromey  <tom@tromey.com>
4766
4767         * remote-fileio.h (struct remote_target): Declare.
4768
4769 2019-01-22  Tom Tromey  <tom@tromey.com>
4770
4771         * python/py-arch.c: Do not include py-ref.h.
4772         * python/py-bpevent.c: Do not include py-ref.h.
4773         * python/py-cmd.c: Do not include py-ref.h.
4774         * python/py-continueevent.c: Do not include py-ref.h.
4775         * python/py-event.h: Do not include py-ref.h.
4776         * python/py-evtregistry.c: Do not include py-ref.h.
4777         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4778         * python/py-frame.c: Do not include py-ref.h.
4779         * python/py-framefilter.c: Do not include py-ref.h.
4780         * python/py-function.c: Do not include py-ref.h.
4781         * python/py-infevents.c: Do not include py-ref.h.
4782         * python/py-linetable.c: Do not include py-ref.h.
4783         * python/py-objfile.c: Do not include py-ref.h.
4784         * python/py-param.c: Do not include py-ref.h.
4785         * python/py-prettyprint.c: Do not include py-ref.h.
4786         * python/py-progspace.c: Do not include py-ref.h.
4787         * python/py-symbol.c: Do not include py-ref.h.
4788         * python/py-symtab.c: Do not include py-ref.h.
4789         * python/py-type.c: Do not include py-ref.h.
4790         * python/py-unwind.c: Do not include py-ref.h.
4791         * python/py-utils.c: Do not include py-ref.h.
4792         * python/py-value.c: Do not include py-ref.h.
4793         * python/py-varobj.c: Do not include py-ref.h.
4794         * python/py-xmethods.c: Do not include py-ref.h.
4795         * python/python.c: Do not include py-ref.h.
4796         * varobj.c: Do not include py-ref.h.
4797
4798 2019-01-22  Tom Tromey  <tom@tromey.com>
4799
4800         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4801         keyword for bcache.
4802
4803 2019-01-22  Tom Tromey  <tom@tromey.com>
4804
4805         * compile/compile-cplus-types.c: Remove a comment by #include.
4806
4807 2019-01-22  Tom Tromey  <tom@tromey.com>
4808
4809         * compile/gcc-c-plugin.h: Include compile-internal.h.
4810
4811 2019-01-22  Tom Tromey  <tom@tromey.com>
4812
4813         * stabsread.c (EXTERN): Do not define.
4814         (symnum, next_symbol_text_func, processing_gcc_compilation)
4815         (within_function, global_sym_chain, global_stabs)
4816         (previous_stab_code, this_object_header_files)
4817         (n_this_object_header_files)
4818         (n_allocated_this_object_header_files): Define.
4819         * stabsread.h (EXTERN): Never define.  Use "extern".
4820
4821 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4822
4823         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4824         history_value.
4825
4826 2019-01-21  Tom Tromey  <tom@tromey.com>
4827
4828         * ui-out.c: Fix includes.
4829         * tui/tui-source.c: Fix includes.
4830         * target.c: Fix includes.
4831         * remote.c: Fix includes.
4832         * regcache.c: Fix includes.
4833         * python/py-block.c: Fix includes.
4834         * printcmd.c: Fix includes.
4835         * or1k-tdep.c: Fix includes.
4836         * mi/mi-main.c: Fix includes.
4837         * m32r-tdep.c: Fix includes.
4838         * csky-tdep.c: Fix includes.
4839         * compile/compile-cplus-types.c: Fix includes.
4840         * cli/cli-interp.c: Fix includes.
4841
4842 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4843
4844         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4845         for padding.
4846
4847 2019-01-16  Tom Tromey  <tom@tromey.com>
4848
4849         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4850         earlier.
4851         (struct objfile) <msymbols_range>: Move from top level.
4852         <msymbols>: New method.
4853         (class objfile_msymbols): Remove.
4854         * symtab.c (default_collect_symbol_completion_matches_break_on):
4855         Update.
4856         * symmisc.c (dump_msymbols): Update.
4857         * stabsread.c (scan_file_globals): Update.
4858         * objc-lang.c (info_selectors_command, info_classes_command)
4859         (find_methods): Update.
4860         * minsyms.c (find_solib_trampoline_target): Update.
4861         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4862         * coffread.c (coff_symfile_read): Update.
4863         * ada-lang.c (ada_lookup_simple_minsym)
4864         (ada_collect_symbol_completion_matches): Update.
4865
4866 2019-01-16  Tom Tromey  <tom@tromey.com>
4867
4868         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4869         type.  Remove no-argument constructor.
4870         <iterator::operator++>: Simplify.
4871         <begin>: Update.
4872         <end>: Use minimal_symbol_count.
4873
4874 2019-01-16  Tom Tromey  <tom@tromey.com>
4875
4876         * objfiles.h (struct objfile) <psymtabs>: New method.
4877         (class objfile_psymtabs): Remove.
4878         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4879         typedef.
4880         <range>: New method.
4881         (require_partial_symbols): Change return type.
4882         * psymtab.c (require_partial_symbols)
4883         (psym_expand_symtabs_matching): Update.
4884         * mdebugread.c (parse_partial_symbols): Update.
4885         * dbxread.c (dbx_end_psymtab): Update.
4886
4887 2019-01-15  Tom Tromey  <tom@tromey.com>
4888
4889         * symtab.c (lookup_objfile_from_block)
4890         (lookup_symbol_in_objfile_symtabs)
4891         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4892         (find_line_symtab, info_sources_command)
4893         (default_collect_symbol_completion_matches_break_on)
4894         (make_source_files_completion_list): Update.
4895         * symmisc.c (print_objfile_statistics, dump_objfile)
4896         (maintenance_print_symbols, maintenance_info_symtabs)
4897         (maintenance_check_symtabs, maintenance_info_line_tables):
4898         Update.
4899         * source.c (select_source_symtab)
4900         (forget_cached_source_info_for_objfile): Update.
4901         * objfiles.h (class objfile_compunits): Remove.
4902         (struct objfile) <compunits_range>: New typedef.
4903         (compunits): New method.
4904         * objfiles.c (objfile_relocate1): Update.
4905         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4906         * maint.c (count_symtabs_and_blocks): Update.
4907         * linespec.c (iterate_over_all_matching_symtabs): Update.
4908         * cp-support.c (add_symbol_overload_list_qualified): Update.
4909         * coffread.c (coff_symtab_read): Update.
4910         * ada-lang.c (add_nonlocal_symbols)
4911         (ada_collect_symbol_completion_matches)
4912         (ada_add_global_exceptions): Update.
4913
4914 2019-01-15  Tom Tromey  <tom@tromey.com>
4915
4916         * progspace.h (program_space) <objfiles_safe_range>: New
4917         typedef.
4918         <objfiles_safe>: New method.
4919         * objfiles.h (class all_objfiles_safe): Remove.
4920         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4921         * jit.c (jit_inferior_exit_hook): Update.
4922
4923 2019-01-17  Tom Tromey  <tom@tromey.com>
4924
4925         * progspace.h (program_space) <objfiles_range>: New typedef.
4926         <objfiles>: New method.
4927         <objfiles_head>: Rename from objfiles.
4928         (object_files): Update.
4929         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4930         * guile/scm-pretty-print.c
4931         (ppscm_find_pretty_printer_from_objfiles): Update.
4932         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4933         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4934         Update.
4935         * python/py-progspace.c (pspy_get_objfiles): Update.
4936         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4937         Update.
4938         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4939         (objfpy_lookup_objfile_by_build_id): Update.
4940         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4941         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4942         Update.
4943         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4944         (expand_symtab_containing_pc, lookup_objfile_from_block)
4945         (lookup_static_symbol, basic_lookup_transparent_type)
4946         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4947         (find_line_symtab, info_sources_command)
4948         (default_collect_symbol_completion_matches_break_on)
4949         (make_source_files_completion_list, find_main_name): Update.
4950         * symmisc.c (print_symbol_bcache_statistics)
4951         (print_objfile_statistics, maintenance_print_symbols)
4952         (maintenance_print_msymbols, maintenance_print_objfiles)
4953         (maintenance_info_symtabs, maintenance_check_symtabs)
4954         (maintenance_expand_symtabs, maintenance_info_line_tables):
4955         Update.
4956         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4957         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4958         (map_overlay_command, unmap_overlay_command)
4959         (simple_overlay_update, expand_symtabs_matching)
4960         (map_symbol_filenames): Update.
4961         * symfile-debug.c (set_debug_symfile): Update.
4962         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4963         Update.
4964         * source.c (select_source_symtab, forget_cached_source_info):
4965         Update.
4966         * solib.c (solib_read_symbols): Update.
4967         * solib-spu.c (append_ocl_sos): Update.
4968         * psymtab.c (maintenance_print_psymbols)
4969         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4970         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4971         * printcmd.c (info_symbol_command): Update.
4972         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4973         Update.
4974         * objfiles.h (class all_objfiles): Remove.
4975         * objfiles.c (have_partial_symbols, have_full_symbols)
4976         (have_minimal_symbols, qsort_cmp, update_section_map)
4977         (shared_objfile_contains_address_p)
4978         (default_iterate_over_objfiles_in_search_order): Update.
4979         * objc-lang.c (info_selectors_command, info_classes_command)
4980         (find_methods): Update.
4981         * minsyms.c (find_solib_trampoline_target): Update.
4982         * maint.c (maintenance_info_sections)
4983         (maintenance_translate_address, count_symtabs_and_blocks):
4984         Update.
4985         * main.c (captured_main_1): Update.
4986         * linux-thread-db.c (try_thread_db_load_from_pdir)
4987         (has_libpthread): Update.
4988         * linespec.c (iterate_over_all_matching_symtabs)
4989         (search_minsyms_for_name): Update.
4990         * jit.c (jit_find_objf_with_entry_addr): Update.
4991         * hppa-tdep.c (find_unwind_entry)
4992         (hppa_lookup_stub_minimal_symbol): Update.
4993         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4994         Update.
4995         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4996         (elf_gnu_ifunc_resolve_by_got): Update.
4997         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4998         * dwarf-index-write.c (save_gdb_index_command): Update.
4999         * cp-support.c (add_symbol_overload_list_qualified): Update.
5000         * breakpoint.c (create_overlay_event_breakpoint)
5001         (create_longjmp_master_breakpoint)
5002         (create_std_terminate_master_breakpoint)
5003         (create_exception_master_breakpoint): Update.
5004         * blockframe.c (find_pc_partial_function): Update.
5005         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5006         (ada_collect_symbol_completion_matches)
5007         (ada_add_global_exceptions): Update.
5008
5009 2019-01-17  Tom Tromey  <tom@tromey.com>
5010
5011         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5012         declare VEC.
5013         (solib_target_parse_libraries): Change return type.
5014         (library_list_start_segment, library_list_start_section)
5015         (library_list_end_library, library_list_start_library); Update.
5016         (solib_target_free_library_list): Remove.
5017         (solib_target_parse_libraries): Remove cleanup.  Change return
5018         type.
5019         (solib_target_current_sos): Update.
5020
5021 2019-01-17  Tom Tromey  <tromey@bapiya>
5022
5023         * valprint.c: Replace "the the" with "the".
5024         * symtab.c: Replace "the the" with "the".
5025         * solib.c: Replace "the the" with "the".
5026         * solib-dsbt.c: Replace "the the" with "the".
5027         * linespec.c: Replace "the the" with "the".
5028         * dwarf2loc.h: Replace "the the" with "the".
5029         * amd64-windows-tdep.c: Replace "the the" with "the".
5030         * aarch64-tdep.c: Replace "the the" with "the".
5031
5032 2019-01-16  Keith Seitz  <keiths@redhat.com>
5033
5034         PR gdb/23773
5035         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5036         <builder>: Rename to ..
5037         <m_builder>: ... this and make private.
5038         (dwarf2_cu::get_builder): New method.  Change all users of
5039         `builder' to use this method.
5040         (dwarf2_start_symtab): Move to ...
5041         (dwarf2_cu::start_symtab): ... here.  Update all callers
5042         (setup_type_unit_groups): Move to ...
5043         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5044         callers.
5045         (dwarf2_cu::reset_builder): New method.
5046         (process_full_compunit, process_full_type_unit): Use
5047         dwarf2_cu::reset_builder.
5048         (follow_die_offset): Record the ancestor CU if it is different
5049         from the followed DIE's CU.
5050         (follow_die_sig_1): Likewise.
5051
5052 2019-01-15  Tom Tromey  <tom@tromey.com>
5053
5054         * remote.c (class remote_state) <buf>: Now a char_vector.
5055         <buf_size>: Remove.
5056         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5057         parameter.
5058         (remote_target::getpkt_or_notif_sane_1)
5059         (remote_target::getpkt_sane)
5060         (remote_target::getpkt_or_notif_sane): Likewise.
5061         (class remote_target) <putpkt>: New overload.
5062         (remote_target::read_frame): Change type of "buf_p".  Remove
5063         sizeof_p parameter.
5064         (packet_ok): New overload.
5065         (packet_check_result): New overload.
5066         Update all uses.
5067
5068 2019-01-14  Tom Tromey  <tom@tromey.com>
5069
5070         * remote-notif.c (handle_notification, remote_notif_ack)
5071         (remote_notif_parse): Make "buf" const.
5072         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5073         const.
5074         (remote_notif_parse, remote_notif_ack, handle_notification):
5075         Likewise.
5076         * remote.c (remote_notif_stop_parse): Make "buf" const.
5077         (remote_target::remote_parse_stop_reply): Make "buf" const.
5078         (remote_notif_stop_ack): Make "buf" const.
5079
5080 2019-01-14  Tom Tromey  <tom@tromey.com>
5081
5082         * remote.c (remote_console_output): Make parameter const.
5083
5084 2019-01-14  Tom Tromey  <tom@tromey.com>
5085
5086         * target-debug.h (target_debug_print_signals): Constify.
5087         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5088         * procfs.c (procfs_target::pass_signals): Update.
5089         * linux-nat.c (linux_nat_target::pass_signals): Update.
5090         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5091         * target-delegates.c: Rebuild.
5092         * remote.c (remote_target::program_signals): Update.
5093         (remote_target::pass_signals): Update.
5094         * target.c (target_pass_signals): Constify argument.
5095         (target_program_signals): Likewise.
5096         * target.h (struct target_ops) <pass_signals, program_signals>:
5097         Constify argument.
5098         (target_pass_signals, target_program_signals): Constify argument.
5099
5100 2019-01-14  Tom Tromey  <tom@tromey.com>
5101
5102         PR tui/28819:
5103         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5104
5105 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5106
5107         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5108         field.
5109         * rs6000-tdep.c: Include reggroups.h.
5110         (IS_V_ALIAS_PSEUDOREG): Define.
5111         (rs6000_register_name): Return names for the "vX" aliases.
5112         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5113         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5114         aliases.  Call default_register_reggroup_p for all other
5115         pseudo-registers.
5116         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5117         New functions.
5118         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5119         Handle "vX" aliases.
5120         (v_alias_pseudo_register_collect): New function.
5121         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5122         (rs6000_gdbarch_init): Initialize "vX" aliases as
5123         pseudo-registers.  Restore registration of
5124         rs6000_pseudo_register_reggroup_p with
5125         set_tdesc_pseudo_register_reggroup_p.
5126
5127 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5128
5129         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5130         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5131         set_gdbarch_num_pseudo_regs.
5132
5133 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5134
5135         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5136         Remove arg prefixname, add do_set and do_show.
5137         Add member functions set_list and show_list.
5138         * cli/cli-style.c (class cli_style_option): Update accordingly.
5139         (style_set_list): Move to file scope.
5140         (style_show_list): Likewise.
5141         (set_style): Call help_list.
5142         (show_style): Call cmd_show_list.
5143         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5144         Update to use the new macro.
5145
5146 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5147
5148         * ada-lang.c (_initialize_ada_language): Expand the help text
5149         for the "catch exception" command.
5150
5151 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5152
5153         * symtab.c (matching_obj_sections): Initialize obj,
5154         declare it closer to its usage.
5155
5156 2019-01-10  Tom Tromey  <tom@tromey.com>
5157
5158         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5159         (basic_inf_threads_range): Remove.
5160         (inf_threads_range, inf_non_exited_threads_range)
5161         (safe_inf_threads_range): Use next_adapter.
5162
5163 2019-01-10  Keith Seitz  <keiths@redhat.com>
5164
5165         PR gdb/23712
5166         PR symtab/23010
5167         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5168         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5169
5170 2019-01-10  Keith Seitz  <keiths@redhat.com>
5171
5172         PR gdb/23712
5173         PR symtab/23010
5174         * dictionary.c (pending_to_vector): Remove.
5175         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5176         Remove _1 suffix, replacing functions of the same name.  Update
5177         all callers.
5178         (dict_create_hashed, dict_create_hashed_expandable)
5179         (dict_create_linear, dict_create_linear_expandable, dict_free)
5180         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5181         Make functions static.
5182
5183 2019-01-10  Keith Seitz  <keiths@redhat.com>
5184
5185         PR gdb/23712
5186         PR symtab/23010
5187         * dictionary.h (struct dictionary): Replace declaration with
5188         multidictionary.
5189         (dict_create_hashed, dict_create_hashed_expandable)
5190         (dict_create_linear, dict_create_linear_expandable)
5191         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5192         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5193         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5194         taking multidictionary argument.
5195         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5196         * block.h (struct block) <dict>: Change to multidictionary
5197         and rename `multidict'.
5198         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5199         symmisc.c: Update all dictionary references to multidictionary.
5200
5201 2019-01-10  Keith Seitz  <keiths@redhat.com>
5202
5203         PR gdb/23712
5204         PR symtab/23010
5205         * dictionary.c: Include unordered_map.
5206         (pending_to_vector): New function.
5207         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5208         Rewrite the non-"_1" functions to take vector instead
5209         of linked list.
5210         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5211         "new" _1 versions of the same name.
5212         (multidictionary): Define.
5213         (std::hash<enum language): New definition.
5214         (collate_pending_symbols_by_language, mdict_create_hashed)
5215         (mdict_create_hashed_expandable, mdict_create_linear)
5216         (mdict_create_linear_expandable, mdict_free)
5217         (find_language_dictionary, create_new_language_dictionary)
5218         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5219         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5220         (mdict_size, mdict_empty): New functions.
5221         * dictionary.h (mdict_iterator): Define.
5222
5223 2019-01-10  Pedro Alves  <palves@redhat.com>
5224
5225         * breakpoint.c (read_uploaded_action)
5226         (create_tracepoint_from_upload): Adjust to use
5227         gdb::unique_xmalloc_ptr.
5228         * ctf.c (ctf_write_uploaded_tp):
5229         (SET_ARRAY_FIELD): Use emplace_back.
5230         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5231         * tracefile-tfile.c (tfile_write_uploaded_tp):
5232         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5233         gdb::unique_xmalloc_ptr.
5234         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5235         at_string, cond_string, cmd_strings>: Replace char pointers
5236         with gdb::unique_xmalloc_ptr.
5237
5238 2019-01-10  Pedro Alves  <palves@redhat.com>
5239
5240         * solib-target.c (library_list_start_library): Don't xstrdup name.
5241
5242 2019-01-10  Pedro Alves  <palves@redhat.com>
5243
5244         * mdebugread.c (parse_partial_symbols): Use
5245         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5246
5247 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5248
5249         * linux-fork.c (scoped_switch_fork_info)
5250         <~scoped_switch_fork_info>: Fix incorrect variable name.
5251
5252 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5253
5254         * linux-fork.c (scoped_switch_fork_info)
5255         <scoped_switch_fork_info>: Make explicit.
5256         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5257
5258 2019-01-10  Tom Tromey  <tom@tromey.com>
5259
5260         * objfiles.h (objfile::reset_psymtabs): Update.
5261         * objfiles.c (objfile::objfile): Update.
5262         * psymtab.h (psymtab_storage::obstack): Update.
5263         (psymtab_storage::m_obstack): Use gdb::optional.
5264         (class psymtab_storage): Update comment.  Remove objfile
5265         parameter.
5266         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5267
5268 2019-01-10  Tom Tromey  <tom@tromey.com>
5269
5270         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5271         <free_psymtabs>: Now private.
5272         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5273         (allocate_psymtab): Use new method.
5274
5275 2019-01-10  Tom Tromey  <tom@tromey.com>
5276
5277         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5278         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5279         * mdebugread.c (parse_partial_symbols): Use
5280         allocate_dependencies.
5281         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5282         allocate_dependencies.
5283         (process_psymtab_comp_unit_reader)
5284         (build_type_psymtab_dependencies): Likewise.
5285         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5286
5287 2019-01-10  Tom Tromey  <tom@tromey.com>
5288
5289         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5290         PSYMBOL_SET_LANGUAGE.
5291         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5292
5293 2019-01-10  Tom Tromey  <tom@tromey.com>
5294
5295         * psymtab.h (psymtab_storage::obstack): New method.
5296         <m_obstack>: Rename from obstack; now private.
5297         * psymtab.c (psymtab_storage): Update.
5298         * dwarf2read.c (create_addrmap_from_index)
5299         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5300         Update.
5301
5302 2019-01-10  Tom Tromey  <tom@tromey.com>
5303
5304         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5305         * objfiles.h (objfile::reset_psymtabs): New method.
5306
5307 2019-01-10  Tom Tromey  <tom@tromey.com>
5308
5309         * symmisc.c (print_symbol_bcache_statistics): Update.
5310         (print_objfile_statistics): Update.
5311         * symfile.c (reread_symbols): Update.
5312         * psymtab.h (class psymtab_storage): New.
5313         * psymtab.c (psymtab_storage): New constructor.
5314         (~psymtab_storage): New destructor.
5315         (require_partial_symbols): Update.
5316         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5317         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5318         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5319         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5320         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5321         (start_psymtab_common, end_psymtab_common)
5322         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5323         (allocate_psymtab): Update.
5324         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5325         Update.
5326         (dump_psymtab_addrmap, maintenance_print_psymbols)
5327         (maintenance_check_psymtabs): Update.
5328         (class objfile_psymtabs): Move to objfiles.h.
5329         * psympriv.h (discard_psymtab): Now inline.
5330         (psymtab_discarder::psymtab_discarder): Update.
5331         (psymtab_discarder::~psymtab_discarder): Update.
5332         (ALL_OBJFILE_PSYMTABS): Rewrite.
5333         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5334         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5335         Remove fields.
5336         <partial_symtabs>: New field.
5337         (class objfile_psymtabs): Move from psymtab.h.  Update.
5338         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5339         psymbol_cache.
5340         (objfile::~objfile): Don't destroy psymbol_cache.
5341         * mdebugread.c (parse_partial_symbols): Update.
5342         * dwarf2read.c (create_addrmap_from_index)
5343         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5344         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5345         (add_partial_subprogram, dwarf2_ranges_read): Update.
5346         * dwarf-index-write.c (write_address_map)
5347         (write_one_signatured_type, recursively_write_psymbols)
5348         (class debug_names, class debug_names, write_psymtabs_to_index):
5349         Update.
5350
5351 2019-01-10  Tom Tromey  <tom@tromey.com>
5352
5353         * symtab.h (SYMBOL_SET_NAMES): Update.
5354         (symbol_set_names): Update.
5355         (MSYMBOL_SET_NAMES): Update.
5356         * symtab.c (symbol_set_names): Change argument to be an
5357         objfile_per_bfd_storage.
5358         * psymtab.c (add_psymbol_to_bcache): Update.
5359         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5360
5361 2019-01-10  Tom Tromey  <tom@tromey.com>
5362
5363         * symtab.c (create_demangled_names_hash): Change argument to be an
5364         objfile_per_bfd_storage.
5365         (symbol_set_names): Update.
5366
5367 2019-01-10  Tom Tromey  <tom@tromey.com>
5368
5369         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5370         init_psymbol_list.
5371         * psymtab.c (init_psymbol_list): Do nothing if already called.
5372         * psympriv.h (init_psymbol_list): Add comment.
5373         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5374         init_psymbol_list.
5375         * dbxread.c (dbx_symfile_read): Unconditionally call
5376         init_psymbol_list.
5377
5378 2019-01-10  Tom Tromey  <tom@tromey.com>
5379
5380         * xcoffread.c (scan_xcoff_symtab): Update.
5381         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5382         "where".
5383         * mdebugread.c (parse_partial_symbols)
5384         (handle_psymbol_enumerators): Update.
5385         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5386         * dbxread.c (read_dbx_symtab): Update.
5387         * psympriv.h (psymbol_placement): New enum.
5388         (add_psymbol_to_list): Update.
5389
5390 2019-01-10  Tom Tromey  <tom@tromey.com>
5391
5392         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5393         static_psymbols parameters.
5394         (scan_xcoff_symtab): Update.
5395         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5396         static_psymbols parameters.
5397         * psympriv.h (start_psymtab_common): Update.
5398         * mdebugread.c (parse_partial_symbols): Update.
5399         * dwarf2read.c (create_partial_symtab): Update.
5400         * dbxread.c (read_dbx_symtab): Update.
5401         (start_psymtab): Remove global_psymbols and static_psymbols
5402         parameters.
5403
5404 2019-01-10  Tom Tromey  <tom@tromey.com>
5405
5406         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5407         * psymtab.c (allocate_psymtab): Add comment.
5408         * psympriv.h (allocate_psymtab): Add comment.
5409         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5410         initializations.
5411         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5412
5413 2019-01-10  Tom Tromey  <tom@tromey.com>
5414
5415         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5416         Don't declare.
5417         * mipsread.c: Include mdebugread.h.
5418         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5419         Declare.
5420         * elfread.c: Include mdebugread.h.
5421
5422 2019-01-09  Tom Tromey  <tom@tromey.com>
5423
5424         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5425         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5426         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5427         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5428         (psym_lookup_symbol, psym_find_last_source_symtab)
5429         (psym_forget_cached_source_info, psym_print_stats)
5430         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5431         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5432         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5433         (psym_find_compunit_symtab_by_address)
5434         (maintenance_print_psymbols, maintenance_info_psymtabs)
5435         (maintenance_check_psymtabs): Use ranged for.
5436         * psymtab.h (class objfile_psymtabs): New.
5437         (require_partial_symbols): Return objfile_psymtabs.
5438         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5439
5440 2019-01-09  Tom Tromey  <tom@tromey.com>
5441
5442         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5443         (find_pc_mapped_section, list_overlays_command)
5444         (map_overlay_command, unmap_overlay_command)
5445         (simple_overlay_update): Use all_objfiles.
5446         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5447         * printcmd.c (info_symbol_command): Use all_objfiles.
5448         * objfiles.h (ALL_OBJSECTIONS): Remove.
5449         * maint.c (maintenance_translate_address): Use all_objfiles.
5450         * gcore.c (gcore_create_callback): Use all_objfiles.
5451         (objfile_find_memory_regions): Likewise.
5452
5453 2019-01-09  Tom Tromey  <tom@tromey.com>
5454
5455         * symtab.c (find_line_symtab, info_sources_command)
5456         (make_source_files_completion_list): Use objfile_compunits.
5457         * source.c (select_source_symtab): Use objfile_compunits.
5458         * objfiles.h (struct objfile): Update comment.
5459         (ALL_OBJFILES): Remove.
5460         (ALL_FILETABS): Remove.
5461         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5462         objfile_compunits.
5463
5464 2019-01-09  Tom Tromey  <tom@tromey.com>
5465
5466         * symmisc.c (print_objfile_statistics, dump_objfile)
5467         (maintenance_print_symbols): Use compunit_filetabs.
5468         * source.c (forget_cached_source_info_for_objfile): Use
5469         compunit_filetabs.
5470         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5471         (ALL_FILETABS): Use compunit_filetabs.
5472         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5473         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5474
5475 2019-01-09  Tom Tromey  <tom@tromey.com>
5476
5477         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5478         (compunit_filetabs): New.
5479         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5480         compunit_filetabs.
5481         (info_sources_command, make_source_files_completion_list): Remove
5482         declaration.
5483         * symmisc.c (print_objfile_statistics, dump_objfile)
5484         (maintenance_print_symbols): Remove declaration.
5485         (maintenance_info_symtabs): Use compunit_filetabs.
5486         (maintenance_info_line_tables): Likewise.
5487         * source.c (select_source_symtab): Change local variable name.
5488         (forget_cached_source_info_for_objfile): Remove declaration.
5489         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5490         * objfiles.c (objfile_relocate1): Remove declaration.
5491         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5492         declaration.
5493         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5494         * coffread.c (coff_symtab_read): Remove declaration.
5495         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5496         compunit_filetabs.
5497
5498 2019-01-09  Tom Tromey  <tom@tromey.com>
5499
5500         * symtab.c (lookup_objfile_from_block)
5501         (find_pc_sect_compunit_symtab, search_symbols)
5502         (default_collect_symbol_completion_matches_break_on): Use
5503         objfile_compunits.
5504         * objfiles.h (ALL_COMPUNITS): Remove.
5505         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5506         * cp-support.c (add_symbol_overload_list_qualified): Use
5507         objfile_compunits.
5508         * ada-lang.c (ada_collect_symbol_completion_matches)
5509         (ada_add_global_exceptions): Use objfile_compunits.
5510
5511 2019-01-09  Tom Tromey  <tom@tromey.com>
5512
5513         * source.c (select_source_symtab)
5514         (forget_cached_source_info_for_objfile): Remove declaration.
5515         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5516         declaration.
5517         * maint.c (count_symtabs_and_blocks): Remove declaration.
5518         * cp-support.c (add_symbol_overload_list_qualified): Remove
5519         declaration.
5520         * coffread.c (coff_symtab_read): Remove declaration.
5521         * symtab.c (lookup_symbol_in_objfile_symtabs)
5522         (basic_lookup_transparent_type_1): Use objfile_compunits.
5523         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5524         (info_sources_command, search_symbols)
5525         (default_collect_symbol_completion_matches_break_on)
5526         (make_source_files_completion_list): Remove declaration.
5527         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5528         (ada_collect_symbol_completion_matches)
5529         (ada_add_global_exceptions): Remove declaration.
5530         * linespec.c (iterate_over_all_matching_symtabs): Use
5531         objfile_compunits.
5532         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5533         (class objfile_compunits): New.
5534         (ALL_COMPUNITS): Use objfile_compunits.
5535         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5536         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5537         objfile_compunits.
5538         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5539
5540 2019-01-09  Tom Tromey  <tom@tromey.com>
5541
5542         * symtab.c (search_symbols)
5543         (default_collect_symbol_completion_matches_break_on): Use
5544         objfile_msymbols.
5545         * ada-lang.c (ada_lookup_simple_minsym)
5546         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5547         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5548         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5549         objfile_msymbols.
5550         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5551         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5552         * objc-lang.c (find_methods): Use objfile_msymbols.
5553         (info_selectors_command, info_classes_command): Likewise.
5554         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5555         * objfiles.h (class objfile_msymbols): New.
5556         (ALL_OBJFILE_MSYMBOLS): Remove.
5557         (ALL_MSYMBOLS): Remove.
5558
5559 2019-01-09  Tom Tromey  <tom@tromey.com>
5560
5561         * common/next-iterator.h (next_adapter): Add Iterator template
5562         parameter.
5563         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5564         (class all_objfiles_safe): New.
5565         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5566         * objfiles.c (put_objfile_before): Update comment.
5567         (add_separate_debug_objfile): Likewise.
5568         (free_all_objfiles): Use all_objfiles_safe.
5569         (objfile_purge_solibs): Likewise.
5570
5571 2019-01-09  Tom Tromey  <tom@tromey.com>
5572
5573         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5574         (expand_symtab_containing_pc, lookup_static_symbol)
5575         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5576         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5577         all_objfiles.
5578         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5579         * breakpoint.c (create_overlay_event_breakpoint)
5580         (create_longjmp_master_breakpoint)
5581         (create_std_terminate_master_breakpoint)
5582         (create_exception_master_breakpoint): Use all_objfiles.
5583         * linux-thread-db.c (try_thread_db_load_from_pdir)
5584         (has_libpthread): Use all_objfiles.
5585         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5586         * linespec.c (iterate_over_all_matching_symtabs)
5587         (search_minsyms_for_name): Use all_objfiles.
5588         * maint.c (maintenance_info_sections): Use all_objfiles.
5589         * main.c (captured_main_1): Use all_objfiles.
5590         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5591         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5592         * guile/scm-pretty-print.c
5593         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5594         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5595         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5596         (maintenance_print_msymbols): Use all_objfiles.
5597         * source.c (select_source_symtab): Use all_objfiles.
5598         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5599         * symfile.c (remove_symbol_file_command)
5600         (expand_symtabs_matching, map_symbol_filenames): Use
5601         all_objfiles.
5602         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5603         all_objfiles.
5604         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5605         * objc-lang.c (find_methods): Use all_objfiles.
5606         * objfiles.c (have_partial_symbols, have_full_symbols)
5607         (have_minimal_symbols, qsort_cmp)
5608         (default_iterate_over_objfiles_in_search_order): Use
5609         all_objfiles.
5610         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5611         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5612         (maintenance_check_psymtabs): Use all_objfiles.
5613         (ALL_PSYMTABS): Remove.
5614         * compile/compile-object-run.c (do_module_cleanup): Use
5615         all_objfiles.
5616         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5617         * cp-support.c (add_symbol_overload_list_qualified): Use
5618         all_objfiles.
5619         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5620         Use all_objfiles.
5621         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5622         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5623         all_objfiles.
5624         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5625         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5626         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5627         Uses all_objfiles.
5628         * solib.c (solib_read_symbols): Use all_objfiles
5629
5630 2019-01-09  Tom Tromey  <tom@tromey.com>
5631
5632         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5633         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5634         all_objfiles.
5635         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5636         * symmisc.c (print_symbol_bcache_statistics)
5637         (print_objfile_statistics, maintenance_print_objfiles)
5638         (maintenance_info_symtabs, maintenance_check_symtabs)
5639         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5640         all_objfiles.
5641         * source.c (forget_cached_source_info): Use all_objfiles.
5642         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5643         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5644         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5645         * objfiles.c (update_section_map): Use all_objfiles.
5646         (shared_objfile_contains_address_p): Likewise.
5647         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5648         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5649
5650 2019-01-09  Tom Tromey  <tom@tromey.com>
5651
5652         * common/next-iterator.h: New file.
5653         * objfiles.h (class all_objfiles): New.
5654         (struct objfile_iterator): New.
5655
5656 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5657
5658         * NEWS: Move the description of the changed "frame", "select-frame",
5659          and "info frame" commands to the Changed commands section.
5660
5661 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5662
5663         * gdbtypes.c (check_stub_method_group): Remove handling of old
5664         mangling schemes.
5665         * linespec.c (find_methods): Likewise.
5666         * stabsread.c (read_member_functions): Likewise.
5667         * valops.c (search_struct_method): Likewise.
5668         (value_struct_elt_for_reference): Likewise.
5669         * NEWS: Mention this change.
5670
5671 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5672
5673         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5674         print_source_lines.
5675         * source.c (print_source_lines_base): Update line number check.
5676         (print_source_lines): New function.
5677         (source_lines_range::source_lines_range): New function.
5678         * source.h (class source_lines_range): New class.
5679         (print_source_lines): New declaration.
5680
5681 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5682
5683         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5684
5685 2019-01-08  Tom Tromey  <tom@tromey.com>
5686             Simon Marchi  <simon.marchi@ericsson.com>
5687
5688         PR gdb/24060
5689         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5690         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5691         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5692         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5693         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5694         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5695
5696 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5697
5698         * source.c (select_source_symtab): Move header comment to
5699         declaration in source.h.
5700         (forget_cached_source_info_for_objfile): Likewise.
5701         (forget_cached_source_info): Likewise.
5702         (identify_source_line): Likewise.
5703         * source.h (identify_source_line): Move declaration from symtab.h
5704         and add comment from source.c
5705         (print_source_lines): Likewise.
5706         (forget_cached_source_info_for_objfile): Likewise.
5707         (forget_cached_source_info): Likewise.
5708         (select_source_symtab): Likewise.
5709         (enum print_source_lines_flag): Move definition from symtab.h.
5710         * symtab.h (identify_source_line): Move declaration to source.h.
5711         (print_source_lines): Likewise.
5712         (forget_cached_source_info_for_objfile): Likewise.
5713         (forget_cached_source_info): Likewise.
5714         (select_source_symtab): Likewise.
5715         (enum print_source_lines_flag): Move definition to source.h.
5716         * tui/tui-hooks.c: Add 'source.h' include.
5717
5718 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5719
5720         * source.c (print_source_lines_base): Handle requests to print
5721         reverse line number sequences, and guard against empty lines
5722         string.
5723
5724 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * source.c (print_source_lines_base): Fix skip of '\r' if next
5727         character is '\n'.
5728
5729 2019-01-06  Tom Tromey  <tom@tromey.com>
5730
5731         * c-exp.y (struct c_parse_state) <macro_original_text,
5732         expansion_obstack>: New member.
5733         (macro_original_text, expansion_obstack): Remove globals.
5734         (scan_macro_expansion, scanning_macro_expansion)
5735         (finished_macro_expansion): Update.
5736         (scan_macro_cleanup): Remove.
5737         (yylex, c_parse): Update.
5738
5739 2019-01-06  Tom Tromey  <tom@tromey.com>
5740
5741         * c-exp.y (struct c_parse_state) <strings>: New member.
5742         (operator_stoken): Update.
5743
5744 2019-01-06  Tom Tromey  <tom@tromey.com>
5745
5746         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5747         (union type_stack_elt) <typelist_val>: Now a pointer to
5748         std::vector.
5749         (type_stack_cleanup): Don't declare.
5750         (push_typelist): Update.
5751         * parse.c (pop_typelist): Return a std::vector.
5752         (push_typelist): Take a std::vector.
5753         (follow_types): Update.  Do not free args.
5754         (type_stack_cleanup): Remove.
5755         * c-exp.y (struct c_parse_state): New.
5756         (cpstate): New global.
5757         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5758         (nonempty_typelist): Update.
5759         (func_mod): Create a new vector.
5760         (c_parse): Create a c_parse_state.
5761         (check_parameter_typelist): Do not delete params.
5762         (function_method): Update.  Do not delete type_list.
5763
5764 2019-01-06  Tom Tromey  <tom@tromey.com>
5765
5766         PR gdb/28155:
5767         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5768         check_typedef.
5769         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5770         (print_return_value): Likewise.
5771
5772 2019-01-05  Tom Tromey  <tom@tromey.com>
5773
5774         * contrib/cleanup_check.py: Remove.
5775         * contrib/gcc-with-excheck: Remove.
5776         * contrib/exsummary.py: Remove.
5777         * contrib/excheck.py: Remove.
5778
5779 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5780
5781         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5782         NULL. Initialize tpprev to NULL instead of assigning it
5783         to NULL on the next statement.
5784         * windows-nat.c (windows_delete_thread): Remove check for
5785         main_thread_id before printing thread exit notifications.
5786         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5787         Remove thread ID check against main_thread_id.
5788         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5789         windows_delete_thread.
5790         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5791
5792 2019-01-04  Tom Tromey  <tom@tromey.com>
5793
5794         * compile/compile.c (_initialize_compile): Use upper case for
5795         metasyntactic variables.
5796         * symmisc.c (_initialize_symmisc): Use upper case for
5797         metasyntactic variables.
5798         * psymtab.c (_initialize_psymtab): Use upper case for
5799         metasyntactic variables.
5800         * demangle.c (demangle_command): Use upper case for metasyntactic
5801         variables.
5802         (_initialize_demangler): Likewise.
5803         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5804         variables.
5805
5806 2019-01-03  Tom Tromey  <tom@tromey.com>
5807
5808         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5809
5810 2019-01-03  Tom Tromey  <tom@tromey.com>
5811
5812         * python/py-symtab.c (salpy_str): Update.
5813         (struct salpy_sal_object) <symtab>: Now a PyObject.
5814         (salpy_dealloc): Update.
5815         (del_objfile_sal): Use gdbpy_ref.
5816
5817 2019-01-03  Tom Tromey  <tom@tromey.com>
5818
5819         * python/py-type.c (convert_field): Use new_reference.  Return
5820         gdbpy_ref.
5821         (make_fielditem): Return gdbpy_ref.
5822         (typy_fields): Update.
5823         (typy_getitem): Update.
5824         (field_name): Return gdbpy_ref.  Use new_reference.
5825         (typy_iterator_iternext): Update.
5826
5827 2019-01-03  Tom Tromey  <tom@tromey.com>
5828
5829         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5830
5831 2019-01-03  Tom Tromey  <tom@tromey.com>
5832
5833         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5834         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5835         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5836         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5837         (pspy_set_type_printers): Likewise.
5838         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5839         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5840         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5841         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5842         (objfpy_set_type_printers): Likewise.
5843
5844 2019-01-03  Tom Tromey  <tom@tromey.com>
5845
5846         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5847         (gdbpy_print_stack): Use gdbpy_err_fetch.
5848         * python/python-internal.h (class gdbpy_err_fetch): New class.
5849         (class gdbpy_enter) <m_error_type, m_error_value,
5850         m_error_traceback>: Remove.
5851         <m_error>: New member.
5852         (gdbpy_exception_to_string): Don't declare.
5853         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5854         * python/py-value.c (convert_value_from_python): Use
5855         gdbpy_err_fetch.
5856         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5857         gdbpy_exception_to_string.
5858         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5859         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5860         gdbpy_err_fetch.
5861
5862 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5863
5864         * linux-nat.c (delete_lwp_cleanup): Delete.
5865         (struct lwp_deleter): New struct.
5866         (lwp_info_up): New typedef.
5867         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5868         lwp_info_up.
5869
5870 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * linux-fork.c (class scoped_switch_fork_info): New class.
5873         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5874
5875 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5876
5877         * valops.c (find_overload_match): Remove use of null_cleanup, and
5878         calls to do_cleanups.
5879
5880 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5881
5882         * compile/compile-cplus-types.c
5883         (compile_cplus_instance::decl_name): Handle changes to
5884         cp_func_name.
5885         * cp-support.c (cp_func_name): Update header comment, update
5886         return type.
5887         * cp-support.h (cp_func_name): Update return type in declaration.
5888         * valops.c (find_overload_match): Move temp_func local to top
5889         level of function and change its type.  Use temp_func to hold and
5890         delete temporary string obtained from cp_func_name.
5891
5892 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5893
5894         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5895         gdb::char_vector, remove cleanup, and update uses of `msg`.
5896
5897 2019-01-03  Jim Wilson  <jimw@sifive.com>
5898
5899         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5900
5901 2019-01-02  Tom Tromey  <tom@tromey.com>
5902
5903         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5904         (tdesc_parse_xml): Remove cleanups.
5905         * target-descriptions.h (make_cleanup_free_target_description):
5906         Don't declare.
5907         (target_desc_deleter): New struct.
5908         (target_desc_up): New typedef.
5909         * target-descriptions.c (target_desc_deleter::operator()): Rename
5910         from free_target_description.
5911         (make_cleanup_free_target_description): Remove.
5912
5913 2019-01-02  Tom Tromey  <tom@tromey.com>
5914
5915         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5916         constructor, destructor.
5917         (linespec_parser): Remove typedef.
5918         (~linespec_parser): Rename from linespec_parser_delete.
5919         (linespec_lex_to_end, linespec_complete_label)
5920         (linespec_complete): Update.
5921         (decode_line_full): Remove cleanups.
5922         (decode_line_1): Update.
5923
5924 2019-01-02  Tom Tromey  <tom@tromey.com>
5925
5926         * python/python-internal.h (inferior_to_inferior_object): Change
5927         return type.
5928         * python/py-exitedevent.c (create_exited_event_object): Update.
5929         * python/py-inferior.c (inferior_to_inferior_object): Return
5930         gdbpy_ref.
5931         (python_new_inferior, python_inferior_deleted)
5932         (thread_to_thread_object, delete_thread_object)
5933         (build_inferior_list, gdbpy_selected_inferior): Update.
5934         * python/py-infthread.c (create_thread_object): Update.  Also fail
5935         if inferior_to_inferior_object fails.
5936
5937 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5938
5939         * inferior.h (class inferior) <displaced_step_state>: New field.
5940         * infrun.h (struct displaced_step_state): Move here from
5941         infrun.c.  Initialize fields, add constructor.
5942         <inf>: Remove field.
5943         <reset>: New method.
5944         * infrun.c (struct displaced_step_inferior_state): Move to
5945         infrun.h.
5946         (displaced_step_inferior_states): Remove.
5947         (get_displaced_stepping_state): Adust.
5948         (displaced_step_in_progress_any_inferior): Adjust.
5949         (displaced_step_in_progress_thread): Adjust.
5950         (displaced_step_in_progress): Adjust.
5951         (add_displaced_stepping_state): Remove.
5952         (get_displaced_step_closure_by_addr): Adjust.
5953         (remove_displaced_stepping_state): Remove.
5954         (infrun_inferior_exit): Call displaced_step_state.reset.
5955         (use_displaced_stepping): Don't check for NULL.
5956         (displaced_step_prepare_throw): Call
5957         get_displaced_stepping_state.
5958         (displaced_step_fixup): Don't check for NULL.
5959         (prepare_for_detach): Don't check for NULL.
5960
5961 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5962
5963         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5964          in case of call that did not complete.
5965
5966 2019-01-02  Andrey Utkin  <autkin@undo.io>
5967
5968         * symfile.c (find_separate_debug_file): Fix search of debug files for
5969         remote debuggee.
5970
5971 2019-01-02  Tom Tromey  <tom@tromey.com>
5972
5973         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5974         indentation.
5975         * python/py-frame.c (frapy_older): Remove cast.
5976         (frapy_newer): Likewise.
5977         * python/py-breakpoint.c (local_setattro): Remove cast.
5978         * python/py-arch.c (archpy_name): Remove local variable.
5979         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5980
5981 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5982
5983         * unittests/basic_string_view/element_access/char/empty.cc:
5984         Fix year range in copyright header.
5985
5986 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5987
5988         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5989         Delete.
5990         <operator==>: Update with for removed field.
5991         <hash>: Likewise.
5992         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5993         <isa_features>: ...this.
5994         <abi_features>: New field.
5995         (riscv_isa_flen): Update comment.
5996         (riscv_abi_xlen): New declaration.
5997         (riscv_abi_flen): New declaration.
5998         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5999         isa_features.
6000         (riscv_abi_xlen): New function.
6001         (riscv_isa_flen): Update to get answer from isa_features.
6002         (riscv_abi_flen): New function.
6003         (riscv_has_fp_abi): Update to get answer from abi_features.
6004         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6005         xlen and flen.
6006         (riscv_call_info) <xlen, flen>: Update comment.
6007         (riscv_call_arg_struct): Remove invalid assertions
6008         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6009         is removed.
6010         (riscv_gdbarch_init): Gather isa features and abi features
6011         separately, ensure both match on the gdbarch when reusing an old
6012         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6013         a target with 64-bit float hardware.
6014
6015 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6016
6017         * source.c (search_command_helper): Stop reverse search
6018         when line 1 has been searched.
6019
6020 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6021
6022         * record-full.c (record_full_base_target::close): Rewrite
6023         record_full_core_buf_list free logic.
6024
6025 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6026
6027         * break-catch-syscall.c (print_one_catch_syscall): xfree
6028         the last text.
6029
6030 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6031
6032         * top.c (print_gdb_version): Update Copyright year in version
6033         message.
6034
6035 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6036
6037         Update copyright year range in all GDB files.
6038
6039 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6040
6041         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6042
6043 For older changes see ChangeLog-2018.
6044 \f
6045 Local Variables:
6046 mode: change-log
6047 left-margin: 8
6048 fill-column: 74
6049 version-control: never
6050 coding: utf-8
6051 End:
6052