gdb/ChangeLog

   1 2019-08-05  Tom Tromey  <tromey@adacore.com>
   2
   3         * compile/compile.c (_initialize_compile): Use _(), not N_().
   4         * thread.c (_initialize_thread): Use _(), not N_().
   5         * stack.c (_initialize_stack): Use _(), not N_().
   6         * printcmd.c (_initialize_printcmd): Use _(), not N_().
   7
   8 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
   9
  10         * dwarf2read.c (struct dw2_symtab_iterator):
  11         <want_specific_block>: Remove.
  12         <block_index>: Change type to gdb::optional.
  13         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
  14         change type of BLOCK_INDEX parameter to gdb::optional.
  15         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
  16         (dw2_lookup_symbol): Don't pass argument for
  17         WANT_SPECIFIC_BLOCK.
  18         (dw2_expand_symtabs_for_function): Don't pass argument for
  19         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
  20         (class dw2_debug_names_iterator)
  21         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
  22         parameter, change BLOCK_INDEX type to gdb::optional.
  23         <m_want_specific_block>: Remove.
  24         <m_block_index>: Change type to gdb::optional.
  25         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
  26         gdb::optional.  Re-write in function of gdb::optional.
  27         (dw2_debug_names_lookup_symbol): Don't pass argument for
  28         WANT_SPECIFIC_BLOCK.
  29         (dw2_debug_names_expand_symtabs_for_function): Don't pass
  30         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
  31         BLOCK_INDEX.
  32
  33 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  34
  35         * NEWS: Mention changes to "info sources" command.
  36
  37 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  38
  39         * symtab.c (filename_partial_match_opts): New struct type.
  40         (struct output_source_filename_data): New members
  41         regexp, c_regexp, partial_match.
  42         (output_source_filename): Use new members to decide to print file.
  43         (info_sources_option_defs): New variable.
  44         (make_info_sources_options_def_group, print_info_sources_header,
  45         info_sources_command_completer):
  46         New functions.
  47         (info_sources_command): Read new optional arguments.
  48         (_initialize_symtab): Update info sources help.
  49
  50 2019-08-02  Alexandre Oliva <oliva@adacore.com>
  51
  52         * ada-lang.c (exception_support_info_v0): Renamed from...
  53         (default_exception_support_info): ... this.  Create new
  54         definition for v1.
  55         (ada_has_this_exception_support): Look up catch_handlers_sym.
  56         (ada_exception_support_info_sniffer): Try v0 after default.
  57
  58 2019-08-01  Tom Tromey  <tromey@adacore.com>
  59
  60         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
  61         gdbarch.h.
  62
  63 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
  64
  65         * s12z-tdep.c: Fix include path for s12z-opc.h.
  66
  67 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
  68
  69         * NEWS: Require GNU make 3.82.
  70
  71 2019-07-16  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
  74         declare.
  75
  76 2019-07-30  Tom Tromey  <tromey@adacore.com>
  77
  78         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  79
  80 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  81
  82         * printcmd.c (print_address_symbolic): Print negative offsets.
  83         (build_address_symbolic): Force signed arithmetic when computing
  84         offset.
  85
  86 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  87
  88         PR/24474: Add a function to lookup static variables.
  89         * NEWS: Mention this new function.
  90         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  91         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  92         * python/python.c (python_GdbMethods): Add new function.
  93
  94 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  95
  96         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  97         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  98         (objfpy_lookup_static_symbol): New function.
  99         (objfile_object_methods): Add new functions.
 100
 101 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 102
 103         * NEWS: Mention 'set|show print frame-info'.  Mention new
 104         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 105         backtrace argument.  Mention that python frame filtering code
 106         is now consistent with what 'backtrace' command prints.
 107
 108 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 109
 110         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 111         comments.
 112         (print_frame_info_auto, print_frame_info_source_line,
 113         print_frame_info_location, print_frame_info_source_and_location,
 114         print_frame_info_location_and_address, print_frame_info_short_location):
 115         New declarations.
 116         (struct frame_print_options): New member print_frame_info.
 117         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 118         * stack.h (get_user_print_what_frame_info): New declaration.
 119         (frame_show_address): New declaration.
 120         * stack.c (print_frame_arguments_choices): New value 'presence'.
 121         (print_frame_info_auto, print_frame_info_source_line,
 122         print_frame_info_location, print_frame_info_source_and_location,
 123         print_frame_info_location_and_address, print_frame_info_short_location,
 124         print_frame_info_choices, print_frame_info_print_what): New definitions.
 125         (print_frame_args): Only print dots for args if print frame-arguments
 126         is 'presence'.
 127         (frame_print_option_defs): New element for "frame-info".
 128         (get_user_print_what_frame_info): New function.
 129         (frame_show_address): Make non static.  Move comment to stack.h.
 130         (print_frame_info_to_print_what): New function.
 131         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 132         to decide what to print.
 133         (backtrace_command_1): Handle the new print_frame_arguments_presence
 134         value.
 135         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 136         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 137         (py_print_frame): In non-mi mode, use LOCATION as default for
 138         print_what, similarly to frame information printed directly by
 139         backtrace command. Handle frame-info user option in non MI mode.
 140
 141 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 142
 143         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 144         Add case for debugging 32-bit target on 64-bit host.  Revise
 145         comment.
 146
 147 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 148
 149         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 150         instead of find_function_entry_range_from_pc.
 151
 152 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 153
 154         * stack.c (find_frame_funname): Remove code which preferred
 155         minsym over symtab sym in "certain pathological cases".
 156
 157         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 158         parameter.  Change type of "do_demangle" to bool.
 159         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 160         Pass suitable "prefer_sym_over_minsym" flag to
 161         build_address_symbolic().  Don't output "+" for negative offsets.
 162         * printcmd.c (print_address_symbolic): Update invocation of
 163         build_address_symbolic to include a "prefer_sym_over_minsym"
 164         flag.
 165         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 166         Restrict cases in which use of minimal symbol is preferred to that
 167         of a found symbol.  Update comments.
 168
 169         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 170         for entry pc when entry pc is out of range for that FDE.
 171
 172 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 173
 174         PR gdb/24839:
 175         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 176         type.
 177
 178 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 179
 180         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 181         this function's Python signature.
 182
 183
 184 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 185
 186         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 187         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 188         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 189         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 190         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 191
 192
 193 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 194
 195         * h8300-tdep.c (h8300_register_name_common): New.
 196         h8300_register_name): Use h8300_register_name_common.
 197         (h8300s_register_name): Likewise.
 198         (h8300sx_register_name): Likewise.
 199         (h8300h_register_nam): New.
 200         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 201
 202
 203 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 204
 205         * arm-tdep.c (arm_skip_cmse_entry): New function.
 206         (arm_is_sgstubs_section): New function.
 207         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 208
 209 2019-07-22  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 212         Don't self-assign.
 213
 214 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 215
 216         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 217         type_print.
 218
 219 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 220
 221         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 222         so that GDB doesn't match any msymbols when searching in the
 223         TYPES_DOMAIN.
 224         (print_symbol_info): Print using typedef_print or type_print based
 225         on the type of the symbol.  Add updated FIXME comment moved from...
 226         (_initialize_symtab): ... move and update FIXME comment to above.
 227
 228 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 229
 230         * NEWS: Mention adding -q option to "info types".
 231         * symtab.c (struct info_types_options): New struct.
 232         (info_types_options_defs): New variable.
 233         (make_info_types_options_def_group): New function.
 234         (info_types_command): Use gdb::option framework to parse options.
 235         (info_types_command_completer): New function.
 236         (_initialize_symtab): Extend the help text on "info types" and
 237         register command completer.
 238
 239 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 240
 241         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 242         (lookup_symbol_in_objfile): Change int to block_enum and add a
 243         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 244
 245 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 246
 247         * MAINTAINERS (Write After Approval): Add self.
 248
 249 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 250
 251         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 252         instruction to the dummy code region.
 253
 254 2019-07-19  Tom Tromey  <tromey@adacore.com>
 255
 256         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 257         (ARGSUSED, PARAMS, __func__): Remove rules.
 258
 259 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 260
 261         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 262         * features/arm/arm-with-iwmmxt.c: Remove.
 263         * features/arm/arm-with-iwmmxt.xml: Remove.
 264         * features/arm/arm-with-m-fpa-layout.c: Remove.
 265         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 266         * features/arm/arm-with-m-vfp-d16.c: Remove.
 267         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 268         * features/arm/arm-with-m.c: Remove.
 269         * features/arm/arm-with-m.xml: Remove.
 270         * features/arm/arm-with-neon.c: Remove.
 271         * features/arm/arm-with-neon.xml: Remove.
 272         * features/arm/arm-with-vfpv2.c: Remove.
 273         * features/arm/arm-with-vfpv2.xml: Remove.
 274         * features/arm/arm-with-vfpv3.c: Remove.
 275         * features/arm/arm-with-vfpv3.xml: Remove.
 276
 277 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 278
 279         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 280
 281 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 282
 283         * arch/aarch32.c (aarch32_create_target_description): Create
 284         target descriptions using features.
 285         * arch/arm.c (arm_create_target_description)
 286         (arm_create_mprofile_target_description): Likewise.
 287         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 288
 289 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 290
 291         * Makefile.in: Add new files.
 292         * aarch32-tdep.c: New file.
 293         * aarch32-tdep.h: New file.
 294         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 295         Call aarch32_read_description.
 296         * arch/aarch32.c: New file.
 297         * arch/aarch32.h: New file.
 298         * arch/arm.c (arm_create_target_description)
 299         (arm_create_mprofile_target_description): New function.
 300         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 301         (arm_create_target_description)
 302         (arm_create_mprofile_target_description): New declaration.
 303         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 304         read_description functions.
 305         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 306         Likewise.
 307         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 308         * arm-tdep.c (tdesc_arm_list): New variable.
 309         (arm_register_g_packet_guesses): Call create description functions.
 310         (arm_read_description) (arm_read_mprofile_description): New
 311         function.
 312         * arm-tdep.h (arm_read_description)
 313         (arm_read_mprofile_description): Add declaration.
 314         * configure.tgt: Add new files.
 315
 316 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 317
 318         * top.c (new_ui_command): Open specified terminal just once.
 319
 320 2019-07-18  Tom Tromey  <tromey@adacore.com>
 321
 322         * symtab.c (main_name): Constify return type.
 323         * symfile.c (set_initial_language): Update.
 324         * symtab.h (main_name): Constify return type.
 325
 326 2019-07-17  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-winsource.c (tui_update_source_window)
 329         (tui_update_source_window_as_is)
 330         (tui_update_source_windows_with_line): Remove return.
 331         * tui/tui-disasm.c (tui_show_disassem)
 332         (tui_show_disassem_and_update_source): Remove return.
 333         * tui/tui.c (tui_reset): Remove return.
 334         * tui/tui-wingeneral.c
 335         (tui_check_and_display_highlight_if_needed): Remove return.
 336
 337 2019-07-17  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 340
 341 2019-07-17  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-winsource.h (struct tui_exec_info_window)
 344         (struct tui_source_window_base): Move from tui-data.h.
 345         * tui/tui-winsource.c: Move many method definitions from
 346         elsewhere.  Remove "structuring" comments.
 347         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 348         (tui_source_window_base::refresh_window): Move to
 349         tui-winsource.c.
 350         * tui/tui-win.c (tui_source_window_base::refresh_all)
 351         (tui_source_window_base::update_tab_width)
 352         (tui_source_window_base::set_new_height)
 353         (tui_source_window_base::do_make_visible_with_new_height): Move to
 354         tui-winsource.c.
 355         * tui/tui-source.h: Update.
 356         * tui/tui-source.c (tui_source_window_base::reset): Move to
 357         tui-winsource.c.
 358         * tui/tui-disasm.h: Update.
 359         * tui/tui-data.h (struct tui_exec_info_window): Move to
 360         tui-winsource.h.
 361         (struct tui_source_window_base): Likewise.
 362         * tui/tui-data.c (tui_source_window_base::clear_detail)
 363         (tui_source_window_base, ~tui_source_window_base): Move to
 364         tui-winsource.c.
 365
 366 2019-07-17  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-win.c (tui_resize_all)
 369         (tui_source_window_base::update_tab_width)
 370         (tui_adjust_win_heights): Update.
 371         (tui_win_info::make_invisible_and_set_new_height): Rename from
 372         make_invisible_and_set_new_height.
 373         * tui/tui-data.h (struct tui_win_info)
 374         <make_invisible_and_set_new_height>: New method.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui.c: Update.
 379         * tui/tui-source.h (struct tui_source_window): Move from
 380         tui-data.h.
 381         * tui/tui-layout.c: Update.
 382         * tui/tui-disasm.c: Update.
 383         * tui/tui-data.h (struct tui_source_window): Move to
 384         tui-source.h.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 389         tui-data.h.
 390         * tui/tui-data.h (struct tui_disasm_window): Move to
 391         tui-disasm.h.
 392
 393 2019-07-17  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-regs.h (struct tui_data_item_window): Move from
 396         tui-data.h.
 397         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 398         * tui/tui-data.h (struct tui_data_item_window): Move to
 399         tui-regs.h.
 400         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 401
 402 2019-07-17  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui.c: Update.
 405         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 406         (tui_cmd_window::max_height): Move to tui-command.c.
 407         * tui/tui-layout.c: Update.
 408         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 409         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 410         tui-command.c.
 411         * tui/tui-command.h (struct tui_cmd_window): Move from
 412         tui-data.h.
 413         * tui/tui-command.c: Remove "structuring" comments.
 414         (tui_cmd_window::clear_detail)
 415         (tui_cmd_window::do_make_visible_with_new_height)
 416         (tui_cmd_window::max_height): Move from elsewhere.
 417
 418 2019-07-17  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 421         Now static.
 422         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 423         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 424
 425 2019-07-17  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui.c: Update.
 428         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 429         tui-regs.c.
 430         * tui/tui-windata.h: Remove file.
 431         * tui/tui-windata.c: Remove file.
 432         * tui/tui-win.c (tui_data_window::set_new_height)
 433         (tui_data_window::do_make_visible_with_new_height): Move to
 434         tui-regs.c.
 435         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 436         * tui/tui-regs.c: Remove "structuring" comments.
 437         (tui_data_window::first_data_item_displayed)
 438         (tui_data_window::delete_data_content_windows)
 439         (tui_data_window::erase_data_content)
 440         (tui_data_window::display_all_data)
 441         (tui_data_window::refresh_all)
 442         (tui_data_window::do_scroll_vertical)
 443         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 444         (tui_data_window::do_make_visible_with_new_height)
 445         (tui_data_window::refresh_window): Move from elsewhere.
 446         (_initialize_tui_regs): Move to end of file.
 447         * tui/tui-layout.c: Update.
 448         * tui/tui-hooks.c: Update.
 449         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 450         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 451         tui-regs.c.
 452         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 453
 454 2019-07-17  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 457         seen.
 458
 459 2019-07-17  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-win.c (tui_source_window_base::set_new_height)
 462         (tui_source_window_base::do_make_visible_with_new_height): Use
 463         m_has_locator field directly.
 464         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 465         method.
 466         (struct tui_source_window_base) <has_locator>: Likewise.
 467
 468 2019-07-17  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 471         Don't declare.
 472         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 473         Remove.
 474         * tui/tui-win.c (tui_source_window_base::set_new_height)
 475         (tui_source_window_base::set_new_height)
 476         (make_invisible_and_set_new_height)
 477         (tui_source_window_base::do_make_visible_with_new_height)
 478         (tui_source_window_base::do_make_visible_with_new_height):
 479         Update.
 480         * tui/tui-layout.c (show_source_disasm_command, show_data)
 481         (show_source_or_disasm_and_command): Update.
 482         * tui/tui-layout.c (show_layout): Update.
 483
 484 2019-07-17  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-layout.c (make_data_window): Remove.
 487         (show_data): Unify creation and re-initialization cases.
 488
 489 2019-07-17  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-layout.c (make_source_window, make_disasm_window):
 492         Remove.
 493         (show_data): Unify creation and re-initialization cases.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-layout.c (make_command_window): Remove.
 498         (show_source_disasm_command, show_source_or_disasm_and_command):
 499         Unify creation and re-initialization cases.
 500
 501 2019-07-17  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 504         creation and re-initialization cases.
 505
 506 2019-07-17  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-regs.c (tui_get_register): Return void.
 509
 510 2019-07-17  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 513         Simplify.
 514
 515 2019-07-17  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 518         resetting.
 519
 520 2019-07-17  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 523         * tui/tui-regs.c (tui_reg_layout): New function.
 524         (tui_show_registers, tui_reg_command): Use it.
 525         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 526         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 527         parameters.
 528         (tui_layout_command): Remove.
 529
 530 2019-07-17  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-layout.h (tui/tui-layout): Return void.
 533         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 534
 535 2019-07-17  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-layout.c (show_source_disasm_command, show_data):
 538         Update.
 539         (reset_locator): Remove.
 540         (show_source_or_disasm_and_command): Update.
 541
 542 2019-07-17  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-source.c (tui_source_window_base::reset): Remove
 545         win_type parameter.
 546         * tui/tui-layout.c (make_command_window, make_source_window)
 547         (make_disasm_window, make_data_window)
 548         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 549         (reset_locator, show_source_or_disasm_and_command): Update.
 550         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 551         win_type parameter.
 552         (struct tui_source_window_base) <reset>: Likewise.
 553
 554 2019-07-17  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-layout.c (show_source_disasm_command): Use
 557         reset_locator.
 558         (reset_locator): New function.
 559         (init_and_make_win): Remove.
 560         (show_source_or_disasm_and_command): Use reset_locator.
 561
 562 2019-07-17  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 565         condition.
 566         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 567         Remove condition.
 568         * tui/tui-source.c (tui_source_window_base::reset): New method.
 569         * tui/tui-layout.c (make_command_window): Don't call
 570         init_and_make_win.
 571         (make_source_window, make_disasm_window): Don't call
 572         make_source_or_disasm_window.
 573         (make_data_window): Don't call init_and_make_win.  Change calling
 574         convention.
 575         (show_source_disasm_command, show_data): Simplify.
 576         (make_source_or_disasm_window): Remove.
 577         (show_source_or_disasm_and_command): Simplify.
 578         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 579         (struct tui_source_window_base) <reset>: Likewise.
 580         <execution_info>: Remove initializer.
 581         * tui/tui-data.c (tui_source_window_base): Initialize
 582         execution_info.
 583
 584 2019-07-17  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 587         variable.
 588
 589 2019-07-17  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui.c (tui_rl_other_window): Update.
 592         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 593         superclass method first.  Always iterate over regs_content.
 594         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 595         method.
 596         * tui/tui-win.c (tui_set_focus_command): Update.
 597
 598 2019-07-17  Tom Tromey  <tom@tromey.com>
 599
 600         * tui/tui-win.c (tui_set_focus_command): Rename from
 601         tui_set_focus.  Call tui_enable.
 602         (tui_set_focus_command): Remove.
 603
 604 2019-07-17  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 607         refresh_window.
 608         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 609         touchwin.
 610         (tui_data_window::refresh_window): Call refresh_window on data
 611         items.  Always call superclass refresh_window.
 612         (tui_win_info::refresh): Remove.
 613         (tui_source_window_base::refresh_window): Update.
 614         (tui_refresh_all): Update.
 615         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 616         refresh_window.
 617         (show_source_or_disasm_and_command): Likewise.
 618         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 619         (struct tui_source_window_base) <refresh>: Likewise.
 620
 621 2019-07-17  Tom Tromey  <tom@tromey.com>
 622
 623         * tui/tui-winsource.c (tui_clear_source_content)
 624         (tui_show_source_content): Update.
 625         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 626         whether content is empty.
 627         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 628         Remove.
 629
 630 2019-07-17  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 633         window's contents.
 634         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 635         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 636
 637 2019-07-17  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 640         (struct tui_data_item_window): Update.
 641
 642 2019-07-17  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 645         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 646         defines.
 647
 648 2019-07-17  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-winsource.h (tui_erase_source_content)
 651         (tui_clear_source_content): Remove "display_prompt" parameter.
 652         * tui/tui-winsource.c (tui_update_source_window_as_is)
 653         (tui_update_source_windows_with_addr): Update.
 654         (tui_clear_source_content): Remove "display_prompt" parameter.
 655         (tui_erase_source_content): Likewise.  Simplify.
 656         (tui_show_source_content): Update.
 657         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 658         * tui/tui-stack.c (tui_show_frame_info): Update.
 659         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 660         Remove defines.
 661
 662 2019-07-17  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 665         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 666         parameter.
 667         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 668         parameter.
 669
 670 2019-07-17  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui-winsource.c (tui_clear_source_content)
 673         (tui_show_source_content, tui_show_exec_info_content)
 674         (tui_clear_exec_info_content): Update.
 675         * tui/tui-stack.c (tui_show_locator_content): Update.
 676         (tui_show_frame_info): Update.
 677         * tui/tui-source.h (tui_source_window): Don't declare.
 678         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 679         from tui_source_is_displayed.
 680         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 681         Remove field.
 682         (struct tui_source_window_base) <content_in_use>: New field.  Now
 683         bool.
 684         (struct tui_source_window) <showing_source_p>: New method.
 685         (TUI_SRC_WIN): Change cast.
 686         * tui/tui-data.c (tui_initialize_static_data): Update.
 687
 688 2019-07-17  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 691         location_matches_p.
 692         * tui/tui-source.c (tui_source_window::location_matches_p): New
 693         method.
 694         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 695         method.
 696         * tui/tui-data.h (struct tui_source_window_base)
 697         <location_matches_p>: New method.
 698         (struct tui_source_window, struct tui_disasm_window)
 699         <location_matches_p>: Likewise.
 700
 701 2019-07-17  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-win.c (tui_set_win_height_command): Rename from
 704         tui_set_win_height.
 705         (tui_set_win_height_command): Remove.
 706
 707 2019-07-17  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-source.c (tui_source_window): New constructor.  Add
 710         observer.
 711         (~tui_source_window): New destructor.
 712         (tui_source_window::style_changed): New method.
 713         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 714         (tui_attach_detach_observers): Update.
 715         * tui/tui-data.h (struct tui_source_window): Make constructor not
 716         inline.  Add destructor.
 717         (struct tui_source_window) <style_changed>: New method.
 718         <m_observable>: New member.
 719
 720 2019-07-17  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 723         * tui/tui-win.c (tui_resize_all): Fix typo.
 724
 725 2019-07-17  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 728         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 729         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 730         * tui/tui-win.c (window_name_completer): Use foreach.
 731         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 732         (update_tab_width): Likewise.
 733         * tui/tui-layout.c (show_layout): Update.
 734         * tui/tui-data.h (class tui_window_iterator): New.
 735         (struct all_tui_windows): New.
 736         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 737
 738 2019-07-17  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 741         parameter.  Don't reference globals.
 742         (tui_reg_command): Update.
 743
 744 2019-07-17  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-regs.c (tui_show_registers): Simplify.
 747
 748 2019-07-17  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-regs.c (tui_show_registers): Update.
 751         (tui_show_register_group): Add win_info parameter.
 752
 753 2019-07-17  Tom Tromey  <tom@tromey.com>
 754
 755         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 756         Rename from tui_display_reg_element_at_line.
 757         (tui_data_window::display_registers_from_line): Update.
 758         * tui/tui-data.h (struct tui_data_window)
 759         <display_reg_element_at_line>: New method.
 760
 761 2019-07-17  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-regs.h (tui_display_registers_from)
 764         (tui_display_registers_from_line): Don't declare.
 765         * tui/tui-windata.c (tui_data_window::display_all_data)
 766         (tui_data_window::refresh_all)
 767         (tui_data_window::do_scroll_vertical): Update.
 768         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 769         from tui_display_registers_from.
 770         (tui_display_reg_element_at_line): Update.
 771         (tui_data_window::display_registers_from_line): Rename from
 772         tui_display_registers_from_line.
 773         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 774         display_registers_from_line>: New methods.
 775
 776 2019-07-17  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 779         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 780         from tui_erase_data_content.
 781         (tui_data_window::display_all_data)
 782         (tui_data_window::refresh_all)
 783         (tui_data_window::do_scroll_vertical): Update.
 784         * tui/tui-regs.c (tui_show_registers): Update.
 785         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 786         New method.
 787
 788 2019-07-17  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 791         declare.
 792         * tui/tui-windata.c
 793         (tui_data_window::delete_data_content_windows): Rename from
 794         tui_delete_data_content_windows.
 795         (tui_data_window::display_all_data)
 796         (tui_data_window::do_scroll_vertical): Update.
 797         * tui/tui-data.h (struct tui_data_window)
 798         <delete_data_content_windows>: New method.
 799
 800 2019-07-17  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 803         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 804
 805 2019-07-17  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 808         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 809         from tui_display_all_data.
 810         * tui/tui-win.c
 811         (tui_data_window::do_make_visible_with_new_height): Update.
 812         * tui/tui-regs.c (tui_show_registers): Update.
 813         * tui/tui-layout.c (tui_set_layout): Update.
 814         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 815         method.
 816
 817 2019-07-17  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 820         * tui/tui-windata.c (tui_display_data_from): Remove.
 821         (tui_data_window::refresh_all): Update.
 822
 823 2019-07-17  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 826         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 827         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 828         tui_display_registers_from_line.
 829         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 830         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 831         "force_display" parameter.
 832
 833 2019-07-17  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 836         declare.
 837         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 838         Rename from tui_first_reg_element_no_inline.
 839         (tui_display_reg_element_at_line)
 840         (tui_display_registers_from_line): Update.
 841         * tui/tui-data.h (struct tui_data_window)
 842         <first_reg_element_no_inline>: New method.
 843
 844 2019-07-17  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-windata.c (tui_display_data_from)
 847         (tui_data_window::do_scroll_vertical): Update.
 848         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 849         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 850         Rename from tui_line_from_reg_element_no.
 851         (tui_display_registers_from_line): Update.
 852         * tui/tui-data.h (struct tui_data_window)
 853         <line_from_reg_element_no>: New method.
 854
 855 2019-07-17  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 858         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 859         tui_last_regs_line_no.
 860         (tui_display_reg_element_at_line)
 861         (tui_display_registers_from_line): Update.
 862         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 863         method.
 864
 865 2019-07-17  Tom Tromey  <tom@tromey.com>
 866
 867         PR tui/24722:
 868         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 869         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 870         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 871         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 872         (tui_update_breakpoint_info): Likewise.
 873         * tui/tui-hooks.c (tui_event_create_breakpoint)
 874         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 875         Update.
 876
 877 2019-07-17  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 880
 881 2019-07-17  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-winsource.c (tui_update_source_window_as_is)
 884         (tui_update_source_windows_with_addr): Update.
 885         * tui/tui-source.h (tui_set_source_content)
 886         (tui_show_symtab_source): Add "win_info" parameter.
 887         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 888         parameter.
 889         (tui_show_symtab_source): Likewise.
 890
 891 2019-07-17  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-wingeneral.c
 894         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 895
 896 2019-07-17  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 899         (struct tui_cmd_window) <can_scroll>: New method.
 900         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 901         method.
 902
 903 2019-07-17  Tom Tromey  <tromey@adacore.com>
 904
 905         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 906         do_field_signed>: Rename.  Change type of "value".
 907         * ui-out.c (ui_out::field_signed): Rename from field_int.
 908         Change type of "value".
 909         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 910         type of "value".
 911         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 912         do_field_int.  Change type of "value".
 913         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 914         do_field_int.  Change type of "value".
 915         * tracepoint.c (trace_status_mi, tfind_1)
 916         (print_one_static_tracepoint_marker): Update.
 917         * thread.c (print_thread_info_1, print_selected_thread_frame):
 918         Update.
 919         * stack.c (print_frame, print_frame_info): Update.
 920         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 921         Update.
 922         * source.c (print_source_lines_base): Update.
 923         * skip.c (info_skip_command): Update.
 924         * record-btrace.c (btrace_ui_out_decode_error)
 925         (btrace_call_history_src_line): Update.
 926         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 927         Update.
 928         * progspace.c (print_program_space): Update.
 929         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 930         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 931         do_field_int.  Change type of "value".
 932         * mi/mi-out.c (mi_ui_out::do_table_begin)
 933         (mi_ui_out::do_table_header): Update.
 934         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 935         type of "value".
 936         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 937         (mi_cmd_data_list_changed_registers, output_register)
 938         (mi_cmd_data_read_memory, mi_load_progress)
 939         (mi_cmd_trace_frame_collected): Update.
 940         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 941         Update.
 942         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 943         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 944         (mi_cmd_var_list_children, varobj_update_one): Update.
 945         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 946         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 947         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 948         * inferior.c (print_inferior): Update.
 949         * gdb_bfd.c (print_one_bfd): Update.
 950         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 951         Update.
 952         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 953         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 954         do_field_int.  Change type of "value".
 955         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 956         do_field_int.  Change type of "value".
 957         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 958         (print_one_breakpoint_location, print_it_catch_fork)
 959         (print_one_catch_fork, print_it_catch_vfork)
 960         (print_one_catch_vfork, print_it_catch_solib)
 961         (print_it_catch_exec, print_it_ranged_breakpoint)
 962         (print_mention_watchpoint, print_mention_masked_watchpoint)
 963         (bkpt_print_it, update_static_tracepoint): Update.
 964         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 965         * break-catch-syscall.c (print_it_catch_syscall): Update.
 966         * ada-tasks.c (print_ada_task_info): Update.
 967         * ada-lang.c (print_it_exception, print_mention_exception):
 968         Update.
 969
 970 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 971
 972         PR breakpoints/24541
 973         * gdbarch.c: Regenerate.
 974         * gdbarch.h: Regenerate.
 975         * gdbarch.sh: Adjust return type and parameter types for
 976         'stap_adjust_register'.
 977         (i386_stap_adjust_register): Adjust signature and return new
 978         register name.
 979         * stap-probe.c (stap_parse_register_operand): Adjust use of
 980         'gdbarch_stap_adjust_register'.
 981
 982 2019-07-17  Tom Tromey  <tromey@adacore.com>
 983
 984         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 985         declare VEC.
 986         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 987         std::vector.
 988         (struct s390_process_info): Add initializers.
 989         (s390_add_process): Use new.
 990         (s390_linux_nat_target::low_forget_process): Use delete.
 991         (s390_linux_nat_target::low_new_fork)
 992         (s390_linux_nat_target::stopped_by_watchpoint)
 993         (s390_linux_nat_target::low_prepare_to_resume)
 994         (s390_linux_nat_target::insert_watchpoint)
 995         (s390_linux_nat_target::insert_hw_breakpoint)
 996         (s390_linux_nat_target::remove_watchpoint)
 997         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 998
 999 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1000
1001         * aarch64-fbsd-nat.c: Include regcache.h.
1002         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1003         argument.
1004         (aarch64_fbsd_nat_target::fetch_registers)
1005         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1006         variable.
1007         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1008
1009 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1010
1011         * fbsd-nat.c: Include gdbarch.h.
1012
1013 2019-07-15  Tom Tromey  <tromey@adacore.com>
1014
1015         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1016
1017 2019-07-15  Tom Tromey  <tromey@adacore.com>
1018
1019         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1020         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1021         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1022         * cli-out.c (cli_ui_out::do_field_int): New method.
1023         * ui-out.c (ui_out::field_unsigned): New method.
1024         * symfile.c (generic_load): Use field_unsigned.
1025         (print_transfer_performance): Likewise.
1026         * record-btrace.c (ui_out_field_uint): Remove.
1027         (btrace_call_history_insn_range, btrace_call_history): Use
1028         field_unsigned.
1029         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1030         field_unsigned.
1031         * ui-out.h (class ui_out) <field_unsigned>: New method.
1032         <do_field_unsigned>: Likewise.
1033
1034 2019-07-15  Tom Tromey  <tromey@adacore.com>
1035
1036         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1037         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1038         * target.c (flash_erase_command): Use field_string.
1039         * infrun.c (print_signal_received_reason): Use field_string.
1040         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1041         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1042         field_string.
1043         * ada-tasks.c (print_ada_task_info): Use field_string.
1044
1045 2019-07-15  Tom Tromey  <tromey@adacore.com>
1046
1047         * target.c (flash_erase_command): Use field_core_addr.
1048         * symfile.c (generic_load): Use field_core_addr.
1049         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1050         Use field_core_addr.
1051         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1052         field_core_addr.
1053
1054 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1055
1056         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1057         value if its desired type is smaller than a CORE_ADDR and signed.
1058
1059 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1062         of changes to field names, and use new is_reference field to
1063         decide if a property is a reference or not.
1064         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1065         field.
1066         (struct dwarf2_property_baton): Update header comment, rename
1067         'referenced_type' to 'property_type' and update comments.
1068         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1069         default property type, store in property baton, update to take
1070         accound of renamed field.
1071         (read_func_scope): Update call to attr_to_dynamic_prop.
1072         (read_array_type): Likewise.
1073         (dwarf2_per_cu_addr_sized_int_type): New function.
1074         (read_subrange_index_type): Move type finding code to
1075         dwarf2_per_cu_addr_sized_int_type.
1076         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1077         (dwarf2_per_cu_addr_type): New function.
1078         (set_die_type): Update calls to attr_to_dynamic_prop.
1079
1080 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * dwarf2read.c (read_subrange_index_type): New function.
1083         (read_subrange_type): Move code into new function and call it.
1084         * gdbtypes.c (create_range_type): Add some asserts.
1085
1086 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1089         update return statements.
1090         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1091         declaration, and update comment to match.
1092         * gdbtypes.c (resolve_dynamic_array): Update call to
1093         dwarf2_evaluate_property to match new return type.
1094
1095 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * valarith.c (value_subscripted_rvalue): Change lowerbound
1098         parameter type from int to LONGEST.
1099         * value.h (value_subscripted_rvalue): Likewise in declaration.
1100
1101 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1102
1103         * cli/cli-utils.c (info_print_command_completer): New function.
1104         * cli/cli-utils.h: Add 'completer.h' include, and forward
1105         declaration for 'struct cmd_list_element'.
1106         (info_print_command_completer): Declare.
1107         * stack.c (_initialize_stack): Add completer for 'info locals' and
1108         'info args'.
1109         * symtab.c (_initialize_symtab): Add completer for 'info
1110         variables' and 'info functions'.
1111         * NEWS: Mention completion for additional info commands.
1112
1113 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1114
1115         * cli/cli-utils.c (extract_info_print_args): Delete.
1116         (extract_arg_maybe_quoted): Delete.
1117         (info_print_options_defs): New variable.
1118         (make_info_print_options_def_group): New function.
1119         (extract_info_print_options): Define new function.
1120         * cli/cli-utils.h (extract_info_print_args): Delete.
1121         (struct info_print_options): New structure.
1122         (extract_info_print_options): Declare new function.
1123         * stack.c (info_locals_command): Update to use new
1124         extract_info_print_options, also add a header comment.
1125         (info_args_command): Likewise.
1126         * symtab.c (info_variables_command): Likewise.
1127         (info_functions_command): Likewise.
1128
1129 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1130
1131         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1132         to extract string arguments.
1133         * common/common-utils.c (extract_string_maybe_quoted): New function.
1134         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1135
1136 2019-07-11  Tom Tromey  <tromey@adacore.com>
1137
1138         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1139         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1140         * top.h (gdbinit): Don't declare.
1141         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1142         into...
1143         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1144         * top.c (gdb_init): Don't call init_cli_cmds.
1145         (gdbinit): Remove.
1146         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1147
1148 2019-07-11  Tom Tromey  <tromey@adacore.com>
1149
1150         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1151         after it has been moved.
1152
1153 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1154
1155         * valops.c (value_must_coerce_to_target): Change return type to
1156         bool.
1157         * value.h (value_must_coerce_to_target): Likewise.
1158
1159 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1160
1161         * breakpoint.c (is_hardware_watchpoint): Remove
1162         forward-declaration.
1163         (is_masked_watchpoint): Change return type to bool.
1164         (is_tracepoint): Likewise.
1165         (is_breakpoint): Likewise.
1166         (is_hardware_watchpoint): Likewise.
1167         (is_watchpoint): Likewise.
1168         (is_no_memory_software_watchpoint): Likewise.
1169         (is_catchpoint): Likewise.
1170         (breakpoint_1): Make FILTER parameter's return type bool.
1171         is_masked_watchpoint): Change return type to bool.
1172         (save_breakpoints): Make FILTER parameter's return type bool.
1173         * breakpoint.h (is_breakpoint): Change return type to bool.
1174         (is_watchpoint): Likewise.
1175         (is_catchpoint): Likewise.
1176         (is_tracepoint): Likewise.
1177
1178 2019-07-10  Tom Tromey  <tom@tromey.com>
1179
1180         * defs.h: Don't include gdbarch.h.
1181         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1182         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1183         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1184         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1185         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1186         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1187         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1188         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1189         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1190         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1191         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1192         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1193         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1194         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1195         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1196         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1197         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1198         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1199         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1200         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1201         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1202         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1203         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1204         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1205         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1206         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1207         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1208
1209 2019-07-10  Tom Tromey  <tromey@adacore.com>
1210
1211         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1212         * breakpoint.c (init_ada_exception_breakpoint): Register as
1213         bp_catchpoint.
1214         (print_one_breakpoint_location, print_one_breakpoint): Use
1215         is_ada_exception_catchpoint.
1216         * ada-lang.c (class ada_catchpoint_location): Pass
1217         bp_loc_software_breakpoint to bp_location constructor.
1218         (is_ada_exception_catchpoint): New function.
1219
1220 2019-07-10  Tom Tromey  <tromey@adacore.com>
1221
1222         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1223         VEC.
1224         (struct arm_exidx_entry): New method operator<.
1225         (struct arm_exidx_data) <section_maps>: Change type.
1226         (arm_exidx_data_free): Remove.
1227         (arm_exidx_data_key): Change type.  Move lower.
1228         (arm_exidx_new_objfile): Update.
1229         (arm_compare_exidx_entries): Remove.
1230         (arm_find_exidx_entry, _initialize_arm_tdep)
1231
1232 2019-07-10  Tom Tromey  <tromey@adacore.com>
1233
1234         * solib-spu.c (ocl_program_data_key): Change type.
1235         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1236         Update.
1237
1238 2019-07-10  Tom Tromey  <tromey@adacore.com>
1239
1240         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1241         (struct solib_aix_inferior_data) <library_list>: Change type.
1242         (solib_aix_inferior_data_handle): Change type.
1243         (get_solib_aix_inferior_data): Update.
1244         (solib_aix_free_library_list): Remove.
1245         (library_list_start_library): Update.
1246         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1247         return type.
1248         (solib_aix_get_library_list)
1249         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1250         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1251
1252 2019-07-10  Tom Tromey  <tromey@adacore.com>
1253
1254         * solib-dsbt.c (struct dsbt_info): Add initializers.
1255         (solib_dsbt_pspace_data): Change type.
1256         (dsbt_pspace_data_cleanup): Remove.
1257         (get_dsbt_info, _initialize_dsbt_solib): Update.
1258
1259 2019-07-10  Tom Tromey  <tromey@adacore.com>
1260
1261         * spu-tdep.c (spu_overlay_data): Change type.
1262         (spu_get_overlay_table, spu_overlay_new_objfile)
1263         (_initialize_spu_tdep): Update.
1264
1265 2019-07-10  Tom Tromey  <tromey@adacore.com>
1266
1267         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1268         destructor.
1269         (dbx_objfile_data_key): Change type and declare later.
1270         (DBX_SYMFILE_INFO): Rewrite.
1271         * dbxread.c (dbx_objfile_data_key): Change type.
1272         (dbx_symfile_init): Update.
1273         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1274         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1275         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1276
1277 2019-07-10  Tom Tromey  <tromey@adacore.com>
1278
1279         * jit.c (jit_program_space_key): Change type.  Move lower.
1280         (get_jit_program_space_data): Update.
1281         (jit_program_space_data_cleanup): Remove.
1282         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1283         Update.
1284         (struct jit_program_space_data): Add initializers.
1285
1286 2019-07-10  Tom Tromey  <tromey@adacore.com>
1287
1288         * solib-darwin.c (struct darwin_info): Add initializers.
1289         (solib_darwin_pspace_data): Change type.
1290         (darwin_pspace_data_cleanup): Remove.
1291         (get_darwin_info, _initialize_darwin_solib): Update.
1292
1293 2019-07-10  Tom Tromey  <tromey@adacore.com>
1294
1295         * remote-sim.c (struct sim_inferior_data): Add initializers,
1296         constructor, and destructor.
1297         (sim_inferior_data_key): Change type.  Move lower.
1298         (check_for_duplicate_sim_descriptor): Update.
1299         (get_sim_inferior_data): Use new.  Update.
1300         (~sim_inferior_data_cleanup): Rename from
1301         sim_inferior_data_cleanup.  Simplify.
1302         (gdbsim_close_inferior, simulator_command)
1303         (sim_command_completer, _initialize_remote_sim): Update.
1304         (next_pid, INITIAL_PID): Move earlier.
1305
1306 2019-07-10  Tom Tromey  <tromey@adacore.com>
1307
1308         * python/python-internal.h (create_thread_object): Return
1309         gdbpy_ref.
1310         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1311         * python/py-inferior.c (struct threadlist_entry): Add
1312         constructor.
1313         <thread_obj>: Now a gdbpy_ref.
1314         (thread_to_thread_object): Update.
1315         (add_thread_object): Use new.
1316         (delete_thread_object): Use delete.
1317         (infpy_threads): Update.
1318         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1319         GIL.
1320
1321 2019-07-10  Tom Tromey  <tromey@adacore.com>
1322
1323         * valops.c (value_cast): Specialize error message for Ada.
1324
1325 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1326
1327         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1328
1329 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1330
1331         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1332         bpstat_should_step): Return bool, adjust comments.
1333         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1334         bpstat_should_step): Likewise.
1335
1336 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1337
1338         * features/Makefile: Use feature target descriptions for Arm.
1339         * features/arm/arm-core.c: Generate new file.
1340         * features/arm/arm-fpa.c: Likewise.
1341         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1342         * features/arm/arm-m-profile.c: Likewise.
1343         * features/arm/arm-vfpv2.c: Likewise.
1344         * features/arm/arm-vfpv3.c: Likewise.
1345         * features/arm/xscale-iwmmxt.c: Likewise.
1346         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1347
1348 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1349
1350         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1351         ptrace earlier.
1352
1353 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1354
1355         * features/aarch64-pauth.c: Regenerate.
1356
1357 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1358
1359         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1360         bool.
1361         (bpstat_what): Use false instead of 0.
1362
1363 2019-07-09  Pedro Alves  <palves@redhat.com>
1364
1365         * break-catch-throw.c (is_exception_catchpoint): New.
1366         * breakpoint.c (print_one_breakpoint_location): New parameter
1367         'raw_loc'.  Handle it.  Use
1368         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1369         looking at the breakpoint's type.
1370         (print_one_breakpoint): If handling "maint info breakpoints", also
1371         print locations of exception catchpoints.
1372         * breakpoint.h (is_exception_catchpoint): Declare.
1373
1374 2019-07-09  Pedro Alves  <palves@redhat.com>
1375
1376         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1377         "addr" field.
1378         (allocate_location_exception_catchpoint): New.
1379         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1380         (initialize_throw_catchpoint_ops): Install
1381         allocate_location_exception_catchpoint as allocate_location
1382         method.
1383         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1384         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1385         bp_loc_other.
1386         (breakpoint_address_is_meaningful): Delete.
1387         (bl_address_is_meaningful): New.
1388         (breakpoint_locations_match): Adjust comment.
1389         (bp_location_from_bp_type): New, factored out of...
1390         (bp_location::bp_location(breakpoint *)): ... this.
1391         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1392         factored out of...
1393         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1394         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1395         breakpoint_address_is_meaningful.
1396         (bp_locations_compare): Adjust comment.
1397         (update_global_location_list): Use bl_address_is_meaningful
1398         instead of breakpoint_address_is_meaningful.
1399         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1400         explicit.
1401         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1402         * python/py-breakpoint.c (bppy_get_location): No longer check
1403         whether location is null.
1404
1405 2019-07-09  Pedro Alves  <palves@redhat.com>
1406
1407         PR c++/15468
1408         * breakpoint.c (print_one_breakpoint_location): Remove
1409         single-location assert.
1410
1411 2019-07-09  Tom Tromey  <tom@tromey.com>
1412
1413         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1414         * configure: Rebuild.
1415         * configure.ac: Change common to gdbsupport.
1416         * gdbsupport: Rename from common.
1417         * acinclude.m4: Change common to gdbsupport.
1418         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1419         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1420         gdbsupport.
1421         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1422         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1423         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1424         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1425         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1426         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1427         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1428         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1429         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1430         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1431         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1432         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1433         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1434         coff-pe-read.c, command.h, compile/compile-c-support.c,
1435         compile/compile-c.h, compile/compile-cplus-symbols.c,
1436         compile/compile-cplus-types.c, compile/compile-cplus.h,
1437         compile/compile-loc2c.c, compile/compile.c, completer.c,
1438         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1439         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1440         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1441         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1442         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1443         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1444         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1445         features/aarch64-core.c, features/aarch64-fpu.c,
1446         features/aarch64-pauth.c, features/aarch64-sve.c,
1447         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1448         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1449         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1450         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1451         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1452         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1453         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1454         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1455         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1456         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1457         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1458         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1459         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1460         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1461         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1462         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1463         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1464         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1465         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1466         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1467         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1468         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1469         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1470         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1471         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1472         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1473         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1474         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1475         minsyms.c, mips-linux-tdep.c, namespace.h,
1476         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1477         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1478         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1479         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1480         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1481         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1482         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1483         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1484         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1485         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1486         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1487         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1488         procfs.c, producer.c, progspace.h, psymtab.h,
1489         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1490         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1491         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1492         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1493         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1494         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1495         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1496         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1497         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1498         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1499         target-memory.c, target.c, target.h, target/waitstatus.c,
1500         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1501         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1502         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1503         unittests/array-view-selftests.c,
1504         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1505         unittests/common-utils-selftests.c,
1506         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1507         unittests/format_pieces-selftests.c,
1508         unittests/function-view-selftests.c,
1509         unittests/lookup_name_info-selftests.c,
1510         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1511         unittests/mkdir-recursive-selftests.c,
1512         unittests/observable-selftests.c,
1513         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1514         unittests/parse-connection-spec-selftests.c,
1515         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1516         unittests/scoped_fd-selftests.c,
1517         unittests/scoped_mmap-selftests.c,
1518         unittests/scoped_restore-selftests.c,
1519         unittests/string_view-selftests.c, unittests/style-selftests.c,
1520         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1521         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1522         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1523         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1524         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1525         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1526
1527 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1528
1529         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1530         bool value.
1531         (decode_digits_ordinary): Set explicit_line field in sal.
1532         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1533         symtab_and_line that was set on an explicit line number in
1534         assembler code.  Do always update the recorded symtab and line if
1535         we do skip the prologue.
1536
1537 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * breakpoint.c (set_breakpoint_location_function): Remove
1540         explicit_loc parameter.
1541         (momentary_breakpoint_from_master): Update call to
1542         set_breakpoint_location_function.
1543         (add_location_to_breakpoint): Likewise.
1544
1545 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1548         required features based on default bfd type when no specific bfd
1549         is present.
1550
1551 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1552
1553         * NEWS: Mention that GDB printf and eval commands can now print
1554         C-style and Ada-style convenience var strings without
1555         calling the inferior.
1556         * printcmd.c (printf_c_string): Locally print GDB internal var
1557         instead of transiting via the inferior.
1558         (printf_wide_c_string): Likewise.
1559
1560 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1561
1562         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1563
1564 2019-07-04  Tom Tromey  <tom@tromey.com>
1565
1566         PR tui/24724:
1567         * tui/tui-winsource.c (tui_clear_source_content): Update.
1568         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1569         (tui_update_breakpoint_info): Update.
1570         (tui_set_exec_info_content): Update.
1571         * tui/tui-source.c (tui_set_source_content_nil): Update.
1572         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1573         has_break.
1574         * tui/tui-data.h (enum tui_bp_flag): New.
1575         (tui_bp_flags): New enum flags type.
1576         (struct tui_source_element) <break_mode>: Change type.  Rename
1577         from has_break.
1578         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1579         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1580         constants.
1581         * tui/tui-winsource.h: Fix comment.
1582
1583 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1584
1585         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1586         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1587         (store_fpregs_to_thread)
1588         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1589         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1590         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1591         (IWMMXT_REGS_SIZE): Add define.
1592         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1593         (fetch_vfp_regs, store_vfp_regs)
1594         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1595         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1596
1597 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1598
1599         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1600         defines.
1601         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1602         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1603         (ARM_INT_REGISTER_SIZE): ...to this.
1604         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1605         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1606         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1607         (arm_linux_collect_gregset, supply_nwfpe_register)
1608         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1609         defines.
1610         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1611         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1612         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1613         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1614         (arm_return_in_memory, arm_store_return_value)
1615         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1616         (arm_record_ld_st_multiple): Likewise.
1617         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1618         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1619
1620 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1621
1622         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1623         AARCH64_DISPLACED_MODIFIED_INSNS.
1624         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1625         (aarch64_displaced_step_copy_insn): Likewise.
1626         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1627         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1628         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1629         ARM_DISPLACED_MODIFIED_INSNS.
1630         * arm-tdep.c (arm_gdbarch_init): Likewise.
1631         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1632         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1633         (struct arm_displaced_step_closure): Use
1634         ARM_DISPLACED_MODIFIED_INSNS.
1635
1636 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1637
1638         * features/Makefile: Remove unused xml files.
1639         * features/aarch64.xml: Remove.
1640         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1641         * features/i386/amd64-avx-avx512.xml: Remove.
1642         * features/i386/amd64-avx-linux.xml: Remove.
1643         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1644         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1645         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1646         * features/i386/amd64-avx-mpx.xml: Remove.
1647         * features/i386/amd64-avx.xml: Remove.
1648         * features/i386/amd64-linux.xml: Remove.
1649         * features/i386/amd64-mpx-linux.xml: Remove.
1650         * features/i386/amd64-mpx.xml: Remove.
1651         * features/i386/amd64.xml: Remove.
1652         * features/i386/i386-avx-avx512-linux.xml: Remove.
1653         * features/i386/i386-avx-avx512.xml: Remove.
1654         * features/i386/i386-avx-linux.xml: Remove.
1655         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1656         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1657         * features/i386/i386-avx-mpx-linux.xml: Remove.
1658         * features/i386/i386-avx-mpx.xml: Remove.
1659         * features/i386/i386-avx.xml: Remove.
1660         * features/i386/i386-linux.xml: Remove.
1661         * features/i386/i386-mmx-linux.xml: Remove.
1662         * features/i386/i386-mmx.xml: Remove.
1663         * features/i386/i386-mpx-linux.xml: Remove.
1664         * features/i386/i386-mpx.xml: Remove.
1665         * features/i386/i386.xml: Remove.
1666         * features/i386/x32-avx-avx512-linux.xml: Remove.
1667         * features/i386/x32-avx-linux.xml: Remove.
1668         * features/i386/x32-linux.xml: Remove.
1669
1670 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1671
1672         * regformats/aarch64.dat: Remove.
1673         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1674         * regformats/i386/amd64-avx-linux.dat: Remove.
1675         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1676         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1677         * regformats/i386/amd64-linux.dat: Remove.
1678         * regformats/i386/amd64-mpx-linux.dat: Remove.
1679         * regformats/i386/amd64.dat: Remove.
1680         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1681         * regformats/i386/i386-avx-linux.dat: Remove.
1682         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1683         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1684         * regformats/i386/i386-linux.dat: Remove.
1685         * regformats/i386/i386-mmx-linux.dat: Remove.
1686         * regformats/i386/i386-mpx-linux.dat: Remove.
1687         * regformats/i386/i386.dat: Remove.
1688         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1689         * regformats/i386/x32-avx-linux.dat: Remove.
1690         * regformats/i386/x32-linux.dat: Remove.
1691
1692 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1693
1694         * aarch64-tdep.c: Remove xml self tests.
1695         * amd64-linux-tdep.c: Likewise.
1696         * amd64-tdep.c: Likewise.
1697         * i386-linux-tdep.c: Likewise.
1698         * i386-tdep.c: Likewise.
1699
1700 2019-07-03  Pedro Alves  <palves@redhat.com>
1701
1702         PR cli/24732
1703         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1704         (pipe_cmd_option_defs): New.
1705         (make_pipe_cmd_options_def_group): New.
1706         (pipe_command): Use gdb::option::process_options.
1707         (pipe_command_completer): New function.
1708         (_initialize_cli_cmds): Install completer for "pipe" command.
1709
1710 2019-07-03  Pedro Alves  <palves@redhat.com>
1711
1712         * cli/cli-option.c (union option_value) <string>: New field.
1713         (struct option_def_and_value): Add ctor, move ctor, dtor and
1714         use DISABLE_COPY_AND_ASSIGN.
1715         (option_def_and_value::clear_value): New.
1716         (parse_option, save_option_value_in_ctx, get_val_type_str)
1717         (add_setshow_cmds_for_options): Handle var_string.
1718         * cli-option.h (union option_def::var_address) <string>: New
1719         field.
1720         (struct string_option_def): New.
1721         * maint-test-options.c (struct test_options_opts): Add default
1722         ctor and use DISABLE_COPY_AND_ASSIGN.
1723         <string_opt>: New field.
1724         (test_options_opts::~test_options_opts): New.
1725         (test_options_opts::dump): Also dump "-string".
1726         (test_options_option_defs): Install "string.
1727
1728 2019-07-03  Pedro Alves  <palves@redhat.com>
1729
1730         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1731         option_value with a null enumeration.
1732         (complete_options): Save the option values in the context.
1733         (save_option_value_in_ctx): New, factored out from ...
1734         (process_options): ... here.
1735         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1736         of the function.
1737         * maint-test-options.c (test_options_opts::dump): New, factored
1738         out from ...
1739         (maintenance_test_options_command_mode): ... here.
1740         (maintenance_test_options_command_completion_result): Delete.
1741         (maintenance_test_options_command_completion_text): Update
1742         comment.
1743         (maintenance_show_test_options_completion_result): Change
1744         prototype.  Just print
1745         maintenance_test_options_command_completion_text.
1746         (save_completion_result): New.
1747         (maintenance_test_options_completer_mode): Pass options context to
1748         complete_options, and then save a dump.
1749         (_initialize_maint_test_options): Use add_cmd to install "maint
1750         show test-options-completion-result".
1751
1752 2019-07-03  Pedro Alves  <palves@redhat.com>
1753
1754         * NEWS (New commands): Mention "with" and "maint with".
1755         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1756         (with_command, with_command_completer): New.
1757         (pipe_command): Adjust to new repeat_previous
1758         interface.
1759         (_initialize_cli_cmds): Install the "with" command and its "w"
1760         alias.
1761         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1762         declarations.
1763         * cli/cli-setshow.c (parse_cli_var_uinteger)
1764         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1765         argument strings for all var_types.
1766         (get_setshow_command_value_string): New, factored out from ...
1767         (do_show_command): ... this.
1768         * cli/cli-setshow.h: Include <string>.
1769         (get_setshow_command_value_string): Declare.
1770         * command.h (repeat_previous): Now returns const char *.  Adjust
1771         comment.
1772         * maint.c: Include "cli/cli-cmds.h".
1773         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1774         (_initialize_maint_cmds): Register the "maintenance with" command.
1775         * top.c (repeat_previous): Move bits from pipe_command here:
1776         Return the saved command line, if any; error out if there's no
1777         command to relaunch.
1778
1779 2019-07-03  Pedro Alves  <palves@redhat.com>
1780
1781         * NEWS (New commands): Mention "maint set/show test-settings"
1782         instead of "maint test-settings".
1783         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1784         (maintenance_test_settings_set_list): Rename to ...
1785         (maintenance_set_test_settings_list): ... this.
1786         (maintenance_test_settings_show_list): Rename to  ...
1787         (maintenance_show_test_settings_list): ... this.
1788         (maintenance_test_settings_cmd): Delete.
1789         (maintenance_test_settings_set_cmd): ...
1790         (maintenance_set_test_settings_cmd): ... this.
1791         (maintenance_test_settings_show_cmd): ...
1792         (maintenance_show_test_settings_cmd): ... this.
1793         (maintenance_test_settings_show_value_cmd):
1794         (maintenance_show_test_settings_value_cmd): ... this.
1795         (_initialize_maint_test_settings): No longer install the "maint
1796         test-settings" prefix command.  Rename "maint test-settings set"
1797         to "maint set test-settings", and "maint test-settings show" to
1798         "maint show test-settings".  Adjust all subcommands.
1799
1800 2019-07-03  Pedro Alves  <palves@redhat.com>
1801
1802         * maint-test-settings.c: Fix file's intro comment.  Replace all
1803         references to "test-options" with references to "test-settings",
1804         in comments.
1805
1806 2019-07-03  Pedro Alves  <palves@redhat.com>
1807
1808         * maint-test-settings.c (maintenance_test_settings_xxx)
1809         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1810         New.
1811         (maintenance_test_settings_enums): Use them.
1812         (maintenance_test_settings_enum): Default to
1813         maintenance_test_settings_xxx.
1814         (_initialize_maint_test_settings): Initialize
1815         MAINTENANCE_TEST_SETTINGS_FILENAME.
1816
1817 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1818
1819         * breakpoint.h (remove_breakpoints_inf): Change return type to
1820         void, move function documentation here.
1821         * breakpoint.c (remove_breakpoints_inf): Change return type to
1822         void, move function documentation to header.
1823
1824 2019-07-02  Pedro Alves  <palves@redhat.com>
1825
1826         * NEWS (Completion improvements): Mention "info threads".
1827         * thread.c (struct info_threads_opts, info_threads_option_defs)
1828         (make_info_threads_options_def_group): New.
1829         (info_threads_command): Use gdb::option::process_options.
1830         (info_threads_command_completer): New.
1831         (_initialize_thread): Use gdb::option::build_help to build the
1832         help text for "info threads".
1833
1834 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1835
1836         * defs.h (generic_load): Move from here...
1837         * symfile.h (generic_load): ... to here.  Rename name parameter
1838         to args.
1839         * symfile.c (generic_load): Add comment.
1840
1841 2019-07-01  Tom Tromey  <tromey@adacore.com>
1842
1843         * dwarf2read.c
1844         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1845         declaration of without_params.  Fix formatting.
1846
1847 2019-07-01  Tom Tromey  <tromey@adacore.com>
1848
1849         * ada-exp.y (find_primitive_type): Update.
1850         * ada-lang.h (ada_lookup_symbol): Update.
1851         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1852         parameter.
1853         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1854
1855 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1856
1857         PR breakpoints/24541
1858         * gdbarch.c: Regenerate.
1859         * gdbarch.h: Regenerate.
1860         * gdbarch.sh: Add 'stap_adjust_register'.
1861         * i386-tdep.c: Include '<unordered_set>'.
1862         (i386_stap_adjust_register): New function.
1863         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1864         * stap-probe.c (stap_parse_register_operand): Call
1865         'gdbarch_stap_adjust_register'.
1866
1867 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1868
1869         PR python/24742
1870         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1871         * python/python.c (do_start_initialization): Use 'xmalloc'
1872         instead of 'PyMem_Malloc'.
1873
1874 2019-06-28  Tom Tromey  <tromey@adacore.com>
1875
1876         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1877         for Ada.
1878
1879 2019-06-27  Tom Tromey  <tromey@adacore.com>
1880
1881         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1882         objfile_key.
1883         (arm_find_mapping_symbol, arm_record_special_symbol)
1884         (_initialize_arm_tdep): Update.
1885         (arm_objfile_data_free): Remove.
1886
1887 2019-06-27  Tom Tromey  <tromey@adacore.com>
1888
1889         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1890         to cp_print_static_field.
1891
1892 2019-06-26  Tom Tromey  <tromey@adacore.com>
1893
1894         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1895         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1896         declare.
1897
1898 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1899
1900         * features/aarch64-core.c (create_feature_aarch64_core):
1901         Regenerate.
1902         * features/aarch64-core.xml: Add cpsr flags.
1903
1904 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1905
1906         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1907         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1908
1909 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1910
1911         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1912         field.
1913         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1914         use.
1915         (arm_record_special_symbol): Don't insert new symbol in sorted
1916         position, push it at the end.
1917
1918 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1919
1920         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1921         (arm_mapping_symbol_s): Remove.
1922         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1923         (arm_mapping_symbol_vec): New typedef.
1924         (struct arm_per_objfile): Add constructor.
1925         <section_maps>: Change type to
1926         std::unique_ptr<arm_mapping_symbol_vec[]>.
1927         (arm_compare_mapping_symbols): Remove.
1928         (arm_find_mapping_symbol): Adjust to section_maps type change.
1929         (arm_objfile_data_free): Call delete on arm_per_objfile.
1930         (arm_record_special_symbol): Adjust to section_maps type change.
1931         Allocate arm_per_objfile with new.
1932
1933 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1934
1935         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1936         with the command prefix.
1937
1938 2019-06-25  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1941         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1942
1943 2019-06-25  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1946         type.
1947         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1948         protected.
1949
1950 2019-06-25  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-winsource.c
1953         (tui_source_window_base::set_is_exec_point_at): Add check against
1954         LOA_ADDRESS.
1955
1956 2019-06-25  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-source.c (tui_set_source_content): Don't check before
1959         xfree.
1960         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1961
1962 2019-06-25  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-winsource.h (tui_update_source_window_as_is)
1965         (tui_alloc_source_buffer, tui_line_is_displayed)
1966         (tui_addr_is_displayed): Change type of win_info.
1967         * tui/tui-winsource.c (tui_update_source_window_as_is)
1968         (tui_clear_source_content, tui_show_source_line)
1969         (tui_show_source_content, tui_source_window_base::refill)
1970         (tui_source_window_base::set_is_exec_point_at)
1971         (tui_source_window_base::set_is_exec_point_at)
1972         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1973         (tui_alloc_source_buffer, tui_line_is_displayed)
1974         (tui_addr_is_displayed): Change type of win_info.  Update.
1975         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1976         (tui_source_window_base::do_make_visible_with_new_height):
1977         Update.
1978         * tui/tui-source.c (tui_set_source_content)
1979         (tui_set_source_content_nil)
1980         (tui_source_window::do_scroll_vertical): Update.
1981         * tui/tui-layout.c (show_layout): Update.
1982         * tui/tui-disasm.c (tui_set_disassem_content)
1983         (tui_disasm_window::do_scroll_vertical): Update.
1984         * tui/tui-data.h (tui_win_content): Remove.
1985         (struct tui_gen_win_info) <content, content_size>: Remove.
1986         (struct tui_source_element): Add initializers and destructor.
1987         (union tui_which_element, struct tui_win_element): Remove.
1988         (struct tui_source_window_base) <content>: New field.
1989         (struct tui_data_window): Remove destructor.
1990         (tui_alloc_content, tui_free_win_content)
1991         (tui_free_all_source_wins_content): Don't declare.
1992         * tui/tui-data.c (tui_initialize_static_data): Update.
1993         (init_content_element, tui_alloc_content): Remove.
1994         (~tui_gen_win_info): Update.
1995         (~tui_data_window, tui_free_all_source_wins_content)
1996         (tui_free_win_content, free_content, free_content_elements):
1997         Remove.
1998
1999 2019-06-25  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-winsource.h (tui_clear_source_content)
2002         (tui_erase_source_content, tui_show_source_content): Change type
2003         of win_info.
2004         * tui/tui-winsource.c (tui_clear_source_content)
2005         (tui_erase_source_content, tui_show_source_content): Change type
2006         of win_info.
2007         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2008         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2009         win_info.
2010         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2011         win_info.
2012         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2013
2014 2019-06-25  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-winsource.c (tui_clear_source_content)
2017         (tui_source_window_base::set_is_exec_point_at): Update.
2018         * tui/tui-source.c (tui_set_source_content_nil): Update.
2019         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2020         a bool.
2021         * tui/tui-data.c (init_content_element): Update.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2026         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2027         * tui/tui-layout.c (init_and_make_win): Update.
2028         * tui/tui.h (enum tui_win_type): Update.
2029         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2030         tui_win_is_auxillary.
2031         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2032         tui_win_is_auxillary.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2037         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2038         (tui_delete_data_content_windows, tui_display_all_data)
2039         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2040         Update.
2041         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2042         * tui/tui-regs.c (tui_last_regs_line_no)
2043         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2044         (tui_show_registers): Update.
2045         (tui_show_register_group): Return void.  Update.
2046         (tui_display_registers_from, tui_display_reg_element_at_line)
2047         (tui_display_registers_from_line, tui_check_register_values):
2048         Update.
2049         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2050         member.
2051         (struct tui_data_window) <regs_content>: Now a std::vector.
2052         <regs_content_count>: Remove.
2053         (tui_add_content_elements, tui_free_data_content): Don't declare.
2054         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2055         (init_content_element): Remove DATA_WIN case.  Add assert.
2056         (tui_add_content_elements): Remove.
2057         (tui_data_window): Update.
2058         (tui_free_data_content): Remove.
2059         (free_content_elements): Remove DATA_WIN case.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-data.c (tui_data_item_window): Update.
2064         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2065         * tui/tui-windata.c (tui_display_all_data)
2066         (tui_display_data_from_line): Update.
2067         (tui_check_data_values): Remove.
2068         * tui/tui-regs.c (tui_show_register_group)
2069         (tui_display_reg_element_at_line): Update.
2070         * tui/tui-hooks.c (tui_register_changed)
2071         (tui_refresh_frame_and_register_information): Call
2072         tui_check_register_values.
2073         * tui/tui-data.h (struct tui_data_window) <data_content,
2074         data_content_count, data_type>: Remove.
2075         (enum tui_data_type): Remove.
2076
2077         * tui/tui-data.c (tui_data_window::clear_detail)
2078         (~tui_data_window): Update.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2083         declare.
2084         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2085         Rename from tui_first_data_item_displayed.  Update.
2086         (tui_data_window::refresh_all)
2087         (tui_data_window::do_scroll_vertical): Update.
2088         * tui/tui-data.h (struct tui_data_window)
2089         <first_data_item_displayed>: Declare new method.
2090
2091 2019-06-25  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2094         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2095         contents...
2096         (tui_initialize_static_data): ...here.
2097
2098 2019-06-25  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2101         (tui_display_registers_from, tui_check_register_values): Update.
2102         (tui_display_register): Remove win_info parameter; update.
2103         (tui_get_register): Change type of parameters.
2104         * tui/tui-data.h (struct tui_data_element): Remove.
2105         (union tui_which_element) <data>: Remove.
2106         <data_window>: Change type.
2107         (struct tui_data_item_window): New.
2108         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2109         case.  Add assert.
2110         (~tui_data_item_window): New destructor.
2111         (free_content_elements): Remove DATA_ITEM_WIN case.
2112
2113 2019-06-25  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2116         Remove.
2117
2118 2019-06-25  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-data.h (struct tui_command_element): Remove.
2121         (union tui_which_element) <command>: Remove.
2122         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2123         assert.
2124         (free_content_elements): Remove CMD_WIN case.
2125
2126 2019-06-25  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-layout.c (tui_set_layout): Update.
2129         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2130         * tui/tui-data.c (layout_def): Update.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2135         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2136         (tui_source_window_base::set_new_height): Update.
2137         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2138         Update.
2139         (tui_set_locator_fullname, tui_set_locator_info)
2140         (tui_show_frame_info): Update.
2141         * tui/tui-source.c (tui_set_source_content)
2142         (tui_source_is_displayed): Update.
2143         * tui/tui-layout.c (show_source_disasm_command, show_data)
2144         (show_source_or_disasm_and_command): Update.
2145         * tui/tui-disasm.c (tui_set_disassem_content)
2146         (tui_get_begin_asm_address): Update.
2147         * tui/tui-data.h (struct tui_locator_element): Remove.
2148         (union tui_which_element) <locator>: Remove.
2149         (struct tui_locator_window): New.
2150         (tui_locator_win_info_ptr): Change return type.
2151         * tui/tui-data.c (_locator): Change type.
2152         (tui_locator_win_info_ptr): Change return type.
2153         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2154         (tui_alloc_content): Add assert.
2155
2156 2019-06-25  Tom Tromey  <tom@tromey.com>
2157
2158         * tui/tui-winsource.c
2159         (tui_exec_info_window::maybe_allocate_content): New method.
2160         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2161         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2162         (make_source_or_disasm_window): Add cast.
2163         * tui/tui-data.h (union tui_which_element) <simple_string>:
2164         Remove.
2165         (struct tui_source_info): New.
2166         (struct tui_source_window_base) <execution_info>: Change type.
2167         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2168         case, and add assert.
2169         (tui_alloc_content): Add assert.
2170
2171 2019-06-25  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2174         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2175         * tui/tui-data.c (tui_alloc_win_info): Remove.
2176
2177 2019-06-25  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2180         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2181         can_highlight.
2182
2183 2019-06-25  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2186         make_visible_with_new_height method.
2187         (tui_win_info::make_visible_with_new_height): New method.
2188         (tui_source_window_base::do_make_visible_with_new_height)
2189         (tui_data_window::do_make_visible_with_new_height)
2190         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2191         (make_visible_with_new_height): Remove.
2192         (tui_resize_all, tui_adjust_win_heights): Use
2193         make_visible_with_new_height method.
2194         * tui/tui-data.h (struct tui_win_info)
2195         <do_make_visible_with_new_height, make_visible_with_new_height>:
2196         New methods.
2197         (struct tui_source_window_base, struct tui_data_window)
2198         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2199         methods.
2200
2201 2019-06-25  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2204         method.
2205         (update_tab_width): Call update_tab_width method.
2206         * tui/tui-data.h (struct tui_win_info)
2207         (struct tui_source_window_base) <update_tab_width>: New methods.
2208
2209 2019-06-25  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2212         parameter.
2213         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2214         parameter.
2215         (tui_gen_win_info::make_visible): Update.
2216         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2217         parameter.
2218         * tui/tui-data.h (enum tui_box): New enum.
2219         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2220
2221 2019-06-25  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2224         init_and_make_win for EXEC_INFO_WIN.
2225         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2226         longer inline.
2227         (struct tui_win_info) <~tui_win_info>: Inline.
2228         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2229         Don't declare.
2230         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2231         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2232         Remove.
2233         (tui_initialize_static_data): Update.
2234         (~tui_gen_win_info): Handle more cleanup here.
2235         (~tui_source_window_base): Delete "execution_info".
2236         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2237
2238 2019-06-25  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-layout.c (make_command_window): Don't set
2241         can_highlight.
2242         (show_source_disasm_command): Call the reset method.
2243         (show_data): Don't set can_highlight.  Call the reset method.
2244         (tui_gen_win_info::reset): Rename from init_gen_win_info
2245         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2246         (show_source_or_disasm_and_command): Call the reset method.
2247         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2248         (struct tui_cmd_window): Set can_highlight.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2253         from make_visible.
2254         (tui_make_visible, tui_make_invisible): Rewrite.
2255         (tui_win_info::make_visible): Remove.
2256         (tui_source_window_base::make_visible): Update.
2257         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2258         method.  Moved from...
2259         (struct tui_win_info) <make_visible>: ...here.
2260
2261 2019-06-25  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-winsource.c
2264         (tui_source_window_base::do_scroll_horizontal): Remove direction
2265         parameter.
2266         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2267         direction parameter.
2268         * tui/tui-win.c (tui_win_info::forward_scroll)
2269         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2270         (tui_win_info::right_scroll): Update.
2271         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2272         direction parameter.
2273         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2274         direction parameter.
2275         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2276         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2277         Remove direction parameter.
2278         (struct tui_source_window_base, struct tui_source_window)
2279         (struct tui_disasm_window, struct tui_data_window)
2280         (struct tui_cmd_window): Update.
2281
2282 2019-06-25  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-winsource.h (tui_set_exec_info_content)
2285         (tui_show_exec_info_content, tui_erase_exec_info_content)
2286         (tui_clear_exec_info_content, tui_update_exec_info): Change
2287         argument to tui_source_window_base.
2288         * tui/tui-winsource.c (tui_set_exec_info_content)
2289         (tui_show_exec_info_content, tui_erase_exec_info_content)
2290         (tui_clear_exec_info_content, tui_update_exec_info): Change
2291         argument to tui_source_window_base.
2292
2293 2019-06-25  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2296         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2297
2298 2019-06-25  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2301         check.
2302
2303 2019-06-25  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2306         type to void.
2307         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2308         type to void.
2309         * tui/tui-source.c (tui_set_source_content): Update.
2310         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2311
2312 2019-06-25  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-win.c (window_name_completer, tui_set_focus)
2315         (tui_all_windows_info): Use name method.
2316         * tui/tui-data.h (struct tui_gen_win_info)
2317         (struct tui_source_window, struct tui_disasm_window)
2318         (struct tui_data_window, struct tui_cmd_window) <name>: New
2319         method.
2320         (tui_win_name): Don't declare.
2321         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2322         (tui_win_name): Remove.
2323
2324 2019-06-25  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-winsource.h (tui_update_source_window)
2327         (tui_update_source_window_as_is): Change parameter type.
2328         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2329         to be a tui_source_window_base.
2330         (tui_update_source_window_as_is): Likewise.
2331         * tui/tui-win.c (make_visible_with_new_height): Update.
2332
2333 2019-06-25  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-winsource.c (tui_erase_source_content)
2336         (tui_show_source_content, tui_show_exec_info_content)
2337         (tui_erase_exec_info_content): Use refresh_window method.
2338         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2339         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2340         from tui_refresh_win.
2341         (tui_data_window::refresh_window): New method.
2342         (tui_win_info::refresh, tui_source_window_base::refresh)
2343         (tui_refresh_all): Use refresh_window method.
2344         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2345         method.
2346         * tui/tui-regs.c (tui_display_register): Call refresh_window
2347         method.
2348         * tui/tui-layout.c (show_source_disasm_command)
2349         (show_source_or_disasm_and_command): Call refresh_window method.
2350         * tui/tui-data.h (struct tui_gen_win_info)
2351         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2352         New method.
2353
2354 2019-06-25  Tom Tromey  <tom@tromey.com>
2355
2356         * tui/tui.c (tui_rl_other_window, tui_enable)
2357         (tui_is_window_visible, tui_get_command_dimension): Update.
2358         * tui/tui-winsource.c (tui_update_source_window_as_is)
2359         (tui_clear_source_content, tui_erase_source_content)
2360         (tui_show_source_line, tui_source_window_base::refill)
2361         (tui_source_window_base::do_scroll_horizontal)
2362         (tui_source_window_base::set_is_exec_point_at)
2363         (tui_update_breakpoint_info, tui_set_exec_info_content)
2364         (tui_alloc_source_buffer, tui_line_is_displayed)
2365         (tui_addr_is_displayed): Update.
2366         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2367         (tui_check_and_display_highlight_if_needed)
2368         (tui_win_info::make_visible, tui_win_info::refresh)
2369         (tui_refresh_all): Update.
2370         * tui/tui-windata.c (tui_first_data_item_displayed)
2371         (tui_delete_data_content_windows, tui_erase_data_content)
2372         (tui_display_all_data, tui_data_window::refresh_all)
2373         (tui_check_data_values): Update.
2374         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2375         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2376         (tui_win_info::backward_scroll, tui_refresh_all_win)
2377         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2378         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2379         (tui_source_window_base::set_new_height)
2380         (tui_data_window::set_new_height)
2381         (make_invisible_and_set_new_height)
2382         (make_visible_with_new_height, new_height_ok)
2383         (parse_scrolling_args): Update.
2384         * tui/tui-stack.c (tui_show_frame_info): Update.
2385         * tui/tui-source.c (tui_set_source_content)
2386         (tui_set_source_content_nil, tui_source_is_displayed)
2387         (tui_source_window::do_scroll_vertical): Update.
2388         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2389         (tui_display_registers_from, tui_display_reg_element_at_line)
2390         (tui_check_register_values, tui_reg_command): Update.
2391         * tui/tui-layout.c (tui_default_win_height)
2392         (show_source_disasm_command, show_data, init_and_make_win)
2393         (show_source_or_disasm_and_command): Update.
2394         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2395         (tui_redisplay_readline, tui_mld_flush)
2396         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2397         (tui_getc): Update.
2398         * tui/tui-disasm.c (tui_set_disassem_content)
2399         (tui_disasm_window::do_scroll_vertical): Update.
2400         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2401         Now virtual.
2402         (struct tui_win_info): Derive from tui_gen_win_info.
2403         <~tui_win_info>: Mark as override.
2404         <generic>: Remove member.
2405         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2406         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2407         (~tui_data_window, ~tui_win_info)
2408         (tui_free_all_source_wins_content): Update.
2409         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2410
2411 2019-06-25  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-layout.c (init_and_make_win): Use new.
2414         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2415         destructor, initializers.
2416         (tui_alloc_generic_win_info): Don't declare.
2417         * tui/tui-data.c (_locator): Add argument to constructor.
2418         (source_win, disasm_win): New globals.
2419         (exec_info): Remove.
2420         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2421         Update.
2422         (tui_alloc_generic_win_info): Remove.
2423         (init_content_element): Use new.
2424         (tui_win_info::tui_win_info): Update.
2425         (free_content_elements) <case DATA_WIN>: Use delete.
2426
2427 2019-06-25  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2430         * tui/tui-windata.c (tui_first_data_item_displayed)
2431         (tui_delete_data_content_windows): Update.
2432         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2433         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2434         (tui_display_registers_from, tui_check_register_values): Update.
2435         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2436         pointer.
2437         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2438         window.
2439         (tui_free_data_content): Update.
2440         (free_content_elements) <case DATA_WIN>: Free the window.
2441
2442 2019-06-25  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2445         Update.
2446         * tui/tui-layout.c (make_command_window)
2447         (show_source_disasm_command, show_data, init_and_make_win)
2448         (show_source_or_disasm_and_command): Update.
2449         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2450         method.
2451         <can_highight, is_highlighted>: Now bool.
2452         (tui_set_win_highlight): Don't declare.
2453         * tui/tui-data.c (tui_set_win_highlight): Remove.
2454
2455 2019-06-25  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-wingeneral.c (make_visible): Remove check of window
2458         type.
2459
2460 2019-06-25  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-win.c (tui_win_info::max_height)
2463         (tui_cmd_window::max_height): New methods.
2464         (new_height_ok): Call max_height.
2465         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2466         <max_height>: New method.
2467
2468 2019-06-25  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-win.c (tui_source_window_base::set_new_height)
2471         (tui_data_window::set_new_height): New methods.
2472         (make_invisible_and_set_new_height): Call set_new_height method.
2473         * tui/tui-data.h (struct tui_win_info)
2474         (struct tui_source_window_base, struct tui_data_window)
2475         <set_new_height>: New method.
2476
2477 2019-06-25  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2480         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2481         tui_refresh_data_win.
2482         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2483         method.
2484         (tui_refresh_all_win): Call the refresh_all method.
2485         (tui_set_focus): Likewise.
2486         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2487         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2488         Likewise.
2489
2490 2019-06-25  Tom Tromey  <tom@tromey.com>
2491
2492         * tui/tui-winsource.h (tui_refill_source_window)
2493         (tui_set_is_exec_point_at): Don't declare.
2494         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2495         (tui_source_window_base::refill): Rename from
2496         tui_refill_source_window.
2497         (tui_source_window_base::do_scroll_horizontal): Update.
2498         (tui_source_window_base::set_is_exec_point_at): Rename from
2499         tui_set_is_exec_point_at.
2500         (tui_update_all_breakpoint_info): Update.
2501         * tui/tui-stack.c (tui_show_frame_info): Update.
2502         * tui/tui-layout.c (show_data): Add cast.
2503         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2504         * tui/tui-data.h (struct tui_source_window_base) <refill,
2505         set_is_exec_point_at>: New methods.
2506         (tui_source_windows, tui_add_to_source_windows): Update types.
2507         (tui_add_to_source_windows): Remove redundant declaration.
2508         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2509         (tui_source_windows): Change return type.
2510         (tui_clear_source_windows_detail): Update.
2511         (tui_add_to_source_windows): Change type of parameter.
2512         (tui_free_all_source_wins_content): Update.
2513
2514 2019-06-25  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-wingeneral.c (tui_win_info::refresh)
2517         (tui_source_window_base::refresh): New methods.
2518         (tui_refresh_all): Call the refresh method.
2519         * tui/tui-data.h (struct tui_win_info)
2520         (struct tui_source_window_base) <refresh>: New method.
2521
2522 2019-06-25  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui.h (tui_is_window_visible): Return bool.
2525         * tui/tui.c (tui_is_window_visible): Return bool.
2526         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2527         (tui_make_visible, tui_make_invisible)
2528         (tui_win_info::make_visible)
2529         (tui_source_window_base::make_visible, make_all_visible)
2530         (tui_make_all_visible, tui_make_all_invisible): Update.
2531         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2532         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2533         bool.
2534         (struct tui_win_info, struct tui_source_window_base)
2535         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2536         * tui/tui-data.c (tui_init_generic_part): Update.
2537
2538 2019-06-25  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2541         (tui_source_window_base::make_visible): New methods.
2542         (make_all_visible): Make method call.
2543         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2544         (struct tui_source_window_base, struct tui_cmd_window): Override
2545         make_visible.
2546         (tui_win_is_source_type): Don't declare.
2547         * tui/tui-data.c (tui_win_is_source_type): Remove.
2548
2549 2019-06-25  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2552         NULL check.
2553
2554 2019-06-25  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2557         Inline constructor.  Add initializers for members.
2558         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2559         constructors; now inline in class.
2560
2561 2019-06-25  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-regs.c (tui_show_registers): Update.
2564         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2565         bool.
2566         * tui/tui-data.c (tui_data_window::clear_detail)
2567         (tui_data_window): Update.
2568
2569 2019-06-25  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui-windata.c (tui_display_all_data)
2572         (tui_display_data_from_line, tui_display_data_from)
2573         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2574         Update.
2575         * tui/tui-regs.c (tui_last_regs_line_no)
2576         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2577         (tui_show_registers, tui_show_register_group)
2578         (tui_display_registers_from, tui_display_reg_element_at_line)
2579         (tui_display_registers_from_line, tui_check_register_values)
2580         (tui_reg_next, tui_reg_prev): Update.
2581         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2582         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2583         tui_data_window.
2584         (struct tui_win_info) <detail>: Remove.  Add new fields from
2585         tui_data_info.
2586         (TUI_DATA_WIN): Add cast.
2587         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2588         (~tui_data_window): Simplify.
2589
2590 2019-06-25  Tom Tromey  <tom@tromey.com>
2591
2592         * tui/tui-layout.c (show_source_disasm_command)
2593         (show_source_or_disasm_and_command): Update.
2594         * tui/tui-io.c (update_cmdwin_start_line)
2595         (tui_redisplay_readline): Update.
2596         * tui/tui-data.h (struct tui_command_info): Remove.
2597         (struct tui_win_info) <detail>: Remove command_info member.
2598         (struct tui_data_window) <start_line>: New member, from
2599         tui_command_info.
2600         (TUI_CMD_WIN): Add casts.
2601
2602 2019-06-25  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-winsource.c (tui_update_source_window)
2605         (tui_refill_source_window)
2606         (tui_source_window_base::do_scroll_horizontal)
2607         (tui_update_breakpoint_info, tui_set_exec_info_content)
2608         (tui_show_exec_info_content, tui_erase_exec_info_content)
2609         (tui_clear_exec_info_content): Update.
2610         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2611         Update.
2612         * tui/tui-win.c (make_invisible_and_set_new_height)
2613         (make_visible_with_new_height): Update.
2614         * tui/tui-source.c (tui_set_source_content)
2615         (tui_show_symtab_source): Update.
2616         * tui/tui-layout.c (extract_display_start_addr)
2617         (show_source_disasm_command, show_data)
2618         (make_source_or_disasm_window)
2619         (show_source_or_disasm_and_command): Update.
2620         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2621         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2622         "gdbarch".
2623         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2624         to tui_source_window_base.
2625         (struct tui_win_info) <detail>: Remove source_info member.
2626         (struct tui_source_window_base) <has_locator>: Inline.
2627         Move contents from tui_source_info; rename has_locator member to
2628         m_has_locator.
2629         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2630         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2631         header file.
2632         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2633         Simplify.
2634         (tui_free_all_source_wins_content): Cast to
2635         tui_source_window_base.
2636
2637 2019-06-25  Tom Tromey  <tom@tromey.com>
2638
2639         * tui/tui-win.c (make_invisible_and_set_new_height)
2640         (make_visible_with_new_height): Call has_locator method.
2641         * tui/tui-layout.c (show_source_disasm_command, show_data)
2642         (show_source_or_disasm_and_command): Update for bool change.
2643         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2644         (tui_win_info) <has_locator>: New method.
2645         (struct tui_source_window_base) <has_locator>: New method.
2646         (tui_win_has_locator): Don't declare.
2647         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2648         from tui_win_has_locator.
2649         (tui_source_window_base): Use false, not FALSE.
2650
2651 2019-06-25  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2654         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2655         clear_detail method directly.
2656         (tui_clear_win_detail): Remove.
2657
2658 2019-06-25  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2661         "this", not TUI_DISASM_WIN.
2662
2663 2019-06-25  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2666         declare.
2667         * tui/tui-winsource.c
2668         (tui_source_window_base::do_scroll_horizontal): Rename from
2669         tui_horizontal_source_scroll.
2670         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2671         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2672         from tui_vertical_data_scroll.
2673         * tui/tui-win.h (tui_scroll): Don't declare.
2674         * tui/tui-win.c (tui_win_info::forward_scroll)
2675         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2676         (tui_win_info::right_scroll): Rename and update.
2677         (tui_scroll_forward_command, tui_scroll_backward_command)
2678         (tui_scroll_left_command, tui_scroll_right_command): Update.
2679         (tui_scroll): Remove.
2680         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2681         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2682         from tui_vertical_source_scroll.
2683         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2684         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2685         from tui_vertical_disassem_scroll.
2686         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2687         do_scroll_horizontal>: New methods.
2688         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2689         Likewise.
2690         (struct tui_source_window_base): Add do_scroll_horizontal.
2691         (struct tui_source_window, struct tui_disasm_window): Add
2692         do_scroll_vertical.
2693         (struct tui_data_window, struct tui_cmd_window): Add
2694         do_scroll_horizontal and do_scroll_vertical.
2695         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2696
2697 2019-06-25  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-data.h (struct tui_source_window_base): New struct.
2700         (struct tui_source_window): Derive from tui_source_window_base.
2701         (struct tui_disasm_window): New struct.
2702         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2703         from tui_source_window::clear_detail.
2704         (tui_source_window_base): Rename from tui_source_window.
2705         (~tui_source_window_base): Rename from ~tui_source_window.
2706         (tui_alloc_win_info): Create a tui_disasm_window.
2707
2708 2019-06-25  Tom Tromey  <tom@tromey.com>
2709
2710         * tui/tui-data.h (struct tui_source_window)
2711         (struct tui_data_window): Declare destructors.
2712         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2713         destructors.
2714         (tui_win_info): Simplify.
2715
2716 2019-06-25  Tom Tromey  <tom@tromey.com>
2717
2718         * tui/tui-winsource.c (tui_display_main)
2719         (tui_update_source_windows_with_addr)
2720         (tui_update_all_breakpoint_info): Update.
2721         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2722         (new_height_ok, parse_scrolling_args): Update.
2723         * tui/tui-stack.c (tui_show_frame_info): Update.
2724         * tui/tui-data.h (struct tui_list): Remove.
2725         (tui_source_windows): Return a reference to a std::vector.
2726         * tui/tui-data.c (source_windows): Now a std::vector.
2727         (tui_source_windows): Change return type.
2728         (tui_clear_source_windows): Rewrite.
2729         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2730         (tui_free_all_source_wins_content): Rewrite.
2731
2732 2019-06-25  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2735         (struct tui_data_window, struct tui_cmd_window): Declare
2736         clear_detail method.
2737         * tui/tui-data.c (tui_source_window::clear_detail)
2738         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2739         methods.
2740         (tui_clear_win_detail): Simplify.
2741
2742 2019-06-25  Tom Tromey  <tom@tromey.com>
2743
2744         * tui/tui-layout.c (make_source_window, make_disasm_window)
2745         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2746         Return the new window.
2747         (show_source_disasm_command, show_data)
2748         (show_source_or_disasm_and_command): Update.
2749
2750 2019-06-25  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2753         parameter.  Return the new window.
2754         (show_source_disasm_command): Update and remove NULL check.
2755         (show_source_or_disasm_and_command): Update.
2756
2757 2019-06-25  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2760
2761 2019-06-25  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-data.h (struct tui_win_info): Make constructor
2764         protected.  Make destructor virtual.  Add initializers.
2765         (tui_source_window, tui_data_window, tui_cmd_window): New
2766         classes.
2767         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2768         constructor.  Add "type" parameter.
2769         (tui_source_window, tui_data_window, tui_cmd_window): New
2770         constructors.
2771         (tui_alloc_win_info): Instantiate the appropriate subclass.
2772
2773 2019-06-25  Tom Tromey  <tom@tromey.com>
2774
2775         * tui/tui-win.c (tui_resize_all): Use delete.
2776         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2777         destructor.
2778         (tui_free_window): Don't declare.
2779         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2780         Update.
2781
2782 2019-06-25  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-data.h (struct tui_win_info): Add constructor.
2785         * tui/tui-data.c (tui_alloc_win_info): Use new.
2786         (tui_free_window): Use delete.
2787
2788 2019-06-22  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2791         declare.
2792         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2793
2794 2019-06-22  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2797         declare.
2798         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2799
2800 2019-06-22  Tom de Vries  <tdevries@suse.de>
2801
2802         * dwarf2read.c (create_addrmap_from_aranges)
2803         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2804         instead of '%zu'.
2805
2806 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2807
2808         * dwarf2read.h (dwarf2_section_info_def): Remove.
2809         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2810         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2811         std::vector<dwarf2_section_info>.
2812         (struct dwo_file) <~dwo_file>: Remove.
2813         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2814         types field.
2815         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2816         (dwarf2_read_debug_names): Likewise.
2817         (create_debug_types_hash_table): Change parameter type to
2818         array_view, adjust code accordingly.
2819         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2820         (partial_die_info::fixup): Likewise.
2821         (determine_prefix): Likewise.
2822         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2823
2824 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2825
2826         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2827         gdb_bfd_ref_ptr.
2828         <~dwo_file>: Remove call to gdb_bfd_unref.
2829         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2830         gdb_bfd_ref_ptr::get.
2831
2832 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2833
2834         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2835         type to htab_up.
2836         * dwarf2read.c (struct dwo_file): Initialize fields.
2837         <~dwo_file>: New.
2838         (free_dwo_file): Remove, move content to ~dwo_file.
2839         (struct dwo_file_deleter): Remove.
2840         (dwo_file_up>: Remove custom deleter.
2841         (free_dwo_files): Remove.
2842         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2843         dwo_files.
2844         (process_skeletonless_type_units): Call unique_ptr::get.
2845         (allocate_dwo_file_hash_table): Add deleter to created hash
2846         table.  Change return type to htab_up.
2847         (lookup_dwo_file_slot): Don't memset dwo_file, call
2848         unique_ptr::get.
2849         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2850         (create_dwo_unit_in_dwp_v2): Likewise.
2851         (open_and_init_dwo_file): Likewise.
2852         (free_dwo_file_from_slot): Remove.
2853
2854 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2855
2856         * dwarf2read.h (struct dwarf2_section_info) <readin,
2857         is_virtual>: Change type to bool.
2858         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2859         true instead of 1.
2860
2861 2019-06-19  Tom Tromey  <tom@tromey.com>
2862
2863         * tui/tui-data.h (tui_init_content_element): Don't declare.
2864
2865 2019-06-19  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-data.h (tui_init_win_info): Don't declare.
2868
2869 2019-06-19  Tom de Vries  <tdevries@suse.de>
2870
2871         * dwarf2read.h (abstract_to_concrete): Change type to
2872         std::unordered_map<sect_offset, std::vector<sect_offset>,
2873         gdb::hash_enum<sect_offset>>.
2874
2875 2019-06-19  Tom Tromey  <tromey@adacore.com>
2876
2877         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2878         EVAL_AVOID_SIDE_EFFECTS specially.
2879
2880 2019-06-19  Tom Tromey  <tromey@adacore.com>
2881
2882         * source-cache.c (highlighter): New global.
2883         (source_cache::get_source_lines): Create a highlighter on demand.
2884
2885 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * defs.h (deprecated_interactive_hook): Delete declaration.
2888         * interps.c (clear_interpreter_hooks): Remove use of
2889         deprecated_interactive_hook.
2890         * top.c (deprecated_interactive_hook): Delete definition.
2891         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2892
2893 2019-06-18  Tom de Vries  <tdevries@suse.de>
2894
2895         PR gdb/24515
2896         * dwarf2read.h (abstract_to_concrete): Change type from
2897         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2898         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2899         * dwarf2read.c (read_variable): Update.
2900         (dwarf2_fetch_die_loc_sect_off): Update.
2901
2902 2019-06-17  Tom de Vries  <tdevries@suse.de>
2903
2904         PR gdb/24617
2905         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2906         accessing parent[parent_len - 1].
2907
2908 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2909
2910         PR gdb/24364
2911         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2912         call dtrace_process_dof with NULL dof.
2913
2914 2019-06-16  Tom de Vries  <tdevries@suse.de>
2915
2916         PR gdb/24445
2917         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2918
2919 2019-06-16  Tom Tromey  <tom@tromey.com>
2920
2921         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2922         (make_all_visible): Use address of member.
2923
2924 2019-06-16  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2927         (tui_free_window, free_content, free_content_elements): Remove
2928         unnecessary cast.
2929         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2930         cast.
2931         * tui/tui-regs.c (tui_show_register_group)
2932         (tui_display_registers_from, tui_display_reg_element_at_line):
2933         Remove unnecessary cast.
2934
2935 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2936
2937         * linux-nat.c (normal_mask): Delete.
2938         (_initialize_linux_nat): Don't initialise normal_mask.
2939
2940 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2941
2942         PR gdb/24445
2943         * dwarf-index-write.h (write_psymtabs_to_index): Add
2944         dwz_basename parameter.
2945         * dwarf-index-write.c (write_gdbindex): Move file writing to
2946         write_gdbindex_1.  Change return type void.
2947         (assert_file_size): Move up, remove filename parameter.
2948         (write_gdbindex_1): New function.
2949         (write_debug_names): Change return type to void, call
2950         assert_file_size.
2951         (struct index_wip_file): New struct.
2952         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2953         file logic to index_wip_file.  Write index for dwz file if
2954         needed.
2955         (save_gdb_index_command): Pass basename of dwz file, if present.
2956         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2957         build-id of dwz file, if present.
2958         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2959         (dwarf2_get_dwz_file): Likewise.
2960         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2961         (dwarf2_get_dwz_file): Likewise.
2962
2963 2019-06-16  Tom Tromey  <tom@tromey.com>
2964
2965         * coffread.c (process_coff_symbol): Use xstrdup.
2966         * value.c (create_internalvar): Use xstrdup.
2967
2968 2019-06-16  Tom Tromey  <tom@tromey.com>
2969
2970         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2971         * breakpoint.c (stopin_command, stopat_command)
2972         (until_break_command, decode_location_default): Remove unnecessary
2973         cast.
2974         * utils.c (subset_compare): Remove unnecessary cast.
2975         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2976         cast.
2977         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2978         cast.
2979         * infcmd.c (path_command): Remove unnecessary cast.
2980         * coffread.c (decode_type): Remove unnecessary cast.
2981         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2982         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2983         * tui/tui-stack.c (tui_show_locator_content)
2984         (tui_show_frame_info): Remove unnecessary cast.
2985         * tui/tui-win.c (tui_scroll_forward_command)
2986         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2987         (parse_scrolling_args): Remove unnecessary cast.
2988         * tui/tui-data.c (init_win_info, tui_del_window)
2989         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2990         (free_content_elements): Remove unnecessary cast.
2991         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2992         unnecessary cast.
2993         * tui/tui-source.c (tui_set_source_content)
2994         (tui_vertical_source_scroll): Remove unnecessary cast.
2995         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2996         cast.
2997         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2998         * tui/tui-regs.c (tui_display_registers_from)
2999         (tui_display_register): Remove unnecessary cast.
3000         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3001         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3002         (make_visible): Remove unnecessary cast.
3003         * tui/tui-winsource.c (tui_erase_source_content)
3004         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3005         unnecessary cast.
3006         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3007         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3008         * stabsread.c (read_type, read_array_type, read_range_type):
3009         Remove unnecessary cast.
3010         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3011         (parse_symbol, parse_type, upgrade_type, parse_external)
3012         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3013         unnecessary cast.
3014         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3015
3016 2019-06-16  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-data.c (tui_alloc_generic_win_info)
3019         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3020         checks.
3021
3022 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3023             Andrew Burgess  <andrew.burgess@embecosm.com>
3024
3025         * f-typeprint.c (f_print_type): Don't return early for not
3026         associated or not allocated types.
3027         (f_type_print_varspec_suffix): Add print_rank parameter and print
3028         ranks of array types in case they dangling.
3029         (f_type_print_base): Add print_rank parameter.
3030
3031 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3032
3033         * NEWS: Mention new MI commands.
3034         * break-catch-throw.c (enum exception_event_kind): Move to
3035         breakpoint.h.
3036         (print_mention_exception_catchpoint): Output text as a single
3037         message.
3038         (catch_exception_command_1): Rename to...
3039         (catch_exception_event): ...this, make non-static, update header
3040         command, and change some parameter types.
3041         (catch_catch_command): Update for changes to
3042         catch_exception_command_1.
3043         (catch_throw_command): Likewise.
3044         (catch_rethrow_command): Likewise.
3045         * breakpoint.c (enum exception_event_kind): Delete.
3046         * breakpoint.h (enum exception_event_kind): Moved here from
3047         break-catch-throw.c.
3048         (catch_exception_event): Declare.
3049         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3050         (mi_cmd_catch_throw): New function.
3051         (mi_cmd_catch_rethrow): New function.
3052         (mi_cmd_catch_catch): New function.
3053         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3054         'catch-catch' entries.
3055         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3056         (mi_cmd_catch_rethrow): Declare.
3057         (mi_cmd_catch_catch): Declare.
3058
3059 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3060
3061         * annotate.c (annotate_source_line): Change return type to void,
3062         update implementation to match.
3063         * annotate.h (annotate_source_line): Change return type to void,
3064         update header comment.
3065         * stack.c (print_frame_info): Don't change what frame information
3066         is printed based on whether annotations are on or not.
3067
3068 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3071         (annotate_source): Make static.
3072         (annotate_source_line): Moved from source.c and renamed from
3073         identify_source_line.  Update the return type.
3074         * annotate.h (annotate_source): Delete declaration.
3075         (annotate_source_line): Declaration moved from source.h, and
3076         renamed from identify_source_line.  Return type updated.
3077         * source.c (identify_source_line): Moved to annotate.c and renamed
3078         to annotate_source_line.
3079         (info_line_command): Remove check of annotation_level.
3080         * source.h (identify_source_line): Move declaration to annotate.h
3081         and rename to annotate_source_line.
3082         * stack.c: Add 'annotate.h' include.
3083         (print_frame_info): Remove check of annotation_level before
3084         calling annotate_source_line.
3085
3086 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3087
3088         * source-cache.c (source_cache::get_plain_source_lines): Use
3089         open_source_file_with_line_charpos instead of just
3090         open_source_file, remove call to find_source_lines.
3091         (source_cache::get_source_lines): Likewise.
3092         * source.c (find_source_lines): Make static.
3093         (get_filename_and_charpos): Renamed into...
3094         (open_source_file_with_line_charpos): ..this along with changes to
3095         return a scoped_fd, and some other minor clean ups.
3096         (identify_source_line): Use open_source_file_with_line_charpos.
3097         (search_command_helper): Use open_source_file_with_line_charpos
3098         instead of just open_source_file, remove call to
3099         find_source_lines.
3100         * source.h (open_source_file_with_line_charpos): Declare new
3101         function.
3102         (find_source_lines): Delete declaration.
3103
3104 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3105
3106         * source.c (get_filename_and_charpos): Remove fullname
3107         parameter.
3108         (identify_source_line): Update call to get_filename_and_charpos.
3109
3110 2019-06-14  Tom Tromey  <tromey@adacore.com>
3111
3112         PR gdb/24502:
3113         * ui-style.h (skip_ansi_escape): Update comment.
3114         * ui-file.h (class no_terminal_escape_file): New class.
3115         * ui-file.c (no_terminal_escape_file::write)
3116         (no_terminal_escape_file::puts): New methods.
3117         * cli/cli-logging.c (handle_redirections): Use
3118         no_terminal_escape_file.
3119
3120 2019-06-14  Tom Tromey  <tromey@adacore.com>
3121
3122         * NEWS: Move convenience variable news above Python news.
3123
3124 2019-06-14  Tom Tromey  <tom@tromey.com>
3125
3126         * gnulib: Move directory to top-level.
3127         * configure.ac: Don't configure gnulib.
3128         * configure: Rebuild.
3129         * common/common-defs.h: Use new path to gnulib.
3130         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3131         (GNULIB_H): Remove.
3132         (INCGNU): Look in new gnulib location.
3133         (HFILES_NO_SRCDIR): Remove gnulib files.
3134         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3135         (generated_files): Remove GNULIB_H.
3136         ($(LIBGNU), all-lib): Remove targets.
3137         (distclean): Don't mention GNULIB_BUILDDIR.
3138         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3139
3140 2019-06-14  Tom Tromey  <tromey@adacore.com>
3141
3142         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3143         Warn if symbol file does not provide any symbols.
3144
3145 2019-06-14  Tom Tromey  <tromey@adacore.com>
3146
3147         * source.c (find_and_open_source): Respect basenames_may_differ.
3148
3149 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3150
3151         * annotate.c (annotate_breakpoints_invalid): Make use of
3152         scoped_restore_terminal_state.
3153         (annotate_frames_invalid): Likewise.
3154
3155 2019-06-14  Tom Tromey  <tromey@adacore.com>
3156
3157         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3158         allow assignment to an internalvar.
3159
3160 2019-06-14  Tom Tromey  <tromey@adacore.com>
3161
3162         * ada-lex.l: Allow "_" in attribute names.
3163
3164 2019-06-14  Tom Tromey  <tromey@adacore.com>
3165
3166         PR gdb/24653:
3167         * regcache.c (registers_changed): Don't call alloca.
3168         * top.c (execute_command): Don't call alloca.
3169
3170 2019-06-13  Pedro Alves  <palves@redhat.com>
3171
3172         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3173         'expression'.  When parsing an expression, error out if there's
3174         junk after "unlimited".
3175         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3176         (do_set_command): Adjust calls to is_unlimited_literal.
3177
3178 2019-06-13  Pedro Alves  <palves@redhat.com>
3179
3180         * compile/compile.c (make_compile_options_def_group): Add braces
3181         around array_view initializer.
3182         * thread.c (make_thread_apply_all_options_def_group)
3183         (make_thread_apply_all_options_def_group): Likewise.
3184
3185 2019-06-13  Pedro Alves  <palves@redhat.com>
3186
3187         * NEWS (New commands): Mention "maint test-options
3188         require-delimiter", "maint test-options unknown-is-error", "maint
3189         test-options unknown-is-operand" and "maint show
3190         test-options-completion-result".
3191         (New command options, command completion): New section.
3192         (Completion improvements): New section.
3193         Mention that you can abbreviate "unlimited".
3194
3195 2019-06-13  Pedro Alves  <palves@redhat.com>
3196
3197         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3198         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3199         * unittests/cli-utils-selftests.c (test_parse_flags)
3200         (test_parse_flags_qcs): Delete.
3201         (test_cli_utils): Don't call deleted functions.
3202
3203 2019-06-13  Pedro Alves  <palves@redhat.com>
3204
3205         * thread.c: Include "cli/cli-option.h".
3206         (tp_array_compar_ascending): Global.
3207         (tp_array_compar): Delete function.
3208         (tp_array_compar_ascending, tp_array_compar_descending): New
3209         functions.
3210         (ascending_option_def, qcs_flag_option_def)
3211         (thr_qcs_flags_option_defs)
3212         (make_thread_apply_all_options_def_group)
3213         (make_thread_apply_options_def_group): New.
3214         (thread_apply_all_command): Use gdb::option::process_options.
3215         (thread_apply_command_completer)
3216         (thread_apply_all_command_completer): New.
3217         (thread_apply_command): Use gdb::option::process_options.
3218         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3219         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3220         to generate help text of "thread apply".  Adjust "taas"'s help.
3221         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3222         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3223
3224 2019-06-13  Pedro Alves  <palves@redhat.com>
3225
3226         * thread.c (thread_apply_command): Check for invalid TID with
3227         isdigit instead of !isalpha.
3228
3229 2019-06-13  Pedro Alves  <palves@redhat.com>
3230
3231         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3232         (validate_flags_qcs): New.
3233         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3234         (validate_flags_qcs): Declare.
3235         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3236         (make_frame_apply_options_def_group): New.
3237         (frame_apply_command_count): Process options with
3238         gdb::option::process_options.
3239         (frame_apply_completer): New.
3240         (frame_apply_level_completer, frame_apply_all_completer)
3241         (frame_apply_completer): New.
3242         (_initialize_stack): Update help of "frame apply", "frame apply
3243         level", "frame apply all" and "faas" to mention supported options
3244         and install command completers.
3245         * stack.h (frame_apply_all_completer): Declare.
3246         * thread.c: Include "stack.h".
3247         (tfaas_command): Add "--".
3248         (_initialize_thread): Update help "tfaas" to mention supported
3249         options and install command completer.
3250
3251 2019-06-13  Pedro Alves  <palves@redhat.com>
3252
3253         * completer.c (complete_nested_command_line): New.
3254         (gdb_completion_word_break_characters_throw): Add assertion.
3255         * completer.h (complete_nested_command_line): Declare.
3256
3257 2019-06-13  Pedro Alves  <palves@redhat.com>
3258
3259         * stack.c (parse_backtrace_qualifiers): New.
3260         (backtrace_command): Use it.
3261         (backtrace_command_completer): Complete on qualifiers.
3262
3263 2019-06-13  Pedro Alves  <palves@redhat.com>
3264
3265         * frame.c: Include "cli/cli-option.h.
3266         (user_set_backtrace_options): New.
3267         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3268         Delete.
3269         (get_prev_frame): Adjust.
3270         (boolean_option_def, uinteger_option_def)
3271         (set_backtrace_option_defs): New.
3272         (_initialize_frame): Adjust and use
3273         gdb::option::add_setshow_cmds_for_options to install "set
3274         backtrace past-main" and "set backtrace past-entry".
3275         * frame.h: Include "cli/cli-option.h".
3276         (struct frame_print_options): Forward declare.
3277         (print_frame_arguments_all, print_frame_arguments_scalars)
3278         (print_frame_arguments_none): Declare.
3279         (print_entry_values): Delete declaration.
3280         (struct frame_print_options, user_frame_print_options): New.
3281         (struct set_backtrace_options): New.
3282         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3283         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3284         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3285         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3286         (list_args_or_locals): Add frame_print_options parameter.
3287         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3288         * python/py-framefilter.c (enumerate_args): Pass down
3289         USER_FRAME_PRINT_OPTIONS.
3290         * stack.c: Include "cli/cli-option.h".
3291         (print_frame_arguments_all, print_frame_arguments_scalars)
3292         (print_frame_arguments_none): Declare.
3293         (print_raw_frame_arguments, print_entry_values): Delete.
3294         (user_frame_print_options): New.
3295         (boolean_option_def, enum_option_def, frame_print_option_defs):
3296         New.
3297         (struct backtrace_cmd_options): New.
3298         (bt_flag_option_def): New.
3299         (backtrace_command_option_defs): New.
3300         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3301         (print_frame_arg, read_frame_arg, print_frame_args)
3302         (print_frame_info, print_frame): Add frame_print_options parameter
3303         and use it.
3304         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3305         (backtrace_command_1): Add frame_print_options and
3306         backtrace_cmd_options parameters and use them.
3307         (make_backtrace_options_def_group): New.
3308         (backtrace_command): Process command options with
3309         gdb::option::process_options.
3310         (backtrace_command_completer): New.
3311         (_initialize_stack): Extend "backtrace"'s help to mention
3312         supported options.  Install completer for "backtrace".
3313         Install some settings commands with add_setshow_cmds_for_options.
3314
3315 2019-06-13  Pedro Alves  <palves@redhat.com>
3316
3317         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3318         and that "set/show print raw frame-arguments" are now deprecated.
3319
3320         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3321         command.
3322         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3323         * stack.c (_initialize_stack): Install "set/show print
3324         raw-frame-arguments", and deprecate "set/show print raw
3325         frame-arguments".
3326         * valprint.c (_initialize_valprint): Deprecate "set/show print
3327         raw".
3328
3329 2019-06-13  Pedro Alves  <palves@redhat.com>
3330
3331         * compile/compile.c (struct compile_options): New.
3332         (compile_flag_option_def, compile_command_option_defs)
3333         (make_compile_options_def_group): New.
3334         (compile_file_command): Handle options with
3335         gdb::option::process_options.
3336         (compile_file_command_completer): New function.
3337         (compile_code_command): Handle options with
3338         gdb::option::process_options.
3339         (compile_code_command_completer): New function.
3340         (_initialize_compiler): Install completers for "compile code" and
3341         "compile file".  Mention available options in "compile code" and
3342         "compile code"'s help.
3343         * completer.c (advance_to_completion_word): New, factored out from
3344         ...
3345         (advance_to_expression_complete_word_point): ... this.
3346         (advance_to_filename_complete_word_point): New.
3347         * completer.h (advance_to_filename_complete_word_point): New
3348         declaration.
3349
3350 2019-06-13  Pedro Alves  <palves@redhat.com>
3351
3352         * compile/compile.c: Include "cli/cli-option.h".
3353         (compile_print_value): Scope data pointer is now a
3354         value_print_options pointer; adjust.
3355         (compile_print_command): Process options.  Scope data pointer is
3356         now a value_print_options pointer; adjust.
3357         (_initialize_compile): Update "compile print"'s help to include
3358         supported options.  Install a completer for "compile print".
3359         * cp-valprint.c (show_vtblprint, show_objectprint)
3360         (show_static_field_print): Delete.
3361         (_initialize_cp_valprint): Don't install "set print
3362         static-members", "set print vtbl", "set print object" here.
3363         * printcmd.c: Include "cli/cli-option.h" and
3364         "common/gdb_optional.h".
3365         (print_command_parse_format): Rework to fill in a
3366         value_print_options instead of a format_data.
3367         (print_value): Change parameter type from format_data pointer to
3368         value_print_options reference.  Adjust.
3369         (print_command_1): Process options.  Adjust to pass down a
3370         value_print_options.
3371         (print_command_completer): New.
3372         (_initialize_printcmd): Install print_command_completer as
3373         handle_brkchars completer for the "print" command.  Update
3374         "print"'s help to include supported options.
3375         * valprint.c: Include "cli/cli-option.h".
3376         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3377         here from cp-valprint.c.
3378         (boolean_option_def, uinteger_option_def)
3379         (value_print_option_defs, make_value_print_options_def_group):
3380         New.  Use gdb::option::add_setshow_cmds_for_options to install
3381         "set print elements", "set print null-stop", "set print repeats",
3382         "set print pretty", "set print union", "set print array", "set
3383         print address", "set print symbol", "set print array-indexes".
3384         * valprint.h: Include <string> and "cli/cli-option.h".
3385         (make_value_print_options_def_group): Declare.
3386         (print_value): Change parameter type from format_data pointer to
3387         value_print_options reference.
3388         (print_command_completer): Declare.
3389
3390 2019-06-13  Pedro Alves  <palves@redhat.com>
3391
3392         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3393         (COMMON_SFILES): Add maint-test-settings.c.
3394         * cli/cli-decode.c (boolean_enums): New global, factored out from
3395         ...
3396         (add_setshow_boolean_cmd): ... here.
3397         * cli/cli-decode.h (boolean_enums): Declare.
3398         * cli/cli-option.c: New file.
3399         * cli/cli-option.h: New file.
3400         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3401         factored out from ...
3402         (parse_cli_boolean_value(const char *)): ... this.
3403         (is_unlimited_literal): Change parameter type to pointer to
3404         pointer.  Adjust and advance ARG pointer.
3405         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3406         (parse_cli_var_enum): New, factored out from ...
3407         (do_set_command): ... this.  Adjust.
3408         * cli/cli-setshow.h (parse_cli_boolean_value)
3409         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3410         (parse_cli_var_enum): Declare.
3411         * cli/cli-utils.c: Include "cli/cli-option.h".
3412         (get_ulongest): New.
3413         * cli/cli-utils.h (get_ulongest): Declare.
3414         (check_for_argument): New overloads.
3415         * maint-test-options.c: New file.
3416
3417 2019-06-13  Pedro Alves  <palves@redhat.com>
3418
3419         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3420         parse a range if "-" is at the end of the string.
3421
3422 2019-06-13  Pedro Alves  <palves@redhat.com>
3423
3424         * cli/cli-setshow.c (parse_auto_binary_operation)
3425         (parse_cli_boolean_value): Don't allow "o".
3426
3427 2019-06-13  Pedro Alves  <palves@redhat.com>
3428
3429         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3430         * NEWS: Mention maint test-settings KIND.
3431         * maint-test-settings.c: New file.
3432
3433 2019-06-13  Pedro Alves  <palves@redhat.com>
3434
3435         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3436         completer.
3437         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3438         "set" completers.
3439
3440 2019-06-13  Pedro Alves  <palves@redhat.com>
3441
3442         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3443         after item.
3444
3445 2019-06-13  Pedro Alves  <palves@redhat.com>
3446
3447         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3448
3449 2019-06-13  Pedro Alves <palves@redhat.com>
3450
3451         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3452         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3453         call.
3454         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3455         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3456         calls.
3457         (check_for_argument): Skip spaces after argument.
3458
3459 2019-06-13  Pedro Alves  <palves@redhat.com>
3460
3461         * thread.c (thread_apply_command): Adjust TID parsing.
3462         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3463         detected before end of string.
3464         (tid_is_in_list): Error out if LIST is invalid.
3465
3466 2019-06-13  Pedro Alves  <palves@redhat.com>
3467
3468         * completer.c (complete_line_internal_1): Rewind completion word
3469         point.
3470         (completion_tracker::advance_custom_word_point_by): Change
3471         parameter type to int.
3472         * completer.h (completion_tracker::advance_custom_word_point_by):
3473         Likewise.
3474
3475 2019-06-13  Pedro Alves  <palves@redhat.com>
3476
3477         * completer.c (advance_to_completion_word): Handle delimiters.
3478
3479 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3480
3481         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3482
3483 2019-06-11  Tom Tromey  <tom@tromey.com>
3484
3485         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3486         (xmalloc_failed): Move to alloc.c.
3487         * alloc.c: New file.
3488         * Makefile.in (COMMON_SFILES): Add alloc.c.
3489
3490 2019-06-11  Tom Tromey  <tom@tromey.com>
3491
3492         * nat/linux-waitpid.c: Don't include server.h.
3493         (linux_debug): Remove.
3494         (my_waitpid): Update.
3495
3496 2019-06-11  Tom Tromey  <tromey@adacore.com>
3497
3498         * infcall.c (_initialize_infcall): Remove trailing newline from
3499         help.
3500         * user-regs.c (_initialize_user_regs): Remove trailing newline
3501         from help.
3502         * typeprint.c (_initialize_typeprint): Remove trailing newline
3503         from help.
3504         * reverse.c (_initialize_reverse): Remove trailing newlines from
3505         help.
3506         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3507         from help.
3508         * language.c (add_set_language_command): Remove trailing newline
3509         from help.
3510         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3511         help.
3512         * disasm.c (_initialize_disasm): Remove trailing newline from
3513         help.
3514         * top.c (init_main): Remove trailing newline from help.
3515         * interps.c (_initialize_interpreter): Remove trailing newline
3516         from help.
3517         * btrace.c (_initialize_btrace): Remove trailing newlines from
3518         help.
3519         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3520         from help.
3521         * python/python.c (_initialize_python): Remove trailing newline
3522         from help.
3523         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3524         help.
3525         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3526         from help.  Reformat some text.
3527         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3528         from help.
3529         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3530         newline from help.
3531
3532 2019-06-11  Tom Tromey  <tromey@adacore.com>
3533
3534         * darwin-nat.c (darwin_decode_exception_message)
3535         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3536
3537 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * valops.c (value_slice): Check for not allocated or not
3540         associated values.
3541
3542 2019-06-10  Tom de Vries  <tdevries@suse.de>
3543
3544         PR gdb/24618
3545         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3546         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3547         invalid.
3548
3549 2019-06-10  Tom de Vries  <tdevries@suse.de>
3550
3551         PR gdb/24611
3552         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3553         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3554
3555 2019-06-10  Tom de Vries  <tdevries@suse.de>
3556
3557         PR symtab/24545
3558         * symtab.c (struct demangled_name_entry): Add language field.
3559         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3560         static minimal symbol".  Set and use language field.
3561
3562 2019-06-10  Tom Tromey  <tromey@adacore.com>
3563
3564         * ada-lang.c (_initialize_ada_language): Update help text.
3565
3566 2019-06-10  Tom Tromey  <tromey@adacore.com>
3567
3568         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3569         with a newline.
3570         * guile/guile.c (handle_boot_error): Don't end warning with a
3571         newline.
3572         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3573         warning with a newline.
3574         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3575         newline.
3576         (s12z_frame_cache): Likewise.
3577         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3578         a newline.
3579         * solib-svr4.c (disable_probes_interface): Don't end warning with
3580         a newline.
3581         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3582         newline.
3583         * python/python.c (do_finish_initialization): Don't end warning
3584         with a newline.
3585
3586 2019-06-10  Tom Tromey  <tom@tromey.com>
3587
3588         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3589         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3590         gdbpy_enter.
3591
3592 2019-06-10  Tom Tromey  <tromey@adacore.com>
3593
3594         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3595         data.
3596         (elf_new_init): Don't call stabsread_new_init.
3597         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3598         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3599         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3600
3601 2019-06-10  Tom de Vries  <tdevries@suse.de>
3602
3603         PR symtab/16264
3604         PR symtab/24517
3605         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3606
3607 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3608
3609         * source.c (find_and_open_source): Also rewrite relative file
3610         names.
3611
3612 2019-04-26  Amos Bird  <amosbird@gmail.com>
3613
3614         * annotate.c (annotate_thread_exited): Add "thread-exited"
3615         annotation.
3616
3617 2019-06-06  Tom Tromey  <tromey@adacore.com>
3618
3619         * maint.h (class scoped_command_stats): Use
3620         DISABLE_COPY_AND_ASSIGN.
3621         <print_time>: New method.
3622         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3623         print_time.
3624         (scoped_command_stats::print_time): New method.
3625
3626 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3627
3628         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3629         instructions of lengths 6 or 8 bytes.
3630
3631 2019-06-04  Pedro Alves  <palves@redhat.com>
3632
3633         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3634
3635         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3636         * breakpoint.c (condition_completer): Likewise.
3637         * cli/cli-dump.c (scan_expression): Likewise.
3638         * common/filestuff.c (mkdir_recursive): Likewise.
3639         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3640         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3641         (gdb_abspath): Likewise.
3642         * compile/compile-cplus-types.c
3643         (compile_cplus_instance::decl_name): Likewise.
3644         * completer.c (complete_explicit_location):
3645         (signal_completer, reg_or_group_completer_1): Likewise.
3646         * cp-support.c (cp_remove_params_if_any): Likewise.
3647         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3648         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3649         * infcmd.c (strip_bg_char): Likewise.
3650         * linespec.c (copy_token_string): Likewise.
3651         * mi/mi-main.c (output_cores): Likewise.
3652         * psymtab.c (psymtab_search_name):
3653         * symfile.c (test_set_ext_lang_command): Likewise.
3654         * target.c (target_fileio_read_stralloc): Likewise.
3655         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3656         * value.c (complete_internalvar): Likewise.
3657
3658 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3659
3660         Add objfile property to gdb.Type.
3661         * NEWS: Mention Python API addition.
3662         * python/py-type.c (typy_get_objfile): New method.
3663
3664 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3665
3666         * NEWS: Mention the new set|show style [title|highlight].
3667         Mention changes to "show style", "help" and "apropos".
3668
3669 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3670
3671         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3672         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3673         instead of print_help_for_command.
3674         (print_doc_of_command): New function.
3675         (help_list): Add 'apropos -v word' suggestion.
3676         (print_help_for_command): Style the command name using title style.
3677         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3678         (_initialize_cli_cmds): Describe -v in apropos_command help.
3679
3680 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3681
3682         * cli/cli-style.h (cli_style_option): Add name in constructor,
3683         add m_name class member, add constructor with intensity,
3684         add name class function.
3685         (cli_style_option::add_setshow_commands): Remove name argument.
3686         (highlight_style, title_style): New styles.
3687         * cli/cli-style.c (do_show): New function that shows a style
3688         characteristic styling the style name with itself.
3689         (set_style_name): New function.
3690         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3691         Update all callers according to the changes in cli/cli-style.h.
3692         * utils.h (fputs_highlighted): New function.
3693         * utils.c (fputs_highlighted): Likewise.
3694
3695 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3696
3697         * NEWS: Mention new pipe command and new convenience variables.
3698
3699 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3700
3701         * cli/cli-cmds.c (pipe_command): New function.
3702         (_initialize_cli_cmds): Call add_com for pipe_command.
3703         Define | as an alias for pipe.
3704         (exit_status_set_internal_vars): New function.
3705         (shell_escape): Call exit_status_set_internal_vars.
3706         cli/cli-decode.c (find_command_name_length): Recognize | as
3707         a single character command.
3708
3709 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3710
3711         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3712         top.c (execute_command_to_ui_file): New function, mostly a copy
3713         of execute_command_to_string.
3714         (execute_command_to_string): Implement by calling
3715         execute_command_to_ui_file.
3716
3717 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3718
3719         * top.h (saved_command_line): Remove declaration.
3720         * top.c (previous_saved_command_line, previous_repeat_arguments):
3721         New variables.
3722         (saved_command_line): Make static, define together with other
3723         'repeat variables'.
3724         (dont_repeat): Clear repeat_arguments.
3725         (repeat_previous, get_saved_command_line, save_command_line):
3726         New functions.
3727         (gdb_init): Initialize saved_command_line
3728         and previous_saved_command_line.
3729         * main.c (captured_main_1): Remove saved_command_line initialization.
3730         * event-top.c (handle_line_of_input): Update to use
3731         the new 'repeat' related functions instead of direct access to
3732         saved_command_line.
3733         * command.h (repeat_previous, get_saved_command_line,
3734         save_command_line): New declarations.
3735         (dont_repeat): Add comment.
3736
3737 2019-05-30  Tom Tromey  <tromey@adacore.com>
3738
3739         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3740         Fix comment.
3741         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3742
3743 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3744
3745         PR cli/24587
3746         * completer.c (complete): Initialize variable word.
3747
3748 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3749
3750         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3751         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3752         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3753         'body' is NULL to the outter 'if', protecting the '!is_define'
3754         situation as well.
3755
3756 2019-05-29  Tom Tromey  <tromey@adacore.com>
3757
3758         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3759         (dwarf_unknown): New function.
3760         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3761         (dwarf_type_encoding_name): Use dwarf_unknown.
3762
3763 2019-05-29  Tom Tromey  <tromey@adacore.com>
3764
3765         PR c++/20020:
3766         * cp-valprint.c (cp_print_value_fields): Call
3767         cp_print_static_field inside "try".
3768
3769 2019-05-29  Tom Tromey  <tromey@adacore.com>
3770
3771         * inflow.c (struct terminal_info): Add default operator=.
3772         * configure: Rebuild.
3773         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3774         -Wdeprecated-copy-dtor, -Wredundant-move.
3775
3776 2019-05-29  Tom Tromey  <tromey@adacore.com>
3777
3778         * NEWS: Add entry.
3779         * infcmd.c (print_return_value_1): Handle finish_print
3780         option.
3781         (show_print_finish): New function.
3782         (_initialize_infcmd): Add "set/show print finish" commands.
3783         * valprint.c (user_print_options): Initialize new member.
3784         * valprint.h (struct value_print_options) <finish_print>: New
3785         member.
3786
3787 2019-05-28  Tom Tromey  <tromey@adacore.com>
3788
3789         * ada-lang.c (ada_remove_Xbn_suffix)
3790         (find_old_style_renaming_symbol)
3791         (parse_old_style_renaming): Remove.
3792         (ada_find_renaming_symbol): Don't call
3793         find_old_style_renaming_symbol.
3794         (ada_is_renaming_symbol): Rename from
3795         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3796         bool.  Now static.
3797         (ada_read_var_value): Update and simplify.
3798         * ada-exp.y (write_var_or_type): Remove old code.
3799
3800 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3801
3802         * event-top.c: Remove include comment.
3803         * inflow.c (class scoped_ignore_sigttou): Move from here...
3804         * inflow.h (class scoped_ignore_sigttou): ...to here.
3805         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3806         * top.c:  Remove include comment.
3807
3808 2019-05-27  Tom Tromey  <tom@tromey.com>
3809
3810         * NEWS: Fix typo.
3811
3812 2019-05-22  Tom Tromey  <tromey@adacore.com>
3813
3814         * target.c (target_follow_exec): Constify parameter.
3815         * target-delegates.c: Rebuild.
3816         * remote.c (remote_target::follow_exec): Constify parameter.
3817         * infrun.c (follow_exec): Constify parameter.
3818         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3819         (target_follow_exec): Likewise.
3820
3821 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3822
3823         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3824         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3825
3826 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3827
3828         * NEWS: Add debugredirect and testsuite sections.
3829
3830 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3831
3832         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3833         target descriptions using exclusively floating point register name
3834         aliases.
3835
3836 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         PR gdb/18644:
3839         * f-lang.c (build_fortran_types): Handle the case where
3840         gdbarch_floatformat_for_type returns a nullptr.
3841
3842 2019-05-21  Tom de Vries  <tdevries@suse.de>
3843
3844         PR cli/24587
3845         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3846
3847 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3848
3849         PR gdb/18644:
3850         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3851         16-byte floats.
3852         * i386-tdep.c (i386_floatformat_for_type): Use
3853         floatformats_ia64_quad for the 16-byte floating point component
3854         within a fortran 32-byte complex number.
3855
3856 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3857
3858         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3859         delete default constructor.
3860         (find_partial_die): Update to return const struct.
3861         (partial_die_parent_scope): Move variable declaration into scope
3862         of its use and change its type to auto.
3863         (guess_partial_die_structure_name): Likewise.
3864         (partial_die_info::fixup): Likewise.
3865
3866 2019-05-17  Tom Tromey  <tromey@adacore.com>
3867
3868         * source.c (find_and_open_source): Remove cast.
3869
3870 2019-05-17  Tom Tromey  <tromey@adacore.com>
3871
3872         * annotate.c (annotate_source): Make "filename" const.
3873         * annotate.h (annotate_source): Use const.
3874
3875 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3876
3877         * disasm.c (set_disassembler_options): Send errors to stderr.
3878
3879 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3880
3881         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3882         (cli_interp_base::set_logging): Check debug_redirect.
3883         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3884         * cli/cli-logging.c (debug_redirect): Add static variable.
3885         (pop_output_files): Add default param.
3886         (handle_redirections): Print debug setting.
3887         (show_logging_command): Likewise.
3888         (_initialize_cli_logging): Add debugredirect command.
3889         * interps.c (current_interp_set_logging): Add debug_redirect
3890         parameter.
3891         * interps.h (set_logging): Add debug_redirect parameter.
3892         (current_interp_set_logging): Likewise.
3893         * mi/mi-common.h: Likewise.
3894         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3895
3896 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3897             Tom Tromey  <tromey@adacore.com>
3898
3899         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3900         directly.
3901         * cli/cli-interp.h (make_logging_output): Remove declaration.
3902         * cli/cli-logging.c (make_logging_output): Remove function.
3903         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3904         directly.
3905         * ui-file.c (tee_file::tee_file): Remove bools.
3906         (tee_file::~tee_file): Remove deletes.
3907         * ui-file.h (tee_file): Remove bools.
3908
3909 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3910
3911         * mi/mi-cmds.h (mi_cmd_complete): New function.
3912         * mi/mi-main.c (mi_cmd_complete): Likewise.
3913         * mi/mi-cmds.c: Define new MI command -complete.
3914         * NEWS: Mention new -complete command.
3915
3916 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3917
3918         * completer.h (complete): New function.
3919         * completer.c (complete): Likewise.
3920         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3921         function defined in completer.h.
3922
3923 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3924
3925         * MAINTAINERS (Write After Approval): Add myself.
3926
3927 2019-05-17  Tom de Vries  <tdevries@suse.de>
3928
3929         PR gdb/24094
3930         * dwarf2read.c (struct cu_partial_die_info): New struct.
3931         (find_partial_die): Return cu_partial_die_info.
3932         (partial_die_parent_scope, guess_partial_die_structure_name)
3933         (partial_die_info::fixup): Handle new return type of find_partial_die.
3934
3935 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3936
3937         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3938         "std::string", simplifying the algorithm.
3939
3940 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3941
3942         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3943         (stap_static_probe_ops::get_probes): Likewise.
3944
3945 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3946
3947         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3948         '-')" and "else if".
3949         (stap_parse_single_operand): Join checks for
3950         "gdbarch_stap_parse_special_token_p" and
3951         "gdbarch_stap_parse_special_token" in the same "if" statement.
3952         Invert check when verifying for operation on register
3953         displacement.
3954
3955 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3956
3957         * stap-probe.c (stap_get_opcode): Update comment.
3958         (stap_get_expected_argument_type): Likewise.
3959         (handle_stap_probe): Likewise.
3960
3961 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3962
3963         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3964         return type to 'bool'.  Adjust comment.  Use 'bool' when
3965         appropriate.
3966         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3967         * stap-probe.c (stap_parse_argument_1): Likewise.
3968         (stap_is_operator): Likewise.
3969         (stap_is_generic_prefix): Likewise.
3970         (stap_is_register_prefix): Likewise.
3971         (stap_is_register_indirection_prefix): Likewise.
3972         (stap_is_integer_prefix): Likewise.
3973         (stap_generic_check_suffix): Likewise.
3974         (stap_check_integer_suffix): Likewise.
3975         (stap_check_register_suffix): Likewise.
3976         (stap_check_register_indirection_suffix): Likewise.
3977         (stap_parse_register_operand): Likewise.
3978         (stap_parse_single_operand): Likewise.
3979         (stap_parse_argument_1): Likewise.
3980         (stap_probe::get_argument_count): Likewise.
3981         (stap_is_operator): Likewise.
3982
3983 2019-05-16  Tom Tromey  <tromey@adacore.com>
3984
3985         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3986         keyword to foreach.
3987
3988 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3989
3990         * linux-thread-db.c (try_thread_db_load_1): Change return type
3991         to bool.
3992         (try_thread_db_load): Likewise.
3993         (try_thread_db_load_from_pdir_1): Likewise.
3994         (try_thread_db_load_from_pdir): Likewise.
3995         (try_thread_db_load_from_sdir): Likewise.
3996         (try_thread_db_load_from_dir): Likewise.
3997         (thread_db_load_search): Likewise.
3998         (has_libpthread): Likewise.
3999         (thread_db_load): Likewise.
4000
4001 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4002
4003         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4004         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4005         NULL, and complain/return if that's the case.
4006
4007 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4008
4009         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4010         (advance, posn, abstract_read_memory): New functions.
4011         [struct mem_read_abstraction]: New struct.
4012         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4013
4014 2019-05-14  Tom Tromey  <tromey@adacore.com>
4015
4016         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4017         value is not lval_memory.
4018
4019 2019-05-14  Tom Tromey  <tromey@adacore.com>
4020
4021         * solib.c (info_sharedlibrary_command): Style the file name.
4022
4023 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4024
4025         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4026         (aarch64_vnv_type): Likewise.
4027         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4028         * common/tdesc.c: Likewise.
4029         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4030         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4031         * features/aarch64-fpu.xml: Add ieee half view.
4032         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4033         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4034         * gdbtypes.h (struct builtin_type): Likewise.
4035         (struct objfile_type): Likewise.
4036
4037 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4038
4039         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4040         typo.
4041         * location.h (string_to_event_location): Likewise.
4042
4043 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4044
4045         GDB 8.3 released.
4046
4047 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4048
4049         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4050         New variable declaration.
4051         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4052         New variable.
4053         (print_one_breakpoint): Use ui_out::test_flags and new global
4054         variable to compute use_fixed_output.
4055         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4056         Remove.
4057         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4058         (mi_multi_location_breakpoint_output_fixed): Remove.
4059         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4060         new variable.
4061         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4062         fix_multi_location_breakpoint_output flag if version >= 3.
4063         * ui-out.h (enum ui_out_flag)
4064         <fix_multi_location_breakpoint_output>: New enumerator.
4065
4066 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4067
4068         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4069
4070 2019-05-10  Tom Tromey  <tromey@adacore.com>
4071
4072         * ada-lang.c (catch_ada_completer): New function.
4073         (_initialize_ada_language): Use it.
4074
4075 2019-05-10  Tom Tromey  <tromey@adacore.com>
4076
4077         * thread.c (print_thread_info): Make "requested_threads" const.
4078         * gdbthread.h (print_thread_info): Make "requested_threads"
4079         const.
4080         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4081         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4082
4083 2019-05-08  Tom Tromey  <tom@tromey.com>
4084
4085         * gdbtypes.c (objfile_type_data): Change type.
4086         (objfile_type, _initialize_gdbtypes): Update.
4087
4088 2019-05-08  Tom Tromey  <tom@tromey.com>
4089
4090         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4091         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4092         (_initialize_dwarf2_frame): Update.
4093
4094 2019-05-08  Tom Tromey  <tom@tromey.com>
4095
4096         * objc-lang.c (objc_objfile_data): Change type.
4097         (find_methods): Update.
4098         (_initialize_objc_lang): Remove.
4099
4100 2019-05-08  Tom Tromey  <tom@tromey.com>
4101
4102         * stabsread.c (rs6000_builtin_type_data): Change type.
4103         (rs6000_builtin_type, _initialize_stabsread): Update.
4104
4105 2019-05-08  Tom Tromey  <tom@tromey.com>
4106
4107         * mips-tdep.c (mips_pdr_data): Remove.
4108         (_initialize_mips_tdep): Update.
4109
4110 2019-05-08  Tom Tromey  <tom@tromey.com>
4111
4112         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4113         (hppa_init_objfile_priv_data, read_unwind_info)
4114         (find_unwind_entry, _initialize_hppa_tdep): Update.
4115
4116 2019-05-08  Tom Tromey  <tom@tromey.com>
4117
4118         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4119         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4120         on obstack.
4121         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4122
4123 2019-05-08  Tom Tromey  <tom@tromey.com>
4124
4125         * mdebugread.c (basic_type_data): Change type.
4126         (basic_type, _initialize_mdebugread): Update.
4127
4128 2019-05-08  Tom Tromey  <tom@tromey.com>
4129
4130         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4131
4132 2019-05-08  Tom Tromey  <tom@tromey.com>
4133
4134         * nto-tdep.c (nto_inferior_data_reg): Change type.
4135         (nto_inferior_data): Update.
4136         (nto_inferior_data_cleanup, nto_new_inferior_data)
4137         (_initialize_nto_tdep): Remove.
4138         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4139
4140 2019-05-08  Tom Tromey  <tom@tromey.com>
4141
4142         * ada-lang.c (struct ada_inferior_data): Add initializers.
4143         (ada_inferior_data): Change type.
4144         (ada_inferior_data_cleanup): Remove.
4145         (get_ada_inferior_data, ada_inferior_exit)
4146         (struct ada_pspace_data): Add initializers, destructor.
4147         (ada_pspace_data_handle): Change type.
4148         (get_ada_pspace_data): Update.
4149         (ada_pspace_data_cleanup): Remove.
4150
4151 2019-05-08  Tom Tromey  <tom@tromey.com>
4152
4153         * coffread.c (struct coff_symfile_info): Add initializers.
4154         (coff_objfile_data_key): Move lower.  Change type.
4155         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4156         Update.
4157         (coff_free_info): Remove.
4158
4159 2019-05-08  Tom Tromey  <tom@tromey.com>
4160
4161         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4162         (fbsd_pspace_data_handle): Move lower.  Change type.
4163         (get_fbsd_pspace_data): Update.
4164         (fbsd_pspace_data_cleanup): Remove.
4165         (_initialize_fbsd_tdep): Update.
4166
4167 2019-05-08  Tom Tromey  <tom@tromey.com>
4168
4169         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4170         (get_ada_tasks_pspace_data): Update.
4171         (ada_tasks_pspace_data_cleanup): Remove.
4172         (_initialize_tasks): Update.
4173         (ada_tasks_inferior_data_handle): Change type.
4174         (get_ada_tasks_inferior_data): Update.
4175         (ada_tasks_inferior_data_cleanup): Remove.
4176         (struct ada_tasks_pspace_data): Add initializers.
4177
4178 2019-05-08  Tom Tromey  <tom@tromey.com>
4179
4180         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4181         * symfile-debug.c (debug_sym_get_probes): Change type.
4182         * stap-probe.c (handle_stap_probe):
4183         (stap_static_probe_ops::get_probes): Change type.
4184         * probe.h (class static_probe_ops) <get_probes>: Change type.
4185         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4186         (parse_probes_in_pspace): Update.
4187         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4188         Update.
4189         (any_static_probe_ops::get_probes): Change type.
4190         * elfread.c (elfread_data): New typedef.
4191         (probe_key): Change type.
4192         (elf_get_probes): Likewise.  Update.
4193         (probe_key_free): Remove.
4194         (_initialize_elfread): Update.
4195         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4196         Change type.
4197         (dtrace_process_dof_probe, dtrace_process_dof)
4198         (dtrace_static_probe_ops::get_probe): Change type.
4199
4200 2019-05-08  Tom Tromey  <tom@tromey.com>
4201
4202         * xcoffread.c (struct xcoff_symfile_info): Rename from
4203         coff_symfile_info.  Add initializers.
4204         (xcoff_objfile_data_key): Move lower.  Change type.
4205         (XCOFF_DATA): Rewrite.
4206         (xcoff_free_info): Remove.
4207         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4208         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4209         (xcoff_initial_scan): Update.
4210
4211 2019-05-08  Tom Tromey  <tom@tromey.com>
4212
4213         * solib-svr4.c (struct svr4_info): Add initializers and
4214         destructor.
4215         <probes_table>: Now an htab_up.
4216         (solib_svr4_pspace_data): Change type.
4217         (free_probes_table): Simplify.
4218         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4219         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4220         (probes_table_remove_objfile_probes, register_solib_event_probe)
4221         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4222         (_initialize_svr4_solib): Update.
4223
4224 2019-05-08  Tom Tromey  <tom@tromey.com>
4225
4226         * remote.c (remote_pspace_data): Change type.
4227         (remote_pspace_data_cleanup): Remove.
4228         (get_remote_exec_file, set_pspace_remote_exec_file)
4229         (_initialize_remote): Update.
4230
4231 2019-05-08  Tom Tromey  <tom@tromey.com>
4232
4233         * breakpoint.c (breakpoint_objfile_key): Change type.
4234         (get_breakpoint_objfile_data): Update.
4235         (free_breakpoint_objfile_data): Remove.
4236         (_initialize_breakpoint): Update.
4237
4238 2019-05-08  Tom Tromey  <tom@tromey.com>
4239
4240         * linux-tdep.c (struct linux_info): Add initializers.
4241         (linux_inferior_data): Move.  Change type.
4242         (invalidate_linux_cache_inf): Update.
4243         (linux_inferior_data_cleanup): Remove.
4244         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4245
4246 2019-05-08  Tom Tromey  <tom@tromey.com>
4247
4248         * auxv.c (auxv_inferior_data): Move.  Change type.
4249         (auxv_inferior_data_cleanup): Remove.
4250         (invalidate_auxv_cache_inf): Rewrite.
4251         (get_auxv_inferior_data, _initialize_auxv): Update.
4252
4253 2019-05-08  Tom Tromey  <tom@tromey.com>
4254
4255         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4256         (symfile_debug_objfile_data_key): Change type.
4257         (symfile_debug_installed, debug_qf_has_symbols)
4258         (debug_qf_find_last_source_symtab)
4259         (debug_qf_forget_cached_source_info)
4260         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4261         (debug_qf_print_stats, debug_qf_dump)
4262         (debug_qf_expand_symtabs_for_function)
4263         (debug_qf_expand_all_symtabs)
4264         (debug_qf_expand_symtabs_with_fullname)
4265         (debug_qf_map_matching_symbols)
4266         (debug_qf_expand_symtabs_matching)
4267         (debug_qf_find_pc_sect_compunit_symtab)
4268         (debug_qf_map_symbol_filenames)
4269         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4270         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4271         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4272         (debug_sym_read_linetable, debug_sym_relocate): Update.
4273         (symfile_debug_free_objfile): Remove.
4274         (install_symfile_debug_logging, _initialize_symfile_debug):
4275         Update.
4276
4277 2019-05-08  Tom Tromey  <tom@tromey.com>
4278
4279         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4280         allocate_on_obstack.
4281         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4282         (get_dwarf2_per_objfile): Update.
4283         (set_dwarf2_per_objfile): Remove.
4284         (dwarf2_has_info, dwarf2_get_section_info): Update.
4285         (dwarf2_free_objfile): Remove.
4286         (_initialize_dwarf2_read): Update.
4287
4288 2019-05-08  Tom Tromey  <tom@tromey.com>
4289
4290         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4291         initializers.
4292         <unsupported_script_warning_printed,
4293         script_not_found_warning_printed>: Now bool.
4294         (auto_load_pspace_data): Change type.
4295         (~auto_load_pspace_info): Rename from
4296         auto_load_pspace_data_cleanup.
4297         (get_auto_load_pspace_data, init_loaded_scripts_info)
4298         (clear_section_scripts, maybe_print_unsupported_script_warning)
4299         (maybe_print_script_not_found_warning, _initialize_auto_load):
4300         Update.
4301
4302 2019-05-08  Tom Tromey  <tom@tromey.com>
4303
4304         * objfiles.c (objfile_pspace_info): Add destructor and
4305         initializers.
4306         (objfiles_pspace_data): Change type.
4307         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4308         (get_objfile_pspace_data): Update.
4309         (objfiles_bfd_data): Change type.
4310         (get_objfile_bfd_data): Update.
4311         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4312
4313 2019-05-08  Tom Tromey  <tom@tromey.com>
4314
4315         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4316         Change type.
4317         (get_catch_syscall_inferior_data): Update.
4318         (catch_syscall_inferior_data_cleanup): Remove.
4319         (_initialize_break_catch_syscall): Update.
4320
4321 2019-05-08  Tom Tromey  <tom@tromey.com>
4322
4323         * inflow.c (struct terminal_info): Add destructor and
4324         initializers.
4325         (inflow_inferior_data): Change type.
4326         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4327         (get_inflow_inferior_data, inflow_inferior_exit)
4328         (swap_terminal_info, _initialize_inflow): Update.
4329
4330 2019-05-08  Tom Tromey  <tom@tromey.com>
4331
4332         * target-dcache.c (target_dcache_cleanup): Remove.
4333         (target_dcache_aspace_key): Change type.
4334         (target_dcache_init_p, target_dcache_invalidate)
4335         (target_dcache_get, target_dcache_get_or_init)
4336         (_initialize_target_dcache): Update.
4337         * dcache.h (struct dcache_deleter): New.
4338
4339 2019-05-08  Tom Tromey  <tom@tromey.com>
4340
4341         * symtab.c (struct symbol_cache): Add destructor and
4342         initializers.
4343         (symbol_cache_key): Move.  Change type.
4344         (make_symbol_cache, free_symbol_cache): Remove.
4345         (get_symbol_cache): Update.
4346         (symbol_cache_cleanup): Remove.
4347         (ALL_PSPACES, symbol_cache_flush)
4348         (maintenance_print_symbol_cache)
4349         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4350         Update.
4351
4352 2019-05-08  Tom Tromey  <tom@tromey.com>
4353
4354         * symtab.c (struct main_info): Add destructor and initializers.
4355         (main_progspace_key): Move.  Change type.
4356         (get_main_info): Update.
4357         (main_info_cleanup): Remove.
4358         (_initialize_symtab): Update.
4359
4360 2019-05-08  Tom Tromey  <tom@tromey.com>
4361
4362         * registry.h (DECLARE_REGISTRY): Define the _key class.
4363
4364 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4365
4366         * NEWS: Merge two 'New commands' sections.
4367
4368 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4369
4370         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4371         parameter and use Ada language definition instead.
4372         (ada_val_print_ptr): Remove unused language parameter.
4373         (ada_val_print_num): Remove language parameter and use Ada language
4374         definition instead.
4375         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4376         parameter.
4377         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4378         parameter and use Ada language definition instead.
4379         (ada_val_print_1): Update all ada_val_print_xxx calls.
4380         Remove language parameter.
4381         (ada_val_print): Update ada_val_print_1 call.
4382
4383 2019-05-08  Tom Tromey  <tromey@adacore.com>
4384
4385         * remote.c (remote_hw_watchpoint_limit)
4386         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4387         Now static.
4388
4389 2019-05-08  Tom Tromey  <tromey@adacore.com>
4390
4391         * maint.c (_initialize_maint_cmds): Move initialization code to
4392         remote.c.
4393         (watchdog, show_watchdog): Move to remote.c.
4394         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4395         "watchdog" static.
4396         (_initialize_remote): Move initialization code from maint.c.
4397         * defs.h (watchdog): Don't declare.
4398
4399 2019-05-08  Tom Tromey  <tromey@adacore.com>
4400
4401         * tui/tui-interp.c: Include main.h.
4402         * interps.c: Include main.h.
4403         * main.h (interpreter_p): Declare.
4404         * defs.h (interpreter_p): Don't declare.
4405
4406 2019-05-08  Tom Tromey  <tromey@adacore.com>
4407
4408         * dwarf2loc.c: Include dwarf2read.h.
4409         * defs.h (read_unsigned_leb128): Don't declare.
4410         * dwarf2read.h (read_unsigned_leb128): Declare.
4411
4412 2019-05-08  Tom Tromey  <tromey@adacore.com>
4413
4414         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4415         method.
4416
4417 2019-05-08  Tom Tromey  <tromey@adacore.com>
4418
4419         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4420         when no wrap column is set.
4421
4422 2019-05-08  Tom Tromey  <tromey@adacore.com>
4423
4424         * c-lang.c (c_get_string): Handle non-C-style arrays.
4425
4426 2019-05-08  Tom Tromey  <tromey@adacore.com>
4427
4428         * typeprint.c (print_offset_data::update): Print the bit offset,
4429         not the number of bits remaining.
4430
4431 2019-05-08  Tom Tromey  <tromey@adacore.com>
4432
4433         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4434         padding at end of comment.
4435
4436 2019-05-08  Tom Tromey  <tromey@adacore.com>
4437
4438         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4439         Compare main types.
4440
4441 2019-05-06  Tom Tromey  <tom@tromey.com>
4442
4443         * common/scoped_mmap.c: Include common-defs.h.
4444         * common/scoped_mmap.h: Don't include config.h.
4445
4446 2019-05-04  Tom Tromey  <tom@tromey.com>
4447
4448         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4449         (struct aarch64_call_info): Add initializers.
4450         <si>: Now a std::vector.
4451         (pass_on_stack, aarch64_push_dummy_call): Update.
4452
4453 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4454             Tom Tromey  <tom@tromey.com>
4455
4456         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4457         (ppc_threads): Now a std::vector.  Now static.
4458         (hwdebug_find_thread_points_by_tid)
4459         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4460         Update.
4461
4462 2019-05-04  Tom Tromey  <tom@tromey.com>
4463
4464         * arc-tdep.c (arc_tdesc_init): Return bool.
4465
4466 2019-05-04  Tom Tromey  <tom@tromey.com>
4467
4468         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4469         Use gdb_assert_not_reached.
4470
4471 2019-05-04  Tom Tromey  <tom@tromey.com>
4472
4473         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4474         "false".
4475
4476 2019-05-04  Tom Tromey  <tom@tromey.com>
4477
4478         * arc-tdep.c (arc_tdesc_init): Use bool.
4479
4480 2019-05-04  Tom Tromey  <tom@tromey.com>
4481
4482         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4483
4484 2019-05-04  Tom Tromey  <tom@tromey.com>
4485
4486         * cli/cli-cmds.c (valid_command_p): Return bool.
4487
4488 2019-05-04  Tom Tromey  <tom@tromey.com>
4489
4490         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4491         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4492
4493 2019-05-04  Raul Tambre  <raul@tambre.ee>
4494
4495         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4496         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4497         operator for comparison.
4498
4499 2019-05-04  Tom Tromey  <tom@tromey.com>
4500
4501         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4502         (lookup_partial_symbol, print_partial_symbols)
4503         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4504         (psymbol_compare): Update.
4505         (add_psymbol_to_bcache): Clear the entire psymbol.
4506         (maintenance_check_psymtabs): Update.
4507         * psympriv.h (struct partial_symbol): Don't derive from
4508         general_symbol_info.
4509         <obj_section, unrelocated_address, address,
4510         set_unrelocated_address>: Update.
4511         <ginfo>: New member.
4512         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4513         (debug_names::write_psymbols): Update.
4514
4515 2019-05-04  Tom de Vries  <tdevries@suse.de>
4516
4517         * contrib/cc-with-tweaks.sh: Support -n arg.
4518
4519 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4520
4521         * corelow.c (core_target::detach): Ensure frame cache and
4522         register caches are cleared.
4523         inferior.c (exit_inferior_1): Likewise.
4524
4525 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4526             Tom Tromey  <tom@tromey.com>
4527
4528         * dictionary.c (collate_pending_symbols_by_language): Remove
4529         "struct" from foreach.
4530         * symtab.c (lookup_global_symbol_from_objfile)
4531         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4532         foreach.
4533         * ser-tcp.c (net_open): Remove "struct" from foreach.
4534         * objfiles.c (objfile_relocate, objfile_rebase)
4535         (objfile_has_symbols): Remove "struct" from foreach.
4536         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4537         from foreach.
4538         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4539         foreach.
4540         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4541         "struct" from foreach.
4542         * ada-lang.c (create_excep_cond_exprs)
4543         (ada_exception_catchpoint_cond_string): Remove "struct" from
4544         foreach.
4545
4546 2019-05-03  Tom Tromey  <tromey@adacore.com>
4547
4548         * ada-exp.y (convert_char_literal): Check suffix of each
4549         enumerator.
4550
4551 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4552
4553         PR ada/21406:
4554         * ada-exp.y (yywrap): Don't define.
4555         * ada-lex.l (%option): Add noyywrap
4556         (yywrap): Remove.
4557
4558 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4559
4560         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4561         _WIN32_WINNT to the XP level, unless already defined to a higher
4562         level.
4563
4564         * unittests/parse-connection-spec-selftests.c:
4565         * ser-tcp.c:
4566         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4567         override.
4568
4569         * symfile.c (find_separate_debug_file): Remove colon from the
4570         drive spec of DOS/Windows file names of the target, so that the
4571         file name produced from DEBUGDIR and the target's directory will
4572         be valid on DOS/Windows systems.
4573
4574 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4575
4576         * rust-lang.c (val_print_struct): Handle printing structures
4577         containing strings.
4578
4579 2019-05-02  Tom Tromey  <tromey@adacore.com>
4580
4581         * valarith.c (_initialize_valarith): Remove.
4582
4583 2019-05-01  Tom Tromey  <tromey@adacore.com>
4584
4585         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4586         bitfields.
4587
4588 2019-05-01  Tom Tromey  <tromey@adacore.com>
4589
4590         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4591         for big-endian copies.
4592
4593 2019-04-30  Ali Tamur  <tamur@google.com>
4594         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4595         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4596         (read_3_bytes): New function.
4597
4598 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4599
4600         * windows-nat.c (main_thread_id): Delete.
4601         (handle_output_debug_string): Replace main_thread_id by
4602         current_event.dwThreadId.
4603         (fake_create_process): Likewise.
4604         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4605         Do not set main_thread_id.
4606         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4607         current_event.dwThreadId.
4608         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4609
4610 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4611
4612         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4613         Use current_event.dwThreadId instead of main_thread_id.
4614
4615 2019-04-30  Tom Tromey  <tromey@adacore.com>
4616
4617         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4618         (create_excep_cond_exprs): Iterate over program spaces.
4619         (ada_exception_catchpoint_cond_string): Examine all minimal
4620         symbols for exception types.
4621
4622 2019-04-30  Tom Tromey  <tromey@adacore.com>
4623
4624         PR c++/24470:
4625         * dwarf2read.c (process_structure_scope): Handle case where type
4626         has template parameters but no symbol was created.
4627
4628 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4629             Chris January  <chris.january@arm.com>
4630
4631         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4632         qualifier.
4633         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4634
4635 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4636
4637         * f-typeprint.c (f_print_type): Update rules for printing
4638         whitespace.
4639         (f_type_print_varspec_suffix): Likewise.
4640
4641 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4642             Chris January  <chris.january@arm.com>
4643
4644         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4645         function arguments.
4646
4647 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4648
4649         * f-lang.c (build_fortran_types): Change name of void type to
4650         lower case.
4651         * f-typeprint.c (f_type_print_base): Print the name of the void
4652         type, rather than a fixed string.
4653         * f-valprint.c (f_decorations): Use lower case void string.
4654
4655 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4656             Chris January  <chris.january@arm.com>
4657
4658         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4659         types for Fortran.
4660
4661 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4662             Chris January  <chris.january@arm.com>
4663             David Lecomber  <david.lecomber@arm.com>
4664
4665         * f-exp.y (BINOP_INTRINSIC): New token.
4666         (exp): New parser rule handling BINOP_INTRINSIC.
4667         (f77_keywords): Add new builtin procedures.
4668         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4669         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4670         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4671         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4672         (print_unop_subexp_f): New function.
4673         (print_binop_subexp_f): New function.
4674         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4675         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4676         (dump_subexp_body_f): Likewise.
4677         (operator_check_f): Likewise.
4678         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4679         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4680
4681 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4682
4683         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4684         UNOP_KIND.
4685         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4686         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4687         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4688         (operator_length_f): New fuction.
4689         (print_subexp_f): New function.
4690         (op_name_f): New function.
4691         (dump_subexp_body_f): New function.
4692         (operator_check_f): New function.
4693         (exp_descriptor_f): Replace standard expression handling functions
4694         with new functions.
4695         * gdb/fortran-operator.def: New file.
4696         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4697         * gdb/std-operator.def: Remove UNOP_KIND.
4698
4699 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4700
4701         * std-operator.def: Remove unbalanced, stray double quote
4702         character.
4703
4704 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4705             Chris January  <chris.january@arm.com>
4706             Daniel Everett  <daniel.everett@arm.com>
4707             Nick Forrington  <nick.forrington@arm.com>
4708             Richard Bunt  <richard.bunt@arm.com>
4709
4710         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4711         of depth when printing anonymous structs or unions.
4712         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4713         Don't print either the top-level value, or the children if the
4714         max-depth is exceeded.
4715         (ppscm_print_children): When printing the key of a map, allow one
4716         extra level of depth.
4717         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4718         print either the top-level value, or the children if the max-depth
4719         is exceeded.
4720         (print_children): When printing the key of a map, allow one extra
4721         level of depth.
4722         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4723         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4724         (user_print_options): Initialise max_depth field.
4725         (val_print_scalar_or_string_type_p): New function.
4726         (val_print): Check to see if the max depth has been reached.
4727         (val_print_check_max_depth): Define new function.
4728         (show_print_max_depth): New function.
4729         (_initialize_valprint): Add 'print max-depth' option.
4730         * valprint.h (struct value_print_options) <max_depth>: New field.
4731         (val_print_check_max_depth): Declare new function.
4732         * NEWS: Document new feature.
4733
4734 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4735
4736         * ada-lang.c (ada_language_defn): Initialise new field.
4737         * c-lang.c (c_is_string_type_p): New function.
4738         (c_language_defn): Initialise new field.
4739         (cplus_language_defn): Initialise new field.
4740         (asm_language_defn): Initialise new field.
4741         (minimal_language_defn): Initialise new field.
4742         * c-lang.h (c_is_string_type_p): Declare new function.
4743         * d-lang.c (d_language_defn): Initialise new field.
4744         * f-lang.c (f_is_string_type_p): New function.
4745         (f_language_defn): Initialise new field.
4746         * go-lang.c (go_is_string_type_p): New function.
4747         (go_language_defn): Initialise new field.
4748         * language.c (default_is_string_type_p): New function.
4749         (unknown_language_defn): Initialise new field.
4750         (auto_language_defn): Initialise new field.
4751         * language.h (struct language_defn) <la_is_string_type_p>: New
4752         member variable.
4753         (default_is_string_type_p): Declare new function.
4754         * m2-lang.c (m2_language_defn): Initialise new field.
4755         * objc-lang.c (objc_language_defn): Initialise new field.
4756         * opencl-lang.c (opencl_language_defn): Initialise new field.
4757         * p-lang.c (pascal_is_string_type_p): New function.
4758         (pascal_language_defn): Initialise new field.
4759         * rust-lang.c (rust_is_string_type_p): New function.
4760         (rust_language_defn): Initialise new field.
4761
4762 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4763
4764         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4765         New field.
4766         * ada-lang.c (ada_language_defn): Initialise new field.
4767         * c-lang.c (c_language_defn): Likewise.
4768         (cplus_language_defn): Likewise.
4769         (asm_language_defn): Likewise.
4770         (minimal_language_defn): Likewise.
4771         * d-lang.c (d_language_defn): Likewise.
4772         * f-lang.c (f_language_defn): Likewise.
4773         * go-lang.c (go_language_defn): Likewise.
4774         * language.c (unknown_language_defn): Likewise.
4775         (auto_language_defn): Likewise.
4776         * m2-lang.c (m2_language_defn): Likewise.
4777         * objc-lang.c (objc_language_defn): Likewise.
4778         * opencl-lang.c (opencl_language_defn): Likewise.
4779         * p-lang.c (pascal_language_defn): Likewise.
4780         * rust-lang.c (rust_language_defn): Likewise.
4781
4782 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4783
4784         * ada-lang.c (ada_is_character_type): Change return type to bool.
4785         (ada_is_string_type): Likewise.
4786         * ada-lang.h (ada_is_character_type): Update declaration
4787         (ada_is_string_type): Likewise.
4788
4789 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4790
4791         Support style in 'frame|thread apply'
4792
4793         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4794         * record.c (record_start, record_stop): Update callers of
4795         execute_command_to_string with false.
4796         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4797         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4798         methods.
4799         (class string_file): New constructor with term_out parameter.
4800         Override methods term_out and can_emit_style_escape.  New member
4801         term_out.
4802         (class stdio_file): Override can_emit_style_escape.
4803         (class tee_file): Override term_out and can_emit_style_escape.
4804         * utils.h (can_emit_style_escape): Remove.
4805         * utils.c (can_emit_style_escape): Likewise.
4806         Update all callers of can_emit_style_escape (SOMESTREAM) to
4807         SOMESTREAM->can_emit_style_escape.
4808         * source-cache.c (source_cache::get_source_lines): Likewise.
4809         * stack.c (frame_apply_command_count): Call execute_command_to_string
4810         passing the term_out characteristic of the current gdb_stdout.
4811         * thread.c (thr_try_catch_cmd): Likewise.
4812         * top.c (execute_command_to_string): pass term_out parameter
4813         to construct the string_file for the command output.
4814         * ui-file.c (term_cli_styling): New function (most code moved
4815         from utils.c can_emit_style_escape).
4816         (string_file::string_file, string_file::can_emit_style_escape,
4817         stdio_file::can_emit_style_escape, tee_file::term_out,
4818         tee_file::can_emit_style_escape): New functions.
4819
4820 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4821
4822         * NEWS: Mention the new set|show may-call-functions.
4823         * infcall.c (may_call_functions_p): New variable.
4824         (show_may_call_functions_p): New function.
4825         (call_function_by_hand_dummy): Throws an error if not
4826         may-call-functions.
4827         (_initialize_infcall): Call add_setshow_boolean_cmd for
4828         may-call-functions.
4829
4830 2019-04-25  Keith Seitz  <keiths@redhat.com>
4831
4832         PR c++/24367
4833         * cp-support.c (inspect_type): Don't attempt substitutions
4834         of symbol with the same name.
4835
4836 2019-04-25  Tom Tromey  <tromey@adacore.com>
4837
4838         PR gdb/24475:
4839         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4840         static.
4841
4842 2019-04-25  Tom Tromey  <tromey@adacore.com>
4843
4844         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4845         rvalue reference.
4846         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4847         (gdb_xml_parser::parse): Use std::move.
4848         * python/python-internal.h (gdbpy_convert_exception): Take a const
4849         reference.
4850         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4851         std::move.
4852         * python/py-utils.c (gdbpy_convert_exception): Take a const
4853         reference.
4854         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4855         Use std::move.
4856         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4857         Use std::move.
4858         * mi/mi-main.c (mi_print_exception): Take a const reference.
4859         * main.c (handle_command_errors): Take a const reference.
4860         * linespec.c (parse_linespec): Use std::move.
4861         * infcall.c (run_inferior_call): Use std::move.
4862         (call_function_by_hand_dummy): Use std::move.
4863         * exec.c (try_open_exec_file): Use std::move.
4864         * exceptions.h (exception_print, exception_fprintf)
4865         (exception_print_same): Update.
4866         * exceptions.c (print_exception, exception_print)
4867         (exception_fprintf, exception_print_same): Change parameters to
4868         const reference.
4869         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4870         * common/new-op.c: Use std::move.
4871         * common/common-exceptions.h (struct gdb_exception): Add move
4872         constructor.
4873         (struct gdb_exception_error, struct gdb_exception_quit, struct
4874         gdb_quit_bad_alloc): Change constructor to move constructor.
4875         (throw_exception): Change parameter to rvalue reference.
4876         * common/common-exceptions.c (throw_exception): Take rvalue
4877         reference.
4878         * cli/cli-interp.c (safe_execute_command): Use std::move.
4879         * breakpoint.c (insert_bp_location, location_to_sals): Use
4880         std::move.
4881
4882 2019-04-25  Tom Tromey  <tromey@adacore.com>
4883
4884         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4885         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4886         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4887         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4888         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4889         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4890         guile/scm-value.c: Use unpack.
4891         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4892         gdbscm_gdb_exception.
4893         (gdbscm_throw_gdb_exception): Likewise.
4894         (struct gdbscm_gdb_exception): New.
4895         (unpack): New function.
4896         (gdbscm_wrap): Use unpack.
4897
4898 2019-04-25  Tom Tromey  <tromey@adacore.com>
4899
4900         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4901         (gdb_rl_callback_handler): Use std::move.
4902         * common/common-exceptions.h (struct gdb_exception): Add move
4903         assignment operator.
4904         (throw_exception_sjlj): Change "exception" to const reference.
4905         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4906         (throw_exception_sjlj): Change "exception" to const reference.
4907
4908 2019-04-25  Tom Tromey  <tromey@adacore.com>
4909
4910         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4911         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4912         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4913         Update.
4914         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4915         Update.
4916         * mi/mi-interp.c (mi_interp::exec): Update.
4917         * linespec.c (parse_linespec): Update.
4918         * infcall.c (run_inferior_call): Update.
4919         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4920         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4921         (gdbscm_lookup_global_symbol): Update.
4922         * guile/scm-param.c (gdbscm_parameter_value): Update.
4923         * guile/scm-frame.c (gdbscm_frame_read_register)
4924         (gdbscm_frame_read_var): Update.
4925         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4926         * exec.c (try_open_exec_file): Update.
4927         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4928         (gdb_rl_callback_handler): Update.
4929         * common/common-exceptions.h (exception_none): Don't declare.
4930         * common/common-exceptions.c (exception_none): Don't define.
4931         (struct catcher) <exception>: Update.
4932         * cli/cli-interp.c (safe_execute_command): Update.
4933         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4934
4935 2019-04-25  Ali Tamur  <tamur@google.com>
4936
4937         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4938         (read_attribute_value): Likewise.
4939         (dwarf2_read_addr_index): Update comment.
4940         (read_str_index): Add DW_FORM_strx.
4941         (dwarf2_string_attr): Likewise.
4942         (dwarf2_const_value_attr): Likewise.
4943         (dump_die_shallow): Likewise.
4944         (dwarf2_fetch_constant_bytes): Likewise.
4945         (skip_form_bytes): Likewise.
4946         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4947
4948 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4949
4950         PR corefiles/11608
4951         PR corefiles/18187
4952         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4953         OFFSET.  Verify if current mapping contains an ELF header.
4954         (linux_find_memory_regions_full): Adjust call to
4955         dump_mapping_p.
4956
4957 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4958             Kang Li <kanglictf@gmail.com>
4959
4960         PR gdb/21600
4961
4962         * dwarf2-frame.c (read_initial_length): Be consistent about using
4963         unsigned representation of length.
4964         (decode_frame_entry_1): Likewise.  Check for wraparound of
4965         end pointer as well as buffer overflow.
4966
4967 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4968
4969         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4970         "vq".
4971
4972 2019-04-24  Tom Tromey  <tromey@adacore.com>
4973
4974         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4975
4976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4977
4978         * s12z-tdep.c (s12z_unwind_pc): Delete.
4979         (s12z_unwind_sp): Delete.
4980         (s12z_gdbarch_init): Don't register deleted functions with
4981         gdbarch.
4982
4983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4984
4985         * rl78-tdep.c (rl78_unwind_sp): Delete.
4986         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4987
4988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4991         (xstormy16_unwind_pc): Delete.
4992         (xstormy16_dummy_id): Delete.
4993         (xstormy16_gdbarch_init): Don't register deleted functions with
4994         gdbarch.
4995
4996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4997
4998         * vax-tdep.c (vax_unwind_pc): Delete.
4999         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5000
5001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5002
5003         * v850-tdep.c (v850_unwind_sp): Delete.
5004         (v850_unwind_pc): Delete.
5005         (v850_dummy_id): Delete.
5006         (v850_gdbarch_init): Don't register deleted functions with
5007         gdbarch.
5008
5009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5010
5011         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5012         (tilegx_unwind_pc): Delete.
5013         (tilegx_unwind_dummy_id): Delete.
5014         (tilegx_gdbarch_init): Don't register deleted functions with
5015         gdbarch.
5016
5017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5020         (tic6x_dummy_id): Delete.
5021         (tic6x_gdbarch_init): Don't register deleted functions with
5022         gdbarch.
5023
5024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5025
5026         * sparc-tdep.c (sparc_unwind_pc): Delete.
5027         (sparc32_gdbarch_init): Don't register deleted function with
5028         gdbarch.
5029
5030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5031
5032         * sh-tdep.c (sh_unwind_sp): Delete.
5033         (sh_unwind_pc): Delete.
5034         (sh_dummy_id): Delete.
5035         (sh_gdbarch_init): Don't register deleted functions with
5036         gdbarch.
5037
5038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5039
5040         * score-tdep.c (score_unwind_sp): Delete.
5041         (score_unwind_pc): Delete.
5042         (score_dummy_id): Delete.
5043         (score_gdbarch_init): Don't register deleted functions with
5044         gdbarch.
5045
5046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5047
5048         * rx-tdep.c (rx_unwind_pc): Delete.
5049         (rx_unwind_sp): Delete.
5050         (rx_dummy_id): Delete.
5051         (rx_gdbarch_init): Don't register deleted functions with
5052         gdbarch.  Update comment.
5053
5054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5055
5056         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5057         (rs6000_dummy_id): Delete.
5058         (rs6000_gdbarch_init): Don't register deleted functions with
5059         gdbarch.
5060
5061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5062
5063         * or1k-tdep.c (or1k_dummy_id): Delete.
5064         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5065
5066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5067
5068         * nios2-tdep.c (nios2_dummy_id): Delete.
5069         (nios2_unwind_sp): Delete.
5070         (nios2_gdbarch_init): Don't register deleted functions with
5071         gdbarch.
5072
5073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * nds32-tdep.c (nds32_dummy_id): Delete.
5076         (nds32_unwind_pc): Delete.
5077         (nds32_unwind_sp): Delete.
5078         (nds32_gdbarch_init): Don't register deleted functions with
5079         gdbarch.
5080
5081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5082
5083         * msp430-tdep.c (msp430_unwind_pc): Delete.
5084         (msp430_unwind_sp): Delete.
5085         (msp430_dummy_id): Delete.
5086         (msp430_gdbarch_init): Don't register deleted functions with
5087         gdbarch.
5088
5089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5090
5091         * moxie-tdep.c (moxie_unwind_sp): Delete.
5092         (moxie_unwind_pc): Delete.
5093         (moxie_dummy_id): Delete.
5094         (moxie_gdbarch_init): Don't register deleted functions with
5095         gdbarch.
5096
5097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5100         (mn10300_unwind_pc): Delete.
5101         (mn10300_unwind_sp): Delete.
5102         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5103         mn10300_unwind_sp.
5104         (mn10300_frame_unwind_init): Don't register deleted functions with
5105         gdbarch.
5106
5107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5108
5109         * mep-tdep.c (mep_unwind_pc): Delete.
5110         (mep_unwind_sp): Delete.
5111         (mep_dummy_id): Delete.
5112         (mep_gdbarch_init): Don't register deleted functions with
5113         gdbarch.
5114
5115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5116
5117         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5118         (m68hc11_unwind_sp): Delete.
5119         (m68hc11_gdbarch_init): Don't register deleted functions with
5120         gdbarch.
5121
5122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5123
5124         * m32r-tdep.c (m32r_unwind_sp): Delete.
5125         (m32r_unwind_pc): Delete.
5126         (m32r_dummy_id): Delete.
5127         (m32r_gdbarch_init): Don't register deleted functions with
5128         gdbarch.
5129
5130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5131
5132         * m32c-tdep.c (m32c_unwind_pc): Delete.
5133         (m32c_unwind_sp): Delete.
5134         (m32c_dummy_id): Delete.
5135         (m32c_gdbarch_init): Don't register deleted functions with
5136         gdbarch.
5137
5138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5139
5140         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5141         (lm32_unwind_pc): Delete.
5142         (lm32_dummy_id): Delete.
5143         (lm32_gdbarch_init): Don't register deleted functions with
5144         gdbarch.
5145
5146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5147
5148         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5149         (iq2000_unwind_pc): Delete.
5150         (iq2000_dummy_id): Delete.
5151         (iq2000_gdbarch_init): Don't register deleted functions with
5152         gdbarch.
5153
5154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5155
5156         * nds32-tdep.c (nds32_type_align): Delete.
5157         (nds32_push_dummy_call): Use type_align instead.
5158
5159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         * arm-tdep.c (arm_type_align): Only handle vector override case.
5162         (arm_push_dummy_call): Use type_align.
5163         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5164
5165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5168         case.
5169         (pass_on_stack): Use type_align.
5170         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5171         function.
5172
5173 2019-04-23  Tom Tromey  <tromey@adacore.com>
5174
5175         * dwarf2read.c (line_header::file_name_at): Remove unused
5176         overload.
5177
5178 2019-04-23  Tom de Vries  <tdevries@suse.de>
5179
5180         PR gdb/24438
5181         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5182         invocation.
5183
5184
5185 2019-03-27  Ali Tamur  <tamur@google.com>
5186
5187         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5188         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5189         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5190         (dwarf_expr_context::get_addr_index): Likewise
5191         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5192         (symbol_needs_eval_context::get_addr_index): Likewise
5193         (disassemble_dwarf_expression): Add DW_OP_addrx
5194         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5195         (read_cutu_die_from_dwo): Update comment
5196         (skip_one_die): Add DW_FORM_addrx
5197         (read_attribute_value): Likewise
5198         (var_decode_location): Add DW_OP_addrx
5199         (dwarf2_const_value_attr): Add DW_FORM_addrx
5200         (dump_die_shallow): Likewise
5201         (dwarf2_fetch_constant_bytes): Likewise
5202         (decode_locdesc): Add DW_OP_addrx
5203         (skip_form_bytes): Add DW_FORM_addrx
5204
5205 2019-04-22  Ali Tamur  <tamur@google.com>
5206
5207         * MAINTAINERS (Write After Approval): Add self.
5208
5209 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5210
5211         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5212         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5213         (open_symbol_file_object): Likewise.
5214         (svr4_default_sos): Add info parameter.
5215         (svr4_read_so_list): Likewise.
5216         (svr4_current_sos_direct): Adjust functions calls to pass down
5217         info.
5218         (svr4_current_sos_1): Add info parameter.
5219         (svr4_current_sos): Call get_svr4_info, pass info down to
5220         svr4_current_sos_1.
5221         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5222         get_svr4_info.
5223         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5224         get_svr4_info.
5225         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5226         to get_svr4_info.
5227         (probes_table_remove_objfile_probes): Likewise.
5228         (register_solib_event_probe): Add info parameter.
5229         (solist_update_incremental): Pass info parameter down to
5230         svr4_read_so_list.
5231         (disable_probes_interface): Add info parameter.
5232         (svr4_handle_solib_event): Pass current_program_space to
5233         get_svr4_info.  Adjust disable_probes_interface cleanup.
5234         (svr4_create_probe_breakpoints): Add info parameter, pass it
5235         down to register_solib_event_probe.
5236         (svr4_create_solib_event_breakpoints): Add info parameter,
5237         pass it down to svr4_create_probe_breakpoints.
5238         (enable_break): Pass info down to
5239         svr4_create_solib_event_breakpoints.
5240         (svr4_solib_create_inferior_hook): Pass current_program_space to
5241         get_svr4_info.
5242         (svr4_clear_solib): Likewise.
5243
5244 2019-04-22  Pedro Alves  <palves@redhat.com>
5245
5246         * solib-svr4.c (svr4_free_objfile_observer): New.
5247         (probe_and_action::objfile): New field.
5248         (probes_table_htab_remove_objfile_probes)
5249         (probes_table_remove_objfile_probes): New functions.
5250         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5251         in the new probe_and_action.  Don't store the probe in 'lookup'.
5252         (svr4_create_probe_breakpoints): Pass objfile to
5253         register_solib_event_probe.
5254         (_initialize_svr4_solib): Register a free_objfile observer.
5255
5256 2019-04-19  Tom Tromey  <tom@tromey.com>
5257
5258         * common/queue.h: Remove.
5259
5260 2019-04-19  Tom Tromey  <tom@tromey.com>
5261
5262         * event-loop.c: Don't include "common/queue.h".
5263
5264 2019-04-19  Tom Tromey  <tom@tromey.com>
5265
5266         * remote.c (remote_target): Use delete.
5267         * remote-notif.h: Include <list>, not "common/queue.h".
5268         (notif_client_p): Remove typedef.
5269         (remote_notif_state): Add constructor, destructor, initializer.
5270         <notif_queue>: Now a std::list.
5271         (remote_notif_state_xfree): Don't declare.
5272         * remote-notif.c (remote_notif_process, handle_notification)
5273         (remote_notif_state_allocate): Update.
5274         (~remote_notif_state): Rename from remote_notif_state_xfree.
5275
5276 2019-04-19  Tom Tromey  <tom@tromey.com>
5277
5278         * symfile.c (reread_symbols): Update.
5279         * objfiles.c (objfile_register_static_link)
5280         (objfile_lookup_static_link): Update
5281         (~objfile) Don't delete static_links.
5282         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5283
5284 2019-04-19  Tom Tromey  <tom@tromey.com>
5285
5286         * type-stack.h (struct type_stack) <insert>: Constify string.
5287         * type-stack.c (type_stack::insert): Constify string.
5288         * gdbtypes.h (lookup_template_type): Update.
5289         (address_space_name_to_int): Update.
5290         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5291         const.
5292         (lookup_template_type): Make name const.
5293         * c-exp.y: Update rules.
5294         (lex_one_token, classify_name, classify_inner_name)
5295         (c_print_token): Update.
5296         * p-exp.y: Update rules.
5297         (yylex): Update.
5298         * f-exp.y: Update rules.
5299         (yylex): Update.
5300         * d-exp.y: Update rules.
5301         (lex_one_token, classify_name, classify_inner_name): Update.
5302         * parse.c (write_dollar_variable, copy_name): Return std::string.
5303         * parser-defs.h (copy_name): Change return type.
5304         * m2-exp.y: Update rules.
5305         (yylex): Update.
5306         * go-exp.y (lex_one_token): Update.
5307         Update rules.
5308         (classify_unsafe_function, classify_packaged_name)
5309         (classify_name, yylex): Update.
5310
5311 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5312
5313         * configure.ac: add --enable-source-highlight switch.
5314         * configure: Regenerate.
5315         * top.c (print_gdb_version): plumb --enable-source-highlight
5316         status to "show configuration".
5317
5318 2019-04-19  Tom Tromey  <tromey@adacore.com>
5319
5320         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5321         Check ADA_TYPE_P.
5322         (empty_record, ada_template_to_fixed_record_type_1)
5323         (template_to_static_fixed_type)
5324         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5325         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5326         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5327         macros.
5328
5329 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5330
5331         PR symtab/24423:
5332         * source.c (print_source_lines_base): Advance "iter" when a
5333         control character is seen.
5334
5335 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5336
5337         * inferior.h (struct infcall_suspend_state_deleter):
5338         Catch exception in destructor to avoid crash.
5339
5340 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5341
5342         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5343         close to the add_com "shell".
5344
5345 2019-04-18  Tom Tromey  <tromey@adacore.com>
5346
5347         * process-stratum-target.h (class process_stratum_target)
5348         <stratum>: Add "final".
5349
5350 2019-04-17  Tom Tromey  <tromey@adacore.com>
5351
5352         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5353         against nullptr before use.
5354
5355 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5356
5357         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5358
5359 2019-04-17  Jim Wilson  <jimw@sifive.com>
5360             Andrew Burgess  <andrew.burgess@embecosm.com>
5361
5362         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5363         code read might fail, assume 4-byte breakpoint in that case.
5364
5365 2019-04-15  Leszek Swirski  <leszeks@google.com>
5366
5367         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5368         rather than a hand-rolled POD check when checking for forced MEMORY
5369         classification.
5370
5371 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5372
5373         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5374         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5375         function.
5376         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5377         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5378         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5379         declaration.
5380
5381 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5382
5383         * aarch64-linux-nat.c
5384         (aarch64_linux_nat_target::thread_architecture): Add override.
5385         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5386         each VQ.
5387
5388 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5389
5390         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5391
5392 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5393
5394         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5395         target types of size 96-bits, add some additional comments, and
5396         check that the builtin type we found was the correct size.
5397
5398 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5399
5400         * utils.c (prompt_for_continue): Don't restore the styling at the
5401         end, as applied_style has the wrong value.  This fixes styling in
5402         long lists of file names that are interrupted by the "Continue?"
5403         prompt.
5404
5405 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5406
5407         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5408         * c-lang.c (c_language_defn): Likewise.
5409         (cplus_language_defn): Likewise.
5410         (asm_language_defn): Likewise.
5411         (minimal_language_defn): Likewise.
5412         * d-lang.c (d_language_defn): Likewise.
5413         * f-lang.c (f_language_defn): Likewise.
5414         * go-lang.c (go_language_defn): Likewise.
5415         * language.c (unknown_language_defn): Likewise.
5416         (auto_language_defn): Likewise.
5417         * language.h (struct language_defn): Remove la_magic field.
5418         (LANG_MAGIC): Delete.
5419         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5420         * objc-lang.c (objc_language_defn): Likewise.
5421         * opencl-lang.c (opencl_language_defn): Likewise.
5422         * p-lang.c (pascal_language_defn): Likewise.
5423         * rust-lang.c (rust_language_defn): Likewise.
5424
5425 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5426
5427         * riscv-tdep.c (riscv_type_align): New function.
5428         (riscv_type_alignment): Delete.
5429         (riscv_arg_location): Use 'type_align'.
5430         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5431
5432 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * gdbtypes.c (type_align): A struct with no non-static fields also
5435         has alignment of 1.
5436
5437 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5438
5439         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5440         component to 0.
5441         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5442         member.
5443         (riscv_struct_info::analyse): New implementation using new
5444         analyse_inner member function.
5445         (riscv_struct_info::field_offset): New member function.
5446         (riscv_struct_info::m_offsets): New member variable.
5447         (riscv_struct_info::analyse_inner): New private member function,
5448         takes the old implementation of riscv_struct_info::analyse but
5449         extended to track field offsets.
5450         (riscv_call_arg_struct): Update the struct folding special cases
5451         to handle cases where empty C++ structs, which are non-zero
5452         length, are found.
5453         (riscv_arg_location): Initialise the length of each location, a
5454         non-zero length now indicates the location is in use.
5455         (riscv_push_dummy_call): Allow for the first location having a
5456         non-zero offset when setting up arguments.
5457         (riscv_return_value): Likewise, but for return values.
5458
5459 2019-04-11  Tom Tromey  <tromey@adacore.com>
5460
5461         * utils.c (internal_vproblem): Make "msg" const.
5462
5463 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5464
5465         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5466         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5467         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5468         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5469
5470 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5471
5472         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5473         function.
5474         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5475         of amd64_collect_native_gregset.
5476         (amd64_linux_nat_target::store_registers): Likewise.
5477
5478 2019-04-10  Tom Tromey  <tom@tromey.com>
5479
5480         * symtab.c (lookup_global_symbol_from_objfile)
5481         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5482         * objfiles.h (class separate_debug_iterator): New.
5483         (class separate_debug_range): New.
5484         (struct objfile) <separate_debug_objfiles>: New method.
5485         (objfile_separate_debug_iterate): Don't declare.
5486         * objfiles.c (separate_debug_iterator::operator++): Rename from
5487         objfile_separate_debug_iterate.
5488         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5489         iterator.
5490         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5491         iterator.
5492
5493 2019-04-10  Tom Tromey  <tom@tromey.com>
5494
5495         * symfile.c (reread_symbols): Remove old comment.
5496         * objfiles.c (free_all_objfiles): Fix a typo.
5497
5498 2019-04-10  Tom Tromey  <tom@tromey.com>
5499
5500         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5501         * minsyms.c (lookup_minimal_symbol): Use foreach.
5502         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5503         (lookup_minimal_symbol_solib_trampoline): Likewise.
5504         * symfile.c (reread_symbols): Use foreach.
5505
5506 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5507             Tom Tromey  <tromey@adacore.com>
5508
5509         PR rust/24414:
5510         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5511         (rust_lex_int_test): Change "value" to be LONGEST.
5512         (rust_lex_tests): Add test for long integer literal.
5513
5514 2019-04-09  Tom Tromey  <tromey@adacore.com>
5515
5516         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5517         to bool.
5518         (extended_remote_target::attach): Update.
5519         (remote_target::remote_notice_new_inferior): Update.
5520         (remote_target::add_current_inferior_and_thread): Update.
5521         * inferior.c (exit_inferior_1): Use "false".
5522         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5523
5524 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5525
5526         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5527         the "start" command.
5528
5529 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5530
5531         * python/py-inferior.c (infpy_thread_from_thread_handle):
5532         Adjust comments to reflect renaming of thread_from_thread_handle
5533         to thread_from_handle.  Adjust keywords.  Fix type error message.
5534         (inferior_object_methods): Add thread_from_handle.  Retain
5535         thread_from_thread_handle, but mark it as deprecated.
5536
5537 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5538
5539         * gdbthread.h (find_thread_by_handle): Revise declaration.
5540         * thread.c (find_thread_by_handle): Likewise.  Adjust
5541         implementation too.
5542         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5543         support for buffer objects as handles.
5544
5545 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5546
5547         * python/py-infthread.c (thpy_thread_handle): New function.
5548         (thread_object_methods): Register thpy_thread_handle.
5549
5550 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5551
5552         * gdbthread.h (thread_to_thread_handle): Declare.
5553         * thread.c (gdbtypes.h): Include.
5554         (thread_to_thread_handle): New function.
5555
5556         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5557         (target_thread_info_to_thread_handle): Declare.
5558         * target.c (target_thread_info_to_thread_handle): New function.
5559         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5560         * target-delegates.c: Regenerate.
5561
5562         * linux-thread-db.c (class thread_db_target): Add method
5563         thread_info_to_thread_handle.
5564         (thread_db_target::thread_info_to_thread_handle): Define.
5565         * remote.c (class remote_target): Add new method
5566         thread_info_to_thread_handle.
5567         (remote_target::thread_info_to_thread_handle): Define.
5568
5569 2019-04-08  Pedro Alves  <palves@redhat.com>
5570
5571         * common/common-exceptions.c (throw_exception): Don't create
5572         named object to throw; throw directly.
5573         (throw_it): Likewise.  Don't initialize gdb_exception::message
5574         here, with new; pass FMT and AP to the ctor instead.
5575         * common/common-exceptions.h: Include <string>.
5576         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5577         const char *, va_list)): New ctor.  Use std::make_shared.
5578         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5579         errors)): Delete.
5580         (gdb_exception_error::gdb_exception_error(enum errors, const char
5581         *, va_list)): New.
5582         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5583         Add assertion.
5584         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5585         errors)): Delete.
5586         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5587         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5588         Add assertion.
5589
5590 2019-04-08  Tom Tromey  <tom@tromey.com>
5591
5592         * valops.c (value_rtti_indirect_type): Replace throw_exception
5593         with throw.
5594         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5595         with throw.
5596         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5597         throw.
5598         * target.c (target_translate_tls_address): Replace throw_exception
5599         with throw.
5600         * stack.c (frame_apply_command_count): Replace throw_exception
5601         with throw.
5602         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5603         throw.
5604         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5605         with throw.
5606         * rs6000-tdep.c (rs6000_frame_cache)
5607         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5608         * remote.c: Replace throw_exception with throw.
5609         * record-full.c (record_full_message, record_full_wait_1)
5610         (record_full_restore): Replace throw_exception with throw.
5611         * record-btrace.c:
5612         (get_thread_current_frame_id, record_btrace_start_replaying)
5613         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5614         (cmd_record_btrace_start): Replace throw_exception with throw.
5615         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5616         throw.
5617         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5618         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5619         * linespec.c:
5620         (find_linespec_symbols): Replace throw_exception with throw.
5621         * infrun.c (displaced_step_prepare, resume): Replace
5622         throw_exception with throw.
5623         * infcmd.c (post_create_inferior): Replace throw_exception with
5624         throw.
5625         * inf-loop.c (inferior_event_handler): Replace throw_exception
5626         with throw.
5627         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5628         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5629         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5630         (get_prev_frame_always, get_frame_pc_if_available)
5631         (get_frame_address_in_block_if_available, get_frame_language):
5632         Replace throw_exception with throw.
5633         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5634         throw_exception with throw.
5635         * eval.c (fetch_subexp_value, evaluate_var_value)
5636         (evaluate_funcall, evaluate_subexp_standard): Replace
5637         throw_exception with throw.
5638         * dwarf2loc.c (call_site_find_chain)
5639         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5640         Replace throw_exception with throw.
5641         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5642         with throw.
5643         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5644         throw.
5645         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5646         * completer.c (complete_line_internal): Replace throw_exception
5647         with throw.
5648         * compile/compile-object-run.c (compile_object_run): Replace
5649         throw_exception with throw.
5650         * cli/cli-script.c (process_next_line): Replace throw_exception
5651         with throw.
5652         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5653         (btrace_enable, btrace_maint_update_pt_packets): Replace
5654         throw_exception with throw.
5655         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5656         throw_exception with throw.
5657         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5658         throw_exception with throw.
5659         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5660         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5661         * aarch64-tdep.c (aarch64_make_prologue_cache)
5662         (aarch64_make_stub_cache): Replace throw_exception with throw.
5663
5664 2019-04-08  Tom Tromey  <tom@tromey.com>
5665
5666         * common/common-exceptions.c (throw_exception): Rename from
5667         throw_exception_cxx.  Remove old copy.  Make argument const.
5668         (throw_it): Create and throw exception objects directly.
5669         * common/common-exceptions.h (throw_exception): Make argument
5670         const.
5671         (struct gdb_exception_error): Add constructor.
5672         (struct gdb_exception_quit): Add constructor.
5673
5674 2019-04-08  Tom Tromey  <tom@tromey.com>
5675
5676         * common/common-exceptions.h (exception_rethrow): Don't declare.
5677         (TRY_SJLJ): Update comment.
5678         (TRY, CATCH, END_CATCH): Remove.
5679         * common/common-exceptions.c (exception_rethrow): Remove.
5680
5681 2019-04-08  Tom Tromey  <tom@tromey.com>
5682
5683         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5684         Remove.
5685         (gdb_exception_error): Rename from
5686         gdb_exception_RETURN_MASK_ERROR.
5687         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5688         (gdb_quit_bad_alloc): Update.
5689         * aarch64-tdep.c: Update.
5690         * ada-lang.c: Update.
5691         * ada-typeprint.c: Update.
5692         * ada-valprint.c: Update.
5693         * amd64-tdep.c: Update.
5694         * arch-utils.c: Update.
5695         * break-catch-throw.c: Update.
5696         * breakpoint.c: Update.
5697         * btrace.c: Update.
5698         * c-varobj.c: Update.
5699         * cli/cli-cmds.c: Update.
5700         * cli/cli-interp.c: Update.
5701         * cli/cli-script.c: Update.
5702         * common/common-exceptions.c: Update.
5703         * common/new-op.c: Update.
5704         * common/selftest.c: Update.
5705         * compile/compile-c-symbols.c: Update.
5706         * compile/compile-cplus-symbols.c: Update.
5707         * compile/compile-object-load.c: Update.
5708         * compile/compile-object-run.c: Update.
5709         * completer.c: Update.
5710         * corelow.c: Update.
5711         * cp-abi.c: Update.
5712         * cp-support.c: Update.
5713         * cp-valprint.c: Update.
5714         * darwin-nat.c: Update.
5715         * disasm-selftests.c: Update.
5716         * dtrace-probe.c: Update.
5717         * dwarf-index-cache.c: Update.
5718         * dwarf-index-write.c: Update.
5719         * dwarf2-frame-tailcall.c: Update.
5720         * dwarf2-frame.c: Update.
5721         * dwarf2loc.c: Update.
5722         * dwarf2read.c: Update.
5723         * eval.c: Update.
5724         * event-loop.c: Update.
5725         * event-top.c: Update.
5726         * exec.c: Update.
5727         * f-valprint.c: Update.
5728         * fbsd-tdep.c: Update.
5729         * frame-unwind.c: Update.
5730         * frame.c: Update.
5731         * gdbtypes.c: Update.
5732         * gnu-v3-abi.c: Update.
5733         * guile/guile-internal.h: Update.
5734         * guile/scm-block.c: Update.
5735         * guile/scm-breakpoint.c: Update.
5736         * guile/scm-cmd.c: Update.
5737         * guile/scm-disasm.c: Update.
5738         * guile/scm-frame.c: Update.
5739         * guile/scm-lazy-string.c: Update.
5740         * guile/scm-math.c: Update.
5741         * guile/scm-param.c: Update.
5742         * guile/scm-ports.c: Update.
5743         * guile/scm-pretty-print.c: Update.
5744         * guile/scm-symbol.c: Update.
5745         * guile/scm-symtab.c: Update.
5746         * guile/scm-type.c: Update.
5747         * guile/scm-value.c: Update.
5748         * i386-linux-tdep.c: Update.
5749         * i386-tdep.c: Update.
5750         * inf-loop.c: Update.
5751         * infcall.c: Update.
5752         * infcmd.c: Update.
5753         * infrun.c: Update.
5754         * jit.c: Update.
5755         * language.c: Update.
5756         * linespec.c: Update.
5757         * linux-fork.c: Update.
5758         * linux-nat.c: Update.
5759         * linux-tdep.c: Update.
5760         * linux-thread-db.c: Update.
5761         * main.c: Update.
5762         * mi/mi-cmd-break.c: Update.
5763         * mi/mi-cmd-stack.c: Update.
5764         * mi/mi-interp.c: Update.
5765         * mi/mi-main.c: Update.
5766         * objc-lang.c: Update.
5767         * p-valprint.c: Update.
5768         * parse.c: Update.
5769         * ppc-linux-tdep.c: Update.
5770         * printcmd.c: Update.
5771         * python/py-arch.c: Update.
5772         * python/py-breakpoint.c: Update.
5773         * python/py-cmd.c: Update.
5774         * python/py-finishbreakpoint.c: Update.
5775         * python/py-frame.c: Update.
5776         * python/py-framefilter.c: Update.
5777         * python/py-gdb-readline.c: Update.
5778         * python/py-inferior.c: Update.
5779         * python/py-infthread.c: Update.
5780         * python/py-lazy-string.c: Update.
5781         * python/py-linetable.c: Update.
5782         * python/py-objfile.c: Update.
5783         * python/py-param.c: Update.
5784         * python/py-prettyprint.c: Update.
5785         * python/py-progspace.c: Update.
5786         * python/py-record-btrace.c: Update.
5787         * python/py-record.c: Update.
5788         * python/py-symbol.c: Update.
5789         * python/py-type.c: Update.
5790         * python/py-unwind.c: Update.
5791         * python/py-utils.c: Update.
5792         * python/py-value.c: Update.
5793         * python/python.c: Update.
5794         * record-btrace.c: Update.
5795         * record-full.c: Update.
5796         * remote-fileio.c: Update.
5797         * remote.c: Update.
5798         * riscv-tdep.c: Update.
5799         * rs6000-aix-tdep.c: Update.
5800         * rs6000-tdep.c: Update.
5801         * rust-exp.y: Update.
5802         * rust-lang.c: Update.
5803         * s390-tdep.c: Update.
5804         * selftest-arch.c: Update.
5805         * solib-dsbt.c: Update.
5806         * solib-frv.c: Update.
5807         * solib-spu.c: Update.
5808         * solib-svr4.c: Update.
5809         * solib.c: Update.
5810         * sparc64-linux-tdep.c: Update.
5811         * stack.c: Update.
5812         * symfile-mem.c: Update.
5813         * symmisc.c: Update.
5814         * target.c: Update.
5815         * thread.c: Update.
5816         * top.c: Update.
5817         * tracefile-tfile.c: Update.
5818         * tui/tui.c: Update.
5819         * typeprint.c: Update.
5820         * unittests/cli-utils-selftests.c: Update.
5821         * unittests/parse-connection-spec-selftests.c: Update.
5822         * valops.c: Update.
5823         * valprint.c: Update.
5824         * value.c: Update.
5825         * varobj.c: Update.
5826         * windows-nat.c: Update.
5827         * x86-linux-nat.c: Update.
5828         * xml-support.c: Update.
5829
5830 2019-04-08  Tom Tromey  <tom@tromey.com>
5831
5832         * xml-support.c: Use C++ exception handling.
5833         * x86-linux-nat.c: Use C++ exception handling.
5834         * windows-nat.c: Use C++ exception handling.
5835         * varobj.c: Use C++ exception handling.
5836         * value.c: Use C++ exception handling.
5837         * valprint.c: Use C++ exception handling.
5838         * valops.c: Use C++ exception handling.
5839         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5840         handling.
5841         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5842         * typeprint.c: Use C++ exception handling.
5843         * tui/tui.c: Use C++ exception handling.
5844         * tracefile-tfile.c: Use C++ exception handling.
5845         * top.c: Use C++ exception handling.
5846         * thread.c: Use C++ exception handling.
5847         * target.c: Use C++ exception handling.
5848         * symmisc.c: Use C++ exception handling.
5849         * symfile-mem.c: Use C++ exception handling.
5850         * stack.c: Use C++ exception handling.
5851         * sparc64-linux-tdep.c: Use C++ exception handling.
5852         * solib.c: Use C++ exception handling.
5853         * solib-svr4.c: Use C++ exception handling.
5854         * solib-spu.c: Use C++ exception handling.
5855         * solib-frv.c: Use C++ exception handling.
5856         * solib-dsbt.c: Use C++ exception handling.
5857         * selftest-arch.c: Use C++ exception handling.
5858         * s390-tdep.c: Use C++ exception handling.
5859         * rust-lang.c: Use C++ exception handling.
5860         * rust-exp.y: Use C++ exception handling.
5861         * rs6000-tdep.c: Use C++ exception handling.
5862         * rs6000-aix-tdep.c: Use C++ exception handling.
5863         * riscv-tdep.c: Use C++ exception handling.
5864         * remote.c: Use C++ exception handling.
5865         * remote-fileio.c: Use C++ exception handling.
5866         * record-full.c: Use C++ exception handling.
5867         * record-btrace.c: Use C++ exception handling.
5868         * python/python.c: Use C++ exception handling.
5869         * python/py-value.c: Use C++ exception handling.
5870         * python/py-utils.c: Use C++ exception handling.
5871         * python/py-unwind.c: Use C++ exception handling.
5872         * python/py-type.c: Use C++ exception handling.
5873         * python/py-symbol.c: Use C++ exception handling.
5874         * python/py-record.c: Use C++ exception handling.
5875         * python/py-record-btrace.c: Use C++ exception handling.
5876         * python/py-progspace.c: Use C++ exception handling.
5877         * python/py-prettyprint.c: Use C++ exception handling.
5878         * python/py-param.c: Use C++ exception handling.
5879         * python/py-objfile.c: Use C++ exception handling.
5880         * python/py-linetable.c: Use C++ exception handling.
5881         * python/py-lazy-string.c: Use C++ exception handling.
5882         * python/py-infthread.c: Use C++ exception handling.
5883         * python/py-inferior.c: Use C++ exception handling.
5884         * python/py-gdb-readline.c: Use C++ exception handling.
5885         * python/py-framefilter.c: Use C++ exception handling.
5886         * python/py-frame.c: Use C++ exception handling.
5887         * python/py-finishbreakpoint.c: Use C++ exception handling.
5888         * python/py-cmd.c: Use C++ exception handling.
5889         * python/py-breakpoint.c: Use C++ exception handling.
5890         * python/py-arch.c: Use C++ exception handling.
5891         * printcmd.c: Use C++ exception handling.
5892         * ppc-linux-tdep.c: Use C++ exception handling.
5893         * parse.c: Use C++ exception handling.
5894         * p-valprint.c: Use C++ exception handling.
5895         * objc-lang.c: Use C++ exception handling.
5896         * mi/mi-main.c: Use C++ exception handling.
5897         * mi/mi-interp.c: Use C++ exception handling.
5898         * mi/mi-cmd-stack.c: Use C++ exception handling.
5899         * mi/mi-cmd-break.c: Use C++ exception handling.
5900         * main.c: Use C++ exception handling.
5901         * linux-thread-db.c: Use C++ exception handling.
5902         * linux-tdep.c: Use C++ exception handling.
5903         * linux-nat.c: Use C++ exception handling.
5904         * linux-fork.c: Use C++ exception handling.
5905         * linespec.c: Use C++ exception handling.
5906         * language.c: Use C++ exception handling.
5907         * jit.c: Use C++ exception handling.
5908         * infrun.c: Use C++ exception handling.
5909         * infcmd.c: Use C++ exception handling.
5910         * infcall.c: Use C++ exception handling.
5911         * inf-loop.c: Use C++ exception handling.
5912         * i386-tdep.c: Use C++ exception handling.
5913         * i386-linux-tdep.c: Use C++ exception handling.
5914         * guile/scm-value.c: Use C++ exception handling.
5915         * guile/scm-type.c: Use C++ exception handling.
5916         * guile/scm-symtab.c: Use C++ exception handling.
5917         * guile/scm-symbol.c: Use C++ exception handling.
5918         * guile/scm-pretty-print.c: Use C++ exception handling.
5919         * guile/scm-ports.c: Use C++ exception handling.
5920         * guile/scm-param.c: Use C++ exception handling.
5921         * guile/scm-math.c: Use C++ exception handling.
5922         * guile/scm-lazy-string.c: Use C++ exception handling.
5923         * guile/scm-frame.c: Use C++ exception handling.
5924         * guile/scm-disasm.c: Use C++ exception handling.
5925         * guile/scm-cmd.c: Use C++ exception handling.
5926         * guile/scm-breakpoint.c: Use C++ exception handling.
5927         * guile/scm-block.c: Use C++ exception handling.
5928         * guile/guile-internal.h: Use C++ exception handling.
5929         * gnu-v3-abi.c: Use C++ exception handling.
5930         * gdbtypes.c: Use C++ exception handling.
5931         * frame.c: Use C++ exception handling.
5932         * frame-unwind.c: Use C++ exception handling.
5933         * fbsd-tdep.c: Use C++ exception handling.
5934         * f-valprint.c: Use C++ exception handling.
5935         * exec.c: Use C++ exception handling.
5936         * event-top.c: Use C++ exception handling.
5937         * event-loop.c: Use C++ exception handling.
5938         * eval.c: Use C++ exception handling.
5939         * dwarf2read.c: Use C++ exception handling.
5940         * dwarf2loc.c: Use C++ exception handling.
5941         * dwarf2-frame.c: Use C++ exception handling.
5942         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5943         * dwarf-index-write.c: Use C++ exception handling.
5944         * dwarf-index-cache.c: Use C++ exception handling.
5945         * dtrace-probe.c: Use C++ exception handling.
5946         * disasm-selftests.c: Use C++ exception handling.
5947         * darwin-nat.c: Use C++ exception handling.
5948         * cp-valprint.c: Use C++ exception handling.
5949         * cp-support.c: Use C++ exception handling.
5950         * cp-abi.c: Use C++ exception handling.
5951         * corelow.c: Use C++ exception handling.
5952         * completer.c: Use C++ exception handling.
5953         * compile/compile-object-run.c: Use C++ exception handling.
5954         * compile/compile-object-load.c: Use C++ exception handling.
5955         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5956         * compile/compile-c-symbols.c: Use C++ exception handling.
5957         * common/selftest.c: Use C++ exception handling.
5958         * common/new-op.c: Use C++ exception handling.
5959         * cli/cli-script.c: Use C++ exception handling.
5960         * cli/cli-interp.c: Use C++ exception handling.
5961         * cli/cli-cmds.c: Use C++ exception handling.
5962         * c-varobj.c: Use C++ exception handling.
5963         * btrace.c: Use C++ exception handling.
5964         * breakpoint.c: Use C++ exception handling.
5965         * break-catch-throw.c: Use C++ exception handling.
5966         * arch-utils.c: Use C++ exception handling.
5967         * amd64-tdep.c: Use C++ exception handling.
5968         * ada-valprint.c: Use C++ exception handling.
5969         * ada-typeprint.c: Use C++ exception handling.
5970         * ada-lang.c: Use C++ exception handling.
5971         * aarch64-tdep.c: Use C++ exception handling.
5972
5973 2019-04-08  Tom Tromey  <tom@tromey.com>
5974
5975         * xml-support.c (gdb_xml_parser::parse): Update.
5976         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5977         * value.c (show_convenience): Update.
5978         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5979         (test_parse_flags_qcs): Update.
5980         * thread.c (thr_try_catch_cmd): Update.
5981         * target.c (target_translate_tls_address): Update.
5982         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5983         (info_frame_command_core, frame_apply_command_count): Update.
5984         * rust-exp.y (rust_lex_exception_test): Update.
5985         * riscv-tdep.c (riscv_print_one_register_info): Update.
5986         * remote.c (remote_target::enable_btrace): Update.
5987         * record-btrace.c (record_btrace_enable_warn): Update.
5988         * python/py-utils.c (gdbpy_convert_exception): Update.
5989         * printcmd.c (do_one_display, print_variable_and_value): Update.
5990         * mi/mi-main.c (mi_print_exception): Update.
5991         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5992         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5993         * linux-nat.c (linux_nat_target::attach): Update.
5994         * linux-fork.c (class scoped_switch_fork_info): Update.
5995         * infrun.c (displaced_step_prepare): Update.
5996         * infcall.c (call_function_by_hand_dummy): Update.
5997         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5998         * gnu-v3-abi.c (print_one_vtable): Update.
5999         * frame.c (get_prev_frame_always): Update.
6000         * f-valprint.c (info_common_command_for_block): Update.
6001         * exec.c (try_open_exec_file): Update.
6002         * exceptions.c (print_exception, exception_print)
6003         (exception_fprintf, exception_print_same): Update.
6004         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6005         * dwarf-index-cache.c (index_cache::store)
6006         (index_cache::lookup_gdb_index): Update.
6007         * darwin-nat.c (maybe_cache_shell): Update.
6008         * cp-valprint.c (cp_print_value_fields): Update.
6009         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6010         (gcc_cplus_symbol_address): Update.
6011         * compile/compile-c-symbols.c (gcc_convert_symbol)
6012         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6013         * common/selftest.c: Update.
6014         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6015         a std::string.
6016         (exception_try_scope_entry, exception_try_scope_exit): Don't
6017         declare.
6018         (struct exception_try_scope): Remove.
6019         (TRY): Don't use exception_try_scope.
6020         (struct gdb_exception): Add constructor, operator=.
6021         <what>: New method.
6022         (struct gdb_exception_RETURN_MASK_ALL)
6023         (struct gdb_exception_RETURN_MASK_ERROR)
6024         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6025         (struct gdb_quit_bad_alloc): Update.
6026         * common/common-exceptions.c (exception_none): Change
6027         initializer.
6028         (struct catcher) <state, exception>: Initialize inline.
6029         <prev>: Remove member.
6030         (current_catcher): Remove.
6031         (catchers): New global.
6032         (exceptions_state_mc_init): Simplify.
6033         (catcher_pop): Remove.
6034         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6035         (try_scope_depth, exception_try_scope_entry)
6036         (exception_try_scope_exit): Remove.
6037         (throw_exception_sjlj): Update.
6038         (exception_messages, exception_messages_size): Remove.
6039         (throw_it): Simplify.
6040         (gdb_exception_sliced_copy): Remove.
6041         (throw_exception_cxx): Update.
6042         * cli/cli-script.c (script_from_file): Update.
6043         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6044         Update.
6045         * ada-valprint.c (ada_val_print): Update.
6046         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6047         (create_excep_cond_exprs): Update.
6048
6049 2019-04-08  Tom Tromey  <tom@tromey.com>
6050
6051         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6052         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6053         (TRY, CATCH, END_CATCH): Remove some definitions.
6054         * common/common-exceptions.c: Don't use GDB_XCPT.
6055         (catcher_list_size): Remove.
6056         (throw_exception, throw_it): Simplify.
6057
6058 2019-04-05  Tom Tromey  <tom@tromey.com>
6059
6060         Revert the header-sorting patch.
6061         * ft32-tdep.c: Revert.
6062         * frv-tdep.c: Revert.
6063         * frv-linux-tdep.c: Revert.
6064         * frame.c: Revert.
6065         * frame-unwind.c: Revert.
6066         * frame-base.c: Revert.
6067         * fork-child.c: Revert.
6068         * findvar.c: Revert.
6069         * findcmd.c: Revert.
6070         * filesystem.c: Revert.
6071         * filename-seen-cache.h: Revert.
6072         * filename-seen-cache.c: Revert.
6073         * fbsd-tdep.c: Revert.
6074         * fbsd-nat.h: Revert.
6075         * fbsd-nat.c: Revert.
6076         * f-valprint.c: Revert.
6077         * f-typeprint.c: Revert.
6078         * f-lang.c: Revert.
6079         * extension.h: Revert.
6080         * extension.c: Revert.
6081         * extension-priv.h: Revert.
6082         * expprint.c: Revert.
6083         * exec.h: Revert.
6084         * exec.c: Revert.
6085         * exceptions.c: Revert.
6086         * event-top.c: Revert.
6087         * event-loop.c: Revert.
6088         * eval.c: Revert.
6089         * elfread.c: Revert.
6090         * dwarf2read.h: Revert.
6091         * dwarf2read.c: Revert.
6092         * dwarf2loc.c: Revert.
6093         * dwarf2expr.h: Revert.
6094         * dwarf2expr.c: Revert.
6095         * dwarf2-frame.c: Revert.
6096         * dwarf2-frame-tailcall.c: Revert.
6097         * dwarf-index-write.h: Revert.
6098         * dwarf-index-write.c: Revert.
6099         * dwarf-index-common.c: Revert.
6100         * dwarf-index-cache.h: Revert.
6101         * dwarf-index-cache.c: Revert.
6102         * dummy-frame.c: Revert.
6103         * dtrace-probe.c: Revert.
6104         * disasm.h: Revert.
6105         * disasm.c: Revert.
6106         * disasm-selftests.c: Revert.
6107         * dictionary.c: Revert.
6108         * dicos-tdep.c: Revert.
6109         * demangle.c: Revert.
6110         * dcache.h: Revert.
6111         * dcache.c: Revert.
6112         * darwin-nat.h: Revert.
6113         * darwin-nat.c: Revert.
6114         * darwin-nat-info.c: Revert.
6115         * d-valprint.c: Revert.
6116         * d-namespace.c: Revert.
6117         * d-lang.c: Revert.
6118         * ctf.c: Revert.
6119         * csky-tdep.c: Revert.
6120         * csky-linux-tdep.c: Revert.
6121         * cris-tdep.c: Revert.
6122         * cris-linux-tdep.c: Revert.
6123         * cp-valprint.c: Revert.
6124         * cp-support.c: Revert.
6125         * cp-namespace.c: Revert.
6126         * cp-abi.c: Revert.
6127         * corelow.c: Revert.
6128         * corefile.c: Revert.
6129         * continuations.c: Revert.
6130         * completer.h: Revert.
6131         * completer.c: Revert.
6132         * complaints.c: Revert.
6133         * coffread.c: Revert.
6134         * coff-pe-read.c: Revert.
6135         * cli-out.h: Revert.
6136         * cli-out.c: Revert.
6137         * charset.c: Revert.
6138         * c-varobj.c: Revert.
6139         * c-valprint.c: Revert.
6140         * c-typeprint.c: Revert.
6141         * c-lang.c: Revert.
6142         * buildsym.c: Revert.
6143         * buildsym-legacy.c: Revert.
6144         * build-id.h: Revert.
6145         * build-id.c: Revert.
6146         * btrace.c: Revert.
6147         * bsd-uthread.c: Revert.
6148         * breakpoint.h: Revert.
6149         * breakpoint.c: Revert.
6150         * break-catch-throw.c: Revert.
6151         * break-catch-syscall.c: Revert.
6152         * break-catch-sig.c: Revert.
6153         * blockframe.c: Revert.
6154         * block.c: Revert.
6155         * bfin-tdep.c: Revert.
6156         * bfin-linux-tdep.c: Revert.
6157         * bfd-target.c: Revert.
6158         * bcache.c: Revert.
6159         * ax-general.c: Revert.
6160         * ax-gdb.h: Revert.
6161         * ax-gdb.c: Revert.
6162         * avr-tdep.c: Revert.
6163         * auxv.c: Revert.
6164         * auto-load.c: Revert.
6165         * arm-wince-tdep.c: Revert.
6166         * arm-tdep.c: Revert.
6167         * arm-symbian-tdep.c: Revert.
6168         * arm-pikeos-tdep.c: Revert.
6169         * arm-obsd-tdep.c: Revert.
6170         * arm-nbsd-tdep.c: Revert.
6171         * arm-nbsd-nat.c: Revert.
6172         * arm-linux-tdep.c: Revert.
6173         * arm-linux-nat.c: Revert.
6174         * arm-fbsd-tdep.c: Revert.
6175         * arm-fbsd-nat.c: Revert.
6176         * arm-bsd-tdep.c: Revert.
6177         * arch-utils.c: Revert.
6178         * arc-tdep.c: Revert.
6179         * arc-newlib-tdep.c: Revert.
6180         * annotate.h: Revert.
6181         * annotate.c: Revert.
6182         * amd64-windows-tdep.c: Revert.
6183         * amd64-windows-nat.c: Revert.
6184         * amd64-tdep.c: Revert.
6185         * amd64-sol2-tdep.c: Revert.
6186         * amd64-obsd-tdep.c: Revert.
6187         * amd64-obsd-nat.c: Revert.
6188         * amd64-nbsd-tdep.c: Revert.
6189         * amd64-nbsd-nat.c: Revert.
6190         * amd64-nat.c: Revert.
6191         * amd64-linux-tdep.c: Revert.
6192         * amd64-linux-nat.c: Revert.
6193         * amd64-fbsd-tdep.c: Revert.
6194         * amd64-fbsd-nat.c: Revert.
6195         * amd64-dicos-tdep.c: Revert.
6196         * amd64-darwin-tdep.c: Revert.
6197         * amd64-bsd-nat.c: Revert.
6198         * alpha-tdep.c: Revert.
6199         * alpha-obsd-tdep.c: Revert.
6200         * alpha-nbsd-tdep.c: Revert.
6201         * alpha-mdebug-tdep.c: Revert.
6202         * alpha-linux-tdep.c: Revert.
6203         * alpha-linux-nat.c: Revert.
6204         * alpha-bsd-tdep.c: Revert.
6205         * alpha-bsd-nat.c: Revert.
6206         * aix-thread.c: Revert.
6207         * agent.c: Revert.
6208         * addrmap.c: Revert.
6209         * ada-varobj.c: Revert.
6210         * ada-valprint.c: Revert.
6211         * ada-typeprint.c: Revert.
6212         * ada-tasks.c: Revert.
6213         * ada-lang.c: Revert.
6214         * aarch64-tdep.c: Revert.
6215         * aarch64-ravenscar-thread.c: Revert.
6216         * aarch64-newlib-tdep.c: Revert.
6217         * aarch64-linux-tdep.c: Revert.
6218         * aarch64-linux-nat.c: Revert.
6219         * aarch64-fbsd-tdep.c: Revert.
6220         * aarch64-fbsd-nat.c: Revert.
6221         * aarch32-linux-nat.c: Revert.
6222
6223 2019-04-05  Tom Tromey  <tom@tromey.com>
6224
6225         * ft32-tdep.c: Sort headers.
6226         * frv-tdep.c: Sort headers.
6227         * frv-linux-tdep.c: Sort headers.
6228         * frame.c: Sort headers.
6229         * frame-unwind.c: Sort headers.
6230         * frame-base.c: Sort headers.
6231         * fork-child.c: Sort headers.
6232         * findvar.c: Sort headers.
6233         * findcmd.c: Sort headers.
6234         * filesystem.c: Sort headers.
6235         * filename-seen-cache.h: Sort headers.
6236         * filename-seen-cache.c: Sort headers.
6237         * fbsd-tdep.c: Sort headers.
6238         * fbsd-nat.h: Sort headers.
6239         * fbsd-nat.c: Sort headers.
6240         * f-valprint.c: Sort headers.
6241         * f-typeprint.c: Sort headers.
6242         * f-lang.c: Sort headers.
6243         * extension.h: Sort headers.
6244         * extension.c: Sort headers.
6245         * extension-priv.h: Sort headers.
6246         * expprint.c: Sort headers.
6247         * exec.h: Sort headers.
6248         * exec.c: Sort headers.
6249         * exceptions.c: Sort headers.
6250         * event-top.c: Sort headers.
6251         * event-loop.c: Sort headers.
6252         * eval.c: Sort headers.
6253         * elfread.c: Sort headers.
6254         * dwarf2read.h: Sort headers.
6255         * dwarf2read.c: Sort headers.
6256         * dwarf2loc.c: Sort headers.
6257         * dwarf2expr.h: Sort headers.
6258         * dwarf2expr.c: Sort headers.
6259         * dwarf2-frame.c: Sort headers.
6260         * dwarf2-frame-tailcall.c: Sort headers.
6261         * dwarf-index-write.h: Sort headers.
6262         * dwarf-index-write.c: Sort headers.
6263         * dwarf-index-common.c: Sort headers.
6264         * dwarf-index-cache.h: Sort headers.
6265         * dwarf-index-cache.c: Sort headers.
6266         * dummy-frame.c: Sort headers.
6267         * dtrace-probe.c: Sort headers.
6268         * disasm.h: Sort headers.
6269         * disasm.c: Sort headers.
6270         * disasm-selftests.c: Sort headers.
6271         * dictionary.c: Sort headers.
6272         * dicos-tdep.c: Sort headers.
6273         * demangle.c: Sort headers.
6274         * dcache.h: Sort headers.
6275         * dcache.c: Sort headers.
6276         * darwin-nat.h: Sort headers.
6277         * darwin-nat.c: Sort headers.
6278         * darwin-nat-info.c: Sort headers.
6279         * d-valprint.c: Sort headers.
6280         * d-namespace.c: Sort headers.
6281         * d-lang.c: Sort headers.
6282         * ctf.c: Sort headers.
6283         * csky-tdep.c: Sort headers.
6284         * csky-linux-tdep.c: Sort headers.
6285         * cris-tdep.c: Sort headers.
6286         * cris-linux-tdep.c: Sort headers.
6287         * cp-valprint.c: Sort headers.
6288         * cp-support.c: Sort headers.
6289         * cp-namespace.c: Sort headers.
6290         * cp-abi.c: Sort headers.
6291         * corelow.c: Sort headers.
6292         * corefile.c: Sort headers.
6293         * continuations.c: Sort headers.
6294         * completer.h: Sort headers.
6295         * completer.c: Sort headers.
6296         * complaints.c: Sort headers.
6297         * coffread.c: Sort headers.
6298         * coff-pe-read.c: Sort headers.
6299         * cli-out.h: Sort headers.
6300         * cli-out.c: Sort headers.
6301         * charset.c: Sort headers.
6302         * c-varobj.c: Sort headers.
6303         * c-valprint.c: Sort headers.
6304         * c-typeprint.c: Sort headers.
6305         * c-lang.c: Sort headers.
6306         * buildsym.c: Sort headers.
6307         * buildsym-legacy.c: Sort headers.
6308         * build-id.h: Sort headers.
6309         * build-id.c: Sort headers.
6310         * btrace.c: Sort headers.
6311         * bsd-uthread.c: Sort headers.
6312         * breakpoint.h: Sort headers.
6313         * breakpoint.c: Sort headers.
6314         * break-catch-throw.c: Sort headers.
6315         * break-catch-syscall.c: Sort headers.
6316         * break-catch-sig.c: Sort headers.
6317         * blockframe.c: Sort headers.
6318         * block.c: Sort headers.
6319         * bfin-tdep.c: Sort headers.
6320         * bfin-linux-tdep.c: Sort headers.
6321         * bfd-target.c: Sort headers.
6322         * bcache.c: Sort headers.
6323         * ax-general.c: Sort headers.
6324         * ax-gdb.h: Sort headers.
6325         * ax-gdb.c: Sort headers.
6326         * avr-tdep.c: Sort headers.
6327         * auxv.c: Sort headers.
6328         * auto-load.c: Sort headers.
6329         * arm-wince-tdep.c: Sort headers.
6330         * arm-tdep.c: Sort headers.
6331         * arm-symbian-tdep.c: Sort headers.
6332         * arm-pikeos-tdep.c: Sort headers.
6333         * arm-obsd-tdep.c: Sort headers.
6334         * arm-nbsd-tdep.c: Sort headers.
6335         * arm-nbsd-nat.c: Sort headers.
6336         * arm-linux-tdep.c: Sort headers.
6337         * arm-linux-nat.c: Sort headers.
6338         * arm-fbsd-tdep.c: Sort headers.
6339         * arm-fbsd-nat.c: Sort headers.
6340         * arm-bsd-tdep.c: Sort headers.
6341         * arch-utils.c: Sort headers.
6342         * arc-tdep.c: Sort headers.
6343         * arc-newlib-tdep.c: Sort headers.
6344         * annotate.h: Sort headers.
6345         * annotate.c: Sort headers.
6346         * amd64-windows-tdep.c: Sort headers.
6347         * amd64-windows-nat.c: Sort headers.
6348         * amd64-tdep.c: Sort headers.
6349         * amd64-sol2-tdep.c: Sort headers.
6350         * amd64-obsd-tdep.c: Sort headers.
6351         * amd64-obsd-nat.c: Sort headers.
6352         * amd64-nbsd-tdep.c: Sort headers.
6353         * amd64-nbsd-nat.c: Sort headers.
6354         * amd64-nat.c: Sort headers.
6355         * amd64-linux-tdep.c: Sort headers.
6356         * amd64-linux-nat.c: Sort headers.
6357         * amd64-fbsd-tdep.c: Sort headers.
6358         * amd64-fbsd-nat.c: Sort headers.
6359         * amd64-dicos-tdep.c: Sort headers.
6360         * amd64-darwin-tdep.c: Sort headers.
6361         * amd64-bsd-nat.c: Sort headers.
6362         * alpha-tdep.c: Sort headers.
6363         * alpha-obsd-tdep.c: Sort headers.
6364         * alpha-nbsd-tdep.c: Sort headers.
6365         * alpha-mdebug-tdep.c: Sort headers.
6366         * alpha-linux-tdep.c: Sort headers.
6367         * alpha-linux-nat.c: Sort headers.
6368         * alpha-bsd-tdep.c: Sort headers.
6369         * alpha-bsd-nat.c: Sort headers.
6370         * aix-thread.c: Sort headers.
6371         * agent.c: Sort headers.
6372         * addrmap.c: Sort headers.
6373         * ada-varobj.c: Sort headers.
6374         * ada-valprint.c: Sort headers.
6375         * ada-typeprint.c: Sort headers.
6376         * ada-tasks.c: Sort headers.
6377         * ada-lang.c: Sort headers.
6378         * aarch64-tdep.c: Sort headers.
6379         * aarch64-ravenscar-thread.c: Sort headers.
6380         * aarch64-newlib-tdep.c: Sort headers.
6381         * aarch64-linux-tdep.c: Sort headers.
6382         * aarch64-linux-nat.c: Sort headers.
6383         * aarch64-fbsd-tdep.c: Sort headers.
6384         * aarch64-fbsd-nat.c: Sort headers.
6385         * aarch32-linux-nat.c: Sort headers.
6386
6387 2019-04-04  Tom Tromey  <tom@tromey.com>
6388
6389         * varobj.c (varobj_create): Update.
6390         * rust-exp.y (struct rust_parser) <update_innermost_block,
6391         lookup_symbol>: New methods.
6392         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6393         Rename.
6394         (rust_parser::rust_lookup_type)
6395         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6396         * printcmd.c (display_command, do_one_display): Update.
6397         * parser-defs.h (struct parser_state) <parser_state>: Add
6398         "tracker" parameter.
6399         (block_tracker): New member.
6400         (class innermost_block_tracker) <innermost_block_tracker>: Add
6401         "types" parameter.
6402         <reset>: Remove method.
6403         (innermost_block): Don't declare.
6404         (null_post_parser): Update.
6405         * parse.c (innermost_block): Remove global.
6406         (write_dollar_variable): Update.
6407         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6408         Remove "tracker_types" parameter.
6409         (parse_expression): Add "tracker" parameter.
6410         (parse_expression_for_completion): Update.
6411         (null_post_parser): Add "tracker" parameter.
6412         * p-exp.y: Update rules.
6413         * m2-exp.y: Update rules.
6414         * language.h (struct language_defn) <la_post_parser>: Add
6415         "tracker" parameter.
6416         * go-exp.y: Update rules.
6417         * f-exp.y: Update rules.
6418         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6419         parameter.
6420         * d-exp.y: Update rules.
6421         * c-exp.y: Update rules.
6422         * breakpoint.c (set_breakpoint_condition): Create an
6423         innermost_block_tracker.
6424         (watch_command_1): Likewise.
6425         * ada-lang.c (resolve): Add "tracker" parameter.
6426         (resolve_subexp): Likewise.
6427         * ada-exp.y (write_var_from_sym): Update.
6428
6429 2019-04-04  Tom Tromey  <tom@tromey.com>
6430
6431         * type-stack.h: New file.
6432         * type-stack.c: New file.
6433         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6434         type-stack.h.
6435         (insert_into_type_stack, insert_type, push_type, push_type_int)
6436         (insert_type_address_space, pop_type, pop_type_int)
6437         (pop_typelist, pop_type_stack, append_type_stack)
6438         (push_type_stack, get_type_stack, push_typelist)
6439         (follow_type_instance_flags, follow_types): Don't declare.
6440         * parse.c (type_stack): Remove global.
6441         (parse_exp_in_context): Update.
6442         (insert_into_type_stack, insert_type, push_type, push_type_int)
6443         (insert_type_address_space, pop_type, pop_type_int)
6444         (pop_typelist, pop_type_stack, append_type_stack)
6445         (push_type_stack, get_type_stack, push_typelist)
6446         (follow_type_instance_flags, follow_types): Remove (moved to
6447         type-stack.c).
6448         * f-exp.y (type_stack): New global.
6449         Update rules.
6450         (push_kind_type, f_parse): Update.
6451         * d-exp.y (type_stack): New global.
6452         Update rules.
6453         (d_parse): Update.
6454         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6455         Update rules.
6456         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6457         (HFILES_NO_SRCDIR): Add type-stack.h.
6458
6459 2019-04-04  Tom Tromey  <tom@tromey.com>
6460
6461         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6462         (rust_parser::convert_ast_to_expression, rust_parse)
6463         (rust_lex_test_completion, rust_lex_tests): Update.
6464         * parser-defs.h (struct expr_completion_state): New.
6465         (struct parser_state) <parser_state>: Add completion parameter.
6466         <mark_struct_expression, mark_completion_tag>: New methods.
6467         <parse_completion, m_completion_state>: New members.
6468         (prefixify_expression, null_post_parser): Update.
6469         (mark_struct_expression, mark_completion_tag): Don't declare.
6470         * parse.c (parse_completion, expout_last_struct)
6471         (expout_tag_completion_type, expout_completion_name): Remove
6472         globals.
6473         (parser_state::mark_struct_expression)
6474         (parser_state::mark_completion_tag): Now methods.
6475         (prefixify_expression): Add last_struct parameter.
6476         (prefixify_subexp): Likewise.
6477         (parse_exp_1): Update.
6478         (parse_exp_in_context): Add cstate parameter.  Update.
6479         (parse_expression_for_completion): Create an
6480         expr_completion_state.
6481         (null_post_parser): Add "completion" parameter.
6482         * p-exp.y: Update rules.
6483         (yylex): Update.
6484         * language.h (struct language_defn) <la_post_parser>: Add
6485         "completing" parameter.
6486         * go-exp.y: Update rules.
6487         (lex_one_token): Update.
6488         * expression.h (parse_completion): Don't declare.
6489         * d-exp.y: Update rules.
6490         (lex_one_token): Update rules.
6491         * c-exp.y: Update rules.
6492         (lex_one_token): Update.
6493         * ada-lang.c (resolve): Add "parse_completion" parameter.
6494         (resolve_subexp): Likewise.
6495         (ada_resolve_function): Likewise.
6496
6497 2019-04-04  Tom Tromey  <tom@tromey.com>
6498
6499         * parser-defs.h (struct parser_state) <start_arglist,
6500         end_arglist>: New methods.
6501         <arglist_len, m_funcall_chain>: New members.
6502         (arglist_len, start_arglist, end_arglist): Don't declare.
6503         * parse.c (arglist_len, funcall_chain): Remove global.
6504         (start_arglist, end_arglist): Remove functions.
6505         (parse_exp_in_context): Update.
6506         * p-exp.y: Update rules.
6507         * m2-exp.y: Update rules.
6508         * go-exp.y: Update rules.
6509         * f-exp.y: Update rules.
6510         * d-exp.y: Update rules.
6511         * c-exp.y: Update rules.
6512
6513 2019-04-04  Tom Tromey  <tom@tromey.com>
6514
6515         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6516         lex_operator, push_back>: New methods.
6517         Update all rules.
6518         (rust_parser::lex_hex, lex_escape): Rename and update.
6519         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6520         (rust_parser::lex_operator): Rename and update.
6521         (rust_parser::lex_number, rustyylex, rustyyerror)
6522         (rust_lex_test_init, rust_lex_test_sequence)
6523         (rust_lex_test_push_back, rust_lex_tests): Update.
6524         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6525         parameter.
6526         <lexptr, prev_lexptr>: New members.
6527         (lexptr, prev_lexptr): Don't declare.
6528         * parse.c (lexptr, prev_lexptr): Remove globals.
6529         (parse_exp_in_context): Update.
6530         * p-exp.y (yylex, yyerror): Update.
6531         * m2-exp.y (parse_number, yylex, yyerror): Update.
6532         * go-exp.y (lex_one_token, yyerror): Update.
6533         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6534         * d-exp.y (lex_one_token, yyerror): Update.
6535         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6536         (lex_one_token, yyerror): Update.
6537         * ada-lex.l (YY_INPUT): Update.
6538         (rewind_to_char): Update.
6539         * ada-exp.y (yyerror): Update.
6540
6541 2019-04-04  Tom Tromey  <tom@tromey.com>
6542
6543         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6544         * parser-defs.h (struct parser_state) <parser_state>: Add new
6545         parameter.
6546         <comma_terminates>: New member.
6547         (comma_terminates): Don't declare global.
6548         * parse.c (comma_terminates): Remove global.
6549         (parse_exp_in_context): Update.
6550         * p-exp.y (yylex): Update.
6551         * m2-exp.y (yylex): Update.
6552         * go-exp.y (lex_one_token): Update.
6553         * f-exp.y (yylex): Update.
6554         * d-exp.y (lex_one_token): Update.
6555         * c-exp.y (lex_one_token): Update.
6556         * ada-lex.l: Update.
6557
6558 2019-04-04  Tom Tromey  <tom@tromey.com>
6559
6560         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6561         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6562         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6563         * parser-defs.h (paren_depth): Don't declare.
6564         * parse.c (paren_depth): Remove global.
6565         (parse_exp_in_context): Update.
6566         * p-exp.y (paren_depth): New global.
6567         (pascal_parse): Initialize it.
6568         * m2-exp.y (paren_depth): New global.
6569         (m2_parse): Initialize it.
6570         * go-exp.y (paren_depth): New global.
6571         (go_parse): Initialize it.
6572         * f-exp.y (paren_depth): New global.
6573         (f_parse): Initialize it.
6574         * d-exp.y (paren_depth): New global.
6575         (d_parse): Initialize it.
6576         * c-exp.y (paren_depth): New global.
6577         (c_parse): Initialize it.
6578         * ada-lex.l (paren_depth): New global.
6579         (lexer_init): Initialize it.
6580
6581 2019-04-04  Tom Tromey  <tom@tromey.com>
6582
6583         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6584         (rust_parser::convert_ast_to_type)
6585         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6586         * parser-defs.h (struct parser_state) <parser_state>: Add
6587         parameters.  Initialize new members.
6588         <expression_context_block, expression_context_pc>: New members.
6589         * parse.c (expression_context_block, expression_context_pc):
6590         Remove globals.
6591         (parse_exp_in_context): Update.
6592         * p-exp.y: Update all rules.
6593         (yylex): Update.
6594         * m2-exp.y: Update all rules.
6595         (yylex): Update.
6596         * go-exp.y (yylex): Update.
6597         * f-exp.y (yylex): Update.
6598         * d-exp.y: Update all rules.
6599         (yylex): Update.
6600         * c-exp.y: Update all rules.
6601         (lex_one_token, classify_name, yylex, c_parse): Update.
6602         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6603
6604 2019-04-04  Tom Tromey  <tom@tromey.com>
6605
6606         * gdbarch.h, gdbarch.c: Rebuild.
6607         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6608         * stap-probe.h:
6609         (struct stap_parse_info): Replace "parser_state" with
6610         "expr_builder".
6611         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6612         (parser_state): New class.
6613         * parse.c (expr_builder): Rename.
6614         (expr_builder::release): Rename.
6615         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6616         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6617         (write_exp_elt_longcst, write_exp_elt_floatcst)
6618         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6619         (write_exp_string_vector, write_exp_bitstring)
6620         (write_exp_msymbol, mark_struct_expression)
6621         (write_dollar_variable)
6622         (insert_type_address_space, increase_expout_size): Replace
6623         "parser_state" with "expr_builder".
6624         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6625         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6626         "parser_state" with "expr_builder".
6627
6628 2019-04-04  Tom Tromey  <tom@tromey.com>
6629
6630         * rust-exp.y: Replace "parse_language" with method call.
6631         * p-exp.y:
6632         (yylex): Replace "parse_language" with method call.
6633         * m2-exp.y:
6634         (yylex): Replace "parse_language" with method call.
6635         * go-exp.y (classify_name): Replace "parse_language" with method
6636         call.
6637         * f-exp.y (yylex): Replace "parse_language" with method call.
6638         * d-exp.y (lex_one_token): Replace "parse_language" with method
6639         call.
6640         * c-exp.y:
6641         (lex_one_token, classify_name, yylex): Replace "parse_language"
6642         with method call.
6643         * ada-exp.y (find_primitive_type, type_char)
6644         (type_system_address): Replace "parse_language" with method call.
6645
6646 2019-04-04  Tom Tromey  <tom@tromey.com>
6647
6648         * rust-exp.y: Replace "parse_gdbarch" with method call.
6649         * parse.c (write_dollar_variable, insert_type_address_space):
6650         Replace "parse_gdbarch" with method call.
6651         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6652         call.
6653         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6654         call.
6655         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6656         "parse_gdbarch" with method call.
6657         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6658         with method call.
6659         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6660         "parse_gdbarch" with method call.
6661         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6662         "parse_gdbarch" with method call.
6663         * c-exp.y (parse_type, parse_number, classify_name): Replace
6664         "parse_gdbarch" with method call.
6665         * ada-lex.l: Replace "parse_gdbarch" with method call.
6666         * ada-exp.y (parse_type, find_primitive_type, type_char)
6667         (type_system_address): Replace "parse_gdbarch" with method call.
6668
6669 2019-04-04  Tom Tromey  <tom@tromey.com>
6670
6671         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6672         * stap-probe.c (stap_parse_argument): Update.
6673         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6674         initial_size parameter.
6675         * rust-exp.y (rust_lex_tests): Update.
6676         * parse.c (parser_state): Update.
6677         (parse_exp_in_context): Update.
6678         * parser-defs.h (struct parser_state) <parser_state>: Remove
6679         "initial_size" parameter.
6680
6681 2019-04-04  Tom Tromey  <tom@tromey.com>
6682
6683         * parser-defs.h (increase_expout_size): Don't declare.
6684         * parse.c (increase_expout_size): Now static.
6685
6686 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6687
6688         * gnu-nat.c (gnu_nat_target::wait): Fix
6689         target_waitstatus_to_string call.
6690
6691 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6692
6693         * eval.c (evaluate_subexp_standard): Handle internal functions
6694         during Fortran function call handling.
6695
6696 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6697
6698         * NEWS: Mention new internal functions.
6699         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6700         (read_base_type): Use dwarf2_init_complex_target_type.
6701         * value.c (creal_internal_fn): New function.
6702         (cimag_internal_fn): New function.
6703         (_initialize_values): Register new internal functions.
6704
6705 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6706
6707         * infrun.c (stop_all_threads): If debug_infrun, always
6708         trace the wait status after wait_one, using
6709         target_waitstatus_to_string and target_pid_to_str.
6710         (handle_inferior_event): Replace various trace of
6711         wait status kind by a single trace.
6712         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6713         wait status kind image by target_waitstatus_to_string.
6714         * target/waitstatus.c (target_waitstatus_to_string): Fix
6715         obsolete comment.
6716
6717 2019-04-01  Tom Tromey  <tromey@adacore.com>
6718
6719         PR symtab/23331:
6720         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6721
6722 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6723             Pedro Alves  <palves@redhat.com>
6724
6725         * top.c (quit_force): Call 'finalize_values'.
6726         * value.c (finalize_values): New function.
6727         * value.h (finalize_values): Declare.
6728
6729 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6730
6731         * NEWS: Announce $_gdb_major and $_gdb_minor.
6732
6733         * top.c (init_gdb_version_vars): New function.
6734         (gdb_init): Call init_gdb_version_vars.
6735
6736 2019-03-29  Tom Tromey  <tromey@adacore.com>
6737
6738         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6739         help text.  Remove dead code.
6740
6741 2019-03-29  Keith Seitz  <keiths@redhat.com>
6742
6743         From Siddhesh Poyarekar:
6744         * f-lang.h (f77_get_upperbound): Return LONGEST.
6745         (f77_get_lowerbound): Likewise.
6746         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6747         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6748         print them.
6749         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6750         plongest to format print it.
6751         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6752         (f77_get_upperbound): Likewise.
6753         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6754         LOWER_BOUND to LONGEST.
6755         (f77_create_arrayprint_offset_tbl): Likewise.
6756
6757 2019-03-29  Keith Seitz  <keiths@redhat.com>
6758
6759         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6760         %s/pulongest for TYPE_LENGTH instead of %d in format
6761         strings.
6762         * ada-typerint.c (ada_print_type): Likewise.
6763         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6764         * compile/compile-c-support.c (generate_register_struct): Likewise.
6765         * gdbtypes.c (recursive_dump_type): Likewise.
6766         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6767         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6768         instead of %d in format strings.
6769         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6770         to std::min to ULONGEST.
6771         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6772         instead of %d in format strings.
6773         * tracepoint.c (info_scope_command): Likewise.
6774         * typeprint.c (print_offset_data::update)
6775         (print_offset_data::finish): Likewise.
6776         * xtensa-tdep.c (xtensa_store_return_value)
6777         (xtensa_push_dummy_call): Likewise.
6778
6779 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6780
6781         * windows-nat.c (display_selector): Fixed format specifications
6782         for 64-bit Cygwin.
6783
6784 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6785
6786         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6787
6788 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6789
6790         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6791         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6792         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6793         (nios2_linux_init_abi): Install it.
6794
6795 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6796
6797         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6798
6799 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6800
6801         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6802
6803 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6804             Tom Tromey  <tromey@adacore.com>
6805
6806         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6807
6808 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6809
6810         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6811         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6812         method to compute the bounds of range types. Also print "[evaluated]"
6813         if the bounds' values come from a dynamic evaluation.
6814
6815 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6816
6817         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6818         whitespace when pretty printing is on.
6819
6820 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6821
6822         * ppc-linux-nat.c: Add include.
6823
6824 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6825
6826         * NEWS: Mention AArch64 Pointer Authentication.
6827
6828 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6829
6830         * arm-linux-nat.c: Add include.
6831
6832 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6833
6834         * source-cache.c (source_cache::get_source_lines): Re-read
6835         fullname after calling open_source_file.
6836
6837 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6838
6839         * NEWS: Mention TLS support for FreeBSD.
6840
6841 2019-03-25  Tom Tromey  <tromey@adacore.com>
6842
6843         * minsyms.c (BUNCH_SIZE): Update comment.
6844         (~minimal_symbol_reader): Remove old comment.
6845         (compact_minimal_symbols): Update comment.
6846         (minimal_symbol_reader::install): Remove old comment.  Update
6847         other comments.
6848
6849 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6850
6851         * s390-linux-nat.c: Add include.
6852
6853 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6854
6855         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6856         Call linux_get_hwcap.
6857         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6858         Likewise.
6859         (aarch64_linux_get_hwcap): Remove function.
6860         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6861         declaration.
6862         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6863         linux_get_hwcap.
6864         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6865         * linux-tdep.c (linux_get_hwcap): Add function.
6866         (linux_get_hwcap2): Likewise.
6867         * linux-tdep.h (linux_get_hwcap): Add declaration.
6868         (linux_get_hwcap2): Likewise.
6869         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6870         (ppc_linux_get_hwcap2): Likewise.
6871         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6872         linux_get_hwcap.
6873         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6874         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6875         (ppc_linux_nat_target::read_description): Likewise.
6876         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6877         * s390-linux-nat.c: Likewise.
6878         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6879
6880 2019-03-24  Tom Tromey  <tom@tromey.com>
6881
6882         * ada-lang.c (standard_lookup): Simplify initialization.
6883         (ada_lookup_symbol_nonlocal): Simplify return.
6884         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6885         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6886         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6887         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6888         initialization.
6889         * solib.c (solib_global_lookup): Simplify.
6890         * symtab.c (null_block_symbol): Remove.
6891         (symbol_cache_lookup): Simplify returns.
6892         (lookup_language_this): Simplify returns.
6893         (lookup_symbol_aux): Simplify return.
6894         (lookup_local_symbol): Simplify returns.
6895         (lookup_global_symbol_from_objfile): Simplify return.
6896         (lookup_symbol_in_objfile_symtabs)
6897         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6898         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6899         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6900         * cp-namespace.c (cp_lookup_bare_symbol)
6901         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6902         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6903         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6904         (cp_lookup_symbol_via_imports): Simplify initialization.
6905         (find_symbol_in_baseclass): Likewise.
6906         * symtab.h (null_block_symbol): Remove.
6907         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6908         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6909         (d_lookup_symbol_module): Likewise.
6910         (find_symbol_in_baseclass): Simplify initialization.
6911
6912 2019-03-24  Tom Tromey  <tom@tromey.com>
6913
6914         * expression.h: Don't include symtab.h.
6915         (struct block): Forward declare.
6916
6917 2019-03-24  Tom Tromey  <tom@tromey.com>
6918
6919         * c-exp.y (typebase): Remove casts.
6920         * gdbtypes.c (lookup_unsigned_typename, )
6921         (lookup_signed_typename): Remove cast.
6922         * eval.c (parse_to_comma_and_eval): Remove cast.
6923         * parse.c (write_dollar_variable): Remove cast.
6924         * block.h (struct block) <superblock>: Now const.
6925         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6926         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6927         (map_block): Make "block" const.
6928         * symfile.h (struct quick_symbol_functions)
6929         <map_matching_symbols>: Constify block argument to "callback".
6930         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6931         const.
6932         (find_pc_sect_compunit_symtab): Make "b" const.
6933         (find_symbol_at_address): Likewise.
6934         (search_symbols): Likewise.
6935         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6936         (dw2_debug_names_lookup_symbol): Likewise.
6937         (dw2_map_matching_symbols): Update.
6938         * p-valprint.c (pascal_val_print): Remove "block".
6939         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6940         (aux_add_nonlocal_symbols): Make "block" const.
6941         (resolve_subexp): Remove cast.
6942         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6943         const.
6944         (iterate_over_file_blocks): Likewise.
6945         * f-exp.y (%union) <bval>: Remove.
6946         * coffread.c (patch_opaque_types): Make "b" const.
6947         * spu-tdep.c (spu_catch_start): Make "block" const.
6948         * c-valprint.c (print_unpacked_pointer): Remove "block".
6949         * symmisc.c (dump_symtab_1): Make "b" const.
6950         (block_depth): Make "block" const.
6951         * d-exp.y (%union) <bval>: Remove.
6952         * cp-support.h (cp_lookup_rtti_type): Update.
6953         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6954         * psymtab.c (psym_lookup_symbol): Make "block" const.
6955         (maintenance_check_psymtabs): Make "b" const.
6956         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6957         (enumerate_locals, enumerate_args): Update.
6958         * python/py-symtab.c (stpy_global_block): Make "block" const.
6959         (stpy_static_block): Likewise.
6960         * inline-frame.c (block_starting_point_at): Make "new_block"
6961         const.
6962         * block.c (find_block_in_blockvector): Make return type const.
6963         (blockvector_for_pc_sect): Make "b" const.
6964         (find_block_in_blockvector): Make "b" const.
6965
6966 2019-03-23  Tom Tromey  <tom@tromey.com>
6967
6968         * varobj.c (varobj_create): Update.
6969         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6970         * printcmd.c (display_command, do_one_display): Don't reset
6971         innermost_block.
6972         * parser-defs.h (enum innermost_block_tracker_type): Move to
6973         expression.h.
6974         (innermost_block): Update comment.
6975         * parse.c (parse_exp_1): Add tracker_types parameter.
6976         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6977         tracker_types parameter.  Reset innermost_block.
6978         (parse_exp_in_context): Remove.
6979         (parse_expression_for_completion): Update.
6980         * objfiles.c (~objfile): Don't reset expression_context_block or
6981         innermost_block.
6982         * expression.h (enum innermost_block_tracker_type): Move from
6983         parser-defs.h.
6984         (parse_exp_1): Add tracker_types parameter.
6985         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6986         reset innermost_block.
6987
6988 2019-03-23  Tom Tromey  <tom@tromey.com>
6989
6990         * objfiles.h: Include bcache.h.
6991
6992 2019-03-23  Tom Tromey  <tom@tromey.com>
6993
6994         * linespec.c (get_current_search_block): Use
6995         scoped_restore_current_language.
6996         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6997
6998 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6999             Jiong Wang  <jiong.wang@arm.com>
7000
7001         * aarch64-linux-tdep.c
7002         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7003         section.
7004         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7005
7006 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7007             Jiong Wang  <jiong.wang@arm.com>
7008
7009         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7010         instructions.
7011         (aarch64_analyze_prologue_test): Add PACIASP test.
7012         (aarch64_prologue_prev_register): Unmask PC value.
7013
7014 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7015             Jiong Wang  <jiong.wang@arm.com>
7016
7017         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7018         (aarch64_dwarf2_prev_register): Unmask PC value.
7019         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7020         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7021         DW_CFA_AARCH64_negate_ra_state.
7022         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7023
7024 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7025             Jiong Wang  <jiong.wang@arm.com>
7026
7027         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7028         registers.
7029         (aarch64_pseudo_register_name): Likewise.
7030         (aarch64_pseudo_register_type): Likewise.
7031         (aarch64_pseudo_register_reggroup_p): Likewise.
7032         (aarch64_gdbarch_init): Add pauth registers.
7033         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7034         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7035         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7036         (struct gdbarch_tdep): Add regnum for ra_state.
7037
7038 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7039             Jiong Wang  <jiong.wang@arm.com>
7040
7041         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7042
7043 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7044             Jiong Wang  <jiong.wang@arm.com>
7045
7046         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7047         function.
7048         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7049         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7050         (aarch64_gdbarch_init): Add puth registers.
7051         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7052         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7053         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7054
7055 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7056             Jiong Wang  <jiong.wang@arm.com>
7057
7058         * aarch64-linux-nat.c
7059         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7060         * aarch64-linux-tdep.c
7061         (aarch64_linux_core_read_description): Likewise.
7062         (aarch64_linux_get_hwcap): New function.
7063         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7064         (aarch64_linux_get_hwcap): New declaration.
7065
7066 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7067             Jiong Wang  <jiong.wang@arm.com>
7068
7069         * aarch64-linux-nat.c
7070         (aarch64_linux_nat_target::read_description): Add pauth param.
7071         * aarch64-linux-tdep.c
7072         (aarch64_linux_core_read_description): Likewise.
7073         * aarch64-tdep.c (struct target_desc): Add in pauth.
7074         (aarch64_read_description): Add pauth param.
7075         (aarch64_gdbarch_init): Likewise.
7076         * aarch64-tdep.h (aarch64_read_description): Likewise.
7077         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7078         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7079         * features/Makefile: Add new files.
7080         * features/aarch64-pauth.c: New file.
7081         * features/aarch64-pauth.xml: New file.
7082
7083 2019-03-20  Tom Tromey  <tromey@adacore.com>
7084
7085         * infrun.c (handle_inferior_event): Rename from
7086         handle_inferior_event_1.  Create a scoped_value_mark.
7087         (handle_inferior_event): Remove.
7088
7089 2019-03-19  Tom Tromey  <tromey@adacore.com>
7090
7091         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7092         * infrun.h (print_stop_event): Add "displays" parameter.
7093         * infrun.c (print_stop_event): Add "displays" parameter.
7094
7095 2019-03-19  Pedro Alves  <palves@redhat.com>
7096
7097         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7098         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7099         to -1.  Fix TABs vs spaces.
7100         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7101         * tui/tui-out.h (tui_ui_out) Add intro comments.
7102         <m_line, m_start_of_line>: In-class initialize, and add describing
7103         comment.
7104
7105 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7106
7107         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7108         variable names.
7109         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7110
7111 2019-03-18  Pedro Alves  <palves@redhat.com>
7112             Eli Zaretskii <eliz@gnu.org>
7113
7114         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7115         m_line and m_start_of_line.
7116
7117 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7118
7119         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7120         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7121         it returns a newline.  This fixes a regression in TU mode, whereby
7122         the next line is output on the same screen line as the user input.
7123
7124 2019-03-18  Tom Tromey  <tromey@adacore.com>
7125
7126         * minsyms.c (minimal_symbol_reader::install): Remove call to
7127         obstack_blank.
7128
7129 2019-03-18  Pedro Alves  <palves@redhat.com>
7130
7131         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7132         New globals.
7133         (apply_style): New, factored out from ...
7134         (apply_ansi_escape): ... this.  Handle reverse video mode.
7135         (tui_set_reverse_mode): New function.
7136         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7137         * tui/tui-winsource.c (tui_show_source_line): Use
7138         tui_set_reverse_mode instead of setting A_STANDOUT.
7139         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7140         New setter methods.
7141
7142 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7143
7144         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7145         Handle tabs.
7146
7147 2019-03-18  Tom Tromey  <tromey@adacore.com>
7148
7149         * ada-lang.c (empty_array): Add "high" parameter.
7150         (ada_evaluate_subexp): Update.
7151
7152 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7153
7154         * unittests/string_view-selftests.c: Define
7155         _initialize_string_view_selftests unconditionally.
7156
7157 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7158
7159         PR gdb/24350
7160         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7161
7162 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7163
7164         PR gdb/24351
7165         * windows-nat.c (display_selector): Fix format specifiers.
7166
7167 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7168
7169         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7170         tui_refill_source_window instead of tui_refresh_win, to update the
7171         current execution line.  This fixes redisplay of the current line
7172         when stepping through the code with "next" or "step".
7173
7174 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7175
7176         * source-cache.c (source_cache::get_source_lines): Call
7177         find_source_lines to initialize s->nlines.  This fixes vertical
7178         scrolling of TUI source window when the DOWN arrow is pressed.
7179
7180 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7181
7182         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7183         linux-thread-db.c (_initialize_thread_db): Likewise.
7184
7185 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7186
7187         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7188         wclrtoeol in tui_show_source_line".  This reverts changes made in
7189         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7190
7191 2019-03-15  Tom Tromey  <tom@tromey.com>
7192
7193         * symtab.h (struct minimal_symbol): Derive from
7194         general_symbol_info.
7195         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7196         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7197         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7198         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7199         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7200         (MSYMBOL_SEARCH_NAME): Update.
7201         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7202         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7203         * minsyms.c (minimal_symbol_reader::record_full): Update.
7204
7205 2019-03-15  Tom Tromey  <tom@tromey.com>
7206
7207         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7208
7209 2019-03-15  Tom Tromey  <tom@tromey.com>
7210
7211         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7212         unique_xmalloc_ptr.
7213         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7214         Update.
7215         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7216         (build_minimal_symbol_hash_tables)
7217         (minimal_symbol_reader::install): Update.
7218
7219 2019-03-15  Tom Tromey  <tom@tromey.com>
7220
7221         * symtab.c (create_demangled_names_hash): Update.
7222         (symbol_set_names): Update.
7223         * objfiles.h (struct objfile_per_bfd_storage)
7224         <demangled_names_hash>: Now an htab_up.
7225         * objfiles.c (objfile_per_bfd_storage): Simplify.
7226
7227 2019-03-15  Tom Tromey  <tom@tromey.com>
7228
7229         * objfiles.h (struct objfile_per_bfd_storage): Declare
7230         destructor.
7231         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7232         New.
7233         (get_objfile_bfd_data): Use new.  Don't initialize
7234         language_of_main.
7235         (free_objfile_per_bfd_storage): Remove.
7236         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7237
7238 2019-03-15  Tom Tromey  <tom@tromey.com>
7239
7240         * symfile.c (reread_symbols): Update.
7241         * objfiles.c (objfile::objfile): Update.
7242         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7243         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7244         comment.
7245         (minimal_symbol_reader::install): Update.
7246         (terminate_minimal_symbol_table): Remove.
7247         * jit.c (jit_object_close_impl): Update.
7248
7249 2019-03-15  Tom Tromey  <tom@tromey.com>
7250
7251         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7252         initializations.
7253
7254 2019-03-15  Tom Tromey  <tom@tromey.com>
7255
7256         * objfiles.h (struct objfile_per_bfd_storage)
7257         <demangled_hash_languages>: Now a bitset.
7258         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7259         (lookup_minimal_symbol): Update.
7260
7261 2019-03-15  Tom Tromey  <tom@tromey.com>
7262
7263         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7264         Don't return the symbol.
7265         * coffread.c (record_minimal_symbol): Use record_full.
7266
7267 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7268
7269         The MS-Windows port of ncurses fails to switch to a color pair if
7270         one or both of the colors are the implicit default colors.  This
7271         change records the default colors when TUI is initialized, and
7272         then specifies them explicitly when a color pair uses the default
7273         colors.  This allows color styling in TUI mode on MS-Windows.
7274
7275         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7276         ncurses_norm_attr.
7277         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7278         colors in ncurses_norm_attr.
7279         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7280         "none", replace it with the default color recorded in
7281         ncurses_norm_attr.
7282
7283 2019-03-14  Tom Tromey  <tromey@adacore.com>
7284
7285         * source-cache.h (class source_cache) <get_source_lines>: Return
7286         std::string.
7287         * source-cache.c (source_cache::extract_lines): Handle case where
7288         first_pos==npos.  Return std::string.
7289         (source_cache::get_source_lines): Update.
7290
7291 2019-03-14  Tom Tromey  <tromey@adacore.com>
7292
7293         * NEWS: Add item for "style sources" commands.
7294         * source-cache.c (source_cache::get_source_lines): Check
7295         source_styling.
7296         * cli/cli-style.c (source_styling): New global.
7297         (_initialize_cli_style): Add "style sources" commands.
7298         (show_style_sources): New function.
7299         * cli/cli-style.h (source_styling): Declare.
7300
7301 2019-03-14  Pedro Alves  <palves@redhat.com>
7302             Tom Tromey  <tromey@adacore.com>
7303
7304         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7305         * tui/tui-winsource.c (tui_refill_source_window): New function,
7306         from...
7307         (tui_horizontal_source_scroll): ... here.  Move some logic.
7308         * cli/cli-style.c (set_style_enabled): Notify new observable.
7309         * tui/tui-hooks.c (tui_redisplay_source): New function.
7310         (tui_attach_detach_observers): Attach or detach
7311         tui_redisplay_source.
7312         * observable.h (source_styling_changed): New observable.
7313         * observable.c: Define source_styling_changed observable.
7314
7315 2019-03-13  Tom Tromey  <tromey@adacore.com>
7316
7317         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7318         (i386_gnu_nat_target::store_registers): Update.
7319         * target-debug.h (target_debug_print_std_string): New macro.
7320         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7321         * windows-tdep.c (display_one_tib): Update.
7322         * tui/tui-stack.c (tui_make_status_line): Update.
7323         * top.c (print_inferior_quit_action): Update.
7324         * thread.c (thr_try_catch_cmd): Update.
7325         (add_thread_with_info): Update.
7326         (thread_target_id_str): Update.
7327         (thr_try_catch_cmd): Update.
7328         (thread_command): Update.
7329         (thread_find_command): Update.
7330         * record-btrace.c (record_btrace_target::info_record)
7331         (record_btrace_resume_thread, record_btrace_target::resume)
7332         (record_btrace_cancel_resume, record_btrace_step_thread)
7333         (record_btrace_target::wait, record_btrace_target::wait)
7334         (record_btrace_target::wait, record_btrace_target::stop): Update.
7335         * progspace.c (print_program_space): Update.
7336         * process-stratum-target.c
7337         (process_stratum_target::thread_address_space): Update.
7338         * linux-fork.c (linux_fork_mourn_inferior)
7339         (detach_checkpoint_command, info_checkpoints_command)
7340         (linux_fork_context): Update.
7341         (linux_fork_detach): Update.
7342         (class scoped_switch_fork_info): Update.
7343         (delete_checkpoint_command): Update.
7344         * infrun.c (follow_fork_inferior): Update.
7345         (follow_fork_inferior): Update.
7346         (proceed_after_vfork_done): Update.
7347         (handle_vfork_child_exec_or_exit): Update.
7348         (follow_exec): Update.
7349         (displaced_step_prepare_throw): Update.
7350         (displaced_step_restore): Update.
7351         (start_step_over): Update.
7352         (resume_1): Update.
7353         (clear_proceed_status_thread): Update.
7354         (proceed): Update.
7355         (print_target_wait_results): Update.
7356         (do_target_wait): Update.
7357         (context_switch): Update.
7358         (stop_all_threads): Update.
7359         (restart_threads): Update.
7360         (finish_step_over): Update.
7361         (handle_signal_stop): Update.
7362         (switch_back_to_stepped_thread): Update.
7363         (keep_going_pass_signal): Update.
7364         (print_exited_reason): Update.
7365         (normal_stop): Update.
7366         * inferior.c (inferior_pid_to_str): Change return type.
7367         (print_selected_inferior): Update.
7368         (add_inferior): Update.
7369         (detach_inferior): Update.
7370         * dummy-frame.c (fprint_dummy_frames): Update.
7371         * dcache.c (dcache_info_1): Update.
7372         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7373         (btrace_fetch, btrace_clear): Update.
7374         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7375         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7376         type.
7377         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7378         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7379         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7380         * gdbarch.c, gdbarch.h: Rebuild.
7381         * gdbarch.sh (core_pid_to_str): Change return type.
7382         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7383         return type.
7384         (windows_nat_target::pid_to_str): Change return type.
7385         (windows_delete_thread): Update.
7386         (windows_nat_target::attach): Update.
7387         (windows_nat_target::files_info): Update.
7388         * target-delegates.c: Rebuild.
7389         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7390         return type.
7391         (sol_thread_target::pid_to_str): Change return type.
7392         * remote.c (class remote_target) <pid_to_str>: Change return
7393         type.
7394         (remote_target::pid_to_str): Change return type.
7395         (extended_remote_target::attach, remote_target::remote_stop_ns)
7396         (remote_target::remote_notif_remove_queued_reply)
7397         (remote_target::push_stop_reply, remote_target::disable_btrace):
7398         Update.
7399         (extended_remote_target::attach): Update.
7400         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7401         type.
7402         (gdbsim_target::pid_to_str): Change return type.
7403         * ravenscar-thread.c (struct ravenscar_thread_target)
7404         <pid_to_str>: Change return type.
7405         (ravenscar_thread_target::pid_to_str): Change return type.
7406         * procfs.c (class procfs_target) <pid_to_str>: Change return
7407         type.
7408         (procfs_target::pid_to_str): Change return type.
7409         (procfs_target::attach): Update.
7410         (procfs_target::detach): Update.
7411         (procfs_target::fetch_registers): Update.
7412         (procfs_target::store_registers): Update.
7413         (procfs_target::wait): Update.
7414         (procfs_target::files_info): Update.
7415         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7416         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7417         return type.
7418         (nto_procfs_target::pid_to_str): Change return type.
7419         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7420         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7421         return type.
7422         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7423         (exit_lwp): Update.
7424         (attach_proc_task_lwp_callback, get_detach_signal)
7425         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7426         (linux_nat_target::resume, wait_lwp, stop_callback)
7427         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7428         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7429         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7430         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7431         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7432         type.
7433         (inf_ptrace_target::attach): Update.
7434         (inf_ptrace_target::files_info): Update.
7435         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7436         type.
7437         (go32_nat_target::pid_to_str): Change return type.
7438         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7439         (gnu_nat_target::wait): Update.
7440         (gnu_nat_target::wait): Update.
7441         (gnu_nat_target::resume): Update.
7442         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7443         (fbsd_nat_target::wait): Update.
7444         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7445         type.
7446         (darwin_nat_target::attach): Update.
7447         * corelow.c (class core_target) <pid_to_str>: Change return type.
7448         (core_target::pid_to_str): Change return type.
7449         * target.c (normal_pid_to_str): Change return type.
7450         (default_pid_to_str): Likewise.
7451         (target_pid_to_str): Change return type.
7452         (target_translate_tls_address): Update.
7453         (target_announce_detach): Update.
7454         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7455         return type.
7456         (bsd_uthread_target::pid_to_str): Change return type.
7457         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7458         type.
7459         (bsd_kvm_target::pid_to_str): Change return type.
7460         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7461         return type.
7462         (aix_thread_target::pid_to_str): Change return type.
7463         * target.h (struct target_ops) <pid_to_str>: Change return type.
7464         (target_pid_to_str, normal_pid_to_str): Likewise.
7465         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7466         type.
7467         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7468         type.
7469         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7470         return type.
7471         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7472         type.
7473         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7474         type.
7475         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7476         return type.
7477
7478 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7479
7480         * NEWS: Mention that the new default MI version is 3.  Mention
7481         changes to the output of commands and events that deal with
7482         multi-location breakpoints.
7483         * breakpoint.c: Include "mi/mi-out.h".
7484         (print_one_breakpoint): Change output syntax if using MI version
7485         >= 3.
7486         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7487         New.
7488         (mi_multi_location_breakpoint_output_fixed): New.
7489         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7490         (mi_cmd_fix_multi_location_breakpoint_output): New.
7491         (mi_multi_location_breakpoint_output_fixed): New.
7492         * mi/mi-cmds.c (mi_cmds): Register command
7493         -fix-multi-location-breakpoint-output.
7494         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7495         interpreter "mi".
7496
7497 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7498
7499         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7500         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7501         instantiate mi_ui_out based on interpreter name.
7502         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7503         * mi/mi-main.c (mi_load_progress): Likewise.
7504
7505 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7506
7507         * NEWS: Combine separate "New targets" sections for 8.3.
7508
7509 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7510
7511         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7512         (ppcfbsd_init_abi): Install gdbarch
7513         "fetch_tls_load_module_address" and "get_thread_local_address"
7514         methods.
7515
7516 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7517
7518         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7519         (riscv_fbsd_init_abi): Install gdbarch
7520         "fetch_tls_load_module_address" and "get_thread_local_address"
7521         methods.
7522
7523 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7524
7525         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7526         (i386fbsd_init_abi): Install gdbarch
7527         "fetch_tls_load_module_address" and "get_thread_local_address"
7528         methods.
7529
7530 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7531
7532         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7533         (amd64fbsd_init_abi): Install gdbarch
7534         "fetch_tls_load_module_address" and "get_thread_local_address"
7535         methods.
7536
7537 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7538
7539         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7540         (struct fbsd_pspace_data): New type.
7541         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7542         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7543         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7544         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7545         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7546
7547 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7548
7549         * gdbtypes.c (lookup_struct_elt): New function.
7550         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7551         * gdbtypes.h (struct struct_elt): New type.
7552         (lookup_struct_elt): New prototype.
7553
7554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7555
7556         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7557         remove disabled code block.
7558
7559 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7560
7561         * gdbarch.sh (get_thread_local_address): New method.
7562         * gdbarch.h, gdbarch.c: Regenerate.
7563         * target.c (target_translate_tls_address): Use
7564         gdbarch_get_thread_local_address if present instead of
7565         target::get_thread_local_address.
7566
7567 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7568
7569         * target.h (target::get_thread_local_address): Update comment.
7570
7571 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7572
7573         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7574         objfile->separate_debug_objfile_backlink if not NULL.
7575
7576 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7577
7578         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7579         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7580         (amd64bsd_store_inferior_registers): Likewise.
7581         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7582         Enable segment base registers.
7583         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7584         PT_GETFSBASE and PT_GETGSBASE.
7585         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7586         PT_SETGSBASE.
7587         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7588         segment base registers.
7589         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7590
7591 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7592
7593         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7594         Update calls to i386_target_description to add 'segments'
7595         parameter.
7596         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7597         add segment base registers.
7598         * arch/i386.c (i386_create_target_description): Add 'segments'
7599         parameter to enable segment base registers.
7600         * arch/i386.h (i386_create_target_description): Likewise.
7601         * features/i386/32bit-segments.xml: New file.
7602         * features/i386/32bit-segments.c: Generate.
7603         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7604         call to i386_target_description to add 'segments' parameter.
7605         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7606         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7607         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7608         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7609         if feature is present.
7610         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7611         Add 'segments' parameter to call to i386_target_description.
7612         (i386_target_description): Add 'segments' parameter to enable
7613         segment base registers.
7614         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7615         to call to i386_target_description.
7616         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7617         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7618         Define I386_NUM_REGS.
7619         (i386_target_description): Add 'segments' parameter to enable
7620         segment base registers.
7621
7622 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7623
7624         PR/24325
7625         * source-cache.c: #undef open and close, to avoid unresolved
7626         externals during linking.
7627
7628 2019-03-12  Tom Tromey  <tromey@adacore.com>
7629
7630         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7631         const.  Add initializers.
7632         (_initialize_remote): Don't initialize ptid globals.
7633
7634 2019-03-12  Pedro Alves  <palves@redhat.com>
7635
7636         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7637
7638 2019-03-12  Pedro Alves  <palves@redhat.com>
7639
7640         * cp-name-parser.y (main): Remove unused 'len' variable.
7641
7642 2019-03-12  Tom Tromey  <tromey@adacore.com>
7643
7644         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7645         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7646
7647 2019-03-12  Tom Tromey  <tromey@adacore.com>
7648
7649         * linux-nat.c (iterate_over_lwps): Update.
7650         (stop_callback): Remove parameter.
7651         (stop_wait_callback, detach_callback, resume_set_callback)
7652         (select_singlestep_lwp_callback, set_ignore_sigint)
7653         (status_callback, resumed_callback, resume_clear_callback)
7654         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7655         data parameter.
7656         (linux_nat_target::detach, linux_nat_target::resume)
7657         (linux_stop_and_wait_all_lwps, select_event_lwp)
7658         (linux_nat_filter_event, linux_nat_wait_1)
7659         (linux_nat_target::kill, linux_nat_target::stop)
7660         (linux_nat_target::stop): Update.
7661         (linux_nat_resume_callback): Change type.
7662         (resume_stopped_resumed_lwps, count_events_callback)
7663         (select_event_lwp_callback): Likewise.
7664         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7665         * arm-linux-nat.c (struct update_registers_data): Remove.
7666         (update_registers_callback): Change type.
7667         (arm_linux_insert_hw_breakpoint1): Update.
7668         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7669         parameter.
7670         (x86_linux_dr_set_addr): Update.
7671         (x86_linux_dr_set_control): Update.
7672         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7673         (iterate_over_lwps): Use gdb::function_view.
7674         * nat/aarch64-linux-hw-point.c (struct
7675         aarch64_dr_update_callback_param): Remove.
7676         (debug_reg_change_callback): Change type.
7677         (aarch64_notify_debug_reg_change): Update.
7678         * s390-linux-nat.c (s390_refresh_per_info): Update.
7679
7680 2019-03-11  Tom Tromey  <tromey@adacore.com>
7681
7682         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7683         redundant assignment to "this_cu".
7684
7685 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7686
7687         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7688
7689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7690
7691         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7692         from...
7693         (rank_one_type): ... this.
7694
7695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7696
7697         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7698         from...
7699         (rank_one_type): ... this.
7700
7701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7702
7703         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7704         from...
7705         (rank_one_type): ... this.
7706
7707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7708
7709         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7710         from...
7711         (rank_one_type): ... this.
7712
7713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7714
7715         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7716         from...
7717         (rank_one_type): ... this.
7718
7719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7720
7721         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7722         from...
7723         (rank_one_type): ... this.
7724
7725 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7726
7727         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7728         from...
7729         (rank_one_type): ... this.
7730
7731 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7732
7733         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7734         from...
7735         (rank_one_type): ... this.
7736
7737 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7738
7739         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7740         from...
7741         (rank_one_type): ... this.
7742
7743 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7744
7745         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7746         from...
7747         (rank_one_type): ... this.
7748
7749 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7750
7751         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7752         from...
7753         (rank_one_type): ... this.
7754
7755 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7756
7757         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7758         from...
7759         (rank_one_type): ... this.
7760
7761 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7762
7763         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7764         inferior-events' shows the example events.
7765
7766 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7767
7768         Support styling on native MS-Windows console
7769
7770         PR/24315
7771         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7772         on MS-Windows if $TERM is not defined.
7773
7774         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7775
7776         * posix-hdep.c (gdb_console_fputs):
7777         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7778         functions.
7779         * ui-file.h (gdb_console_fputs): Add prototype.
7780
7781         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7782         back to fputs only if the former returns zero.
7783
7784 2019-03-07  Tom Tromey  <tom@tromey.com>
7785
7786         * symmisc.c (print_symbol_bcache_statistics): Update.
7787         (print_objfile_statistics): Update.
7788         * symfile.c (allocate_symtab): Update.
7789         * stabsread.c: Don't include bcache.h.
7790         * psymtab.h (struct psymbol_bcache): Don't declare.
7791         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7792         (psymbol_bcache_init, psymbol_bcache_free)
7793         (psymbol_bcache_get_bcache): Don't declare.
7794         * psymtab.c (struct psymbol_bcache): Remove.
7795         (psymtab_storage::psymtab_storage): Update.
7796         (psymtab_storage::~psymtab_storage): Update.
7797         (psymbol_bcache_init, psymbol_bcache_free)
7798         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7799         (add_psymbol_to_bcache): Update.
7800         (allocate_psymtab): Update.
7801         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7802         macro_cache>: No longer pointers.
7803         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7804         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7805         * macrotab.c (macro_bcache): Update.
7806         * macroexp.c: Don't include bcache.h.
7807         * gdbtypes.c (check_types_worklist): Update.
7808         (types_deeply_equal): Remove TRY/CATCH.  Update.
7809         * elfread.c (elf_symtab_read): Update.
7810         * dwarf2read.c: Don't include bcache.h.
7811         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7812         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7813         (print_bcache_statistics, bcache_memory_used): Don't declare.
7814         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7815         methods.  Rename all data members.
7816         * bcache.c (struct bcache): Move to bcache.h.
7817         (bcache::expand_hash_table): Rename from expand_hash_table.
7818         (bcache): Remove.
7819         (bcache::insert): Rename from bcache_full.
7820         (bcache::compare): Rename from bcache_compare.
7821         (bcache_xmalloc): Remove.
7822         (bcache::~bcache): Rename from bcache_xfree.
7823         (bcache::print_statistics): Rename from print_bcache_statistics.
7824         (bcache::memory_used): Rename from bcache_memory_used.
7825
7826 2019-03-07  Pedro Alves  <palves@redhat.com>
7827
7828         * infrun.c (normal_stop): Also check for
7829         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7830
7831 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7832
7833         * f-lang.c (value_from_host_double): Moved to...
7834         * value.c (value_from_host_double): ...here.
7835         * value.h (value_from_host_double): Declare.
7836         * guile/scm-math.c (vlscm_convert_typed_number): Use
7837         value_from_host_double.
7838         (vlscm_convert_number): Likewise.
7839         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7840         * python/py-value.c (convert_value_from_python): Likewise.
7841
7842 2019-03-06  Tom Tromey  <tom@tromey.com>
7843
7844         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7845
7846 2019-03-06  Tom Tromey  <tom@tromey.com>
7847
7848         * utils.h (free_current_contents): Don't declare.
7849         * utils.c (free_current_contents): Remove.
7850
7851 2019-03-06  Tom Tromey  <tom@tromey.com>
7852
7853         * top.c (quit_force): Update.
7854         * main.c (captured_command_loop): Update.
7855         * common/new-op.c (operator new): Update.
7856         * common/common-exceptions.c (struct catcher)
7857         <save_cleanup_chain>: Remove member.
7858         (exceptions_state_mc_init): Update.
7859         (exception_try_scope_entry): Return nullptr.
7860         (exception_try_scope_exit, exception_rethrow)
7861         (throw_exception_sjlj, throw_exception_cxx): Update.
7862         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7863         (all_cleanups, do_cleanups, discard_cleanups)
7864         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7865         (restore_cleanups, restore_final_cleanups): Don't declare.
7866         (do_final_cleanups): Remove parameter.
7867         * common/cleanups.c (cleanup_chain, make_cleanup)
7868         (make_cleanup_dtor, all_cleanups, do_cleanups)
7869         (discard_my_cleanups, discard_cleanups)
7870         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7871         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7872         (null_cleanup): Remove.
7873         (do_final_cleanups): Remove parameter.
7874
7875 2019-03-06  Tom Tromey  <tom@tromey.com>
7876
7877         * remote.c (remote_target::remote_parse_stop_reply): Use
7878         unique_xmalloc_ptr.
7879
7880 2019-03-06  Tom Tromey  <tom@tromey.com>
7881
7882         * stabsread.c (struct stabs_field_info): Rename from field_info.
7883         <list, fnlist>: Add initializers.
7884         <obstack>: New member.
7885         (read_member_functions, read_struct_fields, read_baseclasses):
7886         Allocate on obstack.  Don't use cleanups.
7887         (read_one_struct_field, read_member_functions, read_struct_fields)
7888         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7889         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7890         (read_struct_type): Update.
7891
7892 2019-03-06  Tom Tromey  <tom@tromey.com>
7893
7894         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7895         * common/filestuff.h (make_cleanup_close): Don't declare.
7896         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7897         Remove.
7898
7899 2019-03-06  Tom Tromey  <tom@tromey.com>
7900
7901         * solib-aix.c: Use make_scope_exit.
7902
7903 2019-03-06  Tom Tromey  <tom@tromey.com>
7904
7905         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7906         Use make_scope_exit.
7907
7908 2019-03-06  Tom Tromey  <tom@tromey.com>
7909
7910         * solib-svr4.c (disable_probes_interface): Remove parameter.
7911         (svr4_handle_solib_event): Use make_scope_exit.
7912
7913 2019-03-06  Tom Tromey  <tom@tromey.com>
7914
7915         * remote.c (struct stop_reply_deleter): Remove.
7916         (stop_reply_up): Update.
7917         (struct stop_reply): Derive from notif_event.  Don't typedef.
7918         <regcache>: Now a std::vector.
7919         (stop_reply_xfree): Remove.
7920         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7921         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7922         (remote_target::discard_pending_stop_replies): Use delete.
7923         (remote_target::remote_parse_stop_reply): Update.
7924         (remote_target::process_stop_reply): Update.
7925         * remote-notif.h (struct notif_event): Add virtual destructor.
7926         Remove "dtr" member.
7927         (struct notif_client) <alloc_event>: Return a unique_ptr.
7928         (notif_event_xfree): Don't declare.
7929         (notif_event_up): New typedef.
7930         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7931         (notif_event_xfree, do_notif_event_xfree): Remove.
7932         (remote_notif_state_xfree): Update.
7933
7934 2019-03-06  Tom Tromey  <tom@tromey.com>
7935
7936         * infrun.c (displaced_step_clear_cleanup): Now a
7937         forward_scope_exit type.
7938         (displaced_step_prepare_throw): Update.
7939         (displaced_step_fixup): Update.
7940
7941 2019-03-06  Tom Tromey  <tom@tromey.com>
7942
7943         * inferior.h (class inferior): Update comment.
7944         * gdbthread.h (class thread_info): Update comment.
7945
7946 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7947             Tom Tromey  <tom@tromey.com>
7948
7949         * stabsread.h (struct stab_section_list): Remove.
7950         (coffstab_build_psymtabs): Update.
7951         * dbxread.c (symbuf_sections): Now a std::vector.
7952         (sect_idx): New global.
7953         (fill_symbuf): Update.
7954         (coffstab_build_psymtabs): Change type of stabsects parameter.
7955         Update.
7956         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7957         std::vector.
7958         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7959         (coff_locate_sections): Update.
7960         (coff_symfile_read): Remove cleanups.  Update.
7961         (init_stringtab): Add storage parameter.
7962         (free_stringtab, free_stringtab_cleanup): Remove.
7963         (init_lineno): Add storage parameter.
7964         (free_linetab, free_linetab_cleanup): Remove.
7965
7966 2019-03-06  Pedro Alves  <palves@redhat.com>
7967
7968         * linux-fork.c (fork_info::clobber_regs): Delete.
7969         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7970         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7971         comment.  Adjust.
7972         (scoped_switch_fork_info::scoped_switch_fork_info)
7973         (checkpoint_command, linux_fork_context): Adjust
7974         fork_save_infrun_state calls.
7975
7976 2019-03-06  Pedro Alves  <palves@redhat.com>
7977
7978         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7979         (inf_has_multiple_threads): Return 'bool' and rewrite using
7980         inferior_info::threads().
7981
7982 2019-03-06  Pedro Alves  <palves@redhat.com>
7983
7984         * linux-fork.c: Include <list>.
7985         (fork_list): Now a std::list instance.
7986         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7987         (forks_exist_p, find_last_fork): Adjust.
7988         (new_fork): Delete.
7989         (one_fork_p): New.
7990         (add_fork): Adjust.
7991         (free_fork): Delete, folded into fork_info::~fork_info().
7992         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7993         Adjust.
7994         (init_fork_list): Delete.
7995         (linux_fork_killall, linux_fork_mourn_inferior)
7996         (linux_fork_detach, info_checkpoints_command): Adjust.
7997         (_initialize_linux_fork): No longer call init_fork_list.
7998
7999 2019-03-06  Pedro Alves  <palves@redhat.com>
8000
8001         * linux-fork.c (new_fork): New, split out of ...
8002         (add_fork): ... this.  Return void.  Move "first fork" special
8003         case from here, to ...
8004         (checkpoint_command): ... here.
8005         * linux-linux.h (add_fork): Return void.
8006
8007 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8008
8009         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8010
8011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8012             Chris January  <chris.january@arm.com>
8013             David Lecomber  <david.lecomber@arm.com>
8014
8015         * f-exp.y: New token, UNOP_INTRINSIC.
8016         (exp): New pattern using UNOP_INTRINSIC token.
8017         (f77_keywords): Add 'abs' keyword.
8018         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8019         (value_from_host_double): New function.
8020         (evaluate_subexp_f): Support UNOP_ABS.
8021
8022 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8023
8024         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8025         types.
8026
8027 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8028
8029         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8030         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8031         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8032
8033 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8034
8035         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8036
8037 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8038             Chris January  <chris.january@arm.com>
8039
8040         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8041         * f-exp.y: Define 'KIND' token.
8042         (exp): New pattern for KIND expressions.
8043         (ptype): Handle types with a kind extension.
8044         (direct_abs_decl): Extend to spot kind extensions.
8045         (f77_keywords): Add 'kind' to the list.
8046         (push_kind_type): New function.
8047         (convert_to_kind_type): New function.
8048         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8049         * parse.c (operator_length_standard): Likewise.
8050         * parser-defs.h (enum type_pieces): Add tp_kind.
8051         * std-operator.def: Add UNOP_KIND.
8052
8053 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8054
8055         * f-exp.y (f_parse): Set yydebug.
8056
8057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8058
8059         * f-lang.c (evaluate_subexp_f): New function.
8060         (exp_descriptor_f): New global.
8061         (f_language_defn): Use exp_descriptor_f instead of
8062         exp_descriptor_standard.
8063
8064 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8065
8066         * f-exp.y (struct token): Add comments.
8067         (dot_ops): Remove uppercase versions and the end marker.
8068         (f77_keywords): Likewise.
8069         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8070         entries in the dot_ops array are case insensitive, and use
8071         strncasecmp to compare strings.  Also some whitespace cleanup in
8072         this area.  Similar for the f77_keywords array, except entries in
8073         this list might be case sensitive.
8074
8075 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         * f-exp.y (struct f77_boolean_val): Add comments.
8078         (boolean_values): Remove uppercase versions, and end marker.
8079         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8080         and use strncasecmp to achieve case insensitivity.  Additionally,
8081         perform whitespace cleanup around this code.
8082
8083 2019-03-06  Tom Tromey  <tromey@adacore.com>
8084
8085         * remote-sim.c (gdbsim_target_open): Use result of
8086         gdb_argv::release.
8087
8088 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8089         Dirk Schubert  <dirk.schubert@arm.com>
8090         Chris January  <chris.january@arm.com>
8091
8092         * eval.c (evaluate_subexp_standard): Call Fortran argument
8093         wrapping logic.
8094         * f-lang.c (struct value): A value which can be passed into a
8095         Fortran function call.
8096         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8097         where appropriate.
8098         (struct type): Value ready for a Fortran function call.
8099         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8100         is needed.
8101         * f-lang.h (fortran_argument_convert): Declaration.
8102         (fortran_preserve_arg_pointer): Declaration.
8103         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8104
8105 2019-03-05  Tom Tromey  <tromey@adacore.com>
8106
8107         * python/py-prettyprint.c (print_string_repr): Remove #if.
8108         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8109
8110 2019-03-05  Tom Tromey  <tromey@adacore.com>
8111
8112         * target.c (the_dummy_target): Move later.  Change type to
8113         "dummy_target".
8114         (initialize_targets): Don't initialize the_dummy_target.
8115
8116 2019-03-05  Tom Tromey  <tromey@adacore.com>
8117
8118         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8119         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8120
8121 2019-03-05  Tom Tromey  <tromey@adacore.com>
8122
8123         * windows-nat.c (windows_nat_target::attach)
8124         (windows_nat_target::detach): Don't call gdb_flush.
8125         * valprint.c (generic_val_print, val_print, val_print_string):
8126         Don't call gdb_flush.
8127         * utils.c (defaulted_query): Don't call gdb_flush.
8128         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8129         * target.c (target_announce_detach): Don't call gdb_flush.
8130         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8131         * remote.c (extended_remote_target::attach): Don't call
8132         gdb_flush.
8133         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8134         * printcmd.c (do_examine): Don't call gdb_flush.
8135         (info_display_command): Don't call gdb_flush.
8136         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8137         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8138         * memattr.c (info_mem_command): Don't call gdb_flush.
8139         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8140         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8141         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8142         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8143         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8144         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8145         (gnu_nat_target::detach): Don't call gdb_flush.
8146         * f-valprint.c (f_val_print): Don't call gdb_flush.
8147         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8148         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8149         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8150         gdb_flush.
8151         * c-valprint.c (c_val_print): Don't call gdb_flush.
8152         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8153
8154 2019-03-05  Tom Tromey  <tromey@adacore.com>
8155
8156         * varobj.c (update_dynamic_varobj_children): Update.
8157         (install_default_visualizer): Use reset, not release.
8158         * value.c (set_internalvar): Update.
8159         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8160         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8161         ATTRIBUTE_UNUSED_RESULT.
8162
8163 2019-03-05  Tom Tromey  <tromey@adacore.com>
8164
8165         * remote.c (class scoped_remote_fd) <release>: Add
8166         ATTRIBUTE_UNUSED_RESULT.
8167
8168 2019-03-05  Tom Tromey  <tromey@adacore.com>
8169
8170         * macroexp.c (struct macro_buffer) <release>: Add
8171         ATTRIBUTE_UNUSED_RESULT.
8172
8173 2019-03-05  Tom Tromey  <tromey@adacore.com>
8174
8175         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8176         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8177         ATTRIBUTE_UNUSED_RESULT.
8178
8179 2019-03-05  Tom Tromey  <tromey@adacore.com>
8180
8181         * common/scoped_fd.h (class scoped_fd) <release>: Add
8182         ATTRIBUTE_UNUSED_RESULT.
8183
8184 2019-03-05  Tom Tromey  <tromey@adacore.com>
8185
8186         * parser-defs.h (struct parser_state) <release>: Add
8187         ATTRIBUTE_UNUSED_RESULT.
8188
8189 2019-03-05  Tom Tromey  <tromey@adacore.com>
8190
8191         * utils.h (class gdb_argv) <release>: Add
8192         ATTRIBUTE_UNUSED_RESULT.
8193         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8194
8195 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8196
8197         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8198         for-loop range, to avoid compiler warnings.
8199
8200         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8201         avoid compiler warnings about unused variables.
8202
8203         * NEWS: Mention end of support for native debugging on MS-Windows
8204         before XP.
8205
8206         PR gdb/24292
8207         * common/netstuff.c:
8208         * gdbserver/gdbreplay.c
8209         * gdbserver/remote-utils.c:
8210         * ser-tcp.c:
8211         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8212         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8213         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8214         'getaddrinfo' and 'freeaddrinfo' were not available before
8215         Windows XP, and mingw.org's MinGW headers by default define
8216         _WIN32_WINNT to 0x500.
8217
8218 2019-03-01  Gary Benson <gbenson@redhat.com>
8219
8220         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8221
8222 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8223             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8224
8225         PR gdb/8527
8226         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8227         set_sigint_trap, clear_sigint_trap.
8228
8229 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8230
8231         * target.c (target_detach): Clear the regcache and the
8232         frame cache.
8233
8234 2019-02-27  Pedro Alves  <palves@redhat.com>
8235
8236         * utils.c (set_screen_size): When we cap the height/width sizes,
8237         tweak the corresponding command variable to show "unlimited":
8238
8239 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8240             Pedro Alves  <palves@redhat.com>
8241
8242         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8243         before calling rl_set_screen_size.
8244
8245 2019-02-27  Tom Tromey  <tromey@adacore.com>
8246
8247         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8248         define.
8249         * python/py-value.c: Remove Python 2.4 workaround.
8250         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8251         workaround.
8252         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8253         Python 2.4 workaround.
8254         * python/python-internal.h: Remove Python 2.4 comment.
8255         (Py_ssize_t): Don't define.
8256         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8257         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8258         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8259         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8260         * python/python.c (do_start_initialization): Remove Python 2.4
8261         workaround.
8262         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8263         (print_children): Remove Python 2.4 workaround.
8264         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8265         workaround.
8266         (CHARBUFFERPROC_NAME): Remove.
8267         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8268         Python 2.4 workaround.
8269
8270 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8271
8272         * NEWS: Note minimum Python version.
8273
8274 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8275
8276         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8277         code from these functions.  Remove corresponding ifdefs.  Use
8278         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8279         Remove gotos and target of gotos.
8280         (infpy_search_memory): Likewise.
8281
8282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8283
8284         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8285         (hppa_gdbarch_init): Don't register deleted functions with
8286         gdbarch.
8287
8288 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8289
8290         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8291         (h8300_unwind_sp): Delete.
8292         (h8300_dummy_id): Delete.
8293         (h8300_gdbarch_init): Don't register deleted functions with
8294         gdbarch.
8295
8296 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8297
8298         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8299         (ft32_unwind_pc): Delete.
8300         (ft32_unwind_sp): Delete.
8301         (ft32_gdbarch_init): Don't register deleted functions with
8302         gdbarch.
8303
8304 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8305
8306         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8307         (frv_unwind_pc): Delete.
8308         (frv_unwind_sp): Delete.
8309         (frv_gdbarch_init): Don't register deleted functions with
8310         gdbarch.
8311
8312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8313
8314         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8315         (riscv_unwind_pc): Delete.
8316         (riscv_unwind_sp): Delete.
8317         (riscv_gdbarch_init): Don't register deleted functions with
8318         gdbarch.
8319
8320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8321
8322         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8323         (csky_unwind_pc): Delete.
8324         (csky_unwind_sp): Delete.
8325         (csky_gdbarch_init): Don't register deleted functions with
8326         gdbarch.
8327
8328 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8329
8330         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8331         (cris_unwind_pc): Delete.
8332         (cris_unwind_sp): Delete.
8333         (cris_gdbarch_init): Don't register deleted functions with
8334         gdbarch.
8335
8336 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8337
8338         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8339         (bfin_unwind_pc): Delete.
8340         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8341
8342 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8343
8344         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8345         (arm_unwind_pc): Delete.
8346         (arm_unwind_sp): Delete.
8347         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8348
8349 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8350
8351         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8352         (arc_unwind_pc): Delete.
8353         (arc_unwind_sp): Delete.
8354         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8355
8356 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8357
8358         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8359         (alpha_unwind_pc): Delete.
8360         (alpha_gdbarch_init): Don't register deleted functions with
8361         gdbarch.
8362
8363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8364
8365         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8366         (aarch64_unwind_pc): Delete.
8367         (aarch64_unwind_sp): Delete.
8368         (aarch64_gdbarch_init): Don't register deleted functions with
8369         gdbarch.
8370
8371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8372
8373         * gdbtypes.c (type_align): Don't consider static members when
8374         computing structure alignment.
8375
8376 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8377
8378         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8379         return 0 for other types.
8380         * arch-utils.c (default_type_align): Always return 0.
8381         * gdbarch.h: Regenerate.
8382         * gdbarch.sh (type_align): Extend comment.
8383         * gdbtypes.c (type_align): Add additional comments, always call
8384         gdbarch_type_align before applying the default rules.
8385         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8386         generic code will then apply a suitable default.
8387         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8388         types, return 0 for other types.
8389
8390 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8391
8392         * NEWS: Create a new section for the next release branch.
8393         Rename the section of the current branch, now that it has
8394         been cut.
8395
8396 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8397
8398         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8399         * version.in: Bump version to 8.3.50.DATE-git.
8400
8401 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8402
8403         * aix-thread.c (ptid_cmp): Remove unused variable.
8404         (get_signaled_thread): Likewise.
8405         (store_regs_user_thread): Likewise.
8406         (store_regs_kernel_thread): Likewise.
8407         (fetch_regs_kernel_thread): Remove shadowed variable.
8408
8409 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8410
8411         * features/riscv/32bit-cpu.xml: Add register numbers.
8412         * features/riscv/32bit-fpu.c: Regenerate.
8413         * features/riscv/32bit-fpu.xml: Add register numbers.
8414         * features/riscv/64bit-cpu.xml: Add register numbers.
8415         * features/riscv/64bit-fpu.c: Regenerate.
8416         * features/riscv/64bit-fpu.xml: Add register numbers.
8417
8418 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8419
8420         * NEWS: Mention two argument form of gdb.Value constructor.
8421         * python/py-value.c (convert_buffer_and_type_to_value): New
8422         function.
8423         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8424         Add support for handling an optional second argument.  Call
8425         convert_buffer_and_type_to_value as appropriate.
8426         * python/python-internal.h (Py_buffer_deleter): New struct.
8427         (Py_buffer_up): New typedef.
8428
8429 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8430
8431         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8432         instead of releasing ownership.
8433
8434 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8435
8436         * dwarf2read.c (open_and_init_dwp_file): Call
8437         elf_numsections instead of bfd_count_sections to initialize
8438         dwp_file->num_sections.
8439
8440 2019-02-25  Tom Tromey  <tromey@adacore.com>
8441
8442         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8443
8444 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8445
8446         * gcore.in: Add '--readnever' option when invoking GDB.
8447
8448 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8449
8450         * MAINTAINERS: Update my email address.
8451
8452 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8453
8454         * build-id.c (build_id_to_debug_bfd_1): New function.
8455         (build_id_to_debug_bfd): Look for separate debug file in
8456         sysroot.
8457
8458 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * gdbarch.sh: Update the copyright year range that is placed into
8461         generated files.
8462
8463 2019-02-22  Keith Seitz  <keiths@redhat.com>
8464
8465         PR symtab/23853
8466         * linespec.c (create_sals_line_offset): Search for the default
8467         symtab's filename instead of its fullname.
8468
8469 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8470
8471         * NEWS: Update style defaults.
8472
8473 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8474
8475         * main.c (captured_main_1): Disable styling in batch mode.
8476
8477 2019-02-20  Tom Tromey  <tom@tromey.com>
8478
8479         * symtab.c (symtab_symbol_info): Fix typos.
8480
8481 2019-02-20  Tom Tromey  <tromey@adacore.com>
8482
8483         * findcmd.c (_initialize_mem_search): Use upper case for
8484         metasyntactic variables.
8485
8486 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8487
8488         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8489         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8490
8491 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8492
8493         * top.h (source_file_name): Change to std::string.
8494         * top.c (source_file_name): Likewise.
8495         (command_line_input): Adjust.
8496         * cli/cli-script.c (script_from_file): Adjust.
8497
8498 2019-02-19  Tom Tromey  <tromey@adacore.com>
8499
8500         * ravenscar-thread.c
8501         (ravenscar_thread_target::update_thread_list): Don't call
8502         ada_build_task_list.
8503         * ada-lang.h (ada_build_task_list): Don't declare.
8504         * ada-tasks.c (struct ada_tasks_inferior_data)
8505         <task_list_valid_p>: Now bool.
8506         (read_known_tasks, ada_task_list_changed)
8507         (ada_tasks_invalidate_inferior_data): Update.
8508         (read_known_tasks_array): Return bool.
8509         (read_known_tasks_list): Likewise.
8510         (read_known_tasks): Return void.
8511         (ada_build_task_list): Now static.
8512
8513 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8514
8515         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8516         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8517
8518 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8519
8520         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8521         variant for ada_tasks_pspace_data_handle and
8522         ada_tasks_inferior_data_handle.
8523         (ada_tasks_pspace_data_cleanup): New function.
8524         (ada_tasks_inferior_data_cleanup): New function.
8525
8526 2019-02-17  Tom Tromey  <tom@tromey.com>
8527
8528         * macrotab.h (macro_source_fullname): Return a std::string.
8529         * macrotab.c (macro_include, check_for_redefinition)
8530         (macro_undef, macro_lookup_definition, foreach_macro)
8531         (foreach_macro_in_scope): Update.
8532         (macro_source_fullname): Return a std::string.
8533         * macrocmd.c (show_pp_source_pos): Update.
8534
8535 2019-02-17  Tom Tromey  <tom@tromey.com>
8536
8537         * macrocmd.c (show_pp_source_pos): Style the file names.
8538
8539 2019-02-17  Tom Tromey  <tom@tromey.com>
8540
8541         PR tui/24197:
8542         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8543
8544 2019-02-17  Tom Tromey  <tom@tromey.com>
8545
8546         * ada-lang.c (user_select_syms): Use filtered printing.
8547         * utils.c (wrap_style): New global.
8548         (desired_style): Remove.
8549         (emit_style_escape): Add stream parameter.
8550         (set_output_style, reset_terminal_style, prompt_for_continue):
8551         Update.
8552         (flush_wrap_buffer): Only flush gdb_stdout.
8553         (wrap_here): Set wrap_style.
8554         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8555         treat escape sequences as a character.  Change when wrap buffer is
8556         flushed.
8557         (fputs_styled): Do not set the output style when the default is
8558         requested.
8559         * ui-style.h (struct ui_file_style) <is_default>: New method.
8560         * source.c (print_source_lines_base): Emit escape sequences in one
8561         piece.
8562
8563 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8564
8565         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8566         integers and enumeration types.
8567
8568 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8569
8570         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8571         instead of lookup_symbol_in_language
8572         (do_exact_match): New function.
8573         (ada_get_symbol_name_matcher): Return do_exact_match when
8574         doing a verbatim match.
8575
8576 2019-02-15  Tom Tromey  <tromey@adacore.com>
8577
8578         * ravenscar-thread.c (ravenscar_thread_target::resume)
8579         (ravenscar_thread_target::wait): Special case wildcard requests.
8580
8581 2019-02-15  Tom Tromey  <tromey@adacore.com>
8582
8583         * ravenscar-thread.c (base_ptid): Remove.
8584         (struct ravenscar_thread_target) <close>: New method.
8585         <m_base_ptid>: New member.
8586         <update_inferior_ptid, active_task, task_is_currently_active,
8587         runtime_initialized>: Declare methods.
8588         <ravenscar_thread_target>: Add constructor.
8589         (ravenscar_thread_target::task_is_currently_active)
8590         (ravenscar_thread_target::update_inferior_ptid)
8591         (ravenscar_runtime_initialized): Rename.  Now methods.
8592         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8593         (ravenscar_thread_target::update_thread_list): Update.
8594         (ravenscar_thread_target::active_task): Now method.
8595         (ravenscar_thread_target::store_registers)
8596         (ravenscar_thread_target::prepare_to_store)
8597         (ravenscar_thread_target::prepare_to_store)
8598         (ravenscar_thread_target::mourn_inferior): Update.
8599         (ravenscar_inferior_created): Use "new" to create target.
8600         (ravenscar_thread_target::get_ada_task_ptid): Update.
8601         (_initialize_ravenscar): Don't initialize base_ptid.
8602         (ravenscar_ops): Remove global.
8603
8604 2019-02-15  Tom Tromey  <tromey@adacore.com>
8605
8606         * target.h (push_target): Declare new overload.
8607         * target.c (push_target): New overload, taking an rvalue reference.
8608         * remote.c (remote_target::open_1): Use push_target overload.
8609         * corelow.c (core_target_open): Use push_target overload.
8610
8611 2019-02-15  Tom Tromey  <tromey@adacore.com>
8612
8613         * ravenscar-thread.c (is_ravenscar_task)
8614         (ravenscar_task_is_currently_active): Return bool.
8615         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8616         (_initialize_ravenscar): Remove "(void)".
8617         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8618         Return bool.
8619
8620 2019-02-15  Tom Tromey  <tromey@adacore.com>
8621
8622         * ravenscar-thread.c (ravenscar_runtime_initializer)
8623         (has_ravenscar_runtime, get_running_thread_id)
8624         (ravenscar_thread_target::resume): Fix indentation.
8625
8626 2019-02-15  Tom Tromey  <tromey@adacore.com>
8627
8628         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8629         from ravenscar_arch_ops.
8630         (sparc_ravenscar_ops::fetch_registers)
8631         (sparc_ravenscar_ops::store_registers): Now methods.
8632         (sparc_ravenscar_prepare_to_store): Remove.
8633         (sparc_ravenscar_ops): Redefine.
8634         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8635         methods and destructor.  Remove members.
8636         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8637         (ravenscar_thread_target::store_registers)
8638         (ravenscar_thread_target::prepare_to_store): Update.
8639         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8640         Remove.
8641         (struct ppc_ravenscar_powerpc_ops): Derive from
8642         ravenscar_arch_ops.
8643         (ppc_ravenscar_powerpc_ops::fetch_registers)
8644         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8645         (ppc_ravenscar_powerpc_ops): Redefine.
8646         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8647         (ppc_ravenscar_e500_ops::fetch_registers)
8648         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8649         (ppc_ravenscar_e500_ops): Redefine.
8650         * aarch64-ravenscar-thread.c
8651         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8652         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8653         (aarch64_ravenscar_fetch_registers)
8654         (aarch64_ravenscar_store_registers): Now methods.
8655         (aarch64_ravenscar_ops): Redefine.
8656
8657 2019-02-15  Tom Tromey  <tromey@adacore.com>
8658
8659         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8660         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8661         (ravenscar_thread_target::stopped_by_watchpoint)
8662         (ravenscar_thread_target::stopped_data_address)
8663         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8664
8665 2019-02-15  Tom Tromey  <tromey@adacore.com>
8666
8667         * ravenscar-thread.c: Fix some typos.
8668
8669 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8670             Tom Tromey  <tromey@adacore.com>
8671
8672         * ada-lang.c (ada_exception_sal): Change addr_string to a
8673         std::string.
8674         (create_ada_exception_catchpoint): Update.
8675
8676 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8677             Tom Tromey  <tromey@adacore.com>
8678
8679         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8680         (bp_location_ops): Remove.
8681         (base_breakpoint_allocate_location): Update.
8682         (free_bp_location): Update.
8683         * ada-lang.c (class ada_catchpoint_location)
8684         <ada_catchpoint_location>: Remove ops parameter.
8685         (ada_catchpoint_location_dtor): Remove.
8686         (ada_catchpoint_location_ops): Remove.
8687         (allocate_location_exception): Update.
8688         * breakpoint.h (struct bp_location_ops): Remove.
8689         (class bp_location) <bp_location>: Remove bp_location_ops
8690         parameter.
8691         <~bp_location>: Add destructor.
8692         <ops>: Remove.
8693
8694 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8695             Pedro Alves  <palves@redhat.com>
8696
8697         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8698         'PATH_MAX'.
8699
8700 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8701             Samuel Thibault  <samuel.thibault@gnu.org>
8702             Thomas Schwinge  <thomas@codesourcery.com>
8703
8704         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8705         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8706
8707 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8708
8709         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8710         (check_empty): Use "const char *".
8711
8712         * gnu-nat.c (gnu_nat_target::detach): Instead of
8713         'detach_inferior (pid)' call
8714         'detach_inferior (find_inferior_pid (pid))'.
8715
8716         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8717         'nat/fork-inferior.o'.
8718         * gnu-nat.c: #include "nat/fork-inferior.h".
8719
8720         * gnu-nat.c (gnu_nat_target::detach): Instead of
8721         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8722         * gnu-nat.h: #include "inf-child.h".
8723         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8724         'i386_gnu_nat_target::fetch_registers'.
8725         (gnu_store_registers): Rename/move to
8726         'i386_gnu_nat_target::store_registers'.
8727
8728         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8729         * gnu-nat.h (mach_thread_info): New function.
8730         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8731
8732         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8733
8734 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8735
8736         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8737
8738 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8739
8740         * windows-nat.c (windows_add_thread): Add new parameter
8741         "main_thread_p" with default value set to false.  Update
8742         function documentation as well as all callers.
8743         (windows_delete_thread): Likewise.
8744         (fake_create_process): Update call to windows_add_thread.
8745         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8746         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8747         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8748         call to windows_delete_thread.
8749
8750 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8751
8752         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8753
8754 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8755
8756         * symfile.c (find_separate_debug_file): Use canonical path of
8757         sysroot with child_path instead of gdb_sysroot if it is valid.
8758
8759 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8760
8761         * symfile.c (find_separate_debug_file): Use child_path to
8762         determine if an object file is under a sysroot.
8763
8764 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8765
8766         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8767         unittests/child-path-selftests.c.
8768         * common/pathstuff.c (child_path): New function.
8769         * common/pathstuff.h (child_path): New prototype.
8770         * unittests/child-path-selftests.c: New file.
8771
8772 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8773
8774         * symfile.c (find_separate_debug_file): Look for separate debug
8775         files in debug directories under the sysroot.
8776
8777 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8778
8779         * symtab.h (struct minimal_symbol data_p): New const method.
8780         (struct minimal_symbol text_p): Likewise.
8781         * symtab.c (output_source_filename): Use file name style
8782         to print file name.
8783         (print_symbol_info): Likewise.
8784         (print_msymbol_info): Use address style to print addresses.
8785         Use function name style to print executable text symbols.
8786         (expand_symtab_containing_pc): Use data_p.
8787         (find_pc_sect_compunit_symtab): Likewise.
8788
8789 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8790
8791         * breakpoint.c (describe_other_breakpoints): Use address style
8792         to print addresses.
8793         (say_where): Likewise.
8794
8795 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8796
8797         * ada-typeprint.c (print_func_type): Print function name
8798         style to print function name.
8799         * c-typeprint.c (c_print_type_1): Likewise.
8800
8801 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8802
8803         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8804         for execve.
8805
8806 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8807
8808         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8809         type_stack.
8810
8811 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8812
8813         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8814         TYPE_CODE_REF types.
8815
8816 2019-02-08  Jim Wilson  <jimw@sifive.com>
8817
8818         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8819         (riscv_linux_fregset): New.
8820         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8821
8822 2019-02-07  Tom Tromey  <tom@tromey.com>
8823
8824         * thread.c (thread_cancel_execution_command): Update.
8825         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8826         methods.
8827         (struct thread_fsm_ops): Remove.
8828         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8829         (thread_fsm_should_stop, thread_fsm_return_value)
8830         (thread_fsm_set_finished, thread_fsm_finished_p)
8831         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8832         Don't declare.
8833         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8834         * infrun.c (clear_proceed_status_thread)
8835         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8836         (print_stop_event): Update.
8837         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8838         Add constructor.
8839         (step_command_fsm_ops): Remove.
8840         (new_step_command_fsm): Remove.
8841         (step_1): Update.
8842         (step_command_fsm::should_stop): Rename from
8843         step_command_fsm_should_stop.
8844         (step_command_fsm::clean_up): Rename from
8845         step_command_fsm_clean_up.
8846         (step_command_fsm::do_async_reply_reason): Rename from
8847         step_command_fsm_async_reply_reason.
8848         (struct until_next_fsm): Inherit from thread_fsm.  Add
8849         constructor.
8850         (until_next_fsm_ops): Remove.
8851         (new_until_next_fsm): Remove.
8852         (until_next_fsm::should_stop): Rename from
8853         until_next_fsm_should_stop.
8854         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8855         (until_next_fsm::do_async_reply_reason): Rename from
8856         until_next_fsm_async_reply_reason.
8857         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8858         constructor.  Change type of breakpoint.
8859         (finish_command_fsm_ops): Remove.
8860         (new_finish_command_fsm): Remove.
8861         (finish_command_fsm::should_stop): Rename from
8862         finish_command_fsm_should_stop.
8863         (finish_command_fsm::clean_up): Rename from
8864         finish_command_fsm_clean_up.
8865         (finish_command_fsm::return_value): Rename from
8866         finish_command_fsm_return_value.
8867         (finish_command_fsm::do_async_reply_reason): Rename from
8868         finish_command_fsm_async_reply_reason.
8869         (finish_command): Update.
8870         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8871         Add constructor.
8872         (call_thread_fsm_ops): Remove.
8873         (call_thread_fsm::call_thread_fsm): Rename from
8874         new_call_thread_fsm.
8875         (call_thread_fsm::should_stop): Rename from
8876         call_thread_fsm_should_stop.
8877         (call_thread_fsm::should_notify_stop): Rename from
8878         call_thread_fsm_should_notify_stop.
8879         (run_inferior_call, call_function_by_hand_dummy): Update.
8880         * cli/cli-interp.c (should_print_stop_to_console): Update.
8881         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8882         Add constructor.  Change type of location_breakpoint,
8883         caller_breakpoint.
8884         (until_break_fsm_ops): Remove.
8885         (new_until_break_fsm): Remove.
8886         (until_break_fsm::should_stop): Rename from
8887         until_break_fsm_should_stop.
8888         (until_break_fsm::clean_up): Rename from
8889         until_break_fsm_clean_up.
8890         (until_break_fsm::do_async_reply_reason): Rename from
8891         until_break_fsm_async_reply_reason.
8892         (until_break_command): Update.
8893         * thread-fsm.c: Remove.
8894         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8895
8896 2019-02-07  Tom Tromey  <tom@tromey.com>
8897
8898         * yy-remap.h: Add include guard.
8899         * xtensa-tdep.h: Add include guard.
8900         * xcoffread.h: Rename include guard.
8901         * varobj-iter.h: Add include guard.
8902         * tui/tui.h: Rename include guard.
8903         * tui/tui-winsource.h: Rename include guard.
8904         * tui/tui-wingeneral.h: Rename include guard.
8905         * tui/tui-windata.h: Rename include guard.
8906         * tui/tui-win.h: Rename include guard.
8907         * tui/tui-stack.h: Rename include guard.
8908         * tui/tui-source.h: Rename include guard.
8909         * tui/tui-regs.h: Rename include guard.
8910         * tui/tui-out.h: Rename include guard.
8911         * tui/tui-layout.h: Rename include guard.
8912         * tui/tui-io.h: Rename include guard.
8913         * tui/tui-hooks.h: Rename include guard.
8914         * tui/tui-file.h: Rename include guard.
8915         * tui/tui-disasm.h: Rename include guard.
8916         * tui/tui-data.h: Rename include guard.
8917         * tui/tui-command.h: Rename include guard.
8918         * tic6x-tdep.h: Add include guard.
8919         * target/waitstatus.h: Rename include guard.
8920         * target/wait.h: Rename include guard.
8921         * target/target.h: Rename include guard.
8922         * target/resume.h: Rename include guard.
8923         * target-float.h: Rename include guard.
8924         * stabsread.h: Add include guard.
8925         * rs6000-tdep.h: Add include guard.
8926         * riscv-fbsd-tdep.h: Add include guard.
8927         * regformats/regdef.h: Rename include guard.
8928         * record.h: Rename include guard.
8929         * python/python.h: Rename include guard.
8930         * python/python-internal.h: Rename include guard.
8931         * python/py-stopevent.h: Rename include guard.
8932         * python/py-ref.h: Rename include guard.
8933         * python/py-record.h: Rename include guard.
8934         * python/py-record-full.h: Rename include guard.
8935         * python/py-record-btrace.h: Rename include guard.
8936         * python/py-instruction.h: Rename include guard.
8937         * python/py-events.h: Rename include guard.
8938         * python/py-event.h: Rename include guard.
8939         * procfs.h: Add include guard.
8940         * proc-utils.h: Add include guard.
8941         * p-lang.h: Add include guard.
8942         * or1k-tdep.h: Rename include guard.
8943         * observable.h: Rename include guard.
8944         * nto-tdep.h: Rename include guard.
8945         * nat/x86-linux.h: Rename include guard.
8946         * nat/x86-linux-dregs.h: Rename include guard.
8947         * nat/x86-gcc-cpuid.h: Add include guard.
8948         * nat/x86-dregs.h: Rename include guard.
8949         * nat/x86-cpuid.h: Rename include guard.
8950         * nat/ppc-linux.h: Rename include guard.
8951         * nat/mips-linux-watch.h: Rename include guard.
8952         * nat/linux-waitpid.h: Rename include guard.
8953         * nat/linux-ptrace.h: Rename include guard.
8954         * nat/linux-procfs.h: Rename include guard.
8955         * nat/linux-osdata.h: Rename include guard.
8956         * nat/linux-nat.h: Rename include guard.
8957         * nat/linux-namespaces.h: Rename include guard.
8958         * nat/linux-btrace.h: Rename include guard.
8959         * nat/glibc_thread_db.h: Rename include guard.
8960         * nat/gdb_thread_db.h: Rename include guard.
8961         * nat/gdb_ptrace.h: Rename include guard.
8962         * nat/fork-inferior.h: Rename include guard.
8963         * nat/amd64-linux-siginfo.h: Rename include guard.
8964         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8965         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8966         * nat/aarch64-linux.h: Rename include guard.
8967         * nat/aarch64-linux-hw-point.h: Rename include guard.
8968         * mn10300-tdep.h: Add include guard.
8969         * mips-linux-tdep.h: Add include guard.
8970         * mi/mi-parse.h: Rename include guard.
8971         * mi/mi-out.h: Rename include guard.
8972         * mi/mi-main.h: Rename include guard.
8973         * mi/mi-interp.h: Rename include guard.
8974         * mi/mi-getopt.h: Rename include guard.
8975         * mi/mi-console.h: Rename include guard.
8976         * mi/mi-common.h: Rename include guard.
8977         * mi/mi-cmds.h: Rename include guard.
8978         * mi/mi-cmd-break.h: Rename include guard.
8979         * m2-lang.h: Add include guard.
8980         * location.h: Rename include guard.
8981         * linux-record.h: Rename include guard.
8982         * linux-nat.h: Add include guard.
8983         * linux-fork.h: Add include guard.
8984         * i386-darwin-tdep.h: Rename include guard.
8985         * hppa-linux-offsets.h: Add include guard.
8986         * guile/guile.h: Rename include guard.
8987         * guile/guile-internal.h: Rename include guard.
8988         * gnu-nat.h: Rename include guard.
8989         * gdb-stabs.h: Rename include guard.
8990         * frv-tdep.h: Add include guard.
8991         * f-lang.h: Add include guard.
8992         * event-loop.h: Add include guard.
8993         * darwin-nat.h: Rename include guard.
8994         * cp-abi.h: Rename include guard.
8995         * config/sparc/nm-sol2.h: Rename include guard.
8996         * config/nm-nto.h: Rename include guard.
8997         * config/nm-linux.h: Add include guard.
8998         * config/i386/nm-i386gnu.h: Rename include guard.
8999         * config/djgpp/nl_types.h: Rename include guard.
9000         * config/djgpp/langinfo.h: Rename include guard.
9001         * compile/gcc-cp-plugin.h: Add include guard.
9002         * compile/gcc-c-plugin.h: Add include guard.
9003         * compile/compile.h: Rename include guard.
9004         * compile/compile-object-run.h: Rename include guard.
9005         * compile/compile-object-load.h: Rename include guard.
9006         * compile/compile-internal.h: Rename include guard.
9007         * compile/compile-cplus.h: Rename include guard.
9008         * compile/compile-c.h: Rename include guard.
9009         * common/xml-utils.h: Rename include guard.
9010         * common/x86-xstate.h: Rename include guard.
9011         * common/version.h: Rename include guard.
9012         * common/vec.h: Rename include guard.
9013         * common/tdesc.h: Rename include guard.
9014         * common/selftest.h: Rename include guard.
9015         * common/scoped_restore.h: Rename include guard.
9016         * common/scoped_mmap.h: Rename include guard.
9017         * common/scoped_fd.h: Rename include guard.
9018         * common/safe-iterator.h: Rename include guard.
9019         * common/run-time-clock.h: Rename include guard.
9020         * common/refcounted-object.h: Rename include guard.
9021         * common/queue.h: Rename include guard.
9022         * common/ptid.h: Rename include guard.
9023         * common/print-utils.h: Rename include guard.
9024         * common/preprocessor.h: Rename include guard.
9025         * common/pathstuff.h: Rename include guard.
9026         * common/observable.h: Rename include guard.
9027         * common/netstuff.h: Rename include guard.
9028         * common/job-control.h: Rename include guard.
9029         * common/host-defs.h: Rename include guard.
9030         * common/gdb_wait.h: Rename include guard.
9031         * common/gdb_vecs.h: Rename include guard.
9032         * common/gdb_unlinker.h: Rename include guard.
9033         * common/gdb_unique_ptr.h: Rename include guard.
9034         * common/gdb_tilde_expand.h: Rename include guard.
9035         * common/gdb_sys_time.h: Rename include guard.
9036         * common/gdb_string_view.h: Rename include guard.
9037         * common/gdb_splay_tree.h: Rename include guard.
9038         * common/gdb_setjmp.h: Rename include guard.
9039         * common/gdb_ref_ptr.h: Rename include guard.
9040         * common/gdb_optional.h: Rename include guard.
9041         * common/gdb_locale.h: Rename include guard.
9042         * common/gdb_assert.h: Rename include guard.
9043         * common/filtered-iterator.h: Rename include guard.
9044         * common/filestuff.h: Rename include guard.
9045         * common/fileio.h: Rename include guard.
9046         * common/environ.h: Rename include guard.
9047         * common/common-utils.h: Rename include guard.
9048         * common/common-types.h: Rename include guard.
9049         * common/common-regcache.h: Rename include guard.
9050         * common/common-inferior.h: Rename include guard.
9051         * common/common-gdbthread.h: Rename include guard.
9052         * common/common-exceptions.h: Rename include guard.
9053         * common/common-defs.h: Rename include guard.
9054         * common/common-debug.h: Rename include guard.
9055         * common/cleanups.h: Rename include guard.
9056         * common/buffer.h: Rename include guard.
9057         * common/btrace-common.h: Rename include guard.
9058         * common/break-common.h: Rename include guard.
9059         * cli/cli-utils.h: Rename include guard.
9060         * cli/cli-style.h: Rename include guard.
9061         * cli/cli-setshow.h: Rename include guard.
9062         * cli/cli-script.h: Rename include guard.
9063         * cli/cli-interp.h: Rename include guard.
9064         * cli/cli-decode.h: Rename include guard.
9065         * cli/cli-cmds.h: Rename include guard.
9066         * charset-list.h: Add include guard.
9067         * buildsym-legacy.h: Rename include guard.
9068         * bfin-tdep.h: Add include guard.
9069         * ax.h: Rename include guard.
9070         * arm-linux-tdep.h: Add include guard.
9071         * arm-fbsd-tdep.h: Add include guard.
9072         * arch/xtensa.h: Rename include guard.
9073         * arch/tic6x.h: Add include guard.
9074         * arch/i386.h: Add include guard.
9075         * arch/arm.h: Rename include guard.
9076         * arch/arm-linux.h: Rename include guard.
9077         * arch/arm-get-next-pcs.h: Rename include guard.
9078         * arch/amd64.h: Add include guard.
9079         * arch/aarch64-insn.h: Rename include guard.
9080         * arch-utils.h: Rename include guard.
9081         * annotate.h: Add include guard.
9082         * amd64-darwin-tdep.h: Rename include guard.
9083         * aarch64-linux-tdep.h: Add include guard.
9084         * aarch64-fbsd-tdep.h: Add include guard.
9085         * aarch32-linux-nat.h: Add include guard.
9086
9087 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9088
9089         * macrotab.c (macro_define_internal): New function that
9090         factorizes macro_define_object_internal and macro_define_function
9091         code.
9092         (macro_define_object_internal): Use macro_define_internal.
9093         (macro_define_function): Likewise.
9094
9095 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9096
9097         * macrocmd.c (extract_identifier): Return
9098         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9099         callers.
9100
9101 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9102
9103         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9104
9105 2019-02-05  Tom Tromey  <tom@tromey.com>
9106
9107         * target.c (target_stack::unpush): Move assertion earlier.
9108
9109 2019-01-30  Tom Tromey  <tom@tromey.com>
9110
9111         PR python/23615:
9112         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9113         (gdbpy_parse_and_eval): Likewise.
9114         * python/python-internal.h (gdbpy_allow_threads): New class.
9115
9116 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9117
9118         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9119         (aarch64_fbsd_fpregmap): Move earlier.
9120         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9121         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9122         instead of individual calls to trad_frame_set_reg_addr.
9123         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9124         earlier.
9125         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9126         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9127         instead of individual calls to trad_frame_set_reg_addr.
9128
9129 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9130
9131         * CONTRIBUTE: Replace contribution list with wiki link.
9132
9133 2019-01-25  Tom Tromey  <tom@tromey.com>
9134
9135         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9136
9137 2019-01-25  Tom Tromey  <tom@tromey.com>
9138
9139         * xtensa-linux-nat.c: Fix common/ includes.
9140         * xml-support.h: Fix common/ includes.
9141         * xml-support.c: Fix common/ includes.
9142         * x86-linux-nat.c: Fix common/ includes.
9143         * windows-nat.c: Fix common/ includes.
9144         * varobj.h: Fix common/ includes.
9145         * varobj.c: Fix common/ includes.
9146         * value.c: Fix common/ includes.
9147         * valops.c: Fix common/ includes.
9148         * utils.c: Fix common/ includes.
9149         * unittests/xml-utils-selftests.c: Fix common/ includes.
9150         * unittests/utils-selftests.c: Fix common/ includes.
9151         * unittests/unpack-selftests.c: Fix common/ includes.
9152         * unittests/tracepoint-selftests.c: Fix common/ includes.
9153         * unittests/style-selftests.c: Fix common/ includes.
9154         * unittests/string_view-selftests.c: Fix common/ includes.
9155         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9156         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9157         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9158         * unittests/rsp-low-selftests.c: Fix common/ includes.
9159         * unittests/parse-connection-spec-selftests.c: Fix common/
9160         includes.
9161         * unittests/optional-selftests.c: Fix common/ includes.
9162         * unittests/offset-type-selftests.c: Fix common/ includes.
9163         * unittests/observable-selftests.c: Fix common/ includes.
9164         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9165         * unittests/memrange-selftests.c: Fix common/ includes.
9166         * unittests/memory-map-selftests.c: Fix common/ includes.
9167         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9168         * unittests/function-view-selftests.c: Fix common/ includes.
9169         * unittests/environ-selftests.c: Fix common/ includes.
9170         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9171         * unittests/common-utils-selftests.c: Fix common/ includes.
9172         * unittests/cli-utils-selftests.c: Fix common/ includes.
9173         * unittests/array-view-selftests.c: Fix common/ includes.
9174         * ui-file.c: Fix common/ includes.
9175         * tui/tui-io.c: Fix common/ includes.
9176         * tracepoint.h: Fix common/ includes.
9177         * tracepoint.c: Fix common/ includes.
9178         * tracefile-tfile.c: Fix common/ includes.
9179         * top.h: Fix common/ includes.
9180         * top.c: Fix common/ includes.
9181         * thread.c: Fix common/ includes.
9182         * target/waitstatus.h: Fix common/ includes.
9183         * target/waitstatus.c: Fix common/ includes.
9184         * target.h: Fix common/ includes.
9185         * target.c: Fix common/ includes.
9186         * target-memory.c: Fix common/ includes.
9187         * target-descriptions.c: Fix common/ includes.
9188         * symtab.h: Fix common/ includes.
9189         * symfile.c: Fix common/ includes.
9190         * stap-probe.c: Fix common/ includes.
9191         * spu-linux-nat.c: Fix common/ includes.
9192         * sparc-nat.c: Fix common/ includes.
9193         * source.c: Fix common/ includes.
9194         * solib.c: Fix common/ includes.
9195         * solib-target.c: Fix common/ includes.
9196         * ser-unix.c: Fix common/ includes.
9197         * ser-tcp.c: Fix common/ includes.
9198         * ser-pipe.c: Fix common/ includes.
9199         * ser-base.c: Fix common/ includes.
9200         * selftest-arch.c: Fix common/ includes.
9201         * s12z-tdep.c: Fix common/ includes.
9202         * rust-exp.y: Fix common/ includes.
9203         * rs6000-aix-tdep.c: Fix common/ includes.
9204         * riscv-tdep.c: Fix common/ includes.
9205         * remote.c: Fix common/ includes.
9206         * remote-notif.h: Fix common/ includes.
9207         * remote-fileio.h: Fix common/ includes.
9208         * remote-fileio.c: Fix common/ includes.
9209         * regcache.h: Fix common/ includes.
9210         * regcache.c: Fix common/ includes.
9211         * record-btrace.c: Fix common/ includes.
9212         * python/python.c: Fix common/ includes.
9213         * python/py-type.c: Fix common/ includes.
9214         * python/py-inferior.c: Fix common/ includes.
9215         * progspace.h: Fix common/ includes.
9216         * producer.c: Fix common/ includes.
9217         * procfs.c: Fix common/ includes.
9218         * proc-api.c: Fix common/ includes.
9219         * printcmd.c: Fix common/ includes.
9220         * ppc-linux-nat.c: Fix common/ includes.
9221         * parser-defs.h: Fix common/ includes.
9222         * osdata.c: Fix common/ includes.
9223         * obsd-nat.c: Fix common/ includes.
9224         * nat/x86-linux.c: Fix common/ includes.
9225         * nat/x86-linux-dregs.c: Fix common/ includes.
9226         * nat/x86-dregs.h: Fix common/ includes.
9227         * nat/x86-dregs.c: Fix common/ includes.
9228         * nat/ppc-linux.c: Fix common/ includes.
9229         * nat/mips-linux-watch.h: Fix common/ includes.
9230         * nat/mips-linux-watch.c: Fix common/ includes.
9231         * nat/linux-waitpid.c: Fix common/ includes.
9232         * nat/linux-ptrace.h: Fix common/ includes.
9233         * nat/linux-ptrace.c: Fix common/ includes.
9234         * nat/linux-procfs.c: Fix common/ includes.
9235         * nat/linux-personality.c: Fix common/ includes.
9236         * nat/linux-osdata.c: Fix common/ includes.
9237         * nat/linux-namespaces.c: Fix common/ includes.
9238         * nat/linux-btrace.h: Fix common/ includes.
9239         * nat/linux-btrace.c: Fix common/ includes.
9240         * nat/fork-inferior.c: Fix common/ includes.
9241         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9242         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9243         * nat/aarch64-linux.c: Fix common/ includes.
9244         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9245         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9246         * namespace.h: Fix common/ includes.
9247         * mips-linux-tdep.c: Fix common/ includes.
9248         * minsyms.c: Fix common/ includes.
9249         * mi/mi-parse.h: Fix common/ includes.
9250         * mi/mi-main.c: Fix common/ includes.
9251         * mi/mi-cmd-env.c: Fix common/ includes.
9252         * memrange.h: Fix common/ includes.
9253         * memattr.c: Fix common/ includes.
9254         * maint.h: Fix common/ includes.
9255         * maint.c: Fix common/ includes.
9256         * main.c: Fix common/ includes.
9257         * machoread.c: Fix common/ includes.
9258         * location.c: Fix common/ includes.
9259         * linux-thread-db.c: Fix common/ includes.
9260         * linux-nat.c: Fix common/ includes.
9261         * linux-fork.c: Fix common/ includes.
9262         * inline-frame.c: Fix common/ includes.
9263         * infrun.c: Fix common/ includes.
9264         * inflow.c: Fix common/ includes.
9265         * inferior.h: Fix common/ includes.
9266         * inferior.c: Fix common/ includes.
9267         * infcmd.c: Fix common/ includes.
9268         * inf-ptrace.c: Fix common/ includes.
9269         * inf-child.c: Fix common/ includes.
9270         * ia64-linux-nat.c: Fix common/ includes.
9271         * i387-tdep.c: Fix common/ includes.
9272         * i386-tdep.c: Fix common/ includes.
9273         * i386-linux-tdep.c: Fix common/ includes.
9274         * i386-linux-nat.c: Fix common/ includes.
9275         * i386-go32-tdep.c: Fix common/ includes.
9276         * i386-fbsd-tdep.c: Fix common/ includes.
9277         * i386-fbsd-nat.c: Fix common/ includes.
9278         * guile/scm-type.c: Fix common/ includes.
9279         * guile/guile.c: Fix common/ includes.
9280         * go32-nat.c: Fix common/ includes.
9281         * gnu-nat.c: Fix common/ includes.
9282         * gdbthread.h: Fix common/ includes.
9283         * gdbarch-selftests.c: Fix common/ includes.
9284         * gdb_usleep.c: Fix common/ includes.
9285         * gdb_select.h: Fix common/ includes.
9286         * gdb_bfd.c: Fix common/ includes.
9287         * gcore.c: Fix common/ includes.
9288         * fork-child.c: Fix common/ includes.
9289         * findvar.c: Fix common/ includes.
9290         * fbsd-nat.c: Fix common/ includes.
9291         * event-top.c: Fix common/ includes.
9292         * event-loop.c: Fix common/ includes.
9293         * dwarf2read.c: Fix common/ includes.
9294         * dwarf2loc.c: Fix common/ includes.
9295         * dwarf2-frame.c: Fix common/ includes.
9296         * dwarf-index-cache.c: Fix common/ includes.
9297         * dtrace-probe.c: Fix common/ includes.
9298         * disasm-selftests.c: Fix common/ includes.
9299         * defs.h: Fix common/ includes.
9300         * csky-tdep.c: Fix common/ includes.
9301         * cp-valprint.c: Fix common/ includes.
9302         * cp-support.h: Fix common/ includes.
9303         * cp-support.c: Fix common/ includes.
9304         * corelow.c: Fix common/ includes.
9305         * completer.h: Fix common/ includes.
9306         * completer.c: Fix common/ includes.
9307         * compile/compile.c: Fix common/ includes.
9308         * compile/compile-loc2c.c: Fix common/ includes.
9309         * compile/compile-cplus-types.c: Fix common/ includes.
9310         * compile/compile-cplus-symbols.c: Fix common/ includes.
9311         * command.h: Fix common/ includes.
9312         * cli/cli-dump.c: Fix common/ includes.
9313         * cli/cli-cmds.c: Fix common/ includes.
9314         * charset.c: Fix common/ includes.
9315         * build-id.c: Fix common/ includes.
9316         * btrace.h: Fix common/ includes.
9317         * btrace.c: Fix common/ includes.
9318         * breakpoint.h: Fix common/ includes.
9319         * breakpoint.c: Fix common/ includes.
9320         * ax.h:
9321         (enum agent_op): Fix common/ includes.
9322         * ax-general.c (struct aop_map): Fix common/ includes.
9323         * ax-gdb.c: Fix common/ includes.
9324         * auxv.c: Fix common/ includes.
9325         * auto-load.c: Fix common/ includes.
9326         * arm-tdep.c: Fix common/ includes.
9327         * arch/riscv.c: Fix common/ includes.
9328         * arch/ppc-linux-common.c: Fix common/ includes.
9329         * arch/i386.c: Fix common/ includes.
9330         * arch/arm.c: Fix common/ includes.
9331         * arch/arm-linux.c: Fix common/ includes.
9332         * arch/arm-get-next-pcs.c: Fix common/ includes.
9333         * arch/amd64.c: Fix common/ includes.
9334         * arch/aarch64.c: Fix common/ includes.
9335         * arch/aarch64-insn.c: Fix common/ includes.
9336         * arch-utils.c: Fix common/ includes.
9337         * amd64-windows-tdep.c: Fix common/ includes.
9338         * amd64-tdep.c: Fix common/ includes.
9339         * amd64-sol2-tdep.c: Fix common/ includes.
9340         * amd64-obsd-tdep.c: Fix common/ includes.
9341         * amd64-nbsd-tdep.c: Fix common/ includes.
9342         * amd64-linux-tdep.c: Fix common/ includes.
9343         * amd64-linux-nat.c: Fix common/ includes.
9344         * amd64-fbsd-tdep.c: Fix common/ includes.
9345         * amd64-fbsd-nat.c: Fix common/ includes.
9346         * amd64-dicos-tdep.c: Fix common/ includes.
9347         * amd64-darwin-tdep.c: Fix common/ includes.
9348         * agent.c: Fix common/ includes.
9349         * ada-lang.h: Fix common/ includes.
9350         * ada-lang.c: Fix common/ includes.
9351         * aarch64-tdep.c: Fix common/ includes.
9352
9353 2019-01-25  Tom Tromey  <tom@tromey.com>
9354
9355         * common/create-version.sh: Use common/version.h.
9356
9357 2019-01-24  Pedro Alves  <palves@redhat.com>
9358
9359         * infrun.c (signal_stop, signal_print, signal_program)
9360         (signal_catch, signal_pass): Now arrays instead of pointers.
9361         (update_signals_program_target, do_target_resume)
9362         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9363         * linux-nat.c (linux_nat_target::pass_signals)
9364         (linux_nat_target::create_inferior, linux_nat_target::attach):
9365         Adjust.
9366         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9367         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9368         * procfs.c (procfs_target::pass_signals): Adjust.
9369         * record-full.c (record_full_target::resume): Adjust.
9370         * remote.c (remote_target::pass_signals)
9371         (remote_target::program_signals): Adjust.
9372         * target-debug.h (target_debug_print_signals): Now takes a
9373         gdb::array_view as parameter.  Adjust.
9374         * target.h (target_ops) <pass_signals, program_signals>: Replace
9375         pointer and length parameters with gdb::array_view.
9376         (target_pass_signals, target_program_signals): Likewise.
9377         * target-delegates.c: Regenerate.
9378
9379 2019-01-24  Pedro Alves  <palves@redhat.com>
9380
9381         * common/forward-scope-exit.h
9382         (forward_scope_exit::forward_scope_exit): Pass arguments to
9383         m_bind_function directly, instead of creating a std::bind and
9384         copying that.
9385
9386 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9387
9388         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9389         for static members.
9390         (pass_in_v_vfp_candidate): Likewise.
9391
9392 2019-01-23  Tom Tromey  <tom@tromey.com>
9393             Pedro Alves  <palves@redhat.com>
9394
9395         * regcache.c (class regcache_invalidator): Remove.
9396         (regcache::raw_write): Use make_scope_exit.
9397
9398 2019-01-23  Tom Tromey  <tom@tromey.com>
9399
9400         * ui-out.h (class ui_out_emit_type): Update comment.
9401
9402 2019-01-23  Tom Tromey  <tom@tromey.com>
9403
9404         * infrun.c (fetch_inferior_event): Update comment.
9405
9406 2019-01-23  Tom Tromey  <tom@tromey.com>
9407             Pedro Alves  <palves@redhat.com>
9408
9409         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9410         parameter.
9411         (fetch_inferior_event): Use SCOPE_EXIT.
9412
9413
9414 2019-01-23  Tom Tromey  <tom@tromey.com>
9415             Pedro Alves  <palves@redhat.com>
9416
9417         * infrun.c (disable_thread_events): Delete.
9418         (stop_all_threads): Use SCOPE_EXIT.
9419
9420 2019-01-23  Tom Tromey  <tom@tromey.com>
9421             Pedro Alves  <palves@redhat.com>
9422
9423         * symfile.c: Include forward-scope-exit.h.
9424         (clear_symtab_users_cleanup): Replace forward declaration with
9425         a FORWARD_SCOPE_EXIT.
9426         (syms_from_objfile_1): Use the forward_scope_exit and
9427         gdb::optional instead of cleanup_function.
9428         (reread_symbols): Use the forward_scope_exit instead of
9429         cleanup_function.
9430         (clear_symtab_users_cleanup): Remove function.
9431
9432 2019-01-23  Tom Tromey  <tom@tromey.com>
9433             Pedro Alves  <palves@redhat.com>
9434
9435         * linux-nat.c: Include scope-exit.h.
9436         (cleanup_target_stop): Remove.
9437         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9438         SCOPE_EXIT.
9439
9440 2019-01-23  Tom Tromey  <tom@tromey.com>
9441             Pedro Alves  <palves@redhat.com>
9442
9443         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9444         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9445
9446 2019-01-23  Tom Tromey  <tom@tromey.com>
9447             Andrew Burgess  <andrew.burgess@embecosm.com>
9448             Pedro Alves  <palves@redhat.com>
9449
9450         * infrun.c (fetch_inferior_event): Use scope_exit.
9451         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9452         * top.c (execute_command): Use scope_exit.
9453         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9454         * utils.c (do_bpstat_clear_actions_cleanup)
9455         (make_bpstat_clear_actions_cleanup): Remove.
9456
9457 2019-01-23  Tom Tromey  <tom@tromey.com>
9458             Pedro Alves  <palves@redhat.com>
9459
9460         * infrun.c: Include "common/scope-exit.h"
9461         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9462         (wait_for_inferior): Use SCOPE_EXIT.
9463         (fetch_inferior_event): Use scope_exit.
9464
9465 2019-01-23  Tom Tromey  <tom@tromey.com>
9466             Pedro Alves  <palves@redhat.com>
9467
9468         * breakpoint.c (create_breakpoint): Remove cleanup.
9469
9470 2019-01-23  Tom Tromey  <tom@tromey.com>
9471             Andrew Burgess  <andrew.burgess@embecosm.com>
9472             Pedro Alves  <palves@redhat.com>
9473
9474 2019-01-23  Pedro Alves  <palves@redhat.com>
9475
9476         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9477
9478 2019-01-23  Pedro Alves  <palves@redhat.com>
9479             Andrew Burgess  <andrew.burgess@embecosm.com>
9480
9481         * gdbthread.h: Include "common/forward-scope-exit.h".
9482         (scoped_finish_thread_state): Redefine custom class in terms of
9483         forward_scope_exit.
9484
9485 2019-01-23  Pedro Alves  <palves@redhat.com>
9486             Andrew Burgess  <andrew.burgess@embecosm.com>
9487
9488         * common/forward-scope-exit.h: New file.
9489
9490 2019-01-23  Pedro Alves  <palves@redhat.com>
9491             Andrew Burgess  <andrew.burgess@embecosm.com>
9492             Tom Tromey  <tom@tromey.com>
9493
9494         * common/scope-exit.h: New file.
9495
9496 2019-01-23  Pedro Alves  <palves@redhat.com>
9497
9498         * common/preprocessor.h (ESC): Rename to ...
9499         (ESC_PARENS): ... this.
9500         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9501         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9502
9503 2019-01-23  Tom Tromey  <tom@tromey.com>
9504
9505         * language.h (class scoped_switch_to_sym_language_if_auto):
9506         Initialize m_lang in both cases.
9507
9508 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9509
9510         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9511         with XCNEW.
9512
9513 2019-01-22  Tom Tromey  <tom@tromey.com>
9514
9515         * corelow.c: Do not include sys/file.h.
9516
9517 2019-01-22  Tom Tromey  <tom@tromey.com>
9518
9519         * tui/tui-wingeneral.h: Include gdb_curses.h.
9520
9521 2019-01-22  Tom Tromey  <tom@tromey.com>
9522
9523         * source-cache.h (class source_cache) <get_source_lines,
9524         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9525
9526 2019-01-22  Tom Tromey  <tom@tromey.com>
9527
9528         * remote-fileio.h (struct remote_target): Declare.
9529
9530 2019-01-22  Tom Tromey  <tom@tromey.com>
9531
9532         * python/py-arch.c: Do not include py-ref.h.
9533         * python/py-bpevent.c: Do not include py-ref.h.
9534         * python/py-cmd.c: Do not include py-ref.h.
9535         * python/py-continueevent.c: Do not include py-ref.h.
9536         * python/py-event.h: Do not include py-ref.h.
9537         * python/py-evtregistry.c: Do not include py-ref.h.
9538         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9539         * python/py-frame.c: Do not include py-ref.h.
9540         * python/py-framefilter.c: Do not include py-ref.h.
9541         * python/py-function.c: Do not include py-ref.h.
9542         * python/py-infevents.c: Do not include py-ref.h.
9543         * python/py-linetable.c: Do not include py-ref.h.
9544         * python/py-objfile.c: Do not include py-ref.h.
9545         * python/py-param.c: Do not include py-ref.h.
9546         * python/py-prettyprint.c: Do not include py-ref.h.
9547         * python/py-progspace.c: Do not include py-ref.h.
9548         * python/py-symbol.c: Do not include py-ref.h.
9549         * python/py-symtab.c: Do not include py-ref.h.
9550         * python/py-type.c: Do not include py-ref.h.
9551         * python/py-unwind.c: Do not include py-ref.h.
9552         * python/py-utils.c: Do not include py-ref.h.
9553         * python/py-value.c: Do not include py-ref.h.
9554         * python/py-varobj.c: Do not include py-ref.h.
9555         * python/py-xmethods.c: Do not include py-ref.h.
9556         * python/python.c: Do not include py-ref.h.
9557         * varobj.c: Do not include py-ref.h.
9558
9559 2019-01-22  Tom Tromey  <tom@tromey.com>
9560
9561         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9562         keyword for bcache.
9563
9564 2019-01-22  Tom Tromey  <tom@tromey.com>
9565
9566         * compile/compile-cplus-types.c: Remove a comment by #include.
9567
9568 2019-01-22  Tom Tromey  <tom@tromey.com>
9569
9570         * compile/gcc-c-plugin.h: Include compile-internal.h.
9571
9572 2019-01-22  Tom Tromey  <tom@tromey.com>
9573
9574         * stabsread.c (EXTERN): Do not define.
9575         (symnum, next_symbol_text_func, processing_gcc_compilation)
9576         (within_function, global_sym_chain, global_stabs)
9577         (previous_stab_code, this_object_header_files)
9578         (n_this_object_header_files)
9579         (n_allocated_this_object_header_files): Define.
9580         * stabsread.h (EXTERN): Never define.  Use "extern".
9581
9582 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9583
9584         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9585         history_value.
9586
9587 2019-01-21  Tom Tromey  <tom@tromey.com>
9588
9589         * ui-out.c: Fix includes.
9590         * tui/tui-source.c: Fix includes.
9591         * target.c: Fix includes.
9592         * remote.c: Fix includes.
9593         * regcache.c: Fix includes.
9594         * python/py-block.c: Fix includes.
9595         * printcmd.c: Fix includes.
9596         * or1k-tdep.c: Fix includes.
9597         * mi/mi-main.c: Fix includes.
9598         * m32r-tdep.c: Fix includes.
9599         * csky-tdep.c: Fix includes.
9600         * compile/compile-cplus-types.c: Fix includes.
9601         * cli/cli-interp.c: Fix includes.
9602
9603 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9604
9605         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9606         for padding.
9607
9608 2019-01-16  Tom Tromey  <tom@tromey.com>
9609
9610         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9611         earlier.
9612         (struct objfile) <msymbols_range>: Move from top level.
9613         <msymbols>: New method.
9614         (class objfile_msymbols): Remove.
9615         * symtab.c (default_collect_symbol_completion_matches_break_on):
9616         Update.
9617         * symmisc.c (dump_msymbols): Update.
9618         * stabsread.c (scan_file_globals): Update.
9619         * objc-lang.c (info_selectors_command, info_classes_command)
9620         (find_methods): Update.
9621         * minsyms.c (find_solib_trampoline_target): Update.
9622         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9623         * coffread.c (coff_symfile_read): Update.
9624         * ada-lang.c (ada_lookup_simple_minsym)
9625         (ada_collect_symbol_completion_matches): Update.
9626
9627 2019-01-16  Tom Tromey  <tom@tromey.com>
9628
9629         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9630         type.  Remove no-argument constructor.
9631         <iterator::operator++>: Simplify.
9632         <begin>: Update.
9633         <end>: Use minimal_symbol_count.
9634
9635 2019-01-16  Tom Tromey  <tom@tromey.com>
9636
9637         * objfiles.h (struct objfile) <psymtabs>: New method.
9638         (class objfile_psymtabs): Remove.
9639         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9640         typedef.
9641         <range>: New method.
9642         (require_partial_symbols): Change return type.
9643         * psymtab.c (require_partial_symbols)
9644         (psym_expand_symtabs_matching): Update.
9645         * mdebugread.c (parse_partial_symbols): Update.
9646         * dbxread.c (dbx_end_psymtab): Update.
9647
9648 2019-01-15  Tom Tromey  <tom@tromey.com>
9649
9650         * symtab.c (lookup_objfile_from_block)
9651         (lookup_symbol_in_objfile_symtabs)
9652         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9653         (find_line_symtab, info_sources_command)
9654         (default_collect_symbol_completion_matches_break_on)
9655         (make_source_files_completion_list): Update.
9656         * symmisc.c (print_objfile_statistics, dump_objfile)
9657         (maintenance_print_symbols, maintenance_info_symtabs)
9658         (maintenance_check_symtabs, maintenance_info_line_tables):
9659         Update.
9660         * source.c (select_source_symtab)
9661         (forget_cached_source_info_for_objfile): Update.
9662         * objfiles.h (class objfile_compunits): Remove.
9663         (struct objfile) <compunits_range>: New typedef.
9664         (compunits): New method.
9665         * objfiles.c (objfile_relocate1): Update.
9666         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9667         * maint.c (count_symtabs_and_blocks): Update.
9668         * linespec.c (iterate_over_all_matching_symtabs): Update.
9669         * cp-support.c (add_symbol_overload_list_qualified): Update.
9670         * coffread.c (coff_symtab_read): Update.
9671         * ada-lang.c (add_nonlocal_symbols)
9672         (ada_collect_symbol_completion_matches)
9673         (ada_add_global_exceptions): Update.
9674
9675 2019-01-15  Tom Tromey  <tom@tromey.com>
9676
9677         * progspace.h (program_space) <objfiles_safe_range>: New
9678         typedef.
9679         <objfiles_safe>: New method.
9680         * objfiles.h (class all_objfiles_safe): Remove.
9681         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9682         * jit.c (jit_inferior_exit_hook): Update.
9683
9684 2019-01-17  Tom Tromey  <tom@tromey.com>
9685
9686         * progspace.h (program_space) <objfiles_range>: New typedef.
9687         <objfiles>: New method.
9688         <objfiles_head>: Rename from objfiles.
9689         (object_files): Update.
9690         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9691         * guile/scm-pretty-print.c
9692         (ppscm_find_pretty_printer_from_objfiles): Update.
9693         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9694         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9695         Update.
9696         * python/py-progspace.c (pspy_get_objfiles): Update.
9697         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9698         Update.
9699         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9700         (objfpy_lookup_objfile_by_build_id): Update.
9701         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9702         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9703         Update.
9704         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9705         (expand_symtab_containing_pc, lookup_objfile_from_block)
9706         (lookup_static_symbol, basic_lookup_transparent_type)
9707         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9708         (find_line_symtab, info_sources_command)
9709         (default_collect_symbol_completion_matches_break_on)
9710         (make_source_files_completion_list, find_main_name): Update.
9711         * symmisc.c (print_symbol_bcache_statistics)
9712         (print_objfile_statistics, maintenance_print_symbols)
9713         (maintenance_print_msymbols, maintenance_print_objfiles)
9714         (maintenance_info_symtabs, maintenance_check_symtabs)
9715         (maintenance_expand_symtabs, maintenance_info_line_tables):
9716         Update.
9717         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9718         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9719         (map_overlay_command, unmap_overlay_command)
9720         (simple_overlay_update, expand_symtabs_matching)
9721         (map_symbol_filenames): Update.
9722         * symfile-debug.c (set_debug_symfile): Update.
9723         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9724         Update.
9725         * source.c (select_source_symtab, forget_cached_source_info):
9726         Update.
9727         * solib.c (solib_read_symbols): Update.
9728         * solib-spu.c (append_ocl_sos): Update.
9729         * psymtab.c (maintenance_print_psymbols)
9730         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9731         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9732         * printcmd.c (info_symbol_command): Update.
9733         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9734         Update.
9735         * objfiles.h (class all_objfiles): Remove.
9736         * objfiles.c (have_partial_symbols, have_full_symbols)
9737         (have_minimal_symbols, qsort_cmp, update_section_map)
9738         (shared_objfile_contains_address_p)
9739         (default_iterate_over_objfiles_in_search_order): Update.
9740         * objc-lang.c (info_selectors_command, info_classes_command)
9741         (find_methods): Update.
9742         * minsyms.c (find_solib_trampoline_target): Update.
9743         * maint.c (maintenance_info_sections)
9744         (maintenance_translate_address, count_symtabs_and_blocks):
9745         Update.
9746         * main.c (captured_main_1): Update.
9747         * linux-thread-db.c (try_thread_db_load_from_pdir)
9748         (has_libpthread): Update.
9749         * linespec.c (iterate_over_all_matching_symtabs)
9750         (search_minsyms_for_name): Update.
9751         * jit.c (jit_find_objf_with_entry_addr): Update.
9752         * hppa-tdep.c (find_unwind_entry)
9753         (hppa_lookup_stub_minimal_symbol): Update.
9754         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9755         Update.
9756         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9757         (elf_gnu_ifunc_resolve_by_got): Update.
9758         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9759         * dwarf-index-write.c (save_gdb_index_command): Update.
9760         * cp-support.c (add_symbol_overload_list_qualified): Update.
9761         * breakpoint.c (create_overlay_event_breakpoint)
9762         (create_longjmp_master_breakpoint)
9763         (create_std_terminate_master_breakpoint)
9764         (create_exception_master_breakpoint): Update.
9765         * blockframe.c (find_pc_partial_function): Update.
9766         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9767         (ada_collect_symbol_completion_matches)
9768         (ada_add_global_exceptions): Update.
9769
9770 2019-01-17  Tom Tromey  <tom@tromey.com>
9771
9772         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9773         declare VEC.
9774         (solib_target_parse_libraries): Change return type.
9775         (library_list_start_segment, library_list_start_section)
9776         (library_list_end_library, library_list_start_library); Update.
9777         (solib_target_free_library_list): Remove.
9778         (solib_target_parse_libraries): Remove cleanup.  Change return
9779         type.
9780         (solib_target_current_sos): Update.
9781
9782 2019-01-17  Tom Tromey  <tromey@bapiya>
9783
9784         * valprint.c: Replace "the the" with "the".
9785         * symtab.c: Replace "the the" with "the".
9786         * solib.c: Replace "the the" with "the".
9787         * solib-dsbt.c: Replace "the the" with "the".
9788         * linespec.c: Replace "the the" with "the".
9789         * dwarf2loc.h: Replace "the the" with "the".
9790         * amd64-windows-tdep.c: Replace "the the" with "the".
9791         * aarch64-tdep.c: Replace "the the" with "the".
9792
9793 2019-01-16  Keith Seitz  <keiths@redhat.com>
9794
9795         PR gdb/23773
9796         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9797         <builder>: Rename to ..
9798         <m_builder>: ... this and make private.
9799         (dwarf2_cu::get_builder): New method.  Change all users of
9800         `builder' to use this method.
9801         (dwarf2_start_symtab): Move to ...
9802         (dwarf2_cu::start_symtab): ... here.  Update all callers
9803         (setup_type_unit_groups): Move to ...
9804         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9805         callers.
9806         (dwarf2_cu::reset_builder): New method.
9807         (process_full_compunit, process_full_type_unit): Use
9808         dwarf2_cu::reset_builder.
9809         (follow_die_offset): Record the ancestor CU if it is different
9810         from the followed DIE's CU.
9811         (follow_die_sig_1): Likewise.
9812
9813 2019-01-15  Tom Tromey  <tom@tromey.com>
9814
9815         * remote.c (class remote_state) <buf>: Now a char_vector.
9816         <buf_size>: Remove.
9817         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9818         parameter.
9819         (remote_target::getpkt_or_notif_sane_1)
9820         (remote_target::getpkt_sane)
9821         (remote_target::getpkt_or_notif_sane): Likewise.
9822         (class remote_target) <putpkt>: New overload.
9823         (remote_target::read_frame): Change type of "buf_p".  Remove
9824         sizeof_p parameter.
9825         (packet_ok): New overload.
9826         (packet_check_result): New overload.
9827         Update all uses.
9828
9829 2019-01-14  Tom Tromey  <tom@tromey.com>
9830
9831         * remote-notif.c (handle_notification, remote_notif_ack)
9832         (remote_notif_parse): Make "buf" const.
9833         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9834         const.
9835         (remote_notif_parse, remote_notif_ack, handle_notification):
9836         Likewise.
9837         * remote.c (remote_notif_stop_parse): Make "buf" const.
9838         (remote_target::remote_parse_stop_reply): Make "buf" const.
9839         (remote_notif_stop_ack): Make "buf" const.
9840
9841 2019-01-14  Tom Tromey  <tom@tromey.com>
9842
9843         * remote.c (remote_console_output): Make parameter const.
9844
9845 2019-01-14  Tom Tromey  <tom@tromey.com>
9846
9847         * target-debug.h (target_debug_print_signals): Constify.
9848         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9849         * procfs.c (procfs_target::pass_signals): Update.
9850         * linux-nat.c (linux_nat_target::pass_signals): Update.
9851         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9852         * target-delegates.c: Rebuild.
9853         * remote.c (remote_target::program_signals): Update.
9854         (remote_target::pass_signals): Update.
9855         * target.c (target_pass_signals): Constify argument.
9856         (target_program_signals): Likewise.
9857         * target.h (struct target_ops) <pass_signals, program_signals>:
9858         Constify argument.
9859         (target_pass_signals, target_program_signals): Constify argument.
9860
9861 2019-01-14  Tom Tromey  <tom@tromey.com>
9862
9863         PR tui/28819:
9864         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9865
9866 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9867
9868         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9869         field.
9870         * rs6000-tdep.c: Include reggroups.h.
9871         (IS_V_ALIAS_PSEUDOREG): Define.
9872         (rs6000_register_name): Return names for the "vX" aliases.
9873         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9874         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9875         aliases.  Call default_register_reggroup_p for all other
9876         pseudo-registers.
9877         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9878         New functions.
9879         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9880         Handle "vX" aliases.
9881         (v_alias_pseudo_register_collect): New function.
9882         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9883         (rs6000_gdbarch_init): Initialize "vX" aliases as
9884         pseudo-registers.  Restore registration of
9885         rs6000_pseudo_register_reggroup_p with
9886         set_tdesc_pseudo_register_reggroup_p.
9887
9888 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9889
9890         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9891         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9892         set_gdbarch_num_pseudo_regs.
9893
9894 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9895
9896         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9897         Remove arg prefixname, add do_set and do_show.
9898         Add member functions set_list and show_list.
9899         * cli/cli-style.c (class cli_style_option): Update accordingly.
9900         (style_set_list): Move to file scope.
9901         (style_show_list): Likewise.
9902         (set_style): Call help_list.
9903         (show_style): Call cmd_show_list.
9904         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9905         Update to use the new macro.
9906
9907 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9908
9909         * ada-lang.c (_initialize_ada_language): Expand the help text
9910         for the "catch exception" command.
9911
9912 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9913
9914         * symtab.c (matching_obj_sections): Initialize obj,
9915         declare it closer to its usage.
9916
9917 2019-01-10  Tom Tromey  <tom@tromey.com>
9918
9919         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9920         (basic_inf_threads_range): Remove.
9921         (inf_threads_range, inf_non_exited_threads_range)
9922         (safe_inf_threads_range): Use next_adapter.
9923
9924 2019-01-10  Keith Seitz  <keiths@redhat.com>
9925
9926         PR gdb/23712
9927         PR symtab/23010
9928         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9929         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9930
9931 2019-01-10  Keith Seitz  <keiths@redhat.com>
9932
9933         PR gdb/23712
9934         PR symtab/23010
9935         * dictionary.c (pending_to_vector): Remove.
9936         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9937         Remove _1 suffix, replacing functions of the same name.  Update
9938         all callers.
9939         (dict_create_hashed, dict_create_hashed_expandable)
9940         (dict_create_linear, dict_create_linear_expandable, dict_free)
9941         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9942         Make functions static.
9943
9944 2019-01-10  Keith Seitz  <keiths@redhat.com>
9945
9946         PR gdb/23712
9947         PR symtab/23010
9948         * dictionary.h (struct dictionary): Replace declaration with
9949         multidictionary.
9950         (dict_create_hashed, dict_create_hashed_expandable)
9951         (dict_create_linear, dict_create_linear_expandable)
9952         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9953         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9954         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9955         taking multidictionary argument.
9956         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9957         * block.h (struct block) <dict>: Change to multidictionary
9958         and rename `multidict'.
9959         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9960         symmisc.c: Update all dictionary references to multidictionary.
9961
9962 2019-01-10  Keith Seitz  <keiths@redhat.com>
9963
9964         PR gdb/23712
9965         PR symtab/23010
9966         * dictionary.c: Include unordered_map.
9967         (pending_to_vector): New function.
9968         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9969         Rewrite the non-"_1" functions to take vector instead
9970         of linked list.
9971         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9972         "new" _1 versions of the same name.
9973         (multidictionary): Define.
9974         (std::hash<enum language): New definition.
9975         (collate_pending_symbols_by_language, mdict_create_hashed)
9976         (mdict_create_hashed_expandable, mdict_create_linear)
9977         (mdict_create_linear_expandable, mdict_free)
9978         (find_language_dictionary, create_new_language_dictionary)
9979         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9980         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9981         (mdict_size, mdict_empty): New functions.
9982         * dictionary.h (mdict_iterator): Define.
9983
9984 2019-01-10  Pedro Alves  <palves@redhat.com>
9985
9986         * breakpoint.c (read_uploaded_action)
9987         (create_tracepoint_from_upload): Adjust to use
9988         gdb::unique_xmalloc_ptr.
9989         * ctf.c (ctf_write_uploaded_tp):
9990         (SET_ARRAY_FIELD): Use emplace_back.
9991         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9992         * tracefile-tfile.c (tfile_write_uploaded_tp):
9993         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9994         gdb::unique_xmalloc_ptr.
9995         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9996         at_string, cond_string, cmd_strings>: Replace char pointers
9997         with gdb::unique_xmalloc_ptr.
9998
9999 2019-01-10  Pedro Alves  <palves@redhat.com>
10000
10001         * solib-target.c (library_list_start_library): Don't xstrdup name.
10002
10003 2019-01-10  Pedro Alves  <palves@redhat.com>
10004
10005         * mdebugread.c (parse_partial_symbols): Use
10006         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10007
10008 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10009
10010         * linux-fork.c (scoped_switch_fork_info)
10011         <~scoped_switch_fork_info>: Fix incorrect variable name.
10012
10013 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10014
10015         * linux-fork.c (scoped_switch_fork_info)
10016         <scoped_switch_fork_info>: Make explicit.
10017         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10018
10019 2019-01-10  Tom Tromey  <tom@tromey.com>
10020
10021         * objfiles.h (objfile::reset_psymtabs): Update.
10022         * objfiles.c (objfile::objfile): Update.
10023         * psymtab.h (psymtab_storage::obstack): Update.
10024         (psymtab_storage::m_obstack): Use gdb::optional.
10025         (class psymtab_storage): Update comment.  Remove objfile
10026         parameter.
10027         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10028
10029 2019-01-10  Tom Tromey  <tom@tromey.com>
10030
10031         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10032         <free_psymtabs>: Now private.
10033         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10034         (allocate_psymtab): Use new method.
10035
10036 2019-01-10  Tom Tromey  <tom@tromey.com>
10037
10038         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10039         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10040         * mdebugread.c (parse_partial_symbols): Use
10041         allocate_dependencies.
10042         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10043         allocate_dependencies.
10044         (process_psymtab_comp_unit_reader)
10045         (build_type_psymtab_dependencies): Likewise.
10046         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10047
10048 2019-01-10  Tom Tromey  <tom@tromey.com>
10049
10050         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10051         PSYMBOL_SET_LANGUAGE.
10052         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10053
10054 2019-01-10  Tom Tromey  <tom@tromey.com>
10055
10056         * psymtab.h (psymtab_storage::obstack): New method.
10057         <m_obstack>: Rename from obstack; now private.
10058         * psymtab.c (psymtab_storage): Update.
10059         * dwarf2read.c (create_addrmap_from_index)
10060         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10061         Update.
10062
10063 2019-01-10  Tom Tromey  <tom@tromey.com>
10064
10065         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10066         * objfiles.h (objfile::reset_psymtabs): New method.
10067
10068 2019-01-10  Tom Tromey  <tom@tromey.com>
10069
10070         * symmisc.c (print_symbol_bcache_statistics): Update.
10071         (print_objfile_statistics): Update.
10072         * symfile.c (reread_symbols): Update.
10073         * psymtab.h (class psymtab_storage): New.
10074         * psymtab.c (psymtab_storage): New constructor.
10075         (~psymtab_storage): New destructor.
10076         (require_partial_symbols): Update.
10077         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10078         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10079         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10080         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10081         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10082         (start_psymtab_common, end_psymtab_common)
10083         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10084         (allocate_psymtab): Update.
10085         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10086         Update.
10087         (dump_psymtab_addrmap, maintenance_print_psymbols)
10088         (maintenance_check_psymtabs): Update.
10089         (class objfile_psymtabs): Move to objfiles.h.
10090         * psympriv.h (discard_psymtab): Now inline.
10091         (psymtab_discarder::psymtab_discarder): Update.
10092         (psymtab_discarder::~psymtab_discarder): Update.
10093         (ALL_OBJFILE_PSYMTABS): Rewrite.
10094         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10095         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10096         Remove fields.
10097         <partial_symtabs>: New field.
10098         (class objfile_psymtabs): Move from psymtab.h.  Update.
10099         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10100         psymbol_cache.
10101         (objfile::~objfile): Don't destroy psymbol_cache.
10102         * mdebugread.c (parse_partial_symbols): Update.
10103         * dwarf2read.c (create_addrmap_from_index)
10104         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10105         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10106         (add_partial_subprogram, dwarf2_ranges_read): Update.
10107         * dwarf-index-write.c (write_address_map)
10108         (write_one_signatured_type, recursively_write_psymbols)
10109         (class debug_names, class debug_names, write_psymtabs_to_index):
10110         Update.
10111
10112 2019-01-10  Tom Tromey  <tom@tromey.com>
10113
10114         * symtab.h (SYMBOL_SET_NAMES): Update.
10115         (symbol_set_names): Update.
10116         (MSYMBOL_SET_NAMES): Update.
10117         * symtab.c (symbol_set_names): Change argument to be an
10118         objfile_per_bfd_storage.
10119         * psymtab.c (add_psymbol_to_bcache): Update.
10120         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10121
10122 2019-01-10  Tom Tromey  <tom@tromey.com>
10123
10124         * symtab.c (create_demangled_names_hash): Change argument to be an
10125         objfile_per_bfd_storage.
10126         (symbol_set_names): Update.
10127
10128 2019-01-10  Tom Tromey  <tom@tromey.com>
10129
10130         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10131         init_psymbol_list.
10132         * psymtab.c (init_psymbol_list): Do nothing if already called.
10133         * psympriv.h (init_psymbol_list): Add comment.
10134         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10135         init_psymbol_list.
10136         * dbxread.c (dbx_symfile_read): Unconditionally call
10137         init_psymbol_list.
10138
10139 2019-01-10  Tom Tromey  <tom@tromey.com>
10140
10141         * xcoffread.c (scan_xcoff_symtab): Update.
10142         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10143         "where".
10144         * mdebugread.c (parse_partial_symbols)
10145         (handle_psymbol_enumerators): Update.
10146         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10147         * dbxread.c (read_dbx_symtab): Update.
10148         * psympriv.h (psymbol_placement): New enum.
10149         (add_psymbol_to_list): Update.
10150
10151 2019-01-10  Tom Tromey  <tom@tromey.com>
10152
10153         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10154         static_psymbols parameters.
10155         (scan_xcoff_symtab): Update.
10156         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10157         static_psymbols parameters.
10158         * psympriv.h (start_psymtab_common): Update.
10159         * mdebugread.c (parse_partial_symbols): Update.
10160         * dwarf2read.c (create_partial_symtab): Update.
10161         * dbxread.c (read_dbx_symtab): Update.
10162         (start_psymtab): Remove global_psymbols and static_psymbols
10163         parameters.
10164
10165 2019-01-10  Tom Tromey  <tom@tromey.com>
10166
10167         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10168         * psymtab.c (allocate_psymtab): Add comment.
10169         * psympriv.h (allocate_psymtab): Add comment.
10170         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10171         initializations.
10172         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10173
10174 2019-01-10  Tom Tromey  <tom@tromey.com>
10175
10176         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10177         Don't declare.
10178         * mipsread.c: Include mdebugread.h.
10179         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10180         Declare.
10181         * elfread.c: Include mdebugread.h.
10182
10183 2019-01-09  Tom Tromey  <tom@tromey.com>
10184
10185         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10186         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10187         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10188         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10189         (psym_lookup_symbol, psym_find_last_source_symtab)
10190         (psym_forget_cached_source_info, psym_print_stats)
10191         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10192         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10193         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10194         (psym_find_compunit_symtab_by_address)
10195         (maintenance_print_psymbols, maintenance_info_psymtabs)
10196         (maintenance_check_psymtabs): Use ranged for.
10197         * psymtab.h (class objfile_psymtabs): New.
10198         (require_partial_symbols): Return objfile_psymtabs.
10199         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10200
10201 2019-01-09  Tom Tromey  <tom@tromey.com>
10202
10203         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10204         (find_pc_mapped_section, list_overlays_command)
10205         (map_overlay_command, unmap_overlay_command)
10206         (simple_overlay_update): Use all_objfiles.
10207         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10208         * printcmd.c (info_symbol_command): Use all_objfiles.
10209         * objfiles.h (ALL_OBJSECTIONS): Remove.
10210         * maint.c (maintenance_translate_address): Use all_objfiles.
10211         * gcore.c (gcore_create_callback): Use all_objfiles.
10212         (objfile_find_memory_regions): Likewise.
10213
10214 2019-01-09  Tom Tromey  <tom@tromey.com>
10215
10216         * symtab.c (find_line_symtab, info_sources_command)
10217         (make_source_files_completion_list): Use objfile_compunits.
10218         * source.c (select_source_symtab): Use objfile_compunits.
10219         * objfiles.h (struct objfile): Update comment.
10220         (ALL_OBJFILES): Remove.
10221         (ALL_FILETABS): Remove.
10222         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10223         objfile_compunits.
10224
10225 2019-01-09  Tom Tromey  <tom@tromey.com>
10226
10227         * symmisc.c (print_objfile_statistics, dump_objfile)
10228         (maintenance_print_symbols): Use compunit_filetabs.
10229         * source.c (forget_cached_source_info_for_objfile): Use
10230         compunit_filetabs.
10231         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10232         (ALL_FILETABS): Use compunit_filetabs.
10233         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10234         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10235
10236 2019-01-09  Tom Tromey  <tom@tromey.com>
10237
10238         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10239         (compunit_filetabs): New.
10240         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10241         compunit_filetabs.
10242         (info_sources_command, make_source_files_completion_list): Remove
10243         declaration.
10244         * symmisc.c (print_objfile_statistics, dump_objfile)
10245         (maintenance_print_symbols): Remove declaration.
10246         (maintenance_info_symtabs): Use compunit_filetabs.
10247         (maintenance_info_line_tables): Likewise.
10248         * source.c (select_source_symtab): Change local variable name.
10249         (forget_cached_source_info_for_objfile): Remove declaration.
10250         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10251         * objfiles.c (objfile_relocate1): Remove declaration.
10252         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10253         declaration.
10254         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10255         * coffread.c (coff_symtab_read): Remove declaration.
10256         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10257         compunit_filetabs.
10258
10259 2019-01-09  Tom Tromey  <tom@tromey.com>
10260
10261         * symtab.c (lookup_objfile_from_block)
10262         (find_pc_sect_compunit_symtab, search_symbols)
10263         (default_collect_symbol_completion_matches_break_on): Use
10264         objfile_compunits.
10265         * objfiles.h (ALL_COMPUNITS): Remove.
10266         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10267         * cp-support.c (add_symbol_overload_list_qualified): Use
10268         objfile_compunits.
10269         * ada-lang.c (ada_collect_symbol_completion_matches)
10270         (ada_add_global_exceptions): Use objfile_compunits.
10271
10272 2019-01-09  Tom Tromey  <tom@tromey.com>
10273
10274         * source.c (select_source_symtab)
10275         (forget_cached_source_info_for_objfile): Remove declaration.
10276         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10277         declaration.
10278         * maint.c (count_symtabs_and_blocks): Remove declaration.
10279         * cp-support.c (add_symbol_overload_list_qualified): Remove
10280         declaration.
10281         * coffread.c (coff_symtab_read): Remove declaration.
10282         * symtab.c (lookup_symbol_in_objfile_symtabs)
10283         (basic_lookup_transparent_type_1): Use objfile_compunits.
10284         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10285         (info_sources_command, search_symbols)
10286         (default_collect_symbol_completion_matches_break_on)
10287         (make_source_files_completion_list): Remove declaration.
10288         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10289         (ada_collect_symbol_completion_matches)
10290         (ada_add_global_exceptions): Remove declaration.
10291         * linespec.c (iterate_over_all_matching_symtabs): Use
10292         objfile_compunits.
10293         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10294         (class objfile_compunits): New.
10295         (ALL_COMPUNITS): Use objfile_compunits.
10296         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10297         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10298         objfile_compunits.
10299         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10300
10301 2019-01-09  Tom Tromey  <tom@tromey.com>
10302
10303         * symtab.c (search_symbols)
10304         (default_collect_symbol_completion_matches_break_on): Use
10305         objfile_msymbols.
10306         * ada-lang.c (ada_lookup_simple_minsym)
10307         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10308         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10309         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10310         objfile_msymbols.
10311         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10312         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10313         * objc-lang.c (find_methods): Use objfile_msymbols.
10314         (info_selectors_command, info_classes_command): Likewise.
10315         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10316         * objfiles.h (class objfile_msymbols): New.
10317         (ALL_OBJFILE_MSYMBOLS): Remove.
10318         (ALL_MSYMBOLS): Remove.
10319
10320 2019-01-09  Tom Tromey  <tom@tromey.com>
10321
10322         * common/next-iterator.h (next_adapter): Add Iterator template
10323         parameter.
10324         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10325         (class all_objfiles_safe): New.
10326         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10327         * objfiles.c (put_objfile_before): Update comment.
10328         (add_separate_debug_objfile): Likewise.
10329         (free_all_objfiles): Use all_objfiles_safe.
10330         (objfile_purge_solibs): Likewise.
10331
10332 2019-01-09  Tom Tromey  <tom@tromey.com>
10333
10334         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10335         (expand_symtab_containing_pc, lookup_static_symbol)
10336         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10337         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10338         all_objfiles.
10339         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10340         * breakpoint.c (create_overlay_event_breakpoint)
10341         (create_longjmp_master_breakpoint)
10342         (create_std_terminate_master_breakpoint)
10343         (create_exception_master_breakpoint): Use all_objfiles.
10344         * linux-thread-db.c (try_thread_db_load_from_pdir)
10345         (has_libpthread): Use all_objfiles.
10346         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10347         * linespec.c (iterate_over_all_matching_symtabs)
10348         (search_minsyms_for_name): Use all_objfiles.
10349         * maint.c (maintenance_info_sections): Use all_objfiles.
10350         * main.c (captured_main_1): Use all_objfiles.
10351         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10352         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10353         * guile/scm-pretty-print.c
10354         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10355         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10356         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10357         (maintenance_print_msymbols): Use all_objfiles.
10358         * source.c (select_source_symtab): Use all_objfiles.
10359         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10360         * symfile.c (remove_symbol_file_command)
10361         (expand_symtabs_matching, map_symbol_filenames): Use
10362         all_objfiles.
10363         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10364         all_objfiles.
10365         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10366         * objc-lang.c (find_methods): Use all_objfiles.
10367         * objfiles.c (have_partial_symbols, have_full_symbols)
10368         (have_minimal_symbols, qsort_cmp)
10369         (default_iterate_over_objfiles_in_search_order): Use
10370         all_objfiles.
10371         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10372         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10373         (maintenance_check_psymtabs): Use all_objfiles.
10374         (ALL_PSYMTABS): Remove.
10375         * compile/compile-object-run.c (do_module_cleanup): Use
10376         all_objfiles.
10377         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10378         * cp-support.c (add_symbol_overload_list_qualified): Use
10379         all_objfiles.
10380         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10381         Use all_objfiles.
10382         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10383         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10384         all_objfiles.
10385         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10386         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10387         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10388         Uses all_objfiles.
10389         * solib.c (solib_read_symbols): Use all_objfiles
10390
10391 2019-01-09  Tom Tromey  <tom@tromey.com>
10392
10393         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10394         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10395         all_objfiles.
10396         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10397         * symmisc.c (print_symbol_bcache_statistics)
10398         (print_objfile_statistics, maintenance_print_objfiles)
10399         (maintenance_info_symtabs, maintenance_check_symtabs)
10400         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10401         all_objfiles.
10402         * source.c (forget_cached_source_info): Use all_objfiles.
10403         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10404         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10405         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10406         * objfiles.c (update_section_map): Use all_objfiles.
10407         (shared_objfile_contains_address_p): Likewise.
10408         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10409         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10410
10411 2019-01-09  Tom Tromey  <tom@tromey.com>
10412
10413         * common/next-iterator.h: New file.
10414         * objfiles.h (class all_objfiles): New.
10415         (struct objfile_iterator): New.
10416
10417 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10418
10419         * NEWS: Move the description of the changed "frame", "select-frame",
10420          and "info frame" commands to the Changed commands section.
10421
10422 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10423
10424         * gdbtypes.c (check_stub_method_group): Remove handling of old
10425         mangling schemes.
10426         * linespec.c (find_methods): Likewise.
10427         * stabsread.c (read_member_functions): Likewise.
10428         * valops.c (search_struct_method): Likewise.
10429         (value_struct_elt_for_reference): Likewise.
10430         * NEWS: Mention this change.
10431
10432 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10433
10434         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10435         print_source_lines.
10436         * source.c (print_source_lines_base): Update line number check.
10437         (print_source_lines): New function.
10438         (source_lines_range::source_lines_range): New function.
10439         * source.h (class source_lines_range): New class.
10440         (print_source_lines): New declaration.
10441
10442 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10443
10444         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10445
10446 2019-01-08  Tom Tromey  <tom@tromey.com>
10447             Simon Marchi  <simon.marchi@ericsson.com>
10448
10449         PR gdb/24060
10450         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10451         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10452         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10453         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10454         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10455         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10456
10457 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10458
10459         * source.c (select_source_symtab): Move header comment to
10460         declaration in source.h.
10461         (forget_cached_source_info_for_objfile): Likewise.
10462         (forget_cached_source_info): Likewise.
10463         (identify_source_line): Likewise.
10464         * source.h (identify_source_line): Move declaration from symtab.h
10465         and add comment from source.c
10466         (print_source_lines): Likewise.
10467         (forget_cached_source_info_for_objfile): Likewise.
10468         (forget_cached_source_info): Likewise.
10469         (select_source_symtab): Likewise.
10470         (enum print_source_lines_flag): Move definition from symtab.h.
10471         * symtab.h (identify_source_line): Move declaration to source.h.
10472         (print_source_lines): Likewise.
10473         (forget_cached_source_info_for_objfile): Likewise.
10474         (forget_cached_source_info): Likewise.
10475         (select_source_symtab): Likewise.
10476         (enum print_source_lines_flag): Move definition to source.h.
10477         * tui/tui-hooks.c: Add 'source.h' include.
10478
10479 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10480
10481         * source.c (print_source_lines_base): Handle requests to print
10482         reverse line number sequences, and guard against empty lines
10483         string.
10484
10485 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10486
10487         * source.c (print_source_lines_base): Fix skip of '\r' if next
10488         character is '\n'.
10489
10490 2019-01-06  Tom Tromey  <tom@tromey.com>
10491
10492         * c-exp.y (struct c_parse_state) <macro_original_text,
10493         expansion_obstack>: New member.
10494         (macro_original_text, expansion_obstack): Remove globals.
10495         (scan_macro_expansion, scanning_macro_expansion)
10496         (finished_macro_expansion): Update.
10497         (scan_macro_cleanup): Remove.
10498         (yylex, c_parse): Update.
10499
10500 2019-01-06  Tom Tromey  <tom@tromey.com>
10501
10502         * c-exp.y (struct c_parse_state) <strings>: New member.
10503         (operator_stoken): Update.
10504
10505 2019-01-06  Tom Tromey  <tom@tromey.com>
10506
10507         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10508         (union type_stack_elt) <typelist_val>: Now a pointer to
10509         std::vector.
10510         (type_stack_cleanup): Don't declare.
10511         (push_typelist): Update.
10512         * parse.c (pop_typelist): Return a std::vector.
10513         (push_typelist): Take a std::vector.
10514         (follow_types): Update.  Do not free args.
10515         (type_stack_cleanup): Remove.
10516         * c-exp.y (struct c_parse_state): New.
10517         (cpstate): New global.
10518         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10519         (nonempty_typelist): Update.
10520         (func_mod): Create a new vector.
10521         (c_parse): Create a c_parse_state.
10522         (check_parameter_typelist): Do not delete params.
10523         (function_method): Update.  Do not delete type_list.
10524
10525 2019-01-06  Tom Tromey  <tom@tromey.com>
10526
10527         PR gdb/28155:
10528         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10529         check_typedef.
10530         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10531         (print_return_value): Likewise.
10532
10533 2019-01-05  Tom Tromey  <tom@tromey.com>
10534
10535         * contrib/cleanup_check.py: Remove.
10536         * contrib/gcc-with-excheck: Remove.
10537         * contrib/exsummary.py: Remove.
10538         * contrib/excheck.py: Remove.
10539
10540 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10541
10542         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10543         NULL. Initialize tpprev to NULL instead of assigning it
10544         to NULL on the next statement.
10545         * windows-nat.c (windows_delete_thread): Remove check for
10546         main_thread_id before printing thread exit notifications.
10547         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10548         Remove thread ID check against main_thread_id.
10549         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10550         windows_delete_thread.
10551         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10552
10553 2019-01-04  Tom Tromey  <tom@tromey.com>
10554
10555         * compile/compile.c (_initialize_compile): Use upper case for
10556         metasyntactic variables.
10557         * symmisc.c (_initialize_symmisc): Use upper case for
10558         metasyntactic variables.
10559         * psymtab.c (_initialize_psymtab): Use upper case for
10560         metasyntactic variables.
10561         * demangle.c (demangle_command): Use upper case for metasyntactic
10562         variables.
10563         (_initialize_demangler): Likewise.
10564         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10565         variables.
10566
10567 2019-01-03  Tom Tromey  <tom@tromey.com>
10568
10569         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10570
10571 2019-01-03  Tom Tromey  <tom@tromey.com>
10572
10573         * python/py-symtab.c (salpy_str): Update.
10574         (struct salpy_sal_object) <symtab>: Now a PyObject.
10575         (salpy_dealloc): Update.
10576         (del_objfile_sal): Use gdbpy_ref.
10577
10578 2019-01-03  Tom Tromey  <tom@tromey.com>
10579
10580         * python/py-type.c (convert_field): Use new_reference.  Return
10581         gdbpy_ref.
10582         (make_fielditem): Return gdbpy_ref.
10583         (typy_fields): Update.
10584         (typy_getitem): Update.
10585         (field_name): Return gdbpy_ref.  Use new_reference.
10586         (typy_iterator_iternext): Update.
10587
10588 2019-01-03  Tom Tromey  <tom@tromey.com>
10589
10590         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10591
10592 2019-01-03  Tom Tromey  <tom@tromey.com>
10593
10594         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10595         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10596         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10597         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10598         (pspy_set_type_printers): Likewise.
10599         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10600         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10601         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10602         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10603         (objfpy_set_type_printers): Likewise.
10604
10605 2019-01-03  Tom Tromey  <tom@tromey.com>
10606
10607         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10608         (gdbpy_print_stack): Use gdbpy_err_fetch.
10609         * python/python-internal.h (class gdbpy_err_fetch): New class.
10610         (class gdbpy_enter) <m_error_type, m_error_value,
10611         m_error_traceback>: Remove.
10612         <m_error>: New member.
10613         (gdbpy_exception_to_string): Don't declare.
10614         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10615         * python/py-value.c (convert_value_from_python): Use
10616         gdbpy_err_fetch.
10617         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10618         gdbpy_exception_to_string.
10619         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10620         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10621         gdbpy_err_fetch.
10622
10623 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10624
10625         * linux-nat.c (delete_lwp_cleanup): Delete.
10626         (struct lwp_deleter): New struct.
10627         (lwp_info_up): New typedef.
10628         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10629         lwp_info_up.
10630
10631 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10632
10633         * linux-fork.c (class scoped_switch_fork_info): New class.
10634         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10635
10636 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10637
10638         * valops.c (find_overload_match): Remove use of null_cleanup, and
10639         calls to do_cleanups.
10640
10641 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10642
10643         * compile/compile-cplus-types.c
10644         (compile_cplus_instance::decl_name): Handle changes to
10645         cp_func_name.
10646         * cp-support.c (cp_func_name): Update header comment, update
10647         return type.
10648         * cp-support.h (cp_func_name): Update return type in declaration.
10649         * valops.c (find_overload_match): Move temp_func local to top
10650         level of function and change its type.  Use temp_func to hold and
10651         delete temporary string obtained from cp_func_name.
10652
10653 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10654
10655         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10656         gdb::char_vector, remove cleanup, and update uses of `msg`.
10657
10658 2019-01-03  Jim Wilson  <jimw@sifive.com>
10659
10660         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10661
10662 2019-01-02  Tom Tromey  <tom@tromey.com>
10663
10664         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10665         (tdesc_parse_xml): Remove cleanups.
10666         * target-descriptions.h (make_cleanup_free_target_description):
10667         Don't declare.
10668         (target_desc_deleter): New struct.
10669         (target_desc_up): New typedef.
10670         * target-descriptions.c (target_desc_deleter::operator()): Rename
10671         from free_target_description.
10672         (make_cleanup_free_target_description): Remove.
10673
10674 2019-01-02  Tom Tromey  <tom@tromey.com>
10675
10676         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10677         constructor, destructor.
10678         (linespec_parser): Remove typedef.
10679         (~linespec_parser): Rename from linespec_parser_delete.
10680         (linespec_lex_to_end, linespec_complete_label)
10681         (linespec_complete): Update.
10682         (decode_line_full): Remove cleanups.
10683         (decode_line_1): Update.
10684
10685 2019-01-02  Tom Tromey  <tom@tromey.com>
10686
10687         * python/python-internal.h (inferior_to_inferior_object): Change
10688         return type.
10689         * python/py-exitedevent.c (create_exited_event_object): Update.
10690         * python/py-inferior.c (inferior_to_inferior_object): Return
10691         gdbpy_ref.
10692         (python_new_inferior, python_inferior_deleted)
10693         (thread_to_thread_object, delete_thread_object)
10694         (build_inferior_list, gdbpy_selected_inferior): Update.
10695         * python/py-infthread.c (create_thread_object): Update.  Also fail
10696         if inferior_to_inferior_object fails.
10697
10698 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10699
10700         * inferior.h (class inferior) <displaced_step_state>: New field.
10701         * infrun.h (struct displaced_step_state): Move here from
10702         infrun.c.  Initialize fields, add constructor.
10703         <inf>: Remove field.
10704         <reset>: New method.
10705         * infrun.c (struct displaced_step_inferior_state): Move to
10706         infrun.h.
10707         (displaced_step_inferior_states): Remove.
10708         (get_displaced_stepping_state): Adust.
10709         (displaced_step_in_progress_any_inferior): Adjust.
10710         (displaced_step_in_progress_thread): Adjust.
10711         (displaced_step_in_progress): Adjust.
10712         (add_displaced_stepping_state): Remove.
10713         (get_displaced_step_closure_by_addr): Adjust.
10714         (remove_displaced_stepping_state): Remove.
10715         (infrun_inferior_exit): Call displaced_step_state.reset.
10716         (use_displaced_stepping): Don't check for NULL.
10717         (displaced_step_prepare_throw): Call
10718         get_displaced_stepping_state.
10719         (displaced_step_fixup): Don't check for NULL.
10720         (prepare_for_detach): Don't check for NULL.
10721
10722 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10723
10724         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10725          in case of call that did not complete.
10726
10727 2019-01-02  Andrey Utkin  <autkin@undo.io>
10728
10729         * symfile.c (find_separate_debug_file): Fix search of debug files for
10730         remote debuggee.
10731
10732 2019-01-02  Tom Tromey  <tom@tromey.com>
10733
10734         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10735         indentation.
10736         * python/py-frame.c (frapy_older): Remove cast.
10737         (frapy_newer): Likewise.
10738         * python/py-breakpoint.c (local_setattro): Remove cast.
10739         * python/py-arch.c (archpy_name): Remove local variable.
10740         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10741
10742 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10743
10744         * unittests/basic_string_view/element_access/char/empty.cc:
10745         Fix year range in copyright header.
10746
10747 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10748
10749         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10750         Delete.
10751         <operator==>: Update with for removed field.
10752         <hash>: Likewise.
10753         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10754         <isa_features>: ...this.
10755         <abi_features>: New field.
10756         (riscv_isa_flen): Update comment.
10757         (riscv_abi_xlen): New declaration.
10758         (riscv_abi_flen): New declaration.
10759         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10760         isa_features.
10761         (riscv_abi_xlen): New function.
10762         (riscv_isa_flen): Update to get answer from isa_features.
10763         (riscv_abi_flen): New function.
10764         (riscv_has_fp_abi): Update to get answer from abi_features.
10765         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10766         xlen and flen.
10767         (riscv_call_info) <xlen, flen>: Update comment.
10768         (riscv_call_arg_struct): Remove invalid assertions
10769         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10770         is removed.
10771         (riscv_gdbarch_init): Gather isa features and abi features
10772         separately, ensure both match on the gdbarch when reusing an old
10773         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10774         a target with 64-bit float hardware.
10775
10776 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10777
10778         * source.c (search_command_helper): Stop reverse search
10779         when line 1 has been searched.
10780
10781 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10782
10783         * record-full.c (record_full_base_target::close): Rewrite
10784         record_full_core_buf_list free logic.
10785
10786 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10787
10788         * break-catch-syscall.c (print_one_catch_syscall): xfree
10789         the last text.
10790
10791 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10792
10793         * top.c (print_gdb_version): Update Copyright year in version
10794         message.
10795
10796 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10797
10798         Update copyright year range in all GDB files.
10799
10800 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10801
10802         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10803
10804 For older changes see ChangeLog-2018.
10805 \f
10806 Local Variables:
10807 mode: change-log
10808 left-margin: 8
10809 fill-column: 74
10810 version-control: never
10811 coding: utf-8
10812 End:
10813