gdb/ChangeLog

   1 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * python/py-block.c (blpy_dealloc): Call tp_free.
   4         (blpy_block_syms_dealloc): Likewise.
   5         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
   6         * python/py-inferior.c (infpy_dealloc): Likewise.
   7         * python/py-lazy-string.c (stpy_dealloc): Likewise.
   8         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
   9         * python/py-symbol.c (sympy_dealloc): Likewise.
  10         * python/py-symtab.c (stpy_dealloc): Likewise.
  11         * python/py-type.c (typy_iterator_dealloc): Likewise.
  12
  13 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
  14
  15         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
  16         constructor instead of using a class initializer.
  17
  18 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
  21         * configure: Regenerate.
  22         * configure.ac: Don't source common.host.
  23         * gdbsupport/common.host: Remove.
  24         * gdbsupport/mingw-strerror.c: Remove.
  25         * gdbsupport/posix-strerror.c: Rename to...
  26         * gdbsupport/safe-strerror.c: ...this.
  27
  28 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  29
  30         * maint.c (scoped_command_stats::print_time): Use localtime_r
  31         instead of localtime (provided through gnulib if necessary).
  32         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
  33         of ctime.
  34
  35 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  36
  37         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
  38         avoid compile errors.
  39
  40 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  41
  42         * config.in: Regenerate.
  43         * configure: Regenerate.
  44         * gdbsupport/common.m4: No longer check for strerror_r.
  45         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
  46         POSIX version of strerror_r, now that gnulib provides it if
  47         necessary.
  48
  49 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
  50
  51         * README (`configure' options): Update.
  52
  53 2019-11-14  Tom Tromey  <tromey@adacore.com>
  54
  55         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
  56         expected type for the RHS if the LHS is a convenience variable.
  57
  58 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
  59
  60         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
  61         Provide explicit default and copy constructor.
  62
  63 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  64
  65         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
  66         only call Py_INCREF (newbp) in the bppy_pending_object case.
  67
  68 2019-11-13  Tom Tromey  <tromey@adacore.com>
  69
  70         PR build/25182:
  71         * psympriv.h (partial_symbol): Remove static assert.
  72         * symtab.h (general_symbol_info, symbol): Remove static assert.
  73
  74 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  75
  76         * gdbsupport/format.c (format_pieces::format_pieces): Support
  77         printf 'z' size modifier.
  78         * gdbsupport/format.h (enum argclass): Add size_t_arg.
  79         * printcmd.c (ui_printf):  Handle size_t_arg.
  80         * ui-out.c (ui_out::vmessage): Likewise.
  81         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
  82         function.
  83         (run_tests): Call test_format_int_sizes.
  84
  85 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
  86
  87         * ada-exp.y (write_ambiguous_var): Update.
  88         * buildsym.c (add_symbol_to_list): Update.
  89         * dwarf2read.c (read_variable): Update.
  90         (new_symbol): Update.
  91         * jit.c (finalize_symtab): Update.
  92         * language.c (language_alloc_type_symbol): Update.
  93         * symtab.c (fixup_symbol_section): Update.
  94         (initialize_objfile_symbol_1): Move code to...
  95         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
  96         (allocate_symbol): Update.
  97         (allocate_template_symbol): Update.
  98         (get_symbol_address): Update.
  99         * symtab.h (struct symbol): Inherit from general_symbol_info instead
 100         of having as a field, and add a constructor.
 101         (SYMBOL_VALUE): Update.
 102         (SYMBOL_VALUE_ADDRESS): Update.
 103         (SET_SYMBOL_VALUE_ADDRESS): Update.
 104         (SYMBOL_VALUE_BYTES): Update.
 105         (SYMBOL_VALUE_COMMON_BLOCK): Update.
 106         (SYMBOL_BLOCK_VALUE): Update.
 107         (SYMBOL_VALUE_CHAIN): Update.
 108         (SYMBOL_LANGUAGE): Update.
 109         (SYMBOL_SECTION): Update.
 110         (SYMBOL_OBJ_SECTION): Update.
 111         (SYMBOL_SET_LANGUAGE): Update.
 112         (SYMBOL_SET_LINKAGE_NAME): Update.
 113         (SYMBOL_SET_NAMES): Update.
 114         (SYMBOL_NATURAL_NAME): Update.
 115         (SYMBOL_LINKAGE_NAME): Update.
 116         (SYMBOL_DEMANGLED_NAME): Update.
 117         (SYMBOL_SEARCH_NAME): Update.
 118         (SYMBOL_MATCHES_SEARCH_NAME): Update.
 119         (struct symbol): Update.
 120         (struct template_symbol): Update.
 121         (struct rust_vtable_symbol): Update.
 122         * xcoffread.c (SYMBOL_DUP): Update.
 123
 124 2019-11-12  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-layout.c (show_layout): Set current_layout.
 127         (show_source_disasm_command, show_data)
 128         (show_source_or_disasm_and_command): Don't set current_layout.
 129
 130 2019-11-12  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
 133
 134 2019-11-12  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-win.c (resize_message): New global.
 137         (show_tui_resize_message): New function.
 138         (tui_async_resize_screen): Print message if requested.
 139         (_initialize_tui_win): Add tui-resize-message setting.
 140         * NEWS: Add entry for new commands.
 141
 142 2019-11-11  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 145         functions.
 146
 147 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 148
 149         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 150
 151 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 152
 153         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 154         function.
 155         * python/python-internal.h (gdbpy_lookup_static_symbols):
 156         Declare new function.
 157         * python/python.c (python_GdbMethods): Add
 158         gdb.lookup_static_symbols method.
 159         * NEWS: Mention gdb.lookup_static_symbols.
 160
 161 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 162
 163         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 164         static block of current object file first.  Also fix typo in
 165         header comment.
 166
 167 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 168
 169         * stack.c (set_last_displayed_sal): Delete.
 170         (last_displayed_sal_valid): Delete.
 171         (last_displayed_pspace): Delete.
 172         (last_displayed_addr): Delete.
 173         (last_displayed_symtab): Delete.
 174         (last_displayed_line): Delete.
 175         (class last_displayed_symtab_info_type): New.
 176         (last_displayed_symtab_info): New static global variable.
 177         (print_frame_info): Call methods on last_displayed_symtab_info.
 178         (clear_last_displayed_sal): Update header comment, and make use of
 179         last_displayed_symtab_info.
 180         (last_displayed_sal_is_valid): Likewise.
 181         (get_last_displayed_pspace): Likewise.
 182         (get_last_displayed_addr): Likewise.
 183         (get_last_displayed_symtab): Likewise.
 184         (get_last_displayed_line): Likewise.
 185         (get_last_displayed_sal): Likewise.
 186         * stack.h (clear_last_displayed_sal): Update header comment.
 187         (last_displayed_sal_is_valid): Likewise.
 188         (get_last_displayed_pspace): Likewise.
 189         (get_last_displayed_addr): Likewise.
 190         (get_last_displayed_symtab): Likewise.
 191         (get_last_displayed_line): Likewise.
 192         (get_last_displayed_sal): Likewise.
 193
 194 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 195
 196         * stack.c (frame_show_address): Convert return type to bool.
 197         * stack.h (frame_show_address): Likewise, and update header
 198         comment.
 199
 200 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 203         * unittests/vec-utils-selftests.c: New file.
 204         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 205
 206 2019-11-10  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 209         (tui_highlight_win): Likewise.
 210         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 211         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 212         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 213         Don't set can_highlight.
 214
 215 2019-11-10  Tom Tromey  <tom@tromey.com>
 216
 217         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 218         Remove unused declaration.
 219
 220 2019-11-08  Tom Tromey  <tromey@adacore.com>
 221
 222         * top.c (read_command_file): Update.
 223         (command_line_input): Make return type const.
 224         * python/py-gdb-readline.c: Update.
 225         * linespec.c (decode_line_2): Update.
 226         * defs.h (command_line_input): Make return type const.
 227         * cli/cli-script.c (read_next_line): Make return type const.
 228         * ada-lang.c (get_selections): Update.
 229
 230 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 231
 232         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 233         * mi/mi-main.c (output_cores): Likewise.
 234         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 235         (linux_xfer_osdata_modules): Likewise.
 236         * remote.c (register_remote_support_xml): Likewise.
 237         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 238         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 239
 240 2019-11-06  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-interp.c: Don't include readline.h.
 243         * tui/tui-hooks.c: Don't include readline.h.
 244         * symmisc.c: Include tilde.h, not readline.h.
 245         * symfile.c: Include tilde.h, not readline.h.
 246         * source.c: Include tilde.h, not readline.h.
 247         * solib.c: Include tilde.h, not readline.h.
 248         * psymtab.c: Include tilde.h, not readline.h.
 249         * exec.c: Include tilde.h, not readline.h.
 250         * corelow.c: Include tilde.h, not readline.h.
 251         * cli/cli-dump.c: Include tilde.h, not readline.h.
 252         * cli/cli-cmds.c: Don't include readline.h.
 253
 254 2019-11-05  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 257         (tui_disassemble): Set addr_size.
 258         (tui_disasm_window::set_contents): Use addr_size.
 259
 260 2019-11-05  Tom Tromey  <tom@tromey.com>
 261
 262         * rust-lang.c (rust_language_defn): Update.
 263         * python/py-value.c (valpy_string): Call c_get_string.
 264         * p-lang.c (pascal_language_defn): Update.
 265         * opencl-lang.c (opencl_language_defn): Update.
 266         * objc-lang.c (objc_language_defn): Update.
 267         * m2-lang.c (m2_language_defn): Update.
 268         * language.c (unknown_language_defn, auto_language_defn): Update.
 269         (default_get_string): Remove.
 270         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 271         * go-lang.c (go_language_defn): Update.
 272         * f-lang.c (f_language_defn): Update.
 273         * d-lang.c (d_language_defn): Update.
 274         * c-lang.c (c_language_defn, cplus_language_defn)
 275         (asm_language_defn, minimal_language_defn): Update.
 276         * ada-lang.c (ada_language_defn): Update.
 277         * language.h (struct language_defn) <la_get_string>: Remove.
 278         (LA_GET_STRING): Remove.
 279         (default_get_string): Don't declare.
 280
 281 2019-11-05  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-source.h (struct tui_source_window): Inline
 284         constructor.  Remove destructor.
 285         <style_changed, m_observable>: Move to superclass.
 286         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 287         (struct tui_source_window_base): Move private members to end.
 288         <style_changed, m_observable>: Move from tui_source_window.
 289         * tui/tui-winsource.c (tui_copy_source_line): Move from
 290         tui-source.c.  Rename from copy_source_line.  Add special handling
 291         for negative line number.
 292         (tui_source_window_base::style_changed): Move from
 293         tui_source_window.
 294         (tui_source_window_base): Register observer.
 295         (~tui_source_window_base): New.
 296         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 297         rename.
 298         (tui_source_window::set_contents): Use tui_copy_source_line.
 299         (tui_source_window::tui_source_window): Move to tui-source.h.
 300         (tui_source_window::~tui_source_window): Remove.
 301         (tui_source_window::style_changed): Move to superclass.
 302         * tui/tui-disasm.c (tui_disassemble): Create string file with
 303         styling, when possible.  Add "addr_size" parameter.
 304         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 305         Don't compute maximum size.
 306         (len_without_escapes): New function
 307
 308 2019-11-05  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 311         std::string.
 312         * tui/tui-winsource.c (tui_show_source_line): Update.
 313         * tui/tui-source.c (tui_source_window::set_contents): Update.
 314         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 315
 316 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 317
 318         * symtab.h (gdb_static_assert): Put && operator at the beginning
 319         of the line instead of the end.
 320
 321 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 322
 323         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 324         and sizeof (symbol).
 325         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 326
 327 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 328
 329         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 330         * configure.host: Mark *-*-solaris2.10* obsolete.
 331         * configure.tgt: Mark Solaris < 11 obsolete.
 332         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 333         Update target triplet.
 334
 335 2019-11-01  Tom Tromey  <tromey@adacore.com>
 336
 337         * utils.c (print_sys_errmsg): Simplify.
 338
 339 2019-11-01  Tom Tromey  <tromey@adacore.com>
 340
 341         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 342
 343 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 344
 345         * configure: Regenerate.
 346         * configure.ac: Remove check for strerror_r.
 347         * gdbsupport/common.m4: Check for strerror_r.
 348
 349 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 350
 351         PR gdb/25124
 352
 353         * arm-tdep.c (arm_per_objfile): Rename to ...
 354         (arm_per_bfd): ... this.
 355         (arm_objfile_data_key): Rename to ...
 356         (arm_bfd_data_key): ... this.
 357         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 358         data.
 359         (arm_record_special_symbol): Likewise.
 360
 361 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 364         end.
 365         * c-typeprint.c (c_print_typedef): Likewise.
 366         * f-typeprint.c (f_print_typedef): Likewise.
 367         * m2-typeprint.c (m2_print_typedef): Likewise.
 368         * p-typeprint.c (pascal_print_typedef): Likewise.
 369         * rust-lang.c (rust_print_typedef): Likewise.
 370         * symtab.c (print_symbol_info): Print a newline after calling
 371         typedef_print.
 372
 373 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         * symtab.c (info_module_cmdlist): New variable.
 376         (info_module_command): New function.
 377         (search_module_symbols): New function.
 378         (info_module_subcommand): New function.
 379         (struct info_modules_var_func_options): New struct.
 380         (info_modules_var_func_options_defs): New variable.
 381         (make_info_modules_var_func_options_def_group): New function.
 382         (info_module_functions_command): New function.
 383         (info_module_variables_command): New function.
 384         (info_module_var_func_command_completer): New function.
 385         (_initialize_symtab): Register new 'info module functions' and
 386         'info module variables' commands.
 387         * symtab.h (typedef symbol_search_in_module): New typedef.
 388         (search_module_symbols): Declare new function.
 389         * NEWS: Mention new commands.
 390
 391 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 392
 393         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 394         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 395         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 396         MODULES_DOMAIN.
 397         (scan_partial_symbols): Only create partial module symbols for non
 398         declarations.
 399         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 400         and MODULES_DOMAIN.
 401         * symtab.c (search_domain_name): Likewise.
 402         (search_symbols): Likewise.
 403         (print_symbol_info): Likewise.
 404         (symtab_symbol_info): Likewise.
 405         (info_modules_command): New function.
 406         (_initialize_symtab): Register 'info modules' command.
 407         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 408         * NEWS: Mention new 'info modules' command.
 409
 410 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 411
 412         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 413         and $_gdb_maint_setting_str.
 414
 415 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 416
 417         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 418         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 419         (str_value_from_setting, gdb_setting_str_internal_fn)
 420         (gdb_maint_setting_str_internal_fn): New functions.
 421         (_initialize_cli_cmds): Define the new convenience functions.
 422         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 423         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 424
 425 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 426
 427         * agent.c (set_can_use_agent): When the setting is turned on,
 428         look up agent symbols if we don't have them yet.
 429         (agent_new_objfile): Don't look up agent symbols when the agent
 430         setting is off.
 431
 432 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 433
 434         * config.in: Regenerate.
 435
 436 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 437
 438         * configure: Regenerate.
 439         * configure.ac: Check for strerror_r.
 440         * gdbsupport/common-utils.h (safe_strerror): Change return value
 441         to const char * and document that this function is now threadsafe.
 442         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 443         thread_local and call strerror_r, if available.
 444         * utils.c (perror_string): Update.
 445         (print_sys_errmsg): Update.
 446
 447 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 448
 449         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 450         objfile_key.
 451         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 452         objfile to fetch per-bfd data.
 453         (arm_find_exidx_entry): Likewise.
 454
 455 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 456
 457         * gdbsupport/agent.c (debug_agent): Change type to bool.
 458         (use_agent): Likewise.
 459         (all_agent_symbols_look_up): Likewise.
 460         (agent_loaded_p): Change return value to bool.
 461         (agent_look_up_symbols): Update.
 462         (agent_capability_check): Change return value to bool.
 463         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 464         (debug_agent): Change type to bool.
 465         (use_agent): Likewise.
 466         (agent_capability_check): Change return value to bool.
 467
 468 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 469
 470         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 471         (build_minimal_symbol_hash_tables): Code to clear the table moved
 472         to clear_minimal_symbol_hash_tables.
 473         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 474         when needed.
 475
 476 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 477
 478         * infcmd.c: Remove includes.
 479         * infrun.c: Remove includes.
 480
 481 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 482
 483         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 484         (grow_vect): Remove declaration.
 485         (ada_type_of_array): Remove declaration.
 486         (ada_update_initial_language): Remove declaration.
 487         (ada_fold_name): Remove declaration.
 488         (ada_fill_in_ada_prototype): Remove declaration.
 489         (user_select_syms): Remove declaration.
 490         (get_selections): Remove declaration.
 491         (ada_tag_type): Remove declaration.
 492         (ada_value_tag): Remove declaration.
 493         (ada_is_others_clause): Remove declaration.
 494         (ada_in_variant): Remove declaration.
 495         (ada_value_struct_elt): Remove declaration.
 496         (ada_attribute_name): Remove declaration.
 497         (ada_system_address_type): Remove declaration.
 498         * ada-lang.c (ada_watch_location_expression): Make static.
 499         (GROW_VECT): Move here from ada-lang.h.
 500         (grow_vect): Make static.
 501         (ada_update_initial_language): Make static.
 502         (ada_fold_name): Make static.
 503         (ada_type_of_array): Make static.
 504         (encoded_ordered_before): Move up.
 505         (sort_choices): Move up.
 506         (print_signatures): Move up.
 507         (ada_print_symbol_signature): Move up.
 508         (get_selections): Move up and make static.
 509         (user_select_syms): Move up and make static.
 510         (ada_value_struct_elt): Move up and make static.
 511         (ada_tag_type): Make static.
 512         (ada_value_tag): Make static.
 513         (ada_is_others_clause): Make static.
 514         (ada_in_variant): Make static.
 515         (ada_attribute_name): Make static.
 516
 517 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 518
 519         * ada-lang.c: Remove includes.
 520         * ada-typeprint.c: Remove includes.
 521         * ada-valprint.c: Remove includes.
 522
 523 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 524
 525         * addrmap.c: Add static assertions of type size, moved from
 526         _initialize_addrmap.
 527         (_initialize_addrmap): Remove.
 528
 529 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 530
 531         * coffread.c (record_minimal_symbol): Update.
 532         (process_coff_symbol): Update.
 533         * dbxread.c (read_dbx_symtab): Update.
 534         * dwarf2read.c (add_partial_symbol): Update.
 535         (fixup_go_packaging): Update.
 536         (load_partial_dies): Update.
 537         (new_symbol): Update.
 538         * elfread.c (record_minimal_symbol): Change signature to use
 539         gdb::string_view instead of name+len.
 540         (elf_symtab_read): Update.
 541         (elf_rel_plt_read): Update.
 542         * mdebugread.c (parse_partial_symbols): Update.
 543         (handle_psymbol_enumerators): Update.
 544         (new_symbol): Update.
 545         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 546         to use gdb::string_view instead of name+len.
 547         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 548         * psympriv.h (add_psymbol_to_list): Likewise.
 549         * psymtab.c (add_psymbol_to_bcache): Likewise.
 550         (add_psymbol_to_list): Likewise.
 551         * stabsread.c (define_symbol): Update.
 552         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 553         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 554         (symbol_set_names): Likewise.
 555         * xcoffread.c (scan_xcoff_symtab): Update.
 556
 557 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 558
 559         * symtab.h (symbol_set_names): Document that copy_name must be
 560         set to true for non-nullterminated strings.
 561         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 562         linkage_name if the entry was not found and we need to demangle.
 563
 564 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 565
 566         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 567         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 568         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 569         * gdbsupport/gdb_binary_search.h: New file.
 570
 571 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 572
 573         * NEWS: Mention new --with-system-gdbinit-dir option.
 574         * config.in: Regenerate.
 575         * configure: Regenerate.
 576         * configure.ac: Add new option --with-system-gdbinit-dir.
 577         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 578         for a ".gdb" suffix.
 579         * main.c (get_init_files): Change system_gdbinit argument to
 580         a vector and return the files in SYSTEM_GDBINIT_DIR in
 581         addition to SYSTEM_GDBINIT.
 582         (captured_main_1): Update.
 583         (print_gdb_help): Update.
 584         * top.c (print_gdb_configuration): Also print the value of
 585         SYSTEM_GDBINIT_DIR.
 586
 587 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 588
 589         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 590         that takes gdb::string_view arguments.
 591
 592 2019-10-26  Tom de Vries  <tdevries@suse.de>
 593
 594         * aarch64-linux-tdep.c: Fix typos in comments.
 595         * aarch64-tdep.c: Same.
 596         * ada-lang.c: Same.
 597         * amd64-nat.c: Same.
 598         * arc-tdep.c: Same.
 599         * arch/aarch64-insn.c: Same.
 600         * block.c: Same.
 601         * breakpoint.h: Same.
 602         * btrace.h: Same.
 603         * c-varobj.c: Same.
 604         * cli/cli-decode.c: Same.
 605         * cli/cli-script.c: Same.
 606         * cli/cli-utils.h: Same.
 607         * coff-pe-read.c: Same.
 608         * coffread.c: Same.
 609         * compile/compile-cplus-symbols.c: Same.
 610         * compile/compile-object-run.c: Same.
 611         * completer.c: Same.
 612         * corelow.c: Same.
 613         * cp-support.c: Same.
 614         * demangle.c: Same.
 615         * dwarf-index-write.c: Same.
 616         * dwarf2-frame.c: Same.
 617         * dwarf2-frame.h: Same.
 618         * eval.c: Same.
 619         * frame-base.h: Same.
 620         * frame.h: Same.
 621         * gdbcmd.h: Same.
 622         * gdbtypes.h: Same.
 623         * gnu-nat.c: Same.
 624         * guile/scm-objfile.c: Same.
 625         * i386-tdep.c: Same.
 626         * i386-tdep.h: Same.
 627         * infcall.c: Same.
 628         * infcall.h: Same.
 629         * linux-nat.c: Same.
 630         * m68k-tdep.c: Same.
 631         * macroexp.c: Same.
 632         * memattr.c: Same.
 633         * mi/mi-cmd-disas.c: Same.
 634         * mi/mi-getopt.h: Same.
 635         * mi/mi-main.c: Same.
 636         * minsyms.c: Same.
 637         * nat/aarch64-sve-linux-sigcontext.h: Same.
 638         * objfiles.h: Same.
 639         * ppc-linux-nat.c: Same.
 640         * ppc-linux-tdep.c: Same.
 641         * ppc-tdep.h: Same.
 642         * progspace.h: Same.
 643         * prologue-value.h: Same.
 644         * python/py-evtregistry.c: Same.
 645         * python/py-instruction.h: Same.
 646         * record-btrace.c: Same.
 647         * record-full.c: Same.
 648         * remote.c: Same.
 649         * rs6000-tdep.c: Same.
 650         * ser-tcp.c: Same.
 651         * sol-thread.c: Same.
 652         * sparc-sol2-tdep.c: Same.
 653         * sparc64-tdep.c: Same.
 654         * stabsread.c: Same.
 655         * symfile.c: Same.
 656         * symtab.h: Same.
 657         * target.c: Same.
 658         * tracepoint.c: Same.
 659         * tui/tui-data.h: Same.
 660         * tui/tui-io.c: Same.
 661         * tui/tui-win.c: Same.
 662         * tui/tui.c: Same.
 663         * unittests/rsp-low-selftests.c: Same.
 664         * user-regs.h: Same.
 665         * utils.c: Same.
 666         * utils.h: Same.
 667         * valarith.c: Same.
 668         * valops.c: Same.
 669         * valprint.c: Same.
 670         * valprint.h: Same.
 671         * value.c: Same.
 672         * value.h: Same.
 673         * varobj.c: Same.
 674         * x86-nat.h: Same.
 675         * xtensa-tdep.c: Same.
 676
 677 2019-10-25  Ali Tamur <tamur@google.com>
 678
 679         * charset.c (find_charset_names): Reflect API change.
 680
 681 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 682
 683         * symtab.c (struct demangled_name_entry): Change demangled name
 684         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 685         part of the struct anymore.
 686         (symbol_set_names): No longer obstack allocate + copy the demangled
 687         name, just store the allocated name from bfd.
 688
 689 2019-10-25  Tom Tromey  <tromey@adacore.com>
 690
 691         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 692         (bsearch_cie_cmp, add_cie): Remove.
 693         (find_cie): Reimplement.
 694         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 695         (dwarf2_build_frame_info): Update.
 696
 697 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 698
 699         PR gdb/25126
 700         * symfile.c (reread_symbols): Call forget_cached_source_info to
 701         clear the stale source cache.
 702
 703 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 704
 705         * configure: Regenerate.
 706         * configure.ac: Remove code that sets python_has_threads.
 707
 708 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 709
 710         * config.in: Regenerate.
 711         * configure: Regenerate.
 712         * configure.ac: Remove the code that uses sed to get the python
 713         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 714
 715 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 716
 717         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 718         error paths.
 719
 720 2019-10-23  Tom Tromey  <tom@tromey.com>
 721
 722         * arc-tdep.c: Remove ".." from include.
 723         * frv-tdep.c: Remove ".." from include.
 724         * lm32-tdep.c: Remove ".." from include.
 725         * microblaze-tdep.c: Remove ".." from include.
 726         * or1k-tdep.h: Remove ".." from include.
 727         * s12z-tdep.c: Remove ".." from include.
 728         * Makefile.in (OPCODES_CFLAGS): Add comment.
 729         (TOP_CFLAGS): New variable.
 730         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 731
 732 2019-10-23  Tom Tromey  <tom@tromey.com>
 733
 734         * Makefile.in (READLINE_DIR): Update.
 735
 736 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 737
 738         * infcall.c (call_function_by_hand_dummy): Fix the function
 739         comment.  And extract out a code section into...
 740         (reserve_stack_space): ...this new function.
 741
 742 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 743
 744         * infcall.c (value_arg_coerce): Remove an unused parameter.
 745         (call_function_by_hand_dummy): Update the call to
 746         'value_arg_coerce'.
 747
 748 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 749
 750         * infcall.c (call_function_by_hand_dummy): Refactor.
 751
 752 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 753
 754         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 755
 756 2019-10-23  Tom Tromey  <tom@tromey.com>
 757
 758         * configure: Rebuild.
 759         * configure.ac: Don't check for sigprocmask.
 760         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 761
 762 2019-10-23  Tom Tromey  <tom@tromey.com>
 763
 764         * configure: Rebuild.
 765         * acinclude.m4: Use m4_include, not sinclude.
 766
 767 2019-10-23  Tom de Vries  <tdevries@suse.de>
 768
 769         PR breakpoints/24687
 770         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 771
 772 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 773
 774         * symtab.c (struct demangled_name_entry) <language>: Change from
 775         bitfield to regular variable.
 776
 777 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 778
 779         * symtab.c (struct demangled_name_entry): Add a constructor.
 780         (free_demangled_name_entry): New function to call the destructor
 781         for demangled_name_entry.
 782         (create_demangled_names_hash): Pass free_demangled_name_entry to
 783         htab_create_alloc.
 784         (symbol_set_names): Call placement new for demangled_name_entry.
 785         * utils.c: No longer include xxhash.h here, now that fast_hash
 786         is inlined in the header.
 787         * utils.h: Instead, include it here.
 788
 789 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 790
 791         * Makefile.in: Link with libxxhash.
 792         * config.in: Regenerate.
 793         * configure: Regenerate.
 794         * configure.ac: Search for libxxhash.
 795         * utils.c (fast_hash): Use xxhash if present.
 796
 797 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 798
 799         * utils.h (fast_hash): New function.
 800         * symtab.c (hash_demangled_name_entry): Call new function
 801         fast_hash.
 802
 803 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 804
 805         * symtab.c (struct demangled_name_entry): Change type of mangled
 806         to gdb::string_view. Also adds a constructor that takes the
 807         mangled name.
 808         (hash_demangled_name_entry): Update.
 809         (eq_demangled_name_entry): Update.
 810         (free_demangled_name_entry): New function to call the destructor
 811         now that this is not a POD anymore.
 812         (create_demangled_names_hash): Pass free_demangled_name_entry to
 813         htab_create_alloc.
 814         (symbol_set_names): Update.
 815
 816 2019-10-21  Ali Tamur  <tamu@google.com>
 817
 818         * dwarf2read.c (dir_index): Change type.
 819         (file_name_index): Likewise.
 820         (line_header::include_dir_at): Change comment and implementation on
 821         whether it is DWARF 5.
 822         (line_header::is_valid_file_index): New function.
 823         (line_header::file_name_at): Change comment and implementation on
 824         whether it is DWARF 5.
 825         (line_header::file_names): Change to private field renamed as
 826         m_file_names and introduce a new accessor method.
 827         (line_header::file_names_size): New method.
 828         (line_header::include_dirs): Change to private field and rename as
 829         m_include_dirs.
 830         (dw2_get_file_names_reader): Define local var at a smaller scope and
 831         reflect API change.
 832         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 833         (process_structure_scope): Likewise.
 834         (line_header::add_include_dir): Change message and reflect renaming.
 835         (line_header::add_file_name): Likewise.
 836         (read_formatted_entries): Handle DW_FORM_data16.
 837         (dwarf_decode_line_header): Fix line header length calculation.
 838         (psymtab_include_file_name): Change comment and API.
 839         (lnp_state_machine::m_file): Update comment and reflect type change.
 840         (lnp_state_machine::record_line): Reflect type change.
 841         (dwarf_decode_lines): Reflect API change.
 842         (file_file_name): Likewise.
 843         (file_full_name): Likewise.
 844
 845 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 848
 849 2019-10-21  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 852
 853 2019-10-21  Tom Tromey  <tom@tromey.com>
 854
 855         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 856         NM_H.   Use AC_CONFIG_LINKS.
 857         * configure: Rebuild.
 858         * Makefile.in (NM_H): New variable.
 859         (generated_files): Add NM_H.  Remove gcore.
 860         (nm.h, stamp-nmh): New targets.
 861
 862 2019-10-20  Tom Tromey  <tom@tromey.com>
 863
 864         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 865         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 866         obsolete comment.
 867         (put_objfile_before): Now static.
 868
 869 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 870
 871         * gdbsupport/common-utils.h (startswith): Change return type to
 872         bool.
 873
 874 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 875
 876         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 877         * breakpoint.c (bp_locations_compare): Rename to...
 878         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 879         (update_global_location_list): Use std::sort instead of qsort.
 880         * buildsym.c (compare_line_numbers): Rename to...
 881         (lte_is_less_than): ...this, and change to std::sort semantics.
 882         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 883         instead of qsort.
 884         * disasm.c (compare_lines): Rename to...
 885         (line_is_less_than): ...this, and change to std::sort semantics.
 886         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 887         of qsort.
 888         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 889         (fde_is_less_than): ...this, and change to std::sort semantics.
 890         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 891         * mdebugread.c (compare_blocks):
 892         (block_is_less_than): ...this, and change to std::sort semantics.
 893         (sort_blocks): Call std::sort instead of qsort.
 894         * objfiles.c (qsort_cmp): Rename to...
 895         (sort_cmp): ...this, and change to std::sort semantics.
 896         (update_section_map): Call std::sort instead of qsort.
 897         * remote.c (compare_pnums): Remove.
 898         (map_regcache_remote_table): Call std::sort instead of qsort.
 899         * utils.c (compare_positive_ints): Remove.
 900         * utils.h (compare_positive_ints): Remove.
 901         * xcoffread.c (compare_lte): Remove.
 902         (arrange_linetable): Call std::sort instead of qsort.
 903
 904 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 905
 906         * symfile.c (init_entry_point_info): Fix typo.
 907         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 908
 909 2019-10-18  Tom de Vries  <tdevries@suse.de>
 910
 911         * aarch64-tdep.c: Fix typos in comments.
 912         * ada-lang.c: Same.
 913         * ada-tasks.c: Same.
 914         * alpha-tdep.c: Same.
 915         * alpha-tdep.h: Same.
 916         * amd64-nat.c: Same.
 917         * amd64-windows-tdep.c: Same.
 918         * arc-tdep.c: Same.
 919         * arc-tdep.h: Same.
 920         * arch-utils.c: Same.
 921         * arm-nbsd-tdep.c: Same.
 922         * arm-tdep.c: Same.
 923         * ax-gdb.c: Same.
 924         * blockframe.c: Same.
 925         * btrace.c: Same.
 926         * c-varobj.c: Same.
 927         * coff-pe-read.c: Same.
 928         * coffread.c: Same.
 929         * cris-tdep.c: Same.
 930         * darwin-nat.c: Same.
 931         * dbxread.c: Same.
 932         * dcache.c: Same.
 933         * disasm.c: Same.
 934         * dtrace-probe.c: Same.
 935         * dwarf-index-write.c: Same.
 936         * dwarf2-frame-tailcall.c: Same.
 937         * dwarf2-frame.c: Same.
 938         * dwarf2read.c: Same.
 939         * eval.c: Same.
 940         * exceptions.c: Same.
 941         * fbsd-tdep.c: Same.
 942         * findvar.c: Same.
 943         * frame.c: Same.
 944         * frv-tdep.c: Same.
 945         * gnu-v3-abi.c: Same.
 946         * go32-nat.c: Same.
 947         * h8300-tdep.c: Same.
 948         * hppa-tdep.c: Same.
 949         * i386-linux-tdep.c: Same.
 950         * i386-tdep.c: Same.
 951         * ia64-libunwind-tdep.c: Same.
 952         * ia64-tdep.c: Same.
 953         * infcmd.c: Same.
 954         * infrun.c: Same.
 955         * linespec.c: Same.
 956         * linux-nat.c: Same.
 957         * linux-thread-db.c: Same.
 958         * machoread.c: Same.
 959         * mdebugread.c: Same.
 960         * mep-tdep.c: Same.
 961         * mn10300-tdep.c: Same.
 962         * namespace.c: Same.
 963         * objfiles.c: Same.
 964         * opencl-lang.c: Same.
 965         * or1k-tdep.c: Same.
 966         * osabi.c: Same.
 967         * ppc-linux-nat.c: Same.
 968         * ppc-linux-tdep.c: Same.
 969         * ppc-sysv-tdep.c: Same.
 970         * printcmd.c: Same.
 971         * procfs.c: Same.
 972         * record-btrace.c: Same.
 973         * record-full.c: Same.
 974         * remote-fileio.c: Same.
 975         * remote.c: Same.
 976         * rs6000-tdep.c: Same.
 977         * s12z-tdep.c: Same.
 978         * score-tdep.c: Same.
 979         * ser-base.c: Same.
 980         * ser-go32.c: Same.
 981         * skip.c: Same.
 982         * sol-thread.c: Same.
 983         * solib-svr4.c: Same.
 984         * solib.c: Same.
 985         * source.c: Same.
 986         * sparc-nat.c: Same.
 987         * sparc-sol2-tdep.c: Same.
 988         * sparc-tdep.c: Same.
 989         * sparc64-tdep.c: Same.
 990         * stabsread.c: Same.
 991         * stack.c: Same.
 992         * symfile.c: Same.
 993         * symtab.c: Same.
 994         * target-descriptions.c: Same.
 995         * target-float.c: Same.
 996         * thread.c: Same.
 997         * utils.c: Same.
 998         * valops.c: Same.
 999         * valprint.c: Same.
1000         * value.c: Same.
1001         * varobj.c: Same.
1002         * windows-nat.c: Same.
1003         * xcoffread.c: Same.
1004         * xstormy16-tdep.c: Same.
1005         * xtensa-tdep.c: Same.
1006
1007 2019-10-17  Tom Tromey  <tromey@adacore.com>
1008
1009         * configure: Rebuild.
1010         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1011         in AC_CONFIG_FILES invocation.
1012         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1013         new-style config.status invocation.
1014
1015 2019-10-17  Tom de Vries  <tdevries@suse.de>
1016
1017         * arm-nbsd-nat.c: Fix typos in comments.
1018         * arm-tdep.c: Same.
1019         * darwin-nat-info.c: Same.
1020         * dwarf2read.c: Same.
1021         * elfread.c: Same.
1022         * event-top.c: Same.
1023         * findvar.c: Same.
1024         * gdbtypes.c: Same.
1025         * hppa-tdep.c: Same.
1026         * i386-tdep.c: Same.
1027         * jit.c: Same.
1028         * main.c: Same.
1029         * mdebugread.c: Same.
1030         * moxie-tdep.c: Same.
1031         * nto-procfs.c: Same.
1032         * osabi.c: Same.
1033         * ppc-linux-tdep.c: Same.
1034         * remote.c: Same.
1035         * riscv-tdep.c: Same.
1036         * s390-tdep.c: Same.
1037         * sh-tdep.c: Same.
1038         * sparc-linux-tdep.c: Same.
1039         * sparc-nat.c: Same.
1040         * stack.c: Same.
1041         * target-descriptions.c: Same.
1042         * top.c: Same.
1043         * varobj.c: Same.
1044
1045 2019-10-16  Tom Tromey  <tom@tromey.com>
1046
1047         * objfiles.h (struct objfile) <original_name>: Now const.
1048
1049 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1050
1051         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1052         pass on to sigsetjmp's second argument.
1053         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1054
1055 2019-10-16  Keith Seitz  <keiths@redhat.com>
1056
1057         PR gdb/23567
1058         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1059         sections whose size is greater than the file size.
1060
1061 2019-10-16  Jim Wilson  <jimw@sifive.com>
1062
1063         * riscv-tdep.c (riscv_gcc_target_options): New.
1064         (riscv_gnu_triplet_regexp): New.
1065         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1066         set_gdbarch_gnu_triplet_regexp.
1067
1068 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1069
1070         * Makefile.in: Add xml-builtin.h.
1071         * features/feature_to_c.sh: Add an include for xml-builtin.h
1072         to ensure that the compiler checks that the types match.
1073         * xml-builtin.h: New file.
1074         * xml-support.c (fetch_xml_builtin): Add missing const.
1075         * xml-support.h: Remove declaration of xml_builtins.
1076
1077 2019-10-16  Tom de Vries  <tdevries@suse.de>
1078
1079         PR tdep/25096
1080         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1081         (amd64_classify_aggregate): ... here.
1082         (amd64_classify_aggregate_field): Handled fiels of nested structs
1083         recursively.
1084
1085 2019-10-16  Tom de Vries  <tdevries@suse.de>
1086
1087         PR tdep/24104
1088         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1089         that handles 'theclass'.
1090
1091 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * linespec.c (decode_digits_ordinary): Update comment.
1094         * make-target-delegates: No longer need to handle VEC case.
1095         * memrange.c (normalize_mem_ranges): Update comment.
1096         * namespace.c (add_using_directive): Update comment.
1097         * objc-lang.c (uniquify_strings): Update comment.
1098         * ppc-linux-nat.c (struct thread_points): Update comment.
1099         * probe.h (find_probes_in_objfile): Update comment.
1100         * target.h (enum flash_preserve_mode): Update comment.
1101         * varobj.c (varobj_restrict_range): Update comment.
1102         * varobj.h (varobj_list_children): Update comment.
1103
1104 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * Makefile.in: Remove references to vec.h and vec.c.
1107         * aarch64-tdep.c: No longer include vec.h.
1108         * ada-lang.c: Likewise.
1109         * ada-lang.h: Likewise.
1110         * arm-tdep.c: Likewise.
1111         * ax.h: Likewise.
1112         * breakpoint.h: Likewise.
1113         * charset.c: Likewise.
1114         * cp-support.h: Likewise.
1115         * dtrace-probe.c: Likewise.
1116         * dwarf2read.c: Likewise.
1117         * extension.h: Likewise.
1118         * gdb_bfd.c: Likewise.
1119         * gdbsupport/gdb_vecs.h: Likewise.
1120         * gdbsupport/vec.c: Remove.
1121         * gdbsupport/vec.h: Remove.
1122         * gdbthread.h: Likewise.
1123         * guile/scm-type.c: Likewise.
1124         * inline-frame.c: Likewise.
1125         * machoread.c: Likewise.
1126         * memattr.c: Likewise.
1127         * memrange.h: Likewise.
1128         * namespace.h: Likewise.
1129         * nat/linux-btrace.h: Likewise.
1130         * osdata.c: Likewise.
1131         * parser-defs.h: Likewise.
1132         * progspace.h: Likewise.
1133         * python/py-type.c: Likewise.
1134         * record-btrace.c: Likewise.
1135         * rust-exp.y: Likewise.
1136         * solib-target.c: Likewise.
1137         * stap-probe.c: Likewise.
1138         * target-descriptions.c: Likewise.
1139         * target-memory.c: Likewise.
1140         * target.h: Likewise.
1141         * varobj.c: Likewise.
1142         * varobj.h: Likewise.
1143         * xml-support.h: Likewise.
1144
1145 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1148         Update for new std::vector based implementation.
1149         (process_psymtab_comp_unit_reader): Likewise.
1150         (scan_partial_symbols): Likewise.
1151         (recursively_compute_inclusions): Likewise.
1152         (compute_compunit_symtab_includes): Likewise.
1153         (process_imported_unit_die): Likewise.
1154         (queue_and_load_dwo_tu): Likewise.
1155         (follow_die_sig_1): Likewise.
1156         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1157         (typedef dwarf2_per_cu_ptr): Remove.
1158         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1159         function.
1160         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1161         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1162         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1163         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1164         std::vector.
1165
1166 2019-10-15  Tom Tromey  <tromey@adacore.com>
1167
1168         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1169         TID.
1170
1171 2019-10-15  Tom Tromey  <tromey@adacore.com>
1172
1173         * windows-nat.c (windows_nat_target::fetch_registers)
1174         (windows_nat_target::store_registers): Rename "pid" to "tid".
1175
1176 2019-10-15  Tom Tromey  <tromey@adacore.com>
1177
1178         * gdbarch.h, gdbarch.c: Rebuild.
1179         * gdbarch.sh (gcc_target_options): Change return type to
1180         std::string.
1181         * compile/compile.c (get_args): Update.
1182         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1183         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1184         std::string.
1185         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1186         std::string.
1187         * arch-utils.c (default_gcc_target_options): Return std::string.
1188         * arch-utils.h (default_gcc_target_options): Return std::string.
1189         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1190
1191 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1192
1193         * breakpoint.c (breakpoint_chain): Make static.
1194         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1195         of accessing breakpoint_chain.
1196
1197 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1198
1199         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1200         to a gdb::function_view and return value to bool.
1201         * breakpoint.h (iterate_over_breakpoints): Likewise.
1202         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1203         (pop_dummy_frame): Update.
1204         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1205         (gdbscm_breakpoints): Update.
1206         * python/py-breakpoint.c (build_bp_list): Update.
1207         (gdbpy_breakpoints): Update.
1208         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1209         Update.
1210         (bpfinishpy_handle_stop): Update.
1211         (bpfinishpy_handle_exit): Update.
1212         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1213         (svr4_update_solib_event_breakpoints): Update.
1214
1215 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1216
1217         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1218         when unwrapping single-field structs.
1219
1220 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1221
1222         * dwarf2read.c: Remove includes.
1223
1224 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1225
1226         * ui-out.c (ui_out::call_do_message): Silence
1227         -Wformat-nonliteral warning.
1228
1229 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1230
1231         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1232         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1233         include: readline/tilde.h.
1234
1235 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1236
1237         * remote.c (remote_target::get_trace_status): Remove declaration of
1238         trace_regblock_size.
1239
1240 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1241
1242         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1243         (show_user): Remove declaration of cmdlist.
1244         * cli/cli-cmds.h (max_user_call_depth): Declare.
1245         * cli/cli-script.c (execute_user_command): Remove declaration
1246         of max_user_call_depth.
1247
1248 2019-10-11  Jim Wilson  <jimw@sifive.com>
1249
1250         * gdbsupport/print-utils.h (pulongest): Fix comment.
1251         (plongest): Likewise.
1252         (phex): Add missing comment, mention leading zeros.
1253         (phex_nz): Add mention of no leading zeros to comment.
1254
1255         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1256         plongest instead of unsigned long long cast.
1257
1258 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1259
1260         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1261         for external_editor_command and gdbtk_test.
1262
1263 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1264
1265         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1266         * varobj.c (varobjdebug): Move comment to...
1267         * varobj.h (varobjdebug): ...here, and declare.
1268
1269 2019-10-09  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1272         erase_data_content.
1273
1274 2019-10-09  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1277         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1278         * tui/tui-command.c (tui_cmd_window::resize)
1279         (tui_refresh_cmd_win): Update.
1280         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1281         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1282         * tui/tui-data.c (~tui_gen_win_info): Remove.
1283         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1284         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1285         (tui_redisplay_readline, tui_mld_flush)
1286         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1287         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1288         (tui_data_window::erase_data_content)
1289         (tui_data_item_window::rerender)
1290         (tui_data_item_window::refresh_window): Update.
1291         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1292         (box_win, tui_gen_win_info::make_window)
1293         (tui_gen_win_info::make_visible): Update.
1294         (tui_delete_win): Remove.
1295         * tui/tui-winsource.c
1296         (tui_source_window_base::do_erase_source_content): Update.
1297         (tui_show_source_line, tui_source_window_base::update_tab_width)
1298         (tui_source_window_base::update_exec_info): Update.
1299         * tui/tui-data.h (struct curses_deleter): New.
1300         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1301         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1302
1303 2019-10-09  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1306
1307 2019-10-09  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1310         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1311
1312 2019-10-09  Tom Tromey  <tom@tromey.com>
1313
1314         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1315         window height directly.
1316         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1317         declare.
1318         * tui/tui-layout.c (tui_default_win_height): Remove.
1319         (tui_default_win_viewport_height): Remove.
1320
1321 2019-10-09  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui.h: Remove comments.
1324
1325 2019-10-09  Tom de Vries  <tdevries@suse.de>
1326
1327         * python/lib/gdb/printer/bound_registers.py: Use
1328         '^builtin_type_bound128' as regexp argument for
1329         add_builtin_pretty_printer.
1330
1331 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1332
1333         * guile/guile.c (guile_extension_script_ops): Remove forward
1334         declaration and mark as static.
1335         (guile_script_ops): Likewise.
1336         (extension_language_guile): Move further down in the file so
1337         it can reference the definitions for guile_{extension_,}script_ops.
1338
1339 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1340
1341         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1342         except SORTL, DFLTCC, and KDSA.
1343
1344 2019-10-08  Tom Tromey  <tromey@adacore.com>
1345
1346         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1347         (struct safe_symbol_file_add_args): Remove.
1348
1349 2019-10-08  Tom Tromey  <tromey@adacore.com>
1350
1351         * windows-nat.c: Don't include buildsym-legacy.h.
1352
1353 2019-10-08  Tom Tromey  <tromey@adacore.com>
1354
1355         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1356
1357 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1358
1359         * gdbtypes.c (overload_debug): Move comment to header.
1360         * gdbtypes.h (overload_debug): Declare.
1361         * valops.c: Remove declaration of overload_debug, instead
1362         include gdbtypes.h.
1363
1364 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1365
1366         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1367         through _().
1368         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1369         move comment...
1370         * language.h (lang_frame_mismatch_warn): ... here. Also add
1371         declaration.
1372         * top.c (lang_frame_mismatch_warn): Remove declaration.
1373         (check_frame_language_change): Pass lang_frame_mismatch_warn
1374         through _().
1375
1376 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1377
1378         * c-lang.h (vtbl_ptr_name): Declare.
1379         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1380         it from the header.
1381         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1382
1383 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1384
1385         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1386         gdb_static_assert.
1387
1388 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1389
1390         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1391         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1392         * ctfread.c: New file.
1393         * ctfread.h: New file.
1394         * elfread.c: Include ctfread.h.
1395         (struct elfinfo text_p): New member ctfsect.
1396         (elf_locate_sections): Mark CTF section.
1397         (elf_symfile_read): Call elfctf_build_psymtabs.
1398         * Makefile.in (LIBCTF): Add.
1399         (CLIBS): Use it.
1400         (CDEPS): Likewise.
1401         (DIST): Add ctfread.c.
1402
1403 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         * ctfread.c (struct nextfield): Renamed to ...
1406         (struct ctf_nextfield): ... this.
1407         (struct field_info): Renamed to ...
1408         (strut ctf_field_info): ... this.
1409         (attach_fields_to_type): Update for renamed structures.
1410         (ctf_add_member_cb): Likewise.
1411         (ctf_add_enum_member_cb): Likewise.
1412         (process_struct_members): Likewise.
1413         (process_enum_type): Likewise.
1414
1415 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1416
1417         * tracectf.h: Rename, was ctf.h.
1418         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1419         * tracefile.c: Likewise.
1420         * tracepoint.c: Remove unused include ctf.h.
1421         * mi/mi-main.c: Likewise.
1422         * Makefile.in Replace ctf.c with tracectf.c.
1423
1424 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1425
1426         * version.in: Change version number to "9.0.50.DATE-git".
1427
1428 2019-10-03  Tom Tromey  <tom@tromey.com>
1429
1430         PR rust/24976:
1431         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1432
1433 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1434
1435         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1436         cp_search_name_hash.
1437         * NEWS: Add entry about nested function support.
1438
1439 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1440             Andrew Burgess  <andrew.burgess@embecosm.com>
1441
1442         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1443         for nested static variables when searchin VAR_DOMAIN.
1444         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1445         global scope, update comment.
1446         (add_partial_subprogram): Call add_partial_subprogram recursively
1447         for nested subroutines when processinng Fortran.
1448         (load_partial_dies): Process the child entities of a subprogram
1449         when processing Fortran.
1450         (partial_die_parent_scope): Handle building scope
1451         for Fortran nested functions.
1452         (process_die): Record that nested functions have a scope.
1453         (new_symbol): Always record Fortran subprograms on the global
1454         symbol list.
1455         (determine_prefix): How to build the prefix for Fortran
1456         subprograms.
1457
1458 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1459
1460         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1461         have just sent the thread a SIGSTOP and are waiting for it to
1462         arrive.
1463
1464 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1465
1466         * btrace.c (btrace_add_pc): Remove whitespace before the template
1467         parameter in 'std::vector <...>'.
1468         (parse_xml_btrace_block): Likewise.
1469         (btrace_maint_decode_pt): Likewise.
1470         (btrace_maint_update_packets): Likewise.
1471         (btrace_maint_print_packets): Likewise.
1472         * btrace.h (struct btrace_maint_info): Likewise.
1473         * dwarf2read.c (struct type_unit_group): Likewise.
1474         (build_type_psymtabs_reader): Likewise.
1475         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1476         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1477         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1478
1479 2019-10-03  Tom de Vries  <tdevries@suse.de>
1480
1481         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1482         the first line of the help text for set/show style metadata.
1483
1484 2019-10-02  Tom Tromey  <tromey@adacore.com>
1485
1486         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1487         * gdbsupport/common-inferior.c: New file.
1488         * infcmd.c (startup_with_shell): Don't define.
1489         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1490         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1491         * inferior.h (startup_with_shell): Don't declare.
1492
1493 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1494
1495         * gdbsupport/gdb_assert.h: Include errors.h.
1496         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1497
1498 2019-10-02  Tom Tromey  <tromey@adacore.com>
1499
1500         * NEWS: Add $_ada_exception entry.
1501         * ada-lang.c (struct ada_catchpoint): Add constructor.
1502         <m_kind>: New member.
1503         (allocate_location_exception, re_set_exception): Remove
1504         "ex" parameter.
1505         (should_stop_exception): Compute $_ada_exception.
1506         (check_status_exception, print_it_exception)
1507         (print_one_exception, print_mention_exception): Remove
1508         "ex" parameter.
1509         (allocate_location_catch_exception, re_set_catch_exception)
1510         (check_status_exception, print_it_catch_exception)
1511         (print_one_catch_exception, print_mention_catch_exception)
1512         (print_recreate_catch_exception)
1513         (allocate_location_catch_exception_unhandled)
1514         (re_set_catch_exception_unhandled)
1515         (check_status_exception, print_it_catch_exception_unhandled)
1516         (print_one_catch_exception_unhandled)
1517         (print_mention_catch_exception_unhandled)
1518         (print_recreate_catch_exception_unhandled)
1519         (allocate_location_catch_assert, re_set_catch_assert)
1520         (check_status_assert, print_it_catch_assert)
1521         (print_one_catch_assert, print_mention_catch_assert)
1522         (print_recreate_catch_assert)
1523         (allocate_location_catch_handlers, re_set_catch_handlers)
1524         (check_status_handlers, print_it_catch_handlers)
1525         (print_one_catch_handlers, print_mention_catch_handlers)
1526         (print_recreate_catch_handlers): Remove.
1527         (create_ada_exception_catchpoint): Update.
1528         (initialize_ada_catchpoint_ops): Update.
1529
1530 2019-10-02  Tom Tromey  <tromey@adacore.com>
1531
1532         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1533         (create_excep_cond_exprs): Simplify exception string computation.
1534         (ada_exception_catchpoint_cond_string): Likewise.
1535
1536 2019-10-02  Tom Tromey  <tromey@adacore.com>
1537
1538         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1539         * ada-lang.c (lesseq_defined_than): Handle
1540         LOC_STATIC.
1541         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1542         parameter.
1543         (dwarf2_has_info): Likewise.
1544         (new_symbol): Set maybe_copied on symbol when
1545         appropriate.
1546         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1547         parameter.
1548         <can_copy>: New member.
1549         * elfread.c (record_minimal_symbol): Set maybe_copied
1550         on symbol when appropriate.
1551         (elf_symfile_read): Update call to dwarf2_has_info.
1552         * minsyms.c (lookup_minimal_symbol_linkage): New
1553         function.
1554         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1555         * symtab.c (get_symbol_address, get_msymbol_address):
1556         New functions.
1557         * symtab.h (get_symbol_address, get_msymbol_address):
1558         Declare.
1559         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1560         maybe_copied.
1561         (struct symbol, struct minimal_symbol) <maybe_copied>:
1562         New member.
1563
1564 2019-10-02  Tom Tromey  <tromey@adacore.com>
1565
1566         * source.c (struct current_source_location): New.
1567         (current_source_key): New global.
1568         (current_source_symtab, current_source_line)
1569         (current_source_pspace): Remove.
1570         (get_source_location): New function.
1571         (get_current_source_symtab_and_line)
1572         (set_default_source_symtab_and_line)
1573         (set_current_source_symtab_and_line)
1574         (clear_current_source_symtab_and_line, select_source_symtab)
1575         (info_source_command, print_source_lines_base)
1576         (info_line_command, search_command_helper, _initialize_source):
1577         Update.
1578
1579 2019-10-02  Tom Tromey  <tromey@adacore.com>
1580
1581         * source.c (select_source_symtab): Don't call
1582         decode_line_with_current_source.
1583
1584 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * symtab.c (lookup_global_symbol): Search global block.
1587
1588 2019-10-02  Tom Tromey  <tromey@adacore.com>
1589
1590         * coffread.c (process_coff_symbol): Update.
1591         * dwarf2read.c (var_decode_location, new_symbol): Update.
1592         * mdebugread.c (parse_symbol): Update.
1593         * objfiles.c (relocate_one_symbol): Update.
1594         * stabsread.c (define_symbol, fix_common_block)
1595         (scan_file_globals): Update.
1596         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1597         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1598         * xcoffread.c (process_xcoff_symbol): Update.
1599
1600 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1601
1602         * MAINTAINERS: Update my email address.
1603
1604 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1605
1606         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1607         std::vector.
1608         (build_type_psymtabs_reader): Update for std::vector.
1609         (build_type_psymtab_dependencies): Likewise.
1610         * dwarf2read.h: Remove use of DEF_VEC_P.
1611         (typedef sig_type_ptr): Delete.
1612
1613 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1614
1615         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1616         to std::vector.
1617         (btrace_maint_decode_pt): Likewise, and move allocation of the
1618         vector outside of the loop.
1619         (btrace_maint_update_packets): Update to handle change from VEC to
1620         std::vector.
1621         (btrace_maint_print_packets): Likewise.
1622         (maint_info_btrace_cmd): Likewise.
1623         * btrace.h: Remove use of DEF_VEC_O.
1624         (typedef btrace_pt_packet_s): Delete.
1625         (struct btrace_maint_info) <packets>: Change fromm VEC to
1626         std::vector.
1627         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1628
1629 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1630
1631         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1632         make accesses into the vector constant references.
1633         (btrace_add_pc): Update for std::vector.
1634         (btrace_stitch_bts): Likewise.
1635         (parse_xml_btrace_block): Likewise.
1636         (btrace_maint_update_packets): Likewise.
1637         (btrace_maint_print_packets): Likewise.
1638         (maint_info_btrace_cmd): Likewise.
1639         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1640         std::vector.
1641         (btrace_data::empty): Likewise.
1642         (btrace_data_append): Likewise.
1643         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1644         (typedef btrace_block_s): Delete.
1645         (struct btrace_block): Add constructor.
1646         (struct btrace_data_bts) <blocks>: Change to std::vector.
1647         * nat/linux-btrace.c (perf_event_read_bts): Update for
1648         std::vector.
1649         (linux_read_bts): Likewise.
1650
1651 2019-10-01  Tom Tromey  <tom@tromey.com>
1652
1653         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1654
1655 2019-10-01  Tom Tromey  <tom@tromey.com>
1656
1657         * stack.c (print_frame, info_frame_command_core): Use
1658         styled_string.
1659         * linux-thread-db.c (try_thread_db_load_1)
1660         (try_thread_db_load_from_pdir_1): Use styled_string.
1661         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1662         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1663         (maybe_print_unsupported_script_warning)
1664         (maybe_print_script_not_found_warning): Use styled_string.
1665         * ada-lang.c (user_select_syms): Use styled_string.
1666
1667 2019-10-01  Tom Tromey  <tom@tromey.com>
1668
1669         * p-lang.c (pascal_printstr): Use metadata style.
1670         * value.c (show_convenience): Use metadata style.
1671         * valprint.c (valprint_check_validity, val_print_optimized_out)
1672         (val_print_not_saved, val_print_unavailable)
1673         (val_print_invalid_address, generic_val_print, val_print)
1674         (value_check_printable, val_print_array_elements): Use metadata
1675         style.
1676         * ui-out.h (class ui_out) <field_fmt>: New overload.
1677         <do_field_fmt>: Add style parameter.
1678         * ui-out.c (ui_out::field_fmt): New overload.
1679         * typeprint.c (type_print_unknown_return_type)
1680         (val_print_not_allocated, val_print_not_associated): Use metadata
1681         style.
1682         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1683         parameter.
1684         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1685         * tracepoint.c (tvariables_info_1): Use metadata style.
1686         * stack.c (print_frame_arg, print_frame_info, print_frame)
1687         (info_frame_command_core): Use metadata style.
1688         * skip.c (info_skip_command): Use metadata style.
1689         * rust-lang.c (rust_print_enum): Use metadata style.
1690         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1691         metadata style.
1692         * python/py-framefilter.c (py_print_single_arg): Use metadata
1693         style.
1694         * printcmd.c (do_one_display, print_variable_and_value): Use
1695         metadata style.
1696         * p-valprint.c (pascal_val_print)
1697         (pascal_object_print_value_fields): Use metadata style.
1698         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1699         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1700         parameter.
1701         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1702         * m2-valprint.c (m2_print_long_set): Use metadata style.
1703         * m2-typeprint.c (m2_print_type): Use metadata style.
1704         * infcmd.c (print_return_value_1): Use metadata style.
1705         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1706         * f-valprint.c (info_common_command_for_block): Use metadata
1707         style.
1708         * f-typeprint.c (f_type_print_base): Use metadata style.
1709         * expprint.c (print_subexp_standard): Use metadata style.
1710         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1711         * cli/cli-style.h (class cli_style_option): Add constructor.
1712         (metadata_style): Declare.
1713         * cli/cli-style.c (metadata_style): New global.
1714         (_initialize_cli_style): Register metadata style.
1715         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1716         parameter.
1717         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1718         * c-typeprint.c (c_type_print_base_struct_union)
1719         (c_type_print_base_1): Use metadata style.
1720         * breakpoint.c (watchpoint_value_print)
1721         (print_one_breakpoint_location): Use metadata style.
1722         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1723         style.
1724         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1725         style.
1726         * ada-valprint.c (val_print_packed_array_elements, printstr)
1727         (print_field_values, ada_val_print_ref, ada_val_print): Use
1728         metadata style.
1729         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1730         style.
1731         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1732         style.
1733         * ada-lang.c (user_select_syms): Use metadata style.
1734
1735 2019-10-01  Tom Tromey  <tom@tromey.com>
1736
1737         * cli/cli-cmds.c (pwd_command): Style output.
1738
1739 2019-10-01  Pedro Alves  <palves@redhat.com>
1740             Tom Tromey  <tom@tromey.com>
1741
1742         * symtab.c (print_symbol_info): Use %ps.
1743         (print_msymbol_info): Use %ps.
1744         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1745         * printcmd.c (print_variable_and_value): Use %ps.
1746         * macrocmd.c (show_pp_source_pos): Use %ps.
1747         * infrun.c (print_exited_reason): Use ui_out::message.
1748         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1749         (describe_other_breakpoints): Use ui_out::message and new
1750         formats.
1751         (say_where): Use new formats.
1752         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1753         and new formats.
1754
1755 2019-10-01  Pedro Alves  <palves@redhat.com>
1756             Tom Tromey  <tom@tromey.com>
1757
1758         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1759         (test_gdb_formats): New function.
1760         (run_tests): Call it.
1761         (test_format_specifier): Update.
1762         * utils.h (fputs_filtered): Update comment.
1763         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1764         (fputs_styled_unfiltered): Declare.
1765         * utils.c (fputs_styled_unfiltered): New function.
1766         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1767         (vfprintf_filtered): Update.
1768         (vfprintf_unfiltered, vprintf_filtered): Update.
1769         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1770         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1771         disallow_ui_out_field>: New constants.
1772         (enum class field_kind): New.
1773         (struct base_field_s, struct signed_field_s): New.
1774         (signed_field): New function.
1775         (struct string_field_s): New.
1776         (string_field): New function.
1777         (struct styled_string_s): New.
1778         (styled_string): New function.
1779         (class ui_out) <message>: Add comment.
1780         <vmessage, call_do_message>: New methods.
1781         <do_message>: Add style parameter.
1782         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1783         methods.
1784         (ui_out::message): Rewrite.
1785         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1786         parameter.
1787         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1788         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1789         gdb_extensions parameter.
1790         (class format_piece): Add parameter to constructor.
1791         (n_int_args): New field.
1792         * gdbsupport/format.c (format_pieces::format_pieces): Add
1793         gdb_extensions parameter.  Handle '*'.
1794         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1795         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1796         vfprintf_styled_no_gdbfmt.
1797         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1798         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1799         unfiltered output.
1800         * ui-style.h (struct ui_file_style) <ptr>: New method.
1801
1802 2019-10-01  Tom Tromey  <tom@tromey.com>
1803
1804         * unittests/format_pieces-selftests.c: Update.  Add final format.
1805         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1806         empty literal pieces.
1807
1808 2019-10-01  Tom Tromey  <tom@tromey.com>
1809
1810         * ui-out.h (enum class ui_out_style_kind): Remove.
1811         (class ui_out) <field_string, field_stsream, do_field_string>:
1812         Change type of "style".
1813         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1814         (ui_out::field_string): Update.
1815         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1816         of "style".
1817         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1818         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1819         * stack.c (print_frame_arg, print_frame_info, print_frame):
1820         Update.
1821         * source.c (print_source_lines_base): Update.
1822         * solib.c (info_sharedlibrary_command): Update.
1823         * skip.c (info_skip_command): Update.
1824         * record-btrace.c (btrace_call_history_src_line)
1825         (btrace_call_history): Update.
1826         * python/py-framefilter.c (py_print_frame): Update.
1827         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1828         "style".
1829         * mi/mi-out.c (mi_ui_out::do_table_header)
1830         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1831         (mi_ui_out::do_field_string): Update.
1832         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1833         Update.
1834         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1835         "style".
1836         * cli-out.c (cli_ui_out::do_table_header)
1837         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1838         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1839         (cli_ui_out::do_field_fmt): Update.
1840         * breakpoint.c (print_breakpoint_location): Update.
1841         (update_static_tracepoint): Update.
1842
1843 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1844
1845         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1846         conversion of gdb_datadir.
1847         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1848         remove not needed c_str ().
1849
1850 2019-09-30  Ali Tamur <tamur@google.com>
1851
1852         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1853         (dwarf2_string_attr): Likewise.
1854
1855 2019-09-30  Ali Tamur <tamur@google.com>
1856
1857         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1858         (process_full_type_unit): Likewise.
1859         (dump_die_shallow): Likewise.
1860         (cu_debug_loc_section): Likewise.
1861
1862 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1863
1864         * minsyms.c (compare_minimal_symbols): Rename to...
1865         (minimal_symbol_is_less_than): ...this, and adjust to STL
1866         conventions (return bool, take arguments as references)
1867         (minimal_symbol_reader::install): Call std::sort instead
1868         of qsort.
1869
1870 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1871
1872         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1873         hash and why.
1874         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1875         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1876
1877 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1878
1879         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1880         * psympriv.h (add_psymbol_to_list): Move comment here and update
1881         it.
1882
1883 2019-09-29  Tom de Vries  <tdevries@suse.de>
1884
1885         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1886         Use $tmpdir/$(basename "$output_file").dwz instead of
1887         "${output_file}.dwz".
1888
1889 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1890
1891         PR gdb/25045
1892         * hppa-linux-nat.c: Include gdbarch.h.
1893
1894 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1895
1896         * blockframe.c (find_pc_partial_function): Change return type to bool.
1897         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1898         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1899         (stub_gnu_ifunc_resolve_name): Likewise.
1900         * symtab.c (compare_filenames_for_search): Likewise.
1901         (compare_glob_filenames_for_search): Likewise.
1902         (matching_obj_sections): Likewise.
1903         (symbol_matches_domain): Likewise.
1904         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1905         (find_line_pc): Change return type to bool.
1906         (find_line_pc_range): Likewise.
1907         (producer_is_realview): Likewise.
1908         * symtab.h (symbol_matches_domain): Likewise.
1909         (find_pc_partial_function): Likewise.
1910         (find_pc_line_pc_range): Likewise.
1911         (in_gnu_ifunc_stub): Likewise.
1912         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1913         (find_line_pc): Likewise.
1914         (find_line_pc_range): Likewise.
1915         (matching_obj_sections): Likewise.
1916         (find_line_symtab): Change out parameter to bool.
1917         (producer_is_realview): Change return type to bool.
1918         (compare_filenames_for_search): Likewise.
1919         (compare_glob_filenames_for_search): Likewise.
1920
1921 2019-09-26  Tom Tromey  <tom@tromey.com>
1922
1923         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1924         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1925         * gdb_usleep.h: Remove.
1926         * gdb_usleep.c: Remove.
1927         * utils.c: Don't include gdb_usleep.h.
1928
1929 2019-09-26  Tom Tromey  <tromey@adacore.com>
1930
1931         * python/py-type.c (type_to_type_object): Call check_typedef
1932         for stub types.
1933
1934 2019-09-26  Tom Tromey  <tom@tromey.com>
1935
1936         * utils.h (initialize_utils): Don't declare.
1937         * top.c (gdb_init): Don't call initialize_utils.
1938         * utils.c (initialize_utils): Remove.  Move contents...
1939         (_initialize_utils): ... here.
1940
1941 2019-09-25  Tom Tromey  <tom@tromey.com>
1942
1943         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1944         * utils.h (make_hex_string): Don't declare.
1945         * utils.c (make_hex_string): Remove.
1946
1947 2019-09-24  Tom de Vries  <tdevries@suse.de>
1948
1949         PR gdb/23815
1950         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1951         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1952
1953 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1954
1955         * NEWS: Mention new simulator port for PRU.
1956
1957 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1958
1959         * ada-exp.y (write_object_remaining): Update.
1960         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1961         and eliminate the static buffer.
1962         (ada_decode_symbol): Update.
1963         (ada_la_decode): Update.
1964         (ada_sniff_from_mangled_name): Update.
1965         (is_valid_name_for_wild_match): Update.
1966         (ada_lookup_name_info::matches): Update and simplify.
1967         (name_matches_regex): Update.
1968         (ada_add_global_exceptions): Update.
1969         * ada-lang.h (ada_decode): Update signature.
1970         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1971         * dwarf-index-write.c (debug_names::insert): Update.
1972
1973 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1974
1975         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1976         formatting.
1977
1978 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1979
1980         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1981         Change "nonzero" to "true" in documentation.
1982
1983 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1984
1985         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1986         (_initialize_darwin_solib): Don't set
1987         darwin_so_ops.lookup_lib_global_symbol.
1988         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1989         set_gdbarch_iterate_over_objfiles_in_search_order.
1990         (elf_lookup_lib_symbol): Rename to...
1991         (svr4_iterate_over_objfiles_in_search_order): this, and update
1992         to iterate semantics.
1993         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1994         * solib.c (solib_global_lookup): Remove.
1995         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1996         (solib_global_lookup): Remove.
1997         * symtab.c (lookup_global_or_static_symbol): Remove call to
1998         solib_global_lookup.
1999
2000 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2001
2002         * NEWS: Move entries about default MI version now being
2003         version 3, and about the GDB/MI fix for multi-location
2004         breakpoints to the "since GDB 8.3" section.
2005
2006 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2007
2008         GDB 8.3.1 released.
2009
2010 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2011
2012         * NEWS: Mention that Cell/B.E. debugging support was removed.
2013         * MAINTAINERS: Remove spu target.
2014
2015         * config/djgpp/fnchange.lst: Remove entries for removed files.
2016
2017         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2018         spu-multiarch.o, and spu-tdep.o.
2019         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2020         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2021         spu-multiarch.c, and spu-tdep.c.
2022         * spu-linux-nat.c: Remove file.
2023         * spu-multiarch.c: Remove file.
2024         * spu-tdep.c: Remove file.
2025         * spu-tdep.h: Remove file.
2026         * solib-spu.c: Remove file.
2027         * solib-spu.h: Remove file.
2028
2029         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2030         * configure.nat (spu-linux): Remove.
2031         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2032         solib-multiarch.o from gdb_target_obs.
2033         (spu*-*-*): Remove.
2034
2035         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2036         feature flag.
2037         (ppc_linux_no_features): Update.
2038         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2039         Cell/B.E. support.
2040         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2041         (tdesc_powerpc_cell64l): Likewise.
2042         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2043         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2044         Cell/B.E. support.
2045         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2046         Do not include "features/rs6000/powerpc-cell32l.c" or
2047         "features/rs6000/powerpc-cell64l.c".
2048         (ppc_linux_spu_section): Remove.
2049         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2050         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2051         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2052         (ppc_linux_spe_context_lookup): Remove.
2053         (ppc_linux_spe_context_inferior_created): Remove.
2054         (ppc_linux_spe_context_solib_loaded): Remove.
2055         (ppc_linux_spe_context_solib_unloaded): Remove.
2056         (ppc_linux_spe_context): Remove.
2057         (struct ppu2spu_cache): Remove.
2058         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2059         (struct ppu2spu_data): Remove.
2060         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2061         ppu2spu_unwind): Remove.
2062         (ppc_linux_init_abi): Remove Cell/B.E. support.
2063         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2064
2065         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2066         (rs6000/powerpc-cell64l-expedite): Likewise
2067         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2068         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2069         rs6000/powerpc-cell64l.xml.
2070         * features/rs6000/powerpc-cell32l.xml: Remove.
2071         * features/rs6000/powerpc-cell64l.xml: Likewise.
2072         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2073         * features/rs6000/powerpc-cell64l.c: Likewise.
2074         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2075         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2076         * regformats/reg-spu.dat: Remove.
2077
2078         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2079         * corelow.c (struct spuid_list): Remove.
2080         (add_to_spuid_list): Remove.
2081         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2082         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2083         (remote_protocol_features): Remove associated entries.
2084         (_initialize_remote): No longer initialize them.
2085         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2086         * linux-nat.c (SPUFS_MAGIC): Remove.
2087         (linux_proc_xfer_spu): Remove.
2088         (spu_enumerate_spu_ids): Remove.
2089         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2090         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2091         (linux_make_corefile_notes): No longer call it.
2092
2093         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2094         (cooked_write_test): Likewise.
2095
2096 2019-09-20  Tom Tromey  <tom@tromey.com>
2097
2098         * NEWS: Mention case-sensitivity of TUI commands.
2099         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2100         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2101         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2102
2103 2019-09-20  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-source.c (tui_source_window::set_contents): Use
2106         make_unique_xstrdup.
2107         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2108         make_unique_xstrdup.
2109
2110 2019-09-20  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-data.c: Remove separator comments.
2113         * tui/tui-layout.c: Remove separator comments.
2114         * tui/tui-win.c: Remove separator comments.
2115         * tui/tui-wingeneral.c: Remove separator comments.
2116
2117 2019-09-20  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui.h (strcat_to_buf): Don't declare.
2120         * tui/tui.c (strcat_to_buf): Remove.
2121
2122 2019-09-20  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2125         from "fullname".
2126         * tui/tui-source.c (tui_source_window::set_contents)
2127         (tui_source_window::location_matches_p)
2128         (tui_source_window::maybe_update): Update.
2129
2130 2019-09-20  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2133         Update.
2134         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2135         prefix.
2136         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2137         (tui_data_window::line_from_reg_element_no)
2138         (tui_data_window::first_reg_element_no_inline)
2139         (tui_data_window::show_registers)
2140         (tui_data_window::show_register_group)
2141         (tui_data_window::display_registers_from)
2142         (tui_data_window::display_registers_from_line)
2143         (tui_data_window::first_data_item_displayed)
2144         (tui_data_window::delete_data_content_windows)
2145         (tui_data_window::erase_data_content)
2146         (tui_data_window::do_scroll_vertical)
2147         (tui_data_window::refresh_window)
2148         (tui_data_window::check_register_values): Update.
2149
2150 2019-09-20  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2153         (struct tui_locator_window) <full_name, proc_name>: Now
2154         std::string.
2155         * tui/tui-stack.c (tui_locator_window::make_status_line)
2156         (tui_locator_window::set_locator_fullname)
2157         (tui_locator_window::set_locator_info): Update.
2158         * tui/tui-source.c (tui_source_window::set_contents)
2159         (tui_source_window::showing_source_p): Update.
2160
2161 2019-09-20  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2164         Don't call tui_locator_win_info_ptr.
2165
2166 2019-09-20  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2169
2170 2019-09-20  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2173         height for locator.
2174         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2175         * tui/tui-layout.c (show_source_disasm_command, show_data)
2176         (show_source_or_disasm_and_command): Use 1 as height for locator.
2177
2178 2019-09-20  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui.c (tui_enable): Update.
2181         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2182         Update.
2183         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2184         Update.
2185         * tui/tui-data.c (win_resized): Now bool.
2186         (tui_win_resized): Return bool.
2187         (tui_set_win_resized_to): Accept a bool.
2188
2189 2019-09-20  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2192         Change type of "refresh_values_only".
2193         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2194         type of "refresh_values_only".
2195
2196 2019-09-20  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2199         std::string.
2200         (tui_disassemble): Add "pos" parameter.
2201         (tui_disasm_window::set_contents): Simplify.
2202
2203 2019-09-20  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-winsource.h (struct tui_source_window_base)
2206         <show_source_content>: Now private.
2207         * tui/tui-winsource.c
2208         (tui_source_window_base::show_source_content): Don't handle empty
2209         content case.
2210
2211 2019-09-20  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-layout.c (show_source_disasm_command)
2214         (show_source_or_disasm_and_command): Don't call
2215         show_source_content.
2216
2217 2019-09-20  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2220         Declare.
2221         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2222         from tui_make_status_line.
2223         (tui_locator_window::rerender): Update.
2224
2225 2019-09-20  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2228         (tui_locator_window::rerender): Update.
2229
2230 2019-09-20  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-winsource.h (struct tui_source_window_base)
2233         <~tui_source_window_base>: Don't declare.
2234         <fullname>: Remove.
2235         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2236         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2237         member.
2238         * tui/tui-source.c (tui_source_window::set_contents): Update.
2239         (tui_source_window::location_matches_p)
2240         (tui_source_window::maybe_update): Update.
2241
2242 2019-09-20  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-winsource.h (~tui_source_element): Remove.
2245         (tui_source_element): Update.
2246         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2247         * tui/tui-winsource.c (tui_show_source_line): Update.
2248         * tui/tui-source.c (tui_source_window::set_contents): Update.
2249         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2250
2251 2019-09-20  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2254         declare.
2255         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2256         tui_clear_source_windows_detail.
2257         * tui/tui-winsource.h (struct tui_source_window_base)
2258         <clear_detail>: Don't declare.
2259         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2260         Remove.
2261         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2262
2263 2019-09-20  Tom Tromey  <tromey@adacore.com>
2264
2265         PR ada/24919:
2266         * block.c (contained_in): Fix final return value.
2267
2268 2019-09-20  Alan Modra  <amodra@gmail.com>
2269
2270         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2271         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2272         (read_indirect_string_from_dwz): Use bfd accessor.
2273         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2274         * machoread.c (macho_symfile_read_all_oso): Likewise.
2275         * solib.c (solib_bfd_open): Likewise.
2276
2277 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2278
2279         * eval.c: Move declaration of overload_resolution to...
2280         * value.h: ...here.
2281
2282 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2283
2284         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2285         * arm-linux-tdep.c: Likewise.
2286         * arm-nbsd-nat.c: Likewise.
2287         * arm-tdep.h: Declare arm_apcs_32.
2288         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2289
2290 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2291
2292         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2293         * dwarf2read.h: Declare dwarf_always_disassemble.
2294
2295 2019-09-19  Tom de Vries  <tdevries@suse.de>
2296
2297         PR gdb/25009
2298         * source-cache.c (source_cache::ensure): Catch exception thrown during
2299         construction of the highlighter.
2300
2301 2019-09-18  Alan Modra  <amodra@gmail.com>
2302
2303         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2304         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2305         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2306         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2307         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2308         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2309         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2310         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2311         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2312         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2313         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2314         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2315         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2316         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2317         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2318         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2319         * mi/mi-interp.c: Update throughout for bfd section macro and
2320         function changes.
2321         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2322         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2323
2324 2019-09-18  Tom Tromey  <tom@tromey.com>
2325
2326         * NEWS: Add entry.
2327         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2328         call rl_initialize.
2329         (tui_enable): Do not call rl_initialize.
2330
2331 2019-09-18  Christian Groessler  <chris@groessler.org>
2332
2333         * alpha-linux-nat.c: Include gdbarch.h.
2334
2335 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2336
2337         * ui-file.c: Include cli/cli-style.h.
2338         (term_cli_styling): Remove cli_styling declaration.
2339
2340 2019-09-18  Alan Modra  <amodra@gmail.com>
2341
2342         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2343         to bfd_asymbol_section.
2344
2345 2019-09-18  Alan Modra  <amodra@gmail.com>
2346
2347         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2348         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2349         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2350
2351 2019-09-18  Alan Modra  <amodra@gmail.com>
2352
2353         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2354         * spu-linux-nat.c (spu_bfd_open): Likewise.
2355
2356 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2357
2358         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2359         to bool to match definition in dwarf2read.c.
2360
2361 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2362
2363         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2364         (print_signatures): Likewise.
2365         (trust_pad_over_xvs): Likewise.
2366         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2367         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2368         * arm-linux-nat.c (arm_apcs_32): Likewise.
2369         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2370         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2371         * arm-tdep.c (arm_debug): Likewise.
2372         (arm_apcs_32): Likewise.
2373         * auto-load.c (debug_auto_load): Likewise.
2374         (auto_load_gdb_scripts): Likewise.
2375         (global_auto_load): Likewise.
2376         (auto_load_local_gdbinit): Likewise.
2377         (auto_load_local_gdbinit_loaded): Likewise.
2378         * auto-load.h (global_auto_load): Likewise.
2379         (auto_load_local_gdbinit): Likewise.
2380         (auto_load_local_gdbinit_loaded): Likewise.
2381         * breakpoint.c (disconnected_dprintf): Likewise.
2382         (breakpoint_proceeded): Likewise.
2383         (automatic_hardware_breakpoints): Likewise.
2384         (always_inserted_mode): Likewise.
2385         (target_exact_watchpoints): Likewise.
2386         (_initialize_breakpoint): Update.
2387         * breakpoint.h (target_exact_watchpoints): Change to bool.
2388         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2389         * cli/cli-cmds.c (trace_commands): Likewise.
2390         * cli/cli-cmds.h (trace_commands): Likewise.
2391         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2392         to bool*.
2393         * cli/cli-logging.c (logging_overwrite): Change to bool.
2394         (logging_redirect): Likewise.
2395         (debug_redirect): Likewise.
2396         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2397         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2398         to bool.
2399         <boolean_option_def>: Update.
2400         (struct flag_option_def): Change default type of Context to bool
2401         from int.
2402         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2403         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2404         (get_setshow_command_value_string): Likewise.
2405         * cli/cli-style.c (cli_styling): Change to bool.
2406         (source_styling): Likewise.
2407         * cli/cli-style.h (source_styling): Likewise.
2408         (cli_styling): Likewise.
2409         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2410         to bool.
2411         * command.h (var_types): Update comment.
2412         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2413         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2414         bool.
2415         (debug_compile_cplus_scopes): Likewise.
2416         * compile/compile-internal.h (compile_debug): Likewise.
2417         * compile/compile.c (compile_debug): Likewise.
2418         (struct compile_options) <raw>: Likewise.
2419         * cp-support.c (catch_demangler_crashes): Likewise.
2420         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2421         (usr_cmd_cris_dwarf2_cfi): Likewise.
2422         * csky-tdep.c (csky_debug): Likewise.
2423         * darwin-nat.c (enable_mach_exceptions): Likewise.
2424         * dcache.c (dcache_enabled_p): Likewise.
2425         * defs.h (info_verbose): Likewise.
2426         * demangle.c (demangle): Likewise.
2427         (asm_demangle): Likewise.
2428         * dwarf-index-cache.c (debug_index_cache): Likewise.
2429         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2430         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2431         * dwarf2read.c (check_physname): Likewise.
2432         (use_deprecated_index_sections): Likewise.
2433         (dwarf_always_disassemble): Likewise.
2434         * eval.c (overload_resolution): Likewise.
2435         * event-top.c (set_editing_cmd_var): Likewise.
2436         (exec_done_display_p): Likewise.
2437         * event-top.h (set_editing_cmd_var): Likewise.
2438         (exec_done_display_p): Likewise.
2439         * exec.c (write_files): Likewise.
2440         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2441         (debug_fbsd_nat): Likewise.
2442         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2443         Likewise.
2444         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2445         <backtrace_past_entry> Likewise.
2446         * gdb-demangle.h (demangle): Likewise.
2447         (asm_demangle): Likewise.
2448         * gdb_bfd.c (bfd_sharing): Likewise.
2449         * gdbcore.h (write_files): Likewise.
2450         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2451         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2452         * gdbthread.h (print_thread_events): Likewise.
2453         * gdbtypes.c (opaque_type_resolution): Likewise.
2454         (strict_type_checking): Likewise.
2455         * gnu-nat.c (gnu_debug_flag): Likewise.
2456         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2457         * guile/scm-param.c (pascm_variable): Add boolval.
2458         (add_setshow_generic): Update.
2459         (pascm_param_value): Update.
2460         (pascm_set_param_value_x): Update.
2461         * hppa-tdep.c (hppa_debug): Change to bool..
2462         * infcall.c (may_call_functions_p): Likewise.
2463         (coerce_float_to_double_p): Likewise.
2464         (unwind_on_signal_p): Likewise.
2465         (unwind_on_terminating_exception_p): Likewise.
2466         * infcmd.c (startup_with_shell): Likewise.
2467         * inferior.c (print_inferior_events): Likewise.
2468         * inferior.h (startup_with_shell): Likewise.
2469         (print_inferior_events): Likewise.
2470         * infrun.c (step_stop_if_no_debug): Likewise.
2471         (detach_fork): Likewise.
2472         (debug_displaced): Likewise.
2473         (disable_randomization): Likewise.
2474         (non_stop): Likewise.
2475         (non_stop_1): Likewise.
2476         (observer_mode): Likewise.
2477         (observer_mode_1): Likewise.
2478         (set_observer_mode): Update.
2479         (sched_multi): Change to bool.
2480         * infrun.h (debug_displaced): Likewise.
2481         (sched_multi): Likewise.
2482         (step_stop_if_no_debug): Likewise.
2483         (non_stop): Likewise.
2484         (disable_randomization): Likewise.
2485         * linux-tdep.c (use_coredump_filter): Likewise.
2486         (dump_excluded_mappings): Likewise.
2487         * linux-thread-db.c (auto_load_thread_db): Likewise.
2488         (check_thread_db_on_load): Likewise.
2489         * main.c (captured_main_1): Update.
2490         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2491         xx2_opt, boolean_opt>: Change to bool.
2492         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2493         * maint.c (maintenance_profile_p): Likewise.
2494         (per_command_time): Likewise.
2495         (per_command_space): Likewise.
2496         (per_command_symtab): Likewise.
2497         * memattr.c (inaccessible_by_default): Likewise.
2498         * mi/mi-main.c (mi_async): Likewise.
2499         (mi_async_1): Likewise.
2500         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2501         * nat/fork-inferior.h (startup_with_shell): Likewise.
2502         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2503         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2504         * nios2-tdep.c (nios2_debug): Likewise.
2505         * or1k-tdep.c (or1k_debug): Likewise.
2506         * parse.c (parser_debug): Likewise.
2507         * parser-defs.h (parser_debug): Likewise.
2508         * printcmd.c (print_symbol_filename): Likewise.
2509         * proc-api.c (procfs_trace): Likewise.
2510         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2511         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2512         (set_parameter_value): Update.
2513         (add_setshow_generic): Update.
2514         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2515         to bool*.
2516         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2517         int*.
2518         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2519         * record-btrace.c (record_btrace_target::store_registers): Update.
2520         * record-full.c (record_full_memory_query): Change to bool.
2521         (record_full_stop_at_limit): Likewise.
2522         * record-full.h (record_full_memory_query): Likewise.
2523         * remote-notif.c (notif_debug): Likewise.
2524         * remote-notif.h (notif_debug): Likewise.
2525         * remote.c (use_range_stepping): Likewise.
2526         (interrupt_on_connect): Likewise.
2527         (remote_break): Likewise.
2528         * ser-tcp.c (tcp_auto_retry): Likewise.
2529         * ser-unix.c (serial_hwflow): Likewise.
2530         * skip.c (debug_skip): Likewise.
2531         * solib-aix.c (solib_aix_debug): Likewise.
2532         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2533         (spu_auto_flush_cache_p): Likewise.
2534         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2535         Likewise.
2536         (struct info_print_options) <quiet>: Likewise.
2537         * symfile-debug.c (debug_symfile): Likewise.
2538         * symfile.c (auto_solib_add): Likewise.
2539         (separate_debug_file_debug): Likewise.
2540         * symfile.h (auto_solib_add): Likewise.
2541         (separate_debug_file_debug): Likewise.
2542         * symtab.c (basenames_may_differ): Likewise.
2543         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2544         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2545         (struct info_types_options) <quiet>: Likewise.
2546         * symtab.h (demangle): Likewise.
2547         (basenames_may_differ): Likewise.
2548         * target-dcache.c (stack_cache_enabled_1): Likewise.
2549         (code_cache_enabled_1): Likewise.
2550         * target.c (trust_readonly): Likewise.
2551         (may_write_registers): Likewise.
2552         (may_write_memory): Likewise.
2553         (may_insert_breakpoints): Likewise.
2554         (may_insert_tracepoints): Likewise.
2555         (may_insert_fast_tracepoints): Likewise.
2556         (may_stop): Likewise.
2557         (auto_connect_native_target): Likewise.
2558         (target_stop_and_wait): Update.
2559         (target_async_permitted): Change to bool.
2560         (target_async_permitted_1): Likewise.
2561         (may_write_registers_1): Likewise.
2562         (may_write_memory_1): Likewise.
2563         (may_insert_breakpoints_1): Likewise.
2564         (may_insert_tracepoints_1): Likewise.
2565         (may_insert_fast_tracepoints_1): Likewise.
2566         (may_stop_1): Likewise.
2567         * target.h (target_async_permitted): Likewise.
2568         (may_write_registers): Likewise.
2569         (may_write_memory): Likewise.
2570         (may_insert_breakpoints): Likewise.
2571         (may_insert_tracepoints): Likewise.
2572         (may_insert_fast_tracepoints): Likewise.
2573         (may_stop): Likewise.
2574         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2575         (make_thread_apply_all_options_def_group): Change argument from int*
2576         to bool*.
2577         (thread_apply_all_command): Update.
2578         (print_thread_events): Change to bool.
2579         * top.c (confirm): Likewise.
2580         (command_editing_p): Likewise.
2581         (history_expansion_p): Likewise.
2582         (write_history_p): Likewise.
2583         (info_verbose): Likewise.
2584         * top.h (confirm): Likewise.
2585         (history_expansion_p): Likewise.
2586         * tracepoint.c (disconnected_tracing): Likewise.
2587         (circular_trace_buffer): Likewise.
2588         * typeprint.c (print_methods): Likewise.
2589         (print_typedefs): Likewise.
2590         * utils.c (debug_timestamp): Likewise.
2591         (sevenbit_strings): Likewise.
2592         (pagination_enabled): Likewise.
2593         * utils.h (sevenbit_strings): Likewise.
2594         (pagination_enabled): Likewise.
2595         * valops.c (overload_resolution): Likewise.
2596         * valprint.h (struct value_print_options) <prettyformat_arrays,
2597         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2598         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2599         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2600         Likewise.
2601         * windows-nat.c (new_console): Likewise.
2602         (cygwin_exceptions): Likewise.
2603         (new_group): Likewise.
2604         (debug_exec): Likewise.
2605         (debug_events): Likewise.
2606         (debug_memory): Likewise.
2607         (debug_exceptions): Likewise.
2608         (useshell): Likewise.
2609         * windows-tdep.c (maint_display_all_tib): Likewise.
2610         * xml-support.c (debug_xml): Likewise.
2611
2612 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2613
2614         * source.c (prepare_path_for_appending): New function.
2615         (openp): Make use of new function.
2616         (find_and_open_source): Search for the compilation directory and
2617         source file as a relative path beneath the directory search path.
2618
2619 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * source-cache.c (source_cache::get_line_charpos): Catch
2622         exceptions and return false, this matches the behaviour documented
2623         in the header file.
2624
2625 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2626
2627         * ada-tasks.c (info_task): Remove quoting of the task's name.
2628
2629 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2630
2631         * symfile.c (auto_solib_add): Replace comment with a reference
2632         to the header file.
2633
2634 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2635
2636         * NEWS: Mention that gdb can now be compiled with Python 3
2637         on Windows.
2638
2639 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2640
2641         * maint.c (maint_print_section_data::maint_print_section_data):
2642         Force use of 'float log10 (float)' by casting the argument to
2643         float.
2644
2645 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2646
2647         * maint.c: Add 'cmath' include.
2648         (struct maint_print_section_data): New structure.
2649         (print_section_index): New function.
2650         (print_bfd_section_info): Add header comment, small whitespace
2651         cleanup, and update to call new print_section_index function.
2652         (print_objfile_section_info): Likewise.
2653         (maint_obj_section_from_bfd_section): New function.
2654         (print_bfd_section_info_maybe_relocated): New function.
2655         (maintenance_info_sections): Add header comment, always use
2656         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2657
2658 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2659
2660         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2661         inner scope, add check that the objfile has psymtabs before
2662         checking psymtabs_addrmap.
2663         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2664
2665 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2666
2667         * NEWS: Announce that Ada task names are now shown at more places,
2668         and between quotes (except in info task output).
2669         * gdb/ada-tasks.c (task_to_str): New function.
2670         (display_current_task_id): Call task_to_str.
2671         (task_command_1): Likewise.
2672         (print_ada_task_info): In non-mi mode, Properly align headers and data
2673         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2674
2675 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2676
2677         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2678         prstatus.pr_lwp.pr_info instead of making it up.
2679
2680 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2681
2682         * auto-load.c (auto_load_expand_dir_vars): Update.
2683         * defs.h (gdb_datadir): Change to std::string.
2684         (python_libdir): Likewise.
2685         (relocate_gdb_directory): Change return type to std::string.
2686         * guile/guile.c (gdbscm_data_directory): Update.
2687         (initialize_scheme_side): Update.
2688         * jit.c (jit_reader_dir): Change to std::string.
2689         (jit_reader_load_command): Update.
2690         * main.c (gdb_datadir): Change to std::string.
2691         (python_libdir): Likewise.
2692         (set_gdb_data_directory): Update.
2693         (relocate_path): Change to return std::string.
2694         (relocate_gdb_directory): Change to return std::string.
2695         (relocate_gdbinit_path_maybe_in_datadir): Update.
2696         (captured_main_1): Update.
2697         * python/python.c (do_start_initialization): Update.
2698         * top.c (show_gdb_datadir): Update.
2699         * xml-syscall.c (xml_init_syscalls_info): Update.
2700         (init_syscalls_info): Update.
2701
2702 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2703
2704         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2705         out of get_init_files.
2706         (get_init_files): Update.
2707
2708 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2709
2710         * main.c (get_init_files): Change to use std::string.
2711         (captured_main_1): Update.
2712         (print_gdb_help): Update.
2713
2714 2019-09-11  Ali Tamur  <tamur@google.com>
2715
2716         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2717         implementation.
2718
2719 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2720
2721         * dbxread.c (read_dbx_symtab): Update.
2722         * dwarf2read.c (load_partial_dies): Update.
2723         * mdebugread.c (parse_partial_symbols): Update.
2724         (handle_psymbol_enumerators): Update.
2725         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2726         * psymtab.c (add_psymbol_to_bcache): Likewise.
2727         (add_psymbol_to_list): Likewise.
2728         * symtab.c (symbol_set_names): Likewise.
2729         * symtab.h (symbol_set_names): Likewise.
2730         * xcoffread.c (scan_xcoff_symtab): Update.
2731
2732 2019-09-11  Tom Tromey  <tom@tromey.com>
2733
2734         * symfile-mem.c (symbol_file_add_from_memory): Use
2735         bfd_set_filename.
2736         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2737         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2738
2739 2019-09-10  Tom Tromey  <tromey@adacore.com>
2740
2741         * dwarf-index-write.c (write_psymbols): Extend error message.
2742         (debug_names::insert): Add Ada code.
2743         (debug_names::write_psymbols): Remove Ada check.
2744         (debug_names) <m_string_obstack>: New member.
2745         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2746         (gdb_index_symbol_name_matcher::matches): Remove.
2747         (mapped_index_base::find_name_components_bounds): Add "lang"
2748         parameter.
2749         (mapped_index_base::build_name_components): Also split names
2750         according to Ada syntax.
2751         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2752         type of "match_callback".
2753         (check_match, check_find_bounds_finds)
2754         (dw2_expand_symtabs_matching): Update.
2755         (dw2_debug_names_iterator): Add new constructor.
2756         (dw2_debug_names_map_matching_symbols): New function.
2757         (dw2_debug_names_expand_symtabs_matching): Update.
2758         (dwarf2_debug_names_functions): Use
2759         dw2_debug_names_map_matching_symbols.
2760
2761 2019-09-10  Tom Tromey  <tromey@adacore.com>
2762
2763         * dwarf2read.c (dw2_get_file_names_reader): Add the
2764         CU's file name to the results.
2765
2766 2019-09-10  Tom Tromey  <tromey@adacore.com>
2767
2768         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2769         map_matching_symbols.  Update.
2770         * dwarf2read.c (dw2_map_matching_symbols): Update.
2771         * psymtab.c (match_partial_symbol): Change type; update.
2772         (psym_map_matching_symbols): Likewise.
2773         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2774         type; update.
2775         * symfile.h (struct quick_symbol_functions)
2776         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2777         Remove "match".
2778
2779 2019-09-10  Tom Tromey  <tromey@adacore.com>
2780
2781         * psymtab.c (map_block): Remove.
2782         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2783         * symtab.c (iterate_over_symbols_terminated): New function.
2784         * symtab.c (iterate_over_symbols_terminated): Declare.
2785
2786 2019-09-10  Tom Tromey  <tromey@adacore.com>
2787
2788         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2789         * language.h (struct language_defn) <la_iterate_over_symbols>:
2790         Return bool.
2791         * symtab.c (iterate_over_symbols): Return bool.
2792         * symtab.h (iterate_over_symbols): Return bool.
2793
2794 2019-09-10  Tom Tromey  <tromey@adacore.com>
2795
2796         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2797         (add_nonlocal_symbols): Update.
2798         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2799         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2800         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2801         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2802         Change type of "callback".  Remove "data".
2803
2804
2805 2019-09-09  Ali Tamur  <tamur@google.com>
2806
2807         * dwarf2read.c (comp_unit_head): Update comment.
2808         (dwarf2_dwo_name): New function declaration.
2809         (dwarf_unit_type_name): New function declaration.
2810         (read_comp_unit_head): Add support for new compilation units,
2811         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2812         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2813         (currently named as "signature") in their header. Also clarify error
2814         messages.
2815         (lookup_dwo_id): New function. Returns the dwo id of the given
2816         compile unit.
2817         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2818         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2819         functions.
2820         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2821         (dwarf2_dwo_name): Get the dwo name if present.
2822         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2823         purposes.
2824
2825 2019-09-09  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2828
2829 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2830
2831         * python/python.c (do_start_initialization): Make progname_copy static,
2832         to avoid a leak report.
2833
2834 2019-09-08  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2837
2838 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2839
2840         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2841         Change type to gdb::optional<block_enum>.
2842         (dw2_symtab_iter_init): Change block_index parameter type
2843         to gdb::optional<block_enum>.
2844         (dw2_lookup_symbol): Change block_index parameter
2845         type to block_enum.c
2846         (dw2_debug_names_lookup_symbol): Likewise.
2847         * psymtab.c (psym_lookup_symbol): Likewise.
2848         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2849         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2850         Likewise.
2851
2852 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2853
2854         * defs.h (relocate_gdb_directory): Change int to bool in
2855         signature and rename flag to relocatable.
2856         * main.c (relocate_path): Likewise.
2857         (relocate_gdb_directory): Likewise.
2858
2859 2019-09-06  Alan Modra  <amodra@gmail.com>
2860
2861         * coffread.c (coff_symfile_read): Constify filename variable.
2862         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2863         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2864         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2865         * solib.c (reload_shared_libraries_1): Likewise.
2866         * symfile.c (reread_symbols): Likewise.
2867         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2868         * solib-darwin.c (darwin_bfd_open): Likewise.
2869         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2870
2871 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2872
2873         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2874         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2875
2876 2019-09-03  Tom Tromey  <tromey@adacore.com>
2877
2878         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2879         types.
2880         (has_negatives): Unbias a range type bound.
2881         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2882         * gdbtypes.c (operator==): Handle new field.
2883         (create_range_type): Add "bias" parameter.
2884         (create_static_range_type, resolve_dynamic_range): Update.
2885         * gdbtypes.h (struct range_bounds) <bias>: New member.
2886         (create_range_type): Add bias parameter.
2887         * printcmd.c (print_scalar_formatted): Unbias range types.
2888         * value.c (unpack_long): Unbias range types.
2889         (pack_long): Bias range types.
2890
2891 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2892
2893         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2894         probe arguments.
2895
2896 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2897
2898         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2899         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2900         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2901         (compile_probe_arg): Likewise.
2902         * probe.h (get_argument_count): Likewise.
2903         * solib-svr4.c (solib_event_probe_action): Likewise.
2904         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2905
2906 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2907
2908         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2909         code to here...
2910         (svr4_create_solib_event_breakpoints): ...from here.
2911
2912 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2913
2914         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2915         suffix from warning message.
2916
2917 2019-08-30  Tom Tromey  <tom@tromey.com>
2918
2919         * tui/tui-winsource.h (struct tui_source_window_base)
2920         <refresh_all>: Don't declare.
2921         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2922         Remove.
2923         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2924         tui_show_locator_content.
2925         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2926         declare.
2927         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2928         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2929         declare.
2930
2931 2019-08-30  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2934
2935 2019-08-30  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2938         Remove unnecessary forward declarations.
2939
2940 2019-08-30  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2943         rerender.
2944         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2945         tui_show_locator_content.
2946
2947 2019-08-30  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2950         (tui_locator_window::rerender): Rewrite using body of previous
2951         tui_show_locator_content.
2952
2953 2019-08-30  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2956         set_locator_fullname>: New methods.
2957         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2958         Rename from tui_set_locator_fullname.
2959         (tui_locator_window::set_locator_info): Rename from
2960         tui_set_locator_info.  Return bool.
2961         (tui_update_locator_fullname, tui_show_frame_info): Update.
2962
2963 2019-08-30  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2966
2967 2019-08-30  Tom Tromey  <tom@tromey.com>
2968
2969         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2970         call touchwin.
2971
2972 2019-08-30  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-wingeneral.c (box_win): Assume win_info and
2975         win_info->handle cannot be NULL.
2976
2977 2019-08-30  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2980         refresh_window>: Declare.
2981         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2982         resize.
2983         (tui_data_item_window::rerender): Rename from
2984         tui_display_register.
2985         (tui_data_item_window::refresh_window): New method.
2986         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2987         no-op.
2988
2989 2019-08-30  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2992         regs_column_count, current_group>: Move later.  Now private.
2993         <get_current_group>: New method.
2994         * tui/tui-regs.c (tui_reg_command): Update.
2995         * tui/tui-layout.c (tui_set_layout): Update.
2996
2997 2019-08-30  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3000         (tui_data_window::rerender): Don't call
3001         check_and_display_highlight_if_needed.
3002         (tui_data_window::refresh_all): Remove call to
3003         erase_data_content.
3004
3005 2019-08-30  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3008         (tui_data_window::display_registers_from)
3009         (tui_data_window::display_reg_element_at_line)
3010         (tui_data_window::display_registers_from_line): Remove checks of
3011         "empty".
3012
3013 2019-08-30  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3016         Don't declare.
3017         * tui/tui-regs.c (tui_data_window::show_registers): Call
3018         rerender.
3019         (tui_data_window::rerender): Rename from display_all_data.
3020         (tui_data_window::rerender): Remove old implementation.
3021
3022 2019-08-30  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3025         text.
3026         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3027
3028 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3029             Sergio Durigan Junior  <sergiodj@redhat.com>
3030
3031         PR win32/24284
3032         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3033
3034 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3037         when searching for types.
3038
3039 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3040
3041         * f-lang.c (f_language_defn): Use f_print_typedef.
3042         * f-lang.h (f_print_typedef): Declare.
3043         * f-typeprint.c (f_print_typedef): Define.
3044
3045 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3046
3047         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3048
3049 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3050
3051         * cli/cli-utils.c (info_print_options_defs): Delete.
3052         (make_info_print_options_def_group): Delete.
3053         (extract_info_print_options): Delete.
3054         (info_print_command_completer): Delete.
3055         (info_print_args_help): Add extra parameter, and optionally
3056         include text about -n flag.
3057         * cli/cli-utils.h (struct info_print_options): Delete.
3058         (extract_info_print_options): Delete declaration.
3059         (info_print_command_completer): Delete declaration.
3060         (info_print_args_help): Add extra parameter, extend header
3061         comment.
3062         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3063         search_symbols.
3064         * stack.c (struct info_print_options): New type.
3065         (info_print_options_defs): New file scoped variable.
3066         (make_info_print_options_def_group): New static function.
3067         (info_print_command_completer): New static function.
3068         (info_locals_command): Update to use new local functions.
3069         (info_args_command): Likewise.
3070         (_initialize_stack): Add extra parameter to calls to
3071         info_print_args_help.
3072         * symtab.c (search_symbols): Add extra parameter, use this to
3073         possibly excluse non-debug symbols.
3074         (symtab_symbol_info): Add extra parameter, which is passed on to
3075         search_symbols.
3076         (struct info_print_options): New type.
3077         (info_print_options_defs): New file scoped variable.
3078         (make_info_print_options_def_group): New static function.
3079         (info_print_command_completer): New static function.
3080         (info_variables_command): Update to use local functions, and pass
3081         extra parameter through to symtab_symbol_info.
3082         (info_functions_command): Likewise.
3083         (info_types_command): Pass additional argument through to
3084         symtab_symbol_info.
3085         (rbreak_command): Pass extra argument to search_symbols.
3086         (_initialize_symtab): Add extra arguments for calls to
3087         info_print_args_help, and update help text for 'info variables',
3088         'whereis', and 'info functions' commands.
3089         * symtab.h (search_symbols): Add extra argument to declaration.
3090         * NEWS: Mention new flags.
3091
3092 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3093
3094         * symtab.c (lookup_static_symbol): Call the new function (and move
3095         it down to be next to lookup_global_symbol).
3096         (struct global_sym_lookup_data): Add block_enum member and rename to...
3097         (struct global_or_static_sym_lookup_data): ...this.
3098         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3099         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3100         (lookup_symbol_global_or_static_iterator_cb): ...this.
3101         (lookup_global_or_static_symbol): New function.
3102         (lookup_global_symbol): Call new function.
3103
3104 2019-08-26  Tom de Vries  <tdevries@suse.de>
3105
3106         PR c++/24852
3107         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3108         when pc_probe.prob == NULL.
3109
3110 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3111
3112         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3113         variable symbol_linkage to symbol_linkage_.
3114
3115 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3116
3117         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3118         represent whether the symbol is static, dynamic, or we don't
3119         know.
3120
3121 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3122
3123         * gdb/rx-tdep.c (rx_register_names): New.
3124         (rx_register_name): Delete.
3125         (rx_psw_type): Delete.
3126         (rx_fpsw_type): Delete.
3127         (rx_register_type): Delete.
3128         (rx_gdbarch_init): Convert target-descriptions.
3129         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3130         * gdb/features/Makefile: Add rx.xml.
3131         * gdb/features/rx.xml: New.
3132         * gdb/features/rx.c: Generated.
3133         * gdb/NEWS: Mention target description support.
3134
3135 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3136
3137         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3138         *slot_ptr.
3139
3140 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3141
3142         * configure.ac: Don't check for 'dlfcn.h' (moved to
3143         gdbsupport/common.m4).
3144         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3145         'gdbsupport/'.
3146         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3147         * compile/compile-c-support.c: Include
3148         'gdbsupport/gdb-dlfcn.h'.
3149         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3150         * gdb-dlfcn.c: Move to...
3151         * gdbsupport/gdb-dlfcn.c: ... here.
3152         * gdb-dlfcn.h: Move to...
3153         * gdbsupport/gdb-dlfcn.h: ... here.
3154
3155 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3156
3157         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3158         the offset field signed.
3159
3160 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3161
3162         * python/lib/gdb/__init__.py (_execute_file): New function.
3163         * python/python.c (python_run_simple_file): Call gdb._execute_file
3164         on Windows.
3165
3166 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3167
3168         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3169         all uses as this was never set to anything but a zero value.
3170
3171 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3172
3173         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3174
3175 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3176
3177         * tui/tui-data.h (tui_gen_win_info): Add an =default
3178         move constructor, required by some GCC versions.
3179
3180 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3181
3182         * go32-nat.c (go32_sysinfo): Add hygon_p.
3183
3184 2019-08-20  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3187         line_from_reg_element_no, first_reg_element_no_inline,
3188         display_all_data, delete_data_content_windows,
3189         erase_data_content>: Now private.
3190
3191 2019-08-20  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3194         (tui_unhighlight_win, tui_highlight_win)
3195         (tui_win_info::make_window): Update.
3196         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3197
3198 2019-08-20  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3201         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3202         (MAX_PID_WIDTH): Move to tui-stack.c.
3203         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3204         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3205         (MAX_PID_WIDTH): Move from tui-data.h.
3206
3207 2019-08-20  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3210         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3211         (box_win): Update.
3212         (tui_gen_win_info::make_window): Rename from tui_make_window.
3213         (tui_win_info::make_window): New method.
3214         (tui_gen_win_info::make_visible): Update.
3215         * tui/tui-source.c (tui_source_window::set_contents): Update.
3216         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3217         (tui_data_window::display_registers_from): Update.
3218         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3219         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3220         Declare.
3221         <can_box>: Remove.
3222         <title>: Remove.
3223         (struct tui_win_info) <make_window>: Declare.
3224         <can_box>: Now virtual.
3225         <title>: New member.
3226         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3227         * tui/tui-command.c (tui_cmd_window::resize): Update.
3228
3229 2019-08-20  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3232         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3233         (tui_data_window::check_register_values): Update.
3234
3235 2019-08-20  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-regs.h (struct tui_data_window): Use
3238         DISABLE_COPY_AND_ASSIGN.
3239         <regs_content>: Change type, removing unique_ptr.
3240         <tui_data_window>: Add move constructor.
3241         * tui/tui-regs.c (tui_data_window::show_registers)
3242         (tui_data_window::show_register_group)
3243         (tui_data_window::display_registers_from)
3244         (tui_data_window::display_registers_from)
3245         (tui_data_window::first_data_item_displayed)
3246         (tui_data_window::delete_data_content_windows)
3247         (tui_data_window::rerender, tui_data_window::refresh_window)
3248         (tui_data_window::check_register_values): Update.
3249
3250 2019-08-20  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3253         show_register_group>: Declare.
3254         (tui_show_register_group): Don't declare.
3255         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3256         tui_show_registers.
3257         (tui_data_window::show_register_group): Rename from
3258         tui_show_register_group.
3259         (tui_data_window::check_register_values, tui_reg_command):
3260         Update.
3261         * tui/tui-layout.c (tui_set_layout): Update.
3262
3263 2019-08-20  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3266         Declare.
3267         (tui_check_register_values): Don't declare.
3268         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3269         from tui_check_register_values.
3270         * tui/tui-hooks.c (tui_register_changed): Update.
3271
3272 2019-08-20  Tom Tromey  <tom@tromey.com>
3273
3274         * tui/tui-regs.c (tui_reg_layout): Move later.
3275         (tui_show_registers): Don't enable TUI mode or change layout.
3276
3277 2019-08-20  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-regs.h (struct tui_data_item_window)
3280         <~tui_data_item_window>: Remove.
3281         <content>: Now a unique_xmalloc_ptr.
3282         * tui/tui-regs.c (tui_register_format): Return a
3283         unique_xmalloc_ptr.
3284         (tui_get_register): Update.
3285         (~tui_data_item_window): Remove.
3286         (tui_data_window::display_registers_from, tui_display_register):
3287         Update.
3288         * tui/tui-io.h (tui_expand_tabs): Update.
3289         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3290         Remove "col" parameter.
3291
3292 2019-08-20  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3295         field.
3296         * tui/tui-regs.c (~tui_data_item_window): Update.
3297
3298 2019-08-20  Tom Tromey  <tom@tromey.com>
3299
3300         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3301         earlier.
3302
3303 2019-08-20  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3306
3307 2019-08-20  Tom Tromey  <tom@tromey.com>
3308
3309         * tui/tui-source.h (struct tui_source_window): Update.
3310         * tui/tui-regs.c (tui_show_registers): Update.
3311         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3312         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3313         (NO_REGS_STRING): Remove defines.
3314
3315 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3316
3317         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3318         unnecessary thread walk if remote doesn't support the packet.
3319
3320 2019-08-19  Tom Tromey  <tromey@adacore.com>
3321
3322         * python/py-value.c (value_has_field): Fix indentation.
3323
3324 2019-08-19  Tom Tromey  <tromey@adacore.com>
3325
3326         * printcmd.c (do_one_display, info_display_command): Update.
3327         * block.h (contained_in): Return bool.  Add allow_nested
3328         parameter.
3329         * block.c (contained_in): Return bool.  Add allow_nested
3330         parameter.
3331
3332 2019-08-19  Tom Tromey  <tom@tromey.com>
3333
3334         * configure: Rebuild.
3335         * configure.ac: Disallow the combination of -static-libstdc++ and
3336         source highlight.
3337         * source-cache.c (get_language_name): Handle rust.
3338         (source_cache::get_source_lines): Ignore highlighting exceptions.
3339
3340 2019-08-16  Tom Tromey  <tom@tromey.com>
3341
3342         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3343         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3344         (struct tui_source_window_base) <make_visible, refresh_window,
3345         resize>: Remove methods.
3346         <execution_info>: Remove field.
3347         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3348         (tui_show_source_line, tui_source_window_base)
3349         (~tui_source_window_base): Update.
3350         (tui_source_window_base::resize)
3351         (tui_source_window_base::make_visible)
3352         (tui_source_window_base::refresh_window): Remove.
3353         (tui_source_window_base::update_exec_info): Update.
3354         * tui/tui-source.c (tui_source_window::set_contents): Update.
3355         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3356
3357 2019-08-16  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3360         deprecated_query_hook.
3361
3362 2019-08-16  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3365         (tui_update_source_windows_with_line): Update.
3366         * tui/tui-source.h (struct tui_source_window)
3367         <show_symtab_source>: Declare.
3368         (tui_show_symtab_source): Don't declare.
3369         * tui/tui-source.c (tui_show_symtab_source): Rename from
3370         tui_show_symtab_source.
3371
3372 2019-08-16  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui-winsource.h (struct tui_source_window_base)
3375         <set_contents>: Declare.
3376         * tui/tui-winsource.c
3377         (tui_source_window_base::update_source_window_as_is): Update.
3378         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3379         Declare.
3380         (tui_set_source_content): Don't declare.
3381         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3382         tui_set_source_content.
3383         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3384         Declare.
3385         (tui_set_disassem_content): Don't declare.
3386         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3387         tui_set_disassem_content.
3388
3389 2019-08-16  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-winsource.h (struct tui_source_window_base)
3392         <update_breakpoint_info>: Declare.
3393         (tui_update_breakpoint_info): Don't declare.
3394         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3395         (tui_update_all_breakpoint_info): Update.
3396         (tui_source_window_base::update_breakpoint_info): Rename from
3397         tui_update_breakpoint_info.
3398         (tui_source_window_base::update_exec_info): Update.
3399
3400 2019-08-16  Tom Tromey  <tom@tromey.com>
3401
3402         * tui/tui-winsource.h (struct tui_source_window_base)
3403         <update_source_window>: Declare.
3404         (tui_update_source_window): Don't declare.
3405         * tui/tui-winsource.c
3406         (tui_source_window_base::update_source_window): Rename from
3407         tui_update_source_window.
3408         (tui_source_window_base::rerender): Update.
3409         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3410         * tui/tui-disasm.c (tui_show_disassem)
3411         (tui_show_disassem_and_update_source)
3412         (tui_disasm_window::maybe_update): Update.
3413
3414 2019-08-16  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui-winsource.h (struct tui_source_window_base)
3417         <update_source_window_as_is>: Declare.
3418         (tui_update_source_window_as_is): Don't declare.
3419         * tui/tui-winsource.c (tui_update_source_window): Update
3420         (tui_source_window_base::update_source_window_as_is): Rename from
3421         tui_update_source_window_as_is.
3422         (tui_source_window_base::refill): Update.
3423         * tui/tui-source.c (tui_show_symtab_source): Update.
3424         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3425         Update.
3426
3427 2019-08-16  Tom Tromey  <tom@tromey.com>
3428
3429         * tui/tui-winsource.h (tui_update_source_window)
3430         (tui_update_source_window_as_is): Remove "noerror" parameter.
3431         * tui/tui-winsource.c (tui_update_source_window)
3432         (tui_update_source_window_as_is): Remove "noerror" parameter.
3433         (tui_update_source_windows_with_addr)
3434         (tui_update_source_windows_with_line)
3435         (tui_source_window_base::rerender)
3436         (tui_source_window_base::refill): Update.
3437         * tui/tui-source.h (tui_set_source_content)
3438         (tui_show_symtab_source): Remove "noerror" parameter.
3439         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3440         parameter.
3441         (tui_show_symtab_source): Likewise.
3442         (tui_source_window::maybe_update): Update.
3443         * tui/tui-disasm.c (tui_show_disassem)
3444         (tui_show_disassem_and_update_source)
3445         (tui_disasm_window::do_scroll_vertical)
3446         (tui_disasm_window::maybe_update): Update.
3447
3448 2019-08-16  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui.c (tui_is_window_visible): Update.
3451         * tui/tui-wingeneral.c (tui_make_window)
3452         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3453         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3454         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3455         (tui_set_win_height_command, parse_scrolling_args): Update.
3456         * tui/tui-source.c (tui_source_window::style_changed): Update.
3457         * tui/tui-regs.c (tui_show_registers)
3458         (tui_data_window::first_data_item_displayed)
3459         (tui_data_window::delete_data_content_windows)
3460         (tui_check_register_values, tui_reg_command): Update.
3461         * tui/tui-disasm.c (tui_show_disassem): Update.
3462         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3463         method.
3464         <is_visible>: Remove field.
3465         * tui/tui-data.c (tui_next_win, tui_prev_win)
3466         (tui_delete_invisible_windows): Update.
3467
3468 2019-08-16  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-winsource.h (struct tui_source_window_base)
3471         <m_has_locator>: Remove.
3472         * tui/tui-layout.c (show_source_disasm_command, show_data)
3473         (show_source_or_disasm_and_command): Update.
3474
3475 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3476
3477         * NEWS (Other MI changes): New subsection.
3478         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3479         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3480         * arch-utils.c (default_get_pc_address_flags): New function.
3481         * arch-utils.h (default_get_pc_address_flags): New declaration.
3482         * gdbarch.sh: Add get_pc_address_flags.
3483         * gdbarch.c: Regenerate.
3484         * gdbarch.h: Likewise.
3485         * stack.c (print_pc): New function.
3486         (print_frame_info) (print_frame): Call print_pc.
3487
3488 2019-08-16  Tom de Vries  <tdevries@suse.de>
3489
3490         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3491         print_objfile_section_info.
3492
3493 2019-08-15  Tom Tromey  <tom@tromey.com>
3494
3495         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3496         calling update_cmdwin_start_line.
3497         * tui/tui-winsource.h (struct tui_source_window_base)
3498         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3499         <rerender>: Declare.
3500         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3501         Call rerender.
3502         (tui_source_window_base::set_new_height): Remove.
3503         (tui_source_window_base::rerender): Rename from
3504         do_make_visible_with_new_height.
3505         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3506         resize method.
3507         (tui_win_info::make_invisible_and_set_new_height)
3508         (tui_win_info::make_visible_with_new_height): Remove.
3509         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3510         Declare.
3511         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3512         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3513         do_make_visible_with_new_height>: Don't declare.
3514         <rerender>: Declare.
3515         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3516         set_new_height.
3517         (tui_data_window::do_make_visible_with_new_height): Remove.
3518         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3519         call tui_show_locator_content.
3520         (tui_gen_win_info::resize): Call rerender.
3521         (show_source_or_disasm_and_command): Don't call
3522         tui_show_locator_content.
3523         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3524         method.
3525         (struct tui_win_info) <rerender>: Declare.
3526         <set_new_height, make_invisible_and_set_new_height,
3527         make_visible_with_new_height>: Don't declare.
3528         * tui/tui-data.c (tui_win_list::rerender): New method.
3529         * tui/tui-command.h (struct tui_cmd_window)
3530         <do_make_visible_with_new_height>: Don't declare.
3531         * tui/tui-command.c
3532         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3533
3534 2019-08-15  Tom Tromey  <tromey@adacore.com>
3535
3536         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3537         * ada-lang.c (ada_enum_name): Likewise.
3538
3539 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3540
3541         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3542         leading underscore.
3543         (GdbOutputErrorFile): Likewise.
3544         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3545         accordingly.
3546         (execute_unwinders): Rename to have a leading underscore.
3547         (auto_load_packages): Likewise.
3548         (global scope): Adjust call to auto_load_packages accordingly.
3549         (GdbSetPythonDirectory): Likewise.
3550         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3551         instead of execute_unwinders.
3552
3553 2019-08-15  Tom Tromey  <tom@tromey.com>
3554
3555         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3556         (show_data): Don't change window visibility.
3557         (tui_gen_win_info::resize): Remove special case for command
3558         window.  Use wresize, when available.
3559         (show_source_or_disasm_and_command): Don't change window
3560         visibility.
3561         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3562         <make_visible>: New method.
3563         * tui/tui-command.c (tui_cmd_window::resize): New method.
3564
3565 2019-08-15  Tom Tromey  <tom@tromey.com>
3566
3567         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3568         (struct tui_source_windows): New.
3569         * tui/tui-winsource.c (tui_display_main): Update.
3570         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3571         (new_height_ok, parse_scrolling_args): Update.
3572         * tui/tui-layout.c (show_layout, show_data): Update.
3573         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3574         (tui_add_to_source_windows): Don't declare.
3575         * tui/tui-data.c (source_windows, tui_source_windows)
3576         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3577
3578 2019-08-15  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3581         Rename from reset.
3582         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3583         * tui/tui-layout.c (show_source_disasm_command, show_data):
3584         Update.
3585         (tui_gen_win_info::resize): Rename.
3586         (show_source_or_disasm_and_command): Update.
3587         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3588         reset.
3589
3590 2019-08-15  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3593         * tui/tui-interp.c (tui_interp::init): Don't call
3594         tui_initialize_static_data.
3595         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3596
3597 2019-08-15  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3600         examine tui_win_list.
3601
3602 2019-08-15  Tom Tromey  <tom@tromey.com>
3603
3604         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3605         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3606         tui_clear_source_content.
3607         (tui_clear_source_content): Remove.
3608         (tui_source_window_base::do_erase_source_content): Hoist call to
3609         content.clear().
3610         * tui/tui-stack.c (tui_show_frame_info): Don't call
3611         tui_clear_source_content.
3612
3613 2019-08-15  Tom Tromey  <tom@tromey.com>
3614
3615         * tui/tui-winsource.h (struct tui_source_window_base)
3616         <do_erase_source_content>: New method.
3617         <erase_source_content>: New method.
3618         (tui_erase_source_content): Don't declare.
3619         * tui/tui-winsource.c (tui_clear_source_content): Update.
3620         (tui_source_window_base::do_erase_source_content): Rename from
3621         tui_erase_source_content.
3622         (tui_source_window_base::show_source_content): Update.
3623         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3624         * tui/tui-source.h (struct tui_source_window)
3625         <erase_source_content>: New method.
3626         * tui/tui-disasm.h (struct tui_disasm_window)
3627         <erase_source_content>: New method.
3628
3629 2019-08-15  Tom Tromey  <tom@tromey.com>
3630
3631         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3632         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3633         constructor.
3634         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3635         * tui/tui-source.c (tui_set_source_content): Update.
3636         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3637
3638 2019-08-15  Tom Tromey  <tom@tromey.com>
3639
3640         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3641         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3642         tui-source.c.
3643         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3644         Declare.
3645         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3646         method.
3647         (tui_source_window::maybe_update): Update.
3648
3649 2019-08-15  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3652         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3653         tui-disasm.c.
3654         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3655         Declare.
3656         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3657         method.
3658         (tui_disasm_window::maybe_update): Update.
3659
3660 2019-08-15  Tom Tromey  <tom@tromey.com>
3661
3662         * tui/tui-winsource.h (struct tui_source_window_base)
3663         <maybe_update>: Declare.
3664         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3665         method.
3666         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3667         Declare.
3668         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3669         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3670         Declare.
3671         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3672
3673 2019-08-15  Tom Tromey  <tom@tromey.com>
3674
3675         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3676
3677 2019-08-15  Tom Tromey  <tom@tromey.com>
3678
3679         * tui/tui-wingeneral.c: Include tui-stack.h.
3680         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3681         (struct tui_locator_window): Move from tui-data.h.
3682         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3683         (tui_initialize_static_data): Move from tui-data.c.
3684         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3685         (struct tui_locator_window): Move to tui-stack.c.
3686         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3687         (tui_initialize_static_data): Move to tui-stack.c.
3688
3689 2019-08-15  Tom Tromey  <tom@tromey.com>
3690
3691         * tui/tui-layout.c (show_source_disasm_command)
3692         (show_source_or_disasm_and_command): Use make_visible method, not
3693         tui_make_window.
3694         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3695         Remove.
3696
3697 2019-08-15  Tom Tromey  <tom@tromey.com>
3698
3699         * tui/tui-wingeneral.h (tui_make_window): Update.
3700         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3701         parameter.
3702         (tui_gen_win_info::make_visible): Update.
3703         * tui/tui-regs.c (tui_data_window::display_registers_from):
3704         Update.
3705         * tui/tui-layout.c (show_source_disasm_command)
3706         (show_source_or_disasm_and_command): Update.
3707         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3708         (enum tui_box): Remove.
3709         (struct tui_win_info) <can_box>: New method.
3710         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3711         method.
3712
3713 2019-08-15  Tom de Vries  <tdevries@suse.de>
3714
3715         * linux-nat-trad.c: Include gdbarch.h.
3716
3717 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3718
3719         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3720         register sizes.
3721
3722 2019-08-14  Tom Tromey  <tromey@adacore.com>
3723
3724         * darwin-nat.c: Include gdbarch.h.
3725         * darwin-nat-info.c: Include gdbarch.h.
3726
3727 2019-08-13  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3730         Remove.
3731         * tui/tui-data.c (tui_initialize_static_data): Update.
3732
3733 2019-08-13  Tom Tromey  <tom@tromey.com>
3734
3735         * tui/tui-winsource.h (struct tui_exec_info_window)
3736         <~tui_exec_info_window, maybe_allocate_content, get_content,
3737         m_content>: Remove.
3738         (struct tui_source_window_base) <set_exec_info_content,
3739         show_exec_info_content>: Don't declare.
3740         * tui/tui-winsource.c
3741         (tui_exec_info_window::maybe_allocate_content): Remove.
3742         (tui_source_window_base::update_exec_info): Rename from
3743         set_exec_info_content.
3744         (tui_source_window_base::show_exec_info_content)
3745         (tui_source_window_base::update_exec_info): Remove.
3746
3747 2019-08-13  Tom Tromey  <tom@tromey.com>
3748
3749         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3750         declare.
3751         * tui/tui-winsource.c (tui_update_source_window_as_is)
3752         (tui_update_source_windows_with_addr, tui_erase_source_content):
3753         Update.
3754         (tui_clear_exec_info_content): Remove.
3755
3756 2019-08-13  Tom Tromey  <tom@tromey.com>
3757
3758         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3759         declare.
3760         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3761         call tui_erase_exec_info_content.
3762         (tui_clear_exec_info_content): Rename from
3763         tui_erase_exec_info_content.
3764         (tui_clear_exec_info_content): Delete.
3765
3766 2019-08-13  Tom Tromey  <tom@tromey.com>
3767
3768         * tui/tui-winsource.h (struct tui_source_window_base)
3769         <show_exec_info_content>: Declare.
3770         (tui_show_exec_info_content): Don't declare.
3771         * tui/tui-winsource.c
3772         (tui_source_window_base::show_exec_info_content): Rename from
3773         tui_show_exec_info_content.
3774         (tui_source_window_base::update_exec_info): Update.
3775
3776 2019-08-13  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3779         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3780         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3781         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3782         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3783         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3784         ... here.
3785
3786 2019-08-13  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-winsource.h (struct tui_source_window_base)
3789         <update_exec_info>: Declare.
3790         (tui_update_exec_info): Don't declare.
3791         * tui/tui-winsource.c (tui_update_source_window_as_is)
3792         (tui_source_window_base::refresh_all)
3793         (tui_update_all_breakpoint_info): Update.
3794         (tui_source_window_base::update_exec_info): Rename from
3795         tui_update_exec_info.
3796         * tui/tui-stack.c (tui_show_frame_info): Update.
3797
3798 2019-08-13  Tom Tromey  <tom@tromey.com>
3799
3800         * tui/tui-winsource.h (struct tui_source_window_base)
3801         <set_exec_info_content>: Declare.
3802         (tui_set_exec_info_content): Don't declare.
3803         * tui/tui-winsource.c
3804         (tui_source_window_base::set_exec_info_content): Rename from
3805         tui_set_exec_info_content.
3806         (tui_update_exec_info): Update.
3807
3808 2019-08-13  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui-winsource.h (struct tui_source_window_base)
3811         <show_source_content>: Declare.
3812         (tui_show_source_content): Don't declare.
3813         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3814         (tui_source_window_base::show_source_content): Rename from
3815         tui_show_source_content.
3816         (tui_source_window_base::refresh_all): Update.
3817         * tui/tui-layout.c (show_source_disasm_command)
3818         (show_source_or_disasm_and_command): Update.
3819
3820 2019-08-13  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-winsource.c (tui_erase_source_content)
3823         (tui_show_source_content, tui_source_window_base::refresh_all):
3824         Update.
3825         * tui/tui-wingeneral.h
3826         (tui_check_and_display_highlight_if_needed): Don't declare.
3827         * tui/tui-wingeneral.c
3828         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3829         check_and_display_highlight_if_needed.
3830         * tui/tui-win.c (tui_rehighlight_all)
3831         (tui_win_info::make_visible_with_new_height): Update.
3832         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3833         (tui_data_window::erase_data_content)
3834         (tui_data_window::display_all_data): Update.
3835         * tui/tui-data.h (struct tui_win_info)
3836         <check_and_display_highlight_if_needed>: Declare.
3837
3838 2019-08-13  Tom Tromey  <tom@tromey.com>
3839
3840         * tui/tui-win.c (tui_resize_all): Call
3841         tui_delete_invisible_windows.
3842         * tui/tui-layout.c (show_layout): Call
3843         tui_delete_invisible_windows.
3844         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3845         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3846
3847 2019-08-13  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3850         tui_add_win_to_layout.
3851
3852 2019-08-13  Tom Tromey  <tom@tromey.com>
3853
3854         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3855         * tui/tui-layout.c (tui_default_win_height): Now static.
3856
3857 2019-08-13  Tom Tromey  <tom@tromey.com>
3858
3859         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3860         single switch.
3861         (show_source_disasm_command, show_source_or_disasm_and_command):
3862         Don't check current layout.
3863
3864 2019-08-13  Tom Tromey  <tom@tromey.com>
3865
3866         * tui/tui-wingeneral.c (make_all_visible): Remove.
3867         (tui_make_all_invisible): Simplify.
3868         * tui/tui-layout.c (tui_make_all_invisible): Move from
3869         tui-wingeneral.c; simplify.
3870         (show_layout): Hoist call to tui_make_all_invisible.
3871         (show_data): Don't call tui_make_all_invisible.
3872
3873 2019-08-13  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3876         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3877
3878 2019-08-13  Tom Tromey  <tom@tromey.com>
3879
3880         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3881         tui-data.c.
3882         (show_source_disasm_command, show_data)
3883         (show_source_or_disasm_and_command): Don't use
3884         tui_set_current_layout_to.
3885         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3886         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3887         tui-layout.c.
3888         (tui_set_current_layout_to): Remove.
3889
3890 2019-08-13  Tom Tromey  <tom@tromey.com>
3891
3892         * tui/tui-layout.c (tui_set_layout): Update.
3893         * tui/tui-data.h (struct tui_layout_def): Remove.
3894         (tui_layout_def): Don't declare.
3895         * tui/tui-data.c (layout_def): Remove.
3896         (tui_layout_def): Remove.
3897
3898 2019-08-13  Tom Tromey  <tom@tromey.com>
3899
3900         * tui/tui-winsource.h (struct tui_source_window_base)
3901         <clear_detail>: No longer "override".
3902         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3903         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3904         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3905         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3906         Remove.
3907         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3908
3909 2019-08-13  Tom Tromey  <tromey@adacore.com>
3910
3911         * tracepoint.c: Don't include readline.h or history.h.
3912
3913 2019-08-12  Tom Tromey  <tom@tromey.com>
3914
3915         * configure: Rebuild.
3916         * configure.ac: Check for readline 7.
3917         * NEWS: Mention readline 7 requirement.
3918         * README: Update.
3919
3920 2019-08-12  Tom Tromey  <tom@tromey.com>
3921
3922         * mingw-hdep.c (gdb_select): Remove readline hack.
3923
3924 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3925
3926         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3927         when the function fails.
3928
3929 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3930
3931         * s390-tdep.c (s390_type_align): New function.
3932         (s390_gdbarch_init): Set it as type_align gdbarch method.
3933
3934 2019-08-09  Tom de Vries  <tdevries@suse.de>
3935
3936         PR gdb/24591
3937         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3938         pc_low with relocation offset.
3939
3940 2019-08-07  Tom Tromey  <tromey@adacore.com>
3941
3942         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3943         (print_frame_args): Update.
3944         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3945         Update.
3946         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3947         * frame.h (struct frame_arg): Add initializers.
3948         <error>: Now a unique_xmalloc_ptr.
3949
3950 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3951
3952         * NEWS: Expand the Pointer Authentication entry.
3953         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3954         (aarch64_frame_unmask_lr): ... to this.
3955         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3956         Call aarch64_frame_unmask_lr.
3957         * frame.c (struct frame_info): Add "masked" variable.
3958         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3959         (fprint_frame): Check for masked pc.
3960         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3961         declarations.
3962         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3963         * stack.c (print_frame): Check for masked pc.
3964
3965 2019-08-06  Tom Tromey  <tom@tromey.com>
3966
3967         * stabsread.c (patch_block_stabs, read_one_struct_field)
3968         (read_enum_type): Use obstack_strndup.
3969         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3970         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3971         * dwarf2read.c (guess_full_die_structure_name)
3972         (anonymous_struct_prefix): Use obstack_strndup.
3973         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3974         * c-exp.y (yylex): Use obstack_strndup.
3975         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3976         (write_var_or_type): Use obstack_strndup.
3977
3978 2019-08-06  Tom Tromey  <tom@tromey.com>
3979
3980         * symfile.c (reread_symbols): Use obstack_strdup.
3981         * stabsread.c (read_type): Use obstack_strdup.
3982         * gdb_obstack.h (obstack_strdup): New overload.
3983         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3984         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3985         (dwarf2_canonicalize_name): Use obstack_strdup.
3986         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3987         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3988         Use obstack_strdup.
3989
3990 2019-08-06  Tom Tromey  <tom@tromey.com>
3991
3992         * gdb_obstack.h (obstack_strdup): Define.
3993         * gdb_obstack.c (obstack_strdup): Don't define.
3994
3995 2019-08-06  Tom Tromey  <tom@tromey.com>
3996
3997         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3998         obstack_strdup.
3999         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4000         obstack_strdup.
4001         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4002         * stabsread.c (common_block_start): Use obstack_strdup.
4003         * objfiles.c (set_objfile_main_name, objfile): Use
4004         obstack_strdup.
4005         * namespace.c (add_using_directive): Use obstack_strdup.
4006         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4007         * jit.c (finalize_symtab): Use obstack_strdup.
4008         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4009         (guess_partial_die_structure_name, partial_die_info::fixup)
4010         (dwarf2_name): Use obstack_strdup.
4011         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4012         obstack_strdup.
4013         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4014         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4015         obstack_strdup.
4016         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4017
4018 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4019
4020         * unittests/help-doc-selftests.c: New file.
4021         * Makefile.in: Add the new file.
4022
4023 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4024
4025         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4026         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4027         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4028         the trailing '.' is not output, and the first character is uppercased.
4029         (print_help_for_command): Update call to print_doc_line.
4030         (print_doc_of_command): Likewise.
4031         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4032         * cli/cli-option.c (append_indented_doc): Do not append newline.
4033         (build_help_option): Append newline after first appended_indented_doc
4034         only if a second call is done.
4035         (build_help): Append 2 new lines before each option, except the first
4036         one.
4037         * compile/compile.c (_initialize_compile): Add new lines after
4038         %OPTIONS%, when not at the end of the help.
4039         Change help doc or code
4040         producing the help doc to respect the invariants.
4041         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4042         Also removed the new line after 'Options:', as all other commands
4043         do not put an empty line between 'Options:' and the first option.
4044         * printcmd.c (_initialize_printcmd): Likewise.
4045         * stack.c (_initialize_stack): Likewise.
4046         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4047         incorrectly telling COMMAND is optional.
4048         * ada-lang.c (_initialize_ada_language): Change help doc or code
4049         producing the help doc to respect the invariants.
4050         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4051         * breakpoint.c (_initialize_breakpoint): Likewise.
4052         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4053         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4054         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4055         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4056         _initialize_cli_style): Likewise.
4057         * corelow.c (core_target_info): Likewise.
4058         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4059         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4060         * filesystem.c (_initialize_filesystem): Likewise.
4061         * frame.c (_initialize_frame): Likewise.
4062         * gnu-nat.c (add_task_commands): Likewise.
4063         * infcall.c (_initialize_infcall): Likewise.
4064         * infcmd.c (_initialize_infcmd): Likewise.
4065         * interps.c (_initialize_interpreter): Likewise.
4066         * language.c (_initialize_language): Likewise.
4067         * linux-fork.c (_initialize_linux_fork): Likewise.
4068         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4069         * maint.c (_initialize_maint_cmds): Likewise.
4070         * memattr.c (_initialize_mem): Likewise.
4071         * printcmd.c (_initialize_printcmd): Likewise.
4072         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4073         _RegEx): Likewise.
4074         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4075         * record-btrace.c (_initialize_record_btrace): Likewise.
4076         * record-full.c (_initialize_record_full): Likewise.
4077         * record.c (_initialize_record): Likewise.
4078         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4079         * regcache.c (_initialize_regcache): Likewise.
4080         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4081         _initialize_remote): Likewise.
4082         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4083         * serial.c (_initialize_serial): Likewise.
4084         * skip.c (_initialize_step_skip): Likewise.
4085         * source.c (_initialize_source): Likewise.
4086         * stack.c (_initialize_stack): Likewise.
4087         * symfile.c (_initialize_symfile): Likewise.
4088         * symtab.c (_initialize_symtab): Likewise.
4089         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4090         * top.c (init_main): Likewise.
4091         * tracefile-tfile.c (tfile_target_info): Likewise.
4092         * tracepoint.c (_initialize_tracepoint): Likewise.
4093         * tui/tui-win.c (_initialize_tui_win): Likewise.
4094         * utils.c (add_internal_problem_command): Likewise.
4095         * valprint.c (value_print_option_defs): Likewise.
4096
4097 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4098
4099         PR build/24886
4100         * configure.ac: Drop enable-libmcheck support.
4101         * configure, config.in: Rebuild.
4102         * libmcheck.m4: Remove.
4103         * acinclude.m4: Don't include it.
4104         * Makefile.in: Don't distribute it.
4105         * top.c (print_gdb_configuration): Don't mention it.
4106
4107 2019-08-06  Tom Tromey  <tom@tromey.com>
4108
4109         * utils.c (set_output_style): Sometimes pass stream to
4110         emit_style_escape.
4111         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4112         * record-btrace.c (btrace_insn_history): Update.
4113         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4114         method.
4115         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4116         Update initializers.
4117         <m_uiout>: New field.
4118         <m_di>: Move lower.
4119         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4120         Remove "uiout" parameter.
4121         (dump_insns): Update.
4122         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4123         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4124
4125 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4126
4127         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4128         (error_in_psymtab_expansion): Likewise.
4129         (lookup_symbol_via_quick_fns): Likewise.
4130         (basic_lookup_transparent_type_quick): Likewise.
4131         (basic_lookup_transparent_type_1): Likewise.
4132
4133 2019-08-06  Tom Tromey  <tromey@adacore.com>
4134
4135         * source.c (last_source_error): Now bool.
4136         (print_source_lines_base): Make "noprint" bool.  Only open
4137         source file when last_source_visited changes.
4138
4139 2019-08-06  Tom Tromey  <tromey@adacore.com>
4140
4141         * annotate.c (annotate_source_line): Use g_source_cache.
4142         * source-cache.c (source_cache::get_plain_source_lines): Change
4143         parameters.  Populate m_offset_cache.
4144         (source_cache::ensure): New method.
4145         (source_cache::get_line_charpos): New method.
4146         (extract_lines): Move lower.  Change parameters.
4147         (source_cache::get_source_lines): Move lower.
4148         * source-cache.h (class source_cache): Update comment.
4149         <get_line_charpos>: New method.
4150         <get_source_lines>: Update comment.
4151         <clear>: Clear m_offset_cache.
4152         <get_plain_source_lines>: Change parameters.
4153         <ensure>: New method
4154         <m_offset_cache>: New member.
4155         * source.c (forget_cached_source_info_for_objfile): Update.
4156         (info_source_command): Use g_source_cache.
4157         (find_source_lines, open_source_file_with_line_charpos): Remove.
4158         (print_source_lines_base, search_command_helper): Use g_source_cache.
4159         * source.h (open_source_file_with_line_charpos): Don't declare.
4160         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4161         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4162         Use g_source_cache.
4163
4164 2019-08-06  Tom Tromey  <tromey@adacore.com>
4165
4166         * source-cache.c (source_cache::get_plain_source_lines):
4167         Remove "first_line" and "last_line" parameters.
4168         (source_cache::get_source_lines): Cache plain text.
4169         * source-cache.h (class source_cache)
4170         <get_plain_source_lines>: Update.
4171
4172 2019-08-06  Tom Tromey  <tromey@adacore.com>
4173
4174         * source-cache.c (extract_lines): No longer a method.
4175         Changed type of parameter.  Include final newline.
4176         (selftests::extract_lines_test): New function.
4177         (_initialize_source_cache): Likewise.
4178         * source-cache.h (class source_cache)
4179         <extract_lines>: Don't declare.
4180
4181 2019-08-06  Tom Tromey  <tromey@adacore.com>
4182
4183         * breakpoint.c (init_breakpoint_sal): Update.
4184         (breakpoint): Update.
4185         * breakpoint.h (struct breakpoint) <filter>: Now a
4186         unique_xmalloc_ptr.
4187
4188 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4189
4190         * NEWS: Mention dictionary access on blocks.
4191         * python/py-block.c (blpy_getitem): New function.
4192         (block_object_as_mapping): New struct.
4193         (block_object_type): Use new struct for tp_as_mapping field.
4194
4195 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4196
4197         * objfiles.h (objfile): Add a comment describing partial symbols.
4198
4199 2019-08-05  Tom Tromey  <tromey@adacore.com>
4200
4201         * compile/compile.c (_initialize_compile): Use _(), not N_().
4202         * thread.c (_initialize_thread): Use _(), not N_().
4203         * stack.c (_initialize_stack): Use _(), not N_().
4204         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4205
4206 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4207
4208         * dwarf2read.c (struct dw2_symtab_iterator):
4209         <want_specific_block>: Remove.
4210         <block_index>: Change type to gdb::optional.
4211         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4212         change type of BLOCK_INDEX parameter to gdb::optional.
4213         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4214         (dw2_lookup_symbol): Don't pass argument for
4215         WANT_SPECIFIC_BLOCK.
4216         (dw2_expand_symtabs_for_function): Don't pass argument for
4217         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4218         (class dw2_debug_names_iterator)
4219         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4220         parameter, change BLOCK_INDEX type to gdb::optional.
4221         <m_want_specific_block>: Remove.
4222         <m_block_index>: Change type to gdb::optional.
4223         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4224         gdb::optional.  Re-write in function of gdb::optional.
4225         (dw2_debug_names_lookup_symbol): Don't pass argument for
4226         WANT_SPECIFIC_BLOCK.
4227         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4228         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4229         BLOCK_INDEX.
4230
4231 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4232
4233         * NEWS: Mention changes to "info sources" command.
4234
4235 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4236
4237         * symtab.c (filename_partial_match_opts): New struct type.
4238         (struct output_source_filename_data): New members
4239         regexp, c_regexp, partial_match.
4240         (output_source_filename): Use new members to decide to print file.
4241         (info_sources_option_defs): New variable.
4242         (make_info_sources_options_def_group, print_info_sources_header,
4243         info_sources_command_completer):
4244         New functions.
4245         (info_sources_command): Read new optional arguments.
4246         (_initialize_symtab): Update info sources help.
4247
4248 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4249
4250         * ada-lang.c (exception_support_info_v0): Renamed from...
4251         (default_exception_support_info): ... this.  Create new
4252         definition for v1.
4253         (ada_has_this_exception_support): Look up catch_handlers_sym.
4254         (ada_exception_support_info_sniffer): Try v0 after default.
4255
4256 2019-08-01  Tom Tromey  <tromey@adacore.com>
4257
4258         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4259         gdbarch.h.
4260
4261 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4262
4263         * s12z-tdep.c: Fix include path for s12z-opc.h.
4264
4265 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4266
4267         * NEWS: Require GNU make 3.82.
4268
4269 2019-07-16  Tom Tromey  <tom@tromey.com>
4270
4271         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4272         declare.
4273
4274 2019-07-30  Tom Tromey  <tromey@adacore.com>
4275
4276         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4277
4278 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4279
4280         * printcmd.c (print_address_symbolic): Print negative offsets.
4281         (build_address_symbolic): Force signed arithmetic when computing
4282         offset.
4283
4284 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4285
4286         PR/24474: Add a function to lookup static variables.
4287         * NEWS: Mention this new function.
4288         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4289         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4290         * python/python.c (python_GdbMethods): Add new function.
4291
4292 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4293
4294         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4295         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4296         (objfpy_lookup_static_symbol): New function.
4297         (objfile_object_methods): Add new functions.
4298
4299 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4300
4301         * NEWS: Mention 'set|show print frame-info'.  Mention new
4302         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4303         backtrace argument.  Mention that python frame filtering code
4304         is now consistent with what 'backtrace' command prints.
4305
4306 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4307
4308         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4309         comments.
4310         (print_frame_info_auto, print_frame_info_source_line,
4311         print_frame_info_location, print_frame_info_source_and_location,
4312         print_frame_info_location_and_address, print_frame_info_short_location):
4313         New declarations.
4314         (struct frame_print_options): New member print_frame_info.
4315         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4316         * stack.h (get_user_print_what_frame_info): New declaration.
4317         (frame_show_address): New declaration.
4318         * stack.c (print_frame_arguments_choices): New value 'presence'.
4319         (print_frame_info_auto, print_frame_info_source_line,
4320         print_frame_info_location, print_frame_info_source_and_location,
4321         print_frame_info_location_and_address, print_frame_info_short_location,
4322         print_frame_info_choices, print_frame_info_print_what): New definitions.
4323         (print_frame_args): Only print dots for args if print frame-arguments
4324         is 'presence'.
4325         (frame_print_option_defs): New element for "frame-info".
4326         (get_user_print_what_frame_info): New function.
4327         (frame_show_address): Make non static.  Move comment to stack.h.
4328         (print_frame_info_to_print_what): New function.
4329         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4330         to decide what to print.
4331         (backtrace_command_1): Handle the new print_frame_arguments_presence
4332         value.
4333         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4334         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4335         (py_print_frame): In non-mi mode, use LOCATION as default for
4336         print_what, similarly to frame information printed directly by
4337         backtrace command. Handle frame-info user option in non MI mode.
4338
4339 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4340
4341         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4342         Add case for debugging 32-bit target on 64-bit host.  Revise
4343         comment.
4344
4345 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4346
4347         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4348         instead of find_function_entry_range_from_pc.
4349
4350 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4351
4352         * stack.c (find_frame_funname): Remove code which preferred
4353         minsym over symtab sym in "certain pathological cases".
4354
4355         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4356         parameter.  Change type of "do_demangle" to bool.
4357         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4358         Pass suitable "prefer_sym_over_minsym" flag to
4359         build_address_symbolic().  Don't output "+" for negative offsets.
4360         * printcmd.c (print_address_symbolic): Update invocation of
4361         build_address_symbolic to include a "prefer_sym_over_minsym"
4362         flag.
4363         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4364         Restrict cases in which use of minimal symbol is preferred to that
4365         of a found symbol.  Update comments.
4366
4367         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4368         for entry pc when entry pc is out of range for that FDE.
4369
4370 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4371
4372         PR gdb/24839:
4373         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4374         type.
4375
4376 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4377
4378         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4379         this function's Python signature.
4380
4381
4382 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4383
4384         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4385         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4386         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4387         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4388         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4389
4390
4391 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4392
4393         * h8300-tdep.c (h8300_register_name_common): New.
4394         h8300_register_name): Use h8300_register_name_common.
4395         (h8300s_register_name): Likewise.
4396         (h8300sx_register_name): Likewise.
4397         (h8300h_register_nam): New.
4398         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4399
4400
4401 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4402
4403         * arm-tdep.c (arm_skip_cmse_entry): New function.
4404         (arm_is_sgstubs_section): New function.
4405         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4406
4407 2019-07-22  Tom Tromey  <tom@tromey.com>
4408
4409         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4410         Don't self-assign.
4411
4412 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4413
4414         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4415         type_print.
4416
4417 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4420         so that GDB doesn't match any msymbols when searching in the
4421         TYPES_DOMAIN.
4422         (print_symbol_info): Print using typedef_print or type_print based
4423         on the type of the symbol.  Add updated FIXME comment moved from...
4424         (_initialize_symtab): ... move and update FIXME comment to above.
4425
4426 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * NEWS: Mention adding -q option to "info types".
4429         * symtab.c (struct info_types_options): New struct.
4430         (info_types_options_defs): New variable.
4431         (make_info_types_options_def_group): New function.
4432         (info_types_command): Use gdb::option framework to parse options.
4433         (info_types_command_completer): New function.
4434         (_initialize_symtab): Extend the help text on "info types" and
4435         register command completer.
4436
4437 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4438
4439         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4440         (lookup_symbol_in_objfile): Change int to block_enum and add a
4441         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4442
4443 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4444
4445         * MAINTAINERS (Write After Approval): Add self.
4446
4447 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4450         instruction to the dummy code region.
4451
4452 2019-07-19  Tom Tromey  <tromey@adacore.com>
4453
4454         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4455         (ARGSUSED, PARAMS, __func__): Remove rules.
4456
4457 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4458
4459         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4460         * features/arm/arm-with-iwmmxt.c: Remove.
4461         * features/arm/arm-with-iwmmxt.xml: Remove.
4462         * features/arm/arm-with-m-fpa-layout.c: Remove.
4463         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4464         * features/arm/arm-with-m-vfp-d16.c: Remove.
4465         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4466         * features/arm/arm-with-m.c: Remove.
4467         * features/arm/arm-with-m.xml: Remove.
4468         * features/arm/arm-with-neon.c: Remove.
4469         * features/arm/arm-with-neon.xml: Remove.
4470         * features/arm/arm-with-vfpv2.c: Remove.
4471         * features/arm/arm-with-vfpv2.xml: Remove.
4472         * features/arm/arm-with-vfpv3.c: Remove.
4473         * features/arm/arm-with-vfpv3.xml: Remove.
4474
4475 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4476
4477         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4478
4479 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4480
4481         * arch/aarch32.c (aarch32_create_target_description): Create
4482         target descriptions using features.
4483         * arch/arm.c (arm_create_target_description)
4484         (arm_create_mprofile_target_description): Likewise.
4485         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4486
4487 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4488
4489         * Makefile.in: Add new files.
4490         * aarch32-tdep.c: New file.
4491         * aarch32-tdep.h: New file.
4492         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4493         Call aarch32_read_description.
4494         * arch/aarch32.c: New file.
4495         * arch/aarch32.h: New file.
4496         * arch/arm.c (arm_create_target_description)
4497         (arm_create_mprofile_target_description): New function.
4498         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4499         (arm_create_target_description)
4500         (arm_create_mprofile_target_description): New declaration.
4501         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4502         read_description functions.
4503         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4504         Likewise.
4505         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4506         * arm-tdep.c (tdesc_arm_list): New variable.
4507         (arm_register_g_packet_guesses): Call create description functions.
4508         (arm_read_description) (arm_read_mprofile_description): New
4509         function.
4510         * arm-tdep.h (arm_read_description)
4511         (arm_read_mprofile_description): Add declaration.
4512         * configure.tgt: Add new files.
4513
4514 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4515
4516         * top.c (new_ui_command): Open specified terminal just once.
4517
4518 2019-07-18  Tom Tromey  <tromey@adacore.com>
4519
4520         * symtab.c (main_name): Constify return type.
4521         * symfile.c (set_initial_language): Update.
4522         * symtab.h (main_name): Constify return type.
4523
4524 2019-07-17  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-winsource.c (tui_update_source_window)
4527         (tui_update_source_window_as_is)
4528         (tui_update_source_windows_with_line): Remove return.
4529         * tui/tui-disasm.c (tui_show_disassem)
4530         (tui_show_disassem_and_update_source): Remove return.
4531         * tui/tui.c (tui_reset): Remove return.
4532         * tui/tui-wingeneral.c
4533         (tui_check_and_display_highlight_if_needed): Remove return.
4534
4535 2019-07-17  Tom Tromey  <tom@tromey.com>
4536
4537         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4538
4539 2019-07-17  Tom Tromey  <tom@tromey.com>
4540
4541         * tui/tui-winsource.h (struct tui_exec_info_window)
4542         (struct tui_source_window_base): Move from tui-data.h.
4543         * tui/tui-winsource.c: Move many method definitions from
4544         elsewhere.  Remove "structuring" comments.
4545         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4546         (tui_source_window_base::refresh_window): Move to
4547         tui-winsource.c.
4548         * tui/tui-win.c (tui_source_window_base::refresh_all)
4549         (tui_source_window_base::update_tab_width)
4550         (tui_source_window_base::set_new_height)
4551         (tui_source_window_base::do_make_visible_with_new_height): Move to
4552         tui-winsource.c.
4553         * tui/tui-source.h: Update.
4554         * tui/tui-source.c (tui_source_window_base::reset): Move to
4555         tui-winsource.c.
4556         * tui/tui-disasm.h: Update.
4557         * tui/tui-data.h (struct tui_exec_info_window): Move to
4558         tui-winsource.h.
4559         (struct tui_source_window_base): Likewise.
4560         * tui/tui-data.c (tui_source_window_base::clear_detail)
4561         (tui_source_window_base, ~tui_source_window_base): Move to
4562         tui-winsource.c.
4563
4564 2019-07-17  Tom Tromey  <tom@tromey.com>
4565
4566         * tui/tui-win.c (tui_resize_all)
4567         (tui_source_window_base::update_tab_width)
4568         (tui_adjust_win_heights): Update.
4569         (tui_win_info::make_invisible_and_set_new_height): Rename from
4570         make_invisible_and_set_new_height.
4571         * tui/tui-data.h (struct tui_win_info)
4572         <make_invisible_and_set_new_height>: New method.
4573
4574 2019-07-17  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui.c: Update.
4577         * tui/tui-source.h (struct tui_source_window): Move from
4578         tui-data.h.
4579         * tui/tui-layout.c: Update.
4580         * tui/tui-disasm.c: Update.
4581         * tui/tui-data.h (struct tui_source_window): Move to
4582         tui-source.h.
4583
4584 2019-07-17  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4587         tui-data.h.
4588         * tui/tui-data.h (struct tui_disasm_window): Move to
4589         tui-disasm.h.
4590
4591 2019-07-17  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui-regs.h (struct tui_data_item_window): Move from
4594         tui-data.h.
4595         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4596         * tui/tui-data.h (struct tui_data_item_window): Move to
4597         tui-regs.h.
4598         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4599
4600 2019-07-17  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui.c: Update.
4603         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4604         (tui_cmd_window::max_height): Move to tui-command.c.
4605         * tui/tui-layout.c: Update.
4606         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4607         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4608         tui-command.c.
4609         * tui/tui-command.h (struct tui_cmd_window): Move from
4610         tui-data.h.
4611         * tui/tui-command.c: Remove "structuring" comments.
4612         (tui_cmd_window::clear_detail)
4613         (tui_cmd_window::do_make_visible_with_new_height)
4614         (tui_cmd_window::max_height): Move from elsewhere.
4615
4616 2019-07-17  Tom Tromey  <tom@tromey.com>
4617
4618         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4619         Now static.
4620         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4621         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4622
4623 2019-07-17  Tom Tromey  <tom@tromey.com>
4624
4625         * tui/tui.c: Update.
4626         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4627         tui-regs.c.
4628         * tui/tui-windata.h: Remove file.
4629         * tui/tui-windata.c: Remove file.
4630         * tui/tui-win.c (tui_data_window::set_new_height)
4631         (tui_data_window::do_make_visible_with_new_height): Move to
4632         tui-regs.c.
4633         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4634         * tui/tui-regs.c: Remove "structuring" comments.
4635         (tui_data_window::first_data_item_displayed)
4636         (tui_data_window::delete_data_content_windows)
4637         (tui_data_window::erase_data_content)
4638         (tui_data_window::display_all_data)
4639         (tui_data_window::refresh_all)
4640         (tui_data_window::do_scroll_vertical)
4641         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4642         (tui_data_window::do_make_visible_with_new_height)
4643         (tui_data_window::refresh_window): Move from elsewhere.
4644         (_initialize_tui_regs): Move to end of file.
4645         * tui/tui-layout.c: Update.
4646         * tui/tui-hooks.c: Update.
4647         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4648         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4649         tui-regs.c.
4650         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4651
4652 2019-07-17  Tom Tromey  <tom@tromey.com>
4653
4654         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4655         seen.
4656
4657 2019-07-17  Tom Tromey  <tom@tromey.com>
4658
4659         * tui/tui-win.c (tui_source_window_base::set_new_height)
4660         (tui_source_window_base::do_make_visible_with_new_height): Use
4661         m_has_locator field directly.
4662         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4663         method.
4664         (struct tui_source_window_base) <has_locator>: Likewise.
4665
4666 2019-07-17  Tom Tromey  <tom@tromey.com>
4667
4668         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4669         Don't declare.
4670         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4671         Remove.
4672         * tui/tui-win.c (tui_source_window_base::set_new_height)
4673         (tui_source_window_base::set_new_height)
4674         (make_invisible_and_set_new_height)
4675         (tui_source_window_base::do_make_visible_with_new_height)
4676         (tui_source_window_base::do_make_visible_with_new_height):
4677         Update.
4678         * tui/tui-layout.c (show_source_disasm_command, show_data)
4679         (show_source_or_disasm_and_command): Update.
4680         * tui/tui-layout.c (show_layout): Update.
4681
4682 2019-07-17  Tom Tromey  <tom@tromey.com>
4683
4684         * tui/tui-layout.c (make_data_window): Remove.
4685         (show_data): Unify creation and re-initialization cases.
4686
4687 2019-07-17  Tom Tromey  <tom@tromey.com>
4688
4689         * tui/tui-layout.c (make_source_window, make_disasm_window):
4690         Remove.
4691         (show_data): Unify creation and re-initialization cases.
4692
4693 2019-07-17  Tom Tromey  <tom@tromey.com>
4694
4695         * tui/tui-layout.c (make_command_window): Remove.
4696         (show_source_disasm_command, show_source_or_disasm_and_command):
4697         Unify creation and re-initialization cases.
4698
4699 2019-07-17  Tom Tromey  <tom@tromey.com>
4700
4701         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4702         creation and re-initialization cases.
4703
4704 2019-07-17  Tom Tromey  <tom@tromey.com>
4705
4706         * tui/tui-regs.c (tui_get_register): Return void.
4707
4708 2019-07-17  Tom Tromey  <tom@tromey.com>
4709
4710         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4711         Simplify.
4712
4713 2019-07-17  Tom Tromey  <tom@tromey.com>
4714
4715         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4716         resetting.
4717
4718 2019-07-17  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4721         * tui/tui-regs.c (tui_reg_layout): New function.
4722         (tui_show_registers, tui_reg_command): Use it.
4723         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4724         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4725         parameters.
4726         (tui_layout_command): Remove.
4727
4728 2019-07-17  Tom Tromey  <tom@tromey.com>
4729
4730         * tui/tui-layout.h (tui/tui-layout): Return void.
4731         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4732
4733 2019-07-17  Tom Tromey  <tom@tromey.com>
4734
4735         * tui/tui-layout.c (show_source_disasm_command, show_data):
4736         Update.
4737         (reset_locator): Remove.
4738         (show_source_or_disasm_and_command): Update.
4739
4740 2019-07-17  Tom Tromey  <tom@tromey.com>
4741
4742         * tui/tui-source.c (tui_source_window_base::reset): Remove
4743         win_type parameter.
4744         * tui/tui-layout.c (make_command_window, make_source_window)
4745         (make_disasm_window, make_data_window)
4746         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4747         (reset_locator, show_source_or_disasm_and_command): Update.
4748         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4749         win_type parameter.
4750         (struct tui_source_window_base) <reset>: Likewise.
4751
4752 2019-07-17  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-layout.c (show_source_disasm_command): Use
4755         reset_locator.
4756         (reset_locator): New function.
4757         (init_and_make_win): Remove.
4758         (show_source_or_disasm_and_command): Use reset_locator.
4759
4760 2019-07-17  Tom Tromey  <tom@tromey.com>
4761
4762         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4763         condition.
4764         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4765         Remove condition.
4766         * tui/tui-source.c (tui_source_window_base::reset): New method.
4767         * tui/tui-layout.c (make_command_window): Don't call
4768         init_and_make_win.
4769         (make_source_window, make_disasm_window): Don't call
4770         make_source_or_disasm_window.
4771         (make_data_window): Don't call init_and_make_win.  Change calling
4772         convention.
4773         (show_source_disasm_command, show_data): Simplify.
4774         (make_source_or_disasm_window): Remove.
4775         (show_source_or_disasm_and_command): Simplify.
4776         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4777         (struct tui_source_window_base) <reset>: Likewise.
4778         <execution_info>: Remove initializer.
4779         * tui/tui-data.c (tui_source_window_base): Initialize
4780         execution_info.
4781
4782 2019-07-17  Tom Tromey  <tom@tromey.com>
4783
4784         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4785         variable.
4786
4787 2019-07-17  Tom Tromey  <tom@tromey.com>
4788
4789         * tui/tui.c (tui_rl_other_window): Update.
4790         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4791         superclass method first.  Always iterate over regs_content.
4792         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4793         method.
4794         * tui/tui-win.c (tui_set_focus_command): Update.
4795
4796 2019-07-17  Tom Tromey  <tom@tromey.com>
4797
4798         * tui/tui-win.c (tui_set_focus_command): Rename from
4799         tui_set_focus.  Call tui_enable.
4800         (tui_set_focus_command): Remove.
4801
4802 2019-07-17  Tom Tromey  <tom@tromey.com>
4803
4804         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4805         refresh_window.
4806         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4807         touchwin.
4808         (tui_data_window::refresh_window): Call refresh_window on data
4809         items.  Always call superclass refresh_window.
4810         (tui_win_info::refresh): Remove.
4811         (tui_source_window_base::refresh_window): Update.
4812         (tui_refresh_all): Update.
4813         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4814         refresh_window.
4815         (show_source_or_disasm_and_command): Likewise.
4816         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4817         (struct tui_source_window_base) <refresh>: Likewise.
4818
4819 2019-07-17  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-winsource.c (tui_clear_source_content)
4822         (tui_show_source_content): Update.
4823         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4824         whether content is empty.
4825         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4826         Remove.
4827
4828 2019-07-17  Tom Tromey  <tom@tromey.com>
4829
4830         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4831         window's contents.
4832         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4833         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4834
4835 2019-07-17  Tom Tromey  <tom@tromey.com>
4836
4837         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4838         (struct tui_data_item_window): Update.
4839
4840 2019-07-17  Tom Tromey  <tom@tromey.com>
4841
4842         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4843         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4844         defines.
4845
4846 2019-07-17  Tom Tromey  <tom@tromey.com>
4847
4848         * tui/tui-winsource.h (tui_erase_source_content)
4849         (tui_clear_source_content): Remove "display_prompt" parameter.
4850         * tui/tui-winsource.c (tui_update_source_window_as_is)
4851         (tui_update_source_windows_with_addr): Update.
4852         (tui_clear_source_content): Remove "display_prompt" parameter.
4853         (tui_erase_source_content): Likewise.  Simplify.
4854         (tui_show_source_content): Update.
4855         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4856         * tui/tui-stack.c (tui_show_frame_info): Update.
4857         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4858         Remove defines.
4859
4860 2019-07-17  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4863         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4864         parameter.
4865         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4866         parameter.
4867
4868 2019-07-17  Tom Tromey  <tom@tromey.com>
4869
4870         * tui/tui-winsource.c (tui_clear_source_content)
4871         (tui_show_source_content, tui_show_exec_info_content)
4872         (tui_clear_exec_info_content): Update.
4873         * tui/tui-stack.c (tui_show_locator_content): Update.
4874         (tui_show_frame_info): Update.
4875         * tui/tui-source.h (tui_source_window): Don't declare.
4876         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4877         from tui_source_is_displayed.
4878         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4879         Remove field.
4880         (struct tui_source_window_base) <content_in_use>: New field.  Now
4881         bool.
4882         (struct tui_source_window) <showing_source_p>: New method.
4883         (TUI_SRC_WIN): Change cast.
4884         * tui/tui-data.c (tui_initialize_static_data): Update.
4885
4886 2019-07-17  Tom Tromey  <tom@tromey.com>
4887
4888         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4889         location_matches_p.
4890         * tui/tui-source.c (tui_source_window::location_matches_p): New
4891         method.
4892         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4893         method.
4894         * tui/tui-data.h (struct tui_source_window_base)
4895         <location_matches_p>: New method.
4896         (struct tui_source_window, struct tui_disasm_window)
4897         <location_matches_p>: Likewise.
4898
4899 2019-07-17  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-win.c (tui_set_win_height_command): Rename from
4902         tui_set_win_height.
4903         (tui_set_win_height_command): Remove.
4904
4905 2019-07-17  Tom Tromey  <tom@tromey.com>
4906
4907         * tui/tui-source.c (tui_source_window): New constructor.  Add
4908         observer.
4909         (~tui_source_window): New destructor.
4910         (tui_source_window::style_changed): New method.
4911         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4912         (tui_attach_detach_observers): Update.
4913         * tui/tui-data.h (struct tui_source_window): Make constructor not
4914         inline.  Add destructor.
4915         (struct tui_source_window) <style_changed>: New method.
4916         <m_observable>: New member.
4917
4918 2019-07-17  Tom Tromey  <tom@tromey.com>
4919
4920         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4921         * tui/tui-win.c (tui_resize_all): Fix typo.
4922
4923 2019-07-17  Tom Tromey  <tom@tromey.com>
4924
4925         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4926         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4927         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4928         * tui/tui-win.c (window_name_completer): Use foreach.
4929         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4930         (update_tab_width): Likewise.
4931         * tui/tui-layout.c (show_layout): Update.
4932         * tui/tui-data.h (class tui_window_iterator): New.
4933         (struct all_tui_windows): New.
4934         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4935
4936 2019-07-17  Tom Tromey  <tom@tromey.com>
4937
4938         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4939         parameter.  Don't reference globals.
4940         (tui_reg_command): Update.
4941
4942 2019-07-17  Tom Tromey  <tom@tromey.com>
4943
4944         * tui/tui-regs.c (tui_show_registers): Simplify.
4945
4946 2019-07-17  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-regs.c (tui_show_registers): Update.
4949         (tui_show_register_group): Add win_info parameter.
4950
4951 2019-07-17  Tom Tromey  <tom@tromey.com>
4952
4953         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4954         Rename from tui_display_reg_element_at_line.
4955         (tui_data_window::display_registers_from_line): Update.
4956         * tui/tui-data.h (struct tui_data_window)
4957         <display_reg_element_at_line>: New method.
4958
4959 2019-07-17  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-regs.h (tui_display_registers_from)
4962         (tui_display_registers_from_line): Don't declare.
4963         * tui/tui-windata.c (tui_data_window::display_all_data)
4964         (tui_data_window::refresh_all)
4965         (tui_data_window::do_scroll_vertical): Update.
4966         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4967         from tui_display_registers_from.
4968         (tui_display_reg_element_at_line): Update.
4969         (tui_data_window::display_registers_from_line): Rename from
4970         tui_display_registers_from_line.
4971         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4972         display_registers_from_line>: New methods.
4973
4974 2019-07-17  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4977         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4978         from tui_erase_data_content.
4979         (tui_data_window::display_all_data)
4980         (tui_data_window::refresh_all)
4981         (tui_data_window::do_scroll_vertical): Update.
4982         * tui/tui-regs.c (tui_show_registers): Update.
4983         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4984         New method.
4985
4986 2019-07-17  Tom Tromey  <tom@tromey.com>
4987
4988         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4989         declare.
4990         * tui/tui-windata.c
4991         (tui_data_window::delete_data_content_windows): Rename from
4992         tui_delete_data_content_windows.
4993         (tui_data_window::display_all_data)
4994         (tui_data_window::do_scroll_vertical): Update.
4995         * tui/tui-data.h (struct tui_data_window)
4996         <delete_data_content_windows>: New method.
4997
4998 2019-07-17  Tom Tromey  <tom@tromey.com>
4999
5000         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5001         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5002
5003 2019-07-17  Tom Tromey  <tom@tromey.com>
5004
5005         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5006         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5007         from tui_display_all_data.
5008         * tui/tui-win.c
5009         (tui_data_window::do_make_visible_with_new_height): Update.
5010         * tui/tui-regs.c (tui_show_registers): Update.
5011         * tui/tui-layout.c (tui_set_layout): Update.
5012         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5013         method.
5014
5015 2019-07-17  Tom Tromey  <tom@tromey.com>
5016
5017         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5018         * tui/tui-windata.c (tui_display_data_from): Remove.
5019         (tui_data_window::refresh_all): Update.
5020
5021 2019-07-17  Tom Tromey  <tom@tromey.com>
5022
5023         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5024         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5025         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5026         tui_display_registers_from_line.
5027         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5028         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5029         "force_display" parameter.
5030
5031 2019-07-17  Tom Tromey  <tom@tromey.com>
5032
5033         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5034         declare.
5035         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5036         Rename from tui_first_reg_element_no_inline.
5037         (tui_display_reg_element_at_line)
5038         (tui_display_registers_from_line): Update.
5039         * tui/tui-data.h (struct tui_data_window)
5040         <first_reg_element_no_inline>: New method.
5041
5042 2019-07-17  Tom Tromey  <tom@tromey.com>
5043
5044         * tui/tui-windata.c (tui_display_data_from)
5045         (tui_data_window::do_scroll_vertical): Update.
5046         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5047         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5048         Rename from tui_line_from_reg_element_no.
5049         (tui_display_registers_from_line): Update.
5050         * tui/tui-data.h (struct tui_data_window)
5051         <line_from_reg_element_no>: New method.
5052
5053 2019-07-17  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5056         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5057         tui_last_regs_line_no.
5058         (tui_display_reg_element_at_line)
5059         (tui_display_registers_from_line): Update.
5060         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5061         method.
5062
5063 2019-07-17  Tom Tromey  <tom@tromey.com>
5064
5065         PR tui/24722:
5066         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5067         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5068         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5069         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5070         (tui_update_breakpoint_info): Likewise.
5071         * tui/tui-hooks.c (tui_event_create_breakpoint)
5072         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5073         Update.
5074
5075 2019-07-17  Tom Tromey  <tom@tromey.com>
5076
5077         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5078
5079 2019-07-17  Tom Tromey  <tom@tromey.com>
5080
5081         * tui/tui-winsource.c (tui_update_source_window_as_is)
5082         (tui_update_source_windows_with_addr): Update.
5083         * tui/tui-source.h (tui_set_source_content)
5084         (tui_show_symtab_source): Add "win_info" parameter.
5085         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5086         parameter.
5087         (tui_show_symtab_source): Likewise.
5088
5089 2019-07-17  Tom Tromey  <tom@tromey.com>
5090
5091         * tui/tui-wingeneral.c
5092         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5093
5094 2019-07-17  Tom Tromey  <tom@tromey.com>
5095
5096         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5097         (struct tui_cmd_window) <can_scroll>: New method.
5098         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5099         method.
5100
5101 2019-07-17  Tom Tromey  <tromey@adacore.com>
5102
5103         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5104         do_field_signed>: Rename.  Change type of "value".
5105         * ui-out.c (ui_out::field_signed): Rename from field_int.
5106         Change type of "value".
5107         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5108         type of "value".
5109         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5110         do_field_int.  Change type of "value".
5111         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5112         do_field_int.  Change type of "value".
5113         * tracepoint.c (trace_status_mi, tfind_1)
5114         (print_one_static_tracepoint_marker): Update.
5115         * thread.c (print_thread_info_1, print_selected_thread_frame):
5116         Update.
5117         * stack.c (print_frame, print_frame_info): Update.
5118         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5119         Update.
5120         * source.c (print_source_lines_base): Update.
5121         * skip.c (info_skip_command): Update.
5122         * record-btrace.c (btrace_ui_out_decode_error)
5123         (btrace_call_history_src_line): Update.
5124         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5125         Update.
5126         * progspace.c (print_program_space): Update.
5127         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5128         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5129         do_field_int.  Change type of "value".
5130         * mi/mi-out.c (mi_ui_out::do_table_begin)
5131         (mi_ui_out::do_table_header): Update.
5132         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5133         type of "value".
5134         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5135         (mi_cmd_data_list_changed_registers, output_register)
5136         (mi_cmd_data_read_memory, mi_load_progress)
5137         (mi_cmd_trace_frame_collected): Update.
5138         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5139         Update.
5140         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5141         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5142         (mi_cmd_var_list_children, varobj_update_one): Update.
5143         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5144         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5145         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5146         * inferior.c (print_inferior): Update.
5147         * gdb_bfd.c (print_one_bfd): Update.
5148         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5149         Update.
5150         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5151         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5152         do_field_int.  Change type of "value".
5153         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5154         do_field_int.  Change type of "value".
5155         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5156         (print_one_breakpoint_location, print_it_catch_fork)
5157         (print_one_catch_fork, print_it_catch_vfork)
5158         (print_one_catch_vfork, print_it_catch_solib)
5159         (print_it_catch_exec, print_it_ranged_breakpoint)
5160         (print_mention_watchpoint, print_mention_masked_watchpoint)
5161         (bkpt_print_it, update_static_tracepoint): Update.
5162         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5163         * break-catch-syscall.c (print_it_catch_syscall): Update.
5164         * ada-tasks.c (print_ada_task_info): Update.
5165         * ada-lang.c (print_it_exception, print_mention_exception):
5166         Update.
5167
5168 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5169
5170         PR breakpoints/24541
5171         * gdbarch.c: Regenerate.
5172         * gdbarch.h: Regenerate.
5173         * gdbarch.sh: Adjust return type and parameter types for
5174         'stap_adjust_register'.
5175         (i386_stap_adjust_register): Adjust signature and return new
5176         register name.
5177         * stap-probe.c (stap_parse_register_operand): Adjust use of
5178         'gdbarch_stap_adjust_register'.
5179
5180 2019-07-17  Tom Tromey  <tromey@adacore.com>
5181
5182         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5183         declare VEC.
5184         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5185         std::vector.
5186         (struct s390_process_info): Add initializers.
5187         (s390_add_process): Use new.
5188         (s390_linux_nat_target::low_forget_process): Use delete.
5189         (s390_linux_nat_target::low_new_fork)
5190         (s390_linux_nat_target::stopped_by_watchpoint)
5191         (s390_linux_nat_target::low_prepare_to_resume)
5192         (s390_linux_nat_target::insert_watchpoint)
5193         (s390_linux_nat_target::insert_hw_breakpoint)
5194         (s390_linux_nat_target::remove_watchpoint)
5195         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5196
5197 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5198
5199         * aarch64-fbsd-nat.c: Include regcache.h.
5200         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5201         argument.
5202         (aarch64_fbsd_nat_target::fetch_registers)
5203         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5204         variable.
5205         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5206
5207 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5208
5209         * fbsd-nat.c: Include gdbarch.h.
5210
5211 2019-07-15  Tom Tromey  <tromey@adacore.com>
5212
5213         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5214
5215 2019-07-15  Tom Tromey  <tromey@adacore.com>
5216
5217         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5218         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5219         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5220         * cli-out.c (cli_ui_out::do_field_int): New method.
5221         * ui-out.c (ui_out::field_unsigned): New method.
5222         * symfile.c (generic_load): Use field_unsigned.
5223         (print_transfer_performance): Likewise.
5224         * record-btrace.c (ui_out_field_uint): Remove.
5225         (btrace_call_history_insn_range, btrace_call_history): Use
5226         field_unsigned.
5227         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5228         field_unsigned.
5229         * ui-out.h (class ui_out) <field_unsigned>: New method.
5230         <do_field_unsigned>: Likewise.
5231
5232 2019-07-15  Tom Tromey  <tromey@adacore.com>
5233
5234         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5235         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5236         * target.c (flash_erase_command): Use field_string.
5237         * infrun.c (print_signal_received_reason): Use field_string.
5238         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5239         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5240         field_string.
5241         * ada-tasks.c (print_ada_task_info): Use field_string.
5242
5243 2019-07-15  Tom Tromey  <tromey@adacore.com>
5244
5245         * target.c (flash_erase_command): Use field_core_addr.
5246         * symfile.c (generic_load): Use field_core_addr.
5247         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5248         Use field_core_addr.
5249         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5250         field_core_addr.
5251
5252 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5253
5254         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5255         value if its desired type is smaller than a CORE_ADDR and signed.
5256
5257 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5258
5259         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5260         of changes to field names, and use new is_reference field to
5261         decide if a property is a reference or not.
5262         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5263         field.
5264         (struct dwarf2_property_baton): Update header comment, rename
5265         'referenced_type' to 'property_type' and update comments.
5266         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5267         default property type, store in property baton, update to take
5268         accound of renamed field.
5269         (read_func_scope): Update call to attr_to_dynamic_prop.
5270         (read_array_type): Likewise.
5271         (dwarf2_per_cu_addr_sized_int_type): New function.
5272         (read_subrange_index_type): Move type finding code to
5273         dwarf2_per_cu_addr_sized_int_type.
5274         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5275         (dwarf2_per_cu_addr_type): New function.
5276         (set_die_type): Update calls to attr_to_dynamic_prop.
5277
5278 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5279
5280         * dwarf2read.c (read_subrange_index_type): New function.
5281         (read_subrange_type): Move code into new function and call it.
5282         * gdbtypes.c (create_range_type): Add some asserts.
5283
5284 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5285
5286         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5287         update return statements.
5288         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5289         declaration, and update comment to match.
5290         * gdbtypes.c (resolve_dynamic_array): Update call to
5291         dwarf2_evaluate_property to match new return type.
5292
5293 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5294
5295         * valarith.c (value_subscripted_rvalue): Change lowerbound
5296         parameter type from int to LONGEST.
5297         * value.h (value_subscripted_rvalue): Likewise in declaration.
5298
5299 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5300
5301         * cli/cli-utils.c (info_print_command_completer): New function.
5302         * cli/cli-utils.h: Add 'completer.h' include, and forward
5303         declaration for 'struct cmd_list_element'.
5304         (info_print_command_completer): Declare.
5305         * stack.c (_initialize_stack): Add completer for 'info locals' and
5306         'info args'.
5307         * symtab.c (_initialize_symtab): Add completer for 'info
5308         variables' and 'info functions'.
5309         * NEWS: Mention completion for additional info commands.
5310
5311 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * cli/cli-utils.c (extract_info_print_args): Delete.
5314         (extract_arg_maybe_quoted): Delete.
5315         (info_print_options_defs): New variable.
5316         (make_info_print_options_def_group): New function.
5317         (extract_info_print_options): Define new function.
5318         * cli/cli-utils.h (extract_info_print_args): Delete.
5319         (struct info_print_options): New structure.
5320         (extract_info_print_options): Declare new function.
5321         * stack.c (info_locals_command): Update to use new
5322         extract_info_print_options, also add a header comment.
5323         (info_args_command): Likewise.
5324         * symtab.c (info_variables_command): Likewise.
5325         (info_functions_command): Likewise.
5326
5327 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5328
5329         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5330         to extract string arguments.
5331         * common/common-utils.c (extract_string_maybe_quoted): New function.
5332         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5333
5334 2019-07-11  Tom Tromey  <tromey@adacore.com>
5335
5336         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5337         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5338         * top.h (gdbinit): Don't declare.
5339         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5340         into...
5341         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5342         * top.c (gdb_init): Don't call init_cli_cmds.
5343         (gdbinit): Remove.
5344         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5345
5346 2019-07-11  Tom Tromey  <tromey@adacore.com>
5347
5348         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5349         after it has been moved.
5350
5351 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5352
5353         * valops.c (value_must_coerce_to_target): Change return type to
5354         bool.
5355         * value.h (value_must_coerce_to_target): Likewise.
5356
5357 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5358
5359         * breakpoint.c (is_hardware_watchpoint): Remove
5360         forward-declaration.
5361         (is_masked_watchpoint): Change return type to bool.
5362         (is_tracepoint): Likewise.
5363         (is_breakpoint): Likewise.
5364         (is_hardware_watchpoint): Likewise.
5365         (is_watchpoint): Likewise.
5366         (is_no_memory_software_watchpoint): Likewise.
5367         (is_catchpoint): Likewise.
5368         (breakpoint_1): Make FILTER parameter's return type bool.
5369         is_masked_watchpoint): Change return type to bool.
5370         (save_breakpoints): Make FILTER parameter's return type bool.
5371         * breakpoint.h (is_breakpoint): Change return type to bool.
5372         (is_watchpoint): Likewise.
5373         (is_catchpoint): Likewise.
5374         (is_tracepoint): Likewise.
5375
5376 2019-07-10  Tom Tromey  <tom@tromey.com>
5377
5378         * defs.h: Don't include gdbarch.h.
5379         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5380         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5381         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5382         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5383         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5384         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5385         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5386         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5387         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5388         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5389         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5390         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5391         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5392         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5393         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5394         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5395         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5396         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5397         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5398         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5399         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5400         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5401         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5402         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5403         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5404         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5405         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5406
5407 2019-07-10  Tom Tromey  <tromey@adacore.com>
5408
5409         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5410         * breakpoint.c (init_ada_exception_breakpoint): Register as
5411         bp_catchpoint.
5412         (print_one_breakpoint_location, print_one_breakpoint): Use
5413         is_ada_exception_catchpoint.
5414         * ada-lang.c (class ada_catchpoint_location): Pass
5415         bp_loc_software_breakpoint to bp_location constructor.
5416         (is_ada_exception_catchpoint): New function.
5417
5418 2019-07-10  Tom Tromey  <tromey@adacore.com>
5419
5420         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5421         VEC.
5422         (struct arm_exidx_entry): New method operator<.
5423         (struct arm_exidx_data) <section_maps>: Change type.
5424         (arm_exidx_data_free): Remove.
5425         (arm_exidx_data_key): Change type.  Move lower.
5426         (arm_exidx_new_objfile): Update.
5427         (arm_compare_exidx_entries): Remove.
5428         (arm_find_exidx_entry, _initialize_arm_tdep)
5429
5430 2019-07-10  Tom Tromey  <tromey@adacore.com>
5431
5432         * solib-spu.c (ocl_program_data_key): Change type.
5433         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5434         Update.
5435
5436 2019-07-10  Tom Tromey  <tromey@adacore.com>
5437
5438         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5439         (struct solib_aix_inferior_data) <library_list>: Change type.
5440         (solib_aix_inferior_data_handle): Change type.
5441         (get_solib_aix_inferior_data): Update.
5442         (solib_aix_free_library_list): Remove.
5443         (library_list_start_library): Update.
5444         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5445         return type.
5446         (solib_aix_get_library_list)
5447         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5448         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5449
5450 2019-07-10  Tom Tromey  <tromey@adacore.com>
5451
5452         * solib-dsbt.c (struct dsbt_info): Add initializers.
5453         (solib_dsbt_pspace_data): Change type.
5454         (dsbt_pspace_data_cleanup): Remove.
5455         (get_dsbt_info, _initialize_dsbt_solib): Update.
5456
5457 2019-07-10  Tom Tromey  <tromey@adacore.com>
5458
5459         * spu-tdep.c (spu_overlay_data): Change type.
5460         (spu_get_overlay_table, spu_overlay_new_objfile)
5461         (_initialize_spu_tdep): Update.
5462
5463 2019-07-10  Tom Tromey  <tromey@adacore.com>
5464
5465         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5466         destructor.
5467         (dbx_objfile_data_key): Change type and declare later.
5468         (DBX_SYMFILE_INFO): Rewrite.
5469         * dbxread.c (dbx_objfile_data_key): Change type.
5470         (dbx_symfile_init): Update.
5471         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5472         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5473         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5474
5475 2019-07-10  Tom Tromey  <tromey@adacore.com>
5476
5477         * jit.c (jit_program_space_key): Change type.  Move lower.
5478         (get_jit_program_space_data): Update.
5479         (jit_program_space_data_cleanup): Remove.
5480         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5481         Update.
5482         (struct jit_program_space_data): Add initializers.
5483
5484 2019-07-10  Tom Tromey  <tromey@adacore.com>
5485
5486         * solib-darwin.c (struct darwin_info): Add initializers.
5487         (solib_darwin_pspace_data): Change type.
5488         (darwin_pspace_data_cleanup): Remove.
5489         (get_darwin_info, _initialize_darwin_solib): Update.
5490
5491 2019-07-10  Tom Tromey  <tromey@adacore.com>
5492
5493         * remote-sim.c (struct sim_inferior_data): Add initializers,
5494         constructor, and destructor.
5495         (sim_inferior_data_key): Change type.  Move lower.
5496         (check_for_duplicate_sim_descriptor): Update.
5497         (get_sim_inferior_data): Use new.  Update.
5498         (~sim_inferior_data_cleanup): Rename from
5499         sim_inferior_data_cleanup.  Simplify.
5500         (gdbsim_close_inferior, simulator_command)
5501         (sim_command_completer, _initialize_remote_sim): Update.
5502         (next_pid, INITIAL_PID): Move earlier.
5503
5504 2019-07-10  Tom Tromey  <tromey@adacore.com>
5505
5506         * python/python-internal.h (create_thread_object): Return
5507         gdbpy_ref.
5508         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5509         * python/py-inferior.c (struct threadlist_entry): Add
5510         constructor.
5511         <thread_obj>: Now a gdbpy_ref.
5512         (thread_to_thread_object): Update.
5513         (add_thread_object): Use new.
5514         (delete_thread_object): Use delete.
5515         (infpy_threads): Update.
5516         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5517         GIL.
5518
5519 2019-07-10  Tom Tromey  <tromey@adacore.com>
5520
5521         * valops.c (value_cast): Specialize error message for Ada.
5522
5523 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5524
5525         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5526
5527 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5528
5529         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5530         bpstat_should_step): Return bool, adjust comments.
5531         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5532         bpstat_should_step): Likewise.
5533
5534 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5535
5536         * features/Makefile: Use feature target descriptions for Arm.
5537         * features/arm/arm-core.c: Generate new file.
5538         * features/arm/arm-fpa.c: Likewise.
5539         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5540         * features/arm/arm-m-profile.c: Likewise.
5541         * features/arm/arm-vfpv2.c: Likewise.
5542         * features/arm/arm-vfpv3.c: Likewise.
5543         * features/arm/xscale-iwmmxt.c: Likewise.
5544         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5545
5546 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5547
5548         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5549         ptrace earlier.
5550
5551 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5552
5553         * features/aarch64-pauth.c: Regenerate.
5554
5555 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5556
5557         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5558         bool.
5559         (bpstat_what): Use false instead of 0.
5560
5561 2019-07-09  Pedro Alves  <palves@redhat.com>
5562
5563         * break-catch-throw.c (is_exception_catchpoint): New.
5564         * breakpoint.c (print_one_breakpoint_location): New parameter
5565         'raw_loc'.  Handle it.  Use
5566         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5567         looking at the breakpoint's type.
5568         (print_one_breakpoint): If handling "maint info breakpoints", also
5569         print locations of exception catchpoints.
5570         * breakpoint.h (is_exception_catchpoint): Declare.
5571
5572 2019-07-09  Pedro Alves  <palves@redhat.com>
5573
5574         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5575         "addr" field.
5576         (allocate_location_exception_catchpoint): New.
5577         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5578         (initialize_throw_catchpoint_ops): Install
5579         allocate_location_exception_catchpoint as allocate_location
5580         method.
5581         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5582         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5583         bp_loc_other.
5584         (breakpoint_address_is_meaningful): Delete.
5585         (bl_address_is_meaningful): New.
5586         (breakpoint_locations_match): Adjust comment.
5587         (bp_location_from_bp_type): New, factored out of...
5588         (bp_location::bp_location(breakpoint *)): ... this.
5589         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5590         factored out of...
5591         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5592         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5593         breakpoint_address_is_meaningful.
5594         (bp_locations_compare): Adjust comment.
5595         (update_global_location_list): Use bl_address_is_meaningful
5596         instead of breakpoint_address_is_meaningful.
5597         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5598         explicit.
5599         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5600         * python/py-breakpoint.c (bppy_get_location): No longer check
5601         whether location is null.
5602
5603 2019-07-09  Pedro Alves  <palves@redhat.com>
5604
5605         PR c++/15468
5606         * breakpoint.c (print_one_breakpoint_location): Remove
5607         single-location assert.
5608
5609 2019-07-09  Tom Tromey  <tom@tromey.com>
5610
5611         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5612         * configure: Rebuild.
5613         * configure.ac: Change common to gdbsupport.
5614         * gdbsupport: Rename from common.
5615         * acinclude.m4: Change common to gdbsupport.
5616         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5617         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5618         gdbsupport.
5619         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5620         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5621         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5622         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5623         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5624         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5625         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5626         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5627         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5628         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5629         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5630         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5631         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5632         coff-pe-read.c, command.h, compile/compile-c-support.c,
5633         compile/compile-c.h, compile/compile-cplus-symbols.c,
5634         compile/compile-cplus-types.c, compile/compile-cplus.h,
5635         compile/compile-loc2c.c, compile/compile.c, completer.c,
5636         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5637         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5638         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5639         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5640         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5641         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5642         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5643         features/aarch64-core.c, features/aarch64-fpu.c,
5644         features/aarch64-pauth.c, features/aarch64-sve.c,
5645         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5646         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5647         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5648         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5649         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5650         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5651         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5652         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5653         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5654         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5655         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5656         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5657         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5658         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5659         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5660         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5661         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5662         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5663         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5664         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5665         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5666         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5667         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5668         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5669         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5670         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5671         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5672         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5673         minsyms.c, mips-linux-tdep.c, namespace.h,
5674         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5675         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5676         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5677         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5678         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5679         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5680         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5681         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5682         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5683         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5684         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5685         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5686         procfs.c, producer.c, progspace.h, psymtab.h,
5687         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5688         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5689         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5690         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5691         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5692         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5693         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5694         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5695         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5696         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5697         target-memory.c, target.c, target.h, target/waitstatus.c,
5698         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5699         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5700         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5701         unittests/array-view-selftests.c,
5702         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5703         unittests/common-utils-selftests.c,
5704         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5705         unittests/format_pieces-selftests.c,
5706         unittests/function-view-selftests.c,
5707         unittests/lookup_name_info-selftests.c,
5708         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5709         unittests/mkdir-recursive-selftests.c,
5710         unittests/observable-selftests.c,
5711         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5712         unittests/parse-connection-spec-selftests.c,
5713         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5714         unittests/scoped_fd-selftests.c,
5715         unittests/scoped_mmap-selftests.c,
5716         unittests/scoped_restore-selftests.c,
5717         unittests/string_view-selftests.c, unittests/style-selftests.c,
5718         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5719         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5720         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5721         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5722         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5723         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5724
5725 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5726
5727         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5728         bool value.
5729         (decode_digits_ordinary): Set explicit_line field in sal.
5730         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5731         symtab_and_line that was set on an explicit line number in
5732         assembler code.  Do always update the recorded symtab and line if
5733         we do skip the prologue.
5734
5735 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * breakpoint.c (set_breakpoint_location_function): Remove
5738         explicit_loc parameter.
5739         (momentary_breakpoint_from_master): Update call to
5740         set_breakpoint_location_function.
5741         (add_location_to_breakpoint): Likewise.
5742
5743 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5744
5745         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5746         required features based on default bfd type when no specific bfd
5747         is present.
5748
5749 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5750
5751         * NEWS: Mention that GDB printf and eval commands can now print
5752         C-style and Ada-style convenience var strings without
5753         calling the inferior.
5754         * printcmd.c (printf_c_string): Locally print GDB internal var
5755         instead of transiting via the inferior.
5756         (printf_wide_c_string): Likewise.
5757
5758 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5759
5760         PR breakpoints/25011
5761         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5762
5763 2019-07-04  Tom Tromey  <tom@tromey.com>
5764
5765         PR tui/24724:
5766         * tui/tui-winsource.c (tui_clear_source_content): Update.
5767         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5768         (tui_update_breakpoint_info): Update.
5769         (tui_set_exec_info_content): Update.
5770         * tui/tui-source.c (tui_set_source_content_nil): Update.
5771         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5772         has_break.
5773         * tui/tui-data.h (enum tui_bp_flag): New.
5774         (tui_bp_flags): New enum flags type.
5775         (struct tui_source_element) <break_mode>: Change type.  Rename
5776         from has_break.
5777         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5778         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5779         constants.
5780         * tui/tui-winsource.h: Fix comment.
5781
5782 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5783
5784         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5785         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5786         (store_fpregs_to_thread)
5787         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5788         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5789         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5790         (IWMMXT_REGS_SIZE): Add define.
5791         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5792         (fetch_vfp_regs, store_vfp_regs)
5793         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5794         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5795
5796 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5797
5798         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5799         defines.
5800         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5801         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5802         (ARM_INT_REGISTER_SIZE): ...to this.
5803         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5804         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5805         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5806         (arm_linux_collect_gregset, supply_nwfpe_register)
5807         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5808         defines.
5809         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5810         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5811         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5812         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5813         (arm_return_in_memory, arm_store_return_value)
5814         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5815         (arm_record_ld_st_multiple): Likewise.
5816         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5817         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5818
5819 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5820
5821         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5822         AARCH64_DISPLACED_MODIFIED_INSNS.
5823         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5824         (aarch64_displaced_step_copy_insn): Likewise.
5825         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5826         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5827         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5828         ARM_DISPLACED_MODIFIED_INSNS.
5829         * arm-tdep.c (arm_gdbarch_init): Likewise.
5830         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5831         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5832         (struct arm_displaced_step_closure): Use
5833         ARM_DISPLACED_MODIFIED_INSNS.
5834
5835 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5836
5837         * features/Makefile: Remove unused xml files.
5838         * features/aarch64.xml: Remove.
5839         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5840         * features/i386/amd64-avx-avx512.xml: Remove.
5841         * features/i386/amd64-avx-linux.xml: Remove.
5842         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5843         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5844         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5845         * features/i386/amd64-avx-mpx.xml: Remove.
5846         * features/i386/amd64-avx.xml: Remove.
5847         * features/i386/amd64-linux.xml: Remove.
5848         * features/i386/amd64-mpx-linux.xml: Remove.
5849         * features/i386/amd64-mpx.xml: Remove.
5850         * features/i386/amd64.xml: Remove.
5851         * features/i386/i386-avx-avx512-linux.xml: Remove.
5852         * features/i386/i386-avx-avx512.xml: Remove.
5853         * features/i386/i386-avx-linux.xml: Remove.
5854         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5855         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5856         * features/i386/i386-avx-mpx-linux.xml: Remove.
5857         * features/i386/i386-avx-mpx.xml: Remove.
5858         * features/i386/i386-avx.xml: Remove.
5859         * features/i386/i386-linux.xml: Remove.
5860         * features/i386/i386-mmx-linux.xml: Remove.
5861         * features/i386/i386-mmx.xml: Remove.
5862         * features/i386/i386-mpx-linux.xml: Remove.
5863         * features/i386/i386-mpx.xml: Remove.
5864         * features/i386/i386.xml: Remove.
5865         * features/i386/x32-avx-avx512-linux.xml: Remove.
5866         * features/i386/x32-avx-linux.xml: Remove.
5867         * features/i386/x32-linux.xml: Remove.
5868
5869 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5870
5871         * regformats/aarch64.dat: Remove.
5872         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5873         * regformats/i386/amd64-avx-linux.dat: Remove.
5874         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5875         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5876         * regformats/i386/amd64-linux.dat: Remove.
5877         * regformats/i386/amd64-mpx-linux.dat: Remove.
5878         * regformats/i386/amd64.dat: Remove.
5879         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5880         * regformats/i386/i386-avx-linux.dat: Remove.
5881         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5882         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5883         * regformats/i386/i386-linux.dat: Remove.
5884         * regformats/i386/i386-mmx-linux.dat: Remove.
5885         * regformats/i386/i386-mpx-linux.dat: Remove.
5886         * regformats/i386/i386.dat: Remove.
5887         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5888         * regformats/i386/x32-avx-linux.dat: Remove.
5889         * regformats/i386/x32-linux.dat: Remove.
5890
5891 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5892
5893         * aarch64-tdep.c: Remove xml self tests.
5894         * amd64-linux-tdep.c: Likewise.
5895         * amd64-tdep.c: Likewise.
5896         * i386-linux-tdep.c: Likewise.
5897         * i386-tdep.c: Likewise.
5898
5899 2019-07-03  Pedro Alves  <palves@redhat.com>
5900
5901         PR cli/24732
5902         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5903         (pipe_cmd_option_defs): New.
5904         (make_pipe_cmd_options_def_group): New.
5905         (pipe_command): Use gdb::option::process_options.
5906         (pipe_command_completer): New function.
5907         (_initialize_cli_cmds): Install completer for "pipe" command.
5908
5909 2019-07-03  Pedro Alves  <palves@redhat.com>
5910
5911         * cli/cli-option.c (union option_value) <string>: New field.
5912         (struct option_def_and_value): Add ctor, move ctor, dtor and
5913         use DISABLE_COPY_AND_ASSIGN.
5914         (option_def_and_value::clear_value): New.
5915         (parse_option, save_option_value_in_ctx, get_val_type_str)
5916         (add_setshow_cmds_for_options): Handle var_string.
5917         * cli-option.h (union option_def::var_address) <string>: New
5918         field.
5919         (struct string_option_def): New.
5920         * maint-test-options.c (struct test_options_opts): Add default
5921         ctor and use DISABLE_COPY_AND_ASSIGN.
5922         <string_opt>: New field.
5923         (test_options_opts::~test_options_opts): New.
5924         (test_options_opts::dump): Also dump "-string".
5925         (test_options_option_defs): Install "string.
5926
5927 2019-07-03  Pedro Alves  <palves@redhat.com>
5928
5929         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5930         option_value with a null enumeration.
5931         (complete_options): Save the option values in the context.
5932         (save_option_value_in_ctx): New, factored out from ...
5933         (process_options): ... here.
5934         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5935         of the function.
5936         * maint-test-options.c (test_options_opts::dump): New, factored
5937         out from ...
5938         (maintenance_test_options_command_mode): ... here.
5939         (maintenance_test_options_command_completion_result): Delete.
5940         (maintenance_test_options_command_completion_text): Update
5941         comment.
5942         (maintenance_show_test_options_completion_result): Change
5943         prototype.  Just print
5944         maintenance_test_options_command_completion_text.
5945         (save_completion_result): New.
5946         (maintenance_test_options_completer_mode): Pass options context to
5947         complete_options, and then save a dump.
5948         (_initialize_maint_test_options): Use add_cmd to install "maint
5949         show test-options-completion-result".
5950
5951 2019-07-03  Pedro Alves  <palves@redhat.com>
5952
5953         * NEWS (New commands): Mention "with" and "maint with".
5954         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5955         (with_command, with_command_completer): New.
5956         (pipe_command): Adjust to new repeat_previous
5957         interface.
5958         (_initialize_cli_cmds): Install the "with" command and its "w"
5959         alias.
5960         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5961         declarations.
5962         * cli/cli-setshow.c (parse_cli_var_uinteger)
5963         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5964         argument strings for all var_types.
5965         (get_setshow_command_value_string): New, factored out from ...
5966         (do_show_command): ... this.
5967         * cli/cli-setshow.h: Include <string>.
5968         (get_setshow_command_value_string): Declare.
5969         * command.h (repeat_previous): Now returns const char *.  Adjust
5970         comment.
5971         * maint.c: Include "cli/cli-cmds.h".
5972         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5973         (_initialize_maint_cmds): Register the "maintenance with" command.
5974         * top.c (repeat_previous): Move bits from pipe_command here:
5975         Return the saved command line, if any; error out if there's no
5976         command to relaunch.
5977
5978 2019-07-03  Pedro Alves  <palves@redhat.com>
5979
5980         * NEWS (New commands): Mention "maint set/show test-settings"
5981         instead of "maint test-settings".
5982         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5983         (maintenance_test_settings_set_list): Rename to ...
5984         (maintenance_set_test_settings_list): ... this.
5985         (maintenance_test_settings_show_list): Rename to  ...
5986         (maintenance_show_test_settings_list): ... this.
5987         (maintenance_test_settings_cmd): Delete.
5988         (maintenance_test_settings_set_cmd): ...
5989         (maintenance_set_test_settings_cmd): ... this.
5990         (maintenance_test_settings_show_cmd): ...
5991         (maintenance_show_test_settings_cmd): ... this.
5992         (maintenance_test_settings_show_value_cmd):
5993         (maintenance_show_test_settings_value_cmd): ... this.
5994         (_initialize_maint_test_settings): No longer install the "maint
5995         test-settings" prefix command.  Rename "maint test-settings set"
5996         to "maint set test-settings", and "maint test-settings show" to
5997         "maint show test-settings".  Adjust all subcommands.
5998
5999 2019-07-03  Pedro Alves  <palves@redhat.com>
6000
6001         * maint-test-settings.c: Fix file's intro comment.  Replace all
6002         references to "test-options" with references to "test-settings",
6003         in comments.
6004
6005 2019-07-03  Pedro Alves  <palves@redhat.com>
6006
6007         * maint-test-settings.c (maintenance_test_settings_xxx)
6008         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6009         New.
6010         (maintenance_test_settings_enums): Use them.
6011         (maintenance_test_settings_enum): Default to
6012         maintenance_test_settings_xxx.
6013         (_initialize_maint_test_settings): Initialize
6014         MAINTENANCE_TEST_SETTINGS_FILENAME.
6015
6016 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6017
6018         * breakpoint.h (remove_breakpoints_inf): Change return type to
6019         void, move function documentation here.
6020         * breakpoint.c (remove_breakpoints_inf): Change return type to
6021         void, move function documentation to header.
6022
6023 2019-07-02  Pedro Alves  <palves@redhat.com>
6024
6025         * NEWS (Completion improvements): Mention "info threads".
6026         * thread.c (struct info_threads_opts, info_threads_option_defs)
6027         (make_info_threads_options_def_group): New.
6028         (info_threads_command): Use gdb::option::process_options.
6029         (info_threads_command_completer): New.
6030         (_initialize_thread): Use gdb::option::build_help to build the
6031         help text for "info threads".
6032
6033 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6034
6035         * defs.h (generic_load): Move from here...
6036         * symfile.h (generic_load): ... to here.  Rename name parameter
6037         to args.
6038         * symfile.c (generic_load): Add comment.
6039
6040 2019-07-01  Tom Tromey  <tromey@adacore.com>
6041
6042         * dwarf2read.c
6043         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6044         declaration of without_params.  Fix formatting.
6045
6046 2019-07-01  Tom Tromey  <tromey@adacore.com>
6047
6048         * ada-exp.y (find_primitive_type): Update.
6049         * ada-lang.h (ada_lookup_symbol): Update.
6050         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6051         parameter.
6052         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6053
6054 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6055
6056         PR breakpoints/24541
6057         * gdbarch.c: Regenerate.
6058         * gdbarch.h: Regenerate.
6059         * gdbarch.sh: Add 'stap_adjust_register'.
6060         * i386-tdep.c: Include '<unordered_set>'.
6061         (i386_stap_adjust_register): New function.
6062         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6063         * stap-probe.c (stap_parse_register_operand): Call
6064         'gdbarch_stap_adjust_register'.
6065
6066 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6067
6068         PR python/24742
6069         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6070         * python/python.c (do_start_initialization): Use 'xmalloc'
6071         instead of 'PyMem_Malloc'.
6072
6073 2019-06-28  Tom Tromey  <tromey@adacore.com>
6074
6075         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6076         for Ada.
6077
6078 2019-06-27  Tom Tromey  <tromey@adacore.com>
6079
6080         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6081         objfile_key.
6082         (arm_find_mapping_symbol, arm_record_special_symbol)
6083         (_initialize_arm_tdep): Update.
6084         (arm_objfile_data_free): Remove.
6085
6086 2019-06-27  Tom Tromey  <tromey@adacore.com>
6087
6088         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6089         to cp_print_static_field.
6090
6091 2019-06-26  Tom Tromey  <tromey@adacore.com>
6092
6093         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6094         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6095         declare.
6096
6097 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6098
6099         * features/aarch64-core.c (create_feature_aarch64_core):
6100         Regenerate.
6101         * features/aarch64-core.xml: Add cpsr flags.
6102
6103 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6104
6105         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6106         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6107
6108 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6109
6110         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6111         field.
6112         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6113         use.
6114         (arm_record_special_symbol): Don't insert new symbol in sorted
6115         position, push it at the end.
6116
6117 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6118
6119         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6120         (arm_mapping_symbol_s): Remove.
6121         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6122         (arm_mapping_symbol_vec): New typedef.
6123         (struct arm_per_objfile): Add constructor.
6124         <section_maps>: Change type to
6125         std::unique_ptr<arm_mapping_symbol_vec[]>.
6126         (arm_compare_mapping_symbols): Remove.
6127         (arm_find_mapping_symbol): Adjust to section_maps type change.
6128         (arm_objfile_data_free): Call delete on arm_per_objfile.
6129         (arm_record_special_symbol): Adjust to section_maps type change.
6130         Allocate arm_per_objfile with new.
6131
6132 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6133
6134         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6135         with the command prefix.
6136
6137 2019-06-25  Tom Tromey  <tom@tromey.com>
6138
6139         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6140         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6141
6142 2019-06-25  Tom Tromey  <tom@tromey.com>
6143
6144         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6145         type.
6146         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6147         protected.
6148
6149 2019-06-25  Tom Tromey  <tom@tromey.com>
6150
6151         * tui/tui-winsource.c
6152         (tui_source_window_base::set_is_exec_point_at): Add check against
6153         LOA_ADDRESS.
6154
6155 2019-06-25  Tom Tromey  <tom@tromey.com>
6156
6157         * tui/tui-source.c (tui_set_source_content): Don't check before
6158         xfree.
6159         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6160
6161 2019-06-25  Tom Tromey  <tom@tromey.com>
6162
6163         * tui/tui-winsource.h (tui_update_source_window_as_is)
6164         (tui_alloc_source_buffer, tui_line_is_displayed)
6165         (tui_addr_is_displayed): Change type of win_info.
6166         * tui/tui-winsource.c (tui_update_source_window_as_is)
6167         (tui_clear_source_content, tui_show_source_line)
6168         (tui_show_source_content, tui_source_window_base::refill)
6169         (tui_source_window_base::set_is_exec_point_at)
6170         (tui_source_window_base::set_is_exec_point_at)
6171         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6172         (tui_alloc_source_buffer, tui_line_is_displayed)
6173         (tui_addr_is_displayed): Change type of win_info.  Update.
6174         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6175         (tui_source_window_base::do_make_visible_with_new_height):
6176         Update.
6177         * tui/tui-source.c (tui_set_source_content)
6178         (tui_set_source_content_nil)
6179         (tui_source_window::do_scroll_vertical): Update.
6180         * tui/tui-layout.c (show_layout): Update.
6181         * tui/tui-disasm.c (tui_set_disassem_content)
6182         (tui_disasm_window::do_scroll_vertical): Update.
6183         * tui/tui-data.h (tui_win_content): Remove.
6184         (struct tui_gen_win_info) <content, content_size>: Remove.
6185         (struct tui_source_element): Add initializers and destructor.
6186         (union tui_which_element, struct tui_win_element): Remove.
6187         (struct tui_source_window_base) <content>: New field.
6188         (struct tui_data_window): Remove destructor.
6189         (tui_alloc_content, tui_free_win_content)
6190         (tui_free_all_source_wins_content): Don't declare.
6191         * tui/tui-data.c (tui_initialize_static_data): Update.
6192         (init_content_element, tui_alloc_content): Remove.
6193         (~tui_gen_win_info): Update.
6194         (~tui_data_window, tui_free_all_source_wins_content)
6195         (tui_free_win_content, free_content, free_content_elements):
6196         Remove.
6197
6198 2019-06-25  Tom Tromey  <tom@tromey.com>
6199
6200         * tui/tui-winsource.h (tui_clear_source_content)
6201         (tui_erase_source_content, tui_show_source_content): Change type
6202         of win_info.
6203         * tui/tui-winsource.c (tui_clear_source_content)
6204         (tui_erase_source_content, tui_show_source_content): Change type
6205         of win_info.
6206         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6207         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6208         win_info.
6209         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6210         win_info.
6211         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6212
6213 2019-06-25  Tom Tromey  <tom@tromey.com>
6214
6215         * tui/tui-winsource.c (tui_clear_source_content)
6216         (tui_source_window_base::set_is_exec_point_at): Update.
6217         * tui/tui-source.c (tui_set_source_content_nil): Update.
6218         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6219         a bool.
6220         * tui/tui-data.c (init_content_element): Update.
6221
6222 2019-06-25  Tom Tromey  <tom@tromey.com>
6223
6224         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6225         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6226         * tui/tui-layout.c (init_and_make_win): Update.
6227         * tui/tui.h (enum tui_win_type): Update.
6228         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6229         tui_win_is_auxillary.
6230         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6231         tui_win_is_auxillary.
6232
6233 2019-06-25  Tom Tromey  <tom@tromey.com>
6234
6235         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6236         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6237         (tui_delete_data_content_windows, tui_display_all_data)
6238         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6239         Update.
6240         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6241         * tui/tui-regs.c (tui_last_regs_line_no)
6242         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6243         (tui_show_registers): Update.
6244         (tui_show_register_group): Return void.  Update.
6245         (tui_display_registers_from, tui_display_reg_element_at_line)
6246         (tui_display_registers_from_line, tui_check_register_values):
6247         Update.
6248         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6249         member.
6250         (struct tui_data_window) <regs_content>: Now a std::vector.
6251         <regs_content_count>: Remove.
6252         (tui_add_content_elements, tui_free_data_content): Don't declare.
6253         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6254         (init_content_element): Remove DATA_WIN case.  Add assert.
6255         (tui_add_content_elements): Remove.
6256         (tui_data_window): Update.
6257         (tui_free_data_content): Remove.
6258         (free_content_elements): Remove DATA_WIN case.
6259
6260 2019-06-25  Tom Tromey  <tom@tromey.com>
6261
6262         * tui/tui-data.c (tui_data_item_window): Update.
6263         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6264         * tui/tui-windata.c (tui_display_all_data)
6265         (tui_display_data_from_line): Update.
6266         (tui_check_data_values): Remove.
6267         * tui/tui-regs.c (tui_show_register_group)
6268         (tui_display_reg_element_at_line): Update.
6269         * tui/tui-hooks.c (tui_register_changed)
6270         (tui_refresh_frame_and_register_information): Call
6271         tui_check_register_values.
6272         * tui/tui-data.h (struct tui_data_window) <data_content,
6273         data_content_count, data_type>: Remove.
6274         (enum tui_data_type): Remove.
6275
6276         * tui/tui-data.c (tui_data_window::clear_detail)
6277         (~tui_data_window): Update.
6278
6279 2019-06-25  Tom Tromey  <tom@tromey.com>
6280
6281         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6282         declare.
6283         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6284         Rename from tui_first_data_item_displayed.  Update.
6285         (tui_data_window::refresh_all)
6286         (tui_data_window::do_scroll_vertical): Update.
6287         * tui/tui-data.h (struct tui_data_window)
6288         <first_data_item_displayed>: Declare new method.
6289
6290 2019-06-25  Tom Tromey  <tom@tromey.com>
6291
6292         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6293         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6294         contents...
6295         (tui_initialize_static_data): ...here.
6296
6297 2019-06-25  Tom Tromey  <tom@tromey.com>
6298
6299         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6300         (tui_display_registers_from, tui_check_register_values): Update.
6301         (tui_display_register): Remove win_info parameter; update.
6302         (tui_get_register): Change type of parameters.
6303         * tui/tui-data.h (struct tui_data_element): Remove.
6304         (union tui_which_element) <data>: Remove.
6305         <data_window>: Change type.
6306         (struct tui_data_item_window): New.
6307         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6308         case.  Add assert.
6309         (~tui_data_item_window): New destructor.
6310         (free_content_elements): Remove DATA_ITEM_WIN case.
6311
6312 2019-06-25  Tom Tromey  <tom@tromey.com>
6313
6314         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6315         Remove.
6316
6317 2019-06-25  Tom Tromey  <tom@tromey.com>
6318
6319         * tui/tui-data.h (struct tui_command_element): Remove.
6320         (union tui_which_element) <command>: Remove.
6321         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6322         assert.
6323         (free_content_elements): Remove CMD_WIN case.
6324
6325 2019-06-25  Tom Tromey  <tom@tromey.com>
6326
6327         * tui/tui-layout.c (tui_set_layout): Update.
6328         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6329         * tui/tui-data.c (layout_def): Update.
6330
6331 2019-06-25  Tom Tromey  <tom@tromey.com>
6332
6333         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6334         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6335         (tui_source_window_base::set_new_height): Update.
6336         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6337         Update.
6338         (tui_set_locator_fullname, tui_set_locator_info)
6339         (tui_show_frame_info): Update.
6340         * tui/tui-source.c (tui_set_source_content)
6341         (tui_source_is_displayed): Update.
6342         * tui/tui-layout.c (show_source_disasm_command, show_data)
6343         (show_source_or_disasm_and_command): Update.
6344         * tui/tui-disasm.c (tui_set_disassem_content)
6345         (tui_get_begin_asm_address): Update.
6346         * tui/tui-data.h (struct tui_locator_element): Remove.
6347         (union tui_which_element) <locator>: Remove.
6348         (struct tui_locator_window): New.
6349         (tui_locator_win_info_ptr): Change return type.
6350         * tui/tui-data.c (_locator): Change type.
6351         (tui_locator_win_info_ptr): Change return type.
6352         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6353         (tui_alloc_content): Add assert.
6354
6355 2019-06-25  Tom Tromey  <tom@tromey.com>
6356
6357         * tui/tui-winsource.c
6358         (tui_exec_info_window::maybe_allocate_content): New method.
6359         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6360         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6361         (make_source_or_disasm_window): Add cast.
6362         * tui/tui-data.h (union tui_which_element) <simple_string>:
6363         Remove.
6364         (struct tui_source_info): New.
6365         (struct tui_source_window_base) <execution_info>: Change type.
6366         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6367         case, and add assert.
6368         (tui_alloc_content): Add assert.
6369
6370 2019-06-25  Tom Tromey  <tom@tromey.com>
6371
6372         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6373         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6374         * tui/tui-data.c (tui_alloc_win_info): Remove.
6375
6376 2019-06-25  Tom Tromey  <tom@tromey.com>
6377
6378         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6379         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6380         can_highlight.
6381
6382 2019-06-25  Tom Tromey  <tom@tromey.com>
6383
6384         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6385         make_visible_with_new_height method.
6386         (tui_win_info::make_visible_with_new_height): New method.
6387         (tui_source_window_base::do_make_visible_with_new_height)
6388         (tui_data_window::do_make_visible_with_new_height)
6389         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6390         (make_visible_with_new_height): Remove.
6391         (tui_resize_all, tui_adjust_win_heights): Use
6392         make_visible_with_new_height method.
6393         * tui/tui-data.h (struct tui_win_info)
6394         <do_make_visible_with_new_height, make_visible_with_new_height>:
6395         New methods.
6396         (struct tui_source_window_base, struct tui_data_window)
6397         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6398         methods.
6399
6400 2019-06-25  Tom Tromey  <tom@tromey.com>
6401
6402         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6403         method.
6404         (update_tab_width): Call update_tab_width method.
6405         * tui/tui-data.h (struct tui_win_info)
6406         (struct tui_source_window_base) <update_tab_width>: New methods.
6407
6408 2019-06-25  Tom Tromey  <tom@tromey.com>
6409
6410         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6411         parameter.
6412         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6413         parameter.
6414         (tui_gen_win_info::make_visible): Update.
6415         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6416         parameter.
6417         * tui/tui-data.h (enum tui_box): New enum.
6418         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6419
6420 2019-06-25  Tom Tromey  <tom@tromey.com>
6421
6422         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6423         init_and_make_win for EXEC_INFO_WIN.
6424         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6425         longer inline.
6426         (struct tui_win_info) <~tui_win_info>: Inline.
6427         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6428         Don't declare.
6429         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6430         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6431         Remove.
6432         (tui_initialize_static_data): Update.
6433         (~tui_gen_win_info): Handle more cleanup here.
6434         (~tui_source_window_base): Delete "execution_info".
6435         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6436
6437 2019-06-25  Tom Tromey  <tom@tromey.com>
6438
6439         * tui/tui-layout.c (make_command_window): Don't set
6440         can_highlight.
6441         (show_source_disasm_command): Call the reset method.
6442         (show_data): Don't set can_highlight.  Call the reset method.
6443         (tui_gen_win_info::reset): Rename from init_gen_win_info
6444         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6445         (show_source_or_disasm_and_command): Call the reset method.
6446         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6447         (struct tui_cmd_window): Set can_highlight.
6448
6449 2019-06-25  Tom Tromey  <tom@tromey.com>
6450
6451         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6452         from make_visible.
6453         (tui_make_visible, tui_make_invisible): Rewrite.
6454         (tui_win_info::make_visible): Remove.
6455         (tui_source_window_base::make_visible): Update.
6456         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6457         method.  Moved from...
6458         (struct tui_win_info) <make_visible>: ...here.
6459
6460 2019-06-25  Tom Tromey  <tom@tromey.com>
6461
6462         * tui/tui-winsource.c
6463         (tui_source_window_base::do_scroll_horizontal): Remove direction
6464         parameter.
6465         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6466         direction parameter.
6467         * tui/tui-win.c (tui_win_info::forward_scroll)
6468         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6469         (tui_win_info::right_scroll): Update.
6470         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6471         direction parameter.
6472         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6473         direction parameter.
6474         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6475         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6476         Remove direction parameter.
6477         (struct tui_source_window_base, struct tui_source_window)
6478         (struct tui_disasm_window, struct tui_data_window)
6479         (struct tui_cmd_window): Update.
6480
6481 2019-06-25  Tom Tromey  <tom@tromey.com>
6482
6483         * tui/tui-winsource.h (tui_set_exec_info_content)
6484         (tui_show_exec_info_content, tui_erase_exec_info_content)
6485         (tui_clear_exec_info_content, tui_update_exec_info): Change
6486         argument to tui_source_window_base.
6487         * tui/tui-winsource.c (tui_set_exec_info_content)
6488         (tui_show_exec_info_content, tui_erase_exec_info_content)
6489         (tui_clear_exec_info_content, tui_update_exec_info): Change
6490         argument to tui_source_window_base.
6491
6492 2019-06-25  Tom Tromey  <tom@tromey.com>
6493
6494         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6495         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6496
6497 2019-06-25  Tom Tromey  <tom@tromey.com>
6498
6499         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6500         check.
6501
6502 2019-06-25  Tom Tromey  <tom@tromey.com>
6503
6504         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6505         type to void.
6506         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6507         type to void.
6508         * tui/tui-source.c (tui_set_source_content): Update.
6509         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6510
6511 2019-06-25  Tom Tromey  <tom@tromey.com>
6512
6513         * tui/tui-win.c (window_name_completer, tui_set_focus)
6514         (tui_all_windows_info): Use name method.
6515         * tui/tui-data.h (struct tui_gen_win_info)
6516         (struct tui_source_window, struct tui_disasm_window)
6517         (struct tui_data_window, struct tui_cmd_window) <name>: New
6518         method.
6519         (tui_win_name): Don't declare.
6520         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6521         (tui_win_name): Remove.
6522
6523 2019-06-25  Tom Tromey  <tom@tromey.com>
6524
6525         * tui/tui-winsource.h (tui_update_source_window)
6526         (tui_update_source_window_as_is): Change parameter type.
6527         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6528         to be a tui_source_window_base.
6529         (tui_update_source_window_as_is): Likewise.
6530         * tui/tui-win.c (make_visible_with_new_height): Update.
6531
6532 2019-06-25  Tom Tromey  <tom@tromey.com>
6533
6534         * tui/tui-winsource.c (tui_erase_source_content)
6535         (tui_show_source_content, tui_show_exec_info_content)
6536         (tui_erase_exec_info_content): Use refresh_window method.
6537         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6538         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6539         from tui_refresh_win.
6540         (tui_data_window::refresh_window): New method.
6541         (tui_win_info::refresh, tui_source_window_base::refresh)
6542         (tui_refresh_all): Use refresh_window method.
6543         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6544         method.
6545         * tui/tui-regs.c (tui_display_register): Call refresh_window
6546         method.
6547         * tui/tui-layout.c (show_source_disasm_command)
6548         (show_source_or_disasm_and_command): Call refresh_window method.
6549         * tui/tui-data.h (struct tui_gen_win_info)
6550         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6551         New method.
6552
6553 2019-06-25  Tom Tromey  <tom@tromey.com>
6554
6555         * tui/tui.c (tui_rl_other_window, tui_enable)
6556         (tui_is_window_visible, tui_get_command_dimension): Update.
6557         * tui/tui-winsource.c (tui_update_source_window_as_is)
6558         (tui_clear_source_content, tui_erase_source_content)
6559         (tui_show_source_line, tui_source_window_base::refill)
6560         (tui_source_window_base::do_scroll_horizontal)
6561         (tui_source_window_base::set_is_exec_point_at)
6562         (tui_update_breakpoint_info, tui_set_exec_info_content)
6563         (tui_alloc_source_buffer, tui_line_is_displayed)
6564         (tui_addr_is_displayed): Update.
6565         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6566         (tui_check_and_display_highlight_if_needed)
6567         (tui_win_info::make_visible, tui_win_info::refresh)
6568         (tui_refresh_all): Update.
6569         * tui/tui-windata.c (tui_first_data_item_displayed)
6570         (tui_delete_data_content_windows, tui_erase_data_content)
6571         (tui_display_all_data, tui_data_window::refresh_all)
6572         (tui_check_data_values): Update.
6573         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6574         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6575         (tui_win_info::backward_scroll, tui_refresh_all_win)
6576         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6577         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6578         (tui_source_window_base::set_new_height)
6579         (tui_data_window::set_new_height)
6580         (make_invisible_and_set_new_height)
6581         (make_visible_with_new_height, new_height_ok)
6582         (parse_scrolling_args): Update.
6583         * tui/tui-stack.c (tui_show_frame_info): Update.
6584         * tui/tui-source.c (tui_set_source_content)
6585         (tui_set_source_content_nil, tui_source_is_displayed)
6586         (tui_source_window::do_scroll_vertical): Update.
6587         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6588         (tui_display_registers_from, tui_display_reg_element_at_line)
6589         (tui_check_register_values, tui_reg_command): Update.
6590         * tui/tui-layout.c (tui_default_win_height)
6591         (show_source_disasm_command, show_data, init_and_make_win)
6592         (show_source_or_disasm_and_command): Update.
6593         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6594         (tui_redisplay_readline, tui_mld_flush)
6595         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6596         (tui_getc): Update.
6597         * tui/tui-disasm.c (tui_set_disassem_content)
6598         (tui_disasm_window::do_scroll_vertical): Update.
6599         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6600         Now virtual.
6601         (struct tui_win_info): Derive from tui_gen_win_info.
6602         <~tui_win_info>: Mark as override.
6603         <generic>: Remove member.
6604         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6605         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6606         (~tui_data_window, ~tui_win_info)
6607         (tui_free_all_source_wins_content): Update.
6608         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6609
6610 2019-06-25  Tom Tromey  <tom@tromey.com>
6611
6612         * tui/tui-layout.c (init_and_make_win): Use new.
6613         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6614         destructor, initializers.
6615         (tui_alloc_generic_win_info): Don't declare.
6616         * tui/tui-data.c (_locator): Add argument to constructor.
6617         (source_win, disasm_win): New globals.
6618         (exec_info): Remove.
6619         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6620         Update.
6621         (tui_alloc_generic_win_info): Remove.
6622         (init_content_element): Use new.
6623         (tui_win_info::tui_win_info): Update.
6624         (free_content_elements) <case DATA_WIN>: Use delete.
6625
6626 2019-06-25  Tom Tromey  <tom@tromey.com>
6627
6628         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6629         * tui/tui-windata.c (tui_first_data_item_displayed)
6630         (tui_delete_data_content_windows): Update.
6631         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6632         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6633         (tui_display_registers_from, tui_check_register_values): Update.
6634         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6635         pointer.
6636         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6637         window.
6638         (tui_free_data_content): Update.
6639         (free_content_elements) <case DATA_WIN>: Free the window.
6640
6641 2019-06-25  Tom Tromey  <tom@tromey.com>
6642
6643         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6644         Update.
6645         * tui/tui-layout.c (make_command_window)
6646         (show_source_disasm_command, show_data, init_and_make_win)
6647         (show_source_or_disasm_and_command): Update.
6648         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6649         method.
6650         <can_highight, is_highlighted>: Now bool.
6651         (tui_set_win_highlight): Don't declare.
6652         * tui/tui-data.c (tui_set_win_highlight): Remove.
6653
6654 2019-06-25  Tom Tromey  <tom@tromey.com>
6655
6656         * tui/tui-wingeneral.c (make_visible): Remove check of window
6657         type.
6658
6659 2019-06-25  Tom Tromey  <tom@tromey.com>
6660
6661         * tui/tui-win.c (tui_win_info::max_height)
6662         (tui_cmd_window::max_height): New methods.
6663         (new_height_ok): Call max_height.
6664         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6665         <max_height>: New method.
6666
6667 2019-06-25  Tom Tromey  <tom@tromey.com>
6668
6669         * tui/tui-win.c (tui_source_window_base::set_new_height)
6670         (tui_data_window::set_new_height): New methods.
6671         (make_invisible_and_set_new_height): Call set_new_height method.
6672         * tui/tui-data.h (struct tui_win_info)
6673         (struct tui_source_window_base, struct tui_data_window)
6674         <set_new_height>: New method.
6675
6676 2019-06-25  Tom Tromey  <tom@tromey.com>
6677
6678         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6679         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6680         tui_refresh_data_win.
6681         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6682         method.
6683         (tui_refresh_all_win): Call the refresh_all method.
6684         (tui_set_focus): Likewise.
6685         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6686         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6687         Likewise.
6688
6689 2019-06-25  Tom Tromey  <tom@tromey.com>
6690
6691         * tui/tui-winsource.h (tui_refill_source_window)
6692         (tui_set_is_exec_point_at): Don't declare.
6693         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6694         (tui_source_window_base::refill): Rename from
6695         tui_refill_source_window.
6696         (tui_source_window_base::do_scroll_horizontal): Update.
6697         (tui_source_window_base::set_is_exec_point_at): Rename from
6698         tui_set_is_exec_point_at.
6699         (tui_update_all_breakpoint_info): Update.
6700         * tui/tui-stack.c (tui_show_frame_info): Update.
6701         * tui/tui-layout.c (show_data): Add cast.
6702         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6703         * tui/tui-data.h (struct tui_source_window_base) <refill,
6704         set_is_exec_point_at>: New methods.
6705         (tui_source_windows, tui_add_to_source_windows): Update types.
6706         (tui_add_to_source_windows): Remove redundant declaration.
6707         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6708         (tui_source_windows): Change return type.
6709         (tui_clear_source_windows_detail): Update.
6710         (tui_add_to_source_windows): Change type of parameter.
6711         (tui_free_all_source_wins_content): Update.
6712
6713 2019-06-25  Tom Tromey  <tom@tromey.com>
6714
6715         * tui/tui-wingeneral.c (tui_win_info::refresh)
6716         (tui_source_window_base::refresh): New methods.
6717         (tui_refresh_all): Call the refresh method.
6718         * tui/tui-data.h (struct tui_win_info)
6719         (struct tui_source_window_base) <refresh>: New method.
6720
6721 2019-06-25  Tom Tromey  <tom@tromey.com>
6722
6723         * tui/tui.h (tui_is_window_visible): Return bool.
6724         * tui/tui.c (tui_is_window_visible): Return bool.
6725         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6726         (tui_make_visible, tui_make_invisible)
6727         (tui_win_info::make_visible)
6728         (tui_source_window_base::make_visible, make_all_visible)
6729         (tui_make_all_visible, tui_make_all_invisible): Update.
6730         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6731         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6732         bool.
6733         (struct tui_win_info, struct tui_source_window_base)
6734         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6735         * tui/tui-data.c (tui_init_generic_part): Update.
6736
6737 2019-06-25  Tom Tromey  <tom@tromey.com>
6738
6739         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6740         (tui_source_window_base::make_visible): New methods.
6741         (make_all_visible): Make method call.
6742         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6743         (struct tui_source_window_base, struct tui_cmd_window): Override
6744         make_visible.
6745         (tui_win_is_source_type): Don't declare.
6746         * tui/tui-data.c (tui_win_is_source_type): Remove.
6747
6748 2019-06-25  Tom Tromey  <tom@tromey.com>
6749
6750         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6751         NULL check.
6752
6753 2019-06-25  Tom Tromey  <tom@tromey.com>
6754
6755         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6756         Inline constructor.  Add initializers for members.
6757         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6758         constructors; now inline in class.
6759
6760 2019-06-25  Tom Tromey  <tom@tromey.com>
6761
6762         * tui/tui-regs.c (tui_show_registers): Update.
6763         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6764         bool.
6765         * tui/tui-data.c (tui_data_window::clear_detail)
6766         (tui_data_window): Update.
6767
6768 2019-06-25  Tom Tromey  <tom@tromey.com>
6769
6770         * tui/tui-windata.c (tui_display_all_data)
6771         (tui_display_data_from_line, tui_display_data_from)
6772         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6773         Update.
6774         * tui/tui-regs.c (tui_last_regs_line_no)
6775         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6776         (tui_show_registers, tui_show_register_group)
6777         (tui_display_registers_from, tui_display_reg_element_at_line)
6778         (tui_display_registers_from_line, tui_check_register_values)
6779         (tui_reg_next, tui_reg_prev): Update.
6780         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6781         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6782         tui_data_window.
6783         (struct tui_win_info) <detail>: Remove.  Add new fields from
6784         tui_data_info.
6785         (TUI_DATA_WIN): Add cast.
6786         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6787         (~tui_data_window): Simplify.
6788
6789 2019-06-25  Tom Tromey  <tom@tromey.com>
6790
6791         * tui/tui-layout.c (show_source_disasm_command)
6792         (show_source_or_disasm_and_command): Update.
6793         * tui/tui-io.c (update_cmdwin_start_line)
6794         (tui_redisplay_readline): Update.
6795         * tui/tui-data.h (struct tui_command_info): Remove.
6796         (struct tui_win_info) <detail>: Remove command_info member.
6797         (struct tui_data_window) <start_line>: New member, from
6798         tui_command_info.
6799         (TUI_CMD_WIN): Add casts.
6800
6801 2019-06-25  Tom Tromey  <tom@tromey.com>
6802
6803         * tui/tui-winsource.c (tui_update_source_window)
6804         (tui_refill_source_window)
6805         (tui_source_window_base::do_scroll_horizontal)
6806         (tui_update_breakpoint_info, tui_set_exec_info_content)
6807         (tui_show_exec_info_content, tui_erase_exec_info_content)
6808         (tui_clear_exec_info_content): Update.
6809         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6810         Update.
6811         * tui/tui-win.c (make_invisible_and_set_new_height)
6812         (make_visible_with_new_height): Update.
6813         * tui/tui-source.c (tui_set_source_content)
6814         (tui_show_symtab_source): Update.
6815         * tui/tui-layout.c (extract_display_start_addr)
6816         (show_source_disasm_command, show_data)
6817         (make_source_or_disasm_window)
6818         (show_source_or_disasm_and_command): Update.
6819         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6820         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6821         "gdbarch".
6822         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6823         to tui_source_window_base.
6824         (struct tui_win_info) <detail>: Remove source_info member.
6825         (struct tui_source_window_base) <has_locator>: Inline.
6826         Move contents from tui_source_info; rename has_locator member to
6827         m_has_locator.
6828         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6829         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6830         header file.
6831         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6832         Simplify.
6833         (tui_free_all_source_wins_content): Cast to
6834         tui_source_window_base.
6835
6836 2019-06-25  Tom Tromey  <tom@tromey.com>
6837
6838         * tui/tui-win.c (make_invisible_and_set_new_height)
6839         (make_visible_with_new_height): Call has_locator method.
6840         * tui/tui-layout.c (show_source_disasm_command, show_data)
6841         (show_source_or_disasm_and_command): Update for bool change.
6842         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6843         (tui_win_info) <has_locator>: New method.
6844         (struct tui_source_window_base) <has_locator>: New method.
6845         (tui_win_has_locator): Don't declare.
6846         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6847         from tui_win_has_locator.
6848         (tui_source_window_base): Use false, not FALSE.
6849
6850 2019-06-25  Tom Tromey  <tom@tromey.com>
6851
6852         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6853         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6854         clear_detail method directly.
6855         (tui_clear_win_detail): Remove.
6856
6857 2019-06-25  Tom Tromey  <tom@tromey.com>
6858
6859         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6860         "this", not TUI_DISASM_WIN.
6861
6862 2019-06-25  Tom Tromey  <tom@tromey.com>
6863
6864         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6865         declare.
6866         * tui/tui-winsource.c
6867         (tui_source_window_base::do_scroll_horizontal): Rename from
6868         tui_horizontal_source_scroll.
6869         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6870         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6871         from tui_vertical_data_scroll.
6872         * tui/tui-win.h (tui_scroll): Don't declare.
6873         * tui/tui-win.c (tui_win_info::forward_scroll)
6874         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6875         (tui_win_info::right_scroll): Rename and update.
6876         (tui_scroll_forward_command, tui_scroll_backward_command)
6877         (tui_scroll_left_command, tui_scroll_right_command): Update.
6878         (tui_scroll): Remove.
6879         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6880         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6881         from tui_vertical_source_scroll.
6882         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6883         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6884         from tui_vertical_disassem_scroll.
6885         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6886         do_scroll_horizontal>: New methods.
6887         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6888         Likewise.
6889         (struct tui_source_window_base): Add do_scroll_horizontal.
6890         (struct tui_source_window, struct tui_disasm_window): Add
6891         do_scroll_vertical.
6892         (struct tui_data_window, struct tui_cmd_window): Add
6893         do_scroll_horizontal and do_scroll_vertical.
6894         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6895
6896 2019-06-25  Tom Tromey  <tom@tromey.com>
6897
6898         * tui/tui-data.h (struct tui_source_window_base): New struct.
6899         (struct tui_source_window): Derive from tui_source_window_base.
6900         (struct tui_disasm_window): New struct.
6901         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6902         from tui_source_window::clear_detail.
6903         (tui_source_window_base): Rename from tui_source_window.
6904         (~tui_source_window_base): Rename from ~tui_source_window.
6905         (tui_alloc_win_info): Create a tui_disasm_window.
6906
6907 2019-06-25  Tom Tromey  <tom@tromey.com>
6908
6909         * tui/tui-data.h (struct tui_source_window)
6910         (struct tui_data_window): Declare destructors.
6911         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6912         destructors.
6913         (tui_win_info): Simplify.
6914
6915 2019-06-25  Tom Tromey  <tom@tromey.com>
6916
6917         * tui/tui-winsource.c (tui_display_main)
6918         (tui_update_source_windows_with_addr)
6919         (tui_update_all_breakpoint_info): Update.
6920         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6921         (new_height_ok, parse_scrolling_args): Update.
6922         * tui/tui-stack.c (tui_show_frame_info): Update.
6923         * tui/tui-data.h (struct tui_list): Remove.
6924         (tui_source_windows): Return a reference to a std::vector.
6925         * tui/tui-data.c (source_windows): Now a std::vector.
6926         (tui_source_windows): Change return type.
6927         (tui_clear_source_windows): Rewrite.
6928         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6929         (tui_free_all_source_wins_content): Rewrite.
6930
6931 2019-06-25  Tom Tromey  <tom@tromey.com>
6932
6933         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6934         (struct tui_data_window, struct tui_cmd_window): Declare
6935         clear_detail method.
6936         * tui/tui-data.c (tui_source_window::clear_detail)
6937         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6938         methods.
6939         (tui_clear_win_detail): Simplify.
6940
6941 2019-06-25  Tom Tromey  <tom@tromey.com>
6942
6943         * tui/tui-layout.c (make_source_window, make_disasm_window)
6944         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6945         Return the new window.
6946         (show_source_disasm_command, show_data)
6947         (show_source_or_disasm_and_command): Update.
6948
6949 2019-06-25  Tom Tromey  <tom@tromey.com>
6950
6951         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6952         parameter.  Return the new window.
6953         (show_source_disasm_command): Update and remove NULL check.
6954         (show_source_or_disasm_and_command): Update.
6955
6956 2019-06-25  Tom Tromey  <tom@tromey.com>
6957
6958         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6959
6960 2019-06-25  Tom Tromey  <tom@tromey.com>
6961
6962         * tui/tui-data.h (struct tui_win_info): Make constructor
6963         protected.  Make destructor virtual.  Add initializers.
6964         (tui_source_window, tui_data_window, tui_cmd_window): New
6965         classes.
6966         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6967         constructor.  Add "type" parameter.
6968         (tui_source_window, tui_data_window, tui_cmd_window): New
6969         constructors.
6970         (tui_alloc_win_info): Instantiate the appropriate subclass.
6971
6972 2019-06-25  Tom Tromey  <tom@tromey.com>
6973
6974         * tui/tui-win.c (tui_resize_all): Use delete.
6975         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6976         destructor.
6977         (tui_free_window): Don't declare.
6978         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6979         Update.
6980
6981 2019-06-25  Tom Tromey  <tom@tromey.com>
6982
6983         * tui/tui-data.h (struct tui_win_info): Add constructor.
6984         * tui/tui-data.c (tui_alloc_win_info): Use new.
6985         (tui_free_window): Use delete.
6986
6987 2019-06-22  Tom Tromey  <tom@tromey.com>
6988
6989         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6990         declare.
6991         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6992
6993 2019-06-22  Tom Tromey  <tom@tromey.com>
6994
6995         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6996         declare.
6997         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6998
6999 2019-06-22  Tom de Vries  <tdevries@suse.de>
7000
7001         * dwarf2read.c (create_addrmap_from_aranges)
7002         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7003         instead of '%zu'.
7004
7005 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7006
7007         * dwarf2read.h (dwarf2_section_info_def): Remove.
7008         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7009         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7010         std::vector<dwarf2_section_info>.
7011         (struct dwo_file) <~dwo_file>: Remove.
7012         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7013         types field.
7014         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7015         (dwarf2_read_debug_names): Likewise.
7016         (create_debug_types_hash_table): Change parameter type to
7017         array_view, adjust code accordingly.
7018         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7019         (partial_die_info::fixup): Likewise.
7020         (determine_prefix): Likewise.
7021         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7022
7023 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7024
7025         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7026         gdb_bfd_ref_ptr.
7027         <~dwo_file>: Remove call to gdb_bfd_unref.
7028         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7029         gdb_bfd_ref_ptr::get.
7030
7031 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7032
7033         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7034         type to htab_up.
7035         * dwarf2read.c (struct dwo_file): Initialize fields.
7036         <~dwo_file>: New.
7037         (free_dwo_file): Remove, move content to ~dwo_file.
7038         (struct dwo_file_deleter): Remove.
7039         (dwo_file_up>: Remove custom deleter.
7040         (free_dwo_files): Remove.
7041         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7042         dwo_files.
7043         (process_skeletonless_type_units): Call unique_ptr::get.
7044         (allocate_dwo_file_hash_table): Add deleter to created hash
7045         table.  Change return type to htab_up.
7046         (lookup_dwo_file_slot): Don't memset dwo_file, call
7047         unique_ptr::get.
7048         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7049         (create_dwo_unit_in_dwp_v2): Likewise.
7050         (open_and_init_dwo_file): Likewise.
7051         (free_dwo_file_from_slot): Remove.
7052
7053 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7054
7055         * dwarf2read.h (struct dwarf2_section_info) <readin,
7056         is_virtual>: Change type to bool.
7057         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7058         true instead of 1.
7059
7060 2019-06-19  Tom Tromey  <tom@tromey.com>
7061
7062         * tui/tui-data.h (tui_init_content_element): Don't declare.
7063
7064 2019-06-19  Tom Tromey  <tom@tromey.com>
7065
7066         * tui/tui-data.h (tui_init_win_info): Don't declare.
7067
7068 2019-06-19  Tom de Vries  <tdevries@suse.de>
7069
7070         * dwarf2read.h (abstract_to_concrete): Change type to
7071         std::unordered_map<sect_offset, std::vector<sect_offset>,
7072         gdb::hash_enum<sect_offset>>.
7073
7074 2019-06-19  Tom Tromey  <tromey@adacore.com>
7075
7076         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7077         EVAL_AVOID_SIDE_EFFECTS specially.
7078
7079 2019-06-19  Tom Tromey  <tromey@adacore.com>
7080
7081         * source-cache.c (highlighter): New global.
7082         (source_cache::get_source_lines): Create a highlighter on demand.
7083
7084 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7085
7086         * defs.h (deprecated_interactive_hook): Delete declaration.
7087         * interps.c (clear_interpreter_hooks): Remove use of
7088         deprecated_interactive_hook.
7089         * top.c (deprecated_interactive_hook): Delete definition.
7090         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7091
7092 2019-06-18  Tom de Vries  <tdevries@suse.de>
7093
7094         PR gdb/24515
7095         * dwarf2read.h (abstract_to_concrete): Change type from
7096         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7097         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7098         * dwarf2read.c (read_variable): Update.
7099         (dwarf2_fetch_die_loc_sect_off): Update.
7100
7101 2019-06-17  Tom de Vries  <tdevries@suse.de>
7102
7103         PR gdb/24617
7104         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7105         accessing parent[parent_len - 1].
7106
7107 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7108
7109         PR gdb/24364
7110         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7111         call dtrace_process_dof with NULL dof.
7112
7113 2019-06-16  Tom de Vries  <tdevries@suse.de>
7114
7115         PR gdb/24445
7116         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7117
7118 2019-06-16  Tom Tromey  <tom@tromey.com>
7119
7120         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7121         (make_all_visible): Use address of member.
7122
7123 2019-06-16  Tom Tromey  <tom@tromey.com>
7124
7125         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7126         (tui_free_window, free_content, free_content_elements): Remove
7127         unnecessary cast.
7128         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7129         cast.
7130         * tui/tui-regs.c (tui_show_register_group)
7131         (tui_display_registers_from, tui_display_reg_element_at_line):
7132         Remove unnecessary cast.
7133
7134 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7135
7136         * linux-nat.c (normal_mask): Delete.
7137         (_initialize_linux_nat): Don't initialise normal_mask.
7138
7139 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7140
7141         PR gdb/24445
7142         * dwarf-index-write.h (write_psymtabs_to_index): Add
7143         dwz_basename parameter.
7144         * dwarf-index-write.c (write_gdbindex): Move file writing to
7145         write_gdbindex_1.  Change return type void.
7146         (assert_file_size): Move up, remove filename parameter.
7147         (write_gdbindex_1): New function.
7148         (write_debug_names): Change return type to void, call
7149         assert_file_size.
7150         (struct index_wip_file): New struct.
7151         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7152         file logic to index_wip_file.  Write index for dwz file if
7153         needed.
7154         (save_gdb_index_command): Pass basename of dwz file, if present.
7155         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7156         build-id of dwz file, if present.
7157         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7158         (dwarf2_get_dwz_file): Likewise.
7159         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7160         (dwarf2_get_dwz_file): Likewise.
7161
7162 2019-06-16  Tom Tromey  <tom@tromey.com>
7163
7164         * coffread.c (process_coff_symbol): Use xstrdup.
7165         * value.c (create_internalvar): Use xstrdup.
7166
7167 2019-06-16  Tom Tromey  <tom@tromey.com>
7168
7169         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7170         * breakpoint.c (stopin_command, stopat_command)
7171         (until_break_command, decode_location_default): Remove unnecessary
7172         cast.
7173         * utils.c (subset_compare): Remove unnecessary cast.
7174         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7175         cast.
7176         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7177         cast.
7178         * infcmd.c (path_command): Remove unnecessary cast.
7179         * coffread.c (decode_type): Remove unnecessary cast.
7180         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7181         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7182         * tui/tui-stack.c (tui_show_locator_content)
7183         (tui_show_frame_info): Remove unnecessary cast.
7184         * tui/tui-win.c (tui_scroll_forward_command)
7185         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7186         (parse_scrolling_args): Remove unnecessary cast.
7187         * tui/tui-data.c (init_win_info, tui_del_window)
7188         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7189         (free_content_elements): Remove unnecessary cast.
7190         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7191         unnecessary cast.
7192         * tui/tui-source.c (tui_set_source_content)
7193         (tui_vertical_source_scroll): Remove unnecessary cast.
7194         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7195         cast.
7196         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7197         * tui/tui-regs.c (tui_display_registers_from)
7198         (tui_display_register): Remove unnecessary cast.
7199         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7200         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7201         (make_visible): Remove unnecessary cast.
7202         * tui/tui-winsource.c (tui_erase_source_content)
7203         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7204         unnecessary cast.
7205         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7206         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7207         * stabsread.c (read_type, read_array_type, read_range_type):
7208         Remove unnecessary cast.
7209         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7210         (parse_symbol, parse_type, upgrade_type, parse_external)
7211         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7212         unnecessary cast.
7213         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7214
7215 2019-06-16  Tom Tromey  <tom@tromey.com>
7216
7217         * tui/tui-data.c (tui_alloc_generic_win_info)
7218         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7219         checks.
7220
7221 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7222             Andrew Burgess  <andrew.burgess@embecosm.com>
7223
7224         * f-typeprint.c (f_print_type): Don't return early for not
7225         associated or not allocated types.
7226         (f_type_print_varspec_suffix): Add print_rank parameter and print
7227         ranks of array types in case they dangling.
7228         (f_type_print_base): Add print_rank parameter.
7229
7230 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7231
7232         * NEWS: Mention new MI commands.
7233         * break-catch-throw.c (enum exception_event_kind): Move to
7234         breakpoint.h.
7235         (print_mention_exception_catchpoint): Output text as a single
7236         message.
7237         (catch_exception_command_1): Rename to...
7238         (catch_exception_event): ...this, make non-static, update header
7239         command, and change some parameter types.
7240         (catch_catch_command): Update for changes to
7241         catch_exception_command_1.
7242         (catch_throw_command): Likewise.
7243         (catch_rethrow_command): Likewise.
7244         * breakpoint.c (enum exception_event_kind): Delete.
7245         * breakpoint.h (enum exception_event_kind): Moved here from
7246         break-catch-throw.c.
7247         (catch_exception_event): Declare.
7248         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7249         (mi_cmd_catch_throw): New function.
7250         (mi_cmd_catch_rethrow): New function.
7251         (mi_cmd_catch_catch): New function.
7252         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7253         'catch-catch' entries.
7254         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7255         (mi_cmd_catch_rethrow): Declare.
7256         (mi_cmd_catch_catch): Declare.
7257
7258 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7259
7260         * annotate.c (annotate_source_line): Change return type to void,
7261         update implementation to match.
7262         * annotate.h (annotate_source_line): Change return type to void,
7263         update header comment.
7264         * stack.c (print_frame_info): Don't change what frame information
7265         is printed based on whether annotations are on or not.
7266
7267 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7268
7269         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7270         (annotate_source): Make static.
7271         (annotate_source_line): Moved from source.c and renamed from
7272         identify_source_line.  Update the return type.
7273         * annotate.h (annotate_source): Delete declaration.
7274         (annotate_source_line): Declaration moved from source.h, and
7275         renamed from identify_source_line.  Return type updated.
7276         * source.c (identify_source_line): Moved to annotate.c and renamed
7277         to annotate_source_line.
7278         (info_line_command): Remove check of annotation_level.
7279         * source.h (identify_source_line): Move declaration to annotate.h
7280         and rename to annotate_source_line.
7281         * stack.c: Add 'annotate.h' include.
7282         (print_frame_info): Remove check of annotation_level before
7283         calling annotate_source_line.
7284
7285 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7286
7287         * source-cache.c (source_cache::get_plain_source_lines): Use
7288         open_source_file_with_line_charpos instead of just
7289         open_source_file, remove call to find_source_lines.
7290         (source_cache::get_source_lines): Likewise.
7291         * source.c (find_source_lines): Make static.
7292         (get_filename_and_charpos): Renamed into...
7293         (open_source_file_with_line_charpos): ..this along with changes to
7294         return a scoped_fd, and some other minor clean ups.
7295         (identify_source_line): Use open_source_file_with_line_charpos.
7296         (search_command_helper): Use open_source_file_with_line_charpos
7297         instead of just open_source_file, remove call to
7298         find_source_lines.
7299         * source.h (open_source_file_with_line_charpos): Declare new
7300         function.
7301         (find_source_lines): Delete declaration.
7302
7303 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7304
7305         * source.c (get_filename_and_charpos): Remove fullname
7306         parameter.
7307         (identify_source_line): Update call to get_filename_and_charpos.
7308
7309 2019-06-14  Tom Tromey  <tromey@adacore.com>
7310
7311         PR gdb/24502:
7312         * ui-style.h (skip_ansi_escape): Update comment.
7313         * ui-file.h (class no_terminal_escape_file): New class.
7314         * ui-file.c (no_terminal_escape_file::write)
7315         (no_terminal_escape_file::puts): New methods.
7316         * cli/cli-logging.c (handle_redirections): Use
7317         no_terminal_escape_file.
7318
7319 2019-06-14  Tom Tromey  <tromey@adacore.com>
7320
7321         * NEWS: Move convenience variable news above Python news.
7322
7323 2019-06-14  Tom Tromey  <tom@tromey.com>
7324
7325         * gnulib: Move directory to top-level.
7326         * configure.ac: Don't configure gnulib.
7327         * configure: Rebuild.
7328         * common/common-defs.h: Use new path to gnulib.
7329         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7330         (GNULIB_H): Remove.
7331         (INCGNU): Look in new gnulib location.
7332         (HFILES_NO_SRCDIR): Remove gnulib files.
7333         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7334         (generated_files): Remove GNULIB_H.
7335         ($(LIBGNU), all-lib): Remove targets.
7336         (distclean): Don't mention GNULIB_BUILDDIR.
7337         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7338
7339 2019-06-14  Tom Tromey  <tromey@adacore.com>
7340
7341         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7342         Warn if symbol file does not provide any symbols.
7343
7344 2019-06-14  Tom Tromey  <tromey@adacore.com>
7345
7346         * source.c (find_and_open_source): Respect basenames_may_differ.
7347
7348 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7349
7350         * annotate.c (annotate_breakpoints_invalid): Make use of
7351         scoped_restore_terminal_state.
7352         (annotate_frames_invalid): Likewise.
7353
7354 2019-06-14  Tom Tromey  <tromey@adacore.com>
7355
7356         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7357         allow assignment to an internalvar.
7358
7359 2019-06-14  Tom Tromey  <tromey@adacore.com>
7360
7361         * ada-lex.l: Allow "_" in attribute names.
7362
7363 2019-06-14  Tom Tromey  <tromey@adacore.com>
7364
7365         PR gdb/24653:
7366         * regcache.c (registers_changed): Don't call alloca.
7367         * top.c (execute_command): Don't call alloca.
7368
7369 2019-06-13  Pedro Alves  <palves@redhat.com>
7370
7371         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7372         'expression'.  When parsing an expression, error out if there's
7373         junk after "unlimited".
7374         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7375         (do_set_command): Adjust calls to is_unlimited_literal.
7376
7377 2019-06-13  Pedro Alves  <palves@redhat.com>
7378
7379         * compile/compile.c (make_compile_options_def_group): Add braces
7380         around array_view initializer.
7381         * thread.c (make_thread_apply_all_options_def_group)
7382         (make_thread_apply_all_options_def_group): Likewise.
7383
7384 2019-06-13  Pedro Alves  <palves@redhat.com>
7385
7386         * NEWS (New commands): Mention "maint test-options
7387         require-delimiter", "maint test-options unknown-is-error", "maint
7388         test-options unknown-is-operand" and "maint show
7389         test-options-completion-result".
7390         (New command options, command completion): New section.
7391         (Completion improvements): New section.
7392         Mention that you can abbreviate "unlimited".
7393
7394 2019-06-13  Pedro Alves  <palves@redhat.com>
7395
7396         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7397         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7398         * unittests/cli-utils-selftests.c (test_parse_flags)
7399         (test_parse_flags_qcs): Delete.
7400         (test_cli_utils): Don't call deleted functions.
7401
7402 2019-06-13  Pedro Alves  <palves@redhat.com>
7403
7404         * thread.c: Include "cli/cli-option.h".
7405         (tp_array_compar_ascending): Global.
7406         (tp_array_compar): Delete function.
7407         (tp_array_compar_ascending, tp_array_compar_descending): New
7408         functions.
7409         (ascending_option_def, qcs_flag_option_def)
7410         (thr_qcs_flags_option_defs)
7411         (make_thread_apply_all_options_def_group)
7412         (make_thread_apply_options_def_group): New.
7413         (thread_apply_all_command): Use gdb::option::process_options.
7414         (thread_apply_command_completer)
7415         (thread_apply_all_command_completer): New.
7416         (thread_apply_command): Use gdb::option::process_options.
7417         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7418         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7419         to generate help text of "thread apply".  Adjust "taas"'s help.
7420         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7421         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7422
7423 2019-06-13  Pedro Alves  <palves@redhat.com>
7424
7425         * thread.c (thread_apply_command): Check for invalid TID with
7426         isdigit instead of !isalpha.
7427
7428 2019-06-13  Pedro Alves  <palves@redhat.com>
7429
7430         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7431         (validate_flags_qcs): New.
7432         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7433         (validate_flags_qcs): Declare.
7434         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7435         (make_frame_apply_options_def_group): New.
7436         (frame_apply_command_count): Process options with
7437         gdb::option::process_options.
7438         (frame_apply_completer): New.
7439         (frame_apply_level_completer, frame_apply_all_completer)
7440         (frame_apply_completer): New.
7441         (_initialize_stack): Update help of "frame apply", "frame apply
7442         level", "frame apply all" and "faas" to mention supported options
7443         and install command completers.
7444         * stack.h (frame_apply_all_completer): Declare.
7445         * thread.c: Include "stack.h".
7446         (tfaas_command): Add "--".
7447         (_initialize_thread): Update help "tfaas" to mention supported
7448         options and install command completer.
7449
7450 2019-06-13  Pedro Alves  <palves@redhat.com>
7451
7452         * completer.c (complete_nested_command_line): New.
7453         (gdb_completion_word_break_characters_throw): Add assertion.
7454         * completer.h (complete_nested_command_line): Declare.
7455
7456 2019-06-13  Pedro Alves  <palves@redhat.com>
7457
7458         * stack.c (parse_backtrace_qualifiers): New.
7459         (backtrace_command): Use it.
7460         (backtrace_command_completer): Complete on qualifiers.
7461
7462 2019-06-13  Pedro Alves  <palves@redhat.com>
7463
7464         * frame.c: Include "cli/cli-option.h.
7465         (user_set_backtrace_options): New.
7466         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7467         Delete.
7468         (get_prev_frame): Adjust.
7469         (boolean_option_def, uinteger_option_def)
7470         (set_backtrace_option_defs): New.
7471         (_initialize_frame): Adjust and use
7472         gdb::option::add_setshow_cmds_for_options to install "set
7473         backtrace past-main" and "set backtrace past-entry".
7474         * frame.h: Include "cli/cli-option.h".
7475         (struct frame_print_options): Forward declare.
7476         (print_frame_arguments_all, print_frame_arguments_scalars)
7477         (print_frame_arguments_none): Declare.
7478         (print_entry_values): Delete declaration.
7479         (struct frame_print_options, user_frame_print_options): New.
7480         (struct set_backtrace_options): New.
7481         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7482         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7483         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7484         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7485         (list_args_or_locals): Add frame_print_options parameter.
7486         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7487         * python/py-framefilter.c (enumerate_args): Pass down
7488         USER_FRAME_PRINT_OPTIONS.
7489         * stack.c: Include "cli/cli-option.h".
7490         (print_frame_arguments_all, print_frame_arguments_scalars)
7491         (print_frame_arguments_none): Declare.
7492         (print_raw_frame_arguments, print_entry_values): Delete.
7493         (user_frame_print_options): New.
7494         (boolean_option_def, enum_option_def, frame_print_option_defs):
7495         New.
7496         (struct backtrace_cmd_options): New.
7497         (bt_flag_option_def): New.
7498         (backtrace_command_option_defs): New.
7499         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7500         (print_frame_arg, read_frame_arg, print_frame_args)
7501         (print_frame_info, print_frame): Add frame_print_options parameter
7502         and use it.
7503         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7504         (backtrace_command_1): Add frame_print_options and
7505         backtrace_cmd_options parameters and use them.
7506         (make_backtrace_options_def_group): New.
7507         (backtrace_command): Process command options with
7508         gdb::option::process_options.
7509         (backtrace_command_completer): New.
7510         (_initialize_stack): Extend "backtrace"'s help to mention
7511         supported options.  Install completer for "backtrace".
7512         Install some settings commands with add_setshow_cmds_for_options.
7513
7514 2019-06-13  Pedro Alves  <palves@redhat.com>
7515
7516         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7517         and that "set/show print raw frame-arguments" are now deprecated.
7518
7519         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7520         command.
7521         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7522         * stack.c (_initialize_stack): Install "set/show print
7523         raw-frame-arguments", and deprecate "set/show print raw
7524         frame-arguments".
7525         * valprint.c (_initialize_valprint): Deprecate "set/show print
7526         raw".
7527
7528 2019-06-13  Pedro Alves  <palves@redhat.com>
7529
7530         * compile/compile.c (struct compile_options): New.
7531         (compile_flag_option_def, compile_command_option_defs)
7532         (make_compile_options_def_group): New.
7533         (compile_file_command): Handle options with
7534         gdb::option::process_options.
7535         (compile_file_command_completer): New function.
7536         (compile_code_command): Handle options with
7537         gdb::option::process_options.
7538         (compile_code_command_completer): New function.
7539         (_initialize_compiler): Install completers for "compile code" and
7540         "compile file".  Mention available options in "compile code" and
7541         "compile code"'s help.
7542         * completer.c (advance_to_completion_word): New, factored out from
7543         ...
7544         (advance_to_expression_complete_word_point): ... this.
7545         (advance_to_filename_complete_word_point): New.
7546         * completer.h (advance_to_filename_complete_word_point): New
7547         declaration.
7548
7549 2019-06-13  Pedro Alves  <palves@redhat.com>
7550
7551         * compile/compile.c: Include "cli/cli-option.h".
7552         (compile_print_value): Scope data pointer is now a
7553         value_print_options pointer; adjust.
7554         (compile_print_command): Process options.  Scope data pointer is
7555         now a value_print_options pointer; adjust.
7556         (_initialize_compile): Update "compile print"'s help to include
7557         supported options.  Install a completer for "compile print".
7558         * cp-valprint.c (show_vtblprint, show_objectprint)
7559         (show_static_field_print): Delete.
7560         (_initialize_cp_valprint): Don't install "set print
7561         static-members", "set print vtbl", "set print object" here.
7562         * printcmd.c: Include "cli/cli-option.h" and
7563         "common/gdb_optional.h".
7564         (print_command_parse_format): Rework to fill in a
7565         value_print_options instead of a format_data.
7566         (print_value): Change parameter type from format_data pointer to
7567         value_print_options reference.  Adjust.
7568         (print_command_1): Process options.  Adjust to pass down a
7569         value_print_options.
7570         (print_command_completer): New.
7571         (_initialize_printcmd): Install print_command_completer as
7572         handle_brkchars completer for the "print" command.  Update
7573         "print"'s help to include supported options.
7574         * valprint.c: Include "cli/cli-option.h".
7575         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7576         here from cp-valprint.c.
7577         (boolean_option_def, uinteger_option_def)
7578         (value_print_option_defs, make_value_print_options_def_group):
7579         New.  Use gdb::option::add_setshow_cmds_for_options to install
7580         "set print elements", "set print null-stop", "set print repeats",
7581         "set print pretty", "set print union", "set print array", "set
7582         print address", "set print symbol", "set print array-indexes".
7583         * valprint.h: Include <string> and "cli/cli-option.h".
7584         (make_value_print_options_def_group): Declare.
7585         (print_value): Change parameter type from format_data pointer to
7586         value_print_options reference.
7587         (print_command_completer): Declare.
7588
7589 2019-06-13  Pedro Alves  <palves@redhat.com>
7590
7591         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7592         (COMMON_SFILES): Add maint-test-settings.c.
7593         * cli/cli-decode.c (boolean_enums): New global, factored out from
7594         ...
7595         (add_setshow_boolean_cmd): ... here.
7596         * cli/cli-decode.h (boolean_enums): Declare.
7597         * cli/cli-option.c: New file.
7598         * cli/cli-option.h: New file.
7599         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7600         factored out from ...
7601         (parse_cli_boolean_value(const char *)): ... this.
7602         (is_unlimited_literal): Change parameter type to pointer to
7603         pointer.  Adjust and advance ARG pointer.
7604         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7605         (parse_cli_var_enum): New, factored out from ...
7606         (do_set_command): ... this.  Adjust.
7607         * cli/cli-setshow.h (parse_cli_boolean_value)
7608         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7609         (parse_cli_var_enum): Declare.
7610         * cli/cli-utils.c: Include "cli/cli-option.h".
7611         (get_ulongest): New.
7612         * cli/cli-utils.h (get_ulongest): Declare.
7613         (check_for_argument): New overloads.
7614         * maint-test-options.c: New file.
7615
7616 2019-06-13  Pedro Alves  <palves@redhat.com>
7617
7618         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7619         parse a range if "-" is at the end of the string.
7620
7621 2019-06-13  Pedro Alves  <palves@redhat.com>
7622
7623         * cli/cli-setshow.c (parse_auto_binary_operation)
7624         (parse_cli_boolean_value): Don't allow "o".
7625
7626 2019-06-13  Pedro Alves  <palves@redhat.com>
7627
7628         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7629         * NEWS: Mention maint test-settings KIND.
7630         * maint-test-settings.c: New file.
7631
7632 2019-06-13  Pedro Alves  <palves@redhat.com>
7633
7634         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7635         completer.
7636         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7637         "set" completers.
7638
7639 2019-06-13  Pedro Alves  <palves@redhat.com>
7640
7641         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7642         after item.
7643
7644 2019-06-13  Pedro Alves  <palves@redhat.com>
7645
7646         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7647
7648 2019-06-13  Pedro Alves <palves@redhat.com>
7649
7650         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7651         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7652         call.
7653         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7654         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7655         calls.
7656         (check_for_argument): Skip spaces after argument.
7657
7658 2019-06-13  Pedro Alves  <palves@redhat.com>
7659
7660         * thread.c (thread_apply_command): Adjust TID parsing.
7661         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7662         detected before end of string.
7663         (tid_is_in_list): Error out if LIST is invalid.
7664
7665 2019-06-13  Pedro Alves  <palves@redhat.com>
7666
7667         * completer.c (complete_line_internal_1): Rewind completion word
7668         point.
7669         (completion_tracker::advance_custom_word_point_by): Change
7670         parameter type to int.
7671         * completer.h (completion_tracker::advance_custom_word_point_by):
7672         Likewise.
7673
7674 2019-06-13  Pedro Alves  <palves@redhat.com>
7675
7676         * completer.c (advance_to_completion_word): Handle delimiters.
7677
7678 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7679
7680         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7681
7682 2019-06-11  Tom Tromey  <tom@tromey.com>
7683
7684         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7685         (xmalloc_failed): Move to alloc.c.
7686         * alloc.c: New file.
7687         * Makefile.in (COMMON_SFILES): Add alloc.c.
7688
7689 2019-06-11  Tom Tromey  <tom@tromey.com>
7690
7691         * nat/linux-waitpid.c: Don't include server.h.
7692         (linux_debug): Remove.
7693         (my_waitpid): Update.
7694
7695 2019-06-11  Tom Tromey  <tromey@adacore.com>
7696
7697         * infcall.c (_initialize_infcall): Remove trailing newline from
7698         help.
7699         * user-regs.c (_initialize_user_regs): Remove trailing newline
7700         from help.
7701         * typeprint.c (_initialize_typeprint): Remove trailing newline
7702         from help.
7703         * reverse.c (_initialize_reverse): Remove trailing newlines from
7704         help.
7705         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7706         from help.
7707         * language.c (add_set_language_command): Remove trailing newline
7708         from help.
7709         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7710         help.
7711         * disasm.c (_initialize_disasm): Remove trailing newline from
7712         help.
7713         * top.c (init_main): Remove trailing newline from help.
7714         * interps.c (_initialize_interpreter): Remove trailing newline
7715         from help.
7716         * btrace.c (_initialize_btrace): Remove trailing newlines from
7717         help.
7718         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7719         from help.
7720         * python/python.c (_initialize_python): Remove trailing newline
7721         from help.
7722         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7723         help.
7724         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7725         from help.  Reformat some text.
7726         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7727         from help.
7728         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7729         newline from help.
7730
7731 2019-06-11  Tom Tromey  <tromey@adacore.com>
7732
7733         * darwin-nat.c (darwin_decode_exception_message)
7734         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7735
7736 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7737
7738         * valops.c (value_slice): Check for not allocated or not
7739         associated values.
7740
7741 2019-06-10  Tom de Vries  <tdevries@suse.de>
7742
7743         PR gdb/24618
7744         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7745         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7746         invalid.
7747
7748 2019-06-10  Tom de Vries  <tdevries@suse.de>
7749
7750         PR gdb/24611
7751         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7752         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7753
7754 2019-06-10  Tom de Vries  <tdevries@suse.de>
7755
7756         PR symtab/24545
7757         * symtab.c (struct demangled_name_entry): Add language field.
7758         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7759         static minimal symbol".  Set and use language field.
7760
7761 2019-06-10  Tom Tromey  <tromey@adacore.com>
7762
7763         * ada-lang.c (_initialize_ada_language): Update help text.
7764
7765 2019-06-10  Tom Tromey  <tromey@adacore.com>
7766
7767         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7768         with a newline.
7769         * guile/guile.c (handle_boot_error): Don't end warning with a
7770         newline.
7771         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7772         warning with a newline.
7773         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7774         newline.
7775         (s12z_frame_cache): Likewise.
7776         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7777         a newline.
7778         * solib-svr4.c (disable_probes_interface): Don't end warning with
7779         a newline.
7780         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7781         newline.
7782         * python/python.c (do_finish_initialization): Don't end warning
7783         with a newline.
7784
7785 2019-06-10  Tom Tromey  <tom@tromey.com>
7786
7787         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7788         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7789         gdbpy_enter.
7790
7791 2019-06-10  Tom Tromey  <tromey@adacore.com>
7792
7793         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7794         data.
7795         (elf_new_init): Don't call stabsread_new_init.
7796         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7797         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7798         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7799
7800 2019-06-10  Tom de Vries  <tdevries@suse.de>
7801
7802         PR symtab/16264
7803         PR symtab/24517
7804         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7805
7806 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7807
7808         * source.c (find_and_open_source): Also rewrite relative file
7809         names.
7810
7811 2019-04-26  Amos Bird  <amosbird@gmail.com>
7812
7813         * annotate.c (annotate_thread_exited): Add "thread-exited"
7814         annotation.
7815
7816 2019-06-06  Tom Tromey  <tromey@adacore.com>
7817
7818         * maint.h (class scoped_command_stats): Use
7819         DISABLE_COPY_AND_ASSIGN.
7820         <print_time>: New method.
7821         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7822         print_time.
7823         (scoped_command_stats::print_time): New method.
7824
7825 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7826
7827         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7828         instructions of lengths 6 or 8 bytes.
7829
7830 2019-06-04  Pedro Alves  <palves@redhat.com>
7831
7832         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7833
7834         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7835         * breakpoint.c (condition_completer): Likewise.
7836         * cli/cli-dump.c (scan_expression): Likewise.
7837         * common/filestuff.c (mkdir_recursive): Likewise.
7838         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7839         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7840         (gdb_abspath): Likewise.
7841         * compile/compile-cplus-types.c
7842         (compile_cplus_instance::decl_name): Likewise.
7843         * completer.c (complete_explicit_location):
7844         (signal_completer, reg_or_group_completer_1): Likewise.
7845         * cp-support.c (cp_remove_params_if_any): Likewise.
7846         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7847         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7848         * infcmd.c (strip_bg_char): Likewise.
7849         * linespec.c (copy_token_string): Likewise.
7850         * mi/mi-main.c (output_cores): Likewise.
7851         * psymtab.c (psymtab_search_name):
7852         * symfile.c (test_set_ext_lang_command): Likewise.
7853         * target.c (target_fileio_read_stralloc): Likewise.
7854         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7855         * value.c (complete_internalvar): Likewise.
7856
7857 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7858
7859         Add objfile property to gdb.Type.
7860         * NEWS: Mention Python API addition.
7861         * python/py-type.c (typy_get_objfile): New method.
7862
7863 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7864
7865         * NEWS: Mention the new set|show style [title|highlight].
7866         Mention changes to "show style", "help" and "apropos".
7867
7868 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7869
7870         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7871         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7872         instead of print_help_for_command.
7873         (print_doc_of_command): New function.
7874         (help_list): Add 'apropos -v word' suggestion.
7875         (print_help_for_command): Style the command name using title style.
7876         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7877         (_initialize_cli_cmds): Describe -v in apropos_command help.
7878
7879 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7880
7881         * cli/cli-style.h (cli_style_option): Add name in constructor,
7882         add m_name class member, add constructor with intensity,
7883         add name class function.
7884         (cli_style_option::add_setshow_commands): Remove name argument.
7885         (highlight_style, title_style): New styles.
7886         * cli/cli-style.c (do_show): New function that shows a style
7887         characteristic styling the style name with itself.
7888         (set_style_name): New function.
7889         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7890         Update all callers according to the changes in cli/cli-style.h.
7891         * utils.h (fputs_highlighted): New function.
7892         * utils.c (fputs_highlighted): Likewise.
7893
7894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7895
7896         * NEWS: Mention new pipe command and new convenience variables.
7897
7898 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7899
7900         * cli/cli-cmds.c (pipe_command): New function.
7901         (_initialize_cli_cmds): Call add_com for pipe_command.
7902         Define | as an alias for pipe.
7903         (exit_status_set_internal_vars): New function.
7904         (shell_escape): Call exit_status_set_internal_vars.
7905         cli/cli-decode.c (find_command_name_length): Recognize | as
7906         a single character command.
7907
7908 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7909
7910         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7911         top.c (execute_command_to_ui_file): New function, mostly a copy
7912         of execute_command_to_string.
7913         (execute_command_to_string): Implement by calling
7914         execute_command_to_ui_file.
7915
7916 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7917
7918         * top.h (saved_command_line): Remove declaration.
7919         * top.c (previous_saved_command_line, previous_repeat_arguments):
7920         New variables.
7921         (saved_command_line): Make static, define together with other
7922         'repeat variables'.
7923         (dont_repeat): Clear repeat_arguments.
7924         (repeat_previous, get_saved_command_line, save_command_line):
7925         New functions.
7926         (gdb_init): Initialize saved_command_line
7927         and previous_saved_command_line.
7928         * main.c (captured_main_1): Remove saved_command_line initialization.
7929         * event-top.c (handle_line_of_input): Update to use
7930         the new 'repeat' related functions instead of direct access to
7931         saved_command_line.
7932         * command.h (repeat_previous, get_saved_command_line,
7933         save_command_line): New declarations.
7934         (dont_repeat): Add comment.
7935
7936 2019-05-30  Tom Tromey  <tromey@adacore.com>
7937
7938         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7939         Fix comment.
7940         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7941
7942 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7943
7944         PR cli/24587
7945         * completer.c (complete): Initialize variable word.
7946
7947 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7948
7949         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7950         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7951         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7952         'body' is NULL to the outter 'if', protecting the '!is_define'
7953         situation as well.
7954
7955 2019-05-29  Tom Tromey  <tromey@adacore.com>
7956
7957         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7958         (dwarf_unknown): New function.
7959         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7960         (dwarf_type_encoding_name): Use dwarf_unknown.
7961
7962 2019-05-29  Tom Tromey  <tromey@adacore.com>
7963
7964         PR c++/20020:
7965         * cp-valprint.c (cp_print_value_fields): Call
7966         cp_print_static_field inside "try".
7967
7968 2019-05-29  Tom Tromey  <tromey@adacore.com>
7969
7970         * inflow.c (struct terminal_info): Add default operator=.
7971         * configure: Rebuild.
7972         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7973         -Wdeprecated-copy-dtor, -Wredundant-move.
7974
7975 2019-05-29  Tom Tromey  <tromey@adacore.com>
7976
7977         * NEWS: Add entry.
7978         * infcmd.c (print_return_value_1): Handle finish_print
7979         option.
7980         (show_print_finish): New function.
7981         (_initialize_infcmd): Add "set/show print finish" commands.
7982         * valprint.c (user_print_options): Initialize new member.
7983         * valprint.h (struct value_print_options) <finish_print>: New
7984         member.
7985
7986 2019-05-28  Tom Tromey  <tromey@adacore.com>
7987
7988         * ada-lang.c (ada_remove_Xbn_suffix)
7989         (find_old_style_renaming_symbol)
7990         (parse_old_style_renaming): Remove.
7991         (ada_find_renaming_symbol): Don't call
7992         find_old_style_renaming_symbol.
7993         (ada_is_renaming_symbol): Rename from
7994         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7995         bool.  Now static.
7996         (ada_read_var_value): Update and simplify.
7997         * ada-exp.y (write_var_or_type): Remove old code.
7998
7999 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8000
8001         PR gdb/25010
8002         * event-top.c: Remove include comment.
8003         * inflow.c (class scoped_ignore_sigttou): Move from here...
8004         * inflow.h (class scoped_ignore_sigttou): ...to here.
8005         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8006         * top.c:  Remove include comment.
8007
8008 2019-05-27  Tom Tromey  <tom@tromey.com>
8009
8010         * NEWS: Fix typo.
8011
8012 2019-05-22  Tom Tromey  <tromey@adacore.com>
8013
8014         * target.c (target_follow_exec): Constify parameter.
8015         * target-delegates.c: Rebuild.
8016         * remote.c (remote_target::follow_exec): Constify parameter.
8017         * infrun.c (follow_exec): Constify parameter.
8018         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8019         (target_follow_exec): Likewise.
8020
8021 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8022
8023         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8024         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8025
8026 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8027
8028         * NEWS: Add debugredirect and testsuite sections.
8029
8030 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8031
8032         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8033         target descriptions using exclusively floating point register name
8034         aliases.
8035
8036 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8037
8038         PR gdb/18644:
8039         * f-lang.c (build_fortran_types): Handle the case where
8040         gdbarch_floatformat_for_type returns a nullptr.
8041
8042 2019-05-21  Tom de Vries  <tdevries@suse.de>
8043
8044         PR cli/24587
8045         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8046
8047 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8048
8049         PR gdb/18644:
8050         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8051         16-byte floats.
8052         * i386-tdep.c (i386_floatformat_for_type): Use
8053         floatformats_ia64_quad for the 16-byte floating point component
8054         within a fortran 32-byte complex number.
8055
8056 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8057
8058         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8059         delete default constructor.
8060         (find_partial_die): Update to return const struct.
8061         (partial_die_parent_scope): Move variable declaration into scope
8062         of its use and change its type to auto.
8063         (guess_partial_die_structure_name): Likewise.
8064         (partial_die_info::fixup): Likewise.
8065
8066 2019-05-17  Tom Tromey  <tromey@adacore.com>
8067
8068         * source.c (find_and_open_source): Remove cast.
8069
8070 2019-05-17  Tom Tromey  <tromey@adacore.com>
8071
8072         * annotate.c (annotate_source): Make "filename" const.
8073         * annotate.h (annotate_source): Use const.
8074
8075 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8076
8077         * disasm.c (set_disassembler_options): Send errors to stderr.
8078
8079 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8080
8081         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8082         (cli_interp_base::set_logging): Check debug_redirect.
8083         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8084         * cli/cli-logging.c (debug_redirect): Add static variable.
8085         (pop_output_files): Add default param.
8086         (handle_redirections): Print debug setting.
8087         (show_logging_command): Likewise.
8088         (_initialize_cli_logging): Add debugredirect command.
8089         * interps.c (current_interp_set_logging): Add debug_redirect
8090         parameter.
8091         * interps.h (set_logging): Add debug_redirect parameter.
8092         (current_interp_set_logging): Likewise.
8093         * mi/mi-common.h: Likewise.
8094         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8095
8096 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8097             Tom Tromey  <tromey@adacore.com>
8098
8099         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8100         directly.
8101         * cli/cli-interp.h (make_logging_output): Remove declaration.
8102         * cli/cli-logging.c (make_logging_output): Remove function.
8103         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8104         directly.
8105         * ui-file.c (tee_file::tee_file): Remove bools.
8106         (tee_file::~tee_file): Remove deletes.
8107         * ui-file.h (tee_file): Remove bools.
8108
8109 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8110
8111         * mi/mi-cmds.h (mi_cmd_complete): New function.
8112         * mi/mi-main.c (mi_cmd_complete): Likewise.
8113         * mi/mi-cmds.c: Define new MI command -complete.
8114         * NEWS: Mention new -complete command.
8115
8116 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8117
8118         * completer.h (complete): New function.
8119         * completer.c (complete): Likewise.
8120         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8121         function defined in completer.h.
8122
8123 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8124
8125         * MAINTAINERS (Write After Approval): Add myself.
8126
8127 2019-05-17  Tom de Vries  <tdevries@suse.de>
8128
8129         PR gdb/24094
8130         * dwarf2read.c (struct cu_partial_die_info): New struct.
8131         (find_partial_die): Return cu_partial_die_info.
8132         (partial_die_parent_scope, guess_partial_die_structure_name)
8133         (partial_die_info::fixup): Handle new return type of find_partial_die.
8134
8135 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8136
8137         PR breakpoints/24541
8138         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8139         "std::string", simplifying the algorithm.
8140
8141 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8142
8143         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8144         (stap_static_probe_ops::get_probes): Likewise.
8145
8146 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8147
8148         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8149         '-')" and "else if".
8150         (stap_parse_single_operand): Join checks for
8151         "gdbarch_stap_parse_special_token_p" and
8152         "gdbarch_stap_parse_special_token" in the same "if" statement.
8153         Invert check when verifying for operation on register
8154         displacement.
8155
8156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8157
8158         * stap-probe.c (stap_get_opcode): Update comment.
8159         (stap_get_expected_argument_type): Likewise.
8160         (handle_stap_probe): Likewise.
8161
8162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8163
8164         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8165         return type to 'bool'.  Adjust comment.  Use 'bool' when
8166         appropriate.
8167         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8168         * stap-probe.c (stap_parse_argument_1): Likewise.
8169         (stap_is_operator): Likewise.
8170         (stap_is_generic_prefix): Likewise.
8171         (stap_is_register_prefix): Likewise.
8172         (stap_is_register_indirection_prefix): Likewise.
8173         (stap_is_integer_prefix): Likewise.
8174         (stap_generic_check_suffix): Likewise.
8175         (stap_check_integer_suffix): Likewise.
8176         (stap_check_register_suffix): Likewise.
8177         (stap_check_register_indirection_suffix): Likewise.
8178         (stap_parse_register_operand): Likewise.
8179         (stap_parse_single_operand): Likewise.
8180         (stap_parse_argument_1): Likewise.
8181         (stap_probe::get_argument_count): Likewise.
8182         (stap_is_operator): Likewise.
8183
8184 2019-05-16  Tom Tromey  <tromey@adacore.com>
8185
8186         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8187         keyword to foreach.
8188
8189 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8190
8191         * linux-thread-db.c (try_thread_db_load_1): Change return type
8192         to bool.
8193         (try_thread_db_load): Likewise.
8194         (try_thread_db_load_from_pdir_1): Likewise.
8195         (try_thread_db_load_from_pdir): Likewise.
8196         (try_thread_db_load_from_sdir): Likewise.
8197         (try_thread_db_load_from_dir): Likewise.
8198         (thread_db_load_search): Likewise.
8199         (has_libpthread): Likewise.
8200         (thread_db_load): Likewise.
8201
8202 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8203
8204         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8205         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8206         NULL, and complain/return if that's the case.
8207
8208 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8209
8210         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8211         (advance, posn, abstract_read_memory): New functions.
8212         [struct mem_read_abstraction]: New struct.
8213         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8214
8215 2019-05-14  Tom Tromey  <tromey@adacore.com>
8216
8217         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8218         value is not lval_memory.
8219
8220 2019-05-14  Tom Tromey  <tromey@adacore.com>
8221
8222         * solib.c (info_sharedlibrary_command): Style the file name.
8223
8224 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8225
8226         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8227         (aarch64_vnv_type): Likewise.
8228         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8229         * common/tdesc.c: Likewise.
8230         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8231         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8232         * features/aarch64-fpu.xml: Add ieee half view.
8233         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8234         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8235         * gdbtypes.h (struct builtin_type): Likewise.
8236         (struct objfile_type): Likewise.
8237
8238 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8239
8240         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8241         typo.
8242         * location.h (string_to_event_location): Likewise.
8243
8244 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8245
8246         GDB 8.3 released.
8247
8248 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8249
8250         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8251         New variable declaration.
8252         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8253         New variable.
8254         (print_one_breakpoint): Use ui_out::test_flags and new global
8255         variable to compute use_fixed_output.
8256         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8257         Remove.
8258         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8259         (mi_multi_location_breakpoint_output_fixed): Remove.
8260         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8261         new variable.
8262         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8263         fix_multi_location_breakpoint_output flag if version >= 3.
8264         * ui-out.h (enum ui_out_flag)
8265         <fix_multi_location_breakpoint_output>: New enumerator.
8266
8267 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8268
8269         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8270
8271 2019-05-10  Tom Tromey  <tromey@adacore.com>
8272
8273         * ada-lang.c (catch_ada_completer): New function.
8274         (_initialize_ada_language): Use it.
8275
8276 2019-05-10  Tom Tromey  <tromey@adacore.com>
8277
8278         * thread.c (print_thread_info): Make "requested_threads" const.
8279         * gdbthread.h (print_thread_info): Make "requested_threads"
8280         const.
8281         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8282         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8283
8284 2019-05-08  Tom Tromey  <tom@tromey.com>
8285
8286         * gdbtypes.c (objfile_type_data): Change type.
8287         (objfile_type, _initialize_gdbtypes): Update.
8288
8289 2019-05-08  Tom Tromey  <tom@tromey.com>
8290
8291         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8292         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8293         (_initialize_dwarf2_frame): Update.
8294
8295 2019-05-08  Tom Tromey  <tom@tromey.com>
8296
8297         * objc-lang.c (objc_objfile_data): Change type.
8298         (find_methods): Update.
8299         (_initialize_objc_lang): Remove.
8300
8301 2019-05-08  Tom Tromey  <tom@tromey.com>
8302
8303         * stabsread.c (rs6000_builtin_type_data): Change type.
8304         (rs6000_builtin_type, _initialize_stabsread): Update.
8305
8306 2019-05-08  Tom Tromey  <tom@tromey.com>
8307
8308         * mips-tdep.c (mips_pdr_data): Remove.
8309         (_initialize_mips_tdep): Update.
8310
8311 2019-05-08  Tom Tromey  <tom@tromey.com>
8312
8313         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8314         (hppa_init_objfile_priv_data, read_unwind_info)
8315         (find_unwind_entry, _initialize_hppa_tdep): Update.
8316
8317 2019-05-08  Tom Tromey  <tom@tromey.com>
8318
8319         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8320         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8321         on obstack.
8322         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8323
8324 2019-05-08  Tom Tromey  <tom@tromey.com>
8325
8326         * mdebugread.c (basic_type_data): Change type.
8327         (basic_type, _initialize_mdebugread): Update.
8328
8329 2019-05-08  Tom Tromey  <tom@tromey.com>
8330
8331         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8332
8333 2019-05-08  Tom Tromey  <tom@tromey.com>
8334
8335         * nto-tdep.c (nto_inferior_data_reg): Change type.
8336         (nto_inferior_data): Update.
8337         (nto_inferior_data_cleanup, nto_new_inferior_data)
8338         (_initialize_nto_tdep): Remove.
8339         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8340
8341 2019-05-08  Tom Tromey  <tom@tromey.com>
8342
8343         * ada-lang.c (struct ada_inferior_data): Add initializers.
8344         (ada_inferior_data): Change type.
8345         (ada_inferior_data_cleanup): Remove.
8346         (get_ada_inferior_data, ada_inferior_exit)
8347         (struct ada_pspace_data): Add initializers, destructor.
8348         (ada_pspace_data_handle): Change type.
8349         (get_ada_pspace_data): Update.
8350         (ada_pspace_data_cleanup): Remove.
8351
8352 2019-05-08  Tom Tromey  <tom@tromey.com>
8353
8354         * coffread.c (struct coff_symfile_info): Add initializers.
8355         (coff_objfile_data_key): Move lower.  Change type.
8356         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8357         Update.
8358         (coff_free_info): Remove.
8359
8360 2019-05-08  Tom Tromey  <tom@tromey.com>
8361
8362         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8363         (fbsd_pspace_data_handle): Move lower.  Change type.
8364         (get_fbsd_pspace_data): Update.
8365         (fbsd_pspace_data_cleanup): Remove.
8366         (_initialize_fbsd_tdep): Update.
8367
8368 2019-05-08  Tom Tromey  <tom@tromey.com>
8369
8370         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8371         (get_ada_tasks_pspace_data): Update.
8372         (ada_tasks_pspace_data_cleanup): Remove.
8373         (_initialize_tasks): Update.
8374         (ada_tasks_inferior_data_handle): Change type.
8375         (get_ada_tasks_inferior_data): Update.
8376         (ada_tasks_inferior_data_cleanup): Remove.
8377         (struct ada_tasks_pspace_data): Add initializers.
8378
8379 2019-05-08  Tom Tromey  <tom@tromey.com>
8380
8381         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8382         * symfile-debug.c (debug_sym_get_probes): Change type.
8383         * stap-probe.c (handle_stap_probe):
8384         (stap_static_probe_ops::get_probes): Change type.
8385         * probe.h (class static_probe_ops) <get_probes>: Change type.
8386         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8387         (parse_probes_in_pspace): Update.
8388         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8389         Update.
8390         (any_static_probe_ops::get_probes): Change type.
8391         * elfread.c (elfread_data): New typedef.
8392         (probe_key): Change type.
8393         (elf_get_probes): Likewise.  Update.
8394         (probe_key_free): Remove.
8395         (_initialize_elfread): Update.
8396         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8397         Change type.
8398         (dtrace_process_dof_probe, dtrace_process_dof)
8399         (dtrace_static_probe_ops::get_probe): Change type.
8400
8401 2019-05-08  Tom Tromey  <tom@tromey.com>
8402
8403         * xcoffread.c (struct xcoff_symfile_info): Rename from
8404         coff_symfile_info.  Add initializers.
8405         (xcoff_objfile_data_key): Move lower.  Change type.
8406         (XCOFF_DATA): Rewrite.
8407         (xcoff_free_info): Remove.
8408         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8409         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8410         (xcoff_initial_scan): Update.
8411
8412 2019-05-08  Tom Tromey  <tom@tromey.com>
8413
8414         * solib-svr4.c (struct svr4_info): Add initializers and
8415         destructor.
8416         <probes_table>: Now an htab_up.
8417         (solib_svr4_pspace_data): Change type.
8418         (free_probes_table): Simplify.
8419         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8420         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8421         (probes_table_remove_objfile_probes, register_solib_event_probe)
8422         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8423         (_initialize_svr4_solib): Update.
8424
8425 2019-05-08  Tom Tromey  <tom@tromey.com>
8426
8427         * remote.c (remote_pspace_data): Change type.
8428         (remote_pspace_data_cleanup): Remove.
8429         (get_remote_exec_file, set_pspace_remote_exec_file)
8430         (_initialize_remote): Update.
8431
8432 2019-05-08  Tom Tromey  <tom@tromey.com>
8433
8434         * breakpoint.c (breakpoint_objfile_key): Change type.
8435         (get_breakpoint_objfile_data): Update.
8436         (free_breakpoint_objfile_data): Remove.
8437         (_initialize_breakpoint): Update.
8438
8439 2019-05-08  Tom Tromey  <tom@tromey.com>
8440
8441         * linux-tdep.c (struct linux_info): Add initializers.
8442         (linux_inferior_data): Move.  Change type.
8443         (invalidate_linux_cache_inf): Update.
8444         (linux_inferior_data_cleanup): Remove.
8445         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8446
8447 2019-05-08  Tom Tromey  <tom@tromey.com>
8448
8449         * auxv.c (auxv_inferior_data): Move.  Change type.
8450         (auxv_inferior_data_cleanup): Remove.
8451         (invalidate_auxv_cache_inf): Rewrite.
8452         (get_auxv_inferior_data, _initialize_auxv): Update.
8453
8454 2019-05-08  Tom Tromey  <tom@tromey.com>
8455
8456         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8457         (symfile_debug_objfile_data_key): Change type.
8458         (symfile_debug_installed, debug_qf_has_symbols)
8459         (debug_qf_find_last_source_symtab)
8460         (debug_qf_forget_cached_source_info)
8461         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8462         (debug_qf_print_stats, debug_qf_dump)
8463         (debug_qf_expand_symtabs_for_function)
8464         (debug_qf_expand_all_symtabs)
8465         (debug_qf_expand_symtabs_with_fullname)
8466         (debug_qf_map_matching_symbols)
8467         (debug_qf_expand_symtabs_matching)
8468         (debug_qf_find_pc_sect_compunit_symtab)
8469         (debug_qf_map_symbol_filenames)
8470         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8471         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8472         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8473         (debug_sym_read_linetable, debug_sym_relocate): Update.
8474         (symfile_debug_free_objfile): Remove.
8475         (install_symfile_debug_logging, _initialize_symfile_debug):
8476         Update.
8477
8478 2019-05-08  Tom Tromey  <tom@tromey.com>
8479
8480         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8481         allocate_on_obstack.
8482         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8483         (get_dwarf2_per_objfile): Update.
8484         (set_dwarf2_per_objfile): Remove.
8485         (dwarf2_has_info, dwarf2_get_section_info): Update.
8486         (dwarf2_free_objfile): Remove.
8487         (_initialize_dwarf2_read): Update.
8488
8489 2019-05-08  Tom Tromey  <tom@tromey.com>
8490
8491         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8492         initializers.
8493         <unsupported_script_warning_printed,
8494         script_not_found_warning_printed>: Now bool.
8495         (auto_load_pspace_data): Change type.
8496         (~auto_load_pspace_info): Rename from
8497         auto_load_pspace_data_cleanup.
8498         (get_auto_load_pspace_data, init_loaded_scripts_info)
8499         (clear_section_scripts, maybe_print_unsupported_script_warning)
8500         (maybe_print_script_not_found_warning, _initialize_auto_load):
8501         Update.
8502
8503 2019-05-08  Tom Tromey  <tom@tromey.com>
8504
8505         * objfiles.c (objfile_pspace_info): Add destructor and
8506         initializers.
8507         (objfiles_pspace_data): Change type.
8508         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8509         (get_objfile_pspace_data): Update.
8510         (objfiles_bfd_data): Change type.
8511         (get_objfile_bfd_data): Update.
8512         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8513
8514 2019-05-08  Tom Tromey  <tom@tromey.com>
8515
8516         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8517         Change type.
8518         (get_catch_syscall_inferior_data): Update.
8519         (catch_syscall_inferior_data_cleanup): Remove.
8520         (_initialize_break_catch_syscall): Update.
8521
8522 2019-05-08  Tom Tromey  <tom@tromey.com>
8523
8524         * inflow.c (struct terminal_info): Add destructor and
8525         initializers.
8526         (inflow_inferior_data): Change type.
8527         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8528         (get_inflow_inferior_data, inflow_inferior_exit)
8529         (swap_terminal_info, _initialize_inflow): Update.
8530
8531 2019-05-08  Tom Tromey  <tom@tromey.com>
8532
8533         * target-dcache.c (target_dcache_cleanup): Remove.
8534         (target_dcache_aspace_key): Change type.
8535         (target_dcache_init_p, target_dcache_invalidate)
8536         (target_dcache_get, target_dcache_get_or_init)
8537         (_initialize_target_dcache): Update.
8538         * dcache.h (struct dcache_deleter): New.
8539
8540 2019-05-08  Tom Tromey  <tom@tromey.com>
8541
8542         * symtab.c (struct symbol_cache): Add destructor and
8543         initializers.
8544         (symbol_cache_key): Move.  Change type.
8545         (make_symbol_cache, free_symbol_cache): Remove.
8546         (get_symbol_cache): Update.
8547         (symbol_cache_cleanup): Remove.
8548         (ALL_PSPACES, symbol_cache_flush)
8549         (maintenance_print_symbol_cache)
8550         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8551         Update.
8552
8553 2019-05-08  Tom Tromey  <tom@tromey.com>
8554
8555         * symtab.c (struct main_info): Add destructor and initializers.
8556         (main_progspace_key): Move.  Change type.
8557         (get_main_info): Update.
8558         (main_info_cleanup): Remove.
8559         (_initialize_symtab): Update.
8560
8561 2019-05-08  Tom Tromey  <tom@tromey.com>
8562
8563         * registry.h (DECLARE_REGISTRY): Define the _key class.
8564
8565 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8566
8567         * NEWS: Merge two 'New commands' sections.
8568
8569 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8570
8571         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8572         parameter and use Ada language definition instead.
8573         (ada_val_print_ptr): Remove unused language parameter.
8574         (ada_val_print_num): Remove language parameter and use Ada language
8575         definition instead.
8576         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8577         parameter.
8578         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8579         parameter and use Ada language definition instead.
8580         (ada_val_print_1): Update all ada_val_print_xxx calls.
8581         Remove language parameter.
8582         (ada_val_print): Update ada_val_print_1 call.
8583
8584 2019-05-08  Tom Tromey  <tromey@adacore.com>
8585
8586         * remote.c (remote_hw_watchpoint_limit)
8587         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8588         Now static.
8589
8590 2019-05-08  Tom Tromey  <tromey@adacore.com>
8591
8592         * maint.c (_initialize_maint_cmds): Move initialization code to
8593         remote.c.
8594         (watchdog, show_watchdog): Move to remote.c.
8595         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8596         "watchdog" static.
8597         (_initialize_remote): Move initialization code from maint.c.
8598         * defs.h (watchdog): Don't declare.
8599
8600 2019-05-08  Tom Tromey  <tromey@adacore.com>
8601
8602         * tui/tui-interp.c: Include main.h.
8603         * interps.c: Include main.h.
8604         * main.h (interpreter_p): Declare.
8605         * defs.h (interpreter_p): Don't declare.
8606
8607 2019-05-08  Tom Tromey  <tromey@adacore.com>
8608
8609         * dwarf2loc.c: Include dwarf2read.h.
8610         * defs.h (read_unsigned_leb128): Don't declare.
8611         * dwarf2read.h (read_unsigned_leb128): Declare.
8612
8613 2019-05-08  Tom Tromey  <tromey@adacore.com>
8614
8615         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8616         method.
8617
8618 2019-05-08  Tom Tromey  <tromey@adacore.com>
8619
8620         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8621         when no wrap column is set.
8622
8623 2019-05-08  Tom Tromey  <tromey@adacore.com>
8624
8625         * c-lang.c (c_get_string): Handle non-C-style arrays.
8626
8627 2019-05-08  Tom Tromey  <tromey@adacore.com>
8628
8629         * typeprint.c (print_offset_data::update): Print the bit offset,
8630         not the number of bits remaining.
8631
8632 2019-05-08  Tom Tromey  <tromey@adacore.com>
8633
8634         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8635         padding at end of comment.
8636
8637 2019-05-08  Tom Tromey  <tromey@adacore.com>
8638
8639         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8640         Compare main types.
8641
8642 2019-05-06  Tom Tromey  <tom@tromey.com>
8643
8644         * common/scoped_mmap.c: Include common-defs.h.
8645         * common/scoped_mmap.h: Don't include config.h.
8646
8647 2019-05-04  Tom Tromey  <tom@tromey.com>
8648
8649         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8650         (struct aarch64_call_info): Add initializers.
8651         <si>: Now a std::vector.
8652         (pass_on_stack, aarch64_push_dummy_call): Update.
8653
8654 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8655             Tom Tromey  <tom@tromey.com>
8656
8657         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8658         (ppc_threads): Now a std::vector.  Now static.
8659         (hwdebug_find_thread_points_by_tid)
8660         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8661         Update.
8662
8663 2019-05-04  Tom Tromey  <tom@tromey.com>
8664
8665         * arc-tdep.c (arc_tdesc_init): Return bool.
8666
8667 2019-05-04  Tom Tromey  <tom@tromey.com>
8668
8669         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8670         Use gdb_assert_not_reached.
8671
8672 2019-05-04  Tom Tromey  <tom@tromey.com>
8673
8674         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8675         "false".
8676
8677 2019-05-04  Tom Tromey  <tom@tromey.com>
8678
8679         * arc-tdep.c (arc_tdesc_init): Use bool.
8680
8681 2019-05-04  Tom Tromey  <tom@tromey.com>
8682
8683         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8684
8685 2019-05-04  Tom Tromey  <tom@tromey.com>
8686
8687         * cli/cli-cmds.c (valid_command_p): Return bool.
8688
8689 2019-05-04  Tom Tromey  <tom@tromey.com>
8690
8691         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8692         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8693
8694 2019-05-04  Raul Tambre  <raul@tambre.ee>
8695
8696         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8697         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8698         operator for comparison.
8699
8700 2019-05-04  Tom Tromey  <tom@tromey.com>
8701
8702         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8703         (lookup_partial_symbol, print_partial_symbols)
8704         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8705         (psymbol_compare): Update.
8706         (add_psymbol_to_bcache): Clear the entire psymbol.
8707         (maintenance_check_psymtabs): Update.
8708         * psympriv.h (struct partial_symbol): Don't derive from
8709         general_symbol_info.
8710         <obj_section, unrelocated_address, address,
8711         set_unrelocated_address>: Update.
8712         <ginfo>: New member.
8713         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8714         (debug_names::write_psymbols): Update.
8715
8716 2019-05-04  Tom de Vries  <tdevries@suse.de>
8717
8718         * contrib/cc-with-tweaks.sh: Support -n arg.
8719
8720 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8721
8722         * corelow.c (core_target::detach): Ensure frame cache and
8723         register caches are cleared.
8724         inferior.c (exit_inferior_1): Likewise.
8725
8726 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8727             Tom Tromey  <tom@tromey.com>
8728
8729         * dictionary.c (collate_pending_symbols_by_language): Remove
8730         "struct" from foreach.
8731         * symtab.c (lookup_global_symbol_from_objfile)
8732         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8733         foreach.
8734         * ser-tcp.c (net_open): Remove "struct" from foreach.
8735         * objfiles.c (objfile_relocate, objfile_rebase)
8736         (objfile_has_symbols): Remove "struct" from foreach.
8737         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8738         from foreach.
8739         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8740         foreach.
8741         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8742         "struct" from foreach.
8743         * ada-lang.c (create_excep_cond_exprs)
8744         (ada_exception_catchpoint_cond_string): Remove "struct" from
8745         foreach.
8746
8747 2019-05-03  Tom Tromey  <tromey@adacore.com>
8748
8749         * ada-exp.y (convert_char_literal): Check suffix of each
8750         enumerator.
8751
8752 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8753
8754         PR ada/21406:
8755         * ada-exp.y (yywrap): Don't define.
8756         * ada-lex.l (%option): Add noyywrap
8757         (yywrap): Remove.
8758
8759 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8760
8761         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8762         _WIN32_WINNT to the XP level, unless already defined to a higher
8763         level.
8764
8765         * unittests/parse-connection-spec-selftests.c:
8766         * ser-tcp.c:
8767         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8768         override.
8769
8770         * symfile.c (find_separate_debug_file): Remove colon from the
8771         drive spec of DOS/Windows file names of the target, so that the
8772         file name produced from DEBUGDIR and the target's directory will
8773         be valid on DOS/Windows systems.
8774
8775 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8776
8777         * rust-lang.c (val_print_struct): Handle printing structures
8778         containing strings.
8779
8780 2019-05-02  Tom Tromey  <tromey@adacore.com>
8781
8782         * valarith.c (_initialize_valarith): Remove.
8783
8784 2019-05-01  Tom Tromey  <tromey@adacore.com>
8785
8786         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8787         bitfields.
8788
8789 2019-05-01  Tom Tromey  <tromey@adacore.com>
8790
8791         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8792         for big-endian copies.
8793
8794 2019-04-30  Ali Tamur  <tamur@google.com>
8795         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8796         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8797         (read_3_bytes): New function.
8798
8799 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8800
8801         * windows-nat.c (main_thread_id): Delete.
8802         (handle_output_debug_string): Replace main_thread_id by
8803         current_event.dwThreadId.
8804         (fake_create_process): Likewise.
8805         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8806         Do not set main_thread_id.
8807         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8808         current_event.dwThreadId.
8809         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8810
8811 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8812
8813         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8814         Use current_event.dwThreadId instead of main_thread_id.
8815
8816 2019-04-30  Tom Tromey  <tromey@adacore.com>
8817
8818         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8819         (create_excep_cond_exprs): Iterate over program spaces.
8820         (ada_exception_catchpoint_cond_string): Examine all minimal
8821         symbols for exception types.
8822
8823 2019-04-30  Tom Tromey  <tromey@adacore.com>
8824
8825         PR c++/24470:
8826         * dwarf2read.c (process_structure_scope): Handle case where type
8827         has template parameters but no symbol was created.
8828
8829 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8830             Chris January  <chris.january@arm.com>
8831
8832         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8833         qualifier.
8834         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8835
8836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8837
8838         * f-typeprint.c (f_print_type): Update rules for printing
8839         whitespace.
8840         (f_type_print_varspec_suffix): Likewise.
8841
8842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8843             Chris January  <chris.january@arm.com>
8844
8845         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8846         function arguments.
8847
8848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8849
8850         * f-lang.c (build_fortran_types): Change name of void type to
8851         lower case.
8852         * f-typeprint.c (f_type_print_base): Print the name of the void
8853         type, rather than a fixed string.
8854         * f-valprint.c (f_decorations): Use lower case void string.
8855
8856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8857             Chris January  <chris.january@arm.com>
8858
8859         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8860         types for Fortran.
8861
8862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8863             Chris January  <chris.january@arm.com>
8864             David Lecomber  <david.lecomber@arm.com>
8865
8866         * f-exp.y (BINOP_INTRINSIC): New token.
8867         (exp): New parser rule handling BINOP_INTRINSIC.
8868         (f77_keywords): Add new builtin procedures.
8869         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8870         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8871         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8872         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8873         (print_unop_subexp_f): New function.
8874         (print_binop_subexp_f): New function.
8875         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8876         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8877         (dump_subexp_body_f): Likewise.
8878         (operator_check_f): Likewise.
8879         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8880         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8881
8882 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8883
8884         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8885         UNOP_KIND.
8886         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8887         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8888         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8889         (operator_length_f): New fuction.
8890         (print_subexp_f): New function.
8891         (op_name_f): New function.
8892         (dump_subexp_body_f): New function.
8893         (operator_check_f): New function.
8894         (exp_descriptor_f): Replace standard expression handling functions
8895         with new functions.
8896         * gdb/fortran-operator.def: New file.
8897         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8898         * gdb/std-operator.def: Remove UNOP_KIND.
8899
8900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8901
8902         * std-operator.def: Remove unbalanced, stray double quote
8903         character.
8904
8905 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8906             Chris January  <chris.january@arm.com>
8907             Daniel Everett  <daniel.everett@arm.com>
8908             Nick Forrington  <nick.forrington@arm.com>
8909             Richard Bunt  <richard.bunt@arm.com>
8910
8911         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8912         of depth when printing anonymous structs or unions.
8913         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8914         Don't print either the top-level value, or the children if the
8915         max-depth is exceeded.
8916         (ppscm_print_children): When printing the key of a map, allow one
8917         extra level of depth.
8918         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8919         print either the top-level value, or the children if the max-depth
8920         is exceeded.
8921         (print_children): When printing the key of a map, allow one extra
8922         level of depth.
8923         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8924         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8925         (user_print_options): Initialise max_depth field.
8926         (val_print_scalar_or_string_type_p): New function.
8927         (val_print): Check to see if the max depth has been reached.
8928         (val_print_check_max_depth): Define new function.
8929         (show_print_max_depth): New function.
8930         (_initialize_valprint): Add 'print max-depth' option.
8931         * valprint.h (struct value_print_options) <max_depth>: New field.
8932         (val_print_check_max_depth): Declare new function.
8933         * NEWS: Document new feature.
8934
8935 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8936
8937         * ada-lang.c (ada_language_defn): Initialise new field.
8938         * c-lang.c (c_is_string_type_p): New function.
8939         (c_language_defn): Initialise new field.
8940         (cplus_language_defn): Initialise new field.
8941         (asm_language_defn): Initialise new field.
8942         (minimal_language_defn): Initialise new field.
8943         * c-lang.h (c_is_string_type_p): Declare new function.
8944         * d-lang.c (d_language_defn): Initialise new field.
8945         * f-lang.c (f_is_string_type_p): New function.
8946         (f_language_defn): Initialise new field.
8947         * go-lang.c (go_is_string_type_p): New function.
8948         (go_language_defn): Initialise new field.
8949         * language.c (default_is_string_type_p): New function.
8950         (unknown_language_defn): Initialise new field.
8951         (auto_language_defn): Initialise new field.
8952         * language.h (struct language_defn) <la_is_string_type_p>: New
8953         member variable.
8954         (default_is_string_type_p): Declare new function.
8955         * m2-lang.c (m2_language_defn): Initialise new field.
8956         * objc-lang.c (objc_language_defn): Initialise new field.
8957         * opencl-lang.c (opencl_language_defn): Initialise new field.
8958         * p-lang.c (pascal_is_string_type_p): New function.
8959         (pascal_language_defn): Initialise new field.
8960         * rust-lang.c (rust_is_string_type_p): New function.
8961         (rust_language_defn): Initialise new field.
8962
8963 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8964
8965         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8966         New field.
8967         * ada-lang.c (ada_language_defn): Initialise new field.
8968         * c-lang.c (c_language_defn): Likewise.
8969         (cplus_language_defn): Likewise.
8970         (asm_language_defn): Likewise.
8971         (minimal_language_defn): Likewise.
8972         * d-lang.c (d_language_defn): Likewise.
8973         * f-lang.c (f_language_defn): Likewise.
8974         * go-lang.c (go_language_defn): Likewise.
8975         * language.c (unknown_language_defn): Likewise.
8976         (auto_language_defn): Likewise.
8977         * m2-lang.c (m2_language_defn): Likewise.
8978         * objc-lang.c (objc_language_defn): Likewise.
8979         * opencl-lang.c (opencl_language_defn): Likewise.
8980         * p-lang.c (pascal_language_defn): Likewise.
8981         * rust-lang.c (rust_language_defn): Likewise.
8982
8983 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8984
8985         * ada-lang.c (ada_is_character_type): Change return type to bool.
8986         (ada_is_string_type): Likewise.
8987         * ada-lang.h (ada_is_character_type): Update declaration
8988         (ada_is_string_type): Likewise.
8989
8990 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8991
8992         Support style in 'frame|thread apply'
8993
8994         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8995         * record.c (record_start, record_stop): Update callers of
8996         execute_command_to_string with false.
8997         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8998         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8999         methods.
9000         (class string_file): New constructor with term_out parameter.
9001         Override methods term_out and can_emit_style_escape.  New member
9002         term_out.
9003         (class stdio_file): Override can_emit_style_escape.
9004         (class tee_file): Override term_out and can_emit_style_escape.
9005         * utils.h (can_emit_style_escape): Remove.
9006         * utils.c (can_emit_style_escape): Likewise.
9007         Update all callers of can_emit_style_escape (SOMESTREAM) to
9008         SOMESTREAM->can_emit_style_escape.
9009         * source-cache.c (source_cache::get_source_lines): Likewise.
9010         * stack.c (frame_apply_command_count): Call execute_command_to_string
9011         passing the term_out characteristic of the current gdb_stdout.
9012         * thread.c (thr_try_catch_cmd): Likewise.
9013         * top.c (execute_command_to_string): pass term_out parameter
9014         to construct the string_file for the command output.
9015         * ui-file.c (term_cli_styling): New function (most code moved
9016         from utils.c can_emit_style_escape).
9017         (string_file::string_file, string_file::can_emit_style_escape,
9018         stdio_file::can_emit_style_escape, tee_file::term_out,
9019         tee_file::can_emit_style_escape): New functions.
9020
9021 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9022
9023         * NEWS: Mention the new set|show may-call-functions.
9024         * infcall.c (may_call_functions_p): New variable.
9025         (show_may_call_functions_p): New function.
9026         (call_function_by_hand_dummy): Throws an error if not
9027         may-call-functions.
9028         (_initialize_infcall): Call add_setshow_boolean_cmd for
9029         may-call-functions.
9030
9031 2019-04-25  Keith Seitz  <keiths@redhat.com>
9032
9033         PR c++/24367
9034         * cp-support.c (inspect_type): Don't attempt substitutions
9035         of symbol with the same name.
9036
9037 2019-04-25  Tom Tromey  <tromey@adacore.com>
9038
9039         PR gdb/24475:
9040         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9041         static.
9042
9043 2019-04-25  Tom Tromey  <tromey@adacore.com>
9044
9045         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9046         rvalue reference.
9047         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9048         (gdb_xml_parser::parse): Use std::move.
9049         * python/python-internal.h (gdbpy_convert_exception): Take a const
9050         reference.
9051         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9052         std::move.
9053         * python/py-utils.c (gdbpy_convert_exception): Take a const
9054         reference.
9055         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9056         Use std::move.
9057         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9058         Use std::move.
9059         * mi/mi-main.c (mi_print_exception): Take a const reference.
9060         * main.c (handle_command_errors): Take a const reference.
9061         * linespec.c (parse_linespec): Use std::move.
9062         * infcall.c (run_inferior_call): Use std::move.
9063         (call_function_by_hand_dummy): Use std::move.
9064         * exec.c (try_open_exec_file): Use std::move.
9065         * exceptions.h (exception_print, exception_fprintf)
9066         (exception_print_same): Update.
9067         * exceptions.c (print_exception, exception_print)
9068         (exception_fprintf, exception_print_same): Change parameters to
9069         const reference.
9070         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9071         * common/new-op.c: Use std::move.
9072         * common/common-exceptions.h (struct gdb_exception): Add move
9073         constructor.
9074         (struct gdb_exception_error, struct gdb_exception_quit, struct
9075         gdb_quit_bad_alloc): Change constructor to move constructor.
9076         (throw_exception): Change parameter to rvalue reference.
9077         * common/common-exceptions.c (throw_exception): Take rvalue
9078         reference.
9079         * cli/cli-interp.c (safe_execute_command): Use std::move.
9080         * breakpoint.c (insert_bp_location, location_to_sals): Use
9081         std::move.
9082
9083 2019-04-25  Tom Tromey  <tromey@adacore.com>
9084
9085         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9086         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9087         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9088         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9089         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9090         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9091         guile/scm-value.c: Use unpack.
9092         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9093         gdbscm_gdb_exception.
9094         (gdbscm_throw_gdb_exception): Likewise.
9095         (struct gdbscm_gdb_exception): New.
9096         (unpack): New function.
9097         (gdbscm_wrap): Use unpack.
9098
9099 2019-04-25  Tom Tromey  <tromey@adacore.com>
9100
9101         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9102         (gdb_rl_callback_handler): Use std::move.
9103         * common/common-exceptions.h (struct gdb_exception): Add move
9104         assignment operator.
9105         (throw_exception_sjlj): Change "exception" to const reference.
9106         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9107         (throw_exception_sjlj): Change "exception" to const reference.
9108
9109 2019-04-25  Tom Tromey  <tromey@adacore.com>
9110
9111         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9112         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9113         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9114         Update.
9115         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9116         Update.
9117         * mi/mi-interp.c (mi_interp::exec): Update.
9118         * linespec.c (parse_linespec): Update.
9119         * infcall.c (run_inferior_call): Update.
9120         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9121         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9122         (gdbscm_lookup_global_symbol): Update.
9123         * guile/scm-param.c (gdbscm_parameter_value): Update.
9124         * guile/scm-frame.c (gdbscm_frame_read_register)
9125         (gdbscm_frame_read_var): Update.
9126         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9127         * exec.c (try_open_exec_file): Update.
9128         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9129         (gdb_rl_callback_handler): Update.
9130         * common/common-exceptions.h (exception_none): Don't declare.
9131         * common/common-exceptions.c (exception_none): Don't define.
9132         (struct catcher) <exception>: Update.
9133         * cli/cli-interp.c (safe_execute_command): Update.
9134         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9135
9136 2019-04-25  Ali Tamur  <tamur@google.com>
9137
9138         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9139         (read_attribute_value): Likewise.
9140         (dwarf2_read_addr_index): Update comment.
9141         (read_str_index): Add DW_FORM_strx.
9142         (dwarf2_string_attr): Likewise.
9143         (dwarf2_const_value_attr): Likewise.
9144         (dump_die_shallow): Likewise.
9145         (dwarf2_fetch_constant_bytes): Likewise.
9146         (skip_form_bytes): Likewise.
9147         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9148
9149 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9150
9151         PR corefiles/11608
9152         PR corefiles/18187
9153         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9154         OFFSET.  Verify if current mapping contains an ELF header.
9155         (linux_find_memory_regions_full): Adjust call to
9156         dump_mapping_p.
9157
9158 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9159             Kang Li <kanglictf@gmail.com>
9160
9161         PR gdb/21600
9162
9163         * dwarf2-frame.c (read_initial_length): Be consistent about using
9164         unsigned representation of length.
9165         (decode_frame_entry_1): Likewise.  Check for wraparound of
9166         end pointer as well as buffer overflow.
9167
9168 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9169
9170         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9171         "vq".
9172
9173 2019-04-24  Tom Tromey  <tromey@adacore.com>
9174
9175         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9176
9177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9178
9179         * s12z-tdep.c (s12z_unwind_pc): Delete.
9180         (s12z_unwind_sp): Delete.
9181         (s12z_gdbarch_init): Don't register deleted functions with
9182         gdbarch.
9183
9184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9185
9186         * rl78-tdep.c (rl78_unwind_sp): Delete.
9187         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9188
9189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9190
9191         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9192         (xstormy16_unwind_pc): Delete.
9193         (xstormy16_dummy_id): Delete.
9194         (xstormy16_gdbarch_init): Don't register deleted functions with
9195         gdbarch.
9196
9197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9198
9199         * vax-tdep.c (vax_unwind_pc): Delete.
9200         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9201
9202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9203
9204         * v850-tdep.c (v850_unwind_sp): Delete.
9205         (v850_unwind_pc): Delete.
9206         (v850_dummy_id): Delete.
9207         (v850_gdbarch_init): Don't register deleted functions with
9208         gdbarch.
9209
9210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9211
9212         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9213         (tilegx_unwind_pc): Delete.
9214         (tilegx_unwind_dummy_id): Delete.
9215         (tilegx_gdbarch_init): Don't register deleted functions with
9216         gdbarch.
9217
9218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9219
9220         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9221         (tic6x_dummy_id): Delete.
9222         (tic6x_gdbarch_init): Don't register deleted functions with
9223         gdbarch.
9224
9225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9226
9227         * sparc-tdep.c (sparc_unwind_pc): Delete.
9228         (sparc32_gdbarch_init): Don't register deleted function with
9229         gdbarch.
9230
9231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9232
9233         * sh-tdep.c (sh_unwind_sp): Delete.
9234         (sh_unwind_pc): Delete.
9235         (sh_dummy_id): Delete.
9236         (sh_gdbarch_init): Don't register deleted functions with
9237         gdbarch.
9238
9239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9240
9241         * score-tdep.c (score_unwind_sp): Delete.
9242         (score_unwind_pc): Delete.
9243         (score_dummy_id): Delete.
9244         (score_gdbarch_init): Don't register deleted functions with
9245         gdbarch.
9246
9247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9248
9249         * rx-tdep.c (rx_unwind_pc): Delete.
9250         (rx_unwind_sp): Delete.
9251         (rx_dummy_id): Delete.
9252         (rx_gdbarch_init): Don't register deleted functions with
9253         gdbarch.  Update comment.
9254
9255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9256
9257         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9258         (rs6000_dummy_id): Delete.
9259         (rs6000_gdbarch_init): Don't register deleted functions with
9260         gdbarch.
9261
9262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9263
9264         * or1k-tdep.c (or1k_dummy_id): Delete.
9265         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9266
9267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9268
9269         * nios2-tdep.c (nios2_dummy_id): Delete.
9270         (nios2_unwind_sp): Delete.
9271         (nios2_gdbarch_init): Don't register deleted functions with
9272         gdbarch.
9273
9274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * nds32-tdep.c (nds32_dummy_id): Delete.
9277         (nds32_unwind_pc): Delete.
9278         (nds32_unwind_sp): Delete.
9279         (nds32_gdbarch_init): Don't register deleted functions with
9280         gdbarch.
9281
9282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9283
9284         * msp430-tdep.c (msp430_unwind_pc): Delete.
9285         (msp430_unwind_sp): Delete.
9286         (msp430_dummy_id): Delete.
9287         (msp430_gdbarch_init): Don't register deleted functions with
9288         gdbarch.
9289
9290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9291
9292         * moxie-tdep.c (moxie_unwind_sp): Delete.
9293         (moxie_unwind_pc): Delete.
9294         (moxie_dummy_id): Delete.
9295         (moxie_gdbarch_init): Don't register deleted functions with
9296         gdbarch.
9297
9298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9299
9300         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9301         (mn10300_unwind_pc): Delete.
9302         (mn10300_unwind_sp): Delete.
9303         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9304         mn10300_unwind_sp.
9305         (mn10300_frame_unwind_init): Don't register deleted functions with
9306         gdbarch.
9307
9308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9309
9310         * mep-tdep.c (mep_unwind_pc): Delete.
9311         (mep_unwind_sp): Delete.
9312         (mep_dummy_id): Delete.
9313         (mep_gdbarch_init): Don't register deleted functions with
9314         gdbarch.
9315
9316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9317
9318         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9319         (m68hc11_unwind_sp): Delete.
9320         (m68hc11_gdbarch_init): Don't register deleted functions with
9321         gdbarch.
9322
9323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9324
9325         * m32r-tdep.c (m32r_unwind_sp): Delete.
9326         (m32r_unwind_pc): Delete.
9327         (m32r_dummy_id): Delete.
9328         (m32r_gdbarch_init): Don't register deleted functions with
9329         gdbarch.
9330
9331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9332
9333         * m32c-tdep.c (m32c_unwind_pc): Delete.
9334         (m32c_unwind_sp): Delete.
9335         (m32c_dummy_id): Delete.
9336         (m32c_gdbarch_init): Don't register deleted functions with
9337         gdbarch.
9338
9339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9340
9341         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9342         (lm32_unwind_pc): Delete.
9343         (lm32_dummy_id): Delete.
9344         (lm32_gdbarch_init): Don't register deleted functions with
9345         gdbarch.
9346
9347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9348
9349         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9350         (iq2000_unwind_pc): Delete.
9351         (iq2000_dummy_id): Delete.
9352         (iq2000_gdbarch_init): Don't register deleted functions with
9353         gdbarch.
9354
9355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9356
9357         * nds32-tdep.c (nds32_type_align): Delete.
9358         (nds32_push_dummy_call): Use type_align instead.
9359
9360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9361
9362         * arm-tdep.c (arm_type_align): Only handle vector override case.
9363         (arm_push_dummy_call): Use type_align.
9364         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9365
9366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9367
9368         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9369         case.
9370         (pass_on_stack): Use type_align.
9371         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9372         function.
9373
9374 2019-04-23  Tom Tromey  <tromey@adacore.com>
9375
9376         * dwarf2read.c (line_header::file_name_at): Remove unused
9377         overload.
9378
9379 2019-04-23  Tom de Vries  <tdevries@suse.de>
9380
9381         PR gdb/24438
9382         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9383         invocation.
9384
9385
9386 2019-03-27  Ali Tamur  <tamur@google.com>
9387
9388         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9389         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9390         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9391         (dwarf_expr_context::get_addr_index): Likewise
9392         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9393         (symbol_needs_eval_context::get_addr_index): Likewise
9394         (disassemble_dwarf_expression): Add DW_OP_addrx
9395         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9396         (read_cutu_die_from_dwo): Update comment
9397         (skip_one_die): Add DW_FORM_addrx
9398         (read_attribute_value): Likewise
9399         (var_decode_location): Add DW_OP_addrx
9400         (dwarf2_const_value_attr): Add DW_FORM_addrx
9401         (dump_die_shallow): Likewise
9402         (dwarf2_fetch_constant_bytes): Likewise
9403         (decode_locdesc): Add DW_OP_addrx
9404         (skip_form_bytes): Add DW_FORM_addrx
9405
9406 2019-04-22  Ali Tamur  <tamur@google.com>
9407
9408         * MAINTAINERS (Write After Approval): Add self.
9409
9410 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9411
9412         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9413         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9414         (open_symbol_file_object): Likewise.
9415         (svr4_default_sos): Add info parameter.
9416         (svr4_read_so_list): Likewise.
9417         (svr4_current_sos_direct): Adjust functions calls to pass down
9418         info.
9419         (svr4_current_sos_1): Add info parameter.
9420         (svr4_current_sos): Call get_svr4_info, pass info down to
9421         svr4_current_sos_1.
9422         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9423         get_svr4_info.
9424         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9425         get_svr4_info.
9426         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9427         to get_svr4_info.
9428         (probes_table_remove_objfile_probes): Likewise.
9429         (register_solib_event_probe): Add info parameter.
9430         (solist_update_incremental): Pass info parameter down to
9431         svr4_read_so_list.
9432         (disable_probes_interface): Add info parameter.
9433         (svr4_handle_solib_event): Pass current_program_space to
9434         get_svr4_info.  Adjust disable_probes_interface cleanup.
9435         (svr4_create_probe_breakpoints): Add info parameter, pass it
9436         down to register_solib_event_probe.
9437         (svr4_create_solib_event_breakpoints): Add info parameter,
9438         pass it down to svr4_create_probe_breakpoints.
9439         (enable_break): Pass info down to
9440         svr4_create_solib_event_breakpoints.
9441         (svr4_solib_create_inferior_hook): Pass current_program_space to
9442         get_svr4_info.
9443         (svr4_clear_solib): Likewise.
9444
9445 2019-04-22  Pedro Alves  <palves@redhat.com>
9446
9447         * solib-svr4.c (svr4_free_objfile_observer): New.
9448         (probe_and_action::objfile): New field.
9449         (probes_table_htab_remove_objfile_probes)
9450         (probes_table_remove_objfile_probes): New functions.
9451         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9452         in the new probe_and_action.  Don't store the probe in 'lookup'.
9453         (svr4_create_probe_breakpoints): Pass objfile to
9454         register_solib_event_probe.
9455         (_initialize_svr4_solib): Register a free_objfile observer.
9456
9457 2019-04-19  Tom Tromey  <tom@tromey.com>
9458
9459         * common/queue.h: Remove.
9460
9461 2019-04-19  Tom Tromey  <tom@tromey.com>
9462
9463         * event-loop.c: Don't include "common/queue.h".
9464
9465 2019-04-19  Tom Tromey  <tom@tromey.com>
9466
9467         * remote.c (remote_target): Use delete.
9468         * remote-notif.h: Include <list>, not "common/queue.h".
9469         (notif_client_p): Remove typedef.
9470         (remote_notif_state): Add constructor, destructor, initializer.
9471         <notif_queue>: Now a std::list.
9472         (remote_notif_state_xfree): Don't declare.
9473         * remote-notif.c (remote_notif_process, handle_notification)
9474         (remote_notif_state_allocate): Update.
9475         (~remote_notif_state): Rename from remote_notif_state_xfree.
9476
9477 2019-04-19  Tom Tromey  <tom@tromey.com>
9478
9479         * symfile.c (reread_symbols): Update.
9480         * objfiles.c (objfile_register_static_link)
9481         (objfile_lookup_static_link): Update
9482         (~objfile) Don't delete static_links.
9483         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9484
9485 2019-04-19  Tom Tromey  <tom@tromey.com>
9486
9487         * type-stack.h (struct type_stack) <insert>: Constify string.
9488         * type-stack.c (type_stack::insert): Constify string.
9489         * gdbtypes.h (lookup_template_type): Update.
9490         (address_space_name_to_int): Update.
9491         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9492         const.
9493         (lookup_template_type): Make name const.
9494         * c-exp.y: Update rules.
9495         (lex_one_token, classify_name, classify_inner_name)
9496         (c_print_token): Update.
9497         * p-exp.y: Update rules.
9498         (yylex): Update.
9499         * f-exp.y: Update rules.
9500         (yylex): Update.
9501         * d-exp.y: Update rules.
9502         (lex_one_token, classify_name, classify_inner_name): Update.
9503         * parse.c (write_dollar_variable, copy_name): Return std::string.
9504         * parser-defs.h (copy_name): Change return type.
9505         * m2-exp.y: Update rules.
9506         (yylex): Update.
9507         * go-exp.y (lex_one_token): Update.
9508         Update rules.
9509         (classify_unsafe_function, classify_packaged_name)
9510         (classify_name, yylex): Update.
9511
9512 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9513
9514         * configure.ac: add --enable-source-highlight switch.
9515         * configure: Regenerate.
9516         * top.c (print_gdb_version): plumb --enable-source-highlight
9517         status to "show configuration".
9518
9519 2019-04-19  Tom Tromey  <tromey@adacore.com>
9520
9521         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9522         Check ADA_TYPE_P.
9523         (empty_record, ada_template_to_fixed_record_type_1)
9524         (template_to_static_fixed_type)
9525         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9526         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9527         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9528         macros.
9529
9530 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9531
9532         PR symtab/24423:
9533         * source.c (print_source_lines_base): Advance "iter" when a
9534         control character is seen.
9535
9536 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9537
9538         * inferior.h (struct infcall_suspend_state_deleter):
9539         Catch exception in destructor to avoid crash.
9540
9541 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9542
9543         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9544         close to the add_com "shell".
9545
9546 2019-04-18  Tom Tromey  <tromey@adacore.com>
9547
9548         * process-stratum-target.h (class process_stratum_target)
9549         <stratum>: Add "final".
9550
9551 2019-04-17  Tom Tromey  <tromey@adacore.com>
9552
9553         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9554         against nullptr before use.
9555
9556 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9557
9558         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9559
9560 2019-04-17  Jim Wilson  <jimw@sifive.com>
9561             Andrew Burgess  <andrew.burgess@embecosm.com>
9562
9563         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9564         code read might fail, assume 4-byte breakpoint in that case.
9565
9566 2019-04-15  Leszek Swirski  <leszeks@google.com>
9567
9568         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9569         rather than a hand-rolled POD check when checking for forced MEMORY
9570         classification.
9571
9572 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9573
9574         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9575         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9576         function.
9577         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9578         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9579         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9580         declaration.
9581
9582 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9583
9584         * aarch64-linux-nat.c
9585         (aarch64_linux_nat_target::thread_architecture): Add override.
9586         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9587         each VQ.
9588
9589 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9590
9591         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9592
9593 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9594
9595         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9596         target types of size 96-bits, add some additional comments, and
9597         check that the builtin type we found was the correct size.
9598
9599 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9600
9601         * utils.c (prompt_for_continue): Don't restore the styling at the
9602         end, as applied_style has the wrong value.  This fixes styling in
9603         long lists of file names that are interrupted by the "Continue?"
9604         prompt.
9605
9606 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9607
9608         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9609         * c-lang.c (c_language_defn): Likewise.
9610         (cplus_language_defn): Likewise.
9611         (asm_language_defn): Likewise.
9612         (minimal_language_defn): Likewise.
9613         * d-lang.c (d_language_defn): Likewise.
9614         * f-lang.c (f_language_defn): Likewise.
9615         * go-lang.c (go_language_defn): Likewise.
9616         * language.c (unknown_language_defn): Likewise.
9617         (auto_language_defn): Likewise.
9618         * language.h (struct language_defn): Remove la_magic field.
9619         (LANG_MAGIC): Delete.
9620         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9621         * objc-lang.c (objc_language_defn): Likewise.
9622         * opencl-lang.c (opencl_language_defn): Likewise.
9623         * p-lang.c (pascal_language_defn): Likewise.
9624         * rust-lang.c (rust_language_defn): Likewise.
9625
9626 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9627
9628         * riscv-tdep.c (riscv_type_align): New function.
9629         (riscv_type_alignment): Delete.
9630         (riscv_arg_location): Use 'type_align'.
9631         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9632
9633 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9634
9635         * gdbtypes.c (type_align): A struct with no non-static fields also
9636         has alignment of 1.
9637
9638 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9639
9640         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9641         component to 0.
9642         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9643         member.
9644         (riscv_struct_info::analyse): New implementation using new
9645         analyse_inner member function.
9646         (riscv_struct_info::field_offset): New member function.
9647         (riscv_struct_info::m_offsets): New member variable.
9648         (riscv_struct_info::analyse_inner): New private member function,
9649         takes the old implementation of riscv_struct_info::analyse but
9650         extended to track field offsets.
9651         (riscv_call_arg_struct): Update the struct folding special cases
9652         to handle cases where empty C++ structs, which are non-zero
9653         length, are found.
9654         (riscv_arg_location): Initialise the length of each location, a
9655         non-zero length now indicates the location is in use.
9656         (riscv_push_dummy_call): Allow for the first location having a
9657         non-zero offset when setting up arguments.
9658         (riscv_return_value): Likewise, but for return values.
9659
9660 2019-04-11  Tom Tromey  <tromey@adacore.com>
9661
9662         * utils.c (internal_vproblem): Make "msg" const.
9663
9664 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9665
9666         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9667         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9668         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9669         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9670
9671 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9672
9673         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9674         function.
9675         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9676         of amd64_collect_native_gregset.
9677         (amd64_linux_nat_target::store_registers): Likewise.
9678
9679 2019-04-10  Tom Tromey  <tom@tromey.com>
9680
9681         * symtab.c (lookup_global_symbol_from_objfile)
9682         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9683         * objfiles.h (class separate_debug_iterator): New.
9684         (class separate_debug_range): New.
9685         (struct objfile) <separate_debug_objfiles>: New method.
9686         (objfile_separate_debug_iterate): Don't declare.
9687         * objfiles.c (separate_debug_iterator::operator++): Rename from
9688         objfile_separate_debug_iterate.
9689         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9690         iterator.
9691         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9692         iterator.
9693
9694 2019-04-10  Tom Tromey  <tom@tromey.com>
9695
9696         * symfile.c (reread_symbols): Remove old comment.
9697         * objfiles.c (free_all_objfiles): Fix a typo.
9698
9699 2019-04-10  Tom Tromey  <tom@tromey.com>
9700
9701         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9702         * minsyms.c (lookup_minimal_symbol): Use foreach.
9703         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9704         (lookup_minimal_symbol_solib_trampoline): Likewise.
9705         * symfile.c (reread_symbols): Use foreach.
9706
9707 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9708             Tom Tromey  <tromey@adacore.com>
9709
9710         PR rust/24414:
9711         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9712         (rust_lex_int_test): Change "value" to be LONGEST.
9713         (rust_lex_tests): Add test for long integer literal.
9714
9715 2019-04-09  Tom Tromey  <tromey@adacore.com>
9716
9717         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9718         to bool.
9719         (extended_remote_target::attach): Update.
9720         (remote_target::remote_notice_new_inferior): Update.
9721         (remote_target::add_current_inferior_and_thread): Update.
9722         * inferior.c (exit_inferior_1): Use "false".
9723         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9724
9725 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9726
9727         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9728         the "start" command.
9729
9730 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9731
9732         * python/py-inferior.c (infpy_thread_from_thread_handle):
9733         Adjust comments to reflect renaming of thread_from_thread_handle
9734         to thread_from_handle.  Adjust keywords.  Fix type error message.
9735         (inferior_object_methods): Add thread_from_handle.  Retain
9736         thread_from_thread_handle, but mark it as deprecated.
9737
9738 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9739
9740         * gdbthread.h (find_thread_by_handle): Revise declaration.
9741         * thread.c (find_thread_by_handle): Likewise.  Adjust
9742         implementation too.
9743         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9744         support for buffer objects as handles.
9745
9746 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9747
9748         * python/py-infthread.c (thpy_thread_handle): New function.
9749         (thread_object_methods): Register thpy_thread_handle.
9750
9751 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9752
9753         * gdbthread.h (thread_to_thread_handle): Declare.
9754         * thread.c (gdbtypes.h): Include.
9755         (thread_to_thread_handle): New function.
9756
9757         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9758         (target_thread_info_to_thread_handle): Declare.
9759         * target.c (target_thread_info_to_thread_handle): New function.
9760         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9761         * target-delegates.c: Regenerate.
9762
9763         * linux-thread-db.c (class thread_db_target): Add method
9764         thread_info_to_thread_handle.
9765         (thread_db_target::thread_info_to_thread_handle): Define.
9766         * remote.c (class remote_target): Add new method
9767         thread_info_to_thread_handle.
9768         (remote_target::thread_info_to_thread_handle): Define.
9769
9770 2019-04-08  Pedro Alves  <palves@redhat.com>
9771
9772         * common/common-exceptions.c (throw_exception): Don't create
9773         named object to throw; throw directly.
9774         (throw_it): Likewise.  Don't initialize gdb_exception::message
9775         here, with new; pass FMT and AP to the ctor instead.
9776         * common/common-exceptions.h: Include <string>.
9777         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9778         const char *, va_list)): New ctor.  Use std::make_shared.
9779         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9780         errors)): Delete.
9781         (gdb_exception_error::gdb_exception_error(enum errors, const char
9782         *, va_list)): New.
9783         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9784         Add assertion.
9785         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9786         errors)): Delete.
9787         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9788         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9789         Add assertion.
9790
9791 2019-04-08  Tom Tromey  <tom@tromey.com>
9792
9793         * valops.c (value_rtti_indirect_type): Replace throw_exception
9794         with throw.
9795         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9796         with throw.
9797         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9798         throw.
9799         * target.c (target_translate_tls_address): Replace throw_exception
9800         with throw.
9801         * stack.c (frame_apply_command_count): Replace throw_exception
9802         with throw.
9803         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9804         throw.
9805         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9806         with throw.
9807         * rs6000-tdep.c (rs6000_frame_cache)
9808         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9809         * remote.c: Replace throw_exception with throw.
9810         * record-full.c (record_full_message, record_full_wait_1)
9811         (record_full_restore): Replace throw_exception with throw.
9812         * record-btrace.c:
9813         (get_thread_current_frame_id, record_btrace_start_replaying)
9814         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9815         (cmd_record_btrace_start): Replace throw_exception with throw.
9816         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9817         throw.
9818         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9819         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9820         * linespec.c:
9821         (find_linespec_symbols): Replace throw_exception with throw.
9822         * infrun.c (displaced_step_prepare, resume): Replace
9823         throw_exception with throw.
9824         * infcmd.c (post_create_inferior): Replace throw_exception with
9825         throw.
9826         * inf-loop.c (inferior_event_handler): Replace throw_exception
9827         with throw.
9828         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9829         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9830         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9831         (get_prev_frame_always, get_frame_pc_if_available)
9832         (get_frame_address_in_block_if_available, get_frame_language):
9833         Replace throw_exception with throw.
9834         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9835         throw_exception with throw.
9836         * eval.c (fetch_subexp_value, evaluate_var_value)
9837         (evaluate_funcall, evaluate_subexp_standard): Replace
9838         throw_exception with throw.
9839         * dwarf2loc.c (call_site_find_chain)
9840         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9841         Replace throw_exception with throw.
9842         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9843         with throw.
9844         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9845         throw.
9846         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9847         * completer.c (complete_line_internal): Replace throw_exception
9848         with throw.
9849         * compile/compile-object-run.c (compile_object_run): Replace
9850         throw_exception with throw.
9851         * cli/cli-script.c (process_next_line): Replace throw_exception
9852         with throw.
9853         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9854         (btrace_enable, btrace_maint_update_pt_packets): Replace
9855         throw_exception with throw.
9856         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9857         throw_exception with throw.
9858         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9859         throw_exception with throw.
9860         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9861         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9862         * aarch64-tdep.c (aarch64_make_prologue_cache)
9863         (aarch64_make_stub_cache): Replace throw_exception with throw.
9864
9865 2019-04-08  Tom Tromey  <tom@tromey.com>
9866
9867         * common/common-exceptions.c (throw_exception): Rename from
9868         throw_exception_cxx.  Remove old copy.  Make argument const.
9869         (throw_it): Create and throw exception objects directly.
9870         * common/common-exceptions.h (throw_exception): Make argument
9871         const.
9872         (struct gdb_exception_error): Add constructor.
9873         (struct gdb_exception_quit): Add constructor.
9874
9875 2019-04-08  Tom Tromey  <tom@tromey.com>
9876
9877         * common/common-exceptions.h (exception_rethrow): Don't declare.
9878         (TRY_SJLJ): Update comment.
9879         (TRY, CATCH, END_CATCH): Remove.
9880         * common/common-exceptions.c (exception_rethrow): Remove.
9881
9882 2019-04-08  Tom Tromey  <tom@tromey.com>
9883
9884         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9885         Remove.
9886         (gdb_exception_error): Rename from
9887         gdb_exception_RETURN_MASK_ERROR.
9888         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9889         (gdb_quit_bad_alloc): Update.
9890         * aarch64-tdep.c: Update.
9891         * ada-lang.c: Update.
9892         * ada-typeprint.c: Update.
9893         * ada-valprint.c: Update.
9894         * amd64-tdep.c: Update.
9895         * arch-utils.c: Update.
9896         * break-catch-throw.c: Update.
9897         * breakpoint.c: Update.
9898         * btrace.c: Update.
9899         * c-varobj.c: Update.
9900         * cli/cli-cmds.c: Update.
9901         * cli/cli-interp.c: Update.
9902         * cli/cli-script.c: Update.
9903         * common/common-exceptions.c: Update.
9904         * common/new-op.c: Update.
9905         * common/selftest.c: Update.
9906         * compile/compile-c-symbols.c: Update.
9907         * compile/compile-cplus-symbols.c: Update.
9908         * compile/compile-object-load.c: Update.
9909         * compile/compile-object-run.c: Update.
9910         * completer.c: Update.
9911         * corelow.c: Update.
9912         * cp-abi.c: Update.
9913         * cp-support.c: Update.
9914         * cp-valprint.c: Update.
9915         * darwin-nat.c: Update.
9916         * disasm-selftests.c: Update.
9917         * dtrace-probe.c: Update.
9918         * dwarf-index-cache.c: Update.
9919         * dwarf-index-write.c: Update.
9920         * dwarf2-frame-tailcall.c: Update.
9921         * dwarf2-frame.c: Update.
9922         * dwarf2loc.c: Update.
9923         * dwarf2read.c: Update.
9924         * eval.c: Update.
9925         * event-loop.c: Update.
9926         * event-top.c: Update.
9927         * exec.c: Update.
9928         * f-valprint.c: Update.
9929         * fbsd-tdep.c: Update.
9930         * frame-unwind.c: Update.
9931         * frame.c: Update.
9932         * gdbtypes.c: Update.
9933         * gnu-v3-abi.c: Update.
9934         * guile/guile-internal.h: Update.
9935         * guile/scm-block.c: Update.
9936         * guile/scm-breakpoint.c: Update.
9937         * guile/scm-cmd.c: Update.
9938         * guile/scm-disasm.c: Update.
9939         * guile/scm-frame.c: Update.
9940         * guile/scm-lazy-string.c: Update.
9941         * guile/scm-math.c: Update.
9942         * guile/scm-param.c: Update.
9943         * guile/scm-ports.c: Update.
9944         * guile/scm-pretty-print.c: Update.
9945         * guile/scm-symbol.c: Update.
9946         * guile/scm-symtab.c: Update.
9947         * guile/scm-type.c: Update.
9948         * guile/scm-value.c: Update.
9949         * i386-linux-tdep.c: Update.
9950         * i386-tdep.c: Update.
9951         * inf-loop.c: Update.
9952         * infcall.c: Update.
9953         * infcmd.c: Update.
9954         * infrun.c: Update.
9955         * jit.c: Update.
9956         * language.c: Update.
9957         * linespec.c: Update.
9958         * linux-fork.c: Update.
9959         * linux-nat.c: Update.
9960         * linux-tdep.c: Update.
9961         * linux-thread-db.c: Update.
9962         * main.c: Update.
9963         * mi/mi-cmd-break.c: Update.
9964         * mi/mi-cmd-stack.c: Update.
9965         * mi/mi-interp.c: Update.
9966         * mi/mi-main.c: Update.
9967         * objc-lang.c: Update.
9968         * p-valprint.c: Update.
9969         * parse.c: Update.
9970         * ppc-linux-tdep.c: Update.
9971         * printcmd.c: Update.
9972         * python/py-arch.c: Update.
9973         * python/py-breakpoint.c: Update.
9974         * python/py-cmd.c: Update.
9975         * python/py-finishbreakpoint.c: Update.
9976         * python/py-frame.c: Update.
9977         * python/py-framefilter.c: Update.
9978         * python/py-gdb-readline.c: Update.
9979         * python/py-inferior.c: Update.
9980         * python/py-infthread.c: Update.
9981         * python/py-lazy-string.c: Update.
9982         * python/py-linetable.c: Update.
9983         * python/py-objfile.c: Update.
9984         * python/py-param.c: Update.
9985         * python/py-prettyprint.c: Update.
9986         * python/py-progspace.c: Update.
9987         * python/py-record-btrace.c: Update.
9988         * python/py-record.c: Update.
9989         * python/py-symbol.c: Update.
9990         * python/py-type.c: Update.
9991         * python/py-unwind.c: Update.
9992         * python/py-utils.c: Update.
9993         * python/py-value.c: Update.
9994         * python/python.c: Update.
9995         * record-btrace.c: Update.
9996         * record-full.c: Update.
9997         * remote-fileio.c: Update.
9998         * remote.c: Update.
9999         * riscv-tdep.c: Update.
10000         * rs6000-aix-tdep.c: Update.
10001         * rs6000-tdep.c: Update.
10002         * rust-exp.y: Update.
10003         * rust-lang.c: Update.
10004         * s390-tdep.c: Update.
10005         * selftest-arch.c: Update.
10006         * solib-dsbt.c: Update.
10007         * solib-frv.c: Update.
10008         * solib-spu.c: Update.
10009         * solib-svr4.c: Update.
10010         * solib.c: Update.
10011         * sparc64-linux-tdep.c: Update.
10012         * stack.c: Update.
10013         * symfile-mem.c: Update.
10014         * symmisc.c: Update.
10015         * target.c: Update.
10016         * thread.c: Update.
10017         * top.c: Update.
10018         * tracefile-tfile.c: Update.
10019         * tui/tui.c: Update.
10020         * typeprint.c: Update.
10021         * unittests/cli-utils-selftests.c: Update.
10022         * unittests/parse-connection-spec-selftests.c: Update.
10023         * valops.c: Update.
10024         * valprint.c: Update.
10025         * value.c: Update.
10026         * varobj.c: Update.
10027         * windows-nat.c: Update.
10028         * x86-linux-nat.c: Update.
10029         * xml-support.c: Update.
10030
10031 2019-04-08  Tom Tromey  <tom@tromey.com>
10032
10033         * xml-support.c: Use C++ exception handling.
10034         * x86-linux-nat.c: Use C++ exception handling.
10035         * windows-nat.c: Use C++ exception handling.
10036         * varobj.c: Use C++ exception handling.
10037         * value.c: Use C++ exception handling.
10038         * valprint.c: Use C++ exception handling.
10039         * valops.c: Use C++ exception handling.
10040         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10041         handling.
10042         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10043         * typeprint.c: Use C++ exception handling.
10044         * tui/tui.c: Use C++ exception handling.
10045         * tracefile-tfile.c: Use C++ exception handling.
10046         * top.c: Use C++ exception handling.
10047         * thread.c: Use C++ exception handling.
10048         * target.c: Use C++ exception handling.
10049         * symmisc.c: Use C++ exception handling.
10050         * symfile-mem.c: Use C++ exception handling.
10051         * stack.c: Use C++ exception handling.
10052         * sparc64-linux-tdep.c: Use C++ exception handling.
10053         * solib.c: Use C++ exception handling.
10054         * solib-svr4.c: Use C++ exception handling.
10055         * solib-spu.c: Use C++ exception handling.
10056         * solib-frv.c: Use C++ exception handling.
10057         * solib-dsbt.c: Use C++ exception handling.
10058         * selftest-arch.c: Use C++ exception handling.
10059         * s390-tdep.c: Use C++ exception handling.
10060         * rust-lang.c: Use C++ exception handling.
10061         * rust-exp.y: Use C++ exception handling.
10062         * rs6000-tdep.c: Use C++ exception handling.
10063         * rs6000-aix-tdep.c: Use C++ exception handling.
10064         * riscv-tdep.c: Use C++ exception handling.
10065         * remote.c: Use C++ exception handling.
10066         * remote-fileio.c: Use C++ exception handling.
10067         * record-full.c: Use C++ exception handling.
10068         * record-btrace.c: Use C++ exception handling.
10069         * python/python.c: Use C++ exception handling.
10070         * python/py-value.c: Use C++ exception handling.
10071         * python/py-utils.c: Use C++ exception handling.
10072         * python/py-unwind.c: Use C++ exception handling.
10073         * python/py-type.c: Use C++ exception handling.
10074         * python/py-symbol.c: Use C++ exception handling.
10075         * python/py-record.c: Use C++ exception handling.
10076         * python/py-record-btrace.c: Use C++ exception handling.
10077         * python/py-progspace.c: Use C++ exception handling.
10078         * python/py-prettyprint.c: Use C++ exception handling.
10079         * python/py-param.c: Use C++ exception handling.
10080         * python/py-objfile.c: Use C++ exception handling.
10081         * python/py-linetable.c: Use C++ exception handling.
10082         * python/py-lazy-string.c: Use C++ exception handling.
10083         * python/py-infthread.c: Use C++ exception handling.
10084         * python/py-inferior.c: Use C++ exception handling.
10085         * python/py-gdb-readline.c: Use C++ exception handling.
10086         * python/py-framefilter.c: Use C++ exception handling.
10087         * python/py-frame.c: Use C++ exception handling.
10088         * python/py-finishbreakpoint.c: Use C++ exception handling.
10089         * python/py-cmd.c: Use C++ exception handling.
10090         * python/py-breakpoint.c: Use C++ exception handling.
10091         * python/py-arch.c: Use C++ exception handling.
10092         * printcmd.c: Use C++ exception handling.
10093         * ppc-linux-tdep.c: Use C++ exception handling.
10094         * parse.c: Use C++ exception handling.
10095         * p-valprint.c: Use C++ exception handling.
10096         * objc-lang.c: Use C++ exception handling.
10097         * mi/mi-main.c: Use C++ exception handling.
10098         * mi/mi-interp.c: Use C++ exception handling.
10099         * mi/mi-cmd-stack.c: Use C++ exception handling.
10100         * mi/mi-cmd-break.c: Use C++ exception handling.
10101         * main.c: Use C++ exception handling.
10102         * linux-thread-db.c: Use C++ exception handling.
10103         * linux-tdep.c: Use C++ exception handling.
10104         * linux-nat.c: Use C++ exception handling.
10105         * linux-fork.c: Use C++ exception handling.
10106         * linespec.c: Use C++ exception handling.
10107         * language.c: Use C++ exception handling.
10108         * jit.c: Use C++ exception handling.
10109         * infrun.c: Use C++ exception handling.
10110         * infcmd.c: Use C++ exception handling.
10111         * infcall.c: Use C++ exception handling.
10112         * inf-loop.c: Use C++ exception handling.
10113         * i386-tdep.c: Use C++ exception handling.
10114         * i386-linux-tdep.c: Use C++ exception handling.
10115         * guile/scm-value.c: Use C++ exception handling.
10116         * guile/scm-type.c: Use C++ exception handling.
10117         * guile/scm-symtab.c: Use C++ exception handling.
10118         * guile/scm-symbol.c: Use C++ exception handling.
10119         * guile/scm-pretty-print.c: Use C++ exception handling.
10120         * guile/scm-ports.c: Use C++ exception handling.
10121         * guile/scm-param.c: Use C++ exception handling.
10122         * guile/scm-math.c: Use C++ exception handling.
10123         * guile/scm-lazy-string.c: Use C++ exception handling.
10124         * guile/scm-frame.c: Use C++ exception handling.
10125         * guile/scm-disasm.c: Use C++ exception handling.
10126         * guile/scm-cmd.c: Use C++ exception handling.
10127         * guile/scm-breakpoint.c: Use C++ exception handling.
10128         * guile/scm-block.c: Use C++ exception handling.
10129         * guile/guile-internal.h: Use C++ exception handling.
10130         * gnu-v3-abi.c: Use C++ exception handling.
10131         * gdbtypes.c: Use C++ exception handling.
10132         * frame.c: Use C++ exception handling.
10133         * frame-unwind.c: Use C++ exception handling.
10134         * fbsd-tdep.c: Use C++ exception handling.
10135         * f-valprint.c: Use C++ exception handling.
10136         * exec.c: Use C++ exception handling.
10137         * event-top.c: Use C++ exception handling.
10138         * event-loop.c: Use C++ exception handling.
10139         * eval.c: Use C++ exception handling.
10140         * dwarf2read.c: Use C++ exception handling.
10141         * dwarf2loc.c: Use C++ exception handling.
10142         * dwarf2-frame.c: Use C++ exception handling.
10143         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10144         * dwarf-index-write.c: Use C++ exception handling.
10145         * dwarf-index-cache.c: Use C++ exception handling.
10146         * dtrace-probe.c: Use C++ exception handling.
10147         * disasm-selftests.c: Use C++ exception handling.
10148         * darwin-nat.c: Use C++ exception handling.
10149         * cp-valprint.c: Use C++ exception handling.
10150         * cp-support.c: Use C++ exception handling.
10151         * cp-abi.c: Use C++ exception handling.
10152         * corelow.c: Use C++ exception handling.
10153         * completer.c: Use C++ exception handling.
10154         * compile/compile-object-run.c: Use C++ exception handling.
10155         * compile/compile-object-load.c: Use C++ exception handling.
10156         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10157         * compile/compile-c-symbols.c: Use C++ exception handling.
10158         * common/selftest.c: Use C++ exception handling.
10159         * common/new-op.c: Use C++ exception handling.
10160         * cli/cli-script.c: Use C++ exception handling.
10161         * cli/cli-interp.c: Use C++ exception handling.
10162         * cli/cli-cmds.c: Use C++ exception handling.
10163         * c-varobj.c: Use C++ exception handling.
10164         * btrace.c: Use C++ exception handling.
10165         * breakpoint.c: Use C++ exception handling.
10166         * break-catch-throw.c: Use C++ exception handling.
10167         * arch-utils.c: Use C++ exception handling.
10168         * amd64-tdep.c: Use C++ exception handling.
10169         * ada-valprint.c: Use C++ exception handling.
10170         * ada-typeprint.c: Use C++ exception handling.
10171         * ada-lang.c: Use C++ exception handling.
10172         * aarch64-tdep.c: Use C++ exception handling.
10173
10174 2019-04-08  Tom Tromey  <tom@tromey.com>
10175
10176         * xml-support.c (gdb_xml_parser::parse): Update.
10177         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10178         * value.c (show_convenience): Update.
10179         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10180         (test_parse_flags_qcs): Update.
10181         * thread.c (thr_try_catch_cmd): Update.
10182         * target.c (target_translate_tls_address): Update.
10183         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10184         (info_frame_command_core, frame_apply_command_count): Update.
10185         * rust-exp.y (rust_lex_exception_test): Update.
10186         * riscv-tdep.c (riscv_print_one_register_info): Update.
10187         * remote.c (remote_target::enable_btrace): Update.
10188         * record-btrace.c (record_btrace_enable_warn): Update.
10189         * python/py-utils.c (gdbpy_convert_exception): Update.
10190         * printcmd.c (do_one_display, print_variable_and_value): Update.
10191         * mi/mi-main.c (mi_print_exception): Update.
10192         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10193         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10194         * linux-nat.c (linux_nat_target::attach): Update.
10195         * linux-fork.c (class scoped_switch_fork_info): Update.
10196         * infrun.c (displaced_step_prepare): Update.
10197         * infcall.c (call_function_by_hand_dummy): Update.
10198         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10199         * gnu-v3-abi.c (print_one_vtable): Update.
10200         * frame.c (get_prev_frame_always): Update.
10201         * f-valprint.c (info_common_command_for_block): Update.
10202         * exec.c (try_open_exec_file): Update.
10203         * exceptions.c (print_exception, exception_print)
10204         (exception_fprintf, exception_print_same): Update.
10205         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10206         * dwarf-index-cache.c (index_cache::store)
10207         (index_cache::lookup_gdb_index): Update.
10208         * darwin-nat.c (maybe_cache_shell): Update.
10209         * cp-valprint.c (cp_print_value_fields): Update.
10210         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10211         (gcc_cplus_symbol_address): Update.
10212         * compile/compile-c-symbols.c (gcc_convert_symbol)
10213         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10214         * common/selftest.c: Update.
10215         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10216         a std::string.
10217         (exception_try_scope_entry, exception_try_scope_exit): Don't
10218         declare.
10219         (struct exception_try_scope): Remove.
10220         (TRY): Don't use exception_try_scope.
10221         (struct gdb_exception): Add constructor, operator=.
10222         <what>: New method.
10223         (struct gdb_exception_RETURN_MASK_ALL)
10224         (struct gdb_exception_RETURN_MASK_ERROR)
10225         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10226         (struct gdb_quit_bad_alloc): Update.
10227         * common/common-exceptions.c (exception_none): Change
10228         initializer.
10229         (struct catcher) <state, exception>: Initialize inline.
10230         <prev>: Remove member.
10231         (current_catcher): Remove.
10232         (catchers): New global.
10233         (exceptions_state_mc_init): Simplify.
10234         (catcher_pop): Remove.
10235         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10236         (try_scope_depth, exception_try_scope_entry)
10237         (exception_try_scope_exit): Remove.
10238         (throw_exception_sjlj): Update.
10239         (exception_messages, exception_messages_size): Remove.
10240         (throw_it): Simplify.
10241         (gdb_exception_sliced_copy): Remove.
10242         (throw_exception_cxx): Update.
10243         * cli/cli-script.c (script_from_file): Update.
10244         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10245         Update.
10246         * ada-valprint.c (ada_val_print): Update.
10247         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10248         (create_excep_cond_exprs): Update.
10249
10250 2019-04-08  Tom Tromey  <tom@tromey.com>
10251
10252         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10253         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10254         (TRY, CATCH, END_CATCH): Remove some definitions.
10255         * common/common-exceptions.c: Don't use GDB_XCPT.
10256         (catcher_list_size): Remove.
10257         (throw_exception, throw_it): Simplify.
10258
10259 2019-04-05  Tom Tromey  <tom@tromey.com>
10260
10261         Revert the header-sorting patch.
10262         * ft32-tdep.c: Revert.
10263         * frv-tdep.c: Revert.
10264         * frv-linux-tdep.c: Revert.
10265         * frame.c: Revert.
10266         * frame-unwind.c: Revert.
10267         * frame-base.c: Revert.
10268         * fork-child.c: Revert.
10269         * findvar.c: Revert.
10270         * findcmd.c: Revert.
10271         * filesystem.c: Revert.
10272         * filename-seen-cache.h: Revert.
10273         * filename-seen-cache.c: Revert.
10274         * fbsd-tdep.c: Revert.
10275         * fbsd-nat.h: Revert.
10276         * fbsd-nat.c: Revert.
10277         * f-valprint.c: Revert.
10278         * f-typeprint.c: Revert.
10279         * f-lang.c: Revert.
10280         * extension.h: Revert.
10281         * extension.c: Revert.
10282         * extension-priv.h: Revert.
10283         * expprint.c: Revert.
10284         * exec.h: Revert.
10285         * exec.c: Revert.
10286         * exceptions.c: Revert.
10287         * event-top.c: Revert.
10288         * event-loop.c: Revert.
10289         * eval.c: Revert.
10290         * elfread.c: Revert.
10291         * dwarf2read.h: Revert.
10292         * dwarf2read.c: Revert.
10293         * dwarf2loc.c: Revert.
10294         * dwarf2expr.h: Revert.
10295         * dwarf2expr.c: Revert.
10296         * dwarf2-frame.c: Revert.
10297         * dwarf2-frame-tailcall.c: Revert.
10298         * dwarf-index-write.h: Revert.
10299         * dwarf-index-write.c: Revert.
10300         * dwarf-index-common.c: Revert.
10301         * dwarf-index-cache.h: Revert.
10302         * dwarf-index-cache.c: Revert.
10303         * dummy-frame.c: Revert.
10304         * dtrace-probe.c: Revert.
10305         * disasm.h: Revert.
10306         * disasm.c: Revert.
10307         * disasm-selftests.c: Revert.
10308         * dictionary.c: Revert.
10309         * dicos-tdep.c: Revert.
10310         * demangle.c: Revert.
10311         * dcache.h: Revert.
10312         * dcache.c: Revert.
10313         * darwin-nat.h: Revert.
10314         * darwin-nat.c: Revert.
10315         * darwin-nat-info.c: Revert.
10316         * d-valprint.c: Revert.
10317         * d-namespace.c: Revert.
10318         * d-lang.c: Revert.
10319         * ctf.c: Revert.
10320         * csky-tdep.c: Revert.
10321         * csky-linux-tdep.c: Revert.
10322         * cris-tdep.c: Revert.
10323         * cris-linux-tdep.c: Revert.
10324         * cp-valprint.c: Revert.
10325         * cp-support.c: Revert.
10326         * cp-namespace.c: Revert.
10327         * cp-abi.c: Revert.
10328         * corelow.c: Revert.
10329         * corefile.c: Revert.
10330         * continuations.c: Revert.
10331         * completer.h: Revert.
10332         * completer.c: Revert.
10333         * complaints.c: Revert.
10334         * coffread.c: Revert.
10335         * coff-pe-read.c: Revert.
10336         * cli-out.h: Revert.
10337         * cli-out.c: Revert.
10338         * charset.c: Revert.
10339         * c-varobj.c: Revert.
10340         * c-valprint.c: Revert.
10341         * c-typeprint.c: Revert.
10342         * c-lang.c: Revert.
10343         * buildsym.c: Revert.
10344         * buildsym-legacy.c: Revert.
10345         * build-id.h: Revert.
10346         * build-id.c: Revert.
10347         * btrace.c: Revert.
10348         * bsd-uthread.c: Revert.
10349         * breakpoint.h: Revert.
10350         * breakpoint.c: Revert.
10351         * break-catch-throw.c: Revert.
10352         * break-catch-syscall.c: Revert.
10353         * break-catch-sig.c: Revert.
10354         * blockframe.c: Revert.
10355         * block.c: Revert.
10356         * bfin-tdep.c: Revert.
10357         * bfin-linux-tdep.c: Revert.
10358         * bfd-target.c: Revert.
10359         * bcache.c: Revert.
10360         * ax-general.c: Revert.
10361         * ax-gdb.h: Revert.
10362         * ax-gdb.c: Revert.
10363         * avr-tdep.c: Revert.
10364         * auxv.c: Revert.
10365         * auto-load.c: Revert.
10366         * arm-wince-tdep.c: Revert.
10367         * arm-tdep.c: Revert.
10368         * arm-symbian-tdep.c: Revert.
10369         * arm-pikeos-tdep.c: Revert.
10370         * arm-obsd-tdep.c: Revert.
10371         * arm-nbsd-tdep.c: Revert.
10372         * arm-nbsd-nat.c: Revert.
10373         * arm-linux-tdep.c: Revert.
10374         * arm-linux-nat.c: Revert.
10375         * arm-fbsd-tdep.c: Revert.
10376         * arm-fbsd-nat.c: Revert.
10377         * arm-bsd-tdep.c: Revert.
10378         * arch-utils.c: Revert.
10379         * arc-tdep.c: Revert.
10380         * arc-newlib-tdep.c: Revert.
10381         * annotate.h: Revert.
10382         * annotate.c: Revert.
10383         * amd64-windows-tdep.c: Revert.
10384         * amd64-windows-nat.c: Revert.
10385         * amd64-tdep.c: Revert.
10386         * amd64-sol2-tdep.c: Revert.
10387         * amd64-obsd-tdep.c: Revert.
10388         * amd64-obsd-nat.c: Revert.
10389         * amd64-nbsd-tdep.c: Revert.
10390         * amd64-nbsd-nat.c: Revert.
10391         * amd64-nat.c: Revert.
10392         * amd64-linux-tdep.c: Revert.
10393         * amd64-linux-nat.c: Revert.
10394         * amd64-fbsd-tdep.c: Revert.
10395         * amd64-fbsd-nat.c: Revert.
10396         * amd64-dicos-tdep.c: Revert.
10397         * amd64-darwin-tdep.c: Revert.
10398         * amd64-bsd-nat.c: Revert.
10399         * alpha-tdep.c: Revert.
10400         * alpha-obsd-tdep.c: Revert.
10401         * alpha-nbsd-tdep.c: Revert.
10402         * alpha-mdebug-tdep.c: Revert.
10403         * alpha-linux-tdep.c: Revert.
10404         * alpha-linux-nat.c: Revert.
10405         * alpha-bsd-tdep.c: Revert.
10406         * alpha-bsd-nat.c: Revert.
10407         * aix-thread.c: Revert.
10408         * agent.c: Revert.
10409         * addrmap.c: Revert.
10410         * ada-varobj.c: Revert.
10411         * ada-valprint.c: Revert.
10412         * ada-typeprint.c: Revert.
10413         * ada-tasks.c: Revert.
10414         * ada-lang.c: Revert.
10415         * aarch64-tdep.c: Revert.
10416         * aarch64-ravenscar-thread.c: Revert.
10417         * aarch64-newlib-tdep.c: Revert.
10418         * aarch64-linux-tdep.c: Revert.
10419         * aarch64-linux-nat.c: Revert.
10420         * aarch64-fbsd-tdep.c: Revert.
10421         * aarch64-fbsd-nat.c: Revert.
10422         * aarch32-linux-nat.c: Revert.
10423
10424 2019-04-05  Tom Tromey  <tom@tromey.com>
10425
10426         * ft32-tdep.c: Sort headers.
10427         * frv-tdep.c: Sort headers.
10428         * frv-linux-tdep.c: Sort headers.
10429         * frame.c: Sort headers.
10430         * frame-unwind.c: Sort headers.
10431         * frame-base.c: Sort headers.
10432         * fork-child.c: Sort headers.
10433         * findvar.c: Sort headers.
10434         * findcmd.c: Sort headers.
10435         * filesystem.c: Sort headers.
10436         * filename-seen-cache.h: Sort headers.
10437         * filename-seen-cache.c: Sort headers.
10438         * fbsd-tdep.c: Sort headers.
10439         * fbsd-nat.h: Sort headers.
10440         * fbsd-nat.c: Sort headers.
10441         * f-valprint.c: Sort headers.
10442         * f-typeprint.c: Sort headers.
10443         * f-lang.c: Sort headers.
10444         * extension.h: Sort headers.
10445         * extension.c: Sort headers.
10446         * extension-priv.h: Sort headers.
10447         * expprint.c: Sort headers.
10448         * exec.h: Sort headers.
10449         * exec.c: Sort headers.
10450         * exceptions.c: Sort headers.
10451         * event-top.c: Sort headers.
10452         * event-loop.c: Sort headers.
10453         * eval.c: Sort headers.
10454         * elfread.c: Sort headers.
10455         * dwarf2read.h: Sort headers.
10456         * dwarf2read.c: Sort headers.
10457         * dwarf2loc.c: Sort headers.
10458         * dwarf2expr.h: Sort headers.
10459         * dwarf2expr.c: Sort headers.
10460         * dwarf2-frame.c: Sort headers.
10461         * dwarf2-frame-tailcall.c: Sort headers.
10462         * dwarf-index-write.h: Sort headers.
10463         * dwarf-index-write.c: Sort headers.
10464         * dwarf-index-common.c: Sort headers.
10465         * dwarf-index-cache.h: Sort headers.
10466         * dwarf-index-cache.c: Sort headers.
10467         * dummy-frame.c: Sort headers.
10468         * dtrace-probe.c: Sort headers.
10469         * disasm.h: Sort headers.
10470         * disasm.c: Sort headers.
10471         * disasm-selftests.c: Sort headers.
10472         * dictionary.c: Sort headers.
10473         * dicos-tdep.c: Sort headers.
10474         * demangle.c: Sort headers.
10475         * dcache.h: Sort headers.
10476         * dcache.c: Sort headers.
10477         * darwin-nat.h: Sort headers.
10478         * darwin-nat.c: Sort headers.
10479         * darwin-nat-info.c: Sort headers.
10480         * d-valprint.c: Sort headers.
10481         * d-namespace.c: Sort headers.
10482         * d-lang.c: Sort headers.
10483         * ctf.c: Sort headers.
10484         * csky-tdep.c: Sort headers.
10485         * csky-linux-tdep.c: Sort headers.
10486         * cris-tdep.c: Sort headers.
10487         * cris-linux-tdep.c: Sort headers.
10488         * cp-valprint.c: Sort headers.
10489         * cp-support.c: Sort headers.
10490         * cp-namespace.c: Sort headers.
10491         * cp-abi.c: Sort headers.
10492         * corelow.c: Sort headers.
10493         * corefile.c: Sort headers.
10494         * continuations.c: Sort headers.
10495         * completer.h: Sort headers.
10496         * completer.c: Sort headers.
10497         * complaints.c: Sort headers.
10498         * coffread.c: Sort headers.
10499         * coff-pe-read.c: Sort headers.
10500         * cli-out.h: Sort headers.
10501         * cli-out.c: Sort headers.
10502         * charset.c: Sort headers.
10503         * c-varobj.c: Sort headers.
10504         * c-valprint.c: Sort headers.
10505         * c-typeprint.c: Sort headers.
10506         * c-lang.c: Sort headers.
10507         * buildsym.c: Sort headers.
10508         * buildsym-legacy.c: Sort headers.
10509         * build-id.h: Sort headers.
10510         * build-id.c: Sort headers.
10511         * btrace.c: Sort headers.
10512         * bsd-uthread.c: Sort headers.
10513         * breakpoint.h: Sort headers.
10514         * breakpoint.c: Sort headers.
10515         * break-catch-throw.c: Sort headers.
10516         * break-catch-syscall.c: Sort headers.
10517         * break-catch-sig.c: Sort headers.
10518         * blockframe.c: Sort headers.
10519         * block.c: Sort headers.
10520         * bfin-tdep.c: Sort headers.
10521         * bfin-linux-tdep.c: Sort headers.
10522         * bfd-target.c: Sort headers.
10523         * bcache.c: Sort headers.
10524         * ax-general.c: Sort headers.
10525         * ax-gdb.h: Sort headers.
10526         * ax-gdb.c: Sort headers.
10527         * avr-tdep.c: Sort headers.
10528         * auxv.c: Sort headers.
10529         * auto-load.c: Sort headers.
10530         * arm-wince-tdep.c: Sort headers.
10531         * arm-tdep.c: Sort headers.
10532         * arm-symbian-tdep.c: Sort headers.
10533         * arm-pikeos-tdep.c: Sort headers.
10534         * arm-obsd-tdep.c: Sort headers.
10535         * arm-nbsd-tdep.c: Sort headers.
10536         * arm-nbsd-nat.c: Sort headers.
10537         * arm-linux-tdep.c: Sort headers.
10538         * arm-linux-nat.c: Sort headers.
10539         * arm-fbsd-tdep.c: Sort headers.
10540         * arm-fbsd-nat.c: Sort headers.
10541         * arm-bsd-tdep.c: Sort headers.
10542         * arch-utils.c: Sort headers.
10543         * arc-tdep.c: Sort headers.
10544         * arc-newlib-tdep.c: Sort headers.
10545         * annotate.h: Sort headers.
10546         * annotate.c: Sort headers.
10547         * amd64-windows-tdep.c: Sort headers.
10548         * amd64-windows-nat.c: Sort headers.
10549         * amd64-tdep.c: Sort headers.
10550         * amd64-sol2-tdep.c: Sort headers.
10551         * amd64-obsd-tdep.c: Sort headers.
10552         * amd64-obsd-nat.c: Sort headers.
10553         * amd64-nbsd-tdep.c: Sort headers.
10554         * amd64-nbsd-nat.c: Sort headers.
10555         * amd64-nat.c: Sort headers.
10556         * amd64-linux-tdep.c: Sort headers.
10557         * amd64-linux-nat.c: Sort headers.
10558         * amd64-fbsd-tdep.c: Sort headers.
10559         * amd64-fbsd-nat.c: Sort headers.
10560         * amd64-dicos-tdep.c: Sort headers.
10561         * amd64-darwin-tdep.c: Sort headers.
10562         * amd64-bsd-nat.c: Sort headers.
10563         * alpha-tdep.c: Sort headers.
10564         * alpha-obsd-tdep.c: Sort headers.
10565         * alpha-nbsd-tdep.c: Sort headers.
10566         * alpha-mdebug-tdep.c: Sort headers.
10567         * alpha-linux-tdep.c: Sort headers.
10568         * alpha-linux-nat.c: Sort headers.
10569         * alpha-bsd-tdep.c: Sort headers.
10570         * alpha-bsd-nat.c: Sort headers.
10571         * aix-thread.c: Sort headers.
10572         * agent.c: Sort headers.
10573         * addrmap.c: Sort headers.
10574         * ada-varobj.c: Sort headers.
10575         * ada-valprint.c: Sort headers.
10576         * ada-typeprint.c: Sort headers.
10577         * ada-tasks.c: Sort headers.
10578         * ada-lang.c: Sort headers.
10579         * aarch64-tdep.c: Sort headers.
10580         * aarch64-ravenscar-thread.c: Sort headers.
10581         * aarch64-newlib-tdep.c: Sort headers.
10582         * aarch64-linux-tdep.c: Sort headers.
10583         * aarch64-linux-nat.c: Sort headers.
10584         * aarch64-fbsd-tdep.c: Sort headers.
10585         * aarch64-fbsd-nat.c: Sort headers.
10586         * aarch32-linux-nat.c: Sort headers.
10587
10588 2019-04-04  Tom Tromey  <tom@tromey.com>
10589
10590         * varobj.c (varobj_create): Update.
10591         * rust-exp.y (struct rust_parser) <update_innermost_block,
10592         lookup_symbol>: New methods.
10593         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10594         Rename.
10595         (rust_parser::rust_lookup_type)
10596         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10597         * printcmd.c (display_command, do_one_display): Update.
10598         * parser-defs.h (struct parser_state) <parser_state>: Add
10599         "tracker" parameter.
10600         (block_tracker): New member.
10601         (class innermost_block_tracker) <innermost_block_tracker>: Add
10602         "types" parameter.
10603         <reset>: Remove method.
10604         (innermost_block): Don't declare.
10605         (null_post_parser): Update.
10606         * parse.c (innermost_block): Remove global.
10607         (write_dollar_variable): Update.
10608         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10609         Remove "tracker_types" parameter.
10610         (parse_expression): Add "tracker" parameter.
10611         (parse_expression_for_completion): Update.
10612         (null_post_parser): Add "tracker" parameter.
10613         * p-exp.y: Update rules.
10614         * m2-exp.y: Update rules.
10615         * language.h (struct language_defn) <la_post_parser>: Add
10616         "tracker" parameter.
10617         * go-exp.y: Update rules.
10618         * f-exp.y: Update rules.
10619         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10620         parameter.
10621         * d-exp.y: Update rules.
10622         * c-exp.y: Update rules.
10623         * breakpoint.c (set_breakpoint_condition): Create an
10624         innermost_block_tracker.
10625         (watch_command_1): Likewise.
10626         * ada-lang.c (resolve): Add "tracker" parameter.
10627         (resolve_subexp): Likewise.
10628         * ada-exp.y (write_var_from_sym): Update.
10629
10630 2019-04-04  Tom Tromey  <tom@tromey.com>
10631
10632         * type-stack.h: New file.
10633         * type-stack.c: New file.
10634         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10635         type-stack.h.
10636         (insert_into_type_stack, insert_type, push_type, push_type_int)
10637         (insert_type_address_space, pop_type, pop_type_int)
10638         (pop_typelist, pop_type_stack, append_type_stack)
10639         (push_type_stack, get_type_stack, push_typelist)
10640         (follow_type_instance_flags, follow_types): Don't declare.
10641         * parse.c (type_stack): Remove global.
10642         (parse_exp_in_context): Update.
10643         (insert_into_type_stack, insert_type, push_type, push_type_int)
10644         (insert_type_address_space, pop_type, pop_type_int)
10645         (pop_typelist, pop_type_stack, append_type_stack)
10646         (push_type_stack, get_type_stack, push_typelist)
10647         (follow_type_instance_flags, follow_types): Remove (moved to
10648         type-stack.c).
10649         * f-exp.y (type_stack): New global.
10650         Update rules.
10651         (push_kind_type, f_parse): Update.
10652         * d-exp.y (type_stack): New global.
10653         Update rules.
10654         (d_parse): Update.
10655         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10656         Update rules.
10657         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10658         (HFILES_NO_SRCDIR): Add type-stack.h.
10659
10660 2019-04-04  Tom Tromey  <tom@tromey.com>
10661
10662         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10663         (rust_parser::convert_ast_to_expression, rust_parse)
10664         (rust_lex_test_completion, rust_lex_tests): Update.
10665         * parser-defs.h (struct expr_completion_state): New.
10666         (struct parser_state) <parser_state>: Add completion parameter.
10667         <mark_struct_expression, mark_completion_tag>: New methods.
10668         <parse_completion, m_completion_state>: New members.
10669         (prefixify_expression, null_post_parser): Update.
10670         (mark_struct_expression, mark_completion_tag): Don't declare.
10671         * parse.c (parse_completion, expout_last_struct)
10672         (expout_tag_completion_type, expout_completion_name): Remove
10673         globals.
10674         (parser_state::mark_struct_expression)
10675         (parser_state::mark_completion_tag): Now methods.
10676         (prefixify_expression): Add last_struct parameter.
10677         (prefixify_subexp): Likewise.
10678         (parse_exp_1): Update.
10679         (parse_exp_in_context): Add cstate parameter.  Update.
10680         (parse_expression_for_completion): Create an
10681         expr_completion_state.
10682         (null_post_parser): Add "completion" parameter.
10683         * p-exp.y: Update rules.
10684         (yylex): Update.
10685         * language.h (struct language_defn) <la_post_parser>: Add
10686         "completing" parameter.
10687         * go-exp.y: Update rules.
10688         (lex_one_token): Update.
10689         * expression.h (parse_completion): Don't declare.
10690         * d-exp.y: Update rules.
10691         (lex_one_token): Update rules.
10692         * c-exp.y: Update rules.
10693         (lex_one_token): Update.
10694         * ada-lang.c (resolve): Add "parse_completion" parameter.
10695         (resolve_subexp): Likewise.
10696         (ada_resolve_function): Likewise.
10697
10698 2019-04-04  Tom Tromey  <tom@tromey.com>
10699
10700         * parser-defs.h (struct parser_state) <start_arglist,
10701         end_arglist>: New methods.
10702         <arglist_len, m_funcall_chain>: New members.
10703         (arglist_len, start_arglist, end_arglist): Don't declare.
10704         * parse.c (arglist_len, funcall_chain): Remove global.
10705         (start_arglist, end_arglist): Remove functions.
10706         (parse_exp_in_context): Update.
10707         * p-exp.y: Update rules.
10708         * m2-exp.y: Update rules.
10709         * go-exp.y: Update rules.
10710         * f-exp.y: Update rules.
10711         * d-exp.y: Update rules.
10712         * c-exp.y: Update rules.
10713
10714 2019-04-04  Tom Tromey  <tom@tromey.com>
10715
10716         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10717         lex_operator, push_back>: New methods.
10718         Update all rules.
10719         (rust_parser::lex_hex, lex_escape): Rename and update.
10720         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10721         (rust_parser::lex_operator): Rename and update.
10722         (rust_parser::lex_number, rustyylex, rustyyerror)
10723         (rust_lex_test_init, rust_lex_test_sequence)
10724         (rust_lex_test_push_back, rust_lex_tests): Update.
10725         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10726         parameter.
10727         <lexptr, prev_lexptr>: New members.
10728         (lexptr, prev_lexptr): Don't declare.
10729         * parse.c (lexptr, prev_lexptr): Remove globals.
10730         (parse_exp_in_context): Update.
10731         * p-exp.y (yylex, yyerror): Update.
10732         * m2-exp.y (parse_number, yylex, yyerror): Update.
10733         * go-exp.y (lex_one_token, yyerror): Update.
10734         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10735         * d-exp.y (lex_one_token, yyerror): Update.
10736         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10737         (lex_one_token, yyerror): Update.
10738         * ada-lex.l (YY_INPUT): Update.
10739         (rewind_to_char): Update.
10740         * ada-exp.y (yyerror): Update.
10741
10742 2019-04-04  Tom Tromey  <tom@tromey.com>
10743
10744         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10745         * parser-defs.h (struct parser_state) <parser_state>: Add new
10746         parameter.
10747         <comma_terminates>: New member.
10748         (comma_terminates): Don't declare global.
10749         * parse.c (comma_terminates): Remove global.
10750         (parse_exp_in_context): Update.
10751         * p-exp.y (yylex): Update.
10752         * m2-exp.y (yylex): Update.
10753         * go-exp.y (lex_one_token): Update.
10754         * f-exp.y (yylex): Update.
10755         * d-exp.y (lex_one_token): Update.
10756         * c-exp.y (lex_one_token): Update.
10757         * ada-lex.l: Update.
10758
10759 2019-04-04  Tom Tromey  <tom@tromey.com>
10760
10761         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10762         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10763         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10764         * parser-defs.h (paren_depth): Don't declare.
10765         * parse.c (paren_depth): Remove global.
10766         (parse_exp_in_context): Update.
10767         * p-exp.y (paren_depth): New global.
10768         (pascal_parse): Initialize it.
10769         * m2-exp.y (paren_depth): New global.
10770         (m2_parse): Initialize it.
10771         * go-exp.y (paren_depth): New global.
10772         (go_parse): Initialize it.
10773         * f-exp.y (paren_depth): New global.
10774         (f_parse): Initialize it.
10775         * d-exp.y (paren_depth): New global.
10776         (d_parse): Initialize it.
10777         * c-exp.y (paren_depth): New global.
10778         (c_parse): Initialize it.
10779         * ada-lex.l (paren_depth): New global.
10780         (lexer_init): Initialize it.
10781
10782 2019-04-04  Tom Tromey  <tom@tromey.com>
10783
10784         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10785         (rust_parser::convert_ast_to_type)
10786         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10787         * parser-defs.h (struct parser_state) <parser_state>: Add
10788         parameters.  Initialize new members.
10789         <expression_context_block, expression_context_pc>: New members.
10790         * parse.c (expression_context_block, expression_context_pc):
10791         Remove globals.
10792         (parse_exp_in_context): Update.
10793         * p-exp.y: Update all rules.
10794         (yylex): Update.
10795         * m2-exp.y: Update all rules.
10796         (yylex): Update.
10797         * go-exp.y (yylex): Update.
10798         * f-exp.y (yylex): Update.
10799         * d-exp.y: Update all rules.
10800         (yylex): Update.
10801         * c-exp.y: Update all rules.
10802         (lex_one_token, classify_name, yylex, c_parse): Update.
10803         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10804
10805 2019-04-04  Tom Tromey  <tom@tromey.com>
10806
10807         * gdbarch.h, gdbarch.c: Rebuild.
10808         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10809         * stap-probe.h:
10810         (struct stap_parse_info): Replace "parser_state" with
10811         "expr_builder".
10812         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10813         (parser_state): New class.
10814         * parse.c (expr_builder): Rename.
10815         (expr_builder::release): Rename.
10816         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10817         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10818         (write_exp_elt_longcst, write_exp_elt_floatcst)
10819         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10820         (write_exp_string_vector, write_exp_bitstring)
10821         (write_exp_msymbol, mark_struct_expression)
10822         (write_dollar_variable)
10823         (insert_type_address_space, increase_expout_size): Replace
10824         "parser_state" with "expr_builder".
10825         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10826         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10827         "parser_state" with "expr_builder".
10828
10829 2019-04-04  Tom Tromey  <tom@tromey.com>
10830
10831         * rust-exp.y: Replace "parse_language" with method call.
10832         * p-exp.y:
10833         (yylex): Replace "parse_language" with method call.
10834         * m2-exp.y:
10835         (yylex): Replace "parse_language" with method call.
10836         * go-exp.y (classify_name): Replace "parse_language" with method
10837         call.
10838         * f-exp.y (yylex): Replace "parse_language" with method call.
10839         * d-exp.y (lex_one_token): Replace "parse_language" with method
10840         call.
10841         * c-exp.y:
10842         (lex_one_token, classify_name, yylex): Replace "parse_language"
10843         with method call.
10844         * ada-exp.y (find_primitive_type, type_char)
10845         (type_system_address): Replace "parse_language" with method call.
10846
10847 2019-04-04  Tom Tromey  <tom@tromey.com>
10848
10849         * rust-exp.y: Replace "parse_gdbarch" with method call.
10850         * parse.c (write_dollar_variable, insert_type_address_space):
10851         Replace "parse_gdbarch" with method call.
10852         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10853         call.
10854         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10855         call.
10856         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10857         "parse_gdbarch" with method call.
10858         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10859         with method call.
10860         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10861         "parse_gdbarch" with method call.
10862         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10863         "parse_gdbarch" with method call.
10864         * c-exp.y (parse_type, parse_number, classify_name): Replace
10865         "parse_gdbarch" with method call.
10866         * ada-lex.l: Replace "parse_gdbarch" with method call.
10867         * ada-exp.y (parse_type, find_primitive_type, type_char)
10868         (type_system_address): Replace "parse_gdbarch" with method call.
10869
10870 2019-04-04  Tom Tromey  <tom@tromey.com>
10871
10872         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10873         * stap-probe.c (stap_parse_argument): Update.
10874         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10875         initial_size parameter.
10876         * rust-exp.y (rust_lex_tests): Update.
10877         * parse.c (parser_state): Update.
10878         (parse_exp_in_context): Update.
10879         * parser-defs.h (struct parser_state) <parser_state>: Remove
10880         "initial_size" parameter.
10881
10882 2019-04-04  Tom Tromey  <tom@tromey.com>
10883
10884         * parser-defs.h (increase_expout_size): Don't declare.
10885         * parse.c (increase_expout_size): Now static.
10886
10887 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10888
10889         * gnu-nat.c (gnu_nat_target::wait): Fix
10890         target_waitstatus_to_string call.
10891
10892 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10893
10894         * eval.c (evaluate_subexp_standard): Handle internal functions
10895         during Fortran function call handling.
10896
10897 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10898
10899         * NEWS: Mention new internal functions.
10900         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10901         (read_base_type): Use dwarf2_init_complex_target_type.
10902         * value.c (creal_internal_fn): New function.
10903         (cimag_internal_fn): New function.
10904         (_initialize_values): Register new internal functions.
10905
10906 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10907
10908         * infrun.c (stop_all_threads): If debug_infrun, always
10909         trace the wait status after wait_one, using
10910         target_waitstatus_to_string and target_pid_to_str.
10911         (handle_inferior_event): Replace various trace of
10912         wait status kind by a single trace.
10913         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10914         wait status kind image by target_waitstatus_to_string.
10915         * target/waitstatus.c (target_waitstatus_to_string): Fix
10916         obsolete comment.
10917
10918 2019-04-01  Tom Tromey  <tromey@adacore.com>
10919
10920         PR symtab/23331:
10921         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10922
10923 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10924             Pedro Alves  <palves@redhat.com>
10925
10926         * top.c (quit_force): Call 'finalize_values'.
10927         * value.c (finalize_values): New function.
10928         * value.h (finalize_values): Declare.
10929
10930 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10931
10932         * NEWS: Announce $_gdb_major and $_gdb_minor.
10933
10934         * top.c (init_gdb_version_vars): New function.
10935         (gdb_init): Call init_gdb_version_vars.
10936
10937 2019-03-29  Tom Tromey  <tromey@adacore.com>
10938
10939         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10940         help text.  Remove dead code.
10941
10942 2019-03-29  Keith Seitz  <keiths@redhat.com>
10943
10944         From Siddhesh Poyarekar:
10945         * f-lang.h (f77_get_upperbound): Return LONGEST.
10946         (f77_get_lowerbound): Likewise.
10947         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10948         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10949         print them.
10950         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10951         plongest to format print it.
10952         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10953         (f77_get_upperbound): Likewise.
10954         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10955         LOWER_BOUND to LONGEST.
10956         (f77_create_arrayprint_offset_tbl): Likewise.
10957
10958 2019-03-29  Keith Seitz  <keiths@redhat.com>
10959
10960         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10961         %s/pulongest for TYPE_LENGTH instead of %d in format
10962         strings.
10963         * ada-typerint.c (ada_print_type): Likewise.
10964         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10965         * compile/compile-c-support.c (generate_register_struct): Likewise.
10966         * gdbtypes.c (recursive_dump_type): Likewise.
10967         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10968         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10969         instead of %d in format strings.
10970         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10971         to std::min to ULONGEST.
10972         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10973         instead of %d in format strings.
10974         * tracepoint.c (info_scope_command): Likewise.
10975         * typeprint.c (print_offset_data::update)
10976         (print_offset_data::finish): Likewise.
10977         * xtensa-tdep.c (xtensa_store_return_value)
10978         (xtensa_push_dummy_call): Likewise.
10979
10980 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10981
10982         * windows-nat.c (display_selector): Fixed format specifications
10983         for 64-bit Cygwin.
10984
10985 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10986
10987         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10988
10989 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10990
10991         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10992         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10993         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10994         (nios2_linux_init_abi): Install it.
10995
10996 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10997
10998         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10999
11000 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11001
11002         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11003
11004 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11005             Tom Tromey  <tromey@adacore.com>
11006
11007         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11008
11009 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11010
11011         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11012         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11013         method to compute the bounds of range types. Also print "[evaluated]"
11014         if the bounds' values come from a dynamic evaluation.
11015
11016 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11017
11018         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11019         whitespace when pretty printing is on.
11020
11021 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11022
11023         * ppc-linux-nat.c: Add include.
11024
11025 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11026
11027         * NEWS: Mention AArch64 Pointer Authentication.
11028
11029 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11030
11031         * arm-linux-nat.c: Add include.
11032
11033 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11034
11035         * source-cache.c (source_cache::get_source_lines): Re-read
11036         fullname after calling open_source_file.
11037
11038 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11039
11040         * NEWS: Mention TLS support for FreeBSD.
11041
11042 2019-03-25  Tom Tromey  <tromey@adacore.com>
11043
11044         * minsyms.c (BUNCH_SIZE): Update comment.
11045         (~minimal_symbol_reader): Remove old comment.
11046         (compact_minimal_symbols): Update comment.
11047         (minimal_symbol_reader::install): Remove old comment.  Update
11048         other comments.
11049
11050 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11051
11052         * s390-linux-nat.c: Add include.
11053
11054 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11055
11056         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11057         Call linux_get_hwcap.
11058         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11059         Likewise.
11060         (aarch64_linux_get_hwcap): Remove function.
11061         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11062         declaration.
11063         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11064         linux_get_hwcap.
11065         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11066         * linux-tdep.c (linux_get_hwcap): Add function.
11067         (linux_get_hwcap2): Likewise.
11068         * linux-tdep.h (linux_get_hwcap): Add declaration.
11069         (linux_get_hwcap2): Likewise.
11070         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11071         (ppc_linux_get_hwcap2): Likewise.
11072         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11073         linux_get_hwcap.
11074         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11075         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11076         (ppc_linux_nat_target::read_description): Likewise.
11077         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11078         * s390-linux-nat.c: Likewise.
11079         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11080
11081 2019-03-24  Tom Tromey  <tom@tromey.com>
11082
11083         * ada-lang.c (standard_lookup): Simplify initialization.
11084         (ada_lookup_symbol_nonlocal): Simplify return.
11085         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11086         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11087         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11088         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11089         initialization.
11090         * solib.c (solib_global_lookup): Simplify.
11091         * symtab.c (null_block_symbol): Remove.
11092         (symbol_cache_lookup): Simplify returns.
11093         (lookup_language_this): Simplify returns.
11094         (lookup_symbol_aux): Simplify return.
11095         (lookup_local_symbol): Simplify returns.
11096         (lookup_global_symbol_from_objfile): Simplify return.
11097         (lookup_symbol_in_objfile_symtabs)
11098         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11099         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11100         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11101         * cp-namespace.c (cp_lookup_bare_symbol)
11102         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11103         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11104         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11105         (cp_lookup_symbol_via_imports): Simplify initialization.
11106         (find_symbol_in_baseclass): Likewise.
11107         * symtab.h (null_block_symbol): Remove.
11108         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11109         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11110         (d_lookup_symbol_module): Likewise.
11111         (find_symbol_in_baseclass): Simplify initialization.
11112
11113 2019-03-24  Tom Tromey  <tom@tromey.com>
11114
11115         * expression.h: Don't include symtab.h.
11116         (struct block): Forward declare.
11117
11118 2019-03-24  Tom Tromey  <tom@tromey.com>
11119
11120         * c-exp.y (typebase): Remove casts.
11121         * gdbtypes.c (lookup_unsigned_typename, )
11122         (lookup_signed_typename): Remove cast.
11123         * eval.c (parse_to_comma_and_eval): Remove cast.
11124         * parse.c (write_dollar_variable): Remove cast.
11125         * block.h (struct block) <superblock>: Now const.
11126         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11127         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11128         (map_block): Make "block" const.
11129         * symfile.h (struct quick_symbol_functions)
11130         <map_matching_symbols>: Constify block argument to "callback".
11131         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11132         const.
11133         (find_pc_sect_compunit_symtab): Make "b" const.
11134         (find_symbol_at_address): Likewise.
11135         (search_symbols): Likewise.
11136         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11137         (dw2_debug_names_lookup_symbol): Likewise.
11138         (dw2_map_matching_symbols): Update.
11139         * p-valprint.c (pascal_val_print): Remove "block".
11140         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11141         (aux_add_nonlocal_symbols): Make "block" const.
11142         (resolve_subexp): Remove cast.
11143         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11144         const.
11145         (iterate_over_file_blocks): Likewise.
11146         * f-exp.y (%union) <bval>: Remove.
11147         * coffread.c (patch_opaque_types): Make "b" const.
11148         * spu-tdep.c (spu_catch_start): Make "block" const.
11149         * c-valprint.c (print_unpacked_pointer): Remove "block".
11150         * symmisc.c (dump_symtab_1): Make "b" const.
11151         (block_depth): Make "block" const.
11152         * d-exp.y (%union) <bval>: Remove.
11153         * cp-support.h (cp_lookup_rtti_type): Update.
11154         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11155         * psymtab.c (psym_lookup_symbol): Make "block" const.
11156         (maintenance_check_psymtabs): Make "b" const.
11157         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11158         (enumerate_locals, enumerate_args): Update.
11159         * python/py-symtab.c (stpy_global_block): Make "block" const.
11160         (stpy_static_block): Likewise.
11161         * inline-frame.c (block_starting_point_at): Make "new_block"
11162         const.
11163         * block.c (find_block_in_blockvector): Make return type const.
11164         (blockvector_for_pc_sect): Make "b" const.
11165         (find_block_in_blockvector): Make "b" const.
11166
11167 2019-03-23  Tom Tromey  <tom@tromey.com>
11168
11169         * varobj.c (varobj_create): Update.
11170         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11171         * printcmd.c (display_command, do_one_display): Don't reset
11172         innermost_block.
11173         * parser-defs.h (enum innermost_block_tracker_type): Move to
11174         expression.h.
11175         (innermost_block): Update comment.
11176         * parse.c (parse_exp_1): Add tracker_types parameter.
11177         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11178         tracker_types parameter.  Reset innermost_block.
11179         (parse_exp_in_context): Remove.
11180         (parse_expression_for_completion): Update.
11181         * objfiles.c (~objfile): Don't reset expression_context_block or
11182         innermost_block.
11183         * expression.h (enum innermost_block_tracker_type): Move from
11184         parser-defs.h.
11185         (parse_exp_1): Add tracker_types parameter.
11186         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11187         reset innermost_block.
11188
11189 2019-03-23  Tom Tromey  <tom@tromey.com>
11190
11191         * objfiles.h: Include bcache.h.
11192
11193 2019-03-23  Tom Tromey  <tom@tromey.com>
11194
11195         * linespec.c (get_current_search_block): Use
11196         scoped_restore_current_language.
11197         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11198
11199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11200             Jiong Wang  <jiong.wang@arm.com>
11201
11202         * aarch64-linux-tdep.c
11203         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11204         section.
11205         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11206
11207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11208             Jiong Wang  <jiong.wang@arm.com>
11209
11210         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11211         instructions.
11212         (aarch64_analyze_prologue_test): Add PACIASP test.
11213         (aarch64_prologue_prev_register): Unmask PC value.
11214
11215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11216             Jiong Wang  <jiong.wang@arm.com>
11217
11218         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11219         (aarch64_dwarf2_prev_register): Unmask PC value.
11220         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11221         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11222         DW_CFA_AARCH64_negate_ra_state.
11223         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11224
11225 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11226             Jiong Wang  <jiong.wang@arm.com>
11227
11228         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11229         registers.
11230         (aarch64_pseudo_register_name): Likewise.
11231         (aarch64_pseudo_register_type): Likewise.
11232         (aarch64_pseudo_register_reggroup_p): Likewise.
11233         (aarch64_gdbarch_init): Add pauth registers.
11234         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11235         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11236         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11237         (struct gdbarch_tdep): Add regnum for ra_state.
11238
11239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11240             Jiong Wang  <jiong.wang@arm.com>
11241
11242         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11243
11244 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11245             Jiong Wang  <jiong.wang@arm.com>
11246
11247         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11248         function.
11249         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11250         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11251         (aarch64_gdbarch_init): Add puth registers.
11252         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11253         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11254         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11255
11256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11257             Jiong Wang  <jiong.wang@arm.com>
11258
11259         * aarch64-linux-nat.c
11260         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11261         * aarch64-linux-tdep.c
11262         (aarch64_linux_core_read_description): Likewise.
11263         (aarch64_linux_get_hwcap): New function.
11264         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11265         (aarch64_linux_get_hwcap): New declaration.
11266
11267 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11268             Jiong Wang  <jiong.wang@arm.com>
11269
11270         * aarch64-linux-nat.c
11271         (aarch64_linux_nat_target::read_description): Add pauth param.
11272         * aarch64-linux-tdep.c
11273         (aarch64_linux_core_read_description): Likewise.
11274         * aarch64-tdep.c (struct target_desc): Add in pauth.
11275         (aarch64_read_description): Add pauth param.
11276         (aarch64_gdbarch_init): Likewise.
11277         * aarch64-tdep.h (aarch64_read_description): Likewise.
11278         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11279         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11280         * features/Makefile: Add new files.
11281         * features/aarch64-pauth.c: New file.
11282         * features/aarch64-pauth.xml: New file.
11283
11284 2019-03-20  Tom Tromey  <tromey@adacore.com>
11285
11286         * infrun.c (handle_inferior_event): Rename from
11287         handle_inferior_event_1.  Create a scoped_value_mark.
11288         (handle_inferior_event): Remove.
11289
11290 2019-03-19  Tom Tromey  <tromey@adacore.com>
11291
11292         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11293         * infrun.h (print_stop_event): Add "displays" parameter.
11294         * infrun.c (print_stop_event): Add "displays" parameter.
11295
11296 2019-03-19  Pedro Alves  <palves@redhat.com>
11297
11298         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11299         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11300         to -1.  Fix TABs vs spaces.
11301         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11302         * tui/tui-out.h (tui_ui_out) Add intro comments.
11303         <m_line, m_start_of_line>: In-class initialize, and add describing
11304         comment.
11305
11306 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11307
11308         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11309         variable names.
11310         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11311
11312 2019-03-18  Pedro Alves  <palves@redhat.com>
11313             Eli Zaretskii <eliz@gnu.org>
11314
11315         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11316         m_line and m_start_of_line.
11317
11318 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11319
11320         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11321         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11322         it returns a newline.  This fixes a regression in TU mode, whereby
11323         the next line is output on the same screen line as the user input.
11324
11325 2019-03-18  Tom Tromey  <tromey@adacore.com>
11326
11327         * minsyms.c (minimal_symbol_reader::install): Remove call to
11328         obstack_blank.
11329
11330 2019-03-18  Pedro Alves  <palves@redhat.com>
11331
11332         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11333         New globals.
11334         (apply_style): New, factored out from ...
11335         (apply_ansi_escape): ... this.  Handle reverse video mode.
11336         (tui_set_reverse_mode): New function.
11337         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11338         * tui/tui-winsource.c (tui_show_source_line): Use
11339         tui_set_reverse_mode instead of setting A_STANDOUT.
11340         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11341         New setter methods.
11342
11343 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11344
11345         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11346         Handle tabs.
11347
11348 2019-03-18  Tom Tromey  <tromey@adacore.com>
11349
11350         * ada-lang.c (empty_array): Add "high" parameter.
11351         (ada_evaluate_subexp): Update.
11352
11353 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11354
11355         * unittests/string_view-selftests.c: Define
11356         _initialize_string_view_selftests unconditionally.
11357
11358 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11359
11360         PR gdb/24350
11361         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11362
11363 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11364
11365         PR gdb/24351
11366         * windows-nat.c (display_selector): Fix format specifiers.
11367
11368 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11369
11370         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11371         tui_refill_source_window instead of tui_refresh_win, to update the
11372         current execution line.  This fixes redisplay of the current line
11373         when stepping through the code with "next" or "step".
11374
11375 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11376
11377         * source-cache.c (source_cache::get_source_lines): Call
11378         find_source_lines to initialize s->nlines.  This fixes vertical
11379         scrolling of TUI source window when the DOWN arrow is pressed.
11380
11381 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11382
11383         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11384         linux-thread-db.c (_initialize_thread_db): Likewise.
11385
11386 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11387
11388         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11389         wclrtoeol in tui_show_source_line".  This reverts changes made in
11390         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11391
11392 2019-03-15  Tom Tromey  <tom@tromey.com>
11393
11394         * symtab.h (struct minimal_symbol): Derive from
11395         general_symbol_info.
11396         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11397         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11398         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11399         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11400         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11401         (MSYMBOL_SEARCH_NAME): Update.
11402         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11403         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11404         * minsyms.c (minimal_symbol_reader::record_full): Update.
11405
11406 2019-03-15  Tom Tromey  <tom@tromey.com>
11407
11408         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11409
11410 2019-03-15  Tom Tromey  <tom@tromey.com>
11411
11412         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11413         unique_xmalloc_ptr.
11414         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11415         Update.
11416         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11417         (build_minimal_symbol_hash_tables)
11418         (minimal_symbol_reader::install): Update.
11419
11420 2019-03-15  Tom Tromey  <tom@tromey.com>
11421
11422         * symtab.c (create_demangled_names_hash): Update.
11423         (symbol_set_names): Update.
11424         * objfiles.h (struct objfile_per_bfd_storage)
11425         <demangled_names_hash>: Now an htab_up.
11426         * objfiles.c (objfile_per_bfd_storage): Simplify.
11427
11428 2019-03-15  Tom Tromey  <tom@tromey.com>
11429
11430         * objfiles.h (struct objfile_per_bfd_storage): Declare
11431         destructor.
11432         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11433         New.
11434         (get_objfile_bfd_data): Use new.  Don't initialize
11435         language_of_main.
11436         (free_objfile_per_bfd_storage): Remove.
11437         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11438
11439 2019-03-15  Tom Tromey  <tom@tromey.com>
11440
11441         * symfile.c (reread_symbols): Update.
11442         * objfiles.c (objfile::objfile): Update.
11443         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11444         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11445         comment.
11446         (minimal_symbol_reader::install): Update.
11447         (terminate_minimal_symbol_table): Remove.
11448         * jit.c (jit_object_close_impl): Update.
11449
11450 2019-03-15  Tom Tromey  <tom@tromey.com>
11451
11452         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11453         initializations.
11454
11455 2019-03-15  Tom Tromey  <tom@tromey.com>
11456
11457         * objfiles.h (struct objfile_per_bfd_storage)
11458         <demangled_hash_languages>: Now a bitset.
11459         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11460         (lookup_minimal_symbol): Update.
11461
11462 2019-03-15  Tom Tromey  <tom@tromey.com>
11463
11464         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11465         Don't return the symbol.
11466         * coffread.c (record_minimal_symbol): Use record_full.
11467
11468 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11469
11470         The MS-Windows port of ncurses fails to switch to a color pair if
11471         one or both of the colors are the implicit default colors.  This
11472         change records the default colors when TUI is initialized, and
11473         then specifies them explicitly when a color pair uses the default
11474         colors.  This allows color styling in TUI mode on MS-Windows.
11475
11476         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11477         ncurses_norm_attr.
11478         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11479         colors in ncurses_norm_attr.
11480         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11481         "none", replace it with the default color recorded in
11482         ncurses_norm_attr.
11483
11484 2019-03-14  Tom Tromey  <tromey@adacore.com>
11485
11486         * source-cache.h (class source_cache) <get_source_lines>: Return
11487         std::string.
11488         * source-cache.c (source_cache::extract_lines): Handle case where
11489         first_pos==npos.  Return std::string.
11490         (source_cache::get_source_lines): Update.
11491
11492 2019-03-14  Tom Tromey  <tromey@adacore.com>
11493
11494         * NEWS: Add item for "style sources" commands.
11495         * source-cache.c (source_cache::get_source_lines): Check
11496         source_styling.
11497         * cli/cli-style.c (source_styling): New global.
11498         (_initialize_cli_style): Add "style sources" commands.
11499         (show_style_sources): New function.
11500         * cli/cli-style.h (source_styling): Declare.
11501
11502 2019-03-14  Pedro Alves  <palves@redhat.com>
11503             Tom Tromey  <tromey@adacore.com>
11504
11505         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11506         * tui/tui-winsource.c (tui_refill_source_window): New function,
11507         from...
11508         (tui_horizontal_source_scroll): ... here.  Move some logic.
11509         * cli/cli-style.c (set_style_enabled): Notify new observable.
11510         * tui/tui-hooks.c (tui_redisplay_source): New function.
11511         (tui_attach_detach_observers): Attach or detach
11512         tui_redisplay_source.
11513         * observable.h (source_styling_changed): New observable.
11514         * observable.c: Define source_styling_changed observable.
11515
11516 2019-03-13  Tom Tromey  <tromey@adacore.com>
11517
11518         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11519         (i386_gnu_nat_target::store_registers): Update.
11520         * target-debug.h (target_debug_print_std_string): New macro.
11521         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11522         * windows-tdep.c (display_one_tib): Update.
11523         * tui/tui-stack.c (tui_make_status_line): Update.
11524         * top.c (print_inferior_quit_action): Update.
11525         * thread.c (thr_try_catch_cmd): Update.
11526         (add_thread_with_info): Update.
11527         (thread_target_id_str): Update.
11528         (thr_try_catch_cmd): Update.
11529         (thread_command): Update.
11530         (thread_find_command): Update.
11531         * record-btrace.c (record_btrace_target::info_record)
11532         (record_btrace_resume_thread, record_btrace_target::resume)
11533         (record_btrace_cancel_resume, record_btrace_step_thread)
11534         (record_btrace_target::wait, record_btrace_target::wait)
11535         (record_btrace_target::wait, record_btrace_target::stop): Update.
11536         * progspace.c (print_program_space): Update.
11537         * process-stratum-target.c
11538         (process_stratum_target::thread_address_space): Update.
11539         * linux-fork.c (linux_fork_mourn_inferior)
11540         (detach_checkpoint_command, info_checkpoints_command)
11541         (linux_fork_context): Update.
11542         (linux_fork_detach): Update.
11543         (class scoped_switch_fork_info): Update.
11544         (delete_checkpoint_command): Update.
11545         * infrun.c (follow_fork_inferior): Update.
11546         (follow_fork_inferior): Update.
11547         (proceed_after_vfork_done): Update.
11548         (handle_vfork_child_exec_or_exit): Update.
11549         (follow_exec): Update.
11550         (displaced_step_prepare_throw): Update.
11551         (displaced_step_restore): Update.
11552         (start_step_over): Update.
11553         (resume_1): Update.
11554         (clear_proceed_status_thread): Update.
11555         (proceed): Update.
11556         (print_target_wait_results): Update.
11557         (do_target_wait): Update.
11558         (context_switch): Update.
11559         (stop_all_threads): Update.
11560         (restart_threads): Update.
11561         (finish_step_over): Update.
11562         (handle_signal_stop): Update.
11563         (switch_back_to_stepped_thread): Update.
11564         (keep_going_pass_signal): Update.
11565         (print_exited_reason): Update.
11566         (normal_stop): Update.
11567         * inferior.c (inferior_pid_to_str): Change return type.
11568         (print_selected_inferior): Update.
11569         (add_inferior): Update.
11570         (detach_inferior): Update.
11571         * dummy-frame.c (fprint_dummy_frames): Update.
11572         * dcache.c (dcache_info_1): Update.
11573         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11574         (btrace_fetch, btrace_clear): Update.
11575         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11576         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11577         type.
11578         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11579         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11580         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11581         * gdbarch.c, gdbarch.h: Rebuild.
11582         * gdbarch.sh (core_pid_to_str): Change return type.
11583         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11584         return type.
11585         (windows_nat_target::pid_to_str): Change return type.
11586         (windows_delete_thread): Update.
11587         (windows_nat_target::attach): Update.
11588         (windows_nat_target::files_info): Update.
11589         * target-delegates.c: Rebuild.
11590         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11591         return type.
11592         (sol_thread_target::pid_to_str): Change return type.
11593         * remote.c (class remote_target) <pid_to_str>: Change return
11594         type.
11595         (remote_target::pid_to_str): Change return type.
11596         (extended_remote_target::attach, remote_target::remote_stop_ns)
11597         (remote_target::remote_notif_remove_queued_reply)
11598         (remote_target::push_stop_reply, remote_target::disable_btrace):
11599         Update.
11600         (extended_remote_target::attach): Update.
11601         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11602         type.
11603         (gdbsim_target::pid_to_str): Change return type.
11604         * ravenscar-thread.c (struct ravenscar_thread_target)
11605         <pid_to_str>: Change return type.
11606         (ravenscar_thread_target::pid_to_str): Change return type.
11607         * procfs.c (class procfs_target) <pid_to_str>: Change return
11608         type.
11609         (procfs_target::pid_to_str): Change return type.
11610         (procfs_target::attach): Update.
11611         (procfs_target::detach): Update.
11612         (procfs_target::fetch_registers): Update.
11613         (procfs_target::store_registers): Update.
11614         (procfs_target::wait): Update.
11615         (procfs_target::files_info): Update.
11616         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11617         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11618         return type.
11619         (nto_procfs_target::pid_to_str): Change return type.
11620         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11621         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11622         return type.
11623         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11624         (exit_lwp): Update.
11625         (attach_proc_task_lwp_callback, get_detach_signal)
11626         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11627         (linux_nat_target::resume, wait_lwp, stop_callback)
11628         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11629         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11630         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11631         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11632         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11633         type.
11634         (inf_ptrace_target::attach): Update.
11635         (inf_ptrace_target::files_info): Update.
11636         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11637         type.
11638         (go32_nat_target::pid_to_str): Change return type.
11639         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11640         (gnu_nat_target::wait): Update.
11641         (gnu_nat_target::wait): Update.
11642         (gnu_nat_target::resume): Update.
11643         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11644         (fbsd_nat_target::wait): Update.
11645         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11646         type.
11647         (darwin_nat_target::attach): Update.
11648         * corelow.c (class core_target) <pid_to_str>: Change return type.
11649         (core_target::pid_to_str): Change return type.
11650         * target.c (normal_pid_to_str): Change return type.
11651         (default_pid_to_str): Likewise.
11652         (target_pid_to_str): Change return type.
11653         (target_translate_tls_address): Update.
11654         (target_announce_detach): Update.
11655         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11656         return type.
11657         (bsd_uthread_target::pid_to_str): Change return type.
11658         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11659         type.
11660         (bsd_kvm_target::pid_to_str): Change return type.
11661         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11662         return type.
11663         (aix_thread_target::pid_to_str): Change return type.
11664         * target.h (struct target_ops) <pid_to_str>: Change return type.
11665         (target_pid_to_str, normal_pid_to_str): Likewise.
11666         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11667         type.
11668         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11669         type.
11670         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11671         return type.
11672         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11673         type.
11674         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11675         type.
11676         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11677         return type.
11678
11679 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11680
11681         * NEWS: Mention that the new default MI version is 3.  Mention
11682         changes to the output of commands and events that deal with
11683         multi-location breakpoints.
11684         * breakpoint.c: Include "mi/mi-out.h".
11685         (print_one_breakpoint): Change output syntax if using MI version
11686         >= 3.
11687         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11688         New.
11689         (mi_multi_location_breakpoint_output_fixed): New.
11690         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11691         (mi_cmd_fix_multi_location_breakpoint_output): New.
11692         (mi_multi_location_breakpoint_output_fixed): New.
11693         * mi/mi-cmds.c (mi_cmds): Register command
11694         -fix-multi-location-breakpoint-output.
11695         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11696         interpreter "mi".
11697
11698 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11699
11700         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11701         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11702         instantiate mi_ui_out based on interpreter name.
11703         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11704         * mi/mi-main.c (mi_load_progress): Likewise.
11705
11706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11707
11708         * NEWS: Combine separate "New targets" sections for 8.3.
11709
11710 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11711
11712         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11713         (ppcfbsd_init_abi): Install gdbarch
11714         "fetch_tls_load_module_address" and "get_thread_local_address"
11715         methods.
11716
11717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11718
11719         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11720         (riscv_fbsd_init_abi): Install gdbarch
11721         "fetch_tls_load_module_address" and "get_thread_local_address"
11722         methods.
11723
11724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11725
11726         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11727         (i386fbsd_init_abi): Install gdbarch
11728         "fetch_tls_load_module_address" and "get_thread_local_address"
11729         methods.
11730
11731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11732
11733         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11734         (amd64fbsd_init_abi): Install gdbarch
11735         "fetch_tls_load_module_address" and "get_thread_local_address"
11736         methods.
11737
11738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11739
11740         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11741         (struct fbsd_pspace_data): New type.
11742         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11743         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11744         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11745         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11746         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11747
11748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11749
11750         * gdbtypes.c (lookup_struct_elt): New function.
11751         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11752         * gdbtypes.h (struct struct_elt): New type.
11753         (lookup_struct_elt): New prototype.
11754
11755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11756
11757         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11758         remove disabled code block.
11759
11760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11761
11762         * gdbarch.sh (get_thread_local_address): New method.
11763         * gdbarch.h, gdbarch.c: Regenerate.
11764         * target.c (target_translate_tls_address): Use
11765         gdbarch_get_thread_local_address if present instead of
11766         target::get_thread_local_address.
11767
11768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11769
11770         * target.h (target::get_thread_local_address): Update comment.
11771
11772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11773
11774         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11775         objfile->separate_debug_objfile_backlink if not NULL.
11776
11777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11778
11779         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11780         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11781         (amd64bsd_store_inferior_registers): Likewise.
11782         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11783         Enable segment base registers.
11784         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11785         PT_GETFSBASE and PT_GETGSBASE.
11786         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11787         PT_SETGSBASE.
11788         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11789         segment base registers.
11790         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11791
11792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11793
11794         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11795         Update calls to i386_target_description to add 'segments'
11796         parameter.
11797         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11798         add segment base registers.
11799         * arch/i386.c (i386_create_target_description): Add 'segments'
11800         parameter to enable segment base registers.
11801         * arch/i386.h (i386_create_target_description): Likewise.
11802         * features/i386/32bit-segments.xml: New file.
11803         * features/i386/32bit-segments.c: Generate.
11804         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11805         call to i386_target_description to add 'segments' parameter.
11806         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11807         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11808         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11809         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11810         if feature is present.
11811         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11812         Add 'segments' parameter to call to i386_target_description.
11813         (i386_target_description): Add 'segments' parameter to enable
11814         segment base registers.
11815         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11816         to call to i386_target_description.
11817         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11818         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11819         Define I386_NUM_REGS.
11820         (i386_target_description): Add 'segments' parameter to enable
11821         segment base registers.
11822
11823 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11824
11825         PR/24325
11826         * source-cache.c: #undef open and close, to avoid unresolved
11827         externals during linking.
11828
11829 2019-03-12  Tom Tromey  <tromey@adacore.com>
11830
11831         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11832         const.  Add initializers.
11833         (_initialize_remote): Don't initialize ptid globals.
11834
11835 2019-03-12  Pedro Alves  <palves@redhat.com>
11836
11837         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11838
11839 2019-03-12  Pedro Alves  <palves@redhat.com>
11840
11841         * cp-name-parser.y (main): Remove unused 'len' variable.
11842
11843 2019-03-12  Tom Tromey  <tromey@adacore.com>
11844
11845         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11846         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11847
11848 2019-03-12  Tom Tromey  <tromey@adacore.com>
11849
11850         * linux-nat.c (iterate_over_lwps): Update.
11851         (stop_callback): Remove parameter.
11852         (stop_wait_callback, detach_callback, resume_set_callback)
11853         (select_singlestep_lwp_callback, set_ignore_sigint)
11854         (status_callback, resumed_callback, resume_clear_callback)
11855         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11856         data parameter.
11857         (linux_nat_target::detach, linux_nat_target::resume)
11858         (linux_stop_and_wait_all_lwps, select_event_lwp)
11859         (linux_nat_filter_event, linux_nat_wait_1)
11860         (linux_nat_target::kill, linux_nat_target::stop)
11861         (linux_nat_target::stop): Update.
11862         (linux_nat_resume_callback): Change type.
11863         (resume_stopped_resumed_lwps, count_events_callback)
11864         (select_event_lwp_callback): Likewise.
11865         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11866         * arm-linux-nat.c (struct update_registers_data): Remove.
11867         (update_registers_callback): Change type.
11868         (arm_linux_insert_hw_breakpoint1): Update.
11869         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11870         parameter.
11871         (x86_linux_dr_set_addr): Update.
11872         (x86_linux_dr_set_control): Update.
11873         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11874         (iterate_over_lwps): Use gdb::function_view.
11875         * nat/aarch64-linux-hw-point.c (struct
11876         aarch64_dr_update_callback_param): Remove.
11877         (debug_reg_change_callback): Change type.
11878         (aarch64_notify_debug_reg_change): Update.
11879         * s390-linux-nat.c (s390_refresh_per_info): Update.
11880
11881 2019-03-11  Tom Tromey  <tromey@adacore.com>
11882
11883         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11884         redundant assignment to "this_cu".
11885
11886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11887
11888         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11889
11890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11891
11892         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11893         from...
11894         (rank_one_type): ... this.
11895
11896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11897
11898         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11899         from...
11900         (rank_one_type): ... this.
11901
11902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11903
11904         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11905         from...
11906         (rank_one_type): ... this.
11907
11908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11909
11910         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11911         from...
11912         (rank_one_type): ... this.
11913
11914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11915
11916         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11917         from...
11918         (rank_one_type): ... this.
11919
11920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11921
11922         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11923         from...
11924         (rank_one_type): ... this.
11925
11926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11927
11928         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11929         from...
11930         (rank_one_type): ... this.
11931
11932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11933
11934         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11935         from...
11936         (rank_one_type): ... this.
11937
11938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11939
11940         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11941         from...
11942         (rank_one_type): ... this.
11943
11944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11945
11946         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11947         from...
11948         (rank_one_type): ... this.
11949
11950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11951
11952         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11953         from...
11954         (rank_one_type): ... this.
11955
11956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11957
11958         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11959         from...
11960         (rank_one_type): ... this.
11961
11962 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11963
11964         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11965         inferior-events' shows the example events.
11966
11967 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11968
11969         Support styling on native MS-Windows console
11970
11971         PR/24315
11972         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11973         on MS-Windows if $TERM is not defined.
11974
11975         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11976
11977         * posix-hdep.c (gdb_console_fputs):
11978         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11979         functions.
11980         * ui-file.h (gdb_console_fputs): Add prototype.
11981
11982         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11983         back to fputs only if the former returns zero.
11984
11985 2019-03-07  Tom Tromey  <tom@tromey.com>
11986
11987         * symmisc.c (print_symbol_bcache_statistics): Update.
11988         (print_objfile_statistics): Update.
11989         * symfile.c (allocate_symtab): Update.
11990         * stabsread.c: Don't include bcache.h.
11991         * psymtab.h (struct psymbol_bcache): Don't declare.
11992         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11993         (psymbol_bcache_init, psymbol_bcache_free)
11994         (psymbol_bcache_get_bcache): Don't declare.
11995         * psymtab.c (struct psymbol_bcache): Remove.
11996         (psymtab_storage::psymtab_storage): Update.
11997         (psymtab_storage::~psymtab_storage): Update.
11998         (psymbol_bcache_init, psymbol_bcache_free)
11999         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12000         (add_psymbol_to_bcache): Update.
12001         (allocate_psymtab): Update.
12002         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12003         macro_cache>: No longer pointers.
12004         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12005         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12006         * macrotab.c (macro_bcache): Update.
12007         * macroexp.c: Don't include bcache.h.
12008         * gdbtypes.c (check_types_worklist): Update.
12009         (types_deeply_equal): Remove TRY/CATCH.  Update.
12010         * elfread.c (elf_symtab_read): Update.
12011         * dwarf2read.c: Don't include bcache.h.
12012         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12013         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12014         (print_bcache_statistics, bcache_memory_used): Don't declare.
12015         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12016         methods.  Rename all data members.
12017         * bcache.c (struct bcache): Move to bcache.h.
12018         (bcache::expand_hash_table): Rename from expand_hash_table.
12019         (bcache): Remove.
12020         (bcache::insert): Rename from bcache_full.
12021         (bcache::compare): Rename from bcache_compare.
12022         (bcache_xmalloc): Remove.
12023         (bcache::~bcache): Rename from bcache_xfree.
12024         (bcache::print_statistics): Rename from print_bcache_statistics.
12025         (bcache::memory_used): Rename from bcache_memory_used.
12026
12027 2019-03-07  Pedro Alves  <palves@redhat.com>
12028
12029         * infrun.c (normal_stop): Also check for
12030         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12031
12032 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12033
12034         * f-lang.c (value_from_host_double): Moved to...
12035         * value.c (value_from_host_double): ...here.
12036         * value.h (value_from_host_double): Declare.
12037         * guile/scm-math.c (vlscm_convert_typed_number): Use
12038         value_from_host_double.
12039         (vlscm_convert_number): Likewise.
12040         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12041         * python/py-value.c (convert_value_from_python): Likewise.
12042
12043 2019-03-06  Tom Tromey  <tom@tromey.com>
12044
12045         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12046
12047 2019-03-06  Tom Tromey  <tom@tromey.com>
12048
12049         * utils.h (free_current_contents): Don't declare.
12050         * utils.c (free_current_contents): Remove.
12051
12052 2019-03-06  Tom Tromey  <tom@tromey.com>
12053
12054         * top.c (quit_force): Update.
12055         * main.c (captured_command_loop): Update.
12056         * common/new-op.c (operator new): Update.
12057         * common/common-exceptions.c (struct catcher)
12058         <save_cleanup_chain>: Remove member.
12059         (exceptions_state_mc_init): Update.
12060         (exception_try_scope_entry): Return nullptr.
12061         (exception_try_scope_exit, exception_rethrow)
12062         (throw_exception_sjlj, throw_exception_cxx): Update.
12063         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12064         (all_cleanups, do_cleanups, discard_cleanups)
12065         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12066         (restore_cleanups, restore_final_cleanups): Don't declare.
12067         (do_final_cleanups): Remove parameter.
12068         * common/cleanups.c (cleanup_chain, make_cleanup)
12069         (make_cleanup_dtor, all_cleanups, do_cleanups)
12070         (discard_my_cleanups, discard_cleanups)
12071         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12072         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12073         (null_cleanup): Remove.
12074         (do_final_cleanups): Remove parameter.
12075
12076 2019-03-06  Tom Tromey  <tom@tromey.com>
12077
12078         * remote.c (remote_target::remote_parse_stop_reply): Use
12079         unique_xmalloc_ptr.
12080
12081 2019-03-06  Tom Tromey  <tom@tromey.com>
12082
12083         * stabsread.c (struct stabs_field_info): Rename from field_info.
12084         <list, fnlist>: Add initializers.
12085         <obstack>: New member.
12086         (read_member_functions, read_struct_fields, read_baseclasses):
12087         Allocate on obstack.  Don't use cleanups.
12088         (read_one_struct_field, read_member_functions, read_struct_fields)
12089         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12090         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12091         (read_struct_type): Update.
12092
12093 2019-03-06  Tom Tromey  <tom@tromey.com>
12094
12095         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12096         * common/filestuff.h (make_cleanup_close): Don't declare.
12097         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12098         Remove.
12099
12100 2019-03-06  Tom Tromey  <tom@tromey.com>
12101
12102         * solib-aix.c: Use make_scope_exit.
12103
12104 2019-03-06  Tom Tromey  <tom@tromey.com>
12105
12106         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12107         Use make_scope_exit.
12108
12109 2019-03-06  Tom Tromey  <tom@tromey.com>
12110
12111         * solib-svr4.c (disable_probes_interface): Remove parameter.
12112         (svr4_handle_solib_event): Use make_scope_exit.
12113
12114 2019-03-06  Tom Tromey  <tom@tromey.com>
12115
12116         * remote.c (struct stop_reply_deleter): Remove.
12117         (stop_reply_up): Update.
12118         (struct stop_reply): Derive from notif_event.  Don't typedef.
12119         <regcache>: Now a std::vector.
12120         (stop_reply_xfree): Remove.
12121         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12122         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12123         (remote_target::discard_pending_stop_replies): Use delete.
12124         (remote_target::remote_parse_stop_reply): Update.
12125         (remote_target::process_stop_reply): Update.
12126         * remote-notif.h (struct notif_event): Add virtual destructor.
12127         Remove "dtr" member.
12128         (struct notif_client) <alloc_event>: Return a unique_ptr.
12129         (notif_event_xfree): Don't declare.
12130         (notif_event_up): New typedef.
12131         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12132         (notif_event_xfree, do_notif_event_xfree): Remove.
12133         (remote_notif_state_xfree): Update.
12134
12135 2019-03-06  Tom Tromey  <tom@tromey.com>
12136
12137         * infrun.c (displaced_step_clear_cleanup): Now a
12138         forward_scope_exit type.
12139         (displaced_step_prepare_throw): Update.
12140         (displaced_step_fixup): Update.
12141
12142 2019-03-06  Tom Tromey  <tom@tromey.com>
12143
12144         * inferior.h (class inferior): Update comment.
12145         * gdbthread.h (class thread_info): Update comment.
12146
12147 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12148             Tom Tromey  <tom@tromey.com>
12149
12150         * stabsread.h (struct stab_section_list): Remove.
12151         (coffstab_build_psymtabs): Update.
12152         * dbxread.c (symbuf_sections): Now a std::vector.
12153         (sect_idx): New global.
12154         (fill_symbuf): Update.
12155         (coffstab_build_psymtabs): Change type of stabsects parameter.
12156         Update.
12157         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12158         std::vector.
12159         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12160         (coff_locate_sections): Update.
12161         (coff_symfile_read): Remove cleanups.  Update.
12162         (init_stringtab): Add storage parameter.
12163         (free_stringtab, free_stringtab_cleanup): Remove.
12164         (init_lineno): Add storage parameter.
12165         (free_linetab, free_linetab_cleanup): Remove.
12166
12167 2019-03-06  Pedro Alves  <palves@redhat.com>
12168
12169         * linux-fork.c (fork_info::clobber_regs): Delete.
12170         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12171         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12172         comment.  Adjust.
12173         (scoped_switch_fork_info::scoped_switch_fork_info)
12174         (checkpoint_command, linux_fork_context): Adjust
12175         fork_save_infrun_state calls.
12176
12177 2019-03-06  Pedro Alves  <palves@redhat.com>
12178
12179         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12180         (inf_has_multiple_threads): Return 'bool' and rewrite using
12181         inferior_info::threads().
12182
12183 2019-03-06  Pedro Alves  <palves@redhat.com>
12184
12185         * linux-fork.c: Include <list>.
12186         (fork_list): Now a std::list instance.
12187         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12188         (forks_exist_p, find_last_fork): Adjust.
12189         (new_fork): Delete.
12190         (one_fork_p): New.
12191         (add_fork): Adjust.
12192         (free_fork): Delete, folded into fork_info::~fork_info().
12193         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12194         Adjust.
12195         (init_fork_list): Delete.
12196         (linux_fork_killall, linux_fork_mourn_inferior)
12197         (linux_fork_detach, info_checkpoints_command): Adjust.
12198         (_initialize_linux_fork): No longer call init_fork_list.
12199
12200 2019-03-06  Pedro Alves  <palves@redhat.com>
12201
12202         * linux-fork.c (new_fork): New, split out of ...
12203         (add_fork): ... this.  Return void.  Move "first fork" special
12204         case from here, to ...
12205         (checkpoint_command): ... here.
12206         * linux-linux.h (add_fork): Return void.
12207
12208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12209
12210         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12211
12212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12213             Chris January  <chris.january@arm.com>
12214             David Lecomber  <david.lecomber@arm.com>
12215
12216         * f-exp.y: New token, UNOP_INTRINSIC.
12217         (exp): New pattern using UNOP_INTRINSIC token.
12218         (f77_keywords): Add 'abs' keyword.
12219         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12220         (value_from_host_double): New function.
12221         (evaluate_subexp_f): Support UNOP_ABS.
12222
12223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12224
12225         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12226         types.
12227
12228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12229
12230         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12231         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12232         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12233
12234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12235
12236         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12237
12238 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12239             Chris January  <chris.january@arm.com>
12240
12241         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12242         * f-exp.y: Define 'KIND' token.
12243         (exp): New pattern for KIND expressions.
12244         (ptype): Handle types with a kind extension.
12245         (direct_abs_decl): Extend to spot kind extensions.
12246         (f77_keywords): Add 'kind' to the list.
12247         (push_kind_type): New function.
12248         (convert_to_kind_type): New function.
12249         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12250         * parse.c (operator_length_standard): Likewise.
12251         * parser-defs.h (enum type_pieces): Add tp_kind.
12252         * std-operator.def: Add UNOP_KIND.
12253
12254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12255
12256         * f-exp.y (f_parse): Set yydebug.
12257
12258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12259
12260         * f-lang.c (evaluate_subexp_f): New function.
12261         (exp_descriptor_f): New global.
12262         (f_language_defn): Use exp_descriptor_f instead of
12263         exp_descriptor_standard.
12264
12265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12266
12267         * f-exp.y (struct token): Add comments.
12268         (dot_ops): Remove uppercase versions and the end marker.
12269         (f77_keywords): Likewise.
12270         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12271         entries in the dot_ops array are case insensitive, and use
12272         strncasecmp to compare strings.  Also some whitespace cleanup in
12273         this area.  Similar for the f77_keywords array, except entries in
12274         this list might be case sensitive.
12275
12276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12277
12278         * f-exp.y (struct f77_boolean_val): Add comments.
12279         (boolean_values): Remove uppercase versions, and end marker.
12280         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12281         and use strncasecmp to achieve case insensitivity.  Additionally,
12282         perform whitespace cleanup around this code.
12283
12284 2019-03-06  Tom Tromey  <tromey@adacore.com>
12285
12286         * remote-sim.c (gdbsim_target_open): Use result of
12287         gdb_argv::release.
12288
12289 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12290         Dirk Schubert  <dirk.schubert@arm.com>
12291         Chris January  <chris.january@arm.com>
12292
12293         * eval.c (evaluate_subexp_standard): Call Fortran argument
12294         wrapping logic.
12295         * f-lang.c (struct value): A value which can be passed into a
12296         Fortran function call.
12297         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12298         where appropriate.
12299         (struct type): Value ready for a Fortran function call.
12300         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12301         is needed.
12302         * f-lang.h (fortran_argument_convert): Declaration.
12303         (fortran_preserve_arg_pointer): Declaration.
12304         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12305
12306 2019-03-05  Tom Tromey  <tromey@adacore.com>
12307
12308         * python/py-prettyprint.c (print_string_repr): Remove #if.
12309         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12310
12311 2019-03-05  Tom Tromey  <tromey@adacore.com>
12312
12313         * target.c (the_dummy_target): Move later.  Change type to
12314         "dummy_target".
12315         (initialize_targets): Don't initialize the_dummy_target.
12316
12317 2019-03-05  Tom Tromey  <tromey@adacore.com>
12318
12319         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12320         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12321
12322 2019-03-05  Tom Tromey  <tromey@adacore.com>
12323
12324         * windows-nat.c (windows_nat_target::attach)
12325         (windows_nat_target::detach): Don't call gdb_flush.
12326         * valprint.c (generic_val_print, val_print, val_print_string):
12327         Don't call gdb_flush.
12328         * utils.c (defaulted_query): Don't call gdb_flush.
12329         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12330         * target.c (target_announce_detach): Don't call gdb_flush.
12331         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12332         * remote.c (extended_remote_target::attach): Don't call
12333         gdb_flush.
12334         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12335         * printcmd.c (do_examine): Don't call gdb_flush.
12336         (info_display_command): Don't call gdb_flush.
12337         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12338         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12339         * memattr.c (info_mem_command): Don't call gdb_flush.
12340         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12341         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12342         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12343         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12344         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12345         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12346         (gnu_nat_target::detach): Don't call gdb_flush.
12347         * f-valprint.c (f_val_print): Don't call gdb_flush.
12348         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12349         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12350         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12351         gdb_flush.
12352         * c-valprint.c (c_val_print): Don't call gdb_flush.
12353         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12354
12355 2019-03-05  Tom Tromey  <tromey@adacore.com>
12356
12357         * varobj.c (update_dynamic_varobj_children): Update.
12358         (install_default_visualizer): Use reset, not release.
12359         * value.c (set_internalvar): Update.
12360         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12361         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12362         ATTRIBUTE_UNUSED_RESULT.
12363
12364 2019-03-05  Tom Tromey  <tromey@adacore.com>
12365
12366         * remote.c (class scoped_remote_fd) <release>: Add
12367         ATTRIBUTE_UNUSED_RESULT.
12368
12369 2019-03-05  Tom Tromey  <tromey@adacore.com>
12370
12371         * macroexp.c (struct macro_buffer) <release>: Add
12372         ATTRIBUTE_UNUSED_RESULT.
12373
12374 2019-03-05  Tom Tromey  <tromey@adacore.com>
12375
12376         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12377         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12378         ATTRIBUTE_UNUSED_RESULT.
12379
12380 2019-03-05  Tom Tromey  <tromey@adacore.com>
12381
12382         * common/scoped_fd.h (class scoped_fd) <release>: Add
12383         ATTRIBUTE_UNUSED_RESULT.
12384
12385 2019-03-05  Tom Tromey  <tromey@adacore.com>
12386
12387         * parser-defs.h (struct parser_state) <release>: Add
12388         ATTRIBUTE_UNUSED_RESULT.
12389
12390 2019-03-05  Tom Tromey  <tromey@adacore.com>
12391
12392         * utils.h (class gdb_argv) <release>: Add
12393         ATTRIBUTE_UNUSED_RESULT.
12394         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12395
12396 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12397
12398         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12399         for-loop range, to avoid compiler warnings.
12400
12401         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12402         avoid compiler warnings about unused variables.
12403
12404         * NEWS: Mention end of support for native debugging on MS-Windows
12405         before XP.
12406
12407         PR gdb/24292
12408         * common/netstuff.c:
12409         * gdbserver/gdbreplay.c
12410         * gdbserver/remote-utils.c:
12411         * ser-tcp.c:
12412         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12413         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12414         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12415         'getaddrinfo' and 'freeaddrinfo' were not available before
12416         Windows XP, and mingw.org's MinGW headers by default define
12417         _WIN32_WINNT to 0x500.
12418
12419 2019-03-01  Gary Benson <gbenson@redhat.com>
12420
12421         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12422
12423 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12424             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12425
12426         PR gdb/8527
12427         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12428         set_sigint_trap, clear_sigint_trap.
12429
12430 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12431
12432         * target.c (target_detach): Clear the regcache and the
12433         frame cache.
12434
12435 2019-02-27  Pedro Alves  <palves@redhat.com>
12436
12437         * utils.c (set_screen_size): When we cap the height/width sizes,
12438         tweak the corresponding command variable to show "unlimited":
12439
12440 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12441             Pedro Alves  <palves@redhat.com>
12442
12443         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12444         before calling rl_set_screen_size.
12445
12446 2019-02-27  Tom Tromey  <tromey@adacore.com>
12447
12448         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12449         define.
12450         * python/py-value.c: Remove Python 2.4 workaround.
12451         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12452         workaround.
12453         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12454         Python 2.4 workaround.
12455         * python/python-internal.h: Remove Python 2.4 comment.
12456         (Py_ssize_t): Don't define.
12457         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12458         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12459         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12460         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12461         * python/python.c (do_start_initialization): Remove Python 2.4
12462         workaround.
12463         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12464         (print_children): Remove Python 2.4 workaround.
12465         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12466         workaround.
12467         (CHARBUFFERPROC_NAME): Remove.
12468         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12469         Python 2.4 workaround.
12470
12471 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12472
12473         * NEWS: Note minimum Python version.
12474
12475 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12476
12477         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12478         code from these functions.  Remove corresponding ifdefs.  Use
12479         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12480         Remove gotos and target of gotos.
12481         (infpy_search_memory): Likewise.
12482
12483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12484
12485         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12486         (hppa_gdbarch_init): Don't register deleted functions with
12487         gdbarch.
12488
12489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12490
12491         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12492         (h8300_unwind_sp): Delete.
12493         (h8300_dummy_id): Delete.
12494         (h8300_gdbarch_init): Don't register deleted functions with
12495         gdbarch.
12496
12497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12498
12499         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12500         (ft32_unwind_pc): Delete.
12501         (ft32_unwind_sp): Delete.
12502         (ft32_gdbarch_init): Don't register deleted functions with
12503         gdbarch.
12504
12505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12506
12507         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12508         (frv_unwind_pc): Delete.
12509         (frv_unwind_sp): Delete.
12510         (frv_gdbarch_init): Don't register deleted functions with
12511         gdbarch.
12512
12513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12514
12515         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12516         (riscv_unwind_pc): Delete.
12517         (riscv_unwind_sp): Delete.
12518         (riscv_gdbarch_init): Don't register deleted functions with
12519         gdbarch.
12520
12521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12522
12523         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12524         (csky_unwind_pc): Delete.
12525         (csky_unwind_sp): Delete.
12526         (csky_gdbarch_init): Don't register deleted functions with
12527         gdbarch.
12528
12529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12530
12531         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12532         (cris_unwind_pc): Delete.
12533         (cris_unwind_sp): Delete.
12534         (cris_gdbarch_init): Don't register deleted functions with
12535         gdbarch.
12536
12537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12538
12539         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12540         (bfin_unwind_pc): Delete.
12541         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12542
12543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12544
12545         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12546         (arm_unwind_pc): Delete.
12547         (arm_unwind_sp): Delete.
12548         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12549
12550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12551
12552         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12553         (arc_unwind_pc): Delete.
12554         (arc_unwind_sp): Delete.
12555         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12556
12557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12558
12559         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12560         (alpha_unwind_pc): Delete.
12561         (alpha_gdbarch_init): Don't register deleted functions with
12562         gdbarch.
12563
12564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12565
12566         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12567         (aarch64_unwind_pc): Delete.
12568         (aarch64_unwind_sp): Delete.
12569         (aarch64_gdbarch_init): Don't register deleted functions with
12570         gdbarch.
12571
12572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12573
12574         * gdbtypes.c (type_align): Don't consider static members when
12575         computing structure alignment.
12576
12577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12578
12579         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12580         return 0 for other types.
12581         * arch-utils.c (default_type_align): Always return 0.
12582         * gdbarch.h: Regenerate.
12583         * gdbarch.sh (type_align): Extend comment.
12584         * gdbtypes.c (type_align): Add additional comments, always call
12585         gdbarch_type_align before applying the default rules.
12586         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12587         generic code will then apply a suitable default.
12588         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12589         types, return 0 for other types.
12590
12591 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12592
12593         * NEWS: Create a new section for the next release branch.
12594         Rename the section of the current branch, now that it has
12595         been cut.
12596
12597 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12598
12599         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12600         * version.in: Bump version to 8.3.50.DATE-git.
12601
12602 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12603
12604         * aix-thread.c (ptid_cmp): Remove unused variable.
12605         (get_signaled_thread): Likewise.
12606         (store_regs_user_thread): Likewise.
12607         (store_regs_kernel_thread): Likewise.
12608         (fetch_regs_kernel_thread): Remove shadowed variable.
12609
12610 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12611
12612         * features/riscv/32bit-cpu.xml: Add register numbers.
12613         * features/riscv/32bit-fpu.c: Regenerate.
12614         * features/riscv/32bit-fpu.xml: Add register numbers.
12615         * features/riscv/64bit-cpu.xml: Add register numbers.
12616         * features/riscv/64bit-fpu.c: Regenerate.
12617         * features/riscv/64bit-fpu.xml: Add register numbers.
12618
12619 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12620
12621         * NEWS: Mention two argument form of gdb.Value constructor.
12622         * python/py-value.c (convert_buffer_and_type_to_value): New
12623         function.
12624         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12625         Add support for handling an optional second argument.  Call
12626         convert_buffer_and_type_to_value as appropriate.
12627         * python/python-internal.h (Py_buffer_deleter): New struct.
12628         (Py_buffer_up): New typedef.
12629
12630 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12631
12632         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12633         instead of releasing ownership.
12634
12635 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12636
12637         * dwarf2read.c (open_and_init_dwp_file): Call
12638         elf_numsections instead of bfd_count_sections to initialize
12639         dwp_file->num_sections.
12640
12641 2019-02-25  Tom Tromey  <tromey@adacore.com>
12642
12643         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12644
12645 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12646
12647         * gcore.in: Add '--readnever' option when invoking GDB.
12648
12649 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12650
12651         * MAINTAINERS: Update my email address.
12652
12653 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12654
12655         * build-id.c (build_id_to_debug_bfd_1): New function.
12656         (build_id_to_debug_bfd): Look for separate debug file in
12657         sysroot.
12658
12659 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12660
12661         * gdbarch.sh: Update the copyright year range that is placed into
12662         generated files.
12663
12664 2019-02-22  Keith Seitz  <keiths@redhat.com>
12665
12666         PR symtab/23853
12667         * linespec.c (create_sals_line_offset): Search for the default
12668         symtab's filename instead of its fullname.
12669
12670 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12671
12672         * NEWS: Update style defaults.
12673
12674 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12675
12676         * main.c (captured_main_1): Disable styling in batch mode.
12677
12678 2019-02-20  Tom Tromey  <tom@tromey.com>
12679
12680         * symtab.c (symtab_symbol_info): Fix typos.
12681
12682 2019-02-20  Tom Tromey  <tromey@adacore.com>
12683
12684         * findcmd.c (_initialize_mem_search): Use upper case for
12685         metasyntactic variables.
12686
12687 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12688
12689         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12690         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12691
12692 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12693
12694         * top.h (source_file_name): Change to std::string.
12695         * top.c (source_file_name): Likewise.
12696         (command_line_input): Adjust.
12697         * cli/cli-script.c (script_from_file): Adjust.
12698
12699 2019-02-19  Tom Tromey  <tromey@adacore.com>
12700
12701         * ravenscar-thread.c
12702         (ravenscar_thread_target::update_thread_list): Don't call
12703         ada_build_task_list.
12704         * ada-lang.h (ada_build_task_list): Don't declare.
12705         * ada-tasks.c (struct ada_tasks_inferior_data)
12706         <task_list_valid_p>: Now bool.
12707         (read_known_tasks, ada_task_list_changed)
12708         (ada_tasks_invalidate_inferior_data): Update.
12709         (read_known_tasks_array): Return bool.
12710         (read_known_tasks_list): Likewise.
12711         (read_known_tasks): Return void.
12712         (ada_build_task_list): Now static.
12713
12714 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12715
12716         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12717         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12718
12719 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12720
12721         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12722         variant for ada_tasks_pspace_data_handle and
12723         ada_tasks_inferior_data_handle.
12724         (ada_tasks_pspace_data_cleanup): New function.
12725         (ada_tasks_inferior_data_cleanup): New function.
12726
12727 2019-02-17  Tom Tromey  <tom@tromey.com>
12728
12729         * macrotab.h (macro_source_fullname): Return a std::string.
12730         * macrotab.c (macro_include, check_for_redefinition)
12731         (macro_undef, macro_lookup_definition, foreach_macro)
12732         (foreach_macro_in_scope): Update.
12733         (macro_source_fullname): Return a std::string.
12734         * macrocmd.c (show_pp_source_pos): Update.
12735
12736 2019-02-17  Tom Tromey  <tom@tromey.com>
12737
12738         * macrocmd.c (show_pp_source_pos): Style the file names.
12739
12740 2019-02-17  Tom Tromey  <tom@tromey.com>
12741
12742         PR tui/24197:
12743         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12744
12745 2019-02-17  Tom Tromey  <tom@tromey.com>
12746
12747         * ada-lang.c (user_select_syms): Use filtered printing.
12748         * utils.c (wrap_style): New global.
12749         (desired_style): Remove.
12750         (emit_style_escape): Add stream parameter.
12751         (set_output_style, reset_terminal_style, prompt_for_continue):
12752         Update.
12753         (flush_wrap_buffer): Only flush gdb_stdout.
12754         (wrap_here): Set wrap_style.
12755         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12756         treat escape sequences as a character.  Change when wrap buffer is
12757         flushed.
12758         (fputs_styled): Do not set the output style when the default is
12759         requested.
12760         * ui-style.h (struct ui_file_style) <is_default>: New method.
12761         * source.c (print_source_lines_base): Emit escape sequences in one
12762         piece.
12763
12764 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12765
12766         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12767         integers and enumeration types.
12768
12769 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12770
12771         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12772         instead of lookup_symbol_in_language
12773         (do_exact_match): New function.
12774         (ada_get_symbol_name_matcher): Return do_exact_match when
12775         doing a verbatim match.
12776
12777 2019-02-15  Tom Tromey  <tromey@adacore.com>
12778
12779         * ravenscar-thread.c (ravenscar_thread_target::resume)
12780         (ravenscar_thread_target::wait): Special case wildcard requests.
12781
12782 2019-02-15  Tom Tromey  <tromey@adacore.com>
12783
12784         * ravenscar-thread.c (base_ptid): Remove.
12785         (struct ravenscar_thread_target) <close>: New method.
12786         <m_base_ptid>: New member.
12787         <update_inferior_ptid, active_task, task_is_currently_active,
12788         runtime_initialized>: Declare methods.
12789         <ravenscar_thread_target>: Add constructor.
12790         (ravenscar_thread_target::task_is_currently_active)
12791         (ravenscar_thread_target::update_inferior_ptid)
12792         (ravenscar_runtime_initialized): Rename.  Now methods.
12793         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12794         (ravenscar_thread_target::update_thread_list): Update.
12795         (ravenscar_thread_target::active_task): Now method.
12796         (ravenscar_thread_target::store_registers)
12797         (ravenscar_thread_target::prepare_to_store)
12798         (ravenscar_thread_target::prepare_to_store)
12799         (ravenscar_thread_target::mourn_inferior): Update.
12800         (ravenscar_inferior_created): Use "new" to create target.
12801         (ravenscar_thread_target::get_ada_task_ptid): Update.
12802         (_initialize_ravenscar): Don't initialize base_ptid.
12803         (ravenscar_ops): Remove global.
12804
12805 2019-02-15  Tom Tromey  <tromey@adacore.com>
12806
12807         * target.h (push_target): Declare new overload.
12808         * target.c (push_target): New overload, taking an rvalue reference.
12809         * remote.c (remote_target::open_1): Use push_target overload.
12810         * corelow.c (core_target_open): Use push_target overload.
12811
12812 2019-02-15  Tom Tromey  <tromey@adacore.com>
12813
12814         * ravenscar-thread.c (is_ravenscar_task)
12815         (ravenscar_task_is_currently_active): Return bool.
12816         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12817         (_initialize_ravenscar): Remove "(void)".
12818         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12819         Return bool.
12820
12821 2019-02-15  Tom Tromey  <tromey@adacore.com>
12822
12823         * ravenscar-thread.c (ravenscar_runtime_initializer)
12824         (has_ravenscar_runtime, get_running_thread_id)
12825         (ravenscar_thread_target::resume): Fix indentation.
12826
12827 2019-02-15  Tom Tromey  <tromey@adacore.com>
12828
12829         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12830         from ravenscar_arch_ops.
12831         (sparc_ravenscar_ops::fetch_registers)
12832         (sparc_ravenscar_ops::store_registers): Now methods.
12833         (sparc_ravenscar_prepare_to_store): Remove.
12834         (sparc_ravenscar_ops): Redefine.
12835         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12836         methods and destructor.  Remove members.
12837         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12838         (ravenscar_thread_target::store_registers)
12839         (ravenscar_thread_target::prepare_to_store): Update.
12840         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12841         Remove.
12842         (struct ppc_ravenscar_powerpc_ops): Derive from
12843         ravenscar_arch_ops.
12844         (ppc_ravenscar_powerpc_ops::fetch_registers)
12845         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12846         (ppc_ravenscar_powerpc_ops): Redefine.
12847         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12848         (ppc_ravenscar_e500_ops::fetch_registers)
12849         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12850         (ppc_ravenscar_e500_ops): Redefine.
12851         * aarch64-ravenscar-thread.c
12852         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12853         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12854         (aarch64_ravenscar_fetch_registers)
12855         (aarch64_ravenscar_store_registers): Now methods.
12856         (aarch64_ravenscar_ops): Redefine.
12857
12858 2019-02-15  Tom Tromey  <tromey@adacore.com>
12859
12860         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12861         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12862         (ravenscar_thread_target::stopped_by_watchpoint)
12863         (ravenscar_thread_target::stopped_data_address)
12864         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12865
12866 2019-02-15  Tom Tromey  <tromey@adacore.com>
12867
12868         * ravenscar-thread.c: Fix some typos.
12869
12870 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12871             Tom Tromey  <tromey@adacore.com>
12872
12873         * ada-lang.c (ada_exception_sal): Change addr_string to a
12874         std::string.
12875         (create_ada_exception_catchpoint): Update.
12876
12877 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12878             Tom Tromey  <tromey@adacore.com>
12879
12880         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12881         (bp_location_ops): Remove.
12882         (base_breakpoint_allocate_location): Update.
12883         (free_bp_location): Update.
12884         * ada-lang.c (class ada_catchpoint_location)
12885         <ada_catchpoint_location>: Remove ops parameter.
12886         (ada_catchpoint_location_dtor): Remove.
12887         (ada_catchpoint_location_ops): Remove.
12888         (allocate_location_exception): Update.
12889         * breakpoint.h (struct bp_location_ops): Remove.
12890         (class bp_location) <bp_location>: Remove bp_location_ops
12891         parameter.
12892         <~bp_location>: Add destructor.
12893         <ops>: Remove.
12894
12895 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12896             Pedro Alves  <palves@redhat.com>
12897
12898         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12899         'PATH_MAX'.
12900
12901 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12902             Samuel Thibault  <samuel.thibault@gnu.org>
12903             Thomas Schwinge  <thomas@codesourcery.com>
12904
12905         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12906         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12907
12908 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12909
12910         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12911         (check_empty): Use "const char *".
12912
12913         * gnu-nat.c (gnu_nat_target::detach): Instead of
12914         'detach_inferior (pid)' call
12915         'detach_inferior (find_inferior_pid (pid))'.
12916
12917         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12918         'nat/fork-inferior.o'.
12919         * gnu-nat.c: #include "nat/fork-inferior.h".
12920
12921         * gnu-nat.c (gnu_nat_target::detach): Instead of
12922         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12923         * gnu-nat.h: #include "inf-child.h".
12924         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12925         'i386_gnu_nat_target::fetch_registers'.
12926         (gnu_store_registers): Rename/move to
12927         'i386_gnu_nat_target::store_registers'.
12928
12929         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12930         * gnu-nat.h (mach_thread_info): New function.
12931         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12932
12933         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12934
12935 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12936
12937         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12938
12939 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12940
12941         * windows-nat.c (windows_add_thread): Add new parameter
12942         "main_thread_p" with default value set to false.  Update
12943         function documentation as well as all callers.
12944         (windows_delete_thread): Likewise.
12945         (fake_create_process): Update call to windows_add_thread.
12946         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12947         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12948         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12949         call to windows_delete_thread.
12950
12951 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12952
12953         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12954
12955 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12956
12957         * symfile.c (find_separate_debug_file): Use canonical path of
12958         sysroot with child_path instead of gdb_sysroot if it is valid.
12959
12960 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12961
12962         * symfile.c (find_separate_debug_file): Use child_path to
12963         determine if an object file is under a sysroot.
12964
12965 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12966
12967         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12968         unittests/child-path-selftests.c.
12969         * common/pathstuff.c (child_path): New function.
12970         * common/pathstuff.h (child_path): New prototype.
12971         * unittests/child-path-selftests.c: New file.
12972
12973 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12974
12975         * symfile.c (find_separate_debug_file): Look for separate debug
12976         files in debug directories under the sysroot.
12977
12978 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12979
12980         * symtab.h (struct minimal_symbol data_p): New const method.
12981         (struct minimal_symbol text_p): Likewise.
12982         * symtab.c (output_source_filename): Use file name style
12983         to print file name.
12984         (print_symbol_info): Likewise.
12985         (print_msymbol_info): Use address style to print addresses.
12986         Use function name style to print executable text symbols.
12987         (expand_symtab_containing_pc): Use data_p.
12988         (find_pc_sect_compunit_symtab): Likewise.
12989
12990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12991
12992         * breakpoint.c (describe_other_breakpoints): Use address style
12993         to print addresses.
12994         (say_where): Likewise.
12995
12996 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12997
12998         * ada-typeprint.c (print_func_type): Print function name
12999         style to print function name.
13000         * c-typeprint.c (c_print_type_1): Likewise.
13001
13002 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13003
13004         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13005         for execve.
13006
13007 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13008
13009         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13010         type_stack.
13011
13012 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13013
13014         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13015         TYPE_CODE_REF types.
13016
13017 2019-02-08  Jim Wilson  <jimw@sifive.com>
13018
13019         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13020         (riscv_linux_fregset): New.
13021         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13022
13023 2019-02-07  Tom Tromey  <tom@tromey.com>
13024
13025         * thread.c (thread_cancel_execution_command): Update.
13026         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13027         methods.
13028         (struct thread_fsm_ops): Remove.
13029         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13030         (thread_fsm_should_stop, thread_fsm_return_value)
13031         (thread_fsm_set_finished, thread_fsm_finished_p)
13032         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13033         Don't declare.
13034         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13035         * infrun.c (clear_proceed_status_thread)
13036         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13037         (print_stop_event): Update.
13038         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13039         Add constructor.
13040         (step_command_fsm_ops): Remove.
13041         (new_step_command_fsm): Remove.
13042         (step_1): Update.
13043         (step_command_fsm::should_stop): Rename from
13044         step_command_fsm_should_stop.
13045         (step_command_fsm::clean_up): Rename from
13046         step_command_fsm_clean_up.
13047         (step_command_fsm::do_async_reply_reason): Rename from
13048         step_command_fsm_async_reply_reason.
13049         (struct until_next_fsm): Inherit from thread_fsm.  Add
13050         constructor.
13051         (until_next_fsm_ops): Remove.
13052         (new_until_next_fsm): Remove.
13053         (until_next_fsm::should_stop): Rename from
13054         until_next_fsm_should_stop.
13055         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13056         (until_next_fsm::do_async_reply_reason): Rename from
13057         until_next_fsm_async_reply_reason.
13058         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13059         constructor.  Change type of breakpoint.
13060         (finish_command_fsm_ops): Remove.
13061         (new_finish_command_fsm): Remove.
13062         (finish_command_fsm::should_stop): Rename from
13063         finish_command_fsm_should_stop.
13064         (finish_command_fsm::clean_up): Rename from
13065         finish_command_fsm_clean_up.
13066         (finish_command_fsm::return_value): Rename from
13067         finish_command_fsm_return_value.
13068         (finish_command_fsm::do_async_reply_reason): Rename from
13069         finish_command_fsm_async_reply_reason.
13070         (finish_command): Update.
13071         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13072         Add constructor.
13073         (call_thread_fsm_ops): Remove.
13074         (call_thread_fsm::call_thread_fsm): Rename from
13075         new_call_thread_fsm.
13076         (call_thread_fsm::should_stop): Rename from
13077         call_thread_fsm_should_stop.
13078         (call_thread_fsm::should_notify_stop): Rename from
13079         call_thread_fsm_should_notify_stop.
13080         (run_inferior_call, call_function_by_hand_dummy): Update.
13081         * cli/cli-interp.c (should_print_stop_to_console): Update.
13082         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13083         Add constructor.  Change type of location_breakpoint,
13084         caller_breakpoint.
13085         (until_break_fsm_ops): Remove.
13086         (new_until_break_fsm): Remove.
13087         (until_break_fsm::should_stop): Rename from
13088         until_break_fsm_should_stop.
13089         (until_break_fsm::clean_up): Rename from
13090         until_break_fsm_clean_up.
13091         (until_break_fsm::do_async_reply_reason): Rename from
13092         until_break_fsm_async_reply_reason.
13093         (until_break_command): Update.
13094         * thread-fsm.c: Remove.
13095         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13096
13097 2019-02-07  Tom Tromey  <tom@tromey.com>
13098
13099         * yy-remap.h: Add include guard.
13100         * xtensa-tdep.h: Add include guard.
13101         * xcoffread.h: Rename include guard.
13102         * varobj-iter.h: Add include guard.
13103         * tui/tui.h: Rename include guard.
13104         * tui/tui-winsource.h: Rename include guard.
13105         * tui/tui-wingeneral.h: Rename include guard.
13106         * tui/tui-windata.h: Rename include guard.
13107         * tui/tui-win.h: Rename include guard.
13108         * tui/tui-stack.h: Rename include guard.
13109         * tui/tui-source.h: Rename include guard.
13110         * tui/tui-regs.h: Rename include guard.
13111         * tui/tui-out.h: Rename include guard.
13112         * tui/tui-layout.h: Rename include guard.
13113         * tui/tui-io.h: Rename include guard.
13114         * tui/tui-hooks.h: Rename include guard.
13115         * tui/tui-file.h: Rename include guard.
13116         * tui/tui-disasm.h: Rename include guard.
13117         * tui/tui-data.h: Rename include guard.
13118         * tui/tui-command.h: Rename include guard.
13119         * tic6x-tdep.h: Add include guard.
13120         * target/waitstatus.h: Rename include guard.
13121         * target/wait.h: Rename include guard.
13122         * target/target.h: Rename include guard.
13123         * target/resume.h: Rename include guard.
13124         * target-float.h: Rename include guard.
13125         * stabsread.h: Add include guard.
13126         * rs6000-tdep.h: Add include guard.
13127         * riscv-fbsd-tdep.h: Add include guard.
13128         * regformats/regdef.h: Rename include guard.
13129         * record.h: Rename include guard.
13130         * python/python.h: Rename include guard.
13131         * python/python-internal.h: Rename include guard.
13132         * python/py-stopevent.h: Rename include guard.
13133         * python/py-ref.h: Rename include guard.
13134         * python/py-record.h: Rename include guard.
13135         * python/py-record-full.h: Rename include guard.
13136         * python/py-record-btrace.h: Rename include guard.
13137         * python/py-instruction.h: Rename include guard.
13138         * python/py-events.h: Rename include guard.
13139         * python/py-event.h: Rename include guard.
13140         * procfs.h: Add include guard.
13141         * proc-utils.h: Add include guard.
13142         * p-lang.h: Add include guard.
13143         * or1k-tdep.h: Rename include guard.
13144         * observable.h: Rename include guard.
13145         * nto-tdep.h: Rename include guard.
13146         * nat/x86-linux.h: Rename include guard.
13147         * nat/x86-linux-dregs.h: Rename include guard.
13148         * nat/x86-gcc-cpuid.h: Add include guard.
13149         * nat/x86-dregs.h: Rename include guard.
13150         * nat/x86-cpuid.h: Rename include guard.
13151         * nat/ppc-linux.h: Rename include guard.
13152         * nat/mips-linux-watch.h: Rename include guard.
13153         * nat/linux-waitpid.h: Rename include guard.
13154         * nat/linux-ptrace.h: Rename include guard.
13155         * nat/linux-procfs.h: Rename include guard.
13156         * nat/linux-osdata.h: Rename include guard.
13157         * nat/linux-nat.h: Rename include guard.
13158         * nat/linux-namespaces.h: Rename include guard.
13159         * nat/linux-btrace.h: Rename include guard.
13160         * nat/glibc_thread_db.h: Rename include guard.
13161         * nat/gdb_thread_db.h: Rename include guard.
13162         * nat/gdb_ptrace.h: Rename include guard.
13163         * nat/fork-inferior.h: Rename include guard.
13164         * nat/amd64-linux-siginfo.h: Rename include guard.
13165         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13166         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13167         * nat/aarch64-linux.h: Rename include guard.
13168         * nat/aarch64-linux-hw-point.h: Rename include guard.
13169         * mn10300-tdep.h: Add include guard.
13170         * mips-linux-tdep.h: Add include guard.
13171         * mi/mi-parse.h: Rename include guard.
13172         * mi/mi-out.h: Rename include guard.
13173         * mi/mi-main.h: Rename include guard.
13174         * mi/mi-interp.h: Rename include guard.
13175         * mi/mi-getopt.h: Rename include guard.
13176         * mi/mi-console.h: Rename include guard.
13177         * mi/mi-common.h: Rename include guard.
13178         * mi/mi-cmds.h: Rename include guard.
13179         * mi/mi-cmd-break.h: Rename include guard.
13180         * m2-lang.h: Add include guard.
13181         * location.h: Rename include guard.
13182         * linux-record.h: Rename include guard.
13183         * linux-nat.h: Add include guard.
13184         * linux-fork.h: Add include guard.
13185         * i386-darwin-tdep.h: Rename include guard.
13186         * hppa-linux-offsets.h: Add include guard.
13187         * guile/guile.h: Rename include guard.
13188         * guile/guile-internal.h: Rename include guard.
13189         * gnu-nat.h: Rename include guard.
13190         * gdb-stabs.h: Rename include guard.
13191         * frv-tdep.h: Add include guard.
13192         * f-lang.h: Add include guard.
13193         * event-loop.h: Add include guard.
13194         * darwin-nat.h: Rename include guard.
13195         * cp-abi.h: Rename include guard.
13196         * config/sparc/nm-sol2.h: Rename include guard.
13197         * config/nm-nto.h: Rename include guard.
13198         * config/nm-linux.h: Add include guard.
13199         * config/i386/nm-i386gnu.h: Rename include guard.
13200         * config/djgpp/nl_types.h: Rename include guard.
13201         * config/djgpp/langinfo.h: Rename include guard.
13202         * compile/gcc-cp-plugin.h: Add include guard.
13203         * compile/gcc-c-plugin.h: Add include guard.
13204         * compile/compile.h: Rename include guard.
13205         * compile/compile-object-run.h: Rename include guard.
13206         * compile/compile-object-load.h: Rename include guard.
13207         * compile/compile-internal.h: Rename include guard.
13208         * compile/compile-cplus.h: Rename include guard.
13209         * compile/compile-c.h: Rename include guard.
13210         * common/xml-utils.h: Rename include guard.
13211         * common/x86-xstate.h: Rename include guard.
13212         * common/version.h: Rename include guard.
13213         * common/vec.h: Rename include guard.
13214         * common/tdesc.h: Rename include guard.
13215         * common/selftest.h: Rename include guard.
13216         * common/scoped_restore.h: Rename include guard.
13217         * common/scoped_mmap.h: Rename include guard.
13218         * common/scoped_fd.h: Rename include guard.
13219         * common/safe-iterator.h: Rename include guard.
13220         * common/run-time-clock.h: Rename include guard.
13221         * common/refcounted-object.h: Rename include guard.
13222         * common/queue.h: Rename include guard.
13223         * common/ptid.h: Rename include guard.
13224         * common/print-utils.h: Rename include guard.
13225         * common/preprocessor.h: Rename include guard.
13226         * common/pathstuff.h: Rename include guard.
13227         * common/observable.h: Rename include guard.
13228         * common/netstuff.h: Rename include guard.
13229         * common/job-control.h: Rename include guard.
13230         * common/host-defs.h: Rename include guard.
13231         * common/gdb_wait.h: Rename include guard.
13232         * common/gdb_vecs.h: Rename include guard.
13233         * common/gdb_unlinker.h: Rename include guard.
13234         * common/gdb_unique_ptr.h: Rename include guard.
13235         * common/gdb_tilde_expand.h: Rename include guard.
13236         * common/gdb_sys_time.h: Rename include guard.
13237         * common/gdb_string_view.h: Rename include guard.
13238         * common/gdb_splay_tree.h: Rename include guard.
13239         * common/gdb_setjmp.h: Rename include guard.
13240         * common/gdb_ref_ptr.h: Rename include guard.
13241         * common/gdb_optional.h: Rename include guard.
13242         * common/gdb_locale.h: Rename include guard.
13243         * common/gdb_assert.h: Rename include guard.
13244         * common/filtered-iterator.h: Rename include guard.
13245         * common/filestuff.h: Rename include guard.
13246         * common/fileio.h: Rename include guard.
13247         * common/environ.h: Rename include guard.
13248         * common/common-utils.h: Rename include guard.
13249         * common/common-types.h: Rename include guard.
13250         * common/common-regcache.h: Rename include guard.
13251         * common/common-inferior.h: Rename include guard.
13252         * common/common-gdbthread.h: Rename include guard.
13253         * common/common-exceptions.h: Rename include guard.
13254         * common/common-defs.h: Rename include guard.
13255         * common/common-debug.h: Rename include guard.
13256         * common/cleanups.h: Rename include guard.
13257         * common/buffer.h: Rename include guard.
13258         * common/btrace-common.h: Rename include guard.
13259         * common/break-common.h: Rename include guard.
13260         * cli/cli-utils.h: Rename include guard.
13261         * cli/cli-style.h: Rename include guard.
13262         * cli/cli-setshow.h: Rename include guard.
13263         * cli/cli-script.h: Rename include guard.
13264         * cli/cli-interp.h: Rename include guard.
13265         * cli/cli-decode.h: Rename include guard.
13266         * cli/cli-cmds.h: Rename include guard.
13267         * charset-list.h: Add include guard.
13268         * buildsym-legacy.h: Rename include guard.
13269         * bfin-tdep.h: Add include guard.
13270         * ax.h: Rename include guard.
13271         * arm-linux-tdep.h: Add include guard.
13272         * arm-fbsd-tdep.h: Add include guard.
13273         * arch/xtensa.h: Rename include guard.
13274         * arch/tic6x.h: Add include guard.
13275         * arch/i386.h: Add include guard.
13276         * arch/arm.h: Rename include guard.
13277         * arch/arm-linux.h: Rename include guard.
13278         * arch/arm-get-next-pcs.h: Rename include guard.
13279         * arch/amd64.h: Add include guard.
13280         * arch/aarch64-insn.h: Rename include guard.
13281         * arch-utils.h: Rename include guard.
13282         * annotate.h: Add include guard.
13283         * amd64-darwin-tdep.h: Rename include guard.
13284         * aarch64-linux-tdep.h: Add include guard.
13285         * aarch64-fbsd-tdep.h: Add include guard.
13286         * aarch32-linux-nat.h: Add include guard.
13287
13288 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13289
13290         * macrotab.c (macro_define_internal): New function that
13291         factorizes macro_define_object_internal and macro_define_function
13292         code.
13293         (macro_define_object_internal): Use macro_define_internal.
13294         (macro_define_function): Likewise.
13295
13296 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13297
13298         * macrocmd.c (extract_identifier): Return
13299         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13300         callers.
13301
13302 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13303
13304         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13305
13306 2019-02-05  Tom Tromey  <tom@tromey.com>
13307
13308         * target.c (target_stack::unpush): Move assertion earlier.
13309
13310 2019-01-30  Tom Tromey  <tom@tromey.com>
13311
13312         PR python/23615:
13313         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13314         (gdbpy_parse_and_eval): Likewise.
13315         * python/python-internal.h (gdbpy_allow_threads): New class.
13316
13317 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13318
13319         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13320         (aarch64_fbsd_fpregmap): Move earlier.
13321         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13322         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13323         instead of individual calls to trad_frame_set_reg_addr.
13324         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13325         earlier.
13326         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13327         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13328         instead of individual calls to trad_frame_set_reg_addr.
13329
13330 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13331
13332         * CONTRIBUTE: Replace contribution list with wiki link.
13333
13334 2019-01-25  Tom Tromey  <tom@tromey.com>
13335
13336         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13337
13338 2019-01-25  Tom Tromey  <tom@tromey.com>
13339
13340         * xtensa-linux-nat.c: Fix common/ includes.
13341         * xml-support.h: Fix common/ includes.
13342         * xml-support.c: Fix common/ includes.
13343         * x86-linux-nat.c: Fix common/ includes.
13344         * windows-nat.c: Fix common/ includes.
13345         * varobj.h: Fix common/ includes.
13346         * varobj.c: Fix common/ includes.
13347         * value.c: Fix common/ includes.
13348         * valops.c: Fix common/ includes.
13349         * utils.c: Fix common/ includes.
13350         * unittests/xml-utils-selftests.c: Fix common/ includes.
13351         * unittests/utils-selftests.c: Fix common/ includes.
13352         * unittests/unpack-selftests.c: Fix common/ includes.
13353         * unittests/tracepoint-selftests.c: Fix common/ includes.
13354         * unittests/style-selftests.c: Fix common/ includes.
13355         * unittests/string_view-selftests.c: Fix common/ includes.
13356         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13357         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13358         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13359         * unittests/rsp-low-selftests.c: Fix common/ includes.
13360         * unittests/parse-connection-spec-selftests.c: Fix common/
13361         includes.
13362         * unittests/optional-selftests.c: Fix common/ includes.
13363         * unittests/offset-type-selftests.c: Fix common/ includes.
13364         * unittests/observable-selftests.c: Fix common/ includes.
13365         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13366         * unittests/memrange-selftests.c: Fix common/ includes.
13367         * unittests/memory-map-selftests.c: Fix common/ includes.
13368         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13369         * unittests/function-view-selftests.c: Fix common/ includes.
13370         * unittests/environ-selftests.c: Fix common/ includes.
13371         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13372         * unittests/common-utils-selftests.c: Fix common/ includes.
13373         * unittests/cli-utils-selftests.c: Fix common/ includes.
13374         * unittests/array-view-selftests.c: Fix common/ includes.
13375         * ui-file.c: Fix common/ includes.
13376         * tui/tui-io.c: Fix common/ includes.
13377         * tracepoint.h: Fix common/ includes.
13378         * tracepoint.c: Fix common/ includes.
13379         * tracefile-tfile.c: Fix common/ includes.
13380         * top.h: Fix common/ includes.
13381         * top.c: Fix common/ includes.
13382         * thread.c: Fix common/ includes.
13383         * target/waitstatus.h: Fix common/ includes.
13384         * target/waitstatus.c: Fix common/ includes.
13385         * target.h: Fix common/ includes.
13386         * target.c: Fix common/ includes.
13387         * target-memory.c: Fix common/ includes.
13388         * target-descriptions.c: Fix common/ includes.
13389         * symtab.h: Fix common/ includes.
13390         * symfile.c: Fix common/ includes.
13391         * stap-probe.c: Fix common/ includes.
13392         * spu-linux-nat.c: Fix common/ includes.
13393         * sparc-nat.c: Fix common/ includes.
13394         * source.c: Fix common/ includes.
13395         * solib.c: Fix common/ includes.
13396         * solib-target.c: Fix common/ includes.
13397         * ser-unix.c: Fix common/ includes.
13398         * ser-tcp.c: Fix common/ includes.
13399         * ser-pipe.c: Fix common/ includes.
13400         * ser-base.c: Fix common/ includes.
13401         * selftest-arch.c: Fix common/ includes.
13402         * s12z-tdep.c: Fix common/ includes.
13403         * rust-exp.y: Fix common/ includes.
13404         * rs6000-aix-tdep.c: Fix common/ includes.
13405         * riscv-tdep.c: Fix common/ includes.
13406         * remote.c: Fix common/ includes.
13407         * remote-notif.h: Fix common/ includes.
13408         * remote-fileio.h: Fix common/ includes.
13409         * remote-fileio.c: Fix common/ includes.
13410         * regcache.h: Fix common/ includes.
13411         * regcache.c: Fix common/ includes.
13412         * record-btrace.c: Fix common/ includes.
13413         * python/python.c: Fix common/ includes.
13414         * python/py-type.c: Fix common/ includes.
13415         * python/py-inferior.c: Fix common/ includes.
13416         * progspace.h: Fix common/ includes.
13417         * producer.c: Fix common/ includes.
13418         * procfs.c: Fix common/ includes.
13419         * proc-api.c: Fix common/ includes.
13420         * printcmd.c: Fix common/ includes.
13421         * ppc-linux-nat.c: Fix common/ includes.
13422         * parser-defs.h: Fix common/ includes.
13423         * osdata.c: Fix common/ includes.
13424         * obsd-nat.c: Fix common/ includes.
13425         * nat/x86-linux.c: Fix common/ includes.
13426         * nat/x86-linux-dregs.c: Fix common/ includes.
13427         * nat/x86-dregs.h: Fix common/ includes.
13428         * nat/x86-dregs.c: Fix common/ includes.
13429         * nat/ppc-linux.c: Fix common/ includes.
13430         * nat/mips-linux-watch.h: Fix common/ includes.
13431         * nat/mips-linux-watch.c: Fix common/ includes.
13432         * nat/linux-waitpid.c: Fix common/ includes.
13433         * nat/linux-ptrace.h: Fix common/ includes.
13434         * nat/linux-ptrace.c: Fix common/ includes.
13435         * nat/linux-procfs.c: Fix common/ includes.
13436         * nat/linux-personality.c: Fix common/ includes.
13437         * nat/linux-osdata.c: Fix common/ includes.
13438         * nat/linux-namespaces.c: Fix common/ includes.
13439         * nat/linux-btrace.h: Fix common/ includes.
13440         * nat/linux-btrace.c: Fix common/ includes.
13441         * nat/fork-inferior.c: Fix common/ includes.
13442         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13443         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13444         * nat/aarch64-linux.c: Fix common/ includes.
13445         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13446         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13447         * namespace.h: Fix common/ includes.
13448         * mips-linux-tdep.c: Fix common/ includes.
13449         * minsyms.c: Fix common/ includes.
13450         * mi/mi-parse.h: Fix common/ includes.
13451         * mi/mi-main.c: Fix common/ includes.
13452         * mi/mi-cmd-env.c: Fix common/ includes.
13453         * memrange.h: Fix common/ includes.
13454         * memattr.c: Fix common/ includes.
13455         * maint.h: Fix common/ includes.
13456         * maint.c: Fix common/ includes.
13457         * main.c: Fix common/ includes.
13458         * machoread.c: Fix common/ includes.
13459         * location.c: Fix common/ includes.
13460         * linux-thread-db.c: Fix common/ includes.
13461         * linux-nat.c: Fix common/ includes.
13462         * linux-fork.c: Fix common/ includes.
13463         * inline-frame.c: Fix common/ includes.
13464         * infrun.c: Fix common/ includes.
13465         * inflow.c: Fix common/ includes.
13466         * inferior.h: Fix common/ includes.
13467         * inferior.c: Fix common/ includes.
13468         * infcmd.c: Fix common/ includes.
13469         * inf-ptrace.c: Fix common/ includes.
13470         * inf-child.c: Fix common/ includes.
13471         * ia64-linux-nat.c: Fix common/ includes.
13472         * i387-tdep.c: Fix common/ includes.
13473         * i386-tdep.c: Fix common/ includes.
13474         * i386-linux-tdep.c: Fix common/ includes.
13475         * i386-linux-nat.c: Fix common/ includes.
13476         * i386-go32-tdep.c: Fix common/ includes.
13477         * i386-fbsd-tdep.c: Fix common/ includes.
13478         * i386-fbsd-nat.c: Fix common/ includes.
13479         * guile/scm-type.c: Fix common/ includes.
13480         * guile/guile.c: Fix common/ includes.
13481         * go32-nat.c: Fix common/ includes.
13482         * gnu-nat.c: Fix common/ includes.
13483         * gdbthread.h: Fix common/ includes.
13484         * gdbarch-selftests.c: Fix common/ includes.
13485         * gdb_usleep.c: Fix common/ includes.
13486         * gdb_select.h: Fix common/ includes.
13487         * gdb_bfd.c: Fix common/ includes.
13488         * gcore.c: Fix common/ includes.
13489         * fork-child.c: Fix common/ includes.
13490         * findvar.c: Fix common/ includes.
13491         * fbsd-nat.c: Fix common/ includes.
13492         * event-top.c: Fix common/ includes.
13493         * event-loop.c: Fix common/ includes.
13494         * dwarf2read.c: Fix common/ includes.
13495         * dwarf2loc.c: Fix common/ includes.
13496         * dwarf2-frame.c: Fix common/ includes.
13497         * dwarf-index-cache.c: Fix common/ includes.
13498         * dtrace-probe.c: Fix common/ includes.
13499         * disasm-selftests.c: Fix common/ includes.
13500         * defs.h: Fix common/ includes.
13501         * csky-tdep.c: Fix common/ includes.
13502         * cp-valprint.c: Fix common/ includes.
13503         * cp-support.h: Fix common/ includes.
13504         * cp-support.c: Fix common/ includes.
13505         * corelow.c: Fix common/ includes.
13506         * completer.h: Fix common/ includes.
13507         * completer.c: Fix common/ includes.
13508         * compile/compile.c: Fix common/ includes.
13509         * compile/compile-loc2c.c: Fix common/ includes.
13510         * compile/compile-cplus-types.c: Fix common/ includes.
13511         * compile/compile-cplus-symbols.c: Fix common/ includes.
13512         * command.h: Fix common/ includes.
13513         * cli/cli-dump.c: Fix common/ includes.
13514         * cli/cli-cmds.c: Fix common/ includes.
13515         * charset.c: Fix common/ includes.
13516         * build-id.c: Fix common/ includes.
13517         * btrace.h: Fix common/ includes.
13518         * btrace.c: Fix common/ includes.
13519         * breakpoint.h: Fix common/ includes.
13520         * breakpoint.c: Fix common/ includes.
13521         * ax.h:
13522         (enum agent_op): Fix common/ includes.
13523         * ax-general.c (struct aop_map): Fix common/ includes.
13524         * ax-gdb.c: Fix common/ includes.
13525         * auxv.c: Fix common/ includes.
13526         * auto-load.c: Fix common/ includes.
13527         * arm-tdep.c: Fix common/ includes.
13528         * arch/riscv.c: Fix common/ includes.
13529         * arch/ppc-linux-common.c: Fix common/ includes.
13530         * arch/i386.c: Fix common/ includes.
13531         * arch/arm.c: Fix common/ includes.
13532         * arch/arm-linux.c: Fix common/ includes.
13533         * arch/arm-get-next-pcs.c: Fix common/ includes.
13534         * arch/amd64.c: Fix common/ includes.
13535         * arch/aarch64.c: Fix common/ includes.
13536         * arch/aarch64-insn.c: Fix common/ includes.
13537         * arch-utils.c: Fix common/ includes.
13538         * amd64-windows-tdep.c: Fix common/ includes.
13539         * amd64-tdep.c: Fix common/ includes.
13540         * amd64-sol2-tdep.c: Fix common/ includes.
13541         * amd64-obsd-tdep.c: Fix common/ includes.
13542         * amd64-nbsd-tdep.c: Fix common/ includes.
13543         * amd64-linux-tdep.c: Fix common/ includes.
13544         * amd64-linux-nat.c: Fix common/ includes.
13545         * amd64-fbsd-tdep.c: Fix common/ includes.
13546         * amd64-fbsd-nat.c: Fix common/ includes.
13547         * amd64-dicos-tdep.c: Fix common/ includes.
13548         * amd64-darwin-tdep.c: Fix common/ includes.
13549         * agent.c: Fix common/ includes.
13550         * ada-lang.h: Fix common/ includes.
13551         * ada-lang.c: Fix common/ includes.
13552         * aarch64-tdep.c: Fix common/ includes.
13553
13554 2019-01-25  Tom Tromey  <tom@tromey.com>
13555
13556         * common/create-version.sh: Use common/version.h.
13557
13558 2019-01-24  Pedro Alves  <palves@redhat.com>
13559
13560         * infrun.c (signal_stop, signal_print, signal_program)
13561         (signal_catch, signal_pass): Now arrays instead of pointers.
13562         (update_signals_program_target, do_target_resume)
13563         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13564         * linux-nat.c (linux_nat_target::pass_signals)
13565         (linux_nat_target::create_inferior, linux_nat_target::attach):
13566         Adjust.
13567         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13568         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13569         * procfs.c (procfs_target::pass_signals): Adjust.
13570         * record-full.c (record_full_target::resume): Adjust.
13571         * remote.c (remote_target::pass_signals)
13572         (remote_target::program_signals): Adjust.
13573         * target-debug.h (target_debug_print_signals): Now takes a
13574         gdb::array_view as parameter.  Adjust.
13575         * target.h (target_ops) <pass_signals, program_signals>: Replace
13576         pointer and length parameters with gdb::array_view.
13577         (target_pass_signals, target_program_signals): Likewise.
13578         * target-delegates.c: Regenerate.
13579
13580 2019-01-24  Pedro Alves  <palves@redhat.com>
13581
13582         * common/forward-scope-exit.h
13583         (forward_scope_exit::forward_scope_exit): Pass arguments to
13584         m_bind_function directly, instead of creating a std::bind and
13585         copying that.
13586
13587 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13588
13589         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13590         for static members.
13591         (pass_in_v_vfp_candidate): Likewise.
13592
13593 2019-01-23  Tom Tromey  <tom@tromey.com>
13594             Pedro Alves  <palves@redhat.com>
13595
13596         * regcache.c (class regcache_invalidator): Remove.
13597         (regcache::raw_write): Use make_scope_exit.
13598
13599 2019-01-23  Tom Tromey  <tom@tromey.com>
13600
13601         * ui-out.h (class ui_out_emit_type): Update comment.
13602
13603 2019-01-23  Tom Tromey  <tom@tromey.com>
13604
13605         * infrun.c (fetch_inferior_event): Update comment.
13606
13607 2019-01-23  Tom Tromey  <tom@tromey.com>
13608             Pedro Alves  <palves@redhat.com>
13609
13610         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13611         parameter.
13612         (fetch_inferior_event): Use SCOPE_EXIT.
13613
13614
13615 2019-01-23  Tom Tromey  <tom@tromey.com>
13616             Pedro Alves  <palves@redhat.com>
13617
13618         * infrun.c (disable_thread_events): Delete.
13619         (stop_all_threads): Use SCOPE_EXIT.
13620
13621 2019-01-23  Tom Tromey  <tom@tromey.com>
13622             Pedro Alves  <palves@redhat.com>
13623
13624         * symfile.c: Include forward-scope-exit.h.
13625         (clear_symtab_users_cleanup): Replace forward declaration with
13626         a FORWARD_SCOPE_EXIT.
13627         (syms_from_objfile_1): Use the forward_scope_exit and
13628         gdb::optional instead of cleanup_function.
13629         (reread_symbols): Use the forward_scope_exit instead of
13630         cleanup_function.
13631         (clear_symtab_users_cleanup): Remove function.
13632
13633 2019-01-23  Tom Tromey  <tom@tromey.com>
13634             Pedro Alves  <palves@redhat.com>
13635
13636         * linux-nat.c: Include scope-exit.h.
13637         (cleanup_target_stop): Remove.
13638         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13639         SCOPE_EXIT.
13640
13641 2019-01-23  Tom Tromey  <tom@tromey.com>
13642             Pedro Alves  <palves@redhat.com>
13643
13644         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13645         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13646
13647 2019-01-23  Tom Tromey  <tom@tromey.com>
13648             Andrew Burgess  <andrew.burgess@embecosm.com>
13649             Pedro Alves  <palves@redhat.com>
13650
13651         * infrun.c (fetch_inferior_event): Use scope_exit.
13652         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13653         * top.c (execute_command): Use scope_exit.
13654         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13655         * utils.c (do_bpstat_clear_actions_cleanup)
13656         (make_bpstat_clear_actions_cleanup): Remove.
13657
13658 2019-01-23  Tom Tromey  <tom@tromey.com>
13659             Pedro Alves  <palves@redhat.com>
13660
13661         * infrun.c: Include "common/scope-exit.h"
13662         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13663         (wait_for_inferior): Use SCOPE_EXIT.
13664         (fetch_inferior_event): Use scope_exit.
13665
13666 2019-01-23  Tom Tromey  <tom@tromey.com>
13667             Pedro Alves  <palves@redhat.com>
13668
13669         * breakpoint.c (create_breakpoint): Remove cleanup.
13670
13671 2019-01-23  Tom Tromey  <tom@tromey.com>
13672             Andrew Burgess  <andrew.burgess@embecosm.com>
13673             Pedro Alves  <palves@redhat.com>
13674
13675 2019-01-23  Pedro Alves  <palves@redhat.com>
13676
13677         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13678
13679 2019-01-23  Pedro Alves  <palves@redhat.com>
13680             Andrew Burgess  <andrew.burgess@embecosm.com>
13681
13682         * gdbthread.h: Include "common/forward-scope-exit.h".
13683         (scoped_finish_thread_state): Redefine custom class in terms of
13684         forward_scope_exit.
13685
13686 2019-01-23  Pedro Alves  <palves@redhat.com>
13687             Andrew Burgess  <andrew.burgess@embecosm.com>
13688
13689         * common/forward-scope-exit.h: New file.
13690
13691 2019-01-23  Pedro Alves  <palves@redhat.com>
13692             Andrew Burgess  <andrew.burgess@embecosm.com>
13693             Tom Tromey  <tom@tromey.com>
13694
13695         * common/scope-exit.h: New file.
13696
13697 2019-01-23  Pedro Alves  <palves@redhat.com>
13698
13699         * common/preprocessor.h (ESC): Rename to ...
13700         (ESC_PARENS): ... this.
13701         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13702         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13703
13704 2019-01-23  Tom Tromey  <tom@tromey.com>
13705
13706         * language.h (class scoped_switch_to_sym_language_if_auto):
13707         Initialize m_lang in both cases.
13708
13709 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13710
13711         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13712         with XCNEW.
13713
13714 2019-01-22  Tom Tromey  <tom@tromey.com>
13715
13716         * corelow.c: Do not include sys/file.h.
13717
13718 2019-01-22  Tom Tromey  <tom@tromey.com>
13719
13720         * tui/tui-wingeneral.h: Include gdb_curses.h.
13721
13722 2019-01-22  Tom Tromey  <tom@tromey.com>
13723
13724         * source-cache.h (class source_cache) <get_source_lines,
13725         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13726
13727 2019-01-22  Tom Tromey  <tom@tromey.com>
13728
13729         * remote-fileio.h (struct remote_target): Declare.
13730
13731 2019-01-22  Tom Tromey  <tom@tromey.com>
13732
13733         * python/py-arch.c: Do not include py-ref.h.
13734         * python/py-bpevent.c: Do not include py-ref.h.
13735         * python/py-cmd.c: Do not include py-ref.h.
13736         * python/py-continueevent.c: Do not include py-ref.h.
13737         * python/py-event.h: Do not include py-ref.h.
13738         * python/py-evtregistry.c: Do not include py-ref.h.
13739         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13740         * python/py-frame.c: Do not include py-ref.h.
13741         * python/py-framefilter.c: Do not include py-ref.h.
13742         * python/py-function.c: Do not include py-ref.h.
13743         * python/py-infevents.c: Do not include py-ref.h.
13744         * python/py-linetable.c: Do not include py-ref.h.
13745         * python/py-objfile.c: Do not include py-ref.h.
13746         * python/py-param.c: Do not include py-ref.h.
13747         * python/py-prettyprint.c: Do not include py-ref.h.
13748         * python/py-progspace.c: Do not include py-ref.h.
13749         * python/py-symbol.c: Do not include py-ref.h.
13750         * python/py-symtab.c: Do not include py-ref.h.
13751         * python/py-type.c: Do not include py-ref.h.
13752         * python/py-unwind.c: Do not include py-ref.h.
13753         * python/py-utils.c: Do not include py-ref.h.
13754         * python/py-value.c: Do not include py-ref.h.
13755         * python/py-varobj.c: Do not include py-ref.h.
13756         * python/py-xmethods.c: Do not include py-ref.h.
13757         * python/python.c: Do not include py-ref.h.
13758         * varobj.c: Do not include py-ref.h.
13759
13760 2019-01-22  Tom Tromey  <tom@tromey.com>
13761
13762         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13763         keyword for bcache.
13764
13765 2019-01-22  Tom Tromey  <tom@tromey.com>
13766
13767         * compile/compile-cplus-types.c: Remove a comment by #include.
13768
13769 2019-01-22  Tom Tromey  <tom@tromey.com>
13770
13771         * compile/gcc-c-plugin.h: Include compile-internal.h.
13772
13773 2019-01-22  Tom Tromey  <tom@tromey.com>
13774
13775         * stabsread.c (EXTERN): Do not define.
13776         (symnum, next_symbol_text_func, processing_gcc_compilation)
13777         (within_function, global_sym_chain, global_stabs)
13778         (previous_stab_code, this_object_header_files)
13779         (n_this_object_header_files)
13780         (n_allocated_this_object_header_files): Define.
13781         * stabsread.h (EXTERN): Never define.  Use "extern".
13782
13783 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13784
13785         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13786         history_value.
13787
13788 2019-01-21  Tom Tromey  <tom@tromey.com>
13789
13790         * ui-out.c: Fix includes.
13791         * tui/tui-source.c: Fix includes.
13792         * target.c: Fix includes.
13793         * remote.c: Fix includes.
13794         * regcache.c: Fix includes.
13795         * python/py-block.c: Fix includes.
13796         * printcmd.c: Fix includes.
13797         * or1k-tdep.c: Fix includes.
13798         * mi/mi-main.c: Fix includes.
13799         * m32r-tdep.c: Fix includes.
13800         * csky-tdep.c: Fix includes.
13801         * compile/compile-cplus-types.c: Fix includes.
13802         * cli/cli-interp.c: Fix includes.
13803
13804 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13805
13806         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13807         for padding.
13808
13809 2019-01-16  Tom Tromey  <tom@tromey.com>
13810
13811         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13812         earlier.
13813         (struct objfile) <msymbols_range>: Move from top level.
13814         <msymbols>: New method.
13815         (class objfile_msymbols): Remove.
13816         * symtab.c (default_collect_symbol_completion_matches_break_on):
13817         Update.
13818         * symmisc.c (dump_msymbols): Update.
13819         * stabsread.c (scan_file_globals): Update.
13820         * objc-lang.c (info_selectors_command, info_classes_command)
13821         (find_methods): Update.
13822         * minsyms.c (find_solib_trampoline_target): Update.
13823         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13824         * coffread.c (coff_symfile_read): Update.
13825         * ada-lang.c (ada_lookup_simple_minsym)
13826         (ada_collect_symbol_completion_matches): Update.
13827
13828 2019-01-16  Tom Tromey  <tom@tromey.com>
13829
13830         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13831         type.  Remove no-argument constructor.
13832         <iterator::operator++>: Simplify.
13833         <begin>: Update.
13834         <end>: Use minimal_symbol_count.
13835
13836 2019-01-16  Tom Tromey  <tom@tromey.com>
13837
13838         * objfiles.h (struct objfile) <psymtabs>: New method.
13839         (class objfile_psymtabs): Remove.
13840         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13841         typedef.
13842         <range>: New method.
13843         (require_partial_symbols): Change return type.
13844         * psymtab.c (require_partial_symbols)
13845         (psym_expand_symtabs_matching): Update.
13846         * mdebugread.c (parse_partial_symbols): Update.
13847         * dbxread.c (dbx_end_psymtab): Update.
13848
13849 2019-01-15  Tom Tromey  <tom@tromey.com>
13850
13851         * symtab.c (lookup_objfile_from_block)
13852         (lookup_symbol_in_objfile_symtabs)
13853         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13854         (find_line_symtab, info_sources_command)
13855         (default_collect_symbol_completion_matches_break_on)
13856         (make_source_files_completion_list): Update.
13857         * symmisc.c (print_objfile_statistics, dump_objfile)
13858         (maintenance_print_symbols, maintenance_info_symtabs)
13859         (maintenance_check_symtabs, maintenance_info_line_tables):
13860         Update.
13861         * source.c (select_source_symtab)
13862         (forget_cached_source_info_for_objfile): Update.
13863         * objfiles.h (class objfile_compunits): Remove.
13864         (struct objfile) <compunits_range>: New typedef.
13865         (compunits): New method.
13866         * objfiles.c (objfile_relocate1): Update.
13867         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13868         * maint.c (count_symtabs_and_blocks): Update.
13869         * linespec.c (iterate_over_all_matching_symtabs): Update.
13870         * cp-support.c (add_symbol_overload_list_qualified): Update.
13871         * coffread.c (coff_symtab_read): Update.
13872         * ada-lang.c (add_nonlocal_symbols)
13873         (ada_collect_symbol_completion_matches)
13874         (ada_add_global_exceptions): Update.
13875
13876 2019-01-15  Tom Tromey  <tom@tromey.com>
13877
13878         * progspace.h (program_space) <objfiles_safe_range>: New
13879         typedef.
13880         <objfiles_safe>: New method.
13881         * objfiles.h (class all_objfiles_safe): Remove.
13882         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13883         * jit.c (jit_inferior_exit_hook): Update.
13884
13885 2019-01-17  Tom Tromey  <tom@tromey.com>
13886
13887         * progspace.h (program_space) <objfiles_range>: New typedef.
13888         <objfiles>: New method.
13889         <objfiles_head>: Rename from objfiles.
13890         (object_files): Update.
13891         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13892         * guile/scm-pretty-print.c
13893         (ppscm_find_pretty_printer_from_objfiles): Update.
13894         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13895         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13896         Update.
13897         * python/py-progspace.c (pspy_get_objfiles): Update.
13898         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13899         Update.
13900         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13901         (objfpy_lookup_objfile_by_build_id): Update.
13902         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13903         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13904         Update.
13905         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13906         (expand_symtab_containing_pc, lookup_objfile_from_block)
13907         (lookup_static_symbol, basic_lookup_transparent_type)
13908         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13909         (find_line_symtab, info_sources_command)
13910         (default_collect_symbol_completion_matches_break_on)
13911         (make_source_files_completion_list, find_main_name): Update.
13912         * symmisc.c (print_symbol_bcache_statistics)
13913         (print_objfile_statistics, maintenance_print_symbols)
13914         (maintenance_print_msymbols, maintenance_print_objfiles)
13915         (maintenance_info_symtabs, maintenance_check_symtabs)
13916         (maintenance_expand_symtabs, maintenance_info_line_tables):
13917         Update.
13918         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13919         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13920         (map_overlay_command, unmap_overlay_command)
13921         (simple_overlay_update, expand_symtabs_matching)
13922         (map_symbol_filenames): Update.
13923         * symfile-debug.c (set_debug_symfile): Update.
13924         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13925         Update.
13926         * source.c (select_source_symtab, forget_cached_source_info):
13927         Update.
13928         * solib.c (solib_read_symbols): Update.
13929         * solib-spu.c (append_ocl_sos): Update.
13930         * psymtab.c (maintenance_print_psymbols)
13931         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13932         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13933         * printcmd.c (info_symbol_command): Update.
13934         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13935         Update.
13936         * objfiles.h (class all_objfiles): Remove.
13937         * objfiles.c (have_partial_symbols, have_full_symbols)
13938         (have_minimal_symbols, qsort_cmp, update_section_map)
13939         (shared_objfile_contains_address_p)
13940         (default_iterate_over_objfiles_in_search_order): Update.
13941         * objc-lang.c (info_selectors_command, info_classes_command)
13942         (find_methods): Update.
13943         * minsyms.c (find_solib_trampoline_target): Update.
13944         * maint.c (maintenance_info_sections)
13945         (maintenance_translate_address, count_symtabs_and_blocks):
13946         Update.
13947         * main.c (captured_main_1): Update.
13948         * linux-thread-db.c (try_thread_db_load_from_pdir)
13949         (has_libpthread): Update.
13950         * linespec.c (iterate_over_all_matching_symtabs)
13951         (search_minsyms_for_name): Update.
13952         * jit.c (jit_find_objf_with_entry_addr): Update.
13953         * hppa-tdep.c (find_unwind_entry)
13954         (hppa_lookup_stub_minimal_symbol): Update.
13955         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13956         Update.
13957         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13958         (elf_gnu_ifunc_resolve_by_got): Update.
13959         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13960         * dwarf-index-write.c (save_gdb_index_command): Update.
13961         * cp-support.c (add_symbol_overload_list_qualified): Update.
13962         * breakpoint.c (create_overlay_event_breakpoint)
13963         (create_longjmp_master_breakpoint)
13964         (create_std_terminate_master_breakpoint)
13965         (create_exception_master_breakpoint): Update.
13966         * blockframe.c (find_pc_partial_function): Update.
13967         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13968         (ada_collect_symbol_completion_matches)
13969         (ada_add_global_exceptions): Update.
13970
13971 2019-01-17  Tom Tromey  <tom@tromey.com>
13972
13973         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13974         declare VEC.
13975         (solib_target_parse_libraries): Change return type.
13976         (library_list_start_segment, library_list_start_section)
13977         (library_list_end_library, library_list_start_library); Update.
13978         (solib_target_free_library_list): Remove.
13979         (solib_target_parse_libraries): Remove cleanup.  Change return
13980         type.
13981         (solib_target_current_sos): Update.
13982
13983 2019-01-17  Tom Tromey  <tromey@bapiya>
13984
13985         * valprint.c: Replace "the the" with "the".
13986         * symtab.c: Replace "the the" with "the".
13987         * solib.c: Replace "the the" with "the".
13988         * solib-dsbt.c: Replace "the the" with "the".
13989         * linespec.c: Replace "the the" with "the".
13990         * dwarf2loc.h: Replace "the the" with "the".
13991         * amd64-windows-tdep.c: Replace "the the" with "the".
13992         * aarch64-tdep.c: Replace "the the" with "the".
13993
13994 2019-01-16  Keith Seitz  <keiths@redhat.com>
13995
13996         PR gdb/23773
13997         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13998         <builder>: Rename to ..
13999         <m_builder>: ... this and make private.
14000         (dwarf2_cu::get_builder): New method.  Change all users of
14001         `builder' to use this method.
14002         (dwarf2_start_symtab): Move to ...
14003         (dwarf2_cu::start_symtab): ... here.  Update all callers
14004         (setup_type_unit_groups): Move to ...
14005         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14006         callers.
14007         (dwarf2_cu::reset_builder): New method.
14008         (process_full_compunit, process_full_type_unit): Use
14009         dwarf2_cu::reset_builder.
14010         (follow_die_offset): Record the ancestor CU if it is different
14011         from the followed DIE's CU.
14012         (follow_die_sig_1): Likewise.
14013
14014 2019-01-15  Tom Tromey  <tom@tromey.com>
14015
14016         * remote.c (class remote_state) <buf>: Now a char_vector.
14017         <buf_size>: Remove.
14018         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14019         parameter.
14020         (remote_target::getpkt_or_notif_sane_1)
14021         (remote_target::getpkt_sane)
14022         (remote_target::getpkt_or_notif_sane): Likewise.
14023         (class remote_target) <putpkt>: New overload.
14024         (remote_target::read_frame): Change type of "buf_p".  Remove
14025         sizeof_p parameter.
14026         (packet_ok): New overload.
14027         (packet_check_result): New overload.
14028         Update all uses.
14029
14030 2019-01-14  Tom Tromey  <tom@tromey.com>
14031
14032         * remote-notif.c (handle_notification, remote_notif_ack)
14033         (remote_notif_parse): Make "buf" const.
14034         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14035         const.
14036         (remote_notif_parse, remote_notif_ack, handle_notification):
14037         Likewise.
14038         * remote.c (remote_notif_stop_parse): Make "buf" const.
14039         (remote_target::remote_parse_stop_reply): Make "buf" const.
14040         (remote_notif_stop_ack): Make "buf" const.
14041
14042 2019-01-14  Tom Tromey  <tom@tromey.com>
14043
14044         * remote.c (remote_console_output): Make parameter const.
14045
14046 2019-01-14  Tom Tromey  <tom@tromey.com>
14047
14048         * target-debug.h (target_debug_print_signals): Constify.
14049         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14050         * procfs.c (procfs_target::pass_signals): Update.
14051         * linux-nat.c (linux_nat_target::pass_signals): Update.
14052         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14053         * target-delegates.c: Rebuild.
14054         * remote.c (remote_target::program_signals): Update.
14055         (remote_target::pass_signals): Update.
14056         * target.c (target_pass_signals): Constify argument.
14057         (target_program_signals): Likewise.
14058         * target.h (struct target_ops) <pass_signals, program_signals>:
14059         Constify argument.
14060         (target_pass_signals, target_program_signals): Constify argument.
14061
14062 2019-01-14  Tom Tromey  <tom@tromey.com>
14063
14064         PR tui/28819:
14065         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14066
14067 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14068
14069         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14070         field.
14071         * rs6000-tdep.c: Include reggroups.h.
14072         (IS_V_ALIAS_PSEUDOREG): Define.
14073         (rs6000_register_name): Return names for the "vX" aliases.
14074         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14075         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14076         aliases.  Call default_register_reggroup_p for all other
14077         pseudo-registers.
14078         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14079         New functions.
14080         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14081         Handle "vX" aliases.
14082         (v_alias_pseudo_register_collect): New function.
14083         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14084         (rs6000_gdbarch_init): Initialize "vX" aliases as
14085         pseudo-registers.  Restore registration of
14086         rs6000_pseudo_register_reggroup_p with
14087         set_tdesc_pseudo_register_reggroup_p.
14088
14089 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14090
14091         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14092         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14093         set_gdbarch_num_pseudo_regs.
14094
14095 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14096
14097         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14098         Remove arg prefixname, add do_set and do_show.
14099         Add member functions set_list and show_list.
14100         * cli/cli-style.c (class cli_style_option): Update accordingly.
14101         (style_set_list): Move to file scope.
14102         (style_show_list): Likewise.
14103         (set_style): Call help_list.
14104         (show_style): Call cmd_show_list.
14105         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14106         Update to use the new macro.
14107
14108 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14109
14110         * ada-lang.c (_initialize_ada_language): Expand the help text
14111         for the "catch exception" command.
14112
14113 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14114
14115         * symtab.c (matching_obj_sections): Initialize obj,
14116         declare it closer to its usage.
14117
14118 2019-01-10  Tom Tromey  <tom@tromey.com>
14119
14120         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14121         (basic_inf_threads_range): Remove.
14122         (inf_threads_range, inf_non_exited_threads_range)
14123         (safe_inf_threads_range): Use next_adapter.
14124
14125 2019-01-10  Keith Seitz  <keiths@redhat.com>
14126
14127         PR gdb/23712
14128         PR symtab/23010
14129         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14130         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14131
14132 2019-01-10  Keith Seitz  <keiths@redhat.com>
14133
14134         PR gdb/23712
14135         PR symtab/23010
14136         * dictionary.c (pending_to_vector): Remove.
14137         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14138         Remove _1 suffix, replacing functions of the same name.  Update
14139         all callers.
14140         (dict_create_hashed, dict_create_hashed_expandable)
14141         (dict_create_linear, dict_create_linear_expandable, dict_free)
14142         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14143         Make functions static.
14144
14145 2019-01-10  Keith Seitz  <keiths@redhat.com>
14146
14147         PR gdb/23712
14148         PR symtab/23010
14149         * dictionary.h (struct dictionary): Replace declaration with
14150         multidictionary.
14151         (dict_create_hashed, dict_create_hashed_expandable)
14152         (dict_create_linear, dict_create_linear_expandable)
14153         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14154         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14155         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14156         taking multidictionary argument.
14157         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14158         * block.h (struct block) <dict>: Change to multidictionary
14159         and rename `multidict'.
14160         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14161         symmisc.c: Update all dictionary references to multidictionary.
14162
14163 2019-01-10  Keith Seitz  <keiths@redhat.com>
14164
14165         PR gdb/23712
14166         PR symtab/23010
14167         * dictionary.c: Include unordered_map.
14168         (pending_to_vector): New function.
14169         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14170         Rewrite the non-"_1" functions to take vector instead
14171         of linked list.
14172         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14173         "new" _1 versions of the same name.
14174         (multidictionary): Define.
14175         (std::hash<enum language): New definition.
14176         (collate_pending_symbols_by_language, mdict_create_hashed)
14177         (mdict_create_hashed_expandable, mdict_create_linear)
14178         (mdict_create_linear_expandable, mdict_free)
14179         (find_language_dictionary, create_new_language_dictionary)
14180         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14181         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14182         (mdict_size, mdict_empty): New functions.
14183         * dictionary.h (mdict_iterator): Define.
14184
14185 2019-01-10  Pedro Alves  <palves@redhat.com>
14186
14187         * breakpoint.c (read_uploaded_action)
14188         (create_tracepoint_from_upload): Adjust to use
14189         gdb::unique_xmalloc_ptr.
14190         * ctf.c (ctf_write_uploaded_tp):
14191         (SET_ARRAY_FIELD): Use emplace_back.
14192         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14193         * tracefile-tfile.c (tfile_write_uploaded_tp):
14194         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14195         gdb::unique_xmalloc_ptr.
14196         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14197         at_string, cond_string, cmd_strings>: Replace char pointers
14198         with gdb::unique_xmalloc_ptr.
14199
14200 2019-01-10  Pedro Alves  <palves@redhat.com>
14201
14202         * solib-target.c (library_list_start_library): Don't xstrdup name.
14203
14204 2019-01-10  Pedro Alves  <palves@redhat.com>
14205
14206         * mdebugread.c (parse_partial_symbols): Use
14207         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14208
14209 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14210
14211         * linux-fork.c (scoped_switch_fork_info)
14212         <~scoped_switch_fork_info>: Fix incorrect variable name.
14213
14214 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14215
14216         * linux-fork.c (scoped_switch_fork_info)
14217         <scoped_switch_fork_info>: Make explicit.
14218         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14219
14220 2019-01-10  Tom Tromey  <tom@tromey.com>
14221
14222         * objfiles.h (objfile::reset_psymtabs): Update.
14223         * objfiles.c (objfile::objfile): Update.
14224         * psymtab.h (psymtab_storage::obstack): Update.
14225         (psymtab_storage::m_obstack): Use gdb::optional.
14226         (class psymtab_storage): Update comment.  Remove objfile
14227         parameter.
14228         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14229
14230 2019-01-10  Tom Tromey  <tom@tromey.com>
14231
14232         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14233         <free_psymtabs>: Now private.
14234         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14235         (allocate_psymtab): Use new method.
14236
14237 2019-01-10  Tom Tromey  <tom@tromey.com>
14238
14239         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14240         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14241         * mdebugread.c (parse_partial_symbols): Use
14242         allocate_dependencies.
14243         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14244         allocate_dependencies.
14245         (process_psymtab_comp_unit_reader)
14246         (build_type_psymtab_dependencies): Likewise.
14247         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14248
14249 2019-01-10  Tom Tromey  <tom@tromey.com>
14250
14251         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14252         PSYMBOL_SET_LANGUAGE.
14253         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14254
14255 2019-01-10  Tom Tromey  <tom@tromey.com>
14256
14257         * psymtab.h (psymtab_storage::obstack): New method.
14258         <m_obstack>: Rename from obstack; now private.
14259         * psymtab.c (psymtab_storage): Update.
14260         * dwarf2read.c (create_addrmap_from_index)
14261         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14262         Update.
14263
14264 2019-01-10  Tom Tromey  <tom@tromey.com>
14265
14266         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14267         * objfiles.h (objfile::reset_psymtabs): New method.
14268
14269 2019-01-10  Tom Tromey  <tom@tromey.com>
14270
14271         * symmisc.c (print_symbol_bcache_statistics): Update.
14272         (print_objfile_statistics): Update.
14273         * symfile.c (reread_symbols): Update.
14274         * psymtab.h (class psymtab_storage): New.
14275         * psymtab.c (psymtab_storage): New constructor.
14276         (~psymtab_storage): New destructor.
14277         (require_partial_symbols): Update.
14278         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14279         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14280         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14281         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14282         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14283         (start_psymtab_common, end_psymtab_common)
14284         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14285         (allocate_psymtab): Update.
14286         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14287         Update.
14288         (dump_psymtab_addrmap, maintenance_print_psymbols)
14289         (maintenance_check_psymtabs): Update.
14290         (class objfile_psymtabs): Move to objfiles.h.
14291         * psympriv.h (discard_psymtab): Now inline.
14292         (psymtab_discarder::psymtab_discarder): Update.
14293         (psymtab_discarder::~psymtab_discarder): Update.
14294         (ALL_OBJFILE_PSYMTABS): Rewrite.
14295         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14296         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14297         Remove fields.
14298         <partial_symtabs>: New field.
14299         (class objfile_psymtabs): Move from psymtab.h.  Update.
14300         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14301         psymbol_cache.
14302         (objfile::~objfile): Don't destroy psymbol_cache.
14303         * mdebugread.c (parse_partial_symbols): Update.
14304         * dwarf2read.c (create_addrmap_from_index)
14305         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14306         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14307         (add_partial_subprogram, dwarf2_ranges_read): Update.
14308         * dwarf-index-write.c (write_address_map)
14309         (write_one_signatured_type, recursively_write_psymbols)
14310         (class debug_names, class debug_names, write_psymtabs_to_index):
14311         Update.
14312
14313 2019-01-10  Tom Tromey  <tom@tromey.com>
14314
14315         * symtab.h (SYMBOL_SET_NAMES): Update.
14316         (symbol_set_names): Update.
14317         (MSYMBOL_SET_NAMES): Update.
14318         * symtab.c (symbol_set_names): Change argument to be an
14319         objfile_per_bfd_storage.
14320         * psymtab.c (add_psymbol_to_bcache): Update.
14321         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14322
14323 2019-01-10  Tom Tromey  <tom@tromey.com>
14324
14325         * symtab.c (create_demangled_names_hash): Change argument to be an
14326         objfile_per_bfd_storage.
14327         (symbol_set_names): Update.
14328
14329 2019-01-10  Tom Tromey  <tom@tromey.com>
14330
14331         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14332         init_psymbol_list.
14333         * psymtab.c (init_psymbol_list): Do nothing if already called.
14334         * psympriv.h (init_psymbol_list): Add comment.
14335         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14336         init_psymbol_list.
14337         * dbxread.c (dbx_symfile_read): Unconditionally call
14338         init_psymbol_list.
14339
14340 2019-01-10  Tom Tromey  <tom@tromey.com>
14341
14342         * xcoffread.c (scan_xcoff_symtab): Update.
14343         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14344         "where".
14345         * mdebugread.c (parse_partial_symbols)
14346         (handle_psymbol_enumerators): Update.
14347         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14348         * dbxread.c (read_dbx_symtab): Update.
14349         * psympriv.h (psymbol_placement): New enum.
14350         (add_psymbol_to_list): Update.
14351
14352 2019-01-10  Tom Tromey  <tom@tromey.com>
14353
14354         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14355         static_psymbols parameters.
14356         (scan_xcoff_symtab): Update.
14357         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14358         static_psymbols parameters.
14359         * psympriv.h (start_psymtab_common): Update.
14360         * mdebugread.c (parse_partial_symbols): Update.
14361         * dwarf2read.c (create_partial_symtab): Update.
14362         * dbxread.c (read_dbx_symtab): Update.
14363         (start_psymtab): Remove global_psymbols and static_psymbols
14364         parameters.
14365
14366 2019-01-10  Tom Tromey  <tom@tromey.com>
14367
14368         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14369         * psymtab.c (allocate_psymtab): Add comment.
14370         * psympriv.h (allocate_psymtab): Add comment.
14371         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14372         initializations.
14373         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14374
14375 2019-01-10  Tom Tromey  <tom@tromey.com>
14376
14377         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14378         Don't declare.
14379         * mipsread.c: Include mdebugread.h.
14380         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14381         Declare.
14382         * elfread.c: Include mdebugread.h.
14383
14384 2019-01-09  Tom Tromey  <tom@tromey.com>
14385
14386         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14387         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14388         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14389         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14390         (psym_lookup_symbol, psym_find_last_source_symtab)
14391         (psym_forget_cached_source_info, psym_print_stats)
14392         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14393         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14394         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14395         (psym_find_compunit_symtab_by_address)
14396         (maintenance_print_psymbols, maintenance_info_psymtabs)
14397         (maintenance_check_psymtabs): Use ranged for.
14398         * psymtab.h (class objfile_psymtabs): New.
14399         (require_partial_symbols): Return objfile_psymtabs.
14400         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14401
14402 2019-01-09  Tom Tromey  <tom@tromey.com>
14403
14404         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14405         (find_pc_mapped_section, list_overlays_command)
14406         (map_overlay_command, unmap_overlay_command)
14407         (simple_overlay_update): Use all_objfiles.
14408         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14409         * printcmd.c (info_symbol_command): Use all_objfiles.
14410         * objfiles.h (ALL_OBJSECTIONS): Remove.
14411         * maint.c (maintenance_translate_address): Use all_objfiles.
14412         * gcore.c (gcore_create_callback): Use all_objfiles.
14413         (objfile_find_memory_regions): Likewise.
14414
14415 2019-01-09  Tom Tromey  <tom@tromey.com>
14416
14417         * symtab.c (find_line_symtab, info_sources_command)
14418         (make_source_files_completion_list): Use objfile_compunits.
14419         * source.c (select_source_symtab): Use objfile_compunits.
14420         * objfiles.h (struct objfile): Update comment.
14421         (ALL_OBJFILES): Remove.
14422         (ALL_FILETABS): Remove.
14423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14424         objfile_compunits.
14425
14426 2019-01-09  Tom Tromey  <tom@tromey.com>
14427
14428         * symmisc.c (print_objfile_statistics, dump_objfile)
14429         (maintenance_print_symbols): Use compunit_filetabs.
14430         * source.c (forget_cached_source_info_for_objfile): Use
14431         compunit_filetabs.
14432         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14433         (ALL_FILETABS): Use compunit_filetabs.
14434         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14435         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14436
14437 2019-01-09  Tom Tromey  <tom@tromey.com>
14438
14439         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14440         (compunit_filetabs): New.
14441         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14442         compunit_filetabs.
14443         (info_sources_command, make_source_files_completion_list): Remove
14444         declaration.
14445         * symmisc.c (print_objfile_statistics, dump_objfile)
14446         (maintenance_print_symbols): Remove declaration.
14447         (maintenance_info_symtabs): Use compunit_filetabs.
14448         (maintenance_info_line_tables): Likewise.
14449         * source.c (select_source_symtab): Change local variable name.
14450         (forget_cached_source_info_for_objfile): Remove declaration.
14451         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14452         * objfiles.c (objfile_relocate1): Remove declaration.
14453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14454         declaration.
14455         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14456         * coffread.c (coff_symtab_read): Remove declaration.
14457         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14458         compunit_filetabs.
14459
14460 2019-01-09  Tom Tromey  <tom@tromey.com>
14461
14462         * symtab.c (lookup_objfile_from_block)
14463         (find_pc_sect_compunit_symtab, search_symbols)
14464         (default_collect_symbol_completion_matches_break_on): Use
14465         objfile_compunits.
14466         * objfiles.h (ALL_COMPUNITS): Remove.
14467         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14468         * cp-support.c (add_symbol_overload_list_qualified): Use
14469         objfile_compunits.
14470         * ada-lang.c (ada_collect_symbol_completion_matches)
14471         (ada_add_global_exceptions): Use objfile_compunits.
14472
14473 2019-01-09  Tom Tromey  <tom@tromey.com>
14474
14475         * source.c (select_source_symtab)
14476         (forget_cached_source_info_for_objfile): Remove declaration.
14477         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14478         declaration.
14479         * maint.c (count_symtabs_and_blocks): Remove declaration.
14480         * cp-support.c (add_symbol_overload_list_qualified): Remove
14481         declaration.
14482         * coffread.c (coff_symtab_read): Remove declaration.
14483         * symtab.c (lookup_symbol_in_objfile_symtabs)
14484         (basic_lookup_transparent_type_1): Use objfile_compunits.
14485         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14486         (info_sources_command, search_symbols)
14487         (default_collect_symbol_completion_matches_break_on)
14488         (make_source_files_completion_list): Remove declaration.
14489         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14490         (ada_collect_symbol_completion_matches)
14491         (ada_add_global_exceptions): Remove declaration.
14492         * linespec.c (iterate_over_all_matching_symtabs): Use
14493         objfile_compunits.
14494         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14495         (class objfile_compunits): New.
14496         (ALL_COMPUNITS): Use objfile_compunits.
14497         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14498         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14499         objfile_compunits.
14500         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14501
14502 2019-01-09  Tom Tromey  <tom@tromey.com>
14503
14504         * symtab.c (search_symbols)
14505         (default_collect_symbol_completion_matches_break_on): Use
14506         objfile_msymbols.
14507         * ada-lang.c (ada_lookup_simple_minsym)
14508         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14509         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14510         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14511         objfile_msymbols.
14512         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14513         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14514         * objc-lang.c (find_methods): Use objfile_msymbols.
14515         (info_selectors_command, info_classes_command): Likewise.
14516         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14517         * objfiles.h (class objfile_msymbols): New.
14518         (ALL_OBJFILE_MSYMBOLS): Remove.
14519         (ALL_MSYMBOLS): Remove.
14520
14521 2019-01-09  Tom Tromey  <tom@tromey.com>
14522
14523         * common/next-iterator.h (next_adapter): Add Iterator template
14524         parameter.
14525         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14526         (class all_objfiles_safe): New.
14527         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14528         * objfiles.c (put_objfile_before): Update comment.
14529         (add_separate_debug_objfile): Likewise.
14530         (free_all_objfiles): Use all_objfiles_safe.
14531         (objfile_purge_solibs): Likewise.
14532
14533 2019-01-09  Tom Tromey  <tom@tromey.com>
14534
14535         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14536         (expand_symtab_containing_pc, lookup_static_symbol)
14537         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14538         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14539         all_objfiles.
14540         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14541         * breakpoint.c (create_overlay_event_breakpoint)
14542         (create_longjmp_master_breakpoint)
14543         (create_std_terminate_master_breakpoint)
14544         (create_exception_master_breakpoint): Use all_objfiles.
14545         * linux-thread-db.c (try_thread_db_load_from_pdir)
14546         (has_libpthread): Use all_objfiles.
14547         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14548         * linespec.c (iterate_over_all_matching_symtabs)
14549         (search_minsyms_for_name): Use all_objfiles.
14550         * maint.c (maintenance_info_sections): Use all_objfiles.
14551         * main.c (captured_main_1): Use all_objfiles.
14552         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14553         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14554         * guile/scm-pretty-print.c
14555         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14556         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14557         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14558         (maintenance_print_msymbols): Use all_objfiles.
14559         * source.c (select_source_symtab): Use all_objfiles.
14560         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14561         * symfile.c (remove_symbol_file_command)
14562         (expand_symtabs_matching, map_symbol_filenames): Use
14563         all_objfiles.
14564         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14565         all_objfiles.
14566         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14567         * objc-lang.c (find_methods): Use all_objfiles.
14568         * objfiles.c (have_partial_symbols, have_full_symbols)
14569         (have_minimal_symbols, qsort_cmp)
14570         (default_iterate_over_objfiles_in_search_order): Use
14571         all_objfiles.
14572         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14573         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14574         (maintenance_check_psymtabs): Use all_objfiles.
14575         (ALL_PSYMTABS): Remove.
14576         * compile/compile-object-run.c (do_module_cleanup): Use
14577         all_objfiles.
14578         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14579         * cp-support.c (add_symbol_overload_list_qualified): Use
14580         all_objfiles.
14581         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14582         Use all_objfiles.
14583         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14584         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14585         all_objfiles.
14586         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14587         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14588         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14589         Uses all_objfiles.
14590         * solib.c (solib_read_symbols): Use all_objfiles
14591
14592 2019-01-09  Tom Tromey  <tom@tromey.com>
14593
14594         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14595         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14596         all_objfiles.
14597         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14598         * symmisc.c (print_symbol_bcache_statistics)
14599         (print_objfile_statistics, maintenance_print_objfiles)
14600         (maintenance_info_symtabs, maintenance_check_symtabs)
14601         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14602         all_objfiles.
14603         * source.c (forget_cached_source_info): Use all_objfiles.
14604         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14605         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14606         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14607         * objfiles.c (update_section_map): Use all_objfiles.
14608         (shared_objfile_contains_address_p): Likewise.
14609         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14610         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14611
14612 2019-01-09  Tom Tromey  <tom@tromey.com>
14613
14614         * common/next-iterator.h: New file.
14615         * objfiles.h (class all_objfiles): New.
14616         (struct objfile_iterator): New.
14617
14618 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14619
14620         * NEWS: Move the description of the changed "frame", "select-frame",
14621          and "info frame" commands to the Changed commands section.
14622
14623 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14624
14625         * gdbtypes.c (check_stub_method_group): Remove handling of old
14626         mangling schemes.
14627         * linespec.c (find_methods): Likewise.
14628         * stabsread.c (read_member_functions): Likewise.
14629         * valops.c (search_struct_method): Likewise.
14630         (value_struct_elt_for_reference): Likewise.
14631         * NEWS: Mention this change.
14632
14633 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14634
14635         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14636         print_source_lines.
14637         * source.c (print_source_lines_base): Update line number check.
14638         (print_source_lines): New function.
14639         (source_lines_range::source_lines_range): New function.
14640         * source.h (class source_lines_range): New class.
14641         (print_source_lines): New declaration.
14642
14643 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14644
14645         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14646
14647 2019-01-08  Tom Tromey  <tom@tromey.com>
14648             Simon Marchi  <simon.marchi@ericsson.com>
14649
14650         PR gdb/24060
14651         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14652         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14653         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14654         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14655         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14656         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14657
14658 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14659
14660         * source.c (select_source_symtab): Move header comment to
14661         declaration in source.h.
14662         (forget_cached_source_info_for_objfile): Likewise.
14663         (forget_cached_source_info): Likewise.
14664         (identify_source_line): Likewise.
14665         * source.h (identify_source_line): Move declaration from symtab.h
14666         and add comment from source.c
14667         (print_source_lines): Likewise.
14668         (forget_cached_source_info_for_objfile): Likewise.
14669         (forget_cached_source_info): Likewise.
14670         (select_source_symtab): Likewise.
14671         (enum print_source_lines_flag): Move definition from symtab.h.
14672         * symtab.h (identify_source_line): Move declaration to source.h.
14673         (print_source_lines): Likewise.
14674         (forget_cached_source_info_for_objfile): Likewise.
14675         (forget_cached_source_info): Likewise.
14676         (select_source_symtab): Likewise.
14677         (enum print_source_lines_flag): Move definition to source.h.
14678         * tui/tui-hooks.c: Add 'source.h' include.
14679
14680 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14681
14682         * source.c (print_source_lines_base): Handle requests to print
14683         reverse line number sequences, and guard against empty lines
14684         string.
14685
14686 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14687
14688         * source.c (print_source_lines_base): Fix skip of '\r' if next
14689         character is '\n'.
14690
14691 2019-01-06  Tom Tromey  <tom@tromey.com>
14692
14693         * c-exp.y (struct c_parse_state) <macro_original_text,
14694         expansion_obstack>: New member.
14695         (macro_original_text, expansion_obstack): Remove globals.
14696         (scan_macro_expansion, scanning_macro_expansion)
14697         (finished_macro_expansion): Update.
14698         (scan_macro_cleanup): Remove.
14699         (yylex, c_parse): Update.
14700
14701 2019-01-06  Tom Tromey  <tom@tromey.com>
14702
14703         * c-exp.y (struct c_parse_state) <strings>: New member.
14704         (operator_stoken): Update.
14705
14706 2019-01-06  Tom Tromey  <tom@tromey.com>
14707
14708         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14709         (union type_stack_elt) <typelist_val>: Now a pointer to
14710         std::vector.
14711         (type_stack_cleanup): Don't declare.
14712         (push_typelist): Update.
14713         * parse.c (pop_typelist): Return a std::vector.
14714         (push_typelist): Take a std::vector.
14715         (follow_types): Update.  Do not free args.
14716         (type_stack_cleanup): Remove.
14717         * c-exp.y (struct c_parse_state): New.
14718         (cpstate): New global.
14719         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14720         (nonempty_typelist): Update.
14721         (func_mod): Create a new vector.
14722         (c_parse): Create a c_parse_state.
14723         (check_parameter_typelist): Do not delete params.
14724         (function_method): Update.  Do not delete type_list.
14725
14726 2019-01-06  Tom Tromey  <tom@tromey.com>
14727
14728         PR gdb/28155:
14729         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14730         check_typedef.
14731         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14732         (print_return_value): Likewise.
14733
14734 2019-01-05  Tom Tromey  <tom@tromey.com>
14735
14736         * contrib/cleanup_check.py: Remove.
14737         * contrib/gcc-with-excheck: Remove.
14738         * contrib/exsummary.py: Remove.
14739         * contrib/excheck.py: Remove.
14740
14741 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14742
14743         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14744         NULL. Initialize tpprev to NULL instead of assigning it
14745         to NULL on the next statement.
14746         * windows-nat.c (windows_delete_thread): Remove check for
14747         main_thread_id before printing thread exit notifications.
14748         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14749         Remove thread ID check against main_thread_id.
14750         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14751         windows_delete_thread.
14752         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14753
14754 2019-01-04  Tom Tromey  <tom@tromey.com>
14755
14756         * compile/compile.c (_initialize_compile): Use upper case for
14757         metasyntactic variables.
14758         * symmisc.c (_initialize_symmisc): Use upper case for
14759         metasyntactic variables.
14760         * psymtab.c (_initialize_psymtab): Use upper case for
14761         metasyntactic variables.
14762         * demangle.c (demangle_command): Use upper case for metasyntactic
14763         variables.
14764         (_initialize_demangler): Likewise.
14765         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14766         variables.
14767
14768 2019-01-03  Tom Tromey  <tom@tromey.com>
14769
14770         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14771
14772 2019-01-03  Tom Tromey  <tom@tromey.com>
14773
14774         * python/py-symtab.c (salpy_str): Update.
14775         (struct salpy_sal_object) <symtab>: Now a PyObject.
14776         (salpy_dealloc): Update.
14777         (del_objfile_sal): Use gdbpy_ref.
14778
14779 2019-01-03  Tom Tromey  <tom@tromey.com>
14780
14781         * python/py-type.c (convert_field): Use new_reference.  Return
14782         gdbpy_ref.
14783         (make_fielditem): Return gdbpy_ref.
14784         (typy_fields): Update.
14785         (typy_getitem): Update.
14786         (field_name): Return gdbpy_ref.  Use new_reference.
14787         (typy_iterator_iternext): Update.
14788
14789 2019-01-03  Tom Tromey  <tom@tromey.com>
14790
14791         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14792
14793 2019-01-03  Tom Tromey  <tom@tromey.com>
14794
14795         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14796         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14797         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14798         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14799         (pspy_set_type_printers): Likewise.
14800         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14801         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14802         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14803         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14804         (objfpy_set_type_printers): Likewise.
14805
14806 2019-01-03  Tom Tromey  <tom@tromey.com>
14807
14808         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14809         (gdbpy_print_stack): Use gdbpy_err_fetch.
14810         * python/python-internal.h (class gdbpy_err_fetch): New class.
14811         (class gdbpy_enter) <m_error_type, m_error_value,
14812         m_error_traceback>: Remove.
14813         <m_error>: New member.
14814         (gdbpy_exception_to_string): Don't declare.
14815         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14816         * python/py-value.c (convert_value_from_python): Use
14817         gdbpy_err_fetch.
14818         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14819         gdbpy_exception_to_string.
14820         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14821         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14822         gdbpy_err_fetch.
14823
14824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14825
14826         * linux-nat.c (delete_lwp_cleanup): Delete.
14827         (struct lwp_deleter): New struct.
14828         (lwp_info_up): New typedef.
14829         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14830         lwp_info_up.
14831
14832 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14833
14834         * linux-fork.c (class scoped_switch_fork_info): New class.
14835         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14836
14837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14838
14839         * valops.c (find_overload_match): Remove use of null_cleanup, and
14840         calls to do_cleanups.
14841
14842 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14843
14844         * compile/compile-cplus-types.c
14845         (compile_cplus_instance::decl_name): Handle changes to
14846         cp_func_name.
14847         * cp-support.c (cp_func_name): Update header comment, update
14848         return type.
14849         * cp-support.h (cp_func_name): Update return type in declaration.
14850         * valops.c (find_overload_match): Move temp_func local to top
14851         level of function and change its type.  Use temp_func to hold and
14852         delete temporary string obtained from cp_func_name.
14853
14854 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14855
14856         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14857         gdb::char_vector, remove cleanup, and update uses of `msg`.
14858
14859 2019-01-03  Jim Wilson  <jimw@sifive.com>
14860
14861         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14862
14863 2019-01-02  Tom Tromey  <tom@tromey.com>
14864
14865         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14866         (tdesc_parse_xml): Remove cleanups.
14867         * target-descriptions.h (make_cleanup_free_target_description):
14868         Don't declare.
14869         (target_desc_deleter): New struct.
14870         (target_desc_up): New typedef.
14871         * target-descriptions.c (target_desc_deleter::operator()): Rename
14872         from free_target_description.
14873         (make_cleanup_free_target_description): Remove.
14874
14875 2019-01-02  Tom Tromey  <tom@tromey.com>
14876
14877         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14878         constructor, destructor.
14879         (linespec_parser): Remove typedef.
14880         (~linespec_parser): Rename from linespec_parser_delete.
14881         (linespec_lex_to_end, linespec_complete_label)
14882         (linespec_complete): Update.
14883         (decode_line_full): Remove cleanups.
14884         (decode_line_1): Update.
14885
14886 2019-01-02  Tom Tromey  <tom@tromey.com>
14887
14888         * python/python-internal.h (inferior_to_inferior_object): Change
14889         return type.
14890         * python/py-exitedevent.c (create_exited_event_object): Update.
14891         * python/py-inferior.c (inferior_to_inferior_object): Return
14892         gdbpy_ref.
14893         (python_new_inferior, python_inferior_deleted)
14894         (thread_to_thread_object, delete_thread_object)
14895         (build_inferior_list, gdbpy_selected_inferior): Update.
14896         * python/py-infthread.c (create_thread_object): Update.  Also fail
14897         if inferior_to_inferior_object fails.
14898
14899 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14900
14901         * inferior.h (class inferior) <displaced_step_state>: New field.
14902         * infrun.h (struct displaced_step_state): Move here from
14903         infrun.c.  Initialize fields, add constructor.
14904         <inf>: Remove field.
14905         <reset>: New method.
14906         * infrun.c (struct displaced_step_inferior_state): Move to
14907         infrun.h.
14908         (displaced_step_inferior_states): Remove.
14909         (get_displaced_stepping_state): Adust.
14910         (displaced_step_in_progress_any_inferior): Adjust.
14911         (displaced_step_in_progress_thread): Adjust.
14912         (displaced_step_in_progress): Adjust.
14913         (add_displaced_stepping_state): Remove.
14914         (get_displaced_step_closure_by_addr): Adjust.
14915         (remove_displaced_stepping_state): Remove.
14916         (infrun_inferior_exit): Call displaced_step_state.reset.
14917         (use_displaced_stepping): Don't check for NULL.
14918         (displaced_step_prepare_throw): Call
14919         get_displaced_stepping_state.
14920         (displaced_step_fixup): Don't check for NULL.
14921         (prepare_for_detach): Don't check for NULL.
14922
14923 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14924
14925         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14926          in case of call that did not complete.
14927
14928 2019-01-02  Andrey Utkin  <autkin@undo.io>
14929
14930         * symfile.c (find_separate_debug_file): Fix search of debug files for
14931         remote debuggee.
14932
14933 2019-01-02  Tom Tromey  <tom@tromey.com>
14934
14935         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14936         indentation.
14937         * python/py-frame.c (frapy_older): Remove cast.
14938         (frapy_newer): Likewise.
14939         * python/py-breakpoint.c (local_setattro): Remove cast.
14940         * python/py-arch.c (archpy_name): Remove local variable.
14941         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14942
14943 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14944
14945         * unittests/basic_string_view/element_access/char/empty.cc:
14946         Fix year range in copyright header.
14947
14948 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14949
14950         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14951         Delete.
14952         <operator==>: Update with for removed field.
14953         <hash>: Likewise.
14954         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14955         <isa_features>: ...this.
14956         <abi_features>: New field.
14957         (riscv_isa_flen): Update comment.
14958         (riscv_abi_xlen): New declaration.
14959         (riscv_abi_flen): New declaration.
14960         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14961         isa_features.
14962         (riscv_abi_xlen): New function.
14963         (riscv_isa_flen): Update to get answer from isa_features.
14964         (riscv_abi_flen): New function.
14965         (riscv_has_fp_abi): Update to get answer from abi_features.
14966         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14967         xlen and flen.
14968         (riscv_call_info) <xlen, flen>: Update comment.
14969         (riscv_call_arg_struct): Remove invalid assertions
14970         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14971         is removed.
14972         (riscv_gdbarch_init): Gather isa features and abi features
14973         separately, ensure both match on the gdbarch when reusing an old
14974         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14975         a target with 64-bit float hardware.
14976
14977 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14978
14979         * source.c (search_command_helper): Stop reverse search
14980         when line 1 has been searched.
14981
14982 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14983
14984         * record-full.c (record_full_base_target::close): Rewrite
14985         record_full_core_buf_list free logic.
14986
14987 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14988
14989         * break-catch-syscall.c (print_one_catch_syscall): xfree
14990         the last text.
14991
14992 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14993
14994         * top.c (print_gdb_version): Update Copyright year in version
14995         message.
14996
14997 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14998
14999         Update copyright year range in all GDB files.
15000
15001 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15002
15003         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15004
15005 For older changes see ChangeLog-2018.
15006 \f
15007 Local Variables:
15008 mode: change-log
15009 left-margin: 8
15010 fill-column: 74
15011 version-control: never
15012 coding: utf-8
15013 End:
15014