gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
   4         (tui_display_registers_from, tui_check_register_values): Update.
   5         (tui_display_register): Remove win_info parameter; update.
   6         (tui_get_register): Change type of parameters.
   7         * tui/tui-data.h (struct tui_data_element): Remove.
   8         (union tui_which_element) <data>: Remove.
   9         <data_window>: Change type.
  10         (struct tui_data_item_window): New.
  11         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
  12         case.  Add assert.
  13         (~tui_data_item_window): New destructor.
  14         (free_content_elements): Remove DATA_ITEM_WIN case.
  15
  16 2019-06-25  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
  19         Remove.
  20
  21 2019-06-25  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-data.h (struct tui_command_element): Remove.
  24         (union tui_which_element) <command>: Remove.
  25         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
  26         assert.
  27         (free_content_elements): Remove CMD_WIN case.
  28
  29 2019-06-25  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-layout.c (tui_set_layout): Update.
  32         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
  33         * tui/tui-data.c (layout_def): Update.
  34
  35 2019-06-25  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-wingeneral.c (tui_refresh_all): Update.
  38         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  39         (tui_source_window_base::set_new_height): Update.
  40         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
  41         Update.
  42         (tui_set_locator_fullname, tui_set_locator_info)
  43         (tui_show_frame_info): Update.
  44         * tui/tui-source.c (tui_set_source_content)
  45         (tui_source_is_displayed): Update.
  46         * tui/tui-layout.c (show_source_disasm_command, show_data)
  47         (show_source_or_disasm_and_command): Update.
  48         * tui/tui-disasm.c (tui_set_disassem_content)
  49         (tui_get_begin_asm_address): Update.
  50         * tui/tui-data.h (struct tui_locator_element): Remove.
  51         (union tui_which_element) <locator>: Remove.
  52         (struct tui_locator_window): New.
  53         (tui_locator_win_info_ptr): Change return type.
  54         * tui/tui-data.c (_locator): Change type.
  55         (tui_locator_win_info_ptr): Change return type.
  56         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
  57         (tui_alloc_content): Add assert.
  58
  59 2019-06-25  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-winsource.c
  62         (tui_exec_info_window::maybe_allocate_content): New method.
  63         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
  64         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
  65         (make_source_or_disasm_window): Add cast.
  66         * tui/tui-data.h (union tui_which_element) <simple_string>:
  67         Remove.
  68         (struct tui_source_info): New.
  69         (struct tui_source_window_base) <execution_info>: Change type.
  70         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
  71         case, and add assert.
  72         (tui_alloc_content): Add assert.
  73
  74 2019-06-25  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
  77         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
  78         * tui/tui-data.c (tui_alloc_win_info): Remove.
  79
  80 2019-06-25  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
  83         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
  84         can_highlight.
  85
  86 2019-06-25  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
  89         make_visible_with_new_height method.
  90         (tui_win_info::make_visible_with_new_height): New method.
  91         (tui_source_window_base::do_make_visible_with_new_height)
  92         (tui_data_window::do_make_visible_with_new_height)
  93         (tui_cmd_window::do_make_visible_with_new_height): New methods.
  94         (make_visible_with_new_height): Remove.
  95         (tui_resize_all, tui_adjust_win_heights): Use
  96         make_visible_with_new_height method.
  97         * tui/tui-data.h (struct tui_win_info)
  98         <do_make_visible_with_new_height, make_visible_with_new_height>:
  99         New methods.
 100         (struct tui_source_window_base, struct tui_data_window)
 101         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 102         methods.
 103
 104 2019-06-25  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 107         method.
 108         (update_tab_width): Call update_tab_width method.
 109         * tui/tui-data.h (struct tui_win_info)
 110         (struct tui_source_window_base) <update_tab_width>: New methods.
 111
 112 2019-06-25  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 115         parameter.
 116         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 117         parameter.
 118         (tui_gen_win_info::make_visible): Update.
 119         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 120         parameter.
 121         * tui/tui-data.h (enum tui_box): New enum.
 122         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 123
 124 2019-06-25  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 127         init_and_make_win for EXEC_INFO_WIN.
 128         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 129         longer inline.
 130         (struct tui_win_info) <~tui_win_info>: Inline.
 131         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 132         Don't declare.
 133         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 134         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 135         Remove.
 136         (tui_initialize_static_data): Update.
 137         (~tui_gen_win_info): Handle more cleanup here.
 138         (~tui_source_window_base): Delete "execution_info".
 139         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 140
 141 2019-06-25  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-layout.c (make_command_window): Don't set
 144         can_highlight.
 145         (show_source_disasm_command): Call the reset method.
 146         (show_data): Don't set can_highlight.  Call the reset method.
 147         (tui_gen_win_info::reset): Rename from init_gen_win_info
 148         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 149         (show_source_or_disasm_and_command): Call the reset method.
 150         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 151         (struct tui_cmd_window): Set can_highlight.
 152
 153 2019-06-25  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 156         from make_visible.
 157         (tui_make_visible, tui_make_invisible): Rewrite.
 158         (tui_win_info::make_visible): Remove.
 159         (tui_source_window_base::make_visible): Update.
 160         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 161         method.  Moved from...
 162         (struct tui_win_info) <make_visible>: ...here.
 163
 164 2019-06-25  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-winsource.c
 167         (tui_source_window_base::do_scroll_horizontal): Remove direction
 168         parameter.
 169         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 170         direction parameter.
 171         * tui/tui-win.c (tui_win_info::forward_scroll)
 172         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 173         (tui_win_info::right_scroll): Update.
 174         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 175         direction parameter.
 176         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 177         direction parameter.
 178         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 179         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 180         Remove direction parameter.
 181         (struct tui_source_window_base, struct tui_source_window)
 182         (struct tui_disasm_window, struct tui_data_window)
 183         (struct tui_cmd_window): Update.
 184
 185 2019-06-25  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-winsource.h (tui_set_exec_info_content)
 188         (tui_show_exec_info_content, tui_erase_exec_info_content)
 189         (tui_clear_exec_info_content, tui_update_exec_info): Change
 190         argument to tui_source_window_base.
 191         * tui/tui-winsource.c (tui_set_exec_info_content)
 192         (tui_show_exec_info_content, tui_erase_exec_info_content)
 193         (tui_clear_exec_info_content, tui_update_exec_info): Change
 194         argument to tui_source_window_base.
 195
 196 2019-06-25  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 199         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 200
 201 2019-06-25  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 204         check.
 205
 206 2019-06-25  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 209         type to void.
 210         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 211         type to void.
 212         * tui/tui-source.c (tui_set_source_content): Update.
 213         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 214
 215 2019-06-25  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-win.c (window_name_completer, tui_set_focus)
 218         (tui_all_windows_info): Use name method.
 219         * tui/tui-data.h (struct tui_gen_win_info)
 220         (struct tui_source_window, struct tui_disasm_window)
 221         (struct tui_data_window, struct tui_cmd_window) <name>: New
 222         method.
 223         (tui_win_name): Don't declare.
 224         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 225         (tui_win_name): Remove.
 226
 227 2019-06-25  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-winsource.h (tui_update_source_window)
 230         (tui_update_source_window_as_is): Change parameter type.
 231         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 232         to be a tui_source_window_base.
 233         (tui_update_source_window_as_is): Likewise.
 234         * tui/tui-win.c (make_visible_with_new_height): Update.
 235
 236 2019-06-25  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-winsource.c (tui_erase_source_content)
 239         (tui_show_source_content, tui_show_exec_info_content)
 240         (tui_erase_exec_info_content): Use refresh_window method.
 241         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 242         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 243         from tui_refresh_win.
 244         (tui_data_window::refresh_window): New method.
 245         (tui_win_info::refresh, tui_source_window_base::refresh)
 246         (tui_refresh_all): Use refresh_window method.
 247         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 248         method.
 249         * tui/tui-regs.c (tui_display_register): Call refresh_window
 250         method.
 251         * tui/tui-layout.c (show_source_disasm_command)
 252         (show_source_or_disasm_and_command): Call refresh_window method.
 253         * tui/tui-data.h (struct tui_gen_win_info)
 254         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 255         New method.
 256
 257 2019-06-25  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui.c (tui_rl_other_window, tui_enable)
 260         (tui_is_window_visible, tui_get_command_dimension): Update.
 261         * tui/tui-winsource.c (tui_update_source_window_as_is)
 262         (tui_clear_source_content, tui_erase_source_content)
 263         (tui_show_source_line, tui_source_window_base::refill)
 264         (tui_source_window_base::do_scroll_horizontal)
 265         (tui_source_window_base::set_is_exec_point_at)
 266         (tui_update_breakpoint_info, tui_set_exec_info_content)
 267         (tui_alloc_source_buffer, tui_line_is_displayed)
 268         (tui_addr_is_displayed): Update.
 269         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 270         (tui_check_and_display_highlight_if_needed)
 271         (tui_win_info::make_visible, tui_win_info::refresh)
 272         (tui_refresh_all): Update.
 273         * tui/tui-windata.c (tui_first_data_item_displayed)
 274         (tui_delete_data_content_windows, tui_erase_data_content)
 275         (tui_display_all_data, tui_data_window::refresh_all)
 276         (tui_check_data_values): Update.
 277         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 278         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 279         (tui_win_info::backward_scroll, tui_refresh_all_win)
 280         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 281         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 282         (tui_source_window_base::set_new_height)
 283         (tui_data_window::set_new_height)
 284         (make_invisible_and_set_new_height)
 285         (make_visible_with_new_height, new_height_ok)
 286         (parse_scrolling_args): Update.
 287         * tui/tui-stack.c (tui_show_frame_info): Update.
 288         * tui/tui-source.c (tui_set_source_content)
 289         (tui_set_source_content_nil, tui_source_is_displayed)
 290         (tui_source_window::do_scroll_vertical): Update.
 291         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 292         (tui_display_registers_from, tui_display_reg_element_at_line)
 293         (tui_check_register_values, tui_reg_command): Update.
 294         * tui/tui-layout.c (tui_default_win_height)
 295         (show_source_disasm_command, show_data, init_and_make_win)
 296         (show_source_or_disasm_and_command): Update.
 297         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 298         (tui_redisplay_readline, tui_mld_flush)
 299         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 300         (tui_getc): Update.
 301         * tui/tui-disasm.c (tui_set_disassem_content)
 302         (tui_disasm_window::do_scroll_vertical): Update.
 303         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 304         Now virtual.
 305         (struct tui_win_info): Derive from tui_gen_win_info.
 306         <~tui_win_info>: Mark as override.
 307         <generic>: Remove member.
 308         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 309         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 310         (~tui_data_window, ~tui_win_info)
 311         (tui_free_all_source_wins_content): Update.
 312         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 313
 314 2019-06-25  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-layout.c (init_and_make_win): Use new.
 317         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 318         destructor, initializers.
 319         (tui_alloc_generic_win_info): Don't declare.
 320         * tui/tui-data.c (_locator): Add argument to constructor.
 321         (source_win, disasm_win): New globals.
 322         (exec_info): Remove.
 323         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 324         Update.
 325         (tui_alloc_generic_win_info): Remove.
 326         (init_content_element): Use new.
 327         (tui_win_info::tui_win_info): Update.
 328         (free_content_elements) <case DATA_WIN>: Use delete.
 329
 330 2019-06-25  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 333         * tui/tui-windata.c (tui_first_data_item_displayed)
 334         (tui_delete_data_content_windows): Update.
 335         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 336         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 337         (tui_display_registers_from, tui_check_register_values): Update.
 338         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 339         pointer.
 340         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 341         window.
 342         (tui_free_data_content): Update.
 343         (free_content_elements) <case DATA_WIN>: Free the window.
 344
 345 2019-06-25  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 348         Update.
 349         * tui/tui-layout.c (make_command_window)
 350         (show_source_disasm_command, show_data, init_and_make_win)
 351         (show_source_or_disasm_and_command): Update.
 352         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 353         method.
 354         <can_highight, is_highlighted>: Now bool.
 355         (tui_set_win_highlight): Don't declare.
 356         * tui/tui-data.c (tui_set_win_highlight): Remove.
 357
 358 2019-06-25  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-wingeneral.c (make_visible): Remove check of window
 361         type.
 362
 363 2019-06-25  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-win.c (tui_win_info::max_height)
 366         (tui_cmd_window::max_height): New methods.
 367         (new_height_ok): Call max_height.
 368         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 369         <max_height>: New method.
 370
 371 2019-06-25  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-win.c (tui_source_window_base::set_new_height)
 374         (tui_data_window::set_new_height): New methods.
 375         (make_invisible_and_set_new_height): Call set_new_height method.
 376         * tui/tui-data.h (struct tui_win_info)
 377         (struct tui_source_window_base, struct tui_data_window)
 378         <set_new_height>: New method.
 379
 380 2019-06-25  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 383         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 384         tui_refresh_data_win.
 385         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 386         method.
 387         (tui_refresh_all_win): Call the refresh_all method.
 388         (tui_set_focus): Likewise.
 389         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 390         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 391         Likewise.
 392
 393 2019-06-25  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-winsource.h (tui_refill_source_window)
 396         (tui_set_is_exec_point_at): Don't declare.
 397         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 398         (tui_source_window_base::refill): Rename from
 399         tui_refill_source_window.
 400         (tui_source_window_base::do_scroll_horizontal): Update.
 401         (tui_source_window_base::set_is_exec_point_at): Rename from
 402         tui_set_is_exec_point_at.
 403         (tui_update_all_breakpoint_info): Update.
 404         * tui/tui-stack.c (tui_show_frame_info): Update.
 405         * tui/tui-layout.c (show_data): Add cast.
 406         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 407         * tui/tui-data.h (struct tui_source_window_base) <refill,
 408         set_is_exec_point_at>: New methods.
 409         (tui_source_windows, tui_add_to_source_windows): Update types.
 410         (tui_add_to_source_windows): Remove redundant declaration.
 411         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 412         (tui_source_windows): Change return type.
 413         (tui_clear_source_windows_detail): Update.
 414         (tui_add_to_source_windows): Change type of parameter.
 415         (tui_free_all_source_wins_content): Update.
 416
 417 2019-06-25  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-wingeneral.c (tui_win_info::refresh)
 420         (tui_source_window_base::refresh): New methods.
 421         (tui_refresh_all): Call the refresh method.
 422         * tui/tui-data.h (struct tui_win_info)
 423         (struct tui_source_window_base) <refresh>: New method.
 424
 425 2019-06-25  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui.h (tui_is_window_visible): Return bool.
 428         * tui/tui.c (tui_is_window_visible): Return bool.
 429         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 430         (tui_make_visible, tui_make_invisible)
 431         (tui_win_info::make_visible)
 432         (tui_source_window_base::make_visible, make_all_visible)
 433         (tui_make_all_visible, tui_make_all_invisible): Update.
 434         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 435         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 436         bool.
 437         (struct tui_win_info, struct tui_source_window_base)
 438         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 439         * tui/tui-data.c (tui_init_generic_part): Update.
 440
 441 2019-06-25  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 444         (tui_source_window_base::make_visible): New methods.
 445         (make_all_visible): Make method call.
 446         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 447         (struct tui_source_window_base, struct tui_cmd_window): Override
 448         make_visible.
 449         (tui_win_is_source_type): Don't declare.
 450         * tui/tui-data.c (tui_win_is_source_type): Remove.
 451
 452 2019-06-25  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 455         NULL check.
 456
 457 2019-06-25  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 460         Inline constructor.  Add initializers for members.
 461         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 462         constructors; now inline in class.
 463
 464 2019-06-25  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-regs.c (tui_show_registers): Update.
 467         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 468         bool.
 469         * tui/tui-data.c (tui_data_window::clear_detail)
 470         (tui_data_window): Update.
 471
 472 2019-06-25  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-windata.c (tui_display_all_data)
 475         (tui_display_data_from_line, tui_display_data_from)
 476         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 477         Update.
 478         * tui/tui-regs.c (tui_last_regs_line_no)
 479         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 480         (tui_show_registers, tui_show_register_group)
 481         (tui_display_registers_from, tui_display_reg_element_at_line)
 482         (tui_display_registers_from_line, tui_check_register_values)
 483         (tui_reg_next, tui_reg_prev): Update.
 484         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 485         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 486         tui_data_window.
 487         (struct tui_win_info) <detail>: Remove.  Add new fields from
 488         tui_data_info.
 489         (TUI_DATA_WIN): Add cast.
 490         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 491         (~tui_data_window): Simplify.
 492
 493 2019-06-25  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-layout.c (show_source_disasm_command)
 496         (show_source_or_disasm_and_command): Update.
 497         * tui/tui-io.c (update_cmdwin_start_line)
 498         (tui_redisplay_readline): Update.
 499         * tui/tui-data.h (struct tui_command_info): Remove.
 500         (struct tui_win_info) <detail>: Remove command_info member.
 501         (struct tui_data_window) <start_line>: New member, from
 502         tui_command_info.
 503         (TUI_CMD_WIN): Add casts.
 504
 505 2019-06-25  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-winsource.c (tui_update_source_window)
 508         (tui_refill_source_window)
 509         (tui_source_window_base::do_scroll_horizontal)
 510         (tui_update_breakpoint_info, tui_set_exec_info_content)
 511         (tui_show_exec_info_content, tui_erase_exec_info_content)
 512         (tui_clear_exec_info_content): Update.
 513         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 514         Update.
 515         * tui/tui-win.c (make_invisible_and_set_new_height)
 516         (make_visible_with_new_height): Update.
 517         * tui/tui-source.c (tui_set_source_content)
 518         (tui_show_symtab_source): Update.
 519         * tui/tui-layout.c (extract_display_start_addr)
 520         (show_source_disasm_command, show_data)
 521         (make_source_or_disasm_window)
 522         (show_source_or_disasm_and_command): Update.
 523         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 524         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 525         "gdbarch".
 526         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 527         to tui_source_window_base.
 528         (struct tui_win_info) <detail>: Remove source_info member.
 529         (struct tui_source_window_base) <has_locator>: Inline.
 530         Move contents from tui_source_info; rename has_locator member to
 531         m_has_locator.
 532         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 533         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 534         header file.
 535         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 536         Simplify.
 537         (tui_free_all_source_wins_content): Cast to
 538         tui_source_window_base.
 539
 540 2019-06-25  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-win.c (make_invisible_and_set_new_height)
 543         (make_visible_with_new_height): Call has_locator method.
 544         * tui/tui-layout.c (show_source_disasm_command, show_data)
 545         (show_source_or_disasm_and_command): Update for bool change.
 546         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 547         (tui_win_info) <has_locator>: New method.
 548         (struct tui_source_window_base) <has_locator>: New method.
 549         (tui_win_has_locator): Don't declare.
 550         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 551         from tui_win_has_locator.
 552         (tui_source_window_base): Use false, not FALSE.
 553
 554 2019-06-25  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 557         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 558         clear_detail method directly.
 559         (tui_clear_win_detail): Remove.
 560
 561 2019-06-25  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 564         "this", not TUI_DISASM_WIN.
 565
 566 2019-06-25  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 569         declare.
 570         * tui/tui-winsource.c
 571         (tui_source_window_base::do_scroll_horizontal): Rename from
 572         tui_horizontal_source_scroll.
 573         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 574         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 575         from tui_vertical_data_scroll.
 576         * tui/tui-win.h (tui_scroll): Don't declare.
 577         * tui/tui-win.c (tui_win_info::forward_scroll)
 578         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 579         (tui_win_info::right_scroll): Rename and update.
 580         (tui_scroll_forward_command, tui_scroll_backward_command)
 581         (tui_scroll_left_command, tui_scroll_right_command): Update.
 582         (tui_scroll): Remove.
 583         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 584         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 585         from tui_vertical_source_scroll.
 586         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 587         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 588         from tui_vertical_disassem_scroll.
 589         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 590         do_scroll_horizontal>: New methods.
 591         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 592         Likewise.
 593         (struct tui_source_window_base): Add do_scroll_horizontal.
 594         (struct tui_source_window, struct tui_disasm_window): Add
 595         do_scroll_vertical.
 596         (struct tui_data_window, struct tui_cmd_window): Add
 597         do_scroll_horizontal and do_scroll_vertical.
 598         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 599
 600 2019-06-25  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-data.h (struct tui_source_window_base): New struct.
 603         (struct tui_source_window): Derive from tui_source_window_base.
 604         (struct tui_disasm_window): New struct.
 605         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 606         from tui_source_window::clear_detail.
 607         (tui_source_window_base): Rename from tui_source_window.
 608         (~tui_source_window_base): Rename from ~tui_source_window.
 609         (tui_alloc_win_info): Create a tui_disasm_window.
 610
 611 2019-06-25  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-data.h (struct tui_source_window)
 614         (struct tui_data_window): Declare destructors.
 615         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 616         destructors.
 617         (tui_win_info): Simplify.
 618
 619 2019-06-25  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-winsource.c (tui_display_main)
 622         (tui_update_source_windows_with_addr)
 623         (tui_update_all_breakpoint_info): Update.
 624         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 625         (new_height_ok, parse_scrolling_args): Update.
 626         * tui/tui-stack.c (tui_show_frame_info): Update.
 627         * tui/tui-data.h (struct tui_list): Remove.
 628         (tui_source_windows): Return a reference to a std::vector.
 629         * tui/tui-data.c (source_windows): Now a std::vector.
 630         (tui_source_windows): Change return type.
 631         (tui_clear_source_windows): Rewrite.
 632         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 633         (tui_free_all_source_wins_content): Rewrite.
 634
 635 2019-06-25  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 638         (struct tui_data_window, struct tui_cmd_window): Declare
 639         clear_detail method.
 640         * tui/tui-data.c (tui_source_window::clear_detail)
 641         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 642         methods.
 643         (tui_clear_win_detail): Simplify.
 644
 645 2019-06-25  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-layout.c (make_source_window, make_disasm_window)
 648         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 649         Return the new window.
 650         (show_source_disasm_command, show_data)
 651         (show_source_or_disasm_and_command): Update.
 652
 653 2019-06-25  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 656         parameter.  Return the new window.
 657         (show_source_disasm_command): Update and remove NULL check.
 658         (show_source_or_disasm_and_command): Update.
 659
 660 2019-06-25  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 663
 664 2019-06-25  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-data.h (struct tui_win_info): Make constructor
 667         protected.  Make destructor virtual.  Add initializers.
 668         (tui_source_window, tui_data_window, tui_cmd_window): New
 669         classes.
 670         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 671         constructor.  Add "type" parameter.
 672         (tui_source_window, tui_data_window, tui_cmd_window): New
 673         constructors.
 674         (tui_alloc_win_info): Instantiate the appropriate subclass.
 675
 676 2019-06-25  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-win.c (tui_resize_all): Use delete.
 679         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 680         destructor.
 681         (tui_free_window): Don't declare.
 682         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 683         Update.
 684
 685 2019-06-25  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-data.h (struct tui_win_info): Add constructor.
 688         * tui/tui-data.c (tui_alloc_win_info): Use new.
 689         (tui_free_window): Use delete.
 690
 691 2019-06-22  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 694         declare.
 695         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 696
 697 2019-06-22  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 700         declare.
 701         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 702
 703 2019-06-22  Tom de Vries  <tdevries@suse.de>
 704
 705         * dwarf2read.c (create_addrmap_from_aranges)
 706         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 707         instead of '%zu'.
 708
 709 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 710
 711         * dwarf2read.h (dwarf2_section_info_def): Remove.
 712         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 713         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 714         std::vector<dwarf2_section_info>.
 715         (struct dwo_file) <~dwo_file>: Remove.
 716         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 717         types field.
 718         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 719         (dwarf2_read_debug_names): Likewise.
 720         (create_debug_types_hash_table): Change parameter type to
 721         array_view, adjust code accordingly.
 722         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 723         (partial_die_info::fixup): Likewise.
 724         (determine_prefix): Likewise.
 725         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 726
 727 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 728
 729         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 730         gdb_bfd_ref_ptr.
 731         <~dwo_file>: Remove call to gdb_bfd_unref.
 732         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 733         gdb_bfd_ref_ptr::get.
 734
 735 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 736
 737         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 738         type to htab_up.
 739         * dwarf2read.c (struct dwo_file): Initialize fields.
 740         <~dwo_file>: New.
 741         (free_dwo_file): Remove, move content to ~dwo_file.
 742         (struct dwo_file_deleter): Remove.
 743         (dwo_file_up>: Remove custom deleter.
 744         (free_dwo_files): Remove.
 745         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 746         dwo_files.
 747         (process_skeletonless_type_units): Call unique_ptr::get.
 748         (allocate_dwo_file_hash_table): Add deleter to created hash
 749         table.  Change return type to htab_up.
 750         (lookup_dwo_file_slot): Don't memset dwo_file, call
 751         unique_ptr::get.
 752         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 753         (create_dwo_unit_in_dwp_v2): Likewise.
 754         (open_and_init_dwo_file): Likewise.
 755         (free_dwo_file_from_slot): Remove.
 756
 757 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 758
 759         * dwarf2read.h (struct dwarf2_section_info) <readin,
 760         is_virtual>: Change type to bool.
 761         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 762         true instead of 1.
 763
 764 2019-06-19  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-data.h (tui_init_content_element): Don't declare.
 767
 768 2019-06-19  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui-data.h (tui_init_win_info): Don't declare.
 771
 772 2019-06-19  Tom de Vries  <tdevries@suse.de>
 773
 774         * dwarf2read.h (abstract_to_concrete): Change type to
 775         std::unordered_map<sect_offset, std::vector<sect_offset>,
 776         gdb::hash_enum<sect_offset>>.
 777
 778 2019-06-19  Tom Tromey  <tromey@adacore.com>
 779
 780         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 781         EVAL_AVOID_SIDE_EFFECTS specially.
 782
 783 2019-06-19  Tom Tromey  <tromey@adacore.com>
 784
 785         * source-cache.c (highlighter): New global.
 786         (source_cache::get_source_lines): Create a highlighter on demand.
 787
 788 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 789
 790         * defs.h (deprecated_interactive_hook): Delete declaration.
 791         * interps.c (clear_interpreter_hooks): Remove use of
 792         deprecated_interactive_hook.
 793         * top.c (deprecated_interactive_hook): Delete definition.
 794         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 795
 796 2019-06-18  Tom de Vries  <tdevries@suse.de>
 797
 798         PR gdb/24515
 799         * dwarf2read.h (abstract_to_concrete): Change type from
 800         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 801         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 802         * dwarf2read.c (read_variable): Update.
 803         (dwarf2_fetch_die_loc_sect_off): Update.
 804
 805 2019-06-17  Tom de Vries  <tdevries@suse.de>
 806
 807         PR gdb/24617
 808         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 809         accessing parent[parent_len - 1].
 810
 811 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 812
 813         PR gdb/24364
 814         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 815         call dtrace_process_dof with NULL dof.
 816
 817 2019-06-16  Tom de Vries  <tdevries@suse.de>
 818
 819         PR gdb/24445
 820         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 821
 822 2019-06-16  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 825         (make_all_visible): Use address of member.
 826
 827 2019-06-16  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 830         (tui_free_window, free_content, free_content_elements): Remove
 831         unnecessary cast.
 832         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 833         cast.
 834         * tui/tui-regs.c (tui_show_register_group)
 835         (tui_display_registers_from, tui_display_reg_element_at_line):
 836         Remove unnecessary cast.
 837
 838 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * linux-nat.c (normal_mask): Delete.
 841         (_initialize_linux_nat): Don't initialise normal_mask.
 842
 843 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 844
 845         PR gdb/24445
 846         * dwarf-index-write.h (write_psymtabs_to_index): Add
 847         dwz_basename parameter.
 848         * dwarf-index-write.c (write_gdbindex): Move file writing to
 849         write_gdbindex_1.  Change return type void.
 850         (assert_file_size): Move up, remove filename parameter.
 851         (write_gdbindex_1): New function.
 852         (write_debug_names): Change return type to void, call
 853         assert_file_size.
 854         (struct index_wip_file): New struct.
 855         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 856         file logic to index_wip_file.  Write index for dwz file if
 857         needed.
 858         (save_gdb_index_command): Pass basename of dwz file, if present.
 859         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 860         build-id of dwz file, if present.
 861         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 862         (dwarf2_get_dwz_file): Likewise.
 863         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 864         (dwarf2_get_dwz_file): Likewise.
 865
 866 2019-06-16  Tom Tromey  <tom@tromey.com>
 867
 868         * coffread.c (process_coff_symbol): Use xstrdup.
 869         * value.c (create_internalvar): Use xstrdup.
 870
 871 2019-06-16  Tom Tromey  <tom@tromey.com>
 872
 873         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 874         * breakpoint.c (stopin_command, stopat_command)
 875         (until_break_command, decode_location_default): Remove unnecessary
 876         cast.
 877         * utils.c (subset_compare): Remove unnecessary cast.
 878         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 879         cast.
 880         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 881         cast.
 882         * infcmd.c (path_command): Remove unnecessary cast.
 883         * coffread.c (decode_type): Remove unnecessary cast.
 884         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 885         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 886         * tui/tui-stack.c (tui_show_locator_content)
 887         (tui_show_frame_info): Remove unnecessary cast.
 888         * tui/tui-win.c (tui_scroll_forward_command)
 889         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 890         (parse_scrolling_args): Remove unnecessary cast.
 891         * tui/tui-data.c (init_win_info, tui_del_window)
 892         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 893         (free_content_elements): Remove unnecessary cast.
 894         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 895         unnecessary cast.
 896         * tui/tui-source.c (tui_set_source_content)
 897         (tui_vertical_source_scroll): Remove unnecessary cast.
 898         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 899         cast.
 900         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 901         * tui/tui-regs.c (tui_display_registers_from)
 902         (tui_display_register): Remove unnecessary cast.
 903         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 904         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 905         (make_visible): Remove unnecessary cast.
 906         * tui/tui-winsource.c (tui_erase_source_content)
 907         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 908         unnecessary cast.
 909         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 910         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 911         * stabsread.c (read_type, read_array_type, read_range_type):
 912         Remove unnecessary cast.
 913         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 914         (parse_symbol, parse_type, upgrade_type, parse_external)
 915         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 916         unnecessary cast.
 917         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 918
 919 2019-06-16  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-data.c (tui_alloc_generic_win_info)
 922         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 923         checks.
 924
 925 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 926             Andrew Burgess  <andrew.burgess@embecosm.com>
 927
 928         * f-typeprint.c (f_print_type): Don't return early for not
 929         associated or not allocated types.
 930         (f_type_print_varspec_suffix): Add print_rank parameter and print
 931         ranks of array types in case they dangling.
 932         (f_type_print_base): Add print_rank parameter.
 933
 934 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * NEWS: Mention new MI commands.
 937         * break-catch-throw.c (enum exception_event_kind): Move to
 938         breakpoint.h.
 939         (print_mention_exception_catchpoint): Output text as a single
 940         message.
 941         (catch_exception_command_1): Rename to...
 942         (catch_exception_event): ...this, make non-static, update header
 943         command, and change some parameter types.
 944         (catch_catch_command): Update for changes to
 945         catch_exception_command_1.
 946         (catch_throw_command): Likewise.
 947         (catch_rethrow_command): Likewise.
 948         * breakpoint.c (enum exception_event_kind): Delete.
 949         * breakpoint.h (enum exception_event_kind): Moved here from
 950         break-catch-throw.c.
 951         (catch_exception_event): Declare.
 952         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 953         (mi_cmd_catch_throw): New function.
 954         (mi_cmd_catch_rethrow): New function.
 955         (mi_cmd_catch_catch): New function.
 956         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 957         'catch-catch' entries.
 958         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 959         (mi_cmd_catch_rethrow): Declare.
 960         (mi_cmd_catch_catch): Declare.
 961
 962 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * annotate.c (annotate_source_line): Change return type to void,
 965         update implementation to match.
 966         * annotate.h (annotate_source_line): Change return type to void,
 967         update header comment.
 968         * stack.c (print_frame_info): Don't change what frame information
 969         is printed based on whether annotations are on or not.
 970
 971 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 972
 973         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 974         (annotate_source): Make static.
 975         (annotate_source_line): Moved from source.c and renamed from
 976         identify_source_line.  Update the return type.
 977         * annotate.h (annotate_source): Delete declaration.
 978         (annotate_source_line): Declaration moved from source.h, and
 979         renamed from identify_source_line.  Return type updated.
 980         * source.c (identify_source_line): Moved to annotate.c and renamed
 981         to annotate_source_line.
 982         (info_line_command): Remove check of annotation_level.
 983         * source.h (identify_source_line): Move declaration to annotate.h
 984         and rename to annotate_source_line.
 985         * stack.c: Add 'annotate.h' include.
 986         (print_frame_info): Remove check of annotation_level before
 987         calling annotate_source_line.
 988
 989 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * source-cache.c (source_cache::get_plain_source_lines): Use
 992         open_source_file_with_line_charpos instead of just
 993         open_source_file, remove call to find_source_lines.
 994         (source_cache::get_source_lines): Likewise.
 995         * source.c (find_source_lines): Make static.
 996         (get_filename_and_charpos): Renamed into...
 997         (open_source_file_with_line_charpos): ..this along with changes to
 998         return a scoped_fd, and some other minor clean ups.
 999         (identify_source_line): Use open_source_file_with_line_charpos.
1000         (search_command_helper): Use open_source_file_with_line_charpos
1001         instead of just open_source_file, remove call to
1002         find_source_lines.
1003         * source.h (open_source_file_with_line_charpos): Declare new
1004         function.
1005         (find_source_lines): Delete declaration.
1006
1007 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * source.c (get_filename_and_charpos): Remove fullname
1010         parameter.
1011         (identify_source_line): Update call to get_filename_and_charpos.
1012
1013 2019-06-14  Tom Tromey  <tromey@adacore.com>
1014
1015         PR gdb/24502:
1016         * ui-style.h (skip_ansi_escape): Update comment.
1017         * ui-file.h (class no_terminal_escape_file): New class.
1018         * ui-file.c (no_terminal_escape_file::write)
1019         (no_terminal_escape_file::puts): New methods.
1020         * cli/cli-logging.c (handle_redirections): Use
1021         no_terminal_escape_file.
1022
1023 2019-06-14  Tom Tromey  <tromey@adacore.com>
1024
1025         * NEWS: Move convenience variable news above Python news.
1026
1027 2019-06-14  Tom Tromey  <tom@tromey.com>
1028
1029         * gnulib: Move directory to top-level.
1030         * configure.ac: Don't configure gnulib.
1031         * configure: Rebuild.
1032         * common/common-defs.h: Use new path to gnulib.
1033         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1034         (GNULIB_H): Remove.
1035         (INCGNU): Look in new gnulib location.
1036         (HFILES_NO_SRCDIR): Remove gnulib files.
1037         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1038         (generated_files): Remove GNULIB_H.
1039         ($(LIBGNU), all-lib): Remove targets.
1040         (distclean): Don't mention GNULIB_BUILDDIR.
1041         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1042
1043 2019-06-14  Tom Tromey  <tromey@adacore.com>
1044
1045         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1046         Warn if symbol file does not provide any symbols.
1047
1048 2019-06-14  Tom Tromey  <tromey@adacore.com>
1049
1050         * source.c (find_and_open_source): Respect basenames_may_differ.
1051
1052 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * annotate.c (annotate_breakpoints_invalid): Make use of
1055         scoped_restore_terminal_state.
1056         (annotate_frames_invalid): Likewise.
1057
1058 2019-06-14  Tom Tromey  <tromey@adacore.com>
1059
1060         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1061         allow assignment to an internalvar.
1062
1063 2019-06-14  Tom Tromey  <tromey@adacore.com>
1064
1065         * ada-lex.l: Allow "_" in attribute names.
1066
1067 2019-06-14  Tom Tromey  <tromey@adacore.com>
1068
1069         PR gdb/24653:
1070         * regcache.c (registers_changed): Don't call alloca.
1071         * top.c (execute_command): Don't call alloca.
1072
1073 2019-06-13  Pedro Alves  <palves@redhat.com>
1074
1075         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1076         'expression'.  When parsing an expression, error out if there's
1077         junk after "unlimited".
1078         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1079         (do_set_command): Adjust calls to is_unlimited_literal.
1080
1081 2019-06-13  Pedro Alves  <palves@redhat.com>
1082
1083         * compile/compile.c (make_compile_options_def_group): Add braces
1084         around array_view initializer.
1085         * thread.c (make_thread_apply_all_options_def_group)
1086         (make_thread_apply_all_options_def_group): Likewise.
1087
1088 2019-06-13  Pedro Alves  <palves@redhat.com>
1089
1090         * NEWS (New commands): Mention "maint test-options
1091         require-delimiter", "maint test-options unknown-is-error", "maint
1092         test-options unknown-is-operand" and "maint show
1093         test-options-completion-result".
1094         (New command options, command completion): New section.
1095         (Completion improvements): New section.
1096         Mention that you can abbreviate "unlimited".
1097
1098 2019-06-13  Pedro Alves  <palves@redhat.com>
1099
1100         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1101         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1102         * unittests/cli-utils-selftests.c (test_parse_flags)
1103         (test_parse_flags_qcs): Delete.
1104         (test_cli_utils): Don't call deleted functions.
1105
1106 2019-06-13  Pedro Alves  <palves@redhat.com>
1107
1108         * thread.c: Include "cli/cli-option.h".
1109         (tp_array_compar_ascending): Global.
1110         (tp_array_compar): Delete function.
1111         (tp_array_compar_ascending, tp_array_compar_descending): New
1112         functions.
1113         (ascending_option_def, qcs_flag_option_def)
1114         (thr_qcs_flags_option_defs)
1115         (make_thread_apply_all_options_def_group)
1116         (make_thread_apply_options_def_group): New.
1117         (thread_apply_all_command): Use gdb::option::process_options.
1118         (thread_apply_command_completer)
1119         (thread_apply_all_command_completer): New.
1120         (thread_apply_command): Use gdb::option::process_options.
1121         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1122         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1123         to generate help text of "thread apply".  Adjust "taas"'s help.
1124         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1125         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1126
1127 2019-06-13  Pedro Alves  <palves@redhat.com>
1128
1129         * thread.c (thread_apply_command): Check for invalid TID with
1130         isdigit instead of !isalpha.
1131
1132 2019-06-13  Pedro Alves  <palves@redhat.com>
1133
1134         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1135         (validate_flags_qcs): New.
1136         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1137         (validate_flags_qcs): Declare.
1138         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1139         (make_frame_apply_options_def_group): New.
1140         (frame_apply_command_count): Process options with
1141         gdb::option::process_options.
1142         (frame_apply_completer): New.
1143         (frame_apply_level_completer, frame_apply_all_completer)
1144         (frame_apply_completer): New.
1145         (_initialize_stack): Update help of "frame apply", "frame apply
1146         level", "frame apply all" and "faas" to mention supported options
1147         and install command completers.
1148         * stack.h (frame_apply_all_completer): Declare.
1149         * thread.c: Include "stack.h".
1150         (tfaas_command): Add "--".
1151         (_initialize_thread): Update help "tfaas" to mention supported
1152         options and install command completer.
1153
1154 2019-06-13  Pedro Alves  <palves@redhat.com>
1155
1156         * completer.c (complete_nested_command_line): New.
1157         (gdb_completion_word_break_characters_throw): Add assertion.
1158         * completer.h (complete_nested_command_line): Declare.
1159
1160 2019-06-13  Pedro Alves  <palves@redhat.com>
1161
1162         * stack.c (parse_backtrace_qualifiers): New.
1163         (backtrace_command): Use it.
1164         (backtrace_command_completer): Complete on qualifiers.
1165
1166 2019-06-13  Pedro Alves  <palves@redhat.com>
1167
1168         * frame.c: Include "cli/cli-option.h.
1169         (user_set_backtrace_options): New.
1170         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1171         Delete.
1172         (get_prev_frame): Adjust.
1173         (boolean_option_def, uinteger_option_def)
1174         (set_backtrace_option_defs): New.
1175         (_initialize_frame): Adjust and use
1176         gdb::option::add_setshow_cmds_for_options to install "set
1177         backtrace past-main" and "set backtrace past-entry".
1178         * frame.h: Include "cli/cli-option.h".
1179         (struct frame_print_options): Forward declare.
1180         (print_frame_arguments_all, print_frame_arguments_scalars)
1181         (print_frame_arguments_none): Declare.
1182         (print_entry_values): Delete declaration.
1183         (struct frame_print_options, user_frame_print_options): New.
1184         (struct set_backtrace_options): New.
1185         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1186         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1187         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1188         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1189         (list_args_or_locals): Add frame_print_options parameter.
1190         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1191         * python/py-framefilter.c (enumerate_args): Pass down
1192         USER_FRAME_PRINT_OPTIONS.
1193         * stack.c: Include "cli/cli-option.h".
1194         (print_frame_arguments_all, print_frame_arguments_scalars)
1195         (print_frame_arguments_none): Declare.
1196         (print_raw_frame_arguments, print_entry_values): Delete.
1197         (user_frame_print_options): New.
1198         (boolean_option_def, enum_option_def, frame_print_option_defs):
1199         New.
1200         (struct backtrace_cmd_options): New.
1201         (bt_flag_option_def): New.
1202         (backtrace_command_option_defs): New.
1203         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1204         (print_frame_arg, read_frame_arg, print_frame_args)
1205         (print_frame_info, print_frame): Add frame_print_options parameter
1206         and use it.
1207         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1208         (backtrace_command_1): Add frame_print_options and
1209         backtrace_cmd_options parameters and use them.
1210         (make_backtrace_options_def_group): New.
1211         (backtrace_command): Process command options with
1212         gdb::option::process_options.
1213         (backtrace_command_completer): New.
1214         (_initialize_stack): Extend "backtrace"'s help to mention
1215         supported options.  Install completer for "backtrace".
1216         Install some settings commands with add_setshow_cmds_for_options.
1217
1218 2019-06-13  Pedro Alves  <palves@redhat.com>
1219
1220         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1221         and that "set/show print raw frame-arguments" are now deprecated.
1222
1223         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1224         command.
1225         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1226         * stack.c (_initialize_stack): Install "set/show print
1227         raw-frame-arguments", and deprecate "set/show print raw
1228         frame-arguments".
1229         * valprint.c (_initialize_valprint): Deprecate "set/show print
1230         raw".
1231
1232 2019-06-13  Pedro Alves  <palves@redhat.com>
1233
1234         * compile/compile.c (struct compile_options): New.
1235         (compile_flag_option_def, compile_command_option_defs)
1236         (make_compile_options_def_group): New.
1237         (compile_file_command): Handle options with
1238         gdb::option::process_options.
1239         (compile_file_command_completer): New function.
1240         (compile_code_command): Handle options with
1241         gdb::option::process_options.
1242         (compile_code_command_completer): New function.
1243         (_initialize_compiler): Install completers for "compile code" and
1244         "compile file".  Mention available options in "compile code" and
1245         "compile code"'s help.
1246         * completer.c (advance_to_completion_word): New, factored out from
1247         ...
1248         (advance_to_expression_complete_word_point): ... this.
1249         (advance_to_filename_complete_word_point): New.
1250         * completer.h (advance_to_filename_complete_word_point): New
1251         declaration.
1252
1253 2019-06-13  Pedro Alves  <palves@redhat.com>
1254
1255         * compile/compile.c: Include "cli/cli-option.h".
1256         (compile_print_value): Scope data pointer is now a
1257         value_print_options pointer; adjust.
1258         (compile_print_command): Process options.  Scope data pointer is
1259         now a value_print_options pointer; adjust.
1260         (_initialize_compile): Update "compile print"'s help to include
1261         supported options.  Install a completer for "compile print".
1262         * cp-valprint.c (show_vtblprint, show_objectprint)
1263         (show_static_field_print): Delete.
1264         (_initialize_cp_valprint): Don't install "set print
1265         static-members", "set print vtbl", "set print object" here.
1266         * printcmd.c: Include "cli/cli-option.h" and
1267         "common/gdb_optional.h".
1268         (print_command_parse_format): Rework to fill in a
1269         value_print_options instead of a format_data.
1270         (print_value): Change parameter type from format_data pointer to
1271         value_print_options reference.  Adjust.
1272         (print_command_1): Process options.  Adjust to pass down a
1273         value_print_options.
1274         (print_command_completer): New.
1275         (_initialize_printcmd): Install print_command_completer as
1276         handle_brkchars completer for the "print" command.  Update
1277         "print"'s help to include supported options.
1278         * valprint.c: Include "cli/cli-option.h".
1279         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1280         here from cp-valprint.c.
1281         (boolean_option_def, uinteger_option_def)
1282         (value_print_option_defs, make_value_print_options_def_group):
1283         New.  Use gdb::option::add_setshow_cmds_for_options to install
1284         "set print elements", "set print null-stop", "set print repeats",
1285         "set print pretty", "set print union", "set print array", "set
1286         print address", "set print symbol", "set print array-indexes".
1287         * valprint.h: Include <string> and "cli/cli-option.h".
1288         (make_value_print_options_def_group): Declare.
1289         (print_value): Change parameter type from format_data pointer to
1290         value_print_options reference.
1291         (print_command_completer): Declare.
1292
1293 2019-06-13  Pedro Alves  <palves@redhat.com>
1294
1295         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1296         (COMMON_SFILES): Add maint-test-settings.c.
1297         * cli/cli-decode.c (boolean_enums): New global, factored out from
1298         ...
1299         (add_setshow_boolean_cmd): ... here.
1300         * cli/cli-decode.h (boolean_enums): Declare.
1301         * cli/cli-option.c: New file.
1302         * cli/cli-option.h: New file.
1303         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1304         factored out from ...
1305         (parse_cli_boolean_value(const char *)): ... this.
1306         (is_unlimited_literal): Change parameter type to pointer to
1307         pointer.  Adjust and advance ARG pointer.
1308         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1309         (parse_cli_var_enum): New, factored out from ...
1310         (do_set_command): ... this.  Adjust.
1311         * cli/cli-setshow.h (parse_cli_boolean_value)
1312         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1313         (parse_cli_var_enum): Declare.
1314         * cli/cli-utils.c: Include "cli/cli-option.h".
1315         (get_ulongest): New.
1316         * cli/cli-utils.h (get_ulongest): Declare.
1317         (check_for_argument): New overloads.
1318         * maint-test-options.c: New file.
1319
1320 2019-06-13  Pedro Alves  <palves@redhat.com>
1321
1322         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1323         parse a range if "-" is at the end of the string.
1324
1325 2019-06-13  Pedro Alves  <palves@redhat.com>
1326
1327         * cli/cli-setshow.c (parse_auto_binary_operation)
1328         (parse_cli_boolean_value): Don't allow "o".
1329
1330 2019-06-13  Pedro Alves  <palves@redhat.com>
1331
1332         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1333         * NEWS: Mention maint test-settings KIND.
1334         * maint-test-settings.c: New file.
1335
1336 2019-06-13  Pedro Alves  <palves@redhat.com>
1337
1338         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1339         completer.
1340         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1341         "set" completers.
1342
1343 2019-06-13  Pedro Alves  <palves@redhat.com>
1344
1345         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1346         after item.
1347
1348 2019-06-13  Pedro Alves  <palves@redhat.com>
1349
1350         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1351
1352 2019-06-13  Pedro Alves <palves@redhat.com>
1353
1354         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1355         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1356         call.
1357         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1358         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1359         calls.
1360         (check_for_argument): Skip spaces after argument.
1361
1362 2019-06-13  Pedro Alves  <palves@redhat.com>
1363
1364         * thread.c (thread_apply_command): Adjust TID parsing.
1365         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1366         detected before end of string.
1367         (tid_is_in_list): Error out if LIST is invalid.
1368
1369 2019-06-13  Pedro Alves  <palves@redhat.com>
1370
1371         * completer.c (complete_line_internal_1): Rewind completion word
1372         point.
1373         (completion_tracker::advance_custom_word_point_by): Change
1374         parameter type to int.
1375         * completer.h (completion_tracker::advance_custom_word_point_by):
1376         Likewise.
1377
1378 2019-06-13  Pedro Alves  <palves@redhat.com>
1379
1380         * completer.c (advance_to_completion_word): Handle delimiters.
1381
1382 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1383
1384         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1385
1386 2019-06-11  Tom Tromey  <tom@tromey.com>
1387
1388         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1389         (xmalloc_failed): Move to alloc.c.
1390         * alloc.c: New file.
1391         * Makefile.in (COMMON_SFILES): Add alloc.c.
1392
1393 2019-06-11  Tom Tromey  <tom@tromey.com>
1394
1395         * nat/linux-waitpid.c: Don't include server.h.
1396         (linux_debug): Remove.
1397         (my_waitpid): Update.
1398
1399 2019-06-11  Tom Tromey  <tromey@adacore.com>
1400
1401         * infcall.c (_initialize_infcall): Remove trailing newline from
1402         help.
1403         * user-regs.c (_initialize_user_regs): Remove trailing newline
1404         from help.
1405         * typeprint.c (_initialize_typeprint): Remove trailing newline
1406         from help.
1407         * reverse.c (_initialize_reverse): Remove trailing newlines from
1408         help.
1409         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1410         from help.
1411         * language.c (add_set_language_command): Remove trailing newline
1412         from help.
1413         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1414         help.
1415         * disasm.c (_initialize_disasm): Remove trailing newline from
1416         help.
1417         * top.c (init_main): Remove trailing newline from help.
1418         * interps.c (_initialize_interpreter): Remove trailing newline
1419         from help.
1420         * btrace.c (_initialize_btrace): Remove trailing newlines from
1421         help.
1422         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1423         from help.
1424         * python/python.c (_initialize_python): Remove trailing newline
1425         from help.
1426         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1427         help.
1428         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1429         from help.  Reformat some text.
1430         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1431         from help.
1432         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1433         newline from help.
1434
1435 2019-06-11  Tom Tromey  <tromey@adacore.com>
1436
1437         * darwin-nat.c (darwin_decode_exception_message)
1438         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1439
1440 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1441
1442         * valops.c (value_slice): Check for not allocated or not
1443         associated values.
1444
1445 2019-06-10  Tom de Vries  <tdevries@suse.de>
1446
1447         PR gdb/24618
1448         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1449         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1450         invalid.
1451
1452 2019-06-10  Tom de Vries  <tdevries@suse.de>
1453
1454         PR gdb/24611
1455         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1456         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1457
1458 2019-06-10  Tom de Vries  <tdevries@suse.de>
1459
1460         PR symtab/24545
1461         * symtab.c (struct demangled_name_entry): Add language field.
1462         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1463         static minimal symbol".  Set and use language field.
1464
1465 2019-06-10  Tom Tromey  <tromey@adacore.com>
1466
1467         * ada-lang.c (_initialize_ada_language): Update help text.
1468
1469 2019-06-10  Tom Tromey  <tromey@adacore.com>
1470
1471         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1472         with a newline.
1473         * guile/guile.c (handle_boot_error): Don't end warning with a
1474         newline.
1475         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1476         warning with a newline.
1477         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1478         newline.
1479         (s12z_frame_cache): Likewise.
1480         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1481         a newline.
1482         * solib-svr4.c (disable_probes_interface): Don't end warning with
1483         a newline.
1484         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1485         newline.
1486         * python/python.c (do_finish_initialization): Don't end warning
1487         with a newline.
1488
1489 2019-06-10  Tom Tromey  <tom@tromey.com>
1490
1491         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1492         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1493         gdbpy_enter.
1494
1495 2019-06-10  Tom Tromey  <tromey@adacore.com>
1496
1497         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1498         data.
1499         (elf_new_init): Don't call stabsread_new_init.
1500         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1501         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1502         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1503
1504 2019-06-10  Tom de Vries  <tdevries@suse.de>
1505
1506         PR symtab/16264
1507         PR symtab/24517
1508         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1509
1510 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1511
1512         * source.c (find_and_open_source): Also rewrite relative file
1513         names.
1514
1515 2019-04-26  Amos Bird  <amosbird@gmail.com>
1516
1517         * annotate.c (annotate_thread_exited): Add "thread-exited"
1518         annotation.
1519
1520 2019-06-06  Tom Tromey  <tromey@adacore.com>
1521
1522         * maint.h (class scoped_command_stats): Use
1523         DISABLE_COPY_AND_ASSIGN.
1524         <print_time>: New method.
1525         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1526         print_time.
1527         (scoped_command_stats::print_time): New method.
1528
1529 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1530
1531         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1532         instructions of lengths 6 or 8 bytes.
1533
1534 2019-06-04  Pedro Alves  <palves@redhat.com>
1535
1536         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1537
1538         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1539         * breakpoint.c (condition_completer): Likewise.
1540         * cli/cli-dump.c (scan_expression): Likewise.
1541         * common/filestuff.c (mkdir_recursive): Likewise.
1542         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1543         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1544         (gdb_abspath): Likewise.
1545         * compile/compile-cplus-types.c
1546         (compile_cplus_instance::decl_name): Likewise.
1547         * completer.c (complete_explicit_location):
1548         (signal_completer, reg_or_group_completer_1): Likewise.
1549         * cp-support.c (cp_remove_params_if_any): Likewise.
1550         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1551         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1552         * infcmd.c (strip_bg_char): Likewise.
1553         * linespec.c (copy_token_string): Likewise.
1554         * mi/mi-main.c (output_cores): Likewise.
1555         * psymtab.c (psymtab_search_name):
1556         * symfile.c (test_set_ext_lang_command): Likewise.
1557         * target.c (target_fileio_read_stralloc): Likewise.
1558         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1559         * value.c (complete_internalvar): Likewise.
1560
1561 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1562
1563         Add objfile property to gdb.Type.
1564         * NEWS: Mention Python API addition.
1565         * python/py-type.c (typy_get_objfile): New method.
1566
1567 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1568
1569         * NEWS: Mention the new set|show style [title|highlight].
1570         Mention changes to "show style", "help" and "apropos".
1571
1572 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1573
1574         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1575         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1576         instead of print_help_for_command.
1577         (print_doc_of_command): New function.
1578         (help_list): Add 'apropos -v word' suggestion.
1579         (print_help_for_command): Style the command name using title style.
1580         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1581         (_initialize_cli_cmds): Describe -v in apropos_command help.
1582
1583 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1584
1585         * cli/cli-style.h (cli_style_option): Add name in constructor,
1586         add m_name class member, add constructor with intensity,
1587         add name class function.
1588         (cli_style_option::add_setshow_commands): Remove name argument.
1589         (highlight_style, title_style): New styles.
1590         * cli/cli-style.c (do_show): New function that shows a style
1591         characteristic styling the style name with itself.
1592         (set_style_name): New function.
1593         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1594         Update all callers according to the changes in cli/cli-style.h.
1595         * utils.h (fputs_highlighted): New function.
1596         * utils.c (fputs_highlighted): Likewise.
1597
1598 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1599
1600         * NEWS: Mention new pipe command and new convenience variables.
1601
1602 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1603
1604         * cli/cli-cmds.c (pipe_command): New function.
1605         (_initialize_cli_cmds): Call add_com for pipe_command.
1606         Define | as an alias for pipe.
1607         (exit_status_set_internal_vars): New function.
1608         (shell_escape): Call exit_status_set_internal_vars.
1609         cli/cli-decode.c (find_command_name_length): Recognize | as
1610         a single character command.
1611
1612 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1613
1614         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1615         top.c (execute_command_to_ui_file): New function, mostly a copy
1616         of execute_command_to_string.
1617         (execute_command_to_string): Implement by calling
1618         execute_command_to_ui_file.
1619
1620 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1621
1622         * top.h (saved_command_line): Remove declaration.
1623         * top.c (previous_saved_command_line, previous_repeat_arguments):
1624         New variables.
1625         (saved_command_line): Make static, define together with other
1626         'repeat variables'.
1627         (dont_repeat): Clear repeat_arguments.
1628         (repeat_previous, get_saved_command_line, save_command_line):
1629         New functions.
1630         (gdb_init): Initialize saved_command_line
1631         and previous_saved_command_line.
1632         * main.c (captured_main_1): Remove saved_command_line initialization.
1633         * event-top.c (handle_line_of_input): Update to use
1634         the new 'repeat' related functions instead of direct access to
1635         saved_command_line.
1636         * command.h (repeat_previous, get_saved_command_line,
1637         save_command_line): New declarations.
1638         (dont_repeat): Add comment.
1639
1640 2019-05-30  Tom Tromey  <tromey@adacore.com>
1641
1642         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1643         Fix comment.
1644         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1645
1646 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1647
1648         PR cli/24587
1649         * completer.c (complete): Initialize variable word.
1650
1651 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1652
1653         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1654         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1655         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1656         'body' is NULL to the outter 'if', protecting the '!is_define'
1657         situation as well.
1658
1659 2019-05-29  Tom Tromey  <tromey@adacore.com>
1660
1661         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1662         (dwarf_unknown): New function.
1663         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1664         (dwarf_type_encoding_name): Use dwarf_unknown.
1665
1666 2019-05-29  Tom Tromey  <tromey@adacore.com>
1667
1668         PR c++/20020:
1669         * cp-valprint.c (cp_print_value_fields): Call
1670         cp_print_static_field inside "try".
1671
1672 2019-05-29  Tom Tromey  <tromey@adacore.com>
1673
1674         * inflow.c (struct terminal_info): Add default operator=.
1675         * configure: Rebuild.
1676         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1677         -Wdeprecated-copy-dtor, -Wredundant-move.
1678
1679 2019-05-29  Tom Tromey  <tromey@adacore.com>
1680
1681         * NEWS: Add entry.
1682         * infcmd.c (print_return_value_1): Handle finish_print
1683         option.
1684         (show_print_finish): New function.
1685         (_initialize_infcmd): Add "set/show print finish" commands.
1686         * valprint.c (user_print_options): Initialize new member.
1687         * valprint.h (struct value_print_options) <finish_print>: New
1688         member.
1689
1690 2019-05-28  Tom Tromey  <tromey@adacore.com>
1691
1692         * ada-lang.c (ada_remove_Xbn_suffix)
1693         (find_old_style_renaming_symbol)
1694         (parse_old_style_renaming): Remove.
1695         (ada_find_renaming_symbol): Don't call
1696         find_old_style_renaming_symbol.
1697         (ada_is_renaming_symbol): Rename from
1698         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1699         bool.  Now static.
1700         (ada_read_var_value): Update and simplify.
1701         * ada-exp.y (write_var_or_type): Remove old code.
1702
1703 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1704
1705         * event-top.c: Remove include comment.
1706         * inflow.c (class scoped_ignore_sigttou): Move from here...
1707         * inflow.h (class scoped_ignore_sigttou): ...to here.
1708         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1709         * top.c:  Remove include comment.
1710
1711 2019-05-27  Tom Tromey  <tom@tromey.com>
1712
1713         * NEWS: Fix typo.
1714
1715 2019-05-22  Tom Tromey  <tromey@adacore.com>
1716
1717         * target.c (target_follow_exec): Constify parameter.
1718         * target-delegates.c: Rebuild.
1719         * remote.c (remote_target::follow_exec): Constify parameter.
1720         * infrun.c (follow_exec): Constify parameter.
1721         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1722         (target_follow_exec): Likewise.
1723
1724 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1725
1726         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1727         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1728
1729 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1730
1731         * NEWS: Add debugredirect and testsuite sections.
1732
1733 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1734
1735         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1736         target descriptions using exclusively floating point register name
1737         aliases.
1738
1739 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         PR gdb/18644:
1742         * f-lang.c (build_fortran_types): Handle the case where
1743         gdbarch_floatformat_for_type returns a nullptr.
1744
1745 2019-05-21  Tom de Vries  <tdevries@suse.de>
1746
1747         PR cli/24587
1748         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1749
1750 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1751
1752         PR gdb/18644:
1753         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1754         16-byte floats.
1755         * i386-tdep.c (i386_floatformat_for_type): Use
1756         floatformats_ia64_quad for the 16-byte floating point component
1757         within a fortran 32-byte complex number.
1758
1759 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1760
1761         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1762         delete default constructor.
1763         (find_partial_die): Update to return const struct.
1764         (partial_die_parent_scope): Move variable declaration into scope
1765         of its use and change its type to auto.
1766         (guess_partial_die_structure_name): Likewise.
1767         (partial_die_info::fixup): Likewise.
1768
1769 2019-05-17  Tom Tromey  <tromey@adacore.com>
1770
1771         * source.c (find_and_open_source): Remove cast.
1772
1773 2019-05-17  Tom Tromey  <tromey@adacore.com>
1774
1775         * annotate.c (annotate_source): Make "filename" const.
1776         * annotate.h (annotate_source): Use const.
1777
1778 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1779
1780         * disasm.c (set_disassembler_options): Send errors to stderr.
1781
1782 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1783
1784         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1785         (cli_interp_base::set_logging): Check debug_redirect.
1786         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1787         * cli/cli-logging.c (debug_redirect): Add static variable.
1788         (pop_output_files): Add default param.
1789         (handle_redirections): Print debug setting.
1790         (show_logging_command): Likewise.
1791         (_initialize_cli_logging): Add debugredirect command.
1792         * interps.c (current_interp_set_logging): Add debug_redirect
1793         parameter.
1794         * interps.h (set_logging): Add debug_redirect parameter.
1795         (current_interp_set_logging): Likewise.
1796         * mi/mi-common.h: Likewise.
1797         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1798
1799 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1800             Tom Tromey  <tromey@adacore.com>
1801
1802         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1803         directly.
1804         * cli/cli-interp.h (make_logging_output): Remove declaration.
1805         * cli/cli-logging.c (make_logging_output): Remove function.
1806         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1807         directly.
1808         * ui-file.c (tee_file::tee_file): Remove bools.
1809         (tee_file::~tee_file): Remove deletes.
1810         * ui-file.h (tee_file): Remove bools.
1811
1812 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1813
1814         * mi/mi-cmds.h (mi_cmd_complete): New function.
1815         * mi/mi-main.c (mi_cmd_complete): Likewise.
1816         * mi/mi-cmds.c: Define new MI command -complete.
1817         * NEWS: Mention new -complete command.
1818
1819 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1820
1821         * completer.h (complete): New function.
1822         * completer.c (complete): Likewise.
1823         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1824         function defined in completer.h.
1825
1826 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1827
1828         * MAINTAINERS (Write After Approval): Add myself.
1829
1830 2019-05-17  Tom de Vries  <tdevries@suse.de>
1831
1832         PR gdb/24094
1833         * dwarf2read.c (struct cu_partial_die_info): New struct.
1834         (find_partial_die): Return cu_partial_die_info.
1835         (partial_die_parent_scope, guess_partial_die_structure_name)
1836         (partial_die_info::fixup): Handle new return type of find_partial_die.
1837
1838 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1839
1840         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1841         "std::string", simplifying the algorithm.
1842
1843 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1844
1845         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1846         (stap_static_probe_ops::get_probes): Likewise.
1847
1848 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1849
1850         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1851         '-')" and "else if".
1852         (stap_parse_single_operand): Join checks for
1853         "gdbarch_stap_parse_special_token_p" and
1854         "gdbarch_stap_parse_special_token" in the same "if" statement.
1855         Invert check when verifying for operation on register
1856         displacement.
1857
1858 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1859
1860         * stap-probe.c (stap_get_opcode): Update comment.
1861         (stap_get_expected_argument_type): Likewise.
1862         (handle_stap_probe): Likewise.
1863
1864 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1865
1866         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1867         return type to 'bool'.  Adjust comment.  Use 'bool' when
1868         appropriate.
1869         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1870         * stap-probe.c (stap_parse_argument_1): Likewise.
1871         (stap_is_operator): Likewise.
1872         (stap_is_generic_prefix): Likewise.
1873         (stap_is_register_prefix): Likewise.
1874         (stap_is_register_indirection_prefix): Likewise.
1875         (stap_is_integer_prefix): Likewise.
1876         (stap_generic_check_suffix): Likewise.
1877         (stap_check_integer_suffix): Likewise.
1878         (stap_check_register_suffix): Likewise.
1879         (stap_check_register_indirection_suffix): Likewise.
1880         (stap_parse_register_operand): Likewise.
1881         (stap_parse_single_operand): Likewise.
1882         (stap_parse_argument_1): Likewise.
1883         (stap_probe::get_argument_count): Likewise.
1884         (stap_is_operator): Likewise.
1885
1886 2019-05-16  Tom Tromey  <tromey@adacore.com>
1887
1888         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1889         keyword to foreach.
1890
1891 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1892
1893         * linux-thread-db.c (try_thread_db_load_1): Change return type
1894         to bool.
1895         (try_thread_db_load): Likewise.
1896         (try_thread_db_load_from_pdir_1): Likewise.
1897         (try_thread_db_load_from_pdir): Likewise.
1898         (try_thread_db_load_from_sdir): Likewise.
1899         (try_thread_db_load_from_dir): Likewise.
1900         (thread_db_load_search): Likewise.
1901         (has_libpthread): Likewise.
1902         (thread_db_load): Likewise.
1903
1904 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1905
1906         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1907         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1908         NULL, and complain/return if that's the case.
1909
1910 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1911
1912         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1913         (advance, posn, abstract_read_memory): New functions.
1914         [struct mem_read_abstraction]: New struct.
1915         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1916
1917 2019-05-14  Tom Tromey  <tromey@adacore.com>
1918
1919         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1920         value is not lval_memory.
1921
1922 2019-05-14  Tom Tromey  <tromey@adacore.com>
1923
1924         * solib.c (info_sharedlibrary_command): Style the file name.
1925
1926 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1927
1928         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1929         (aarch64_vnv_type): Likewise.
1930         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1931         * common/tdesc.c: Likewise.
1932         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1933         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1934         * features/aarch64-fpu.xml: Add ieee half view.
1935         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1936         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1937         * gdbtypes.h (struct builtin_type): Likewise.
1938         (struct objfile_type): Likewise.
1939
1940 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1941
1942         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1943         typo.
1944         * location.h (string_to_event_location): Likewise.
1945
1946 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1947
1948         GDB 8.3 released.
1949
1950 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1951
1952         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1953         New variable declaration.
1954         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1955         New variable.
1956         (print_one_breakpoint): Use ui_out::test_flags and new global
1957         variable to compute use_fixed_output.
1958         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1959         Remove.
1960         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1961         (mi_multi_location_breakpoint_output_fixed): Remove.
1962         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1963         new variable.
1964         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1965         fix_multi_location_breakpoint_output flag if version >= 3.
1966         * ui-out.h (enum ui_out_flag)
1967         <fix_multi_location_breakpoint_output>: New enumerator.
1968
1969 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1970
1971         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1972
1973 2019-05-10  Tom Tromey  <tromey@adacore.com>
1974
1975         * ada-lang.c (catch_ada_completer): New function.
1976         (_initialize_ada_language): Use it.
1977
1978 2019-05-10  Tom Tromey  <tromey@adacore.com>
1979
1980         * thread.c (print_thread_info): Make "requested_threads" const.
1981         * gdbthread.h (print_thread_info): Make "requested_threads"
1982         const.
1983         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1984         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1985
1986 2019-05-08  Tom Tromey  <tom@tromey.com>
1987
1988         * gdbtypes.c (objfile_type_data): Change type.
1989         (objfile_type, _initialize_gdbtypes): Update.
1990
1991 2019-05-08  Tom Tromey  <tom@tromey.com>
1992
1993         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1994         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1995         (_initialize_dwarf2_frame): Update.
1996
1997 2019-05-08  Tom Tromey  <tom@tromey.com>
1998
1999         * objc-lang.c (objc_objfile_data): Change type.
2000         (find_methods): Update.
2001         (_initialize_objc_lang): Remove.
2002
2003 2019-05-08  Tom Tromey  <tom@tromey.com>
2004
2005         * stabsread.c (rs6000_builtin_type_data): Change type.
2006         (rs6000_builtin_type, _initialize_stabsread): Update.
2007
2008 2019-05-08  Tom Tromey  <tom@tromey.com>
2009
2010         * mips-tdep.c (mips_pdr_data): Remove.
2011         (_initialize_mips_tdep): Update.
2012
2013 2019-05-08  Tom Tromey  <tom@tromey.com>
2014
2015         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2016         (hppa_init_objfile_priv_data, read_unwind_info)
2017         (find_unwind_entry, _initialize_hppa_tdep): Update.
2018
2019 2019-05-08  Tom Tromey  <tom@tromey.com>
2020
2021         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2022         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2023         on obstack.
2024         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2025
2026 2019-05-08  Tom Tromey  <tom@tromey.com>
2027
2028         * mdebugread.c (basic_type_data): Change type.
2029         (basic_type, _initialize_mdebugread): Update.
2030
2031 2019-05-08  Tom Tromey  <tom@tromey.com>
2032
2033         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2034
2035 2019-05-08  Tom Tromey  <tom@tromey.com>
2036
2037         * nto-tdep.c (nto_inferior_data_reg): Change type.
2038         (nto_inferior_data): Update.
2039         (nto_inferior_data_cleanup, nto_new_inferior_data)
2040         (_initialize_nto_tdep): Remove.
2041         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2042
2043 2019-05-08  Tom Tromey  <tom@tromey.com>
2044
2045         * ada-lang.c (struct ada_inferior_data): Add initializers.
2046         (ada_inferior_data): Change type.
2047         (ada_inferior_data_cleanup): Remove.
2048         (get_ada_inferior_data, ada_inferior_exit)
2049         (struct ada_pspace_data): Add initializers, destructor.
2050         (ada_pspace_data_handle): Change type.
2051         (get_ada_pspace_data): Update.
2052         (ada_pspace_data_cleanup): Remove.
2053
2054 2019-05-08  Tom Tromey  <tom@tromey.com>
2055
2056         * coffread.c (struct coff_symfile_info): Add initializers.
2057         (coff_objfile_data_key): Move lower.  Change type.
2058         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2059         Update.
2060         (coff_free_info): Remove.
2061
2062 2019-05-08  Tom Tromey  <tom@tromey.com>
2063
2064         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2065         (fbsd_pspace_data_handle): Move lower.  Change type.
2066         (get_fbsd_pspace_data): Update.
2067         (fbsd_pspace_data_cleanup): Remove.
2068         (_initialize_fbsd_tdep): Update.
2069
2070 2019-05-08  Tom Tromey  <tom@tromey.com>
2071
2072         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2073         (get_ada_tasks_pspace_data): Update.
2074         (ada_tasks_pspace_data_cleanup): Remove.
2075         (_initialize_tasks): Update.
2076         (ada_tasks_inferior_data_handle): Change type.
2077         (get_ada_tasks_inferior_data): Update.
2078         (ada_tasks_inferior_data_cleanup): Remove.
2079         (struct ada_tasks_pspace_data): Add initializers.
2080
2081 2019-05-08  Tom Tromey  <tom@tromey.com>
2082
2083         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2084         * symfile-debug.c (debug_sym_get_probes): Change type.
2085         * stap-probe.c (handle_stap_probe):
2086         (stap_static_probe_ops::get_probes): Change type.
2087         * probe.h (class static_probe_ops) <get_probes>: Change type.
2088         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2089         (parse_probes_in_pspace): Update.
2090         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2091         Update.
2092         (any_static_probe_ops::get_probes): Change type.
2093         * elfread.c (elfread_data): New typedef.
2094         (probe_key): Change type.
2095         (elf_get_probes): Likewise.  Update.
2096         (probe_key_free): Remove.
2097         (_initialize_elfread): Update.
2098         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2099         Change type.
2100         (dtrace_process_dof_probe, dtrace_process_dof)
2101         (dtrace_static_probe_ops::get_probe): Change type.
2102
2103 2019-05-08  Tom Tromey  <tom@tromey.com>
2104
2105         * xcoffread.c (struct xcoff_symfile_info): Rename from
2106         coff_symfile_info.  Add initializers.
2107         (xcoff_objfile_data_key): Move lower.  Change type.
2108         (XCOFF_DATA): Rewrite.
2109         (xcoff_free_info): Remove.
2110         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2111         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2112         (xcoff_initial_scan): Update.
2113
2114 2019-05-08  Tom Tromey  <tom@tromey.com>
2115
2116         * solib-svr4.c (struct svr4_info): Add initializers and
2117         destructor.
2118         <probes_table>: Now an htab_up.
2119         (solib_svr4_pspace_data): Change type.
2120         (free_probes_table): Simplify.
2121         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2122         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2123         (probes_table_remove_objfile_probes, register_solib_event_probe)
2124         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2125         (_initialize_svr4_solib): Update.
2126
2127 2019-05-08  Tom Tromey  <tom@tromey.com>
2128
2129         * remote.c (remote_pspace_data): Change type.
2130         (remote_pspace_data_cleanup): Remove.
2131         (get_remote_exec_file, set_pspace_remote_exec_file)
2132         (_initialize_remote): Update.
2133
2134 2019-05-08  Tom Tromey  <tom@tromey.com>
2135
2136         * breakpoint.c (breakpoint_objfile_key): Change type.
2137         (get_breakpoint_objfile_data): Update.
2138         (free_breakpoint_objfile_data): Remove.
2139         (_initialize_breakpoint): Update.
2140
2141 2019-05-08  Tom Tromey  <tom@tromey.com>
2142
2143         * linux-tdep.c (struct linux_info): Add initializers.
2144         (linux_inferior_data): Move.  Change type.
2145         (invalidate_linux_cache_inf): Update.
2146         (linux_inferior_data_cleanup): Remove.
2147         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2148
2149 2019-05-08  Tom Tromey  <tom@tromey.com>
2150
2151         * auxv.c (auxv_inferior_data): Move.  Change type.
2152         (auxv_inferior_data_cleanup): Remove.
2153         (invalidate_auxv_cache_inf): Rewrite.
2154         (get_auxv_inferior_data, _initialize_auxv): Update.
2155
2156 2019-05-08  Tom Tromey  <tom@tromey.com>
2157
2158         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2159         (symfile_debug_objfile_data_key): Change type.
2160         (symfile_debug_installed, debug_qf_has_symbols)
2161         (debug_qf_find_last_source_symtab)
2162         (debug_qf_forget_cached_source_info)
2163         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2164         (debug_qf_print_stats, debug_qf_dump)
2165         (debug_qf_expand_symtabs_for_function)
2166         (debug_qf_expand_all_symtabs)
2167         (debug_qf_expand_symtabs_with_fullname)
2168         (debug_qf_map_matching_symbols)
2169         (debug_qf_expand_symtabs_matching)
2170         (debug_qf_find_pc_sect_compunit_symtab)
2171         (debug_qf_map_symbol_filenames)
2172         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2173         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2174         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2175         (debug_sym_read_linetable, debug_sym_relocate): Update.
2176         (symfile_debug_free_objfile): Remove.
2177         (install_symfile_debug_logging, _initialize_symfile_debug):
2178         Update.
2179
2180 2019-05-08  Tom Tromey  <tom@tromey.com>
2181
2182         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2183         allocate_on_obstack.
2184         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2185         (get_dwarf2_per_objfile): Update.
2186         (set_dwarf2_per_objfile): Remove.
2187         (dwarf2_has_info, dwarf2_get_section_info): Update.
2188         (dwarf2_free_objfile): Remove.
2189         (_initialize_dwarf2_read): Update.
2190
2191 2019-05-08  Tom Tromey  <tom@tromey.com>
2192
2193         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2194         initializers.
2195         <unsupported_script_warning_printed,
2196         script_not_found_warning_printed>: Now bool.
2197         (auto_load_pspace_data): Change type.
2198         (~auto_load_pspace_info): Rename from
2199         auto_load_pspace_data_cleanup.
2200         (get_auto_load_pspace_data, init_loaded_scripts_info)
2201         (clear_section_scripts, maybe_print_unsupported_script_warning)
2202         (maybe_print_script_not_found_warning, _initialize_auto_load):
2203         Update.
2204
2205 2019-05-08  Tom Tromey  <tom@tromey.com>
2206
2207         * objfiles.c (objfile_pspace_info): Add destructor and
2208         initializers.
2209         (objfiles_pspace_data): Change type.
2210         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2211         (get_objfile_pspace_data): Update.
2212         (objfiles_bfd_data): Change type.
2213         (get_objfile_bfd_data): Update.
2214         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2215
2216 2019-05-08  Tom Tromey  <tom@tromey.com>
2217
2218         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2219         Change type.
2220         (get_catch_syscall_inferior_data): Update.
2221         (catch_syscall_inferior_data_cleanup): Remove.
2222         (_initialize_break_catch_syscall): Update.
2223
2224 2019-05-08  Tom Tromey  <tom@tromey.com>
2225
2226         * inflow.c (struct terminal_info): Add destructor and
2227         initializers.
2228         (inflow_inferior_data): Change type.
2229         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2230         (get_inflow_inferior_data, inflow_inferior_exit)
2231         (swap_terminal_info, _initialize_inflow): Update.
2232
2233 2019-05-08  Tom Tromey  <tom@tromey.com>
2234
2235         * target-dcache.c (target_dcache_cleanup): Remove.
2236         (target_dcache_aspace_key): Change type.
2237         (target_dcache_init_p, target_dcache_invalidate)
2238         (target_dcache_get, target_dcache_get_or_init)
2239         (_initialize_target_dcache): Update.
2240         * dcache.h (struct dcache_deleter): New.
2241
2242 2019-05-08  Tom Tromey  <tom@tromey.com>
2243
2244         * symtab.c (struct symbol_cache): Add destructor and
2245         initializers.
2246         (symbol_cache_key): Move.  Change type.
2247         (make_symbol_cache, free_symbol_cache): Remove.
2248         (get_symbol_cache): Update.
2249         (symbol_cache_cleanup): Remove.
2250         (ALL_PSPACES, symbol_cache_flush)
2251         (maintenance_print_symbol_cache)
2252         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2253         Update.
2254
2255 2019-05-08  Tom Tromey  <tom@tromey.com>
2256
2257         * symtab.c (struct main_info): Add destructor and initializers.
2258         (main_progspace_key): Move.  Change type.
2259         (get_main_info): Update.
2260         (main_info_cleanup): Remove.
2261         (_initialize_symtab): Update.
2262
2263 2019-05-08  Tom Tromey  <tom@tromey.com>
2264
2265         * registry.h (DECLARE_REGISTRY): Define the _key class.
2266
2267 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * NEWS: Merge two 'New commands' sections.
2270
2271 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2272
2273         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2274         parameter and use Ada language definition instead.
2275         (ada_val_print_ptr): Remove unused language parameter.
2276         (ada_val_print_num): Remove language parameter and use Ada language
2277         definition instead.
2278         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2279         parameter.
2280         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2281         parameter and use Ada language definition instead.
2282         (ada_val_print_1): Update all ada_val_print_xxx calls.
2283         Remove language parameter.
2284         (ada_val_print): Update ada_val_print_1 call.
2285
2286 2019-05-08  Tom Tromey  <tromey@adacore.com>
2287
2288         * remote.c (remote_hw_watchpoint_limit)
2289         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2290         Now static.
2291
2292 2019-05-08  Tom Tromey  <tromey@adacore.com>
2293
2294         * maint.c (_initialize_maint_cmds): Move initialization code to
2295         remote.c.
2296         (watchdog, show_watchdog): Move to remote.c.
2297         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2298         "watchdog" static.
2299         (_initialize_remote): Move initialization code from maint.c.
2300         * defs.h (watchdog): Don't declare.
2301
2302 2019-05-08  Tom Tromey  <tromey@adacore.com>
2303
2304         * tui/tui-interp.c: Include main.h.
2305         * interps.c: Include main.h.
2306         * main.h (interpreter_p): Declare.
2307         * defs.h (interpreter_p): Don't declare.
2308
2309 2019-05-08  Tom Tromey  <tromey@adacore.com>
2310
2311         * dwarf2loc.c: Include dwarf2read.h.
2312         * defs.h (read_unsigned_leb128): Don't declare.
2313         * dwarf2read.h (read_unsigned_leb128): Declare.
2314
2315 2019-05-08  Tom Tromey  <tromey@adacore.com>
2316
2317         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2318         method.
2319
2320 2019-05-08  Tom Tromey  <tromey@adacore.com>
2321
2322         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2323         when no wrap column is set.
2324
2325 2019-05-08  Tom Tromey  <tromey@adacore.com>
2326
2327         * c-lang.c (c_get_string): Handle non-C-style arrays.
2328
2329 2019-05-08  Tom Tromey  <tromey@adacore.com>
2330
2331         * typeprint.c (print_offset_data::update): Print the bit offset,
2332         not the number of bits remaining.
2333
2334 2019-05-08  Tom Tromey  <tromey@adacore.com>
2335
2336         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2337         padding at end of comment.
2338
2339 2019-05-08  Tom Tromey  <tromey@adacore.com>
2340
2341         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2342         Compare main types.
2343
2344 2019-05-06  Tom Tromey  <tom@tromey.com>
2345
2346         * common/scoped_mmap.c: Include common-defs.h.
2347         * common/scoped_mmap.h: Don't include config.h.
2348
2349 2019-05-04  Tom Tromey  <tom@tromey.com>
2350
2351         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2352         (struct aarch64_call_info): Add initializers.
2353         <si>: Now a std::vector.
2354         (pass_on_stack, aarch64_push_dummy_call): Update.
2355
2356 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2357             Tom Tromey  <tom@tromey.com>
2358
2359         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2360         (ppc_threads): Now a std::vector.  Now static.
2361         (hwdebug_find_thread_points_by_tid)
2362         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2363         Update.
2364
2365 2019-05-04  Tom Tromey  <tom@tromey.com>
2366
2367         * arc-tdep.c (arc_tdesc_init): Return bool.
2368
2369 2019-05-04  Tom Tromey  <tom@tromey.com>
2370
2371         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2372         Use gdb_assert_not_reached.
2373
2374 2019-05-04  Tom Tromey  <tom@tromey.com>
2375
2376         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2377         "false".
2378
2379 2019-05-04  Tom Tromey  <tom@tromey.com>
2380
2381         * arc-tdep.c (arc_tdesc_init): Use bool.
2382
2383 2019-05-04  Tom Tromey  <tom@tromey.com>
2384
2385         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2386
2387 2019-05-04  Tom Tromey  <tom@tromey.com>
2388
2389         * cli/cli-cmds.c (valid_command_p): Return bool.
2390
2391 2019-05-04  Tom Tromey  <tom@tromey.com>
2392
2393         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2394         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2395
2396 2019-05-04  Raul Tambre  <raul@tambre.ee>
2397
2398         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2399         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2400         operator for comparison.
2401
2402 2019-05-04  Tom Tromey  <tom@tromey.com>
2403
2404         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2405         (lookup_partial_symbol, print_partial_symbols)
2406         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2407         (psymbol_compare): Update.
2408         (add_psymbol_to_bcache): Clear the entire psymbol.
2409         (maintenance_check_psymtabs): Update.
2410         * psympriv.h (struct partial_symbol): Don't derive from
2411         general_symbol_info.
2412         <obj_section, unrelocated_address, address,
2413         set_unrelocated_address>: Update.
2414         <ginfo>: New member.
2415         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2416         (debug_names::write_psymbols): Update.
2417
2418 2019-05-04  Tom de Vries  <tdevries@suse.de>
2419
2420         * contrib/cc-with-tweaks.sh: Support -n arg.
2421
2422 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2423
2424         * corelow.c (core_target::detach): Ensure frame cache and
2425         register caches are cleared.
2426         inferior.c (exit_inferior_1): Likewise.
2427
2428 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2429             Tom Tromey  <tom@tromey.com>
2430
2431         * dictionary.c (collate_pending_symbols_by_language): Remove
2432         "struct" from foreach.
2433         * symtab.c (lookup_global_symbol_from_objfile)
2434         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2435         foreach.
2436         * ser-tcp.c (net_open): Remove "struct" from foreach.
2437         * objfiles.c (objfile_relocate, objfile_rebase)
2438         (objfile_has_symbols): Remove "struct" from foreach.
2439         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2440         from foreach.
2441         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2442         foreach.
2443         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2444         "struct" from foreach.
2445         * ada-lang.c (create_excep_cond_exprs)
2446         (ada_exception_catchpoint_cond_string): Remove "struct" from
2447         foreach.
2448
2449 2019-05-03  Tom Tromey  <tromey@adacore.com>
2450
2451         * ada-exp.y (convert_char_literal): Check suffix of each
2452         enumerator.
2453
2454 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2455
2456         PR ada/21406:
2457         * ada-exp.y (yywrap): Don't define.
2458         * ada-lex.l (%option): Add noyywrap
2459         (yywrap): Remove.
2460
2461 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2462
2463         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2464         _WIN32_WINNT to the XP level, unless already defined to a higher
2465         level.
2466
2467         * unittests/parse-connection-spec-selftests.c:
2468         * ser-tcp.c:
2469         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2470         override.
2471
2472         * symfile.c (find_separate_debug_file): Remove colon from the
2473         drive spec of DOS/Windows file names of the target, so that the
2474         file name produced from DEBUGDIR and the target's directory will
2475         be valid on DOS/Windows systems.
2476
2477 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2478
2479         * rust-lang.c (val_print_struct): Handle printing structures
2480         containing strings.
2481
2482 2019-05-02  Tom Tromey  <tromey@adacore.com>
2483
2484         * valarith.c (_initialize_valarith): Remove.
2485
2486 2019-05-01  Tom Tromey  <tromey@adacore.com>
2487
2488         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2489         bitfields.
2490
2491 2019-05-01  Tom Tromey  <tromey@adacore.com>
2492
2493         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2494         for big-endian copies.
2495
2496 2019-04-30  Ali Tamur  <tamur@google.com>
2497         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2498         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2499         (read_3_bytes): New function.
2500
2501 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2502
2503         * windows-nat.c (main_thread_id): Delete.
2504         (handle_output_debug_string): Replace main_thread_id by
2505         current_event.dwThreadId.
2506         (fake_create_process): Likewise.
2507         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2508         Do not set main_thread_id.
2509         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2510         current_event.dwThreadId.
2511         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2512
2513 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2514
2515         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2516         Use current_event.dwThreadId instead of main_thread_id.
2517
2518 2019-04-30  Tom Tromey  <tromey@adacore.com>
2519
2520         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2521         (create_excep_cond_exprs): Iterate over program spaces.
2522         (ada_exception_catchpoint_cond_string): Examine all minimal
2523         symbols for exception types.
2524
2525 2019-04-30  Tom Tromey  <tromey@adacore.com>
2526
2527         PR c++/24470:
2528         * dwarf2read.c (process_structure_scope): Handle case where type
2529         has template parameters but no symbol was created.
2530
2531 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2532             Chris January  <chris.january@arm.com>
2533
2534         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2535         qualifier.
2536         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2537
2538 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2539
2540         * f-typeprint.c (f_print_type): Update rules for printing
2541         whitespace.
2542         (f_type_print_varspec_suffix): Likewise.
2543
2544 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2545             Chris January  <chris.january@arm.com>
2546
2547         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2548         function arguments.
2549
2550 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2551
2552         * f-lang.c (build_fortran_types): Change name of void type to
2553         lower case.
2554         * f-typeprint.c (f_type_print_base): Print the name of the void
2555         type, rather than a fixed string.
2556         * f-valprint.c (f_decorations): Use lower case void string.
2557
2558 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2559             Chris January  <chris.january@arm.com>
2560
2561         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2562         types for Fortran.
2563
2564 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2565             Chris January  <chris.january@arm.com>
2566             David Lecomber  <david.lecomber@arm.com>
2567
2568         * f-exp.y (BINOP_INTRINSIC): New token.
2569         (exp): New parser rule handling BINOP_INTRINSIC.
2570         (f77_keywords): Add new builtin procedures.
2571         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2572         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2573         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2574         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2575         (print_unop_subexp_f): New function.
2576         (print_binop_subexp_f): New function.
2577         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2578         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2579         (dump_subexp_body_f): Likewise.
2580         (operator_check_f): Likewise.
2581         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2582         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2583
2584 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2585
2586         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2587         UNOP_KIND.
2588         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2589         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2590         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2591         (operator_length_f): New fuction.
2592         (print_subexp_f): New function.
2593         (op_name_f): New function.
2594         (dump_subexp_body_f): New function.
2595         (operator_check_f): New function.
2596         (exp_descriptor_f): Replace standard expression handling functions
2597         with new functions.
2598         * gdb/fortran-operator.def: New file.
2599         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2600         * gdb/std-operator.def: Remove UNOP_KIND.
2601
2602 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2603
2604         * std-operator.def: Remove unbalanced, stray double quote
2605         character.
2606
2607 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2608             Chris January  <chris.january@arm.com>
2609             Daniel Everett  <daniel.everett@arm.com>
2610             Nick Forrington  <nick.forrington@arm.com>
2611             Richard Bunt  <richard.bunt@arm.com>
2612
2613         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2614         of depth when printing anonymous structs or unions.
2615         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2616         Don't print either the top-level value, or the children if the
2617         max-depth is exceeded.
2618         (ppscm_print_children): When printing the key of a map, allow one
2619         extra level of depth.
2620         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2621         print either the top-level value, or the children if the max-depth
2622         is exceeded.
2623         (print_children): When printing the key of a map, allow one extra
2624         level of depth.
2625         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2626         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2627         (user_print_options): Initialise max_depth field.
2628         (val_print_scalar_or_string_type_p): New function.
2629         (val_print): Check to see if the max depth has been reached.
2630         (val_print_check_max_depth): Define new function.
2631         (show_print_max_depth): New function.
2632         (_initialize_valprint): Add 'print max-depth' option.
2633         * valprint.h (struct value_print_options) <max_depth>: New field.
2634         (val_print_check_max_depth): Declare new function.
2635         * NEWS: Document new feature.
2636
2637 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2638
2639         * ada-lang.c (ada_language_defn): Initialise new field.
2640         * c-lang.c (c_is_string_type_p): New function.
2641         (c_language_defn): Initialise new field.
2642         (cplus_language_defn): Initialise new field.
2643         (asm_language_defn): Initialise new field.
2644         (minimal_language_defn): Initialise new field.
2645         * c-lang.h (c_is_string_type_p): Declare new function.
2646         * d-lang.c (d_language_defn): Initialise new field.
2647         * f-lang.c (f_is_string_type_p): New function.
2648         (f_language_defn): Initialise new field.
2649         * go-lang.c (go_is_string_type_p): New function.
2650         (go_language_defn): Initialise new field.
2651         * language.c (default_is_string_type_p): New function.
2652         (unknown_language_defn): Initialise new field.
2653         (auto_language_defn): Initialise new field.
2654         * language.h (struct language_defn) <la_is_string_type_p>: New
2655         member variable.
2656         (default_is_string_type_p): Declare new function.
2657         * m2-lang.c (m2_language_defn): Initialise new field.
2658         * objc-lang.c (objc_language_defn): Initialise new field.
2659         * opencl-lang.c (opencl_language_defn): Initialise new field.
2660         * p-lang.c (pascal_is_string_type_p): New function.
2661         (pascal_language_defn): Initialise new field.
2662         * rust-lang.c (rust_is_string_type_p): New function.
2663         (rust_language_defn): Initialise new field.
2664
2665 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2668         New field.
2669         * ada-lang.c (ada_language_defn): Initialise new field.
2670         * c-lang.c (c_language_defn): Likewise.
2671         (cplus_language_defn): Likewise.
2672         (asm_language_defn): Likewise.
2673         (minimal_language_defn): Likewise.
2674         * d-lang.c (d_language_defn): Likewise.
2675         * f-lang.c (f_language_defn): Likewise.
2676         * go-lang.c (go_language_defn): Likewise.
2677         * language.c (unknown_language_defn): Likewise.
2678         (auto_language_defn): Likewise.
2679         * m2-lang.c (m2_language_defn): Likewise.
2680         * objc-lang.c (objc_language_defn): Likewise.
2681         * opencl-lang.c (opencl_language_defn): Likewise.
2682         * p-lang.c (pascal_language_defn): Likewise.
2683         * rust-lang.c (rust_language_defn): Likewise.
2684
2685 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2686
2687         * ada-lang.c (ada_is_character_type): Change return type to bool.
2688         (ada_is_string_type): Likewise.
2689         * ada-lang.h (ada_is_character_type): Update declaration
2690         (ada_is_string_type): Likewise.
2691
2692 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2693
2694         Support style in 'frame|thread apply'
2695
2696         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2697         * record.c (record_start, record_stop): Update callers of
2698         execute_command_to_string with false.
2699         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2700         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2701         methods.
2702         (class string_file): New constructor with term_out parameter.
2703         Override methods term_out and can_emit_style_escape.  New member
2704         term_out.
2705         (class stdio_file): Override can_emit_style_escape.
2706         (class tee_file): Override term_out and can_emit_style_escape.
2707         * utils.h (can_emit_style_escape): Remove.
2708         * utils.c (can_emit_style_escape): Likewise.
2709         Update all callers of can_emit_style_escape (SOMESTREAM) to
2710         SOMESTREAM->can_emit_style_escape.
2711         * source-cache.c (source_cache::get_source_lines): Likewise.
2712         * stack.c (frame_apply_command_count): Call execute_command_to_string
2713         passing the term_out characteristic of the current gdb_stdout.
2714         * thread.c (thr_try_catch_cmd): Likewise.
2715         * top.c (execute_command_to_string): pass term_out parameter
2716         to construct the string_file for the command output.
2717         * ui-file.c (term_cli_styling): New function (most code moved
2718         from utils.c can_emit_style_escape).
2719         (string_file::string_file, string_file::can_emit_style_escape,
2720         stdio_file::can_emit_style_escape, tee_file::term_out,
2721         tee_file::can_emit_style_escape): New functions.
2722
2723 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2724
2725         * NEWS: Mention the new set|show may-call-functions.
2726         * infcall.c (may_call_functions_p): New variable.
2727         (show_may_call_functions_p): New function.
2728         (call_function_by_hand_dummy): Throws an error if not
2729         may-call-functions.
2730         (_initialize_infcall): Call add_setshow_boolean_cmd for
2731         may-call-functions.
2732
2733 2019-04-25  Keith Seitz  <keiths@redhat.com>
2734
2735         PR c++/24367
2736         * cp-support.c (inspect_type): Don't attempt substitutions
2737         of symbol with the same name.
2738
2739 2019-04-25  Tom Tromey  <tromey@adacore.com>
2740
2741         PR gdb/24475:
2742         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2743         static.
2744
2745 2019-04-25  Tom Tromey  <tromey@adacore.com>
2746
2747         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2748         rvalue reference.
2749         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2750         (gdb_xml_parser::parse): Use std::move.
2751         * python/python-internal.h (gdbpy_convert_exception): Take a const
2752         reference.
2753         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2754         std::move.
2755         * python/py-utils.c (gdbpy_convert_exception): Take a const
2756         reference.
2757         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2758         Use std::move.
2759         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2760         Use std::move.
2761         * mi/mi-main.c (mi_print_exception): Take a const reference.
2762         * main.c (handle_command_errors): Take a const reference.
2763         * linespec.c (parse_linespec): Use std::move.
2764         * infcall.c (run_inferior_call): Use std::move.
2765         (call_function_by_hand_dummy): Use std::move.
2766         * exec.c (try_open_exec_file): Use std::move.
2767         * exceptions.h (exception_print, exception_fprintf)
2768         (exception_print_same): Update.
2769         * exceptions.c (print_exception, exception_print)
2770         (exception_fprintf, exception_print_same): Change parameters to
2771         const reference.
2772         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2773         * common/new-op.c: Use std::move.
2774         * common/common-exceptions.h (struct gdb_exception): Add move
2775         constructor.
2776         (struct gdb_exception_error, struct gdb_exception_quit, struct
2777         gdb_quit_bad_alloc): Change constructor to move constructor.
2778         (throw_exception): Change parameter to rvalue reference.
2779         * common/common-exceptions.c (throw_exception): Take rvalue
2780         reference.
2781         * cli/cli-interp.c (safe_execute_command): Use std::move.
2782         * breakpoint.c (insert_bp_location, location_to_sals): Use
2783         std::move.
2784
2785 2019-04-25  Tom Tromey  <tromey@adacore.com>
2786
2787         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2788         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2789         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2790         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2791         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2792         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2793         guile/scm-value.c: Use unpack.
2794         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2795         gdbscm_gdb_exception.
2796         (gdbscm_throw_gdb_exception): Likewise.
2797         (struct gdbscm_gdb_exception): New.
2798         (unpack): New function.
2799         (gdbscm_wrap): Use unpack.
2800
2801 2019-04-25  Tom Tromey  <tromey@adacore.com>
2802
2803         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2804         (gdb_rl_callback_handler): Use std::move.
2805         * common/common-exceptions.h (struct gdb_exception): Add move
2806         assignment operator.
2807         (throw_exception_sjlj): Change "exception" to const reference.
2808         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2809         (throw_exception_sjlj): Change "exception" to const reference.
2810
2811 2019-04-25  Tom Tromey  <tromey@adacore.com>
2812
2813         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2814         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2815         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2816         Update.
2817         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2818         Update.
2819         * mi/mi-interp.c (mi_interp::exec): Update.
2820         * linespec.c (parse_linespec): Update.
2821         * infcall.c (run_inferior_call): Update.
2822         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2823         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2824         (gdbscm_lookup_global_symbol): Update.
2825         * guile/scm-param.c (gdbscm_parameter_value): Update.
2826         * guile/scm-frame.c (gdbscm_frame_read_register)
2827         (gdbscm_frame_read_var): Update.
2828         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2829         * exec.c (try_open_exec_file): Update.
2830         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2831         (gdb_rl_callback_handler): Update.
2832         * common/common-exceptions.h (exception_none): Don't declare.
2833         * common/common-exceptions.c (exception_none): Don't define.
2834         (struct catcher) <exception>: Update.
2835         * cli/cli-interp.c (safe_execute_command): Update.
2836         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2837
2838 2019-04-25  Ali Tamur  <tamur@google.com>
2839
2840         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2841         (read_attribute_value): Likewise.
2842         (dwarf2_read_addr_index): Update comment.
2843         (read_str_index): Add DW_FORM_strx.
2844         (dwarf2_string_attr): Likewise.
2845         (dwarf2_const_value_attr): Likewise.
2846         (dump_die_shallow): Likewise.
2847         (dwarf2_fetch_constant_bytes): Likewise.
2848         (skip_form_bytes): Likewise.
2849         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2850
2851 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2852
2853         PR corefiles/11608
2854         PR corefiles/18187
2855         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2856         OFFSET.  Verify if current mapping contains an ELF header.
2857         (linux_find_memory_regions_full): Adjust call to
2858         dump_mapping_p.
2859
2860 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2861             Kang Li <kanglictf@gmail.com>
2862
2863         PR gdb/21600
2864
2865         * dwarf2-frame.c (read_initial_length): Be consistent about using
2866         unsigned representation of length.
2867         (decode_frame_entry_1): Likewise.  Check for wraparound of
2868         end pointer as well as buffer overflow.
2869
2870 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2871
2872         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2873         "vq".
2874
2875 2019-04-24  Tom Tromey  <tromey@adacore.com>
2876
2877         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2878
2879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2880
2881         * s12z-tdep.c (s12z_unwind_pc): Delete.
2882         (s12z_unwind_sp): Delete.
2883         (s12z_gdbarch_init): Don't register deleted functions with
2884         gdbarch.
2885
2886 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2887
2888         * rl78-tdep.c (rl78_unwind_sp): Delete.
2889         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2890
2891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2892
2893         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2894         (xstormy16_unwind_pc): Delete.
2895         (xstormy16_dummy_id): Delete.
2896         (xstormy16_gdbarch_init): Don't register deleted functions with
2897         gdbarch.
2898
2899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * vax-tdep.c (vax_unwind_pc): Delete.
2902         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2903
2904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2905
2906         * v850-tdep.c (v850_unwind_sp): Delete.
2907         (v850_unwind_pc): Delete.
2908         (v850_dummy_id): Delete.
2909         (v850_gdbarch_init): Don't register deleted functions with
2910         gdbarch.
2911
2912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2913
2914         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2915         (tilegx_unwind_pc): Delete.
2916         (tilegx_unwind_dummy_id): Delete.
2917         (tilegx_gdbarch_init): Don't register deleted functions with
2918         gdbarch.
2919
2920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2921
2922         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2923         (tic6x_dummy_id): Delete.
2924         (tic6x_gdbarch_init): Don't register deleted functions with
2925         gdbarch.
2926
2927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2928
2929         * sparc-tdep.c (sparc_unwind_pc): Delete.
2930         (sparc32_gdbarch_init): Don't register deleted function with
2931         gdbarch.
2932
2933 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2934
2935         * sh-tdep.c (sh_unwind_sp): Delete.
2936         (sh_unwind_pc): Delete.
2937         (sh_dummy_id): Delete.
2938         (sh_gdbarch_init): Don't register deleted functions with
2939         gdbarch.
2940
2941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2942
2943         * score-tdep.c (score_unwind_sp): Delete.
2944         (score_unwind_pc): Delete.
2945         (score_dummy_id): Delete.
2946         (score_gdbarch_init): Don't register deleted functions with
2947         gdbarch.
2948
2949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * rx-tdep.c (rx_unwind_pc): Delete.
2952         (rx_unwind_sp): Delete.
2953         (rx_dummy_id): Delete.
2954         (rx_gdbarch_init): Don't register deleted functions with
2955         gdbarch.  Update comment.
2956
2957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2960         (rs6000_dummy_id): Delete.
2961         (rs6000_gdbarch_init): Don't register deleted functions with
2962         gdbarch.
2963
2964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2965
2966         * or1k-tdep.c (or1k_dummy_id): Delete.
2967         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2968
2969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2970
2971         * nios2-tdep.c (nios2_dummy_id): Delete.
2972         (nios2_unwind_sp): Delete.
2973         (nios2_gdbarch_init): Don't register deleted functions with
2974         gdbarch.
2975
2976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2977
2978         * nds32-tdep.c (nds32_dummy_id): Delete.
2979         (nds32_unwind_pc): Delete.
2980         (nds32_unwind_sp): Delete.
2981         (nds32_gdbarch_init): Don't register deleted functions with
2982         gdbarch.
2983
2984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * msp430-tdep.c (msp430_unwind_pc): Delete.
2987         (msp430_unwind_sp): Delete.
2988         (msp430_dummy_id): Delete.
2989         (msp430_gdbarch_init): Don't register deleted functions with
2990         gdbarch.
2991
2992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2993
2994         * moxie-tdep.c (moxie_unwind_sp): Delete.
2995         (moxie_unwind_pc): Delete.
2996         (moxie_dummy_id): Delete.
2997         (moxie_gdbarch_init): Don't register deleted functions with
2998         gdbarch.
2999
3000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3003         (mn10300_unwind_pc): Delete.
3004         (mn10300_unwind_sp): Delete.
3005         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3006         mn10300_unwind_sp.
3007         (mn10300_frame_unwind_init): Don't register deleted functions with
3008         gdbarch.
3009
3010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3011
3012         * mep-tdep.c (mep_unwind_pc): Delete.
3013         (mep_unwind_sp): Delete.
3014         (mep_dummy_id): Delete.
3015         (mep_gdbarch_init): Don't register deleted functions with
3016         gdbarch.
3017
3018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3021         (m68hc11_unwind_sp): Delete.
3022         (m68hc11_gdbarch_init): Don't register deleted functions with
3023         gdbarch.
3024
3025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3026
3027         * m32r-tdep.c (m32r_unwind_sp): Delete.
3028         (m32r_unwind_pc): Delete.
3029         (m32r_dummy_id): Delete.
3030         (m32r_gdbarch_init): Don't register deleted functions with
3031         gdbarch.
3032
3033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3034
3035         * m32c-tdep.c (m32c_unwind_pc): Delete.
3036         (m32c_unwind_sp): Delete.
3037         (m32c_dummy_id): Delete.
3038         (m32c_gdbarch_init): Don't register deleted functions with
3039         gdbarch.
3040
3041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3042
3043         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3044         (lm32_unwind_pc): Delete.
3045         (lm32_dummy_id): Delete.
3046         (lm32_gdbarch_init): Don't register deleted functions with
3047         gdbarch.
3048
3049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3050
3051         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3052         (iq2000_unwind_pc): Delete.
3053         (iq2000_dummy_id): Delete.
3054         (iq2000_gdbarch_init): Don't register deleted functions with
3055         gdbarch.
3056
3057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3058
3059         * nds32-tdep.c (nds32_type_align): Delete.
3060         (nds32_push_dummy_call): Use type_align instead.
3061
3062 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3063
3064         * arm-tdep.c (arm_type_align): Only handle vector override case.
3065         (arm_push_dummy_call): Use type_align.
3066         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3067
3068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3071         case.
3072         (pass_on_stack): Use type_align.
3073         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3074         function.
3075
3076 2019-04-23  Tom Tromey  <tromey@adacore.com>
3077
3078         * dwarf2read.c (line_header::file_name_at): Remove unused
3079         overload.
3080
3081 2019-04-23  Tom de Vries  <tdevries@suse.de>
3082
3083         PR gdb/24438
3084         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3085         invocation.
3086
3087
3088 2019-03-27  Ali Tamur  <tamur@google.com>
3089
3090         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3091         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3092         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3093         (dwarf_expr_context::get_addr_index): Likewise
3094         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3095         (symbol_needs_eval_context::get_addr_index): Likewise
3096         (disassemble_dwarf_expression): Add DW_OP_addrx
3097         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3098         (read_cutu_die_from_dwo): Update comment
3099         (skip_one_die): Add DW_FORM_addrx
3100         (read_attribute_value): Likewise
3101         (var_decode_location): Add DW_OP_addrx
3102         (dwarf2_const_value_attr): Add DW_FORM_addrx
3103         (dump_die_shallow): Likewise
3104         (dwarf2_fetch_constant_bytes): Likewise
3105         (decode_locdesc): Add DW_OP_addrx
3106         (skip_form_bytes): Add DW_FORM_addrx
3107
3108 2019-04-22  Ali Tamur  <tamur@google.com>
3109
3110         * MAINTAINERS (Write After Approval): Add self.
3111
3112 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3113
3114         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3115         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3116         (open_symbol_file_object): Likewise.
3117         (svr4_default_sos): Add info parameter.
3118         (svr4_read_so_list): Likewise.
3119         (svr4_current_sos_direct): Adjust functions calls to pass down
3120         info.
3121         (svr4_current_sos_1): Add info parameter.
3122         (svr4_current_sos): Call get_svr4_info, pass info down to
3123         svr4_current_sos_1.
3124         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3125         get_svr4_info.
3126         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3127         get_svr4_info.
3128         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3129         to get_svr4_info.
3130         (probes_table_remove_objfile_probes): Likewise.
3131         (register_solib_event_probe): Add info parameter.
3132         (solist_update_incremental): Pass info parameter down to
3133         svr4_read_so_list.
3134         (disable_probes_interface): Add info parameter.
3135         (svr4_handle_solib_event): Pass current_program_space to
3136         get_svr4_info.  Adjust disable_probes_interface cleanup.
3137         (svr4_create_probe_breakpoints): Add info parameter, pass it
3138         down to register_solib_event_probe.
3139         (svr4_create_solib_event_breakpoints): Add info parameter,
3140         pass it down to svr4_create_probe_breakpoints.
3141         (enable_break): Pass info down to
3142         svr4_create_solib_event_breakpoints.
3143         (svr4_solib_create_inferior_hook): Pass current_program_space to
3144         get_svr4_info.
3145         (svr4_clear_solib): Likewise.
3146
3147 2019-04-22  Pedro Alves  <palves@redhat.com>
3148
3149         * solib-svr4.c (svr4_free_objfile_observer): New.
3150         (probe_and_action::objfile): New field.
3151         (probes_table_htab_remove_objfile_probes)
3152         (probes_table_remove_objfile_probes): New functions.
3153         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3154         in the new probe_and_action.  Don't store the probe in 'lookup'.
3155         (svr4_create_probe_breakpoints): Pass objfile to
3156         register_solib_event_probe.
3157         (_initialize_svr4_solib): Register a free_objfile observer.
3158
3159 2019-04-19  Tom Tromey  <tom@tromey.com>
3160
3161         * common/queue.h: Remove.
3162
3163 2019-04-19  Tom Tromey  <tom@tromey.com>
3164
3165         * event-loop.c: Don't include "common/queue.h".
3166
3167 2019-04-19  Tom Tromey  <tom@tromey.com>
3168
3169         * remote.c (remote_target): Use delete.
3170         * remote-notif.h: Include <list>, not "common/queue.h".
3171         (notif_client_p): Remove typedef.
3172         (remote_notif_state): Add constructor, destructor, initializer.
3173         <notif_queue>: Now a std::list.
3174         (remote_notif_state_xfree): Don't declare.
3175         * remote-notif.c (remote_notif_process, handle_notification)
3176         (remote_notif_state_allocate): Update.
3177         (~remote_notif_state): Rename from remote_notif_state_xfree.
3178
3179 2019-04-19  Tom Tromey  <tom@tromey.com>
3180
3181         * symfile.c (reread_symbols): Update.
3182         * objfiles.c (objfile_register_static_link)
3183         (objfile_lookup_static_link): Update
3184         (~objfile) Don't delete static_links.
3185         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3186
3187 2019-04-19  Tom Tromey  <tom@tromey.com>
3188
3189         * type-stack.h (struct type_stack) <insert>: Constify string.
3190         * type-stack.c (type_stack::insert): Constify string.
3191         * gdbtypes.h (lookup_template_type): Update.
3192         (address_space_name_to_int): Update.
3193         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3194         const.
3195         (lookup_template_type): Make name const.
3196         * c-exp.y: Update rules.
3197         (lex_one_token, classify_name, classify_inner_name)
3198         (c_print_token): Update.
3199         * p-exp.y: Update rules.
3200         (yylex): Update.
3201         * f-exp.y: Update rules.
3202         (yylex): Update.
3203         * d-exp.y: Update rules.
3204         (lex_one_token, classify_name, classify_inner_name): Update.
3205         * parse.c (write_dollar_variable, copy_name): Return std::string.
3206         * parser-defs.h (copy_name): Change return type.
3207         * m2-exp.y: Update rules.
3208         (yylex): Update.
3209         * go-exp.y (lex_one_token): Update.
3210         Update rules.
3211         (classify_unsafe_function, classify_packaged_name)
3212         (classify_name, yylex): Update.
3213
3214 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3215
3216         * configure.ac: add --enable-source-highlight switch.
3217         * configure: Regenerate.
3218         * top.c (print_gdb_version): plumb --enable-source-highlight
3219         status to "show configuration".
3220
3221 2019-04-19  Tom Tromey  <tromey@adacore.com>
3222
3223         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3224         Check ADA_TYPE_P.
3225         (empty_record, ada_template_to_fixed_record_type_1)
3226         (template_to_static_fixed_type)
3227         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3228         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3229         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3230         macros.
3231
3232 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3233
3234         PR symtab/24423:
3235         * source.c (print_source_lines_base): Advance "iter" when a
3236         control character is seen.
3237
3238 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3239
3240         * inferior.h (struct infcall_suspend_state_deleter):
3241         Catch exception in destructor to avoid crash.
3242
3243 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3244
3245         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3246         close to the add_com "shell".
3247
3248 2019-04-18  Tom Tromey  <tromey@adacore.com>
3249
3250         * process-stratum-target.h (class process_stratum_target)
3251         <stratum>: Add "final".
3252
3253 2019-04-17  Tom Tromey  <tromey@adacore.com>
3254
3255         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3256         against nullptr before use.
3257
3258 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3259
3260         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3261
3262 2019-04-17  Jim Wilson  <jimw@sifive.com>
3263             Andrew Burgess  <andrew.burgess@embecosm.com>
3264
3265         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3266         code read might fail, assume 4-byte breakpoint in that case.
3267
3268 2019-04-15  Leszek Swirski  <leszeks@google.com>
3269
3270         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3271         rather than a hand-rolled POD check when checking for forced MEMORY
3272         classification.
3273
3274 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3275
3276         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3277         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3278         function.
3279         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3280         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3281         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3282         declaration.
3283
3284 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3285
3286         * aarch64-linux-nat.c
3287         (aarch64_linux_nat_target::thread_architecture): Add override.
3288         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3289         each VQ.
3290
3291 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3292
3293         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3294
3295 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3296
3297         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3298         target types of size 96-bits, add some additional comments, and
3299         check that the builtin type we found was the correct size.
3300
3301 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3302
3303         * utils.c (prompt_for_continue): Don't restore the styling at the
3304         end, as applied_style has the wrong value.  This fixes styling in
3305         long lists of file names that are interrupted by the "Continue?"
3306         prompt.
3307
3308 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3309
3310         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3311         * c-lang.c (c_language_defn): Likewise.
3312         (cplus_language_defn): Likewise.
3313         (asm_language_defn): Likewise.
3314         (minimal_language_defn): Likewise.
3315         * d-lang.c (d_language_defn): Likewise.
3316         * f-lang.c (f_language_defn): Likewise.
3317         * go-lang.c (go_language_defn): Likewise.
3318         * language.c (unknown_language_defn): Likewise.
3319         (auto_language_defn): Likewise.
3320         * language.h (struct language_defn): Remove la_magic field.
3321         (LANG_MAGIC): Delete.
3322         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3323         * objc-lang.c (objc_language_defn): Likewise.
3324         * opencl-lang.c (opencl_language_defn): Likewise.
3325         * p-lang.c (pascal_language_defn): Likewise.
3326         * rust-lang.c (rust_language_defn): Likewise.
3327
3328 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3329
3330         * riscv-tdep.c (riscv_type_align): New function.
3331         (riscv_type_alignment): Delete.
3332         (riscv_arg_location): Use 'type_align'.
3333         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3334
3335 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3336
3337         * gdbtypes.c (type_align): A struct with no non-static fields also
3338         has alignment of 1.
3339
3340 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3341
3342         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3343         component to 0.
3344         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3345         member.
3346         (riscv_struct_info::analyse): New implementation using new
3347         analyse_inner member function.
3348         (riscv_struct_info::field_offset): New member function.
3349         (riscv_struct_info::m_offsets): New member variable.
3350         (riscv_struct_info::analyse_inner): New private member function,
3351         takes the old implementation of riscv_struct_info::analyse but
3352         extended to track field offsets.
3353         (riscv_call_arg_struct): Update the struct folding special cases
3354         to handle cases where empty C++ structs, which are non-zero
3355         length, are found.
3356         (riscv_arg_location): Initialise the length of each location, a
3357         non-zero length now indicates the location is in use.
3358         (riscv_push_dummy_call): Allow for the first location having a
3359         non-zero offset when setting up arguments.
3360         (riscv_return_value): Likewise, but for return values.
3361
3362 2019-04-11  Tom Tromey  <tromey@adacore.com>
3363
3364         * utils.c (internal_vproblem): Make "msg" const.
3365
3366 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3367
3368         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3369         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3370         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3371         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3372
3373 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3374
3375         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3376         function.
3377         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3378         of amd64_collect_native_gregset.
3379         (amd64_linux_nat_target::store_registers): Likewise.
3380
3381 2019-04-10  Tom Tromey  <tom@tromey.com>
3382
3383         * symtab.c (lookup_global_symbol_from_objfile)
3384         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3385         * objfiles.h (class separate_debug_iterator): New.
3386         (class separate_debug_range): New.
3387         (struct objfile) <separate_debug_objfiles>: New method.
3388         (objfile_separate_debug_iterate): Don't declare.
3389         * objfiles.c (separate_debug_iterator::operator++): Rename from
3390         objfile_separate_debug_iterate.
3391         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3392         iterator.
3393         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3394         iterator.
3395
3396 2019-04-10  Tom Tromey  <tom@tromey.com>
3397
3398         * symfile.c (reread_symbols): Remove old comment.
3399         * objfiles.c (free_all_objfiles): Fix a typo.
3400
3401 2019-04-10  Tom Tromey  <tom@tromey.com>
3402
3403         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3404         * minsyms.c (lookup_minimal_symbol): Use foreach.
3405         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3406         (lookup_minimal_symbol_solib_trampoline): Likewise.
3407         * symfile.c (reread_symbols): Use foreach.
3408
3409 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3410             Tom Tromey  <tromey@adacore.com>
3411
3412         PR rust/24414:
3413         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3414         (rust_lex_int_test): Change "value" to be LONGEST.
3415         (rust_lex_tests): Add test for long integer literal.
3416
3417 2019-04-09  Tom Tromey  <tromey@adacore.com>
3418
3419         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3420         to bool.
3421         (extended_remote_target::attach): Update.
3422         (remote_target::remote_notice_new_inferior): Update.
3423         (remote_target::add_current_inferior_and_thread): Update.
3424         * inferior.c (exit_inferior_1): Use "false".
3425         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3426
3427 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3428
3429         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3430         the "start" command.
3431
3432 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3433
3434         * python/py-inferior.c (infpy_thread_from_thread_handle):
3435         Adjust comments to reflect renaming of thread_from_thread_handle
3436         to thread_from_handle.  Adjust keywords.  Fix type error message.
3437         (inferior_object_methods): Add thread_from_handle.  Retain
3438         thread_from_thread_handle, but mark it as deprecated.
3439
3440 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3441
3442         * gdbthread.h (find_thread_by_handle): Revise declaration.
3443         * thread.c (find_thread_by_handle): Likewise.  Adjust
3444         implementation too.
3445         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3446         support for buffer objects as handles.
3447
3448 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3449
3450         * python/py-infthread.c (thpy_thread_handle): New function.
3451         (thread_object_methods): Register thpy_thread_handle.
3452
3453 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3454
3455         * gdbthread.h (thread_to_thread_handle): Declare.
3456         * thread.c (gdbtypes.h): Include.
3457         (thread_to_thread_handle): New function.
3458
3459         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3460         (target_thread_info_to_thread_handle): Declare.
3461         * target.c (target_thread_info_to_thread_handle): New function.
3462         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3463         * target-delegates.c: Regenerate.
3464
3465         * linux-thread-db.c (class thread_db_target): Add method
3466         thread_info_to_thread_handle.
3467         (thread_db_target::thread_info_to_thread_handle): Define.
3468         * remote.c (class remote_target): Add new method
3469         thread_info_to_thread_handle.
3470         (remote_target::thread_info_to_thread_handle): Define.
3471
3472 2019-04-08  Pedro Alves  <palves@redhat.com>
3473
3474         * common/common-exceptions.c (throw_exception): Don't create
3475         named object to throw; throw directly.
3476         (throw_it): Likewise.  Don't initialize gdb_exception::message
3477         here, with new; pass FMT and AP to the ctor instead.
3478         * common/common-exceptions.h: Include <string>.
3479         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3480         const char *, va_list)): New ctor.  Use std::make_shared.
3481         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3482         errors)): Delete.
3483         (gdb_exception_error::gdb_exception_error(enum errors, const char
3484         *, va_list)): New.
3485         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3486         Add assertion.
3487         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3488         errors)): Delete.
3489         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3490         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3491         Add assertion.
3492
3493 2019-04-08  Tom Tromey  <tom@tromey.com>
3494
3495         * valops.c (value_rtti_indirect_type): Replace throw_exception
3496         with throw.
3497         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3498         with throw.
3499         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3500         throw.
3501         * target.c (target_translate_tls_address): Replace throw_exception
3502         with throw.
3503         * stack.c (frame_apply_command_count): Replace throw_exception
3504         with throw.
3505         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3506         throw.
3507         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3508         with throw.
3509         * rs6000-tdep.c (rs6000_frame_cache)
3510         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3511         * remote.c: Replace throw_exception with throw.
3512         * record-full.c (record_full_message, record_full_wait_1)
3513         (record_full_restore): Replace throw_exception with throw.
3514         * record-btrace.c:
3515         (get_thread_current_frame_id, record_btrace_start_replaying)
3516         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3517         (cmd_record_btrace_start): Replace throw_exception with throw.
3518         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3519         throw.
3520         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3521         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3522         * linespec.c:
3523         (find_linespec_symbols): Replace throw_exception with throw.
3524         * infrun.c (displaced_step_prepare, resume): Replace
3525         throw_exception with throw.
3526         * infcmd.c (post_create_inferior): Replace throw_exception with
3527         throw.
3528         * inf-loop.c (inferior_event_handler): Replace throw_exception
3529         with throw.
3530         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3531         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3532         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3533         (get_prev_frame_always, get_frame_pc_if_available)
3534         (get_frame_address_in_block_if_available, get_frame_language):
3535         Replace throw_exception with throw.
3536         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3537         throw_exception with throw.
3538         * eval.c (fetch_subexp_value, evaluate_var_value)
3539         (evaluate_funcall, evaluate_subexp_standard): Replace
3540         throw_exception with throw.
3541         * dwarf2loc.c (call_site_find_chain)
3542         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3543         Replace throw_exception with throw.
3544         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3545         with throw.
3546         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3547         throw.
3548         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3549         * completer.c (complete_line_internal): Replace throw_exception
3550         with throw.
3551         * compile/compile-object-run.c (compile_object_run): Replace
3552         throw_exception with throw.
3553         * cli/cli-script.c (process_next_line): Replace throw_exception
3554         with throw.
3555         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3556         (btrace_enable, btrace_maint_update_pt_packets): Replace
3557         throw_exception with throw.
3558         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3559         throw_exception with throw.
3560         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3561         throw_exception with throw.
3562         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3563         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3564         * aarch64-tdep.c (aarch64_make_prologue_cache)
3565         (aarch64_make_stub_cache): Replace throw_exception with throw.
3566
3567 2019-04-08  Tom Tromey  <tom@tromey.com>
3568
3569         * common/common-exceptions.c (throw_exception): Rename from
3570         throw_exception_cxx.  Remove old copy.  Make argument const.
3571         (throw_it): Create and throw exception objects directly.
3572         * common/common-exceptions.h (throw_exception): Make argument
3573         const.
3574         (struct gdb_exception_error): Add constructor.
3575         (struct gdb_exception_quit): Add constructor.
3576
3577 2019-04-08  Tom Tromey  <tom@tromey.com>
3578
3579         * common/common-exceptions.h (exception_rethrow): Don't declare.
3580         (TRY_SJLJ): Update comment.
3581         (TRY, CATCH, END_CATCH): Remove.
3582         * common/common-exceptions.c (exception_rethrow): Remove.
3583
3584 2019-04-08  Tom Tromey  <tom@tromey.com>
3585
3586         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3587         Remove.
3588         (gdb_exception_error): Rename from
3589         gdb_exception_RETURN_MASK_ERROR.
3590         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3591         (gdb_quit_bad_alloc): Update.
3592         * aarch64-tdep.c: Update.
3593         * ada-lang.c: Update.
3594         * ada-typeprint.c: Update.
3595         * ada-valprint.c: Update.
3596         * amd64-tdep.c: Update.
3597         * arch-utils.c: Update.
3598         * break-catch-throw.c: Update.
3599         * breakpoint.c: Update.
3600         * btrace.c: Update.
3601         * c-varobj.c: Update.
3602         * cli/cli-cmds.c: Update.
3603         * cli/cli-interp.c: Update.
3604         * cli/cli-script.c: Update.
3605         * common/common-exceptions.c: Update.
3606         * common/new-op.c: Update.
3607         * common/selftest.c: Update.
3608         * compile/compile-c-symbols.c: Update.
3609         * compile/compile-cplus-symbols.c: Update.
3610         * compile/compile-object-load.c: Update.
3611         * compile/compile-object-run.c: Update.
3612         * completer.c: Update.
3613         * corelow.c: Update.
3614         * cp-abi.c: Update.
3615         * cp-support.c: Update.
3616         * cp-valprint.c: Update.
3617         * darwin-nat.c: Update.
3618         * disasm-selftests.c: Update.
3619         * dtrace-probe.c: Update.
3620         * dwarf-index-cache.c: Update.
3621         * dwarf-index-write.c: Update.
3622         * dwarf2-frame-tailcall.c: Update.
3623         * dwarf2-frame.c: Update.
3624         * dwarf2loc.c: Update.
3625         * dwarf2read.c: Update.
3626         * eval.c: Update.
3627         * event-loop.c: Update.
3628         * event-top.c: Update.
3629         * exec.c: Update.
3630         * f-valprint.c: Update.
3631         * fbsd-tdep.c: Update.
3632         * frame-unwind.c: Update.
3633         * frame.c: Update.
3634         * gdbtypes.c: Update.
3635         * gnu-v3-abi.c: Update.
3636         * guile/guile-internal.h: Update.
3637         * guile/scm-block.c: Update.
3638         * guile/scm-breakpoint.c: Update.
3639         * guile/scm-cmd.c: Update.
3640         * guile/scm-disasm.c: Update.
3641         * guile/scm-frame.c: Update.
3642         * guile/scm-lazy-string.c: Update.
3643         * guile/scm-math.c: Update.
3644         * guile/scm-param.c: Update.
3645         * guile/scm-ports.c: Update.
3646         * guile/scm-pretty-print.c: Update.
3647         * guile/scm-symbol.c: Update.
3648         * guile/scm-symtab.c: Update.
3649         * guile/scm-type.c: Update.
3650         * guile/scm-value.c: Update.
3651         * i386-linux-tdep.c: Update.
3652         * i386-tdep.c: Update.
3653         * inf-loop.c: Update.
3654         * infcall.c: Update.
3655         * infcmd.c: Update.
3656         * infrun.c: Update.
3657         * jit.c: Update.
3658         * language.c: Update.
3659         * linespec.c: Update.
3660         * linux-fork.c: Update.
3661         * linux-nat.c: Update.
3662         * linux-tdep.c: Update.
3663         * linux-thread-db.c: Update.
3664         * main.c: Update.
3665         * mi/mi-cmd-break.c: Update.
3666         * mi/mi-cmd-stack.c: Update.
3667         * mi/mi-interp.c: Update.
3668         * mi/mi-main.c: Update.
3669         * objc-lang.c: Update.
3670         * p-valprint.c: Update.
3671         * parse.c: Update.
3672         * ppc-linux-tdep.c: Update.
3673         * printcmd.c: Update.
3674         * python/py-arch.c: Update.
3675         * python/py-breakpoint.c: Update.
3676         * python/py-cmd.c: Update.
3677         * python/py-finishbreakpoint.c: Update.
3678         * python/py-frame.c: Update.
3679         * python/py-framefilter.c: Update.
3680         * python/py-gdb-readline.c: Update.
3681         * python/py-inferior.c: Update.
3682         * python/py-infthread.c: Update.
3683         * python/py-lazy-string.c: Update.
3684         * python/py-linetable.c: Update.
3685         * python/py-objfile.c: Update.
3686         * python/py-param.c: Update.
3687         * python/py-prettyprint.c: Update.
3688         * python/py-progspace.c: Update.
3689         * python/py-record-btrace.c: Update.
3690         * python/py-record.c: Update.
3691         * python/py-symbol.c: Update.
3692         * python/py-type.c: Update.
3693         * python/py-unwind.c: Update.
3694         * python/py-utils.c: Update.
3695         * python/py-value.c: Update.
3696         * python/python.c: Update.
3697         * record-btrace.c: Update.
3698         * record-full.c: Update.
3699         * remote-fileio.c: Update.
3700         * remote.c: Update.
3701         * riscv-tdep.c: Update.
3702         * rs6000-aix-tdep.c: Update.
3703         * rs6000-tdep.c: Update.
3704         * rust-exp.y: Update.
3705         * rust-lang.c: Update.
3706         * s390-tdep.c: Update.
3707         * selftest-arch.c: Update.
3708         * solib-dsbt.c: Update.
3709         * solib-frv.c: Update.
3710         * solib-spu.c: Update.
3711         * solib-svr4.c: Update.
3712         * solib.c: Update.
3713         * sparc64-linux-tdep.c: Update.
3714         * stack.c: Update.
3715         * symfile-mem.c: Update.
3716         * symmisc.c: Update.
3717         * target.c: Update.
3718         * thread.c: Update.
3719         * top.c: Update.
3720         * tracefile-tfile.c: Update.
3721         * tui/tui.c: Update.
3722         * typeprint.c: Update.
3723         * unittests/cli-utils-selftests.c: Update.
3724         * unittests/parse-connection-spec-selftests.c: Update.
3725         * valops.c: Update.
3726         * valprint.c: Update.
3727         * value.c: Update.
3728         * varobj.c: Update.
3729         * windows-nat.c: Update.
3730         * x86-linux-nat.c: Update.
3731         * xml-support.c: Update.
3732
3733 2019-04-08  Tom Tromey  <tom@tromey.com>
3734
3735         * xml-support.c: Use C++ exception handling.
3736         * x86-linux-nat.c: Use C++ exception handling.
3737         * windows-nat.c: Use C++ exception handling.
3738         * varobj.c: Use C++ exception handling.
3739         * value.c: Use C++ exception handling.
3740         * valprint.c: Use C++ exception handling.
3741         * valops.c: Use C++ exception handling.
3742         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3743         handling.
3744         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3745         * typeprint.c: Use C++ exception handling.
3746         * tui/tui.c: Use C++ exception handling.
3747         * tracefile-tfile.c: Use C++ exception handling.
3748         * top.c: Use C++ exception handling.
3749         * thread.c: Use C++ exception handling.
3750         * target.c: Use C++ exception handling.
3751         * symmisc.c: Use C++ exception handling.
3752         * symfile-mem.c: Use C++ exception handling.
3753         * stack.c: Use C++ exception handling.
3754         * sparc64-linux-tdep.c: Use C++ exception handling.
3755         * solib.c: Use C++ exception handling.
3756         * solib-svr4.c: Use C++ exception handling.
3757         * solib-spu.c: Use C++ exception handling.
3758         * solib-frv.c: Use C++ exception handling.
3759         * solib-dsbt.c: Use C++ exception handling.
3760         * selftest-arch.c: Use C++ exception handling.
3761         * s390-tdep.c: Use C++ exception handling.
3762         * rust-lang.c: Use C++ exception handling.
3763         * rust-exp.y: Use C++ exception handling.
3764         * rs6000-tdep.c: Use C++ exception handling.
3765         * rs6000-aix-tdep.c: Use C++ exception handling.
3766         * riscv-tdep.c: Use C++ exception handling.
3767         * remote.c: Use C++ exception handling.
3768         * remote-fileio.c: Use C++ exception handling.
3769         * record-full.c: Use C++ exception handling.
3770         * record-btrace.c: Use C++ exception handling.
3771         * python/python.c: Use C++ exception handling.
3772         * python/py-value.c: Use C++ exception handling.
3773         * python/py-utils.c: Use C++ exception handling.
3774         * python/py-unwind.c: Use C++ exception handling.
3775         * python/py-type.c: Use C++ exception handling.
3776         * python/py-symbol.c: Use C++ exception handling.
3777         * python/py-record.c: Use C++ exception handling.
3778         * python/py-record-btrace.c: Use C++ exception handling.
3779         * python/py-progspace.c: Use C++ exception handling.
3780         * python/py-prettyprint.c: Use C++ exception handling.
3781         * python/py-param.c: Use C++ exception handling.
3782         * python/py-objfile.c: Use C++ exception handling.
3783         * python/py-linetable.c: Use C++ exception handling.
3784         * python/py-lazy-string.c: Use C++ exception handling.
3785         * python/py-infthread.c: Use C++ exception handling.
3786         * python/py-inferior.c: Use C++ exception handling.
3787         * python/py-gdb-readline.c: Use C++ exception handling.
3788         * python/py-framefilter.c: Use C++ exception handling.
3789         * python/py-frame.c: Use C++ exception handling.
3790         * python/py-finishbreakpoint.c: Use C++ exception handling.
3791         * python/py-cmd.c: Use C++ exception handling.
3792         * python/py-breakpoint.c: Use C++ exception handling.
3793         * python/py-arch.c: Use C++ exception handling.
3794         * printcmd.c: Use C++ exception handling.
3795         * ppc-linux-tdep.c: Use C++ exception handling.
3796         * parse.c: Use C++ exception handling.
3797         * p-valprint.c: Use C++ exception handling.
3798         * objc-lang.c: Use C++ exception handling.
3799         * mi/mi-main.c: Use C++ exception handling.
3800         * mi/mi-interp.c: Use C++ exception handling.
3801         * mi/mi-cmd-stack.c: Use C++ exception handling.
3802         * mi/mi-cmd-break.c: Use C++ exception handling.
3803         * main.c: Use C++ exception handling.
3804         * linux-thread-db.c: Use C++ exception handling.
3805         * linux-tdep.c: Use C++ exception handling.
3806         * linux-nat.c: Use C++ exception handling.
3807         * linux-fork.c: Use C++ exception handling.
3808         * linespec.c: Use C++ exception handling.
3809         * language.c: Use C++ exception handling.
3810         * jit.c: Use C++ exception handling.
3811         * infrun.c: Use C++ exception handling.
3812         * infcmd.c: Use C++ exception handling.
3813         * infcall.c: Use C++ exception handling.
3814         * inf-loop.c: Use C++ exception handling.
3815         * i386-tdep.c: Use C++ exception handling.
3816         * i386-linux-tdep.c: Use C++ exception handling.
3817         * guile/scm-value.c: Use C++ exception handling.
3818         * guile/scm-type.c: Use C++ exception handling.
3819         * guile/scm-symtab.c: Use C++ exception handling.
3820         * guile/scm-symbol.c: Use C++ exception handling.
3821         * guile/scm-pretty-print.c: Use C++ exception handling.
3822         * guile/scm-ports.c: Use C++ exception handling.
3823         * guile/scm-param.c: Use C++ exception handling.
3824         * guile/scm-math.c: Use C++ exception handling.
3825         * guile/scm-lazy-string.c: Use C++ exception handling.
3826         * guile/scm-frame.c: Use C++ exception handling.
3827         * guile/scm-disasm.c: Use C++ exception handling.
3828         * guile/scm-cmd.c: Use C++ exception handling.
3829         * guile/scm-breakpoint.c: Use C++ exception handling.
3830         * guile/scm-block.c: Use C++ exception handling.
3831         * guile/guile-internal.h: Use C++ exception handling.
3832         * gnu-v3-abi.c: Use C++ exception handling.
3833         * gdbtypes.c: Use C++ exception handling.
3834         * frame.c: Use C++ exception handling.
3835         * frame-unwind.c: Use C++ exception handling.
3836         * fbsd-tdep.c: Use C++ exception handling.
3837         * f-valprint.c: Use C++ exception handling.
3838         * exec.c: Use C++ exception handling.
3839         * event-top.c: Use C++ exception handling.
3840         * event-loop.c: Use C++ exception handling.
3841         * eval.c: Use C++ exception handling.
3842         * dwarf2read.c: Use C++ exception handling.
3843         * dwarf2loc.c: Use C++ exception handling.
3844         * dwarf2-frame.c: Use C++ exception handling.
3845         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3846         * dwarf-index-write.c: Use C++ exception handling.
3847         * dwarf-index-cache.c: Use C++ exception handling.
3848         * dtrace-probe.c: Use C++ exception handling.
3849         * disasm-selftests.c: Use C++ exception handling.
3850         * darwin-nat.c: Use C++ exception handling.
3851         * cp-valprint.c: Use C++ exception handling.
3852         * cp-support.c: Use C++ exception handling.
3853         * cp-abi.c: Use C++ exception handling.
3854         * corelow.c: Use C++ exception handling.
3855         * completer.c: Use C++ exception handling.
3856         * compile/compile-object-run.c: Use C++ exception handling.
3857         * compile/compile-object-load.c: Use C++ exception handling.
3858         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3859         * compile/compile-c-symbols.c: Use C++ exception handling.
3860         * common/selftest.c: Use C++ exception handling.
3861         * common/new-op.c: Use C++ exception handling.
3862         * cli/cli-script.c: Use C++ exception handling.
3863         * cli/cli-interp.c: Use C++ exception handling.
3864         * cli/cli-cmds.c: Use C++ exception handling.
3865         * c-varobj.c: Use C++ exception handling.
3866         * btrace.c: Use C++ exception handling.
3867         * breakpoint.c: Use C++ exception handling.
3868         * break-catch-throw.c: Use C++ exception handling.
3869         * arch-utils.c: Use C++ exception handling.
3870         * amd64-tdep.c: Use C++ exception handling.
3871         * ada-valprint.c: Use C++ exception handling.
3872         * ada-typeprint.c: Use C++ exception handling.
3873         * ada-lang.c: Use C++ exception handling.
3874         * aarch64-tdep.c: Use C++ exception handling.
3875
3876 2019-04-08  Tom Tromey  <tom@tromey.com>
3877
3878         * xml-support.c (gdb_xml_parser::parse): Update.
3879         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3880         * value.c (show_convenience): Update.
3881         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3882         (test_parse_flags_qcs): Update.
3883         * thread.c (thr_try_catch_cmd): Update.
3884         * target.c (target_translate_tls_address): Update.
3885         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3886         (info_frame_command_core, frame_apply_command_count): Update.
3887         * rust-exp.y (rust_lex_exception_test): Update.
3888         * riscv-tdep.c (riscv_print_one_register_info): Update.
3889         * remote.c (remote_target::enable_btrace): Update.
3890         * record-btrace.c (record_btrace_enable_warn): Update.
3891         * python/py-utils.c (gdbpy_convert_exception): Update.
3892         * printcmd.c (do_one_display, print_variable_and_value): Update.
3893         * mi/mi-main.c (mi_print_exception): Update.
3894         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3895         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3896         * linux-nat.c (linux_nat_target::attach): Update.
3897         * linux-fork.c (class scoped_switch_fork_info): Update.
3898         * infrun.c (displaced_step_prepare): Update.
3899         * infcall.c (call_function_by_hand_dummy): Update.
3900         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3901         * gnu-v3-abi.c (print_one_vtable): Update.
3902         * frame.c (get_prev_frame_always): Update.
3903         * f-valprint.c (info_common_command_for_block): Update.
3904         * exec.c (try_open_exec_file): Update.
3905         * exceptions.c (print_exception, exception_print)
3906         (exception_fprintf, exception_print_same): Update.
3907         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3908         * dwarf-index-cache.c (index_cache::store)
3909         (index_cache::lookup_gdb_index): Update.
3910         * darwin-nat.c (maybe_cache_shell): Update.
3911         * cp-valprint.c (cp_print_value_fields): Update.
3912         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3913         (gcc_cplus_symbol_address): Update.
3914         * compile/compile-c-symbols.c (gcc_convert_symbol)
3915         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3916         * common/selftest.c: Update.
3917         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3918         a std::string.
3919         (exception_try_scope_entry, exception_try_scope_exit): Don't
3920         declare.
3921         (struct exception_try_scope): Remove.
3922         (TRY): Don't use exception_try_scope.
3923         (struct gdb_exception): Add constructor, operator=.
3924         <what>: New method.
3925         (struct gdb_exception_RETURN_MASK_ALL)
3926         (struct gdb_exception_RETURN_MASK_ERROR)
3927         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3928         (struct gdb_quit_bad_alloc): Update.
3929         * common/common-exceptions.c (exception_none): Change
3930         initializer.
3931         (struct catcher) <state, exception>: Initialize inline.
3932         <prev>: Remove member.
3933         (current_catcher): Remove.
3934         (catchers): New global.
3935         (exceptions_state_mc_init): Simplify.
3936         (catcher_pop): Remove.
3937         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3938         (try_scope_depth, exception_try_scope_entry)
3939         (exception_try_scope_exit): Remove.
3940         (throw_exception_sjlj): Update.
3941         (exception_messages, exception_messages_size): Remove.
3942         (throw_it): Simplify.
3943         (gdb_exception_sliced_copy): Remove.
3944         (throw_exception_cxx): Update.
3945         * cli/cli-script.c (script_from_file): Update.
3946         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3947         Update.
3948         * ada-valprint.c (ada_val_print): Update.
3949         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3950         (create_excep_cond_exprs): Update.
3951
3952 2019-04-08  Tom Tromey  <tom@tromey.com>
3953
3954         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3955         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3956         (TRY, CATCH, END_CATCH): Remove some definitions.
3957         * common/common-exceptions.c: Don't use GDB_XCPT.
3958         (catcher_list_size): Remove.
3959         (throw_exception, throw_it): Simplify.
3960
3961 2019-04-05  Tom Tromey  <tom@tromey.com>
3962
3963         Revert the header-sorting patch.
3964         * ft32-tdep.c: Revert.
3965         * frv-tdep.c: Revert.
3966         * frv-linux-tdep.c: Revert.
3967         * frame.c: Revert.
3968         * frame-unwind.c: Revert.
3969         * frame-base.c: Revert.
3970         * fork-child.c: Revert.
3971         * findvar.c: Revert.
3972         * findcmd.c: Revert.
3973         * filesystem.c: Revert.
3974         * filename-seen-cache.h: Revert.
3975         * filename-seen-cache.c: Revert.
3976         * fbsd-tdep.c: Revert.
3977         * fbsd-nat.h: Revert.
3978         * fbsd-nat.c: Revert.
3979         * f-valprint.c: Revert.
3980         * f-typeprint.c: Revert.
3981         * f-lang.c: Revert.
3982         * extension.h: Revert.
3983         * extension.c: Revert.
3984         * extension-priv.h: Revert.
3985         * expprint.c: Revert.
3986         * exec.h: Revert.
3987         * exec.c: Revert.
3988         * exceptions.c: Revert.
3989         * event-top.c: Revert.
3990         * event-loop.c: Revert.
3991         * eval.c: Revert.
3992         * elfread.c: Revert.
3993         * dwarf2read.h: Revert.
3994         * dwarf2read.c: Revert.
3995         * dwarf2loc.c: Revert.
3996         * dwarf2expr.h: Revert.
3997         * dwarf2expr.c: Revert.
3998         * dwarf2-frame.c: Revert.
3999         * dwarf2-frame-tailcall.c: Revert.
4000         * dwarf-index-write.h: Revert.
4001         * dwarf-index-write.c: Revert.
4002         * dwarf-index-common.c: Revert.
4003         * dwarf-index-cache.h: Revert.
4004         * dwarf-index-cache.c: Revert.
4005         * dummy-frame.c: Revert.
4006         * dtrace-probe.c: Revert.
4007         * disasm.h: Revert.
4008         * disasm.c: Revert.
4009         * disasm-selftests.c: Revert.
4010         * dictionary.c: Revert.
4011         * dicos-tdep.c: Revert.
4012         * demangle.c: Revert.
4013         * dcache.h: Revert.
4014         * dcache.c: Revert.
4015         * darwin-nat.h: Revert.
4016         * darwin-nat.c: Revert.
4017         * darwin-nat-info.c: Revert.
4018         * d-valprint.c: Revert.
4019         * d-namespace.c: Revert.
4020         * d-lang.c: Revert.
4021         * ctf.c: Revert.
4022         * csky-tdep.c: Revert.
4023         * csky-linux-tdep.c: Revert.
4024         * cris-tdep.c: Revert.
4025         * cris-linux-tdep.c: Revert.
4026         * cp-valprint.c: Revert.
4027         * cp-support.c: Revert.
4028         * cp-namespace.c: Revert.
4029         * cp-abi.c: Revert.
4030         * corelow.c: Revert.
4031         * corefile.c: Revert.
4032         * continuations.c: Revert.
4033         * completer.h: Revert.
4034         * completer.c: Revert.
4035         * complaints.c: Revert.
4036         * coffread.c: Revert.
4037         * coff-pe-read.c: Revert.
4038         * cli-out.h: Revert.
4039         * cli-out.c: Revert.
4040         * charset.c: Revert.
4041         * c-varobj.c: Revert.
4042         * c-valprint.c: Revert.
4043         * c-typeprint.c: Revert.
4044         * c-lang.c: Revert.
4045         * buildsym.c: Revert.
4046         * buildsym-legacy.c: Revert.
4047         * build-id.h: Revert.
4048         * build-id.c: Revert.
4049         * btrace.c: Revert.
4050         * bsd-uthread.c: Revert.
4051         * breakpoint.h: Revert.
4052         * breakpoint.c: Revert.
4053         * break-catch-throw.c: Revert.
4054         * break-catch-syscall.c: Revert.
4055         * break-catch-sig.c: Revert.
4056         * blockframe.c: Revert.
4057         * block.c: Revert.
4058         * bfin-tdep.c: Revert.
4059         * bfin-linux-tdep.c: Revert.
4060         * bfd-target.c: Revert.
4061         * bcache.c: Revert.
4062         * ax-general.c: Revert.
4063         * ax-gdb.h: Revert.
4064         * ax-gdb.c: Revert.
4065         * avr-tdep.c: Revert.
4066         * auxv.c: Revert.
4067         * auto-load.c: Revert.
4068         * arm-wince-tdep.c: Revert.
4069         * arm-tdep.c: Revert.
4070         * arm-symbian-tdep.c: Revert.
4071         * arm-pikeos-tdep.c: Revert.
4072         * arm-obsd-tdep.c: Revert.
4073         * arm-nbsd-tdep.c: Revert.
4074         * arm-nbsd-nat.c: Revert.
4075         * arm-linux-tdep.c: Revert.
4076         * arm-linux-nat.c: Revert.
4077         * arm-fbsd-tdep.c: Revert.
4078         * arm-fbsd-nat.c: Revert.
4079         * arm-bsd-tdep.c: Revert.
4080         * arch-utils.c: Revert.
4081         * arc-tdep.c: Revert.
4082         * arc-newlib-tdep.c: Revert.
4083         * annotate.h: Revert.
4084         * annotate.c: Revert.
4085         * amd64-windows-tdep.c: Revert.
4086         * amd64-windows-nat.c: Revert.
4087         * amd64-tdep.c: Revert.
4088         * amd64-sol2-tdep.c: Revert.
4089         * amd64-obsd-tdep.c: Revert.
4090         * amd64-obsd-nat.c: Revert.
4091         * amd64-nbsd-tdep.c: Revert.
4092         * amd64-nbsd-nat.c: Revert.
4093         * amd64-nat.c: Revert.
4094         * amd64-linux-tdep.c: Revert.
4095         * amd64-linux-nat.c: Revert.
4096         * amd64-fbsd-tdep.c: Revert.
4097         * amd64-fbsd-nat.c: Revert.
4098         * amd64-dicos-tdep.c: Revert.
4099         * amd64-darwin-tdep.c: Revert.
4100         * amd64-bsd-nat.c: Revert.
4101         * alpha-tdep.c: Revert.
4102         * alpha-obsd-tdep.c: Revert.
4103         * alpha-nbsd-tdep.c: Revert.
4104         * alpha-mdebug-tdep.c: Revert.
4105         * alpha-linux-tdep.c: Revert.
4106         * alpha-linux-nat.c: Revert.
4107         * alpha-bsd-tdep.c: Revert.
4108         * alpha-bsd-nat.c: Revert.
4109         * aix-thread.c: Revert.
4110         * agent.c: Revert.
4111         * addrmap.c: Revert.
4112         * ada-varobj.c: Revert.
4113         * ada-valprint.c: Revert.
4114         * ada-typeprint.c: Revert.
4115         * ada-tasks.c: Revert.
4116         * ada-lang.c: Revert.
4117         * aarch64-tdep.c: Revert.
4118         * aarch64-ravenscar-thread.c: Revert.
4119         * aarch64-newlib-tdep.c: Revert.
4120         * aarch64-linux-tdep.c: Revert.
4121         * aarch64-linux-nat.c: Revert.
4122         * aarch64-fbsd-tdep.c: Revert.
4123         * aarch64-fbsd-nat.c: Revert.
4124         * aarch32-linux-nat.c: Revert.
4125
4126 2019-04-05  Tom Tromey  <tom@tromey.com>
4127
4128         * ft32-tdep.c: Sort headers.
4129         * frv-tdep.c: Sort headers.
4130         * frv-linux-tdep.c: Sort headers.
4131         * frame.c: Sort headers.
4132         * frame-unwind.c: Sort headers.
4133         * frame-base.c: Sort headers.
4134         * fork-child.c: Sort headers.
4135         * findvar.c: Sort headers.
4136         * findcmd.c: Sort headers.
4137         * filesystem.c: Sort headers.
4138         * filename-seen-cache.h: Sort headers.
4139         * filename-seen-cache.c: Sort headers.
4140         * fbsd-tdep.c: Sort headers.
4141         * fbsd-nat.h: Sort headers.
4142         * fbsd-nat.c: Sort headers.
4143         * f-valprint.c: Sort headers.
4144         * f-typeprint.c: Sort headers.
4145         * f-lang.c: Sort headers.
4146         * extension.h: Sort headers.
4147         * extension.c: Sort headers.
4148         * extension-priv.h: Sort headers.
4149         * expprint.c: Sort headers.
4150         * exec.h: Sort headers.
4151         * exec.c: Sort headers.
4152         * exceptions.c: Sort headers.
4153         * event-top.c: Sort headers.
4154         * event-loop.c: Sort headers.
4155         * eval.c: Sort headers.
4156         * elfread.c: Sort headers.
4157         * dwarf2read.h: Sort headers.
4158         * dwarf2read.c: Sort headers.
4159         * dwarf2loc.c: Sort headers.
4160         * dwarf2expr.h: Sort headers.
4161         * dwarf2expr.c: Sort headers.
4162         * dwarf2-frame.c: Sort headers.
4163         * dwarf2-frame-tailcall.c: Sort headers.
4164         * dwarf-index-write.h: Sort headers.
4165         * dwarf-index-write.c: Sort headers.
4166         * dwarf-index-common.c: Sort headers.
4167         * dwarf-index-cache.h: Sort headers.
4168         * dwarf-index-cache.c: Sort headers.
4169         * dummy-frame.c: Sort headers.
4170         * dtrace-probe.c: Sort headers.
4171         * disasm.h: Sort headers.
4172         * disasm.c: Sort headers.
4173         * disasm-selftests.c: Sort headers.
4174         * dictionary.c: Sort headers.
4175         * dicos-tdep.c: Sort headers.
4176         * demangle.c: Sort headers.
4177         * dcache.h: Sort headers.
4178         * dcache.c: Sort headers.
4179         * darwin-nat.h: Sort headers.
4180         * darwin-nat.c: Sort headers.
4181         * darwin-nat-info.c: Sort headers.
4182         * d-valprint.c: Sort headers.
4183         * d-namespace.c: Sort headers.
4184         * d-lang.c: Sort headers.
4185         * ctf.c: Sort headers.
4186         * csky-tdep.c: Sort headers.
4187         * csky-linux-tdep.c: Sort headers.
4188         * cris-tdep.c: Sort headers.
4189         * cris-linux-tdep.c: Sort headers.
4190         * cp-valprint.c: Sort headers.
4191         * cp-support.c: Sort headers.
4192         * cp-namespace.c: Sort headers.
4193         * cp-abi.c: Sort headers.
4194         * corelow.c: Sort headers.
4195         * corefile.c: Sort headers.
4196         * continuations.c: Sort headers.
4197         * completer.h: Sort headers.
4198         * completer.c: Sort headers.
4199         * complaints.c: Sort headers.
4200         * coffread.c: Sort headers.
4201         * coff-pe-read.c: Sort headers.
4202         * cli-out.h: Sort headers.
4203         * cli-out.c: Sort headers.
4204         * charset.c: Sort headers.
4205         * c-varobj.c: Sort headers.
4206         * c-valprint.c: Sort headers.
4207         * c-typeprint.c: Sort headers.
4208         * c-lang.c: Sort headers.
4209         * buildsym.c: Sort headers.
4210         * buildsym-legacy.c: Sort headers.
4211         * build-id.h: Sort headers.
4212         * build-id.c: Sort headers.
4213         * btrace.c: Sort headers.
4214         * bsd-uthread.c: Sort headers.
4215         * breakpoint.h: Sort headers.
4216         * breakpoint.c: Sort headers.
4217         * break-catch-throw.c: Sort headers.
4218         * break-catch-syscall.c: Sort headers.
4219         * break-catch-sig.c: Sort headers.
4220         * blockframe.c: Sort headers.
4221         * block.c: Sort headers.
4222         * bfin-tdep.c: Sort headers.
4223         * bfin-linux-tdep.c: Sort headers.
4224         * bfd-target.c: Sort headers.
4225         * bcache.c: Sort headers.
4226         * ax-general.c: Sort headers.
4227         * ax-gdb.h: Sort headers.
4228         * ax-gdb.c: Sort headers.
4229         * avr-tdep.c: Sort headers.
4230         * auxv.c: Sort headers.
4231         * auto-load.c: Sort headers.
4232         * arm-wince-tdep.c: Sort headers.
4233         * arm-tdep.c: Sort headers.
4234         * arm-symbian-tdep.c: Sort headers.
4235         * arm-pikeos-tdep.c: Sort headers.
4236         * arm-obsd-tdep.c: Sort headers.
4237         * arm-nbsd-tdep.c: Sort headers.
4238         * arm-nbsd-nat.c: Sort headers.
4239         * arm-linux-tdep.c: Sort headers.
4240         * arm-linux-nat.c: Sort headers.
4241         * arm-fbsd-tdep.c: Sort headers.
4242         * arm-fbsd-nat.c: Sort headers.
4243         * arm-bsd-tdep.c: Sort headers.
4244         * arch-utils.c: Sort headers.
4245         * arc-tdep.c: Sort headers.
4246         * arc-newlib-tdep.c: Sort headers.
4247         * annotate.h: Sort headers.
4248         * annotate.c: Sort headers.
4249         * amd64-windows-tdep.c: Sort headers.
4250         * amd64-windows-nat.c: Sort headers.
4251         * amd64-tdep.c: Sort headers.
4252         * amd64-sol2-tdep.c: Sort headers.
4253         * amd64-obsd-tdep.c: Sort headers.
4254         * amd64-obsd-nat.c: Sort headers.
4255         * amd64-nbsd-tdep.c: Sort headers.
4256         * amd64-nbsd-nat.c: Sort headers.
4257         * amd64-nat.c: Sort headers.
4258         * amd64-linux-tdep.c: Sort headers.
4259         * amd64-linux-nat.c: Sort headers.
4260         * amd64-fbsd-tdep.c: Sort headers.
4261         * amd64-fbsd-nat.c: Sort headers.
4262         * amd64-dicos-tdep.c: Sort headers.
4263         * amd64-darwin-tdep.c: Sort headers.
4264         * amd64-bsd-nat.c: Sort headers.
4265         * alpha-tdep.c: Sort headers.
4266         * alpha-obsd-tdep.c: Sort headers.
4267         * alpha-nbsd-tdep.c: Sort headers.
4268         * alpha-mdebug-tdep.c: Sort headers.
4269         * alpha-linux-tdep.c: Sort headers.
4270         * alpha-linux-nat.c: Sort headers.
4271         * alpha-bsd-tdep.c: Sort headers.
4272         * alpha-bsd-nat.c: Sort headers.
4273         * aix-thread.c: Sort headers.
4274         * agent.c: Sort headers.
4275         * addrmap.c: Sort headers.
4276         * ada-varobj.c: Sort headers.
4277         * ada-valprint.c: Sort headers.
4278         * ada-typeprint.c: Sort headers.
4279         * ada-tasks.c: Sort headers.
4280         * ada-lang.c: Sort headers.
4281         * aarch64-tdep.c: Sort headers.
4282         * aarch64-ravenscar-thread.c: Sort headers.
4283         * aarch64-newlib-tdep.c: Sort headers.
4284         * aarch64-linux-tdep.c: Sort headers.
4285         * aarch64-linux-nat.c: Sort headers.
4286         * aarch64-fbsd-tdep.c: Sort headers.
4287         * aarch64-fbsd-nat.c: Sort headers.
4288         * aarch32-linux-nat.c: Sort headers.
4289
4290 2019-04-04  Tom Tromey  <tom@tromey.com>
4291
4292         * varobj.c (varobj_create): Update.
4293         * rust-exp.y (struct rust_parser) <update_innermost_block,
4294         lookup_symbol>: New methods.
4295         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4296         Rename.
4297         (rust_parser::rust_lookup_type)
4298         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4299         * printcmd.c (display_command, do_one_display): Update.
4300         * parser-defs.h (struct parser_state) <parser_state>: Add
4301         "tracker" parameter.
4302         (block_tracker): New member.
4303         (class innermost_block_tracker) <innermost_block_tracker>: Add
4304         "types" parameter.
4305         <reset>: Remove method.
4306         (innermost_block): Don't declare.
4307         (null_post_parser): Update.
4308         * parse.c (innermost_block): Remove global.
4309         (write_dollar_variable): Update.
4310         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4311         Remove "tracker_types" parameter.
4312         (parse_expression): Add "tracker" parameter.
4313         (parse_expression_for_completion): Update.
4314         (null_post_parser): Add "tracker" parameter.
4315         * p-exp.y: Update rules.
4316         * m2-exp.y: Update rules.
4317         * language.h (struct language_defn) <la_post_parser>: Add
4318         "tracker" parameter.
4319         * go-exp.y: Update rules.
4320         * f-exp.y: Update rules.
4321         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4322         parameter.
4323         * d-exp.y: Update rules.
4324         * c-exp.y: Update rules.
4325         * breakpoint.c (set_breakpoint_condition): Create an
4326         innermost_block_tracker.
4327         (watch_command_1): Likewise.
4328         * ada-lang.c (resolve): Add "tracker" parameter.
4329         (resolve_subexp): Likewise.
4330         * ada-exp.y (write_var_from_sym): Update.
4331
4332 2019-04-04  Tom Tromey  <tom@tromey.com>
4333
4334         * type-stack.h: New file.
4335         * type-stack.c: New file.
4336         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4337         type-stack.h.
4338         (insert_into_type_stack, insert_type, push_type, push_type_int)
4339         (insert_type_address_space, pop_type, pop_type_int)
4340         (pop_typelist, pop_type_stack, append_type_stack)
4341         (push_type_stack, get_type_stack, push_typelist)
4342         (follow_type_instance_flags, follow_types): Don't declare.
4343         * parse.c (type_stack): Remove global.
4344         (parse_exp_in_context): Update.
4345         (insert_into_type_stack, insert_type, push_type, push_type_int)
4346         (insert_type_address_space, pop_type, pop_type_int)
4347         (pop_typelist, pop_type_stack, append_type_stack)
4348         (push_type_stack, get_type_stack, push_typelist)
4349         (follow_type_instance_flags, follow_types): Remove (moved to
4350         type-stack.c).
4351         * f-exp.y (type_stack): New global.
4352         Update rules.
4353         (push_kind_type, f_parse): Update.
4354         * d-exp.y (type_stack): New global.
4355         Update rules.
4356         (d_parse): Update.
4357         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4358         Update rules.
4359         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4360         (HFILES_NO_SRCDIR): Add type-stack.h.
4361
4362 2019-04-04  Tom Tromey  <tom@tromey.com>
4363
4364         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4365         (rust_parser::convert_ast_to_expression, rust_parse)
4366         (rust_lex_test_completion, rust_lex_tests): Update.
4367         * parser-defs.h (struct expr_completion_state): New.
4368         (struct parser_state) <parser_state>: Add completion parameter.
4369         <mark_struct_expression, mark_completion_tag>: New methods.
4370         <parse_completion, m_completion_state>: New members.
4371         (prefixify_expression, null_post_parser): Update.
4372         (mark_struct_expression, mark_completion_tag): Don't declare.
4373         * parse.c (parse_completion, expout_last_struct)
4374         (expout_tag_completion_type, expout_completion_name): Remove
4375         globals.
4376         (parser_state::mark_struct_expression)
4377         (parser_state::mark_completion_tag): Now methods.
4378         (prefixify_expression): Add last_struct parameter.
4379         (prefixify_subexp): Likewise.
4380         (parse_exp_1): Update.
4381         (parse_exp_in_context): Add cstate parameter.  Update.
4382         (parse_expression_for_completion): Create an
4383         expr_completion_state.
4384         (null_post_parser): Add "completion" parameter.
4385         * p-exp.y: Update rules.
4386         (yylex): Update.
4387         * language.h (struct language_defn) <la_post_parser>: Add
4388         "completing" parameter.
4389         * go-exp.y: Update rules.
4390         (lex_one_token): Update.
4391         * expression.h (parse_completion): Don't declare.
4392         * d-exp.y: Update rules.
4393         (lex_one_token): Update rules.
4394         * c-exp.y: Update rules.
4395         (lex_one_token): Update.
4396         * ada-lang.c (resolve): Add "parse_completion" parameter.
4397         (resolve_subexp): Likewise.
4398         (ada_resolve_function): Likewise.
4399
4400 2019-04-04  Tom Tromey  <tom@tromey.com>
4401
4402         * parser-defs.h (struct parser_state) <start_arglist,
4403         end_arglist>: New methods.
4404         <arglist_len, m_funcall_chain>: New members.
4405         (arglist_len, start_arglist, end_arglist): Don't declare.
4406         * parse.c (arglist_len, funcall_chain): Remove global.
4407         (start_arglist, end_arglist): Remove functions.
4408         (parse_exp_in_context): Update.
4409         * p-exp.y: Update rules.
4410         * m2-exp.y: Update rules.
4411         * go-exp.y: Update rules.
4412         * f-exp.y: Update rules.
4413         * d-exp.y: Update rules.
4414         * c-exp.y: Update rules.
4415
4416 2019-04-04  Tom Tromey  <tom@tromey.com>
4417
4418         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4419         lex_operator, push_back>: New methods.
4420         Update all rules.
4421         (rust_parser::lex_hex, lex_escape): Rename and update.
4422         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4423         (rust_parser::lex_operator): Rename and update.
4424         (rust_parser::lex_number, rustyylex, rustyyerror)
4425         (rust_lex_test_init, rust_lex_test_sequence)
4426         (rust_lex_test_push_back, rust_lex_tests): Update.
4427         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4428         parameter.
4429         <lexptr, prev_lexptr>: New members.
4430         (lexptr, prev_lexptr): Don't declare.
4431         * parse.c (lexptr, prev_lexptr): Remove globals.
4432         (parse_exp_in_context): Update.
4433         * p-exp.y (yylex, yyerror): Update.
4434         * m2-exp.y (parse_number, yylex, yyerror): Update.
4435         * go-exp.y (lex_one_token, yyerror): Update.
4436         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4437         * d-exp.y (lex_one_token, yyerror): Update.
4438         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4439         (lex_one_token, yyerror): Update.
4440         * ada-lex.l (YY_INPUT): Update.
4441         (rewind_to_char): Update.
4442         * ada-exp.y (yyerror): Update.
4443
4444 2019-04-04  Tom Tromey  <tom@tromey.com>
4445
4446         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4447         * parser-defs.h (struct parser_state) <parser_state>: Add new
4448         parameter.
4449         <comma_terminates>: New member.
4450         (comma_terminates): Don't declare global.
4451         * parse.c (comma_terminates): Remove global.
4452         (parse_exp_in_context): Update.
4453         * p-exp.y (yylex): Update.
4454         * m2-exp.y (yylex): Update.
4455         * go-exp.y (lex_one_token): Update.
4456         * f-exp.y (yylex): Update.
4457         * d-exp.y (lex_one_token): Update.
4458         * c-exp.y (lex_one_token): Update.
4459         * ada-lex.l: Update.
4460
4461 2019-04-04  Tom Tromey  <tom@tromey.com>
4462
4463         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4464         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4465         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4466         * parser-defs.h (paren_depth): Don't declare.
4467         * parse.c (paren_depth): Remove global.
4468         (parse_exp_in_context): Update.
4469         * p-exp.y (paren_depth): New global.
4470         (pascal_parse): Initialize it.
4471         * m2-exp.y (paren_depth): New global.
4472         (m2_parse): Initialize it.
4473         * go-exp.y (paren_depth): New global.
4474         (go_parse): Initialize it.
4475         * f-exp.y (paren_depth): New global.
4476         (f_parse): Initialize it.
4477         * d-exp.y (paren_depth): New global.
4478         (d_parse): Initialize it.
4479         * c-exp.y (paren_depth): New global.
4480         (c_parse): Initialize it.
4481         * ada-lex.l (paren_depth): New global.
4482         (lexer_init): Initialize it.
4483
4484 2019-04-04  Tom Tromey  <tom@tromey.com>
4485
4486         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4487         (rust_parser::convert_ast_to_type)
4488         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4489         * parser-defs.h (struct parser_state) <parser_state>: Add
4490         parameters.  Initialize new members.
4491         <expression_context_block, expression_context_pc>: New members.
4492         * parse.c (expression_context_block, expression_context_pc):
4493         Remove globals.
4494         (parse_exp_in_context): Update.
4495         * p-exp.y: Update all rules.
4496         (yylex): Update.
4497         * m2-exp.y: Update all rules.
4498         (yylex): Update.
4499         * go-exp.y (yylex): Update.
4500         * f-exp.y (yylex): Update.
4501         * d-exp.y: Update all rules.
4502         (yylex): Update.
4503         * c-exp.y: Update all rules.
4504         (lex_one_token, classify_name, yylex, c_parse): Update.
4505         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4506
4507 2019-04-04  Tom Tromey  <tom@tromey.com>
4508
4509         * gdbarch.h, gdbarch.c: Rebuild.
4510         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4511         * stap-probe.h:
4512         (struct stap_parse_info): Replace "parser_state" with
4513         "expr_builder".
4514         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4515         (parser_state): New class.
4516         * parse.c (expr_builder): Rename.
4517         (expr_builder::release): Rename.
4518         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4519         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4520         (write_exp_elt_longcst, write_exp_elt_floatcst)
4521         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4522         (write_exp_string_vector, write_exp_bitstring)
4523         (write_exp_msymbol, mark_struct_expression)
4524         (write_dollar_variable)
4525         (insert_type_address_space, increase_expout_size): Replace
4526         "parser_state" with "expr_builder".
4527         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4528         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4529         "parser_state" with "expr_builder".
4530
4531 2019-04-04  Tom Tromey  <tom@tromey.com>
4532
4533         * rust-exp.y: Replace "parse_language" with method call.
4534         * p-exp.y:
4535         (yylex): Replace "parse_language" with method call.
4536         * m2-exp.y:
4537         (yylex): Replace "parse_language" with method call.
4538         * go-exp.y (classify_name): Replace "parse_language" with method
4539         call.
4540         * f-exp.y (yylex): Replace "parse_language" with method call.
4541         * d-exp.y (lex_one_token): Replace "parse_language" with method
4542         call.
4543         * c-exp.y:
4544         (lex_one_token, classify_name, yylex): Replace "parse_language"
4545         with method call.
4546         * ada-exp.y (find_primitive_type, type_char)
4547         (type_system_address): Replace "parse_language" with method call.
4548
4549 2019-04-04  Tom Tromey  <tom@tromey.com>
4550
4551         * rust-exp.y: Replace "parse_gdbarch" with method call.
4552         * parse.c (write_dollar_variable, insert_type_address_space):
4553         Replace "parse_gdbarch" with method call.
4554         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4555         call.
4556         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4557         call.
4558         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4559         "parse_gdbarch" with method call.
4560         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4561         with method call.
4562         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4563         "parse_gdbarch" with method call.
4564         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4565         "parse_gdbarch" with method call.
4566         * c-exp.y (parse_type, parse_number, classify_name): Replace
4567         "parse_gdbarch" with method call.
4568         * ada-lex.l: Replace "parse_gdbarch" with method call.
4569         * ada-exp.y (parse_type, find_primitive_type, type_char)
4570         (type_system_address): Replace "parse_gdbarch" with method call.
4571
4572 2019-04-04  Tom Tromey  <tom@tromey.com>
4573
4574         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4575         * stap-probe.c (stap_parse_argument): Update.
4576         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4577         initial_size parameter.
4578         * rust-exp.y (rust_lex_tests): Update.
4579         * parse.c (parser_state): Update.
4580         (parse_exp_in_context): Update.
4581         * parser-defs.h (struct parser_state) <parser_state>: Remove
4582         "initial_size" parameter.
4583
4584 2019-04-04  Tom Tromey  <tom@tromey.com>
4585
4586         * parser-defs.h (increase_expout_size): Don't declare.
4587         * parse.c (increase_expout_size): Now static.
4588
4589 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4590
4591         * gnu-nat.c (gnu_nat_target::wait): Fix
4592         target_waitstatus_to_string call.
4593
4594 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4595
4596         * eval.c (evaluate_subexp_standard): Handle internal functions
4597         during Fortran function call handling.
4598
4599 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4600
4601         * NEWS: Mention new internal functions.
4602         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4603         (read_base_type): Use dwarf2_init_complex_target_type.
4604         * value.c (creal_internal_fn): New function.
4605         (cimag_internal_fn): New function.
4606         (_initialize_values): Register new internal functions.
4607
4608 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4609
4610         * infrun.c (stop_all_threads): If debug_infrun, always
4611         trace the wait status after wait_one, using
4612         target_waitstatus_to_string and target_pid_to_str.
4613         (handle_inferior_event): Replace various trace of
4614         wait status kind by a single trace.
4615         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4616         wait status kind image by target_waitstatus_to_string.
4617         * target/waitstatus.c (target_waitstatus_to_string): Fix
4618         obsolete comment.
4619
4620 2019-04-01  Tom Tromey  <tromey@adacore.com>
4621
4622         PR symtab/23331:
4623         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4624
4625 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4626             Pedro Alves  <palves@redhat.com>
4627
4628         * top.c (quit_force): Call 'finalize_values'.
4629         * value.c (finalize_values): New function.
4630         * value.h (finalize_values): Declare.
4631
4632 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4633
4634         * NEWS: Announce $_gdb_major and $_gdb_minor.
4635
4636         * top.c (init_gdb_version_vars): New function.
4637         (gdb_init): Call init_gdb_version_vars.
4638
4639 2019-03-29  Tom Tromey  <tromey@adacore.com>
4640
4641         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4642         help text.  Remove dead code.
4643
4644 2019-03-29  Keith Seitz  <keiths@redhat.com>
4645
4646         From Siddhesh Poyarekar:
4647         * f-lang.h (f77_get_upperbound): Return LONGEST.
4648         (f77_get_lowerbound): Likewise.
4649         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4650         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4651         print them.
4652         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4653         plongest to format print it.
4654         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4655         (f77_get_upperbound): Likewise.
4656         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4657         LOWER_BOUND to LONGEST.
4658         (f77_create_arrayprint_offset_tbl): Likewise.
4659
4660 2019-03-29  Keith Seitz  <keiths@redhat.com>
4661
4662         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4663         %s/pulongest for TYPE_LENGTH instead of %d in format
4664         strings.
4665         * ada-typerint.c (ada_print_type): Likewise.
4666         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4667         * compile/compile-c-support.c (generate_register_struct): Likewise.
4668         * gdbtypes.c (recursive_dump_type): Likewise.
4669         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4670         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4671         instead of %d in format strings.
4672         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4673         to std::min to ULONGEST.
4674         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4675         instead of %d in format strings.
4676         * tracepoint.c (info_scope_command): Likewise.
4677         * typeprint.c (print_offset_data::update)
4678         (print_offset_data::finish): Likewise.
4679         * xtensa-tdep.c (xtensa_store_return_value)
4680         (xtensa_push_dummy_call): Likewise.
4681
4682 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4683
4684         * windows-nat.c (display_selector): Fixed format specifications
4685         for 64-bit Cygwin.
4686
4687 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4688
4689         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4690
4691 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4692
4693         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4694         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4695         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4696         (nios2_linux_init_abi): Install it.
4697
4698 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4699
4700         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4701
4702 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4703
4704         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4705
4706 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4707             Tom Tromey  <tromey@adacore.com>
4708
4709         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4710
4711 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4712
4713         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4714         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4715         method to compute the bounds of range types. Also print "[evaluated]"
4716         if the bounds' values come from a dynamic evaluation.
4717
4718 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4719
4720         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4721         whitespace when pretty printing is on.
4722
4723 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4724
4725         * ppc-linux-nat.c: Add include.
4726
4727 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4728
4729         * NEWS: Mention AArch64 Pointer Authentication.
4730
4731 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4732
4733         * arm-linux-nat.c: Add include.
4734
4735 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4736
4737         * source-cache.c (source_cache::get_source_lines): Re-read
4738         fullname after calling open_source_file.
4739
4740 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4741
4742         * NEWS: Mention TLS support for FreeBSD.
4743
4744 2019-03-25  Tom Tromey  <tromey@adacore.com>
4745
4746         * minsyms.c (BUNCH_SIZE): Update comment.
4747         (~minimal_symbol_reader): Remove old comment.
4748         (compact_minimal_symbols): Update comment.
4749         (minimal_symbol_reader::install): Remove old comment.  Update
4750         other comments.
4751
4752 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4753
4754         * s390-linux-nat.c: Add include.
4755
4756 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4757
4758         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4759         Call linux_get_hwcap.
4760         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4761         Likewise.
4762         (aarch64_linux_get_hwcap): Remove function.
4763         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4764         declaration.
4765         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4766         linux_get_hwcap.
4767         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4768         * linux-tdep.c (linux_get_hwcap): Add function.
4769         (linux_get_hwcap2): Likewise.
4770         * linux-tdep.h (linux_get_hwcap): Add declaration.
4771         (linux_get_hwcap2): Likewise.
4772         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4773         (ppc_linux_get_hwcap2): Likewise.
4774         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4775         linux_get_hwcap.
4776         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4777         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4778         (ppc_linux_nat_target::read_description): Likewise.
4779         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4780         * s390-linux-nat.c: Likewise.
4781         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4782
4783 2019-03-24  Tom Tromey  <tom@tromey.com>
4784
4785         * ada-lang.c (standard_lookup): Simplify initialization.
4786         (ada_lookup_symbol_nonlocal): Simplify return.
4787         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4788         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4789         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4790         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4791         initialization.
4792         * solib.c (solib_global_lookup): Simplify.
4793         * symtab.c (null_block_symbol): Remove.
4794         (symbol_cache_lookup): Simplify returns.
4795         (lookup_language_this): Simplify returns.
4796         (lookup_symbol_aux): Simplify return.
4797         (lookup_local_symbol): Simplify returns.
4798         (lookup_global_symbol_from_objfile): Simplify return.
4799         (lookup_symbol_in_objfile_symtabs)
4800         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4801         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4802         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4803         * cp-namespace.c (cp_lookup_bare_symbol)
4804         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4805         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4806         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4807         (cp_lookup_symbol_via_imports): Simplify initialization.
4808         (find_symbol_in_baseclass): Likewise.
4809         * symtab.h (null_block_symbol): Remove.
4810         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4811         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4812         (d_lookup_symbol_module): Likewise.
4813         (find_symbol_in_baseclass): Simplify initialization.
4814
4815 2019-03-24  Tom Tromey  <tom@tromey.com>
4816
4817         * expression.h: Don't include symtab.h.
4818         (struct block): Forward declare.
4819
4820 2019-03-24  Tom Tromey  <tom@tromey.com>
4821
4822         * c-exp.y (typebase): Remove casts.
4823         * gdbtypes.c (lookup_unsigned_typename, )
4824         (lookup_signed_typename): Remove cast.
4825         * eval.c (parse_to_comma_and_eval): Remove cast.
4826         * parse.c (write_dollar_variable): Remove cast.
4827         * block.h (struct block) <superblock>: Now const.
4828         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4829         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4830         (map_block): Make "block" const.
4831         * symfile.h (struct quick_symbol_functions)
4832         <map_matching_symbols>: Constify block argument to "callback".
4833         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4834         const.
4835         (find_pc_sect_compunit_symtab): Make "b" const.
4836         (find_symbol_at_address): Likewise.
4837         (search_symbols): Likewise.
4838         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4839         (dw2_debug_names_lookup_symbol): Likewise.
4840         (dw2_map_matching_symbols): Update.
4841         * p-valprint.c (pascal_val_print): Remove "block".
4842         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4843         (aux_add_nonlocal_symbols): Make "block" const.
4844         (resolve_subexp): Remove cast.
4845         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4846         const.
4847         (iterate_over_file_blocks): Likewise.
4848         * f-exp.y (%union) <bval>: Remove.
4849         * coffread.c (patch_opaque_types): Make "b" const.
4850         * spu-tdep.c (spu_catch_start): Make "block" const.
4851         * c-valprint.c (print_unpacked_pointer): Remove "block".
4852         * symmisc.c (dump_symtab_1): Make "b" const.
4853         (block_depth): Make "block" const.
4854         * d-exp.y (%union) <bval>: Remove.
4855         * cp-support.h (cp_lookup_rtti_type): Update.
4856         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4857         * psymtab.c (psym_lookup_symbol): Make "block" const.
4858         (maintenance_check_psymtabs): Make "b" const.
4859         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4860         (enumerate_locals, enumerate_args): Update.
4861         * python/py-symtab.c (stpy_global_block): Make "block" const.
4862         (stpy_static_block): Likewise.
4863         * inline-frame.c (block_starting_point_at): Make "new_block"
4864         const.
4865         * block.c (find_block_in_blockvector): Make return type const.
4866         (blockvector_for_pc_sect): Make "b" const.
4867         (find_block_in_blockvector): Make "b" const.
4868
4869 2019-03-23  Tom Tromey  <tom@tromey.com>
4870
4871         * varobj.c (varobj_create): Update.
4872         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4873         * printcmd.c (display_command, do_one_display): Don't reset
4874         innermost_block.
4875         * parser-defs.h (enum innermost_block_tracker_type): Move to
4876         expression.h.
4877         (innermost_block): Update comment.
4878         * parse.c (parse_exp_1): Add tracker_types parameter.
4879         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4880         tracker_types parameter.  Reset innermost_block.
4881         (parse_exp_in_context): Remove.
4882         (parse_expression_for_completion): Update.
4883         * objfiles.c (~objfile): Don't reset expression_context_block or
4884         innermost_block.
4885         * expression.h (enum innermost_block_tracker_type): Move from
4886         parser-defs.h.
4887         (parse_exp_1): Add tracker_types parameter.
4888         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4889         reset innermost_block.
4890
4891 2019-03-23  Tom Tromey  <tom@tromey.com>
4892
4893         * objfiles.h: Include bcache.h.
4894
4895 2019-03-23  Tom Tromey  <tom@tromey.com>
4896
4897         * linespec.c (get_current_search_block): Use
4898         scoped_restore_current_language.
4899         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4900
4901 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4902             Jiong Wang  <jiong.wang@arm.com>
4903
4904         * aarch64-linux-tdep.c
4905         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4906         section.
4907         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4908
4909 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4910             Jiong Wang  <jiong.wang@arm.com>
4911
4912         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4913         instructions.
4914         (aarch64_analyze_prologue_test): Add PACIASP test.
4915         (aarch64_prologue_prev_register): Unmask PC value.
4916
4917 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4918             Jiong Wang  <jiong.wang@arm.com>
4919
4920         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4921         (aarch64_dwarf2_prev_register): Unmask PC value.
4922         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4923         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4924         DW_CFA_AARCH64_negate_ra_state.
4925         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4926
4927 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4928             Jiong Wang  <jiong.wang@arm.com>
4929
4930         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4931         registers.
4932         (aarch64_pseudo_register_name): Likewise.
4933         (aarch64_pseudo_register_type): Likewise.
4934         (aarch64_pseudo_register_reggroup_p): Likewise.
4935         (aarch64_gdbarch_init): Add pauth registers.
4936         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4937         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4938         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4939         (struct gdbarch_tdep): Add regnum for ra_state.
4940
4941 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4942             Jiong Wang  <jiong.wang@arm.com>
4943
4944         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4945
4946 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4947             Jiong Wang  <jiong.wang@arm.com>
4948
4949         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4950         function.
4951         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4952         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4953         (aarch64_gdbarch_init): Add puth registers.
4954         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4955         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4956         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4957
4958 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4959             Jiong Wang  <jiong.wang@arm.com>
4960
4961         * aarch64-linux-nat.c
4962         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4963         * aarch64-linux-tdep.c
4964         (aarch64_linux_core_read_description): Likewise.
4965         (aarch64_linux_get_hwcap): New function.
4966         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4967         (aarch64_linux_get_hwcap): New declaration.
4968
4969 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4970             Jiong Wang  <jiong.wang@arm.com>
4971
4972         * aarch64-linux-nat.c
4973         (aarch64_linux_nat_target::read_description): Add pauth param.
4974         * aarch64-linux-tdep.c
4975         (aarch64_linux_core_read_description): Likewise.
4976         * aarch64-tdep.c (struct target_desc): Add in pauth.
4977         (aarch64_read_description): Add pauth param.
4978         (aarch64_gdbarch_init): Likewise.
4979         * aarch64-tdep.h (aarch64_read_description): Likewise.
4980         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4981         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4982         * features/Makefile: Add new files.
4983         * features/aarch64-pauth.c: New file.
4984         * features/aarch64-pauth.xml: New file.
4985
4986 2019-03-20  Tom Tromey  <tromey@adacore.com>
4987
4988         * infrun.c (handle_inferior_event): Rename from
4989         handle_inferior_event_1.  Create a scoped_value_mark.
4990         (handle_inferior_event): Remove.
4991
4992 2019-03-19  Tom Tromey  <tromey@adacore.com>
4993
4994         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4995         * infrun.h (print_stop_event): Add "displays" parameter.
4996         * infrun.c (print_stop_event): Add "displays" parameter.
4997
4998 2019-03-19  Pedro Alves  <palves@redhat.com>
4999
5000         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5001         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5002         to -1.  Fix TABs vs spaces.
5003         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5004         * tui/tui-out.h (tui_ui_out) Add intro comments.
5005         <m_line, m_start_of_line>: In-class initialize, and add describing
5006         comment.
5007
5008 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5009
5010         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5011         variable names.
5012         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5013
5014 2019-03-18  Pedro Alves  <palves@redhat.com>
5015             Eli Zaretskii <eliz@gnu.org>
5016
5017         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5018         m_line and m_start_of_line.
5019
5020 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5021
5022         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5023         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5024         it returns a newline.  This fixes a regression in TU mode, whereby
5025         the next line is output on the same screen line as the user input.
5026
5027 2019-03-18  Tom Tromey  <tromey@adacore.com>
5028
5029         * minsyms.c (minimal_symbol_reader::install): Remove call to
5030         obstack_blank.
5031
5032 2019-03-18  Pedro Alves  <palves@redhat.com>
5033
5034         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5035         New globals.
5036         (apply_style): New, factored out from ...
5037         (apply_ansi_escape): ... this.  Handle reverse video mode.
5038         (tui_set_reverse_mode): New function.
5039         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5040         * tui/tui-winsource.c (tui_show_source_line): Use
5041         tui_set_reverse_mode instead of setting A_STANDOUT.
5042         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5043         New setter methods.
5044
5045 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5046
5047         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5048         Handle tabs.
5049
5050 2019-03-18  Tom Tromey  <tromey@adacore.com>
5051
5052         * ada-lang.c (empty_array): Add "high" parameter.
5053         (ada_evaluate_subexp): Update.
5054
5055 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5056
5057         * unittests/string_view-selftests.c: Define
5058         _initialize_string_view_selftests unconditionally.
5059
5060 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5061
5062         PR gdb/24350
5063         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5064
5065 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5066
5067         PR gdb/24351
5068         * windows-nat.c (display_selector): Fix format specifiers.
5069
5070 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5071
5072         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5073         tui_refill_source_window instead of tui_refresh_win, to update the
5074         current execution line.  This fixes redisplay of the current line
5075         when stepping through the code with "next" or "step".
5076
5077 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5078
5079         * source-cache.c (source_cache::get_source_lines): Call
5080         find_source_lines to initialize s->nlines.  This fixes vertical
5081         scrolling of TUI source window when the DOWN arrow is pressed.
5082
5083 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5084
5085         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5086         linux-thread-db.c (_initialize_thread_db): Likewise.
5087
5088 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5089
5090         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5091         wclrtoeol in tui_show_source_line".  This reverts changes made in
5092         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5093
5094 2019-03-15  Tom Tromey  <tom@tromey.com>
5095
5096         * symtab.h (struct minimal_symbol): Derive from
5097         general_symbol_info.
5098         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5099         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5100         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5101         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5102         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5103         (MSYMBOL_SEARCH_NAME): Update.
5104         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5105         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5106         * minsyms.c (minimal_symbol_reader::record_full): Update.
5107
5108 2019-03-15  Tom Tromey  <tom@tromey.com>
5109
5110         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5111
5112 2019-03-15  Tom Tromey  <tom@tromey.com>
5113
5114         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5115         unique_xmalloc_ptr.
5116         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5117         Update.
5118         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5119         (build_minimal_symbol_hash_tables)
5120         (minimal_symbol_reader::install): Update.
5121
5122 2019-03-15  Tom Tromey  <tom@tromey.com>
5123
5124         * symtab.c (create_demangled_names_hash): Update.
5125         (symbol_set_names): Update.
5126         * objfiles.h (struct objfile_per_bfd_storage)
5127         <demangled_names_hash>: Now an htab_up.
5128         * objfiles.c (objfile_per_bfd_storage): Simplify.
5129
5130 2019-03-15  Tom Tromey  <tom@tromey.com>
5131
5132         * objfiles.h (struct objfile_per_bfd_storage): Declare
5133         destructor.
5134         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5135         New.
5136         (get_objfile_bfd_data): Use new.  Don't initialize
5137         language_of_main.
5138         (free_objfile_per_bfd_storage): Remove.
5139         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5140
5141 2019-03-15  Tom Tromey  <tom@tromey.com>
5142
5143         * symfile.c (reread_symbols): Update.
5144         * objfiles.c (objfile::objfile): Update.
5145         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5146         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5147         comment.
5148         (minimal_symbol_reader::install): Update.
5149         (terminate_minimal_symbol_table): Remove.
5150         * jit.c (jit_object_close_impl): Update.
5151
5152 2019-03-15  Tom Tromey  <tom@tromey.com>
5153
5154         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5155         initializations.
5156
5157 2019-03-15  Tom Tromey  <tom@tromey.com>
5158
5159         * objfiles.h (struct objfile_per_bfd_storage)
5160         <demangled_hash_languages>: Now a bitset.
5161         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5162         (lookup_minimal_symbol): Update.
5163
5164 2019-03-15  Tom Tromey  <tom@tromey.com>
5165
5166         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5167         Don't return the symbol.
5168         * coffread.c (record_minimal_symbol): Use record_full.
5169
5170 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5171
5172         The MS-Windows port of ncurses fails to switch to a color pair if
5173         one or both of the colors are the implicit default colors.  This
5174         change records the default colors when TUI is initialized, and
5175         then specifies them explicitly when a color pair uses the default
5176         colors.  This allows color styling in TUI mode on MS-Windows.
5177
5178         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5179         ncurses_norm_attr.
5180         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5181         colors in ncurses_norm_attr.
5182         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5183         "none", replace it with the default color recorded in
5184         ncurses_norm_attr.
5185
5186 2019-03-14  Tom Tromey  <tromey@adacore.com>
5187
5188         * source-cache.h (class source_cache) <get_source_lines>: Return
5189         std::string.
5190         * source-cache.c (source_cache::extract_lines): Handle case where
5191         first_pos==npos.  Return std::string.
5192         (source_cache::get_source_lines): Update.
5193
5194 2019-03-14  Tom Tromey  <tromey@adacore.com>
5195
5196         * NEWS: Add item for "style sources" commands.
5197         * source-cache.c (source_cache::get_source_lines): Check
5198         source_styling.
5199         * cli/cli-style.c (source_styling): New global.
5200         (_initialize_cli_style): Add "style sources" commands.
5201         (show_style_sources): New function.
5202         * cli/cli-style.h (source_styling): Declare.
5203
5204 2019-03-14  Pedro Alves  <palves@redhat.com>
5205             Tom Tromey  <tromey@adacore.com>
5206
5207         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5208         * tui/tui-winsource.c (tui_refill_source_window): New function,
5209         from...
5210         (tui_horizontal_source_scroll): ... here.  Move some logic.
5211         * cli/cli-style.c (set_style_enabled): Notify new observable.
5212         * tui/tui-hooks.c (tui_redisplay_source): New function.
5213         (tui_attach_detach_observers): Attach or detach
5214         tui_redisplay_source.
5215         * observable.h (source_styling_changed): New observable.
5216         * observable.c: Define source_styling_changed observable.
5217
5218 2019-03-13  Tom Tromey  <tromey@adacore.com>
5219
5220         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5221         (i386_gnu_nat_target::store_registers): Update.
5222         * target-debug.h (target_debug_print_std_string): New macro.
5223         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5224         * windows-tdep.c (display_one_tib): Update.
5225         * tui/tui-stack.c (tui_make_status_line): Update.
5226         * top.c (print_inferior_quit_action): Update.
5227         * thread.c (thr_try_catch_cmd): Update.
5228         (add_thread_with_info): Update.
5229         (thread_target_id_str): Update.
5230         (thr_try_catch_cmd): Update.
5231         (thread_command): Update.
5232         (thread_find_command): Update.
5233         * record-btrace.c (record_btrace_target::info_record)
5234         (record_btrace_resume_thread, record_btrace_target::resume)
5235         (record_btrace_cancel_resume, record_btrace_step_thread)
5236         (record_btrace_target::wait, record_btrace_target::wait)
5237         (record_btrace_target::wait, record_btrace_target::stop): Update.
5238         * progspace.c (print_program_space): Update.
5239         * process-stratum-target.c
5240         (process_stratum_target::thread_address_space): Update.
5241         * linux-fork.c (linux_fork_mourn_inferior)
5242         (detach_checkpoint_command, info_checkpoints_command)
5243         (linux_fork_context): Update.
5244         (linux_fork_detach): Update.
5245         (class scoped_switch_fork_info): Update.
5246         (delete_checkpoint_command): Update.
5247         * infrun.c (follow_fork_inferior): Update.
5248         (follow_fork_inferior): Update.
5249         (proceed_after_vfork_done): Update.
5250         (handle_vfork_child_exec_or_exit): Update.
5251         (follow_exec): Update.
5252         (displaced_step_prepare_throw): Update.
5253         (displaced_step_restore): Update.
5254         (start_step_over): Update.
5255         (resume_1): Update.
5256         (clear_proceed_status_thread): Update.
5257         (proceed): Update.
5258         (print_target_wait_results): Update.
5259         (do_target_wait): Update.
5260         (context_switch): Update.
5261         (stop_all_threads): Update.
5262         (restart_threads): Update.
5263         (finish_step_over): Update.
5264         (handle_signal_stop): Update.
5265         (switch_back_to_stepped_thread): Update.
5266         (keep_going_pass_signal): Update.
5267         (print_exited_reason): Update.
5268         (normal_stop): Update.
5269         * inferior.c (inferior_pid_to_str): Change return type.
5270         (print_selected_inferior): Update.
5271         (add_inferior): Update.
5272         (detach_inferior): Update.
5273         * dummy-frame.c (fprint_dummy_frames): Update.
5274         * dcache.c (dcache_info_1): Update.
5275         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5276         (btrace_fetch, btrace_clear): Update.
5277         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5278         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5279         type.
5280         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5281         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5282         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5283         * gdbarch.c, gdbarch.h: Rebuild.
5284         * gdbarch.sh (core_pid_to_str): Change return type.
5285         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5286         return type.
5287         (windows_nat_target::pid_to_str): Change return type.
5288         (windows_delete_thread): Update.
5289         (windows_nat_target::attach): Update.
5290         (windows_nat_target::files_info): Update.
5291         * target-delegates.c: Rebuild.
5292         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5293         return type.
5294         (sol_thread_target::pid_to_str): Change return type.
5295         * remote.c (class remote_target) <pid_to_str>: Change return
5296         type.
5297         (remote_target::pid_to_str): Change return type.
5298         (extended_remote_target::attach, remote_target::remote_stop_ns)
5299         (remote_target::remote_notif_remove_queued_reply)
5300         (remote_target::push_stop_reply, remote_target::disable_btrace):
5301         Update.
5302         (extended_remote_target::attach): Update.
5303         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5304         type.
5305         (gdbsim_target::pid_to_str): Change return type.
5306         * ravenscar-thread.c (struct ravenscar_thread_target)
5307         <pid_to_str>: Change return type.
5308         (ravenscar_thread_target::pid_to_str): Change return type.
5309         * procfs.c (class procfs_target) <pid_to_str>: Change return
5310         type.
5311         (procfs_target::pid_to_str): Change return type.
5312         (procfs_target::attach): Update.
5313         (procfs_target::detach): Update.
5314         (procfs_target::fetch_registers): Update.
5315         (procfs_target::store_registers): Update.
5316         (procfs_target::wait): Update.
5317         (procfs_target::files_info): Update.
5318         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5319         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5320         return type.
5321         (nto_procfs_target::pid_to_str): Change return type.
5322         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5323         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5324         return type.
5325         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5326         (exit_lwp): Update.
5327         (attach_proc_task_lwp_callback, get_detach_signal)
5328         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5329         (linux_nat_target::resume, wait_lwp, stop_callback)
5330         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5331         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5332         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5333         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5334         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5335         type.
5336         (inf_ptrace_target::attach): Update.
5337         (inf_ptrace_target::files_info): Update.
5338         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5339         type.
5340         (go32_nat_target::pid_to_str): Change return type.
5341         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5342         (gnu_nat_target::wait): Update.
5343         (gnu_nat_target::wait): Update.
5344         (gnu_nat_target::resume): Update.
5345         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5346         (fbsd_nat_target::wait): Update.
5347         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5348         type.
5349         (darwin_nat_target::attach): Update.
5350         * corelow.c (class core_target) <pid_to_str>: Change return type.
5351         (core_target::pid_to_str): Change return type.
5352         * target.c (normal_pid_to_str): Change return type.
5353         (default_pid_to_str): Likewise.
5354         (target_pid_to_str): Change return type.
5355         (target_translate_tls_address): Update.
5356         (target_announce_detach): Update.
5357         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5358         return type.
5359         (bsd_uthread_target::pid_to_str): Change return type.
5360         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5361         type.
5362         (bsd_kvm_target::pid_to_str): Change return type.
5363         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5364         return type.
5365         (aix_thread_target::pid_to_str): Change return type.
5366         * target.h (struct target_ops) <pid_to_str>: Change return type.
5367         (target_pid_to_str, normal_pid_to_str): Likewise.
5368         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5369         type.
5370         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5371         type.
5372         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5373         return type.
5374         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5375         type.
5376         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5377         type.
5378         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5379         return type.
5380
5381 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5382
5383         * NEWS: Mention that the new default MI version is 3.  Mention
5384         changes to the output of commands and events that deal with
5385         multi-location breakpoints.
5386         * breakpoint.c: Include "mi/mi-out.h".
5387         (print_one_breakpoint): Change output syntax if using MI version
5388         >= 3.
5389         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5390         New.
5391         (mi_multi_location_breakpoint_output_fixed): New.
5392         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5393         (mi_cmd_fix_multi_location_breakpoint_output): New.
5394         (mi_multi_location_breakpoint_output_fixed): New.
5395         * mi/mi-cmds.c (mi_cmds): Register command
5396         -fix-multi-location-breakpoint-output.
5397         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5398         interpreter "mi".
5399
5400 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5401
5402         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5403         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5404         instantiate mi_ui_out based on interpreter name.
5405         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5406         * mi/mi-main.c (mi_load_progress): Likewise.
5407
5408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5409
5410         * NEWS: Combine separate "New targets" sections for 8.3.
5411
5412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5413
5414         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5415         (ppcfbsd_init_abi): Install gdbarch
5416         "fetch_tls_load_module_address" and "get_thread_local_address"
5417         methods.
5418
5419 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5420
5421         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5422         (riscv_fbsd_init_abi): Install gdbarch
5423         "fetch_tls_load_module_address" and "get_thread_local_address"
5424         methods.
5425
5426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5427
5428         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5429         (i386fbsd_init_abi): Install gdbarch
5430         "fetch_tls_load_module_address" and "get_thread_local_address"
5431         methods.
5432
5433 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5434
5435         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5436         (amd64fbsd_init_abi): Install gdbarch
5437         "fetch_tls_load_module_address" and "get_thread_local_address"
5438         methods.
5439
5440 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5441
5442         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5443         (struct fbsd_pspace_data): New type.
5444         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5445         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5446         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5447         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5448         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5449
5450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5451
5452         * gdbtypes.c (lookup_struct_elt): New function.
5453         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5454         * gdbtypes.h (struct struct_elt): New type.
5455         (lookup_struct_elt): New prototype.
5456
5457 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5458
5459         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5460         remove disabled code block.
5461
5462 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5463
5464         * gdbarch.sh (get_thread_local_address): New method.
5465         * gdbarch.h, gdbarch.c: Regenerate.
5466         * target.c (target_translate_tls_address): Use
5467         gdbarch_get_thread_local_address if present instead of
5468         target::get_thread_local_address.
5469
5470 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5471
5472         * target.h (target::get_thread_local_address): Update comment.
5473
5474 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5475
5476         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5477         objfile->separate_debug_objfile_backlink if not NULL.
5478
5479 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5480
5481         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5482         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5483         (amd64bsd_store_inferior_registers): Likewise.
5484         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5485         Enable segment base registers.
5486         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5487         PT_GETFSBASE and PT_GETGSBASE.
5488         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5489         PT_SETGSBASE.
5490         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5491         segment base registers.
5492         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5493
5494 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5495
5496         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5497         Update calls to i386_target_description to add 'segments'
5498         parameter.
5499         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5500         add segment base registers.
5501         * arch/i386.c (i386_create_target_description): Add 'segments'
5502         parameter to enable segment base registers.
5503         * arch/i386.h (i386_create_target_description): Likewise.
5504         * features/i386/32bit-segments.xml: New file.
5505         * features/i386/32bit-segments.c: Generate.
5506         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5507         call to i386_target_description to add 'segments' parameter.
5508         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5509         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5510         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5511         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5512         if feature is present.
5513         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5514         Add 'segments' parameter to call to i386_target_description.
5515         (i386_target_description): Add 'segments' parameter to enable
5516         segment base registers.
5517         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5518         to call to i386_target_description.
5519         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5520         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5521         Define I386_NUM_REGS.
5522         (i386_target_description): Add 'segments' parameter to enable
5523         segment base registers.
5524
5525 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5526
5527         PR/24325
5528         * source-cache.c: #undef open and close, to avoid unresolved
5529         externals during linking.
5530
5531 2019-03-12  Tom Tromey  <tromey@adacore.com>
5532
5533         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5534         const.  Add initializers.
5535         (_initialize_remote): Don't initialize ptid globals.
5536
5537 2019-03-12  Pedro Alves  <palves@redhat.com>
5538
5539         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5540
5541 2019-03-12  Pedro Alves  <palves@redhat.com>
5542
5543         * cp-name-parser.y (main): Remove unused 'len' variable.
5544
5545 2019-03-12  Tom Tromey  <tromey@adacore.com>
5546
5547         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5548         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5549
5550 2019-03-12  Tom Tromey  <tromey@adacore.com>
5551
5552         * linux-nat.c (iterate_over_lwps): Update.
5553         (stop_callback): Remove parameter.
5554         (stop_wait_callback, detach_callback, resume_set_callback)
5555         (select_singlestep_lwp_callback, set_ignore_sigint)
5556         (status_callback, resumed_callback, resume_clear_callback)
5557         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5558         data parameter.
5559         (linux_nat_target::detach, linux_nat_target::resume)
5560         (linux_stop_and_wait_all_lwps, select_event_lwp)
5561         (linux_nat_filter_event, linux_nat_wait_1)
5562         (linux_nat_target::kill, linux_nat_target::stop)
5563         (linux_nat_target::stop): Update.
5564         (linux_nat_resume_callback): Change type.
5565         (resume_stopped_resumed_lwps, count_events_callback)
5566         (select_event_lwp_callback): Likewise.
5567         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5568         * arm-linux-nat.c (struct update_registers_data): Remove.
5569         (update_registers_callback): Change type.
5570         (arm_linux_insert_hw_breakpoint1): Update.
5571         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5572         parameter.
5573         (x86_linux_dr_set_addr): Update.
5574         (x86_linux_dr_set_control): Update.
5575         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5576         (iterate_over_lwps): Use gdb::function_view.
5577         * nat/aarch64-linux-hw-point.c (struct
5578         aarch64_dr_update_callback_param): Remove.
5579         (debug_reg_change_callback): Change type.
5580         (aarch64_notify_debug_reg_change): Update.
5581         * s390-linux-nat.c (s390_refresh_per_info): Update.
5582
5583 2019-03-11  Tom Tromey  <tromey@adacore.com>
5584
5585         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5586         redundant assignment to "this_cu".
5587
5588 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5589
5590         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5591
5592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5593
5594         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5595         from...
5596         (rank_one_type): ... this.
5597
5598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5599
5600         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5601         from...
5602         (rank_one_type): ... this.
5603
5604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5605
5606         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5607         from...
5608         (rank_one_type): ... this.
5609
5610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5611
5612         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5613         from...
5614         (rank_one_type): ... this.
5615
5616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5617
5618         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5619         from...
5620         (rank_one_type): ... this.
5621
5622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5623
5624         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5625         from...
5626         (rank_one_type): ... this.
5627
5628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5629
5630         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5631         from...
5632         (rank_one_type): ... this.
5633
5634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5635
5636         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5637         from...
5638         (rank_one_type): ... this.
5639
5640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5641
5642         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5643         from...
5644         (rank_one_type): ... this.
5645
5646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5647
5648         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5649         from...
5650         (rank_one_type): ... this.
5651
5652 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5653
5654         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5655         from...
5656         (rank_one_type): ... this.
5657
5658 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5659
5660         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5661         from...
5662         (rank_one_type): ... this.
5663
5664 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5665
5666         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5667         inferior-events' shows the example events.
5668
5669 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5670
5671         Support styling on native MS-Windows console
5672
5673         PR/24315
5674         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5675         on MS-Windows if $TERM is not defined.
5676
5677         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5678
5679         * posix-hdep.c (gdb_console_fputs):
5680         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5681         functions.
5682         * ui-file.h (gdb_console_fputs): Add prototype.
5683
5684         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5685         back to fputs only if the former returns zero.
5686
5687 2019-03-07  Tom Tromey  <tom@tromey.com>
5688
5689         * symmisc.c (print_symbol_bcache_statistics): Update.
5690         (print_objfile_statistics): Update.
5691         * symfile.c (allocate_symtab): Update.
5692         * stabsread.c: Don't include bcache.h.
5693         * psymtab.h (struct psymbol_bcache): Don't declare.
5694         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5695         (psymbol_bcache_init, psymbol_bcache_free)
5696         (psymbol_bcache_get_bcache): Don't declare.
5697         * psymtab.c (struct psymbol_bcache): Remove.
5698         (psymtab_storage::psymtab_storage): Update.
5699         (psymtab_storage::~psymtab_storage): Update.
5700         (psymbol_bcache_init, psymbol_bcache_free)
5701         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5702         (add_psymbol_to_bcache): Update.
5703         (allocate_psymtab): Update.
5704         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5705         macro_cache>: No longer pointers.
5706         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5707         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5708         * macrotab.c (macro_bcache): Update.
5709         * macroexp.c: Don't include bcache.h.
5710         * gdbtypes.c (check_types_worklist): Update.
5711         (types_deeply_equal): Remove TRY/CATCH.  Update.
5712         * elfread.c (elf_symtab_read): Update.
5713         * dwarf2read.c: Don't include bcache.h.
5714         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5715         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5716         (print_bcache_statistics, bcache_memory_used): Don't declare.
5717         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5718         methods.  Rename all data members.
5719         * bcache.c (struct bcache): Move to bcache.h.
5720         (bcache::expand_hash_table): Rename from expand_hash_table.
5721         (bcache): Remove.
5722         (bcache::insert): Rename from bcache_full.
5723         (bcache::compare): Rename from bcache_compare.
5724         (bcache_xmalloc): Remove.
5725         (bcache::~bcache): Rename from bcache_xfree.
5726         (bcache::print_statistics): Rename from print_bcache_statistics.
5727         (bcache::memory_used): Rename from bcache_memory_used.
5728
5729 2019-03-07  Pedro Alves  <palves@redhat.com>
5730
5731         * infrun.c (normal_stop): Also check for
5732         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5733
5734 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5735
5736         * f-lang.c (value_from_host_double): Moved to...
5737         * value.c (value_from_host_double): ...here.
5738         * value.h (value_from_host_double): Declare.
5739         * guile/scm-math.c (vlscm_convert_typed_number): Use
5740         value_from_host_double.
5741         (vlscm_convert_number): Likewise.
5742         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5743         * python/py-value.c (convert_value_from_python): Likewise.
5744
5745 2019-03-06  Tom Tromey  <tom@tromey.com>
5746
5747         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5748
5749 2019-03-06  Tom Tromey  <tom@tromey.com>
5750
5751         * utils.h (free_current_contents): Don't declare.
5752         * utils.c (free_current_contents): Remove.
5753
5754 2019-03-06  Tom Tromey  <tom@tromey.com>
5755
5756         * top.c (quit_force): Update.
5757         * main.c (captured_command_loop): Update.
5758         * common/new-op.c (operator new): Update.
5759         * common/common-exceptions.c (struct catcher)
5760         <save_cleanup_chain>: Remove member.
5761         (exceptions_state_mc_init): Update.
5762         (exception_try_scope_entry): Return nullptr.
5763         (exception_try_scope_exit, exception_rethrow)
5764         (throw_exception_sjlj, throw_exception_cxx): Update.
5765         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5766         (all_cleanups, do_cleanups, discard_cleanups)
5767         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5768         (restore_cleanups, restore_final_cleanups): Don't declare.
5769         (do_final_cleanups): Remove parameter.
5770         * common/cleanups.c (cleanup_chain, make_cleanup)
5771         (make_cleanup_dtor, all_cleanups, do_cleanups)
5772         (discard_my_cleanups, discard_cleanups)
5773         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5774         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5775         (null_cleanup): Remove.
5776         (do_final_cleanups): Remove parameter.
5777
5778 2019-03-06  Tom Tromey  <tom@tromey.com>
5779
5780         * remote.c (remote_target::remote_parse_stop_reply): Use
5781         unique_xmalloc_ptr.
5782
5783 2019-03-06  Tom Tromey  <tom@tromey.com>
5784
5785         * stabsread.c (struct stabs_field_info): Rename from field_info.
5786         <list, fnlist>: Add initializers.
5787         <obstack>: New member.
5788         (read_member_functions, read_struct_fields, read_baseclasses):
5789         Allocate on obstack.  Don't use cleanups.
5790         (read_one_struct_field, read_member_functions, read_struct_fields)
5791         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5792         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5793         (read_struct_type): Update.
5794
5795 2019-03-06  Tom Tromey  <tom@tromey.com>
5796
5797         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5798         * common/filestuff.h (make_cleanup_close): Don't declare.
5799         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5800         Remove.
5801
5802 2019-03-06  Tom Tromey  <tom@tromey.com>
5803
5804         * solib-aix.c: Use make_scope_exit.
5805
5806 2019-03-06  Tom Tromey  <tom@tromey.com>
5807
5808         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5809         Use make_scope_exit.
5810
5811 2019-03-06  Tom Tromey  <tom@tromey.com>
5812
5813         * solib-svr4.c (disable_probes_interface): Remove parameter.
5814         (svr4_handle_solib_event): Use make_scope_exit.
5815
5816 2019-03-06  Tom Tromey  <tom@tromey.com>
5817
5818         * remote.c (struct stop_reply_deleter): Remove.
5819         (stop_reply_up): Update.
5820         (struct stop_reply): Derive from notif_event.  Don't typedef.
5821         <regcache>: Now a std::vector.
5822         (stop_reply_xfree): Remove.
5823         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5824         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5825         (remote_target::discard_pending_stop_replies): Use delete.
5826         (remote_target::remote_parse_stop_reply): Update.
5827         (remote_target::process_stop_reply): Update.
5828         * remote-notif.h (struct notif_event): Add virtual destructor.
5829         Remove "dtr" member.
5830         (struct notif_client) <alloc_event>: Return a unique_ptr.
5831         (notif_event_xfree): Don't declare.
5832         (notif_event_up): New typedef.
5833         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5834         (notif_event_xfree, do_notif_event_xfree): Remove.
5835         (remote_notif_state_xfree): Update.
5836
5837 2019-03-06  Tom Tromey  <tom@tromey.com>
5838
5839         * infrun.c (displaced_step_clear_cleanup): Now a
5840         forward_scope_exit type.
5841         (displaced_step_prepare_throw): Update.
5842         (displaced_step_fixup): Update.
5843
5844 2019-03-06  Tom Tromey  <tom@tromey.com>
5845
5846         * inferior.h (class inferior): Update comment.
5847         * gdbthread.h (class thread_info): Update comment.
5848
5849 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5850             Tom Tromey  <tom@tromey.com>
5851
5852         * stabsread.h (struct stab_section_list): Remove.
5853         (coffstab_build_psymtabs): Update.
5854         * dbxread.c (symbuf_sections): Now a std::vector.
5855         (sect_idx): New global.
5856         (fill_symbuf): Update.
5857         (coffstab_build_psymtabs): Change type of stabsects parameter.
5858         Update.
5859         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5860         std::vector.
5861         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5862         (coff_locate_sections): Update.
5863         (coff_symfile_read): Remove cleanups.  Update.
5864         (init_stringtab): Add storage parameter.
5865         (free_stringtab, free_stringtab_cleanup): Remove.
5866         (init_lineno): Add storage parameter.
5867         (free_linetab, free_linetab_cleanup): Remove.
5868
5869 2019-03-06  Pedro Alves  <palves@redhat.com>
5870
5871         * linux-fork.c (fork_info::clobber_regs): Delete.
5872         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5873         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5874         comment.  Adjust.
5875         (scoped_switch_fork_info::scoped_switch_fork_info)
5876         (checkpoint_command, linux_fork_context): Adjust
5877         fork_save_infrun_state calls.
5878
5879 2019-03-06  Pedro Alves  <palves@redhat.com>
5880
5881         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5882         (inf_has_multiple_threads): Return 'bool' and rewrite using
5883         inferior_info::threads().
5884
5885 2019-03-06  Pedro Alves  <palves@redhat.com>
5886
5887         * linux-fork.c: Include <list>.
5888         (fork_list): Now a std::list instance.
5889         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5890         (forks_exist_p, find_last_fork): Adjust.
5891         (new_fork): Delete.
5892         (one_fork_p): New.
5893         (add_fork): Adjust.
5894         (free_fork): Delete, folded into fork_info::~fork_info().
5895         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5896         Adjust.
5897         (init_fork_list): Delete.
5898         (linux_fork_killall, linux_fork_mourn_inferior)
5899         (linux_fork_detach, info_checkpoints_command): Adjust.
5900         (_initialize_linux_fork): No longer call init_fork_list.
5901
5902 2019-03-06  Pedro Alves  <palves@redhat.com>
5903
5904         * linux-fork.c (new_fork): New, split out of ...
5905         (add_fork): ... this.  Return void.  Move "first fork" special
5906         case from here, to ...
5907         (checkpoint_command): ... here.
5908         * linux-linux.h (add_fork): Return void.
5909
5910 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5911
5912         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5913
5914 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5915             Chris January  <chris.january@arm.com>
5916             David Lecomber  <david.lecomber@arm.com>
5917
5918         * f-exp.y: New token, UNOP_INTRINSIC.
5919         (exp): New pattern using UNOP_INTRINSIC token.
5920         (f77_keywords): Add 'abs' keyword.
5921         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5922         (value_from_host_double): New function.
5923         (evaluate_subexp_f): Support UNOP_ABS.
5924
5925 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5926
5927         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5928         types.
5929
5930 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5931
5932         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5933         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5934         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5935
5936 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5937
5938         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5939
5940 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5941             Chris January  <chris.january@arm.com>
5942
5943         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5944         * f-exp.y: Define 'KIND' token.
5945         (exp): New pattern for KIND expressions.
5946         (ptype): Handle types with a kind extension.
5947         (direct_abs_decl): Extend to spot kind extensions.
5948         (f77_keywords): Add 'kind' to the list.
5949         (push_kind_type): New function.
5950         (convert_to_kind_type): New function.
5951         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5952         * parse.c (operator_length_standard): Likewise.
5953         * parser-defs.h (enum type_pieces): Add tp_kind.
5954         * std-operator.def: Add UNOP_KIND.
5955
5956 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5957
5958         * f-exp.y (f_parse): Set yydebug.
5959
5960 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5961
5962         * f-lang.c (evaluate_subexp_f): New function.
5963         (exp_descriptor_f): New global.
5964         (f_language_defn): Use exp_descriptor_f instead of
5965         exp_descriptor_standard.
5966
5967 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5968
5969         * f-exp.y (struct token): Add comments.
5970         (dot_ops): Remove uppercase versions and the end marker.
5971         (f77_keywords): Likewise.
5972         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5973         entries in the dot_ops array are case insensitive, and use
5974         strncasecmp to compare strings.  Also some whitespace cleanup in
5975         this area.  Similar for the f77_keywords array, except entries in
5976         this list might be case sensitive.
5977
5978 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5979
5980         * f-exp.y (struct f77_boolean_val): Add comments.
5981         (boolean_values): Remove uppercase versions, and end marker.
5982         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5983         and use strncasecmp to achieve case insensitivity.  Additionally,
5984         perform whitespace cleanup around this code.
5985
5986 2019-03-06  Tom Tromey  <tromey@adacore.com>
5987
5988         * remote-sim.c (gdbsim_target_open): Use result of
5989         gdb_argv::release.
5990
5991 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5992         Dirk Schubert  <dirk.schubert@arm.com>
5993         Chris January  <chris.january@arm.com>
5994
5995         * eval.c (evaluate_subexp_standard): Call Fortran argument
5996         wrapping logic.
5997         * f-lang.c (struct value): A value which can be passed into a
5998         Fortran function call.
5999         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6000         where appropriate.
6001         (struct type): Value ready for a Fortran function call.
6002         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6003         is needed.
6004         * f-lang.h (fortran_argument_convert): Declaration.
6005         (fortran_preserve_arg_pointer): Declaration.
6006         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6007
6008 2019-03-05  Tom Tromey  <tromey@adacore.com>
6009
6010         * python/py-prettyprint.c (print_string_repr): Remove #if.
6011         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6012
6013 2019-03-05  Tom Tromey  <tromey@adacore.com>
6014
6015         * target.c (the_dummy_target): Move later.  Change type to
6016         "dummy_target".
6017         (initialize_targets): Don't initialize the_dummy_target.
6018
6019 2019-03-05  Tom Tromey  <tromey@adacore.com>
6020
6021         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6022         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6023
6024 2019-03-05  Tom Tromey  <tromey@adacore.com>
6025
6026         * windows-nat.c (windows_nat_target::attach)
6027         (windows_nat_target::detach): Don't call gdb_flush.
6028         * valprint.c (generic_val_print, val_print, val_print_string):
6029         Don't call gdb_flush.
6030         * utils.c (defaulted_query): Don't call gdb_flush.
6031         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6032         * target.c (target_announce_detach): Don't call gdb_flush.
6033         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6034         * remote.c (extended_remote_target::attach): Don't call
6035         gdb_flush.
6036         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6037         * printcmd.c (do_examine): Don't call gdb_flush.
6038         (info_display_command): Don't call gdb_flush.
6039         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6040         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6041         * memattr.c (info_mem_command): Don't call gdb_flush.
6042         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6043         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6044         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6045         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6046         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6047         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6048         (gnu_nat_target::detach): Don't call gdb_flush.
6049         * f-valprint.c (f_val_print): Don't call gdb_flush.
6050         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6051         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6052         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6053         gdb_flush.
6054         * c-valprint.c (c_val_print): Don't call gdb_flush.
6055         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6056
6057 2019-03-05  Tom Tromey  <tromey@adacore.com>
6058
6059         * varobj.c (update_dynamic_varobj_children): Update.
6060         (install_default_visualizer): Use reset, not release.
6061         * value.c (set_internalvar): Update.
6062         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6063         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6064         ATTRIBUTE_UNUSED_RESULT.
6065
6066 2019-03-05  Tom Tromey  <tromey@adacore.com>
6067
6068         * remote.c (class scoped_remote_fd) <release>: Add
6069         ATTRIBUTE_UNUSED_RESULT.
6070
6071 2019-03-05  Tom Tromey  <tromey@adacore.com>
6072
6073         * macroexp.c (struct macro_buffer) <release>: Add
6074         ATTRIBUTE_UNUSED_RESULT.
6075
6076 2019-03-05  Tom Tromey  <tromey@adacore.com>
6077
6078         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6079         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6080         ATTRIBUTE_UNUSED_RESULT.
6081
6082 2019-03-05  Tom Tromey  <tromey@adacore.com>
6083
6084         * common/scoped_fd.h (class scoped_fd) <release>: Add
6085         ATTRIBUTE_UNUSED_RESULT.
6086
6087 2019-03-05  Tom Tromey  <tromey@adacore.com>
6088
6089         * parser-defs.h (struct parser_state) <release>: Add
6090         ATTRIBUTE_UNUSED_RESULT.
6091
6092 2019-03-05  Tom Tromey  <tromey@adacore.com>
6093
6094         * utils.h (class gdb_argv) <release>: Add
6095         ATTRIBUTE_UNUSED_RESULT.
6096         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6097
6098 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6099
6100         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6101         for-loop range, to avoid compiler warnings.
6102
6103         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6104         avoid compiler warnings about unused variables.
6105
6106         * NEWS: Mention end of support for native debugging on MS-Windows
6107         before XP.
6108
6109         PR gdb/24292
6110         * common/netstuff.c:
6111         * gdbserver/gdbreplay.c
6112         * gdbserver/remote-utils.c:
6113         * ser-tcp.c:
6114         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6115         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6116         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6117         'getaddrinfo' and 'freeaddrinfo' were not available before
6118         Windows XP, and mingw.org's MinGW headers by default define
6119         _WIN32_WINNT to 0x500.
6120
6121 2019-03-01  Gary Benson <gbenson@redhat.com>
6122
6123         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6124
6125 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6126             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6127
6128         PR gdb/8527
6129         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6130         set_sigint_trap, clear_sigint_trap.
6131
6132 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6133
6134         * target.c (target_detach): Clear the regcache and the
6135         frame cache.
6136
6137 2019-02-27  Pedro Alves  <palves@redhat.com>
6138
6139         * utils.c (set_screen_size): When we cap the height/width sizes,
6140         tweak the corresponding command variable to show "unlimited":
6141
6142 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6143             Pedro Alves  <palves@redhat.com>
6144
6145         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6146         before calling rl_set_screen_size.
6147
6148 2019-02-27  Tom Tromey  <tromey@adacore.com>
6149
6150         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6151         define.
6152         * python/py-value.c: Remove Python 2.4 workaround.
6153         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6154         workaround.
6155         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6156         Python 2.4 workaround.
6157         * python/python-internal.h: Remove Python 2.4 comment.
6158         (Py_ssize_t): Don't define.
6159         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6160         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6161         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6162         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6163         * python/python.c (do_start_initialization): Remove Python 2.4
6164         workaround.
6165         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6166         (print_children): Remove Python 2.4 workaround.
6167         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6168         workaround.
6169         (CHARBUFFERPROC_NAME): Remove.
6170         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6171         Python 2.4 workaround.
6172
6173 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6174
6175         * NEWS: Note minimum Python version.
6176
6177 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6178
6179         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6180         code from these functions.  Remove corresponding ifdefs.  Use
6181         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6182         Remove gotos and target of gotos.
6183         (infpy_search_memory): Likewise.
6184
6185 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6186
6187         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6188         (hppa_gdbarch_init): Don't register deleted functions with
6189         gdbarch.
6190
6191 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6194         (h8300_unwind_sp): Delete.
6195         (h8300_dummy_id): Delete.
6196         (h8300_gdbarch_init): Don't register deleted functions with
6197         gdbarch.
6198
6199 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6200
6201         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6202         (ft32_unwind_pc): Delete.
6203         (ft32_unwind_sp): Delete.
6204         (ft32_gdbarch_init): Don't register deleted functions with
6205         gdbarch.
6206
6207 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6208
6209         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6210         (frv_unwind_pc): Delete.
6211         (frv_unwind_sp): Delete.
6212         (frv_gdbarch_init): Don't register deleted functions with
6213         gdbarch.
6214
6215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6216
6217         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6218         (riscv_unwind_pc): Delete.
6219         (riscv_unwind_sp): Delete.
6220         (riscv_gdbarch_init): Don't register deleted functions with
6221         gdbarch.
6222
6223 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6224
6225         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6226         (csky_unwind_pc): Delete.
6227         (csky_unwind_sp): Delete.
6228         (csky_gdbarch_init): Don't register deleted functions with
6229         gdbarch.
6230
6231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6232
6233         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6234         (cris_unwind_pc): Delete.
6235         (cris_unwind_sp): Delete.
6236         (cris_gdbarch_init): Don't register deleted functions with
6237         gdbarch.
6238
6239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6240
6241         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6242         (bfin_unwind_pc): Delete.
6243         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6244
6245 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6246
6247         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6248         (arm_unwind_pc): Delete.
6249         (arm_unwind_sp): Delete.
6250         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6251
6252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6255         (arc_unwind_pc): Delete.
6256         (arc_unwind_sp): Delete.
6257         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6258
6259 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6260
6261         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6262         (alpha_unwind_pc): Delete.
6263         (alpha_gdbarch_init): Don't register deleted functions with
6264         gdbarch.
6265
6266 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6267
6268         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6269         (aarch64_unwind_pc): Delete.
6270         (aarch64_unwind_sp): Delete.
6271         (aarch64_gdbarch_init): Don't register deleted functions with
6272         gdbarch.
6273
6274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * gdbtypes.c (type_align): Don't consider static members when
6277         computing structure alignment.
6278
6279 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6280
6281         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6282         return 0 for other types.
6283         * arch-utils.c (default_type_align): Always return 0.
6284         * gdbarch.h: Regenerate.
6285         * gdbarch.sh (type_align): Extend comment.
6286         * gdbtypes.c (type_align): Add additional comments, always call
6287         gdbarch_type_align before applying the default rules.
6288         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6289         generic code will then apply a suitable default.
6290         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6291         types, return 0 for other types.
6292
6293 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6294
6295         * NEWS: Create a new section for the next release branch.
6296         Rename the section of the current branch, now that it has
6297         been cut.
6298
6299 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6300
6301         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6302         * version.in: Bump version to 8.3.50.DATE-git.
6303
6304 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6305
6306         * aix-thread.c (ptid_cmp): Remove unused variable.
6307         (get_signaled_thread): Likewise.
6308         (store_regs_user_thread): Likewise.
6309         (store_regs_kernel_thread): Likewise.
6310         (fetch_regs_kernel_thread): Remove shadowed variable.
6311
6312 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6313
6314         * features/riscv/32bit-cpu.xml: Add register numbers.
6315         * features/riscv/32bit-fpu.c: Regenerate.
6316         * features/riscv/32bit-fpu.xml: Add register numbers.
6317         * features/riscv/64bit-cpu.xml: Add register numbers.
6318         * features/riscv/64bit-fpu.c: Regenerate.
6319         * features/riscv/64bit-fpu.xml: Add register numbers.
6320
6321 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6322
6323         * NEWS: Mention two argument form of gdb.Value constructor.
6324         * python/py-value.c (convert_buffer_and_type_to_value): New
6325         function.
6326         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6327         Add support for handling an optional second argument.  Call
6328         convert_buffer_and_type_to_value as appropriate.
6329         * python/python-internal.h (Py_buffer_deleter): New struct.
6330         (Py_buffer_up): New typedef.
6331
6332 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6333
6334         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6335         instead of releasing ownership.
6336
6337 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6338
6339         * dwarf2read.c (open_and_init_dwp_file): Call
6340         elf_numsections instead of bfd_count_sections to initialize
6341         dwp_file->num_sections.
6342
6343 2019-02-25  Tom Tromey  <tromey@adacore.com>
6344
6345         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6346
6347 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6348
6349         * gcore.in: Add '--readnever' option when invoking GDB.
6350
6351 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6352
6353         * MAINTAINERS: Update my email address.
6354
6355 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6356
6357         * build-id.c (build_id_to_debug_bfd_1): New function.
6358         (build_id_to_debug_bfd): Look for separate debug file in
6359         sysroot.
6360
6361 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * gdbarch.sh: Update the copyright year range that is placed into
6364         generated files.
6365
6366 2019-02-22  Keith Seitz  <keiths@redhat.com>
6367
6368         PR symtab/23853
6369         * linespec.c (create_sals_line_offset): Search for the default
6370         symtab's filename instead of its fullname.
6371
6372 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6373
6374         * NEWS: Update style defaults.
6375
6376 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6377
6378         * main.c (captured_main_1): Disable styling in batch mode.
6379
6380 2019-02-20  Tom Tromey  <tom@tromey.com>
6381
6382         * symtab.c (symtab_symbol_info): Fix typos.
6383
6384 2019-02-20  Tom Tromey  <tromey@adacore.com>
6385
6386         * findcmd.c (_initialize_mem_search): Use upper case for
6387         metasyntactic variables.
6388
6389 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6390
6391         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6392         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6393
6394 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6395
6396         * top.h (source_file_name): Change to std::string.
6397         * top.c (source_file_name): Likewise.
6398         (command_line_input): Adjust.
6399         * cli/cli-script.c (script_from_file): Adjust.
6400
6401 2019-02-19  Tom Tromey  <tromey@adacore.com>
6402
6403         * ravenscar-thread.c
6404         (ravenscar_thread_target::update_thread_list): Don't call
6405         ada_build_task_list.
6406         * ada-lang.h (ada_build_task_list): Don't declare.
6407         * ada-tasks.c (struct ada_tasks_inferior_data)
6408         <task_list_valid_p>: Now bool.
6409         (read_known_tasks, ada_task_list_changed)
6410         (ada_tasks_invalidate_inferior_data): Update.
6411         (read_known_tasks_array): Return bool.
6412         (read_known_tasks_list): Likewise.
6413         (read_known_tasks): Return void.
6414         (ada_build_task_list): Now static.
6415
6416 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6417
6418         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6419         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6420
6421 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6422
6423         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6424         variant for ada_tasks_pspace_data_handle and
6425         ada_tasks_inferior_data_handle.
6426         (ada_tasks_pspace_data_cleanup): New function.
6427         (ada_tasks_inferior_data_cleanup): New function.
6428
6429 2019-02-17  Tom Tromey  <tom@tromey.com>
6430
6431         * macrotab.h (macro_source_fullname): Return a std::string.
6432         * macrotab.c (macro_include, check_for_redefinition)
6433         (macro_undef, macro_lookup_definition, foreach_macro)
6434         (foreach_macro_in_scope): Update.
6435         (macro_source_fullname): Return a std::string.
6436         * macrocmd.c (show_pp_source_pos): Update.
6437
6438 2019-02-17  Tom Tromey  <tom@tromey.com>
6439
6440         * macrocmd.c (show_pp_source_pos): Style the file names.
6441
6442 2019-02-17  Tom Tromey  <tom@tromey.com>
6443
6444         PR tui/24197:
6445         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6446
6447 2019-02-17  Tom Tromey  <tom@tromey.com>
6448
6449         * ada-lang.c (user_select_syms): Use filtered printing.
6450         * utils.c (wrap_style): New global.
6451         (desired_style): Remove.
6452         (emit_style_escape): Add stream parameter.
6453         (set_output_style, reset_terminal_style, prompt_for_continue):
6454         Update.
6455         (flush_wrap_buffer): Only flush gdb_stdout.
6456         (wrap_here): Set wrap_style.
6457         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6458         treat escape sequences as a character.  Change when wrap buffer is
6459         flushed.
6460         (fputs_styled): Do not set the output style when the default is
6461         requested.
6462         * ui-style.h (struct ui_file_style) <is_default>: New method.
6463         * source.c (print_source_lines_base): Emit escape sequences in one
6464         piece.
6465
6466 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6467
6468         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6469         integers and enumeration types.
6470
6471 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6472
6473         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6474         instead of lookup_symbol_in_language
6475         (do_exact_match): New function.
6476         (ada_get_symbol_name_matcher): Return do_exact_match when
6477         doing a verbatim match.
6478
6479 2019-02-15  Tom Tromey  <tromey@adacore.com>
6480
6481         * ravenscar-thread.c (ravenscar_thread_target::resume)
6482         (ravenscar_thread_target::wait): Special case wildcard requests.
6483
6484 2019-02-15  Tom Tromey  <tromey@adacore.com>
6485
6486         * ravenscar-thread.c (base_ptid): Remove.
6487         (struct ravenscar_thread_target) <close>: New method.
6488         <m_base_ptid>: New member.
6489         <update_inferior_ptid, active_task, task_is_currently_active,
6490         runtime_initialized>: Declare methods.
6491         <ravenscar_thread_target>: Add constructor.
6492         (ravenscar_thread_target::task_is_currently_active)
6493         (ravenscar_thread_target::update_inferior_ptid)
6494         (ravenscar_runtime_initialized): Rename.  Now methods.
6495         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6496         (ravenscar_thread_target::update_thread_list): Update.
6497         (ravenscar_thread_target::active_task): Now method.
6498         (ravenscar_thread_target::store_registers)
6499         (ravenscar_thread_target::prepare_to_store)
6500         (ravenscar_thread_target::prepare_to_store)
6501         (ravenscar_thread_target::mourn_inferior): Update.
6502         (ravenscar_inferior_created): Use "new" to create target.
6503         (ravenscar_thread_target::get_ada_task_ptid): Update.
6504         (_initialize_ravenscar): Don't initialize base_ptid.
6505         (ravenscar_ops): Remove global.
6506
6507 2019-02-15  Tom Tromey  <tromey@adacore.com>
6508
6509         * target.h (push_target): Declare new overload.
6510         * target.c (push_target): New overload, taking an rvalue reference.
6511         * remote.c (remote_target::open_1): Use push_target overload.
6512         * corelow.c (core_target_open): Use push_target overload.
6513
6514 2019-02-15  Tom Tromey  <tromey@adacore.com>
6515
6516         * ravenscar-thread.c (is_ravenscar_task)
6517         (ravenscar_task_is_currently_active): Return bool.
6518         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6519         (_initialize_ravenscar): Remove "(void)".
6520         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6521         Return bool.
6522
6523 2019-02-15  Tom Tromey  <tromey@adacore.com>
6524
6525         * ravenscar-thread.c (ravenscar_runtime_initializer)
6526         (has_ravenscar_runtime, get_running_thread_id)
6527         (ravenscar_thread_target::resume): Fix indentation.
6528
6529 2019-02-15  Tom Tromey  <tromey@adacore.com>
6530
6531         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6532         from ravenscar_arch_ops.
6533         (sparc_ravenscar_ops::fetch_registers)
6534         (sparc_ravenscar_ops::store_registers): Now methods.
6535         (sparc_ravenscar_prepare_to_store): Remove.
6536         (sparc_ravenscar_ops): Redefine.
6537         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6538         methods and destructor.  Remove members.
6539         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6540         (ravenscar_thread_target::store_registers)
6541         (ravenscar_thread_target::prepare_to_store): Update.
6542         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6543         Remove.
6544         (struct ppc_ravenscar_powerpc_ops): Derive from
6545         ravenscar_arch_ops.
6546         (ppc_ravenscar_powerpc_ops::fetch_registers)
6547         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6548         (ppc_ravenscar_powerpc_ops): Redefine.
6549         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6550         (ppc_ravenscar_e500_ops::fetch_registers)
6551         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6552         (ppc_ravenscar_e500_ops): Redefine.
6553         * aarch64-ravenscar-thread.c
6554         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6555         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6556         (aarch64_ravenscar_fetch_registers)
6557         (aarch64_ravenscar_store_registers): Now methods.
6558         (aarch64_ravenscar_ops): Redefine.
6559
6560 2019-02-15  Tom Tromey  <tromey@adacore.com>
6561
6562         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6563         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6564         (ravenscar_thread_target::stopped_by_watchpoint)
6565         (ravenscar_thread_target::stopped_data_address)
6566         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6567
6568 2019-02-15  Tom Tromey  <tromey@adacore.com>
6569
6570         * ravenscar-thread.c: Fix some typos.
6571
6572 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6573             Tom Tromey  <tromey@adacore.com>
6574
6575         * ada-lang.c (ada_exception_sal): Change addr_string to a
6576         std::string.
6577         (create_ada_exception_catchpoint): Update.
6578
6579 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6580             Tom Tromey  <tromey@adacore.com>
6581
6582         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6583         (bp_location_ops): Remove.
6584         (base_breakpoint_allocate_location): Update.
6585         (free_bp_location): Update.
6586         * ada-lang.c (class ada_catchpoint_location)
6587         <ada_catchpoint_location>: Remove ops parameter.
6588         (ada_catchpoint_location_dtor): Remove.
6589         (ada_catchpoint_location_ops): Remove.
6590         (allocate_location_exception): Update.
6591         * breakpoint.h (struct bp_location_ops): Remove.
6592         (class bp_location) <bp_location>: Remove bp_location_ops
6593         parameter.
6594         <~bp_location>: Add destructor.
6595         <ops>: Remove.
6596
6597 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6598             Pedro Alves  <palves@redhat.com>
6599
6600         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6601         'PATH_MAX'.
6602
6603 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6604             Samuel Thibault  <samuel.thibault@gnu.org>
6605             Thomas Schwinge  <thomas@codesourcery.com>
6606
6607         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6608         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6609
6610 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6611
6612         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6613         (check_empty): Use "const char *".
6614
6615         * gnu-nat.c (gnu_nat_target::detach): Instead of
6616         'detach_inferior (pid)' call
6617         'detach_inferior (find_inferior_pid (pid))'.
6618
6619         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6620         'nat/fork-inferior.o'.
6621         * gnu-nat.c: #include "nat/fork-inferior.h".
6622
6623         * gnu-nat.c (gnu_nat_target::detach): Instead of
6624         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6625         * gnu-nat.h: #include "inf-child.h".
6626         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6627         'i386_gnu_nat_target::fetch_registers'.
6628         (gnu_store_registers): Rename/move to
6629         'i386_gnu_nat_target::store_registers'.
6630
6631         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6632         * gnu-nat.h (mach_thread_info): New function.
6633         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6634
6635         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6636
6637 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6638
6639         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6640
6641 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6642
6643         * windows-nat.c (windows_add_thread): Add new parameter
6644         "main_thread_p" with default value set to false.  Update
6645         function documentation as well as all callers.
6646         (windows_delete_thread): Likewise.
6647         (fake_create_process): Update call to windows_add_thread.
6648         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6649         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6650         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6651         call to windows_delete_thread.
6652
6653 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6654
6655         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6656
6657 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6658
6659         * symfile.c (find_separate_debug_file): Use canonical path of
6660         sysroot with child_path instead of gdb_sysroot if it is valid.
6661
6662 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6663
6664         * symfile.c (find_separate_debug_file): Use child_path to
6665         determine if an object file is under a sysroot.
6666
6667 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6668
6669         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6670         unittests/child-path-selftests.c.
6671         * common/pathstuff.c (child_path): New function.
6672         * common/pathstuff.h (child_path): New prototype.
6673         * unittests/child-path-selftests.c: New file.
6674
6675 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6676
6677         * symfile.c (find_separate_debug_file): Look for separate debug
6678         files in debug directories under the sysroot.
6679
6680 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6681
6682         * symtab.h (struct minimal_symbol data_p): New const method.
6683         (struct minimal_symbol text_p): Likewise.
6684         * symtab.c (output_source_filename): Use file name style
6685         to print file name.
6686         (print_symbol_info): Likewise.
6687         (print_msymbol_info): Use address style to print addresses.
6688         Use function name style to print executable text symbols.
6689         (expand_symtab_containing_pc): Use data_p.
6690         (find_pc_sect_compunit_symtab): Likewise.
6691
6692 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6693
6694         * breakpoint.c (describe_other_breakpoints): Use address style
6695         to print addresses.
6696         (say_where): Likewise.
6697
6698 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6699
6700         * ada-typeprint.c (print_func_type): Print function name
6701         style to print function name.
6702         * c-typeprint.c (c_print_type_1): Likewise.
6703
6704 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6705
6706         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6707         for execve.
6708
6709 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6710
6711         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6712         type_stack.
6713
6714 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6715
6716         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6717         TYPE_CODE_REF types.
6718
6719 2019-02-08  Jim Wilson  <jimw@sifive.com>
6720
6721         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6722         (riscv_linux_fregset): New.
6723         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6724
6725 2019-02-07  Tom Tromey  <tom@tromey.com>
6726
6727         * thread.c (thread_cancel_execution_command): Update.
6728         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6729         methods.
6730         (struct thread_fsm_ops): Remove.
6731         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6732         (thread_fsm_should_stop, thread_fsm_return_value)
6733         (thread_fsm_set_finished, thread_fsm_finished_p)
6734         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6735         Don't declare.
6736         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6737         * infrun.c (clear_proceed_status_thread)
6738         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6739         (print_stop_event): Update.
6740         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6741         Add constructor.
6742         (step_command_fsm_ops): Remove.
6743         (new_step_command_fsm): Remove.
6744         (step_1): Update.
6745         (step_command_fsm::should_stop): Rename from
6746         step_command_fsm_should_stop.
6747         (step_command_fsm::clean_up): Rename from
6748         step_command_fsm_clean_up.
6749         (step_command_fsm::do_async_reply_reason): Rename from
6750         step_command_fsm_async_reply_reason.
6751         (struct until_next_fsm): Inherit from thread_fsm.  Add
6752         constructor.
6753         (until_next_fsm_ops): Remove.
6754         (new_until_next_fsm): Remove.
6755         (until_next_fsm::should_stop): Rename from
6756         until_next_fsm_should_stop.
6757         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6758         (until_next_fsm::do_async_reply_reason): Rename from
6759         until_next_fsm_async_reply_reason.
6760         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6761         constructor.  Change type of breakpoint.
6762         (finish_command_fsm_ops): Remove.
6763         (new_finish_command_fsm): Remove.
6764         (finish_command_fsm::should_stop): Rename from
6765         finish_command_fsm_should_stop.
6766         (finish_command_fsm::clean_up): Rename from
6767         finish_command_fsm_clean_up.
6768         (finish_command_fsm::return_value): Rename from
6769         finish_command_fsm_return_value.
6770         (finish_command_fsm::do_async_reply_reason): Rename from
6771         finish_command_fsm_async_reply_reason.
6772         (finish_command): Update.
6773         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6774         Add constructor.
6775         (call_thread_fsm_ops): Remove.
6776         (call_thread_fsm::call_thread_fsm): Rename from
6777         new_call_thread_fsm.
6778         (call_thread_fsm::should_stop): Rename from
6779         call_thread_fsm_should_stop.
6780         (call_thread_fsm::should_notify_stop): Rename from
6781         call_thread_fsm_should_notify_stop.
6782         (run_inferior_call, call_function_by_hand_dummy): Update.
6783         * cli/cli-interp.c (should_print_stop_to_console): Update.
6784         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6785         Add constructor.  Change type of location_breakpoint,
6786         caller_breakpoint.
6787         (until_break_fsm_ops): Remove.
6788         (new_until_break_fsm): Remove.
6789         (until_break_fsm::should_stop): Rename from
6790         until_break_fsm_should_stop.
6791         (until_break_fsm::clean_up): Rename from
6792         until_break_fsm_clean_up.
6793         (until_break_fsm::do_async_reply_reason): Rename from
6794         until_break_fsm_async_reply_reason.
6795         (until_break_command): Update.
6796         * thread-fsm.c: Remove.
6797         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6798
6799 2019-02-07  Tom Tromey  <tom@tromey.com>
6800
6801         * yy-remap.h: Add include guard.
6802         * xtensa-tdep.h: Add include guard.
6803         * xcoffread.h: Rename include guard.
6804         * varobj-iter.h: Add include guard.
6805         * tui/tui.h: Rename include guard.
6806         * tui/tui-winsource.h: Rename include guard.
6807         * tui/tui-wingeneral.h: Rename include guard.
6808         * tui/tui-windata.h: Rename include guard.
6809         * tui/tui-win.h: Rename include guard.
6810         * tui/tui-stack.h: Rename include guard.
6811         * tui/tui-source.h: Rename include guard.
6812         * tui/tui-regs.h: Rename include guard.
6813         * tui/tui-out.h: Rename include guard.
6814         * tui/tui-layout.h: Rename include guard.
6815         * tui/tui-io.h: Rename include guard.
6816         * tui/tui-hooks.h: Rename include guard.
6817         * tui/tui-file.h: Rename include guard.
6818         * tui/tui-disasm.h: Rename include guard.
6819         * tui/tui-data.h: Rename include guard.
6820         * tui/tui-command.h: Rename include guard.
6821         * tic6x-tdep.h: Add include guard.
6822         * target/waitstatus.h: Rename include guard.
6823         * target/wait.h: Rename include guard.
6824         * target/target.h: Rename include guard.
6825         * target/resume.h: Rename include guard.
6826         * target-float.h: Rename include guard.
6827         * stabsread.h: Add include guard.
6828         * rs6000-tdep.h: Add include guard.
6829         * riscv-fbsd-tdep.h: Add include guard.
6830         * regformats/regdef.h: Rename include guard.
6831         * record.h: Rename include guard.
6832         * python/python.h: Rename include guard.
6833         * python/python-internal.h: Rename include guard.
6834         * python/py-stopevent.h: Rename include guard.
6835         * python/py-ref.h: Rename include guard.
6836         * python/py-record.h: Rename include guard.
6837         * python/py-record-full.h: Rename include guard.
6838         * python/py-record-btrace.h: Rename include guard.
6839         * python/py-instruction.h: Rename include guard.
6840         * python/py-events.h: Rename include guard.
6841         * python/py-event.h: Rename include guard.
6842         * procfs.h: Add include guard.
6843         * proc-utils.h: Add include guard.
6844         * p-lang.h: Add include guard.
6845         * or1k-tdep.h: Rename include guard.
6846         * observable.h: Rename include guard.
6847         * nto-tdep.h: Rename include guard.
6848         * nat/x86-linux.h: Rename include guard.
6849         * nat/x86-linux-dregs.h: Rename include guard.
6850         * nat/x86-gcc-cpuid.h: Add include guard.
6851         * nat/x86-dregs.h: Rename include guard.
6852         * nat/x86-cpuid.h: Rename include guard.
6853         * nat/ppc-linux.h: Rename include guard.
6854         * nat/mips-linux-watch.h: Rename include guard.
6855         * nat/linux-waitpid.h: Rename include guard.
6856         * nat/linux-ptrace.h: Rename include guard.
6857         * nat/linux-procfs.h: Rename include guard.
6858         * nat/linux-osdata.h: Rename include guard.
6859         * nat/linux-nat.h: Rename include guard.
6860         * nat/linux-namespaces.h: Rename include guard.
6861         * nat/linux-btrace.h: Rename include guard.
6862         * nat/glibc_thread_db.h: Rename include guard.
6863         * nat/gdb_thread_db.h: Rename include guard.
6864         * nat/gdb_ptrace.h: Rename include guard.
6865         * nat/fork-inferior.h: Rename include guard.
6866         * nat/amd64-linux-siginfo.h: Rename include guard.
6867         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6868         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6869         * nat/aarch64-linux.h: Rename include guard.
6870         * nat/aarch64-linux-hw-point.h: Rename include guard.
6871         * mn10300-tdep.h: Add include guard.
6872         * mips-linux-tdep.h: Add include guard.
6873         * mi/mi-parse.h: Rename include guard.
6874         * mi/mi-out.h: Rename include guard.
6875         * mi/mi-main.h: Rename include guard.
6876         * mi/mi-interp.h: Rename include guard.
6877         * mi/mi-getopt.h: Rename include guard.
6878         * mi/mi-console.h: Rename include guard.
6879         * mi/mi-common.h: Rename include guard.
6880         * mi/mi-cmds.h: Rename include guard.
6881         * mi/mi-cmd-break.h: Rename include guard.
6882         * m2-lang.h: Add include guard.
6883         * location.h: Rename include guard.
6884         * linux-record.h: Rename include guard.
6885         * linux-nat.h: Add include guard.
6886         * linux-fork.h: Add include guard.
6887         * i386-darwin-tdep.h: Rename include guard.
6888         * hppa-linux-offsets.h: Add include guard.
6889         * guile/guile.h: Rename include guard.
6890         * guile/guile-internal.h: Rename include guard.
6891         * gnu-nat.h: Rename include guard.
6892         * gdb-stabs.h: Rename include guard.
6893         * frv-tdep.h: Add include guard.
6894         * f-lang.h: Add include guard.
6895         * event-loop.h: Add include guard.
6896         * darwin-nat.h: Rename include guard.
6897         * cp-abi.h: Rename include guard.
6898         * config/sparc/nm-sol2.h: Rename include guard.
6899         * config/nm-nto.h: Rename include guard.
6900         * config/nm-linux.h: Add include guard.
6901         * config/i386/nm-i386gnu.h: Rename include guard.
6902         * config/djgpp/nl_types.h: Rename include guard.
6903         * config/djgpp/langinfo.h: Rename include guard.
6904         * compile/gcc-cp-plugin.h: Add include guard.
6905         * compile/gcc-c-plugin.h: Add include guard.
6906         * compile/compile.h: Rename include guard.
6907         * compile/compile-object-run.h: Rename include guard.
6908         * compile/compile-object-load.h: Rename include guard.
6909         * compile/compile-internal.h: Rename include guard.
6910         * compile/compile-cplus.h: Rename include guard.
6911         * compile/compile-c.h: Rename include guard.
6912         * common/xml-utils.h: Rename include guard.
6913         * common/x86-xstate.h: Rename include guard.
6914         * common/version.h: Rename include guard.
6915         * common/vec.h: Rename include guard.
6916         * common/tdesc.h: Rename include guard.
6917         * common/selftest.h: Rename include guard.
6918         * common/scoped_restore.h: Rename include guard.
6919         * common/scoped_mmap.h: Rename include guard.
6920         * common/scoped_fd.h: Rename include guard.
6921         * common/safe-iterator.h: Rename include guard.
6922         * common/run-time-clock.h: Rename include guard.
6923         * common/refcounted-object.h: Rename include guard.
6924         * common/queue.h: Rename include guard.
6925         * common/ptid.h: Rename include guard.
6926         * common/print-utils.h: Rename include guard.
6927         * common/preprocessor.h: Rename include guard.
6928         * common/pathstuff.h: Rename include guard.
6929         * common/observable.h: Rename include guard.
6930         * common/netstuff.h: Rename include guard.
6931         * common/job-control.h: Rename include guard.
6932         * common/host-defs.h: Rename include guard.
6933         * common/gdb_wait.h: Rename include guard.
6934         * common/gdb_vecs.h: Rename include guard.
6935         * common/gdb_unlinker.h: Rename include guard.
6936         * common/gdb_unique_ptr.h: Rename include guard.
6937         * common/gdb_tilde_expand.h: Rename include guard.
6938         * common/gdb_sys_time.h: Rename include guard.
6939         * common/gdb_string_view.h: Rename include guard.
6940         * common/gdb_splay_tree.h: Rename include guard.
6941         * common/gdb_setjmp.h: Rename include guard.
6942         * common/gdb_ref_ptr.h: Rename include guard.
6943         * common/gdb_optional.h: Rename include guard.
6944         * common/gdb_locale.h: Rename include guard.
6945         * common/gdb_assert.h: Rename include guard.
6946         * common/filtered-iterator.h: Rename include guard.
6947         * common/filestuff.h: Rename include guard.
6948         * common/fileio.h: Rename include guard.
6949         * common/environ.h: Rename include guard.
6950         * common/common-utils.h: Rename include guard.
6951         * common/common-types.h: Rename include guard.
6952         * common/common-regcache.h: Rename include guard.
6953         * common/common-inferior.h: Rename include guard.
6954         * common/common-gdbthread.h: Rename include guard.
6955         * common/common-exceptions.h: Rename include guard.
6956         * common/common-defs.h: Rename include guard.
6957         * common/common-debug.h: Rename include guard.
6958         * common/cleanups.h: Rename include guard.
6959         * common/buffer.h: Rename include guard.
6960         * common/btrace-common.h: Rename include guard.
6961         * common/break-common.h: Rename include guard.
6962         * cli/cli-utils.h: Rename include guard.
6963         * cli/cli-style.h: Rename include guard.
6964         * cli/cli-setshow.h: Rename include guard.
6965         * cli/cli-script.h: Rename include guard.
6966         * cli/cli-interp.h: Rename include guard.
6967         * cli/cli-decode.h: Rename include guard.
6968         * cli/cli-cmds.h: Rename include guard.
6969         * charset-list.h: Add include guard.
6970         * buildsym-legacy.h: Rename include guard.
6971         * bfin-tdep.h: Add include guard.
6972         * ax.h: Rename include guard.
6973         * arm-linux-tdep.h: Add include guard.
6974         * arm-fbsd-tdep.h: Add include guard.
6975         * arch/xtensa.h: Rename include guard.
6976         * arch/tic6x.h: Add include guard.
6977         * arch/i386.h: Add include guard.
6978         * arch/arm.h: Rename include guard.
6979         * arch/arm-linux.h: Rename include guard.
6980         * arch/arm-get-next-pcs.h: Rename include guard.
6981         * arch/amd64.h: Add include guard.
6982         * arch/aarch64-insn.h: Rename include guard.
6983         * arch-utils.h: Rename include guard.
6984         * annotate.h: Add include guard.
6985         * amd64-darwin-tdep.h: Rename include guard.
6986         * aarch64-linux-tdep.h: Add include guard.
6987         * aarch64-fbsd-tdep.h: Add include guard.
6988         * aarch32-linux-nat.h: Add include guard.
6989
6990 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6991
6992         * macrotab.c (macro_define_internal): New function that
6993         factorizes macro_define_object_internal and macro_define_function
6994         code.
6995         (macro_define_object_internal): Use macro_define_internal.
6996         (macro_define_function): Likewise.
6997
6998 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6999
7000         * macrocmd.c (extract_identifier): Return
7001         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7002         callers.
7003
7004 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7005
7006         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7007
7008 2019-02-05  Tom Tromey  <tom@tromey.com>
7009
7010         * target.c (target_stack::unpush): Move assertion earlier.
7011
7012 2019-01-30  Tom Tromey  <tom@tromey.com>
7013
7014         PR python/23615:
7015         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7016         (gdbpy_parse_and_eval): Likewise.
7017         * python/python-internal.h (gdbpy_allow_threads): New class.
7018
7019 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7020
7021         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7022         (aarch64_fbsd_fpregmap): Move earlier.
7023         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7024         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7025         instead of individual calls to trad_frame_set_reg_addr.
7026         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7027         earlier.
7028         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7029         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7030         instead of individual calls to trad_frame_set_reg_addr.
7031
7032 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7033
7034         * CONTRIBUTE: Replace contribution list with wiki link.
7035
7036 2019-01-25  Tom Tromey  <tom@tromey.com>
7037
7038         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7039
7040 2019-01-25  Tom Tromey  <tom@tromey.com>
7041
7042         * xtensa-linux-nat.c: Fix common/ includes.
7043         * xml-support.h: Fix common/ includes.
7044         * xml-support.c: Fix common/ includes.
7045         * x86-linux-nat.c: Fix common/ includes.
7046         * windows-nat.c: Fix common/ includes.
7047         * varobj.h: Fix common/ includes.
7048         * varobj.c: Fix common/ includes.
7049         * value.c: Fix common/ includes.
7050         * valops.c: Fix common/ includes.
7051         * utils.c: Fix common/ includes.
7052         * unittests/xml-utils-selftests.c: Fix common/ includes.
7053         * unittests/utils-selftests.c: Fix common/ includes.
7054         * unittests/unpack-selftests.c: Fix common/ includes.
7055         * unittests/tracepoint-selftests.c: Fix common/ includes.
7056         * unittests/style-selftests.c: Fix common/ includes.
7057         * unittests/string_view-selftests.c: Fix common/ includes.
7058         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7059         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7060         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7061         * unittests/rsp-low-selftests.c: Fix common/ includes.
7062         * unittests/parse-connection-spec-selftests.c: Fix common/
7063         includes.
7064         * unittests/optional-selftests.c: Fix common/ includes.
7065         * unittests/offset-type-selftests.c: Fix common/ includes.
7066         * unittests/observable-selftests.c: Fix common/ includes.
7067         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7068         * unittests/memrange-selftests.c: Fix common/ includes.
7069         * unittests/memory-map-selftests.c: Fix common/ includes.
7070         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7071         * unittests/function-view-selftests.c: Fix common/ includes.
7072         * unittests/environ-selftests.c: Fix common/ includes.
7073         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7074         * unittests/common-utils-selftests.c: Fix common/ includes.
7075         * unittests/cli-utils-selftests.c: Fix common/ includes.
7076         * unittests/array-view-selftests.c: Fix common/ includes.
7077         * ui-file.c: Fix common/ includes.
7078         * tui/tui-io.c: Fix common/ includes.
7079         * tracepoint.h: Fix common/ includes.
7080         * tracepoint.c: Fix common/ includes.
7081         * tracefile-tfile.c: Fix common/ includes.
7082         * top.h: Fix common/ includes.
7083         * top.c: Fix common/ includes.
7084         * thread.c: Fix common/ includes.
7085         * target/waitstatus.h: Fix common/ includes.
7086         * target/waitstatus.c: Fix common/ includes.
7087         * target.h: Fix common/ includes.
7088         * target.c: Fix common/ includes.
7089         * target-memory.c: Fix common/ includes.
7090         * target-descriptions.c: Fix common/ includes.
7091         * symtab.h: Fix common/ includes.
7092         * symfile.c: Fix common/ includes.
7093         * stap-probe.c: Fix common/ includes.
7094         * spu-linux-nat.c: Fix common/ includes.
7095         * sparc-nat.c: Fix common/ includes.
7096         * source.c: Fix common/ includes.
7097         * solib.c: Fix common/ includes.
7098         * solib-target.c: Fix common/ includes.
7099         * ser-unix.c: Fix common/ includes.
7100         * ser-tcp.c: Fix common/ includes.
7101         * ser-pipe.c: Fix common/ includes.
7102         * ser-base.c: Fix common/ includes.
7103         * selftest-arch.c: Fix common/ includes.
7104         * s12z-tdep.c: Fix common/ includes.
7105         * rust-exp.y: Fix common/ includes.
7106         * rs6000-aix-tdep.c: Fix common/ includes.
7107         * riscv-tdep.c: Fix common/ includes.
7108         * remote.c: Fix common/ includes.
7109         * remote-notif.h: Fix common/ includes.
7110         * remote-fileio.h: Fix common/ includes.
7111         * remote-fileio.c: Fix common/ includes.
7112         * regcache.h: Fix common/ includes.
7113         * regcache.c: Fix common/ includes.
7114         * record-btrace.c: Fix common/ includes.
7115         * python/python.c: Fix common/ includes.
7116         * python/py-type.c: Fix common/ includes.
7117         * python/py-inferior.c: Fix common/ includes.
7118         * progspace.h: Fix common/ includes.
7119         * producer.c: Fix common/ includes.
7120         * procfs.c: Fix common/ includes.
7121         * proc-api.c: Fix common/ includes.
7122         * printcmd.c: Fix common/ includes.
7123         * ppc-linux-nat.c: Fix common/ includes.
7124         * parser-defs.h: Fix common/ includes.
7125         * osdata.c: Fix common/ includes.
7126         * obsd-nat.c: Fix common/ includes.
7127         * nat/x86-linux.c: Fix common/ includes.
7128         * nat/x86-linux-dregs.c: Fix common/ includes.
7129         * nat/x86-dregs.h: Fix common/ includes.
7130         * nat/x86-dregs.c: Fix common/ includes.
7131         * nat/ppc-linux.c: Fix common/ includes.
7132         * nat/mips-linux-watch.h: Fix common/ includes.
7133         * nat/mips-linux-watch.c: Fix common/ includes.
7134         * nat/linux-waitpid.c: Fix common/ includes.
7135         * nat/linux-ptrace.h: Fix common/ includes.
7136         * nat/linux-ptrace.c: Fix common/ includes.
7137         * nat/linux-procfs.c: Fix common/ includes.
7138         * nat/linux-personality.c: Fix common/ includes.
7139         * nat/linux-osdata.c: Fix common/ includes.
7140         * nat/linux-namespaces.c: Fix common/ includes.
7141         * nat/linux-btrace.h: Fix common/ includes.
7142         * nat/linux-btrace.c: Fix common/ includes.
7143         * nat/fork-inferior.c: Fix common/ includes.
7144         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7145         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7146         * nat/aarch64-linux.c: Fix common/ includes.
7147         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7148         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7149         * namespace.h: Fix common/ includes.
7150         * mips-linux-tdep.c: Fix common/ includes.
7151         * minsyms.c: Fix common/ includes.
7152         * mi/mi-parse.h: Fix common/ includes.
7153         * mi/mi-main.c: Fix common/ includes.
7154         * mi/mi-cmd-env.c: Fix common/ includes.
7155         * memrange.h: Fix common/ includes.
7156         * memattr.c: Fix common/ includes.
7157         * maint.h: Fix common/ includes.
7158         * maint.c: Fix common/ includes.
7159         * main.c: Fix common/ includes.
7160         * machoread.c: Fix common/ includes.
7161         * location.c: Fix common/ includes.
7162         * linux-thread-db.c: Fix common/ includes.
7163         * linux-nat.c: Fix common/ includes.
7164         * linux-fork.c: Fix common/ includes.
7165         * inline-frame.c: Fix common/ includes.
7166         * infrun.c: Fix common/ includes.
7167         * inflow.c: Fix common/ includes.
7168         * inferior.h: Fix common/ includes.
7169         * inferior.c: Fix common/ includes.
7170         * infcmd.c: Fix common/ includes.
7171         * inf-ptrace.c: Fix common/ includes.
7172         * inf-child.c: Fix common/ includes.
7173         * ia64-linux-nat.c: Fix common/ includes.
7174         * i387-tdep.c: Fix common/ includes.
7175         * i386-tdep.c: Fix common/ includes.
7176         * i386-linux-tdep.c: Fix common/ includes.
7177         * i386-linux-nat.c: Fix common/ includes.
7178         * i386-go32-tdep.c: Fix common/ includes.
7179         * i386-fbsd-tdep.c: Fix common/ includes.
7180         * i386-fbsd-nat.c: Fix common/ includes.
7181         * guile/scm-type.c: Fix common/ includes.
7182         * guile/guile.c: Fix common/ includes.
7183         * go32-nat.c: Fix common/ includes.
7184         * gnu-nat.c: Fix common/ includes.
7185         * gdbthread.h: Fix common/ includes.
7186         * gdbarch-selftests.c: Fix common/ includes.
7187         * gdb_usleep.c: Fix common/ includes.
7188         * gdb_select.h: Fix common/ includes.
7189         * gdb_bfd.c: Fix common/ includes.
7190         * gcore.c: Fix common/ includes.
7191         * fork-child.c: Fix common/ includes.
7192         * findvar.c: Fix common/ includes.
7193         * fbsd-nat.c: Fix common/ includes.
7194         * event-top.c: Fix common/ includes.
7195         * event-loop.c: Fix common/ includes.
7196         * dwarf2read.c: Fix common/ includes.
7197         * dwarf2loc.c: Fix common/ includes.
7198         * dwarf2-frame.c: Fix common/ includes.
7199         * dwarf-index-cache.c: Fix common/ includes.
7200         * dtrace-probe.c: Fix common/ includes.
7201         * disasm-selftests.c: Fix common/ includes.
7202         * defs.h: Fix common/ includes.
7203         * csky-tdep.c: Fix common/ includes.
7204         * cp-valprint.c: Fix common/ includes.
7205         * cp-support.h: Fix common/ includes.
7206         * cp-support.c: Fix common/ includes.
7207         * corelow.c: Fix common/ includes.
7208         * completer.h: Fix common/ includes.
7209         * completer.c: Fix common/ includes.
7210         * compile/compile.c: Fix common/ includes.
7211         * compile/compile-loc2c.c: Fix common/ includes.
7212         * compile/compile-cplus-types.c: Fix common/ includes.
7213         * compile/compile-cplus-symbols.c: Fix common/ includes.
7214         * command.h: Fix common/ includes.
7215         * cli/cli-dump.c: Fix common/ includes.
7216         * cli/cli-cmds.c: Fix common/ includes.
7217         * charset.c: Fix common/ includes.
7218         * build-id.c: Fix common/ includes.
7219         * btrace.h: Fix common/ includes.
7220         * btrace.c: Fix common/ includes.
7221         * breakpoint.h: Fix common/ includes.
7222         * breakpoint.c: Fix common/ includes.
7223         * ax.h:
7224         (enum agent_op): Fix common/ includes.
7225         * ax-general.c (struct aop_map): Fix common/ includes.
7226         * ax-gdb.c: Fix common/ includes.
7227         * auxv.c: Fix common/ includes.
7228         * auto-load.c: Fix common/ includes.
7229         * arm-tdep.c: Fix common/ includes.
7230         * arch/riscv.c: Fix common/ includes.
7231         * arch/ppc-linux-common.c: Fix common/ includes.
7232         * arch/i386.c: Fix common/ includes.
7233         * arch/arm.c: Fix common/ includes.
7234         * arch/arm-linux.c: Fix common/ includes.
7235         * arch/arm-get-next-pcs.c: Fix common/ includes.
7236         * arch/amd64.c: Fix common/ includes.
7237         * arch/aarch64.c: Fix common/ includes.
7238         * arch/aarch64-insn.c: Fix common/ includes.
7239         * arch-utils.c: Fix common/ includes.
7240         * amd64-windows-tdep.c: Fix common/ includes.
7241         * amd64-tdep.c: Fix common/ includes.
7242         * amd64-sol2-tdep.c: Fix common/ includes.
7243         * amd64-obsd-tdep.c: Fix common/ includes.
7244         * amd64-nbsd-tdep.c: Fix common/ includes.
7245         * amd64-linux-tdep.c: Fix common/ includes.
7246         * amd64-linux-nat.c: Fix common/ includes.
7247         * amd64-fbsd-tdep.c: Fix common/ includes.
7248         * amd64-fbsd-nat.c: Fix common/ includes.
7249         * amd64-dicos-tdep.c: Fix common/ includes.
7250         * amd64-darwin-tdep.c: Fix common/ includes.
7251         * agent.c: Fix common/ includes.
7252         * ada-lang.h: Fix common/ includes.
7253         * ada-lang.c: Fix common/ includes.
7254         * aarch64-tdep.c: Fix common/ includes.
7255
7256 2019-01-25  Tom Tromey  <tom@tromey.com>
7257
7258         * common/create-version.sh: Use common/version.h.
7259
7260 2019-01-24  Pedro Alves  <palves@redhat.com>
7261
7262         * infrun.c (signal_stop, signal_print, signal_program)
7263         (signal_catch, signal_pass): Now arrays instead of pointers.
7264         (update_signals_program_target, do_target_resume)
7265         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7266         * linux-nat.c (linux_nat_target::pass_signals)
7267         (linux_nat_target::create_inferior, linux_nat_target::attach):
7268         Adjust.
7269         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7270         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7271         * procfs.c (procfs_target::pass_signals): Adjust.
7272         * record-full.c (record_full_target::resume): Adjust.
7273         * remote.c (remote_target::pass_signals)
7274         (remote_target::program_signals): Adjust.
7275         * target-debug.h (target_debug_print_signals): Now takes a
7276         gdb::array_view as parameter.  Adjust.
7277         * target.h (target_ops) <pass_signals, program_signals>: Replace
7278         pointer and length parameters with gdb::array_view.
7279         (target_pass_signals, target_program_signals): Likewise.
7280         * target-delegates.c: Regenerate.
7281
7282 2019-01-24  Pedro Alves  <palves@redhat.com>
7283
7284         * common/forward-scope-exit.h
7285         (forward_scope_exit::forward_scope_exit): Pass arguments to
7286         m_bind_function directly, instead of creating a std::bind and
7287         copying that.
7288
7289 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7290
7291         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7292         for static members.
7293         (pass_in_v_vfp_candidate): Likewise.
7294
7295 2019-01-23  Tom Tromey  <tom@tromey.com>
7296             Pedro Alves  <palves@redhat.com>
7297
7298         * regcache.c (class regcache_invalidator): Remove.
7299         (regcache::raw_write): Use make_scope_exit.
7300
7301 2019-01-23  Tom Tromey  <tom@tromey.com>
7302
7303         * ui-out.h (class ui_out_emit_type): Update comment.
7304
7305 2019-01-23  Tom Tromey  <tom@tromey.com>
7306
7307         * infrun.c (fetch_inferior_event): Update comment.
7308
7309 2019-01-23  Tom Tromey  <tom@tromey.com>
7310             Pedro Alves  <palves@redhat.com>
7311
7312         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7313         parameter.
7314         (fetch_inferior_event): Use SCOPE_EXIT.
7315
7316
7317 2019-01-23  Tom Tromey  <tom@tromey.com>
7318             Pedro Alves  <palves@redhat.com>
7319
7320         * infrun.c (disable_thread_events): Delete.
7321         (stop_all_threads): Use SCOPE_EXIT.
7322
7323 2019-01-23  Tom Tromey  <tom@tromey.com>
7324             Pedro Alves  <palves@redhat.com>
7325
7326         * symfile.c: Include forward-scope-exit.h.
7327         (clear_symtab_users_cleanup): Replace forward declaration with
7328         a FORWARD_SCOPE_EXIT.
7329         (syms_from_objfile_1): Use the forward_scope_exit and
7330         gdb::optional instead of cleanup_function.
7331         (reread_symbols): Use the forward_scope_exit instead of
7332         cleanup_function.
7333         (clear_symtab_users_cleanup): Remove function.
7334
7335 2019-01-23  Tom Tromey  <tom@tromey.com>
7336             Pedro Alves  <palves@redhat.com>
7337
7338         * linux-nat.c: Include scope-exit.h.
7339         (cleanup_target_stop): Remove.
7340         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7341         SCOPE_EXIT.
7342
7343 2019-01-23  Tom Tromey  <tom@tromey.com>
7344             Pedro Alves  <palves@redhat.com>
7345
7346         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7347         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7348
7349 2019-01-23  Tom Tromey  <tom@tromey.com>
7350             Andrew Burgess  <andrew.burgess@embecosm.com>
7351             Pedro Alves  <palves@redhat.com>
7352
7353         * infrun.c (fetch_inferior_event): Use scope_exit.
7354         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7355         * top.c (execute_command): Use scope_exit.
7356         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7357         * utils.c (do_bpstat_clear_actions_cleanup)
7358         (make_bpstat_clear_actions_cleanup): Remove.
7359
7360 2019-01-23  Tom Tromey  <tom@tromey.com>
7361             Pedro Alves  <palves@redhat.com>
7362
7363         * infrun.c: Include "common/scope-exit.h"
7364         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7365         (wait_for_inferior): Use SCOPE_EXIT.
7366         (fetch_inferior_event): Use scope_exit.
7367
7368 2019-01-23  Tom Tromey  <tom@tromey.com>
7369             Pedro Alves  <palves@redhat.com>
7370
7371         * breakpoint.c (create_breakpoint): Remove cleanup.
7372
7373 2019-01-23  Tom Tromey  <tom@tromey.com>
7374             Andrew Burgess  <andrew.burgess@embecosm.com>
7375             Pedro Alves  <palves@redhat.com>
7376
7377 2019-01-23  Pedro Alves  <palves@redhat.com>
7378
7379         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7380
7381 2019-01-23  Pedro Alves  <palves@redhat.com>
7382             Andrew Burgess  <andrew.burgess@embecosm.com>
7383
7384         * gdbthread.h: Include "common/forward-scope-exit.h".
7385         (scoped_finish_thread_state): Redefine custom class in terms of
7386         forward_scope_exit.
7387
7388 2019-01-23  Pedro Alves  <palves@redhat.com>
7389             Andrew Burgess  <andrew.burgess@embecosm.com>
7390
7391         * common/forward-scope-exit.h: New file.
7392
7393 2019-01-23  Pedro Alves  <palves@redhat.com>
7394             Andrew Burgess  <andrew.burgess@embecosm.com>
7395             Tom Tromey  <tom@tromey.com>
7396
7397         * common/scope-exit.h: New file.
7398
7399 2019-01-23  Pedro Alves  <palves@redhat.com>
7400
7401         * common/preprocessor.h (ESC): Rename to ...
7402         (ESC_PARENS): ... this.
7403         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7404         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7405
7406 2019-01-23  Tom Tromey  <tom@tromey.com>
7407
7408         * language.h (class scoped_switch_to_sym_language_if_auto):
7409         Initialize m_lang in both cases.
7410
7411 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7412
7413         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7414         with XCNEW.
7415
7416 2019-01-22  Tom Tromey  <tom@tromey.com>
7417
7418         * corelow.c: Do not include sys/file.h.
7419
7420 2019-01-22  Tom Tromey  <tom@tromey.com>
7421
7422         * tui/tui-wingeneral.h: Include gdb_curses.h.
7423
7424 2019-01-22  Tom Tromey  <tom@tromey.com>
7425
7426         * source-cache.h (class source_cache) <get_source_lines,
7427         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7428
7429 2019-01-22  Tom Tromey  <tom@tromey.com>
7430
7431         * remote-fileio.h (struct remote_target): Declare.
7432
7433 2019-01-22  Tom Tromey  <tom@tromey.com>
7434
7435         * python/py-arch.c: Do not include py-ref.h.
7436         * python/py-bpevent.c: Do not include py-ref.h.
7437         * python/py-cmd.c: Do not include py-ref.h.
7438         * python/py-continueevent.c: Do not include py-ref.h.
7439         * python/py-event.h: Do not include py-ref.h.
7440         * python/py-evtregistry.c: Do not include py-ref.h.
7441         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7442         * python/py-frame.c: Do not include py-ref.h.
7443         * python/py-framefilter.c: Do not include py-ref.h.
7444         * python/py-function.c: Do not include py-ref.h.
7445         * python/py-infevents.c: Do not include py-ref.h.
7446         * python/py-linetable.c: Do not include py-ref.h.
7447         * python/py-objfile.c: Do not include py-ref.h.
7448         * python/py-param.c: Do not include py-ref.h.
7449         * python/py-prettyprint.c: Do not include py-ref.h.
7450         * python/py-progspace.c: Do not include py-ref.h.
7451         * python/py-symbol.c: Do not include py-ref.h.
7452         * python/py-symtab.c: Do not include py-ref.h.
7453         * python/py-type.c: Do not include py-ref.h.
7454         * python/py-unwind.c: Do not include py-ref.h.
7455         * python/py-utils.c: Do not include py-ref.h.
7456         * python/py-value.c: Do not include py-ref.h.
7457         * python/py-varobj.c: Do not include py-ref.h.
7458         * python/py-xmethods.c: Do not include py-ref.h.
7459         * python/python.c: Do not include py-ref.h.
7460         * varobj.c: Do not include py-ref.h.
7461
7462 2019-01-22  Tom Tromey  <tom@tromey.com>
7463
7464         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7465         keyword for bcache.
7466
7467 2019-01-22  Tom Tromey  <tom@tromey.com>
7468
7469         * compile/compile-cplus-types.c: Remove a comment by #include.
7470
7471 2019-01-22  Tom Tromey  <tom@tromey.com>
7472
7473         * compile/gcc-c-plugin.h: Include compile-internal.h.
7474
7475 2019-01-22  Tom Tromey  <tom@tromey.com>
7476
7477         * stabsread.c (EXTERN): Do not define.
7478         (symnum, next_symbol_text_func, processing_gcc_compilation)
7479         (within_function, global_sym_chain, global_stabs)
7480         (previous_stab_code, this_object_header_files)
7481         (n_this_object_header_files)
7482         (n_allocated_this_object_header_files): Define.
7483         * stabsread.h (EXTERN): Never define.  Use "extern".
7484
7485 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7486
7487         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7488         history_value.
7489
7490 2019-01-21  Tom Tromey  <tom@tromey.com>
7491
7492         * ui-out.c: Fix includes.
7493         * tui/tui-source.c: Fix includes.
7494         * target.c: Fix includes.
7495         * remote.c: Fix includes.
7496         * regcache.c: Fix includes.
7497         * python/py-block.c: Fix includes.
7498         * printcmd.c: Fix includes.
7499         * or1k-tdep.c: Fix includes.
7500         * mi/mi-main.c: Fix includes.
7501         * m32r-tdep.c: Fix includes.
7502         * csky-tdep.c: Fix includes.
7503         * compile/compile-cplus-types.c: Fix includes.
7504         * cli/cli-interp.c: Fix includes.
7505
7506 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7507
7508         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7509         for padding.
7510
7511 2019-01-16  Tom Tromey  <tom@tromey.com>
7512
7513         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7514         earlier.
7515         (struct objfile) <msymbols_range>: Move from top level.
7516         <msymbols>: New method.
7517         (class objfile_msymbols): Remove.
7518         * symtab.c (default_collect_symbol_completion_matches_break_on):
7519         Update.
7520         * symmisc.c (dump_msymbols): Update.
7521         * stabsread.c (scan_file_globals): Update.
7522         * objc-lang.c (info_selectors_command, info_classes_command)
7523         (find_methods): Update.
7524         * minsyms.c (find_solib_trampoline_target): Update.
7525         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7526         * coffread.c (coff_symfile_read): Update.
7527         * ada-lang.c (ada_lookup_simple_minsym)
7528         (ada_collect_symbol_completion_matches): Update.
7529
7530 2019-01-16  Tom Tromey  <tom@tromey.com>
7531
7532         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7533         type.  Remove no-argument constructor.
7534         <iterator::operator++>: Simplify.
7535         <begin>: Update.
7536         <end>: Use minimal_symbol_count.
7537
7538 2019-01-16  Tom Tromey  <tom@tromey.com>
7539
7540         * objfiles.h (struct objfile) <psymtabs>: New method.
7541         (class objfile_psymtabs): Remove.
7542         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7543         typedef.
7544         <range>: New method.
7545         (require_partial_symbols): Change return type.
7546         * psymtab.c (require_partial_symbols)
7547         (psym_expand_symtabs_matching): Update.
7548         * mdebugread.c (parse_partial_symbols): Update.
7549         * dbxread.c (dbx_end_psymtab): Update.
7550
7551 2019-01-15  Tom Tromey  <tom@tromey.com>
7552
7553         * symtab.c (lookup_objfile_from_block)
7554         (lookup_symbol_in_objfile_symtabs)
7555         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7556         (find_line_symtab, info_sources_command)
7557         (default_collect_symbol_completion_matches_break_on)
7558         (make_source_files_completion_list): Update.
7559         * symmisc.c (print_objfile_statistics, dump_objfile)
7560         (maintenance_print_symbols, maintenance_info_symtabs)
7561         (maintenance_check_symtabs, maintenance_info_line_tables):
7562         Update.
7563         * source.c (select_source_symtab)
7564         (forget_cached_source_info_for_objfile): Update.
7565         * objfiles.h (class objfile_compunits): Remove.
7566         (struct objfile) <compunits_range>: New typedef.
7567         (compunits): New method.
7568         * objfiles.c (objfile_relocate1): Update.
7569         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7570         * maint.c (count_symtabs_and_blocks): Update.
7571         * linespec.c (iterate_over_all_matching_symtabs): Update.
7572         * cp-support.c (add_symbol_overload_list_qualified): Update.
7573         * coffread.c (coff_symtab_read): Update.
7574         * ada-lang.c (add_nonlocal_symbols)
7575         (ada_collect_symbol_completion_matches)
7576         (ada_add_global_exceptions): Update.
7577
7578 2019-01-15  Tom Tromey  <tom@tromey.com>
7579
7580         * progspace.h (program_space) <objfiles_safe_range>: New
7581         typedef.
7582         <objfiles_safe>: New method.
7583         * objfiles.h (class all_objfiles_safe): Remove.
7584         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7585         * jit.c (jit_inferior_exit_hook): Update.
7586
7587 2019-01-17  Tom Tromey  <tom@tromey.com>
7588
7589         * progspace.h (program_space) <objfiles_range>: New typedef.
7590         <objfiles>: New method.
7591         <objfiles_head>: Rename from objfiles.
7592         (object_files): Update.
7593         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7594         * guile/scm-pretty-print.c
7595         (ppscm_find_pretty_printer_from_objfiles): Update.
7596         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7597         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7598         Update.
7599         * python/py-progspace.c (pspy_get_objfiles): Update.
7600         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7601         Update.
7602         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7603         (objfpy_lookup_objfile_by_build_id): Update.
7604         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7605         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7606         Update.
7607         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7608         (expand_symtab_containing_pc, lookup_objfile_from_block)
7609         (lookup_static_symbol, basic_lookup_transparent_type)
7610         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7611         (find_line_symtab, info_sources_command)
7612         (default_collect_symbol_completion_matches_break_on)
7613         (make_source_files_completion_list, find_main_name): Update.
7614         * symmisc.c (print_symbol_bcache_statistics)
7615         (print_objfile_statistics, maintenance_print_symbols)
7616         (maintenance_print_msymbols, maintenance_print_objfiles)
7617         (maintenance_info_symtabs, maintenance_check_symtabs)
7618         (maintenance_expand_symtabs, maintenance_info_line_tables):
7619         Update.
7620         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7621         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7622         (map_overlay_command, unmap_overlay_command)
7623         (simple_overlay_update, expand_symtabs_matching)
7624         (map_symbol_filenames): Update.
7625         * symfile-debug.c (set_debug_symfile): Update.
7626         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7627         Update.
7628         * source.c (select_source_symtab, forget_cached_source_info):
7629         Update.
7630         * solib.c (solib_read_symbols): Update.
7631         * solib-spu.c (append_ocl_sos): Update.
7632         * psymtab.c (maintenance_print_psymbols)
7633         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7634         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7635         * printcmd.c (info_symbol_command): Update.
7636         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7637         Update.
7638         * objfiles.h (class all_objfiles): Remove.
7639         * objfiles.c (have_partial_symbols, have_full_symbols)
7640         (have_minimal_symbols, qsort_cmp, update_section_map)
7641         (shared_objfile_contains_address_p)
7642         (default_iterate_over_objfiles_in_search_order): Update.
7643         * objc-lang.c (info_selectors_command, info_classes_command)
7644         (find_methods): Update.
7645         * minsyms.c (find_solib_trampoline_target): Update.
7646         * maint.c (maintenance_info_sections)
7647         (maintenance_translate_address, count_symtabs_and_blocks):
7648         Update.
7649         * main.c (captured_main_1): Update.
7650         * linux-thread-db.c (try_thread_db_load_from_pdir)
7651         (has_libpthread): Update.
7652         * linespec.c (iterate_over_all_matching_symtabs)
7653         (search_minsyms_for_name): Update.
7654         * jit.c (jit_find_objf_with_entry_addr): Update.
7655         * hppa-tdep.c (find_unwind_entry)
7656         (hppa_lookup_stub_minimal_symbol): Update.
7657         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7658         Update.
7659         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7660         (elf_gnu_ifunc_resolve_by_got): Update.
7661         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7662         * dwarf-index-write.c (save_gdb_index_command): Update.
7663         * cp-support.c (add_symbol_overload_list_qualified): Update.
7664         * breakpoint.c (create_overlay_event_breakpoint)
7665         (create_longjmp_master_breakpoint)
7666         (create_std_terminate_master_breakpoint)
7667         (create_exception_master_breakpoint): Update.
7668         * blockframe.c (find_pc_partial_function): Update.
7669         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7670         (ada_collect_symbol_completion_matches)
7671         (ada_add_global_exceptions): Update.
7672
7673 2019-01-17  Tom Tromey  <tom@tromey.com>
7674
7675         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7676         declare VEC.
7677         (solib_target_parse_libraries): Change return type.
7678         (library_list_start_segment, library_list_start_section)
7679         (library_list_end_library, library_list_start_library); Update.
7680         (solib_target_free_library_list): Remove.
7681         (solib_target_parse_libraries): Remove cleanup.  Change return
7682         type.
7683         (solib_target_current_sos): Update.
7684
7685 2019-01-17  Tom Tromey  <tromey@bapiya>
7686
7687         * valprint.c: Replace "the the" with "the".
7688         * symtab.c: Replace "the the" with "the".
7689         * solib.c: Replace "the the" with "the".
7690         * solib-dsbt.c: Replace "the the" with "the".
7691         * linespec.c: Replace "the the" with "the".
7692         * dwarf2loc.h: Replace "the the" with "the".
7693         * amd64-windows-tdep.c: Replace "the the" with "the".
7694         * aarch64-tdep.c: Replace "the the" with "the".
7695
7696 2019-01-16  Keith Seitz  <keiths@redhat.com>
7697
7698         PR gdb/23773
7699         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7700         <builder>: Rename to ..
7701         <m_builder>: ... this and make private.
7702         (dwarf2_cu::get_builder): New method.  Change all users of
7703         `builder' to use this method.
7704         (dwarf2_start_symtab): Move to ...
7705         (dwarf2_cu::start_symtab): ... here.  Update all callers
7706         (setup_type_unit_groups): Move to ...
7707         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7708         callers.
7709         (dwarf2_cu::reset_builder): New method.
7710         (process_full_compunit, process_full_type_unit): Use
7711         dwarf2_cu::reset_builder.
7712         (follow_die_offset): Record the ancestor CU if it is different
7713         from the followed DIE's CU.
7714         (follow_die_sig_1): Likewise.
7715
7716 2019-01-15  Tom Tromey  <tom@tromey.com>
7717
7718         * remote.c (class remote_state) <buf>: Now a char_vector.
7719         <buf_size>: Remove.
7720         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7721         parameter.
7722         (remote_target::getpkt_or_notif_sane_1)
7723         (remote_target::getpkt_sane)
7724         (remote_target::getpkt_or_notif_sane): Likewise.
7725         (class remote_target) <putpkt>: New overload.
7726         (remote_target::read_frame): Change type of "buf_p".  Remove
7727         sizeof_p parameter.
7728         (packet_ok): New overload.
7729         (packet_check_result): New overload.
7730         Update all uses.
7731
7732 2019-01-14  Tom Tromey  <tom@tromey.com>
7733
7734         * remote-notif.c (handle_notification, remote_notif_ack)
7735         (remote_notif_parse): Make "buf" const.
7736         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7737         const.
7738         (remote_notif_parse, remote_notif_ack, handle_notification):
7739         Likewise.
7740         * remote.c (remote_notif_stop_parse): Make "buf" const.
7741         (remote_target::remote_parse_stop_reply): Make "buf" const.
7742         (remote_notif_stop_ack): Make "buf" const.
7743
7744 2019-01-14  Tom Tromey  <tom@tromey.com>
7745
7746         * remote.c (remote_console_output): Make parameter const.
7747
7748 2019-01-14  Tom Tromey  <tom@tromey.com>
7749
7750         * target-debug.h (target_debug_print_signals): Constify.
7751         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7752         * procfs.c (procfs_target::pass_signals): Update.
7753         * linux-nat.c (linux_nat_target::pass_signals): Update.
7754         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7755         * target-delegates.c: Rebuild.
7756         * remote.c (remote_target::program_signals): Update.
7757         (remote_target::pass_signals): Update.
7758         * target.c (target_pass_signals): Constify argument.
7759         (target_program_signals): Likewise.
7760         * target.h (struct target_ops) <pass_signals, program_signals>:
7761         Constify argument.
7762         (target_pass_signals, target_program_signals): Constify argument.
7763
7764 2019-01-14  Tom Tromey  <tom@tromey.com>
7765
7766         PR tui/28819:
7767         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7768
7769 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7770
7771         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7772         field.
7773         * rs6000-tdep.c: Include reggroups.h.
7774         (IS_V_ALIAS_PSEUDOREG): Define.
7775         (rs6000_register_name): Return names for the "vX" aliases.
7776         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7777         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7778         aliases.  Call default_register_reggroup_p for all other
7779         pseudo-registers.
7780         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7781         New functions.
7782         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7783         Handle "vX" aliases.
7784         (v_alias_pseudo_register_collect): New function.
7785         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7786         (rs6000_gdbarch_init): Initialize "vX" aliases as
7787         pseudo-registers.  Restore registration of
7788         rs6000_pseudo_register_reggroup_p with
7789         set_tdesc_pseudo_register_reggroup_p.
7790
7791 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7792
7793         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7794         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7795         set_gdbarch_num_pseudo_regs.
7796
7797 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7798
7799         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7800         Remove arg prefixname, add do_set and do_show.
7801         Add member functions set_list and show_list.
7802         * cli/cli-style.c (class cli_style_option): Update accordingly.
7803         (style_set_list): Move to file scope.
7804         (style_show_list): Likewise.
7805         (set_style): Call help_list.
7806         (show_style): Call cmd_show_list.
7807         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7808         Update to use the new macro.
7809
7810 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7811
7812         * ada-lang.c (_initialize_ada_language): Expand the help text
7813         for the "catch exception" command.
7814
7815 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7816
7817         * symtab.c (matching_obj_sections): Initialize obj,
7818         declare it closer to its usage.
7819
7820 2019-01-10  Tom Tromey  <tom@tromey.com>
7821
7822         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7823         (basic_inf_threads_range): Remove.
7824         (inf_threads_range, inf_non_exited_threads_range)
7825         (safe_inf_threads_range): Use next_adapter.
7826
7827 2019-01-10  Keith Seitz  <keiths@redhat.com>
7828
7829         PR gdb/23712
7830         PR symtab/23010
7831         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7832         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7833
7834 2019-01-10  Keith Seitz  <keiths@redhat.com>
7835
7836         PR gdb/23712
7837         PR symtab/23010
7838         * dictionary.c (pending_to_vector): Remove.
7839         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7840         Remove _1 suffix, replacing functions of the same name.  Update
7841         all callers.
7842         (dict_create_hashed, dict_create_hashed_expandable)
7843         (dict_create_linear, dict_create_linear_expandable, dict_free)
7844         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7845         Make functions static.
7846
7847 2019-01-10  Keith Seitz  <keiths@redhat.com>
7848
7849         PR gdb/23712
7850         PR symtab/23010
7851         * dictionary.h (struct dictionary): Replace declaration with
7852         multidictionary.
7853         (dict_create_hashed, dict_create_hashed_expandable)
7854         (dict_create_linear, dict_create_linear_expandable)
7855         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7856         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7857         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7858         taking multidictionary argument.
7859         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7860         * block.h (struct block) <dict>: Change to multidictionary
7861         and rename `multidict'.
7862         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7863         symmisc.c: Update all dictionary references to multidictionary.
7864
7865 2019-01-10  Keith Seitz  <keiths@redhat.com>
7866
7867         PR gdb/23712
7868         PR symtab/23010
7869         * dictionary.c: Include unordered_map.
7870         (pending_to_vector): New function.
7871         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7872         Rewrite the non-"_1" functions to take vector instead
7873         of linked list.
7874         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7875         "new" _1 versions of the same name.
7876         (multidictionary): Define.
7877         (std::hash<enum language): New definition.
7878         (collate_pending_symbols_by_language, mdict_create_hashed)
7879         (mdict_create_hashed_expandable, mdict_create_linear)
7880         (mdict_create_linear_expandable, mdict_free)
7881         (find_language_dictionary, create_new_language_dictionary)
7882         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7883         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7884         (mdict_size, mdict_empty): New functions.
7885         * dictionary.h (mdict_iterator): Define.
7886
7887 2019-01-10  Pedro Alves  <palves@redhat.com>
7888
7889         * breakpoint.c (read_uploaded_action)
7890         (create_tracepoint_from_upload): Adjust to use
7891         gdb::unique_xmalloc_ptr.
7892         * ctf.c (ctf_write_uploaded_tp):
7893         (SET_ARRAY_FIELD): Use emplace_back.
7894         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7895         * tracefile-tfile.c (tfile_write_uploaded_tp):
7896         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7897         gdb::unique_xmalloc_ptr.
7898         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7899         at_string, cond_string, cmd_strings>: Replace char pointers
7900         with gdb::unique_xmalloc_ptr.
7901
7902 2019-01-10  Pedro Alves  <palves@redhat.com>
7903
7904         * solib-target.c (library_list_start_library): Don't xstrdup name.
7905
7906 2019-01-10  Pedro Alves  <palves@redhat.com>
7907
7908         * mdebugread.c (parse_partial_symbols): Use
7909         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7910
7911 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7912
7913         * linux-fork.c (scoped_switch_fork_info)
7914         <~scoped_switch_fork_info>: Fix incorrect variable name.
7915
7916 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7917
7918         * linux-fork.c (scoped_switch_fork_info)
7919         <scoped_switch_fork_info>: Make explicit.
7920         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7921
7922 2019-01-10  Tom Tromey  <tom@tromey.com>
7923
7924         * objfiles.h (objfile::reset_psymtabs): Update.
7925         * objfiles.c (objfile::objfile): Update.
7926         * psymtab.h (psymtab_storage::obstack): Update.
7927         (psymtab_storage::m_obstack): Use gdb::optional.
7928         (class psymtab_storage): Update comment.  Remove objfile
7929         parameter.
7930         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7931
7932 2019-01-10  Tom Tromey  <tom@tromey.com>
7933
7934         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7935         <free_psymtabs>: Now private.
7936         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7937         (allocate_psymtab): Use new method.
7938
7939 2019-01-10  Tom Tromey  <tom@tromey.com>
7940
7941         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7942         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7943         * mdebugread.c (parse_partial_symbols): Use
7944         allocate_dependencies.
7945         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7946         allocate_dependencies.
7947         (process_psymtab_comp_unit_reader)
7948         (build_type_psymtab_dependencies): Likewise.
7949         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7950
7951 2019-01-10  Tom Tromey  <tom@tromey.com>
7952
7953         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7954         PSYMBOL_SET_LANGUAGE.
7955         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7956
7957 2019-01-10  Tom Tromey  <tom@tromey.com>
7958
7959         * psymtab.h (psymtab_storage::obstack): New method.
7960         <m_obstack>: Rename from obstack; now private.
7961         * psymtab.c (psymtab_storage): Update.
7962         * dwarf2read.c (create_addrmap_from_index)
7963         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7964         Update.
7965
7966 2019-01-10  Tom Tromey  <tom@tromey.com>
7967
7968         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7969         * objfiles.h (objfile::reset_psymtabs): New method.
7970
7971 2019-01-10  Tom Tromey  <tom@tromey.com>
7972
7973         * symmisc.c (print_symbol_bcache_statistics): Update.
7974         (print_objfile_statistics): Update.
7975         * symfile.c (reread_symbols): Update.
7976         * psymtab.h (class psymtab_storage): New.
7977         * psymtab.c (psymtab_storage): New constructor.
7978         (~psymtab_storage): New destructor.
7979         (require_partial_symbols): Update.
7980         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7981         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7982         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7983         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7984         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7985         (start_psymtab_common, end_psymtab_common)
7986         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7987         (allocate_psymtab): Update.
7988         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7989         Update.
7990         (dump_psymtab_addrmap, maintenance_print_psymbols)
7991         (maintenance_check_psymtabs): Update.
7992         (class objfile_psymtabs): Move to objfiles.h.
7993         * psympriv.h (discard_psymtab): Now inline.
7994         (psymtab_discarder::psymtab_discarder): Update.
7995         (psymtab_discarder::~psymtab_discarder): Update.
7996         (ALL_OBJFILE_PSYMTABS): Rewrite.
7997         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7998         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7999         Remove fields.
8000         <partial_symtabs>: New field.
8001         (class objfile_psymtabs): Move from psymtab.h.  Update.
8002         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8003         psymbol_cache.
8004         (objfile::~objfile): Don't destroy psymbol_cache.
8005         * mdebugread.c (parse_partial_symbols): Update.
8006         * dwarf2read.c (create_addrmap_from_index)
8007         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8008         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8009         (add_partial_subprogram, dwarf2_ranges_read): Update.
8010         * dwarf-index-write.c (write_address_map)
8011         (write_one_signatured_type, recursively_write_psymbols)
8012         (class debug_names, class debug_names, write_psymtabs_to_index):
8013         Update.
8014
8015 2019-01-10  Tom Tromey  <tom@tromey.com>
8016
8017         * symtab.h (SYMBOL_SET_NAMES): Update.
8018         (symbol_set_names): Update.
8019         (MSYMBOL_SET_NAMES): Update.
8020         * symtab.c (symbol_set_names): Change argument to be an
8021         objfile_per_bfd_storage.
8022         * psymtab.c (add_psymbol_to_bcache): Update.
8023         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8024
8025 2019-01-10  Tom Tromey  <tom@tromey.com>
8026
8027         * symtab.c (create_demangled_names_hash): Change argument to be an
8028         objfile_per_bfd_storage.
8029         (symbol_set_names): Update.
8030
8031 2019-01-10  Tom Tromey  <tom@tromey.com>
8032
8033         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8034         init_psymbol_list.
8035         * psymtab.c (init_psymbol_list): Do nothing if already called.
8036         * psympriv.h (init_psymbol_list): Add comment.
8037         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8038         init_psymbol_list.
8039         * dbxread.c (dbx_symfile_read): Unconditionally call
8040         init_psymbol_list.
8041
8042 2019-01-10  Tom Tromey  <tom@tromey.com>
8043
8044         * xcoffread.c (scan_xcoff_symtab): Update.
8045         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8046         "where".
8047         * mdebugread.c (parse_partial_symbols)
8048         (handle_psymbol_enumerators): Update.
8049         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8050         * dbxread.c (read_dbx_symtab): Update.
8051         * psympriv.h (psymbol_placement): New enum.
8052         (add_psymbol_to_list): Update.
8053
8054 2019-01-10  Tom Tromey  <tom@tromey.com>
8055
8056         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8057         static_psymbols parameters.
8058         (scan_xcoff_symtab): Update.
8059         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8060         static_psymbols parameters.
8061         * psympriv.h (start_psymtab_common): Update.
8062         * mdebugread.c (parse_partial_symbols): Update.
8063         * dwarf2read.c (create_partial_symtab): Update.
8064         * dbxread.c (read_dbx_symtab): Update.
8065         (start_psymtab): Remove global_psymbols and static_psymbols
8066         parameters.
8067
8068 2019-01-10  Tom Tromey  <tom@tromey.com>
8069
8070         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8071         * psymtab.c (allocate_psymtab): Add comment.
8072         * psympriv.h (allocate_psymtab): Add comment.
8073         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8074         initializations.
8075         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8076
8077 2019-01-10  Tom Tromey  <tom@tromey.com>
8078
8079         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8080         Don't declare.
8081         * mipsread.c: Include mdebugread.h.
8082         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8083         Declare.
8084         * elfread.c: Include mdebugread.h.
8085
8086 2019-01-09  Tom Tromey  <tom@tromey.com>
8087
8088         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8089         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8090         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8091         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8092         (psym_lookup_symbol, psym_find_last_source_symtab)
8093         (psym_forget_cached_source_info, psym_print_stats)
8094         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8095         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8096         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8097         (psym_find_compunit_symtab_by_address)
8098         (maintenance_print_psymbols, maintenance_info_psymtabs)
8099         (maintenance_check_psymtabs): Use ranged for.
8100         * psymtab.h (class objfile_psymtabs): New.
8101         (require_partial_symbols): Return objfile_psymtabs.
8102         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8103
8104 2019-01-09  Tom Tromey  <tom@tromey.com>
8105
8106         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8107         (find_pc_mapped_section, list_overlays_command)
8108         (map_overlay_command, unmap_overlay_command)
8109         (simple_overlay_update): Use all_objfiles.
8110         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8111         * printcmd.c (info_symbol_command): Use all_objfiles.
8112         * objfiles.h (ALL_OBJSECTIONS): Remove.
8113         * maint.c (maintenance_translate_address): Use all_objfiles.
8114         * gcore.c (gcore_create_callback): Use all_objfiles.
8115         (objfile_find_memory_regions): Likewise.
8116
8117 2019-01-09  Tom Tromey  <tom@tromey.com>
8118
8119         * symtab.c (find_line_symtab, info_sources_command)
8120         (make_source_files_completion_list): Use objfile_compunits.
8121         * source.c (select_source_symtab): Use objfile_compunits.
8122         * objfiles.h (struct objfile): Update comment.
8123         (ALL_OBJFILES): Remove.
8124         (ALL_FILETABS): Remove.
8125         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8126         objfile_compunits.
8127
8128 2019-01-09  Tom Tromey  <tom@tromey.com>
8129
8130         * symmisc.c (print_objfile_statistics, dump_objfile)
8131         (maintenance_print_symbols): Use compunit_filetabs.
8132         * source.c (forget_cached_source_info_for_objfile): Use
8133         compunit_filetabs.
8134         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8135         (ALL_FILETABS): Use compunit_filetabs.
8136         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8137         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8138
8139 2019-01-09  Tom Tromey  <tom@tromey.com>
8140
8141         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8142         (compunit_filetabs): New.
8143         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8144         compunit_filetabs.
8145         (info_sources_command, make_source_files_completion_list): Remove
8146         declaration.
8147         * symmisc.c (print_objfile_statistics, dump_objfile)
8148         (maintenance_print_symbols): Remove declaration.
8149         (maintenance_info_symtabs): Use compunit_filetabs.
8150         (maintenance_info_line_tables): Likewise.
8151         * source.c (select_source_symtab): Change local variable name.
8152         (forget_cached_source_info_for_objfile): Remove declaration.
8153         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8154         * objfiles.c (objfile_relocate1): Remove declaration.
8155         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8156         declaration.
8157         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8158         * coffread.c (coff_symtab_read): Remove declaration.
8159         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8160         compunit_filetabs.
8161
8162 2019-01-09  Tom Tromey  <tom@tromey.com>
8163
8164         * symtab.c (lookup_objfile_from_block)
8165         (find_pc_sect_compunit_symtab, search_symbols)
8166         (default_collect_symbol_completion_matches_break_on): Use
8167         objfile_compunits.
8168         * objfiles.h (ALL_COMPUNITS): Remove.
8169         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8170         * cp-support.c (add_symbol_overload_list_qualified): Use
8171         objfile_compunits.
8172         * ada-lang.c (ada_collect_symbol_completion_matches)
8173         (ada_add_global_exceptions): Use objfile_compunits.
8174
8175 2019-01-09  Tom Tromey  <tom@tromey.com>
8176
8177         * source.c (select_source_symtab)
8178         (forget_cached_source_info_for_objfile): Remove declaration.
8179         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8180         declaration.
8181         * maint.c (count_symtabs_and_blocks): Remove declaration.
8182         * cp-support.c (add_symbol_overload_list_qualified): Remove
8183         declaration.
8184         * coffread.c (coff_symtab_read): Remove declaration.
8185         * symtab.c (lookup_symbol_in_objfile_symtabs)
8186         (basic_lookup_transparent_type_1): Use objfile_compunits.
8187         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8188         (info_sources_command, search_symbols)
8189         (default_collect_symbol_completion_matches_break_on)
8190         (make_source_files_completion_list): Remove declaration.
8191         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8192         (ada_collect_symbol_completion_matches)
8193         (ada_add_global_exceptions): Remove declaration.
8194         * linespec.c (iterate_over_all_matching_symtabs): Use
8195         objfile_compunits.
8196         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8197         (class objfile_compunits): New.
8198         (ALL_COMPUNITS): Use objfile_compunits.
8199         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8200         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8201         objfile_compunits.
8202         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8203
8204 2019-01-09  Tom Tromey  <tom@tromey.com>
8205
8206         * symtab.c (search_symbols)
8207         (default_collect_symbol_completion_matches_break_on): Use
8208         objfile_msymbols.
8209         * ada-lang.c (ada_lookup_simple_minsym)
8210         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8211         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8212         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8213         objfile_msymbols.
8214         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8215         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8216         * objc-lang.c (find_methods): Use objfile_msymbols.
8217         (info_selectors_command, info_classes_command): Likewise.
8218         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8219         * objfiles.h (class objfile_msymbols): New.
8220         (ALL_OBJFILE_MSYMBOLS): Remove.
8221         (ALL_MSYMBOLS): Remove.
8222
8223 2019-01-09  Tom Tromey  <tom@tromey.com>
8224
8225         * common/next-iterator.h (next_adapter): Add Iterator template
8226         parameter.
8227         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8228         (class all_objfiles_safe): New.
8229         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8230         * objfiles.c (put_objfile_before): Update comment.
8231         (add_separate_debug_objfile): Likewise.
8232         (free_all_objfiles): Use all_objfiles_safe.
8233         (objfile_purge_solibs): Likewise.
8234
8235 2019-01-09  Tom Tromey  <tom@tromey.com>
8236
8237         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8238         (expand_symtab_containing_pc, lookup_static_symbol)
8239         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8240         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8241         all_objfiles.
8242         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8243         * breakpoint.c (create_overlay_event_breakpoint)
8244         (create_longjmp_master_breakpoint)
8245         (create_std_terminate_master_breakpoint)
8246         (create_exception_master_breakpoint): Use all_objfiles.
8247         * linux-thread-db.c (try_thread_db_load_from_pdir)
8248         (has_libpthread): Use all_objfiles.
8249         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8250         * linespec.c (iterate_over_all_matching_symtabs)
8251         (search_minsyms_for_name): Use all_objfiles.
8252         * maint.c (maintenance_info_sections): Use all_objfiles.
8253         * main.c (captured_main_1): Use all_objfiles.
8254         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8255         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8256         * guile/scm-pretty-print.c
8257         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8258         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8259         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8260         (maintenance_print_msymbols): Use all_objfiles.
8261         * source.c (select_source_symtab): Use all_objfiles.
8262         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8263         * symfile.c (remove_symbol_file_command)
8264         (expand_symtabs_matching, map_symbol_filenames): Use
8265         all_objfiles.
8266         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8267         all_objfiles.
8268         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8269         * objc-lang.c (find_methods): Use all_objfiles.
8270         * objfiles.c (have_partial_symbols, have_full_symbols)
8271         (have_minimal_symbols, qsort_cmp)
8272         (default_iterate_over_objfiles_in_search_order): Use
8273         all_objfiles.
8274         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8275         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8276         (maintenance_check_psymtabs): Use all_objfiles.
8277         (ALL_PSYMTABS): Remove.
8278         * compile/compile-object-run.c (do_module_cleanup): Use
8279         all_objfiles.
8280         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8281         * cp-support.c (add_symbol_overload_list_qualified): Use
8282         all_objfiles.
8283         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8284         Use all_objfiles.
8285         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8286         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8287         all_objfiles.
8288         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8289         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8290         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8291         Uses all_objfiles.
8292         * solib.c (solib_read_symbols): Use all_objfiles
8293
8294 2019-01-09  Tom Tromey  <tom@tromey.com>
8295
8296         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8297         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8298         all_objfiles.
8299         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8300         * symmisc.c (print_symbol_bcache_statistics)
8301         (print_objfile_statistics, maintenance_print_objfiles)
8302         (maintenance_info_symtabs, maintenance_check_symtabs)
8303         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8304         all_objfiles.
8305         * source.c (forget_cached_source_info): Use all_objfiles.
8306         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8307         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8308         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8309         * objfiles.c (update_section_map): Use all_objfiles.
8310         (shared_objfile_contains_address_p): Likewise.
8311         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8312         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8313
8314 2019-01-09  Tom Tromey  <tom@tromey.com>
8315
8316         * common/next-iterator.h: New file.
8317         * objfiles.h (class all_objfiles): New.
8318         (struct objfile_iterator): New.
8319
8320 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8321
8322         * NEWS: Move the description of the changed "frame", "select-frame",
8323          and "info frame" commands to the Changed commands section.
8324
8325 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8326
8327         * gdbtypes.c (check_stub_method_group): Remove handling of old
8328         mangling schemes.
8329         * linespec.c (find_methods): Likewise.
8330         * stabsread.c (read_member_functions): Likewise.
8331         * valops.c (search_struct_method): Likewise.
8332         (value_struct_elt_for_reference): Likewise.
8333         * NEWS: Mention this change.
8334
8335 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8336
8337         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8338         print_source_lines.
8339         * source.c (print_source_lines_base): Update line number check.
8340         (print_source_lines): New function.
8341         (source_lines_range::source_lines_range): New function.
8342         * source.h (class source_lines_range): New class.
8343         (print_source_lines): New declaration.
8344
8345 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8346
8347         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8348
8349 2019-01-08  Tom Tromey  <tom@tromey.com>
8350             Simon Marchi  <simon.marchi@ericsson.com>
8351
8352         PR gdb/24060
8353         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8354         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8355         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8356         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8357         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8358         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8359
8360 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8361
8362         * source.c (select_source_symtab): Move header comment to
8363         declaration in source.h.
8364         (forget_cached_source_info_for_objfile): Likewise.
8365         (forget_cached_source_info): Likewise.
8366         (identify_source_line): Likewise.
8367         * source.h (identify_source_line): Move declaration from symtab.h
8368         and add comment from source.c
8369         (print_source_lines): Likewise.
8370         (forget_cached_source_info_for_objfile): Likewise.
8371         (forget_cached_source_info): Likewise.
8372         (select_source_symtab): Likewise.
8373         (enum print_source_lines_flag): Move definition from symtab.h.
8374         * symtab.h (identify_source_line): Move declaration to source.h.
8375         (print_source_lines): Likewise.
8376         (forget_cached_source_info_for_objfile): Likewise.
8377         (forget_cached_source_info): Likewise.
8378         (select_source_symtab): Likewise.
8379         (enum print_source_lines_flag): Move definition to source.h.
8380         * tui/tui-hooks.c: Add 'source.h' include.
8381
8382 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8383
8384         * source.c (print_source_lines_base): Handle requests to print
8385         reverse line number sequences, and guard against empty lines
8386         string.
8387
8388 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8389
8390         * source.c (print_source_lines_base): Fix skip of '\r' if next
8391         character is '\n'.
8392
8393 2019-01-06  Tom Tromey  <tom@tromey.com>
8394
8395         * c-exp.y (struct c_parse_state) <macro_original_text,
8396         expansion_obstack>: New member.
8397         (macro_original_text, expansion_obstack): Remove globals.
8398         (scan_macro_expansion, scanning_macro_expansion)
8399         (finished_macro_expansion): Update.
8400         (scan_macro_cleanup): Remove.
8401         (yylex, c_parse): Update.
8402
8403 2019-01-06  Tom Tromey  <tom@tromey.com>
8404
8405         * c-exp.y (struct c_parse_state) <strings>: New member.
8406         (operator_stoken): Update.
8407
8408 2019-01-06  Tom Tromey  <tom@tromey.com>
8409
8410         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8411         (union type_stack_elt) <typelist_val>: Now a pointer to
8412         std::vector.
8413         (type_stack_cleanup): Don't declare.
8414         (push_typelist): Update.
8415         * parse.c (pop_typelist): Return a std::vector.
8416         (push_typelist): Take a std::vector.
8417         (follow_types): Update.  Do not free args.
8418         (type_stack_cleanup): Remove.
8419         * c-exp.y (struct c_parse_state): New.
8420         (cpstate): New global.
8421         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8422         (nonempty_typelist): Update.
8423         (func_mod): Create a new vector.
8424         (c_parse): Create a c_parse_state.
8425         (check_parameter_typelist): Do not delete params.
8426         (function_method): Update.  Do not delete type_list.
8427
8428 2019-01-06  Tom Tromey  <tom@tromey.com>
8429
8430         PR gdb/28155:
8431         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8432         check_typedef.
8433         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8434         (print_return_value): Likewise.
8435
8436 2019-01-05  Tom Tromey  <tom@tromey.com>
8437
8438         * contrib/cleanup_check.py: Remove.
8439         * contrib/gcc-with-excheck: Remove.
8440         * contrib/exsummary.py: Remove.
8441         * contrib/excheck.py: Remove.
8442
8443 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8444
8445         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8446         NULL. Initialize tpprev to NULL instead of assigning it
8447         to NULL on the next statement.
8448         * windows-nat.c (windows_delete_thread): Remove check for
8449         main_thread_id before printing thread exit notifications.
8450         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8451         Remove thread ID check against main_thread_id.
8452         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8453         windows_delete_thread.
8454         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8455
8456 2019-01-04  Tom Tromey  <tom@tromey.com>
8457
8458         * compile/compile.c (_initialize_compile): Use upper case for
8459         metasyntactic variables.
8460         * symmisc.c (_initialize_symmisc): Use upper case for
8461         metasyntactic variables.
8462         * psymtab.c (_initialize_psymtab): Use upper case for
8463         metasyntactic variables.
8464         * demangle.c (demangle_command): Use upper case for metasyntactic
8465         variables.
8466         (_initialize_demangler): Likewise.
8467         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8468         variables.
8469
8470 2019-01-03  Tom Tromey  <tom@tromey.com>
8471
8472         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8473
8474 2019-01-03  Tom Tromey  <tom@tromey.com>
8475
8476         * python/py-symtab.c (salpy_str): Update.
8477         (struct salpy_sal_object) <symtab>: Now a PyObject.
8478         (salpy_dealloc): Update.
8479         (del_objfile_sal): Use gdbpy_ref.
8480
8481 2019-01-03  Tom Tromey  <tom@tromey.com>
8482
8483         * python/py-type.c (convert_field): Use new_reference.  Return
8484         gdbpy_ref.
8485         (make_fielditem): Return gdbpy_ref.
8486         (typy_fields): Update.
8487         (typy_getitem): Update.
8488         (field_name): Return gdbpy_ref.  Use new_reference.
8489         (typy_iterator_iternext): Update.
8490
8491 2019-01-03  Tom Tromey  <tom@tromey.com>
8492
8493         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8494
8495 2019-01-03  Tom Tromey  <tom@tromey.com>
8496
8497         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8498         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8499         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8500         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8501         (pspy_set_type_printers): Likewise.
8502         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8503         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8504         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8505         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8506         (objfpy_set_type_printers): Likewise.
8507
8508 2019-01-03  Tom Tromey  <tom@tromey.com>
8509
8510         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8511         (gdbpy_print_stack): Use gdbpy_err_fetch.
8512         * python/python-internal.h (class gdbpy_err_fetch): New class.
8513         (class gdbpy_enter) <m_error_type, m_error_value,
8514         m_error_traceback>: Remove.
8515         <m_error>: New member.
8516         (gdbpy_exception_to_string): Don't declare.
8517         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8518         * python/py-value.c (convert_value_from_python): Use
8519         gdbpy_err_fetch.
8520         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8521         gdbpy_exception_to_string.
8522         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8523         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8524         gdbpy_err_fetch.
8525
8526 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8527
8528         * linux-nat.c (delete_lwp_cleanup): Delete.
8529         (struct lwp_deleter): New struct.
8530         (lwp_info_up): New typedef.
8531         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8532         lwp_info_up.
8533
8534 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8535
8536         * linux-fork.c (class scoped_switch_fork_info): New class.
8537         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8538
8539 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8540
8541         * valops.c (find_overload_match): Remove use of null_cleanup, and
8542         calls to do_cleanups.
8543
8544 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8545
8546         * compile/compile-cplus-types.c
8547         (compile_cplus_instance::decl_name): Handle changes to
8548         cp_func_name.
8549         * cp-support.c (cp_func_name): Update header comment, update
8550         return type.
8551         * cp-support.h (cp_func_name): Update return type in declaration.
8552         * valops.c (find_overload_match): Move temp_func local to top
8553         level of function and change its type.  Use temp_func to hold and
8554         delete temporary string obtained from cp_func_name.
8555
8556 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8557
8558         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8559         gdb::char_vector, remove cleanup, and update uses of `msg`.
8560
8561 2019-01-03  Jim Wilson  <jimw@sifive.com>
8562
8563         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8564
8565 2019-01-02  Tom Tromey  <tom@tromey.com>
8566
8567         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8568         (tdesc_parse_xml): Remove cleanups.
8569         * target-descriptions.h (make_cleanup_free_target_description):
8570         Don't declare.
8571         (target_desc_deleter): New struct.
8572         (target_desc_up): New typedef.
8573         * target-descriptions.c (target_desc_deleter::operator()): Rename
8574         from free_target_description.
8575         (make_cleanup_free_target_description): Remove.
8576
8577 2019-01-02  Tom Tromey  <tom@tromey.com>
8578
8579         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8580         constructor, destructor.
8581         (linespec_parser): Remove typedef.
8582         (~linespec_parser): Rename from linespec_parser_delete.
8583         (linespec_lex_to_end, linespec_complete_label)
8584         (linespec_complete): Update.
8585         (decode_line_full): Remove cleanups.
8586         (decode_line_1): Update.
8587
8588 2019-01-02  Tom Tromey  <tom@tromey.com>
8589
8590         * python/python-internal.h (inferior_to_inferior_object): Change
8591         return type.
8592         * python/py-exitedevent.c (create_exited_event_object): Update.
8593         * python/py-inferior.c (inferior_to_inferior_object): Return
8594         gdbpy_ref.
8595         (python_new_inferior, python_inferior_deleted)
8596         (thread_to_thread_object, delete_thread_object)
8597         (build_inferior_list, gdbpy_selected_inferior): Update.
8598         * python/py-infthread.c (create_thread_object): Update.  Also fail
8599         if inferior_to_inferior_object fails.
8600
8601 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8602
8603         * inferior.h (class inferior) <displaced_step_state>: New field.
8604         * infrun.h (struct displaced_step_state): Move here from
8605         infrun.c.  Initialize fields, add constructor.
8606         <inf>: Remove field.
8607         <reset>: New method.
8608         * infrun.c (struct displaced_step_inferior_state): Move to
8609         infrun.h.
8610         (displaced_step_inferior_states): Remove.
8611         (get_displaced_stepping_state): Adust.
8612         (displaced_step_in_progress_any_inferior): Adjust.
8613         (displaced_step_in_progress_thread): Adjust.
8614         (displaced_step_in_progress): Adjust.
8615         (add_displaced_stepping_state): Remove.
8616         (get_displaced_step_closure_by_addr): Adjust.
8617         (remove_displaced_stepping_state): Remove.
8618         (infrun_inferior_exit): Call displaced_step_state.reset.
8619         (use_displaced_stepping): Don't check for NULL.
8620         (displaced_step_prepare_throw): Call
8621         get_displaced_stepping_state.
8622         (displaced_step_fixup): Don't check for NULL.
8623         (prepare_for_detach): Don't check for NULL.
8624
8625 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8626
8627         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8628          in case of call that did not complete.
8629
8630 2019-01-02  Andrey Utkin  <autkin@undo.io>
8631
8632         * symfile.c (find_separate_debug_file): Fix search of debug files for
8633         remote debuggee.
8634
8635 2019-01-02  Tom Tromey  <tom@tromey.com>
8636
8637         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8638         indentation.
8639         * python/py-frame.c (frapy_older): Remove cast.
8640         (frapy_newer): Likewise.
8641         * python/py-breakpoint.c (local_setattro): Remove cast.
8642         * python/py-arch.c (archpy_name): Remove local variable.
8643         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8644
8645 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8646
8647         * unittests/basic_string_view/element_access/char/empty.cc:
8648         Fix year range in copyright header.
8649
8650 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8651
8652         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8653         Delete.
8654         <operator==>: Update with for removed field.
8655         <hash>: Likewise.
8656         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8657         <isa_features>: ...this.
8658         <abi_features>: New field.
8659         (riscv_isa_flen): Update comment.
8660         (riscv_abi_xlen): New declaration.
8661         (riscv_abi_flen): New declaration.
8662         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8663         isa_features.
8664         (riscv_abi_xlen): New function.
8665         (riscv_isa_flen): Update to get answer from isa_features.
8666         (riscv_abi_flen): New function.
8667         (riscv_has_fp_abi): Update to get answer from abi_features.
8668         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8669         xlen and flen.
8670         (riscv_call_info) <xlen, flen>: Update comment.
8671         (riscv_call_arg_struct): Remove invalid assertions
8672         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8673         is removed.
8674         (riscv_gdbarch_init): Gather isa features and abi features
8675         separately, ensure both match on the gdbarch when reusing an old
8676         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8677         a target with 64-bit float hardware.
8678
8679 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8680
8681         * source.c (search_command_helper): Stop reverse search
8682         when line 1 has been searched.
8683
8684 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8685
8686         * record-full.c (record_full_base_target::close): Rewrite
8687         record_full_core_buf_list free logic.
8688
8689 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8690
8691         * break-catch-syscall.c (print_one_catch_syscall): xfree
8692         the last text.
8693
8694 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8695
8696         * top.c (print_gdb_version): Update Copyright year in version
8697         message.
8698
8699 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8700
8701         Update copyright year range in all GDB files.
8702
8703 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8704
8705         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8706
8707 For older changes see ChangeLog-2018.
8708 \f
8709 Local Variables:
8710 mode: change-log
8711 left-margin: 8
8712 fill-column: 74
8713 version-control: never
8714 coding: utf-8
8715 End:
8716