gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
   4         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
   5         (_initialize_dwarf2_frame): Update.
   6
   7 2019-05-08  Tom Tromey  <tom@tromey.com>
   8
   9         * objc-lang.c (objc_objfile_data): Change type.
  10         (find_methods): Update.
  11         (_initialize_objc_lang): Remove.
  12
  13 2019-05-08  Tom Tromey  <tom@tromey.com>
  14
  15         * stabsread.c (rs6000_builtin_type_data): Change type.
  16         (rs6000_builtin_type, _initialize_stabsread): Update.
  17
  18 2019-05-08  Tom Tromey  <tom@tromey.com>
  19
  20         * mips-tdep.c (mips_pdr_data): Remove.
  21         (_initialize_mips_tdep): Update.
  22
  23 2019-05-08  Tom Tromey  <tom@tromey.com>
  24
  25         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
  26         (hppa_init_objfile_priv_data, read_unwind_info)
  27         (find_unwind_entry, _initialize_hppa_tdep): Update.
  28
  29 2019-05-08  Tom Tromey  <tom@tromey.com>
  30
  31         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
  32         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
  33         on obstack.
  34         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
  35
  36 2019-05-08  Tom Tromey  <tom@tromey.com>
  37
  38         * mdebugread.c (basic_type_data): Change type.
  39         (basic_type, _initialize_mdebugread): Update.
  40
  41 2019-05-08  Tom Tromey  <tom@tromey.com>
  42
  43         * common/gdb_unique_ptr.h (struct noop_deleter): New.
  44
  45 2019-05-08  Tom Tromey  <tom@tromey.com>
  46
  47         * nto-tdep.c (nto_inferior_data_reg): Change type.
  48         (nto_inferior_data): Update.
  49         (nto_inferior_data_cleanup, nto_new_inferior_data)
  50         (_initialize_nto_tdep): Remove.
  51         * nto-tdep.h (struct nto_inferior_data): Add initializers.
  52
  53 2019-05-08  Tom Tromey  <tom@tromey.com>
  54
  55         * ada-lang.c (struct ada_inferior_data): Add initializers.
  56         (ada_inferior_data): Change type.
  57         (ada_inferior_data_cleanup): Remove.
  58         (get_ada_inferior_data, ada_inferior_exit)
  59         (struct ada_pspace_data): Add initializers, destructor.
  60         (ada_pspace_data_handle): Change type.
  61         (get_ada_pspace_data): Update.
  62         (ada_pspace_data_cleanup): Remove.
  63
  64 2019-05-08  Tom Tromey  <tom@tromey.com>
  65
  66         * coffread.c (struct coff_symfile_info): Add initializers.
  67         (coff_objfile_data_key): Move lower.  Change type.
  68         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  69         Update.
  70         (coff_free_info): Remove.
  71
  72 2019-05-08  Tom Tromey  <tom@tromey.com>
  73
  74         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  75         (fbsd_pspace_data_handle): Move lower.  Change type.
  76         (get_fbsd_pspace_data): Update.
  77         (fbsd_pspace_data_cleanup): Remove.
  78         (_initialize_fbsd_tdep): Update.
  79
  80 2019-05-08  Tom Tromey  <tom@tromey.com>
  81
  82         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  83         (get_ada_tasks_pspace_data): Update.
  84         (ada_tasks_pspace_data_cleanup): Remove.
  85         (_initialize_tasks): Update.
  86         (ada_tasks_inferior_data_handle): Change type.
  87         (get_ada_tasks_inferior_data): Update.
  88         (ada_tasks_inferior_data_cleanup): Remove.
  89         (struct ada_tasks_pspace_data): Add initializers.
  90
  91 2019-05-08  Tom Tromey  <tom@tromey.com>
  92
  93         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  94         * symfile-debug.c (debug_sym_get_probes): Change type.
  95         * stap-probe.c (handle_stap_probe):
  96         (stap_static_probe_ops::get_probes): Change type.
  97         * probe.h (class static_probe_ops) <get_probes>: Change type.
  98         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  99         (parse_probes_in_pspace): Update.
 100         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 101         Update.
 102         (any_static_probe_ops::get_probes): Change type.
 103         * elfread.c (elfread_data): New typedef.
 104         (probe_key): Change type.
 105         (elf_get_probes): Likewise.  Update.
 106         (probe_key_free): Remove.
 107         (_initialize_elfread): Update.
 108         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 109         Change type.
 110         (dtrace_process_dof_probe, dtrace_process_dof)
 111         (dtrace_static_probe_ops::get_probe): Change type.
 112
 113 2019-05-08  Tom Tromey  <tom@tromey.com>
 114
 115         * xcoffread.c (struct xcoff_symfile_info): Rename from
 116         coff_symfile_info.  Add initializers.
 117         (xcoff_objfile_data_key): Move lower.  Change type.
 118         (XCOFF_DATA): Rewrite.
 119         (xcoff_free_info): Remove.
 120         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 121         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 122         (xcoff_initial_scan): Update.
 123
 124 2019-05-08  Tom Tromey  <tom@tromey.com>
 125
 126         * solib-svr4.c (struct svr4_info): Add initializers and
 127         destructor.
 128         <probes_table>: Now an htab_up.
 129         (solib_svr4_pspace_data): Change type.
 130         (free_probes_table): Simplify.
 131         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 132         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 133         (probes_table_remove_objfile_probes, register_solib_event_probe)
 134         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 135         (_initialize_svr4_solib): Update.
 136
 137 2019-05-08  Tom Tromey  <tom@tromey.com>
 138
 139         * remote.c (remote_pspace_data): Change type.
 140         (remote_pspace_data_cleanup): Remove.
 141         (get_remote_exec_file, set_pspace_remote_exec_file)
 142         (_initialize_remote): Update.
 143
 144 2019-05-08  Tom Tromey  <tom@tromey.com>
 145
 146         * breakpoint.c (breakpoint_objfile_key): Change type.
 147         (get_breakpoint_objfile_data): Update.
 148         (free_breakpoint_objfile_data): Remove.
 149         (_initialize_breakpoint): Update.
 150
 151 2019-05-08  Tom Tromey  <tom@tromey.com>
 152
 153         * linux-tdep.c (struct linux_info): Add initializers.
 154         (linux_inferior_data): Move.  Change type.
 155         (invalidate_linux_cache_inf): Update.
 156         (linux_inferior_data_cleanup): Remove.
 157         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 158
 159 2019-05-08  Tom Tromey  <tom@tromey.com>
 160
 161         * auxv.c (auxv_inferior_data): Move.  Change type.
 162         (auxv_inferior_data_cleanup): Remove.
 163         (invalidate_auxv_cache_inf): Rewrite.
 164         (get_auxv_inferior_data, _initialize_auxv): Update.
 165
 166 2019-05-08  Tom Tromey  <tom@tromey.com>
 167
 168         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 169         (symfile_debug_objfile_data_key): Change type.
 170         (symfile_debug_installed, debug_qf_has_symbols)
 171         (debug_qf_find_last_source_symtab)
 172         (debug_qf_forget_cached_source_info)
 173         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 174         (debug_qf_print_stats, debug_qf_dump)
 175         (debug_qf_expand_symtabs_for_function)
 176         (debug_qf_expand_all_symtabs)
 177         (debug_qf_expand_symtabs_with_fullname)
 178         (debug_qf_map_matching_symbols)
 179         (debug_qf_expand_symtabs_matching)
 180         (debug_qf_find_pc_sect_compunit_symtab)
 181         (debug_qf_map_symbol_filenames)
 182         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 183         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 184         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 185         (debug_sym_read_linetable, debug_sym_relocate): Update.
 186         (symfile_debug_free_objfile): Remove.
 187         (install_symfile_debug_logging, _initialize_symfile_debug):
 188         Update.
 189
 190 2019-05-08  Tom Tromey  <tom@tromey.com>
 191
 192         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 193         allocate_on_obstack.
 194         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 195         (get_dwarf2_per_objfile): Update.
 196         (set_dwarf2_per_objfile): Remove.
 197         (dwarf2_has_info, dwarf2_get_section_info): Update.
 198         (dwarf2_free_objfile): Remove.
 199         (_initialize_dwarf2_read): Update.
 200
 201 2019-05-08  Tom Tromey  <tom@tromey.com>
 202
 203         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 204         initializers.
 205         <unsupported_script_warning_printed,
 206         script_not_found_warning_printed>: Now bool.
 207         (auto_load_pspace_data): Change type.
 208         (~auto_load_pspace_info): Rename from
 209         auto_load_pspace_data_cleanup.
 210         (get_auto_load_pspace_data, init_loaded_scripts_info)
 211         (clear_section_scripts, maybe_print_unsupported_script_warning)
 212         (maybe_print_script_not_found_warning, _initialize_auto_load):
 213         Update.
 214
 215 2019-05-08  Tom Tromey  <tom@tromey.com>
 216
 217         * objfiles.c (objfile_pspace_info): Add destructor and
 218         initializers.
 219         (objfiles_pspace_data): Change type.
 220         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 221         (get_objfile_pspace_data): Update.
 222         (objfiles_bfd_data): Change type.
 223         (get_objfile_bfd_data): Update.
 224         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 225
 226 2019-05-08  Tom Tromey  <tom@tromey.com>
 227
 228         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 229         Change type.
 230         (get_catch_syscall_inferior_data): Update.
 231         (catch_syscall_inferior_data_cleanup): Remove.
 232         (_initialize_break_catch_syscall): Update.
 233
 234 2019-05-08  Tom Tromey  <tom@tromey.com>
 235
 236         * inflow.c (struct terminal_info): Add destructor and
 237         initializers.
 238         (inflow_inferior_data): Change type.
 239         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 240         (get_inflow_inferior_data, inflow_inferior_exit)
 241         (swap_terminal_info, _initialize_inflow): Update.
 242
 243 2019-05-08  Tom Tromey  <tom@tromey.com>
 244
 245         * target-dcache.c (target_dcache_cleanup): Remove.
 246         (target_dcache_aspace_key): Change type.
 247         (target_dcache_init_p, target_dcache_invalidate)
 248         (target_dcache_get, target_dcache_get_or_init)
 249         (_initialize_target_dcache): Update.
 250         * dcache.h (struct dcache_deleter): New.
 251
 252 2019-05-08  Tom Tromey  <tom@tromey.com>
 253
 254         * symtab.c (struct symbol_cache): Add destructor and
 255         initializers.
 256         (symbol_cache_key): Move.  Change type.
 257         (make_symbol_cache, free_symbol_cache): Remove.
 258         (get_symbol_cache): Update.
 259         (symbol_cache_cleanup): Remove.
 260         (ALL_PSPACES, symbol_cache_flush)
 261         (maintenance_print_symbol_cache)
 262         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 263         Update.
 264
 265 2019-05-08  Tom Tromey  <tom@tromey.com>
 266
 267         * symtab.c (struct main_info): Add destructor and initializers.
 268         (main_progspace_key): Move.  Change type.
 269         (get_main_info): Update.
 270         (main_info_cleanup): Remove.
 271         (_initialize_symtab): Update.
 272
 273 2019-05-08  Tom Tromey  <tom@tromey.com>
 274
 275         * registry.h (DECLARE_REGISTRY): Define the _key class.
 276
 277 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 278
 279         * NEWS: Merge two 'New commands' sections.
 280
 281 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 282
 283         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 284         parameter and use Ada language definition instead.
 285         (ada_val_print_ptr): Remove unused language parameter.
 286         (ada_val_print_num): Remove language parameter and use Ada language
 287         definition instead.
 288         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 289         parameter.
 290         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 291         parameter and use Ada language definition instead.
 292         (ada_val_print_1): Update all ada_val_print_xxx calls.
 293         Remove language parameter.
 294         (ada_val_print): Update ada_val_print_1 call.
 295
 296 2019-05-08  Tom Tromey  <tromey@adacore.com>
 297
 298         * remote.c (remote_hw_watchpoint_limit)
 299         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 300         Now static.
 301
 302 2019-05-08  Tom Tromey  <tromey@adacore.com>
 303
 304         * maint.c (_initialize_maint_cmds): Move initialization code to
 305         remote.c.
 306         (watchdog, show_watchdog): Move to remote.c.
 307         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 308         "watchdog" static.
 309         (_initialize_remote): Move initialization code from maint.c.
 310         * defs.h (watchdog): Don't declare.
 311
 312 2019-05-08  Tom Tromey  <tromey@adacore.com>
 313
 314         * tui/tui-interp.c: Include main.h.
 315         * interps.c: Include main.h.
 316         * main.h (interpreter_p): Declare.
 317         * defs.h (interpreter_p): Don't declare.
 318
 319 2019-05-08  Tom Tromey  <tromey@adacore.com>
 320
 321         * dwarf2loc.c: Include dwarf2read.h.
 322         * defs.h (read_unsigned_leb128): Don't declare.
 323         * dwarf2read.h (read_unsigned_leb128): Declare.
 324
 325 2019-05-08  Tom Tromey  <tromey@adacore.com>
 326
 327         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 328         method.
 329
 330 2019-05-08  Tom Tromey  <tromey@adacore.com>
 331
 332         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 333         when no wrap column is set.
 334
 335 2019-05-08  Tom Tromey  <tromey@adacore.com>
 336
 337         * c-lang.c (c_get_string): Handle non-C-style arrays.
 338
 339 2019-05-08  Tom Tromey  <tromey@adacore.com>
 340
 341         * typeprint.c (print_offset_data::update): Print the bit offset,
 342         not the number of bits remaining.
 343
 344 2019-05-08  Tom Tromey  <tromey@adacore.com>
 345
 346         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 347         padding at end of comment.
 348
 349 2019-05-08  Tom Tromey  <tromey@adacore.com>
 350
 351         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 352         Compare main types.
 353
 354 2019-05-06  Tom Tromey  <tom@tromey.com>
 355
 356         * common/scoped_mmap.c: Include common-defs.h.
 357         * common/scoped_mmap.h: Don't include config.h.
 358
 359 2019-05-04  Tom Tromey  <tom@tromey.com>
 360
 361         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 362         (struct aarch64_call_info): Add initializers.
 363         <si>: Now a std::vector.
 364         (pass_on_stack, aarch64_push_dummy_call): Update.
 365
 366 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 367             Tom Tromey  <tom@tromey.com>
 368
 369         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 370         (ppc_threads): Now a std::vector.  Now static.
 371         (hwdebug_find_thread_points_by_tid)
 372         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 373         Update.
 374
 375 2019-05-04  Tom Tromey  <tom@tromey.com>
 376
 377         * arc-tdep.c (arc_tdesc_init): Return bool.
 378
 379 2019-05-04  Tom Tromey  <tom@tromey.com>
 380
 381         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 382         Use gdb_assert_not_reached.
 383
 384 2019-05-04  Tom Tromey  <tom@tromey.com>
 385
 386         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 387         "false".
 388
 389 2019-05-04  Tom Tromey  <tom@tromey.com>
 390
 391         * arc-tdep.c (arc_tdesc_init): Use bool.
 392
 393 2019-05-04  Tom Tromey  <tom@tromey.com>
 394
 395         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 396
 397 2019-05-04  Tom Tromey  <tom@tromey.com>
 398
 399         * cli/cli-cmds.c (valid_command_p): Return bool.
 400
 401 2019-05-04  Tom Tromey  <tom@tromey.com>
 402
 403         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 404         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 405
 406 2019-05-04  Raul Tambre  <raul@tambre.ee>
 407
 408         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 409         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 410         operator for comparison.
 411
 412 2019-05-04  Tom Tromey  <tom@tromey.com>
 413
 414         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 415         (lookup_partial_symbol, print_partial_symbols)
 416         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 417         (psymbol_compare): Update.
 418         (add_psymbol_to_bcache): Clear the entire psymbol.
 419         (maintenance_check_psymtabs): Update.
 420         * psympriv.h (struct partial_symbol): Don't derive from
 421         general_symbol_info.
 422         <obj_section, unrelocated_address, address,
 423         set_unrelocated_address>: Update.
 424         <ginfo>: New member.
 425         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 426         (debug_names::write_psymbols): Update.
 427
 428 2019-05-04  Tom de Vries  <tdevries@suse.de>
 429
 430         * contrib/cc-with-tweaks.sh: Support -n arg.
 431
 432 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 433
 434         * corelow.c (core_target::detach): Ensure frame cache and
 435         register caches are cleared.
 436         inferior.c (exit_inferior_1): Likewise.
 437
 438 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 439             Tom Tromey  <tom@tromey.com>
 440
 441         * dictionary.c (collate_pending_symbols_by_language): Remove
 442         "struct" from foreach.
 443         * symtab.c (lookup_global_symbol_from_objfile)
 444         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 445         foreach.
 446         * ser-tcp.c (net_open): Remove "struct" from foreach.
 447         * objfiles.c (objfile_relocate, objfile_rebase)
 448         (objfile_has_symbols): Remove "struct" from foreach.
 449         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 450         from foreach.
 451         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 452         foreach.
 453         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 454         "struct" from foreach.
 455         * ada-lang.c (create_excep_cond_exprs)
 456         (ada_exception_catchpoint_cond_string): Remove "struct" from
 457         foreach.
 458
 459 2019-05-03  Tom Tromey  <tromey@adacore.com>
 460
 461         * ada-exp.y (convert_char_literal): Check suffix of each
 462         enumerator.
 463
 464 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 465
 466         PR ada/21406:
 467         * ada-exp.y (yywrap): Don't define.
 468         * ada-lex.l (%option): Add noyywrap
 469         (yywrap): Remove.
 470
 471 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 472
 473         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 474         _WIN32_WINNT to the XP level, unless already defined to a higher
 475         level.
 476
 477         * unittests/parse-connection-spec-selftests.c:
 478         * ser-tcp.c:
 479         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 480         override.
 481
 482         * symfile.c (find_separate_debug_file): Remove colon from the
 483         drive spec of DOS/Windows file names of the target, so that the
 484         file name produced from DEBUGDIR and the target's directory will
 485         be valid on DOS/Windows systems.
 486
 487 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 488
 489         * rust-lang.c (val_print_struct): Handle printing structures
 490         containing strings.
 491
 492 2019-05-02  Tom Tromey  <tromey@adacore.com>
 493
 494         * valarith.c (_initialize_valarith): Remove.
 495
 496 2019-05-01  Tom Tromey  <tromey@adacore.com>
 497
 498         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 499         bitfields.
 500
 501 2019-05-01  Tom Tromey  <tromey@adacore.com>
 502
 503         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 504         for big-endian copies.
 505
 506 2019-04-30  Ali Tamur  <tamur@google.com>
 507         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 508         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 509         (read_3_bytes): New function.
 510
 511 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 512
 513         * windows-nat.c (main_thread_id): Delete.
 514         (handle_output_debug_string): Replace main_thread_id by
 515         current_event.dwThreadId.
 516         (fake_create_process): Likewise.
 517         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 518         Do not set main_thread_id.
 519         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 520         current_event.dwThreadId.
 521         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 522
 523 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 524
 525         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 526         Use current_event.dwThreadId instead of main_thread_id.
 527
 528 2019-04-30  Tom Tromey  <tromey@adacore.com>
 529
 530         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 531         (create_excep_cond_exprs): Iterate over program spaces.
 532         (ada_exception_catchpoint_cond_string): Examine all minimal
 533         symbols for exception types.
 534
 535 2019-04-30  Tom Tromey  <tromey@adacore.com>
 536
 537         PR c++/24470:
 538         * dwarf2read.c (process_structure_scope): Handle case where type
 539         has template parameters but no symbol was created.
 540
 541 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 542             Chris January  <chris.january@arm.com>
 543
 544         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 545         qualifier.
 546         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 547
 548 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * f-typeprint.c (f_print_type): Update rules for printing
 551         whitespace.
 552         (f_type_print_varspec_suffix): Likewise.
 553
 554 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 555             Chris January  <chris.january@arm.com>
 556
 557         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 558         function arguments.
 559
 560 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * f-lang.c (build_fortran_types): Change name of void type to
 563         lower case.
 564         * f-typeprint.c (f_type_print_base): Print the name of the void
 565         type, rather than a fixed string.
 566         * f-valprint.c (f_decorations): Use lower case void string.
 567
 568 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 569             Chris January  <chris.january@arm.com>
 570
 571         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 572         types for Fortran.
 573
 574 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 575             Chris January  <chris.january@arm.com>
 576             David Lecomber  <david.lecomber@arm.com>
 577
 578         * f-exp.y (BINOP_INTRINSIC): New token.
 579         (exp): New parser rule handling BINOP_INTRINSIC.
 580         (f77_keywords): Add new builtin procedures.
 581         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 582         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 583         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 584         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 585         (print_unop_subexp_f): New function.
 586         (print_binop_subexp_f): New function.
 587         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 588         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 589         (dump_subexp_body_f): Likewise.
 590         (operator_check_f): Likewise.
 591         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 592         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 593
 594 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 595
 596         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 597         UNOP_KIND.
 598         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 599         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 600         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 601         (operator_length_f): New fuction.
 602         (print_subexp_f): New function.
 603         (op_name_f): New function.
 604         (dump_subexp_body_f): New function.
 605         (operator_check_f): New function.
 606         (exp_descriptor_f): Replace standard expression handling functions
 607         with new functions.
 608         * gdb/fortran-operator.def: New file.
 609         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 610         * gdb/std-operator.def: Remove UNOP_KIND.
 611
 612 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 613
 614         * std-operator.def: Remove unbalanced, stray double quote
 615         character.
 616
 617 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 618             Chris January  <chris.january@arm.com>
 619             Daniel Everett  <daniel.everett@arm.com>
 620             Nick Forrington  <nick.forrington@arm.com>
 621             Richard Bunt  <richard.bunt@arm.com>
 622
 623         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 624         of depth when printing anonymous structs or unions.
 625         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 626         Don't print either the top-level value, or the children if the
 627         max-depth is exceeded.
 628         (ppscm_print_children): When printing the key of a map, allow one
 629         extra level of depth.
 630         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 631         print either the top-level value, or the children if the max-depth
 632         is exceeded.
 633         (print_children): When printing the key of a map, allow one extra
 634         level of depth.
 635         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 636         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 637         (user_print_options): Initialise max_depth field.
 638         (val_print_scalar_or_string_type_p): New function.
 639         (val_print): Check to see if the max depth has been reached.
 640         (val_print_check_max_depth): Define new function.
 641         (show_print_max_depth): New function.
 642         (_initialize_valprint): Add 'print max-depth' option.
 643         * valprint.h (struct value_print_options) <max_depth>: New field.
 644         (val_print_check_max_depth): Declare new function.
 645         * NEWS: Document new feature.
 646
 647 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 648
 649         * ada-lang.c (ada_language_defn): Initialise new field.
 650         * c-lang.c (c_is_string_type_p): New function.
 651         (c_language_defn): Initialise new field.
 652         (cplus_language_defn): Initialise new field.
 653         (asm_language_defn): Initialise new field.
 654         (minimal_language_defn): Initialise new field.
 655         * c-lang.h (c_is_string_type_p): Declare new function.
 656         * d-lang.c (d_language_defn): Initialise new field.
 657         * f-lang.c (f_is_string_type_p): New function.
 658         (f_language_defn): Initialise new field.
 659         * go-lang.c (go_is_string_type_p): New function.
 660         (go_language_defn): Initialise new field.
 661         * language.c (default_is_string_type_p): New function.
 662         (unknown_language_defn): Initialise new field.
 663         (auto_language_defn): Initialise new field.
 664         * language.h (struct language_defn) <la_is_string_type_p>: New
 665         member variable.
 666         (default_is_string_type_p): Declare new function.
 667         * m2-lang.c (m2_language_defn): Initialise new field.
 668         * objc-lang.c (objc_language_defn): Initialise new field.
 669         * opencl-lang.c (opencl_language_defn): Initialise new field.
 670         * p-lang.c (pascal_is_string_type_p): New function.
 671         (pascal_language_defn): Initialise new field.
 672         * rust-lang.c (rust_is_string_type_p): New function.
 673         (rust_language_defn): Initialise new field.
 674
 675 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 676
 677         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 678         New field.
 679         * ada-lang.c (ada_language_defn): Initialise new field.
 680         * c-lang.c (c_language_defn): Likewise.
 681         (cplus_language_defn): Likewise.
 682         (asm_language_defn): Likewise.
 683         (minimal_language_defn): Likewise.
 684         * d-lang.c (d_language_defn): Likewise.
 685         * f-lang.c (f_language_defn): Likewise.
 686         * go-lang.c (go_language_defn): Likewise.
 687         * language.c (unknown_language_defn): Likewise.
 688         (auto_language_defn): Likewise.
 689         * m2-lang.c (m2_language_defn): Likewise.
 690         * objc-lang.c (objc_language_defn): Likewise.
 691         * opencl-lang.c (opencl_language_defn): Likewise.
 692         * p-lang.c (pascal_language_defn): Likewise.
 693         * rust-lang.c (rust_language_defn): Likewise.
 694
 695 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * ada-lang.c (ada_is_character_type): Change return type to bool.
 698         (ada_is_string_type): Likewise.
 699         * ada-lang.h (ada_is_character_type): Update declaration
 700         (ada_is_string_type): Likewise.
 701
 702 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 703
 704         Support style in 'frame|thread apply'
 705
 706         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 707         * record.c (record_start, record_stop): Update callers of
 708         execute_command_to_string with false.
 709         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 710         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 711         methods.
 712         (class string_file): New constructor with term_out parameter.
 713         Override methods term_out and can_emit_style_escape.  New member
 714         term_out.
 715         (class stdio_file): Override can_emit_style_escape.
 716         (class tee_file): Override term_out and can_emit_style_escape.
 717         * utils.h (can_emit_style_escape): Remove.
 718         * utils.c (can_emit_style_escape): Likewise.
 719         Update all callers of can_emit_style_escape (SOMESTREAM) to
 720         SOMESTREAM->can_emit_style_escape.
 721         * source-cache.c (source_cache::get_source_lines): Likewise.
 722         * stack.c (frame_apply_command_count): Call execute_command_to_string
 723         passing the term_out characteristic of the current gdb_stdout.
 724         * thread.c (thr_try_catch_cmd): Likewise.
 725         * top.c (execute_command_to_string): pass term_out parameter
 726         to construct the string_file for the command output.
 727         * ui-file.c (term_cli_styling): New function (most code moved
 728         from utils.c can_emit_style_escape).
 729         (string_file::string_file, string_file::can_emit_style_escape,
 730         stdio_file::can_emit_style_escape, tee_file::term_out,
 731         tee_file::can_emit_style_escape): New functions.
 732
 733 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 734
 735         * NEWS: Mention the new set|show may-call-functions.
 736         * infcall.c (may_call_functions_p): New variable.
 737         (show_may_call_functions_p): New function.
 738         (call_function_by_hand_dummy): Throws an error if not
 739         may-call-functions.
 740         (_initialize_infcall): Call add_setshow_boolean_cmd for
 741         may-call-functions.
 742
 743 2019-04-25  Keith Seitz  <keiths@redhat.com>
 744
 745         PR c++/24367
 746         * cp-support.c (inspect_type): Don't attempt substitutions
 747         of symbol with the same name.
 748
 749 2019-04-25  Tom Tromey  <tromey@adacore.com>
 750
 751         PR gdb/24475:
 752         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 753         static.
 754
 755 2019-04-25  Tom Tromey  <tromey@adacore.com>
 756
 757         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 758         rvalue reference.
 759         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 760         (gdb_xml_parser::parse): Use std::move.
 761         * python/python-internal.h (gdbpy_convert_exception): Take a const
 762         reference.
 763         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 764         std::move.
 765         * python/py-utils.c (gdbpy_convert_exception): Take a const
 766         reference.
 767         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 768         Use std::move.
 769         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 770         Use std::move.
 771         * mi/mi-main.c (mi_print_exception): Take a const reference.
 772         * main.c (handle_command_errors): Take a const reference.
 773         * linespec.c (parse_linespec): Use std::move.
 774         * infcall.c (run_inferior_call): Use std::move.
 775         (call_function_by_hand_dummy): Use std::move.
 776         * exec.c (try_open_exec_file): Use std::move.
 777         * exceptions.h (exception_print, exception_fprintf)
 778         (exception_print_same): Update.
 779         * exceptions.c (print_exception, exception_print)
 780         (exception_fprintf, exception_print_same): Change parameters to
 781         const reference.
 782         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 783         * common/new-op.c: Use std::move.
 784         * common/common-exceptions.h (struct gdb_exception): Add move
 785         constructor.
 786         (struct gdb_exception_error, struct gdb_exception_quit, struct
 787         gdb_quit_bad_alloc): Change constructor to move constructor.
 788         (throw_exception): Change parameter to rvalue reference.
 789         * common/common-exceptions.c (throw_exception): Take rvalue
 790         reference.
 791         * cli/cli-interp.c (safe_execute_command): Use std::move.
 792         * breakpoint.c (insert_bp_location, location_to_sals): Use
 793         std::move.
 794
 795 2019-04-25  Tom Tromey  <tromey@adacore.com>
 796
 797         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 798         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 799         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 800         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 801         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 802         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 803         guile/scm-value.c: Use unpack.
 804         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 805         gdbscm_gdb_exception.
 806         (gdbscm_throw_gdb_exception): Likewise.
 807         (struct gdbscm_gdb_exception): New.
 808         (unpack): New function.
 809         (gdbscm_wrap): Use unpack.
 810
 811 2019-04-25  Tom Tromey  <tromey@adacore.com>
 812
 813         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 814         (gdb_rl_callback_handler): Use std::move.
 815         * common/common-exceptions.h (struct gdb_exception): Add move
 816         assignment operator.
 817         (throw_exception_sjlj): Change "exception" to const reference.
 818         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 819         (throw_exception_sjlj): Change "exception" to const reference.
 820
 821 2019-04-25  Tom Tromey  <tromey@adacore.com>
 822
 823         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 824         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 825         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 826         Update.
 827         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 828         Update.
 829         * mi/mi-interp.c (mi_interp::exec): Update.
 830         * linespec.c (parse_linespec): Update.
 831         * infcall.c (run_inferior_call): Update.
 832         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 833         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 834         (gdbscm_lookup_global_symbol): Update.
 835         * guile/scm-param.c (gdbscm_parameter_value): Update.
 836         * guile/scm-frame.c (gdbscm_frame_read_register)
 837         (gdbscm_frame_read_var): Update.
 838         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 839         * exec.c (try_open_exec_file): Update.
 840         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 841         (gdb_rl_callback_handler): Update.
 842         * common/common-exceptions.h (exception_none): Don't declare.
 843         * common/common-exceptions.c (exception_none): Don't define.
 844         (struct catcher) <exception>: Update.
 845         * cli/cli-interp.c (safe_execute_command): Update.
 846         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 847
 848 2019-04-25  Ali Tamur  <tamur@google.com>
 849
 850         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 851         (read_attribute_value): Likewise.
 852         (dwarf2_read_addr_index): Update comment.
 853         (read_str_index): Add DW_FORM_strx.
 854         (dwarf2_string_attr): Likewise.
 855         (dwarf2_const_value_attr): Likewise.
 856         (dump_die_shallow): Likewise.
 857         (dwarf2_fetch_constant_bytes): Likewise.
 858         (skip_form_bytes): Likewise.
 859         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 860
 861 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 862
 863         PR corefiles/11608
 864         PR corefiles/18187
 865         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 866         OFFSET.  Verify if current mapping contains an ELF header.
 867         (linux_find_memory_regions_full): Adjust call to
 868         dump_mapping_p.
 869
 870 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 871             Kang Li <kanglictf@gmail.com>
 872
 873         PR gdb/21600
 874
 875         * dwarf2-frame.c (read_initial_length): Be consistent about using
 876         unsigned representation of length.
 877         (decode_frame_entry_1): Likewise.  Check for wraparound of
 878         end pointer as well as buffer overflow.
 879
 880 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 881
 882         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 883         "vq".
 884
 885 2019-04-24  Tom Tromey  <tromey@adacore.com>
 886
 887         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 888
 889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 890
 891         * s12z-tdep.c (s12z_unwind_pc): Delete.
 892         (s12z_unwind_sp): Delete.
 893         (s12z_gdbarch_init): Don't register deleted functions with
 894         gdbarch.
 895
 896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 897
 898         * rl78-tdep.c (rl78_unwind_sp): Delete.
 899         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 900
 901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 902
 903         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 904         (xstormy16_unwind_pc): Delete.
 905         (xstormy16_dummy_id): Delete.
 906         (xstormy16_gdbarch_init): Don't register deleted functions with
 907         gdbarch.
 908
 909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * vax-tdep.c (vax_unwind_pc): Delete.
 912         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 913
 914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * v850-tdep.c (v850_unwind_sp): Delete.
 917         (v850_unwind_pc): Delete.
 918         (v850_dummy_id): Delete.
 919         (v850_gdbarch_init): Don't register deleted functions with
 920         gdbarch.
 921
 922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 923
 924         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 925         (tilegx_unwind_pc): Delete.
 926         (tilegx_unwind_dummy_id): Delete.
 927         (tilegx_gdbarch_init): Don't register deleted functions with
 928         gdbarch.
 929
 930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 933         (tic6x_dummy_id): Delete.
 934         (tic6x_gdbarch_init): Don't register deleted functions with
 935         gdbarch.
 936
 937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * sparc-tdep.c (sparc_unwind_pc): Delete.
 940         (sparc32_gdbarch_init): Don't register deleted function with
 941         gdbarch.
 942
 943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 944
 945         * sh-tdep.c (sh_unwind_sp): Delete.
 946         (sh_unwind_pc): Delete.
 947         (sh_dummy_id): Delete.
 948         (sh_gdbarch_init): Don't register deleted functions with
 949         gdbarch.
 950
 951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 952
 953         * score-tdep.c (score_unwind_sp): Delete.
 954         (score_unwind_pc): Delete.
 955         (score_dummy_id): Delete.
 956         (score_gdbarch_init): Don't register deleted functions with
 957         gdbarch.
 958
 959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * rx-tdep.c (rx_unwind_pc): Delete.
 962         (rx_unwind_sp): Delete.
 963         (rx_dummy_id): Delete.
 964         (rx_gdbarch_init): Don't register deleted functions with
 965         gdbarch.  Update comment.
 966
 967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 970         (rs6000_dummy_id): Delete.
 971         (rs6000_gdbarch_init): Don't register deleted functions with
 972         gdbarch.
 973
 974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 975
 976         * or1k-tdep.c (or1k_dummy_id): Delete.
 977         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 978
 979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * nios2-tdep.c (nios2_dummy_id): Delete.
 982         (nios2_unwind_sp): Delete.
 983         (nios2_gdbarch_init): Don't register deleted functions with
 984         gdbarch.
 985
 986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 987
 988         * nds32-tdep.c (nds32_dummy_id): Delete.
 989         (nds32_unwind_pc): Delete.
 990         (nds32_unwind_sp): Delete.
 991         (nds32_gdbarch_init): Don't register deleted functions with
 992         gdbarch.
 993
 994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         * msp430-tdep.c (msp430_unwind_pc): Delete.
 997         (msp430_unwind_sp): Delete.
 998         (msp430_dummy_id): Delete.
 999         (msp430_gdbarch_init): Don't register deleted functions with
1000         gdbarch.
1001
1002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * moxie-tdep.c (moxie_unwind_sp): Delete.
1005         (moxie_unwind_pc): Delete.
1006         (moxie_dummy_id): Delete.
1007         (moxie_gdbarch_init): Don't register deleted functions with
1008         gdbarch.
1009
1010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1011
1012         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1013         (mn10300_unwind_pc): Delete.
1014         (mn10300_unwind_sp): Delete.
1015         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1016         mn10300_unwind_sp.
1017         (mn10300_frame_unwind_init): Don't register deleted functions with
1018         gdbarch.
1019
1020 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * mep-tdep.c (mep_unwind_pc): Delete.
1023         (mep_unwind_sp): Delete.
1024         (mep_dummy_id): Delete.
1025         (mep_gdbarch_init): Don't register deleted functions with
1026         gdbarch.
1027
1028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1031         (m68hc11_unwind_sp): Delete.
1032         (m68hc11_gdbarch_init): Don't register deleted functions with
1033         gdbarch.
1034
1035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1036
1037         * m32r-tdep.c (m32r_unwind_sp): Delete.
1038         (m32r_unwind_pc): Delete.
1039         (m32r_dummy_id): Delete.
1040         (m32r_gdbarch_init): Don't register deleted functions with
1041         gdbarch.
1042
1043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * m32c-tdep.c (m32c_unwind_pc): Delete.
1046         (m32c_unwind_sp): Delete.
1047         (m32c_dummy_id): Delete.
1048         (m32c_gdbarch_init): Don't register deleted functions with
1049         gdbarch.
1050
1051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1054         (lm32_unwind_pc): Delete.
1055         (lm32_dummy_id): Delete.
1056         (lm32_gdbarch_init): Don't register deleted functions with
1057         gdbarch.
1058
1059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1062         (iq2000_unwind_pc): Delete.
1063         (iq2000_dummy_id): Delete.
1064         (iq2000_gdbarch_init): Don't register deleted functions with
1065         gdbarch.
1066
1067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * nds32-tdep.c (nds32_type_align): Delete.
1070         (nds32_push_dummy_call): Use type_align instead.
1071
1072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * arm-tdep.c (arm_type_align): Only handle vector override case.
1075         (arm_push_dummy_call): Use type_align.
1076         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1077
1078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1081         case.
1082         (pass_on_stack): Use type_align.
1083         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1084         function.
1085
1086 2019-04-23  Tom Tromey  <tromey@adacore.com>
1087
1088         * dwarf2read.c (line_header::file_name_at): Remove unused
1089         overload.
1090
1091 2019-04-23  Tom de Vries  <tdevries@suse.de>
1092
1093         PR gdb/24438
1094         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1095         invocation.
1096
1097
1098 2019-03-27  Ali Tamur  <tamur@google.com>
1099
1100         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1101         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1102         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1103         (dwarf_expr_context::get_addr_index): Likewise
1104         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1105         (symbol_needs_eval_context::get_addr_index): Likewise
1106         (disassemble_dwarf_expression): Add DW_OP_addrx
1107         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1108         (read_cutu_die_from_dwo): Update comment
1109         (skip_one_die): Add DW_FORM_addrx
1110         (read_attribute_value): Likewise
1111         (var_decode_location): Add DW_OP_addrx
1112         (dwarf2_const_value_attr): Add DW_FORM_addrx
1113         (dump_die_shallow): Likewise
1114         (dwarf2_fetch_constant_bytes): Likewise
1115         (decode_locdesc): Add DW_OP_addrx
1116         (skip_form_bytes): Add DW_FORM_addrx
1117
1118 2019-04-22  Ali Tamur  <tamur@google.com>
1119
1120         * MAINTAINERS (Write After Approval): Add self.
1121
1122 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1123
1124         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1125         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1126         (open_symbol_file_object): Likewise.
1127         (svr4_default_sos): Add info parameter.
1128         (svr4_read_so_list): Likewise.
1129         (svr4_current_sos_direct): Adjust functions calls to pass down
1130         info.
1131         (svr4_current_sos_1): Add info parameter.
1132         (svr4_current_sos): Call get_svr4_info, pass info down to
1133         svr4_current_sos_1.
1134         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1135         get_svr4_info.
1136         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1137         get_svr4_info.
1138         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1139         to get_svr4_info.
1140         (probes_table_remove_objfile_probes): Likewise.
1141         (register_solib_event_probe): Add info parameter.
1142         (solist_update_incremental): Pass info parameter down to
1143         svr4_read_so_list.
1144         (disable_probes_interface): Add info parameter.
1145         (svr4_handle_solib_event): Pass current_program_space to
1146         get_svr4_info.  Adjust disable_probes_interface cleanup.
1147         (svr4_create_probe_breakpoints): Add info parameter, pass it
1148         down to register_solib_event_probe.
1149         (svr4_create_solib_event_breakpoints): Add info parameter,
1150         pass it down to svr4_create_probe_breakpoints.
1151         (enable_break): Pass info down to
1152         svr4_create_solib_event_breakpoints.
1153         (svr4_solib_create_inferior_hook): Pass current_program_space to
1154         get_svr4_info.
1155         (svr4_clear_solib): Likewise.
1156
1157 2019-04-22  Pedro Alves  <palves@redhat.com>
1158
1159         * solib-svr4.c (svr4_free_objfile_observer): New.
1160         (probe_and_action::objfile): New field.
1161         (probes_table_htab_remove_objfile_probes)
1162         (probes_table_remove_objfile_probes): New functions.
1163         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1164         in the new probe_and_action.  Don't store the probe in 'lookup'.
1165         (svr4_create_probe_breakpoints): Pass objfile to
1166         register_solib_event_probe.
1167         (_initialize_svr4_solib): Register a free_objfile observer.
1168
1169 2019-04-19  Tom Tromey  <tom@tromey.com>
1170
1171         * common/queue.h: Remove.
1172
1173 2019-04-19  Tom Tromey  <tom@tromey.com>
1174
1175         * event-loop.c: Don't include "common/queue.h".
1176
1177 2019-04-19  Tom Tromey  <tom@tromey.com>
1178
1179         * remote.c (remote_target): Use delete.
1180         * remote-notif.h: Include <list>, not "common/queue.h".
1181         (notif_client_p): Remove typedef.
1182         (remote_notif_state): Add constructor, destructor, initializer.
1183         <notif_queue>: Now a std::list.
1184         (remote_notif_state_xfree): Don't declare.
1185         * remote-notif.c (remote_notif_process, handle_notification)
1186         (remote_notif_state_allocate): Update.
1187         (~remote_notif_state): Rename from remote_notif_state_xfree.
1188
1189 2019-04-19  Tom Tromey  <tom@tromey.com>
1190
1191         * symfile.c (reread_symbols): Update.
1192         * objfiles.c (objfile_register_static_link)
1193         (objfile_lookup_static_link): Update
1194         (~objfile) Don't delete static_links.
1195         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1196
1197 2019-04-19  Tom Tromey  <tom@tromey.com>
1198
1199         * type-stack.h (struct type_stack) <insert>: Constify string.
1200         * type-stack.c (type_stack::insert): Constify string.
1201         * gdbtypes.h (lookup_template_type): Update.
1202         (address_space_name_to_int): Update.
1203         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1204         const.
1205         (lookup_template_type): Make name const.
1206         * c-exp.y: Update rules.
1207         (lex_one_token, classify_name, classify_inner_name)
1208         (c_print_token): Update.
1209         * p-exp.y: Update rules.
1210         (yylex): Update.
1211         * f-exp.y: Update rules.
1212         (yylex): Update.
1213         * d-exp.y: Update rules.
1214         (lex_one_token, classify_name, classify_inner_name): Update.
1215         * parse.c (write_dollar_variable, copy_name): Return std::string.
1216         * parser-defs.h (copy_name): Change return type.
1217         * m2-exp.y: Update rules.
1218         (yylex): Update.
1219         * go-exp.y (lex_one_token): Update.
1220         Update rules.
1221         (classify_unsafe_function, classify_packaged_name)
1222         (classify_name, yylex): Update.
1223
1224 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1225
1226         * configure.ac: add --enable-source-highlight switch.
1227         * configure: Regenerate.
1228         * top.c (print_gdb_version): plumb --enable-source-highlight
1229         status to "show configuration".
1230
1231 2019-04-19  Tom Tromey  <tromey@adacore.com>
1232
1233         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1234         Check ADA_TYPE_P.
1235         (empty_record, ada_template_to_fixed_record_type_1)
1236         (template_to_static_fixed_type)
1237         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1238         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1239         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1240         macros.
1241
1242 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1243
1244         PR symtab/24423:
1245         * source.c (print_source_lines_base): Advance "iter" when a
1246         control character is seen.
1247
1248 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1249
1250         * inferior.h (struct infcall_suspend_state_deleter):
1251         Catch exception in destructor to avoid crash.
1252
1253 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1254
1255         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1256         close to the add_com "shell".
1257
1258 2019-04-18  Tom Tromey  <tromey@adacore.com>
1259
1260         * process-stratum-target.h (class process_stratum_target)
1261         <stratum>: Add "final".
1262
1263 2019-04-17  Tom Tromey  <tromey@adacore.com>
1264
1265         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1266         against nullptr before use.
1267
1268 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1269
1270         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1271
1272 2019-04-17  Jim Wilson  <jimw@sifive.com>
1273             Andrew Burgess  <andrew.burgess@embecosm.com>
1274
1275         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1276         code read might fail, assume 4-byte breakpoint in that case.
1277
1278 2019-04-15  Leszek Swirski  <leszeks@google.com>
1279
1280         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1281         rather than a hand-rolled POD check when checking for forced MEMORY
1282         classification.
1283
1284 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1285
1286         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1287         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1288         function.
1289         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1290         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1291         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1292         declaration.
1293
1294 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1295
1296         * aarch64-linux-nat.c
1297         (aarch64_linux_nat_target::thread_architecture): Add override.
1298         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1299         each VQ.
1300
1301 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1302
1303         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1304
1305 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1308         target types of size 96-bits, add some additional comments, and
1309         check that the builtin type we found was the correct size.
1310
1311 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1312
1313         * utils.c (prompt_for_continue): Don't restore the styling at the
1314         end, as applied_style has the wrong value.  This fixes styling in
1315         long lists of file names that are interrupted by the "Continue?"
1316         prompt.
1317
1318 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1321         * c-lang.c (c_language_defn): Likewise.
1322         (cplus_language_defn): Likewise.
1323         (asm_language_defn): Likewise.
1324         (minimal_language_defn): Likewise.
1325         * d-lang.c (d_language_defn): Likewise.
1326         * f-lang.c (f_language_defn): Likewise.
1327         * go-lang.c (go_language_defn): Likewise.
1328         * language.c (unknown_language_defn): Likewise.
1329         (auto_language_defn): Likewise.
1330         * language.h (struct language_defn): Remove la_magic field.
1331         (LANG_MAGIC): Delete.
1332         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1333         * objc-lang.c (objc_language_defn): Likewise.
1334         * opencl-lang.c (opencl_language_defn): Likewise.
1335         * p-lang.c (pascal_language_defn): Likewise.
1336         * rust-lang.c (rust_language_defn): Likewise.
1337
1338 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * riscv-tdep.c (riscv_type_align): New function.
1341         (riscv_type_alignment): Delete.
1342         (riscv_arg_location): Use 'type_align'.
1343         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1344
1345 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1346
1347         * gdbtypes.c (type_align): A struct with no non-static fields also
1348         has alignment of 1.
1349
1350 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1353         component to 0.
1354         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1355         member.
1356         (riscv_struct_info::analyse): New implementation using new
1357         analyse_inner member function.
1358         (riscv_struct_info::field_offset): New member function.
1359         (riscv_struct_info::m_offsets): New member variable.
1360         (riscv_struct_info::analyse_inner): New private member function,
1361         takes the old implementation of riscv_struct_info::analyse but
1362         extended to track field offsets.
1363         (riscv_call_arg_struct): Update the struct folding special cases
1364         to handle cases where empty C++ structs, which are non-zero
1365         length, are found.
1366         (riscv_arg_location): Initialise the length of each location, a
1367         non-zero length now indicates the location is in use.
1368         (riscv_push_dummy_call): Allow for the first location having a
1369         non-zero offset when setting up arguments.
1370         (riscv_return_value): Likewise, but for return values.
1371
1372 2019-04-11  Tom Tromey  <tromey@adacore.com>
1373
1374         * utils.c (internal_vproblem): Make "msg" const.
1375
1376 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1377
1378         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1379         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1380         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1381         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1382
1383 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1384
1385         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1386         function.
1387         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1388         of amd64_collect_native_gregset.
1389         (amd64_linux_nat_target::store_registers): Likewise.
1390
1391 2019-04-10  Tom Tromey  <tom@tromey.com>
1392
1393         * symtab.c (lookup_global_symbol_from_objfile)
1394         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1395         * objfiles.h (class separate_debug_iterator): New.
1396         (class separate_debug_range): New.
1397         (struct objfile) <separate_debug_objfiles>: New method.
1398         (objfile_separate_debug_iterate): Don't declare.
1399         * objfiles.c (separate_debug_iterator::operator++): Rename from
1400         objfile_separate_debug_iterate.
1401         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1402         iterator.
1403         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1404         iterator.
1405
1406 2019-04-10  Tom Tromey  <tom@tromey.com>
1407
1408         * symfile.c (reread_symbols): Remove old comment.
1409         * objfiles.c (free_all_objfiles): Fix a typo.
1410
1411 2019-04-10  Tom Tromey  <tom@tromey.com>
1412
1413         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1414         * minsyms.c (lookup_minimal_symbol): Use foreach.
1415         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1416         (lookup_minimal_symbol_solib_trampoline): Likewise.
1417         * symfile.c (reread_symbols): Use foreach.
1418
1419 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1420             Tom Tromey  <tromey@adacore.com>
1421
1422         PR rust/24414:
1423         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1424         (rust_lex_int_test): Change "value" to be LONGEST.
1425         (rust_lex_tests): Add test for long integer literal.
1426
1427 2019-04-09  Tom Tromey  <tromey@adacore.com>
1428
1429         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1430         to bool.
1431         (extended_remote_target::attach): Update.
1432         (remote_target::remote_notice_new_inferior): Update.
1433         (remote_target::add_current_inferior_and_thread): Update.
1434         * inferior.c (exit_inferior_1): Use "false".
1435         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1436
1437 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1438
1439         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1440         the "start" command.
1441
1442 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1443
1444         * python/py-inferior.c (infpy_thread_from_thread_handle):
1445         Adjust comments to reflect renaming of thread_from_thread_handle
1446         to thread_from_handle.  Adjust keywords.  Fix type error message.
1447         (inferior_object_methods): Add thread_from_handle.  Retain
1448         thread_from_thread_handle, but mark it as deprecated.
1449
1450 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1451
1452         * gdbthread.h (find_thread_by_handle): Revise declaration.
1453         * thread.c (find_thread_by_handle): Likewise.  Adjust
1454         implementation too.
1455         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1456         support for buffer objects as handles.
1457
1458 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1459
1460         * python/py-infthread.c (thpy_thread_handle): New function.
1461         (thread_object_methods): Register thpy_thread_handle.
1462
1463 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1464
1465         * gdbthread.h (thread_to_thread_handle): Declare.
1466         * thread.c (gdbtypes.h): Include.
1467         (thread_to_thread_handle): New function.
1468
1469         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1470         (target_thread_info_to_thread_handle): Declare.
1471         * target.c (target_thread_info_to_thread_handle): New function.
1472         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1473         * target-delegates.c: Regenerate.
1474
1475         * linux-thread-db.c (class thread_db_target): Add method
1476         thread_info_to_thread_handle.
1477         (thread_db_target::thread_info_to_thread_handle): Define.
1478         * remote.c (class remote_target): Add new method
1479         thread_info_to_thread_handle.
1480         (remote_target::thread_info_to_thread_handle): Define.
1481
1482 2019-04-08  Pedro Alves  <palves@redhat.com>
1483
1484         * common/common-exceptions.c (throw_exception): Don't create
1485         named object to throw; throw directly.
1486         (throw_it): Likewise.  Don't initialize gdb_exception::message
1487         here, with new; pass FMT and AP to the ctor instead.
1488         * common/common-exceptions.h: Include <string>.
1489         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1490         const char *, va_list)): New ctor.  Use std::make_shared.
1491         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1492         errors)): Delete.
1493         (gdb_exception_error::gdb_exception_error(enum errors, const char
1494         *, va_list)): New.
1495         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1496         Add assertion.
1497         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1498         errors)): Delete.
1499         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1500         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1501         Add assertion.
1502
1503 2019-04-08  Tom Tromey  <tom@tromey.com>
1504
1505         * valops.c (value_rtti_indirect_type): Replace throw_exception
1506         with throw.
1507         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1508         with throw.
1509         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1510         throw.
1511         * target.c (target_translate_tls_address): Replace throw_exception
1512         with throw.
1513         * stack.c (frame_apply_command_count): Replace throw_exception
1514         with throw.
1515         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1516         throw.
1517         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1518         with throw.
1519         * rs6000-tdep.c (rs6000_frame_cache)
1520         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1521         * remote.c: Replace throw_exception with throw.
1522         * record-full.c (record_full_message, record_full_wait_1)
1523         (record_full_restore): Replace throw_exception with throw.
1524         * record-btrace.c:
1525         (get_thread_current_frame_id, record_btrace_start_replaying)
1526         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1527         (cmd_record_btrace_start): Replace throw_exception with throw.
1528         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1529         throw.
1530         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1531         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1532         * linespec.c:
1533         (find_linespec_symbols): Replace throw_exception with throw.
1534         * infrun.c (displaced_step_prepare, resume): Replace
1535         throw_exception with throw.
1536         * infcmd.c (post_create_inferior): Replace throw_exception with
1537         throw.
1538         * inf-loop.c (inferior_event_handler): Replace throw_exception
1539         with throw.
1540         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1541         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1542         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1543         (get_prev_frame_always, get_frame_pc_if_available)
1544         (get_frame_address_in_block_if_available, get_frame_language):
1545         Replace throw_exception with throw.
1546         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1547         throw_exception with throw.
1548         * eval.c (fetch_subexp_value, evaluate_var_value)
1549         (evaluate_funcall, evaluate_subexp_standard): Replace
1550         throw_exception with throw.
1551         * dwarf2loc.c (call_site_find_chain)
1552         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1553         Replace throw_exception with throw.
1554         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1555         with throw.
1556         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1557         throw.
1558         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1559         * completer.c (complete_line_internal): Replace throw_exception
1560         with throw.
1561         * compile/compile-object-run.c (compile_object_run): Replace
1562         throw_exception with throw.
1563         * cli/cli-script.c (process_next_line): Replace throw_exception
1564         with throw.
1565         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1566         (btrace_enable, btrace_maint_update_pt_packets): Replace
1567         throw_exception with throw.
1568         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1569         throw_exception with throw.
1570         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1571         throw_exception with throw.
1572         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1573         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1574         * aarch64-tdep.c (aarch64_make_prologue_cache)
1575         (aarch64_make_stub_cache): Replace throw_exception with throw.
1576
1577 2019-04-08  Tom Tromey  <tom@tromey.com>
1578
1579         * common/common-exceptions.c (throw_exception): Rename from
1580         throw_exception_cxx.  Remove old copy.  Make argument const.
1581         (throw_it): Create and throw exception objects directly.
1582         * common/common-exceptions.h (throw_exception): Make argument
1583         const.
1584         (struct gdb_exception_error): Add constructor.
1585         (struct gdb_exception_quit): Add constructor.
1586
1587 2019-04-08  Tom Tromey  <tom@tromey.com>
1588
1589         * common/common-exceptions.h (exception_rethrow): Don't declare.
1590         (TRY_SJLJ): Update comment.
1591         (TRY, CATCH, END_CATCH): Remove.
1592         * common/common-exceptions.c (exception_rethrow): Remove.
1593
1594 2019-04-08  Tom Tromey  <tom@tromey.com>
1595
1596         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1597         Remove.
1598         (gdb_exception_error): Rename from
1599         gdb_exception_RETURN_MASK_ERROR.
1600         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1601         (gdb_quit_bad_alloc): Update.
1602         * aarch64-tdep.c: Update.
1603         * ada-lang.c: Update.
1604         * ada-typeprint.c: Update.
1605         * ada-valprint.c: Update.
1606         * amd64-tdep.c: Update.
1607         * arch-utils.c: Update.
1608         * break-catch-throw.c: Update.
1609         * breakpoint.c: Update.
1610         * btrace.c: Update.
1611         * c-varobj.c: Update.
1612         * cli/cli-cmds.c: Update.
1613         * cli/cli-interp.c: Update.
1614         * cli/cli-script.c: Update.
1615         * common/common-exceptions.c: Update.
1616         * common/new-op.c: Update.
1617         * common/selftest.c: Update.
1618         * compile/compile-c-symbols.c: Update.
1619         * compile/compile-cplus-symbols.c: Update.
1620         * compile/compile-object-load.c: Update.
1621         * compile/compile-object-run.c: Update.
1622         * completer.c: Update.
1623         * corelow.c: Update.
1624         * cp-abi.c: Update.
1625         * cp-support.c: Update.
1626         * cp-valprint.c: Update.
1627         * darwin-nat.c: Update.
1628         * disasm-selftests.c: Update.
1629         * dtrace-probe.c: Update.
1630         * dwarf-index-cache.c: Update.
1631         * dwarf-index-write.c: Update.
1632         * dwarf2-frame-tailcall.c: Update.
1633         * dwarf2-frame.c: Update.
1634         * dwarf2loc.c: Update.
1635         * dwarf2read.c: Update.
1636         * eval.c: Update.
1637         * event-loop.c: Update.
1638         * event-top.c: Update.
1639         * exec.c: Update.
1640         * f-valprint.c: Update.
1641         * fbsd-tdep.c: Update.
1642         * frame-unwind.c: Update.
1643         * frame.c: Update.
1644         * gdbtypes.c: Update.
1645         * gnu-v3-abi.c: Update.
1646         * guile/guile-internal.h: Update.
1647         * guile/scm-block.c: Update.
1648         * guile/scm-breakpoint.c: Update.
1649         * guile/scm-cmd.c: Update.
1650         * guile/scm-disasm.c: Update.
1651         * guile/scm-frame.c: Update.
1652         * guile/scm-lazy-string.c: Update.
1653         * guile/scm-math.c: Update.
1654         * guile/scm-param.c: Update.
1655         * guile/scm-ports.c: Update.
1656         * guile/scm-pretty-print.c: Update.
1657         * guile/scm-symbol.c: Update.
1658         * guile/scm-symtab.c: Update.
1659         * guile/scm-type.c: Update.
1660         * guile/scm-value.c: Update.
1661         * i386-linux-tdep.c: Update.
1662         * i386-tdep.c: Update.
1663         * inf-loop.c: Update.
1664         * infcall.c: Update.
1665         * infcmd.c: Update.
1666         * infrun.c: Update.
1667         * jit.c: Update.
1668         * language.c: Update.
1669         * linespec.c: Update.
1670         * linux-fork.c: Update.
1671         * linux-nat.c: Update.
1672         * linux-tdep.c: Update.
1673         * linux-thread-db.c: Update.
1674         * main.c: Update.
1675         * mi/mi-cmd-break.c: Update.
1676         * mi/mi-cmd-stack.c: Update.
1677         * mi/mi-interp.c: Update.
1678         * mi/mi-main.c: Update.
1679         * objc-lang.c: Update.
1680         * p-valprint.c: Update.
1681         * parse.c: Update.
1682         * ppc-linux-tdep.c: Update.
1683         * printcmd.c: Update.
1684         * python/py-arch.c: Update.
1685         * python/py-breakpoint.c: Update.
1686         * python/py-cmd.c: Update.
1687         * python/py-finishbreakpoint.c: Update.
1688         * python/py-frame.c: Update.
1689         * python/py-framefilter.c: Update.
1690         * python/py-gdb-readline.c: Update.
1691         * python/py-inferior.c: Update.
1692         * python/py-infthread.c: Update.
1693         * python/py-lazy-string.c: Update.
1694         * python/py-linetable.c: Update.
1695         * python/py-objfile.c: Update.
1696         * python/py-param.c: Update.
1697         * python/py-prettyprint.c: Update.
1698         * python/py-progspace.c: Update.
1699         * python/py-record-btrace.c: Update.
1700         * python/py-record.c: Update.
1701         * python/py-symbol.c: Update.
1702         * python/py-type.c: Update.
1703         * python/py-unwind.c: Update.
1704         * python/py-utils.c: Update.
1705         * python/py-value.c: Update.
1706         * python/python.c: Update.
1707         * record-btrace.c: Update.
1708         * record-full.c: Update.
1709         * remote-fileio.c: Update.
1710         * remote.c: Update.
1711         * riscv-tdep.c: Update.
1712         * rs6000-aix-tdep.c: Update.
1713         * rs6000-tdep.c: Update.
1714         * rust-exp.y: Update.
1715         * rust-lang.c: Update.
1716         * s390-tdep.c: Update.
1717         * selftest-arch.c: Update.
1718         * solib-dsbt.c: Update.
1719         * solib-frv.c: Update.
1720         * solib-spu.c: Update.
1721         * solib-svr4.c: Update.
1722         * solib.c: Update.
1723         * sparc64-linux-tdep.c: Update.
1724         * stack.c: Update.
1725         * symfile-mem.c: Update.
1726         * symmisc.c: Update.
1727         * target.c: Update.
1728         * thread.c: Update.
1729         * top.c: Update.
1730         * tracefile-tfile.c: Update.
1731         * tui/tui.c: Update.
1732         * typeprint.c: Update.
1733         * unittests/cli-utils-selftests.c: Update.
1734         * unittests/parse-connection-spec-selftests.c: Update.
1735         * valops.c: Update.
1736         * valprint.c: Update.
1737         * value.c: Update.
1738         * varobj.c: Update.
1739         * windows-nat.c: Update.
1740         * x86-linux-nat.c: Update.
1741         * xml-support.c: Update.
1742
1743 2019-04-08  Tom Tromey  <tom@tromey.com>
1744
1745         * xml-support.c: Use C++ exception handling.
1746         * x86-linux-nat.c: Use C++ exception handling.
1747         * windows-nat.c: Use C++ exception handling.
1748         * varobj.c: Use C++ exception handling.
1749         * value.c: Use C++ exception handling.
1750         * valprint.c: Use C++ exception handling.
1751         * valops.c: Use C++ exception handling.
1752         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1753         handling.
1754         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1755         * typeprint.c: Use C++ exception handling.
1756         * tui/tui.c: Use C++ exception handling.
1757         * tracefile-tfile.c: Use C++ exception handling.
1758         * top.c: Use C++ exception handling.
1759         * thread.c: Use C++ exception handling.
1760         * target.c: Use C++ exception handling.
1761         * symmisc.c: Use C++ exception handling.
1762         * symfile-mem.c: Use C++ exception handling.
1763         * stack.c: Use C++ exception handling.
1764         * sparc64-linux-tdep.c: Use C++ exception handling.
1765         * solib.c: Use C++ exception handling.
1766         * solib-svr4.c: Use C++ exception handling.
1767         * solib-spu.c: Use C++ exception handling.
1768         * solib-frv.c: Use C++ exception handling.
1769         * solib-dsbt.c: Use C++ exception handling.
1770         * selftest-arch.c: Use C++ exception handling.
1771         * s390-tdep.c: Use C++ exception handling.
1772         * rust-lang.c: Use C++ exception handling.
1773         * rust-exp.y: Use C++ exception handling.
1774         * rs6000-tdep.c: Use C++ exception handling.
1775         * rs6000-aix-tdep.c: Use C++ exception handling.
1776         * riscv-tdep.c: Use C++ exception handling.
1777         * remote.c: Use C++ exception handling.
1778         * remote-fileio.c: Use C++ exception handling.
1779         * record-full.c: Use C++ exception handling.
1780         * record-btrace.c: Use C++ exception handling.
1781         * python/python.c: Use C++ exception handling.
1782         * python/py-value.c: Use C++ exception handling.
1783         * python/py-utils.c: Use C++ exception handling.
1784         * python/py-unwind.c: Use C++ exception handling.
1785         * python/py-type.c: Use C++ exception handling.
1786         * python/py-symbol.c: Use C++ exception handling.
1787         * python/py-record.c: Use C++ exception handling.
1788         * python/py-record-btrace.c: Use C++ exception handling.
1789         * python/py-progspace.c: Use C++ exception handling.
1790         * python/py-prettyprint.c: Use C++ exception handling.
1791         * python/py-param.c: Use C++ exception handling.
1792         * python/py-objfile.c: Use C++ exception handling.
1793         * python/py-linetable.c: Use C++ exception handling.
1794         * python/py-lazy-string.c: Use C++ exception handling.
1795         * python/py-infthread.c: Use C++ exception handling.
1796         * python/py-inferior.c: Use C++ exception handling.
1797         * python/py-gdb-readline.c: Use C++ exception handling.
1798         * python/py-framefilter.c: Use C++ exception handling.
1799         * python/py-frame.c: Use C++ exception handling.
1800         * python/py-finishbreakpoint.c: Use C++ exception handling.
1801         * python/py-cmd.c: Use C++ exception handling.
1802         * python/py-breakpoint.c: Use C++ exception handling.
1803         * python/py-arch.c: Use C++ exception handling.
1804         * printcmd.c: Use C++ exception handling.
1805         * ppc-linux-tdep.c: Use C++ exception handling.
1806         * parse.c: Use C++ exception handling.
1807         * p-valprint.c: Use C++ exception handling.
1808         * objc-lang.c: Use C++ exception handling.
1809         * mi/mi-main.c: Use C++ exception handling.
1810         * mi/mi-interp.c: Use C++ exception handling.
1811         * mi/mi-cmd-stack.c: Use C++ exception handling.
1812         * mi/mi-cmd-break.c: Use C++ exception handling.
1813         * main.c: Use C++ exception handling.
1814         * linux-thread-db.c: Use C++ exception handling.
1815         * linux-tdep.c: Use C++ exception handling.
1816         * linux-nat.c: Use C++ exception handling.
1817         * linux-fork.c: Use C++ exception handling.
1818         * linespec.c: Use C++ exception handling.
1819         * language.c: Use C++ exception handling.
1820         * jit.c: Use C++ exception handling.
1821         * infrun.c: Use C++ exception handling.
1822         * infcmd.c: Use C++ exception handling.
1823         * infcall.c: Use C++ exception handling.
1824         * inf-loop.c: Use C++ exception handling.
1825         * i386-tdep.c: Use C++ exception handling.
1826         * i386-linux-tdep.c: Use C++ exception handling.
1827         * guile/scm-value.c: Use C++ exception handling.
1828         * guile/scm-type.c: Use C++ exception handling.
1829         * guile/scm-symtab.c: Use C++ exception handling.
1830         * guile/scm-symbol.c: Use C++ exception handling.
1831         * guile/scm-pretty-print.c: Use C++ exception handling.
1832         * guile/scm-ports.c: Use C++ exception handling.
1833         * guile/scm-param.c: Use C++ exception handling.
1834         * guile/scm-math.c: Use C++ exception handling.
1835         * guile/scm-lazy-string.c: Use C++ exception handling.
1836         * guile/scm-frame.c: Use C++ exception handling.
1837         * guile/scm-disasm.c: Use C++ exception handling.
1838         * guile/scm-cmd.c: Use C++ exception handling.
1839         * guile/scm-breakpoint.c: Use C++ exception handling.
1840         * guile/scm-block.c: Use C++ exception handling.
1841         * guile/guile-internal.h: Use C++ exception handling.
1842         * gnu-v3-abi.c: Use C++ exception handling.
1843         * gdbtypes.c: Use C++ exception handling.
1844         * frame.c: Use C++ exception handling.
1845         * frame-unwind.c: Use C++ exception handling.
1846         * fbsd-tdep.c: Use C++ exception handling.
1847         * f-valprint.c: Use C++ exception handling.
1848         * exec.c: Use C++ exception handling.
1849         * event-top.c: Use C++ exception handling.
1850         * event-loop.c: Use C++ exception handling.
1851         * eval.c: Use C++ exception handling.
1852         * dwarf2read.c: Use C++ exception handling.
1853         * dwarf2loc.c: Use C++ exception handling.
1854         * dwarf2-frame.c: Use C++ exception handling.
1855         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1856         * dwarf-index-write.c: Use C++ exception handling.
1857         * dwarf-index-cache.c: Use C++ exception handling.
1858         * dtrace-probe.c: Use C++ exception handling.
1859         * disasm-selftests.c: Use C++ exception handling.
1860         * darwin-nat.c: Use C++ exception handling.
1861         * cp-valprint.c: Use C++ exception handling.
1862         * cp-support.c: Use C++ exception handling.
1863         * cp-abi.c: Use C++ exception handling.
1864         * corelow.c: Use C++ exception handling.
1865         * completer.c: Use C++ exception handling.
1866         * compile/compile-object-run.c: Use C++ exception handling.
1867         * compile/compile-object-load.c: Use C++ exception handling.
1868         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1869         * compile/compile-c-symbols.c: Use C++ exception handling.
1870         * common/selftest.c: Use C++ exception handling.
1871         * common/new-op.c: Use C++ exception handling.
1872         * cli/cli-script.c: Use C++ exception handling.
1873         * cli/cli-interp.c: Use C++ exception handling.
1874         * cli/cli-cmds.c: Use C++ exception handling.
1875         * c-varobj.c: Use C++ exception handling.
1876         * btrace.c: Use C++ exception handling.
1877         * breakpoint.c: Use C++ exception handling.
1878         * break-catch-throw.c: Use C++ exception handling.
1879         * arch-utils.c: Use C++ exception handling.
1880         * amd64-tdep.c: Use C++ exception handling.
1881         * ada-valprint.c: Use C++ exception handling.
1882         * ada-typeprint.c: Use C++ exception handling.
1883         * ada-lang.c: Use C++ exception handling.
1884         * aarch64-tdep.c: Use C++ exception handling.
1885
1886 2019-04-08  Tom Tromey  <tom@tromey.com>
1887
1888         * xml-support.c (gdb_xml_parser::parse): Update.
1889         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1890         * value.c (show_convenience): Update.
1891         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1892         (test_parse_flags_qcs): Update.
1893         * thread.c (thr_try_catch_cmd): Update.
1894         * target.c (target_translate_tls_address): Update.
1895         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1896         (info_frame_command_core, frame_apply_command_count): Update.
1897         * rust-exp.y (rust_lex_exception_test): Update.
1898         * riscv-tdep.c (riscv_print_one_register_info): Update.
1899         * remote.c (remote_target::enable_btrace): Update.
1900         * record-btrace.c (record_btrace_enable_warn): Update.
1901         * python/py-utils.c (gdbpy_convert_exception): Update.
1902         * printcmd.c (do_one_display, print_variable_and_value): Update.
1903         * mi/mi-main.c (mi_print_exception): Update.
1904         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1905         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1906         * linux-nat.c (linux_nat_target::attach): Update.
1907         * linux-fork.c (class scoped_switch_fork_info): Update.
1908         * infrun.c (displaced_step_prepare): Update.
1909         * infcall.c (call_function_by_hand_dummy): Update.
1910         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1911         * gnu-v3-abi.c (print_one_vtable): Update.
1912         * frame.c (get_prev_frame_always): Update.
1913         * f-valprint.c (info_common_command_for_block): Update.
1914         * exec.c (try_open_exec_file): Update.
1915         * exceptions.c (print_exception, exception_print)
1916         (exception_fprintf, exception_print_same): Update.
1917         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1918         * dwarf-index-cache.c (index_cache::store)
1919         (index_cache::lookup_gdb_index): Update.
1920         * darwin-nat.c (maybe_cache_shell): Update.
1921         * cp-valprint.c (cp_print_value_fields): Update.
1922         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1923         (gcc_cplus_symbol_address): Update.
1924         * compile/compile-c-symbols.c (gcc_convert_symbol)
1925         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1926         * common/selftest.c: Update.
1927         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1928         a std::string.
1929         (exception_try_scope_entry, exception_try_scope_exit): Don't
1930         declare.
1931         (struct exception_try_scope): Remove.
1932         (TRY): Don't use exception_try_scope.
1933         (struct gdb_exception): Add constructor, operator=.
1934         <what>: New method.
1935         (struct gdb_exception_RETURN_MASK_ALL)
1936         (struct gdb_exception_RETURN_MASK_ERROR)
1937         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1938         (struct gdb_quit_bad_alloc): Update.
1939         * common/common-exceptions.c (exception_none): Change
1940         initializer.
1941         (struct catcher) <state, exception>: Initialize inline.
1942         <prev>: Remove member.
1943         (current_catcher): Remove.
1944         (catchers): New global.
1945         (exceptions_state_mc_init): Simplify.
1946         (catcher_pop): Remove.
1947         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1948         (try_scope_depth, exception_try_scope_entry)
1949         (exception_try_scope_exit): Remove.
1950         (throw_exception_sjlj): Update.
1951         (exception_messages, exception_messages_size): Remove.
1952         (throw_it): Simplify.
1953         (gdb_exception_sliced_copy): Remove.
1954         (throw_exception_cxx): Update.
1955         * cli/cli-script.c (script_from_file): Update.
1956         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1957         Update.
1958         * ada-valprint.c (ada_val_print): Update.
1959         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1960         (create_excep_cond_exprs): Update.
1961
1962 2019-04-08  Tom Tromey  <tom@tromey.com>
1963
1964         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1965         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1966         (TRY, CATCH, END_CATCH): Remove some definitions.
1967         * common/common-exceptions.c: Don't use GDB_XCPT.
1968         (catcher_list_size): Remove.
1969         (throw_exception, throw_it): Simplify.
1970
1971 2019-04-05  Tom Tromey  <tom@tromey.com>
1972
1973         Revert the header-sorting patch.
1974         * ft32-tdep.c: Revert.
1975         * frv-tdep.c: Revert.
1976         * frv-linux-tdep.c: Revert.
1977         * frame.c: Revert.
1978         * frame-unwind.c: Revert.
1979         * frame-base.c: Revert.
1980         * fork-child.c: Revert.
1981         * findvar.c: Revert.
1982         * findcmd.c: Revert.
1983         * filesystem.c: Revert.
1984         * filename-seen-cache.h: Revert.
1985         * filename-seen-cache.c: Revert.
1986         * fbsd-tdep.c: Revert.
1987         * fbsd-nat.h: Revert.
1988         * fbsd-nat.c: Revert.
1989         * f-valprint.c: Revert.
1990         * f-typeprint.c: Revert.
1991         * f-lang.c: Revert.
1992         * extension.h: Revert.
1993         * extension.c: Revert.
1994         * extension-priv.h: Revert.
1995         * expprint.c: Revert.
1996         * exec.h: Revert.
1997         * exec.c: Revert.
1998         * exceptions.c: Revert.
1999         * event-top.c: Revert.
2000         * event-loop.c: Revert.
2001         * eval.c: Revert.
2002         * elfread.c: Revert.
2003         * dwarf2read.h: Revert.
2004         * dwarf2read.c: Revert.
2005         * dwarf2loc.c: Revert.
2006         * dwarf2expr.h: Revert.
2007         * dwarf2expr.c: Revert.
2008         * dwarf2-frame.c: Revert.
2009         * dwarf2-frame-tailcall.c: Revert.
2010         * dwarf-index-write.h: Revert.
2011         * dwarf-index-write.c: Revert.
2012         * dwarf-index-common.c: Revert.
2013         * dwarf-index-cache.h: Revert.
2014         * dwarf-index-cache.c: Revert.
2015         * dummy-frame.c: Revert.
2016         * dtrace-probe.c: Revert.
2017         * disasm.h: Revert.
2018         * disasm.c: Revert.
2019         * disasm-selftests.c: Revert.
2020         * dictionary.c: Revert.
2021         * dicos-tdep.c: Revert.
2022         * demangle.c: Revert.
2023         * dcache.h: Revert.
2024         * dcache.c: Revert.
2025         * darwin-nat.h: Revert.
2026         * darwin-nat.c: Revert.
2027         * darwin-nat-info.c: Revert.
2028         * d-valprint.c: Revert.
2029         * d-namespace.c: Revert.
2030         * d-lang.c: Revert.
2031         * ctf.c: Revert.
2032         * csky-tdep.c: Revert.
2033         * csky-linux-tdep.c: Revert.
2034         * cris-tdep.c: Revert.
2035         * cris-linux-tdep.c: Revert.
2036         * cp-valprint.c: Revert.
2037         * cp-support.c: Revert.
2038         * cp-namespace.c: Revert.
2039         * cp-abi.c: Revert.
2040         * corelow.c: Revert.
2041         * corefile.c: Revert.
2042         * continuations.c: Revert.
2043         * completer.h: Revert.
2044         * completer.c: Revert.
2045         * complaints.c: Revert.
2046         * coffread.c: Revert.
2047         * coff-pe-read.c: Revert.
2048         * cli-out.h: Revert.
2049         * cli-out.c: Revert.
2050         * charset.c: Revert.
2051         * c-varobj.c: Revert.
2052         * c-valprint.c: Revert.
2053         * c-typeprint.c: Revert.
2054         * c-lang.c: Revert.
2055         * buildsym.c: Revert.
2056         * buildsym-legacy.c: Revert.
2057         * build-id.h: Revert.
2058         * build-id.c: Revert.
2059         * btrace.c: Revert.
2060         * bsd-uthread.c: Revert.
2061         * breakpoint.h: Revert.
2062         * breakpoint.c: Revert.
2063         * break-catch-throw.c: Revert.
2064         * break-catch-syscall.c: Revert.
2065         * break-catch-sig.c: Revert.
2066         * blockframe.c: Revert.
2067         * block.c: Revert.
2068         * bfin-tdep.c: Revert.
2069         * bfin-linux-tdep.c: Revert.
2070         * bfd-target.c: Revert.
2071         * bcache.c: Revert.
2072         * ax-general.c: Revert.
2073         * ax-gdb.h: Revert.
2074         * ax-gdb.c: Revert.
2075         * avr-tdep.c: Revert.
2076         * auxv.c: Revert.
2077         * auto-load.c: Revert.
2078         * arm-wince-tdep.c: Revert.
2079         * arm-tdep.c: Revert.
2080         * arm-symbian-tdep.c: Revert.
2081         * arm-pikeos-tdep.c: Revert.
2082         * arm-obsd-tdep.c: Revert.
2083         * arm-nbsd-tdep.c: Revert.
2084         * arm-nbsd-nat.c: Revert.
2085         * arm-linux-tdep.c: Revert.
2086         * arm-linux-nat.c: Revert.
2087         * arm-fbsd-tdep.c: Revert.
2088         * arm-fbsd-nat.c: Revert.
2089         * arm-bsd-tdep.c: Revert.
2090         * arch-utils.c: Revert.
2091         * arc-tdep.c: Revert.
2092         * arc-newlib-tdep.c: Revert.
2093         * annotate.h: Revert.
2094         * annotate.c: Revert.
2095         * amd64-windows-tdep.c: Revert.
2096         * amd64-windows-nat.c: Revert.
2097         * amd64-tdep.c: Revert.
2098         * amd64-sol2-tdep.c: Revert.
2099         * amd64-obsd-tdep.c: Revert.
2100         * amd64-obsd-nat.c: Revert.
2101         * amd64-nbsd-tdep.c: Revert.
2102         * amd64-nbsd-nat.c: Revert.
2103         * amd64-nat.c: Revert.
2104         * amd64-linux-tdep.c: Revert.
2105         * amd64-linux-nat.c: Revert.
2106         * amd64-fbsd-tdep.c: Revert.
2107         * amd64-fbsd-nat.c: Revert.
2108         * amd64-dicos-tdep.c: Revert.
2109         * amd64-darwin-tdep.c: Revert.
2110         * amd64-bsd-nat.c: Revert.
2111         * alpha-tdep.c: Revert.
2112         * alpha-obsd-tdep.c: Revert.
2113         * alpha-nbsd-tdep.c: Revert.
2114         * alpha-mdebug-tdep.c: Revert.
2115         * alpha-linux-tdep.c: Revert.
2116         * alpha-linux-nat.c: Revert.
2117         * alpha-bsd-tdep.c: Revert.
2118         * alpha-bsd-nat.c: Revert.
2119         * aix-thread.c: Revert.
2120         * agent.c: Revert.
2121         * addrmap.c: Revert.
2122         * ada-varobj.c: Revert.
2123         * ada-valprint.c: Revert.
2124         * ada-typeprint.c: Revert.
2125         * ada-tasks.c: Revert.
2126         * ada-lang.c: Revert.
2127         * aarch64-tdep.c: Revert.
2128         * aarch64-ravenscar-thread.c: Revert.
2129         * aarch64-newlib-tdep.c: Revert.
2130         * aarch64-linux-tdep.c: Revert.
2131         * aarch64-linux-nat.c: Revert.
2132         * aarch64-fbsd-tdep.c: Revert.
2133         * aarch64-fbsd-nat.c: Revert.
2134         * aarch32-linux-nat.c: Revert.
2135
2136 2019-04-05  Tom Tromey  <tom@tromey.com>
2137
2138         * ft32-tdep.c: Sort headers.
2139         * frv-tdep.c: Sort headers.
2140         * frv-linux-tdep.c: Sort headers.
2141         * frame.c: Sort headers.
2142         * frame-unwind.c: Sort headers.
2143         * frame-base.c: Sort headers.
2144         * fork-child.c: Sort headers.
2145         * findvar.c: Sort headers.
2146         * findcmd.c: Sort headers.
2147         * filesystem.c: Sort headers.
2148         * filename-seen-cache.h: Sort headers.
2149         * filename-seen-cache.c: Sort headers.
2150         * fbsd-tdep.c: Sort headers.
2151         * fbsd-nat.h: Sort headers.
2152         * fbsd-nat.c: Sort headers.
2153         * f-valprint.c: Sort headers.
2154         * f-typeprint.c: Sort headers.
2155         * f-lang.c: Sort headers.
2156         * extension.h: Sort headers.
2157         * extension.c: Sort headers.
2158         * extension-priv.h: Sort headers.
2159         * expprint.c: Sort headers.
2160         * exec.h: Sort headers.
2161         * exec.c: Sort headers.
2162         * exceptions.c: Sort headers.
2163         * event-top.c: Sort headers.
2164         * event-loop.c: Sort headers.
2165         * eval.c: Sort headers.
2166         * elfread.c: Sort headers.
2167         * dwarf2read.h: Sort headers.
2168         * dwarf2read.c: Sort headers.
2169         * dwarf2loc.c: Sort headers.
2170         * dwarf2expr.h: Sort headers.
2171         * dwarf2expr.c: Sort headers.
2172         * dwarf2-frame.c: Sort headers.
2173         * dwarf2-frame-tailcall.c: Sort headers.
2174         * dwarf-index-write.h: Sort headers.
2175         * dwarf-index-write.c: Sort headers.
2176         * dwarf-index-common.c: Sort headers.
2177         * dwarf-index-cache.h: Sort headers.
2178         * dwarf-index-cache.c: Sort headers.
2179         * dummy-frame.c: Sort headers.
2180         * dtrace-probe.c: Sort headers.
2181         * disasm.h: Sort headers.
2182         * disasm.c: Sort headers.
2183         * disasm-selftests.c: Sort headers.
2184         * dictionary.c: Sort headers.
2185         * dicos-tdep.c: Sort headers.
2186         * demangle.c: Sort headers.
2187         * dcache.h: Sort headers.
2188         * dcache.c: Sort headers.
2189         * darwin-nat.h: Sort headers.
2190         * darwin-nat.c: Sort headers.
2191         * darwin-nat-info.c: Sort headers.
2192         * d-valprint.c: Sort headers.
2193         * d-namespace.c: Sort headers.
2194         * d-lang.c: Sort headers.
2195         * ctf.c: Sort headers.
2196         * csky-tdep.c: Sort headers.
2197         * csky-linux-tdep.c: Sort headers.
2198         * cris-tdep.c: Sort headers.
2199         * cris-linux-tdep.c: Sort headers.
2200         * cp-valprint.c: Sort headers.
2201         * cp-support.c: Sort headers.
2202         * cp-namespace.c: Sort headers.
2203         * cp-abi.c: Sort headers.
2204         * corelow.c: Sort headers.
2205         * corefile.c: Sort headers.
2206         * continuations.c: Sort headers.
2207         * completer.h: Sort headers.
2208         * completer.c: Sort headers.
2209         * complaints.c: Sort headers.
2210         * coffread.c: Sort headers.
2211         * coff-pe-read.c: Sort headers.
2212         * cli-out.h: Sort headers.
2213         * cli-out.c: Sort headers.
2214         * charset.c: Sort headers.
2215         * c-varobj.c: Sort headers.
2216         * c-valprint.c: Sort headers.
2217         * c-typeprint.c: Sort headers.
2218         * c-lang.c: Sort headers.
2219         * buildsym.c: Sort headers.
2220         * buildsym-legacy.c: Sort headers.
2221         * build-id.h: Sort headers.
2222         * build-id.c: Sort headers.
2223         * btrace.c: Sort headers.
2224         * bsd-uthread.c: Sort headers.
2225         * breakpoint.h: Sort headers.
2226         * breakpoint.c: Sort headers.
2227         * break-catch-throw.c: Sort headers.
2228         * break-catch-syscall.c: Sort headers.
2229         * break-catch-sig.c: Sort headers.
2230         * blockframe.c: Sort headers.
2231         * block.c: Sort headers.
2232         * bfin-tdep.c: Sort headers.
2233         * bfin-linux-tdep.c: Sort headers.
2234         * bfd-target.c: Sort headers.
2235         * bcache.c: Sort headers.
2236         * ax-general.c: Sort headers.
2237         * ax-gdb.h: Sort headers.
2238         * ax-gdb.c: Sort headers.
2239         * avr-tdep.c: Sort headers.
2240         * auxv.c: Sort headers.
2241         * auto-load.c: Sort headers.
2242         * arm-wince-tdep.c: Sort headers.
2243         * arm-tdep.c: Sort headers.
2244         * arm-symbian-tdep.c: Sort headers.
2245         * arm-pikeos-tdep.c: Sort headers.
2246         * arm-obsd-tdep.c: Sort headers.
2247         * arm-nbsd-tdep.c: Sort headers.
2248         * arm-nbsd-nat.c: Sort headers.
2249         * arm-linux-tdep.c: Sort headers.
2250         * arm-linux-nat.c: Sort headers.
2251         * arm-fbsd-tdep.c: Sort headers.
2252         * arm-fbsd-nat.c: Sort headers.
2253         * arm-bsd-tdep.c: Sort headers.
2254         * arch-utils.c: Sort headers.
2255         * arc-tdep.c: Sort headers.
2256         * arc-newlib-tdep.c: Sort headers.
2257         * annotate.h: Sort headers.
2258         * annotate.c: Sort headers.
2259         * amd64-windows-tdep.c: Sort headers.
2260         * amd64-windows-nat.c: Sort headers.
2261         * amd64-tdep.c: Sort headers.
2262         * amd64-sol2-tdep.c: Sort headers.
2263         * amd64-obsd-tdep.c: Sort headers.
2264         * amd64-obsd-nat.c: Sort headers.
2265         * amd64-nbsd-tdep.c: Sort headers.
2266         * amd64-nbsd-nat.c: Sort headers.
2267         * amd64-nat.c: Sort headers.
2268         * amd64-linux-tdep.c: Sort headers.
2269         * amd64-linux-nat.c: Sort headers.
2270         * amd64-fbsd-tdep.c: Sort headers.
2271         * amd64-fbsd-nat.c: Sort headers.
2272         * amd64-dicos-tdep.c: Sort headers.
2273         * amd64-darwin-tdep.c: Sort headers.
2274         * amd64-bsd-nat.c: Sort headers.
2275         * alpha-tdep.c: Sort headers.
2276         * alpha-obsd-tdep.c: Sort headers.
2277         * alpha-nbsd-tdep.c: Sort headers.
2278         * alpha-mdebug-tdep.c: Sort headers.
2279         * alpha-linux-tdep.c: Sort headers.
2280         * alpha-linux-nat.c: Sort headers.
2281         * alpha-bsd-tdep.c: Sort headers.
2282         * alpha-bsd-nat.c: Sort headers.
2283         * aix-thread.c: Sort headers.
2284         * agent.c: Sort headers.
2285         * addrmap.c: Sort headers.
2286         * ada-varobj.c: Sort headers.
2287         * ada-valprint.c: Sort headers.
2288         * ada-typeprint.c: Sort headers.
2289         * ada-tasks.c: Sort headers.
2290         * ada-lang.c: Sort headers.
2291         * aarch64-tdep.c: Sort headers.
2292         * aarch64-ravenscar-thread.c: Sort headers.
2293         * aarch64-newlib-tdep.c: Sort headers.
2294         * aarch64-linux-tdep.c: Sort headers.
2295         * aarch64-linux-nat.c: Sort headers.
2296         * aarch64-fbsd-tdep.c: Sort headers.
2297         * aarch64-fbsd-nat.c: Sort headers.
2298         * aarch32-linux-nat.c: Sort headers.
2299
2300 2019-04-04  Tom Tromey  <tom@tromey.com>
2301
2302         * varobj.c (varobj_create): Update.
2303         * rust-exp.y (struct rust_parser) <update_innermost_block,
2304         lookup_symbol>: New methods.
2305         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2306         Rename.
2307         (rust_parser::rust_lookup_type)
2308         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2309         * printcmd.c (display_command, do_one_display): Update.
2310         * parser-defs.h (struct parser_state) <parser_state>: Add
2311         "tracker" parameter.
2312         (block_tracker): New member.
2313         (class innermost_block_tracker) <innermost_block_tracker>: Add
2314         "types" parameter.
2315         <reset>: Remove method.
2316         (innermost_block): Don't declare.
2317         (null_post_parser): Update.
2318         * parse.c (innermost_block): Remove global.
2319         (write_dollar_variable): Update.
2320         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2321         Remove "tracker_types" parameter.
2322         (parse_expression): Add "tracker" parameter.
2323         (parse_expression_for_completion): Update.
2324         (null_post_parser): Add "tracker" parameter.
2325         * p-exp.y: Update rules.
2326         * m2-exp.y: Update rules.
2327         * language.h (struct language_defn) <la_post_parser>: Add
2328         "tracker" parameter.
2329         * go-exp.y: Update rules.
2330         * f-exp.y: Update rules.
2331         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2332         parameter.
2333         * d-exp.y: Update rules.
2334         * c-exp.y: Update rules.
2335         * breakpoint.c (set_breakpoint_condition): Create an
2336         innermost_block_tracker.
2337         (watch_command_1): Likewise.
2338         * ada-lang.c (resolve): Add "tracker" parameter.
2339         (resolve_subexp): Likewise.
2340         * ada-exp.y (write_var_from_sym): Update.
2341
2342 2019-04-04  Tom Tromey  <tom@tromey.com>
2343
2344         * type-stack.h: New file.
2345         * type-stack.c: New file.
2346         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2347         type-stack.h.
2348         (insert_into_type_stack, insert_type, push_type, push_type_int)
2349         (insert_type_address_space, pop_type, pop_type_int)
2350         (pop_typelist, pop_type_stack, append_type_stack)
2351         (push_type_stack, get_type_stack, push_typelist)
2352         (follow_type_instance_flags, follow_types): Don't declare.
2353         * parse.c (type_stack): Remove global.
2354         (parse_exp_in_context): Update.
2355         (insert_into_type_stack, insert_type, push_type, push_type_int)
2356         (insert_type_address_space, pop_type, pop_type_int)
2357         (pop_typelist, pop_type_stack, append_type_stack)
2358         (push_type_stack, get_type_stack, push_typelist)
2359         (follow_type_instance_flags, follow_types): Remove (moved to
2360         type-stack.c).
2361         * f-exp.y (type_stack): New global.
2362         Update rules.
2363         (push_kind_type, f_parse): Update.
2364         * d-exp.y (type_stack): New global.
2365         Update rules.
2366         (d_parse): Update.
2367         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2368         Update rules.
2369         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2370         (HFILES_NO_SRCDIR): Add type-stack.h.
2371
2372 2019-04-04  Tom Tromey  <tom@tromey.com>
2373
2374         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2375         (rust_parser::convert_ast_to_expression, rust_parse)
2376         (rust_lex_test_completion, rust_lex_tests): Update.
2377         * parser-defs.h (struct expr_completion_state): New.
2378         (struct parser_state) <parser_state>: Add completion parameter.
2379         <mark_struct_expression, mark_completion_tag>: New methods.
2380         <parse_completion, m_completion_state>: New members.
2381         (prefixify_expression, null_post_parser): Update.
2382         (mark_struct_expression, mark_completion_tag): Don't declare.
2383         * parse.c (parse_completion, expout_last_struct)
2384         (expout_tag_completion_type, expout_completion_name): Remove
2385         globals.
2386         (parser_state::mark_struct_expression)
2387         (parser_state::mark_completion_tag): Now methods.
2388         (prefixify_expression): Add last_struct parameter.
2389         (prefixify_subexp): Likewise.
2390         (parse_exp_1): Update.
2391         (parse_exp_in_context): Add cstate parameter.  Update.
2392         (parse_expression_for_completion): Create an
2393         expr_completion_state.
2394         (null_post_parser): Add "completion" parameter.
2395         * p-exp.y: Update rules.
2396         (yylex): Update.
2397         * language.h (struct language_defn) <la_post_parser>: Add
2398         "completing" parameter.
2399         * go-exp.y: Update rules.
2400         (lex_one_token): Update.
2401         * expression.h (parse_completion): Don't declare.
2402         * d-exp.y: Update rules.
2403         (lex_one_token): Update rules.
2404         * c-exp.y: Update rules.
2405         (lex_one_token): Update.
2406         * ada-lang.c (resolve): Add "parse_completion" parameter.
2407         (resolve_subexp): Likewise.
2408         (ada_resolve_function): Likewise.
2409
2410 2019-04-04  Tom Tromey  <tom@tromey.com>
2411
2412         * parser-defs.h (struct parser_state) <start_arglist,
2413         end_arglist>: New methods.
2414         <arglist_len, m_funcall_chain>: New members.
2415         (arglist_len, start_arglist, end_arglist): Don't declare.
2416         * parse.c (arglist_len, funcall_chain): Remove global.
2417         (start_arglist, end_arglist): Remove functions.
2418         (parse_exp_in_context): Update.
2419         * p-exp.y: Update rules.
2420         * m2-exp.y: Update rules.
2421         * go-exp.y: Update rules.
2422         * f-exp.y: Update rules.
2423         * d-exp.y: Update rules.
2424         * c-exp.y: Update rules.
2425
2426 2019-04-04  Tom Tromey  <tom@tromey.com>
2427
2428         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2429         lex_operator, push_back>: New methods.
2430         Update all rules.
2431         (rust_parser::lex_hex, lex_escape): Rename and update.
2432         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2433         (rust_parser::lex_operator): Rename and update.
2434         (rust_parser::lex_number, rustyylex, rustyyerror)
2435         (rust_lex_test_init, rust_lex_test_sequence)
2436         (rust_lex_test_push_back, rust_lex_tests): Update.
2437         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2438         parameter.
2439         <lexptr, prev_lexptr>: New members.
2440         (lexptr, prev_lexptr): Don't declare.
2441         * parse.c (lexptr, prev_lexptr): Remove globals.
2442         (parse_exp_in_context): Update.
2443         * p-exp.y (yylex, yyerror): Update.
2444         * m2-exp.y (parse_number, yylex, yyerror): Update.
2445         * go-exp.y (lex_one_token, yyerror): Update.
2446         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2447         * d-exp.y (lex_one_token, yyerror): Update.
2448         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2449         (lex_one_token, yyerror): Update.
2450         * ada-lex.l (YY_INPUT): Update.
2451         (rewind_to_char): Update.
2452         * ada-exp.y (yyerror): Update.
2453
2454 2019-04-04  Tom Tromey  <tom@tromey.com>
2455
2456         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2457         * parser-defs.h (struct parser_state) <parser_state>: Add new
2458         parameter.
2459         <comma_terminates>: New member.
2460         (comma_terminates): Don't declare global.
2461         * parse.c (comma_terminates): Remove global.
2462         (parse_exp_in_context): Update.
2463         * p-exp.y (yylex): Update.
2464         * m2-exp.y (yylex): Update.
2465         * go-exp.y (lex_one_token): Update.
2466         * f-exp.y (yylex): Update.
2467         * d-exp.y (lex_one_token): Update.
2468         * c-exp.y (lex_one_token): Update.
2469         * ada-lex.l: Update.
2470
2471 2019-04-04  Tom Tromey  <tom@tromey.com>
2472
2473         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2474         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2475         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2476         * parser-defs.h (paren_depth): Don't declare.
2477         * parse.c (paren_depth): Remove global.
2478         (parse_exp_in_context): Update.
2479         * p-exp.y (paren_depth): New global.
2480         (pascal_parse): Initialize it.
2481         * m2-exp.y (paren_depth): New global.
2482         (m2_parse): Initialize it.
2483         * go-exp.y (paren_depth): New global.
2484         (go_parse): Initialize it.
2485         * f-exp.y (paren_depth): New global.
2486         (f_parse): Initialize it.
2487         * d-exp.y (paren_depth): New global.
2488         (d_parse): Initialize it.
2489         * c-exp.y (paren_depth): New global.
2490         (c_parse): Initialize it.
2491         * ada-lex.l (paren_depth): New global.
2492         (lexer_init): Initialize it.
2493
2494 2019-04-04  Tom Tromey  <tom@tromey.com>
2495
2496         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2497         (rust_parser::convert_ast_to_type)
2498         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2499         * parser-defs.h (struct parser_state) <parser_state>: Add
2500         parameters.  Initialize new members.
2501         <expression_context_block, expression_context_pc>: New members.
2502         * parse.c (expression_context_block, expression_context_pc):
2503         Remove globals.
2504         (parse_exp_in_context): Update.
2505         * p-exp.y: Update all rules.
2506         (yylex): Update.
2507         * m2-exp.y: Update all rules.
2508         (yylex): Update.
2509         * go-exp.y (yylex): Update.
2510         * f-exp.y (yylex): Update.
2511         * d-exp.y: Update all rules.
2512         (yylex): Update.
2513         * c-exp.y: Update all rules.
2514         (lex_one_token, classify_name, yylex, c_parse): Update.
2515         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2516
2517 2019-04-04  Tom Tromey  <tom@tromey.com>
2518
2519         * gdbarch.h, gdbarch.c: Rebuild.
2520         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2521         * stap-probe.h:
2522         (struct stap_parse_info): Replace "parser_state" with
2523         "expr_builder".
2524         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2525         (parser_state): New class.
2526         * parse.c (expr_builder): Rename.
2527         (expr_builder::release): Rename.
2528         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2529         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2530         (write_exp_elt_longcst, write_exp_elt_floatcst)
2531         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2532         (write_exp_string_vector, write_exp_bitstring)
2533         (write_exp_msymbol, mark_struct_expression)
2534         (write_dollar_variable)
2535         (insert_type_address_space, increase_expout_size): Replace
2536         "parser_state" with "expr_builder".
2537         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2538         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2539         "parser_state" with "expr_builder".
2540
2541 2019-04-04  Tom Tromey  <tom@tromey.com>
2542
2543         * rust-exp.y: Replace "parse_language" with method call.
2544         * p-exp.y:
2545         (yylex): Replace "parse_language" with method call.
2546         * m2-exp.y:
2547         (yylex): Replace "parse_language" with method call.
2548         * go-exp.y (classify_name): Replace "parse_language" with method
2549         call.
2550         * f-exp.y (yylex): Replace "parse_language" with method call.
2551         * d-exp.y (lex_one_token): Replace "parse_language" with method
2552         call.
2553         * c-exp.y:
2554         (lex_one_token, classify_name, yylex): Replace "parse_language"
2555         with method call.
2556         * ada-exp.y (find_primitive_type, type_char)
2557         (type_system_address): Replace "parse_language" with method call.
2558
2559 2019-04-04  Tom Tromey  <tom@tromey.com>
2560
2561         * rust-exp.y: Replace "parse_gdbarch" with method call.
2562         * parse.c (write_dollar_variable, insert_type_address_space):
2563         Replace "parse_gdbarch" with method call.
2564         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2565         call.
2566         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2567         call.
2568         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2569         "parse_gdbarch" with method call.
2570         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2571         with method call.
2572         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2573         "parse_gdbarch" with method call.
2574         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2575         "parse_gdbarch" with method call.
2576         * c-exp.y (parse_type, parse_number, classify_name): Replace
2577         "parse_gdbarch" with method call.
2578         * ada-lex.l: Replace "parse_gdbarch" with method call.
2579         * ada-exp.y (parse_type, find_primitive_type, type_char)
2580         (type_system_address): Replace "parse_gdbarch" with method call.
2581
2582 2019-04-04  Tom Tromey  <tom@tromey.com>
2583
2584         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2585         * stap-probe.c (stap_parse_argument): Update.
2586         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2587         initial_size parameter.
2588         * rust-exp.y (rust_lex_tests): Update.
2589         * parse.c (parser_state): Update.
2590         (parse_exp_in_context): Update.
2591         * parser-defs.h (struct parser_state) <parser_state>: Remove
2592         "initial_size" parameter.
2593
2594 2019-04-04  Tom Tromey  <tom@tromey.com>
2595
2596         * parser-defs.h (increase_expout_size): Don't declare.
2597         * parse.c (increase_expout_size): Now static.
2598
2599 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2600
2601         * gnu-nat.c (gnu_nat_target::wait): Fix
2602         target_waitstatus_to_string call.
2603
2604 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2605
2606         * eval.c (evaluate_subexp_standard): Handle internal functions
2607         during Fortran function call handling.
2608
2609 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * NEWS: Mention new internal functions.
2612         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2613         (read_base_type): Use dwarf2_init_complex_target_type.
2614         * value.c (creal_internal_fn): New function.
2615         (cimag_internal_fn): New function.
2616         (_initialize_values): Register new internal functions.
2617
2618 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2619
2620         * infrun.c (stop_all_threads): If debug_infrun, always
2621         trace the wait status after wait_one, using
2622         target_waitstatus_to_string and target_pid_to_str.
2623         (handle_inferior_event): Replace various trace of
2624         wait status kind by a single trace.
2625         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2626         wait status kind image by target_waitstatus_to_string.
2627         * target/waitstatus.c (target_waitstatus_to_string): Fix
2628         obsolete comment.
2629
2630 2019-04-01  Tom Tromey  <tromey@adacore.com>
2631
2632         PR symtab/23331:
2633         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2634
2635 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2636             Pedro Alves  <palves@redhat.com>
2637
2638         * top.c (quit_force): Call 'finalize_values'.
2639         * value.c (finalize_values): New function.
2640         * value.h (finalize_values): Declare.
2641
2642 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2643
2644         * NEWS: Announce $_gdb_major and $_gdb_minor.
2645
2646         * top.c (init_gdb_version_vars): New function.
2647         (gdb_init): Call init_gdb_version_vars.
2648
2649 2019-03-29  Tom Tromey  <tromey@adacore.com>
2650
2651         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2652         help text.  Remove dead code.
2653
2654 2019-03-29  Keith Seitz  <keiths@redhat.com>
2655
2656         From Siddhesh Poyarekar:
2657         * f-lang.h (f77_get_upperbound): Return LONGEST.
2658         (f77_get_lowerbound): Likewise.
2659         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2660         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2661         print them.
2662         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2663         plongest to format print it.
2664         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2665         (f77_get_upperbound): Likewise.
2666         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2667         LOWER_BOUND to LONGEST.
2668         (f77_create_arrayprint_offset_tbl): Likewise.
2669
2670 2019-03-29  Keith Seitz  <keiths@redhat.com>
2671
2672         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2673         %s/pulongest for TYPE_LENGTH instead of %d in format
2674         strings.
2675         * ada-typerint.c (ada_print_type): Likewise.
2676         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2677         * compile/compile-c-support.c (generate_register_struct): Likewise.
2678         * gdbtypes.c (recursive_dump_type): Likewise.
2679         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2680         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2681         instead of %d in format strings.
2682         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2683         to std::min to ULONGEST.
2684         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2685         instead of %d in format strings.
2686         * tracepoint.c (info_scope_command): Likewise.
2687         * typeprint.c (print_offset_data::update)
2688         (print_offset_data::finish): Likewise.
2689         * xtensa-tdep.c (xtensa_store_return_value)
2690         (xtensa_push_dummy_call): Likewise.
2691
2692 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2693
2694         * windows-nat.c (display_selector): Fixed format specifications
2695         for 64-bit Cygwin.
2696
2697 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2698
2699         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2700
2701 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2702
2703         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2704         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2705         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2706         (nios2_linux_init_abi): Install it.
2707
2708 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2709
2710         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2711
2712 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2713
2714         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2715
2716 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2717             Tom Tromey  <tromey@adacore.com>
2718
2719         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2720
2721 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2722
2723         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2724         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2725         method to compute the bounds of range types. Also print "[evaluated]"
2726         if the bounds' values come from a dynamic evaluation.
2727
2728 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2729
2730         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2731         whitespace when pretty printing is on.
2732
2733 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2734
2735         * ppc-linux-nat.c: Add include.
2736
2737 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2738
2739         * NEWS: Mention AArch64 Pointer Authentication.
2740
2741 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2742
2743         * arm-linux-nat.c: Add include.
2744
2745 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2746
2747         * source-cache.c (source_cache::get_source_lines): Re-read
2748         fullname after calling open_source_file.
2749
2750 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2751
2752         * NEWS: Mention TLS support for FreeBSD.
2753
2754 2019-03-25  Tom Tromey  <tromey@adacore.com>
2755
2756         * minsyms.c (BUNCH_SIZE): Update comment.
2757         (~minimal_symbol_reader): Remove old comment.
2758         (compact_minimal_symbols): Update comment.
2759         (minimal_symbol_reader::install): Remove old comment.  Update
2760         other comments.
2761
2762 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2763
2764         * s390-linux-nat.c: Add include.
2765
2766 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2767
2768         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2769         Call linux_get_hwcap.
2770         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2771         Likewise.
2772         (aarch64_linux_get_hwcap): Remove function.
2773         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2774         declaration.
2775         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2776         linux_get_hwcap.
2777         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2778         * linux-tdep.c (linux_get_hwcap): Add function.
2779         (linux_get_hwcap2): Likewise.
2780         * linux-tdep.h (linux_get_hwcap): Add declaration.
2781         (linux_get_hwcap2): Likewise.
2782         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2783         (ppc_linux_get_hwcap2): Likewise.
2784         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2785         linux_get_hwcap.
2786         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2787         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2788         (ppc_linux_nat_target::read_description): Likewise.
2789         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2790         * s390-linux-nat.c: Likewise.
2791         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2792
2793 2019-03-24  Tom Tromey  <tom@tromey.com>
2794
2795         * ada-lang.c (standard_lookup): Simplify initialization.
2796         (ada_lookup_symbol_nonlocal): Simplify return.
2797         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2798         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2799         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2800         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2801         initialization.
2802         * solib.c (solib_global_lookup): Simplify.
2803         * symtab.c (null_block_symbol): Remove.
2804         (symbol_cache_lookup): Simplify returns.
2805         (lookup_language_this): Simplify returns.
2806         (lookup_symbol_aux): Simplify return.
2807         (lookup_local_symbol): Simplify returns.
2808         (lookup_global_symbol_from_objfile): Simplify return.
2809         (lookup_symbol_in_objfile_symtabs)
2810         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2811         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2812         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2813         * cp-namespace.c (cp_lookup_bare_symbol)
2814         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2815         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2816         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2817         (cp_lookup_symbol_via_imports): Simplify initialization.
2818         (find_symbol_in_baseclass): Likewise.
2819         * symtab.h (null_block_symbol): Remove.
2820         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2821         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2822         (d_lookup_symbol_module): Likewise.
2823         (find_symbol_in_baseclass): Simplify initialization.
2824
2825 2019-03-24  Tom Tromey  <tom@tromey.com>
2826
2827         * expression.h: Don't include symtab.h.
2828         (struct block): Forward declare.
2829
2830 2019-03-24  Tom Tromey  <tom@tromey.com>
2831
2832         * c-exp.y (typebase): Remove casts.
2833         * gdbtypes.c (lookup_unsigned_typename, )
2834         (lookup_signed_typename): Remove cast.
2835         * eval.c (parse_to_comma_and_eval): Remove cast.
2836         * parse.c (write_dollar_variable): Remove cast.
2837         * block.h (struct block) <superblock>: Now const.
2838         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2839         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2840         (map_block): Make "block" const.
2841         * symfile.h (struct quick_symbol_functions)
2842         <map_matching_symbols>: Constify block argument to "callback".
2843         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2844         const.
2845         (find_pc_sect_compunit_symtab): Make "b" const.
2846         (find_symbol_at_address): Likewise.
2847         (search_symbols): Likewise.
2848         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2849         (dw2_debug_names_lookup_symbol): Likewise.
2850         (dw2_map_matching_symbols): Update.
2851         * p-valprint.c (pascal_val_print): Remove "block".
2852         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2853         (aux_add_nonlocal_symbols): Make "block" const.
2854         (resolve_subexp): Remove cast.
2855         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2856         const.
2857         (iterate_over_file_blocks): Likewise.
2858         * f-exp.y (%union) <bval>: Remove.
2859         * coffread.c (patch_opaque_types): Make "b" const.
2860         * spu-tdep.c (spu_catch_start): Make "block" const.
2861         * c-valprint.c (print_unpacked_pointer): Remove "block".
2862         * symmisc.c (dump_symtab_1): Make "b" const.
2863         (block_depth): Make "block" const.
2864         * d-exp.y (%union) <bval>: Remove.
2865         * cp-support.h (cp_lookup_rtti_type): Update.
2866         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2867         * psymtab.c (psym_lookup_symbol): Make "block" const.
2868         (maintenance_check_psymtabs): Make "b" const.
2869         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2870         (enumerate_locals, enumerate_args): Update.
2871         * python/py-symtab.c (stpy_global_block): Make "block" const.
2872         (stpy_static_block): Likewise.
2873         * inline-frame.c (block_starting_point_at): Make "new_block"
2874         const.
2875         * block.c (find_block_in_blockvector): Make return type const.
2876         (blockvector_for_pc_sect): Make "b" const.
2877         (find_block_in_blockvector): Make "b" const.
2878
2879 2019-03-23  Tom Tromey  <tom@tromey.com>
2880
2881         * varobj.c (varobj_create): Update.
2882         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2883         * printcmd.c (display_command, do_one_display): Don't reset
2884         innermost_block.
2885         * parser-defs.h (enum innermost_block_tracker_type): Move to
2886         expression.h.
2887         (innermost_block): Update comment.
2888         * parse.c (parse_exp_1): Add tracker_types parameter.
2889         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2890         tracker_types parameter.  Reset innermost_block.
2891         (parse_exp_in_context): Remove.
2892         (parse_expression_for_completion): Update.
2893         * objfiles.c (~objfile): Don't reset expression_context_block or
2894         innermost_block.
2895         * expression.h (enum innermost_block_tracker_type): Move from
2896         parser-defs.h.
2897         (parse_exp_1): Add tracker_types parameter.
2898         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2899         reset innermost_block.
2900
2901 2019-03-23  Tom Tromey  <tom@tromey.com>
2902
2903         * objfiles.h: Include bcache.h.
2904
2905 2019-03-23  Tom Tromey  <tom@tromey.com>
2906
2907         * linespec.c (get_current_search_block): Use
2908         scoped_restore_current_language.
2909         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2910
2911 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2912             Jiong Wang  <jiong.wang@arm.com>
2913
2914         * aarch64-linux-tdep.c
2915         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2916         section.
2917         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2918
2919 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2920             Jiong Wang  <jiong.wang@arm.com>
2921
2922         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2923         instructions.
2924         (aarch64_analyze_prologue_test): Add PACIASP test.
2925         (aarch64_prologue_prev_register): Unmask PC value.
2926
2927 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2928             Jiong Wang  <jiong.wang@arm.com>
2929
2930         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2931         (aarch64_dwarf2_prev_register): Unmask PC value.
2932         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2933         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2934         DW_CFA_AARCH64_negate_ra_state.
2935         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2936
2937 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2938             Jiong Wang  <jiong.wang@arm.com>
2939
2940         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2941         registers.
2942         (aarch64_pseudo_register_name): Likewise.
2943         (aarch64_pseudo_register_type): Likewise.
2944         (aarch64_pseudo_register_reggroup_p): Likewise.
2945         (aarch64_gdbarch_init): Add pauth registers.
2946         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2947         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2948         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2949         (struct gdbarch_tdep): Add regnum for ra_state.
2950
2951 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2952             Jiong Wang  <jiong.wang@arm.com>
2953
2954         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2955
2956 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2957             Jiong Wang  <jiong.wang@arm.com>
2958
2959         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2960         function.
2961         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2962         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2963         (aarch64_gdbarch_init): Add puth registers.
2964         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2965         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2966         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2967
2968 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2969             Jiong Wang  <jiong.wang@arm.com>
2970
2971         * aarch64-linux-nat.c
2972         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2973         * aarch64-linux-tdep.c
2974         (aarch64_linux_core_read_description): Likewise.
2975         (aarch64_linux_get_hwcap): New function.
2976         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2977         (aarch64_linux_get_hwcap): New declaration.
2978
2979 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2980             Jiong Wang  <jiong.wang@arm.com>
2981
2982         * aarch64-linux-nat.c
2983         (aarch64_linux_nat_target::read_description): Add pauth param.
2984         * aarch64-linux-tdep.c
2985         (aarch64_linux_core_read_description): Likewise.
2986         * aarch64-tdep.c (struct target_desc): Add in pauth.
2987         (aarch64_read_description): Add pauth param.
2988         (aarch64_gdbarch_init): Likewise.
2989         * aarch64-tdep.h (aarch64_read_description): Likewise.
2990         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2991         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2992         * features/Makefile: Add new files.
2993         * features/aarch64-pauth.c: New file.
2994         * features/aarch64-pauth.xml: New file.
2995
2996 2019-03-20  Tom Tromey  <tromey@adacore.com>
2997
2998         * infrun.c (handle_inferior_event): Rename from
2999         handle_inferior_event_1.  Create a scoped_value_mark.
3000         (handle_inferior_event): Remove.
3001
3002 2019-03-19  Tom Tromey  <tromey@adacore.com>
3003
3004         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3005         * infrun.h (print_stop_event): Add "displays" parameter.
3006         * infrun.c (print_stop_event): Add "displays" parameter.
3007
3008 2019-03-19  Pedro Alves  <palves@redhat.com>
3009
3010         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3011         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3012         to -1.  Fix TABs vs spaces.
3013         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3014         * tui/tui-out.h (tui_ui_out) Add intro comments.
3015         <m_line, m_start_of_line>: In-class initialize, and add describing
3016         comment.
3017
3018 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3019
3020         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3021         variable names.
3022         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3023
3024 2019-03-18  Pedro Alves  <palves@redhat.com>
3025             Eli Zaretskii <eliz@gnu.org>
3026
3027         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3028         m_line and m_start_of_line.
3029
3030 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3031
3032         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3033         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3034         it returns a newline.  This fixes a regression in TU mode, whereby
3035         the next line is output on the same screen line as the user input.
3036
3037 2019-03-18  Tom Tromey  <tromey@adacore.com>
3038
3039         * minsyms.c (minimal_symbol_reader::install): Remove call to
3040         obstack_blank.
3041
3042 2019-03-18  Pedro Alves  <palves@redhat.com>
3043
3044         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3045         New globals.
3046         (apply_style): New, factored out from ...
3047         (apply_ansi_escape): ... this.  Handle reverse video mode.
3048         (tui_set_reverse_mode): New function.
3049         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3050         * tui/tui-winsource.c (tui_show_source_line): Use
3051         tui_set_reverse_mode instead of setting A_STANDOUT.
3052         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3053         New setter methods.
3054
3055 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3056
3057         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3058         Handle tabs.
3059
3060 2019-03-18  Tom Tromey  <tromey@adacore.com>
3061
3062         * ada-lang.c (empty_array): Add "high" parameter.
3063         (ada_evaluate_subexp): Update.
3064
3065 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3066
3067         * unittests/string_view-selftests.c: Define
3068         _initialize_string_view_selftests unconditionally.
3069
3070 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3071
3072         PR gdb/24350
3073         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3074
3075 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3076
3077         PR gdb/24351
3078         * windows-nat.c (display_selector): Fix format specifiers.
3079
3080 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3081
3082         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3083         tui_refill_source_window instead of tui_refresh_win, to update the
3084         current execution line.  This fixes redisplay of the current line
3085         when stepping through the code with "next" or "step".
3086
3087 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3088
3089         * source-cache.c (source_cache::get_source_lines): Call
3090         find_source_lines to initialize s->nlines.  This fixes vertical
3091         scrolling of TUI source window when the DOWN arrow is pressed.
3092
3093 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3094
3095         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3096         linux-thread-db.c (_initialize_thread_db): Likewise.
3097
3098 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3099
3100         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3101         wclrtoeol in tui_show_source_line".  This reverts changes made in
3102         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3103
3104 2019-03-15  Tom Tromey  <tom@tromey.com>
3105
3106         * symtab.h (struct minimal_symbol): Derive from
3107         general_symbol_info.
3108         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3109         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3110         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3111         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3112         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3113         (MSYMBOL_SEARCH_NAME): Update.
3114         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3115         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3116         * minsyms.c (minimal_symbol_reader::record_full): Update.
3117
3118 2019-03-15  Tom Tromey  <tom@tromey.com>
3119
3120         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3121
3122 2019-03-15  Tom Tromey  <tom@tromey.com>
3123
3124         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3125         unique_xmalloc_ptr.
3126         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3127         Update.
3128         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3129         (build_minimal_symbol_hash_tables)
3130         (minimal_symbol_reader::install): Update.
3131
3132 2019-03-15  Tom Tromey  <tom@tromey.com>
3133
3134         * symtab.c (create_demangled_names_hash): Update.
3135         (symbol_set_names): Update.
3136         * objfiles.h (struct objfile_per_bfd_storage)
3137         <demangled_names_hash>: Now an htab_up.
3138         * objfiles.c (objfile_per_bfd_storage): Simplify.
3139
3140 2019-03-15  Tom Tromey  <tom@tromey.com>
3141
3142         * objfiles.h (struct objfile_per_bfd_storage): Declare
3143         destructor.
3144         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3145         New.
3146         (get_objfile_bfd_data): Use new.  Don't initialize
3147         language_of_main.
3148         (free_objfile_per_bfd_storage): Remove.
3149         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3150
3151 2019-03-15  Tom Tromey  <tom@tromey.com>
3152
3153         * symfile.c (reread_symbols): Update.
3154         * objfiles.c (objfile::objfile): Update.
3155         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3156         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3157         comment.
3158         (minimal_symbol_reader::install): Update.
3159         (terminate_minimal_symbol_table): Remove.
3160         * jit.c (jit_object_close_impl): Update.
3161
3162 2019-03-15  Tom Tromey  <tom@tromey.com>
3163
3164         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3165         initializations.
3166
3167 2019-03-15  Tom Tromey  <tom@tromey.com>
3168
3169         * objfiles.h (struct objfile_per_bfd_storage)
3170         <demangled_hash_languages>: Now a bitset.
3171         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3172         (lookup_minimal_symbol): Update.
3173
3174 2019-03-15  Tom Tromey  <tom@tromey.com>
3175
3176         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3177         Don't return the symbol.
3178         * coffread.c (record_minimal_symbol): Use record_full.
3179
3180 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3181
3182         The MS-Windows port of ncurses fails to switch to a color pair if
3183         one or both of the colors are the implicit default colors.  This
3184         change records the default colors when TUI is initialized, and
3185         then specifies them explicitly when a color pair uses the default
3186         colors.  This allows color styling in TUI mode on MS-Windows.
3187
3188         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3189         ncurses_norm_attr.
3190         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3191         colors in ncurses_norm_attr.
3192         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3193         "none", replace it with the default color recorded in
3194         ncurses_norm_attr.
3195
3196 2019-03-14  Tom Tromey  <tromey@adacore.com>
3197
3198         * source-cache.h (class source_cache) <get_source_lines>: Return
3199         std::string.
3200         * source-cache.c (source_cache::extract_lines): Handle case where
3201         first_pos==npos.  Return std::string.
3202         (source_cache::get_source_lines): Update.
3203
3204 2019-03-14  Tom Tromey  <tromey@adacore.com>
3205
3206         * NEWS: Add item for "style sources" commands.
3207         * source-cache.c (source_cache::get_source_lines): Check
3208         source_styling.
3209         * cli/cli-style.c (source_styling): New global.
3210         (_initialize_cli_style): Add "style sources" commands.
3211         (show_style_sources): New function.
3212         * cli/cli-style.h (source_styling): Declare.
3213
3214 2019-03-14  Pedro Alves  <palves@redhat.com>
3215             Tom Tromey  <tromey@adacore.com>
3216
3217         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3218         * tui/tui-winsource.c (tui_refill_source_window): New function,
3219         from...
3220         (tui_horizontal_source_scroll): ... here.  Move some logic.
3221         * cli/cli-style.c (set_style_enabled): Notify new observable.
3222         * tui/tui-hooks.c (tui_redisplay_source): New function.
3223         (tui_attach_detach_observers): Attach or detach
3224         tui_redisplay_source.
3225         * observable.h (source_styling_changed): New observable.
3226         * observable.c: Define source_styling_changed observable.
3227
3228 2019-03-13  Tom Tromey  <tromey@adacore.com>
3229
3230         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3231         (i386_gnu_nat_target::store_registers): Update.
3232         * target-debug.h (target_debug_print_std_string): New macro.
3233         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3234         * windows-tdep.c (display_one_tib): Update.
3235         * tui/tui-stack.c (tui_make_status_line): Update.
3236         * top.c (print_inferior_quit_action): Update.
3237         * thread.c (thr_try_catch_cmd): Update.
3238         (add_thread_with_info): Update.
3239         (thread_target_id_str): Update.
3240         (thr_try_catch_cmd): Update.
3241         (thread_command): Update.
3242         (thread_find_command): Update.
3243         * record-btrace.c (record_btrace_target::info_record)
3244         (record_btrace_resume_thread, record_btrace_target::resume)
3245         (record_btrace_cancel_resume, record_btrace_step_thread)
3246         (record_btrace_target::wait, record_btrace_target::wait)
3247         (record_btrace_target::wait, record_btrace_target::stop): Update.
3248         * progspace.c (print_program_space): Update.
3249         * process-stratum-target.c
3250         (process_stratum_target::thread_address_space): Update.
3251         * linux-fork.c (linux_fork_mourn_inferior)
3252         (detach_checkpoint_command, info_checkpoints_command)
3253         (linux_fork_context): Update.
3254         (linux_fork_detach): Update.
3255         (class scoped_switch_fork_info): Update.
3256         (delete_checkpoint_command): Update.
3257         * infrun.c (follow_fork_inferior): Update.
3258         (follow_fork_inferior): Update.
3259         (proceed_after_vfork_done): Update.
3260         (handle_vfork_child_exec_or_exit): Update.
3261         (follow_exec): Update.
3262         (displaced_step_prepare_throw): Update.
3263         (displaced_step_restore): Update.
3264         (start_step_over): Update.
3265         (resume_1): Update.
3266         (clear_proceed_status_thread): Update.
3267         (proceed): Update.
3268         (print_target_wait_results): Update.
3269         (do_target_wait): Update.
3270         (context_switch): Update.
3271         (stop_all_threads): Update.
3272         (restart_threads): Update.
3273         (finish_step_over): Update.
3274         (handle_signal_stop): Update.
3275         (switch_back_to_stepped_thread): Update.
3276         (keep_going_pass_signal): Update.
3277         (print_exited_reason): Update.
3278         (normal_stop): Update.
3279         * inferior.c (inferior_pid_to_str): Change return type.
3280         (print_selected_inferior): Update.
3281         (add_inferior): Update.
3282         (detach_inferior): Update.
3283         * dummy-frame.c (fprint_dummy_frames): Update.
3284         * dcache.c (dcache_info_1): Update.
3285         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3286         (btrace_fetch, btrace_clear): Update.
3287         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3288         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3289         type.
3290         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3291         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3292         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3293         * gdbarch.c, gdbarch.h: Rebuild.
3294         * gdbarch.sh (core_pid_to_str): Change return type.
3295         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3296         return type.
3297         (windows_nat_target::pid_to_str): Change return type.
3298         (windows_delete_thread): Update.
3299         (windows_nat_target::attach): Update.
3300         (windows_nat_target::files_info): Update.
3301         * target-delegates.c: Rebuild.
3302         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3303         return type.
3304         (sol_thread_target::pid_to_str): Change return type.
3305         * remote.c (class remote_target) <pid_to_str>: Change return
3306         type.
3307         (remote_target::pid_to_str): Change return type.
3308         (extended_remote_target::attach, remote_target::remote_stop_ns)
3309         (remote_target::remote_notif_remove_queued_reply)
3310         (remote_target::push_stop_reply, remote_target::disable_btrace):
3311         Update.
3312         (extended_remote_target::attach): Update.
3313         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3314         type.
3315         (gdbsim_target::pid_to_str): Change return type.
3316         * ravenscar-thread.c (struct ravenscar_thread_target)
3317         <pid_to_str>: Change return type.
3318         (ravenscar_thread_target::pid_to_str): Change return type.
3319         * procfs.c (class procfs_target) <pid_to_str>: Change return
3320         type.
3321         (procfs_target::pid_to_str): Change return type.
3322         (procfs_target::attach): Update.
3323         (procfs_target::detach): Update.
3324         (procfs_target::fetch_registers): Update.
3325         (procfs_target::store_registers): Update.
3326         (procfs_target::wait): Update.
3327         (procfs_target::files_info): Update.
3328         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3329         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3330         return type.
3331         (nto_procfs_target::pid_to_str): Change return type.
3332         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3333         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3334         return type.
3335         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3336         (exit_lwp): Update.
3337         (attach_proc_task_lwp_callback, get_detach_signal)
3338         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3339         (linux_nat_target::resume, wait_lwp, stop_callback)
3340         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3341         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3342         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3343         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3344         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3345         type.
3346         (inf_ptrace_target::attach): Update.
3347         (inf_ptrace_target::files_info): Update.
3348         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3349         type.
3350         (go32_nat_target::pid_to_str): Change return type.
3351         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3352         (gnu_nat_target::wait): Update.
3353         (gnu_nat_target::wait): Update.
3354         (gnu_nat_target::resume): Update.
3355         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3356         (fbsd_nat_target::wait): Update.
3357         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3358         type.
3359         (darwin_nat_target::attach): Update.
3360         * corelow.c (class core_target) <pid_to_str>: Change return type.
3361         (core_target::pid_to_str): Change return type.
3362         * target.c (normal_pid_to_str): Change return type.
3363         (default_pid_to_str): Likewise.
3364         (target_pid_to_str): Change return type.
3365         (target_translate_tls_address): Update.
3366         (target_announce_detach): Update.
3367         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3368         return type.
3369         (bsd_uthread_target::pid_to_str): Change return type.
3370         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3371         type.
3372         (bsd_kvm_target::pid_to_str): Change return type.
3373         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3374         return type.
3375         (aix_thread_target::pid_to_str): Change return type.
3376         * target.h (struct target_ops) <pid_to_str>: Change return type.
3377         (target_pid_to_str, normal_pid_to_str): Likewise.
3378         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3379         type.
3380         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3381         type.
3382         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3383         return type.
3384         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3385         type.
3386         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3387         type.
3388         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3389         return type.
3390
3391 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3392
3393         * NEWS: Mention that the new default MI version is 3.  Mention
3394         changes to the output of commands and events that deal with
3395         multi-location breakpoints.
3396         * breakpoint.c: Include "mi/mi-out.h".
3397         (print_one_breakpoint): Change output syntax if using MI version
3398         >= 3.
3399         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3400         New.
3401         (mi_multi_location_breakpoint_output_fixed): New.
3402         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3403         (mi_cmd_fix_multi_location_breakpoint_output): New.
3404         (mi_multi_location_breakpoint_output_fixed): New.
3405         * mi/mi-cmds.c (mi_cmds): Register command
3406         -fix-multi-location-breakpoint-output.
3407         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3408         interpreter "mi".
3409
3410 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3411
3412         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3413         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3414         instantiate mi_ui_out based on interpreter name.
3415         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3416         * mi/mi-main.c (mi_load_progress): Likewise.
3417
3418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3419
3420         * NEWS: Combine separate "New targets" sections for 8.3.
3421
3422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3423
3424         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3425         (ppcfbsd_init_abi): Install gdbarch
3426         "fetch_tls_load_module_address" and "get_thread_local_address"
3427         methods.
3428
3429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3430
3431         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3432         (riscv_fbsd_init_abi): Install gdbarch
3433         "fetch_tls_load_module_address" and "get_thread_local_address"
3434         methods.
3435
3436 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3437
3438         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3439         (i386fbsd_init_abi): Install gdbarch
3440         "fetch_tls_load_module_address" and "get_thread_local_address"
3441         methods.
3442
3443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3444
3445         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3446         (amd64fbsd_init_abi): Install gdbarch
3447         "fetch_tls_load_module_address" and "get_thread_local_address"
3448         methods.
3449
3450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3451
3452         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3453         (struct fbsd_pspace_data): New type.
3454         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3455         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3456         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3457         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3458         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3459
3460 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3461
3462         * gdbtypes.c (lookup_struct_elt): New function.
3463         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3464         * gdbtypes.h (struct struct_elt): New type.
3465         (lookup_struct_elt): New prototype.
3466
3467 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3468
3469         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3470         remove disabled code block.
3471
3472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3473
3474         * gdbarch.sh (get_thread_local_address): New method.
3475         * gdbarch.h, gdbarch.c: Regenerate.
3476         * target.c (target_translate_tls_address): Use
3477         gdbarch_get_thread_local_address if present instead of
3478         target::get_thread_local_address.
3479
3480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3481
3482         * target.h (target::get_thread_local_address): Update comment.
3483
3484 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3485
3486         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3487         objfile->separate_debug_objfile_backlink if not NULL.
3488
3489 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3490
3491         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3492         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3493         (amd64bsd_store_inferior_registers): Likewise.
3494         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3495         Enable segment base registers.
3496         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3497         PT_GETFSBASE and PT_GETGSBASE.
3498         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3499         PT_SETGSBASE.
3500         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3501         segment base registers.
3502         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3503
3504 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3505
3506         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3507         Update calls to i386_target_description to add 'segments'
3508         parameter.
3509         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3510         add segment base registers.
3511         * arch/i386.c (i386_create_target_description): Add 'segments'
3512         parameter to enable segment base registers.
3513         * arch/i386.h (i386_create_target_description): Likewise.
3514         * features/i386/32bit-segments.xml: New file.
3515         * features/i386/32bit-segments.c: Generate.
3516         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3517         call to i386_target_description to add 'segments' parameter.
3518         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3519         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3520         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3521         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3522         if feature is present.
3523         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3524         Add 'segments' parameter to call to i386_target_description.
3525         (i386_target_description): Add 'segments' parameter to enable
3526         segment base registers.
3527         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3528         to call to i386_target_description.
3529         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3530         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3531         Define I386_NUM_REGS.
3532         (i386_target_description): Add 'segments' parameter to enable
3533         segment base registers.
3534
3535 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3536
3537         PR/24325
3538         * source-cache.c: #undef open and close, to avoid unresolved
3539         externals during linking.
3540
3541 2019-03-12  Tom Tromey  <tromey@adacore.com>
3542
3543         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3544         const.  Add initializers.
3545         (_initialize_remote): Don't initialize ptid globals.
3546
3547 2019-03-12  Pedro Alves  <palves@redhat.com>
3548
3549         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3550
3551 2019-03-12  Pedro Alves  <palves@redhat.com>
3552
3553         * cp-name-parser.y (main): Remove unused 'len' variable.
3554
3555 2019-03-12  Tom Tromey  <tromey@adacore.com>
3556
3557         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3558         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3559
3560 2019-03-12  Tom Tromey  <tromey@adacore.com>
3561
3562         * linux-nat.c (iterate_over_lwps): Update.
3563         (stop_callback): Remove parameter.
3564         (stop_wait_callback, detach_callback, resume_set_callback)
3565         (select_singlestep_lwp_callback, set_ignore_sigint)
3566         (status_callback, resumed_callback, resume_clear_callback)
3567         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3568         data parameter.
3569         (linux_nat_target::detach, linux_nat_target::resume)
3570         (linux_stop_and_wait_all_lwps, select_event_lwp)
3571         (linux_nat_filter_event, linux_nat_wait_1)
3572         (linux_nat_target::kill, linux_nat_target::stop)
3573         (linux_nat_target::stop): Update.
3574         (linux_nat_resume_callback): Change type.
3575         (resume_stopped_resumed_lwps, count_events_callback)
3576         (select_event_lwp_callback): Likewise.
3577         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3578         * arm-linux-nat.c (struct update_registers_data): Remove.
3579         (update_registers_callback): Change type.
3580         (arm_linux_insert_hw_breakpoint1): Update.
3581         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3582         parameter.
3583         (x86_linux_dr_set_addr): Update.
3584         (x86_linux_dr_set_control): Update.
3585         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3586         (iterate_over_lwps): Use gdb::function_view.
3587         * nat/aarch64-linux-hw-point.c (struct
3588         aarch64_dr_update_callback_param): Remove.
3589         (debug_reg_change_callback): Change type.
3590         (aarch64_notify_debug_reg_change): Update.
3591         * s390-linux-nat.c (s390_refresh_per_info): Update.
3592
3593 2019-03-11  Tom Tromey  <tromey@adacore.com>
3594
3595         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3596         redundant assignment to "this_cu".
3597
3598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3599
3600         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3601
3602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3603
3604         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3605         from...
3606         (rank_one_type): ... this.
3607
3608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3609
3610         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3611         from...
3612         (rank_one_type): ... this.
3613
3614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3615
3616         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3617         from...
3618         (rank_one_type): ... this.
3619
3620 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3621
3622         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3623         from...
3624         (rank_one_type): ... this.
3625
3626 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3627
3628         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3629         from...
3630         (rank_one_type): ... this.
3631
3632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3633
3634         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3635         from...
3636         (rank_one_type): ... this.
3637
3638 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3639
3640         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3641         from...
3642         (rank_one_type): ... this.
3643
3644 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3645
3646         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3647         from...
3648         (rank_one_type): ... this.
3649
3650 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3651
3652         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3653         from...
3654         (rank_one_type): ... this.
3655
3656 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3657
3658         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3659         from...
3660         (rank_one_type): ... this.
3661
3662 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3663
3664         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3665         from...
3666         (rank_one_type): ... this.
3667
3668 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3669
3670         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3671         from...
3672         (rank_one_type): ... this.
3673
3674 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3675
3676         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3677         inferior-events' shows the example events.
3678
3679 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3680
3681         Support styling on native MS-Windows console
3682
3683         PR/24315
3684         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3685         on MS-Windows if $TERM is not defined.
3686
3687         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3688
3689         * posix-hdep.c (gdb_console_fputs):
3690         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3691         functions.
3692         * ui-file.h (gdb_console_fputs): Add prototype.
3693
3694         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3695         back to fputs only if the former returns zero.
3696
3697 2019-03-07  Tom Tromey  <tom@tromey.com>
3698
3699         * symmisc.c (print_symbol_bcache_statistics): Update.
3700         (print_objfile_statistics): Update.
3701         * symfile.c (allocate_symtab): Update.
3702         * stabsread.c: Don't include bcache.h.
3703         * psymtab.h (struct psymbol_bcache): Don't declare.
3704         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3705         (psymbol_bcache_init, psymbol_bcache_free)
3706         (psymbol_bcache_get_bcache): Don't declare.
3707         * psymtab.c (struct psymbol_bcache): Remove.
3708         (psymtab_storage::psymtab_storage): Update.
3709         (psymtab_storage::~psymtab_storage): Update.
3710         (psymbol_bcache_init, psymbol_bcache_free)
3711         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3712         (add_psymbol_to_bcache): Update.
3713         (allocate_psymtab): Update.
3714         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3715         macro_cache>: No longer pointers.
3716         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3717         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3718         * macrotab.c (macro_bcache): Update.
3719         * macroexp.c: Don't include bcache.h.
3720         * gdbtypes.c (check_types_worklist): Update.
3721         (types_deeply_equal): Remove TRY/CATCH.  Update.
3722         * elfread.c (elf_symtab_read): Update.
3723         * dwarf2read.c: Don't include bcache.h.
3724         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3725         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3726         (print_bcache_statistics, bcache_memory_used): Don't declare.
3727         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3728         methods.  Rename all data members.
3729         * bcache.c (struct bcache): Move to bcache.h.
3730         (bcache::expand_hash_table): Rename from expand_hash_table.
3731         (bcache): Remove.
3732         (bcache::insert): Rename from bcache_full.
3733         (bcache::compare): Rename from bcache_compare.
3734         (bcache_xmalloc): Remove.
3735         (bcache::~bcache): Rename from bcache_xfree.
3736         (bcache::print_statistics): Rename from print_bcache_statistics.
3737         (bcache::memory_used): Rename from bcache_memory_used.
3738
3739 2019-03-07  Pedro Alves  <palves@redhat.com>
3740
3741         * infrun.c (normal_stop): Also check for
3742         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3743
3744 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         * f-lang.c (value_from_host_double): Moved to...
3747         * value.c (value_from_host_double): ...here.
3748         * value.h (value_from_host_double): Declare.
3749         * guile/scm-math.c (vlscm_convert_typed_number): Use
3750         value_from_host_double.
3751         (vlscm_convert_number): Likewise.
3752         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3753         * python/py-value.c (convert_value_from_python): Likewise.
3754
3755 2019-03-06  Tom Tromey  <tom@tromey.com>
3756
3757         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3758
3759 2019-03-06  Tom Tromey  <tom@tromey.com>
3760
3761         * utils.h (free_current_contents): Don't declare.
3762         * utils.c (free_current_contents): Remove.
3763
3764 2019-03-06  Tom Tromey  <tom@tromey.com>
3765
3766         * top.c (quit_force): Update.
3767         * main.c (captured_command_loop): Update.
3768         * common/new-op.c (operator new): Update.
3769         * common/common-exceptions.c (struct catcher)
3770         <save_cleanup_chain>: Remove member.
3771         (exceptions_state_mc_init): Update.
3772         (exception_try_scope_entry): Return nullptr.
3773         (exception_try_scope_exit, exception_rethrow)
3774         (throw_exception_sjlj, throw_exception_cxx): Update.
3775         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3776         (all_cleanups, do_cleanups, discard_cleanups)
3777         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3778         (restore_cleanups, restore_final_cleanups): Don't declare.
3779         (do_final_cleanups): Remove parameter.
3780         * common/cleanups.c (cleanup_chain, make_cleanup)
3781         (make_cleanup_dtor, all_cleanups, do_cleanups)
3782         (discard_my_cleanups, discard_cleanups)
3783         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3784         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3785         (null_cleanup): Remove.
3786         (do_final_cleanups): Remove parameter.
3787
3788 2019-03-06  Tom Tromey  <tom@tromey.com>
3789
3790         * remote.c (remote_target::remote_parse_stop_reply): Use
3791         unique_xmalloc_ptr.
3792
3793 2019-03-06  Tom Tromey  <tom@tromey.com>
3794
3795         * stabsread.c (struct stabs_field_info): Rename from field_info.
3796         <list, fnlist>: Add initializers.
3797         <obstack>: New member.
3798         (read_member_functions, read_struct_fields, read_baseclasses):
3799         Allocate on obstack.  Don't use cleanups.
3800         (read_one_struct_field, read_member_functions, read_struct_fields)
3801         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3802         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3803         (read_struct_type): Update.
3804
3805 2019-03-06  Tom Tromey  <tom@tromey.com>
3806
3807         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3808         * common/filestuff.h (make_cleanup_close): Don't declare.
3809         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3810         Remove.
3811
3812 2019-03-06  Tom Tromey  <tom@tromey.com>
3813
3814         * solib-aix.c: Use make_scope_exit.
3815
3816 2019-03-06  Tom Tromey  <tom@tromey.com>
3817
3818         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3819         Use make_scope_exit.
3820
3821 2019-03-06  Tom Tromey  <tom@tromey.com>
3822
3823         * solib-svr4.c (disable_probes_interface): Remove parameter.
3824         (svr4_handle_solib_event): Use make_scope_exit.
3825
3826 2019-03-06  Tom Tromey  <tom@tromey.com>
3827
3828         * remote.c (struct stop_reply_deleter): Remove.
3829         (stop_reply_up): Update.
3830         (struct stop_reply): Derive from notif_event.  Don't typedef.
3831         <regcache>: Now a std::vector.
3832         (stop_reply_xfree): Remove.
3833         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3834         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3835         (remote_target::discard_pending_stop_replies): Use delete.
3836         (remote_target::remote_parse_stop_reply): Update.
3837         (remote_target::process_stop_reply): Update.
3838         * remote-notif.h (struct notif_event): Add virtual destructor.
3839         Remove "dtr" member.
3840         (struct notif_client) <alloc_event>: Return a unique_ptr.
3841         (notif_event_xfree): Don't declare.
3842         (notif_event_up): New typedef.
3843         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3844         (notif_event_xfree, do_notif_event_xfree): Remove.
3845         (remote_notif_state_xfree): Update.
3846
3847 2019-03-06  Tom Tromey  <tom@tromey.com>
3848
3849         * infrun.c (displaced_step_clear_cleanup): Now a
3850         forward_scope_exit type.
3851         (displaced_step_prepare_throw): Update.
3852         (displaced_step_fixup): Update.
3853
3854 2019-03-06  Tom Tromey  <tom@tromey.com>
3855
3856         * inferior.h (class inferior): Update comment.
3857         * gdbthread.h (class thread_info): Update comment.
3858
3859 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3860             Tom Tromey  <tom@tromey.com>
3861
3862         * stabsread.h (struct stab_section_list): Remove.
3863         (coffstab_build_psymtabs): Update.
3864         * dbxread.c (symbuf_sections): Now a std::vector.
3865         (sect_idx): New global.
3866         (fill_symbuf): Update.
3867         (coffstab_build_psymtabs): Change type of stabsects parameter.
3868         Update.
3869         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3870         std::vector.
3871         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3872         (coff_locate_sections): Update.
3873         (coff_symfile_read): Remove cleanups.  Update.
3874         (init_stringtab): Add storage parameter.
3875         (free_stringtab, free_stringtab_cleanup): Remove.
3876         (init_lineno): Add storage parameter.
3877         (free_linetab, free_linetab_cleanup): Remove.
3878
3879 2019-03-06  Pedro Alves  <palves@redhat.com>
3880
3881         * linux-fork.c (fork_info::clobber_regs): Delete.
3882         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3883         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3884         comment.  Adjust.
3885         (scoped_switch_fork_info::scoped_switch_fork_info)
3886         (checkpoint_command, linux_fork_context): Adjust
3887         fork_save_infrun_state calls.
3888
3889 2019-03-06  Pedro Alves  <palves@redhat.com>
3890
3891         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3892         (inf_has_multiple_threads): Return 'bool' and rewrite using
3893         inferior_info::threads().
3894
3895 2019-03-06  Pedro Alves  <palves@redhat.com>
3896
3897         * linux-fork.c: Include <list>.
3898         (fork_list): Now a std::list instance.
3899         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3900         (forks_exist_p, find_last_fork): Adjust.
3901         (new_fork): Delete.
3902         (one_fork_p): New.
3903         (add_fork): Adjust.
3904         (free_fork): Delete, folded into fork_info::~fork_info().
3905         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3906         Adjust.
3907         (init_fork_list): Delete.
3908         (linux_fork_killall, linux_fork_mourn_inferior)
3909         (linux_fork_detach, info_checkpoints_command): Adjust.
3910         (_initialize_linux_fork): No longer call init_fork_list.
3911
3912 2019-03-06  Pedro Alves  <palves@redhat.com>
3913
3914         * linux-fork.c (new_fork): New, split out of ...
3915         (add_fork): ... this.  Return void.  Move "first fork" special
3916         case from here, to ...
3917         (checkpoint_command): ... here.
3918         * linux-linux.h (add_fork): Return void.
3919
3920 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3921
3922         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3923
3924 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3925             Chris January  <chris.january@arm.com>
3926             David Lecomber  <david.lecomber@arm.com>
3927
3928         * f-exp.y: New token, UNOP_INTRINSIC.
3929         (exp): New pattern using UNOP_INTRINSIC token.
3930         (f77_keywords): Add 'abs' keyword.
3931         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3932         (value_from_host_double): New function.
3933         (evaluate_subexp_f): Support UNOP_ABS.
3934
3935 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3938         types.
3939
3940 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3943         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3944         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3945
3946 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3949
3950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3951             Chris January  <chris.january@arm.com>
3952
3953         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3954         * f-exp.y: Define 'KIND' token.
3955         (exp): New pattern for KIND expressions.
3956         (ptype): Handle types with a kind extension.
3957         (direct_abs_decl): Extend to spot kind extensions.
3958         (f77_keywords): Add 'kind' to the list.
3959         (push_kind_type): New function.
3960         (convert_to_kind_type): New function.
3961         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3962         * parse.c (operator_length_standard): Likewise.
3963         * parser-defs.h (enum type_pieces): Add tp_kind.
3964         * std-operator.def: Add UNOP_KIND.
3965
3966 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * f-exp.y (f_parse): Set yydebug.
3969
3970 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3971
3972         * f-lang.c (evaluate_subexp_f): New function.
3973         (exp_descriptor_f): New global.
3974         (f_language_defn): Use exp_descriptor_f instead of
3975         exp_descriptor_standard.
3976
3977 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3978
3979         * f-exp.y (struct token): Add comments.
3980         (dot_ops): Remove uppercase versions and the end marker.
3981         (f77_keywords): Likewise.
3982         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3983         entries in the dot_ops array are case insensitive, and use
3984         strncasecmp to compare strings.  Also some whitespace cleanup in
3985         this area.  Similar for the f77_keywords array, except entries in
3986         this list might be case sensitive.
3987
3988 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * f-exp.y (struct f77_boolean_val): Add comments.
3991         (boolean_values): Remove uppercase versions, and end marker.
3992         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3993         and use strncasecmp to achieve case insensitivity.  Additionally,
3994         perform whitespace cleanup around this code.
3995
3996 2019-03-06  Tom Tromey  <tromey@adacore.com>
3997
3998         * remote-sim.c (gdbsim_target_open): Use result of
3999         gdb_argv::release.
4000
4001 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4002         Dirk Schubert  <dirk.schubert@arm.com>
4003         Chris January  <chris.january@arm.com>
4004
4005         * eval.c (evaluate_subexp_standard): Call Fortran argument
4006         wrapping logic.
4007         * f-lang.c (struct value): A value which can be passed into a
4008         Fortran function call.
4009         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4010         where appropriate.
4011         (struct type): Value ready for a Fortran function call.
4012         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4013         is needed.
4014         * f-lang.h (fortran_argument_convert): Declaration.
4015         (fortran_preserve_arg_pointer): Declaration.
4016         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4017
4018 2019-03-05  Tom Tromey  <tromey@adacore.com>
4019
4020         * python/py-prettyprint.c (print_string_repr): Remove #if.
4021         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4022
4023 2019-03-05  Tom Tromey  <tromey@adacore.com>
4024
4025         * target.c (the_dummy_target): Move later.  Change type to
4026         "dummy_target".
4027         (initialize_targets): Don't initialize the_dummy_target.
4028
4029 2019-03-05  Tom Tromey  <tromey@adacore.com>
4030
4031         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4032         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4033
4034 2019-03-05  Tom Tromey  <tromey@adacore.com>
4035
4036         * windows-nat.c (windows_nat_target::attach)
4037         (windows_nat_target::detach): Don't call gdb_flush.
4038         * valprint.c (generic_val_print, val_print, val_print_string):
4039         Don't call gdb_flush.
4040         * utils.c (defaulted_query): Don't call gdb_flush.
4041         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4042         * target.c (target_announce_detach): Don't call gdb_flush.
4043         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4044         * remote.c (extended_remote_target::attach): Don't call
4045         gdb_flush.
4046         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4047         * printcmd.c (do_examine): Don't call gdb_flush.
4048         (info_display_command): Don't call gdb_flush.
4049         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4050         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4051         * memattr.c (info_mem_command): Don't call gdb_flush.
4052         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4053         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4054         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4055         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4056         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4057         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4058         (gnu_nat_target::detach): Don't call gdb_flush.
4059         * f-valprint.c (f_val_print): Don't call gdb_flush.
4060         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4061         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4062         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4063         gdb_flush.
4064         * c-valprint.c (c_val_print): Don't call gdb_flush.
4065         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4066
4067 2019-03-05  Tom Tromey  <tromey@adacore.com>
4068
4069         * varobj.c (update_dynamic_varobj_children): Update.
4070         (install_default_visualizer): Use reset, not release.
4071         * value.c (set_internalvar): Update.
4072         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4073         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4074         ATTRIBUTE_UNUSED_RESULT.
4075
4076 2019-03-05  Tom Tromey  <tromey@adacore.com>
4077
4078         * remote.c (class scoped_remote_fd) <release>: Add
4079         ATTRIBUTE_UNUSED_RESULT.
4080
4081 2019-03-05  Tom Tromey  <tromey@adacore.com>
4082
4083         * macroexp.c (struct macro_buffer) <release>: Add
4084         ATTRIBUTE_UNUSED_RESULT.
4085
4086 2019-03-05  Tom Tromey  <tromey@adacore.com>
4087
4088         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4089         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4090         ATTRIBUTE_UNUSED_RESULT.
4091
4092 2019-03-05  Tom Tromey  <tromey@adacore.com>
4093
4094         * common/scoped_fd.h (class scoped_fd) <release>: Add
4095         ATTRIBUTE_UNUSED_RESULT.
4096
4097 2019-03-05  Tom Tromey  <tromey@adacore.com>
4098
4099         * parser-defs.h (struct parser_state) <release>: Add
4100         ATTRIBUTE_UNUSED_RESULT.
4101
4102 2019-03-05  Tom Tromey  <tromey@adacore.com>
4103
4104         * utils.h (class gdb_argv) <release>: Add
4105         ATTRIBUTE_UNUSED_RESULT.
4106         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4107
4108 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4109
4110         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4111         for-loop range, to avoid compiler warnings.
4112
4113         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4114         avoid compiler warnings about unused variables.
4115
4116         * NEWS: Mention end of support for native debugging on MS-Windows
4117         before XP.
4118
4119         PR gdb/24292
4120         * common/netstuff.c:
4121         * gdbserver/gdbreplay.c
4122         * gdbserver/remote-utils.c:
4123         * ser-tcp.c:
4124         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4125         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4126         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4127         'getaddrinfo' and 'freeaddrinfo' were not available before
4128         Windows XP, and mingw.org's MinGW headers by default define
4129         _WIN32_WINNT to 0x500.
4130
4131 2019-03-01  Gary Benson <gbenson@redhat.com>
4132
4133         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4134
4135 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4136             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4137
4138         PR gdb/8527
4139         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4140         set_sigint_trap, clear_sigint_trap.
4141
4142 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4143
4144         * target.c (target_detach): Clear the regcache and the
4145         frame cache.
4146
4147 2019-02-27  Pedro Alves  <palves@redhat.com>
4148
4149         * utils.c (set_screen_size): When we cap the height/width sizes,
4150         tweak the corresponding command variable to show "unlimited":
4151
4152 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4153             Pedro Alves  <palves@redhat.com>
4154
4155         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4156         before calling rl_set_screen_size.
4157
4158 2019-02-27  Tom Tromey  <tromey@adacore.com>
4159
4160         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4161         define.
4162         * python/py-value.c: Remove Python 2.4 workaround.
4163         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4164         workaround.
4165         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4166         Python 2.4 workaround.
4167         * python/python-internal.h: Remove Python 2.4 comment.
4168         (Py_ssize_t): Don't define.
4169         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4170         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4171         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4172         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4173         * python/python.c (do_start_initialization): Remove Python 2.4
4174         workaround.
4175         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4176         (print_children): Remove Python 2.4 workaround.
4177         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4178         workaround.
4179         (CHARBUFFERPROC_NAME): Remove.
4180         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4181         Python 2.4 workaround.
4182
4183 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4184
4185         * NEWS: Note minimum Python version.
4186
4187 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4188
4189         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4190         code from these functions.  Remove corresponding ifdefs.  Use
4191         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4192         Remove gotos and target of gotos.
4193         (infpy_search_memory): Likewise.
4194
4195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4196
4197         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4198         (hppa_gdbarch_init): Don't register deleted functions with
4199         gdbarch.
4200
4201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4202
4203         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4204         (h8300_unwind_sp): Delete.
4205         (h8300_dummy_id): Delete.
4206         (h8300_gdbarch_init): Don't register deleted functions with
4207         gdbarch.
4208
4209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4212         (ft32_unwind_pc): Delete.
4213         (ft32_unwind_sp): Delete.
4214         (ft32_gdbarch_init): Don't register deleted functions with
4215         gdbarch.
4216
4217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4218
4219         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4220         (frv_unwind_pc): Delete.
4221         (frv_unwind_sp): Delete.
4222         (frv_gdbarch_init): Don't register deleted functions with
4223         gdbarch.
4224
4225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4226
4227         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4228         (riscv_unwind_pc): Delete.
4229         (riscv_unwind_sp): Delete.
4230         (riscv_gdbarch_init): Don't register deleted functions with
4231         gdbarch.
4232
4233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4234
4235         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4236         (csky_unwind_pc): Delete.
4237         (csky_unwind_sp): Delete.
4238         (csky_gdbarch_init): Don't register deleted functions with
4239         gdbarch.
4240
4241 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4242
4243         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4244         (cris_unwind_pc): Delete.
4245         (cris_unwind_sp): Delete.
4246         (cris_gdbarch_init): Don't register deleted functions with
4247         gdbarch.
4248
4249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4252         (bfin_unwind_pc): Delete.
4253         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4254
4255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4258         (arm_unwind_pc): Delete.
4259         (arm_unwind_sp): Delete.
4260         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4261
4262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4265         (arc_unwind_pc): Delete.
4266         (arc_unwind_sp): Delete.
4267         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4268
4269 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4270
4271         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4272         (alpha_unwind_pc): Delete.
4273         (alpha_gdbarch_init): Don't register deleted functions with
4274         gdbarch.
4275
4276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4277
4278         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4279         (aarch64_unwind_pc): Delete.
4280         (aarch64_unwind_sp): Delete.
4281         (aarch64_gdbarch_init): Don't register deleted functions with
4282         gdbarch.
4283
4284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4285
4286         * gdbtypes.c (type_align): Don't consider static members when
4287         computing structure alignment.
4288
4289 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4292         return 0 for other types.
4293         * arch-utils.c (default_type_align): Always return 0.
4294         * gdbarch.h: Regenerate.
4295         * gdbarch.sh (type_align): Extend comment.
4296         * gdbtypes.c (type_align): Add additional comments, always call
4297         gdbarch_type_align before applying the default rules.
4298         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4299         generic code will then apply a suitable default.
4300         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4301         types, return 0 for other types.
4302
4303 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4304
4305         * NEWS: Create a new section for the next release branch.
4306         Rename the section of the current branch, now that it has
4307         been cut.
4308
4309 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4310
4311         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4312         * version.in: Bump version to 8.3.50.DATE-git.
4313
4314 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4315
4316         * aix-thread.c (ptid_cmp): Remove unused variable.
4317         (get_signaled_thread): Likewise.
4318         (store_regs_user_thread): Likewise.
4319         (store_regs_kernel_thread): Likewise.
4320         (fetch_regs_kernel_thread): Remove shadowed variable.
4321
4322 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * features/riscv/32bit-cpu.xml: Add register numbers.
4325         * features/riscv/32bit-fpu.c: Regenerate.
4326         * features/riscv/32bit-fpu.xml: Add register numbers.
4327         * features/riscv/64bit-cpu.xml: Add register numbers.
4328         * features/riscv/64bit-fpu.c: Regenerate.
4329         * features/riscv/64bit-fpu.xml: Add register numbers.
4330
4331 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4332
4333         * NEWS: Mention two argument form of gdb.Value constructor.
4334         * python/py-value.c (convert_buffer_and_type_to_value): New
4335         function.
4336         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4337         Add support for handling an optional second argument.  Call
4338         convert_buffer_and_type_to_value as appropriate.
4339         * python/python-internal.h (Py_buffer_deleter): New struct.
4340         (Py_buffer_up): New typedef.
4341
4342 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4343
4344         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4345         instead of releasing ownership.
4346
4347 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4348
4349         * dwarf2read.c (open_and_init_dwp_file): Call
4350         elf_numsections instead of bfd_count_sections to initialize
4351         dwp_file->num_sections.
4352
4353 2019-02-25  Tom Tromey  <tromey@adacore.com>
4354
4355         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4356
4357 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4358
4359         * gcore.in: Add '--readnever' option when invoking GDB.
4360
4361 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4362
4363         * MAINTAINERS: Update my email address.
4364
4365 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4366
4367         * build-id.c (build_id_to_debug_bfd_1): New function.
4368         (build_id_to_debug_bfd): Look for separate debug file in
4369         sysroot.
4370
4371 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4372
4373         * gdbarch.sh: Update the copyright year range that is placed into
4374         generated files.
4375
4376 2019-02-22  Keith Seitz  <keiths@redhat.com>
4377
4378         PR symtab/23853
4379         * linespec.c (create_sals_line_offset): Search for the default
4380         symtab's filename instead of its fullname.
4381
4382 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4383
4384         * NEWS: Update style defaults.
4385
4386 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4387
4388         * main.c (captured_main_1): Disable styling in batch mode.
4389
4390 2019-02-20  Tom Tromey  <tom@tromey.com>
4391
4392         * symtab.c (symtab_symbol_info): Fix typos.
4393
4394 2019-02-20  Tom Tromey  <tromey@adacore.com>
4395
4396         * findcmd.c (_initialize_mem_search): Use upper case for
4397         metasyntactic variables.
4398
4399 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4400
4401         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4402         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4403
4404 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4405
4406         * top.h (source_file_name): Change to std::string.
4407         * top.c (source_file_name): Likewise.
4408         (command_line_input): Adjust.
4409         * cli/cli-script.c (script_from_file): Adjust.
4410
4411 2019-02-19  Tom Tromey  <tromey@adacore.com>
4412
4413         * ravenscar-thread.c
4414         (ravenscar_thread_target::update_thread_list): Don't call
4415         ada_build_task_list.
4416         * ada-lang.h (ada_build_task_list): Don't declare.
4417         * ada-tasks.c (struct ada_tasks_inferior_data)
4418         <task_list_valid_p>: Now bool.
4419         (read_known_tasks, ada_task_list_changed)
4420         (ada_tasks_invalidate_inferior_data): Update.
4421         (read_known_tasks_array): Return bool.
4422         (read_known_tasks_list): Likewise.
4423         (read_known_tasks): Return void.
4424         (ada_build_task_list): Now static.
4425
4426 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4429         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4430
4431 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4432
4433         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4434         variant for ada_tasks_pspace_data_handle and
4435         ada_tasks_inferior_data_handle.
4436         (ada_tasks_pspace_data_cleanup): New function.
4437         (ada_tasks_inferior_data_cleanup): New function.
4438
4439 2019-02-17  Tom Tromey  <tom@tromey.com>
4440
4441         * macrotab.h (macro_source_fullname): Return a std::string.
4442         * macrotab.c (macro_include, check_for_redefinition)
4443         (macro_undef, macro_lookup_definition, foreach_macro)
4444         (foreach_macro_in_scope): Update.
4445         (macro_source_fullname): Return a std::string.
4446         * macrocmd.c (show_pp_source_pos): Update.
4447
4448 2019-02-17  Tom Tromey  <tom@tromey.com>
4449
4450         * macrocmd.c (show_pp_source_pos): Style the file names.
4451
4452 2019-02-17  Tom Tromey  <tom@tromey.com>
4453
4454         PR tui/24197:
4455         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4456
4457 2019-02-17  Tom Tromey  <tom@tromey.com>
4458
4459         * ada-lang.c (user_select_syms): Use filtered printing.
4460         * utils.c (wrap_style): New global.
4461         (desired_style): Remove.
4462         (emit_style_escape): Add stream parameter.
4463         (set_output_style, reset_terminal_style, prompt_for_continue):
4464         Update.
4465         (flush_wrap_buffer): Only flush gdb_stdout.
4466         (wrap_here): Set wrap_style.
4467         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4468         treat escape sequences as a character.  Change when wrap buffer is
4469         flushed.
4470         (fputs_styled): Do not set the output style when the default is
4471         requested.
4472         * ui-style.h (struct ui_file_style) <is_default>: New method.
4473         * source.c (print_source_lines_base): Emit escape sequences in one
4474         piece.
4475
4476 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4477
4478         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4479         integers and enumeration types.
4480
4481 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4482
4483         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4484         instead of lookup_symbol_in_language
4485         (do_exact_match): New function.
4486         (ada_get_symbol_name_matcher): Return do_exact_match when
4487         doing a verbatim match.
4488
4489 2019-02-15  Tom Tromey  <tromey@adacore.com>
4490
4491         * ravenscar-thread.c (ravenscar_thread_target::resume)
4492         (ravenscar_thread_target::wait): Special case wildcard requests.
4493
4494 2019-02-15  Tom Tromey  <tromey@adacore.com>
4495
4496         * ravenscar-thread.c (base_ptid): Remove.
4497         (struct ravenscar_thread_target) <close>: New method.
4498         <m_base_ptid>: New member.
4499         <update_inferior_ptid, active_task, task_is_currently_active,
4500         runtime_initialized>: Declare methods.
4501         <ravenscar_thread_target>: Add constructor.
4502         (ravenscar_thread_target::task_is_currently_active)
4503         (ravenscar_thread_target::update_inferior_ptid)
4504         (ravenscar_runtime_initialized): Rename.  Now methods.
4505         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4506         (ravenscar_thread_target::update_thread_list): Update.
4507         (ravenscar_thread_target::active_task): Now method.
4508         (ravenscar_thread_target::store_registers)
4509         (ravenscar_thread_target::prepare_to_store)
4510         (ravenscar_thread_target::prepare_to_store)
4511         (ravenscar_thread_target::mourn_inferior): Update.
4512         (ravenscar_inferior_created): Use "new" to create target.
4513         (ravenscar_thread_target::get_ada_task_ptid): Update.
4514         (_initialize_ravenscar): Don't initialize base_ptid.
4515         (ravenscar_ops): Remove global.
4516
4517 2019-02-15  Tom Tromey  <tromey@adacore.com>
4518
4519         * target.h (push_target): Declare new overload.
4520         * target.c (push_target): New overload, taking an rvalue reference.
4521         * remote.c (remote_target::open_1): Use push_target overload.
4522         * corelow.c (core_target_open): Use push_target overload.
4523
4524 2019-02-15  Tom Tromey  <tromey@adacore.com>
4525
4526         * ravenscar-thread.c (is_ravenscar_task)
4527         (ravenscar_task_is_currently_active): Return bool.
4528         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4529         (_initialize_ravenscar): Remove "(void)".
4530         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4531         Return bool.
4532
4533 2019-02-15  Tom Tromey  <tromey@adacore.com>
4534
4535         * ravenscar-thread.c (ravenscar_runtime_initializer)
4536         (has_ravenscar_runtime, get_running_thread_id)
4537         (ravenscar_thread_target::resume): Fix indentation.
4538
4539 2019-02-15  Tom Tromey  <tromey@adacore.com>
4540
4541         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4542         from ravenscar_arch_ops.
4543         (sparc_ravenscar_ops::fetch_registers)
4544         (sparc_ravenscar_ops::store_registers): Now methods.
4545         (sparc_ravenscar_prepare_to_store): Remove.
4546         (sparc_ravenscar_ops): Redefine.
4547         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4548         methods and destructor.  Remove members.
4549         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4550         (ravenscar_thread_target::store_registers)
4551         (ravenscar_thread_target::prepare_to_store): Update.
4552         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4553         Remove.
4554         (struct ppc_ravenscar_powerpc_ops): Derive from
4555         ravenscar_arch_ops.
4556         (ppc_ravenscar_powerpc_ops::fetch_registers)
4557         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4558         (ppc_ravenscar_powerpc_ops): Redefine.
4559         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4560         (ppc_ravenscar_e500_ops::fetch_registers)
4561         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4562         (ppc_ravenscar_e500_ops): Redefine.
4563         * aarch64-ravenscar-thread.c
4564         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4565         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4566         (aarch64_ravenscar_fetch_registers)
4567         (aarch64_ravenscar_store_registers): Now methods.
4568         (aarch64_ravenscar_ops): Redefine.
4569
4570 2019-02-15  Tom Tromey  <tromey@adacore.com>
4571
4572         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4573         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4574         (ravenscar_thread_target::stopped_by_watchpoint)
4575         (ravenscar_thread_target::stopped_data_address)
4576         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4577
4578 2019-02-15  Tom Tromey  <tromey@adacore.com>
4579
4580         * ravenscar-thread.c: Fix some typos.
4581
4582 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4583             Tom Tromey  <tromey@adacore.com>
4584
4585         * ada-lang.c (ada_exception_sal): Change addr_string to a
4586         std::string.
4587         (create_ada_exception_catchpoint): Update.
4588
4589 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4590             Tom Tromey  <tromey@adacore.com>
4591
4592         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4593         (bp_location_ops): Remove.
4594         (base_breakpoint_allocate_location): Update.
4595         (free_bp_location): Update.
4596         * ada-lang.c (class ada_catchpoint_location)
4597         <ada_catchpoint_location>: Remove ops parameter.
4598         (ada_catchpoint_location_dtor): Remove.
4599         (ada_catchpoint_location_ops): Remove.
4600         (allocate_location_exception): Update.
4601         * breakpoint.h (struct bp_location_ops): Remove.
4602         (class bp_location) <bp_location>: Remove bp_location_ops
4603         parameter.
4604         <~bp_location>: Add destructor.
4605         <ops>: Remove.
4606
4607 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4608             Pedro Alves  <palves@redhat.com>
4609
4610         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4611         'PATH_MAX'.
4612
4613 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4614             Samuel Thibault  <samuel.thibault@gnu.org>
4615             Thomas Schwinge  <thomas@codesourcery.com>
4616
4617         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4618         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4619
4620 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4621
4622         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4623         (check_empty): Use "const char *".
4624
4625         * gnu-nat.c (gnu_nat_target::detach): Instead of
4626         'detach_inferior (pid)' call
4627         'detach_inferior (find_inferior_pid (pid))'.
4628
4629         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4630         'nat/fork-inferior.o'.
4631         * gnu-nat.c: #include "nat/fork-inferior.h".
4632
4633         * gnu-nat.c (gnu_nat_target::detach): Instead of
4634         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4635         * gnu-nat.h: #include "inf-child.h".
4636         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4637         'i386_gnu_nat_target::fetch_registers'.
4638         (gnu_store_registers): Rename/move to
4639         'i386_gnu_nat_target::store_registers'.
4640
4641         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4642         * gnu-nat.h (mach_thread_info): New function.
4643         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4644
4645         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4646
4647 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4648
4649         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4650
4651 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4652
4653         * windows-nat.c (windows_add_thread): Add new parameter
4654         "main_thread_p" with default value set to false.  Update
4655         function documentation as well as all callers.
4656         (windows_delete_thread): Likewise.
4657         (fake_create_process): Update call to windows_add_thread.
4658         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4659         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4660         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4661         call to windows_delete_thread.
4662
4663 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4664
4665         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4666
4667 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4668
4669         * symfile.c (find_separate_debug_file): Use canonical path of
4670         sysroot with child_path instead of gdb_sysroot if it is valid.
4671
4672 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4673
4674         * symfile.c (find_separate_debug_file): Use child_path to
4675         determine if an object file is under a sysroot.
4676
4677 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4678
4679         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4680         unittests/child-path-selftests.c.
4681         * common/pathstuff.c (child_path): New function.
4682         * common/pathstuff.h (child_path): New prototype.
4683         * unittests/child-path-selftests.c: New file.
4684
4685 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4686
4687         * symfile.c (find_separate_debug_file): Look for separate debug
4688         files in debug directories under the sysroot.
4689
4690 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4691
4692         * symtab.h (struct minimal_symbol data_p): New const method.
4693         (struct minimal_symbol text_p): Likewise.
4694         * symtab.c (output_source_filename): Use file name style
4695         to print file name.
4696         (print_symbol_info): Likewise.
4697         (print_msymbol_info): Use address style to print addresses.
4698         Use function name style to print executable text symbols.
4699         (expand_symtab_containing_pc): Use data_p.
4700         (find_pc_sect_compunit_symtab): Likewise.
4701
4702 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4703
4704         * breakpoint.c (describe_other_breakpoints): Use address style
4705         to print addresses.
4706         (say_where): Likewise.
4707
4708 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4709
4710         * ada-typeprint.c (print_func_type): Print function name
4711         style to print function name.
4712         * c-typeprint.c (c_print_type_1): Likewise.
4713
4714 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4715
4716         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4717         for execve.
4718
4719 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4720
4721         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4722         type_stack.
4723
4724 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4725
4726         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4727         TYPE_CODE_REF types.
4728
4729 2019-02-08  Jim Wilson  <jimw@sifive.com>
4730
4731         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4732         (riscv_linux_fregset): New.
4733         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4734
4735 2019-02-07  Tom Tromey  <tom@tromey.com>
4736
4737         * thread.c (thread_cancel_execution_command): Update.
4738         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4739         methods.
4740         (struct thread_fsm_ops): Remove.
4741         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4742         (thread_fsm_should_stop, thread_fsm_return_value)
4743         (thread_fsm_set_finished, thread_fsm_finished_p)
4744         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4745         Don't declare.
4746         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4747         * infrun.c (clear_proceed_status_thread)
4748         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4749         (print_stop_event): Update.
4750         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4751         Add constructor.
4752         (step_command_fsm_ops): Remove.
4753         (new_step_command_fsm): Remove.
4754         (step_1): Update.
4755         (step_command_fsm::should_stop): Rename from
4756         step_command_fsm_should_stop.
4757         (step_command_fsm::clean_up): Rename from
4758         step_command_fsm_clean_up.
4759         (step_command_fsm::do_async_reply_reason): Rename from
4760         step_command_fsm_async_reply_reason.
4761         (struct until_next_fsm): Inherit from thread_fsm.  Add
4762         constructor.
4763         (until_next_fsm_ops): Remove.
4764         (new_until_next_fsm): Remove.
4765         (until_next_fsm::should_stop): Rename from
4766         until_next_fsm_should_stop.
4767         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4768         (until_next_fsm::do_async_reply_reason): Rename from
4769         until_next_fsm_async_reply_reason.
4770         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4771         constructor.  Change type of breakpoint.
4772         (finish_command_fsm_ops): Remove.
4773         (new_finish_command_fsm): Remove.
4774         (finish_command_fsm::should_stop): Rename from
4775         finish_command_fsm_should_stop.
4776         (finish_command_fsm::clean_up): Rename from
4777         finish_command_fsm_clean_up.
4778         (finish_command_fsm::return_value): Rename from
4779         finish_command_fsm_return_value.
4780         (finish_command_fsm::do_async_reply_reason): Rename from
4781         finish_command_fsm_async_reply_reason.
4782         (finish_command): Update.
4783         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4784         Add constructor.
4785         (call_thread_fsm_ops): Remove.
4786         (call_thread_fsm::call_thread_fsm): Rename from
4787         new_call_thread_fsm.
4788         (call_thread_fsm::should_stop): Rename from
4789         call_thread_fsm_should_stop.
4790         (call_thread_fsm::should_notify_stop): Rename from
4791         call_thread_fsm_should_notify_stop.
4792         (run_inferior_call, call_function_by_hand_dummy): Update.
4793         * cli/cli-interp.c (should_print_stop_to_console): Update.
4794         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4795         Add constructor.  Change type of location_breakpoint,
4796         caller_breakpoint.
4797         (until_break_fsm_ops): Remove.
4798         (new_until_break_fsm): Remove.
4799         (until_break_fsm::should_stop): Rename from
4800         until_break_fsm_should_stop.
4801         (until_break_fsm::clean_up): Rename from
4802         until_break_fsm_clean_up.
4803         (until_break_fsm::do_async_reply_reason): Rename from
4804         until_break_fsm_async_reply_reason.
4805         (until_break_command): Update.
4806         * thread-fsm.c: Remove.
4807         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4808
4809 2019-02-07  Tom Tromey  <tom@tromey.com>
4810
4811         * yy-remap.h: Add include guard.
4812         * xtensa-tdep.h: Add include guard.
4813         * xcoffread.h: Rename include guard.
4814         * varobj-iter.h: Add include guard.
4815         * tui/tui.h: Rename include guard.
4816         * tui/tui-winsource.h: Rename include guard.
4817         * tui/tui-wingeneral.h: Rename include guard.
4818         * tui/tui-windata.h: Rename include guard.
4819         * tui/tui-win.h: Rename include guard.
4820         * tui/tui-stack.h: Rename include guard.
4821         * tui/tui-source.h: Rename include guard.
4822         * tui/tui-regs.h: Rename include guard.
4823         * tui/tui-out.h: Rename include guard.
4824         * tui/tui-layout.h: Rename include guard.
4825         * tui/tui-io.h: Rename include guard.
4826         * tui/tui-hooks.h: Rename include guard.
4827         * tui/tui-file.h: Rename include guard.
4828         * tui/tui-disasm.h: Rename include guard.
4829         * tui/tui-data.h: Rename include guard.
4830         * tui/tui-command.h: Rename include guard.
4831         * tic6x-tdep.h: Add include guard.
4832         * target/waitstatus.h: Rename include guard.
4833         * target/wait.h: Rename include guard.
4834         * target/target.h: Rename include guard.
4835         * target/resume.h: Rename include guard.
4836         * target-float.h: Rename include guard.
4837         * stabsread.h: Add include guard.
4838         * rs6000-tdep.h: Add include guard.
4839         * riscv-fbsd-tdep.h: Add include guard.
4840         * regformats/regdef.h: Rename include guard.
4841         * record.h: Rename include guard.
4842         * python/python.h: Rename include guard.
4843         * python/python-internal.h: Rename include guard.
4844         * python/py-stopevent.h: Rename include guard.
4845         * python/py-ref.h: Rename include guard.
4846         * python/py-record.h: Rename include guard.
4847         * python/py-record-full.h: Rename include guard.
4848         * python/py-record-btrace.h: Rename include guard.
4849         * python/py-instruction.h: Rename include guard.
4850         * python/py-events.h: Rename include guard.
4851         * python/py-event.h: Rename include guard.
4852         * procfs.h: Add include guard.
4853         * proc-utils.h: Add include guard.
4854         * p-lang.h: Add include guard.
4855         * or1k-tdep.h: Rename include guard.
4856         * observable.h: Rename include guard.
4857         * nto-tdep.h: Rename include guard.
4858         * nat/x86-linux.h: Rename include guard.
4859         * nat/x86-linux-dregs.h: Rename include guard.
4860         * nat/x86-gcc-cpuid.h: Add include guard.
4861         * nat/x86-dregs.h: Rename include guard.
4862         * nat/x86-cpuid.h: Rename include guard.
4863         * nat/ppc-linux.h: Rename include guard.
4864         * nat/mips-linux-watch.h: Rename include guard.
4865         * nat/linux-waitpid.h: Rename include guard.
4866         * nat/linux-ptrace.h: Rename include guard.
4867         * nat/linux-procfs.h: Rename include guard.
4868         * nat/linux-osdata.h: Rename include guard.
4869         * nat/linux-nat.h: Rename include guard.
4870         * nat/linux-namespaces.h: Rename include guard.
4871         * nat/linux-btrace.h: Rename include guard.
4872         * nat/glibc_thread_db.h: Rename include guard.
4873         * nat/gdb_thread_db.h: Rename include guard.
4874         * nat/gdb_ptrace.h: Rename include guard.
4875         * nat/fork-inferior.h: Rename include guard.
4876         * nat/amd64-linux-siginfo.h: Rename include guard.
4877         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4878         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4879         * nat/aarch64-linux.h: Rename include guard.
4880         * nat/aarch64-linux-hw-point.h: Rename include guard.
4881         * mn10300-tdep.h: Add include guard.
4882         * mips-linux-tdep.h: Add include guard.
4883         * mi/mi-parse.h: Rename include guard.
4884         * mi/mi-out.h: Rename include guard.
4885         * mi/mi-main.h: Rename include guard.
4886         * mi/mi-interp.h: Rename include guard.
4887         * mi/mi-getopt.h: Rename include guard.
4888         * mi/mi-console.h: Rename include guard.
4889         * mi/mi-common.h: Rename include guard.
4890         * mi/mi-cmds.h: Rename include guard.
4891         * mi/mi-cmd-break.h: Rename include guard.
4892         * m2-lang.h: Add include guard.
4893         * location.h: Rename include guard.
4894         * linux-record.h: Rename include guard.
4895         * linux-nat.h: Add include guard.
4896         * linux-fork.h: Add include guard.
4897         * i386-darwin-tdep.h: Rename include guard.
4898         * hppa-linux-offsets.h: Add include guard.
4899         * guile/guile.h: Rename include guard.
4900         * guile/guile-internal.h: Rename include guard.
4901         * gnu-nat.h: Rename include guard.
4902         * gdb-stabs.h: Rename include guard.
4903         * frv-tdep.h: Add include guard.
4904         * f-lang.h: Add include guard.
4905         * event-loop.h: Add include guard.
4906         * darwin-nat.h: Rename include guard.
4907         * cp-abi.h: Rename include guard.
4908         * config/sparc/nm-sol2.h: Rename include guard.
4909         * config/nm-nto.h: Rename include guard.
4910         * config/nm-linux.h: Add include guard.
4911         * config/i386/nm-i386gnu.h: Rename include guard.
4912         * config/djgpp/nl_types.h: Rename include guard.
4913         * config/djgpp/langinfo.h: Rename include guard.
4914         * compile/gcc-cp-plugin.h: Add include guard.
4915         * compile/gcc-c-plugin.h: Add include guard.
4916         * compile/compile.h: Rename include guard.
4917         * compile/compile-object-run.h: Rename include guard.
4918         * compile/compile-object-load.h: Rename include guard.
4919         * compile/compile-internal.h: Rename include guard.
4920         * compile/compile-cplus.h: Rename include guard.
4921         * compile/compile-c.h: Rename include guard.
4922         * common/xml-utils.h: Rename include guard.
4923         * common/x86-xstate.h: Rename include guard.
4924         * common/version.h: Rename include guard.
4925         * common/vec.h: Rename include guard.
4926         * common/tdesc.h: Rename include guard.
4927         * common/selftest.h: Rename include guard.
4928         * common/scoped_restore.h: Rename include guard.
4929         * common/scoped_mmap.h: Rename include guard.
4930         * common/scoped_fd.h: Rename include guard.
4931         * common/safe-iterator.h: Rename include guard.
4932         * common/run-time-clock.h: Rename include guard.
4933         * common/refcounted-object.h: Rename include guard.
4934         * common/queue.h: Rename include guard.
4935         * common/ptid.h: Rename include guard.
4936         * common/print-utils.h: Rename include guard.
4937         * common/preprocessor.h: Rename include guard.
4938         * common/pathstuff.h: Rename include guard.
4939         * common/observable.h: Rename include guard.
4940         * common/netstuff.h: Rename include guard.
4941         * common/job-control.h: Rename include guard.
4942         * common/host-defs.h: Rename include guard.
4943         * common/gdb_wait.h: Rename include guard.
4944         * common/gdb_vecs.h: Rename include guard.
4945         * common/gdb_unlinker.h: Rename include guard.
4946         * common/gdb_unique_ptr.h: Rename include guard.
4947         * common/gdb_tilde_expand.h: Rename include guard.
4948         * common/gdb_sys_time.h: Rename include guard.
4949         * common/gdb_string_view.h: Rename include guard.
4950         * common/gdb_splay_tree.h: Rename include guard.
4951         * common/gdb_setjmp.h: Rename include guard.
4952         * common/gdb_ref_ptr.h: Rename include guard.
4953         * common/gdb_optional.h: Rename include guard.
4954         * common/gdb_locale.h: Rename include guard.
4955         * common/gdb_assert.h: Rename include guard.
4956         * common/filtered-iterator.h: Rename include guard.
4957         * common/filestuff.h: Rename include guard.
4958         * common/fileio.h: Rename include guard.
4959         * common/environ.h: Rename include guard.
4960         * common/common-utils.h: Rename include guard.
4961         * common/common-types.h: Rename include guard.
4962         * common/common-regcache.h: Rename include guard.
4963         * common/common-inferior.h: Rename include guard.
4964         * common/common-gdbthread.h: Rename include guard.
4965         * common/common-exceptions.h: Rename include guard.
4966         * common/common-defs.h: Rename include guard.
4967         * common/common-debug.h: Rename include guard.
4968         * common/cleanups.h: Rename include guard.
4969         * common/buffer.h: Rename include guard.
4970         * common/btrace-common.h: Rename include guard.
4971         * common/break-common.h: Rename include guard.
4972         * cli/cli-utils.h: Rename include guard.
4973         * cli/cli-style.h: Rename include guard.
4974         * cli/cli-setshow.h: Rename include guard.
4975         * cli/cli-script.h: Rename include guard.
4976         * cli/cli-interp.h: Rename include guard.
4977         * cli/cli-decode.h: Rename include guard.
4978         * cli/cli-cmds.h: Rename include guard.
4979         * charset-list.h: Add include guard.
4980         * buildsym-legacy.h: Rename include guard.
4981         * bfin-tdep.h: Add include guard.
4982         * ax.h: Rename include guard.
4983         * arm-linux-tdep.h: Add include guard.
4984         * arm-fbsd-tdep.h: Add include guard.
4985         * arch/xtensa.h: Rename include guard.
4986         * arch/tic6x.h: Add include guard.
4987         * arch/i386.h: Add include guard.
4988         * arch/arm.h: Rename include guard.
4989         * arch/arm-linux.h: Rename include guard.
4990         * arch/arm-get-next-pcs.h: Rename include guard.
4991         * arch/amd64.h: Add include guard.
4992         * arch/aarch64-insn.h: Rename include guard.
4993         * arch-utils.h: Rename include guard.
4994         * annotate.h: Add include guard.
4995         * amd64-darwin-tdep.h: Rename include guard.
4996         * aarch64-linux-tdep.h: Add include guard.
4997         * aarch64-fbsd-tdep.h: Add include guard.
4998         * aarch32-linux-nat.h: Add include guard.
4999
5000 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5001
5002         * macrotab.c (macro_define_internal): New function that
5003         factorizes macro_define_object_internal and macro_define_function
5004         code.
5005         (macro_define_object_internal): Use macro_define_internal.
5006         (macro_define_function): Likewise.
5007
5008 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5009
5010         * macrocmd.c (extract_identifier): Return
5011         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5012         callers.
5013
5014 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5015
5016         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5017
5018 2019-02-05  Tom Tromey  <tom@tromey.com>
5019
5020         * target.c (target_stack::unpush): Move assertion earlier.
5021
5022 2019-01-30  Tom Tromey  <tom@tromey.com>
5023
5024         PR python/23615:
5025         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5026         (gdbpy_parse_and_eval): Likewise.
5027         * python/python-internal.h (gdbpy_allow_threads): New class.
5028
5029 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5030
5031         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5032         (aarch64_fbsd_fpregmap): Move earlier.
5033         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5034         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5035         instead of individual calls to trad_frame_set_reg_addr.
5036         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5037         earlier.
5038         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5039         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5040         instead of individual calls to trad_frame_set_reg_addr.
5041
5042 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5043
5044         * CONTRIBUTE: Replace contribution list with wiki link.
5045
5046 2019-01-25  Tom Tromey  <tom@tromey.com>
5047
5048         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5049
5050 2019-01-25  Tom Tromey  <tom@tromey.com>
5051
5052         * xtensa-linux-nat.c: Fix common/ includes.
5053         * xml-support.h: Fix common/ includes.
5054         * xml-support.c: Fix common/ includes.
5055         * x86-linux-nat.c: Fix common/ includes.
5056         * windows-nat.c: Fix common/ includes.
5057         * varobj.h: Fix common/ includes.
5058         * varobj.c: Fix common/ includes.
5059         * value.c: Fix common/ includes.
5060         * valops.c: Fix common/ includes.
5061         * utils.c: Fix common/ includes.
5062         * unittests/xml-utils-selftests.c: Fix common/ includes.
5063         * unittests/utils-selftests.c: Fix common/ includes.
5064         * unittests/unpack-selftests.c: Fix common/ includes.
5065         * unittests/tracepoint-selftests.c: Fix common/ includes.
5066         * unittests/style-selftests.c: Fix common/ includes.
5067         * unittests/string_view-selftests.c: Fix common/ includes.
5068         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5069         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5070         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5071         * unittests/rsp-low-selftests.c: Fix common/ includes.
5072         * unittests/parse-connection-spec-selftests.c: Fix common/
5073         includes.
5074         * unittests/optional-selftests.c: Fix common/ includes.
5075         * unittests/offset-type-selftests.c: Fix common/ includes.
5076         * unittests/observable-selftests.c: Fix common/ includes.
5077         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5078         * unittests/memrange-selftests.c: Fix common/ includes.
5079         * unittests/memory-map-selftests.c: Fix common/ includes.
5080         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5081         * unittests/function-view-selftests.c: Fix common/ includes.
5082         * unittests/environ-selftests.c: Fix common/ includes.
5083         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5084         * unittests/common-utils-selftests.c: Fix common/ includes.
5085         * unittests/cli-utils-selftests.c: Fix common/ includes.
5086         * unittests/array-view-selftests.c: Fix common/ includes.
5087         * ui-file.c: Fix common/ includes.
5088         * tui/tui-io.c: Fix common/ includes.
5089         * tracepoint.h: Fix common/ includes.
5090         * tracepoint.c: Fix common/ includes.
5091         * tracefile-tfile.c: Fix common/ includes.
5092         * top.h: Fix common/ includes.
5093         * top.c: Fix common/ includes.
5094         * thread.c: Fix common/ includes.
5095         * target/waitstatus.h: Fix common/ includes.
5096         * target/waitstatus.c: Fix common/ includes.
5097         * target.h: Fix common/ includes.
5098         * target.c: Fix common/ includes.
5099         * target-memory.c: Fix common/ includes.
5100         * target-descriptions.c: Fix common/ includes.
5101         * symtab.h: Fix common/ includes.
5102         * symfile.c: Fix common/ includes.
5103         * stap-probe.c: Fix common/ includes.
5104         * spu-linux-nat.c: Fix common/ includes.
5105         * sparc-nat.c: Fix common/ includes.
5106         * source.c: Fix common/ includes.
5107         * solib.c: Fix common/ includes.
5108         * solib-target.c: Fix common/ includes.
5109         * ser-unix.c: Fix common/ includes.
5110         * ser-tcp.c: Fix common/ includes.
5111         * ser-pipe.c: Fix common/ includes.
5112         * ser-base.c: Fix common/ includes.
5113         * selftest-arch.c: Fix common/ includes.
5114         * s12z-tdep.c: Fix common/ includes.
5115         * rust-exp.y: Fix common/ includes.
5116         * rs6000-aix-tdep.c: Fix common/ includes.
5117         * riscv-tdep.c: Fix common/ includes.
5118         * remote.c: Fix common/ includes.
5119         * remote-notif.h: Fix common/ includes.
5120         * remote-fileio.h: Fix common/ includes.
5121         * remote-fileio.c: Fix common/ includes.
5122         * regcache.h: Fix common/ includes.
5123         * regcache.c: Fix common/ includes.
5124         * record-btrace.c: Fix common/ includes.
5125         * python/python.c: Fix common/ includes.
5126         * python/py-type.c: Fix common/ includes.
5127         * python/py-inferior.c: Fix common/ includes.
5128         * progspace.h: Fix common/ includes.
5129         * producer.c: Fix common/ includes.
5130         * procfs.c: Fix common/ includes.
5131         * proc-api.c: Fix common/ includes.
5132         * printcmd.c: Fix common/ includes.
5133         * ppc-linux-nat.c: Fix common/ includes.
5134         * parser-defs.h: Fix common/ includes.
5135         * osdata.c: Fix common/ includes.
5136         * obsd-nat.c: Fix common/ includes.
5137         * nat/x86-linux.c: Fix common/ includes.
5138         * nat/x86-linux-dregs.c: Fix common/ includes.
5139         * nat/x86-dregs.h: Fix common/ includes.
5140         * nat/x86-dregs.c: Fix common/ includes.
5141         * nat/ppc-linux.c: Fix common/ includes.
5142         * nat/mips-linux-watch.h: Fix common/ includes.
5143         * nat/mips-linux-watch.c: Fix common/ includes.
5144         * nat/linux-waitpid.c: Fix common/ includes.
5145         * nat/linux-ptrace.h: Fix common/ includes.
5146         * nat/linux-ptrace.c: Fix common/ includes.
5147         * nat/linux-procfs.c: Fix common/ includes.
5148         * nat/linux-personality.c: Fix common/ includes.
5149         * nat/linux-osdata.c: Fix common/ includes.
5150         * nat/linux-namespaces.c: Fix common/ includes.
5151         * nat/linux-btrace.h: Fix common/ includes.
5152         * nat/linux-btrace.c: Fix common/ includes.
5153         * nat/fork-inferior.c: Fix common/ includes.
5154         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5155         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5156         * nat/aarch64-linux.c: Fix common/ includes.
5157         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5158         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5159         * namespace.h: Fix common/ includes.
5160         * mips-linux-tdep.c: Fix common/ includes.
5161         * minsyms.c: Fix common/ includes.
5162         * mi/mi-parse.h: Fix common/ includes.
5163         * mi/mi-main.c: Fix common/ includes.
5164         * mi/mi-cmd-env.c: Fix common/ includes.
5165         * memrange.h: Fix common/ includes.
5166         * memattr.c: Fix common/ includes.
5167         * maint.h: Fix common/ includes.
5168         * maint.c: Fix common/ includes.
5169         * main.c: Fix common/ includes.
5170         * machoread.c: Fix common/ includes.
5171         * location.c: Fix common/ includes.
5172         * linux-thread-db.c: Fix common/ includes.
5173         * linux-nat.c: Fix common/ includes.
5174         * linux-fork.c: Fix common/ includes.
5175         * inline-frame.c: Fix common/ includes.
5176         * infrun.c: Fix common/ includes.
5177         * inflow.c: Fix common/ includes.
5178         * inferior.h: Fix common/ includes.
5179         * inferior.c: Fix common/ includes.
5180         * infcmd.c: Fix common/ includes.
5181         * inf-ptrace.c: Fix common/ includes.
5182         * inf-child.c: Fix common/ includes.
5183         * ia64-linux-nat.c: Fix common/ includes.
5184         * i387-tdep.c: Fix common/ includes.
5185         * i386-tdep.c: Fix common/ includes.
5186         * i386-linux-tdep.c: Fix common/ includes.
5187         * i386-linux-nat.c: Fix common/ includes.
5188         * i386-go32-tdep.c: Fix common/ includes.
5189         * i386-fbsd-tdep.c: Fix common/ includes.
5190         * i386-fbsd-nat.c: Fix common/ includes.
5191         * guile/scm-type.c: Fix common/ includes.
5192         * guile/guile.c: Fix common/ includes.
5193         * go32-nat.c: Fix common/ includes.
5194         * gnu-nat.c: Fix common/ includes.
5195         * gdbthread.h: Fix common/ includes.
5196         * gdbarch-selftests.c: Fix common/ includes.
5197         * gdb_usleep.c: Fix common/ includes.
5198         * gdb_select.h: Fix common/ includes.
5199         * gdb_bfd.c: Fix common/ includes.
5200         * gcore.c: Fix common/ includes.
5201         * fork-child.c: Fix common/ includes.
5202         * findvar.c: Fix common/ includes.
5203         * fbsd-nat.c: Fix common/ includes.
5204         * event-top.c: Fix common/ includes.
5205         * event-loop.c: Fix common/ includes.
5206         * dwarf2read.c: Fix common/ includes.
5207         * dwarf2loc.c: Fix common/ includes.
5208         * dwarf2-frame.c: Fix common/ includes.
5209         * dwarf-index-cache.c: Fix common/ includes.
5210         * dtrace-probe.c: Fix common/ includes.
5211         * disasm-selftests.c: Fix common/ includes.
5212         * defs.h: Fix common/ includes.
5213         * csky-tdep.c: Fix common/ includes.
5214         * cp-valprint.c: Fix common/ includes.
5215         * cp-support.h: Fix common/ includes.
5216         * cp-support.c: Fix common/ includes.
5217         * corelow.c: Fix common/ includes.
5218         * completer.h: Fix common/ includes.
5219         * completer.c: Fix common/ includes.
5220         * compile/compile.c: Fix common/ includes.
5221         * compile/compile-loc2c.c: Fix common/ includes.
5222         * compile/compile-cplus-types.c: Fix common/ includes.
5223         * compile/compile-cplus-symbols.c: Fix common/ includes.
5224         * command.h: Fix common/ includes.
5225         * cli/cli-dump.c: Fix common/ includes.
5226         * cli/cli-cmds.c: Fix common/ includes.
5227         * charset.c: Fix common/ includes.
5228         * build-id.c: Fix common/ includes.
5229         * btrace.h: Fix common/ includes.
5230         * btrace.c: Fix common/ includes.
5231         * breakpoint.h: Fix common/ includes.
5232         * breakpoint.c: Fix common/ includes.
5233         * ax.h:
5234         (enum agent_op): Fix common/ includes.
5235         * ax-general.c (struct aop_map): Fix common/ includes.
5236         * ax-gdb.c: Fix common/ includes.
5237         * auxv.c: Fix common/ includes.
5238         * auto-load.c: Fix common/ includes.
5239         * arm-tdep.c: Fix common/ includes.
5240         * arch/riscv.c: Fix common/ includes.
5241         * arch/ppc-linux-common.c: Fix common/ includes.
5242         * arch/i386.c: Fix common/ includes.
5243         * arch/arm.c: Fix common/ includes.
5244         * arch/arm-linux.c: Fix common/ includes.
5245         * arch/arm-get-next-pcs.c: Fix common/ includes.
5246         * arch/amd64.c: Fix common/ includes.
5247         * arch/aarch64.c: Fix common/ includes.
5248         * arch/aarch64-insn.c: Fix common/ includes.
5249         * arch-utils.c: Fix common/ includes.
5250         * amd64-windows-tdep.c: Fix common/ includes.
5251         * amd64-tdep.c: Fix common/ includes.
5252         * amd64-sol2-tdep.c: Fix common/ includes.
5253         * amd64-obsd-tdep.c: Fix common/ includes.
5254         * amd64-nbsd-tdep.c: Fix common/ includes.
5255         * amd64-linux-tdep.c: Fix common/ includes.
5256         * amd64-linux-nat.c: Fix common/ includes.
5257         * amd64-fbsd-tdep.c: Fix common/ includes.
5258         * amd64-fbsd-nat.c: Fix common/ includes.
5259         * amd64-dicos-tdep.c: Fix common/ includes.
5260         * amd64-darwin-tdep.c: Fix common/ includes.
5261         * agent.c: Fix common/ includes.
5262         * ada-lang.h: Fix common/ includes.
5263         * ada-lang.c: Fix common/ includes.
5264         * aarch64-tdep.c: Fix common/ includes.
5265
5266 2019-01-25  Tom Tromey  <tom@tromey.com>
5267
5268         * common/create-version.sh: Use common/version.h.
5269
5270 2019-01-24  Pedro Alves  <palves@redhat.com>
5271
5272         * infrun.c (signal_stop, signal_print, signal_program)
5273         (signal_catch, signal_pass): Now arrays instead of pointers.
5274         (update_signals_program_target, do_target_resume)
5275         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5276         * linux-nat.c (linux_nat_target::pass_signals)
5277         (linux_nat_target::create_inferior, linux_nat_target::attach):
5278         Adjust.
5279         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5280         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5281         * procfs.c (procfs_target::pass_signals): Adjust.
5282         * record-full.c (record_full_target::resume): Adjust.
5283         * remote.c (remote_target::pass_signals)
5284         (remote_target::program_signals): Adjust.
5285         * target-debug.h (target_debug_print_signals): Now takes a
5286         gdb::array_view as parameter.  Adjust.
5287         * target.h (target_ops) <pass_signals, program_signals>: Replace
5288         pointer and length parameters with gdb::array_view.
5289         (target_pass_signals, target_program_signals): Likewise.
5290         * target-delegates.c: Regenerate.
5291
5292 2019-01-24  Pedro Alves  <palves@redhat.com>
5293
5294         * common/forward-scope-exit.h
5295         (forward_scope_exit::forward_scope_exit): Pass arguments to
5296         m_bind_function directly, instead of creating a std::bind and
5297         copying that.
5298
5299 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5300
5301         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5302         for static members.
5303         (pass_in_v_vfp_candidate): Likewise.
5304
5305 2019-01-23  Tom Tromey  <tom@tromey.com>
5306             Pedro Alves  <palves@redhat.com>
5307
5308         * regcache.c (class regcache_invalidator): Remove.
5309         (regcache::raw_write): Use make_scope_exit.
5310
5311 2019-01-23  Tom Tromey  <tom@tromey.com>
5312
5313         * ui-out.h (class ui_out_emit_type): Update comment.
5314
5315 2019-01-23  Tom Tromey  <tom@tromey.com>
5316
5317         * infrun.c (fetch_inferior_event): Update comment.
5318
5319 2019-01-23  Tom Tromey  <tom@tromey.com>
5320             Pedro Alves  <palves@redhat.com>
5321
5322         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5323         parameter.
5324         (fetch_inferior_event): Use SCOPE_EXIT.
5325
5326
5327 2019-01-23  Tom Tromey  <tom@tromey.com>
5328             Pedro Alves  <palves@redhat.com>
5329
5330         * infrun.c (disable_thread_events): Delete.
5331         (stop_all_threads): Use SCOPE_EXIT.
5332
5333 2019-01-23  Tom Tromey  <tom@tromey.com>
5334             Pedro Alves  <palves@redhat.com>
5335
5336         * symfile.c: Include forward-scope-exit.h.
5337         (clear_symtab_users_cleanup): Replace forward declaration with
5338         a FORWARD_SCOPE_EXIT.
5339         (syms_from_objfile_1): Use the forward_scope_exit and
5340         gdb::optional instead of cleanup_function.
5341         (reread_symbols): Use the forward_scope_exit instead of
5342         cleanup_function.
5343         (clear_symtab_users_cleanup): Remove function.
5344
5345 2019-01-23  Tom Tromey  <tom@tromey.com>
5346             Pedro Alves  <palves@redhat.com>
5347
5348         * linux-nat.c: Include scope-exit.h.
5349         (cleanup_target_stop): Remove.
5350         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5351         SCOPE_EXIT.
5352
5353 2019-01-23  Tom Tromey  <tom@tromey.com>
5354             Pedro Alves  <palves@redhat.com>
5355
5356         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5357         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5358
5359 2019-01-23  Tom Tromey  <tom@tromey.com>
5360             Andrew Burgess  <andrew.burgess@embecosm.com>
5361             Pedro Alves  <palves@redhat.com>
5362
5363         * infrun.c (fetch_inferior_event): Use scope_exit.
5364         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5365         * top.c (execute_command): Use scope_exit.
5366         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5367         * utils.c (do_bpstat_clear_actions_cleanup)
5368         (make_bpstat_clear_actions_cleanup): Remove.
5369
5370 2019-01-23  Tom Tromey  <tom@tromey.com>
5371             Pedro Alves  <palves@redhat.com>
5372
5373         * infrun.c: Include "common/scope-exit.h"
5374         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5375         (wait_for_inferior): Use SCOPE_EXIT.
5376         (fetch_inferior_event): Use scope_exit.
5377
5378 2019-01-23  Tom Tromey  <tom@tromey.com>
5379             Pedro Alves  <palves@redhat.com>
5380
5381         * breakpoint.c (create_breakpoint): Remove cleanup.
5382
5383 2019-01-23  Tom Tromey  <tom@tromey.com>
5384             Andrew Burgess  <andrew.burgess@embecosm.com>
5385             Pedro Alves  <palves@redhat.com>
5386
5387 2019-01-23  Pedro Alves  <palves@redhat.com>
5388
5389         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5390
5391 2019-01-23  Pedro Alves  <palves@redhat.com>
5392             Andrew Burgess  <andrew.burgess@embecosm.com>
5393
5394         * gdbthread.h: Include "common/forward-scope-exit.h".
5395         (scoped_finish_thread_state): Redefine custom class in terms of
5396         forward_scope_exit.
5397
5398 2019-01-23  Pedro Alves  <palves@redhat.com>
5399             Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * common/forward-scope-exit.h: New file.
5402
5403 2019-01-23  Pedro Alves  <palves@redhat.com>
5404             Andrew Burgess  <andrew.burgess@embecosm.com>
5405             Tom Tromey  <tom@tromey.com>
5406
5407         * common/scope-exit.h: New file.
5408
5409 2019-01-23  Pedro Alves  <palves@redhat.com>
5410
5411         * common/preprocessor.h (ESC): Rename to ...
5412         (ESC_PARENS): ... this.
5413         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5414         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5415
5416 2019-01-23  Tom Tromey  <tom@tromey.com>
5417
5418         * language.h (class scoped_switch_to_sym_language_if_auto):
5419         Initialize m_lang in both cases.
5420
5421 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5422
5423         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5424         with XCNEW.
5425
5426 2019-01-22  Tom Tromey  <tom@tromey.com>
5427
5428         * corelow.c: Do not include sys/file.h.
5429
5430 2019-01-22  Tom Tromey  <tom@tromey.com>
5431
5432         * tui/tui-wingeneral.h: Include gdb_curses.h.
5433
5434 2019-01-22  Tom Tromey  <tom@tromey.com>
5435
5436         * source-cache.h (class source_cache) <get_source_lines,
5437         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5438
5439 2019-01-22  Tom Tromey  <tom@tromey.com>
5440
5441         * remote-fileio.h (struct remote_target): Declare.
5442
5443 2019-01-22  Tom Tromey  <tom@tromey.com>
5444
5445         * python/py-arch.c: Do not include py-ref.h.
5446         * python/py-bpevent.c: Do not include py-ref.h.
5447         * python/py-cmd.c: Do not include py-ref.h.
5448         * python/py-continueevent.c: Do not include py-ref.h.
5449         * python/py-event.h: Do not include py-ref.h.
5450         * python/py-evtregistry.c: Do not include py-ref.h.
5451         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5452         * python/py-frame.c: Do not include py-ref.h.
5453         * python/py-framefilter.c: Do not include py-ref.h.
5454         * python/py-function.c: Do not include py-ref.h.
5455         * python/py-infevents.c: Do not include py-ref.h.
5456         * python/py-linetable.c: Do not include py-ref.h.
5457         * python/py-objfile.c: Do not include py-ref.h.
5458         * python/py-param.c: Do not include py-ref.h.
5459         * python/py-prettyprint.c: Do not include py-ref.h.
5460         * python/py-progspace.c: Do not include py-ref.h.
5461         * python/py-symbol.c: Do not include py-ref.h.
5462         * python/py-symtab.c: Do not include py-ref.h.
5463         * python/py-type.c: Do not include py-ref.h.
5464         * python/py-unwind.c: Do not include py-ref.h.
5465         * python/py-utils.c: Do not include py-ref.h.
5466         * python/py-value.c: Do not include py-ref.h.
5467         * python/py-varobj.c: Do not include py-ref.h.
5468         * python/py-xmethods.c: Do not include py-ref.h.
5469         * python/python.c: Do not include py-ref.h.
5470         * varobj.c: Do not include py-ref.h.
5471
5472 2019-01-22  Tom Tromey  <tom@tromey.com>
5473
5474         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5475         keyword for bcache.
5476
5477 2019-01-22  Tom Tromey  <tom@tromey.com>
5478
5479         * compile/compile-cplus-types.c: Remove a comment by #include.
5480
5481 2019-01-22  Tom Tromey  <tom@tromey.com>
5482
5483         * compile/gcc-c-plugin.h: Include compile-internal.h.
5484
5485 2019-01-22  Tom Tromey  <tom@tromey.com>
5486
5487         * stabsread.c (EXTERN): Do not define.
5488         (symnum, next_symbol_text_func, processing_gcc_compilation)
5489         (within_function, global_sym_chain, global_stabs)
5490         (previous_stab_code, this_object_header_files)
5491         (n_this_object_header_files)
5492         (n_allocated_this_object_header_files): Define.
5493         * stabsread.h (EXTERN): Never define.  Use "extern".
5494
5495 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5496
5497         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5498         history_value.
5499
5500 2019-01-21  Tom Tromey  <tom@tromey.com>
5501
5502         * ui-out.c: Fix includes.
5503         * tui/tui-source.c: Fix includes.
5504         * target.c: Fix includes.
5505         * remote.c: Fix includes.
5506         * regcache.c: Fix includes.
5507         * python/py-block.c: Fix includes.
5508         * printcmd.c: Fix includes.
5509         * or1k-tdep.c: Fix includes.
5510         * mi/mi-main.c: Fix includes.
5511         * m32r-tdep.c: Fix includes.
5512         * csky-tdep.c: Fix includes.
5513         * compile/compile-cplus-types.c: Fix includes.
5514         * cli/cli-interp.c: Fix includes.
5515
5516 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5517
5518         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5519         for padding.
5520
5521 2019-01-16  Tom Tromey  <tom@tromey.com>
5522
5523         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5524         earlier.
5525         (struct objfile) <msymbols_range>: Move from top level.
5526         <msymbols>: New method.
5527         (class objfile_msymbols): Remove.
5528         * symtab.c (default_collect_symbol_completion_matches_break_on):
5529         Update.
5530         * symmisc.c (dump_msymbols): Update.
5531         * stabsread.c (scan_file_globals): Update.
5532         * objc-lang.c (info_selectors_command, info_classes_command)
5533         (find_methods): Update.
5534         * minsyms.c (find_solib_trampoline_target): Update.
5535         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5536         * coffread.c (coff_symfile_read): Update.
5537         * ada-lang.c (ada_lookup_simple_minsym)
5538         (ada_collect_symbol_completion_matches): Update.
5539
5540 2019-01-16  Tom Tromey  <tom@tromey.com>
5541
5542         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5543         type.  Remove no-argument constructor.
5544         <iterator::operator++>: Simplify.
5545         <begin>: Update.
5546         <end>: Use minimal_symbol_count.
5547
5548 2019-01-16  Tom Tromey  <tom@tromey.com>
5549
5550         * objfiles.h (struct objfile) <psymtabs>: New method.
5551         (class objfile_psymtabs): Remove.
5552         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5553         typedef.
5554         <range>: New method.
5555         (require_partial_symbols): Change return type.
5556         * psymtab.c (require_partial_symbols)
5557         (psym_expand_symtabs_matching): Update.
5558         * mdebugread.c (parse_partial_symbols): Update.
5559         * dbxread.c (dbx_end_psymtab): Update.
5560
5561 2019-01-15  Tom Tromey  <tom@tromey.com>
5562
5563         * symtab.c (lookup_objfile_from_block)
5564         (lookup_symbol_in_objfile_symtabs)
5565         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5566         (find_line_symtab, info_sources_command)
5567         (default_collect_symbol_completion_matches_break_on)
5568         (make_source_files_completion_list): Update.
5569         * symmisc.c (print_objfile_statistics, dump_objfile)
5570         (maintenance_print_symbols, maintenance_info_symtabs)
5571         (maintenance_check_symtabs, maintenance_info_line_tables):
5572         Update.
5573         * source.c (select_source_symtab)
5574         (forget_cached_source_info_for_objfile): Update.
5575         * objfiles.h (class objfile_compunits): Remove.
5576         (struct objfile) <compunits_range>: New typedef.
5577         (compunits): New method.
5578         * objfiles.c (objfile_relocate1): Update.
5579         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5580         * maint.c (count_symtabs_and_blocks): Update.
5581         * linespec.c (iterate_over_all_matching_symtabs): Update.
5582         * cp-support.c (add_symbol_overload_list_qualified): Update.
5583         * coffread.c (coff_symtab_read): Update.
5584         * ada-lang.c (add_nonlocal_symbols)
5585         (ada_collect_symbol_completion_matches)
5586         (ada_add_global_exceptions): Update.
5587
5588 2019-01-15  Tom Tromey  <tom@tromey.com>
5589
5590         * progspace.h (program_space) <objfiles_safe_range>: New
5591         typedef.
5592         <objfiles_safe>: New method.
5593         * objfiles.h (class all_objfiles_safe): Remove.
5594         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5595         * jit.c (jit_inferior_exit_hook): Update.
5596
5597 2019-01-17  Tom Tromey  <tom@tromey.com>
5598
5599         * progspace.h (program_space) <objfiles_range>: New typedef.
5600         <objfiles>: New method.
5601         <objfiles_head>: Rename from objfiles.
5602         (object_files): Update.
5603         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5604         * guile/scm-pretty-print.c
5605         (ppscm_find_pretty_printer_from_objfiles): Update.
5606         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5607         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5608         Update.
5609         * python/py-progspace.c (pspy_get_objfiles): Update.
5610         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5611         Update.
5612         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5613         (objfpy_lookup_objfile_by_build_id): Update.
5614         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5615         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5616         Update.
5617         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5618         (expand_symtab_containing_pc, lookup_objfile_from_block)
5619         (lookup_static_symbol, basic_lookup_transparent_type)
5620         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5621         (find_line_symtab, info_sources_command)
5622         (default_collect_symbol_completion_matches_break_on)
5623         (make_source_files_completion_list, find_main_name): Update.
5624         * symmisc.c (print_symbol_bcache_statistics)
5625         (print_objfile_statistics, maintenance_print_symbols)
5626         (maintenance_print_msymbols, maintenance_print_objfiles)
5627         (maintenance_info_symtabs, maintenance_check_symtabs)
5628         (maintenance_expand_symtabs, maintenance_info_line_tables):
5629         Update.
5630         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5631         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5632         (map_overlay_command, unmap_overlay_command)
5633         (simple_overlay_update, expand_symtabs_matching)
5634         (map_symbol_filenames): Update.
5635         * symfile-debug.c (set_debug_symfile): Update.
5636         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5637         Update.
5638         * source.c (select_source_symtab, forget_cached_source_info):
5639         Update.
5640         * solib.c (solib_read_symbols): Update.
5641         * solib-spu.c (append_ocl_sos): Update.
5642         * psymtab.c (maintenance_print_psymbols)
5643         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5644         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5645         * printcmd.c (info_symbol_command): Update.
5646         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5647         Update.
5648         * objfiles.h (class all_objfiles): Remove.
5649         * objfiles.c (have_partial_symbols, have_full_symbols)
5650         (have_minimal_symbols, qsort_cmp, update_section_map)
5651         (shared_objfile_contains_address_p)
5652         (default_iterate_over_objfiles_in_search_order): Update.
5653         * objc-lang.c (info_selectors_command, info_classes_command)
5654         (find_methods): Update.
5655         * minsyms.c (find_solib_trampoline_target): Update.
5656         * maint.c (maintenance_info_sections)
5657         (maintenance_translate_address, count_symtabs_and_blocks):
5658         Update.
5659         * main.c (captured_main_1): Update.
5660         * linux-thread-db.c (try_thread_db_load_from_pdir)
5661         (has_libpthread): Update.
5662         * linespec.c (iterate_over_all_matching_symtabs)
5663         (search_minsyms_for_name): Update.
5664         * jit.c (jit_find_objf_with_entry_addr): Update.
5665         * hppa-tdep.c (find_unwind_entry)
5666         (hppa_lookup_stub_minimal_symbol): Update.
5667         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5668         Update.
5669         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5670         (elf_gnu_ifunc_resolve_by_got): Update.
5671         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5672         * dwarf-index-write.c (save_gdb_index_command): Update.
5673         * cp-support.c (add_symbol_overload_list_qualified): Update.
5674         * breakpoint.c (create_overlay_event_breakpoint)
5675         (create_longjmp_master_breakpoint)
5676         (create_std_terminate_master_breakpoint)
5677         (create_exception_master_breakpoint): Update.
5678         * blockframe.c (find_pc_partial_function): Update.
5679         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5680         (ada_collect_symbol_completion_matches)
5681         (ada_add_global_exceptions): Update.
5682
5683 2019-01-17  Tom Tromey  <tom@tromey.com>
5684
5685         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5686         declare VEC.
5687         (solib_target_parse_libraries): Change return type.
5688         (library_list_start_segment, library_list_start_section)
5689         (library_list_end_library, library_list_start_library); Update.
5690         (solib_target_free_library_list): Remove.
5691         (solib_target_parse_libraries): Remove cleanup.  Change return
5692         type.
5693         (solib_target_current_sos): Update.
5694
5695 2019-01-17  Tom Tromey  <tromey@bapiya>
5696
5697         * valprint.c: Replace "the the" with "the".
5698         * symtab.c: Replace "the the" with "the".
5699         * solib.c: Replace "the the" with "the".
5700         * solib-dsbt.c: Replace "the the" with "the".
5701         * linespec.c: Replace "the the" with "the".
5702         * dwarf2loc.h: Replace "the the" with "the".
5703         * amd64-windows-tdep.c: Replace "the the" with "the".
5704         * aarch64-tdep.c: Replace "the the" with "the".
5705
5706 2019-01-16  Keith Seitz  <keiths@redhat.com>
5707
5708         PR gdb/23773
5709         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5710         <builder>: Rename to ..
5711         <m_builder>: ... this and make private.
5712         (dwarf2_cu::get_builder): New method.  Change all users of
5713         `builder' to use this method.
5714         (dwarf2_start_symtab): Move to ...
5715         (dwarf2_cu::start_symtab): ... here.  Update all callers
5716         (setup_type_unit_groups): Move to ...
5717         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5718         callers.
5719         (dwarf2_cu::reset_builder): New method.
5720         (process_full_compunit, process_full_type_unit): Use
5721         dwarf2_cu::reset_builder.
5722         (follow_die_offset): Record the ancestor CU if it is different
5723         from the followed DIE's CU.
5724         (follow_die_sig_1): Likewise.
5725
5726 2019-01-15  Tom Tromey  <tom@tromey.com>
5727
5728         * remote.c (class remote_state) <buf>: Now a char_vector.
5729         <buf_size>: Remove.
5730         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5731         parameter.
5732         (remote_target::getpkt_or_notif_sane_1)
5733         (remote_target::getpkt_sane)
5734         (remote_target::getpkt_or_notif_sane): Likewise.
5735         (class remote_target) <putpkt>: New overload.
5736         (remote_target::read_frame): Change type of "buf_p".  Remove
5737         sizeof_p parameter.
5738         (packet_ok): New overload.
5739         (packet_check_result): New overload.
5740         Update all uses.
5741
5742 2019-01-14  Tom Tromey  <tom@tromey.com>
5743
5744         * remote-notif.c (handle_notification, remote_notif_ack)
5745         (remote_notif_parse): Make "buf" const.
5746         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5747         const.
5748         (remote_notif_parse, remote_notif_ack, handle_notification):
5749         Likewise.
5750         * remote.c (remote_notif_stop_parse): Make "buf" const.
5751         (remote_target::remote_parse_stop_reply): Make "buf" const.
5752         (remote_notif_stop_ack): Make "buf" const.
5753
5754 2019-01-14  Tom Tromey  <tom@tromey.com>
5755
5756         * remote.c (remote_console_output): Make parameter const.
5757
5758 2019-01-14  Tom Tromey  <tom@tromey.com>
5759
5760         * target-debug.h (target_debug_print_signals): Constify.
5761         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5762         * procfs.c (procfs_target::pass_signals): Update.
5763         * linux-nat.c (linux_nat_target::pass_signals): Update.
5764         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5765         * target-delegates.c: Rebuild.
5766         * remote.c (remote_target::program_signals): Update.
5767         (remote_target::pass_signals): Update.
5768         * target.c (target_pass_signals): Constify argument.
5769         (target_program_signals): Likewise.
5770         * target.h (struct target_ops) <pass_signals, program_signals>:
5771         Constify argument.
5772         (target_pass_signals, target_program_signals): Constify argument.
5773
5774 2019-01-14  Tom Tromey  <tom@tromey.com>
5775
5776         PR tui/28819:
5777         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5778
5779 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5780
5781         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5782         field.
5783         * rs6000-tdep.c: Include reggroups.h.
5784         (IS_V_ALIAS_PSEUDOREG): Define.
5785         (rs6000_register_name): Return names for the "vX" aliases.
5786         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5787         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5788         aliases.  Call default_register_reggroup_p for all other
5789         pseudo-registers.
5790         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5791         New functions.
5792         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5793         Handle "vX" aliases.
5794         (v_alias_pseudo_register_collect): New function.
5795         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5796         (rs6000_gdbarch_init): Initialize "vX" aliases as
5797         pseudo-registers.  Restore registration of
5798         rs6000_pseudo_register_reggroup_p with
5799         set_tdesc_pseudo_register_reggroup_p.
5800
5801 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5802
5803         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5804         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5805         set_gdbarch_num_pseudo_regs.
5806
5807 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5808
5809         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5810         Remove arg prefixname, add do_set and do_show.
5811         Add member functions set_list and show_list.
5812         * cli/cli-style.c (class cli_style_option): Update accordingly.
5813         (style_set_list): Move to file scope.
5814         (style_show_list): Likewise.
5815         (set_style): Call help_list.
5816         (show_style): Call cmd_show_list.
5817         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5818         Update to use the new macro.
5819
5820 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5821
5822         * ada-lang.c (_initialize_ada_language): Expand the help text
5823         for the "catch exception" command.
5824
5825 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5826
5827         * symtab.c (matching_obj_sections): Initialize obj,
5828         declare it closer to its usage.
5829
5830 2019-01-10  Tom Tromey  <tom@tromey.com>
5831
5832         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5833         (basic_inf_threads_range): Remove.
5834         (inf_threads_range, inf_non_exited_threads_range)
5835         (safe_inf_threads_range): Use next_adapter.
5836
5837 2019-01-10  Keith Seitz  <keiths@redhat.com>
5838
5839         PR gdb/23712
5840         PR symtab/23010
5841         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5842         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5843
5844 2019-01-10  Keith Seitz  <keiths@redhat.com>
5845
5846         PR gdb/23712
5847         PR symtab/23010
5848         * dictionary.c (pending_to_vector): Remove.
5849         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5850         Remove _1 suffix, replacing functions of the same name.  Update
5851         all callers.
5852         (dict_create_hashed, dict_create_hashed_expandable)
5853         (dict_create_linear, dict_create_linear_expandable, dict_free)
5854         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5855         Make functions static.
5856
5857 2019-01-10  Keith Seitz  <keiths@redhat.com>
5858
5859         PR gdb/23712
5860         PR symtab/23010
5861         * dictionary.h (struct dictionary): Replace declaration with
5862         multidictionary.
5863         (dict_create_hashed, dict_create_hashed_expandable)
5864         (dict_create_linear, dict_create_linear_expandable)
5865         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5866         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5867         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5868         taking multidictionary argument.
5869         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5870         * block.h (struct block) <dict>: Change to multidictionary
5871         and rename `multidict'.
5872         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5873         symmisc.c: Update all dictionary references to multidictionary.
5874
5875 2019-01-10  Keith Seitz  <keiths@redhat.com>
5876
5877         PR gdb/23712
5878         PR symtab/23010
5879         * dictionary.c: Include unordered_map.
5880         (pending_to_vector): New function.
5881         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5882         Rewrite the non-"_1" functions to take vector instead
5883         of linked list.
5884         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5885         "new" _1 versions of the same name.
5886         (multidictionary): Define.
5887         (std::hash<enum language): New definition.
5888         (collate_pending_symbols_by_language, mdict_create_hashed)
5889         (mdict_create_hashed_expandable, mdict_create_linear)
5890         (mdict_create_linear_expandable, mdict_free)
5891         (find_language_dictionary, create_new_language_dictionary)
5892         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5893         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5894         (mdict_size, mdict_empty): New functions.
5895         * dictionary.h (mdict_iterator): Define.
5896
5897 2019-01-10  Pedro Alves  <palves@redhat.com>
5898
5899         * breakpoint.c (read_uploaded_action)
5900         (create_tracepoint_from_upload): Adjust to use
5901         gdb::unique_xmalloc_ptr.
5902         * ctf.c (ctf_write_uploaded_tp):
5903         (SET_ARRAY_FIELD): Use emplace_back.
5904         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5905         * tracefile-tfile.c (tfile_write_uploaded_tp):
5906         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5907         gdb::unique_xmalloc_ptr.
5908         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5909         at_string, cond_string, cmd_strings>: Replace char pointers
5910         with gdb::unique_xmalloc_ptr.
5911
5912 2019-01-10  Pedro Alves  <palves@redhat.com>
5913
5914         * solib-target.c (library_list_start_library): Don't xstrdup name.
5915
5916 2019-01-10  Pedro Alves  <palves@redhat.com>
5917
5918         * mdebugread.c (parse_partial_symbols): Use
5919         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5920
5921 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5922
5923         * linux-fork.c (scoped_switch_fork_info)
5924         <~scoped_switch_fork_info>: Fix incorrect variable name.
5925
5926 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5927
5928         * linux-fork.c (scoped_switch_fork_info)
5929         <scoped_switch_fork_info>: Make explicit.
5930         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5931
5932 2019-01-10  Tom Tromey  <tom@tromey.com>
5933
5934         * objfiles.h (objfile::reset_psymtabs): Update.
5935         * objfiles.c (objfile::objfile): Update.
5936         * psymtab.h (psymtab_storage::obstack): Update.
5937         (psymtab_storage::m_obstack): Use gdb::optional.
5938         (class psymtab_storage): Update comment.  Remove objfile
5939         parameter.
5940         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5941
5942 2019-01-10  Tom Tromey  <tom@tromey.com>
5943
5944         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5945         <free_psymtabs>: Now private.
5946         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5947         (allocate_psymtab): Use new method.
5948
5949 2019-01-10  Tom Tromey  <tom@tromey.com>
5950
5951         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5952         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5953         * mdebugread.c (parse_partial_symbols): Use
5954         allocate_dependencies.
5955         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5956         allocate_dependencies.
5957         (process_psymtab_comp_unit_reader)
5958         (build_type_psymtab_dependencies): Likewise.
5959         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5960
5961 2019-01-10  Tom Tromey  <tom@tromey.com>
5962
5963         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5964         PSYMBOL_SET_LANGUAGE.
5965         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5966
5967 2019-01-10  Tom Tromey  <tom@tromey.com>
5968
5969         * psymtab.h (psymtab_storage::obstack): New method.
5970         <m_obstack>: Rename from obstack; now private.
5971         * psymtab.c (psymtab_storage): Update.
5972         * dwarf2read.c (create_addrmap_from_index)
5973         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5974         Update.
5975
5976 2019-01-10  Tom Tromey  <tom@tromey.com>
5977
5978         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5979         * objfiles.h (objfile::reset_psymtabs): New method.
5980
5981 2019-01-10  Tom Tromey  <tom@tromey.com>
5982
5983         * symmisc.c (print_symbol_bcache_statistics): Update.
5984         (print_objfile_statistics): Update.
5985         * symfile.c (reread_symbols): Update.
5986         * psymtab.h (class psymtab_storage): New.
5987         * psymtab.c (psymtab_storage): New constructor.
5988         (~psymtab_storage): New destructor.
5989         (require_partial_symbols): Update.
5990         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5991         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5992         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5993         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5994         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5995         (start_psymtab_common, end_psymtab_common)
5996         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5997         (allocate_psymtab): Update.
5998         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5999         Update.
6000         (dump_psymtab_addrmap, maintenance_print_psymbols)
6001         (maintenance_check_psymtabs): Update.
6002         (class objfile_psymtabs): Move to objfiles.h.
6003         * psympriv.h (discard_psymtab): Now inline.
6004         (psymtab_discarder::psymtab_discarder): Update.
6005         (psymtab_discarder::~psymtab_discarder): Update.
6006         (ALL_OBJFILE_PSYMTABS): Rewrite.
6007         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6008         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6009         Remove fields.
6010         <partial_symtabs>: New field.
6011         (class objfile_psymtabs): Move from psymtab.h.  Update.
6012         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6013         psymbol_cache.
6014         (objfile::~objfile): Don't destroy psymbol_cache.
6015         * mdebugread.c (parse_partial_symbols): Update.
6016         * dwarf2read.c (create_addrmap_from_index)
6017         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6018         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6019         (add_partial_subprogram, dwarf2_ranges_read): Update.
6020         * dwarf-index-write.c (write_address_map)
6021         (write_one_signatured_type, recursively_write_psymbols)
6022         (class debug_names, class debug_names, write_psymtabs_to_index):
6023         Update.
6024
6025 2019-01-10  Tom Tromey  <tom@tromey.com>
6026
6027         * symtab.h (SYMBOL_SET_NAMES): Update.
6028         (symbol_set_names): Update.
6029         (MSYMBOL_SET_NAMES): Update.
6030         * symtab.c (symbol_set_names): Change argument to be an
6031         objfile_per_bfd_storage.
6032         * psymtab.c (add_psymbol_to_bcache): Update.
6033         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6034
6035 2019-01-10  Tom Tromey  <tom@tromey.com>
6036
6037         * symtab.c (create_demangled_names_hash): Change argument to be an
6038         objfile_per_bfd_storage.
6039         (symbol_set_names): Update.
6040
6041 2019-01-10  Tom Tromey  <tom@tromey.com>
6042
6043         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6044         init_psymbol_list.
6045         * psymtab.c (init_psymbol_list): Do nothing if already called.
6046         * psympriv.h (init_psymbol_list): Add comment.
6047         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6048         init_psymbol_list.
6049         * dbxread.c (dbx_symfile_read): Unconditionally call
6050         init_psymbol_list.
6051
6052 2019-01-10  Tom Tromey  <tom@tromey.com>
6053
6054         * xcoffread.c (scan_xcoff_symtab): Update.
6055         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6056         "where".
6057         * mdebugread.c (parse_partial_symbols)
6058         (handle_psymbol_enumerators): Update.
6059         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6060         * dbxread.c (read_dbx_symtab): Update.
6061         * psympriv.h (psymbol_placement): New enum.
6062         (add_psymbol_to_list): Update.
6063
6064 2019-01-10  Tom Tromey  <tom@tromey.com>
6065
6066         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6067         static_psymbols parameters.
6068         (scan_xcoff_symtab): Update.
6069         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6070         static_psymbols parameters.
6071         * psympriv.h (start_psymtab_common): Update.
6072         * mdebugread.c (parse_partial_symbols): Update.
6073         * dwarf2read.c (create_partial_symtab): Update.
6074         * dbxread.c (read_dbx_symtab): Update.
6075         (start_psymtab): Remove global_psymbols and static_psymbols
6076         parameters.
6077
6078 2019-01-10  Tom Tromey  <tom@tromey.com>
6079
6080         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6081         * psymtab.c (allocate_psymtab): Add comment.
6082         * psympriv.h (allocate_psymtab): Add comment.
6083         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6084         initializations.
6085         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6086
6087 2019-01-10  Tom Tromey  <tom@tromey.com>
6088
6089         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6090         Don't declare.
6091         * mipsread.c: Include mdebugread.h.
6092         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6093         Declare.
6094         * elfread.c: Include mdebugread.h.
6095
6096 2019-01-09  Tom Tromey  <tom@tromey.com>
6097
6098         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6099         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6100         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6101         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6102         (psym_lookup_symbol, psym_find_last_source_symtab)
6103         (psym_forget_cached_source_info, psym_print_stats)
6104         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6105         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6106         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6107         (psym_find_compunit_symtab_by_address)
6108         (maintenance_print_psymbols, maintenance_info_psymtabs)
6109         (maintenance_check_psymtabs): Use ranged for.
6110         * psymtab.h (class objfile_psymtabs): New.
6111         (require_partial_symbols): Return objfile_psymtabs.
6112         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6113
6114 2019-01-09  Tom Tromey  <tom@tromey.com>
6115
6116         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6117         (find_pc_mapped_section, list_overlays_command)
6118         (map_overlay_command, unmap_overlay_command)
6119         (simple_overlay_update): Use all_objfiles.
6120         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6121         * printcmd.c (info_symbol_command): Use all_objfiles.
6122         * objfiles.h (ALL_OBJSECTIONS): Remove.
6123         * maint.c (maintenance_translate_address): Use all_objfiles.
6124         * gcore.c (gcore_create_callback): Use all_objfiles.
6125         (objfile_find_memory_regions): Likewise.
6126
6127 2019-01-09  Tom Tromey  <tom@tromey.com>
6128
6129         * symtab.c (find_line_symtab, info_sources_command)
6130         (make_source_files_completion_list): Use objfile_compunits.
6131         * source.c (select_source_symtab): Use objfile_compunits.
6132         * objfiles.h (struct objfile): Update comment.
6133         (ALL_OBJFILES): Remove.
6134         (ALL_FILETABS): Remove.
6135         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6136         objfile_compunits.
6137
6138 2019-01-09  Tom Tromey  <tom@tromey.com>
6139
6140         * symmisc.c (print_objfile_statistics, dump_objfile)
6141         (maintenance_print_symbols): Use compunit_filetabs.
6142         * source.c (forget_cached_source_info_for_objfile): Use
6143         compunit_filetabs.
6144         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6145         (ALL_FILETABS): Use compunit_filetabs.
6146         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6147         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6148
6149 2019-01-09  Tom Tromey  <tom@tromey.com>
6150
6151         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6152         (compunit_filetabs): New.
6153         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6154         compunit_filetabs.
6155         (info_sources_command, make_source_files_completion_list): Remove
6156         declaration.
6157         * symmisc.c (print_objfile_statistics, dump_objfile)
6158         (maintenance_print_symbols): Remove declaration.
6159         (maintenance_info_symtabs): Use compunit_filetabs.
6160         (maintenance_info_line_tables): Likewise.
6161         * source.c (select_source_symtab): Change local variable name.
6162         (forget_cached_source_info_for_objfile): Remove declaration.
6163         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6164         * objfiles.c (objfile_relocate1): Remove declaration.
6165         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6166         declaration.
6167         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6168         * coffread.c (coff_symtab_read): Remove declaration.
6169         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6170         compunit_filetabs.
6171
6172 2019-01-09  Tom Tromey  <tom@tromey.com>
6173
6174         * symtab.c (lookup_objfile_from_block)
6175         (find_pc_sect_compunit_symtab, search_symbols)
6176         (default_collect_symbol_completion_matches_break_on): Use
6177         objfile_compunits.
6178         * objfiles.h (ALL_COMPUNITS): Remove.
6179         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6180         * cp-support.c (add_symbol_overload_list_qualified): Use
6181         objfile_compunits.
6182         * ada-lang.c (ada_collect_symbol_completion_matches)
6183         (ada_add_global_exceptions): Use objfile_compunits.
6184
6185 2019-01-09  Tom Tromey  <tom@tromey.com>
6186
6187         * source.c (select_source_symtab)
6188         (forget_cached_source_info_for_objfile): Remove declaration.
6189         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6190         declaration.
6191         * maint.c (count_symtabs_and_blocks): Remove declaration.
6192         * cp-support.c (add_symbol_overload_list_qualified): Remove
6193         declaration.
6194         * coffread.c (coff_symtab_read): Remove declaration.
6195         * symtab.c (lookup_symbol_in_objfile_symtabs)
6196         (basic_lookup_transparent_type_1): Use objfile_compunits.
6197         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6198         (info_sources_command, search_symbols)
6199         (default_collect_symbol_completion_matches_break_on)
6200         (make_source_files_completion_list): Remove declaration.
6201         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6202         (ada_collect_symbol_completion_matches)
6203         (ada_add_global_exceptions): Remove declaration.
6204         * linespec.c (iterate_over_all_matching_symtabs): Use
6205         objfile_compunits.
6206         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6207         (class objfile_compunits): New.
6208         (ALL_COMPUNITS): Use objfile_compunits.
6209         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6210         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6211         objfile_compunits.
6212         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6213
6214 2019-01-09  Tom Tromey  <tom@tromey.com>
6215
6216         * symtab.c (search_symbols)
6217         (default_collect_symbol_completion_matches_break_on): Use
6218         objfile_msymbols.
6219         * ada-lang.c (ada_lookup_simple_minsym)
6220         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6221         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6222         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6223         objfile_msymbols.
6224         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6225         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6226         * objc-lang.c (find_methods): Use objfile_msymbols.
6227         (info_selectors_command, info_classes_command): Likewise.
6228         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6229         * objfiles.h (class objfile_msymbols): New.
6230         (ALL_OBJFILE_MSYMBOLS): Remove.
6231         (ALL_MSYMBOLS): Remove.
6232
6233 2019-01-09  Tom Tromey  <tom@tromey.com>
6234
6235         * common/next-iterator.h (next_adapter): Add Iterator template
6236         parameter.
6237         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6238         (class all_objfiles_safe): New.
6239         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6240         * objfiles.c (put_objfile_before): Update comment.
6241         (add_separate_debug_objfile): Likewise.
6242         (free_all_objfiles): Use all_objfiles_safe.
6243         (objfile_purge_solibs): Likewise.
6244
6245 2019-01-09  Tom Tromey  <tom@tromey.com>
6246
6247         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6248         (expand_symtab_containing_pc, lookup_static_symbol)
6249         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6250         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6251         all_objfiles.
6252         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6253         * breakpoint.c (create_overlay_event_breakpoint)
6254         (create_longjmp_master_breakpoint)
6255         (create_std_terminate_master_breakpoint)
6256         (create_exception_master_breakpoint): Use all_objfiles.
6257         * linux-thread-db.c (try_thread_db_load_from_pdir)
6258         (has_libpthread): Use all_objfiles.
6259         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6260         * linespec.c (iterate_over_all_matching_symtabs)
6261         (search_minsyms_for_name): Use all_objfiles.
6262         * maint.c (maintenance_info_sections): Use all_objfiles.
6263         * main.c (captured_main_1): Use all_objfiles.
6264         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6265         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6266         * guile/scm-pretty-print.c
6267         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6268         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6269         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6270         (maintenance_print_msymbols): Use all_objfiles.
6271         * source.c (select_source_symtab): Use all_objfiles.
6272         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6273         * symfile.c (remove_symbol_file_command)
6274         (expand_symtabs_matching, map_symbol_filenames): Use
6275         all_objfiles.
6276         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6277         all_objfiles.
6278         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6279         * objc-lang.c (find_methods): Use all_objfiles.
6280         * objfiles.c (have_partial_symbols, have_full_symbols)
6281         (have_minimal_symbols, qsort_cmp)
6282         (default_iterate_over_objfiles_in_search_order): Use
6283         all_objfiles.
6284         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6285         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6286         (maintenance_check_psymtabs): Use all_objfiles.
6287         (ALL_PSYMTABS): Remove.
6288         * compile/compile-object-run.c (do_module_cleanup): Use
6289         all_objfiles.
6290         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6291         * cp-support.c (add_symbol_overload_list_qualified): Use
6292         all_objfiles.
6293         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6294         Use all_objfiles.
6295         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6296         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6297         all_objfiles.
6298         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6299         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6300         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6301         Uses all_objfiles.
6302         * solib.c (solib_read_symbols): Use all_objfiles
6303
6304 2019-01-09  Tom Tromey  <tom@tromey.com>
6305
6306         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6307         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6308         all_objfiles.
6309         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6310         * symmisc.c (print_symbol_bcache_statistics)
6311         (print_objfile_statistics, maintenance_print_objfiles)
6312         (maintenance_info_symtabs, maintenance_check_symtabs)
6313         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6314         all_objfiles.
6315         * source.c (forget_cached_source_info): Use all_objfiles.
6316         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6317         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6318         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6319         * objfiles.c (update_section_map): Use all_objfiles.
6320         (shared_objfile_contains_address_p): Likewise.
6321         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6322         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6323
6324 2019-01-09  Tom Tromey  <tom@tromey.com>
6325
6326         * common/next-iterator.h: New file.
6327         * objfiles.h (class all_objfiles): New.
6328         (struct objfile_iterator): New.
6329
6330 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6331
6332         * NEWS: Move the description of the changed "frame", "select-frame",
6333          and "info frame" commands to the Changed commands section.
6334
6335 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6336
6337         * gdbtypes.c (check_stub_method_group): Remove handling of old
6338         mangling schemes.
6339         * linespec.c (find_methods): Likewise.
6340         * stabsread.c (read_member_functions): Likewise.
6341         * valops.c (search_struct_method): Likewise.
6342         (value_struct_elt_for_reference): Likewise.
6343         * NEWS: Mention this change.
6344
6345 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6346
6347         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6348         print_source_lines.
6349         * source.c (print_source_lines_base): Update line number check.
6350         (print_source_lines): New function.
6351         (source_lines_range::source_lines_range): New function.
6352         * source.h (class source_lines_range): New class.
6353         (print_source_lines): New declaration.
6354
6355 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6356
6357         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6358
6359 2019-01-08  Tom Tromey  <tom@tromey.com>
6360             Simon Marchi  <simon.marchi@ericsson.com>
6361
6362         PR gdb/24060
6363         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6364         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6365         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6366         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6367         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6368         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6369
6370 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * source.c (select_source_symtab): Move header comment to
6373         declaration in source.h.
6374         (forget_cached_source_info_for_objfile): Likewise.
6375         (forget_cached_source_info): Likewise.
6376         (identify_source_line): Likewise.
6377         * source.h (identify_source_line): Move declaration from symtab.h
6378         and add comment from source.c
6379         (print_source_lines): Likewise.
6380         (forget_cached_source_info_for_objfile): Likewise.
6381         (forget_cached_source_info): Likewise.
6382         (select_source_symtab): Likewise.
6383         (enum print_source_lines_flag): Move definition from symtab.h.
6384         * symtab.h (identify_source_line): Move declaration to source.h.
6385         (print_source_lines): Likewise.
6386         (forget_cached_source_info_for_objfile): Likewise.
6387         (forget_cached_source_info): Likewise.
6388         (select_source_symtab): Likewise.
6389         (enum print_source_lines_flag): Move definition to source.h.
6390         * tui/tui-hooks.c: Add 'source.h' include.
6391
6392 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6393
6394         * source.c (print_source_lines_base): Handle requests to print
6395         reverse line number sequences, and guard against empty lines
6396         string.
6397
6398 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6399
6400         * source.c (print_source_lines_base): Fix skip of '\r' if next
6401         character is '\n'.
6402
6403 2019-01-06  Tom Tromey  <tom@tromey.com>
6404
6405         * c-exp.y (struct c_parse_state) <macro_original_text,
6406         expansion_obstack>: New member.
6407         (macro_original_text, expansion_obstack): Remove globals.
6408         (scan_macro_expansion, scanning_macro_expansion)
6409         (finished_macro_expansion): Update.
6410         (scan_macro_cleanup): Remove.
6411         (yylex, c_parse): Update.
6412
6413 2019-01-06  Tom Tromey  <tom@tromey.com>
6414
6415         * c-exp.y (struct c_parse_state) <strings>: New member.
6416         (operator_stoken): Update.
6417
6418 2019-01-06  Tom Tromey  <tom@tromey.com>
6419
6420         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6421         (union type_stack_elt) <typelist_val>: Now a pointer to
6422         std::vector.
6423         (type_stack_cleanup): Don't declare.
6424         (push_typelist): Update.
6425         * parse.c (pop_typelist): Return a std::vector.
6426         (push_typelist): Take a std::vector.
6427         (follow_types): Update.  Do not free args.
6428         (type_stack_cleanup): Remove.
6429         * c-exp.y (struct c_parse_state): New.
6430         (cpstate): New global.
6431         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6432         (nonempty_typelist): Update.
6433         (func_mod): Create a new vector.
6434         (c_parse): Create a c_parse_state.
6435         (check_parameter_typelist): Do not delete params.
6436         (function_method): Update.  Do not delete type_list.
6437
6438 2019-01-06  Tom Tromey  <tom@tromey.com>
6439
6440         PR gdb/28155:
6441         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6442         check_typedef.
6443         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6444         (print_return_value): Likewise.
6445
6446 2019-01-05  Tom Tromey  <tom@tromey.com>
6447
6448         * contrib/cleanup_check.py: Remove.
6449         * contrib/gcc-with-excheck: Remove.
6450         * contrib/exsummary.py: Remove.
6451         * contrib/excheck.py: Remove.
6452
6453 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6454
6455         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6456         NULL. Initialize tpprev to NULL instead of assigning it
6457         to NULL on the next statement.
6458         * windows-nat.c (windows_delete_thread): Remove check for
6459         main_thread_id before printing thread exit notifications.
6460         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6461         Remove thread ID check against main_thread_id.
6462         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6463         windows_delete_thread.
6464         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6465
6466 2019-01-04  Tom Tromey  <tom@tromey.com>
6467
6468         * compile/compile.c (_initialize_compile): Use upper case for
6469         metasyntactic variables.
6470         * symmisc.c (_initialize_symmisc): Use upper case for
6471         metasyntactic variables.
6472         * psymtab.c (_initialize_psymtab): Use upper case for
6473         metasyntactic variables.
6474         * demangle.c (demangle_command): Use upper case for metasyntactic
6475         variables.
6476         (_initialize_demangler): Likewise.
6477         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6478         variables.
6479
6480 2019-01-03  Tom Tromey  <tom@tromey.com>
6481
6482         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6483
6484 2019-01-03  Tom Tromey  <tom@tromey.com>
6485
6486         * python/py-symtab.c (salpy_str): Update.
6487         (struct salpy_sal_object) <symtab>: Now a PyObject.
6488         (salpy_dealloc): Update.
6489         (del_objfile_sal): Use gdbpy_ref.
6490
6491 2019-01-03  Tom Tromey  <tom@tromey.com>
6492
6493         * python/py-type.c (convert_field): Use new_reference.  Return
6494         gdbpy_ref.
6495         (make_fielditem): Return gdbpy_ref.
6496         (typy_fields): Update.
6497         (typy_getitem): Update.
6498         (field_name): Return gdbpy_ref.  Use new_reference.
6499         (typy_iterator_iternext): Update.
6500
6501 2019-01-03  Tom Tromey  <tom@tromey.com>
6502
6503         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6504
6505 2019-01-03  Tom Tromey  <tom@tromey.com>
6506
6507         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6508         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6509         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6510         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6511         (pspy_set_type_printers): Likewise.
6512         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6513         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6514         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6515         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6516         (objfpy_set_type_printers): Likewise.
6517
6518 2019-01-03  Tom Tromey  <tom@tromey.com>
6519
6520         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6521         (gdbpy_print_stack): Use gdbpy_err_fetch.
6522         * python/python-internal.h (class gdbpy_err_fetch): New class.
6523         (class gdbpy_enter) <m_error_type, m_error_value,
6524         m_error_traceback>: Remove.
6525         <m_error>: New member.
6526         (gdbpy_exception_to_string): Don't declare.
6527         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6528         * python/py-value.c (convert_value_from_python): Use
6529         gdbpy_err_fetch.
6530         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6531         gdbpy_exception_to_string.
6532         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6533         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6534         gdbpy_err_fetch.
6535
6536 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6537
6538         * linux-nat.c (delete_lwp_cleanup): Delete.
6539         (struct lwp_deleter): New struct.
6540         (lwp_info_up): New typedef.
6541         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6542         lwp_info_up.
6543
6544 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6545
6546         * linux-fork.c (class scoped_switch_fork_info): New class.
6547         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6548
6549 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6550
6551         * valops.c (find_overload_match): Remove use of null_cleanup, and
6552         calls to do_cleanups.
6553
6554 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6555
6556         * compile/compile-cplus-types.c
6557         (compile_cplus_instance::decl_name): Handle changes to
6558         cp_func_name.
6559         * cp-support.c (cp_func_name): Update header comment, update
6560         return type.
6561         * cp-support.h (cp_func_name): Update return type in declaration.
6562         * valops.c (find_overload_match): Move temp_func local to top
6563         level of function and change its type.  Use temp_func to hold and
6564         delete temporary string obtained from cp_func_name.
6565
6566 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6567
6568         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6569         gdb::char_vector, remove cleanup, and update uses of `msg`.
6570
6571 2019-01-03  Jim Wilson  <jimw@sifive.com>
6572
6573         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6574
6575 2019-01-02  Tom Tromey  <tom@tromey.com>
6576
6577         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6578         (tdesc_parse_xml): Remove cleanups.
6579         * target-descriptions.h (make_cleanup_free_target_description):
6580         Don't declare.
6581         (target_desc_deleter): New struct.
6582         (target_desc_up): New typedef.
6583         * target-descriptions.c (target_desc_deleter::operator()): Rename
6584         from free_target_description.
6585         (make_cleanup_free_target_description): Remove.
6586
6587 2019-01-02  Tom Tromey  <tom@tromey.com>
6588
6589         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6590         constructor, destructor.
6591         (linespec_parser): Remove typedef.
6592         (~linespec_parser): Rename from linespec_parser_delete.
6593         (linespec_lex_to_end, linespec_complete_label)
6594         (linespec_complete): Update.
6595         (decode_line_full): Remove cleanups.
6596         (decode_line_1): Update.
6597
6598 2019-01-02  Tom Tromey  <tom@tromey.com>
6599
6600         * python/python-internal.h (inferior_to_inferior_object): Change
6601         return type.
6602         * python/py-exitedevent.c (create_exited_event_object): Update.
6603         * python/py-inferior.c (inferior_to_inferior_object): Return
6604         gdbpy_ref.
6605         (python_new_inferior, python_inferior_deleted)
6606         (thread_to_thread_object, delete_thread_object)
6607         (build_inferior_list, gdbpy_selected_inferior): Update.
6608         * python/py-infthread.c (create_thread_object): Update.  Also fail
6609         if inferior_to_inferior_object fails.
6610
6611 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6612
6613         * inferior.h (class inferior) <displaced_step_state>: New field.
6614         * infrun.h (struct displaced_step_state): Move here from
6615         infrun.c.  Initialize fields, add constructor.
6616         <inf>: Remove field.
6617         <reset>: New method.
6618         * infrun.c (struct displaced_step_inferior_state): Move to
6619         infrun.h.
6620         (displaced_step_inferior_states): Remove.
6621         (get_displaced_stepping_state): Adust.
6622         (displaced_step_in_progress_any_inferior): Adjust.
6623         (displaced_step_in_progress_thread): Adjust.
6624         (displaced_step_in_progress): Adjust.
6625         (add_displaced_stepping_state): Remove.
6626         (get_displaced_step_closure_by_addr): Adjust.
6627         (remove_displaced_stepping_state): Remove.
6628         (infrun_inferior_exit): Call displaced_step_state.reset.
6629         (use_displaced_stepping): Don't check for NULL.
6630         (displaced_step_prepare_throw): Call
6631         get_displaced_stepping_state.
6632         (displaced_step_fixup): Don't check for NULL.
6633         (prepare_for_detach): Don't check for NULL.
6634
6635 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6636
6637         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6638          in case of call that did not complete.
6639
6640 2019-01-02  Andrey Utkin  <autkin@undo.io>
6641
6642         * symfile.c (find_separate_debug_file): Fix search of debug files for
6643         remote debuggee.
6644
6645 2019-01-02  Tom Tromey  <tom@tromey.com>
6646
6647         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6648         indentation.
6649         * python/py-frame.c (frapy_older): Remove cast.
6650         (frapy_newer): Likewise.
6651         * python/py-breakpoint.c (local_setattro): Remove cast.
6652         * python/py-arch.c (archpy_name): Remove local variable.
6653         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6654
6655 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6656
6657         * unittests/basic_string_view/element_access/char/empty.cc:
6658         Fix year range in copyright header.
6659
6660 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6663         Delete.
6664         <operator==>: Update with for removed field.
6665         <hash>: Likewise.
6666         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6667         <isa_features>: ...this.
6668         <abi_features>: New field.
6669         (riscv_isa_flen): Update comment.
6670         (riscv_abi_xlen): New declaration.
6671         (riscv_abi_flen): New declaration.
6672         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6673         isa_features.
6674         (riscv_abi_xlen): New function.
6675         (riscv_isa_flen): Update to get answer from isa_features.
6676         (riscv_abi_flen): New function.
6677         (riscv_has_fp_abi): Update to get answer from abi_features.
6678         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6679         xlen and flen.
6680         (riscv_call_info) <xlen, flen>: Update comment.
6681         (riscv_call_arg_struct): Remove invalid assertions
6682         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6683         is removed.
6684         (riscv_gdbarch_init): Gather isa features and abi features
6685         separately, ensure both match on the gdbarch when reusing an old
6686         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6687         a target with 64-bit float hardware.
6688
6689 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6690
6691         * source.c (search_command_helper): Stop reverse search
6692         when line 1 has been searched.
6693
6694 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6695
6696         * record-full.c (record_full_base_target::close): Rewrite
6697         record_full_core_buf_list free logic.
6698
6699 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6700
6701         * break-catch-syscall.c (print_one_catch_syscall): xfree
6702         the last text.
6703
6704 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6705
6706         * top.c (print_gdb_version): Update Copyright year in version
6707         message.
6708
6709 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6710
6711         Update copyright year range in all GDB files.
6712
6713 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6714
6715         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6716
6717 For older changes see ChangeLog-2018.
6718 \f
6719 Local Variables:
6720 mode: change-log
6721 left-margin: 8
6722 fill-column: 74
6723 version-control: never
6724 coding: utf-8
6725 End:
6726