gdb/ChangeLog

   1 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         PR breakpoints/24541
   4         * gdbarch.c: Regenerate.
   5         * gdbarch.h: Regenerate.
   6         * gdbarch.sh: Adjust return type and parameter types for
   7         'stap_adjust_register'.
   8         (i386_stap_adjust_register): Adjust signature and return new
   9         register name.
  10         * stap-probe.c (stap_parse_register_operand): Adjust use of
  11         'gdbarch_stap_adjust_register'.
  12
  13 2019-07-17  Tom Tromey  <tromey@adacore.com>
  14
  15         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
  16         declare VEC.
  17         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
  18         std::vector.
  19         (struct s390_process_info): Add initializers.
  20         (s390_add_process): Use new.
  21         (s390_linux_nat_target::low_forget_process): Use delete.
  22         (s390_linux_nat_target::low_new_fork)
  23         (s390_linux_nat_target::stopped_by_watchpoint)
  24         (s390_linux_nat_target::low_prepare_to_resume)
  25         (s390_linux_nat_target::insert_watchpoint)
  26         (s390_linux_nat_target::insert_hw_breakpoint)
  27         (s390_linux_nat_target::remove_watchpoint)
  28         (s390_linux_nat_target::remove_hw_breakpoint): Update.
  29
  30 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
  31
  32         * aarch64-fbsd-nat.c: Include regcache.h.
  33         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
  34         argument.
  35         (aarch64_fbsd_nat_target::fetch_registers)
  36         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
  37         variable.
  38         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
  39
  40 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
  41
  42         * fbsd-nat.c: Include gdbarch.h.
  43
  44 2019-07-15  Tom Tromey  <tromey@adacore.com>
  45
  46         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
  47
  48 2019-07-15  Tom Tromey  <tromey@adacore.com>
  49
  50         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
  51         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
  52         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
  53         * cli-out.c (cli_ui_out::do_field_int): New method.
  54         * ui-out.c (ui_out::field_unsigned): New method.
  55         * symfile.c (generic_load): Use field_unsigned.
  56         (print_transfer_performance): Likewise.
  57         * record-btrace.c (ui_out_field_uint): Remove.
  58         (btrace_call_history_insn_range, btrace_call_history): Use
  59         field_unsigned.
  60         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
  61         field_unsigned.
  62         * ui-out.h (class ui_out) <field_unsigned>: New method.
  63         <do_field_unsigned>: Likewise.
  64
  65 2019-07-15  Tom Tromey  <tromey@adacore.com>
  66
  67         * mi/mi-main.c (list_available_thread_groups): Use field_string.
  68         * mi/mi-interp.c (mi_memory_changed): Use field_string.
  69         * target.c (flash_erase_command): Use field_string.
  70         * infrun.c (print_signal_received_reason): Use field_string.
  71         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
  72         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
  73         field_string.
  74         * ada-tasks.c (print_ada_task_info): Use field_string.
  75
  76 2019-07-15  Tom Tromey  <tromey@adacore.com>
  77
  78         * target.c (flash_erase_command): Use field_core_addr.
  79         * symfile.c (generic_load): Use field_core_addr.
  80         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
  81         Use field_core_addr.
  82         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
  83         field_core_addr.
  84
  85 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  86
  87         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
  88         value if its desired type is smaller than a CORE_ADDR and signed.
  89
  90 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  91
  92         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
  93         of changes to field names, and use new is_reference field to
  94         decide if a property is a reference or not.
  95         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
  96         field.
  97         (struct dwarf2_property_baton): Update header comment, rename
  98         'referenced_type' to 'property_type' and update comments.
  99         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 100         default property type, store in property baton, update to take
 101         accound of renamed field.
 102         (read_func_scope): Update call to attr_to_dynamic_prop.
 103         (read_array_type): Likewise.
 104         (dwarf2_per_cu_addr_sized_int_type): New function.
 105         (read_subrange_index_type): Move type finding code to
 106         dwarf2_per_cu_addr_sized_int_type.
 107         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 108         (dwarf2_per_cu_addr_type): New function.
 109         (set_die_type): Update calls to attr_to_dynamic_prop.
 110
 111 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 112
 113         * dwarf2read.c (read_subrange_index_type): New function.
 114         (read_subrange_type): Move code into new function and call it.
 115         * gdbtypes.c (create_range_type): Add some asserts.
 116
 117 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 118
 119         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 120         update return statements.
 121         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 122         declaration, and update comment to match.
 123         * gdbtypes.c (resolve_dynamic_array): Update call to
 124         dwarf2_evaluate_property to match new return type.
 125
 126 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 127
 128         * valarith.c (value_subscripted_rvalue): Change lowerbound
 129         parameter type from int to LONGEST.
 130         * value.h (value_subscripted_rvalue): Likewise in declaration.
 131
 132 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 133
 134         * cli/cli-utils.c (info_print_command_completer): New function.
 135         * cli/cli-utils.h: Add 'completer.h' include, and forward
 136         declaration for 'struct cmd_list_element'.
 137         (info_print_command_completer): Declare.
 138         * stack.c (_initialize_stack): Add completer for 'info locals' and
 139         'info args'.
 140         * symtab.c (_initialize_symtab): Add completer for 'info
 141         variables' and 'info functions'.
 142         * NEWS: Mention completion for additional info commands.
 143
 144 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 145
 146         * cli/cli-utils.c (extract_info_print_args): Delete.
 147         (extract_arg_maybe_quoted): Delete.
 148         (info_print_options_defs): New variable.
 149         (make_info_print_options_def_group): New function.
 150         (extract_info_print_options): Define new function.
 151         * cli/cli-utils.h (extract_info_print_args): Delete.
 152         (struct info_print_options): New structure.
 153         (extract_info_print_options): Declare new function.
 154         * stack.c (info_locals_command): Update to use new
 155         extract_info_print_options, also add a header comment.
 156         (info_args_command): Likewise.
 157         * symtab.c (info_variables_command): Likewise.
 158         (info_functions_command): Likewise.
 159
 160 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 161
 162         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 163         to extract string arguments.
 164         * common/common-utils.c (extract_string_maybe_quoted): New function.
 165         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 166
 167 2019-07-11  Tom Tromey  <tromey@adacore.com>
 168
 169         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 170         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 171         * top.h (gdbinit): Don't declare.
 172         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 173         into...
 174         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 175         * top.c (gdb_init): Don't call init_cli_cmds.
 176         (gdbinit): Remove.
 177         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 178
 179 2019-07-11  Tom Tromey  <tromey@adacore.com>
 180
 181         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 182         after it has been moved.
 183
 184 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 185
 186         * valops.c (value_must_coerce_to_target): Change return type to
 187         bool.
 188         * value.h (value_must_coerce_to_target): Likewise.
 189
 190 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 191
 192         * breakpoint.c (is_hardware_watchpoint): Remove
 193         forward-declaration.
 194         (is_masked_watchpoint): Change return type to bool.
 195         (is_tracepoint): Likewise.
 196         (is_breakpoint): Likewise.
 197         (is_hardware_watchpoint): Likewise.
 198         (is_watchpoint): Likewise.
 199         (is_no_memory_software_watchpoint): Likewise.
 200         (is_catchpoint): Likewise.
 201         (breakpoint_1): Make FILTER parameter's return type bool.
 202         is_masked_watchpoint): Change return type to bool.
 203         (save_breakpoints): Make FILTER parameter's return type bool.
 204         * breakpoint.h (is_breakpoint): Change return type to bool.
 205         (is_watchpoint): Likewise.
 206         (is_catchpoint): Likewise.
 207         (is_tracepoint): Likewise.
 208
 209 2019-07-10  Tom Tromey  <tom@tromey.com>
 210
 211         * defs.h: Don't include gdbarch.h.
 212         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 213         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 214         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 215         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 216         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 217         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 218         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 219         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 220         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 221         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 222         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 223         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 224         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 225         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 226         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 227         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 228         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 229         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 230         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 231         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 232         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 233         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 234         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 235         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 236         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 237         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 238         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 239
 240 2019-07-10  Tom Tromey  <tromey@adacore.com>
 241
 242         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 243         * breakpoint.c (init_ada_exception_breakpoint): Register as
 244         bp_catchpoint.
 245         (print_one_breakpoint_location, print_one_breakpoint): Use
 246         is_ada_exception_catchpoint.
 247         * ada-lang.c (class ada_catchpoint_location): Pass
 248         bp_loc_software_breakpoint to bp_location constructor.
 249         (is_ada_exception_catchpoint): New function.
 250
 251 2019-07-10  Tom Tromey  <tromey@adacore.com>
 252
 253         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 254         VEC.
 255         (struct arm_exidx_entry): New method operator<.
 256         (struct arm_exidx_data) <section_maps>: Change type.
 257         (arm_exidx_data_free): Remove.
 258         (arm_exidx_data_key): Change type.  Move lower.
 259         (arm_exidx_new_objfile): Update.
 260         (arm_compare_exidx_entries): Remove.
 261         (arm_find_exidx_entry, _initialize_arm_tdep)
 262
 263 2019-07-10  Tom Tromey  <tromey@adacore.com>
 264
 265         * solib-spu.c (ocl_program_data_key): Change type.
 266         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 267         Update.
 268
 269 2019-07-10  Tom Tromey  <tromey@adacore.com>
 270
 271         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 272         (struct solib_aix_inferior_data) <library_list>: Change type.
 273         (solib_aix_inferior_data_handle): Change type.
 274         (get_solib_aix_inferior_data): Update.
 275         (solib_aix_free_library_list): Remove.
 276         (library_list_start_library): Update.
 277         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 278         return type.
 279         (solib_aix_get_library_list)
 280         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 281         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 282
 283 2019-07-10  Tom Tromey  <tromey@adacore.com>
 284
 285         * solib-dsbt.c (struct dsbt_info): Add initializers.
 286         (solib_dsbt_pspace_data): Change type.
 287         (dsbt_pspace_data_cleanup): Remove.
 288         (get_dsbt_info, _initialize_dsbt_solib): Update.
 289
 290 2019-07-10  Tom Tromey  <tromey@adacore.com>
 291
 292         * spu-tdep.c (spu_overlay_data): Change type.
 293         (spu_get_overlay_table, spu_overlay_new_objfile)
 294         (_initialize_spu_tdep): Update.
 295
 296 2019-07-10  Tom Tromey  <tromey@adacore.com>
 297
 298         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 299         destructor.
 300         (dbx_objfile_data_key): Change type and declare later.
 301         (DBX_SYMFILE_INFO): Rewrite.
 302         * dbxread.c (dbx_objfile_data_key): Change type.
 303         (dbx_symfile_init): Update.
 304         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 305         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 306         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 307
 308 2019-07-10  Tom Tromey  <tromey@adacore.com>
 309
 310         * jit.c (jit_program_space_key): Change type.  Move lower.
 311         (get_jit_program_space_data): Update.
 312         (jit_program_space_data_cleanup): Remove.
 313         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 314         Update.
 315         (struct jit_program_space_data): Add initializers.
 316
 317 2019-07-10  Tom Tromey  <tromey@adacore.com>
 318
 319         * solib-darwin.c (struct darwin_info): Add initializers.
 320         (solib_darwin_pspace_data): Change type.
 321         (darwin_pspace_data_cleanup): Remove.
 322         (get_darwin_info, _initialize_darwin_solib): Update.
 323
 324 2019-07-10  Tom Tromey  <tromey@adacore.com>
 325
 326         * remote-sim.c (struct sim_inferior_data): Add initializers,
 327         constructor, and destructor.
 328         (sim_inferior_data_key): Change type.  Move lower.
 329         (check_for_duplicate_sim_descriptor): Update.
 330         (get_sim_inferior_data): Use new.  Update.
 331         (~sim_inferior_data_cleanup): Rename from
 332         sim_inferior_data_cleanup.  Simplify.
 333         (gdbsim_close_inferior, simulator_command)
 334         (sim_command_completer, _initialize_remote_sim): Update.
 335         (next_pid, INITIAL_PID): Move earlier.
 336
 337 2019-07-10  Tom Tromey  <tromey@adacore.com>
 338
 339         * python/python-internal.h (create_thread_object): Return
 340         gdbpy_ref.
 341         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 342         * python/py-inferior.c (struct threadlist_entry): Add
 343         constructor.
 344         <thread_obj>: Now a gdbpy_ref.
 345         (thread_to_thread_object): Update.
 346         (add_thread_object): Use new.
 347         (delete_thread_object): Use delete.
 348         (infpy_threads): Update.
 349         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 350         GIL.
 351
 352 2019-07-10  Tom Tromey  <tromey@adacore.com>
 353
 354         * valops.c (value_cast): Specialize error message for Ada.
 355
 356 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 357
 358         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 359
 360 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 361
 362         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 363         bpstat_should_step): Return bool, adjust comments.
 364         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 365         bpstat_should_step): Likewise.
 366
 367 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 368
 369         * features/Makefile: Use feature target descriptions for Arm.
 370         * features/arm/arm-core.c: Generate new file.
 371         * features/arm/arm-fpa.c: Likewise.
 372         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 373         * features/arm/arm-m-profile.c: Likewise.
 374         * features/arm/arm-vfpv2.c: Likewise.
 375         * features/arm/arm-vfpv3.c: Likewise.
 376         * features/arm/xscale-iwmmxt.c: Likewise.
 377         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 378
 379 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 380
 381         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 382         ptrace earlier.
 383
 384 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 385
 386         * features/aarch64-pauth.c: Regenerate.
 387
 388 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 389
 390         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 391         bool.
 392         (bpstat_what): Use false instead of 0.
 393
 394 2019-07-09  Pedro Alves  <palves@redhat.com>
 395
 396         * break-catch-throw.c (is_exception_catchpoint): New.
 397         * breakpoint.c (print_one_breakpoint_location): New parameter
 398         'raw_loc'.  Handle it.  Use
 399         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 400         looking at the breakpoint's type.
 401         (print_one_breakpoint): If handling "maint info breakpoints", also
 402         print locations of exception catchpoints.
 403         * breakpoint.h (is_exception_catchpoint): Declare.
 404
 405 2019-07-09  Pedro Alves  <palves@redhat.com>
 406
 407         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 408         "addr" field.
 409         (allocate_location_exception_catchpoint): New.
 410         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 411         (initialize_throw_catchpoint_ops): Install
 412         allocate_location_exception_catchpoint as allocate_location
 413         method.
 414         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 415         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 416         bp_loc_other.
 417         (breakpoint_address_is_meaningful): Delete.
 418         (bl_address_is_meaningful): New.
 419         (breakpoint_locations_match): Adjust comment.
 420         (bp_location_from_bp_type): New, factored out of...
 421         (bp_location::bp_location(breakpoint *)): ... this.
 422         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 423         factored out of...
 424         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 425         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 426         breakpoint_address_is_meaningful.
 427         (bp_locations_compare): Adjust comment.
 428         (update_global_location_list): Use bl_address_is_meaningful
 429         instead of breakpoint_address_is_meaningful.
 430         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 431         explicit.
 432         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 433         * python/py-breakpoint.c (bppy_get_location): No longer check
 434         whether location is null.
 435
 436 2019-07-09  Pedro Alves  <palves@redhat.com>
 437
 438         PR c++/15468
 439         * breakpoint.c (print_one_breakpoint_location): Remove
 440         single-location assert.
 441
 442 2019-07-09  Tom Tromey  <tom@tromey.com>
 443
 444         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 445         * configure: Rebuild.
 446         * configure.ac: Change common to gdbsupport.
 447         * gdbsupport: Rename from common.
 448         * acinclude.m4: Change common to gdbsupport.
 449         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 450         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 451         gdbsupport.
 452         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 453         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 454         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 455         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 456         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 457         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 458         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 459         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 460         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 461         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 462         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 463         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 464         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 465         coff-pe-read.c, command.h, compile/compile-c-support.c,
 466         compile/compile-c.h, compile/compile-cplus-symbols.c,
 467         compile/compile-cplus-types.c, compile/compile-cplus.h,
 468         compile/compile-loc2c.c, compile/compile.c, completer.c,
 469         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 470         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 471         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 472         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 473         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 474         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 475         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 476         features/aarch64-core.c, features/aarch64-fpu.c,
 477         features/aarch64-pauth.c, features/aarch64-sve.c,
 478         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 479         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 480         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 481         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 482         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 483         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 484         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 485         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 486         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 487         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 488         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 489         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 490         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 491         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 492         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 493         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 494         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 495         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 496         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 497         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 498         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 499         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 500         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 501         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 502         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 503         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 504         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 505         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 506         minsyms.c, mips-linux-tdep.c, namespace.h,
 507         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 508         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 509         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 510         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 511         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 512         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 513         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 514         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 515         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 516         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 517         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 518         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 519         procfs.c, producer.c, progspace.h, psymtab.h,
 520         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 521         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 522         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 523         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 524         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 525         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 526         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 527         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 528         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 529         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 530         target-memory.c, target.c, target.h, target/waitstatus.c,
 531         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 532         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 533         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 534         unittests/array-view-selftests.c,
 535         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 536         unittests/common-utils-selftests.c,
 537         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 538         unittests/format_pieces-selftests.c,
 539         unittests/function-view-selftests.c,
 540         unittests/lookup_name_info-selftests.c,
 541         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 542         unittests/mkdir-recursive-selftests.c,
 543         unittests/observable-selftests.c,
 544         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 545         unittests/parse-connection-spec-selftests.c,
 546         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 547         unittests/scoped_fd-selftests.c,
 548         unittests/scoped_mmap-selftests.c,
 549         unittests/scoped_restore-selftests.c,
 550         unittests/string_view-selftests.c, unittests/style-selftests.c,
 551         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 552         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 553         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 554         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 555         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 556         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 557
 558 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 559
 560         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 561         bool value.
 562         (decode_digits_ordinary): Set explicit_line field in sal.
 563         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 564         symtab_and_line that was set on an explicit line number in
 565         assembler code.  Do always update the recorded symtab and line if
 566         we do skip the prologue.
 567
 568 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * breakpoint.c (set_breakpoint_location_function): Remove
 571         explicit_loc parameter.
 572         (momentary_breakpoint_from_master): Update call to
 573         set_breakpoint_location_function.
 574         (add_location_to_breakpoint): Likewise.
 575
 576 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 579         required features based on default bfd type when no specific bfd
 580         is present.
 581
 582 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 583
 584         * NEWS: Mention that GDB printf and eval commands can now print
 585         C-style and Ada-style convenience var strings without
 586         calling the inferior.
 587         * printcmd.c (printf_c_string): Locally print GDB internal var
 588         instead of transiting via the inferior.
 589         (printf_wide_c_string): Likewise.
 590
 591 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 592
 593         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 594
 595 2019-07-04  Tom Tromey  <tom@tromey.com>
 596
 597         PR tui/24724:
 598         * tui/tui-winsource.c (tui_clear_source_content): Update.
 599         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 600         (tui_update_breakpoint_info): Update.
 601         (tui_set_exec_info_content): Update.
 602         * tui/tui-source.c (tui_set_source_content_nil): Update.
 603         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 604         has_break.
 605         * tui/tui-data.h (enum tui_bp_flag): New.
 606         (tui_bp_flags): New enum flags type.
 607         (struct tui_source_element) <break_mode>: Change type.  Rename
 608         from has_break.
 609         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 610         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 611         constants.
 612         * tui/tui-winsource.h: Fix comment.
 613
 614 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 615
 616         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 617         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 618         (store_fpregs_to_thread)
 619         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 620         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 621         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 622         (IWMMXT_REGS_SIZE): Add define.
 623         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 624         (fetch_vfp_regs, store_vfp_regs)
 625         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 626         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 627
 628 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 629
 630         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 631         defines.
 632         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 633         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 634         (ARM_INT_REGISTER_SIZE): ...to this.
 635         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 636         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 637         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 638         (arm_linux_collect_gregset, supply_nwfpe_register)
 639         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 640         defines.
 641         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 642         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 643         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 644         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 645         (arm_return_in_memory, arm_store_return_value)
 646         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 647         (arm_record_ld_st_multiple): Likewise.
 648         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 649         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 650
 651 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 652
 653         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 654         AARCH64_DISPLACED_MODIFIED_INSNS.
 655         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 656         (aarch64_displaced_step_copy_insn): Likewise.
 657         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 658         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 659         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 660         ARM_DISPLACED_MODIFIED_INSNS.
 661         * arm-tdep.c (arm_gdbarch_init): Likewise.
 662         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 663         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 664         (struct arm_displaced_step_closure): Use
 665         ARM_DISPLACED_MODIFIED_INSNS.
 666
 667 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 668
 669         * features/Makefile: Remove unused xml files.
 670         * features/aarch64.xml: Remove.
 671         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 672         * features/i386/amd64-avx-avx512.xml: Remove.
 673         * features/i386/amd64-avx-linux.xml: Remove.
 674         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 675         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 676         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 677         * features/i386/amd64-avx-mpx.xml: Remove.
 678         * features/i386/amd64-avx.xml: Remove.
 679         * features/i386/amd64-linux.xml: Remove.
 680         * features/i386/amd64-mpx-linux.xml: Remove.
 681         * features/i386/amd64-mpx.xml: Remove.
 682         * features/i386/amd64.xml: Remove.
 683         * features/i386/i386-avx-avx512-linux.xml: Remove.
 684         * features/i386/i386-avx-avx512.xml: Remove.
 685         * features/i386/i386-avx-linux.xml: Remove.
 686         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 687         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 688         * features/i386/i386-avx-mpx-linux.xml: Remove.
 689         * features/i386/i386-avx-mpx.xml: Remove.
 690         * features/i386/i386-avx.xml: Remove.
 691         * features/i386/i386-linux.xml: Remove.
 692         * features/i386/i386-mmx-linux.xml: Remove.
 693         * features/i386/i386-mmx.xml: Remove.
 694         * features/i386/i386-mpx-linux.xml: Remove.
 695         * features/i386/i386-mpx.xml: Remove.
 696         * features/i386/i386.xml: Remove.
 697         * features/i386/x32-avx-avx512-linux.xml: Remove.
 698         * features/i386/x32-avx-linux.xml: Remove.
 699         * features/i386/x32-linux.xml: Remove.
 700
 701 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 702
 703         * regformats/aarch64.dat: Remove.
 704         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 705         * regformats/i386/amd64-avx-linux.dat: Remove.
 706         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 707         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 708         * regformats/i386/amd64-linux.dat: Remove.
 709         * regformats/i386/amd64-mpx-linux.dat: Remove.
 710         * regformats/i386/amd64.dat: Remove.
 711         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 712         * regformats/i386/i386-avx-linux.dat: Remove.
 713         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 714         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 715         * regformats/i386/i386-linux.dat: Remove.
 716         * regformats/i386/i386-mmx-linux.dat: Remove.
 717         * regformats/i386/i386-mpx-linux.dat: Remove.
 718         * regformats/i386/i386.dat: Remove.
 719         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 720         * regformats/i386/x32-avx-linux.dat: Remove.
 721         * regformats/i386/x32-linux.dat: Remove.
 722
 723 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 724
 725         * aarch64-tdep.c: Remove xml self tests.
 726         * amd64-linux-tdep.c: Likewise.
 727         * amd64-tdep.c: Likewise.
 728         * i386-linux-tdep.c: Likewise.
 729         * i386-tdep.c: Likewise.
 730
 731 2019-07-03  Pedro Alves  <palves@redhat.com>
 732
 733         PR cli/24732
 734         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 735         (pipe_cmd_option_defs): New.
 736         (make_pipe_cmd_options_def_group): New.
 737         (pipe_command): Use gdb::option::process_options.
 738         (pipe_command_completer): New function.
 739         (_initialize_cli_cmds): Install completer for "pipe" command.
 740
 741 2019-07-03  Pedro Alves  <palves@redhat.com>
 742
 743         * cli/cli-option.c (union option_value) <string>: New field.
 744         (struct option_def_and_value): Add ctor, move ctor, dtor and
 745         use DISABLE_COPY_AND_ASSIGN.
 746         (option_def_and_value::clear_value): New.
 747         (parse_option, save_option_value_in_ctx, get_val_type_str)
 748         (add_setshow_cmds_for_options): Handle var_string.
 749         * cli-option.h (union option_def::var_address) <string>: New
 750         field.
 751         (struct string_option_def): New.
 752         * maint-test-options.c (struct test_options_opts): Add default
 753         ctor and use DISABLE_COPY_AND_ASSIGN.
 754         <string_opt>: New field.
 755         (test_options_opts::~test_options_opts): New.
 756         (test_options_opts::dump): Also dump "-string".
 757         (test_options_option_defs): Install "string.
 758
 759 2019-07-03  Pedro Alves  <palves@redhat.com>
 760
 761         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 762         option_value with a null enumeration.
 763         (complete_options): Save the option values in the context.
 764         (save_option_value_in_ctx): New, factored out from ...
 765         (process_options): ... here.
 766         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 767         of the function.
 768         * maint-test-options.c (test_options_opts::dump): New, factored
 769         out from ...
 770         (maintenance_test_options_command_mode): ... here.
 771         (maintenance_test_options_command_completion_result): Delete.
 772         (maintenance_test_options_command_completion_text): Update
 773         comment.
 774         (maintenance_show_test_options_completion_result): Change
 775         prototype.  Just print
 776         maintenance_test_options_command_completion_text.
 777         (save_completion_result): New.
 778         (maintenance_test_options_completer_mode): Pass options context to
 779         complete_options, and then save a dump.
 780         (_initialize_maint_test_options): Use add_cmd to install "maint
 781         show test-options-completion-result".
 782
 783 2019-07-03  Pedro Alves  <palves@redhat.com>
 784
 785         * NEWS (New commands): Mention "with" and "maint with".
 786         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 787         (with_command, with_command_completer): New.
 788         (pipe_command): Adjust to new repeat_previous
 789         interface.
 790         (_initialize_cli_cmds): Install the "with" command and its "w"
 791         alias.
 792         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 793         declarations.
 794         * cli/cli-setshow.c (parse_cli_var_uinteger)
 795         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 796         argument strings for all var_types.
 797         (get_setshow_command_value_string): New, factored out from ...
 798         (do_show_command): ... this.
 799         * cli/cli-setshow.h: Include <string>.
 800         (get_setshow_command_value_string): Declare.
 801         * command.h (repeat_previous): Now returns const char *.  Adjust
 802         comment.
 803         * maint.c: Include "cli/cli-cmds.h".
 804         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 805         (_initialize_maint_cmds): Register the "maintenance with" command.
 806         * top.c (repeat_previous): Move bits from pipe_command here:
 807         Return the saved command line, if any; error out if there's no
 808         command to relaunch.
 809
 810 2019-07-03  Pedro Alves  <palves@redhat.com>
 811
 812         * NEWS (New commands): Mention "maint set/show test-settings"
 813         instead of "maint test-settings".
 814         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 815         (maintenance_test_settings_set_list): Rename to ...
 816         (maintenance_set_test_settings_list): ... this.
 817         (maintenance_test_settings_show_list): Rename to  ...
 818         (maintenance_show_test_settings_list): ... this.
 819         (maintenance_test_settings_cmd): Delete.
 820         (maintenance_test_settings_set_cmd): ...
 821         (maintenance_set_test_settings_cmd): ... this.
 822         (maintenance_test_settings_show_cmd): ...
 823         (maintenance_show_test_settings_cmd): ... this.
 824         (maintenance_test_settings_show_value_cmd):
 825         (maintenance_show_test_settings_value_cmd): ... this.
 826         (_initialize_maint_test_settings): No longer install the "maint
 827         test-settings" prefix command.  Rename "maint test-settings set"
 828         to "maint set test-settings", and "maint test-settings show" to
 829         "maint show test-settings".  Adjust all subcommands.
 830
 831 2019-07-03  Pedro Alves  <palves@redhat.com>
 832
 833         * maint-test-settings.c: Fix file's intro comment.  Replace all
 834         references to "test-options" with references to "test-settings",
 835         in comments.
 836
 837 2019-07-03  Pedro Alves  <palves@redhat.com>
 838
 839         * maint-test-settings.c (maintenance_test_settings_xxx)
 840         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 841         New.
 842         (maintenance_test_settings_enums): Use them.
 843         (maintenance_test_settings_enum): Default to
 844         maintenance_test_settings_xxx.
 845         (_initialize_maint_test_settings): Initialize
 846         MAINTENANCE_TEST_SETTINGS_FILENAME.
 847
 848 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 849
 850         * breakpoint.h (remove_breakpoints_inf): Change return type to
 851         void, move function documentation here.
 852         * breakpoint.c (remove_breakpoints_inf): Change return type to
 853         void, move function documentation to header.
 854
 855 2019-07-02  Pedro Alves  <palves@redhat.com>
 856
 857         * NEWS (Completion improvements): Mention "info threads".
 858         * thread.c (struct info_threads_opts, info_threads_option_defs)
 859         (make_info_threads_options_def_group): New.
 860         (info_threads_command): Use gdb::option::process_options.
 861         (info_threads_command_completer): New.
 862         (_initialize_thread): Use gdb::option::build_help to build the
 863         help text for "info threads".
 864
 865 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 866
 867         * defs.h (generic_load): Move from here...
 868         * symfile.h (generic_load): ... to here.  Rename name parameter
 869         to args.
 870         * symfile.c (generic_load): Add comment.
 871
 872 2019-07-01  Tom Tromey  <tromey@adacore.com>
 873
 874         * dwarf2read.c
 875         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 876         declaration of without_params.  Fix formatting.
 877
 878 2019-07-01  Tom Tromey  <tromey@adacore.com>
 879
 880         * ada-exp.y (find_primitive_type): Update.
 881         * ada-lang.h (ada_lookup_symbol): Update.
 882         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 883         parameter.
 884         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 885
 886 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 887
 888         PR breakpoints/24541
 889         * gdbarch.c: Regenerate.
 890         * gdbarch.h: Regenerate.
 891         * gdbarch.sh: Add 'stap_adjust_register'.
 892         * i386-tdep.c: Include '<unordered_set>'.
 893         (i386_stap_adjust_register): New function.
 894         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 895         * stap-probe.c (stap_parse_register_operand): Call
 896         'gdbarch_stap_adjust_register'.
 897
 898 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 899
 900         PR python/24742
 901         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 902         * python/python.c (do_start_initialization): Use 'xmalloc'
 903         instead of 'PyMem_Malloc'.
 904
 905 2019-06-28  Tom Tromey  <tromey@adacore.com>
 906
 907         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 908         for Ada.
 909
 910 2019-06-27  Tom Tromey  <tromey@adacore.com>
 911
 912         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 913         objfile_key.
 914         (arm_find_mapping_symbol, arm_record_special_symbol)
 915         (_initialize_arm_tdep): Update.
 916         (arm_objfile_data_free): Remove.
 917
 918 2019-06-27  Tom Tromey  <tromey@adacore.com>
 919
 920         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 921         to cp_print_static_field.
 922
 923 2019-06-26  Tom Tromey  <tromey@adacore.com>
 924
 925         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 926         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 927         declare.
 928
 929 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 930
 931         * features/aarch64-core.c (create_feature_aarch64_core):
 932         Regenerate.
 933         * features/aarch64-core.xml: Add cpsr flags.
 934
 935 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 936
 937         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 938         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 939
 940 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 941
 942         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 943         field.
 944         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 945         use.
 946         (arm_record_special_symbol): Don't insert new symbol in sorted
 947         position, push it at the end.
 948
 949 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 950
 951         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 952         (arm_mapping_symbol_s): Remove.
 953         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 954         (arm_mapping_symbol_vec): New typedef.
 955         (struct arm_per_objfile): Add constructor.
 956         <section_maps>: Change type to
 957         std::unique_ptr<arm_mapping_symbol_vec[]>.
 958         (arm_compare_mapping_symbols): Remove.
 959         (arm_find_mapping_symbol): Adjust to section_maps type change.
 960         (arm_objfile_data_free): Call delete on arm_per_objfile.
 961         (arm_record_special_symbol): Adjust to section_maps type change.
 962         Allocate arm_per_objfile with new.
 963
 964 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 965
 966         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 967         with the command prefix.
 968
 969 2019-06-25  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 972         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 973
 974 2019-06-25  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 977         type.
 978         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 979         protected.
 980
 981 2019-06-25  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-winsource.c
 984         (tui_source_window_base::set_is_exec_point_at): Add check against
 985         LOA_ADDRESS.
 986
 987 2019-06-25  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-source.c (tui_set_source_content): Don't check before
 990         xfree.
 991         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 992
 993 2019-06-25  Tom Tromey  <tom@tromey.com>
 994
 995         * tui/tui-winsource.h (tui_update_source_window_as_is)
 996         (tui_alloc_source_buffer, tui_line_is_displayed)
 997         (tui_addr_is_displayed): Change type of win_info.
 998         * tui/tui-winsource.c (tui_update_source_window_as_is)
 999         (tui_clear_source_content, tui_show_source_line)
1000         (tui_show_source_content, tui_source_window_base::refill)
1001         (tui_source_window_base::set_is_exec_point_at)
1002         (tui_source_window_base::set_is_exec_point_at)
1003         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1004         (tui_alloc_source_buffer, tui_line_is_displayed)
1005         (tui_addr_is_displayed): Change type of win_info.  Update.
1006         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1007         (tui_source_window_base::do_make_visible_with_new_height):
1008         Update.
1009         * tui/tui-source.c (tui_set_source_content)
1010         (tui_set_source_content_nil)
1011         (tui_source_window::do_scroll_vertical): Update.
1012         * tui/tui-layout.c (show_layout): Update.
1013         * tui/tui-disasm.c (tui_set_disassem_content)
1014         (tui_disasm_window::do_scroll_vertical): Update.
1015         * tui/tui-data.h (tui_win_content): Remove.
1016         (struct tui_gen_win_info) <content, content_size>: Remove.
1017         (struct tui_source_element): Add initializers and destructor.
1018         (union tui_which_element, struct tui_win_element): Remove.
1019         (struct tui_source_window_base) <content>: New field.
1020         (struct tui_data_window): Remove destructor.
1021         (tui_alloc_content, tui_free_win_content)
1022         (tui_free_all_source_wins_content): Don't declare.
1023         * tui/tui-data.c (tui_initialize_static_data): Update.
1024         (init_content_element, tui_alloc_content): Remove.
1025         (~tui_gen_win_info): Update.
1026         (~tui_data_window, tui_free_all_source_wins_content)
1027         (tui_free_win_content, free_content, free_content_elements):
1028         Remove.
1029
1030 2019-06-25  Tom Tromey  <tom@tromey.com>
1031
1032         * tui/tui-winsource.h (tui_clear_source_content)
1033         (tui_erase_source_content, tui_show_source_content): Change type
1034         of win_info.
1035         * tui/tui-winsource.c (tui_clear_source_content)
1036         (tui_erase_source_content, tui_show_source_content): Change type
1037         of win_info.
1038         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1039         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1040         win_info.
1041         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1042         win_info.
1043         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1044
1045 2019-06-25  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-winsource.c (tui_clear_source_content)
1048         (tui_source_window_base::set_is_exec_point_at): Update.
1049         * tui/tui-source.c (tui_set_source_content_nil): Update.
1050         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1051         a bool.
1052         * tui/tui-data.c (init_content_element): Update.
1053
1054 2019-06-25  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1057         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1058         * tui/tui-layout.c (init_and_make_win): Update.
1059         * tui/tui.h (enum tui_win_type): Update.
1060         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1061         tui_win_is_auxillary.
1062         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1063         tui_win_is_auxillary.
1064
1065 2019-06-25  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1068         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1069         (tui_delete_data_content_windows, tui_display_all_data)
1070         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1071         Update.
1072         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1073         * tui/tui-regs.c (tui_last_regs_line_no)
1074         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1075         (tui_show_registers): Update.
1076         (tui_show_register_group): Return void.  Update.
1077         (tui_display_registers_from, tui_display_reg_element_at_line)
1078         (tui_display_registers_from_line, tui_check_register_values):
1079         Update.
1080         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1081         member.
1082         (struct tui_data_window) <regs_content>: Now a std::vector.
1083         <regs_content_count>: Remove.
1084         (tui_add_content_elements, tui_free_data_content): Don't declare.
1085         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1086         (init_content_element): Remove DATA_WIN case.  Add assert.
1087         (tui_add_content_elements): Remove.
1088         (tui_data_window): Update.
1089         (tui_free_data_content): Remove.
1090         (free_content_elements): Remove DATA_WIN case.
1091
1092 2019-06-25  Tom Tromey  <tom@tromey.com>
1093
1094         * tui/tui-data.c (tui_data_item_window): Update.
1095         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1096         * tui/tui-windata.c (tui_display_all_data)
1097         (tui_display_data_from_line): Update.
1098         (tui_check_data_values): Remove.
1099         * tui/tui-regs.c (tui_show_register_group)
1100         (tui_display_reg_element_at_line): Update.
1101         * tui/tui-hooks.c (tui_register_changed)
1102         (tui_refresh_frame_and_register_information): Call
1103         tui_check_register_values.
1104         * tui/tui-data.h (struct tui_data_window) <data_content,
1105         data_content_count, data_type>: Remove.
1106         (enum tui_data_type): Remove.
1107
1108         * tui/tui-data.c (tui_data_window::clear_detail)
1109         (~tui_data_window): Update.
1110
1111 2019-06-25  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1114         declare.
1115         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1116         Rename from tui_first_data_item_displayed.  Update.
1117         (tui_data_window::refresh_all)
1118         (tui_data_window::do_scroll_vertical): Update.
1119         * tui/tui-data.h (struct tui_data_window)
1120         <first_data_item_displayed>: Declare new method.
1121
1122 2019-06-25  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1125         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1126         contents...
1127         (tui_initialize_static_data): ...here.
1128
1129 2019-06-25  Tom Tromey  <tom@tromey.com>
1130
1131         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1132         (tui_display_registers_from, tui_check_register_values): Update.
1133         (tui_display_register): Remove win_info parameter; update.
1134         (tui_get_register): Change type of parameters.
1135         * tui/tui-data.h (struct tui_data_element): Remove.
1136         (union tui_which_element) <data>: Remove.
1137         <data_window>: Change type.
1138         (struct tui_data_item_window): New.
1139         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1140         case.  Add assert.
1141         (~tui_data_item_window): New destructor.
1142         (free_content_elements): Remove DATA_ITEM_WIN case.
1143
1144 2019-06-25  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1147         Remove.
1148
1149 2019-06-25  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-data.h (struct tui_command_element): Remove.
1152         (union tui_which_element) <command>: Remove.
1153         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1154         assert.
1155         (free_content_elements): Remove CMD_WIN case.
1156
1157 2019-06-25  Tom Tromey  <tom@tromey.com>
1158
1159         * tui/tui-layout.c (tui_set_layout): Update.
1160         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1161         * tui/tui-data.c (layout_def): Update.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1166         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1167         (tui_source_window_base::set_new_height): Update.
1168         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1169         Update.
1170         (tui_set_locator_fullname, tui_set_locator_info)
1171         (tui_show_frame_info): Update.
1172         * tui/tui-source.c (tui_set_source_content)
1173         (tui_source_is_displayed): Update.
1174         * tui/tui-layout.c (show_source_disasm_command, show_data)
1175         (show_source_or_disasm_and_command): Update.
1176         * tui/tui-disasm.c (tui_set_disassem_content)
1177         (tui_get_begin_asm_address): Update.
1178         * tui/tui-data.h (struct tui_locator_element): Remove.
1179         (union tui_which_element) <locator>: Remove.
1180         (struct tui_locator_window): New.
1181         (tui_locator_win_info_ptr): Change return type.
1182         * tui/tui-data.c (_locator): Change type.
1183         (tui_locator_win_info_ptr): Change return type.
1184         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1185         (tui_alloc_content): Add assert.
1186
1187 2019-06-25  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-winsource.c
1190         (tui_exec_info_window::maybe_allocate_content): New method.
1191         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1192         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1193         (make_source_or_disasm_window): Add cast.
1194         * tui/tui-data.h (union tui_which_element) <simple_string>:
1195         Remove.
1196         (struct tui_source_info): New.
1197         (struct tui_source_window_base) <execution_info>: Change type.
1198         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1199         case, and add assert.
1200         (tui_alloc_content): Add assert.
1201
1202 2019-06-25  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1205         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1206         * tui/tui-data.c (tui_alloc_win_info): Remove.
1207
1208 2019-06-25  Tom Tromey  <tom@tromey.com>
1209
1210         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1211         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1212         can_highlight.
1213
1214 2019-06-25  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1217         make_visible_with_new_height method.
1218         (tui_win_info::make_visible_with_new_height): New method.
1219         (tui_source_window_base::do_make_visible_with_new_height)
1220         (tui_data_window::do_make_visible_with_new_height)
1221         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1222         (make_visible_with_new_height): Remove.
1223         (tui_resize_all, tui_adjust_win_heights): Use
1224         make_visible_with_new_height method.
1225         * tui/tui-data.h (struct tui_win_info)
1226         <do_make_visible_with_new_height, make_visible_with_new_height>:
1227         New methods.
1228         (struct tui_source_window_base, struct tui_data_window)
1229         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1230         methods.
1231
1232 2019-06-25  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1235         method.
1236         (update_tab_width): Call update_tab_width method.
1237         * tui/tui-data.h (struct tui_win_info)
1238         (struct tui_source_window_base) <update_tab_width>: New methods.
1239
1240 2019-06-25  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1243         parameter.
1244         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1245         parameter.
1246         (tui_gen_win_info::make_visible): Update.
1247         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1248         parameter.
1249         * tui/tui-data.h (enum tui_box): New enum.
1250         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1251
1252 2019-06-25  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1255         init_and_make_win for EXEC_INFO_WIN.
1256         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1257         longer inline.
1258         (struct tui_win_info) <~tui_win_info>: Inline.
1259         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1260         Don't declare.
1261         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1262         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1263         Remove.
1264         (tui_initialize_static_data): Update.
1265         (~tui_gen_win_info): Handle more cleanup here.
1266         (~tui_source_window_base): Delete "execution_info".
1267         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-layout.c (make_command_window): Don't set
1272         can_highlight.
1273         (show_source_disasm_command): Call the reset method.
1274         (show_data): Don't set can_highlight.  Call the reset method.
1275         (tui_gen_win_info::reset): Rename from init_gen_win_info
1276         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1277         (show_source_or_disasm_and_command): Call the reset method.
1278         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1279         (struct tui_cmd_window): Set can_highlight.
1280
1281 2019-06-25  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1284         from make_visible.
1285         (tui_make_visible, tui_make_invisible): Rewrite.
1286         (tui_win_info::make_visible): Remove.
1287         (tui_source_window_base::make_visible): Update.
1288         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1289         method.  Moved from...
1290         (struct tui_win_info) <make_visible>: ...here.
1291
1292 2019-06-25  Tom Tromey  <tom@tromey.com>
1293
1294         * tui/tui-winsource.c
1295         (tui_source_window_base::do_scroll_horizontal): Remove direction
1296         parameter.
1297         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1298         direction parameter.
1299         * tui/tui-win.c (tui_win_info::forward_scroll)
1300         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1301         (tui_win_info::right_scroll): Update.
1302         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1303         direction parameter.
1304         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1305         direction parameter.
1306         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1307         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1308         Remove direction parameter.
1309         (struct tui_source_window_base, struct tui_source_window)
1310         (struct tui_disasm_window, struct tui_data_window)
1311         (struct tui_cmd_window): Update.
1312
1313 2019-06-25  Tom Tromey  <tom@tromey.com>
1314
1315         * tui/tui-winsource.h (tui_set_exec_info_content)
1316         (tui_show_exec_info_content, tui_erase_exec_info_content)
1317         (tui_clear_exec_info_content, tui_update_exec_info): Change
1318         argument to tui_source_window_base.
1319         * tui/tui-winsource.c (tui_set_exec_info_content)
1320         (tui_show_exec_info_content, tui_erase_exec_info_content)
1321         (tui_clear_exec_info_content, tui_update_exec_info): Change
1322         argument to tui_source_window_base.
1323
1324 2019-06-25  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1327         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1328
1329 2019-06-25  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1332         check.
1333
1334 2019-06-25  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1337         type to void.
1338         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1339         type to void.
1340         * tui/tui-source.c (tui_set_source_content): Update.
1341         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1342
1343 2019-06-25  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-win.c (window_name_completer, tui_set_focus)
1346         (tui_all_windows_info): Use name method.
1347         * tui/tui-data.h (struct tui_gen_win_info)
1348         (struct tui_source_window, struct tui_disasm_window)
1349         (struct tui_data_window, struct tui_cmd_window) <name>: New
1350         method.
1351         (tui_win_name): Don't declare.
1352         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1353         (tui_win_name): Remove.
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-winsource.h (tui_update_source_window)
1358         (tui_update_source_window_as_is): Change parameter type.
1359         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1360         to be a tui_source_window_base.
1361         (tui_update_source_window_as_is): Likewise.
1362         * tui/tui-win.c (make_visible_with_new_height): Update.
1363
1364 2019-06-25  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui-winsource.c (tui_erase_source_content)
1367         (tui_show_source_content, tui_show_exec_info_content)
1368         (tui_erase_exec_info_content): Use refresh_window method.
1369         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1370         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1371         from tui_refresh_win.
1372         (tui_data_window::refresh_window): New method.
1373         (tui_win_info::refresh, tui_source_window_base::refresh)
1374         (tui_refresh_all): Use refresh_window method.
1375         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1376         method.
1377         * tui/tui-regs.c (tui_display_register): Call refresh_window
1378         method.
1379         * tui/tui-layout.c (show_source_disasm_command)
1380         (show_source_or_disasm_and_command): Call refresh_window method.
1381         * tui/tui-data.h (struct tui_gen_win_info)
1382         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1383         New method.
1384
1385 2019-06-25  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui.c (tui_rl_other_window, tui_enable)
1388         (tui_is_window_visible, tui_get_command_dimension): Update.
1389         * tui/tui-winsource.c (tui_update_source_window_as_is)
1390         (tui_clear_source_content, tui_erase_source_content)
1391         (tui_show_source_line, tui_source_window_base::refill)
1392         (tui_source_window_base::do_scroll_horizontal)
1393         (tui_source_window_base::set_is_exec_point_at)
1394         (tui_update_breakpoint_info, tui_set_exec_info_content)
1395         (tui_alloc_source_buffer, tui_line_is_displayed)
1396         (tui_addr_is_displayed): Update.
1397         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1398         (tui_check_and_display_highlight_if_needed)
1399         (tui_win_info::make_visible, tui_win_info::refresh)
1400         (tui_refresh_all): Update.
1401         * tui/tui-windata.c (tui_first_data_item_displayed)
1402         (tui_delete_data_content_windows, tui_erase_data_content)
1403         (tui_display_all_data, tui_data_window::refresh_all)
1404         (tui_check_data_values): Update.
1405         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1406         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1407         (tui_win_info::backward_scroll, tui_refresh_all_win)
1408         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1409         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1410         (tui_source_window_base::set_new_height)
1411         (tui_data_window::set_new_height)
1412         (make_invisible_and_set_new_height)
1413         (make_visible_with_new_height, new_height_ok)
1414         (parse_scrolling_args): Update.
1415         * tui/tui-stack.c (tui_show_frame_info): Update.
1416         * tui/tui-source.c (tui_set_source_content)
1417         (tui_set_source_content_nil, tui_source_is_displayed)
1418         (tui_source_window::do_scroll_vertical): Update.
1419         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1420         (tui_display_registers_from, tui_display_reg_element_at_line)
1421         (tui_check_register_values, tui_reg_command): Update.
1422         * tui/tui-layout.c (tui_default_win_height)
1423         (show_source_disasm_command, show_data, init_and_make_win)
1424         (show_source_or_disasm_and_command): Update.
1425         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1426         (tui_redisplay_readline, tui_mld_flush)
1427         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1428         (tui_getc): Update.
1429         * tui/tui-disasm.c (tui_set_disassem_content)
1430         (tui_disasm_window::do_scroll_vertical): Update.
1431         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1432         Now virtual.
1433         (struct tui_win_info): Derive from tui_gen_win_info.
1434         <~tui_win_info>: Mark as override.
1435         <generic>: Remove member.
1436         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1437         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1438         (~tui_data_window, ~tui_win_info)
1439         (tui_free_all_source_wins_content): Update.
1440         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1441
1442 2019-06-25  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-layout.c (init_and_make_win): Use new.
1445         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1446         destructor, initializers.
1447         (tui_alloc_generic_win_info): Don't declare.
1448         * tui/tui-data.c (_locator): Add argument to constructor.
1449         (source_win, disasm_win): New globals.
1450         (exec_info): Remove.
1451         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1452         Update.
1453         (tui_alloc_generic_win_info): Remove.
1454         (init_content_element): Use new.
1455         (tui_win_info::tui_win_info): Update.
1456         (free_content_elements) <case DATA_WIN>: Use delete.
1457
1458 2019-06-25  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1461         * tui/tui-windata.c (tui_first_data_item_displayed)
1462         (tui_delete_data_content_windows): Update.
1463         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1464         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1465         (tui_display_registers_from, tui_check_register_values): Update.
1466         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1467         pointer.
1468         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1469         window.
1470         (tui_free_data_content): Update.
1471         (free_content_elements) <case DATA_WIN>: Free the window.
1472
1473 2019-06-25  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1476         Update.
1477         * tui/tui-layout.c (make_command_window)
1478         (show_source_disasm_command, show_data, init_and_make_win)
1479         (show_source_or_disasm_and_command): Update.
1480         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1481         method.
1482         <can_highight, is_highlighted>: Now bool.
1483         (tui_set_win_highlight): Don't declare.
1484         * tui/tui-data.c (tui_set_win_highlight): Remove.
1485
1486 2019-06-25  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-wingeneral.c (make_visible): Remove check of window
1489         type.
1490
1491 2019-06-25  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-win.c (tui_win_info::max_height)
1494         (tui_cmd_window::max_height): New methods.
1495         (new_height_ok): Call max_height.
1496         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1497         <max_height>: New method.
1498
1499 2019-06-25  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-win.c (tui_source_window_base::set_new_height)
1502         (tui_data_window::set_new_height): New methods.
1503         (make_invisible_and_set_new_height): Call set_new_height method.
1504         * tui/tui-data.h (struct tui_win_info)
1505         (struct tui_source_window_base, struct tui_data_window)
1506         <set_new_height>: New method.
1507
1508 2019-06-25  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1511         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1512         tui_refresh_data_win.
1513         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1514         method.
1515         (tui_refresh_all_win): Call the refresh_all method.
1516         (tui_set_focus): Likewise.
1517         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1518         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1519         Likewise.
1520
1521 2019-06-25  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-winsource.h (tui_refill_source_window)
1524         (tui_set_is_exec_point_at): Don't declare.
1525         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1526         (tui_source_window_base::refill): Rename from
1527         tui_refill_source_window.
1528         (tui_source_window_base::do_scroll_horizontal): Update.
1529         (tui_source_window_base::set_is_exec_point_at): Rename from
1530         tui_set_is_exec_point_at.
1531         (tui_update_all_breakpoint_info): Update.
1532         * tui/tui-stack.c (tui_show_frame_info): Update.
1533         * tui/tui-layout.c (show_data): Add cast.
1534         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1535         * tui/tui-data.h (struct tui_source_window_base) <refill,
1536         set_is_exec_point_at>: New methods.
1537         (tui_source_windows, tui_add_to_source_windows): Update types.
1538         (tui_add_to_source_windows): Remove redundant declaration.
1539         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1540         (tui_source_windows): Change return type.
1541         (tui_clear_source_windows_detail): Update.
1542         (tui_add_to_source_windows): Change type of parameter.
1543         (tui_free_all_source_wins_content): Update.
1544
1545 2019-06-25  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-wingeneral.c (tui_win_info::refresh)
1548         (tui_source_window_base::refresh): New methods.
1549         (tui_refresh_all): Call the refresh method.
1550         * tui/tui-data.h (struct tui_win_info)
1551         (struct tui_source_window_base) <refresh>: New method.
1552
1553 2019-06-25  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui.h (tui_is_window_visible): Return bool.
1556         * tui/tui.c (tui_is_window_visible): Return bool.
1557         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1558         (tui_make_visible, tui_make_invisible)
1559         (tui_win_info::make_visible)
1560         (tui_source_window_base::make_visible, make_all_visible)
1561         (tui_make_all_visible, tui_make_all_invisible): Update.
1562         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1563         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1564         bool.
1565         (struct tui_win_info, struct tui_source_window_base)
1566         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1567         * tui/tui-data.c (tui_init_generic_part): Update.
1568
1569 2019-06-25  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1572         (tui_source_window_base::make_visible): New methods.
1573         (make_all_visible): Make method call.
1574         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1575         (struct tui_source_window_base, struct tui_cmd_window): Override
1576         make_visible.
1577         (tui_win_is_source_type): Don't declare.
1578         * tui/tui-data.c (tui_win_is_source_type): Remove.
1579
1580 2019-06-25  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1583         NULL check.
1584
1585 2019-06-25  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1588         Inline constructor.  Add initializers for members.
1589         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1590         constructors; now inline in class.
1591
1592 2019-06-25  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-regs.c (tui_show_registers): Update.
1595         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1596         bool.
1597         * tui/tui-data.c (tui_data_window::clear_detail)
1598         (tui_data_window): Update.
1599
1600 2019-06-25  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-windata.c (tui_display_all_data)
1603         (tui_display_data_from_line, tui_display_data_from)
1604         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1605         Update.
1606         * tui/tui-regs.c (tui_last_regs_line_no)
1607         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1608         (tui_show_registers, tui_show_register_group)
1609         (tui_display_registers_from, tui_display_reg_element_at_line)
1610         (tui_display_registers_from_line, tui_check_register_values)
1611         (tui_reg_next, tui_reg_prev): Update.
1612         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1613         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1614         tui_data_window.
1615         (struct tui_win_info) <detail>: Remove.  Add new fields from
1616         tui_data_info.
1617         (TUI_DATA_WIN): Add cast.
1618         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1619         (~tui_data_window): Simplify.
1620
1621 2019-06-25  Tom Tromey  <tom@tromey.com>
1622
1623         * tui/tui-layout.c (show_source_disasm_command)
1624         (show_source_or_disasm_and_command): Update.
1625         * tui/tui-io.c (update_cmdwin_start_line)
1626         (tui_redisplay_readline): Update.
1627         * tui/tui-data.h (struct tui_command_info): Remove.
1628         (struct tui_win_info) <detail>: Remove command_info member.
1629         (struct tui_data_window) <start_line>: New member, from
1630         tui_command_info.
1631         (TUI_CMD_WIN): Add casts.
1632
1633 2019-06-25  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-winsource.c (tui_update_source_window)
1636         (tui_refill_source_window)
1637         (tui_source_window_base::do_scroll_horizontal)
1638         (tui_update_breakpoint_info, tui_set_exec_info_content)
1639         (tui_show_exec_info_content, tui_erase_exec_info_content)
1640         (tui_clear_exec_info_content): Update.
1641         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1642         Update.
1643         * tui/tui-win.c (make_invisible_and_set_new_height)
1644         (make_visible_with_new_height): Update.
1645         * tui/tui-source.c (tui_set_source_content)
1646         (tui_show_symtab_source): Update.
1647         * tui/tui-layout.c (extract_display_start_addr)
1648         (show_source_disasm_command, show_data)
1649         (make_source_or_disasm_window)
1650         (show_source_or_disasm_and_command): Update.
1651         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1652         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1653         "gdbarch".
1654         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1655         to tui_source_window_base.
1656         (struct tui_win_info) <detail>: Remove source_info member.
1657         (struct tui_source_window_base) <has_locator>: Inline.
1658         Move contents from tui_source_info; rename has_locator member to
1659         m_has_locator.
1660         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1661         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1662         header file.
1663         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1664         Simplify.
1665         (tui_free_all_source_wins_content): Cast to
1666         tui_source_window_base.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-win.c (make_invisible_and_set_new_height)
1671         (make_visible_with_new_height): Call has_locator method.
1672         * tui/tui-layout.c (show_source_disasm_command, show_data)
1673         (show_source_or_disasm_and_command): Update for bool change.
1674         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1675         (tui_win_info) <has_locator>: New method.
1676         (struct tui_source_window_base) <has_locator>: New method.
1677         (tui_win_has_locator): Don't declare.
1678         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1679         from tui_win_has_locator.
1680         (tui_source_window_base): Use false, not FALSE.
1681
1682 2019-06-25  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1685         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1686         clear_detail method directly.
1687         (tui_clear_win_detail): Remove.
1688
1689 2019-06-25  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1692         "this", not TUI_DISASM_WIN.
1693
1694 2019-06-25  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1697         declare.
1698         * tui/tui-winsource.c
1699         (tui_source_window_base::do_scroll_horizontal): Rename from
1700         tui_horizontal_source_scroll.
1701         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1702         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1703         from tui_vertical_data_scroll.
1704         * tui/tui-win.h (tui_scroll): Don't declare.
1705         * tui/tui-win.c (tui_win_info::forward_scroll)
1706         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1707         (tui_win_info::right_scroll): Rename and update.
1708         (tui_scroll_forward_command, tui_scroll_backward_command)
1709         (tui_scroll_left_command, tui_scroll_right_command): Update.
1710         (tui_scroll): Remove.
1711         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1712         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1713         from tui_vertical_source_scroll.
1714         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1715         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1716         from tui_vertical_disassem_scroll.
1717         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1718         do_scroll_horizontal>: New methods.
1719         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1720         Likewise.
1721         (struct tui_source_window_base): Add do_scroll_horizontal.
1722         (struct tui_source_window, struct tui_disasm_window): Add
1723         do_scroll_vertical.
1724         (struct tui_data_window, struct tui_cmd_window): Add
1725         do_scroll_horizontal and do_scroll_vertical.
1726         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1727
1728 2019-06-25  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-data.h (struct tui_source_window_base): New struct.
1731         (struct tui_source_window): Derive from tui_source_window_base.
1732         (struct tui_disasm_window): New struct.
1733         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1734         from tui_source_window::clear_detail.
1735         (tui_source_window_base): Rename from tui_source_window.
1736         (~tui_source_window_base): Rename from ~tui_source_window.
1737         (tui_alloc_win_info): Create a tui_disasm_window.
1738
1739 2019-06-25  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-data.h (struct tui_source_window)
1742         (struct tui_data_window): Declare destructors.
1743         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1744         destructors.
1745         (tui_win_info): Simplify.
1746
1747 2019-06-25  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-winsource.c (tui_display_main)
1750         (tui_update_source_windows_with_addr)
1751         (tui_update_all_breakpoint_info): Update.
1752         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1753         (new_height_ok, parse_scrolling_args): Update.
1754         * tui/tui-stack.c (tui_show_frame_info): Update.
1755         * tui/tui-data.h (struct tui_list): Remove.
1756         (tui_source_windows): Return a reference to a std::vector.
1757         * tui/tui-data.c (source_windows): Now a std::vector.
1758         (tui_source_windows): Change return type.
1759         (tui_clear_source_windows): Rewrite.
1760         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1761         (tui_free_all_source_wins_content): Rewrite.
1762
1763 2019-06-25  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1766         (struct tui_data_window, struct tui_cmd_window): Declare
1767         clear_detail method.
1768         * tui/tui-data.c (tui_source_window::clear_detail)
1769         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1770         methods.
1771         (tui_clear_win_detail): Simplify.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-layout.c (make_source_window, make_disasm_window)
1776         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1777         Return the new window.
1778         (show_source_disasm_command, show_data)
1779         (show_source_or_disasm_and_command): Update.
1780
1781 2019-06-25  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1784         parameter.  Return the new window.
1785         (show_source_disasm_command): Update and remove NULL check.
1786         (show_source_or_disasm_and_command): Update.
1787
1788 2019-06-25  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1791
1792 2019-06-25  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-data.h (struct tui_win_info): Make constructor
1795         protected.  Make destructor virtual.  Add initializers.
1796         (tui_source_window, tui_data_window, tui_cmd_window): New
1797         classes.
1798         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1799         constructor.  Add "type" parameter.
1800         (tui_source_window, tui_data_window, tui_cmd_window): New
1801         constructors.
1802         (tui_alloc_win_info): Instantiate the appropriate subclass.
1803
1804 2019-06-25  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-win.c (tui_resize_all): Use delete.
1807         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1808         destructor.
1809         (tui_free_window): Don't declare.
1810         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1811         Update.
1812
1813 2019-06-25  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-data.h (struct tui_win_info): Add constructor.
1816         * tui/tui-data.c (tui_alloc_win_info): Use new.
1817         (tui_free_window): Use delete.
1818
1819 2019-06-22  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1822         declare.
1823         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1824
1825 2019-06-22  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1828         declare.
1829         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1830
1831 2019-06-22  Tom de Vries  <tdevries@suse.de>
1832
1833         * dwarf2read.c (create_addrmap_from_aranges)
1834         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1835         instead of '%zu'.
1836
1837 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1838
1839         * dwarf2read.h (dwarf2_section_info_def): Remove.
1840         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1841         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1842         std::vector<dwarf2_section_info>.
1843         (struct dwo_file) <~dwo_file>: Remove.
1844         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1845         types field.
1846         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1847         (dwarf2_read_debug_names): Likewise.
1848         (create_debug_types_hash_table): Change parameter type to
1849         array_view, adjust code accordingly.
1850         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1851         (partial_die_info::fixup): Likewise.
1852         (determine_prefix): Likewise.
1853         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1854
1855 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1856
1857         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1858         gdb_bfd_ref_ptr.
1859         <~dwo_file>: Remove call to gdb_bfd_unref.
1860         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1861         gdb_bfd_ref_ptr::get.
1862
1863 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1864
1865         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1866         type to htab_up.
1867         * dwarf2read.c (struct dwo_file): Initialize fields.
1868         <~dwo_file>: New.
1869         (free_dwo_file): Remove, move content to ~dwo_file.
1870         (struct dwo_file_deleter): Remove.
1871         (dwo_file_up>: Remove custom deleter.
1872         (free_dwo_files): Remove.
1873         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1874         dwo_files.
1875         (process_skeletonless_type_units): Call unique_ptr::get.
1876         (allocate_dwo_file_hash_table): Add deleter to created hash
1877         table.  Change return type to htab_up.
1878         (lookup_dwo_file_slot): Don't memset dwo_file, call
1879         unique_ptr::get.
1880         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1881         (create_dwo_unit_in_dwp_v2): Likewise.
1882         (open_and_init_dwo_file): Likewise.
1883         (free_dwo_file_from_slot): Remove.
1884
1885 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1886
1887         * dwarf2read.h (struct dwarf2_section_info) <readin,
1888         is_virtual>: Change type to bool.
1889         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1890         true instead of 1.
1891
1892 2019-06-19  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-data.h (tui_init_content_element): Don't declare.
1895
1896 2019-06-19  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-data.h (tui_init_win_info): Don't declare.
1899
1900 2019-06-19  Tom de Vries  <tdevries@suse.de>
1901
1902         * dwarf2read.h (abstract_to_concrete): Change type to
1903         std::unordered_map<sect_offset, std::vector<sect_offset>,
1904         gdb::hash_enum<sect_offset>>.
1905
1906 2019-06-19  Tom Tromey  <tromey@adacore.com>
1907
1908         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1909         EVAL_AVOID_SIDE_EFFECTS specially.
1910
1911 2019-06-19  Tom Tromey  <tromey@adacore.com>
1912
1913         * source-cache.c (highlighter): New global.
1914         (source_cache::get_source_lines): Create a highlighter on demand.
1915
1916 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1917
1918         * defs.h (deprecated_interactive_hook): Delete declaration.
1919         * interps.c (clear_interpreter_hooks): Remove use of
1920         deprecated_interactive_hook.
1921         * top.c (deprecated_interactive_hook): Delete definition.
1922         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1923
1924 2019-06-18  Tom de Vries  <tdevries@suse.de>
1925
1926         PR gdb/24515
1927         * dwarf2read.h (abstract_to_concrete): Change type from
1928         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1929         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1930         * dwarf2read.c (read_variable): Update.
1931         (dwarf2_fetch_die_loc_sect_off): Update.
1932
1933 2019-06-17  Tom de Vries  <tdevries@suse.de>
1934
1935         PR gdb/24617
1936         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1937         accessing parent[parent_len - 1].
1938
1939 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1940
1941         PR gdb/24364
1942         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1943         call dtrace_process_dof with NULL dof.
1944
1945 2019-06-16  Tom de Vries  <tdevries@suse.de>
1946
1947         PR gdb/24445
1948         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1949
1950 2019-06-16  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1953         (make_all_visible): Use address of member.
1954
1955 2019-06-16  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1958         (tui_free_window, free_content, free_content_elements): Remove
1959         unnecessary cast.
1960         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1961         cast.
1962         * tui/tui-regs.c (tui_show_register_group)
1963         (tui_display_registers_from, tui_display_reg_element_at_line):
1964         Remove unnecessary cast.
1965
1966 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1967
1968         * linux-nat.c (normal_mask): Delete.
1969         (_initialize_linux_nat): Don't initialise normal_mask.
1970
1971 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1972
1973         PR gdb/24445
1974         * dwarf-index-write.h (write_psymtabs_to_index): Add
1975         dwz_basename parameter.
1976         * dwarf-index-write.c (write_gdbindex): Move file writing to
1977         write_gdbindex_1.  Change return type void.
1978         (assert_file_size): Move up, remove filename parameter.
1979         (write_gdbindex_1): New function.
1980         (write_debug_names): Change return type to void, call
1981         assert_file_size.
1982         (struct index_wip_file): New struct.
1983         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1984         file logic to index_wip_file.  Write index for dwz file if
1985         needed.
1986         (save_gdb_index_command): Pass basename of dwz file, if present.
1987         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1988         build-id of dwz file, if present.
1989         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1990         (dwarf2_get_dwz_file): Likewise.
1991         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1992         (dwarf2_get_dwz_file): Likewise.
1993
1994 2019-06-16  Tom Tromey  <tom@tromey.com>
1995
1996         * coffread.c (process_coff_symbol): Use xstrdup.
1997         * value.c (create_internalvar): Use xstrdup.
1998
1999 2019-06-16  Tom Tromey  <tom@tromey.com>
2000
2001         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2002         * breakpoint.c (stopin_command, stopat_command)
2003         (until_break_command, decode_location_default): Remove unnecessary
2004         cast.
2005         * utils.c (subset_compare): Remove unnecessary cast.
2006         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2007         cast.
2008         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2009         cast.
2010         * infcmd.c (path_command): Remove unnecessary cast.
2011         * coffread.c (decode_type): Remove unnecessary cast.
2012         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2013         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2014         * tui/tui-stack.c (tui_show_locator_content)
2015         (tui_show_frame_info): Remove unnecessary cast.
2016         * tui/tui-win.c (tui_scroll_forward_command)
2017         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2018         (parse_scrolling_args): Remove unnecessary cast.
2019         * tui/tui-data.c (init_win_info, tui_del_window)
2020         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2021         (free_content_elements): Remove unnecessary cast.
2022         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2023         unnecessary cast.
2024         * tui/tui-source.c (tui_set_source_content)
2025         (tui_vertical_source_scroll): Remove unnecessary cast.
2026         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2027         cast.
2028         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2029         * tui/tui-regs.c (tui_display_registers_from)
2030         (tui_display_register): Remove unnecessary cast.
2031         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2032         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2033         (make_visible): Remove unnecessary cast.
2034         * tui/tui-winsource.c (tui_erase_source_content)
2035         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2036         unnecessary cast.
2037         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2038         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2039         * stabsread.c (read_type, read_array_type, read_range_type):
2040         Remove unnecessary cast.
2041         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2042         (parse_symbol, parse_type, upgrade_type, parse_external)
2043         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2044         unnecessary cast.
2045         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2046
2047 2019-06-16  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-data.c (tui_alloc_generic_win_info)
2050         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2051         checks.
2052
2053 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2054             Andrew Burgess  <andrew.burgess@embecosm.com>
2055
2056         * f-typeprint.c (f_print_type): Don't return early for not
2057         associated or not allocated types.
2058         (f_type_print_varspec_suffix): Add print_rank parameter and print
2059         ranks of array types in case they dangling.
2060         (f_type_print_base): Add print_rank parameter.
2061
2062 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * NEWS: Mention new MI commands.
2065         * break-catch-throw.c (enum exception_event_kind): Move to
2066         breakpoint.h.
2067         (print_mention_exception_catchpoint): Output text as a single
2068         message.
2069         (catch_exception_command_1): Rename to...
2070         (catch_exception_event): ...this, make non-static, update header
2071         command, and change some parameter types.
2072         (catch_catch_command): Update for changes to
2073         catch_exception_command_1.
2074         (catch_throw_command): Likewise.
2075         (catch_rethrow_command): Likewise.
2076         * breakpoint.c (enum exception_event_kind): Delete.
2077         * breakpoint.h (enum exception_event_kind): Moved here from
2078         break-catch-throw.c.
2079         (catch_exception_event): Declare.
2080         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2081         (mi_cmd_catch_throw): New function.
2082         (mi_cmd_catch_rethrow): New function.
2083         (mi_cmd_catch_catch): New function.
2084         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2085         'catch-catch' entries.
2086         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2087         (mi_cmd_catch_rethrow): Declare.
2088         (mi_cmd_catch_catch): Declare.
2089
2090 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2091
2092         * annotate.c (annotate_source_line): Change return type to void,
2093         update implementation to match.
2094         * annotate.h (annotate_source_line): Change return type to void,
2095         update header comment.
2096         * stack.c (print_frame_info): Don't change what frame information
2097         is printed based on whether annotations are on or not.
2098
2099 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2100
2101         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2102         (annotate_source): Make static.
2103         (annotate_source_line): Moved from source.c and renamed from
2104         identify_source_line.  Update the return type.
2105         * annotate.h (annotate_source): Delete declaration.
2106         (annotate_source_line): Declaration moved from source.h, and
2107         renamed from identify_source_line.  Return type updated.
2108         * source.c (identify_source_line): Moved to annotate.c and renamed
2109         to annotate_source_line.
2110         (info_line_command): Remove check of annotation_level.
2111         * source.h (identify_source_line): Move declaration to annotate.h
2112         and rename to annotate_source_line.
2113         * stack.c: Add 'annotate.h' include.
2114         (print_frame_info): Remove check of annotation_level before
2115         calling annotate_source_line.
2116
2117 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2118
2119         * source-cache.c (source_cache::get_plain_source_lines): Use
2120         open_source_file_with_line_charpos instead of just
2121         open_source_file, remove call to find_source_lines.
2122         (source_cache::get_source_lines): Likewise.
2123         * source.c (find_source_lines): Make static.
2124         (get_filename_and_charpos): Renamed into...
2125         (open_source_file_with_line_charpos): ..this along with changes to
2126         return a scoped_fd, and some other minor clean ups.
2127         (identify_source_line): Use open_source_file_with_line_charpos.
2128         (search_command_helper): Use open_source_file_with_line_charpos
2129         instead of just open_source_file, remove call to
2130         find_source_lines.
2131         * source.h (open_source_file_with_line_charpos): Declare new
2132         function.
2133         (find_source_lines): Delete declaration.
2134
2135 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2136
2137         * source.c (get_filename_and_charpos): Remove fullname
2138         parameter.
2139         (identify_source_line): Update call to get_filename_and_charpos.
2140
2141 2019-06-14  Tom Tromey  <tromey@adacore.com>
2142
2143         PR gdb/24502:
2144         * ui-style.h (skip_ansi_escape): Update comment.
2145         * ui-file.h (class no_terminal_escape_file): New class.
2146         * ui-file.c (no_terminal_escape_file::write)
2147         (no_terminal_escape_file::puts): New methods.
2148         * cli/cli-logging.c (handle_redirections): Use
2149         no_terminal_escape_file.
2150
2151 2019-06-14  Tom Tromey  <tromey@adacore.com>
2152
2153         * NEWS: Move convenience variable news above Python news.
2154
2155 2019-06-14  Tom Tromey  <tom@tromey.com>
2156
2157         * gnulib: Move directory to top-level.
2158         * configure.ac: Don't configure gnulib.
2159         * configure: Rebuild.
2160         * common/common-defs.h: Use new path to gnulib.
2161         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2162         (GNULIB_H): Remove.
2163         (INCGNU): Look in new gnulib location.
2164         (HFILES_NO_SRCDIR): Remove gnulib files.
2165         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2166         (generated_files): Remove GNULIB_H.
2167         ($(LIBGNU), all-lib): Remove targets.
2168         (distclean): Don't mention GNULIB_BUILDDIR.
2169         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2170
2171 2019-06-14  Tom Tromey  <tromey@adacore.com>
2172
2173         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2174         Warn if symbol file does not provide any symbols.
2175
2176 2019-06-14  Tom Tromey  <tromey@adacore.com>
2177
2178         * source.c (find_and_open_source): Respect basenames_may_differ.
2179
2180 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2181
2182         * annotate.c (annotate_breakpoints_invalid): Make use of
2183         scoped_restore_terminal_state.
2184         (annotate_frames_invalid): Likewise.
2185
2186 2019-06-14  Tom Tromey  <tromey@adacore.com>
2187
2188         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2189         allow assignment to an internalvar.
2190
2191 2019-06-14  Tom Tromey  <tromey@adacore.com>
2192
2193         * ada-lex.l: Allow "_" in attribute names.
2194
2195 2019-06-14  Tom Tromey  <tromey@adacore.com>
2196
2197         PR gdb/24653:
2198         * regcache.c (registers_changed): Don't call alloca.
2199         * top.c (execute_command): Don't call alloca.
2200
2201 2019-06-13  Pedro Alves  <palves@redhat.com>
2202
2203         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2204         'expression'.  When parsing an expression, error out if there's
2205         junk after "unlimited".
2206         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2207         (do_set_command): Adjust calls to is_unlimited_literal.
2208
2209 2019-06-13  Pedro Alves  <palves@redhat.com>
2210
2211         * compile/compile.c (make_compile_options_def_group): Add braces
2212         around array_view initializer.
2213         * thread.c (make_thread_apply_all_options_def_group)
2214         (make_thread_apply_all_options_def_group): Likewise.
2215
2216 2019-06-13  Pedro Alves  <palves@redhat.com>
2217
2218         * NEWS (New commands): Mention "maint test-options
2219         require-delimiter", "maint test-options unknown-is-error", "maint
2220         test-options unknown-is-operand" and "maint show
2221         test-options-completion-result".
2222         (New command options, command completion): New section.
2223         (Completion improvements): New section.
2224         Mention that you can abbreviate "unlimited".
2225
2226 2019-06-13  Pedro Alves  <palves@redhat.com>
2227
2228         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2229         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2230         * unittests/cli-utils-selftests.c (test_parse_flags)
2231         (test_parse_flags_qcs): Delete.
2232         (test_cli_utils): Don't call deleted functions.
2233
2234 2019-06-13  Pedro Alves  <palves@redhat.com>
2235
2236         * thread.c: Include "cli/cli-option.h".
2237         (tp_array_compar_ascending): Global.
2238         (tp_array_compar): Delete function.
2239         (tp_array_compar_ascending, tp_array_compar_descending): New
2240         functions.
2241         (ascending_option_def, qcs_flag_option_def)
2242         (thr_qcs_flags_option_defs)
2243         (make_thread_apply_all_options_def_group)
2244         (make_thread_apply_options_def_group): New.
2245         (thread_apply_all_command): Use gdb::option::process_options.
2246         (thread_apply_command_completer)
2247         (thread_apply_all_command_completer): New.
2248         (thread_apply_command): Use gdb::option::process_options.
2249         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2250         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2251         to generate help text of "thread apply".  Adjust "taas"'s help.
2252         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2253         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2254
2255 2019-06-13  Pedro Alves  <palves@redhat.com>
2256
2257         * thread.c (thread_apply_command): Check for invalid TID with
2258         isdigit instead of !isalpha.
2259
2260 2019-06-13  Pedro Alves  <palves@redhat.com>
2261
2262         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2263         (validate_flags_qcs): New.
2264         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2265         (validate_flags_qcs): Declare.
2266         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2267         (make_frame_apply_options_def_group): New.
2268         (frame_apply_command_count): Process options with
2269         gdb::option::process_options.
2270         (frame_apply_completer): New.
2271         (frame_apply_level_completer, frame_apply_all_completer)
2272         (frame_apply_completer): New.
2273         (_initialize_stack): Update help of "frame apply", "frame apply
2274         level", "frame apply all" and "faas" to mention supported options
2275         and install command completers.
2276         * stack.h (frame_apply_all_completer): Declare.
2277         * thread.c: Include "stack.h".
2278         (tfaas_command): Add "--".
2279         (_initialize_thread): Update help "tfaas" to mention supported
2280         options and install command completer.
2281
2282 2019-06-13  Pedro Alves  <palves@redhat.com>
2283
2284         * completer.c (complete_nested_command_line): New.
2285         (gdb_completion_word_break_characters_throw): Add assertion.
2286         * completer.h (complete_nested_command_line): Declare.
2287
2288 2019-06-13  Pedro Alves  <palves@redhat.com>
2289
2290         * stack.c (parse_backtrace_qualifiers): New.
2291         (backtrace_command): Use it.
2292         (backtrace_command_completer): Complete on qualifiers.
2293
2294 2019-06-13  Pedro Alves  <palves@redhat.com>
2295
2296         * frame.c: Include "cli/cli-option.h.
2297         (user_set_backtrace_options): New.
2298         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2299         Delete.
2300         (get_prev_frame): Adjust.
2301         (boolean_option_def, uinteger_option_def)
2302         (set_backtrace_option_defs): New.
2303         (_initialize_frame): Adjust and use
2304         gdb::option::add_setshow_cmds_for_options to install "set
2305         backtrace past-main" and "set backtrace past-entry".
2306         * frame.h: Include "cli/cli-option.h".
2307         (struct frame_print_options): Forward declare.
2308         (print_frame_arguments_all, print_frame_arguments_scalars)
2309         (print_frame_arguments_none): Declare.
2310         (print_entry_values): Delete declaration.
2311         (struct frame_print_options, user_frame_print_options): New.
2312         (struct set_backtrace_options): New.
2313         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2314         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2315         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2316         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2317         (list_args_or_locals): Add frame_print_options parameter.
2318         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2319         * python/py-framefilter.c (enumerate_args): Pass down
2320         USER_FRAME_PRINT_OPTIONS.
2321         * stack.c: Include "cli/cli-option.h".
2322         (print_frame_arguments_all, print_frame_arguments_scalars)
2323         (print_frame_arguments_none): Declare.
2324         (print_raw_frame_arguments, print_entry_values): Delete.
2325         (user_frame_print_options): New.
2326         (boolean_option_def, enum_option_def, frame_print_option_defs):
2327         New.
2328         (struct backtrace_cmd_options): New.
2329         (bt_flag_option_def): New.
2330         (backtrace_command_option_defs): New.
2331         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2332         (print_frame_arg, read_frame_arg, print_frame_args)
2333         (print_frame_info, print_frame): Add frame_print_options parameter
2334         and use it.
2335         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2336         (backtrace_command_1): Add frame_print_options and
2337         backtrace_cmd_options parameters and use them.
2338         (make_backtrace_options_def_group): New.
2339         (backtrace_command): Process command options with
2340         gdb::option::process_options.
2341         (backtrace_command_completer): New.
2342         (_initialize_stack): Extend "backtrace"'s help to mention
2343         supported options.  Install completer for "backtrace".
2344         Install some settings commands with add_setshow_cmds_for_options.
2345
2346 2019-06-13  Pedro Alves  <palves@redhat.com>
2347
2348         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2349         and that "set/show print raw frame-arguments" are now deprecated.
2350
2351         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2352         command.
2353         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2354         * stack.c (_initialize_stack): Install "set/show print
2355         raw-frame-arguments", and deprecate "set/show print raw
2356         frame-arguments".
2357         * valprint.c (_initialize_valprint): Deprecate "set/show print
2358         raw".
2359
2360 2019-06-13  Pedro Alves  <palves@redhat.com>
2361
2362         * compile/compile.c (struct compile_options): New.
2363         (compile_flag_option_def, compile_command_option_defs)
2364         (make_compile_options_def_group): New.
2365         (compile_file_command): Handle options with
2366         gdb::option::process_options.
2367         (compile_file_command_completer): New function.
2368         (compile_code_command): Handle options with
2369         gdb::option::process_options.
2370         (compile_code_command_completer): New function.
2371         (_initialize_compiler): Install completers for "compile code" and
2372         "compile file".  Mention available options in "compile code" and
2373         "compile code"'s help.
2374         * completer.c (advance_to_completion_word): New, factored out from
2375         ...
2376         (advance_to_expression_complete_word_point): ... this.
2377         (advance_to_filename_complete_word_point): New.
2378         * completer.h (advance_to_filename_complete_word_point): New
2379         declaration.
2380
2381 2019-06-13  Pedro Alves  <palves@redhat.com>
2382
2383         * compile/compile.c: Include "cli/cli-option.h".
2384         (compile_print_value): Scope data pointer is now a
2385         value_print_options pointer; adjust.
2386         (compile_print_command): Process options.  Scope data pointer is
2387         now a value_print_options pointer; adjust.
2388         (_initialize_compile): Update "compile print"'s help to include
2389         supported options.  Install a completer for "compile print".
2390         * cp-valprint.c (show_vtblprint, show_objectprint)
2391         (show_static_field_print): Delete.
2392         (_initialize_cp_valprint): Don't install "set print
2393         static-members", "set print vtbl", "set print object" here.
2394         * printcmd.c: Include "cli/cli-option.h" and
2395         "common/gdb_optional.h".
2396         (print_command_parse_format): Rework to fill in a
2397         value_print_options instead of a format_data.
2398         (print_value): Change parameter type from format_data pointer to
2399         value_print_options reference.  Adjust.
2400         (print_command_1): Process options.  Adjust to pass down a
2401         value_print_options.
2402         (print_command_completer): New.
2403         (_initialize_printcmd): Install print_command_completer as
2404         handle_brkchars completer for the "print" command.  Update
2405         "print"'s help to include supported options.
2406         * valprint.c: Include "cli/cli-option.h".
2407         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2408         here from cp-valprint.c.
2409         (boolean_option_def, uinteger_option_def)
2410         (value_print_option_defs, make_value_print_options_def_group):
2411         New.  Use gdb::option::add_setshow_cmds_for_options to install
2412         "set print elements", "set print null-stop", "set print repeats",
2413         "set print pretty", "set print union", "set print array", "set
2414         print address", "set print symbol", "set print array-indexes".
2415         * valprint.h: Include <string> and "cli/cli-option.h".
2416         (make_value_print_options_def_group): Declare.
2417         (print_value): Change parameter type from format_data pointer to
2418         value_print_options reference.
2419         (print_command_completer): Declare.
2420
2421 2019-06-13  Pedro Alves  <palves@redhat.com>
2422
2423         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2424         (COMMON_SFILES): Add maint-test-settings.c.
2425         * cli/cli-decode.c (boolean_enums): New global, factored out from
2426         ...
2427         (add_setshow_boolean_cmd): ... here.
2428         * cli/cli-decode.h (boolean_enums): Declare.
2429         * cli/cli-option.c: New file.
2430         * cli/cli-option.h: New file.
2431         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2432         factored out from ...
2433         (parse_cli_boolean_value(const char *)): ... this.
2434         (is_unlimited_literal): Change parameter type to pointer to
2435         pointer.  Adjust and advance ARG pointer.
2436         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2437         (parse_cli_var_enum): New, factored out from ...
2438         (do_set_command): ... this.  Adjust.
2439         * cli/cli-setshow.h (parse_cli_boolean_value)
2440         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2441         (parse_cli_var_enum): Declare.
2442         * cli/cli-utils.c: Include "cli/cli-option.h".
2443         (get_ulongest): New.
2444         * cli/cli-utils.h (get_ulongest): Declare.
2445         (check_for_argument): New overloads.
2446         * maint-test-options.c: New file.
2447
2448 2019-06-13  Pedro Alves  <palves@redhat.com>
2449
2450         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2451         parse a range if "-" is at the end of the string.
2452
2453 2019-06-13  Pedro Alves  <palves@redhat.com>
2454
2455         * cli/cli-setshow.c (parse_auto_binary_operation)
2456         (parse_cli_boolean_value): Don't allow "o".
2457
2458 2019-06-13  Pedro Alves  <palves@redhat.com>
2459
2460         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2461         * NEWS: Mention maint test-settings KIND.
2462         * maint-test-settings.c: New file.
2463
2464 2019-06-13  Pedro Alves  <palves@redhat.com>
2465
2466         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2467         completer.
2468         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2469         "set" completers.
2470
2471 2019-06-13  Pedro Alves  <palves@redhat.com>
2472
2473         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2474         after item.
2475
2476 2019-06-13  Pedro Alves  <palves@redhat.com>
2477
2478         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2479
2480 2019-06-13  Pedro Alves <palves@redhat.com>
2481
2482         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2483         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2484         call.
2485         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2486         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2487         calls.
2488         (check_for_argument): Skip spaces after argument.
2489
2490 2019-06-13  Pedro Alves  <palves@redhat.com>
2491
2492         * thread.c (thread_apply_command): Adjust TID parsing.
2493         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2494         detected before end of string.
2495         (tid_is_in_list): Error out if LIST is invalid.
2496
2497 2019-06-13  Pedro Alves  <palves@redhat.com>
2498
2499         * completer.c (complete_line_internal_1): Rewind completion word
2500         point.
2501         (completion_tracker::advance_custom_word_point_by): Change
2502         parameter type to int.
2503         * completer.h (completion_tracker::advance_custom_word_point_by):
2504         Likewise.
2505
2506 2019-06-13  Pedro Alves  <palves@redhat.com>
2507
2508         * completer.c (advance_to_completion_word): Handle delimiters.
2509
2510 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2511
2512         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2513
2514 2019-06-11  Tom Tromey  <tom@tromey.com>
2515
2516         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2517         (xmalloc_failed): Move to alloc.c.
2518         * alloc.c: New file.
2519         * Makefile.in (COMMON_SFILES): Add alloc.c.
2520
2521 2019-06-11  Tom Tromey  <tom@tromey.com>
2522
2523         * nat/linux-waitpid.c: Don't include server.h.
2524         (linux_debug): Remove.
2525         (my_waitpid): Update.
2526
2527 2019-06-11  Tom Tromey  <tromey@adacore.com>
2528
2529         * infcall.c (_initialize_infcall): Remove trailing newline from
2530         help.
2531         * user-regs.c (_initialize_user_regs): Remove trailing newline
2532         from help.
2533         * typeprint.c (_initialize_typeprint): Remove trailing newline
2534         from help.
2535         * reverse.c (_initialize_reverse): Remove trailing newlines from
2536         help.
2537         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2538         from help.
2539         * language.c (add_set_language_command): Remove trailing newline
2540         from help.
2541         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2542         help.
2543         * disasm.c (_initialize_disasm): Remove trailing newline from
2544         help.
2545         * top.c (init_main): Remove trailing newline from help.
2546         * interps.c (_initialize_interpreter): Remove trailing newline
2547         from help.
2548         * btrace.c (_initialize_btrace): Remove trailing newlines from
2549         help.
2550         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2551         from help.
2552         * python/python.c (_initialize_python): Remove trailing newline
2553         from help.
2554         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2555         help.
2556         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2557         from help.  Reformat some text.
2558         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2559         from help.
2560         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2561         newline from help.
2562
2563 2019-06-11  Tom Tromey  <tromey@adacore.com>
2564
2565         * darwin-nat.c (darwin_decode_exception_message)
2566         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2567
2568 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * valops.c (value_slice): Check for not allocated or not
2571         associated values.
2572
2573 2019-06-10  Tom de Vries  <tdevries@suse.de>
2574
2575         PR gdb/24618
2576         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2577         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2578         invalid.
2579
2580 2019-06-10  Tom de Vries  <tdevries@suse.de>
2581
2582         PR gdb/24611
2583         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2584         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2585
2586 2019-06-10  Tom de Vries  <tdevries@suse.de>
2587
2588         PR symtab/24545
2589         * symtab.c (struct demangled_name_entry): Add language field.
2590         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2591         static minimal symbol".  Set and use language field.
2592
2593 2019-06-10  Tom Tromey  <tromey@adacore.com>
2594
2595         * ada-lang.c (_initialize_ada_language): Update help text.
2596
2597 2019-06-10  Tom Tromey  <tromey@adacore.com>
2598
2599         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2600         with a newline.
2601         * guile/guile.c (handle_boot_error): Don't end warning with a
2602         newline.
2603         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2604         warning with a newline.
2605         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2606         newline.
2607         (s12z_frame_cache): Likewise.
2608         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2609         a newline.
2610         * solib-svr4.c (disable_probes_interface): Don't end warning with
2611         a newline.
2612         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2613         newline.
2614         * python/python.c (do_finish_initialization): Don't end warning
2615         with a newline.
2616
2617 2019-06-10  Tom Tromey  <tom@tromey.com>
2618
2619         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2620         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2621         gdbpy_enter.
2622
2623 2019-06-10  Tom Tromey  <tromey@adacore.com>
2624
2625         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2626         data.
2627         (elf_new_init): Don't call stabsread_new_init.
2628         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2629         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2630         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2631
2632 2019-06-10  Tom de Vries  <tdevries@suse.de>
2633
2634         PR symtab/16264
2635         PR symtab/24517
2636         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2637
2638 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2639
2640         * source.c (find_and_open_source): Also rewrite relative file
2641         names.
2642
2643 2019-04-26  Amos Bird  <amosbird@gmail.com>
2644
2645         * annotate.c (annotate_thread_exited): Add "thread-exited"
2646         annotation.
2647
2648 2019-06-06  Tom Tromey  <tromey@adacore.com>
2649
2650         * maint.h (class scoped_command_stats): Use
2651         DISABLE_COPY_AND_ASSIGN.
2652         <print_time>: New method.
2653         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2654         print_time.
2655         (scoped_command_stats::print_time): New method.
2656
2657 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2658
2659         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2660         instructions of lengths 6 or 8 bytes.
2661
2662 2019-06-04  Pedro Alves  <palves@redhat.com>
2663
2664         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2665
2666         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2667         * breakpoint.c (condition_completer): Likewise.
2668         * cli/cli-dump.c (scan_expression): Likewise.
2669         * common/filestuff.c (mkdir_recursive): Likewise.
2670         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2671         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2672         (gdb_abspath): Likewise.
2673         * compile/compile-cplus-types.c
2674         (compile_cplus_instance::decl_name): Likewise.
2675         * completer.c (complete_explicit_location):
2676         (signal_completer, reg_or_group_completer_1): Likewise.
2677         * cp-support.c (cp_remove_params_if_any): Likewise.
2678         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2679         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2680         * infcmd.c (strip_bg_char): Likewise.
2681         * linespec.c (copy_token_string): Likewise.
2682         * mi/mi-main.c (output_cores): Likewise.
2683         * psymtab.c (psymtab_search_name):
2684         * symfile.c (test_set_ext_lang_command): Likewise.
2685         * target.c (target_fileio_read_stralloc): Likewise.
2686         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2687         * value.c (complete_internalvar): Likewise.
2688
2689 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2690
2691         Add objfile property to gdb.Type.
2692         * NEWS: Mention Python API addition.
2693         * python/py-type.c (typy_get_objfile): New method.
2694
2695 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2696
2697         * NEWS: Mention the new set|show style [title|highlight].
2698         Mention changes to "show style", "help" and "apropos".
2699
2700 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2701
2702         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2703         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2704         instead of print_help_for_command.
2705         (print_doc_of_command): New function.
2706         (help_list): Add 'apropos -v word' suggestion.
2707         (print_help_for_command): Style the command name using title style.
2708         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2709         (_initialize_cli_cmds): Describe -v in apropos_command help.
2710
2711 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2712
2713         * cli/cli-style.h (cli_style_option): Add name in constructor,
2714         add m_name class member, add constructor with intensity,
2715         add name class function.
2716         (cli_style_option::add_setshow_commands): Remove name argument.
2717         (highlight_style, title_style): New styles.
2718         * cli/cli-style.c (do_show): New function that shows a style
2719         characteristic styling the style name with itself.
2720         (set_style_name): New function.
2721         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2722         Update all callers according to the changes in cli/cli-style.h.
2723         * utils.h (fputs_highlighted): New function.
2724         * utils.c (fputs_highlighted): Likewise.
2725
2726 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2727
2728         * NEWS: Mention new pipe command and new convenience variables.
2729
2730 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2731
2732         * cli/cli-cmds.c (pipe_command): New function.
2733         (_initialize_cli_cmds): Call add_com for pipe_command.
2734         Define | as an alias for pipe.
2735         (exit_status_set_internal_vars): New function.
2736         (shell_escape): Call exit_status_set_internal_vars.
2737         cli/cli-decode.c (find_command_name_length): Recognize | as
2738         a single character command.
2739
2740 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2741
2742         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2743         top.c (execute_command_to_ui_file): New function, mostly a copy
2744         of execute_command_to_string.
2745         (execute_command_to_string): Implement by calling
2746         execute_command_to_ui_file.
2747
2748 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2749
2750         * top.h (saved_command_line): Remove declaration.
2751         * top.c (previous_saved_command_line, previous_repeat_arguments):
2752         New variables.
2753         (saved_command_line): Make static, define together with other
2754         'repeat variables'.
2755         (dont_repeat): Clear repeat_arguments.
2756         (repeat_previous, get_saved_command_line, save_command_line):
2757         New functions.
2758         (gdb_init): Initialize saved_command_line
2759         and previous_saved_command_line.
2760         * main.c (captured_main_1): Remove saved_command_line initialization.
2761         * event-top.c (handle_line_of_input): Update to use
2762         the new 'repeat' related functions instead of direct access to
2763         saved_command_line.
2764         * command.h (repeat_previous, get_saved_command_line,
2765         save_command_line): New declarations.
2766         (dont_repeat): Add comment.
2767
2768 2019-05-30  Tom Tromey  <tromey@adacore.com>
2769
2770         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2771         Fix comment.
2772         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2773
2774 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2775
2776         PR cli/24587
2777         * completer.c (complete): Initialize variable word.
2778
2779 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2780
2781         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2782         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2783         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2784         'body' is NULL to the outter 'if', protecting the '!is_define'
2785         situation as well.
2786
2787 2019-05-29  Tom Tromey  <tromey@adacore.com>
2788
2789         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2790         (dwarf_unknown): New function.
2791         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2792         (dwarf_type_encoding_name): Use dwarf_unknown.
2793
2794 2019-05-29  Tom Tromey  <tromey@adacore.com>
2795
2796         PR c++/20020:
2797         * cp-valprint.c (cp_print_value_fields): Call
2798         cp_print_static_field inside "try".
2799
2800 2019-05-29  Tom Tromey  <tromey@adacore.com>
2801
2802         * inflow.c (struct terminal_info): Add default operator=.
2803         * configure: Rebuild.
2804         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2805         -Wdeprecated-copy-dtor, -Wredundant-move.
2806
2807 2019-05-29  Tom Tromey  <tromey@adacore.com>
2808
2809         * NEWS: Add entry.
2810         * infcmd.c (print_return_value_1): Handle finish_print
2811         option.
2812         (show_print_finish): New function.
2813         (_initialize_infcmd): Add "set/show print finish" commands.
2814         * valprint.c (user_print_options): Initialize new member.
2815         * valprint.h (struct value_print_options) <finish_print>: New
2816         member.
2817
2818 2019-05-28  Tom Tromey  <tromey@adacore.com>
2819
2820         * ada-lang.c (ada_remove_Xbn_suffix)
2821         (find_old_style_renaming_symbol)
2822         (parse_old_style_renaming): Remove.
2823         (ada_find_renaming_symbol): Don't call
2824         find_old_style_renaming_symbol.
2825         (ada_is_renaming_symbol): Rename from
2826         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2827         bool.  Now static.
2828         (ada_read_var_value): Update and simplify.
2829         * ada-exp.y (write_var_or_type): Remove old code.
2830
2831 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2832
2833         * event-top.c: Remove include comment.
2834         * inflow.c (class scoped_ignore_sigttou): Move from here...
2835         * inflow.h (class scoped_ignore_sigttou): ...to here.
2836         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2837         * top.c:  Remove include comment.
2838
2839 2019-05-27  Tom Tromey  <tom@tromey.com>
2840
2841         * NEWS: Fix typo.
2842
2843 2019-05-22  Tom Tromey  <tromey@adacore.com>
2844
2845         * target.c (target_follow_exec): Constify parameter.
2846         * target-delegates.c: Rebuild.
2847         * remote.c (remote_target::follow_exec): Constify parameter.
2848         * infrun.c (follow_exec): Constify parameter.
2849         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2850         (target_follow_exec): Likewise.
2851
2852 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2853
2854         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2855         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2856
2857 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2858
2859         * NEWS: Add debugredirect and testsuite sections.
2860
2861 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2862
2863         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2864         target descriptions using exclusively floating point register name
2865         aliases.
2866
2867 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2868
2869         PR gdb/18644:
2870         * f-lang.c (build_fortran_types): Handle the case where
2871         gdbarch_floatformat_for_type returns a nullptr.
2872
2873 2019-05-21  Tom de Vries  <tdevries@suse.de>
2874
2875         PR cli/24587
2876         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2877
2878 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2879
2880         PR gdb/18644:
2881         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2882         16-byte floats.
2883         * i386-tdep.c (i386_floatformat_for_type): Use
2884         floatformats_ia64_quad for the 16-byte floating point component
2885         within a fortran 32-byte complex number.
2886
2887 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2888
2889         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2890         delete default constructor.
2891         (find_partial_die): Update to return const struct.
2892         (partial_die_parent_scope): Move variable declaration into scope
2893         of its use and change its type to auto.
2894         (guess_partial_die_structure_name): Likewise.
2895         (partial_die_info::fixup): Likewise.
2896
2897 2019-05-17  Tom Tromey  <tromey@adacore.com>
2898
2899         * source.c (find_and_open_source): Remove cast.
2900
2901 2019-05-17  Tom Tromey  <tromey@adacore.com>
2902
2903         * annotate.c (annotate_source): Make "filename" const.
2904         * annotate.h (annotate_source): Use const.
2905
2906 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2907
2908         * disasm.c (set_disassembler_options): Send errors to stderr.
2909
2910 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2911
2912         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2913         (cli_interp_base::set_logging): Check debug_redirect.
2914         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2915         * cli/cli-logging.c (debug_redirect): Add static variable.
2916         (pop_output_files): Add default param.
2917         (handle_redirections): Print debug setting.
2918         (show_logging_command): Likewise.
2919         (_initialize_cli_logging): Add debugredirect command.
2920         * interps.c (current_interp_set_logging): Add debug_redirect
2921         parameter.
2922         * interps.h (set_logging): Add debug_redirect parameter.
2923         (current_interp_set_logging): Likewise.
2924         * mi/mi-common.h: Likewise.
2925         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2926
2927 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2928             Tom Tromey  <tromey@adacore.com>
2929
2930         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2931         directly.
2932         * cli/cli-interp.h (make_logging_output): Remove declaration.
2933         * cli/cli-logging.c (make_logging_output): Remove function.
2934         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2935         directly.
2936         * ui-file.c (tee_file::tee_file): Remove bools.
2937         (tee_file::~tee_file): Remove deletes.
2938         * ui-file.h (tee_file): Remove bools.
2939
2940 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2941
2942         * mi/mi-cmds.h (mi_cmd_complete): New function.
2943         * mi/mi-main.c (mi_cmd_complete): Likewise.
2944         * mi/mi-cmds.c: Define new MI command -complete.
2945         * NEWS: Mention new -complete command.
2946
2947 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2948
2949         * completer.h (complete): New function.
2950         * completer.c (complete): Likewise.
2951         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2952         function defined in completer.h.
2953
2954 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2955
2956         * MAINTAINERS (Write After Approval): Add myself.
2957
2958 2019-05-17  Tom de Vries  <tdevries@suse.de>
2959
2960         PR gdb/24094
2961         * dwarf2read.c (struct cu_partial_die_info): New struct.
2962         (find_partial_die): Return cu_partial_die_info.
2963         (partial_die_parent_scope, guess_partial_die_structure_name)
2964         (partial_die_info::fixup): Handle new return type of find_partial_die.
2965
2966 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2967
2968         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2969         "std::string", simplifying the algorithm.
2970
2971 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2972
2973         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2974         (stap_static_probe_ops::get_probes): Likewise.
2975
2976 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2977
2978         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2979         '-')" and "else if".
2980         (stap_parse_single_operand): Join checks for
2981         "gdbarch_stap_parse_special_token_p" and
2982         "gdbarch_stap_parse_special_token" in the same "if" statement.
2983         Invert check when verifying for operation on register
2984         displacement.
2985
2986 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2987
2988         * stap-probe.c (stap_get_opcode): Update comment.
2989         (stap_get_expected_argument_type): Likewise.
2990         (handle_stap_probe): Likewise.
2991
2992 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2993
2994         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2995         return type to 'bool'.  Adjust comment.  Use 'bool' when
2996         appropriate.
2997         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2998         * stap-probe.c (stap_parse_argument_1): Likewise.
2999         (stap_is_operator): Likewise.
3000         (stap_is_generic_prefix): Likewise.
3001         (stap_is_register_prefix): Likewise.
3002         (stap_is_register_indirection_prefix): Likewise.
3003         (stap_is_integer_prefix): Likewise.
3004         (stap_generic_check_suffix): Likewise.
3005         (stap_check_integer_suffix): Likewise.
3006         (stap_check_register_suffix): Likewise.
3007         (stap_check_register_indirection_suffix): Likewise.
3008         (stap_parse_register_operand): Likewise.
3009         (stap_parse_single_operand): Likewise.
3010         (stap_parse_argument_1): Likewise.
3011         (stap_probe::get_argument_count): Likewise.
3012         (stap_is_operator): Likewise.
3013
3014 2019-05-16  Tom Tromey  <tromey@adacore.com>
3015
3016         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3017         keyword to foreach.
3018
3019 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3020
3021         * linux-thread-db.c (try_thread_db_load_1): Change return type
3022         to bool.
3023         (try_thread_db_load): Likewise.
3024         (try_thread_db_load_from_pdir_1): Likewise.
3025         (try_thread_db_load_from_pdir): Likewise.
3026         (try_thread_db_load_from_sdir): Likewise.
3027         (try_thread_db_load_from_dir): Likewise.
3028         (thread_db_load_search): Likewise.
3029         (has_libpthread): Likewise.
3030         (thread_db_load): Likewise.
3031
3032 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3033
3034         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3035         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3036         NULL, and complain/return if that's the case.
3037
3038 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3039
3040         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3041         (advance, posn, abstract_read_memory): New functions.
3042         [struct mem_read_abstraction]: New struct.
3043         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3044
3045 2019-05-14  Tom Tromey  <tromey@adacore.com>
3046
3047         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3048         value is not lval_memory.
3049
3050 2019-05-14  Tom Tromey  <tromey@adacore.com>
3051
3052         * solib.c (info_sharedlibrary_command): Style the file name.
3053
3054 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3055
3056         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3057         (aarch64_vnv_type): Likewise.
3058         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3059         * common/tdesc.c: Likewise.
3060         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3061         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3062         * features/aarch64-fpu.xml: Add ieee half view.
3063         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3064         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3065         * gdbtypes.h (struct builtin_type): Likewise.
3066         (struct objfile_type): Likewise.
3067
3068 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3069
3070         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3071         typo.
3072         * location.h (string_to_event_location): Likewise.
3073
3074 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3075
3076         GDB 8.3 released.
3077
3078 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3079
3080         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3081         New variable declaration.
3082         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3083         New variable.
3084         (print_one_breakpoint): Use ui_out::test_flags and new global
3085         variable to compute use_fixed_output.
3086         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3087         Remove.
3088         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3089         (mi_multi_location_breakpoint_output_fixed): Remove.
3090         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3091         new variable.
3092         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3093         fix_multi_location_breakpoint_output flag if version >= 3.
3094         * ui-out.h (enum ui_out_flag)
3095         <fix_multi_location_breakpoint_output>: New enumerator.
3096
3097 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3098
3099         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3100
3101 2019-05-10  Tom Tromey  <tromey@adacore.com>
3102
3103         * ada-lang.c (catch_ada_completer): New function.
3104         (_initialize_ada_language): Use it.
3105
3106 2019-05-10  Tom Tromey  <tromey@adacore.com>
3107
3108         * thread.c (print_thread_info): Make "requested_threads" const.
3109         * gdbthread.h (print_thread_info): Make "requested_threads"
3110         const.
3111         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3112         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3113
3114 2019-05-08  Tom Tromey  <tom@tromey.com>
3115
3116         * gdbtypes.c (objfile_type_data): Change type.
3117         (objfile_type, _initialize_gdbtypes): Update.
3118
3119 2019-05-08  Tom Tromey  <tom@tromey.com>
3120
3121         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3122         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3123         (_initialize_dwarf2_frame): Update.
3124
3125 2019-05-08  Tom Tromey  <tom@tromey.com>
3126
3127         * objc-lang.c (objc_objfile_data): Change type.
3128         (find_methods): Update.
3129         (_initialize_objc_lang): Remove.
3130
3131 2019-05-08  Tom Tromey  <tom@tromey.com>
3132
3133         * stabsread.c (rs6000_builtin_type_data): Change type.
3134         (rs6000_builtin_type, _initialize_stabsread): Update.
3135
3136 2019-05-08  Tom Tromey  <tom@tromey.com>
3137
3138         * mips-tdep.c (mips_pdr_data): Remove.
3139         (_initialize_mips_tdep): Update.
3140
3141 2019-05-08  Tom Tromey  <tom@tromey.com>
3142
3143         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3144         (hppa_init_objfile_priv_data, read_unwind_info)
3145         (find_unwind_entry, _initialize_hppa_tdep): Update.
3146
3147 2019-05-08  Tom Tromey  <tom@tromey.com>
3148
3149         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3150         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3151         on obstack.
3152         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3153
3154 2019-05-08  Tom Tromey  <tom@tromey.com>
3155
3156         * mdebugread.c (basic_type_data): Change type.
3157         (basic_type, _initialize_mdebugread): Update.
3158
3159 2019-05-08  Tom Tromey  <tom@tromey.com>
3160
3161         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3162
3163 2019-05-08  Tom Tromey  <tom@tromey.com>
3164
3165         * nto-tdep.c (nto_inferior_data_reg): Change type.
3166         (nto_inferior_data): Update.
3167         (nto_inferior_data_cleanup, nto_new_inferior_data)
3168         (_initialize_nto_tdep): Remove.
3169         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3170
3171 2019-05-08  Tom Tromey  <tom@tromey.com>
3172
3173         * ada-lang.c (struct ada_inferior_data): Add initializers.
3174         (ada_inferior_data): Change type.
3175         (ada_inferior_data_cleanup): Remove.
3176         (get_ada_inferior_data, ada_inferior_exit)
3177         (struct ada_pspace_data): Add initializers, destructor.
3178         (ada_pspace_data_handle): Change type.
3179         (get_ada_pspace_data): Update.
3180         (ada_pspace_data_cleanup): Remove.
3181
3182 2019-05-08  Tom Tromey  <tom@tromey.com>
3183
3184         * coffread.c (struct coff_symfile_info): Add initializers.
3185         (coff_objfile_data_key): Move lower.  Change type.
3186         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3187         Update.
3188         (coff_free_info): Remove.
3189
3190 2019-05-08  Tom Tromey  <tom@tromey.com>
3191
3192         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3193         (fbsd_pspace_data_handle): Move lower.  Change type.
3194         (get_fbsd_pspace_data): Update.
3195         (fbsd_pspace_data_cleanup): Remove.
3196         (_initialize_fbsd_tdep): Update.
3197
3198 2019-05-08  Tom Tromey  <tom@tromey.com>
3199
3200         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3201         (get_ada_tasks_pspace_data): Update.
3202         (ada_tasks_pspace_data_cleanup): Remove.
3203         (_initialize_tasks): Update.
3204         (ada_tasks_inferior_data_handle): Change type.
3205         (get_ada_tasks_inferior_data): Update.
3206         (ada_tasks_inferior_data_cleanup): Remove.
3207         (struct ada_tasks_pspace_data): Add initializers.
3208
3209 2019-05-08  Tom Tromey  <tom@tromey.com>
3210
3211         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3212         * symfile-debug.c (debug_sym_get_probes): Change type.
3213         * stap-probe.c (handle_stap_probe):
3214         (stap_static_probe_ops::get_probes): Change type.
3215         * probe.h (class static_probe_ops) <get_probes>: Change type.
3216         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3217         (parse_probes_in_pspace): Update.
3218         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3219         Update.
3220         (any_static_probe_ops::get_probes): Change type.
3221         * elfread.c (elfread_data): New typedef.
3222         (probe_key): Change type.
3223         (elf_get_probes): Likewise.  Update.
3224         (probe_key_free): Remove.
3225         (_initialize_elfread): Update.
3226         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3227         Change type.
3228         (dtrace_process_dof_probe, dtrace_process_dof)
3229         (dtrace_static_probe_ops::get_probe): Change type.
3230
3231 2019-05-08  Tom Tromey  <tom@tromey.com>
3232
3233         * xcoffread.c (struct xcoff_symfile_info): Rename from
3234         coff_symfile_info.  Add initializers.
3235         (xcoff_objfile_data_key): Move lower.  Change type.
3236         (XCOFF_DATA): Rewrite.
3237         (xcoff_free_info): Remove.
3238         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3239         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3240         (xcoff_initial_scan): Update.
3241
3242 2019-05-08  Tom Tromey  <tom@tromey.com>
3243
3244         * solib-svr4.c (struct svr4_info): Add initializers and
3245         destructor.
3246         <probes_table>: Now an htab_up.
3247         (solib_svr4_pspace_data): Change type.
3248         (free_probes_table): Simplify.
3249         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3250         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3251         (probes_table_remove_objfile_probes, register_solib_event_probe)
3252         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3253         (_initialize_svr4_solib): Update.
3254
3255 2019-05-08  Tom Tromey  <tom@tromey.com>
3256
3257         * remote.c (remote_pspace_data): Change type.
3258         (remote_pspace_data_cleanup): Remove.
3259         (get_remote_exec_file, set_pspace_remote_exec_file)
3260         (_initialize_remote): Update.
3261
3262 2019-05-08  Tom Tromey  <tom@tromey.com>
3263
3264         * breakpoint.c (breakpoint_objfile_key): Change type.
3265         (get_breakpoint_objfile_data): Update.
3266         (free_breakpoint_objfile_data): Remove.
3267         (_initialize_breakpoint): Update.
3268
3269 2019-05-08  Tom Tromey  <tom@tromey.com>
3270
3271         * linux-tdep.c (struct linux_info): Add initializers.
3272         (linux_inferior_data): Move.  Change type.
3273         (invalidate_linux_cache_inf): Update.
3274         (linux_inferior_data_cleanup): Remove.
3275         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3276
3277 2019-05-08  Tom Tromey  <tom@tromey.com>
3278
3279         * auxv.c (auxv_inferior_data): Move.  Change type.
3280         (auxv_inferior_data_cleanup): Remove.
3281         (invalidate_auxv_cache_inf): Rewrite.
3282         (get_auxv_inferior_data, _initialize_auxv): Update.
3283
3284 2019-05-08  Tom Tromey  <tom@tromey.com>
3285
3286         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3287         (symfile_debug_objfile_data_key): Change type.
3288         (symfile_debug_installed, debug_qf_has_symbols)
3289         (debug_qf_find_last_source_symtab)
3290         (debug_qf_forget_cached_source_info)
3291         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3292         (debug_qf_print_stats, debug_qf_dump)
3293         (debug_qf_expand_symtabs_for_function)
3294         (debug_qf_expand_all_symtabs)
3295         (debug_qf_expand_symtabs_with_fullname)
3296         (debug_qf_map_matching_symbols)
3297         (debug_qf_expand_symtabs_matching)
3298         (debug_qf_find_pc_sect_compunit_symtab)
3299         (debug_qf_map_symbol_filenames)
3300         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3301         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3302         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3303         (debug_sym_read_linetable, debug_sym_relocate): Update.
3304         (symfile_debug_free_objfile): Remove.
3305         (install_symfile_debug_logging, _initialize_symfile_debug):
3306         Update.
3307
3308 2019-05-08  Tom Tromey  <tom@tromey.com>
3309
3310         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3311         allocate_on_obstack.
3312         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3313         (get_dwarf2_per_objfile): Update.
3314         (set_dwarf2_per_objfile): Remove.
3315         (dwarf2_has_info, dwarf2_get_section_info): Update.
3316         (dwarf2_free_objfile): Remove.
3317         (_initialize_dwarf2_read): Update.
3318
3319 2019-05-08  Tom Tromey  <tom@tromey.com>
3320
3321         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3322         initializers.
3323         <unsupported_script_warning_printed,
3324         script_not_found_warning_printed>: Now bool.
3325         (auto_load_pspace_data): Change type.
3326         (~auto_load_pspace_info): Rename from
3327         auto_load_pspace_data_cleanup.
3328         (get_auto_load_pspace_data, init_loaded_scripts_info)
3329         (clear_section_scripts, maybe_print_unsupported_script_warning)
3330         (maybe_print_script_not_found_warning, _initialize_auto_load):
3331         Update.
3332
3333 2019-05-08  Tom Tromey  <tom@tromey.com>
3334
3335         * objfiles.c (objfile_pspace_info): Add destructor and
3336         initializers.
3337         (objfiles_pspace_data): Change type.
3338         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3339         (get_objfile_pspace_data): Update.
3340         (objfiles_bfd_data): Change type.
3341         (get_objfile_bfd_data): Update.
3342         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3343
3344 2019-05-08  Tom Tromey  <tom@tromey.com>
3345
3346         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3347         Change type.
3348         (get_catch_syscall_inferior_data): Update.
3349         (catch_syscall_inferior_data_cleanup): Remove.
3350         (_initialize_break_catch_syscall): Update.
3351
3352 2019-05-08  Tom Tromey  <tom@tromey.com>
3353
3354         * inflow.c (struct terminal_info): Add destructor and
3355         initializers.
3356         (inflow_inferior_data): Change type.
3357         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3358         (get_inflow_inferior_data, inflow_inferior_exit)
3359         (swap_terminal_info, _initialize_inflow): Update.
3360
3361 2019-05-08  Tom Tromey  <tom@tromey.com>
3362
3363         * target-dcache.c (target_dcache_cleanup): Remove.
3364         (target_dcache_aspace_key): Change type.
3365         (target_dcache_init_p, target_dcache_invalidate)
3366         (target_dcache_get, target_dcache_get_or_init)
3367         (_initialize_target_dcache): Update.
3368         * dcache.h (struct dcache_deleter): New.
3369
3370 2019-05-08  Tom Tromey  <tom@tromey.com>
3371
3372         * symtab.c (struct symbol_cache): Add destructor and
3373         initializers.
3374         (symbol_cache_key): Move.  Change type.
3375         (make_symbol_cache, free_symbol_cache): Remove.
3376         (get_symbol_cache): Update.
3377         (symbol_cache_cleanup): Remove.
3378         (ALL_PSPACES, symbol_cache_flush)
3379         (maintenance_print_symbol_cache)
3380         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3381         Update.
3382
3383 2019-05-08  Tom Tromey  <tom@tromey.com>
3384
3385         * symtab.c (struct main_info): Add destructor and initializers.
3386         (main_progspace_key): Move.  Change type.
3387         (get_main_info): Update.
3388         (main_info_cleanup): Remove.
3389         (_initialize_symtab): Update.
3390
3391 2019-05-08  Tom Tromey  <tom@tromey.com>
3392
3393         * registry.h (DECLARE_REGISTRY): Define the _key class.
3394
3395 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3396
3397         * NEWS: Merge two 'New commands' sections.
3398
3399 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3400
3401         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3402         parameter and use Ada language definition instead.
3403         (ada_val_print_ptr): Remove unused language parameter.
3404         (ada_val_print_num): Remove language parameter and use Ada language
3405         definition instead.
3406         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3407         parameter.
3408         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3409         parameter and use Ada language definition instead.
3410         (ada_val_print_1): Update all ada_val_print_xxx calls.
3411         Remove language parameter.
3412         (ada_val_print): Update ada_val_print_1 call.
3413
3414 2019-05-08  Tom Tromey  <tromey@adacore.com>
3415
3416         * remote.c (remote_hw_watchpoint_limit)
3417         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3418         Now static.
3419
3420 2019-05-08  Tom Tromey  <tromey@adacore.com>
3421
3422         * maint.c (_initialize_maint_cmds): Move initialization code to
3423         remote.c.
3424         (watchdog, show_watchdog): Move to remote.c.
3425         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3426         "watchdog" static.
3427         (_initialize_remote): Move initialization code from maint.c.
3428         * defs.h (watchdog): Don't declare.
3429
3430 2019-05-08  Tom Tromey  <tromey@adacore.com>
3431
3432         * tui/tui-interp.c: Include main.h.
3433         * interps.c: Include main.h.
3434         * main.h (interpreter_p): Declare.
3435         * defs.h (interpreter_p): Don't declare.
3436
3437 2019-05-08  Tom Tromey  <tromey@adacore.com>
3438
3439         * dwarf2loc.c: Include dwarf2read.h.
3440         * defs.h (read_unsigned_leb128): Don't declare.
3441         * dwarf2read.h (read_unsigned_leb128): Declare.
3442
3443 2019-05-08  Tom Tromey  <tromey@adacore.com>
3444
3445         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3446         method.
3447
3448 2019-05-08  Tom Tromey  <tromey@adacore.com>
3449
3450         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3451         when no wrap column is set.
3452
3453 2019-05-08  Tom Tromey  <tromey@adacore.com>
3454
3455         * c-lang.c (c_get_string): Handle non-C-style arrays.
3456
3457 2019-05-08  Tom Tromey  <tromey@adacore.com>
3458
3459         * typeprint.c (print_offset_data::update): Print the bit offset,
3460         not the number of bits remaining.
3461
3462 2019-05-08  Tom Tromey  <tromey@adacore.com>
3463
3464         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3465         padding at end of comment.
3466
3467 2019-05-08  Tom Tromey  <tromey@adacore.com>
3468
3469         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3470         Compare main types.
3471
3472 2019-05-06  Tom Tromey  <tom@tromey.com>
3473
3474         * common/scoped_mmap.c: Include common-defs.h.
3475         * common/scoped_mmap.h: Don't include config.h.
3476
3477 2019-05-04  Tom Tromey  <tom@tromey.com>
3478
3479         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3480         (struct aarch64_call_info): Add initializers.
3481         <si>: Now a std::vector.
3482         (pass_on_stack, aarch64_push_dummy_call): Update.
3483
3484 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3485             Tom Tromey  <tom@tromey.com>
3486
3487         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3488         (ppc_threads): Now a std::vector.  Now static.
3489         (hwdebug_find_thread_points_by_tid)
3490         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3491         Update.
3492
3493 2019-05-04  Tom Tromey  <tom@tromey.com>
3494
3495         * arc-tdep.c (arc_tdesc_init): Return bool.
3496
3497 2019-05-04  Tom Tromey  <tom@tromey.com>
3498
3499         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3500         Use gdb_assert_not_reached.
3501
3502 2019-05-04  Tom Tromey  <tom@tromey.com>
3503
3504         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3505         "false".
3506
3507 2019-05-04  Tom Tromey  <tom@tromey.com>
3508
3509         * arc-tdep.c (arc_tdesc_init): Use bool.
3510
3511 2019-05-04  Tom Tromey  <tom@tromey.com>
3512
3513         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3514
3515 2019-05-04  Tom Tromey  <tom@tromey.com>
3516
3517         * cli/cli-cmds.c (valid_command_p): Return bool.
3518
3519 2019-05-04  Tom Tromey  <tom@tromey.com>
3520
3521         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3522         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3523
3524 2019-05-04  Raul Tambre  <raul@tambre.ee>
3525
3526         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3527         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3528         operator for comparison.
3529
3530 2019-05-04  Tom Tromey  <tom@tromey.com>
3531
3532         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3533         (lookup_partial_symbol, print_partial_symbols)
3534         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3535         (psymbol_compare): Update.
3536         (add_psymbol_to_bcache): Clear the entire psymbol.
3537         (maintenance_check_psymtabs): Update.
3538         * psympriv.h (struct partial_symbol): Don't derive from
3539         general_symbol_info.
3540         <obj_section, unrelocated_address, address,
3541         set_unrelocated_address>: Update.
3542         <ginfo>: New member.
3543         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3544         (debug_names::write_psymbols): Update.
3545
3546 2019-05-04  Tom de Vries  <tdevries@suse.de>
3547
3548         * contrib/cc-with-tweaks.sh: Support -n arg.
3549
3550 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3551
3552         * corelow.c (core_target::detach): Ensure frame cache and
3553         register caches are cleared.
3554         inferior.c (exit_inferior_1): Likewise.
3555
3556 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3557             Tom Tromey  <tom@tromey.com>
3558
3559         * dictionary.c (collate_pending_symbols_by_language): Remove
3560         "struct" from foreach.
3561         * symtab.c (lookup_global_symbol_from_objfile)
3562         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3563         foreach.
3564         * ser-tcp.c (net_open): Remove "struct" from foreach.
3565         * objfiles.c (objfile_relocate, objfile_rebase)
3566         (objfile_has_symbols): Remove "struct" from foreach.
3567         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3568         from foreach.
3569         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3570         foreach.
3571         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3572         "struct" from foreach.
3573         * ada-lang.c (create_excep_cond_exprs)
3574         (ada_exception_catchpoint_cond_string): Remove "struct" from
3575         foreach.
3576
3577 2019-05-03  Tom Tromey  <tromey@adacore.com>
3578
3579         * ada-exp.y (convert_char_literal): Check suffix of each
3580         enumerator.
3581
3582 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3583
3584         PR ada/21406:
3585         * ada-exp.y (yywrap): Don't define.
3586         * ada-lex.l (%option): Add noyywrap
3587         (yywrap): Remove.
3588
3589 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3590
3591         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3592         _WIN32_WINNT to the XP level, unless already defined to a higher
3593         level.
3594
3595         * unittests/parse-connection-spec-selftests.c:
3596         * ser-tcp.c:
3597         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3598         override.
3599
3600         * symfile.c (find_separate_debug_file): Remove colon from the
3601         drive spec of DOS/Windows file names of the target, so that the
3602         file name produced from DEBUGDIR and the target's directory will
3603         be valid on DOS/Windows systems.
3604
3605 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3606
3607         * rust-lang.c (val_print_struct): Handle printing structures
3608         containing strings.
3609
3610 2019-05-02  Tom Tromey  <tromey@adacore.com>
3611
3612         * valarith.c (_initialize_valarith): Remove.
3613
3614 2019-05-01  Tom Tromey  <tromey@adacore.com>
3615
3616         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3617         bitfields.
3618
3619 2019-05-01  Tom Tromey  <tromey@adacore.com>
3620
3621         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3622         for big-endian copies.
3623
3624 2019-04-30  Ali Tamur  <tamur@google.com>
3625         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3626         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3627         (read_3_bytes): New function.
3628
3629 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3630
3631         * windows-nat.c (main_thread_id): Delete.
3632         (handle_output_debug_string): Replace main_thread_id by
3633         current_event.dwThreadId.
3634         (fake_create_process): Likewise.
3635         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3636         Do not set main_thread_id.
3637         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3638         current_event.dwThreadId.
3639         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3640
3641 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3642
3643         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3644         Use current_event.dwThreadId instead of main_thread_id.
3645
3646 2019-04-30  Tom Tromey  <tromey@adacore.com>
3647
3648         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3649         (create_excep_cond_exprs): Iterate over program spaces.
3650         (ada_exception_catchpoint_cond_string): Examine all minimal
3651         symbols for exception types.
3652
3653 2019-04-30  Tom Tromey  <tromey@adacore.com>
3654
3655         PR c++/24470:
3656         * dwarf2read.c (process_structure_scope): Handle case where type
3657         has template parameters but no symbol was created.
3658
3659 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3660             Chris January  <chris.january@arm.com>
3661
3662         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3663         qualifier.
3664         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3665
3666 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * f-typeprint.c (f_print_type): Update rules for printing
3669         whitespace.
3670         (f_type_print_varspec_suffix): Likewise.
3671
3672 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3673             Chris January  <chris.january@arm.com>
3674
3675         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3676         function arguments.
3677
3678 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3679
3680         * f-lang.c (build_fortran_types): Change name of void type to
3681         lower case.
3682         * f-typeprint.c (f_type_print_base): Print the name of the void
3683         type, rather than a fixed string.
3684         * f-valprint.c (f_decorations): Use lower case void string.
3685
3686 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3687             Chris January  <chris.january@arm.com>
3688
3689         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3690         types for Fortran.
3691
3692 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3693             Chris January  <chris.january@arm.com>
3694             David Lecomber  <david.lecomber@arm.com>
3695
3696         * f-exp.y (BINOP_INTRINSIC): New token.
3697         (exp): New parser rule handling BINOP_INTRINSIC.
3698         (f77_keywords): Add new builtin procedures.
3699         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3700         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3701         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3702         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3703         (print_unop_subexp_f): New function.
3704         (print_binop_subexp_f): New function.
3705         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3706         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3707         (dump_subexp_body_f): Likewise.
3708         (operator_check_f): Likewise.
3709         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3710         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3711
3712 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3715         UNOP_KIND.
3716         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3717         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3718         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3719         (operator_length_f): New fuction.
3720         (print_subexp_f): New function.
3721         (op_name_f): New function.
3722         (dump_subexp_body_f): New function.
3723         (operator_check_f): New function.
3724         (exp_descriptor_f): Replace standard expression handling functions
3725         with new functions.
3726         * gdb/fortran-operator.def: New file.
3727         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3728         * gdb/std-operator.def: Remove UNOP_KIND.
3729
3730 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3731
3732         * std-operator.def: Remove unbalanced, stray double quote
3733         character.
3734
3735 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3736             Chris January  <chris.january@arm.com>
3737             Daniel Everett  <daniel.everett@arm.com>
3738             Nick Forrington  <nick.forrington@arm.com>
3739             Richard Bunt  <richard.bunt@arm.com>
3740
3741         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3742         of depth when printing anonymous structs or unions.
3743         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3744         Don't print either the top-level value, or the children if the
3745         max-depth is exceeded.
3746         (ppscm_print_children): When printing the key of a map, allow one
3747         extra level of depth.
3748         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3749         print either the top-level value, or the children if the max-depth
3750         is exceeded.
3751         (print_children): When printing the key of a map, allow one extra
3752         level of depth.
3753         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3754         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3755         (user_print_options): Initialise max_depth field.
3756         (val_print_scalar_or_string_type_p): New function.
3757         (val_print): Check to see if the max depth has been reached.
3758         (val_print_check_max_depth): Define new function.
3759         (show_print_max_depth): New function.
3760         (_initialize_valprint): Add 'print max-depth' option.
3761         * valprint.h (struct value_print_options) <max_depth>: New field.
3762         (val_print_check_max_depth): Declare new function.
3763         * NEWS: Document new feature.
3764
3765 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3766
3767         * ada-lang.c (ada_language_defn): Initialise new field.
3768         * c-lang.c (c_is_string_type_p): New function.
3769         (c_language_defn): Initialise new field.
3770         (cplus_language_defn): Initialise new field.
3771         (asm_language_defn): Initialise new field.
3772         (minimal_language_defn): Initialise new field.
3773         * c-lang.h (c_is_string_type_p): Declare new function.
3774         * d-lang.c (d_language_defn): Initialise new field.
3775         * f-lang.c (f_is_string_type_p): New function.
3776         (f_language_defn): Initialise new field.
3777         * go-lang.c (go_is_string_type_p): New function.
3778         (go_language_defn): Initialise new field.
3779         * language.c (default_is_string_type_p): New function.
3780         (unknown_language_defn): Initialise new field.
3781         (auto_language_defn): Initialise new field.
3782         * language.h (struct language_defn) <la_is_string_type_p>: New
3783         member variable.
3784         (default_is_string_type_p): Declare new function.
3785         * m2-lang.c (m2_language_defn): Initialise new field.
3786         * objc-lang.c (objc_language_defn): Initialise new field.
3787         * opencl-lang.c (opencl_language_defn): Initialise new field.
3788         * p-lang.c (pascal_is_string_type_p): New function.
3789         (pascal_language_defn): Initialise new field.
3790         * rust-lang.c (rust_is_string_type_p): New function.
3791         (rust_language_defn): Initialise new field.
3792
3793 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3794
3795         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3796         New field.
3797         * ada-lang.c (ada_language_defn): Initialise new field.
3798         * c-lang.c (c_language_defn): Likewise.
3799         (cplus_language_defn): Likewise.
3800         (asm_language_defn): Likewise.
3801         (minimal_language_defn): Likewise.
3802         * d-lang.c (d_language_defn): Likewise.
3803         * f-lang.c (f_language_defn): Likewise.
3804         * go-lang.c (go_language_defn): Likewise.
3805         * language.c (unknown_language_defn): Likewise.
3806         (auto_language_defn): Likewise.
3807         * m2-lang.c (m2_language_defn): Likewise.
3808         * objc-lang.c (objc_language_defn): Likewise.
3809         * opencl-lang.c (opencl_language_defn): Likewise.
3810         * p-lang.c (pascal_language_defn): Likewise.
3811         * rust-lang.c (rust_language_defn): Likewise.
3812
3813 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * ada-lang.c (ada_is_character_type): Change return type to bool.
3816         (ada_is_string_type): Likewise.
3817         * ada-lang.h (ada_is_character_type): Update declaration
3818         (ada_is_string_type): Likewise.
3819
3820 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3821
3822         Support style in 'frame|thread apply'
3823
3824         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3825         * record.c (record_start, record_stop): Update callers of
3826         execute_command_to_string with false.
3827         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3828         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3829         methods.
3830         (class string_file): New constructor with term_out parameter.
3831         Override methods term_out and can_emit_style_escape.  New member
3832         term_out.
3833         (class stdio_file): Override can_emit_style_escape.
3834         (class tee_file): Override term_out and can_emit_style_escape.
3835         * utils.h (can_emit_style_escape): Remove.
3836         * utils.c (can_emit_style_escape): Likewise.
3837         Update all callers of can_emit_style_escape (SOMESTREAM) to
3838         SOMESTREAM->can_emit_style_escape.
3839         * source-cache.c (source_cache::get_source_lines): Likewise.
3840         * stack.c (frame_apply_command_count): Call execute_command_to_string
3841         passing the term_out characteristic of the current gdb_stdout.
3842         * thread.c (thr_try_catch_cmd): Likewise.
3843         * top.c (execute_command_to_string): pass term_out parameter
3844         to construct the string_file for the command output.
3845         * ui-file.c (term_cli_styling): New function (most code moved
3846         from utils.c can_emit_style_escape).
3847         (string_file::string_file, string_file::can_emit_style_escape,
3848         stdio_file::can_emit_style_escape, tee_file::term_out,
3849         tee_file::can_emit_style_escape): New functions.
3850
3851 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3852
3853         * NEWS: Mention the new set|show may-call-functions.
3854         * infcall.c (may_call_functions_p): New variable.
3855         (show_may_call_functions_p): New function.
3856         (call_function_by_hand_dummy): Throws an error if not
3857         may-call-functions.
3858         (_initialize_infcall): Call add_setshow_boolean_cmd for
3859         may-call-functions.
3860
3861 2019-04-25  Keith Seitz  <keiths@redhat.com>
3862
3863         PR c++/24367
3864         * cp-support.c (inspect_type): Don't attempt substitutions
3865         of symbol with the same name.
3866
3867 2019-04-25  Tom Tromey  <tromey@adacore.com>
3868
3869         PR gdb/24475:
3870         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3871         static.
3872
3873 2019-04-25  Tom Tromey  <tromey@adacore.com>
3874
3875         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3876         rvalue reference.
3877         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3878         (gdb_xml_parser::parse): Use std::move.
3879         * python/python-internal.h (gdbpy_convert_exception): Take a const
3880         reference.
3881         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3882         std::move.
3883         * python/py-utils.c (gdbpy_convert_exception): Take a const
3884         reference.
3885         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3886         Use std::move.
3887         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3888         Use std::move.
3889         * mi/mi-main.c (mi_print_exception): Take a const reference.
3890         * main.c (handle_command_errors): Take a const reference.
3891         * linespec.c (parse_linespec): Use std::move.
3892         * infcall.c (run_inferior_call): Use std::move.
3893         (call_function_by_hand_dummy): Use std::move.
3894         * exec.c (try_open_exec_file): Use std::move.
3895         * exceptions.h (exception_print, exception_fprintf)
3896         (exception_print_same): Update.
3897         * exceptions.c (print_exception, exception_print)
3898         (exception_fprintf, exception_print_same): Change parameters to
3899         const reference.
3900         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3901         * common/new-op.c: Use std::move.
3902         * common/common-exceptions.h (struct gdb_exception): Add move
3903         constructor.
3904         (struct gdb_exception_error, struct gdb_exception_quit, struct
3905         gdb_quit_bad_alloc): Change constructor to move constructor.
3906         (throw_exception): Change parameter to rvalue reference.
3907         * common/common-exceptions.c (throw_exception): Take rvalue
3908         reference.
3909         * cli/cli-interp.c (safe_execute_command): Use std::move.
3910         * breakpoint.c (insert_bp_location, location_to_sals): Use
3911         std::move.
3912
3913 2019-04-25  Tom Tromey  <tromey@adacore.com>
3914
3915         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3916         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3917         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3918         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3919         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3920         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3921         guile/scm-value.c: Use unpack.
3922         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3923         gdbscm_gdb_exception.
3924         (gdbscm_throw_gdb_exception): Likewise.
3925         (struct gdbscm_gdb_exception): New.
3926         (unpack): New function.
3927         (gdbscm_wrap): Use unpack.
3928
3929 2019-04-25  Tom Tromey  <tromey@adacore.com>
3930
3931         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3932         (gdb_rl_callback_handler): Use std::move.
3933         * common/common-exceptions.h (struct gdb_exception): Add move
3934         assignment operator.
3935         (throw_exception_sjlj): Change "exception" to const reference.
3936         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3937         (throw_exception_sjlj): Change "exception" to const reference.
3938
3939 2019-04-25  Tom Tromey  <tromey@adacore.com>
3940
3941         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3942         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3943         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3944         Update.
3945         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3946         Update.
3947         * mi/mi-interp.c (mi_interp::exec): Update.
3948         * linespec.c (parse_linespec): Update.
3949         * infcall.c (run_inferior_call): Update.
3950         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3951         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3952         (gdbscm_lookup_global_symbol): Update.
3953         * guile/scm-param.c (gdbscm_parameter_value): Update.
3954         * guile/scm-frame.c (gdbscm_frame_read_register)
3955         (gdbscm_frame_read_var): Update.
3956         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3957         * exec.c (try_open_exec_file): Update.
3958         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3959         (gdb_rl_callback_handler): Update.
3960         * common/common-exceptions.h (exception_none): Don't declare.
3961         * common/common-exceptions.c (exception_none): Don't define.
3962         (struct catcher) <exception>: Update.
3963         * cli/cli-interp.c (safe_execute_command): Update.
3964         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3965
3966 2019-04-25  Ali Tamur  <tamur@google.com>
3967
3968         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3969         (read_attribute_value): Likewise.
3970         (dwarf2_read_addr_index): Update comment.
3971         (read_str_index): Add DW_FORM_strx.
3972         (dwarf2_string_attr): Likewise.
3973         (dwarf2_const_value_attr): Likewise.
3974         (dump_die_shallow): Likewise.
3975         (dwarf2_fetch_constant_bytes): Likewise.
3976         (skip_form_bytes): Likewise.
3977         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3978
3979 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3980
3981         PR corefiles/11608
3982         PR corefiles/18187
3983         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3984         OFFSET.  Verify if current mapping contains an ELF header.
3985         (linux_find_memory_regions_full): Adjust call to
3986         dump_mapping_p.
3987
3988 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3989             Kang Li <kanglictf@gmail.com>
3990
3991         PR gdb/21600
3992
3993         * dwarf2-frame.c (read_initial_length): Be consistent about using
3994         unsigned representation of length.
3995         (decode_frame_entry_1): Likewise.  Check for wraparound of
3996         end pointer as well as buffer overflow.
3997
3998 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3999
4000         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4001         "vq".
4002
4003 2019-04-24  Tom Tromey  <tromey@adacore.com>
4004
4005         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4006
4007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4008
4009         * s12z-tdep.c (s12z_unwind_pc): Delete.
4010         (s12z_unwind_sp): Delete.
4011         (s12z_gdbarch_init): Don't register deleted functions with
4012         gdbarch.
4013
4014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4015
4016         * rl78-tdep.c (rl78_unwind_sp): Delete.
4017         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4018
4019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4020
4021         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4022         (xstormy16_unwind_pc): Delete.
4023         (xstormy16_dummy_id): Delete.
4024         (xstormy16_gdbarch_init): Don't register deleted functions with
4025         gdbarch.
4026
4027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4028
4029         * vax-tdep.c (vax_unwind_pc): Delete.
4030         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4031
4032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4033
4034         * v850-tdep.c (v850_unwind_sp): Delete.
4035         (v850_unwind_pc): Delete.
4036         (v850_dummy_id): Delete.
4037         (v850_gdbarch_init): Don't register deleted functions with
4038         gdbarch.
4039
4040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4043         (tilegx_unwind_pc): Delete.
4044         (tilegx_unwind_dummy_id): Delete.
4045         (tilegx_gdbarch_init): Don't register deleted functions with
4046         gdbarch.
4047
4048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4049
4050         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4051         (tic6x_dummy_id): Delete.
4052         (tic6x_gdbarch_init): Don't register deleted functions with
4053         gdbarch.
4054
4055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4056
4057         * sparc-tdep.c (sparc_unwind_pc): Delete.
4058         (sparc32_gdbarch_init): Don't register deleted function with
4059         gdbarch.
4060
4061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4062
4063         * sh-tdep.c (sh_unwind_sp): Delete.
4064         (sh_unwind_pc): Delete.
4065         (sh_dummy_id): Delete.
4066         (sh_gdbarch_init): Don't register deleted functions with
4067         gdbarch.
4068
4069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4070
4071         * score-tdep.c (score_unwind_sp): Delete.
4072         (score_unwind_pc): Delete.
4073         (score_dummy_id): Delete.
4074         (score_gdbarch_init): Don't register deleted functions with
4075         gdbarch.
4076
4077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4078
4079         * rx-tdep.c (rx_unwind_pc): Delete.
4080         (rx_unwind_sp): Delete.
4081         (rx_dummy_id): Delete.
4082         (rx_gdbarch_init): Don't register deleted functions with
4083         gdbarch.  Update comment.
4084
4085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4088         (rs6000_dummy_id): Delete.
4089         (rs6000_gdbarch_init): Don't register deleted functions with
4090         gdbarch.
4091
4092 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4093
4094         * or1k-tdep.c (or1k_dummy_id): Delete.
4095         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4096
4097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * nios2-tdep.c (nios2_dummy_id): Delete.
4100         (nios2_unwind_sp): Delete.
4101         (nios2_gdbarch_init): Don't register deleted functions with
4102         gdbarch.
4103
4104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4105
4106         * nds32-tdep.c (nds32_dummy_id): Delete.
4107         (nds32_unwind_pc): Delete.
4108         (nds32_unwind_sp): Delete.
4109         (nds32_gdbarch_init): Don't register deleted functions with
4110         gdbarch.
4111
4112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4113
4114         * msp430-tdep.c (msp430_unwind_pc): Delete.
4115         (msp430_unwind_sp): Delete.
4116         (msp430_dummy_id): Delete.
4117         (msp430_gdbarch_init): Don't register deleted functions with
4118         gdbarch.
4119
4120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4121
4122         * moxie-tdep.c (moxie_unwind_sp): Delete.
4123         (moxie_unwind_pc): Delete.
4124         (moxie_dummy_id): Delete.
4125         (moxie_gdbarch_init): Don't register deleted functions with
4126         gdbarch.
4127
4128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4129
4130         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4131         (mn10300_unwind_pc): Delete.
4132         (mn10300_unwind_sp): Delete.
4133         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4134         mn10300_unwind_sp.
4135         (mn10300_frame_unwind_init): Don't register deleted functions with
4136         gdbarch.
4137
4138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * mep-tdep.c (mep_unwind_pc): Delete.
4141         (mep_unwind_sp): Delete.
4142         (mep_dummy_id): Delete.
4143         (mep_gdbarch_init): Don't register deleted functions with
4144         gdbarch.
4145
4146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4149         (m68hc11_unwind_sp): Delete.
4150         (m68hc11_gdbarch_init): Don't register deleted functions with
4151         gdbarch.
4152
4153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4154
4155         * m32r-tdep.c (m32r_unwind_sp): Delete.
4156         (m32r_unwind_pc): Delete.
4157         (m32r_dummy_id): Delete.
4158         (m32r_gdbarch_init): Don't register deleted functions with
4159         gdbarch.
4160
4161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4162
4163         * m32c-tdep.c (m32c_unwind_pc): Delete.
4164         (m32c_unwind_sp): Delete.
4165         (m32c_dummy_id): Delete.
4166         (m32c_gdbarch_init): Don't register deleted functions with
4167         gdbarch.
4168
4169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4170
4171         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4172         (lm32_unwind_pc): Delete.
4173         (lm32_dummy_id): Delete.
4174         (lm32_gdbarch_init): Don't register deleted functions with
4175         gdbarch.
4176
4177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4178
4179         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4180         (iq2000_unwind_pc): Delete.
4181         (iq2000_dummy_id): Delete.
4182         (iq2000_gdbarch_init): Don't register deleted functions with
4183         gdbarch.
4184
4185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4186
4187         * nds32-tdep.c (nds32_type_align): Delete.
4188         (nds32_push_dummy_call): Use type_align instead.
4189
4190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4191
4192         * arm-tdep.c (arm_type_align): Only handle vector override case.
4193         (arm_push_dummy_call): Use type_align.
4194         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4195
4196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4197
4198         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4199         case.
4200         (pass_on_stack): Use type_align.
4201         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4202         function.
4203
4204 2019-04-23  Tom Tromey  <tromey@adacore.com>
4205
4206         * dwarf2read.c (line_header::file_name_at): Remove unused
4207         overload.
4208
4209 2019-04-23  Tom de Vries  <tdevries@suse.de>
4210
4211         PR gdb/24438
4212         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4213         invocation.
4214
4215
4216 2019-03-27  Ali Tamur  <tamur@google.com>
4217
4218         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4219         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4220         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4221         (dwarf_expr_context::get_addr_index): Likewise
4222         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4223         (symbol_needs_eval_context::get_addr_index): Likewise
4224         (disassemble_dwarf_expression): Add DW_OP_addrx
4225         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4226         (read_cutu_die_from_dwo): Update comment
4227         (skip_one_die): Add DW_FORM_addrx
4228         (read_attribute_value): Likewise
4229         (var_decode_location): Add DW_OP_addrx
4230         (dwarf2_const_value_attr): Add DW_FORM_addrx
4231         (dump_die_shallow): Likewise
4232         (dwarf2_fetch_constant_bytes): Likewise
4233         (decode_locdesc): Add DW_OP_addrx
4234         (skip_form_bytes): Add DW_FORM_addrx
4235
4236 2019-04-22  Ali Tamur  <tamur@google.com>
4237
4238         * MAINTAINERS (Write After Approval): Add self.
4239
4240 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4241
4242         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4243         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4244         (open_symbol_file_object): Likewise.
4245         (svr4_default_sos): Add info parameter.
4246         (svr4_read_so_list): Likewise.
4247         (svr4_current_sos_direct): Adjust functions calls to pass down
4248         info.
4249         (svr4_current_sos_1): Add info parameter.
4250         (svr4_current_sos): Call get_svr4_info, pass info down to
4251         svr4_current_sos_1.
4252         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4253         get_svr4_info.
4254         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4255         get_svr4_info.
4256         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4257         to get_svr4_info.
4258         (probes_table_remove_objfile_probes): Likewise.
4259         (register_solib_event_probe): Add info parameter.
4260         (solist_update_incremental): Pass info parameter down to
4261         svr4_read_so_list.
4262         (disable_probes_interface): Add info parameter.
4263         (svr4_handle_solib_event): Pass current_program_space to
4264         get_svr4_info.  Adjust disable_probes_interface cleanup.
4265         (svr4_create_probe_breakpoints): Add info parameter, pass it
4266         down to register_solib_event_probe.
4267         (svr4_create_solib_event_breakpoints): Add info parameter,
4268         pass it down to svr4_create_probe_breakpoints.
4269         (enable_break): Pass info down to
4270         svr4_create_solib_event_breakpoints.
4271         (svr4_solib_create_inferior_hook): Pass current_program_space to
4272         get_svr4_info.
4273         (svr4_clear_solib): Likewise.
4274
4275 2019-04-22  Pedro Alves  <palves@redhat.com>
4276
4277         * solib-svr4.c (svr4_free_objfile_observer): New.
4278         (probe_and_action::objfile): New field.
4279         (probes_table_htab_remove_objfile_probes)
4280         (probes_table_remove_objfile_probes): New functions.
4281         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4282         in the new probe_and_action.  Don't store the probe in 'lookup'.
4283         (svr4_create_probe_breakpoints): Pass objfile to
4284         register_solib_event_probe.
4285         (_initialize_svr4_solib): Register a free_objfile observer.
4286
4287 2019-04-19  Tom Tromey  <tom@tromey.com>
4288
4289         * common/queue.h: Remove.
4290
4291 2019-04-19  Tom Tromey  <tom@tromey.com>
4292
4293         * event-loop.c: Don't include "common/queue.h".
4294
4295 2019-04-19  Tom Tromey  <tom@tromey.com>
4296
4297         * remote.c (remote_target): Use delete.
4298         * remote-notif.h: Include <list>, not "common/queue.h".
4299         (notif_client_p): Remove typedef.
4300         (remote_notif_state): Add constructor, destructor, initializer.
4301         <notif_queue>: Now a std::list.
4302         (remote_notif_state_xfree): Don't declare.
4303         * remote-notif.c (remote_notif_process, handle_notification)
4304         (remote_notif_state_allocate): Update.
4305         (~remote_notif_state): Rename from remote_notif_state_xfree.
4306
4307 2019-04-19  Tom Tromey  <tom@tromey.com>
4308
4309         * symfile.c (reread_symbols): Update.
4310         * objfiles.c (objfile_register_static_link)
4311         (objfile_lookup_static_link): Update
4312         (~objfile) Don't delete static_links.
4313         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4314
4315 2019-04-19  Tom Tromey  <tom@tromey.com>
4316
4317         * type-stack.h (struct type_stack) <insert>: Constify string.
4318         * type-stack.c (type_stack::insert): Constify string.
4319         * gdbtypes.h (lookup_template_type): Update.
4320         (address_space_name_to_int): Update.
4321         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4322         const.
4323         (lookup_template_type): Make name const.
4324         * c-exp.y: Update rules.
4325         (lex_one_token, classify_name, classify_inner_name)
4326         (c_print_token): Update.
4327         * p-exp.y: Update rules.
4328         (yylex): Update.
4329         * f-exp.y: Update rules.
4330         (yylex): Update.
4331         * d-exp.y: Update rules.
4332         (lex_one_token, classify_name, classify_inner_name): Update.
4333         * parse.c (write_dollar_variable, copy_name): Return std::string.
4334         * parser-defs.h (copy_name): Change return type.
4335         * m2-exp.y: Update rules.
4336         (yylex): Update.
4337         * go-exp.y (lex_one_token): Update.
4338         Update rules.
4339         (classify_unsafe_function, classify_packaged_name)
4340         (classify_name, yylex): Update.
4341
4342 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4343
4344         * configure.ac: add --enable-source-highlight switch.
4345         * configure: Regenerate.
4346         * top.c (print_gdb_version): plumb --enable-source-highlight
4347         status to "show configuration".
4348
4349 2019-04-19  Tom Tromey  <tromey@adacore.com>
4350
4351         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4352         Check ADA_TYPE_P.
4353         (empty_record, ada_template_to_fixed_record_type_1)
4354         (template_to_static_fixed_type)
4355         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4356         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4357         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4358         macros.
4359
4360 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4361
4362         PR symtab/24423:
4363         * source.c (print_source_lines_base): Advance "iter" when a
4364         control character is seen.
4365
4366 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4367
4368         * inferior.h (struct infcall_suspend_state_deleter):
4369         Catch exception in destructor to avoid crash.
4370
4371 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4372
4373         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4374         close to the add_com "shell".
4375
4376 2019-04-18  Tom Tromey  <tromey@adacore.com>
4377
4378         * process-stratum-target.h (class process_stratum_target)
4379         <stratum>: Add "final".
4380
4381 2019-04-17  Tom Tromey  <tromey@adacore.com>
4382
4383         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4384         against nullptr before use.
4385
4386 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4387
4388         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4389
4390 2019-04-17  Jim Wilson  <jimw@sifive.com>
4391             Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4394         code read might fail, assume 4-byte breakpoint in that case.
4395
4396 2019-04-15  Leszek Swirski  <leszeks@google.com>
4397
4398         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4399         rather than a hand-rolled POD check when checking for forced MEMORY
4400         classification.
4401
4402 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4403
4404         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4405         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4406         function.
4407         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4408         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4409         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4410         declaration.
4411
4412 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4413
4414         * aarch64-linux-nat.c
4415         (aarch64_linux_nat_target::thread_architecture): Add override.
4416         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4417         each VQ.
4418
4419 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4420
4421         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4422
4423 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4424
4425         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4426         target types of size 96-bits, add some additional comments, and
4427         check that the builtin type we found was the correct size.
4428
4429 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4430
4431         * utils.c (prompt_for_continue): Don't restore the styling at the
4432         end, as applied_style has the wrong value.  This fixes styling in
4433         long lists of file names that are interrupted by the "Continue?"
4434         prompt.
4435
4436 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4437
4438         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4439         * c-lang.c (c_language_defn): Likewise.
4440         (cplus_language_defn): Likewise.
4441         (asm_language_defn): Likewise.
4442         (minimal_language_defn): Likewise.
4443         * d-lang.c (d_language_defn): Likewise.
4444         * f-lang.c (f_language_defn): Likewise.
4445         * go-lang.c (go_language_defn): Likewise.
4446         * language.c (unknown_language_defn): Likewise.
4447         (auto_language_defn): Likewise.
4448         * language.h (struct language_defn): Remove la_magic field.
4449         (LANG_MAGIC): Delete.
4450         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4451         * objc-lang.c (objc_language_defn): Likewise.
4452         * opencl-lang.c (opencl_language_defn): Likewise.
4453         * p-lang.c (pascal_language_defn): Likewise.
4454         * rust-lang.c (rust_language_defn): Likewise.
4455
4456 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * riscv-tdep.c (riscv_type_align): New function.
4459         (riscv_type_alignment): Delete.
4460         (riscv_arg_location): Use 'type_align'.
4461         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4462
4463 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * gdbtypes.c (type_align): A struct with no non-static fields also
4466         has alignment of 1.
4467
4468 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4469
4470         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4471         component to 0.
4472         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4473         member.
4474         (riscv_struct_info::analyse): New implementation using new
4475         analyse_inner member function.
4476         (riscv_struct_info::field_offset): New member function.
4477         (riscv_struct_info::m_offsets): New member variable.
4478         (riscv_struct_info::analyse_inner): New private member function,
4479         takes the old implementation of riscv_struct_info::analyse but
4480         extended to track field offsets.
4481         (riscv_call_arg_struct): Update the struct folding special cases
4482         to handle cases where empty C++ structs, which are non-zero
4483         length, are found.
4484         (riscv_arg_location): Initialise the length of each location, a
4485         non-zero length now indicates the location is in use.
4486         (riscv_push_dummy_call): Allow for the first location having a
4487         non-zero offset when setting up arguments.
4488         (riscv_return_value): Likewise, but for return values.
4489
4490 2019-04-11  Tom Tromey  <tromey@adacore.com>
4491
4492         * utils.c (internal_vproblem): Make "msg" const.
4493
4494 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4495
4496         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4497         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4498         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4499         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4500
4501 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4502
4503         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4504         function.
4505         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4506         of amd64_collect_native_gregset.
4507         (amd64_linux_nat_target::store_registers): Likewise.
4508
4509 2019-04-10  Tom Tromey  <tom@tromey.com>
4510
4511         * symtab.c (lookup_global_symbol_from_objfile)
4512         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4513         * objfiles.h (class separate_debug_iterator): New.
4514         (class separate_debug_range): New.
4515         (struct objfile) <separate_debug_objfiles>: New method.
4516         (objfile_separate_debug_iterate): Don't declare.
4517         * objfiles.c (separate_debug_iterator::operator++): Rename from
4518         objfile_separate_debug_iterate.
4519         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4520         iterator.
4521         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4522         iterator.
4523
4524 2019-04-10  Tom Tromey  <tom@tromey.com>
4525
4526         * symfile.c (reread_symbols): Remove old comment.
4527         * objfiles.c (free_all_objfiles): Fix a typo.
4528
4529 2019-04-10  Tom Tromey  <tom@tromey.com>
4530
4531         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4532         * minsyms.c (lookup_minimal_symbol): Use foreach.
4533         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4534         (lookup_minimal_symbol_solib_trampoline): Likewise.
4535         * symfile.c (reread_symbols): Use foreach.
4536
4537 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4538             Tom Tromey  <tromey@adacore.com>
4539
4540         PR rust/24414:
4541         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4542         (rust_lex_int_test): Change "value" to be LONGEST.
4543         (rust_lex_tests): Add test for long integer literal.
4544
4545 2019-04-09  Tom Tromey  <tromey@adacore.com>
4546
4547         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4548         to bool.
4549         (extended_remote_target::attach): Update.
4550         (remote_target::remote_notice_new_inferior): Update.
4551         (remote_target::add_current_inferior_and_thread): Update.
4552         * inferior.c (exit_inferior_1): Use "false".
4553         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4554
4555 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4556
4557         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4558         the "start" command.
4559
4560 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4561
4562         * python/py-inferior.c (infpy_thread_from_thread_handle):
4563         Adjust comments to reflect renaming of thread_from_thread_handle
4564         to thread_from_handle.  Adjust keywords.  Fix type error message.
4565         (inferior_object_methods): Add thread_from_handle.  Retain
4566         thread_from_thread_handle, but mark it as deprecated.
4567
4568 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4569
4570         * gdbthread.h (find_thread_by_handle): Revise declaration.
4571         * thread.c (find_thread_by_handle): Likewise.  Adjust
4572         implementation too.
4573         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4574         support for buffer objects as handles.
4575
4576 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4577
4578         * python/py-infthread.c (thpy_thread_handle): New function.
4579         (thread_object_methods): Register thpy_thread_handle.
4580
4581 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4582
4583         * gdbthread.h (thread_to_thread_handle): Declare.
4584         * thread.c (gdbtypes.h): Include.
4585         (thread_to_thread_handle): New function.
4586
4587         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4588         (target_thread_info_to_thread_handle): Declare.
4589         * target.c (target_thread_info_to_thread_handle): New function.
4590         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4591         * target-delegates.c: Regenerate.
4592
4593         * linux-thread-db.c (class thread_db_target): Add method
4594         thread_info_to_thread_handle.
4595         (thread_db_target::thread_info_to_thread_handle): Define.
4596         * remote.c (class remote_target): Add new method
4597         thread_info_to_thread_handle.
4598         (remote_target::thread_info_to_thread_handle): Define.
4599
4600 2019-04-08  Pedro Alves  <palves@redhat.com>
4601
4602         * common/common-exceptions.c (throw_exception): Don't create
4603         named object to throw; throw directly.
4604         (throw_it): Likewise.  Don't initialize gdb_exception::message
4605         here, with new; pass FMT and AP to the ctor instead.
4606         * common/common-exceptions.h: Include <string>.
4607         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4608         const char *, va_list)): New ctor.  Use std::make_shared.
4609         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4610         errors)): Delete.
4611         (gdb_exception_error::gdb_exception_error(enum errors, const char
4612         *, va_list)): New.
4613         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4614         Add assertion.
4615         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4616         errors)): Delete.
4617         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4618         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4619         Add assertion.
4620
4621 2019-04-08  Tom Tromey  <tom@tromey.com>
4622
4623         * valops.c (value_rtti_indirect_type): Replace throw_exception
4624         with throw.
4625         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4626         with throw.
4627         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4628         throw.
4629         * target.c (target_translate_tls_address): Replace throw_exception
4630         with throw.
4631         * stack.c (frame_apply_command_count): Replace throw_exception
4632         with throw.
4633         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4634         throw.
4635         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4636         with throw.
4637         * rs6000-tdep.c (rs6000_frame_cache)
4638         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4639         * remote.c: Replace throw_exception with throw.
4640         * record-full.c (record_full_message, record_full_wait_1)
4641         (record_full_restore): Replace throw_exception with throw.
4642         * record-btrace.c:
4643         (get_thread_current_frame_id, record_btrace_start_replaying)
4644         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4645         (cmd_record_btrace_start): Replace throw_exception with throw.
4646         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4647         throw.
4648         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4649         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4650         * linespec.c:
4651         (find_linespec_symbols): Replace throw_exception with throw.
4652         * infrun.c (displaced_step_prepare, resume): Replace
4653         throw_exception with throw.
4654         * infcmd.c (post_create_inferior): Replace throw_exception with
4655         throw.
4656         * inf-loop.c (inferior_event_handler): Replace throw_exception
4657         with throw.
4658         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4659         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4660         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4661         (get_prev_frame_always, get_frame_pc_if_available)
4662         (get_frame_address_in_block_if_available, get_frame_language):
4663         Replace throw_exception with throw.
4664         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4665         throw_exception with throw.
4666         * eval.c (fetch_subexp_value, evaluate_var_value)
4667         (evaluate_funcall, evaluate_subexp_standard): Replace
4668         throw_exception with throw.
4669         * dwarf2loc.c (call_site_find_chain)
4670         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4671         Replace throw_exception with throw.
4672         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4673         with throw.
4674         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4675         throw.
4676         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4677         * completer.c (complete_line_internal): Replace throw_exception
4678         with throw.
4679         * compile/compile-object-run.c (compile_object_run): Replace
4680         throw_exception with throw.
4681         * cli/cli-script.c (process_next_line): Replace throw_exception
4682         with throw.
4683         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4684         (btrace_enable, btrace_maint_update_pt_packets): Replace
4685         throw_exception with throw.
4686         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4687         throw_exception with throw.
4688         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4689         throw_exception with throw.
4690         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4691         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4692         * aarch64-tdep.c (aarch64_make_prologue_cache)
4693         (aarch64_make_stub_cache): Replace throw_exception with throw.
4694
4695 2019-04-08  Tom Tromey  <tom@tromey.com>
4696
4697         * common/common-exceptions.c (throw_exception): Rename from
4698         throw_exception_cxx.  Remove old copy.  Make argument const.
4699         (throw_it): Create and throw exception objects directly.
4700         * common/common-exceptions.h (throw_exception): Make argument
4701         const.
4702         (struct gdb_exception_error): Add constructor.
4703         (struct gdb_exception_quit): Add constructor.
4704
4705 2019-04-08  Tom Tromey  <tom@tromey.com>
4706
4707         * common/common-exceptions.h (exception_rethrow): Don't declare.
4708         (TRY_SJLJ): Update comment.
4709         (TRY, CATCH, END_CATCH): Remove.
4710         * common/common-exceptions.c (exception_rethrow): Remove.
4711
4712 2019-04-08  Tom Tromey  <tom@tromey.com>
4713
4714         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4715         Remove.
4716         (gdb_exception_error): Rename from
4717         gdb_exception_RETURN_MASK_ERROR.
4718         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4719         (gdb_quit_bad_alloc): Update.
4720         * aarch64-tdep.c: Update.
4721         * ada-lang.c: Update.
4722         * ada-typeprint.c: Update.
4723         * ada-valprint.c: Update.
4724         * amd64-tdep.c: Update.
4725         * arch-utils.c: Update.
4726         * break-catch-throw.c: Update.
4727         * breakpoint.c: Update.
4728         * btrace.c: Update.
4729         * c-varobj.c: Update.
4730         * cli/cli-cmds.c: Update.
4731         * cli/cli-interp.c: Update.
4732         * cli/cli-script.c: Update.
4733         * common/common-exceptions.c: Update.
4734         * common/new-op.c: Update.
4735         * common/selftest.c: Update.
4736         * compile/compile-c-symbols.c: Update.
4737         * compile/compile-cplus-symbols.c: Update.
4738         * compile/compile-object-load.c: Update.
4739         * compile/compile-object-run.c: Update.
4740         * completer.c: Update.
4741         * corelow.c: Update.
4742         * cp-abi.c: Update.
4743         * cp-support.c: Update.
4744         * cp-valprint.c: Update.
4745         * darwin-nat.c: Update.
4746         * disasm-selftests.c: Update.
4747         * dtrace-probe.c: Update.
4748         * dwarf-index-cache.c: Update.
4749         * dwarf-index-write.c: Update.
4750         * dwarf2-frame-tailcall.c: Update.
4751         * dwarf2-frame.c: Update.
4752         * dwarf2loc.c: Update.
4753         * dwarf2read.c: Update.
4754         * eval.c: Update.
4755         * event-loop.c: Update.
4756         * event-top.c: Update.
4757         * exec.c: Update.
4758         * f-valprint.c: Update.
4759         * fbsd-tdep.c: Update.
4760         * frame-unwind.c: Update.
4761         * frame.c: Update.
4762         * gdbtypes.c: Update.
4763         * gnu-v3-abi.c: Update.
4764         * guile/guile-internal.h: Update.
4765         * guile/scm-block.c: Update.
4766         * guile/scm-breakpoint.c: Update.
4767         * guile/scm-cmd.c: Update.
4768         * guile/scm-disasm.c: Update.
4769         * guile/scm-frame.c: Update.
4770         * guile/scm-lazy-string.c: Update.
4771         * guile/scm-math.c: Update.
4772         * guile/scm-param.c: Update.
4773         * guile/scm-ports.c: Update.
4774         * guile/scm-pretty-print.c: Update.
4775         * guile/scm-symbol.c: Update.
4776         * guile/scm-symtab.c: Update.
4777         * guile/scm-type.c: Update.
4778         * guile/scm-value.c: Update.
4779         * i386-linux-tdep.c: Update.
4780         * i386-tdep.c: Update.
4781         * inf-loop.c: Update.
4782         * infcall.c: Update.
4783         * infcmd.c: Update.
4784         * infrun.c: Update.
4785         * jit.c: Update.
4786         * language.c: Update.
4787         * linespec.c: Update.
4788         * linux-fork.c: Update.
4789         * linux-nat.c: Update.
4790         * linux-tdep.c: Update.
4791         * linux-thread-db.c: Update.
4792         * main.c: Update.
4793         * mi/mi-cmd-break.c: Update.
4794         * mi/mi-cmd-stack.c: Update.
4795         * mi/mi-interp.c: Update.
4796         * mi/mi-main.c: Update.
4797         * objc-lang.c: Update.
4798         * p-valprint.c: Update.
4799         * parse.c: Update.
4800         * ppc-linux-tdep.c: Update.
4801         * printcmd.c: Update.
4802         * python/py-arch.c: Update.
4803         * python/py-breakpoint.c: Update.
4804         * python/py-cmd.c: Update.
4805         * python/py-finishbreakpoint.c: Update.
4806         * python/py-frame.c: Update.
4807         * python/py-framefilter.c: Update.
4808         * python/py-gdb-readline.c: Update.
4809         * python/py-inferior.c: Update.
4810         * python/py-infthread.c: Update.
4811         * python/py-lazy-string.c: Update.
4812         * python/py-linetable.c: Update.
4813         * python/py-objfile.c: Update.
4814         * python/py-param.c: Update.
4815         * python/py-prettyprint.c: Update.
4816         * python/py-progspace.c: Update.
4817         * python/py-record-btrace.c: Update.
4818         * python/py-record.c: Update.
4819         * python/py-symbol.c: Update.
4820         * python/py-type.c: Update.
4821         * python/py-unwind.c: Update.
4822         * python/py-utils.c: Update.
4823         * python/py-value.c: Update.
4824         * python/python.c: Update.
4825         * record-btrace.c: Update.
4826         * record-full.c: Update.
4827         * remote-fileio.c: Update.
4828         * remote.c: Update.
4829         * riscv-tdep.c: Update.
4830         * rs6000-aix-tdep.c: Update.
4831         * rs6000-tdep.c: Update.
4832         * rust-exp.y: Update.
4833         * rust-lang.c: Update.
4834         * s390-tdep.c: Update.
4835         * selftest-arch.c: Update.
4836         * solib-dsbt.c: Update.
4837         * solib-frv.c: Update.
4838         * solib-spu.c: Update.
4839         * solib-svr4.c: Update.
4840         * solib.c: Update.
4841         * sparc64-linux-tdep.c: Update.
4842         * stack.c: Update.
4843         * symfile-mem.c: Update.
4844         * symmisc.c: Update.
4845         * target.c: Update.
4846         * thread.c: Update.
4847         * top.c: Update.
4848         * tracefile-tfile.c: Update.
4849         * tui/tui.c: Update.
4850         * typeprint.c: Update.
4851         * unittests/cli-utils-selftests.c: Update.
4852         * unittests/parse-connection-spec-selftests.c: Update.
4853         * valops.c: Update.
4854         * valprint.c: Update.
4855         * value.c: Update.
4856         * varobj.c: Update.
4857         * windows-nat.c: Update.
4858         * x86-linux-nat.c: Update.
4859         * xml-support.c: Update.
4860
4861 2019-04-08  Tom Tromey  <tom@tromey.com>
4862
4863         * xml-support.c: Use C++ exception handling.
4864         * x86-linux-nat.c: Use C++ exception handling.
4865         * windows-nat.c: Use C++ exception handling.
4866         * varobj.c: Use C++ exception handling.
4867         * value.c: Use C++ exception handling.
4868         * valprint.c: Use C++ exception handling.
4869         * valops.c: Use C++ exception handling.
4870         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4871         handling.
4872         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4873         * typeprint.c: Use C++ exception handling.
4874         * tui/tui.c: Use C++ exception handling.
4875         * tracefile-tfile.c: Use C++ exception handling.
4876         * top.c: Use C++ exception handling.
4877         * thread.c: Use C++ exception handling.
4878         * target.c: Use C++ exception handling.
4879         * symmisc.c: Use C++ exception handling.
4880         * symfile-mem.c: Use C++ exception handling.
4881         * stack.c: Use C++ exception handling.
4882         * sparc64-linux-tdep.c: Use C++ exception handling.
4883         * solib.c: Use C++ exception handling.
4884         * solib-svr4.c: Use C++ exception handling.
4885         * solib-spu.c: Use C++ exception handling.
4886         * solib-frv.c: Use C++ exception handling.
4887         * solib-dsbt.c: Use C++ exception handling.
4888         * selftest-arch.c: Use C++ exception handling.
4889         * s390-tdep.c: Use C++ exception handling.
4890         * rust-lang.c: Use C++ exception handling.
4891         * rust-exp.y: Use C++ exception handling.
4892         * rs6000-tdep.c: Use C++ exception handling.
4893         * rs6000-aix-tdep.c: Use C++ exception handling.
4894         * riscv-tdep.c: Use C++ exception handling.
4895         * remote.c: Use C++ exception handling.
4896         * remote-fileio.c: Use C++ exception handling.
4897         * record-full.c: Use C++ exception handling.
4898         * record-btrace.c: Use C++ exception handling.
4899         * python/python.c: Use C++ exception handling.
4900         * python/py-value.c: Use C++ exception handling.
4901         * python/py-utils.c: Use C++ exception handling.
4902         * python/py-unwind.c: Use C++ exception handling.
4903         * python/py-type.c: Use C++ exception handling.
4904         * python/py-symbol.c: Use C++ exception handling.
4905         * python/py-record.c: Use C++ exception handling.
4906         * python/py-record-btrace.c: Use C++ exception handling.
4907         * python/py-progspace.c: Use C++ exception handling.
4908         * python/py-prettyprint.c: Use C++ exception handling.
4909         * python/py-param.c: Use C++ exception handling.
4910         * python/py-objfile.c: Use C++ exception handling.
4911         * python/py-linetable.c: Use C++ exception handling.
4912         * python/py-lazy-string.c: Use C++ exception handling.
4913         * python/py-infthread.c: Use C++ exception handling.
4914         * python/py-inferior.c: Use C++ exception handling.
4915         * python/py-gdb-readline.c: Use C++ exception handling.
4916         * python/py-framefilter.c: Use C++ exception handling.
4917         * python/py-frame.c: Use C++ exception handling.
4918         * python/py-finishbreakpoint.c: Use C++ exception handling.
4919         * python/py-cmd.c: Use C++ exception handling.
4920         * python/py-breakpoint.c: Use C++ exception handling.
4921         * python/py-arch.c: Use C++ exception handling.
4922         * printcmd.c: Use C++ exception handling.
4923         * ppc-linux-tdep.c: Use C++ exception handling.
4924         * parse.c: Use C++ exception handling.
4925         * p-valprint.c: Use C++ exception handling.
4926         * objc-lang.c: Use C++ exception handling.
4927         * mi/mi-main.c: Use C++ exception handling.
4928         * mi/mi-interp.c: Use C++ exception handling.
4929         * mi/mi-cmd-stack.c: Use C++ exception handling.
4930         * mi/mi-cmd-break.c: Use C++ exception handling.
4931         * main.c: Use C++ exception handling.
4932         * linux-thread-db.c: Use C++ exception handling.
4933         * linux-tdep.c: Use C++ exception handling.
4934         * linux-nat.c: Use C++ exception handling.
4935         * linux-fork.c: Use C++ exception handling.
4936         * linespec.c: Use C++ exception handling.
4937         * language.c: Use C++ exception handling.
4938         * jit.c: Use C++ exception handling.
4939         * infrun.c: Use C++ exception handling.
4940         * infcmd.c: Use C++ exception handling.
4941         * infcall.c: Use C++ exception handling.
4942         * inf-loop.c: Use C++ exception handling.
4943         * i386-tdep.c: Use C++ exception handling.
4944         * i386-linux-tdep.c: Use C++ exception handling.
4945         * guile/scm-value.c: Use C++ exception handling.
4946         * guile/scm-type.c: Use C++ exception handling.
4947         * guile/scm-symtab.c: Use C++ exception handling.
4948         * guile/scm-symbol.c: Use C++ exception handling.
4949         * guile/scm-pretty-print.c: Use C++ exception handling.
4950         * guile/scm-ports.c: Use C++ exception handling.
4951         * guile/scm-param.c: Use C++ exception handling.
4952         * guile/scm-math.c: Use C++ exception handling.
4953         * guile/scm-lazy-string.c: Use C++ exception handling.
4954         * guile/scm-frame.c: Use C++ exception handling.
4955         * guile/scm-disasm.c: Use C++ exception handling.
4956         * guile/scm-cmd.c: Use C++ exception handling.
4957         * guile/scm-breakpoint.c: Use C++ exception handling.
4958         * guile/scm-block.c: Use C++ exception handling.
4959         * guile/guile-internal.h: Use C++ exception handling.
4960         * gnu-v3-abi.c: Use C++ exception handling.
4961         * gdbtypes.c: Use C++ exception handling.
4962         * frame.c: Use C++ exception handling.
4963         * frame-unwind.c: Use C++ exception handling.
4964         * fbsd-tdep.c: Use C++ exception handling.
4965         * f-valprint.c: Use C++ exception handling.
4966         * exec.c: Use C++ exception handling.
4967         * event-top.c: Use C++ exception handling.
4968         * event-loop.c: Use C++ exception handling.
4969         * eval.c: Use C++ exception handling.
4970         * dwarf2read.c: Use C++ exception handling.
4971         * dwarf2loc.c: Use C++ exception handling.
4972         * dwarf2-frame.c: Use C++ exception handling.
4973         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4974         * dwarf-index-write.c: Use C++ exception handling.
4975         * dwarf-index-cache.c: Use C++ exception handling.
4976         * dtrace-probe.c: Use C++ exception handling.
4977         * disasm-selftests.c: Use C++ exception handling.
4978         * darwin-nat.c: Use C++ exception handling.
4979         * cp-valprint.c: Use C++ exception handling.
4980         * cp-support.c: Use C++ exception handling.
4981         * cp-abi.c: Use C++ exception handling.
4982         * corelow.c: Use C++ exception handling.
4983         * completer.c: Use C++ exception handling.
4984         * compile/compile-object-run.c: Use C++ exception handling.
4985         * compile/compile-object-load.c: Use C++ exception handling.
4986         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4987         * compile/compile-c-symbols.c: Use C++ exception handling.
4988         * common/selftest.c: Use C++ exception handling.
4989         * common/new-op.c: Use C++ exception handling.
4990         * cli/cli-script.c: Use C++ exception handling.
4991         * cli/cli-interp.c: Use C++ exception handling.
4992         * cli/cli-cmds.c: Use C++ exception handling.
4993         * c-varobj.c: Use C++ exception handling.
4994         * btrace.c: Use C++ exception handling.
4995         * breakpoint.c: Use C++ exception handling.
4996         * break-catch-throw.c: Use C++ exception handling.
4997         * arch-utils.c: Use C++ exception handling.
4998         * amd64-tdep.c: Use C++ exception handling.
4999         * ada-valprint.c: Use C++ exception handling.
5000         * ada-typeprint.c: Use C++ exception handling.
5001         * ada-lang.c: Use C++ exception handling.
5002         * aarch64-tdep.c: Use C++ exception handling.
5003
5004 2019-04-08  Tom Tromey  <tom@tromey.com>
5005
5006         * xml-support.c (gdb_xml_parser::parse): Update.
5007         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5008         * value.c (show_convenience): Update.
5009         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5010         (test_parse_flags_qcs): Update.
5011         * thread.c (thr_try_catch_cmd): Update.
5012         * target.c (target_translate_tls_address): Update.
5013         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5014         (info_frame_command_core, frame_apply_command_count): Update.
5015         * rust-exp.y (rust_lex_exception_test): Update.
5016         * riscv-tdep.c (riscv_print_one_register_info): Update.
5017         * remote.c (remote_target::enable_btrace): Update.
5018         * record-btrace.c (record_btrace_enable_warn): Update.
5019         * python/py-utils.c (gdbpy_convert_exception): Update.
5020         * printcmd.c (do_one_display, print_variable_and_value): Update.
5021         * mi/mi-main.c (mi_print_exception): Update.
5022         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5023         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5024         * linux-nat.c (linux_nat_target::attach): Update.
5025         * linux-fork.c (class scoped_switch_fork_info): Update.
5026         * infrun.c (displaced_step_prepare): Update.
5027         * infcall.c (call_function_by_hand_dummy): Update.
5028         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5029         * gnu-v3-abi.c (print_one_vtable): Update.
5030         * frame.c (get_prev_frame_always): Update.
5031         * f-valprint.c (info_common_command_for_block): Update.
5032         * exec.c (try_open_exec_file): Update.
5033         * exceptions.c (print_exception, exception_print)
5034         (exception_fprintf, exception_print_same): Update.
5035         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5036         * dwarf-index-cache.c (index_cache::store)
5037         (index_cache::lookup_gdb_index): Update.
5038         * darwin-nat.c (maybe_cache_shell): Update.
5039         * cp-valprint.c (cp_print_value_fields): Update.
5040         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5041         (gcc_cplus_symbol_address): Update.
5042         * compile/compile-c-symbols.c (gcc_convert_symbol)
5043         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5044         * common/selftest.c: Update.
5045         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5046         a std::string.
5047         (exception_try_scope_entry, exception_try_scope_exit): Don't
5048         declare.
5049         (struct exception_try_scope): Remove.
5050         (TRY): Don't use exception_try_scope.
5051         (struct gdb_exception): Add constructor, operator=.
5052         <what>: New method.
5053         (struct gdb_exception_RETURN_MASK_ALL)
5054         (struct gdb_exception_RETURN_MASK_ERROR)
5055         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5056         (struct gdb_quit_bad_alloc): Update.
5057         * common/common-exceptions.c (exception_none): Change
5058         initializer.
5059         (struct catcher) <state, exception>: Initialize inline.
5060         <prev>: Remove member.
5061         (current_catcher): Remove.
5062         (catchers): New global.
5063         (exceptions_state_mc_init): Simplify.
5064         (catcher_pop): Remove.
5065         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5066         (try_scope_depth, exception_try_scope_entry)
5067         (exception_try_scope_exit): Remove.
5068         (throw_exception_sjlj): Update.
5069         (exception_messages, exception_messages_size): Remove.
5070         (throw_it): Simplify.
5071         (gdb_exception_sliced_copy): Remove.
5072         (throw_exception_cxx): Update.
5073         * cli/cli-script.c (script_from_file): Update.
5074         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5075         Update.
5076         * ada-valprint.c (ada_val_print): Update.
5077         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5078         (create_excep_cond_exprs): Update.
5079
5080 2019-04-08  Tom Tromey  <tom@tromey.com>
5081
5082         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5083         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5084         (TRY, CATCH, END_CATCH): Remove some definitions.
5085         * common/common-exceptions.c: Don't use GDB_XCPT.
5086         (catcher_list_size): Remove.
5087         (throw_exception, throw_it): Simplify.
5088
5089 2019-04-05  Tom Tromey  <tom@tromey.com>
5090
5091         Revert the header-sorting patch.
5092         * ft32-tdep.c: Revert.
5093         * frv-tdep.c: Revert.
5094         * frv-linux-tdep.c: Revert.
5095         * frame.c: Revert.
5096         * frame-unwind.c: Revert.
5097         * frame-base.c: Revert.
5098         * fork-child.c: Revert.
5099         * findvar.c: Revert.
5100         * findcmd.c: Revert.
5101         * filesystem.c: Revert.
5102         * filename-seen-cache.h: Revert.
5103         * filename-seen-cache.c: Revert.
5104         * fbsd-tdep.c: Revert.
5105         * fbsd-nat.h: Revert.
5106         * fbsd-nat.c: Revert.
5107         * f-valprint.c: Revert.
5108         * f-typeprint.c: Revert.
5109         * f-lang.c: Revert.
5110         * extension.h: Revert.
5111         * extension.c: Revert.
5112         * extension-priv.h: Revert.
5113         * expprint.c: Revert.
5114         * exec.h: Revert.
5115         * exec.c: Revert.
5116         * exceptions.c: Revert.
5117         * event-top.c: Revert.
5118         * event-loop.c: Revert.
5119         * eval.c: Revert.
5120         * elfread.c: Revert.
5121         * dwarf2read.h: Revert.
5122         * dwarf2read.c: Revert.
5123         * dwarf2loc.c: Revert.
5124         * dwarf2expr.h: Revert.
5125         * dwarf2expr.c: Revert.
5126         * dwarf2-frame.c: Revert.
5127         * dwarf2-frame-tailcall.c: Revert.
5128         * dwarf-index-write.h: Revert.
5129         * dwarf-index-write.c: Revert.
5130         * dwarf-index-common.c: Revert.
5131         * dwarf-index-cache.h: Revert.
5132         * dwarf-index-cache.c: Revert.
5133         * dummy-frame.c: Revert.
5134         * dtrace-probe.c: Revert.
5135         * disasm.h: Revert.
5136         * disasm.c: Revert.
5137         * disasm-selftests.c: Revert.
5138         * dictionary.c: Revert.
5139         * dicos-tdep.c: Revert.
5140         * demangle.c: Revert.
5141         * dcache.h: Revert.
5142         * dcache.c: Revert.
5143         * darwin-nat.h: Revert.
5144         * darwin-nat.c: Revert.
5145         * darwin-nat-info.c: Revert.
5146         * d-valprint.c: Revert.
5147         * d-namespace.c: Revert.
5148         * d-lang.c: Revert.
5149         * ctf.c: Revert.
5150         * csky-tdep.c: Revert.
5151         * csky-linux-tdep.c: Revert.
5152         * cris-tdep.c: Revert.
5153         * cris-linux-tdep.c: Revert.
5154         * cp-valprint.c: Revert.
5155         * cp-support.c: Revert.
5156         * cp-namespace.c: Revert.
5157         * cp-abi.c: Revert.
5158         * corelow.c: Revert.
5159         * corefile.c: Revert.
5160         * continuations.c: Revert.
5161         * completer.h: Revert.
5162         * completer.c: Revert.
5163         * complaints.c: Revert.
5164         * coffread.c: Revert.
5165         * coff-pe-read.c: Revert.
5166         * cli-out.h: Revert.
5167         * cli-out.c: Revert.
5168         * charset.c: Revert.
5169         * c-varobj.c: Revert.
5170         * c-valprint.c: Revert.
5171         * c-typeprint.c: Revert.
5172         * c-lang.c: Revert.
5173         * buildsym.c: Revert.
5174         * buildsym-legacy.c: Revert.
5175         * build-id.h: Revert.
5176         * build-id.c: Revert.
5177         * btrace.c: Revert.
5178         * bsd-uthread.c: Revert.
5179         * breakpoint.h: Revert.
5180         * breakpoint.c: Revert.
5181         * break-catch-throw.c: Revert.
5182         * break-catch-syscall.c: Revert.
5183         * break-catch-sig.c: Revert.
5184         * blockframe.c: Revert.
5185         * block.c: Revert.
5186         * bfin-tdep.c: Revert.
5187         * bfin-linux-tdep.c: Revert.
5188         * bfd-target.c: Revert.
5189         * bcache.c: Revert.
5190         * ax-general.c: Revert.
5191         * ax-gdb.h: Revert.
5192         * ax-gdb.c: Revert.
5193         * avr-tdep.c: Revert.
5194         * auxv.c: Revert.
5195         * auto-load.c: Revert.
5196         * arm-wince-tdep.c: Revert.
5197         * arm-tdep.c: Revert.
5198         * arm-symbian-tdep.c: Revert.
5199         * arm-pikeos-tdep.c: Revert.
5200         * arm-obsd-tdep.c: Revert.
5201         * arm-nbsd-tdep.c: Revert.
5202         * arm-nbsd-nat.c: Revert.
5203         * arm-linux-tdep.c: Revert.
5204         * arm-linux-nat.c: Revert.
5205         * arm-fbsd-tdep.c: Revert.
5206         * arm-fbsd-nat.c: Revert.
5207         * arm-bsd-tdep.c: Revert.
5208         * arch-utils.c: Revert.
5209         * arc-tdep.c: Revert.
5210         * arc-newlib-tdep.c: Revert.
5211         * annotate.h: Revert.
5212         * annotate.c: Revert.
5213         * amd64-windows-tdep.c: Revert.
5214         * amd64-windows-nat.c: Revert.
5215         * amd64-tdep.c: Revert.
5216         * amd64-sol2-tdep.c: Revert.
5217         * amd64-obsd-tdep.c: Revert.
5218         * amd64-obsd-nat.c: Revert.
5219         * amd64-nbsd-tdep.c: Revert.
5220         * amd64-nbsd-nat.c: Revert.
5221         * amd64-nat.c: Revert.
5222         * amd64-linux-tdep.c: Revert.
5223         * amd64-linux-nat.c: Revert.
5224         * amd64-fbsd-tdep.c: Revert.
5225         * amd64-fbsd-nat.c: Revert.
5226         * amd64-dicos-tdep.c: Revert.
5227         * amd64-darwin-tdep.c: Revert.
5228         * amd64-bsd-nat.c: Revert.
5229         * alpha-tdep.c: Revert.
5230         * alpha-obsd-tdep.c: Revert.
5231         * alpha-nbsd-tdep.c: Revert.
5232         * alpha-mdebug-tdep.c: Revert.
5233         * alpha-linux-tdep.c: Revert.
5234         * alpha-linux-nat.c: Revert.
5235         * alpha-bsd-tdep.c: Revert.
5236         * alpha-bsd-nat.c: Revert.
5237         * aix-thread.c: Revert.
5238         * agent.c: Revert.
5239         * addrmap.c: Revert.
5240         * ada-varobj.c: Revert.
5241         * ada-valprint.c: Revert.
5242         * ada-typeprint.c: Revert.
5243         * ada-tasks.c: Revert.
5244         * ada-lang.c: Revert.
5245         * aarch64-tdep.c: Revert.
5246         * aarch64-ravenscar-thread.c: Revert.
5247         * aarch64-newlib-tdep.c: Revert.
5248         * aarch64-linux-tdep.c: Revert.
5249         * aarch64-linux-nat.c: Revert.
5250         * aarch64-fbsd-tdep.c: Revert.
5251         * aarch64-fbsd-nat.c: Revert.
5252         * aarch32-linux-nat.c: Revert.
5253
5254 2019-04-05  Tom Tromey  <tom@tromey.com>
5255
5256         * ft32-tdep.c: Sort headers.
5257         * frv-tdep.c: Sort headers.
5258         * frv-linux-tdep.c: Sort headers.
5259         * frame.c: Sort headers.
5260         * frame-unwind.c: Sort headers.
5261         * frame-base.c: Sort headers.
5262         * fork-child.c: Sort headers.
5263         * findvar.c: Sort headers.
5264         * findcmd.c: Sort headers.
5265         * filesystem.c: Sort headers.
5266         * filename-seen-cache.h: Sort headers.
5267         * filename-seen-cache.c: Sort headers.
5268         * fbsd-tdep.c: Sort headers.
5269         * fbsd-nat.h: Sort headers.
5270         * fbsd-nat.c: Sort headers.
5271         * f-valprint.c: Sort headers.
5272         * f-typeprint.c: Sort headers.
5273         * f-lang.c: Sort headers.
5274         * extension.h: Sort headers.
5275         * extension.c: Sort headers.
5276         * extension-priv.h: Sort headers.
5277         * expprint.c: Sort headers.
5278         * exec.h: Sort headers.
5279         * exec.c: Sort headers.
5280         * exceptions.c: Sort headers.
5281         * event-top.c: Sort headers.
5282         * event-loop.c: Sort headers.
5283         * eval.c: Sort headers.
5284         * elfread.c: Sort headers.
5285         * dwarf2read.h: Sort headers.
5286         * dwarf2read.c: Sort headers.
5287         * dwarf2loc.c: Sort headers.
5288         * dwarf2expr.h: Sort headers.
5289         * dwarf2expr.c: Sort headers.
5290         * dwarf2-frame.c: Sort headers.
5291         * dwarf2-frame-tailcall.c: Sort headers.
5292         * dwarf-index-write.h: Sort headers.
5293         * dwarf-index-write.c: Sort headers.
5294         * dwarf-index-common.c: Sort headers.
5295         * dwarf-index-cache.h: Sort headers.
5296         * dwarf-index-cache.c: Sort headers.
5297         * dummy-frame.c: Sort headers.
5298         * dtrace-probe.c: Sort headers.
5299         * disasm.h: Sort headers.
5300         * disasm.c: Sort headers.
5301         * disasm-selftests.c: Sort headers.
5302         * dictionary.c: Sort headers.
5303         * dicos-tdep.c: Sort headers.
5304         * demangle.c: Sort headers.
5305         * dcache.h: Sort headers.
5306         * dcache.c: Sort headers.
5307         * darwin-nat.h: Sort headers.
5308         * darwin-nat.c: Sort headers.
5309         * darwin-nat-info.c: Sort headers.
5310         * d-valprint.c: Sort headers.
5311         * d-namespace.c: Sort headers.
5312         * d-lang.c: Sort headers.
5313         * ctf.c: Sort headers.
5314         * csky-tdep.c: Sort headers.
5315         * csky-linux-tdep.c: Sort headers.
5316         * cris-tdep.c: Sort headers.
5317         * cris-linux-tdep.c: Sort headers.
5318         * cp-valprint.c: Sort headers.
5319         * cp-support.c: Sort headers.
5320         * cp-namespace.c: Sort headers.
5321         * cp-abi.c: Sort headers.
5322         * corelow.c: Sort headers.
5323         * corefile.c: Sort headers.
5324         * continuations.c: Sort headers.
5325         * completer.h: Sort headers.
5326         * completer.c: Sort headers.
5327         * complaints.c: Sort headers.
5328         * coffread.c: Sort headers.
5329         * coff-pe-read.c: Sort headers.
5330         * cli-out.h: Sort headers.
5331         * cli-out.c: Sort headers.
5332         * charset.c: Sort headers.
5333         * c-varobj.c: Sort headers.
5334         * c-valprint.c: Sort headers.
5335         * c-typeprint.c: Sort headers.
5336         * c-lang.c: Sort headers.
5337         * buildsym.c: Sort headers.
5338         * buildsym-legacy.c: Sort headers.
5339         * build-id.h: Sort headers.
5340         * build-id.c: Sort headers.
5341         * btrace.c: Sort headers.
5342         * bsd-uthread.c: Sort headers.
5343         * breakpoint.h: Sort headers.
5344         * breakpoint.c: Sort headers.
5345         * break-catch-throw.c: Sort headers.
5346         * break-catch-syscall.c: Sort headers.
5347         * break-catch-sig.c: Sort headers.
5348         * blockframe.c: Sort headers.
5349         * block.c: Sort headers.
5350         * bfin-tdep.c: Sort headers.
5351         * bfin-linux-tdep.c: Sort headers.
5352         * bfd-target.c: Sort headers.
5353         * bcache.c: Sort headers.
5354         * ax-general.c: Sort headers.
5355         * ax-gdb.h: Sort headers.
5356         * ax-gdb.c: Sort headers.
5357         * avr-tdep.c: Sort headers.
5358         * auxv.c: Sort headers.
5359         * auto-load.c: Sort headers.
5360         * arm-wince-tdep.c: Sort headers.
5361         * arm-tdep.c: Sort headers.
5362         * arm-symbian-tdep.c: Sort headers.
5363         * arm-pikeos-tdep.c: Sort headers.
5364         * arm-obsd-tdep.c: Sort headers.
5365         * arm-nbsd-tdep.c: Sort headers.
5366         * arm-nbsd-nat.c: Sort headers.
5367         * arm-linux-tdep.c: Sort headers.
5368         * arm-linux-nat.c: Sort headers.
5369         * arm-fbsd-tdep.c: Sort headers.
5370         * arm-fbsd-nat.c: Sort headers.
5371         * arm-bsd-tdep.c: Sort headers.
5372         * arch-utils.c: Sort headers.
5373         * arc-tdep.c: Sort headers.
5374         * arc-newlib-tdep.c: Sort headers.
5375         * annotate.h: Sort headers.
5376         * annotate.c: Sort headers.
5377         * amd64-windows-tdep.c: Sort headers.
5378         * amd64-windows-nat.c: Sort headers.
5379         * amd64-tdep.c: Sort headers.
5380         * amd64-sol2-tdep.c: Sort headers.
5381         * amd64-obsd-tdep.c: Sort headers.
5382         * amd64-obsd-nat.c: Sort headers.
5383         * amd64-nbsd-tdep.c: Sort headers.
5384         * amd64-nbsd-nat.c: Sort headers.
5385         * amd64-nat.c: Sort headers.
5386         * amd64-linux-tdep.c: Sort headers.
5387         * amd64-linux-nat.c: Sort headers.
5388         * amd64-fbsd-tdep.c: Sort headers.
5389         * amd64-fbsd-nat.c: Sort headers.
5390         * amd64-dicos-tdep.c: Sort headers.
5391         * amd64-darwin-tdep.c: Sort headers.
5392         * amd64-bsd-nat.c: Sort headers.
5393         * alpha-tdep.c: Sort headers.
5394         * alpha-obsd-tdep.c: Sort headers.
5395         * alpha-nbsd-tdep.c: Sort headers.
5396         * alpha-mdebug-tdep.c: Sort headers.
5397         * alpha-linux-tdep.c: Sort headers.
5398         * alpha-linux-nat.c: Sort headers.
5399         * alpha-bsd-tdep.c: Sort headers.
5400         * alpha-bsd-nat.c: Sort headers.
5401         * aix-thread.c: Sort headers.
5402         * agent.c: Sort headers.
5403         * addrmap.c: Sort headers.
5404         * ada-varobj.c: Sort headers.
5405         * ada-valprint.c: Sort headers.
5406         * ada-typeprint.c: Sort headers.
5407         * ada-tasks.c: Sort headers.
5408         * ada-lang.c: Sort headers.
5409         * aarch64-tdep.c: Sort headers.
5410         * aarch64-ravenscar-thread.c: Sort headers.
5411         * aarch64-newlib-tdep.c: Sort headers.
5412         * aarch64-linux-tdep.c: Sort headers.
5413         * aarch64-linux-nat.c: Sort headers.
5414         * aarch64-fbsd-tdep.c: Sort headers.
5415         * aarch64-fbsd-nat.c: Sort headers.
5416         * aarch32-linux-nat.c: Sort headers.
5417
5418 2019-04-04  Tom Tromey  <tom@tromey.com>
5419
5420         * varobj.c (varobj_create): Update.
5421         * rust-exp.y (struct rust_parser) <update_innermost_block,
5422         lookup_symbol>: New methods.
5423         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5424         Rename.
5425         (rust_parser::rust_lookup_type)
5426         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5427         * printcmd.c (display_command, do_one_display): Update.
5428         * parser-defs.h (struct parser_state) <parser_state>: Add
5429         "tracker" parameter.
5430         (block_tracker): New member.
5431         (class innermost_block_tracker) <innermost_block_tracker>: Add
5432         "types" parameter.
5433         <reset>: Remove method.
5434         (innermost_block): Don't declare.
5435         (null_post_parser): Update.
5436         * parse.c (innermost_block): Remove global.
5437         (write_dollar_variable): Update.
5438         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5439         Remove "tracker_types" parameter.
5440         (parse_expression): Add "tracker" parameter.
5441         (parse_expression_for_completion): Update.
5442         (null_post_parser): Add "tracker" parameter.
5443         * p-exp.y: Update rules.
5444         * m2-exp.y: Update rules.
5445         * language.h (struct language_defn) <la_post_parser>: Add
5446         "tracker" parameter.
5447         * go-exp.y: Update rules.
5448         * f-exp.y: Update rules.
5449         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5450         parameter.
5451         * d-exp.y: Update rules.
5452         * c-exp.y: Update rules.
5453         * breakpoint.c (set_breakpoint_condition): Create an
5454         innermost_block_tracker.
5455         (watch_command_1): Likewise.
5456         * ada-lang.c (resolve): Add "tracker" parameter.
5457         (resolve_subexp): Likewise.
5458         * ada-exp.y (write_var_from_sym): Update.
5459
5460 2019-04-04  Tom Tromey  <tom@tromey.com>
5461
5462         * type-stack.h: New file.
5463         * type-stack.c: New file.
5464         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5465         type-stack.h.
5466         (insert_into_type_stack, insert_type, push_type, push_type_int)
5467         (insert_type_address_space, pop_type, pop_type_int)
5468         (pop_typelist, pop_type_stack, append_type_stack)
5469         (push_type_stack, get_type_stack, push_typelist)
5470         (follow_type_instance_flags, follow_types): Don't declare.
5471         * parse.c (type_stack): Remove global.
5472         (parse_exp_in_context): Update.
5473         (insert_into_type_stack, insert_type, push_type, push_type_int)
5474         (insert_type_address_space, pop_type, pop_type_int)
5475         (pop_typelist, pop_type_stack, append_type_stack)
5476         (push_type_stack, get_type_stack, push_typelist)
5477         (follow_type_instance_flags, follow_types): Remove (moved to
5478         type-stack.c).
5479         * f-exp.y (type_stack): New global.
5480         Update rules.
5481         (push_kind_type, f_parse): Update.
5482         * d-exp.y (type_stack): New global.
5483         Update rules.
5484         (d_parse): Update.
5485         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5486         Update rules.
5487         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5488         (HFILES_NO_SRCDIR): Add type-stack.h.
5489
5490 2019-04-04  Tom Tromey  <tom@tromey.com>
5491
5492         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5493         (rust_parser::convert_ast_to_expression, rust_parse)
5494         (rust_lex_test_completion, rust_lex_tests): Update.
5495         * parser-defs.h (struct expr_completion_state): New.
5496         (struct parser_state) <parser_state>: Add completion parameter.
5497         <mark_struct_expression, mark_completion_tag>: New methods.
5498         <parse_completion, m_completion_state>: New members.
5499         (prefixify_expression, null_post_parser): Update.
5500         (mark_struct_expression, mark_completion_tag): Don't declare.
5501         * parse.c (parse_completion, expout_last_struct)
5502         (expout_tag_completion_type, expout_completion_name): Remove
5503         globals.
5504         (parser_state::mark_struct_expression)
5505         (parser_state::mark_completion_tag): Now methods.
5506         (prefixify_expression): Add last_struct parameter.
5507         (prefixify_subexp): Likewise.
5508         (parse_exp_1): Update.
5509         (parse_exp_in_context): Add cstate parameter.  Update.
5510         (parse_expression_for_completion): Create an
5511         expr_completion_state.
5512         (null_post_parser): Add "completion" parameter.
5513         * p-exp.y: Update rules.
5514         (yylex): Update.
5515         * language.h (struct language_defn) <la_post_parser>: Add
5516         "completing" parameter.
5517         * go-exp.y: Update rules.
5518         (lex_one_token): Update.
5519         * expression.h (parse_completion): Don't declare.
5520         * d-exp.y: Update rules.
5521         (lex_one_token): Update rules.
5522         * c-exp.y: Update rules.
5523         (lex_one_token): Update.
5524         * ada-lang.c (resolve): Add "parse_completion" parameter.
5525         (resolve_subexp): Likewise.
5526         (ada_resolve_function): Likewise.
5527
5528 2019-04-04  Tom Tromey  <tom@tromey.com>
5529
5530         * parser-defs.h (struct parser_state) <start_arglist,
5531         end_arglist>: New methods.
5532         <arglist_len, m_funcall_chain>: New members.
5533         (arglist_len, start_arglist, end_arglist): Don't declare.
5534         * parse.c (arglist_len, funcall_chain): Remove global.
5535         (start_arglist, end_arglist): Remove functions.
5536         (parse_exp_in_context): Update.
5537         * p-exp.y: Update rules.
5538         * m2-exp.y: Update rules.
5539         * go-exp.y: Update rules.
5540         * f-exp.y: Update rules.
5541         * d-exp.y: Update rules.
5542         * c-exp.y: Update rules.
5543
5544 2019-04-04  Tom Tromey  <tom@tromey.com>
5545
5546         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5547         lex_operator, push_back>: New methods.
5548         Update all rules.
5549         (rust_parser::lex_hex, lex_escape): Rename and update.
5550         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5551         (rust_parser::lex_operator): Rename and update.
5552         (rust_parser::lex_number, rustyylex, rustyyerror)
5553         (rust_lex_test_init, rust_lex_test_sequence)
5554         (rust_lex_test_push_back, rust_lex_tests): Update.
5555         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5556         parameter.
5557         <lexptr, prev_lexptr>: New members.
5558         (lexptr, prev_lexptr): Don't declare.
5559         * parse.c (lexptr, prev_lexptr): Remove globals.
5560         (parse_exp_in_context): Update.
5561         * p-exp.y (yylex, yyerror): Update.
5562         * m2-exp.y (parse_number, yylex, yyerror): Update.
5563         * go-exp.y (lex_one_token, yyerror): Update.
5564         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5565         * d-exp.y (lex_one_token, yyerror): Update.
5566         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5567         (lex_one_token, yyerror): Update.
5568         * ada-lex.l (YY_INPUT): Update.
5569         (rewind_to_char): Update.
5570         * ada-exp.y (yyerror): Update.
5571
5572 2019-04-04  Tom Tromey  <tom@tromey.com>
5573
5574         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5575         * parser-defs.h (struct parser_state) <parser_state>: Add new
5576         parameter.
5577         <comma_terminates>: New member.
5578         (comma_terminates): Don't declare global.
5579         * parse.c (comma_terminates): Remove global.
5580         (parse_exp_in_context): Update.
5581         * p-exp.y (yylex): Update.
5582         * m2-exp.y (yylex): Update.
5583         * go-exp.y (lex_one_token): Update.
5584         * f-exp.y (yylex): Update.
5585         * d-exp.y (lex_one_token): Update.
5586         * c-exp.y (lex_one_token): Update.
5587         * ada-lex.l: Update.
5588
5589 2019-04-04  Tom Tromey  <tom@tromey.com>
5590
5591         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5592         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5593         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5594         * parser-defs.h (paren_depth): Don't declare.
5595         * parse.c (paren_depth): Remove global.
5596         (parse_exp_in_context): Update.
5597         * p-exp.y (paren_depth): New global.
5598         (pascal_parse): Initialize it.
5599         * m2-exp.y (paren_depth): New global.
5600         (m2_parse): Initialize it.
5601         * go-exp.y (paren_depth): New global.
5602         (go_parse): Initialize it.
5603         * f-exp.y (paren_depth): New global.
5604         (f_parse): Initialize it.
5605         * d-exp.y (paren_depth): New global.
5606         (d_parse): Initialize it.
5607         * c-exp.y (paren_depth): New global.
5608         (c_parse): Initialize it.
5609         * ada-lex.l (paren_depth): New global.
5610         (lexer_init): Initialize it.
5611
5612 2019-04-04  Tom Tromey  <tom@tromey.com>
5613
5614         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5615         (rust_parser::convert_ast_to_type)
5616         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5617         * parser-defs.h (struct parser_state) <parser_state>: Add
5618         parameters.  Initialize new members.
5619         <expression_context_block, expression_context_pc>: New members.
5620         * parse.c (expression_context_block, expression_context_pc):
5621         Remove globals.
5622         (parse_exp_in_context): Update.
5623         * p-exp.y: Update all rules.
5624         (yylex): Update.
5625         * m2-exp.y: Update all rules.
5626         (yylex): Update.
5627         * go-exp.y (yylex): Update.
5628         * f-exp.y (yylex): Update.
5629         * d-exp.y: Update all rules.
5630         (yylex): Update.
5631         * c-exp.y: Update all rules.
5632         (lex_one_token, classify_name, yylex, c_parse): Update.
5633         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5634
5635 2019-04-04  Tom Tromey  <tom@tromey.com>
5636
5637         * gdbarch.h, gdbarch.c: Rebuild.
5638         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5639         * stap-probe.h:
5640         (struct stap_parse_info): Replace "parser_state" with
5641         "expr_builder".
5642         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5643         (parser_state): New class.
5644         * parse.c (expr_builder): Rename.
5645         (expr_builder::release): Rename.
5646         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5647         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5648         (write_exp_elt_longcst, write_exp_elt_floatcst)
5649         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5650         (write_exp_string_vector, write_exp_bitstring)
5651         (write_exp_msymbol, mark_struct_expression)
5652         (write_dollar_variable)
5653         (insert_type_address_space, increase_expout_size): Replace
5654         "parser_state" with "expr_builder".
5655         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5656         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5657         "parser_state" with "expr_builder".
5658
5659 2019-04-04  Tom Tromey  <tom@tromey.com>
5660
5661         * rust-exp.y: Replace "parse_language" with method call.
5662         * p-exp.y:
5663         (yylex): Replace "parse_language" with method call.
5664         * m2-exp.y:
5665         (yylex): Replace "parse_language" with method call.
5666         * go-exp.y (classify_name): Replace "parse_language" with method
5667         call.
5668         * f-exp.y (yylex): Replace "parse_language" with method call.
5669         * d-exp.y (lex_one_token): Replace "parse_language" with method
5670         call.
5671         * c-exp.y:
5672         (lex_one_token, classify_name, yylex): Replace "parse_language"
5673         with method call.
5674         * ada-exp.y (find_primitive_type, type_char)
5675         (type_system_address): Replace "parse_language" with method call.
5676
5677 2019-04-04  Tom Tromey  <tom@tromey.com>
5678
5679         * rust-exp.y: Replace "parse_gdbarch" with method call.
5680         * parse.c (write_dollar_variable, insert_type_address_space):
5681         Replace "parse_gdbarch" with method call.
5682         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5683         call.
5684         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5685         call.
5686         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5687         "parse_gdbarch" with method call.
5688         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5689         with method call.
5690         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5691         "parse_gdbarch" with method call.
5692         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5693         "parse_gdbarch" with method call.
5694         * c-exp.y (parse_type, parse_number, classify_name): Replace
5695         "parse_gdbarch" with method call.
5696         * ada-lex.l: Replace "parse_gdbarch" with method call.
5697         * ada-exp.y (parse_type, find_primitive_type, type_char)
5698         (type_system_address): Replace "parse_gdbarch" with method call.
5699
5700 2019-04-04  Tom Tromey  <tom@tromey.com>
5701
5702         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5703         * stap-probe.c (stap_parse_argument): Update.
5704         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5705         initial_size parameter.
5706         * rust-exp.y (rust_lex_tests): Update.
5707         * parse.c (parser_state): Update.
5708         (parse_exp_in_context): Update.
5709         * parser-defs.h (struct parser_state) <parser_state>: Remove
5710         "initial_size" parameter.
5711
5712 2019-04-04  Tom Tromey  <tom@tromey.com>
5713
5714         * parser-defs.h (increase_expout_size): Don't declare.
5715         * parse.c (increase_expout_size): Now static.
5716
5717 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5718
5719         * gnu-nat.c (gnu_nat_target::wait): Fix
5720         target_waitstatus_to_string call.
5721
5722 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5723
5724         * eval.c (evaluate_subexp_standard): Handle internal functions
5725         during Fortran function call handling.
5726
5727 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5728
5729         * NEWS: Mention new internal functions.
5730         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5731         (read_base_type): Use dwarf2_init_complex_target_type.
5732         * value.c (creal_internal_fn): New function.
5733         (cimag_internal_fn): New function.
5734         (_initialize_values): Register new internal functions.
5735
5736 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5737
5738         * infrun.c (stop_all_threads): If debug_infrun, always
5739         trace the wait status after wait_one, using
5740         target_waitstatus_to_string and target_pid_to_str.
5741         (handle_inferior_event): Replace various trace of
5742         wait status kind by a single trace.
5743         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5744         wait status kind image by target_waitstatus_to_string.
5745         * target/waitstatus.c (target_waitstatus_to_string): Fix
5746         obsolete comment.
5747
5748 2019-04-01  Tom Tromey  <tromey@adacore.com>
5749
5750         PR symtab/23331:
5751         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5752
5753 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5754             Pedro Alves  <palves@redhat.com>
5755
5756         * top.c (quit_force): Call 'finalize_values'.
5757         * value.c (finalize_values): New function.
5758         * value.h (finalize_values): Declare.
5759
5760 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5761
5762         * NEWS: Announce $_gdb_major and $_gdb_minor.
5763
5764         * top.c (init_gdb_version_vars): New function.
5765         (gdb_init): Call init_gdb_version_vars.
5766
5767 2019-03-29  Tom Tromey  <tromey@adacore.com>
5768
5769         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5770         help text.  Remove dead code.
5771
5772 2019-03-29  Keith Seitz  <keiths@redhat.com>
5773
5774         From Siddhesh Poyarekar:
5775         * f-lang.h (f77_get_upperbound): Return LONGEST.
5776         (f77_get_lowerbound): Likewise.
5777         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5778         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5779         print them.
5780         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5781         plongest to format print it.
5782         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5783         (f77_get_upperbound): Likewise.
5784         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5785         LOWER_BOUND to LONGEST.
5786         (f77_create_arrayprint_offset_tbl): Likewise.
5787
5788 2019-03-29  Keith Seitz  <keiths@redhat.com>
5789
5790         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5791         %s/pulongest for TYPE_LENGTH instead of %d in format
5792         strings.
5793         * ada-typerint.c (ada_print_type): Likewise.
5794         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5795         * compile/compile-c-support.c (generate_register_struct): Likewise.
5796         * gdbtypes.c (recursive_dump_type): Likewise.
5797         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5798         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5799         instead of %d in format strings.
5800         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5801         to std::min to ULONGEST.
5802         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5803         instead of %d in format strings.
5804         * tracepoint.c (info_scope_command): Likewise.
5805         * typeprint.c (print_offset_data::update)
5806         (print_offset_data::finish): Likewise.
5807         * xtensa-tdep.c (xtensa_store_return_value)
5808         (xtensa_push_dummy_call): Likewise.
5809
5810 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5811
5812         * windows-nat.c (display_selector): Fixed format specifications
5813         for 64-bit Cygwin.
5814
5815 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5816
5817         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5818
5819 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5820
5821         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5822         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5823         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5824         (nios2_linux_init_abi): Install it.
5825
5826 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5827
5828         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5829
5830 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5831
5832         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5833
5834 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5835             Tom Tromey  <tromey@adacore.com>
5836
5837         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5838
5839 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5840
5841         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5842         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5843         method to compute the bounds of range types. Also print "[evaluated]"
5844         if the bounds' values come from a dynamic evaluation.
5845
5846 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5847
5848         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5849         whitespace when pretty printing is on.
5850
5851 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5852
5853         * ppc-linux-nat.c: Add include.
5854
5855 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5856
5857         * NEWS: Mention AArch64 Pointer Authentication.
5858
5859 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5860
5861         * arm-linux-nat.c: Add include.
5862
5863 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5864
5865         * source-cache.c (source_cache::get_source_lines): Re-read
5866         fullname after calling open_source_file.
5867
5868 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5869
5870         * NEWS: Mention TLS support for FreeBSD.
5871
5872 2019-03-25  Tom Tromey  <tromey@adacore.com>
5873
5874         * minsyms.c (BUNCH_SIZE): Update comment.
5875         (~minimal_symbol_reader): Remove old comment.
5876         (compact_minimal_symbols): Update comment.
5877         (minimal_symbol_reader::install): Remove old comment.  Update
5878         other comments.
5879
5880 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5881
5882         * s390-linux-nat.c: Add include.
5883
5884 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5885
5886         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5887         Call linux_get_hwcap.
5888         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5889         Likewise.
5890         (aarch64_linux_get_hwcap): Remove function.
5891         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5892         declaration.
5893         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5894         linux_get_hwcap.
5895         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5896         * linux-tdep.c (linux_get_hwcap): Add function.
5897         (linux_get_hwcap2): Likewise.
5898         * linux-tdep.h (linux_get_hwcap): Add declaration.
5899         (linux_get_hwcap2): Likewise.
5900         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5901         (ppc_linux_get_hwcap2): Likewise.
5902         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5903         linux_get_hwcap.
5904         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5905         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5906         (ppc_linux_nat_target::read_description): Likewise.
5907         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5908         * s390-linux-nat.c: Likewise.
5909         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5910
5911 2019-03-24  Tom Tromey  <tom@tromey.com>
5912
5913         * ada-lang.c (standard_lookup): Simplify initialization.
5914         (ada_lookup_symbol_nonlocal): Simplify return.
5915         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5916         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5917         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5918         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5919         initialization.
5920         * solib.c (solib_global_lookup): Simplify.
5921         * symtab.c (null_block_symbol): Remove.
5922         (symbol_cache_lookup): Simplify returns.
5923         (lookup_language_this): Simplify returns.
5924         (lookup_symbol_aux): Simplify return.
5925         (lookup_local_symbol): Simplify returns.
5926         (lookup_global_symbol_from_objfile): Simplify return.
5927         (lookup_symbol_in_objfile_symtabs)
5928         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5929         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5930         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5931         * cp-namespace.c (cp_lookup_bare_symbol)
5932         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5933         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5934         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5935         (cp_lookup_symbol_via_imports): Simplify initialization.
5936         (find_symbol_in_baseclass): Likewise.
5937         * symtab.h (null_block_symbol): Remove.
5938         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5939         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5940         (d_lookup_symbol_module): Likewise.
5941         (find_symbol_in_baseclass): Simplify initialization.
5942
5943 2019-03-24  Tom Tromey  <tom@tromey.com>
5944
5945         * expression.h: Don't include symtab.h.
5946         (struct block): Forward declare.
5947
5948 2019-03-24  Tom Tromey  <tom@tromey.com>
5949
5950         * c-exp.y (typebase): Remove casts.
5951         * gdbtypes.c (lookup_unsigned_typename, )
5952         (lookup_signed_typename): Remove cast.
5953         * eval.c (parse_to_comma_and_eval): Remove cast.
5954         * parse.c (write_dollar_variable): Remove cast.
5955         * block.h (struct block) <superblock>: Now const.
5956         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5957         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5958         (map_block): Make "block" const.
5959         * symfile.h (struct quick_symbol_functions)
5960         <map_matching_symbols>: Constify block argument to "callback".
5961         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5962         const.
5963         (find_pc_sect_compunit_symtab): Make "b" const.
5964         (find_symbol_at_address): Likewise.
5965         (search_symbols): Likewise.
5966         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5967         (dw2_debug_names_lookup_symbol): Likewise.
5968         (dw2_map_matching_symbols): Update.
5969         * p-valprint.c (pascal_val_print): Remove "block".
5970         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5971         (aux_add_nonlocal_symbols): Make "block" const.
5972         (resolve_subexp): Remove cast.
5973         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5974         const.
5975         (iterate_over_file_blocks): Likewise.
5976         * f-exp.y (%union) <bval>: Remove.
5977         * coffread.c (patch_opaque_types): Make "b" const.
5978         * spu-tdep.c (spu_catch_start): Make "block" const.
5979         * c-valprint.c (print_unpacked_pointer): Remove "block".
5980         * symmisc.c (dump_symtab_1): Make "b" const.
5981         (block_depth): Make "block" const.
5982         * d-exp.y (%union) <bval>: Remove.
5983         * cp-support.h (cp_lookup_rtti_type): Update.
5984         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5985         * psymtab.c (psym_lookup_symbol): Make "block" const.
5986         (maintenance_check_psymtabs): Make "b" const.
5987         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5988         (enumerate_locals, enumerate_args): Update.
5989         * python/py-symtab.c (stpy_global_block): Make "block" const.
5990         (stpy_static_block): Likewise.
5991         * inline-frame.c (block_starting_point_at): Make "new_block"
5992         const.
5993         * block.c (find_block_in_blockvector): Make return type const.
5994         (blockvector_for_pc_sect): Make "b" const.
5995         (find_block_in_blockvector): Make "b" const.
5996
5997 2019-03-23  Tom Tromey  <tom@tromey.com>
5998
5999         * varobj.c (varobj_create): Update.
6000         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6001         * printcmd.c (display_command, do_one_display): Don't reset
6002         innermost_block.
6003         * parser-defs.h (enum innermost_block_tracker_type): Move to
6004         expression.h.
6005         (innermost_block): Update comment.
6006         * parse.c (parse_exp_1): Add tracker_types parameter.
6007         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6008         tracker_types parameter.  Reset innermost_block.
6009         (parse_exp_in_context): Remove.
6010         (parse_expression_for_completion): Update.
6011         * objfiles.c (~objfile): Don't reset expression_context_block or
6012         innermost_block.
6013         * expression.h (enum innermost_block_tracker_type): Move from
6014         parser-defs.h.
6015         (parse_exp_1): Add tracker_types parameter.
6016         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6017         reset innermost_block.
6018
6019 2019-03-23  Tom Tromey  <tom@tromey.com>
6020
6021         * objfiles.h: Include bcache.h.
6022
6023 2019-03-23  Tom Tromey  <tom@tromey.com>
6024
6025         * linespec.c (get_current_search_block): Use
6026         scoped_restore_current_language.
6027         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6028
6029 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6030             Jiong Wang  <jiong.wang@arm.com>
6031
6032         * aarch64-linux-tdep.c
6033         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6034         section.
6035         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6036
6037 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6038             Jiong Wang  <jiong.wang@arm.com>
6039
6040         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6041         instructions.
6042         (aarch64_analyze_prologue_test): Add PACIASP test.
6043         (aarch64_prologue_prev_register): Unmask PC value.
6044
6045 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6046             Jiong Wang  <jiong.wang@arm.com>
6047
6048         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6049         (aarch64_dwarf2_prev_register): Unmask PC value.
6050         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6051         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6052         DW_CFA_AARCH64_negate_ra_state.
6053         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6054
6055 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6056             Jiong Wang  <jiong.wang@arm.com>
6057
6058         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6059         registers.
6060         (aarch64_pseudo_register_name): Likewise.
6061         (aarch64_pseudo_register_type): Likewise.
6062         (aarch64_pseudo_register_reggroup_p): Likewise.
6063         (aarch64_gdbarch_init): Add pauth registers.
6064         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6065         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6066         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6067         (struct gdbarch_tdep): Add regnum for ra_state.
6068
6069 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6070             Jiong Wang  <jiong.wang@arm.com>
6071
6072         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6073
6074 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6075             Jiong Wang  <jiong.wang@arm.com>
6076
6077         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6078         function.
6079         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6080         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6081         (aarch64_gdbarch_init): Add puth registers.
6082         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6083         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6084         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6085
6086 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6087             Jiong Wang  <jiong.wang@arm.com>
6088
6089         * aarch64-linux-nat.c
6090         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6091         * aarch64-linux-tdep.c
6092         (aarch64_linux_core_read_description): Likewise.
6093         (aarch64_linux_get_hwcap): New function.
6094         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6095         (aarch64_linux_get_hwcap): New declaration.
6096
6097 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6098             Jiong Wang  <jiong.wang@arm.com>
6099
6100         * aarch64-linux-nat.c
6101         (aarch64_linux_nat_target::read_description): Add pauth param.
6102         * aarch64-linux-tdep.c
6103         (aarch64_linux_core_read_description): Likewise.
6104         * aarch64-tdep.c (struct target_desc): Add in pauth.
6105         (aarch64_read_description): Add pauth param.
6106         (aarch64_gdbarch_init): Likewise.
6107         * aarch64-tdep.h (aarch64_read_description): Likewise.
6108         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6109         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6110         * features/Makefile: Add new files.
6111         * features/aarch64-pauth.c: New file.
6112         * features/aarch64-pauth.xml: New file.
6113
6114 2019-03-20  Tom Tromey  <tromey@adacore.com>
6115
6116         * infrun.c (handle_inferior_event): Rename from
6117         handle_inferior_event_1.  Create a scoped_value_mark.
6118         (handle_inferior_event): Remove.
6119
6120 2019-03-19  Tom Tromey  <tromey@adacore.com>
6121
6122         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6123         * infrun.h (print_stop_event): Add "displays" parameter.
6124         * infrun.c (print_stop_event): Add "displays" parameter.
6125
6126 2019-03-19  Pedro Alves  <palves@redhat.com>
6127
6128         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6129         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6130         to -1.  Fix TABs vs spaces.
6131         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6132         * tui/tui-out.h (tui_ui_out) Add intro comments.
6133         <m_line, m_start_of_line>: In-class initialize, and add describing
6134         comment.
6135
6136 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6137
6138         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6139         variable names.
6140         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6141
6142 2019-03-18  Pedro Alves  <palves@redhat.com>
6143             Eli Zaretskii <eliz@gnu.org>
6144
6145         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6146         m_line and m_start_of_line.
6147
6148 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6149
6150         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6151         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6152         it returns a newline.  This fixes a regression in TU mode, whereby
6153         the next line is output on the same screen line as the user input.
6154
6155 2019-03-18  Tom Tromey  <tromey@adacore.com>
6156
6157         * minsyms.c (minimal_symbol_reader::install): Remove call to
6158         obstack_blank.
6159
6160 2019-03-18  Pedro Alves  <palves@redhat.com>
6161
6162         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6163         New globals.
6164         (apply_style): New, factored out from ...
6165         (apply_ansi_escape): ... this.  Handle reverse video mode.
6166         (tui_set_reverse_mode): New function.
6167         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6168         * tui/tui-winsource.c (tui_show_source_line): Use
6169         tui_set_reverse_mode instead of setting A_STANDOUT.
6170         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6171         New setter methods.
6172
6173 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6174
6175         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6176         Handle tabs.
6177
6178 2019-03-18  Tom Tromey  <tromey@adacore.com>
6179
6180         * ada-lang.c (empty_array): Add "high" parameter.
6181         (ada_evaluate_subexp): Update.
6182
6183 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6184
6185         * unittests/string_view-selftests.c: Define
6186         _initialize_string_view_selftests unconditionally.
6187
6188 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6189
6190         PR gdb/24350
6191         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6192
6193 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6194
6195         PR gdb/24351
6196         * windows-nat.c (display_selector): Fix format specifiers.
6197
6198 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6199
6200         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6201         tui_refill_source_window instead of tui_refresh_win, to update the
6202         current execution line.  This fixes redisplay of the current line
6203         when stepping through the code with "next" or "step".
6204
6205 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6206
6207         * source-cache.c (source_cache::get_source_lines): Call
6208         find_source_lines to initialize s->nlines.  This fixes vertical
6209         scrolling of TUI source window when the DOWN arrow is pressed.
6210
6211 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6212
6213         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6214         linux-thread-db.c (_initialize_thread_db): Likewise.
6215
6216 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6217
6218         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6219         wclrtoeol in tui_show_source_line".  This reverts changes made in
6220         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6221
6222 2019-03-15  Tom Tromey  <tom@tromey.com>
6223
6224         * symtab.h (struct minimal_symbol): Derive from
6225         general_symbol_info.
6226         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6227         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6228         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6229         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6230         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6231         (MSYMBOL_SEARCH_NAME): Update.
6232         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6233         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6234         * minsyms.c (minimal_symbol_reader::record_full): Update.
6235
6236 2019-03-15  Tom Tromey  <tom@tromey.com>
6237
6238         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6239
6240 2019-03-15  Tom Tromey  <tom@tromey.com>
6241
6242         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6243         unique_xmalloc_ptr.
6244         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6245         Update.
6246         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6247         (build_minimal_symbol_hash_tables)
6248         (minimal_symbol_reader::install): Update.
6249
6250 2019-03-15  Tom Tromey  <tom@tromey.com>
6251
6252         * symtab.c (create_demangled_names_hash): Update.
6253         (symbol_set_names): Update.
6254         * objfiles.h (struct objfile_per_bfd_storage)
6255         <demangled_names_hash>: Now an htab_up.
6256         * objfiles.c (objfile_per_bfd_storage): Simplify.
6257
6258 2019-03-15  Tom Tromey  <tom@tromey.com>
6259
6260         * objfiles.h (struct objfile_per_bfd_storage): Declare
6261         destructor.
6262         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6263         New.
6264         (get_objfile_bfd_data): Use new.  Don't initialize
6265         language_of_main.
6266         (free_objfile_per_bfd_storage): Remove.
6267         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6268
6269 2019-03-15  Tom Tromey  <tom@tromey.com>
6270
6271         * symfile.c (reread_symbols): Update.
6272         * objfiles.c (objfile::objfile): Update.
6273         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6274         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6275         comment.
6276         (minimal_symbol_reader::install): Update.
6277         (terminate_minimal_symbol_table): Remove.
6278         * jit.c (jit_object_close_impl): Update.
6279
6280 2019-03-15  Tom Tromey  <tom@tromey.com>
6281
6282         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6283         initializations.
6284
6285 2019-03-15  Tom Tromey  <tom@tromey.com>
6286
6287         * objfiles.h (struct objfile_per_bfd_storage)
6288         <demangled_hash_languages>: Now a bitset.
6289         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6290         (lookup_minimal_symbol): Update.
6291
6292 2019-03-15  Tom Tromey  <tom@tromey.com>
6293
6294         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6295         Don't return the symbol.
6296         * coffread.c (record_minimal_symbol): Use record_full.
6297
6298 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6299
6300         The MS-Windows port of ncurses fails to switch to a color pair if
6301         one or both of the colors are the implicit default colors.  This
6302         change records the default colors when TUI is initialized, and
6303         then specifies them explicitly when a color pair uses the default
6304         colors.  This allows color styling in TUI mode on MS-Windows.
6305
6306         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6307         ncurses_norm_attr.
6308         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6309         colors in ncurses_norm_attr.
6310         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6311         "none", replace it with the default color recorded in
6312         ncurses_norm_attr.
6313
6314 2019-03-14  Tom Tromey  <tromey@adacore.com>
6315
6316         * source-cache.h (class source_cache) <get_source_lines>: Return
6317         std::string.
6318         * source-cache.c (source_cache::extract_lines): Handle case where
6319         first_pos==npos.  Return std::string.
6320         (source_cache::get_source_lines): Update.
6321
6322 2019-03-14  Tom Tromey  <tromey@adacore.com>
6323
6324         * NEWS: Add item for "style sources" commands.
6325         * source-cache.c (source_cache::get_source_lines): Check
6326         source_styling.
6327         * cli/cli-style.c (source_styling): New global.
6328         (_initialize_cli_style): Add "style sources" commands.
6329         (show_style_sources): New function.
6330         * cli/cli-style.h (source_styling): Declare.
6331
6332 2019-03-14  Pedro Alves  <palves@redhat.com>
6333             Tom Tromey  <tromey@adacore.com>
6334
6335         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6336         * tui/tui-winsource.c (tui_refill_source_window): New function,
6337         from...
6338         (tui_horizontal_source_scroll): ... here.  Move some logic.
6339         * cli/cli-style.c (set_style_enabled): Notify new observable.
6340         * tui/tui-hooks.c (tui_redisplay_source): New function.
6341         (tui_attach_detach_observers): Attach or detach
6342         tui_redisplay_source.
6343         * observable.h (source_styling_changed): New observable.
6344         * observable.c: Define source_styling_changed observable.
6345
6346 2019-03-13  Tom Tromey  <tromey@adacore.com>
6347
6348         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6349         (i386_gnu_nat_target::store_registers): Update.
6350         * target-debug.h (target_debug_print_std_string): New macro.
6351         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6352         * windows-tdep.c (display_one_tib): Update.
6353         * tui/tui-stack.c (tui_make_status_line): Update.
6354         * top.c (print_inferior_quit_action): Update.
6355         * thread.c (thr_try_catch_cmd): Update.
6356         (add_thread_with_info): Update.
6357         (thread_target_id_str): Update.
6358         (thr_try_catch_cmd): Update.
6359         (thread_command): Update.
6360         (thread_find_command): Update.
6361         * record-btrace.c (record_btrace_target::info_record)
6362         (record_btrace_resume_thread, record_btrace_target::resume)
6363         (record_btrace_cancel_resume, record_btrace_step_thread)
6364         (record_btrace_target::wait, record_btrace_target::wait)
6365         (record_btrace_target::wait, record_btrace_target::stop): Update.
6366         * progspace.c (print_program_space): Update.
6367         * process-stratum-target.c
6368         (process_stratum_target::thread_address_space): Update.
6369         * linux-fork.c (linux_fork_mourn_inferior)
6370         (detach_checkpoint_command, info_checkpoints_command)
6371         (linux_fork_context): Update.
6372         (linux_fork_detach): Update.
6373         (class scoped_switch_fork_info): Update.
6374         (delete_checkpoint_command): Update.
6375         * infrun.c (follow_fork_inferior): Update.
6376         (follow_fork_inferior): Update.
6377         (proceed_after_vfork_done): Update.
6378         (handle_vfork_child_exec_or_exit): Update.
6379         (follow_exec): Update.
6380         (displaced_step_prepare_throw): Update.
6381         (displaced_step_restore): Update.
6382         (start_step_over): Update.
6383         (resume_1): Update.
6384         (clear_proceed_status_thread): Update.
6385         (proceed): Update.
6386         (print_target_wait_results): Update.
6387         (do_target_wait): Update.
6388         (context_switch): Update.
6389         (stop_all_threads): Update.
6390         (restart_threads): Update.
6391         (finish_step_over): Update.
6392         (handle_signal_stop): Update.
6393         (switch_back_to_stepped_thread): Update.
6394         (keep_going_pass_signal): Update.
6395         (print_exited_reason): Update.
6396         (normal_stop): Update.
6397         * inferior.c (inferior_pid_to_str): Change return type.
6398         (print_selected_inferior): Update.
6399         (add_inferior): Update.
6400         (detach_inferior): Update.
6401         * dummy-frame.c (fprint_dummy_frames): Update.
6402         * dcache.c (dcache_info_1): Update.
6403         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6404         (btrace_fetch, btrace_clear): Update.
6405         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6406         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6407         type.
6408         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6409         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6410         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6411         * gdbarch.c, gdbarch.h: Rebuild.
6412         * gdbarch.sh (core_pid_to_str): Change return type.
6413         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6414         return type.
6415         (windows_nat_target::pid_to_str): Change return type.
6416         (windows_delete_thread): Update.
6417         (windows_nat_target::attach): Update.
6418         (windows_nat_target::files_info): Update.
6419         * target-delegates.c: Rebuild.
6420         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6421         return type.
6422         (sol_thread_target::pid_to_str): Change return type.
6423         * remote.c (class remote_target) <pid_to_str>: Change return
6424         type.
6425         (remote_target::pid_to_str): Change return type.
6426         (extended_remote_target::attach, remote_target::remote_stop_ns)
6427         (remote_target::remote_notif_remove_queued_reply)
6428         (remote_target::push_stop_reply, remote_target::disable_btrace):
6429         Update.
6430         (extended_remote_target::attach): Update.
6431         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6432         type.
6433         (gdbsim_target::pid_to_str): Change return type.
6434         * ravenscar-thread.c (struct ravenscar_thread_target)
6435         <pid_to_str>: Change return type.
6436         (ravenscar_thread_target::pid_to_str): Change return type.
6437         * procfs.c (class procfs_target) <pid_to_str>: Change return
6438         type.
6439         (procfs_target::pid_to_str): Change return type.
6440         (procfs_target::attach): Update.
6441         (procfs_target::detach): Update.
6442         (procfs_target::fetch_registers): Update.
6443         (procfs_target::store_registers): Update.
6444         (procfs_target::wait): Update.
6445         (procfs_target::files_info): Update.
6446         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6447         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6448         return type.
6449         (nto_procfs_target::pid_to_str): Change return type.
6450         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6451         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6452         return type.
6453         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6454         (exit_lwp): Update.
6455         (attach_proc_task_lwp_callback, get_detach_signal)
6456         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6457         (linux_nat_target::resume, wait_lwp, stop_callback)
6458         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6459         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6460         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6461         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6462         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6463         type.
6464         (inf_ptrace_target::attach): Update.
6465         (inf_ptrace_target::files_info): Update.
6466         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6467         type.
6468         (go32_nat_target::pid_to_str): Change return type.
6469         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6470         (gnu_nat_target::wait): Update.
6471         (gnu_nat_target::wait): Update.
6472         (gnu_nat_target::resume): Update.
6473         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6474         (fbsd_nat_target::wait): Update.
6475         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6476         type.
6477         (darwin_nat_target::attach): Update.
6478         * corelow.c (class core_target) <pid_to_str>: Change return type.
6479         (core_target::pid_to_str): Change return type.
6480         * target.c (normal_pid_to_str): Change return type.
6481         (default_pid_to_str): Likewise.
6482         (target_pid_to_str): Change return type.
6483         (target_translate_tls_address): Update.
6484         (target_announce_detach): Update.
6485         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6486         return type.
6487         (bsd_uthread_target::pid_to_str): Change return type.
6488         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6489         type.
6490         (bsd_kvm_target::pid_to_str): Change return type.
6491         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6492         return type.
6493         (aix_thread_target::pid_to_str): Change return type.
6494         * target.h (struct target_ops) <pid_to_str>: Change return type.
6495         (target_pid_to_str, normal_pid_to_str): Likewise.
6496         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6497         type.
6498         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6499         type.
6500         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6501         return type.
6502         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6503         type.
6504         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6505         type.
6506         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6507         return type.
6508
6509 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6510
6511         * NEWS: Mention that the new default MI version is 3.  Mention
6512         changes to the output of commands and events that deal with
6513         multi-location breakpoints.
6514         * breakpoint.c: Include "mi/mi-out.h".
6515         (print_one_breakpoint): Change output syntax if using MI version
6516         >= 3.
6517         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6518         New.
6519         (mi_multi_location_breakpoint_output_fixed): New.
6520         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6521         (mi_cmd_fix_multi_location_breakpoint_output): New.
6522         (mi_multi_location_breakpoint_output_fixed): New.
6523         * mi/mi-cmds.c (mi_cmds): Register command
6524         -fix-multi-location-breakpoint-output.
6525         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6526         interpreter "mi".
6527
6528 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6529
6530         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6531         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6532         instantiate mi_ui_out based on interpreter name.
6533         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6534         * mi/mi-main.c (mi_load_progress): Likewise.
6535
6536 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6537
6538         * NEWS: Combine separate "New targets" sections for 8.3.
6539
6540 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6541
6542         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6543         (ppcfbsd_init_abi): Install gdbarch
6544         "fetch_tls_load_module_address" and "get_thread_local_address"
6545         methods.
6546
6547 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6548
6549         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6550         (riscv_fbsd_init_abi): Install gdbarch
6551         "fetch_tls_load_module_address" and "get_thread_local_address"
6552         methods.
6553
6554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6555
6556         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6557         (i386fbsd_init_abi): Install gdbarch
6558         "fetch_tls_load_module_address" and "get_thread_local_address"
6559         methods.
6560
6561 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6562
6563         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6564         (amd64fbsd_init_abi): Install gdbarch
6565         "fetch_tls_load_module_address" and "get_thread_local_address"
6566         methods.
6567
6568 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6569
6570         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6571         (struct fbsd_pspace_data): New type.
6572         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6573         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6574         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6575         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6576         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6577
6578 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6579
6580         * gdbtypes.c (lookup_struct_elt): New function.
6581         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6582         * gdbtypes.h (struct struct_elt): New type.
6583         (lookup_struct_elt): New prototype.
6584
6585 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6586
6587         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6588         remove disabled code block.
6589
6590 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6591
6592         * gdbarch.sh (get_thread_local_address): New method.
6593         * gdbarch.h, gdbarch.c: Regenerate.
6594         * target.c (target_translate_tls_address): Use
6595         gdbarch_get_thread_local_address if present instead of
6596         target::get_thread_local_address.
6597
6598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6599
6600         * target.h (target::get_thread_local_address): Update comment.
6601
6602 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6603
6604         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6605         objfile->separate_debug_objfile_backlink if not NULL.
6606
6607 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6608
6609         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6610         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6611         (amd64bsd_store_inferior_registers): Likewise.
6612         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6613         Enable segment base registers.
6614         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6615         PT_GETFSBASE and PT_GETGSBASE.
6616         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6617         PT_SETGSBASE.
6618         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6619         segment base registers.
6620         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6621
6622 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6623
6624         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6625         Update calls to i386_target_description to add 'segments'
6626         parameter.
6627         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6628         add segment base registers.
6629         * arch/i386.c (i386_create_target_description): Add 'segments'
6630         parameter to enable segment base registers.
6631         * arch/i386.h (i386_create_target_description): Likewise.
6632         * features/i386/32bit-segments.xml: New file.
6633         * features/i386/32bit-segments.c: Generate.
6634         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6635         call to i386_target_description to add 'segments' parameter.
6636         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6637         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6638         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6639         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6640         if feature is present.
6641         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6642         Add 'segments' parameter to call to i386_target_description.
6643         (i386_target_description): Add 'segments' parameter to enable
6644         segment base registers.
6645         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6646         to call to i386_target_description.
6647         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6648         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6649         Define I386_NUM_REGS.
6650         (i386_target_description): Add 'segments' parameter to enable
6651         segment base registers.
6652
6653 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6654
6655         PR/24325
6656         * source-cache.c: #undef open and close, to avoid unresolved
6657         externals during linking.
6658
6659 2019-03-12  Tom Tromey  <tromey@adacore.com>
6660
6661         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6662         const.  Add initializers.
6663         (_initialize_remote): Don't initialize ptid globals.
6664
6665 2019-03-12  Pedro Alves  <palves@redhat.com>
6666
6667         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6668
6669 2019-03-12  Pedro Alves  <palves@redhat.com>
6670
6671         * cp-name-parser.y (main): Remove unused 'len' variable.
6672
6673 2019-03-12  Tom Tromey  <tromey@adacore.com>
6674
6675         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6676         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6677
6678 2019-03-12  Tom Tromey  <tromey@adacore.com>
6679
6680         * linux-nat.c (iterate_over_lwps): Update.
6681         (stop_callback): Remove parameter.
6682         (stop_wait_callback, detach_callback, resume_set_callback)
6683         (select_singlestep_lwp_callback, set_ignore_sigint)
6684         (status_callback, resumed_callback, resume_clear_callback)
6685         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6686         data parameter.
6687         (linux_nat_target::detach, linux_nat_target::resume)
6688         (linux_stop_and_wait_all_lwps, select_event_lwp)
6689         (linux_nat_filter_event, linux_nat_wait_1)
6690         (linux_nat_target::kill, linux_nat_target::stop)
6691         (linux_nat_target::stop): Update.
6692         (linux_nat_resume_callback): Change type.
6693         (resume_stopped_resumed_lwps, count_events_callback)
6694         (select_event_lwp_callback): Likewise.
6695         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6696         * arm-linux-nat.c (struct update_registers_data): Remove.
6697         (update_registers_callback): Change type.
6698         (arm_linux_insert_hw_breakpoint1): Update.
6699         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6700         parameter.
6701         (x86_linux_dr_set_addr): Update.
6702         (x86_linux_dr_set_control): Update.
6703         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6704         (iterate_over_lwps): Use gdb::function_view.
6705         * nat/aarch64-linux-hw-point.c (struct
6706         aarch64_dr_update_callback_param): Remove.
6707         (debug_reg_change_callback): Change type.
6708         (aarch64_notify_debug_reg_change): Update.
6709         * s390-linux-nat.c (s390_refresh_per_info): Update.
6710
6711 2019-03-11  Tom Tromey  <tromey@adacore.com>
6712
6713         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6714         redundant assignment to "this_cu".
6715
6716 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6717
6718         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6719
6720 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6721
6722         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6723         from...
6724         (rank_one_type): ... this.
6725
6726 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6727
6728         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6729         from...
6730         (rank_one_type): ... this.
6731
6732 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6733
6734         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6735         from...
6736         (rank_one_type): ... this.
6737
6738 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6739
6740         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6741         from...
6742         (rank_one_type): ... this.
6743
6744 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6745
6746         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6747         from...
6748         (rank_one_type): ... this.
6749
6750 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6751
6752         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6753         from...
6754         (rank_one_type): ... this.
6755
6756 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6757
6758         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6759         from...
6760         (rank_one_type): ... this.
6761
6762 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6763
6764         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6765         from...
6766         (rank_one_type): ... this.
6767
6768 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6769
6770         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6771         from...
6772         (rank_one_type): ... this.
6773
6774 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6775
6776         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6777         from...
6778         (rank_one_type): ... this.
6779
6780 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6781
6782         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6783         from...
6784         (rank_one_type): ... this.
6785
6786 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6787
6788         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6789         from...
6790         (rank_one_type): ... this.
6791
6792 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6793
6794         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6795         inferior-events' shows the example events.
6796
6797 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6798
6799         Support styling on native MS-Windows console
6800
6801         PR/24315
6802         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6803         on MS-Windows if $TERM is not defined.
6804
6805         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6806
6807         * posix-hdep.c (gdb_console_fputs):
6808         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6809         functions.
6810         * ui-file.h (gdb_console_fputs): Add prototype.
6811
6812         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6813         back to fputs only if the former returns zero.
6814
6815 2019-03-07  Tom Tromey  <tom@tromey.com>
6816
6817         * symmisc.c (print_symbol_bcache_statistics): Update.
6818         (print_objfile_statistics): Update.
6819         * symfile.c (allocate_symtab): Update.
6820         * stabsread.c: Don't include bcache.h.
6821         * psymtab.h (struct psymbol_bcache): Don't declare.
6822         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6823         (psymbol_bcache_init, psymbol_bcache_free)
6824         (psymbol_bcache_get_bcache): Don't declare.
6825         * psymtab.c (struct psymbol_bcache): Remove.
6826         (psymtab_storage::psymtab_storage): Update.
6827         (psymtab_storage::~psymtab_storage): Update.
6828         (psymbol_bcache_init, psymbol_bcache_free)
6829         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6830         (add_psymbol_to_bcache): Update.
6831         (allocate_psymtab): Update.
6832         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6833         macro_cache>: No longer pointers.
6834         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6835         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6836         * macrotab.c (macro_bcache): Update.
6837         * macroexp.c: Don't include bcache.h.
6838         * gdbtypes.c (check_types_worklist): Update.
6839         (types_deeply_equal): Remove TRY/CATCH.  Update.
6840         * elfread.c (elf_symtab_read): Update.
6841         * dwarf2read.c: Don't include bcache.h.
6842         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6843         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6844         (print_bcache_statistics, bcache_memory_used): Don't declare.
6845         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6846         methods.  Rename all data members.
6847         * bcache.c (struct bcache): Move to bcache.h.
6848         (bcache::expand_hash_table): Rename from expand_hash_table.
6849         (bcache): Remove.
6850         (bcache::insert): Rename from bcache_full.
6851         (bcache::compare): Rename from bcache_compare.
6852         (bcache_xmalloc): Remove.
6853         (bcache::~bcache): Rename from bcache_xfree.
6854         (bcache::print_statistics): Rename from print_bcache_statistics.
6855         (bcache::memory_used): Rename from bcache_memory_used.
6856
6857 2019-03-07  Pedro Alves  <palves@redhat.com>
6858
6859         * infrun.c (normal_stop): Also check for
6860         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6861
6862 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6863
6864         * f-lang.c (value_from_host_double): Moved to...
6865         * value.c (value_from_host_double): ...here.
6866         * value.h (value_from_host_double): Declare.
6867         * guile/scm-math.c (vlscm_convert_typed_number): Use
6868         value_from_host_double.
6869         (vlscm_convert_number): Likewise.
6870         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6871         * python/py-value.c (convert_value_from_python): Likewise.
6872
6873 2019-03-06  Tom Tromey  <tom@tromey.com>
6874
6875         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6876
6877 2019-03-06  Tom Tromey  <tom@tromey.com>
6878
6879         * utils.h (free_current_contents): Don't declare.
6880         * utils.c (free_current_contents): Remove.
6881
6882 2019-03-06  Tom Tromey  <tom@tromey.com>
6883
6884         * top.c (quit_force): Update.
6885         * main.c (captured_command_loop): Update.
6886         * common/new-op.c (operator new): Update.
6887         * common/common-exceptions.c (struct catcher)
6888         <save_cleanup_chain>: Remove member.
6889         (exceptions_state_mc_init): Update.
6890         (exception_try_scope_entry): Return nullptr.
6891         (exception_try_scope_exit, exception_rethrow)
6892         (throw_exception_sjlj, throw_exception_cxx): Update.
6893         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6894         (all_cleanups, do_cleanups, discard_cleanups)
6895         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6896         (restore_cleanups, restore_final_cleanups): Don't declare.
6897         (do_final_cleanups): Remove parameter.
6898         * common/cleanups.c (cleanup_chain, make_cleanup)
6899         (make_cleanup_dtor, all_cleanups, do_cleanups)
6900         (discard_my_cleanups, discard_cleanups)
6901         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6902         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6903         (null_cleanup): Remove.
6904         (do_final_cleanups): Remove parameter.
6905
6906 2019-03-06  Tom Tromey  <tom@tromey.com>
6907
6908         * remote.c (remote_target::remote_parse_stop_reply): Use
6909         unique_xmalloc_ptr.
6910
6911 2019-03-06  Tom Tromey  <tom@tromey.com>
6912
6913         * stabsread.c (struct stabs_field_info): Rename from field_info.
6914         <list, fnlist>: Add initializers.
6915         <obstack>: New member.
6916         (read_member_functions, read_struct_fields, read_baseclasses):
6917         Allocate on obstack.  Don't use cleanups.
6918         (read_one_struct_field, read_member_functions, read_struct_fields)
6919         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6920         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6921         (read_struct_type): Update.
6922
6923 2019-03-06  Tom Tromey  <tom@tromey.com>
6924
6925         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6926         * common/filestuff.h (make_cleanup_close): Don't declare.
6927         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6928         Remove.
6929
6930 2019-03-06  Tom Tromey  <tom@tromey.com>
6931
6932         * solib-aix.c: Use make_scope_exit.
6933
6934 2019-03-06  Tom Tromey  <tom@tromey.com>
6935
6936         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6937         Use make_scope_exit.
6938
6939 2019-03-06  Tom Tromey  <tom@tromey.com>
6940
6941         * solib-svr4.c (disable_probes_interface): Remove parameter.
6942         (svr4_handle_solib_event): Use make_scope_exit.
6943
6944 2019-03-06  Tom Tromey  <tom@tromey.com>
6945
6946         * remote.c (struct stop_reply_deleter): Remove.
6947         (stop_reply_up): Update.
6948         (struct stop_reply): Derive from notif_event.  Don't typedef.
6949         <regcache>: Now a std::vector.
6950         (stop_reply_xfree): Remove.
6951         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6952         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6953         (remote_target::discard_pending_stop_replies): Use delete.
6954         (remote_target::remote_parse_stop_reply): Update.
6955         (remote_target::process_stop_reply): Update.
6956         * remote-notif.h (struct notif_event): Add virtual destructor.
6957         Remove "dtr" member.
6958         (struct notif_client) <alloc_event>: Return a unique_ptr.
6959         (notif_event_xfree): Don't declare.
6960         (notif_event_up): New typedef.
6961         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6962         (notif_event_xfree, do_notif_event_xfree): Remove.
6963         (remote_notif_state_xfree): Update.
6964
6965 2019-03-06  Tom Tromey  <tom@tromey.com>
6966
6967         * infrun.c (displaced_step_clear_cleanup): Now a
6968         forward_scope_exit type.
6969         (displaced_step_prepare_throw): Update.
6970         (displaced_step_fixup): Update.
6971
6972 2019-03-06  Tom Tromey  <tom@tromey.com>
6973
6974         * inferior.h (class inferior): Update comment.
6975         * gdbthread.h (class thread_info): Update comment.
6976
6977 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6978             Tom Tromey  <tom@tromey.com>
6979
6980         * stabsread.h (struct stab_section_list): Remove.
6981         (coffstab_build_psymtabs): Update.
6982         * dbxread.c (symbuf_sections): Now a std::vector.
6983         (sect_idx): New global.
6984         (fill_symbuf): Update.
6985         (coffstab_build_psymtabs): Change type of stabsects parameter.
6986         Update.
6987         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6988         std::vector.
6989         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6990         (coff_locate_sections): Update.
6991         (coff_symfile_read): Remove cleanups.  Update.
6992         (init_stringtab): Add storage parameter.
6993         (free_stringtab, free_stringtab_cleanup): Remove.
6994         (init_lineno): Add storage parameter.
6995         (free_linetab, free_linetab_cleanup): Remove.
6996
6997 2019-03-06  Pedro Alves  <palves@redhat.com>
6998
6999         * linux-fork.c (fork_info::clobber_regs): Delete.
7000         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7001         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7002         comment.  Adjust.
7003         (scoped_switch_fork_info::scoped_switch_fork_info)
7004         (checkpoint_command, linux_fork_context): Adjust
7005         fork_save_infrun_state calls.
7006
7007 2019-03-06  Pedro Alves  <palves@redhat.com>
7008
7009         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7010         (inf_has_multiple_threads): Return 'bool' and rewrite using
7011         inferior_info::threads().
7012
7013 2019-03-06  Pedro Alves  <palves@redhat.com>
7014
7015         * linux-fork.c: Include <list>.
7016         (fork_list): Now a std::list instance.
7017         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7018         (forks_exist_p, find_last_fork): Adjust.
7019         (new_fork): Delete.
7020         (one_fork_p): New.
7021         (add_fork): Adjust.
7022         (free_fork): Delete, folded into fork_info::~fork_info().
7023         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7024         Adjust.
7025         (init_fork_list): Delete.
7026         (linux_fork_killall, linux_fork_mourn_inferior)
7027         (linux_fork_detach, info_checkpoints_command): Adjust.
7028         (_initialize_linux_fork): No longer call init_fork_list.
7029
7030 2019-03-06  Pedro Alves  <palves@redhat.com>
7031
7032         * linux-fork.c (new_fork): New, split out of ...
7033         (add_fork): ... this.  Return void.  Move "first fork" special
7034         case from here, to ...
7035         (checkpoint_command): ... here.
7036         * linux-linux.h (add_fork): Return void.
7037
7038 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7039
7040         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7041
7042 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7043             Chris January  <chris.january@arm.com>
7044             David Lecomber  <david.lecomber@arm.com>
7045
7046         * f-exp.y: New token, UNOP_INTRINSIC.
7047         (exp): New pattern using UNOP_INTRINSIC token.
7048         (f77_keywords): Add 'abs' keyword.
7049         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7050         (value_from_host_double): New function.
7051         (evaluate_subexp_f): Support UNOP_ABS.
7052
7053 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7054
7055         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7056         types.
7057
7058 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7059
7060         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7061         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7062         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7063
7064 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7067
7068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7069             Chris January  <chris.january@arm.com>
7070
7071         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7072         * f-exp.y: Define 'KIND' token.
7073         (exp): New pattern for KIND expressions.
7074         (ptype): Handle types with a kind extension.
7075         (direct_abs_decl): Extend to spot kind extensions.
7076         (f77_keywords): Add 'kind' to the list.
7077         (push_kind_type): New function.
7078         (convert_to_kind_type): New function.
7079         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7080         * parse.c (operator_length_standard): Likewise.
7081         * parser-defs.h (enum type_pieces): Add tp_kind.
7082         * std-operator.def: Add UNOP_KIND.
7083
7084 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7085
7086         * f-exp.y (f_parse): Set yydebug.
7087
7088 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7089
7090         * f-lang.c (evaluate_subexp_f): New function.
7091         (exp_descriptor_f): New global.
7092         (f_language_defn): Use exp_descriptor_f instead of
7093         exp_descriptor_standard.
7094
7095 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7096
7097         * f-exp.y (struct token): Add comments.
7098         (dot_ops): Remove uppercase versions and the end marker.
7099         (f77_keywords): Likewise.
7100         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7101         entries in the dot_ops array are case insensitive, and use
7102         strncasecmp to compare strings.  Also some whitespace cleanup in
7103         this area.  Similar for the f77_keywords array, except entries in
7104         this list might be case sensitive.
7105
7106 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7107
7108         * f-exp.y (struct f77_boolean_val): Add comments.
7109         (boolean_values): Remove uppercase versions, and end marker.
7110         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7111         and use strncasecmp to achieve case insensitivity.  Additionally,
7112         perform whitespace cleanup around this code.
7113
7114 2019-03-06  Tom Tromey  <tromey@adacore.com>
7115
7116         * remote-sim.c (gdbsim_target_open): Use result of
7117         gdb_argv::release.
7118
7119 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7120         Dirk Schubert  <dirk.schubert@arm.com>
7121         Chris January  <chris.january@arm.com>
7122
7123         * eval.c (evaluate_subexp_standard): Call Fortran argument
7124         wrapping logic.
7125         * f-lang.c (struct value): A value which can be passed into a
7126         Fortran function call.
7127         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7128         where appropriate.
7129         (struct type): Value ready for a Fortran function call.
7130         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7131         is needed.
7132         * f-lang.h (fortran_argument_convert): Declaration.
7133         (fortran_preserve_arg_pointer): Declaration.
7134         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7135
7136 2019-03-05  Tom Tromey  <tromey@adacore.com>
7137
7138         * python/py-prettyprint.c (print_string_repr): Remove #if.
7139         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7140
7141 2019-03-05  Tom Tromey  <tromey@adacore.com>
7142
7143         * target.c (the_dummy_target): Move later.  Change type to
7144         "dummy_target".
7145         (initialize_targets): Don't initialize the_dummy_target.
7146
7147 2019-03-05  Tom Tromey  <tromey@adacore.com>
7148
7149         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7150         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7151
7152 2019-03-05  Tom Tromey  <tromey@adacore.com>
7153
7154         * windows-nat.c (windows_nat_target::attach)
7155         (windows_nat_target::detach): Don't call gdb_flush.
7156         * valprint.c (generic_val_print, val_print, val_print_string):
7157         Don't call gdb_flush.
7158         * utils.c (defaulted_query): Don't call gdb_flush.
7159         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7160         * target.c (target_announce_detach): Don't call gdb_flush.
7161         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7162         * remote.c (extended_remote_target::attach): Don't call
7163         gdb_flush.
7164         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7165         * printcmd.c (do_examine): Don't call gdb_flush.
7166         (info_display_command): Don't call gdb_flush.
7167         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7168         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7169         * memattr.c (info_mem_command): Don't call gdb_flush.
7170         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7171         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7172         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7173         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7174         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7175         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7176         (gnu_nat_target::detach): Don't call gdb_flush.
7177         * f-valprint.c (f_val_print): Don't call gdb_flush.
7178         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7179         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7180         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7181         gdb_flush.
7182         * c-valprint.c (c_val_print): Don't call gdb_flush.
7183         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7184
7185 2019-03-05  Tom Tromey  <tromey@adacore.com>
7186
7187         * varobj.c (update_dynamic_varobj_children): Update.
7188         (install_default_visualizer): Use reset, not release.
7189         * value.c (set_internalvar): Update.
7190         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7191         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7192         ATTRIBUTE_UNUSED_RESULT.
7193
7194 2019-03-05  Tom Tromey  <tromey@adacore.com>
7195
7196         * remote.c (class scoped_remote_fd) <release>: Add
7197         ATTRIBUTE_UNUSED_RESULT.
7198
7199 2019-03-05  Tom Tromey  <tromey@adacore.com>
7200
7201         * macroexp.c (struct macro_buffer) <release>: Add
7202         ATTRIBUTE_UNUSED_RESULT.
7203
7204 2019-03-05  Tom Tromey  <tromey@adacore.com>
7205
7206         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7207         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7208         ATTRIBUTE_UNUSED_RESULT.
7209
7210 2019-03-05  Tom Tromey  <tromey@adacore.com>
7211
7212         * common/scoped_fd.h (class scoped_fd) <release>: Add
7213         ATTRIBUTE_UNUSED_RESULT.
7214
7215 2019-03-05  Tom Tromey  <tromey@adacore.com>
7216
7217         * parser-defs.h (struct parser_state) <release>: Add
7218         ATTRIBUTE_UNUSED_RESULT.
7219
7220 2019-03-05  Tom Tromey  <tromey@adacore.com>
7221
7222         * utils.h (class gdb_argv) <release>: Add
7223         ATTRIBUTE_UNUSED_RESULT.
7224         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7225
7226 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7227
7228         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7229         for-loop range, to avoid compiler warnings.
7230
7231         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7232         avoid compiler warnings about unused variables.
7233
7234         * NEWS: Mention end of support for native debugging on MS-Windows
7235         before XP.
7236
7237         PR gdb/24292
7238         * common/netstuff.c:
7239         * gdbserver/gdbreplay.c
7240         * gdbserver/remote-utils.c:
7241         * ser-tcp.c:
7242         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7243         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7244         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7245         'getaddrinfo' and 'freeaddrinfo' were not available before
7246         Windows XP, and mingw.org's MinGW headers by default define
7247         _WIN32_WINNT to 0x500.
7248
7249 2019-03-01  Gary Benson <gbenson@redhat.com>
7250
7251         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7252
7253 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7254             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7255
7256         PR gdb/8527
7257         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7258         set_sigint_trap, clear_sigint_trap.
7259
7260 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7261
7262         * target.c (target_detach): Clear the regcache and the
7263         frame cache.
7264
7265 2019-02-27  Pedro Alves  <palves@redhat.com>
7266
7267         * utils.c (set_screen_size): When we cap the height/width sizes,
7268         tweak the corresponding command variable to show "unlimited":
7269
7270 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7271             Pedro Alves  <palves@redhat.com>
7272
7273         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7274         before calling rl_set_screen_size.
7275
7276 2019-02-27  Tom Tromey  <tromey@adacore.com>
7277
7278         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7279         define.
7280         * python/py-value.c: Remove Python 2.4 workaround.
7281         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7282         workaround.
7283         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7284         Python 2.4 workaround.
7285         * python/python-internal.h: Remove Python 2.4 comment.
7286         (Py_ssize_t): Don't define.
7287         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7288         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7289         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7290         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7291         * python/python.c (do_start_initialization): Remove Python 2.4
7292         workaround.
7293         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7294         (print_children): Remove Python 2.4 workaround.
7295         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7296         workaround.
7297         (CHARBUFFERPROC_NAME): Remove.
7298         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7299         Python 2.4 workaround.
7300
7301 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7302
7303         * NEWS: Note minimum Python version.
7304
7305 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7306
7307         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7308         code from these functions.  Remove corresponding ifdefs.  Use
7309         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7310         Remove gotos and target of gotos.
7311         (infpy_search_memory): Likewise.
7312
7313 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7314
7315         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7316         (hppa_gdbarch_init): Don't register deleted functions with
7317         gdbarch.
7318
7319 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7320
7321         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7322         (h8300_unwind_sp): Delete.
7323         (h8300_dummy_id): Delete.
7324         (h8300_gdbarch_init): Don't register deleted functions with
7325         gdbarch.
7326
7327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7328
7329         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7330         (ft32_unwind_pc): Delete.
7331         (ft32_unwind_sp): Delete.
7332         (ft32_gdbarch_init): Don't register deleted functions with
7333         gdbarch.
7334
7335 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7336
7337         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7338         (frv_unwind_pc): Delete.
7339         (frv_unwind_sp): Delete.
7340         (frv_gdbarch_init): Don't register deleted functions with
7341         gdbarch.
7342
7343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7344
7345         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7346         (riscv_unwind_pc): Delete.
7347         (riscv_unwind_sp): Delete.
7348         (riscv_gdbarch_init): Don't register deleted functions with
7349         gdbarch.
7350
7351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7352
7353         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7354         (csky_unwind_pc): Delete.
7355         (csky_unwind_sp): Delete.
7356         (csky_gdbarch_init): Don't register deleted functions with
7357         gdbarch.
7358
7359 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7360
7361         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7362         (cris_unwind_pc): Delete.
7363         (cris_unwind_sp): Delete.
7364         (cris_gdbarch_init): Don't register deleted functions with
7365         gdbarch.
7366
7367 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7368
7369         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7370         (bfin_unwind_pc): Delete.
7371         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7372
7373 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7374
7375         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7376         (arm_unwind_pc): Delete.
7377         (arm_unwind_sp): Delete.
7378         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7379
7380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7381
7382         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7383         (arc_unwind_pc): Delete.
7384         (arc_unwind_sp): Delete.
7385         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7386
7387 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7388
7389         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7390         (alpha_unwind_pc): Delete.
7391         (alpha_gdbarch_init): Don't register deleted functions with
7392         gdbarch.
7393
7394 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7395
7396         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7397         (aarch64_unwind_pc): Delete.
7398         (aarch64_unwind_sp): Delete.
7399         (aarch64_gdbarch_init): Don't register deleted functions with
7400         gdbarch.
7401
7402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7403
7404         * gdbtypes.c (type_align): Don't consider static members when
7405         computing structure alignment.
7406
7407 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7408
7409         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7410         return 0 for other types.
7411         * arch-utils.c (default_type_align): Always return 0.
7412         * gdbarch.h: Regenerate.
7413         * gdbarch.sh (type_align): Extend comment.
7414         * gdbtypes.c (type_align): Add additional comments, always call
7415         gdbarch_type_align before applying the default rules.
7416         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7417         generic code will then apply a suitable default.
7418         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7419         types, return 0 for other types.
7420
7421 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7422
7423         * NEWS: Create a new section for the next release branch.
7424         Rename the section of the current branch, now that it has
7425         been cut.
7426
7427 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7428
7429         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7430         * version.in: Bump version to 8.3.50.DATE-git.
7431
7432 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7433
7434         * aix-thread.c (ptid_cmp): Remove unused variable.
7435         (get_signaled_thread): Likewise.
7436         (store_regs_user_thread): Likewise.
7437         (store_regs_kernel_thread): Likewise.
7438         (fetch_regs_kernel_thread): Remove shadowed variable.
7439
7440 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7441
7442         * features/riscv/32bit-cpu.xml: Add register numbers.
7443         * features/riscv/32bit-fpu.c: Regenerate.
7444         * features/riscv/32bit-fpu.xml: Add register numbers.
7445         * features/riscv/64bit-cpu.xml: Add register numbers.
7446         * features/riscv/64bit-fpu.c: Regenerate.
7447         * features/riscv/64bit-fpu.xml: Add register numbers.
7448
7449 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7450
7451         * NEWS: Mention two argument form of gdb.Value constructor.
7452         * python/py-value.c (convert_buffer_and_type_to_value): New
7453         function.
7454         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7455         Add support for handling an optional second argument.  Call
7456         convert_buffer_and_type_to_value as appropriate.
7457         * python/python-internal.h (Py_buffer_deleter): New struct.
7458         (Py_buffer_up): New typedef.
7459
7460 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7461
7462         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7463         instead of releasing ownership.
7464
7465 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7466
7467         * dwarf2read.c (open_and_init_dwp_file): Call
7468         elf_numsections instead of bfd_count_sections to initialize
7469         dwp_file->num_sections.
7470
7471 2019-02-25  Tom Tromey  <tromey@adacore.com>
7472
7473         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7474
7475 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7476
7477         * gcore.in: Add '--readnever' option when invoking GDB.
7478
7479 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7480
7481         * MAINTAINERS: Update my email address.
7482
7483 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7484
7485         * build-id.c (build_id_to_debug_bfd_1): New function.
7486         (build_id_to_debug_bfd): Look for separate debug file in
7487         sysroot.
7488
7489 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7490
7491         * gdbarch.sh: Update the copyright year range that is placed into
7492         generated files.
7493
7494 2019-02-22  Keith Seitz  <keiths@redhat.com>
7495
7496         PR symtab/23853
7497         * linespec.c (create_sals_line_offset): Search for the default
7498         symtab's filename instead of its fullname.
7499
7500 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7501
7502         * NEWS: Update style defaults.
7503
7504 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7505
7506         * main.c (captured_main_1): Disable styling in batch mode.
7507
7508 2019-02-20  Tom Tromey  <tom@tromey.com>
7509
7510         * symtab.c (symtab_symbol_info): Fix typos.
7511
7512 2019-02-20  Tom Tromey  <tromey@adacore.com>
7513
7514         * findcmd.c (_initialize_mem_search): Use upper case for
7515         metasyntactic variables.
7516
7517 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7518
7519         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7520         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7521
7522 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7523
7524         * top.h (source_file_name): Change to std::string.
7525         * top.c (source_file_name): Likewise.
7526         (command_line_input): Adjust.
7527         * cli/cli-script.c (script_from_file): Adjust.
7528
7529 2019-02-19  Tom Tromey  <tromey@adacore.com>
7530
7531         * ravenscar-thread.c
7532         (ravenscar_thread_target::update_thread_list): Don't call
7533         ada_build_task_list.
7534         * ada-lang.h (ada_build_task_list): Don't declare.
7535         * ada-tasks.c (struct ada_tasks_inferior_data)
7536         <task_list_valid_p>: Now bool.
7537         (read_known_tasks, ada_task_list_changed)
7538         (ada_tasks_invalidate_inferior_data): Update.
7539         (read_known_tasks_array): Return bool.
7540         (read_known_tasks_list): Likewise.
7541         (read_known_tasks): Return void.
7542         (ada_build_task_list): Now static.
7543
7544 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7547         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7548
7549 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7550
7551         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7552         variant for ada_tasks_pspace_data_handle and
7553         ada_tasks_inferior_data_handle.
7554         (ada_tasks_pspace_data_cleanup): New function.
7555         (ada_tasks_inferior_data_cleanup): New function.
7556
7557 2019-02-17  Tom Tromey  <tom@tromey.com>
7558
7559         * macrotab.h (macro_source_fullname): Return a std::string.
7560         * macrotab.c (macro_include, check_for_redefinition)
7561         (macro_undef, macro_lookup_definition, foreach_macro)
7562         (foreach_macro_in_scope): Update.
7563         (macro_source_fullname): Return a std::string.
7564         * macrocmd.c (show_pp_source_pos): Update.
7565
7566 2019-02-17  Tom Tromey  <tom@tromey.com>
7567
7568         * macrocmd.c (show_pp_source_pos): Style the file names.
7569
7570 2019-02-17  Tom Tromey  <tom@tromey.com>
7571
7572         PR tui/24197:
7573         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7574
7575 2019-02-17  Tom Tromey  <tom@tromey.com>
7576
7577         * ada-lang.c (user_select_syms): Use filtered printing.
7578         * utils.c (wrap_style): New global.
7579         (desired_style): Remove.
7580         (emit_style_escape): Add stream parameter.
7581         (set_output_style, reset_terminal_style, prompt_for_continue):
7582         Update.
7583         (flush_wrap_buffer): Only flush gdb_stdout.
7584         (wrap_here): Set wrap_style.
7585         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7586         treat escape sequences as a character.  Change when wrap buffer is
7587         flushed.
7588         (fputs_styled): Do not set the output style when the default is
7589         requested.
7590         * ui-style.h (struct ui_file_style) <is_default>: New method.
7591         * source.c (print_source_lines_base): Emit escape sequences in one
7592         piece.
7593
7594 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7595
7596         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7597         integers and enumeration types.
7598
7599 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7600
7601         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7602         instead of lookup_symbol_in_language
7603         (do_exact_match): New function.
7604         (ada_get_symbol_name_matcher): Return do_exact_match when
7605         doing a verbatim match.
7606
7607 2019-02-15  Tom Tromey  <tromey@adacore.com>
7608
7609         * ravenscar-thread.c (ravenscar_thread_target::resume)
7610         (ravenscar_thread_target::wait): Special case wildcard requests.
7611
7612 2019-02-15  Tom Tromey  <tromey@adacore.com>
7613
7614         * ravenscar-thread.c (base_ptid): Remove.
7615         (struct ravenscar_thread_target) <close>: New method.
7616         <m_base_ptid>: New member.
7617         <update_inferior_ptid, active_task, task_is_currently_active,
7618         runtime_initialized>: Declare methods.
7619         <ravenscar_thread_target>: Add constructor.
7620         (ravenscar_thread_target::task_is_currently_active)
7621         (ravenscar_thread_target::update_inferior_ptid)
7622         (ravenscar_runtime_initialized): Rename.  Now methods.
7623         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7624         (ravenscar_thread_target::update_thread_list): Update.
7625         (ravenscar_thread_target::active_task): Now method.
7626         (ravenscar_thread_target::store_registers)
7627         (ravenscar_thread_target::prepare_to_store)
7628         (ravenscar_thread_target::prepare_to_store)
7629         (ravenscar_thread_target::mourn_inferior): Update.
7630         (ravenscar_inferior_created): Use "new" to create target.
7631         (ravenscar_thread_target::get_ada_task_ptid): Update.
7632         (_initialize_ravenscar): Don't initialize base_ptid.
7633         (ravenscar_ops): Remove global.
7634
7635 2019-02-15  Tom Tromey  <tromey@adacore.com>
7636
7637         * target.h (push_target): Declare new overload.
7638         * target.c (push_target): New overload, taking an rvalue reference.
7639         * remote.c (remote_target::open_1): Use push_target overload.
7640         * corelow.c (core_target_open): Use push_target overload.
7641
7642 2019-02-15  Tom Tromey  <tromey@adacore.com>
7643
7644         * ravenscar-thread.c (is_ravenscar_task)
7645         (ravenscar_task_is_currently_active): Return bool.
7646         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7647         (_initialize_ravenscar): Remove "(void)".
7648         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7649         Return bool.
7650
7651 2019-02-15  Tom Tromey  <tromey@adacore.com>
7652
7653         * ravenscar-thread.c (ravenscar_runtime_initializer)
7654         (has_ravenscar_runtime, get_running_thread_id)
7655         (ravenscar_thread_target::resume): Fix indentation.
7656
7657 2019-02-15  Tom Tromey  <tromey@adacore.com>
7658
7659         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7660         from ravenscar_arch_ops.
7661         (sparc_ravenscar_ops::fetch_registers)
7662         (sparc_ravenscar_ops::store_registers): Now methods.
7663         (sparc_ravenscar_prepare_to_store): Remove.
7664         (sparc_ravenscar_ops): Redefine.
7665         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7666         methods and destructor.  Remove members.
7667         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7668         (ravenscar_thread_target::store_registers)
7669         (ravenscar_thread_target::prepare_to_store): Update.
7670         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7671         Remove.
7672         (struct ppc_ravenscar_powerpc_ops): Derive from
7673         ravenscar_arch_ops.
7674         (ppc_ravenscar_powerpc_ops::fetch_registers)
7675         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7676         (ppc_ravenscar_powerpc_ops): Redefine.
7677         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7678         (ppc_ravenscar_e500_ops::fetch_registers)
7679         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7680         (ppc_ravenscar_e500_ops): Redefine.
7681         * aarch64-ravenscar-thread.c
7682         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7683         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7684         (aarch64_ravenscar_fetch_registers)
7685         (aarch64_ravenscar_store_registers): Now methods.
7686         (aarch64_ravenscar_ops): Redefine.
7687
7688 2019-02-15  Tom Tromey  <tromey@adacore.com>
7689
7690         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7691         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7692         (ravenscar_thread_target::stopped_by_watchpoint)
7693         (ravenscar_thread_target::stopped_data_address)
7694         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7695
7696 2019-02-15  Tom Tromey  <tromey@adacore.com>
7697
7698         * ravenscar-thread.c: Fix some typos.
7699
7700 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7701             Tom Tromey  <tromey@adacore.com>
7702
7703         * ada-lang.c (ada_exception_sal): Change addr_string to a
7704         std::string.
7705         (create_ada_exception_catchpoint): Update.
7706
7707 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7708             Tom Tromey  <tromey@adacore.com>
7709
7710         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7711         (bp_location_ops): Remove.
7712         (base_breakpoint_allocate_location): Update.
7713         (free_bp_location): Update.
7714         * ada-lang.c (class ada_catchpoint_location)
7715         <ada_catchpoint_location>: Remove ops parameter.
7716         (ada_catchpoint_location_dtor): Remove.
7717         (ada_catchpoint_location_ops): Remove.
7718         (allocate_location_exception): Update.
7719         * breakpoint.h (struct bp_location_ops): Remove.
7720         (class bp_location) <bp_location>: Remove bp_location_ops
7721         parameter.
7722         <~bp_location>: Add destructor.
7723         <ops>: Remove.
7724
7725 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7726             Pedro Alves  <palves@redhat.com>
7727
7728         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7729         'PATH_MAX'.
7730
7731 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7732             Samuel Thibault  <samuel.thibault@gnu.org>
7733             Thomas Schwinge  <thomas@codesourcery.com>
7734
7735         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7736         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7737
7738 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7739
7740         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7741         (check_empty): Use "const char *".
7742
7743         * gnu-nat.c (gnu_nat_target::detach): Instead of
7744         'detach_inferior (pid)' call
7745         'detach_inferior (find_inferior_pid (pid))'.
7746
7747         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7748         'nat/fork-inferior.o'.
7749         * gnu-nat.c: #include "nat/fork-inferior.h".
7750
7751         * gnu-nat.c (gnu_nat_target::detach): Instead of
7752         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7753         * gnu-nat.h: #include "inf-child.h".
7754         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7755         'i386_gnu_nat_target::fetch_registers'.
7756         (gnu_store_registers): Rename/move to
7757         'i386_gnu_nat_target::store_registers'.
7758
7759         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7760         * gnu-nat.h (mach_thread_info): New function.
7761         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7762
7763         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7764
7765 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7766
7767         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7768
7769 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7770
7771         * windows-nat.c (windows_add_thread): Add new parameter
7772         "main_thread_p" with default value set to false.  Update
7773         function documentation as well as all callers.
7774         (windows_delete_thread): Likewise.
7775         (fake_create_process): Update call to windows_add_thread.
7776         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7777         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7778         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7779         call to windows_delete_thread.
7780
7781 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7782
7783         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7784
7785 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7786
7787         * symfile.c (find_separate_debug_file): Use canonical path of
7788         sysroot with child_path instead of gdb_sysroot if it is valid.
7789
7790 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7791
7792         * symfile.c (find_separate_debug_file): Use child_path to
7793         determine if an object file is under a sysroot.
7794
7795 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7796
7797         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7798         unittests/child-path-selftests.c.
7799         * common/pathstuff.c (child_path): New function.
7800         * common/pathstuff.h (child_path): New prototype.
7801         * unittests/child-path-selftests.c: New file.
7802
7803 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7804
7805         * symfile.c (find_separate_debug_file): Look for separate debug
7806         files in debug directories under the sysroot.
7807
7808 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7809
7810         * symtab.h (struct minimal_symbol data_p): New const method.
7811         (struct minimal_symbol text_p): Likewise.
7812         * symtab.c (output_source_filename): Use file name style
7813         to print file name.
7814         (print_symbol_info): Likewise.
7815         (print_msymbol_info): Use address style to print addresses.
7816         Use function name style to print executable text symbols.
7817         (expand_symtab_containing_pc): Use data_p.
7818         (find_pc_sect_compunit_symtab): Likewise.
7819
7820 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7821
7822         * breakpoint.c (describe_other_breakpoints): Use address style
7823         to print addresses.
7824         (say_where): Likewise.
7825
7826 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7827
7828         * ada-typeprint.c (print_func_type): Print function name
7829         style to print function name.
7830         * c-typeprint.c (c_print_type_1): Likewise.
7831
7832 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7833
7834         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7835         for execve.
7836
7837 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7838
7839         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7840         type_stack.
7841
7842 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7843
7844         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7845         TYPE_CODE_REF types.
7846
7847 2019-02-08  Jim Wilson  <jimw@sifive.com>
7848
7849         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7850         (riscv_linux_fregset): New.
7851         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7852
7853 2019-02-07  Tom Tromey  <tom@tromey.com>
7854
7855         * thread.c (thread_cancel_execution_command): Update.
7856         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7857         methods.
7858         (struct thread_fsm_ops): Remove.
7859         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7860         (thread_fsm_should_stop, thread_fsm_return_value)
7861         (thread_fsm_set_finished, thread_fsm_finished_p)
7862         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7863         Don't declare.
7864         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7865         * infrun.c (clear_proceed_status_thread)
7866         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7867         (print_stop_event): Update.
7868         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7869         Add constructor.
7870         (step_command_fsm_ops): Remove.
7871         (new_step_command_fsm): Remove.
7872         (step_1): Update.
7873         (step_command_fsm::should_stop): Rename from
7874         step_command_fsm_should_stop.
7875         (step_command_fsm::clean_up): Rename from
7876         step_command_fsm_clean_up.
7877         (step_command_fsm::do_async_reply_reason): Rename from
7878         step_command_fsm_async_reply_reason.
7879         (struct until_next_fsm): Inherit from thread_fsm.  Add
7880         constructor.
7881         (until_next_fsm_ops): Remove.
7882         (new_until_next_fsm): Remove.
7883         (until_next_fsm::should_stop): Rename from
7884         until_next_fsm_should_stop.
7885         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7886         (until_next_fsm::do_async_reply_reason): Rename from
7887         until_next_fsm_async_reply_reason.
7888         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7889         constructor.  Change type of breakpoint.
7890         (finish_command_fsm_ops): Remove.
7891         (new_finish_command_fsm): Remove.
7892         (finish_command_fsm::should_stop): Rename from
7893         finish_command_fsm_should_stop.
7894         (finish_command_fsm::clean_up): Rename from
7895         finish_command_fsm_clean_up.
7896         (finish_command_fsm::return_value): Rename from
7897         finish_command_fsm_return_value.
7898         (finish_command_fsm::do_async_reply_reason): Rename from
7899         finish_command_fsm_async_reply_reason.
7900         (finish_command): Update.
7901         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7902         Add constructor.
7903         (call_thread_fsm_ops): Remove.
7904         (call_thread_fsm::call_thread_fsm): Rename from
7905         new_call_thread_fsm.
7906         (call_thread_fsm::should_stop): Rename from
7907         call_thread_fsm_should_stop.
7908         (call_thread_fsm::should_notify_stop): Rename from
7909         call_thread_fsm_should_notify_stop.
7910         (run_inferior_call, call_function_by_hand_dummy): Update.
7911         * cli/cli-interp.c (should_print_stop_to_console): Update.
7912         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7913         Add constructor.  Change type of location_breakpoint,
7914         caller_breakpoint.
7915         (until_break_fsm_ops): Remove.
7916         (new_until_break_fsm): Remove.
7917         (until_break_fsm::should_stop): Rename from
7918         until_break_fsm_should_stop.
7919         (until_break_fsm::clean_up): Rename from
7920         until_break_fsm_clean_up.
7921         (until_break_fsm::do_async_reply_reason): Rename from
7922         until_break_fsm_async_reply_reason.
7923         (until_break_command): Update.
7924         * thread-fsm.c: Remove.
7925         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7926
7927 2019-02-07  Tom Tromey  <tom@tromey.com>
7928
7929         * yy-remap.h: Add include guard.
7930         * xtensa-tdep.h: Add include guard.
7931         * xcoffread.h: Rename include guard.
7932         * varobj-iter.h: Add include guard.
7933         * tui/tui.h: Rename include guard.
7934         * tui/tui-winsource.h: Rename include guard.
7935         * tui/tui-wingeneral.h: Rename include guard.
7936         * tui/tui-windata.h: Rename include guard.
7937         * tui/tui-win.h: Rename include guard.
7938         * tui/tui-stack.h: Rename include guard.
7939         * tui/tui-source.h: Rename include guard.
7940         * tui/tui-regs.h: Rename include guard.
7941         * tui/tui-out.h: Rename include guard.
7942         * tui/tui-layout.h: Rename include guard.
7943         * tui/tui-io.h: Rename include guard.
7944         * tui/tui-hooks.h: Rename include guard.
7945         * tui/tui-file.h: Rename include guard.
7946         * tui/tui-disasm.h: Rename include guard.
7947         * tui/tui-data.h: Rename include guard.
7948         * tui/tui-command.h: Rename include guard.
7949         * tic6x-tdep.h: Add include guard.
7950         * target/waitstatus.h: Rename include guard.
7951         * target/wait.h: Rename include guard.
7952         * target/target.h: Rename include guard.
7953         * target/resume.h: Rename include guard.
7954         * target-float.h: Rename include guard.
7955         * stabsread.h: Add include guard.
7956         * rs6000-tdep.h: Add include guard.
7957         * riscv-fbsd-tdep.h: Add include guard.
7958         * regformats/regdef.h: Rename include guard.
7959         * record.h: Rename include guard.
7960         * python/python.h: Rename include guard.
7961         * python/python-internal.h: Rename include guard.
7962         * python/py-stopevent.h: Rename include guard.
7963         * python/py-ref.h: Rename include guard.
7964         * python/py-record.h: Rename include guard.
7965         * python/py-record-full.h: Rename include guard.
7966         * python/py-record-btrace.h: Rename include guard.
7967         * python/py-instruction.h: Rename include guard.
7968         * python/py-events.h: Rename include guard.
7969         * python/py-event.h: Rename include guard.
7970         * procfs.h: Add include guard.
7971         * proc-utils.h: Add include guard.
7972         * p-lang.h: Add include guard.
7973         * or1k-tdep.h: Rename include guard.
7974         * observable.h: Rename include guard.
7975         * nto-tdep.h: Rename include guard.
7976         * nat/x86-linux.h: Rename include guard.
7977         * nat/x86-linux-dregs.h: Rename include guard.
7978         * nat/x86-gcc-cpuid.h: Add include guard.
7979         * nat/x86-dregs.h: Rename include guard.
7980         * nat/x86-cpuid.h: Rename include guard.
7981         * nat/ppc-linux.h: Rename include guard.
7982         * nat/mips-linux-watch.h: Rename include guard.
7983         * nat/linux-waitpid.h: Rename include guard.
7984         * nat/linux-ptrace.h: Rename include guard.
7985         * nat/linux-procfs.h: Rename include guard.
7986         * nat/linux-osdata.h: Rename include guard.
7987         * nat/linux-nat.h: Rename include guard.
7988         * nat/linux-namespaces.h: Rename include guard.
7989         * nat/linux-btrace.h: Rename include guard.
7990         * nat/glibc_thread_db.h: Rename include guard.
7991         * nat/gdb_thread_db.h: Rename include guard.
7992         * nat/gdb_ptrace.h: Rename include guard.
7993         * nat/fork-inferior.h: Rename include guard.
7994         * nat/amd64-linux-siginfo.h: Rename include guard.
7995         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7996         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7997         * nat/aarch64-linux.h: Rename include guard.
7998         * nat/aarch64-linux-hw-point.h: Rename include guard.
7999         * mn10300-tdep.h: Add include guard.
8000         * mips-linux-tdep.h: Add include guard.
8001         * mi/mi-parse.h: Rename include guard.
8002         * mi/mi-out.h: Rename include guard.
8003         * mi/mi-main.h: Rename include guard.
8004         * mi/mi-interp.h: Rename include guard.
8005         * mi/mi-getopt.h: Rename include guard.
8006         * mi/mi-console.h: Rename include guard.
8007         * mi/mi-common.h: Rename include guard.
8008         * mi/mi-cmds.h: Rename include guard.
8009         * mi/mi-cmd-break.h: Rename include guard.
8010         * m2-lang.h: Add include guard.
8011         * location.h: Rename include guard.
8012         * linux-record.h: Rename include guard.
8013         * linux-nat.h: Add include guard.
8014         * linux-fork.h: Add include guard.
8015         * i386-darwin-tdep.h: Rename include guard.
8016         * hppa-linux-offsets.h: Add include guard.
8017         * guile/guile.h: Rename include guard.
8018         * guile/guile-internal.h: Rename include guard.
8019         * gnu-nat.h: Rename include guard.
8020         * gdb-stabs.h: Rename include guard.
8021         * frv-tdep.h: Add include guard.
8022         * f-lang.h: Add include guard.
8023         * event-loop.h: Add include guard.
8024         * darwin-nat.h: Rename include guard.
8025         * cp-abi.h: Rename include guard.
8026         * config/sparc/nm-sol2.h: Rename include guard.
8027         * config/nm-nto.h: Rename include guard.
8028         * config/nm-linux.h: Add include guard.
8029         * config/i386/nm-i386gnu.h: Rename include guard.
8030         * config/djgpp/nl_types.h: Rename include guard.
8031         * config/djgpp/langinfo.h: Rename include guard.
8032         * compile/gcc-cp-plugin.h: Add include guard.
8033         * compile/gcc-c-plugin.h: Add include guard.
8034         * compile/compile.h: Rename include guard.
8035         * compile/compile-object-run.h: Rename include guard.
8036         * compile/compile-object-load.h: Rename include guard.
8037         * compile/compile-internal.h: Rename include guard.
8038         * compile/compile-cplus.h: Rename include guard.
8039         * compile/compile-c.h: Rename include guard.
8040         * common/xml-utils.h: Rename include guard.
8041         * common/x86-xstate.h: Rename include guard.
8042         * common/version.h: Rename include guard.
8043         * common/vec.h: Rename include guard.
8044         * common/tdesc.h: Rename include guard.
8045         * common/selftest.h: Rename include guard.
8046         * common/scoped_restore.h: Rename include guard.
8047         * common/scoped_mmap.h: Rename include guard.
8048         * common/scoped_fd.h: Rename include guard.
8049         * common/safe-iterator.h: Rename include guard.
8050         * common/run-time-clock.h: Rename include guard.
8051         * common/refcounted-object.h: Rename include guard.
8052         * common/queue.h: Rename include guard.
8053         * common/ptid.h: Rename include guard.
8054         * common/print-utils.h: Rename include guard.
8055         * common/preprocessor.h: Rename include guard.
8056         * common/pathstuff.h: Rename include guard.
8057         * common/observable.h: Rename include guard.
8058         * common/netstuff.h: Rename include guard.
8059         * common/job-control.h: Rename include guard.
8060         * common/host-defs.h: Rename include guard.
8061         * common/gdb_wait.h: Rename include guard.
8062         * common/gdb_vecs.h: Rename include guard.
8063         * common/gdb_unlinker.h: Rename include guard.
8064         * common/gdb_unique_ptr.h: Rename include guard.
8065         * common/gdb_tilde_expand.h: Rename include guard.
8066         * common/gdb_sys_time.h: Rename include guard.
8067         * common/gdb_string_view.h: Rename include guard.
8068         * common/gdb_splay_tree.h: Rename include guard.
8069         * common/gdb_setjmp.h: Rename include guard.
8070         * common/gdb_ref_ptr.h: Rename include guard.
8071         * common/gdb_optional.h: Rename include guard.
8072         * common/gdb_locale.h: Rename include guard.
8073         * common/gdb_assert.h: Rename include guard.
8074         * common/filtered-iterator.h: Rename include guard.
8075         * common/filestuff.h: Rename include guard.
8076         * common/fileio.h: Rename include guard.
8077         * common/environ.h: Rename include guard.
8078         * common/common-utils.h: Rename include guard.
8079         * common/common-types.h: Rename include guard.
8080         * common/common-regcache.h: Rename include guard.
8081         * common/common-inferior.h: Rename include guard.
8082         * common/common-gdbthread.h: Rename include guard.
8083         * common/common-exceptions.h: Rename include guard.
8084         * common/common-defs.h: Rename include guard.
8085         * common/common-debug.h: Rename include guard.
8086         * common/cleanups.h: Rename include guard.
8087         * common/buffer.h: Rename include guard.
8088         * common/btrace-common.h: Rename include guard.
8089         * common/break-common.h: Rename include guard.
8090         * cli/cli-utils.h: Rename include guard.
8091         * cli/cli-style.h: Rename include guard.
8092         * cli/cli-setshow.h: Rename include guard.
8093         * cli/cli-script.h: Rename include guard.
8094         * cli/cli-interp.h: Rename include guard.
8095         * cli/cli-decode.h: Rename include guard.
8096         * cli/cli-cmds.h: Rename include guard.
8097         * charset-list.h: Add include guard.
8098         * buildsym-legacy.h: Rename include guard.
8099         * bfin-tdep.h: Add include guard.
8100         * ax.h: Rename include guard.
8101         * arm-linux-tdep.h: Add include guard.
8102         * arm-fbsd-tdep.h: Add include guard.
8103         * arch/xtensa.h: Rename include guard.
8104         * arch/tic6x.h: Add include guard.
8105         * arch/i386.h: Add include guard.
8106         * arch/arm.h: Rename include guard.
8107         * arch/arm-linux.h: Rename include guard.
8108         * arch/arm-get-next-pcs.h: Rename include guard.
8109         * arch/amd64.h: Add include guard.
8110         * arch/aarch64-insn.h: Rename include guard.
8111         * arch-utils.h: Rename include guard.
8112         * annotate.h: Add include guard.
8113         * amd64-darwin-tdep.h: Rename include guard.
8114         * aarch64-linux-tdep.h: Add include guard.
8115         * aarch64-fbsd-tdep.h: Add include guard.
8116         * aarch32-linux-nat.h: Add include guard.
8117
8118 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8119
8120         * macrotab.c (macro_define_internal): New function that
8121         factorizes macro_define_object_internal and macro_define_function
8122         code.
8123         (macro_define_object_internal): Use macro_define_internal.
8124         (macro_define_function): Likewise.
8125
8126 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8127
8128         * macrocmd.c (extract_identifier): Return
8129         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8130         callers.
8131
8132 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8133
8134         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8135
8136 2019-02-05  Tom Tromey  <tom@tromey.com>
8137
8138         * target.c (target_stack::unpush): Move assertion earlier.
8139
8140 2019-01-30  Tom Tromey  <tom@tromey.com>
8141
8142         PR python/23615:
8143         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8144         (gdbpy_parse_and_eval): Likewise.
8145         * python/python-internal.h (gdbpy_allow_threads): New class.
8146
8147 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8148
8149         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8150         (aarch64_fbsd_fpregmap): Move earlier.
8151         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8152         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8153         instead of individual calls to trad_frame_set_reg_addr.
8154         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8155         earlier.
8156         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8157         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8158         instead of individual calls to trad_frame_set_reg_addr.
8159
8160 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8161
8162         * CONTRIBUTE: Replace contribution list with wiki link.
8163
8164 2019-01-25  Tom Tromey  <tom@tromey.com>
8165
8166         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8167
8168 2019-01-25  Tom Tromey  <tom@tromey.com>
8169
8170         * xtensa-linux-nat.c: Fix common/ includes.
8171         * xml-support.h: Fix common/ includes.
8172         * xml-support.c: Fix common/ includes.
8173         * x86-linux-nat.c: Fix common/ includes.
8174         * windows-nat.c: Fix common/ includes.
8175         * varobj.h: Fix common/ includes.
8176         * varobj.c: Fix common/ includes.
8177         * value.c: Fix common/ includes.
8178         * valops.c: Fix common/ includes.
8179         * utils.c: Fix common/ includes.
8180         * unittests/xml-utils-selftests.c: Fix common/ includes.
8181         * unittests/utils-selftests.c: Fix common/ includes.
8182         * unittests/unpack-selftests.c: Fix common/ includes.
8183         * unittests/tracepoint-selftests.c: Fix common/ includes.
8184         * unittests/style-selftests.c: Fix common/ includes.
8185         * unittests/string_view-selftests.c: Fix common/ includes.
8186         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8187         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8188         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8189         * unittests/rsp-low-selftests.c: Fix common/ includes.
8190         * unittests/parse-connection-spec-selftests.c: Fix common/
8191         includes.
8192         * unittests/optional-selftests.c: Fix common/ includes.
8193         * unittests/offset-type-selftests.c: Fix common/ includes.
8194         * unittests/observable-selftests.c: Fix common/ includes.
8195         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8196         * unittests/memrange-selftests.c: Fix common/ includes.
8197         * unittests/memory-map-selftests.c: Fix common/ includes.
8198         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8199         * unittests/function-view-selftests.c: Fix common/ includes.
8200         * unittests/environ-selftests.c: Fix common/ includes.
8201         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8202         * unittests/common-utils-selftests.c: Fix common/ includes.
8203         * unittests/cli-utils-selftests.c: Fix common/ includes.
8204         * unittests/array-view-selftests.c: Fix common/ includes.
8205         * ui-file.c: Fix common/ includes.
8206         * tui/tui-io.c: Fix common/ includes.
8207         * tracepoint.h: Fix common/ includes.
8208         * tracepoint.c: Fix common/ includes.
8209         * tracefile-tfile.c: Fix common/ includes.
8210         * top.h: Fix common/ includes.
8211         * top.c: Fix common/ includes.
8212         * thread.c: Fix common/ includes.
8213         * target/waitstatus.h: Fix common/ includes.
8214         * target/waitstatus.c: Fix common/ includes.
8215         * target.h: Fix common/ includes.
8216         * target.c: Fix common/ includes.
8217         * target-memory.c: Fix common/ includes.
8218         * target-descriptions.c: Fix common/ includes.
8219         * symtab.h: Fix common/ includes.
8220         * symfile.c: Fix common/ includes.
8221         * stap-probe.c: Fix common/ includes.
8222         * spu-linux-nat.c: Fix common/ includes.
8223         * sparc-nat.c: Fix common/ includes.
8224         * source.c: Fix common/ includes.
8225         * solib.c: Fix common/ includes.
8226         * solib-target.c: Fix common/ includes.
8227         * ser-unix.c: Fix common/ includes.
8228         * ser-tcp.c: Fix common/ includes.
8229         * ser-pipe.c: Fix common/ includes.
8230         * ser-base.c: Fix common/ includes.
8231         * selftest-arch.c: Fix common/ includes.
8232         * s12z-tdep.c: Fix common/ includes.
8233         * rust-exp.y: Fix common/ includes.
8234         * rs6000-aix-tdep.c: Fix common/ includes.
8235         * riscv-tdep.c: Fix common/ includes.
8236         * remote.c: Fix common/ includes.
8237         * remote-notif.h: Fix common/ includes.
8238         * remote-fileio.h: Fix common/ includes.
8239         * remote-fileio.c: Fix common/ includes.
8240         * regcache.h: Fix common/ includes.
8241         * regcache.c: Fix common/ includes.
8242         * record-btrace.c: Fix common/ includes.
8243         * python/python.c: Fix common/ includes.
8244         * python/py-type.c: Fix common/ includes.
8245         * python/py-inferior.c: Fix common/ includes.
8246         * progspace.h: Fix common/ includes.
8247         * producer.c: Fix common/ includes.
8248         * procfs.c: Fix common/ includes.
8249         * proc-api.c: Fix common/ includes.
8250         * printcmd.c: Fix common/ includes.
8251         * ppc-linux-nat.c: Fix common/ includes.
8252         * parser-defs.h: Fix common/ includes.
8253         * osdata.c: Fix common/ includes.
8254         * obsd-nat.c: Fix common/ includes.
8255         * nat/x86-linux.c: Fix common/ includes.
8256         * nat/x86-linux-dregs.c: Fix common/ includes.
8257         * nat/x86-dregs.h: Fix common/ includes.
8258         * nat/x86-dregs.c: Fix common/ includes.
8259         * nat/ppc-linux.c: Fix common/ includes.
8260         * nat/mips-linux-watch.h: Fix common/ includes.
8261         * nat/mips-linux-watch.c: Fix common/ includes.
8262         * nat/linux-waitpid.c: Fix common/ includes.
8263         * nat/linux-ptrace.h: Fix common/ includes.
8264         * nat/linux-ptrace.c: Fix common/ includes.
8265         * nat/linux-procfs.c: Fix common/ includes.
8266         * nat/linux-personality.c: Fix common/ includes.
8267         * nat/linux-osdata.c: Fix common/ includes.
8268         * nat/linux-namespaces.c: Fix common/ includes.
8269         * nat/linux-btrace.h: Fix common/ includes.
8270         * nat/linux-btrace.c: Fix common/ includes.
8271         * nat/fork-inferior.c: Fix common/ includes.
8272         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8273         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8274         * nat/aarch64-linux.c: Fix common/ includes.
8275         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8276         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8277         * namespace.h: Fix common/ includes.
8278         * mips-linux-tdep.c: Fix common/ includes.
8279         * minsyms.c: Fix common/ includes.
8280         * mi/mi-parse.h: Fix common/ includes.
8281         * mi/mi-main.c: Fix common/ includes.
8282         * mi/mi-cmd-env.c: Fix common/ includes.
8283         * memrange.h: Fix common/ includes.
8284         * memattr.c: Fix common/ includes.
8285         * maint.h: Fix common/ includes.
8286         * maint.c: Fix common/ includes.
8287         * main.c: Fix common/ includes.
8288         * machoread.c: Fix common/ includes.
8289         * location.c: Fix common/ includes.
8290         * linux-thread-db.c: Fix common/ includes.
8291         * linux-nat.c: Fix common/ includes.
8292         * linux-fork.c: Fix common/ includes.
8293         * inline-frame.c: Fix common/ includes.
8294         * infrun.c: Fix common/ includes.
8295         * inflow.c: Fix common/ includes.
8296         * inferior.h: Fix common/ includes.
8297         * inferior.c: Fix common/ includes.
8298         * infcmd.c: Fix common/ includes.
8299         * inf-ptrace.c: Fix common/ includes.
8300         * inf-child.c: Fix common/ includes.
8301         * ia64-linux-nat.c: Fix common/ includes.
8302         * i387-tdep.c: Fix common/ includes.
8303         * i386-tdep.c: Fix common/ includes.
8304         * i386-linux-tdep.c: Fix common/ includes.
8305         * i386-linux-nat.c: Fix common/ includes.
8306         * i386-go32-tdep.c: Fix common/ includes.
8307         * i386-fbsd-tdep.c: Fix common/ includes.
8308         * i386-fbsd-nat.c: Fix common/ includes.
8309         * guile/scm-type.c: Fix common/ includes.
8310         * guile/guile.c: Fix common/ includes.
8311         * go32-nat.c: Fix common/ includes.
8312         * gnu-nat.c: Fix common/ includes.
8313         * gdbthread.h: Fix common/ includes.
8314         * gdbarch-selftests.c: Fix common/ includes.
8315         * gdb_usleep.c: Fix common/ includes.
8316         * gdb_select.h: Fix common/ includes.
8317         * gdb_bfd.c: Fix common/ includes.
8318         * gcore.c: Fix common/ includes.
8319         * fork-child.c: Fix common/ includes.
8320         * findvar.c: Fix common/ includes.
8321         * fbsd-nat.c: Fix common/ includes.
8322         * event-top.c: Fix common/ includes.
8323         * event-loop.c: Fix common/ includes.
8324         * dwarf2read.c: Fix common/ includes.
8325         * dwarf2loc.c: Fix common/ includes.
8326         * dwarf2-frame.c: Fix common/ includes.
8327         * dwarf-index-cache.c: Fix common/ includes.
8328         * dtrace-probe.c: Fix common/ includes.
8329         * disasm-selftests.c: Fix common/ includes.
8330         * defs.h: Fix common/ includes.
8331         * csky-tdep.c: Fix common/ includes.
8332         * cp-valprint.c: Fix common/ includes.
8333         * cp-support.h: Fix common/ includes.
8334         * cp-support.c: Fix common/ includes.
8335         * corelow.c: Fix common/ includes.
8336         * completer.h: Fix common/ includes.
8337         * completer.c: Fix common/ includes.
8338         * compile/compile.c: Fix common/ includes.
8339         * compile/compile-loc2c.c: Fix common/ includes.
8340         * compile/compile-cplus-types.c: Fix common/ includes.
8341         * compile/compile-cplus-symbols.c: Fix common/ includes.
8342         * command.h: Fix common/ includes.
8343         * cli/cli-dump.c: Fix common/ includes.
8344         * cli/cli-cmds.c: Fix common/ includes.
8345         * charset.c: Fix common/ includes.
8346         * build-id.c: Fix common/ includes.
8347         * btrace.h: Fix common/ includes.
8348         * btrace.c: Fix common/ includes.
8349         * breakpoint.h: Fix common/ includes.
8350         * breakpoint.c: Fix common/ includes.
8351         * ax.h:
8352         (enum agent_op): Fix common/ includes.
8353         * ax-general.c (struct aop_map): Fix common/ includes.
8354         * ax-gdb.c: Fix common/ includes.
8355         * auxv.c: Fix common/ includes.
8356         * auto-load.c: Fix common/ includes.
8357         * arm-tdep.c: Fix common/ includes.
8358         * arch/riscv.c: Fix common/ includes.
8359         * arch/ppc-linux-common.c: Fix common/ includes.
8360         * arch/i386.c: Fix common/ includes.
8361         * arch/arm.c: Fix common/ includes.
8362         * arch/arm-linux.c: Fix common/ includes.
8363         * arch/arm-get-next-pcs.c: Fix common/ includes.
8364         * arch/amd64.c: Fix common/ includes.
8365         * arch/aarch64.c: Fix common/ includes.
8366         * arch/aarch64-insn.c: Fix common/ includes.
8367         * arch-utils.c: Fix common/ includes.
8368         * amd64-windows-tdep.c: Fix common/ includes.
8369         * amd64-tdep.c: Fix common/ includes.
8370         * amd64-sol2-tdep.c: Fix common/ includes.
8371         * amd64-obsd-tdep.c: Fix common/ includes.
8372         * amd64-nbsd-tdep.c: Fix common/ includes.
8373         * amd64-linux-tdep.c: Fix common/ includes.
8374         * amd64-linux-nat.c: Fix common/ includes.
8375         * amd64-fbsd-tdep.c: Fix common/ includes.
8376         * amd64-fbsd-nat.c: Fix common/ includes.
8377         * amd64-dicos-tdep.c: Fix common/ includes.
8378         * amd64-darwin-tdep.c: Fix common/ includes.
8379         * agent.c: Fix common/ includes.
8380         * ada-lang.h: Fix common/ includes.
8381         * ada-lang.c: Fix common/ includes.
8382         * aarch64-tdep.c: Fix common/ includes.
8383
8384 2019-01-25  Tom Tromey  <tom@tromey.com>
8385
8386         * common/create-version.sh: Use common/version.h.
8387
8388 2019-01-24  Pedro Alves  <palves@redhat.com>
8389
8390         * infrun.c (signal_stop, signal_print, signal_program)
8391         (signal_catch, signal_pass): Now arrays instead of pointers.
8392         (update_signals_program_target, do_target_resume)
8393         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8394         * linux-nat.c (linux_nat_target::pass_signals)
8395         (linux_nat_target::create_inferior, linux_nat_target::attach):
8396         Adjust.
8397         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8398         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8399         * procfs.c (procfs_target::pass_signals): Adjust.
8400         * record-full.c (record_full_target::resume): Adjust.
8401         * remote.c (remote_target::pass_signals)
8402         (remote_target::program_signals): Adjust.
8403         * target-debug.h (target_debug_print_signals): Now takes a
8404         gdb::array_view as parameter.  Adjust.
8405         * target.h (target_ops) <pass_signals, program_signals>: Replace
8406         pointer and length parameters with gdb::array_view.
8407         (target_pass_signals, target_program_signals): Likewise.
8408         * target-delegates.c: Regenerate.
8409
8410 2019-01-24  Pedro Alves  <palves@redhat.com>
8411
8412         * common/forward-scope-exit.h
8413         (forward_scope_exit::forward_scope_exit): Pass arguments to
8414         m_bind_function directly, instead of creating a std::bind and
8415         copying that.
8416
8417 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8418
8419         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8420         for static members.
8421         (pass_in_v_vfp_candidate): Likewise.
8422
8423 2019-01-23  Tom Tromey  <tom@tromey.com>
8424             Pedro Alves  <palves@redhat.com>
8425
8426         * regcache.c (class regcache_invalidator): Remove.
8427         (regcache::raw_write): Use make_scope_exit.
8428
8429 2019-01-23  Tom Tromey  <tom@tromey.com>
8430
8431         * ui-out.h (class ui_out_emit_type): Update comment.
8432
8433 2019-01-23  Tom Tromey  <tom@tromey.com>
8434
8435         * infrun.c (fetch_inferior_event): Update comment.
8436
8437 2019-01-23  Tom Tromey  <tom@tromey.com>
8438             Pedro Alves  <palves@redhat.com>
8439
8440         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8441         parameter.
8442         (fetch_inferior_event): Use SCOPE_EXIT.
8443
8444
8445 2019-01-23  Tom Tromey  <tom@tromey.com>
8446             Pedro Alves  <palves@redhat.com>
8447
8448         * infrun.c (disable_thread_events): Delete.
8449         (stop_all_threads): Use SCOPE_EXIT.
8450
8451 2019-01-23  Tom Tromey  <tom@tromey.com>
8452             Pedro Alves  <palves@redhat.com>
8453
8454         * symfile.c: Include forward-scope-exit.h.
8455         (clear_symtab_users_cleanup): Replace forward declaration with
8456         a FORWARD_SCOPE_EXIT.
8457         (syms_from_objfile_1): Use the forward_scope_exit and
8458         gdb::optional instead of cleanup_function.
8459         (reread_symbols): Use the forward_scope_exit instead of
8460         cleanup_function.
8461         (clear_symtab_users_cleanup): Remove function.
8462
8463 2019-01-23  Tom Tromey  <tom@tromey.com>
8464             Pedro Alves  <palves@redhat.com>
8465
8466         * linux-nat.c: Include scope-exit.h.
8467         (cleanup_target_stop): Remove.
8468         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8469         SCOPE_EXIT.
8470
8471 2019-01-23  Tom Tromey  <tom@tromey.com>
8472             Pedro Alves  <palves@redhat.com>
8473
8474         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8475         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8476
8477 2019-01-23  Tom Tromey  <tom@tromey.com>
8478             Andrew Burgess  <andrew.burgess@embecosm.com>
8479             Pedro Alves  <palves@redhat.com>
8480
8481         * infrun.c (fetch_inferior_event): Use scope_exit.
8482         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8483         * top.c (execute_command): Use scope_exit.
8484         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8485         * utils.c (do_bpstat_clear_actions_cleanup)
8486         (make_bpstat_clear_actions_cleanup): Remove.
8487
8488 2019-01-23  Tom Tromey  <tom@tromey.com>
8489             Pedro Alves  <palves@redhat.com>
8490
8491         * infrun.c: Include "common/scope-exit.h"
8492         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8493         (wait_for_inferior): Use SCOPE_EXIT.
8494         (fetch_inferior_event): Use scope_exit.
8495
8496 2019-01-23  Tom Tromey  <tom@tromey.com>
8497             Pedro Alves  <palves@redhat.com>
8498
8499         * breakpoint.c (create_breakpoint): Remove cleanup.
8500
8501 2019-01-23  Tom Tromey  <tom@tromey.com>
8502             Andrew Burgess  <andrew.burgess@embecosm.com>
8503             Pedro Alves  <palves@redhat.com>
8504
8505 2019-01-23  Pedro Alves  <palves@redhat.com>
8506
8507         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8508
8509 2019-01-23  Pedro Alves  <palves@redhat.com>
8510             Andrew Burgess  <andrew.burgess@embecosm.com>
8511
8512         * gdbthread.h: Include "common/forward-scope-exit.h".
8513         (scoped_finish_thread_state): Redefine custom class in terms of
8514         forward_scope_exit.
8515
8516 2019-01-23  Pedro Alves  <palves@redhat.com>
8517             Andrew Burgess  <andrew.burgess@embecosm.com>
8518
8519         * common/forward-scope-exit.h: New file.
8520
8521 2019-01-23  Pedro Alves  <palves@redhat.com>
8522             Andrew Burgess  <andrew.burgess@embecosm.com>
8523             Tom Tromey  <tom@tromey.com>
8524
8525         * common/scope-exit.h: New file.
8526
8527 2019-01-23  Pedro Alves  <palves@redhat.com>
8528
8529         * common/preprocessor.h (ESC): Rename to ...
8530         (ESC_PARENS): ... this.
8531         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8532         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8533
8534 2019-01-23  Tom Tromey  <tom@tromey.com>
8535
8536         * language.h (class scoped_switch_to_sym_language_if_auto):
8537         Initialize m_lang in both cases.
8538
8539 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8540
8541         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8542         with XCNEW.
8543
8544 2019-01-22  Tom Tromey  <tom@tromey.com>
8545
8546         * corelow.c: Do not include sys/file.h.
8547
8548 2019-01-22  Tom Tromey  <tom@tromey.com>
8549
8550         * tui/tui-wingeneral.h: Include gdb_curses.h.
8551
8552 2019-01-22  Tom Tromey  <tom@tromey.com>
8553
8554         * source-cache.h (class source_cache) <get_source_lines,
8555         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8556
8557 2019-01-22  Tom Tromey  <tom@tromey.com>
8558
8559         * remote-fileio.h (struct remote_target): Declare.
8560
8561 2019-01-22  Tom Tromey  <tom@tromey.com>
8562
8563         * python/py-arch.c: Do not include py-ref.h.
8564         * python/py-bpevent.c: Do not include py-ref.h.
8565         * python/py-cmd.c: Do not include py-ref.h.
8566         * python/py-continueevent.c: Do not include py-ref.h.
8567         * python/py-event.h: Do not include py-ref.h.
8568         * python/py-evtregistry.c: Do not include py-ref.h.
8569         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8570         * python/py-frame.c: Do not include py-ref.h.
8571         * python/py-framefilter.c: Do not include py-ref.h.
8572         * python/py-function.c: Do not include py-ref.h.
8573         * python/py-infevents.c: Do not include py-ref.h.
8574         * python/py-linetable.c: Do not include py-ref.h.
8575         * python/py-objfile.c: Do not include py-ref.h.
8576         * python/py-param.c: Do not include py-ref.h.
8577         * python/py-prettyprint.c: Do not include py-ref.h.
8578         * python/py-progspace.c: Do not include py-ref.h.
8579         * python/py-symbol.c: Do not include py-ref.h.
8580         * python/py-symtab.c: Do not include py-ref.h.
8581         * python/py-type.c: Do not include py-ref.h.
8582         * python/py-unwind.c: Do not include py-ref.h.
8583         * python/py-utils.c: Do not include py-ref.h.
8584         * python/py-value.c: Do not include py-ref.h.
8585         * python/py-varobj.c: Do not include py-ref.h.
8586         * python/py-xmethods.c: Do not include py-ref.h.
8587         * python/python.c: Do not include py-ref.h.
8588         * varobj.c: Do not include py-ref.h.
8589
8590 2019-01-22  Tom Tromey  <tom@tromey.com>
8591
8592         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8593         keyword for bcache.
8594
8595 2019-01-22  Tom Tromey  <tom@tromey.com>
8596
8597         * compile/compile-cplus-types.c: Remove a comment by #include.
8598
8599 2019-01-22  Tom Tromey  <tom@tromey.com>
8600
8601         * compile/gcc-c-plugin.h: Include compile-internal.h.
8602
8603 2019-01-22  Tom Tromey  <tom@tromey.com>
8604
8605         * stabsread.c (EXTERN): Do not define.
8606         (symnum, next_symbol_text_func, processing_gcc_compilation)
8607         (within_function, global_sym_chain, global_stabs)
8608         (previous_stab_code, this_object_header_files)
8609         (n_this_object_header_files)
8610         (n_allocated_this_object_header_files): Define.
8611         * stabsread.h (EXTERN): Never define.  Use "extern".
8612
8613 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8614
8615         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8616         history_value.
8617
8618 2019-01-21  Tom Tromey  <tom@tromey.com>
8619
8620         * ui-out.c: Fix includes.
8621         * tui/tui-source.c: Fix includes.
8622         * target.c: Fix includes.
8623         * remote.c: Fix includes.
8624         * regcache.c: Fix includes.
8625         * python/py-block.c: Fix includes.
8626         * printcmd.c: Fix includes.
8627         * or1k-tdep.c: Fix includes.
8628         * mi/mi-main.c: Fix includes.
8629         * m32r-tdep.c: Fix includes.
8630         * csky-tdep.c: Fix includes.
8631         * compile/compile-cplus-types.c: Fix includes.
8632         * cli/cli-interp.c: Fix includes.
8633
8634 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8635
8636         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8637         for padding.
8638
8639 2019-01-16  Tom Tromey  <tom@tromey.com>
8640
8641         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8642         earlier.
8643         (struct objfile) <msymbols_range>: Move from top level.
8644         <msymbols>: New method.
8645         (class objfile_msymbols): Remove.
8646         * symtab.c (default_collect_symbol_completion_matches_break_on):
8647         Update.
8648         * symmisc.c (dump_msymbols): Update.
8649         * stabsread.c (scan_file_globals): Update.
8650         * objc-lang.c (info_selectors_command, info_classes_command)
8651         (find_methods): Update.
8652         * minsyms.c (find_solib_trampoline_target): Update.
8653         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8654         * coffread.c (coff_symfile_read): Update.
8655         * ada-lang.c (ada_lookup_simple_minsym)
8656         (ada_collect_symbol_completion_matches): Update.
8657
8658 2019-01-16  Tom Tromey  <tom@tromey.com>
8659
8660         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8661         type.  Remove no-argument constructor.
8662         <iterator::operator++>: Simplify.
8663         <begin>: Update.
8664         <end>: Use minimal_symbol_count.
8665
8666 2019-01-16  Tom Tromey  <tom@tromey.com>
8667
8668         * objfiles.h (struct objfile) <psymtabs>: New method.
8669         (class objfile_psymtabs): Remove.
8670         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8671         typedef.
8672         <range>: New method.
8673         (require_partial_symbols): Change return type.
8674         * psymtab.c (require_partial_symbols)
8675         (psym_expand_symtabs_matching): Update.
8676         * mdebugread.c (parse_partial_symbols): Update.
8677         * dbxread.c (dbx_end_psymtab): Update.
8678
8679 2019-01-15  Tom Tromey  <tom@tromey.com>
8680
8681         * symtab.c (lookup_objfile_from_block)
8682         (lookup_symbol_in_objfile_symtabs)
8683         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8684         (find_line_symtab, info_sources_command)
8685         (default_collect_symbol_completion_matches_break_on)
8686         (make_source_files_completion_list): Update.
8687         * symmisc.c (print_objfile_statistics, dump_objfile)
8688         (maintenance_print_symbols, maintenance_info_symtabs)
8689         (maintenance_check_symtabs, maintenance_info_line_tables):
8690         Update.
8691         * source.c (select_source_symtab)
8692         (forget_cached_source_info_for_objfile): Update.
8693         * objfiles.h (class objfile_compunits): Remove.
8694         (struct objfile) <compunits_range>: New typedef.
8695         (compunits): New method.
8696         * objfiles.c (objfile_relocate1): Update.
8697         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8698         * maint.c (count_symtabs_and_blocks): Update.
8699         * linespec.c (iterate_over_all_matching_symtabs): Update.
8700         * cp-support.c (add_symbol_overload_list_qualified): Update.
8701         * coffread.c (coff_symtab_read): Update.
8702         * ada-lang.c (add_nonlocal_symbols)
8703         (ada_collect_symbol_completion_matches)
8704         (ada_add_global_exceptions): Update.
8705
8706 2019-01-15  Tom Tromey  <tom@tromey.com>
8707
8708         * progspace.h (program_space) <objfiles_safe_range>: New
8709         typedef.
8710         <objfiles_safe>: New method.
8711         * objfiles.h (class all_objfiles_safe): Remove.
8712         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8713         * jit.c (jit_inferior_exit_hook): Update.
8714
8715 2019-01-17  Tom Tromey  <tom@tromey.com>
8716
8717         * progspace.h (program_space) <objfiles_range>: New typedef.
8718         <objfiles>: New method.
8719         <objfiles_head>: Rename from objfiles.
8720         (object_files): Update.
8721         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8722         * guile/scm-pretty-print.c
8723         (ppscm_find_pretty_printer_from_objfiles): Update.
8724         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8725         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8726         Update.
8727         * python/py-progspace.c (pspy_get_objfiles): Update.
8728         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8729         Update.
8730         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8731         (objfpy_lookup_objfile_by_build_id): Update.
8732         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8733         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8734         Update.
8735         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8736         (expand_symtab_containing_pc, lookup_objfile_from_block)
8737         (lookup_static_symbol, basic_lookup_transparent_type)
8738         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8739         (find_line_symtab, info_sources_command)
8740         (default_collect_symbol_completion_matches_break_on)
8741         (make_source_files_completion_list, find_main_name): Update.
8742         * symmisc.c (print_symbol_bcache_statistics)
8743         (print_objfile_statistics, maintenance_print_symbols)
8744         (maintenance_print_msymbols, maintenance_print_objfiles)
8745         (maintenance_info_symtabs, maintenance_check_symtabs)
8746         (maintenance_expand_symtabs, maintenance_info_line_tables):
8747         Update.
8748         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8749         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8750         (map_overlay_command, unmap_overlay_command)
8751         (simple_overlay_update, expand_symtabs_matching)
8752         (map_symbol_filenames): Update.
8753         * symfile-debug.c (set_debug_symfile): Update.
8754         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8755         Update.
8756         * source.c (select_source_symtab, forget_cached_source_info):
8757         Update.
8758         * solib.c (solib_read_symbols): Update.
8759         * solib-spu.c (append_ocl_sos): Update.
8760         * psymtab.c (maintenance_print_psymbols)
8761         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8762         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8763         * printcmd.c (info_symbol_command): Update.
8764         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8765         Update.
8766         * objfiles.h (class all_objfiles): Remove.
8767         * objfiles.c (have_partial_symbols, have_full_symbols)
8768         (have_minimal_symbols, qsort_cmp, update_section_map)
8769         (shared_objfile_contains_address_p)
8770         (default_iterate_over_objfiles_in_search_order): Update.
8771         * objc-lang.c (info_selectors_command, info_classes_command)
8772         (find_methods): Update.
8773         * minsyms.c (find_solib_trampoline_target): Update.
8774         * maint.c (maintenance_info_sections)
8775         (maintenance_translate_address, count_symtabs_and_blocks):
8776         Update.
8777         * main.c (captured_main_1): Update.
8778         * linux-thread-db.c (try_thread_db_load_from_pdir)
8779         (has_libpthread): Update.
8780         * linespec.c (iterate_over_all_matching_symtabs)
8781         (search_minsyms_for_name): Update.
8782         * jit.c (jit_find_objf_with_entry_addr): Update.
8783         * hppa-tdep.c (find_unwind_entry)
8784         (hppa_lookup_stub_minimal_symbol): Update.
8785         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8786         Update.
8787         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8788         (elf_gnu_ifunc_resolve_by_got): Update.
8789         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8790         * dwarf-index-write.c (save_gdb_index_command): Update.
8791         * cp-support.c (add_symbol_overload_list_qualified): Update.
8792         * breakpoint.c (create_overlay_event_breakpoint)
8793         (create_longjmp_master_breakpoint)
8794         (create_std_terminate_master_breakpoint)
8795         (create_exception_master_breakpoint): Update.
8796         * blockframe.c (find_pc_partial_function): Update.
8797         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8798         (ada_collect_symbol_completion_matches)
8799         (ada_add_global_exceptions): Update.
8800
8801 2019-01-17  Tom Tromey  <tom@tromey.com>
8802
8803         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8804         declare VEC.
8805         (solib_target_parse_libraries): Change return type.
8806         (library_list_start_segment, library_list_start_section)
8807         (library_list_end_library, library_list_start_library); Update.
8808         (solib_target_free_library_list): Remove.
8809         (solib_target_parse_libraries): Remove cleanup.  Change return
8810         type.
8811         (solib_target_current_sos): Update.
8812
8813 2019-01-17  Tom Tromey  <tromey@bapiya>
8814
8815         * valprint.c: Replace "the the" with "the".
8816         * symtab.c: Replace "the the" with "the".
8817         * solib.c: Replace "the the" with "the".
8818         * solib-dsbt.c: Replace "the the" with "the".
8819         * linespec.c: Replace "the the" with "the".
8820         * dwarf2loc.h: Replace "the the" with "the".
8821         * amd64-windows-tdep.c: Replace "the the" with "the".
8822         * aarch64-tdep.c: Replace "the the" with "the".
8823
8824 2019-01-16  Keith Seitz  <keiths@redhat.com>
8825
8826         PR gdb/23773
8827         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8828         <builder>: Rename to ..
8829         <m_builder>: ... this and make private.
8830         (dwarf2_cu::get_builder): New method.  Change all users of
8831         `builder' to use this method.
8832         (dwarf2_start_symtab): Move to ...
8833         (dwarf2_cu::start_symtab): ... here.  Update all callers
8834         (setup_type_unit_groups): Move to ...
8835         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8836         callers.
8837         (dwarf2_cu::reset_builder): New method.
8838         (process_full_compunit, process_full_type_unit): Use
8839         dwarf2_cu::reset_builder.
8840         (follow_die_offset): Record the ancestor CU if it is different
8841         from the followed DIE's CU.
8842         (follow_die_sig_1): Likewise.
8843
8844 2019-01-15  Tom Tromey  <tom@tromey.com>
8845
8846         * remote.c (class remote_state) <buf>: Now a char_vector.
8847         <buf_size>: Remove.
8848         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8849         parameter.
8850         (remote_target::getpkt_or_notif_sane_1)
8851         (remote_target::getpkt_sane)
8852         (remote_target::getpkt_or_notif_sane): Likewise.
8853         (class remote_target) <putpkt>: New overload.
8854         (remote_target::read_frame): Change type of "buf_p".  Remove
8855         sizeof_p parameter.
8856         (packet_ok): New overload.
8857         (packet_check_result): New overload.
8858         Update all uses.
8859
8860 2019-01-14  Tom Tromey  <tom@tromey.com>
8861
8862         * remote-notif.c (handle_notification, remote_notif_ack)
8863         (remote_notif_parse): Make "buf" const.
8864         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8865         const.
8866         (remote_notif_parse, remote_notif_ack, handle_notification):
8867         Likewise.
8868         * remote.c (remote_notif_stop_parse): Make "buf" const.
8869         (remote_target::remote_parse_stop_reply): Make "buf" const.
8870         (remote_notif_stop_ack): Make "buf" const.
8871
8872 2019-01-14  Tom Tromey  <tom@tromey.com>
8873
8874         * remote.c (remote_console_output): Make parameter const.
8875
8876 2019-01-14  Tom Tromey  <tom@tromey.com>
8877
8878         * target-debug.h (target_debug_print_signals): Constify.
8879         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8880         * procfs.c (procfs_target::pass_signals): Update.
8881         * linux-nat.c (linux_nat_target::pass_signals): Update.
8882         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8883         * target-delegates.c: Rebuild.
8884         * remote.c (remote_target::program_signals): Update.
8885         (remote_target::pass_signals): Update.
8886         * target.c (target_pass_signals): Constify argument.
8887         (target_program_signals): Likewise.
8888         * target.h (struct target_ops) <pass_signals, program_signals>:
8889         Constify argument.
8890         (target_pass_signals, target_program_signals): Constify argument.
8891
8892 2019-01-14  Tom Tromey  <tom@tromey.com>
8893
8894         PR tui/28819:
8895         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8896
8897 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8898
8899         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8900         field.
8901         * rs6000-tdep.c: Include reggroups.h.
8902         (IS_V_ALIAS_PSEUDOREG): Define.
8903         (rs6000_register_name): Return names for the "vX" aliases.
8904         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8905         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8906         aliases.  Call default_register_reggroup_p for all other
8907         pseudo-registers.
8908         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8909         New functions.
8910         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8911         Handle "vX" aliases.
8912         (v_alias_pseudo_register_collect): New function.
8913         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8914         (rs6000_gdbarch_init): Initialize "vX" aliases as
8915         pseudo-registers.  Restore registration of
8916         rs6000_pseudo_register_reggroup_p with
8917         set_tdesc_pseudo_register_reggroup_p.
8918
8919 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8920
8921         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8922         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8923         set_gdbarch_num_pseudo_regs.
8924
8925 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8926
8927         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8928         Remove arg prefixname, add do_set and do_show.
8929         Add member functions set_list and show_list.
8930         * cli/cli-style.c (class cli_style_option): Update accordingly.
8931         (style_set_list): Move to file scope.
8932         (style_show_list): Likewise.
8933         (set_style): Call help_list.
8934         (show_style): Call cmd_show_list.
8935         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8936         Update to use the new macro.
8937
8938 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8939
8940         * ada-lang.c (_initialize_ada_language): Expand the help text
8941         for the "catch exception" command.
8942
8943 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8944
8945         * symtab.c (matching_obj_sections): Initialize obj,
8946         declare it closer to its usage.
8947
8948 2019-01-10  Tom Tromey  <tom@tromey.com>
8949
8950         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8951         (basic_inf_threads_range): Remove.
8952         (inf_threads_range, inf_non_exited_threads_range)
8953         (safe_inf_threads_range): Use next_adapter.
8954
8955 2019-01-10  Keith Seitz  <keiths@redhat.com>
8956
8957         PR gdb/23712
8958         PR symtab/23010
8959         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8960         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8961
8962 2019-01-10  Keith Seitz  <keiths@redhat.com>
8963
8964         PR gdb/23712
8965         PR symtab/23010
8966         * dictionary.c (pending_to_vector): Remove.
8967         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8968         Remove _1 suffix, replacing functions of the same name.  Update
8969         all callers.
8970         (dict_create_hashed, dict_create_hashed_expandable)
8971         (dict_create_linear, dict_create_linear_expandable, dict_free)
8972         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8973         Make functions static.
8974
8975 2019-01-10  Keith Seitz  <keiths@redhat.com>
8976
8977         PR gdb/23712
8978         PR symtab/23010
8979         * dictionary.h (struct dictionary): Replace declaration with
8980         multidictionary.
8981         (dict_create_hashed, dict_create_hashed_expandable)
8982         (dict_create_linear, dict_create_linear_expandable)
8983         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8984         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8985         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8986         taking multidictionary argument.
8987         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8988         * block.h (struct block) <dict>: Change to multidictionary
8989         and rename `multidict'.
8990         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8991         symmisc.c: Update all dictionary references to multidictionary.
8992
8993 2019-01-10  Keith Seitz  <keiths@redhat.com>
8994
8995         PR gdb/23712
8996         PR symtab/23010
8997         * dictionary.c: Include unordered_map.
8998         (pending_to_vector): New function.
8999         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9000         Rewrite the non-"_1" functions to take vector instead
9001         of linked list.
9002         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9003         "new" _1 versions of the same name.
9004         (multidictionary): Define.
9005         (std::hash<enum language): New definition.
9006         (collate_pending_symbols_by_language, mdict_create_hashed)
9007         (mdict_create_hashed_expandable, mdict_create_linear)
9008         (mdict_create_linear_expandable, mdict_free)
9009         (find_language_dictionary, create_new_language_dictionary)
9010         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9011         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9012         (mdict_size, mdict_empty): New functions.
9013         * dictionary.h (mdict_iterator): Define.
9014
9015 2019-01-10  Pedro Alves  <palves@redhat.com>
9016
9017         * breakpoint.c (read_uploaded_action)
9018         (create_tracepoint_from_upload): Adjust to use
9019         gdb::unique_xmalloc_ptr.
9020         * ctf.c (ctf_write_uploaded_tp):
9021         (SET_ARRAY_FIELD): Use emplace_back.
9022         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9023         * tracefile-tfile.c (tfile_write_uploaded_tp):
9024         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9025         gdb::unique_xmalloc_ptr.
9026         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9027         at_string, cond_string, cmd_strings>: Replace char pointers
9028         with gdb::unique_xmalloc_ptr.
9029
9030 2019-01-10  Pedro Alves  <palves@redhat.com>
9031
9032         * solib-target.c (library_list_start_library): Don't xstrdup name.
9033
9034 2019-01-10  Pedro Alves  <palves@redhat.com>
9035
9036         * mdebugread.c (parse_partial_symbols): Use
9037         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9038
9039 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9040
9041         * linux-fork.c (scoped_switch_fork_info)
9042         <~scoped_switch_fork_info>: Fix incorrect variable name.
9043
9044 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9045
9046         * linux-fork.c (scoped_switch_fork_info)
9047         <scoped_switch_fork_info>: Make explicit.
9048         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9049
9050 2019-01-10  Tom Tromey  <tom@tromey.com>
9051
9052         * objfiles.h (objfile::reset_psymtabs): Update.
9053         * objfiles.c (objfile::objfile): Update.
9054         * psymtab.h (psymtab_storage::obstack): Update.
9055         (psymtab_storage::m_obstack): Use gdb::optional.
9056         (class psymtab_storage): Update comment.  Remove objfile
9057         parameter.
9058         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9059
9060 2019-01-10  Tom Tromey  <tom@tromey.com>
9061
9062         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9063         <free_psymtabs>: Now private.
9064         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9065         (allocate_psymtab): Use new method.
9066
9067 2019-01-10  Tom Tromey  <tom@tromey.com>
9068
9069         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9070         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9071         * mdebugread.c (parse_partial_symbols): Use
9072         allocate_dependencies.
9073         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9074         allocate_dependencies.
9075         (process_psymtab_comp_unit_reader)
9076         (build_type_psymtab_dependencies): Likewise.
9077         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9078
9079 2019-01-10  Tom Tromey  <tom@tromey.com>
9080
9081         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9082         PSYMBOL_SET_LANGUAGE.
9083         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9084
9085 2019-01-10  Tom Tromey  <tom@tromey.com>
9086
9087         * psymtab.h (psymtab_storage::obstack): New method.
9088         <m_obstack>: Rename from obstack; now private.
9089         * psymtab.c (psymtab_storage): Update.
9090         * dwarf2read.c (create_addrmap_from_index)
9091         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9092         Update.
9093
9094 2019-01-10  Tom Tromey  <tom@tromey.com>
9095
9096         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9097         * objfiles.h (objfile::reset_psymtabs): New method.
9098
9099 2019-01-10  Tom Tromey  <tom@tromey.com>
9100
9101         * symmisc.c (print_symbol_bcache_statistics): Update.
9102         (print_objfile_statistics): Update.
9103         * symfile.c (reread_symbols): Update.
9104         * psymtab.h (class psymtab_storage): New.
9105         * psymtab.c (psymtab_storage): New constructor.
9106         (~psymtab_storage): New destructor.
9107         (require_partial_symbols): Update.
9108         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9109         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9110         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9111         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9112         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9113         (start_psymtab_common, end_psymtab_common)
9114         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9115         (allocate_psymtab): Update.
9116         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9117         Update.
9118         (dump_psymtab_addrmap, maintenance_print_psymbols)
9119         (maintenance_check_psymtabs): Update.
9120         (class objfile_psymtabs): Move to objfiles.h.
9121         * psympriv.h (discard_psymtab): Now inline.
9122         (psymtab_discarder::psymtab_discarder): Update.
9123         (psymtab_discarder::~psymtab_discarder): Update.
9124         (ALL_OBJFILE_PSYMTABS): Rewrite.
9125         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9126         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9127         Remove fields.
9128         <partial_symtabs>: New field.
9129         (class objfile_psymtabs): Move from psymtab.h.  Update.
9130         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9131         psymbol_cache.
9132         (objfile::~objfile): Don't destroy psymbol_cache.
9133         * mdebugread.c (parse_partial_symbols): Update.
9134         * dwarf2read.c (create_addrmap_from_index)
9135         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9136         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9137         (add_partial_subprogram, dwarf2_ranges_read): Update.
9138         * dwarf-index-write.c (write_address_map)
9139         (write_one_signatured_type, recursively_write_psymbols)
9140         (class debug_names, class debug_names, write_psymtabs_to_index):
9141         Update.
9142
9143 2019-01-10  Tom Tromey  <tom@tromey.com>
9144
9145         * symtab.h (SYMBOL_SET_NAMES): Update.
9146         (symbol_set_names): Update.
9147         (MSYMBOL_SET_NAMES): Update.
9148         * symtab.c (symbol_set_names): Change argument to be an
9149         objfile_per_bfd_storage.
9150         * psymtab.c (add_psymbol_to_bcache): Update.
9151         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9152
9153 2019-01-10  Tom Tromey  <tom@tromey.com>
9154
9155         * symtab.c (create_demangled_names_hash): Change argument to be an
9156         objfile_per_bfd_storage.
9157         (symbol_set_names): Update.
9158
9159 2019-01-10  Tom Tromey  <tom@tromey.com>
9160
9161         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9162         init_psymbol_list.
9163         * psymtab.c (init_psymbol_list): Do nothing if already called.
9164         * psympriv.h (init_psymbol_list): Add comment.
9165         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9166         init_psymbol_list.
9167         * dbxread.c (dbx_symfile_read): Unconditionally call
9168         init_psymbol_list.
9169
9170 2019-01-10  Tom Tromey  <tom@tromey.com>
9171
9172         * xcoffread.c (scan_xcoff_symtab): Update.
9173         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9174         "where".
9175         * mdebugread.c (parse_partial_symbols)
9176         (handle_psymbol_enumerators): Update.
9177         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9178         * dbxread.c (read_dbx_symtab): Update.
9179         * psympriv.h (psymbol_placement): New enum.
9180         (add_psymbol_to_list): Update.
9181
9182 2019-01-10  Tom Tromey  <tom@tromey.com>
9183
9184         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9185         static_psymbols parameters.
9186         (scan_xcoff_symtab): Update.
9187         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9188         static_psymbols parameters.
9189         * psympriv.h (start_psymtab_common): Update.
9190         * mdebugread.c (parse_partial_symbols): Update.
9191         * dwarf2read.c (create_partial_symtab): Update.
9192         * dbxread.c (read_dbx_symtab): Update.
9193         (start_psymtab): Remove global_psymbols and static_psymbols
9194         parameters.
9195
9196 2019-01-10  Tom Tromey  <tom@tromey.com>
9197
9198         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9199         * psymtab.c (allocate_psymtab): Add comment.
9200         * psympriv.h (allocate_psymtab): Add comment.
9201         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9202         initializations.
9203         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9204
9205 2019-01-10  Tom Tromey  <tom@tromey.com>
9206
9207         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9208         Don't declare.
9209         * mipsread.c: Include mdebugread.h.
9210         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9211         Declare.
9212         * elfread.c: Include mdebugread.h.
9213
9214 2019-01-09  Tom Tromey  <tom@tromey.com>
9215
9216         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9217         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9218         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9219         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9220         (psym_lookup_symbol, psym_find_last_source_symtab)
9221         (psym_forget_cached_source_info, psym_print_stats)
9222         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9223         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9224         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9225         (psym_find_compunit_symtab_by_address)
9226         (maintenance_print_psymbols, maintenance_info_psymtabs)
9227         (maintenance_check_psymtabs): Use ranged for.
9228         * psymtab.h (class objfile_psymtabs): New.
9229         (require_partial_symbols): Return objfile_psymtabs.
9230         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9231
9232 2019-01-09  Tom Tromey  <tom@tromey.com>
9233
9234         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9235         (find_pc_mapped_section, list_overlays_command)
9236         (map_overlay_command, unmap_overlay_command)
9237         (simple_overlay_update): Use all_objfiles.
9238         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9239         * printcmd.c (info_symbol_command): Use all_objfiles.
9240         * objfiles.h (ALL_OBJSECTIONS): Remove.
9241         * maint.c (maintenance_translate_address): Use all_objfiles.
9242         * gcore.c (gcore_create_callback): Use all_objfiles.
9243         (objfile_find_memory_regions): Likewise.
9244
9245 2019-01-09  Tom Tromey  <tom@tromey.com>
9246
9247         * symtab.c (find_line_symtab, info_sources_command)
9248         (make_source_files_completion_list): Use objfile_compunits.
9249         * source.c (select_source_symtab): Use objfile_compunits.
9250         * objfiles.h (struct objfile): Update comment.
9251         (ALL_OBJFILES): Remove.
9252         (ALL_FILETABS): Remove.
9253         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9254         objfile_compunits.
9255
9256 2019-01-09  Tom Tromey  <tom@tromey.com>
9257
9258         * symmisc.c (print_objfile_statistics, dump_objfile)
9259         (maintenance_print_symbols): Use compunit_filetabs.
9260         * source.c (forget_cached_source_info_for_objfile): Use
9261         compunit_filetabs.
9262         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9263         (ALL_FILETABS): Use compunit_filetabs.
9264         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9265         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9266
9267 2019-01-09  Tom Tromey  <tom@tromey.com>
9268
9269         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9270         (compunit_filetabs): New.
9271         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9272         compunit_filetabs.
9273         (info_sources_command, make_source_files_completion_list): Remove
9274         declaration.
9275         * symmisc.c (print_objfile_statistics, dump_objfile)
9276         (maintenance_print_symbols): Remove declaration.
9277         (maintenance_info_symtabs): Use compunit_filetabs.
9278         (maintenance_info_line_tables): Likewise.
9279         * source.c (select_source_symtab): Change local variable name.
9280         (forget_cached_source_info_for_objfile): Remove declaration.
9281         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9282         * objfiles.c (objfile_relocate1): Remove declaration.
9283         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9284         declaration.
9285         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9286         * coffread.c (coff_symtab_read): Remove declaration.
9287         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9288         compunit_filetabs.
9289
9290 2019-01-09  Tom Tromey  <tom@tromey.com>
9291
9292         * symtab.c (lookup_objfile_from_block)
9293         (find_pc_sect_compunit_symtab, search_symbols)
9294         (default_collect_symbol_completion_matches_break_on): Use
9295         objfile_compunits.
9296         * objfiles.h (ALL_COMPUNITS): Remove.
9297         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9298         * cp-support.c (add_symbol_overload_list_qualified): Use
9299         objfile_compunits.
9300         * ada-lang.c (ada_collect_symbol_completion_matches)
9301         (ada_add_global_exceptions): Use objfile_compunits.
9302
9303 2019-01-09  Tom Tromey  <tom@tromey.com>
9304
9305         * source.c (select_source_symtab)
9306         (forget_cached_source_info_for_objfile): Remove declaration.
9307         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9308         declaration.
9309         * maint.c (count_symtabs_and_blocks): Remove declaration.
9310         * cp-support.c (add_symbol_overload_list_qualified): Remove
9311         declaration.
9312         * coffread.c (coff_symtab_read): Remove declaration.
9313         * symtab.c (lookup_symbol_in_objfile_symtabs)
9314         (basic_lookup_transparent_type_1): Use objfile_compunits.
9315         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9316         (info_sources_command, search_symbols)
9317         (default_collect_symbol_completion_matches_break_on)
9318         (make_source_files_completion_list): Remove declaration.
9319         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9320         (ada_collect_symbol_completion_matches)
9321         (ada_add_global_exceptions): Remove declaration.
9322         * linespec.c (iterate_over_all_matching_symtabs): Use
9323         objfile_compunits.
9324         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9325         (class objfile_compunits): New.
9326         (ALL_COMPUNITS): Use objfile_compunits.
9327         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9328         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9329         objfile_compunits.
9330         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9331
9332 2019-01-09  Tom Tromey  <tom@tromey.com>
9333
9334         * symtab.c (search_symbols)
9335         (default_collect_symbol_completion_matches_break_on): Use
9336         objfile_msymbols.
9337         * ada-lang.c (ada_lookup_simple_minsym)
9338         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9339         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9340         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9341         objfile_msymbols.
9342         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9343         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9344         * objc-lang.c (find_methods): Use objfile_msymbols.
9345         (info_selectors_command, info_classes_command): Likewise.
9346         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9347         * objfiles.h (class objfile_msymbols): New.
9348         (ALL_OBJFILE_MSYMBOLS): Remove.
9349         (ALL_MSYMBOLS): Remove.
9350
9351 2019-01-09  Tom Tromey  <tom@tromey.com>
9352
9353         * common/next-iterator.h (next_adapter): Add Iterator template
9354         parameter.
9355         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9356         (class all_objfiles_safe): New.
9357         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9358         * objfiles.c (put_objfile_before): Update comment.
9359         (add_separate_debug_objfile): Likewise.
9360         (free_all_objfiles): Use all_objfiles_safe.
9361         (objfile_purge_solibs): Likewise.
9362
9363 2019-01-09  Tom Tromey  <tom@tromey.com>
9364
9365         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9366         (expand_symtab_containing_pc, lookup_static_symbol)
9367         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9368         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9369         all_objfiles.
9370         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9371         * breakpoint.c (create_overlay_event_breakpoint)
9372         (create_longjmp_master_breakpoint)
9373         (create_std_terminate_master_breakpoint)
9374         (create_exception_master_breakpoint): Use all_objfiles.
9375         * linux-thread-db.c (try_thread_db_load_from_pdir)
9376         (has_libpthread): Use all_objfiles.
9377         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9378         * linespec.c (iterate_over_all_matching_symtabs)
9379         (search_minsyms_for_name): Use all_objfiles.
9380         * maint.c (maintenance_info_sections): Use all_objfiles.
9381         * main.c (captured_main_1): Use all_objfiles.
9382         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9383         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9384         * guile/scm-pretty-print.c
9385         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9386         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9387         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9388         (maintenance_print_msymbols): Use all_objfiles.
9389         * source.c (select_source_symtab): Use all_objfiles.
9390         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9391         * symfile.c (remove_symbol_file_command)
9392         (expand_symtabs_matching, map_symbol_filenames): Use
9393         all_objfiles.
9394         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9395         all_objfiles.
9396         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9397         * objc-lang.c (find_methods): Use all_objfiles.
9398         * objfiles.c (have_partial_symbols, have_full_symbols)
9399         (have_minimal_symbols, qsort_cmp)
9400         (default_iterate_over_objfiles_in_search_order): Use
9401         all_objfiles.
9402         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9403         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9404         (maintenance_check_psymtabs): Use all_objfiles.
9405         (ALL_PSYMTABS): Remove.
9406         * compile/compile-object-run.c (do_module_cleanup): Use
9407         all_objfiles.
9408         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9409         * cp-support.c (add_symbol_overload_list_qualified): Use
9410         all_objfiles.
9411         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9412         Use all_objfiles.
9413         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9414         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9415         all_objfiles.
9416         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9417         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9418         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9419         Uses all_objfiles.
9420         * solib.c (solib_read_symbols): Use all_objfiles
9421
9422 2019-01-09  Tom Tromey  <tom@tromey.com>
9423
9424         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9425         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9426         all_objfiles.
9427         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9428         * symmisc.c (print_symbol_bcache_statistics)
9429         (print_objfile_statistics, maintenance_print_objfiles)
9430         (maintenance_info_symtabs, maintenance_check_symtabs)
9431         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9432         all_objfiles.
9433         * source.c (forget_cached_source_info): Use all_objfiles.
9434         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9435         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9436         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9437         * objfiles.c (update_section_map): Use all_objfiles.
9438         (shared_objfile_contains_address_p): Likewise.
9439         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9440         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9441
9442 2019-01-09  Tom Tromey  <tom@tromey.com>
9443
9444         * common/next-iterator.h: New file.
9445         * objfiles.h (class all_objfiles): New.
9446         (struct objfile_iterator): New.
9447
9448 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9449
9450         * NEWS: Move the description of the changed "frame", "select-frame",
9451          and "info frame" commands to the Changed commands section.
9452
9453 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9454
9455         * gdbtypes.c (check_stub_method_group): Remove handling of old
9456         mangling schemes.
9457         * linespec.c (find_methods): Likewise.
9458         * stabsread.c (read_member_functions): Likewise.
9459         * valops.c (search_struct_method): Likewise.
9460         (value_struct_elt_for_reference): Likewise.
9461         * NEWS: Mention this change.
9462
9463 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9464
9465         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9466         print_source_lines.
9467         * source.c (print_source_lines_base): Update line number check.
9468         (print_source_lines): New function.
9469         (source_lines_range::source_lines_range): New function.
9470         * source.h (class source_lines_range): New class.
9471         (print_source_lines): New declaration.
9472
9473 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9474
9475         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9476
9477 2019-01-08  Tom Tromey  <tom@tromey.com>
9478             Simon Marchi  <simon.marchi@ericsson.com>
9479
9480         PR gdb/24060
9481         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9482         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9483         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9484         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9485         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9486         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9487
9488 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9489
9490         * source.c (select_source_symtab): Move header comment to
9491         declaration in source.h.
9492         (forget_cached_source_info_for_objfile): Likewise.
9493         (forget_cached_source_info): Likewise.
9494         (identify_source_line): Likewise.
9495         * source.h (identify_source_line): Move declaration from symtab.h
9496         and add comment from source.c
9497         (print_source_lines): Likewise.
9498         (forget_cached_source_info_for_objfile): Likewise.
9499         (forget_cached_source_info): Likewise.
9500         (select_source_symtab): Likewise.
9501         (enum print_source_lines_flag): Move definition from symtab.h.
9502         * symtab.h (identify_source_line): Move declaration to source.h.
9503         (print_source_lines): Likewise.
9504         (forget_cached_source_info_for_objfile): Likewise.
9505         (forget_cached_source_info): Likewise.
9506         (select_source_symtab): Likewise.
9507         (enum print_source_lines_flag): Move definition to source.h.
9508         * tui/tui-hooks.c: Add 'source.h' include.
9509
9510 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9511
9512         * source.c (print_source_lines_base): Handle requests to print
9513         reverse line number sequences, and guard against empty lines
9514         string.
9515
9516 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9517
9518         * source.c (print_source_lines_base): Fix skip of '\r' if next
9519         character is '\n'.
9520
9521 2019-01-06  Tom Tromey  <tom@tromey.com>
9522
9523         * c-exp.y (struct c_parse_state) <macro_original_text,
9524         expansion_obstack>: New member.
9525         (macro_original_text, expansion_obstack): Remove globals.
9526         (scan_macro_expansion, scanning_macro_expansion)
9527         (finished_macro_expansion): Update.
9528         (scan_macro_cleanup): Remove.
9529         (yylex, c_parse): Update.
9530
9531 2019-01-06  Tom Tromey  <tom@tromey.com>
9532
9533         * c-exp.y (struct c_parse_state) <strings>: New member.
9534         (operator_stoken): Update.
9535
9536 2019-01-06  Tom Tromey  <tom@tromey.com>
9537
9538         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9539         (union type_stack_elt) <typelist_val>: Now a pointer to
9540         std::vector.
9541         (type_stack_cleanup): Don't declare.
9542         (push_typelist): Update.
9543         * parse.c (pop_typelist): Return a std::vector.
9544         (push_typelist): Take a std::vector.
9545         (follow_types): Update.  Do not free args.
9546         (type_stack_cleanup): Remove.
9547         * c-exp.y (struct c_parse_state): New.
9548         (cpstate): New global.
9549         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9550         (nonempty_typelist): Update.
9551         (func_mod): Create a new vector.
9552         (c_parse): Create a c_parse_state.
9553         (check_parameter_typelist): Do not delete params.
9554         (function_method): Update.  Do not delete type_list.
9555
9556 2019-01-06  Tom Tromey  <tom@tromey.com>
9557
9558         PR gdb/28155:
9559         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9560         check_typedef.
9561         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9562         (print_return_value): Likewise.
9563
9564 2019-01-05  Tom Tromey  <tom@tromey.com>
9565
9566         * contrib/cleanup_check.py: Remove.
9567         * contrib/gcc-with-excheck: Remove.
9568         * contrib/exsummary.py: Remove.
9569         * contrib/excheck.py: Remove.
9570
9571 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9572
9573         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9574         NULL. Initialize tpprev to NULL instead of assigning it
9575         to NULL on the next statement.
9576         * windows-nat.c (windows_delete_thread): Remove check for
9577         main_thread_id before printing thread exit notifications.
9578         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9579         Remove thread ID check against main_thread_id.
9580         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9581         windows_delete_thread.
9582         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9583
9584 2019-01-04  Tom Tromey  <tom@tromey.com>
9585
9586         * compile/compile.c (_initialize_compile): Use upper case for
9587         metasyntactic variables.
9588         * symmisc.c (_initialize_symmisc): Use upper case for
9589         metasyntactic variables.
9590         * psymtab.c (_initialize_psymtab): Use upper case for
9591         metasyntactic variables.
9592         * demangle.c (demangle_command): Use upper case for metasyntactic
9593         variables.
9594         (_initialize_demangler): Likewise.
9595         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9596         variables.
9597
9598 2019-01-03  Tom Tromey  <tom@tromey.com>
9599
9600         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9601
9602 2019-01-03  Tom Tromey  <tom@tromey.com>
9603
9604         * python/py-symtab.c (salpy_str): Update.
9605         (struct salpy_sal_object) <symtab>: Now a PyObject.
9606         (salpy_dealloc): Update.
9607         (del_objfile_sal): Use gdbpy_ref.
9608
9609 2019-01-03  Tom Tromey  <tom@tromey.com>
9610
9611         * python/py-type.c (convert_field): Use new_reference.  Return
9612         gdbpy_ref.
9613         (make_fielditem): Return gdbpy_ref.
9614         (typy_fields): Update.
9615         (typy_getitem): Update.
9616         (field_name): Return gdbpy_ref.  Use new_reference.
9617         (typy_iterator_iternext): Update.
9618
9619 2019-01-03  Tom Tromey  <tom@tromey.com>
9620
9621         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9622
9623 2019-01-03  Tom Tromey  <tom@tromey.com>
9624
9625         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9626         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9627         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9628         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9629         (pspy_set_type_printers): Likewise.
9630         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9631         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9632         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9633         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9634         (objfpy_set_type_printers): Likewise.
9635
9636 2019-01-03  Tom Tromey  <tom@tromey.com>
9637
9638         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9639         (gdbpy_print_stack): Use gdbpy_err_fetch.
9640         * python/python-internal.h (class gdbpy_err_fetch): New class.
9641         (class gdbpy_enter) <m_error_type, m_error_value,
9642         m_error_traceback>: Remove.
9643         <m_error>: New member.
9644         (gdbpy_exception_to_string): Don't declare.
9645         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9646         * python/py-value.c (convert_value_from_python): Use
9647         gdbpy_err_fetch.
9648         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9649         gdbpy_exception_to_string.
9650         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9651         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9652         gdbpy_err_fetch.
9653
9654 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9655
9656         * linux-nat.c (delete_lwp_cleanup): Delete.
9657         (struct lwp_deleter): New struct.
9658         (lwp_info_up): New typedef.
9659         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9660         lwp_info_up.
9661
9662 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9663
9664         * linux-fork.c (class scoped_switch_fork_info): New class.
9665         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9666
9667 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9668
9669         * valops.c (find_overload_match): Remove use of null_cleanup, and
9670         calls to do_cleanups.
9671
9672 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9673
9674         * compile/compile-cplus-types.c
9675         (compile_cplus_instance::decl_name): Handle changes to
9676         cp_func_name.
9677         * cp-support.c (cp_func_name): Update header comment, update
9678         return type.
9679         * cp-support.h (cp_func_name): Update return type in declaration.
9680         * valops.c (find_overload_match): Move temp_func local to top
9681         level of function and change its type.  Use temp_func to hold and
9682         delete temporary string obtained from cp_func_name.
9683
9684 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9685
9686         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9687         gdb::char_vector, remove cleanup, and update uses of `msg`.
9688
9689 2019-01-03  Jim Wilson  <jimw@sifive.com>
9690
9691         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9692
9693 2019-01-02  Tom Tromey  <tom@tromey.com>
9694
9695         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9696         (tdesc_parse_xml): Remove cleanups.
9697         * target-descriptions.h (make_cleanup_free_target_description):
9698         Don't declare.
9699         (target_desc_deleter): New struct.
9700         (target_desc_up): New typedef.
9701         * target-descriptions.c (target_desc_deleter::operator()): Rename
9702         from free_target_description.
9703         (make_cleanup_free_target_description): Remove.
9704
9705 2019-01-02  Tom Tromey  <tom@tromey.com>
9706
9707         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9708         constructor, destructor.
9709         (linespec_parser): Remove typedef.
9710         (~linespec_parser): Rename from linespec_parser_delete.
9711         (linespec_lex_to_end, linespec_complete_label)
9712         (linespec_complete): Update.
9713         (decode_line_full): Remove cleanups.
9714         (decode_line_1): Update.
9715
9716 2019-01-02  Tom Tromey  <tom@tromey.com>
9717
9718         * python/python-internal.h (inferior_to_inferior_object): Change
9719         return type.
9720         * python/py-exitedevent.c (create_exited_event_object): Update.
9721         * python/py-inferior.c (inferior_to_inferior_object): Return
9722         gdbpy_ref.
9723         (python_new_inferior, python_inferior_deleted)
9724         (thread_to_thread_object, delete_thread_object)
9725         (build_inferior_list, gdbpy_selected_inferior): Update.
9726         * python/py-infthread.c (create_thread_object): Update.  Also fail
9727         if inferior_to_inferior_object fails.
9728
9729 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9730
9731         * inferior.h (class inferior) <displaced_step_state>: New field.
9732         * infrun.h (struct displaced_step_state): Move here from
9733         infrun.c.  Initialize fields, add constructor.
9734         <inf>: Remove field.
9735         <reset>: New method.
9736         * infrun.c (struct displaced_step_inferior_state): Move to
9737         infrun.h.
9738         (displaced_step_inferior_states): Remove.
9739         (get_displaced_stepping_state): Adust.
9740         (displaced_step_in_progress_any_inferior): Adjust.
9741         (displaced_step_in_progress_thread): Adjust.
9742         (displaced_step_in_progress): Adjust.
9743         (add_displaced_stepping_state): Remove.
9744         (get_displaced_step_closure_by_addr): Adjust.
9745         (remove_displaced_stepping_state): Remove.
9746         (infrun_inferior_exit): Call displaced_step_state.reset.
9747         (use_displaced_stepping): Don't check for NULL.
9748         (displaced_step_prepare_throw): Call
9749         get_displaced_stepping_state.
9750         (displaced_step_fixup): Don't check for NULL.
9751         (prepare_for_detach): Don't check for NULL.
9752
9753 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9754
9755         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9756          in case of call that did not complete.
9757
9758 2019-01-02  Andrey Utkin  <autkin@undo.io>
9759
9760         * symfile.c (find_separate_debug_file): Fix search of debug files for
9761         remote debuggee.
9762
9763 2019-01-02  Tom Tromey  <tom@tromey.com>
9764
9765         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9766         indentation.
9767         * python/py-frame.c (frapy_older): Remove cast.
9768         (frapy_newer): Likewise.
9769         * python/py-breakpoint.c (local_setattro): Remove cast.
9770         * python/py-arch.c (archpy_name): Remove local variable.
9771         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9772
9773 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9774
9775         * unittests/basic_string_view/element_access/char/empty.cc:
9776         Fix year range in copyright header.
9777
9778 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9779
9780         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9781         Delete.
9782         <operator==>: Update with for removed field.
9783         <hash>: Likewise.
9784         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9785         <isa_features>: ...this.
9786         <abi_features>: New field.
9787         (riscv_isa_flen): Update comment.
9788         (riscv_abi_xlen): New declaration.
9789         (riscv_abi_flen): New declaration.
9790         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9791         isa_features.
9792         (riscv_abi_xlen): New function.
9793         (riscv_isa_flen): Update to get answer from isa_features.
9794         (riscv_abi_flen): New function.
9795         (riscv_has_fp_abi): Update to get answer from abi_features.
9796         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9797         xlen and flen.
9798         (riscv_call_info) <xlen, flen>: Update comment.
9799         (riscv_call_arg_struct): Remove invalid assertions
9800         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9801         is removed.
9802         (riscv_gdbarch_init): Gather isa features and abi features
9803         separately, ensure both match on the gdbarch when reusing an old
9804         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9805         a target with 64-bit float hardware.
9806
9807 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9808
9809         * source.c (search_command_helper): Stop reverse search
9810         when line 1 has been searched.
9811
9812 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9813
9814         * record-full.c (record_full_base_target::close): Rewrite
9815         record_full_core_buf_list free logic.
9816
9817 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9818
9819         * break-catch-syscall.c (print_one_catch_syscall): xfree
9820         the last text.
9821
9822 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9823
9824         * top.c (print_gdb_version): Update Copyright year in version
9825         message.
9826
9827 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9828
9829         Update copyright year range in all GDB files.
9830
9831 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9832
9833         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9834
9835 For older changes see ChangeLog-2018.
9836 \f
9837 Local Variables:
9838 mode: change-log
9839 left-margin: 8
9840 fill-column: 74
9841 version-control: never
9842 coding: utf-8
9843 End:
9844