gdb/ChangeLog

   1 2019-06-19  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (tui_init_content_element): Don't declare.
   4
   5 2019-06-19  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-data.h (tui_init_win_info): Don't declare.
   8
   9 2019-06-19  Tom de Vries  <tdevries@suse.de>
  10
  11         * dwarf2read.h (abstract_to_concrete): Change type to
  12         std::unordered_map<sect_offset, std::vector<sect_offset>,
  13         gdb::hash_enum<sect_offset>>.
  14
  15 2019-06-19  Tom Tromey  <tromey@adacore.com>
  16
  17         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  18         EVAL_AVOID_SIDE_EFFECTS specially.
  19
  20 2019-06-19  Tom Tromey  <tromey@adacore.com>
  21
  22         * source-cache.c (highlighter): New global.
  23         (source_cache::get_source_lines): Create a highlighter on demand.
  24
  25 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  26
  27         * defs.h (deprecated_interactive_hook): Delete declaration.
  28         * interps.c (clear_interpreter_hooks): Remove use of
  29         deprecated_interactive_hook.
  30         * top.c (deprecated_interactive_hook): Delete definition.
  31         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  32
  33 2019-06-18  Tom de Vries  <tdevries@suse.de>
  34
  35         PR gdb/24515
  36         * dwarf2read.h (abstract_to_concrete): Change type from
  37         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  38         std::unordered_map<sect_offset, std::vector<sect_offset>>.
  39         * dwarf2read.c (read_variable): Update.
  40         (dwarf2_fetch_die_loc_sect_off): Update.
  41
  42 2019-06-17  Tom de Vries  <tdevries@suse.de>
  43
  44         PR gdb/24617
  45         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
  46         accessing parent[parent_len - 1].
  47
  48 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
  49
  50         PR gdb/24364
  51         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
  52         call dtrace_process_dof with NULL dof.
  53
  54 2019-06-16  Tom de Vries  <tdevries@suse.de>
  55
  56         PR gdb/24445
  57         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
  58
  59 2019-06-16  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  62         (make_all_visible): Use address of member.
  63
  64 2019-06-16  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
  67         (tui_free_window, free_content, free_content_elements): Remove
  68         unnecessary cast.
  69         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
  70         cast.
  71         * tui/tui-regs.c (tui_show_register_group)
  72         (tui_display_registers_from, tui_display_reg_element_at_line):
  73         Remove unnecessary cast.
  74
  75 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
  76
  77         * linux-nat.c (normal_mask): Delete.
  78         (_initialize_linux_nat): Don't initialise normal_mask.
  79
  80 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
  81
  82         PR gdb/24445
  83         * dwarf-index-write.h (write_psymtabs_to_index): Add
  84         dwz_basename parameter.
  85         * dwarf-index-write.c (write_gdbindex): Move file writing to
  86         write_gdbindex_1.  Change return type void.
  87         (assert_file_size): Move up, remove filename parameter.
  88         (write_gdbindex_1): New function.
  89         (write_debug_names): Change return type to void, call
  90         assert_file_size.
  91         (struct index_wip_file): New struct.
  92         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
  93         file logic to index_wip_file.  Write index for dwz file if
  94         needed.
  95         (save_gdb_index_command): Pass basename of dwz file, if present.
  96         * dwarf-index-cache.c (index_cache::store): Obtain and pass
  97         build-id of dwz file, if present.
  98         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
  99         (dwarf2_get_dwz_file): Likewise.
 100         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 101         (dwarf2_get_dwz_file): Likewise.
 102
 103 2019-06-16  Tom Tromey  <tom@tromey.com>
 104
 105         * coffread.c (process_coff_symbol): Use xstrdup.
 106         * value.c (create_internalvar): Use xstrdup.
 107
 108 2019-06-16  Tom Tromey  <tom@tromey.com>
 109
 110         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 111         * breakpoint.c (stopin_command, stopat_command)
 112         (until_break_command, decode_location_default): Remove unnecessary
 113         cast.
 114         * utils.c (subset_compare): Remove unnecessary cast.
 115         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 116         cast.
 117         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 118         cast.
 119         * infcmd.c (path_command): Remove unnecessary cast.
 120         * coffread.c (decode_type): Remove unnecessary cast.
 121         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 122         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 123         * tui/tui-stack.c (tui_show_locator_content)
 124         (tui_show_frame_info): Remove unnecessary cast.
 125         * tui/tui-win.c (tui_scroll_forward_command)
 126         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 127         (parse_scrolling_args): Remove unnecessary cast.
 128         * tui/tui-data.c (init_win_info, tui_del_window)
 129         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 130         (free_content_elements): Remove unnecessary cast.
 131         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 132         unnecessary cast.
 133         * tui/tui-source.c (tui_set_source_content)
 134         (tui_vertical_source_scroll): Remove unnecessary cast.
 135         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 136         cast.
 137         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 138         * tui/tui-regs.c (tui_display_registers_from)
 139         (tui_display_register): Remove unnecessary cast.
 140         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 141         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 142         (make_visible): Remove unnecessary cast.
 143         * tui/tui-winsource.c (tui_erase_source_content)
 144         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 145         unnecessary cast.
 146         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 147         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 148         * stabsread.c (read_type, read_array_type, read_range_type):
 149         Remove unnecessary cast.
 150         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 151         (parse_symbol, parse_type, upgrade_type, parse_external)
 152         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 153         unnecessary cast.
 154         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 155
 156 2019-06-16  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-data.c (tui_alloc_generic_win_info)
 159         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 160         checks.
 161
 162 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 163             Andrew Burgess  <andrew.burgess@embecosm.com>
 164
 165         * f-typeprint.c (f_print_type): Don't return early for not
 166         associated or not allocated types.
 167         (f_type_print_varspec_suffix): Add print_rank parameter and print
 168         ranks of array types in case they dangling.
 169         (f_type_print_base): Add print_rank parameter.
 170
 171 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 172
 173         * NEWS: Mention new MI commands.
 174         * break-catch-throw.c (enum exception_event_kind): Move to
 175         breakpoint.h.
 176         (print_mention_exception_catchpoint): Output text as a single
 177         message.
 178         (catch_exception_command_1): Rename to...
 179         (catch_exception_event): ...this, make non-static, update header
 180         command, and change some parameter types.
 181         (catch_catch_command): Update for changes to
 182         catch_exception_command_1.
 183         (catch_throw_command): Likewise.
 184         (catch_rethrow_command): Likewise.
 185         * breakpoint.c (enum exception_event_kind): Delete.
 186         * breakpoint.h (enum exception_event_kind): Moved here from
 187         break-catch-throw.c.
 188         (catch_exception_event): Declare.
 189         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 190         (mi_cmd_catch_throw): New function.
 191         (mi_cmd_catch_rethrow): New function.
 192         (mi_cmd_catch_catch): New function.
 193         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 194         'catch-catch' entries.
 195         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 196         (mi_cmd_catch_rethrow): Declare.
 197         (mi_cmd_catch_catch): Declare.
 198
 199 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 200
 201         * annotate.c (annotate_source_line): Change return type to void,
 202         update implementation to match.
 203         * annotate.h (annotate_source_line): Change return type to void,
 204         update header comment.
 205         * stack.c (print_frame_info): Don't change what frame information
 206         is printed based on whether annotations are on or not.
 207
 208 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 209
 210         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 211         (annotate_source): Make static.
 212         (annotate_source_line): Moved from source.c and renamed from
 213         identify_source_line.  Update the return type.
 214         * annotate.h (annotate_source): Delete declaration.
 215         (annotate_source_line): Declaration moved from source.h, and
 216         renamed from identify_source_line.  Return type updated.
 217         * source.c (identify_source_line): Moved to annotate.c and renamed
 218         to annotate_source_line.
 219         (info_line_command): Remove check of annotation_level.
 220         * source.h (identify_source_line): Move declaration to annotate.h
 221         and rename to annotate_source_line.
 222         * stack.c: Add 'annotate.h' include.
 223         (print_frame_info): Remove check of annotation_level before
 224         calling annotate_source_line.
 225
 226 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 227
 228         * source-cache.c (source_cache::get_plain_source_lines): Use
 229         open_source_file_with_line_charpos instead of just
 230         open_source_file, remove call to find_source_lines.
 231         (source_cache::get_source_lines): Likewise.
 232         * source.c (find_source_lines): Make static.
 233         (get_filename_and_charpos): Renamed into...
 234         (open_source_file_with_line_charpos): ..this along with changes to
 235         return a scoped_fd, and some other minor clean ups.
 236         (identify_source_line): Use open_source_file_with_line_charpos.
 237         (search_command_helper): Use open_source_file_with_line_charpos
 238         instead of just open_source_file, remove call to
 239         find_source_lines.
 240         * source.h (open_source_file_with_line_charpos): Declare new
 241         function.
 242         (find_source_lines): Delete declaration.
 243
 244 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 245
 246         * source.c (get_filename_and_charpos): Remove fullname
 247         parameter.
 248         (identify_source_line): Update call to get_filename_and_charpos.
 249
 250 2019-06-14  Tom Tromey  <tromey@adacore.com>
 251
 252         PR gdb/24502:
 253         * ui-style.h (skip_ansi_escape): Update comment.
 254         * ui-file.h (class no_terminal_escape_file): New class.
 255         * ui-file.c (no_terminal_escape_file::write)
 256         (no_terminal_escape_file::puts): New methods.
 257         * cli/cli-logging.c (handle_redirections): Use
 258         no_terminal_escape_file.
 259
 260 2019-06-14  Tom Tromey  <tromey@adacore.com>
 261
 262         * NEWS: Move convenience variable news above Python news.
 263
 264 2019-06-14  Tom Tromey  <tom@tromey.com>
 265
 266         * gnulib: Move directory to top-level.
 267         * configure.ac: Don't configure gnulib.
 268         * configure: Rebuild.
 269         * common/common-defs.h: Use new path to gnulib.
 270         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 271         (GNULIB_H): Remove.
 272         (INCGNU): Look in new gnulib location.
 273         (HFILES_NO_SRCDIR): Remove gnulib files.
 274         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 275         (generated_files): Remove GNULIB_H.
 276         ($(LIBGNU), all-lib): Remove targets.
 277         (distclean): Don't mention GNULIB_BUILDDIR.
 278         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 279
 280 2019-06-14  Tom Tromey  <tromey@adacore.com>
 281
 282         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 283         Warn if symbol file does not provide any symbols.
 284
 285 2019-06-14  Tom Tromey  <tromey@adacore.com>
 286
 287         * source.c (find_and_open_source): Respect basenames_may_differ.
 288
 289 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 290
 291         * annotate.c (annotate_breakpoints_invalid): Make use of
 292         scoped_restore_terminal_state.
 293         (annotate_frames_invalid): Likewise.
 294
 295 2019-06-14  Tom Tromey  <tromey@adacore.com>
 296
 297         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 298         allow assignment to an internalvar.
 299
 300 2019-06-14  Tom Tromey  <tromey@adacore.com>
 301
 302         * ada-lex.l: Allow "_" in attribute names.
 303
 304 2019-06-14  Tom Tromey  <tromey@adacore.com>
 305
 306         PR gdb/24653:
 307         * regcache.c (registers_changed): Don't call alloca.
 308         * top.c (execute_command): Don't call alloca.
 309
 310 2019-06-13  Pedro Alves  <palves@redhat.com>
 311
 312         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 313         'expression'.  When parsing an expression, error out if there's
 314         junk after "unlimited".
 315         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 316         (do_set_command): Adjust calls to is_unlimited_literal.
 317
 318 2019-06-13  Pedro Alves  <palves@redhat.com>
 319
 320         * compile/compile.c (make_compile_options_def_group): Add braces
 321         around array_view initializer.
 322         * thread.c (make_thread_apply_all_options_def_group)
 323         (make_thread_apply_all_options_def_group): Likewise.
 324
 325 2019-06-13  Pedro Alves  <palves@redhat.com>
 326
 327         * NEWS (New commands): Mention "maint test-options
 328         require-delimiter", "maint test-options unknown-is-error", "maint
 329         test-options unknown-is-operand" and "maint show
 330         test-options-completion-result".
 331         (New command options, command completion): New section.
 332         (Completion improvements): New section.
 333         Mention that you can abbreviate "unlimited".
 334
 335 2019-06-13  Pedro Alves  <palves@redhat.com>
 336
 337         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 338         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 339         * unittests/cli-utils-selftests.c (test_parse_flags)
 340         (test_parse_flags_qcs): Delete.
 341         (test_cli_utils): Don't call deleted functions.
 342
 343 2019-06-13  Pedro Alves  <palves@redhat.com>
 344
 345         * thread.c: Include "cli/cli-option.h".
 346         (tp_array_compar_ascending): Global.
 347         (tp_array_compar): Delete function.
 348         (tp_array_compar_ascending, tp_array_compar_descending): New
 349         functions.
 350         (ascending_option_def, qcs_flag_option_def)
 351         (thr_qcs_flags_option_defs)
 352         (make_thread_apply_all_options_def_group)
 353         (make_thread_apply_options_def_group): New.
 354         (thread_apply_all_command): Use gdb::option::process_options.
 355         (thread_apply_command_completer)
 356         (thread_apply_all_command_completer): New.
 357         (thread_apply_command): Use gdb::option::process_options.
 358         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 359         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 360         to generate help text of "thread apply".  Adjust "taas"'s help.
 361         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 362         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 363
 364 2019-06-13  Pedro Alves  <palves@redhat.com>
 365
 366         * thread.c (thread_apply_command): Check for invalid TID with
 367         isdigit instead of !isalpha.
 368
 369 2019-06-13  Pedro Alves  <palves@redhat.com>
 370
 371         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 372         (validate_flags_qcs): New.
 373         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 374         (validate_flags_qcs): Declare.
 375         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 376         (make_frame_apply_options_def_group): New.
 377         (frame_apply_command_count): Process options with
 378         gdb::option::process_options.
 379         (frame_apply_completer): New.
 380         (frame_apply_level_completer, frame_apply_all_completer)
 381         (frame_apply_completer): New.
 382         (_initialize_stack): Update help of "frame apply", "frame apply
 383         level", "frame apply all" and "faas" to mention supported options
 384         and install command completers.
 385         * stack.h (frame_apply_all_completer): Declare.
 386         * thread.c: Include "stack.h".
 387         (tfaas_command): Add "--".
 388         (_initialize_thread): Update help "tfaas" to mention supported
 389         options and install command completer.
 390
 391 2019-06-13  Pedro Alves  <palves@redhat.com>
 392
 393         * completer.c (complete_nested_command_line): New.
 394         (gdb_completion_word_break_characters_throw): Add assertion.
 395         * completer.h (complete_nested_command_line): Declare.
 396
 397 2019-06-13  Pedro Alves  <palves@redhat.com>
 398
 399         * stack.c (parse_backtrace_qualifiers): New.
 400         (backtrace_command): Use it.
 401         (backtrace_command_completer): Complete on qualifiers.
 402
 403 2019-06-13  Pedro Alves  <palves@redhat.com>
 404
 405         * frame.c: Include "cli/cli-option.h.
 406         (user_set_backtrace_options): New.
 407         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 408         Delete.
 409         (get_prev_frame): Adjust.
 410         (boolean_option_def, uinteger_option_def)
 411         (set_backtrace_option_defs): New.
 412         (_initialize_frame): Adjust and use
 413         gdb::option::add_setshow_cmds_for_options to install "set
 414         backtrace past-main" and "set backtrace past-entry".
 415         * frame.h: Include "cli/cli-option.h".
 416         (struct frame_print_options): Forward declare.
 417         (print_frame_arguments_all, print_frame_arguments_scalars)
 418         (print_frame_arguments_none): Declare.
 419         (print_entry_values): Delete declaration.
 420         (struct frame_print_options, user_frame_print_options): New.
 421         (struct set_backtrace_options): New.
 422         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 423         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 424         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 425         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 426         (list_args_or_locals): Add frame_print_options parameter.
 427         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 428         * python/py-framefilter.c (enumerate_args): Pass down
 429         USER_FRAME_PRINT_OPTIONS.
 430         * stack.c: Include "cli/cli-option.h".
 431         (print_frame_arguments_all, print_frame_arguments_scalars)
 432         (print_frame_arguments_none): Declare.
 433         (print_raw_frame_arguments, print_entry_values): Delete.
 434         (user_frame_print_options): New.
 435         (boolean_option_def, enum_option_def, frame_print_option_defs):
 436         New.
 437         (struct backtrace_cmd_options): New.
 438         (bt_flag_option_def): New.
 439         (backtrace_command_option_defs): New.
 440         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 441         (print_frame_arg, read_frame_arg, print_frame_args)
 442         (print_frame_info, print_frame): Add frame_print_options parameter
 443         and use it.
 444         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 445         (backtrace_command_1): Add frame_print_options and
 446         backtrace_cmd_options parameters and use them.
 447         (make_backtrace_options_def_group): New.
 448         (backtrace_command): Process command options with
 449         gdb::option::process_options.
 450         (backtrace_command_completer): New.
 451         (_initialize_stack): Extend "backtrace"'s help to mention
 452         supported options.  Install completer for "backtrace".
 453         Install some settings commands with add_setshow_cmds_for_options.
 454
 455 2019-06-13  Pedro Alves  <palves@redhat.com>
 456
 457         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 458         and that "set/show print raw frame-arguments" are now deprecated.
 459
 460         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 461         command.
 462         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 463         * stack.c (_initialize_stack): Install "set/show print
 464         raw-frame-arguments", and deprecate "set/show print raw
 465         frame-arguments".
 466         * valprint.c (_initialize_valprint): Deprecate "set/show print
 467         raw".
 468
 469 2019-06-13  Pedro Alves  <palves@redhat.com>
 470
 471         * compile/compile.c (struct compile_options): New.
 472         (compile_flag_option_def, compile_command_option_defs)
 473         (make_compile_options_def_group): New.
 474         (compile_file_command): Handle options with
 475         gdb::option::process_options.
 476         (compile_file_command_completer): New function.
 477         (compile_code_command): Handle options with
 478         gdb::option::process_options.
 479         (compile_code_command_completer): New function.
 480         (_initialize_compiler): Install completers for "compile code" and
 481         "compile file".  Mention available options in "compile code" and
 482         "compile code"'s help.
 483         * completer.c (advance_to_completion_word): New, factored out from
 484         ...
 485         (advance_to_expression_complete_word_point): ... this.
 486         (advance_to_filename_complete_word_point): New.
 487         * completer.h (advance_to_filename_complete_word_point): New
 488         declaration.
 489
 490 2019-06-13  Pedro Alves  <palves@redhat.com>
 491
 492         * compile/compile.c: Include "cli/cli-option.h".
 493         (compile_print_value): Scope data pointer is now a
 494         value_print_options pointer; adjust.
 495         (compile_print_command): Process options.  Scope data pointer is
 496         now a value_print_options pointer; adjust.
 497         (_initialize_compile): Update "compile print"'s help to include
 498         supported options.  Install a completer for "compile print".
 499         * cp-valprint.c (show_vtblprint, show_objectprint)
 500         (show_static_field_print): Delete.
 501         (_initialize_cp_valprint): Don't install "set print
 502         static-members", "set print vtbl", "set print object" here.
 503         * printcmd.c: Include "cli/cli-option.h" and
 504         "common/gdb_optional.h".
 505         (print_command_parse_format): Rework to fill in a
 506         value_print_options instead of a format_data.
 507         (print_value): Change parameter type from format_data pointer to
 508         value_print_options reference.  Adjust.
 509         (print_command_1): Process options.  Adjust to pass down a
 510         value_print_options.
 511         (print_command_completer): New.
 512         (_initialize_printcmd): Install print_command_completer as
 513         handle_brkchars completer for the "print" command.  Update
 514         "print"'s help to include supported options.
 515         * valprint.c: Include "cli/cli-option.h".
 516         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 517         here from cp-valprint.c.
 518         (boolean_option_def, uinteger_option_def)
 519         (value_print_option_defs, make_value_print_options_def_group):
 520         New.  Use gdb::option::add_setshow_cmds_for_options to install
 521         "set print elements", "set print null-stop", "set print repeats",
 522         "set print pretty", "set print union", "set print array", "set
 523         print address", "set print symbol", "set print array-indexes".
 524         * valprint.h: Include <string> and "cli/cli-option.h".
 525         (make_value_print_options_def_group): Declare.
 526         (print_value): Change parameter type from format_data pointer to
 527         value_print_options reference.
 528         (print_command_completer): Declare.
 529
 530 2019-06-13  Pedro Alves  <palves@redhat.com>
 531
 532         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 533         (COMMON_SFILES): Add maint-test-settings.c.
 534         * cli/cli-decode.c (boolean_enums): New global, factored out from
 535         ...
 536         (add_setshow_boolean_cmd): ... here.
 537         * cli/cli-decode.h (boolean_enums): Declare.
 538         * cli/cli-option.c: New file.
 539         * cli/cli-option.h: New file.
 540         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 541         factored out from ...
 542         (parse_cli_boolean_value(const char *)): ... this.
 543         (is_unlimited_literal): Change parameter type to pointer to
 544         pointer.  Adjust and advance ARG pointer.
 545         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 546         (parse_cli_var_enum): New, factored out from ...
 547         (do_set_command): ... this.  Adjust.
 548         * cli/cli-setshow.h (parse_cli_boolean_value)
 549         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 550         (parse_cli_var_enum): Declare.
 551         * cli/cli-utils.c: Include "cli/cli-option.h".
 552         (get_ulongest): New.
 553         * cli/cli-utils.h (get_ulongest): Declare.
 554         (check_for_argument): New overloads.
 555         * maint-test-options.c: New file.
 556
 557 2019-06-13  Pedro Alves  <palves@redhat.com>
 558
 559         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 560         parse a range if "-" is at the end of the string.
 561
 562 2019-06-13  Pedro Alves  <palves@redhat.com>
 563
 564         * cli/cli-setshow.c (parse_auto_binary_operation)
 565         (parse_cli_boolean_value): Don't allow "o".
 566
 567 2019-06-13  Pedro Alves  <palves@redhat.com>
 568
 569         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 570         * NEWS: Mention maint test-settings KIND.
 571         * maint-test-settings.c: New file.
 572
 573 2019-06-13  Pedro Alves  <palves@redhat.com>
 574
 575         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 576         completer.
 577         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 578         "set" completers.
 579
 580 2019-06-13  Pedro Alves  <palves@redhat.com>
 581
 582         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 583         after item.
 584
 585 2019-06-13  Pedro Alves  <palves@redhat.com>
 586
 587         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 588
 589 2019-06-13  Pedro Alves <palves@redhat.com>
 590
 591         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 592         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 593         call.
 594         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 595         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 596         calls.
 597         (check_for_argument): Skip spaces after argument.
 598
 599 2019-06-13  Pedro Alves  <palves@redhat.com>
 600
 601         * thread.c (thread_apply_command): Adjust TID parsing.
 602         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 603         detected before end of string.
 604         (tid_is_in_list): Error out if LIST is invalid.
 605
 606 2019-06-13  Pedro Alves  <palves@redhat.com>
 607
 608         * completer.c (complete_line_internal_1): Rewind completion word
 609         point.
 610         (completion_tracker::advance_custom_word_point_by): Change
 611         parameter type to int.
 612         * completer.h (completion_tracker::advance_custom_word_point_by):
 613         Likewise.
 614
 615 2019-06-13  Pedro Alves  <palves@redhat.com>
 616
 617         * completer.c (advance_to_completion_word): Handle delimiters.
 618
 619 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 620
 621         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 622
 623 2019-06-11  Tom Tromey  <tom@tromey.com>
 624
 625         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 626         (xmalloc_failed): Move to alloc.c.
 627         * alloc.c: New file.
 628         * Makefile.in (COMMON_SFILES): Add alloc.c.
 629
 630 2019-06-11  Tom Tromey  <tom@tromey.com>
 631
 632         * nat/linux-waitpid.c: Don't include server.h.
 633         (linux_debug): Remove.
 634         (my_waitpid): Update.
 635
 636 2019-06-11  Tom Tromey  <tromey@adacore.com>
 637
 638         * infcall.c (_initialize_infcall): Remove trailing newline from
 639         help.
 640         * user-regs.c (_initialize_user_regs): Remove trailing newline
 641         from help.
 642         * typeprint.c (_initialize_typeprint): Remove trailing newline
 643         from help.
 644         * reverse.c (_initialize_reverse): Remove trailing newlines from
 645         help.
 646         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 647         from help.
 648         * language.c (add_set_language_command): Remove trailing newline
 649         from help.
 650         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 651         help.
 652         * disasm.c (_initialize_disasm): Remove trailing newline from
 653         help.
 654         * top.c (init_main): Remove trailing newline from help.
 655         * interps.c (_initialize_interpreter): Remove trailing newline
 656         from help.
 657         * btrace.c (_initialize_btrace): Remove trailing newlines from
 658         help.
 659         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 660         from help.
 661         * python/python.c (_initialize_python): Remove trailing newline
 662         from help.
 663         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 664         help.
 665         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 666         from help.  Reformat some text.
 667         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 668         from help.
 669         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 670         newline from help.
 671
 672 2019-06-11  Tom Tromey  <tromey@adacore.com>
 673
 674         * darwin-nat.c (darwin_decode_exception_message)
 675         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 676
 677 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 678
 679         * valops.c (value_slice): Check for not allocated or not
 680         associated values.
 681
 682 2019-06-10  Tom de Vries  <tdevries@suse.de>
 683
 684         PR gdb/24618
 685         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 686         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 687         invalid.
 688
 689 2019-06-10  Tom de Vries  <tdevries@suse.de>
 690
 691         PR gdb/24611
 692         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 693         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 694
 695 2019-06-10  Tom de Vries  <tdevries@suse.de>
 696
 697         PR symtab/24545
 698         * symtab.c (struct demangled_name_entry): Add language field.
 699         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 700         static minimal symbol".  Set and use language field.
 701
 702 2019-06-10  Tom Tromey  <tromey@adacore.com>
 703
 704         * ada-lang.c (_initialize_ada_language): Update help text.
 705
 706 2019-06-10  Tom Tromey  <tromey@adacore.com>
 707
 708         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 709         with a newline.
 710         * guile/guile.c (handle_boot_error): Don't end warning with a
 711         newline.
 712         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 713         warning with a newline.
 714         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 715         newline.
 716         (s12z_frame_cache): Likewise.
 717         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 718         a newline.
 719         * solib-svr4.c (disable_probes_interface): Don't end warning with
 720         a newline.
 721         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 722         newline.
 723         * python/python.c (do_finish_initialization): Don't end warning
 724         with a newline.
 725
 726 2019-06-10  Tom Tromey  <tom@tromey.com>
 727
 728         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 729         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 730         gdbpy_enter.
 731
 732 2019-06-10  Tom Tromey  <tromey@adacore.com>
 733
 734         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 735         data.
 736         (elf_new_init): Don't call stabsread_new_init.
 737         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 738         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 739         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 740
 741 2019-06-10  Tom de Vries  <tdevries@suse.de>
 742
 743         PR symtab/16264
 744         PR symtab/24517
 745         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 746
 747 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 748
 749         * source.c (find_and_open_source): Also rewrite relative file
 750         names.
 751
 752 2019-04-26  Amos Bird  <amosbird@gmail.com>
 753
 754         * annotate.c (annotate_thread_exited): Add "thread-exited"
 755         annotation.
 756
 757 2019-06-06  Tom Tromey  <tromey@adacore.com>
 758
 759         * maint.h (class scoped_command_stats): Use
 760         DISABLE_COPY_AND_ASSIGN.
 761         <print_time>: New method.
 762         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 763         print_time.
 764         (scoped_command_stats::print_time): New method.
 765
 766 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 769         instructions of lengths 6 or 8 bytes.
 770
 771 2019-06-04  Pedro Alves  <palves@redhat.com>
 772
 773         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 774
 775         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 776         * breakpoint.c (condition_completer): Likewise.
 777         * cli/cli-dump.c (scan_expression): Likewise.
 778         * common/filestuff.c (mkdir_recursive): Likewise.
 779         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 780         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 781         (gdb_abspath): Likewise.
 782         * compile/compile-cplus-types.c
 783         (compile_cplus_instance::decl_name): Likewise.
 784         * completer.c (complete_explicit_location):
 785         (signal_completer, reg_or_group_completer_1): Likewise.
 786         * cp-support.c (cp_remove_params_if_any): Likewise.
 787         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 788         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 789         * infcmd.c (strip_bg_char): Likewise.
 790         * linespec.c (copy_token_string): Likewise.
 791         * mi/mi-main.c (output_cores): Likewise.
 792         * psymtab.c (psymtab_search_name):
 793         * symfile.c (test_set_ext_lang_command): Likewise.
 794         * target.c (target_fileio_read_stralloc): Likewise.
 795         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 796         * value.c (complete_internalvar): Likewise.
 797
 798 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 799
 800         Add objfile property to gdb.Type.
 801         * NEWS: Mention Python API addition.
 802         * python/py-type.c (typy_get_objfile): New method.
 803
 804 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 805
 806         * NEWS: Mention the new set|show style [title|highlight].
 807         Mention changes to "show style", "help" and "apropos".
 808
 809 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 810
 811         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 812         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 813         instead of print_help_for_command.
 814         (print_doc_of_command): New function.
 815         (help_list): Add 'apropos -v word' suggestion.
 816         (print_help_for_command): Style the command name using title style.
 817         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 818         (_initialize_cli_cmds): Describe -v in apropos_command help.
 819
 820 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 821
 822         * cli/cli-style.h (cli_style_option): Add name in constructor,
 823         add m_name class member, add constructor with intensity,
 824         add name class function.
 825         (cli_style_option::add_setshow_commands): Remove name argument.
 826         (highlight_style, title_style): New styles.
 827         * cli/cli-style.c (do_show): New function that shows a style
 828         characteristic styling the style name with itself.
 829         (set_style_name): New function.
 830         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 831         Update all callers according to the changes in cli/cli-style.h.
 832         * utils.h (fputs_highlighted): New function.
 833         * utils.c (fputs_highlighted): Likewise.
 834
 835 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 836
 837         * NEWS: Mention new pipe command and new convenience variables.
 838
 839 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 840
 841         * cli/cli-cmds.c (pipe_command): New function.
 842         (_initialize_cli_cmds): Call add_com for pipe_command.
 843         Define | as an alias for pipe.
 844         (exit_status_set_internal_vars): New function.
 845         (shell_escape): Call exit_status_set_internal_vars.
 846         cli/cli-decode.c (find_command_name_length): Recognize | as
 847         a single character command.
 848
 849 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 850
 851         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 852         top.c (execute_command_to_ui_file): New function, mostly a copy
 853         of execute_command_to_string.
 854         (execute_command_to_string): Implement by calling
 855         execute_command_to_ui_file.
 856
 857 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 858
 859         * top.h (saved_command_line): Remove declaration.
 860         * top.c (previous_saved_command_line, previous_repeat_arguments):
 861         New variables.
 862         (saved_command_line): Make static, define together with other
 863         'repeat variables'.
 864         (dont_repeat): Clear repeat_arguments.
 865         (repeat_previous, get_saved_command_line, save_command_line):
 866         New functions.
 867         (gdb_init): Initialize saved_command_line
 868         and previous_saved_command_line.
 869         * main.c (captured_main_1): Remove saved_command_line initialization.
 870         * event-top.c (handle_line_of_input): Update to use
 871         the new 'repeat' related functions instead of direct access to
 872         saved_command_line.
 873         * command.h (repeat_previous, get_saved_command_line,
 874         save_command_line): New declarations.
 875         (dont_repeat): Add comment.
 876
 877 2019-05-30  Tom Tromey  <tromey@adacore.com>
 878
 879         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 880         Fix comment.
 881         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 882
 883 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 884
 885         PR cli/24587
 886         * completer.c (complete): Initialize variable word.
 887
 888 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 889
 890         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 891         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 892         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 893         'body' is NULL to the outter 'if', protecting the '!is_define'
 894         situation as well.
 895
 896 2019-05-29  Tom Tromey  <tromey@adacore.com>
 897
 898         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 899         (dwarf_unknown): New function.
 900         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 901         (dwarf_type_encoding_name): Use dwarf_unknown.
 902
 903 2019-05-29  Tom Tromey  <tromey@adacore.com>
 904
 905         PR c++/20020:
 906         * cp-valprint.c (cp_print_value_fields): Call
 907         cp_print_static_field inside "try".
 908
 909 2019-05-29  Tom Tromey  <tromey@adacore.com>
 910
 911         * inflow.c (struct terminal_info): Add default operator=.
 912         * configure: Rebuild.
 913         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 914         -Wdeprecated-copy-dtor, -Wredundant-move.
 915
 916 2019-05-29  Tom Tromey  <tromey@adacore.com>
 917
 918         * NEWS: Add entry.
 919         * infcmd.c (print_return_value_1): Handle finish_print
 920         option.
 921         (show_print_finish): New function.
 922         (_initialize_infcmd): Add "set/show print finish" commands.
 923         * valprint.c (user_print_options): Initialize new member.
 924         * valprint.h (struct value_print_options) <finish_print>: New
 925         member.
 926
 927 2019-05-28  Tom Tromey  <tromey@adacore.com>
 928
 929         * ada-lang.c (ada_remove_Xbn_suffix)
 930         (find_old_style_renaming_symbol)
 931         (parse_old_style_renaming): Remove.
 932         (ada_find_renaming_symbol): Don't call
 933         find_old_style_renaming_symbol.
 934         (ada_is_renaming_symbol): Rename from
 935         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 936         bool.  Now static.
 937         (ada_read_var_value): Update and simplify.
 938         * ada-exp.y (write_var_or_type): Remove old code.
 939
 940 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 941
 942         * event-top.c: Remove include comment.
 943         * inflow.c (class scoped_ignore_sigttou): Move from here...
 944         * inflow.h (class scoped_ignore_sigttou): ...to here.
 945         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 946         * top.c:  Remove include comment.
 947
 948 2019-05-27  Tom Tromey  <tom@tromey.com>
 949
 950         * NEWS: Fix typo.
 951
 952 2019-05-22  Tom Tromey  <tromey@adacore.com>
 953
 954         * target.c (target_follow_exec): Constify parameter.
 955         * target-delegates.c: Rebuild.
 956         * remote.c (remote_target::follow_exec): Constify parameter.
 957         * infrun.c (follow_exec): Constify parameter.
 958         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 959         (target_follow_exec): Likewise.
 960
 961 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 962
 963         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 964         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 965
 966 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 967
 968         * NEWS: Add debugredirect and testsuite sections.
 969
 970 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 971
 972         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 973         target descriptions using exclusively floating point register name
 974         aliases.
 975
 976 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 977
 978         PR gdb/18644:
 979         * f-lang.c (build_fortran_types): Handle the case where
 980         gdbarch_floatformat_for_type returns a nullptr.
 981
 982 2019-05-21  Tom de Vries  <tdevries@suse.de>
 983
 984         PR cli/24587
 985         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 986
 987 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 988
 989         PR gdb/18644:
 990         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 991         16-byte floats.
 992         * i386-tdep.c (i386_floatformat_for_type): Use
 993         floatformats_ia64_quad for the 16-byte floating point component
 994         within a fortran 32-byte complex number.
 995
 996 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 999         delete default constructor.
1000         (find_partial_die): Update to return const struct.
1001         (partial_die_parent_scope): Move variable declaration into scope
1002         of its use and change its type to auto.
1003         (guess_partial_die_structure_name): Likewise.
1004         (partial_die_info::fixup): Likewise.
1005
1006 2019-05-17  Tom Tromey  <tromey@adacore.com>
1007
1008         * source.c (find_and_open_source): Remove cast.
1009
1010 2019-05-17  Tom Tromey  <tromey@adacore.com>
1011
1012         * annotate.c (annotate_source): Make "filename" const.
1013         * annotate.h (annotate_source): Use const.
1014
1015 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1016
1017         * disasm.c (set_disassembler_options): Send errors to stderr.
1018
1019 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1020
1021         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1022         (cli_interp_base::set_logging): Check debug_redirect.
1023         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1024         * cli/cli-logging.c (debug_redirect): Add static variable.
1025         (pop_output_files): Add default param.
1026         (handle_redirections): Print debug setting.
1027         (show_logging_command): Likewise.
1028         (_initialize_cli_logging): Add debugredirect command.
1029         * interps.c (current_interp_set_logging): Add debug_redirect
1030         parameter.
1031         * interps.h (set_logging): Add debug_redirect parameter.
1032         (current_interp_set_logging): Likewise.
1033         * mi/mi-common.h: Likewise.
1034         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1035
1036 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1037             Tom Tromey  <tromey@adacore.com>
1038
1039         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1040         directly.
1041         * cli/cli-interp.h (make_logging_output): Remove declaration.
1042         * cli/cli-logging.c (make_logging_output): Remove function.
1043         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1044         directly.
1045         * ui-file.c (tee_file::tee_file): Remove bools.
1046         (tee_file::~tee_file): Remove deletes.
1047         * ui-file.h (tee_file): Remove bools.
1048
1049 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1050
1051         * mi/mi-cmds.h (mi_cmd_complete): New function.
1052         * mi/mi-main.c (mi_cmd_complete): Likewise.
1053         * mi/mi-cmds.c: Define new MI command -complete.
1054         * NEWS: Mention new -complete command.
1055
1056 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1057
1058         * completer.h (complete): New function.
1059         * completer.c (complete): Likewise.
1060         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1061         function defined in completer.h.
1062
1063 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1064
1065         * MAINTAINERS (Write After Approval): Add myself.
1066
1067 2019-05-17  Tom de Vries  <tdevries@suse.de>
1068
1069         PR gdb/24094
1070         * dwarf2read.c (struct cu_partial_die_info): New struct.
1071         (find_partial_die): Return cu_partial_die_info.
1072         (partial_die_parent_scope, guess_partial_die_structure_name)
1073         (partial_die_info::fixup): Handle new return type of find_partial_die.
1074
1075 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1076
1077         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1078         "std::string", simplifying the algorithm.
1079
1080 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1081
1082         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1083         (stap_static_probe_ops::get_probes): Likewise.
1084
1085 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1086
1087         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1088         '-')" and "else if".
1089         (stap_parse_single_operand): Join checks for
1090         "gdbarch_stap_parse_special_token_p" and
1091         "gdbarch_stap_parse_special_token" in the same "if" statement.
1092         Invert check when verifying for operation on register
1093         displacement.
1094
1095 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1096
1097         * stap-probe.c (stap_get_opcode): Update comment.
1098         (stap_get_expected_argument_type): Likewise.
1099         (handle_stap_probe): Likewise.
1100
1101 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1102
1103         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1104         return type to 'bool'.  Adjust comment.  Use 'bool' when
1105         appropriate.
1106         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1107         * stap-probe.c (stap_parse_argument_1): Likewise.
1108         (stap_is_operator): Likewise.
1109         (stap_is_generic_prefix): Likewise.
1110         (stap_is_register_prefix): Likewise.
1111         (stap_is_register_indirection_prefix): Likewise.
1112         (stap_is_integer_prefix): Likewise.
1113         (stap_generic_check_suffix): Likewise.
1114         (stap_check_integer_suffix): Likewise.
1115         (stap_check_register_suffix): Likewise.
1116         (stap_check_register_indirection_suffix): Likewise.
1117         (stap_parse_register_operand): Likewise.
1118         (stap_parse_single_operand): Likewise.
1119         (stap_parse_argument_1): Likewise.
1120         (stap_probe::get_argument_count): Likewise.
1121         (stap_is_operator): Likewise.
1122
1123 2019-05-16  Tom Tromey  <tromey@adacore.com>
1124
1125         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1126         keyword to foreach.
1127
1128 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1129
1130         * linux-thread-db.c (try_thread_db_load_1): Change return type
1131         to bool.
1132         (try_thread_db_load): Likewise.
1133         (try_thread_db_load_from_pdir_1): Likewise.
1134         (try_thread_db_load_from_pdir): Likewise.
1135         (try_thread_db_load_from_sdir): Likewise.
1136         (try_thread_db_load_from_dir): Likewise.
1137         (thread_db_load_search): Likewise.
1138         (has_libpthread): Likewise.
1139         (thread_db_load): Likewise.
1140
1141 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1142
1143         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1144         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1145         NULL, and complain/return if that's the case.
1146
1147 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1148
1149         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1150         (advance, posn, abstract_read_memory): New functions.
1151         [struct mem_read_abstraction]: New struct.
1152         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1153
1154 2019-05-14  Tom Tromey  <tromey@adacore.com>
1155
1156         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1157         value is not lval_memory.
1158
1159 2019-05-14  Tom Tromey  <tromey@adacore.com>
1160
1161         * solib.c (info_sharedlibrary_command): Style the file name.
1162
1163 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1164
1165         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1166         (aarch64_vnv_type): Likewise.
1167         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1168         * common/tdesc.c: Likewise.
1169         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1170         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1171         * features/aarch64-fpu.xml: Add ieee half view.
1172         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1173         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1174         * gdbtypes.h (struct builtin_type): Likewise.
1175         (struct objfile_type): Likewise.
1176
1177 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1178
1179         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1180         typo.
1181         * location.h (string_to_event_location): Likewise.
1182
1183 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1184
1185         GDB 8.3 released.
1186
1187 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1188
1189         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1190         New variable declaration.
1191         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1192         New variable.
1193         (print_one_breakpoint): Use ui_out::test_flags and new global
1194         variable to compute use_fixed_output.
1195         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1196         Remove.
1197         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1198         (mi_multi_location_breakpoint_output_fixed): Remove.
1199         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1200         new variable.
1201         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1202         fix_multi_location_breakpoint_output flag if version >= 3.
1203         * ui-out.h (enum ui_out_flag)
1204         <fix_multi_location_breakpoint_output>: New enumerator.
1205
1206 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1207
1208         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1209
1210 2019-05-10  Tom Tromey  <tromey@adacore.com>
1211
1212         * ada-lang.c (catch_ada_completer): New function.
1213         (_initialize_ada_language): Use it.
1214
1215 2019-05-10  Tom Tromey  <tromey@adacore.com>
1216
1217         * thread.c (print_thread_info): Make "requested_threads" const.
1218         * gdbthread.h (print_thread_info): Make "requested_threads"
1219         const.
1220         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1221         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1222
1223 2019-05-08  Tom Tromey  <tom@tromey.com>
1224
1225         * gdbtypes.c (objfile_type_data): Change type.
1226         (objfile_type, _initialize_gdbtypes): Update.
1227
1228 2019-05-08  Tom Tromey  <tom@tromey.com>
1229
1230         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1231         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1232         (_initialize_dwarf2_frame): Update.
1233
1234 2019-05-08  Tom Tromey  <tom@tromey.com>
1235
1236         * objc-lang.c (objc_objfile_data): Change type.
1237         (find_methods): Update.
1238         (_initialize_objc_lang): Remove.
1239
1240 2019-05-08  Tom Tromey  <tom@tromey.com>
1241
1242         * stabsread.c (rs6000_builtin_type_data): Change type.
1243         (rs6000_builtin_type, _initialize_stabsread): Update.
1244
1245 2019-05-08  Tom Tromey  <tom@tromey.com>
1246
1247         * mips-tdep.c (mips_pdr_data): Remove.
1248         (_initialize_mips_tdep): Update.
1249
1250 2019-05-08  Tom Tromey  <tom@tromey.com>
1251
1252         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1253         (hppa_init_objfile_priv_data, read_unwind_info)
1254         (find_unwind_entry, _initialize_hppa_tdep): Update.
1255
1256 2019-05-08  Tom Tromey  <tom@tromey.com>
1257
1258         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1259         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1260         on obstack.
1261         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1262
1263 2019-05-08  Tom Tromey  <tom@tromey.com>
1264
1265         * mdebugread.c (basic_type_data): Change type.
1266         (basic_type, _initialize_mdebugread): Update.
1267
1268 2019-05-08  Tom Tromey  <tom@tromey.com>
1269
1270         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1271
1272 2019-05-08  Tom Tromey  <tom@tromey.com>
1273
1274         * nto-tdep.c (nto_inferior_data_reg): Change type.
1275         (nto_inferior_data): Update.
1276         (nto_inferior_data_cleanup, nto_new_inferior_data)
1277         (_initialize_nto_tdep): Remove.
1278         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1279
1280 2019-05-08  Tom Tromey  <tom@tromey.com>
1281
1282         * ada-lang.c (struct ada_inferior_data): Add initializers.
1283         (ada_inferior_data): Change type.
1284         (ada_inferior_data_cleanup): Remove.
1285         (get_ada_inferior_data, ada_inferior_exit)
1286         (struct ada_pspace_data): Add initializers, destructor.
1287         (ada_pspace_data_handle): Change type.
1288         (get_ada_pspace_data): Update.
1289         (ada_pspace_data_cleanup): Remove.
1290
1291 2019-05-08  Tom Tromey  <tom@tromey.com>
1292
1293         * coffread.c (struct coff_symfile_info): Add initializers.
1294         (coff_objfile_data_key): Move lower.  Change type.
1295         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1296         Update.
1297         (coff_free_info): Remove.
1298
1299 2019-05-08  Tom Tromey  <tom@tromey.com>
1300
1301         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1302         (fbsd_pspace_data_handle): Move lower.  Change type.
1303         (get_fbsd_pspace_data): Update.
1304         (fbsd_pspace_data_cleanup): Remove.
1305         (_initialize_fbsd_tdep): Update.
1306
1307 2019-05-08  Tom Tromey  <tom@tromey.com>
1308
1309         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1310         (get_ada_tasks_pspace_data): Update.
1311         (ada_tasks_pspace_data_cleanup): Remove.
1312         (_initialize_tasks): Update.
1313         (ada_tasks_inferior_data_handle): Change type.
1314         (get_ada_tasks_inferior_data): Update.
1315         (ada_tasks_inferior_data_cleanup): Remove.
1316         (struct ada_tasks_pspace_data): Add initializers.
1317
1318 2019-05-08  Tom Tromey  <tom@tromey.com>
1319
1320         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1321         * symfile-debug.c (debug_sym_get_probes): Change type.
1322         * stap-probe.c (handle_stap_probe):
1323         (stap_static_probe_ops::get_probes): Change type.
1324         * probe.h (class static_probe_ops) <get_probes>: Change type.
1325         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1326         (parse_probes_in_pspace): Update.
1327         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1328         Update.
1329         (any_static_probe_ops::get_probes): Change type.
1330         * elfread.c (elfread_data): New typedef.
1331         (probe_key): Change type.
1332         (elf_get_probes): Likewise.  Update.
1333         (probe_key_free): Remove.
1334         (_initialize_elfread): Update.
1335         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1336         Change type.
1337         (dtrace_process_dof_probe, dtrace_process_dof)
1338         (dtrace_static_probe_ops::get_probe): Change type.
1339
1340 2019-05-08  Tom Tromey  <tom@tromey.com>
1341
1342         * xcoffread.c (struct xcoff_symfile_info): Rename from
1343         coff_symfile_info.  Add initializers.
1344         (xcoff_objfile_data_key): Move lower.  Change type.
1345         (XCOFF_DATA): Rewrite.
1346         (xcoff_free_info): Remove.
1347         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1348         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1349         (xcoff_initial_scan): Update.
1350
1351 2019-05-08  Tom Tromey  <tom@tromey.com>
1352
1353         * solib-svr4.c (struct svr4_info): Add initializers and
1354         destructor.
1355         <probes_table>: Now an htab_up.
1356         (solib_svr4_pspace_data): Change type.
1357         (free_probes_table): Simplify.
1358         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1359         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1360         (probes_table_remove_objfile_probes, register_solib_event_probe)
1361         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1362         (_initialize_svr4_solib): Update.
1363
1364 2019-05-08  Tom Tromey  <tom@tromey.com>
1365
1366         * remote.c (remote_pspace_data): Change type.
1367         (remote_pspace_data_cleanup): Remove.
1368         (get_remote_exec_file, set_pspace_remote_exec_file)
1369         (_initialize_remote): Update.
1370
1371 2019-05-08  Tom Tromey  <tom@tromey.com>
1372
1373         * breakpoint.c (breakpoint_objfile_key): Change type.
1374         (get_breakpoint_objfile_data): Update.
1375         (free_breakpoint_objfile_data): Remove.
1376         (_initialize_breakpoint): Update.
1377
1378 2019-05-08  Tom Tromey  <tom@tromey.com>
1379
1380         * linux-tdep.c (struct linux_info): Add initializers.
1381         (linux_inferior_data): Move.  Change type.
1382         (invalidate_linux_cache_inf): Update.
1383         (linux_inferior_data_cleanup): Remove.
1384         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1385
1386 2019-05-08  Tom Tromey  <tom@tromey.com>
1387
1388         * auxv.c (auxv_inferior_data): Move.  Change type.
1389         (auxv_inferior_data_cleanup): Remove.
1390         (invalidate_auxv_cache_inf): Rewrite.
1391         (get_auxv_inferior_data, _initialize_auxv): Update.
1392
1393 2019-05-08  Tom Tromey  <tom@tromey.com>
1394
1395         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1396         (symfile_debug_objfile_data_key): Change type.
1397         (symfile_debug_installed, debug_qf_has_symbols)
1398         (debug_qf_find_last_source_symtab)
1399         (debug_qf_forget_cached_source_info)
1400         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1401         (debug_qf_print_stats, debug_qf_dump)
1402         (debug_qf_expand_symtabs_for_function)
1403         (debug_qf_expand_all_symtabs)
1404         (debug_qf_expand_symtabs_with_fullname)
1405         (debug_qf_map_matching_symbols)
1406         (debug_qf_expand_symtabs_matching)
1407         (debug_qf_find_pc_sect_compunit_symtab)
1408         (debug_qf_map_symbol_filenames)
1409         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1410         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1411         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1412         (debug_sym_read_linetable, debug_sym_relocate): Update.
1413         (symfile_debug_free_objfile): Remove.
1414         (install_symfile_debug_logging, _initialize_symfile_debug):
1415         Update.
1416
1417 2019-05-08  Tom Tromey  <tom@tromey.com>
1418
1419         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1420         allocate_on_obstack.
1421         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1422         (get_dwarf2_per_objfile): Update.
1423         (set_dwarf2_per_objfile): Remove.
1424         (dwarf2_has_info, dwarf2_get_section_info): Update.
1425         (dwarf2_free_objfile): Remove.
1426         (_initialize_dwarf2_read): Update.
1427
1428 2019-05-08  Tom Tromey  <tom@tromey.com>
1429
1430         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1431         initializers.
1432         <unsupported_script_warning_printed,
1433         script_not_found_warning_printed>: Now bool.
1434         (auto_load_pspace_data): Change type.
1435         (~auto_load_pspace_info): Rename from
1436         auto_load_pspace_data_cleanup.
1437         (get_auto_load_pspace_data, init_loaded_scripts_info)
1438         (clear_section_scripts, maybe_print_unsupported_script_warning)
1439         (maybe_print_script_not_found_warning, _initialize_auto_load):
1440         Update.
1441
1442 2019-05-08  Tom Tromey  <tom@tromey.com>
1443
1444         * objfiles.c (objfile_pspace_info): Add destructor and
1445         initializers.
1446         (objfiles_pspace_data): Change type.
1447         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1448         (get_objfile_pspace_data): Update.
1449         (objfiles_bfd_data): Change type.
1450         (get_objfile_bfd_data): Update.
1451         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1452
1453 2019-05-08  Tom Tromey  <tom@tromey.com>
1454
1455         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1456         Change type.
1457         (get_catch_syscall_inferior_data): Update.
1458         (catch_syscall_inferior_data_cleanup): Remove.
1459         (_initialize_break_catch_syscall): Update.
1460
1461 2019-05-08  Tom Tromey  <tom@tromey.com>
1462
1463         * inflow.c (struct terminal_info): Add destructor and
1464         initializers.
1465         (inflow_inferior_data): Change type.
1466         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1467         (get_inflow_inferior_data, inflow_inferior_exit)
1468         (swap_terminal_info, _initialize_inflow): Update.
1469
1470 2019-05-08  Tom Tromey  <tom@tromey.com>
1471
1472         * target-dcache.c (target_dcache_cleanup): Remove.
1473         (target_dcache_aspace_key): Change type.
1474         (target_dcache_init_p, target_dcache_invalidate)
1475         (target_dcache_get, target_dcache_get_or_init)
1476         (_initialize_target_dcache): Update.
1477         * dcache.h (struct dcache_deleter): New.
1478
1479 2019-05-08  Tom Tromey  <tom@tromey.com>
1480
1481         * symtab.c (struct symbol_cache): Add destructor and
1482         initializers.
1483         (symbol_cache_key): Move.  Change type.
1484         (make_symbol_cache, free_symbol_cache): Remove.
1485         (get_symbol_cache): Update.
1486         (symbol_cache_cleanup): Remove.
1487         (ALL_PSPACES, symbol_cache_flush)
1488         (maintenance_print_symbol_cache)
1489         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1490         Update.
1491
1492 2019-05-08  Tom Tromey  <tom@tromey.com>
1493
1494         * symtab.c (struct main_info): Add destructor and initializers.
1495         (main_progspace_key): Move.  Change type.
1496         (get_main_info): Update.
1497         (main_info_cleanup): Remove.
1498         (_initialize_symtab): Update.
1499
1500 2019-05-08  Tom Tromey  <tom@tromey.com>
1501
1502         * registry.h (DECLARE_REGISTRY): Define the _key class.
1503
1504 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1505
1506         * NEWS: Merge two 'New commands' sections.
1507
1508 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1509
1510         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1511         parameter and use Ada language definition instead.
1512         (ada_val_print_ptr): Remove unused language parameter.
1513         (ada_val_print_num): Remove language parameter and use Ada language
1514         definition instead.
1515         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1516         parameter.
1517         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1518         parameter and use Ada language definition instead.
1519         (ada_val_print_1): Update all ada_val_print_xxx calls.
1520         Remove language parameter.
1521         (ada_val_print): Update ada_val_print_1 call.
1522
1523 2019-05-08  Tom Tromey  <tromey@adacore.com>
1524
1525         * remote.c (remote_hw_watchpoint_limit)
1526         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1527         Now static.
1528
1529 2019-05-08  Tom Tromey  <tromey@adacore.com>
1530
1531         * maint.c (_initialize_maint_cmds): Move initialization code to
1532         remote.c.
1533         (watchdog, show_watchdog): Move to remote.c.
1534         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1535         "watchdog" static.
1536         (_initialize_remote): Move initialization code from maint.c.
1537         * defs.h (watchdog): Don't declare.
1538
1539 2019-05-08  Tom Tromey  <tromey@adacore.com>
1540
1541         * tui/tui-interp.c: Include main.h.
1542         * interps.c: Include main.h.
1543         * main.h (interpreter_p): Declare.
1544         * defs.h (interpreter_p): Don't declare.
1545
1546 2019-05-08  Tom Tromey  <tromey@adacore.com>
1547
1548         * dwarf2loc.c: Include dwarf2read.h.
1549         * defs.h (read_unsigned_leb128): Don't declare.
1550         * dwarf2read.h (read_unsigned_leb128): Declare.
1551
1552 2019-05-08  Tom Tromey  <tromey@adacore.com>
1553
1554         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1555         method.
1556
1557 2019-05-08  Tom Tromey  <tromey@adacore.com>
1558
1559         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1560         when no wrap column is set.
1561
1562 2019-05-08  Tom Tromey  <tromey@adacore.com>
1563
1564         * c-lang.c (c_get_string): Handle non-C-style arrays.
1565
1566 2019-05-08  Tom Tromey  <tromey@adacore.com>
1567
1568         * typeprint.c (print_offset_data::update): Print the bit offset,
1569         not the number of bits remaining.
1570
1571 2019-05-08  Tom Tromey  <tromey@adacore.com>
1572
1573         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1574         padding at end of comment.
1575
1576 2019-05-08  Tom Tromey  <tromey@adacore.com>
1577
1578         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1579         Compare main types.
1580
1581 2019-05-06  Tom Tromey  <tom@tromey.com>
1582
1583         * common/scoped_mmap.c: Include common-defs.h.
1584         * common/scoped_mmap.h: Don't include config.h.
1585
1586 2019-05-04  Tom Tromey  <tom@tromey.com>
1587
1588         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1589         (struct aarch64_call_info): Add initializers.
1590         <si>: Now a std::vector.
1591         (pass_on_stack, aarch64_push_dummy_call): Update.
1592
1593 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1594             Tom Tromey  <tom@tromey.com>
1595
1596         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1597         (ppc_threads): Now a std::vector.  Now static.
1598         (hwdebug_find_thread_points_by_tid)
1599         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1600         Update.
1601
1602 2019-05-04  Tom Tromey  <tom@tromey.com>
1603
1604         * arc-tdep.c (arc_tdesc_init): Return bool.
1605
1606 2019-05-04  Tom Tromey  <tom@tromey.com>
1607
1608         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1609         Use gdb_assert_not_reached.
1610
1611 2019-05-04  Tom Tromey  <tom@tromey.com>
1612
1613         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1614         "false".
1615
1616 2019-05-04  Tom Tromey  <tom@tromey.com>
1617
1618         * arc-tdep.c (arc_tdesc_init): Use bool.
1619
1620 2019-05-04  Tom Tromey  <tom@tromey.com>
1621
1622         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1623
1624 2019-05-04  Tom Tromey  <tom@tromey.com>
1625
1626         * cli/cli-cmds.c (valid_command_p): Return bool.
1627
1628 2019-05-04  Tom Tromey  <tom@tromey.com>
1629
1630         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1631         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1632
1633 2019-05-04  Raul Tambre  <raul@tambre.ee>
1634
1635         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1636         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1637         operator for comparison.
1638
1639 2019-05-04  Tom Tromey  <tom@tromey.com>
1640
1641         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1642         (lookup_partial_symbol, print_partial_symbols)
1643         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1644         (psymbol_compare): Update.
1645         (add_psymbol_to_bcache): Clear the entire psymbol.
1646         (maintenance_check_psymtabs): Update.
1647         * psympriv.h (struct partial_symbol): Don't derive from
1648         general_symbol_info.
1649         <obj_section, unrelocated_address, address,
1650         set_unrelocated_address>: Update.
1651         <ginfo>: New member.
1652         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1653         (debug_names::write_psymbols): Update.
1654
1655 2019-05-04  Tom de Vries  <tdevries@suse.de>
1656
1657         * contrib/cc-with-tweaks.sh: Support -n arg.
1658
1659 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1660
1661         * corelow.c (core_target::detach): Ensure frame cache and
1662         register caches are cleared.
1663         inferior.c (exit_inferior_1): Likewise.
1664
1665 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1666             Tom Tromey  <tom@tromey.com>
1667
1668         * dictionary.c (collate_pending_symbols_by_language): Remove
1669         "struct" from foreach.
1670         * symtab.c (lookup_global_symbol_from_objfile)
1671         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1672         foreach.
1673         * ser-tcp.c (net_open): Remove "struct" from foreach.
1674         * objfiles.c (objfile_relocate, objfile_rebase)
1675         (objfile_has_symbols): Remove "struct" from foreach.
1676         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1677         from foreach.
1678         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1679         foreach.
1680         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1681         "struct" from foreach.
1682         * ada-lang.c (create_excep_cond_exprs)
1683         (ada_exception_catchpoint_cond_string): Remove "struct" from
1684         foreach.
1685
1686 2019-05-03  Tom Tromey  <tromey@adacore.com>
1687
1688         * ada-exp.y (convert_char_literal): Check suffix of each
1689         enumerator.
1690
1691 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1692
1693         PR ada/21406:
1694         * ada-exp.y (yywrap): Don't define.
1695         * ada-lex.l (%option): Add noyywrap
1696         (yywrap): Remove.
1697
1698 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1699
1700         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1701         _WIN32_WINNT to the XP level, unless already defined to a higher
1702         level.
1703
1704         * unittests/parse-connection-spec-selftests.c:
1705         * ser-tcp.c:
1706         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1707         override.
1708
1709         * symfile.c (find_separate_debug_file): Remove colon from the
1710         drive spec of DOS/Windows file names of the target, so that the
1711         file name produced from DEBUGDIR and the target's directory will
1712         be valid on DOS/Windows systems.
1713
1714 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1715
1716         * rust-lang.c (val_print_struct): Handle printing structures
1717         containing strings.
1718
1719 2019-05-02  Tom Tromey  <tromey@adacore.com>
1720
1721         * valarith.c (_initialize_valarith): Remove.
1722
1723 2019-05-01  Tom Tromey  <tromey@adacore.com>
1724
1725         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1726         bitfields.
1727
1728 2019-05-01  Tom Tromey  <tromey@adacore.com>
1729
1730         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1731         for big-endian copies.
1732
1733 2019-04-30  Ali Tamur  <tamur@google.com>
1734         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1735         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1736         (read_3_bytes): New function.
1737
1738 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1739
1740         * windows-nat.c (main_thread_id): Delete.
1741         (handle_output_debug_string): Replace main_thread_id by
1742         current_event.dwThreadId.
1743         (fake_create_process): Likewise.
1744         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1745         Do not set main_thread_id.
1746         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1747         current_event.dwThreadId.
1748         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1749
1750 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1751
1752         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1753         Use current_event.dwThreadId instead of main_thread_id.
1754
1755 2019-04-30  Tom Tromey  <tromey@adacore.com>
1756
1757         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1758         (create_excep_cond_exprs): Iterate over program spaces.
1759         (ada_exception_catchpoint_cond_string): Examine all minimal
1760         symbols for exception types.
1761
1762 2019-04-30  Tom Tromey  <tromey@adacore.com>
1763
1764         PR c++/24470:
1765         * dwarf2read.c (process_structure_scope): Handle case where type
1766         has template parameters but no symbol was created.
1767
1768 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1769             Chris January  <chris.january@arm.com>
1770
1771         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1772         qualifier.
1773         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1774
1775 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1776
1777         * f-typeprint.c (f_print_type): Update rules for printing
1778         whitespace.
1779         (f_type_print_varspec_suffix): Likewise.
1780
1781 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1782             Chris January  <chris.january@arm.com>
1783
1784         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1785         function arguments.
1786
1787 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1788
1789         * f-lang.c (build_fortran_types): Change name of void type to
1790         lower case.
1791         * f-typeprint.c (f_type_print_base): Print the name of the void
1792         type, rather than a fixed string.
1793         * f-valprint.c (f_decorations): Use lower case void string.
1794
1795 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1796             Chris January  <chris.january@arm.com>
1797
1798         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1799         types for Fortran.
1800
1801 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1802             Chris January  <chris.january@arm.com>
1803             David Lecomber  <david.lecomber@arm.com>
1804
1805         * f-exp.y (BINOP_INTRINSIC): New token.
1806         (exp): New parser rule handling BINOP_INTRINSIC.
1807         (f77_keywords): Add new builtin procedures.
1808         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1809         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1810         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1811         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1812         (print_unop_subexp_f): New function.
1813         (print_binop_subexp_f): New function.
1814         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1815         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1816         (dump_subexp_body_f): Likewise.
1817         (operator_check_f): Likewise.
1818         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1819         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1820
1821 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1822
1823         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1824         UNOP_KIND.
1825         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1826         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1827         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1828         (operator_length_f): New fuction.
1829         (print_subexp_f): New function.
1830         (op_name_f): New function.
1831         (dump_subexp_body_f): New function.
1832         (operator_check_f): New function.
1833         (exp_descriptor_f): Replace standard expression handling functions
1834         with new functions.
1835         * gdb/fortran-operator.def: New file.
1836         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1837         * gdb/std-operator.def: Remove UNOP_KIND.
1838
1839 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1840
1841         * std-operator.def: Remove unbalanced, stray double quote
1842         character.
1843
1844 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1845             Chris January  <chris.january@arm.com>
1846             Daniel Everett  <daniel.everett@arm.com>
1847             Nick Forrington  <nick.forrington@arm.com>
1848             Richard Bunt  <richard.bunt@arm.com>
1849
1850         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1851         of depth when printing anonymous structs or unions.
1852         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1853         Don't print either the top-level value, or the children if the
1854         max-depth is exceeded.
1855         (ppscm_print_children): When printing the key of a map, allow one
1856         extra level of depth.
1857         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1858         print either the top-level value, or the children if the max-depth
1859         is exceeded.
1860         (print_children): When printing the key of a map, allow one extra
1861         level of depth.
1862         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1863         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1864         (user_print_options): Initialise max_depth field.
1865         (val_print_scalar_or_string_type_p): New function.
1866         (val_print): Check to see if the max depth has been reached.
1867         (val_print_check_max_depth): Define new function.
1868         (show_print_max_depth): New function.
1869         (_initialize_valprint): Add 'print max-depth' option.
1870         * valprint.h (struct value_print_options) <max_depth>: New field.
1871         (val_print_check_max_depth): Declare new function.
1872         * NEWS: Document new feature.
1873
1874 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1875
1876         * ada-lang.c (ada_language_defn): Initialise new field.
1877         * c-lang.c (c_is_string_type_p): New function.
1878         (c_language_defn): Initialise new field.
1879         (cplus_language_defn): Initialise new field.
1880         (asm_language_defn): Initialise new field.
1881         (minimal_language_defn): Initialise new field.
1882         * c-lang.h (c_is_string_type_p): Declare new function.
1883         * d-lang.c (d_language_defn): Initialise new field.
1884         * f-lang.c (f_is_string_type_p): New function.
1885         (f_language_defn): Initialise new field.
1886         * go-lang.c (go_is_string_type_p): New function.
1887         (go_language_defn): Initialise new field.
1888         * language.c (default_is_string_type_p): New function.
1889         (unknown_language_defn): Initialise new field.
1890         (auto_language_defn): Initialise new field.
1891         * language.h (struct language_defn) <la_is_string_type_p>: New
1892         member variable.
1893         (default_is_string_type_p): Declare new function.
1894         * m2-lang.c (m2_language_defn): Initialise new field.
1895         * objc-lang.c (objc_language_defn): Initialise new field.
1896         * opencl-lang.c (opencl_language_defn): Initialise new field.
1897         * p-lang.c (pascal_is_string_type_p): New function.
1898         (pascal_language_defn): Initialise new field.
1899         * rust-lang.c (rust_is_string_type_p): New function.
1900         (rust_language_defn): Initialise new field.
1901
1902 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1905         New field.
1906         * ada-lang.c (ada_language_defn): Initialise new field.
1907         * c-lang.c (c_language_defn): Likewise.
1908         (cplus_language_defn): Likewise.
1909         (asm_language_defn): Likewise.
1910         (minimal_language_defn): Likewise.
1911         * d-lang.c (d_language_defn): Likewise.
1912         * f-lang.c (f_language_defn): Likewise.
1913         * go-lang.c (go_language_defn): Likewise.
1914         * language.c (unknown_language_defn): Likewise.
1915         (auto_language_defn): Likewise.
1916         * m2-lang.c (m2_language_defn): Likewise.
1917         * objc-lang.c (objc_language_defn): Likewise.
1918         * opencl-lang.c (opencl_language_defn): Likewise.
1919         * p-lang.c (pascal_language_defn): Likewise.
1920         * rust-lang.c (rust_language_defn): Likewise.
1921
1922 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1923
1924         * ada-lang.c (ada_is_character_type): Change return type to bool.
1925         (ada_is_string_type): Likewise.
1926         * ada-lang.h (ada_is_character_type): Update declaration
1927         (ada_is_string_type): Likewise.
1928
1929 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1930
1931         Support style in 'frame|thread apply'
1932
1933         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1934         * record.c (record_start, record_stop): Update callers of
1935         execute_command_to_string with false.
1936         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1937         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1938         methods.
1939         (class string_file): New constructor with term_out parameter.
1940         Override methods term_out and can_emit_style_escape.  New member
1941         term_out.
1942         (class stdio_file): Override can_emit_style_escape.
1943         (class tee_file): Override term_out and can_emit_style_escape.
1944         * utils.h (can_emit_style_escape): Remove.
1945         * utils.c (can_emit_style_escape): Likewise.
1946         Update all callers of can_emit_style_escape (SOMESTREAM) to
1947         SOMESTREAM->can_emit_style_escape.
1948         * source-cache.c (source_cache::get_source_lines): Likewise.
1949         * stack.c (frame_apply_command_count): Call execute_command_to_string
1950         passing the term_out characteristic of the current gdb_stdout.
1951         * thread.c (thr_try_catch_cmd): Likewise.
1952         * top.c (execute_command_to_string): pass term_out parameter
1953         to construct the string_file for the command output.
1954         * ui-file.c (term_cli_styling): New function (most code moved
1955         from utils.c can_emit_style_escape).
1956         (string_file::string_file, string_file::can_emit_style_escape,
1957         stdio_file::can_emit_style_escape, tee_file::term_out,
1958         tee_file::can_emit_style_escape): New functions.
1959
1960 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1961
1962         * NEWS: Mention the new set|show may-call-functions.
1963         * infcall.c (may_call_functions_p): New variable.
1964         (show_may_call_functions_p): New function.
1965         (call_function_by_hand_dummy): Throws an error if not
1966         may-call-functions.
1967         (_initialize_infcall): Call add_setshow_boolean_cmd for
1968         may-call-functions.
1969
1970 2019-04-25  Keith Seitz  <keiths@redhat.com>
1971
1972         PR c++/24367
1973         * cp-support.c (inspect_type): Don't attempt substitutions
1974         of symbol with the same name.
1975
1976 2019-04-25  Tom Tromey  <tromey@adacore.com>
1977
1978         PR gdb/24475:
1979         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1980         static.
1981
1982 2019-04-25  Tom Tromey  <tromey@adacore.com>
1983
1984         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1985         rvalue reference.
1986         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1987         (gdb_xml_parser::parse): Use std::move.
1988         * python/python-internal.h (gdbpy_convert_exception): Take a const
1989         reference.
1990         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1991         std::move.
1992         * python/py-utils.c (gdbpy_convert_exception): Take a const
1993         reference.
1994         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1995         Use std::move.
1996         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1997         Use std::move.
1998         * mi/mi-main.c (mi_print_exception): Take a const reference.
1999         * main.c (handle_command_errors): Take a const reference.
2000         * linespec.c (parse_linespec): Use std::move.
2001         * infcall.c (run_inferior_call): Use std::move.
2002         (call_function_by_hand_dummy): Use std::move.
2003         * exec.c (try_open_exec_file): Use std::move.
2004         * exceptions.h (exception_print, exception_fprintf)
2005         (exception_print_same): Update.
2006         * exceptions.c (print_exception, exception_print)
2007         (exception_fprintf, exception_print_same): Change parameters to
2008         const reference.
2009         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2010         * common/new-op.c: Use std::move.
2011         * common/common-exceptions.h (struct gdb_exception): Add move
2012         constructor.
2013         (struct gdb_exception_error, struct gdb_exception_quit, struct
2014         gdb_quit_bad_alloc): Change constructor to move constructor.
2015         (throw_exception): Change parameter to rvalue reference.
2016         * common/common-exceptions.c (throw_exception): Take rvalue
2017         reference.
2018         * cli/cli-interp.c (safe_execute_command): Use std::move.
2019         * breakpoint.c (insert_bp_location, location_to_sals): Use
2020         std::move.
2021
2022 2019-04-25  Tom Tromey  <tromey@adacore.com>
2023
2024         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2025         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2026         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2027         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2028         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2029         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2030         guile/scm-value.c: Use unpack.
2031         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2032         gdbscm_gdb_exception.
2033         (gdbscm_throw_gdb_exception): Likewise.
2034         (struct gdbscm_gdb_exception): New.
2035         (unpack): New function.
2036         (gdbscm_wrap): Use unpack.
2037
2038 2019-04-25  Tom Tromey  <tromey@adacore.com>
2039
2040         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2041         (gdb_rl_callback_handler): Use std::move.
2042         * common/common-exceptions.h (struct gdb_exception): Add move
2043         assignment operator.
2044         (throw_exception_sjlj): Change "exception" to const reference.
2045         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2046         (throw_exception_sjlj): Change "exception" to const reference.
2047
2048 2019-04-25  Tom Tromey  <tromey@adacore.com>
2049
2050         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2051         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2052         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2053         Update.
2054         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2055         Update.
2056         * mi/mi-interp.c (mi_interp::exec): Update.
2057         * linespec.c (parse_linespec): Update.
2058         * infcall.c (run_inferior_call): Update.
2059         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2060         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2061         (gdbscm_lookup_global_symbol): Update.
2062         * guile/scm-param.c (gdbscm_parameter_value): Update.
2063         * guile/scm-frame.c (gdbscm_frame_read_register)
2064         (gdbscm_frame_read_var): Update.
2065         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2066         * exec.c (try_open_exec_file): Update.
2067         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2068         (gdb_rl_callback_handler): Update.
2069         * common/common-exceptions.h (exception_none): Don't declare.
2070         * common/common-exceptions.c (exception_none): Don't define.
2071         (struct catcher) <exception>: Update.
2072         * cli/cli-interp.c (safe_execute_command): Update.
2073         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2074
2075 2019-04-25  Ali Tamur  <tamur@google.com>
2076
2077         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2078         (read_attribute_value): Likewise.
2079         (dwarf2_read_addr_index): Update comment.
2080         (read_str_index): Add DW_FORM_strx.
2081         (dwarf2_string_attr): Likewise.
2082         (dwarf2_const_value_attr): Likewise.
2083         (dump_die_shallow): Likewise.
2084         (dwarf2_fetch_constant_bytes): Likewise.
2085         (skip_form_bytes): Likewise.
2086         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2087
2088 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2089
2090         PR corefiles/11608
2091         PR corefiles/18187
2092         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2093         OFFSET.  Verify if current mapping contains an ELF header.
2094         (linux_find_memory_regions_full): Adjust call to
2095         dump_mapping_p.
2096
2097 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2098             Kang Li <kanglictf@gmail.com>
2099
2100         PR gdb/21600
2101
2102         * dwarf2-frame.c (read_initial_length): Be consistent about using
2103         unsigned representation of length.
2104         (decode_frame_entry_1): Likewise.  Check for wraparound of
2105         end pointer as well as buffer overflow.
2106
2107 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2108
2109         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2110         "vq".
2111
2112 2019-04-24  Tom Tromey  <tromey@adacore.com>
2113
2114         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2115
2116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2117
2118         * s12z-tdep.c (s12z_unwind_pc): Delete.
2119         (s12z_unwind_sp): Delete.
2120         (s12z_gdbarch_init): Don't register deleted functions with
2121         gdbarch.
2122
2123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2124
2125         * rl78-tdep.c (rl78_unwind_sp): Delete.
2126         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2127
2128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2129
2130         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2131         (xstormy16_unwind_pc): Delete.
2132         (xstormy16_dummy_id): Delete.
2133         (xstormy16_gdbarch_init): Don't register deleted functions with
2134         gdbarch.
2135
2136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2137
2138         * vax-tdep.c (vax_unwind_pc): Delete.
2139         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2140
2141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * v850-tdep.c (v850_unwind_sp): Delete.
2144         (v850_unwind_pc): Delete.
2145         (v850_dummy_id): Delete.
2146         (v850_gdbarch_init): Don't register deleted functions with
2147         gdbarch.
2148
2149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2150
2151         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2152         (tilegx_unwind_pc): Delete.
2153         (tilegx_unwind_dummy_id): Delete.
2154         (tilegx_gdbarch_init): Don't register deleted functions with
2155         gdbarch.
2156
2157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2160         (tic6x_dummy_id): Delete.
2161         (tic6x_gdbarch_init): Don't register deleted functions with
2162         gdbarch.
2163
2164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * sparc-tdep.c (sparc_unwind_pc): Delete.
2167         (sparc32_gdbarch_init): Don't register deleted function with
2168         gdbarch.
2169
2170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2171
2172         * sh-tdep.c (sh_unwind_sp): Delete.
2173         (sh_unwind_pc): Delete.
2174         (sh_dummy_id): Delete.
2175         (sh_gdbarch_init): Don't register deleted functions with
2176         gdbarch.
2177
2178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * score-tdep.c (score_unwind_sp): Delete.
2181         (score_unwind_pc): Delete.
2182         (score_dummy_id): Delete.
2183         (score_gdbarch_init): Don't register deleted functions with
2184         gdbarch.
2185
2186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2187
2188         * rx-tdep.c (rx_unwind_pc): Delete.
2189         (rx_unwind_sp): Delete.
2190         (rx_dummy_id): Delete.
2191         (rx_gdbarch_init): Don't register deleted functions with
2192         gdbarch.  Update comment.
2193
2194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2197         (rs6000_dummy_id): Delete.
2198         (rs6000_gdbarch_init): Don't register deleted functions with
2199         gdbarch.
2200
2201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * or1k-tdep.c (or1k_dummy_id): Delete.
2204         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2205
2206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * nios2-tdep.c (nios2_dummy_id): Delete.
2209         (nios2_unwind_sp): Delete.
2210         (nios2_gdbarch_init): Don't register deleted functions with
2211         gdbarch.
2212
2213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2214
2215         * nds32-tdep.c (nds32_dummy_id): Delete.
2216         (nds32_unwind_pc): Delete.
2217         (nds32_unwind_sp): Delete.
2218         (nds32_gdbarch_init): Don't register deleted functions with
2219         gdbarch.
2220
2221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2222
2223         * msp430-tdep.c (msp430_unwind_pc): Delete.
2224         (msp430_unwind_sp): Delete.
2225         (msp430_dummy_id): Delete.
2226         (msp430_gdbarch_init): Don't register deleted functions with
2227         gdbarch.
2228
2229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2230
2231         * moxie-tdep.c (moxie_unwind_sp): Delete.
2232         (moxie_unwind_pc): Delete.
2233         (moxie_dummy_id): Delete.
2234         (moxie_gdbarch_init): Don't register deleted functions with
2235         gdbarch.
2236
2237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2240         (mn10300_unwind_pc): Delete.
2241         (mn10300_unwind_sp): Delete.
2242         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2243         mn10300_unwind_sp.
2244         (mn10300_frame_unwind_init): Don't register deleted functions with
2245         gdbarch.
2246
2247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2248
2249         * mep-tdep.c (mep_unwind_pc): Delete.
2250         (mep_unwind_sp): Delete.
2251         (mep_dummy_id): Delete.
2252         (mep_gdbarch_init): Don't register deleted functions with
2253         gdbarch.
2254
2255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2258         (m68hc11_unwind_sp): Delete.
2259         (m68hc11_gdbarch_init): Don't register deleted functions with
2260         gdbarch.
2261
2262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * m32r-tdep.c (m32r_unwind_sp): Delete.
2265         (m32r_unwind_pc): Delete.
2266         (m32r_dummy_id): Delete.
2267         (m32r_gdbarch_init): Don't register deleted functions with
2268         gdbarch.
2269
2270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * m32c-tdep.c (m32c_unwind_pc): Delete.
2273         (m32c_unwind_sp): Delete.
2274         (m32c_dummy_id): Delete.
2275         (m32c_gdbarch_init): Don't register deleted functions with
2276         gdbarch.
2277
2278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2281         (lm32_unwind_pc): Delete.
2282         (lm32_dummy_id): Delete.
2283         (lm32_gdbarch_init): Don't register deleted functions with
2284         gdbarch.
2285
2286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2289         (iq2000_unwind_pc): Delete.
2290         (iq2000_dummy_id): Delete.
2291         (iq2000_gdbarch_init): Don't register deleted functions with
2292         gdbarch.
2293
2294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * nds32-tdep.c (nds32_type_align): Delete.
2297         (nds32_push_dummy_call): Use type_align instead.
2298
2299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * arm-tdep.c (arm_type_align): Only handle vector override case.
2302         (arm_push_dummy_call): Use type_align.
2303         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2304
2305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2308         case.
2309         (pass_on_stack): Use type_align.
2310         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2311         function.
2312
2313 2019-04-23  Tom Tromey  <tromey@adacore.com>
2314
2315         * dwarf2read.c (line_header::file_name_at): Remove unused
2316         overload.
2317
2318 2019-04-23  Tom de Vries  <tdevries@suse.de>
2319
2320         PR gdb/24438
2321         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2322         invocation.
2323
2324
2325 2019-03-27  Ali Tamur  <tamur@google.com>
2326
2327         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2328         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2329         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2330         (dwarf_expr_context::get_addr_index): Likewise
2331         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2332         (symbol_needs_eval_context::get_addr_index): Likewise
2333         (disassemble_dwarf_expression): Add DW_OP_addrx
2334         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2335         (read_cutu_die_from_dwo): Update comment
2336         (skip_one_die): Add DW_FORM_addrx
2337         (read_attribute_value): Likewise
2338         (var_decode_location): Add DW_OP_addrx
2339         (dwarf2_const_value_attr): Add DW_FORM_addrx
2340         (dump_die_shallow): Likewise
2341         (dwarf2_fetch_constant_bytes): Likewise
2342         (decode_locdesc): Add DW_OP_addrx
2343         (skip_form_bytes): Add DW_FORM_addrx
2344
2345 2019-04-22  Ali Tamur  <tamur@google.com>
2346
2347         * MAINTAINERS (Write After Approval): Add self.
2348
2349 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2350
2351         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2352         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2353         (open_symbol_file_object): Likewise.
2354         (svr4_default_sos): Add info parameter.
2355         (svr4_read_so_list): Likewise.
2356         (svr4_current_sos_direct): Adjust functions calls to pass down
2357         info.
2358         (svr4_current_sos_1): Add info parameter.
2359         (svr4_current_sos): Call get_svr4_info, pass info down to
2360         svr4_current_sos_1.
2361         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2362         get_svr4_info.
2363         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2364         get_svr4_info.
2365         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2366         to get_svr4_info.
2367         (probes_table_remove_objfile_probes): Likewise.
2368         (register_solib_event_probe): Add info parameter.
2369         (solist_update_incremental): Pass info parameter down to
2370         svr4_read_so_list.
2371         (disable_probes_interface): Add info parameter.
2372         (svr4_handle_solib_event): Pass current_program_space to
2373         get_svr4_info.  Adjust disable_probes_interface cleanup.
2374         (svr4_create_probe_breakpoints): Add info parameter, pass it
2375         down to register_solib_event_probe.
2376         (svr4_create_solib_event_breakpoints): Add info parameter,
2377         pass it down to svr4_create_probe_breakpoints.
2378         (enable_break): Pass info down to
2379         svr4_create_solib_event_breakpoints.
2380         (svr4_solib_create_inferior_hook): Pass current_program_space to
2381         get_svr4_info.
2382         (svr4_clear_solib): Likewise.
2383
2384 2019-04-22  Pedro Alves  <palves@redhat.com>
2385
2386         * solib-svr4.c (svr4_free_objfile_observer): New.
2387         (probe_and_action::objfile): New field.
2388         (probes_table_htab_remove_objfile_probes)
2389         (probes_table_remove_objfile_probes): New functions.
2390         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2391         in the new probe_and_action.  Don't store the probe in 'lookup'.
2392         (svr4_create_probe_breakpoints): Pass objfile to
2393         register_solib_event_probe.
2394         (_initialize_svr4_solib): Register a free_objfile observer.
2395
2396 2019-04-19  Tom Tromey  <tom@tromey.com>
2397
2398         * common/queue.h: Remove.
2399
2400 2019-04-19  Tom Tromey  <tom@tromey.com>
2401
2402         * event-loop.c: Don't include "common/queue.h".
2403
2404 2019-04-19  Tom Tromey  <tom@tromey.com>
2405
2406         * remote.c (remote_target): Use delete.
2407         * remote-notif.h: Include <list>, not "common/queue.h".
2408         (notif_client_p): Remove typedef.
2409         (remote_notif_state): Add constructor, destructor, initializer.
2410         <notif_queue>: Now a std::list.
2411         (remote_notif_state_xfree): Don't declare.
2412         * remote-notif.c (remote_notif_process, handle_notification)
2413         (remote_notif_state_allocate): Update.
2414         (~remote_notif_state): Rename from remote_notif_state_xfree.
2415
2416 2019-04-19  Tom Tromey  <tom@tromey.com>
2417
2418         * symfile.c (reread_symbols): Update.
2419         * objfiles.c (objfile_register_static_link)
2420         (objfile_lookup_static_link): Update
2421         (~objfile) Don't delete static_links.
2422         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2423
2424 2019-04-19  Tom Tromey  <tom@tromey.com>
2425
2426         * type-stack.h (struct type_stack) <insert>: Constify string.
2427         * type-stack.c (type_stack::insert): Constify string.
2428         * gdbtypes.h (lookup_template_type): Update.
2429         (address_space_name_to_int): Update.
2430         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2431         const.
2432         (lookup_template_type): Make name const.
2433         * c-exp.y: Update rules.
2434         (lex_one_token, classify_name, classify_inner_name)
2435         (c_print_token): Update.
2436         * p-exp.y: Update rules.
2437         (yylex): Update.
2438         * f-exp.y: Update rules.
2439         (yylex): Update.
2440         * d-exp.y: Update rules.
2441         (lex_one_token, classify_name, classify_inner_name): Update.
2442         * parse.c (write_dollar_variable, copy_name): Return std::string.
2443         * parser-defs.h (copy_name): Change return type.
2444         * m2-exp.y: Update rules.
2445         (yylex): Update.
2446         * go-exp.y (lex_one_token): Update.
2447         Update rules.
2448         (classify_unsafe_function, classify_packaged_name)
2449         (classify_name, yylex): Update.
2450
2451 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2452
2453         * configure.ac: add --enable-source-highlight switch.
2454         * configure: Regenerate.
2455         * top.c (print_gdb_version): plumb --enable-source-highlight
2456         status to "show configuration".
2457
2458 2019-04-19  Tom Tromey  <tromey@adacore.com>
2459
2460         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2461         Check ADA_TYPE_P.
2462         (empty_record, ada_template_to_fixed_record_type_1)
2463         (template_to_static_fixed_type)
2464         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2465         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2466         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2467         macros.
2468
2469 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2470
2471         PR symtab/24423:
2472         * source.c (print_source_lines_base): Advance "iter" when a
2473         control character is seen.
2474
2475 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2476
2477         * inferior.h (struct infcall_suspend_state_deleter):
2478         Catch exception in destructor to avoid crash.
2479
2480 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2481
2482         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2483         close to the add_com "shell".
2484
2485 2019-04-18  Tom Tromey  <tromey@adacore.com>
2486
2487         * process-stratum-target.h (class process_stratum_target)
2488         <stratum>: Add "final".
2489
2490 2019-04-17  Tom Tromey  <tromey@adacore.com>
2491
2492         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2493         against nullptr before use.
2494
2495 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2496
2497         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2498
2499 2019-04-17  Jim Wilson  <jimw@sifive.com>
2500             Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2503         code read might fail, assume 4-byte breakpoint in that case.
2504
2505 2019-04-15  Leszek Swirski  <leszeks@google.com>
2506
2507         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2508         rather than a hand-rolled POD check when checking for forced MEMORY
2509         classification.
2510
2511 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2512
2513         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2514         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2515         function.
2516         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2517         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2518         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2519         declaration.
2520
2521 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2522
2523         * aarch64-linux-nat.c
2524         (aarch64_linux_nat_target::thread_architecture): Add override.
2525         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2526         each VQ.
2527
2528 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2529
2530         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2531
2532 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2533
2534         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2535         target types of size 96-bits, add some additional comments, and
2536         check that the builtin type we found was the correct size.
2537
2538 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2539
2540         * utils.c (prompt_for_continue): Don't restore the styling at the
2541         end, as applied_style has the wrong value.  This fixes styling in
2542         long lists of file names that are interrupted by the "Continue?"
2543         prompt.
2544
2545 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2548         * c-lang.c (c_language_defn): Likewise.
2549         (cplus_language_defn): Likewise.
2550         (asm_language_defn): Likewise.
2551         (minimal_language_defn): Likewise.
2552         * d-lang.c (d_language_defn): Likewise.
2553         * f-lang.c (f_language_defn): Likewise.
2554         * go-lang.c (go_language_defn): Likewise.
2555         * language.c (unknown_language_defn): Likewise.
2556         (auto_language_defn): Likewise.
2557         * language.h (struct language_defn): Remove la_magic field.
2558         (LANG_MAGIC): Delete.
2559         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2560         * objc-lang.c (objc_language_defn): Likewise.
2561         * opencl-lang.c (opencl_language_defn): Likewise.
2562         * p-lang.c (pascal_language_defn): Likewise.
2563         * rust-lang.c (rust_language_defn): Likewise.
2564
2565 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * riscv-tdep.c (riscv_type_align): New function.
2568         (riscv_type_alignment): Delete.
2569         (riscv_arg_location): Use 'type_align'.
2570         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2571
2572 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2573
2574         * gdbtypes.c (type_align): A struct with no non-static fields also
2575         has alignment of 1.
2576
2577 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2578
2579         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2580         component to 0.
2581         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2582         member.
2583         (riscv_struct_info::analyse): New implementation using new
2584         analyse_inner member function.
2585         (riscv_struct_info::field_offset): New member function.
2586         (riscv_struct_info::m_offsets): New member variable.
2587         (riscv_struct_info::analyse_inner): New private member function,
2588         takes the old implementation of riscv_struct_info::analyse but
2589         extended to track field offsets.
2590         (riscv_call_arg_struct): Update the struct folding special cases
2591         to handle cases where empty C++ structs, which are non-zero
2592         length, are found.
2593         (riscv_arg_location): Initialise the length of each location, a
2594         non-zero length now indicates the location is in use.
2595         (riscv_push_dummy_call): Allow for the first location having a
2596         non-zero offset when setting up arguments.
2597         (riscv_return_value): Likewise, but for return values.
2598
2599 2019-04-11  Tom Tromey  <tromey@adacore.com>
2600
2601         * utils.c (internal_vproblem): Make "msg" const.
2602
2603 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2604
2605         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2606         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2607         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2608         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2609
2610 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2611
2612         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2613         function.
2614         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2615         of amd64_collect_native_gregset.
2616         (amd64_linux_nat_target::store_registers): Likewise.
2617
2618 2019-04-10  Tom Tromey  <tom@tromey.com>
2619
2620         * symtab.c (lookup_global_symbol_from_objfile)
2621         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2622         * objfiles.h (class separate_debug_iterator): New.
2623         (class separate_debug_range): New.
2624         (struct objfile) <separate_debug_objfiles>: New method.
2625         (objfile_separate_debug_iterate): Don't declare.
2626         * objfiles.c (separate_debug_iterator::operator++): Rename from
2627         objfile_separate_debug_iterate.
2628         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2629         iterator.
2630         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2631         iterator.
2632
2633 2019-04-10  Tom Tromey  <tom@tromey.com>
2634
2635         * symfile.c (reread_symbols): Remove old comment.
2636         * objfiles.c (free_all_objfiles): Fix a typo.
2637
2638 2019-04-10  Tom Tromey  <tom@tromey.com>
2639
2640         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2641         * minsyms.c (lookup_minimal_symbol): Use foreach.
2642         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2643         (lookup_minimal_symbol_solib_trampoline): Likewise.
2644         * symfile.c (reread_symbols): Use foreach.
2645
2646 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2647             Tom Tromey  <tromey@adacore.com>
2648
2649         PR rust/24414:
2650         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2651         (rust_lex_int_test): Change "value" to be LONGEST.
2652         (rust_lex_tests): Add test for long integer literal.
2653
2654 2019-04-09  Tom Tromey  <tromey@adacore.com>
2655
2656         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2657         to bool.
2658         (extended_remote_target::attach): Update.
2659         (remote_target::remote_notice_new_inferior): Update.
2660         (remote_target::add_current_inferior_and_thread): Update.
2661         * inferior.c (exit_inferior_1): Use "false".
2662         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2663
2664 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2665
2666         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2667         the "start" command.
2668
2669 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2670
2671         * python/py-inferior.c (infpy_thread_from_thread_handle):
2672         Adjust comments to reflect renaming of thread_from_thread_handle
2673         to thread_from_handle.  Adjust keywords.  Fix type error message.
2674         (inferior_object_methods): Add thread_from_handle.  Retain
2675         thread_from_thread_handle, but mark it as deprecated.
2676
2677 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2678
2679         * gdbthread.h (find_thread_by_handle): Revise declaration.
2680         * thread.c (find_thread_by_handle): Likewise.  Adjust
2681         implementation too.
2682         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2683         support for buffer objects as handles.
2684
2685 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2686
2687         * python/py-infthread.c (thpy_thread_handle): New function.
2688         (thread_object_methods): Register thpy_thread_handle.
2689
2690 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2691
2692         * gdbthread.h (thread_to_thread_handle): Declare.
2693         * thread.c (gdbtypes.h): Include.
2694         (thread_to_thread_handle): New function.
2695
2696         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2697         (target_thread_info_to_thread_handle): Declare.
2698         * target.c (target_thread_info_to_thread_handle): New function.
2699         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2700         * target-delegates.c: Regenerate.
2701
2702         * linux-thread-db.c (class thread_db_target): Add method
2703         thread_info_to_thread_handle.
2704         (thread_db_target::thread_info_to_thread_handle): Define.
2705         * remote.c (class remote_target): Add new method
2706         thread_info_to_thread_handle.
2707         (remote_target::thread_info_to_thread_handle): Define.
2708
2709 2019-04-08  Pedro Alves  <palves@redhat.com>
2710
2711         * common/common-exceptions.c (throw_exception): Don't create
2712         named object to throw; throw directly.
2713         (throw_it): Likewise.  Don't initialize gdb_exception::message
2714         here, with new; pass FMT and AP to the ctor instead.
2715         * common/common-exceptions.h: Include <string>.
2716         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2717         const char *, va_list)): New ctor.  Use std::make_shared.
2718         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2719         errors)): Delete.
2720         (gdb_exception_error::gdb_exception_error(enum errors, const char
2721         *, va_list)): New.
2722         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2723         Add assertion.
2724         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2725         errors)): Delete.
2726         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2727         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2728         Add assertion.
2729
2730 2019-04-08  Tom Tromey  <tom@tromey.com>
2731
2732         * valops.c (value_rtti_indirect_type): Replace throw_exception
2733         with throw.
2734         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2735         with throw.
2736         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2737         throw.
2738         * target.c (target_translate_tls_address): Replace throw_exception
2739         with throw.
2740         * stack.c (frame_apply_command_count): Replace throw_exception
2741         with throw.
2742         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2743         throw.
2744         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2745         with throw.
2746         * rs6000-tdep.c (rs6000_frame_cache)
2747         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2748         * remote.c: Replace throw_exception with throw.
2749         * record-full.c (record_full_message, record_full_wait_1)
2750         (record_full_restore): Replace throw_exception with throw.
2751         * record-btrace.c:
2752         (get_thread_current_frame_id, record_btrace_start_replaying)
2753         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2754         (cmd_record_btrace_start): Replace throw_exception with throw.
2755         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2756         throw.
2757         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2758         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2759         * linespec.c:
2760         (find_linespec_symbols): Replace throw_exception with throw.
2761         * infrun.c (displaced_step_prepare, resume): Replace
2762         throw_exception with throw.
2763         * infcmd.c (post_create_inferior): Replace throw_exception with
2764         throw.
2765         * inf-loop.c (inferior_event_handler): Replace throw_exception
2766         with throw.
2767         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2768         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2769         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2770         (get_prev_frame_always, get_frame_pc_if_available)
2771         (get_frame_address_in_block_if_available, get_frame_language):
2772         Replace throw_exception with throw.
2773         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2774         throw_exception with throw.
2775         * eval.c (fetch_subexp_value, evaluate_var_value)
2776         (evaluate_funcall, evaluate_subexp_standard): Replace
2777         throw_exception with throw.
2778         * dwarf2loc.c (call_site_find_chain)
2779         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2780         Replace throw_exception with throw.
2781         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2782         with throw.
2783         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2784         throw.
2785         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2786         * completer.c (complete_line_internal): Replace throw_exception
2787         with throw.
2788         * compile/compile-object-run.c (compile_object_run): Replace
2789         throw_exception with throw.
2790         * cli/cli-script.c (process_next_line): Replace throw_exception
2791         with throw.
2792         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2793         (btrace_enable, btrace_maint_update_pt_packets): Replace
2794         throw_exception with throw.
2795         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2796         throw_exception with throw.
2797         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2798         throw_exception with throw.
2799         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2800         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2801         * aarch64-tdep.c (aarch64_make_prologue_cache)
2802         (aarch64_make_stub_cache): Replace throw_exception with throw.
2803
2804 2019-04-08  Tom Tromey  <tom@tromey.com>
2805
2806         * common/common-exceptions.c (throw_exception): Rename from
2807         throw_exception_cxx.  Remove old copy.  Make argument const.
2808         (throw_it): Create and throw exception objects directly.
2809         * common/common-exceptions.h (throw_exception): Make argument
2810         const.
2811         (struct gdb_exception_error): Add constructor.
2812         (struct gdb_exception_quit): Add constructor.
2813
2814 2019-04-08  Tom Tromey  <tom@tromey.com>
2815
2816         * common/common-exceptions.h (exception_rethrow): Don't declare.
2817         (TRY_SJLJ): Update comment.
2818         (TRY, CATCH, END_CATCH): Remove.
2819         * common/common-exceptions.c (exception_rethrow): Remove.
2820
2821 2019-04-08  Tom Tromey  <tom@tromey.com>
2822
2823         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2824         Remove.
2825         (gdb_exception_error): Rename from
2826         gdb_exception_RETURN_MASK_ERROR.
2827         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2828         (gdb_quit_bad_alloc): Update.
2829         * aarch64-tdep.c: Update.
2830         * ada-lang.c: Update.
2831         * ada-typeprint.c: Update.
2832         * ada-valprint.c: Update.
2833         * amd64-tdep.c: Update.
2834         * arch-utils.c: Update.
2835         * break-catch-throw.c: Update.
2836         * breakpoint.c: Update.
2837         * btrace.c: Update.
2838         * c-varobj.c: Update.
2839         * cli/cli-cmds.c: Update.
2840         * cli/cli-interp.c: Update.
2841         * cli/cli-script.c: Update.
2842         * common/common-exceptions.c: Update.
2843         * common/new-op.c: Update.
2844         * common/selftest.c: Update.
2845         * compile/compile-c-symbols.c: Update.
2846         * compile/compile-cplus-symbols.c: Update.
2847         * compile/compile-object-load.c: Update.
2848         * compile/compile-object-run.c: Update.
2849         * completer.c: Update.
2850         * corelow.c: Update.
2851         * cp-abi.c: Update.
2852         * cp-support.c: Update.
2853         * cp-valprint.c: Update.
2854         * darwin-nat.c: Update.
2855         * disasm-selftests.c: Update.
2856         * dtrace-probe.c: Update.
2857         * dwarf-index-cache.c: Update.
2858         * dwarf-index-write.c: Update.
2859         * dwarf2-frame-tailcall.c: Update.
2860         * dwarf2-frame.c: Update.
2861         * dwarf2loc.c: Update.
2862         * dwarf2read.c: Update.
2863         * eval.c: Update.
2864         * event-loop.c: Update.
2865         * event-top.c: Update.
2866         * exec.c: Update.
2867         * f-valprint.c: Update.
2868         * fbsd-tdep.c: Update.
2869         * frame-unwind.c: Update.
2870         * frame.c: Update.
2871         * gdbtypes.c: Update.
2872         * gnu-v3-abi.c: Update.
2873         * guile/guile-internal.h: Update.
2874         * guile/scm-block.c: Update.
2875         * guile/scm-breakpoint.c: Update.
2876         * guile/scm-cmd.c: Update.
2877         * guile/scm-disasm.c: Update.
2878         * guile/scm-frame.c: Update.
2879         * guile/scm-lazy-string.c: Update.
2880         * guile/scm-math.c: Update.
2881         * guile/scm-param.c: Update.
2882         * guile/scm-ports.c: Update.
2883         * guile/scm-pretty-print.c: Update.
2884         * guile/scm-symbol.c: Update.
2885         * guile/scm-symtab.c: Update.
2886         * guile/scm-type.c: Update.
2887         * guile/scm-value.c: Update.
2888         * i386-linux-tdep.c: Update.
2889         * i386-tdep.c: Update.
2890         * inf-loop.c: Update.
2891         * infcall.c: Update.
2892         * infcmd.c: Update.
2893         * infrun.c: Update.
2894         * jit.c: Update.
2895         * language.c: Update.
2896         * linespec.c: Update.
2897         * linux-fork.c: Update.
2898         * linux-nat.c: Update.
2899         * linux-tdep.c: Update.
2900         * linux-thread-db.c: Update.
2901         * main.c: Update.
2902         * mi/mi-cmd-break.c: Update.
2903         * mi/mi-cmd-stack.c: Update.
2904         * mi/mi-interp.c: Update.
2905         * mi/mi-main.c: Update.
2906         * objc-lang.c: Update.
2907         * p-valprint.c: Update.
2908         * parse.c: Update.
2909         * ppc-linux-tdep.c: Update.
2910         * printcmd.c: Update.
2911         * python/py-arch.c: Update.
2912         * python/py-breakpoint.c: Update.
2913         * python/py-cmd.c: Update.
2914         * python/py-finishbreakpoint.c: Update.
2915         * python/py-frame.c: Update.
2916         * python/py-framefilter.c: Update.
2917         * python/py-gdb-readline.c: Update.
2918         * python/py-inferior.c: Update.
2919         * python/py-infthread.c: Update.
2920         * python/py-lazy-string.c: Update.
2921         * python/py-linetable.c: Update.
2922         * python/py-objfile.c: Update.
2923         * python/py-param.c: Update.
2924         * python/py-prettyprint.c: Update.
2925         * python/py-progspace.c: Update.
2926         * python/py-record-btrace.c: Update.
2927         * python/py-record.c: Update.
2928         * python/py-symbol.c: Update.
2929         * python/py-type.c: Update.
2930         * python/py-unwind.c: Update.
2931         * python/py-utils.c: Update.
2932         * python/py-value.c: Update.
2933         * python/python.c: Update.
2934         * record-btrace.c: Update.
2935         * record-full.c: Update.
2936         * remote-fileio.c: Update.
2937         * remote.c: Update.
2938         * riscv-tdep.c: Update.
2939         * rs6000-aix-tdep.c: Update.
2940         * rs6000-tdep.c: Update.
2941         * rust-exp.y: Update.
2942         * rust-lang.c: Update.
2943         * s390-tdep.c: Update.
2944         * selftest-arch.c: Update.
2945         * solib-dsbt.c: Update.
2946         * solib-frv.c: Update.
2947         * solib-spu.c: Update.
2948         * solib-svr4.c: Update.
2949         * solib.c: Update.
2950         * sparc64-linux-tdep.c: Update.
2951         * stack.c: Update.
2952         * symfile-mem.c: Update.
2953         * symmisc.c: Update.
2954         * target.c: Update.
2955         * thread.c: Update.
2956         * top.c: Update.
2957         * tracefile-tfile.c: Update.
2958         * tui/tui.c: Update.
2959         * typeprint.c: Update.
2960         * unittests/cli-utils-selftests.c: Update.
2961         * unittests/parse-connection-spec-selftests.c: Update.
2962         * valops.c: Update.
2963         * valprint.c: Update.
2964         * value.c: Update.
2965         * varobj.c: Update.
2966         * windows-nat.c: Update.
2967         * x86-linux-nat.c: Update.
2968         * xml-support.c: Update.
2969
2970 2019-04-08  Tom Tromey  <tom@tromey.com>
2971
2972         * xml-support.c: Use C++ exception handling.
2973         * x86-linux-nat.c: Use C++ exception handling.
2974         * windows-nat.c: Use C++ exception handling.
2975         * varobj.c: Use C++ exception handling.
2976         * value.c: Use C++ exception handling.
2977         * valprint.c: Use C++ exception handling.
2978         * valops.c: Use C++ exception handling.
2979         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2980         handling.
2981         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2982         * typeprint.c: Use C++ exception handling.
2983         * tui/tui.c: Use C++ exception handling.
2984         * tracefile-tfile.c: Use C++ exception handling.
2985         * top.c: Use C++ exception handling.
2986         * thread.c: Use C++ exception handling.
2987         * target.c: Use C++ exception handling.
2988         * symmisc.c: Use C++ exception handling.
2989         * symfile-mem.c: Use C++ exception handling.
2990         * stack.c: Use C++ exception handling.
2991         * sparc64-linux-tdep.c: Use C++ exception handling.
2992         * solib.c: Use C++ exception handling.
2993         * solib-svr4.c: Use C++ exception handling.
2994         * solib-spu.c: Use C++ exception handling.
2995         * solib-frv.c: Use C++ exception handling.
2996         * solib-dsbt.c: Use C++ exception handling.
2997         * selftest-arch.c: Use C++ exception handling.
2998         * s390-tdep.c: Use C++ exception handling.
2999         * rust-lang.c: Use C++ exception handling.
3000         * rust-exp.y: Use C++ exception handling.
3001         * rs6000-tdep.c: Use C++ exception handling.
3002         * rs6000-aix-tdep.c: Use C++ exception handling.
3003         * riscv-tdep.c: Use C++ exception handling.
3004         * remote.c: Use C++ exception handling.
3005         * remote-fileio.c: Use C++ exception handling.
3006         * record-full.c: Use C++ exception handling.
3007         * record-btrace.c: Use C++ exception handling.
3008         * python/python.c: Use C++ exception handling.
3009         * python/py-value.c: Use C++ exception handling.
3010         * python/py-utils.c: Use C++ exception handling.
3011         * python/py-unwind.c: Use C++ exception handling.
3012         * python/py-type.c: Use C++ exception handling.
3013         * python/py-symbol.c: Use C++ exception handling.
3014         * python/py-record.c: Use C++ exception handling.
3015         * python/py-record-btrace.c: Use C++ exception handling.
3016         * python/py-progspace.c: Use C++ exception handling.
3017         * python/py-prettyprint.c: Use C++ exception handling.
3018         * python/py-param.c: Use C++ exception handling.
3019         * python/py-objfile.c: Use C++ exception handling.
3020         * python/py-linetable.c: Use C++ exception handling.
3021         * python/py-lazy-string.c: Use C++ exception handling.
3022         * python/py-infthread.c: Use C++ exception handling.
3023         * python/py-inferior.c: Use C++ exception handling.
3024         * python/py-gdb-readline.c: Use C++ exception handling.
3025         * python/py-framefilter.c: Use C++ exception handling.
3026         * python/py-frame.c: Use C++ exception handling.
3027         * python/py-finishbreakpoint.c: Use C++ exception handling.
3028         * python/py-cmd.c: Use C++ exception handling.
3029         * python/py-breakpoint.c: Use C++ exception handling.
3030         * python/py-arch.c: Use C++ exception handling.
3031         * printcmd.c: Use C++ exception handling.
3032         * ppc-linux-tdep.c: Use C++ exception handling.
3033         * parse.c: Use C++ exception handling.
3034         * p-valprint.c: Use C++ exception handling.
3035         * objc-lang.c: Use C++ exception handling.
3036         * mi/mi-main.c: Use C++ exception handling.
3037         * mi/mi-interp.c: Use C++ exception handling.
3038         * mi/mi-cmd-stack.c: Use C++ exception handling.
3039         * mi/mi-cmd-break.c: Use C++ exception handling.
3040         * main.c: Use C++ exception handling.
3041         * linux-thread-db.c: Use C++ exception handling.
3042         * linux-tdep.c: Use C++ exception handling.
3043         * linux-nat.c: Use C++ exception handling.
3044         * linux-fork.c: Use C++ exception handling.
3045         * linespec.c: Use C++ exception handling.
3046         * language.c: Use C++ exception handling.
3047         * jit.c: Use C++ exception handling.
3048         * infrun.c: Use C++ exception handling.
3049         * infcmd.c: Use C++ exception handling.
3050         * infcall.c: Use C++ exception handling.
3051         * inf-loop.c: Use C++ exception handling.
3052         * i386-tdep.c: Use C++ exception handling.
3053         * i386-linux-tdep.c: Use C++ exception handling.
3054         * guile/scm-value.c: Use C++ exception handling.
3055         * guile/scm-type.c: Use C++ exception handling.
3056         * guile/scm-symtab.c: Use C++ exception handling.
3057         * guile/scm-symbol.c: Use C++ exception handling.
3058         * guile/scm-pretty-print.c: Use C++ exception handling.
3059         * guile/scm-ports.c: Use C++ exception handling.
3060         * guile/scm-param.c: Use C++ exception handling.
3061         * guile/scm-math.c: Use C++ exception handling.
3062         * guile/scm-lazy-string.c: Use C++ exception handling.
3063         * guile/scm-frame.c: Use C++ exception handling.
3064         * guile/scm-disasm.c: Use C++ exception handling.
3065         * guile/scm-cmd.c: Use C++ exception handling.
3066         * guile/scm-breakpoint.c: Use C++ exception handling.
3067         * guile/scm-block.c: Use C++ exception handling.
3068         * guile/guile-internal.h: Use C++ exception handling.
3069         * gnu-v3-abi.c: Use C++ exception handling.
3070         * gdbtypes.c: Use C++ exception handling.
3071         * frame.c: Use C++ exception handling.
3072         * frame-unwind.c: Use C++ exception handling.
3073         * fbsd-tdep.c: Use C++ exception handling.
3074         * f-valprint.c: Use C++ exception handling.
3075         * exec.c: Use C++ exception handling.
3076         * event-top.c: Use C++ exception handling.
3077         * event-loop.c: Use C++ exception handling.
3078         * eval.c: Use C++ exception handling.
3079         * dwarf2read.c: Use C++ exception handling.
3080         * dwarf2loc.c: Use C++ exception handling.
3081         * dwarf2-frame.c: Use C++ exception handling.
3082         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3083         * dwarf-index-write.c: Use C++ exception handling.
3084         * dwarf-index-cache.c: Use C++ exception handling.
3085         * dtrace-probe.c: Use C++ exception handling.
3086         * disasm-selftests.c: Use C++ exception handling.
3087         * darwin-nat.c: Use C++ exception handling.
3088         * cp-valprint.c: Use C++ exception handling.
3089         * cp-support.c: Use C++ exception handling.
3090         * cp-abi.c: Use C++ exception handling.
3091         * corelow.c: Use C++ exception handling.
3092         * completer.c: Use C++ exception handling.
3093         * compile/compile-object-run.c: Use C++ exception handling.
3094         * compile/compile-object-load.c: Use C++ exception handling.
3095         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3096         * compile/compile-c-symbols.c: Use C++ exception handling.
3097         * common/selftest.c: Use C++ exception handling.
3098         * common/new-op.c: Use C++ exception handling.
3099         * cli/cli-script.c: Use C++ exception handling.
3100         * cli/cli-interp.c: Use C++ exception handling.
3101         * cli/cli-cmds.c: Use C++ exception handling.
3102         * c-varobj.c: Use C++ exception handling.
3103         * btrace.c: Use C++ exception handling.
3104         * breakpoint.c: Use C++ exception handling.
3105         * break-catch-throw.c: Use C++ exception handling.
3106         * arch-utils.c: Use C++ exception handling.
3107         * amd64-tdep.c: Use C++ exception handling.
3108         * ada-valprint.c: Use C++ exception handling.
3109         * ada-typeprint.c: Use C++ exception handling.
3110         * ada-lang.c: Use C++ exception handling.
3111         * aarch64-tdep.c: Use C++ exception handling.
3112
3113 2019-04-08  Tom Tromey  <tom@tromey.com>
3114
3115         * xml-support.c (gdb_xml_parser::parse): Update.
3116         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3117         * value.c (show_convenience): Update.
3118         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3119         (test_parse_flags_qcs): Update.
3120         * thread.c (thr_try_catch_cmd): Update.
3121         * target.c (target_translate_tls_address): Update.
3122         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3123         (info_frame_command_core, frame_apply_command_count): Update.
3124         * rust-exp.y (rust_lex_exception_test): Update.
3125         * riscv-tdep.c (riscv_print_one_register_info): Update.
3126         * remote.c (remote_target::enable_btrace): Update.
3127         * record-btrace.c (record_btrace_enable_warn): Update.
3128         * python/py-utils.c (gdbpy_convert_exception): Update.
3129         * printcmd.c (do_one_display, print_variable_and_value): Update.
3130         * mi/mi-main.c (mi_print_exception): Update.
3131         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3132         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3133         * linux-nat.c (linux_nat_target::attach): Update.
3134         * linux-fork.c (class scoped_switch_fork_info): Update.
3135         * infrun.c (displaced_step_prepare): Update.
3136         * infcall.c (call_function_by_hand_dummy): Update.
3137         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3138         * gnu-v3-abi.c (print_one_vtable): Update.
3139         * frame.c (get_prev_frame_always): Update.
3140         * f-valprint.c (info_common_command_for_block): Update.
3141         * exec.c (try_open_exec_file): Update.
3142         * exceptions.c (print_exception, exception_print)
3143         (exception_fprintf, exception_print_same): Update.
3144         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3145         * dwarf-index-cache.c (index_cache::store)
3146         (index_cache::lookup_gdb_index): Update.
3147         * darwin-nat.c (maybe_cache_shell): Update.
3148         * cp-valprint.c (cp_print_value_fields): Update.
3149         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3150         (gcc_cplus_symbol_address): Update.
3151         * compile/compile-c-symbols.c (gcc_convert_symbol)
3152         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3153         * common/selftest.c: Update.
3154         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3155         a std::string.
3156         (exception_try_scope_entry, exception_try_scope_exit): Don't
3157         declare.
3158         (struct exception_try_scope): Remove.
3159         (TRY): Don't use exception_try_scope.
3160         (struct gdb_exception): Add constructor, operator=.
3161         <what>: New method.
3162         (struct gdb_exception_RETURN_MASK_ALL)
3163         (struct gdb_exception_RETURN_MASK_ERROR)
3164         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3165         (struct gdb_quit_bad_alloc): Update.
3166         * common/common-exceptions.c (exception_none): Change
3167         initializer.
3168         (struct catcher) <state, exception>: Initialize inline.
3169         <prev>: Remove member.
3170         (current_catcher): Remove.
3171         (catchers): New global.
3172         (exceptions_state_mc_init): Simplify.
3173         (catcher_pop): Remove.
3174         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3175         (try_scope_depth, exception_try_scope_entry)
3176         (exception_try_scope_exit): Remove.
3177         (throw_exception_sjlj): Update.
3178         (exception_messages, exception_messages_size): Remove.
3179         (throw_it): Simplify.
3180         (gdb_exception_sliced_copy): Remove.
3181         (throw_exception_cxx): Update.
3182         * cli/cli-script.c (script_from_file): Update.
3183         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3184         Update.
3185         * ada-valprint.c (ada_val_print): Update.
3186         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3187         (create_excep_cond_exprs): Update.
3188
3189 2019-04-08  Tom Tromey  <tom@tromey.com>
3190
3191         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3192         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3193         (TRY, CATCH, END_CATCH): Remove some definitions.
3194         * common/common-exceptions.c: Don't use GDB_XCPT.
3195         (catcher_list_size): Remove.
3196         (throw_exception, throw_it): Simplify.
3197
3198 2019-04-05  Tom Tromey  <tom@tromey.com>
3199
3200         Revert the header-sorting patch.
3201         * ft32-tdep.c: Revert.
3202         * frv-tdep.c: Revert.
3203         * frv-linux-tdep.c: Revert.
3204         * frame.c: Revert.
3205         * frame-unwind.c: Revert.
3206         * frame-base.c: Revert.
3207         * fork-child.c: Revert.
3208         * findvar.c: Revert.
3209         * findcmd.c: Revert.
3210         * filesystem.c: Revert.
3211         * filename-seen-cache.h: Revert.
3212         * filename-seen-cache.c: Revert.
3213         * fbsd-tdep.c: Revert.
3214         * fbsd-nat.h: Revert.
3215         * fbsd-nat.c: Revert.
3216         * f-valprint.c: Revert.
3217         * f-typeprint.c: Revert.
3218         * f-lang.c: Revert.
3219         * extension.h: Revert.
3220         * extension.c: Revert.
3221         * extension-priv.h: Revert.
3222         * expprint.c: Revert.
3223         * exec.h: Revert.
3224         * exec.c: Revert.
3225         * exceptions.c: Revert.
3226         * event-top.c: Revert.
3227         * event-loop.c: Revert.
3228         * eval.c: Revert.
3229         * elfread.c: Revert.
3230         * dwarf2read.h: Revert.
3231         * dwarf2read.c: Revert.
3232         * dwarf2loc.c: Revert.
3233         * dwarf2expr.h: Revert.
3234         * dwarf2expr.c: Revert.
3235         * dwarf2-frame.c: Revert.
3236         * dwarf2-frame-tailcall.c: Revert.
3237         * dwarf-index-write.h: Revert.
3238         * dwarf-index-write.c: Revert.
3239         * dwarf-index-common.c: Revert.
3240         * dwarf-index-cache.h: Revert.
3241         * dwarf-index-cache.c: Revert.
3242         * dummy-frame.c: Revert.
3243         * dtrace-probe.c: Revert.
3244         * disasm.h: Revert.
3245         * disasm.c: Revert.
3246         * disasm-selftests.c: Revert.
3247         * dictionary.c: Revert.
3248         * dicos-tdep.c: Revert.
3249         * demangle.c: Revert.
3250         * dcache.h: Revert.
3251         * dcache.c: Revert.
3252         * darwin-nat.h: Revert.
3253         * darwin-nat.c: Revert.
3254         * darwin-nat-info.c: Revert.
3255         * d-valprint.c: Revert.
3256         * d-namespace.c: Revert.
3257         * d-lang.c: Revert.
3258         * ctf.c: Revert.
3259         * csky-tdep.c: Revert.
3260         * csky-linux-tdep.c: Revert.
3261         * cris-tdep.c: Revert.
3262         * cris-linux-tdep.c: Revert.
3263         * cp-valprint.c: Revert.
3264         * cp-support.c: Revert.
3265         * cp-namespace.c: Revert.
3266         * cp-abi.c: Revert.
3267         * corelow.c: Revert.
3268         * corefile.c: Revert.
3269         * continuations.c: Revert.
3270         * completer.h: Revert.
3271         * completer.c: Revert.
3272         * complaints.c: Revert.
3273         * coffread.c: Revert.
3274         * coff-pe-read.c: Revert.
3275         * cli-out.h: Revert.
3276         * cli-out.c: Revert.
3277         * charset.c: Revert.
3278         * c-varobj.c: Revert.
3279         * c-valprint.c: Revert.
3280         * c-typeprint.c: Revert.
3281         * c-lang.c: Revert.
3282         * buildsym.c: Revert.
3283         * buildsym-legacy.c: Revert.
3284         * build-id.h: Revert.
3285         * build-id.c: Revert.
3286         * btrace.c: Revert.
3287         * bsd-uthread.c: Revert.
3288         * breakpoint.h: Revert.
3289         * breakpoint.c: Revert.
3290         * break-catch-throw.c: Revert.
3291         * break-catch-syscall.c: Revert.
3292         * break-catch-sig.c: Revert.
3293         * blockframe.c: Revert.
3294         * block.c: Revert.
3295         * bfin-tdep.c: Revert.
3296         * bfin-linux-tdep.c: Revert.
3297         * bfd-target.c: Revert.
3298         * bcache.c: Revert.
3299         * ax-general.c: Revert.
3300         * ax-gdb.h: Revert.
3301         * ax-gdb.c: Revert.
3302         * avr-tdep.c: Revert.
3303         * auxv.c: Revert.
3304         * auto-load.c: Revert.
3305         * arm-wince-tdep.c: Revert.
3306         * arm-tdep.c: Revert.
3307         * arm-symbian-tdep.c: Revert.
3308         * arm-pikeos-tdep.c: Revert.
3309         * arm-obsd-tdep.c: Revert.
3310         * arm-nbsd-tdep.c: Revert.
3311         * arm-nbsd-nat.c: Revert.
3312         * arm-linux-tdep.c: Revert.
3313         * arm-linux-nat.c: Revert.
3314         * arm-fbsd-tdep.c: Revert.
3315         * arm-fbsd-nat.c: Revert.
3316         * arm-bsd-tdep.c: Revert.
3317         * arch-utils.c: Revert.
3318         * arc-tdep.c: Revert.
3319         * arc-newlib-tdep.c: Revert.
3320         * annotate.h: Revert.
3321         * annotate.c: Revert.
3322         * amd64-windows-tdep.c: Revert.
3323         * amd64-windows-nat.c: Revert.
3324         * amd64-tdep.c: Revert.
3325         * amd64-sol2-tdep.c: Revert.
3326         * amd64-obsd-tdep.c: Revert.
3327         * amd64-obsd-nat.c: Revert.
3328         * amd64-nbsd-tdep.c: Revert.
3329         * amd64-nbsd-nat.c: Revert.
3330         * amd64-nat.c: Revert.
3331         * amd64-linux-tdep.c: Revert.
3332         * amd64-linux-nat.c: Revert.
3333         * amd64-fbsd-tdep.c: Revert.
3334         * amd64-fbsd-nat.c: Revert.
3335         * amd64-dicos-tdep.c: Revert.
3336         * amd64-darwin-tdep.c: Revert.
3337         * amd64-bsd-nat.c: Revert.
3338         * alpha-tdep.c: Revert.
3339         * alpha-obsd-tdep.c: Revert.
3340         * alpha-nbsd-tdep.c: Revert.
3341         * alpha-mdebug-tdep.c: Revert.
3342         * alpha-linux-tdep.c: Revert.
3343         * alpha-linux-nat.c: Revert.
3344         * alpha-bsd-tdep.c: Revert.
3345         * alpha-bsd-nat.c: Revert.
3346         * aix-thread.c: Revert.
3347         * agent.c: Revert.
3348         * addrmap.c: Revert.
3349         * ada-varobj.c: Revert.
3350         * ada-valprint.c: Revert.
3351         * ada-typeprint.c: Revert.
3352         * ada-tasks.c: Revert.
3353         * ada-lang.c: Revert.
3354         * aarch64-tdep.c: Revert.
3355         * aarch64-ravenscar-thread.c: Revert.
3356         * aarch64-newlib-tdep.c: Revert.
3357         * aarch64-linux-tdep.c: Revert.
3358         * aarch64-linux-nat.c: Revert.
3359         * aarch64-fbsd-tdep.c: Revert.
3360         * aarch64-fbsd-nat.c: Revert.
3361         * aarch32-linux-nat.c: Revert.
3362
3363 2019-04-05  Tom Tromey  <tom@tromey.com>
3364
3365         * ft32-tdep.c: Sort headers.
3366         * frv-tdep.c: Sort headers.
3367         * frv-linux-tdep.c: Sort headers.
3368         * frame.c: Sort headers.
3369         * frame-unwind.c: Sort headers.
3370         * frame-base.c: Sort headers.
3371         * fork-child.c: Sort headers.
3372         * findvar.c: Sort headers.
3373         * findcmd.c: Sort headers.
3374         * filesystem.c: Sort headers.
3375         * filename-seen-cache.h: Sort headers.
3376         * filename-seen-cache.c: Sort headers.
3377         * fbsd-tdep.c: Sort headers.
3378         * fbsd-nat.h: Sort headers.
3379         * fbsd-nat.c: Sort headers.
3380         * f-valprint.c: Sort headers.
3381         * f-typeprint.c: Sort headers.
3382         * f-lang.c: Sort headers.
3383         * extension.h: Sort headers.
3384         * extension.c: Sort headers.
3385         * extension-priv.h: Sort headers.
3386         * expprint.c: Sort headers.
3387         * exec.h: Sort headers.
3388         * exec.c: Sort headers.
3389         * exceptions.c: Sort headers.
3390         * event-top.c: Sort headers.
3391         * event-loop.c: Sort headers.
3392         * eval.c: Sort headers.
3393         * elfread.c: Sort headers.
3394         * dwarf2read.h: Sort headers.
3395         * dwarf2read.c: Sort headers.
3396         * dwarf2loc.c: Sort headers.
3397         * dwarf2expr.h: Sort headers.
3398         * dwarf2expr.c: Sort headers.
3399         * dwarf2-frame.c: Sort headers.
3400         * dwarf2-frame-tailcall.c: Sort headers.
3401         * dwarf-index-write.h: Sort headers.
3402         * dwarf-index-write.c: Sort headers.
3403         * dwarf-index-common.c: Sort headers.
3404         * dwarf-index-cache.h: Sort headers.
3405         * dwarf-index-cache.c: Sort headers.
3406         * dummy-frame.c: Sort headers.
3407         * dtrace-probe.c: Sort headers.
3408         * disasm.h: Sort headers.
3409         * disasm.c: Sort headers.
3410         * disasm-selftests.c: Sort headers.
3411         * dictionary.c: Sort headers.
3412         * dicos-tdep.c: Sort headers.
3413         * demangle.c: Sort headers.
3414         * dcache.h: Sort headers.
3415         * dcache.c: Sort headers.
3416         * darwin-nat.h: Sort headers.
3417         * darwin-nat.c: Sort headers.
3418         * darwin-nat-info.c: Sort headers.
3419         * d-valprint.c: Sort headers.
3420         * d-namespace.c: Sort headers.
3421         * d-lang.c: Sort headers.
3422         * ctf.c: Sort headers.
3423         * csky-tdep.c: Sort headers.
3424         * csky-linux-tdep.c: Sort headers.
3425         * cris-tdep.c: Sort headers.
3426         * cris-linux-tdep.c: Sort headers.
3427         * cp-valprint.c: Sort headers.
3428         * cp-support.c: Sort headers.
3429         * cp-namespace.c: Sort headers.
3430         * cp-abi.c: Sort headers.
3431         * corelow.c: Sort headers.
3432         * corefile.c: Sort headers.
3433         * continuations.c: Sort headers.
3434         * completer.h: Sort headers.
3435         * completer.c: Sort headers.
3436         * complaints.c: Sort headers.
3437         * coffread.c: Sort headers.
3438         * coff-pe-read.c: Sort headers.
3439         * cli-out.h: Sort headers.
3440         * cli-out.c: Sort headers.
3441         * charset.c: Sort headers.
3442         * c-varobj.c: Sort headers.
3443         * c-valprint.c: Sort headers.
3444         * c-typeprint.c: Sort headers.
3445         * c-lang.c: Sort headers.
3446         * buildsym.c: Sort headers.
3447         * buildsym-legacy.c: Sort headers.
3448         * build-id.h: Sort headers.
3449         * build-id.c: Sort headers.
3450         * btrace.c: Sort headers.
3451         * bsd-uthread.c: Sort headers.
3452         * breakpoint.h: Sort headers.
3453         * breakpoint.c: Sort headers.
3454         * break-catch-throw.c: Sort headers.
3455         * break-catch-syscall.c: Sort headers.
3456         * break-catch-sig.c: Sort headers.
3457         * blockframe.c: Sort headers.
3458         * block.c: Sort headers.
3459         * bfin-tdep.c: Sort headers.
3460         * bfin-linux-tdep.c: Sort headers.
3461         * bfd-target.c: Sort headers.
3462         * bcache.c: Sort headers.
3463         * ax-general.c: Sort headers.
3464         * ax-gdb.h: Sort headers.
3465         * ax-gdb.c: Sort headers.
3466         * avr-tdep.c: Sort headers.
3467         * auxv.c: Sort headers.
3468         * auto-load.c: Sort headers.
3469         * arm-wince-tdep.c: Sort headers.
3470         * arm-tdep.c: Sort headers.
3471         * arm-symbian-tdep.c: Sort headers.
3472         * arm-pikeos-tdep.c: Sort headers.
3473         * arm-obsd-tdep.c: Sort headers.
3474         * arm-nbsd-tdep.c: Sort headers.
3475         * arm-nbsd-nat.c: Sort headers.
3476         * arm-linux-tdep.c: Sort headers.
3477         * arm-linux-nat.c: Sort headers.
3478         * arm-fbsd-tdep.c: Sort headers.
3479         * arm-fbsd-nat.c: Sort headers.
3480         * arm-bsd-tdep.c: Sort headers.
3481         * arch-utils.c: Sort headers.
3482         * arc-tdep.c: Sort headers.
3483         * arc-newlib-tdep.c: Sort headers.
3484         * annotate.h: Sort headers.
3485         * annotate.c: Sort headers.
3486         * amd64-windows-tdep.c: Sort headers.
3487         * amd64-windows-nat.c: Sort headers.
3488         * amd64-tdep.c: Sort headers.
3489         * amd64-sol2-tdep.c: Sort headers.
3490         * amd64-obsd-tdep.c: Sort headers.
3491         * amd64-obsd-nat.c: Sort headers.
3492         * amd64-nbsd-tdep.c: Sort headers.
3493         * amd64-nbsd-nat.c: Sort headers.
3494         * amd64-nat.c: Sort headers.
3495         * amd64-linux-tdep.c: Sort headers.
3496         * amd64-linux-nat.c: Sort headers.
3497         * amd64-fbsd-tdep.c: Sort headers.
3498         * amd64-fbsd-nat.c: Sort headers.
3499         * amd64-dicos-tdep.c: Sort headers.
3500         * amd64-darwin-tdep.c: Sort headers.
3501         * amd64-bsd-nat.c: Sort headers.
3502         * alpha-tdep.c: Sort headers.
3503         * alpha-obsd-tdep.c: Sort headers.
3504         * alpha-nbsd-tdep.c: Sort headers.
3505         * alpha-mdebug-tdep.c: Sort headers.
3506         * alpha-linux-tdep.c: Sort headers.
3507         * alpha-linux-nat.c: Sort headers.
3508         * alpha-bsd-tdep.c: Sort headers.
3509         * alpha-bsd-nat.c: Sort headers.
3510         * aix-thread.c: Sort headers.
3511         * agent.c: Sort headers.
3512         * addrmap.c: Sort headers.
3513         * ada-varobj.c: Sort headers.
3514         * ada-valprint.c: Sort headers.
3515         * ada-typeprint.c: Sort headers.
3516         * ada-tasks.c: Sort headers.
3517         * ada-lang.c: Sort headers.
3518         * aarch64-tdep.c: Sort headers.
3519         * aarch64-ravenscar-thread.c: Sort headers.
3520         * aarch64-newlib-tdep.c: Sort headers.
3521         * aarch64-linux-tdep.c: Sort headers.
3522         * aarch64-linux-nat.c: Sort headers.
3523         * aarch64-fbsd-tdep.c: Sort headers.
3524         * aarch64-fbsd-nat.c: Sort headers.
3525         * aarch32-linux-nat.c: Sort headers.
3526
3527 2019-04-04  Tom Tromey  <tom@tromey.com>
3528
3529         * varobj.c (varobj_create): Update.
3530         * rust-exp.y (struct rust_parser) <update_innermost_block,
3531         lookup_symbol>: New methods.
3532         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3533         Rename.
3534         (rust_parser::rust_lookup_type)
3535         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3536         * printcmd.c (display_command, do_one_display): Update.
3537         * parser-defs.h (struct parser_state) <parser_state>: Add
3538         "tracker" parameter.
3539         (block_tracker): New member.
3540         (class innermost_block_tracker) <innermost_block_tracker>: Add
3541         "types" parameter.
3542         <reset>: Remove method.
3543         (innermost_block): Don't declare.
3544         (null_post_parser): Update.
3545         * parse.c (innermost_block): Remove global.
3546         (write_dollar_variable): Update.
3547         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3548         Remove "tracker_types" parameter.
3549         (parse_expression): Add "tracker" parameter.
3550         (parse_expression_for_completion): Update.
3551         (null_post_parser): Add "tracker" parameter.
3552         * p-exp.y: Update rules.
3553         * m2-exp.y: Update rules.
3554         * language.h (struct language_defn) <la_post_parser>: Add
3555         "tracker" parameter.
3556         * go-exp.y: Update rules.
3557         * f-exp.y: Update rules.
3558         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3559         parameter.
3560         * d-exp.y: Update rules.
3561         * c-exp.y: Update rules.
3562         * breakpoint.c (set_breakpoint_condition): Create an
3563         innermost_block_tracker.
3564         (watch_command_1): Likewise.
3565         * ada-lang.c (resolve): Add "tracker" parameter.
3566         (resolve_subexp): Likewise.
3567         * ada-exp.y (write_var_from_sym): Update.
3568
3569 2019-04-04  Tom Tromey  <tom@tromey.com>
3570
3571         * type-stack.h: New file.
3572         * type-stack.c: New file.
3573         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3574         type-stack.h.
3575         (insert_into_type_stack, insert_type, push_type, push_type_int)
3576         (insert_type_address_space, pop_type, pop_type_int)
3577         (pop_typelist, pop_type_stack, append_type_stack)
3578         (push_type_stack, get_type_stack, push_typelist)
3579         (follow_type_instance_flags, follow_types): Don't declare.
3580         * parse.c (type_stack): Remove global.
3581         (parse_exp_in_context): Update.
3582         (insert_into_type_stack, insert_type, push_type, push_type_int)
3583         (insert_type_address_space, pop_type, pop_type_int)
3584         (pop_typelist, pop_type_stack, append_type_stack)
3585         (push_type_stack, get_type_stack, push_typelist)
3586         (follow_type_instance_flags, follow_types): Remove (moved to
3587         type-stack.c).
3588         * f-exp.y (type_stack): New global.
3589         Update rules.
3590         (push_kind_type, f_parse): Update.
3591         * d-exp.y (type_stack): New global.
3592         Update rules.
3593         (d_parse): Update.
3594         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3595         Update rules.
3596         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3597         (HFILES_NO_SRCDIR): Add type-stack.h.
3598
3599 2019-04-04  Tom Tromey  <tom@tromey.com>
3600
3601         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3602         (rust_parser::convert_ast_to_expression, rust_parse)
3603         (rust_lex_test_completion, rust_lex_tests): Update.
3604         * parser-defs.h (struct expr_completion_state): New.
3605         (struct parser_state) <parser_state>: Add completion parameter.
3606         <mark_struct_expression, mark_completion_tag>: New methods.
3607         <parse_completion, m_completion_state>: New members.
3608         (prefixify_expression, null_post_parser): Update.
3609         (mark_struct_expression, mark_completion_tag): Don't declare.
3610         * parse.c (parse_completion, expout_last_struct)
3611         (expout_tag_completion_type, expout_completion_name): Remove
3612         globals.
3613         (parser_state::mark_struct_expression)
3614         (parser_state::mark_completion_tag): Now methods.
3615         (prefixify_expression): Add last_struct parameter.
3616         (prefixify_subexp): Likewise.
3617         (parse_exp_1): Update.
3618         (parse_exp_in_context): Add cstate parameter.  Update.
3619         (parse_expression_for_completion): Create an
3620         expr_completion_state.
3621         (null_post_parser): Add "completion" parameter.
3622         * p-exp.y: Update rules.
3623         (yylex): Update.
3624         * language.h (struct language_defn) <la_post_parser>: Add
3625         "completing" parameter.
3626         * go-exp.y: Update rules.
3627         (lex_one_token): Update.
3628         * expression.h (parse_completion): Don't declare.
3629         * d-exp.y: Update rules.
3630         (lex_one_token): Update rules.
3631         * c-exp.y: Update rules.
3632         (lex_one_token): Update.
3633         * ada-lang.c (resolve): Add "parse_completion" parameter.
3634         (resolve_subexp): Likewise.
3635         (ada_resolve_function): Likewise.
3636
3637 2019-04-04  Tom Tromey  <tom@tromey.com>
3638
3639         * parser-defs.h (struct parser_state) <start_arglist,
3640         end_arglist>: New methods.
3641         <arglist_len, m_funcall_chain>: New members.
3642         (arglist_len, start_arglist, end_arglist): Don't declare.
3643         * parse.c (arglist_len, funcall_chain): Remove global.
3644         (start_arglist, end_arglist): Remove functions.
3645         (parse_exp_in_context): Update.
3646         * p-exp.y: Update rules.
3647         * m2-exp.y: Update rules.
3648         * go-exp.y: Update rules.
3649         * f-exp.y: Update rules.
3650         * d-exp.y: Update rules.
3651         * c-exp.y: Update rules.
3652
3653 2019-04-04  Tom Tromey  <tom@tromey.com>
3654
3655         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3656         lex_operator, push_back>: New methods.
3657         Update all rules.
3658         (rust_parser::lex_hex, lex_escape): Rename and update.
3659         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3660         (rust_parser::lex_operator): Rename and update.
3661         (rust_parser::lex_number, rustyylex, rustyyerror)
3662         (rust_lex_test_init, rust_lex_test_sequence)
3663         (rust_lex_test_push_back, rust_lex_tests): Update.
3664         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3665         parameter.
3666         <lexptr, prev_lexptr>: New members.
3667         (lexptr, prev_lexptr): Don't declare.
3668         * parse.c (lexptr, prev_lexptr): Remove globals.
3669         (parse_exp_in_context): Update.
3670         * p-exp.y (yylex, yyerror): Update.
3671         * m2-exp.y (parse_number, yylex, yyerror): Update.
3672         * go-exp.y (lex_one_token, yyerror): Update.
3673         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3674         * d-exp.y (lex_one_token, yyerror): Update.
3675         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3676         (lex_one_token, yyerror): Update.
3677         * ada-lex.l (YY_INPUT): Update.
3678         (rewind_to_char): Update.
3679         * ada-exp.y (yyerror): Update.
3680
3681 2019-04-04  Tom Tromey  <tom@tromey.com>
3682
3683         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3684         * parser-defs.h (struct parser_state) <parser_state>: Add new
3685         parameter.
3686         <comma_terminates>: New member.
3687         (comma_terminates): Don't declare global.
3688         * parse.c (comma_terminates): Remove global.
3689         (parse_exp_in_context): Update.
3690         * p-exp.y (yylex): Update.
3691         * m2-exp.y (yylex): Update.
3692         * go-exp.y (lex_one_token): Update.
3693         * f-exp.y (yylex): Update.
3694         * d-exp.y (lex_one_token): Update.
3695         * c-exp.y (lex_one_token): Update.
3696         * ada-lex.l: Update.
3697
3698 2019-04-04  Tom Tromey  <tom@tromey.com>
3699
3700         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3701         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3702         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3703         * parser-defs.h (paren_depth): Don't declare.
3704         * parse.c (paren_depth): Remove global.
3705         (parse_exp_in_context): Update.
3706         * p-exp.y (paren_depth): New global.
3707         (pascal_parse): Initialize it.
3708         * m2-exp.y (paren_depth): New global.
3709         (m2_parse): Initialize it.
3710         * go-exp.y (paren_depth): New global.
3711         (go_parse): Initialize it.
3712         * f-exp.y (paren_depth): New global.
3713         (f_parse): Initialize it.
3714         * d-exp.y (paren_depth): New global.
3715         (d_parse): Initialize it.
3716         * c-exp.y (paren_depth): New global.
3717         (c_parse): Initialize it.
3718         * ada-lex.l (paren_depth): New global.
3719         (lexer_init): Initialize it.
3720
3721 2019-04-04  Tom Tromey  <tom@tromey.com>
3722
3723         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3724         (rust_parser::convert_ast_to_type)
3725         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3726         * parser-defs.h (struct parser_state) <parser_state>: Add
3727         parameters.  Initialize new members.
3728         <expression_context_block, expression_context_pc>: New members.
3729         * parse.c (expression_context_block, expression_context_pc):
3730         Remove globals.
3731         (parse_exp_in_context): Update.
3732         * p-exp.y: Update all rules.
3733         (yylex): Update.
3734         * m2-exp.y: Update all rules.
3735         (yylex): Update.
3736         * go-exp.y (yylex): Update.
3737         * f-exp.y (yylex): Update.
3738         * d-exp.y: Update all rules.
3739         (yylex): Update.
3740         * c-exp.y: Update all rules.
3741         (lex_one_token, classify_name, yylex, c_parse): Update.
3742         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3743
3744 2019-04-04  Tom Tromey  <tom@tromey.com>
3745
3746         * gdbarch.h, gdbarch.c: Rebuild.
3747         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3748         * stap-probe.h:
3749         (struct stap_parse_info): Replace "parser_state" with
3750         "expr_builder".
3751         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3752         (parser_state): New class.
3753         * parse.c (expr_builder): Rename.
3754         (expr_builder::release): Rename.
3755         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3756         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3757         (write_exp_elt_longcst, write_exp_elt_floatcst)
3758         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3759         (write_exp_string_vector, write_exp_bitstring)
3760         (write_exp_msymbol, mark_struct_expression)
3761         (write_dollar_variable)
3762         (insert_type_address_space, increase_expout_size): Replace
3763         "parser_state" with "expr_builder".
3764         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3765         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3766         "parser_state" with "expr_builder".
3767
3768 2019-04-04  Tom Tromey  <tom@tromey.com>
3769
3770         * rust-exp.y: Replace "parse_language" with method call.
3771         * p-exp.y:
3772         (yylex): Replace "parse_language" with method call.
3773         * m2-exp.y:
3774         (yylex): Replace "parse_language" with method call.
3775         * go-exp.y (classify_name): Replace "parse_language" with method
3776         call.
3777         * f-exp.y (yylex): Replace "parse_language" with method call.
3778         * d-exp.y (lex_one_token): Replace "parse_language" with method
3779         call.
3780         * c-exp.y:
3781         (lex_one_token, classify_name, yylex): Replace "parse_language"
3782         with method call.
3783         * ada-exp.y (find_primitive_type, type_char)
3784         (type_system_address): Replace "parse_language" with method call.
3785
3786 2019-04-04  Tom Tromey  <tom@tromey.com>
3787
3788         * rust-exp.y: Replace "parse_gdbarch" with method call.
3789         * parse.c (write_dollar_variable, insert_type_address_space):
3790         Replace "parse_gdbarch" with method call.
3791         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3792         call.
3793         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3794         call.
3795         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3796         "parse_gdbarch" with method call.
3797         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3798         with method call.
3799         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3800         "parse_gdbarch" with method call.
3801         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3802         "parse_gdbarch" with method call.
3803         * c-exp.y (parse_type, parse_number, classify_name): Replace
3804         "parse_gdbarch" with method call.
3805         * ada-lex.l: Replace "parse_gdbarch" with method call.
3806         * ada-exp.y (parse_type, find_primitive_type, type_char)
3807         (type_system_address): Replace "parse_gdbarch" with method call.
3808
3809 2019-04-04  Tom Tromey  <tom@tromey.com>
3810
3811         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3812         * stap-probe.c (stap_parse_argument): Update.
3813         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3814         initial_size parameter.
3815         * rust-exp.y (rust_lex_tests): Update.
3816         * parse.c (parser_state): Update.
3817         (parse_exp_in_context): Update.
3818         * parser-defs.h (struct parser_state) <parser_state>: Remove
3819         "initial_size" parameter.
3820
3821 2019-04-04  Tom Tromey  <tom@tromey.com>
3822
3823         * parser-defs.h (increase_expout_size): Don't declare.
3824         * parse.c (increase_expout_size): Now static.
3825
3826 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3827
3828         * gnu-nat.c (gnu_nat_target::wait): Fix
3829         target_waitstatus_to_string call.
3830
3831 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * eval.c (evaluate_subexp_standard): Handle internal functions
3834         during Fortran function call handling.
3835
3836 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * NEWS: Mention new internal functions.
3839         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3840         (read_base_type): Use dwarf2_init_complex_target_type.
3841         * value.c (creal_internal_fn): New function.
3842         (cimag_internal_fn): New function.
3843         (_initialize_values): Register new internal functions.
3844
3845 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3846
3847         * infrun.c (stop_all_threads): If debug_infrun, always
3848         trace the wait status after wait_one, using
3849         target_waitstatus_to_string and target_pid_to_str.
3850         (handle_inferior_event): Replace various trace of
3851         wait status kind by a single trace.
3852         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3853         wait status kind image by target_waitstatus_to_string.
3854         * target/waitstatus.c (target_waitstatus_to_string): Fix
3855         obsolete comment.
3856
3857 2019-04-01  Tom Tromey  <tromey@adacore.com>
3858
3859         PR symtab/23331:
3860         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3861
3862 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3863             Pedro Alves  <palves@redhat.com>
3864
3865         * top.c (quit_force): Call 'finalize_values'.
3866         * value.c (finalize_values): New function.
3867         * value.h (finalize_values): Declare.
3868
3869 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3870
3871         * NEWS: Announce $_gdb_major and $_gdb_minor.
3872
3873         * top.c (init_gdb_version_vars): New function.
3874         (gdb_init): Call init_gdb_version_vars.
3875
3876 2019-03-29  Tom Tromey  <tromey@adacore.com>
3877
3878         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3879         help text.  Remove dead code.
3880
3881 2019-03-29  Keith Seitz  <keiths@redhat.com>
3882
3883         From Siddhesh Poyarekar:
3884         * f-lang.h (f77_get_upperbound): Return LONGEST.
3885         (f77_get_lowerbound): Likewise.
3886         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3887         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3888         print them.
3889         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3890         plongest to format print it.
3891         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3892         (f77_get_upperbound): Likewise.
3893         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3894         LOWER_BOUND to LONGEST.
3895         (f77_create_arrayprint_offset_tbl): Likewise.
3896
3897 2019-03-29  Keith Seitz  <keiths@redhat.com>
3898
3899         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3900         %s/pulongest for TYPE_LENGTH instead of %d in format
3901         strings.
3902         * ada-typerint.c (ada_print_type): Likewise.
3903         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3904         * compile/compile-c-support.c (generate_register_struct): Likewise.
3905         * gdbtypes.c (recursive_dump_type): Likewise.
3906         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3907         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3908         instead of %d in format strings.
3909         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3910         to std::min to ULONGEST.
3911         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3912         instead of %d in format strings.
3913         * tracepoint.c (info_scope_command): Likewise.
3914         * typeprint.c (print_offset_data::update)
3915         (print_offset_data::finish): Likewise.
3916         * xtensa-tdep.c (xtensa_store_return_value)
3917         (xtensa_push_dummy_call): Likewise.
3918
3919 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3920
3921         * windows-nat.c (display_selector): Fixed format specifications
3922         for 64-bit Cygwin.
3923
3924 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3925
3926         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3927
3928 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3929
3930         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3931         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3932         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3933         (nios2_linux_init_abi): Install it.
3934
3935 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3936
3937         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3938
3939 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3940
3941         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3942
3943 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3944             Tom Tromey  <tromey@adacore.com>
3945
3946         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3947
3948 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3949
3950         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3951         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3952         method to compute the bounds of range types. Also print "[evaluated]"
3953         if the bounds' values come from a dynamic evaluation.
3954
3955 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3956
3957         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3958         whitespace when pretty printing is on.
3959
3960 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3961
3962         * ppc-linux-nat.c: Add include.
3963
3964 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3965
3966         * NEWS: Mention AArch64 Pointer Authentication.
3967
3968 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3969
3970         * arm-linux-nat.c: Add include.
3971
3972 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3973
3974         * source-cache.c (source_cache::get_source_lines): Re-read
3975         fullname after calling open_source_file.
3976
3977 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3978
3979         * NEWS: Mention TLS support for FreeBSD.
3980
3981 2019-03-25  Tom Tromey  <tromey@adacore.com>
3982
3983         * minsyms.c (BUNCH_SIZE): Update comment.
3984         (~minimal_symbol_reader): Remove old comment.
3985         (compact_minimal_symbols): Update comment.
3986         (minimal_symbol_reader::install): Remove old comment.  Update
3987         other comments.
3988
3989 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3990
3991         * s390-linux-nat.c: Add include.
3992
3993 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3994
3995         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3996         Call linux_get_hwcap.
3997         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3998         Likewise.
3999         (aarch64_linux_get_hwcap): Remove function.
4000         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4001         declaration.
4002         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4003         linux_get_hwcap.
4004         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4005         * linux-tdep.c (linux_get_hwcap): Add function.
4006         (linux_get_hwcap2): Likewise.
4007         * linux-tdep.h (linux_get_hwcap): Add declaration.
4008         (linux_get_hwcap2): Likewise.
4009         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4010         (ppc_linux_get_hwcap2): Likewise.
4011         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4012         linux_get_hwcap.
4013         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4014         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4015         (ppc_linux_nat_target::read_description): Likewise.
4016         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4017         * s390-linux-nat.c: Likewise.
4018         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4019
4020 2019-03-24  Tom Tromey  <tom@tromey.com>
4021
4022         * ada-lang.c (standard_lookup): Simplify initialization.
4023         (ada_lookup_symbol_nonlocal): Simplify return.
4024         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4025         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4026         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4027         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4028         initialization.
4029         * solib.c (solib_global_lookup): Simplify.
4030         * symtab.c (null_block_symbol): Remove.
4031         (symbol_cache_lookup): Simplify returns.
4032         (lookup_language_this): Simplify returns.
4033         (lookup_symbol_aux): Simplify return.
4034         (lookup_local_symbol): Simplify returns.
4035         (lookup_global_symbol_from_objfile): Simplify return.
4036         (lookup_symbol_in_objfile_symtabs)
4037         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4038         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4039         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4040         * cp-namespace.c (cp_lookup_bare_symbol)
4041         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4042         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4043         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4044         (cp_lookup_symbol_via_imports): Simplify initialization.
4045         (find_symbol_in_baseclass): Likewise.
4046         * symtab.h (null_block_symbol): Remove.
4047         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4048         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4049         (d_lookup_symbol_module): Likewise.
4050         (find_symbol_in_baseclass): Simplify initialization.
4051
4052 2019-03-24  Tom Tromey  <tom@tromey.com>
4053
4054         * expression.h: Don't include symtab.h.
4055         (struct block): Forward declare.
4056
4057 2019-03-24  Tom Tromey  <tom@tromey.com>
4058
4059         * c-exp.y (typebase): Remove casts.
4060         * gdbtypes.c (lookup_unsigned_typename, )
4061         (lookup_signed_typename): Remove cast.
4062         * eval.c (parse_to_comma_and_eval): Remove cast.
4063         * parse.c (write_dollar_variable): Remove cast.
4064         * block.h (struct block) <superblock>: Now const.
4065         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4066         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4067         (map_block): Make "block" const.
4068         * symfile.h (struct quick_symbol_functions)
4069         <map_matching_symbols>: Constify block argument to "callback".
4070         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4071         const.
4072         (find_pc_sect_compunit_symtab): Make "b" const.
4073         (find_symbol_at_address): Likewise.
4074         (search_symbols): Likewise.
4075         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4076         (dw2_debug_names_lookup_symbol): Likewise.
4077         (dw2_map_matching_symbols): Update.
4078         * p-valprint.c (pascal_val_print): Remove "block".
4079         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4080         (aux_add_nonlocal_symbols): Make "block" const.
4081         (resolve_subexp): Remove cast.
4082         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4083         const.
4084         (iterate_over_file_blocks): Likewise.
4085         * f-exp.y (%union) <bval>: Remove.
4086         * coffread.c (patch_opaque_types): Make "b" const.
4087         * spu-tdep.c (spu_catch_start): Make "block" const.
4088         * c-valprint.c (print_unpacked_pointer): Remove "block".
4089         * symmisc.c (dump_symtab_1): Make "b" const.
4090         (block_depth): Make "block" const.
4091         * d-exp.y (%union) <bval>: Remove.
4092         * cp-support.h (cp_lookup_rtti_type): Update.
4093         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4094         * psymtab.c (psym_lookup_symbol): Make "block" const.
4095         (maintenance_check_psymtabs): Make "b" const.
4096         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4097         (enumerate_locals, enumerate_args): Update.
4098         * python/py-symtab.c (stpy_global_block): Make "block" const.
4099         (stpy_static_block): Likewise.
4100         * inline-frame.c (block_starting_point_at): Make "new_block"
4101         const.
4102         * block.c (find_block_in_blockvector): Make return type const.
4103         (blockvector_for_pc_sect): Make "b" const.
4104         (find_block_in_blockvector): Make "b" const.
4105
4106 2019-03-23  Tom Tromey  <tom@tromey.com>
4107
4108         * varobj.c (varobj_create): Update.
4109         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4110         * printcmd.c (display_command, do_one_display): Don't reset
4111         innermost_block.
4112         * parser-defs.h (enum innermost_block_tracker_type): Move to
4113         expression.h.
4114         (innermost_block): Update comment.
4115         * parse.c (parse_exp_1): Add tracker_types parameter.
4116         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4117         tracker_types parameter.  Reset innermost_block.
4118         (parse_exp_in_context): Remove.
4119         (parse_expression_for_completion): Update.
4120         * objfiles.c (~objfile): Don't reset expression_context_block or
4121         innermost_block.
4122         * expression.h (enum innermost_block_tracker_type): Move from
4123         parser-defs.h.
4124         (parse_exp_1): Add tracker_types parameter.
4125         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4126         reset innermost_block.
4127
4128 2019-03-23  Tom Tromey  <tom@tromey.com>
4129
4130         * objfiles.h: Include bcache.h.
4131
4132 2019-03-23  Tom Tromey  <tom@tromey.com>
4133
4134         * linespec.c (get_current_search_block): Use
4135         scoped_restore_current_language.
4136         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4137
4138 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4139             Jiong Wang  <jiong.wang@arm.com>
4140
4141         * aarch64-linux-tdep.c
4142         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4143         section.
4144         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4145
4146 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4147             Jiong Wang  <jiong.wang@arm.com>
4148
4149         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4150         instructions.
4151         (aarch64_analyze_prologue_test): Add PACIASP test.
4152         (aarch64_prologue_prev_register): Unmask PC value.
4153
4154 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4155             Jiong Wang  <jiong.wang@arm.com>
4156
4157         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4158         (aarch64_dwarf2_prev_register): Unmask PC value.
4159         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4160         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4161         DW_CFA_AARCH64_negate_ra_state.
4162         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4163
4164 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4165             Jiong Wang  <jiong.wang@arm.com>
4166
4167         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4168         registers.
4169         (aarch64_pseudo_register_name): Likewise.
4170         (aarch64_pseudo_register_type): Likewise.
4171         (aarch64_pseudo_register_reggroup_p): Likewise.
4172         (aarch64_gdbarch_init): Add pauth registers.
4173         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4174         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4175         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4176         (struct gdbarch_tdep): Add regnum for ra_state.
4177
4178 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4179             Jiong Wang  <jiong.wang@arm.com>
4180
4181         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4182
4183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4184             Jiong Wang  <jiong.wang@arm.com>
4185
4186         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4187         function.
4188         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4189         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4190         (aarch64_gdbarch_init): Add puth registers.
4191         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4192         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4193         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4194
4195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4196             Jiong Wang  <jiong.wang@arm.com>
4197
4198         * aarch64-linux-nat.c
4199         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4200         * aarch64-linux-tdep.c
4201         (aarch64_linux_core_read_description): Likewise.
4202         (aarch64_linux_get_hwcap): New function.
4203         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4204         (aarch64_linux_get_hwcap): New declaration.
4205
4206 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4207             Jiong Wang  <jiong.wang@arm.com>
4208
4209         * aarch64-linux-nat.c
4210         (aarch64_linux_nat_target::read_description): Add pauth param.
4211         * aarch64-linux-tdep.c
4212         (aarch64_linux_core_read_description): Likewise.
4213         * aarch64-tdep.c (struct target_desc): Add in pauth.
4214         (aarch64_read_description): Add pauth param.
4215         (aarch64_gdbarch_init): Likewise.
4216         * aarch64-tdep.h (aarch64_read_description): Likewise.
4217         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4218         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4219         * features/Makefile: Add new files.
4220         * features/aarch64-pauth.c: New file.
4221         * features/aarch64-pauth.xml: New file.
4222
4223 2019-03-20  Tom Tromey  <tromey@adacore.com>
4224
4225         * infrun.c (handle_inferior_event): Rename from
4226         handle_inferior_event_1.  Create a scoped_value_mark.
4227         (handle_inferior_event): Remove.
4228
4229 2019-03-19  Tom Tromey  <tromey@adacore.com>
4230
4231         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4232         * infrun.h (print_stop_event): Add "displays" parameter.
4233         * infrun.c (print_stop_event): Add "displays" parameter.
4234
4235 2019-03-19  Pedro Alves  <palves@redhat.com>
4236
4237         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4238         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4239         to -1.  Fix TABs vs spaces.
4240         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4241         * tui/tui-out.h (tui_ui_out) Add intro comments.
4242         <m_line, m_start_of_line>: In-class initialize, and add describing
4243         comment.
4244
4245 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4246
4247         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4248         variable names.
4249         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4250
4251 2019-03-18  Pedro Alves  <palves@redhat.com>
4252             Eli Zaretskii <eliz@gnu.org>
4253
4254         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4255         m_line and m_start_of_line.
4256
4257 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4258
4259         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4260         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4261         it returns a newline.  This fixes a regression in TU mode, whereby
4262         the next line is output on the same screen line as the user input.
4263
4264 2019-03-18  Tom Tromey  <tromey@adacore.com>
4265
4266         * minsyms.c (minimal_symbol_reader::install): Remove call to
4267         obstack_blank.
4268
4269 2019-03-18  Pedro Alves  <palves@redhat.com>
4270
4271         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4272         New globals.
4273         (apply_style): New, factored out from ...
4274         (apply_ansi_escape): ... this.  Handle reverse video mode.
4275         (tui_set_reverse_mode): New function.
4276         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4277         * tui/tui-winsource.c (tui_show_source_line): Use
4278         tui_set_reverse_mode instead of setting A_STANDOUT.
4279         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4280         New setter methods.
4281
4282 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4283
4284         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4285         Handle tabs.
4286
4287 2019-03-18  Tom Tromey  <tromey@adacore.com>
4288
4289         * ada-lang.c (empty_array): Add "high" parameter.
4290         (ada_evaluate_subexp): Update.
4291
4292 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4293
4294         * unittests/string_view-selftests.c: Define
4295         _initialize_string_view_selftests unconditionally.
4296
4297 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4298
4299         PR gdb/24350
4300         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4301
4302 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4303
4304         PR gdb/24351
4305         * windows-nat.c (display_selector): Fix format specifiers.
4306
4307 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4308
4309         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4310         tui_refill_source_window instead of tui_refresh_win, to update the
4311         current execution line.  This fixes redisplay of the current line
4312         when stepping through the code with "next" or "step".
4313
4314 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4315
4316         * source-cache.c (source_cache::get_source_lines): Call
4317         find_source_lines to initialize s->nlines.  This fixes vertical
4318         scrolling of TUI source window when the DOWN arrow is pressed.
4319
4320 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4321
4322         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4323         linux-thread-db.c (_initialize_thread_db): Likewise.
4324
4325 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4326
4327         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4328         wclrtoeol in tui_show_source_line".  This reverts changes made in
4329         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4330
4331 2019-03-15  Tom Tromey  <tom@tromey.com>
4332
4333         * symtab.h (struct minimal_symbol): Derive from
4334         general_symbol_info.
4335         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4336         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4337         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4338         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4339         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4340         (MSYMBOL_SEARCH_NAME): Update.
4341         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4342         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4343         * minsyms.c (minimal_symbol_reader::record_full): Update.
4344
4345 2019-03-15  Tom Tromey  <tom@tromey.com>
4346
4347         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4348
4349 2019-03-15  Tom Tromey  <tom@tromey.com>
4350
4351         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4352         unique_xmalloc_ptr.
4353         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4354         Update.
4355         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4356         (build_minimal_symbol_hash_tables)
4357         (minimal_symbol_reader::install): Update.
4358
4359 2019-03-15  Tom Tromey  <tom@tromey.com>
4360
4361         * symtab.c (create_demangled_names_hash): Update.
4362         (symbol_set_names): Update.
4363         * objfiles.h (struct objfile_per_bfd_storage)
4364         <demangled_names_hash>: Now an htab_up.
4365         * objfiles.c (objfile_per_bfd_storage): Simplify.
4366
4367 2019-03-15  Tom Tromey  <tom@tromey.com>
4368
4369         * objfiles.h (struct objfile_per_bfd_storage): Declare
4370         destructor.
4371         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4372         New.
4373         (get_objfile_bfd_data): Use new.  Don't initialize
4374         language_of_main.
4375         (free_objfile_per_bfd_storage): Remove.
4376         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4377
4378 2019-03-15  Tom Tromey  <tom@tromey.com>
4379
4380         * symfile.c (reread_symbols): Update.
4381         * objfiles.c (objfile::objfile): Update.
4382         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4383         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4384         comment.
4385         (minimal_symbol_reader::install): Update.
4386         (terminate_minimal_symbol_table): Remove.
4387         * jit.c (jit_object_close_impl): Update.
4388
4389 2019-03-15  Tom Tromey  <tom@tromey.com>
4390
4391         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4392         initializations.
4393
4394 2019-03-15  Tom Tromey  <tom@tromey.com>
4395
4396         * objfiles.h (struct objfile_per_bfd_storage)
4397         <demangled_hash_languages>: Now a bitset.
4398         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4399         (lookup_minimal_symbol): Update.
4400
4401 2019-03-15  Tom Tromey  <tom@tromey.com>
4402
4403         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4404         Don't return the symbol.
4405         * coffread.c (record_minimal_symbol): Use record_full.
4406
4407 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4408
4409         The MS-Windows port of ncurses fails to switch to a color pair if
4410         one or both of the colors are the implicit default colors.  This
4411         change records the default colors when TUI is initialized, and
4412         then specifies them explicitly when a color pair uses the default
4413         colors.  This allows color styling in TUI mode on MS-Windows.
4414
4415         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4416         ncurses_norm_attr.
4417         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4418         colors in ncurses_norm_attr.
4419         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4420         "none", replace it with the default color recorded in
4421         ncurses_norm_attr.
4422
4423 2019-03-14  Tom Tromey  <tromey@adacore.com>
4424
4425         * source-cache.h (class source_cache) <get_source_lines>: Return
4426         std::string.
4427         * source-cache.c (source_cache::extract_lines): Handle case where
4428         first_pos==npos.  Return std::string.
4429         (source_cache::get_source_lines): Update.
4430
4431 2019-03-14  Tom Tromey  <tromey@adacore.com>
4432
4433         * NEWS: Add item for "style sources" commands.
4434         * source-cache.c (source_cache::get_source_lines): Check
4435         source_styling.
4436         * cli/cli-style.c (source_styling): New global.
4437         (_initialize_cli_style): Add "style sources" commands.
4438         (show_style_sources): New function.
4439         * cli/cli-style.h (source_styling): Declare.
4440
4441 2019-03-14  Pedro Alves  <palves@redhat.com>
4442             Tom Tromey  <tromey@adacore.com>
4443
4444         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4445         * tui/tui-winsource.c (tui_refill_source_window): New function,
4446         from...
4447         (tui_horizontal_source_scroll): ... here.  Move some logic.
4448         * cli/cli-style.c (set_style_enabled): Notify new observable.
4449         * tui/tui-hooks.c (tui_redisplay_source): New function.
4450         (tui_attach_detach_observers): Attach or detach
4451         tui_redisplay_source.
4452         * observable.h (source_styling_changed): New observable.
4453         * observable.c: Define source_styling_changed observable.
4454
4455 2019-03-13  Tom Tromey  <tromey@adacore.com>
4456
4457         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4458         (i386_gnu_nat_target::store_registers): Update.
4459         * target-debug.h (target_debug_print_std_string): New macro.
4460         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4461         * windows-tdep.c (display_one_tib): Update.
4462         * tui/tui-stack.c (tui_make_status_line): Update.
4463         * top.c (print_inferior_quit_action): Update.
4464         * thread.c (thr_try_catch_cmd): Update.
4465         (add_thread_with_info): Update.
4466         (thread_target_id_str): Update.
4467         (thr_try_catch_cmd): Update.
4468         (thread_command): Update.
4469         (thread_find_command): Update.
4470         * record-btrace.c (record_btrace_target::info_record)
4471         (record_btrace_resume_thread, record_btrace_target::resume)
4472         (record_btrace_cancel_resume, record_btrace_step_thread)
4473         (record_btrace_target::wait, record_btrace_target::wait)
4474         (record_btrace_target::wait, record_btrace_target::stop): Update.
4475         * progspace.c (print_program_space): Update.
4476         * process-stratum-target.c
4477         (process_stratum_target::thread_address_space): Update.
4478         * linux-fork.c (linux_fork_mourn_inferior)
4479         (detach_checkpoint_command, info_checkpoints_command)
4480         (linux_fork_context): Update.
4481         (linux_fork_detach): Update.
4482         (class scoped_switch_fork_info): Update.
4483         (delete_checkpoint_command): Update.
4484         * infrun.c (follow_fork_inferior): Update.
4485         (follow_fork_inferior): Update.
4486         (proceed_after_vfork_done): Update.
4487         (handle_vfork_child_exec_or_exit): Update.
4488         (follow_exec): Update.
4489         (displaced_step_prepare_throw): Update.
4490         (displaced_step_restore): Update.
4491         (start_step_over): Update.
4492         (resume_1): Update.
4493         (clear_proceed_status_thread): Update.
4494         (proceed): Update.
4495         (print_target_wait_results): Update.
4496         (do_target_wait): Update.
4497         (context_switch): Update.
4498         (stop_all_threads): Update.
4499         (restart_threads): Update.
4500         (finish_step_over): Update.
4501         (handle_signal_stop): Update.
4502         (switch_back_to_stepped_thread): Update.
4503         (keep_going_pass_signal): Update.
4504         (print_exited_reason): Update.
4505         (normal_stop): Update.
4506         * inferior.c (inferior_pid_to_str): Change return type.
4507         (print_selected_inferior): Update.
4508         (add_inferior): Update.
4509         (detach_inferior): Update.
4510         * dummy-frame.c (fprint_dummy_frames): Update.
4511         * dcache.c (dcache_info_1): Update.
4512         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4513         (btrace_fetch, btrace_clear): Update.
4514         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4515         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4516         type.
4517         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4518         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4519         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4520         * gdbarch.c, gdbarch.h: Rebuild.
4521         * gdbarch.sh (core_pid_to_str): Change return type.
4522         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4523         return type.
4524         (windows_nat_target::pid_to_str): Change return type.
4525         (windows_delete_thread): Update.
4526         (windows_nat_target::attach): Update.
4527         (windows_nat_target::files_info): Update.
4528         * target-delegates.c: Rebuild.
4529         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4530         return type.
4531         (sol_thread_target::pid_to_str): Change return type.
4532         * remote.c (class remote_target) <pid_to_str>: Change return
4533         type.
4534         (remote_target::pid_to_str): Change return type.
4535         (extended_remote_target::attach, remote_target::remote_stop_ns)
4536         (remote_target::remote_notif_remove_queued_reply)
4537         (remote_target::push_stop_reply, remote_target::disable_btrace):
4538         Update.
4539         (extended_remote_target::attach): Update.
4540         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4541         type.
4542         (gdbsim_target::pid_to_str): Change return type.
4543         * ravenscar-thread.c (struct ravenscar_thread_target)
4544         <pid_to_str>: Change return type.
4545         (ravenscar_thread_target::pid_to_str): Change return type.
4546         * procfs.c (class procfs_target) <pid_to_str>: Change return
4547         type.
4548         (procfs_target::pid_to_str): Change return type.
4549         (procfs_target::attach): Update.
4550         (procfs_target::detach): Update.
4551         (procfs_target::fetch_registers): Update.
4552         (procfs_target::store_registers): Update.
4553         (procfs_target::wait): Update.
4554         (procfs_target::files_info): Update.
4555         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4556         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4557         return type.
4558         (nto_procfs_target::pid_to_str): Change return type.
4559         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4560         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4561         return type.
4562         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4563         (exit_lwp): Update.
4564         (attach_proc_task_lwp_callback, get_detach_signal)
4565         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4566         (linux_nat_target::resume, wait_lwp, stop_callback)
4567         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4568         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4569         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4570         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4571         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4572         type.
4573         (inf_ptrace_target::attach): Update.
4574         (inf_ptrace_target::files_info): Update.
4575         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4576         type.
4577         (go32_nat_target::pid_to_str): Change return type.
4578         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4579         (gnu_nat_target::wait): Update.
4580         (gnu_nat_target::wait): Update.
4581         (gnu_nat_target::resume): Update.
4582         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4583         (fbsd_nat_target::wait): Update.
4584         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4585         type.
4586         (darwin_nat_target::attach): Update.
4587         * corelow.c (class core_target) <pid_to_str>: Change return type.
4588         (core_target::pid_to_str): Change return type.
4589         * target.c (normal_pid_to_str): Change return type.
4590         (default_pid_to_str): Likewise.
4591         (target_pid_to_str): Change return type.
4592         (target_translate_tls_address): Update.
4593         (target_announce_detach): Update.
4594         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4595         return type.
4596         (bsd_uthread_target::pid_to_str): Change return type.
4597         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4598         type.
4599         (bsd_kvm_target::pid_to_str): Change return type.
4600         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4601         return type.
4602         (aix_thread_target::pid_to_str): Change return type.
4603         * target.h (struct target_ops) <pid_to_str>: Change return type.
4604         (target_pid_to_str, normal_pid_to_str): Likewise.
4605         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4606         type.
4607         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4608         type.
4609         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4610         return type.
4611         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4612         type.
4613         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4614         type.
4615         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4616         return type.
4617
4618 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4619
4620         * NEWS: Mention that the new default MI version is 3.  Mention
4621         changes to the output of commands and events that deal with
4622         multi-location breakpoints.
4623         * breakpoint.c: Include "mi/mi-out.h".
4624         (print_one_breakpoint): Change output syntax if using MI version
4625         >= 3.
4626         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4627         New.
4628         (mi_multi_location_breakpoint_output_fixed): New.
4629         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4630         (mi_cmd_fix_multi_location_breakpoint_output): New.
4631         (mi_multi_location_breakpoint_output_fixed): New.
4632         * mi/mi-cmds.c (mi_cmds): Register command
4633         -fix-multi-location-breakpoint-output.
4634         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4635         interpreter "mi".
4636
4637 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4638
4639         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4640         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4641         instantiate mi_ui_out based on interpreter name.
4642         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4643         * mi/mi-main.c (mi_load_progress): Likewise.
4644
4645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4646
4647         * NEWS: Combine separate "New targets" sections for 8.3.
4648
4649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4650
4651         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4652         (ppcfbsd_init_abi): Install gdbarch
4653         "fetch_tls_load_module_address" and "get_thread_local_address"
4654         methods.
4655
4656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4657
4658         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4659         (riscv_fbsd_init_abi): Install gdbarch
4660         "fetch_tls_load_module_address" and "get_thread_local_address"
4661         methods.
4662
4663 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4664
4665         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4666         (i386fbsd_init_abi): Install gdbarch
4667         "fetch_tls_load_module_address" and "get_thread_local_address"
4668         methods.
4669
4670 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4671
4672         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4673         (amd64fbsd_init_abi): Install gdbarch
4674         "fetch_tls_load_module_address" and "get_thread_local_address"
4675         methods.
4676
4677 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4678
4679         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4680         (struct fbsd_pspace_data): New type.
4681         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4682         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4683         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4684         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4685         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4686
4687 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4688
4689         * gdbtypes.c (lookup_struct_elt): New function.
4690         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4691         * gdbtypes.h (struct struct_elt): New type.
4692         (lookup_struct_elt): New prototype.
4693
4694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4695
4696         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4697         remove disabled code block.
4698
4699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4700
4701         * gdbarch.sh (get_thread_local_address): New method.
4702         * gdbarch.h, gdbarch.c: Regenerate.
4703         * target.c (target_translate_tls_address): Use
4704         gdbarch_get_thread_local_address if present instead of
4705         target::get_thread_local_address.
4706
4707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4708
4709         * target.h (target::get_thread_local_address): Update comment.
4710
4711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4712
4713         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4714         objfile->separate_debug_objfile_backlink if not NULL.
4715
4716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4717
4718         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4719         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4720         (amd64bsd_store_inferior_registers): Likewise.
4721         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4722         Enable segment base registers.
4723         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4724         PT_GETFSBASE and PT_GETGSBASE.
4725         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4726         PT_SETGSBASE.
4727         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4728         segment base registers.
4729         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4730
4731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4732
4733         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4734         Update calls to i386_target_description to add 'segments'
4735         parameter.
4736         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4737         add segment base registers.
4738         * arch/i386.c (i386_create_target_description): Add 'segments'
4739         parameter to enable segment base registers.
4740         * arch/i386.h (i386_create_target_description): Likewise.
4741         * features/i386/32bit-segments.xml: New file.
4742         * features/i386/32bit-segments.c: Generate.
4743         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4744         call to i386_target_description to add 'segments' parameter.
4745         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4746         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4747         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4748         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4749         if feature is present.
4750         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4751         Add 'segments' parameter to call to i386_target_description.
4752         (i386_target_description): Add 'segments' parameter to enable
4753         segment base registers.
4754         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4755         to call to i386_target_description.
4756         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4757         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4758         Define I386_NUM_REGS.
4759         (i386_target_description): Add 'segments' parameter to enable
4760         segment base registers.
4761
4762 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4763
4764         PR/24325
4765         * source-cache.c: #undef open and close, to avoid unresolved
4766         externals during linking.
4767
4768 2019-03-12  Tom Tromey  <tromey@adacore.com>
4769
4770         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4771         const.  Add initializers.
4772         (_initialize_remote): Don't initialize ptid globals.
4773
4774 2019-03-12  Pedro Alves  <palves@redhat.com>
4775
4776         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4777
4778 2019-03-12  Pedro Alves  <palves@redhat.com>
4779
4780         * cp-name-parser.y (main): Remove unused 'len' variable.
4781
4782 2019-03-12  Tom Tromey  <tromey@adacore.com>
4783
4784         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4785         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4786
4787 2019-03-12  Tom Tromey  <tromey@adacore.com>
4788
4789         * linux-nat.c (iterate_over_lwps): Update.
4790         (stop_callback): Remove parameter.
4791         (stop_wait_callback, detach_callback, resume_set_callback)
4792         (select_singlestep_lwp_callback, set_ignore_sigint)
4793         (status_callback, resumed_callback, resume_clear_callback)
4794         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4795         data parameter.
4796         (linux_nat_target::detach, linux_nat_target::resume)
4797         (linux_stop_and_wait_all_lwps, select_event_lwp)
4798         (linux_nat_filter_event, linux_nat_wait_1)
4799         (linux_nat_target::kill, linux_nat_target::stop)
4800         (linux_nat_target::stop): Update.
4801         (linux_nat_resume_callback): Change type.
4802         (resume_stopped_resumed_lwps, count_events_callback)
4803         (select_event_lwp_callback): Likewise.
4804         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4805         * arm-linux-nat.c (struct update_registers_data): Remove.
4806         (update_registers_callback): Change type.
4807         (arm_linux_insert_hw_breakpoint1): Update.
4808         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4809         parameter.
4810         (x86_linux_dr_set_addr): Update.
4811         (x86_linux_dr_set_control): Update.
4812         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4813         (iterate_over_lwps): Use gdb::function_view.
4814         * nat/aarch64-linux-hw-point.c (struct
4815         aarch64_dr_update_callback_param): Remove.
4816         (debug_reg_change_callback): Change type.
4817         (aarch64_notify_debug_reg_change): Update.
4818         * s390-linux-nat.c (s390_refresh_per_info): Update.
4819
4820 2019-03-11  Tom Tromey  <tromey@adacore.com>
4821
4822         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4823         redundant assignment to "this_cu".
4824
4825 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4826
4827         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4828
4829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4830
4831         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4832         from...
4833         (rank_one_type): ... this.
4834
4835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4836
4837         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4838         from...
4839         (rank_one_type): ... this.
4840
4841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4842
4843         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4844         from...
4845         (rank_one_type): ... this.
4846
4847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4848
4849         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4850         from...
4851         (rank_one_type): ... this.
4852
4853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4854
4855         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4856         from...
4857         (rank_one_type): ... this.
4858
4859 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4860
4861         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4862         from...
4863         (rank_one_type): ... this.
4864
4865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4866
4867         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4868         from...
4869         (rank_one_type): ... this.
4870
4871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4872
4873         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4874         from...
4875         (rank_one_type): ... this.
4876
4877 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4878
4879         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4880         from...
4881         (rank_one_type): ... this.
4882
4883 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4884
4885         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4886         from...
4887         (rank_one_type): ... this.
4888
4889 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4890
4891         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4892         from...
4893         (rank_one_type): ... this.
4894
4895 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4896
4897         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4898         from...
4899         (rank_one_type): ... this.
4900
4901 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4902
4903         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4904         inferior-events' shows the example events.
4905
4906 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4907
4908         Support styling on native MS-Windows console
4909
4910         PR/24315
4911         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4912         on MS-Windows if $TERM is not defined.
4913
4914         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4915
4916         * posix-hdep.c (gdb_console_fputs):
4917         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4918         functions.
4919         * ui-file.h (gdb_console_fputs): Add prototype.
4920
4921         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4922         back to fputs only if the former returns zero.
4923
4924 2019-03-07  Tom Tromey  <tom@tromey.com>
4925
4926         * symmisc.c (print_symbol_bcache_statistics): Update.
4927         (print_objfile_statistics): Update.
4928         * symfile.c (allocate_symtab): Update.
4929         * stabsread.c: Don't include bcache.h.
4930         * psymtab.h (struct psymbol_bcache): Don't declare.
4931         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4932         (psymbol_bcache_init, psymbol_bcache_free)
4933         (psymbol_bcache_get_bcache): Don't declare.
4934         * psymtab.c (struct psymbol_bcache): Remove.
4935         (psymtab_storage::psymtab_storage): Update.
4936         (psymtab_storage::~psymtab_storage): Update.
4937         (psymbol_bcache_init, psymbol_bcache_free)
4938         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4939         (add_psymbol_to_bcache): Update.
4940         (allocate_psymtab): Update.
4941         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4942         macro_cache>: No longer pointers.
4943         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4944         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4945         * macrotab.c (macro_bcache): Update.
4946         * macroexp.c: Don't include bcache.h.
4947         * gdbtypes.c (check_types_worklist): Update.
4948         (types_deeply_equal): Remove TRY/CATCH.  Update.
4949         * elfread.c (elf_symtab_read): Update.
4950         * dwarf2read.c: Don't include bcache.h.
4951         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4952         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4953         (print_bcache_statistics, bcache_memory_used): Don't declare.
4954         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4955         methods.  Rename all data members.
4956         * bcache.c (struct bcache): Move to bcache.h.
4957         (bcache::expand_hash_table): Rename from expand_hash_table.
4958         (bcache): Remove.
4959         (bcache::insert): Rename from bcache_full.
4960         (bcache::compare): Rename from bcache_compare.
4961         (bcache_xmalloc): Remove.
4962         (bcache::~bcache): Rename from bcache_xfree.
4963         (bcache::print_statistics): Rename from print_bcache_statistics.
4964         (bcache::memory_used): Rename from bcache_memory_used.
4965
4966 2019-03-07  Pedro Alves  <palves@redhat.com>
4967
4968         * infrun.c (normal_stop): Also check for
4969         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4970
4971 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4972
4973         * f-lang.c (value_from_host_double): Moved to...
4974         * value.c (value_from_host_double): ...here.
4975         * value.h (value_from_host_double): Declare.
4976         * guile/scm-math.c (vlscm_convert_typed_number): Use
4977         value_from_host_double.
4978         (vlscm_convert_number): Likewise.
4979         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4980         * python/py-value.c (convert_value_from_python): Likewise.
4981
4982 2019-03-06  Tom Tromey  <tom@tromey.com>
4983
4984         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4985
4986 2019-03-06  Tom Tromey  <tom@tromey.com>
4987
4988         * utils.h (free_current_contents): Don't declare.
4989         * utils.c (free_current_contents): Remove.
4990
4991 2019-03-06  Tom Tromey  <tom@tromey.com>
4992
4993         * top.c (quit_force): Update.
4994         * main.c (captured_command_loop): Update.
4995         * common/new-op.c (operator new): Update.
4996         * common/common-exceptions.c (struct catcher)
4997         <save_cleanup_chain>: Remove member.
4998         (exceptions_state_mc_init): Update.
4999         (exception_try_scope_entry): Return nullptr.
5000         (exception_try_scope_exit, exception_rethrow)
5001         (throw_exception_sjlj, throw_exception_cxx): Update.
5002         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5003         (all_cleanups, do_cleanups, discard_cleanups)
5004         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5005         (restore_cleanups, restore_final_cleanups): Don't declare.
5006         (do_final_cleanups): Remove parameter.
5007         * common/cleanups.c (cleanup_chain, make_cleanup)
5008         (make_cleanup_dtor, all_cleanups, do_cleanups)
5009         (discard_my_cleanups, discard_cleanups)
5010         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5011         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5012         (null_cleanup): Remove.
5013         (do_final_cleanups): Remove parameter.
5014
5015 2019-03-06  Tom Tromey  <tom@tromey.com>
5016
5017         * remote.c (remote_target::remote_parse_stop_reply): Use
5018         unique_xmalloc_ptr.
5019
5020 2019-03-06  Tom Tromey  <tom@tromey.com>
5021
5022         * stabsread.c (struct stabs_field_info): Rename from field_info.
5023         <list, fnlist>: Add initializers.
5024         <obstack>: New member.
5025         (read_member_functions, read_struct_fields, read_baseclasses):
5026         Allocate on obstack.  Don't use cleanups.
5027         (read_one_struct_field, read_member_functions, read_struct_fields)
5028         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5029         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5030         (read_struct_type): Update.
5031
5032 2019-03-06  Tom Tromey  <tom@tromey.com>
5033
5034         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5035         * common/filestuff.h (make_cleanup_close): Don't declare.
5036         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5037         Remove.
5038
5039 2019-03-06  Tom Tromey  <tom@tromey.com>
5040
5041         * solib-aix.c: Use make_scope_exit.
5042
5043 2019-03-06  Tom Tromey  <tom@tromey.com>
5044
5045         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5046         Use make_scope_exit.
5047
5048 2019-03-06  Tom Tromey  <tom@tromey.com>
5049
5050         * solib-svr4.c (disable_probes_interface): Remove parameter.
5051         (svr4_handle_solib_event): Use make_scope_exit.
5052
5053 2019-03-06  Tom Tromey  <tom@tromey.com>
5054
5055         * remote.c (struct stop_reply_deleter): Remove.
5056         (stop_reply_up): Update.
5057         (struct stop_reply): Derive from notif_event.  Don't typedef.
5058         <regcache>: Now a std::vector.
5059         (stop_reply_xfree): Remove.
5060         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5061         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5062         (remote_target::discard_pending_stop_replies): Use delete.
5063         (remote_target::remote_parse_stop_reply): Update.
5064         (remote_target::process_stop_reply): Update.
5065         * remote-notif.h (struct notif_event): Add virtual destructor.
5066         Remove "dtr" member.
5067         (struct notif_client) <alloc_event>: Return a unique_ptr.
5068         (notif_event_xfree): Don't declare.
5069         (notif_event_up): New typedef.
5070         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5071         (notif_event_xfree, do_notif_event_xfree): Remove.
5072         (remote_notif_state_xfree): Update.
5073
5074 2019-03-06  Tom Tromey  <tom@tromey.com>
5075
5076         * infrun.c (displaced_step_clear_cleanup): Now a
5077         forward_scope_exit type.
5078         (displaced_step_prepare_throw): Update.
5079         (displaced_step_fixup): Update.
5080
5081 2019-03-06  Tom Tromey  <tom@tromey.com>
5082
5083         * inferior.h (class inferior): Update comment.
5084         * gdbthread.h (class thread_info): Update comment.
5085
5086 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5087             Tom Tromey  <tom@tromey.com>
5088
5089         * stabsread.h (struct stab_section_list): Remove.
5090         (coffstab_build_psymtabs): Update.
5091         * dbxread.c (symbuf_sections): Now a std::vector.
5092         (sect_idx): New global.
5093         (fill_symbuf): Update.
5094         (coffstab_build_psymtabs): Change type of stabsects parameter.
5095         Update.
5096         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5097         std::vector.
5098         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5099         (coff_locate_sections): Update.
5100         (coff_symfile_read): Remove cleanups.  Update.
5101         (init_stringtab): Add storage parameter.
5102         (free_stringtab, free_stringtab_cleanup): Remove.
5103         (init_lineno): Add storage parameter.
5104         (free_linetab, free_linetab_cleanup): Remove.
5105
5106 2019-03-06  Pedro Alves  <palves@redhat.com>
5107
5108         * linux-fork.c (fork_info::clobber_regs): Delete.
5109         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5110         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5111         comment.  Adjust.
5112         (scoped_switch_fork_info::scoped_switch_fork_info)
5113         (checkpoint_command, linux_fork_context): Adjust
5114         fork_save_infrun_state calls.
5115
5116 2019-03-06  Pedro Alves  <palves@redhat.com>
5117
5118         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5119         (inf_has_multiple_threads): Return 'bool' and rewrite using
5120         inferior_info::threads().
5121
5122 2019-03-06  Pedro Alves  <palves@redhat.com>
5123
5124         * linux-fork.c: Include <list>.
5125         (fork_list): Now a std::list instance.
5126         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5127         (forks_exist_p, find_last_fork): Adjust.
5128         (new_fork): Delete.
5129         (one_fork_p): New.
5130         (add_fork): Adjust.
5131         (free_fork): Delete, folded into fork_info::~fork_info().
5132         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5133         Adjust.
5134         (init_fork_list): Delete.
5135         (linux_fork_killall, linux_fork_mourn_inferior)
5136         (linux_fork_detach, info_checkpoints_command): Adjust.
5137         (_initialize_linux_fork): No longer call init_fork_list.
5138
5139 2019-03-06  Pedro Alves  <palves@redhat.com>
5140
5141         * linux-fork.c (new_fork): New, split out of ...
5142         (add_fork): ... this.  Return void.  Move "first fork" special
5143         case from here, to ...
5144         (checkpoint_command): ... here.
5145         * linux-linux.h (add_fork): Return void.
5146
5147 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5148
5149         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5150
5151 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5152             Chris January  <chris.january@arm.com>
5153             David Lecomber  <david.lecomber@arm.com>
5154
5155         * f-exp.y: New token, UNOP_INTRINSIC.
5156         (exp): New pattern using UNOP_INTRINSIC token.
5157         (f77_keywords): Add 'abs' keyword.
5158         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5159         (value_from_host_double): New function.
5160         (evaluate_subexp_f): Support UNOP_ABS.
5161
5162 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5163
5164         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5165         types.
5166
5167 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5168
5169         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5170         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5171         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5172
5173 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5174
5175         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5176
5177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5178             Chris January  <chris.january@arm.com>
5179
5180         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5181         * f-exp.y: Define 'KIND' token.
5182         (exp): New pattern for KIND expressions.
5183         (ptype): Handle types with a kind extension.
5184         (direct_abs_decl): Extend to spot kind extensions.
5185         (f77_keywords): Add 'kind' to the list.
5186         (push_kind_type): New function.
5187         (convert_to_kind_type): New function.
5188         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5189         * parse.c (operator_length_standard): Likewise.
5190         * parser-defs.h (enum type_pieces): Add tp_kind.
5191         * std-operator.def: Add UNOP_KIND.
5192
5193 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5194
5195         * f-exp.y (f_parse): Set yydebug.
5196
5197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5198
5199         * f-lang.c (evaluate_subexp_f): New function.
5200         (exp_descriptor_f): New global.
5201         (f_language_defn): Use exp_descriptor_f instead of
5202         exp_descriptor_standard.
5203
5204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5205
5206         * f-exp.y (struct token): Add comments.
5207         (dot_ops): Remove uppercase versions and the end marker.
5208         (f77_keywords): Likewise.
5209         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5210         entries in the dot_ops array are case insensitive, and use
5211         strncasecmp to compare strings.  Also some whitespace cleanup in
5212         this area.  Similar for the f77_keywords array, except entries in
5213         this list might be case sensitive.
5214
5215 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5216
5217         * f-exp.y (struct f77_boolean_val): Add comments.
5218         (boolean_values): Remove uppercase versions, and end marker.
5219         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5220         and use strncasecmp to achieve case insensitivity.  Additionally,
5221         perform whitespace cleanup around this code.
5222
5223 2019-03-06  Tom Tromey  <tromey@adacore.com>
5224
5225         * remote-sim.c (gdbsim_target_open): Use result of
5226         gdb_argv::release.
5227
5228 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5229         Dirk Schubert  <dirk.schubert@arm.com>
5230         Chris January  <chris.january@arm.com>
5231
5232         * eval.c (evaluate_subexp_standard): Call Fortran argument
5233         wrapping logic.
5234         * f-lang.c (struct value): A value which can be passed into a
5235         Fortran function call.
5236         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5237         where appropriate.
5238         (struct type): Value ready for a Fortran function call.
5239         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5240         is needed.
5241         * f-lang.h (fortran_argument_convert): Declaration.
5242         (fortran_preserve_arg_pointer): Declaration.
5243         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5244
5245 2019-03-05  Tom Tromey  <tromey@adacore.com>
5246
5247         * python/py-prettyprint.c (print_string_repr): Remove #if.
5248         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5249
5250 2019-03-05  Tom Tromey  <tromey@adacore.com>
5251
5252         * target.c (the_dummy_target): Move later.  Change type to
5253         "dummy_target".
5254         (initialize_targets): Don't initialize the_dummy_target.
5255
5256 2019-03-05  Tom Tromey  <tromey@adacore.com>
5257
5258         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5259         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5260
5261 2019-03-05  Tom Tromey  <tromey@adacore.com>
5262
5263         * windows-nat.c (windows_nat_target::attach)
5264         (windows_nat_target::detach): Don't call gdb_flush.
5265         * valprint.c (generic_val_print, val_print, val_print_string):
5266         Don't call gdb_flush.
5267         * utils.c (defaulted_query): Don't call gdb_flush.
5268         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5269         * target.c (target_announce_detach): Don't call gdb_flush.
5270         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5271         * remote.c (extended_remote_target::attach): Don't call
5272         gdb_flush.
5273         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5274         * printcmd.c (do_examine): Don't call gdb_flush.
5275         (info_display_command): Don't call gdb_flush.
5276         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5277         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5278         * memattr.c (info_mem_command): Don't call gdb_flush.
5279         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5280         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5281         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5282         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5283         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5284         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5285         (gnu_nat_target::detach): Don't call gdb_flush.
5286         * f-valprint.c (f_val_print): Don't call gdb_flush.
5287         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5288         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5289         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5290         gdb_flush.
5291         * c-valprint.c (c_val_print): Don't call gdb_flush.
5292         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5293
5294 2019-03-05  Tom Tromey  <tromey@adacore.com>
5295
5296         * varobj.c (update_dynamic_varobj_children): Update.
5297         (install_default_visualizer): Use reset, not release.
5298         * value.c (set_internalvar): Update.
5299         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5300         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5301         ATTRIBUTE_UNUSED_RESULT.
5302
5303 2019-03-05  Tom Tromey  <tromey@adacore.com>
5304
5305         * remote.c (class scoped_remote_fd) <release>: Add
5306         ATTRIBUTE_UNUSED_RESULT.
5307
5308 2019-03-05  Tom Tromey  <tromey@adacore.com>
5309
5310         * macroexp.c (struct macro_buffer) <release>: Add
5311         ATTRIBUTE_UNUSED_RESULT.
5312
5313 2019-03-05  Tom Tromey  <tromey@adacore.com>
5314
5315         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5316         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5317         ATTRIBUTE_UNUSED_RESULT.
5318
5319 2019-03-05  Tom Tromey  <tromey@adacore.com>
5320
5321         * common/scoped_fd.h (class scoped_fd) <release>: Add
5322         ATTRIBUTE_UNUSED_RESULT.
5323
5324 2019-03-05  Tom Tromey  <tromey@adacore.com>
5325
5326         * parser-defs.h (struct parser_state) <release>: Add
5327         ATTRIBUTE_UNUSED_RESULT.
5328
5329 2019-03-05  Tom Tromey  <tromey@adacore.com>
5330
5331         * utils.h (class gdb_argv) <release>: Add
5332         ATTRIBUTE_UNUSED_RESULT.
5333         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5334
5335 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5336
5337         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5338         for-loop range, to avoid compiler warnings.
5339
5340         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5341         avoid compiler warnings about unused variables.
5342
5343         * NEWS: Mention end of support for native debugging on MS-Windows
5344         before XP.
5345
5346         PR gdb/24292
5347         * common/netstuff.c:
5348         * gdbserver/gdbreplay.c
5349         * gdbserver/remote-utils.c:
5350         * ser-tcp.c:
5351         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5352         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5353         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5354         'getaddrinfo' and 'freeaddrinfo' were not available before
5355         Windows XP, and mingw.org's MinGW headers by default define
5356         _WIN32_WINNT to 0x500.
5357
5358 2019-03-01  Gary Benson <gbenson@redhat.com>
5359
5360         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5361
5362 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5363             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5364
5365         PR gdb/8527
5366         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5367         set_sigint_trap, clear_sigint_trap.
5368
5369 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5370
5371         * target.c (target_detach): Clear the regcache and the
5372         frame cache.
5373
5374 2019-02-27  Pedro Alves  <palves@redhat.com>
5375
5376         * utils.c (set_screen_size): When we cap the height/width sizes,
5377         tweak the corresponding command variable to show "unlimited":
5378
5379 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5380             Pedro Alves  <palves@redhat.com>
5381
5382         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5383         before calling rl_set_screen_size.
5384
5385 2019-02-27  Tom Tromey  <tromey@adacore.com>
5386
5387         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5388         define.
5389         * python/py-value.c: Remove Python 2.4 workaround.
5390         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5391         workaround.
5392         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5393         Python 2.4 workaround.
5394         * python/python-internal.h: Remove Python 2.4 comment.
5395         (Py_ssize_t): Don't define.
5396         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5397         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5398         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5399         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5400         * python/python.c (do_start_initialization): Remove Python 2.4
5401         workaround.
5402         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5403         (print_children): Remove Python 2.4 workaround.
5404         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5405         workaround.
5406         (CHARBUFFERPROC_NAME): Remove.
5407         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5408         Python 2.4 workaround.
5409
5410 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5411
5412         * NEWS: Note minimum Python version.
5413
5414 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5415
5416         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5417         code from these functions.  Remove corresponding ifdefs.  Use
5418         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5419         Remove gotos and target of gotos.
5420         (infpy_search_memory): Likewise.
5421
5422 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5423
5424         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5425         (hppa_gdbarch_init): Don't register deleted functions with
5426         gdbarch.
5427
5428 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5429
5430         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5431         (h8300_unwind_sp): Delete.
5432         (h8300_dummy_id): Delete.
5433         (h8300_gdbarch_init): Don't register deleted functions with
5434         gdbarch.
5435
5436 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5437
5438         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5439         (ft32_unwind_pc): Delete.
5440         (ft32_unwind_sp): Delete.
5441         (ft32_gdbarch_init): Don't register deleted functions with
5442         gdbarch.
5443
5444 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5447         (frv_unwind_pc): Delete.
5448         (frv_unwind_sp): Delete.
5449         (frv_gdbarch_init): Don't register deleted functions with
5450         gdbarch.
5451
5452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5453
5454         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5455         (riscv_unwind_pc): Delete.
5456         (riscv_unwind_sp): Delete.
5457         (riscv_gdbarch_init): Don't register deleted functions with
5458         gdbarch.
5459
5460 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5461
5462         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5463         (csky_unwind_pc): Delete.
5464         (csky_unwind_sp): Delete.
5465         (csky_gdbarch_init): Don't register deleted functions with
5466         gdbarch.
5467
5468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5469
5470         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5471         (cris_unwind_pc): Delete.
5472         (cris_unwind_sp): Delete.
5473         (cris_gdbarch_init): Don't register deleted functions with
5474         gdbarch.
5475
5476 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5477
5478         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5479         (bfin_unwind_pc): Delete.
5480         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5481
5482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5483
5484         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5485         (arm_unwind_pc): Delete.
5486         (arm_unwind_sp): Delete.
5487         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5488
5489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5492         (arc_unwind_pc): Delete.
5493         (arc_unwind_sp): Delete.
5494         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5495
5496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5497
5498         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5499         (alpha_unwind_pc): Delete.
5500         (alpha_gdbarch_init): Don't register deleted functions with
5501         gdbarch.
5502
5503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5504
5505         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5506         (aarch64_unwind_pc): Delete.
5507         (aarch64_unwind_sp): Delete.
5508         (aarch64_gdbarch_init): Don't register deleted functions with
5509         gdbarch.
5510
5511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5512
5513         * gdbtypes.c (type_align): Don't consider static members when
5514         computing structure alignment.
5515
5516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5517
5518         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5519         return 0 for other types.
5520         * arch-utils.c (default_type_align): Always return 0.
5521         * gdbarch.h: Regenerate.
5522         * gdbarch.sh (type_align): Extend comment.
5523         * gdbtypes.c (type_align): Add additional comments, always call
5524         gdbarch_type_align before applying the default rules.
5525         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5526         generic code will then apply a suitable default.
5527         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5528         types, return 0 for other types.
5529
5530 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5531
5532         * NEWS: Create a new section for the next release branch.
5533         Rename the section of the current branch, now that it has
5534         been cut.
5535
5536 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5537
5538         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5539         * version.in: Bump version to 8.3.50.DATE-git.
5540
5541 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5542
5543         * aix-thread.c (ptid_cmp): Remove unused variable.
5544         (get_signaled_thread): Likewise.
5545         (store_regs_user_thread): Likewise.
5546         (store_regs_kernel_thread): Likewise.
5547         (fetch_regs_kernel_thread): Remove shadowed variable.
5548
5549 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5550
5551         * features/riscv/32bit-cpu.xml: Add register numbers.
5552         * features/riscv/32bit-fpu.c: Regenerate.
5553         * features/riscv/32bit-fpu.xml: Add register numbers.
5554         * features/riscv/64bit-cpu.xml: Add register numbers.
5555         * features/riscv/64bit-fpu.c: Regenerate.
5556         * features/riscv/64bit-fpu.xml: Add register numbers.
5557
5558 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5559
5560         * NEWS: Mention two argument form of gdb.Value constructor.
5561         * python/py-value.c (convert_buffer_and_type_to_value): New
5562         function.
5563         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5564         Add support for handling an optional second argument.  Call
5565         convert_buffer_and_type_to_value as appropriate.
5566         * python/python-internal.h (Py_buffer_deleter): New struct.
5567         (Py_buffer_up): New typedef.
5568
5569 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5570
5571         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5572         instead of releasing ownership.
5573
5574 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5575
5576         * dwarf2read.c (open_and_init_dwp_file): Call
5577         elf_numsections instead of bfd_count_sections to initialize
5578         dwp_file->num_sections.
5579
5580 2019-02-25  Tom Tromey  <tromey@adacore.com>
5581
5582         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5583
5584 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5585
5586         * gcore.in: Add '--readnever' option when invoking GDB.
5587
5588 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5589
5590         * MAINTAINERS: Update my email address.
5591
5592 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5593
5594         * build-id.c (build_id_to_debug_bfd_1): New function.
5595         (build_id_to_debug_bfd): Look for separate debug file in
5596         sysroot.
5597
5598 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5599
5600         * gdbarch.sh: Update the copyright year range that is placed into
5601         generated files.
5602
5603 2019-02-22  Keith Seitz  <keiths@redhat.com>
5604
5605         PR symtab/23853
5606         * linespec.c (create_sals_line_offset): Search for the default
5607         symtab's filename instead of its fullname.
5608
5609 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5610
5611         * NEWS: Update style defaults.
5612
5613 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5614
5615         * main.c (captured_main_1): Disable styling in batch mode.
5616
5617 2019-02-20  Tom Tromey  <tom@tromey.com>
5618
5619         * symtab.c (symtab_symbol_info): Fix typos.
5620
5621 2019-02-20  Tom Tromey  <tromey@adacore.com>
5622
5623         * findcmd.c (_initialize_mem_search): Use upper case for
5624         metasyntactic variables.
5625
5626 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5627
5628         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5629         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5630
5631 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5632
5633         * top.h (source_file_name): Change to std::string.
5634         * top.c (source_file_name): Likewise.
5635         (command_line_input): Adjust.
5636         * cli/cli-script.c (script_from_file): Adjust.
5637
5638 2019-02-19  Tom Tromey  <tromey@adacore.com>
5639
5640         * ravenscar-thread.c
5641         (ravenscar_thread_target::update_thread_list): Don't call
5642         ada_build_task_list.
5643         * ada-lang.h (ada_build_task_list): Don't declare.
5644         * ada-tasks.c (struct ada_tasks_inferior_data)
5645         <task_list_valid_p>: Now bool.
5646         (read_known_tasks, ada_task_list_changed)
5647         (ada_tasks_invalidate_inferior_data): Update.
5648         (read_known_tasks_array): Return bool.
5649         (read_known_tasks_list): Likewise.
5650         (read_known_tasks): Return void.
5651         (ada_build_task_list): Now static.
5652
5653 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5654
5655         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5656         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5657
5658 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5659
5660         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5661         variant for ada_tasks_pspace_data_handle and
5662         ada_tasks_inferior_data_handle.
5663         (ada_tasks_pspace_data_cleanup): New function.
5664         (ada_tasks_inferior_data_cleanup): New function.
5665
5666 2019-02-17  Tom Tromey  <tom@tromey.com>
5667
5668         * macrotab.h (macro_source_fullname): Return a std::string.
5669         * macrotab.c (macro_include, check_for_redefinition)
5670         (macro_undef, macro_lookup_definition, foreach_macro)
5671         (foreach_macro_in_scope): Update.
5672         (macro_source_fullname): Return a std::string.
5673         * macrocmd.c (show_pp_source_pos): Update.
5674
5675 2019-02-17  Tom Tromey  <tom@tromey.com>
5676
5677         * macrocmd.c (show_pp_source_pos): Style the file names.
5678
5679 2019-02-17  Tom Tromey  <tom@tromey.com>
5680
5681         PR tui/24197:
5682         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5683
5684 2019-02-17  Tom Tromey  <tom@tromey.com>
5685
5686         * ada-lang.c (user_select_syms): Use filtered printing.
5687         * utils.c (wrap_style): New global.
5688         (desired_style): Remove.
5689         (emit_style_escape): Add stream parameter.
5690         (set_output_style, reset_terminal_style, prompt_for_continue):
5691         Update.
5692         (flush_wrap_buffer): Only flush gdb_stdout.
5693         (wrap_here): Set wrap_style.
5694         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5695         treat escape sequences as a character.  Change when wrap buffer is
5696         flushed.
5697         (fputs_styled): Do not set the output style when the default is
5698         requested.
5699         * ui-style.h (struct ui_file_style) <is_default>: New method.
5700         * source.c (print_source_lines_base): Emit escape sequences in one
5701         piece.
5702
5703 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5704
5705         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5706         integers and enumeration types.
5707
5708 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5709
5710         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5711         instead of lookup_symbol_in_language
5712         (do_exact_match): New function.
5713         (ada_get_symbol_name_matcher): Return do_exact_match when
5714         doing a verbatim match.
5715
5716 2019-02-15  Tom Tromey  <tromey@adacore.com>
5717
5718         * ravenscar-thread.c (ravenscar_thread_target::resume)
5719         (ravenscar_thread_target::wait): Special case wildcard requests.
5720
5721 2019-02-15  Tom Tromey  <tromey@adacore.com>
5722
5723         * ravenscar-thread.c (base_ptid): Remove.
5724         (struct ravenscar_thread_target) <close>: New method.
5725         <m_base_ptid>: New member.
5726         <update_inferior_ptid, active_task, task_is_currently_active,
5727         runtime_initialized>: Declare methods.
5728         <ravenscar_thread_target>: Add constructor.
5729         (ravenscar_thread_target::task_is_currently_active)
5730         (ravenscar_thread_target::update_inferior_ptid)
5731         (ravenscar_runtime_initialized): Rename.  Now methods.
5732         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5733         (ravenscar_thread_target::update_thread_list): Update.
5734         (ravenscar_thread_target::active_task): Now method.
5735         (ravenscar_thread_target::store_registers)
5736         (ravenscar_thread_target::prepare_to_store)
5737         (ravenscar_thread_target::prepare_to_store)
5738         (ravenscar_thread_target::mourn_inferior): Update.
5739         (ravenscar_inferior_created): Use "new" to create target.
5740         (ravenscar_thread_target::get_ada_task_ptid): Update.
5741         (_initialize_ravenscar): Don't initialize base_ptid.
5742         (ravenscar_ops): Remove global.
5743
5744 2019-02-15  Tom Tromey  <tromey@adacore.com>
5745
5746         * target.h (push_target): Declare new overload.
5747         * target.c (push_target): New overload, taking an rvalue reference.
5748         * remote.c (remote_target::open_1): Use push_target overload.
5749         * corelow.c (core_target_open): Use push_target overload.
5750
5751 2019-02-15  Tom Tromey  <tromey@adacore.com>
5752
5753         * ravenscar-thread.c (is_ravenscar_task)
5754         (ravenscar_task_is_currently_active): Return bool.
5755         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5756         (_initialize_ravenscar): Remove "(void)".
5757         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5758         Return bool.
5759
5760 2019-02-15  Tom Tromey  <tromey@adacore.com>
5761
5762         * ravenscar-thread.c (ravenscar_runtime_initializer)
5763         (has_ravenscar_runtime, get_running_thread_id)
5764         (ravenscar_thread_target::resume): Fix indentation.
5765
5766 2019-02-15  Tom Tromey  <tromey@adacore.com>
5767
5768         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5769         from ravenscar_arch_ops.
5770         (sparc_ravenscar_ops::fetch_registers)
5771         (sparc_ravenscar_ops::store_registers): Now methods.
5772         (sparc_ravenscar_prepare_to_store): Remove.
5773         (sparc_ravenscar_ops): Redefine.
5774         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5775         methods and destructor.  Remove members.
5776         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5777         (ravenscar_thread_target::store_registers)
5778         (ravenscar_thread_target::prepare_to_store): Update.
5779         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5780         Remove.
5781         (struct ppc_ravenscar_powerpc_ops): Derive from
5782         ravenscar_arch_ops.
5783         (ppc_ravenscar_powerpc_ops::fetch_registers)
5784         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5785         (ppc_ravenscar_powerpc_ops): Redefine.
5786         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5787         (ppc_ravenscar_e500_ops::fetch_registers)
5788         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5789         (ppc_ravenscar_e500_ops): Redefine.
5790         * aarch64-ravenscar-thread.c
5791         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5792         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5793         (aarch64_ravenscar_fetch_registers)
5794         (aarch64_ravenscar_store_registers): Now methods.
5795         (aarch64_ravenscar_ops): Redefine.
5796
5797 2019-02-15  Tom Tromey  <tromey@adacore.com>
5798
5799         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5800         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5801         (ravenscar_thread_target::stopped_by_watchpoint)
5802         (ravenscar_thread_target::stopped_data_address)
5803         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5804
5805 2019-02-15  Tom Tromey  <tromey@adacore.com>
5806
5807         * ravenscar-thread.c: Fix some typos.
5808
5809 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5810             Tom Tromey  <tromey@adacore.com>
5811
5812         * ada-lang.c (ada_exception_sal): Change addr_string to a
5813         std::string.
5814         (create_ada_exception_catchpoint): Update.
5815
5816 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5817             Tom Tromey  <tromey@adacore.com>
5818
5819         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5820         (bp_location_ops): Remove.
5821         (base_breakpoint_allocate_location): Update.
5822         (free_bp_location): Update.
5823         * ada-lang.c (class ada_catchpoint_location)
5824         <ada_catchpoint_location>: Remove ops parameter.
5825         (ada_catchpoint_location_dtor): Remove.
5826         (ada_catchpoint_location_ops): Remove.
5827         (allocate_location_exception): Update.
5828         * breakpoint.h (struct bp_location_ops): Remove.
5829         (class bp_location) <bp_location>: Remove bp_location_ops
5830         parameter.
5831         <~bp_location>: Add destructor.
5832         <ops>: Remove.
5833
5834 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5835             Pedro Alves  <palves@redhat.com>
5836
5837         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5838         'PATH_MAX'.
5839
5840 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5841             Samuel Thibault  <samuel.thibault@gnu.org>
5842             Thomas Schwinge  <thomas@codesourcery.com>
5843
5844         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5845         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5846
5847 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5848
5849         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5850         (check_empty): Use "const char *".
5851
5852         * gnu-nat.c (gnu_nat_target::detach): Instead of
5853         'detach_inferior (pid)' call
5854         'detach_inferior (find_inferior_pid (pid))'.
5855
5856         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5857         'nat/fork-inferior.o'.
5858         * gnu-nat.c: #include "nat/fork-inferior.h".
5859
5860         * gnu-nat.c (gnu_nat_target::detach): Instead of
5861         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5862         * gnu-nat.h: #include "inf-child.h".
5863         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5864         'i386_gnu_nat_target::fetch_registers'.
5865         (gnu_store_registers): Rename/move to
5866         'i386_gnu_nat_target::store_registers'.
5867
5868         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5869         * gnu-nat.h (mach_thread_info): New function.
5870         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5871
5872         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5873
5874 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5875
5876         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5877
5878 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5879
5880         * windows-nat.c (windows_add_thread): Add new parameter
5881         "main_thread_p" with default value set to false.  Update
5882         function documentation as well as all callers.
5883         (windows_delete_thread): Likewise.
5884         (fake_create_process): Update call to windows_add_thread.
5885         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5886         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5887         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5888         call to windows_delete_thread.
5889
5890 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5891
5892         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5893
5894 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5895
5896         * symfile.c (find_separate_debug_file): Use canonical path of
5897         sysroot with child_path instead of gdb_sysroot if it is valid.
5898
5899 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5900
5901         * symfile.c (find_separate_debug_file): Use child_path to
5902         determine if an object file is under a sysroot.
5903
5904 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5905
5906         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5907         unittests/child-path-selftests.c.
5908         * common/pathstuff.c (child_path): New function.
5909         * common/pathstuff.h (child_path): New prototype.
5910         * unittests/child-path-selftests.c: New file.
5911
5912 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5913
5914         * symfile.c (find_separate_debug_file): Look for separate debug
5915         files in debug directories under the sysroot.
5916
5917 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5918
5919         * symtab.h (struct minimal_symbol data_p): New const method.
5920         (struct minimal_symbol text_p): Likewise.
5921         * symtab.c (output_source_filename): Use file name style
5922         to print file name.
5923         (print_symbol_info): Likewise.
5924         (print_msymbol_info): Use address style to print addresses.
5925         Use function name style to print executable text symbols.
5926         (expand_symtab_containing_pc): Use data_p.
5927         (find_pc_sect_compunit_symtab): Likewise.
5928
5929 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5930
5931         * breakpoint.c (describe_other_breakpoints): Use address style
5932         to print addresses.
5933         (say_where): Likewise.
5934
5935 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5936
5937         * ada-typeprint.c (print_func_type): Print function name
5938         style to print function name.
5939         * c-typeprint.c (c_print_type_1): Likewise.
5940
5941 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5942
5943         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5944         for execve.
5945
5946 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5947
5948         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5949         type_stack.
5950
5951 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5952
5953         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5954         TYPE_CODE_REF types.
5955
5956 2019-02-08  Jim Wilson  <jimw@sifive.com>
5957
5958         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5959         (riscv_linux_fregset): New.
5960         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5961
5962 2019-02-07  Tom Tromey  <tom@tromey.com>
5963
5964         * thread.c (thread_cancel_execution_command): Update.
5965         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5966         methods.
5967         (struct thread_fsm_ops): Remove.
5968         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5969         (thread_fsm_should_stop, thread_fsm_return_value)
5970         (thread_fsm_set_finished, thread_fsm_finished_p)
5971         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5972         Don't declare.
5973         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5974         * infrun.c (clear_proceed_status_thread)
5975         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5976         (print_stop_event): Update.
5977         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5978         Add constructor.
5979         (step_command_fsm_ops): Remove.
5980         (new_step_command_fsm): Remove.
5981         (step_1): Update.
5982         (step_command_fsm::should_stop): Rename from
5983         step_command_fsm_should_stop.
5984         (step_command_fsm::clean_up): Rename from
5985         step_command_fsm_clean_up.
5986         (step_command_fsm::do_async_reply_reason): Rename from
5987         step_command_fsm_async_reply_reason.
5988         (struct until_next_fsm): Inherit from thread_fsm.  Add
5989         constructor.
5990         (until_next_fsm_ops): Remove.
5991         (new_until_next_fsm): Remove.
5992         (until_next_fsm::should_stop): Rename from
5993         until_next_fsm_should_stop.
5994         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5995         (until_next_fsm::do_async_reply_reason): Rename from
5996         until_next_fsm_async_reply_reason.
5997         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5998         constructor.  Change type of breakpoint.
5999         (finish_command_fsm_ops): Remove.
6000         (new_finish_command_fsm): Remove.
6001         (finish_command_fsm::should_stop): Rename from
6002         finish_command_fsm_should_stop.
6003         (finish_command_fsm::clean_up): Rename from
6004         finish_command_fsm_clean_up.
6005         (finish_command_fsm::return_value): Rename from
6006         finish_command_fsm_return_value.
6007         (finish_command_fsm::do_async_reply_reason): Rename from
6008         finish_command_fsm_async_reply_reason.
6009         (finish_command): Update.
6010         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6011         Add constructor.
6012         (call_thread_fsm_ops): Remove.
6013         (call_thread_fsm::call_thread_fsm): Rename from
6014         new_call_thread_fsm.
6015         (call_thread_fsm::should_stop): Rename from
6016         call_thread_fsm_should_stop.
6017         (call_thread_fsm::should_notify_stop): Rename from
6018         call_thread_fsm_should_notify_stop.
6019         (run_inferior_call, call_function_by_hand_dummy): Update.
6020         * cli/cli-interp.c (should_print_stop_to_console): Update.
6021         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6022         Add constructor.  Change type of location_breakpoint,
6023         caller_breakpoint.
6024         (until_break_fsm_ops): Remove.
6025         (new_until_break_fsm): Remove.
6026         (until_break_fsm::should_stop): Rename from
6027         until_break_fsm_should_stop.
6028         (until_break_fsm::clean_up): Rename from
6029         until_break_fsm_clean_up.
6030         (until_break_fsm::do_async_reply_reason): Rename from
6031         until_break_fsm_async_reply_reason.
6032         (until_break_command): Update.
6033         * thread-fsm.c: Remove.
6034         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6035
6036 2019-02-07  Tom Tromey  <tom@tromey.com>
6037
6038         * yy-remap.h: Add include guard.
6039         * xtensa-tdep.h: Add include guard.
6040         * xcoffread.h: Rename include guard.
6041         * varobj-iter.h: Add include guard.
6042         * tui/tui.h: Rename include guard.
6043         * tui/tui-winsource.h: Rename include guard.
6044         * tui/tui-wingeneral.h: Rename include guard.
6045         * tui/tui-windata.h: Rename include guard.
6046         * tui/tui-win.h: Rename include guard.
6047         * tui/tui-stack.h: Rename include guard.
6048         * tui/tui-source.h: Rename include guard.
6049         * tui/tui-regs.h: Rename include guard.
6050         * tui/tui-out.h: Rename include guard.
6051         * tui/tui-layout.h: Rename include guard.
6052         * tui/tui-io.h: Rename include guard.
6053         * tui/tui-hooks.h: Rename include guard.
6054         * tui/tui-file.h: Rename include guard.
6055         * tui/tui-disasm.h: Rename include guard.
6056         * tui/tui-data.h: Rename include guard.
6057         * tui/tui-command.h: Rename include guard.
6058         * tic6x-tdep.h: Add include guard.
6059         * target/waitstatus.h: Rename include guard.
6060         * target/wait.h: Rename include guard.
6061         * target/target.h: Rename include guard.
6062         * target/resume.h: Rename include guard.
6063         * target-float.h: Rename include guard.
6064         * stabsread.h: Add include guard.
6065         * rs6000-tdep.h: Add include guard.
6066         * riscv-fbsd-tdep.h: Add include guard.
6067         * regformats/regdef.h: Rename include guard.
6068         * record.h: Rename include guard.
6069         * python/python.h: Rename include guard.
6070         * python/python-internal.h: Rename include guard.
6071         * python/py-stopevent.h: Rename include guard.
6072         * python/py-ref.h: Rename include guard.
6073         * python/py-record.h: Rename include guard.
6074         * python/py-record-full.h: Rename include guard.
6075         * python/py-record-btrace.h: Rename include guard.
6076         * python/py-instruction.h: Rename include guard.
6077         * python/py-events.h: Rename include guard.
6078         * python/py-event.h: Rename include guard.
6079         * procfs.h: Add include guard.
6080         * proc-utils.h: Add include guard.
6081         * p-lang.h: Add include guard.
6082         * or1k-tdep.h: Rename include guard.
6083         * observable.h: Rename include guard.
6084         * nto-tdep.h: Rename include guard.
6085         * nat/x86-linux.h: Rename include guard.
6086         * nat/x86-linux-dregs.h: Rename include guard.
6087         * nat/x86-gcc-cpuid.h: Add include guard.
6088         * nat/x86-dregs.h: Rename include guard.
6089         * nat/x86-cpuid.h: Rename include guard.
6090         * nat/ppc-linux.h: Rename include guard.
6091         * nat/mips-linux-watch.h: Rename include guard.
6092         * nat/linux-waitpid.h: Rename include guard.
6093         * nat/linux-ptrace.h: Rename include guard.
6094         * nat/linux-procfs.h: Rename include guard.
6095         * nat/linux-osdata.h: Rename include guard.
6096         * nat/linux-nat.h: Rename include guard.
6097         * nat/linux-namespaces.h: Rename include guard.
6098         * nat/linux-btrace.h: Rename include guard.
6099         * nat/glibc_thread_db.h: Rename include guard.
6100         * nat/gdb_thread_db.h: Rename include guard.
6101         * nat/gdb_ptrace.h: Rename include guard.
6102         * nat/fork-inferior.h: Rename include guard.
6103         * nat/amd64-linux-siginfo.h: Rename include guard.
6104         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6105         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6106         * nat/aarch64-linux.h: Rename include guard.
6107         * nat/aarch64-linux-hw-point.h: Rename include guard.
6108         * mn10300-tdep.h: Add include guard.
6109         * mips-linux-tdep.h: Add include guard.
6110         * mi/mi-parse.h: Rename include guard.
6111         * mi/mi-out.h: Rename include guard.
6112         * mi/mi-main.h: Rename include guard.
6113         * mi/mi-interp.h: Rename include guard.
6114         * mi/mi-getopt.h: Rename include guard.
6115         * mi/mi-console.h: Rename include guard.
6116         * mi/mi-common.h: Rename include guard.
6117         * mi/mi-cmds.h: Rename include guard.
6118         * mi/mi-cmd-break.h: Rename include guard.
6119         * m2-lang.h: Add include guard.
6120         * location.h: Rename include guard.
6121         * linux-record.h: Rename include guard.
6122         * linux-nat.h: Add include guard.
6123         * linux-fork.h: Add include guard.
6124         * i386-darwin-tdep.h: Rename include guard.
6125         * hppa-linux-offsets.h: Add include guard.
6126         * guile/guile.h: Rename include guard.
6127         * guile/guile-internal.h: Rename include guard.
6128         * gnu-nat.h: Rename include guard.
6129         * gdb-stabs.h: Rename include guard.
6130         * frv-tdep.h: Add include guard.
6131         * f-lang.h: Add include guard.
6132         * event-loop.h: Add include guard.
6133         * darwin-nat.h: Rename include guard.
6134         * cp-abi.h: Rename include guard.
6135         * config/sparc/nm-sol2.h: Rename include guard.
6136         * config/nm-nto.h: Rename include guard.
6137         * config/nm-linux.h: Add include guard.
6138         * config/i386/nm-i386gnu.h: Rename include guard.
6139         * config/djgpp/nl_types.h: Rename include guard.
6140         * config/djgpp/langinfo.h: Rename include guard.
6141         * compile/gcc-cp-plugin.h: Add include guard.
6142         * compile/gcc-c-plugin.h: Add include guard.
6143         * compile/compile.h: Rename include guard.
6144         * compile/compile-object-run.h: Rename include guard.
6145         * compile/compile-object-load.h: Rename include guard.
6146         * compile/compile-internal.h: Rename include guard.
6147         * compile/compile-cplus.h: Rename include guard.
6148         * compile/compile-c.h: Rename include guard.
6149         * common/xml-utils.h: Rename include guard.
6150         * common/x86-xstate.h: Rename include guard.
6151         * common/version.h: Rename include guard.
6152         * common/vec.h: Rename include guard.
6153         * common/tdesc.h: Rename include guard.
6154         * common/selftest.h: Rename include guard.
6155         * common/scoped_restore.h: Rename include guard.
6156         * common/scoped_mmap.h: Rename include guard.
6157         * common/scoped_fd.h: Rename include guard.
6158         * common/safe-iterator.h: Rename include guard.
6159         * common/run-time-clock.h: Rename include guard.
6160         * common/refcounted-object.h: Rename include guard.
6161         * common/queue.h: Rename include guard.
6162         * common/ptid.h: Rename include guard.
6163         * common/print-utils.h: Rename include guard.
6164         * common/preprocessor.h: Rename include guard.
6165         * common/pathstuff.h: Rename include guard.
6166         * common/observable.h: Rename include guard.
6167         * common/netstuff.h: Rename include guard.
6168         * common/job-control.h: Rename include guard.
6169         * common/host-defs.h: Rename include guard.
6170         * common/gdb_wait.h: Rename include guard.
6171         * common/gdb_vecs.h: Rename include guard.
6172         * common/gdb_unlinker.h: Rename include guard.
6173         * common/gdb_unique_ptr.h: Rename include guard.
6174         * common/gdb_tilde_expand.h: Rename include guard.
6175         * common/gdb_sys_time.h: Rename include guard.
6176         * common/gdb_string_view.h: Rename include guard.
6177         * common/gdb_splay_tree.h: Rename include guard.
6178         * common/gdb_setjmp.h: Rename include guard.
6179         * common/gdb_ref_ptr.h: Rename include guard.
6180         * common/gdb_optional.h: Rename include guard.
6181         * common/gdb_locale.h: Rename include guard.
6182         * common/gdb_assert.h: Rename include guard.
6183         * common/filtered-iterator.h: Rename include guard.
6184         * common/filestuff.h: Rename include guard.
6185         * common/fileio.h: Rename include guard.
6186         * common/environ.h: Rename include guard.
6187         * common/common-utils.h: Rename include guard.
6188         * common/common-types.h: Rename include guard.
6189         * common/common-regcache.h: Rename include guard.
6190         * common/common-inferior.h: Rename include guard.
6191         * common/common-gdbthread.h: Rename include guard.
6192         * common/common-exceptions.h: Rename include guard.
6193         * common/common-defs.h: Rename include guard.
6194         * common/common-debug.h: Rename include guard.
6195         * common/cleanups.h: Rename include guard.
6196         * common/buffer.h: Rename include guard.
6197         * common/btrace-common.h: Rename include guard.
6198         * common/break-common.h: Rename include guard.
6199         * cli/cli-utils.h: Rename include guard.
6200         * cli/cli-style.h: Rename include guard.
6201         * cli/cli-setshow.h: Rename include guard.
6202         * cli/cli-script.h: Rename include guard.
6203         * cli/cli-interp.h: Rename include guard.
6204         * cli/cli-decode.h: Rename include guard.
6205         * cli/cli-cmds.h: Rename include guard.
6206         * charset-list.h: Add include guard.
6207         * buildsym-legacy.h: Rename include guard.
6208         * bfin-tdep.h: Add include guard.
6209         * ax.h: Rename include guard.
6210         * arm-linux-tdep.h: Add include guard.
6211         * arm-fbsd-tdep.h: Add include guard.
6212         * arch/xtensa.h: Rename include guard.
6213         * arch/tic6x.h: Add include guard.
6214         * arch/i386.h: Add include guard.
6215         * arch/arm.h: Rename include guard.
6216         * arch/arm-linux.h: Rename include guard.
6217         * arch/arm-get-next-pcs.h: Rename include guard.
6218         * arch/amd64.h: Add include guard.
6219         * arch/aarch64-insn.h: Rename include guard.
6220         * arch-utils.h: Rename include guard.
6221         * annotate.h: Add include guard.
6222         * amd64-darwin-tdep.h: Rename include guard.
6223         * aarch64-linux-tdep.h: Add include guard.
6224         * aarch64-fbsd-tdep.h: Add include guard.
6225         * aarch32-linux-nat.h: Add include guard.
6226
6227 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6228
6229         * macrotab.c (macro_define_internal): New function that
6230         factorizes macro_define_object_internal and macro_define_function
6231         code.
6232         (macro_define_object_internal): Use macro_define_internal.
6233         (macro_define_function): Likewise.
6234
6235 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6236
6237         * macrocmd.c (extract_identifier): Return
6238         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6239         callers.
6240
6241 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6242
6243         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6244
6245 2019-02-05  Tom Tromey  <tom@tromey.com>
6246
6247         * target.c (target_stack::unpush): Move assertion earlier.
6248
6249 2019-01-30  Tom Tromey  <tom@tromey.com>
6250
6251         PR python/23615:
6252         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6253         (gdbpy_parse_and_eval): Likewise.
6254         * python/python-internal.h (gdbpy_allow_threads): New class.
6255
6256 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6257
6258         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6259         (aarch64_fbsd_fpregmap): Move earlier.
6260         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6261         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6262         instead of individual calls to trad_frame_set_reg_addr.
6263         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6264         earlier.
6265         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6266         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6267         instead of individual calls to trad_frame_set_reg_addr.
6268
6269 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6270
6271         * CONTRIBUTE: Replace contribution list with wiki link.
6272
6273 2019-01-25  Tom Tromey  <tom@tromey.com>
6274
6275         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6276
6277 2019-01-25  Tom Tromey  <tom@tromey.com>
6278
6279         * xtensa-linux-nat.c: Fix common/ includes.
6280         * xml-support.h: Fix common/ includes.
6281         * xml-support.c: Fix common/ includes.
6282         * x86-linux-nat.c: Fix common/ includes.
6283         * windows-nat.c: Fix common/ includes.
6284         * varobj.h: Fix common/ includes.
6285         * varobj.c: Fix common/ includes.
6286         * value.c: Fix common/ includes.
6287         * valops.c: Fix common/ includes.
6288         * utils.c: Fix common/ includes.
6289         * unittests/xml-utils-selftests.c: Fix common/ includes.
6290         * unittests/utils-selftests.c: Fix common/ includes.
6291         * unittests/unpack-selftests.c: Fix common/ includes.
6292         * unittests/tracepoint-selftests.c: Fix common/ includes.
6293         * unittests/style-selftests.c: Fix common/ includes.
6294         * unittests/string_view-selftests.c: Fix common/ includes.
6295         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6296         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6297         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6298         * unittests/rsp-low-selftests.c: Fix common/ includes.
6299         * unittests/parse-connection-spec-selftests.c: Fix common/
6300         includes.
6301         * unittests/optional-selftests.c: Fix common/ includes.
6302         * unittests/offset-type-selftests.c: Fix common/ includes.
6303         * unittests/observable-selftests.c: Fix common/ includes.
6304         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6305         * unittests/memrange-selftests.c: Fix common/ includes.
6306         * unittests/memory-map-selftests.c: Fix common/ includes.
6307         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6308         * unittests/function-view-selftests.c: Fix common/ includes.
6309         * unittests/environ-selftests.c: Fix common/ includes.
6310         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6311         * unittests/common-utils-selftests.c: Fix common/ includes.
6312         * unittests/cli-utils-selftests.c: Fix common/ includes.
6313         * unittests/array-view-selftests.c: Fix common/ includes.
6314         * ui-file.c: Fix common/ includes.
6315         * tui/tui-io.c: Fix common/ includes.
6316         * tracepoint.h: Fix common/ includes.
6317         * tracepoint.c: Fix common/ includes.
6318         * tracefile-tfile.c: Fix common/ includes.
6319         * top.h: Fix common/ includes.
6320         * top.c: Fix common/ includes.
6321         * thread.c: Fix common/ includes.
6322         * target/waitstatus.h: Fix common/ includes.
6323         * target/waitstatus.c: Fix common/ includes.
6324         * target.h: Fix common/ includes.
6325         * target.c: Fix common/ includes.
6326         * target-memory.c: Fix common/ includes.
6327         * target-descriptions.c: Fix common/ includes.
6328         * symtab.h: Fix common/ includes.
6329         * symfile.c: Fix common/ includes.
6330         * stap-probe.c: Fix common/ includes.
6331         * spu-linux-nat.c: Fix common/ includes.
6332         * sparc-nat.c: Fix common/ includes.
6333         * source.c: Fix common/ includes.
6334         * solib.c: Fix common/ includes.
6335         * solib-target.c: Fix common/ includes.
6336         * ser-unix.c: Fix common/ includes.
6337         * ser-tcp.c: Fix common/ includes.
6338         * ser-pipe.c: Fix common/ includes.
6339         * ser-base.c: Fix common/ includes.
6340         * selftest-arch.c: Fix common/ includes.
6341         * s12z-tdep.c: Fix common/ includes.
6342         * rust-exp.y: Fix common/ includes.
6343         * rs6000-aix-tdep.c: Fix common/ includes.
6344         * riscv-tdep.c: Fix common/ includes.
6345         * remote.c: Fix common/ includes.
6346         * remote-notif.h: Fix common/ includes.
6347         * remote-fileio.h: Fix common/ includes.
6348         * remote-fileio.c: Fix common/ includes.
6349         * regcache.h: Fix common/ includes.
6350         * regcache.c: Fix common/ includes.
6351         * record-btrace.c: Fix common/ includes.
6352         * python/python.c: Fix common/ includes.
6353         * python/py-type.c: Fix common/ includes.
6354         * python/py-inferior.c: Fix common/ includes.
6355         * progspace.h: Fix common/ includes.
6356         * producer.c: Fix common/ includes.
6357         * procfs.c: Fix common/ includes.
6358         * proc-api.c: Fix common/ includes.
6359         * printcmd.c: Fix common/ includes.
6360         * ppc-linux-nat.c: Fix common/ includes.
6361         * parser-defs.h: Fix common/ includes.
6362         * osdata.c: Fix common/ includes.
6363         * obsd-nat.c: Fix common/ includes.
6364         * nat/x86-linux.c: Fix common/ includes.
6365         * nat/x86-linux-dregs.c: Fix common/ includes.
6366         * nat/x86-dregs.h: Fix common/ includes.
6367         * nat/x86-dregs.c: Fix common/ includes.
6368         * nat/ppc-linux.c: Fix common/ includes.
6369         * nat/mips-linux-watch.h: Fix common/ includes.
6370         * nat/mips-linux-watch.c: Fix common/ includes.
6371         * nat/linux-waitpid.c: Fix common/ includes.
6372         * nat/linux-ptrace.h: Fix common/ includes.
6373         * nat/linux-ptrace.c: Fix common/ includes.
6374         * nat/linux-procfs.c: Fix common/ includes.
6375         * nat/linux-personality.c: Fix common/ includes.
6376         * nat/linux-osdata.c: Fix common/ includes.
6377         * nat/linux-namespaces.c: Fix common/ includes.
6378         * nat/linux-btrace.h: Fix common/ includes.
6379         * nat/linux-btrace.c: Fix common/ includes.
6380         * nat/fork-inferior.c: Fix common/ includes.
6381         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6382         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6383         * nat/aarch64-linux.c: Fix common/ includes.
6384         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6385         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6386         * namespace.h: Fix common/ includes.
6387         * mips-linux-tdep.c: Fix common/ includes.
6388         * minsyms.c: Fix common/ includes.
6389         * mi/mi-parse.h: Fix common/ includes.
6390         * mi/mi-main.c: Fix common/ includes.
6391         * mi/mi-cmd-env.c: Fix common/ includes.
6392         * memrange.h: Fix common/ includes.
6393         * memattr.c: Fix common/ includes.
6394         * maint.h: Fix common/ includes.
6395         * maint.c: Fix common/ includes.
6396         * main.c: Fix common/ includes.
6397         * machoread.c: Fix common/ includes.
6398         * location.c: Fix common/ includes.
6399         * linux-thread-db.c: Fix common/ includes.
6400         * linux-nat.c: Fix common/ includes.
6401         * linux-fork.c: Fix common/ includes.
6402         * inline-frame.c: Fix common/ includes.
6403         * infrun.c: Fix common/ includes.
6404         * inflow.c: Fix common/ includes.
6405         * inferior.h: Fix common/ includes.
6406         * inferior.c: Fix common/ includes.
6407         * infcmd.c: Fix common/ includes.
6408         * inf-ptrace.c: Fix common/ includes.
6409         * inf-child.c: Fix common/ includes.
6410         * ia64-linux-nat.c: Fix common/ includes.
6411         * i387-tdep.c: Fix common/ includes.
6412         * i386-tdep.c: Fix common/ includes.
6413         * i386-linux-tdep.c: Fix common/ includes.
6414         * i386-linux-nat.c: Fix common/ includes.
6415         * i386-go32-tdep.c: Fix common/ includes.
6416         * i386-fbsd-tdep.c: Fix common/ includes.
6417         * i386-fbsd-nat.c: Fix common/ includes.
6418         * guile/scm-type.c: Fix common/ includes.
6419         * guile/guile.c: Fix common/ includes.
6420         * go32-nat.c: Fix common/ includes.
6421         * gnu-nat.c: Fix common/ includes.
6422         * gdbthread.h: Fix common/ includes.
6423         * gdbarch-selftests.c: Fix common/ includes.
6424         * gdb_usleep.c: Fix common/ includes.
6425         * gdb_select.h: Fix common/ includes.
6426         * gdb_bfd.c: Fix common/ includes.
6427         * gcore.c: Fix common/ includes.
6428         * fork-child.c: Fix common/ includes.
6429         * findvar.c: Fix common/ includes.
6430         * fbsd-nat.c: Fix common/ includes.
6431         * event-top.c: Fix common/ includes.
6432         * event-loop.c: Fix common/ includes.
6433         * dwarf2read.c: Fix common/ includes.
6434         * dwarf2loc.c: Fix common/ includes.
6435         * dwarf2-frame.c: Fix common/ includes.
6436         * dwarf-index-cache.c: Fix common/ includes.
6437         * dtrace-probe.c: Fix common/ includes.
6438         * disasm-selftests.c: Fix common/ includes.
6439         * defs.h: Fix common/ includes.
6440         * csky-tdep.c: Fix common/ includes.
6441         * cp-valprint.c: Fix common/ includes.
6442         * cp-support.h: Fix common/ includes.
6443         * cp-support.c: Fix common/ includes.
6444         * corelow.c: Fix common/ includes.
6445         * completer.h: Fix common/ includes.
6446         * completer.c: Fix common/ includes.
6447         * compile/compile.c: Fix common/ includes.
6448         * compile/compile-loc2c.c: Fix common/ includes.
6449         * compile/compile-cplus-types.c: Fix common/ includes.
6450         * compile/compile-cplus-symbols.c: Fix common/ includes.
6451         * command.h: Fix common/ includes.
6452         * cli/cli-dump.c: Fix common/ includes.
6453         * cli/cli-cmds.c: Fix common/ includes.
6454         * charset.c: Fix common/ includes.
6455         * build-id.c: Fix common/ includes.
6456         * btrace.h: Fix common/ includes.
6457         * btrace.c: Fix common/ includes.
6458         * breakpoint.h: Fix common/ includes.
6459         * breakpoint.c: Fix common/ includes.
6460         * ax.h:
6461         (enum agent_op): Fix common/ includes.
6462         * ax-general.c (struct aop_map): Fix common/ includes.
6463         * ax-gdb.c: Fix common/ includes.
6464         * auxv.c: Fix common/ includes.
6465         * auto-load.c: Fix common/ includes.
6466         * arm-tdep.c: Fix common/ includes.
6467         * arch/riscv.c: Fix common/ includes.
6468         * arch/ppc-linux-common.c: Fix common/ includes.
6469         * arch/i386.c: Fix common/ includes.
6470         * arch/arm.c: Fix common/ includes.
6471         * arch/arm-linux.c: Fix common/ includes.
6472         * arch/arm-get-next-pcs.c: Fix common/ includes.
6473         * arch/amd64.c: Fix common/ includes.
6474         * arch/aarch64.c: Fix common/ includes.
6475         * arch/aarch64-insn.c: Fix common/ includes.
6476         * arch-utils.c: Fix common/ includes.
6477         * amd64-windows-tdep.c: Fix common/ includes.
6478         * amd64-tdep.c: Fix common/ includes.
6479         * amd64-sol2-tdep.c: Fix common/ includes.
6480         * amd64-obsd-tdep.c: Fix common/ includes.
6481         * amd64-nbsd-tdep.c: Fix common/ includes.
6482         * amd64-linux-tdep.c: Fix common/ includes.
6483         * amd64-linux-nat.c: Fix common/ includes.
6484         * amd64-fbsd-tdep.c: Fix common/ includes.
6485         * amd64-fbsd-nat.c: Fix common/ includes.
6486         * amd64-dicos-tdep.c: Fix common/ includes.
6487         * amd64-darwin-tdep.c: Fix common/ includes.
6488         * agent.c: Fix common/ includes.
6489         * ada-lang.h: Fix common/ includes.
6490         * ada-lang.c: Fix common/ includes.
6491         * aarch64-tdep.c: Fix common/ includes.
6492
6493 2019-01-25  Tom Tromey  <tom@tromey.com>
6494
6495         * common/create-version.sh: Use common/version.h.
6496
6497 2019-01-24  Pedro Alves  <palves@redhat.com>
6498
6499         * infrun.c (signal_stop, signal_print, signal_program)
6500         (signal_catch, signal_pass): Now arrays instead of pointers.
6501         (update_signals_program_target, do_target_resume)
6502         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6503         * linux-nat.c (linux_nat_target::pass_signals)
6504         (linux_nat_target::create_inferior, linux_nat_target::attach):
6505         Adjust.
6506         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6507         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6508         * procfs.c (procfs_target::pass_signals): Adjust.
6509         * record-full.c (record_full_target::resume): Adjust.
6510         * remote.c (remote_target::pass_signals)
6511         (remote_target::program_signals): Adjust.
6512         * target-debug.h (target_debug_print_signals): Now takes a
6513         gdb::array_view as parameter.  Adjust.
6514         * target.h (target_ops) <pass_signals, program_signals>: Replace
6515         pointer and length parameters with gdb::array_view.
6516         (target_pass_signals, target_program_signals): Likewise.
6517         * target-delegates.c: Regenerate.
6518
6519 2019-01-24  Pedro Alves  <palves@redhat.com>
6520
6521         * common/forward-scope-exit.h
6522         (forward_scope_exit::forward_scope_exit): Pass arguments to
6523         m_bind_function directly, instead of creating a std::bind and
6524         copying that.
6525
6526 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6527
6528         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6529         for static members.
6530         (pass_in_v_vfp_candidate): Likewise.
6531
6532 2019-01-23  Tom Tromey  <tom@tromey.com>
6533             Pedro Alves  <palves@redhat.com>
6534
6535         * regcache.c (class regcache_invalidator): Remove.
6536         (regcache::raw_write): Use make_scope_exit.
6537
6538 2019-01-23  Tom Tromey  <tom@tromey.com>
6539
6540         * ui-out.h (class ui_out_emit_type): Update comment.
6541
6542 2019-01-23  Tom Tromey  <tom@tromey.com>
6543
6544         * infrun.c (fetch_inferior_event): Update comment.
6545
6546 2019-01-23  Tom Tromey  <tom@tromey.com>
6547             Pedro Alves  <palves@redhat.com>
6548
6549         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6550         parameter.
6551         (fetch_inferior_event): Use SCOPE_EXIT.
6552
6553
6554 2019-01-23  Tom Tromey  <tom@tromey.com>
6555             Pedro Alves  <palves@redhat.com>
6556
6557         * infrun.c (disable_thread_events): Delete.
6558         (stop_all_threads): Use SCOPE_EXIT.
6559
6560 2019-01-23  Tom Tromey  <tom@tromey.com>
6561             Pedro Alves  <palves@redhat.com>
6562
6563         * symfile.c: Include forward-scope-exit.h.
6564         (clear_symtab_users_cleanup): Replace forward declaration with
6565         a FORWARD_SCOPE_EXIT.
6566         (syms_from_objfile_1): Use the forward_scope_exit and
6567         gdb::optional instead of cleanup_function.
6568         (reread_symbols): Use the forward_scope_exit instead of
6569         cleanup_function.
6570         (clear_symtab_users_cleanup): Remove function.
6571
6572 2019-01-23  Tom Tromey  <tom@tromey.com>
6573             Pedro Alves  <palves@redhat.com>
6574
6575         * linux-nat.c: Include scope-exit.h.
6576         (cleanup_target_stop): Remove.
6577         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6578         SCOPE_EXIT.
6579
6580 2019-01-23  Tom Tromey  <tom@tromey.com>
6581             Pedro Alves  <palves@redhat.com>
6582
6583         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6584         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6585
6586 2019-01-23  Tom Tromey  <tom@tromey.com>
6587             Andrew Burgess  <andrew.burgess@embecosm.com>
6588             Pedro Alves  <palves@redhat.com>
6589
6590         * infrun.c (fetch_inferior_event): Use scope_exit.
6591         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6592         * top.c (execute_command): Use scope_exit.
6593         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6594         * utils.c (do_bpstat_clear_actions_cleanup)
6595         (make_bpstat_clear_actions_cleanup): Remove.
6596
6597 2019-01-23  Tom Tromey  <tom@tromey.com>
6598             Pedro Alves  <palves@redhat.com>
6599
6600         * infrun.c: Include "common/scope-exit.h"
6601         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6602         (wait_for_inferior): Use SCOPE_EXIT.
6603         (fetch_inferior_event): Use scope_exit.
6604
6605 2019-01-23  Tom Tromey  <tom@tromey.com>
6606             Pedro Alves  <palves@redhat.com>
6607
6608         * breakpoint.c (create_breakpoint): Remove cleanup.
6609
6610 2019-01-23  Tom Tromey  <tom@tromey.com>
6611             Andrew Burgess  <andrew.burgess@embecosm.com>
6612             Pedro Alves  <palves@redhat.com>
6613
6614 2019-01-23  Pedro Alves  <palves@redhat.com>
6615
6616         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6617
6618 2019-01-23  Pedro Alves  <palves@redhat.com>
6619             Andrew Burgess  <andrew.burgess@embecosm.com>
6620
6621         * gdbthread.h: Include "common/forward-scope-exit.h".
6622         (scoped_finish_thread_state): Redefine custom class in terms of
6623         forward_scope_exit.
6624
6625 2019-01-23  Pedro Alves  <palves@redhat.com>
6626             Andrew Burgess  <andrew.burgess@embecosm.com>
6627
6628         * common/forward-scope-exit.h: New file.
6629
6630 2019-01-23  Pedro Alves  <palves@redhat.com>
6631             Andrew Burgess  <andrew.burgess@embecosm.com>
6632             Tom Tromey  <tom@tromey.com>
6633
6634         * common/scope-exit.h: New file.
6635
6636 2019-01-23  Pedro Alves  <palves@redhat.com>
6637
6638         * common/preprocessor.h (ESC): Rename to ...
6639         (ESC_PARENS): ... this.
6640         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6641         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6642
6643 2019-01-23  Tom Tromey  <tom@tromey.com>
6644
6645         * language.h (class scoped_switch_to_sym_language_if_auto):
6646         Initialize m_lang in both cases.
6647
6648 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6649
6650         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6651         with XCNEW.
6652
6653 2019-01-22  Tom Tromey  <tom@tromey.com>
6654
6655         * corelow.c: Do not include sys/file.h.
6656
6657 2019-01-22  Tom Tromey  <tom@tromey.com>
6658
6659         * tui/tui-wingeneral.h: Include gdb_curses.h.
6660
6661 2019-01-22  Tom Tromey  <tom@tromey.com>
6662
6663         * source-cache.h (class source_cache) <get_source_lines,
6664         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6665
6666 2019-01-22  Tom Tromey  <tom@tromey.com>
6667
6668         * remote-fileio.h (struct remote_target): Declare.
6669
6670 2019-01-22  Tom Tromey  <tom@tromey.com>
6671
6672         * python/py-arch.c: Do not include py-ref.h.
6673         * python/py-bpevent.c: Do not include py-ref.h.
6674         * python/py-cmd.c: Do not include py-ref.h.
6675         * python/py-continueevent.c: Do not include py-ref.h.
6676         * python/py-event.h: Do not include py-ref.h.
6677         * python/py-evtregistry.c: Do not include py-ref.h.
6678         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6679         * python/py-frame.c: Do not include py-ref.h.
6680         * python/py-framefilter.c: Do not include py-ref.h.
6681         * python/py-function.c: Do not include py-ref.h.
6682         * python/py-infevents.c: Do not include py-ref.h.
6683         * python/py-linetable.c: Do not include py-ref.h.
6684         * python/py-objfile.c: Do not include py-ref.h.
6685         * python/py-param.c: Do not include py-ref.h.
6686         * python/py-prettyprint.c: Do not include py-ref.h.
6687         * python/py-progspace.c: Do not include py-ref.h.
6688         * python/py-symbol.c: Do not include py-ref.h.
6689         * python/py-symtab.c: Do not include py-ref.h.
6690         * python/py-type.c: Do not include py-ref.h.
6691         * python/py-unwind.c: Do not include py-ref.h.
6692         * python/py-utils.c: Do not include py-ref.h.
6693         * python/py-value.c: Do not include py-ref.h.
6694         * python/py-varobj.c: Do not include py-ref.h.
6695         * python/py-xmethods.c: Do not include py-ref.h.
6696         * python/python.c: Do not include py-ref.h.
6697         * varobj.c: Do not include py-ref.h.
6698
6699 2019-01-22  Tom Tromey  <tom@tromey.com>
6700
6701         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6702         keyword for bcache.
6703
6704 2019-01-22  Tom Tromey  <tom@tromey.com>
6705
6706         * compile/compile-cplus-types.c: Remove a comment by #include.
6707
6708 2019-01-22  Tom Tromey  <tom@tromey.com>
6709
6710         * compile/gcc-c-plugin.h: Include compile-internal.h.
6711
6712 2019-01-22  Tom Tromey  <tom@tromey.com>
6713
6714         * stabsread.c (EXTERN): Do not define.
6715         (symnum, next_symbol_text_func, processing_gcc_compilation)
6716         (within_function, global_sym_chain, global_stabs)
6717         (previous_stab_code, this_object_header_files)
6718         (n_this_object_header_files)
6719         (n_allocated_this_object_header_files): Define.
6720         * stabsread.h (EXTERN): Never define.  Use "extern".
6721
6722 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6723
6724         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6725         history_value.
6726
6727 2019-01-21  Tom Tromey  <tom@tromey.com>
6728
6729         * ui-out.c: Fix includes.
6730         * tui/tui-source.c: Fix includes.
6731         * target.c: Fix includes.
6732         * remote.c: Fix includes.
6733         * regcache.c: Fix includes.
6734         * python/py-block.c: Fix includes.
6735         * printcmd.c: Fix includes.
6736         * or1k-tdep.c: Fix includes.
6737         * mi/mi-main.c: Fix includes.
6738         * m32r-tdep.c: Fix includes.
6739         * csky-tdep.c: Fix includes.
6740         * compile/compile-cplus-types.c: Fix includes.
6741         * cli/cli-interp.c: Fix includes.
6742
6743 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6744
6745         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6746         for padding.
6747
6748 2019-01-16  Tom Tromey  <tom@tromey.com>
6749
6750         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6751         earlier.
6752         (struct objfile) <msymbols_range>: Move from top level.
6753         <msymbols>: New method.
6754         (class objfile_msymbols): Remove.
6755         * symtab.c (default_collect_symbol_completion_matches_break_on):
6756         Update.
6757         * symmisc.c (dump_msymbols): Update.
6758         * stabsread.c (scan_file_globals): Update.
6759         * objc-lang.c (info_selectors_command, info_classes_command)
6760         (find_methods): Update.
6761         * minsyms.c (find_solib_trampoline_target): Update.
6762         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6763         * coffread.c (coff_symfile_read): Update.
6764         * ada-lang.c (ada_lookup_simple_minsym)
6765         (ada_collect_symbol_completion_matches): Update.
6766
6767 2019-01-16  Tom Tromey  <tom@tromey.com>
6768
6769         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6770         type.  Remove no-argument constructor.
6771         <iterator::operator++>: Simplify.
6772         <begin>: Update.
6773         <end>: Use minimal_symbol_count.
6774
6775 2019-01-16  Tom Tromey  <tom@tromey.com>
6776
6777         * objfiles.h (struct objfile) <psymtabs>: New method.
6778         (class objfile_psymtabs): Remove.
6779         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6780         typedef.
6781         <range>: New method.
6782         (require_partial_symbols): Change return type.
6783         * psymtab.c (require_partial_symbols)
6784         (psym_expand_symtabs_matching): Update.
6785         * mdebugread.c (parse_partial_symbols): Update.
6786         * dbxread.c (dbx_end_psymtab): Update.
6787
6788 2019-01-15  Tom Tromey  <tom@tromey.com>
6789
6790         * symtab.c (lookup_objfile_from_block)
6791         (lookup_symbol_in_objfile_symtabs)
6792         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6793         (find_line_symtab, info_sources_command)
6794         (default_collect_symbol_completion_matches_break_on)
6795         (make_source_files_completion_list): Update.
6796         * symmisc.c (print_objfile_statistics, dump_objfile)
6797         (maintenance_print_symbols, maintenance_info_symtabs)
6798         (maintenance_check_symtabs, maintenance_info_line_tables):
6799         Update.
6800         * source.c (select_source_symtab)
6801         (forget_cached_source_info_for_objfile): Update.
6802         * objfiles.h (class objfile_compunits): Remove.
6803         (struct objfile) <compunits_range>: New typedef.
6804         (compunits): New method.
6805         * objfiles.c (objfile_relocate1): Update.
6806         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6807         * maint.c (count_symtabs_and_blocks): Update.
6808         * linespec.c (iterate_over_all_matching_symtabs): Update.
6809         * cp-support.c (add_symbol_overload_list_qualified): Update.
6810         * coffread.c (coff_symtab_read): Update.
6811         * ada-lang.c (add_nonlocal_symbols)
6812         (ada_collect_symbol_completion_matches)
6813         (ada_add_global_exceptions): Update.
6814
6815 2019-01-15  Tom Tromey  <tom@tromey.com>
6816
6817         * progspace.h (program_space) <objfiles_safe_range>: New
6818         typedef.
6819         <objfiles_safe>: New method.
6820         * objfiles.h (class all_objfiles_safe): Remove.
6821         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6822         * jit.c (jit_inferior_exit_hook): Update.
6823
6824 2019-01-17  Tom Tromey  <tom@tromey.com>
6825
6826         * progspace.h (program_space) <objfiles_range>: New typedef.
6827         <objfiles>: New method.
6828         <objfiles_head>: Rename from objfiles.
6829         (object_files): Update.
6830         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6831         * guile/scm-pretty-print.c
6832         (ppscm_find_pretty_printer_from_objfiles): Update.
6833         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6834         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6835         Update.
6836         * python/py-progspace.c (pspy_get_objfiles): Update.
6837         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6838         Update.
6839         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6840         (objfpy_lookup_objfile_by_build_id): Update.
6841         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6842         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6843         Update.
6844         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6845         (expand_symtab_containing_pc, lookup_objfile_from_block)
6846         (lookup_static_symbol, basic_lookup_transparent_type)
6847         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6848         (find_line_symtab, info_sources_command)
6849         (default_collect_symbol_completion_matches_break_on)
6850         (make_source_files_completion_list, find_main_name): Update.
6851         * symmisc.c (print_symbol_bcache_statistics)
6852         (print_objfile_statistics, maintenance_print_symbols)
6853         (maintenance_print_msymbols, maintenance_print_objfiles)
6854         (maintenance_info_symtabs, maintenance_check_symtabs)
6855         (maintenance_expand_symtabs, maintenance_info_line_tables):
6856         Update.
6857         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6858         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6859         (map_overlay_command, unmap_overlay_command)
6860         (simple_overlay_update, expand_symtabs_matching)
6861         (map_symbol_filenames): Update.
6862         * symfile-debug.c (set_debug_symfile): Update.
6863         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6864         Update.
6865         * source.c (select_source_symtab, forget_cached_source_info):
6866         Update.
6867         * solib.c (solib_read_symbols): Update.
6868         * solib-spu.c (append_ocl_sos): Update.
6869         * psymtab.c (maintenance_print_psymbols)
6870         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6871         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6872         * printcmd.c (info_symbol_command): Update.
6873         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6874         Update.
6875         * objfiles.h (class all_objfiles): Remove.
6876         * objfiles.c (have_partial_symbols, have_full_symbols)
6877         (have_minimal_symbols, qsort_cmp, update_section_map)
6878         (shared_objfile_contains_address_p)
6879         (default_iterate_over_objfiles_in_search_order): Update.
6880         * objc-lang.c (info_selectors_command, info_classes_command)
6881         (find_methods): Update.
6882         * minsyms.c (find_solib_trampoline_target): Update.
6883         * maint.c (maintenance_info_sections)
6884         (maintenance_translate_address, count_symtabs_and_blocks):
6885         Update.
6886         * main.c (captured_main_1): Update.
6887         * linux-thread-db.c (try_thread_db_load_from_pdir)
6888         (has_libpthread): Update.
6889         * linespec.c (iterate_over_all_matching_symtabs)
6890         (search_minsyms_for_name): Update.
6891         * jit.c (jit_find_objf_with_entry_addr): Update.
6892         * hppa-tdep.c (find_unwind_entry)
6893         (hppa_lookup_stub_minimal_symbol): Update.
6894         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6895         Update.
6896         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6897         (elf_gnu_ifunc_resolve_by_got): Update.
6898         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6899         * dwarf-index-write.c (save_gdb_index_command): Update.
6900         * cp-support.c (add_symbol_overload_list_qualified): Update.
6901         * breakpoint.c (create_overlay_event_breakpoint)
6902         (create_longjmp_master_breakpoint)
6903         (create_std_terminate_master_breakpoint)
6904         (create_exception_master_breakpoint): Update.
6905         * blockframe.c (find_pc_partial_function): Update.
6906         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6907         (ada_collect_symbol_completion_matches)
6908         (ada_add_global_exceptions): Update.
6909
6910 2019-01-17  Tom Tromey  <tom@tromey.com>
6911
6912         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6913         declare VEC.
6914         (solib_target_parse_libraries): Change return type.
6915         (library_list_start_segment, library_list_start_section)
6916         (library_list_end_library, library_list_start_library); Update.
6917         (solib_target_free_library_list): Remove.
6918         (solib_target_parse_libraries): Remove cleanup.  Change return
6919         type.
6920         (solib_target_current_sos): Update.
6921
6922 2019-01-17  Tom Tromey  <tromey@bapiya>
6923
6924         * valprint.c: Replace "the the" with "the".
6925         * symtab.c: Replace "the the" with "the".
6926         * solib.c: Replace "the the" with "the".
6927         * solib-dsbt.c: Replace "the the" with "the".
6928         * linespec.c: Replace "the the" with "the".
6929         * dwarf2loc.h: Replace "the the" with "the".
6930         * amd64-windows-tdep.c: Replace "the the" with "the".
6931         * aarch64-tdep.c: Replace "the the" with "the".
6932
6933 2019-01-16  Keith Seitz  <keiths@redhat.com>
6934
6935         PR gdb/23773
6936         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6937         <builder>: Rename to ..
6938         <m_builder>: ... this and make private.
6939         (dwarf2_cu::get_builder): New method.  Change all users of
6940         `builder' to use this method.
6941         (dwarf2_start_symtab): Move to ...
6942         (dwarf2_cu::start_symtab): ... here.  Update all callers
6943         (setup_type_unit_groups): Move to ...
6944         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6945         callers.
6946         (dwarf2_cu::reset_builder): New method.
6947         (process_full_compunit, process_full_type_unit): Use
6948         dwarf2_cu::reset_builder.
6949         (follow_die_offset): Record the ancestor CU if it is different
6950         from the followed DIE's CU.
6951         (follow_die_sig_1): Likewise.
6952
6953 2019-01-15  Tom Tromey  <tom@tromey.com>
6954
6955         * remote.c (class remote_state) <buf>: Now a char_vector.
6956         <buf_size>: Remove.
6957         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6958         parameter.
6959         (remote_target::getpkt_or_notif_sane_1)
6960         (remote_target::getpkt_sane)
6961         (remote_target::getpkt_or_notif_sane): Likewise.
6962         (class remote_target) <putpkt>: New overload.
6963         (remote_target::read_frame): Change type of "buf_p".  Remove
6964         sizeof_p parameter.
6965         (packet_ok): New overload.
6966         (packet_check_result): New overload.
6967         Update all uses.
6968
6969 2019-01-14  Tom Tromey  <tom@tromey.com>
6970
6971         * remote-notif.c (handle_notification, remote_notif_ack)
6972         (remote_notif_parse): Make "buf" const.
6973         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6974         const.
6975         (remote_notif_parse, remote_notif_ack, handle_notification):
6976         Likewise.
6977         * remote.c (remote_notif_stop_parse): Make "buf" const.
6978         (remote_target::remote_parse_stop_reply): Make "buf" const.
6979         (remote_notif_stop_ack): Make "buf" const.
6980
6981 2019-01-14  Tom Tromey  <tom@tromey.com>
6982
6983         * remote.c (remote_console_output): Make parameter const.
6984
6985 2019-01-14  Tom Tromey  <tom@tromey.com>
6986
6987         * target-debug.h (target_debug_print_signals): Constify.
6988         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6989         * procfs.c (procfs_target::pass_signals): Update.
6990         * linux-nat.c (linux_nat_target::pass_signals): Update.
6991         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6992         * target-delegates.c: Rebuild.
6993         * remote.c (remote_target::program_signals): Update.
6994         (remote_target::pass_signals): Update.
6995         * target.c (target_pass_signals): Constify argument.
6996         (target_program_signals): Likewise.
6997         * target.h (struct target_ops) <pass_signals, program_signals>:
6998         Constify argument.
6999         (target_pass_signals, target_program_signals): Constify argument.
7000
7001 2019-01-14  Tom Tromey  <tom@tromey.com>
7002
7003         PR tui/28819:
7004         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7005
7006 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7007
7008         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7009         field.
7010         * rs6000-tdep.c: Include reggroups.h.
7011         (IS_V_ALIAS_PSEUDOREG): Define.
7012         (rs6000_register_name): Return names for the "vX" aliases.
7013         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7014         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7015         aliases.  Call default_register_reggroup_p for all other
7016         pseudo-registers.
7017         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7018         New functions.
7019         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7020         Handle "vX" aliases.
7021         (v_alias_pseudo_register_collect): New function.
7022         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7023         (rs6000_gdbarch_init): Initialize "vX" aliases as
7024         pseudo-registers.  Restore registration of
7025         rs6000_pseudo_register_reggroup_p with
7026         set_tdesc_pseudo_register_reggroup_p.
7027
7028 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7029
7030         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7031         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7032         set_gdbarch_num_pseudo_regs.
7033
7034 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7035
7036         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7037         Remove arg prefixname, add do_set and do_show.
7038         Add member functions set_list and show_list.
7039         * cli/cli-style.c (class cli_style_option): Update accordingly.
7040         (style_set_list): Move to file scope.
7041         (style_show_list): Likewise.
7042         (set_style): Call help_list.
7043         (show_style): Call cmd_show_list.
7044         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7045         Update to use the new macro.
7046
7047 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7048
7049         * ada-lang.c (_initialize_ada_language): Expand the help text
7050         for the "catch exception" command.
7051
7052 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7053
7054         * symtab.c (matching_obj_sections): Initialize obj,
7055         declare it closer to its usage.
7056
7057 2019-01-10  Tom Tromey  <tom@tromey.com>
7058
7059         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7060         (basic_inf_threads_range): Remove.
7061         (inf_threads_range, inf_non_exited_threads_range)
7062         (safe_inf_threads_range): Use next_adapter.
7063
7064 2019-01-10  Keith Seitz  <keiths@redhat.com>
7065
7066         PR gdb/23712
7067         PR symtab/23010
7068         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7069         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7070
7071 2019-01-10  Keith Seitz  <keiths@redhat.com>
7072
7073         PR gdb/23712
7074         PR symtab/23010
7075         * dictionary.c (pending_to_vector): Remove.
7076         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7077         Remove _1 suffix, replacing functions of the same name.  Update
7078         all callers.
7079         (dict_create_hashed, dict_create_hashed_expandable)
7080         (dict_create_linear, dict_create_linear_expandable, dict_free)
7081         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7082         Make functions static.
7083
7084 2019-01-10  Keith Seitz  <keiths@redhat.com>
7085
7086         PR gdb/23712
7087         PR symtab/23010
7088         * dictionary.h (struct dictionary): Replace declaration with
7089         multidictionary.
7090         (dict_create_hashed, dict_create_hashed_expandable)
7091         (dict_create_linear, dict_create_linear_expandable)
7092         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7093         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7094         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7095         taking multidictionary argument.
7096         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7097         * block.h (struct block) <dict>: Change to multidictionary
7098         and rename `multidict'.
7099         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7100         symmisc.c: Update all dictionary references to multidictionary.
7101
7102 2019-01-10  Keith Seitz  <keiths@redhat.com>
7103
7104         PR gdb/23712
7105         PR symtab/23010
7106         * dictionary.c: Include unordered_map.
7107         (pending_to_vector): New function.
7108         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7109         Rewrite the non-"_1" functions to take vector instead
7110         of linked list.
7111         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7112         "new" _1 versions of the same name.
7113         (multidictionary): Define.
7114         (std::hash<enum language): New definition.
7115         (collate_pending_symbols_by_language, mdict_create_hashed)
7116         (mdict_create_hashed_expandable, mdict_create_linear)
7117         (mdict_create_linear_expandable, mdict_free)
7118         (find_language_dictionary, create_new_language_dictionary)
7119         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7120         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7121         (mdict_size, mdict_empty): New functions.
7122         * dictionary.h (mdict_iterator): Define.
7123
7124 2019-01-10  Pedro Alves  <palves@redhat.com>
7125
7126         * breakpoint.c (read_uploaded_action)
7127         (create_tracepoint_from_upload): Adjust to use
7128         gdb::unique_xmalloc_ptr.
7129         * ctf.c (ctf_write_uploaded_tp):
7130         (SET_ARRAY_FIELD): Use emplace_back.
7131         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7132         * tracefile-tfile.c (tfile_write_uploaded_tp):
7133         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7134         gdb::unique_xmalloc_ptr.
7135         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7136         at_string, cond_string, cmd_strings>: Replace char pointers
7137         with gdb::unique_xmalloc_ptr.
7138
7139 2019-01-10  Pedro Alves  <palves@redhat.com>
7140
7141         * solib-target.c (library_list_start_library): Don't xstrdup name.
7142
7143 2019-01-10  Pedro Alves  <palves@redhat.com>
7144
7145         * mdebugread.c (parse_partial_symbols): Use
7146         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7147
7148 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7149
7150         * linux-fork.c (scoped_switch_fork_info)
7151         <~scoped_switch_fork_info>: Fix incorrect variable name.
7152
7153 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7154
7155         * linux-fork.c (scoped_switch_fork_info)
7156         <scoped_switch_fork_info>: Make explicit.
7157         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7158
7159 2019-01-10  Tom Tromey  <tom@tromey.com>
7160
7161         * objfiles.h (objfile::reset_psymtabs): Update.
7162         * objfiles.c (objfile::objfile): Update.
7163         * psymtab.h (psymtab_storage::obstack): Update.
7164         (psymtab_storage::m_obstack): Use gdb::optional.
7165         (class psymtab_storage): Update comment.  Remove objfile
7166         parameter.
7167         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7168
7169 2019-01-10  Tom Tromey  <tom@tromey.com>
7170
7171         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7172         <free_psymtabs>: Now private.
7173         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7174         (allocate_psymtab): Use new method.
7175
7176 2019-01-10  Tom Tromey  <tom@tromey.com>
7177
7178         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7179         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7180         * mdebugread.c (parse_partial_symbols): Use
7181         allocate_dependencies.
7182         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7183         allocate_dependencies.
7184         (process_psymtab_comp_unit_reader)
7185         (build_type_psymtab_dependencies): Likewise.
7186         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7187
7188 2019-01-10  Tom Tromey  <tom@tromey.com>
7189
7190         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7191         PSYMBOL_SET_LANGUAGE.
7192         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7193
7194 2019-01-10  Tom Tromey  <tom@tromey.com>
7195
7196         * psymtab.h (psymtab_storage::obstack): New method.
7197         <m_obstack>: Rename from obstack; now private.
7198         * psymtab.c (psymtab_storage): Update.
7199         * dwarf2read.c (create_addrmap_from_index)
7200         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7201         Update.
7202
7203 2019-01-10  Tom Tromey  <tom@tromey.com>
7204
7205         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7206         * objfiles.h (objfile::reset_psymtabs): New method.
7207
7208 2019-01-10  Tom Tromey  <tom@tromey.com>
7209
7210         * symmisc.c (print_symbol_bcache_statistics): Update.
7211         (print_objfile_statistics): Update.
7212         * symfile.c (reread_symbols): Update.
7213         * psymtab.h (class psymtab_storage): New.
7214         * psymtab.c (psymtab_storage): New constructor.
7215         (~psymtab_storage): New destructor.
7216         (require_partial_symbols): Update.
7217         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7218         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7219         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7220         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7221         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7222         (start_psymtab_common, end_psymtab_common)
7223         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7224         (allocate_psymtab): Update.
7225         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7226         Update.
7227         (dump_psymtab_addrmap, maintenance_print_psymbols)
7228         (maintenance_check_psymtabs): Update.
7229         (class objfile_psymtabs): Move to objfiles.h.
7230         * psympriv.h (discard_psymtab): Now inline.
7231         (psymtab_discarder::psymtab_discarder): Update.
7232         (psymtab_discarder::~psymtab_discarder): Update.
7233         (ALL_OBJFILE_PSYMTABS): Rewrite.
7234         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7235         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7236         Remove fields.
7237         <partial_symtabs>: New field.
7238         (class objfile_psymtabs): Move from psymtab.h.  Update.
7239         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7240         psymbol_cache.
7241         (objfile::~objfile): Don't destroy psymbol_cache.
7242         * mdebugread.c (parse_partial_symbols): Update.
7243         * dwarf2read.c (create_addrmap_from_index)
7244         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7245         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7246         (add_partial_subprogram, dwarf2_ranges_read): Update.
7247         * dwarf-index-write.c (write_address_map)
7248         (write_one_signatured_type, recursively_write_psymbols)
7249         (class debug_names, class debug_names, write_psymtabs_to_index):
7250         Update.
7251
7252 2019-01-10  Tom Tromey  <tom@tromey.com>
7253
7254         * symtab.h (SYMBOL_SET_NAMES): Update.
7255         (symbol_set_names): Update.
7256         (MSYMBOL_SET_NAMES): Update.
7257         * symtab.c (symbol_set_names): Change argument to be an
7258         objfile_per_bfd_storage.
7259         * psymtab.c (add_psymbol_to_bcache): Update.
7260         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7261
7262 2019-01-10  Tom Tromey  <tom@tromey.com>
7263
7264         * symtab.c (create_demangled_names_hash): Change argument to be an
7265         objfile_per_bfd_storage.
7266         (symbol_set_names): Update.
7267
7268 2019-01-10  Tom Tromey  <tom@tromey.com>
7269
7270         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7271         init_psymbol_list.
7272         * psymtab.c (init_psymbol_list): Do nothing if already called.
7273         * psympriv.h (init_psymbol_list): Add comment.
7274         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7275         init_psymbol_list.
7276         * dbxread.c (dbx_symfile_read): Unconditionally call
7277         init_psymbol_list.
7278
7279 2019-01-10  Tom Tromey  <tom@tromey.com>
7280
7281         * xcoffread.c (scan_xcoff_symtab): Update.
7282         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7283         "where".
7284         * mdebugread.c (parse_partial_symbols)
7285         (handle_psymbol_enumerators): Update.
7286         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7287         * dbxread.c (read_dbx_symtab): Update.
7288         * psympriv.h (psymbol_placement): New enum.
7289         (add_psymbol_to_list): Update.
7290
7291 2019-01-10  Tom Tromey  <tom@tromey.com>
7292
7293         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7294         static_psymbols parameters.
7295         (scan_xcoff_symtab): Update.
7296         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7297         static_psymbols parameters.
7298         * psympriv.h (start_psymtab_common): Update.
7299         * mdebugread.c (parse_partial_symbols): Update.
7300         * dwarf2read.c (create_partial_symtab): Update.
7301         * dbxread.c (read_dbx_symtab): Update.
7302         (start_psymtab): Remove global_psymbols and static_psymbols
7303         parameters.
7304
7305 2019-01-10  Tom Tromey  <tom@tromey.com>
7306
7307         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7308         * psymtab.c (allocate_psymtab): Add comment.
7309         * psympriv.h (allocate_psymtab): Add comment.
7310         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7311         initializations.
7312         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7313
7314 2019-01-10  Tom Tromey  <tom@tromey.com>
7315
7316         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7317         Don't declare.
7318         * mipsread.c: Include mdebugread.h.
7319         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7320         Declare.
7321         * elfread.c: Include mdebugread.h.
7322
7323 2019-01-09  Tom Tromey  <tom@tromey.com>
7324
7325         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7326         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7327         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7328         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7329         (psym_lookup_symbol, psym_find_last_source_symtab)
7330         (psym_forget_cached_source_info, psym_print_stats)
7331         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7332         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7333         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7334         (psym_find_compunit_symtab_by_address)
7335         (maintenance_print_psymbols, maintenance_info_psymtabs)
7336         (maintenance_check_psymtabs): Use ranged for.
7337         * psymtab.h (class objfile_psymtabs): New.
7338         (require_partial_symbols): Return objfile_psymtabs.
7339         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7340
7341 2019-01-09  Tom Tromey  <tom@tromey.com>
7342
7343         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7344         (find_pc_mapped_section, list_overlays_command)
7345         (map_overlay_command, unmap_overlay_command)
7346         (simple_overlay_update): Use all_objfiles.
7347         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7348         * printcmd.c (info_symbol_command): Use all_objfiles.
7349         * objfiles.h (ALL_OBJSECTIONS): Remove.
7350         * maint.c (maintenance_translate_address): Use all_objfiles.
7351         * gcore.c (gcore_create_callback): Use all_objfiles.
7352         (objfile_find_memory_regions): Likewise.
7353
7354 2019-01-09  Tom Tromey  <tom@tromey.com>
7355
7356         * symtab.c (find_line_symtab, info_sources_command)
7357         (make_source_files_completion_list): Use objfile_compunits.
7358         * source.c (select_source_symtab): Use objfile_compunits.
7359         * objfiles.h (struct objfile): Update comment.
7360         (ALL_OBJFILES): Remove.
7361         (ALL_FILETABS): Remove.
7362         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7363         objfile_compunits.
7364
7365 2019-01-09  Tom Tromey  <tom@tromey.com>
7366
7367         * symmisc.c (print_objfile_statistics, dump_objfile)
7368         (maintenance_print_symbols): Use compunit_filetabs.
7369         * source.c (forget_cached_source_info_for_objfile): Use
7370         compunit_filetabs.
7371         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7372         (ALL_FILETABS): Use compunit_filetabs.
7373         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7374         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7375
7376 2019-01-09  Tom Tromey  <tom@tromey.com>
7377
7378         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7379         (compunit_filetabs): New.
7380         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7381         compunit_filetabs.
7382         (info_sources_command, make_source_files_completion_list): Remove
7383         declaration.
7384         * symmisc.c (print_objfile_statistics, dump_objfile)
7385         (maintenance_print_symbols): Remove declaration.
7386         (maintenance_info_symtabs): Use compunit_filetabs.
7387         (maintenance_info_line_tables): Likewise.
7388         * source.c (select_source_symtab): Change local variable name.
7389         (forget_cached_source_info_for_objfile): Remove declaration.
7390         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7391         * objfiles.c (objfile_relocate1): Remove declaration.
7392         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7393         declaration.
7394         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7395         * coffread.c (coff_symtab_read): Remove declaration.
7396         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7397         compunit_filetabs.
7398
7399 2019-01-09  Tom Tromey  <tom@tromey.com>
7400
7401         * symtab.c (lookup_objfile_from_block)
7402         (find_pc_sect_compunit_symtab, search_symbols)
7403         (default_collect_symbol_completion_matches_break_on): Use
7404         objfile_compunits.
7405         * objfiles.h (ALL_COMPUNITS): Remove.
7406         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7407         * cp-support.c (add_symbol_overload_list_qualified): Use
7408         objfile_compunits.
7409         * ada-lang.c (ada_collect_symbol_completion_matches)
7410         (ada_add_global_exceptions): Use objfile_compunits.
7411
7412 2019-01-09  Tom Tromey  <tom@tromey.com>
7413
7414         * source.c (select_source_symtab)
7415         (forget_cached_source_info_for_objfile): Remove declaration.
7416         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7417         declaration.
7418         * maint.c (count_symtabs_and_blocks): Remove declaration.
7419         * cp-support.c (add_symbol_overload_list_qualified): Remove
7420         declaration.
7421         * coffread.c (coff_symtab_read): Remove declaration.
7422         * symtab.c (lookup_symbol_in_objfile_symtabs)
7423         (basic_lookup_transparent_type_1): Use objfile_compunits.
7424         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7425         (info_sources_command, search_symbols)
7426         (default_collect_symbol_completion_matches_break_on)
7427         (make_source_files_completion_list): Remove declaration.
7428         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7429         (ada_collect_symbol_completion_matches)
7430         (ada_add_global_exceptions): Remove declaration.
7431         * linespec.c (iterate_over_all_matching_symtabs): Use
7432         objfile_compunits.
7433         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7434         (class objfile_compunits): New.
7435         (ALL_COMPUNITS): Use objfile_compunits.
7436         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7437         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7438         objfile_compunits.
7439         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7440
7441 2019-01-09  Tom Tromey  <tom@tromey.com>
7442
7443         * symtab.c (search_symbols)
7444         (default_collect_symbol_completion_matches_break_on): Use
7445         objfile_msymbols.
7446         * ada-lang.c (ada_lookup_simple_minsym)
7447         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7448         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7449         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7450         objfile_msymbols.
7451         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7452         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7453         * objc-lang.c (find_methods): Use objfile_msymbols.
7454         (info_selectors_command, info_classes_command): Likewise.
7455         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7456         * objfiles.h (class objfile_msymbols): New.
7457         (ALL_OBJFILE_MSYMBOLS): Remove.
7458         (ALL_MSYMBOLS): Remove.
7459
7460 2019-01-09  Tom Tromey  <tom@tromey.com>
7461
7462         * common/next-iterator.h (next_adapter): Add Iterator template
7463         parameter.
7464         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7465         (class all_objfiles_safe): New.
7466         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7467         * objfiles.c (put_objfile_before): Update comment.
7468         (add_separate_debug_objfile): Likewise.
7469         (free_all_objfiles): Use all_objfiles_safe.
7470         (objfile_purge_solibs): Likewise.
7471
7472 2019-01-09  Tom Tromey  <tom@tromey.com>
7473
7474         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7475         (expand_symtab_containing_pc, lookup_static_symbol)
7476         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7477         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7478         all_objfiles.
7479         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7480         * breakpoint.c (create_overlay_event_breakpoint)
7481         (create_longjmp_master_breakpoint)
7482         (create_std_terminate_master_breakpoint)
7483         (create_exception_master_breakpoint): Use all_objfiles.
7484         * linux-thread-db.c (try_thread_db_load_from_pdir)
7485         (has_libpthread): Use all_objfiles.
7486         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7487         * linespec.c (iterate_over_all_matching_symtabs)
7488         (search_minsyms_for_name): Use all_objfiles.
7489         * maint.c (maintenance_info_sections): Use all_objfiles.
7490         * main.c (captured_main_1): Use all_objfiles.
7491         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7492         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7493         * guile/scm-pretty-print.c
7494         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7495         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7496         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7497         (maintenance_print_msymbols): Use all_objfiles.
7498         * source.c (select_source_symtab): Use all_objfiles.
7499         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7500         * symfile.c (remove_symbol_file_command)
7501         (expand_symtabs_matching, map_symbol_filenames): Use
7502         all_objfiles.
7503         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7504         all_objfiles.
7505         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7506         * objc-lang.c (find_methods): Use all_objfiles.
7507         * objfiles.c (have_partial_symbols, have_full_symbols)
7508         (have_minimal_symbols, qsort_cmp)
7509         (default_iterate_over_objfiles_in_search_order): Use
7510         all_objfiles.
7511         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7512         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7513         (maintenance_check_psymtabs): Use all_objfiles.
7514         (ALL_PSYMTABS): Remove.
7515         * compile/compile-object-run.c (do_module_cleanup): Use
7516         all_objfiles.
7517         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7518         * cp-support.c (add_symbol_overload_list_qualified): Use
7519         all_objfiles.
7520         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7521         Use all_objfiles.
7522         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7523         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7524         all_objfiles.
7525         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7526         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7527         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7528         Uses all_objfiles.
7529         * solib.c (solib_read_symbols): Use all_objfiles
7530
7531 2019-01-09  Tom Tromey  <tom@tromey.com>
7532
7533         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7534         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7535         all_objfiles.
7536         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7537         * symmisc.c (print_symbol_bcache_statistics)
7538         (print_objfile_statistics, maintenance_print_objfiles)
7539         (maintenance_info_symtabs, maintenance_check_symtabs)
7540         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7541         all_objfiles.
7542         * source.c (forget_cached_source_info): Use all_objfiles.
7543         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7544         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7545         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7546         * objfiles.c (update_section_map): Use all_objfiles.
7547         (shared_objfile_contains_address_p): Likewise.
7548         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7549         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7550
7551 2019-01-09  Tom Tromey  <tom@tromey.com>
7552
7553         * common/next-iterator.h: New file.
7554         * objfiles.h (class all_objfiles): New.
7555         (struct objfile_iterator): New.
7556
7557 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7558
7559         * NEWS: Move the description of the changed "frame", "select-frame",
7560          and "info frame" commands to the Changed commands section.
7561
7562 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7563
7564         * gdbtypes.c (check_stub_method_group): Remove handling of old
7565         mangling schemes.
7566         * linespec.c (find_methods): Likewise.
7567         * stabsread.c (read_member_functions): Likewise.
7568         * valops.c (search_struct_method): Likewise.
7569         (value_struct_elt_for_reference): Likewise.
7570         * NEWS: Mention this change.
7571
7572 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7575         print_source_lines.
7576         * source.c (print_source_lines_base): Update line number check.
7577         (print_source_lines): New function.
7578         (source_lines_range::source_lines_range): New function.
7579         * source.h (class source_lines_range): New class.
7580         (print_source_lines): New declaration.
7581
7582 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7583
7584         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7585
7586 2019-01-08  Tom Tromey  <tom@tromey.com>
7587             Simon Marchi  <simon.marchi@ericsson.com>
7588
7589         PR gdb/24060
7590         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7591         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7592         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7593         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7594         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7595         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7596
7597 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7598
7599         * source.c (select_source_symtab): Move header comment to
7600         declaration in source.h.
7601         (forget_cached_source_info_for_objfile): Likewise.
7602         (forget_cached_source_info): Likewise.
7603         (identify_source_line): Likewise.
7604         * source.h (identify_source_line): Move declaration from symtab.h
7605         and add comment from source.c
7606         (print_source_lines): Likewise.
7607         (forget_cached_source_info_for_objfile): Likewise.
7608         (forget_cached_source_info): Likewise.
7609         (select_source_symtab): Likewise.
7610         (enum print_source_lines_flag): Move definition from symtab.h.
7611         * symtab.h (identify_source_line): Move declaration to source.h.
7612         (print_source_lines): Likewise.
7613         (forget_cached_source_info_for_objfile): Likewise.
7614         (forget_cached_source_info): Likewise.
7615         (select_source_symtab): Likewise.
7616         (enum print_source_lines_flag): Move definition to source.h.
7617         * tui/tui-hooks.c: Add 'source.h' include.
7618
7619 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7620
7621         * source.c (print_source_lines_base): Handle requests to print
7622         reverse line number sequences, and guard against empty lines
7623         string.
7624
7625 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * source.c (print_source_lines_base): Fix skip of '\r' if next
7628         character is '\n'.
7629
7630 2019-01-06  Tom Tromey  <tom@tromey.com>
7631
7632         * c-exp.y (struct c_parse_state) <macro_original_text,
7633         expansion_obstack>: New member.
7634         (macro_original_text, expansion_obstack): Remove globals.
7635         (scan_macro_expansion, scanning_macro_expansion)
7636         (finished_macro_expansion): Update.
7637         (scan_macro_cleanup): Remove.
7638         (yylex, c_parse): Update.
7639
7640 2019-01-06  Tom Tromey  <tom@tromey.com>
7641
7642         * c-exp.y (struct c_parse_state) <strings>: New member.
7643         (operator_stoken): Update.
7644
7645 2019-01-06  Tom Tromey  <tom@tromey.com>
7646
7647         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7648         (union type_stack_elt) <typelist_val>: Now a pointer to
7649         std::vector.
7650         (type_stack_cleanup): Don't declare.
7651         (push_typelist): Update.
7652         * parse.c (pop_typelist): Return a std::vector.
7653         (push_typelist): Take a std::vector.
7654         (follow_types): Update.  Do not free args.
7655         (type_stack_cleanup): Remove.
7656         * c-exp.y (struct c_parse_state): New.
7657         (cpstate): New global.
7658         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7659         (nonempty_typelist): Update.
7660         (func_mod): Create a new vector.
7661         (c_parse): Create a c_parse_state.
7662         (check_parameter_typelist): Do not delete params.
7663         (function_method): Update.  Do not delete type_list.
7664
7665 2019-01-06  Tom Tromey  <tom@tromey.com>
7666
7667         PR gdb/28155:
7668         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7669         check_typedef.
7670         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7671         (print_return_value): Likewise.
7672
7673 2019-01-05  Tom Tromey  <tom@tromey.com>
7674
7675         * contrib/cleanup_check.py: Remove.
7676         * contrib/gcc-with-excheck: Remove.
7677         * contrib/exsummary.py: Remove.
7678         * contrib/excheck.py: Remove.
7679
7680 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7681
7682         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7683         NULL. Initialize tpprev to NULL instead of assigning it
7684         to NULL on the next statement.
7685         * windows-nat.c (windows_delete_thread): Remove check for
7686         main_thread_id before printing thread exit notifications.
7687         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7688         Remove thread ID check against main_thread_id.
7689         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7690         windows_delete_thread.
7691         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7692
7693 2019-01-04  Tom Tromey  <tom@tromey.com>
7694
7695         * compile/compile.c (_initialize_compile): Use upper case for
7696         metasyntactic variables.
7697         * symmisc.c (_initialize_symmisc): Use upper case for
7698         metasyntactic variables.
7699         * psymtab.c (_initialize_psymtab): Use upper case for
7700         metasyntactic variables.
7701         * demangle.c (demangle_command): Use upper case for metasyntactic
7702         variables.
7703         (_initialize_demangler): Likewise.
7704         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7705         variables.
7706
7707 2019-01-03  Tom Tromey  <tom@tromey.com>
7708
7709         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7710
7711 2019-01-03  Tom Tromey  <tom@tromey.com>
7712
7713         * python/py-symtab.c (salpy_str): Update.
7714         (struct salpy_sal_object) <symtab>: Now a PyObject.
7715         (salpy_dealloc): Update.
7716         (del_objfile_sal): Use gdbpy_ref.
7717
7718 2019-01-03  Tom Tromey  <tom@tromey.com>
7719
7720         * python/py-type.c (convert_field): Use new_reference.  Return
7721         gdbpy_ref.
7722         (make_fielditem): Return gdbpy_ref.
7723         (typy_fields): Update.
7724         (typy_getitem): Update.
7725         (field_name): Return gdbpy_ref.  Use new_reference.
7726         (typy_iterator_iternext): Update.
7727
7728 2019-01-03  Tom Tromey  <tom@tromey.com>
7729
7730         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7731
7732 2019-01-03  Tom Tromey  <tom@tromey.com>
7733
7734         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7735         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7736         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7737         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7738         (pspy_set_type_printers): Likewise.
7739         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7740         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7741         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7742         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7743         (objfpy_set_type_printers): Likewise.
7744
7745 2019-01-03  Tom Tromey  <tom@tromey.com>
7746
7747         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7748         (gdbpy_print_stack): Use gdbpy_err_fetch.
7749         * python/python-internal.h (class gdbpy_err_fetch): New class.
7750         (class gdbpy_enter) <m_error_type, m_error_value,
7751         m_error_traceback>: Remove.
7752         <m_error>: New member.
7753         (gdbpy_exception_to_string): Don't declare.
7754         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7755         * python/py-value.c (convert_value_from_python): Use
7756         gdbpy_err_fetch.
7757         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7758         gdbpy_exception_to_string.
7759         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7760         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7761         gdbpy_err_fetch.
7762
7763 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7764
7765         * linux-nat.c (delete_lwp_cleanup): Delete.
7766         (struct lwp_deleter): New struct.
7767         (lwp_info_up): New typedef.
7768         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7769         lwp_info_up.
7770
7771 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7772
7773         * linux-fork.c (class scoped_switch_fork_info): New class.
7774         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7775
7776 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7777
7778         * valops.c (find_overload_match): Remove use of null_cleanup, and
7779         calls to do_cleanups.
7780
7781 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7782
7783         * compile/compile-cplus-types.c
7784         (compile_cplus_instance::decl_name): Handle changes to
7785         cp_func_name.
7786         * cp-support.c (cp_func_name): Update header comment, update
7787         return type.
7788         * cp-support.h (cp_func_name): Update return type in declaration.
7789         * valops.c (find_overload_match): Move temp_func local to top
7790         level of function and change its type.  Use temp_func to hold and
7791         delete temporary string obtained from cp_func_name.
7792
7793 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7794
7795         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7796         gdb::char_vector, remove cleanup, and update uses of `msg`.
7797
7798 2019-01-03  Jim Wilson  <jimw@sifive.com>
7799
7800         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7801
7802 2019-01-02  Tom Tromey  <tom@tromey.com>
7803
7804         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7805         (tdesc_parse_xml): Remove cleanups.
7806         * target-descriptions.h (make_cleanup_free_target_description):
7807         Don't declare.
7808         (target_desc_deleter): New struct.
7809         (target_desc_up): New typedef.
7810         * target-descriptions.c (target_desc_deleter::operator()): Rename
7811         from free_target_description.
7812         (make_cleanup_free_target_description): Remove.
7813
7814 2019-01-02  Tom Tromey  <tom@tromey.com>
7815
7816         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7817         constructor, destructor.
7818         (linespec_parser): Remove typedef.
7819         (~linespec_parser): Rename from linespec_parser_delete.
7820         (linespec_lex_to_end, linespec_complete_label)
7821         (linespec_complete): Update.
7822         (decode_line_full): Remove cleanups.
7823         (decode_line_1): Update.
7824
7825 2019-01-02  Tom Tromey  <tom@tromey.com>
7826
7827         * python/python-internal.h (inferior_to_inferior_object): Change
7828         return type.
7829         * python/py-exitedevent.c (create_exited_event_object): Update.
7830         * python/py-inferior.c (inferior_to_inferior_object): Return
7831         gdbpy_ref.
7832         (python_new_inferior, python_inferior_deleted)
7833         (thread_to_thread_object, delete_thread_object)
7834         (build_inferior_list, gdbpy_selected_inferior): Update.
7835         * python/py-infthread.c (create_thread_object): Update.  Also fail
7836         if inferior_to_inferior_object fails.
7837
7838 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7839
7840         * inferior.h (class inferior) <displaced_step_state>: New field.
7841         * infrun.h (struct displaced_step_state): Move here from
7842         infrun.c.  Initialize fields, add constructor.
7843         <inf>: Remove field.
7844         <reset>: New method.
7845         * infrun.c (struct displaced_step_inferior_state): Move to
7846         infrun.h.
7847         (displaced_step_inferior_states): Remove.
7848         (get_displaced_stepping_state): Adust.
7849         (displaced_step_in_progress_any_inferior): Adjust.
7850         (displaced_step_in_progress_thread): Adjust.
7851         (displaced_step_in_progress): Adjust.
7852         (add_displaced_stepping_state): Remove.
7853         (get_displaced_step_closure_by_addr): Adjust.
7854         (remove_displaced_stepping_state): Remove.
7855         (infrun_inferior_exit): Call displaced_step_state.reset.
7856         (use_displaced_stepping): Don't check for NULL.
7857         (displaced_step_prepare_throw): Call
7858         get_displaced_stepping_state.
7859         (displaced_step_fixup): Don't check for NULL.
7860         (prepare_for_detach): Don't check for NULL.
7861
7862 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7863
7864         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7865          in case of call that did not complete.
7866
7867 2019-01-02  Andrey Utkin  <autkin@undo.io>
7868
7869         * symfile.c (find_separate_debug_file): Fix search of debug files for
7870         remote debuggee.
7871
7872 2019-01-02  Tom Tromey  <tom@tromey.com>
7873
7874         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7875         indentation.
7876         * python/py-frame.c (frapy_older): Remove cast.
7877         (frapy_newer): Likewise.
7878         * python/py-breakpoint.c (local_setattro): Remove cast.
7879         * python/py-arch.c (archpy_name): Remove local variable.
7880         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7881
7882 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7883
7884         * unittests/basic_string_view/element_access/char/empty.cc:
7885         Fix year range in copyright header.
7886
7887 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7888
7889         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7890         Delete.
7891         <operator==>: Update with for removed field.
7892         <hash>: Likewise.
7893         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7894         <isa_features>: ...this.
7895         <abi_features>: New field.
7896         (riscv_isa_flen): Update comment.
7897         (riscv_abi_xlen): New declaration.
7898         (riscv_abi_flen): New declaration.
7899         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7900         isa_features.
7901         (riscv_abi_xlen): New function.
7902         (riscv_isa_flen): Update to get answer from isa_features.
7903         (riscv_abi_flen): New function.
7904         (riscv_has_fp_abi): Update to get answer from abi_features.
7905         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7906         xlen and flen.
7907         (riscv_call_info) <xlen, flen>: Update comment.
7908         (riscv_call_arg_struct): Remove invalid assertions
7909         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7910         is removed.
7911         (riscv_gdbarch_init): Gather isa features and abi features
7912         separately, ensure both match on the gdbarch when reusing an old
7913         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7914         a target with 64-bit float hardware.
7915
7916 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7917
7918         * source.c (search_command_helper): Stop reverse search
7919         when line 1 has been searched.
7920
7921 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7922
7923         * record-full.c (record_full_base_target::close): Rewrite
7924         record_full_core_buf_list free logic.
7925
7926 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7927
7928         * break-catch-syscall.c (print_one_catch_syscall): xfree
7929         the last text.
7930
7931 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7932
7933         * top.c (print_gdb_version): Update Copyright year in version
7934         message.
7935
7936 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7937
7938         Update copyright year range in all GDB files.
7939
7940 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7941
7942         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7943
7944 For older changes see ChangeLog-2018.
7945 \f
7946 Local Variables:
7947 mode: change-log
7948 left-margin: 8
7949 fill-column: 74
7950 version-control: never
7951 coding: utf-8
7952 End:
7953