gdb/ChangeLog

   1 2019-05-03  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-exp.y (convert_char_literal): Check suffix of each
   4         enumerator.
   5
   6 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
   7
   8         PR ada/21406:
   9         * ada-exp.y (yywrap): Don't define.
  10         * ada-lex.l (%option): Add noyywrap
  11         (yywrap): Remove.
  12
  13 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  14
  15         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  16         _WIN32_WINNT to the XP level, unless already defined to a higher
  17         level.
  18
  19         * unittests/parse-connection-spec-selftests.c:
  20         * ser-tcp.c:
  21         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  22         override.
  23
  24         * symfile.c (find_separate_debug_file): Remove colon from the
  25         drive spec of DOS/Windows file names of the target, so that the
  26         file name produced from DEBUGDIR and the target's directory will
  27         be valid on DOS/Windows systems.
  28
  29 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  30
  31         * rust-lang.c (val_print_struct): Handle printing structures
  32         containing strings.
  33
  34 2019-05-02  Tom Tromey  <tromey@adacore.com>
  35
  36         * valarith.c (_initialize_valarith): Remove.
  37
  38 2019-05-01  Tom Tromey  <tromey@adacore.com>
  39
  40         * ada-lang.c (ada_value_primitive_field): Treat more fields as
  41         bitfields.
  42
  43 2019-05-01  Tom Tromey  <tromey@adacore.com>
  44
  45         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  46         for big-endian copies.
  47
  48 2019-04-30  Ali Tamur  <tamur@google.com>
  49         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  50         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  51         (read_3_bytes): New function.
  52
  53 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  54
  55         * windows-nat.c (main_thread_id): Delete.
  56         (handle_output_debug_string): Replace main_thread_id by
  57         current_event.dwThreadId.
  58         (fake_create_process): Likewise.
  59         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  60         Do not set main_thread_id.
  61         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  62         current_event.dwThreadId.
  63         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  64
  65 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  66
  67         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  68         Use current_event.dwThreadId instead of main_thread_id.
  69
  70 2019-04-30  Tom Tromey  <tromey@adacore.com>
  71
  72         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  73         (create_excep_cond_exprs): Iterate over program spaces.
  74         (ada_exception_catchpoint_cond_string): Examine all minimal
  75         symbols for exception types.
  76
  77 2019-04-30  Tom Tromey  <tromey@adacore.com>
  78
  79         PR c++/24470:
  80         * dwarf2read.c (process_structure_scope): Handle case where type
  81         has template parameters but no symbol was created.
  82
  83 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  84             Chris January  <chris.january@arm.com>
  85
  86         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  87         qualifier.
  88         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  89
  90 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  91
  92         * f-typeprint.c (f_print_type): Update rules for printing
  93         whitespace.
  94         (f_type_print_varspec_suffix): Likewise.
  95
  96 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  97             Chris January  <chris.january@arm.com>
  98
  99         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 100         function arguments.
 101
 102 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 103
 104         * f-lang.c (build_fortran_types): Change name of void type to
 105         lower case.
 106         * f-typeprint.c (f_type_print_base): Print the name of the void
 107         type, rather than a fixed string.
 108         * f-valprint.c (f_decorations): Use lower case void string.
 109
 110 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 111             Chris January  <chris.january@arm.com>
 112
 113         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 114         types for Fortran.
 115
 116 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 117             Chris January  <chris.january@arm.com>
 118             David Lecomber  <david.lecomber@arm.com>
 119
 120         * f-exp.y (BINOP_INTRINSIC): New token.
 121         (exp): New parser rule handling BINOP_INTRINSIC.
 122         (f77_keywords): Add new builtin procedures.
 123         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 124         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 125         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 126         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 127         (print_unop_subexp_f): New function.
 128         (print_binop_subexp_f): New function.
 129         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 130         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 131         (dump_subexp_body_f): Likewise.
 132         (operator_check_f): Likewise.
 133         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 134         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 135
 136 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 137
 138         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 139         UNOP_KIND.
 140         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 141         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 142         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 143         (operator_length_f): New fuction.
 144         (print_subexp_f): New function.
 145         (op_name_f): New function.
 146         (dump_subexp_body_f): New function.
 147         (operator_check_f): New function.
 148         (exp_descriptor_f): Replace standard expression handling functions
 149         with new functions.
 150         * gdb/fortran-operator.def: New file.
 151         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 152         * gdb/std-operator.def: Remove UNOP_KIND.
 153
 154 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 155
 156         * std-operator.def: Remove unbalanced, stray double quote
 157         character.
 158
 159 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 160             Chris January  <chris.january@arm.com>
 161             Daniel Everett  <daniel.everett@arm.com>
 162             Nick Forrington  <nick.forrington@arm.com>
 163             Richard Bunt  <richard.bunt@arm.com>
 164
 165         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 166         of depth when printing anonymous structs or unions.
 167         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 168         Don't print either the top-level value, or the children if the
 169         max-depth is exceeded.
 170         (ppscm_print_children): When printing the key of a map, allow one
 171         extra level of depth.
 172         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 173         print either the top-level value, or the children if the max-depth
 174         is exceeded.
 175         (print_children): When printing the key of a map, allow one extra
 176         level of depth.
 177         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 178         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 179         (user_print_options): Initialise max_depth field.
 180         (val_print_scalar_or_string_type_p): New function.
 181         (val_print): Check to see if the max depth has been reached.
 182         (val_print_check_max_depth): Define new function.
 183         (show_print_max_depth): New function.
 184         (_initialize_valprint): Add 'print max-depth' option.
 185         * valprint.h (struct value_print_options) <max_depth>: New field.
 186         (val_print_check_max_depth): Declare new function.
 187         * NEWS: Document new feature.
 188
 189 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 190
 191         * ada-lang.c (ada_language_defn): Initialise new field.
 192         * c-lang.c (c_is_string_type_p): New function.
 193         (c_language_defn): Initialise new field.
 194         (cplus_language_defn): Initialise new field.
 195         (asm_language_defn): Initialise new field.
 196         (minimal_language_defn): Initialise new field.
 197         * c-lang.h (c_is_string_type_p): Declare new function.
 198         * d-lang.c (d_language_defn): Initialise new field.
 199         * f-lang.c (f_is_string_type_p): New function.
 200         (f_language_defn): Initialise new field.
 201         * go-lang.c (go_is_string_type_p): New function.
 202         (go_language_defn): Initialise new field.
 203         * language.c (default_is_string_type_p): New function.
 204         (unknown_language_defn): Initialise new field.
 205         (auto_language_defn): Initialise new field.
 206         * language.h (struct language_defn) <la_is_string_type_p>: New
 207         member variable.
 208         (default_is_string_type_p): Declare new function.
 209         * m2-lang.c (m2_language_defn): Initialise new field.
 210         * objc-lang.c (objc_language_defn): Initialise new field.
 211         * opencl-lang.c (opencl_language_defn): Initialise new field.
 212         * p-lang.c (pascal_is_string_type_p): New function.
 213         (pascal_language_defn): Initialise new field.
 214         * rust-lang.c (rust_is_string_type_p): New function.
 215         (rust_language_defn): Initialise new field.
 216
 217 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 218
 219         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 220         New field.
 221         * ada-lang.c (ada_language_defn): Initialise new field.
 222         * c-lang.c (c_language_defn): Likewise.
 223         (cplus_language_defn): Likewise.
 224         (asm_language_defn): Likewise.
 225         (minimal_language_defn): Likewise.
 226         * d-lang.c (d_language_defn): Likewise.
 227         * f-lang.c (f_language_defn): Likewise.
 228         * go-lang.c (go_language_defn): Likewise.
 229         * language.c (unknown_language_defn): Likewise.
 230         (auto_language_defn): Likewise.
 231         * m2-lang.c (m2_language_defn): Likewise.
 232         * objc-lang.c (objc_language_defn): Likewise.
 233         * opencl-lang.c (opencl_language_defn): Likewise.
 234         * p-lang.c (pascal_language_defn): Likewise.
 235         * rust-lang.c (rust_language_defn): Likewise.
 236
 237 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * ada-lang.c (ada_is_character_type): Change return type to bool.
 240         (ada_is_string_type): Likewise.
 241         * ada-lang.h (ada_is_character_type): Update declaration
 242         (ada_is_string_type): Likewise.
 243
 244 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 245
 246         Support style in 'frame|thread apply'
 247
 248         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 249         * record.c (record_start, record_stop): Update callers of
 250         execute_command_to_string with false.
 251         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 252         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 253         methods.
 254         (class string_file): New constructor with term_out parameter.
 255         Override methods term_out and can_emit_style_escape.  New member
 256         term_out.
 257         (class stdio_file): Override can_emit_style_escape.
 258         (class tee_file): Override term_out and can_emit_style_escape.
 259         * utils.h (can_emit_style_escape): Remove.
 260         * utils.c (can_emit_style_escape): Likewise.
 261         Update all callers of can_emit_style_escape (SOMESTREAM) to
 262         SOMESTREAM->can_emit_style_escape.
 263         * source-cache.c (source_cache::get_source_lines): Likewise.
 264         * stack.c (frame_apply_command_count): Call execute_command_to_string
 265         passing the term_out characteristic of the current gdb_stdout.
 266         * thread.c (thr_try_catch_cmd): Likewise.
 267         * top.c (execute_command_to_string): pass term_out parameter
 268         to construct the string_file for the command output.
 269         * ui-file.c (term_cli_styling): New function (most code moved
 270         from utils.c can_emit_style_escape).
 271         (string_file::string_file, string_file::can_emit_style_escape,
 272         stdio_file::can_emit_style_escape, tee_file::term_out,
 273         tee_file::can_emit_style_escape): New functions.
 274
 275 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 276
 277         * NEWS: Mention the new set|show may-call-functions.
 278         * infcall.c (may_call_functions_p): New variable.
 279         (show_may_call_functions_p): New function.
 280         (call_function_by_hand_dummy): Throws an error if not
 281         may-call-functions.
 282         (_initialize_infcall): Call add_setshow_boolean_cmd for
 283         may-call-functions.
 284
 285 2019-04-25  Keith Seitz  <keiths@redhat.com>
 286
 287         PR c++/24367
 288         * cp-support.c (inspect_type): Don't attempt substitutions
 289         of symbol with the same name.
 290
 291 2019-04-25  Tom Tromey  <tromey@adacore.com>
 292
 293         PR gdb/24475:
 294         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 295         static.
 296
 297 2019-04-25  Tom Tromey  <tromey@adacore.com>
 298
 299         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 300         rvalue reference.
 301         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 302         (gdb_xml_parser::parse): Use std::move.
 303         * python/python-internal.h (gdbpy_convert_exception): Take a const
 304         reference.
 305         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 306         std::move.
 307         * python/py-utils.c (gdbpy_convert_exception): Take a const
 308         reference.
 309         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 310         Use std::move.
 311         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 312         Use std::move.
 313         * mi/mi-main.c (mi_print_exception): Take a const reference.
 314         * main.c (handle_command_errors): Take a const reference.
 315         * linespec.c (parse_linespec): Use std::move.
 316         * infcall.c (run_inferior_call): Use std::move.
 317         (call_function_by_hand_dummy): Use std::move.
 318         * exec.c (try_open_exec_file): Use std::move.
 319         * exceptions.h (exception_print, exception_fprintf)
 320         (exception_print_same): Update.
 321         * exceptions.c (print_exception, exception_print)
 322         (exception_fprintf, exception_print_same): Change parameters to
 323         const reference.
 324         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 325         * common/new-op.c: Use std::move.
 326         * common/common-exceptions.h (struct gdb_exception): Add move
 327         constructor.
 328         (struct gdb_exception_error, struct gdb_exception_quit, struct
 329         gdb_quit_bad_alloc): Change constructor to move constructor.
 330         (throw_exception): Change parameter to rvalue reference.
 331         * common/common-exceptions.c (throw_exception): Take rvalue
 332         reference.
 333         * cli/cli-interp.c (safe_execute_command): Use std::move.
 334         * breakpoint.c (insert_bp_location, location_to_sals): Use
 335         std::move.
 336
 337 2019-04-25  Tom Tromey  <tromey@adacore.com>
 338
 339         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 340         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 341         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 342         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 343         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 344         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 345         guile/scm-value.c: Use unpack.
 346         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 347         gdbscm_gdb_exception.
 348         (gdbscm_throw_gdb_exception): Likewise.
 349         (struct gdbscm_gdb_exception): New.
 350         (unpack): New function.
 351         (gdbscm_wrap): Use unpack.
 352
 353 2019-04-25  Tom Tromey  <tromey@adacore.com>
 354
 355         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 356         (gdb_rl_callback_handler): Use std::move.
 357         * common/common-exceptions.h (struct gdb_exception): Add move
 358         assignment operator.
 359         (throw_exception_sjlj): Change "exception" to const reference.
 360         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 361         (throw_exception_sjlj): Change "exception" to const reference.
 362
 363 2019-04-25  Tom Tromey  <tromey@adacore.com>
 364
 365         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 366         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 367         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 368         Update.
 369         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 370         Update.
 371         * mi/mi-interp.c (mi_interp::exec): Update.
 372         * linespec.c (parse_linespec): Update.
 373         * infcall.c (run_inferior_call): Update.
 374         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 375         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 376         (gdbscm_lookup_global_symbol): Update.
 377         * guile/scm-param.c (gdbscm_parameter_value): Update.
 378         * guile/scm-frame.c (gdbscm_frame_read_register)
 379         (gdbscm_frame_read_var): Update.
 380         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 381         * exec.c (try_open_exec_file): Update.
 382         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 383         (gdb_rl_callback_handler): Update.
 384         * common/common-exceptions.h (exception_none): Don't declare.
 385         * common/common-exceptions.c (exception_none): Don't define.
 386         (struct catcher) <exception>: Update.
 387         * cli/cli-interp.c (safe_execute_command): Update.
 388         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 389
 390 2019-04-25  Ali Tamur  <tamur@google.com>
 391
 392         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 393         (read_attribute_value): Likewise.
 394         (dwarf2_read_addr_index): Update comment.
 395         (read_str_index): Add DW_FORM_strx.
 396         (dwarf2_string_attr): Likewise.
 397         (dwarf2_const_value_attr): Likewise.
 398         (dump_die_shallow): Likewise.
 399         (dwarf2_fetch_constant_bytes): Likewise.
 400         (skip_form_bytes): Likewise.
 401         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 402
 403 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 404
 405         PR corefiles/11608
 406         PR corefiles/18187
 407         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 408         OFFSET.  Verify if current mapping contains an ELF header.
 409         (linux_find_memory_regions_full): Adjust call to
 410         dump_mapping_p.
 411
 412 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 413             Kang Li <kanglictf@gmail.com>
 414
 415         PR gdb/21600
 416
 417         * dwarf2-frame.c (read_initial_length): Be consistent about using
 418         unsigned representation of length.
 419         (decode_frame_entry_1): Likewise.  Check for wraparound of
 420         end pointer as well as buffer overflow.
 421
 422 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 423
 424         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 425         "vq".
 426
 427 2019-04-24  Tom Tromey  <tromey@adacore.com>
 428
 429         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 430
 431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         * s12z-tdep.c (s12z_unwind_pc): Delete.
 434         (s12z_unwind_sp): Delete.
 435         (s12z_gdbarch_init): Don't register deleted functions with
 436         gdbarch.
 437
 438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 439
 440         * rl78-tdep.c (rl78_unwind_sp): Delete.
 441         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 442
 443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 444
 445         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 446         (xstormy16_unwind_pc): Delete.
 447         (xstormy16_dummy_id): Delete.
 448         (xstormy16_gdbarch_init): Don't register deleted functions with
 449         gdbarch.
 450
 451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * vax-tdep.c (vax_unwind_pc): Delete.
 454         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 455
 456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 457
 458         * v850-tdep.c (v850_unwind_sp): Delete.
 459         (v850_unwind_pc): Delete.
 460         (v850_dummy_id): Delete.
 461         (v850_gdbarch_init): Don't register deleted functions with
 462         gdbarch.
 463
 464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 465
 466         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 467         (tilegx_unwind_pc): Delete.
 468         (tilegx_unwind_dummy_id): Delete.
 469         (tilegx_gdbarch_init): Don't register deleted functions with
 470         gdbarch.
 471
 472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 473
 474         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 475         (tic6x_dummy_id): Delete.
 476         (tic6x_gdbarch_init): Don't register deleted functions with
 477         gdbarch.
 478
 479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 480
 481         * sparc-tdep.c (sparc_unwind_pc): Delete.
 482         (sparc32_gdbarch_init): Don't register deleted function with
 483         gdbarch.
 484
 485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 486
 487         * sh-tdep.c (sh_unwind_sp): Delete.
 488         (sh_unwind_pc): Delete.
 489         (sh_dummy_id): Delete.
 490         (sh_gdbarch_init): Don't register deleted functions with
 491         gdbarch.
 492
 493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * score-tdep.c (score_unwind_sp): Delete.
 496         (score_unwind_pc): Delete.
 497         (score_dummy_id): Delete.
 498         (score_gdbarch_init): Don't register deleted functions with
 499         gdbarch.
 500
 501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 502
 503         * rx-tdep.c (rx_unwind_pc): Delete.
 504         (rx_unwind_sp): Delete.
 505         (rx_dummy_id): Delete.
 506         (rx_gdbarch_init): Don't register deleted functions with
 507         gdbarch.  Update comment.
 508
 509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 510
 511         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 512         (rs6000_dummy_id): Delete.
 513         (rs6000_gdbarch_init): Don't register deleted functions with
 514         gdbarch.
 515
 516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * or1k-tdep.c (or1k_dummy_id): Delete.
 519         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 520
 521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 522
 523         * nios2-tdep.c (nios2_dummy_id): Delete.
 524         (nios2_unwind_sp): Delete.
 525         (nios2_gdbarch_init): Don't register deleted functions with
 526         gdbarch.
 527
 528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 529
 530         * nds32-tdep.c (nds32_dummy_id): Delete.
 531         (nds32_unwind_pc): Delete.
 532         (nds32_unwind_sp): Delete.
 533         (nds32_gdbarch_init): Don't register deleted functions with
 534         gdbarch.
 535
 536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 537
 538         * msp430-tdep.c (msp430_unwind_pc): Delete.
 539         (msp430_unwind_sp): Delete.
 540         (msp430_dummy_id): Delete.
 541         (msp430_gdbarch_init): Don't register deleted functions with
 542         gdbarch.
 543
 544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 545
 546         * moxie-tdep.c (moxie_unwind_sp): Delete.
 547         (moxie_unwind_pc): Delete.
 548         (moxie_dummy_id): Delete.
 549         (moxie_gdbarch_init): Don't register deleted functions with
 550         gdbarch.
 551
 552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 553
 554         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 555         (mn10300_unwind_pc): Delete.
 556         (mn10300_unwind_sp): Delete.
 557         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 558         mn10300_unwind_sp.
 559         (mn10300_frame_unwind_init): Don't register deleted functions with
 560         gdbarch.
 561
 562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 563
 564         * mep-tdep.c (mep_unwind_pc): Delete.
 565         (mep_unwind_sp): Delete.
 566         (mep_dummy_id): Delete.
 567         (mep_gdbarch_init): Don't register deleted functions with
 568         gdbarch.
 569
 570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 571
 572         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 573         (m68hc11_unwind_sp): Delete.
 574         (m68hc11_gdbarch_init): Don't register deleted functions with
 575         gdbarch.
 576
 577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 578
 579         * m32r-tdep.c (m32r_unwind_sp): Delete.
 580         (m32r_unwind_pc): Delete.
 581         (m32r_dummy_id): Delete.
 582         (m32r_gdbarch_init): Don't register deleted functions with
 583         gdbarch.
 584
 585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 586
 587         * m32c-tdep.c (m32c_unwind_pc): Delete.
 588         (m32c_unwind_sp): Delete.
 589         (m32c_dummy_id): Delete.
 590         (m32c_gdbarch_init): Don't register deleted functions with
 591         gdbarch.
 592
 593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 594
 595         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 596         (lm32_unwind_pc): Delete.
 597         (lm32_dummy_id): Delete.
 598         (lm32_gdbarch_init): Don't register deleted functions with
 599         gdbarch.
 600
 601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 604         (iq2000_unwind_pc): Delete.
 605         (iq2000_dummy_id): Delete.
 606         (iq2000_gdbarch_init): Don't register deleted functions with
 607         gdbarch.
 608
 609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 610
 611         * nds32-tdep.c (nds32_type_align): Delete.
 612         (nds32_push_dummy_call): Use type_align instead.
 613
 614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 615
 616         * arm-tdep.c (arm_type_align): Only handle vector override case.
 617         (arm_push_dummy_call): Use type_align.
 618         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 619
 620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 621
 622         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 623         case.
 624         (pass_on_stack): Use type_align.
 625         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 626         function.
 627
 628 2019-04-23  Tom Tromey  <tromey@adacore.com>
 629
 630         * dwarf2read.c (line_header::file_name_at): Remove unused
 631         overload.
 632
 633 2019-04-23  Tom de Vries  <tdevries@suse.de>
 634
 635         PR gdb/24438
 636         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 637         invocation.
 638
 639
 640 2019-03-27  Ali Tamur  <tamur@google.com>
 641
 642         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 643         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 644         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 645         (dwarf_expr_context::get_addr_index): Likewise
 646         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 647         (symbol_needs_eval_context::get_addr_index): Likewise
 648         (disassemble_dwarf_expression): Add DW_OP_addrx
 649         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 650         (read_cutu_die_from_dwo): Update comment
 651         (skip_one_die): Add DW_FORM_addrx
 652         (read_attribute_value): Likewise
 653         (var_decode_location): Add DW_OP_addrx
 654         (dwarf2_const_value_attr): Add DW_FORM_addrx
 655         (dump_die_shallow): Likewise
 656         (dwarf2_fetch_constant_bytes): Likewise
 657         (decode_locdesc): Add DW_OP_addrx
 658         (skip_form_bytes): Add DW_FORM_addrx
 659
 660 2019-04-22  Ali Tamur  <tamur@google.com>
 661
 662         * MAINTAINERS (Write After Approval): Add self.
 663
 664 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 665
 666         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 667         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 668         (open_symbol_file_object): Likewise.
 669         (svr4_default_sos): Add info parameter.
 670         (svr4_read_so_list): Likewise.
 671         (svr4_current_sos_direct): Adjust functions calls to pass down
 672         info.
 673         (svr4_current_sos_1): Add info parameter.
 674         (svr4_current_sos): Call get_svr4_info, pass info down to
 675         svr4_current_sos_1.
 676         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 677         get_svr4_info.
 678         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 679         get_svr4_info.
 680         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 681         to get_svr4_info.
 682         (probes_table_remove_objfile_probes): Likewise.
 683         (register_solib_event_probe): Add info parameter.
 684         (solist_update_incremental): Pass info parameter down to
 685         svr4_read_so_list.
 686         (disable_probes_interface): Add info parameter.
 687         (svr4_handle_solib_event): Pass current_program_space to
 688         get_svr4_info.  Adjust disable_probes_interface cleanup.
 689         (svr4_create_probe_breakpoints): Add info parameter, pass it
 690         down to register_solib_event_probe.
 691         (svr4_create_solib_event_breakpoints): Add info parameter,
 692         pass it down to svr4_create_probe_breakpoints.
 693         (enable_break): Pass info down to
 694         svr4_create_solib_event_breakpoints.
 695         (svr4_solib_create_inferior_hook): Pass current_program_space to
 696         get_svr4_info.
 697         (svr4_clear_solib): Likewise.
 698
 699 2019-04-22  Pedro Alves  <palves@redhat.com>
 700
 701         * solib-svr4.c (svr4_free_objfile_observer): New.
 702         (probe_and_action::objfile): New field.
 703         (probes_table_htab_remove_objfile_probes)
 704         (probes_table_remove_objfile_probes): New functions.
 705         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 706         in the new probe_and_action.  Don't store the probe in 'lookup'.
 707         (svr4_create_probe_breakpoints): Pass objfile to
 708         register_solib_event_probe.
 709         (_initialize_svr4_solib): Register a free_objfile observer.
 710
 711 2019-04-19  Tom Tromey  <tom@tromey.com>
 712
 713         * common/queue.h: Remove.
 714
 715 2019-04-19  Tom Tromey  <tom@tromey.com>
 716
 717         * event-loop.c: Don't include "common/queue.h".
 718
 719 2019-04-19  Tom Tromey  <tom@tromey.com>
 720
 721         * remote.c (remote_target): Use delete.
 722         * remote-notif.h: Include <list>, not "common/queue.h".
 723         (notif_client_p): Remove typedef.
 724         (remote_notif_state): Add constructor, destructor, initializer.
 725         <notif_queue>: Now a std::list.
 726         (remote_notif_state_xfree): Don't declare.
 727         * remote-notif.c (remote_notif_process, handle_notification)
 728         (remote_notif_state_allocate): Update.
 729         (~remote_notif_state): Rename from remote_notif_state_xfree.
 730
 731 2019-04-19  Tom Tromey  <tom@tromey.com>
 732
 733         * symfile.c (reread_symbols): Update.
 734         * objfiles.c (objfile_register_static_link)
 735         (objfile_lookup_static_link): Update
 736         (~objfile) Don't delete static_links.
 737         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 738
 739 2019-04-19  Tom Tromey  <tom@tromey.com>
 740
 741         * type-stack.h (struct type_stack) <insert>: Constify string.
 742         * type-stack.c (type_stack::insert): Constify string.
 743         * gdbtypes.h (lookup_template_type): Update.
 744         (address_space_name_to_int): Update.
 745         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 746         const.
 747         (lookup_template_type): Make name const.
 748         * c-exp.y: Update rules.
 749         (lex_one_token, classify_name, classify_inner_name)
 750         (c_print_token): Update.
 751         * p-exp.y: Update rules.
 752         (yylex): Update.
 753         * f-exp.y: Update rules.
 754         (yylex): Update.
 755         * d-exp.y: Update rules.
 756         (lex_one_token, classify_name, classify_inner_name): Update.
 757         * parse.c (write_dollar_variable, copy_name): Return std::string.
 758         * parser-defs.h (copy_name): Change return type.
 759         * m2-exp.y: Update rules.
 760         (yylex): Update.
 761         * go-exp.y (lex_one_token): Update.
 762         Update rules.
 763         (classify_unsafe_function, classify_packaged_name)
 764         (classify_name, yylex): Update.
 765
 766 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 767
 768         * configure.ac: add --enable-source-highlight switch.
 769         * configure: Regenerate.
 770         * top.c (print_gdb_version): plumb --enable-source-highlight
 771         status to "show configuration".
 772
 773 2019-04-19  Tom Tromey  <tromey@adacore.com>
 774
 775         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 776         Check ADA_TYPE_P.
 777         (empty_record, ada_template_to_fixed_record_type_1)
 778         (template_to_static_fixed_type)
 779         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 780         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 781         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 782         macros.
 783
 784 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 785
 786         PR symtab/24423:
 787         * source.c (print_source_lines_base): Advance "iter" when a
 788         control character is seen.
 789
 790 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 791
 792         * inferior.h (struct infcall_suspend_state_deleter):
 793         Catch exception in destructor to avoid crash.
 794
 795 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 796
 797         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 798         close to the add_com "shell".
 799
 800 2019-04-18  Tom Tromey  <tromey@adacore.com>
 801
 802         * process-stratum-target.h (class process_stratum_target)
 803         <stratum>: Add "final".
 804
 805 2019-04-17  Tom Tromey  <tromey@adacore.com>
 806
 807         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 808         against nullptr before use.
 809
 810 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 811
 812         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 813
 814 2019-04-17  Jim Wilson  <jimw@sifive.com>
 815             Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 818         code read might fail, assume 4-byte breakpoint in that case.
 819
 820 2019-04-15  Leszek Swirski  <leszeks@google.com>
 821
 822         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 823         rather than a hand-rolled POD check when checking for forced MEMORY
 824         classification.
 825
 826 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 827
 828         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 829         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 830         function.
 831         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 832         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 833         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 834         declaration.
 835
 836 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 837
 838         * aarch64-linux-nat.c
 839         (aarch64_linux_nat_target::thread_architecture): Add override.
 840         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 841         each VQ.
 842
 843 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 844
 845         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 846
 847 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 848
 849         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 850         target types of size 96-bits, add some additional comments, and
 851         check that the builtin type we found was the correct size.
 852
 853 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 854
 855         * utils.c (prompt_for_continue): Don't restore the styling at the
 856         end, as applied_style has the wrong value.  This fixes styling in
 857         long lists of file names that are interrupted by the "Continue?"
 858         prompt.
 859
 860 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 861
 862         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 863         * c-lang.c (c_language_defn): Likewise.
 864         (cplus_language_defn): Likewise.
 865         (asm_language_defn): Likewise.
 866         (minimal_language_defn): Likewise.
 867         * d-lang.c (d_language_defn): Likewise.
 868         * f-lang.c (f_language_defn): Likewise.
 869         * go-lang.c (go_language_defn): Likewise.
 870         * language.c (unknown_language_defn): Likewise.
 871         (auto_language_defn): Likewise.
 872         * language.h (struct language_defn): Remove la_magic field.
 873         (LANG_MAGIC): Delete.
 874         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 875         * objc-lang.c (objc_language_defn): Likewise.
 876         * opencl-lang.c (opencl_language_defn): Likewise.
 877         * p-lang.c (pascal_language_defn): Likewise.
 878         * rust-lang.c (rust_language_defn): Likewise.
 879
 880 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 881
 882         * riscv-tdep.c (riscv_type_align): New function.
 883         (riscv_type_alignment): Delete.
 884         (riscv_arg_location): Use 'type_align'.
 885         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 886
 887 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * gdbtypes.c (type_align): A struct with no non-static fields also
 890         has alignment of 1.
 891
 892 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 893
 894         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 895         component to 0.
 896         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 897         member.
 898         (riscv_struct_info::analyse): New implementation using new
 899         analyse_inner member function.
 900         (riscv_struct_info::field_offset): New member function.
 901         (riscv_struct_info::m_offsets): New member variable.
 902         (riscv_struct_info::analyse_inner): New private member function,
 903         takes the old implementation of riscv_struct_info::analyse but
 904         extended to track field offsets.
 905         (riscv_call_arg_struct): Update the struct folding special cases
 906         to handle cases where empty C++ structs, which are non-zero
 907         length, are found.
 908         (riscv_arg_location): Initialise the length of each location, a
 909         non-zero length now indicates the location is in use.
 910         (riscv_push_dummy_call): Allow for the first location having a
 911         non-zero offset when setting up arguments.
 912         (riscv_return_value): Likewise, but for return values.
 913
 914 2019-04-11  Tom Tromey  <tromey@adacore.com>
 915
 916         * utils.c (internal_vproblem): Make "msg" const.
 917
 918 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 919
 920         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 921         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 922         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 923         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 924
 925 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 926
 927         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 928         function.
 929         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 930         of amd64_collect_native_gregset.
 931         (amd64_linux_nat_target::store_registers): Likewise.
 932
 933 2019-04-10  Tom Tromey  <tom@tromey.com>
 934
 935         * symtab.c (lookup_global_symbol_from_objfile)
 936         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 937         * objfiles.h (class separate_debug_iterator): New.
 938         (class separate_debug_range): New.
 939         (struct objfile) <separate_debug_objfiles>: New method.
 940         (objfile_separate_debug_iterate): Don't declare.
 941         * objfiles.c (separate_debug_iterator::operator++): Rename from
 942         objfile_separate_debug_iterate.
 943         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 944         iterator.
 945         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 946         iterator.
 947
 948 2019-04-10  Tom Tromey  <tom@tromey.com>
 949
 950         * symfile.c (reread_symbols): Remove old comment.
 951         * objfiles.c (free_all_objfiles): Fix a typo.
 952
 953 2019-04-10  Tom Tromey  <tom@tromey.com>
 954
 955         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 956         * minsyms.c (lookup_minimal_symbol): Use foreach.
 957         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 958         (lookup_minimal_symbol_solib_trampoline): Likewise.
 959         * symfile.c (reread_symbols): Use foreach.
 960
 961 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 962             Tom Tromey  <tromey@adacore.com>
 963
 964         PR rust/24414:
 965         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 966         (rust_lex_int_test): Change "value" to be LONGEST.
 967         (rust_lex_tests): Add test for long integer literal.
 968
 969 2019-04-09  Tom Tromey  <tromey@adacore.com>
 970
 971         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 972         to bool.
 973         (extended_remote_target::attach): Update.
 974         (remote_target::remote_notice_new_inferior): Update.
 975         (remote_target::add_current_inferior_and_thread): Update.
 976         * inferior.c (exit_inferior_1): Use "false".
 977         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 978
 979 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 980
 981         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 982         the "start" command.
 983
 984 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 985
 986         * python/py-inferior.c (infpy_thread_from_thread_handle):
 987         Adjust comments to reflect renaming of thread_from_thread_handle
 988         to thread_from_handle.  Adjust keywords.  Fix type error message.
 989         (inferior_object_methods): Add thread_from_handle.  Retain
 990         thread_from_thread_handle, but mark it as deprecated.
 991
 992 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 993
 994         * gdbthread.h (find_thread_by_handle): Revise declaration.
 995         * thread.c (find_thread_by_handle): Likewise.  Adjust
 996         implementation too.
 997         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 998         support for buffer objects as handles.
 999
1000 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1001
1002         * python/py-infthread.c (thpy_thread_handle): New function.
1003         (thread_object_methods): Register thpy_thread_handle.
1004
1005 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1006
1007         * gdbthread.h (thread_to_thread_handle): Declare.
1008         * thread.c (gdbtypes.h): Include.
1009         (thread_to_thread_handle): New function.
1010
1011         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1012         (target_thread_info_to_thread_handle): Declare.
1013         * target.c (target_thread_info_to_thread_handle): New function.
1014         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1015         * target-delegates.c: Regenerate.
1016
1017         * linux-thread-db.c (class thread_db_target): Add method
1018         thread_info_to_thread_handle.
1019         (thread_db_target::thread_info_to_thread_handle): Define.
1020         * remote.c (class remote_target): Add new method
1021         thread_info_to_thread_handle.
1022         (remote_target::thread_info_to_thread_handle): Define.
1023
1024 2019-04-08  Pedro Alves  <palves@redhat.com>
1025
1026         * common/common-exceptions.c (throw_exception): Don't create
1027         named object to throw; throw directly.
1028         (throw_it): Likewise.  Don't initialize gdb_exception::message
1029         here, with new; pass FMT and AP to the ctor instead.
1030         * common/common-exceptions.h: Include <string>.
1031         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1032         const char *, va_list)): New ctor.  Use std::make_shared.
1033         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1034         errors)): Delete.
1035         (gdb_exception_error::gdb_exception_error(enum errors, const char
1036         *, va_list)): New.
1037         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1038         Add assertion.
1039         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1040         errors)): Delete.
1041         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1042         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1043         Add assertion.
1044
1045 2019-04-08  Tom Tromey  <tom@tromey.com>
1046
1047         * valops.c (value_rtti_indirect_type): Replace throw_exception
1048         with throw.
1049         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1050         with throw.
1051         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1052         throw.
1053         * target.c (target_translate_tls_address): Replace throw_exception
1054         with throw.
1055         * stack.c (frame_apply_command_count): Replace throw_exception
1056         with throw.
1057         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1058         throw.
1059         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1060         with throw.
1061         * rs6000-tdep.c (rs6000_frame_cache)
1062         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1063         * remote.c: Replace throw_exception with throw.
1064         * record-full.c (record_full_message, record_full_wait_1)
1065         (record_full_restore): Replace throw_exception with throw.
1066         * record-btrace.c:
1067         (get_thread_current_frame_id, record_btrace_start_replaying)
1068         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1069         (cmd_record_btrace_start): Replace throw_exception with throw.
1070         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1071         throw.
1072         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1073         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1074         * linespec.c:
1075         (find_linespec_symbols): Replace throw_exception with throw.
1076         * infrun.c (displaced_step_prepare, resume): Replace
1077         throw_exception with throw.
1078         * infcmd.c (post_create_inferior): Replace throw_exception with
1079         throw.
1080         * inf-loop.c (inferior_event_handler): Replace throw_exception
1081         with throw.
1082         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1083         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1084         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1085         (get_prev_frame_always, get_frame_pc_if_available)
1086         (get_frame_address_in_block_if_available, get_frame_language):
1087         Replace throw_exception with throw.
1088         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1089         throw_exception with throw.
1090         * eval.c (fetch_subexp_value, evaluate_var_value)
1091         (evaluate_funcall, evaluate_subexp_standard): Replace
1092         throw_exception with throw.
1093         * dwarf2loc.c (call_site_find_chain)
1094         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1095         Replace throw_exception with throw.
1096         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1097         with throw.
1098         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1099         throw.
1100         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1101         * completer.c (complete_line_internal): Replace throw_exception
1102         with throw.
1103         * compile/compile-object-run.c (compile_object_run): Replace
1104         throw_exception with throw.
1105         * cli/cli-script.c (process_next_line): Replace throw_exception
1106         with throw.
1107         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1108         (btrace_enable, btrace_maint_update_pt_packets): Replace
1109         throw_exception with throw.
1110         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1111         throw_exception with throw.
1112         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1113         throw_exception with throw.
1114         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1115         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1116         * aarch64-tdep.c (aarch64_make_prologue_cache)
1117         (aarch64_make_stub_cache): Replace throw_exception with throw.
1118
1119 2019-04-08  Tom Tromey  <tom@tromey.com>
1120
1121         * common/common-exceptions.c (throw_exception): Rename from
1122         throw_exception_cxx.  Remove old copy.  Make argument const.
1123         (throw_it): Create and throw exception objects directly.
1124         * common/common-exceptions.h (throw_exception): Make argument
1125         const.
1126         (struct gdb_exception_error): Add constructor.
1127         (struct gdb_exception_quit): Add constructor.
1128
1129 2019-04-08  Tom Tromey  <tom@tromey.com>
1130
1131         * common/common-exceptions.h (exception_rethrow): Don't declare.
1132         (TRY_SJLJ): Update comment.
1133         (TRY, CATCH, END_CATCH): Remove.
1134         * common/common-exceptions.c (exception_rethrow): Remove.
1135
1136 2019-04-08  Tom Tromey  <tom@tromey.com>
1137
1138         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1139         Remove.
1140         (gdb_exception_error): Rename from
1141         gdb_exception_RETURN_MASK_ERROR.
1142         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1143         (gdb_quit_bad_alloc): Update.
1144         * aarch64-tdep.c: Update.
1145         * ada-lang.c: Update.
1146         * ada-typeprint.c: Update.
1147         * ada-valprint.c: Update.
1148         * amd64-tdep.c: Update.
1149         * arch-utils.c: Update.
1150         * break-catch-throw.c: Update.
1151         * breakpoint.c: Update.
1152         * btrace.c: Update.
1153         * c-varobj.c: Update.
1154         * cli/cli-cmds.c: Update.
1155         * cli/cli-interp.c: Update.
1156         * cli/cli-script.c: Update.
1157         * common/common-exceptions.c: Update.
1158         * common/new-op.c: Update.
1159         * common/selftest.c: Update.
1160         * compile/compile-c-symbols.c: Update.
1161         * compile/compile-cplus-symbols.c: Update.
1162         * compile/compile-object-load.c: Update.
1163         * compile/compile-object-run.c: Update.
1164         * completer.c: Update.
1165         * corelow.c: Update.
1166         * cp-abi.c: Update.
1167         * cp-support.c: Update.
1168         * cp-valprint.c: Update.
1169         * darwin-nat.c: Update.
1170         * disasm-selftests.c: Update.
1171         * dtrace-probe.c: Update.
1172         * dwarf-index-cache.c: Update.
1173         * dwarf-index-write.c: Update.
1174         * dwarf2-frame-tailcall.c: Update.
1175         * dwarf2-frame.c: Update.
1176         * dwarf2loc.c: Update.
1177         * dwarf2read.c: Update.
1178         * eval.c: Update.
1179         * event-loop.c: Update.
1180         * event-top.c: Update.
1181         * exec.c: Update.
1182         * f-valprint.c: Update.
1183         * fbsd-tdep.c: Update.
1184         * frame-unwind.c: Update.
1185         * frame.c: Update.
1186         * gdbtypes.c: Update.
1187         * gnu-v3-abi.c: Update.
1188         * guile/guile-internal.h: Update.
1189         * guile/scm-block.c: Update.
1190         * guile/scm-breakpoint.c: Update.
1191         * guile/scm-cmd.c: Update.
1192         * guile/scm-disasm.c: Update.
1193         * guile/scm-frame.c: Update.
1194         * guile/scm-lazy-string.c: Update.
1195         * guile/scm-math.c: Update.
1196         * guile/scm-param.c: Update.
1197         * guile/scm-ports.c: Update.
1198         * guile/scm-pretty-print.c: Update.
1199         * guile/scm-symbol.c: Update.
1200         * guile/scm-symtab.c: Update.
1201         * guile/scm-type.c: Update.
1202         * guile/scm-value.c: Update.
1203         * i386-linux-tdep.c: Update.
1204         * i386-tdep.c: Update.
1205         * inf-loop.c: Update.
1206         * infcall.c: Update.
1207         * infcmd.c: Update.
1208         * infrun.c: Update.
1209         * jit.c: Update.
1210         * language.c: Update.
1211         * linespec.c: Update.
1212         * linux-fork.c: Update.
1213         * linux-nat.c: Update.
1214         * linux-tdep.c: Update.
1215         * linux-thread-db.c: Update.
1216         * main.c: Update.
1217         * mi/mi-cmd-break.c: Update.
1218         * mi/mi-cmd-stack.c: Update.
1219         * mi/mi-interp.c: Update.
1220         * mi/mi-main.c: Update.
1221         * objc-lang.c: Update.
1222         * p-valprint.c: Update.
1223         * parse.c: Update.
1224         * ppc-linux-tdep.c: Update.
1225         * printcmd.c: Update.
1226         * python/py-arch.c: Update.
1227         * python/py-breakpoint.c: Update.
1228         * python/py-cmd.c: Update.
1229         * python/py-finishbreakpoint.c: Update.
1230         * python/py-frame.c: Update.
1231         * python/py-framefilter.c: Update.
1232         * python/py-gdb-readline.c: Update.
1233         * python/py-inferior.c: Update.
1234         * python/py-infthread.c: Update.
1235         * python/py-lazy-string.c: Update.
1236         * python/py-linetable.c: Update.
1237         * python/py-objfile.c: Update.
1238         * python/py-param.c: Update.
1239         * python/py-prettyprint.c: Update.
1240         * python/py-progspace.c: Update.
1241         * python/py-record-btrace.c: Update.
1242         * python/py-record.c: Update.
1243         * python/py-symbol.c: Update.
1244         * python/py-type.c: Update.
1245         * python/py-unwind.c: Update.
1246         * python/py-utils.c: Update.
1247         * python/py-value.c: Update.
1248         * python/python.c: Update.
1249         * record-btrace.c: Update.
1250         * record-full.c: Update.
1251         * remote-fileio.c: Update.
1252         * remote.c: Update.
1253         * riscv-tdep.c: Update.
1254         * rs6000-aix-tdep.c: Update.
1255         * rs6000-tdep.c: Update.
1256         * rust-exp.y: Update.
1257         * rust-lang.c: Update.
1258         * s390-tdep.c: Update.
1259         * selftest-arch.c: Update.
1260         * solib-dsbt.c: Update.
1261         * solib-frv.c: Update.
1262         * solib-spu.c: Update.
1263         * solib-svr4.c: Update.
1264         * solib.c: Update.
1265         * sparc64-linux-tdep.c: Update.
1266         * stack.c: Update.
1267         * symfile-mem.c: Update.
1268         * symmisc.c: Update.
1269         * target.c: Update.
1270         * thread.c: Update.
1271         * top.c: Update.
1272         * tracefile-tfile.c: Update.
1273         * tui/tui.c: Update.
1274         * typeprint.c: Update.
1275         * unittests/cli-utils-selftests.c: Update.
1276         * unittests/parse-connection-spec-selftests.c: Update.
1277         * valops.c: Update.
1278         * valprint.c: Update.
1279         * value.c: Update.
1280         * varobj.c: Update.
1281         * windows-nat.c: Update.
1282         * x86-linux-nat.c: Update.
1283         * xml-support.c: Update.
1284
1285 2019-04-08  Tom Tromey  <tom@tromey.com>
1286
1287         * xml-support.c: Use C++ exception handling.
1288         * x86-linux-nat.c: Use C++ exception handling.
1289         * windows-nat.c: Use C++ exception handling.
1290         * varobj.c: Use C++ exception handling.
1291         * value.c: Use C++ exception handling.
1292         * valprint.c: Use C++ exception handling.
1293         * valops.c: Use C++ exception handling.
1294         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1295         handling.
1296         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1297         * typeprint.c: Use C++ exception handling.
1298         * tui/tui.c: Use C++ exception handling.
1299         * tracefile-tfile.c: Use C++ exception handling.
1300         * top.c: Use C++ exception handling.
1301         * thread.c: Use C++ exception handling.
1302         * target.c: Use C++ exception handling.
1303         * symmisc.c: Use C++ exception handling.
1304         * symfile-mem.c: Use C++ exception handling.
1305         * stack.c: Use C++ exception handling.
1306         * sparc64-linux-tdep.c: Use C++ exception handling.
1307         * solib.c: Use C++ exception handling.
1308         * solib-svr4.c: Use C++ exception handling.
1309         * solib-spu.c: Use C++ exception handling.
1310         * solib-frv.c: Use C++ exception handling.
1311         * solib-dsbt.c: Use C++ exception handling.
1312         * selftest-arch.c: Use C++ exception handling.
1313         * s390-tdep.c: Use C++ exception handling.
1314         * rust-lang.c: Use C++ exception handling.
1315         * rust-exp.y: Use C++ exception handling.
1316         * rs6000-tdep.c: Use C++ exception handling.
1317         * rs6000-aix-tdep.c: Use C++ exception handling.
1318         * riscv-tdep.c: Use C++ exception handling.
1319         * remote.c: Use C++ exception handling.
1320         * remote-fileio.c: Use C++ exception handling.
1321         * record-full.c: Use C++ exception handling.
1322         * record-btrace.c: Use C++ exception handling.
1323         * python/python.c: Use C++ exception handling.
1324         * python/py-value.c: Use C++ exception handling.
1325         * python/py-utils.c: Use C++ exception handling.
1326         * python/py-unwind.c: Use C++ exception handling.
1327         * python/py-type.c: Use C++ exception handling.
1328         * python/py-symbol.c: Use C++ exception handling.
1329         * python/py-record.c: Use C++ exception handling.
1330         * python/py-record-btrace.c: Use C++ exception handling.
1331         * python/py-progspace.c: Use C++ exception handling.
1332         * python/py-prettyprint.c: Use C++ exception handling.
1333         * python/py-param.c: Use C++ exception handling.
1334         * python/py-objfile.c: Use C++ exception handling.
1335         * python/py-linetable.c: Use C++ exception handling.
1336         * python/py-lazy-string.c: Use C++ exception handling.
1337         * python/py-infthread.c: Use C++ exception handling.
1338         * python/py-inferior.c: Use C++ exception handling.
1339         * python/py-gdb-readline.c: Use C++ exception handling.
1340         * python/py-framefilter.c: Use C++ exception handling.
1341         * python/py-frame.c: Use C++ exception handling.
1342         * python/py-finishbreakpoint.c: Use C++ exception handling.
1343         * python/py-cmd.c: Use C++ exception handling.
1344         * python/py-breakpoint.c: Use C++ exception handling.
1345         * python/py-arch.c: Use C++ exception handling.
1346         * printcmd.c: Use C++ exception handling.
1347         * ppc-linux-tdep.c: Use C++ exception handling.
1348         * parse.c: Use C++ exception handling.
1349         * p-valprint.c: Use C++ exception handling.
1350         * objc-lang.c: Use C++ exception handling.
1351         * mi/mi-main.c: Use C++ exception handling.
1352         * mi/mi-interp.c: Use C++ exception handling.
1353         * mi/mi-cmd-stack.c: Use C++ exception handling.
1354         * mi/mi-cmd-break.c: Use C++ exception handling.
1355         * main.c: Use C++ exception handling.
1356         * linux-thread-db.c: Use C++ exception handling.
1357         * linux-tdep.c: Use C++ exception handling.
1358         * linux-nat.c: Use C++ exception handling.
1359         * linux-fork.c: Use C++ exception handling.
1360         * linespec.c: Use C++ exception handling.
1361         * language.c: Use C++ exception handling.
1362         * jit.c: Use C++ exception handling.
1363         * infrun.c: Use C++ exception handling.
1364         * infcmd.c: Use C++ exception handling.
1365         * infcall.c: Use C++ exception handling.
1366         * inf-loop.c: Use C++ exception handling.
1367         * i386-tdep.c: Use C++ exception handling.
1368         * i386-linux-tdep.c: Use C++ exception handling.
1369         * guile/scm-value.c: Use C++ exception handling.
1370         * guile/scm-type.c: Use C++ exception handling.
1371         * guile/scm-symtab.c: Use C++ exception handling.
1372         * guile/scm-symbol.c: Use C++ exception handling.
1373         * guile/scm-pretty-print.c: Use C++ exception handling.
1374         * guile/scm-ports.c: Use C++ exception handling.
1375         * guile/scm-param.c: Use C++ exception handling.
1376         * guile/scm-math.c: Use C++ exception handling.
1377         * guile/scm-lazy-string.c: Use C++ exception handling.
1378         * guile/scm-frame.c: Use C++ exception handling.
1379         * guile/scm-disasm.c: Use C++ exception handling.
1380         * guile/scm-cmd.c: Use C++ exception handling.
1381         * guile/scm-breakpoint.c: Use C++ exception handling.
1382         * guile/scm-block.c: Use C++ exception handling.
1383         * guile/guile-internal.h: Use C++ exception handling.
1384         * gnu-v3-abi.c: Use C++ exception handling.
1385         * gdbtypes.c: Use C++ exception handling.
1386         * frame.c: Use C++ exception handling.
1387         * frame-unwind.c: Use C++ exception handling.
1388         * fbsd-tdep.c: Use C++ exception handling.
1389         * f-valprint.c: Use C++ exception handling.
1390         * exec.c: Use C++ exception handling.
1391         * event-top.c: Use C++ exception handling.
1392         * event-loop.c: Use C++ exception handling.
1393         * eval.c: Use C++ exception handling.
1394         * dwarf2read.c: Use C++ exception handling.
1395         * dwarf2loc.c: Use C++ exception handling.
1396         * dwarf2-frame.c: Use C++ exception handling.
1397         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1398         * dwarf-index-write.c: Use C++ exception handling.
1399         * dwarf-index-cache.c: Use C++ exception handling.
1400         * dtrace-probe.c: Use C++ exception handling.
1401         * disasm-selftests.c: Use C++ exception handling.
1402         * darwin-nat.c: Use C++ exception handling.
1403         * cp-valprint.c: Use C++ exception handling.
1404         * cp-support.c: Use C++ exception handling.
1405         * cp-abi.c: Use C++ exception handling.
1406         * corelow.c: Use C++ exception handling.
1407         * completer.c: Use C++ exception handling.
1408         * compile/compile-object-run.c: Use C++ exception handling.
1409         * compile/compile-object-load.c: Use C++ exception handling.
1410         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1411         * compile/compile-c-symbols.c: Use C++ exception handling.
1412         * common/selftest.c: Use C++ exception handling.
1413         * common/new-op.c: Use C++ exception handling.
1414         * cli/cli-script.c: Use C++ exception handling.
1415         * cli/cli-interp.c: Use C++ exception handling.
1416         * cli/cli-cmds.c: Use C++ exception handling.
1417         * c-varobj.c: Use C++ exception handling.
1418         * btrace.c: Use C++ exception handling.
1419         * breakpoint.c: Use C++ exception handling.
1420         * break-catch-throw.c: Use C++ exception handling.
1421         * arch-utils.c: Use C++ exception handling.
1422         * amd64-tdep.c: Use C++ exception handling.
1423         * ada-valprint.c: Use C++ exception handling.
1424         * ada-typeprint.c: Use C++ exception handling.
1425         * ada-lang.c: Use C++ exception handling.
1426         * aarch64-tdep.c: Use C++ exception handling.
1427
1428 2019-04-08  Tom Tromey  <tom@tromey.com>
1429
1430         * xml-support.c (gdb_xml_parser::parse): Update.
1431         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1432         * value.c (show_convenience): Update.
1433         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1434         (test_parse_flags_qcs): Update.
1435         * thread.c (thr_try_catch_cmd): Update.
1436         * target.c (target_translate_tls_address): Update.
1437         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1438         (info_frame_command_core, frame_apply_command_count): Update.
1439         * rust-exp.y (rust_lex_exception_test): Update.
1440         * riscv-tdep.c (riscv_print_one_register_info): Update.
1441         * remote.c (remote_target::enable_btrace): Update.
1442         * record-btrace.c (record_btrace_enable_warn): Update.
1443         * python/py-utils.c (gdbpy_convert_exception): Update.
1444         * printcmd.c (do_one_display, print_variable_and_value): Update.
1445         * mi/mi-main.c (mi_print_exception): Update.
1446         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1447         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1448         * linux-nat.c (linux_nat_target::attach): Update.
1449         * linux-fork.c (class scoped_switch_fork_info): Update.
1450         * infrun.c (displaced_step_prepare): Update.
1451         * infcall.c (call_function_by_hand_dummy): Update.
1452         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1453         * gnu-v3-abi.c (print_one_vtable): Update.
1454         * frame.c (get_prev_frame_always): Update.
1455         * f-valprint.c (info_common_command_for_block): Update.
1456         * exec.c (try_open_exec_file): Update.
1457         * exceptions.c (print_exception, exception_print)
1458         (exception_fprintf, exception_print_same): Update.
1459         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1460         * dwarf-index-cache.c (index_cache::store)
1461         (index_cache::lookup_gdb_index): Update.
1462         * darwin-nat.c (maybe_cache_shell): Update.
1463         * cp-valprint.c (cp_print_value_fields): Update.
1464         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1465         (gcc_cplus_symbol_address): Update.
1466         * compile/compile-c-symbols.c (gcc_convert_symbol)
1467         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1468         * common/selftest.c: Update.
1469         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1470         a std::string.
1471         (exception_try_scope_entry, exception_try_scope_exit): Don't
1472         declare.
1473         (struct exception_try_scope): Remove.
1474         (TRY): Don't use exception_try_scope.
1475         (struct gdb_exception): Add constructor, operator=.
1476         <what>: New method.
1477         (struct gdb_exception_RETURN_MASK_ALL)
1478         (struct gdb_exception_RETURN_MASK_ERROR)
1479         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1480         (struct gdb_quit_bad_alloc): Update.
1481         * common/common-exceptions.c (exception_none): Change
1482         initializer.
1483         (struct catcher) <state, exception>: Initialize inline.
1484         <prev>: Remove member.
1485         (current_catcher): Remove.
1486         (catchers): New global.
1487         (exceptions_state_mc_init): Simplify.
1488         (catcher_pop): Remove.
1489         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1490         (try_scope_depth, exception_try_scope_entry)
1491         (exception_try_scope_exit): Remove.
1492         (throw_exception_sjlj): Update.
1493         (exception_messages, exception_messages_size): Remove.
1494         (throw_it): Simplify.
1495         (gdb_exception_sliced_copy): Remove.
1496         (throw_exception_cxx): Update.
1497         * cli/cli-script.c (script_from_file): Update.
1498         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1499         Update.
1500         * ada-valprint.c (ada_val_print): Update.
1501         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1502         (create_excep_cond_exprs): Update.
1503
1504 2019-04-08  Tom Tromey  <tom@tromey.com>
1505
1506         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1507         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1508         (TRY, CATCH, END_CATCH): Remove some definitions.
1509         * common/common-exceptions.c: Don't use GDB_XCPT.
1510         (catcher_list_size): Remove.
1511         (throw_exception, throw_it): Simplify.
1512
1513 2019-04-05  Tom Tromey  <tom@tromey.com>
1514
1515         Revert the header-sorting patch.
1516         * ft32-tdep.c: Revert.
1517         * frv-tdep.c: Revert.
1518         * frv-linux-tdep.c: Revert.
1519         * frame.c: Revert.
1520         * frame-unwind.c: Revert.
1521         * frame-base.c: Revert.
1522         * fork-child.c: Revert.
1523         * findvar.c: Revert.
1524         * findcmd.c: Revert.
1525         * filesystem.c: Revert.
1526         * filename-seen-cache.h: Revert.
1527         * filename-seen-cache.c: Revert.
1528         * fbsd-tdep.c: Revert.
1529         * fbsd-nat.h: Revert.
1530         * fbsd-nat.c: Revert.
1531         * f-valprint.c: Revert.
1532         * f-typeprint.c: Revert.
1533         * f-lang.c: Revert.
1534         * extension.h: Revert.
1535         * extension.c: Revert.
1536         * extension-priv.h: Revert.
1537         * expprint.c: Revert.
1538         * exec.h: Revert.
1539         * exec.c: Revert.
1540         * exceptions.c: Revert.
1541         * event-top.c: Revert.
1542         * event-loop.c: Revert.
1543         * eval.c: Revert.
1544         * elfread.c: Revert.
1545         * dwarf2read.h: Revert.
1546         * dwarf2read.c: Revert.
1547         * dwarf2loc.c: Revert.
1548         * dwarf2expr.h: Revert.
1549         * dwarf2expr.c: Revert.
1550         * dwarf2-frame.c: Revert.
1551         * dwarf2-frame-tailcall.c: Revert.
1552         * dwarf-index-write.h: Revert.
1553         * dwarf-index-write.c: Revert.
1554         * dwarf-index-common.c: Revert.
1555         * dwarf-index-cache.h: Revert.
1556         * dwarf-index-cache.c: Revert.
1557         * dummy-frame.c: Revert.
1558         * dtrace-probe.c: Revert.
1559         * disasm.h: Revert.
1560         * disasm.c: Revert.
1561         * disasm-selftests.c: Revert.
1562         * dictionary.c: Revert.
1563         * dicos-tdep.c: Revert.
1564         * demangle.c: Revert.
1565         * dcache.h: Revert.
1566         * dcache.c: Revert.
1567         * darwin-nat.h: Revert.
1568         * darwin-nat.c: Revert.
1569         * darwin-nat-info.c: Revert.
1570         * d-valprint.c: Revert.
1571         * d-namespace.c: Revert.
1572         * d-lang.c: Revert.
1573         * ctf.c: Revert.
1574         * csky-tdep.c: Revert.
1575         * csky-linux-tdep.c: Revert.
1576         * cris-tdep.c: Revert.
1577         * cris-linux-tdep.c: Revert.
1578         * cp-valprint.c: Revert.
1579         * cp-support.c: Revert.
1580         * cp-namespace.c: Revert.
1581         * cp-abi.c: Revert.
1582         * corelow.c: Revert.
1583         * corefile.c: Revert.
1584         * continuations.c: Revert.
1585         * completer.h: Revert.
1586         * completer.c: Revert.
1587         * complaints.c: Revert.
1588         * coffread.c: Revert.
1589         * coff-pe-read.c: Revert.
1590         * cli-out.h: Revert.
1591         * cli-out.c: Revert.
1592         * charset.c: Revert.
1593         * c-varobj.c: Revert.
1594         * c-valprint.c: Revert.
1595         * c-typeprint.c: Revert.
1596         * c-lang.c: Revert.
1597         * buildsym.c: Revert.
1598         * buildsym-legacy.c: Revert.
1599         * build-id.h: Revert.
1600         * build-id.c: Revert.
1601         * btrace.c: Revert.
1602         * bsd-uthread.c: Revert.
1603         * breakpoint.h: Revert.
1604         * breakpoint.c: Revert.
1605         * break-catch-throw.c: Revert.
1606         * break-catch-syscall.c: Revert.
1607         * break-catch-sig.c: Revert.
1608         * blockframe.c: Revert.
1609         * block.c: Revert.
1610         * bfin-tdep.c: Revert.
1611         * bfin-linux-tdep.c: Revert.
1612         * bfd-target.c: Revert.
1613         * bcache.c: Revert.
1614         * ax-general.c: Revert.
1615         * ax-gdb.h: Revert.
1616         * ax-gdb.c: Revert.
1617         * avr-tdep.c: Revert.
1618         * auxv.c: Revert.
1619         * auto-load.c: Revert.
1620         * arm-wince-tdep.c: Revert.
1621         * arm-tdep.c: Revert.
1622         * arm-symbian-tdep.c: Revert.
1623         * arm-pikeos-tdep.c: Revert.
1624         * arm-obsd-tdep.c: Revert.
1625         * arm-nbsd-tdep.c: Revert.
1626         * arm-nbsd-nat.c: Revert.
1627         * arm-linux-tdep.c: Revert.
1628         * arm-linux-nat.c: Revert.
1629         * arm-fbsd-tdep.c: Revert.
1630         * arm-fbsd-nat.c: Revert.
1631         * arm-bsd-tdep.c: Revert.
1632         * arch-utils.c: Revert.
1633         * arc-tdep.c: Revert.
1634         * arc-newlib-tdep.c: Revert.
1635         * annotate.h: Revert.
1636         * annotate.c: Revert.
1637         * amd64-windows-tdep.c: Revert.
1638         * amd64-windows-nat.c: Revert.
1639         * amd64-tdep.c: Revert.
1640         * amd64-sol2-tdep.c: Revert.
1641         * amd64-obsd-tdep.c: Revert.
1642         * amd64-obsd-nat.c: Revert.
1643         * amd64-nbsd-tdep.c: Revert.
1644         * amd64-nbsd-nat.c: Revert.
1645         * amd64-nat.c: Revert.
1646         * amd64-linux-tdep.c: Revert.
1647         * amd64-linux-nat.c: Revert.
1648         * amd64-fbsd-tdep.c: Revert.
1649         * amd64-fbsd-nat.c: Revert.
1650         * amd64-dicos-tdep.c: Revert.
1651         * amd64-darwin-tdep.c: Revert.
1652         * amd64-bsd-nat.c: Revert.
1653         * alpha-tdep.c: Revert.
1654         * alpha-obsd-tdep.c: Revert.
1655         * alpha-nbsd-tdep.c: Revert.
1656         * alpha-mdebug-tdep.c: Revert.
1657         * alpha-linux-tdep.c: Revert.
1658         * alpha-linux-nat.c: Revert.
1659         * alpha-bsd-tdep.c: Revert.
1660         * alpha-bsd-nat.c: Revert.
1661         * aix-thread.c: Revert.
1662         * agent.c: Revert.
1663         * addrmap.c: Revert.
1664         * ada-varobj.c: Revert.
1665         * ada-valprint.c: Revert.
1666         * ada-typeprint.c: Revert.
1667         * ada-tasks.c: Revert.
1668         * ada-lang.c: Revert.
1669         * aarch64-tdep.c: Revert.
1670         * aarch64-ravenscar-thread.c: Revert.
1671         * aarch64-newlib-tdep.c: Revert.
1672         * aarch64-linux-tdep.c: Revert.
1673         * aarch64-linux-nat.c: Revert.
1674         * aarch64-fbsd-tdep.c: Revert.
1675         * aarch64-fbsd-nat.c: Revert.
1676         * aarch32-linux-nat.c: Revert.
1677
1678 2019-04-05  Tom Tromey  <tom@tromey.com>
1679
1680         * ft32-tdep.c: Sort headers.
1681         * frv-tdep.c: Sort headers.
1682         * frv-linux-tdep.c: Sort headers.
1683         * frame.c: Sort headers.
1684         * frame-unwind.c: Sort headers.
1685         * frame-base.c: Sort headers.
1686         * fork-child.c: Sort headers.
1687         * findvar.c: Sort headers.
1688         * findcmd.c: Sort headers.
1689         * filesystem.c: Sort headers.
1690         * filename-seen-cache.h: Sort headers.
1691         * filename-seen-cache.c: Sort headers.
1692         * fbsd-tdep.c: Sort headers.
1693         * fbsd-nat.h: Sort headers.
1694         * fbsd-nat.c: Sort headers.
1695         * f-valprint.c: Sort headers.
1696         * f-typeprint.c: Sort headers.
1697         * f-lang.c: Sort headers.
1698         * extension.h: Sort headers.
1699         * extension.c: Sort headers.
1700         * extension-priv.h: Sort headers.
1701         * expprint.c: Sort headers.
1702         * exec.h: Sort headers.
1703         * exec.c: Sort headers.
1704         * exceptions.c: Sort headers.
1705         * event-top.c: Sort headers.
1706         * event-loop.c: Sort headers.
1707         * eval.c: Sort headers.
1708         * elfread.c: Sort headers.
1709         * dwarf2read.h: Sort headers.
1710         * dwarf2read.c: Sort headers.
1711         * dwarf2loc.c: Sort headers.
1712         * dwarf2expr.h: Sort headers.
1713         * dwarf2expr.c: Sort headers.
1714         * dwarf2-frame.c: Sort headers.
1715         * dwarf2-frame-tailcall.c: Sort headers.
1716         * dwarf-index-write.h: Sort headers.
1717         * dwarf-index-write.c: Sort headers.
1718         * dwarf-index-common.c: Sort headers.
1719         * dwarf-index-cache.h: Sort headers.
1720         * dwarf-index-cache.c: Sort headers.
1721         * dummy-frame.c: Sort headers.
1722         * dtrace-probe.c: Sort headers.
1723         * disasm.h: Sort headers.
1724         * disasm.c: Sort headers.
1725         * disasm-selftests.c: Sort headers.
1726         * dictionary.c: Sort headers.
1727         * dicos-tdep.c: Sort headers.
1728         * demangle.c: Sort headers.
1729         * dcache.h: Sort headers.
1730         * dcache.c: Sort headers.
1731         * darwin-nat.h: Sort headers.
1732         * darwin-nat.c: Sort headers.
1733         * darwin-nat-info.c: Sort headers.
1734         * d-valprint.c: Sort headers.
1735         * d-namespace.c: Sort headers.
1736         * d-lang.c: Sort headers.
1737         * ctf.c: Sort headers.
1738         * csky-tdep.c: Sort headers.
1739         * csky-linux-tdep.c: Sort headers.
1740         * cris-tdep.c: Sort headers.
1741         * cris-linux-tdep.c: Sort headers.
1742         * cp-valprint.c: Sort headers.
1743         * cp-support.c: Sort headers.
1744         * cp-namespace.c: Sort headers.
1745         * cp-abi.c: Sort headers.
1746         * corelow.c: Sort headers.
1747         * corefile.c: Sort headers.
1748         * continuations.c: Sort headers.
1749         * completer.h: Sort headers.
1750         * completer.c: Sort headers.
1751         * complaints.c: Sort headers.
1752         * coffread.c: Sort headers.
1753         * coff-pe-read.c: Sort headers.
1754         * cli-out.h: Sort headers.
1755         * cli-out.c: Sort headers.
1756         * charset.c: Sort headers.
1757         * c-varobj.c: Sort headers.
1758         * c-valprint.c: Sort headers.
1759         * c-typeprint.c: Sort headers.
1760         * c-lang.c: Sort headers.
1761         * buildsym.c: Sort headers.
1762         * buildsym-legacy.c: Sort headers.
1763         * build-id.h: Sort headers.
1764         * build-id.c: Sort headers.
1765         * btrace.c: Sort headers.
1766         * bsd-uthread.c: Sort headers.
1767         * breakpoint.h: Sort headers.
1768         * breakpoint.c: Sort headers.
1769         * break-catch-throw.c: Sort headers.
1770         * break-catch-syscall.c: Sort headers.
1771         * break-catch-sig.c: Sort headers.
1772         * blockframe.c: Sort headers.
1773         * block.c: Sort headers.
1774         * bfin-tdep.c: Sort headers.
1775         * bfin-linux-tdep.c: Sort headers.
1776         * bfd-target.c: Sort headers.
1777         * bcache.c: Sort headers.
1778         * ax-general.c: Sort headers.
1779         * ax-gdb.h: Sort headers.
1780         * ax-gdb.c: Sort headers.
1781         * avr-tdep.c: Sort headers.
1782         * auxv.c: Sort headers.
1783         * auto-load.c: Sort headers.
1784         * arm-wince-tdep.c: Sort headers.
1785         * arm-tdep.c: Sort headers.
1786         * arm-symbian-tdep.c: Sort headers.
1787         * arm-pikeos-tdep.c: Sort headers.
1788         * arm-obsd-tdep.c: Sort headers.
1789         * arm-nbsd-tdep.c: Sort headers.
1790         * arm-nbsd-nat.c: Sort headers.
1791         * arm-linux-tdep.c: Sort headers.
1792         * arm-linux-nat.c: Sort headers.
1793         * arm-fbsd-tdep.c: Sort headers.
1794         * arm-fbsd-nat.c: Sort headers.
1795         * arm-bsd-tdep.c: Sort headers.
1796         * arch-utils.c: Sort headers.
1797         * arc-tdep.c: Sort headers.
1798         * arc-newlib-tdep.c: Sort headers.
1799         * annotate.h: Sort headers.
1800         * annotate.c: Sort headers.
1801         * amd64-windows-tdep.c: Sort headers.
1802         * amd64-windows-nat.c: Sort headers.
1803         * amd64-tdep.c: Sort headers.
1804         * amd64-sol2-tdep.c: Sort headers.
1805         * amd64-obsd-tdep.c: Sort headers.
1806         * amd64-obsd-nat.c: Sort headers.
1807         * amd64-nbsd-tdep.c: Sort headers.
1808         * amd64-nbsd-nat.c: Sort headers.
1809         * amd64-nat.c: Sort headers.
1810         * amd64-linux-tdep.c: Sort headers.
1811         * amd64-linux-nat.c: Sort headers.
1812         * amd64-fbsd-tdep.c: Sort headers.
1813         * amd64-fbsd-nat.c: Sort headers.
1814         * amd64-dicos-tdep.c: Sort headers.
1815         * amd64-darwin-tdep.c: Sort headers.
1816         * amd64-bsd-nat.c: Sort headers.
1817         * alpha-tdep.c: Sort headers.
1818         * alpha-obsd-tdep.c: Sort headers.
1819         * alpha-nbsd-tdep.c: Sort headers.
1820         * alpha-mdebug-tdep.c: Sort headers.
1821         * alpha-linux-tdep.c: Sort headers.
1822         * alpha-linux-nat.c: Sort headers.
1823         * alpha-bsd-tdep.c: Sort headers.
1824         * alpha-bsd-nat.c: Sort headers.
1825         * aix-thread.c: Sort headers.
1826         * agent.c: Sort headers.
1827         * addrmap.c: Sort headers.
1828         * ada-varobj.c: Sort headers.
1829         * ada-valprint.c: Sort headers.
1830         * ada-typeprint.c: Sort headers.
1831         * ada-tasks.c: Sort headers.
1832         * ada-lang.c: Sort headers.
1833         * aarch64-tdep.c: Sort headers.
1834         * aarch64-ravenscar-thread.c: Sort headers.
1835         * aarch64-newlib-tdep.c: Sort headers.
1836         * aarch64-linux-tdep.c: Sort headers.
1837         * aarch64-linux-nat.c: Sort headers.
1838         * aarch64-fbsd-tdep.c: Sort headers.
1839         * aarch64-fbsd-nat.c: Sort headers.
1840         * aarch32-linux-nat.c: Sort headers.
1841
1842 2019-04-04  Tom Tromey  <tom@tromey.com>
1843
1844         * varobj.c (varobj_create): Update.
1845         * rust-exp.y (struct rust_parser) <update_innermost_block,
1846         lookup_symbol>: New methods.
1847         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1848         Rename.
1849         (rust_parser::rust_lookup_type)
1850         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1851         * printcmd.c (display_command, do_one_display): Update.
1852         * parser-defs.h (struct parser_state) <parser_state>: Add
1853         "tracker" parameter.
1854         (block_tracker): New member.
1855         (class innermost_block_tracker) <innermost_block_tracker>: Add
1856         "types" parameter.
1857         <reset>: Remove method.
1858         (innermost_block): Don't declare.
1859         (null_post_parser): Update.
1860         * parse.c (innermost_block): Remove global.
1861         (write_dollar_variable): Update.
1862         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1863         Remove "tracker_types" parameter.
1864         (parse_expression): Add "tracker" parameter.
1865         (parse_expression_for_completion): Update.
1866         (null_post_parser): Add "tracker" parameter.
1867         * p-exp.y: Update rules.
1868         * m2-exp.y: Update rules.
1869         * language.h (struct language_defn) <la_post_parser>: Add
1870         "tracker" parameter.
1871         * go-exp.y: Update rules.
1872         * f-exp.y: Update rules.
1873         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1874         parameter.
1875         * d-exp.y: Update rules.
1876         * c-exp.y: Update rules.
1877         * breakpoint.c (set_breakpoint_condition): Create an
1878         innermost_block_tracker.
1879         (watch_command_1): Likewise.
1880         * ada-lang.c (resolve): Add "tracker" parameter.
1881         (resolve_subexp): Likewise.
1882         * ada-exp.y (write_var_from_sym): Update.
1883
1884 2019-04-04  Tom Tromey  <tom@tromey.com>
1885
1886         * type-stack.h: New file.
1887         * type-stack.c: New file.
1888         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1889         type-stack.h.
1890         (insert_into_type_stack, insert_type, push_type, push_type_int)
1891         (insert_type_address_space, pop_type, pop_type_int)
1892         (pop_typelist, pop_type_stack, append_type_stack)
1893         (push_type_stack, get_type_stack, push_typelist)
1894         (follow_type_instance_flags, follow_types): Don't declare.
1895         * parse.c (type_stack): Remove global.
1896         (parse_exp_in_context): Update.
1897         (insert_into_type_stack, insert_type, push_type, push_type_int)
1898         (insert_type_address_space, pop_type, pop_type_int)
1899         (pop_typelist, pop_type_stack, append_type_stack)
1900         (push_type_stack, get_type_stack, push_typelist)
1901         (follow_type_instance_flags, follow_types): Remove (moved to
1902         type-stack.c).
1903         * f-exp.y (type_stack): New global.
1904         Update rules.
1905         (push_kind_type, f_parse): Update.
1906         * d-exp.y (type_stack): New global.
1907         Update rules.
1908         (d_parse): Update.
1909         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1910         Update rules.
1911         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1912         (HFILES_NO_SRCDIR): Add type-stack.h.
1913
1914 2019-04-04  Tom Tromey  <tom@tromey.com>
1915
1916         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1917         (rust_parser::convert_ast_to_expression, rust_parse)
1918         (rust_lex_test_completion, rust_lex_tests): Update.
1919         * parser-defs.h (struct expr_completion_state): New.
1920         (struct parser_state) <parser_state>: Add completion parameter.
1921         <mark_struct_expression, mark_completion_tag>: New methods.
1922         <parse_completion, m_completion_state>: New members.
1923         (prefixify_expression, null_post_parser): Update.
1924         (mark_struct_expression, mark_completion_tag): Don't declare.
1925         * parse.c (parse_completion, expout_last_struct)
1926         (expout_tag_completion_type, expout_completion_name): Remove
1927         globals.
1928         (parser_state::mark_struct_expression)
1929         (parser_state::mark_completion_tag): Now methods.
1930         (prefixify_expression): Add last_struct parameter.
1931         (prefixify_subexp): Likewise.
1932         (parse_exp_1): Update.
1933         (parse_exp_in_context): Add cstate parameter.  Update.
1934         (parse_expression_for_completion): Create an
1935         expr_completion_state.
1936         (null_post_parser): Add "completion" parameter.
1937         * p-exp.y: Update rules.
1938         (yylex): Update.
1939         * language.h (struct language_defn) <la_post_parser>: Add
1940         "completing" parameter.
1941         * go-exp.y: Update rules.
1942         (lex_one_token): Update.
1943         * expression.h (parse_completion): Don't declare.
1944         * d-exp.y: Update rules.
1945         (lex_one_token): Update rules.
1946         * c-exp.y: Update rules.
1947         (lex_one_token): Update.
1948         * ada-lang.c (resolve): Add "parse_completion" parameter.
1949         (resolve_subexp): Likewise.
1950         (ada_resolve_function): Likewise.
1951
1952 2019-04-04  Tom Tromey  <tom@tromey.com>
1953
1954         * parser-defs.h (struct parser_state) <start_arglist,
1955         end_arglist>: New methods.
1956         <arglist_len, m_funcall_chain>: New members.
1957         (arglist_len, start_arglist, end_arglist): Don't declare.
1958         * parse.c (arglist_len, funcall_chain): Remove global.
1959         (start_arglist, end_arglist): Remove functions.
1960         (parse_exp_in_context): Update.
1961         * p-exp.y: Update rules.
1962         * m2-exp.y: Update rules.
1963         * go-exp.y: Update rules.
1964         * f-exp.y: Update rules.
1965         * d-exp.y: Update rules.
1966         * c-exp.y: Update rules.
1967
1968 2019-04-04  Tom Tromey  <tom@tromey.com>
1969
1970         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1971         lex_operator, push_back>: New methods.
1972         Update all rules.
1973         (rust_parser::lex_hex, lex_escape): Rename and update.
1974         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1975         (rust_parser::lex_operator): Rename and update.
1976         (rust_parser::lex_number, rustyylex, rustyyerror)
1977         (rust_lex_test_init, rust_lex_test_sequence)
1978         (rust_lex_test_push_back, rust_lex_tests): Update.
1979         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1980         parameter.
1981         <lexptr, prev_lexptr>: New members.
1982         (lexptr, prev_lexptr): Don't declare.
1983         * parse.c (lexptr, prev_lexptr): Remove globals.
1984         (parse_exp_in_context): Update.
1985         * p-exp.y (yylex, yyerror): Update.
1986         * m2-exp.y (parse_number, yylex, yyerror): Update.
1987         * go-exp.y (lex_one_token, yyerror): Update.
1988         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1989         * d-exp.y (lex_one_token, yyerror): Update.
1990         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1991         (lex_one_token, yyerror): Update.
1992         * ada-lex.l (YY_INPUT): Update.
1993         (rewind_to_char): Update.
1994         * ada-exp.y (yyerror): Update.
1995
1996 2019-04-04  Tom Tromey  <tom@tromey.com>
1997
1998         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1999         * parser-defs.h (struct parser_state) <parser_state>: Add new
2000         parameter.
2001         <comma_terminates>: New member.
2002         (comma_terminates): Don't declare global.
2003         * parse.c (comma_terminates): Remove global.
2004         (parse_exp_in_context): Update.
2005         * p-exp.y (yylex): Update.
2006         * m2-exp.y (yylex): Update.
2007         * go-exp.y (lex_one_token): Update.
2008         * f-exp.y (yylex): Update.
2009         * d-exp.y (lex_one_token): Update.
2010         * c-exp.y (lex_one_token): Update.
2011         * ada-lex.l: Update.
2012
2013 2019-04-04  Tom Tromey  <tom@tromey.com>
2014
2015         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2016         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2017         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2018         * parser-defs.h (paren_depth): Don't declare.
2019         * parse.c (paren_depth): Remove global.
2020         (parse_exp_in_context): Update.
2021         * p-exp.y (paren_depth): New global.
2022         (pascal_parse): Initialize it.
2023         * m2-exp.y (paren_depth): New global.
2024         (m2_parse): Initialize it.
2025         * go-exp.y (paren_depth): New global.
2026         (go_parse): Initialize it.
2027         * f-exp.y (paren_depth): New global.
2028         (f_parse): Initialize it.
2029         * d-exp.y (paren_depth): New global.
2030         (d_parse): Initialize it.
2031         * c-exp.y (paren_depth): New global.
2032         (c_parse): Initialize it.
2033         * ada-lex.l (paren_depth): New global.
2034         (lexer_init): Initialize it.
2035
2036 2019-04-04  Tom Tromey  <tom@tromey.com>
2037
2038         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2039         (rust_parser::convert_ast_to_type)
2040         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2041         * parser-defs.h (struct parser_state) <parser_state>: Add
2042         parameters.  Initialize new members.
2043         <expression_context_block, expression_context_pc>: New members.
2044         * parse.c (expression_context_block, expression_context_pc):
2045         Remove globals.
2046         (parse_exp_in_context): Update.
2047         * p-exp.y: Update all rules.
2048         (yylex): Update.
2049         * m2-exp.y: Update all rules.
2050         (yylex): Update.
2051         * go-exp.y (yylex): Update.
2052         * f-exp.y (yylex): Update.
2053         * d-exp.y: Update all rules.
2054         (yylex): Update.
2055         * c-exp.y: Update all rules.
2056         (lex_one_token, classify_name, yylex, c_parse): Update.
2057         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2058
2059 2019-04-04  Tom Tromey  <tom@tromey.com>
2060
2061         * gdbarch.h, gdbarch.c: Rebuild.
2062         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2063         * stap-probe.h:
2064         (struct stap_parse_info): Replace "parser_state" with
2065         "expr_builder".
2066         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2067         (parser_state): New class.
2068         * parse.c (expr_builder): Rename.
2069         (expr_builder::release): Rename.
2070         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2071         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2072         (write_exp_elt_longcst, write_exp_elt_floatcst)
2073         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2074         (write_exp_string_vector, write_exp_bitstring)
2075         (write_exp_msymbol, mark_struct_expression)
2076         (write_dollar_variable)
2077         (insert_type_address_space, increase_expout_size): Replace
2078         "parser_state" with "expr_builder".
2079         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2080         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2081         "parser_state" with "expr_builder".
2082
2083 2019-04-04  Tom Tromey  <tom@tromey.com>
2084
2085         * rust-exp.y: Replace "parse_language" with method call.
2086         * p-exp.y:
2087         (yylex): Replace "parse_language" with method call.
2088         * m2-exp.y:
2089         (yylex): Replace "parse_language" with method call.
2090         * go-exp.y (classify_name): Replace "parse_language" with method
2091         call.
2092         * f-exp.y (yylex): Replace "parse_language" with method call.
2093         * d-exp.y (lex_one_token): Replace "parse_language" with method
2094         call.
2095         * c-exp.y:
2096         (lex_one_token, classify_name, yylex): Replace "parse_language"
2097         with method call.
2098         * ada-exp.y (find_primitive_type, type_char)
2099         (type_system_address): Replace "parse_language" with method call.
2100
2101 2019-04-04  Tom Tromey  <tom@tromey.com>
2102
2103         * rust-exp.y: Replace "parse_gdbarch" with method call.
2104         * parse.c (write_dollar_variable, insert_type_address_space):
2105         Replace "parse_gdbarch" with method call.
2106         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2107         call.
2108         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2109         call.
2110         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2111         "parse_gdbarch" with method call.
2112         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2113         with method call.
2114         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2115         "parse_gdbarch" with method call.
2116         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2117         "parse_gdbarch" with method call.
2118         * c-exp.y (parse_type, parse_number, classify_name): Replace
2119         "parse_gdbarch" with method call.
2120         * ada-lex.l: Replace "parse_gdbarch" with method call.
2121         * ada-exp.y (parse_type, find_primitive_type, type_char)
2122         (type_system_address): Replace "parse_gdbarch" with method call.
2123
2124 2019-04-04  Tom Tromey  <tom@tromey.com>
2125
2126         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2127         * stap-probe.c (stap_parse_argument): Update.
2128         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2129         initial_size parameter.
2130         * rust-exp.y (rust_lex_tests): Update.
2131         * parse.c (parser_state): Update.
2132         (parse_exp_in_context): Update.
2133         * parser-defs.h (struct parser_state) <parser_state>: Remove
2134         "initial_size" parameter.
2135
2136 2019-04-04  Tom Tromey  <tom@tromey.com>
2137
2138         * parser-defs.h (increase_expout_size): Don't declare.
2139         * parse.c (increase_expout_size): Now static.
2140
2141 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2142
2143         * gnu-nat.c (gnu_nat_target::wait): Fix
2144         target_waitstatus_to_string call.
2145
2146 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2147
2148         * eval.c (evaluate_subexp_standard): Handle internal functions
2149         during Fortran function call handling.
2150
2151 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2152
2153         * NEWS: Mention new internal functions.
2154         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2155         (read_base_type): Use dwarf2_init_complex_target_type.
2156         * value.c (creal_internal_fn): New function.
2157         (cimag_internal_fn): New function.
2158         (_initialize_values): Register new internal functions.
2159
2160 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2161
2162         * infrun.c (stop_all_threads): If debug_infrun, always
2163         trace the wait status after wait_one, using
2164         target_waitstatus_to_string and target_pid_to_str.
2165         (handle_inferior_event): Replace various trace of
2166         wait status kind by a single trace.
2167         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2168         wait status kind image by target_waitstatus_to_string.
2169         * target/waitstatus.c (target_waitstatus_to_string): Fix
2170         obsolete comment.
2171
2172 2019-04-01  Tom Tromey  <tromey@adacore.com>
2173
2174         PR symtab/23331:
2175         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2176
2177 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2178             Pedro Alves  <palves@redhat.com>
2179
2180         * top.c (quit_force): Call 'finalize_values'.
2181         * value.c (finalize_values): New function.
2182         * value.h (finalize_values): Declare.
2183
2184 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2185
2186         * NEWS: Announce $_gdb_major and $_gdb_minor.
2187
2188         * top.c (init_gdb_version_vars): New function.
2189         (gdb_init): Call init_gdb_version_vars.
2190
2191 2019-03-29  Tom Tromey  <tromey@adacore.com>
2192
2193         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2194         help text.  Remove dead code.
2195
2196 2019-03-29  Keith Seitz  <keiths@redhat.com>
2197
2198         From Siddhesh Poyarekar:
2199         * f-lang.h (f77_get_upperbound): Return LONGEST.
2200         (f77_get_lowerbound): Likewise.
2201         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2202         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2203         print them.
2204         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2205         plongest to format print it.
2206         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2207         (f77_get_upperbound): Likewise.
2208         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2209         LOWER_BOUND to LONGEST.
2210         (f77_create_arrayprint_offset_tbl): Likewise.
2211
2212 2019-03-29  Keith Seitz  <keiths@redhat.com>
2213
2214         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2215         %s/pulongest for TYPE_LENGTH instead of %d in format
2216         strings.
2217         * ada-typerint.c (ada_print_type): Likewise.
2218         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2219         * compile/compile-c-support.c (generate_register_struct): Likewise.
2220         * gdbtypes.c (recursive_dump_type): Likewise.
2221         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2222         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2223         instead of %d in format strings.
2224         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2225         to std::min to ULONGEST.
2226         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2227         instead of %d in format strings.
2228         * tracepoint.c (info_scope_command): Likewise.
2229         * typeprint.c (print_offset_data::update)
2230         (print_offset_data::finish): Likewise.
2231         * xtensa-tdep.c (xtensa_store_return_value)
2232         (xtensa_push_dummy_call): Likewise.
2233
2234 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2235
2236         * windows-nat.c (display_selector): Fixed format specifications
2237         for 64-bit Cygwin.
2238
2239 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2240
2241         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2242
2243 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2244
2245         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2246         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2247         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2248         (nios2_linux_init_abi): Install it.
2249
2250 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2251
2252         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2253
2254 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2255
2256         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2257
2258 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2259             Tom Tromey  <tromey@adacore.com>
2260
2261         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2262
2263 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2264
2265         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2266         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2267         method to compute the bounds of range types. Also print "[evaluated]"
2268         if the bounds' values come from a dynamic evaluation.
2269
2270 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2273         whitespace when pretty printing is on.
2274
2275 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2276
2277         * ppc-linux-nat.c: Add include.
2278
2279 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2280
2281         * NEWS: Mention AArch64 Pointer Authentication.
2282
2283 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2284
2285         * arm-linux-nat.c: Add include.
2286
2287 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2288
2289         * source-cache.c (source_cache::get_source_lines): Re-read
2290         fullname after calling open_source_file.
2291
2292 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2293
2294         * NEWS: Mention TLS support for FreeBSD.
2295
2296 2019-03-25  Tom Tromey  <tromey@adacore.com>
2297
2298         * minsyms.c (BUNCH_SIZE): Update comment.
2299         (~minimal_symbol_reader): Remove old comment.
2300         (compact_minimal_symbols): Update comment.
2301         (minimal_symbol_reader::install): Remove old comment.  Update
2302         other comments.
2303
2304 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2305
2306         * s390-linux-nat.c: Add include.
2307
2308 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2309
2310         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2311         Call linux_get_hwcap.
2312         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2313         Likewise.
2314         (aarch64_linux_get_hwcap): Remove function.
2315         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2316         declaration.
2317         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2318         linux_get_hwcap.
2319         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2320         * linux-tdep.c (linux_get_hwcap): Add function.
2321         (linux_get_hwcap2): Likewise.
2322         * linux-tdep.h (linux_get_hwcap): Add declaration.
2323         (linux_get_hwcap2): Likewise.
2324         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2325         (ppc_linux_get_hwcap2): Likewise.
2326         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2327         linux_get_hwcap.
2328         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2329         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2330         (ppc_linux_nat_target::read_description): Likewise.
2331         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2332         * s390-linux-nat.c: Likewise.
2333         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2334
2335 2019-03-24  Tom Tromey  <tom@tromey.com>
2336
2337         * ada-lang.c (standard_lookup): Simplify initialization.
2338         (ada_lookup_symbol_nonlocal): Simplify return.
2339         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2340         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2341         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2342         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2343         initialization.
2344         * solib.c (solib_global_lookup): Simplify.
2345         * symtab.c (null_block_symbol): Remove.
2346         (symbol_cache_lookup): Simplify returns.
2347         (lookup_language_this): Simplify returns.
2348         (lookup_symbol_aux): Simplify return.
2349         (lookup_local_symbol): Simplify returns.
2350         (lookup_global_symbol_from_objfile): Simplify return.
2351         (lookup_symbol_in_objfile_symtabs)
2352         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2353         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2354         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2355         * cp-namespace.c (cp_lookup_bare_symbol)
2356         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2357         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2358         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2359         (cp_lookup_symbol_via_imports): Simplify initialization.
2360         (find_symbol_in_baseclass): Likewise.
2361         * symtab.h (null_block_symbol): Remove.
2362         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2363         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2364         (d_lookup_symbol_module): Likewise.
2365         (find_symbol_in_baseclass): Simplify initialization.
2366
2367 2019-03-24  Tom Tromey  <tom@tromey.com>
2368
2369         * expression.h: Don't include symtab.h.
2370         (struct block): Forward declare.
2371
2372 2019-03-24  Tom Tromey  <tom@tromey.com>
2373
2374         * c-exp.y (typebase): Remove casts.
2375         * gdbtypes.c (lookup_unsigned_typename, )
2376         (lookup_signed_typename): Remove cast.
2377         * eval.c (parse_to_comma_and_eval): Remove cast.
2378         * parse.c (write_dollar_variable): Remove cast.
2379         * block.h (struct block) <superblock>: Now const.
2380         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2381         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2382         (map_block): Make "block" const.
2383         * symfile.h (struct quick_symbol_functions)
2384         <map_matching_symbols>: Constify block argument to "callback".
2385         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2386         const.
2387         (find_pc_sect_compunit_symtab): Make "b" const.
2388         (find_symbol_at_address): Likewise.
2389         (search_symbols): Likewise.
2390         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2391         (dw2_debug_names_lookup_symbol): Likewise.
2392         (dw2_map_matching_symbols): Update.
2393         * p-valprint.c (pascal_val_print): Remove "block".
2394         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2395         (aux_add_nonlocal_symbols): Make "block" const.
2396         (resolve_subexp): Remove cast.
2397         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2398         const.
2399         (iterate_over_file_blocks): Likewise.
2400         * f-exp.y (%union) <bval>: Remove.
2401         * coffread.c (patch_opaque_types): Make "b" const.
2402         * spu-tdep.c (spu_catch_start): Make "block" const.
2403         * c-valprint.c (print_unpacked_pointer): Remove "block".
2404         * symmisc.c (dump_symtab_1): Make "b" const.
2405         (block_depth): Make "block" const.
2406         * d-exp.y (%union) <bval>: Remove.
2407         * cp-support.h (cp_lookup_rtti_type): Update.
2408         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2409         * psymtab.c (psym_lookup_symbol): Make "block" const.
2410         (maintenance_check_psymtabs): Make "b" const.
2411         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2412         (enumerate_locals, enumerate_args): Update.
2413         * python/py-symtab.c (stpy_global_block): Make "block" const.
2414         (stpy_static_block): Likewise.
2415         * inline-frame.c (block_starting_point_at): Make "new_block"
2416         const.
2417         * block.c (find_block_in_blockvector): Make return type const.
2418         (blockvector_for_pc_sect): Make "b" const.
2419         (find_block_in_blockvector): Make "b" const.
2420
2421 2019-03-23  Tom Tromey  <tom@tromey.com>
2422
2423         * varobj.c (varobj_create): Update.
2424         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2425         * printcmd.c (display_command, do_one_display): Don't reset
2426         innermost_block.
2427         * parser-defs.h (enum innermost_block_tracker_type): Move to
2428         expression.h.
2429         (innermost_block): Update comment.
2430         * parse.c (parse_exp_1): Add tracker_types parameter.
2431         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2432         tracker_types parameter.  Reset innermost_block.
2433         (parse_exp_in_context): Remove.
2434         (parse_expression_for_completion): Update.
2435         * objfiles.c (~objfile): Don't reset expression_context_block or
2436         innermost_block.
2437         * expression.h (enum innermost_block_tracker_type): Move from
2438         parser-defs.h.
2439         (parse_exp_1): Add tracker_types parameter.
2440         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2441         reset innermost_block.
2442
2443 2019-03-23  Tom Tromey  <tom@tromey.com>
2444
2445         * objfiles.h: Include bcache.h.
2446
2447 2019-03-23  Tom Tromey  <tom@tromey.com>
2448
2449         * linespec.c (get_current_search_block): Use
2450         scoped_restore_current_language.
2451         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2452
2453 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2454             Jiong Wang  <jiong.wang@arm.com>
2455
2456         * aarch64-linux-tdep.c
2457         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2458         section.
2459         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2460
2461 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2462             Jiong Wang  <jiong.wang@arm.com>
2463
2464         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2465         instructions.
2466         (aarch64_analyze_prologue_test): Add PACIASP test.
2467         (aarch64_prologue_prev_register): Unmask PC value.
2468
2469 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2470             Jiong Wang  <jiong.wang@arm.com>
2471
2472         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2473         (aarch64_dwarf2_prev_register): Unmask PC value.
2474         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2475         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2476         DW_CFA_AARCH64_negate_ra_state.
2477         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2478
2479 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2480             Jiong Wang  <jiong.wang@arm.com>
2481
2482         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2483         registers.
2484         (aarch64_pseudo_register_name): Likewise.
2485         (aarch64_pseudo_register_type): Likewise.
2486         (aarch64_pseudo_register_reggroup_p): Likewise.
2487         (aarch64_gdbarch_init): Add pauth registers.
2488         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2489         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2490         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2491         (struct gdbarch_tdep): Add regnum for ra_state.
2492
2493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2494             Jiong Wang  <jiong.wang@arm.com>
2495
2496         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2497
2498 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2499             Jiong Wang  <jiong.wang@arm.com>
2500
2501         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2502         function.
2503         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2504         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2505         (aarch64_gdbarch_init): Add puth registers.
2506         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2507         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2508         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2509
2510 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2511             Jiong Wang  <jiong.wang@arm.com>
2512
2513         * aarch64-linux-nat.c
2514         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2515         * aarch64-linux-tdep.c
2516         (aarch64_linux_core_read_description): Likewise.
2517         (aarch64_linux_get_hwcap): New function.
2518         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2519         (aarch64_linux_get_hwcap): New declaration.
2520
2521 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2522             Jiong Wang  <jiong.wang@arm.com>
2523
2524         * aarch64-linux-nat.c
2525         (aarch64_linux_nat_target::read_description): Add pauth param.
2526         * aarch64-linux-tdep.c
2527         (aarch64_linux_core_read_description): Likewise.
2528         * aarch64-tdep.c (struct target_desc): Add in pauth.
2529         (aarch64_read_description): Add pauth param.
2530         (aarch64_gdbarch_init): Likewise.
2531         * aarch64-tdep.h (aarch64_read_description): Likewise.
2532         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2533         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2534         * features/Makefile: Add new files.
2535         * features/aarch64-pauth.c: New file.
2536         * features/aarch64-pauth.xml: New file.
2537
2538 2019-03-20  Tom Tromey  <tromey@adacore.com>
2539
2540         * infrun.c (handle_inferior_event): Rename from
2541         handle_inferior_event_1.  Create a scoped_value_mark.
2542         (handle_inferior_event): Remove.
2543
2544 2019-03-19  Tom Tromey  <tromey@adacore.com>
2545
2546         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2547         * infrun.h (print_stop_event): Add "displays" parameter.
2548         * infrun.c (print_stop_event): Add "displays" parameter.
2549
2550 2019-03-19  Pedro Alves  <palves@redhat.com>
2551
2552         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2553         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2554         to -1.  Fix TABs vs spaces.
2555         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2556         * tui/tui-out.h (tui_ui_out) Add intro comments.
2557         <m_line, m_start_of_line>: In-class initialize, and add describing
2558         comment.
2559
2560 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2561
2562         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2563         variable names.
2564         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2565
2566 2019-03-18  Pedro Alves  <palves@redhat.com>
2567             Eli Zaretskii <eliz@gnu.org>
2568
2569         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2570         m_line and m_start_of_line.
2571
2572 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2573
2574         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2575         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2576         it returns a newline.  This fixes a regression in TU mode, whereby
2577         the next line is output on the same screen line as the user input.
2578
2579 2019-03-18  Tom Tromey  <tromey@adacore.com>
2580
2581         * minsyms.c (minimal_symbol_reader::install): Remove call to
2582         obstack_blank.
2583
2584 2019-03-18  Pedro Alves  <palves@redhat.com>
2585
2586         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2587         New globals.
2588         (apply_style): New, factored out from ...
2589         (apply_ansi_escape): ... this.  Handle reverse video mode.
2590         (tui_set_reverse_mode): New function.
2591         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2592         * tui/tui-winsource.c (tui_show_source_line): Use
2593         tui_set_reverse_mode instead of setting A_STANDOUT.
2594         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2595         New setter methods.
2596
2597 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2598
2599         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2600         Handle tabs.
2601
2602 2019-03-18  Tom Tromey  <tromey@adacore.com>
2603
2604         * ada-lang.c (empty_array): Add "high" parameter.
2605         (ada_evaluate_subexp): Update.
2606
2607 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2608
2609         * unittests/string_view-selftests.c: Define
2610         _initialize_string_view_selftests unconditionally.
2611
2612 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2613
2614         PR gdb/24350
2615         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2616
2617 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2618
2619         PR gdb/24351
2620         * windows-nat.c (display_selector): Fix format specifiers.
2621
2622 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2623
2624         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2625         tui_refill_source_window instead of tui_refresh_win, to update the
2626         current execution line.  This fixes redisplay of the current line
2627         when stepping through the code with "next" or "step".
2628
2629 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2630
2631         * source-cache.c (source_cache::get_source_lines): Call
2632         find_source_lines to initialize s->nlines.  This fixes vertical
2633         scrolling of TUI source window when the DOWN arrow is pressed.
2634
2635 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2636
2637         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2638         linux-thread-db.c (_initialize_thread_db): Likewise.
2639
2640 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2641
2642         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2643         wclrtoeol in tui_show_source_line".  This reverts changes made in
2644         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2645
2646 2019-03-15  Tom Tromey  <tom@tromey.com>
2647
2648         * symtab.h (struct minimal_symbol): Derive from
2649         general_symbol_info.
2650         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2651         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2652         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2653         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2654         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2655         (MSYMBOL_SEARCH_NAME): Update.
2656         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2657         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2658         * minsyms.c (minimal_symbol_reader::record_full): Update.
2659
2660 2019-03-15  Tom Tromey  <tom@tromey.com>
2661
2662         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2663
2664 2019-03-15  Tom Tromey  <tom@tromey.com>
2665
2666         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2667         unique_xmalloc_ptr.
2668         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2669         Update.
2670         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2671         (build_minimal_symbol_hash_tables)
2672         (minimal_symbol_reader::install): Update.
2673
2674 2019-03-15  Tom Tromey  <tom@tromey.com>
2675
2676         * symtab.c (create_demangled_names_hash): Update.
2677         (symbol_set_names): Update.
2678         * objfiles.h (struct objfile_per_bfd_storage)
2679         <demangled_names_hash>: Now an htab_up.
2680         * objfiles.c (objfile_per_bfd_storage): Simplify.
2681
2682 2019-03-15  Tom Tromey  <tom@tromey.com>
2683
2684         * objfiles.h (struct objfile_per_bfd_storage): Declare
2685         destructor.
2686         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2687         New.
2688         (get_objfile_bfd_data): Use new.  Don't initialize
2689         language_of_main.
2690         (free_objfile_per_bfd_storage): Remove.
2691         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2692
2693 2019-03-15  Tom Tromey  <tom@tromey.com>
2694
2695         * symfile.c (reread_symbols): Update.
2696         * objfiles.c (objfile::objfile): Update.
2697         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2698         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2699         comment.
2700         (minimal_symbol_reader::install): Update.
2701         (terminate_minimal_symbol_table): Remove.
2702         * jit.c (jit_object_close_impl): Update.
2703
2704 2019-03-15  Tom Tromey  <tom@tromey.com>
2705
2706         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2707         initializations.
2708
2709 2019-03-15  Tom Tromey  <tom@tromey.com>
2710
2711         * objfiles.h (struct objfile_per_bfd_storage)
2712         <demangled_hash_languages>: Now a bitset.
2713         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2714         (lookup_minimal_symbol): Update.
2715
2716 2019-03-15  Tom Tromey  <tom@tromey.com>
2717
2718         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2719         Don't return the symbol.
2720         * coffread.c (record_minimal_symbol): Use record_full.
2721
2722 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2723
2724         The MS-Windows port of ncurses fails to switch to a color pair if
2725         one or both of the colors are the implicit default colors.  This
2726         change records the default colors when TUI is initialized, and
2727         then specifies them explicitly when a color pair uses the default
2728         colors.  This allows color styling in TUI mode on MS-Windows.
2729
2730         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2731         ncurses_norm_attr.
2732         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2733         colors in ncurses_norm_attr.
2734         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2735         "none", replace it with the default color recorded in
2736         ncurses_norm_attr.
2737
2738 2019-03-14  Tom Tromey  <tromey@adacore.com>
2739
2740         * source-cache.h (class source_cache) <get_source_lines>: Return
2741         std::string.
2742         * source-cache.c (source_cache::extract_lines): Handle case where
2743         first_pos==npos.  Return std::string.
2744         (source_cache::get_source_lines): Update.
2745
2746 2019-03-14  Tom Tromey  <tromey@adacore.com>
2747
2748         * NEWS: Add item for "style sources" commands.
2749         * source-cache.c (source_cache::get_source_lines): Check
2750         source_styling.
2751         * cli/cli-style.c (source_styling): New global.
2752         (_initialize_cli_style): Add "style sources" commands.
2753         (show_style_sources): New function.
2754         * cli/cli-style.h (source_styling): Declare.
2755
2756 2019-03-14  Pedro Alves  <palves@redhat.com>
2757             Tom Tromey  <tromey@adacore.com>
2758
2759         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2760         * tui/tui-winsource.c (tui_refill_source_window): New function,
2761         from...
2762         (tui_horizontal_source_scroll): ... here.  Move some logic.
2763         * cli/cli-style.c (set_style_enabled): Notify new observable.
2764         * tui/tui-hooks.c (tui_redisplay_source): New function.
2765         (tui_attach_detach_observers): Attach or detach
2766         tui_redisplay_source.
2767         * observable.h (source_styling_changed): New observable.
2768         * observable.c: Define source_styling_changed observable.
2769
2770 2019-03-13  Tom Tromey  <tromey@adacore.com>
2771
2772         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2773         (i386_gnu_nat_target::store_registers): Update.
2774         * target-debug.h (target_debug_print_std_string): New macro.
2775         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2776         * windows-tdep.c (display_one_tib): Update.
2777         * tui/tui-stack.c (tui_make_status_line): Update.
2778         * top.c (print_inferior_quit_action): Update.
2779         * thread.c (thr_try_catch_cmd): Update.
2780         (add_thread_with_info): Update.
2781         (thread_target_id_str): Update.
2782         (thr_try_catch_cmd): Update.
2783         (thread_command): Update.
2784         (thread_find_command): Update.
2785         * record-btrace.c (record_btrace_target::info_record)
2786         (record_btrace_resume_thread, record_btrace_target::resume)
2787         (record_btrace_cancel_resume, record_btrace_step_thread)
2788         (record_btrace_target::wait, record_btrace_target::wait)
2789         (record_btrace_target::wait, record_btrace_target::stop): Update.
2790         * progspace.c (print_program_space): Update.
2791         * process-stratum-target.c
2792         (process_stratum_target::thread_address_space): Update.
2793         * linux-fork.c (linux_fork_mourn_inferior)
2794         (detach_checkpoint_command, info_checkpoints_command)
2795         (linux_fork_context): Update.
2796         (linux_fork_detach): Update.
2797         (class scoped_switch_fork_info): Update.
2798         (delete_checkpoint_command): Update.
2799         * infrun.c (follow_fork_inferior): Update.
2800         (follow_fork_inferior): Update.
2801         (proceed_after_vfork_done): Update.
2802         (handle_vfork_child_exec_or_exit): Update.
2803         (follow_exec): Update.
2804         (displaced_step_prepare_throw): Update.
2805         (displaced_step_restore): Update.
2806         (start_step_over): Update.
2807         (resume_1): Update.
2808         (clear_proceed_status_thread): Update.
2809         (proceed): Update.
2810         (print_target_wait_results): Update.
2811         (do_target_wait): Update.
2812         (context_switch): Update.
2813         (stop_all_threads): Update.
2814         (restart_threads): Update.
2815         (finish_step_over): Update.
2816         (handle_signal_stop): Update.
2817         (switch_back_to_stepped_thread): Update.
2818         (keep_going_pass_signal): Update.
2819         (print_exited_reason): Update.
2820         (normal_stop): Update.
2821         * inferior.c (inferior_pid_to_str): Change return type.
2822         (print_selected_inferior): Update.
2823         (add_inferior): Update.
2824         (detach_inferior): Update.
2825         * dummy-frame.c (fprint_dummy_frames): Update.
2826         * dcache.c (dcache_info_1): Update.
2827         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2828         (btrace_fetch, btrace_clear): Update.
2829         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2830         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2831         type.
2832         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2833         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2834         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2835         * gdbarch.c, gdbarch.h: Rebuild.
2836         * gdbarch.sh (core_pid_to_str): Change return type.
2837         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2838         return type.
2839         (windows_nat_target::pid_to_str): Change return type.
2840         (windows_delete_thread): Update.
2841         (windows_nat_target::attach): Update.
2842         (windows_nat_target::files_info): Update.
2843         * target-delegates.c: Rebuild.
2844         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2845         return type.
2846         (sol_thread_target::pid_to_str): Change return type.
2847         * remote.c (class remote_target) <pid_to_str>: Change return
2848         type.
2849         (remote_target::pid_to_str): Change return type.
2850         (extended_remote_target::attach, remote_target::remote_stop_ns)
2851         (remote_target::remote_notif_remove_queued_reply)
2852         (remote_target::push_stop_reply, remote_target::disable_btrace):
2853         Update.
2854         (extended_remote_target::attach): Update.
2855         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2856         type.
2857         (gdbsim_target::pid_to_str): Change return type.
2858         * ravenscar-thread.c (struct ravenscar_thread_target)
2859         <pid_to_str>: Change return type.
2860         (ravenscar_thread_target::pid_to_str): Change return type.
2861         * procfs.c (class procfs_target) <pid_to_str>: Change return
2862         type.
2863         (procfs_target::pid_to_str): Change return type.
2864         (procfs_target::attach): Update.
2865         (procfs_target::detach): Update.
2866         (procfs_target::fetch_registers): Update.
2867         (procfs_target::store_registers): Update.
2868         (procfs_target::wait): Update.
2869         (procfs_target::files_info): Update.
2870         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2871         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2872         return type.
2873         (nto_procfs_target::pid_to_str): Change return type.
2874         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2875         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2876         return type.
2877         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2878         (exit_lwp): Update.
2879         (attach_proc_task_lwp_callback, get_detach_signal)
2880         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2881         (linux_nat_target::resume, wait_lwp, stop_callback)
2882         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2883         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2884         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2885         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2886         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2887         type.
2888         (inf_ptrace_target::attach): Update.
2889         (inf_ptrace_target::files_info): Update.
2890         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2891         type.
2892         (go32_nat_target::pid_to_str): Change return type.
2893         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2894         (gnu_nat_target::wait): Update.
2895         (gnu_nat_target::wait): Update.
2896         (gnu_nat_target::resume): Update.
2897         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2898         (fbsd_nat_target::wait): Update.
2899         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2900         type.
2901         (darwin_nat_target::attach): Update.
2902         * corelow.c (class core_target) <pid_to_str>: Change return type.
2903         (core_target::pid_to_str): Change return type.
2904         * target.c (normal_pid_to_str): Change return type.
2905         (default_pid_to_str): Likewise.
2906         (target_pid_to_str): Change return type.
2907         (target_translate_tls_address): Update.
2908         (target_announce_detach): Update.
2909         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2910         return type.
2911         (bsd_uthread_target::pid_to_str): Change return type.
2912         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2913         type.
2914         (bsd_kvm_target::pid_to_str): Change return type.
2915         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2916         return type.
2917         (aix_thread_target::pid_to_str): Change return type.
2918         * target.h (struct target_ops) <pid_to_str>: Change return type.
2919         (target_pid_to_str, normal_pid_to_str): Likewise.
2920         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2921         type.
2922         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2923         type.
2924         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2925         return type.
2926         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2927         type.
2928         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2929         type.
2930         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2931         return type.
2932
2933 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2934
2935         * NEWS: Mention that the new default MI version is 3.  Mention
2936         changes to the output of commands and events that deal with
2937         multi-location breakpoints.
2938         * breakpoint.c: Include "mi/mi-out.h".
2939         (print_one_breakpoint): Change output syntax if using MI version
2940         >= 3.
2941         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2942         New.
2943         (mi_multi_location_breakpoint_output_fixed): New.
2944         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2945         (mi_cmd_fix_multi_location_breakpoint_output): New.
2946         (mi_multi_location_breakpoint_output_fixed): New.
2947         * mi/mi-cmds.c (mi_cmds): Register command
2948         -fix-multi-location-breakpoint-output.
2949         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2950         interpreter "mi".
2951
2952 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2953
2954         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2955         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2956         instantiate mi_ui_out based on interpreter name.
2957         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2958         * mi/mi-main.c (mi_load_progress): Likewise.
2959
2960 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2961
2962         * NEWS: Combine separate "New targets" sections for 8.3.
2963
2964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2965
2966         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2967         (ppcfbsd_init_abi): Install gdbarch
2968         "fetch_tls_load_module_address" and "get_thread_local_address"
2969         methods.
2970
2971 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2972
2973         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2974         (riscv_fbsd_init_abi): Install gdbarch
2975         "fetch_tls_load_module_address" and "get_thread_local_address"
2976         methods.
2977
2978 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2979
2980         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2981         (i386fbsd_init_abi): Install gdbarch
2982         "fetch_tls_load_module_address" and "get_thread_local_address"
2983         methods.
2984
2985 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2986
2987         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2988         (amd64fbsd_init_abi): Install gdbarch
2989         "fetch_tls_load_module_address" and "get_thread_local_address"
2990         methods.
2991
2992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2993
2994         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2995         (struct fbsd_pspace_data): New type.
2996         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2997         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2998         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2999         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3000         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3001
3002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3003
3004         * gdbtypes.c (lookup_struct_elt): New function.
3005         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3006         * gdbtypes.h (struct struct_elt): New type.
3007         (lookup_struct_elt): New prototype.
3008
3009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3010
3011         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3012         remove disabled code block.
3013
3014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3015
3016         * gdbarch.sh (get_thread_local_address): New method.
3017         * gdbarch.h, gdbarch.c: Regenerate.
3018         * target.c (target_translate_tls_address): Use
3019         gdbarch_get_thread_local_address if present instead of
3020         target::get_thread_local_address.
3021
3022 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3023
3024         * target.h (target::get_thread_local_address): Update comment.
3025
3026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3027
3028         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3029         objfile->separate_debug_objfile_backlink if not NULL.
3030
3031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3032
3033         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3034         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3035         (amd64bsd_store_inferior_registers): Likewise.
3036         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3037         Enable segment base registers.
3038         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3039         PT_GETFSBASE and PT_GETGSBASE.
3040         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3041         PT_SETGSBASE.
3042         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3043         segment base registers.
3044         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3045
3046 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3047
3048         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3049         Update calls to i386_target_description to add 'segments'
3050         parameter.
3051         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3052         add segment base registers.
3053         * arch/i386.c (i386_create_target_description): Add 'segments'
3054         parameter to enable segment base registers.
3055         * arch/i386.h (i386_create_target_description): Likewise.
3056         * features/i386/32bit-segments.xml: New file.
3057         * features/i386/32bit-segments.c: Generate.
3058         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3059         call to i386_target_description to add 'segments' parameter.
3060         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3061         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3062         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3063         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3064         if feature is present.
3065         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3066         Add 'segments' parameter to call to i386_target_description.
3067         (i386_target_description): Add 'segments' parameter to enable
3068         segment base registers.
3069         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3070         to call to i386_target_description.
3071         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3072         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3073         Define I386_NUM_REGS.
3074         (i386_target_description): Add 'segments' parameter to enable
3075         segment base registers.
3076
3077 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3078
3079         PR/24325
3080         * source-cache.c: #undef open and close, to avoid unresolved
3081         externals during linking.
3082
3083 2019-03-12  Tom Tromey  <tromey@adacore.com>
3084
3085         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3086         const.  Add initializers.
3087         (_initialize_remote): Don't initialize ptid globals.
3088
3089 2019-03-12  Pedro Alves  <palves@redhat.com>
3090
3091         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3092
3093 2019-03-12  Pedro Alves  <palves@redhat.com>
3094
3095         * cp-name-parser.y (main): Remove unused 'len' variable.
3096
3097 2019-03-12  Tom Tromey  <tromey@adacore.com>
3098
3099         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3100         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3101
3102 2019-03-12  Tom Tromey  <tromey@adacore.com>
3103
3104         * linux-nat.c (iterate_over_lwps): Update.
3105         (stop_callback): Remove parameter.
3106         (stop_wait_callback, detach_callback, resume_set_callback)
3107         (select_singlestep_lwp_callback, set_ignore_sigint)
3108         (status_callback, resumed_callback, resume_clear_callback)
3109         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3110         data parameter.
3111         (linux_nat_target::detach, linux_nat_target::resume)
3112         (linux_stop_and_wait_all_lwps, select_event_lwp)
3113         (linux_nat_filter_event, linux_nat_wait_1)
3114         (linux_nat_target::kill, linux_nat_target::stop)
3115         (linux_nat_target::stop): Update.
3116         (linux_nat_resume_callback): Change type.
3117         (resume_stopped_resumed_lwps, count_events_callback)
3118         (select_event_lwp_callback): Likewise.
3119         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3120         * arm-linux-nat.c (struct update_registers_data): Remove.
3121         (update_registers_callback): Change type.
3122         (arm_linux_insert_hw_breakpoint1): Update.
3123         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3124         parameter.
3125         (x86_linux_dr_set_addr): Update.
3126         (x86_linux_dr_set_control): Update.
3127         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3128         (iterate_over_lwps): Use gdb::function_view.
3129         * nat/aarch64-linux-hw-point.c (struct
3130         aarch64_dr_update_callback_param): Remove.
3131         (debug_reg_change_callback): Change type.
3132         (aarch64_notify_debug_reg_change): Update.
3133         * s390-linux-nat.c (s390_refresh_per_info): Update.
3134
3135 2019-03-11  Tom Tromey  <tromey@adacore.com>
3136
3137         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3138         redundant assignment to "this_cu".
3139
3140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3141
3142         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3143
3144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3145
3146         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3147         from...
3148         (rank_one_type): ... this.
3149
3150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3151
3152         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3153         from...
3154         (rank_one_type): ... this.
3155
3156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3157
3158         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3159         from...
3160         (rank_one_type): ... this.
3161
3162 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3163
3164         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3165         from...
3166         (rank_one_type): ... this.
3167
3168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3169
3170         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3171         from...
3172         (rank_one_type): ... this.
3173
3174 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3175
3176         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3177         from...
3178         (rank_one_type): ... this.
3179
3180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3181
3182         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3183         from...
3184         (rank_one_type): ... this.
3185
3186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3187
3188         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3189         from...
3190         (rank_one_type): ... this.
3191
3192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3193
3194         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3195         from...
3196         (rank_one_type): ... this.
3197
3198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3199
3200         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3201         from...
3202         (rank_one_type): ... this.
3203
3204 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3205
3206         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3207         from...
3208         (rank_one_type): ... this.
3209
3210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3211
3212         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3213         from...
3214         (rank_one_type): ... this.
3215
3216 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3217
3218         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3219         inferior-events' shows the example events.
3220
3221 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3222
3223         Support styling on native MS-Windows console
3224
3225         PR/24315
3226         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3227         on MS-Windows if $TERM is not defined.
3228
3229         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3230
3231         * posix-hdep.c (gdb_console_fputs):
3232         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3233         functions.
3234         * ui-file.h (gdb_console_fputs): Add prototype.
3235
3236         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3237         back to fputs only if the former returns zero.
3238
3239 2019-03-07  Tom Tromey  <tom@tromey.com>
3240
3241         * symmisc.c (print_symbol_bcache_statistics): Update.
3242         (print_objfile_statistics): Update.
3243         * symfile.c (allocate_symtab): Update.
3244         * stabsread.c: Don't include bcache.h.
3245         * psymtab.h (struct psymbol_bcache): Don't declare.
3246         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3247         (psymbol_bcache_init, psymbol_bcache_free)
3248         (psymbol_bcache_get_bcache): Don't declare.
3249         * psymtab.c (struct psymbol_bcache): Remove.
3250         (psymtab_storage::psymtab_storage): Update.
3251         (psymtab_storage::~psymtab_storage): Update.
3252         (psymbol_bcache_init, psymbol_bcache_free)
3253         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3254         (add_psymbol_to_bcache): Update.
3255         (allocate_psymtab): Update.
3256         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3257         macro_cache>: No longer pointers.
3258         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3259         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3260         * macrotab.c (macro_bcache): Update.
3261         * macroexp.c: Don't include bcache.h.
3262         * gdbtypes.c (check_types_worklist): Update.
3263         (types_deeply_equal): Remove TRY/CATCH.  Update.
3264         * elfread.c (elf_symtab_read): Update.
3265         * dwarf2read.c: Don't include bcache.h.
3266         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3267         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3268         (print_bcache_statistics, bcache_memory_used): Don't declare.
3269         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3270         methods.  Rename all data members.
3271         * bcache.c (struct bcache): Move to bcache.h.
3272         (bcache::expand_hash_table): Rename from expand_hash_table.
3273         (bcache): Remove.
3274         (bcache::insert): Rename from bcache_full.
3275         (bcache::compare): Rename from bcache_compare.
3276         (bcache_xmalloc): Remove.
3277         (bcache::~bcache): Rename from bcache_xfree.
3278         (bcache::print_statistics): Rename from print_bcache_statistics.
3279         (bcache::memory_used): Rename from bcache_memory_used.
3280
3281 2019-03-07  Pedro Alves  <palves@redhat.com>
3282
3283         * infrun.c (normal_stop): Also check for
3284         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3285
3286 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3287
3288         * f-lang.c (value_from_host_double): Moved to...
3289         * value.c (value_from_host_double): ...here.
3290         * value.h (value_from_host_double): Declare.
3291         * guile/scm-math.c (vlscm_convert_typed_number): Use
3292         value_from_host_double.
3293         (vlscm_convert_number): Likewise.
3294         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3295         * python/py-value.c (convert_value_from_python): Likewise.
3296
3297 2019-03-06  Tom Tromey  <tom@tromey.com>
3298
3299         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3300
3301 2019-03-06  Tom Tromey  <tom@tromey.com>
3302
3303         * utils.h (free_current_contents): Don't declare.
3304         * utils.c (free_current_contents): Remove.
3305
3306 2019-03-06  Tom Tromey  <tom@tromey.com>
3307
3308         * top.c (quit_force): Update.
3309         * main.c (captured_command_loop): Update.
3310         * common/new-op.c (operator new): Update.
3311         * common/common-exceptions.c (struct catcher)
3312         <save_cleanup_chain>: Remove member.
3313         (exceptions_state_mc_init): Update.
3314         (exception_try_scope_entry): Return nullptr.
3315         (exception_try_scope_exit, exception_rethrow)
3316         (throw_exception_sjlj, throw_exception_cxx): Update.
3317         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3318         (all_cleanups, do_cleanups, discard_cleanups)
3319         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3320         (restore_cleanups, restore_final_cleanups): Don't declare.
3321         (do_final_cleanups): Remove parameter.
3322         * common/cleanups.c (cleanup_chain, make_cleanup)
3323         (make_cleanup_dtor, all_cleanups, do_cleanups)
3324         (discard_my_cleanups, discard_cleanups)
3325         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3326         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3327         (null_cleanup): Remove.
3328         (do_final_cleanups): Remove parameter.
3329
3330 2019-03-06  Tom Tromey  <tom@tromey.com>
3331
3332         * remote.c (remote_target::remote_parse_stop_reply): Use
3333         unique_xmalloc_ptr.
3334
3335 2019-03-06  Tom Tromey  <tom@tromey.com>
3336
3337         * stabsread.c (struct stabs_field_info): Rename from field_info.
3338         <list, fnlist>: Add initializers.
3339         <obstack>: New member.
3340         (read_member_functions, read_struct_fields, read_baseclasses):
3341         Allocate on obstack.  Don't use cleanups.
3342         (read_one_struct_field, read_member_functions, read_struct_fields)
3343         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3344         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3345         (read_struct_type): Update.
3346
3347 2019-03-06  Tom Tromey  <tom@tromey.com>
3348
3349         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3350         * common/filestuff.h (make_cleanup_close): Don't declare.
3351         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3352         Remove.
3353
3354 2019-03-06  Tom Tromey  <tom@tromey.com>
3355
3356         * solib-aix.c: Use make_scope_exit.
3357
3358 2019-03-06  Tom Tromey  <tom@tromey.com>
3359
3360         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3361         Use make_scope_exit.
3362
3363 2019-03-06  Tom Tromey  <tom@tromey.com>
3364
3365         * solib-svr4.c (disable_probes_interface): Remove parameter.
3366         (svr4_handle_solib_event): Use make_scope_exit.
3367
3368 2019-03-06  Tom Tromey  <tom@tromey.com>
3369
3370         * remote.c (struct stop_reply_deleter): Remove.
3371         (stop_reply_up): Update.
3372         (struct stop_reply): Derive from notif_event.  Don't typedef.
3373         <regcache>: Now a std::vector.
3374         (stop_reply_xfree): Remove.
3375         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3376         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3377         (remote_target::discard_pending_stop_replies): Use delete.
3378         (remote_target::remote_parse_stop_reply): Update.
3379         (remote_target::process_stop_reply): Update.
3380         * remote-notif.h (struct notif_event): Add virtual destructor.
3381         Remove "dtr" member.
3382         (struct notif_client) <alloc_event>: Return a unique_ptr.
3383         (notif_event_xfree): Don't declare.
3384         (notif_event_up): New typedef.
3385         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3386         (notif_event_xfree, do_notif_event_xfree): Remove.
3387         (remote_notif_state_xfree): Update.
3388
3389 2019-03-06  Tom Tromey  <tom@tromey.com>
3390
3391         * infrun.c (displaced_step_clear_cleanup): Now a
3392         forward_scope_exit type.
3393         (displaced_step_prepare_throw): Update.
3394         (displaced_step_fixup): Update.
3395
3396 2019-03-06  Tom Tromey  <tom@tromey.com>
3397
3398         * inferior.h (class inferior): Update comment.
3399         * gdbthread.h (class thread_info): Update comment.
3400
3401 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3402             Tom Tromey  <tom@tromey.com>
3403
3404         * stabsread.h (struct stab_section_list): Remove.
3405         (coffstab_build_psymtabs): Update.
3406         * dbxread.c (symbuf_sections): Now a std::vector.
3407         (sect_idx): New global.
3408         (fill_symbuf): Update.
3409         (coffstab_build_psymtabs): Change type of stabsects parameter.
3410         Update.
3411         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3412         std::vector.
3413         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3414         (coff_locate_sections): Update.
3415         (coff_symfile_read): Remove cleanups.  Update.
3416         (init_stringtab): Add storage parameter.
3417         (free_stringtab, free_stringtab_cleanup): Remove.
3418         (init_lineno): Add storage parameter.
3419         (free_linetab, free_linetab_cleanup): Remove.
3420
3421 2019-03-06  Pedro Alves  <palves@redhat.com>
3422
3423         * linux-fork.c (fork_info::clobber_regs): Delete.
3424         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3425         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3426         comment.  Adjust.
3427         (scoped_switch_fork_info::scoped_switch_fork_info)
3428         (checkpoint_command, linux_fork_context): Adjust
3429         fork_save_infrun_state calls.
3430
3431 2019-03-06  Pedro Alves  <palves@redhat.com>
3432
3433         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3434         (inf_has_multiple_threads): Return 'bool' and rewrite using
3435         inferior_info::threads().
3436
3437 2019-03-06  Pedro Alves  <palves@redhat.com>
3438
3439         * linux-fork.c: Include <list>.
3440         (fork_list): Now a std::list instance.
3441         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3442         (forks_exist_p, find_last_fork): Adjust.
3443         (new_fork): Delete.
3444         (one_fork_p): New.
3445         (add_fork): Adjust.
3446         (free_fork): Delete, folded into fork_info::~fork_info().
3447         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3448         Adjust.
3449         (init_fork_list): Delete.
3450         (linux_fork_killall, linux_fork_mourn_inferior)
3451         (linux_fork_detach, info_checkpoints_command): Adjust.
3452         (_initialize_linux_fork): No longer call init_fork_list.
3453
3454 2019-03-06  Pedro Alves  <palves@redhat.com>
3455
3456         * linux-fork.c (new_fork): New, split out of ...
3457         (add_fork): ... this.  Return void.  Move "first fork" special
3458         case from here, to ...
3459         (checkpoint_command): ... here.
3460         * linux-linux.h (add_fork): Return void.
3461
3462 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3465
3466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3467             Chris January  <chris.january@arm.com>
3468             David Lecomber  <david.lecomber@arm.com>
3469
3470         * f-exp.y: New token, UNOP_INTRINSIC.
3471         (exp): New pattern using UNOP_INTRINSIC token.
3472         (f77_keywords): Add 'abs' keyword.
3473         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3474         (value_from_host_double): New function.
3475         (evaluate_subexp_f): Support UNOP_ABS.
3476
3477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3478
3479         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3480         types.
3481
3482 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3483
3484         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3485         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3486         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3487
3488 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3491
3492 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3493             Chris January  <chris.january@arm.com>
3494
3495         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3496         * f-exp.y: Define 'KIND' token.
3497         (exp): New pattern for KIND expressions.
3498         (ptype): Handle types with a kind extension.
3499         (direct_abs_decl): Extend to spot kind extensions.
3500         (f77_keywords): Add 'kind' to the list.
3501         (push_kind_type): New function.
3502         (convert_to_kind_type): New function.
3503         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3504         * parse.c (operator_length_standard): Likewise.
3505         * parser-defs.h (enum type_pieces): Add tp_kind.
3506         * std-operator.def: Add UNOP_KIND.
3507
3508 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3509
3510         * f-exp.y (f_parse): Set yydebug.
3511
3512 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3513
3514         * f-lang.c (evaluate_subexp_f): New function.
3515         (exp_descriptor_f): New global.
3516         (f_language_defn): Use exp_descriptor_f instead of
3517         exp_descriptor_standard.
3518
3519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * f-exp.y (struct token): Add comments.
3522         (dot_ops): Remove uppercase versions and the end marker.
3523         (f77_keywords): Likewise.
3524         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3525         entries in the dot_ops array are case insensitive, and use
3526         strncasecmp to compare strings.  Also some whitespace cleanup in
3527         this area.  Similar for the f77_keywords array, except entries in
3528         this list might be case sensitive.
3529
3530 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * f-exp.y (struct f77_boolean_val): Add comments.
3533         (boolean_values): Remove uppercase versions, and end marker.
3534         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3535         and use strncasecmp to achieve case insensitivity.  Additionally,
3536         perform whitespace cleanup around this code.
3537
3538 2019-03-06  Tom Tromey  <tromey@adacore.com>
3539
3540         * remote-sim.c (gdbsim_target_open): Use result of
3541         gdb_argv::release.
3542
3543 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3544         Dirk Schubert  <dirk.schubert@arm.com>
3545         Chris January  <chris.january@arm.com>
3546
3547         * eval.c (evaluate_subexp_standard): Call Fortran argument
3548         wrapping logic.
3549         * f-lang.c (struct value): A value which can be passed into a
3550         Fortran function call.
3551         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3552         where appropriate.
3553         (struct type): Value ready for a Fortran function call.
3554         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3555         is needed.
3556         * f-lang.h (fortran_argument_convert): Declaration.
3557         (fortran_preserve_arg_pointer): Declaration.
3558         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3559
3560 2019-03-05  Tom Tromey  <tromey@adacore.com>
3561
3562         * python/py-prettyprint.c (print_string_repr): Remove #if.
3563         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3564
3565 2019-03-05  Tom Tromey  <tromey@adacore.com>
3566
3567         * target.c (the_dummy_target): Move later.  Change type to
3568         "dummy_target".
3569         (initialize_targets): Don't initialize the_dummy_target.
3570
3571 2019-03-05  Tom Tromey  <tromey@adacore.com>
3572
3573         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3574         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3575
3576 2019-03-05  Tom Tromey  <tromey@adacore.com>
3577
3578         * windows-nat.c (windows_nat_target::attach)
3579         (windows_nat_target::detach): Don't call gdb_flush.
3580         * valprint.c (generic_val_print, val_print, val_print_string):
3581         Don't call gdb_flush.
3582         * utils.c (defaulted_query): Don't call gdb_flush.
3583         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3584         * target.c (target_announce_detach): Don't call gdb_flush.
3585         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3586         * remote.c (extended_remote_target::attach): Don't call
3587         gdb_flush.
3588         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3589         * printcmd.c (do_examine): Don't call gdb_flush.
3590         (info_display_command): Don't call gdb_flush.
3591         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3592         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3593         * memattr.c (info_mem_command): Don't call gdb_flush.
3594         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3595         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3596         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3597         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3598         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3599         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3600         (gnu_nat_target::detach): Don't call gdb_flush.
3601         * f-valprint.c (f_val_print): Don't call gdb_flush.
3602         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3603         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3604         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3605         gdb_flush.
3606         * c-valprint.c (c_val_print): Don't call gdb_flush.
3607         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3608
3609 2019-03-05  Tom Tromey  <tromey@adacore.com>
3610
3611         * varobj.c (update_dynamic_varobj_children): Update.
3612         (install_default_visualizer): Use reset, not release.
3613         * value.c (set_internalvar): Update.
3614         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3615         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3616         ATTRIBUTE_UNUSED_RESULT.
3617
3618 2019-03-05  Tom Tromey  <tromey@adacore.com>
3619
3620         * remote.c (class scoped_remote_fd) <release>: Add
3621         ATTRIBUTE_UNUSED_RESULT.
3622
3623 2019-03-05  Tom Tromey  <tromey@adacore.com>
3624
3625         * macroexp.c (struct macro_buffer) <release>: Add
3626         ATTRIBUTE_UNUSED_RESULT.
3627
3628 2019-03-05  Tom Tromey  <tromey@adacore.com>
3629
3630         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3631         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3632         ATTRIBUTE_UNUSED_RESULT.
3633
3634 2019-03-05  Tom Tromey  <tromey@adacore.com>
3635
3636         * common/scoped_fd.h (class scoped_fd) <release>: Add
3637         ATTRIBUTE_UNUSED_RESULT.
3638
3639 2019-03-05  Tom Tromey  <tromey@adacore.com>
3640
3641         * parser-defs.h (struct parser_state) <release>: Add
3642         ATTRIBUTE_UNUSED_RESULT.
3643
3644 2019-03-05  Tom Tromey  <tromey@adacore.com>
3645
3646         * utils.h (class gdb_argv) <release>: Add
3647         ATTRIBUTE_UNUSED_RESULT.
3648         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3649
3650 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3651
3652         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3653         for-loop range, to avoid compiler warnings.
3654
3655         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3656         avoid compiler warnings about unused variables.
3657
3658         * NEWS: Mention end of support for native debugging on MS-Windows
3659         before XP.
3660
3661         PR gdb/24292
3662         * common/netstuff.c:
3663         * gdbserver/gdbreplay.c
3664         * gdbserver/remote-utils.c:
3665         * ser-tcp.c:
3666         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3667         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3668         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3669         'getaddrinfo' and 'freeaddrinfo' were not available before
3670         Windows XP, and mingw.org's MinGW headers by default define
3671         _WIN32_WINNT to 0x500.
3672
3673 2019-03-01  Gary Benson <gbenson@redhat.com>
3674
3675         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3676
3677 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3678             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3679
3680         PR gdb/8527
3681         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3682         set_sigint_trap, clear_sigint_trap.
3683
3684 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3685
3686         * target.c (target_detach): Clear the regcache and the
3687         frame cache.
3688
3689 2019-02-27  Pedro Alves  <palves@redhat.com>
3690
3691         * utils.c (set_screen_size): When we cap the height/width sizes,
3692         tweak the corresponding command variable to show "unlimited":
3693
3694 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3695             Pedro Alves  <palves@redhat.com>
3696
3697         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3698         before calling rl_set_screen_size.
3699
3700 2019-02-27  Tom Tromey  <tromey@adacore.com>
3701
3702         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3703         define.
3704         * python/py-value.c: Remove Python 2.4 workaround.
3705         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3706         workaround.
3707         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3708         Python 2.4 workaround.
3709         * python/python-internal.h: Remove Python 2.4 comment.
3710         (Py_ssize_t): Don't define.
3711         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3712         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3713         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3714         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3715         * python/python.c (do_start_initialization): Remove Python 2.4
3716         workaround.
3717         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3718         (print_children): Remove Python 2.4 workaround.
3719         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3720         workaround.
3721         (CHARBUFFERPROC_NAME): Remove.
3722         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3723         Python 2.4 workaround.
3724
3725 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3726
3727         * NEWS: Note minimum Python version.
3728
3729 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3730
3731         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3732         code from these functions.  Remove corresponding ifdefs.  Use
3733         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3734         Remove gotos and target of gotos.
3735         (infpy_search_memory): Likewise.
3736
3737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3738
3739         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3740         (hppa_gdbarch_init): Don't register deleted functions with
3741         gdbarch.
3742
3743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3744
3745         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3746         (h8300_unwind_sp): Delete.
3747         (h8300_dummy_id): Delete.
3748         (h8300_gdbarch_init): Don't register deleted functions with
3749         gdbarch.
3750
3751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3754         (ft32_unwind_pc): Delete.
3755         (ft32_unwind_sp): Delete.
3756         (ft32_gdbarch_init): Don't register deleted functions with
3757         gdbarch.
3758
3759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3760
3761         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3762         (frv_unwind_pc): Delete.
3763         (frv_unwind_sp): Delete.
3764         (frv_gdbarch_init): Don't register deleted functions with
3765         gdbarch.
3766
3767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3768
3769         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3770         (riscv_unwind_pc): Delete.
3771         (riscv_unwind_sp): Delete.
3772         (riscv_gdbarch_init): Don't register deleted functions with
3773         gdbarch.
3774
3775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3776
3777         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3778         (csky_unwind_pc): Delete.
3779         (csky_unwind_sp): Delete.
3780         (csky_gdbarch_init): Don't register deleted functions with
3781         gdbarch.
3782
3783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3784
3785         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3786         (cris_unwind_pc): Delete.
3787         (cris_unwind_sp): Delete.
3788         (cris_gdbarch_init): Don't register deleted functions with
3789         gdbarch.
3790
3791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3792
3793         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3794         (bfin_unwind_pc): Delete.
3795         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3796
3797 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3800         (arm_unwind_pc): Delete.
3801         (arm_unwind_sp): Delete.
3802         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3803
3804 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3807         (arc_unwind_pc): Delete.
3808         (arc_unwind_sp): Delete.
3809         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3810
3811 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3812
3813         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3814         (alpha_unwind_pc): Delete.
3815         (alpha_gdbarch_init): Don't register deleted functions with
3816         gdbarch.
3817
3818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3821         (aarch64_unwind_pc): Delete.
3822         (aarch64_unwind_sp): Delete.
3823         (aarch64_gdbarch_init): Don't register deleted functions with
3824         gdbarch.
3825
3826 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3827
3828         * gdbtypes.c (type_align): Don't consider static members when
3829         computing structure alignment.
3830
3831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3834         return 0 for other types.
3835         * arch-utils.c (default_type_align): Always return 0.
3836         * gdbarch.h: Regenerate.
3837         * gdbarch.sh (type_align): Extend comment.
3838         * gdbtypes.c (type_align): Add additional comments, always call
3839         gdbarch_type_align before applying the default rules.
3840         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3841         generic code will then apply a suitable default.
3842         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3843         types, return 0 for other types.
3844
3845 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3846
3847         * NEWS: Create a new section for the next release branch.
3848         Rename the section of the current branch, now that it has
3849         been cut.
3850
3851 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3852
3853         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3854         * version.in: Bump version to 8.3.50.DATE-git.
3855
3856 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3857
3858         * aix-thread.c (ptid_cmp): Remove unused variable.
3859         (get_signaled_thread): Likewise.
3860         (store_regs_user_thread): Likewise.
3861         (store_regs_kernel_thread): Likewise.
3862         (fetch_regs_kernel_thread): Remove shadowed variable.
3863
3864 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * features/riscv/32bit-cpu.xml: Add register numbers.
3867         * features/riscv/32bit-fpu.c: Regenerate.
3868         * features/riscv/32bit-fpu.xml: Add register numbers.
3869         * features/riscv/64bit-cpu.xml: Add register numbers.
3870         * features/riscv/64bit-fpu.c: Regenerate.
3871         * features/riscv/64bit-fpu.xml: Add register numbers.
3872
3873 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3874
3875         * NEWS: Mention two argument form of gdb.Value constructor.
3876         * python/py-value.c (convert_buffer_and_type_to_value): New
3877         function.
3878         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3879         Add support for handling an optional second argument.  Call
3880         convert_buffer_and_type_to_value as appropriate.
3881         * python/python-internal.h (Py_buffer_deleter): New struct.
3882         (Py_buffer_up): New typedef.
3883
3884 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3885
3886         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3887         instead of releasing ownership.
3888
3889 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3890
3891         * dwarf2read.c (open_and_init_dwp_file): Call
3892         elf_numsections instead of bfd_count_sections to initialize
3893         dwp_file->num_sections.
3894
3895 2019-02-25  Tom Tromey  <tromey@adacore.com>
3896
3897         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3898
3899 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3900
3901         * gcore.in: Add '--readnever' option when invoking GDB.
3902
3903 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3904
3905         * MAINTAINERS: Update my email address.
3906
3907 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3908
3909         * build-id.c (build_id_to_debug_bfd_1): New function.
3910         (build_id_to_debug_bfd): Look for separate debug file in
3911         sysroot.
3912
3913 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3914
3915         * gdbarch.sh: Update the copyright year range that is placed into
3916         generated files.
3917
3918 2019-02-22  Keith Seitz  <keiths@redhat.com>
3919
3920         PR symtab/23853
3921         * linespec.c (create_sals_line_offset): Search for the default
3922         symtab's filename instead of its fullname.
3923
3924 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3925
3926         * NEWS: Update style defaults.
3927
3928 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3929
3930         * main.c (captured_main_1): Disable styling in batch mode.
3931
3932 2019-02-20  Tom Tromey  <tom@tromey.com>
3933
3934         * symtab.c (symtab_symbol_info): Fix typos.
3935
3936 2019-02-20  Tom Tromey  <tromey@adacore.com>
3937
3938         * findcmd.c (_initialize_mem_search): Use upper case for
3939         metasyntactic variables.
3940
3941 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3942
3943         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3944         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3945
3946 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3947
3948         * top.h (source_file_name): Change to std::string.
3949         * top.c (source_file_name): Likewise.
3950         (command_line_input): Adjust.
3951         * cli/cli-script.c (script_from_file): Adjust.
3952
3953 2019-02-19  Tom Tromey  <tromey@adacore.com>
3954
3955         * ravenscar-thread.c
3956         (ravenscar_thread_target::update_thread_list): Don't call
3957         ada_build_task_list.
3958         * ada-lang.h (ada_build_task_list): Don't declare.
3959         * ada-tasks.c (struct ada_tasks_inferior_data)
3960         <task_list_valid_p>: Now bool.
3961         (read_known_tasks, ada_task_list_changed)
3962         (ada_tasks_invalidate_inferior_data): Update.
3963         (read_known_tasks_array): Return bool.
3964         (read_known_tasks_list): Likewise.
3965         (read_known_tasks): Return void.
3966         (ada_build_task_list): Now static.
3967
3968 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3969
3970         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3971         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3972
3973 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3974
3975         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3976         variant for ada_tasks_pspace_data_handle and
3977         ada_tasks_inferior_data_handle.
3978         (ada_tasks_pspace_data_cleanup): New function.
3979         (ada_tasks_inferior_data_cleanup): New function.
3980
3981 2019-02-17  Tom Tromey  <tom@tromey.com>
3982
3983         * macrotab.h (macro_source_fullname): Return a std::string.
3984         * macrotab.c (macro_include, check_for_redefinition)
3985         (macro_undef, macro_lookup_definition, foreach_macro)
3986         (foreach_macro_in_scope): Update.
3987         (macro_source_fullname): Return a std::string.
3988         * macrocmd.c (show_pp_source_pos): Update.
3989
3990 2019-02-17  Tom Tromey  <tom@tromey.com>
3991
3992         * macrocmd.c (show_pp_source_pos): Style the file names.
3993
3994 2019-02-17  Tom Tromey  <tom@tromey.com>
3995
3996         PR tui/24197:
3997         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3998
3999 2019-02-17  Tom Tromey  <tom@tromey.com>
4000
4001         * ada-lang.c (user_select_syms): Use filtered printing.
4002         * utils.c (wrap_style): New global.
4003         (desired_style): Remove.
4004         (emit_style_escape): Add stream parameter.
4005         (set_output_style, reset_terminal_style, prompt_for_continue):
4006         Update.
4007         (flush_wrap_buffer): Only flush gdb_stdout.
4008         (wrap_here): Set wrap_style.
4009         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4010         treat escape sequences as a character.  Change when wrap buffer is
4011         flushed.
4012         (fputs_styled): Do not set the output style when the default is
4013         requested.
4014         * ui-style.h (struct ui_file_style) <is_default>: New method.
4015         * source.c (print_source_lines_base): Emit escape sequences in one
4016         piece.
4017
4018 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4019
4020         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4021         integers and enumeration types.
4022
4023 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4024
4025         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4026         instead of lookup_symbol_in_language
4027         (do_exact_match): New function.
4028         (ada_get_symbol_name_matcher): Return do_exact_match when
4029         doing a verbatim match.
4030
4031 2019-02-15  Tom Tromey  <tromey@adacore.com>
4032
4033         * ravenscar-thread.c (ravenscar_thread_target::resume)
4034         (ravenscar_thread_target::wait): Special case wildcard requests.
4035
4036 2019-02-15  Tom Tromey  <tromey@adacore.com>
4037
4038         * ravenscar-thread.c (base_ptid): Remove.
4039         (struct ravenscar_thread_target) <close>: New method.
4040         <m_base_ptid>: New member.
4041         <update_inferior_ptid, active_task, task_is_currently_active,
4042         runtime_initialized>: Declare methods.
4043         <ravenscar_thread_target>: Add constructor.
4044         (ravenscar_thread_target::task_is_currently_active)
4045         (ravenscar_thread_target::update_inferior_ptid)
4046         (ravenscar_runtime_initialized): Rename.  Now methods.
4047         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4048         (ravenscar_thread_target::update_thread_list): Update.
4049         (ravenscar_thread_target::active_task): Now method.
4050         (ravenscar_thread_target::store_registers)
4051         (ravenscar_thread_target::prepare_to_store)
4052         (ravenscar_thread_target::prepare_to_store)
4053         (ravenscar_thread_target::mourn_inferior): Update.
4054         (ravenscar_inferior_created): Use "new" to create target.
4055         (ravenscar_thread_target::get_ada_task_ptid): Update.
4056         (_initialize_ravenscar): Don't initialize base_ptid.
4057         (ravenscar_ops): Remove global.
4058
4059 2019-02-15  Tom Tromey  <tromey@adacore.com>
4060
4061         * target.h (push_target): Declare new overload.
4062         * target.c (push_target): New overload, taking an rvalue reference.
4063         * remote.c (remote_target::open_1): Use push_target overload.
4064         * corelow.c (core_target_open): Use push_target overload.
4065
4066 2019-02-15  Tom Tromey  <tromey@adacore.com>
4067
4068         * ravenscar-thread.c (is_ravenscar_task)
4069         (ravenscar_task_is_currently_active): Return bool.
4070         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4071         (_initialize_ravenscar): Remove "(void)".
4072         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4073         Return bool.
4074
4075 2019-02-15  Tom Tromey  <tromey@adacore.com>
4076
4077         * ravenscar-thread.c (ravenscar_runtime_initializer)
4078         (has_ravenscar_runtime, get_running_thread_id)
4079         (ravenscar_thread_target::resume): Fix indentation.
4080
4081 2019-02-15  Tom Tromey  <tromey@adacore.com>
4082
4083         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4084         from ravenscar_arch_ops.
4085         (sparc_ravenscar_ops::fetch_registers)
4086         (sparc_ravenscar_ops::store_registers): Now methods.
4087         (sparc_ravenscar_prepare_to_store): Remove.
4088         (sparc_ravenscar_ops): Redefine.
4089         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4090         methods and destructor.  Remove members.
4091         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4092         (ravenscar_thread_target::store_registers)
4093         (ravenscar_thread_target::prepare_to_store): Update.
4094         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4095         Remove.
4096         (struct ppc_ravenscar_powerpc_ops): Derive from
4097         ravenscar_arch_ops.
4098         (ppc_ravenscar_powerpc_ops::fetch_registers)
4099         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4100         (ppc_ravenscar_powerpc_ops): Redefine.
4101         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4102         (ppc_ravenscar_e500_ops::fetch_registers)
4103         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4104         (ppc_ravenscar_e500_ops): Redefine.
4105         * aarch64-ravenscar-thread.c
4106         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4107         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4108         (aarch64_ravenscar_fetch_registers)
4109         (aarch64_ravenscar_store_registers): Now methods.
4110         (aarch64_ravenscar_ops): Redefine.
4111
4112 2019-02-15  Tom Tromey  <tromey@adacore.com>
4113
4114         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4115         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4116         (ravenscar_thread_target::stopped_by_watchpoint)
4117         (ravenscar_thread_target::stopped_data_address)
4118         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4119
4120 2019-02-15  Tom Tromey  <tromey@adacore.com>
4121
4122         * ravenscar-thread.c: Fix some typos.
4123
4124 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4125             Tom Tromey  <tromey@adacore.com>
4126
4127         * ada-lang.c (ada_exception_sal): Change addr_string to a
4128         std::string.
4129         (create_ada_exception_catchpoint): Update.
4130
4131 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4132             Tom Tromey  <tromey@adacore.com>
4133
4134         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4135         (bp_location_ops): Remove.
4136         (base_breakpoint_allocate_location): Update.
4137         (free_bp_location): Update.
4138         * ada-lang.c (class ada_catchpoint_location)
4139         <ada_catchpoint_location>: Remove ops parameter.
4140         (ada_catchpoint_location_dtor): Remove.
4141         (ada_catchpoint_location_ops): Remove.
4142         (allocate_location_exception): Update.
4143         * breakpoint.h (struct bp_location_ops): Remove.
4144         (class bp_location) <bp_location>: Remove bp_location_ops
4145         parameter.
4146         <~bp_location>: Add destructor.
4147         <ops>: Remove.
4148
4149 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4150             Pedro Alves  <palves@redhat.com>
4151
4152         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4153         'PATH_MAX'.
4154
4155 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4156             Samuel Thibault  <samuel.thibault@gnu.org>
4157             Thomas Schwinge  <thomas@codesourcery.com>
4158
4159         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4160         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4161
4162 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4163
4164         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4165         (check_empty): Use "const char *".
4166
4167         * gnu-nat.c (gnu_nat_target::detach): Instead of
4168         'detach_inferior (pid)' call
4169         'detach_inferior (find_inferior_pid (pid))'.
4170
4171         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4172         'nat/fork-inferior.o'.
4173         * gnu-nat.c: #include "nat/fork-inferior.h".
4174
4175         * gnu-nat.c (gnu_nat_target::detach): Instead of
4176         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4177         * gnu-nat.h: #include "inf-child.h".
4178         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4179         'i386_gnu_nat_target::fetch_registers'.
4180         (gnu_store_registers): Rename/move to
4181         'i386_gnu_nat_target::store_registers'.
4182
4183         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4184         * gnu-nat.h (mach_thread_info): New function.
4185         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4186
4187         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4188
4189 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4190
4191         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4192
4193 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4194
4195         * windows-nat.c (windows_add_thread): Add new parameter
4196         "main_thread_p" with default value set to false.  Update
4197         function documentation as well as all callers.
4198         (windows_delete_thread): Likewise.
4199         (fake_create_process): Update call to windows_add_thread.
4200         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4201         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4202         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4203         call to windows_delete_thread.
4204
4205 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4206
4207         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4208
4209 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4210
4211         * symfile.c (find_separate_debug_file): Use canonical path of
4212         sysroot with child_path instead of gdb_sysroot if it is valid.
4213
4214 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4215
4216         * symfile.c (find_separate_debug_file): Use child_path to
4217         determine if an object file is under a sysroot.
4218
4219 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4220
4221         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4222         unittests/child-path-selftests.c.
4223         * common/pathstuff.c (child_path): New function.
4224         * common/pathstuff.h (child_path): New prototype.
4225         * unittests/child-path-selftests.c: New file.
4226
4227 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4228
4229         * symfile.c (find_separate_debug_file): Look for separate debug
4230         files in debug directories under the sysroot.
4231
4232 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4233
4234         * symtab.h (struct minimal_symbol data_p): New const method.
4235         (struct minimal_symbol text_p): Likewise.
4236         * symtab.c (output_source_filename): Use file name style
4237         to print file name.
4238         (print_symbol_info): Likewise.
4239         (print_msymbol_info): Use address style to print addresses.
4240         Use function name style to print executable text symbols.
4241         (expand_symtab_containing_pc): Use data_p.
4242         (find_pc_sect_compunit_symtab): Likewise.
4243
4244 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4245
4246         * breakpoint.c (describe_other_breakpoints): Use address style
4247         to print addresses.
4248         (say_where): Likewise.
4249
4250 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4251
4252         * ada-typeprint.c (print_func_type): Print function name
4253         style to print function name.
4254         * c-typeprint.c (c_print_type_1): Likewise.
4255
4256 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4257
4258         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4259         for execve.
4260
4261 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4262
4263         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4264         type_stack.
4265
4266 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4267
4268         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4269         TYPE_CODE_REF types.
4270
4271 2019-02-08  Jim Wilson  <jimw@sifive.com>
4272
4273         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4274         (riscv_linux_fregset): New.
4275         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4276
4277 2019-02-07  Tom Tromey  <tom@tromey.com>
4278
4279         * thread.c (thread_cancel_execution_command): Update.
4280         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4281         methods.
4282         (struct thread_fsm_ops): Remove.
4283         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4284         (thread_fsm_should_stop, thread_fsm_return_value)
4285         (thread_fsm_set_finished, thread_fsm_finished_p)
4286         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4287         Don't declare.
4288         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4289         * infrun.c (clear_proceed_status_thread)
4290         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4291         (print_stop_event): Update.
4292         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4293         Add constructor.
4294         (step_command_fsm_ops): Remove.
4295         (new_step_command_fsm): Remove.
4296         (step_1): Update.
4297         (step_command_fsm::should_stop): Rename from
4298         step_command_fsm_should_stop.
4299         (step_command_fsm::clean_up): Rename from
4300         step_command_fsm_clean_up.
4301         (step_command_fsm::do_async_reply_reason): Rename from
4302         step_command_fsm_async_reply_reason.
4303         (struct until_next_fsm): Inherit from thread_fsm.  Add
4304         constructor.
4305         (until_next_fsm_ops): Remove.
4306         (new_until_next_fsm): Remove.
4307         (until_next_fsm::should_stop): Rename from
4308         until_next_fsm_should_stop.
4309         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4310         (until_next_fsm::do_async_reply_reason): Rename from
4311         until_next_fsm_async_reply_reason.
4312         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4313         constructor.  Change type of breakpoint.
4314         (finish_command_fsm_ops): Remove.
4315         (new_finish_command_fsm): Remove.
4316         (finish_command_fsm::should_stop): Rename from
4317         finish_command_fsm_should_stop.
4318         (finish_command_fsm::clean_up): Rename from
4319         finish_command_fsm_clean_up.
4320         (finish_command_fsm::return_value): Rename from
4321         finish_command_fsm_return_value.
4322         (finish_command_fsm::do_async_reply_reason): Rename from
4323         finish_command_fsm_async_reply_reason.
4324         (finish_command): Update.
4325         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4326         Add constructor.
4327         (call_thread_fsm_ops): Remove.
4328         (call_thread_fsm::call_thread_fsm): Rename from
4329         new_call_thread_fsm.
4330         (call_thread_fsm::should_stop): Rename from
4331         call_thread_fsm_should_stop.
4332         (call_thread_fsm::should_notify_stop): Rename from
4333         call_thread_fsm_should_notify_stop.
4334         (run_inferior_call, call_function_by_hand_dummy): Update.
4335         * cli/cli-interp.c (should_print_stop_to_console): Update.
4336         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4337         Add constructor.  Change type of location_breakpoint,
4338         caller_breakpoint.
4339         (until_break_fsm_ops): Remove.
4340         (new_until_break_fsm): Remove.
4341         (until_break_fsm::should_stop): Rename from
4342         until_break_fsm_should_stop.
4343         (until_break_fsm::clean_up): Rename from
4344         until_break_fsm_clean_up.
4345         (until_break_fsm::do_async_reply_reason): Rename from
4346         until_break_fsm_async_reply_reason.
4347         (until_break_command): Update.
4348         * thread-fsm.c: Remove.
4349         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4350
4351 2019-02-07  Tom Tromey  <tom@tromey.com>
4352
4353         * yy-remap.h: Add include guard.
4354         * xtensa-tdep.h: Add include guard.
4355         * xcoffread.h: Rename include guard.
4356         * varobj-iter.h: Add include guard.
4357         * tui/tui.h: Rename include guard.
4358         * tui/tui-winsource.h: Rename include guard.
4359         * tui/tui-wingeneral.h: Rename include guard.
4360         * tui/tui-windata.h: Rename include guard.
4361         * tui/tui-win.h: Rename include guard.
4362         * tui/tui-stack.h: Rename include guard.
4363         * tui/tui-source.h: Rename include guard.
4364         * tui/tui-regs.h: Rename include guard.
4365         * tui/tui-out.h: Rename include guard.
4366         * tui/tui-layout.h: Rename include guard.
4367         * tui/tui-io.h: Rename include guard.
4368         * tui/tui-hooks.h: Rename include guard.
4369         * tui/tui-file.h: Rename include guard.
4370         * tui/tui-disasm.h: Rename include guard.
4371         * tui/tui-data.h: Rename include guard.
4372         * tui/tui-command.h: Rename include guard.
4373         * tic6x-tdep.h: Add include guard.
4374         * target/waitstatus.h: Rename include guard.
4375         * target/wait.h: Rename include guard.
4376         * target/target.h: Rename include guard.
4377         * target/resume.h: Rename include guard.
4378         * target-float.h: Rename include guard.
4379         * stabsread.h: Add include guard.
4380         * rs6000-tdep.h: Add include guard.
4381         * riscv-fbsd-tdep.h: Add include guard.
4382         * regformats/regdef.h: Rename include guard.
4383         * record.h: Rename include guard.
4384         * python/python.h: Rename include guard.
4385         * python/python-internal.h: Rename include guard.
4386         * python/py-stopevent.h: Rename include guard.
4387         * python/py-ref.h: Rename include guard.
4388         * python/py-record.h: Rename include guard.
4389         * python/py-record-full.h: Rename include guard.
4390         * python/py-record-btrace.h: Rename include guard.
4391         * python/py-instruction.h: Rename include guard.
4392         * python/py-events.h: Rename include guard.
4393         * python/py-event.h: Rename include guard.
4394         * procfs.h: Add include guard.
4395         * proc-utils.h: Add include guard.
4396         * p-lang.h: Add include guard.
4397         * or1k-tdep.h: Rename include guard.
4398         * observable.h: Rename include guard.
4399         * nto-tdep.h: Rename include guard.
4400         * nat/x86-linux.h: Rename include guard.
4401         * nat/x86-linux-dregs.h: Rename include guard.
4402         * nat/x86-gcc-cpuid.h: Add include guard.
4403         * nat/x86-dregs.h: Rename include guard.
4404         * nat/x86-cpuid.h: Rename include guard.
4405         * nat/ppc-linux.h: Rename include guard.
4406         * nat/mips-linux-watch.h: Rename include guard.
4407         * nat/linux-waitpid.h: Rename include guard.
4408         * nat/linux-ptrace.h: Rename include guard.
4409         * nat/linux-procfs.h: Rename include guard.
4410         * nat/linux-osdata.h: Rename include guard.
4411         * nat/linux-nat.h: Rename include guard.
4412         * nat/linux-namespaces.h: Rename include guard.
4413         * nat/linux-btrace.h: Rename include guard.
4414         * nat/glibc_thread_db.h: Rename include guard.
4415         * nat/gdb_thread_db.h: Rename include guard.
4416         * nat/gdb_ptrace.h: Rename include guard.
4417         * nat/fork-inferior.h: Rename include guard.
4418         * nat/amd64-linux-siginfo.h: Rename include guard.
4419         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4420         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4421         * nat/aarch64-linux.h: Rename include guard.
4422         * nat/aarch64-linux-hw-point.h: Rename include guard.
4423         * mn10300-tdep.h: Add include guard.
4424         * mips-linux-tdep.h: Add include guard.
4425         * mi/mi-parse.h: Rename include guard.
4426         * mi/mi-out.h: Rename include guard.
4427         * mi/mi-main.h: Rename include guard.
4428         * mi/mi-interp.h: Rename include guard.
4429         * mi/mi-getopt.h: Rename include guard.
4430         * mi/mi-console.h: Rename include guard.
4431         * mi/mi-common.h: Rename include guard.
4432         * mi/mi-cmds.h: Rename include guard.
4433         * mi/mi-cmd-break.h: Rename include guard.
4434         * m2-lang.h: Add include guard.
4435         * location.h: Rename include guard.
4436         * linux-record.h: Rename include guard.
4437         * linux-nat.h: Add include guard.
4438         * linux-fork.h: Add include guard.
4439         * i386-darwin-tdep.h: Rename include guard.
4440         * hppa-linux-offsets.h: Add include guard.
4441         * guile/guile.h: Rename include guard.
4442         * guile/guile-internal.h: Rename include guard.
4443         * gnu-nat.h: Rename include guard.
4444         * gdb-stabs.h: Rename include guard.
4445         * frv-tdep.h: Add include guard.
4446         * f-lang.h: Add include guard.
4447         * event-loop.h: Add include guard.
4448         * darwin-nat.h: Rename include guard.
4449         * cp-abi.h: Rename include guard.
4450         * config/sparc/nm-sol2.h: Rename include guard.
4451         * config/nm-nto.h: Rename include guard.
4452         * config/nm-linux.h: Add include guard.
4453         * config/i386/nm-i386gnu.h: Rename include guard.
4454         * config/djgpp/nl_types.h: Rename include guard.
4455         * config/djgpp/langinfo.h: Rename include guard.
4456         * compile/gcc-cp-plugin.h: Add include guard.
4457         * compile/gcc-c-plugin.h: Add include guard.
4458         * compile/compile.h: Rename include guard.
4459         * compile/compile-object-run.h: Rename include guard.
4460         * compile/compile-object-load.h: Rename include guard.
4461         * compile/compile-internal.h: Rename include guard.
4462         * compile/compile-cplus.h: Rename include guard.
4463         * compile/compile-c.h: Rename include guard.
4464         * common/xml-utils.h: Rename include guard.
4465         * common/x86-xstate.h: Rename include guard.
4466         * common/version.h: Rename include guard.
4467         * common/vec.h: Rename include guard.
4468         * common/tdesc.h: Rename include guard.
4469         * common/selftest.h: Rename include guard.
4470         * common/scoped_restore.h: Rename include guard.
4471         * common/scoped_mmap.h: Rename include guard.
4472         * common/scoped_fd.h: Rename include guard.
4473         * common/safe-iterator.h: Rename include guard.
4474         * common/run-time-clock.h: Rename include guard.
4475         * common/refcounted-object.h: Rename include guard.
4476         * common/queue.h: Rename include guard.
4477         * common/ptid.h: Rename include guard.
4478         * common/print-utils.h: Rename include guard.
4479         * common/preprocessor.h: Rename include guard.
4480         * common/pathstuff.h: Rename include guard.
4481         * common/observable.h: Rename include guard.
4482         * common/netstuff.h: Rename include guard.
4483         * common/job-control.h: Rename include guard.
4484         * common/host-defs.h: Rename include guard.
4485         * common/gdb_wait.h: Rename include guard.
4486         * common/gdb_vecs.h: Rename include guard.
4487         * common/gdb_unlinker.h: Rename include guard.
4488         * common/gdb_unique_ptr.h: Rename include guard.
4489         * common/gdb_tilde_expand.h: Rename include guard.
4490         * common/gdb_sys_time.h: Rename include guard.
4491         * common/gdb_string_view.h: Rename include guard.
4492         * common/gdb_splay_tree.h: Rename include guard.
4493         * common/gdb_setjmp.h: Rename include guard.
4494         * common/gdb_ref_ptr.h: Rename include guard.
4495         * common/gdb_optional.h: Rename include guard.
4496         * common/gdb_locale.h: Rename include guard.
4497         * common/gdb_assert.h: Rename include guard.
4498         * common/filtered-iterator.h: Rename include guard.
4499         * common/filestuff.h: Rename include guard.
4500         * common/fileio.h: Rename include guard.
4501         * common/environ.h: Rename include guard.
4502         * common/common-utils.h: Rename include guard.
4503         * common/common-types.h: Rename include guard.
4504         * common/common-regcache.h: Rename include guard.
4505         * common/common-inferior.h: Rename include guard.
4506         * common/common-gdbthread.h: Rename include guard.
4507         * common/common-exceptions.h: Rename include guard.
4508         * common/common-defs.h: Rename include guard.
4509         * common/common-debug.h: Rename include guard.
4510         * common/cleanups.h: Rename include guard.
4511         * common/buffer.h: Rename include guard.
4512         * common/btrace-common.h: Rename include guard.
4513         * common/break-common.h: Rename include guard.
4514         * cli/cli-utils.h: Rename include guard.
4515         * cli/cli-style.h: Rename include guard.
4516         * cli/cli-setshow.h: Rename include guard.
4517         * cli/cli-script.h: Rename include guard.
4518         * cli/cli-interp.h: Rename include guard.
4519         * cli/cli-decode.h: Rename include guard.
4520         * cli/cli-cmds.h: Rename include guard.
4521         * charset-list.h: Add include guard.
4522         * buildsym-legacy.h: Rename include guard.
4523         * bfin-tdep.h: Add include guard.
4524         * ax.h: Rename include guard.
4525         * arm-linux-tdep.h: Add include guard.
4526         * arm-fbsd-tdep.h: Add include guard.
4527         * arch/xtensa.h: Rename include guard.
4528         * arch/tic6x.h: Add include guard.
4529         * arch/i386.h: Add include guard.
4530         * arch/arm.h: Rename include guard.
4531         * arch/arm-linux.h: Rename include guard.
4532         * arch/arm-get-next-pcs.h: Rename include guard.
4533         * arch/amd64.h: Add include guard.
4534         * arch/aarch64-insn.h: Rename include guard.
4535         * arch-utils.h: Rename include guard.
4536         * annotate.h: Add include guard.
4537         * amd64-darwin-tdep.h: Rename include guard.
4538         * aarch64-linux-tdep.h: Add include guard.
4539         * aarch64-fbsd-tdep.h: Add include guard.
4540         * aarch32-linux-nat.h: Add include guard.
4541
4542 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4543
4544         * macrotab.c (macro_define_internal): New function that
4545         factorizes macro_define_object_internal and macro_define_function
4546         code.
4547         (macro_define_object_internal): Use macro_define_internal.
4548         (macro_define_function): Likewise.
4549
4550 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4551
4552         * macrocmd.c (extract_identifier): Return
4553         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4554         callers.
4555
4556 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4557
4558         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4559
4560 2019-02-05  Tom Tromey  <tom@tromey.com>
4561
4562         * target.c (target_stack::unpush): Move assertion earlier.
4563
4564 2019-01-30  Tom Tromey  <tom@tromey.com>
4565
4566         PR python/23615:
4567         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4568         (gdbpy_parse_and_eval): Likewise.
4569         * python/python-internal.h (gdbpy_allow_threads): New class.
4570
4571 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4572
4573         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4574         (aarch64_fbsd_fpregmap): Move earlier.
4575         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4576         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4577         instead of individual calls to trad_frame_set_reg_addr.
4578         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4579         earlier.
4580         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4581         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4582         instead of individual calls to trad_frame_set_reg_addr.
4583
4584 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4585
4586         * CONTRIBUTE: Replace contribution list with wiki link.
4587
4588 2019-01-25  Tom Tromey  <tom@tromey.com>
4589
4590         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4591
4592 2019-01-25  Tom Tromey  <tom@tromey.com>
4593
4594         * xtensa-linux-nat.c: Fix common/ includes.
4595         * xml-support.h: Fix common/ includes.
4596         * xml-support.c: Fix common/ includes.
4597         * x86-linux-nat.c: Fix common/ includes.
4598         * windows-nat.c: Fix common/ includes.
4599         * varobj.h: Fix common/ includes.
4600         * varobj.c: Fix common/ includes.
4601         * value.c: Fix common/ includes.
4602         * valops.c: Fix common/ includes.
4603         * utils.c: Fix common/ includes.
4604         * unittests/xml-utils-selftests.c: Fix common/ includes.
4605         * unittests/utils-selftests.c: Fix common/ includes.
4606         * unittests/unpack-selftests.c: Fix common/ includes.
4607         * unittests/tracepoint-selftests.c: Fix common/ includes.
4608         * unittests/style-selftests.c: Fix common/ includes.
4609         * unittests/string_view-selftests.c: Fix common/ includes.
4610         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4611         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4612         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4613         * unittests/rsp-low-selftests.c: Fix common/ includes.
4614         * unittests/parse-connection-spec-selftests.c: Fix common/
4615         includes.
4616         * unittests/optional-selftests.c: Fix common/ includes.
4617         * unittests/offset-type-selftests.c: Fix common/ includes.
4618         * unittests/observable-selftests.c: Fix common/ includes.
4619         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4620         * unittests/memrange-selftests.c: Fix common/ includes.
4621         * unittests/memory-map-selftests.c: Fix common/ includes.
4622         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4623         * unittests/function-view-selftests.c: Fix common/ includes.
4624         * unittests/environ-selftests.c: Fix common/ includes.
4625         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4626         * unittests/common-utils-selftests.c: Fix common/ includes.
4627         * unittests/cli-utils-selftests.c: Fix common/ includes.
4628         * unittests/array-view-selftests.c: Fix common/ includes.
4629         * ui-file.c: Fix common/ includes.
4630         * tui/tui-io.c: Fix common/ includes.
4631         * tracepoint.h: Fix common/ includes.
4632         * tracepoint.c: Fix common/ includes.
4633         * tracefile-tfile.c: Fix common/ includes.
4634         * top.h: Fix common/ includes.
4635         * top.c: Fix common/ includes.
4636         * thread.c: Fix common/ includes.
4637         * target/waitstatus.h: Fix common/ includes.
4638         * target/waitstatus.c: Fix common/ includes.
4639         * target.h: Fix common/ includes.
4640         * target.c: Fix common/ includes.
4641         * target-memory.c: Fix common/ includes.
4642         * target-descriptions.c: Fix common/ includes.
4643         * symtab.h: Fix common/ includes.
4644         * symfile.c: Fix common/ includes.
4645         * stap-probe.c: Fix common/ includes.
4646         * spu-linux-nat.c: Fix common/ includes.
4647         * sparc-nat.c: Fix common/ includes.
4648         * source.c: Fix common/ includes.
4649         * solib.c: Fix common/ includes.
4650         * solib-target.c: Fix common/ includes.
4651         * ser-unix.c: Fix common/ includes.
4652         * ser-tcp.c: Fix common/ includes.
4653         * ser-pipe.c: Fix common/ includes.
4654         * ser-base.c: Fix common/ includes.
4655         * selftest-arch.c: Fix common/ includes.
4656         * s12z-tdep.c: Fix common/ includes.
4657         * rust-exp.y: Fix common/ includes.
4658         * rs6000-aix-tdep.c: Fix common/ includes.
4659         * riscv-tdep.c: Fix common/ includes.
4660         * remote.c: Fix common/ includes.
4661         * remote-notif.h: Fix common/ includes.
4662         * remote-fileio.h: Fix common/ includes.
4663         * remote-fileio.c: Fix common/ includes.
4664         * regcache.h: Fix common/ includes.
4665         * regcache.c: Fix common/ includes.
4666         * record-btrace.c: Fix common/ includes.
4667         * python/python.c: Fix common/ includes.
4668         * python/py-type.c: Fix common/ includes.
4669         * python/py-inferior.c: Fix common/ includes.
4670         * progspace.h: Fix common/ includes.
4671         * producer.c: Fix common/ includes.
4672         * procfs.c: Fix common/ includes.
4673         * proc-api.c: Fix common/ includes.
4674         * printcmd.c: Fix common/ includes.
4675         * ppc-linux-nat.c: Fix common/ includes.
4676         * parser-defs.h: Fix common/ includes.
4677         * osdata.c: Fix common/ includes.
4678         * obsd-nat.c: Fix common/ includes.
4679         * nat/x86-linux.c: Fix common/ includes.
4680         * nat/x86-linux-dregs.c: Fix common/ includes.
4681         * nat/x86-dregs.h: Fix common/ includes.
4682         * nat/x86-dregs.c: Fix common/ includes.
4683         * nat/ppc-linux.c: Fix common/ includes.
4684         * nat/mips-linux-watch.h: Fix common/ includes.
4685         * nat/mips-linux-watch.c: Fix common/ includes.
4686         * nat/linux-waitpid.c: Fix common/ includes.
4687         * nat/linux-ptrace.h: Fix common/ includes.
4688         * nat/linux-ptrace.c: Fix common/ includes.
4689         * nat/linux-procfs.c: Fix common/ includes.
4690         * nat/linux-personality.c: Fix common/ includes.
4691         * nat/linux-osdata.c: Fix common/ includes.
4692         * nat/linux-namespaces.c: Fix common/ includes.
4693         * nat/linux-btrace.h: Fix common/ includes.
4694         * nat/linux-btrace.c: Fix common/ includes.
4695         * nat/fork-inferior.c: Fix common/ includes.
4696         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4697         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4698         * nat/aarch64-linux.c: Fix common/ includes.
4699         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4700         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4701         * namespace.h: Fix common/ includes.
4702         * mips-linux-tdep.c: Fix common/ includes.
4703         * minsyms.c: Fix common/ includes.
4704         * mi/mi-parse.h: Fix common/ includes.
4705         * mi/mi-main.c: Fix common/ includes.
4706         * mi/mi-cmd-env.c: Fix common/ includes.
4707         * memrange.h: Fix common/ includes.
4708         * memattr.c: Fix common/ includes.
4709         * maint.h: Fix common/ includes.
4710         * maint.c: Fix common/ includes.
4711         * main.c: Fix common/ includes.
4712         * machoread.c: Fix common/ includes.
4713         * location.c: Fix common/ includes.
4714         * linux-thread-db.c: Fix common/ includes.
4715         * linux-nat.c: Fix common/ includes.
4716         * linux-fork.c: Fix common/ includes.
4717         * inline-frame.c: Fix common/ includes.
4718         * infrun.c: Fix common/ includes.
4719         * inflow.c: Fix common/ includes.
4720         * inferior.h: Fix common/ includes.
4721         * inferior.c: Fix common/ includes.
4722         * infcmd.c: Fix common/ includes.
4723         * inf-ptrace.c: Fix common/ includes.
4724         * inf-child.c: Fix common/ includes.
4725         * ia64-linux-nat.c: Fix common/ includes.
4726         * i387-tdep.c: Fix common/ includes.
4727         * i386-tdep.c: Fix common/ includes.
4728         * i386-linux-tdep.c: Fix common/ includes.
4729         * i386-linux-nat.c: Fix common/ includes.
4730         * i386-go32-tdep.c: Fix common/ includes.
4731         * i386-fbsd-tdep.c: Fix common/ includes.
4732         * i386-fbsd-nat.c: Fix common/ includes.
4733         * guile/scm-type.c: Fix common/ includes.
4734         * guile/guile.c: Fix common/ includes.
4735         * go32-nat.c: Fix common/ includes.
4736         * gnu-nat.c: Fix common/ includes.
4737         * gdbthread.h: Fix common/ includes.
4738         * gdbarch-selftests.c: Fix common/ includes.
4739         * gdb_usleep.c: Fix common/ includes.
4740         * gdb_select.h: Fix common/ includes.
4741         * gdb_bfd.c: Fix common/ includes.
4742         * gcore.c: Fix common/ includes.
4743         * fork-child.c: Fix common/ includes.
4744         * findvar.c: Fix common/ includes.
4745         * fbsd-nat.c: Fix common/ includes.
4746         * event-top.c: Fix common/ includes.
4747         * event-loop.c: Fix common/ includes.
4748         * dwarf2read.c: Fix common/ includes.
4749         * dwarf2loc.c: Fix common/ includes.
4750         * dwarf2-frame.c: Fix common/ includes.
4751         * dwarf-index-cache.c: Fix common/ includes.
4752         * dtrace-probe.c: Fix common/ includes.
4753         * disasm-selftests.c: Fix common/ includes.
4754         * defs.h: Fix common/ includes.
4755         * csky-tdep.c: Fix common/ includes.
4756         * cp-valprint.c: Fix common/ includes.
4757         * cp-support.h: Fix common/ includes.
4758         * cp-support.c: Fix common/ includes.
4759         * corelow.c: Fix common/ includes.
4760         * completer.h: Fix common/ includes.
4761         * completer.c: Fix common/ includes.
4762         * compile/compile.c: Fix common/ includes.
4763         * compile/compile-loc2c.c: Fix common/ includes.
4764         * compile/compile-cplus-types.c: Fix common/ includes.
4765         * compile/compile-cplus-symbols.c: Fix common/ includes.
4766         * command.h: Fix common/ includes.
4767         * cli/cli-dump.c: Fix common/ includes.
4768         * cli/cli-cmds.c: Fix common/ includes.
4769         * charset.c: Fix common/ includes.
4770         * build-id.c: Fix common/ includes.
4771         * btrace.h: Fix common/ includes.
4772         * btrace.c: Fix common/ includes.
4773         * breakpoint.h: Fix common/ includes.
4774         * breakpoint.c: Fix common/ includes.
4775         * ax.h:
4776         (enum agent_op): Fix common/ includes.
4777         * ax-general.c (struct aop_map): Fix common/ includes.
4778         * ax-gdb.c: Fix common/ includes.
4779         * auxv.c: Fix common/ includes.
4780         * auto-load.c: Fix common/ includes.
4781         * arm-tdep.c: Fix common/ includes.
4782         * arch/riscv.c: Fix common/ includes.
4783         * arch/ppc-linux-common.c: Fix common/ includes.
4784         * arch/i386.c: Fix common/ includes.
4785         * arch/arm.c: Fix common/ includes.
4786         * arch/arm-linux.c: Fix common/ includes.
4787         * arch/arm-get-next-pcs.c: Fix common/ includes.
4788         * arch/amd64.c: Fix common/ includes.
4789         * arch/aarch64.c: Fix common/ includes.
4790         * arch/aarch64-insn.c: Fix common/ includes.
4791         * arch-utils.c: Fix common/ includes.
4792         * amd64-windows-tdep.c: Fix common/ includes.
4793         * amd64-tdep.c: Fix common/ includes.
4794         * amd64-sol2-tdep.c: Fix common/ includes.
4795         * amd64-obsd-tdep.c: Fix common/ includes.
4796         * amd64-nbsd-tdep.c: Fix common/ includes.
4797         * amd64-linux-tdep.c: Fix common/ includes.
4798         * amd64-linux-nat.c: Fix common/ includes.
4799         * amd64-fbsd-tdep.c: Fix common/ includes.
4800         * amd64-fbsd-nat.c: Fix common/ includes.
4801         * amd64-dicos-tdep.c: Fix common/ includes.
4802         * amd64-darwin-tdep.c: Fix common/ includes.
4803         * agent.c: Fix common/ includes.
4804         * ada-lang.h: Fix common/ includes.
4805         * ada-lang.c: Fix common/ includes.
4806         * aarch64-tdep.c: Fix common/ includes.
4807
4808 2019-01-25  Tom Tromey  <tom@tromey.com>
4809
4810         * common/create-version.sh: Use common/version.h.
4811
4812 2019-01-24  Pedro Alves  <palves@redhat.com>
4813
4814         * infrun.c (signal_stop, signal_print, signal_program)
4815         (signal_catch, signal_pass): Now arrays instead of pointers.
4816         (update_signals_program_target, do_target_resume)
4817         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4818         * linux-nat.c (linux_nat_target::pass_signals)
4819         (linux_nat_target::create_inferior, linux_nat_target::attach):
4820         Adjust.
4821         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4822         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4823         * procfs.c (procfs_target::pass_signals): Adjust.
4824         * record-full.c (record_full_target::resume): Adjust.
4825         * remote.c (remote_target::pass_signals)
4826         (remote_target::program_signals): Adjust.
4827         * target-debug.h (target_debug_print_signals): Now takes a
4828         gdb::array_view as parameter.  Adjust.
4829         * target.h (target_ops) <pass_signals, program_signals>: Replace
4830         pointer and length parameters with gdb::array_view.
4831         (target_pass_signals, target_program_signals): Likewise.
4832         * target-delegates.c: Regenerate.
4833
4834 2019-01-24  Pedro Alves  <palves@redhat.com>
4835
4836         * common/forward-scope-exit.h
4837         (forward_scope_exit::forward_scope_exit): Pass arguments to
4838         m_bind_function directly, instead of creating a std::bind and
4839         copying that.
4840
4841 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4842
4843         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4844         for static members.
4845         (pass_in_v_vfp_candidate): Likewise.
4846
4847 2019-01-23  Tom Tromey  <tom@tromey.com>
4848             Pedro Alves  <palves@redhat.com>
4849
4850         * regcache.c (class regcache_invalidator): Remove.
4851         (regcache::raw_write): Use make_scope_exit.
4852
4853 2019-01-23  Tom Tromey  <tom@tromey.com>
4854
4855         * ui-out.h (class ui_out_emit_type): Update comment.
4856
4857 2019-01-23  Tom Tromey  <tom@tromey.com>
4858
4859         * infrun.c (fetch_inferior_event): Update comment.
4860
4861 2019-01-23  Tom Tromey  <tom@tromey.com>
4862             Pedro Alves  <palves@redhat.com>
4863
4864         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4865         parameter.
4866         (fetch_inferior_event): Use SCOPE_EXIT.
4867
4868
4869 2019-01-23  Tom Tromey  <tom@tromey.com>
4870             Pedro Alves  <palves@redhat.com>
4871
4872         * infrun.c (disable_thread_events): Delete.
4873         (stop_all_threads): Use SCOPE_EXIT.
4874
4875 2019-01-23  Tom Tromey  <tom@tromey.com>
4876             Pedro Alves  <palves@redhat.com>
4877
4878         * symfile.c: Include forward-scope-exit.h.
4879         (clear_symtab_users_cleanup): Replace forward declaration with
4880         a FORWARD_SCOPE_EXIT.
4881         (syms_from_objfile_1): Use the forward_scope_exit and
4882         gdb::optional instead of cleanup_function.
4883         (reread_symbols): Use the forward_scope_exit instead of
4884         cleanup_function.
4885         (clear_symtab_users_cleanup): Remove function.
4886
4887 2019-01-23  Tom Tromey  <tom@tromey.com>
4888             Pedro Alves  <palves@redhat.com>
4889
4890         * linux-nat.c: Include scope-exit.h.
4891         (cleanup_target_stop): Remove.
4892         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4893         SCOPE_EXIT.
4894
4895 2019-01-23  Tom Tromey  <tom@tromey.com>
4896             Pedro Alves  <palves@redhat.com>
4897
4898         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4899         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4900
4901 2019-01-23  Tom Tromey  <tom@tromey.com>
4902             Andrew Burgess  <andrew.burgess@embecosm.com>
4903             Pedro Alves  <palves@redhat.com>
4904
4905         * infrun.c (fetch_inferior_event): Use scope_exit.
4906         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4907         * top.c (execute_command): Use scope_exit.
4908         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4909         * utils.c (do_bpstat_clear_actions_cleanup)
4910         (make_bpstat_clear_actions_cleanup): Remove.
4911
4912 2019-01-23  Tom Tromey  <tom@tromey.com>
4913             Pedro Alves  <palves@redhat.com>
4914
4915         * infrun.c: Include "common/scope-exit.h"
4916         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4917         (wait_for_inferior): Use SCOPE_EXIT.
4918         (fetch_inferior_event): Use scope_exit.
4919
4920 2019-01-23  Tom Tromey  <tom@tromey.com>
4921             Pedro Alves  <palves@redhat.com>
4922
4923         * breakpoint.c (create_breakpoint): Remove cleanup.
4924
4925 2019-01-23  Tom Tromey  <tom@tromey.com>
4926             Andrew Burgess  <andrew.burgess@embecosm.com>
4927             Pedro Alves  <palves@redhat.com>
4928
4929 2019-01-23  Pedro Alves  <palves@redhat.com>
4930
4931         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4932
4933 2019-01-23  Pedro Alves  <palves@redhat.com>
4934             Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * gdbthread.h: Include "common/forward-scope-exit.h".
4937         (scoped_finish_thread_state): Redefine custom class in terms of
4938         forward_scope_exit.
4939
4940 2019-01-23  Pedro Alves  <palves@redhat.com>
4941             Andrew Burgess  <andrew.burgess@embecosm.com>
4942
4943         * common/forward-scope-exit.h: New file.
4944
4945 2019-01-23  Pedro Alves  <palves@redhat.com>
4946             Andrew Burgess  <andrew.burgess@embecosm.com>
4947             Tom Tromey  <tom@tromey.com>
4948
4949         * common/scope-exit.h: New file.
4950
4951 2019-01-23  Pedro Alves  <palves@redhat.com>
4952
4953         * common/preprocessor.h (ESC): Rename to ...
4954         (ESC_PARENS): ... this.
4955         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4956         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4957
4958 2019-01-23  Tom Tromey  <tom@tromey.com>
4959
4960         * language.h (class scoped_switch_to_sym_language_if_auto):
4961         Initialize m_lang in both cases.
4962
4963 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4964
4965         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4966         with XCNEW.
4967
4968 2019-01-22  Tom Tromey  <tom@tromey.com>
4969
4970         * corelow.c: Do not include sys/file.h.
4971
4972 2019-01-22  Tom Tromey  <tom@tromey.com>
4973
4974         * tui/tui-wingeneral.h: Include gdb_curses.h.
4975
4976 2019-01-22  Tom Tromey  <tom@tromey.com>
4977
4978         * source-cache.h (class source_cache) <get_source_lines,
4979         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4980
4981 2019-01-22  Tom Tromey  <tom@tromey.com>
4982
4983         * remote-fileio.h (struct remote_target): Declare.
4984
4985 2019-01-22  Tom Tromey  <tom@tromey.com>
4986
4987         * python/py-arch.c: Do not include py-ref.h.
4988         * python/py-bpevent.c: Do not include py-ref.h.
4989         * python/py-cmd.c: Do not include py-ref.h.
4990         * python/py-continueevent.c: Do not include py-ref.h.
4991         * python/py-event.h: Do not include py-ref.h.
4992         * python/py-evtregistry.c: Do not include py-ref.h.
4993         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4994         * python/py-frame.c: Do not include py-ref.h.
4995         * python/py-framefilter.c: Do not include py-ref.h.
4996         * python/py-function.c: Do not include py-ref.h.
4997         * python/py-infevents.c: Do not include py-ref.h.
4998         * python/py-linetable.c: Do not include py-ref.h.
4999         * python/py-objfile.c: Do not include py-ref.h.
5000         * python/py-param.c: Do not include py-ref.h.
5001         * python/py-prettyprint.c: Do not include py-ref.h.
5002         * python/py-progspace.c: Do not include py-ref.h.
5003         * python/py-symbol.c: Do not include py-ref.h.
5004         * python/py-symtab.c: Do not include py-ref.h.
5005         * python/py-type.c: Do not include py-ref.h.
5006         * python/py-unwind.c: Do not include py-ref.h.
5007         * python/py-utils.c: Do not include py-ref.h.
5008         * python/py-value.c: Do not include py-ref.h.
5009         * python/py-varobj.c: Do not include py-ref.h.
5010         * python/py-xmethods.c: Do not include py-ref.h.
5011         * python/python.c: Do not include py-ref.h.
5012         * varobj.c: Do not include py-ref.h.
5013
5014 2019-01-22  Tom Tromey  <tom@tromey.com>
5015
5016         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5017         keyword for bcache.
5018
5019 2019-01-22  Tom Tromey  <tom@tromey.com>
5020
5021         * compile/compile-cplus-types.c: Remove a comment by #include.
5022
5023 2019-01-22  Tom Tromey  <tom@tromey.com>
5024
5025         * compile/gcc-c-plugin.h: Include compile-internal.h.
5026
5027 2019-01-22  Tom Tromey  <tom@tromey.com>
5028
5029         * stabsread.c (EXTERN): Do not define.
5030         (symnum, next_symbol_text_func, processing_gcc_compilation)
5031         (within_function, global_sym_chain, global_stabs)
5032         (previous_stab_code, this_object_header_files)
5033         (n_this_object_header_files)
5034         (n_allocated_this_object_header_files): Define.
5035         * stabsread.h (EXTERN): Never define.  Use "extern".
5036
5037 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5038
5039         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5040         history_value.
5041
5042 2019-01-21  Tom Tromey  <tom@tromey.com>
5043
5044         * ui-out.c: Fix includes.
5045         * tui/tui-source.c: Fix includes.
5046         * target.c: Fix includes.
5047         * remote.c: Fix includes.
5048         * regcache.c: Fix includes.
5049         * python/py-block.c: Fix includes.
5050         * printcmd.c: Fix includes.
5051         * or1k-tdep.c: Fix includes.
5052         * mi/mi-main.c: Fix includes.
5053         * m32r-tdep.c: Fix includes.
5054         * csky-tdep.c: Fix includes.
5055         * compile/compile-cplus-types.c: Fix includes.
5056         * cli/cli-interp.c: Fix includes.
5057
5058 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5059
5060         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5061         for padding.
5062
5063 2019-01-16  Tom Tromey  <tom@tromey.com>
5064
5065         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5066         earlier.
5067         (struct objfile) <msymbols_range>: Move from top level.
5068         <msymbols>: New method.
5069         (class objfile_msymbols): Remove.
5070         * symtab.c (default_collect_symbol_completion_matches_break_on):
5071         Update.
5072         * symmisc.c (dump_msymbols): Update.
5073         * stabsread.c (scan_file_globals): Update.
5074         * objc-lang.c (info_selectors_command, info_classes_command)
5075         (find_methods): Update.
5076         * minsyms.c (find_solib_trampoline_target): Update.
5077         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5078         * coffread.c (coff_symfile_read): Update.
5079         * ada-lang.c (ada_lookup_simple_minsym)
5080         (ada_collect_symbol_completion_matches): Update.
5081
5082 2019-01-16  Tom Tromey  <tom@tromey.com>
5083
5084         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5085         type.  Remove no-argument constructor.
5086         <iterator::operator++>: Simplify.
5087         <begin>: Update.
5088         <end>: Use minimal_symbol_count.
5089
5090 2019-01-16  Tom Tromey  <tom@tromey.com>
5091
5092         * objfiles.h (struct objfile) <psymtabs>: New method.
5093         (class objfile_psymtabs): Remove.
5094         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5095         typedef.
5096         <range>: New method.
5097         (require_partial_symbols): Change return type.
5098         * psymtab.c (require_partial_symbols)
5099         (psym_expand_symtabs_matching): Update.
5100         * mdebugread.c (parse_partial_symbols): Update.
5101         * dbxread.c (dbx_end_psymtab): Update.
5102
5103 2019-01-15  Tom Tromey  <tom@tromey.com>
5104
5105         * symtab.c (lookup_objfile_from_block)
5106         (lookup_symbol_in_objfile_symtabs)
5107         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5108         (find_line_symtab, info_sources_command)
5109         (default_collect_symbol_completion_matches_break_on)
5110         (make_source_files_completion_list): Update.
5111         * symmisc.c (print_objfile_statistics, dump_objfile)
5112         (maintenance_print_symbols, maintenance_info_symtabs)
5113         (maintenance_check_symtabs, maintenance_info_line_tables):
5114         Update.
5115         * source.c (select_source_symtab)
5116         (forget_cached_source_info_for_objfile): Update.
5117         * objfiles.h (class objfile_compunits): Remove.
5118         (struct objfile) <compunits_range>: New typedef.
5119         (compunits): New method.
5120         * objfiles.c (objfile_relocate1): Update.
5121         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5122         * maint.c (count_symtabs_and_blocks): Update.
5123         * linespec.c (iterate_over_all_matching_symtabs): Update.
5124         * cp-support.c (add_symbol_overload_list_qualified): Update.
5125         * coffread.c (coff_symtab_read): Update.
5126         * ada-lang.c (add_nonlocal_symbols)
5127         (ada_collect_symbol_completion_matches)
5128         (ada_add_global_exceptions): Update.
5129
5130 2019-01-15  Tom Tromey  <tom@tromey.com>
5131
5132         * progspace.h (program_space) <objfiles_safe_range>: New
5133         typedef.
5134         <objfiles_safe>: New method.
5135         * objfiles.h (class all_objfiles_safe): Remove.
5136         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5137         * jit.c (jit_inferior_exit_hook): Update.
5138
5139 2019-01-17  Tom Tromey  <tom@tromey.com>
5140
5141         * progspace.h (program_space) <objfiles_range>: New typedef.
5142         <objfiles>: New method.
5143         <objfiles_head>: Rename from objfiles.
5144         (object_files): Update.
5145         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5146         * guile/scm-pretty-print.c
5147         (ppscm_find_pretty_printer_from_objfiles): Update.
5148         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5149         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5150         Update.
5151         * python/py-progspace.c (pspy_get_objfiles): Update.
5152         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5153         Update.
5154         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5155         (objfpy_lookup_objfile_by_build_id): Update.
5156         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5157         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5158         Update.
5159         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5160         (expand_symtab_containing_pc, lookup_objfile_from_block)
5161         (lookup_static_symbol, basic_lookup_transparent_type)
5162         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5163         (find_line_symtab, info_sources_command)
5164         (default_collect_symbol_completion_matches_break_on)
5165         (make_source_files_completion_list, find_main_name): Update.
5166         * symmisc.c (print_symbol_bcache_statistics)
5167         (print_objfile_statistics, maintenance_print_symbols)
5168         (maintenance_print_msymbols, maintenance_print_objfiles)
5169         (maintenance_info_symtabs, maintenance_check_symtabs)
5170         (maintenance_expand_symtabs, maintenance_info_line_tables):
5171         Update.
5172         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5173         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5174         (map_overlay_command, unmap_overlay_command)
5175         (simple_overlay_update, expand_symtabs_matching)
5176         (map_symbol_filenames): Update.
5177         * symfile-debug.c (set_debug_symfile): Update.
5178         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5179         Update.
5180         * source.c (select_source_symtab, forget_cached_source_info):
5181         Update.
5182         * solib.c (solib_read_symbols): Update.
5183         * solib-spu.c (append_ocl_sos): Update.
5184         * psymtab.c (maintenance_print_psymbols)
5185         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5186         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5187         * printcmd.c (info_symbol_command): Update.
5188         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5189         Update.
5190         * objfiles.h (class all_objfiles): Remove.
5191         * objfiles.c (have_partial_symbols, have_full_symbols)
5192         (have_minimal_symbols, qsort_cmp, update_section_map)
5193         (shared_objfile_contains_address_p)
5194         (default_iterate_over_objfiles_in_search_order): Update.
5195         * objc-lang.c (info_selectors_command, info_classes_command)
5196         (find_methods): Update.
5197         * minsyms.c (find_solib_trampoline_target): Update.
5198         * maint.c (maintenance_info_sections)
5199         (maintenance_translate_address, count_symtabs_and_blocks):
5200         Update.
5201         * main.c (captured_main_1): Update.
5202         * linux-thread-db.c (try_thread_db_load_from_pdir)
5203         (has_libpthread): Update.
5204         * linespec.c (iterate_over_all_matching_symtabs)
5205         (search_minsyms_for_name): Update.
5206         * jit.c (jit_find_objf_with_entry_addr): Update.
5207         * hppa-tdep.c (find_unwind_entry)
5208         (hppa_lookup_stub_minimal_symbol): Update.
5209         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5210         Update.
5211         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5212         (elf_gnu_ifunc_resolve_by_got): Update.
5213         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5214         * dwarf-index-write.c (save_gdb_index_command): Update.
5215         * cp-support.c (add_symbol_overload_list_qualified): Update.
5216         * breakpoint.c (create_overlay_event_breakpoint)
5217         (create_longjmp_master_breakpoint)
5218         (create_std_terminate_master_breakpoint)
5219         (create_exception_master_breakpoint): Update.
5220         * blockframe.c (find_pc_partial_function): Update.
5221         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5222         (ada_collect_symbol_completion_matches)
5223         (ada_add_global_exceptions): Update.
5224
5225 2019-01-17  Tom Tromey  <tom@tromey.com>
5226
5227         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5228         declare VEC.
5229         (solib_target_parse_libraries): Change return type.
5230         (library_list_start_segment, library_list_start_section)
5231         (library_list_end_library, library_list_start_library); Update.
5232         (solib_target_free_library_list): Remove.
5233         (solib_target_parse_libraries): Remove cleanup.  Change return
5234         type.
5235         (solib_target_current_sos): Update.
5236
5237 2019-01-17  Tom Tromey  <tromey@bapiya>
5238
5239         * valprint.c: Replace "the the" with "the".
5240         * symtab.c: Replace "the the" with "the".
5241         * solib.c: Replace "the the" with "the".
5242         * solib-dsbt.c: Replace "the the" with "the".
5243         * linespec.c: Replace "the the" with "the".
5244         * dwarf2loc.h: Replace "the the" with "the".
5245         * amd64-windows-tdep.c: Replace "the the" with "the".
5246         * aarch64-tdep.c: Replace "the the" with "the".
5247
5248 2019-01-16  Keith Seitz  <keiths@redhat.com>
5249
5250         PR gdb/23773
5251         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5252         <builder>: Rename to ..
5253         <m_builder>: ... this and make private.
5254         (dwarf2_cu::get_builder): New method.  Change all users of
5255         `builder' to use this method.
5256         (dwarf2_start_symtab): Move to ...
5257         (dwarf2_cu::start_symtab): ... here.  Update all callers
5258         (setup_type_unit_groups): Move to ...
5259         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5260         callers.
5261         (dwarf2_cu::reset_builder): New method.
5262         (process_full_compunit, process_full_type_unit): Use
5263         dwarf2_cu::reset_builder.
5264         (follow_die_offset): Record the ancestor CU if it is different
5265         from the followed DIE's CU.
5266         (follow_die_sig_1): Likewise.
5267
5268 2019-01-15  Tom Tromey  <tom@tromey.com>
5269
5270         * remote.c (class remote_state) <buf>: Now a char_vector.
5271         <buf_size>: Remove.
5272         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5273         parameter.
5274         (remote_target::getpkt_or_notif_sane_1)
5275         (remote_target::getpkt_sane)
5276         (remote_target::getpkt_or_notif_sane): Likewise.
5277         (class remote_target) <putpkt>: New overload.
5278         (remote_target::read_frame): Change type of "buf_p".  Remove
5279         sizeof_p parameter.
5280         (packet_ok): New overload.
5281         (packet_check_result): New overload.
5282         Update all uses.
5283
5284 2019-01-14  Tom Tromey  <tom@tromey.com>
5285
5286         * remote-notif.c (handle_notification, remote_notif_ack)
5287         (remote_notif_parse): Make "buf" const.
5288         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5289         const.
5290         (remote_notif_parse, remote_notif_ack, handle_notification):
5291         Likewise.
5292         * remote.c (remote_notif_stop_parse): Make "buf" const.
5293         (remote_target::remote_parse_stop_reply): Make "buf" const.
5294         (remote_notif_stop_ack): Make "buf" const.
5295
5296 2019-01-14  Tom Tromey  <tom@tromey.com>
5297
5298         * remote.c (remote_console_output): Make parameter const.
5299
5300 2019-01-14  Tom Tromey  <tom@tromey.com>
5301
5302         * target-debug.h (target_debug_print_signals): Constify.
5303         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5304         * procfs.c (procfs_target::pass_signals): Update.
5305         * linux-nat.c (linux_nat_target::pass_signals): Update.
5306         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5307         * target-delegates.c: Rebuild.
5308         * remote.c (remote_target::program_signals): Update.
5309         (remote_target::pass_signals): Update.
5310         * target.c (target_pass_signals): Constify argument.
5311         (target_program_signals): Likewise.
5312         * target.h (struct target_ops) <pass_signals, program_signals>:
5313         Constify argument.
5314         (target_pass_signals, target_program_signals): Constify argument.
5315
5316 2019-01-14  Tom Tromey  <tom@tromey.com>
5317
5318         PR tui/28819:
5319         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5320
5321 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5322
5323         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5324         field.
5325         * rs6000-tdep.c: Include reggroups.h.
5326         (IS_V_ALIAS_PSEUDOREG): Define.
5327         (rs6000_register_name): Return names for the "vX" aliases.
5328         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5329         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5330         aliases.  Call default_register_reggroup_p for all other
5331         pseudo-registers.
5332         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5333         New functions.
5334         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5335         Handle "vX" aliases.
5336         (v_alias_pseudo_register_collect): New function.
5337         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5338         (rs6000_gdbarch_init): Initialize "vX" aliases as
5339         pseudo-registers.  Restore registration of
5340         rs6000_pseudo_register_reggroup_p with
5341         set_tdesc_pseudo_register_reggroup_p.
5342
5343 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5344
5345         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5346         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5347         set_gdbarch_num_pseudo_regs.
5348
5349 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5350
5351         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5352         Remove arg prefixname, add do_set and do_show.
5353         Add member functions set_list and show_list.
5354         * cli/cli-style.c (class cli_style_option): Update accordingly.
5355         (style_set_list): Move to file scope.
5356         (style_show_list): Likewise.
5357         (set_style): Call help_list.
5358         (show_style): Call cmd_show_list.
5359         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5360         Update to use the new macro.
5361
5362 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5363
5364         * ada-lang.c (_initialize_ada_language): Expand the help text
5365         for the "catch exception" command.
5366
5367 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5368
5369         * symtab.c (matching_obj_sections): Initialize obj,
5370         declare it closer to its usage.
5371
5372 2019-01-10  Tom Tromey  <tom@tromey.com>
5373
5374         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5375         (basic_inf_threads_range): Remove.
5376         (inf_threads_range, inf_non_exited_threads_range)
5377         (safe_inf_threads_range): Use next_adapter.
5378
5379 2019-01-10  Keith Seitz  <keiths@redhat.com>
5380
5381         PR gdb/23712
5382         PR symtab/23010
5383         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5384         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5385
5386 2019-01-10  Keith Seitz  <keiths@redhat.com>
5387
5388         PR gdb/23712
5389         PR symtab/23010
5390         * dictionary.c (pending_to_vector): Remove.
5391         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5392         Remove _1 suffix, replacing functions of the same name.  Update
5393         all callers.
5394         (dict_create_hashed, dict_create_hashed_expandable)
5395         (dict_create_linear, dict_create_linear_expandable, dict_free)
5396         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5397         Make functions static.
5398
5399 2019-01-10  Keith Seitz  <keiths@redhat.com>
5400
5401         PR gdb/23712
5402         PR symtab/23010
5403         * dictionary.h (struct dictionary): Replace declaration with
5404         multidictionary.
5405         (dict_create_hashed, dict_create_hashed_expandable)
5406         (dict_create_linear, dict_create_linear_expandable)
5407         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5408         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5409         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5410         taking multidictionary argument.
5411         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5412         * block.h (struct block) <dict>: Change to multidictionary
5413         and rename `multidict'.
5414         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5415         symmisc.c: Update all dictionary references to multidictionary.
5416
5417 2019-01-10  Keith Seitz  <keiths@redhat.com>
5418
5419         PR gdb/23712
5420         PR symtab/23010
5421         * dictionary.c: Include unordered_map.
5422         (pending_to_vector): New function.
5423         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5424         Rewrite the non-"_1" functions to take vector instead
5425         of linked list.
5426         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5427         "new" _1 versions of the same name.
5428         (multidictionary): Define.
5429         (std::hash<enum language): New definition.
5430         (collate_pending_symbols_by_language, mdict_create_hashed)
5431         (mdict_create_hashed_expandable, mdict_create_linear)
5432         (mdict_create_linear_expandable, mdict_free)
5433         (find_language_dictionary, create_new_language_dictionary)
5434         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5435         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5436         (mdict_size, mdict_empty): New functions.
5437         * dictionary.h (mdict_iterator): Define.
5438
5439 2019-01-10  Pedro Alves  <palves@redhat.com>
5440
5441         * breakpoint.c (read_uploaded_action)
5442         (create_tracepoint_from_upload): Adjust to use
5443         gdb::unique_xmalloc_ptr.
5444         * ctf.c (ctf_write_uploaded_tp):
5445         (SET_ARRAY_FIELD): Use emplace_back.
5446         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5447         * tracefile-tfile.c (tfile_write_uploaded_tp):
5448         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5449         gdb::unique_xmalloc_ptr.
5450         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5451         at_string, cond_string, cmd_strings>: Replace char pointers
5452         with gdb::unique_xmalloc_ptr.
5453
5454 2019-01-10  Pedro Alves  <palves@redhat.com>
5455
5456         * solib-target.c (library_list_start_library): Don't xstrdup name.
5457
5458 2019-01-10  Pedro Alves  <palves@redhat.com>
5459
5460         * mdebugread.c (parse_partial_symbols): Use
5461         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5462
5463 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5464
5465         * linux-fork.c (scoped_switch_fork_info)
5466         <~scoped_switch_fork_info>: Fix incorrect variable name.
5467
5468 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5469
5470         * linux-fork.c (scoped_switch_fork_info)
5471         <scoped_switch_fork_info>: Make explicit.
5472         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5473
5474 2019-01-10  Tom Tromey  <tom@tromey.com>
5475
5476         * objfiles.h (objfile::reset_psymtabs): Update.
5477         * objfiles.c (objfile::objfile): Update.
5478         * psymtab.h (psymtab_storage::obstack): Update.
5479         (psymtab_storage::m_obstack): Use gdb::optional.
5480         (class psymtab_storage): Update comment.  Remove objfile
5481         parameter.
5482         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5483
5484 2019-01-10  Tom Tromey  <tom@tromey.com>
5485
5486         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5487         <free_psymtabs>: Now private.
5488         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5489         (allocate_psymtab): Use new method.
5490
5491 2019-01-10  Tom Tromey  <tom@tromey.com>
5492
5493         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5494         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5495         * mdebugread.c (parse_partial_symbols): Use
5496         allocate_dependencies.
5497         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5498         allocate_dependencies.
5499         (process_psymtab_comp_unit_reader)
5500         (build_type_psymtab_dependencies): Likewise.
5501         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5502
5503 2019-01-10  Tom Tromey  <tom@tromey.com>
5504
5505         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5506         PSYMBOL_SET_LANGUAGE.
5507         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5508
5509 2019-01-10  Tom Tromey  <tom@tromey.com>
5510
5511         * psymtab.h (psymtab_storage::obstack): New method.
5512         <m_obstack>: Rename from obstack; now private.
5513         * psymtab.c (psymtab_storage): Update.
5514         * dwarf2read.c (create_addrmap_from_index)
5515         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5516         Update.
5517
5518 2019-01-10  Tom Tromey  <tom@tromey.com>
5519
5520         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5521         * objfiles.h (objfile::reset_psymtabs): New method.
5522
5523 2019-01-10  Tom Tromey  <tom@tromey.com>
5524
5525         * symmisc.c (print_symbol_bcache_statistics): Update.
5526         (print_objfile_statistics): Update.
5527         * symfile.c (reread_symbols): Update.
5528         * psymtab.h (class psymtab_storage): New.
5529         * psymtab.c (psymtab_storage): New constructor.
5530         (~psymtab_storage): New destructor.
5531         (require_partial_symbols): Update.
5532         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5533         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5534         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5535         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5536         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5537         (start_psymtab_common, end_psymtab_common)
5538         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5539         (allocate_psymtab): Update.
5540         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5541         Update.
5542         (dump_psymtab_addrmap, maintenance_print_psymbols)
5543         (maintenance_check_psymtabs): Update.
5544         (class objfile_psymtabs): Move to objfiles.h.
5545         * psympriv.h (discard_psymtab): Now inline.
5546         (psymtab_discarder::psymtab_discarder): Update.
5547         (psymtab_discarder::~psymtab_discarder): Update.
5548         (ALL_OBJFILE_PSYMTABS): Rewrite.
5549         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5550         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5551         Remove fields.
5552         <partial_symtabs>: New field.
5553         (class objfile_psymtabs): Move from psymtab.h.  Update.
5554         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5555         psymbol_cache.
5556         (objfile::~objfile): Don't destroy psymbol_cache.
5557         * mdebugread.c (parse_partial_symbols): Update.
5558         * dwarf2read.c (create_addrmap_from_index)
5559         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5560         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5561         (add_partial_subprogram, dwarf2_ranges_read): Update.
5562         * dwarf-index-write.c (write_address_map)
5563         (write_one_signatured_type, recursively_write_psymbols)
5564         (class debug_names, class debug_names, write_psymtabs_to_index):
5565         Update.
5566
5567 2019-01-10  Tom Tromey  <tom@tromey.com>
5568
5569         * symtab.h (SYMBOL_SET_NAMES): Update.
5570         (symbol_set_names): Update.
5571         (MSYMBOL_SET_NAMES): Update.
5572         * symtab.c (symbol_set_names): Change argument to be an
5573         objfile_per_bfd_storage.
5574         * psymtab.c (add_psymbol_to_bcache): Update.
5575         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5576
5577 2019-01-10  Tom Tromey  <tom@tromey.com>
5578
5579         * symtab.c (create_demangled_names_hash): Change argument to be an
5580         objfile_per_bfd_storage.
5581         (symbol_set_names): Update.
5582
5583 2019-01-10  Tom Tromey  <tom@tromey.com>
5584
5585         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5586         init_psymbol_list.
5587         * psymtab.c (init_psymbol_list): Do nothing if already called.
5588         * psympriv.h (init_psymbol_list): Add comment.
5589         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5590         init_psymbol_list.
5591         * dbxread.c (dbx_symfile_read): Unconditionally call
5592         init_psymbol_list.
5593
5594 2019-01-10  Tom Tromey  <tom@tromey.com>
5595
5596         * xcoffread.c (scan_xcoff_symtab): Update.
5597         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5598         "where".
5599         * mdebugread.c (parse_partial_symbols)
5600         (handle_psymbol_enumerators): Update.
5601         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5602         * dbxread.c (read_dbx_symtab): Update.
5603         * psympriv.h (psymbol_placement): New enum.
5604         (add_psymbol_to_list): Update.
5605
5606 2019-01-10  Tom Tromey  <tom@tromey.com>
5607
5608         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5609         static_psymbols parameters.
5610         (scan_xcoff_symtab): Update.
5611         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5612         static_psymbols parameters.
5613         * psympriv.h (start_psymtab_common): Update.
5614         * mdebugread.c (parse_partial_symbols): Update.
5615         * dwarf2read.c (create_partial_symtab): Update.
5616         * dbxread.c (read_dbx_symtab): Update.
5617         (start_psymtab): Remove global_psymbols and static_psymbols
5618         parameters.
5619
5620 2019-01-10  Tom Tromey  <tom@tromey.com>
5621
5622         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5623         * psymtab.c (allocate_psymtab): Add comment.
5624         * psympriv.h (allocate_psymtab): Add comment.
5625         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5626         initializations.
5627         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5628
5629 2019-01-10  Tom Tromey  <tom@tromey.com>
5630
5631         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5632         Don't declare.
5633         * mipsread.c: Include mdebugread.h.
5634         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5635         Declare.
5636         * elfread.c: Include mdebugread.h.
5637
5638 2019-01-09  Tom Tromey  <tom@tromey.com>
5639
5640         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5641         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5642         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5643         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5644         (psym_lookup_symbol, psym_find_last_source_symtab)
5645         (psym_forget_cached_source_info, psym_print_stats)
5646         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5647         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5648         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5649         (psym_find_compunit_symtab_by_address)
5650         (maintenance_print_psymbols, maintenance_info_psymtabs)
5651         (maintenance_check_psymtabs): Use ranged for.
5652         * psymtab.h (class objfile_psymtabs): New.
5653         (require_partial_symbols): Return objfile_psymtabs.
5654         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5655
5656 2019-01-09  Tom Tromey  <tom@tromey.com>
5657
5658         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5659         (find_pc_mapped_section, list_overlays_command)
5660         (map_overlay_command, unmap_overlay_command)
5661         (simple_overlay_update): Use all_objfiles.
5662         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5663         * printcmd.c (info_symbol_command): Use all_objfiles.
5664         * objfiles.h (ALL_OBJSECTIONS): Remove.
5665         * maint.c (maintenance_translate_address): Use all_objfiles.
5666         * gcore.c (gcore_create_callback): Use all_objfiles.
5667         (objfile_find_memory_regions): Likewise.
5668
5669 2019-01-09  Tom Tromey  <tom@tromey.com>
5670
5671         * symtab.c (find_line_symtab, info_sources_command)
5672         (make_source_files_completion_list): Use objfile_compunits.
5673         * source.c (select_source_symtab): Use objfile_compunits.
5674         * objfiles.h (struct objfile): Update comment.
5675         (ALL_OBJFILES): Remove.
5676         (ALL_FILETABS): Remove.
5677         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5678         objfile_compunits.
5679
5680 2019-01-09  Tom Tromey  <tom@tromey.com>
5681
5682         * symmisc.c (print_objfile_statistics, dump_objfile)
5683         (maintenance_print_symbols): Use compunit_filetabs.
5684         * source.c (forget_cached_source_info_for_objfile): Use
5685         compunit_filetabs.
5686         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5687         (ALL_FILETABS): Use compunit_filetabs.
5688         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5689         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5690
5691 2019-01-09  Tom Tromey  <tom@tromey.com>
5692
5693         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5694         (compunit_filetabs): New.
5695         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5696         compunit_filetabs.
5697         (info_sources_command, make_source_files_completion_list): Remove
5698         declaration.
5699         * symmisc.c (print_objfile_statistics, dump_objfile)
5700         (maintenance_print_symbols): Remove declaration.
5701         (maintenance_info_symtabs): Use compunit_filetabs.
5702         (maintenance_info_line_tables): Likewise.
5703         * source.c (select_source_symtab): Change local variable name.
5704         (forget_cached_source_info_for_objfile): Remove declaration.
5705         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5706         * objfiles.c (objfile_relocate1): Remove declaration.
5707         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5708         declaration.
5709         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5710         * coffread.c (coff_symtab_read): Remove declaration.
5711         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5712         compunit_filetabs.
5713
5714 2019-01-09  Tom Tromey  <tom@tromey.com>
5715
5716         * symtab.c (lookup_objfile_from_block)
5717         (find_pc_sect_compunit_symtab, search_symbols)
5718         (default_collect_symbol_completion_matches_break_on): Use
5719         objfile_compunits.
5720         * objfiles.h (ALL_COMPUNITS): Remove.
5721         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5722         * cp-support.c (add_symbol_overload_list_qualified): Use
5723         objfile_compunits.
5724         * ada-lang.c (ada_collect_symbol_completion_matches)
5725         (ada_add_global_exceptions): Use objfile_compunits.
5726
5727 2019-01-09  Tom Tromey  <tom@tromey.com>
5728
5729         * source.c (select_source_symtab)
5730         (forget_cached_source_info_for_objfile): Remove declaration.
5731         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5732         declaration.
5733         * maint.c (count_symtabs_and_blocks): Remove declaration.
5734         * cp-support.c (add_symbol_overload_list_qualified): Remove
5735         declaration.
5736         * coffread.c (coff_symtab_read): Remove declaration.
5737         * symtab.c (lookup_symbol_in_objfile_symtabs)
5738         (basic_lookup_transparent_type_1): Use objfile_compunits.
5739         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5740         (info_sources_command, search_symbols)
5741         (default_collect_symbol_completion_matches_break_on)
5742         (make_source_files_completion_list): Remove declaration.
5743         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5744         (ada_collect_symbol_completion_matches)
5745         (ada_add_global_exceptions): Remove declaration.
5746         * linespec.c (iterate_over_all_matching_symtabs): Use
5747         objfile_compunits.
5748         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5749         (class objfile_compunits): New.
5750         (ALL_COMPUNITS): Use objfile_compunits.
5751         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5752         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5753         objfile_compunits.
5754         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5755
5756 2019-01-09  Tom Tromey  <tom@tromey.com>
5757
5758         * symtab.c (search_symbols)
5759         (default_collect_symbol_completion_matches_break_on): Use
5760         objfile_msymbols.
5761         * ada-lang.c (ada_lookup_simple_minsym)
5762         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5763         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5764         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5765         objfile_msymbols.
5766         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5767         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5768         * objc-lang.c (find_methods): Use objfile_msymbols.
5769         (info_selectors_command, info_classes_command): Likewise.
5770         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5771         * objfiles.h (class objfile_msymbols): New.
5772         (ALL_OBJFILE_MSYMBOLS): Remove.
5773         (ALL_MSYMBOLS): Remove.
5774
5775 2019-01-09  Tom Tromey  <tom@tromey.com>
5776
5777         * common/next-iterator.h (next_adapter): Add Iterator template
5778         parameter.
5779         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5780         (class all_objfiles_safe): New.
5781         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5782         * objfiles.c (put_objfile_before): Update comment.
5783         (add_separate_debug_objfile): Likewise.
5784         (free_all_objfiles): Use all_objfiles_safe.
5785         (objfile_purge_solibs): Likewise.
5786
5787 2019-01-09  Tom Tromey  <tom@tromey.com>
5788
5789         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5790         (expand_symtab_containing_pc, lookup_static_symbol)
5791         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5792         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5793         all_objfiles.
5794         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5795         * breakpoint.c (create_overlay_event_breakpoint)
5796         (create_longjmp_master_breakpoint)
5797         (create_std_terminate_master_breakpoint)
5798         (create_exception_master_breakpoint): Use all_objfiles.
5799         * linux-thread-db.c (try_thread_db_load_from_pdir)
5800         (has_libpthread): Use all_objfiles.
5801         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5802         * linespec.c (iterate_over_all_matching_symtabs)
5803         (search_minsyms_for_name): Use all_objfiles.
5804         * maint.c (maintenance_info_sections): Use all_objfiles.
5805         * main.c (captured_main_1): Use all_objfiles.
5806         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5807         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5808         * guile/scm-pretty-print.c
5809         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5810         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5811         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5812         (maintenance_print_msymbols): Use all_objfiles.
5813         * source.c (select_source_symtab): Use all_objfiles.
5814         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5815         * symfile.c (remove_symbol_file_command)
5816         (expand_symtabs_matching, map_symbol_filenames): Use
5817         all_objfiles.
5818         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5819         all_objfiles.
5820         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5821         * objc-lang.c (find_methods): Use all_objfiles.
5822         * objfiles.c (have_partial_symbols, have_full_symbols)
5823         (have_minimal_symbols, qsort_cmp)
5824         (default_iterate_over_objfiles_in_search_order): Use
5825         all_objfiles.
5826         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5827         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5828         (maintenance_check_psymtabs): Use all_objfiles.
5829         (ALL_PSYMTABS): Remove.
5830         * compile/compile-object-run.c (do_module_cleanup): Use
5831         all_objfiles.
5832         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5833         * cp-support.c (add_symbol_overload_list_qualified): Use
5834         all_objfiles.
5835         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5836         Use all_objfiles.
5837         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5838         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5839         all_objfiles.
5840         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5841         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5842         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5843         Uses all_objfiles.
5844         * solib.c (solib_read_symbols): Use all_objfiles
5845
5846 2019-01-09  Tom Tromey  <tom@tromey.com>
5847
5848         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5849         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5850         all_objfiles.
5851         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5852         * symmisc.c (print_symbol_bcache_statistics)
5853         (print_objfile_statistics, maintenance_print_objfiles)
5854         (maintenance_info_symtabs, maintenance_check_symtabs)
5855         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5856         all_objfiles.
5857         * source.c (forget_cached_source_info): Use all_objfiles.
5858         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5859         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5860         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5861         * objfiles.c (update_section_map): Use all_objfiles.
5862         (shared_objfile_contains_address_p): Likewise.
5863         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5864         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5865
5866 2019-01-09  Tom Tromey  <tom@tromey.com>
5867
5868         * common/next-iterator.h: New file.
5869         * objfiles.h (class all_objfiles): New.
5870         (struct objfile_iterator): New.
5871
5872 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5873
5874         * NEWS: Move the description of the changed "frame", "select-frame",
5875          and "info frame" commands to the Changed commands section.
5876
5877 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5878
5879         * gdbtypes.c (check_stub_method_group): Remove handling of old
5880         mangling schemes.
5881         * linespec.c (find_methods): Likewise.
5882         * stabsread.c (read_member_functions): Likewise.
5883         * valops.c (search_struct_method): Likewise.
5884         (value_struct_elt_for_reference): Likewise.
5885         * NEWS: Mention this change.
5886
5887 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5890         print_source_lines.
5891         * source.c (print_source_lines_base): Update line number check.
5892         (print_source_lines): New function.
5893         (source_lines_range::source_lines_range): New function.
5894         * source.h (class source_lines_range): New class.
5895         (print_source_lines): New declaration.
5896
5897 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5898
5899         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5900
5901 2019-01-08  Tom Tromey  <tom@tromey.com>
5902             Simon Marchi  <simon.marchi@ericsson.com>
5903
5904         PR gdb/24060
5905         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5906         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5907         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5908         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5909         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5910         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5911
5912 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5913
5914         * source.c (select_source_symtab): Move header comment to
5915         declaration in source.h.
5916         (forget_cached_source_info_for_objfile): Likewise.
5917         (forget_cached_source_info): Likewise.
5918         (identify_source_line): Likewise.
5919         * source.h (identify_source_line): Move declaration from symtab.h
5920         and add comment from source.c
5921         (print_source_lines): Likewise.
5922         (forget_cached_source_info_for_objfile): Likewise.
5923         (forget_cached_source_info): Likewise.
5924         (select_source_symtab): Likewise.
5925         (enum print_source_lines_flag): Move definition from symtab.h.
5926         * symtab.h (identify_source_line): Move declaration to source.h.
5927         (print_source_lines): Likewise.
5928         (forget_cached_source_info_for_objfile): Likewise.
5929         (forget_cached_source_info): Likewise.
5930         (select_source_symtab): Likewise.
5931         (enum print_source_lines_flag): Move definition to source.h.
5932         * tui/tui-hooks.c: Add 'source.h' include.
5933
5934 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * source.c (print_source_lines_base): Handle requests to print
5937         reverse line number sequences, and guard against empty lines
5938         string.
5939
5940 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * source.c (print_source_lines_base): Fix skip of '\r' if next
5943         character is '\n'.
5944
5945 2019-01-06  Tom Tromey  <tom@tromey.com>
5946
5947         * c-exp.y (struct c_parse_state) <macro_original_text,
5948         expansion_obstack>: New member.
5949         (macro_original_text, expansion_obstack): Remove globals.
5950         (scan_macro_expansion, scanning_macro_expansion)
5951         (finished_macro_expansion): Update.
5952         (scan_macro_cleanup): Remove.
5953         (yylex, c_parse): Update.
5954
5955 2019-01-06  Tom Tromey  <tom@tromey.com>
5956
5957         * c-exp.y (struct c_parse_state) <strings>: New member.
5958         (operator_stoken): Update.
5959
5960 2019-01-06  Tom Tromey  <tom@tromey.com>
5961
5962         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5963         (union type_stack_elt) <typelist_val>: Now a pointer to
5964         std::vector.
5965         (type_stack_cleanup): Don't declare.
5966         (push_typelist): Update.
5967         * parse.c (pop_typelist): Return a std::vector.
5968         (push_typelist): Take a std::vector.
5969         (follow_types): Update.  Do not free args.
5970         (type_stack_cleanup): Remove.
5971         * c-exp.y (struct c_parse_state): New.
5972         (cpstate): New global.
5973         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5974         (nonempty_typelist): Update.
5975         (func_mod): Create a new vector.
5976         (c_parse): Create a c_parse_state.
5977         (check_parameter_typelist): Do not delete params.
5978         (function_method): Update.  Do not delete type_list.
5979
5980 2019-01-06  Tom Tromey  <tom@tromey.com>
5981
5982         PR gdb/28155:
5983         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5984         check_typedef.
5985         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5986         (print_return_value): Likewise.
5987
5988 2019-01-05  Tom Tromey  <tom@tromey.com>
5989
5990         * contrib/cleanup_check.py: Remove.
5991         * contrib/gcc-with-excheck: Remove.
5992         * contrib/exsummary.py: Remove.
5993         * contrib/excheck.py: Remove.
5994
5995 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5996
5997         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5998         NULL. Initialize tpprev to NULL instead of assigning it
5999         to NULL on the next statement.
6000         * windows-nat.c (windows_delete_thread): Remove check for
6001         main_thread_id before printing thread exit notifications.
6002         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6003         Remove thread ID check against main_thread_id.
6004         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6005         windows_delete_thread.
6006         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6007
6008 2019-01-04  Tom Tromey  <tom@tromey.com>
6009
6010         * compile/compile.c (_initialize_compile): Use upper case for
6011         metasyntactic variables.
6012         * symmisc.c (_initialize_symmisc): Use upper case for
6013         metasyntactic variables.
6014         * psymtab.c (_initialize_psymtab): Use upper case for
6015         metasyntactic variables.
6016         * demangle.c (demangle_command): Use upper case for metasyntactic
6017         variables.
6018         (_initialize_demangler): Likewise.
6019         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6020         variables.
6021
6022 2019-01-03  Tom Tromey  <tom@tromey.com>
6023
6024         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6025
6026 2019-01-03  Tom Tromey  <tom@tromey.com>
6027
6028         * python/py-symtab.c (salpy_str): Update.
6029         (struct salpy_sal_object) <symtab>: Now a PyObject.
6030         (salpy_dealloc): Update.
6031         (del_objfile_sal): Use gdbpy_ref.
6032
6033 2019-01-03  Tom Tromey  <tom@tromey.com>
6034
6035         * python/py-type.c (convert_field): Use new_reference.  Return
6036         gdbpy_ref.
6037         (make_fielditem): Return gdbpy_ref.
6038         (typy_fields): Update.
6039         (typy_getitem): Update.
6040         (field_name): Return gdbpy_ref.  Use new_reference.
6041         (typy_iterator_iternext): Update.
6042
6043 2019-01-03  Tom Tromey  <tom@tromey.com>
6044
6045         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6046
6047 2019-01-03  Tom Tromey  <tom@tromey.com>
6048
6049         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6050         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6051         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6052         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6053         (pspy_set_type_printers): Likewise.
6054         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6055         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6056         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6057         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6058         (objfpy_set_type_printers): Likewise.
6059
6060 2019-01-03  Tom Tromey  <tom@tromey.com>
6061
6062         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6063         (gdbpy_print_stack): Use gdbpy_err_fetch.
6064         * python/python-internal.h (class gdbpy_err_fetch): New class.
6065         (class gdbpy_enter) <m_error_type, m_error_value,
6066         m_error_traceback>: Remove.
6067         <m_error>: New member.
6068         (gdbpy_exception_to_string): Don't declare.
6069         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6070         * python/py-value.c (convert_value_from_python): Use
6071         gdbpy_err_fetch.
6072         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6073         gdbpy_exception_to_string.
6074         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6075         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6076         gdbpy_err_fetch.
6077
6078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6079
6080         * linux-nat.c (delete_lwp_cleanup): Delete.
6081         (struct lwp_deleter): New struct.
6082         (lwp_info_up): New typedef.
6083         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6084         lwp_info_up.
6085
6086 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6087
6088         * linux-fork.c (class scoped_switch_fork_info): New class.
6089         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6090
6091 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6092
6093         * valops.c (find_overload_match): Remove use of null_cleanup, and
6094         calls to do_cleanups.
6095
6096 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6097
6098         * compile/compile-cplus-types.c
6099         (compile_cplus_instance::decl_name): Handle changes to
6100         cp_func_name.
6101         * cp-support.c (cp_func_name): Update header comment, update
6102         return type.
6103         * cp-support.h (cp_func_name): Update return type in declaration.
6104         * valops.c (find_overload_match): Move temp_func local to top
6105         level of function and change its type.  Use temp_func to hold and
6106         delete temporary string obtained from cp_func_name.
6107
6108 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6111         gdb::char_vector, remove cleanup, and update uses of `msg`.
6112
6113 2019-01-03  Jim Wilson  <jimw@sifive.com>
6114
6115         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6116
6117 2019-01-02  Tom Tromey  <tom@tromey.com>
6118
6119         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6120         (tdesc_parse_xml): Remove cleanups.
6121         * target-descriptions.h (make_cleanup_free_target_description):
6122         Don't declare.
6123         (target_desc_deleter): New struct.
6124         (target_desc_up): New typedef.
6125         * target-descriptions.c (target_desc_deleter::operator()): Rename
6126         from free_target_description.
6127         (make_cleanup_free_target_description): Remove.
6128
6129 2019-01-02  Tom Tromey  <tom@tromey.com>
6130
6131         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6132         constructor, destructor.
6133         (linespec_parser): Remove typedef.
6134         (~linespec_parser): Rename from linespec_parser_delete.
6135         (linespec_lex_to_end, linespec_complete_label)
6136         (linespec_complete): Update.
6137         (decode_line_full): Remove cleanups.
6138         (decode_line_1): Update.
6139
6140 2019-01-02  Tom Tromey  <tom@tromey.com>
6141
6142         * python/python-internal.h (inferior_to_inferior_object): Change
6143         return type.
6144         * python/py-exitedevent.c (create_exited_event_object): Update.
6145         * python/py-inferior.c (inferior_to_inferior_object): Return
6146         gdbpy_ref.
6147         (python_new_inferior, python_inferior_deleted)
6148         (thread_to_thread_object, delete_thread_object)
6149         (build_inferior_list, gdbpy_selected_inferior): Update.
6150         * python/py-infthread.c (create_thread_object): Update.  Also fail
6151         if inferior_to_inferior_object fails.
6152
6153 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6154
6155         * inferior.h (class inferior) <displaced_step_state>: New field.
6156         * infrun.h (struct displaced_step_state): Move here from
6157         infrun.c.  Initialize fields, add constructor.
6158         <inf>: Remove field.
6159         <reset>: New method.
6160         * infrun.c (struct displaced_step_inferior_state): Move to
6161         infrun.h.
6162         (displaced_step_inferior_states): Remove.
6163         (get_displaced_stepping_state): Adust.
6164         (displaced_step_in_progress_any_inferior): Adjust.
6165         (displaced_step_in_progress_thread): Adjust.
6166         (displaced_step_in_progress): Adjust.
6167         (add_displaced_stepping_state): Remove.
6168         (get_displaced_step_closure_by_addr): Adjust.
6169         (remove_displaced_stepping_state): Remove.
6170         (infrun_inferior_exit): Call displaced_step_state.reset.
6171         (use_displaced_stepping): Don't check for NULL.
6172         (displaced_step_prepare_throw): Call
6173         get_displaced_stepping_state.
6174         (displaced_step_fixup): Don't check for NULL.
6175         (prepare_for_detach): Don't check for NULL.
6176
6177 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6178
6179         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6180          in case of call that did not complete.
6181
6182 2019-01-02  Andrey Utkin  <autkin@undo.io>
6183
6184         * symfile.c (find_separate_debug_file): Fix search of debug files for
6185         remote debuggee.
6186
6187 2019-01-02  Tom Tromey  <tom@tromey.com>
6188
6189         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6190         indentation.
6191         * python/py-frame.c (frapy_older): Remove cast.
6192         (frapy_newer): Likewise.
6193         * python/py-breakpoint.c (local_setattro): Remove cast.
6194         * python/py-arch.c (archpy_name): Remove local variable.
6195         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6196
6197 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6198
6199         * unittests/basic_string_view/element_access/char/empty.cc:
6200         Fix year range in copyright header.
6201
6202 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6205         Delete.
6206         <operator==>: Update with for removed field.
6207         <hash>: Likewise.
6208         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6209         <isa_features>: ...this.
6210         <abi_features>: New field.
6211         (riscv_isa_flen): Update comment.
6212         (riscv_abi_xlen): New declaration.
6213         (riscv_abi_flen): New declaration.
6214         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6215         isa_features.
6216         (riscv_abi_xlen): New function.
6217         (riscv_isa_flen): Update to get answer from isa_features.
6218         (riscv_abi_flen): New function.
6219         (riscv_has_fp_abi): Update to get answer from abi_features.
6220         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6221         xlen and flen.
6222         (riscv_call_info) <xlen, flen>: Update comment.
6223         (riscv_call_arg_struct): Remove invalid assertions
6224         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6225         is removed.
6226         (riscv_gdbarch_init): Gather isa features and abi features
6227         separately, ensure both match on the gdbarch when reusing an old
6228         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6229         a target with 64-bit float hardware.
6230
6231 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6232
6233         * source.c (search_command_helper): Stop reverse search
6234         when line 1 has been searched.
6235
6236 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6237
6238         * record-full.c (record_full_base_target::close): Rewrite
6239         record_full_core_buf_list free logic.
6240
6241 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6242
6243         * break-catch-syscall.c (print_one_catch_syscall): xfree
6244         the last text.
6245
6246 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6247
6248         * top.c (print_gdb_version): Update Copyright year in version
6249         message.
6250
6251 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6252
6253         Update copyright year range in all GDB files.
6254
6255 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6256
6257         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6258
6259 For older changes see ChangeLog-2018.
6260 \f
6261 Local Variables:
6262 mode: change-log
6263 left-margin: 8
6264 fill-column: 74
6265 version-control: never
6266 coding: utf-8
6267 End:
6268