1 2019-08-06 Tom Tromey <tom@tromey.com>
3 * gdb_obstack.h (obstack_strdup): Define.
4 * gdb_obstack.c (obstack_strdup): Don't define.
6 2019-08-06 Tom Tromey <tom@tromey.com>
8 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
10 * typeprint.c (typedef_hash_table::find_global_typedef): Use
12 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
13 * stabsread.c (common_block_start): Use obstack_strdup.
14 * objfiles.c (set_objfile_main_name, objfile): Use
16 * namespace.c (add_using_directive): Use obstack_strdup.
17 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
18 * jit.c (finalize_symtab): Use obstack_strdup.
19 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
20 (guess_partial_die_structure_name, partial_die_info::fixup)
21 (dwarf2_name): Use obstack_strdup.
22 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
24 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
25 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
27 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
29 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
31 * unittests/help-doc-selftests.c: New file.
32 * Makefile.in: Add the new file.
34 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
36 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
37 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
38 the full first line, except when FOR_VALUE_PREFIX. In this case,
39 the trailing '.' is not output, and the first character is uppercased.
40 (print_help_for_command): Update call to print_doc_line.
41 (print_doc_of_command): Likewise.
42 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
43 * cli/cli-option.c (append_indented_doc): Do not append newline.
44 (build_help_option): Append newline after first appended_indented_doc
45 only if a second call is done.
46 (build_help): Append 2 new lines before each option, except the first
48 * compile/compile.c (_initialize_compile): Add new lines after
49 %OPTIONS%, when not at the end of the help.
50 Change help doc or code
51 producing the help doc to respect the invariants.
52 * maint-test-options.c (_initialize_maint_test_options): Likewise.
53 Also removed the new line after 'Options:', as all other commands
54 do not put an empty line between 'Options:' and the first option.
55 * printcmd.c (_initialize_printcmd): Likewise.
56 * stack.c (_initialize_stack): Likewise.
57 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
58 incorrectly telling COMMAND is optional.
59 * ada-lang.c (_initialize_ada_language): Change help doc or code
60 producing the help doc to respect the invariants.
61 * ada-tasks.c (_initialize_ada_tasks): Likewise.
62 * breakpoint.c (_initialize_breakpoint): Likewise.
63 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
64 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
65 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
66 * cli/cli-style.c (cli_style_option::add_setshow_commands,
67 _initialize_cli_style): Likewise.
68 * corelow.c (core_target_info): Likewise.
69 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
70 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
71 * filesystem.c (_initialize_filesystem): Likewise.
72 * frame.c (_initialize_frame): Likewise.
73 * gnu-nat.c (add_task_commands): Likewise.
74 * infcall.c (_initialize_infcall): Likewise.
75 * infcmd.c (_initialize_infcmd): Likewise.
76 * interps.c (_initialize_interpreter): Likewise.
77 * language.c (_initialize_language): Likewise.
78 * linux-fork.c (_initialize_linux_fork): Likewise.
79 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
80 * maint.c (_initialize_maint_cmds): Likewise.
81 * memattr.c (_initialize_mem): Likewise.
82 * printcmd.c (_initialize_printcmd): Likewise.
83 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
85 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
86 * record-btrace.c (_initialize_record_btrace): Likewise.
87 * record-full.c (_initialize_record_full): Likewise.
88 * record.c (_initialize_record): Likewise.
89 * regcache-dump.c (_initialize_regcache_dump): Likewise.
90 * regcache.c (_initialize_regcache): Likewise.
91 * remote.c (add_packet_config_cmd, init_remote_threadtests,
92 _initialize_remote): Likewise.
93 * ser-tcp.c (_initialize_ser_tcp): Likewise.
94 * serial.c (_initialize_serial): Likewise.
95 * skip.c (_initialize_step_skip): Likewise.
96 * source.c (_initialize_source): Likewise.
97 * stack.c (_initialize_stack): Likewise.
98 * symfile.c (_initialize_symfile): Likewise.
99 * symtab.c (_initialize_symtab): Likewise.
100 * target-descriptions.c (_initialize_target_descriptions): Likewise.
101 * top.c (init_main): Likewise.
102 * tracefile-tfile.c (tfile_target_info): Likewise.
103 * tracepoint.c (_initialize_tracepoint): Likewise.
104 * tui/tui-win.c (_initialize_tui_win): Likewise.
105 * utils.c (add_internal_problem_command): Likewise.
106 * valprint.c (value_print_option_defs): Likewise.
108 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
111 * configure.ac: Drop enable-libmcheck support.
112 * configure, config.in: Rebuild.
113 * libmcheck.m4: Remove.
114 * acinclude.m4: Don't include it.
115 * Makefile.in: Don't distribute it.
116 * top.c (print_gdb_configuration): Don't mention it.
118 2019-08-06 Tom Tromey <tom@tromey.com>
120 * utils.c (set_output_style): Sometimes pass stream to
122 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
123 * record-btrace.c (btrace_insn_history): Update.
124 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
126 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
128 <m_uiout>: New field.
130 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
131 Remove "uiout" parameter.
132 (dump_insns): Update.
133 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
134 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
136 2019-08-06 Christian Biesinger <cbiesinger@google.com>
138 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
139 (error_in_psymtab_expansion): Likewise.
140 (lookup_symbol_via_quick_fns): Likewise.
141 (basic_lookup_transparent_type_quick): Likewise.
142 (basic_lookup_transparent_type_1): Likewise.
144 2019-08-06 Tom Tromey <tromey@adacore.com>
146 * source.c (last_source_error): Now bool.
147 (print_source_lines_base): Make "noprint" bool. Only open
148 source file when last_source_visited changes.
150 2019-08-06 Tom Tromey <tromey@adacore.com>
152 * annotate.c (annotate_source_line): Use g_source_cache.
153 * source-cache.c (source_cache::get_plain_source_lines): Change
154 parameters. Populate m_offset_cache.
155 (source_cache::ensure): New method.
156 (source_cache::get_line_charpos): New method.
157 (extract_lines): Move lower. Change parameters.
158 (source_cache::get_source_lines): Move lower.
159 * source-cache.h (class source_cache): Update comment.
160 <get_line_charpos>: New method.
161 <get_source_lines>: Update comment.
162 <clear>: Clear m_offset_cache.
163 <get_plain_source_lines>: Change parameters.
165 <m_offset_cache>: New member.
166 * source.c (forget_cached_source_info_for_objfile): Update.
167 (info_source_command): Use g_source_cache.
168 (find_source_lines, open_source_file_with_line_charpos): Remove.
169 (print_source_lines_base, search_command_helper): Use g_source_cache.
170 * source.h (open_source_file_with_line_charpos): Don't declare.
171 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
172 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
175 2019-08-06 Tom Tromey <tromey@adacore.com>
177 * source-cache.c (source_cache::get_plain_source_lines):
178 Remove "first_line" and "last_line" parameters.
179 (source_cache::get_source_lines): Cache plain text.
180 * source-cache.h (class source_cache)
181 <get_plain_source_lines>: Update.
183 2019-08-06 Tom Tromey <tromey@adacore.com>
185 * source-cache.c (extract_lines): No longer a method.
186 Changed type of parameter. Include final newline.
187 (selftests::extract_lines_test): New function.
188 (_initialize_source_cache): Likewise.
189 * source-cache.h (class source_cache)
190 <extract_lines>: Don't declare.
192 2019-08-06 Tom Tromey <tromey@adacore.com>
194 * breakpoint.c (init_breakpoint_sal): Update.
195 (breakpoint): Update.
196 * breakpoint.h (struct breakpoint) <filter>: Now a
199 2019-08-05 Christian Biesinger <cbiesinger@google.com>
201 * NEWS: Mention dictionary access on blocks.
202 * python/py-block.c (blpy_getitem): New function.
203 (block_object_as_mapping): New struct.
204 (block_object_type): Use new struct for tp_as_mapping field.
206 2019-08-05 Christian Biesinger <cbiesinger@google.com>
208 * objfiles.h (objfile): Add a comment describing partial symbols.
210 2019-08-05 Tom Tromey <tromey@adacore.com>
212 * compile/compile.c (_initialize_compile): Use _(), not N_().
213 * thread.c (_initialize_thread): Use _(), not N_().
214 * stack.c (_initialize_stack): Use _(), not N_().
215 * printcmd.c (_initialize_printcmd): Use _(), not N_().
217 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
219 * dwarf2read.c (struct dw2_symtab_iterator):
220 <want_specific_block>: Remove.
221 <block_index>: Change type to gdb::optional.
222 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
223 change type of BLOCK_INDEX parameter to gdb::optional.
224 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
225 (dw2_lookup_symbol): Don't pass argument for
227 (dw2_expand_symtabs_for_function): Don't pass argument for
228 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
229 (class dw2_debug_names_iterator)
230 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
231 parameter, change BLOCK_INDEX type to gdb::optional.
232 <m_want_specific_block>: Remove.
233 <m_block_index>: Change type to gdb::optional.
234 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
235 gdb::optional. Re-write in function of gdb::optional.
236 (dw2_debug_names_lookup_symbol): Don't pass argument for
238 (dw2_debug_names_expand_symtabs_for_function): Don't pass
239 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
242 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
244 * NEWS: Mention changes to "info sources" command.
246 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
248 * symtab.c (filename_partial_match_opts): New struct type.
249 (struct output_source_filename_data): New members
250 regexp, c_regexp, partial_match.
251 (output_source_filename): Use new members to decide to print file.
252 (info_sources_option_defs): New variable.
253 (make_info_sources_options_def_group, print_info_sources_header,
254 info_sources_command_completer):
256 (info_sources_command): Read new optional arguments.
257 (_initialize_symtab): Update info sources help.
259 2019-08-02 Alexandre Oliva <oliva@adacore.com>
261 * ada-lang.c (exception_support_info_v0): Renamed from...
262 (default_exception_support_info): ... this. Create new
264 (ada_has_this_exception_support): Look up catch_handlers_sym.
265 (ada_exception_support_info_sniffer): Try v0 after default.
267 2019-08-01 Tom Tromey <tromey@adacore.com>
269 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
272 2019-08-01 Christian Biesinger <cbiesinger@google.com>
274 * s12z-tdep.c: Fix include path for s12z-opc.h.
276 2019-08-01 Alan Hayward <alan.hayward@arm.com>
278 * NEWS: Require GNU make 3.82.
280 2019-07-16 Tom Tromey <tom@tromey.com>
282 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
285 2019-07-30 Tom Tromey <tromey@adacore.com>
287 * block.c (contained_in): Remove BLOCK_FUNCTION check.
289 2019-07-30 Kevin Buettner <kevinb@redhat.com>
291 * printcmd.c (print_address_symbolic): Print negative offsets.
292 (build_address_symbolic): Force signed arithmetic when computing
295 2019-07-30 Christian Biesinger <cbiesinger@google.com>
297 PR/24474: Add a function to lookup static variables.
298 * NEWS: Mention this new function.
299 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
300 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
301 * python/python.c (python_GdbMethods): Add new function.
303 2019-07-29 Christian Biesinger <cbiesinger@google.com>
305 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
306 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
307 (objfpy_lookup_static_symbol): New function.
308 (objfile_object_methods): Add new functions.
310 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
312 * NEWS: Mention 'set|show print frame-info'. Mention new
313 'presence' value for 'frame-arguments'. Mention new '-frame-info'
314 backtrace argument. Mention that python frame filtering code
315 is now consistent with what 'backtrace' command prints.
317 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
319 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
321 (print_frame_info_auto, print_frame_info_source_line,
322 print_frame_info_location, print_frame_info_source_and_location,
323 print_frame_info_location_and_address, print_frame_info_short_location):
325 (struct frame_print_options): New member print_frame_info.
326 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
327 * stack.h (get_user_print_what_frame_info): New declaration.
328 (frame_show_address): New declaration.
329 * stack.c (print_frame_arguments_choices): New value 'presence'.
330 (print_frame_info_auto, print_frame_info_source_line,
331 print_frame_info_location, print_frame_info_source_and_location,
332 print_frame_info_location_and_address, print_frame_info_short_location,
333 print_frame_info_choices, print_frame_info_print_what): New definitions.
334 (print_frame_args): Only print dots for args if print frame-arguments
336 (frame_print_option_defs): New element for "frame-info".
337 (get_user_print_what_frame_info): New function.
338 (frame_show_address): Make non static. Move comment to stack.h.
339 (print_frame_info_to_print_what): New function.
340 (print_frame_info): Update comment. Use fp_opts.print_frame_info
341 to decide what to print.
342 (backtrace_command_1): Handle the new print_frame_arguments_presence
344 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
345 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
346 (py_print_frame): In non-mi mode, use LOCATION as default for
347 print_what, similarly to frame information printed directly by
348 backtrace command. Handle frame-info user option in non MI mode.
350 2019-07-27 Kevin Buettner <kevinb@redhat.com>
352 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
353 Add case for debugging 32-bit target on 64-bit host. Revise
356 2019-07-27 Kevin Buettner <kevinb@redhat.com>
358 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
359 instead of find_function_entry_range_from_pc.
361 2019-07-27 Kevin Buettner <kevinb@redhat.com>
363 * stack.c (find_frame_funname): Remove code which preferred
364 minsym over symtab sym in "certain pathological cases".
366 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
367 parameter. Change type of "do_demangle" to bool.
368 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
369 Pass suitable "prefer_sym_over_minsym" flag to
370 build_address_symbolic(). Don't output "+" for negative offsets.
371 * printcmd.c (print_address_symbolic): Update invocation of
372 build_address_symbolic to include a "prefer_sym_over_minsym"
374 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
375 Restrict cases in which use of minimal symbol is preferred to that
376 of a found symbol. Update comments.
378 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
379 for entry pc when entry pc is out of range for that FDE.
381 2019-07-26 Brian Callahan <bcallah@openbsd.org>
384 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
387 2019-07-25 Christian Biesinger <cbiesinger@google.com>
389 * python/py-objfile.c (add_separate_debug_file): Fix comment about
390 this function's Python signature.
393 2019-07-24 Christian Biesinger <cbiesinger@google.com>
395 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
396 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
397 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
398 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
399 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
402 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
404 * h8300-tdep.c (h8300_register_name_common): New.
405 h8300_register_name): Use h8300_register_name_common.
406 (h8300s_register_name): Likewise.
407 (h8300sx_register_name): Likewise.
408 (h8300h_register_nam): New.
409 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
412 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
414 * arm-tdep.c (arm_skip_cmse_entry): New function.
415 (arm_is_sgstubs_section): New function.
416 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
418 2019-07-22 Tom Tromey <tom@tromey.com>
420 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
423 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
425 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
428 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
430 * symtab.c (search_symbols): Adjust msymbol matching type arrays
431 so that GDB doesn't match any msymbols when searching in the
433 (print_symbol_info): Print using typedef_print or type_print based
434 on the type of the symbol. Add updated FIXME comment moved from...
435 (_initialize_symtab): ... move and update FIXME comment to above.
437 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
439 * NEWS: Mention adding -q option to "info types".
440 * symtab.c (struct info_types_options): New struct.
441 (info_types_options_defs): New variable.
442 (make_info_types_options_def_group): New function.
443 (info_types_command): Use gdb::option framework to parse options.
444 (info_types_command_completer): New function.
445 (_initialize_symtab): Extend the help text on "info types" and
446 register command completer.
448 2019-07-21 Christian Biesinger <cbiesinger@google.com>
450 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
451 (lookup_symbol_in_objfile): Change int to block_enum and add a
452 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
454 2019-07-20 Christian Biesinger <cbiesinger@google.com>
456 * MAINTAINERS (Write After Approval): Add self.
458 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
460 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
461 instruction to the dummy code region.
463 2019-07-19 Tom Tromey <tromey@adacore.com>
465 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
466 (ARGSUSED, PARAMS, __func__): Remove rules.
468 2019-07-19 Alan Hayward <alan.hayward@arm.com>
470 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
471 * features/arm/arm-with-iwmmxt.c: Remove.
472 * features/arm/arm-with-iwmmxt.xml: Remove.
473 * features/arm/arm-with-m-fpa-layout.c: Remove.
474 * features/arm/arm-with-m-fpa-layout.xml: Remove.
475 * features/arm/arm-with-m-vfp-d16.c: Remove.
476 * features/arm/arm-with-m-vfp-d16.xml: Remove.
477 * features/arm/arm-with-m.c: Remove.
478 * features/arm/arm-with-m.xml: Remove.
479 * features/arm/arm-with-neon.c: Remove.
480 * features/arm/arm-with-neon.xml: Remove.
481 * features/arm/arm-with-vfpv2.c: Remove.
482 * features/arm/arm-with-vfpv2.xml: Remove.
483 * features/arm/arm-with-vfpv3.c: Remove.
484 * features/arm/arm-with-vfpv3.xml: Remove.
486 2019-07-19 Alan Hayward <alan.hayward@arm.com>
488 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
490 2019-07-19 Alan Hayward <alan.hayward@arm.com>
492 * arch/aarch32.c (aarch32_create_target_description): Create
493 target descriptions using features.
494 * arch/arm.c (arm_create_target_description)
495 (arm_create_mprofile_target_description): Likewise.
496 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
498 2019-07-19 Alan Hayward <alan.hayward@arm.com>
500 * Makefile.in: Add new files.
501 * aarch32-tdep.c: New file.
502 * aarch32-tdep.h: New file.
503 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
504 Call aarch32_read_description.
505 * arch/aarch32.c: New file.
506 * arch/aarch32.h: New file.
507 * arch/arm.c (arm_create_target_description)
508 (arm_create_mprofile_target_description): New function.
509 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
510 (arm_create_target_description)
511 (arm_create_mprofile_target_description): New declaration.
512 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
513 read_description functions.
514 * arm-linux-nat.c (arm_linux_nat_target::read_description):
516 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
517 * arm-tdep.c (tdesc_arm_list): New variable.
518 (arm_register_g_packet_guesses): Call create description functions.
519 (arm_read_description) (arm_read_mprofile_description): New
521 * arm-tdep.h (arm_read_description)
522 (arm_read_mprofile_description): Add declaration.
523 * configure.tgt: Add new files.
525 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
527 * top.c (new_ui_command): Open specified terminal just once.
529 2019-07-18 Tom Tromey <tromey@adacore.com>
531 * symtab.c (main_name): Constify return type.
532 * symfile.c (set_initial_language): Update.
533 * symtab.h (main_name): Constify return type.
535 2019-07-17 Tom Tromey <tom@tromey.com>
537 * tui/tui-winsource.c (tui_update_source_window)
538 (tui_update_source_window_as_is)
539 (tui_update_source_windows_with_line): Remove return.
540 * tui/tui-disasm.c (tui_show_disassem)
541 (tui_show_disassem_and_update_source): Remove return.
542 * tui/tui.c (tui_reset): Remove return.
543 * tui/tui-wingeneral.c
544 (tui_check_and_display_highlight_if_needed): Remove return.
546 2019-07-17 Tom Tromey <tom@tromey.com>
548 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
550 2019-07-17 Tom Tromey <tom@tromey.com>
552 * tui/tui-winsource.h (struct tui_exec_info_window)
553 (struct tui_source_window_base): Move from tui-data.h.
554 * tui/tui-winsource.c: Move many method definitions from
555 elsewhere. Remove "structuring" comments.
556 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
557 (tui_source_window_base::refresh_window): Move to
559 * tui/tui-win.c (tui_source_window_base::refresh_all)
560 (tui_source_window_base::update_tab_width)
561 (tui_source_window_base::set_new_height)
562 (tui_source_window_base::do_make_visible_with_new_height): Move to
564 * tui/tui-source.h: Update.
565 * tui/tui-source.c (tui_source_window_base::reset): Move to
567 * tui/tui-disasm.h: Update.
568 * tui/tui-data.h (struct tui_exec_info_window): Move to
570 (struct tui_source_window_base): Likewise.
571 * tui/tui-data.c (tui_source_window_base::clear_detail)
572 (tui_source_window_base, ~tui_source_window_base): Move to
575 2019-07-17 Tom Tromey <tom@tromey.com>
577 * tui/tui-win.c (tui_resize_all)
578 (tui_source_window_base::update_tab_width)
579 (tui_adjust_win_heights): Update.
580 (tui_win_info::make_invisible_and_set_new_height): Rename from
581 make_invisible_and_set_new_height.
582 * tui/tui-data.h (struct tui_win_info)
583 <make_invisible_and_set_new_height>: New method.
585 2019-07-17 Tom Tromey <tom@tromey.com>
588 * tui/tui-source.h (struct tui_source_window): Move from
590 * tui/tui-layout.c: Update.
591 * tui/tui-disasm.c: Update.
592 * tui/tui-data.h (struct tui_source_window): Move to
595 2019-07-17 Tom Tromey <tom@tromey.com>
597 * tui/tui-disasm.h (struct tui_disasm_window): Move from
599 * tui/tui-data.h (struct tui_disasm_window): Move to
602 2019-07-17 Tom Tromey <tom@tromey.com>
604 * tui/tui-regs.h (struct tui_data_item_window): Move from
606 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
607 * tui/tui-data.h (struct tui_data_item_window): Move to
609 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
611 2019-07-17 Tom Tromey <tom@tromey.com>
614 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
615 (tui_cmd_window::max_height): Move to tui-command.c.
616 * tui/tui-layout.c: Update.
617 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
618 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
620 * tui/tui-command.h (struct tui_cmd_window): Move from
622 * tui/tui-command.c: Remove "structuring" comments.
623 (tui_cmd_window::clear_detail)
624 (tui_cmd_window::do_make_visible_with_new_height)
625 (tui_cmd_window::max_height): Move from elsewhere.
627 2019-07-17 Tom Tromey <tom@tromey.com>
629 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
631 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
632 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
634 2019-07-17 Tom Tromey <tom@tromey.com>
637 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
639 * tui/tui-windata.h: Remove file.
640 * tui/tui-windata.c: Remove file.
641 * tui/tui-win.c (tui_data_window::set_new_height)
642 (tui_data_window::do_make_visible_with_new_height): Move to
644 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
645 * tui/tui-regs.c: Remove "structuring" comments.
646 (tui_data_window::first_data_item_displayed)
647 (tui_data_window::delete_data_content_windows)
648 (tui_data_window::erase_data_content)
649 (tui_data_window::display_all_data)
650 (tui_data_window::refresh_all)
651 (tui_data_window::do_scroll_vertical)
652 (tui_data_window::clear_detail, tui_data_window::set_new_height)
653 (tui_data_window::do_make_visible_with_new_height)
654 (tui_data_window::refresh_window): Move from elsewhere.
655 (_initialize_tui_regs): Move to end of file.
656 * tui/tui-layout.c: Update.
657 * tui/tui-hooks.c: Update.
658 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
659 * tui/tui-data.c (tui_data_window::clear_detail): Move to
661 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
663 2019-07-17 Tom Tromey <tom@tromey.com>
665 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
668 2019-07-17 Tom Tromey <tom@tromey.com>
670 * tui/tui-win.c (tui_source_window_base::set_new_height)
671 (tui_source_window_base::do_make_visible_with_new_height): Use
672 m_has_locator field directly.
673 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
675 (struct tui_source_window_base) <has_locator>: Likewise.
677 2019-07-17 Tom Tromey <tom@tromey.com>
679 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
681 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
683 * tui/tui-win.c (tui_source_window_base::set_new_height)
684 (tui_source_window_base::set_new_height)
685 (make_invisible_and_set_new_height)
686 (tui_source_window_base::do_make_visible_with_new_height)
687 (tui_source_window_base::do_make_visible_with_new_height):
689 * tui/tui-layout.c (show_source_disasm_command, show_data)
690 (show_source_or_disasm_and_command): Update.
691 * tui/tui-layout.c (show_layout): Update.
693 2019-07-17 Tom Tromey <tom@tromey.com>
695 * tui/tui-layout.c (make_data_window): Remove.
696 (show_data): Unify creation and re-initialization cases.
698 2019-07-17 Tom Tromey <tom@tromey.com>
700 * tui/tui-layout.c (make_source_window, make_disasm_window):
702 (show_data): Unify creation and re-initialization cases.
704 2019-07-17 Tom Tromey <tom@tromey.com>
706 * tui/tui-layout.c (make_command_window): Remove.
707 (show_source_disasm_command, show_source_or_disasm_and_command):
708 Unify creation and re-initialization cases.
710 2019-07-17 Tom Tromey <tom@tromey.com>
712 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
713 creation and re-initialization cases.
715 2019-07-17 Tom Tromey <tom@tromey.com>
717 * tui/tui-regs.c (tui_get_register): Return void.
719 2019-07-17 Tom Tromey <tom@tromey.com>
721 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
724 2019-07-17 Tom Tromey <tom@tromey.com>
726 * tui/tui-layout.c (show_source_disasm_command): Simplify window
729 2019-07-17 Tom Tromey <tom@tromey.com>
731 * tui/tui.h (tui_set_layout_by_name): Don't declare.
732 * tui/tui-regs.c (tui_reg_layout): New function.
733 (tui_show_registers, tui_reg_command): Use it.
734 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
735 (tui_layout_command): Rename from tui_set_layout_by_name. Change
737 (tui_layout_command): Remove.
739 2019-07-17 Tom Tromey <tom@tromey.com>
741 * tui/tui-layout.h (tui/tui-layout): Return void.
742 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
744 2019-07-17 Tom Tromey <tom@tromey.com>
746 * tui/tui-layout.c (show_source_disasm_command, show_data):
748 (reset_locator): Remove.
749 (show_source_or_disasm_and_command): Update.
751 2019-07-17 Tom Tromey <tom@tromey.com>
753 * tui/tui-source.c (tui_source_window_base::reset): Remove
755 * tui/tui-layout.c (make_command_window, make_source_window)
756 (make_disasm_window, make_data_window)
757 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
758 (reset_locator, show_source_or_disasm_and_command): Update.
759 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
761 (struct tui_source_window_base) <reset>: Likewise.
763 2019-07-17 Tom Tromey <tom@tromey.com>
765 * tui/tui-layout.c (show_source_disasm_command): Use
767 (reset_locator): New function.
768 (init_and_make_win): Remove.
769 (show_source_or_disasm_and_command): Use reset_locator.
771 2019-07-17 Tom Tromey <tom@tromey.com>
773 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
775 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
777 * tui/tui-source.c (tui_source_window_base::reset): New method.
778 * tui/tui-layout.c (make_command_window): Don't call
780 (make_source_window, make_disasm_window): Don't call
781 make_source_or_disasm_window.
782 (make_data_window): Don't call init_and_make_win. Change calling
784 (show_source_disasm_command, show_data): Simplify.
785 (make_source_or_disasm_window): Remove.
786 (show_source_or_disasm_and_command): Simplify.
787 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
788 (struct tui_source_window_base) <reset>: Likewise.
789 <execution_info>: Remove initializer.
790 * tui/tui-data.c (tui_source_window_base): Initialize
793 2019-07-17 Tom Tromey <tom@tromey.com>
795 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
798 2019-07-17 Tom Tromey <tom@tromey.com>
800 * tui/tui.c (tui_rl_other_window): Update.
801 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
802 superclass method first. Always iterate over regs_content.
803 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
805 * tui/tui-win.c (tui_set_focus_command): Update.
807 2019-07-17 Tom Tromey <tom@tromey.com>
809 * tui/tui-win.c (tui_set_focus_command): Rename from
810 tui_set_focus. Call tui_enable.
811 (tui_set_focus_command): Remove.
813 2019-07-17 Tom Tromey <tom@tromey.com>
815 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
817 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
819 (tui_data_window::refresh_window): Call refresh_window on data
820 items. Always call superclass refresh_window.
821 (tui_win_info::refresh): Remove.
822 (tui_source_window_base::refresh_window): Update.
823 (tui_refresh_all): Update.
824 * tui/tui-layout.c (show_source_disasm_command): Remove call to
826 (show_source_or_disasm_and_command): Likewise.
827 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
828 (struct tui_source_window_base) <refresh>: Likewise.
830 2019-07-17 Tom Tromey <tom@tromey.com>
832 * tui/tui-winsource.c (tui_clear_source_content)
833 (tui_show_source_content): Update.
834 * tui/tui-source.c (tui_source_window::showing_source_p): Check
835 whether content is empty.
836 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
839 2019-07-17 Tom Tromey <tom@tromey.com>
841 * tui/tui-winsource.c (tui_erase_source_content): Clear the
843 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
844 * tui/tui-source.c (tui_set_source_content_nil): Remove.
846 2019-07-17 Tom Tromey <tom@tromey.com>
848 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
849 (struct tui_data_item_window): Update.
851 2019-07-17 Tom Tromey <tom@tromey.com>
853 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
854 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
857 2019-07-17 Tom Tromey <tom@tromey.com>
859 * tui/tui-winsource.h (tui_erase_source_content)
860 (tui_clear_source_content): Remove "display_prompt" parameter.
861 * tui/tui-winsource.c (tui_update_source_window_as_is)
862 (tui_update_source_windows_with_addr): Update.
863 (tui_clear_source_content): Remove "display_prompt" parameter.
864 (tui_erase_source_content): Likewise. Simplify.
865 (tui_show_source_content): Update.
866 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
867 * tui/tui-stack.c (tui_show_frame_info): Update.
868 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
871 2019-07-17 Tom Tromey <tom@tromey.com>
873 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
874 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
876 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
879 2019-07-17 Tom Tromey <tom@tromey.com>
881 * tui/tui-winsource.c (tui_clear_source_content)
882 (tui_show_source_content, tui_show_exec_info_content)
883 (tui_clear_exec_info_content): Update.
884 * tui/tui-stack.c (tui_show_locator_content): Update.
885 (tui_show_frame_info): Update.
886 * tui/tui-source.h (tui_source_window): Don't declare.
887 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
888 from tui_source_is_displayed.
889 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
891 (struct tui_source_window_base) <content_in_use>: New field. Now
893 (struct tui_source_window) <showing_source_p>: New method.
894 (TUI_SRC_WIN): Change cast.
895 * tui/tui-data.c (tui_initialize_static_data): Update.
897 2019-07-17 Tom Tromey <tom@tromey.com>
899 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
901 * tui/tui-source.c (tui_source_window::location_matches_p): New
903 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
905 * tui/tui-data.h (struct tui_source_window_base)
906 <location_matches_p>: New method.
907 (struct tui_source_window, struct tui_disasm_window)
908 <location_matches_p>: Likewise.
910 2019-07-17 Tom Tromey <tom@tromey.com>
912 * tui/tui-win.c (tui_set_win_height_command): Rename from
914 (tui_set_win_height_command): Remove.
916 2019-07-17 Tom Tromey <tom@tromey.com>
918 * tui/tui-source.c (tui_source_window): New constructor. Add
920 (~tui_source_window): New destructor.
921 (tui_source_window::style_changed): New method.
922 * tui/tui-hooks.c (tui_redisplay_source): Remove.
923 (tui_attach_detach_observers): Update.
924 * tui/tui-data.h (struct tui_source_window): Make constructor not
925 inline. Add destructor.
926 (struct tui_source_window) <style_changed>: New method.
927 <m_observable>: New member.
929 2019-07-17 Tom Tromey <tom@tromey.com>
931 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
932 * tui/tui-win.c (tui_resize_all): Fix typo.
934 2019-07-17 Tom Tromey <tom@tromey.com>
936 * tui/tui-wingeneral.h (tui_refresh_all): Update.
937 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
938 (tui_refresh_all): Remove "list" parameter. Use foreach.
939 * tui/tui-win.c (window_name_completer): Use foreach.
940 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
941 (update_tab_width): Likewise.
942 * tui/tui-layout.c (show_layout): Update.
943 * tui/tui-data.h (class tui_window_iterator): New.
944 (struct all_tui_windows): New.
945 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
947 2019-07-17 Tom Tromey <tom@tromey.com>
949 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
950 parameter. Don't reference globals.
951 (tui_reg_command): Update.
953 2019-07-17 Tom Tromey <tom@tromey.com>
955 * tui/tui-regs.c (tui_show_registers): Simplify.
957 2019-07-17 Tom Tromey <tom@tromey.com>
959 * tui/tui-regs.c (tui_show_registers): Update.
960 (tui_show_register_group): Add win_info parameter.
962 2019-07-17 Tom Tromey <tom@tromey.com>
964 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
965 Rename from tui_display_reg_element_at_line.
966 (tui_data_window::display_registers_from_line): Update.
967 * tui/tui-data.h (struct tui_data_window)
968 <display_reg_element_at_line>: New method.
970 2019-07-17 Tom Tromey <tom@tromey.com>
972 * tui/tui-regs.h (tui_display_registers_from)
973 (tui_display_registers_from_line): Don't declare.
974 * tui/tui-windata.c (tui_data_window::display_all_data)
975 (tui_data_window::refresh_all)
976 (tui_data_window::do_scroll_vertical): Update.
977 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
978 from tui_display_registers_from.
979 (tui_display_reg_element_at_line): Update.
980 (tui_data_window::display_registers_from_line): Rename from
981 tui_display_registers_from_line.
982 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
983 display_registers_from_line>: New methods.
985 2019-07-17 Tom Tromey <tom@tromey.com>
987 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
988 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
989 from tui_erase_data_content.
990 (tui_data_window::display_all_data)
991 (tui_data_window::refresh_all)
992 (tui_data_window::do_scroll_vertical): Update.
993 * tui/tui-regs.c (tui_show_registers): Update.
994 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
997 2019-07-17 Tom Tromey <tom@tromey.com>
999 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1002 (tui_data_window::delete_data_content_windows): Rename from
1003 tui_delete_data_content_windows.
1004 (tui_data_window::display_all_data)
1005 (tui_data_window::do_scroll_vertical): Update.
1006 * tui/tui-data.h (struct tui_data_window)
1007 <delete_data_content_windows>: New method.
1009 2019-07-17 Tom Tromey <tom@tromey.com>
1011 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1012 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1014 2019-07-17 Tom Tromey <tom@tromey.com>
1016 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1017 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1018 from tui_display_all_data.
1020 (tui_data_window::do_make_visible_with_new_height): Update.
1021 * tui/tui-regs.c (tui_show_registers): Update.
1022 * tui/tui-layout.c (tui_set_layout): Update.
1023 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1026 2019-07-17 Tom Tromey <tom@tromey.com>
1028 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1029 * tui/tui-windata.c (tui_display_data_from): Remove.
1030 (tui_data_window::refresh_all): Update.
1032 2019-07-17 Tom Tromey <tom@tromey.com>
1034 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1035 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1036 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1037 tui_display_registers_from_line.
1038 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1039 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1040 "force_display" parameter.
1042 2019-07-17 Tom Tromey <tom@tromey.com>
1044 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1046 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1047 Rename from tui_first_reg_element_no_inline.
1048 (tui_display_reg_element_at_line)
1049 (tui_display_registers_from_line): Update.
1050 * tui/tui-data.h (struct tui_data_window)
1051 <first_reg_element_no_inline>: New method.
1053 2019-07-17 Tom Tromey <tom@tromey.com>
1055 * tui/tui-windata.c (tui_display_data_from)
1056 (tui_data_window::do_scroll_vertical): Update.
1057 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1058 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1059 Rename from tui_line_from_reg_element_no.
1060 (tui_display_registers_from_line): Update.
1061 * tui/tui-data.h (struct tui_data_window)
1062 <line_from_reg_element_no>: New method.
1064 2019-07-17 Tom Tromey <tom@tromey.com>
1066 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1067 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1068 tui_last_regs_line_no.
1069 (tui_display_reg_element_at_line)
1070 (tui_display_registers_from_line): Update.
1071 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1074 2019-07-17 Tom Tromey <tom@tromey.com>
1077 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1078 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1079 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1080 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1081 (tui_update_breakpoint_info): Likewise.
1082 * tui/tui-hooks.c (tui_event_create_breakpoint)
1083 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1086 2019-07-17 Tom Tromey <tom@tromey.com>
1088 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1090 2019-07-17 Tom Tromey <tom@tromey.com>
1092 * tui/tui-winsource.c (tui_update_source_window_as_is)
1093 (tui_update_source_windows_with_addr): Update.
1094 * tui/tui-source.h (tui_set_source_content)
1095 (tui_show_symtab_source): Add "win_info" parameter.
1096 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1098 (tui_show_symtab_source): Likewise.
1100 2019-07-17 Tom Tromey <tom@tromey.com>
1102 * tui/tui-wingeneral.c
1103 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1105 2019-07-17 Tom Tromey <tom@tromey.com>
1107 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1108 (struct tui_cmd_window) <can_scroll>: New method.
1109 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1112 2019-07-17 Tom Tromey <tromey@adacore.com>
1114 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1115 do_field_signed>: Rename. Change type of "value".
1116 * ui-out.c (ui_out::field_signed): Rename from field_int.
1117 Change type of "value".
1118 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1120 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1121 do_field_int. Change type of "value".
1122 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1123 do_field_int. Change type of "value".
1124 * tracepoint.c (trace_status_mi, tfind_1)
1125 (print_one_static_tracepoint_marker): Update.
1126 * thread.c (print_thread_info_1, print_selected_thread_frame):
1128 * stack.c (print_frame, print_frame_info): Update.
1129 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1131 * source.c (print_source_lines_base): Update.
1132 * skip.c (info_skip_command): Update.
1133 * record-btrace.c (btrace_ui_out_decode_error)
1134 (btrace_call_history_src_line): Update.
1135 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1137 * progspace.c (print_program_space): Update.
1138 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1139 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1140 do_field_int. Change type of "value".
1141 * mi/mi-out.c (mi_ui_out::do_table_begin)
1142 (mi_ui_out::do_table_header): Update.
1143 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1145 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1146 (mi_cmd_data_list_changed_registers, output_register)
1147 (mi_cmd_data_read_memory, mi_load_progress)
1148 (mi_cmd_trace_frame_collected): Update.
1149 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1151 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1152 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1153 (mi_cmd_var_list_children, varobj_update_one): Update.
1154 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1155 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1156 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1157 * inferior.c (print_inferior): Update.
1158 * gdb_bfd.c (print_one_bfd): Update.
1159 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1161 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1162 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1163 do_field_int. Change type of "value".
1164 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1165 do_field_int. Change type of "value".
1166 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1167 (print_one_breakpoint_location, print_it_catch_fork)
1168 (print_one_catch_fork, print_it_catch_vfork)
1169 (print_one_catch_vfork, print_it_catch_solib)
1170 (print_it_catch_exec, print_it_ranged_breakpoint)
1171 (print_mention_watchpoint, print_mention_masked_watchpoint)
1172 (bkpt_print_it, update_static_tracepoint): Update.
1173 * break-catch-throw.c (print_it_exception_catchpoint): Update.
1174 * break-catch-syscall.c (print_it_catch_syscall): Update.
1175 * ada-tasks.c (print_ada_task_info): Update.
1176 * ada-lang.c (print_it_exception, print_mention_exception):
1179 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
1181 PR breakpoints/24541
1182 * gdbarch.c: Regenerate.
1183 * gdbarch.h: Regenerate.
1184 * gdbarch.sh: Adjust return type and parameter types for
1185 'stap_adjust_register'.
1186 (i386_stap_adjust_register): Adjust signature and return new
1188 * stap-probe.c (stap_parse_register_operand): Adjust use of
1189 'gdbarch_stap_adjust_register'.
1191 2019-07-17 Tom Tromey <tromey@adacore.com>
1193 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
1195 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1197 (struct s390_process_info): Add initializers.
1198 (s390_add_process): Use new.
1199 (s390_linux_nat_target::low_forget_process): Use delete.
1200 (s390_linux_nat_target::low_new_fork)
1201 (s390_linux_nat_target::stopped_by_watchpoint)
1202 (s390_linux_nat_target::low_prepare_to_resume)
1203 (s390_linux_nat_target::insert_watchpoint)
1204 (s390_linux_nat_target::insert_hw_breakpoint)
1205 (s390_linux_nat_target::remove_watchpoint)
1206 (s390_linux_nat_target::remove_hw_breakpoint): Update.
1208 2019-07-16 John Baldwin <jhb@FreeBSD.org>
1210 * aarch64-fbsd-nat.c: Include regcache.h.
1211 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1213 (aarch64_fbsd_nat_target::fetch_registers)
1214 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1216 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1218 2019-07-16 John Baldwin <jhb@FreeBSD.org>
1220 * fbsd-nat.c: Include gdbarch.h.
1222 2019-07-15 Tom Tromey <tromey@adacore.com>
1224 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1226 2019-07-15 Tom Tromey <tromey@adacore.com>
1228 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1229 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1230 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1231 * cli-out.c (cli_ui_out::do_field_int): New method.
1232 * ui-out.c (ui_out::field_unsigned): New method.
1233 * symfile.c (generic_load): Use field_unsigned.
1234 (print_transfer_performance): Likewise.
1235 * record-btrace.c (ui_out_field_uint): Remove.
1236 (btrace_call_history_insn_range, btrace_call_history): Use
1238 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1240 * ui-out.h (class ui_out) <field_unsigned>: New method.
1241 <do_field_unsigned>: Likewise.
1243 2019-07-15 Tom Tromey <tromey@adacore.com>
1245 * mi/mi-main.c (list_available_thread_groups): Use field_string.
1246 * mi/mi-interp.c (mi_memory_changed): Use field_string.
1247 * target.c (flash_erase_command): Use field_string.
1248 * infrun.c (print_signal_received_reason): Use field_string.
1249 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1250 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1252 * ada-tasks.c (print_ada_task_info): Use field_string.
1254 2019-07-15 Tom Tromey <tromey@adacore.com>
1256 * target.c (flash_erase_command): Use field_core_addr.
1257 * symfile.c (generic_load): Use field_core_addr.
1258 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1259 Use field_core_addr.
1260 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1263 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1265 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1266 value if its desired type is smaller than a CORE_ADDR and signed.
1268 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1270 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1271 of changes to field names, and use new is_reference field to
1272 decide if a property is a reference or not.
1273 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1275 (struct dwarf2_property_baton): Update header comment, rename
1276 'referenced_type' to 'property_type' and update comments.
1277 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1278 default property type, store in property baton, update to take
1279 accound of renamed field.
1280 (read_func_scope): Update call to attr_to_dynamic_prop.
1281 (read_array_type): Likewise.
1282 (dwarf2_per_cu_addr_sized_int_type): New function.
1283 (read_subrange_index_type): Move type finding code to
1284 dwarf2_per_cu_addr_sized_int_type.
1285 (read_subrange_type): Update calls to attr_to_dynamic_prop.
1286 (dwarf2_per_cu_addr_type): New function.
1287 (set_die_type): Update calls to attr_to_dynamic_prop.
1289 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1291 * dwarf2read.c (read_subrange_index_type): New function.
1292 (read_subrange_type): Move code into new function and call it.
1293 * gdbtypes.c (create_range_type): Add some asserts.
1295 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1297 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1298 update return statements.
1299 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1300 declaration, and update comment to match.
1301 * gdbtypes.c (resolve_dynamic_array): Update call to
1302 dwarf2_evaluate_property to match new return type.
1304 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1306 * valarith.c (value_subscripted_rvalue): Change lowerbound
1307 parameter type from int to LONGEST.
1308 * value.h (value_subscripted_rvalue): Likewise in declaration.
1310 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1312 * cli/cli-utils.c (info_print_command_completer): New function.
1313 * cli/cli-utils.h: Add 'completer.h' include, and forward
1314 declaration for 'struct cmd_list_element'.
1315 (info_print_command_completer): Declare.
1316 * stack.c (_initialize_stack): Add completer for 'info locals' and
1318 * symtab.c (_initialize_symtab): Add completer for 'info
1319 variables' and 'info functions'.
1320 * NEWS: Mention completion for additional info commands.
1322 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1324 * cli/cli-utils.c (extract_info_print_args): Delete.
1325 (extract_arg_maybe_quoted): Delete.
1326 (info_print_options_defs): New variable.
1327 (make_info_print_options_def_group): New function.
1328 (extract_info_print_options): Define new function.
1329 * cli/cli-utils.h (extract_info_print_args): Delete.
1330 (struct info_print_options): New structure.
1331 (extract_info_print_options): Declare new function.
1332 * stack.c (info_locals_command): Update to use new
1333 extract_info_print_options, also add a header comment.
1334 (info_args_command): Likewise.
1335 * symtab.c (info_variables_command): Likewise.
1336 (info_functions_command): Likewise.
1338 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1340 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1341 to extract string arguments.
1342 * common/common-utils.c (extract_string_maybe_quoted): New function.
1343 * common/common-utils.h (extract_string_maybe_quoted): Declare.
1345 2019-07-11 Tom Tromey <tromey@adacore.com>
1347 * main.c (get_init_files): Use GDBINIT, not gdbinit.
1348 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1349 * top.h (gdbinit): Don't declare.
1350 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1352 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
1353 * top.c (gdb_init): Don't call init_cli_cmds.
1355 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1357 2019-07-11 Tom Tromey <tromey@adacore.com>
1359 * python/py-inferior.c (add_thread_object): Don't use thread_obj
1360 after it has been moved.
1362 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1364 * valops.c (value_must_coerce_to_target): Change return type to
1366 * value.h (value_must_coerce_to_target): Likewise.
1368 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
1370 * breakpoint.c (is_hardware_watchpoint): Remove
1371 forward-declaration.
1372 (is_masked_watchpoint): Change return type to bool.
1373 (is_tracepoint): Likewise.
1374 (is_breakpoint): Likewise.
1375 (is_hardware_watchpoint): Likewise.
1376 (is_watchpoint): Likewise.
1377 (is_no_memory_software_watchpoint): Likewise.
1378 (is_catchpoint): Likewise.
1379 (breakpoint_1): Make FILTER parameter's return type bool.
1380 is_masked_watchpoint): Change return type to bool.
1381 (save_breakpoints): Make FILTER parameter's return type bool.
1382 * breakpoint.h (is_breakpoint): Change return type to bool.
1383 (is_watchpoint): Likewise.
1384 (is_catchpoint): Likewise.
1385 (is_tracepoint): Likewise.
1387 2019-07-10 Tom Tromey <tom@tromey.com>
1389 * defs.h: Don't include gdbarch.h.
1390 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1391 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1392 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1393 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1394 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1395 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1396 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1397 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1398 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1399 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1400 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1401 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1402 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1403 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1404 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1405 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1406 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1407 record-btrace.c, record.h, regcache-dump.c, regcache.h,
1408 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1409 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1410 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1411 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1412 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1413 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1414 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1415 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1416 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1418 2019-07-10 Tom Tromey <tromey@adacore.com>
1420 * ada-lang.h (is_ada_exception_catchpoint): Declare.
1421 * breakpoint.c (init_ada_exception_breakpoint): Register as
1423 (print_one_breakpoint_location, print_one_breakpoint): Use
1424 is_ada_exception_catchpoint.
1425 * ada-lang.c (class ada_catchpoint_location): Pass
1426 bp_loc_software_breakpoint to bp_location constructor.
1427 (is_ada_exception_catchpoint): New function.
1429 2019-07-10 Tom Tromey <tromey@adacore.com>
1431 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
1433 (struct arm_exidx_entry): New method operator<.
1434 (struct arm_exidx_data) <section_maps>: Change type.
1435 (arm_exidx_data_free): Remove.
1436 (arm_exidx_data_key): Change type. Move lower.
1437 (arm_exidx_new_objfile): Update.
1438 (arm_compare_exidx_entries): Remove.
1439 (arm_find_exidx_entry, _initialize_arm_tdep)
1441 2019-07-10 Tom Tromey <tromey@adacore.com>
1443 * solib-spu.c (ocl_program_data_key): Change type.
1444 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1447 2019-07-10 Tom Tromey <tromey@adacore.com>
1449 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
1450 (struct solib_aix_inferior_data) <library_list>: Change type.
1451 (solib_aix_inferior_data_handle): Change type.
1452 (get_solib_aix_inferior_data): Update.
1453 (solib_aix_free_library_list): Remove.
1454 (library_list_start_library): Update.
1455 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1457 (solib_aix_get_library_list)
1458 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1459 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1461 2019-07-10 Tom Tromey <tromey@adacore.com>
1463 * solib-dsbt.c (struct dsbt_info): Add initializers.
1464 (solib_dsbt_pspace_data): Change type.
1465 (dsbt_pspace_data_cleanup): Remove.
1466 (get_dsbt_info, _initialize_dsbt_solib): Update.
1468 2019-07-10 Tom Tromey <tromey@adacore.com>
1470 * spu-tdep.c (spu_overlay_data): Change type.
1471 (spu_get_overlay_table, spu_overlay_new_objfile)
1472 (_initialize_spu_tdep): Update.
1474 2019-07-10 Tom Tromey <tromey@adacore.com>
1476 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1478 (dbx_objfile_data_key): Change type and declare later.
1479 (DBX_SYMFILE_INFO): Rewrite.
1480 * dbxread.c (dbx_objfile_data_key): Change type.
1481 (dbx_symfile_init): Update.
1482 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
1483 (coffstab_build_psymtabs, elfstab_build_psymtabs)
1484 (stabsect_build_psymtabs, _initialize_dbxread): Update.
1486 2019-07-10 Tom Tromey <tromey@adacore.com>
1488 * jit.c (jit_program_space_key): Change type. Move lower.
1489 (get_jit_program_space_data): Update.
1490 (jit_program_space_data_cleanup): Remove.
1491 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1493 (struct jit_program_space_data): Add initializers.
1495 2019-07-10 Tom Tromey <tromey@adacore.com>
1497 * solib-darwin.c (struct darwin_info): Add initializers.
1498 (solib_darwin_pspace_data): Change type.
1499 (darwin_pspace_data_cleanup): Remove.
1500 (get_darwin_info, _initialize_darwin_solib): Update.
1502 2019-07-10 Tom Tromey <tromey@adacore.com>
1504 * remote-sim.c (struct sim_inferior_data): Add initializers,
1505 constructor, and destructor.
1506 (sim_inferior_data_key): Change type. Move lower.
1507 (check_for_duplicate_sim_descriptor): Update.
1508 (get_sim_inferior_data): Use new. Update.
1509 (~sim_inferior_data_cleanup): Rename from
1510 sim_inferior_data_cleanup. Simplify.
1511 (gdbsim_close_inferior, simulator_command)
1512 (sim_command_completer, _initialize_remote_sim): Update.
1513 (next_pid, INITIAL_PID): Move earlier.
1515 2019-07-10 Tom Tromey <tromey@adacore.com>
1517 * python/python-internal.h (create_thread_object): Return
1519 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1520 * python/py-inferior.c (struct threadlist_entry): Add
1522 <thread_obj>: Now a gdbpy_ref.
1523 (thread_to_thread_object): Update.
1524 (add_thread_object): Use new.
1525 (delete_thread_object): Use delete.
1526 (infpy_threads): Update.
1527 (py_free_inferior): Update. Construct "inf_obj" after acquiring
1530 2019-07-10 Tom Tromey <tromey@adacore.com>
1532 * valops.c (value_cast): Specialize error message for Ada.
1534 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1536 * breakpoint.c (breakpoint_1): Update doc and parameter names.
1538 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1540 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1541 bpstat_should_step): Return bool, adjust comments.
1542 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1543 bpstat_should_step): Likewise.
1545 2019-07-10 Alan Hayward <alan.hayward@arm.com>
1547 * features/Makefile: Use feature target descriptions for Arm.
1548 * features/arm/arm-core.c: Generate new file.
1549 * features/arm/arm-fpa.c: Likewise.
1550 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1551 * features/arm/arm-m-profile.c: Likewise.
1552 * features/arm/arm-vfpv2.c: Likewise.
1553 * features/arm/arm-vfpv3.c: Likewise.
1554 * features/arm/xscale-iwmmxt.c: Likewise.
1555 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1557 2019-07-10 Alan Hayward <alan.hayward@arm.com>
1559 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1562 2019-07-10 Alan Hayward <alan.hayward@arm.com>
1564 * features/aarch64-pauth.c: Regenerate.
1566 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
1568 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1570 (bpstat_what): Use false instead of 0.
1572 2019-07-09 Pedro Alves <palves@redhat.com>
1574 * break-catch-throw.c (is_exception_catchpoint): New.
1575 * breakpoint.c (print_one_breakpoint_location): New parameter
1576 'raw_loc'. Handle it. Use
1577 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1578 looking at the breakpoint's type.
1579 (print_one_breakpoint): If handling "maint info breakpoints", also
1580 print locations of exception catchpoints.
1581 * breakpoint.h (is_exception_catchpoint): Declare.
1583 2019-07-09 Pedro Alves <palves@redhat.com>
1585 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1587 (allocate_location_exception_catchpoint): New.
1588 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1589 (initialize_throw_catchpoint_ops): Install
1590 allocate_location_exception_catchpoint as allocate_location
1592 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1593 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1595 (breakpoint_address_is_meaningful): Delete.
1596 (bl_address_is_meaningful): New.
1597 (breakpoint_locations_match): Adjust comment.
1598 (bp_location_from_bp_type): New, factored out of...
1599 (bp_location::bp_location(breakpoint *)): ... this.
1600 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1602 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
1603 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1604 breakpoint_address_is_meaningful.
1605 (bp_locations_compare): Adjust comment.
1606 (update_global_location_list): Use bl_address_is_meaningful
1607 instead of breakpoint_address_is_meaningful.
1608 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1610 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1611 * python/py-breakpoint.c (bppy_get_location): No longer check
1612 whether location is null.
1614 2019-07-09 Pedro Alves <palves@redhat.com>
1617 * breakpoint.c (print_one_breakpoint_location): Remove
1618 single-location assert.
1620 2019-07-09 Tom Tromey <tom@tromey.com>
1622 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1623 * configure: Rebuild.
1624 * configure.ac: Change common to gdbsupport.
1625 * gdbsupport: Rename from common.
1626 * acinclude.m4: Change common to gdbsupport.
1627 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1628 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1630 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1631 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1632 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1633 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1634 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1635 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1636 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1637 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1638 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1639 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1640 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1641 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1642 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1643 coff-pe-read.c, command.h, compile/compile-c-support.c,
1644 compile/compile-c.h, compile/compile-cplus-symbols.c,
1645 compile/compile-cplus-types.c, compile/compile-cplus.h,
1646 compile/compile-loc2c.c, compile/compile.c, completer.c,
1647 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1648 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1649 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1650 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1651 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1652 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1653 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1654 features/aarch64-core.c, features/aarch64-fpu.c,
1655 features/aarch64-pauth.c, features/aarch64-sve.c,
1656 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1657 features/i386/32bit-core.c, features/i386/32bit-linux.c,
1658 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1659 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1660 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1661 features/i386/64bit-core.c, features/i386/64bit-linux.c,
1662 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1663 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1664 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1665 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1666 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1667 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1668 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1669 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1670 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1671 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1672 go32-nat.c, guile/guile.c, guile/scm-ports.c,
1673 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1674 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1675 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1676 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1677 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1678 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1679 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1680 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1681 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1682 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1683 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1684 minsyms.c, mips-linux-tdep.c, namespace.h,
1685 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1686 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1687 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1688 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1689 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1690 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1691 nat/linux-waitpid.c, nat/mips-linux-watch.c,
1692 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1693 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1694 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1695 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1696 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1697 procfs.c, producer.c, progspace.h, psymtab.h,
1698 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1699 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1700 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1701 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1702 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1703 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1704 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1705 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1706 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1707 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1708 target-memory.c, target.c, target.h, target/waitstatus.c,
1709 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1710 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1711 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1712 unittests/array-view-selftests.c,
1713 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1714 unittests/common-utils-selftests.c,
1715 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1716 unittests/format_pieces-selftests.c,
1717 unittests/function-view-selftests.c,
1718 unittests/lookup_name_info-selftests.c,
1719 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1720 unittests/mkdir-recursive-selftests.c,
1721 unittests/observable-selftests.c,
1722 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1723 unittests/parse-connection-spec-selftests.c,
1724 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1725 unittests/scoped_fd-selftests.c,
1726 unittests/scoped_mmap-selftests.c,
1727 unittests/scoped_restore-selftests.c,
1728 unittests/string_view-selftests.c, unittests/style-selftests.c,
1729 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1730 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1731 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1732 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1733 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1734 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1736 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1738 * linespec.c (decode_digits_list_mode): Set explicit_line to a
1740 (decode_digits_ordinary): Set explicit_line field in sal.
1741 * symtab.c (skip_prologue_sal): Don't skip prologue for a
1742 symtab_and_line that was set on an explicit line number in
1743 assembler code. Do always update the recorded symtab and line if
1744 we do skip the prologue.
1746 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1748 * breakpoint.c (set_breakpoint_location_function): Remove
1749 explicit_loc parameter.
1750 (momentary_breakpoint_from_master): Update call to
1751 set_breakpoint_location_function.
1752 (add_location_to_breakpoint): Likewise.
1754 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1756 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1757 required features based on default bfd type when no specific bfd
1760 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1762 * NEWS: Mention that GDB printf and eval commands can now print
1763 C-style and Ada-style convenience var strings without
1764 calling the inferior.
1765 * printcmd.c (printf_c_string): Locally print GDB internal var
1766 instead of transiting via the inferior.
1767 (printf_wide_c_string): Likewise.
1769 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1771 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1773 2019-07-04 Tom Tromey <tom@tromey.com>
1776 * tui/tui-winsource.c (tui_clear_source_content): Update.
1777 (tui_source_window_base::set_is_exec_point_at): Fix comment.
1778 (tui_update_breakpoint_info): Update.
1779 (tui_set_exec_info_content): Update.
1780 * tui/tui-source.c (tui_set_source_content_nil): Update.
1781 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1783 * tui/tui-data.h (enum tui_bp_flag): New.
1784 (tui_bp_flags): New enum flags type.
1785 (struct tui_source_element) <break_mode>: Change type. Rename
1787 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1788 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
1790 * tui/tui-winsource.h: Fix comment.
1792 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1794 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1795 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1796 (store_fpregs_to_thread)
1797 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1798 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1799 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1800 (IWMMXT_REGS_SIZE): Add define.
1801 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1802 (fetch_vfp_regs, store_vfp_regs)
1803 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1804 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1806 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1808 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1810 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1811 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1812 (ARM_INT_REGISTER_SIZE): ...to this.
1813 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1814 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1815 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1816 (arm_linux_collect_gregset, supply_nwfpe_register)
1817 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1819 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1820 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1821 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1822 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1823 (arm_return_in_memory, arm_store_return_value)
1824 (arm_get_longjmp_target, arm_register_g_packet_guesses)
1825 (arm_record_ld_st_multiple): Likewise.
1826 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1827 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1829 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1831 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1832 AARCH64_DISPLACED_MODIFIED_INSNS.
1833 * aarch64-tdep.c (struct aarch64_displaced_step_data)
1834 (aarch64_displaced_step_copy_insn): Likewise.
1835 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1836 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1837 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1838 ARM_DISPLACED_MODIFIED_INSNS.
1839 * arm-tdep.c (arm_gdbarch_init): Likewise.
1840 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1841 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1842 (struct arm_displaced_step_closure): Use
1843 ARM_DISPLACED_MODIFIED_INSNS.
1845 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1847 * features/Makefile: Remove unused xml files.
1848 * features/aarch64.xml: Remove.
1849 * features/i386/amd64-avx-avx512-linux.xml: Remove.
1850 * features/i386/amd64-avx-avx512.xml: Remove.
1851 * features/i386/amd64-avx-linux.xml: Remove.
1852 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1853 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1854 * features/i386/amd64-avx-mpx-linux.xml: Remove.
1855 * features/i386/amd64-avx-mpx.xml: Remove.
1856 * features/i386/amd64-avx.xml: Remove.
1857 * features/i386/amd64-linux.xml: Remove.
1858 * features/i386/amd64-mpx-linux.xml: Remove.
1859 * features/i386/amd64-mpx.xml: Remove.
1860 * features/i386/amd64.xml: Remove.
1861 * features/i386/i386-avx-avx512-linux.xml: Remove.
1862 * features/i386/i386-avx-avx512.xml: Remove.
1863 * features/i386/i386-avx-linux.xml: Remove.
1864 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1865 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1866 * features/i386/i386-avx-mpx-linux.xml: Remove.
1867 * features/i386/i386-avx-mpx.xml: Remove.
1868 * features/i386/i386-avx.xml: Remove.
1869 * features/i386/i386-linux.xml: Remove.
1870 * features/i386/i386-mmx-linux.xml: Remove.
1871 * features/i386/i386-mmx.xml: Remove.
1872 * features/i386/i386-mpx-linux.xml: Remove.
1873 * features/i386/i386-mpx.xml: Remove.
1874 * features/i386/i386.xml: Remove.
1875 * features/i386/x32-avx-avx512-linux.xml: Remove.
1876 * features/i386/x32-avx-linux.xml: Remove.
1877 * features/i386/x32-linux.xml: Remove.
1879 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1881 * regformats/aarch64.dat: Remove.
1882 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1883 * regformats/i386/amd64-avx-linux.dat: Remove.
1884 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1885 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1886 * regformats/i386/amd64-linux.dat: Remove.
1887 * regformats/i386/amd64-mpx-linux.dat: Remove.
1888 * regformats/i386/amd64.dat: Remove.
1889 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1890 * regformats/i386/i386-avx-linux.dat: Remove.
1891 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1892 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1893 * regformats/i386/i386-linux.dat: Remove.
1894 * regformats/i386/i386-mmx-linux.dat: Remove.
1895 * regformats/i386/i386-mpx-linux.dat: Remove.
1896 * regformats/i386/i386.dat: Remove.
1897 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1898 * regformats/i386/x32-avx-linux.dat: Remove.
1899 * regformats/i386/x32-linux.dat: Remove.
1901 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1903 * aarch64-tdep.c: Remove xml self tests.
1904 * amd64-linux-tdep.c: Likewise.
1905 * amd64-tdep.c: Likewise.
1906 * i386-linux-tdep.c: Likewise.
1907 * i386-tdep.c: Likewise.
1909 2019-07-03 Pedro Alves <palves@redhat.com>
1912 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1913 (pipe_cmd_option_defs): New.
1914 (make_pipe_cmd_options_def_group): New.
1915 (pipe_command): Use gdb::option::process_options.
1916 (pipe_command_completer): New function.
1917 (_initialize_cli_cmds): Install completer for "pipe" command.
1919 2019-07-03 Pedro Alves <palves@redhat.com>
1921 * cli/cli-option.c (union option_value) <string>: New field.
1922 (struct option_def_and_value): Add ctor, move ctor, dtor and
1923 use DISABLE_COPY_AND_ASSIGN.
1924 (option_def_and_value::clear_value): New.
1925 (parse_option, save_option_value_in_ctx, get_val_type_str)
1926 (add_setshow_cmds_for_options): Handle var_string.
1927 * cli-option.h (union option_def::var_address) <string>: New
1929 (struct string_option_def): New.
1930 * maint-test-options.c (struct test_options_opts): Add default
1931 ctor and use DISABLE_COPY_AND_ASSIGN.
1932 <string_opt>: New field.
1933 (test_options_opts::~test_options_opts): New.
1934 (test_options_opts::dump): Also dump "-string".
1935 (test_options_option_defs): Install "string.
1937 2019-07-03 Pedro Alves <palves@redhat.com>
1939 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1940 option_value with a null enumeration.
1941 (complete_options): Save the option values in the context.
1942 (save_option_value_in_ctx): New, factored out from ...
1943 (process_options): ... here.
1944 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1946 * maint-test-options.c (test_options_opts::dump): New, factored
1948 (maintenance_test_options_command_mode): ... here.
1949 (maintenance_test_options_command_completion_result): Delete.
1950 (maintenance_test_options_command_completion_text): Update
1952 (maintenance_show_test_options_completion_result): Change
1953 prototype. Just print
1954 maintenance_test_options_command_completion_text.
1955 (save_completion_result): New.
1956 (maintenance_test_options_completer_mode): Pass options context to
1957 complete_options, and then save a dump.
1958 (_initialize_maint_test_options): Use add_cmd to install "maint
1959 show test-options-completion-result".
1961 2019-07-03 Pedro Alves <palves@redhat.com>
1963 * NEWS (New commands): Mention "with" and "maint with".
1964 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1965 (with_command, with_command_completer): New.
1966 (pipe_command): Adjust to new repeat_previous
1968 (_initialize_cli_cmds): Install the "with" command and its "w"
1970 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1972 * cli/cli-setshow.c (parse_cli_var_uinteger)
1973 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1974 argument strings for all var_types.
1975 (get_setshow_command_value_string): New, factored out from ...
1976 (do_show_command): ... this.
1977 * cli/cli-setshow.h: Include <string>.
1978 (get_setshow_command_value_string): Declare.
1979 * command.h (repeat_previous): Now returns const char *. Adjust
1981 * maint.c: Include "cli/cli-cmds.h".
1982 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1983 (_initialize_maint_cmds): Register the "maintenance with" command.
1984 * top.c (repeat_previous): Move bits from pipe_command here:
1985 Return the saved command line, if any; error out if there's no
1986 command to relaunch.
1988 2019-07-03 Pedro Alves <palves@redhat.com>
1990 * NEWS (New commands): Mention "maint set/show test-settings"
1991 instead of "maint test-settings".
1992 * maint-test-settings.c (maintenance_test_settings_list): Delete.
1993 (maintenance_test_settings_set_list): Rename to ...
1994 (maintenance_set_test_settings_list): ... this.
1995 (maintenance_test_settings_show_list): Rename to ...
1996 (maintenance_show_test_settings_list): ... this.
1997 (maintenance_test_settings_cmd): Delete.
1998 (maintenance_test_settings_set_cmd): ...
1999 (maintenance_set_test_settings_cmd): ... this.
2000 (maintenance_test_settings_show_cmd): ...
2001 (maintenance_show_test_settings_cmd): ... this.
2002 (maintenance_test_settings_show_value_cmd):
2003 (maintenance_show_test_settings_value_cmd): ... this.
2004 (_initialize_maint_test_settings): No longer install the "maint
2005 test-settings" prefix command. Rename "maint test-settings set"
2006 to "maint set test-settings", and "maint test-settings show" to
2007 "maint show test-settings". Adjust all subcommands.
2009 2019-07-03 Pedro Alves <palves@redhat.com>
2011 * maint-test-settings.c: Fix file's intro comment. Replace all
2012 references to "test-options" with references to "test-settings",
2015 2019-07-03 Pedro Alves <palves@redhat.com>
2017 * maint-test-settings.c (maintenance_test_settings_xxx)
2018 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2020 (maintenance_test_settings_enums): Use them.
2021 (maintenance_test_settings_enum): Default to
2022 maintenance_test_settings_xxx.
2023 (_initialize_maint_test_settings): Initialize
2024 MAINTENANCE_TEST_SETTINGS_FILENAME.
2026 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2028 * breakpoint.h (remove_breakpoints_inf): Change return type to
2029 void, move function documentation here.
2030 * breakpoint.c (remove_breakpoints_inf): Change return type to
2031 void, move function documentation to header.
2033 2019-07-02 Pedro Alves <palves@redhat.com>
2035 * NEWS (Completion improvements): Mention "info threads".
2036 * thread.c (struct info_threads_opts, info_threads_option_defs)
2037 (make_info_threads_options_def_group): New.
2038 (info_threads_command): Use gdb::option::process_options.
2039 (info_threads_command_completer): New.
2040 (_initialize_thread): Use gdb::option::build_help to build the
2041 help text for "info threads".
2043 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2045 * defs.h (generic_load): Move from here...
2046 * symfile.h (generic_load): ... to here. Rename name parameter
2048 * symfile.c (generic_load): Add comment.
2050 2019-07-01 Tom Tromey <tromey@adacore.com>
2053 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2054 declaration of without_params. Fix formatting.
2056 2019-07-01 Tom Tromey <tromey@adacore.com>
2058 * ada-exp.y (find_primitive_type): Update.
2059 * ada-lang.h (ada_lookup_symbol): Update.
2060 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2062 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2064 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2066 PR breakpoints/24541
2067 * gdbarch.c: Regenerate.
2068 * gdbarch.h: Regenerate.
2069 * gdbarch.sh: Add 'stap_adjust_register'.
2070 * i386-tdep.c: Include '<unordered_set>'.
2071 (i386_stap_adjust_register): New function.
2072 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2073 * stap-probe.c (stap_parse_register_operand): Call
2074 'gdbarch_stap_adjust_register'.
2076 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2079 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2080 * python/python.c (do_start_initialization): Use 'xmalloc'
2081 instead of 'PyMem_Malloc'.
2083 2019-06-28 Tom Tromey <tromey@adacore.com>
2085 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2088 2019-06-27 Tom Tromey <tromey@adacore.com>
2090 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2092 (arm_find_mapping_symbol, arm_record_special_symbol)
2093 (_initialize_arm_tdep): Update.
2094 (arm_objfile_data_free): Remove.
2096 2019-06-27 Tom Tromey <tromey@adacore.com>
2098 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2099 to cp_print_static_field.
2101 2019-06-26 Tom Tromey <tromey@adacore.com>
2103 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2104 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2107 2019-06-26 Alan Hayward <alan.hayward@arm.com>
2109 * features/aarch64-core.c (create_feature_aarch64_core):
2111 * features/aarch64-core.xml: Add cpsr flags.
2113 2019-06-26 Alan Hayward <alan.hayward@arm.com>
2115 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2116 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2118 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2120 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2122 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2124 (arm_record_special_symbol): Don't insert new symbol in sorted
2125 position, push it at the end.
2127 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2129 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2130 (arm_mapping_symbol_s): Remove.
2131 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2132 (arm_mapping_symbol_vec): New typedef.
2133 (struct arm_per_objfile): Add constructor.
2134 <section_maps>: Change type to
2135 std::unique_ptr<arm_mapping_symbol_vec[]>.
2136 (arm_compare_mapping_symbols): Remove.
2137 (arm_find_mapping_symbol): Adjust to section_maps type change.
2138 (arm_objfile_data_free): Call delete on arm_per_objfile.
2139 (arm_record_special_symbol): Adjust to section_maps type change.
2140 Allocate arm_per_objfile with new.
2142 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2144 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2145 with the command prefix.
2147 2019-06-25 Tom Tromey <tom@tromey.com>
2149 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2150 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2152 2019-06-25 Tom Tromey <tom@tromey.com>
2154 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2156 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2159 2019-06-25 Tom Tromey <tom@tromey.com>
2161 * tui/tui-winsource.c
2162 (tui_source_window_base::set_is_exec_point_at): Add check against
2165 2019-06-25 Tom Tromey <tom@tromey.com>
2167 * tui/tui-source.c (tui_set_source_content): Don't check before
2169 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2171 2019-06-25 Tom Tromey <tom@tromey.com>
2173 * tui/tui-winsource.h (tui_update_source_window_as_is)
2174 (tui_alloc_source_buffer, tui_line_is_displayed)
2175 (tui_addr_is_displayed): Change type of win_info.
2176 * tui/tui-winsource.c (tui_update_source_window_as_is)
2177 (tui_clear_source_content, tui_show_source_line)
2178 (tui_show_source_content, tui_source_window_base::refill)
2179 (tui_source_window_base::set_is_exec_point_at)
2180 (tui_source_window_base::set_is_exec_point_at)
2181 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2182 (tui_alloc_source_buffer, tui_line_is_displayed)
2183 (tui_addr_is_displayed): Change type of win_info. Update.
2184 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2185 (tui_source_window_base::do_make_visible_with_new_height):
2187 * tui/tui-source.c (tui_set_source_content)
2188 (tui_set_source_content_nil)
2189 (tui_source_window::do_scroll_vertical): Update.
2190 * tui/tui-layout.c (show_layout): Update.
2191 * tui/tui-disasm.c (tui_set_disassem_content)
2192 (tui_disasm_window::do_scroll_vertical): Update.
2193 * tui/tui-data.h (tui_win_content): Remove.
2194 (struct tui_gen_win_info) <content, content_size>: Remove.
2195 (struct tui_source_element): Add initializers and destructor.
2196 (union tui_which_element, struct tui_win_element): Remove.
2197 (struct tui_source_window_base) <content>: New field.
2198 (struct tui_data_window): Remove destructor.
2199 (tui_alloc_content, tui_free_win_content)
2200 (tui_free_all_source_wins_content): Don't declare.
2201 * tui/tui-data.c (tui_initialize_static_data): Update.
2202 (init_content_element, tui_alloc_content): Remove.
2203 (~tui_gen_win_info): Update.
2204 (~tui_data_window, tui_free_all_source_wins_content)
2205 (tui_free_win_content, free_content, free_content_elements):
2208 2019-06-25 Tom Tromey <tom@tromey.com>
2210 * tui/tui-winsource.h (tui_clear_source_content)
2211 (tui_erase_source_content, tui_show_source_content): Change type
2213 * tui/tui-winsource.c (tui_clear_source_content)
2214 (tui_erase_source_content, tui_show_source_content): Change type
2216 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2217 * tui/tui-source.h (tui_set_source_content_nil): Change type of
2219 * tui/tui-source.c (tui_set_source_content_nil): Change type of
2221 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2223 2019-06-25 Tom Tromey <tom@tromey.com>
2225 * tui/tui-winsource.c (tui_clear_source_content)
2226 (tui_source_window_base::set_is_exec_point_at): Update.
2227 * tui/tui-source.c (tui_set_source_content_nil): Update.
2228 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2230 * tui/tui-data.c (init_content_element): Update.
2232 2019-06-25 Tom Tromey <tom@tromey.com>
2234 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2235 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2236 * tui/tui-layout.c (init_and_make_win): Update.
2237 * tui/tui.h (enum tui_win_type): Update.
2238 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2239 tui_win_is_auxillary.
2240 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2241 tui_win_is_auxillary.
2243 2019-06-25 Tom Tromey <tom@tromey.com>
2245 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2246 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2247 (tui_delete_data_content_windows, tui_display_all_data)
2248 (tui_data_window::do_scroll_vertical, tui_display_data_from):
2250 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2251 * tui/tui-regs.c (tui_last_regs_line_no)
2252 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2253 (tui_show_registers): Update.
2254 (tui_show_register_group): Return void. Update.
2255 (tui_display_registers_from, tui_display_reg_element_at_line)
2256 (tui_display_registers_from_line, tui_check_register_values):
2258 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2260 (struct tui_data_window) <regs_content>: Now a std::vector.
2261 <regs_content_count>: Remove.
2262 (tui_add_content_elements, tui_free_data_content): Don't declare.
2263 * tui/tui-data.c (tui_data_window::clear_detail): Update.
2264 (init_content_element): Remove DATA_WIN case. Add assert.
2265 (tui_add_content_elements): Remove.
2266 (tui_data_window): Update.
2267 (tui_free_data_content): Remove.
2268 (free_content_elements): Remove DATA_WIN case.
2270 2019-06-25 Tom Tromey <tom@tromey.com>
2272 * tui/tui-data.c (tui_data_item_window): Update.
2273 * tui/tui-windata.h (tui_check_data_values): Don't declare.
2274 * tui/tui-windata.c (tui_display_all_data)
2275 (tui_display_data_from_line): Update.
2276 (tui_check_data_values): Remove.
2277 * tui/tui-regs.c (tui_show_register_group)
2278 (tui_display_reg_element_at_line): Update.
2279 * tui/tui-hooks.c (tui_register_changed)
2280 (tui_refresh_frame_and_register_information): Call
2281 tui_check_register_values.
2282 * tui/tui-data.h (struct tui_data_window) <data_content,
2283 data_content_count, data_type>: Remove.
2284 (enum tui_data_type): Remove.
2286 * tui/tui-data.c (tui_data_window::clear_detail)
2287 (~tui_data_window): Update.
2289 2019-06-25 Tom Tromey <tom@tromey.com>
2291 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2293 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2294 Rename from tui_first_data_item_displayed. Update.
2295 (tui_data_window::refresh_all)
2296 (tui_data_window::do_scroll_vertical): Update.
2297 * tui/tui-data.h (struct tui_data_window)
2298 <first_data_item_displayed>: Declare new method.
2300 2019-06-25 Tom Tromey <tom@tromey.com>
2302 * tui/tui-data.h (tui_init_generic_part): Don't declare.
2303 * tui/tui-data.c (tui_init_generic_part): Remove, moving
2305 (tui_initialize_static_data): ...here.
2307 2019-06-25 Tom Tromey <tom@tromey.com>
2309 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2310 (tui_display_registers_from, tui_check_register_values): Update.
2311 (tui_display_register): Remove win_info parameter; update.
2312 (tui_get_register): Change type of parameters.
2313 * tui/tui-data.h (struct tui_data_element): Remove.
2314 (union tui_which_element) <data>: Remove.
2315 <data_window>: Change type.
2316 (struct tui_data_item_window): New.
2317 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2319 (~tui_data_item_window): New destructor.
2320 (free_content_elements): Remove DATA_ITEM_WIN case.
2322 2019-06-25 Tom Tromey <tom@tromey.com>
2324 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2327 2019-06-25 Tom Tromey <tom@tromey.com>
2329 * tui/tui-data.h (struct tui_command_element): Remove.
2330 (union tui_which_element) <command>: Remove.
2331 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
2333 (free_content_elements): Remove CMD_WIN case.
2335 2019-06-25 Tom Tromey <tom@tromey.com>
2337 * tui/tui-layout.c (tui_set_layout): Update.
2338 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2339 * tui/tui-data.c (layout_def): Update.
2341 2019-06-25 Tom Tromey <tom@tromey.com>
2343 * tui/tui-wingeneral.c (tui_refresh_all): Update.
2344 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2345 (tui_source_window_base::set_new_height): Update.
2346 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2348 (tui_set_locator_fullname, tui_set_locator_info)
2349 (tui_show_frame_info): Update.
2350 * tui/tui-source.c (tui_set_source_content)
2351 (tui_source_is_displayed): Update.
2352 * tui/tui-layout.c (show_source_disasm_command, show_data)
2353 (show_source_or_disasm_and_command): Update.
2354 * tui/tui-disasm.c (tui_set_disassem_content)
2355 (tui_get_begin_asm_address): Update.
2356 * tui/tui-data.h (struct tui_locator_element): Remove.
2357 (union tui_which_element) <locator>: Remove.
2358 (struct tui_locator_window): New.
2359 (tui_locator_win_info_ptr): Change return type.
2360 * tui/tui-data.c (_locator): Change type.
2361 (tui_locator_win_info_ptr): Change return type.
2362 (init_content_element): Remove LOCATOR_WIN case. Add assert.
2363 (tui_alloc_content): Add assert.
2365 2019-06-25 Tom Tromey <tom@tromey.com>
2367 * tui/tui-winsource.c
2368 (tui_exec_info_window::maybe_allocate_content): New method.
2369 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2370 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2371 (make_source_or_disasm_window): Add cast.
2372 * tui/tui-data.h (union tui_which_element) <simple_string>:
2374 (struct tui_source_info): New.
2375 (struct tui_source_window_base) <execution_info>: Change type.
2376 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2377 case, and add assert.
2378 (tui_alloc_content): Add assert.
2380 2019-06-25 Tom Tromey <tom@tromey.com>
2382 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2383 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2384 * tui/tui-data.c (tui_alloc_win_info): Remove.
2386 2019-06-25 Tom Tromey <tom@tromey.com>
2388 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2389 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2392 2019-06-25 Tom Tromey <tom@tromey.com>
2394 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2395 make_visible_with_new_height method.
2396 (tui_win_info::make_visible_with_new_height): New method.
2397 (tui_source_window_base::do_make_visible_with_new_height)
2398 (tui_data_window::do_make_visible_with_new_height)
2399 (tui_cmd_window::do_make_visible_with_new_height): New methods.
2400 (make_visible_with_new_height): Remove.
2401 (tui_resize_all, tui_adjust_win_heights): Use
2402 make_visible_with_new_height method.
2403 * tui/tui-data.h (struct tui_win_info)
2404 <do_make_visible_with_new_height, make_visible_with_new_height>:
2406 (struct tui_source_window_base, struct tui_data_window)
2407 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2410 2019-06-25 Tom Tromey <tom@tromey.com>
2412 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2414 (update_tab_width): Call update_tab_width method.
2415 * tui/tui-data.h (struct tui_win_info)
2416 (struct tui_source_window_base) <update_tab_width>: New methods.
2418 2019-06-25 Tom Tromey <tom@tromey.com>
2420 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2422 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2424 (tui_gen_win_info::make_visible): Update.
2425 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2427 * tui/tui-data.h (enum tui_box): New enum.
2428 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2430 2019-06-25 Tom Tromey <tom@tromey.com>
2432 * tui/tui-layout.c (make_source_or_disasm_window): Always use
2433 init_and_make_win for EXEC_INFO_WIN.
2434 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2436 (struct tui_win_info) <~tui_win_info>: Inline.
2437 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2439 * tui/tui-data.c (source_win, disasm_win): Remove globals.
2440 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2442 (tui_initialize_static_data): Update.
2443 (~tui_gen_win_info): Handle more cleanup here.
2444 (~tui_source_window_base): Delete "execution_info".
2445 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2447 2019-06-25 Tom Tromey <tom@tromey.com>
2449 * tui/tui-layout.c (make_command_window): Don't set
2451 (show_source_disasm_command): Call the reset method.
2452 (show_data): Don't set can_highlight. Call the reset method.
2453 (tui_gen_win_info::reset): Rename from init_gen_win_info
2454 (init_and_make_win): Simplify. Return tui_gen_win_info.
2455 (show_source_or_disasm_and_command): Call the reset method.
2456 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2457 (struct tui_cmd_window): Set can_highlight.
2459 2019-06-25 Tom Tromey <tom@tromey.com>
2461 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2463 (tui_make_visible, tui_make_invisible): Rewrite.
2464 (tui_win_info::make_visible): Remove.
2465 (tui_source_window_base::make_visible): Update.
2466 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2467 method. Moved from...
2468 (struct tui_win_info) <make_visible>: ...here.
2470 2019-06-25 Tom Tromey <tom@tromey.com>
2472 * tui/tui-winsource.c
2473 (tui_source_window_base::do_scroll_horizontal): Remove direction
2475 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2476 direction parameter.
2477 * tui/tui-win.c (tui_win_info::forward_scroll)
2478 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2479 (tui_win_info::right_scroll): Update.
2480 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2481 direction parameter.
2482 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2483 direction parameter.
2484 * tui/tui-data.h (enum tui_scroll_direction): Remove.
2485 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2486 Remove direction parameter.
2487 (struct tui_source_window_base, struct tui_source_window)
2488 (struct tui_disasm_window, struct tui_data_window)
2489 (struct tui_cmd_window): Update.
2491 2019-06-25 Tom Tromey <tom@tromey.com>
2493 * tui/tui-winsource.h (tui_set_exec_info_content)
2494 (tui_show_exec_info_content, tui_erase_exec_info_content)
2495 (tui_clear_exec_info_content, tui_update_exec_info): Change
2496 argument to tui_source_window_base.
2497 * tui/tui-winsource.c (tui_set_exec_info_content)
2498 (tui_show_exec_info_content, tui_erase_exec_info_content)
2499 (tui_clear_exec_info_content, tui_update_exec_info): Change
2500 argument to tui_source_window_base.
2502 2019-06-25 Tom Tromey <tom@tromey.com>
2504 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2505 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2507 2019-06-25 Tom Tromey <tom@tromey.com>
2509 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2512 2019-06-25 Tom Tromey <tom@tromey.com>
2514 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2516 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2518 * tui/tui-source.c (tui_set_source_content): Update.
2519 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2521 2019-06-25 Tom Tromey <tom@tromey.com>
2523 * tui/tui-win.c (window_name_completer, tui_set_focus)
2524 (tui_all_windows_info): Use name method.
2525 * tui/tui-data.h (struct tui_gen_win_info)
2526 (struct tui_source_window, struct tui_disasm_window)
2527 (struct tui_data_window, struct tui_cmd_window) <name>: New
2529 (tui_win_name): Don't declare.
2530 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2531 (tui_win_name): Remove.
2533 2019-06-25 Tom Tromey <tom@tromey.com>
2535 * tui/tui-winsource.h (tui_update_source_window)
2536 (tui_update_source_window_as_is): Change parameter type.
2537 * tui/tui-winsource.c (tui_update_source_window): Change win_info
2538 to be a tui_source_window_base.
2539 (tui_update_source_window_as_is): Likewise.
2540 * tui/tui-win.c (make_visible_with_new_height): Update.
2542 2019-06-25 Tom Tromey <tom@tromey.com>
2544 * tui/tui-winsource.c (tui_erase_source_content)
2545 (tui_show_source_content, tui_show_exec_info_content)
2546 (tui_erase_exec_info_content): Use refresh_window method.
2547 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2548 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2549 from tui_refresh_win.
2550 (tui_data_window::refresh_window): New method.
2551 (tui_win_info::refresh, tui_source_window_base::refresh)
2552 (tui_refresh_all): Use refresh_window method.
2553 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2555 * tui/tui-regs.c (tui_display_register): Call refresh_window
2557 * tui/tui-layout.c (show_source_disasm_command)
2558 (show_source_or_disasm_and_command): Call refresh_window method.
2559 * tui/tui-data.h (struct tui_gen_win_info)
2560 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2563 2019-06-25 Tom Tromey <tom@tromey.com>
2565 * tui/tui.c (tui_rl_other_window, tui_enable)
2566 (tui_is_window_visible, tui_get_command_dimension): Update.
2567 * tui/tui-winsource.c (tui_update_source_window_as_is)
2568 (tui_clear_source_content, tui_erase_source_content)
2569 (tui_show_source_line, tui_source_window_base::refill)
2570 (tui_source_window_base::do_scroll_horizontal)
2571 (tui_source_window_base::set_is_exec_point_at)
2572 (tui_update_breakpoint_info, tui_set_exec_info_content)
2573 (tui_alloc_source_buffer, tui_line_is_displayed)
2574 (tui_addr_is_displayed): Update.
2575 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2576 (tui_check_and_display_highlight_if_needed)
2577 (tui_win_info::make_visible, tui_win_info::refresh)
2578 (tui_refresh_all): Update.
2579 * tui/tui-windata.c (tui_first_data_item_displayed)
2580 (tui_delete_data_content_windows, tui_erase_data_content)
2581 (tui_display_all_data, tui_data_window::refresh_all)
2582 (tui_check_data_values): Update.
2583 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2584 (tui_set_win_focus_to, tui_win_info::forward_scroll)
2585 (tui_win_info::backward_scroll, tui_refresh_all_win)
2586 (tui_resize_all, tui_set_focus, tui_all_windows_info)
2587 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2588 (tui_source_window_base::set_new_height)
2589 (tui_data_window::set_new_height)
2590 (make_invisible_and_set_new_height)
2591 (make_visible_with_new_height, new_height_ok)
2592 (parse_scrolling_args): Update.
2593 * tui/tui-stack.c (tui_show_frame_info): Update.
2594 * tui/tui-source.c (tui_set_source_content)
2595 (tui_set_source_content_nil, tui_source_is_displayed)
2596 (tui_source_window::do_scroll_vertical): Update.
2597 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2598 (tui_display_registers_from, tui_display_reg_element_at_line)
2599 (tui_check_register_values, tui_reg_command): Update.
2600 * tui/tui-layout.c (tui_default_win_height)
2601 (show_source_disasm_command, show_data, init_and_make_win)
2602 (show_source_or_disasm_and_command): Update.
2603 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2604 (tui_redisplay_readline, tui_mld_flush)
2605 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2607 * tui/tui-disasm.c (tui_set_disassem_content)
2608 (tui_disasm_window::do_scroll_vertical): Update.
2609 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2611 (struct tui_win_info): Derive from tui_gen_win_info.
2612 <~tui_win_info>: Mark as override.
2613 <generic>: Remove member.
2614 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2615 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2616 (~tui_data_window, ~tui_win_info)
2617 (tui_free_all_source_wins_content): Update.
2618 * tui/tui-command.c (tui_refresh_cmd_win): Update.
2620 2019-06-25 Tom Tromey <tom@tromey.com>
2622 * tui/tui-layout.c (init_and_make_win): Use new.
2623 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2624 destructor, initializers.
2625 (tui_alloc_generic_win_info): Don't declare.
2626 * tui/tui-data.c (_locator): Add argument to constructor.
2627 (source_win, disasm_win): New globals.
2628 (exec_info): Remove.
2629 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2631 (tui_alloc_generic_win_info): Remove.
2632 (init_content_element): Use new.
2633 (tui_win_info::tui_win_info): Update.
2634 (free_content_elements) <case DATA_WIN>: Use delete.
2636 2019-06-25 Tom Tromey <tom@tromey.com>
2638 * tui/tui-wingeneral.c (tui_refresh_win): Update.
2639 * tui/tui-windata.c (tui_first_data_item_displayed)
2640 (tui_delete_data_content_windows): Update.
2641 * tui/tui-win.c (tui_data_window::set_new_height): Update.
2642 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2643 (tui_display_registers_from, tui_check_register_values): Update.
2644 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2646 * tui/tui-data.c (init_content_element): Update. Allocate the new
2648 (tui_free_data_content): Update.
2649 (free_content_elements) <case DATA_WIN>: Free the window.
2651 2019-06-25 Tom Tromey <tom@tromey.com>
2653 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2655 * tui/tui-layout.c (make_command_window)
2656 (show_source_disasm_command, show_data, init_and_make_win)
2657 (show_source_or_disasm_and_command): Update.
2658 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2660 <can_highight, is_highlighted>: Now bool.
2661 (tui_set_win_highlight): Don't declare.
2662 * tui/tui-data.c (tui_set_win_highlight): Remove.
2664 2019-06-25 Tom Tromey <tom@tromey.com>
2666 * tui/tui-wingeneral.c (make_visible): Remove check of window
2669 2019-06-25 Tom Tromey <tom@tromey.com>
2671 * tui/tui-win.c (tui_win_info::max_height)
2672 (tui_cmd_window::max_height): New methods.
2673 (new_height_ok): Call max_height.
2674 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2675 <max_height>: New method.
2677 2019-06-25 Tom Tromey <tom@tromey.com>
2679 * tui/tui-win.c (tui_source_window_base::set_new_height)
2680 (tui_data_window::set_new_height): New methods.
2681 (make_invisible_and_set_new_height): Call set_new_height method.
2682 * tui/tui-data.h (struct tui_win_info)
2683 (struct tui_source_window_base, struct tui_data_window)
2684 <set_new_height>: New method.
2686 2019-06-25 Tom Tromey <tom@tromey.com>
2688 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2689 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2690 tui_refresh_data_win.
2691 * tui/tui-win.c (tui_source_window_base::refresh_all): New
2693 (tui_refresh_all_win): Call the refresh_all method.
2694 (tui_set_focus): Likewise.
2695 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2696 (struct tui_source_window_base, struct tui_data_window) <refresh>:
2699 2019-06-25 Tom Tromey <tom@tromey.com>
2701 * tui/tui-winsource.h (tui_refill_source_window)
2702 (tui_set_is_exec_point_at): Don't declare.
2703 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2704 (tui_source_window_base::refill): Rename from
2705 tui_refill_source_window.
2706 (tui_source_window_base::do_scroll_horizontal): Update.
2707 (tui_source_window_base::set_is_exec_point_at): Rename from
2708 tui_set_is_exec_point_at.
2709 (tui_update_all_breakpoint_info): Update.
2710 * tui/tui-stack.c (tui_show_frame_info): Update.
2711 * tui/tui-layout.c (show_data): Add cast.
2712 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2713 * tui/tui-data.h (struct tui_source_window_base) <refill,
2714 set_is_exec_point_at>: New methods.
2715 (tui_source_windows, tui_add_to_source_windows): Update types.
2716 (tui_add_to_source_windows): Remove redundant declaration.
2717 * tui/tui-data.c (source_windows): Store tui_source_window_base.
2718 (tui_source_windows): Change return type.
2719 (tui_clear_source_windows_detail): Update.
2720 (tui_add_to_source_windows): Change type of parameter.
2721 (tui_free_all_source_wins_content): Update.
2723 2019-06-25 Tom Tromey <tom@tromey.com>
2725 * tui/tui-wingeneral.c (tui_win_info::refresh)
2726 (tui_source_window_base::refresh): New methods.
2727 (tui_refresh_all): Call the refresh method.
2728 * tui/tui-data.h (struct tui_win_info)
2729 (struct tui_source_window_base) <refresh>: New method.
2731 2019-06-25 Tom Tromey <tom@tromey.com>
2733 * tui/tui.h (tui_is_window_visible): Return bool.
2734 * tui/tui.c (tui_is_window_visible): Return bool.
2735 * tui/tui-wingeneral.c (tui_make_window, make_visible)
2736 (tui_make_visible, tui_make_invisible)
2737 (tui_win_info::make_visible)
2738 (tui_source_window_base::make_visible, make_all_visible)
2739 (tui_make_all_visible, tui_make_all_invisible): Update.
2740 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2741 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2743 (struct tui_win_info, struct tui_source_window_base)
2744 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2745 * tui/tui-data.c (tui_init_generic_part): Update.
2747 2019-06-25 Tom Tromey <tom@tromey.com>
2749 * tui/tui-wingeneral.c (tui_win_info::make_visible)
2750 (tui_source_window_base::make_visible): New methods.
2751 (make_all_visible): Make method call.
2752 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2753 (struct tui_source_window_base, struct tui_cmd_window): Override
2755 (tui_win_is_source_type): Don't declare.
2756 * tui/tui-data.c (tui_win_is_source_type): Remove.
2758 2019-06-25 Tom Tromey <tom@tromey.com>
2760 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2763 2019-06-25 Tom Tromey <tom@tromey.com>
2765 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2766 Inline constructor. Add initializers for members.
2767 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2768 constructors; now inline in class.
2770 2019-06-25 Tom Tromey <tom@tromey.com>
2772 * tui/tui-regs.c (tui_show_registers): Update.
2773 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2775 * tui/tui-data.c (tui_data_window::clear_detail)
2776 (tui_data_window): Update.
2778 2019-06-25 Tom Tromey <tom@tromey.com>
2780 * tui/tui-windata.c (tui_display_all_data)
2781 (tui_display_data_from_line, tui_display_data_from)
2782 (tui_check_data_values, tui_data_window::do_scroll_vertical):
2784 * tui/tui-regs.c (tui_last_regs_line_no)
2785 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2786 (tui_show_registers, tui_show_register_group)
2787 (tui_display_registers_from, tui_display_reg_element_at_line)
2788 (tui_display_registers_from_line, tui_check_register_values)
2789 (tui_reg_next, tui_reg_prev): Update.
2790 * tui/tui-layout.c (tui_set_layout, show_data): Update.
2791 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
2793 (struct tui_win_info) <detail>: Remove. Add new fields from
2795 (TUI_DATA_WIN): Add cast.
2796 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2797 (~tui_data_window): Simplify.
2799 2019-06-25 Tom Tromey <tom@tromey.com>
2801 * tui/tui-layout.c (show_source_disasm_command)
2802 (show_source_or_disasm_and_command): Update.
2803 * tui/tui-io.c (update_cmdwin_start_line)
2804 (tui_redisplay_readline): Update.
2805 * tui/tui-data.h (struct tui_command_info): Remove.
2806 (struct tui_win_info) <detail>: Remove command_info member.
2807 (struct tui_data_window) <start_line>: New member, from
2809 (TUI_CMD_WIN): Add casts.
2811 2019-06-25 Tom Tromey <tom@tromey.com>
2813 * tui/tui-winsource.c (tui_update_source_window)
2814 (tui_refill_source_window)
2815 (tui_source_window_base::do_scroll_horizontal)
2816 (tui_update_breakpoint_info, tui_set_exec_info_content)
2817 (tui_show_exec_info_content, tui_erase_exec_info_content)
2818 (tui_clear_exec_info_content): Update.
2819 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2821 * tui/tui-win.c (make_invisible_and_set_new_height)
2822 (make_visible_with_new_height): Update.
2823 * tui/tui-source.c (tui_set_source_content)
2824 (tui_show_symtab_source): Update.
2825 * tui/tui-layout.c (extract_display_start_addr)
2826 (show_source_disasm_command, show_data)
2827 (make_source_or_disasm_window)
2828 (show_source_or_disasm_and_command): Update.
2829 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2830 (tui_disasm_window::do_scroll_vertical): Remove shadowing
2832 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
2833 to tui_source_window_base.
2834 (struct tui_win_info) <detail>: Remove source_info member.
2835 (struct tui_source_window_base) <has_locator>: Inline.
2836 Move contents from tui_source_info; rename has_locator member to
2838 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2839 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2841 (tui_source_window_base::clear_detail, ~tui_source_window_base):
2843 (tui_free_all_source_wins_content): Cast to
2844 tui_source_window_base.
2846 2019-06-25 Tom Tromey <tom@tromey.com>
2848 * tui/tui-win.c (make_invisible_and_set_new_height)
2849 (make_visible_with_new_height): Call has_locator method.
2850 * tui/tui-layout.c (show_source_disasm_command, show_data)
2851 (show_source_or_disasm_and_command): Update for bool change.
2852 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2853 (tui_win_info) <has_locator>: New method.
2854 (struct tui_source_window_base) <has_locator>: New method.
2855 (tui_win_has_locator): Don't declare.
2856 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2857 from tui_win_has_locator.
2858 (tui_source_window_base): Use false, not FALSE.
2860 2019-06-25 Tom Tromey <tom@tromey.com>
2862 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2863 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2864 clear_detail method directly.
2865 (tui_clear_win_detail): Remove.
2867 2019-06-25 Tom Tromey <tom@tromey.com>
2869 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2870 "this", not TUI_DISASM_WIN.
2872 2019-06-25 Tom Tromey <tom@tromey.com>
2874 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
2876 * tui/tui-winsource.c
2877 (tui_source_window_base::do_scroll_horizontal): Rename from
2878 tui_horizontal_source_scroll.
2879 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2880 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2881 from tui_vertical_data_scroll.
2882 * tui/tui-win.h (tui_scroll): Don't declare.
2883 * tui/tui-win.c (tui_win_info::forward_scroll)
2884 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2885 (tui_win_info::right_scroll): Rename and update.
2886 (tui_scroll_forward_command, tui_scroll_backward_command)
2887 (tui_scroll_left_command, tui_scroll_right_command): Update.
2888 (tui_scroll): Remove.
2889 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2890 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2891 from tui_vertical_source_scroll.
2892 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2893 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2894 from tui_vertical_disassem_scroll.
2895 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2896 do_scroll_horizontal>: New methods.
2897 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2899 (struct tui_source_window_base): Add do_scroll_horizontal.
2900 (struct tui_source_window, struct tui_disasm_window): Add
2902 (struct tui_data_window, struct tui_cmd_window): Add
2903 do_scroll_horizontal and do_scroll_vertical.
2904 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2906 2019-06-25 Tom Tromey <tom@tromey.com>
2908 * tui/tui-data.h (struct tui_source_window_base): New struct.
2909 (struct tui_source_window): Derive from tui_source_window_base.
2910 (struct tui_disasm_window): New struct.
2911 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2912 from tui_source_window::clear_detail.
2913 (tui_source_window_base): Rename from tui_source_window.
2914 (~tui_source_window_base): Rename from ~tui_source_window.
2915 (tui_alloc_win_info): Create a tui_disasm_window.
2917 2019-06-25 Tom Tromey <tom@tromey.com>
2919 * tui/tui-data.h (struct tui_source_window)
2920 (struct tui_data_window): Declare destructors.
2921 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2923 (tui_win_info): Simplify.
2925 2019-06-25 Tom Tromey <tom@tromey.com>
2927 * tui/tui-winsource.c (tui_display_main)
2928 (tui_update_source_windows_with_addr)
2929 (tui_update_all_breakpoint_info): Update.
2930 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2931 (new_height_ok, parse_scrolling_args): Update.
2932 * tui/tui-stack.c (tui_show_frame_info): Update.
2933 * tui/tui-data.h (struct tui_list): Remove.
2934 (tui_source_windows): Return a reference to a std::vector.
2935 * tui/tui-data.c (source_windows): Now a std::vector.
2936 (tui_source_windows): Change return type.
2937 (tui_clear_source_windows): Rewrite.
2938 (tui_clear_source_windows_detail, tui_add_to_source_windows)
2939 (tui_free_all_source_wins_content): Rewrite.
2941 2019-06-25 Tom Tromey <tom@tromey.com>
2943 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2944 (struct tui_data_window, struct tui_cmd_window): Declare
2945 clear_detail method.
2946 * tui/tui-data.c (tui_source_window::clear_detail)
2947 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2949 (tui_clear_win_detail): Simplify.
2951 2019-06-25 Tom Tromey <tom@tromey.com>
2953 * tui/tui-layout.c (make_source_window, make_disasm_window)
2954 (make_source_or_disasm_window): Remove win_info_ptr parameter.
2955 Return the new window.
2956 (show_source_disasm_command, show_data)
2957 (show_source_or_disasm_and_command): Update.
2959 2019-06-25 Tom Tromey <tom@tromey.com>
2961 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2962 parameter. Return the new window.
2963 (show_source_disasm_command): Update and remove NULL check.
2964 (show_source_or_disasm_and_command): Update.
2966 2019-06-25 Tom Tromey <tom@tromey.com>
2968 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2970 2019-06-25 Tom Tromey <tom@tromey.com>
2972 * tui/tui-data.h (struct tui_win_info): Make constructor
2973 protected. Make destructor virtual. Add initializers.
2974 (tui_source_window, tui_data_window, tui_cmd_window): New
2976 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
2977 constructor. Add "type" parameter.
2978 (tui_source_window, tui_data_window, tui_cmd_window): New
2980 (tui_alloc_win_info): Instantiate the appropriate subclass.
2982 2019-06-25 Tom Tromey <tom@tromey.com>
2984 * tui/tui-win.c (tui_resize_all): Use delete.
2985 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2987 (tui_free_window): Don't declare.
2988 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2991 2019-06-25 Tom Tromey <tom@tromey.com>
2993 * tui/tui-data.h (struct tui_win_info): Add constructor.
2994 * tui/tui-data.c (tui_alloc_win_info): Use new.
2995 (tui_free_window): Use delete.
2997 2019-06-22 Tom Tromey <tom@tromey.com>
2999 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3001 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3003 2019-06-22 Tom Tromey <tom@tromey.com>
3005 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3007 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3009 2019-06-22 Tom de Vries <tdevries@suse.de>
3011 * dwarf2read.c (create_addrmap_from_aranges)
3012 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3015 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
3017 * dwarf2read.h (dwarf2_section_info_def): Remove.
3018 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3019 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3020 std::vector<dwarf2_section_info>.
3021 (struct dwo_file) <~dwo_file>: Remove.
3022 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3024 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3025 (dwarf2_read_debug_names): Likewise.
3026 (create_debug_types_hash_table): Change parameter type to
3027 array_view, adjust code accordingly.
3028 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3029 (partial_die_info::fixup): Likewise.
3030 (determine_prefix): Likewise.
3031 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3033 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3035 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3037 <~dwo_file>: Remove call to gdb_bfd_unref.
3038 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3039 gdb_bfd_ref_ptr::get.
3041 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3043 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3045 * dwarf2read.c (struct dwo_file): Initialize fields.
3047 (free_dwo_file): Remove, move content to ~dwo_file.
3048 (struct dwo_file_deleter): Remove.
3049 (dwo_file_up>: Remove custom deleter.
3050 (free_dwo_files): Remove.
3051 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3053 (process_skeletonless_type_units): Call unique_ptr::get.
3054 (allocate_dwo_file_hash_table): Add deleter to created hash
3055 table. Change return type to htab_up.
3056 (lookup_dwo_file_slot): Don't memset dwo_file, call
3058 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3059 (create_dwo_unit_in_dwp_v2): Likewise.
3060 (open_and_init_dwo_file): Likewise.
3061 (free_dwo_file_from_slot): Remove.
3063 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3065 * dwarf2read.h (struct dwarf2_section_info) <readin,
3066 is_virtual>: Change type to bool.
3067 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3070 2019-06-19 Tom Tromey <tom@tromey.com>
3072 * tui/tui-data.h (tui_init_content_element): Don't declare.
3074 2019-06-19 Tom Tromey <tom@tromey.com>
3076 * tui/tui-data.h (tui_init_win_info): Don't declare.
3078 2019-06-19 Tom de Vries <tdevries@suse.de>
3080 * dwarf2read.h (abstract_to_concrete): Change type to
3081 std::unordered_map<sect_offset, std::vector<sect_offset>,
3082 gdb::hash_enum<sect_offset>>.
3084 2019-06-19 Tom Tromey <tromey@adacore.com>
3086 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3087 EVAL_AVOID_SIDE_EFFECTS specially.
3089 2019-06-19 Tom Tromey <tromey@adacore.com>
3091 * source-cache.c (highlighter): New global.
3092 (source_cache::get_source_lines): Create a highlighter on demand.
3094 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3096 * defs.h (deprecated_interactive_hook): Delete declaration.
3097 * interps.c (clear_interpreter_hooks): Remove use of
3098 deprecated_interactive_hook.
3099 * top.c (deprecated_interactive_hook): Delete definition.
3100 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3102 2019-06-18 Tom de Vries <tdevries@suse.de>
3105 * dwarf2read.h (abstract_to_concrete): Change type from
3106 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3107 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3108 * dwarf2read.c (read_variable): Update.
3109 (dwarf2_fetch_die_loc_sect_off): Update.
3111 2019-06-17 Tom de Vries <tdevries@suse.de>
3114 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3115 accessing parent[parent_len - 1].
3117 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3120 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3121 call dtrace_process_dof with NULL dof.
3123 2019-06-16 Tom de Vries <tdevries@suse.de>
3126 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3128 2019-06-16 Tom Tromey <tom@tromey.com>
3130 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3131 (make_all_visible): Use address of member.
3133 2019-06-16 Tom Tromey <tom@tromey.com>
3135 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3136 (tui_free_window, free_content, free_content_elements): Remove
3138 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3140 * tui/tui-regs.c (tui_show_register_group)
3141 (tui_display_registers_from, tui_display_reg_element_at_line):
3142 Remove unnecessary cast.
3144 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3146 * linux-nat.c (normal_mask): Delete.
3147 (_initialize_linux_nat): Don't initialise normal_mask.
3149 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3152 * dwarf-index-write.h (write_psymtabs_to_index): Add
3153 dwz_basename parameter.
3154 * dwarf-index-write.c (write_gdbindex): Move file writing to
3155 write_gdbindex_1. Change return type void.
3156 (assert_file_size): Move up, remove filename parameter.
3157 (write_gdbindex_1): New function.
3158 (write_debug_names): Change return type to void, call
3160 (struct index_wip_file): New struct.
3161 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3162 file logic to index_wip_file. Write index for dwz file if
3164 (save_gdb_index_command): Pass basename of dwz file, if present.
3165 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3166 build-id of dwz file, if present.
3167 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3168 (dwarf2_get_dwz_file): Likewise.
3169 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3170 (dwarf2_get_dwz_file): Likewise.
3172 2019-06-16 Tom Tromey <tom@tromey.com>
3174 * coffread.c (process_coff_symbol): Use xstrdup.
3175 * value.c (create_internalvar): Use xstrdup.
3177 2019-06-16 Tom Tromey <tom@tromey.com>
3179 * valops.c (value_cast, value_slice): Remove unnecessary cast.
3180 * breakpoint.c (stopin_command, stopat_command)
3181 (until_break_command, decode_location_default): Remove unnecessary
3183 * utils.c (subset_compare): Remove unnecessary cast.
3184 * ada-lang.c (ada_update_initial_language): Remove unnecessary
3186 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3188 * infcmd.c (path_command): Remove unnecessary cast.
3189 * coffread.c (decode_type): Remove unnecessary cast.
3190 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3191 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3192 * tui/tui-stack.c (tui_show_locator_content)
3193 (tui_show_frame_info): Remove unnecessary cast.
3194 * tui/tui-win.c (tui_scroll_forward_command)
3195 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3196 (parse_scrolling_args): Remove unnecessary cast.
3197 * tui/tui-data.c (init_win_info, tui_del_window)
3198 (tui_free_window, tui_del_data_windows, tui_free_data_content)
3199 (free_content_elements): Remove unnecessary cast.
3200 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3202 * tui/tui-source.c (tui_set_source_content)
3203 (tui_vertical_source_scroll): Remove unnecessary cast.
3204 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3206 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3207 * tui/tui-regs.c (tui_display_registers_from)
3208 (tui_display_register): Remove unnecessary cast.
3209 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3210 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3211 (make_visible): Remove unnecessary cast.
3212 * tui/tui-winsource.c (tui_erase_source_content)
3213 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3215 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3216 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3217 * stabsread.c (read_type, read_array_type, read_range_type):
3218 Remove unnecessary cast.
3219 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3220 (parse_symbol, parse_type, upgrade_type, parse_external)
3221 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3223 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3225 2019-06-16 Tom Tromey <tom@tromey.com>
3227 * tui/tui-data.c (tui_alloc_generic_win_info)
3228 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3231 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
3232 Andrew Burgess <andrew.burgess@embecosm.com>
3234 * f-typeprint.c (f_print_type): Don't return early for not
3235 associated or not allocated types.
3236 (f_type_print_varspec_suffix): Add print_rank parameter and print
3237 ranks of array types in case they dangling.
3238 (f_type_print_base): Add print_rank parameter.
3240 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3242 * NEWS: Mention new MI commands.
3243 * break-catch-throw.c (enum exception_event_kind): Move to
3245 (print_mention_exception_catchpoint): Output text as a single
3247 (catch_exception_command_1): Rename to...
3248 (catch_exception_event): ...this, make non-static, update header
3249 command, and change some parameter types.
3250 (catch_catch_command): Update for changes to
3251 catch_exception_command_1.
3252 (catch_throw_command): Likewise.
3253 (catch_rethrow_command): Likewise.
3254 * breakpoint.c (enum exception_event_kind): Delete.
3255 * breakpoint.h (enum exception_event_kind): Moved here from
3256 break-catch-throw.c.
3257 (catch_exception_event): Declare.
3258 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3259 (mi_cmd_catch_throw): New function.
3260 (mi_cmd_catch_rethrow): New function.
3261 (mi_cmd_catch_catch): New function.
3262 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3263 'catch-catch' entries.
3264 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3265 (mi_cmd_catch_rethrow): Declare.
3266 (mi_cmd_catch_catch): Declare.
3268 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3270 * annotate.c (annotate_source_line): Change return type to void,
3271 update implementation to match.
3272 * annotate.h (annotate_source_line): Change return type to void,
3273 update header comment.
3274 * stack.c (print_frame_info): Don't change what frame information
3275 is printed based on whether annotations are on or not.
3277 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3279 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3280 (annotate_source): Make static.
3281 (annotate_source_line): Moved from source.c and renamed from
3282 identify_source_line. Update the return type.
3283 * annotate.h (annotate_source): Delete declaration.
3284 (annotate_source_line): Declaration moved from source.h, and
3285 renamed from identify_source_line. Return type updated.
3286 * source.c (identify_source_line): Moved to annotate.c and renamed
3287 to annotate_source_line.
3288 (info_line_command): Remove check of annotation_level.
3289 * source.h (identify_source_line): Move declaration to annotate.h
3290 and rename to annotate_source_line.
3291 * stack.c: Add 'annotate.h' include.
3292 (print_frame_info): Remove check of annotation_level before
3293 calling annotate_source_line.
3295 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3297 * source-cache.c (source_cache::get_plain_source_lines): Use
3298 open_source_file_with_line_charpos instead of just
3299 open_source_file, remove call to find_source_lines.
3300 (source_cache::get_source_lines): Likewise.
3301 * source.c (find_source_lines): Make static.
3302 (get_filename_and_charpos): Renamed into...
3303 (open_source_file_with_line_charpos): ..this along with changes to
3304 return a scoped_fd, and some other minor clean ups.
3305 (identify_source_line): Use open_source_file_with_line_charpos.
3306 (search_command_helper): Use open_source_file_with_line_charpos
3307 instead of just open_source_file, remove call to
3309 * source.h (open_source_file_with_line_charpos): Declare new
3311 (find_source_lines): Delete declaration.
3313 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3315 * source.c (get_filename_and_charpos): Remove fullname
3317 (identify_source_line): Update call to get_filename_and_charpos.
3319 2019-06-14 Tom Tromey <tromey@adacore.com>
3322 * ui-style.h (skip_ansi_escape): Update comment.
3323 * ui-file.h (class no_terminal_escape_file): New class.
3324 * ui-file.c (no_terminal_escape_file::write)
3325 (no_terminal_escape_file::puts): New methods.
3326 * cli/cli-logging.c (handle_redirections): Use
3327 no_terminal_escape_file.
3329 2019-06-14 Tom Tromey <tromey@adacore.com>
3331 * NEWS: Move convenience variable news above Python news.
3333 2019-06-14 Tom Tromey <tom@tromey.com>
3335 * gnulib: Move directory to top-level.
3336 * configure.ac: Don't configure gnulib.
3337 * configure: Rebuild.
3338 * common/common-defs.h: Use new path to gnulib.
3339 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3341 (INCGNU): Look in new gnulib location.
3342 (HFILES_NO_SRCDIR): Remove gnulib files.
3343 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3344 (generated_files): Remove GNULIB_H.
3345 ($(LIBGNU), all-lib): Remove targets.
3346 (distclean): Don't mention GNULIB_BUILDDIR.
3347 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3349 2019-06-14 Tom Tromey <tromey@adacore.com>
3351 * symfile.c (add_symbol_file_command): Remove obsolete comment.
3352 Warn if symbol file does not provide any symbols.
3354 2019-06-14 Tom Tromey <tromey@adacore.com>
3356 * source.c (find_and_open_source): Respect basenames_may_differ.
3358 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
3360 * annotate.c (annotate_breakpoints_invalid): Make use of
3361 scoped_restore_terminal_state.
3362 (annotate_frames_invalid): Likewise.
3364 2019-06-14 Tom Tromey <tromey@adacore.com>
3366 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3367 allow assignment to an internalvar.
3369 2019-06-14 Tom Tromey <tromey@adacore.com>
3371 * ada-lex.l: Allow "_" in attribute names.
3373 2019-06-14 Tom Tromey <tromey@adacore.com>
3376 * regcache.c (registers_changed): Don't call alloca.
3377 * top.c (execute_command): Don't call alloca.
3379 2019-06-13 Pedro Alves <palves@redhat.com>
3381 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3382 'expression'. When parsing an expression, error out if there's
3383 junk after "unlimited".
3384 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3385 (do_set_command): Adjust calls to is_unlimited_literal.
3387 2019-06-13 Pedro Alves <palves@redhat.com>
3389 * compile/compile.c (make_compile_options_def_group): Add braces
3390 around array_view initializer.
3391 * thread.c (make_thread_apply_all_options_def_group)
3392 (make_thread_apply_all_options_def_group): Likewise.
3394 2019-06-13 Pedro Alves <palves@redhat.com>
3396 * NEWS (New commands): Mention "maint test-options
3397 require-delimiter", "maint test-options unknown-is-error", "maint
3398 test-options unknown-is-operand" and "maint show
3399 test-options-completion-result".
3400 (New command options, command completion): New section.
3401 (Completion improvements): New section.
3402 Mention that you can abbreviate "unlimited".
3404 2019-06-13 Pedro Alves <palves@redhat.com>
3406 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3407 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3408 * unittests/cli-utils-selftests.c (test_parse_flags)
3409 (test_parse_flags_qcs): Delete.
3410 (test_cli_utils): Don't call deleted functions.
3412 2019-06-13 Pedro Alves <palves@redhat.com>
3414 * thread.c: Include "cli/cli-option.h".
3415 (tp_array_compar_ascending): Global.
3416 (tp_array_compar): Delete function.
3417 (tp_array_compar_ascending, tp_array_compar_descending): New
3419 (ascending_option_def, qcs_flag_option_def)
3420 (thr_qcs_flags_option_defs)
3421 (make_thread_apply_all_options_def_group)
3422 (make_thread_apply_options_def_group): New.
3423 (thread_apply_all_command): Use gdb::option::process_options.
3424 (thread_apply_command_completer)
3425 (thread_apply_all_command_completer): New.
3426 (thread_apply_command): Use gdb::option::process_options.
3427 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3428 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
3429 to generate help text of "thread apply". Adjust "taas"'s help.
3430 * tid-parse.c (tid_range_parser::in_thread_range): New method.
3431 * tid-parse.h (tid_range_parser::in_thread_range): New method.
3433 2019-06-13 Pedro Alves <palves@redhat.com>
3435 * thread.c (thread_apply_command): Check for invalid TID with
3436 isdigit instead of !isalpha.
3438 2019-06-13 Pedro Alves <palves@redhat.com>
3440 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3441 (validate_flags_qcs): New.
3442 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3443 (validate_flags_qcs): Declare.
3444 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3445 (make_frame_apply_options_def_group): New.
3446 (frame_apply_command_count): Process options with
3447 gdb::option::process_options.
3448 (frame_apply_completer): New.
3449 (frame_apply_level_completer, frame_apply_all_completer)
3450 (frame_apply_completer): New.
3451 (_initialize_stack): Update help of "frame apply", "frame apply
3452 level", "frame apply all" and "faas" to mention supported options
3453 and install command completers.
3454 * stack.h (frame_apply_all_completer): Declare.
3455 * thread.c: Include "stack.h".
3456 (tfaas_command): Add "--".
3457 (_initialize_thread): Update help "tfaas" to mention supported
3458 options and install command completer.
3460 2019-06-13 Pedro Alves <palves@redhat.com>
3462 * completer.c (complete_nested_command_line): New.
3463 (gdb_completion_word_break_characters_throw): Add assertion.
3464 * completer.h (complete_nested_command_line): Declare.
3466 2019-06-13 Pedro Alves <palves@redhat.com>
3468 * stack.c (parse_backtrace_qualifiers): New.
3469 (backtrace_command): Use it.
3470 (backtrace_command_completer): Complete on qualifiers.
3472 2019-06-13 Pedro Alves <palves@redhat.com>
3474 * frame.c: Include "cli/cli-option.h.
3475 (user_set_backtrace_options): New.
3476 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3478 (get_prev_frame): Adjust.
3479 (boolean_option_def, uinteger_option_def)
3480 (set_backtrace_option_defs): New.
3481 (_initialize_frame): Adjust and use
3482 gdb::option::add_setshow_cmds_for_options to install "set
3483 backtrace past-main" and "set backtrace past-entry".
3484 * frame.h: Include "cli/cli-option.h".
3485 (struct frame_print_options): Forward declare.
3486 (print_frame_arguments_all, print_frame_arguments_scalars)
3487 (print_frame_arguments_none): Declare.
3488 (print_entry_values): Delete declaration.
3489 (struct frame_print_options, user_frame_print_options): New.
3490 (struct set_backtrace_options): New.
3491 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3492 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3493 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3494 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3495 (list_args_or_locals): Add frame_print_options parameter.
3496 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3497 * python/py-framefilter.c (enumerate_args): Pass down
3498 USER_FRAME_PRINT_OPTIONS.
3499 * stack.c: Include "cli/cli-option.h".
3500 (print_frame_arguments_all, print_frame_arguments_scalars)
3501 (print_frame_arguments_none): Declare.
3502 (print_raw_frame_arguments, print_entry_values): Delete.
3503 (user_frame_print_options): New.
3504 (boolean_option_def, enum_option_def, frame_print_option_defs):
3506 (struct backtrace_cmd_options): New.
3507 (bt_flag_option_def): New.
3508 (backtrace_command_option_defs): New.
3509 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3510 (print_frame_arg, read_frame_arg, print_frame_args)
3511 (print_frame_info, print_frame): Add frame_print_options parameter
3513 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3514 (backtrace_command_1): Add frame_print_options and
3515 backtrace_cmd_options parameters and use them.
3516 (make_backtrace_options_def_group): New.
3517 (backtrace_command): Process command options with
3518 gdb::option::process_options.
3519 (backtrace_command_completer): New.
3520 (_initialize_stack): Extend "backtrace"'s help to mention
3521 supported options. Install completer for "backtrace".
3522 Install some settings commands with add_setshow_cmds_for_options.
3524 2019-06-13 Pedro Alves <palves@redhat.com>
3526 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3527 and that "set/show print raw frame-arguments" are now deprecated.
3529 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3531 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3532 * stack.c (_initialize_stack): Install "set/show print
3533 raw-frame-arguments", and deprecate "set/show print raw
3535 * valprint.c (_initialize_valprint): Deprecate "set/show print
3538 2019-06-13 Pedro Alves <palves@redhat.com>
3540 * compile/compile.c (struct compile_options): New.
3541 (compile_flag_option_def, compile_command_option_defs)
3542 (make_compile_options_def_group): New.
3543 (compile_file_command): Handle options with
3544 gdb::option::process_options.
3545 (compile_file_command_completer): New function.
3546 (compile_code_command): Handle options with
3547 gdb::option::process_options.
3548 (compile_code_command_completer): New function.
3549 (_initialize_compiler): Install completers for "compile code" and
3550 "compile file". Mention available options in "compile code" and
3551 "compile code"'s help.
3552 * completer.c (advance_to_completion_word): New, factored out from
3554 (advance_to_expression_complete_word_point): ... this.
3555 (advance_to_filename_complete_word_point): New.
3556 * completer.h (advance_to_filename_complete_word_point): New
3559 2019-06-13 Pedro Alves <palves@redhat.com>
3561 * compile/compile.c: Include "cli/cli-option.h".
3562 (compile_print_value): Scope data pointer is now a
3563 value_print_options pointer; adjust.
3564 (compile_print_command): Process options. Scope data pointer is
3565 now a value_print_options pointer; adjust.
3566 (_initialize_compile): Update "compile print"'s help to include
3567 supported options. Install a completer for "compile print".
3568 * cp-valprint.c (show_vtblprint, show_objectprint)
3569 (show_static_field_print): Delete.
3570 (_initialize_cp_valprint): Don't install "set print
3571 static-members", "set print vtbl", "set print object" here.
3572 * printcmd.c: Include "cli/cli-option.h" and
3573 "common/gdb_optional.h".
3574 (print_command_parse_format): Rework to fill in a
3575 value_print_options instead of a format_data.
3576 (print_value): Change parameter type from format_data pointer to
3577 value_print_options reference. Adjust.
3578 (print_command_1): Process options. Adjust to pass down a
3579 value_print_options.
3580 (print_command_completer): New.
3581 (_initialize_printcmd): Install print_command_completer as
3582 handle_brkchars completer for the "print" command. Update
3583 "print"'s help to include supported options.
3584 * valprint.c: Include "cli/cli-option.h".
3585 (show_vtblprint, show_objectprint, show_static_field_print): Moved
3586 here from cp-valprint.c.
3587 (boolean_option_def, uinteger_option_def)
3588 (value_print_option_defs, make_value_print_options_def_group):
3589 New. Use gdb::option::add_setshow_cmds_for_options to install
3590 "set print elements", "set print null-stop", "set print repeats",
3591 "set print pretty", "set print union", "set print array", "set
3592 print address", "set print symbol", "set print array-indexes".
3593 * valprint.h: Include <string> and "cli/cli-option.h".
3594 (make_value_print_options_def_group): Declare.
3595 (print_value): Change parameter type from format_data pointer to
3596 value_print_options reference.
3597 (print_command_completer): Declare.
3599 2019-06-13 Pedro Alves <palves@redhat.com>
3601 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3602 (COMMON_SFILES): Add maint-test-settings.c.
3603 * cli/cli-decode.c (boolean_enums): New global, factored out from
3605 (add_setshow_boolean_cmd): ... here.
3606 * cli/cli-decode.h (boolean_enums): Declare.
3607 * cli/cli-option.c: New file.
3608 * cli/cli-option.h: New file.
3609 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3610 factored out from ...
3611 (parse_cli_boolean_value(const char *)): ... this.
3612 (is_unlimited_literal): Change parameter type to pointer to
3613 pointer. Adjust and advance ARG pointer.
3614 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3615 (parse_cli_var_enum): New, factored out from ...
3616 (do_set_command): ... this. Adjust.
3617 * cli/cli-setshow.h (parse_cli_boolean_value)
3618 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3619 (parse_cli_var_enum): Declare.
3620 * cli/cli-utils.c: Include "cli/cli-option.h".
3621 (get_ulongest): New.
3622 * cli/cli-utils.h (get_ulongest): Declare.
3623 (check_for_argument): New overloads.
3624 * maint-test-options.c: New file.
3626 2019-06-13 Pedro Alves <palves@redhat.com>
3628 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3629 parse a range if "-" is at the end of the string.
3631 2019-06-13 Pedro Alves <palves@redhat.com>
3633 * cli/cli-setshow.c (parse_auto_binary_operation)
3634 (parse_cli_boolean_value): Don't allow "o".
3636 2019-06-13 Pedro Alves <palves@redhat.com>
3638 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3639 * NEWS: Mention maint test-settings KIND.
3640 * maint-test-settings.c: New file.
3642 2019-06-13 Pedro Alves <palves@redhat.com>
3644 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3646 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3649 2019-06-13 Pedro Alves <palves@redhat.com>
3651 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3654 2019-06-13 Pedro Alves <palves@redhat.com>
3656 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3658 2019-06-13 Pedro Alves <palves@redhat.com>
3660 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3661 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3663 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3664 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3666 (check_for_argument): Skip spaces after argument.
3668 2019-06-13 Pedro Alves <palves@redhat.com>
3670 * thread.c (thread_apply_command): Adjust TID parsing.
3671 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3672 detected before end of string.
3673 (tid_is_in_list): Error out if LIST is invalid.
3675 2019-06-13 Pedro Alves <palves@redhat.com>
3677 * completer.c (complete_line_internal_1): Rewind completion word
3679 (completion_tracker::advance_custom_word_point_by): Change
3680 parameter type to int.
3681 * completer.h (completion_tracker::advance_custom_word_point_by):
3684 2019-06-13 Pedro Alves <palves@redhat.com>
3686 * completer.c (advance_to_completion_word): Handle delimiters.
3688 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
3690 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3692 2019-06-11 Tom Tromey <tom@tromey.com>
3694 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3695 (xmalloc_failed): Move to alloc.c.
3696 * alloc.c: New file.
3697 * Makefile.in (COMMON_SFILES): Add alloc.c.
3699 2019-06-11 Tom Tromey <tom@tromey.com>
3701 * nat/linux-waitpid.c: Don't include server.h.
3702 (linux_debug): Remove.
3703 (my_waitpid): Update.
3705 2019-06-11 Tom Tromey <tromey@adacore.com>
3707 * infcall.c (_initialize_infcall): Remove trailing newline from
3709 * user-regs.c (_initialize_user_regs): Remove trailing newline
3711 * typeprint.c (_initialize_typeprint): Remove trailing newline
3713 * reverse.c (_initialize_reverse): Remove trailing newlines from
3715 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3717 * language.c (add_set_language_command): Remove trailing newline
3719 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3721 * disasm.c (_initialize_disasm): Remove trailing newline from
3723 * top.c (init_main): Remove trailing newline from help.
3724 * interps.c (_initialize_interpreter): Remove trailing newline
3726 * btrace.c (_initialize_btrace): Remove trailing newlines from
3728 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3730 * python/python.c (_initialize_python): Remove trailing newline
3732 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3734 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3735 from help. Reformat some text.
3736 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3738 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3741 2019-06-11 Tom Tromey <tromey@adacore.com>
3743 * darwin-nat.c (darwin_decode_exception_message)
3744 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3746 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
3748 * valops.c (value_slice): Check for not allocated or not
3751 2019-06-10 Tom de Vries <tdevries@suse.de>
3754 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3755 sure an empty slot (defined by a 32-bit zero pair) is recognized as
3758 2019-06-10 Tom de Vries <tdevries@suse.de>
3761 * linespec.c (linespec_lexer_lex_string): Remove incorrect
3762 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
3764 2019-06-10 Tom de Vries <tdevries@suse.de>
3767 * symtab.c (struct demangled_name_entry): Add language field.
3768 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
3769 static minimal symbol". Set and use language field.
3771 2019-06-10 Tom Tromey <tromey@adacore.com>
3773 * ada-lang.c (_initialize_ada_language): Update help text.
3775 2019-06-10 Tom Tromey <tromey@adacore.com>
3777 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3779 * guile/guile.c (handle_boot_error): Don't end warning with a
3781 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3782 warning with a newline.
3783 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3785 (s12z_frame_cache): Likewise.
3786 * dwarf-index-cache.c (index_cache::store): Don't end warning with
3788 * solib-svr4.c (disable_probes_interface): Don't end warning with
3790 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3792 * python/python.c (do_finish_initialization): Don't end warning
3795 2019-06-10 Tom Tromey <tom@tromey.com>
3797 * python/py-breakpoint.c (gdbpy_breakpoint_created)
3798 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3801 2019-06-10 Tom Tromey <tromey@adacore.com>
3803 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3805 (elf_new_init): Don't call stabsread_new_init.
3806 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3807 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
3808 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3810 2019-06-10 Tom de Vries <tdevries@suse.de>
3814 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3816 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
3818 * source.c (find_and_open_source): Also rewrite relative file
3821 2019-04-26 Amos Bird <amosbird@gmail.com>
3823 * annotate.c (annotate_thread_exited): Add "thread-exited"
3826 2019-06-06 Tom Tromey <tromey@adacore.com>
3828 * maint.h (class scoped_command_stats): Use
3829 DISABLE_COPY_AND_ASSIGN.
3830 <print_time>: New method.
3831 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3833 (scoped_command_stats::print_time): New method.
3835 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
3837 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3838 instructions of lengths 6 or 8 bytes.
3840 2019-06-04 Pedro Alves <palves@redhat.com>
3842 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3844 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3845 * breakpoint.c (condition_completer): Likewise.
3846 * cli/cli-dump.c (scan_expression): Likewise.
3847 * common/filestuff.c (mkdir_recursive): Likewise.
3848 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3849 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3850 (gdb_abspath): Likewise.
3851 * compile/compile-cplus-types.c
3852 (compile_cplus_instance::decl_name): Likewise.
3853 * completer.c (complete_explicit_location):
3854 (signal_completer, reg_or_group_completer_1): Likewise.
3855 * cp-support.c (cp_remove_params_if_any): Likewise.
3856 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3857 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3858 * infcmd.c (strip_bg_char): Likewise.
3859 * linespec.c (copy_token_string): Likewise.
3860 * mi/mi-main.c (output_cores): Likewise.
3861 * psymtab.c (psymtab_search_name):
3862 * symfile.c (test_set_ext_lang_command): Likewise.
3863 * target.c (target_fileio_read_stralloc): Likewise.
3864 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3865 * value.c (complete_internalvar): Likewise.
3867 2019-06-04 Christian Biesinger <cbiesinger@google.com>
3869 Add objfile property to gdb.Type.
3870 * NEWS: Mention Python API addition.
3871 * python/py-type.c (typy_get_objfile): New method.
3873 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3875 * NEWS: Mention the new set|show style [title|highlight].
3876 Mention changes to "show style", "help" and "apropos".
3878 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3880 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3881 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
3882 instead of print_help_for_command.
3883 (print_doc_of_command): New function.
3884 (help_list): Add 'apropos -v word' suggestion.
3885 (print_help_for_command): Style the command name using title style.
3886 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3887 (_initialize_cli_cmds): Describe -v in apropos_command help.
3889 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3891 * cli/cli-style.h (cli_style_option): Add name in constructor,
3892 add m_name class member, add constructor with intensity,
3893 add name class function.
3894 (cli_style_option::add_setshow_commands): Remove name argument.
3895 (highlight_style, title_style): New styles.
3896 * cli/cli-style.c (do_show): New function that shows a style
3897 characteristic styling the style name with itself.
3898 (set_style_name): New function.
3899 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3900 Update all callers according to the changes in cli/cli-style.h.
3901 * utils.h (fputs_highlighted): New function.
3902 * utils.c (fputs_highlighted): Likewise.
3904 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3906 * NEWS: Mention new pipe command and new convenience variables.
3908 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3910 * cli/cli-cmds.c (pipe_command): New function.
3911 (_initialize_cli_cmds): Call add_com for pipe_command.
3912 Define | as an alias for pipe.
3913 (exit_status_set_internal_vars): New function.
3914 (shell_escape): Call exit_status_set_internal_vars.
3915 cli/cli-decode.c (find_command_name_length): Recognize | as
3916 a single character command.
3918 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3920 * gdbcmd.h (execute_command_to_ui_file): New declaration.
3921 top.c (execute_command_to_ui_file): New function, mostly a copy
3922 of execute_command_to_string.
3923 (execute_command_to_string): Implement by calling
3924 execute_command_to_ui_file.
3926 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3928 * top.h (saved_command_line): Remove declaration.
3929 * top.c (previous_saved_command_line, previous_repeat_arguments):
3931 (saved_command_line): Make static, define together with other
3933 (dont_repeat): Clear repeat_arguments.
3934 (repeat_previous, get_saved_command_line, save_command_line):
3936 (gdb_init): Initialize saved_command_line
3937 and previous_saved_command_line.
3938 * main.c (captured_main_1): Remove saved_command_line initialization.
3939 * event-top.c (handle_line_of_input): Update to use
3940 the new 'repeat' related functions instead of direct access to
3942 * command.h (repeat_previous, get_saved_command_line,
3943 save_command_line): New declarations.
3944 (dont_repeat): Add comment.
3946 2019-05-30 Tom Tromey <tromey@adacore.com>
3948 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3950 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3952 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
3955 * completer.c (complete): Initialize variable word.
3957 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
3959 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3960 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3961 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3962 'body' is NULL to the outter 'if', protecting the '!is_define'
3965 2019-05-29 Tom Tromey <tromey@adacore.com>
3967 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3968 (dwarf_unknown): New function.
3969 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3970 (dwarf_type_encoding_name): Use dwarf_unknown.
3972 2019-05-29 Tom Tromey <tromey@adacore.com>
3975 * cp-valprint.c (cp_print_value_fields): Call
3976 cp_print_static_field inside "try".
3978 2019-05-29 Tom Tromey <tromey@adacore.com>
3980 * inflow.c (struct terminal_info): Add default operator=.
3981 * configure: Rebuild.
3982 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3983 -Wdeprecated-copy-dtor, -Wredundant-move.
3985 2019-05-29 Tom Tromey <tromey@adacore.com>
3988 * infcmd.c (print_return_value_1): Handle finish_print
3990 (show_print_finish): New function.
3991 (_initialize_infcmd): Add "set/show print finish" commands.
3992 * valprint.c (user_print_options): Initialize new member.
3993 * valprint.h (struct value_print_options) <finish_print>: New
3996 2019-05-28 Tom Tromey <tromey@adacore.com>
3998 * ada-lang.c (ada_remove_Xbn_suffix)
3999 (find_old_style_renaming_symbol)
4000 (parse_old_style_renaming): Remove.
4001 (ada_find_renaming_symbol): Don't call
4002 find_old_style_renaming_symbol.
4003 (ada_is_renaming_symbol): Rename from
4004 ada_find_renaming_symbol. Remove "block" parameter. Return
4006 (ada_read_var_value): Update and simplify.
4007 * ada-exp.y (write_var_or_type): Remove old code.
4009 2019-05-28 Alan Hayward <alan.hayward@arm.com>
4011 * event-top.c: Remove include comment.
4012 * inflow.c (class scoped_ignore_sigttou): Move from here...
4013 * inflow.h (class scoped_ignore_sigttou): ...to here.
4014 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4015 * top.c: Remove include comment.
4017 2019-05-27 Tom Tromey <tom@tromey.com>
4021 2019-05-22 Tom Tromey <tromey@adacore.com>
4023 * target.c (target_follow_exec): Constify parameter.
4024 * target-delegates.c: Rebuild.
4025 * remote.c (remote_target::follow_exec): Constify parameter.
4026 * infrun.c (follow_exec): Constify parameter.
4027 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4028 (target_follow_exec): Likewise.
4030 2019-05-22 Alan Hayward <alan.hayward@arm.com>
4032 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4033 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4035 2019-05-22 Alan Hayward <alan.hayward@arm.com>
4037 * NEWS: Add debugredirect and testsuite sections.
4039 2019-05-22 Simon Cook <simon.cook@embecosm.com>
4041 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4042 target descriptions using exclusively floating point register name
4045 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4048 * f-lang.c (build_fortran_types): Handle the case where
4049 gdbarch_floatformat_for_type returns a nullptr.
4051 2019-05-21 Tom de Vries <tdevries@suse.de>
4054 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4056 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4059 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4061 * i386-tdep.c (i386_floatformat_for_type): Use
4062 floatformats_ia64_quad for the 16-byte floating point component
4063 within a fortran 32-byte complex number.
4065 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4067 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4068 delete default constructor.
4069 (find_partial_die): Update to return const struct.
4070 (partial_die_parent_scope): Move variable declaration into scope
4071 of its use and change its type to auto.
4072 (guess_partial_die_structure_name): Likewise.
4073 (partial_die_info::fixup): Likewise.
4075 2019-05-17 Tom Tromey <tromey@adacore.com>
4077 * source.c (find_and_open_source): Remove cast.
4079 2019-05-17 Tom Tromey <tromey@adacore.com>
4081 * annotate.c (annotate_source): Make "filename" const.
4082 * annotate.h (annotate_source): Use const.
4084 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4086 * disasm.c (set_disassembler_options): Send errors to stderr.
4088 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4090 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4091 (cli_interp_base::set_logging): Check debug_redirect.
4092 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4093 * cli/cli-logging.c (debug_redirect): Add static variable.
4094 (pop_output_files): Add default param.
4095 (handle_redirections): Print debug setting.
4096 (show_logging_command): Likewise.
4097 (_initialize_cli_logging): Add debugredirect command.
4098 * interps.c (current_interp_set_logging): Add debug_redirect
4100 * interps.h (set_logging): Add debug_redirect parameter.
4101 (current_interp_set_logging): Likewise.
4102 * mi/mi-common.h: Likewise.
4103 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4105 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4106 Tom Tromey <tromey@adacore.com>
4108 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4110 * cli/cli-interp.h (make_logging_output): Remove declaration.
4111 * cli/cli-logging.c (make_logging_output): Remove function.
4112 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4114 * ui-file.c (tee_file::tee_file): Remove bools.
4115 (tee_file::~tee_file): Remove deletes.
4116 * ui-file.h (tee_file): Remove bools.
4118 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4120 * mi/mi-cmds.h (mi_cmd_complete): New function.
4121 * mi/mi-main.c (mi_cmd_complete): Likewise.
4122 * mi/mi-cmds.c: Define new MI command -complete.
4123 * NEWS: Mention new -complete command.
4125 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4127 * completer.h (complete): New function.
4128 * completer.c (complete): Likewise.
4129 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4130 function defined in completer.h.
4132 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4134 * MAINTAINERS (Write After Approval): Add myself.
4136 2019-05-17 Tom de Vries <tdevries@suse.de>
4139 * dwarf2read.c (struct cu_partial_die_info): New struct.
4140 (find_partial_die): Return cu_partial_die_info.
4141 (partial_die_parent_scope, guess_partial_die_structure_name)
4142 (partial_die_info::fixup): Handle new return type of find_partial_die.
4144 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4146 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4147 "std::string", simplifying the algorithm.
4149 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4151 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4152 (stap_static_probe_ops::get_probes): Likewise.
4154 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4156 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4157 '-')" and "else if".
4158 (stap_parse_single_operand): Join checks for
4159 "gdbarch_stap_parse_special_token_p" and
4160 "gdbarch_stap_parse_special_token" in the same "if" statement.
4161 Invert check when verifying for operation on register
4164 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4166 * stap-probe.c (stap_get_opcode): Update comment.
4167 (stap_get_expected_argument_type): Likewise.
4168 (handle_stap_probe): Likewise.
4170 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4172 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4173 return type to 'bool'. Adjust comment. Use 'bool' when
4175 (i386_stap_parse_special_token_three_arg_disp): Likewise.
4176 * stap-probe.c (stap_parse_argument_1): Likewise.
4177 (stap_is_operator): Likewise.
4178 (stap_is_generic_prefix): Likewise.
4179 (stap_is_register_prefix): Likewise.
4180 (stap_is_register_indirection_prefix): Likewise.
4181 (stap_is_integer_prefix): Likewise.
4182 (stap_generic_check_suffix): Likewise.
4183 (stap_check_integer_suffix): Likewise.
4184 (stap_check_register_suffix): Likewise.
4185 (stap_check_register_indirection_suffix): Likewise.
4186 (stap_parse_register_operand): Likewise.
4187 (stap_parse_single_operand): Likewise.
4188 (stap_parse_argument_1): Likewise.
4189 (stap_probe::get_argument_count): Likewise.
4190 (stap_is_operator): Likewise.
4192 2019-05-16 Tom Tromey <tromey@adacore.com>
4194 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4197 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
4199 * linux-thread-db.c (try_thread_db_load_1): Change return type
4201 (try_thread_db_load): Likewise.
4202 (try_thread_db_load_from_pdir_1): Likewise.
4203 (try_thread_db_load_from_pdir): Likewise.
4204 (try_thread_db_load_from_sdir): Likewise.
4205 (try_thread_db_load_from_dir): Likewise.
4206 (thread_db_load_search): Likewise.
4207 (has_libpthread): Likewise.
4208 (thread_db_load): Likewise.
4210 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
4212 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4213 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4214 NULL, and complain/return if that's the case.
4216 2019-05-15 John Darrington <john@darrington.wattle.id.au>
4218 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4219 (advance, posn, abstract_read_memory): New functions.
4220 [struct mem_read_abstraction]: New struct.
4221 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4223 2019-05-14 Tom Tromey <tromey@adacore.com>
4225 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4226 value is not lval_memory.
4228 2019-05-14 Tom Tromey <tromey@adacore.com>
4230 * solib.c (info_sharedlibrary_command): Style the file name.
4232 2019-05-14 Alan Hayward <alan.hayward@arm.com>
4234 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4235 (aarch64_vnv_type): Likewise.
4236 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4237 * common/tdesc.c: Likewise.
4238 * common/tdesc.h (enum tdesc_type_kind): Likewise.
4239 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4240 * features/aarch64-fpu.xml: Add ieee half view.
4241 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4242 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4243 * gdbtypes.h (struct builtin_type): Likewise.
4244 (struct objfile_type): Likewise.
4246 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
4248 * language.c (language_sniff_from_mangled_name): Fix "langauge"
4250 * location.h (string_to_event_location): Likewise.
4252 2019-05-11 Joel Brobecker <brobecker@adacore.com>
4256 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
4258 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4259 New variable declaration.
4260 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4262 (print_one_breakpoint): Use ui_out::test_flags and new global
4263 variable to compute use_fixed_output.
4264 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4266 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4267 (mi_multi_location_breakpoint_output_fixed): Remove.
4268 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4270 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4271 fix_multi_location_breakpoint_output flag if version >= 3.
4272 * ui-out.h (enum ui_out_flag)
4273 <fix_multi_location_breakpoint_output>: New enumerator.
4275 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
4277 * contrib/cc-with-tweaks.sh: Validate dwz's work.
4279 2019-05-10 Tom Tromey <tromey@adacore.com>
4281 * ada-lang.c (catch_ada_completer): New function.
4282 (_initialize_ada_language): Use it.
4284 2019-05-10 Tom Tromey <tromey@adacore.com>
4286 * thread.c (print_thread_info): Make "requested_threads" const.
4287 * gdbthread.h (print_thread_info): Make "requested_threads"
4289 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4290 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4292 2019-05-08 Tom Tromey <tom@tromey.com>
4294 * gdbtypes.c (objfile_type_data): Change type.
4295 (objfile_type, _initialize_gdbtypes): Update.
4297 2019-05-08 Tom Tromey <tom@tromey.com>
4299 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4300 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4301 (_initialize_dwarf2_frame): Update.
4303 2019-05-08 Tom Tromey <tom@tromey.com>
4305 * objc-lang.c (objc_objfile_data): Change type.
4306 (find_methods): Update.
4307 (_initialize_objc_lang): Remove.
4309 2019-05-08 Tom Tromey <tom@tromey.com>
4311 * stabsread.c (rs6000_builtin_type_data): Change type.
4312 (rs6000_builtin_type, _initialize_stabsread): Update.
4314 2019-05-08 Tom Tromey <tom@tromey.com>
4316 * mips-tdep.c (mips_pdr_data): Remove.
4317 (_initialize_mips_tdep): Update.
4319 2019-05-08 Tom Tromey <tom@tromey.com>
4321 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4322 (hppa_init_objfile_priv_data, read_unwind_info)
4323 (find_unwind_entry, _initialize_hppa_tdep): Update.
4325 2019-05-08 Tom Tromey <tom@tromey.com>
4327 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4328 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
4330 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4332 2019-05-08 Tom Tromey <tom@tromey.com>
4334 * mdebugread.c (basic_type_data): Change type.
4335 (basic_type, _initialize_mdebugread): Update.
4337 2019-05-08 Tom Tromey <tom@tromey.com>
4339 * common/gdb_unique_ptr.h (struct noop_deleter): New.
4341 2019-05-08 Tom Tromey <tom@tromey.com>
4343 * nto-tdep.c (nto_inferior_data_reg): Change type.
4344 (nto_inferior_data): Update.
4345 (nto_inferior_data_cleanup, nto_new_inferior_data)
4346 (_initialize_nto_tdep): Remove.
4347 * nto-tdep.h (struct nto_inferior_data): Add initializers.
4349 2019-05-08 Tom Tromey <tom@tromey.com>
4351 * ada-lang.c (struct ada_inferior_data): Add initializers.
4352 (ada_inferior_data): Change type.
4353 (ada_inferior_data_cleanup): Remove.
4354 (get_ada_inferior_data, ada_inferior_exit)
4355 (struct ada_pspace_data): Add initializers, destructor.
4356 (ada_pspace_data_handle): Change type.
4357 (get_ada_pspace_data): Update.
4358 (ada_pspace_data_cleanup): Remove.
4360 2019-05-08 Tom Tromey <tom@tromey.com>
4362 * coffread.c (struct coff_symfile_info): Add initializers.
4363 (coff_objfile_data_key): Move lower. Change type.
4364 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4366 (coff_free_info): Remove.
4368 2019-05-08 Tom Tromey <tom@tromey.com>
4370 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4371 (fbsd_pspace_data_handle): Move lower. Change type.
4372 (get_fbsd_pspace_data): Update.
4373 (fbsd_pspace_data_cleanup): Remove.
4374 (_initialize_fbsd_tdep): Update.
4376 2019-05-08 Tom Tromey <tom@tromey.com>
4378 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4379 (get_ada_tasks_pspace_data): Update.
4380 (ada_tasks_pspace_data_cleanup): Remove.
4381 (_initialize_tasks): Update.
4382 (ada_tasks_inferior_data_handle): Change type.
4383 (get_ada_tasks_inferior_data): Update.
4384 (ada_tasks_inferior_data_cleanup): Remove.
4385 (struct ada_tasks_pspace_data): Add initializers.
4387 2019-05-08 Tom Tromey <tom@tromey.com>
4389 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4390 * symfile-debug.c (debug_sym_get_probes): Change type.
4391 * stap-probe.c (handle_stap_probe):
4392 (stap_static_probe_ops::get_probes): Change type.
4393 * probe.h (class static_probe_ops) <get_probes>: Change type.
4394 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4395 (parse_probes_in_pspace): Update.
4396 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4398 (any_static_probe_ops::get_probes): Change type.
4399 * elfread.c (elfread_data): New typedef.
4400 (probe_key): Change type.
4401 (elf_get_probes): Likewise. Update.
4402 (probe_key_free): Remove.
4403 (_initialize_elfread): Update.
4404 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4406 (dtrace_process_dof_probe, dtrace_process_dof)
4407 (dtrace_static_probe_ops::get_probe): Change type.
4409 2019-05-08 Tom Tromey <tom@tromey.com>
4411 * xcoffread.c (struct xcoff_symfile_info): Rename from
4412 coff_symfile_info. Add initializers.
4413 (xcoff_objfile_data_key): Move lower. Change type.
4414 (XCOFF_DATA): Rewrite.
4415 (xcoff_free_info): Remove.
4416 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4417 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4418 (xcoff_initial_scan): Update.
4420 2019-05-08 Tom Tromey <tom@tromey.com>
4422 * solib-svr4.c (struct svr4_info): Add initializers and
4424 <probes_table>: Now an htab_up.
4425 (solib_svr4_pspace_data): Change type.
4426 (free_probes_table): Simplify.
4427 (~svr4_info): Rename from svr4_pspace_data_cleanup.
4428 (get_svr4_info, probes_table_htab_remove_objfile_probes)
4429 (probes_table_remove_objfile_probes, register_solib_event_probe)
4430 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4431 (_initialize_svr4_solib): Update.
4433 2019-05-08 Tom Tromey <tom@tromey.com>
4435 * remote.c (remote_pspace_data): Change type.
4436 (remote_pspace_data_cleanup): Remove.
4437 (get_remote_exec_file, set_pspace_remote_exec_file)
4438 (_initialize_remote): Update.
4440 2019-05-08 Tom Tromey <tom@tromey.com>
4442 * breakpoint.c (breakpoint_objfile_key): Change type.
4443 (get_breakpoint_objfile_data): Update.
4444 (free_breakpoint_objfile_data): Remove.
4445 (_initialize_breakpoint): Update.
4447 2019-05-08 Tom Tromey <tom@tromey.com>
4449 * linux-tdep.c (struct linux_info): Add initializers.
4450 (linux_inferior_data): Move. Change type.
4451 (invalidate_linux_cache_inf): Update.
4452 (linux_inferior_data_cleanup): Remove.
4453 (get_linux_inferior_data, _initialize_linux_tdep): Update.
4455 2019-05-08 Tom Tromey <tom@tromey.com>
4457 * auxv.c (auxv_inferior_data): Move. Change type.
4458 (auxv_inferior_data_cleanup): Remove.
4459 (invalidate_auxv_cache_inf): Rewrite.
4460 (get_auxv_inferior_data, _initialize_auxv): Update.
4462 2019-05-08 Tom Tromey <tom@tromey.com>
4464 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4465 (symfile_debug_objfile_data_key): Change type.
4466 (symfile_debug_installed, debug_qf_has_symbols)
4467 (debug_qf_find_last_source_symtab)
4468 (debug_qf_forget_cached_source_info)
4469 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4470 (debug_qf_print_stats, debug_qf_dump)
4471 (debug_qf_expand_symtabs_for_function)
4472 (debug_qf_expand_all_symtabs)
4473 (debug_qf_expand_symtabs_with_fullname)
4474 (debug_qf_map_matching_symbols)
4475 (debug_qf_expand_symtabs_matching)
4476 (debug_qf_find_pc_sect_compunit_symtab)
4477 (debug_qf_map_symbol_filenames)
4478 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4479 (debug_sym_new_init, debug_sym_init, debug_sym_read)
4480 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4481 (debug_sym_read_linetable, debug_sym_relocate): Update.
4482 (symfile_debug_free_objfile): Remove.
4483 (install_symfile_debug_logging, _initialize_symfile_debug):
4486 2019-05-08 Tom Tromey <tom@tromey.com>
4488 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4489 allocate_on_obstack.
4490 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4491 (get_dwarf2_per_objfile): Update.
4492 (set_dwarf2_per_objfile): Remove.
4493 (dwarf2_has_info, dwarf2_get_section_info): Update.
4494 (dwarf2_free_objfile): Remove.
4495 (_initialize_dwarf2_read): Update.
4497 2019-05-08 Tom Tromey <tom@tromey.com>
4499 * auto-load.c (struct auto_load_pspace_info): Add destructor and
4501 <unsupported_script_warning_printed,
4502 script_not_found_warning_printed>: Now bool.
4503 (auto_load_pspace_data): Change type.
4504 (~auto_load_pspace_info): Rename from
4505 auto_load_pspace_data_cleanup.
4506 (get_auto_load_pspace_data, init_loaded_scripts_info)
4507 (clear_section_scripts, maybe_print_unsupported_script_warning)
4508 (maybe_print_script_not_found_warning, _initialize_auto_load):
4511 2019-05-08 Tom Tromey <tom@tromey.com>
4513 * objfiles.c (objfile_pspace_info): Add destructor and
4515 (objfiles_pspace_data): Change type.
4516 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4517 (get_objfile_pspace_data): Update.
4518 (objfiles_bfd_data): Change type.
4519 (get_objfile_bfd_data): Update.
4520 (objfile_bfd_data_free, _initialize_objfiles): Remove.
4522 2019-05-08 Tom Tromey <tom@tromey.com>
4524 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4526 (get_catch_syscall_inferior_data): Update.
4527 (catch_syscall_inferior_data_cleanup): Remove.
4528 (_initialize_break_catch_syscall): Update.
4530 2019-05-08 Tom Tromey <tom@tromey.com>
4532 * inflow.c (struct terminal_info): Add destructor and
4534 (inflow_inferior_data): Change type.
4535 (~terminal_info): Rename from inflow_inferior_data_cleanup.
4536 (get_inflow_inferior_data, inflow_inferior_exit)
4537 (swap_terminal_info, _initialize_inflow): Update.
4539 2019-05-08 Tom Tromey <tom@tromey.com>
4541 * target-dcache.c (target_dcache_cleanup): Remove.
4542 (target_dcache_aspace_key): Change type.
4543 (target_dcache_init_p, target_dcache_invalidate)
4544 (target_dcache_get, target_dcache_get_or_init)
4545 (_initialize_target_dcache): Update.
4546 * dcache.h (struct dcache_deleter): New.
4548 2019-05-08 Tom Tromey <tom@tromey.com>
4550 * symtab.c (struct symbol_cache): Add destructor and
4552 (symbol_cache_key): Move. Change type.
4553 (make_symbol_cache, free_symbol_cache): Remove.
4554 (get_symbol_cache): Update.
4555 (symbol_cache_cleanup): Remove.
4556 (ALL_PSPACES, symbol_cache_flush)
4557 (maintenance_print_symbol_cache)
4558 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4561 2019-05-08 Tom Tromey <tom@tromey.com>
4563 * symtab.c (struct main_info): Add destructor and initializers.
4564 (main_progspace_key): Move. Change type.
4565 (get_main_info): Update.
4566 (main_info_cleanup): Remove.
4567 (_initialize_symtab): Update.
4569 2019-05-08 Tom Tromey <tom@tromey.com>
4571 * registry.h (DECLARE_REGISTRY): Define the _key class.
4573 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
4575 * NEWS: Merge two 'New commands' sections.
4577 2019-05-08 Joel Brobecker <brobecker@adacore.com>
4579 * ada-valprint.c (ada_val_print_gnat_array): Remove language
4580 parameter and use Ada language definition instead.
4581 (ada_val_print_ptr): Remove unused language parameter.
4582 (ada_val_print_num): Remove language parameter and use Ada language
4584 (ada_val_print_enum, ada_val_print_flt): Remove unused language
4586 (ada_val_print_struct_union, ada_val_print_ref): Remove language
4587 parameter and use Ada language definition instead.
4588 (ada_val_print_1): Update all ada_val_print_xxx calls.
4589 Remove language parameter.
4590 (ada_val_print): Update ada_val_print_1 call.
4592 2019-05-08 Tom Tromey <tromey@adacore.com>
4594 * remote.c (remote_hw_watchpoint_limit)
4595 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4598 2019-05-08 Tom Tromey <tromey@adacore.com>
4600 * maint.c (_initialize_maint_cmds): Move initialization code to
4602 (watchdog, show_watchdog): Move to remote.c.
4603 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
4605 (_initialize_remote): Move initialization code from maint.c.
4606 * defs.h (watchdog): Don't declare.
4608 2019-05-08 Tom Tromey <tromey@adacore.com>
4610 * tui/tui-interp.c: Include main.h.
4611 * interps.c: Include main.h.
4612 * main.h (interpreter_p): Declare.
4613 * defs.h (interpreter_p): Don't declare.
4615 2019-05-08 Tom Tromey <tromey@adacore.com>
4617 * dwarf2loc.c: Include dwarf2read.h.
4618 * defs.h (read_unsigned_leb128): Don't declare.
4619 * dwarf2read.h (read_unsigned_leb128): Declare.
4621 2019-05-08 Tom Tromey <tromey@adacore.com>
4623 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4626 2019-05-08 Tom Tromey <tromey@adacore.com>
4628 * utils.c (fputs_maybe_filtered): Reset style after paging, even
4629 when no wrap column is set.
4631 2019-05-08 Tom Tromey <tromey@adacore.com>
4633 * c-lang.c (c_get_string): Handle non-C-style arrays.
4635 2019-05-08 Tom Tromey <tromey@adacore.com>
4637 * typeprint.c (print_offset_data::update): Print the bit offset,
4638 not the number of bits remaining.
4640 2019-05-08 Tom Tromey <tromey@adacore.com>
4642 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4643 padding at end of comment.
4645 2019-05-08 Tom Tromey <tromey@adacore.com>
4647 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4650 2019-05-06 Tom Tromey <tom@tromey.com>
4652 * common/scoped_mmap.c: Include common-defs.h.
4653 * common/scoped_mmap.h: Don't include config.h.
4655 2019-05-04 Tom Tromey <tom@tromey.com>
4657 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4658 (struct aarch64_call_info): Add initializers.
4659 <si>: Now a std::vector.
4660 (pass_on_stack, aarch64_push_dummy_call): Update.
4662 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
4663 Tom Tromey <tom@tromey.com>
4665 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4666 (ppc_threads): Now a std::vector. Now static.
4667 (hwdebug_find_thread_points_by_tid)
4668 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4671 2019-05-04 Tom Tromey <tom@tromey.com>
4673 * arc-tdep.c (arc_tdesc_init): Return bool.
4675 2019-05-04 Tom Tromey <tom@tromey.com>
4677 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4678 Use gdb_assert_not_reached.
4680 2019-05-04 Tom Tromey <tom@tromey.com>
4682 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4685 2019-05-04 Tom Tromey <tom@tromey.com>
4687 * arc-tdep.c (arc_tdesc_init): Use bool.
4689 2019-05-04 Tom Tromey <tom@tromey.com>
4691 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4693 2019-05-04 Tom Tromey <tom@tromey.com>
4695 * cli/cli-cmds.c (valid_command_p): Return bool.
4697 2019-05-04 Tom Tromey <tom@tromey.com>
4699 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4700 * command.h (valid_user_defined_cmd_name_p): Channge return type.
4702 2019-05-04 Raul Tambre <raul@tambre.ee>
4704 * python/lib/gdb/prompt.py (_ExtendedPrompt)
4705 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4706 operator for comparison.
4708 2019-05-04 Tom Tromey <tom@tromey.com>
4710 * psymtab.c (psymbol_name_matches, match_partial_symbol)
4711 (lookup_partial_symbol, print_partial_symbols)
4712 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4713 (psymbol_compare): Update.
4714 (add_psymbol_to_bcache): Clear the entire psymbol.
4715 (maintenance_check_psymtabs): Update.
4716 * psympriv.h (struct partial_symbol): Don't derive from
4717 general_symbol_info.
4718 <obj_section, unrelocated_address, address,
4719 set_unrelocated_address>: Update.
4720 <ginfo>: New member.
4721 * dwarf-index-write.c (write_psymbols, debug_names::insert)
4722 (debug_names::write_psymbols): Update.
4724 2019-05-04 Tom de Vries <tdevries@suse.de>
4726 * contrib/cc-with-tweaks.sh: Support -n arg.
4728 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4730 * corelow.c (core_target::detach): Ensure frame cache and
4731 register caches are cleared.
4732 inferior.c (exit_inferior_1): Likewise.
4734 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
4735 Tom Tromey <tom@tromey.com>
4737 * dictionary.c (collate_pending_symbols_by_language): Remove
4738 "struct" from foreach.
4739 * symtab.c (lookup_global_symbol_from_objfile)
4740 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4742 * ser-tcp.c (net_open): Remove "struct" from foreach.
4743 * objfiles.c (objfile_relocate, objfile_rebase)
4744 (objfile_has_symbols): Remove "struct" from foreach.
4745 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4747 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4749 * darwin-nat.c (thread_info_from_private_thread_info): Remove
4750 "struct" from foreach.
4751 * ada-lang.c (create_excep_cond_exprs)
4752 (ada_exception_catchpoint_cond_string): Remove "struct" from
4755 2019-05-03 Tom Tromey <tromey@adacore.com>
4757 * ada-exp.y (convert_char_literal): Check suffix of each
4760 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
4763 * ada-exp.y (yywrap): Don't define.
4764 * ada-lex.l (%option): Add noyywrap
4767 2019-05-03 Eli Zaretskii <eliz@gnu.org>
4769 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4770 _WIN32_WINNT to the XP level, unless already defined to a higher
4773 * unittests/parse-connection-spec-selftests.c:
4775 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
4778 * symfile.c (find_separate_debug_file): Remove colon from the
4779 drive spec of DOS/Windows file names of the target, so that the
4780 file name produced from DEBUGDIR and the target's directory will
4781 be valid on DOS/Windows systems.
4783 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
4785 * rust-lang.c (val_print_struct): Handle printing structures
4788 2019-05-02 Tom Tromey <tromey@adacore.com>
4790 * valarith.c (_initialize_valarith): Remove.
4792 2019-05-01 Tom Tromey <tromey@adacore.com>
4794 * ada-lang.c (ada_value_primitive_field): Treat more fields as
4797 2019-05-01 Tom Tromey <tromey@adacore.com>
4799 * ada-lang.c (ada_value_assign): Correctly compute starting offset
4800 for big-endian copies.
4802 2019-04-30 Ali Tamur <tamur@google.com>
4803 * gdb/dwarf2read.c (read_3_bytes): New declaration.
4804 (read_attribute_value): Added DW_FORM_strx1-4 cases.
4805 (read_3_bytes): New function.
4807 2019-04-30 Joel Brobecker <brobecker@adacore.com>
4809 * windows-nat.c (main_thread_id): Delete.
4810 (handle_output_debug_string): Replace main_thread_id by
4811 current_event.dwThreadId.
4812 (fake_create_process): Likewise.
4813 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4814 Do not set main_thread_id.
4815 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4816 current_event.dwThreadId.
4817 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4819 2019-04-30 Joel Brobecker <brobecker@adacore.com>
4821 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4822 Use current_event.dwThreadId instead of main_thread_id.
4824 2019-04-30 Tom Tromey <tromey@adacore.com>
4826 * ada-lang.c (ada_lookup_simple_minsyms): New function.
4827 (create_excep_cond_exprs): Iterate over program spaces.
4828 (ada_exception_catchpoint_cond_string): Examine all minimal
4829 symbols for exception types.
4831 2019-04-30 Tom Tromey <tromey@adacore.com>
4834 * dwarf2read.c (process_structure_scope): Handle case where type
4835 has template parameters but no symbol was created.
4837 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4838 Chris January <chris.january@arm.com>
4840 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4842 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4844 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4846 * f-typeprint.c (f_print_type): Update rules for printing
4848 (f_type_print_varspec_suffix): Likewise.
4850 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4851 Chris January <chris.january@arm.com>
4853 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4856 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4858 * f-lang.c (build_fortran_types): Change name of void type to
4860 * f-typeprint.c (f_type_print_base): Print the name of the void
4861 type, rather than a fixed string.
4862 * f-valprint.c (f_decorations): Use lower case void string.
4864 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4865 Chris January <chris.january@arm.com>
4867 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4870 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4871 Chris January <chris.january@arm.com>
4872 David Lecomber <david.lecomber@arm.com>
4874 * f-exp.y (BINOP_INTRINSIC): New token.
4875 (exp): New parser rule handling BINOP_INTRINSIC.
4876 (f77_keywords): Add new builtin procedures.
4877 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4878 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4879 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4880 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4881 (print_unop_subexp_f): New function.
4882 (print_binop_subexp_f): New function.
4883 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4884 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4885 (dump_subexp_body_f): Likewise.
4886 (operator_check_f): Likewise.
4887 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4888 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4890 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4892 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4894 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4895 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4896 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4897 (operator_length_f): New fuction.
4898 (print_subexp_f): New function.
4899 (op_name_f): New function.
4900 (dump_subexp_body_f): New function.
4901 (operator_check_f): New function.
4902 (exp_descriptor_f): Replace standard expression handling functions
4904 * gdb/fortran-operator.def: New file.
4905 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4906 * gdb/std-operator.def: Remove UNOP_KIND.
4908 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4910 * std-operator.def: Remove unbalanced, stray double quote
4913 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4914 Chris January <chris.january@arm.com>
4915 Daniel Everett <daniel.everett@arm.com>
4916 Nick Forrington <nick.forrington@arm.com>
4917 Richard Bunt <richard.bunt@arm.com>
4919 * cp-valprint.c (cp_print_value_fields): Allow an additional level
4920 of depth when printing anonymous structs or unions.
4921 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4922 Don't print either the top-level value, or the children if the
4923 max-depth is exceeded.
4924 (ppscm_print_children): When printing the key of a map, allow one
4925 extra level of depth.
4926 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4927 print either the top-level value, or the children if the max-depth
4929 (print_children): When printing the key of a map, allow one extra
4931 * python/py-value.c (valpy_format_string): Add max_depth keyword.
4932 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4933 (user_print_options): Initialise max_depth field.
4934 (val_print_scalar_or_string_type_p): New function.
4935 (val_print): Check to see if the max depth has been reached.
4936 (val_print_check_max_depth): Define new function.
4937 (show_print_max_depth): New function.
4938 (_initialize_valprint): Add 'print max-depth' option.
4939 * valprint.h (struct value_print_options) <max_depth>: New field.
4940 (val_print_check_max_depth): Declare new function.
4941 * NEWS: Document new feature.
4943 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4945 * ada-lang.c (ada_language_defn): Initialise new field.
4946 * c-lang.c (c_is_string_type_p): New function.
4947 (c_language_defn): Initialise new field.
4948 (cplus_language_defn): Initialise new field.
4949 (asm_language_defn): Initialise new field.
4950 (minimal_language_defn): Initialise new field.
4951 * c-lang.h (c_is_string_type_p): Declare new function.
4952 * d-lang.c (d_language_defn): Initialise new field.
4953 * f-lang.c (f_is_string_type_p): New function.
4954 (f_language_defn): Initialise new field.
4955 * go-lang.c (go_is_string_type_p): New function.
4956 (go_language_defn): Initialise new field.
4957 * language.c (default_is_string_type_p): New function.
4958 (unknown_language_defn): Initialise new field.
4959 (auto_language_defn): Initialise new field.
4960 * language.h (struct language_defn) <la_is_string_type_p>: New
4962 (default_is_string_type_p): Declare new function.
4963 * m2-lang.c (m2_language_defn): Initialise new field.
4964 * objc-lang.c (objc_language_defn): Initialise new field.
4965 * opencl-lang.c (opencl_language_defn): Initialise new field.
4966 * p-lang.c (pascal_is_string_type_p): New function.
4967 (pascal_language_defn): Initialise new field.
4968 * rust-lang.c (rust_is_string_type_p): New function.
4969 (rust_language_defn): Initialise new field.
4971 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4973 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4975 * ada-lang.c (ada_language_defn): Initialise new field.
4976 * c-lang.c (c_language_defn): Likewise.
4977 (cplus_language_defn): Likewise.
4978 (asm_language_defn): Likewise.
4979 (minimal_language_defn): Likewise.
4980 * d-lang.c (d_language_defn): Likewise.
4981 * f-lang.c (f_language_defn): Likewise.
4982 * go-lang.c (go_language_defn): Likewise.
4983 * language.c (unknown_language_defn): Likewise.
4984 (auto_language_defn): Likewise.
4985 * m2-lang.c (m2_language_defn): Likewise.
4986 * objc-lang.c (objc_language_defn): Likewise.
4987 * opencl-lang.c (opencl_language_defn): Likewise.
4988 * p-lang.c (pascal_language_defn): Likewise.
4989 * rust-lang.c (rust_language_defn): Likewise.
4991 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4993 * ada-lang.c (ada_is_character_type): Change return type to bool.
4994 (ada_is_string_type): Likewise.
4995 * ada-lang.h (ada_is_character_type): Update declaration
4996 (ada_is_string_type): Likewise.
4998 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5000 Support style in 'frame|thread apply'
5002 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5003 * record.c (record_start, record_stop): Update callers of
5004 execute_command_to_string with false.
5005 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5006 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5008 (class string_file): New constructor with term_out parameter.
5009 Override methods term_out and can_emit_style_escape. New member
5011 (class stdio_file): Override can_emit_style_escape.
5012 (class tee_file): Override term_out and can_emit_style_escape.
5013 * utils.h (can_emit_style_escape): Remove.
5014 * utils.c (can_emit_style_escape): Likewise.
5015 Update all callers of can_emit_style_escape (SOMESTREAM) to
5016 SOMESTREAM->can_emit_style_escape.
5017 * source-cache.c (source_cache::get_source_lines): Likewise.
5018 * stack.c (frame_apply_command_count): Call execute_command_to_string
5019 passing the term_out characteristic of the current gdb_stdout.
5020 * thread.c (thr_try_catch_cmd): Likewise.
5021 * top.c (execute_command_to_string): pass term_out parameter
5022 to construct the string_file for the command output.
5023 * ui-file.c (term_cli_styling): New function (most code moved
5024 from utils.c can_emit_style_escape).
5025 (string_file::string_file, string_file::can_emit_style_escape,
5026 stdio_file::can_emit_style_escape, tee_file::term_out,
5027 tee_file::can_emit_style_escape): New functions.
5029 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5031 * NEWS: Mention the new set|show may-call-functions.
5032 * infcall.c (may_call_functions_p): New variable.
5033 (show_may_call_functions_p): New function.
5034 (call_function_by_hand_dummy): Throws an error if not
5036 (_initialize_infcall): Call add_setshow_boolean_cmd for
5039 2019-04-25 Keith Seitz <keiths@redhat.com>
5042 * cp-support.c (inspect_type): Don't attempt substitutions
5043 of symbol with the same name.
5045 2019-04-25 Tom Tromey <tromey@adacore.com>
5048 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5051 2019-04-25 Tom Tromey <tromey@adacore.com>
5053 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5055 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5056 (gdb_xml_parser::parse): Use std::move.
5057 * python/python-internal.h (gdbpy_convert_exception): Take a const
5059 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5061 * python/py-utils.c (gdbpy_convert_exception): Take a const
5063 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5065 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5067 * mi/mi-main.c (mi_print_exception): Take a const reference.
5068 * main.c (handle_command_errors): Take a const reference.
5069 * linespec.c (parse_linespec): Use std::move.
5070 * infcall.c (run_inferior_call): Use std::move.
5071 (call_function_by_hand_dummy): Use std::move.
5072 * exec.c (try_open_exec_file): Use std::move.
5073 * exceptions.h (exception_print, exception_fprintf)
5074 (exception_print_same): Update.
5075 * exceptions.c (print_exception, exception_print)
5076 (exception_fprintf, exception_print_same): Change parameters to
5078 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5079 * common/new-op.c: Use std::move.
5080 * common/common-exceptions.h (struct gdb_exception): Add move
5082 (struct gdb_exception_error, struct gdb_exception_quit, struct
5083 gdb_quit_bad_alloc): Change constructor to move constructor.
5084 (throw_exception): Change parameter to rvalue reference.
5085 * common/common-exceptions.c (throw_exception): Take rvalue
5087 * cli/cli-interp.c (safe_execute_command): Use std::move.
5088 * breakpoint.c (insert_bp_location, location_to_sals): Use
5091 2019-04-25 Tom Tromey <tromey@adacore.com>
5093 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5094 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5095 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5096 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5097 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5098 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5099 guile/scm-value.c: Use unpack.
5100 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5101 gdbscm_gdb_exception.
5102 (gdbscm_throw_gdb_exception): Likewise.
5103 (struct gdbscm_gdb_exception): New.
5104 (unpack): New function.
5105 (gdbscm_wrap): Use unpack.
5107 2019-04-25 Tom Tromey <tromey@adacore.com>
5109 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5110 (gdb_rl_callback_handler): Use std::move.
5111 * common/common-exceptions.h (struct gdb_exception): Add move
5112 assignment operator.
5113 (throw_exception_sjlj): Change "exception" to const reference.
5114 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5115 (throw_exception_sjlj): Change "exception" to const reference.
5117 2019-04-25 Tom Tromey <tromey@adacore.com>
5119 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5120 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5121 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5123 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5125 * mi/mi-interp.c (mi_interp::exec): Update.
5126 * linespec.c (parse_linespec): Update.
5127 * infcall.c (run_inferior_call): Update.
5128 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5129 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5130 (gdbscm_lookup_global_symbol): Update.
5131 * guile/scm-param.c (gdbscm_parameter_value): Update.
5132 * guile/scm-frame.c (gdbscm_frame_read_register)
5133 (gdbscm_frame_read_var): Update.
5134 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5135 * exec.c (try_open_exec_file): Update.
5136 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5137 (gdb_rl_callback_handler): Update.
5138 * common/common-exceptions.h (exception_none): Don't declare.
5139 * common/common-exceptions.c (exception_none): Don't define.
5140 (struct catcher) <exception>: Update.
5141 * cli/cli-interp.c (safe_execute_command): Update.
5142 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5144 2019-04-25 Ali Tamur <tamur@google.com>
5146 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5147 (read_attribute_value): Likewise.
5148 (dwarf2_read_addr_index): Update comment.
5149 (read_str_index): Add DW_FORM_strx.
5150 (dwarf2_string_attr): Likewise.
5151 (dwarf2_const_value_attr): Likewise.
5152 (dump_die_shallow): Likewise.
5153 (dwarf2_fetch_constant_bytes): Likewise.
5154 (skip_form_bytes): Likewise.
5155 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5157 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5161 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5162 OFFSET. Verify if current mapping contains an ELF header.
5163 (linux_find_memory_regions_full): Adjust call to
5166 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5167 Kang Li <kanglictf@gmail.com>
5171 * dwarf2-frame.c (read_initial_length): Be consistent about using
5172 unsigned representation of length.
5173 (decode_frame_entry_1): Likewise. Check for wraparound of
5174 end pointer as well as buffer overflow.
5176 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
5178 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5181 2019-04-24 Tom Tromey <tromey@adacore.com>
5183 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5185 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5187 * s12z-tdep.c (s12z_unwind_pc): Delete.
5188 (s12z_unwind_sp): Delete.
5189 (s12z_gdbarch_init): Don't register deleted functions with
5192 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5194 * rl78-tdep.c (rl78_unwind_sp): Delete.
5195 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5197 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5199 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5200 (xstormy16_unwind_pc): Delete.
5201 (xstormy16_dummy_id): Delete.
5202 (xstormy16_gdbarch_init): Don't register deleted functions with
5205 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5207 * vax-tdep.c (vax_unwind_pc): Delete.
5208 (vax_gdbarch_init): Don't register deleted function with gdbarch.
5210 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5212 * v850-tdep.c (v850_unwind_sp): Delete.
5213 (v850_unwind_pc): Delete.
5214 (v850_dummy_id): Delete.
5215 (v850_gdbarch_init): Don't register deleted functions with
5218 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5220 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5221 (tilegx_unwind_pc): Delete.
5222 (tilegx_unwind_dummy_id): Delete.
5223 (tilegx_gdbarch_init): Don't register deleted functions with
5226 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5228 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5229 (tic6x_dummy_id): Delete.
5230 (tic6x_gdbarch_init): Don't register deleted functions with
5233 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5235 * sparc-tdep.c (sparc_unwind_pc): Delete.
5236 (sparc32_gdbarch_init): Don't register deleted function with
5239 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5241 * sh-tdep.c (sh_unwind_sp): Delete.
5242 (sh_unwind_pc): Delete.
5243 (sh_dummy_id): Delete.
5244 (sh_gdbarch_init): Don't register deleted functions with
5247 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5249 * score-tdep.c (score_unwind_sp): Delete.
5250 (score_unwind_pc): Delete.
5251 (score_dummy_id): Delete.
5252 (score_gdbarch_init): Don't register deleted functions with
5255 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5257 * rx-tdep.c (rx_unwind_pc): Delete.
5258 (rx_unwind_sp): Delete.
5259 (rx_dummy_id): Delete.
5260 (rx_gdbarch_init): Don't register deleted functions with
5261 gdbarch. Update comment.
5263 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5265 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5266 (rs6000_dummy_id): Delete.
5267 (rs6000_gdbarch_init): Don't register deleted functions with
5270 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5272 * or1k-tdep.c (or1k_dummy_id): Delete.
5273 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5275 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5277 * nios2-tdep.c (nios2_dummy_id): Delete.
5278 (nios2_unwind_sp): Delete.
5279 (nios2_gdbarch_init): Don't register deleted functions with
5282 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5284 * nds32-tdep.c (nds32_dummy_id): Delete.
5285 (nds32_unwind_pc): Delete.
5286 (nds32_unwind_sp): Delete.
5287 (nds32_gdbarch_init): Don't register deleted functions with
5290 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5292 * msp430-tdep.c (msp430_unwind_pc): Delete.
5293 (msp430_unwind_sp): Delete.
5294 (msp430_dummy_id): Delete.
5295 (msp430_gdbarch_init): Don't register deleted functions with
5298 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5300 * moxie-tdep.c (moxie_unwind_sp): Delete.
5301 (moxie_unwind_pc): Delete.
5302 (moxie_dummy_id): Delete.
5303 (moxie_gdbarch_init): Don't register deleted functions with
5306 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5308 * mn10300-tdep.c (mn10300_dummy_id): Delete.
5309 (mn10300_unwind_pc): Delete.
5310 (mn10300_unwind_sp): Delete.
5311 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5313 (mn10300_frame_unwind_init): Don't register deleted functions with
5316 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5318 * mep-tdep.c (mep_unwind_pc): Delete.
5319 (mep_unwind_sp): Delete.
5320 (mep_dummy_id): Delete.
5321 (mep_gdbarch_init): Don't register deleted functions with
5324 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5326 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5327 (m68hc11_unwind_sp): Delete.
5328 (m68hc11_gdbarch_init): Don't register deleted functions with
5331 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5333 * m32r-tdep.c (m32r_unwind_sp): Delete.
5334 (m32r_unwind_pc): Delete.
5335 (m32r_dummy_id): Delete.
5336 (m32r_gdbarch_init): Don't register deleted functions with
5339 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5341 * m32c-tdep.c (m32c_unwind_pc): Delete.
5342 (m32c_unwind_sp): Delete.
5343 (m32c_dummy_id): Delete.
5344 (m32c_gdbarch_init): Don't register deleted functions with
5347 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5349 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5350 (lm32_unwind_pc): Delete.
5351 (lm32_dummy_id): Delete.
5352 (lm32_gdbarch_init): Don't register deleted functions with
5355 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5357 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5358 (iq2000_unwind_pc): Delete.
5359 (iq2000_dummy_id): Delete.
5360 (iq2000_gdbarch_init): Don't register deleted functions with
5363 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5365 * nds32-tdep.c (nds32_type_align): Delete.
5366 (nds32_push_dummy_call): Use type_align instead.
5368 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5370 * arm-tdep.c (arm_type_align): Only handle vector override case.
5371 (arm_push_dummy_call): Use type_align.
5372 (arm_gdbarch_init): Register arm_type_align gdbarch function.
5374 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5376 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5378 (pass_on_stack): Use type_align.
5379 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5382 2019-04-23 Tom Tromey <tromey@adacore.com>
5384 * dwarf2read.c (line_header::file_name_at): Remove unused
5387 2019-04-23 Tom de Vries <tdevries@suse.de>
5390 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5394 2019-03-27 Ali Tamur <tamur@google.com>
5396 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5397 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5398 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5399 (dwarf_expr_context::get_addr_index): Likewise
5400 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5401 (symbol_needs_eval_context::get_addr_index): Likewise
5402 (disassemble_dwarf_expression): Add DW_OP_addrx
5403 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5404 (read_cutu_die_from_dwo): Update comment
5405 (skip_one_die): Add DW_FORM_addrx
5406 (read_attribute_value): Likewise
5407 (var_decode_location): Add DW_OP_addrx
5408 (dwarf2_const_value_attr): Add DW_FORM_addrx
5409 (dump_die_shallow): Likewise
5410 (dwarf2_fetch_constant_bytes): Likewise
5411 (decode_locdesc): Add DW_OP_addrx
5412 (skip_form_bytes): Add DW_FORM_addrx
5414 2019-04-22 Ali Tamur <tamur@google.com>
5416 * MAINTAINERS (Write After Approval): Add self.
5418 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
5420 * solib-svr4.c (get_svr4_info): Add pspace parameter.
5421 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5422 (open_symbol_file_object): Likewise.
5423 (svr4_default_sos): Add info parameter.
5424 (svr4_read_so_list): Likewise.
5425 (svr4_current_sos_direct): Adjust functions calls to pass down
5427 (svr4_current_sos_1): Add info parameter.
5428 (svr4_current_sos): Call get_svr4_info, pass info down to
5430 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5432 (svr4_in_dynsym_resolve_code): Pass current_program_space to
5434 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5436 (probes_table_remove_objfile_probes): Likewise.
5437 (register_solib_event_probe): Add info parameter.
5438 (solist_update_incremental): Pass info parameter down to
5440 (disable_probes_interface): Add info parameter.
5441 (svr4_handle_solib_event): Pass current_program_space to
5442 get_svr4_info. Adjust disable_probes_interface cleanup.
5443 (svr4_create_probe_breakpoints): Add info parameter, pass it
5444 down to register_solib_event_probe.
5445 (svr4_create_solib_event_breakpoints): Add info parameter,
5446 pass it down to svr4_create_probe_breakpoints.
5447 (enable_break): Pass info down to
5448 svr4_create_solib_event_breakpoints.
5449 (svr4_solib_create_inferior_hook): Pass current_program_space to
5451 (svr4_clear_solib): Likewise.
5453 2019-04-22 Pedro Alves <palves@redhat.com>
5455 * solib-svr4.c (svr4_free_objfile_observer): New.
5456 (probe_and_action::objfile): New field.
5457 (probes_table_htab_remove_objfile_probes)
5458 (probes_table_remove_objfile_probes): New functions.
5459 (register_solib_event_probe): Add 'objfile' parameter. Store it
5460 in the new probe_and_action. Don't store the probe in 'lookup'.
5461 (svr4_create_probe_breakpoints): Pass objfile to
5462 register_solib_event_probe.
5463 (_initialize_svr4_solib): Register a free_objfile observer.
5465 2019-04-19 Tom Tromey <tom@tromey.com>
5467 * common/queue.h: Remove.
5469 2019-04-19 Tom Tromey <tom@tromey.com>
5471 * event-loop.c: Don't include "common/queue.h".
5473 2019-04-19 Tom Tromey <tom@tromey.com>
5475 * remote.c (remote_target): Use delete.
5476 * remote-notif.h: Include <list>, not "common/queue.h".
5477 (notif_client_p): Remove typedef.
5478 (remote_notif_state): Add constructor, destructor, initializer.
5479 <notif_queue>: Now a std::list.
5480 (remote_notif_state_xfree): Don't declare.
5481 * remote-notif.c (remote_notif_process, handle_notification)
5482 (remote_notif_state_allocate): Update.
5483 (~remote_notif_state): Rename from remote_notif_state_xfree.
5485 2019-04-19 Tom Tromey <tom@tromey.com>
5487 * symfile.c (reread_symbols): Update.
5488 * objfiles.c (objfile_register_static_link)
5489 (objfile_lookup_static_link): Update
5490 (~objfile) Don't delete static_links.
5491 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5493 2019-04-19 Tom Tromey <tom@tromey.com>
5495 * type-stack.h (struct type_stack) <insert>: Constify string.
5496 * type-stack.c (type_stack::insert): Constify string.
5497 * gdbtypes.h (lookup_template_type): Update.
5498 (address_space_name_to_int): Update.
5499 * gdbtypes.c (address_space_name_to_int): Make space_identifier
5501 (lookup_template_type): Make name const.
5502 * c-exp.y: Update rules.
5503 (lex_one_token, classify_name, classify_inner_name)
5504 (c_print_token): Update.
5505 * p-exp.y: Update rules.
5507 * f-exp.y: Update rules.
5509 * d-exp.y: Update rules.
5510 (lex_one_token, classify_name, classify_inner_name): Update.
5511 * parse.c (write_dollar_variable, copy_name): Return std::string.
5512 * parser-defs.h (copy_name): Change return type.
5513 * m2-exp.y: Update rules.
5515 * go-exp.y (lex_one_token): Update.
5517 (classify_unsafe_function, classify_packaged_name)
5518 (classify_name, yylex): Update.
5520 2019-04-19 Sergei Trofimovich <siarheit@google.com>
5522 * configure.ac: add --enable-source-highlight switch.
5523 * configure: Regenerate.
5524 * top.c (print_gdb_version): plumb --enable-source-highlight
5525 status to "show configuration".
5527 2019-04-19 Tom Tromey <tromey@adacore.com>
5529 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5531 (empty_record, ada_template_to_fixed_record_type_1)
5532 (template_to_static_fixed_type)
5533 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5534 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5535 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5538 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
5541 * source.c (print_source_lines_base): Advance "iter" when a
5542 control character is seen.
5544 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5546 * inferior.h (struct infcall_suspend_state_deleter):
5547 Catch exception in destructor to avoid crash.
5549 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5551 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5552 close to the add_com "shell".
5554 2019-04-18 Tom Tromey <tromey@adacore.com>
5556 * process-stratum-target.h (class process_stratum_target)
5557 <stratum>: Add "final".
5559 2019-04-17 Tom Tromey <tromey@adacore.com>
5561 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5562 against nullptr before use.
5564 2019-04-17 Alan Hayward <alan.hayward@arm.com>
5566 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5568 2019-04-17 Jim Wilson <jimw@sifive.com>
5569 Andrew Burgess <andrew.burgess@embecosm.com>
5571 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5572 code read might fail, assume 4-byte breakpoint in that case.
5574 2019-04-15 Leszek Swirski <leszeks@google.com>
5576 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5577 rather than a hand-rolled POD check when checking for forced MEMORY
5580 2019-04-15 Alan Hayward <alan.hayward@arm.com>
5582 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5583 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5585 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5586 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5587 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5590 2019-04-15 Alan Hayward <alan.hayward@arm.com>
5592 * aarch64-linux-nat.c
5593 (aarch64_linux_nat_target::thread_architecture): Add override.
5594 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5597 2019-04-15 Alan Hayward <alan.hayward@arm.com>
5599 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5601 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
5603 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5604 target types of size 96-bits, add some additional comments, and
5605 check that the builtin type we found was the correct size.
5607 2019-04-12 Eli Zaretskii <eliz@gnu.org>
5609 * utils.c (prompt_for_continue): Don't restore the styling at the
5610 end, as applied_style has the wrong value. This fixes styling in
5611 long lists of file names that are interrupted by the "Continue?"
5614 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
5616 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5617 * c-lang.c (c_language_defn): Likewise.
5618 (cplus_language_defn): Likewise.
5619 (asm_language_defn): Likewise.
5620 (minimal_language_defn): Likewise.
5621 * d-lang.c (d_language_defn): Likewise.
5622 * f-lang.c (f_language_defn): Likewise.
5623 * go-lang.c (go_language_defn): Likewise.
5624 * language.c (unknown_language_defn): Likewise.
5625 (auto_language_defn): Likewise.
5626 * language.h (struct language_defn): Remove la_magic field.
5627 (LANG_MAGIC): Delete.
5628 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5629 * objc-lang.c (objc_language_defn): Likewise.
5630 * opencl-lang.c (opencl_language_defn): Likewise.
5631 * p-lang.c (pascal_language_defn): Likewise.
5632 * rust-lang.c (rust_language_defn): Likewise.
5634 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5636 * riscv-tdep.c (riscv_type_align): New function.
5637 (riscv_type_alignment): Delete.
5638 (riscv_arg_location): Use 'type_align'.
5639 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5641 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5643 * gdbtypes.c (type_align): A struct with no non-static fields also
5646 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5648 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5650 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5652 (riscv_struct_info::analyse): New implementation using new
5653 analyse_inner member function.
5654 (riscv_struct_info::field_offset): New member function.
5655 (riscv_struct_info::m_offsets): New member variable.
5656 (riscv_struct_info::analyse_inner): New private member function,
5657 takes the old implementation of riscv_struct_info::analyse but
5658 extended to track field offsets.
5659 (riscv_call_arg_struct): Update the struct folding special cases
5660 to handle cases where empty C++ structs, which are non-zero
5662 (riscv_arg_location): Initialise the length of each location, a
5663 non-zero length now indicates the location is in use.
5664 (riscv_push_dummy_call): Allow for the first location having a
5665 non-zero offset when setting up arguments.
5666 (riscv_return_value): Likewise, but for return values.
5668 2019-04-11 Tom Tromey <tromey@adacore.com>
5670 * utils.c (internal_vproblem): Make "msg" const.
5672 2019-04-11 Alan Hayward <alan.hayward@arm.com>
5674 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5675 * trad-frame.c (trad_frame_reset_saved_regs): New function.
5676 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5677 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5679 2019-04-10 Kevin Buettner <kevinb@redhat.com>
5681 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5683 (fill_gregset): Call amd64_linux_collect_native_gregset instead
5684 of amd64_collect_native_gregset.
5685 (amd64_linux_nat_target::store_registers): Likewise.
5687 2019-04-10 Tom Tromey <tom@tromey.com>
5689 * symtab.c (lookup_global_symbol_from_objfile)
5690 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5691 * objfiles.h (class separate_debug_iterator): New.
5692 (class separate_debug_range): New.
5693 (struct objfile) <separate_debug_objfiles>: New method.
5694 (objfile_separate_debug_iterate): Don't declare.
5695 * objfiles.c (separate_debug_iterator::operator++): Rename from
5696 objfile_separate_debug_iterate.
5697 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5699 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5702 2019-04-10 Tom Tromey <tom@tromey.com>
5704 * symfile.c (reread_symbols): Remove old comment.
5705 * objfiles.c (free_all_objfiles): Fix a typo.
5707 2019-04-10 Tom Tromey <tom@tromey.com>
5709 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5710 * minsyms.c (lookup_minimal_symbol): Use foreach.
5711 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5712 (lookup_minimal_symbol_solib_trampoline): Likewise.
5713 * symfile.c (reread_symbols): Use foreach.
5715 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
5716 Tom Tromey <tromey@adacore.com>
5719 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5720 (rust_lex_int_test): Change "value" to be LONGEST.
5721 (rust_lex_tests): Add test for long integer literal.
5723 2019-04-09 Tom Tromey <tromey@adacore.com>
5725 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5727 (extended_remote_target::attach): Update.
5728 (remote_target::remote_notice_new_inferior): Update.
5729 (remote_target::add_current_inferior_and_thread): Update.
5730 * inferior.c (exit_inferior_1): Use "false".
5731 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5733 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
5735 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5736 the "start" command.
5738 2019-04-08 Kevin Buettner <kevinb@redhat.com>
5740 * python/py-inferior.c (infpy_thread_from_thread_handle):
5741 Adjust comments to reflect renaming of thread_from_thread_handle
5742 to thread_from_handle. Adjust keywords. Fix type error message.
5743 (inferior_object_methods): Add thread_from_handle. Retain
5744 thread_from_thread_handle, but mark it as deprecated.
5746 2019-04-08 Kevin Buettner <kevinb@redhat.com>
5748 * gdbthread.h (find_thread_by_handle): Revise declaration.
5749 * thread.c (find_thread_by_handle): Likewise. Adjust
5751 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5752 support for buffer objects as handles.
5754 2019-04-08 Kevin Buettner <kevinb@redhat.com>
5756 * python/py-infthread.c (thpy_thread_handle): New function.
5757 (thread_object_methods): Register thpy_thread_handle.
5759 2019-04-08 Kevin Buettner <kevinb@redhat.com>
5761 * gdbthread.h (thread_to_thread_handle): Declare.
5762 * thread.c (gdbtypes.h): Include.
5763 (thread_to_thread_handle): New function.
5765 * target.h (struct target_ops): Add thread_info_to_thread_handle.
5766 (target_thread_info_to_thread_handle): Declare.
5767 * target.c (target_thread_info_to_thread_handle): New function.
5768 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5769 * target-delegates.c: Regenerate.
5771 * linux-thread-db.c (class thread_db_target): Add method
5772 thread_info_to_thread_handle.
5773 (thread_db_target::thread_info_to_thread_handle): Define.
5774 * remote.c (class remote_target): Add new method
5775 thread_info_to_thread_handle.
5776 (remote_target::thread_info_to_thread_handle): Define.
5778 2019-04-08 Pedro Alves <palves@redhat.com>
5780 * common/common-exceptions.c (throw_exception): Don't create
5781 named object to throw; throw directly.
5782 (throw_it): Likewise. Don't initialize gdb_exception::message
5783 here, with new; pass FMT and AP to the ctor instead.
5784 * common/common-exceptions.h: Include <string>.
5785 (gdb_exception::gdb_exception(enum return_reason, enum errors,
5786 const char *, va_list)): New ctor. Use std::make_shared.
5787 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5789 (gdb_exception_error::gdb_exception_error(enum errors, const char
5791 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5793 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5795 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5796 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5799 2019-04-08 Tom Tromey <tom@tromey.com>
5801 * valops.c (value_rtti_indirect_type): Replace throw_exception
5803 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5805 * thread.c (thr_try_catch_cmd): Replace throw_exception with
5807 * target.c (target_translate_tls_address): Replace throw_exception
5809 * stack.c (frame_apply_command_count): Replace throw_exception
5811 * solib-spu.c (append_ocl_sos): Replace throw_exception with
5813 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5815 * rs6000-tdep.c (rs6000_frame_cache)
5816 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5817 * remote.c: Replace throw_exception with throw.
5818 * record-full.c (record_full_message, record_full_wait_1)
5819 (record_full_restore): Replace throw_exception with throw.
5821 (get_thread_current_frame_id, record_btrace_start_replaying)
5822 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5823 (cmd_record_btrace_start): Replace throw_exception with throw.
5824 * parse.c (parse_exp_in_context_1): Replace throw_exception with
5826 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5827 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5829 (find_linespec_symbols): Replace throw_exception with throw.
5830 * infrun.c (displaced_step_prepare, resume): Replace
5831 throw_exception with throw.
5832 * infcmd.c (post_create_inferior): Replace throw_exception with
5834 * inf-loop.c (inferior_event_handler): Replace throw_exception
5836 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5837 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5838 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5839 (get_prev_frame_always, get_frame_pc_if_available)
5840 (get_frame_address_in_block_if_available, get_frame_language):
5841 Replace throw_exception with throw.
5842 * frame-unwind.c (frame_unwind_try_unwinder): Replace
5843 throw_exception with throw.
5844 * eval.c (fetch_subexp_value, evaluate_var_value)
5845 (evaluate_funcall, evaluate_subexp_standard): Replace
5846 throw_exception with throw.
5847 * dwarf2loc.c (call_site_find_chain)
5848 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5849 Replace throw_exception with throw.
5850 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5852 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5854 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5855 * completer.c (complete_line_internal): Replace throw_exception
5857 * compile/compile-object-run.c (compile_object_run): Replace
5858 throw_exception with throw.
5859 * cli/cli-script.c (process_next_line): Replace throw_exception
5861 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5862 (btrace_enable, btrace_maint_update_pt_packets): Replace
5863 throw_exception with throw.
5864 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5865 throw_exception with throw.
5866 * break-catch-throw.c (re_set_exception_catchpoint): Replace
5867 throw_exception with throw.
5868 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5869 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5870 * aarch64-tdep.c (aarch64_make_prologue_cache)
5871 (aarch64_make_stub_cache): Replace throw_exception with throw.
5873 2019-04-08 Tom Tromey <tom@tromey.com>
5875 * common/common-exceptions.c (throw_exception): Rename from
5876 throw_exception_cxx. Remove old copy. Make argument const.
5877 (throw_it): Create and throw exception objects directly.
5878 * common/common-exceptions.h (throw_exception): Make argument
5880 (struct gdb_exception_error): Add constructor.
5881 (struct gdb_exception_quit): Add constructor.
5883 2019-04-08 Tom Tromey <tom@tromey.com>
5885 * common/common-exceptions.h (exception_rethrow): Don't declare.
5886 (TRY_SJLJ): Update comment.
5887 (TRY, CATCH, END_CATCH): Remove.
5888 * common/common-exceptions.c (exception_rethrow): Remove.
5890 2019-04-08 Tom Tromey <tom@tromey.com>
5892 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5894 (gdb_exception_error): Rename from
5895 gdb_exception_RETURN_MASK_ERROR.
5896 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5897 (gdb_quit_bad_alloc): Update.
5898 * aarch64-tdep.c: Update.
5899 * ada-lang.c: Update.
5900 * ada-typeprint.c: Update.
5901 * ada-valprint.c: Update.
5902 * amd64-tdep.c: Update.
5903 * arch-utils.c: Update.
5904 * break-catch-throw.c: Update.
5905 * breakpoint.c: Update.
5907 * c-varobj.c: Update.
5908 * cli/cli-cmds.c: Update.
5909 * cli/cli-interp.c: Update.
5910 * cli/cli-script.c: Update.
5911 * common/common-exceptions.c: Update.
5912 * common/new-op.c: Update.
5913 * common/selftest.c: Update.
5914 * compile/compile-c-symbols.c: Update.
5915 * compile/compile-cplus-symbols.c: Update.
5916 * compile/compile-object-load.c: Update.
5917 * compile/compile-object-run.c: Update.
5918 * completer.c: Update.
5919 * corelow.c: Update.
5921 * cp-support.c: Update.
5922 * cp-valprint.c: Update.
5923 * darwin-nat.c: Update.
5924 * disasm-selftests.c: Update.
5925 * dtrace-probe.c: Update.
5926 * dwarf-index-cache.c: Update.
5927 * dwarf-index-write.c: Update.
5928 * dwarf2-frame-tailcall.c: Update.
5929 * dwarf2-frame.c: Update.
5930 * dwarf2loc.c: Update.
5931 * dwarf2read.c: Update.
5933 * event-loop.c: Update.
5934 * event-top.c: Update.
5936 * f-valprint.c: Update.
5937 * fbsd-tdep.c: Update.
5938 * frame-unwind.c: Update.
5940 * gdbtypes.c: Update.
5941 * gnu-v3-abi.c: Update.
5942 * guile/guile-internal.h: Update.
5943 * guile/scm-block.c: Update.
5944 * guile/scm-breakpoint.c: Update.
5945 * guile/scm-cmd.c: Update.
5946 * guile/scm-disasm.c: Update.
5947 * guile/scm-frame.c: Update.
5948 * guile/scm-lazy-string.c: Update.
5949 * guile/scm-math.c: Update.
5950 * guile/scm-param.c: Update.
5951 * guile/scm-ports.c: Update.
5952 * guile/scm-pretty-print.c: Update.
5953 * guile/scm-symbol.c: Update.
5954 * guile/scm-symtab.c: Update.
5955 * guile/scm-type.c: Update.
5956 * guile/scm-value.c: Update.
5957 * i386-linux-tdep.c: Update.
5958 * i386-tdep.c: Update.
5959 * inf-loop.c: Update.
5960 * infcall.c: Update.
5964 * language.c: Update.
5965 * linespec.c: Update.
5966 * linux-fork.c: Update.
5967 * linux-nat.c: Update.
5968 * linux-tdep.c: Update.
5969 * linux-thread-db.c: Update.
5971 * mi/mi-cmd-break.c: Update.
5972 * mi/mi-cmd-stack.c: Update.
5973 * mi/mi-interp.c: Update.
5974 * mi/mi-main.c: Update.
5975 * objc-lang.c: Update.
5976 * p-valprint.c: Update.
5978 * ppc-linux-tdep.c: Update.
5979 * printcmd.c: Update.
5980 * python/py-arch.c: Update.
5981 * python/py-breakpoint.c: Update.
5982 * python/py-cmd.c: Update.
5983 * python/py-finishbreakpoint.c: Update.
5984 * python/py-frame.c: Update.
5985 * python/py-framefilter.c: Update.
5986 * python/py-gdb-readline.c: Update.
5987 * python/py-inferior.c: Update.
5988 * python/py-infthread.c: Update.
5989 * python/py-lazy-string.c: Update.
5990 * python/py-linetable.c: Update.
5991 * python/py-objfile.c: Update.
5992 * python/py-param.c: Update.
5993 * python/py-prettyprint.c: Update.
5994 * python/py-progspace.c: Update.
5995 * python/py-record-btrace.c: Update.
5996 * python/py-record.c: Update.
5997 * python/py-symbol.c: Update.
5998 * python/py-type.c: Update.
5999 * python/py-unwind.c: Update.
6000 * python/py-utils.c: Update.
6001 * python/py-value.c: Update.
6002 * python/python.c: Update.
6003 * record-btrace.c: Update.
6004 * record-full.c: Update.
6005 * remote-fileio.c: Update.
6007 * riscv-tdep.c: Update.
6008 * rs6000-aix-tdep.c: Update.
6009 * rs6000-tdep.c: Update.
6010 * rust-exp.y: Update.
6011 * rust-lang.c: Update.
6012 * s390-tdep.c: Update.
6013 * selftest-arch.c: Update.
6014 * solib-dsbt.c: Update.
6015 * solib-frv.c: Update.
6016 * solib-spu.c: Update.
6017 * solib-svr4.c: Update.
6019 * sparc64-linux-tdep.c: Update.
6021 * symfile-mem.c: Update.
6022 * symmisc.c: Update.
6026 * tracefile-tfile.c: Update.
6027 * tui/tui.c: Update.
6028 * typeprint.c: Update.
6029 * unittests/cli-utils-selftests.c: Update.
6030 * unittests/parse-connection-spec-selftests.c: Update.
6032 * valprint.c: Update.
6035 * windows-nat.c: Update.
6036 * x86-linux-nat.c: Update.
6037 * xml-support.c: Update.
6039 2019-04-08 Tom Tromey <tom@tromey.com>
6041 * xml-support.c: Use C++ exception handling.
6042 * x86-linux-nat.c: Use C++ exception handling.
6043 * windows-nat.c: Use C++ exception handling.
6044 * varobj.c: Use C++ exception handling.
6045 * value.c: Use C++ exception handling.
6046 * valprint.c: Use C++ exception handling.
6047 * valops.c: Use C++ exception handling.
6048 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6050 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6051 * typeprint.c: Use C++ exception handling.
6052 * tui/tui.c: Use C++ exception handling.
6053 * tracefile-tfile.c: Use C++ exception handling.
6054 * top.c: Use C++ exception handling.
6055 * thread.c: Use C++ exception handling.
6056 * target.c: Use C++ exception handling.
6057 * symmisc.c: Use C++ exception handling.
6058 * symfile-mem.c: Use C++ exception handling.
6059 * stack.c: Use C++ exception handling.
6060 * sparc64-linux-tdep.c: Use C++ exception handling.
6061 * solib.c: Use C++ exception handling.
6062 * solib-svr4.c: Use C++ exception handling.
6063 * solib-spu.c: Use C++ exception handling.
6064 * solib-frv.c: Use C++ exception handling.
6065 * solib-dsbt.c: Use C++ exception handling.
6066 * selftest-arch.c: Use C++ exception handling.
6067 * s390-tdep.c: Use C++ exception handling.
6068 * rust-lang.c: Use C++ exception handling.
6069 * rust-exp.y: Use C++ exception handling.
6070 * rs6000-tdep.c: Use C++ exception handling.
6071 * rs6000-aix-tdep.c: Use C++ exception handling.
6072 * riscv-tdep.c: Use C++ exception handling.
6073 * remote.c: Use C++ exception handling.
6074 * remote-fileio.c: Use C++ exception handling.
6075 * record-full.c: Use C++ exception handling.
6076 * record-btrace.c: Use C++ exception handling.
6077 * python/python.c: Use C++ exception handling.
6078 * python/py-value.c: Use C++ exception handling.
6079 * python/py-utils.c: Use C++ exception handling.
6080 * python/py-unwind.c: Use C++ exception handling.
6081 * python/py-type.c: Use C++ exception handling.
6082 * python/py-symbol.c: Use C++ exception handling.
6083 * python/py-record.c: Use C++ exception handling.
6084 * python/py-record-btrace.c: Use C++ exception handling.
6085 * python/py-progspace.c: Use C++ exception handling.
6086 * python/py-prettyprint.c: Use C++ exception handling.
6087 * python/py-param.c: Use C++ exception handling.
6088 * python/py-objfile.c: Use C++ exception handling.
6089 * python/py-linetable.c: Use C++ exception handling.
6090 * python/py-lazy-string.c: Use C++ exception handling.
6091 * python/py-infthread.c: Use C++ exception handling.
6092 * python/py-inferior.c: Use C++ exception handling.
6093 * python/py-gdb-readline.c: Use C++ exception handling.
6094 * python/py-framefilter.c: Use C++ exception handling.
6095 * python/py-frame.c: Use C++ exception handling.
6096 * python/py-finishbreakpoint.c: Use C++ exception handling.
6097 * python/py-cmd.c: Use C++ exception handling.
6098 * python/py-breakpoint.c: Use C++ exception handling.
6099 * python/py-arch.c: Use C++ exception handling.
6100 * printcmd.c: Use C++ exception handling.
6101 * ppc-linux-tdep.c: Use C++ exception handling.
6102 * parse.c: Use C++ exception handling.
6103 * p-valprint.c: Use C++ exception handling.
6104 * objc-lang.c: Use C++ exception handling.
6105 * mi/mi-main.c: Use C++ exception handling.
6106 * mi/mi-interp.c: Use C++ exception handling.
6107 * mi/mi-cmd-stack.c: Use C++ exception handling.
6108 * mi/mi-cmd-break.c: Use C++ exception handling.
6109 * main.c: Use C++ exception handling.
6110 * linux-thread-db.c: Use C++ exception handling.
6111 * linux-tdep.c: Use C++ exception handling.
6112 * linux-nat.c: Use C++ exception handling.
6113 * linux-fork.c: Use C++ exception handling.
6114 * linespec.c: Use C++ exception handling.
6115 * language.c: Use C++ exception handling.
6116 * jit.c: Use C++ exception handling.
6117 * infrun.c: Use C++ exception handling.
6118 * infcmd.c: Use C++ exception handling.
6119 * infcall.c: Use C++ exception handling.
6120 * inf-loop.c: Use C++ exception handling.
6121 * i386-tdep.c: Use C++ exception handling.
6122 * i386-linux-tdep.c: Use C++ exception handling.
6123 * guile/scm-value.c: Use C++ exception handling.
6124 * guile/scm-type.c: Use C++ exception handling.
6125 * guile/scm-symtab.c: Use C++ exception handling.
6126 * guile/scm-symbol.c: Use C++ exception handling.
6127 * guile/scm-pretty-print.c: Use C++ exception handling.
6128 * guile/scm-ports.c: Use C++ exception handling.
6129 * guile/scm-param.c: Use C++ exception handling.
6130 * guile/scm-math.c: Use C++ exception handling.
6131 * guile/scm-lazy-string.c: Use C++ exception handling.
6132 * guile/scm-frame.c: Use C++ exception handling.
6133 * guile/scm-disasm.c: Use C++ exception handling.
6134 * guile/scm-cmd.c: Use C++ exception handling.
6135 * guile/scm-breakpoint.c: Use C++ exception handling.
6136 * guile/scm-block.c: Use C++ exception handling.
6137 * guile/guile-internal.h: Use C++ exception handling.
6138 * gnu-v3-abi.c: Use C++ exception handling.
6139 * gdbtypes.c: Use C++ exception handling.
6140 * frame.c: Use C++ exception handling.
6141 * frame-unwind.c: Use C++ exception handling.
6142 * fbsd-tdep.c: Use C++ exception handling.
6143 * f-valprint.c: Use C++ exception handling.
6144 * exec.c: Use C++ exception handling.
6145 * event-top.c: Use C++ exception handling.
6146 * event-loop.c: Use C++ exception handling.
6147 * eval.c: Use C++ exception handling.
6148 * dwarf2read.c: Use C++ exception handling.
6149 * dwarf2loc.c: Use C++ exception handling.
6150 * dwarf2-frame.c: Use C++ exception handling.
6151 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6152 * dwarf-index-write.c: Use C++ exception handling.
6153 * dwarf-index-cache.c: Use C++ exception handling.
6154 * dtrace-probe.c: Use C++ exception handling.
6155 * disasm-selftests.c: Use C++ exception handling.
6156 * darwin-nat.c: Use C++ exception handling.
6157 * cp-valprint.c: Use C++ exception handling.
6158 * cp-support.c: Use C++ exception handling.
6159 * cp-abi.c: Use C++ exception handling.
6160 * corelow.c: Use C++ exception handling.
6161 * completer.c: Use C++ exception handling.
6162 * compile/compile-object-run.c: Use C++ exception handling.
6163 * compile/compile-object-load.c: Use C++ exception handling.
6164 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6165 * compile/compile-c-symbols.c: Use C++ exception handling.
6166 * common/selftest.c: Use C++ exception handling.
6167 * common/new-op.c: Use C++ exception handling.
6168 * cli/cli-script.c: Use C++ exception handling.
6169 * cli/cli-interp.c: Use C++ exception handling.
6170 * cli/cli-cmds.c: Use C++ exception handling.
6171 * c-varobj.c: Use C++ exception handling.
6172 * btrace.c: Use C++ exception handling.
6173 * breakpoint.c: Use C++ exception handling.
6174 * break-catch-throw.c: Use C++ exception handling.
6175 * arch-utils.c: Use C++ exception handling.
6176 * amd64-tdep.c: Use C++ exception handling.
6177 * ada-valprint.c: Use C++ exception handling.
6178 * ada-typeprint.c: Use C++ exception handling.
6179 * ada-lang.c: Use C++ exception handling.
6180 * aarch64-tdep.c: Use C++ exception handling.
6182 2019-04-08 Tom Tromey <tom@tromey.com>
6184 * xml-support.c (gdb_xml_parser::parse): Update.
6185 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6186 * value.c (show_convenience): Update.
6187 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6188 (test_parse_flags_qcs): Update.
6189 * thread.c (thr_try_catch_cmd): Update.
6190 * target.c (target_translate_tls_address): Update.
6191 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6192 (info_frame_command_core, frame_apply_command_count): Update.
6193 * rust-exp.y (rust_lex_exception_test): Update.
6194 * riscv-tdep.c (riscv_print_one_register_info): Update.
6195 * remote.c (remote_target::enable_btrace): Update.
6196 * record-btrace.c (record_btrace_enable_warn): Update.
6197 * python/py-utils.c (gdbpy_convert_exception): Update.
6198 * printcmd.c (do_one_display, print_variable_and_value): Update.
6199 * mi/mi-main.c (mi_print_exception): Update.
6200 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6201 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6202 * linux-nat.c (linux_nat_target::attach): Update.
6203 * linux-fork.c (class scoped_switch_fork_info): Update.
6204 * infrun.c (displaced_step_prepare): Update.
6205 * infcall.c (call_function_by_hand_dummy): Update.
6206 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6207 * gnu-v3-abi.c (print_one_vtable): Update.
6208 * frame.c (get_prev_frame_always): Update.
6209 * f-valprint.c (info_common_command_for_block): Update.
6210 * exec.c (try_open_exec_file): Update.
6211 * exceptions.c (print_exception, exception_print)
6212 (exception_fprintf, exception_print_same): Update.
6213 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6214 * dwarf-index-cache.c (index_cache::store)
6215 (index_cache::lookup_gdb_index): Update.
6216 * darwin-nat.c (maybe_cache_shell): Update.
6217 * cp-valprint.c (cp_print_value_fields): Update.
6218 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6219 (gcc_cplus_symbol_address): Update.
6220 * compile/compile-c-symbols.c (gcc_convert_symbol)
6221 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6222 * common/selftest.c: Update.
6223 * common/common-exceptions.h (struct gdb_exception) <message>: Now
6225 (exception_try_scope_entry, exception_try_scope_exit): Don't
6227 (struct exception_try_scope): Remove.
6228 (TRY): Don't use exception_try_scope.
6229 (struct gdb_exception): Add constructor, operator=.
6231 (struct gdb_exception_RETURN_MASK_ALL)
6232 (struct gdb_exception_RETURN_MASK_ERROR)
6233 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6234 (struct gdb_quit_bad_alloc): Update.
6235 * common/common-exceptions.c (exception_none): Change
6237 (struct catcher) <state, exception>: Initialize inline.
6238 <prev>: Remove member.
6239 (current_catcher): Remove.
6240 (catchers): New global.
6241 (exceptions_state_mc_init): Simplify.
6242 (catcher_pop): Remove.
6243 (exceptions_state_mc, exceptions_state_mc_catch): Update.
6244 (try_scope_depth, exception_try_scope_entry)
6245 (exception_try_scope_exit): Remove.
6246 (throw_exception_sjlj): Update.
6247 (exception_messages, exception_messages_size): Remove.
6248 (throw_it): Simplify.
6249 (gdb_exception_sliced_copy): Remove.
6250 (throw_exception_cxx): Update.
6251 * cli/cli-script.c (script_from_file): Update.
6252 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6254 * ada-valprint.c (ada_val_print): Update.
6255 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6256 (create_excep_cond_exprs): Update.
6258 2019-04-08 Tom Tromey <tom@tromey.com>
6260 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6261 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6262 (TRY, CATCH, END_CATCH): Remove some definitions.
6263 * common/common-exceptions.c: Don't use GDB_XCPT.
6264 (catcher_list_size): Remove.
6265 (throw_exception, throw_it): Simplify.
6267 2019-04-05 Tom Tromey <tom@tromey.com>
6269 Revert the header-sorting patch.
6270 * ft32-tdep.c: Revert.
6271 * frv-tdep.c: Revert.
6272 * frv-linux-tdep.c: Revert.
6274 * frame-unwind.c: Revert.
6275 * frame-base.c: Revert.
6276 * fork-child.c: Revert.
6277 * findvar.c: Revert.
6278 * findcmd.c: Revert.
6279 * filesystem.c: Revert.
6280 * filename-seen-cache.h: Revert.
6281 * filename-seen-cache.c: Revert.
6282 * fbsd-tdep.c: Revert.
6283 * fbsd-nat.h: Revert.
6284 * fbsd-nat.c: Revert.
6285 * f-valprint.c: Revert.
6286 * f-typeprint.c: Revert.
6288 * extension.h: Revert.
6289 * extension.c: Revert.
6290 * extension-priv.h: Revert.
6291 * expprint.c: Revert.
6294 * exceptions.c: Revert.
6295 * event-top.c: Revert.
6296 * event-loop.c: Revert.
6298 * elfread.c: Revert.
6299 * dwarf2read.h: Revert.
6300 * dwarf2read.c: Revert.
6301 * dwarf2loc.c: Revert.
6302 * dwarf2expr.h: Revert.
6303 * dwarf2expr.c: Revert.
6304 * dwarf2-frame.c: Revert.
6305 * dwarf2-frame-tailcall.c: Revert.
6306 * dwarf-index-write.h: Revert.
6307 * dwarf-index-write.c: Revert.
6308 * dwarf-index-common.c: Revert.
6309 * dwarf-index-cache.h: Revert.
6310 * dwarf-index-cache.c: Revert.
6311 * dummy-frame.c: Revert.
6312 * dtrace-probe.c: Revert.
6315 * disasm-selftests.c: Revert.
6316 * dictionary.c: Revert.
6317 * dicos-tdep.c: Revert.
6318 * demangle.c: Revert.
6321 * darwin-nat.h: Revert.
6322 * darwin-nat.c: Revert.
6323 * darwin-nat-info.c: Revert.
6324 * d-valprint.c: Revert.
6325 * d-namespace.c: Revert.
6328 * csky-tdep.c: Revert.
6329 * csky-linux-tdep.c: Revert.
6330 * cris-tdep.c: Revert.
6331 * cris-linux-tdep.c: Revert.
6332 * cp-valprint.c: Revert.
6333 * cp-support.c: Revert.
6334 * cp-namespace.c: Revert.
6336 * corelow.c: Revert.
6337 * corefile.c: Revert.
6338 * continuations.c: Revert.
6339 * completer.h: Revert.
6340 * completer.c: Revert.
6341 * complaints.c: Revert.
6342 * coffread.c: Revert.
6343 * coff-pe-read.c: Revert.
6344 * cli-out.h: Revert.
6345 * cli-out.c: Revert.
6346 * charset.c: Revert.
6347 * c-varobj.c: Revert.
6348 * c-valprint.c: Revert.
6349 * c-typeprint.c: Revert.
6351 * buildsym.c: Revert.
6352 * buildsym-legacy.c: Revert.
6353 * build-id.h: Revert.
6354 * build-id.c: Revert.
6356 * bsd-uthread.c: Revert.
6357 * breakpoint.h: Revert.
6358 * breakpoint.c: Revert.
6359 * break-catch-throw.c: Revert.
6360 * break-catch-syscall.c: Revert.
6361 * break-catch-sig.c: Revert.
6362 * blockframe.c: Revert.
6364 * bfin-tdep.c: Revert.
6365 * bfin-linux-tdep.c: Revert.
6366 * bfd-target.c: Revert.
6368 * ax-general.c: Revert.
6371 * avr-tdep.c: Revert.
6373 * auto-load.c: Revert.
6374 * arm-wince-tdep.c: Revert.
6375 * arm-tdep.c: Revert.
6376 * arm-symbian-tdep.c: Revert.
6377 * arm-pikeos-tdep.c: Revert.
6378 * arm-obsd-tdep.c: Revert.
6379 * arm-nbsd-tdep.c: Revert.
6380 * arm-nbsd-nat.c: Revert.
6381 * arm-linux-tdep.c: Revert.
6382 * arm-linux-nat.c: Revert.
6383 * arm-fbsd-tdep.c: Revert.
6384 * arm-fbsd-nat.c: Revert.
6385 * arm-bsd-tdep.c: Revert.
6386 * arch-utils.c: Revert.
6387 * arc-tdep.c: Revert.
6388 * arc-newlib-tdep.c: Revert.
6389 * annotate.h: Revert.
6390 * annotate.c: Revert.
6391 * amd64-windows-tdep.c: Revert.
6392 * amd64-windows-nat.c: Revert.
6393 * amd64-tdep.c: Revert.
6394 * amd64-sol2-tdep.c: Revert.
6395 * amd64-obsd-tdep.c: Revert.
6396 * amd64-obsd-nat.c: Revert.
6397 * amd64-nbsd-tdep.c: Revert.
6398 * amd64-nbsd-nat.c: Revert.
6399 * amd64-nat.c: Revert.
6400 * amd64-linux-tdep.c: Revert.
6401 * amd64-linux-nat.c: Revert.
6402 * amd64-fbsd-tdep.c: Revert.
6403 * amd64-fbsd-nat.c: Revert.
6404 * amd64-dicos-tdep.c: Revert.
6405 * amd64-darwin-tdep.c: Revert.
6406 * amd64-bsd-nat.c: Revert.
6407 * alpha-tdep.c: Revert.
6408 * alpha-obsd-tdep.c: Revert.
6409 * alpha-nbsd-tdep.c: Revert.
6410 * alpha-mdebug-tdep.c: Revert.
6411 * alpha-linux-tdep.c: Revert.
6412 * alpha-linux-nat.c: Revert.
6413 * alpha-bsd-tdep.c: Revert.
6414 * alpha-bsd-nat.c: Revert.
6415 * aix-thread.c: Revert.
6417 * addrmap.c: Revert.
6418 * ada-varobj.c: Revert.
6419 * ada-valprint.c: Revert.
6420 * ada-typeprint.c: Revert.
6421 * ada-tasks.c: Revert.
6422 * ada-lang.c: Revert.
6423 * aarch64-tdep.c: Revert.
6424 * aarch64-ravenscar-thread.c: Revert.
6425 * aarch64-newlib-tdep.c: Revert.
6426 * aarch64-linux-tdep.c: Revert.
6427 * aarch64-linux-nat.c: Revert.
6428 * aarch64-fbsd-tdep.c: Revert.
6429 * aarch64-fbsd-nat.c: Revert.
6430 * aarch32-linux-nat.c: Revert.
6432 2019-04-05 Tom Tromey <tom@tromey.com>
6434 * ft32-tdep.c: Sort headers.
6435 * frv-tdep.c: Sort headers.
6436 * frv-linux-tdep.c: Sort headers.
6437 * frame.c: Sort headers.
6438 * frame-unwind.c: Sort headers.
6439 * frame-base.c: Sort headers.
6440 * fork-child.c: Sort headers.
6441 * findvar.c: Sort headers.
6442 * findcmd.c: Sort headers.
6443 * filesystem.c: Sort headers.
6444 * filename-seen-cache.h: Sort headers.
6445 * filename-seen-cache.c: Sort headers.
6446 * fbsd-tdep.c: Sort headers.
6447 * fbsd-nat.h: Sort headers.
6448 * fbsd-nat.c: Sort headers.
6449 * f-valprint.c: Sort headers.
6450 * f-typeprint.c: Sort headers.
6451 * f-lang.c: Sort headers.
6452 * extension.h: Sort headers.
6453 * extension.c: Sort headers.
6454 * extension-priv.h: Sort headers.
6455 * expprint.c: Sort headers.
6456 * exec.h: Sort headers.
6457 * exec.c: Sort headers.
6458 * exceptions.c: Sort headers.
6459 * event-top.c: Sort headers.
6460 * event-loop.c: Sort headers.
6461 * eval.c: Sort headers.
6462 * elfread.c: Sort headers.
6463 * dwarf2read.h: Sort headers.
6464 * dwarf2read.c: Sort headers.
6465 * dwarf2loc.c: Sort headers.
6466 * dwarf2expr.h: Sort headers.
6467 * dwarf2expr.c: Sort headers.
6468 * dwarf2-frame.c: Sort headers.
6469 * dwarf2-frame-tailcall.c: Sort headers.
6470 * dwarf-index-write.h: Sort headers.
6471 * dwarf-index-write.c: Sort headers.
6472 * dwarf-index-common.c: Sort headers.
6473 * dwarf-index-cache.h: Sort headers.
6474 * dwarf-index-cache.c: Sort headers.
6475 * dummy-frame.c: Sort headers.
6476 * dtrace-probe.c: Sort headers.
6477 * disasm.h: Sort headers.
6478 * disasm.c: Sort headers.
6479 * disasm-selftests.c: Sort headers.
6480 * dictionary.c: Sort headers.
6481 * dicos-tdep.c: Sort headers.
6482 * demangle.c: Sort headers.
6483 * dcache.h: Sort headers.
6484 * dcache.c: Sort headers.
6485 * darwin-nat.h: Sort headers.
6486 * darwin-nat.c: Sort headers.
6487 * darwin-nat-info.c: Sort headers.
6488 * d-valprint.c: Sort headers.
6489 * d-namespace.c: Sort headers.
6490 * d-lang.c: Sort headers.
6491 * ctf.c: Sort headers.
6492 * csky-tdep.c: Sort headers.
6493 * csky-linux-tdep.c: Sort headers.
6494 * cris-tdep.c: Sort headers.
6495 * cris-linux-tdep.c: Sort headers.
6496 * cp-valprint.c: Sort headers.
6497 * cp-support.c: Sort headers.
6498 * cp-namespace.c: Sort headers.
6499 * cp-abi.c: Sort headers.
6500 * corelow.c: Sort headers.
6501 * corefile.c: Sort headers.
6502 * continuations.c: Sort headers.
6503 * completer.h: Sort headers.
6504 * completer.c: Sort headers.
6505 * complaints.c: Sort headers.
6506 * coffread.c: Sort headers.
6507 * coff-pe-read.c: Sort headers.
6508 * cli-out.h: Sort headers.
6509 * cli-out.c: Sort headers.
6510 * charset.c: Sort headers.
6511 * c-varobj.c: Sort headers.
6512 * c-valprint.c: Sort headers.
6513 * c-typeprint.c: Sort headers.
6514 * c-lang.c: Sort headers.
6515 * buildsym.c: Sort headers.
6516 * buildsym-legacy.c: Sort headers.
6517 * build-id.h: Sort headers.
6518 * build-id.c: Sort headers.
6519 * btrace.c: Sort headers.
6520 * bsd-uthread.c: Sort headers.
6521 * breakpoint.h: Sort headers.
6522 * breakpoint.c: Sort headers.
6523 * break-catch-throw.c: Sort headers.
6524 * break-catch-syscall.c: Sort headers.
6525 * break-catch-sig.c: Sort headers.
6526 * blockframe.c: Sort headers.
6527 * block.c: Sort headers.
6528 * bfin-tdep.c: Sort headers.
6529 * bfin-linux-tdep.c: Sort headers.
6530 * bfd-target.c: Sort headers.
6531 * bcache.c: Sort headers.
6532 * ax-general.c: Sort headers.
6533 * ax-gdb.h: Sort headers.
6534 * ax-gdb.c: Sort headers.
6535 * avr-tdep.c: Sort headers.
6536 * auxv.c: Sort headers.
6537 * auto-load.c: Sort headers.
6538 * arm-wince-tdep.c: Sort headers.
6539 * arm-tdep.c: Sort headers.
6540 * arm-symbian-tdep.c: Sort headers.
6541 * arm-pikeos-tdep.c: Sort headers.
6542 * arm-obsd-tdep.c: Sort headers.
6543 * arm-nbsd-tdep.c: Sort headers.
6544 * arm-nbsd-nat.c: Sort headers.
6545 * arm-linux-tdep.c: Sort headers.
6546 * arm-linux-nat.c: Sort headers.
6547 * arm-fbsd-tdep.c: Sort headers.
6548 * arm-fbsd-nat.c: Sort headers.
6549 * arm-bsd-tdep.c: Sort headers.
6550 * arch-utils.c: Sort headers.
6551 * arc-tdep.c: Sort headers.
6552 * arc-newlib-tdep.c: Sort headers.
6553 * annotate.h: Sort headers.
6554 * annotate.c: Sort headers.
6555 * amd64-windows-tdep.c: Sort headers.
6556 * amd64-windows-nat.c: Sort headers.
6557 * amd64-tdep.c: Sort headers.
6558 * amd64-sol2-tdep.c: Sort headers.
6559 * amd64-obsd-tdep.c: Sort headers.
6560 * amd64-obsd-nat.c: Sort headers.
6561 * amd64-nbsd-tdep.c: Sort headers.
6562 * amd64-nbsd-nat.c: Sort headers.
6563 * amd64-nat.c: Sort headers.
6564 * amd64-linux-tdep.c: Sort headers.
6565 * amd64-linux-nat.c: Sort headers.
6566 * amd64-fbsd-tdep.c: Sort headers.
6567 * amd64-fbsd-nat.c: Sort headers.
6568 * amd64-dicos-tdep.c: Sort headers.
6569 * amd64-darwin-tdep.c: Sort headers.
6570 * amd64-bsd-nat.c: Sort headers.
6571 * alpha-tdep.c: Sort headers.
6572 * alpha-obsd-tdep.c: Sort headers.
6573 * alpha-nbsd-tdep.c: Sort headers.
6574 * alpha-mdebug-tdep.c: Sort headers.
6575 * alpha-linux-tdep.c: Sort headers.
6576 * alpha-linux-nat.c: Sort headers.
6577 * alpha-bsd-tdep.c: Sort headers.
6578 * alpha-bsd-nat.c: Sort headers.
6579 * aix-thread.c: Sort headers.
6580 * agent.c: Sort headers.
6581 * addrmap.c: Sort headers.
6582 * ada-varobj.c: Sort headers.
6583 * ada-valprint.c: Sort headers.
6584 * ada-typeprint.c: Sort headers.
6585 * ada-tasks.c: Sort headers.
6586 * ada-lang.c: Sort headers.
6587 * aarch64-tdep.c: Sort headers.
6588 * aarch64-ravenscar-thread.c: Sort headers.
6589 * aarch64-newlib-tdep.c: Sort headers.
6590 * aarch64-linux-tdep.c: Sort headers.
6591 * aarch64-linux-nat.c: Sort headers.
6592 * aarch64-fbsd-tdep.c: Sort headers.
6593 * aarch64-fbsd-nat.c: Sort headers.
6594 * aarch32-linux-nat.c: Sort headers.
6596 2019-04-04 Tom Tromey <tom@tromey.com>
6598 * varobj.c (varobj_create): Update.
6599 * rust-exp.y (struct rust_parser) <update_innermost_block,
6600 lookup_symbol>: New methods.
6601 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6603 (rust_parser::rust_lookup_type)
6604 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6605 * printcmd.c (display_command, do_one_display): Update.
6606 * parser-defs.h (struct parser_state) <parser_state>: Add
6607 "tracker" parameter.
6608 (block_tracker): New member.
6609 (class innermost_block_tracker) <innermost_block_tracker>: Add
6611 <reset>: Remove method.
6612 (innermost_block): Don't declare.
6613 (null_post_parser): Update.
6614 * parse.c (innermost_block): Remove global.
6615 (write_dollar_variable): Update.
6616 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6617 Remove "tracker_types" parameter.
6618 (parse_expression): Add "tracker" parameter.
6619 (parse_expression_for_completion): Update.
6620 (null_post_parser): Add "tracker" parameter.
6621 * p-exp.y: Update rules.
6622 * m2-exp.y: Update rules.
6623 * language.h (struct language_defn) <la_post_parser>: Add
6624 "tracker" parameter.
6625 * go-exp.y: Update rules.
6626 * f-exp.y: Update rules.
6627 * expression.h (parse_expression, parse_exp_1): Add "tracker"
6629 * d-exp.y: Update rules.
6630 * c-exp.y: Update rules.
6631 * breakpoint.c (set_breakpoint_condition): Create an
6632 innermost_block_tracker.
6633 (watch_command_1): Likewise.
6634 * ada-lang.c (resolve): Add "tracker" parameter.
6635 (resolve_subexp): Likewise.
6636 * ada-exp.y (write_var_from_sym): Update.
6638 2019-04-04 Tom Tromey <tom@tromey.com>
6640 * type-stack.h: New file.
6641 * type-stack.c: New file.
6642 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6644 (insert_into_type_stack, insert_type, push_type, push_type_int)
6645 (insert_type_address_space, pop_type, pop_type_int)
6646 (pop_typelist, pop_type_stack, append_type_stack)
6647 (push_type_stack, get_type_stack, push_typelist)
6648 (follow_type_instance_flags, follow_types): Don't declare.
6649 * parse.c (type_stack): Remove global.
6650 (parse_exp_in_context): Update.
6651 (insert_into_type_stack, insert_type, push_type, push_type_int)
6652 (insert_type_address_space, pop_type, pop_type_int)
6653 (pop_typelist, pop_type_stack, append_type_stack)
6654 (push_type_stack, get_type_stack, push_typelist)
6655 (follow_type_instance_flags, follow_types): Remove (moved to
6657 * f-exp.y (type_stack): New global.
6659 (push_kind_type, f_parse): Update.
6660 * d-exp.y (type_stack): New global.
6663 * c-exp.y (struct c_parse_state) <type_stack>: New member.
6665 * Makefile.in (COMMON_SFILES): Add type-stack.c.
6666 (HFILES_NO_SRCDIR): Add type-stack.h.
6668 2019-04-04 Tom Tromey <tom@tromey.com>
6670 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6671 (rust_parser::convert_ast_to_expression, rust_parse)
6672 (rust_lex_test_completion, rust_lex_tests): Update.
6673 * parser-defs.h (struct expr_completion_state): New.
6674 (struct parser_state) <parser_state>: Add completion parameter.
6675 <mark_struct_expression, mark_completion_tag>: New methods.
6676 <parse_completion, m_completion_state>: New members.
6677 (prefixify_expression, null_post_parser): Update.
6678 (mark_struct_expression, mark_completion_tag): Don't declare.
6679 * parse.c (parse_completion, expout_last_struct)
6680 (expout_tag_completion_type, expout_completion_name): Remove
6682 (parser_state::mark_struct_expression)
6683 (parser_state::mark_completion_tag): Now methods.
6684 (prefixify_expression): Add last_struct parameter.
6685 (prefixify_subexp): Likewise.
6686 (parse_exp_1): Update.
6687 (parse_exp_in_context): Add cstate parameter. Update.
6688 (parse_expression_for_completion): Create an
6689 expr_completion_state.
6690 (null_post_parser): Add "completion" parameter.
6691 * p-exp.y: Update rules.
6693 * language.h (struct language_defn) <la_post_parser>: Add
6694 "completing" parameter.
6695 * go-exp.y: Update rules.
6696 (lex_one_token): Update.
6697 * expression.h (parse_completion): Don't declare.
6698 * d-exp.y: Update rules.
6699 (lex_one_token): Update rules.
6700 * c-exp.y: Update rules.
6701 (lex_one_token): Update.
6702 * ada-lang.c (resolve): Add "parse_completion" parameter.
6703 (resolve_subexp): Likewise.
6704 (ada_resolve_function): Likewise.
6706 2019-04-04 Tom Tromey <tom@tromey.com>
6708 * parser-defs.h (struct parser_state) <start_arglist,
6709 end_arglist>: New methods.
6710 <arglist_len, m_funcall_chain>: New members.
6711 (arglist_len, start_arglist, end_arglist): Don't declare.
6712 * parse.c (arglist_len, funcall_chain): Remove global.
6713 (start_arglist, end_arglist): Remove functions.
6714 (parse_exp_in_context): Update.
6715 * p-exp.y: Update rules.
6716 * m2-exp.y: Update rules.
6717 * go-exp.y: Update rules.
6718 * f-exp.y: Update rules.
6719 * d-exp.y: Update rules.
6720 * c-exp.y: Update rules.
6722 2019-04-04 Tom Tromey <tom@tromey.com>
6724 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6725 lex_operator, push_back>: New methods.
6727 (rust_parser::lex_hex, lex_escape): Rename and update.
6728 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6729 (rust_parser::lex_operator): Rename and update.
6730 (rust_parser::lex_number, rustyylex, rustyyerror)
6731 (rust_lex_test_init, rust_lex_test_sequence)
6732 (rust_lex_test_push_back, rust_lex_tests): Update.
6733 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6735 <lexptr, prev_lexptr>: New members.
6736 (lexptr, prev_lexptr): Don't declare.
6737 * parse.c (lexptr, prev_lexptr): Remove globals.
6738 (parse_exp_in_context): Update.
6739 * p-exp.y (yylex, yyerror): Update.
6740 * m2-exp.y (parse_number, yylex, yyerror): Update.
6741 * go-exp.y (lex_one_token, yyerror): Update.
6742 * f-exp.y (match_string_literal, yylex, yyerror): Update.
6743 * d-exp.y (lex_one_token, yyerror): Update.
6744 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6745 (lex_one_token, yyerror): Update.
6746 * ada-lex.l (YY_INPUT): Update.
6747 (rewind_to_char): Update.
6748 * ada-exp.y (yyerror): Update.
6750 2019-04-04 Tom Tromey <tom@tromey.com>
6752 * rust-exp.y (rustyylex, rust_lex_tests): Update.
6753 * parser-defs.h (struct parser_state) <parser_state>: Add new
6755 <comma_terminates>: New member.
6756 (comma_terminates): Don't declare global.
6757 * parse.c (comma_terminates): Remove global.
6758 (parse_exp_in_context): Update.
6759 * p-exp.y (yylex): Update.
6760 * m2-exp.y (yylex): Update.
6761 * go-exp.y (lex_one_token): Update.
6762 * f-exp.y (yylex): Update.
6763 * d-exp.y (lex_one_token): Update.
6764 * c-exp.y (lex_one_token): Update.
6765 * ada-lex.l: Update.
6767 2019-04-04 Tom Tromey <tom@tromey.com>
6769 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6770 (rustyylex, rust_lex_test_init, rust_lex_test_one)
6771 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6772 * parser-defs.h (paren_depth): Don't declare.
6773 * parse.c (paren_depth): Remove global.
6774 (parse_exp_in_context): Update.
6775 * p-exp.y (paren_depth): New global.
6776 (pascal_parse): Initialize it.
6777 * m2-exp.y (paren_depth): New global.
6778 (m2_parse): Initialize it.
6779 * go-exp.y (paren_depth): New global.
6780 (go_parse): Initialize it.
6781 * f-exp.y (paren_depth): New global.
6782 (f_parse): Initialize it.
6783 * d-exp.y (paren_depth): New global.
6784 (d_parse): Initialize it.
6785 * c-exp.y (paren_depth): New global.
6786 (c_parse): Initialize it.
6787 * ada-lex.l (paren_depth): New global.
6788 (lexer_init): Initialize it.
6790 2019-04-04 Tom Tromey <tom@tromey.com>
6792 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6793 (rust_parser::convert_ast_to_type)
6794 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6795 * parser-defs.h (struct parser_state) <parser_state>: Add
6796 parameters. Initialize new members.
6797 <expression_context_block, expression_context_pc>: New members.
6798 * parse.c (expression_context_block, expression_context_pc):
6800 (parse_exp_in_context): Update.
6801 * p-exp.y: Update all rules.
6803 * m2-exp.y: Update all rules.
6805 * go-exp.y (yylex): Update.
6806 * f-exp.y (yylex): Update.
6807 * d-exp.y: Update all rules.
6809 * c-exp.y: Update all rules.
6810 (lex_one_token, classify_name, yylex, c_parse): Update.
6811 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6813 2019-04-04 Tom Tromey <tom@tromey.com>
6815 * gdbarch.h, gdbarch.c: Rebuild.
6816 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6818 (struct stap_parse_info): Replace "parser_state" with
6820 * parser-defs.h (struct expr_builder): Rename from "parser_state".
6821 (parser_state): New class.
6822 * parse.c (expr_builder): Rename.
6823 (expr_builder::release): Rename.
6824 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6825 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6826 (write_exp_elt_longcst, write_exp_elt_floatcst)
6827 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6828 (write_exp_string_vector, write_exp_bitstring)
6829 (write_exp_msymbol, mark_struct_expression)
6830 (write_dollar_variable)
6831 (insert_type_address_space, increase_expout_size): Replace
6832 "parser_state" with "expr_builder".
6833 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6834 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6835 "parser_state" with "expr_builder".
6837 2019-04-04 Tom Tromey <tom@tromey.com>
6839 * rust-exp.y: Replace "parse_language" with method call.
6841 (yylex): Replace "parse_language" with method call.
6843 (yylex): Replace "parse_language" with method call.
6844 * go-exp.y (classify_name): Replace "parse_language" with method
6846 * f-exp.y (yylex): Replace "parse_language" with method call.
6847 * d-exp.y (lex_one_token): Replace "parse_language" with method
6850 (lex_one_token, classify_name, yylex): Replace "parse_language"
6852 * ada-exp.y (find_primitive_type, type_char)
6853 (type_system_address): Replace "parse_language" with method call.
6855 2019-04-04 Tom Tromey <tom@tromey.com>
6857 * rust-exp.y: Replace "parse_gdbarch" with method call.
6858 * parse.c (write_dollar_variable, insert_type_address_space):
6859 Replace "parse_gdbarch" with method call.
6860 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6862 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6864 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6865 "parse_gdbarch" with method call.
6866 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6868 * f-exp.y (parse_type, parse_f_type, yylex): Replace
6869 "parse_gdbarch" with method call.
6870 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6871 "parse_gdbarch" with method call.
6872 * c-exp.y (parse_type, parse_number, classify_name): Replace
6873 "parse_gdbarch" with method call.
6874 * ada-lex.l: Replace "parse_gdbarch" with method call.
6875 * ada-exp.y (parse_type, find_primitive_type, type_char)
6876 (type_system_address): Replace "parse_gdbarch" with method call.
6878 2019-04-04 Tom Tromey <tom@tromey.com>
6880 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6881 * stap-probe.c (stap_parse_argument): Update.
6882 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6883 initial_size parameter.
6884 * rust-exp.y (rust_lex_tests): Update.
6885 * parse.c (parser_state): Update.
6886 (parse_exp_in_context): Update.
6887 * parser-defs.h (struct parser_state) <parser_state>: Remove
6888 "initial_size" parameter.
6890 2019-04-04 Tom Tromey <tom@tromey.com>
6892 * parser-defs.h (increase_expout_size): Don't declare.
6893 * parse.c (increase_expout_size): Now static.
6895 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
6897 * gnu-nat.c (gnu_nat_target::wait): Fix
6898 target_waitstatus_to_string call.
6900 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6902 * eval.c (evaluate_subexp_standard): Handle internal functions
6903 during Fortran function call handling.
6905 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6907 * NEWS: Mention new internal functions.
6908 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6909 (read_base_type): Use dwarf2_init_complex_target_type.
6910 * value.c (creal_internal_fn): New function.
6911 (cimag_internal_fn): New function.
6912 (_initialize_values): Register new internal functions.
6914 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6916 * infrun.c (stop_all_threads): If debug_infrun, always
6917 trace the wait status after wait_one, using
6918 target_waitstatus_to_string and target_pid_to_str.
6919 (handle_inferior_event): Replace various trace of
6920 wait status kind by a single trace.
6921 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6922 wait status kind image by target_waitstatus_to_string.
6923 * target/waitstatus.c (target_waitstatus_to_string): Fix
6926 2019-04-01 Tom Tromey <tromey@adacore.com>
6929 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6931 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
6932 Pedro Alves <palves@redhat.com>
6934 * top.c (quit_force): Call 'finalize_values'.
6935 * value.c (finalize_values): New function.
6936 * value.h (finalize_values): Declare.
6938 2019-03-30 Eli Zaretskii <eliz@gnu.org>
6940 * NEWS: Announce $_gdb_major and $_gdb_minor.
6942 * top.c (init_gdb_version_vars): New function.
6943 (gdb_init): Call init_gdb_version_vars.
6945 2019-03-29 Tom Tromey <tromey@adacore.com>
6947 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
6948 help text. Remove dead code.
6950 2019-03-29 Keith Seitz <keiths@redhat.com>
6952 From Siddhesh Poyarekar:
6953 * f-lang.h (f77_get_upperbound): Return LONGEST.
6954 (f77_get_lowerbound): Likewise.
6955 * f-typeprint.c (f_type_print_varspec_suffix): Expand
6956 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
6958 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
6959 plongest to format print it.
6960 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6961 (f77_get_upperbound): Likewise.
6962 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6963 LOWER_BOUND to LONGEST.
6964 (f77_create_arrayprint_offset_tbl): Likewise.
6966 2019-03-29 Keith Seitz <keiths@redhat.com>
6968 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6969 %s/pulongest for TYPE_LENGTH instead of %d in format
6971 * ada-typerint.c (ada_print_type): Likewise.
6972 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6973 * compile/compile-c-support.c (generate_register_struct): Likewise.
6974 * gdbtypes.c (recursive_dump_type): Likewise.
6975 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6976 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
6977 instead of %d in format strings.
6978 * riscv-tdep.c (riscv_type_alignment): Cast second argument
6979 to std::min to ULONGEST.
6980 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6981 instead of %d in format strings.
6982 * tracepoint.c (info_scope_command): Likewise.
6983 * typeprint.c (print_offset_data::update)
6984 (print_offset_data::finish): Likewise.
6985 * xtensa-tdep.c (xtensa_store_return_value)
6986 (xtensa_push_dummy_call): Likewise.
6988 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
6990 * windows-nat.c (display_selector): Fixed format specifications
6993 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6995 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6997 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
6999 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7000 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7001 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7002 (nios2_linux_init_abi): Install it.
7004 2019-03-28 Alan Hayward <alan.hayward@arm.com>
7006 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7008 2019-03-28 Alan Hayward <alan.hayward@arm.com>
7010 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7012 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7013 Tom Tromey <tromey@adacore.com>
7015 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7017 2019-03-26 Joel Brobecker <brobecker@adacore.com>
7019 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7020 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7021 method to compute the bounds of range types. Also print "[evaluated]"
7022 if the bounds' values come from a dynamic evaluation.
7024 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7026 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7027 whitespace when pretty printing is on.
7029 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7031 * ppc-linux-nat.c: Add include.
7033 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7035 * NEWS: Mention AArch64 Pointer Authentication.
7037 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7039 * arm-linux-nat.c: Add include.
7041 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7043 * source-cache.c (source_cache::get_source_lines): Re-read
7044 fullname after calling open_source_file.
7046 2019-03-25 John Baldwin <jhb@FreeBSD.org>
7048 * NEWS: Mention TLS support for FreeBSD.
7050 2019-03-25 Tom Tromey <tromey@adacore.com>
7052 * minsyms.c (BUNCH_SIZE): Update comment.
7053 (~minimal_symbol_reader): Remove old comment.
7054 (compact_minimal_symbols): Update comment.
7055 (minimal_symbol_reader::install): Remove old comment. Update
7058 2019-03-25 Alan Hayward <alan.hayward@arm.com>
7060 * s390-linux-nat.c: Add include.
7062 2019-03-25 Alan Hayward <alan.hayward@arm.com>
7064 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7065 Call linux_get_hwcap.
7066 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7068 (aarch64_linux_get_hwcap): Remove function.
7069 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7071 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7073 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7074 * linux-tdep.c (linux_get_hwcap): Add function.
7075 (linux_get_hwcap2): Likewise.
7076 * linux-tdep.h (linux_get_hwcap): Add declaration.
7077 (linux_get_hwcap2): Likewise.
7078 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7079 (ppc_linux_get_hwcap2): Likewise.
7080 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7082 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7083 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7084 (ppc_linux_nat_target::read_description): Likewise.
7085 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7086 * s390-linux-nat.c: Likewise.
7087 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7089 2019-03-24 Tom Tromey <tom@tromey.com>
7091 * ada-lang.c (standard_lookup): Simplify initialization.
7092 (ada_lookup_symbol_nonlocal): Simplify return.
7093 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7094 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7095 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7096 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7098 * solib.c (solib_global_lookup): Simplify.
7099 * symtab.c (null_block_symbol): Remove.
7100 (symbol_cache_lookup): Simplify returns.
7101 (lookup_language_this): Simplify returns.
7102 (lookup_symbol_aux): Simplify return.
7103 (lookup_local_symbol): Simplify returns.
7104 (lookup_global_symbol_from_objfile): Simplify return.
7105 (lookup_symbol_in_objfile_symtabs)
7106 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7107 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7108 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7109 * cp-namespace.c (cp_lookup_bare_symbol)
7110 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7111 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7112 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7113 (cp_lookup_symbol_via_imports): Simplify initialization.
7114 (find_symbol_in_baseclass): Likewise.
7115 * symtab.h (null_block_symbol): Remove.
7116 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7117 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7118 (d_lookup_symbol_module): Likewise.
7119 (find_symbol_in_baseclass): Simplify initialization.
7121 2019-03-24 Tom Tromey <tom@tromey.com>
7123 * expression.h: Don't include symtab.h.
7124 (struct block): Forward declare.
7126 2019-03-24 Tom Tromey <tom@tromey.com>
7128 * c-exp.y (typebase): Remove casts.
7129 * gdbtypes.c (lookup_unsigned_typename, )
7130 (lookup_signed_typename): Remove cast.
7131 * eval.c (parse_to_comma_and_eval): Remove cast.
7132 * parse.c (write_dollar_variable): Remove cast.
7133 * block.h (struct block) <superblock>: Now const.
7134 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7135 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7136 (map_block): Make "block" const.
7137 * symfile.h (struct quick_symbol_functions)
7138 <map_matching_symbols>: Constify block argument to "callback".
7139 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7141 (find_pc_sect_compunit_symtab): Make "b" const.
7142 (find_symbol_at_address): Likewise.
7143 (search_symbols): Likewise.
7144 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7145 (dw2_debug_names_lookup_symbol): Likewise.
7146 (dw2_map_matching_symbols): Update.
7147 * p-valprint.c (pascal_val_print): Remove "block".
7148 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7149 (aux_add_nonlocal_symbols): Make "block" const.
7150 (resolve_subexp): Remove cast.
7151 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7153 (iterate_over_file_blocks): Likewise.
7154 * f-exp.y (%union) <bval>: Remove.
7155 * coffread.c (patch_opaque_types): Make "b" const.
7156 * spu-tdep.c (spu_catch_start): Make "block" const.
7157 * c-valprint.c (print_unpacked_pointer): Remove "block".
7158 * symmisc.c (dump_symtab_1): Make "b" const.
7159 (block_depth): Make "block" const.
7160 * d-exp.y (%union) <bval>: Remove.
7161 * cp-support.h (cp_lookup_rtti_type): Update.
7162 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7163 * psymtab.c (psym_lookup_symbol): Make "block" const.
7164 (maintenance_check_psymtabs): Make "b" const.
7165 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7166 (enumerate_locals, enumerate_args): Update.
7167 * python/py-symtab.c (stpy_global_block): Make "block" const.
7168 (stpy_static_block): Likewise.
7169 * inline-frame.c (block_starting_point_at): Make "new_block"
7171 * block.c (find_block_in_blockvector): Make return type const.
7172 (blockvector_for_pc_sect): Make "b" const.
7173 (find_block_in_blockvector): Make "b" const.
7175 2019-03-23 Tom Tromey <tom@tromey.com>
7177 * varobj.c (varobj_create): Update.
7178 * symfile.c (clear_symtab_users): Don't reset innermost_block.
7179 * printcmd.c (display_command, do_one_display): Don't reset
7181 * parser-defs.h (enum innermost_block_tracker_type): Move to
7183 (innermost_block): Update comment.
7184 * parse.c (parse_exp_1): Add tracker_types parameter.
7185 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
7186 tracker_types parameter. Reset innermost_block.
7187 (parse_exp_in_context): Remove.
7188 (parse_expression_for_completion): Update.
7189 * objfiles.c (~objfile): Don't reset expression_context_block or
7191 * expression.h (enum innermost_block_tracker_type): Move from
7193 (parse_exp_1): Add tracker_types parameter.
7194 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7195 reset innermost_block.
7197 2019-03-23 Tom Tromey <tom@tromey.com>
7199 * objfiles.h: Include bcache.h.
7201 2019-03-23 Tom Tromey <tom@tromey.com>
7203 * linespec.c (get_current_search_block): Use
7204 scoped_restore_current_language.
7205 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7207 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7208 Jiong Wang <jiong.wang@arm.com>
7210 * aarch64-linux-tdep.c
7211 (aarch64_linux_iterate_over_regset_sections): Check for pauth
7213 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7215 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7216 Jiong Wang <jiong.wang@arm.com>
7218 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7220 (aarch64_analyze_prologue_test): Add PACIASP test.
7221 (aarch64_prologue_prev_register): Unmask PC value.
7223 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7224 Jiong Wang <jiong.wang@arm.com>
7226 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7227 (aarch64_dwarf2_prev_register): Unmask PC value.
7228 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7229 (aarch64_execute_dwarf_cfa_vendor_op): Check for
7230 DW_CFA_AARCH64_negate_ra_state.
7231 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7233 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7234 Jiong Wang <jiong.wang@arm.com>
7236 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7238 (aarch64_pseudo_register_name): Likewise.
7239 (aarch64_pseudo_register_type): Likewise.
7240 (aarch64_pseudo_register_reggroup_p): Likewise.
7241 (aarch64_gdbarch_init): Add pauth registers.
7242 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7243 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7244 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7245 (struct gdbarch_tdep): Add regnum for ra_state.
7247 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7248 Jiong Wang <jiong.wang@arm.com>
7250 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7252 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7253 Jiong Wang <jiong.wang@arm.com>
7255 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7257 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7258 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7259 (aarch64_gdbarch_init): Add puth registers.
7260 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7261 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7262 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7264 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7265 Jiong Wang <jiong.wang@arm.com>
7267 * aarch64-linux-nat.c
7268 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7269 * aarch64-linux-tdep.c
7270 (aarch64_linux_core_read_description): Likewise.
7271 (aarch64_linux_get_hwcap): New function.
7272 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7273 (aarch64_linux_get_hwcap): New declaration.
7275 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7276 Jiong Wang <jiong.wang@arm.com>
7278 * aarch64-linux-nat.c
7279 (aarch64_linux_nat_target::read_description): Add pauth param.
7280 * aarch64-linux-tdep.c
7281 (aarch64_linux_core_read_description): Likewise.
7282 * aarch64-tdep.c (struct target_desc): Add in pauth.
7283 (aarch64_read_description): Add pauth param.
7284 (aarch64_gdbarch_init): Likewise.
7285 * aarch64-tdep.h (aarch64_read_description): Likewise.
7286 * arch/aarch64.c (aarch64_create_target_description): Likewise.
7287 * arch/aarch64.h (aarch64_create_target_description): Likewise.
7288 * features/Makefile: Add new files.
7289 * features/aarch64-pauth.c: New file.
7290 * features/aarch64-pauth.xml: New file.
7292 2019-03-20 Tom Tromey <tromey@adacore.com>
7294 * infrun.c (handle_inferior_event): Rename from
7295 handle_inferior_event_1. Create a scoped_value_mark.
7296 (handle_inferior_event): Remove.
7298 2019-03-19 Tom Tromey <tromey@adacore.com>
7300 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7301 * infrun.h (print_stop_event): Add "displays" parameter.
7302 * infrun.c (print_stop_event): Add "displays" parameter.
7304 2019-03-19 Pedro Alves <palves@redhat.com>
7306 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7307 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
7308 to -1. Fix TABs vs spaces.
7309 (tui_ui_out::tui_ui_out): Don't initialize fields here.
7310 * tui/tui-out.h (tui_ui_out) Add intro comments.
7311 <m_line, m_start_of_line>: In-class initialize, and add describing
7314 2019-03-18 Alan Hayward <alan.hayward@arm.com>
7316 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7318 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7320 2019-03-18 Pedro Alves <palves@redhat.com>
7321 Eli Zaretskii <eliz@gnu.org>
7323 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7324 m_line and m_start_of_line.
7326 2019-03-18 Eli Zaretskii <eliz@gnu.org>
7328 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7329 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7330 it returns a newline. This fixes a regression in TU mode, whereby
7331 the next line is output on the same screen line as the user input.
7333 2019-03-18 Tom Tromey <tromey@adacore.com>
7335 * minsyms.c (minimal_symbol_reader::install): Remove call to
7338 2019-03-18 Pedro Alves <palves@redhat.com>
7340 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7342 (apply_style): New, factored out from ...
7343 (apply_ansi_escape): ... this. Handle reverse video mode.
7344 (tui_set_reverse_mode): New function.
7345 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7346 * tui/tui-winsource.c (tui_show_source_line): Use
7347 tui_set_reverse_mode instead of setting A_STANDOUT.
7348 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7351 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
7353 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7356 2019-03-18 Tom Tromey <tromey@adacore.com>
7358 * ada-lang.c (empty_array): Add "high" parameter.
7359 (ada_evaluate_subexp): Update.
7361 2019-03-17 Sergei Trofimovich <siarheit@google.com>
7363 * unittests/string_view-selftests.c: Define
7364 _initialize_string_view_selftests unconditionally.
7366 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7369 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7371 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7374 * windows-nat.c (display_selector): Fix format specifiers.
7376 2019-03-17 Eli Zaretskii <eliz@gnu.org>
7378 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7379 tui_refill_source_window instead of tui_refresh_win, to update the
7380 current execution line. This fixes redisplay of the current line
7381 when stepping through the code with "next" or "step".
7383 2019-03-16 Eli Zaretskii <eliz@gnu.org>
7385 * source-cache.c (source_cache::get_source_lines): Call
7386 find_source_lines to initialize s->nlines. This fixes vertical
7387 scrolling of TUI source window when the DOWN arrow is pressed.
7389 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7391 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7392 linux-thread-db.c (_initialize_thread_db): Likewise.
7394 2019-03-16 Eli Zaretskii <eliz@gnu.org>
7396 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7397 wclrtoeol in tui_show_source_line". This reverts changes made in
7398 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7400 2019-03-15 Tom Tromey <tom@tromey.com>
7402 * symtab.h (struct minimal_symbol): Derive from
7403 general_symbol_info.
7404 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7405 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7406 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7407 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7408 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7409 (MSYMBOL_SEARCH_NAME): Update.
7410 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7411 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7412 * minsyms.c (minimal_symbol_reader::record_full): Update.
7414 2019-03-15 Tom Tromey <tom@tromey.com>
7416 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7418 2019-03-15 Tom Tromey <tom@tromey.com>
7420 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7422 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7424 * minsyms.c (lookup_minimal_symbol_by_pc_section)
7425 (build_minimal_symbol_hash_tables)
7426 (minimal_symbol_reader::install): Update.
7428 2019-03-15 Tom Tromey <tom@tromey.com>
7430 * symtab.c (create_demangled_names_hash): Update.
7431 (symbol_set_names): Update.
7432 * objfiles.h (struct objfile_per_bfd_storage)
7433 <demangled_names_hash>: Now an htab_up.
7434 * objfiles.c (objfile_per_bfd_storage): Simplify.
7436 2019-03-15 Tom Tromey <tom@tromey.com>
7438 * objfiles.h (struct objfile_per_bfd_storage): Declare
7440 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7442 (get_objfile_bfd_data): Use new. Don't initialize
7444 (free_objfile_per_bfd_storage): Remove.
7445 (objfile_bfd_data_free, objfile::~objfile): Use delete.
7447 2019-03-15 Tom Tromey <tom@tromey.com>
7449 * symfile.c (reread_symbols): Update.
7450 * objfiles.c (objfile::objfile): Update.
7451 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7452 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7454 (minimal_symbol_reader::install): Update.
7455 (terminate_minimal_symbol_table): Remove.
7456 * jit.c (jit_object_close_impl): Update.
7458 2019-03-15 Tom Tromey <tom@tromey.com>
7460 * minsyms.c (minimal_symbol_reader::record_full): Remove some
7463 2019-03-15 Tom Tromey <tom@tromey.com>
7465 * objfiles.h (struct objfile_per_bfd_storage)
7466 <demangled_hash_languages>: Now a bitset.
7467 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7468 (lookup_minimal_symbol): Update.
7470 2019-03-15 Tom Tromey <tom@tromey.com>
7472 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7473 Don't return the symbol.
7474 * coffread.c (record_minimal_symbol): Use record_full.
7476 2019-03-14 Eli Zaretskii <eliz@gnu.org>
7478 The MS-Windows port of ncurses fails to switch to a color pair if
7479 one or both of the colors are the implicit default colors. This
7480 change records the default colors when TUI is initialized, and
7481 then specifies them explicitly when a color pair uses the default
7482 colors. This allows color styling in TUI mode on MS-Windows.
7484 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
7486 (tui_initialize_io) [__MINGW32__]: Record the default terminal
7487 colors in ncurses_norm_attr.
7488 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7489 "none", replace it with the default color recorded in
7492 2019-03-14 Tom Tromey <tromey@adacore.com>
7494 * source-cache.h (class source_cache) <get_source_lines>: Return
7496 * source-cache.c (source_cache::extract_lines): Handle case where
7497 first_pos==npos. Return std::string.
7498 (source_cache::get_source_lines): Update.
7500 2019-03-14 Tom Tromey <tromey@adacore.com>
7502 * NEWS: Add item for "style sources" commands.
7503 * source-cache.c (source_cache::get_source_lines): Check
7505 * cli/cli-style.c (source_styling): New global.
7506 (_initialize_cli_style): Add "style sources" commands.
7507 (show_style_sources): New function.
7508 * cli/cli-style.h (source_styling): Declare.
7510 2019-03-14 Pedro Alves <palves@redhat.com>
7511 Tom Tromey <tromey@adacore.com>
7513 * tui/tui-winsource.h (tui_refill_source_window): Declare.
7514 * tui/tui-winsource.c (tui_refill_source_window): New function,
7516 (tui_horizontal_source_scroll): ... here. Move some logic.
7517 * cli/cli-style.c (set_style_enabled): Notify new observable.
7518 * tui/tui-hooks.c (tui_redisplay_source): New function.
7519 (tui_attach_detach_observers): Attach or detach
7520 tui_redisplay_source.
7521 * observable.h (source_styling_changed): New observable.
7522 * observable.c: Define source_styling_changed observable.
7524 2019-03-13 Tom Tromey <tromey@adacore.com>
7526 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7527 (i386_gnu_nat_target::store_registers): Update.
7528 * target-debug.h (target_debug_print_std_string): New macro.
7529 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7530 * windows-tdep.c (display_one_tib): Update.
7531 * tui/tui-stack.c (tui_make_status_line): Update.
7532 * top.c (print_inferior_quit_action): Update.
7533 * thread.c (thr_try_catch_cmd): Update.
7534 (add_thread_with_info): Update.
7535 (thread_target_id_str): Update.
7536 (thr_try_catch_cmd): Update.
7537 (thread_command): Update.
7538 (thread_find_command): Update.
7539 * record-btrace.c (record_btrace_target::info_record)
7540 (record_btrace_resume_thread, record_btrace_target::resume)
7541 (record_btrace_cancel_resume, record_btrace_step_thread)
7542 (record_btrace_target::wait, record_btrace_target::wait)
7543 (record_btrace_target::wait, record_btrace_target::stop): Update.
7544 * progspace.c (print_program_space): Update.
7545 * process-stratum-target.c
7546 (process_stratum_target::thread_address_space): Update.
7547 * linux-fork.c (linux_fork_mourn_inferior)
7548 (detach_checkpoint_command, info_checkpoints_command)
7549 (linux_fork_context): Update.
7550 (linux_fork_detach): Update.
7551 (class scoped_switch_fork_info): Update.
7552 (delete_checkpoint_command): Update.
7553 * infrun.c (follow_fork_inferior): Update.
7554 (follow_fork_inferior): Update.
7555 (proceed_after_vfork_done): Update.
7556 (handle_vfork_child_exec_or_exit): Update.
7557 (follow_exec): Update.
7558 (displaced_step_prepare_throw): Update.
7559 (displaced_step_restore): Update.
7560 (start_step_over): Update.
7562 (clear_proceed_status_thread): Update.
7564 (print_target_wait_results): Update.
7565 (do_target_wait): Update.
7566 (context_switch): Update.
7567 (stop_all_threads): Update.
7568 (restart_threads): Update.
7569 (finish_step_over): Update.
7570 (handle_signal_stop): Update.
7571 (switch_back_to_stepped_thread): Update.
7572 (keep_going_pass_signal): Update.
7573 (print_exited_reason): Update.
7574 (normal_stop): Update.
7575 * inferior.c (inferior_pid_to_str): Change return type.
7576 (print_selected_inferior): Update.
7577 (add_inferior): Update.
7578 (detach_inferior): Update.
7579 * dummy-frame.c (fprint_dummy_frames): Update.
7580 * dcache.c (dcache_info_1): Update.
7581 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7582 (btrace_fetch, btrace_clear): Update.
7583 * linux-tdep.c (linux_core_pid_to_str): Change return type.
7584 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7586 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7587 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7588 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7589 * gdbarch.c, gdbarch.h: Rebuild.
7590 * gdbarch.sh (core_pid_to_str): Change return type.
7591 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7593 (windows_nat_target::pid_to_str): Change return type.
7594 (windows_delete_thread): Update.
7595 (windows_nat_target::attach): Update.
7596 (windows_nat_target::files_info): Update.
7597 * target-delegates.c: Rebuild.
7598 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7600 (sol_thread_target::pid_to_str): Change return type.
7601 * remote.c (class remote_target) <pid_to_str>: Change return
7603 (remote_target::pid_to_str): Change return type.
7604 (extended_remote_target::attach, remote_target::remote_stop_ns)
7605 (remote_target::remote_notif_remove_queued_reply)
7606 (remote_target::push_stop_reply, remote_target::disable_btrace):
7608 (extended_remote_target::attach): Update.
7609 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7611 (gdbsim_target::pid_to_str): Change return type.
7612 * ravenscar-thread.c (struct ravenscar_thread_target)
7613 <pid_to_str>: Change return type.
7614 (ravenscar_thread_target::pid_to_str): Change return type.
7615 * procfs.c (class procfs_target) <pid_to_str>: Change return
7617 (procfs_target::pid_to_str): Change return type.
7618 (procfs_target::attach): Update.
7619 (procfs_target::detach): Update.
7620 (procfs_target::fetch_registers): Update.
7621 (procfs_target::store_registers): Update.
7622 (procfs_target::wait): Update.
7623 (procfs_target::files_info): Update.
7624 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7625 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7627 (nto_procfs_target::pid_to_str): Change return type.
7628 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7629 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7631 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7633 (attach_proc_task_lwp_callback, get_detach_signal)
7634 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7635 (linux_nat_target::resume, wait_lwp, stop_callback)
7636 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7637 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7638 (linux_nat_wait_1, resume_stopped_resumed_lwps)
7639 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7640 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7642 (inf_ptrace_target::attach): Update.
7643 (inf_ptrace_target::files_info): Update.
7644 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7646 (go32_nat_target::pid_to_str): Change return type.
7647 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7648 (gnu_nat_target::wait): Update.
7649 (gnu_nat_target::wait): Update.
7650 (gnu_nat_target::resume): Update.
7651 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7652 (fbsd_nat_target::wait): Update.
7653 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7655 (darwin_nat_target::attach): Update.
7656 * corelow.c (class core_target) <pid_to_str>: Change return type.
7657 (core_target::pid_to_str): Change return type.
7658 * target.c (normal_pid_to_str): Change return type.
7659 (default_pid_to_str): Likewise.
7660 (target_pid_to_str): Change return type.
7661 (target_translate_tls_address): Update.
7662 (target_announce_detach): Update.
7663 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7665 (bsd_uthread_target::pid_to_str): Change return type.
7666 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7668 (bsd_kvm_target::pid_to_str): Change return type.
7669 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7671 (aix_thread_target::pid_to_str): Change return type.
7672 * target.h (struct target_ops) <pid_to_str>: Change return type.
7673 (target_pid_to_str, normal_pid_to_str): Likewise.
7674 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7676 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7678 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7680 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7682 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7684 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7687 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
7689 * NEWS: Mention that the new default MI version is 3. Mention
7690 changes to the output of commands and events that deal with
7691 multi-location breakpoints.
7692 * breakpoint.c: Include "mi/mi-out.h".
7693 (print_one_breakpoint): Change output syntax if using MI version
7695 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7697 (mi_multi_location_breakpoint_output_fixed): New.
7698 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7699 (mi_cmd_fix_multi_location_breakpoint_output): New.
7700 (mi_multi_location_breakpoint_output_fixed): New.
7701 * mi/mi-cmds.c (mi_cmds): Register command
7702 -fix-multi-location-breakpoint-output.
7703 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7706 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
7708 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7709 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7710 instantiate mi_ui_out based on interpreter name.
7711 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7712 * mi/mi-main.c (mi_load_progress): Likewise.
7714 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7716 * NEWS: Combine separate "New targets" sections for 8.3.
7718 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7720 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7721 (ppcfbsd_init_abi): Install gdbarch
7722 "fetch_tls_load_module_address" and "get_thread_local_address"
7725 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7727 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7728 (riscv_fbsd_init_abi): Install gdbarch
7729 "fetch_tls_load_module_address" and "get_thread_local_address"
7732 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7734 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7735 (i386fbsd_init_abi): Install gdbarch
7736 "fetch_tls_load_module_address" and "get_thread_local_address"
7739 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7741 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7742 (amd64fbsd_init_abi): Install gdbarch
7743 "fetch_tls_load_module_address" and "get_thread_local_address"
7746 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7748 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7749 (struct fbsd_pspace_data): New type.
7750 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7751 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7752 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7753 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7754 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7756 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7758 * gdbtypes.c (lookup_struct_elt): New function.
7759 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7760 * gdbtypes.h (struct struct_elt): New type.
7761 (lookup_struct_elt): New prototype.
7763 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7765 * gdbtypes.c (lookup_struct_elt_type): Update comment and
7766 remove disabled code block.
7768 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7770 * gdbarch.sh (get_thread_local_address): New method.
7771 * gdbarch.h, gdbarch.c: Regenerate.
7772 * target.c (target_translate_tls_address): Use
7773 gdbarch_get_thread_local_address if present instead of
7774 target::get_thread_local_address.
7776 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7778 * target.h (target::get_thread_local_address): Update comment.
7780 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7782 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7783 objfile->separate_debug_objfile_backlink if not NULL.
7785 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7787 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7788 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7789 (amd64bsd_store_inferior_registers): Likewise.
7790 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7791 Enable segment base registers.
7792 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7793 PT_GETFSBASE and PT_GETGSBASE.
7794 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7796 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7797 segment base registers.
7798 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7800 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7802 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7803 Update calls to i386_target_description to add 'segments'
7805 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
7806 add segment base registers.
7807 * arch/i386.c (i386_create_target_description): Add 'segments'
7808 parameter to enable segment base registers.
7809 * arch/i386.h (i386_create_target_description): Likewise.
7810 * features/i386/32bit-segments.xml: New file.
7811 * features/i386/32bit-segments.c: Generate.
7812 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7813 call to i386_target_description to add 'segments' parameter.
7814 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7815 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7816 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7817 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7818 if feature is present.
7819 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7820 Add 'segments' parameter to call to i386_target_description.
7821 (i386_target_description): Add 'segments' parameter to enable
7822 segment base registers.
7823 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7824 to call to i386_target_description.
7825 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7826 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7827 Define I386_NUM_REGS.
7828 (i386_target_description): Add 'segments' parameter to enable
7829 segment base registers.
7831 2019-03-12 Eli Zaretskii <eliz@gnu.org>
7834 * source-cache.c: #undef open and close, to avoid unresolved
7835 externals during linking.
7837 2019-03-12 Tom Tromey <tromey@adacore.com>
7839 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7840 const. Add initializers.
7841 (_initialize_remote): Don't initialize ptid globals.
7843 2019-03-12 Pedro Alves <palves@redhat.com>
7845 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7847 2019-03-12 Pedro Alves <palves@redhat.com>
7849 * cp-name-parser.y (main): Remove unused 'len' variable.
7851 2019-03-12 Tom Tromey <tromey@adacore.com>
7853 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7854 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7856 2019-03-12 Tom Tromey <tromey@adacore.com>
7858 * linux-nat.c (iterate_over_lwps): Update.
7859 (stop_callback): Remove parameter.
7860 (stop_wait_callback, detach_callback, resume_set_callback)
7861 (select_singlestep_lwp_callback, set_ignore_sigint)
7862 (status_callback, resumed_callback, resume_clear_callback)
7863 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7865 (linux_nat_target::detach, linux_nat_target::resume)
7866 (linux_stop_and_wait_all_lwps, select_event_lwp)
7867 (linux_nat_filter_event, linux_nat_wait_1)
7868 (linux_nat_target::kill, linux_nat_target::stop)
7869 (linux_nat_target::stop): Update.
7870 (linux_nat_resume_callback): Change type.
7871 (resume_stopped_resumed_lwps, count_events_callback)
7872 (select_event_lwp_callback): Likewise.
7873 (linux_stop_lwp, linux_nat_stop_lwp): Update.
7874 * arm-linux-nat.c (struct update_registers_data): Remove.
7875 (update_registers_callback): Change type.
7876 (arm_linux_insert_hw_breakpoint1): Update.
7877 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7879 (x86_linux_dr_set_addr): Update.
7880 (x86_linux_dr_set_control): Update.
7881 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7882 (iterate_over_lwps): Use gdb::function_view.
7883 * nat/aarch64-linux-hw-point.c (struct
7884 aarch64_dr_update_callback_param): Remove.
7885 (debug_reg_change_callback): Change type.
7886 (aarch64_notify_debug_reg_change): Update.
7887 * s390-linux-nat.c (s390_refresh_per_info): Update.
7889 2019-03-11 Tom Tromey <tromey@adacore.com>
7891 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7892 redundant assignment to "this_cu".
7894 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7896 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7898 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7900 * gdbtypes.c (rank_one_type_parm_set): New function extracted
7902 (rank_one_type): ... this.
7904 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7906 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7908 (rank_one_type): ... this.
7910 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7912 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7914 (rank_one_type): ... this.
7916 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7918 * gdbtypes.c (rank_one_type_parm_float): New function extracted
7920 (rank_one_type): ... this.
7922 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7924 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7926 (rank_one_type): ... this.
7928 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7930 * gdbtypes.c (rank_one_type_parm_range): New function extracted
7932 (rank_one_type): ... this.
7934 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7936 * gdbtypes.c (rank_one_type_parm_char): New function extracted
7938 (rank_one_type): ... this.
7940 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7942 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7944 (rank_one_type): ... this.
7946 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7948 * gdbtypes.c (rank_one_type_parm_int): New function extracted
7950 (rank_one_type): ... this.
7952 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7954 * gdbtypes.c (rank_one_type_parm_func): New function extracted
7956 (rank_one_type): ... this.
7958 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7960 * gdbtypes.c (rank_one_type_parm_array): New function extracted
7962 (rank_one_type): ... this.
7964 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7966 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7968 (rank_one_type): ... this.
7970 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7972 * inferior.c (initialize_inferiors): Ensure 'help set/show print
7973 inferior-events' shows the example events.
7975 2019-03-08 Eli Zaretskii <eliz@gnu.org>
7977 Support styling on native MS-Windows console
7980 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7981 on MS-Windows if $TERM is not defined.
7983 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7985 * posix-hdep.c (gdb_console_fputs):
7986 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7988 * ui-file.h (gdb_console_fputs): Add prototype.
7990 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7991 back to fputs only if the former returns zero.
7993 2019-03-07 Tom Tromey <tom@tromey.com>
7995 * symmisc.c (print_symbol_bcache_statistics): Update.
7996 (print_objfile_statistics): Update.
7997 * symfile.c (allocate_symtab): Update.
7998 * stabsread.c: Don't include bcache.h.
7999 * psymtab.h (struct psymbol_bcache): Don't declare.
8000 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8001 (psymbol_bcache_init, psymbol_bcache_free)
8002 (psymbol_bcache_get_bcache): Don't declare.
8003 * psymtab.c (struct psymbol_bcache): Remove.
8004 (psymtab_storage::psymtab_storage): Update.
8005 (psymtab_storage::~psymtab_storage): Update.
8006 (psymbol_bcache_init, psymbol_bcache_free)
8007 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8008 (add_psymbol_to_bcache): Update.
8009 (allocate_psymtab): Update.
8010 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8011 macro_cache>: No longer pointers.
8012 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8013 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8014 * macrotab.c (macro_bcache): Update.
8015 * macroexp.c: Don't include bcache.h.
8016 * gdbtypes.c (check_types_worklist): Update.
8017 (types_deeply_equal): Remove TRY/CATCH. Update.
8018 * elfread.c (elf_symtab_read): Update.
8019 * dwarf2read.c: Don't include bcache.h.
8020 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8021 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8022 (print_bcache_statistics, bcache_memory_used): Don't declare.
8023 (struct bcache): Move from bcache.c. Add constructor, destructor,
8024 methods. Rename all data members.
8025 * bcache.c (struct bcache): Move to bcache.h.
8026 (bcache::expand_hash_table): Rename from expand_hash_table.
8028 (bcache::insert): Rename from bcache_full.
8029 (bcache::compare): Rename from bcache_compare.
8030 (bcache_xmalloc): Remove.
8031 (bcache::~bcache): Rename from bcache_xfree.
8032 (bcache::print_statistics): Rename from print_bcache_statistics.
8033 (bcache::memory_used): Rename from bcache_memory_used.
8035 2019-03-07 Pedro Alves <palves@redhat.com>
8037 * infrun.c (normal_stop): Also check for
8038 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8040 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8042 * f-lang.c (value_from_host_double): Moved to...
8043 * value.c (value_from_host_double): ...here.
8044 * value.h (value_from_host_double): Declare.
8045 * guile/scm-math.c (vlscm_convert_typed_number): Use
8046 value_from_host_double.
8047 (vlscm_convert_number): Likewise.
8048 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8049 * python/py-value.c (convert_value_from_python): Likewise.
8051 2019-03-06 Tom Tromey <tom@tromey.com>
8053 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8055 2019-03-06 Tom Tromey <tom@tromey.com>
8057 * utils.h (free_current_contents): Don't declare.
8058 * utils.c (free_current_contents): Remove.
8060 2019-03-06 Tom Tromey <tom@tromey.com>
8062 * top.c (quit_force): Update.
8063 * main.c (captured_command_loop): Update.
8064 * common/new-op.c (operator new): Update.
8065 * common/common-exceptions.c (struct catcher)
8066 <save_cleanup_chain>: Remove member.
8067 (exceptions_state_mc_init): Update.
8068 (exception_try_scope_entry): Return nullptr.
8069 (exception_try_scope_exit, exception_rethrow)
8070 (throw_exception_sjlj, throw_exception_cxx): Update.
8071 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8072 (all_cleanups, do_cleanups, discard_cleanups)
8073 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8074 (restore_cleanups, restore_final_cleanups): Don't declare.
8075 (do_final_cleanups): Remove parameter.
8076 * common/cleanups.c (cleanup_chain, make_cleanup)
8077 (make_cleanup_dtor, all_cleanups, do_cleanups)
8078 (discard_my_cleanups, discard_cleanups)
8079 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8080 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8081 (null_cleanup): Remove.
8082 (do_final_cleanups): Remove parameter.
8084 2019-03-06 Tom Tromey <tom@tromey.com>
8086 * remote.c (remote_target::remote_parse_stop_reply): Use
8089 2019-03-06 Tom Tromey <tom@tromey.com>
8091 * stabsread.c (struct stabs_field_info): Rename from field_info.
8092 <list, fnlist>: Add initializers.
8093 <obstack>: New member.
8094 (read_member_functions, read_struct_fields, read_baseclasses):
8095 Allocate on obstack. Don't use cleanups.
8096 (read_one_struct_field, read_member_functions, read_struct_fields)
8097 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8098 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8099 (read_struct_type): Update.
8101 2019-03-06 Tom Tromey <tom@tromey.com>
8103 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8104 * common/filestuff.h (make_cleanup_close): Don't declare.
8105 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8108 2019-03-06 Tom Tromey <tom@tromey.com>
8110 * solib-aix.c: Use make_scope_exit.
8112 2019-03-06 Tom Tromey <tom@tromey.com>
8114 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8115 Use make_scope_exit.
8117 2019-03-06 Tom Tromey <tom@tromey.com>
8119 * solib-svr4.c (disable_probes_interface): Remove parameter.
8120 (svr4_handle_solib_event): Use make_scope_exit.
8122 2019-03-06 Tom Tromey <tom@tromey.com>
8124 * remote.c (struct stop_reply_deleter): Remove.
8125 (stop_reply_up): Update.
8126 (struct stop_reply): Derive from notif_event. Don't typedef.
8127 <regcache>: Now a std::vector.
8128 (stop_reply_xfree): Remove.
8129 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8130 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8131 (remote_target::discard_pending_stop_replies): Use delete.
8132 (remote_target::remote_parse_stop_reply): Update.
8133 (remote_target::process_stop_reply): Update.
8134 * remote-notif.h (struct notif_event): Add virtual destructor.
8135 Remove "dtr" member.
8136 (struct notif_client) <alloc_event>: Return a unique_ptr.
8137 (notif_event_xfree): Don't declare.
8138 (notif_event_up): New typedef.
8139 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8140 (notif_event_xfree, do_notif_event_xfree): Remove.
8141 (remote_notif_state_xfree): Update.
8143 2019-03-06 Tom Tromey <tom@tromey.com>
8145 * infrun.c (displaced_step_clear_cleanup): Now a
8146 forward_scope_exit type.
8147 (displaced_step_prepare_throw): Update.
8148 (displaced_step_fixup): Update.
8150 2019-03-06 Tom Tromey <tom@tromey.com>
8152 * inferior.h (class inferior): Update comment.
8153 * gdbthread.h (class thread_info): Update comment.
8155 2019-03-06 Joel Brobecker <brobecker@adacore.com>
8156 Tom Tromey <tom@tromey.com>
8158 * stabsread.h (struct stab_section_list): Remove.
8159 (coffstab_build_psymtabs): Update.
8160 * dbxread.c (symbuf_sections): Now a std::vector.
8161 (sect_idx): New global.
8162 (fill_symbuf): Update.
8163 (coffstab_build_psymtabs): Change type of stabsects parameter.
8165 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8167 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8168 (coff_locate_sections): Update.
8169 (coff_symfile_read): Remove cleanups. Update.
8170 (init_stringtab): Add storage parameter.
8171 (free_stringtab, free_stringtab_cleanup): Remove.
8172 (init_lineno): Add storage parameter.
8173 (free_linetab, free_linetab_cleanup): Remove.
8175 2019-03-06 Pedro Alves <palves@redhat.com>
8177 * linux-fork.c (fork_info::clobber_regs): Delete.
8178 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8179 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
8181 (scoped_switch_fork_info::scoped_switch_fork_info)
8182 (checkpoint_command, linux_fork_context): Adjust
8183 fork_save_infrun_state calls.
8185 2019-03-06 Pedro Alves <palves@redhat.com>
8187 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8188 (inf_has_multiple_threads): Return 'bool' and rewrite using
8189 inferior_info::threads().
8191 2019-03-06 Pedro Alves <palves@redhat.com>
8193 * linux-fork.c: Include <list>.
8194 (fork_list): Now a std::list instance.
8195 (fork_info): Add ctor, dtor, and in-class initialize all fields.
8196 (forks_exist_p, find_last_fork): Adjust.
8200 (free_fork): Delete, folded into fork_info::~fork_info().
8201 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8203 (init_fork_list): Delete.
8204 (linux_fork_killall, linux_fork_mourn_inferior)
8205 (linux_fork_detach, info_checkpoints_command): Adjust.
8206 (_initialize_linux_fork): No longer call init_fork_list.
8208 2019-03-06 Pedro Alves <palves@redhat.com>
8210 * linux-fork.c (new_fork): New, split out of ...
8211 (add_fork): ... this. Return void. Move "first fork" special
8212 case from here, to ...
8213 (checkpoint_command): ... here.
8214 * linux-linux.h (add_fork): Return void.
8216 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8218 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8220 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8221 Chris January <chris.january@arm.com>
8222 David Lecomber <david.lecomber@arm.com>
8224 * f-exp.y: New token, UNOP_INTRINSIC.
8225 (exp): New pattern using UNOP_INTRINSIC token.
8226 (f77_keywords): Add 'abs' keyword.
8227 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8228 (value_from_host_double): New function.
8229 (evaluate_subexp_f): Support UNOP_ABS.
8231 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8233 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8236 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8238 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8239 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8240 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8242 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8244 * f-exp.y (convert_to_kind_type): Handle more type kinds.
8246 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8247 Chris January <chris.january@arm.com>
8249 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8250 * f-exp.y: Define 'KIND' token.
8251 (exp): New pattern for KIND expressions.
8252 (ptype): Handle types with a kind extension.
8253 (direct_abs_decl): Extend to spot kind extensions.
8254 (f77_keywords): Add 'kind' to the list.
8255 (push_kind_type): New function.
8256 (convert_to_kind_type): New function.
8257 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8258 * parse.c (operator_length_standard): Likewise.
8259 * parser-defs.h (enum type_pieces): Add tp_kind.
8260 * std-operator.def: Add UNOP_KIND.
8262 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8264 * f-exp.y (f_parse): Set yydebug.
8266 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8268 * f-lang.c (evaluate_subexp_f): New function.
8269 (exp_descriptor_f): New global.
8270 (f_language_defn): Use exp_descriptor_f instead of
8271 exp_descriptor_standard.
8273 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8275 * f-exp.y (struct token): Add comments.
8276 (dot_ops): Remove uppercase versions and the end marker.
8277 (f77_keywords): Likewise.
8278 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8279 entries in the dot_ops array are case insensitive, and use
8280 strncasecmp to compare strings. Also some whitespace cleanup in
8281 this area. Similar for the f77_keywords array, except entries in
8282 this list might be case sensitive.
8284 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8286 * f-exp.y (struct f77_boolean_val): Add comments.
8287 (boolean_values): Remove uppercase versions, and end marker.
8288 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8289 and use strncasecmp to achieve case insensitivity. Additionally,
8290 perform whitespace cleanup around this code.
8292 2019-03-06 Tom Tromey <tromey@adacore.com>
8294 * remote-sim.c (gdbsim_target_open): Use result of
8297 2019-03-06 Richard Bunt <richard.bunt@arm.com>
8298 Dirk Schubert <dirk.schubert@arm.com>
8299 Chris January <chris.january@arm.com>
8301 * eval.c (evaluate_subexp_standard): Call Fortran argument
8303 * f-lang.c (struct value): A value which can be passed into a
8304 Fortran function call.
8305 (fortran_argument_convert): Wrap Fortran arguments in a pointer
8307 (struct type): Value ready for a Fortran function call.
8308 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8310 * f-lang.h (fortran_argument_convert): Declaration.
8311 (fortran_preserve_arg_pointer): Declaration.
8312 * infcall.c (value_arg_coerce): Call Fortran argument logic.
8314 2019-03-05 Tom Tromey <tromey@adacore.com>
8316 * python/py-prettyprint.c (print_string_repr): Remove #if.
8317 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8319 2019-03-05 Tom Tromey <tromey@adacore.com>
8321 * target.c (the_dummy_target): Move later. Change type to
8323 (initialize_targets): Don't initialize the_dummy_target.
8325 2019-03-05 Tom Tromey <tromey@adacore.com>
8327 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8328 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8330 2019-03-05 Tom Tromey <tromey@adacore.com>
8332 * windows-nat.c (windows_nat_target::attach)
8333 (windows_nat_target::detach): Don't call gdb_flush.
8334 * valprint.c (generic_val_print, val_print, val_print_string):
8335 Don't call gdb_flush.
8336 * utils.c (defaulted_query): Don't call gdb_flush.
8337 * typeprint.c (print_type_scalar): Don't call gdb_flush.
8338 * target.c (target_announce_detach): Don't call gdb_flush.
8339 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8340 * remote.c (extended_remote_target::attach): Don't call
8342 * procfs.c (procfs_target::detach): Don't call gdb_flush.
8343 * printcmd.c (do_examine): Don't call gdb_flush.
8344 (info_display_command): Don't call gdb_flush.
8345 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8346 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8347 * memattr.c (info_mem_command): Don't call gdb_flush.
8348 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8349 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8350 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8351 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8352 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8353 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8354 (gnu_nat_target::detach): Don't call gdb_flush.
8355 * f-valprint.c (f_val_print): Don't call gdb_flush.
8356 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8357 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8358 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8360 * c-valprint.c (c_val_print): Don't call gdb_flush.
8361 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8363 2019-03-05 Tom Tromey <tromey@adacore.com>
8365 * varobj.c (update_dynamic_varobj_children): Update.
8366 (install_default_visualizer): Use reset, not release.
8367 * value.c (set_internalvar): Update.
8368 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8369 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8370 ATTRIBUTE_UNUSED_RESULT.
8372 2019-03-05 Tom Tromey <tromey@adacore.com>
8374 * remote.c (class scoped_remote_fd) <release>: Add
8375 ATTRIBUTE_UNUSED_RESULT.
8377 2019-03-05 Tom Tromey <tromey@adacore.com>
8379 * macroexp.c (struct macro_buffer) <release>: Add
8380 ATTRIBUTE_UNUSED_RESULT.
8382 2019-03-05 Tom Tromey <tromey@adacore.com>
8384 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8385 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8386 ATTRIBUTE_UNUSED_RESULT.
8388 2019-03-05 Tom Tromey <tromey@adacore.com>
8390 * common/scoped_fd.h (class scoped_fd) <release>: Add
8391 ATTRIBUTE_UNUSED_RESULT.
8393 2019-03-05 Tom Tromey <tromey@adacore.com>
8395 * parser-defs.h (struct parser_state) <release>: Add
8396 ATTRIBUTE_UNUSED_RESULT.
8398 2019-03-05 Tom Tromey <tromey@adacore.com>
8400 * utils.h (class gdb_argv) <release>: Add
8401 ATTRIBUTE_UNUSED_RESULT.
8402 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8404 2019-03-02 Eli Zaretskii <eliz@gnu.org>
8406 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8407 for-loop range, to avoid compiler warnings.
8409 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8410 avoid compiler warnings about unused variables.
8412 * NEWS: Mention end of support for native debugging on MS-Windows
8416 * common/netstuff.c:
8417 * gdbserver/gdbreplay.c
8418 * gdbserver/remote-utils.c:
8420 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8421 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
8422 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8423 'getaddrinfo' and 'freeaddrinfo' were not available before
8424 Windows XP, and mingw.org's MinGW headers by default define
8425 _WIN32_WINNT to 0x500.
8427 2019-03-01 Gary Benson <gbenson@redhat.com>
8429 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8431 2019-02-28 Brian Vandenberg <phantall@gmail.com>
8432 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
8435 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8436 set_sigint_trap, clear_sigint_trap.
8438 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8440 * target.c (target_detach): Clear the regcache and the
8443 2019-02-27 Pedro Alves <palves@redhat.com>
8445 * utils.c (set_screen_size): When we cap the height/width sizes,
8446 tweak the corresponding command variable to show "unlimited":
8448 2019-02-27 Saagar Jha <saagar@saagarjha.com>
8449 Pedro Alves <palves@redhat.com>
8451 * utils.c (set_screen_size): Reduce "infinite" rows and columns
8452 before calling rl_set_screen_size.
8454 2019-02-27 Tom Tromey <tromey@adacore.com>
8456 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8458 * python/py-value.c: Remove Python 2.4 workaround.
8459 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8461 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8462 Python 2.4 workaround.
8463 * python/python-internal.h: Remove Python 2.4 comment.
8464 (Py_ssize_t): Don't define.
8465 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8466 (gdb_Py_DECREF): Remove Python 2.4 workaround.
8467 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8468 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8469 * python/python.c (do_start_initialization): Remove Python 2.4
8471 * python/py-prettyprint.c (class dummy_python_frame): Remove.
8472 (print_children): Remove Python 2.4 workaround.
8473 * python/py-inferior.c (buffer_procs): Remove Python 2.4
8475 (CHARBUFFERPROC_NAME): Remove.
8476 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8477 Python 2.4 workaround.
8479 2019-02-27 Kevin Buettner <kevinb@redhat.com>
8481 * NEWS: Note minimum Python version.
8483 2019-02-27 Kevin Buettner <kevinb@redhat.com>
8485 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8486 code from these functions. Remove corresponding ifdefs. Use
8487 Py_buffer_up instead of explicit calls to PyBuffer_Release.
8488 Remove gotos and target of gotos.
8489 (infpy_search_memory): Likewise.
8491 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8493 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8494 (hppa_gdbarch_init): Don't register deleted functions with
8497 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8499 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8500 (h8300_unwind_sp): Delete.
8501 (h8300_dummy_id): Delete.
8502 (h8300_gdbarch_init): Don't register deleted functions with
8505 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8507 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8508 (ft32_unwind_pc): Delete.
8509 (ft32_unwind_sp): Delete.
8510 (ft32_gdbarch_init): Don't register deleted functions with
8513 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8515 * gdb/frv-tdep.c (frv_dummy_id): Delete.
8516 (frv_unwind_pc): Delete.
8517 (frv_unwind_sp): Delete.
8518 (frv_gdbarch_init): Don't register deleted functions with
8521 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8523 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8524 (riscv_unwind_pc): Delete.
8525 (riscv_unwind_sp): Delete.
8526 (riscv_gdbarch_init): Don't register deleted functions with
8529 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8531 * gdb/csky-tdep.c (csky_dummy_id): Delete.
8532 (csky_unwind_pc): Delete.
8533 (csky_unwind_sp): Delete.
8534 (csky_gdbarch_init): Don't register deleted functions with
8537 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8539 * gdb/cris-tdep.c (cris_dummy_id): Delete.
8540 (cris_unwind_pc): Delete.
8541 (cris_unwind_sp): Delete.
8542 (cris_gdbarch_init): Don't register deleted functions with
8545 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8547 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8548 (bfin_unwind_pc): Delete.
8549 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8551 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8553 * gdb/arm-tdep.c (arm_dummy_id): Delete.
8554 (arm_unwind_pc): Delete.
8555 (arm_unwind_sp): Delete.
8556 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8558 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8560 * gdb/arc-tdep.c (arc_dummy_id): Delete.
8561 (arc_unwind_pc): Delete.
8562 (arc_unwind_sp): Delete.
8563 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8565 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8567 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8568 (alpha_unwind_pc): Delete.
8569 (alpha_gdbarch_init): Don't register deleted functions with
8572 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8574 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8575 (aarch64_unwind_pc): Delete.
8576 (aarch64_unwind_sp): Delete.
8577 (aarch64_gdbarch_init): Don't register deleted functions with
8580 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8582 * gdbtypes.c (type_align): Don't consider static members when
8583 computing structure alignment.
8585 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8587 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8588 return 0 for other types.
8589 * arch-utils.c (default_type_align): Always return 0.
8590 * gdbarch.h: Regenerate.
8591 * gdbarch.sh (type_align): Extend comment.
8592 * gdbtypes.c (type_align): Add additional comments, always call
8593 gdbarch_type_align before applying the default rules.
8594 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8595 generic code will then apply a suitable default.
8596 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8597 types, return 0 for other types.
8599 2019-02-27 Joel Brobecker <brobecker@adacore.com>
8601 * NEWS: Create a new section for the next release branch.
8602 Rename the section of the current branch, now that it has
8605 2019-02-27 Joel Brobecker <brobecker@adacore.com>
8607 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8608 * version.in: Bump version to 8.3.50.DATE-git.
8610 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
8612 * aix-thread.c (ptid_cmp): Remove unused variable.
8613 (get_signaled_thread): Likewise.
8614 (store_regs_user_thread): Likewise.
8615 (store_regs_kernel_thread): Likewise.
8616 (fetch_regs_kernel_thread): Remove shadowed variable.
8618 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
8620 * features/riscv/32bit-cpu.xml: Add register numbers.
8621 * features/riscv/32bit-fpu.c: Regenerate.
8622 * features/riscv/32bit-fpu.xml: Add register numbers.
8623 * features/riscv/64bit-cpu.xml: Add register numbers.
8624 * features/riscv/64bit-fpu.c: Regenerate.
8625 * features/riscv/64bit-fpu.xml: Add register numbers.
8627 2019-02-26 Kevin Buettner <kevinb@redhat.com>
8629 * NEWS: Mention two argument form of gdb.Value constructor.
8630 * python/py-value.c (convert_buffer_and_type_to_value): New
8632 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8633 Add support for handling an optional second argument. Call
8634 convert_buffer_and_type_to_value as appropriate.
8635 * python/python-internal.h (Py_buffer_deleter): New struct.
8636 (Py_buffer_up): New typedef.
8638 2019-02-25 John Baldwin <jhb@FreeBSD.org>
8640 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8641 instead of releasing ownership.
8643 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
8645 * dwarf2read.c (open_and_init_dwp_file): Call
8646 elf_numsections instead of bfd_count_sections to initialize
8647 dwp_file->num_sections.
8649 2019-02-25 Tom Tromey <tromey@adacore.com>
8651 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8653 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
8655 * gcore.in: Add '--readnever' option when invoking GDB.
8657 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
8659 * MAINTAINERS: Update my email address.
8661 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
8663 * build-id.c (build_id_to_debug_bfd_1): New function.
8664 (build_id_to_debug_bfd): Look for separate debug file in
8667 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
8669 * gdbarch.sh: Update the copyright year range that is placed into
8672 2019-02-22 Keith Seitz <keiths@redhat.com>
8675 * linespec.c (create_sals_line_offset): Search for the default
8676 symtab's filename instead of its fullname.
8678 2019-02-21 Alan Hayward <alan.hayward@arm.com>
8680 * NEWS: Update style defaults.
8682 2019-02-21 Alan Hayward <alan.hayward@arm.com>
8684 * main.c (captured_main_1): Disable styling in batch mode.
8686 2019-02-20 Tom Tromey <tom@tromey.com>
8688 * symtab.c (symtab_symbol_info): Fix typos.
8690 2019-02-20 Tom Tromey <tromey@adacore.com>
8692 * findcmd.c (_initialize_mem_search): Use upper case for
8693 metasyntactic variables.
8695 2019-02-20 Alan Hayward <alan.hayward@arm.com>
8697 * aarch64-tdep.c (aarch64_add_reggroups): New function.
8698 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8700 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
8702 * top.h (source_file_name): Change to std::string.
8703 * top.c (source_file_name): Likewise.
8704 (command_line_input): Adjust.
8705 * cli/cli-script.c (script_from_file): Adjust.
8707 2019-02-19 Tom Tromey <tromey@adacore.com>
8709 * ravenscar-thread.c
8710 (ravenscar_thread_target::update_thread_list): Don't call
8711 ada_build_task_list.
8712 * ada-lang.h (ada_build_task_list): Don't declare.
8713 * ada-tasks.c (struct ada_tasks_inferior_data)
8714 <task_list_valid_p>: Now bool.
8715 (read_known_tasks, ada_task_list_changed)
8716 (ada_tasks_invalidate_inferior_data): Update.
8717 (read_known_tasks_array): Return bool.
8718 (read_known_tasks_list): Likewise.
8719 (read_known_tasks): Return void.
8720 (ada_build_task_list): Now static.
8722 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
8724 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8725 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8727 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8729 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8730 variant for ada_tasks_pspace_data_handle and
8731 ada_tasks_inferior_data_handle.
8732 (ada_tasks_pspace_data_cleanup): New function.
8733 (ada_tasks_inferior_data_cleanup): New function.
8735 2019-02-17 Tom Tromey <tom@tromey.com>
8737 * macrotab.h (macro_source_fullname): Return a std::string.
8738 * macrotab.c (macro_include, check_for_redefinition)
8739 (macro_undef, macro_lookup_definition, foreach_macro)
8740 (foreach_macro_in_scope): Update.
8741 (macro_source_fullname): Return a std::string.
8742 * macrocmd.c (show_pp_source_pos): Update.
8744 2019-02-17 Tom Tromey <tom@tromey.com>
8746 * macrocmd.c (show_pp_source_pos): Style the file names.
8748 2019-02-17 Tom Tromey <tom@tromey.com>
8751 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8753 2019-02-17 Tom Tromey <tom@tromey.com>
8755 * ada-lang.c (user_select_syms): Use filtered printing.
8756 * utils.c (wrap_style): New global.
8757 (desired_style): Remove.
8758 (emit_style_escape): Add stream parameter.
8759 (set_output_style, reset_terminal_style, prompt_for_continue):
8761 (flush_wrap_buffer): Only flush gdb_stdout.
8762 (wrap_here): Set wrap_style.
8763 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
8764 treat escape sequences as a character. Change when wrap buffer is
8766 (fputs_styled): Do not set the output style when the default is
8768 * ui-style.h (struct ui_file_style) <is_default>: New method.
8769 * source.c (print_source_lines_base): Emit escape sequences in one
8772 2019-02-17 Joel Brobecker <brobecker@adacore.com>
8774 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8775 integers and enumeration types.
8777 2019-02-17 Joel Brobecker <brobecker@adacore.com>
8779 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8780 instead of lookup_symbol_in_language
8781 (do_exact_match): New function.
8782 (ada_get_symbol_name_matcher): Return do_exact_match when
8783 doing a verbatim match.
8785 2019-02-15 Tom Tromey <tromey@adacore.com>
8787 * ravenscar-thread.c (ravenscar_thread_target::resume)
8788 (ravenscar_thread_target::wait): Special case wildcard requests.
8790 2019-02-15 Tom Tromey <tromey@adacore.com>
8792 * ravenscar-thread.c (base_ptid): Remove.
8793 (struct ravenscar_thread_target) <close>: New method.
8794 <m_base_ptid>: New member.
8795 <update_inferior_ptid, active_task, task_is_currently_active,
8796 runtime_initialized>: Declare methods.
8797 <ravenscar_thread_target>: Add constructor.
8798 (ravenscar_thread_target::task_is_currently_active)
8799 (ravenscar_thread_target::update_inferior_ptid)
8800 (ravenscar_runtime_initialized): Rename. Now methods.
8801 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8802 (ravenscar_thread_target::update_thread_list): Update.
8803 (ravenscar_thread_target::active_task): Now method.
8804 (ravenscar_thread_target::store_registers)
8805 (ravenscar_thread_target::prepare_to_store)
8806 (ravenscar_thread_target::prepare_to_store)
8807 (ravenscar_thread_target::mourn_inferior): Update.
8808 (ravenscar_inferior_created): Use "new" to create target.
8809 (ravenscar_thread_target::get_ada_task_ptid): Update.
8810 (_initialize_ravenscar): Don't initialize base_ptid.
8811 (ravenscar_ops): Remove global.
8813 2019-02-15 Tom Tromey <tromey@adacore.com>
8815 * target.h (push_target): Declare new overload.
8816 * target.c (push_target): New overload, taking an rvalue reference.
8817 * remote.c (remote_target::open_1): Use push_target overload.
8818 * corelow.c (core_target_open): Use push_target overload.
8820 2019-02-15 Tom Tromey <tromey@adacore.com>
8822 * ravenscar-thread.c (is_ravenscar_task)
8823 (ravenscar_task_is_currently_active): Return bool.
8824 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8825 (_initialize_ravenscar): Remove "(void)".
8826 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8829 2019-02-15 Tom Tromey <tromey@adacore.com>
8831 * ravenscar-thread.c (ravenscar_runtime_initializer)
8832 (has_ravenscar_runtime, get_running_thread_id)
8833 (ravenscar_thread_target::resume): Fix indentation.
8835 2019-02-15 Tom Tromey <tromey@adacore.com>
8837 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8838 from ravenscar_arch_ops.
8839 (sparc_ravenscar_ops::fetch_registers)
8840 (sparc_ravenscar_ops::store_registers): Now methods.
8841 (sparc_ravenscar_prepare_to_store): Remove.
8842 (sparc_ravenscar_ops): Redefine.
8843 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8844 methods and destructor. Remove members.
8845 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8846 (ravenscar_thread_target::store_registers)
8847 (ravenscar_thread_target::prepare_to_store): Update.
8848 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8850 (struct ppc_ravenscar_powerpc_ops): Derive from
8852 (ppc_ravenscar_powerpc_ops::fetch_registers)
8853 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8854 (ppc_ravenscar_powerpc_ops): Redefine.
8855 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8856 (ppc_ravenscar_e500_ops::fetch_registers)
8857 (ppc_ravenscar_e500_ops::store_registers): Now methods.
8858 (ppc_ravenscar_e500_ops): Redefine.
8859 * aarch64-ravenscar-thread.c
8860 (aarch64_ravenscar_generic_prepare_to_store): Remove.
8861 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8862 (aarch64_ravenscar_fetch_registers)
8863 (aarch64_ravenscar_store_registers): Now methods.
8864 (aarch64_ravenscar_ops): Redefine.
8866 2019-02-15 Tom Tromey <tromey@adacore.com>
8868 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8869 (ravenscar_thread_target::stopped_by_hw_breakpoint)
8870 (ravenscar_thread_target::stopped_by_watchpoint)
8871 (ravenscar_thread_target::stopped_data_address)
8872 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8874 2019-02-15 Tom Tromey <tromey@adacore.com>
8876 * ravenscar-thread.c: Fix some typos.
8878 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8879 Tom Tromey <tromey@adacore.com>
8881 * ada-lang.c (ada_exception_sal): Change addr_string to a
8883 (create_ada_exception_catchpoint): Update.
8885 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8886 Tom Tromey <tromey@adacore.com>
8888 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8889 (bp_location_ops): Remove.
8890 (base_breakpoint_allocate_location): Update.
8891 (free_bp_location): Update.
8892 * ada-lang.c (class ada_catchpoint_location)
8893 <ada_catchpoint_location>: Remove ops parameter.
8894 (ada_catchpoint_location_dtor): Remove.
8895 (ada_catchpoint_location_ops): Remove.
8896 (allocate_location_exception): Update.
8897 * breakpoint.h (struct bp_location_ops): Remove.
8898 (class bp_location) <bp_location>: Remove bp_location_ops
8900 <~bp_location>: Add destructor.
8903 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8904 Pedro Alves <palves@redhat.com>
8906 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8909 2019-02-14 David Michael <fedora.dm0@gmail.com>
8910 Samuel Thibault <samuel.thibault@gnu.org>
8911 Thomas Schwinge <thomas@codesourcery.com>
8913 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8914 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8916 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8918 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8919 (check_empty): Use "const char *".
8921 * gnu-nat.c (gnu_nat_target::detach): Instead of
8922 'detach_inferior (pid)' call
8923 'detach_inferior (find_inferior_pid (pid))'.
8925 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8926 'nat/fork-inferior.o'.
8927 * gnu-nat.c: #include "nat/fork-inferior.h".
8929 * gnu-nat.c (gnu_nat_target::detach): Instead of
8930 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8931 * gnu-nat.h: #include "inf-child.h".
8932 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8933 'i386_gnu_nat_target::fetch_registers'.
8934 (gnu_store_registers): Rename/move to
8935 'i386_gnu_nat_target::store_registers'.
8937 * config/i386/nm-i386gnu.h: Don't "#include" any files.
8938 * gnu-nat.h (mach_thread_info): New function.
8939 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8941 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8943 2019-02-14 Frederic Konrad <konrad@adacore.com>
8945 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8947 2019-02-14 Joel Brobecker <brobecker@adacore.com>
8949 * windows-nat.c (windows_add_thread): Add new parameter
8950 "main_thread_p" with default value set to false. Update
8951 function documentation as well as all callers.
8952 (windows_delete_thread): Likewise.
8953 (fake_create_process): Update call to windows_add_thread.
8954 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8955 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8956 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8957 call to windows_delete_thread.
8959 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
8961 * MAINTAINERS: Add Andrew Burgess as global maintainer.
8963 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8965 * symfile.c (find_separate_debug_file): Use canonical path of
8966 sysroot with child_path instead of gdb_sysroot if it is valid.
8968 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8970 * symfile.c (find_separate_debug_file): Use child_path to
8971 determine if an object file is under a sysroot.
8973 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8975 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8976 unittests/child-path-selftests.c.
8977 * common/pathstuff.c (child_path): New function.
8978 * common/pathstuff.h (child_path): New prototype.
8979 * unittests/child-path-selftests.c: New file.
8981 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8983 * symfile.c (find_separate_debug_file): Look for separate debug
8984 files in debug directories under the sysroot.
8986 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8988 * symtab.h (struct minimal_symbol data_p): New const method.
8989 (struct minimal_symbol text_p): Likewise.
8990 * symtab.c (output_source_filename): Use file name style
8992 (print_symbol_info): Likewise.
8993 (print_msymbol_info): Use address style to print addresses.
8994 Use function name style to print executable text symbols.
8995 (expand_symtab_containing_pc): Use data_p.
8996 (find_pc_sect_compunit_symtab): Likewise.
8998 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9000 * breakpoint.c (describe_other_breakpoints): Use address style
9002 (say_where): Likewise.
9004 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9006 * ada-typeprint.c (print_func_type): Print function name
9007 style to print function name.
9008 * c-typeprint.c (c_print_type_1): Likewise.
9010 2019-02-11 Alan Hayward <alan.hayward@arm.com>
9012 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9015 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9017 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9020 2019-02-10 Joel Brobecker <brobecker@adacore.com>
9022 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9023 TYPE_CODE_REF types.
9025 2019-02-08 Jim Wilson <jimw@sifive.com>
9027 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9028 (riscv_linux_fregset): New.
9029 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9031 2019-02-07 Tom Tromey <tom@tromey.com>
9033 * thread.c (thread_cancel_execution_command): Update.
9034 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9036 (struct thread_fsm_ops): Remove.
9037 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9038 (thread_fsm_should_stop, thread_fsm_return_value)
9039 (thread_fsm_set_finished, thread_fsm_finished_p)
9040 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9042 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9043 * infrun.c (clear_proceed_status_thread)
9044 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9045 (print_stop_event): Update.
9046 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9048 (step_command_fsm_ops): Remove.
9049 (new_step_command_fsm): Remove.
9051 (step_command_fsm::should_stop): Rename from
9052 step_command_fsm_should_stop.
9053 (step_command_fsm::clean_up): Rename from
9054 step_command_fsm_clean_up.
9055 (step_command_fsm::do_async_reply_reason): Rename from
9056 step_command_fsm_async_reply_reason.
9057 (struct until_next_fsm): Inherit from thread_fsm. Add
9059 (until_next_fsm_ops): Remove.
9060 (new_until_next_fsm): Remove.
9061 (until_next_fsm::should_stop): Rename from
9062 until_next_fsm_should_stop.
9063 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9064 (until_next_fsm::do_async_reply_reason): Rename from
9065 until_next_fsm_async_reply_reason.
9066 (struct finish_command_fsm): Inherit from thread_fsm. Add
9067 constructor. Change type of breakpoint.
9068 (finish_command_fsm_ops): Remove.
9069 (new_finish_command_fsm): Remove.
9070 (finish_command_fsm::should_stop): Rename from
9071 finish_command_fsm_should_stop.
9072 (finish_command_fsm::clean_up): Rename from
9073 finish_command_fsm_clean_up.
9074 (finish_command_fsm::return_value): Rename from
9075 finish_command_fsm_return_value.
9076 (finish_command_fsm::do_async_reply_reason): Rename from
9077 finish_command_fsm_async_reply_reason.
9078 (finish_command): Update.
9079 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9081 (call_thread_fsm_ops): Remove.
9082 (call_thread_fsm::call_thread_fsm): Rename from
9083 new_call_thread_fsm.
9084 (call_thread_fsm::should_stop): Rename from
9085 call_thread_fsm_should_stop.
9086 (call_thread_fsm::should_notify_stop): Rename from
9087 call_thread_fsm_should_notify_stop.
9088 (run_inferior_call, call_function_by_hand_dummy): Update.
9089 * cli/cli-interp.c (should_print_stop_to_console): Update.
9090 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9091 Add constructor. Change type of location_breakpoint,
9093 (until_break_fsm_ops): Remove.
9094 (new_until_break_fsm): Remove.
9095 (until_break_fsm::should_stop): Rename from
9096 until_break_fsm_should_stop.
9097 (until_break_fsm::clean_up): Rename from
9098 until_break_fsm_clean_up.
9099 (until_break_fsm::do_async_reply_reason): Rename from
9100 until_break_fsm_async_reply_reason.
9101 (until_break_command): Update.
9102 * thread-fsm.c: Remove.
9103 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9105 2019-02-07 Tom Tromey <tom@tromey.com>
9107 * yy-remap.h: Add include guard.
9108 * xtensa-tdep.h: Add include guard.
9109 * xcoffread.h: Rename include guard.
9110 * varobj-iter.h: Add include guard.
9111 * tui/tui.h: Rename include guard.
9112 * tui/tui-winsource.h: Rename include guard.
9113 * tui/tui-wingeneral.h: Rename include guard.
9114 * tui/tui-windata.h: Rename include guard.
9115 * tui/tui-win.h: Rename include guard.
9116 * tui/tui-stack.h: Rename include guard.
9117 * tui/tui-source.h: Rename include guard.
9118 * tui/tui-regs.h: Rename include guard.
9119 * tui/tui-out.h: Rename include guard.
9120 * tui/tui-layout.h: Rename include guard.
9121 * tui/tui-io.h: Rename include guard.
9122 * tui/tui-hooks.h: Rename include guard.
9123 * tui/tui-file.h: Rename include guard.
9124 * tui/tui-disasm.h: Rename include guard.
9125 * tui/tui-data.h: Rename include guard.
9126 * tui/tui-command.h: Rename include guard.
9127 * tic6x-tdep.h: Add include guard.
9128 * target/waitstatus.h: Rename include guard.
9129 * target/wait.h: Rename include guard.
9130 * target/target.h: Rename include guard.
9131 * target/resume.h: Rename include guard.
9132 * target-float.h: Rename include guard.
9133 * stabsread.h: Add include guard.
9134 * rs6000-tdep.h: Add include guard.
9135 * riscv-fbsd-tdep.h: Add include guard.
9136 * regformats/regdef.h: Rename include guard.
9137 * record.h: Rename include guard.
9138 * python/python.h: Rename include guard.
9139 * python/python-internal.h: Rename include guard.
9140 * python/py-stopevent.h: Rename include guard.
9141 * python/py-ref.h: Rename include guard.
9142 * python/py-record.h: Rename include guard.
9143 * python/py-record-full.h: Rename include guard.
9144 * python/py-record-btrace.h: Rename include guard.
9145 * python/py-instruction.h: Rename include guard.
9146 * python/py-events.h: Rename include guard.
9147 * python/py-event.h: Rename include guard.
9148 * procfs.h: Add include guard.
9149 * proc-utils.h: Add include guard.
9150 * p-lang.h: Add include guard.
9151 * or1k-tdep.h: Rename include guard.
9152 * observable.h: Rename include guard.
9153 * nto-tdep.h: Rename include guard.
9154 * nat/x86-linux.h: Rename include guard.
9155 * nat/x86-linux-dregs.h: Rename include guard.
9156 * nat/x86-gcc-cpuid.h: Add include guard.
9157 * nat/x86-dregs.h: Rename include guard.
9158 * nat/x86-cpuid.h: Rename include guard.
9159 * nat/ppc-linux.h: Rename include guard.
9160 * nat/mips-linux-watch.h: Rename include guard.
9161 * nat/linux-waitpid.h: Rename include guard.
9162 * nat/linux-ptrace.h: Rename include guard.
9163 * nat/linux-procfs.h: Rename include guard.
9164 * nat/linux-osdata.h: Rename include guard.
9165 * nat/linux-nat.h: Rename include guard.
9166 * nat/linux-namespaces.h: Rename include guard.
9167 * nat/linux-btrace.h: Rename include guard.
9168 * nat/glibc_thread_db.h: Rename include guard.
9169 * nat/gdb_thread_db.h: Rename include guard.
9170 * nat/gdb_ptrace.h: Rename include guard.
9171 * nat/fork-inferior.h: Rename include guard.
9172 * nat/amd64-linux-siginfo.h: Rename include guard.
9173 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9174 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9175 * nat/aarch64-linux.h: Rename include guard.
9176 * nat/aarch64-linux-hw-point.h: Rename include guard.
9177 * mn10300-tdep.h: Add include guard.
9178 * mips-linux-tdep.h: Add include guard.
9179 * mi/mi-parse.h: Rename include guard.
9180 * mi/mi-out.h: Rename include guard.
9181 * mi/mi-main.h: Rename include guard.
9182 * mi/mi-interp.h: Rename include guard.
9183 * mi/mi-getopt.h: Rename include guard.
9184 * mi/mi-console.h: Rename include guard.
9185 * mi/mi-common.h: Rename include guard.
9186 * mi/mi-cmds.h: Rename include guard.
9187 * mi/mi-cmd-break.h: Rename include guard.
9188 * m2-lang.h: Add include guard.
9189 * location.h: Rename include guard.
9190 * linux-record.h: Rename include guard.
9191 * linux-nat.h: Add include guard.
9192 * linux-fork.h: Add include guard.
9193 * i386-darwin-tdep.h: Rename include guard.
9194 * hppa-linux-offsets.h: Add include guard.
9195 * guile/guile.h: Rename include guard.
9196 * guile/guile-internal.h: Rename include guard.
9197 * gnu-nat.h: Rename include guard.
9198 * gdb-stabs.h: Rename include guard.
9199 * frv-tdep.h: Add include guard.
9200 * f-lang.h: Add include guard.
9201 * event-loop.h: Add include guard.
9202 * darwin-nat.h: Rename include guard.
9203 * cp-abi.h: Rename include guard.
9204 * config/sparc/nm-sol2.h: Rename include guard.
9205 * config/nm-nto.h: Rename include guard.
9206 * config/nm-linux.h: Add include guard.
9207 * config/i386/nm-i386gnu.h: Rename include guard.
9208 * config/djgpp/nl_types.h: Rename include guard.
9209 * config/djgpp/langinfo.h: Rename include guard.
9210 * compile/gcc-cp-plugin.h: Add include guard.
9211 * compile/gcc-c-plugin.h: Add include guard.
9212 * compile/compile.h: Rename include guard.
9213 * compile/compile-object-run.h: Rename include guard.
9214 * compile/compile-object-load.h: Rename include guard.
9215 * compile/compile-internal.h: Rename include guard.
9216 * compile/compile-cplus.h: Rename include guard.
9217 * compile/compile-c.h: Rename include guard.
9218 * common/xml-utils.h: Rename include guard.
9219 * common/x86-xstate.h: Rename include guard.
9220 * common/version.h: Rename include guard.
9221 * common/vec.h: Rename include guard.
9222 * common/tdesc.h: Rename include guard.
9223 * common/selftest.h: Rename include guard.
9224 * common/scoped_restore.h: Rename include guard.
9225 * common/scoped_mmap.h: Rename include guard.
9226 * common/scoped_fd.h: Rename include guard.
9227 * common/safe-iterator.h: Rename include guard.
9228 * common/run-time-clock.h: Rename include guard.
9229 * common/refcounted-object.h: Rename include guard.
9230 * common/queue.h: Rename include guard.
9231 * common/ptid.h: Rename include guard.
9232 * common/print-utils.h: Rename include guard.
9233 * common/preprocessor.h: Rename include guard.
9234 * common/pathstuff.h: Rename include guard.
9235 * common/observable.h: Rename include guard.
9236 * common/netstuff.h: Rename include guard.
9237 * common/job-control.h: Rename include guard.
9238 * common/host-defs.h: Rename include guard.
9239 * common/gdb_wait.h: Rename include guard.
9240 * common/gdb_vecs.h: Rename include guard.
9241 * common/gdb_unlinker.h: Rename include guard.
9242 * common/gdb_unique_ptr.h: Rename include guard.
9243 * common/gdb_tilde_expand.h: Rename include guard.
9244 * common/gdb_sys_time.h: Rename include guard.
9245 * common/gdb_string_view.h: Rename include guard.
9246 * common/gdb_splay_tree.h: Rename include guard.
9247 * common/gdb_setjmp.h: Rename include guard.
9248 * common/gdb_ref_ptr.h: Rename include guard.
9249 * common/gdb_optional.h: Rename include guard.
9250 * common/gdb_locale.h: Rename include guard.
9251 * common/gdb_assert.h: Rename include guard.
9252 * common/filtered-iterator.h: Rename include guard.
9253 * common/filestuff.h: Rename include guard.
9254 * common/fileio.h: Rename include guard.
9255 * common/environ.h: Rename include guard.
9256 * common/common-utils.h: Rename include guard.
9257 * common/common-types.h: Rename include guard.
9258 * common/common-regcache.h: Rename include guard.
9259 * common/common-inferior.h: Rename include guard.
9260 * common/common-gdbthread.h: Rename include guard.
9261 * common/common-exceptions.h: Rename include guard.
9262 * common/common-defs.h: Rename include guard.
9263 * common/common-debug.h: Rename include guard.
9264 * common/cleanups.h: Rename include guard.
9265 * common/buffer.h: Rename include guard.
9266 * common/btrace-common.h: Rename include guard.
9267 * common/break-common.h: Rename include guard.
9268 * cli/cli-utils.h: Rename include guard.
9269 * cli/cli-style.h: Rename include guard.
9270 * cli/cli-setshow.h: Rename include guard.
9271 * cli/cli-script.h: Rename include guard.
9272 * cli/cli-interp.h: Rename include guard.
9273 * cli/cli-decode.h: Rename include guard.
9274 * cli/cli-cmds.h: Rename include guard.
9275 * charset-list.h: Add include guard.
9276 * buildsym-legacy.h: Rename include guard.
9277 * bfin-tdep.h: Add include guard.
9278 * ax.h: Rename include guard.
9279 * arm-linux-tdep.h: Add include guard.
9280 * arm-fbsd-tdep.h: Add include guard.
9281 * arch/xtensa.h: Rename include guard.
9282 * arch/tic6x.h: Add include guard.
9283 * arch/i386.h: Add include guard.
9284 * arch/arm.h: Rename include guard.
9285 * arch/arm-linux.h: Rename include guard.
9286 * arch/arm-get-next-pcs.h: Rename include guard.
9287 * arch/amd64.h: Add include guard.
9288 * arch/aarch64-insn.h: Rename include guard.
9289 * arch-utils.h: Rename include guard.
9290 * annotate.h: Add include guard.
9291 * amd64-darwin-tdep.h: Rename include guard.
9292 * aarch64-linux-tdep.h: Add include guard.
9293 * aarch64-fbsd-tdep.h: Add include guard.
9294 * aarch32-linux-nat.h: Add include guard.
9296 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9298 * macrotab.c (macro_define_internal): New function that
9299 factorizes macro_define_object_internal and macro_define_function
9301 (macro_define_object_internal): Use macro_define_internal.
9302 (macro_define_function): Likewise.
9304 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9306 * macrocmd.c (extract_identifier): Return
9307 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9310 2019-02-06 John Baldwin <jhb@FreeBSD.org>
9312 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9314 2019-02-05 Tom Tromey <tom@tromey.com>
9316 * target.c (target_stack::unpush): Move assertion earlier.
9318 2019-01-30 Tom Tromey <tom@tromey.com>
9321 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9322 (gdbpy_parse_and_eval): Likewise.
9323 * python/python-internal.h (gdbpy_allow_threads): New class.
9325 2019-01-28 John Baldwin <jhb@FreeBSD.org>
9327 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9328 (aarch64_fbsd_fpregmap): Move earlier.
9329 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9330 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9331 instead of individual calls to trad_frame_set_reg_addr.
9332 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9334 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9335 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9336 instead of individual calls to trad_frame_set_reg_addr.
9338 2019-01-28 Alan Hayward <alan.hayward@arm.com>
9340 * CONTRIBUTE: Replace contribution list with wiki link.
9342 2019-01-25 Tom Tromey <tom@tromey.com>
9344 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9346 2019-01-25 Tom Tromey <tom@tromey.com>
9348 * xtensa-linux-nat.c: Fix common/ includes.
9349 * xml-support.h: Fix common/ includes.
9350 * xml-support.c: Fix common/ includes.
9351 * x86-linux-nat.c: Fix common/ includes.
9352 * windows-nat.c: Fix common/ includes.
9353 * varobj.h: Fix common/ includes.
9354 * varobj.c: Fix common/ includes.
9355 * value.c: Fix common/ includes.
9356 * valops.c: Fix common/ includes.
9357 * utils.c: Fix common/ includes.
9358 * unittests/xml-utils-selftests.c: Fix common/ includes.
9359 * unittests/utils-selftests.c: Fix common/ includes.
9360 * unittests/unpack-selftests.c: Fix common/ includes.
9361 * unittests/tracepoint-selftests.c: Fix common/ includes.
9362 * unittests/style-selftests.c: Fix common/ includes.
9363 * unittests/string_view-selftests.c: Fix common/ includes.
9364 * unittests/scoped_restore-selftests.c: Fix common/ includes.
9365 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9366 * unittests/scoped_fd-selftests.c: Fix common/ includes.
9367 * unittests/rsp-low-selftests.c: Fix common/ includes.
9368 * unittests/parse-connection-spec-selftests.c: Fix common/
9370 * unittests/optional-selftests.c: Fix common/ includes.
9371 * unittests/offset-type-selftests.c: Fix common/ includes.
9372 * unittests/observable-selftests.c: Fix common/ includes.
9373 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9374 * unittests/memrange-selftests.c: Fix common/ includes.
9375 * unittests/memory-map-selftests.c: Fix common/ includes.
9376 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9377 * unittests/function-view-selftests.c: Fix common/ includes.
9378 * unittests/environ-selftests.c: Fix common/ includes.
9379 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9380 * unittests/common-utils-selftests.c: Fix common/ includes.
9381 * unittests/cli-utils-selftests.c: Fix common/ includes.
9382 * unittests/array-view-selftests.c: Fix common/ includes.
9383 * ui-file.c: Fix common/ includes.
9384 * tui/tui-io.c: Fix common/ includes.
9385 * tracepoint.h: Fix common/ includes.
9386 * tracepoint.c: Fix common/ includes.
9387 * tracefile-tfile.c: Fix common/ includes.
9388 * top.h: Fix common/ includes.
9389 * top.c: Fix common/ includes.
9390 * thread.c: Fix common/ includes.
9391 * target/waitstatus.h: Fix common/ includes.
9392 * target/waitstatus.c: Fix common/ includes.
9393 * target.h: Fix common/ includes.
9394 * target.c: Fix common/ includes.
9395 * target-memory.c: Fix common/ includes.
9396 * target-descriptions.c: Fix common/ includes.
9397 * symtab.h: Fix common/ includes.
9398 * symfile.c: Fix common/ includes.
9399 * stap-probe.c: Fix common/ includes.
9400 * spu-linux-nat.c: Fix common/ includes.
9401 * sparc-nat.c: Fix common/ includes.
9402 * source.c: Fix common/ includes.
9403 * solib.c: Fix common/ includes.
9404 * solib-target.c: Fix common/ includes.
9405 * ser-unix.c: Fix common/ includes.
9406 * ser-tcp.c: Fix common/ includes.
9407 * ser-pipe.c: Fix common/ includes.
9408 * ser-base.c: Fix common/ includes.
9409 * selftest-arch.c: Fix common/ includes.
9410 * s12z-tdep.c: Fix common/ includes.
9411 * rust-exp.y: Fix common/ includes.
9412 * rs6000-aix-tdep.c: Fix common/ includes.
9413 * riscv-tdep.c: Fix common/ includes.
9414 * remote.c: Fix common/ includes.
9415 * remote-notif.h: Fix common/ includes.
9416 * remote-fileio.h: Fix common/ includes.
9417 * remote-fileio.c: Fix common/ includes.
9418 * regcache.h: Fix common/ includes.
9419 * regcache.c: Fix common/ includes.
9420 * record-btrace.c: Fix common/ includes.
9421 * python/python.c: Fix common/ includes.
9422 * python/py-type.c: Fix common/ includes.
9423 * python/py-inferior.c: Fix common/ includes.
9424 * progspace.h: Fix common/ includes.
9425 * producer.c: Fix common/ includes.
9426 * procfs.c: Fix common/ includes.
9427 * proc-api.c: Fix common/ includes.
9428 * printcmd.c: Fix common/ includes.
9429 * ppc-linux-nat.c: Fix common/ includes.
9430 * parser-defs.h: Fix common/ includes.
9431 * osdata.c: Fix common/ includes.
9432 * obsd-nat.c: Fix common/ includes.
9433 * nat/x86-linux.c: Fix common/ includes.
9434 * nat/x86-linux-dregs.c: Fix common/ includes.
9435 * nat/x86-dregs.h: Fix common/ includes.
9436 * nat/x86-dregs.c: Fix common/ includes.
9437 * nat/ppc-linux.c: Fix common/ includes.
9438 * nat/mips-linux-watch.h: Fix common/ includes.
9439 * nat/mips-linux-watch.c: Fix common/ includes.
9440 * nat/linux-waitpid.c: Fix common/ includes.
9441 * nat/linux-ptrace.h: Fix common/ includes.
9442 * nat/linux-ptrace.c: Fix common/ includes.
9443 * nat/linux-procfs.c: Fix common/ includes.
9444 * nat/linux-personality.c: Fix common/ includes.
9445 * nat/linux-osdata.c: Fix common/ includes.
9446 * nat/linux-namespaces.c: Fix common/ includes.
9447 * nat/linux-btrace.h: Fix common/ includes.
9448 * nat/linux-btrace.c: Fix common/ includes.
9449 * nat/fork-inferior.c: Fix common/ includes.
9450 * nat/amd64-linux-siginfo.c: Fix common/ includes.
9451 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9452 * nat/aarch64-linux.c: Fix common/ includes.
9453 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9454 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9455 * namespace.h: Fix common/ includes.
9456 * mips-linux-tdep.c: Fix common/ includes.
9457 * minsyms.c: Fix common/ includes.
9458 * mi/mi-parse.h: Fix common/ includes.
9459 * mi/mi-main.c: Fix common/ includes.
9460 * mi/mi-cmd-env.c: Fix common/ includes.
9461 * memrange.h: Fix common/ includes.
9462 * memattr.c: Fix common/ includes.
9463 * maint.h: Fix common/ includes.
9464 * maint.c: Fix common/ includes.
9465 * main.c: Fix common/ includes.
9466 * machoread.c: Fix common/ includes.
9467 * location.c: Fix common/ includes.
9468 * linux-thread-db.c: Fix common/ includes.
9469 * linux-nat.c: Fix common/ includes.
9470 * linux-fork.c: Fix common/ includes.
9471 * inline-frame.c: Fix common/ includes.
9472 * infrun.c: Fix common/ includes.
9473 * inflow.c: Fix common/ includes.
9474 * inferior.h: Fix common/ includes.
9475 * inferior.c: Fix common/ includes.
9476 * infcmd.c: Fix common/ includes.
9477 * inf-ptrace.c: Fix common/ includes.
9478 * inf-child.c: Fix common/ includes.
9479 * ia64-linux-nat.c: Fix common/ includes.
9480 * i387-tdep.c: Fix common/ includes.
9481 * i386-tdep.c: Fix common/ includes.
9482 * i386-linux-tdep.c: Fix common/ includes.
9483 * i386-linux-nat.c: Fix common/ includes.
9484 * i386-go32-tdep.c: Fix common/ includes.
9485 * i386-fbsd-tdep.c: Fix common/ includes.
9486 * i386-fbsd-nat.c: Fix common/ includes.
9487 * guile/scm-type.c: Fix common/ includes.
9488 * guile/guile.c: Fix common/ includes.
9489 * go32-nat.c: Fix common/ includes.
9490 * gnu-nat.c: Fix common/ includes.
9491 * gdbthread.h: Fix common/ includes.
9492 * gdbarch-selftests.c: Fix common/ includes.
9493 * gdb_usleep.c: Fix common/ includes.
9494 * gdb_select.h: Fix common/ includes.
9495 * gdb_bfd.c: Fix common/ includes.
9496 * gcore.c: Fix common/ includes.
9497 * fork-child.c: Fix common/ includes.
9498 * findvar.c: Fix common/ includes.
9499 * fbsd-nat.c: Fix common/ includes.
9500 * event-top.c: Fix common/ includes.
9501 * event-loop.c: Fix common/ includes.
9502 * dwarf2read.c: Fix common/ includes.
9503 * dwarf2loc.c: Fix common/ includes.
9504 * dwarf2-frame.c: Fix common/ includes.
9505 * dwarf-index-cache.c: Fix common/ includes.
9506 * dtrace-probe.c: Fix common/ includes.
9507 * disasm-selftests.c: Fix common/ includes.
9508 * defs.h: Fix common/ includes.
9509 * csky-tdep.c: Fix common/ includes.
9510 * cp-valprint.c: Fix common/ includes.
9511 * cp-support.h: Fix common/ includes.
9512 * cp-support.c: Fix common/ includes.
9513 * corelow.c: Fix common/ includes.
9514 * completer.h: Fix common/ includes.
9515 * completer.c: Fix common/ includes.
9516 * compile/compile.c: Fix common/ includes.
9517 * compile/compile-loc2c.c: Fix common/ includes.
9518 * compile/compile-cplus-types.c: Fix common/ includes.
9519 * compile/compile-cplus-symbols.c: Fix common/ includes.
9520 * command.h: Fix common/ includes.
9521 * cli/cli-dump.c: Fix common/ includes.
9522 * cli/cli-cmds.c: Fix common/ includes.
9523 * charset.c: Fix common/ includes.
9524 * build-id.c: Fix common/ includes.
9525 * btrace.h: Fix common/ includes.
9526 * btrace.c: Fix common/ includes.
9527 * breakpoint.h: Fix common/ includes.
9528 * breakpoint.c: Fix common/ includes.
9530 (enum agent_op): Fix common/ includes.
9531 * ax-general.c (struct aop_map): Fix common/ includes.
9532 * ax-gdb.c: Fix common/ includes.
9533 * auxv.c: Fix common/ includes.
9534 * auto-load.c: Fix common/ includes.
9535 * arm-tdep.c: Fix common/ includes.
9536 * arch/riscv.c: Fix common/ includes.
9537 * arch/ppc-linux-common.c: Fix common/ includes.
9538 * arch/i386.c: Fix common/ includes.
9539 * arch/arm.c: Fix common/ includes.
9540 * arch/arm-linux.c: Fix common/ includes.
9541 * arch/arm-get-next-pcs.c: Fix common/ includes.
9542 * arch/amd64.c: Fix common/ includes.
9543 * arch/aarch64.c: Fix common/ includes.
9544 * arch/aarch64-insn.c: Fix common/ includes.
9545 * arch-utils.c: Fix common/ includes.
9546 * amd64-windows-tdep.c: Fix common/ includes.
9547 * amd64-tdep.c: Fix common/ includes.
9548 * amd64-sol2-tdep.c: Fix common/ includes.
9549 * amd64-obsd-tdep.c: Fix common/ includes.
9550 * amd64-nbsd-tdep.c: Fix common/ includes.
9551 * amd64-linux-tdep.c: Fix common/ includes.
9552 * amd64-linux-nat.c: Fix common/ includes.
9553 * amd64-fbsd-tdep.c: Fix common/ includes.
9554 * amd64-fbsd-nat.c: Fix common/ includes.
9555 * amd64-dicos-tdep.c: Fix common/ includes.
9556 * amd64-darwin-tdep.c: Fix common/ includes.
9557 * agent.c: Fix common/ includes.
9558 * ada-lang.h: Fix common/ includes.
9559 * ada-lang.c: Fix common/ includes.
9560 * aarch64-tdep.c: Fix common/ includes.
9562 2019-01-25 Tom Tromey <tom@tromey.com>
9564 * common/create-version.sh: Use common/version.h.
9566 2019-01-24 Pedro Alves <palves@redhat.com>
9568 * infrun.c (signal_stop, signal_print, signal_program)
9569 (signal_catch, signal_pass): Now arrays instead of pointers.
9570 (update_signals_program_target, do_target_resume)
9571 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9572 * linux-nat.c (linux_nat_target::pass_signals)
9573 (linux_nat_target::create_inferior, linux_nat_target::attach):
9575 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9576 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9577 * procfs.c (procfs_target::pass_signals): Adjust.
9578 * record-full.c (record_full_target::resume): Adjust.
9579 * remote.c (remote_target::pass_signals)
9580 (remote_target::program_signals): Adjust.
9581 * target-debug.h (target_debug_print_signals): Now takes a
9582 gdb::array_view as parameter. Adjust.
9583 * target.h (target_ops) <pass_signals, program_signals>: Replace
9584 pointer and length parameters with gdb::array_view.
9585 (target_pass_signals, target_program_signals): Likewise.
9586 * target-delegates.c: Regenerate.
9588 2019-01-24 Pedro Alves <palves@redhat.com>
9590 * common/forward-scope-exit.h
9591 (forward_scope_exit::forward_scope_exit): Pass arguments to
9592 m_bind_function directly, instead of creating a std::bind and
9595 2019-01-24 Alan Hayward <alan.hayward@arm.com>
9597 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9599 (pass_in_v_vfp_candidate): Likewise.
9601 2019-01-23 Tom Tromey <tom@tromey.com>
9602 Pedro Alves <palves@redhat.com>
9604 * regcache.c (class regcache_invalidator): Remove.
9605 (regcache::raw_write): Use make_scope_exit.
9607 2019-01-23 Tom Tromey <tom@tromey.com>
9609 * ui-out.h (class ui_out_emit_type): Update comment.
9611 2019-01-23 Tom Tromey <tom@tromey.com>
9613 * infrun.c (fetch_inferior_event): Update comment.
9615 2019-01-23 Tom Tromey <tom@tromey.com>
9616 Pedro Alves <palves@redhat.com>
9618 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9620 (fetch_inferior_event): Use SCOPE_EXIT.
9623 2019-01-23 Tom Tromey <tom@tromey.com>
9624 Pedro Alves <palves@redhat.com>
9626 * infrun.c (disable_thread_events): Delete.
9627 (stop_all_threads): Use SCOPE_EXIT.
9629 2019-01-23 Tom Tromey <tom@tromey.com>
9630 Pedro Alves <palves@redhat.com>
9632 * symfile.c: Include forward-scope-exit.h.
9633 (clear_symtab_users_cleanup): Replace forward declaration with
9634 a FORWARD_SCOPE_EXIT.
9635 (syms_from_objfile_1): Use the forward_scope_exit and
9636 gdb::optional instead of cleanup_function.
9637 (reread_symbols): Use the forward_scope_exit instead of
9639 (clear_symtab_users_cleanup): Remove function.
9641 2019-01-23 Tom Tromey <tom@tromey.com>
9642 Pedro Alves <palves@redhat.com>
9644 * linux-nat.c: Include scope-exit.h.
9645 (cleanup_target_stop): Remove.
9646 (linux_nat_target::static_tracepoint_markers_by_strid): Use
9649 2019-01-23 Tom Tromey <tom@tromey.com>
9650 Pedro Alves <palves@redhat.com>
9652 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9653 (call_function_by_hand_dummy): Use SCOPE_EXIT.
9655 2019-01-23 Tom Tromey <tom@tromey.com>
9656 Andrew Burgess <andrew.burgess@embecosm.com>
9657 Pedro Alves <palves@redhat.com>
9659 * infrun.c (fetch_inferior_event): Use scope_exit.
9660 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9661 * top.c (execute_command): Use scope_exit.
9662 * breakpoint.c (bpstat_do_actions): Use scope_exit.
9663 * utils.c (do_bpstat_clear_actions_cleanup)
9664 (make_bpstat_clear_actions_cleanup): Remove.
9666 2019-01-23 Tom Tromey <tom@tromey.com>
9667 Pedro Alves <palves@redhat.com>
9669 * infrun.c: Include "common/scope-exit.h"
9670 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9671 (wait_for_inferior): Use SCOPE_EXIT.
9672 (fetch_inferior_event): Use scope_exit.
9674 2019-01-23 Tom Tromey <tom@tromey.com>
9675 Pedro Alves <palves@redhat.com>
9677 * breakpoint.c (create_breakpoint): Remove cleanup.
9679 2019-01-23 Tom Tromey <tom@tromey.com>
9680 Andrew Burgess <andrew.burgess@embecosm.com>
9681 Pedro Alves <palves@redhat.com>
9683 2019-01-23 Pedro Alves <palves@redhat.com>
9685 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9687 2019-01-23 Pedro Alves <palves@redhat.com>
9688 Andrew Burgess <andrew.burgess@embecosm.com>
9690 * gdbthread.h: Include "common/forward-scope-exit.h".
9691 (scoped_finish_thread_state): Redefine custom class in terms of
9694 2019-01-23 Pedro Alves <palves@redhat.com>
9695 Andrew Burgess <andrew.burgess@embecosm.com>
9697 * common/forward-scope-exit.h: New file.
9699 2019-01-23 Pedro Alves <palves@redhat.com>
9700 Andrew Burgess <andrew.burgess@embecosm.com>
9701 Tom Tromey <tom@tromey.com>
9703 * common/scope-exit.h: New file.
9705 2019-01-23 Pedro Alves <palves@redhat.com>
9707 * common/preprocessor.h (ESC): Rename to ...
9708 (ESC_PARENS): ... this.
9709 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9710 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9712 2019-01-23 Tom Tromey <tom@tromey.com>
9714 * language.h (class scoped_switch_to_sym_language_if_auto):
9715 Initialize m_lang in both cases.
9717 2019-01-23 Alan Hayward <alan.hayward@arm.com>
9719 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9722 2019-01-22 Tom Tromey <tom@tromey.com>
9724 * corelow.c: Do not include sys/file.h.
9726 2019-01-22 Tom Tromey <tom@tromey.com>
9728 * tui/tui-wingeneral.h: Include gdb_curses.h.
9730 2019-01-22 Tom Tromey <tom@tromey.com>
9732 * source-cache.h (class source_cache) <get_source_lines,
9733 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9735 2019-01-22 Tom Tromey <tom@tromey.com>
9737 * remote-fileio.h (struct remote_target): Declare.
9739 2019-01-22 Tom Tromey <tom@tromey.com>
9741 * python/py-arch.c: Do not include py-ref.h.
9742 * python/py-bpevent.c: Do not include py-ref.h.
9743 * python/py-cmd.c: Do not include py-ref.h.
9744 * python/py-continueevent.c: Do not include py-ref.h.
9745 * python/py-event.h: Do not include py-ref.h.
9746 * python/py-evtregistry.c: Do not include py-ref.h.
9747 * python/py-finishbreakpoint.c: Do not include py-ref.h.
9748 * python/py-frame.c: Do not include py-ref.h.
9749 * python/py-framefilter.c: Do not include py-ref.h.
9750 * python/py-function.c: Do not include py-ref.h.
9751 * python/py-infevents.c: Do not include py-ref.h.
9752 * python/py-linetable.c: Do not include py-ref.h.
9753 * python/py-objfile.c: Do not include py-ref.h.
9754 * python/py-param.c: Do not include py-ref.h.
9755 * python/py-prettyprint.c: Do not include py-ref.h.
9756 * python/py-progspace.c: Do not include py-ref.h.
9757 * python/py-symbol.c: Do not include py-ref.h.
9758 * python/py-symtab.c: Do not include py-ref.h.
9759 * python/py-type.c: Do not include py-ref.h.
9760 * python/py-unwind.c: Do not include py-ref.h.
9761 * python/py-utils.c: Do not include py-ref.h.
9762 * python/py-value.c: Do not include py-ref.h.
9763 * python/py-varobj.c: Do not include py-ref.h.
9764 * python/py-xmethods.c: Do not include py-ref.h.
9765 * python/python.c: Do not include py-ref.h.
9766 * varobj.c: Do not include py-ref.h.
9768 2019-01-22 Tom Tromey <tom@tromey.com>
9770 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9773 2019-01-22 Tom Tromey <tom@tromey.com>
9775 * compile/compile-cplus-types.c: Remove a comment by #include.
9777 2019-01-22 Tom Tromey <tom@tromey.com>
9779 * compile/gcc-c-plugin.h: Include compile-internal.h.
9781 2019-01-22 Tom Tromey <tom@tromey.com>
9783 * stabsread.c (EXTERN): Do not define.
9784 (symnum, next_symbol_text_func, processing_gcc_compilation)
9785 (within_function, global_sym_chain, global_stabs)
9786 (previous_stab_code, this_object_header_files)
9787 (n_this_object_header_files)
9788 (n_allocated_this_object_header_files): Define.
9789 * stabsread.h (EXTERN): Never define. Use "extern".
9791 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9793 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9796 2019-01-21 Tom Tromey <tom@tromey.com>
9798 * ui-out.c: Fix includes.
9799 * tui/tui-source.c: Fix includes.
9800 * target.c: Fix includes.
9801 * remote.c: Fix includes.
9802 * regcache.c: Fix includes.
9803 * python/py-block.c: Fix includes.
9804 * printcmd.c: Fix includes.
9805 * or1k-tdep.c: Fix includes.
9806 * mi/mi-main.c: Fix includes.
9807 * m32r-tdep.c: Fix includes.
9808 * csky-tdep.c: Fix includes.
9809 * compile/compile-cplus-types.c: Fix includes.
9810 * cli/cli-interp.c: Fix includes.
9812 2019-01-21 Alan Hayward <alan.hayward@arm.com>
9814 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9817 2019-01-16 Tom Tromey <tom@tromey.com>
9819 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
9821 (struct objfile) <msymbols_range>: Move from top level.
9822 <msymbols>: New method.
9823 (class objfile_msymbols): Remove.
9824 * symtab.c (default_collect_symbol_completion_matches_break_on):
9826 * symmisc.c (dump_msymbols): Update.
9827 * stabsread.c (scan_file_globals): Update.
9828 * objc-lang.c (info_selectors_command, info_classes_command)
9829 (find_methods): Update.
9830 * minsyms.c (find_solib_trampoline_target): Update.
9831 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9832 * coffread.c (coff_symfile_read): Update.
9833 * ada-lang.c (ada_lookup_simple_minsym)
9834 (ada_collect_symbol_completion_matches): Update.
9836 2019-01-16 Tom Tromey <tom@tromey.com>
9838 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9839 type. Remove no-argument constructor.
9840 <iterator::operator++>: Simplify.
9842 <end>: Use minimal_symbol_count.
9844 2019-01-16 Tom Tromey <tom@tromey.com>
9846 * objfiles.h (struct objfile) <psymtabs>: New method.
9847 (class objfile_psymtabs): Remove.
9848 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9850 <range>: New method.
9851 (require_partial_symbols): Change return type.
9852 * psymtab.c (require_partial_symbols)
9853 (psym_expand_symtabs_matching): Update.
9854 * mdebugread.c (parse_partial_symbols): Update.
9855 * dbxread.c (dbx_end_psymtab): Update.
9857 2019-01-15 Tom Tromey <tom@tromey.com>
9859 * symtab.c (lookup_objfile_from_block)
9860 (lookup_symbol_in_objfile_symtabs)
9861 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9862 (find_line_symtab, info_sources_command)
9863 (default_collect_symbol_completion_matches_break_on)
9864 (make_source_files_completion_list): Update.
9865 * symmisc.c (print_objfile_statistics, dump_objfile)
9866 (maintenance_print_symbols, maintenance_info_symtabs)
9867 (maintenance_check_symtabs, maintenance_info_line_tables):
9869 * source.c (select_source_symtab)
9870 (forget_cached_source_info_for_objfile): Update.
9871 * objfiles.h (class objfile_compunits): Remove.
9872 (struct objfile) <compunits_range>: New typedef.
9873 (compunits): New method.
9874 * objfiles.c (objfile_relocate1): Update.
9875 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9876 * maint.c (count_symtabs_and_blocks): Update.
9877 * linespec.c (iterate_over_all_matching_symtabs): Update.
9878 * cp-support.c (add_symbol_overload_list_qualified): Update.
9879 * coffread.c (coff_symtab_read): Update.
9880 * ada-lang.c (add_nonlocal_symbols)
9881 (ada_collect_symbol_completion_matches)
9882 (ada_add_global_exceptions): Update.
9884 2019-01-15 Tom Tromey <tom@tromey.com>
9886 * progspace.h (program_space) <objfiles_safe_range>: New
9888 <objfiles_safe>: New method.
9889 * objfiles.h (class all_objfiles_safe): Remove.
9890 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9891 * jit.c (jit_inferior_exit_hook): Update.
9893 2019-01-17 Tom Tromey <tom@tromey.com>
9895 * progspace.h (program_space) <objfiles_range>: New typedef.
9896 <objfiles>: New method.
9897 <objfiles_head>: Rename from objfiles.
9898 (object_files): Update.
9899 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9900 * guile/scm-pretty-print.c
9901 (ppscm_find_pretty_printer_from_objfiles): Update.
9902 * guile/scm-objfile.c (gdbscm_objfiles): Update.
9903 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9905 * python/py-progspace.c (pspy_get_objfiles): Update.
9906 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9908 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9909 (objfpy_lookup_objfile_by_build_id): Update.
9910 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9911 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9913 * symtab.c (iterate_over_symtabs, matching_obj_sections)
9914 (expand_symtab_containing_pc, lookup_objfile_from_block)
9915 (lookup_static_symbol, basic_lookup_transparent_type)
9916 (find_pc_sect_compunit_symtab, find_symbol_at_address)
9917 (find_line_symtab, info_sources_command)
9918 (default_collect_symbol_completion_matches_break_on)
9919 (make_source_files_completion_list, find_main_name): Update.
9920 * symmisc.c (print_symbol_bcache_statistics)
9921 (print_objfile_statistics, maintenance_print_symbols)
9922 (maintenance_print_msymbols, maintenance_print_objfiles)
9923 (maintenance_info_symtabs, maintenance_check_symtabs)
9924 (maintenance_expand_symtabs, maintenance_info_line_tables):
9926 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9927 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9928 (map_overlay_command, unmap_overlay_command)
9929 (simple_overlay_update, expand_symtabs_matching)
9930 (map_symbol_filenames): Update.
9931 * symfile-debug.c (set_debug_symfile): Update.
9932 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9934 * source.c (select_source_symtab, forget_cached_source_info):
9936 * solib.c (solib_read_symbols): Update.
9937 * solib-spu.c (append_ocl_sos): Update.
9938 * psymtab.c (maintenance_print_psymbols)
9939 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9940 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9941 * printcmd.c (info_symbol_command): Update.
9942 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9944 * objfiles.h (class all_objfiles): Remove.
9945 * objfiles.c (have_partial_symbols, have_full_symbols)
9946 (have_minimal_symbols, qsort_cmp, update_section_map)
9947 (shared_objfile_contains_address_p)
9948 (default_iterate_over_objfiles_in_search_order): Update.
9949 * objc-lang.c (info_selectors_command, info_classes_command)
9950 (find_methods): Update.
9951 * minsyms.c (find_solib_trampoline_target): Update.
9952 * maint.c (maintenance_info_sections)
9953 (maintenance_translate_address, count_symtabs_and_blocks):
9955 * main.c (captured_main_1): Update.
9956 * linux-thread-db.c (try_thread_db_load_from_pdir)
9957 (has_libpthread): Update.
9958 * linespec.c (iterate_over_all_matching_symtabs)
9959 (search_minsyms_for_name): Update.
9960 * jit.c (jit_find_objf_with_entry_addr): Update.
9961 * hppa-tdep.c (find_unwind_entry)
9962 (hppa_lookup_stub_minimal_symbol): Update.
9963 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9965 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9966 (elf_gnu_ifunc_resolve_by_got): Update.
9967 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9968 * dwarf-index-write.c (save_gdb_index_command): Update.
9969 * cp-support.c (add_symbol_overload_list_qualified): Update.
9970 * breakpoint.c (create_overlay_event_breakpoint)
9971 (create_longjmp_master_breakpoint)
9972 (create_std_terminate_master_breakpoint)
9973 (create_exception_master_breakpoint): Update.
9974 * blockframe.c (find_pc_partial_function): Update.
9975 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9976 (ada_collect_symbol_completion_matches)
9977 (ada_add_global_exceptions): Update.
9979 2019-01-17 Tom Tromey <tom@tromey.com>
9981 * solib-target.c (lm_info_target_p): Remove typedef. Don't
9983 (solib_target_parse_libraries): Change return type.
9984 (library_list_start_segment, library_list_start_section)
9985 (library_list_end_library, library_list_start_library); Update.
9986 (solib_target_free_library_list): Remove.
9987 (solib_target_parse_libraries): Remove cleanup. Change return
9989 (solib_target_current_sos): Update.
9991 2019-01-17 Tom Tromey <tromey@bapiya>
9993 * valprint.c: Replace "the the" with "the".
9994 * symtab.c: Replace "the the" with "the".
9995 * solib.c: Replace "the the" with "the".
9996 * solib-dsbt.c: Replace "the the" with "the".
9997 * linespec.c: Replace "the the" with "the".
9998 * dwarf2loc.h: Replace "the the" with "the".
9999 * amd64-windows-tdep.c: Replace "the the" with "the".
10000 * aarch64-tdep.c: Replace "the the" with "the".
10002 2019-01-16 Keith Seitz <keiths@redhat.com>
10005 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10006 <builder>: Rename to ..
10007 <m_builder>: ... this and make private.
10008 (dwarf2_cu::get_builder): New method. Change all users of
10009 `builder' to use this method.
10010 (dwarf2_start_symtab): Move to ...
10011 (dwarf2_cu::start_symtab): ... here. Update all callers
10012 (setup_type_unit_groups): Move to ...
10013 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10015 (dwarf2_cu::reset_builder): New method.
10016 (process_full_compunit, process_full_type_unit): Use
10017 dwarf2_cu::reset_builder.
10018 (follow_die_offset): Record the ancestor CU if it is different
10019 from the followed DIE's CU.
10020 (follow_die_sig_1): Likewise.
10022 2019-01-15 Tom Tromey <tom@tromey.com>
10024 * remote.c (class remote_state) <buf>: Now a char_vector.
10025 <buf_size>: Remove.
10026 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10028 (remote_target::getpkt_or_notif_sane_1)
10029 (remote_target::getpkt_sane)
10030 (remote_target::getpkt_or_notif_sane): Likewise.
10031 (class remote_target) <putpkt>: New overload.
10032 (remote_target::read_frame): Change type of "buf_p". Remove
10033 sizeof_p parameter.
10034 (packet_ok): New overload.
10035 (packet_check_result): New overload.
10038 2019-01-14 Tom Tromey <tom@tromey.com>
10040 * remote-notif.c (handle_notification, remote_notif_ack)
10041 (remote_notif_parse): Make "buf" const.
10042 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10044 (remote_notif_parse, remote_notif_ack, handle_notification):
10046 * remote.c (remote_notif_stop_parse): Make "buf" const.
10047 (remote_target::remote_parse_stop_reply): Make "buf" const.
10048 (remote_notif_stop_ack): Make "buf" const.
10050 2019-01-14 Tom Tromey <tom@tromey.com>
10052 * remote.c (remote_console_output): Make parameter const.
10054 2019-01-14 Tom Tromey <tom@tromey.com>
10056 * target-debug.h (target_debug_print_signals): Constify.
10057 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10058 * procfs.c (procfs_target::pass_signals): Update.
10059 * linux-nat.c (linux_nat_target::pass_signals): Update.
10060 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10061 * target-delegates.c: Rebuild.
10062 * remote.c (remote_target::program_signals): Update.
10063 (remote_target::pass_signals): Update.
10064 * target.c (target_pass_signals): Constify argument.
10065 (target_program_signals): Likewise.
10066 * target.h (struct target_ops) <pass_signals, program_signals>:
10068 (target_pass_signals, target_program_signals): Constify argument.
10070 2019-01-14 Tom Tromey <tom@tromey.com>
10073 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10075 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10077 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10079 * rs6000-tdep.c: Include reggroups.h.
10080 (IS_V_ALIAS_PSEUDOREG): Define.
10081 (rs6000_register_name): Return names for the "vX" aliases.
10082 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10083 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10084 aliases. Call default_register_reggroup_p for all other
10086 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10088 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10089 Handle "vX" aliases.
10090 (v_alias_pseudo_register_collect): New function.
10091 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10092 (rs6000_gdbarch_init): Initialize "vX" aliases as
10093 pseudo-registers. Restore registration of
10094 rs6000_pseudo_register_reggroup_p with
10095 set_tdesc_pseudo_register_reggroup_p.
10097 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10099 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10100 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10101 set_gdbarch_num_pseudo_regs.
10103 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10105 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10106 Remove arg prefixname, add do_set and do_show.
10107 Add member functions set_list and show_list.
10108 * cli/cli-style.c (class cli_style_option): Update accordingly.
10109 (style_set_list): Move to file scope.
10110 (style_show_list): Likewise.
10111 (set_style): Call help_list.
10112 (show_style): Call cmd_show_list.
10113 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10114 Update to use the new macro.
10116 2019-10-12 Joel Brobecker <brobecker@adacore.com>
10118 * ada-lang.c (_initialize_ada_language): Expand the help text
10119 for the "catch exception" command.
10121 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10123 * symtab.c (matching_obj_sections): Initialize obj,
10124 declare it closer to its usage.
10126 2019-01-10 Tom Tromey <tom@tromey.com>
10128 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10129 (basic_inf_threads_range): Remove.
10130 (inf_threads_range, inf_non_exited_threads_range)
10131 (safe_inf_threads_range): Use next_adapter.
10133 2019-01-10 Keith Seitz <keiths@redhat.com>
10137 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10138 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10140 2019-01-10 Keith Seitz <keiths@redhat.com>
10144 * dictionary.c (pending_to_vector): Remove.
10145 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10146 Remove _1 suffix, replacing functions of the same name. Update
10148 (dict_create_hashed, dict_create_hashed_expandable)
10149 (dict_create_linear, dict_create_linear_expandable, dict_free)
10150 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10151 Make functions static.
10153 2019-01-10 Keith Seitz <keiths@redhat.com>
10157 * dictionary.h (struct dictionary): Replace declaration with
10159 (dict_create_hashed, dict_create_hashed_expandable)
10160 (dict_create_linear, dict_create_linear_expandable)
10161 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10162 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10163 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10164 taking multidictionary argument.
10165 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10166 * block.h (struct block) <dict>: Change to multidictionary
10167 and rename `multidict'.
10168 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10169 symmisc.c: Update all dictionary references to multidictionary.
10171 2019-01-10 Keith Seitz <keiths@redhat.com>
10175 * dictionary.c: Include unordered_map.
10176 (pending_to_vector): New function.
10177 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10178 Rewrite the non-"_1" functions to take vector instead
10180 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10181 "new" _1 versions of the same name.
10182 (multidictionary): Define.
10183 (std::hash<enum language): New definition.
10184 (collate_pending_symbols_by_language, mdict_create_hashed)
10185 (mdict_create_hashed_expandable, mdict_create_linear)
10186 (mdict_create_linear_expandable, mdict_free)
10187 (find_language_dictionary, create_new_language_dictionary)
10188 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10189 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10190 (mdict_size, mdict_empty): New functions.
10191 * dictionary.h (mdict_iterator): Define.
10193 2019-01-10 Pedro Alves <palves@redhat.com>
10195 * breakpoint.c (read_uploaded_action)
10196 (create_tracepoint_from_upload): Adjust to use
10197 gdb::unique_xmalloc_ptr.
10198 * ctf.c (ctf_write_uploaded_tp):
10199 (SET_ARRAY_FIELD): Use emplace_back.
10200 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10201 * tracefile-tfile.c (tfile_write_uploaded_tp):
10202 * tracepoint.c (parse_tracepoint_definition): Adjust to use
10203 gdb::unique_xmalloc_ptr.
10204 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10205 at_string, cond_string, cmd_strings>: Replace char pointers
10206 with gdb::unique_xmalloc_ptr.
10208 2019-01-10 Pedro Alves <palves@redhat.com>
10210 * solib-target.c (library_list_start_library): Don't xstrdup name.
10212 2019-01-10 Pedro Alves <palves@redhat.com>
10214 * mdebugread.c (parse_partial_symbols): Use
10215 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10217 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10219 * linux-fork.c (scoped_switch_fork_info)
10220 <~scoped_switch_fork_info>: Fix incorrect variable name.
10222 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10224 * linux-fork.c (scoped_switch_fork_info)
10225 <scoped_switch_fork_info>: Make explicit.
10226 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10228 2019-01-10 Tom Tromey <tom@tromey.com>
10230 * objfiles.h (objfile::reset_psymtabs): Update.
10231 * objfiles.c (objfile::objfile): Update.
10232 * psymtab.h (psymtab_storage::obstack): Update.
10233 (psymtab_storage::m_obstack): Use gdb::optional.
10234 (class psymtab_storage): Update comment. Remove objfile
10236 * psymtab.c (psymtab_storage::psymtab_storage): Update.
10238 2019-01-10 Tom Tromey <tom@tromey.com>
10240 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10241 <free_psymtabs>: Now private.
10242 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10243 (allocate_psymtab): Use new method.
10245 2019-01-10 Tom Tromey <tom@tromey.com>
10247 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10248 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10249 * mdebugread.c (parse_partial_symbols): Use
10250 allocate_dependencies.
10251 * dwarf2read.c (dwarf2_create_include_psymtab): Use
10252 allocate_dependencies.
10253 (process_psymtab_comp_unit_reader)
10254 (build_type_psymtab_dependencies): Likewise.
10255 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10257 2019-01-10 Tom Tromey <tom@tromey.com>
10259 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10260 PSYMBOL_SET_LANGUAGE.
10261 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10263 2019-01-10 Tom Tromey <tom@tromey.com>
10265 * psymtab.h (psymtab_storage::obstack): New method.
10266 <m_obstack>: Rename from obstack; now private.
10267 * psymtab.c (psymtab_storage): Update.
10268 * dwarf2read.c (create_addrmap_from_index)
10269 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10272 2019-01-10 Tom Tromey <tom@tromey.com>
10274 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10275 * objfiles.h (objfile::reset_psymtabs): New method.
10277 2019-01-10 Tom Tromey <tom@tromey.com>
10279 * symmisc.c (print_symbol_bcache_statistics): Update.
10280 (print_objfile_statistics): Update.
10281 * symfile.c (reread_symbols): Update.
10282 * psymtab.h (class psymtab_storage): New.
10283 * psymtab.c (psymtab_storage): New constructor.
10284 (~psymtab_storage): New destructor.
10285 (require_partial_symbols): Update.
10286 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10287 (find_pc_sect_psymtab, find_pc_sect_psymbol)
10288 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10289 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10290 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10291 (start_psymtab_common, end_psymtab_common)
10292 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10293 (allocate_psymtab): Update.
10294 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10296 (dump_psymtab_addrmap, maintenance_print_psymbols)
10297 (maintenance_check_psymtabs): Update.
10298 (class objfile_psymtabs): Move to objfiles.h.
10299 * psympriv.h (discard_psymtab): Now inline.
10300 (psymtab_discarder::psymtab_discarder): Update.
10301 (psymtab_discarder::~psymtab_discarder): Update.
10302 (ALL_OBJFILE_PSYMTABS): Rewrite.
10303 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10304 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10306 <partial_symtabs>: New field.
10307 (class objfile_psymtabs): Move from psymtab.h. Update.
10308 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10310 (objfile::~objfile): Don't destroy psymbol_cache.
10311 * mdebugread.c (parse_partial_symbols): Update.
10312 * dwarf2read.c (create_addrmap_from_index)
10313 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10314 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10315 (add_partial_subprogram, dwarf2_ranges_read): Update.
10316 * dwarf-index-write.c (write_address_map)
10317 (write_one_signatured_type, recursively_write_psymbols)
10318 (class debug_names, class debug_names, write_psymtabs_to_index):
10321 2019-01-10 Tom Tromey <tom@tromey.com>
10323 * symtab.h (SYMBOL_SET_NAMES): Update.
10324 (symbol_set_names): Update.
10325 (MSYMBOL_SET_NAMES): Update.
10326 * symtab.c (symbol_set_names): Change argument to be an
10327 objfile_per_bfd_storage.
10328 * psymtab.c (add_psymbol_to_bcache): Update.
10329 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10331 2019-01-10 Tom Tromey <tom@tromey.com>
10333 * symtab.c (create_demangled_names_hash): Change argument to be an
10334 objfile_per_bfd_storage.
10335 (symbol_set_names): Update.
10337 2019-01-10 Tom Tromey <tom@tromey.com>
10339 * xcoffread.c (xcoff_initial_scan): Unconditionally call
10341 * psymtab.c (init_psymbol_list): Do nothing if already called.
10342 * psympriv.h (init_psymbol_list): Add comment.
10343 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10345 * dbxread.c (dbx_symfile_read): Unconditionally call
10348 2019-01-10 Tom Tromey <tom@tromey.com>
10350 * xcoffread.c (scan_xcoff_symtab): Update.
10351 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10353 * mdebugread.c (parse_partial_symbols)
10354 (handle_psymbol_enumerators): Update.
10355 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10356 * dbxread.c (read_dbx_symtab): Update.
10357 * psympriv.h (psymbol_placement): New enum.
10358 (add_psymbol_to_list): Update.
10360 2019-01-10 Tom Tromey <tom@tromey.com>
10362 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10363 static_psymbols parameters.
10364 (scan_xcoff_symtab): Update.
10365 * psymtab.c (start_psymtab_common): Remove global_psymbols and
10366 static_psymbols parameters.
10367 * psympriv.h (start_psymtab_common): Update.
10368 * mdebugread.c (parse_partial_symbols): Update.
10369 * dwarf2read.c (create_partial_symtab): Update.
10370 * dbxread.c (read_dbx_symtab): Update.
10371 (start_psymtab): Remove global_psymbols and static_psymbols
10374 2019-01-10 Tom Tromey <tom@tromey.com>
10376 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10377 * psymtab.c (allocate_psymtab): Add comment.
10378 * psympriv.h (allocate_psymtab): Add comment.
10379 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10381 * dbxread.c (dbx_end_psymtab): Remove some initializations.
10383 2019-01-10 Tom Tromey <tom@tromey.com>
10385 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10387 * mipsread.c: Include mdebugread.h.
10388 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10390 * elfread.c: Include mdebugread.h.
10392 2019-01-09 Tom Tromey <tom@tromey.com>
10394 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10395 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10396 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10397 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10398 (psym_lookup_symbol, psym_find_last_source_symtab)
10399 (psym_forget_cached_source_info, psym_print_stats)
10400 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10401 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10402 (psym_map_matching_symbols, psym_expand_symtabs_matching)
10403 (psym_find_compunit_symtab_by_address)
10404 (maintenance_print_psymbols, maintenance_info_psymtabs)
10405 (maintenance_check_psymtabs): Use ranged for.
10406 * psymtab.h (class objfile_psymtabs): New.
10407 (require_partial_symbols): Return objfile_psymtabs.
10408 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10410 2019-01-09 Tom Tromey <tom@tromey.com>
10412 * symfile.c (overlay_invalidate_all, find_pc_overlay)
10413 (find_pc_mapped_section, list_overlays_command)
10414 (map_overlay_command, unmap_overlay_command)
10415 (simple_overlay_update): Use all_objfiles.
10416 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10417 * printcmd.c (info_symbol_command): Use all_objfiles.
10418 * objfiles.h (ALL_OBJSECTIONS): Remove.
10419 * maint.c (maintenance_translate_address): Use all_objfiles.
10420 * gcore.c (gcore_create_callback): Use all_objfiles.
10421 (objfile_find_memory_regions): Likewise.
10423 2019-01-09 Tom Tromey <tom@tromey.com>
10425 * symtab.c (find_line_symtab, info_sources_command)
10426 (make_source_files_completion_list): Use objfile_compunits.
10427 * source.c (select_source_symtab): Use objfile_compunits.
10428 * objfiles.h (struct objfile): Update comment.
10429 (ALL_OBJFILES): Remove.
10430 (ALL_FILETABS): Remove.
10431 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10434 2019-01-09 Tom Tromey <tom@tromey.com>
10436 * symmisc.c (print_objfile_statistics, dump_objfile)
10437 (maintenance_print_symbols): Use compunit_filetabs.
10438 * source.c (forget_cached_source_info_for_objfile): Use
10440 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10441 (ALL_FILETABS): Use compunit_filetabs.
10442 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10443 * coffread.c (coff_symtab_read): Use compunit_filetabs.
10445 2019-01-09 Tom Tromey <tom@tromey.com>
10447 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10448 (compunit_filetabs): New.
10449 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10451 (info_sources_command, make_source_files_completion_list): Remove
10453 * symmisc.c (print_objfile_statistics, dump_objfile)
10454 (maintenance_print_symbols): Remove declaration.
10455 (maintenance_info_symtabs): Use compunit_filetabs.
10456 (maintenance_info_line_tables): Likewise.
10457 * source.c (select_source_symtab): Change local variable name.
10458 (forget_cached_source_info_for_objfile): Remove declaration.
10459 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10460 * objfiles.c (objfile_relocate1): Remove declaration.
10461 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10463 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10464 * coffread.c (coff_symtab_read): Remove declaration.
10465 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10468 2019-01-09 Tom Tromey <tom@tromey.com>
10470 * symtab.c (lookup_objfile_from_block)
10471 (find_pc_sect_compunit_symtab, search_symbols)
10472 (default_collect_symbol_completion_matches_break_on): Use
10474 * objfiles.h (ALL_COMPUNITS): Remove.
10475 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10476 * cp-support.c (add_symbol_overload_list_qualified): Use
10478 * ada-lang.c (ada_collect_symbol_completion_matches)
10479 (ada_add_global_exceptions): Use objfile_compunits.
10481 2019-01-09 Tom Tromey <tom@tromey.com>
10483 * source.c (select_source_symtab)
10484 (forget_cached_source_info_for_objfile): Remove declaration.
10485 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10487 * maint.c (count_symtabs_and_blocks): Remove declaration.
10488 * cp-support.c (add_symbol_overload_list_qualified): Remove
10490 * coffread.c (coff_symtab_read): Remove declaration.
10491 * symtab.c (lookup_symbol_in_objfile_symtabs)
10492 (basic_lookup_transparent_type_1): Use objfile_compunits.
10493 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10494 (info_sources_command, search_symbols)
10495 (default_collect_symbol_completion_matches_break_on)
10496 (make_source_files_completion_list): Remove declaration.
10497 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10498 (ada_collect_symbol_completion_matches)
10499 (ada_add_global_exceptions): Remove declaration.
10500 * linespec.c (iterate_over_all_matching_symtabs): Use
10502 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10503 (class objfile_compunits): New.
10504 (ALL_COMPUNITS): Use objfile_compunits.
10505 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10506 (maintenance_check_symtabs, maintenance_info_line_tables): Use
10508 * objfiles.c (objfile_relocate1): Use objfile_compunits.
10510 2019-01-09 Tom Tromey <tom@tromey.com>
10512 * symtab.c (search_symbols)
10513 (default_collect_symbol_completion_matches_break_on): Use
10515 * ada-lang.c (ada_lookup_simple_minsym)
10516 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10517 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10518 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10520 * coffread.c (coff_symfile_read): Use objfile_msymbols.
10521 * symmisc.c (dump_msymbols): Use objfile_msymbols.
10522 * objc-lang.c (find_methods): Use objfile_msymbols.
10523 (info_selectors_command, info_classes_command): Likewise.
10524 * stabsread.c (scan_file_globals): Use objfile_msymbols.
10525 * objfiles.h (class objfile_msymbols): New.
10526 (ALL_OBJFILE_MSYMBOLS): Remove.
10527 (ALL_MSYMBOLS): Remove.
10529 2019-01-09 Tom Tromey <tom@tromey.com>
10531 * common/next-iterator.h (next_adapter): Add Iterator template
10533 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10534 (class all_objfiles_safe): New.
10535 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10536 * objfiles.c (put_objfile_before): Update comment.
10537 (add_separate_debug_objfile): Likewise.
10538 (free_all_objfiles): Use all_objfiles_safe.
10539 (objfile_purge_solibs): Likewise.
10541 2019-01-09 Tom Tromey <tom@tromey.com>
10543 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10544 (expand_symtab_containing_pc, lookup_static_symbol)
10545 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10546 (find_symbol_at_address, find_line_symtab, find_main_name): Use
10548 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10549 * breakpoint.c (create_overlay_event_breakpoint)
10550 (create_longjmp_master_breakpoint)
10551 (create_std_terminate_master_breakpoint)
10552 (create_exception_master_breakpoint): Use all_objfiles.
10553 * linux-thread-db.c (try_thread_db_load_from_pdir)
10554 (has_libpthread): Use all_objfiles.
10555 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10556 * linespec.c (iterate_over_all_matching_symtabs)
10557 (search_minsyms_for_name): Use all_objfiles.
10558 * maint.c (maintenance_info_sections): Use all_objfiles.
10559 * main.c (captured_main_1): Use all_objfiles.
10560 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10561 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10562 * guile/scm-pretty-print.c
10563 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10564 * solib-spu.c (append_ocl_sos): Use all_objfiles.
10565 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10566 (maintenance_print_msymbols): Use all_objfiles.
10567 * source.c (select_source_symtab): Use all_objfiles.
10568 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10569 * symfile.c (remove_symbol_file_command)
10570 (expand_symtabs_matching, map_symbol_filenames): Use
10572 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10574 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10575 * objc-lang.c (find_methods): Use all_objfiles.
10576 * objfiles.c (have_partial_symbols, have_full_symbols)
10577 (have_minimal_symbols, qsort_cmp)
10578 (default_iterate_over_objfiles_in_search_order): Use
10580 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10581 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10582 (maintenance_check_psymtabs): Use all_objfiles.
10583 (ALL_PSYMTABS): Remove.
10584 * compile/compile-object-run.c (do_module_cleanup): Use
10586 * blockframe.c (find_pc_partial_function): Use all_objfiles.
10587 * cp-support.c (add_symbol_overload_list_qualified): Use
10589 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10591 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10592 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10594 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10595 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10596 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10598 * solib.c (solib_read_symbols): Use all_objfiles
10600 2019-01-09 Tom Tromey <tom@tromey.com>
10602 * probe.c (parse_probes_in_pspace): Use all_objfiles.
10603 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10605 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10606 * symmisc.c (print_symbol_bcache_statistics)
10607 (print_objfile_statistics, maintenance_print_objfiles)
10608 (maintenance_info_symtabs, maintenance_check_symtabs)
10609 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10611 * source.c (forget_cached_source_info): Use all_objfiles.
10612 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10613 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10614 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10615 * objfiles.c (update_section_map): Use all_objfiles.
10616 (shared_objfile_contains_address_p): Likewise.
10617 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10618 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10620 2019-01-09 Tom Tromey <tom@tromey.com>
10622 * common/next-iterator.h: New file.
10623 * objfiles.h (class all_objfiles): New.
10624 (struct objfile_iterator): New.
10626 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10628 * NEWS: Move the description of the changed "frame", "select-frame",
10629 and "info frame" commands to the Changed commands section.
10631 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
10633 * gdbtypes.c (check_stub_method_group): Remove handling of old
10635 * linespec.c (find_methods): Likewise.
10636 * stabsread.c (read_member_functions): Likewise.
10637 * valops.c (search_struct_method): Likewise.
10638 (value_struct_elt_for_reference): Likewise.
10639 * NEWS: Mention this change.
10641 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
10643 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10644 print_source_lines.
10645 * source.c (print_source_lines_base): Update line number check.
10646 (print_source_lines): New function.
10647 (source_lines_range::source_lines_range): New function.
10648 * source.h (class source_lines_range): New class.
10649 (print_source_lines): New declaration.
10651 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10653 * linespec.c (linespec_state_destructor): Free self->canonical_names.
10655 2019-01-08 Tom Tromey <tom@tromey.com>
10656 Simon Marchi <simon.marchi@ericsson.com>
10659 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10660 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10661 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10662 * f-exp.y (DOLLAR_VARIABLE): Likewise.
10663 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10664 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10666 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10668 * source.c (select_source_symtab): Move header comment to
10669 declaration in source.h.
10670 (forget_cached_source_info_for_objfile): Likewise.
10671 (forget_cached_source_info): Likewise.
10672 (identify_source_line): Likewise.
10673 * source.h (identify_source_line): Move declaration from symtab.h
10674 and add comment from source.c
10675 (print_source_lines): Likewise.
10676 (forget_cached_source_info_for_objfile): Likewise.
10677 (forget_cached_source_info): Likewise.
10678 (select_source_symtab): Likewise.
10679 (enum print_source_lines_flag): Move definition from symtab.h.
10680 * symtab.h (identify_source_line): Move declaration to source.h.
10681 (print_source_lines): Likewise.
10682 (forget_cached_source_info_for_objfile): Likewise.
10683 (forget_cached_source_info): Likewise.
10684 (select_source_symtab): Likewise.
10685 (enum print_source_lines_flag): Move definition to source.h.
10686 * tui/tui-hooks.c: Add 'source.h' include.
10688 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10690 * source.c (print_source_lines_base): Handle requests to print
10691 reverse line number sequences, and guard against empty lines
10694 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10696 * source.c (print_source_lines_base): Fix skip of '\r' if next
10699 2019-01-06 Tom Tromey <tom@tromey.com>
10701 * c-exp.y (struct c_parse_state) <macro_original_text,
10702 expansion_obstack>: New member.
10703 (macro_original_text, expansion_obstack): Remove globals.
10704 (scan_macro_expansion, scanning_macro_expansion)
10705 (finished_macro_expansion): Update.
10706 (scan_macro_cleanup): Remove.
10707 (yylex, c_parse): Update.
10709 2019-01-06 Tom Tromey <tom@tromey.com>
10711 * c-exp.y (struct c_parse_state) <strings>: New member.
10712 (operator_stoken): Update.
10714 2019-01-06 Tom Tromey <tom@tromey.com>
10716 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
10717 (union type_stack_elt) <typelist_val>: Now a pointer to
10719 (type_stack_cleanup): Don't declare.
10720 (push_typelist): Update.
10721 * parse.c (pop_typelist): Return a std::vector.
10722 (push_typelist): Take a std::vector.
10723 (follow_types): Update. Do not free args.
10724 (type_stack_cleanup): Remove.
10725 * c-exp.y (struct c_parse_state): New.
10726 (cpstate): New global.
10727 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10728 (nonempty_typelist): Update.
10729 (func_mod): Create a new vector.
10730 (c_parse): Create a c_parse_state.
10731 (check_parameter_typelist): Do not delete params.
10732 (function_method): Update. Do not delete type_list.
10734 2019-01-06 Tom Tromey <tom@tromey.com>
10737 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10739 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10740 (print_return_value): Likewise.
10742 2019-01-05 Tom Tromey <tom@tromey.com>
10744 * contrib/cleanup_check.py: Remove.
10745 * contrib/gcc-with-excheck: Remove.
10746 * contrib/exsummary.py: Remove.
10747 * contrib/excheck.py: Remove.
10749 2019-01-05 Joel Brobecker <brobecker@adacore.com>
10751 * thread.c (delete_thread_1): Add gdb_assert that THR is not
10752 NULL. Initialize tpprev to NULL instead of assigning it
10753 to NULL on the next statement.
10754 * windows-nat.c (windows_delete_thread): Remove check for
10755 main_thread_id before printing thread exit notifications.
10756 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10757 Remove thread ID check against main_thread_id.
10758 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10759 windows_delete_thread.
10760 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10762 2019-01-04 Tom Tromey <tom@tromey.com>
10764 * compile/compile.c (_initialize_compile): Use upper case for
10765 metasyntactic variables.
10766 * symmisc.c (_initialize_symmisc): Use upper case for
10767 metasyntactic variables.
10768 * psymtab.c (_initialize_psymtab): Use upper case for
10769 metasyntactic variables.
10770 * demangle.c (demangle_command): Use upper case for metasyntactic
10772 (_initialize_demangler): Likewise.
10773 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10776 2019-01-03 Tom Tromey <tom@tromey.com>
10778 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10780 2019-01-03 Tom Tromey <tom@tromey.com>
10782 * python/py-symtab.c (salpy_str): Update.
10783 (struct salpy_sal_object) <symtab>: Now a PyObject.
10784 (salpy_dealloc): Update.
10785 (del_objfile_sal): Use gdbpy_ref.
10787 2019-01-03 Tom Tromey <tom@tromey.com>
10789 * python/py-type.c (convert_field): Use new_reference. Return
10791 (make_fielditem): Return gdbpy_ref.
10792 (typy_fields): Update.
10793 (typy_getitem): Update.
10794 (field_name): Return gdbpy_ref. Use new_reference.
10795 (typy_iterator_iternext): Update.
10797 2019-01-03 Tom Tromey <tom@tromey.com>
10799 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10801 2019-01-03 Tom Tromey <tom@tromey.com>
10803 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10804 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10805 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10806 (pspy_set_frame_filters, pspy_set_frame_unwinders)
10807 (pspy_set_type_printers): Likewise.
10808 * python/py-function.c (fnpy_init): Use gdbpy_ref.
10809 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10810 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10811 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10812 (objfpy_set_type_printers): Likewise.
10814 2019-01-03 Tom Tromey <tom@tromey.com>
10816 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10817 (gdbpy_print_stack): Use gdbpy_err_fetch.
10818 * python/python-internal.h (class gdbpy_err_fetch): New class.
10819 (class gdbpy_enter) <m_error_type, m_error_value,
10820 m_error_traceback>: Remove.
10821 <m_error>: New member.
10822 (gdbpy_exception_to_string): Don't declare.
10823 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10824 * python/py-value.c (convert_value_from_python): Use
10826 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10827 gdbpy_exception_to_string.
10828 (gdbpy_handle_exception): Use gdbpy_err_fetch.
10829 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10832 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10834 * linux-nat.c (delete_lwp_cleanup): Delete.
10835 (struct lwp_deleter): New struct.
10836 (lwp_info_up): New typedef.
10837 (linux_nat_target::follow_fork): Delete cleanup, and make use of
10840 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10842 * linux-fork.c (class scoped_switch_fork_info): New class.
10843 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10845 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10847 * valops.c (find_overload_match): Remove use of null_cleanup, and
10848 calls to do_cleanups.
10850 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10852 * compile/compile-cplus-types.c
10853 (compile_cplus_instance::decl_name): Handle changes to
10855 * cp-support.c (cp_func_name): Update header comment, update
10857 * cp-support.h (cp_func_name): Update return type in declaration.
10858 * valops.c (find_overload_match): Move temp_func local to top
10859 level of function and change its type. Use temp_func to hold and
10860 delete temporary string obtained from cp_func_name.
10862 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10864 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10865 gdb::char_vector, remove cleanup, and update uses of `msg`.
10867 2019-01-03 Jim Wilson <jimw@sifive.com>
10869 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10871 2019-01-02 Tom Tromey <tom@tromey.com>
10873 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10874 (tdesc_parse_xml): Remove cleanups.
10875 * target-descriptions.h (make_cleanup_free_target_description):
10877 (target_desc_deleter): New struct.
10878 (target_desc_up): New typedef.
10879 * target-descriptions.c (target_desc_deleter::operator()): Rename
10880 from free_target_description.
10881 (make_cleanup_free_target_description): Remove.
10883 2019-01-02 Tom Tromey <tom@tromey.com>
10885 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
10886 constructor, destructor.
10887 (linespec_parser): Remove typedef.
10888 (~linespec_parser): Rename from linespec_parser_delete.
10889 (linespec_lex_to_end, linespec_complete_label)
10890 (linespec_complete): Update.
10891 (decode_line_full): Remove cleanups.
10892 (decode_line_1): Update.
10894 2019-01-02 Tom Tromey <tom@tromey.com>
10896 * python/python-internal.h (inferior_to_inferior_object): Change
10898 * python/py-exitedevent.c (create_exited_event_object): Update.
10899 * python/py-inferior.c (inferior_to_inferior_object): Return
10901 (python_new_inferior, python_inferior_deleted)
10902 (thread_to_thread_object, delete_thread_object)
10903 (build_inferior_list, gdbpy_selected_inferior): Update.
10904 * python/py-infthread.c (create_thread_object): Update. Also fail
10905 if inferior_to_inferior_object fails.
10907 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
10909 * inferior.h (class inferior) <displaced_step_state>: New field.
10910 * infrun.h (struct displaced_step_state): Move here from
10911 infrun.c. Initialize fields, add constructor.
10912 <inf>: Remove field.
10913 <reset>: New method.
10914 * infrun.c (struct displaced_step_inferior_state): Move to
10916 (displaced_step_inferior_states): Remove.
10917 (get_displaced_stepping_state): Adust.
10918 (displaced_step_in_progress_any_inferior): Adjust.
10919 (displaced_step_in_progress_thread): Adjust.
10920 (displaced_step_in_progress): Adjust.
10921 (add_displaced_stepping_state): Remove.
10922 (get_displaced_step_closure_by_addr): Adjust.
10923 (remove_displaced_stepping_state): Remove.
10924 (infrun_inferior_exit): Call displaced_step_state.reset.
10925 (use_displaced_stepping): Don't check for NULL.
10926 (displaced_step_prepare_throw): Call
10927 get_displaced_stepping_state.
10928 (displaced_step_fixup): Don't check for NULL.
10929 (prepare_for_detach): Don't check for NULL.
10931 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10933 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10934 in case of call that did not complete.
10936 2019-01-02 Andrey Utkin <autkin@undo.io>
10938 * symfile.c (find_separate_debug_file): Fix search of debug files for
10941 2019-01-02 Tom Tromey <tom@tromey.com>
10943 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10945 * python/py-frame.c (frapy_older): Remove cast.
10946 (frapy_newer): Likewise.
10947 * python/py-breakpoint.c (local_setattro): Remove cast.
10948 * python/py-arch.c (archpy_name): Remove local variable.
10949 * python/py-type.c (gdbpy_lookup_type): Remove cast.
10951 2019-01-02 Joel Brobecker <brobecker@adacore.com>
10953 * unittests/basic_string_view/element_access/char/empty.cc:
10954 Fix year range in copyright header.
10956 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
10958 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10960 <operator==>: Update with for removed field.
10962 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10963 <isa_features>: ...this.
10964 <abi_features>: New field.
10965 (riscv_isa_flen): Update comment.
10966 (riscv_abi_xlen): New declaration.
10967 (riscv_abi_flen): New declaration.
10968 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10970 (riscv_abi_xlen): New function.
10971 (riscv_isa_flen): Update to get answer from isa_features.
10972 (riscv_abi_flen): New function.
10973 (riscv_has_fp_abi): Update to get answer from abi_features.
10974 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10976 (riscv_call_info) <xlen, flen>: Update comment.
10977 (riscv_call_arg_struct): Remove invalid assertions
10978 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10980 (riscv_gdbarch_init): Gather isa features and abi features
10981 separately, ensure both match on the gdbarch when reusing an old
10982 gdbarch. Relax an error check to allow 32-bit abi float to run on
10983 a target with 64-bit float hardware.
10985 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10987 * source.c (search_command_helper): Stop reverse search
10988 when line 1 has been searched.
10990 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10992 * record-full.c (record_full_base_target::close): Rewrite
10993 record_full_core_buf_list free logic.
10995 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10997 * break-catch-syscall.c (print_one_catch_syscall): xfree
11000 2019-01-01 Joel Brobecker <brobecker@adacore.com>
11002 * top.c (print_gdb_version): Update Copyright year in version
11005 2019-01-01 Joel Brobecker <brobecker@adacore.com>
11007 Update copyright year range in all GDB files.
11009 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
11011 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11013 For older changes see ChangeLog-2018.
11019 version-control: never
projects / deliverable / binutils-gdb.git / blob