gdb/ChangeLog

   1 2019-03-14  Pedro Alves  <palves@redhat.com>
   2             Tom Tromey  <tromey@adacore.com>
   3
   4         * tui/tui-winsource.h (tui_refill_source_window): Declare.
   5         * tui/tui-winsource.c (tui_refill_source_window): New function,
   6         from...
   7         (tui_horizontal_source_scroll): ... here.  Move some logic.
   8         * cli/cli-style.c (set_style_enabled): Notify new observable.
   9         * tui/tui-hooks.c (tui_redisplay_source): New function.
  10         (tui_attach_detach_observers): Attach or detach
  11         tui_redisplay_source.
  12         * observable.h (source_styling_changed): New observable.
  13         * observable.c: Define source_styling_changed observable.
  14
  15 2019-03-13  Tom Tromey  <tromey@adacore.com>
  16
  17         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
  18         (i386_gnu_nat_target::store_registers): Update.
  19         * target-debug.h (target_debug_print_std_string): New macro.
  20         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
  21         * windows-tdep.c (display_one_tib): Update.
  22         * tui/tui-stack.c (tui_make_status_line): Update.
  23         * top.c (print_inferior_quit_action): Update.
  24         * thread.c (thr_try_catch_cmd): Update.
  25         (add_thread_with_info): Update.
  26         (thread_target_id_str): Update.
  27         (thr_try_catch_cmd): Update.
  28         (thread_command): Update.
  29         (thread_find_command): Update.
  30         * record-btrace.c (record_btrace_target::info_record)
  31         (record_btrace_resume_thread, record_btrace_target::resume)
  32         (record_btrace_cancel_resume, record_btrace_step_thread)
  33         (record_btrace_target::wait, record_btrace_target::wait)
  34         (record_btrace_target::wait, record_btrace_target::stop): Update.
  35         * progspace.c (print_program_space): Update.
  36         * process-stratum-target.c
  37         (process_stratum_target::thread_address_space): Update.
  38         * linux-fork.c (linux_fork_mourn_inferior)
  39         (detach_checkpoint_command, info_checkpoints_command)
  40         (linux_fork_context): Update.
  41         (linux_fork_detach): Update.
  42         (class scoped_switch_fork_info): Update.
  43         (delete_checkpoint_command): Update.
  44         * infrun.c (follow_fork_inferior): Update.
  45         (follow_fork_inferior): Update.
  46         (proceed_after_vfork_done): Update.
  47         (handle_vfork_child_exec_or_exit): Update.
  48         (follow_exec): Update.
  49         (displaced_step_prepare_throw): Update.
  50         (displaced_step_restore): Update.
  51         (start_step_over): Update.
  52         (resume_1): Update.
  53         (clear_proceed_status_thread): Update.
  54         (proceed): Update.
  55         (print_target_wait_results): Update.
  56         (do_target_wait): Update.
  57         (context_switch): Update.
  58         (stop_all_threads): Update.
  59         (restart_threads): Update.
  60         (finish_step_over): Update.
  61         (handle_signal_stop): Update.
  62         (switch_back_to_stepped_thread): Update.
  63         (keep_going_pass_signal): Update.
  64         (print_exited_reason): Update.
  65         (normal_stop): Update.
  66         * inferior.c (inferior_pid_to_str): Change return type.
  67         (print_selected_inferior): Update.
  68         (add_inferior): Update.
  69         (detach_inferior): Update.
  70         * dummy-frame.c (fprint_dummy_frames): Update.
  71         * dcache.c (dcache_info_1): Update.
  72         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
  73         (btrace_fetch, btrace_clear): Update.
  74         * linux-tdep.c (linux_core_pid_to_str): Change return type.
  75         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
  76         type.
  77         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
  78         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
  79         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
  80         * gdbarch.c, gdbarch.h: Rebuild.
  81         * gdbarch.sh (core_pid_to_str): Change return type.
  82         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
  83         return type.
  84         (windows_nat_target::pid_to_str): Change return type.
  85         (windows_delete_thread): Update.
  86         (windows_nat_target::attach): Update.
  87         (windows_nat_target::files_info): Update.
  88         * target-delegates.c: Rebuild.
  89         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
  90         return type.
  91         (sol_thread_target::pid_to_str): Change return type.
  92         * remote.c (class remote_target) <pid_to_str>: Change return
  93         type.
  94         (remote_target::pid_to_str): Change return type.
  95         (extended_remote_target::attach, remote_target::remote_stop_ns)
  96         (remote_target::remote_notif_remove_queued_reply)
  97         (remote_target::push_stop_reply, remote_target::disable_btrace):
  98         Update.
  99         (extended_remote_target::attach): Update.
 100         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 101         type.
 102         (gdbsim_target::pid_to_str): Change return type.
 103         * ravenscar-thread.c (struct ravenscar_thread_target)
 104         <pid_to_str>: Change return type.
 105         (ravenscar_thread_target::pid_to_str): Change return type.
 106         * procfs.c (class procfs_target) <pid_to_str>: Change return
 107         type.
 108         (procfs_target::pid_to_str): Change return type.
 109         (procfs_target::attach): Update.
 110         (procfs_target::detach): Update.
 111         (procfs_target::fetch_registers): Update.
 112         (procfs_target::store_registers): Update.
 113         (procfs_target::wait): Update.
 114         (procfs_target::files_info): Update.
 115         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 116         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 117         return type.
 118         (nto_procfs_target::pid_to_str): Change return type.
 119         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 120         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 121         return type.
 122         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 123         (exit_lwp): Update.
 124         (attach_proc_task_lwp_callback, get_detach_signal)
 125         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 126         (linux_nat_target::resume, wait_lwp, stop_callback)
 127         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 128         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 129         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 130         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 131         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 132         type.
 133         (inf_ptrace_target::attach): Update.
 134         (inf_ptrace_target::files_info): Update.
 135         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 136         type.
 137         (go32_nat_target::pid_to_str): Change return type.
 138         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 139         (gnu_nat_target::wait): Update.
 140         (gnu_nat_target::wait): Update.
 141         (gnu_nat_target::resume): Update.
 142         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 143         (fbsd_nat_target::wait): Update.
 144         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 145         type.
 146         (darwin_nat_target::attach): Update.
 147         * corelow.c (class core_target) <pid_to_str>: Change return type.
 148         (core_target::pid_to_str): Change return type.
 149         * target.c (normal_pid_to_str): Change return type.
 150         (default_pid_to_str): Likewise.
 151         (target_pid_to_str): Change return type.
 152         (target_translate_tls_address): Update.
 153         (target_announce_detach): Update.
 154         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 155         return type.
 156         (bsd_uthread_target::pid_to_str): Change return type.
 157         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 158         type.
 159         (bsd_kvm_target::pid_to_str): Change return type.
 160         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 161         return type.
 162         (aix_thread_target::pid_to_str): Change return type.
 163         * target.h (struct target_ops) <pid_to_str>: Change return type.
 164         (target_pid_to_str, normal_pid_to_str): Likewise.
 165         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 166         type.
 167         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 168         type.
 169         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 170         return type.
 171         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 172         type.
 173         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 174         type.
 175         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 176         return type.
 177
 178 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 179
 180         * NEWS: Mention that the new default MI version is 3.  Mention
 181         changes to the output of commands and events that deal with
 182         multi-location breakpoints.
 183         * breakpoint.c: Include "mi/mi-out.h".
 184         (print_one_breakpoint): Change output syntax if using MI version
 185         >= 3.
 186         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 187         New.
 188         (mi_multi_location_breakpoint_output_fixed): New.
 189         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 190         (mi_cmd_fix_multi_location_breakpoint_output): New.
 191         (mi_multi_location_breakpoint_output_fixed): New.
 192         * mi/mi-cmds.c (mi_cmds): Register command
 193         -fix-multi-location-breakpoint-output.
 194         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 195         interpreter "mi".
 196
 197 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 198
 199         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 200         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 201         instantiate mi_ui_out based on interpreter name.
 202         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 203         * mi/mi-main.c (mi_load_progress): Likewise.
 204
 205 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 206
 207         * NEWS: Combine separate "New targets" sections for 8.3.
 208
 209 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 210
 211         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 212         (ppcfbsd_init_abi): Install gdbarch
 213         "fetch_tls_load_module_address" and "get_thread_local_address"
 214         methods.
 215
 216 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 217
 218         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 219         (riscv_fbsd_init_abi): Install gdbarch
 220         "fetch_tls_load_module_address" and "get_thread_local_address"
 221         methods.
 222
 223 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 224
 225         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 226         (i386fbsd_init_abi): Install gdbarch
 227         "fetch_tls_load_module_address" and "get_thread_local_address"
 228         methods.
 229
 230 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 231
 232         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 233         (amd64fbsd_init_abi): Install gdbarch
 234         "fetch_tls_load_module_address" and "get_thread_local_address"
 235         methods.
 236
 237 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 238
 239         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 240         (struct fbsd_pspace_data): New type.
 241         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 242         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 243         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 244         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 245         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 246
 247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 248
 249         * gdbtypes.c (lookup_struct_elt): New function.
 250         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 251         * gdbtypes.h (struct struct_elt): New type.
 252         (lookup_struct_elt): New prototype.
 253
 254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 255
 256         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 257         remove disabled code block.
 258
 259 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 260
 261         * gdbarch.sh (get_thread_local_address): New method.
 262         * gdbarch.h, gdbarch.c: Regenerate.
 263         * target.c (target_translate_tls_address): Use
 264         gdbarch_get_thread_local_address if present instead of
 265         target::get_thread_local_address.
 266
 267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 268
 269         * target.h (target::get_thread_local_address): Update comment.
 270
 271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 272
 273         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 274         objfile->separate_debug_objfile_backlink if not NULL.
 275
 276 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 277
 278         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 279         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 280         (amd64bsd_store_inferior_registers): Likewise.
 281         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 282         Enable segment base registers.
 283         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 284         PT_GETFSBASE and PT_GETGSBASE.
 285         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 286         PT_SETGSBASE.
 287         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 288         segment base registers.
 289         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 290
 291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 292
 293         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 294         Update calls to i386_target_description to add 'segments'
 295         parameter.
 296         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 297         add segment base registers.
 298         * arch/i386.c (i386_create_target_description): Add 'segments'
 299         parameter to enable segment base registers.
 300         * arch/i386.h (i386_create_target_description): Likewise.
 301         * features/i386/32bit-segments.xml: New file.
 302         * features/i386/32bit-segments.c: Generate.
 303         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 304         call to i386_target_description to add 'segments' parameter.
 305         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 306         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 307         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 308         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 309         if feature is present.
 310         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 311         Add 'segments' parameter to call to i386_target_description.
 312         (i386_target_description): Add 'segments' parameter to enable
 313         segment base registers.
 314         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 315         to call to i386_target_description.
 316         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 317         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 318         Define I386_NUM_REGS.
 319         (i386_target_description): Add 'segments' parameter to enable
 320         segment base registers.
 321
 322 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 323
 324         PR/24325
 325         * source-cache.c: #undef open and close, to avoid unresolved
 326         externals during linking.
 327
 328 2019-03-12  Tom Tromey  <tromey@adacore.com>
 329
 330         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 331         const.  Add initializers.
 332         (_initialize_remote): Don't initialize ptid globals.
 333
 334 2019-03-12  Pedro Alves  <palves@redhat.com>
 335
 336         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 337
 338 2019-03-12  Pedro Alves  <palves@redhat.com>
 339
 340         * cp-name-parser.y (main): Remove unused 'len' variable.
 341
 342 2019-03-12  Tom Tromey  <tromey@adacore.com>
 343
 344         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 345         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 346
 347 2019-03-12  Tom Tromey  <tromey@adacore.com>
 348
 349         * linux-nat.c (iterate_over_lwps): Update.
 350         (stop_callback): Remove parameter.
 351         (stop_wait_callback, detach_callback, resume_set_callback)
 352         (select_singlestep_lwp_callback, set_ignore_sigint)
 353         (status_callback, resumed_callback, resume_clear_callback)
 354         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 355         data parameter.
 356         (linux_nat_target::detach, linux_nat_target::resume)
 357         (linux_stop_and_wait_all_lwps, select_event_lwp)
 358         (linux_nat_filter_event, linux_nat_wait_1)
 359         (linux_nat_target::kill, linux_nat_target::stop)
 360         (linux_nat_target::stop): Update.
 361         (linux_nat_resume_callback): Change type.
 362         (resume_stopped_resumed_lwps, count_events_callback)
 363         (select_event_lwp_callback): Likewise.
 364         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 365         * arm-linux-nat.c (struct update_registers_data): Remove.
 366         (update_registers_callback): Change type.
 367         (arm_linux_insert_hw_breakpoint1): Update.
 368         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 369         parameter.
 370         (x86_linux_dr_set_addr): Update.
 371         (x86_linux_dr_set_control): Update.
 372         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 373         (iterate_over_lwps): Use gdb::function_view.
 374         * nat/aarch64-linux-hw-point.c (struct
 375         aarch64_dr_update_callback_param): Remove.
 376         (debug_reg_change_callback): Change type.
 377         (aarch64_notify_debug_reg_change): Update.
 378         * s390-linux-nat.c (s390_refresh_per_info): Update.
 379
 380 2019-03-11  Tom Tromey  <tromey@adacore.com>
 381
 382         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 383         redundant assignment to "this_cu".
 384
 385 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 386
 387         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 388
 389 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 390
 391         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 392         from...
 393         (rank_one_type): ... this.
 394
 395 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 396
 397         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 398         from...
 399         (rank_one_type): ... this.
 400
 401 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 402
 403         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 404         from...
 405         (rank_one_type): ... this.
 406
 407 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 408
 409         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 410         from...
 411         (rank_one_type): ... this.
 412
 413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 414
 415         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 416         from...
 417         (rank_one_type): ... this.
 418
 419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 420
 421         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 422         from...
 423         (rank_one_type): ... this.
 424
 425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 426
 427         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 428         from...
 429         (rank_one_type): ... this.
 430
 431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 432
 433         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 434         from...
 435         (rank_one_type): ... this.
 436
 437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 438
 439         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 440         from...
 441         (rank_one_type): ... this.
 442
 443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 444
 445         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 446         from...
 447         (rank_one_type): ... this.
 448
 449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 450
 451         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 452         from...
 453         (rank_one_type): ... this.
 454
 455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 456
 457         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 458         from...
 459         (rank_one_type): ... this.
 460
 461 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 462
 463         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 464         inferior-events' shows the example events.
 465
 466 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 467
 468         Support styling on native MS-Windows console
 469
 470         PR/24315
 471         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 472         on MS-Windows if $TERM is not defined.
 473
 474         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 475
 476         * posix-hdep.c (gdb_console_fputs):
 477         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 478         functions.
 479         * ui-file.h (gdb_console_fputs): Add prototype.
 480
 481         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 482         back to fputs only if the former returns zero.
 483
 484 2019-03-07  Tom Tromey  <tom@tromey.com>
 485
 486         * symmisc.c (print_symbol_bcache_statistics): Update.
 487         (print_objfile_statistics): Update.
 488         * symfile.c (allocate_symtab): Update.
 489         * stabsread.c: Don't include bcache.h.
 490         * psymtab.h (struct psymbol_bcache): Don't declare.
 491         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 492         (psymbol_bcache_init, psymbol_bcache_free)
 493         (psymbol_bcache_get_bcache): Don't declare.
 494         * psymtab.c (struct psymbol_bcache): Remove.
 495         (psymtab_storage::psymtab_storage): Update.
 496         (psymtab_storage::~psymtab_storage): Update.
 497         (psymbol_bcache_init, psymbol_bcache_free)
 498         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 499         (add_psymbol_to_bcache): Update.
 500         (allocate_psymtab): Update.
 501         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 502         macro_cache>: No longer pointers.
 503         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 504         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 505         * macrotab.c (macro_bcache): Update.
 506         * macroexp.c: Don't include bcache.h.
 507         * gdbtypes.c (check_types_worklist): Update.
 508         (types_deeply_equal): Remove TRY/CATCH.  Update.
 509         * elfread.c (elf_symtab_read): Update.
 510         * dwarf2read.c: Don't include bcache.h.
 511         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 512         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 513         (print_bcache_statistics, bcache_memory_used): Don't declare.
 514         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 515         methods.  Rename all data members.
 516         * bcache.c (struct bcache): Move to bcache.h.
 517         (bcache::expand_hash_table): Rename from expand_hash_table.
 518         (bcache): Remove.
 519         (bcache::insert): Rename from bcache_full.
 520         (bcache::compare): Rename from bcache_compare.
 521         (bcache_xmalloc): Remove.
 522         (bcache::~bcache): Rename from bcache_xfree.
 523         (bcache::print_statistics): Rename from print_bcache_statistics.
 524         (bcache::memory_used): Rename from bcache_memory_used.
 525
 526 2019-03-07  Pedro Alves  <palves@redhat.com>
 527
 528         * infrun.c (normal_stop): Also check for
 529         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 530
 531 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * f-lang.c (value_from_host_double): Moved to...
 534         * value.c (value_from_host_double): ...here.
 535         * value.h (value_from_host_double): Declare.
 536         * guile/scm-math.c (vlscm_convert_typed_number): Use
 537         value_from_host_double.
 538         (vlscm_convert_number): Likewise.
 539         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 540         * python/py-value.c (convert_value_from_python): Likewise.
 541
 542 2019-03-06  Tom Tromey  <tom@tromey.com>
 543
 544         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 545
 546 2019-03-06  Tom Tromey  <tom@tromey.com>
 547
 548         * utils.h (free_current_contents): Don't declare.
 549         * utils.c (free_current_contents): Remove.
 550
 551 2019-03-06  Tom Tromey  <tom@tromey.com>
 552
 553         * top.c (quit_force): Update.
 554         * main.c (captured_command_loop): Update.
 555         * common/new-op.c (operator new): Update.
 556         * common/common-exceptions.c (struct catcher)
 557         <save_cleanup_chain>: Remove member.
 558         (exceptions_state_mc_init): Update.
 559         (exception_try_scope_entry): Return nullptr.
 560         (exception_try_scope_exit, exception_rethrow)
 561         (throw_exception_sjlj, throw_exception_cxx): Update.
 562         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 563         (all_cleanups, do_cleanups, discard_cleanups)
 564         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 565         (restore_cleanups, restore_final_cleanups): Don't declare.
 566         (do_final_cleanups): Remove parameter.
 567         * common/cleanups.c (cleanup_chain, make_cleanup)
 568         (make_cleanup_dtor, all_cleanups, do_cleanups)
 569         (discard_my_cleanups, discard_cleanups)
 570         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 571         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 572         (null_cleanup): Remove.
 573         (do_final_cleanups): Remove parameter.
 574
 575 2019-03-06  Tom Tromey  <tom@tromey.com>
 576
 577         * remote.c (remote_target::remote_parse_stop_reply): Use
 578         unique_xmalloc_ptr.
 579
 580 2019-03-06  Tom Tromey  <tom@tromey.com>
 581
 582         * stabsread.c (struct stabs_field_info): Rename from field_info.
 583         <list, fnlist>: Add initializers.
 584         <obstack>: New member.
 585         (read_member_functions, read_struct_fields, read_baseclasses):
 586         Allocate on obstack.  Don't use cleanups.
 587         (read_one_struct_field, read_member_functions, read_struct_fields)
 588         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 589         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 590         (read_struct_type): Update.
 591
 592 2019-03-06  Tom Tromey  <tom@tromey.com>
 593
 594         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 595         * common/filestuff.h (make_cleanup_close): Don't declare.
 596         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 597         Remove.
 598
 599 2019-03-06  Tom Tromey  <tom@tromey.com>
 600
 601         * solib-aix.c: Use make_scope_exit.
 602
 603 2019-03-06  Tom Tromey  <tom@tromey.com>
 604
 605         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 606         Use make_scope_exit.
 607
 608 2019-03-06  Tom Tromey  <tom@tromey.com>
 609
 610         * solib-svr4.c (disable_probes_interface): Remove parameter.
 611         (svr4_handle_solib_event): Use make_scope_exit.
 612
 613 2019-03-06  Tom Tromey  <tom@tromey.com>
 614
 615         * remote.c (struct stop_reply_deleter): Remove.
 616         (stop_reply_up): Update.
 617         (struct stop_reply): Derive from notif_event.  Don't typedef.
 618         <regcache>: Now a std::vector.
 619         (stop_reply_xfree): Remove.
 620         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 621         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 622         (remote_target::discard_pending_stop_replies): Use delete.
 623         (remote_target::remote_parse_stop_reply): Update.
 624         (remote_target::process_stop_reply): Update.
 625         * remote-notif.h (struct notif_event): Add virtual destructor.
 626         Remove "dtr" member.
 627         (struct notif_client) <alloc_event>: Return a unique_ptr.
 628         (notif_event_xfree): Don't declare.
 629         (notif_event_up): New typedef.
 630         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 631         (notif_event_xfree, do_notif_event_xfree): Remove.
 632         (remote_notif_state_xfree): Update.
 633
 634 2019-03-06  Tom Tromey  <tom@tromey.com>
 635
 636         * infrun.c (displaced_step_clear_cleanup): Now a
 637         forward_scope_exit type.
 638         (displaced_step_prepare_throw): Update.
 639         (displaced_step_fixup): Update.
 640
 641 2019-03-06  Tom Tromey  <tom@tromey.com>
 642
 643         * inferior.h (class inferior): Update comment.
 644         * gdbthread.h (class thread_info): Update comment.
 645
 646 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 647             Tom Tromey  <tom@tromey.com>
 648
 649         * stabsread.h (struct stab_section_list): Remove.
 650         (coffstab_build_psymtabs): Update.
 651         * dbxread.c (symbuf_sections): Now a std::vector.
 652         (sect_idx): New global.
 653         (fill_symbuf): Update.
 654         (coffstab_build_psymtabs): Change type of stabsects parameter.
 655         Update.
 656         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 657         std::vector.
 658         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 659         (coff_locate_sections): Update.
 660         (coff_symfile_read): Remove cleanups.  Update.
 661         (init_stringtab): Add storage parameter.
 662         (free_stringtab, free_stringtab_cleanup): Remove.
 663         (init_lineno): Add storage parameter.
 664         (free_linetab, free_linetab_cleanup): Remove.
 665
 666 2019-03-06  Pedro Alves  <palves@redhat.com>
 667
 668         * linux-fork.c (fork_info::clobber_regs): Delete.
 669         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 670         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 671         comment.  Adjust.
 672         (scoped_switch_fork_info::scoped_switch_fork_info)
 673         (checkpoint_command, linux_fork_context): Adjust
 674         fork_save_infrun_state calls.
 675
 676 2019-03-06  Pedro Alves  <palves@redhat.com>
 677
 678         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 679         (inf_has_multiple_threads): Return 'bool' and rewrite using
 680         inferior_info::threads().
 681
 682 2019-03-06  Pedro Alves  <palves@redhat.com>
 683
 684         * linux-fork.c: Include <list>.
 685         (fork_list): Now a std::list instance.
 686         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 687         (forks_exist_p, find_last_fork): Adjust.
 688         (new_fork): Delete.
 689         (one_fork_p): New.
 690         (add_fork): Adjust.
 691         (free_fork): Delete, folded into fork_info::~fork_info().
 692         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 693         Adjust.
 694         (init_fork_list): Delete.
 695         (linux_fork_killall, linux_fork_mourn_inferior)
 696         (linux_fork_detach, info_checkpoints_command): Adjust.
 697         (_initialize_linux_fork): No longer call init_fork_list.
 698
 699 2019-03-06  Pedro Alves  <palves@redhat.com>
 700
 701         * linux-fork.c (new_fork): New, split out of ...
 702         (add_fork): ... this.  Return void.  Move "first fork" special
 703         case from here, to ...
 704         (checkpoint_command): ... here.
 705         * linux-linux.h (add_fork): Return void.
 706
 707 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 708
 709         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 710
 711 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 712             Chris January  <chris.january@arm.com>
 713             David Lecomber  <david.lecomber@arm.com>
 714
 715         * f-exp.y: New token, UNOP_INTRINSIC.
 716         (exp): New pattern using UNOP_INTRINSIC token.
 717         (f77_keywords): Add 'abs' keyword.
 718         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 719         (value_from_host_double): New function.
 720         (evaluate_subexp_f): Support UNOP_ABS.
 721
 722 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 723
 724         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 725         types.
 726
 727 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 728
 729         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 730         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 731         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 732
 733 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 736
 737 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 738             Chris January  <chris.january@arm.com>
 739
 740         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 741         * f-exp.y: Define 'KIND' token.
 742         (exp): New pattern for KIND expressions.
 743         (ptype): Handle types with a kind extension.
 744         (direct_abs_decl): Extend to spot kind extensions.
 745         (f77_keywords): Add 'kind' to the list.
 746         (push_kind_type): New function.
 747         (convert_to_kind_type): New function.
 748         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 749         * parse.c (operator_length_standard): Likewise.
 750         * parser-defs.h (enum type_pieces): Add tp_kind.
 751         * std-operator.def: Add UNOP_KIND.
 752
 753 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 754
 755         * f-exp.y (f_parse): Set yydebug.
 756
 757 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 758
 759         * f-lang.c (evaluate_subexp_f): New function.
 760         (exp_descriptor_f): New global.
 761         (f_language_defn): Use exp_descriptor_f instead of
 762         exp_descriptor_standard.
 763
 764 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 765
 766         * f-exp.y (struct token): Add comments.
 767         (dot_ops): Remove uppercase versions and the end marker.
 768         (f77_keywords): Likewise.
 769         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 770         entries in the dot_ops array are case insensitive, and use
 771         strncasecmp to compare strings.  Also some whitespace cleanup in
 772         this area.  Similar for the f77_keywords array, except entries in
 773         this list might be case sensitive.
 774
 775 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 776
 777         * f-exp.y (struct f77_boolean_val): Add comments.
 778         (boolean_values): Remove uppercase versions, and end marker.
 779         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 780         and use strncasecmp to achieve case insensitivity.  Additionally,
 781         perform whitespace cleanup around this code.
 782
 783 2019-03-06  Tom Tromey  <tromey@adacore.com>
 784
 785         * remote-sim.c (gdbsim_target_open): Use result of
 786         gdb_argv::release.
 787
 788 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 789         Dirk Schubert  <dirk.schubert@arm.com>
 790         Chris January  <chris.january@arm.com>
 791
 792         * eval.c (evaluate_subexp_standard): Call Fortran argument
 793         wrapping logic.
 794         * f-lang.c (struct value): A value which can be passed into a
 795         Fortran function call.
 796         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 797         where appropriate.
 798         (struct type): Value ready for a Fortran function call.
 799         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 800         is needed.
 801         * f-lang.h (fortran_argument_convert): Declaration.
 802         (fortran_preserve_arg_pointer): Declaration.
 803         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 804
 805 2019-03-05  Tom Tromey  <tromey@adacore.com>
 806
 807         * python/py-prettyprint.c (print_string_repr): Remove #if.
 808         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 809
 810 2019-03-05  Tom Tromey  <tromey@adacore.com>
 811
 812         * target.c (the_dummy_target): Move later.  Change type to
 813         "dummy_target".
 814         (initialize_targets): Don't initialize the_dummy_target.
 815
 816 2019-03-05  Tom Tromey  <tromey@adacore.com>
 817
 818         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 819         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 820
 821 2019-03-05  Tom Tromey  <tromey@adacore.com>
 822
 823         * windows-nat.c (windows_nat_target::attach)
 824         (windows_nat_target::detach): Don't call gdb_flush.
 825         * valprint.c (generic_val_print, val_print, val_print_string):
 826         Don't call gdb_flush.
 827         * utils.c (defaulted_query): Don't call gdb_flush.
 828         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 829         * target.c (target_announce_detach): Don't call gdb_flush.
 830         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 831         * remote.c (extended_remote_target::attach): Don't call
 832         gdb_flush.
 833         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 834         * printcmd.c (do_examine): Don't call gdb_flush.
 835         (info_display_command): Don't call gdb_flush.
 836         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 837         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 838         * memattr.c (info_mem_command): Don't call gdb_flush.
 839         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 840         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 841         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 842         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 843         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 844         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 845         (gnu_nat_target::detach): Don't call gdb_flush.
 846         * f-valprint.c (f_val_print): Don't call gdb_flush.
 847         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 848         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 849         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 850         gdb_flush.
 851         * c-valprint.c (c_val_print): Don't call gdb_flush.
 852         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 853
 854 2019-03-05  Tom Tromey  <tromey@adacore.com>
 855
 856         * varobj.c (update_dynamic_varobj_children): Update.
 857         (install_default_visualizer): Use reset, not release.
 858         * value.c (set_internalvar): Update.
 859         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 860         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 861         ATTRIBUTE_UNUSED_RESULT.
 862
 863 2019-03-05  Tom Tromey  <tromey@adacore.com>
 864
 865         * remote.c (class scoped_remote_fd) <release>: Add
 866         ATTRIBUTE_UNUSED_RESULT.
 867
 868 2019-03-05  Tom Tromey  <tromey@adacore.com>
 869
 870         * macroexp.c (struct macro_buffer) <release>: Add
 871         ATTRIBUTE_UNUSED_RESULT.
 872
 873 2019-03-05  Tom Tromey  <tromey@adacore.com>
 874
 875         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 876         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 877         ATTRIBUTE_UNUSED_RESULT.
 878
 879 2019-03-05  Tom Tromey  <tromey@adacore.com>
 880
 881         * common/scoped_fd.h (class scoped_fd) <release>: Add
 882         ATTRIBUTE_UNUSED_RESULT.
 883
 884 2019-03-05  Tom Tromey  <tromey@adacore.com>
 885
 886         * parser-defs.h (struct parser_state) <release>: Add
 887         ATTRIBUTE_UNUSED_RESULT.
 888
 889 2019-03-05  Tom Tromey  <tromey@adacore.com>
 890
 891         * utils.h (class gdb_argv) <release>: Add
 892         ATTRIBUTE_UNUSED_RESULT.
 893         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 894
 895 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 896
 897         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 898         for-loop range, to avoid compiler warnings.
 899
 900         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 901         avoid compiler warnings about unused variables.
 902
 903         * NEWS: Mention end of support for native debugging on MS-Windows
 904         before XP.
 905
 906         PR gdb/24292
 907         * common/netstuff.c:
 908         * gdbserver/gdbreplay.c
 909         * gdbserver/remote-utils.c:
 910         * ser-tcp.c:
 911         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 912         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 913         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 914         'getaddrinfo' and 'freeaddrinfo' were not available before
 915         Windows XP, and mingw.org's MinGW headers by default define
 916         _WIN32_WINNT to 0x500.
 917
 918 2019-03-01  Gary Benson <gbenson@redhat.com>
 919
 920         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 921
 922 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 923             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 924
 925         PR gdb/8527
 926         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 927         set_sigint_trap, clear_sigint_trap.
 928
 929 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 930
 931         * target.c (target_detach): Clear the regcache and the
 932         frame cache.
 933
 934 2019-02-27  Pedro Alves  <palves@redhat.com>
 935
 936         * utils.c (set_screen_size): When we cap the height/width sizes,
 937         tweak the corresponding command variable to show "unlimited":
 938
 939 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 940             Pedro Alves  <palves@redhat.com>
 941
 942         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 943         before calling rl_set_screen_size.
 944
 945 2019-02-27  Tom Tromey  <tromey@adacore.com>
 946
 947         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 948         define.
 949         * python/py-value.c: Remove Python 2.4 workaround.
 950         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 951         workaround.
 952         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 953         Python 2.4 workaround.
 954         * python/python-internal.h: Remove Python 2.4 comment.
 955         (Py_ssize_t): Don't define.
 956         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 957         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 958         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 959         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 960         * python/python.c (do_start_initialization): Remove Python 2.4
 961         workaround.
 962         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 963         (print_children): Remove Python 2.4 workaround.
 964         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 965         workaround.
 966         (CHARBUFFERPROC_NAME): Remove.
 967         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 968         Python 2.4 workaround.
 969
 970 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 971
 972         * NEWS: Note minimum Python version.
 973
 974 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 975
 976         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 977         code from these functions.  Remove corresponding ifdefs.  Use
 978         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 979         Remove gotos and target of gotos.
 980         (infpy_search_memory): Likewise.
 981
 982 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 983
 984         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 985         (hppa_gdbarch_init): Don't register deleted functions with
 986         gdbarch.
 987
 988 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 991         (h8300_unwind_sp): Delete.
 992         (h8300_dummy_id): Delete.
 993         (h8300_gdbarch_init): Don't register deleted functions with
 994         gdbarch.
 995
 996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 999         (ft32_unwind_pc): Delete.
1000         (ft32_unwind_sp): Delete.
1001         (ft32_gdbarch_init): Don't register deleted functions with
1002         gdbarch.
1003
1004 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1005
1006         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1007         (frv_unwind_pc): Delete.
1008         (frv_unwind_sp): Delete.
1009         (frv_gdbarch_init): Don't register deleted functions with
1010         gdbarch.
1011
1012 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1013
1014         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1015         (riscv_unwind_pc): Delete.
1016         (riscv_unwind_sp): Delete.
1017         (riscv_gdbarch_init): Don't register deleted functions with
1018         gdbarch.
1019
1020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1023         (csky_unwind_pc): Delete.
1024         (csky_unwind_sp): Delete.
1025         (csky_gdbarch_init): Don't register deleted functions with
1026         gdbarch.
1027
1028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1031         (cris_unwind_pc): Delete.
1032         (cris_unwind_sp): Delete.
1033         (cris_gdbarch_init): Don't register deleted functions with
1034         gdbarch.
1035
1036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1039         (bfin_unwind_pc): Delete.
1040         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1041
1042 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1043
1044         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1045         (arm_unwind_pc): Delete.
1046         (arm_unwind_sp): Delete.
1047         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1048
1049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1050
1051         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1052         (arc_unwind_pc): Delete.
1053         (arc_unwind_sp): Delete.
1054         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1055
1056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1059         (alpha_unwind_pc): Delete.
1060         (alpha_gdbarch_init): Don't register deleted functions with
1061         gdbarch.
1062
1063 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1064
1065         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1066         (aarch64_unwind_pc): Delete.
1067         (aarch64_unwind_sp): Delete.
1068         (aarch64_gdbarch_init): Don't register deleted functions with
1069         gdbarch.
1070
1071 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1072
1073         * gdbtypes.c (type_align): Don't consider static members when
1074         computing structure alignment.
1075
1076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1077
1078         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1079         return 0 for other types.
1080         * arch-utils.c (default_type_align): Always return 0.
1081         * gdbarch.h: Regenerate.
1082         * gdbarch.sh (type_align): Extend comment.
1083         * gdbtypes.c (type_align): Add additional comments, always call
1084         gdbarch_type_align before applying the default rules.
1085         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1086         generic code will then apply a suitable default.
1087         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1088         types, return 0 for other types.
1089
1090 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1091
1092         * NEWS: Create a new section for the next release branch.
1093         Rename the section of the current branch, now that it has
1094         been cut.
1095
1096 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1097
1098         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1099         * version.in: Bump version to 8.3.50.DATE-git.
1100
1101 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1102
1103         * aix-thread.c (ptid_cmp): Remove unused variable.
1104         (get_signaled_thread): Likewise.
1105         (store_regs_user_thread): Likewise.
1106         (store_regs_kernel_thread): Likewise.
1107         (fetch_regs_kernel_thread): Remove shadowed variable.
1108
1109 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1110
1111         * features/riscv/32bit-cpu.xml: Add register numbers.
1112         * features/riscv/32bit-fpu.c: Regenerate.
1113         * features/riscv/32bit-fpu.xml: Add register numbers.
1114         * features/riscv/64bit-cpu.xml: Add register numbers.
1115         * features/riscv/64bit-fpu.c: Regenerate.
1116         * features/riscv/64bit-fpu.xml: Add register numbers.
1117
1118 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1119
1120         * NEWS: Mention two argument form of gdb.Value constructor.
1121         * python/py-value.c (convert_buffer_and_type_to_value): New
1122         function.
1123         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1124         Add support for handling an optional second argument.  Call
1125         convert_buffer_and_type_to_value as appropriate.
1126         * python/python-internal.h (Py_buffer_deleter): New struct.
1127         (Py_buffer_up): New typedef.
1128
1129 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1130
1131         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1132         instead of releasing ownership.
1133
1134 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1135
1136         * dwarf2read.c (open_and_init_dwp_file): Call
1137         elf_numsections instead of bfd_count_sections to initialize
1138         dwp_file->num_sections.
1139
1140 2019-02-25  Tom Tromey  <tromey@adacore.com>
1141
1142         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1143
1144 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1145
1146         * gcore.in: Add '--readnever' option when invoking GDB.
1147
1148 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1149
1150         * MAINTAINERS: Update my email address.
1151
1152 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1153
1154         * build-id.c (build_id_to_debug_bfd_1): New function.
1155         (build_id_to_debug_bfd): Look for separate debug file in
1156         sysroot.
1157
1158 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * gdbarch.sh: Update the copyright year range that is placed into
1161         generated files.
1162
1163 2019-02-22  Keith Seitz  <keiths@redhat.com>
1164
1165         PR symtab/23853
1166         * linespec.c (create_sals_line_offset): Search for the default
1167         symtab's filename instead of its fullname.
1168
1169 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1170
1171         * NEWS: Update style defaults.
1172
1173 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1174
1175         * main.c (captured_main_1): Disable styling in batch mode.
1176
1177 2019-02-20  Tom Tromey  <tom@tromey.com>
1178
1179         * symtab.c (symtab_symbol_info): Fix typos.
1180
1181 2019-02-20  Tom Tromey  <tromey@adacore.com>
1182
1183         * findcmd.c (_initialize_mem_search): Use upper case for
1184         metasyntactic variables.
1185
1186 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1187
1188         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1189         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1190
1191 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1192
1193         * top.h (source_file_name): Change to std::string.
1194         * top.c (source_file_name): Likewise.
1195         (command_line_input): Adjust.
1196         * cli/cli-script.c (script_from_file): Adjust.
1197
1198 2019-02-19  Tom Tromey  <tromey@adacore.com>
1199
1200         * ravenscar-thread.c
1201         (ravenscar_thread_target::update_thread_list): Don't call
1202         ada_build_task_list.
1203         * ada-lang.h (ada_build_task_list): Don't declare.
1204         * ada-tasks.c (struct ada_tasks_inferior_data)
1205         <task_list_valid_p>: Now bool.
1206         (read_known_tasks, ada_task_list_changed)
1207         (ada_tasks_invalidate_inferior_data): Update.
1208         (read_known_tasks_array): Return bool.
1209         (read_known_tasks_list): Likewise.
1210         (read_known_tasks): Return void.
1211         (ada_build_task_list): Now static.
1212
1213 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1216         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1217
1218 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1219
1220         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1221         variant for ada_tasks_pspace_data_handle and
1222         ada_tasks_inferior_data_handle.
1223         (ada_tasks_pspace_data_cleanup): New function.
1224         (ada_tasks_inferior_data_cleanup): New function.
1225
1226 2019-02-17  Tom Tromey  <tom@tromey.com>
1227
1228         * macrotab.h (macro_source_fullname): Return a std::string.
1229         * macrotab.c (macro_include, check_for_redefinition)
1230         (macro_undef, macro_lookup_definition, foreach_macro)
1231         (foreach_macro_in_scope): Update.
1232         (macro_source_fullname): Return a std::string.
1233         * macrocmd.c (show_pp_source_pos): Update.
1234
1235 2019-02-17  Tom Tromey  <tom@tromey.com>
1236
1237         * macrocmd.c (show_pp_source_pos): Style the file names.
1238
1239 2019-02-17  Tom Tromey  <tom@tromey.com>
1240
1241         PR tui/24197:
1242         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1243
1244 2019-02-17  Tom Tromey  <tom@tromey.com>
1245
1246         * ada-lang.c (user_select_syms): Use filtered printing.
1247         * utils.c (wrap_style): New global.
1248         (desired_style): Remove.
1249         (emit_style_escape): Add stream parameter.
1250         (set_output_style, reset_terminal_style, prompt_for_continue):
1251         Update.
1252         (flush_wrap_buffer): Only flush gdb_stdout.
1253         (wrap_here): Set wrap_style.
1254         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1255         treat escape sequences as a character.  Change when wrap buffer is
1256         flushed.
1257         (fputs_styled): Do not set the output style when the default is
1258         requested.
1259         * ui-style.h (struct ui_file_style) <is_default>: New method.
1260         * source.c (print_source_lines_base): Emit escape sequences in one
1261         piece.
1262
1263 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1264
1265         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1266         integers and enumeration types.
1267
1268 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1269
1270         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1271         instead of lookup_symbol_in_language
1272         (do_exact_match): New function.
1273         (ada_get_symbol_name_matcher): Return do_exact_match when
1274         doing a verbatim match.
1275
1276 2019-02-15  Tom Tromey  <tromey@adacore.com>
1277
1278         * ravenscar-thread.c (ravenscar_thread_target::resume)
1279         (ravenscar_thread_target::wait): Special case wildcard requests.
1280
1281 2019-02-15  Tom Tromey  <tromey@adacore.com>
1282
1283         * ravenscar-thread.c (base_ptid): Remove.
1284         (struct ravenscar_thread_target) <close>: New method.
1285         <m_base_ptid>: New member.
1286         <update_inferior_ptid, active_task, task_is_currently_active,
1287         runtime_initialized>: Declare methods.
1288         <ravenscar_thread_target>: Add constructor.
1289         (ravenscar_thread_target::task_is_currently_active)
1290         (ravenscar_thread_target::update_inferior_ptid)
1291         (ravenscar_runtime_initialized): Rename.  Now methods.
1292         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1293         (ravenscar_thread_target::update_thread_list): Update.
1294         (ravenscar_thread_target::active_task): Now method.
1295         (ravenscar_thread_target::store_registers)
1296         (ravenscar_thread_target::prepare_to_store)
1297         (ravenscar_thread_target::prepare_to_store)
1298         (ravenscar_thread_target::mourn_inferior): Update.
1299         (ravenscar_inferior_created): Use "new" to create target.
1300         (ravenscar_thread_target::get_ada_task_ptid): Update.
1301         (_initialize_ravenscar): Don't initialize base_ptid.
1302         (ravenscar_ops): Remove global.
1303
1304 2019-02-15  Tom Tromey  <tromey@adacore.com>
1305
1306         * target.h (push_target): Declare new overload.
1307         * target.c (push_target): New overload, taking an rvalue reference.
1308         * remote.c (remote_target::open_1): Use push_target overload.
1309         * corelow.c (core_target_open): Use push_target overload.
1310
1311 2019-02-15  Tom Tromey  <tromey@adacore.com>
1312
1313         * ravenscar-thread.c (is_ravenscar_task)
1314         (ravenscar_task_is_currently_active): Return bool.
1315         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1316         (_initialize_ravenscar): Remove "(void)".
1317         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1318         Return bool.
1319
1320 2019-02-15  Tom Tromey  <tromey@adacore.com>
1321
1322         * ravenscar-thread.c (ravenscar_runtime_initializer)
1323         (has_ravenscar_runtime, get_running_thread_id)
1324         (ravenscar_thread_target::resume): Fix indentation.
1325
1326 2019-02-15  Tom Tromey  <tromey@adacore.com>
1327
1328         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1329         from ravenscar_arch_ops.
1330         (sparc_ravenscar_ops::fetch_registers)
1331         (sparc_ravenscar_ops::store_registers): Now methods.
1332         (sparc_ravenscar_prepare_to_store): Remove.
1333         (sparc_ravenscar_ops): Redefine.
1334         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1335         methods and destructor.  Remove members.
1336         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1337         (ravenscar_thread_target::store_registers)
1338         (ravenscar_thread_target::prepare_to_store): Update.
1339         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1340         Remove.
1341         (struct ppc_ravenscar_powerpc_ops): Derive from
1342         ravenscar_arch_ops.
1343         (ppc_ravenscar_powerpc_ops::fetch_registers)
1344         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1345         (ppc_ravenscar_powerpc_ops): Redefine.
1346         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1347         (ppc_ravenscar_e500_ops::fetch_registers)
1348         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1349         (ppc_ravenscar_e500_ops): Redefine.
1350         * aarch64-ravenscar-thread.c
1351         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1352         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1353         (aarch64_ravenscar_fetch_registers)
1354         (aarch64_ravenscar_store_registers): Now methods.
1355         (aarch64_ravenscar_ops): Redefine.
1356
1357 2019-02-15  Tom Tromey  <tromey@adacore.com>
1358
1359         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1360         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1361         (ravenscar_thread_target::stopped_by_watchpoint)
1362         (ravenscar_thread_target::stopped_data_address)
1363         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1364
1365 2019-02-15  Tom Tromey  <tromey@adacore.com>
1366
1367         * ravenscar-thread.c: Fix some typos.
1368
1369 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1370             Tom Tromey  <tromey@adacore.com>
1371
1372         * ada-lang.c (ada_exception_sal): Change addr_string to a
1373         std::string.
1374         (create_ada_exception_catchpoint): Update.
1375
1376 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1377             Tom Tromey  <tromey@adacore.com>
1378
1379         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1380         (bp_location_ops): Remove.
1381         (base_breakpoint_allocate_location): Update.
1382         (free_bp_location): Update.
1383         * ada-lang.c (class ada_catchpoint_location)
1384         <ada_catchpoint_location>: Remove ops parameter.
1385         (ada_catchpoint_location_dtor): Remove.
1386         (ada_catchpoint_location_ops): Remove.
1387         (allocate_location_exception): Update.
1388         * breakpoint.h (struct bp_location_ops): Remove.
1389         (class bp_location) <bp_location>: Remove bp_location_ops
1390         parameter.
1391         <~bp_location>: Add destructor.
1392         <ops>: Remove.
1393
1394 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1395             Pedro Alves  <palves@redhat.com>
1396
1397         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1398         'PATH_MAX'.
1399
1400 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1401             Samuel Thibault  <samuel.thibault@gnu.org>
1402             Thomas Schwinge  <thomas@codesourcery.com>
1403
1404         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1405         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1406
1407 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1408
1409         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1410         (check_empty): Use "const char *".
1411
1412         * gnu-nat.c (gnu_nat_target::detach): Instead of
1413         'detach_inferior (pid)' call
1414         'detach_inferior (find_inferior_pid (pid))'.
1415
1416         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1417         'nat/fork-inferior.o'.
1418         * gnu-nat.c: #include "nat/fork-inferior.h".
1419
1420         * gnu-nat.c (gnu_nat_target::detach): Instead of
1421         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1422         * gnu-nat.h: #include "inf-child.h".
1423         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1424         'i386_gnu_nat_target::fetch_registers'.
1425         (gnu_store_registers): Rename/move to
1426         'i386_gnu_nat_target::store_registers'.
1427
1428         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1429         * gnu-nat.h (mach_thread_info): New function.
1430         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1431
1432         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1433
1434 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1435
1436         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1437
1438 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1439
1440         * windows-nat.c (windows_add_thread): Add new parameter
1441         "main_thread_p" with default value set to false.  Update
1442         function documentation as well as all callers.
1443         (windows_delete_thread): Likewise.
1444         (fake_create_process): Update call to windows_add_thread.
1445         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1446         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1447         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1448         call to windows_delete_thread.
1449
1450 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1451
1452         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1453
1454 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1455
1456         * symfile.c (find_separate_debug_file): Use canonical path of
1457         sysroot with child_path instead of gdb_sysroot if it is valid.
1458
1459 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1460
1461         * symfile.c (find_separate_debug_file): Use child_path to
1462         determine if an object file is under a sysroot.
1463
1464 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1465
1466         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1467         unittests/child-path-selftests.c.
1468         * common/pathstuff.c (child_path): New function.
1469         * common/pathstuff.h (child_path): New prototype.
1470         * unittests/child-path-selftests.c: New file.
1471
1472 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1473
1474         * symfile.c (find_separate_debug_file): Look for separate debug
1475         files in debug directories under the sysroot.
1476
1477 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1478
1479         * symtab.h (struct minimal_symbol data_p): New const method.
1480         (struct minimal_symbol text_p): Likewise.
1481         * symtab.c (output_source_filename): Use file name style
1482         to print file name.
1483         (print_symbol_info): Likewise.
1484         (print_msymbol_info): Use address style to print addresses.
1485         Use function name style to print executable text symbols.
1486         (expand_symtab_containing_pc): Use data_p.
1487         (find_pc_sect_compunit_symtab): Likewise.
1488
1489 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1490
1491         * breakpoint.c (describe_other_breakpoints): Use address style
1492         to print addresses.
1493         (say_where): Likewise.
1494
1495 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1496
1497         * ada-typeprint.c (print_func_type): Print function name
1498         style to print function name.
1499         * c-typeprint.c (c_print_type_1): Likewise.
1500
1501 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1502
1503         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1504         for execve.
1505
1506 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1507
1508         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1509         type_stack.
1510
1511 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1512
1513         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1514         TYPE_CODE_REF types.
1515
1516 2019-02-08  Jim Wilson  <jimw@sifive.com>
1517
1518         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1519         (riscv_linux_fregset): New.
1520         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1521
1522 2019-02-07  Tom Tromey  <tom@tromey.com>
1523
1524         * thread.c (thread_cancel_execution_command): Update.
1525         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1526         methods.
1527         (struct thread_fsm_ops): Remove.
1528         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1529         (thread_fsm_should_stop, thread_fsm_return_value)
1530         (thread_fsm_set_finished, thread_fsm_finished_p)
1531         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1532         Don't declare.
1533         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1534         * infrun.c (clear_proceed_status_thread)
1535         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1536         (print_stop_event): Update.
1537         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1538         Add constructor.
1539         (step_command_fsm_ops): Remove.
1540         (new_step_command_fsm): Remove.
1541         (step_1): Update.
1542         (step_command_fsm::should_stop): Rename from
1543         step_command_fsm_should_stop.
1544         (step_command_fsm::clean_up): Rename from
1545         step_command_fsm_clean_up.
1546         (step_command_fsm::do_async_reply_reason): Rename from
1547         step_command_fsm_async_reply_reason.
1548         (struct until_next_fsm): Inherit from thread_fsm.  Add
1549         constructor.
1550         (until_next_fsm_ops): Remove.
1551         (new_until_next_fsm): Remove.
1552         (until_next_fsm::should_stop): Rename from
1553         until_next_fsm_should_stop.
1554         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1555         (until_next_fsm::do_async_reply_reason): Rename from
1556         until_next_fsm_async_reply_reason.
1557         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1558         constructor.  Change type of breakpoint.
1559         (finish_command_fsm_ops): Remove.
1560         (new_finish_command_fsm): Remove.
1561         (finish_command_fsm::should_stop): Rename from
1562         finish_command_fsm_should_stop.
1563         (finish_command_fsm::clean_up): Rename from
1564         finish_command_fsm_clean_up.
1565         (finish_command_fsm::return_value): Rename from
1566         finish_command_fsm_return_value.
1567         (finish_command_fsm::do_async_reply_reason): Rename from
1568         finish_command_fsm_async_reply_reason.
1569         (finish_command): Update.
1570         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1571         Add constructor.
1572         (call_thread_fsm_ops): Remove.
1573         (call_thread_fsm::call_thread_fsm): Rename from
1574         new_call_thread_fsm.
1575         (call_thread_fsm::should_stop): Rename from
1576         call_thread_fsm_should_stop.
1577         (call_thread_fsm::should_notify_stop): Rename from
1578         call_thread_fsm_should_notify_stop.
1579         (run_inferior_call, call_function_by_hand_dummy): Update.
1580         * cli/cli-interp.c (should_print_stop_to_console): Update.
1581         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1582         Add constructor.  Change type of location_breakpoint,
1583         caller_breakpoint.
1584         (until_break_fsm_ops): Remove.
1585         (new_until_break_fsm): Remove.
1586         (until_break_fsm::should_stop): Rename from
1587         until_break_fsm_should_stop.
1588         (until_break_fsm::clean_up): Rename from
1589         until_break_fsm_clean_up.
1590         (until_break_fsm::do_async_reply_reason): Rename from
1591         until_break_fsm_async_reply_reason.
1592         (until_break_command): Update.
1593         * thread-fsm.c: Remove.
1594         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1595
1596 2019-02-07  Tom Tromey  <tom@tromey.com>
1597
1598         * yy-remap.h: Add include guard.
1599         * xtensa-tdep.h: Add include guard.
1600         * xcoffread.h: Rename include guard.
1601         * varobj-iter.h: Add include guard.
1602         * tui/tui.h: Rename include guard.
1603         * tui/tui-winsource.h: Rename include guard.
1604         * tui/tui-wingeneral.h: Rename include guard.
1605         * tui/tui-windata.h: Rename include guard.
1606         * tui/tui-win.h: Rename include guard.
1607         * tui/tui-stack.h: Rename include guard.
1608         * tui/tui-source.h: Rename include guard.
1609         * tui/tui-regs.h: Rename include guard.
1610         * tui/tui-out.h: Rename include guard.
1611         * tui/tui-layout.h: Rename include guard.
1612         * tui/tui-io.h: Rename include guard.
1613         * tui/tui-hooks.h: Rename include guard.
1614         * tui/tui-file.h: Rename include guard.
1615         * tui/tui-disasm.h: Rename include guard.
1616         * tui/tui-data.h: Rename include guard.
1617         * tui/tui-command.h: Rename include guard.
1618         * tic6x-tdep.h: Add include guard.
1619         * target/waitstatus.h: Rename include guard.
1620         * target/wait.h: Rename include guard.
1621         * target/target.h: Rename include guard.
1622         * target/resume.h: Rename include guard.
1623         * target-float.h: Rename include guard.
1624         * stabsread.h: Add include guard.
1625         * rs6000-tdep.h: Add include guard.
1626         * riscv-fbsd-tdep.h: Add include guard.
1627         * regformats/regdef.h: Rename include guard.
1628         * record.h: Rename include guard.
1629         * python/python.h: Rename include guard.
1630         * python/python-internal.h: Rename include guard.
1631         * python/py-stopevent.h: Rename include guard.
1632         * python/py-ref.h: Rename include guard.
1633         * python/py-record.h: Rename include guard.
1634         * python/py-record-full.h: Rename include guard.
1635         * python/py-record-btrace.h: Rename include guard.
1636         * python/py-instruction.h: Rename include guard.
1637         * python/py-events.h: Rename include guard.
1638         * python/py-event.h: Rename include guard.
1639         * procfs.h: Add include guard.
1640         * proc-utils.h: Add include guard.
1641         * p-lang.h: Add include guard.
1642         * or1k-tdep.h: Rename include guard.
1643         * observable.h: Rename include guard.
1644         * nto-tdep.h: Rename include guard.
1645         * nat/x86-linux.h: Rename include guard.
1646         * nat/x86-linux-dregs.h: Rename include guard.
1647         * nat/x86-gcc-cpuid.h: Add include guard.
1648         * nat/x86-dregs.h: Rename include guard.
1649         * nat/x86-cpuid.h: Rename include guard.
1650         * nat/ppc-linux.h: Rename include guard.
1651         * nat/mips-linux-watch.h: Rename include guard.
1652         * nat/linux-waitpid.h: Rename include guard.
1653         * nat/linux-ptrace.h: Rename include guard.
1654         * nat/linux-procfs.h: Rename include guard.
1655         * nat/linux-osdata.h: Rename include guard.
1656         * nat/linux-nat.h: Rename include guard.
1657         * nat/linux-namespaces.h: Rename include guard.
1658         * nat/linux-btrace.h: Rename include guard.
1659         * nat/glibc_thread_db.h: Rename include guard.
1660         * nat/gdb_thread_db.h: Rename include guard.
1661         * nat/gdb_ptrace.h: Rename include guard.
1662         * nat/fork-inferior.h: Rename include guard.
1663         * nat/amd64-linux-siginfo.h: Rename include guard.
1664         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1665         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1666         * nat/aarch64-linux.h: Rename include guard.
1667         * nat/aarch64-linux-hw-point.h: Rename include guard.
1668         * mn10300-tdep.h: Add include guard.
1669         * mips-linux-tdep.h: Add include guard.
1670         * mi/mi-parse.h: Rename include guard.
1671         * mi/mi-out.h: Rename include guard.
1672         * mi/mi-main.h: Rename include guard.
1673         * mi/mi-interp.h: Rename include guard.
1674         * mi/mi-getopt.h: Rename include guard.
1675         * mi/mi-console.h: Rename include guard.
1676         * mi/mi-common.h: Rename include guard.
1677         * mi/mi-cmds.h: Rename include guard.
1678         * mi/mi-cmd-break.h: Rename include guard.
1679         * m2-lang.h: Add include guard.
1680         * location.h: Rename include guard.
1681         * linux-record.h: Rename include guard.
1682         * linux-nat.h: Add include guard.
1683         * linux-fork.h: Add include guard.
1684         * i386-darwin-tdep.h: Rename include guard.
1685         * hppa-linux-offsets.h: Add include guard.
1686         * guile/guile.h: Rename include guard.
1687         * guile/guile-internal.h: Rename include guard.
1688         * gnu-nat.h: Rename include guard.
1689         * gdb-stabs.h: Rename include guard.
1690         * frv-tdep.h: Add include guard.
1691         * f-lang.h: Add include guard.
1692         * event-loop.h: Add include guard.
1693         * darwin-nat.h: Rename include guard.
1694         * cp-abi.h: Rename include guard.
1695         * config/sparc/nm-sol2.h: Rename include guard.
1696         * config/nm-nto.h: Rename include guard.
1697         * config/nm-linux.h: Add include guard.
1698         * config/i386/nm-i386gnu.h: Rename include guard.
1699         * config/djgpp/nl_types.h: Rename include guard.
1700         * config/djgpp/langinfo.h: Rename include guard.
1701         * compile/gcc-cp-plugin.h: Add include guard.
1702         * compile/gcc-c-plugin.h: Add include guard.
1703         * compile/compile.h: Rename include guard.
1704         * compile/compile-object-run.h: Rename include guard.
1705         * compile/compile-object-load.h: Rename include guard.
1706         * compile/compile-internal.h: Rename include guard.
1707         * compile/compile-cplus.h: Rename include guard.
1708         * compile/compile-c.h: Rename include guard.
1709         * common/xml-utils.h: Rename include guard.
1710         * common/x86-xstate.h: Rename include guard.
1711         * common/version.h: Rename include guard.
1712         * common/vec.h: Rename include guard.
1713         * common/tdesc.h: Rename include guard.
1714         * common/selftest.h: Rename include guard.
1715         * common/scoped_restore.h: Rename include guard.
1716         * common/scoped_mmap.h: Rename include guard.
1717         * common/scoped_fd.h: Rename include guard.
1718         * common/safe-iterator.h: Rename include guard.
1719         * common/run-time-clock.h: Rename include guard.
1720         * common/refcounted-object.h: Rename include guard.
1721         * common/queue.h: Rename include guard.
1722         * common/ptid.h: Rename include guard.
1723         * common/print-utils.h: Rename include guard.
1724         * common/preprocessor.h: Rename include guard.
1725         * common/pathstuff.h: Rename include guard.
1726         * common/observable.h: Rename include guard.
1727         * common/netstuff.h: Rename include guard.
1728         * common/job-control.h: Rename include guard.
1729         * common/host-defs.h: Rename include guard.
1730         * common/gdb_wait.h: Rename include guard.
1731         * common/gdb_vecs.h: Rename include guard.
1732         * common/gdb_unlinker.h: Rename include guard.
1733         * common/gdb_unique_ptr.h: Rename include guard.
1734         * common/gdb_tilde_expand.h: Rename include guard.
1735         * common/gdb_sys_time.h: Rename include guard.
1736         * common/gdb_string_view.h: Rename include guard.
1737         * common/gdb_splay_tree.h: Rename include guard.
1738         * common/gdb_setjmp.h: Rename include guard.
1739         * common/gdb_ref_ptr.h: Rename include guard.
1740         * common/gdb_optional.h: Rename include guard.
1741         * common/gdb_locale.h: Rename include guard.
1742         * common/gdb_assert.h: Rename include guard.
1743         * common/filtered-iterator.h: Rename include guard.
1744         * common/filestuff.h: Rename include guard.
1745         * common/fileio.h: Rename include guard.
1746         * common/environ.h: Rename include guard.
1747         * common/common-utils.h: Rename include guard.
1748         * common/common-types.h: Rename include guard.
1749         * common/common-regcache.h: Rename include guard.
1750         * common/common-inferior.h: Rename include guard.
1751         * common/common-gdbthread.h: Rename include guard.
1752         * common/common-exceptions.h: Rename include guard.
1753         * common/common-defs.h: Rename include guard.
1754         * common/common-debug.h: Rename include guard.
1755         * common/cleanups.h: Rename include guard.
1756         * common/buffer.h: Rename include guard.
1757         * common/btrace-common.h: Rename include guard.
1758         * common/break-common.h: Rename include guard.
1759         * cli/cli-utils.h: Rename include guard.
1760         * cli/cli-style.h: Rename include guard.
1761         * cli/cli-setshow.h: Rename include guard.
1762         * cli/cli-script.h: Rename include guard.
1763         * cli/cli-interp.h: Rename include guard.
1764         * cli/cli-decode.h: Rename include guard.
1765         * cli/cli-cmds.h: Rename include guard.
1766         * charset-list.h: Add include guard.
1767         * buildsym-legacy.h: Rename include guard.
1768         * bfin-tdep.h: Add include guard.
1769         * ax.h: Rename include guard.
1770         * arm-linux-tdep.h: Add include guard.
1771         * arm-fbsd-tdep.h: Add include guard.
1772         * arch/xtensa.h: Rename include guard.
1773         * arch/tic6x.h: Add include guard.
1774         * arch/i386.h: Add include guard.
1775         * arch/arm.h: Rename include guard.
1776         * arch/arm-linux.h: Rename include guard.
1777         * arch/arm-get-next-pcs.h: Rename include guard.
1778         * arch/amd64.h: Add include guard.
1779         * arch/aarch64-insn.h: Rename include guard.
1780         * arch-utils.h: Rename include guard.
1781         * annotate.h: Add include guard.
1782         * amd64-darwin-tdep.h: Rename include guard.
1783         * aarch64-linux-tdep.h: Add include guard.
1784         * aarch64-fbsd-tdep.h: Add include guard.
1785         * aarch32-linux-nat.h: Add include guard.
1786
1787 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1788
1789         * macrotab.c (macro_define_internal): New function that
1790         factorizes macro_define_object_internal and macro_define_function
1791         code.
1792         (macro_define_object_internal): Use macro_define_internal.
1793         (macro_define_function): Likewise.
1794
1795 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1796
1797         * macrocmd.c (extract_identifier): Return
1798         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1799         callers.
1800
1801 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1802
1803         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1804
1805 2019-02-05  Tom Tromey  <tom@tromey.com>
1806
1807         * target.c (target_stack::unpush): Move assertion earlier.
1808
1809 2019-01-30  Tom Tromey  <tom@tromey.com>
1810
1811         PR python/23615:
1812         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1813         (gdbpy_parse_and_eval): Likewise.
1814         * python/python-internal.h (gdbpy_allow_threads): New class.
1815
1816 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1817
1818         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1819         (aarch64_fbsd_fpregmap): Move earlier.
1820         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1821         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1822         instead of individual calls to trad_frame_set_reg_addr.
1823         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1824         earlier.
1825         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1826         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1827         instead of individual calls to trad_frame_set_reg_addr.
1828
1829 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1830
1831         * CONTRIBUTE: Replace contribution list with wiki link.
1832
1833 2019-01-25  Tom Tromey  <tom@tromey.com>
1834
1835         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1836
1837 2019-01-25  Tom Tromey  <tom@tromey.com>
1838
1839         * xtensa-linux-nat.c: Fix common/ includes.
1840         * xml-support.h: Fix common/ includes.
1841         * xml-support.c: Fix common/ includes.
1842         * x86-linux-nat.c: Fix common/ includes.
1843         * windows-nat.c: Fix common/ includes.
1844         * varobj.h: Fix common/ includes.
1845         * varobj.c: Fix common/ includes.
1846         * value.c: Fix common/ includes.
1847         * valops.c: Fix common/ includes.
1848         * utils.c: Fix common/ includes.
1849         * unittests/xml-utils-selftests.c: Fix common/ includes.
1850         * unittests/utils-selftests.c: Fix common/ includes.
1851         * unittests/unpack-selftests.c: Fix common/ includes.
1852         * unittests/tracepoint-selftests.c: Fix common/ includes.
1853         * unittests/style-selftests.c: Fix common/ includes.
1854         * unittests/string_view-selftests.c: Fix common/ includes.
1855         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1856         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1857         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1858         * unittests/rsp-low-selftests.c: Fix common/ includes.
1859         * unittests/parse-connection-spec-selftests.c: Fix common/
1860         includes.
1861         * unittests/optional-selftests.c: Fix common/ includes.
1862         * unittests/offset-type-selftests.c: Fix common/ includes.
1863         * unittests/observable-selftests.c: Fix common/ includes.
1864         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1865         * unittests/memrange-selftests.c: Fix common/ includes.
1866         * unittests/memory-map-selftests.c: Fix common/ includes.
1867         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1868         * unittests/function-view-selftests.c: Fix common/ includes.
1869         * unittests/environ-selftests.c: Fix common/ includes.
1870         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1871         * unittests/common-utils-selftests.c: Fix common/ includes.
1872         * unittests/cli-utils-selftests.c: Fix common/ includes.
1873         * unittests/array-view-selftests.c: Fix common/ includes.
1874         * ui-file.c: Fix common/ includes.
1875         * tui/tui-io.c: Fix common/ includes.
1876         * tracepoint.h: Fix common/ includes.
1877         * tracepoint.c: Fix common/ includes.
1878         * tracefile-tfile.c: Fix common/ includes.
1879         * top.h: Fix common/ includes.
1880         * top.c: Fix common/ includes.
1881         * thread.c: Fix common/ includes.
1882         * target/waitstatus.h: Fix common/ includes.
1883         * target/waitstatus.c: Fix common/ includes.
1884         * target.h: Fix common/ includes.
1885         * target.c: Fix common/ includes.
1886         * target-memory.c: Fix common/ includes.
1887         * target-descriptions.c: Fix common/ includes.
1888         * symtab.h: Fix common/ includes.
1889         * symfile.c: Fix common/ includes.
1890         * stap-probe.c: Fix common/ includes.
1891         * spu-linux-nat.c: Fix common/ includes.
1892         * sparc-nat.c: Fix common/ includes.
1893         * source.c: Fix common/ includes.
1894         * solib.c: Fix common/ includes.
1895         * solib-target.c: Fix common/ includes.
1896         * ser-unix.c: Fix common/ includes.
1897         * ser-tcp.c: Fix common/ includes.
1898         * ser-pipe.c: Fix common/ includes.
1899         * ser-base.c: Fix common/ includes.
1900         * selftest-arch.c: Fix common/ includes.
1901         * s12z-tdep.c: Fix common/ includes.
1902         * rust-exp.y: Fix common/ includes.
1903         * rs6000-aix-tdep.c: Fix common/ includes.
1904         * riscv-tdep.c: Fix common/ includes.
1905         * remote.c: Fix common/ includes.
1906         * remote-notif.h: Fix common/ includes.
1907         * remote-fileio.h: Fix common/ includes.
1908         * remote-fileio.c: Fix common/ includes.
1909         * regcache.h: Fix common/ includes.
1910         * regcache.c: Fix common/ includes.
1911         * record-btrace.c: Fix common/ includes.
1912         * python/python.c: Fix common/ includes.
1913         * python/py-type.c: Fix common/ includes.
1914         * python/py-inferior.c: Fix common/ includes.
1915         * progspace.h: Fix common/ includes.
1916         * producer.c: Fix common/ includes.
1917         * procfs.c: Fix common/ includes.
1918         * proc-api.c: Fix common/ includes.
1919         * printcmd.c: Fix common/ includes.
1920         * ppc-linux-nat.c: Fix common/ includes.
1921         * parser-defs.h: Fix common/ includes.
1922         * osdata.c: Fix common/ includes.
1923         * obsd-nat.c: Fix common/ includes.
1924         * nat/x86-linux.c: Fix common/ includes.
1925         * nat/x86-linux-dregs.c: Fix common/ includes.
1926         * nat/x86-dregs.h: Fix common/ includes.
1927         * nat/x86-dregs.c: Fix common/ includes.
1928         * nat/ppc-linux.c: Fix common/ includes.
1929         * nat/mips-linux-watch.h: Fix common/ includes.
1930         * nat/mips-linux-watch.c: Fix common/ includes.
1931         * nat/linux-waitpid.c: Fix common/ includes.
1932         * nat/linux-ptrace.h: Fix common/ includes.
1933         * nat/linux-ptrace.c: Fix common/ includes.
1934         * nat/linux-procfs.c: Fix common/ includes.
1935         * nat/linux-personality.c: Fix common/ includes.
1936         * nat/linux-osdata.c: Fix common/ includes.
1937         * nat/linux-namespaces.c: Fix common/ includes.
1938         * nat/linux-btrace.h: Fix common/ includes.
1939         * nat/linux-btrace.c: Fix common/ includes.
1940         * nat/fork-inferior.c: Fix common/ includes.
1941         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1942         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1943         * nat/aarch64-linux.c: Fix common/ includes.
1944         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1945         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1946         * namespace.h: Fix common/ includes.
1947         * mips-linux-tdep.c: Fix common/ includes.
1948         * minsyms.c: Fix common/ includes.
1949         * mi/mi-parse.h: Fix common/ includes.
1950         * mi/mi-main.c: Fix common/ includes.
1951         * mi/mi-cmd-env.c: Fix common/ includes.
1952         * memrange.h: Fix common/ includes.
1953         * memattr.c: Fix common/ includes.
1954         * maint.h: Fix common/ includes.
1955         * maint.c: Fix common/ includes.
1956         * main.c: Fix common/ includes.
1957         * machoread.c: Fix common/ includes.
1958         * location.c: Fix common/ includes.
1959         * linux-thread-db.c: Fix common/ includes.
1960         * linux-nat.c: Fix common/ includes.
1961         * linux-fork.c: Fix common/ includes.
1962         * inline-frame.c: Fix common/ includes.
1963         * infrun.c: Fix common/ includes.
1964         * inflow.c: Fix common/ includes.
1965         * inferior.h: Fix common/ includes.
1966         * inferior.c: Fix common/ includes.
1967         * infcmd.c: Fix common/ includes.
1968         * inf-ptrace.c: Fix common/ includes.
1969         * inf-child.c: Fix common/ includes.
1970         * ia64-linux-nat.c: Fix common/ includes.
1971         * i387-tdep.c: Fix common/ includes.
1972         * i386-tdep.c: Fix common/ includes.
1973         * i386-linux-tdep.c: Fix common/ includes.
1974         * i386-linux-nat.c: Fix common/ includes.
1975         * i386-go32-tdep.c: Fix common/ includes.
1976         * i386-fbsd-tdep.c: Fix common/ includes.
1977         * i386-fbsd-nat.c: Fix common/ includes.
1978         * guile/scm-type.c: Fix common/ includes.
1979         * guile/guile.c: Fix common/ includes.
1980         * go32-nat.c: Fix common/ includes.
1981         * gnu-nat.c: Fix common/ includes.
1982         * gdbthread.h: Fix common/ includes.
1983         * gdbarch-selftests.c: Fix common/ includes.
1984         * gdb_usleep.c: Fix common/ includes.
1985         * gdb_select.h: Fix common/ includes.
1986         * gdb_bfd.c: Fix common/ includes.
1987         * gcore.c: Fix common/ includes.
1988         * fork-child.c: Fix common/ includes.
1989         * findvar.c: Fix common/ includes.
1990         * fbsd-nat.c: Fix common/ includes.
1991         * event-top.c: Fix common/ includes.
1992         * event-loop.c: Fix common/ includes.
1993         * dwarf2read.c: Fix common/ includes.
1994         * dwarf2loc.c: Fix common/ includes.
1995         * dwarf2-frame.c: Fix common/ includes.
1996         * dwarf-index-cache.c: Fix common/ includes.
1997         * dtrace-probe.c: Fix common/ includes.
1998         * disasm-selftests.c: Fix common/ includes.
1999         * defs.h: Fix common/ includes.
2000         * csky-tdep.c: Fix common/ includes.
2001         * cp-valprint.c: Fix common/ includes.
2002         * cp-support.h: Fix common/ includes.
2003         * cp-support.c: Fix common/ includes.
2004         * corelow.c: Fix common/ includes.
2005         * completer.h: Fix common/ includes.
2006         * completer.c: Fix common/ includes.
2007         * compile/compile.c: Fix common/ includes.
2008         * compile/compile-loc2c.c: Fix common/ includes.
2009         * compile/compile-cplus-types.c: Fix common/ includes.
2010         * compile/compile-cplus-symbols.c: Fix common/ includes.
2011         * command.h: Fix common/ includes.
2012         * cli/cli-dump.c: Fix common/ includes.
2013         * cli/cli-cmds.c: Fix common/ includes.
2014         * charset.c: Fix common/ includes.
2015         * build-id.c: Fix common/ includes.
2016         * btrace.h: Fix common/ includes.
2017         * btrace.c: Fix common/ includes.
2018         * breakpoint.h: Fix common/ includes.
2019         * breakpoint.c: Fix common/ includes.
2020         * ax.h:
2021         (enum agent_op): Fix common/ includes.
2022         * ax-general.c (struct aop_map): Fix common/ includes.
2023         * ax-gdb.c: Fix common/ includes.
2024         * auxv.c: Fix common/ includes.
2025         * auto-load.c: Fix common/ includes.
2026         * arm-tdep.c: Fix common/ includes.
2027         * arch/riscv.c: Fix common/ includes.
2028         * arch/ppc-linux-common.c: Fix common/ includes.
2029         * arch/i386.c: Fix common/ includes.
2030         * arch/arm.c: Fix common/ includes.
2031         * arch/arm-linux.c: Fix common/ includes.
2032         * arch/arm-get-next-pcs.c: Fix common/ includes.
2033         * arch/amd64.c: Fix common/ includes.
2034         * arch/aarch64.c: Fix common/ includes.
2035         * arch/aarch64-insn.c: Fix common/ includes.
2036         * arch-utils.c: Fix common/ includes.
2037         * amd64-windows-tdep.c: Fix common/ includes.
2038         * amd64-tdep.c: Fix common/ includes.
2039         * amd64-sol2-tdep.c: Fix common/ includes.
2040         * amd64-obsd-tdep.c: Fix common/ includes.
2041         * amd64-nbsd-tdep.c: Fix common/ includes.
2042         * amd64-linux-tdep.c: Fix common/ includes.
2043         * amd64-linux-nat.c: Fix common/ includes.
2044         * amd64-fbsd-tdep.c: Fix common/ includes.
2045         * amd64-fbsd-nat.c: Fix common/ includes.
2046         * amd64-dicos-tdep.c: Fix common/ includes.
2047         * amd64-darwin-tdep.c: Fix common/ includes.
2048         * agent.c: Fix common/ includes.
2049         * ada-lang.h: Fix common/ includes.
2050         * ada-lang.c: Fix common/ includes.
2051         * aarch64-tdep.c: Fix common/ includes.
2052
2053 2019-01-25  Tom Tromey  <tom@tromey.com>
2054
2055         * common/create-version.sh: Use common/version.h.
2056
2057 2019-01-24  Pedro Alves  <palves@redhat.com>
2058
2059         * infrun.c (signal_stop, signal_print, signal_program)
2060         (signal_catch, signal_pass): Now arrays instead of pointers.
2061         (update_signals_program_target, do_target_resume)
2062         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2063         * linux-nat.c (linux_nat_target::pass_signals)
2064         (linux_nat_target::create_inferior, linux_nat_target::attach):
2065         Adjust.
2066         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2067         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2068         * procfs.c (procfs_target::pass_signals): Adjust.
2069         * record-full.c (record_full_target::resume): Adjust.
2070         * remote.c (remote_target::pass_signals)
2071         (remote_target::program_signals): Adjust.
2072         * target-debug.h (target_debug_print_signals): Now takes a
2073         gdb::array_view as parameter.  Adjust.
2074         * target.h (target_ops) <pass_signals, program_signals>: Replace
2075         pointer and length parameters with gdb::array_view.
2076         (target_pass_signals, target_program_signals): Likewise.
2077         * target-delegates.c: Regenerate.
2078
2079 2019-01-24  Pedro Alves  <palves@redhat.com>
2080
2081         * common/forward-scope-exit.h
2082         (forward_scope_exit::forward_scope_exit): Pass arguments to
2083         m_bind_function directly, instead of creating a std::bind and
2084         copying that.
2085
2086 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2087
2088         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2089         for static members.
2090         (pass_in_v_vfp_candidate): Likewise.
2091
2092 2019-01-23  Tom Tromey  <tom@tromey.com>
2093             Pedro Alves  <palves@redhat.com>
2094
2095         * regcache.c (class regcache_invalidator): Remove.
2096         (regcache::raw_write): Use make_scope_exit.
2097
2098 2019-01-23  Tom Tromey  <tom@tromey.com>
2099
2100         * ui-out.h (class ui_out_emit_type): Update comment.
2101
2102 2019-01-23  Tom Tromey  <tom@tromey.com>
2103
2104         * infrun.c (fetch_inferior_event): Update comment.
2105
2106 2019-01-23  Tom Tromey  <tom@tromey.com>
2107             Pedro Alves  <palves@redhat.com>
2108
2109         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2110         parameter.
2111         (fetch_inferior_event): Use SCOPE_EXIT.
2112
2113
2114 2019-01-23  Tom Tromey  <tom@tromey.com>
2115             Pedro Alves  <palves@redhat.com>
2116
2117         * infrun.c (disable_thread_events): Delete.
2118         (stop_all_threads): Use SCOPE_EXIT.
2119
2120 2019-01-23  Tom Tromey  <tom@tromey.com>
2121             Pedro Alves  <palves@redhat.com>
2122
2123         * symfile.c: Include forward-scope-exit.h.
2124         (clear_symtab_users_cleanup): Replace forward declaration with
2125         a FORWARD_SCOPE_EXIT.
2126         (syms_from_objfile_1): Use the forward_scope_exit and
2127         gdb::optional instead of cleanup_function.
2128         (reread_symbols): Use the forward_scope_exit instead of
2129         cleanup_function.
2130         (clear_symtab_users_cleanup): Remove function.
2131
2132 2019-01-23  Tom Tromey  <tom@tromey.com>
2133             Pedro Alves  <palves@redhat.com>
2134
2135         * linux-nat.c: Include scope-exit.h.
2136         (cleanup_target_stop): Remove.
2137         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2138         SCOPE_EXIT.
2139
2140 2019-01-23  Tom Tromey  <tom@tromey.com>
2141             Pedro Alves  <palves@redhat.com>
2142
2143         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2144         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2145
2146 2019-01-23  Tom Tromey  <tom@tromey.com>
2147             Andrew Burgess  <andrew.burgess@embecosm.com>
2148             Pedro Alves  <palves@redhat.com>
2149
2150         * infrun.c (fetch_inferior_event): Use scope_exit.
2151         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2152         * top.c (execute_command): Use scope_exit.
2153         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2154         * utils.c (do_bpstat_clear_actions_cleanup)
2155         (make_bpstat_clear_actions_cleanup): Remove.
2156
2157 2019-01-23  Tom Tromey  <tom@tromey.com>
2158             Pedro Alves  <palves@redhat.com>
2159
2160         * infrun.c: Include "common/scope-exit.h"
2161         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2162         (wait_for_inferior): Use SCOPE_EXIT.
2163         (fetch_inferior_event): Use scope_exit.
2164
2165 2019-01-23  Tom Tromey  <tom@tromey.com>
2166             Pedro Alves  <palves@redhat.com>
2167
2168         * breakpoint.c (create_breakpoint): Remove cleanup.
2169
2170 2019-01-23  Tom Tromey  <tom@tromey.com>
2171             Andrew Burgess  <andrew.burgess@embecosm.com>
2172             Pedro Alves  <palves@redhat.com>
2173
2174 2019-01-23  Pedro Alves  <palves@redhat.com>
2175
2176         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2177
2178 2019-01-23  Pedro Alves  <palves@redhat.com>
2179             Andrew Burgess  <andrew.burgess@embecosm.com>
2180
2181         * gdbthread.h: Include "common/forward-scope-exit.h".
2182         (scoped_finish_thread_state): Redefine custom class in terms of
2183         forward_scope_exit.
2184
2185 2019-01-23  Pedro Alves  <palves@redhat.com>
2186             Andrew Burgess  <andrew.burgess@embecosm.com>
2187
2188         * common/forward-scope-exit.h: New file.
2189
2190 2019-01-23  Pedro Alves  <palves@redhat.com>
2191             Andrew Burgess  <andrew.burgess@embecosm.com>
2192             Tom Tromey  <tom@tromey.com>
2193
2194         * common/scope-exit.h: New file.
2195
2196 2019-01-23  Pedro Alves  <palves@redhat.com>
2197
2198         * common/preprocessor.h (ESC): Rename to ...
2199         (ESC_PARENS): ... this.
2200         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2201         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2202
2203 2019-01-23  Tom Tromey  <tom@tromey.com>
2204
2205         * language.h (class scoped_switch_to_sym_language_if_auto):
2206         Initialize m_lang in both cases.
2207
2208 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2209
2210         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2211         with XCNEW.
2212
2213 2019-01-22  Tom Tromey  <tom@tromey.com>
2214
2215         * corelow.c: Do not include sys/file.h.
2216
2217 2019-01-22  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-wingeneral.h: Include gdb_curses.h.
2220
2221 2019-01-22  Tom Tromey  <tom@tromey.com>
2222
2223         * source-cache.h (class source_cache) <get_source_lines,
2224         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2225
2226 2019-01-22  Tom Tromey  <tom@tromey.com>
2227
2228         * remote-fileio.h (struct remote_target): Declare.
2229
2230 2019-01-22  Tom Tromey  <tom@tromey.com>
2231
2232         * python/py-arch.c: Do not include py-ref.h.
2233         * python/py-bpevent.c: Do not include py-ref.h.
2234         * python/py-cmd.c: Do not include py-ref.h.
2235         * python/py-continueevent.c: Do not include py-ref.h.
2236         * python/py-event.h: Do not include py-ref.h.
2237         * python/py-evtregistry.c: Do not include py-ref.h.
2238         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2239         * python/py-frame.c: Do not include py-ref.h.
2240         * python/py-framefilter.c: Do not include py-ref.h.
2241         * python/py-function.c: Do not include py-ref.h.
2242         * python/py-infevents.c: Do not include py-ref.h.
2243         * python/py-linetable.c: Do not include py-ref.h.
2244         * python/py-objfile.c: Do not include py-ref.h.
2245         * python/py-param.c: Do not include py-ref.h.
2246         * python/py-prettyprint.c: Do not include py-ref.h.
2247         * python/py-progspace.c: Do not include py-ref.h.
2248         * python/py-symbol.c: Do not include py-ref.h.
2249         * python/py-symtab.c: Do not include py-ref.h.
2250         * python/py-type.c: Do not include py-ref.h.
2251         * python/py-unwind.c: Do not include py-ref.h.
2252         * python/py-utils.c: Do not include py-ref.h.
2253         * python/py-value.c: Do not include py-ref.h.
2254         * python/py-varobj.c: Do not include py-ref.h.
2255         * python/py-xmethods.c: Do not include py-ref.h.
2256         * python/python.c: Do not include py-ref.h.
2257         * varobj.c: Do not include py-ref.h.
2258
2259 2019-01-22  Tom Tromey  <tom@tromey.com>
2260
2261         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2262         keyword for bcache.
2263
2264 2019-01-22  Tom Tromey  <tom@tromey.com>
2265
2266         * compile/compile-cplus-types.c: Remove a comment by #include.
2267
2268 2019-01-22  Tom Tromey  <tom@tromey.com>
2269
2270         * compile/gcc-c-plugin.h: Include compile-internal.h.
2271
2272 2019-01-22  Tom Tromey  <tom@tromey.com>
2273
2274         * stabsread.c (EXTERN): Do not define.
2275         (symnum, next_symbol_text_func, processing_gcc_compilation)
2276         (within_function, global_sym_chain, global_stabs)
2277         (previous_stab_code, this_object_header_files)
2278         (n_this_object_header_files)
2279         (n_allocated_this_object_header_files): Define.
2280         * stabsread.h (EXTERN): Never define.  Use "extern".
2281
2282 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2283
2284         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2285         history_value.
2286
2287 2019-01-21  Tom Tromey  <tom@tromey.com>
2288
2289         * ui-out.c: Fix includes.
2290         * tui/tui-source.c: Fix includes.
2291         * target.c: Fix includes.
2292         * remote.c: Fix includes.
2293         * regcache.c: Fix includes.
2294         * python/py-block.c: Fix includes.
2295         * printcmd.c: Fix includes.
2296         * or1k-tdep.c: Fix includes.
2297         * mi/mi-main.c: Fix includes.
2298         * m32r-tdep.c: Fix includes.
2299         * csky-tdep.c: Fix includes.
2300         * compile/compile-cplus-types.c: Fix includes.
2301         * cli/cli-interp.c: Fix includes.
2302
2303 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2304
2305         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2306         for padding.
2307
2308 2019-01-16  Tom Tromey  <tom@tromey.com>
2309
2310         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2311         earlier.
2312         (struct objfile) <msymbols_range>: Move from top level.
2313         <msymbols>: New method.
2314         (class objfile_msymbols): Remove.
2315         * symtab.c (default_collect_symbol_completion_matches_break_on):
2316         Update.
2317         * symmisc.c (dump_msymbols): Update.
2318         * stabsread.c (scan_file_globals): Update.
2319         * objc-lang.c (info_selectors_command, info_classes_command)
2320         (find_methods): Update.
2321         * minsyms.c (find_solib_trampoline_target): Update.
2322         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2323         * coffread.c (coff_symfile_read): Update.
2324         * ada-lang.c (ada_lookup_simple_minsym)
2325         (ada_collect_symbol_completion_matches): Update.
2326
2327 2019-01-16  Tom Tromey  <tom@tromey.com>
2328
2329         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2330         type.  Remove no-argument constructor.
2331         <iterator::operator++>: Simplify.
2332         <begin>: Update.
2333         <end>: Use minimal_symbol_count.
2334
2335 2019-01-16  Tom Tromey  <tom@tromey.com>
2336
2337         * objfiles.h (struct objfile) <psymtabs>: New method.
2338         (class objfile_psymtabs): Remove.
2339         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2340         typedef.
2341         <range>: New method.
2342         (require_partial_symbols): Change return type.
2343         * psymtab.c (require_partial_symbols)
2344         (psym_expand_symtabs_matching): Update.
2345         * mdebugread.c (parse_partial_symbols): Update.
2346         * dbxread.c (dbx_end_psymtab): Update.
2347
2348 2019-01-15  Tom Tromey  <tom@tromey.com>
2349
2350         * symtab.c (lookup_objfile_from_block)
2351         (lookup_symbol_in_objfile_symtabs)
2352         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2353         (find_line_symtab, info_sources_command)
2354         (default_collect_symbol_completion_matches_break_on)
2355         (make_source_files_completion_list): Update.
2356         * symmisc.c (print_objfile_statistics, dump_objfile)
2357         (maintenance_print_symbols, maintenance_info_symtabs)
2358         (maintenance_check_symtabs, maintenance_info_line_tables):
2359         Update.
2360         * source.c (select_source_symtab)
2361         (forget_cached_source_info_for_objfile): Update.
2362         * objfiles.h (class objfile_compunits): Remove.
2363         (struct objfile) <compunits_range>: New typedef.
2364         (compunits): New method.
2365         * objfiles.c (objfile_relocate1): Update.
2366         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2367         * maint.c (count_symtabs_and_blocks): Update.
2368         * linespec.c (iterate_over_all_matching_symtabs): Update.
2369         * cp-support.c (add_symbol_overload_list_qualified): Update.
2370         * coffread.c (coff_symtab_read): Update.
2371         * ada-lang.c (add_nonlocal_symbols)
2372         (ada_collect_symbol_completion_matches)
2373         (ada_add_global_exceptions): Update.
2374
2375 2019-01-15  Tom Tromey  <tom@tromey.com>
2376
2377         * progspace.h (program_space) <objfiles_safe_range>: New
2378         typedef.
2379         <objfiles_safe>: New method.
2380         * objfiles.h (class all_objfiles_safe): Remove.
2381         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2382         * jit.c (jit_inferior_exit_hook): Update.
2383
2384 2019-01-17  Tom Tromey  <tom@tromey.com>
2385
2386         * progspace.h (program_space) <objfiles_range>: New typedef.
2387         <objfiles>: New method.
2388         <objfiles_head>: Rename from objfiles.
2389         (object_files): Update.
2390         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2391         * guile/scm-pretty-print.c
2392         (ppscm_find_pretty_printer_from_objfiles): Update.
2393         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2394         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2395         Update.
2396         * python/py-progspace.c (pspy_get_objfiles): Update.
2397         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2398         Update.
2399         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2400         (objfpy_lookup_objfile_by_build_id): Update.
2401         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2402         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2403         Update.
2404         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2405         (expand_symtab_containing_pc, lookup_objfile_from_block)
2406         (lookup_static_symbol, basic_lookup_transparent_type)
2407         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2408         (find_line_symtab, info_sources_command)
2409         (default_collect_symbol_completion_matches_break_on)
2410         (make_source_files_completion_list, find_main_name): Update.
2411         * symmisc.c (print_symbol_bcache_statistics)
2412         (print_objfile_statistics, maintenance_print_symbols)
2413         (maintenance_print_msymbols, maintenance_print_objfiles)
2414         (maintenance_info_symtabs, maintenance_check_symtabs)
2415         (maintenance_expand_symtabs, maintenance_info_line_tables):
2416         Update.
2417         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2418         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2419         (map_overlay_command, unmap_overlay_command)
2420         (simple_overlay_update, expand_symtabs_matching)
2421         (map_symbol_filenames): Update.
2422         * symfile-debug.c (set_debug_symfile): Update.
2423         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2424         Update.
2425         * source.c (select_source_symtab, forget_cached_source_info):
2426         Update.
2427         * solib.c (solib_read_symbols): Update.
2428         * solib-spu.c (append_ocl_sos): Update.
2429         * psymtab.c (maintenance_print_psymbols)
2430         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2431         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2432         * printcmd.c (info_symbol_command): Update.
2433         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2434         Update.
2435         * objfiles.h (class all_objfiles): Remove.
2436         * objfiles.c (have_partial_symbols, have_full_symbols)
2437         (have_minimal_symbols, qsort_cmp, update_section_map)
2438         (shared_objfile_contains_address_p)
2439         (default_iterate_over_objfiles_in_search_order): Update.
2440         * objc-lang.c (info_selectors_command, info_classes_command)
2441         (find_methods): Update.
2442         * minsyms.c (find_solib_trampoline_target): Update.
2443         * maint.c (maintenance_info_sections)
2444         (maintenance_translate_address, count_symtabs_and_blocks):
2445         Update.
2446         * main.c (captured_main_1): Update.
2447         * linux-thread-db.c (try_thread_db_load_from_pdir)
2448         (has_libpthread): Update.
2449         * linespec.c (iterate_over_all_matching_symtabs)
2450         (search_minsyms_for_name): Update.
2451         * jit.c (jit_find_objf_with_entry_addr): Update.
2452         * hppa-tdep.c (find_unwind_entry)
2453         (hppa_lookup_stub_minimal_symbol): Update.
2454         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2455         Update.
2456         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2457         (elf_gnu_ifunc_resolve_by_got): Update.
2458         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2459         * dwarf-index-write.c (save_gdb_index_command): Update.
2460         * cp-support.c (add_symbol_overload_list_qualified): Update.
2461         * breakpoint.c (create_overlay_event_breakpoint)
2462         (create_longjmp_master_breakpoint)
2463         (create_std_terminate_master_breakpoint)
2464         (create_exception_master_breakpoint): Update.
2465         * blockframe.c (find_pc_partial_function): Update.
2466         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2467         (ada_collect_symbol_completion_matches)
2468         (ada_add_global_exceptions): Update.
2469
2470 2019-01-17  Tom Tromey  <tom@tromey.com>
2471
2472         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2473         declare VEC.
2474         (solib_target_parse_libraries): Change return type.
2475         (library_list_start_segment, library_list_start_section)
2476         (library_list_end_library, library_list_start_library); Update.
2477         (solib_target_free_library_list): Remove.
2478         (solib_target_parse_libraries): Remove cleanup.  Change return
2479         type.
2480         (solib_target_current_sos): Update.
2481
2482 2019-01-17  Tom Tromey  <tromey@bapiya>
2483
2484         * valprint.c: Replace "the the" with "the".
2485         * symtab.c: Replace "the the" with "the".
2486         * solib.c: Replace "the the" with "the".
2487         * solib-dsbt.c: Replace "the the" with "the".
2488         * linespec.c: Replace "the the" with "the".
2489         * dwarf2loc.h: Replace "the the" with "the".
2490         * amd64-windows-tdep.c: Replace "the the" with "the".
2491         * aarch64-tdep.c: Replace "the the" with "the".
2492
2493 2019-01-16  Keith Seitz  <keiths@redhat.com>
2494
2495         PR gdb/23773
2496         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2497         <builder>: Rename to ..
2498         <m_builder>: ... this and make private.
2499         (dwarf2_cu::get_builder): New method.  Change all users of
2500         `builder' to use this method.
2501         (dwarf2_start_symtab): Move to ...
2502         (dwarf2_cu::start_symtab): ... here.  Update all callers
2503         (setup_type_unit_groups): Move to ...
2504         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2505         callers.
2506         (dwarf2_cu::reset_builder): New method.
2507         (process_full_compunit, process_full_type_unit): Use
2508         dwarf2_cu::reset_builder.
2509         (follow_die_offset): Record the ancestor CU if it is different
2510         from the followed DIE's CU.
2511         (follow_die_sig_1): Likewise.
2512
2513 2019-01-15  Tom Tromey  <tom@tromey.com>
2514
2515         * remote.c (class remote_state) <buf>: Now a char_vector.
2516         <buf_size>: Remove.
2517         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2518         parameter.
2519         (remote_target::getpkt_or_notif_sane_1)
2520         (remote_target::getpkt_sane)
2521         (remote_target::getpkt_or_notif_sane): Likewise.
2522         (class remote_target) <putpkt>: New overload.
2523         (remote_target::read_frame): Change type of "buf_p".  Remove
2524         sizeof_p parameter.
2525         (packet_ok): New overload.
2526         (packet_check_result): New overload.
2527         Update all uses.
2528
2529 2019-01-14  Tom Tromey  <tom@tromey.com>
2530
2531         * remote-notif.c (handle_notification, remote_notif_ack)
2532         (remote_notif_parse): Make "buf" const.
2533         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2534         const.
2535         (remote_notif_parse, remote_notif_ack, handle_notification):
2536         Likewise.
2537         * remote.c (remote_notif_stop_parse): Make "buf" const.
2538         (remote_target::remote_parse_stop_reply): Make "buf" const.
2539         (remote_notif_stop_ack): Make "buf" const.
2540
2541 2019-01-14  Tom Tromey  <tom@tromey.com>
2542
2543         * remote.c (remote_console_output): Make parameter const.
2544
2545 2019-01-14  Tom Tromey  <tom@tromey.com>
2546
2547         * target-debug.h (target_debug_print_signals): Constify.
2548         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2549         * procfs.c (procfs_target::pass_signals): Update.
2550         * linux-nat.c (linux_nat_target::pass_signals): Update.
2551         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2552         * target-delegates.c: Rebuild.
2553         * remote.c (remote_target::program_signals): Update.
2554         (remote_target::pass_signals): Update.
2555         * target.c (target_pass_signals): Constify argument.
2556         (target_program_signals): Likewise.
2557         * target.h (struct target_ops) <pass_signals, program_signals>:
2558         Constify argument.
2559         (target_pass_signals, target_program_signals): Constify argument.
2560
2561 2019-01-14  Tom Tromey  <tom@tromey.com>
2562
2563         PR tui/28819:
2564         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2565
2566 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2567
2568         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2569         field.
2570         * rs6000-tdep.c: Include reggroups.h.
2571         (IS_V_ALIAS_PSEUDOREG): Define.
2572         (rs6000_register_name): Return names for the "vX" aliases.
2573         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2574         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2575         aliases.  Call default_register_reggroup_p for all other
2576         pseudo-registers.
2577         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2578         New functions.
2579         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2580         Handle "vX" aliases.
2581         (v_alias_pseudo_register_collect): New function.
2582         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2583         (rs6000_gdbarch_init): Initialize "vX" aliases as
2584         pseudo-registers.  Restore registration of
2585         rs6000_pseudo_register_reggroup_p with
2586         set_tdesc_pseudo_register_reggroup_p.
2587
2588 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2589
2590         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2591         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2592         set_gdbarch_num_pseudo_regs.
2593
2594 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2595
2596         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2597         Remove arg prefixname, add do_set and do_show.
2598         Add member functions set_list and show_list.
2599         * cli/cli-style.c (class cli_style_option): Update accordingly.
2600         (style_set_list): Move to file scope.
2601         (style_show_list): Likewise.
2602         (set_style): Call help_list.
2603         (show_style): Call cmd_show_list.
2604         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2605         Update to use the new macro.
2606
2607 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2608
2609         * ada-lang.c (_initialize_ada_language): Expand the help text
2610         for the "catch exception" command.
2611
2612 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2613
2614         * symtab.c (matching_obj_sections): Initialize obj,
2615         declare it closer to its usage.
2616
2617 2019-01-10  Tom Tromey  <tom@tromey.com>
2618
2619         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2620         (basic_inf_threads_range): Remove.
2621         (inf_threads_range, inf_non_exited_threads_range)
2622         (safe_inf_threads_range): Use next_adapter.
2623
2624 2019-01-10  Keith Seitz  <keiths@redhat.com>
2625
2626         PR gdb/23712
2627         PR symtab/23010
2628         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2629         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2630
2631 2019-01-10  Keith Seitz  <keiths@redhat.com>
2632
2633         PR gdb/23712
2634         PR symtab/23010
2635         * dictionary.c (pending_to_vector): Remove.
2636         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2637         Remove _1 suffix, replacing functions of the same name.  Update
2638         all callers.
2639         (dict_create_hashed, dict_create_hashed_expandable)
2640         (dict_create_linear, dict_create_linear_expandable, dict_free)
2641         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2642         Make functions static.
2643
2644 2019-01-10  Keith Seitz  <keiths@redhat.com>
2645
2646         PR gdb/23712
2647         PR symtab/23010
2648         * dictionary.h (struct dictionary): Replace declaration with
2649         multidictionary.
2650         (dict_create_hashed, dict_create_hashed_expandable)
2651         (dict_create_linear, dict_create_linear_expandable)
2652         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2653         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2654         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2655         taking multidictionary argument.
2656         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2657         * block.h (struct block) <dict>: Change to multidictionary
2658         and rename `multidict'.
2659         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2660         symmisc.c: Update all dictionary references to multidictionary.
2661
2662 2019-01-10  Keith Seitz  <keiths@redhat.com>
2663
2664         PR gdb/23712
2665         PR symtab/23010
2666         * dictionary.c: Include unordered_map.
2667         (pending_to_vector): New function.
2668         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2669         Rewrite the non-"_1" functions to take vector instead
2670         of linked list.
2671         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2672         "new" _1 versions of the same name.
2673         (multidictionary): Define.
2674         (std::hash<enum language): New definition.
2675         (collate_pending_symbols_by_language, mdict_create_hashed)
2676         (mdict_create_hashed_expandable, mdict_create_linear)
2677         (mdict_create_linear_expandable, mdict_free)
2678         (find_language_dictionary, create_new_language_dictionary)
2679         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2680         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2681         (mdict_size, mdict_empty): New functions.
2682         * dictionary.h (mdict_iterator): Define.
2683
2684 2019-01-10  Pedro Alves  <palves@redhat.com>
2685
2686         * breakpoint.c (read_uploaded_action)
2687         (create_tracepoint_from_upload): Adjust to use
2688         gdb::unique_xmalloc_ptr.
2689         * ctf.c (ctf_write_uploaded_tp):
2690         (SET_ARRAY_FIELD): Use emplace_back.
2691         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2692         * tracefile-tfile.c (tfile_write_uploaded_tp):
2693         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2694         gdb::unique_xmalloc_ptr.
2695         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2696         at_string, cond_string, cmd_strings>: Replace char pointers
2697         with gdb::unique_xmalloc_ptr.
2698
2699 2019-01-10  Pedro Alves  <palves@redhat.com>
2700
2701         * solib-target.c (library_list_start_library): Don't xstrdup name.
2702
2703 2019-01-10  Pedro Alves  <palves@redhat.com>
2704
2705         * mdebugread.c (parse_partial_symbols): Use
2706         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2707
2708 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * linux-fork.c (scoped_switch_fork_info)
2711         <~scoped_switch_fork_info>: Fix incorrect variable name.
2712
2713 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2714
2715         * linux-fork.c (scoped_switch_fork_info)
2716         <scoped_switch_fork_info>: Make explicit.
2717         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2718
2719 2019-01-10  Tom Tromey  <tom@tromey.com>
2720
2721         * objfiles.h (objfile::reset_psymtabs): Update.
2722         * objfiles.c (objfile::objfile): Update.
2723         * psymtab.h (psymtab_storage::obstack): Update.
2724         (psymtab_storage::m_obstack): Use gdb::optional.
2725         (class psymtab_storage): Update comment.  Remove objfile
2726         parameter.
2727         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2728
2729 2019-01-10  Tom Tromey  <tom@tromey.com>
2730
2731         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2732         <free_psymtabs>: Now private.
2733         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2734         (allocate_psymtab): Use new method.
2735
2736 2019-01-10  Tom Tromey  <tom@tromey.com>
2737
2738         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2739         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2740         * mdebugread.c (parse_partial_symbols): Use
2741         allocate_dependencies.
2742         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2743         allocate_dependencies.
2744         (process_psymtab_comp_unit_reader)
2745         (build_type_psymtab_dependencies): Likewise.
2746         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2747
2748 2019-01-10  Tom Tromey  <tom@tromey.com>
2749
2750         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2751         PSYMBOL_SET_LANGUAGE.
2752         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2753
2754 2019-01-10  Tom Tromey  <tom@tromey.com>
2755
2756         * psymtab.h (psymtab_storage::obstack): New method.
2757         <m_obstack>: Rename from obstack; now private.
2758         * psymtab.c (psymtab_storage): Update.
2759         * dwarf2read.c (create_addrmap_from_index)
2760         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2761         Update.
2762
2763 2019-01-10  Tom Tromey  <tom@tromey.com>
2764
2765         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2766         * objfiles.h (objfile::reset_psymtabs): New method.
2767
2768 2019-01-10  Tom Tromey  <tom@tromey.com>
2769
2770         * symmisc.c (print_symbol_bcache_statistics): Update.
2771         (print_objfile_statistics): Update.
2772         * symfile.c (reread_symbols): Update.
2773         * psymtab.h (class psymtab_storage): New.
2774         * psymtab.c (psymtab_storage): New constructor.
2775         (~psymtab_storage): New destructor.
2776         (require_partial_symbols): Update.
2777         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2778         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2779         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2780         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2781         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2782         (start_psymtab_common, end_psymtab_common)
2783         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2784         (allocate_psymtab): Update.
2785         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2786         Update.
2787         (dump_psymtab_addrmap, maintenance_print_psymbols)
2788         (maintenance_check_psymtabs): Update.
2789         (class objfile_psymtabs): Move to objfiles.h.
2790         * psympriv.h (discard_psymtab): Now inline.
2791         (psymtab_discarder::psymtab_discarder): Update.
2792         (psymtab_discarder::~psymtab_discarder): Update.
2793         (ALL_OBJFILE_PSYMTABS): Rewrite.
2794         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2795         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2796         Remove fields.
2797         <partial_symtabs>: New field.
2798         (class objfile_psymtabs): Move from psymtab.h.  Update.
2799         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2800         psymbol_cache.
2801         (objfile::~objfile): Don't destroy psymbol_cache.
2802         * mdebugread.c (parse_partial_symbols): Update.
2803         * dwarf2read.c (create_addrmap_from_index)
2804         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2805         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2806         (add_partial_subprogram, dwarf2_ranges_read): Update.
2807         * dwarf-index-write.c (write_address_map)
2808         (write_one_signatured_type, recursively_write_psymbols)
2809         (class debug_names, class debug_names, write_psymtabs_to_index):
2810         Update.
2811
2812 2019-01-10  Tom Tromey  <tom@tromey.com>
2813
2814         * symtab.h (SYMBOL_SET_NAMES): Update.
2815         (symbol_set_names): Update.
2816         (MSYMBOL_SET_NAMES): Update.
2817         * symtab.c (symbol_set_names): Change argument to be an
2818         objfile_per_bfd_storage.
2819         * psymtab.c (add_psymbol_to_bcache): Update.
2820         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2821
2822 2019-01-10  Tom Tromey  <tom@tromey.com>
2823
2824         * symtab.c (create_demangled_names_hash): Change argument to be an
2825         objfile_per_bfd_storage.
2826         (symbol_set_names): Update.
2827
2828 2019-01-10  Tom Tromey  <tom@tromey.com>
2829
2830         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2831         init_psymbol_list.
2832         * psymtab.c (init_psymbol_list): Do nothing if already called.
2833         * psympriv.h (init_psymbol_list): Add comment.
2834         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2835         init_psymbol_list.
2836         * dbxread.c (dbx_symfile_read): Unconditionally call
2837         init_psymbol_list.
2838
2839 2019-01-10  Tom Tromey  <tom@tromey.com>
2840
2841         * xcoffread.c (scan_xcoff_symtab): Update.
2842         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2843         "where".
2844         * mdebugread.c (parse_partial_symbols)
2845         (handle_psymbol_enumerators): Update.
2846         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2847         * dbxread.c (read_dbx_symtab): Update.
2848         * psympriv.h (psymbol_placement): New enum.
2849         (add_psymbol_to_list): Update.
2850
2851 2019-01-10  Tom Tromey  <tom@tromey.com>
2852
2853         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2854         static_psymbols parameters.
2855         (scan_xcoff_symtab): Update.
2856         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2857         static_psymbols parameters.
2858         * psympriv.h (start_psymtab_common): Update.
2859         * mdebugread.c (parse_partial_symbols): Update.
2860         * dwarf2read.c (create_partial_symtab): Update.
2861         * dbxread.c (read_dbx_symtab): Update.
2862         (start_psymtab): Remove global_psymbols and static_psymbols
2863         parameters.
2864
2865 2019-01-10  Tom Tromey  <tom@tromey.com>
2866
2867         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2868         * psymtab.c (allocate_psymtab): Add comment.
2869         * psympriv.h (allocate_psymtab): Add comment.
2870         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2871         initializations.
2872         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2873
2874 2019-01-10  Tom Tromey  <tom@tromey.com>
2875
2876         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2877         Don't declare.
2878         * mipsread.c: Include mdebugread.h.
2879         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2880         Declare.
2881         * elfread.c: Include mdebugread.h.
2882
2883 2019-01-09  Tom Tromey  <tom@tromey.com>
2884
2885         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2886         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2887         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2888         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2889         (psym_lookup_symbol, psym_find_last_source_symtab)
2890         (psym_forget_cached_source_info, psym_print_stats)
2891         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2892         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2893         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2894         (psym_find_compunit_symtab_by_address)
2895         (maintenance_print_psymbols, maintenance_info_psymtabs)
2896         (maintenance_check_psymtabs): Use ranged for.
2897         * psymtab.h (class objfile_psymtabs): New.
2898         (require_partial_symbols): Return objfile_psymtabs.
2899         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2900
2901 2019-01-09  Tom Tromey  <tom@tromey.com>
2902
2903         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2904         (find_pc_mapped_section, list_overlays_command)
2905         (map_overlay_command, unmap_overlay_command)
2906         (simple_overlay_update): Use all_objfiles.
2907         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2908         * printcmd.c (info_symbol_command): Use all_objfiles.
2909         * objfiles.h (ALL_OBJSECTIONS): Remove.
2910         * maint.c (maintenance_translate_address): Use all_objfiles.
2911         * gcore.c (gcore_create_callback): Use all_objfiles.
2912         (objfile_find_memory_regions): Likewise.
2913
2914 2019-01-09  Tom Tromey  <tom@tromey.com>
2915
2916         * symtab.c (find_line_symtab, info_sources_command)
2917         (make_source_files_completion_list): Use objfile_compunits.
2918         * source.c (select_source_symtab): Use objfile_compunits.
2919         * objfiles.h (struct objfile): Update comment.
2920         (ALL_OBJFILES): Remove.
2921         (ALL_FILETABS): Remove.
2922         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2923         objfile_compunits.
2924
2925 2019-01-09  Tom Tromey  <tom@tromey.com>
2926
2927         * symmisc.c (print_objfile_statistics, dump_objfile)
2928         (maintenance_print_symbols): Use compunit_filetabs.
2929         * source.c (forget_cached_source_info_for_objfile): Use
2930         compunit_filetabs.
2931         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2932         (ALL_FILETABS): Use compunit_filetabs.
2933         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2934         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2935
2936 2019-01-09  Tom Tromey  <tom@tromey.com>
2937
2938         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2939         (compunit_filetabs): New.
2940         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2941         compunit_filetabs.
2942         (info_sources_command, make_source_files_completion_list): Remove
2943         declaration.
2944         * symmisc.c (print_objfile_statistics, dump_objfile)
2945         (maintenance_print_symbols): Remove declaration.
2946         (maintenance_info_symtabs): Use compunit_filetabs.
2947         (maintenance_info_line_tables): Likewise.
2948         * source.c (select_source_symtab): Change local variable name.
2949         (forget_cached_source_info_for_objfile): Remove declaration.
2950         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2951         * objfiles.c (objfile_relocate1): Remove declaration.
2952         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2953         declaration.
2954         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2955         * coffread.c (coff_symtab_read): Remove declaration.
2956         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2957         compunit_filetabs.
2958
2959 2019-01-09  Tom Tromey  <tom@tromey.com>
2960
2961         * symtab.c (lookup_objfile_from_block)
2962         (find_pc_sect_compunit_symtab, search_symbols)
2963         (default_collect_symbol_completion_matches_break_on): Use
2964         objfile_compunits.
2965         * objfiles.h (ALL_COMPUNITS): Remove.
2966         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2967         * cp-support.c (add_symbol_overload_list_qualified): Use
2968         objfile_compunits.
2969         * ada-lang.c (ada_collect_symbol_completion_matches)
2970         (ada_add_global_exceptions): Use objfile_compunits.
2971
2972 2019-01-09  Tom Tromey  <tom@tromey.com>
2973
2974         * source.c (select_source_symtab)
2975         (forget_cached_source_info_for_objfile): Remove declaration.
2976         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2977         declaration.
2978         * maint.c (count_symtabs_and_blocks): Remove declaration.
2979         * cp-support.c (add_symbol_overload_list_qualified): Remove
2980         declaration.
2981         * coffread.c (coff_symtab_read): Remove declaration.
2982         * symtab.c (lookup_symbol_in_objfile_symtabs)
2983         (basic_lookup_transparent_type_1): Use objfile_compunits.
2984         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2985         (info_sources_command, search_symbols)
2986         (default_collect_symbol_completion_matches_break_on)
2987         (make_source_files_completion_list): Remove declaration.
2988         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2989         (ada_collect_symbol_completion_matches)
2990         (ada_add_global_exceptions): Remove declaration.
2991         * linespec.c (iterate_over_all_matching_symtabs): Use
2992         objfile_compunits.
2993         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2994         (class objfile_compunits): New.
2995         (ALL_COMPUNITS): Use objfile_compunits.
2996         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2997         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2998         objfile_compunits.
2999         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3000
3001 2019-01-09  Tom Tromey  <tom@tromey.com>
3002
3003         * symtab.c (search_symbols)
3004         (default_collect_symbol_completion_matches_break_on): Use
3005         objfile_msymbols.
3006         * ada-lang.c (ada_lookup_simple_minsym)
3007         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3008         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3009         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3010         objfile_msymbols.
3011         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3012         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3013         * objc-lang.c (find_methods): Use objfile_msymbols.
3014         (info_selectors_command, info_classes_command): Likewise.
3015         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3016         * objfiles.h (class objfile_msymbols): New.
3017         (ALL_OBJFILE_MSYMBOLS): Remove.
3018         (ALL_MSYMBOLS): Remove.
3019
3020 2019-01-09  Tom Tromey  <tom@tromey.com>
3021
3022         * common/next-iterator.h (next_adapter): Add Iterator template
3023         parameter.
3024         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3025         (class all_objfiles_safe): New.
3026         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3027         * objfiles.c (put_objfile_before): Update comment.
3028         (add_separate_debug_objfile): Likewise.
3029         (free_all_objfiles): Use all_objfiles_safe.
3030         (objfile_purge_solibs): Likewise.
3031
3032 2019-01-09  Tom Tromey  <tom@tromey.com>
3033
3034         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3035         (expand_symtab_containing_pc, lookup_static_symbol)
3036         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3037         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3038         all_objfiles.
3039         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3040         * breakpoint.c (create_overlay_event_breakpoint)
3041         (create_longjmp_master_breakpoint)
3042         (create_std_terminate_master_breakpoint)
3043         (create_exception_master_breakpoint): Use all_objfiles.
3044         * linux-thread-db.c (try_thread_db_load_from_pdir)
3045         (has_libpthread): Use all_objfiles.
3046         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3047         * linespec.c (iterate_over_all_matching_symtabs)
3048         (search_minsyms_for_name): Use all_objfiles.
3049         * maint.c (maintenance_info_sections): Use all_objfiles.
3050         * main.c (captured_main_1): Use all_objfiles.
3051         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3052         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3053         * guile/scm-pretty-print.c
3054         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3055         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3056         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3057         (maintenance_print_msymbols): Use all_objfiles.
3058         * source.c (select_source_symtab): Use all_objfiles.
3059         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3060         * symfile.c (remove_symbol_file_command)
3061         (expand_symtabs_matching, map_symbol_filenames): Use
3062         all_objfiles.
3063         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3064         all_objfiles.
3065         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3066         * objc-lang.c (find_methods): Use all_objfiles.
3067         * objfiles.c (have_partial_symbols, have_full_symbols)
3068         (have_minimal_symbols, qsort_cmp)
3069         (default_iterate_over_objfiles_in_search_order): Use
3070         all_objfiles.
3071         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3072         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3073         (maintenance_check_psymtabs): Use all_objfiles.
3074         (ALL_PSYMTABS): Remove.
3075         * compile/compile-object-run.c (do_module_cleanup): Use
3076         all_objfiles.
3077         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3078         * cp-support.c (add_symbol_overload_list_qualified): Use
3079         all_objfiles.
3080         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3081         Use all_objfiles.
3082         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3083         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3084         all_objfiles.
3085         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3086         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3087         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3088         Uses all_objfiles.
3089         * solib.c (solib_read_symbols): Use all_objfiles
3090
3091 2019-01-09  Tom Tromey  <tom@tromey.com>
3092
3093         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3094         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3095         all_objfiles.
3096         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3097         * symmisc.c (print_symbol_bcache_statistics)
3098         (print_objfile_statistics, maintenance_print_objfiles)
3099         (maintenance_info_symtabs, maintenance_check_symtabs)
3100         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3101         all_objfiles.
3102         * source.c (forget_cached_source_info): Use all_objfiles.
3103         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3104         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3105         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3106         * objfiles.c (update_section_map): Use all_objfiles.
3107         (shared_objfile_contains_address_p): Likewise.
3108         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3109         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3110
3111 2019-01-09  Tom Tromey  <tom@tromey.com>
3112
3113         * common/next-iterator.h: New file.
3114         * objfiles.h (class all_objfiles): New.
3115         (struct objfile_iterator): New.
3116
3117 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3118
3119         * NEWS: Move the description of the changed "frame", "select-frame",
3120          and "info frame" commands to the Changed commands section.
3121
3122 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3123
3124         * gdbtypes.c (check_stub_method_group): Remove handling of old
3125         mangling schemes.
3126         * linespec.c (find_methods): Likewise.
3127         * stabsread.c (read_member_functions): Likewise.
3128         * valops.c (search_struct_method): Likewise.
3129         (value_struct_elt_for_reference): Likewise.
3130         * NEWS: Mention this change.
3131
3132 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3133
3134         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3135         print_source_lines.
3136         * source.c (print_source_lines_base): Update line number check.
3137         (print_source_lines): New function.
3138         (source_lines_range::source_lines_range): New function.
3139         * source.h (class source_lines_range): New class.
3140         (print_source_lines): New declaration.
3141
3142 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3143
3144         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3145
3146 2019-01-08  Tom Tromey  <tom@tromey.com>
3147             Simon Marchi  <simon.marchi@ericsson.com>
3148
3149         PR gdb/24060
3150         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3151         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3152         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3153         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3154         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3155         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3156
3157 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3158
3159         * source.c (select_source_symtab): Move header comment to
3160         declaration in source.h.
3161         (forget_cached_source_info_for_objfile): Likewise.
3162         (forget_cached_source_info): Likewise.
3163         (identify_source_line): Likewise.
3164         * source.h (identify_source_line): Move declaration from symtab.h
3165         and add comment from source.c
3166         (print_source_lines): Likewise.
3167         (forget_cached_source_info_for_objfile): Likewise.
3168         (forget_cached_source_info): Likewise.
3169         (select_source_symtab): Likewise.
3170         (enum print_source_lines_flag): Move definition from symtab.h.
3171         * symtab.h (identify_source_line): Move declaration to source.h.
3172         (print_source_lines): Likewise.
3173         (forget_cached_source_info_for_objfile): Likewise.
3174         (forget_cached_source_info): Likewise.
3175         (select_source_symtab): Likewise.
3176         (enum print_source_lines_flag): Move definition to source.h.
3177         * tui/tui-hooks.c: Add 'source.h' include.
3178
3179 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3180
3181         * source.c (print_source_lines_base): Handle requests to print
3182         reverse line number sequences, and guard against empty lines
3183         string.
3184
3185 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3186
3187         * source.c (print_source_lines_base): Fix skip of '\r' if next
3188         character is '\n'.
3189
3190 2019-01-06  Tom Tromey  <tom@tromey.com>
3191
3192         * c-exp.y (struct c_parse_state) <macro_original_text,
3193         expansion_obstack>: New member.
3194         (macro_original_text, expansion_obstack): Remove globals.
3195         (scan_macro_expansion, scanning_macro_expansion)
3196         (finished_macro_expansion): Update.
3197         (scan_macro_cleanup): Remove.
3198         (yylex, c_parse): Update.
3199
3200 2019-01-06  Tom Tromey  <tom@tromey.com>
3201
3202         * c-exp.y (struct c_parse_state) <strings>: New member.
3203         (operator_stoken): Update.
3204
3205 2019-01-06  Tom Tromey  <tom@tromey.com>
3206
3207         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3208         (union type_stack_elt) <typelist_val>: Now a pointer to
3209         std::vector.
3210         (type_stack_cleanup): Don't declare.
3211         (push_typelist): Update.
3212         * parse.c (pop_typelist): Return a std::vector.
3213         (push_typelist): Take a std::vector.
3214         (follow_types): Update.  Do not free args.
3215         (type_stack_cleanup): Remove.
3216         * c-exp.y (struct c_parse_state): New.
3217         (cpstate): New global.
3218         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3219         (nonempty_typelist): Update.
3220         (func_mod): Create a new vector.
3221         (c_parse): Create a c_parse_state.
3222         (check_parameter_typelist): Do not delete params.
3223         (function_method): Update.  Do not delete type_list.
3224
3225 2019-01-06  Tom Tromey  <tom@tromey.com>
3226
3227         PR gdb/28155:
3228         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3229         check_typedef.
3230         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3231         (print_return_value): Likewise.
3232
3233 2019-01-05  Tom Tromey  <tom@tromey.com>
3234
3235         * contrib/cleanup_check.py: Remove.
3236         * contrib/gcc-with-excheck: Remove.
3237         * contrib/exsummary.py: Remove.
3238         * contrib/excheck.py: Remove.
3239
3240 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3241
3242         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3243         NULL. Initialize tpprev to NULL instead of assigning it
3244         to NULL on the next statement.
3245         * windows-nat.c (windows_delete_thread): Remove check for
3246         main_thread_id before printing thread exit notifications.
3247         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3248         Remove thread ID check against main_thread_id.
3249         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3250         windows_delete_thread.
3251         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3252
3253 2019-01-04  Tom Tromey  <tom@tromey.com>
3254
3255         * compile/compile.c (_initialize_compile): Use upper case for
3256         metasyntactic variables.
3257         * symmisc.c (_initialize_symmisc): Use upper case for
3258         metasyntactic variables.
3259         * psymtab.c (_initialize_psymtab): Use upper case for
3260         metasyntactic variables.
3261         * demangle.c (demangle_command): Use upper case for metasyntactic
3262         variables.
3263         (_initialize_demangler): Likewise.
3264         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3265         variables.
3266
3267 2019-01-03  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3270
3271 2019-01-03  Tom Tromey  <tom@tromey.com>
3272
3273         * python/py-symtab.c (salpy_str): Update.
3274         (struct salpy_sal_object) <symtab>: Now a PyObject.
3275         (salpy_dealloc): Update.
3276         (del_objfile_sal): Use gdbpy_ref.
3277
3278 2019-01-03  Tom Tromey  <tom@tromey.com>
3279
3280         * python/py-type.c (convert_field): Use new_reference.  Return
3281         gdbpy_ref.
3282         (make_fielditem): Return gdbpy_ref.
3283         (typy_fields): Update.
3284         (typy_getitem): Update.
3285         (field_name): Return gdbpy_ref.  Use new_reference.
3286         (typy_iterator_iternext): Update.
3287
3288 2019-01-03  Tom Tromey  <tom@tromey.com>
3289
3290         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3291
3292 2019-01-03  Tom Tromey  <tom@tromey.com>
3293
3294         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3295         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3296         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3297         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3298         (pspy_set_type_printers): Likewise.
3299         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3300         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3301         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3302         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3303         (objfpy_set_type_printers): Likewise.
3304
3305 2019-01-03  Tom Tromey  <tom@tromey.com>
3306
3307         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3308         (gdbpy_print_stack): Use gdbpy_err_fetch.
3309         * python/python-internal.h (class gdbpy_err_fetch): New class.
3310         (class gdbpy_enter) <m_error_type, m_error_value,
3311         m_error_traceback>: Remove.
3312         <m_error>: New member.
3313         (gdbpy_exception_to_string): Don't declare.
3314         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3315         * python/py-value.c (convert_value_from_python): Use
3316         gdbpy_err_fetch.
3317         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3318         gdbpy_exception_to_string.
3319         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3320         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3321         gdbpy_err_fetch.
3322
3323 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * linux-nat.c (delete_lwp_cleanup): Delete.
3326         (struct lwp_deleter): New struct.
3327         (lwp_info_up): New typedef.
3328         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3329         lwp_info_up.
3330
3331 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3332
3333         * linux-fork.c (class scoped_switch_fork_info): New class.
3334         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3335
3336 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3337
3338         * valops.c (find_overload_match): Remove use of null_cleanup, and
3339         calls to do_cleanups.
3340
3341 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3342
3343         * compile/compile-cplus-types.c
3344         (compile_cplus_instance::decl_name): Handle changes to
3345         cp_func_name.
3346         * cp-support.c (cp_func_name): Update header comment, update
3347         return type.
3348         * cp-support.h (cp_func_name): Update return type in declaration.
3349         * valops.c (find_overload_match): Move temp_func local to top
3350         level of function and change its type.  Use temp_func to hold and
3351         delete temporary string obtained from cp_func_name.
3352
3353 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3356         gdb::char_vector, remove cleanup, and update uses of `msg`.
3357
3358 2019-01-03  Jim Wilson  <jimw@sifive.com>
3359
3360         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3361
3362 2019-01-02  Tom Tromey  <tom@tromey.com>
3363
3364         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3365         (tdesc_parse_xml): Remove cleanups.
3366         * target-descriptions.h (make_cleanup_free_target_description):
3367         Don't declare.
3368         (target_desc_deleter): New struct.
3369         (target_desc_up): New typedef.
3370         * target-descriptions.c (target_desc_deleter::operator()): Rename
3371         from free_target_description.
3372         (make_cleanup_free_target_description): Remove.
3373
3374 2019-01-02  Tom Tromey  <tom@tromey.com>
3375
3376         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3377         constructor, destructor.
3378         (linespec_parser): Remove typedef.
3379         (~linespec_parser): Rename from linespec_parser_delete.
3380         (linespec_lex_to_end, linespec_complete_label)
3381         (linespec_complete): Update.
3382         (decode_line_full): Remove cleanups.
3383         (decode_line_1): Update.
3384
3385 2019-01-02  Tom Tromey  <tom@tromey.com>
3386
3387         * python/python-internal.h (inferior_to_inferior_object): Change
3388         return type.
3389         * python/py-exitedevent.c (create_exited_event_object): Update.
3390         * python/py-inferior.c (inferior_to_inferior_object): Return
3391         gdbpy_ref.
3392         (python_new_inferior, python_inferior_deleted)
3393         (thread_to_thread_object, delete_thread_object)
3394         (build_inferior_list, gdbpy_selected_inferior): Update.
3395         * python/py-infthread.c (create_thread_object): Update.  Also fail
3396         if inferior_to_inferior_object fails.
3397
3398 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3399
3400         * inferior.h (class inferior) <displaced_step_state>: New field.
3401         * infrun.h (struct displaced_step_state): Move here from
3402         infrun.c.  Initialize fields, add constructor.
3403         <inf>: Remove field.
3404         <reset>: New method.
3405         * infrun.c (struct displaced_step_inferior_state): Move to
3406         infrun.h.
3407         (displaced_step_inferior_states): Remove.
3408         (get_displaced_stepping_state): Adust.
3409         (displaced_step_in_progress_any_inferior): Adjust.
3410         (displaced_step_in_progress_thread): Adjust.
3411         (displaced_step_in_progress): Adjust.
3412         (add_displaced_stepping_state): Remove.
3413         (get_displaced_step_closure_by_addr): Adjust.
3414         (remove_displaced_stepping_state): Remove.
3415         (infrun_inferior_exit): Call displaced_step_state.reset.
3416         (use_displaced_stepping): Don't check for NULL.
3417         (displaced_step_prepare_throw): Call
3418         get_displaced_stepping_state.
3419         (displaced_step_fixup): Don't check for NULL.
3420         (prepare_for_detach): Don't check for NULL.
3421
3422 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3423
3424         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3425          in case of call that did not complete.
3426
3427 2019-01-02  Andrey Utkin  <autkin@undo.io>
3428
3429         * symfile.c (find_separate_debug_file): Fix search of debug files for
3430         remote debuggee.
3431
3432 2019-01-02  Tom Tromey  <tom@tromey.com>
3433
3434         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3435         indentation.
3436         * python/py-frame.c (frapy_older): Remove cast.
3437         (frapy_newer): Likewise.
3438         * python/py-breakpoint.c (local_setattro): Remove cast.
3439         * python/py-arch.c (archpy_name): Remove local variable.
3440         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3441
3442 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3443
3444         * unittests/basic_string_view/element_access/char/empty.cc:
3445         Fix year range in copyright header.
3446
3447 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3448
3449         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3450         Delete.
3451         <operator==>: Update with for removed field.
3452         <hash>: Likewise.
3453         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3454         <isa_features>: ...this.
3455         <abi_features>: New field.
3456         (riscv_isa_flen): Update comment.
3457         (riscv_abi_xlen): New declaration.
3458         (riscv_abi_flen): New declaration.
3459         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3460         isa_features.
3461         (riscv_abi_xlen): New function.
3462         (riscv_isa_flen): Update to get answer from isa_features.
3463         (riscv_abi_flen): New function.
3464         (riscv_has_fp_abi): Update to get answer from abi_features.
3465         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3466         xlen and flen.
3467         (riscv_call_info) <xlen, flen>: Update comment.
3468         (riscv_call_arg_struct): Remove invalid assertions
3469         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3470         is removed.
3471         (riscv_gdbarch_init): Gather isa features and abi features
3472         separately, ensure both match on the gdbarch when reusing an old
3473         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3474         a target with 64-bit float hardware.
3475
3476 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3477
3478         * source.c (search_command_helper): Stop reverse search
3479         when line 1 has been searched.
3480
3481 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3482
3483         * record-full.c (record_full_base_target::close): Rewrite
3484         record_full_core_buf_list free logic.
3485
3486 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3487
3488         * break-catch-syscall.c (print_one_catch_syscall): xfree
3489         the last text.
3490
3491 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3492
3493         * top.c (print_gdb_version): Update Copyright year in version
3494         message.
3495
3496 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3497
3498         Update copyright year range in all GDB files.
3499
3500 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3501
3502         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3503
3504 For older changes see ChangeLog-2018.
3505 \f
3506 Local Variables:
3507 mode: change-log
3508 left-margin: 8
3509 fill-column: 74
3510 version-control: never
3511 coding: utf-8
3512 End:
3513