gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * thread.c (thread_apply_command): Adjust TID parsing.
   4         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
   5         detected before end of string.
   6         (tid_is_in_list): Error out if LIST is invalid.
   7
   8 2019-06-13  Pedro Alves  <palves@redhat.com>
   9
  10         * completer.c (complete_line_internal_1): Rewind completion word
  11         point.
  12         (completion_tracker::advance_custom_word_point_by): Change
  13         parameter type to int.
  14         * completer.h (completion_tracker::advance_custom_word_point_by):
  15         Likewise.
  16
  17 2019-06-13  Pedro Alves  <palves@redhat.com>
  18
  19         * completer.c (advance_to_completion_word): Handle delimiters.
  20
  21 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
  22
  23         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
  24
  25 2019-06-11  Tom Tromey  <tom@tromey.com>
  26
  27         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
  28         (xmalloc_failed): Move to alloc.c.
  29         * alloc.c: New file.
  30         * Makefile.in (COMMON_SFILES): Add alloc.c.
  31
  32 2019-06-11  Tom Tromey  <tom@tromey.com>
  33
  34         * nat/linux-waitpid.c: Don't include server.h.
  35         (linux_debug): Remove.
  36         (my_waitpid): Update.
  37
  38 2019-06-11  Tom Tromey  <tromey@adacore.com>
  39
  40         * infcall.c (_initialize_infcall): Remove trailing newline from
  41         help.
  42         * user-regs.c (_initialize_user_regs): Remove trailing newline
  43         from help.
  44         * typeprint.c (_initialize_typeprint): Remove trailing newline
  45         from help.
  46         * reverse.c (_initialize_reverse): Remove trailing newlines from
  47         help.
  48         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
  49         from help.
  50         * language.c (add_set_language_command): Remove trailing newline
  51         from help.
  52         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
  53         help.
  54         * disasm.c (_initialize_disasm): Remove trailing newline from
  55         help.
  56         * top.c (init_main): Remove trailing newline from help.
  57         * interps.c (_initialize_interpreter): Remove trailing newline
  58         from help.
  59         * btrace.c (_initialize_btrace): Remove trailing newlines from
  60         help.
  61         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
  62         from help.
  63         * python/python.c (_initialize_python): Remove trailing newline
  64         from help.
  65         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
  66         help.
  67         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
  68         from help.  Reformat some text.
  69         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
  70         from help.
  71         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
  72         newline from help.
  73
  74 2019-06-11  Tom Tromey  <tromey@adacore.com>
  75
  76         * darwin-nat.c (darwin_decode_exception_message)
  77         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
  78
  79 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  80
  81         * valops.c (value_slice): Check for not allocated or not
  82         associated values.
  83
  84 2019-06-10  Tom de Vries  <tdevries@suse.de>
  85
  86         PR gdb/24618
  87         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
  88         sure an empty slot (defined by a 32-bit zero pair) is recognized as
  89         invalid.
  90
  91 2019-06-10  Tom de Vries  <tdevries@suse.de>
  92
  93         PR gdb/24611
  94         * linespec.c (linespec_lexer_lex_string): Remove incorrect
  95         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
  96
  97 2019-06-10  Tom de Vries  <tdevries@suse.de>
  98
  99         PR symtab/24545
 100         * symtab.c (struct demangled_name_entry): Add language field.
 101         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 102         static minimal symbol".  Set and use language field.
 103
 104 2019-06-10  Tom Tromey  <tromey@adacore.com>
 105
 106         * ada-lang.c (_initialize_ada_language): Update help text.
 107
 108 2019-06-10  Tom Tromey  <tromey@adacore.com>
 109
 110         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 111         with a newline.
 112         * guile/guile.c (handle_boot_error): Don't end warning with a
 113         newline.
 114         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 115         warning with a newline.
 116         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 117         newline.
 118         (s12z_frame_cache): Likewise.
 119         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 120         a newline.
 121         * solib-svr4.c (disable_probes_interface): Don't end warning with
 122         a newline.
 123         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 124         newline.
 125         * python/python.c (do_finish_initialization): Don't end warning
 126         with a newline.
 127
 128 2019-06-10  Tom Tromey  <tom@tromey.com>
 129
 130         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 131         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 132         gdbpy_enter.
 133
 134 2019-06-10  Tom Tromey  <tromey@adacore.com>
 135
 136         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 137         data.
 138         (elf_new_init): Don't call stabsread_new_init.
 139         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 140         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 141         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 142
 143 2019-06-10  Tom de Vries  <tdevries@suse.de>
 144
 145         PR symtab/16264
 146         PR symtab/24517
 147         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 148
 149 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 150
 151         * source.c (find_and_open_source): Also rewrite relative file
 152         names.
 153
 154 2019-04-26  Amos Bird  <amosbird@gmail.com>
 155
 156         * annotate.c (annotate_thread_exited): Add "thread-exited"
 157         annotation.
 158
 159 2019-06-06  Tom Tromey  <tromey@adacore.com>
 160
 161         * maint.h (class scoped_command_stats): Use
 162         DISABLE_COPY_AND_ASSIGN.
 163         <print_time>: New method.
 164         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 165         print_time.
 166         (scoped_command_stats::print_time): New method.
 167
 168 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 169
 170         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 171         instructions of lengths 6 or 8 bytes.
 172
 173 2019-06-04  Pedro Alves  <palves@redhat.com>
 174
 175         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 176
 177         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 178         * breakpoint.c (condition_completer): Likewise.
 179         * cli/cli-dump.c (scan_expression): Likewise.
 180         * common/filestuff.c (mkdir_recursive): Likewise.
 181         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 182         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 183         (gdb_abspath): Likewise.
 184         * compile/compile-cplus-types.c
 185         (compile_cplus_instance::decl_name): Likewise.
 186         * completer.c (complete_explicit_location):
 187         (signal_completer, reg_or_group_completer_1): Likewise.
 188         * cp-support.c (cp_remove_params_if_any): Likewise.
 189         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 190         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 191         * infcmd.c (strip_bg_char): Likewise.
 192         * linespec.c (copy_token_string): Likewise.
 193         * mi/mi-main.c (output_cores): Likewise.
 194         * psymtab.c (psymtab_search_name):
 195         * symfile.c (test_set_ext_lang_command): Likewise.
 196         * target.c (target_fileio_read_stralloc): Likewise.
 197         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 198         * value.c (complete_internalvar): Likewise.
 199
 200 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 201
 202         Add objfile property to gdb.Type.
 203         * NEWS: Mention Python API addition.
 204         * python/py-type.c (typy_get_objfile): New method.
 205
 206 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 207
 208         * NEWS: Mention the new set|show style [title|highlight].
 209         Mention changes to "show style", "help" and "apropos".
 210
 211 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 212
 213         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 214         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 215         instead of print_help_for_command.
 216         (print_doc_of_command): New function.
 217         (help_list): Add 'apropos -v word' suggestion.
 218         (print_help_for_command): Style the command name using title style.
 219         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 220         (_initialize_cli_cmds): Describe -v in apropos_command help.
 221
 222 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 223
 224         * cli/cli-style.h (cli_style_option): Add name in constructor,
 225         add m_name class member, add constructor with intensity,
 226         add name class function.
 227         (cli_style_option::add_setshow_commands): Remove name argument.
 228         (highlight_style, title_style): New styles.
 229         * cli/cli-style.c (do_show): New function that shows a style
 230         characteristic styling the style name with itself.
 231         (set_style_name): New function.
 232         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 233         Update all callers according to the changes in cli/cli-style.h.
 234         * utils.h (fputs_highlighted): New function.
 235         * utils.c (fputs_highlighted): Likewise.
 236
 237 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 238
 239         * NEWS: Mention new pipe command and new convenience variables.
 240
 241 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 242
 243         * cli/cli-cmds.c (pipe_command): New function.
 244         (_initialize_cli_cmds): Call add_com for pipe_command.
 245         Define | as an alias for pipe.
 246         (exit_status_set_internal_vars): New function.
 247         (shell_escape): Call exit_status_set_internal_vars.
 248         cli/cli-decode.c (find_command_name_length): Recognize | as
 249         a single character command.
 250
 251 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 252
 253         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 254         top.c (execute_command_to_ui_file): New function, mostly a copy
 255         of execute_command_to_string.
 256         (execute_command_to_string): Implement by calling
 257         execute_command_to_ui_file.
 258
 259 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 260
 261         * top.h (saved_command_line): Remove declaration.
 262         * top.c (previous_saved_command_line, previous_repeat_arguments):
 263         New variables.
 264         (saved_command_line): Make static, define together with other
 265         'repeat variables'.
 266         (dont_repeat): Clear repeat_arguments.
 267         (repeat_previous, get_saved_command_line, save_command_line):
 268         New functions.
 269         (gdb_init): Initialize saved_command_line
 270         and previous_saved_command_line.
 271         * main.c (captured_main_1): Remove saved_command_line initialization.
 272         * event-top.c (handle_line_of_input): Update to use
 273         the new 'repeat' related functions instead of direct access to
 274         saved_command_line.
 275         * command.h (repeat_previous, get_saved_command_line,
 276         save_command_line): New declarations.
 277         (dont_repeat): Add comment.
 278
 279 2019-05-30  Tom Tromey  <tromey@adacore.com>
 280
 281         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 282         Fix comment.
 283         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 284
 285 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 286
 287         PR cli/24587
 288         * completer.c (complete): Initialize variable word.
 289
 290 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 291
 292         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 293         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 294         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 295         'body' is NULL to the outter 'if', protecting the '!is_define'
 296         situation as well.
 297
 298 2019-05-29  Tom Tromey  <tromey@adacore.com>
 299
 300         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 301         (dwarf_unknown): New function.
 302         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 303         (dwarf_type_encoding_name): Use dwarf_unknown.
 304
 305 2019-05-29  Tom Tromey  <tromey@adacore.com>
 306
 307         PR c++/20020:
 308         * cp-valprint.c (cp_print_value_fields): Call
 309         cp_print_static_field inside "try".
 310
 311 2019-05-29  Tom Tromey  <tromey@adacore.com>
 312
 313         * inflow.c (struct terminal_info): Add default operator=.
 314         * configure: Rebuild.
 315         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 316         -Wdeprecated-copy-dtor, -Wredundant-move.
 317
 318 2019-05-29  Tom Tromey  <tromey@adacore.com>
 319
 320         * NEWS: Add entry.
 321         * infcmd.c (print_return_value_1): Handle finish_print
 322         option.
 323         (show_print_finish): New function.
 324         (_initialize_infcmd): Add "set/show print finish" commands.
 325         * valprint.c (user_print_options): Initialize new member.
 326         * valprint.h (struct value_print_options) <finish_print>: New
 327         member.
 328
 329 2019-05-28  Tom Tromey  <tromey@adacore.com>
 330
 331         * ada-lang.c (ada_remove_Xbn_suffix)
 332         (find_old_style_renaming_symbol)
 333         (parse_old_style_renaming): Remove.
 334         (ada_find_renaming_symbol): Don't call
 335         find_old_style_renaming_symbol.
 336         (ada_is_renaming_symbol): Rename from
 337         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 338         bool.  Now static.
 339         (ada_read_var_value): Update and simplify.
 340         * ada-exp.y (write_var_or_type): Remove old code.
 341
 342 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 343
 344         * event-top.c: Remove include comment.
 345         * inflow.c (class scoped_ignore_sigttou): Move from here...
 346         * inflow.h (class scoped_ignore_sigttou): ...to here.
 347         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 348         * top.c:  Remove include comment.
 349
 350 2019-05-27  Tom Tromey  <tom@tromey.com>
 351
 352         * NEWS: Fix typo.
 353
 354 2019-05-22  Tom Tromey  <tromey@adacore.com>
 355
 356         * target.c (target_follow_exec): Constify parameter.
 357         * target-delegates.c: Rebuild.
 358         * remote.c (remote_target::follow_exec): Constify parameter.
 359         * infrun.c (follow_exec): Constify parameter.
 360         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 361         (target_follow_exec): Likewise.
 362
 363 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 364
 365         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 366         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 367
 368 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 369
 370         * NEWS: Add debugredirect and testsuite sections.
 371
 372 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 373
 374         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 375         target descriptions using exclusively floating point register name
 376         aliases.
 377
 378 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 379
 380         PR gdb/18644:
 381         * f-lang.c (build_fortran_types): Handle the case where
 382         gdbarch_floatformat_for_type returns a nullptr.
 383
 384 2019-05-21  Tom de Vries  <tdevries@suse.de>
 385
 386         PR cli/24587
 387         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 388
 389 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 390
 391         PR gdb/18644:
 392         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 393         16-byte floats.
 394         * i386-tdep.c (i386_floatformat_for_type): Use
 395         floatformats_ia64_quad for the 16-byte floating point component
 396         within a fortran 32-byte complex number.
 397
 398 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 401         delete default constructor.
 402         (find_partial_die): Update to return const struct.
 403         (partial_die_parent_scope): Move variable declaration into scope
 404         of its use and change its type to auto.
 405         (guess_partial_die_structure_name): Likewise.
 406         (partial_die_info::fixup): Likewise.
 407
 408 2019-05-17  Tom Tromey  <tromey@adacore.com>
 409
 410         * source.c (find_and_open_source): Remove cast.
 411
 412 2019-05-17  Tom Tromey  <tromey@adacore.com>
 413
 414         * annotate.c (annotate_source): Make "filename" const.
 415         * annotate.h (annotate_source): Use const.
 416
 417 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 418
 419         * disasm.c (set_disassembler_options): Send errors to stderr.
 420
 421 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 422
 423         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 424         (cli_interp_base::set_logging): Check debug_redirect.
 425         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 426         * cli/cli-logging.c (debug_redirect): Add static variable.
 427         (pop_output_files): Add default param.
 428         (handle_redirections): Print debug setting.
 429         (show_logging_command): Likewise.
 430         (_initialize_cli_logging): Add debugredirect command.
 431         * interps.c (current_interp_set_logging): Add debug_redirect
 432         parameter.
 433         * interps.h (set_logging): Add debug_redirect parameter.
 434         (current_interp_set_logging): Likewise.
 435         * mi/mi-common.h: Likewise.
 436         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 437
 438 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 439             Tom Tromey  <tromey@adacore.com>
 440
 441         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 442         directly.
 443         * cli/cli-interp.h (make_logging_output): Remove declaration.
 444         * cli/cli-logging.c (make_logging_output): Remove function.
 445         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 446         directly.
 447         * ui-file.c (tee_file::tee_file): Remove bools.
 448         (tee_file::~tee_file): Remove deletes.
 449         * ui-file.h (tee_file): Remove bools.
 450
 451 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 452
 453         * mi/mi-cmds.h (mi_cmd_complete): New function.
 454         * mi/mi-main.c (mi_cmd_complete): Likewise.
 455         * mi/mi-cmds.c: Define new MI command -complete.
 456         * NEWS: Mention new -complete command.
 457
 458 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 459
 460         * completer.h (complete): New function.
 461         * completer.c (complete): Likewise.
 462         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 463         function defined in completer.h.
 464
 465 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 466
 467        * MAINTAINERS (Write After Approval): Add myself.
 468
 469 2019-05-17  Tom de Vries  <tdevries@suse.de>
 470
 471         PR gdb/24094
 472         * dwarf2read.c (struct cu_partial_die_info): New struct.
 473         (find_partial_die): Return cu_partial_die_info.
 474         (partial_die_parent_scope, guess_partial_die_structure_name)
 475         (partial_die_info::fixup): Handle new return type of find_partial_die.
 476
 477 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 478
 479         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 480         "std::string", simplifying the algorithm.
 481
 482 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 483
 484         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 485         (stap_static_probe_ops::get_probes): Likewise.
 486
 487 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 488
 489         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 490         '-')" and "else if".
 491         (stap_parse_single_operand): Join checks for
 492         "gdbarch_stap_parse_special_token_p" and
 493         "gdbarch_stap_parse_special_token" in the same "if" statement.
 494         Invert check when verifying for operation on register
 495         displacement.
 496
 497 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 498
 499         * stap-probe.c (stap_get_opcode): Update comment.
 500         (stap_get_expected_argument_type): Likewise.
 501         (handle_stap_probe): Likewise.
 502
 503 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 504
 505         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 506         return type to 'bool'.  Adjust comment.  Use 'bool' when
 507         appropriate.
 508         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 509         * stap-probe.c (stap_parse_argument_1): Likewise.
 510         (stap_is_operator): Likewise.
 511         (stap_is_generic_prefix): Likewise.
 512         (stap_is_register_prefix): Likewise.
 513         (stap_is_register_indirection_prefix): Likewise.
 514         (stap_is_integer_prefix): Likewise.
 515         (stap_generic_check_suffix): Likewise.
 516         (stap_check_integer_suffix): Likewise.
 517         (stap_check_register_suffix): Likewise.
 518         (stap_check_register_indirection_suffix): Likewise.
 519         (stap_parse_register_operand): Likewise.
 520         (stap_parse_single_operand): Likewise.
 521         (stap_parse_argument_1): Likewise.
 522         (stap_probe::get_argument_count): Likewise.
 523         (stap_is_operator): Likewise.
 524
 525 2019-05-16  Tom Tromey  <tromey@adacore.com>
 526
 527         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 528         keyword to foreach.
 529
 530 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 531
 532         * linux-thread-db.c (try_thread_db_load_1): Change return type
 533         to bool.
 534         (try_thread_db_load): Likewise.
 535         (try_thread_db_load_from_pdir_1): Likewise.
 536         (try_thread_db_load_from_pdir): Likewise.
 537         (try_thread_db_load_from_sdir): Likewise.
 538         (try_thread_db_load_from_dir): Likewise.
 539         (thread_db_load_search): Likewise.
 540         (has_libpthread): Likewise.
 541         (thread_db_load): Likewise.
 542
 543 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 544
 545         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 546         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 547         NULL, and complain/return if that's the case.
 548
 549 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 550
 551         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 552         (advance, posn, abstract_read_memory): New functions.
 553         [struct mem_read_abstraction]: New struct.
 554         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 555
 556 2019-05-14  Tom Tromey  <tromey@adacore.com>
 557
 558         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 559         value is not lval_memory.
 560
 561 2019-05-14  Tom Tromey  <tromey@adacore.com>
 562
 563         * solib.c (info_sharedlibrary_command): Style the file name.
 564
 565 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 566
 567         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 568         (aarch64_vnv_type): Likewise.
 569         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 570         * common/tdesc.c: Likewise.
 571         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 572         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 573         * features/aarch64-fpu.xml: Add ieee half view.
 574         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 575         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 576         * gdbtypes.h (struct builtin_type): Likewise.
 577         (struct objfile_type): Likewise.
 578
 579 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 580
 581         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 582         typo.
 583         * location.h (string_to_event_location): Likewise.
 584
 585 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 586
 587         GDB 8.3 released.
 588
 589 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 590
 591         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 592         New variable declaration.
 593         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 594         New variable.
 595         (print_one_breakpoint): Use ui_out::test_flags and new global
 596         variable to compute use_fixed_output.
 597         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 598         Remove.
 599         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 600         (mi_multi_location_breakpoint_output_fixed): Remove.
 601         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 602         new variable.
 603         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 604         fix_multi_location_breakpoint_output flag if version >= 3.
 605         * ui-out.h (enum ui_out_flag)
 606         <fix_multi_location_breakpoint_output>: New enumerator.
 607
 608 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 609
 610         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 611
 612 2019-05-10  Tom Tromey  <tromey@adacore.com>
 613
 614         * ada-lang.c (catch_ada_completer): New function.
 615         (_initialize_ada_language): Use it.
 616
 617 2019-05-10  Tom Tromey  <tromey@adacore.com>
 618
 619         * thread.c (print_thread_info): Make "requested_threads" const.
 620         * gdbthread.h (print_thread_info): Make "requested_threads"
 621         const.
 622         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 623         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 624
 625 2019-05-08  Tom Tromey  <tom@tromey.com>
 626
 627         * gdbtypes.c (objfile_type_data): Change type.
 628         (objfile_type, _initialize_gdbtypes): Update.
 629
 630 2019-05-08  Tom Tromey  <tom@tromey.com>
 631
 632         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 633         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 634         (_initialize_dwarf2_frame): Update.
 635
 636 2019-05-08  Tom Tromey  <tom@tromey.com>
 637
 638         * objc-lang.c (objc_objfile_data): Change type.
 639         (find_methods): Update.
 640         (_initialize_objc_lang): Remove.
 641
 642 2019-05-08  Tom Tromey  <tom@tromey.com>
 643
 644         * stabsread.c (rs6000_builtin_type_data): Change type.
 645         (rs6000_builtin_type, _initialize_stabsread): Update.
 646
 647 2019-05-08  Tom Tromey  <tom@tromey.com>
 648
 649         * mips-tdep.c (mips_pdr_data): Remove.
 650         (_initialize_mips_tdep): Update.
 651
 652 2019-05-08  Tom Tromey  <tom@tromey.com>
 653
 654         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 655         (hppa_init_objfile_priv_data, read_unwind_info)
 656         (find_unwind_entry, _initialize_hppa_tdep): Update.
 657
 658 2019-05-08  Tom Tromey  <tom@tromey.com>
 659
 660         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 661         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 662         on obstack.
 663         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 664
 665 2019-05-08  Tom Tromey  <tom@tromey.com>
 666
 667         * mdebugread.c (basic_type_data): Change type.
 668         (basic_type, _initialize_mdebugread): Update.
 669
 670 2019-05-08  Tom Tromey  <tom@tromey.com>
 671
 672         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 673
 674 2019-05-08  Tom Tromey  <tom@tromey.com>
 675
 676         * nto-tdep.c (nto_inferior_data_reg): Change type.
 677         (nto_inferior_data): Update.
 678         (nto_inferior_data_cleanup, nto_new_inferior_data)
 679         (_initialize_nto_tdep): Remove.
 680         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 681
 682 2019-05-08  Tom Tromey  <tom@tromey.com>
 683
 684         * ada-lang.c (struct ada_inferior_data): Add initializers.
 685         (ada_inferior_data): Change type.
 686         (ada_inferior_data_cleanup): Remove.
 687         (get_ada_inferior_data, ada_inferior_exit)
 688         (struct ada_pspace_data): Add initializers, destructor.
 689         (ada_pspace_data_handle): Change type.
 690         (get_ada_pspace_data): Update.
 691         (ada_pspace_data_cleanup): Remove.
 692
 693 2019-05-08  Tom Tromey  <tom@tromey.com>
 694
 695         * coffread.c (struct coff_symfile_info): Add initializers.
 696         (coff_objfile_data_key): Move lower.  Change type.
 697         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 698         Update.
 699         (coff_free_info): Remove.
 700
 701 2019-05-08  Tom Tromey  <tom@tromey.com>
 702
 703         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 704         (fbsd_pspace_data_handle): Move lower.  Change type.
 705         (get_fbsd_pspace_data): Update.
 706         (fbsd_pspace_data_cleanup): Remove.
 707         (_initialize_fbsd_tdep): Update.
 708
 709 2019-05-08  Tom Tromey  <tom@tromey.com>
 710
 711         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 712         (get_ada_tasks_pspace_data): Update.
 713         (ada_tasks_pspace_data_cleanup): Remove.
 714         (_initialize_tasks): Update.
 715         (ada_tasks_inferior_data_handle): Change type.
 716         (get_ada_tasks_inferior_data): Update.
 717         (ada_tasks_inferior_data_cleanup): Remove.
 718         (struct ada_tasks_pspace_data): Add initializers.
 719
 720 2019-05-08  Tom Tromey  <tom@tromey.com>
 721
 722         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 723         * symfile-debug.c (debug_sym_get_probes): Change type.
 724         * stap-probe.c (handle_stap_probe):
 725         (stap_static_probe_ops::get_probes): Change type.
 726         * probe.h (class static_probe_ops) <get_probes>: Change type.
 727         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 728         (parse_probes_in_pspace): Update.
 729         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 730         Update.
 731         (any_static_probe_ops::get_probes): Change type.
 732         * elfread.c (elfread_data): New typedef.
 733         (probe_key): Change type.
 734         (elf_get_probes): Likewise.  Update.
 735         (probe_key_free): Remove.
 736         (_initialize_elfread): Update.
 737         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 738         Change type.
 739         (dtrace_process_dof_probe, dtrace_process_dof)
 740         (dtrace_static_probe_ops::get_probe): Change type.
 741
 742 2019-05-08  Tom Tromey  <tom@tromey.com>
 743
 744         * xcoffread.c (struct xcoff_symfile_info): Rename from
 745         coff_symfile_info.  Add initializers.
 746         (xcoff_objfile_data_key): Move lower.  Change type.
 747         (XCOFF_DATA): Rewrite.
 748         (xcoff_free_info): Remove.
 749         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 750         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 751         (xcoff_initial_scan): Update.
 752
 753 2019-05-08  Tom Tromey  <tom@tromey.com>
 754
 755         * solib-svr4.c (struct svr4_info): Add initializers and
 756         destructor.
 757         <probes_table>: Now an htab_up.
 758         (solib_svr4_pspace_data): Change type.
 759         (free_probes_table): Simplify.
 760         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 761         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 762         (probes_table_remove_objfile_probes, register_solib_event_probe)
 763         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 764         (_initialize_svr4_solib): Update.
 765
 766 2019-05-08  Tom Tromey  <tom@tromey.com>
 767
 768         * remote.c (remote_pspace_data): Change type.
 769         (remote_pspace_data_cleanup): Remove.
 770         (get_remote_exec_file, set_pspace_remote_exec_file)
 771         (_initialize_remote): Update.
 772
 773 2019-05-08  Tom Tromey  <tom@tromey.com>
 774
 775         * breakpoint.c (breakpoint_objfile_key): Change type.
 776         (get_breakpoint_objfile_data): Update.
 777         (free_breakpoint_objfile_data): Remove.
 778         (_initialize_breakpoint): Update.
 779
 780 2019-05-08  Tom Tromey  <tom@tromey.com>
 781
 782         * linux-tdep.c (struct linux_info): Add initializers.
 783         (linux_inferior_data): Move.  Change type.
 784         (invalidate_linux_cache_inf): Update.
 785         (linux_inferior_data_cleanup): Remove.
 786         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 787
 788 2019-05-08  Tom Tromey  <tom@tromey.com>
 789
 790         * auxv.c (auxv_inferior_data): Move.  Change type.
 791         (auxv_inferior_data_cleanup): Remove.
 792         (invalidate_auxv_cache_inf): Rewrite.
 793         (get_auxv_inferior_data, _initialize_auxv): Update.
 794
 795 2019-05-08  Tom Tromey  <tom@tromey.com>
 796
 797         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 798         (symfile_debug_objfile_data_key): Change type.
 799         (symfile_debug_installed, debug_qf_has_symbols)
 800         (debug_qf_find_last_source_symtab)
 801         (debug_qf_forget_cached_source_info)
 802         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 803         (debug_qf_print_stats, debug_qf_dump)
 804         (debug_qf_expand_symtabs_for_function)
 805         (debug_qf_expand_all_symtabs)
 806         (debug_qf_expand_symtabs_with_fullname)
 807         (debug_qf_map_matching_symbols)
 808         (debug_qf_expand_symtabs_matching)
 809         (debug_qf_find_pc_sect_compunit_symtab)
 810         (debug_qf_map_symbol_filenames)
 811         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 812         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 813         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 814         (debug_sym_read_linetable, debug_sym_relocate): Update.
 815         (symfile_debug_free_objfile): Remove.
 816         (install_symfile_debug_logging, _initialize_symfile_debug):
 817         Update.
 818
 819 2019-05-08  Tom Tromey  <tom@tromey.com>
 820
 821         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 822         allocate_on_obstack.
 823         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 824         (get_dwarf2_per_objfile): Update.
 825         (set_dwarf2_per_objfile): Remove.
 826         (dwarf2_has_info, dwarf2_get_section_info): Update.
 827         (dwarf2_free_objfile): Remove.
 828         (_initialize_dwarf2_read): Update.
 829
 830 2019-05-08  Tom Tromey  <tom@tromey.com>
 831
 832         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 833         initializers.
 834         <unsupported_script_warning_printed,
 835         script_not_found_warning_printed>: Now bool.
 836         (auto_load_pspace_data): Change type.
 837         (~auto_load_pspace_info): Rename from
 838         auto_load_pspace_data_cleanup.
 839         (get_auto_load_pspace_data, init_loaded_scripts_info)
 840         (clear_section_scripts, maybe_print_unsupported_script_warning)
 841         (maybe_print_script_not_found_warning, _initialize_auto_load):
 842         Update.
 843
 844 2019-05-08  Tom Tromey  <tom@tromey.com>
 845
 846         * objfiles.c (objfile_pspace_info): Add destructor and
 847         initializers.
 848         (objfiles_pspace_data): Change type.
 849         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 850         (get_objfile_pspace_data): Update.
 851         (objfiles_bfd_data): Change type.
 852         (get_objfile_bfd_data): Update.
 853         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 854
 855 2019-05-08  Tom Tromey  <tom@tromey.com>
 856
 857         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 858         Change type.
 859         (get_catch_syscall_inferior_data): Update.
 860         (catch_syscall_inferior_data_cleanup): Remove.
 861         (_initialize_break_catch_syscall): Update.
 862
 863 2019-05-08  Tom Tromey  <tom@tromey.com>
 864
 865         * inflow.c (struct terminal_info): Add destructor and
 866         initializers.
 867         (inflow_inferior_data): Change type.
 868         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 869         (get_inflow_inferior_data, inflow_inferior_exit)
 870         (swap_terminal_info, _initialize_inflow): Update.
 871
 872 2019-05-08  Tom Tromey  <tom@tromey.com>
 873
 874         * target-dcache.c (target_dcache_cleanup): Remove.
 875         (target_dcache_aspace_key): Change type.
 876         (target_dcache_init_p, target_dcache_invalidate)
 877         (target_dcache_get, target_dcache_get_or_init)
 878         (_initialize_target_dcache): Update.
 879         * dcache.h (struct dcache_deleter): New.
 880
 881 2019-05-08  Tom Tromey  <tom@tromey.com>
 882
 883         * symtab.c (struct symbol_cache): Add destructor and
 884         initializers.
 885         (symbol_cache_key): Move.  Change type.
 886         (make_symbol_cache, free_symbol_cache): Remove.
 887         (get_symbol_cache): Update.
 888         (symbol_cache_cleanup): Remove.
 889         (ALL_PSPACES, symbol_cache_flush)
 890         (maintenance_print_symbol_cache)
 891         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 892         Update.
 893
 894 2019-05-08  Tom Tromey  <tom@tromey.com>
 895
 896         * symtab.c (struct main_info): Add destructor and initializers.
 897         (main_progspace_key): Move.  Change type.
 898         (get_main_info): Update.
 899         (main_info_cleanup): Remove.
 900         (_initialize_symtab): Update.
 901
 902 2019-05-08  Tom Tromey  <tom@tromey.com>
 903
 904         * registry.h (DECLARE_REGISTRY): Define the _key class.
 905
 906 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 907
 908         * NEWS: Merge two 'New commands' sections.
 909
 910 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 911
 912         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 913         parameter and use Ada language definition instead.
 914         (ada_val_print_ptr): Remove unused language parameter.
 915         (ada_val_print_num): Remove language parameter and use Ada language
 916         definition instead.
 917         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 918         parameter.
 919         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 920         parameter and use Ada language definition instead.
 921         (ada_val_print_1): Update all ada_val_print_xxx calls.
 922         Remove language parameter.
 923         (ada_val_print): Update ada_val_print_1 call.
 924
 925 2019-05-08  Tom Tromey  <tromey@adacore.com>
 926
 927         * remote.c (remote_hw_watchpoint_limit)
 928         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 929         Now static.
 930
 931 2019-05-08  Tom Tromey  <tromey@adacore.com>
 932
 933         * maint.c (_initialize_maint_cmds): Move initialization code to
 934         remote.c.
 935         (watchdog, show_watchdog): Move to remote.c.
 936         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 937         "watchdog" static.
 938         (_initialize_remote): Move initialization code from maint.c.
 939         * defs.h (watchdog): Don't declare.
 940
 941 2019-05-08  Tom Tromey  <tromey@adacore.com>
 942
 943         * tui/tui-interp.c: Include main.h.
 944         * interps.c: Include main.h.
 945         * main.h (interpreter_p): Declare.
 946         * defs.h (interpreter_p): Don't declare.
 947
 948 2019-05-08  Tom Tromey  <tromey@adacore.com>
 949
 950         * dwarf2loc.c: Include dwarf2read.h.
 951         * defs.h (read_unsigned_leb128): Don't declare.
 952         * dwarf2read.h (read_unsigned_leb128): Declare.
 953
 954 2019-05-08  Tom Tromey  <tromey@adacore.com>
 955
 956         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 957         method.
 958
 959 2019-05-08  Tom Tromey  <tromey@adacore.com>
 960
 961         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 962         when no wrap column is set.
 963
 964 2019-05-08  Tom Tromey  <tromey@adacore.com>
 965
 966         * c-lang.c (c_get_string): Handle non-C-style arrays.
 967
 968 2019-05-08  Tom Tromey  <tromey@adacore.com>
 969
 970         * typeprint.c (print_offset_data::update): Print the bit offset,
 971         not the number of bits remaining.
 972
 973 2019-05-08  Tom Tromey  <tromey@adacore.com>
 974
 975         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 976         padding at end of comment.
 977
 978 2019-05-08  Tom Tromey  <tromey@adacore.com>
 979
 980         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 981         Compare main types.
 982
 983 2019-05-06  Tom Tromey  <tom@tromey.com>
 984
 985         * common/scoped_mmap.c: Include common-defs.h.
 986         * common/scoped_mmap.h: Don't include config.h.
 987
 988 2019-05-04  Tom Tromey  <tom@tromey.com>
 989
 990         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 991         (struct aarch64_call_info): Add initializers.
 992         <si>: Now a std::vector.
 993         (pass_on_stack, aarch64_push_dummy_call): Update.
 994
 995 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 996             Tom Tromey  <tom@tromey.com>
 997
 998         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 999         (ppc_threads): Now a std::vector.  Now static.
1000         (hwdebug_find_thread_points_by_tid)
1001         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1002         Update.
1003
1004 2019-05-04  Tom Tromey  <tom@tromey.com>
1005
1006         * arc-tdep.c (arc_tdesc_init): Return bool.
1007
1008 2019-05-04  Tom Tromey  <tom@tromey.com>
1009
1010         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1011         Use gdb_assert_not_reached.
1012
1013 2019-05-04  Tom Tromey  <tom@tromey.com>
1014
1015         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1016         "false".
1017
1018 2019-05-04  Tom Tromey  <tom@tromey.com>
1019
1020         * arc-tdep.c (arc_tdesc_init): Use bool.
1021
1022 2019-05-04  Tom Tromey  <tom@tromey.com>
1023
1024         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1025
1026 2019-05-04  Tom Tromey  <tom@tromey.com>
1027
1028         * cli/cli-cmds.c (valid_command_p): Return bool.
1029
1030 2019-05-04  Tom Tromey  <tom@tromey.com>
1031
1032         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1033         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1034
1035 2019-05-04  Raul Tambre  <raul@tambre.ee>
1036
1037         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1038         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1039         operator for comparison.
1040
1041 2019-05-04  Tom Tromey  <tom@tromey.com>
1042
1043         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1044         (lookup_partial_symbol, print_partial_symbols)
1045         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1046         (psymbol_compare): Update.
1047         (add_psymbol_to_bcache): Clear the entire psymbol.
1048         (maintenance_check_psymtabs): Update.
1049         * psympriv.h (struct partial_symbol): Don't derive from
1050         general_symbol_info.
1051         <obj_section, unrelocated_address, address,
1052         set_unrelocated_address>: Update.
1053         <ginfo>: New member.
1054         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1055         (debug_names::write_psymbols): Update.
1056
1057 2019-05-04  Tom de Vries  <tdevries@suse.de>
1058
1059         * contrib/cc-with-tweaks.sh: Support -n arg.
1060
1061 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1062
1063         * corelow.c (core_target::detach): Ensure frame cache and
1064         register caches are cleared.
1065         inferior.c (exit_inferior_1): Likewise.
1066
1067 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1068             Tom Tromey  <tom@tromey.com>
1069
1070         * dictionary.c (collate_pending_symbols_by_language): Remove
1071         "struct" from foreach.
1072         * symtab.c (lookup_global_symbol_from_objfile)
1073         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1074         foreach.
1075         * ser-tcp.c (net_open): Remove "struct" from foreach.
1076         * objfiles.c (objfile_relocate, objfile_rebase)
1077         (objfile_has_symbols): Remove "struct" from foreach.
1078         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1079         from foreach.
1080         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1081         foreach.
1082         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1083         "struct" from foreach.
1084         * ada-lang.c (create_excep_cond_exprs)
1085         (ada_exception_catchpoint_cond_string): Remove "struct" from
1086         foreach.
1087
1088 2019-05-03  Tom Tromey  <tromey@adacore.com>
1089
1090         * ada-exp.y (convert_char_literal): Check suffix of each
1091         enumerator.
1092
1093 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1094
1095         PR ada/21406:
1096         * ada-exp.y (yywrap): Don't define.
1097         * ada-lex.l (%option): Add noyywrap
1098         (yywrap): Remove.
1099
1100 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1101
1102         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1103         _WIN32_WINNT to the XP level, unless already defined to a higher
1104         level.
1105
1106         * unittests/parse-connection-spec-selftests.c:
1107         * ser-tcp.c:
1108         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1109         override.
1110
1111         * symfile.c (find_separate_debug_file): Remove colon from the
1112         drive spec of DOS/Windows file names of the target, so that the
1113         file name produced from DEBUGDIR and the target's directory will
1114         be valid on DOS/Windows systems.
1115
1116 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * rust-lang.c (val_print_struct): Handle printing structures
1119         containing strings.
1120
1121 2019-05-02  Tom Tromey  <tromey@adacore.com>
1122
1123         * valarith.c (_initialize_valarith): Remove.
1124
1125 2019-05-01  Tom Tromey  <tromey@adacore.com>
1126
1127         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1128         bitfields.
1129
1130 2019-05-01  Tom Tromey  <tromey@adacore.com>
1131
1132         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1133         for big-endian copies.
1134
1135 2019-04-30  Ali Tamur  <tamur@google.com>
1136         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1137         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1138         (read_3_bytes): New function.
1139
1140 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1141
1142         * windows-nat.c (main_thread_id): Delete.
1143         (handle_output_debug_string): Replace main_thread_id by
1144         current_event.dwThreadId.
1145         (fake_create_process): Likewise.
1146         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1147         Do not set main_thread_id.
1148         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1149         current_event.dwThreadId.
1150         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1151
1152 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1153
1154         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1155         Use current_event.dwThreadId instead of main_thread_id.
1156
1157 2019-04-30  Tom Tromey  <tromey@adacore.com>
1158
1159         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1160         (create_excep_cond_exprs): Iterate over program spaces.
1161         (ada_exception_catchpoint_cond_string): Examine all minimal
1162         symbols for exception types.
1163
1164 2019-04-30  Tom Tromey  <tromey@adacore.com>
1165
1166         PR c++/24470:
1167         * dwarf2read.c (process_structure_scope): Handle case where type
1168         has template parameters but no symbol was created.
1169
1170 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1171             Chris January  <chris.january@arm.com>
1172
1173         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1174         qualifier.
1175         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1176
1177 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1178
1179         * f-typeprint.c (f_print_type): Update rules for printing
1180         whitespace.
1181         (f_type_print_varspec_suffix): Likewise.
1182
1183 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1184             Chris January  <chris.january@arm.com>
1185
1186         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1187         function arguments.
1188
1189 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * f-lang.c (build_fortran_types): Change name of void type to
1192         lower case.
1193         * f-typeprint.c (f_type_print_base): Print the name of the void
1194         type, rather than a fixed string.
1195         * f-valprint.c (f_decorations): Use lower case void string.
1196
1197 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1198             Chris January  <chris.january@arm.com>
1199
1200         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1201         types for Fortran.
1202
1203 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1204             Chris January  <chris.january@arm.com>
1205             David Lecomber  <david.lecomber@arm.com>
1206
1207         * f-exp.y (BINOP_INTRINSIC): New token.
1208         (exp): New parser rule handling BINOP_INTRINSIC.
1209         (f77_keywords): Add new builtin procedures.
1210         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1211         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1212         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1213         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1214         (print_unop_subexp_f): New function.
1215         (print_binop_subexp_f): New function.
1216         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1217         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1218         (dump_subexp_body_f): Likewise.
1219         (operator_check_f): Likewise.
1220         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1221         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1222
1223 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1224
1225         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1226         UNOP_KIND.
1227         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1228         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1229         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1230         (operator_length_f): New fuction.
1231         (print_subexp_f): New function.
1232         (op_name_f): New function.
1233         (dump_subexp_body_f): New function.
1234         (operator_check_f): New function.
1235         (exp_descriptor_f): Replace standard expression handling functions
1236         with new functions.
1237         * gdb/fortran-operator.def: New file.
1238         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1239         * gdb/std-operator.def: Remove UNOP_KIND.
1240
1241 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * std-operator.def: Remove unbalanced, stray double quote
1244         character.
1245
1246 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1247             Chris January  <chris.january@arm.com>
1248             Daniel Everett  <daniel.everett@arm.com>
1249             Nick Forrington  <nick.forrington@arm.com>
1250             Richard Bunt  <richard.bunt@arm.com>
1251
1252         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1253         of depth when printing anonymous structs or unions.
1254         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1255         Don't print either the top-level value, or the children if the
1256         max-depth is exceeded.
1257         (ppscm_print_children): When printing the key of a map, allow one
1258         extra level of depth.
1259         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1260         print either the top-level value, or the children if the max-depth
1261         is exceeded.
1262         (print_children): When printing the key of a map, allow one extra
1263         level of depth.
1264         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1265         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1266         (user_print_options): Initialise max_depth field.
1267         (val_print_scalar_or_string_type_p): New function.
1268         (val_print): Check to see if the max depth has been reached.
1269         (val_print_check_max_depth): Define new function.
1270         (show_print_max_depth): New function.
1271         (_initialize_valprint): Add 'print max-depth' option.
1272         * valprint.h (struct value_print_options) <max_depth>: New field.
1273         (val_print_check_max_depth): Declare new function.
1274         * NEWS: Document new feature.
1275
1276 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1277
1278         * ada-lang.c (ada_language_defn): Initialise new field.
1279         * c-lang.c (c_is_string_type_p): New function.
1280         (c_language_defn): Initialise new field.
1281         (cplus_language_defn): Initialise new field.
1282         (asm_language_defn): Initialise new field.
1283         (minimal_language_defn): Initialise new field.
1284         * c-lang.h (c_is_string_type_p): Declare new function.
1285         * d-lang.c (d_language_defn): Initialise new field.
1286         * f-lang.c (f_is_string_type_p): New function.
1287         (f_language_defn): Initialise new field.
1288         * go-lang.c (go_is_string_type_p): New function.
1289         (go_language_defn): Initialise new field.
1290         * language.c (default_is_string_type_p): New function.
1291         (unknown_language_defn): Initialise new field.
1292         (auto_language_defn): Initialise new field.
1293         * language.h (struct language_defn) <la_is_string_type_p>: New
1294         member variable.
1295         (default_is_string_type_p): Declare new function.
1296         * m2-lang.c (m2_language_defn): Initialise new field.
1297         * objc-lang.c (objc_language_defn): Initialise new field.
1298         * opencl-lang.c (opencl_language_defn): Initialise new field.
1299         * p-lang.c (pascal_is_string_type_p): New function.
1300         (pascal_language_defn): Initialise new field.
1301         * rust-lang.c (rust_is_string_type_p): New function.
1302         (rust_language_defn): Initialise new field.
1303
1304 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1307         New field.
1308         * ada-lang.c (ada_language_defn): Initialise new field.
1309         * c-lang.c (c_language_defn): Likewise.
1310         (cplus_language_defn): Likewise.
1311         (asm_language_defn): Likewise.
1312         (minimal_language_defn): Likewise.
1313         * d-lang.c (d_language_defn): Likewise.
1314         * f-lang.c (f_language_defn): Likewise.
1315         * go-lang.c (go_language_defn): Likewise.
1316         * language.c (unknown_language_defn): Likewise.
1317         (auto_language_defn): Likewise.
1318         * m2-lang.c (m2_language_defn): Likewise.
1319         * objc-lang.c (objc_language_defn): Likewise.
1320         * opencl-lang.c (opencl_language_defn): Likewise.
1321         * p-lang.c (pascal_language_defn): Likewise.
1322         * rust-lang.c (rust_language_defn): Likewise.
1323
1324 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * ada-lang.c (ada_is_character_type): Change return type to bool.
1327         (ada_is_string_type): Likewise.
1328         * ada-lang.h (ada_is_character_type): Update declaration
1329         (ada_is_string_type): Likewise.
1330
1331 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1332
1333         Support style in 'frame|thread apply'
1334
1335         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1336         * record.c (record_start, record_stop): Update callers of
1337         execute_command_to_string with false.
1338         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1339         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1340         methods.
1341         (class string_file): New constructor with term_out parameter.
1342         Override methods term_out and can_emit_style_escape.  New member
1343         term_out.
1344         (class stdio_file): Override can_emit_style_escape.
1345         (class tee_file): Override term_out and can_emit_style_escape.
1346         * utils.h (can_emit_style_escape): Remove.
1347         * utils.c (can_emit_style_escape): Likewise.
1348         Update all callers of can_emit_style_escape (SOMESTREAM) to
1349         SOMESTREAM->can_emit_style_escape.
1350         * source-cache.c (source_cache::get_source_lines): Likewise.
1351         * stack.c (frame_apply_command_count): Call execute_command_to_string
1352         passing the term_out characteristic of the current gdb_stdout.
1353         * thread.c (thr_try_catch_cmd): Likewise.
1354         * top.c (execute_command_to_string): pass term_out parameter
1355         to construct the string_file for the command output.
1356         * ui-file.c (term_cli_styling): New function (most code moved
1357         from utils.c can_emit_style_escape).
1358         (string_file::string_file, string_file::can_emit_style_escape,
1359         stdio_file::can_emit_style_escape, tee_file::term_out,
1360         tee_file::can_emit_style_escape): New functions.
1361
1362 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1363
1364         * NEWS: Mention the new set|show may-call-functions.
1365         * infcall.c (may_call_functions_p): New variable.
1366         (show_may_call_functions_p): New function.
1367         (call_function_by_hand_dummy): Throws an error if not
1368         may-call-functions.
1369         (_initialize_infcall): Call add_setshow_boolean_cmd for
1370         may-call-functions.
1371
1372 2019-04-25  Keith Seitz  <keiths@redhat.com>
1373
1374         PR c++/24367
1375         * cp-support.c (inspect_type): Don't attempt substitutions
1376         of symbol with the same name.
1377
1378 2019-04-25  Tom Tromey  <tromey@adacore.com>
1379
1380         PR gdb/24475:
1381         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1382         static.
1383
1384 2019-04-25  Tom Tromey  <tromey@adacore.com>
1385
1386         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1387         rvalue reference.
1388         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1389         (gdb_xml_parser::parse): Use std::move.
1390         * python/python-internal.h (gdbpy_convert_exception): Take a const
1391         reference.
1392         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1393         std::move.
1394         * python/py-utils.c (gdbpy_convert_exception): Take a const
1395         reference.
1396         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1397         Use std::move.
1398         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1399         Use std::move.
1400         * mi/mi-main.c (mi_print_exception): Take a const reference.
1401         * main.c (handle_command_errors): Take a const reference.
1402         * linespec.c (parse_linespec): Use std::move.
1403         * infcall.c (run_inferior_call): Use std::move.
1404         (call_function_by_hand_dummy): Use std::move.
1405         * exec.c (try_open_exec_file): Use std::move.
1406         * exceptions.h (exception_print, exception_fprintf)
1407         (exception_print_same): Update.
1408         * exceptions.c (print_exception, exception_print)
1409         (exception_fprintf, exception_print_same): Change parameters to
1410         const reference.
1411         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1412         * common/new-op.c: Use std::move.
1413         * common/common-exceptions.h (struct gdb_exception): Add move
1414         constructor.
1415         (struct gdb_exception_error, struct gdb_exception_quit, struct
1416         gdb_quit_bad_alloc): Change constructor to move constructor.
1417         (throw_exception): Change parameter to rvalue reference.
1418         * common/common-exceptions.c (throw_exception): Take rvalue
1419         reference.
1420         * cli/cli-interp.c (safe_execute_command): Use std::move.
1421         * breakpoint.c (insert_bp_location, location_to_sals): Use
1422         std::move.
1423
1424 2019-04-25  Tom Tromey  <tromey@adacore.com>
1425
1426         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1427         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1428         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1429         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1430         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1431         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1432         guile/scm-value.c: Use unpack.
1433         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1434         gdbscm_gdb_exception.
1435         (gdbscm_throw_gdb_exception): Likewise.
1436         (struct gdbscm_gdb_exception): New.
1437         (unpack): New function.
1438         (gdbscm_wrap): Use unpack.
1439
1440 2019-04-25  Tom Tromey  <tromey@adacore.com>
1441
1442         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1443         (gdb_rl_callback_handler): Use std::move.
1444         * common/common-exceptions.h (struct gdb_exception): Add move
1445         assignment operator.
1446         (throw_exception_sjlj): Change "exception" to const reference.
1447         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1448         (throw_exception_sjlj): Change "exception" to const reference.
1449
1450 2019-04-25  Tom Tromey  <tromey@adacore.com>
1451
1452         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1453         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1454         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1455         Update.
1456         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1457         Update.
1458         * mi/mi-interp.c (mi_interp::exec): Update.
1459         * linespec.c (parse_linespec): Update.
1460         * infcall.c (run_inferior_call): Update.
1461         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1462         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1463         (gdbscm_lookup_global_symbol): Update.
1464         * guile/scm-param.c (gdbscm_parameter_value): Update.
1465         * guile/scm-frame.c (gdbscm_frame_read_register)
1466         (gdbscm_frame_read_var): Update.
1467         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1468         * exec.c (try_open_exec_file): Update.
1469         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1470         (gdb_rl_callback_handler): Update.
1471         * common/common-exceptions.h (exception_none): Don't declare.
1472         * common/common-exceptions.c (exception_none): Don't define.
1473         (struct catcher) <exception>: Update.
1474         * cli/cli-interp.c (safe_execute_command): Update.
1475         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1476
1477 2019-04-25  Ali Tamur  <tamur@google.com>
1478
1479         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1480         (read_attribute_value): Likewise.
1481         (dwarf2_read_addr_index): Update comment.
1482         (read_str_index): Add DW_FORM_strx.
1483         (dwarf2_string_attr): Likewise.
1484         (dwarf2_const_value_attr): Likewise.
1485         (dump_die_shallow): Likewise.
1486         (dwarf2_fetch_constant_bytes): Likewise.
1487         (skip_form_bytes): Likewise.
1488         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1489
1490 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1491
1492         PR corefiles/11608
1493         PR corefiles/18187
1494         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1495         OFFSET.  Verify if current mapping contains an ELF header.
1496         (linux_find_memory_regions_full): Adjust call to
1497         dump_mapping_p.
1498
1499 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1500             Kang Li <kanglictf@gmail.com>
1501
1502         PR gdb/21600
1503
1504         * dwarf2-frame.c (read_initial_length): Be consistent about using
1505         unsigned representation of length.
1506         (decode_frame_entry_1): Likewise.  Check for wraparound of
1507         end pointer as well as buffer overflow.
1508
1509 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1510
1511         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1512         "vq".
1513
1514 2019-04-24  Tom Tromey  <tromey@adacore.com>
1515
1516         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1517
1518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * s12z-tdep.c (s12z_unwind_pc): Delete.
1521         (s12z_unwind_sp): Delete.
1522         (s12z_gdbarch_init): Don't register deleted functions with
1523         gdbarch.
1524
1525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1526
1527         * rl78-tdep.c (rl78_unwind_sp): Delete.
1528         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1529
1530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1531
1532         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1533         (xstormy16_unwind_pc): Delete.
1534         (xstormy16_dummy_id): Delete.
1535         (xstormy16_gdbarch_init): Don't register deleted functions with
1536         gdbarch.
1537
1538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * vax-tdep.c (vax_unwind_pc): Delete.
1541         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1542
1543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1544
1545         * v850-tdep.c (v850_unwind_sp): Delete.
1546         (v850_unwind_pc): Delete.
1547         (v850_dummy_id): Delete.
1548         (v850_gdbarch_init): Don't register deleted functions with
1549         gdbarch.
1550
1551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1554         (tilegx_unwind_pc): Delete.
1555         (tilegx_unwind_dummy_id): Delete.
1556         (tilegx_gdbarch_init): Don't register deleted functions with
1557         gdbarch.
1558
1559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1560
1561         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1562         (tic6x_dummy_id): Delete.
1563         (tic6x_gdbarch_init): Don't register deleted functions with
1564         gdbarch.
1565
1566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1567
1568         * sparc-tdep.c (sparc_unwind_pc): Delete.
1569         (sparc32_gdbarch_init): Don't register deleted function with
1570         gdbarch.
1571
1572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * sh-tdep.c (sh_unwind_sp): Delete.
1575         (sh_unwind_pc): Delete.
1576         (sh_dummy_id): Delete.
1577         (sh_gdbarch_init): Don't register deleted functions with
1578         gdbarch.
1579
1580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * score-tdep.c (score_unwind_sp): Delete.
1583         (score_unwind_pc): Delete.
1584         (score_dummy_id): Delete.
1585         (score_gdbarch_init): Don't register deleted functions with
1586         gdbarch.
1587
1588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * rx-tdep.c (rx_unwind_pc): Delete.
1591         (rx_unwind_sp): Delete.
1592         (rx_dummy_id): Delete.
1593         (rx_gdbarch_init): Don't register deleted functions with
1594         gdbarch.  Update comment.
1595
1596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1597
1598         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1599         (rs6000_dummy_id): Delete.
1600         (rs6000_gdbarch_init): Don't register deleted functions with
1601         gdbarch.
1602
1603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1604
1605         * or1k-tdep.c (or1k_dummy_id): Delete.
1606         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1607
1608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1609
1610         * nios2-tdep.c (nios2_dummy_id): Delete.
1611         (nios2_unwind_sp): Delete.
1612         (nios2_gdbarch_init): Don't register deleted functions with
1613         gdbarch.
1614
1615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * nds32-tdep.c (nds32_dummy_id): Delete.
1618         (nds32_unwind_pc): Delete.
1619         (nds32_unwind_sp): Delete.
1620         (nds32_gdbarch_init): Don't register deleted functions with
1621         gdbarch.
1622
1623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1624
1625         * msp430-tdep.c (msp430_unwind_pc): Delete.
1626         (msp430_unwind_sp): Delete.
1627         (msp430_dummy_id): Delete.
1628         (msp430_gdbarch_init): Don't register deleted functions with
1629         gdbarch.
1630
1631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1632
1633         * moxie-tdep.c (moxie_unwind_sp): Delete.
1634         (moxie_unwind_pc): Delete.
1635         (moxie_dummy_id): Delete.
1636         (moxie_gdbarch_init): Don't register deleted functions with
1637         gdbarch.
1638
1639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1640
1641         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1642         (mn10300_unwind_pc): Delete.
1643         (mn10300_unwind_sp): Delete.
1644         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1645         mn10300_unwind_sp.
1646         (mn10300_frame_unwind_init): Don't register deleted functions with
1647         gdbarch.
1648
1649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1650
1651         * mep-tdep.c (mep_unwind_pc): Delete.
1652         (mep_unwind_sp): Delete.
1653         (mep_dummy_id): Delete.
1654         (mep_gdbarch_init): Don't register deleted functions with
1655         gdbarch.
1656
1657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1658
1659         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1660         (m68hc11_unwind_sp): Delete.
1661         (m68hc11_gdbarch_init): Don't register deleted functions with
1662         gdbarch.
1663
1664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1665
1666         * m32r-tdep.c (m32r_unwind_sp): Delete.
1667         (m32r_unwind_pc): Delete.
1668         (m32r_dummy_id): Delete.
1669         (m32r_gdbarch_init): Don't register deleted functions with
1670         gdbarch.
1671
1672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1673
1674         * m32c-tdep.c (m32c_unwind_pc): Delete.
1675         (m32c_unwind_sp): Delete.
1676         (m32c_dummy_id): Delete.
1677         (m32c_gdbarch_init): Don't register deleted functions with
1678         gdbarch.
1679
1680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1681
1682         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1683         (lm32_unwind_pc): Delete.
1684         (lm32_dummy_id): Delete.
1685         (lm32_gdbarch_init): Don't register deleted functions with
1686         gdbarch.
1687
1688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1689
1690         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1691         (iq2000_unwind_pc): Delete.
1692         (iq2000_dummy_id): Delete.
1693         (iq2000_gdbarch_init): Don't register deleted functions with
1694         gdbarch.
1695
1696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1697
1698         * nds32-tdep.c (nds32_type_align): Delete.
1699         (nds32_push_dummy_call): Use type_align instead.
1700
1701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1702
1703         * arm-tdep.c (arm_type_align): Only handle vector override case.
1704         (arm_push_dummy_call): Use type_align.
1705         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1706
1707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1708
1709         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1710         case.
1711         (pass_on_stack): Use type_align.
1712         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1713         function.
1714
1715 2019-04-23  Tom Tromey  <tromey@adacore.com>
1716
1717         * dwarf2read.c (line_header::file_name_at): Remove unused
1718         overload.
1719
1720 2019-04-23  Tom de Vries  <tdevries@suse.de>
1721
1722         PR gdb/24438
1723         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1724         invocation.
1725
1726
1727 2019-03-27  Ali Tamur  <tamur@google.com>
1728
1729         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1730         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1731         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1732         (dwarf_expr_context::get_addr_index): Likewise
1733         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1734         (symbol_needs_eval_context::get_addr_index): Likewise
1735         (disassemble_dwarf_expression): Add DW_OP_addrx
1736         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1737         (read_cutu_die_from_dwo): Update comment
1738         (skip_one_die): Add DW_FORM_addrx
1739         (read_attribute_value): Likewise
1740         (var_decode_location): Add DW_OP_addrx
1741         (dwarf2_const_value_attr): Add DW_FORM_addrx
1742         (dump_die_shallow): Likewise
1743         (dwarf2_fetch_constant_bytes): Likewise
1744         (decode_locdesc): Add DW_OP_addrx
1745         (skip_form_bytes): Add DW_FORM_addrx
1746
1747 2019-04-22  Ali Tamur  <tamur@google.com>
1748
1749         * MAINTAINERS (Write After Approval): Add self.
1750
1751 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1752
1753         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1754         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1755         (open_symbol_file_object): Likewise.
1756         (svr4_default_sos): Add info parameter.
1757         (svr4_read_so_list): Likewise.
1758         (svr4_current_sos_direct): Adjust functions calls to pass down
1759         info.
1760         (svr4_current_sos_1): Add info parameter.
1761         (svr4_current_sos): Call get_svr4_info, pass info down to
1762         svr4_current_sos_1.
1763         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1764         get_svr4_info.
1765         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1766         get_svr4_info.
1767         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1768         to get_svr4_info.
1769         (probes_table_remove_objfile_probes): Likewise.
1770         (register_solib_event_probe): Add info parameter.
1771         (solist_update_incremental): Pass info parameter down to
1772         svr4_read_so_list.
1773         (disable_probes_interface): Add info parameter.
1774         (svr4_handle_solib_event): Pass current_program_space to
1775         get_svr4_info.  Adjust disable_probes_interface cleanup.
1776         (svr4_create_probe_breakpoints): Add info parameter, pass it
1777         down to register_solib_event_probe.
1778         (svr4_create_solib_event_breakpoints): Add info parameter,
1779         pass it down to svr4_create_probe_breakpoints.
1780         (enable_break): Pass info down to
1781         svr4_create_solib_event_breakpoints.
1782         (svr4_solib_create_inferior_hook): Pass current_program_space to
1783         get_svr4_info.
1784         (svr4_clear_solib): Likewise.
1785
1786 2019-04-22  Pedro Alves  <palves@redhat.com>
1787
1788         * solib-svr4.c (svr4_free_objfile_observer): New.
1789         (probe_and_action::objfile): New field.
1790         (probes_table_htab_remove_objfile_probes)
1791         (probes_table_remove_objfile_probes): New functions.
1792         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1793         in the new probe_and_action.  Don't store the probe in 'lookup'.
1794         (svr4_create_probe_breakpoints): Pass objfile to
1795         register_solib_event_probe.
1796         (_initialize_svr4_solib): Register a free_objfile observer.
1797
1798 2019-04-19  Tom Tromey  <tom@tromey.com>
1799
1800         * common/queue.h: Remove.
1801
1802 2019-04-19  Tom Tromey  <tom@tromey.com>
1803
1804         * event-loop.c: Don't include "common/queue.h".
1805
1806 2019-04-19  Tom Tromey  <tom@tromey.com>
1807
1808         * remote.c (remote_target): Use delete.
1809         * remote-notif.h: Include <list>, not "common/queue.h".
1810         (notif_client_p): Remove typedef.
1811         (remote_notif_state): Add constructor, destructor, initializer.
1812         <notif_queue>: Now a std::list.
1813         (remote_notif_state_xfree): Don't declare.
1814         * remote-notif.c (remote_notif_process, handle_notification)
1815         (remote_notif_state_allocate): Update.
1816         (~remote_notif_state): Rename from remote_notif_state_xfree.
1817
1818 2019-04-19  Tom Tromey  <tom@tromey.com>
1819
1820         * symfile.c (reread_symbols): Update.
1821         * objfiles.c (objfile_register_static_link)
1822         (objfile_lookup_static_link): Update
1823         (~objfile) Don't delete static_links.
1824         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1825
1826 2019-04-19  Tom Tromey  <tom@tromey.com>
1827
1828         * type-stack.h (struct type_stack) <insert>: Constify string.
1829         * type-stack.c (type_stack::insert): Constify string.
1830         * gdbtypes.h (lookup_template_type): Update.
1831         (address_space_name_to_int): Update.
1832         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1833         const.
1834         (lookup_template_type): Make name const.
1835         * c-exp.y: Update rules.
1836         (lex_one_token, classify_name, classify_inner_name)
1837         (c_print_token): Update.
1838         * p-exp.y: Update rules.
1839         (yylex): Update.
1840         * f-exp.y: Update rules.
1841         (yylex): Update.
1842         * d-exp.y: Update rules.
1843         (lex_one_token, classify_name, classify_inner_name): Update.
1844         * parse.c (write_dollar_variable, copy_name): Return std::string.
1845         * parser-defs.h (copy_name): Change return type.
1846         * m2-exp.y: Update rules.
1847         (yylex): Update.
1848         * go-exp.y (lex_one_token): Update.
1849         Update rules.
1850         (classify_unsafe_function, classify_packaged_name)
1851         (classify_name, yylex): Update.
1852
1853 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1854
1855         * configure.ac: add --enable-source-highlight switch.
1856         * configure: Regenerate.
1857         * top.c (print_gdb_version): plumb --enable-source-highlight
1858         status to "show configuration".
1859
1860 2019-04-19  Tom Tromey  <tromey@adacore.com>
1861
1862         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1863         Check ADA_TYPE_P.
1864         (empty_record, ada_template_to_fixed_record_type_1)
1865         (template_to_static_fixed_type)
1866         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1867         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1868         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1869         macros.
1870
1871 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1872
1873         PR symtab/24423:
1874         * source.c (print_source_lines_base): Advance "iter" when a
1875         control character is seen.
1876
1877 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1878
1879         * inferior.h (struct infcall_suspend_state_deleter):
1880         Catch exception in destructor to avoid crash.
1881
1882 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1883
1884         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1885         close to the add_com "shell".
1886
1887 2019-04-18  Tom Tromey  <tromey@adacore.com>
1888
1889         * process-stratum-target.h (class process_stratum_target)
1890         <stratum>: Add "final".
1891
1892 2019-04-17  Tom Tromey  <tromey@adacore.com>
1893
1894         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1895         against nullptr before use.
1896
1897 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1898
1899         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1900
1901 2019-04-17  Jim Wilson  <jimw@sifive.com>
1902             Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1905         code read might fail, assume 4-byte breakpoint in that case.
1906
1907 2019-04-15  Leszek Swirski  <leszeks@google.com>
1908
1909         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1910         rather than a hand-rolled POD check when checking for forced MEMORY
1911         classification.
1912
1913 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1914
1915         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1916         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1917         function.
1918         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1919         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1920         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1921         declaration.
1922
1923 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1924
1925         * aarch64-linux-nat.c
1926         (aarch64_linux_nat_target::thread_architecture): Add override.
1927         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1928         each VQ.
1929
1930 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1931
1932         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1933
1934 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1935
1936         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1937         target types of size 96-bits, add some additional comments, and
1938         check that the builtin type we found was the correct size.
1939
1940 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1941
1942         * utils.c (prompt_for_continue): Don't restore the styling at the
1943         end, as applied_style has the wrong value.  This fixes styling in
1944         long lists of file names that are interrupted by the "Continue?"
1945         prompt.
1946
1947 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1948
1949         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1950         * c-lang.c (c_language_defn): Likewise.
1951         (cplus_language_defn): Likewise.
1952         (asm_language_defn): Likewise.
1953         (minimal_language_defn): Likewise.
1954         * d-lang.c (d_language_defn): Likewise.
1955         * f-lang.c (f_language_defn): Likewise.
1956         * go-lang.c (go_language_defn): Likewise.
1957         * language.c (unknown_language_defn): Likewise.
1958         (auto_language_defn): Likewise.
1959         * language.h (struct language_defn): Remove la_magic field.
1960         (LANG_MAGIC): Delete.
1961         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1962         * objc-lang.c (objc_language_defn): Likewise.
1963         * opencl-lang.c (opencl_language_defn): Likewise.
1964         * p-lang.c (pascal_language_defn): Likewise.
1965         * rust-lang.c (rust_language_defn): Likewise.
1966
1967 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1968
1969         * riscv-tdep.c (riscv_type_align): New function.
1970         (riscv_type_alignment): Delete.
1971         (riscv_arg_location): Use 'type_align'.
1972         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1973
1974 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * gdbtypes.c (type_align): A struct with no non-static fields also
1977         has alignment of 1.
1978
1979 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1980
1981         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1982         component to 0.
1983         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1984         member.
1985         (riscv_struct_info::analyse): New implementation using new
1986         analyse_inner member function.
1987         (riscv_struct_info::field_offset): New member function.
1988         (riscv_struct_info::m_offsets): New member variable.
1989         (riscv_struct_info::analyse_inner): New private member function,
1990         takes the old implementation of riscv_struct_info::analyse but
1991         extended to track field offsets.
1992         (riscv_call_arg_struct): Update the struct folding special cases
1993         to handle cases where empty C++ structs, which are non-zero
1994         length, are found.
1995         (riscv_arg_location): Initialise the length of each location, a
1996         non-zero length now indicates the location is in use.
1997         (riscv_push_dummy_call): Allow for the first location having a
1998         non-zero offset when setting up arguments.
1999         (riscv_return_value): Likewise, but for return values.
2000
2001 2019-04-11  Tom Tromey  <tromey@adacore.com>
2002
2003         * utils.c (internal_vproblem): Make "msg" const.
2004
2005 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2006
2007         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2008         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2009         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2010         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2011
2012 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2013
2014         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2015         function.
2016         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2017         of amd64_collect_native_gregset.
2018         (amd64_linux_nat_target::store_registers): Likewise.
2019
2020 2019-04-10  Tom Tromey  <tom@tromey.com>
2021
2022         * symtab.c (lookup_global_symbol_from_objfile)
2023         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2024         * objfiles.h (class separate_debug_iterator): New.
2025         (class separate_debug_range): New.
2026         (struct objfile) <separate_debug_objfiles>: New method.
2027         (objfile_separate_debug_iterate): Don't declare.
2028         * objfiles.c (separate_debug_iterator::operator++): Rename from
2029         objfile_separate_debug_iterate.
2030         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2031         iterator.
2032         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2033         iterator.
2034
2035 2019-04-10  Tom Tromey  <tom@tromey.com>
2036
2037         * symfile.c (reread_symbols): Remove old comment.
2038         * objfiles.c (free_all_objfiles): Fix a typo.
2039
2040 2019-04-10  Tom Tromey  <tom@tromey.com>
2041
2042         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2043         * minsyms.c (lookup_minimal_symbol): Use foreach.
2044         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2045         (lookup_minimal_symbol_solib_trampoline): Likewise.
2046         * symfile.c (reread_symbols): Use foreach.
2047
2048 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2049             Tom Tromey  <tromey@adacore.com>
2050
2051         PR rust/24414:
2052         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2053         (rust_lex_int_test): Change "value" to be LONGEST.
2054         (rust_lex_tests): Add test for long integer literal.
2055
2056 2019-04-09  Tom Tromey  <tromey@adacore.com>
2057
2058         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2059         to bool.
2060         (extended_remote_target::attach): Update.
2061         (remote_target::remote_notice_new_inferior): Update.
2062         (remote_target::add_current_inferior_and_thread): Update.
2063         * inferior.c (exit_inferior_1): Use "false".
2064         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2065
2066 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2067
2068         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2069         the "start" command.
2070
2071 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2072
2073         * python/py-inferior.c (infpy_thread_from_thread_handle):
2074         Adjust comments to reflect renaming of thread_from_thread_handle
2075         to thread_from_handle.  Adjust keywords.  Fix type error message.
2076         (inferior_object_methods): Add thread_from_handle.  Retain
2077         thread_from_thread_handle, but mark it as deprecated.
2078
2079 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2080
2081         * gdbthread.h (find_thread_by_handle): Revise declaration.
2082         * thread.c (find_thread_by_handle): Likewise.  Adjust
2083         implementation too.
2084         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2085         support for buffer objects as handles.
2086
2087 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2088
2089         * python/py-infthread.c (thpy_thread_handle): New function.
2090         (thread_object_methods): Register thpy_thread_handle.
2091
2092 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2093
2094         * gdbthread.h (thread_to_thread_handle): Declare.
2095         * thread.c (gdbtypes.h): Include.
2096         (thread_to_thread_handle): New function.
2097
2098         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2099         (target_thread_info_to_thread_handle): Declare.
2100         * target.c (target_thread_info_to_thread_handle): New function.
2101         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2102         * target-delegates.c: Regenerate.
2103
2104         * linux-thread-db.c (class thread_db_target): Add method
2105         thread_info_to_thread_handle.
2106         (thread_db_target::thread_info_to_thread_handle): Define.
2107         * remote.c (class remote_target): Add new method
2108         thread_info_to_thread_handle.
2109         (remote_target::thread_info_to_thread_handle): Define.
2110
2111 2019-04-08  Pedro Alves  <palves@redhat.com>
2112
2113         * common/common-exceptions.c (throw_exception): Don't create
2114         named object to throw; throw directly.
2115         (throw_it): Likewise.  Don't initialize gdb_exception::message
2116         here, with new; pass FMT and AP to the ctor instead.
2117         * common/common-exceptions.h: Include <string>.
2118         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2119         const char *, va_list)): New ctor.  Use std::make_shared.
2120         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2121         errors)): Delete.
2122         (gdb_exception_error::gdb_exception_error(enum errors, const char
2123         *, va_list)): New.
2124         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2125         Add assertion.
2126         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2127         errors)): Delete.
2128         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2129         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2130         Add assertion.
2131
2132 2019-04-08  Tom Tromey  <tom@tromey.com>
2133
2134         * valops.c (value_rtti_indirect_type): Replace throw_exception
2135         with throw.
2136         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2137         with throw.
2138         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2139         throw.
2140         * target.c (target_translate_tls_address): Replace throw_exception
2141         with throw.
2142         * stack.c (frame_apply_command_count): Replace throw_exception
2143         with throw.
2144         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2145         throw.
2146         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2147         with throw.
2148         * rs6000-tdep.c (rs6000_frame_cache)
2149         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2150         * remote.c: Replace throw_exception with throw.
2151         * record-full.c (record_full_message, record_full_wait_1)
2152         (record_full_restore): Replace throw_exception with throw.
2153         * record-btrace.c:
2154         (get_thread_current_frame_id, record_btrace_start_replaying)
2155         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2156         (cmd_record_btrace_start): Replace throw_exception with throw.
2157         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2158         throw.
2159         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2160         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2161         * linespec.c:
2162         (find_linespec_symbols): Replace throw_exception with throw.
2163         * infrun.c (displaced_step_prepare, resume): Replace
2164         throw_exception with throw.
2165         * infcmd.c (post_create_inferior): Replace throw_exception with
2166         throw.
2167         * inf-loop.c (inferior_event_handler): Replace throw_exception
2168         with throw.
2169         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2170         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2171         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2172         (get_prev_frame_always, get_frame_pc_if_available)
2173         (get_frame_address_in_block_if_available, get_frame_language):
2174         Replace throw_exception with throw.
2175         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2176         throw_exception with throw.
2177         * eval.c (fetch_subexp_value, evaluate_var_value)
2178         (evaluate_funcall, evaluate_subexp_standard): Replace
2179         throw_exception with throw.
2180         * dwarf2loc.c (call_site_find_chain)
2181         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2182         Replace throw_exception with throw.
2183         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2184         with throw.
2185         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2186         throw.
2187         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2188         * completer.c (complete_line_internal): Replace throw_exception
2189         with throw.
2190         * compile/compile-object-run.c (compile_object_run): Replace
2191         throw_exception with throw.
2192         * cli/cli-script.c (process_next_line): Replace throw_exception
2193         with throw.
2194         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2195         (btrace_enable, btrace_maint_update_pt_packets): Replace
2196         throw_exception with throw.
2197         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2198         throw_exception with throw.
2199         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2200         throw_exception with throw.
2201         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2202         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2203         * aarch64-tdep.c (aarch64_make_prologue_cache)
2204         (aarch64_make_stub_cache): Replace throw_exception with throw.
2205
2206 2019-04-08  Tom Tromey  <tom@tromey.com>
2207
2208         * common/common-exceptions.c (throw_exception): Rename from
2209         throw_exception_cxx.  Remove old copy.  Make argument const.
2210         (throw_it): Create and throw exception objects directly.
2211         * common/common-exceptions.h (throw_exception): Make argument
2212         const.
2213         (struct gdb_exception_error): Add constructor.
2214         (struct gdb_exception_quit): Add constructor.
2215
2216 2019-04-08  Tom Tromey  <tom@tromey.com>
2217
2218         * common/common-exceptions.h (exception_rethrow): Don't declare.
2219         (TRY_SJLJ): Update comment.
2220         (TRY, CATCH, END_CATCH): Remove.
2221         * common/common-exceptions.c (exception_rethrow): Remove.
2222
2223 2019-04-08  Tom Tromey  <tom@tromey.com>
2224
2225         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2226         Remove.
2227         (gdb_exception_error): Rename from
2228         gdb_exception_RETURN_MASK_ERROR.
2229         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2230         (gdb_quit_bad_alloc): Update.
2231         * aarch64-tdep.c: Update.
2232         * ada-lang.c: Update.
2233         * ada-typeprint.c: Update.
2234         * ada-valprint.c: Update.
2235         * amd64-tdep.c: Update.
2236         * arch-utils.c: Update.
2237         * break-catch-throw.c: Update.
2238         * breakpoint.c: Update.
2239         * btrace.c: Update.
2240         * c-varobj.c: Update.
2241         * cli/cli-cmds.c: Update.
2242         * cli/cli-interp.c: Update.
2243         * cli/cli-script.c: Update.
2244         * common/common-exceptions.c: Update.
2245         * common/new-op.c: Update.
2246         * common/selftest.c: Update.
2247         * compile/compile-c-symbols.c: Update.
2248         * compile/compile-cplus-symbols.c: Update.
2249         * compile/compile-object-load.c: Update.
2250         * compile/compile-object-run.c: Update.
2251         * completer.c: Update.
2252         * corelow.c: Update.
2253         * cp-abi.c: Update.
2254         * cp-support.c: Update.
2255         * cp-valprint.c: Update.
2256         * darwin-nat.c: Update.
2257         * disasm-selftests.c: Update.
2258         * dtrace-probe.c: Update.
2259         * dwarf-index-cache.c: Update.
2260         * dwarf-index-write.c: Update.
2261         * dwarf2-frame-tailcall.c: Update.
2262         * dwarf2-frame.c: Update.
2263         * dwarf2loc.c: Update.
2264         * dwarf2read.c: Update.
2265         * eval.c: Update.
2266         * event-loop.c: Update.
2267         * event-top.c: Update.
2268         * exec.c: Update.
2269         * f-valprint.c: Update.
2270         * fbsd-tdep.c: Update.
2271         * frame-unwind.c: Update.
2272         * frame.c: Update.
2273         * gdbtypes.c: Update.
2274         * gnu-v3-abi.c: Update.
2275         * guile/guile-internal.h: Update.
2276         * guile/scm-block.c: Update.
2277         * guile/scm-breakpoint.c: Update.
2278         * guile/scm-cmd.c: Update.
2279         * guile/scm-disasm.c: Update.
2280         * guile/scm-frame.c: Update.
2281         * guile/scm-lazy-string.c: Update.
2282         * guile/scm-math.c: Update.
2283         * guile/scm-param.c: Update.
2284         * guile/scm-ports.c: Update.
2285         * guile/scm-pretty-print.c: Update.
2286         * guile/scm-symbol.c: Update.
2287         * guile/scm-symtab.c: Update.
2288         * guile/scm-type.c: Update.
2289         * guile/scm-value.c: Update.
2290         * i386-linux-tdep.c: Update.
2291         * i386-tdep.c: Update.
2292         * inf-loop.c: Update.
2293         * infcall.c: Update.
2294         * infcmd.c: Update.
2295         * infrun.c: Update.
2296         * jit.c: Update.
2297         * language.c: Update.
2298         * linespec.c: Update.
2299         * linux-fork.c: Update.
2300         * linux-nat.c: Update.
2301         * linux-tdep.c: Update.
2302         * linux-thread-db.c: Update.
2303         * main.c: Update.
2304         * mi/mi-cmd-break.c: Update.
2305         * mi/mi-cmd-stack.c: Update.
2306         * mi/mi-interp.c: Update.
2307         * mi/mi-main.c: Update.
2308         * objc-lang.c: Update.
2309         * p-valprint.c: Update.
2310         * parse.c: Update.
2311         * ppc-linux-tdep.c: Update.
2312         * printcmd.c: Update.
2313         * python/py-arch.c: Update.
2314         * python/py-breakpoint.c: Update.
2315         * python/py-cmd.c: Update.
2316         * python/py-finishbreakpoint.c: Update.
2317         * python/py-frame.c: Update.
2318         * python/py-framefilter.c: Update.
2319         * python/py-gdb-readline.c: Update.
2320         * python/py-inferior.c: Update.
2321         * python/py-infthread.c: Update.
2322         * python/py-lazy-string.c: Update.
2323         * python/py-linetable.c: Update.
2324         * python/py-objfile.c: Update.
2325         * python/py-param.c: Update.
2326         * python/py-prettyprint.c: Update.
2327         * python/py-progspace.c: Update.
2328         * python/py-record-btrace.c: Update.
2329         * python/py-record.c: Update.
2330         * python/py-symbol.c: Update.
2331         * python/py-type.c: Update.
2332         * python/py-unwind.c: Update.
2333         * python/py-utils.c: Update.
2334         * python/py-value.c: Update.
2335         * python/python.c: Update.
2336         * record-btrace.c: Update.
2337         * record-full.c: Update.
2338         * remote-fileio.c: Update.
2339         * remote.c: Update.
2340         * riscv-tdep.c: Update.
2341         * rs6000-aix-tdep.c: Update.
2342         * rs6000-tdep.c: Update.
2343         * rust-exp.y: Update.
2344         * rust-lang.c: Update.
2345         * s390-tdep.c: Update.
2346         * selftest-arch.c: Update.
2347         * solib-dsbt.c: Update.
2348         * solib-frv.c: Update.
2349         * solib-spu.c: Update.
2350         * solib-svr4.c: Update.
2351         * solib.c: Update.
2352         * sparc64-linux-tdep.c: Update.
2353         * stack.c: Update.
2354         * symfile-mem.c: Update.
2355         * symmisc.c: Update.
2356         * target.c: Update.
2357         * thread.c: Update.
2358         * top.c: Update.
2359         * tracefile-tfile.c: Update.
2360         * tui/tui.c: Update.
2361         * typeprint.c: Update.
2362         * unittests/cli-utils-selftests.c: Update.
2363         * unittests/parse-connection-spec-selftests.c: Update.
2364         * valops.c: Update.
2365         * valprint.c: Update.
2366         * value.c: Update.
2367         * varobj.c: Update.
2368         * windows-nat.c: Update.
2369         * x86-linux-nat.c: Update.
2370         * xml-support.c: Update.
2371
2372 2019-04-08  Tom Tromey  <tom@tromey.com>
2373
2374         * xml-support.c: Use C++ exception handling.
2375         * x86-linux-nat.c: Use C++ exception handling.
2376         * windows-nat.c: Use C++ exception handling.
2377         * varobj.c: Use C++ exception handling.
2378         * value.c: Use C++ exception handling.
2379         * valprint.c: Use C++ exception handling.
2380         * valops.c: Use C++ exception handling.
2381         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2382         handling.
2383         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2384         * typeprint.c: Use C++ exception handling.
2385         * tui/tui.c: Use C++ exception handling.
2386         * tracefile-tfile.c: Use C++ exception handling.
2387         * top.c: Use C++ exception handling.
2388         * thread.c: Use C++ exception handling.
2389         * target.c: Use C++ exception handling.
2390         * symmisc.c: Use C++ exception handling.
2391         * symfile-mem.c: Use C++ exception handling.
2392         * stack.c: Use C++ exception handling.
2393         * sparc64-linux-tdep.c: Use C++ exception handling.
2394         * solib.c: Use C++ exception handling.
2395         * solib-svr4.c: Use C++ exception handling.
2396         * solib-spu.c: Use C++ exception handling.
2397         * solib-frv.c: Use C++ exception handling.
2398         * solib-dsbt.c: Use C++ exception handling.
2399         * selftest-arch.c: Use C++ exception handling.
2400         * s390-tdep.c: Use C++ exception handling.
2401         * rust-lang.c: Use C++ exception handling.
2402         * rust-exp.y: Use C++ exception handling.
2403         * rs6000-tdep.c: Use C++ exception handling.
2404         * rs6000-aix-tdep.c: Use C++ exception handling.
2405         * riscv-tdep.c: Use C++ exception handling.
2406         * remote.c: Use C++ exception handling.
2407         * remote-fileio.c: Use C++ exception handling.
2408         * record-full.c: Use C++ exception handling.
2409         * record-btrace.c: Use C++ exception handling.
2410         * python/python.c: Use C++ exception handling.
2411         * python/py-value.c: Use C++ exception handling.
2412         * python/py-utils.c: Use C++ exception handling.
2413         * python/py-unwind.c: Use C++ exception handling.
2414         * python/py-type.c: Use C++ exception handling.
2415         * python/py-symbol.c: Use C++ exception handling.
2416         * python/py-record.c: Use C++ exception handling.
2417         * python/py-record-btrace.c: Use C++ exception handling.
2418         * python/py-progspace.c: Use C++ exception handling.
2419         * python/py-prettyprint.c: Use C++ exception handling.
2420         * python/py-param.c: Use C++ exception handling.
2421         * python/py-objfile.c: Use C++ exception handling.
2422         * python/py-linetable.c: Use C++ exception handling.
2423         * python/py-lazy-string.c: Use C++ exception handling.
2424         * python/py-infthread.c: Use C++ exception handling.
2425         * python/py-inferior.c: Use C++ exception handling.
2426         * python/py-gdb-readline.c: Use C++ exception handling.
2427         * python/py-framefilter.c: Use C++ exception handling.
2428         * python/py-frame.c: Use C++ exception handling.
2429         * python/py-finishbreakpoint.c: Use C++ exception handling.
2430         * python/py-cmd.c: Use C++ exception handling.
2431         * python/py-breakpoint.c: Use C++ exception handling.
2432         * python/py-arch.c: Use C++ exception handling.
2433         * printcmd.c: Use C++ exception handling.
2434         * ppc-linux-tdep.c: Use C++ exception handling.
2435         * parse.c: Use C++ exception handling.
2436         * p-valprint.c: Use C++ exception handling.
2437         * objc-lang.c: Use C++ exception handling.
2438         * mi/mi-main.c: Use C++ exception handling.
2439         * mi/mi-interp.c: Use C++ exception handling.
2440         * mi/mi-cmd-stack.c: Use C++ exception handling.
2441         * mi/mi-cmd-break.c: Use C++ exception handling.
2442         * main.c: Use C++ exception handling.
2443         * linux-thread-db.c: Use C++ exception handling.
2444         * linux-tdep.c: Use C++ exception handling.
2445         * linux-nat.c: Use C++ exception handling.
2446         * linux-fork.c: Use C++ exception handling.
2447         * linespec.c: Use C++ exception handling.
2448         * language.c: Use C++ exception handling.
2449         * jit.c: Use C++ exception handling.
2450         * infrun.c: Use C++ exception handling.
2451         * infcmd.c: Use C++ exception handling.
2452         * infcall.c: Use C++ exception handling.
2453         * inf-loop.c: Use C++ exception handling.
2454         * i386-tdep.c: Use C++ exception handling.
2455         * i386-linux-tdep.c: Use C++ exception handling.
2456         * guile/scm-value.c: Use C++ exception handling.
2457         * guile/scm-type.c: Use C++ exception handling.
2458         * guile/scm-symtab.c: Use C++ exception handling.
2459         * guile/scm-symbol.c: Use C++ exception handling.
2460         * guile/scm-pretty-print.c: Use C++ exception handling.
2461         * guile/scm-ports.c: Use C++ exception handling.
2462         * guile/scm-param.c: Use C++ exception handling.
2463         * guile/scm-math.c: Use C++ exception handling.
2464         * guile/scm-lazy-string.c: Use C++ exception handling.
2465         * guile/scm-frame.c: Use C++ exception handling.
2466         * guile/scm-disasm.c: Use C++ exception handling.
2467         * guile/scm-cmd.c: Use C++ exception handling.
2468         * guile/scm-breakpoint.c: Use C++ exception handling.
2469         * guile/scm-block.c: Use C++ exception handling.
2470         * guile/guile-internal.h: Use C++ exception handling.
2471         * gnu-v3-abi.c: Use C++ exception handling.
2472         * gdbtypes.c: Use C++ exception handling.
2473         * frame.c: Use C++ exception handling.
2474         * frame-unwind.c: Use C++ exception handling.
2475         * fbsd-tdep.c: Use C++ exception handling.
2476         * f-valprint.c: Use C++ exception handling.
2477         * exec.c: Use C++ exception handling.
2478         * event-top.c: Use C++ exception handling.
2479         * event-loop.c: Use C++ exception handling.
2480         * eval.c: Use C++ exception handling.
2481         * dwarf2read.c: Use C++ exception handling.
2482         * dwarf2loc.c: Use C++ exception handling.
2483         * dwarf2-frame.c: Use C++ exception handling.
2484         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2485         * dwarf-index-write.c: Use C++ exception handling.
2486         * dwarf-index-cache.c: Use C++ exception handling.
2487         * dtrace-probe.c: Use C++ exception handling.
2488         * disasm-selftests.c: Use C++ exception handling.
2489         * darwin-nat.c: Use C++ exception handling.
2490         * cp-valprint.c: Use C++ exception handling.
2491         * cp-support.c: Use C++ exception handling.
2492         * cp-abi.c: Use C++ exception handling.
2493         * corelow.c: Use C++ exception handling.
2494         * completer.c: Use C++ exception handling.
2495         * compile/compile-object-run.c: Use C++ exception handling.
2496         * compile/compile-object-load.c: Use C++ exception handling.
2497         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2498         * compile/compile-c-symbols.c: Use C++ exception handling.
2499         * common/selftest.c: Use C++ exception handling.
2500         * common/new-op.c: Use C++ exception handling.
2501         * cli/cli-script.c: Use C++ exception handling.
2502         * cli/cli-interp.c: Use C++ exception handling.
2503         * cli/cli-cmds.c: Use C++ exception handling.
2504         * c-varobj.c: Use C++ exception handling.
2505         * btrace.c: Use C++ exception handling.
2506         * breakpoint.c: Use C++ exception handling.
2507         * break-catch-throw.c: Use C++ exception handling.
2508         * arch-utils.c: Use C++ exception handling.
2509         * amd64-tdep.c: Use C++ exception handling.
2510         * ada-valprint.c: Use C++ exception handling.
2511         * ada-typeprint.c: Use C++ exception handling.
2512         * ada-lang.c: Use C++ exception handling.
2513         * aarch64-tdep.c: Use C++ exception handling.
2514
2515 2019-04-08  Tom Tromey  <tom@tromey.com>
2516
2517         * xml-support.c (gdb_xml_parser::parse): Update.
2518         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2519         * value.c (show_convenience): Update.
2520         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2521         (test_parse_flags_qcs): Update.
2522         * thread.c (thr_try_catch_cmd): Update.
2523         * target.c (target_translate_tls_address): Update.
2524         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2525         (info_frame_command_core, frame_apply_command_count): Update.
2526         * rust-exp.y (rust_lex_exception_test): Update.
2527         * riscv-tdep.c (riscv_print_one_register_info): Update.
2528         * remote.c (remote_target::enable_btrace): Update.
2529         * record-btrace.c (record_btrace_enable_warn): Update.
2530         * python/py-utils.c (gdbpy_convert_exception): Update.
2531         * printcmd.c (do_one_display, print_variable_and_value): Update.
2532         * mi/mi-main.c (mi_print_exception): Update.
2533         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2534         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2535         * linux-nat.c (linux_nat_target::attach): Update.
2536         * linux-fork.c (class scoped_switch_fork_info): Update.
2537         * infrun.c (displaced_step_prepare): Update.
2538         * infcall.c (call_function_by_hand_dummy): Update.
2539         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2540         * gnu-v3-abi.c (print_one_vtable): Update.
2541         * frame.c (get_prev_frame_always): Update.
2542         * f-valprint.c (info_common_command_for_block): Update.
2543         * exec.c (try_open_exec_file): Update.
2544         * exceptions.c (print_exception, exception_print)
2545         (exception_fprintf, exception_print_same): Update.
2546         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2547         * dwarf-index-cache.c (index_cache::store)
2548         (index_cache::lookup_gdb_index): Update.
2549         * darwin-nat.c (maybe_cache_shell): Update.
2550         * cp-valprint.c (cp_print_value_fields): Update.
2551         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2552         (gcc_cplus_symbol_address): Update.
2553         * compile/compile-c-symbols.c (gcc_convert_symbol)
2554         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2555         * common/selftest.c: Update.
2556         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2557         a std::string.
2558         (exception_try_scope_entry, exception_try_scope_exit): Don't
2559         declare.
2560         (struct exception_try_scope): Remove.
2561         (TRY): Don't use exception_try_scope.
2562         (struct gdb_exception): Add constructor, operator=.
2563         <what>: New method.
2564         (struct gdb_exception_RETURN_MASK_ALL)
2565         (struct gdb_exception_RETURN_MASK_ERROR)
2566         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2567         (struct gdb_quit_bad_alloc): Update.
2568         * common/common-exceptions.c (exception_none): Change
2569         initializer.
2570         (struct catcher) <state, exception>: Initialize inline.
2571         <prev>: Remove member.
2572         (current_catcher): Remove.
2573         (catchers): New global.
2574         (exceptions_state_mc_init): Simplify.
2575         (catcher_pop): Remove.
2576         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2577         (try_scope_depth, exception_try_scope_entry)
2578         (exception_try_scope_exit): Remove.
2579         (throw_exception_sjlj): Update.
2580         (exception_messages, exception_messages_size): Remove.
2581         (throw_it): Simplify.
2582         (gdb_exception_sliced_copy): Remove.
2583         (throw_exception_cxx): Update.
2584         * cli/cli-script.c (script_from_file): Update.
2585         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2586         Update.
2587         * ada-valprint.c (ada_val_print): Update.
2588         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2589         (create_excep_cond_exprs): Update.
2590
2591 2019-04-08  Tom Tromey  <tom@tromey.com>
2592
2593         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2594         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2595         (TRY, CATCH, END_CATCH): Remove some definitions.
2596         * common/common-exceptions.c: Don't use GDB_XCPT.
2597         (catcher_list_size): Remove.
2598         (throw_exception, throw_it): Simplify.
2599
2600 2019-04-05  Tom Tromey  <tom@tromey.com>
2601
2602         Revert the header-sorting patch.
2603         * ft32-tdep.c: Revert.
2604         * frv-tdep.c: Revert.
2605         * frv-linux-tdep.c: Revert.
2606         * frame.c: Revert.
2607         * frame-unwind.c: Revert.
2608         * frame-base.c: Revert.
2609         * fork-child.c: Revert.
2610         * findvar.c: Revert.
2611         * findcmd.c: Revert.
2612         * filesystem.c: Revert.
2613         * filename-seen-cache.h: Revert.
2614         * filename-seen-cache.c: Revert.
2615         * fbsd-tdep.c: Revert.
2616         * fbsd-nat.h: Revert.
2617         * fbsd-nat.c: Revert.
2618         * f-valprint.c: Revert.
2619         * f-typeprint.c: Revert.
2620         * f-lang.c: Revert.
2621         * extension.h: Revert.
2622         * extension.c: Revert.
2623         * extension-priv.h: Revert.
2624         * expprint.c: Revert.
2625         * exec.h: Revert.
2626         * exec.c: Revert.
2627         * exceptions.c: Revert.
2628         * event-top.c: Revert.
2629         * event-loop.c: Revert.
2630         * eval.c: Revert.
2631         * elfread.c: Revert.
2632         * dwarf2read.h: Revert.
2633         * dwarf2read.c: Revert.
2634         * dwarf2loc.c: Revert.
2635         * dwarf2expr.h: Revert.
2636         * dwarf2expr.c: Revert.
2637         * dwarf2-frame.c: Revert.
2638         * dwarf2-frame-tailcall.c: Revert.
2639         * dwarf-index-write.h: Revert.
2640         * dwarf-index-write.c: Revert.
2641         * dwarf-index-common.c: Revert.
2642         * dwarf-index-cache.h: Revert.
2643         * dwarf-index-cache.c: Revert.
2644         * dummy-frame.c: Revert.
2645         * dtrace-probe.c: Revert.
2646         * disasm.h: Revert.
2647         * disasm.c: Revert.
2648         * disasm-selftests.c: Revert.
2649         * dictionary.c: Revert.
2650         * dicos-tdep.c: Revert.
2651         * demangle.c: Revert.
2652         * dcache.h: Revert.
2653         * dcache.c: Revert.
2654         * darwin-nat.h: Revert.
2655         * darwin-nat.c: Revert.
2656         * darwin-nat-info.c: Revert.
2657         * d-valprint.c: Revert.
2658         * d-namespace.c: Revert.
2659         * d-lang.c: Revert.
2660         * ctf.c: Revert.
2661         * csky-tdep.c: Revert.
2662         * csky-linux-tdep.c: Revert.
2663         * cris-tdep.c: Revert.
2664         * cris-linux-tdep.c: Revert.
2665         * cp-valprint.c: Revert.
2666         * cp-support.c: Revert.
2667         * cp-namespace.c: Revert.
2668         * cp-abi.c: Revert.
2669         * corelow.c: Revert.
2670         * corefile.c: Revert.
2671         * continuations.c: Revert.
2672         * completer.h: Revert.
2673         * completer.c: Revert.
2674         * complaints.c: Revert.
2675         * coffread.c: Revert.
2676         * coff-pe-read.c: Revert.
2677         * cli-out.h: Revert.
2678         * cli-out.c: Revert.
2679         * charset.c: Revert.
2680         * c-varobj.c: Revert.
2681         * c-valprint.c: Revert.
2682         * c-typeprint.c: Revert.
2683         * c-lang.c: Revert.
2684         * buildsym.c: Revert.
2685         * buildsym-legacy.c: Revert.
2686         * build-id.h: Revert.
2687         * build-id.c: Revert.
2688         * btrace.c: Revert.
2689         * bsd-uthread.c: Revert.
2690         * breakpoint.h: Revert.
2691         * breakpoint.c: Revert.
2692         * break-catch-throw.c: Revert.
2693         * break-catch-syscall.c: Revert.
2694         * break-catch-sig.c: Revert.
2695         * blockframe.c: Revert.
2696         * block.c: Revert.
2697         * bfin-tdep.c: Revert.
2698         * bfin-linux-tdep.c: Revert.
2699         * bfd-target.c: Revert.
2700         * bcache.c: Revert.
2701         * ax-general.c: Revert.
2702         * ax-gdb.h: Revert.
2703         * ax-gdb.c: Revert.
2704         * avr-tdep.c: Revert.
2705         * auxv.c: Revert.
2706         * auto-load.c: Revert.
2707         * arm-wince-tdep.c: Revert.
2708         * arm-tdep.c: Revert.
2709         * arm-symbian-tdep.c: Revert.
2710         * arm-pikeos-tdep.c: Revert.
2711         * arm-obsd-tdep.c: Revert.
2712         * arm-nbsd-tdep.c: Revert.
2713         * arm-nbsd-nat.c: Revert.
2714         * arm-linux-tdep.c: Revert.
2715         * arm-linux-nat.c: Revert.
2716         * arm-fbsd-tdep.c: Revert.
2717         * arm-fbsd-nat.c: Revert.
2718         * arm-bsd-tdep.c: Revert.
2719         * arch-utils.c: Revert.
2720         * arc-tdep.c: Revert.
2721         * arc-newlib-tdep.c: Revert.
2722         * annotate.h: Revert.
2723         * annotate.c: Revert.
2724         * amd64-windows-tdep.c: Revert.
2725         * amd64-windows-nat.c: Revert.
2726         * amd64-tdep.c: Revert.
2727         * amd64-sol2-tdep.c: Revert.
2728         * amd64-obsd-tdep.c: Revert.
2729         * amd64-obsd-nat.c: Revert.
2730         * amd64-nbsd-tdep.c: Revert.
2731         * amd64-nbsd-nat.c: Revert.
2732         * amd64-nat.c: Revert.
2733         * amd64-linux-tdep.c: Revert.
2734         * amd64-linux-nat.c: Revert.
2735         * amd64-fbsd-tdep.c: Revert.
2736         * amd64-fbsd-nat.c: Revert.
2737         * amd64-dicos-tdep.c: Revert.
2738         * amd64-darwin-tdep.c: Revert.
2739         * amd64-bsd-nat.c: Revert.
2740         * alpha-tdep.c: Revert.
2741         * alpha-obsd-tdep.c: Revert.
2742         * alpha-nbsd-tdep.c: Revert.
2743         * alpha-mdebug-tdep.c: Revert.
2744         * alpha-linux-tdep.c: Revert.
2745         * alpha-linux-nat.c: Revert.
2746         * alpha-bsd-tdep.c: Revert.
2747         * alpha-bsd-nat.c: Revert.
2748         * aix-thread.c: Revert.
2749         * agent.c: Revert.
2750         * addrmap.c: Revert.
2751         * ada-varobj.c: Revert.
2752         * ada-valprint.c: Revert.
2753         * ada-typeprint.c: Revert.
2754         * ada-tasks.c: Revert.
2755         * ada-lang.c: Revert.
2756         * aarch64-tdep.c: Revert.
2757         * aarch64-ravenscar-thread.c: Revert.
2758         * aarch64-newlib-tdep.c: Revert.
2759         * aarch64-linux-tdep.c: Revert.
2760         * aarch64-linux-nat.c: Revert.
2761         * aarch64-fbsd-tdep.c: Revert.
2762         * aarch64-fbsd-nat.c: Revert.
2763         * aarch32-linux-nat.c: Revert.
2764
2765 2019-04-05  Tom Tromey  <tom@tromey.com>
2766
2767         * ft32-tdep.c: Sort headers.
2768         * frv-tdep.c: Sort headers.
2769         * frv-linux-tdep.c: Sort headers.
2770         * frame.c: Sort headers.
2771         * frame-unwind.c: Sort headers.
2772         * frame-base.c: Sort headers.
2773         * fork-child.c: Sort headers.
2774         * findvar.c: Sort headers.
2775         * findcmd.c: Sort headers.
2776         * filesystem.c: Sort headers.
2777         * filename-seen-cache.h: Sort headers.
2778         * filename-seen-cache.c: Sort headers.
2779         * fbsd-tdep.c: Sort headers.
2780         * fbsd-nat.h: Sort headers.
2781         * fbsd-nat.c: Sort headers.
2782         * f-valprint.c: Sort headers.
2783         * f-typeprint.c: Sort headers.
2784         * f-lang.c: Sort headers.
2785         * extension.h: Sort headers.
2786         * extension.c: Sort headers.
2787         * extension-priv.h: Sort headers.
2788         * expprint.c: Sort headers.
2789         * exec.h: Sort headers.
2790         * exec.c: Sort headers.
2791         * exceptions.c: Sort headers.
2792         * event-top.c: Sort headers.
2793         * event-loop.c: Sort headers.
2794         * eval.c: Sort headers.
2795         * elfread.c: Sort headers.
2796         * dwarf2read.h: Sort headers.
2797         * dwarf2read.c: Sort headers.
2798         * dwarf2loc.c: Sort headers.
2799         * dwarf2expr.h: Sort headers.
2800         * dwarf2expr.c: Sort headers.
2801         * dwarf2-frame.c: Sort headers.
2802         * dwarf2-frame-tailcall.c: Sort headers.
2803         * dwarf-index-write.h: Sort headers.
2804         * dwarf-index-write.c: Sort headers.
2805         * dwarf-index-common.c: Sort headers.
2806         * dwarf-index-cache.h: Sort headers.
2807         * dwarf-index-cache.c: Sort headers.
2808         * dummy-frame.c: Sort headers.
2809         * dtrace-probe.c: Sort headers.
2810         * disasm.h: Sort headers.
2811         * disasm.c: Sort headers.
2812         * disasm-selftests.c: Sort headers.
2813         * dictionary.c: Sort headers.
2814         * dicos-tdep.c: Sort headers.
2815         * demangle.c: Sort headers.
2816         * dcache.h: Sort headers.
2817         * dcache.c: Sort headers.
2818         * darwin-nat.h: Sort headers.
2819         * darwin-nat.c: Sort headers.
2820         * darwin-nat-info.c: Sort headers.
2821         * d-valprint.c: Sort headers.
2822         * d-namespace.c: Sort headers.
2823         * d-lang.c: Sort headers.
2824         * ctf.c: Sort headers.
2825         * csky-tdep.c: Sort headers.
2826         * csky-linux-tdep.c: Sort headers.
2827         * cris-tdep.c: Sort headers.
2828         * cris-linux-tdep.c: Sort headers.
2829         * cp-valprint.c: Sort headers.
2830         * cp-support.c: Sort headers.
2831         * cp-namespace.c: Sort headers.
2832         * cp-abi.c: Sort headers.
2833         * corelow.c: Sort headers.
2834         * corefile.c: Sort headers.
2835         * continuations.c: Sort headers.
2836         * completer.h: Sort headers.
2837         * completer.c: Sort headers.
2838         * complaints.c: Sort headers.
2839         * coffread.c: Sort headers.
2840         * coff-pe-read.c: Sort headers.
2841         * cli-out.h: Sort headers.
2842         * cli-out.c: Sort headers.
2843         * charset.c: Sort headers.
2844         * c-varobj.c: Sort headers.
2845         * c-valprint.c: Sort headers.
2846         * c-typeprint.c: Sort headers.
2847         * c-lang.c: Sort headers.
2848         * buildsym.c: Sort headers.
2849         * buildsym-legacy.c: Sort headers.
2850         * build-id.h: Sort headers.
2851         * build-id.c: Sort headers.
2852         * btrace.c: Sort headers.
2853         * bsd-uthread.c: Sort headers.
2854         * breakpoint.h: Sort headers.
2855         * breakpoint.c: Sort headers.
2856         * break-catch-throw.c: Sort headers.
2857         * break-catch-syscall.c: Sort headers.
2858         * break-catch-sig.c: Sort headers.
2859         * blockframe.c: Sort headers.
2860         * block.c: Sort headers.
2861         * bfin-tdep.c: Sort headers.
2862         * bfin-linux-tdep.c: Sort headers.
2863         * bfd-target.c: Sort headers.
2864         * bcache.c: Sort headers.
2865         * ax-general.c: Sort headers.
2866         * ax-gdb.h: Sort headers.
2867         * ax-gdb.c: Sort headers.
2868         * avr-tdep.c: Sort headers.
2869         * auxv.c: Sort headers.
2870         * auto-load.c: Sort headers.
2871         * arm-wince-tdep.c: Sort headers.
2872         * arm-tdep.c: Sort headers.
2873         * arm-symbian-tdep.c: Sort headers.
2874         * arm-pikeos-tdep.c: Sort headers.
2875         * arm-obsd-tdep.c: Sort headers.
2876         * arm-nbsd-tdep.c: Sort headers.
2877         * arm-nbsd-nat.c: Sort headers.
2878         * arm-linux-tdep.c: Sort headers.
2879         * arm-linux-nat.c: Sort headers.
2880         * arm-fbsd-tdep.c: Sort headers.
2881         * arm-fbsd-nat.c: Sort headers.
2882         * arm-bsd-tdep.c: Sort headers.
2883         * arch-utils.c: Sort headers.
2884         * arc-tdep.c: Sort headers.
2885         * arc-newlib-tdep.c: Sort headers.
2886         * annotate.h: Sort headers.
2887         * annotate.c: Sort headers.
2888         * amd64-windows-tdep.c: Sort headers.
2889         * amd64-windows-nat.c: Sort headers.
2890         * amd64-tdep.c: Sort headers.
2891         * amd64-sol2-tdep.c: Sort headers.
2892         * amd64-obsd-tdep.c: Sort headers.
2893         * amd64-obsd-nat.c: Sort headers.
2894         * amd64-nbsd-tdep.c: Sort headers.
2895         * amd64-nbsd-nat.c: Sort headers.
2896         * amd64-nat.c: Sort headers.
2897         * amd64-linux-tdep.c: Sort headers.
2898         * amd64-linux-nat.c: Sort headers.
2899         * amd64-fbsd-tdep.c: Sort headers.
2900         * amd64-fbsd-nat.c: Sort headers.
2901         * amd64-dicos-tdep.c: Sort headers.
2902         * amd64-darwin-tdep.c: Sort headers.
2903         * amd64-bsd-nat.c: Sort headers.
2904         * alpha-tdep.c: Sort headers.
2905         * alpha-obsd-tdep.c: Sort headers.
2906         * alpha-nbsd-tdep.c: Sort headers.
2907         * alpha-mdebug-tdep.c: Sort headers.
2908         * alpha-linux-tdep.c: Sort headers.
2909         * alpha-linux-nat.c: Sort headers.
2910         * alpha-bsd-tdep.c: Sort headers.
2911         * alpha-bsd-nat.c: Sort headers.
2912         * aix-thread.c: Sort headers.
2913         * agent.c: Sort headers.
2914         * addrmap.c: Sort headers.
2915         * ada-varobj.c: Sort headers.
2916         * ada-valprint.c: Sort headers.
2917         * ada-typeprint.c: Sort headers.
2918         * ada-tasks.c: Sort headers.
2919         * ada-lang.c: Sort headers.
2920         * aarch64-tdep.c: Sort headers.
2921         * aarch64-ravenscar-thread.c: Sort headers.
2922         * aarch64-newlib-tdep.c: Sort headers.
2923         * aarch64-linux-tdep.c: Sort headers.
2924         * aarch64-linux-nat.c: Sort headers.
2925         * aarch64-fbsd-tdep.c: Sort headers.
2926         * aarch64-fbsd-nat.c: Sort headers.
2927         * aarch32-linux-nat.c: Sort headers.
2928
2929 2019-04-04  Tom Tromey  <tom@tromey.com>
2930
2931         * varobj.c (varobj_create): Update.
2932         * rust-exp.y (struct rust_parser) <update_innermost_block,
2933         lookup_symbol>: New methods.
2934         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2935         Rename.
2936         (rust_parser::rust_lookup_type)
2937         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2938         * printcmd.c (display_command, do_one_display): Update.
2939         * parser-defs.h (struct parser_state) <parser_state>: Add
2940         "tracker" parameter.
2941         (block_tracker): New member.
2942         (class innermost_block_tracker) <innermost_block_tracker>: Add
2943         "types" parameter.
2944         <reset>: Remove method.
2945         (innermost_block): Don't declare.
2946         (null_post_parser): Update.
2947         * parse.c (innermost_block): Remove global.
2948         (write_dollar_variable): Update.
2949         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2950         Remove "tracker_types" parameter.
2951         (parse_expression): Add "tracker" parameter.
2952         (parse_expression_for_completion): Update.
2953         (null_post_parser): Add "tracker" parameter.
2954         * p-exp.y: Update rules.
2955         * m2-exp.y: Update rules.
2956         * language.h (struct language_defn) <la_post_parser>: Add
2957         "tracker" parameter.
2958         * go-exp.y: Update rules.
2959         * f-exp.y: Update rules.
2960         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2961         parameter.
2962         * d-exp.y: Update rules.
2963         * c-exp.y: Update rules.
2964         * breakpoint.c (set_breakpoint_condition): Create an
2965         innermost_block_tracker.
2966         (watch_command_1): Likewise.
2967         * ada-lang.c (resolve): Add "tracker" parameter.
2968         (resolve_subexp): Likewise.
2969         * ada-exp.y (write_var_from_sym): Update.
2970
2971 2019-04-04  Tom Tromey  <tom@tromey.com>
2972
2973         * type-stack.h: New file.
2974         * type-stack.c: New file.
2975         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2976         type-stack.h.
2977         (insert_into_type_stack, insert_type, push_type, push_type_int)
2978         (insert_type_address_space, pop_type, pop_type_int)
2979         (pop_typelist, pop_type_stack, append_type_stack)
2980         (push_type_stack, get_type_stack, push_typelist)
2981         (follow_type_instance_flags, follow_types): Don't declare.
2982         * parse.c (type_stack): Remove global.
2983         (parse_exp_in_context): Update.
2984         (insert_into_type_stack, insert_type, push_type, push_type_int)
2985         (insert_type_address_space, pop_type, pop_type_int)
2986         (pop_typelist, pop_type_stack, append_type_stack)
2987         (push_type_stack, get_type_stack, push_typelist)
2988         (follow_type_instance_flags, follow_types): Remove (moved to
2989         type-stack.c).
2990         * f-exp.y (type_stack): New global.
2991         Update rules.
2992         (push_kind_type, f_parse): Update.
2993         * d-exp.y (type_stack): New global.
2994         Update rules.
2995         (d_parse): Update.
2996         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2997         Update rules.
2998         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2999         (HFILES_NO_SRCDIR): Add type-stack.h.
3000
3001 2019-04-04  Tom Tromey  <tom@tromey.com>
3002
3003         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3004         (rust_parser::convert_ast_to_expression, rust_parse)
3005         (rust_lex_test_completion, rust_lex_tests): Update.
3006         * parser-defs.h (struct expr_completion_state): New.
3007         (struct parser_state) <parser_state>: Add completion parameter.
3008         <mark_struct_expression, mark_completion_tag>: New methods.
3009         <parse_completion, m_completion_state>: New members.
3010         (prefixify_expression, null_post_parser): Update.
3011         (mark_struct_expression, mark_completion_tag): Don't declare.
3012         * parse.c (parse_completion, expout_last_struct)
3013         (expout_tag_completion_type, expout_completion_name): Remove
3014         globals.
3015         (parser_state::mark_struct_expression)
3016         (parser_state::mark_completion_tag): Now methods.
3017         (prefixify_expression): Add last_struct parameter.
3018         (prefixify_subexp): Likewise.
3019         (parse_exp_1): Update.
3020         (parse_exp_in_context): Add cstate parameter.  Update.
3021         (parse_expression_for_completion): Create an
3022         expr_completion_state.
3023         (null_post_parser): Add "completion" parameter.
3024         * p-exp.y: Update rules.
3025         (yylex): Update.
3026         * language.h (struct language_defn) <la_post_parser>: Add
3027         "completing" parameter.
3028         * go-exp.y: Update rules.
3029         (lex_one_token): Update.
3030         * expression.h (parse_completion): Don't declare.
3031         * d-exp.y: Update rules.
3032         (lex_one_token): Update rules.
3033         * c-exp.y: Update rules.
3034         (lex_one_token): Update.
3035         * ada-lang.c (resolve): Add "parse_completion" parameter.
3036         (resolve_subexp): Likewise.
3037         (ada_resolve_function): Likewise.
3038
3039 2019-04-04  Tom Tromey  <tom@tromey.com>
3040
3041         * parser-defs.h (struct parser_state) <start_arglist,
3042         end_arglist>: New methods.
3043         <arglist_len, m_funcall_chain>: New members.
3044         (arglist_len, start_arglist, end_arglist): Don't declare.
3045         * parse.c (arglist_len, funcall_chain): Remove global.
3046         (start_arglist, end_arglist): Remove functions.
3047         (parse_exp_in_context): Update.
3048         * p-exp.y: Update rules.
3049         * m2-exp.y: Update rules.
3050         * go-exp.y: Update rules.
3051         * f-exp.y: Update rules.
3052         * d-exp.y: Update rules.
3053         * c-exp.y: Update rules.
3054
3055 2019-04-04  Tom Tromey  <tom@tromey.com>
3056
3057         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3058         lex_operator, push_back>: New methods.
3059         Update all rules.
3060         (rust_parser::lex_hex, lex_escape): Rename and update.
3061         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3062         (rust_parser::lex_operator): Rename and update.
3063         (rust_parser::lex_number, rustyylex, rustyyerror)
3064         (rust_lex_test_init, rust_lex_test_sequence)
3065         (rust_lex_test_push_back, rust_lex_tests): Update.
3066         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3067         parameter.
3068         <lexptr, prev_lexptr>: New members.
3069         (lexptr, prev_lexptr): Don't declare.
3070         * parse.c (lexptr, prev_lexptr): Remove globals.
3071         (parse_exp_in_context): Update.
3072         * p-exp.y (yylex, yyerror): Update.
3073         * m2-exp.y (parse_number, yylex, yyerror): Update.
3074         * go-exp.y (lex_one_token, yyerror): Update.
3075         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3076         * d-exp.y (lex_one_token, yyerror): Update.
3077         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3078         (lex_one_token, yyerror): Update.
3079         * ada-lex.l (YY_INPUT): Update.
3080         (rewind_to_char): Update.
3081         * ada-exp.y (yyerror): Update.
3082
3083 2019-04-04  Tom Tromey  <tom@tromey.com>
3084
3085         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3086         * parser-defs.h (struct parser_state) <parser_state>: Add new
3087         parameter.
3088         <comma_terminates>: New member.
3089         (comma_terminates): Don't declare global.
3090         * parse.c (comma_terminates): Remove global.
3091         (parse_exp_in_context): Update.
3092         * p-exp.y (yylex): Update.
3093         * m2-exp.y (yylex): Update.
3094         * go-exp.y (lex_one_token): Update.
3095         * f-exp.y (yylex): Update.
3096         * d-exp.y (lex_one_token): Update.
3097         * c-exp.y (lex_one_token): Update.
3098         * ada-lex.l: Update.
3099
3100 2019-04-04  Tom Tromey  <tom@tromey.com>
3101
3102         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3103         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3104         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3105         * parser-defs.h (paren_depth): Don't declare.
3106         * parse.c (paren_depth): Remove global.
3107         (parse_exp_in_context): Update.
3108         * p-exp.y (paren_depth): New global.
3109         (pascal_parse): Initialize it.
3110         * m2-exp.y (paren_depth): New global.
3111         (m2_parse): Initialize it.
3112         * go-exp.y (paren_depth): New global.
3113         (go_parse): Initialize it.
3114         * f-exp.y (paren_depth): New global.
3115         (f_parse): Initialize it.
3116         * d-exp.y (paren_depth): New global.
3117         (d_parse): Initialize it.
3118         * c-exp.y (paren_depth): New global.
3119         (c_parse): Initialize it.
3120         * ada-lex.l (paren_depth): New global.
3121         (lexer_init): Initialize it.
3122
3123 2019-04-04  Tom Tromey  <tom@tromey.com>
3124
3125         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3126         (rust_parser::convert_ast_to_type)
3127         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3128         * parser-defs.h (struct parser_state) <parser_state>: Add
3129         parameters.  Initialize new members.
3130         <expression_context_block, expression_context_pc>: New members.
3131         * parse.c (expression_context_block, expression_context_pc):
3132         Remove globals.
3133         (parse_exp_in_context): Update.
3134         * p-exp.y: Update all rules.
3135         (yylex): Update.
3136         * m2-exp.y: Update all rules.
3137         (yylex): Update.
3138         * go-exp.y (yylex): Update.
3139         * f-exp.y (yylex): Update.
3140         * d-exp.y: Update all rules.
3141         (yylex): Update.
3142         * c-exp.y: Update all rules.
3143         (lex_one_token, classify_name, yylex, c_parse): Update.
3144         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3145
3146 2019-04-04  Tom Tromey  <tom@tromey.com>
3147
3148         * gdbarch.h, gdbarch.c: Rebuild.
3149         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3150         * stap-probe.h:
3151         (struct stap_parse_info): Replace "parser_state" with
3152         "expr_builder".
3153         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3154         (parser_state): New class.
3155         * parse.c (expr_builder): Rename.
3156         (expr_builder::release): Rename.
3157         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3158         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3159         (write_exp_elt_longcst, write_exp_elt_floatcst)
3160         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3161         (write_exp_string_vector, write_exp_bitstring)
3162         (write_exp_msymbol, mark_struct_expression)
3163         (write_dollar_variable)
3164         (insert_type_address_space, increase_expout_size): Replace
3165         "parser_state" with "expr_builder".
3166         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3167         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3168         "parser_state" with "expr_builder".
3169
3170 2019-04-04  Tom Tromey  <tom@tromey.com>
3171
3172         * rust-exp.y: Replace "parse_language" with method call.
3173         * p-exp.y:
3174         (yylex): Replace "parse_language" with method call.
3175         * m2-exp.y:
3176         (yylex): Replace "parse_language" with method call.
3177         * go-exp.y (classify_name): Replace "parse_language" with method
3178         call.
3179         * f-exp.y (yylex): Replace "parse_language" with method call.
3180         * d-exp.y (lex_one_token): Replace "parse_language" with method
3181         call.
3182         * c-exp.y:
3183         (lex_one_token, classify_name, yylex): Replace "parse_language"
3184         with method call.
3185         * ada-exp.y (find_primitive_type, type_char)
3186         (type_system_address): Replace "parse_language" with method call.
3187
3188 2019-04-04  Tom Tromey  <tom@tromey.com>
3189
3190         * rust-exp.y: Replace "parse_gdbarch" with method call.
3191         * parse.c (write_dollar_variable, insert_type_address_space):
3192         Replace "parse_gdbarch" with method call.
3193         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3194         call.
3195         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3196         call.
3197         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3198         "parse_gdbarch" with method call.
3199         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3200         with method call.
3201         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3202         "parse_gdbarch" with method call.
3203         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3204         "parse_gdbarch" with method call.
3205         * c-exp.y (parse_type, parse_number, classify_name): Replace
3206         "parse_gdbarch" with method call.
3207         * ada-lex.l: Replace "parse_gdbarch" with method call.
3208         * ada-exp.y (parse_type, find_primitive_type, type_char)
3209         (type_system_address): Replace "parse_gdbarch" with method call.
3210
3211 2019-04-04  Tom Tromey  <tom@tromey.com>
3212
3213         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3214         * stap-probe.c (stap_parse_argument): Update.
3215         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3216         initial_size parameter.
3217         * rust-exp.y (rust_lex_tests): Update.
3218         * parse.c (parser_state): Update.
3219         (parse_exp_in_context): Update.
3220         * parser-defs.h (struct parser_state) <parser_state>: Remove
3221         "initial_size" parameter.
3222
3223 2019-04-04  Tom Tromey  <tom@tromey.com>
3224
3225         * parser-defs.h (increase_expout_size): Don't declare.
3226         * parse.c (increase_expout_size): Now static.
3227
3228 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3229
3230         * gnu-nat.c (gnu_nat_target::wait): Fix
3231         target_waitstatus_to_string call.
3232
3233 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3234
3235         * eval.c (evaluate_subexp_standard): Handle internal functions
3236         during Fortran function call handling.
3237
3238 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3239
3240         * NEWS: Mention new internal functions.
3241         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3242         (read_base_type): Use dwarf2_init_complex_target_type.
3243         * value.c (creal_internal_fn): New function.
3244         (cimag_internal_fn): New function.
3245         (_initialize_values): Register new internal functions.
3246
3247 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3248
3249         * infrun.c (stop_all_threads): If debug_infrun, always
3250         trace the wait status after wait_one, using
3251         target_waitstatus_to_string and target_pid_to_str.
3252         (handle_inferior_event): Replace various trace of
3253         wait status kind by a single trace.
3254         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3255         wait status kind image by target_waitstatus_to_string.
3256         * target/waitstatus.c (target_waitstatus_to_string): Fix
3257         obsolete comment.
3258
3259 2019-04-01  Tom Tromey  <tromey@adacore.com>
3260
3261         PR symtab/23331:
3262         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3263
3264 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3265             Pedro Alves  <palves@redhat.com>
3266
3267         * top.c (quit_force): Call 'finalize_values'.
3268         * value.c (finalize_values): New function.
3269         * value.h (finalize_values): Declare.
3270
3271 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3272
3273         * NEWS: Announce $_gdb_major and $_gdb_minor.
3274
3275         * top.c (init_gdb_version_vars): New function.
3276         (gdb_init): Call init_gdb_version_vars.
3277
3278 2019-03-29  Tom Tromey  <tromey@adacore.com>
3279
3280         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3281         help text.  Remove dead code.
3282
3283 2019-03-29  Keith Seitz  <keiths@redhat.com>
3284
3285         From Siddhesh Poyarekar:
3286         * f-lang.h (f77_get_upperbound): Return LONGEST.
3287         (f77_get_lowerbound): Likewise.
3288         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3289         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3290         print them.
3291         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3292         plongest to format print it.
3293         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3294         (f77_get_upperbound): Likewise.
3295         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3296         LOWER_BOUND to LONGEST.
3297         (f77_create_arrayprint_offset_tbl): Likewise.
3298
3299 2019-03-29  Keith Seitz  <keiths@redhat.com>
3300
3301         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3302         %s/pulongest for TYPE_LENGTH instead of %d in format
3303         strings.
3304         * ada-typerint.c (ada_print_type): Likewise.
3305         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3306         * compile/compile-c-support.c (generate_register_struct): Likewise.
3307         * gdbtypes.c (recursive_dump_type): Likewise.
3308         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3309         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3310         instead of %d in format strings.
3311         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3312         to std::min to ULONGEST.
3313         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3314         instead of %d in format strings.
3315         * tracepoint.c (info_scope_command): Likewise.
3316         * typeprint.c (print_offset_data::update)
3317         (print_offset_data::finish): Likewise.
3318         * xtensa-tdep.c (xtensa_store_return_value)
3319         (xtensa_push_dummy_call): Likewise.
3320
3321 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3322
3323         * windows-nat.c (display_selector): Fixed format specifications
3324         for 64-bit Cygwin.
3325
3326 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3327
3328         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3329
3330 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3331
3332         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3333         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3334         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3335         (nios2_linux_init_abi): Install it.
3336
3337 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3338
3339         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3340
3341 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3342
3343         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3344
3345 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3346             Tom Tromey  <tromey@adacore.com>
3347
3348         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3349
3350 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3351
3352         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3353         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3354         method to compute the bounds of range types. Also print "[evaluated]"
3355         if the bounds' values come from a dynamic evaluation.
3356
3357 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3358
3359         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3360         whitespace when pretty printing is on.
3361
3362 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3363
3364         * ppc-linux-nat.c: Add include.
3365
3366 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3367
3368         * NEWS: Mention AArch64 Pointer Authentication.
3369
3370 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3371
3372         * arm-linux-nat.c: Add include.
3373
3374 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3375
3376         * source-cache.c (source_cache::get_source_lines): Re-read
3377         fullname after calling open_source_file.
3378
3379 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3380
3381         * NEWS: Mention TLS support for FreeBSD.
3382
3383 2019-03-25  Tom Tromey  <tromey@adacore.com>
3384
3385         * minsyms.c (BUNCH_SIZE): Update comment.
3386         (~minimal_symbol_reader): Remove old comment.
3387         (compact_minimal_symbols): Update comment.
3388         (minimal_symbol_reader::install): Remove old comment.  Update
3389         other comments.
3390
3391 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3392
3393         * s390-linux-nat.c: Add include.
3394
3395 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3396
3397         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3398         Call linux_get_hwcap.
3399         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3400         Likewise.
3401         (aarch64_linux_get_hwcap): Remove function.
3402         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3403         declaration.
3404         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3405         linux_get_hwcap.
3406         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3407         * linux-tdep.c (linux_get_hwcap): Add function.
3408         (linux_get_hwcap2): Likewise.
3409         * linux-tdep.h (linux_get_hwcap): Add declaration.
3410         (linux_get_hwcap2): Likewise.
3411         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3412         (ppc_linux_get_hwcap2): Likewise.
3413         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3414         linux_get_hwcap.
3415         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3416         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3417         (ppc_linux_nat_target::read_description): Likewise.
3418         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3419         * s390-linux-nat.c: Likewise.
3420         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3421
3422 2019-03-24  Tom Tromey  <tom@tromey.com>
3423
3424         * ada-lang.c (standard_lookup): Simplify initialization.
3425         (ada_lookup_symbol_nonlocal): Simplify return.
3426         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3427         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3428         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3429         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3430         initialization.
3431         * solib.c (solib_global_lookup): Simplify.
3432         * symtab.c (null_block_symbol): Remove.
3433         (symbol_cache_lookup): Simplify returns.
3434         (lookup_language_this): Simplify returns.
3435         (lookup_symbol_aux): Simplify return.
3436         (lookup_local_symbol): Simplify returns.
3437         (lookup_global_symbol_from_objfile): Simplify return.
3438         (lookup_symbol_in_objfile_symtabs)
3439         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3440         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3441         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3442         * cp-namespace.c (cp_lookup_bare_symbol)
3443         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3444         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3445         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3446         (cp_lookup_symbol_via_imports): Simplify initialization.
3447         (find_symbol_in_baseclass): Likewise.
3448         * symtab.h (null_block_symbol): Remove.
3449         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3450         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3451         (d_lookup_symbol_module): Likewise.
3452         (find_symbol_in_baseclass): Simplify initialization.
3453
3454 2019-03-24  Tom Tromey  <tom@tromey.com>
3455
3456         * expression.h: Don't include symtab.h.
3457         (struct block): Forward declare.
3458
3459 2019-03-24  Tom Tromey  <tom@tromey.com>
3460
3461         * c-exp.y (typebase): Remove casts.
3462         * gdbtypes.c (lookup_unsigned_typename, )
3463         (lookup_signed_typename): Remove cast.
3464         * eval.c (parse_to_comma_and_eval): Remove cast.
3465         * parse.c (write_dollar_variable): Remove cast.
3466         * block.h (struct block) <superblock>: Now const.
3467         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3468         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3469         (map_block): Make "block" const.
3470         * symfile.h (struct quick_symbol_functions)
3471         <map_matching_symbols>: Constify block argument to "callback".
3472         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3473         const.
3474         (find_pc_sect_compunit_symtab): Make "b" const.
3475         (find_symbol_at_address): Likewise.
3476         (search_symbols): Likewise.
3477         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3478         (dw2_debug_names_lookup_symbol): Likewise.
3479         (dw2_map_matching_symbols): Update.
3480         * p-valprint.c (pascal_val_print): Remove "block".
3481         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3482         (aux_add_nonlocal_symbols): Make "block" const.
3483         (resolve_subexp): Remove cast.
3484         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3485         const.
3486         (iterate_over_file_blocks): Likewise.
3487         * f-exp.y (%union) <bval>: Remove.
3488         * coffread.c (patch_opaque_types): Make "b" const.
3489         * spu-tdep.c (spu_catch_start): Make "block" const.
3490         * c-valprint.c (print_unpacked_pointer): Remove "block".
3491         * symmisc.c (dump_symtab_1): Make "b" const.
3492         (block_depth): Make "block" const.
3493         * d-exp.y (%union) <bval>: Remove.
3494         * cp-support.h (cp_lookup_rtti_type): Update.
3495         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3496         * psymtab.c (psym_lookup_symbol): Make "block" const.
3497         (maintenance_check_psymtabs): Make "b" const.
3498         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3499         (enumerate_locals, enumerate_args): Update.
3500         * python/py-symtab.c (stpy_global_block): Make "block" const.
3501         (stpy_static_block): Likewise.
3502         * inline-frame.c (block_starting_point_at): Make "new_block"
3503         const.
3504         * block.c (find_block_in_blockvector): Make return type const.
3505         (blockvector_for_pc_sect): Make "b" const.
3506         (find_block_in_blockvector): Make "b" const.
3507
3508 2019-03-23  Tom Tromey  <tom@tromey.com>
3509
3510         * varobj.c (varobj_create): Update.
3511         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3512         * printcmd.c (display_command, do_one_display): Don't reset
3513         innermost_block.
3514         * parser-defs.h (enum innermost_block_tracker_type): Move to
3515         expression.h.
3516         (innermost_block): Update comment.
3517         * parse.c (parse_exp_1): Add tracker_types parameter.
3518         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3519         tracker_types parameter.  Reset innermost_block.
3520         (parse_exp_in_context): Remove.
3521         (parse_expression_for_completion): Update.
3522         * objfiles.c (~objfile): Don't reset expression_context_block or
3523         innermost_block.
3524         * expression.h (enum innermost_block_tracker_type): Move from
3525         parser-defs.h.
3526         (parse_exp_1): Add tracker_types parameter.
3527         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3528         reset innermost_block.
3529
3530 2019-03-23  Tom Tromey  <tom@tromey.com>
3531
3532         * objfiles.h: Include bcache.h.
3533
3534 2019-03-23  Tom Tromey  <tom@tromey.com>
3535
3536         * linespec.c (get_current_search_block): Use
3537         scoped_restore_current_language.
3538         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3539
3540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3541             Jiong Wang  <jiong.wang@arm.com>
3542
3543         * aarch64-linux-tdep.c
3544         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3545         section.
3546         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3547
3548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3549             Jiong Wang  <jiong.wang@arm.com>
3550
3551         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3552         instructions.
3553         (aarch64_analyze_prologue_test): Add PACIASP test.
3554         (aarch64_prologue_prev_register): Unmask PC value.
3555
3556 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3557             Jiong Wang  <jiong.wang@arm.com>
3558
3559         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3560         (aarch64_dwarf2_prev_register): Unmask PC value.
3561         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3562         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3563         DW_CFA_AARCH64_negate_ra_state.
3564         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3565
3566 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3567             Jiong Wang  <jiong.wang@arm.com>
3568
3569         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3570         registers.
3571         (aarch64_pseudo_register_name): Likewise.
3572         (aarch64_pseudo_register_type): Likewise.
3573         (aarch64_pseudo_register_reggroup_p): Likewise.
3574         (aarch64_gdbarch_init): Add pauth registers.
3575         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3576         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3577         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3578         (struct gdbarch_tdep): Add regnum for ra_state.
3579
3580 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3581             Jiong Wang  <jiong.wang@arm.com>
3582
3583         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3584
3585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3586             Jiong Wang  <jiong.wang@arm.com>
3587
3588         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3589         function.
3590         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3591         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3592         (aarch64_gdbarch_init): Add puth registers.
3593         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3594         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3595         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3596
3597 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3598             Jiong Wang  <jiong.wang@arm.com>
3599
3600         * aarch64-linux-nat.c
3601         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3602         * aarch64-linux-tdep.c
3603         (aarch64_linux_core_read_description): Likewise.
3604         (aarch64_linux_get_hwcap): New function.
3605         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3606         (aarch64_linux_get_hwcap): New declaration.
3607
3608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3609             Jiong Wang  <jiong.wang@arm.com>
3610
3611         * aarch64-linux-nat.c
3612         (aarch64_linux_nat_target::read_description): Add pauth param.
3613         * aarch64-linux-tdep.c
3614         (aarch64_linux_core_read_description): Likewise.
3615         * aarch64-tdep.c (struct target_desc): Add in pauth.
3616         (aarch64_read_description): Add pauth param.
3617         (aarch64_gdbarch_init): Likewise.
3618         * aarch64-tdep.h (aarch64_read_description): Likewise.
3619         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3620         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3621         * features/Makefile: Add new files.
3622         * features/aarch64-pauth.c: New file.
3623         * features/aarch64-pauth.xml: New file.
3624
3625 2019-03-20  Tom Tromey  <tromey@adacore.com>
3626
3627         * infrun.c (handle_inferior_event): Rename from
3628         handle_inferior_event_1.  Create a scoped_value_mark.
3629         (handle_inferior_event): Remove.
3630
3631 2019-03-19  Tom Tromey  <tromey@adacore.com>
3632
3633         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3634         * infrun.h (print_stop_event): Add "displays" parameter.
3635         * infrun.c (print_stop_event): Add "displays" parameter.
3636
3637 2019-03-19  Pedro Alves  <palves@redhat.com>
3638
3639         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3640         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3641         to -1.  Fix TABs vs spaces.
3642         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3643         * tui/tui-out.h (tui_ui_out) Add intro comments.
3644         <m_line, m_start_of_line>: In-class initialize, and add describing
3645         comment.
3646
3647 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3648
3649         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3650         variable names.
3651         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3652
3653 2019-03-18  Pedro Alves  <palves@redhat.com>
3654             Eli Zaretskii <eliz@gnu.org>
3655
3656         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3657         m_line and m_start_of_line.
3658
3659 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3660
3661         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3662         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3663         it returns a newline.  This fixes a regression in TU mode, whereby
3664         the next line is output on the same screen line as the user input.
3665
3666 2019-03-18  Tom Tromey  <tromey@adacore.com>
3667
3668         * minsyms.c (minimal_symbol_reader::install): Remove call to
3669         obstack_blank.
3670
3671 2019-03-18  Pedro Alves  <palves@redhat.com>
3672
3673         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3674         New globals.
3675         (apply_style): New, factored out from ...
3676         (apply_ansi_escape): ... this.  Handle reverse video mode.
3677         (tui_set_reverse_mode): New function.
3678         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3679         * tui/tui-winsource.c (tui_show_source_line): Use
3680         tui_set_reverse_mode instead of setting A_STANDOUT.
3681         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3682         New setter methods.
3683
3684 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3685
3686         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3687         Handle tabs.
3688
3689 2019-03-18  Tom Tromey  <tromey@adacore.com>
3690
3691         * ada-lang.c (empty_array): Add "high" parameter.
3692         (ada_evaluate_subexp): Update.
3693
3694 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3695
3696         * unittests/string_view-selftests.c: Define
3697         _initialize_string_view_selftests unconditionally.
3698
3699 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3700
3701         PR gdb/24350
3702         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3703
3704 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3705
3706         PR gdb/24351
3707         * windows-nat.c (display_selector): Fix format specifiers.
3708
3709 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3710
3711         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3712         tui_refill_source_window instead of tui_refresh_win, to update the
3713         current execution line.  This fixes redisplay of the current line
3714         when stepping through the code with "next" or "step".
3715
3716 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3717
3718         * source-cache.c (source_cache::get_source_lines): Call
3719         find_source_lines to initialize s->nlines.  This fixes vertical
3720         scrolling of TUI source window when the DOWN arrow is pressed.
3721
3722 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3723
3724         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3725         linux-thread-db.c (_initialize_thread_db): Likewise.
3726
3727 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3728
3729         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3730         wclrtoeol in tui_show_source_line".  This reverts changes made in
3731         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3732
3733 2019-03-15  Tom Tromey  <tom@tromey.com>
3734
3735         * symtab.h (struct minimal_symbol): Derive from
3736         general_symbol_info.
3737         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3738         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3739         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3740         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3741         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3742         (MSYMBOL_SEARCH_NAME): Update.
3743         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3744         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3745         * minsyms.c (minimal_symbol_reader::record_full): Update.
3746
3747 2019-03-15  Tom Tromey  <tom@tromey.com>
3748
3749         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3750
3751 2019-03-15  Tom Tromey  <tom@tromey.com>
3752
3753         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3754         unique_xmalloc_ptr.
3755         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3756         Update.
3757         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3758         (build_minimal_symbol_hash_tables)
3759         (minimal_symbol_reader::install): Update.
3760
3761 2019-03-15  Tom Tromey  <tom@tromey.com>
3762
3763         * symtab.c (create_demangled_names_hash): Update.
3764         (symbol_set_names): Update.
3765         * objfiles.h (struct objfile_per_bfd_storage)
3766         <demangled_names_hash>: Now an htab_up.
3767         * objfiles.c (objfile_per_bfd_storage): Simplify.
3768
3769 2019-03-15  Tom Tromey  <tom@tromey.com>
3770
3771         * objfiles.h (struct objfile_per_bfd_storage): Declare
3772         destructor.
3773         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3774         New.
3775         (get_objfile_bfd_data): Use new.  Don't initialize
3776         language_of_main.
3777         (free_objfile_per_bfd_storage): Remove.
3778         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3779
3780 2019-03-15  Tom Tromey  <tom@tromey.com>
3781
3782         * symfile.c (reread_symbols): Update.
3783         * objfiles.c (objfile::objfile): Update.
3784         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3785         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3786         comment.
3787         (minimal_symbol_reader::install): Update.
3788         (terminate_minimal_symbol_table): Remove.
3789         * jit.c (jit_object_close_impl): Update.
3790
3791 2019-03-15  Tom Tromey  <tom@tromey.com>
3792
3793         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3794         initializations.
3795
3796 2019-03-15  Tom Tromey  <tom@tromey.com>
3797
3798         * objfiles.h (struct objfile_per_bfd_storage)
3799         <demangled_hash_languages>: Now a bitset.
3800         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3801         (lookup_minimal_symbol): Update.
3802
3803 2019-03-15  Tom Tromey  <tom@tromey.com>
3804
3805         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3806         Don't return the symbol.
3807         * coffread.c (record_minimal_symbol): Use record_full.
3808
3809 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3810
3811         The MS-Windows port of ncurses fails to switch to a color pair if
3812         one or both of the colors are the implicit default colors.  This
3813         change records the default colors when TUI is initialized, and
3814         then specifies them explicitly when a color pair uses the default
3815         colors.  This allows color styling in TUI mode on MS-Windows.
3816
3817         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3818         ncurses_norm_attr.
3819         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3820         colors in ncurses_norm_attr.
3821         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3822         "none", replace it with the default color recorded in
3823         ncurses_norm_attr.
3824
3825 2019-03-14  Tom Tromey  <tromey@adacore.com>
3826
3827         * source-cache.h (class source_cache) <get_source_lines>: Return
3828         std::string.
3829         * source-cache.c (source_cache::extract_lines): Handle case where
3830         first_pos==npos.  Return std::string.
3831         (source_cache::get_source_lines): Update.
3832
3833 2019-03-14  Tom Tromey  <tromey@adacore.com>
3834
3835         * NEWS: Add item for "style sources" commands.
3836         * source-cache.c (source_cache::get_source_lines): Check
3837         source_styling.
3838         * cli/cli-style.c (source_styling): New global.
3839         (_initialize_cli_style): Add "style sources" commands.
3840         (show_style_sources): New function.
3841         * cli/cli-style.h (source_styling): Declare.
3842
3843 2019-03-14  Pedro Alves  <palves@redhat.com>
3844             Tom Tromey  <tromey@adacore.com>
3845
3846         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3847         * tui/tui-winsource.c (tui_refill_source_window): New function,
3848         from...
3849         (tui_horizontal_source_scroll): ... here.  Move some logic.
3850         * cli/cli-style.c (set_style_enabled): Notify new observable.
3851         * tui/tui-hooks.c (tui_redisplay_source): New function.
3852         (tui_attach_detach_observers): Attach or detach
3853         tui_redisplay_source.
3854         * observable.h (source_styling_changed): New observable.
3855         * observable.c: Define source_styling_changed observable.
3856
3857 2019-03-13  Tom Tromey  <tromey@adacore.com>
3858
3859         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3860         (i386_gnu_nat_target::store_registers): Update.
3861         * target-debug.h (target_debug_print_std_string): New macro.
3862         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3863         * windows-tdep.c (display_one_tib): Update.
3864         * tui/tui-stack.c (tui_make_status_line): Update.
3865         * top.c (print_inferior_quit_action): Update.
3866         * thread.c (thr_try_catch_cmd): Update.
3867         (add_thread_with_info): Update.
3868         (thread_target_id_str): Update.
3869         (thr_try_catch_cmd): Update.
3870         (thread_command): Update.
3871         (thread_find_command): Update.
3872         * record-btrace.c (record_btrace_target::info_record)
3873         (record_btrace_resume_thread, record_btrace_target::resume)
3874         (record_btrace_cancel_resume, record_btrace_step_thread)
3875         (record_btrace_target::wait, record_btrace_target::wait)
3876         (record_btrace_target::wait, record_btrace_target::stop): Update.
3877         * progspace.c (print_program_space): Update.
3878         * process-stratum-target.c
3879         (process_stratum_target::thread_address_space): Update.
3880         * linux-fork.c (linux_fork_mourn_inferior)
3881         (detach_checkpoint_command, info_checkpoints_command)
3882         (linux_fork_context): Update.
3883         (linux_fork_detach): Update.
3884         (class scoped_switch_fork_info): Update.
3885         (delete_checkpoint_command): Update.
3886         * infrun.c (follow_fork_inferior): Update.
3887         (follow_fork_inferior): Update.
3888         (proceed_after_vfork_done): Update.
3889         (handle_vfork_child_exec_or_exit): Update.
3890         (follow_exec): Update.
3891         (displaced_step_prepare_throw): Update.
3892         (displaced_step_restore): Update.
3893         (start_step_over): Update.
3894         (resume_1): Update.
3895         (clear_proceed_status_thread): Update.
3896         (proceed): Update.
3897         (print_target_wait_results): Update.
3898         (do_target_wait): Update.
3899         (context_switch): Update.
3900         (stop_all_threads): Update.
3901         (restart_threads): Update.
3902         (finish_step_over): Update.
3903         (handle_signal_stop): Update.
3904         (switch_back_to_stepped_thread): Update.
3905         (keep_going_pass_signal): Update.
3906         (print_exited_reason): Update.
3907         (normal_stop): Update.
3908         * inferior.c (inferior_pid_to_str): Change return type.
3909         (print_selected_inferior): Update.
3910         (add_inferior): Update.
3911         (detach_inferior): Update.
3912         * dummy-frame.c (fprint_dummy_frames): Update.
3913         * dcache.c (dcache_info_1): Update.
3914         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3915         (btrace_fetch, btrace_clear): Update.
3916         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3917         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3918         type.
3919         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3920         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3921         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3922         * gdbarch.c, gdbarch.h: Rebuild.
3923         * gdbarch.sh (core_pid_to_str): Change return type.
3924         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3925         return type.
3926         (windows_nat_target::pid_to_str): Change return type.
3927         (windows_delete_thread): Update.
3928         (windows_nat_target::attach): Update.
3929         (windows_nat_target::files_info): Update.
3930         * target-delegates.c: Rebuild.
3931         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3932         return type.
3933         (sol_thread_target::pid_to_str): Change return type.
3934         * remote.c (class remote_target) <pid_to_str>: Change return
3935         type.
3936         (remote_target::pid_to_str): Change return type.
3937         (extended_remote_target::attach, remote_target::remote_stop_ns)
3938         (remote_target::remote_notif_remove_queued_reply)
3939         (remote_target::push_stop_reply, remote_target::disable_btrace):
3940         Update.
3941         (extended_remote_target::attach): Update.
3942         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3943         type.
3944         (gdbsim_target::pid_to_str): Change return type.
3945         * ravenscar-thread.c (struct ravenscar_thread_target)
3946         <pid_to_str>: Change return type.
3947         (ravenscar_thread_target::pid_to_str): Change return type.
3948         * procfs.c (class procfs_target) <pid_to_str>: Change return
3949         type.
3950         (procfs_target::pid_to_str): Change return type.
3951         (procfs_target::attach): Update.
3952         (procfs_target::detach): Update.
3953         (procfs_target::fetch_registers): Update.
3954         (procfs_target::store_registers): Update.
3955         (procfs_target::wait): Update.
3956         (procfs_target::files_info): Update.
3957         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3958         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3959         return type.
3960         (nto_procfs_target::pid_to_str): Change return type.
3961         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3962         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3963         return type.
3964         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3965         (exit_lwp): Update.
3966         (attach_proc_task_lwp_callback, get_detach_signal)
3967         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3968         (linux_nat_target::resume, wait_lwp, stop_callback)
3969         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3970         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3971         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3972         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3973         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3974         type.
3975         (inf_ptrace_target::attach): Update.
3976         (inf_ptrace_target::files_info): Update.
3977         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3978         type.
3979         (go32_nat_target::pid_to_str): Change return type.
3980         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3981         (gnu_nat_target::wait): Update.
3982         (gnu_nat_target::wait): Update.
3983         (gnu_nat_target::resume): Update.
3984         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3985         (fbsd_nat_target::wait): Update.
3986         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3987         type.
3988         (darwin_nat_target::attach): Update.
3989         * corelow.c (class core_target) <pid_to_str>: Change return type.
3990         (core_target::pid_to_str): Change return type.
3991         * target.c (normal_pid_to_str): Change return type.
3992         (default_pid_to_str): Likewise.
3993         (target_pid_to_str): Change return type.
3994         (target_translate_tls_address): Update.
3995         (target_announce_detach): Update.
3996         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3997         return type.
3998         (bsd_uthread_target::pid_to_str): Change return type.
3999         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4000         type.
4001         (bsd_kvm_target::pid_to_str): Change return type.
4002         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4003         return type.
4004         (aix_thread_target::pid_to_str): Change return type.
4005         * target.h (struct target_ops) <pid_to_str>: Change return type.
4006         (target_pid_to_str, normal_pid_to_str): Likewise.
4007         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4008         type.
4009         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4010         type.
4011         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4012         return type.
4013         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4014         type.
4015         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4016         type.
4017         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4018         return type.
4019
4020 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4021
4022         * NEWS: Mention that the new default MI version is 3.  Mention
4023         changes to the output of commands and events that deal with
4024         multi-location breakpoints.
4025         * breakpoint.c: Include "mi/mi-out.h".
4026         (print_one_breakpoint): Change output syntax if using MI version
4027         >= 3.
4028         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4029         New.
4030         (mi_multi_location_breakpoint_output_fixed): New.
4031         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4032         (mi_cmd_fix_multi_location_breakpoint_output): New.
4033         (mi_multi_location_breakpoint_output_fixed): New.
4034         * mi/mi-cmds.c (mi_cmds): Register command
4035         -fix-multi-location-breakpoint-output.
4036         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4037         interpreter "mi".
4038
4039 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4040
4041         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4042         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4043         instantiate mi_ui_out based on interpreter name.
4044         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4045         * mi/mi-main.c (mi_load_progress): Likewise.
4046
4047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4048
4049         * NEWS: Combine separate "New targets" sections for 8.3.
4050
4051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4052
4053         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4054         (ppcfbsd_init_abi): Install gdbarch
4055         "fetch_tls_load_module_address" and "get_thread_local_address"
4056         methods.
4057
4058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4059
4060         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4061         (riscv_fbsd_init_abi): Install gdbarch
4062         "fetch_tls_load_module_address" and "get_thread_local_address"
4063         methods.
4064
4065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4066
4067         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4068         (i386fbsd_init_abi): Install gdbarch
4069         "fetch_tls_load_module_address" and "get_thread_local_address"
4070         methods.
4071
4072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4073
4074         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4075         (amd64fbsd_init_abi): Install gdbarch
4076         "fetch_tls_load_module_address" and "get_thread_local_address"
4077         methods.
4078
4079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4080
4081         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4082         (struct fbsd_pspace_data): New type.
4083         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4084         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4085         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4086         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4087         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4088
4089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4090
4091         * gdbtypes.c (lookup_struct_elt): New function.
4092         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4093         * gdbtypes.h (struct struct_elt): New type.
4094         (lookup_struct_elt): New prototype.
4095
4096 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4097
4098         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4099         remove disabled code block.
4100
4101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4102
4103         * gdbarch.sh (get_thread_local_address): New method.
4104         * gdbarch.h, gdbarch.c: Regenerate.
4105         * target.c (target_translate_tls_address): Use
4106         gdbarch_get_thread_local_address if present instead of
4107         target::get_thread_local_address.
4108
4109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4110
4111         * target.h (target::get_thread_local_address): Update comment.
4112
4113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4114
4115         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4116         objfile->separate_debug_objfile_backlink if not NULL.
4117
4118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4119
4120         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4121         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4122         (amd64bsd_store_inferior_registers): Likewise.
4123         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4124         Enable segment base registers.
4125         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4126         PT_GETFSBASE and PT_GETGSBASE.
4127         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4128         PT_SETGSBASE.
4129         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4130         segment base registers.
4131         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4132
4133 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4134
4135         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4136         Update calls to i386_target_description to add 'segments'
4137         parameter.
4138         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4139         add segment base registers.
4140         * arch/i386.c (i386_create_target_description): Add 'segments'
4141         parameter to enable segment base registers.
4142         * arch/i386.h (i386_create_target_description): Likewise.
4143         * features/i386/32bit-segments.xml: New file.
4144         * features/i386/32bit-segments.c: Generate.
4145         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4146         call to i386_target_description to add 'segments' parameter.
4147         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4148         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4149         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4150         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4151         if feature is present.
4152         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4153         Add 'segments' parameter to call to i386_target_description.
4154         (i386_target_description): Add 'segments' parameter to enable
4155         segment base registers.
4156         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4157         to call to i386_target_description.
4158         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4159         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4160         Define I386_NUM_REGS.
4161         (i386_target_description): Add 'segments' parameter to enable
4162         segment base registers.
4163
4164 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4165
4166         PR/24325
4167         * source-cache.c: #undef open and close, to avoid unresolved
4168         externals during linking.
4169
4170 2019-03-12  Tom Tromey  <tromey@adacore.com>
4171
4172         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4173         const.  Add initializers.
4174         (_initialize_remote): Don't initialize ptid globals.
4175
4176 2019-03-12  Pedro Alves  <palves@redhat.com>
4177
4178         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4179
4180 2019-03-12  Pedro Alves  <palves@redhat.com>
4181
4182         * cp-name-parser.y (main): Remove unused 'len' variable.
4183
4184 2019-03-12  Tom Tromey  <tromey@adacore.com>
4185
4186         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4187         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4188
4189 2019-03-12  Tom Tromey  <tromey@adacore.com>
4190
4191         * linux-nat.c (iterate_over_lwps): Update.
4192         (stop_callback): Remove parameter.
4193         (stop_wait_callback, detach_callback, resume_set_callback)
4194         (select_singlestep_lwp_callback, set_ignore_sigint)
4195         (status_callback, resumed_callback, resume_clear_callback)
4196         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4197         data parameter.
4198         (linux_nat_target::detach, linux_nat_target::resume)
4199         (linux_stop_and_wait_all_lwps, select_event_lwp)
4200         (linux_nat_filter_event, linux_nat_wait_1)
4201         (linux_nat_target::kill, linux_nat_target::stop)
4202         (linux_nat_target::stop): Update.
4203         (linux_nat_resume_callback): Change type.
4204         (resume_stopped_resumed_lwps, count_events_callback)
4205         (select_event_lwp_callback): Likewise.
4206         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4207         * arm-linux-nat.c (struct update_registers_data): Remove.
4208         (update_registers_callback): Change type.
4209         (arm_linux_insert_hw_breakpoint1): Update.
4210         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4211         parameter.
4212         (x86_linux_dr_set_addr): Update.
4213         (x86_linux_dr_set_control): Update.
4214         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4215         (iterate_over_lwps): Use gdb::function_view.
4216         * nat/aarch64-linux-hw-point.c (struct
4217         aarch64_dr_update_callback_param): Remove.
4218         (debug_reg_change_callback): Change type.
4219         (aarch64_notify_debug_reg_change): Update.
4220         * s390-linux-nat.c (s390_refresh_per_info): Update.
4221
4222 2019-03-11  Tom Tromey  <tromey@adacore.com>
4223
4224         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4225         redundant assignment to "this_cu".
4226
4227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4228
4229         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4230
4231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4232
4233         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4234         from...
4235         (rank_one_type): ... this.
4236
4237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4238
4239         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4240         from...
4241         (rank_one_type): ... this.
4242
4243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4244
4245         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4246         from...
4247         (rank_one_type): ... this.
4248
4249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4250
4251         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4252         from...
4253         (rank_one_type): ... this.
4254
4255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4256
4257         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4258         from...
4259         (rank_one_type): ... this.
4260
4261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4262
4263         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4264         from...
4265         (rank_one_type): ... this.
4266
4267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4268
4269         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4270         from...
4271         (rank_one_type): ... this.
4272
4273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4274
4275         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4276         from...
4277         (rank_one_type): ... this.
4278
4279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4280
4281         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4282         from...
4283         (rank_one_type): ... this.
4284
4285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4286
4287         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4288         from...
4289         (rank_one_type): ... this.
4290
4291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4292
4293         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4294         from...
4295         (rank_one_type): ... this.
4296
4297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4298
4299         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4300         from...
4301         (rank_one_type): ... this.
4302
4303 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4304
4305         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4306         inferior-events' shows the example events.
4307
4308 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4309
4310         Support styling on native MS-Windows console
4311
4312         PR/24315
4313         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4314         on MS-Windows if $TERM is not defined.
4315
4316         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4317
4318         * posix-hdep.c (gdb_console_fputs):
4319         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4320         functions.
4321         * ui-file.h (gdb_console_fputs): Add prototype.
4322
4323         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4324         back to fputs only if the former returns zero.
4325
4326 2019-03-07  Tom Tromey  <tom@tromey.com>
4327
4328         * symmisc.c (print_symbol_bcache_statistics): Update.
4329         (print_objfile_statistics): Update.
4330         * symfile.c (allocate_symtab): Update.
4331         * stabsread.c: Don't include bcache.h.
4332         * psymtab.h (struct psymbol_bcache): Don't declare.
4333         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4334         (psymbol_bcache_init, psymbol_bcache_free)
4335         (psymbol_bcache_get_bcache): Don't declare.
4336         * psymtab.c (struct psymbol_bcache): Remove.
4337         (psymtab_storage::psymtab_storage): Update.
4338         (psymtab_storage::~psymtab_storage): Update.
4339         (psymbol_bcache_init, psymbol_bcache_free)
4340         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4341         (add_psymbol_to_bcache): Update.
4342         (allocate_psymtab): Update.
4343         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4344         macro_cache>: No longer pointers.
4345         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4346         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4347         * macrotab.c (macro_bcache): Update.
4348         * macroexp.c: Don't include bcache.h.
4349         * gdbtypes.c (check_types_worklist): Update.
4350         (types_deeply_equal): Remove TRY/CATCH.  Update.
4351         * elfread.c (elf_symtab_read): Update.
4352         * dwarf2read.c: Don't include bcache.h.
4353         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4354         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4355         (print_bcache_statistics, bcache_memory_used): Don't declare.
4356         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4357         methods.  Rename all data members.
4358         * bcache.c (struct bcache): Move to bcache.h.
4359         (bcache::expand_hash_table): Rename from expand_hash_table.
4360         (bcache): Remove.
4361         (bcache::insert): Rename from bcache_full.
4362         (bcache::compare): Rename from bcache_compare.
4363         (bcache_xmalloc): Remove.
4364         (bcache::~bcache): Rename from bcache_xfree.
4365         (bcache::print_statistics): Rename from print_bcache_statistics.
4366         (bcache::memory_used): Rename from bcache_memory_used.
4367
4368 2019-03-07  Pedro Alves  <palves@redhat.com>
4369
4370         * infrun.c (normal_stop): Also check for
4371         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4372
4373 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * f-lang.c (value_from_host_double): Moved to...
4376         * value.c (value_from_host_double): ...here.
4377         * value.h (value_from_host_double): Declare.
4378         * guile/scm-math.c (vlscm_convert_typed_number): Use
4379         value_from_host_double.
4380         (vlscm_convert_number): Likewise.
4381         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4382         * python/py-value.c (convert_value_from_python): Likewise.
4383
4384 2019-03-06  Tom Tromey  <tom@tromey.com>
4385
4386         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4387
4388 2019-03-06  Tom Tromey  <tom@tromey.com>
4389
4390         * utils.h (free_current_contents): Don't declare.
4391         * utils.c (free_current_contents): Remove.
4392
4393 2019-03-06  Tom Tromey  <tom@tromey.com>
4394
4395         * top.c (quit_force): Update.
4396         * main.c (captured_command_loop): Update.
4397         * common/new-op.c (operator new): Update.
4398         * common/common-exceptions.c (struct catcher)
4399         <save_cleanup_chain>: Remove member.
4400         (exceptions_state_mc_init): Update.
4401         (exception_try_scope_entry): Return nullptr.
4402         (exception_try_scope_exit, exception_rethrow)
4403         (throw_exception_sjlj, throw_exception_cxx): Update.
4404         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4405         (all_cleanups, do_cleanups, discard_cleanups)
4406         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4407         (restore_cleanups, restore_final_cleanups): Don't declare.
4408         (do_final_cleanups): Remove parameter.
4409         * common/cleanups.c (cleanup_chain, make_cleanup)
4410         (make_cleanup_dtor, all_cleanups, do_cleanups)
4411         (discard_my_cleanups, discard_cleanups)
4412         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4413         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4414         (null_cleanup): Remove.
4415         (do_final_cleanups): Remove parameter.
4416
4417 2019-03-06  Tom Tromey  <tom@tromey.com>
4418
4419         * remote.c (remote_target::remote_parse_stop_reply): Use
4420         unique_xmalloc_ptr.
4421
4422 2019-03-06  Tom Tromey  <tom@tromey.com>
4423
4424         * stabsread.c (struct stabs_field_info): Rename from field_info.
4425         <list, fnlist>: Add initializers.
4426         <obstack>: New member.
4427         (read_member_functions, read_struct_fields, read_baseclasses):
4428         Allocate on obstack.  Don't use cleanups.
4429         (read_one_struct_field, read_member_functions, read_struct_fields)
4430         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4431         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4432         (read_struct_type): Update.
4433
4434 2019-03-06  Tom Tromey  <tom@tromey.com>
4435
4436         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4437         * common/filestuff.h (make_cleanup_close): Don't declare.
4438         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4439         Remove.
4440
4441 2019-03-06  Tom Tromey  <tom@tromey.com>
4442
4443         * solib-aix.c: Use make_scope_exit.
4444
4445 2019-03-06  Tom Tromey  <tom@tromey.com>
4446
4447         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4448         Use make_scope_exit.
4449
4450 2019-03-06  Tom Tromey  <tom@tromey.com>
4451
4452         * solib-svr4.c (disable_probes_interface): Remove parameter.
4453         (svr4_handle_solib_event): Use make_scope_exit.
4454
4455 2019-03-06  Tom Tromey  <tom@tromey.com>
4456
4457         * remote.c (struct stop_reply_deleter): Remove.
4458         (stop_reply_up): Update.
4459         (struct stop_reply): Derive from notif_event.  Don't typedef.
4460         <regcache>: Now a std::vector.
4461         (stop_reply_xfree): Remove.
4462         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4463         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4464         (remote_target::discard_pending_stop_replies): Use delete.
4465         (remote_target::remote_parse_stop_reply): Update.
4466         (remote_target::process_stop_reply): Update.
4467         * remote-notif.h (struct notif_event): Add virtual destructor.
4468         Remove "dtr" member.
4469         (struct notif_client) <alloc_event>: Return a unique_ptr.
4470         (notif_event_xfree): Don't declare.
4471         (notif_event_up): New typedef.
4472         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4473         (notif_event_xfree, do_notif_event_xfree): Remove.
4474         (remote_notif_state_xfree): Update.
4475
4476 2019-03-06  Tom Tromey  <tom@tromey.com>
4477
4478         * infrun.c (displaced_step_clear_cleanup): Now a
4479         forward_scope_exit type.
4480         (displaced_step_prepare_throw): Update.
4481         (displaced_step_fixup): Update.
4482
4483 2019-03-06  Tom Tromey  <tom@tromey.com>
4484
4485         * inferior.h (class inferior): Update comment.
4486         * gdbthread.h (class thread_info): Update comment.
4487
4488 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4489             Tom Tromey  <tom@tromey.com>
4490
4491         * stabsread.h (struct stab_section_list): Remove.
4492         (coffstab_build_psymtabs): Update.
4493         * dbxread.c (symbuf_sections): Now a std::vector.
4494         (sect_idx): New global.
4495         (fill_symbuf): Update.
4496         (coffstab_build_psymtabs): Change type of stabsects parameter.
4497         Update.
4498         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4499         std::vector.
4500         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4501         (coff_locate_sections): Update.
4502         (coff_symfile_read): Remove cleanups.  Update.
4503         (init_stringtab): Add storage parameter.
4504         (free_stringtab, free_stringtab_cleanup): Remove.
4505         (init_lineno): Add storage parameter.
4506         (free_linetab, free_linetab_cleanup): Remove.
4507
4508 2019-03-06  Pedro Alves  <palves@redhat.com>
4509
4510         * linux-fork.c (fork_info::clobber_regs): Delete.
4511         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4512         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4513         comment.  Adjust.
4514         (scoped_switch_fork_info::scoped_switch_fork_info)
4515         (checkpoint_command, linux_fork_context): Adjust
4516         fork_save_infrun_state calls.
4517
4518 2019-03-06  Pedro Alves  <palves@redhat.com>
4519
4520         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4521         (inf_has_multiple_threads): Return 'bool' and rewrite using
4522         inferior_info::threads().
4523
4524 2019-03-06  Pedro Alves  <palves@redhat.com>
4525
4526         * linux-fork.c: Include <list>.
4527         (fork_list): Now a std::list instance.
4528         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4529         (forks_exist_p, find_last_fork): Adjust.
4530         (new_fork): Delete.
4531         (one_fork_p): New.
4532         (add_fork): Adjust.
4533         (free_fork): Delete, folded into fork_info::~fork_info().
4534         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4535         Adjust.
4536         (init_fork_list): Delete.
4537         (linux_fork_killall, linux_fork_mourn_inferior)
4538         (linux_fork_detach, info_checkpoints_command): Adjust.
4539         (_initialize_linux_fork): No longer call init_fork_list.
4540
4541 2019-03-06  Pedro Alves  <palves@redhat.com>
4542
4543         * linux-fork.c (new_fork): New, split out of ...
4544         (add_fork): ... this.  Return void.  Move "first fork" special
4545         case from here, to ...
4546         (checkpoint_command): ... here.
4547         * linux-linux.h (add_fork): Return void.
4548
4549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4550
4551         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4552
4553 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4554             Chris January  <chris.january@arm.com>
4555             David Lecomber  <david.lecomber@arm.com>
4556
4557         * f-exp.y: New token, UNOP_INTRINSIC.
4558         (exp): New pattern using UNOP_INTRINSIC token.
4559         (f77_keywords): Add 'abs' keyword.
4560         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4561         (value_from_host_double): New function.
4562         (evaluate_subexp_f): Support UNOP_ABS.
4563
4564 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4567         types.
4568
4569 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4570
4571         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4572         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4573         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4574
4575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4576
4577         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4578
4579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4580             Chris January  <chris.january@arm.com>
4581
4582         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4583         * f-exp.y: Define 'KIND' token.
4584         (exp): New pattern for KIND expressions.
4585         (ptype): Handle types with a kind extension.
4586         (direct_abs_decl): Extend to spot kind extensions.
4587         (f77_keywords): Add 'kind' to the list.
4588         (push_kind_type): New function.
4589         (convert_to_kind_type): New function.
4590         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4591         * parse.c (operator_length_standard): Likewise.
4592         * parser-defs.h (enum type_pieces): Add tp_kind.
4593         * std-operator.def: Add UNOP_KIND.
4594
4595 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4596
4597         * f-exp.y (f_parse): Set yydebug.
4598
4599 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4600
4601         * f-lang.c (evaluate_subexp_f): New function.
4602         (exp_descriptor_f): New global.
4603         (f_language_defn): Use exp_descriptor_f instead of
4604         exp_descriptor_standard.
4605
4606 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * f-exp.y (struct token): Add comments.
4609         (dot_ops): Remove uppercase versions and the end marker.
4610         (f77_keywords): Likewise.
4611         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4612         entries in the dot_ops array are case insensitive, and use
4613         strncasecmp to compare strings.  Also some whitespace cleanup in
4614         this area.  Similar for the f77_keywords array, except entries in
4615         this list might be case sensitive.
4616
4617 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * f-exp.y (struct f77_boolean_val): Add comments.
4620         (boolean_values): Remove uppercase versions, and end marker.
4621         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4622         and use strncasecmp to achieve case insensitivity.  Additionally,
4623         perform whitespace cleanup around this code.
4624
4625 2019-03-06  Tom Tromey  <tromey@adacore.com>
4626
4627         * remote-sim.c (gdbsim_target_open): Use result of
4628         gdb_argv::release.
4629
4630 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4631         Dirk Schubert  <dirk.schubert@arm.com>
4632         Chris January  <chris.january@arm.com>
4633
4634         * eval.c (evaluate_subexp_standard): Call Fortran argument
4635         wrapping logic.
4636         * f-lang.c (struct value): A value which can be passed into a
4637         Fortran function call.
4638         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4639         where appropriate.
4640         (struct type): Value ready for a Fortran function call.
4641         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4642         is needed.
4643         * f-lang.h (fortran_argument_convert): Declaration.
4644         (fortran_preserve_arg_pointer): Declaration.
4645         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4646
4647 2019-03-05  Tom Tromey  <tromey@adacore.com>
4648
4649         * python/py-prettyprint.c (print_string_repr): Remove #if.
4650         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4651
4652 2019-03-05  Tom Tromey  <tromey@adacore.com>
4653
4654         * target.c (the_dummy_target): Move later.  Change type to
4655         "dummy_target".
4656         (initialize_targets): Don't initialize the_dummy_target.
4657
4658 2019-03-05  Tom Tromey  <tromey@adacore.com>
4659
4660         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4661         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4662
4663 2019-03-05  Tom Tromey  <tromey@adacore.com>
4664
4665         * windows-nat.c (windows_nat_target::attach)
4666         (windows_nat_target::detach): Don't call gdb_flush.
4667         * valprint.c (generic_val_print, val_print, val_print_string):
4668         Don't call gdb_flush.
4669         * utils.c (defaulted_query): Don't call gdb_flush.
4670         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4671         * target.c (target_announce_detach): Don't call gdb_flush.
4672         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4673         * remote.c (extended_remote_target::attach): Don't call
4674         gdb_flush.
4675         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4676         * printcmd.c (do_examine): Don't call gdb_flush.
4677         (info_display_command): Don't call gdb_flush.
4678         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4679         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4680         * memattr.c (info_mem_command): Don't call gdb_flush.
4681         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4682         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4683         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4684         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4685         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4686         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4687         (gnu_nat_target::detach): Don't call gdb_flush.
4688         * f-valprint.c (f_val_print): Don't call gdb_flush.
4689         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4690         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4691         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4692         gdb_flush.
4693         * c-valprint.c (c_val_print): Don't call gdb_flush.
4694         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4695
4696 2019-03-05  Tom Tromey  <tromey@adacore.com>
4697
4698         * varobj.c (update_dynamic_varobj_children): Update.
4699         (install_default_visualizer): Use reset, not release.
4700         * value.c (set_internalvar): Update.
4701         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4702         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4703         ATTRIBUTE_UNUSED_RESULT.
4704
4705 2019-03-05  Tom Tromey  <tromey@adacore.com>
4706
4707         * remote.c (class scoped_remote_fd) <release>: Add
4708         ATTRIBUTE_UNUSED_RESULT.
4709
4710 2019-03-05  Tom Tromey  <tromey@adacore.com>
4711
4712         * macroexp.c (struct macro_buffer) <release>: Add
4713         ATTRIBUTE_UNUSED_RESULT.
4714
4715 2019-03-05  Tom Tromey  <tromey@adacore.com>
4716
4717         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4718         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4719         ATTRIBUTE_UNUSED_RESULT.
4720
4721 2019-03-05  Tom Tromey  <tromey@adacore.com>
4722
4723         * common/scoped_fd.h (class scoped_fd) <release>: Add
4724         ATTRIBUTE_UNUSED_RESULT.
4725
4726 2019-03-05  Tom Tromey  <tromey@adacore.com>
4727
4728         * parser-defs.h (struct parser_state) <release>: Add
4729         ATTRIBUTE_UNUSED_RESULT.
4730
4731 2019-03-05  Tom Tromey  <tromey@adacore.com>
4732
4733         * utils.h (class gdb_argv) <release>: Add
4734         ATTRIBUTE_UNUSED_RESULT.
4735         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4736
4737 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4738
4739         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4740         for-loop range, to avoid compiler warnings.
4741
4742         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4743         avoid compiler warnings about unused variables.
4744
4745         * NEWS: Mention end of support for native debugging on MS-Windows
4746         before XP.
4747
4748         PR gdb/24292
4749         * common/netstuff.c:
4750         * gdbserver/gdbreplay.c
4751         * gdbserver/remote-utils.c:
4752         * ser-tcp.c:
4753         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4754         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4755         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4756         'getaddrinfo' and 'freeaddrinfo' were not available before
4757         Windows XP, and mingw.org's MinGW headers by default define
4758         _WIN32_WINNT to 0x500.
4759
4760 2019-03-01  Gary Benson <gbenson@redhat.com>
4761
4762         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4763
4764 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4765             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4766
4767         PR gdb/8527
4768         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4769         set_sigint_trap, clear_sigint_trap.
4770
4771 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4772
4773         * target.c (target_detach): Clear the regcache and the
4774         frame cache.
4775
4776 2019-02-27  Pedro Alves  <palves@redhat.com>
4777
4778         * utils.c (set_screen_size): When we cap the height/width sizes,
4779         tweak the corresponding command variable to show "unlimited":
4780
4781 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4782             Pedro Alves  <palves@redhat.com>
4783
4784         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4785         before calling rl_set_screen_size.
4786
4787 2019-02-27  Tom Tromey  <tromey@adacore.com>
4788
4789         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4790         define.
4791         * python/py-value.c: Remove Python 2.4 workaround.
4792         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4793         workaround.
4794         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4795         Python 2.4 workaround.
4796         * python/python-internal.h: Remove Python 2.4 comment.
4797         (Py_ssize_t): Don't define.
4798         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4799         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4800         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4801         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4802         * python/python.c (do_start_initialization): Remove Python 2.4
4803         workaround.
4804         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4805         (print_children): Remove Python 2.4 workaround.
4806         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4807         workaround.
4808         (CHARBUFFERPROC_NAME): Remove.
4809         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4810         Python 2.4 workaround.
4811
4812 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4813
4814         * NEWS: Note minimum Python version.
4815
4816 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4817
4818         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4819         code from these functions.  Remove corresponding ifdefs.  Use
4820         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4821         Remove gotos and target of gotos.
4822         (infpy_search_memory): Likewise.
4823
4824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4825
4826         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4827         (hppa_gdbarch_init): Don't register deleted functions with
4828         gdbarch.
4829
4830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4833         (h8300_unwind_sp): Delete.
4834         (h8300_dummy_id): Delete.
4835         (h8300_gdbarch_init): Don't register deleted functions with
4836         gdbarch.
4837
4838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4841         (ft32_unwind_pc): Delete.
4842         (ft32_unwind_sp): Delete.
4843         (ft32_gdbarch_init): Don't register deleted functions with
4844         gdbarch.
4845
4846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4849         (frv_unwind_pc): Delete.
4850         (frv_unwind_sp): Delete.
4851         (frv_gdbarch_init): Don't register deleted functions with
4852         gdbarch.
4853
4854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4857         (riscv_unwind_pc): Delete.
4858         (riscv_unwind_sp): Delete.
4859         (riscv_gdbarch_init): Don't register deleted functions with
4860         gdbarch.
4861
4862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4865         (csky_unwind_pc): Delete.
4866         (csky_unwind_sp): Delete.
4867         (csky_gdbarch_init): Don't register deleted functions with
4868         gdbarch.
4869
4870 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4871
4872         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4873         (cris_unwind_pc): Delete.
4874         (cris_unwind_sp): Delete.
4875         (cris_gdbarch_init): Don't register deleted functions with
4876         gdbarch.
4877
4878 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4881         (bfin_unwind_pc): Delete.
4882         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4883
4884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4887         (arm_unwind_pc): Delete.
4888         (arm_unwind_sp): Delete.
4889         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4890
4891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4892
4893         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4894         (arc_unwind_pc): Delete.
4895         (arc_unwind_sp): Delete.
4896         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4897
4898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4901         (alpha_unwind_pc): Delete.
4902         (alpha_gdbarch_init): Don't register deleted functions with
4903         gdbarch.
4904
4905 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4906
4907         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4908         (aarch64_unwind_pc): Delete.
4909         (aarch64_unwind_sp): Delete.
4910         (aarch64_gdbarch_init): Don't register deleted functions with
4911         gdbarch.
4912
4913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * gdbtypes.c (type_align): Don't consider static members when
4916         computing structure alignment.
4917
4918 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4921         return 0 for other types.
4922         * arch-utils.c (default_type_align): Always return 0.
4923         * gdbarch.h: Regenerate.
4924         * gdbarch.sh (type_align): Extend comment.
4925         * gdbtypes.c (type_align): Add additional comments, always call
4926         gdbarch_type_align before applying the default rules.
4927         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4928         generic code will then apply a suitable default.
4929         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4930         types, return 0 for other types.
4931
4932 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4933
4934         * NEWS: Create a new section for the next release branch.
4935         Rename the section of the current branch, now that it has
4936         been cut.
4937
4938 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4939
4940         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4941         * version.in: Bump version to 8.3.50.DATE-git.
4942
4943 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4944
4945         * aix-thread.c (ptid_cmp): Remove unused variable.
4946         (get_signaled_thread): Likewise.
4947         (store_regs_user_thread): Likewise.
4948         (store_regs_kernel_thread): Likewise.
4949         (fetch_regs_kernel_thread): Remove shadowed variable.
4950
4951 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * features/riscv/32bit-cpu.xml: Add register numbers.
4954         * features/riscv/32bit-fpu.c: Regenerate.
4955         * features/riscv/32bit-fpu.xml: Add register numbers.
4956         * features/riscv/64bit-cpu.xml: Add register numbers.
4957         * features/riscv/64bit-fpu.c: Regenerate.
4958         * features/riscv/64bit-fpu.xml: Add register numbers.
4959
4960 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4961
4962         * NEWS: Mention two argument form of gdb.Value constructor.
4963         * python/py-value.c (convert_buffer_and_type_to_value): New
4964         function.
4965         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4966         Add support for handling an optional second argument.  Call
4967         convert_buffer_and_type_to_value as appropriate.
4968         * python/python-internal.h (Py_buffer_deleter): New struct.
4969         (Py_buffer_up): New typedef.
4970
4971 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4972
4973         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4974         instead of releasing ownership.
4975
4976 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4977
4978         * dwarf2read.c (open_and_init_dwp_file): Call
4979         elf_numsections instead of bfd_count_sections to initialize
4980         dwp_file->num_sections.
4981
4982 2019-02-25  Tom Tromey  <tromey@adacore.com>
4983
4984         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4985
4986 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4987
4988         * gcore.in: Add '--readnever' option when invoking GDB.
4989
4990 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4991
4992         * MAINTAINERS: Update my email address.
4993
4994 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4995
4996         * build-id.c (build_id_to_debug_bfd_1): New function.
4997         (build_id_to_debug_bfd): Look for separate debug file in
4998         sysroot.
4999
5000 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * gdbarch.sh: Update the copyright year range that is placed into
5003         generated files.
5004
5005 2019-02-22  Keith Seitz  <keiths@redhat.com>
5006
5007         PR symtab/23853
5008         * linespec.c (create_sals_line_offset): Search for the default
5009         symtab's filename instead of its fullname.
5010
5011 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5012
5013         * NEWS: Update style defaults.
5014
5015 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5016
5017         * main.c (captured_main_1): Disable styling in batch mode.
5018
5019 2019-02-20  Tom Tromey  <tom@tromey.com>
5020
5021         * symtab.c (symtab_symbol_info): Fix typos.
5022
5023 2019-02-20  Tom Tromey  <tromey@adacore.com>
5024
5025         * findcmd.c (_initialize_mem_search): Use upper case for
5026         metasyntactic variables.
5027
5028 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5029
5030         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5031         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5032
5033 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5034
5035         * top.h (source_file_name): Change to std::string.
5036         * top.c (source_file_name): Likewise.
5037         (command_line_input): Adjust.
5038         * cli/cli-script.c (script_from_file): Adjust.
5039
5040 2019-02-19  Tom Tromey  <tromey@adacore.com>
5041
5042         * ravenscar-thread.c
5043         (ravenscar_thread_target::update_thread_list): Don't call
5044         ada_build_task_list.
5045         * ada-lang.h (ada_build_task_list): Don't declare.
5046         * ada-tasks.c (struct ada_tasks_inferior_data)
5047         <task_list_valid_p>: Now bool.
5048         (read_known_tasks, ada_task_list_changed)
5049         (ada_tasks_invalidate_inferior_data): Update.
5050         (read_known_tasks_array): Return bool.
5051         (read_known_tasks_list): Likewise.
5052         (read_known_tasks): Return void.
5053         (ada_build_task_list): Now static.
5054
5055 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5056
5057         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5058         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5059
5060 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5061
5062         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5063         variant for ada_tasks_pspace_data_handle and
5064         ada_tasks_inferior_data_handle.
5065         (ada_tasks_pspace_data_cleanup): New function.
5066         (ada_tasks_inferior_data_cleanup): New function.
5067
5068 2019-02-17  Tom Tromey  <tom@tromey.com>
5069
5070         * macrotab.h (macro_source_fullname): Return a std::string.
5071         * macrotab.c (macro_include, check_for_redefinition)
5072         (macro_undef, macro_lookup_definition, foreach_macro)
5073         (foreach_macro_in_scope): Update.
5074         (macro_source_fullname): Return a std::string.
5075         * macrocmd.c (show_pp_source_pos): Update.
5076
5077 2019-02-17  Tom Tromey  <tom@tromey.com>
5078
5079         * macrocmd.c (show_pp_source_pos): Style the file names.
5080
5081 2019-02-17  Tom Tromey  <tom@tromey.com>
5082
5083         PR tui/24197:
5084         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5085
5086 2019-02-17  Tom Tromey  <tom@tromey.com>
5087
5088         * ada-lang.c (user_select_syms): Use filtered printing.
5089         * utils.c (wrap_style): New global.
5090         (desired_style): Remove.
5091         (emit_style_escape): Add stream parameter.
5092         (set_output_style, reset_terminal_style, prompt_for_continue):
5093         Update.
5094         (flush_wrap_buffer): Only flush gdb_stdout.
5095         (wrap_here): Set wrap_style.
5096         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5097         treat escape sequences as a character.  Change when wrap buffer is
5098         flushed.
5099         (fputs_styled): Do not set the output style when the default is
5100         requested.
5101         * ui-style.h (struct ui_file_style) <is_default>: New method.
5102         * source.c (print_source_lines_base): Emit escape sequences in one
5103         piece.
5104
5105 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5106
5107         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5108         integers and enumeration types.
5109
5110 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5111
5112         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5113         instead of lookup_symbol_in_language
5114         (do_exact_match): New function.
5115         (ada_get_symbol_name_matcher): Return do_exact_match when
5116         doing a verbatim match.
5117
5118 2019-02-15  Tom Tromey  <tromey@adacore.com>
5119
5120         * ravenscar-thread.c (ravenscar_thread_target::resume)
5121         (ravenscar_thread_target::wait): Special case wildcard requests.
5122
5123 2019-02-15  Tom Tromey  <tromey@adacore.com>
5124
5125         * ravenscar-thread.c (base_ptid): Remove.
5126         (struct ravenscar_thread_target) <close>: New method.
5127         <m_base_ptid>: New member.
5128         <update_inferior_ptid, active_task, task_is_currently_active,
5129         runtime_initialized>: Declare methods.
5130         <ravenscar_thread_target>: Add constructor.
5131         (ravenscar_thread_target::task_is_currently_active)
5132         (ravenscar_thread_target::update_inferior_ptid)
5133         (ravenscar_runtime_initialized): Rename.  Now methods.
5134         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5135         (ravenscar_thread_target::update_thread_list): Update.
5136         (ravenscar_thread_target::active_task): Now method.
5137         (ravenscar_thread_target::store_registers)
5138         (ravenscar_thread_target::prepare_to_store)
5139         (ravenscar_thread_target::prepare_to_store)
5140         (ravenscar_thread_target::mourn_inferior): Update.
5141         (ravenscar_inferior_created): Use "new" to create target.
5142         (ravenscar_thread_target::get_ada_task_ptid): Update.
5143         (_initialize_ravenscar): Don't initialize base_ptid.
5144         (ravenscar_ops): Remove global.
5145
5146 2019-02-15  Tom Tromey  <tromey@adacore.com>
5147
5148         * target.h (push_target): Declare new overload.
5149         * target.c (push_target): New overload, taking an rvalue reference.
5150         * remote.c (remote_target::open_1): Use push_target overload.
5151         * corelow.c (core_target_open): Use push_target overload.
5152
5153 2019-02-15  Tom Tromey  <tromey@adacore.com>
5154
5155         * ravenscar-thread.c (is_ravenscar_task)
5156         (ravenscar_task_is_currently_active): Return bool.
5157         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5158         (_initialize_ravenscar): Remove "(void)".
5159         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5160         Return bool.
5161
5162 2019-02-15  Tom Tromey  <tromey@adacore.com>
5163
5164         * ravenscar-thread.c (ravenscar_runtime_initializer)
5165         (has_ravenscar_runtime, get_running_thread_id)
5166         (ravenscar_thread_target::resume): Fix indentation.
5167
5168 2019-02-15  Tom Tromey  <tromey@adacore.com>
5169
5170         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5171         from ravenscar_arch_ops.
5172         (sparc_ravenscar_ops::fetch_registers)
5173         (sparc_ravenscar_ops::store_registers): Now methods.
5174         (sparc_ravenscar_prepare_to_store): Remove.
5175         (sparc_ravenscar_ops): Redefine.
5176         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5177         methods and destructor.  Remove members.
5178         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5179         (ravenscar_thread_target::store_registers)
5180         (ravenscar_thread_target::prepare_to_store): Update.
5181         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5182         Remove.
5183         (struct ppc_ravenscar_powerpc_ops): Derive from
5184         ravenscar_arch_ops.
5185         (ppc_ravenscar_powerpc_ops::fetch_registers)
5186         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5187         (ppc_ravenscar_powerpc_ops): Redefine.
5188         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5189         (ppc_ravenscar_e500_ops::fetch_registers)
5190         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5191         (ppc_ravenscar_e500_ops): Redefine.
5192         * aarch64-ravenscar-thread.c
5193         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5194         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5195         (aarch64_ravenscar_fetch_registers)
5196         (aarch64_ravenscar_store_registers): Now methods.
5197         (aarch64_ravenscar_ops): Redefine.
5198
5199 2019-02-15  Tom Tromey  <tromey@adacore.com>
5200
5201         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5202         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5203         (ravenscar_thread_target::stopped_by_watchpoint)
5204         (ravenscar_thread_target::stopped_data_address)
5205         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5206
5207 2019-02-15  Tom Tromey  <tromey@adacore.com>
5208
5209         * ravenscar-thread.c: Fix some typos.
5210
5211 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5212             Tom Tromey  <tromey@adacore.com>
5213
5214         * ada-lang.c (ada_exception_sal): Change addr_string to a
5215         std::string.
5216         (create_ada_exception_catchpoint): Update.
5217
5218 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5219             Tom Tromey  <tromey@adacore.com>
5220
5221         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5222         (bp_location_ops): Remove.
5223         (base_breakpoint_allocate_location): Update.
5224         (free_bp_location): Update.
5225         * ada-lang.c (class ada_catchpoint_location)
5226         <ada_catchpoint_location>: Remove ops parameter.
5227         (ada_catchpoint_location_dtor): Remove.
5228         (ada_catchpoint_location_ops): Remove.
5229         (allocate_location_exception): Update.
5230         * breakpoint.h (struct bp_location_ops): Remove.
5231         (class bp_location) <bp_location>: Remove bp_location_ops
5232         parameter.
5233         <~bp_location>: Add destructor.
5234         <ops>: Remove.
5235
5236 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5237             Pedro Alves  <palves@redhat.com>
5238
5239         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5240         'PATH_MAX'.
5241
5242 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5243             Samuel Thibault  <samuel.thibault@gnu.org>
5244             Thomas Schwinge  <thomas@codesourcery.com>
5245
5246         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5247         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5248
5249 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5250
5251         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5252         (check_empty): Use "const char *".
5253
5254         * gnu-nat.c (gnu_nat_target::detach): Instead of
5255         'detach_inferior (pid)' call
5256         'detach_inferior (find_inferior_pid (pid))'.
5257
5258         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5259         'nat/fork-inferior.o'.
5260         * gnu-nat.c: #include "nat/fork-inferior.h".
5261
5262         * gnu-nat.c (gnu_nat_target::detach): Instead of
5263         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5264         * gnu-nat.h: #include "inf-child.h".
5265         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5266         'i386_gnu_nat_target::fetch_registers'.
5267         (gnu_store_registers): Rename/move to
5268         'i386_gnu_nat_target::store_registers'.
5269
5270         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5271         * gnu-nat.h (mach_thread_info): New function.
5272         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5273
5274         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5275
5276 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5277
5278         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5279
5280 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5281
5282         * windows-nat.c (windows_add_thread): Add new parameter
5283         "main_thread_p" with default value set to false.  Update
5284         function documentation as well as all callers.
5285         (windows_delete_thread): Likewise.
5286         (fake_create_process): Update call to windows_add_thread.
5287         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5288         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5289         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5290         call to windows_delete_thread.
5291
5292 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5293
5294         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5295
5296 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5297
5298         * symfile.c (find_separate_debug_file): Use canonical path of
5299         sysroot with child_path instead of gdb_sysroot if it is valid.
5300
5301 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5302
5303         * symfile.c (find_separate_debug_file): Use child_path to
5304         determine if an object file is under a sysroot.
5305
5306 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5307
5308         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5309         unittests/child-path-selftests.c.
5310         * common/pathstuff.c (child_path): New function.
5311         * common/pathstuff.h (child_path): New prototype.
5312         * unittests/child-path-selftests.c: New file.
5313
5314 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5315
5316         * symfile.c (find_separate_debug_file): Look for separate debug
5317         files in debug directories under the sysroot.
5318
5319 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5320
5321         * symtab.h (struct minimal_symbol data_p): New const method.
5322         (struct minimal_symbol text_p): Likewise.
5323         * symtab.c (output_source_filename): Use file name style
5324         to print file name.
5325         (print_symbol_info): Likewise.
5326         (print_msymbol_info): Use address style to print addresses.
5327         Use function name style to print executable text symbols.
5328         (expand_symtab_containing_pc): Use data_p.
5329         (find_pc_sect_compunit_symtab): Likewise.
5330
5331 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5332
5333         * breakpoint.c (describe_other_breakpoints): Use address style
5334         to print addresses.
5335         (say_where): Likewise.
5336
5337 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5338
5339         * ada-typeprint.c (print_func_type): Print function name
5340         style to print function name.
5341         * c-typeprint.c (c_print_type_1): Likewise.
5342
5343 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5344
5345         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5346         for execve.
5347
5348 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5349
5350         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5351         type_stack.
5352
5353 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5354
5355         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5356         TYPE_CODE_REF types.
5357
5358 2019-02-08  Jim Wilson  <jimw@sifive.com>
5359
5360         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5361         (riscv_linux_fregset): New.
5362         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5363
5364 2019-02-07  Tom Tromey  <tom@tromey.com>
5365
5366         * thread.c (thread_cancel_execution_command): Update.
5367         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5368         methods.
5369         (struct thread_fsm_ops): Remove.
5370         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5371         (thread_fsm_should_stop, thread_fsm_return_value)
5372         (thread_fsm_set_finished, thread_fsm_finished_p)
5373         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5374         Don't declare.
5375         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5376         * infrun.c (clear_proceed_status_thread)
5377         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5378         (print_stop_event): Update.
5379         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5380         Add constructor.
5381         (step_command_fsm_ops): Remove.
5382         (new_step_command_fsm): Remove.
5383         (step_1): Update.
5384         (step_command_fsm::should_stop): Rename from
5385         step_command_fsm_should_stop.
5386         (step_command_fsm::clean_up): Rename from
5387         step_command_fsm_clean_up.
5388         (step_command_fsm::do_async_reply_reason): Rename from
5389         step_command_fsm_async_reply_reason.
5390         (struct until_next_fsm): Inherit from thread_fsm.  Add
5391         constructor.
5392         (until_next_fsm_ops): Remove.
5393         (new_until_next_fsm): Remove.
5394         (until_next_fsm::should_stop): Rename from
5395         until_next_fsm_should_stop.
5396         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5397         (until_next_fsm::do_async_reply_reason): Rename from
5398         until_next_fsm_async_reply_reason.
5399         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5400         constructor.  Change type of breakpoint.
5401         (finish_command_fsm_ops): Remove.
5402         (new_finish_command_fsm): Remove.
5403         (finish_command_fsm::should_stop): Rename from
5404         finish_command_fsm_should_stop.
5405         (finish_command_fsm::clean_up): Rename from
5406         finish_command_fsm_clean_up.
5407         (finish_command_fsm::return_value): Rename from
5408         finish_command_fsm_return_value.
5409         (finish_command_fsm::do_async_reply_reason): Rename from
5410         finish_command_fsm_async_reply_reason.
5411         (finish_command): Update.
5412         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5413         Add constructor.
5414         (call_thread_fsm_ops): Remove.
5415         (call_thread_fsm::call_thread_fsm): Rename from
5416         new_call_thread_fsm.
5417         (call_thread_fsm::should_stop): Rename from
5418         call_thread_fsm_should_stop.
5419         (call_thread_fsm::should_notify_stop): Rename from
5420         call_thread_fsm_should_notify_stop.
5421         (run_inferior_call, call_function_by_hand_dummy): Update.
5422         * cli/cli-interp.c (should_print_stop_to_console): Update.
5423         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5424         Add constructor.  Change type of location_breakpoint,
5425         caller_breakpoint.
5426         (until_break_fsm_ops): Remove.
5427         (new_until_break_fsm): Remove.
5428         (until_break_fsm::should_stop): Rename from
5429         until_break_fsm_should_stop.
5430         (until_break_fsm::clean_up): Rename from
5431         until_break_fsm_clean_up.
5432         (until_break_fsm::do_async_reply_reason): Rename from
5433         until_break_fsm_async_reply_reason.
5434         (until_break_command): Update.
5435         * thread-fsm.c: Remove.
5436         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5437
5438 2019-02-07  Tom Tromey  <tom@tromey.com>
5439
5440         * yy-remap.h: Add include guard.
5441         * xtensa-tdep.h: Add include guard.
5442         * xcoffread.h: Rename include guard.
5443         * varobj-iter.h: Add include guard.
5444         * tui/tui.h: Rename include guard.
5445         * tui/tui-winsource.h: Rename include guard.
5446         * tui/tui-wingeneral.h: Rename include guard.
5447         * tui/tui-windata.h: Rename include guard.
5448         * tui/tui-win.h: Rename include guard.
5449         * tui/tui-stack.h: Rename include guard.
5450         * tui/tui-source.h: Rename include guard.
5451         * tui/tui-regs.h: Rename include guard.
5452         * tui/tui-out.h: Rename include guard.
5453         * tui/tui-layout.h: Rename include guard.
5454         * tui/tui-io.h: Rename include guard.
5455         * tui/tui-hooks.h: Rename include guard.
5456         * tui/tui-file.h: Rename include guard.
5457         * tui/tui-disasm.h: Rename include guard.
5458         * tui/tui-data.h: Rename include guard.
5459         * tui/tui-command.h: Rename include guard.
5460         * tic6x-tdep.h: Add include guard.
5461         * target/waitstatus.h: Rename include guard.
5462         * target/wait.h: Rename include guard.
5463         * target/target.h: Rename include guard.
5464         * target/resume.h: Rename include guard.
5465         * target-float.h: Rename include guard.
5466         * stabsread.h: Add include guard.
5467         * rs6000-tdep.h: Add include guard.
5468         * riscv-fbsd-tdep.h: Add include guard.
5469         * regformats/regdef.h: Rename include guard.
5470         * record.h: Rename include guard.
5471         * python/python.h: Rename include guard.
5472         * python/python-internal.h: Rename include guard.
5473         * python/py-stopevent.h: Rename include guard.
5474         * python/py-ref.h: Rename include guard.
5475         * python/py-record.h: Rename include guard.
5476         * python/py-record-full.h: Rename include guard.
5477         * python/py-record-btrace.h: Rename include guard.
5478         * python/py-instruction.h: Rename include guard.
5479         * python/py-events.h: Rename include guard.
5480         * python/py-event.h: Rename include guard.
5481         * procfs.h: Add include guard.
5482         * proc-utils.h: Add include guard.
5483         * p-lang.h: Add include guard.
5484         * or1k-tdep.h: Rename include guard.
5485         * observable.h: Rename include guard.
5486         * nto-tdep.h: Rename include guard.
5487         * nat/x86-linux.h: Rename include guard.
5488         * nat/x86-linux-dregs.h: Rename include guard.
5489         * nat/x86-gcc-cpuid.h: Add include guard.
5490         * nat/x86-dregs.h: Rename include guard.
5491         * nat/x86-cpuid.h: Rename include guard.
5492         * nat/ppc-linux.h: Rename include guard.
5493         * nat/mips-linux-watch.h: Rename include guard.
5494         * nat/linux-waitpid.h: Rename include guard.
5495         * nat/linux-ptrace.h: Rename include guard.
5496         * nat/linux-procfs.h: Rename include guard.
5497         * nat/linux-osdata.h: Rename include guard.
5498         * nat/linux-nat.h: Rename include guard.
5499         * nat/linux-namespaces.h: Rename include guard.
5500         * nat/linux-btrace.h: Rename include guard.
5501         * nat/glibc_thread_db.h: Rename include guard.
5502         * nat/gdb_thread_db.h: Rename include guard.
5503         * nat/gdb_ptrace.h: Rename include guard.
5504         * nat/fork-inferior.h: Rename include guard.
5505         * nat/amd64-linux-siginfo.h: Rename include guard.
5506         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5507         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5508         * nat/aarch64-linux.h: Rename include guard.
5509         * nat/aarch64-linux-hw-point.h: Rename include guard.
5510         * mn10300-tdep.h: Add include guard.
5511         * mips-linux-tdep.h: Add include guard.
5512         * mi/mi-parse.h: Rename include guard.
5513         * mi/mi-out.h: Rename include guard.
5514         * mi/mi-main.h: Rename include guard.
5515         * mi/mi-interp.h: Rename include guard.
5516         * mi/mi-getopt.h: Rename include guard.
5517         * mi/mi-console.h: Rename include guard.
5518         * mi/mi-common.h: Rename include guard.
5519         * mi/mi-cmds.h: Rename include guard.
5520         * mi/mi-cmd-break.h: Rename include guard.
5521         * m2-lang.h: Add include guard.
5522         * location.h: Rename include guard.
5523         * linux-record.h: Rename include guard.
5524         * linux-nat.h: Add include guard.
5525         * linux-fork.h: Add include guard.
5526         * i386-darwin-tdep.h: Rename include guard.
5527         * hppa-linux-offsets.h: Add include guard.
5528         * guile/guile.h: Rename include guard.
5529         * guile/guile-internal.h: Rename include guard.
5530         * gnu-nat.h: Rename include guard.
5531         * gdb-stabs.h: Rename include guard.
5532         * frv-tdep.h: Add include guard.
5533         * f-lang.h: Add include guard.
5534         * event-loop.h: Add include guard.
5535         * darwin-nat.h: Rename include guard.
5536         * cp-abi.h: Rename include guard.
5537         * config/sparc/nm-sol2.h: Rename include guard.
5538         * config/nm-nto.h: Rename include guard.
5539         * config/nm-linux.h: Add include guard.
5540         * config/i386/nm-i386gnu.h: Rename include guard.
5541         * config/djgpp/nl_types.h: Rename include guard.
5542         * config/djgpp/langinfo.h: Rename include guard.
5543         * compile/gcc-cp-plugin.h: Add include guard.
5544         * compile/gcc-c-plugin.h: Add include guard.
5545         * compile/compile.h: Rename include guard.
5546         * compile/compile-object-run.h: Rename include guard.
5547         * compile/compile-object-load.h: Rename include guard.
5548         * compile/compile-internal.h: Rename include guard.
5549         * compile/compile-cplus.h: Rename include guard.
5550         * compile/compile-c.h: Rename include guard.
5551         * common/xml-utils.h: Rename include guard.
5552         * common/x86-xstate.h: Rename include guard.
5553         * common/version.h: Rename include guard.
5554         * common/vec.h: Rename include guard.
5555         * common/tdesc.h: Rename include guard.
5556         * common/selftest.h: Rename include guard.
5557         * common/scoped_restore.h: Rename include guard.
5558         * common/scoped_mmap.h: Rename include guard.
5559         * common/scoped_fd.h: Rename include guard.
5560         * common/safe-iterator.h: Rename include guard.
5561         * common/run-time-clock.h: Rename include guard.
5562         * common/refcounted-object.h: Rename include guard.
5563         * common/queue.h: Rename include guard.
5564         * common/ptid.h: Rename include guard.
5565         * common/print-utils.h: Rename include guard.
5566         * common/preprocessor.h: Rename include guard.
5567         * common/pathstuff.h: Rename include guard.
5568         * common/observable.h: Rename include guard.
5569         * common/netstuff.h: Rename include guard.
5570         * common/job-control.h: Rename include guard.
5571         * common/host-defs.h: Rename include guard.
5572         * common/gdb_wait.h: Rename include guard.
5573         * common/gdb_vecs.h: Rename include guard.
5574         * common/gdb_unlinker.h: Rename include guard.
5575         * common/gdb_unique_ptr.h: Rename include guard.
5576         * common/gdb_tilde_expand.h: Rename include guard.
5577         * common/gdb_sys_time.h: Rename include guard.
5578         * common/gdb_string_view.h: Rename include guard.
5579         * common/gdb_splay_tree.h: Rename include guard.
5580         * common/gdb_setjmp.h: Rename include guard.
5581         * common/gdb_ref_ptr.h: Rename include guard.
5582         * common/gdb_optional.h: Rename include guard.
5583         * common/gdb_locale.h: Rename include guard.
5584         * common/gdb_assert.h: Rename include guard.
5585         * common/filtered-iterator.h: Rename include guard.
5586         * common/filestuff.h: Rename include guard.
5587         * common/fileio.h: Rename include guard.
5588         * common/environ.h: Rename include guard.
5589         * common/common-utils.h: Rename include guard.
5590         * common/common-types.h: Rename include guard.
5591         * common/common-regcache.h: Rename include guard.
5592         * common/common-inferior.h: Rename include guard.
5593         * common/common-gdbthread.h: Rename include guard.
5594         * common/common-exceptions.h: Rename include guard.
5595         * common/common-defs.h: Rename include guard.
5596         * common/common-debug.h: Rename include guard.
5597         * common/cleanups.h: Rename include guard.
5598         * common/buffer.h: Rename include guard.
5599         * common/btrace-common.h: Rename include guard.
5600         * common/break-common.h: Rename include guard.
5601         * cli/cli-utils.h: Rename include guard.
5602         * cli/cli-style.h: Rename include guard.
5603         * cli/cli-setshow.h: Rename include guard.
5604         * cli/cli-script.h: Rename include guard.
5605         * cli/cli-interp.h: Rename include guard.
5606         * cli/cli-decode.h: Rename include guard.
5607         * cli/cli-cmds.h: Rename include guard.
5608         * charset-list.h: Add include guard.
5609         * buildsym-legacy.h: Rename include guard.
5610         * bfin-tdep.h: Add include guard.
5611         * ax.h: Rename include guard.
5612         * arm-linux-tdep.h: Add include guard.
5613         * arm-fbsd-tdep.h: Add include guard.
5614         * arch/xtensa.h: Rename include guard.
5615         * arch/tic6x.h: Add include guard.
5616         * arch/i386.h: Add include guard.
5617         * arch/arm.h: Rename include guard.
5618         * arch/arm-linux.h: Rename include guard.
5619         * arch/arm-get-next-pcs.h: Rename include guard.
5620         * arch/amd64.h: Add include guard.
5621         * arch/aarch64-insn.h: Rename include guard.
5622         * arch-utils.h: Rename include guard.
5623         * annotate.h: Add include guard.
5624         * amd64-darwin-tdep.h: Rename include guard.
5625         * aarch64-linux-tdep.h: Add include guard.
5626         * aarch64-fbsd-tdep.h: Add include guard.
5627         * aarch32-linux-nat.h: Add include guard.
5628
5629 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5630
5631         * macrotab.c (macro_define_internal): New function that
5632         factorizes macro_define_object_internal and macro_define_function
5633         code.
5634         (macro_define_object_internal): Use macro_define_internal.
5635         (macro_define_function): Likewise.
5636
5637 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5638
5639         * macrocmd.c (extract_identifier): Return
5640         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5641         callers.
5642
5643 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5644
5645         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5646
5647 2019-02-05  Tom Tromey  <tom@tromey.com>
5648
5649         * target.c (target_stack::unpush): Move assertion earlier.
5650
5651 2019-01-30  Tom Tromey  <tom@tromey.com>
5652
5653         PR python/23615:
5654         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5655         (gdbpy_parse_and_eval): Likewise.
5656         * python/python-internal.h (gdbpy_allow_threads): New class.
5657
5658 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5659
5660         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5661         (aarch64_fbsd_fpregmap): Move earlier.
5662         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5663         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5664         instead of individual calls to trad_frame_set_reg_addr.
5665         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5666         earlier.
5667         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5668         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5669         instead of individual calls to trad_frame_set_reg_addr.
5670
5671 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5672
5673         * CONTRIBUTE: Replace contribution list with wiki link.
5674
5675 2019-01-25  Tom Tromey  <tom@tromey.com>
5676
5677         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5678
5679 2019-01-25  Tom Tromey  <tom@tromey.com>
5680
5681         * xtensa-linux-nat.c: Fix common/ includes.
5682         * xml-support.h: Fix common/ includes.
5683         * xml-support.c: Fix common/ includes.
5684         * x86-linux-nat.c: Fix common/ includes.
5685         * windows-nat.c: Fix common/ includes.
5686         * varobj.h: Fix common/ includes.
5687         * varobj.c: Fix common/ includes.
5688         * value.c: Fix common/ includes.
5689         * valops.c: Fix common/ includes.
5690         * utils.c: Fix common/ includes.
5691         * unittests/xml-utils-selftests.c: Fix common/ includes.
5692         * unittests/utils-selftests.c: Fix common/ includes.
5693         * unittests/unpack-selftests.c: Fix common/ includes.
5694         * unittests/tracepoint-selftests.c: Fix common/ includes.
5695         * unittests/style-selftests.c: Fix common/ includes.
5696         * unittests/string_view-selftests.c: Fix common/ includes.
5697         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5698         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5699         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5700         * unittests/rsp-low-selftests.c: Fix common/ includes.
5701         * unittests/parse-connection-spec-selftests.c: Fix common/
5702         includes.
5703         * unittests/optional-selftests.c: Fix common/ includes.
5704         * unittests/offset-type-selftests.c: Fix common/ includes.
5705         * unittests/observable-selftests.c: Fix common/ includes.
5706         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5707         * unittests/memrange-selftests.c: Fix common/ includes.
5708         * unittests/memory-map-selftests.c: Fix common/ includes.
5709         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5710         * unittests/function-view-selftests.c: Fix common/ includes.
5711         * unittests/environ-selftests.c: Fix common/ includes.
5712         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5713         * unittests/common-utils-selftests.c: Fix common/ includes.
5714         * unittests/cli-utils-selftests.c: Fix common/ includes.
5715         * unittests/array-view-selftests.c: Fix common/ includes.
5716         * ui-file.c: Fix common/ includes.
5717         * tui/tui-io.c: Fix common/ includes.
5718         * tracepoint.h: Fix common/ includes.
5719         * tracepoint.c: Fix common/ includes.
5720         * tracefile-tfile.c: Fix common/ includes.
5721         * top.h: Fix common/ includes.
5722         * top.c: Fix common/ includes.
5723         * thread.c: Fix common/ includes.
5724         * target/waitstatus.h: Fix common/ includes.
5725         * target/waitstatus.c: Fix common/ includes.
5726         * target.h: Fix common/ includes.
5727         * target.c: Fix common/ includes.
5728         * target-memory.c: Fix common/ includes.
5729         * target-descriptions.c: Fix common/ includes.
5730         * symtab.h: Fix common/ includes.
5731         * symfile.c: Fix common/ includes.
5732         * stap-probe.c: Fix common/ includes.
5733         * spu-linux-nat.c: Fix common/ includes.
5734         * sparc-nat.c: Fix common/ includes.
5735         * source.c: Fix common/ includes.
5736         * solib.c: Fix common/ includes.
5737         * solib-target.c: Fix common/ includes.
5738         * ser-unix.c: Fix common/ includes.
5739         * ser-tcp.c: Fix common/ includes.
5740         * ser-pipe.c: Fix common/ includes.
5741         * ser-base.c: Fix common/ includes.
5742         * selftest-arch.c: Fix common/ includes.
5743         * s12z-tdep.c: Fix common/ includes.
5744         * rust-exp.y: Fix common/ includes.
5745         * rs6000-aix-tdep.c: Fix common/ includes.
5746         * riscv-tdep.c: Fix common/ includes.
5747         * remote.c: Fix common/ includes.
5748         * remote-notif.h: Fix common/ includes.
5749         * remote-fileio.h: Fix common/ includes.
5750         * remote-fileio.c: Fix common/ includes.
5751         * regcache.h: Fix common/ includes.
5752         * regcache.c: Fix common/ includes.
5753         * record-btrace.c: Fix common/ includes.
5754         * python/python.c: Fix common/ includes.
5755         * python/py-type.c: Fix common/ includes.
5756         * python/py-inferior.c: Fix common/ includes.
5757         * progspace.h: Fix common/ includes.
5758         * producer.c: Fix common/ includes.
5759         * procfs.c: Fix common/ includes.
5760         * proc-api.c: Fix common/ includes.
5761         * printcmd.c: Fix common/ includes.
5762         * ppc-linux-nat.c: Fix common/ includes.
5763         * parser-defs.h: Fix common/ includes.
5764         * osdata.c: Fix common/ includes.
5765         * obsd-nat.c: Fix common/ includes.
5766         * nat/x86-linux.c: Fix common/ includes.
5767         * nat/x86-linux-dregs.c: Fix common/ includes.
5768         * nat/x86-dregs.h: Fix common/ includes.
5769         * nat/x86-dregs.c: Fix common/ includes.
5770         * nat/ppc-linux.c: Fix common/ includes.
5771         * nat/mips-linux-watch.h: Fix common/ includes.
5772         * nat/mips-linux-watch.c: Fix common/ includes.
5773         * nat/linux-waitpid.c: Fix common/ includes.
5774         * nat/linux-ptrace.h: Fix common/ includes.
5775         * nat/linux-ptrace.c: Fix common/ includes.
5776         * nat/linux-procfs.c: Fix common/ includes.
5777         * nat/linux-personality.c: Fix common/ includes.
5778         * nat/linux-osdata.c: Fix common/ includes.
5779         * nat/linux-namespaces.c: Fix common/ includes.
5780         * nat/linux-btrace.h: Fix common/ includes.
5781         * nat/linux-btrace.c: Fix common/ includes.
5782         * nat/fork-inferior.c: Fix common/ includes.
5783         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5784         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5785         * nat/aarch64-linux.c: Fix common/ includes.
5786         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5787         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5788         * namespace.h: Fix common/ includes.
5789         * mips-linux-tdep.c: Fix common/ includes.
5790         * minsyms.c: Fix common/ includes.
5791         * mi/mi-parse.h: Fix common/ includes.
5792         * mi/mi-main.c: Fix common/ includes.
5793         * mi/mi-cmd-env.c: Fix common/ includes.
5794         * memrange.h: Fix common/ includes.
5795         * memattr.c: Fix common/ includes.
5796         * maint.h: Fix common/ includes.
5797         * maint.c: Fix common/ includes.
5798         * main.c: Fix common/ includes.
5799         * machoread.c: Fix common/ includes.
5800         * location.c: Fix common/ includes.
5801         * linux-thread-db.c: Fix common/ includes.
5802         * linux-nat.c: Fix common/ includes.
5803         * linux-fork.c: Fix common/ includes.
5804         * inline-frame.c: Fix common/ includes.
5805         * infrun.c: Fix common/ includes.
5806         * inflow.c: Fix common/ includes.
5807         * inferior.h: Fix common/ includes.
5808         * inferior.c: Fix common/ includes.
5809         * infcmd.c: Fix common/ includes.
5810         * inf-ptrace.c: Fix common/ includes.
5811         * inf-child.c: Fix common/ includes.
5812         * ia64-linux-nat.c: Fix common/ includes.
5813         * i387-tdep.c: Fix common/ includes.
5814         * i386-tdep.c: Fix common/ includes.
5815         * i386-linux-tdep.c: Fix common/ includes.
5816         * i386-linux-nat.c: Fix common/ includes.
5817         * i386-go32-tdep.c: Fix common/ includes.
5818         * i386-fbsd-tdep.c: Fix common/ includes.
5819         * i386-fbsd-nat.c: Fix common/ includes.
5820         * guile/scm-type.c: Fix common/ includes.
5821         * guile/guile.c: Fix common/ includes.
5822         * go32-nat.c: Fix common/ includes.
5823         * gnu-nat.c: Fix common/ includes.
5824         * gdbthread.h: Fix common/ includes.
5825         * gdbarch-selftests.c: Fix common/ includes.
5826         * gdb_usleep.c: Fix common/ includes.
5827         * gdb_select.h: Fix common/ includes.
5828         * gdb_bfd.c: Fix common/ includes.
5829         * gcore.c: Fix common/ includes.
5830         * fork-child.c: Fix common/ includes.
5831         * findvar.c: Fix common/ includes.
5832         * fbsd-nat.c: Fix common/ includes.
5833         * event-top.c: Fix common/ includes.
5834         * event-loop.c: Fix common/ includes.
5835         * dwarf2read.c: Fix common/ includes.
5836         * dwarf2loc.c: Fix common/ includes.
5837         * dwarf2-frame.c: Fix common/ includes.
5838         * dwarf-index-cache.c: Fix common/ includes.
5839         * dtrace-probe.c: Fix common/ includes.
5840         * disasm-selftests.c: Fix common/ includes.
5841         * defs.h: Fix common/ includes.
5842         * csky-tdep.c: Fix common/ includes.
5843         * cp-valprint.c: Fix common/ includes.
5844         * cp-support.h: Fix common/ includes.
5845         * cp-support.c: Fix common/ includes.
5846         * corelow.c: Fix common/ includes.
5847         * completer.h: Fix common/ includes.
5848         * completer.c: Fix common/ includes.
5849         * compile/compile.c: Fix common/ includes.
5850         * compile/compile-loc2c.c: Fix common/ includes.
5851         * compile/compile-cplus-types.c: Fix common/ includes.
5852         * compile/compile-cplus-symbols.c: Fix common/ includes.
5853         * command.h: Fix common/ includes.
5854         * cli/cli-dump.c: Fix common/ includes.
5855         * cli/cli-cmds.c: Fix common/ includes.
5856         * charset.c: Fix common/ includes.
5857         * build-id.c: Fix common/ includes.
5858         * btrace.h: Fix common/ includes.
5859         * btrace.c: Fix common/ includes.
5860         * breakpoint.h: Fix common/ includes.
5861         * breakpoint.c: Fix common/ includes.
5862         * ax.h:
5863         (enum agent_op): Fix common/ includes.
5864         * ax-general.c (struct aop_map): Fix common/ includes.
5865         * ax-gdb.c: Fix common/ includes.
5866         * auxv.c: Fix common/ includes.
5867         * auto-load.c: Fix common/ includes.
5868         * arm-tdep.c: Fix common/ includes.
5869         * arch/riscv.c: Fix common/ includes.
5870         * arch/ppc-linux-common.c: Fix common/ includes.
5871         * arch/i386.c: Fix common/ includes.
5872         * arch/arm.c: Fix common/ includes.
5873         * arch/arm-linux.c: Fix common/ includes.
5874         * arch/arm-get-next-pcs.c: Fix common/ includes.
5875         * arch/amd64.c: Fix common/ includes.
5876         * arch/aarch64.c: Fix common/ includes.
5877         * arch/aarch64-insn.c: Fix common/ includes.
5878         * arch-utils.c: Fix common/ includes.
5879         * amd64-windows-tdep.c: Fix common/ includes.
5880         * amd64-tdep.c: Fix common/ includes.
5881         * amd64-sol2-tdep.c: Fix common/ includes.
5882         * amd64-obsd-tdep.c: Fix common/ includes.
5883         * amd64-nbsd-tdep.c: Fix common/ includes.
5884         * amd64-linux-tdep.c: Fix common/ includes.
5885         * amd64-linux-nat.c: Fix common/ includes.
5886         * amd64-fbsd-tdep.c: Fix common/ includes.
5887         * amd64-fbsd-nat.c: Fix common/ includes.
5888         * amd64-dicos-tdep.c: Fix common/ includes.
5889         * amd64-darwin-tdep.c: Fix common/ includes.
5890         * agent.c: Fix common/ includes.
5891         * ada-lang.h: Fix common/ includes.
5892         * ada-lang.c: Fix common/ includes.
5893         * aarch64-tdep.c: Fix common/ includes.
5894
5895 2019-01-25  Tom Tromey  <tom@tromey.com>
5896
5897         * common/create-version.sh: Use common/version.h.
5898
5899 2019-01-24  Pedro Alves  <palves@redhat.com>
5900
5901         * infrun.c (signal_stop, signal_print, signal_program)
5902         (signal_catch, signal_pass): Now arrays instead of pointers.
5903         (update_signals_program_target, do_target_resume)
5904         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5905         * linux-nat.c (linux_nat_target::pass_signals)
5906         (linux_nat_target::create_inferior, linux_nat_target::attach):
5907         Adjust.
5908         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5909         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5910         * procfs.c (procfs_target::pass_signals): Adjust.
5911         * record-full.c (record_full_target::resume): Adjust.
5912         * remote.c (remote_target::pass_signals)
5913         (remote_target::program_signals): Adjust.
5914         * target-debug.h (target_debug_print_signals): Now takes a
5915         gdb::array_view as parameter.  Adjust.
5916         * target.h (target_ops) <pass_signals, program_signals>: Replace
5917         pointer and length parameters with gdb::array_view.
5918         (target_pass_signals, target_program_signals): Likewise.
5919         * target-delegates.c: Regenerate.
5920
5921 2019-01-24  Pedro Alves  <palves@redhat.com>
5922
5923         * common/forward-scope-exit.h
5924         (forward_scope_exit::forward_scope_exit): Pass arguments to
5925         m_bind_function directly, instead of creating a std::bind and
5926         copying that.
5927
5928 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5929
5930         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5931         for static members.
5932         (pass_in_v_vfp_candidate): Likewise.
5933
5934 2019-01-23  Tom Tromey  <tom@tromey.com>
5935             Pedro Alves  <palves@redhat.com>
5936
5937         * regcache.c (class regcache_invalidator): Remove.
5938         (regcache::raw_write): Use make_scope_exit.
5939
5940 2019-01-23  Tom Tromey  <tom@tromey.com>
5941
5942         * ui-out.h (class ui_out_emit_type): Update comment.
5943
5944 2019-01-23  Tom Tromey  <tom@tromey.com>
5945
5946         * infrun.c (fetch_inferior_event): Update comment.
5947
5948 2019-01-23  Tom Tromey  <tom@tromey.com>
5949             Pedro Alves  <palves@redhat.com>
5950
5951         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5952         parameter.
5953         (fetch_inferior_event): Use SCOPE_EXIT.
5954
5955
5956 2019-01-23  Tom Tromey  <tom@tromey.com>
5957             Pedro Alves  <palves@redhat.com>
5958
5959         * infrun.c (disable_thread_events): Delete.
5960         (stop_all_threads): Use SCOPE_EXIT.
5961
5962 2019-01-23  Tom Tromey  <tom@tromey.com>
5963             Pedro Alves  <palves@redhat.com>
5964
5965         * symfile.c: Include forward-scope-exit.h.
5966         (clear_symtab_users_cleanup): Replace forward declaration with
5967         a FORWARD_SCOPE_EXIT.
5968         (syms_from_objfile_1): Use the forward_scope_exit and
5969         gdb::optional instead of cleanup_function.
5970         (reread_symbols): Use the forward_scope_exit instead of
5971         cleanup_function.
5972         (clear_symtab_users_cleanup): Remove function.
5973
5974 2019-01-23  Tom Tromey  <tom@tromey.com>
5975             Pedro Alves  <palves@redhat.com>
5976
5977         * linux-nat.c: Include scope-exit.h.
5978         (cleanup_target_stop): Remove.
5979         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5980         SCOPE_EXIT.
5981
5982 2019-01-23  Tom Tromey  <tom@tromey.com>
5983             Pedro Alves  <palves@redhat.com>
5984
5985         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5986         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5987
5988 2019-01-23  Tom Tromey  <tom@tromey.com>
5989             Andrew Burgess  <andrew.burgess@embecosm.com>
5990             Pedro Alves  <palves@redhat.com>
5991
5992         * infrun.c (fetch_inferior_event): Use scope_exit.
5993         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5994         * top.c (execute_command): Use scope_exit.
5995         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5996         * utils.c (do_bpstat_clear_actions_cleanup)
5997         (make_bpstat_clear_actions_cleanup): Remove.
5998
5999 2019-01-23  Tom Tromey  <tom@tromey.com>
6000             Pedro Alves  <palves@redhat.com>
6001
6002         * infrun.c: Include "common/scope-exit.h"
6003         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6004         (wait_for_inferior): Use SCOPE_EXIT.
6005         (fetch_inferior_event): Use scope_exit.
6006
6007 2019-01-23  Tom Tromey  <tom@tromey.com>
6008             Pedro Alves  <palves@redhat.com>
6009
6010         * breakpoint.c (create_breakpoint): Remove cleanup.
6011
6012 2019-01-23  Tom Tromey  <tom@tromey.com>
6013             Andrew Burgess  <andrew.burgess@embecosm.com>
6014             Pedro Alves  <palves@redhat.com>
6015
6016 2019-01-23  Pedro Alves  <palves@redhat.com>
6017
6018         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6019
6020 2019-01-23  Pedro Alves  <palves@redhat.com>
6021             Andrew Burgess  <andrew.burgess@embecosm.com>
6022
6023         * gdbthread.h: Include "common/forward-scope-exit.h".
6024         (scoped_finish_thread_state): Redefine custom class in terms of
6025         forward_scope_exit.
6026
6027 2019-01-23  Pedro Alves  <palves@redhat.com>
6028             Andrew Burgess  <andrew.burgess@embecosm.com>
6029
6030         * common/forward-scope-exit.h: New file.
6031
6032 2019-01-23  Pedro Alves  <palves@redhat.com>
6033             Andrew Burgess  <andrew.burgess@embecosm.com>
6034             Tom Tromey  <tom@tromey.com>
6035
6036         * common/scope-exit.h: New file.
6037
6038 2019-01-23  Pedro Alves  <palves@redhat.com>
6039
6040         * common/preprocessor.h (ESC): Rename to ...
6041         (ESC_PARENS): ... this.
6042         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6043         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6044
6045 2019-01-23  Tom Tromey  <tom@tromey.com>
6046
6047         * language.h (class scoped_switch_to_sym_language_if_auto):
6048         Initialize m_lang in both cases.
6049
6050 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6051
6052         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6053         with XCNEW.
6054
6055 2019-01-22  Tom Tromey  <tom@tromey.com>
6056
6057         * corelow.c: Do not include sys/file.h.
6058
6059 2019-01-22  Tom Tromey  <tom@tromey.com>
6060
6061         * tui/tui-wingeneral.h: Include gdb_curses.h.
6062
6063 2019-01-22  Tom Tromey  <tom@tromey.com>
6064
6065         * source-cache.h (class source_cache) <get_source_lines,
6066         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6067
6068 2019-01-22  Tom Tromey  <tom@tromey.com>
6069
6070         * remote-fileio.h (struct remote_target): Declare.
6071
6072 2019-01-22  Tom Tromey  <tom@tromey.com>
6073
6074         * python/py-arch.c: Do not include py-ref.h.
6075         * python/py-bpevent.c: Do not include py-ref.h.
6076         * python/py-cmd.c: Do not include py-ref.h.
6077         * python/py-continueevent.c: Do not include py-ref.h.
6078         * python/py-event.h: Do not include py-ref.h.
6079         * python/py-evtregistry.c: Do not include py-ref.h.
6080         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6081         * python/py-frame.c: Do not include py-ref.h.
6082         * python/py-framefilter.c: Do not include py-ref.h.
6083         * python/py-function.c: Do not include py-ref.h.
6084         * python/py-infevents.c: Do not include py-ref.h.
6085         * python/py-linetable.c: Do not include py-ref.h.
6086         * python/py-objfile.c: Do not include py-ref.h.
6087         * python/py-param.c: Do not include py-ref.h.
6088         * python/py-prettyprint.c: Do not include py-ref.h.
6089         * python/py-progspace.c: Do not include py-ref.h.
6090         * python/py-symbol.c: Do not include py-ref.h.
6091         * python/py-symtab.c: Do not include py-ref.h.
6092         * python/py-type.c: Do not include py-ref.h.
6093         * python/py-unwind.c: Do not include py-ref.h.
6094         * python/py-utils.c: Do not include py-ref.h.
6095         * python/py-value.c: Do not include py-ref.h.
6096         * python/py-varobj.c: Do not include py-ref.h.
6097         * python/py-xmethods.c: Do not include py-ref.h.
6098         * python/python.c: Do not include py-ref.h.
6099         * varobj.c: Do not include py-ref.h.
6100
6101 2019-01-22  Tom Tromey  <tom@tromey.com>
6102
6103         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6104         keyword for bcache.
6105
6106 2019-01-22  Tom Tromey  <tom@tromey.com>
6107
6108         * compile/compile-cplus-types.c: Remove a comment by #include.
6109
6110 2019-01-22  Tom Tromey  <tom@tromey.com>
6111
6112         * compile/gcc-c-plugin.h: Include compile-internal.h.
6113
6114 2019-01-22  Tom Tromey  <tom@tromey.com>
6115
6116         * stabsread.c (EXTERN): Do not define.
6117         (symnum, next_symbol_text_func, processing_gcc_compilation)
6118         (within_function, global_sym_chain, global_stabs)
6119         (previous_stab_code, this_object_header_files)
6120         (n_this_object_header_files)
6121         (n_allocated_this_object_header_files): Define.
6122         * stabsread.h (EXTERN): Never define.  Use "extern".
6123
6124 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6125
6126         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6127         history_value.
6128
6129 2019-01-21  Tom Tromey  <tom@tromey.com>
6130
6131         * ui-out.c: Fix includes.
6132         * tui/tui-source.c: Fix includes.
6133         * target.c: Fix includes.
6134         * remote.c: Fix includes.
6135         * regcache.c: Fix includes.
6136         * python/py-block.c: Fix includes.
6137         * printcmd.c: Fix includes.
6138         * or1k-tdep.c: Fix includes.
6139         * mi/mi-main.c: Fix includes.
6140         * m32r-tdep.c: Fix includes.
6141         * csky-tdep.c: Fix includes.
6142         * compile/compile-cplus-types.c: Fix includes.
6143         * cli/cli-interp.c: Fix includes.
6144
6145 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6146
6147         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6148         for padding.
6149
6150 2019-01-16  Tom Tromey  <tom@tromey.com>
6151
6152         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6153         earlier.
6154         (struct objfile) <msymbols_range>: Move from top level.
6155         <msymbols>: New method.
6156         (class objfile_msymbols): Remove.
6157         * symtab.c (default_collect_symbol_completion_matches_break_on):
6158         Update.
6159         * symmisc.c (dump_msymbols): Update.
6160         * stabsread.c (scan_file_globals): Update.
6161         * objc-lang.c (info_selectors_command, info_classes_command)
6162         (find_methods): Update.
6163         * minsyms.c (find_solib_trampoline_target): Update.
6164         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6165         * coffread.c (coff_symfile_read): Update.
6166         * ada-lang.c (ada_lookup_simple_minsym)
6167         (ada_collect_symbol_completion_matches): Update.
6168
6169 2019-01-16  Tom Tromey  <tom@tromey.com>
6170
6171         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6172         type.  Remove no-argument constructor.
6173         <iterator::operator++>: Simplify.
6174         <begin>: Update.
6175         <end>: Use minimal_symbol_count.
6176
6177 2019-01-16  Tom Tromey  <tom@tromey.com>
6178
6179         * objfiles.h (struct objfile) <psymtabs>: New method.
6180         (class objfile_psymtabs): Remove.
6181         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6182         typedef.
6183         <range>: New method.
6184         (require_partial_symbols): Change return type.
6185         * psymtab.c (require_partial_symbols)
6186         (psym_expand_symtabs_matching): Update.
6187         * mdebugread.c (parse_partial_symbols): Update.
6188         * dbxread.c (dbx_end_psymtab): Update.
6189
6190 2019-01-15  Tom Tromey  <tom@tromey.com>
6191
6192         * symtab.c (lookup_objfile_from_block)
6193         (lookup_symbol_in_objfile_symtabs)
6194         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6195         (find_line_symtab, info_sources_command)
6196         (default_collect_symbol_completion_matches_break_on)
6197         (make_source_files_completion_list): Update.
6198         * symmisc.c (print_objfile_statistics, dump_objfile)
6199         (maintenance_print_symbols, maintenance_info_symtabs)
6200         (maintenance_check_symtabs, maintenance_info_line_tables):
6201         Update.
6202         * source.c (select_source_symtab)
6203         (forget_cached_source_info_for_objfile): Update.
6204         * objfiles.h (class objfile_compunits): Remove.
6205         (struct objfile) <compunits_range>: New typedef.
6206         (compunits): New method.
6207         * objfiles.c (objfile_relocate1): Update.
6208         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6209         * maint.c (count_symtabs_and_blocks): Update.
6210         * linespec.c (iterate_over_all_matching_symtabs): Update.
6211         * cp-support.c (add_symbol_overload_list_qualified): Update.
6212         * coffread.c (coff_symtab_read): Update.
6213         * ada-lang.c (add_nonlocal_symbols)
6214         (ada_collect_symbol_completion_matches)
6215         (ada_add_global_exceptions): Update.
6216
6217 2019-01-15  Tom Tromey  <tom@tromey.com>
6218
6219         * progspace.h (program_space) <objfiles_safe_range>: New
6220         typedef.
6221         <objfiles_safe>: New method.
6222         * objfiles.h (class all_objfiles_safe): Remove.
6223         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6224         * jit.c (jit_inferior_exit_hook): Update.
6225
6226 2019-01-17  Tom Tromey  <tom@tromey.com>
6227
6228         * progspace.h (program_space) <objfiles_range>: New typedef.
6229         <objfiles>: New method.
6230         <objfiles_head>: Rename from objfiles.
6231         (object_files): Update.
6232         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6233         * guile/scm-pretty-print.c
6234         (ppscm_find_pretty_printer_from_objfiles): Update.
6235         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6236         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6237         Update.
6238         * python/py-progspace.c (pspy_get_objfiles): Update.
6239         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6240         Update.
6241         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6242         (objfpy_lookup_objfile_by_build_id): Update.
6243         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6244         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6245         Update.
6246         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6247         (expand_symtab_containing_pc, lookup_objfile_from_block)
6248         (lookup_static_symbol, basic_lookup_transparent_type)
6249         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6250         (find_line_symtab, info_sources_command)
6251         (default_collect_symbol_completion_matches_break_on)
6252         (make_source_files_completion_list, find_main_name): Update.
6253         * symmisc.c (print_symbol_bcache_statistics)
6254         (print_objfile_statistics, maintenance_print_symbols)
6255         (maintenance_print_msymbols, maintenance_print_objfiles)
6256         (maintenance_info_symtabs, maintenance_check_symtabs)
6257         (maintenance_expand_symtabs, maintenance_info_line_tables):
6258         Update.
6259         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6260         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6261         (map_overlay_command, unmap_overlay_command)
6262         (simple_overlay_update, expand_symtabs_matching)
6263         (map_symbol_filenames): Update.
6264         * symfile-debug.c (set_debug_symfile): Update.
6265         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6266         Update.
6267         * source.c (select_source_symtab, forget_cached_source_info):
6268         Update.
6269         * solib.c (solib_read_symbols): Update.
6270         * solib-spu.c (append_ocl_sos): Update.
6271         * psymtab.c (maintenance_print_psymbols)
6272         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6273         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6274         * printcmd.c (info_symbol_command): Update.
6275         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6276         Update.
6277         * objfiles.h (class all_objfiles): Remove.
6278         * objfiles.c (have_partial_symbols, have_full_symbols)
6279         (have_minimal_symbols, qsort_cmp, update_section_map)
6280         (shared_objfile_contains_address_p)
6281         (default_iterate_over_objfiles_in_search_order): Update.
6282         * objc-lang.c (info_selectors_command, info_classes_command)
6283         (find_methods): Update.
6284         * minsyms.c (find_solib_trampoline_target): Update.
6285         * maint.c (maintenance_info_sections)
6286         (maintenance_translate_address, count_symtabs_and_blocks):
6287         Update.
6288         * main.c (captured_main_1): Update.
6289         * linux-thread-db.c (try_thread_db_load_from_pdir)
6290         (has_libpthread): Update.
6291         * linespec.c (iterate_over_all_matching_symtabs)
6292         (search_minsyms_for_name): Update.
6293         * jit.c (jit_find_objf_with_entry_addr): Update.
6294         * hppa-tdep.c (find_unwind_entry)
6295         (hppa_lookup_stub_minimal_symbol): Update.
6296         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6297         Update.
6298         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6299         (elf_gnu_ifunc_resolve_by_got): Update.
6300         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6301         * dwarf-index-write.c (save_gdb_index_command): Update.
6302         * cp-support.c (add_symbol_overload_list_qualified): Update.
6303         * breakpoint.c (create_overlay_event_breakpoint)
6304         (create_longjmp_master_breakpoint)
6305         (create_std_terminate_master_breakpoint)
6306         (create_exception_master_breakpoint): Update.
6307         * blockframe.c (find_pc_partial_function): Update.
6308         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6309         (ada_collect_symbol_completion_matches)
6310         (ada_add_global_exceptions): Update.
6311
6312 2019-01-17  Tom Tromey  <tom@tromey.com>
6313
6314         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6315         declare VEC.
6316         (solib_target_parse_libraries): Change return type.
6317         (library_list_start_segment, library_list_start_section)
6318         (library_list_end_library, library_list_start_library); Update.
6319         (solib_target_free_library_list): Remove.
6320         (solib_target_parse_libraries): Remove cleanup.  Change return
6321         type.
6322         (solib_target_current_sos): Update.
6323
6324 2019-01-17  Tom Tromey  <tromey@bapiya>
6325
6326         * valprint.c: Replace "the the" with "the".
6327         * symtab.c: Replace "the the" with "the".
6328         * solib.c: Replace "the the" with "the".
6329         * solib-dsbt.c: Replace "the the" with "the".
6330         * linespec.c: Replace "the the" with "the".
6331         * dwarf2loc.h: Replace "the the" with "the".
6332         * amd64-windows-tdep.c: Replace "the the" with "the".
6333         * aarch64-tdep.c: Replace "the the" with "the".
6334
6335 2019-01-16  Keith Seitz  <keiths@redhat.com>
6336
6337         PR gdb/23773
6338         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6339         <builder>: Rename to ..
6340         <m_builder>: ... this and make private.
6341         (dwarf2_cu::get_builder): New method.  Change all users of
6342         `builder' to use this method.
6343         (dwarf2_start_symtab): Move to ...
6344         (dwarf2_cu::start_symtab): ... here.  Update all callers
6345         (setup_type_unit_groups): Move to ...
6346         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6347         callers.
6348         (dwarf2_cu::reset_builder): New method.
6349         (process_full_compunit, process_full_type_unit): Use
6350         dwarf2_cu::reset_builder.
6351         (follow_die_offset): Record the ancestor CU if it is different
6352         from the followed DIE's CU.
6353         (follow_die_sig_1): Likewise.
6354
6355 2019-01-15  Tom Tromey  <tom@tromey.com>
6356
6357         * remote.c (class remote_state) <buf>: Now a char_vector.
6358         <buf_size>: Remove.
6359         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6360         parameter.
6361         (remote_target::getpkt_or_notif_sane_1)
6362         (remote_target::getpkt_sane)
6363         (remote_target::getpkt_or_notif_sane): Likewise.
6364         (class remote_target) <putpkt>: New overload.
6365         (remote_target::read_frame): Change type of "buf_p".  Remove
6366         sizeof_p parameter.
6367         (packet_ok): New overload.
6368         (packet_check_result): New overload.
6369         Update all uses.
6370
6371 2019-01-14  Tom Tromey  <tom@tromey.com>
6372
6373         * remote-notif.c (handle_notification, remote_notif_ack)
6374         (remote_notif_parse): Make "buf" const.
6375         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6376         const.
6377         (remote_notif_parse, remote_notif_ack, handle_notification):
6378         Likewise.
6379         * remote.c (remote_notif_stop_parse): Make "buf" const.
6380         (remote_target::remote_parse_stop_reply): Make "buf" const.
6381         (remote_notif_stop_ack): Make "buf" const.
6382
6383 2019-01-14  Tom Tromey  <tom@tromey.com>
6384
6385         * remote.c (remote_console_output): Make parameter const.
6386
6387 2019-01-14  Tom Tromey  <tom@tromey.com>
6388
6389         * target-debug.h (target_debug_print_signals): Constify.
6390         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6391         * procfs.c (procfs_target::pass_signals): Update.
6392         * linux-nat.c (linux_nat_target::pass_signals): Update.
6393         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6394         * target-delegates.c: Rebuild.
6395         * remote.c (remote_target::program_signals): Update.
6396         (remote_target::pass_signals): Update.
6397         * target.c (target_pass_signals): Constify argument.
6398         (target_program_signals): Likewise.
6399         * target.h (struct target_ops) <pass_signals, program_signals>:
6400         Constify argument.
6401         (target_pass_signals, target_program_signals): Constify argument.
6402
6403 2019-01-14  Tom Tromey  <tom@tromey.com>
6404
6405         PR tui/28819:
6406         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6407
6408 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6409
6410         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6411         field.
6412         * rs6000-tdep.c: Include reggroups.h.
6413         (IS_V_ALIAS_PSEUDOREG): Define.
6414         (rs6000_register_name): Return names for the "vX" aliases.
6415         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6416         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6417         aliases.  Call default_register_reggroup_p for all other
6418         pseudo-registers.
6419         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6420         New functions.
6421         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6422         Handle "vX" aliases.
6423         (v_alias_pseudo_register_collect): New function.
6424         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6425         (rs6000_gdbarch_init): Initialize "vX" aliases as
6426         pseudo-registers.  Restore registration of
6427         rs6000_pseudo_register_reggroup_p with
6428         set_tdesc_pseudo_register_reggroup_p.
6429
6430 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6431
6432         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6433         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6434         set_gdbarch_num_pseudo_regs.
6435
6436 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6437
6438         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6439         Remove arg prefixname, add do_set and do_show.
6440         Add member functions set_list and show_list.
6441         * cli/cli-style.c (class cli_style_option): Update accordingly.
6442         (style_set_list): Move to file scope.
6443         (style_show_list): Likewise.
6444         (set_style): Call help_list.
6445         (show_style): Call cmd_show_list.
6446         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6447         Update to use the new macro.
6448
6449 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6450
6451         * ada-lang.c (_initialize_ada_language): Expand the help text
6452         for the "catch exception" command.
6453
6454 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6455
6456         * symtab.c (matching_obj_sections): Initialize obj,
6457         declare it closer to its usage.
6458
6459 2019-01-10  Tom Tromey  <tom@tromey.com>
6460
6461         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6462         (basic_inf_threads_range): Remove.
6463         (inf_threads_range, inf_non_exited_threads_range)
6464         (safe_inf_threads_range): Use next_adapter.
6465
6466 2019-01-10  Keith Seitz  <keiths@redhat.com>
6467
6468         PR gdb/23712
6469         PR symtab/23010
6470         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6471         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6472
6473 2019-01-10  Keith Seitz  <keiths@redhat.com>
6474
6475         PR gdb/23712
6476         PR symtab/23010
6477         * dictionary.c (pending_to_vector): Remove.
6478         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6479         Remove _1 suffix, replacing functions of the same name.  Update
6480         all callers.
6481         (dict_create_hashed, dict_create_hashed_expandable)
6482         (dict_create_linear, dict_create_linear_expandable, dict_free)
6483         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6484         Make functions static.
6485
6486 2019-01-10  Keith Seitz  <keiths@redhat.com>
6487
6488         PR gdb/23712
6489         PR symtab/23010
6490         * dictionary.h (struct dictionary): Replace declaration with
6491         multidictionary.
6492         (dict_create_hashed, dict_create_hashed_expandable)
6493         (dict_create_linear, dict_create_linear_expandable)
6494         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6495         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6496         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6497         taking multidictionary argument.
6498         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6499         * block.h (struct block) <dict>: Change to multidictionary
6500         and rename `multidict'.
6501         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6502         symmisc.c: Update all dictionary references to multidictionary.
6503
6504 2019-01-10  Keith Seitz  <keiths@redhat.com>
6505
6506         PR gdb/23712
6507         PR symtab/23010
6508         * dictionary.c: Include unordered_map.
6509         (pending_to_vector): New function.
6510         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6511         Rewrite the non-"_1" functions to take vector instead
6512         of linked list.
6513         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6514         "new" _1 versions of the same name.
6515         (multidictionary): Define.
6516         (std::hash<enum language): New definition.
6517         (collate_pending_symbols_by_language, mdict_create_hashed)
6518         (mdict_create_hashed_expandable, mdict_create_linear)
6519         (mdict_create_linear_expandable, mdict_free)
6520         (find_language_dictionary, create_new_language_dictionary)
6521         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6522         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6523         (mdict_size, mdict_empty): New functions.
6524         * dictionary.h (mdict_iterator): Define.
6525
6526 2019-01-10  Pedro Alves  <palves@redhat.com>
6527
6528         * breakpoint.c (read_uploaded_action)
6529         (create_tracepoint_from_upload): Adjust to use
6530         gdb::unique_xmalloc_ptr.
6531         * ctf.c (ctf_write_uploaded_tp):
6532         (SET_ARRAY_FIELD): Use emplace_back.
6533         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6534         * tracefile-tfile.c (tfile_write_uploaded_tp):
6535         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6536         gdb::unique_xmalloc_ptr.
6537         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6538         at_string, cond_string, cmd_strings>: Replace char pointers
6539         with gdb::unique_xmalloc_ptr.
6540
6541 2019-01-10  Pedro Alves  <palves@redhat.com>
6542
6543         * solib-target.c (library_list_start_library): Don't xstrdup name.
6544
6545 2019-01-10  Pedro Alves  <palves@redhat.com>
6546
6547         * mdebugread.c (parse_partial_symbols): Use
6548         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6549
6550 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6551
6552         * linux-fork.c (scoped_switch_fork_info)
6553         <~scoped_switch_fork_info>: Fix incorrect variable name.
6554
6555 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6556
6557         * linux-fork.c (scoped_switch_fork_info)
6558         <scoped_switch_fork_info>: Make explicit.
6559         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6560
6561 2019-01-10  Tom Tromey  <tom@tromey.com>
6562
6563         * objfiles.h (objfile::reset_psymtabs): Update.
6564         * objfiles.c (objfile::objfile): Update.
6565         * psymtab.h (psymtab_storage::obstack): Update.
6566         (psymtab_storage::m_obstack): Use gdb::optional.
6567         (class psymtab_storage): Update comment.  Remove objfile
6568         parameter.
6569         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6570
6571 2019-01-10  Tom Tromey  <tom@tromey.com>
6572
6573         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6574         <free_psymtabs>: Now private.
6575         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6576         (allocate_psymtab): Use new method.
6577
6578 2019-01-10  Tom Tromey  <tom@tromey.com>
6579
6580         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6581         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6582         * mdebugread.c (parse_partial_symbols): Use
6583         allocate_dependencies.
6584         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6585         allocate_dependencies.
6586         (process_psymtab_comp_unit_reader)
6587         (build_type_psymtab_dependencies): Likewise.
6588         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6589
6590 2019-01-10  Tom Tromey  <tom@tromey.com>
6591
6592         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6593         PSYMBOL_SET_LANGUAGE.
6594         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6595
6596 2019-01-10  Tom Tromey  <tom@tromey.com>
6597
6598         * psymtab.h (psymtab_storage::obstack): New method.
6599         <m_obstack>: Rename from obstack; now private.
6600         * psymtab.c (psymtab_storage): Update.
6601         * dwarf2read.c (create_addrmap_from_index)
6602         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6603         Update.
6604
6605 2019-01-10  Tom Tromey  <tom@tromey.com>
6606
6607         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6608         * objfiles.h (objfile::reset_psymtabs): New method.
6609
6610 2019-01-10  Tom Tromey  <tom@tromey.com>
6611
6612         * symmisc.c (print_symbol_bcache_statistics): Update.
6613         (print_objfile_statistics): Update.
6614         * symfile.c (reread_symbols): Update.
6615         * psymtab.h (class psymtab_storage): New.
6616         * psymtab.c (psymtab_storage): New constructor.
6617         (~psymtab_storage): New destructor.
6618         (require_partial_symbols): Update.
6619         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6620         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6621         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6622         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6623         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6624         (start_psymtab_common, end_psymtab_common)
6625         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6626         (allocate_psymtab): Update.
6627         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6628         Update.
6629         (dump_psymtab_addrmap, maintenance_print_psymbols)
6630         (maintenance_check_psymtabs): Update.
6631         (class objfile_psymtabs): Move to objfiles.h.
6632         * psympriv.h (discard_psymtab): Now inline.
6633         (psymtab_discarder::psymtab_discarder): Update.
6634         (psymtab_discarder::~psymtab_discarder): Update.
6635         (ALL_OBJFILE_PSYMTABS): Rewrite.
6636         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6637         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6638         Remove fields.
6639         <partial_symtabs>: New field.
6640         (class objfile_psymtabs): Move from psymtab.h.  Update.
6641         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6642         psymbol_cache.
6643         (objfile::~objfile): Don't destroy psymbol_cache.
6644         * mdebugread.c (parse_partial_symbols): Update.
6645         * dwarf2read.c (create_addrmap_from_index)
6646         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6647         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6648         (add_partial_subprogram, dwarf2_ranges_read): Update.
6649         * dwarf-index-write.c (write_address_map)
6650         (write_one_signatured_type, recursively_write_psymbols)
6651         (class debug_names, class debug_names, write_psymtabs_to_index):
6652         Update.
6653
6654 2019-01-10  Tom Tromey  <tom@tromey.com>
6655
6656         * symtab.h (SYMBOL_SET_NAMES): Update.
6657         (symbol_set_names): Update.
6658         (MSYMBOL_SET_NAMES): Update.
6659         * symtab.c (symbol_set_names): Change argument to be an
6660         objfile_per_bfd_storage.
6661         * psymtab.c (add_psymbol_to_bcache): Update.
6662         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6663
6664 2019-01-10  Tom Tromey  <tom@tromey.com>
6665
6666         * symtab.c (create_demangled_names_hash): Change argument to be an
6667         objfile_per_bfd_storage.
6668         (symbol_set_names): Update.
6669
6670 2019-01-10  Tom Tromey  <tom@tromey.com>
6671
6672         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6673         init_psymbol_list.
6674         * psymtab.c (init_psymbol_list): Do nothing if already called.
6675         * psympriv.h (init_psymbol_list): Add comment.
6676         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6677         init_psymbol_list.
6678         * dbxread.c (dbx_symfile_read): Unconditionally call
6679         init_psymbol_list.
6680
6681 2019-01-10  Tom Tromey  <tom@tromey.com>
6682
6683         * xcoffread.c (scan_xcoff_symtab): Update.
6684         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6685         "where".
6686         * mdebugread.c (parse_partial_symbols)
6687         (handle_psymbol_enumerators): Update.
6688         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6689         * dbxread.c (read_dbx_symtab): Update.
6690         * psympriv.h (psymbol_placement): New enum.
6691         (add_psymbol_to_list): Update.
6692
6693 2019-01-10  Tom Tromey  <tom@tromey.com>
6694
6695         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6696         static_psymbols parameters.
6697         (scan_xcoff_symtab): Update.
6698         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6699         static_psymbols parameters.
6700         * psympriv.h (start_psymtab_common): Update.
6701         * mdebugread.c (parse_partial_symbols): Update.
6702         * dwarf2read.c (create_partial_symtab): Update.
6703         * dbxread.c (read_dbx_symtab): Update.
6704         (start_psymtab): Remove global_psymbols and static_psymbols
6705         parameters.
6706
6707 2019-01-10  Tom Tromey  <tom@tromey.com>
6708
6709         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6710         * psymtab.c (allocate_psymtab): Add comment.
6711         * psympriv.h (allocate_psymtab): Add comment.
6712         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6713         initializations.
6714         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6715
6716 2019-01-10  Tom Tromey  <tom@tromey.com>
6717
6718         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6719         Don't declare.
6720         * mipsread.c: Include mdebugread.h.
6721         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6722         Declare.
6723         * elfread.c: Include mdebugread.h.
6724
6725 2019-01-09  Tom Tromey  <tom@tromey.com>
6726
6727         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6728         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6729         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6730         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6731         (psym_lookup_symbol, psym_find_last_source_symtab)
6732         (psym_forget_cached_source_info, psym_print_stats)
6733         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6734         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6735         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6736         (psym_find_compunit_symtab_by_address)
6737         (maintenance_print_psymbols, maintenance_info_psymtabs)
6738         (maintenance_check_psymtabs): Use ranged for.
6739         * psymtab.h (class objfile_psymtabs): New.
6740         (require_partial_symbols): Return objfile_psymtabs.
6741         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6742
6743 2019-01-09  Tom Tromey  <tom@tromey.com>
6744
6745         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6746         (find_pc_mapped_section, list_overlays_command)
6747         (map_overlay_command, unmap_overlay_command)
6748         (simple_overlay_update): Use all_objfiles.
6749         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6750         * printcmd.c (info_symbol_command): Use all_objfiles.
6751         * objfiles.h (ALL_OBJSECTIONS): Remove.
6752         * maint.c (maintenance_translate_address): Use all_objfiles.
6753         * gcore.c (gcore_create_callback): Use all_objfiles.
6754         (objfile_find_memory_regions): Likewise.
6755
6756 2019-01-09  Tom Tromey  <tom@tromey.com>
6757
6758         * symtab.c (find_line_symtab, info_sources_command)
6759         (make_source_files_completion_list): Use objfile_compunits.
6760         * source.c (select_source_symtab): Use objfile_compunits.
6761         * objfiles.h (struct objfile): Update comment.
6762         (ALL_OBJFILES): Remove.
6763         (ALL_FILETABS): Remove.
6764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6765         objfile_compunits.
6766
6767 2019-01-09  Tom Tromey  <tom@tromey.com>
6768
6769         * symmisc.c (print_objfile_statistics, dump_objfile)
6770         (maintenance_print_symbols): Use compunit_filetabs.
6771         * source.c (forget_cached_source_info_for_objfile): Use
6772         compunit_filetabs.
6773         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6774         (ALL_FILETABS): Use compunit_filetabs.
6775         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6776         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6777
6778 2019-01-09  Tom Tromey  <tom@tromey.com>
6779
6780         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6781         (compunit_filetabs): New.
6782         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6783         compunit_filetabs.
6784         (info_sources_command, make_source_files_completion_list): Remove
6785         declaration.
6786         * symmisc.c (print_objfile_statistics, dump_objfile)
6787         (maintenance_print_symbols): Remove declaration.
6788         (maintenance_info_symtabs): Use compunit_filetabs.
6789         (maintenance_info_line_tables): Likewise.
6790         * source.c (select_source_symtab): Change local variable name.
6791         (forget_cached_source_info_for_objfile): Remove declaration.
6792         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6793         * objfiles.c (objfile_relocate1): Remove declaration.
6794         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6795         declaration.
6796         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6797         * coffread.c (coff_symtab_read): Remove declaration.
6798         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6799         compunit_filetabs.
6800
6801 2019-01-09  Tom Tromey  <tom@tromey.com>
6802
6803         * symtab.c (lookup_objfile_from_block)
6804         (find_pc_sect_compunit_symtab, search_symbols)
6805         (default_collect_symbol_completion_matches_break_on): Use
6806         objfile_compunits.
6807         * objfiles.h (ALL_COMPUNITS): Remove.
6808         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6809         * cp-support.c (add_symbol_overload_list_qualified): Use
6810         objfile_compunits.
6811         * ada-lang.c (ada_collect_symbol_completion_matches)
6812         (ada_add_global_exceptions): Use objfile_compunits.
6813
6814 2019-01-09  Tom Tromey  <tom@tromey.com>
6815
6816         * source.c (select_source_symtab)
6817         (forget_cached_source_info_for_objfile): Remove declaration.
6818         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6819         declaration.
6820         * maint.c (count_symtabs_and_blocks): Remove declaration.
6821         * cp-support.c (add_symbol_overload_list_qualified): Remove
6822         declaration.
6823         * coffread.c (coff_symtab_read): Remove declaration.
6824         * symtab.c (lookup_symbol_in_objfile_symtabs)
6825         (basic_lookup_transparent_type_1): Use objfile_compunits.
6826         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6827         (info_sources_command, search_symbols)
6828         (default_collect_symbol_completion_matches_break_on)
6829         (make_source_files_completion_list): Remove declaration.
6830         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6831         (ada_collect_symbol_completion_matches)
6832         (ada_add_global_exceptions): Remove declaration.
6833         * linespec.c (iterate_over_all_matching_symtabs): Use
6834         objfile_compunits.
6835         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6836         (class objfile_compunits): New.
6837         (ALL_COMPUNITS): Use objfile_compunits.
6838         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6839         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6840         objfile_compunits.
6841         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6842
6843 2019-01-09  Tom Tromey  <tom@tromey.com>
6844
6845         * symtab.c (search_symbols)
6846         (default_collect_symbol_completion_matches_break_on): Use
6847         objfile_msymbols.
6848         * ada-lang.c (ada_lookup_simple_minsym)
6849         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6850         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6851         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6852         objfile_msymbols.
6853         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6854         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6855         * objc-lang.c (find_methods): Use objfile_msymbols.
6856         (info_selectors_command, info_classes_command): Likewise.
6857         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6858         * objfiles.h (class objfile_msymbols): New.
6859         (ALL_OBJFILE_MSYMBOLS): Remove.
6860         (ALL_MSYMBOLS): Remove.
6861
6862 2019-01-09  Tom Tromey  <tom@tromey.com>
6863
6864         * common/next-iterator.h (next_adapter): Add Iterator template
6865         parameter.
6866         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6867         (class all_objfiles_safe): New.
6868         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6869         * objfiles.c (put_objfile_before): Update comment.
6870         (add_separate_debug_objfile): Likewise.
6871         (free_all_objfiles): Use all_objfiles_safe.
6872         (objfile_purge_solibs): Likewise.
6873
6874 2019-01-09  Tom Tromey  <tom@tromey.com>
6875
6876         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6877         (expand_symtab_containing_pc, lookup_static_symbol)
6878         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6879         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6880         all_objfiles.
6881         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6882         * breakpoint.c (create_overlay_event_breakpoint)
6883         (create_longjmp_master_breakpoint)
6884         (create_std_terminate_master_breakpoint)
6885         (create_exception_master_breakpoint): Use all_objfiles.
6886         * linux-thread-db.c (try_thread_db_load_from_pdir)
6887         (has_libpthread): Use all_objfiles.
6888         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6889         * linespec.c (iterate_over_all_matching_symtabs)
6890         (search_minsyms_for_name): Use all_objfiles.
6891         * maint.c (maintenance_info_sections): Use all_objfiles.
6892         * main.c (captured_main_1): Use all_objfiles.
6893         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6894         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6895         * guile/scm-pretty-print.c
6896         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6897         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6898         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6899         (maintenance_print_msymbols): Use all_objfiles.
6900         * source.c (select_source_symtab): Use all_objfiles.
6901         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6902         * symfile.c (remove_symbol_file_command)
6903         (expand_symtabs_matching, map_symbol_filenames): Use
6904         all_objfiles.
6905         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6906         all_objfiles.
6907         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6908         * objc-lang.c (find_methods): Use all_objfiles.
6909         * objfiles.c (have_partial_symbols, have_full_symbols)
6910         (have_minimal_symbols, qsort_cmp)
6911         (default_iterate_over_objfiles_in_search_order): Use
6912         all_objfiles.
6913         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6914         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6915         (maintenance_check_psymtabs): Use all_objfiles.
6916         (ALL_PSYMTABS): Remove.
6917         * compile/compile-object-run.c (do_module_cleanup): Use
6918         all_objfiles.
6919         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6920         * cp-support.c (add_symbol_overload_list_qualified): Use
6921         all_objfiles.
6922         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6923         Use all_objfiles.
6924         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6925         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6926         all_objfiles.
6927         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6928         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6929         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6930         Uses all_objfiles.
6931         * solib.c (solib_read_symbols): Use all_objfiles
6932
6933 2019-01-09  Tom Tromey  <tom@tromey.com>
6934
6935         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6936         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6937         all_objfiles.
6938         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6939         * symmisc.c (print_symbol_bcache_statistics)
6940         (print_objfile_statistics, maintenance_print_objfiles)
6941         (maintenance_info_symtabs, maintenance_check_symtabs)
6942         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6943         all_objfiles.
6944         * source.c (forget_cached_source_info): Use all_objfiles.
6945         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6946         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6947         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6948         * objfiles.c (update_section_map): Use all_objfiles.
6949         (shared_objfile_contains_address_p): Likewise.
6950         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6951         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6952
6953 2019-01-09  Tom Tromey  <tom@tromey.com>
6954
6955         * common/next-iterator.h: New file.
6956         * objfiles.h (class all_objfiles): New.
6957         (struct objfile_iterator): New.
6958
6959 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6960
6961         * NEWS: Move the description of the changed "frame", "select-frame",
6962          and "info frame" commands to the Changed commands section.
6963
6964 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6965
6966         * gdbtypes.c (check_stub_method_group): Remove handling of old
6967         mangling schemes.
6968         * linespec.c (find_methods): Likewise.
6969         * stabsread.c (read_member_functions): Likewise.
6970         * valops.c (search_struct_method): Likewise.
6971         (value_struct_elt_for_reference): Likewise.
6972         * NEWS: Mention this change.
6973
6974 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6975
6976         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6977         print_source_lines.
6978         * source.c (print_source_lines_base): Update line number check.
6979         (print_source_lines): New function.
6980         (source_lines_range::source_lines_range): New function.
6981         * source.h (class source_lines_range): New class.
6982         (print_source_lines): New declaration.
6983
6984 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6985
6986         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6987
6988 2019-01-08  Tom Tromey  <tom@tromey.com>
6989             Simon Marchi  <simon.marchi@ericsson.com>
6990
6991         PR gdb/24060
6992         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6993         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6994         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6995         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6996         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6997         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6998
6999 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7000
7001         * source.c (select_source_symtab): Move header comment to
7002         declaration in source.h.
7003         (forget_cached_source_info_for_objfile): Likewise.
7004         (forget_cached_source_info): Likewise.
7005         (identify_source_line): Likewise.
7006         * source.h (identify_source_line): Move declaration from symtab.h
7007         and add comment from source.c
7008         (print_source_lines): Likewise.
7009         (forget_cached_source_info_for_objfile): Likewise.
7010         (forget_cached_source_info): Likewise.
7011         (select_source_symtab): Likewise.
7012         (enum print_source_lines_flag): Move definition from symtab.h.
7013         * symtab.h (identify_source_line): Move declaration to source.h.
7014         (print_source_lines): Likewise.
7015         (forget_cached_source_info_for_objfile): Likewise.
7016         (forget_cached_source_info): Likewise.
7017         (select_source_symtab): Likewise.
7018         (enum print_source_lines_flag): Move definition to source.h.
7019         * tui/tui-hooks.c: Add 'source.h' include.
7020
7021 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7022
7023         * source.c (print_source_lines_base): Handle requests to print
7024         reverse line number sequences, and guard against empty lines
7025         string.
7026
7027 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7028
7029         * source.c (print_source_lines_base): Fix skip of '\r' if next
7030         character is '\n'.
7031
7032 2019-01-06  Tom Tromey  <tom@tromey.com>
7033
7034         * c-exp.y (struct c_parse_state) <macro_original_text,
7035         expansion_obstack>: New member.
7036         (macro_original_text, expansion_obstack): Remove globals.
7037         (scan_macro_expansion, scanning_macro_expansion)
7038         (finished_macro_expansion): Update.
7039         (scan_macro_cleanup): Remove.
7040         (yylex, c_parse): Update.
7041
7042 2019-01-06  Tom Tromey  <tom@tromey.com>
7043
7044         * c-exp.y (struct c_parse_state) <strings>: New member.
7045         (operator_stoken): Update.
7046
7047 2019-01-06  Tom Tromey  <tom@tromey.com>
7048
7049         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7050         (union type_stack_elt) <typelist_val>: Now a pointer to
7051         std::vector.
7052         (type_stack_cleanup): Don't declare.
7053         (push_typelist): Update.
7054         * parse.c (pop_typelist): Return a std::vector.
7055         (push_typelist): Take a std::vector.
7056         (follow_types): Update.  Do not free args.
7057         (type_stack_cleanup): Remove.
7058         * c-exp.y (struct c_parse_state): New.
7059         (cpstate): New global.
7060         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7061         (nonempty_typelist): Update.
7062         (func_mod): Create a new vector.
7063         (c_parse): Create a c_parse_state.
7064         (check_parameter_typelist): Do not delete params.
7065         (function_method): Update.  Do not delete type_list.
7066
7067 2019-01-06  Tom Tromey  <tom@tromey.com>
7068
7069         PR gdb/28155:
7070         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7071         check_typedef.
7072         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7073         (print_return_value): Likewise.
7074
7075 2019-01-05  Tom Tromey  <tom@tromey.com>
7076
7077         * contrib/cleanup_check.py: Remove.
7078         * contrib/gcc-with-excheck: Remove.
7079         * contrib/exsummary.py: Remove.
7080         * contrib/excheck.py: Remove.
7081
7082 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7083
7084         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7085         NULL. Initialize tpprev to NULL instead of assigning it
7086         to NULL on the next statement.
7087         * windows-nat.c (windows_delete_thread): Remove check for
7088         main_thread_id before printing thread exit notifications.
7089         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7090         Remove thread ID check against main_thread_id.
7091         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7092         windows_delete_thread.
7093         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7094
7095 2019-01-04  Tom Tromey  <tom@tromey.com>
7096
7097         * compile/compile.c (_initialize_compile): Use upper case for
7098         metasyntactic variables.
7099         * symmisc.c (_initialize_symmisc): Use upper case for
7100         metasyntactic variables.
7101         * psymtab.c (_initialize_psymtab): Use upper case for
7102         metasyntactic variables.
7103         * demangle.c (demangle_command): Use upper case for metasyntactic
7104         variables.
7105         (_initialize_demangler): Likewise.
7106         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7107         variables.
7108
7109 2019-01-03  Tom Tromey  <tom@tromey.com>
7110
7111         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7112
7113 2019-01-03  Tom Tromey  <tom@tromey.com>
7114
7115         * python/py-symtab.c (salpy_str): Update.
7116         (struct salpy_sal_object) <symtab>: Now a PyObject.
7117         (salpy_dealloc): Update.
7118         (del_objfile_sal): Use gdbpy_ref.
7119
7120 2019-01-03  Tom Tromey  <tom@tromey.com>
7121
7122         * python/py-type.c (convert_field): Use new_reference.  Return
7123         gdbpy_ref.
7124         (make_fielditem): Return gdbpy_ref.
7125         (typy_fields): Update.
7126         (typy_getitem): Update.
7127         (field_name): Return gdbpy_ref.  Use new_reference.
7128         (typy_iterator_iternext): Update.
7129
7130 2019-01-03  Tom Tromey  <tom@tromey.com>
7131
7132         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7133
7134 2019-01-03  Tom Tromey  <tom@tromey.com>
7135
7136         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7137         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7138         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7139         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7140         (pspy_set_type_printers): Likewise.
7141         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7142         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7143         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7144         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7145         (objfpy_set_type_printers): Likewise.
7146
7147 2019-01-03  Tom Tromey  <tom@tromey.com>
7148
7149         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7150         (gdbpy_print_stack): Use gdbpy_err_fetch.
7151         * python/python-internal.h (class gdbpy_err_fetch): New class.
7152         (class gdbpy_enter) <m_error_type, m_error_value,
7153         m_error_traceback>: Remove.
7154         <m_error>: New member.
7155         (gdbpy_exception_to_string): Don't declare.
7156         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7157         * python/py-value.c (convert_value_from_python): Use
7158         gdbpy_err_fetch.
7159         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7160         gdbpy_exception_to_string.
7161         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7162         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7163         gdbpy_err_fetch.
7164
7165 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7166
7167         * linux-nat.c (delete_lwp_cleanup): Delete.
7168         (struct lwp_deleter): New struct.
7169         (lwp_info_up): New typedef.
7170         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7171         lwp_info_up.
7172
7173 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * linux-fork.c (class scoped_switch_fork_info): New class.
7176         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7177
7178 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7179
7180         * valops.c (find_overload_match): Remove use of null_cleanup, and
7181         calls to do_cleanups.
7182
7183 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7184
7185         * compile/compile-cplus-types.c
7186         (compile_cplus_instance::decl_name): Handle changes to
7187         cp_func_name.
7188         * cp-support.c (cp_func_name): Update header comment, update
7189         return type.
7190         * cp-support.h (cp_func_name): Update return type in declaration.
7191         * valops.c (find_overload_match): Move temp_func local to top
7192         level of function and change its type.  Use temp_func to hold and
7193         delete temporary string obtained from cp_func_name.
7194
7195 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7198         gdb::char_vector, remove cleanup, and update uses of `msg`.
7199
7200 2019-01-03  Jim Wilson  <jimw@sifive.com>
7201
7202         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7203
7204 2019-01-02  Tom Tromey  <tom@tromey.com>
7205
7206         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7207         (tdesc_parse_xml): Remove cleanups.
7208         * target-descriptions.h (make_cleanup_free_target_description):
7209         Don't declare.
7210         (target_desc_deleter): New struct.
7211         (target_desc_up): New typedef.
7212         * target-descriptions.c (target_desc_deleter::operator()): Rename
7213         from free_target_description.
7214         (make_cleanup_free_target_description): Remove.
7215
7216 2019-01-02  Tom Tromey  <tom@tromey.com>
7217
7218         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7219         constructor, destructor.
7220         (linespec_parser): Remove typedef.
7221         (~linespec_parser): Rename from linespec_parser_delete.
7222         (linespec_lex_to_end, linespec_complete_label)
7223         (linespec_complete): Update.
7224         (decode_line_full): Remove cleanups.
7225         (decode_line_1): Update.
7226
7227 2019-01-02  Tom Tromey  <tom@tromey.com>
7228
7229         * python/python-internal.h (inferior_to_inferior_object): Change
7230         return type.
7231         * python/py-exitedevent.c (create_exited_event_object): Update.
7232         * python/py-inferior.c (inferior_to_inferior_object): Return
7233         gdbpy_ref.
7234         (python_new_inferior, python_inferior_deleted)
7235         (thread_to_thread_object, delete_thread_object)
7236         (build_inferior_list, gdbpy_selected_inferior): Update.
7237         * python/py-infthread.c (create_thread_object): Update.  Also fail
7238         if inferior_to_inferior_object fails.
7239
7240 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7241
7242         * inferior.h (class inferior) <displaced_step_state>: New field.
7243         * infrun.h (struct displaced_step_state): Move here from
7244         infrun.c.  Initialize fields, add constructor.
7245         <inf>: Remove field.
7246         <reset>: New method.
7247         * infrun.c (struct displaced_step_inferior_state): Move to
7248         infrun.h.
7249         (displaced_step_inferior_states): Remove.
7250         (get_displaced_stepping_state): Adust.
7251         (displaced_step_in_progress_any_inferior): Adjust.
7252         (displaced_step_in_progress_thread): Adjust.
7253         (displaced_step_in_progress): Adjust.
7254         (add_displaced_stepping_state): Remove.
7255         (get_displaced_step_closure_by_addr): Adjust.
7256         (remove_displaced_stepping_state): Remove.
7257         (infrun_inferior_exit): Call displaced_step_state.reset.
7258         (use_displaced_stepping): Don't check for NULL.
7259         (displaced_step_prepare_throw): Call
7260         get_displaced_stepping_state.
7261         (displaced_step_fixup): Don't check for NULL.
7262         (prepare_for_detach): Don't check for NULL.
7263
7264 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7265
7266         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7267          in case of call that did not complete.
7268
7269 2019-01-02  Andrey Utkin  <autkin@undo.io>
7270
7271         * symfile.c (find_separate_debug_file): Fix search of debug files for
7272         remote debuggee.
7273
7274 2019-01-02  Tom Tromey  <tom@tromey.com>
7275
7276         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7277         indentation.
7278         * python/py-frame.c (frapy_older): Remove cast.
7279         (frapy_newer): Likewise.
7280         * python/py-breakpoint.c (local_setattro): Remove cast.
7281         * python/py-arch.c (archpy_name): Remove local variable.
7282         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7283
7284 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7285
7286         * unittests/basic_string_view/element_access/char/empty.cc:
7287         Fix year range in copyright header.
7288
7289 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7290
7291         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7292         Delete.
7293         <operator==>: Update with for removed field.
7294         <hash>: Likewise.
7295         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7296         <isa_features>: ...this.
7297         <abi_features>: New field.
7298         (riscv_isa_flen): Update comment.
7299         (riscv_abi_xlen): New declaration.
7300         (riscv_abi_flen): New declaration.
7301         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7302         isa_features.
7303         (riscv_abi_xlen): New function.
7304         (riscv_isa_flen): Update to get answer from isa_features.
7305         (riscv_abi_flen): New function.
7306         (riscv_has_fp_abi): Update to get answer from abi_features.
7307         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7308         xlen and flen.
7309         (riscv_call_info) <xlen, flen>: Update comment.
7310         (riscv_call_arg_struct): Remove invalid assertions
7311         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7312         is removed.
7313         (riscv_gdbarch_init): Gather isa features and abi features
7314         separately, ensure both match on the gdbarch when reusing an old
7315         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7316         a target with 64-bit float hardware.
7317
7318 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7319
7320         * source.c (search_command_helper): Stop reverse search
7321         when line 1 has been searched.
7322
7323 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7324
7325         * record-full.c (record_full_base_target::close): Rewrite
7326         record_full_core_buf_list free logic.
7327
7328 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7329
7330         * break-catch-syscall.c (print_one_catch_syscall): xfree
7331         the last text.
7332
7333 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7334
7335         * top.c (print_gdb_version): Update Copyright year in version
7336         message.
7337
7338 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7339
7340         Update copyright year range in all GDB files.
7341
7342 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7343
7344         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7345
7346 For older changes see ChangeLog-2018.
7347 \f
7348 Local Variables:
7349 mode: change-log
7350 left-margin: 8
7351 fill-column: 74
7352 version-control: never
7353 coding: utf-8
7354 End:
7355