gdb/ChangeLog

   1 2019-09-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
   4         from "fullname".
   5         * tui/tui-source.c (tui_source_window::set_contents)
   6         (tui_source_window::location_matches_p)
   7         (tui_source_window::maybe_update): Update.
   8
   9 2019-09-20  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
  12         Update.
  13         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
  14         prefix.
  15         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  16         (tui_data_window::line_from_reg_element_no)
  17         (tui_data_window::first_reg_element_no_inline)
  18         (tui_data_window::show_registers)
  19         (tui_data_window::show_register_group)
  20         (tui_data_window::display_registers_from)
  21         (tui_data_window::display_registers_from_line)
  22         (tui_data_window::first_data_item_displayed)
  23         (tui_data_window::delete_data_content_windows)
  24         (tui_data_window::erase_data_content)
  25         (tui_data_window::do_scroll_vertical)
  26         (tui_data_window::refresh_window)
  27         (tui_data_window::check_register_values): Update.
  28
  29 2019-09-20  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
  32         (struct tui_locator_window) <full_name, proc_name>: Now
  33         std::string.
  34         * tui/tui-stack.c (tui_locator_window::make_status_line)
  35         (tui_locator_window::set_locator_fullname)
  36         (tui_locator_window::set_locator_info): Update.
  37         * tui/tui-source.c (tui_source_window::set_contents)
  38         (tui_source_window::showing_source_p): Update.
  39
  40 2019-09-20  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  43         Don't call tui_locator_win_info_ptr.
  44
  45 2019-09-20  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-win.c (tui_resize_all): Don't call refresh.
  48
  49 2019-09-20  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
  52         height for locator.
  53         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
  54         * tui/tui-layout.c (show_source_disasm_command, show_data)
  55         (show_source_or_disasm_and_command): Use 1 as height for locator.
  56
  57 2019-09-20  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui.c (tui_enable): Update.
  60         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
  61         Update.
  62         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
  63         Update.
  64         * tui/tui-data.c (win_resized): Now bool.
  65         (tui_win_resized): Return bool.
  66         (tui_set_win_resized_to): Accept a bool.
  67
  68 2019-09-20  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
  71         Change type of "refresh_values_only".
  72         * tui/tui-regs.c (tui_data_window::show_register_group): Change
  73         type of "refresh_values_only".
  74
  75 2019-09-20  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
  78         std::string.
  79         (tui_disassemble): Add "pos" parameter.
  80         (tui_disasm_window::set_contents): Simplify.
  81
  82 2019-09-20  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-winsource.h (struct tui_source_window_base)
  85         <show_source_content>: Now private.
  86         * tui/tui-winsource.c
  87         (tui_source_window_base::show_source_content): Don't handle empty
  88         content case.
  89
  90 2019-09-20  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-layout.c (show_source_disasm_command)
  93         (show_source_or_disasm_and_command): Don't call
  94         show_source_content.
  95
  96 2019-09-20  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
  99         Declare.
 100         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 101         from tui_make_status_line.
 102         (tui_locator_window::rerender): Update.
 103
 104 2019-09-20  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 107         (tui_locator_window::rerender): Update.
 108
 109 2019-09-20  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-winsource.h (struct tui_source_window_base)
 112         <~tui_source_window_base>: Don't declare.
 113         <fullname>: Remove.
 114         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 115         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 116         member.
 117         * tui/tui-source.c (tui_source_window::set_contents): Update.
 118         (tui_source_window::location_matches_p)
 119         (tui_source_window::maybe_update): Update.
 120
 121 2019-09-20  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-winsource.h (~tui_source_element): Remove.
 124         (tui_source_element): Update.
 125         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 126         * tui/tui-winsource.c (tui_show_source_line): Update.
 127         * tui/tui-source.c (tui_source_window::set_contents): Update.
 128         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 129
 130 2019-09-20  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 133         declare.
 134         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 135         tui_clear_source_windows_detail.
 136         * tui/tui-winsource.h (struct tui_source_window_base)
 137         <clear_detail>: Don't declare.
 138         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 139         Remove.
 140         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 141
 142 2019-09-20  Tom Tromey  <tromey@adacore.com>
 143
 144         PR ada/24919:
 145         * block.c (contained_in): Fix final return value.
 146
 147 2019-09-20  Alan Modra  <amodra@gmail.com>
 148
 149         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 150         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 151         (read_indirect_string_from_dwz): Use bfd accessor.
 152         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 153         * machoread.c (macho_symfile_read_all_oso): Likewise.
 154         * solib.c (solib_bfd_open): Likewise.
 155
 156 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 157
 158         * eval.c: Move declaration of overload_resolution to...
 159         * value.h: ...here.
 160
 161 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 162
 163         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 164         * arm-linux-tdep.c: Likewise.
 165         * arm-nbsd-nat.c: Likewise.
 166         * arm-tdep.h: Declare arm_apcs_32.
 167         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 168
 169 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 170
 171         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 172         * dwarf2read.h: Declare dwarf_always_disassemble.
 173
 174 2019-09-19  Tom de Vries  <tdevries@suse.de>
 175
 176         PR gdb/25009
 177         * source-cache.c (source_cache::ensure): Catch exception thrown during
 178         construction of the highlighter.
 179
 180 2019-09-18  Alan Modra  <amodra@gmail.com>
 181
 182         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 183         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 184         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 185         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 186         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 187         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 188         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 189         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 190         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 191         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 192         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 193         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 194         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 195         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 196         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 197         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 198         * mi/mi-interp.c: Update throughout for bfd section macro and
 199         function changes.
 200         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 201         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 202
 203 2019-09-18  Tom Tromey  <tom@tromey.com>
 204
 205         * NEWS: Add entry.
 206         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 207         call rl_initialize.
 208         (tui_enable): Do not call rl_initialize.
 209
 210 2019-09-18  Christian Groessler  <chris@groessler.org>
 211
 212         * alpha-linux-nat.c: Include gdbarch.h.
 213
 214 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 215
 216         * ui-file.c: Include cli/cli-style.h.
 217         (term_cli_styling): Remove cli_styling declaration.
 218
 219 2019-09-18  Alan Modra  <amodra@gmail.com>
 220
 221         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 222         to bfd_asymbol_section.
 223
 224 2019-09-18  Alan Modra  <amodra@gmail.com>
 225
 226         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 227         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 228         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 229
 230 2019-09-18  Alan Modra  <amodra@gmail.com>
 231
 232         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 233         * spu-linux-nat.c (spu_bfd_open): Likewise.
 234
 235 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 236
 237         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 238         to bool to match definition in dwarf2read.c.
 239
 240 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 241
 242         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 243         (print_signatures): Likewise.
 244         (trust_pad_over_xvs): Likewise.
 245         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 246         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 247         * arm-linux-nat.c (arm_apcs_32): Likewise.
 248         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 249         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 250         * arm-tdep.c (arm_debug): Likewise.
 251         (arm_apcs_32): Likewise.
 252         * auto-load.c (debug_auto_load): Likewise.
 253         (auto_load_gdb_scripts): Likewise.
 254         (global_auto_load): Likewise.
 255         (auto_load_local_gdbinit): Likewise.
 256         (auto_load_local_gdbinit_loaded): Likewise.
 257         * auto-load.h (global_auto_load): Likewise.
 258         (auto_load_local_gdbinit): Likewise.
 259         (auto_load_local_gdbinit_loaded): Likewise.
 260         * breakpoint.c (disconnected_dprintf): Likewise.
 261         (breakpoint_proceeded): Likewise.
 262         (automatic_hardware_breakpoints): Likewise.
 263         (always_inserted_mode): Likewise.
 264         (target_exact_watchpoints): Likewise.
 265         (_initialize_breakpoint): Update.
 266         * breakpoint.h (target_exact_watchpoints): Change to bool.
 267         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 268         * cli/cli-cmds.c (trace_commands): Likewise.
 269         * cli/cli-cmds.h (trace_commands): Likewise.
 270         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 271         to bool*.
 272         * cli/cli-logging.c (logging_overwrite): Change to bool.
 273         (logging_redirect): Likewise.
 274         (debug_redirect): Likewise.
 275         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 276         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 277         to bool.
 278         <boolean_option_def>: Update.
 279         (struct flag_option_def): Change default type of Context to bool
 280         from int.
 281         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 282         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 283         (get_setshow_command_value_string): Likewise.
 284         * cli/cli-style.c (cli_styling): Change to bool.
 285         (source_styling): Likewise.
 286         * cli/cli-style.h (source_styling): Likewise.
 287         (cli_styling): Likewise.
 288         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 289         to bool.
 290         * command.h (var_types): Update comment.
 291         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 292         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 293         bool.
 294         (debug_compile_cplus_scopes): Likewise.
 295         * compile/compile-internal.h (compile_debug): Likewise.
 296         * compile/compile.c (compile_debug): Likewise.
 297         (struct compile_options) <raw>: Likewise.
 298         * cp-support.c (catch_demangler_crashes): Likewise.
 299         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 300         (usr_cmd_cris_dwarf2_cfi): Likewise.
 301         * csky-tdep.c (csky_debug): Likewise.
 302         * darwin-nat.c (enable_mach_exceptions): Likewise.
 303         * dcache.c (dcache_enabled_p): Likewise.
 304         * defs.h (info_verbose): Likewise.
 305         * demangle.c (demangle): Likewise.
 306         (asm_demangle): Likewise.
 307         * dwarf-index-cache.c (debug_index_cache): Likewise.
 308         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 309         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 310         * dwarf2read.c (check_physname): Likewise.
 311         (use_deprecated_index_sections): Likewise.
 312         (dwarf_always_disassemble): Likewise.
 313         * eval.c (overload_resolution): Likewise.
 314         * event-top.c (set_editing_cmd_var): Likewise.
 315         (exec_done_display_p): Likewise.
 316         * event-top.h (set_editing_cmd_var): Likewise.
 317         (exec_done_display_p): Likewise.
 318         * exec.c (write_files): Likewise.
 319         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 320         (debug_fbsd_nat): Likewise.
 321         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 322         Likewise.
 323         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 324         <backtrace_past_entry> Likewise.
 325         * gdb-demangle.h (demangle): Likewise.
 326         (asm_demangle): Likewise.
 327         * gdb_bfd.c (bfd_sharing): Likewise.
 328         * gdbcore.h (write_files): Likewise.
 329         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 330         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 331         * gdbthread.h (print_thread_events): Likewise.
 332         * gdbtypes.c (opaque_type_resolution): Likewise.
 333         (strict_type_checking): Likewise.
 334         * gnu-nat.c (gnu_debug_flag): Likewise.
 335         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 336         * guile/scm-param.c (pascm_variable): Add boolval.
 337         (add_setshow_generic): Update.
 338         (pascm_param_value): Update.
 339         (pascm_set_param_value_x): Update.
 340         * hppa-tdep.c (hppa_debug): Change to bool..
 341         * infcall.c (may_call_functions_p): Likewise.
 342         (coerce_float_to_double_p): Likewise.
 343         (unwind_on_signal_p): Likewise.
 344         (unwind_on_terminating_exception_p): Likewise.
 345         * infcmd.c (startup_with_shell): Likewise.
 346         * inferior.c (print_inferior_events): Likewise.
 347         * inferior.h (startup_with_shell): Likewise.
 348         (print_inferior_events): Likewise.
 349         * infrun.c (step_stop_if_no_debug): Likewise.
 350         (detach_fork): Likewise.
 351         (debug_displaced): Likewise.
 352         (disable_randomization): Likewise.
 353         (non_stop): Likewise.
 354         (non_stop_1): Likewise.
 355         (observer_mode): Likewise.
 356         (observer_mode_1): Likewise.
 357         (set_observer_mode): Update.
 358         (sched_multi): Change to bool.
 359         * infrun.h (debug_displaced): Likewise.
 360         (sched_multi): Likewise.
 361         (step_stop_if_no_debug): Likewise.
 362         (non_stop): Likewise.
 363         (disable_randomization): Likewise.
 364         * linux-tdep.c (use_coredump_filter): Likewise.
 365         (dump_excluded_mappings): Likewise.
 366         * linux-thread-db.c (auto_load_thread_db): Likewise.
 367         (check_thread_db_on_load): Likewise.
 368         * main.c (captured_main_1): Update.
 369         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 370         xx2_opt, boolean_opt>: Change to bool.
 371         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 372         * maint.c (maintenance_profile_p): Likewise.
 373         (per_command_time): Likewise.
 374         (per_command_space): Likewise.
 375         (per_command_symtab): Likewise.
 376         * memattr.c (inaccessible_by_default): Likewise.
 377         * mi/mi-main.c (mi_async): Likewise.
 378         (mi_async_1): Likewise.
 379         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 380         * nat/fork-inferior.h (startup_with_shell): Likewise.
 381         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 382         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 383         * nios2-tdep.c (nios2_debug): Likewise.
 384         * or1k-tdep.c (or1k_debug): Likewise.
 385         * parse.c (parser_debug): Likewise.
 386         * parser-defs.h (parser_debug): Likewise.
 387         * printcmd.c (print_symbol_filename): Likewise.
 388         * proc-api.c (procfs_trace): Likewise.
 389         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 390         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 391         (set_parameter_value): Update.
 392         (add_setshow_generic): Update.
 393         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 394         to bool*.
 395         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 396         int*.
 397         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 398         * record-btrace.c (record_btrace_target::store_registers): Update.
 399         * record-full.c (record_full_memory_query): Change to bool.
 400         (record_full_stop_at_limit): Likewise.
 401         * record-full.h (record_full_memory_query): Likewise.
 402         * remote-notif.c (notif_debug): Likewise.
 403         * remote-notif.h (notif_debug): Likewise.
 404         * remote.c (use_range_stepping): Likewise.
 405         (interrupt_on_connect): Likewise.
 406         (remote_break): Likewise.
 407         * ser-tcp.c (tcp_auto_retry): Likewise.
 408         * ser-unix.c (serial_hwflow): Likewise.
 409         * skip.c (debug_skip): Likewise.
 410         * solib-aix.c (solib_aix_debug): Likewise.
 411         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 412         (spu_auto_flush_cache_p): Likewise.
 413         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 414         Likewise.
 415         (struct info_print_options) <quiet>: Likewise.
 416         * symfile-debug.c (debug_symfile): Likewise.
 417         * symfile.c (auto_solib_add): Likewise.
 418         (separate_debug_file_debug): Likewise.
 419         * symfile.h (auto_solib_add): Likewise.
 420         (separate_debug_file_debug): Likewise.
 421         * symtab.c (basenames_may_differ): Likewise.
 422         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 423         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 424         (struct info_types_options) <quiet>: Likewise.
 425         * symtab.h (demangle): Likewise.
 426         (basenames_may_differ): Likewise.
 427         * target-dcache.c (stack_cache_enabled_1): Likewise.
 428         (code_cache_enabled_1): Likewise.
 429         * target.c (trust_readonly): Likewise.
 430         (may_write_registers): Likewise.
 431         (may_write_memory): Likewise.
 432         (may_insert_breakpoints): Likewise.
 433         (may_insert_tracepoints): Likewise.
 434         (may_insert_fast_tracepoints): Likewise.
 435         (may_stop): Likewise.
 436         (auto_connect_native_target): Likewise.
 437         (target_stop_and_wait): Update.
 438         (target_async_permitted): Change to bool.
 439         (target_async_permitted_1): Likewise.
 440         (may_write_registers_1): Likewise.
 441         (may_write_memory_1): Likewise.
 442         (may_insert_breakpoints_1): Likewise.
 443         (may_insert_tracepoints_1): Likewise.
 444         (may_insert_fast_tracepoints_1): Likewise.
 445         (may_stop_1): Likewise.
 446         * target.h (target_async_permitted): Likewise.
 447         (may_write_registers): Likewise.
 448         (may_write_memory): Likewise.
 449         (may_insert_breakpoints): Likewise.
 450         (may_insert_tracepoints): Likewise.
 451         (may_insert_fast_tracepoints): Likewise.
 452         (may_stop): Likewise.
 453         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 454         (make_thread_apply_all_options_def_group): Change argument from int*
 455         to bool*.
 456         (thread_apply_all_command): Update.
 457         (print_thread_events): Change to bool.
 458         * top.c (confirm): Likewise.
 459         (command_editing_p): Likewise.
 460         (history_expansion_p): Likewise.
 461         (write_history_p): Likewise.
 462         (info_verbose): Likewise.
 463         * top.h (confirm): Likewise.
 464         (history_expansion_p): Likewise.
 465         * tracepoint.c (disconnected_tracing): Likewise.
 466         (circular_trace_buffer): Likewise.
 467         * typeprint.c (print_methods): Likewise.
 468         (print_typedefs): Likewise.
 469         * utils.c (debug_timestamp): Likewise.
 470         (sevenbit_strings): Likewise.
 471         (pagination_enabled): Likewise.
 472         * utils.h (sevenbit_strings): Likewise.
 473         (pagination_enabled): Likewise.
 474         * valops.c (overload_resolution): Likewise.
 475         * valprint.h (struct value_print_options) <prettyformat_arrays,
 476         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 477         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 478         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 479         Likewise.
 480         * windows-nat.c (new_console): Likewise.
 481         (cygwin_exceptions): Likewise.
 482         (new_group): Likewise.
 483         (debug_exec): Likewise.
 484         (debug_events): Likewise.
 485         (debug_memory): Likewise.
 486         (debug_exceptions): Likewise.
 487         (useshell): Likewise.
 488         * windows-tdep.c (maint_display_all_tib): Likewise.
 489         * xml-support.c (debug_xml): Likewise.
 490
 491 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 492
 493         * source.c (prepare_path_for_appending): New function.
 494         (openp): Make use of new function.
 495         (find_and_open_source): Search for the compilation directory and
 496         source file as a relative path beneath the directory search path.
 497
 498 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * source-cache.c (source_cache::get_line_charpos): Catch
 501         exceptions and return false, this matches the behaviour documented
 502         in the header file.
 503
 504 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 505
 506         * ada-tasks.c (info_task): Remove quoting of the task's name.
 507
 508 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 509
 510         * symfile.c (auto_solib_add): Replace comment with a reference
 511         to the header file.
 512
 513 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 514
 515         * NEWS: Mention that gdb can now be compiled with Python 3
 516         on Windows.
 517
 518 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * maint.c (maint_print_section_data::maint_print_section_data):
 521         Force use of 'float log10 (float)' by casting the argument to
 522         float.
 523
 524 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 525
 526         * maint.c: Add 'cmath' include.
 527         (struct maint_print_section_data): New structure.
 528         (print_section_index): New function.
 529         (print_bfd_section_info): Add header comment, small whitespace
 530         cleanup, and update to call new print_section_index function.
 531         (print_objfile_section_info): Likewise.
 532         (maint_obj_section_from_bfd_section): New function.
 533         (print_bfd_section_info_maybe_relocated): New function.
 534         (maintenance_info_sections): Add header comment, always use
 535         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 536
 537 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 540         inner scope, add check that the objfile has psymtabs before
 541         checking psymtabs_addrmap.
 542         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 543
 544 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 545
 546         * NEWS: Announce that Ada task names are now shown at more places,
 547         and between quotes (except in info task output).
 548         * gdb/ada-tasks.c (task_to_str): New function.
 549         (display_current_task_id): Call task_to_str.
 550         (task_command_1): Likewise.
 551         (print_ada_task_info): In non-mi mode, Properly align headers and data
 552         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 553
 554 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 555
 556         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 557         prstatus.pr_lwp.pr_info instead of making it up.
 558
 559 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 560
 561         * auto-load.c (auto_load_expand_dir_vars): Update.
 562         * defs.h (gdb_datadir): Change to std::string.
 563         (python_libdir): Likewise.
 564         (relocate_gdb_directory): Change return type to std::string.
 565         * guile/guile.c (gdbscm_data_directory): Update.
 566         (initialize_scheme_side): Update.
 567         * jit.c (jit_reader_dir): Change to std::string.
 568         (jit_reader_load_command): Update.
 569         * main.c (gdb_datadir): Change to std::string.
 570         (python_libdir): Likewise.
 571         (set_gdb_data_directory): Update.
 572         (relocate_path): Change to return std::string.
 573         (relocate_gdb_directory): Change to return std::string.
 574         (relocate_gdbinit_path_maybe_in_datadir): Update.
 575         (captured_main_1): Update.
 576         * python/python.c (do_start_initialization): Update.
 577         * top.c (show_gdb_datadir): Update.
 578         * xml-syscall.c (xml_init_syscalls_info): Update.
 579         (init_syscalls_info): Update.
 580
 581 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 582
 583         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 584         out of get_init_files.
 585         (get_init_files): Update.
 586
 587 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 588
 589         * main.c (get_init_files): Change to use std::string.
 590         (captured_main_1): Update.
 591         (print_gdb_help): Update.
 592
 593 2019-09-11  Ali Tamur  <tamur@google.com>
 594
 595         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 596         implementation.
 597
 598 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 599
 600         * dbxread.c (read_dbx_symtab): Update.
 601         * dwarf2read.c (load_partial_dies): Update.
 602         * mdebugread.c (parse_partial_symbols): Update.
 603         (handle_psymbol_enumerators): Update.
 604         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 605         * psymtab.c (add_psymbol_to_bcache): Likewise.
 606         (add_psymbol_to_list): Likewise.
 607         * symtab.c (symbol_set_names): Likewise.
 608         * symtab.h (symbol_set_names): Likewise.
 609         * xcoffread.c (scan_xcoff_symtab): Update.
 610
 611 2019-09-11  Tom Tromey  <tom@tromey.com>
 612
 613         * symfile-mem.c (symbol_file_add_from_memory): Use
 614         bfd_set_filename.
 615         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 616         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 617
 618 2019-09-10  Tom Tromey  <tromey@adacore.com>
 619
 620         * dwarf-index-write.c (write_psymbols): Extend error message.
 621         (debug_names::insert): Add Ada code.
 622         (debug_names::write_psymbols): Remove Ada check.
 623         (debug_names) <m_string_obstack>: New member.
 624         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 625         (gdb_index_symbol_name_matcher::matches): Remove.
 626         (mapped_index_base::find_name_components_bounds): Add "lang"
 627         parameter.
 628         (mapped_index_base::build_name_components): Also split names
 629         according to Ada syntax.
 630         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 631         type of "match_callback".
 632         (check_match, check_find_bounds_finds)
 633         (dw2_expand_symtabs_matching): Update.
 634         (dw2_debug_names_iterator): Add new constructor.
 635         (dw2_debug_names_map_matching_symbols): New function.
 636         (dw2_debug_names_expand_symtabs_matching): Update.
 637         (dwarf2_debug_names_functions): Use
 638         dw2_debug_names_map_matching_symbols.
 639
 640 2019-09-10  Tom Tromey  <tromey@adacore.com>
 641
 642         * dwarf2read.c (dw2_get_file_names_reader): Add the
 643         CU's file name to the results.
 644
 645 2019-09-10  Tom Tromey  <tromey@adacore.com>
 646
 647         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 648         map_matching_symbols.  Update.
 649         * dwarf2read.c (dw2_map_matching_symbols): Update.
 650         * psymtab.c (match_partial_symbol): Change type; update.
 651         (psym_map_matching_symbols): Likewise.
 652         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 653         type; update.
 654         * symfile.h (struct quick_symbol_functions)
 655         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 656         Remove "match".
 657
 658 2019-09-10  Tom Tromey  <tromey@adacore.com>
 659
 660         * psymtab.c (map_block): Remove.
 661         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 662         * symtab.c (iterate_over_symbols_terminated): New function.
 663         * symtab.c (iterate_over_symbols_terminated): Declare.
 664
 665 2019-09-10  Tom Tromey  <tromey@adacore.com>
 666
 667         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 668         * language.h (struct language_defn) <la_iterate_over_symbols>:
 669         Return bool.
 670         * symtab.c (iterate_over_symbols): Return bool.
 671         * symtab.h (iterate_over_symbols): Return bool.
 672
 673 2019-09-10  Tom Tromey  <tromey@adacore.com>
 674
 675         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 676         (add_nonlocal_symbols): Update.
 677         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 678         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 679         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 680         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 681         Change type of "callback".  Remove "data".
 682
 683
 684 2019-09-09  Ali Tamur  <tamur@google.com>
 685
 686         * dwarf2read.c (comp_unit_head): Update comment.
 687         (dwarf2_dwo_name): New function declaration.
 688         (dwarf_unit_type_name): New function declaration.
 689         (read_comp_unit_head): Add support for new compilation units,
 690         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 691         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 692         (currently named as "signature") in their header. Also clarify error
 693         messages.
 694         (lookup_dwo_id): New function. Returns the dwo id of the given
 695         compile unit.
 696         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 697         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 698         functions.
 699         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 700         (dwarf2_dwo_name): Get the dwo name if present.
 701         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 702         purposes.
 703
 704 2019-09-09  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 707
 708 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 709
 710         * python/python.c (do_start_initialization): Make progname_copy static,
 711         to avoid a leak report.
 712
 713 2019-09-08  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 716
 717 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 718
 719         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 720         Change type to gdb::optional<block_enum>.
 721         (dw2_symtab_iter_init): Change block_index parameter type
 722         to gdb::optional<block_enum>.
 723         (dw2_lookup_symbol): Change block_index parameter
 724         type to block_enum.c
 725         (dw2_debug_names_lookup_symbol): Likewise.
 726         * psymtab.c (psym_lookup_symbol): Likewise.
 727         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 728         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 729         Likewise.
 730
 731 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 732
 733         * defs.h (relocate_gdb_directory): Change int to bool in
 734         signature and rename flag to relocatable.
 735         * main.c (relocate_path): Likewise.
 736         (relocate_gdb_directory): Likewise.
 737
 738 2019-09-06  Alan Modra  <amodra@gmail.com>
 739
 740         * coffread.c (coff_symfile_read): Constify filename variable.
 741         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 742         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 743         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 744         * solib.c (reload_shared_libraries_1): Likewise.
 745         * symfile.c (reread_symbols): Likewise.
 746         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 747         * solib-darwin.c (darwin_bfd_open): Likewise.
 748         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 749
 750 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 753         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 754
 755 2019-09-03  Tom Tromey  <tromey@adacore.com>
 756
 757         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 758         types.
 759         (has_negatives): Unbias a range type bound.
 760         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 761         * gdbtypes.c (operator==): Handle new field.
 762         (create_range_type): Add "bias" parameter.
 763         (create_static_range_type, resolve_dynamic_range): Update.
 764         * gdbtypes.h (struct range_bounds) <bias>: New member.
 765         (create_range_type): Add bias parameter.
 766         * printcmd.c (print_scalar_formatted): Unbias range types.
 767         * value.c (unpack_long): Unbias range types.
 768         (pack_long): Bias range types.
 769
 770 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 771
 772         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 773         probe arguments.
 774
 775 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 776
 777         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 778         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 779         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 780         (compile_probe_arg): Likewise.
 781         * probe.h (get_argument_count): Likewise.
 782         * solib-svr4.c (solib_event_probe_action): Likewise.
 783         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 784
 785 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 786
 787         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 788         code to here...
 789         (svr4_create_solib_event_breakpoints): ...from here.
 790
 791 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 792
 793         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 794         suffix from warning message.
 795
 796 2019-08-30  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-winsource.h (struct tui_source_window_base)
 799         <refresh_all>: Don't declare.
 800         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 801         Remove.
 802         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 803         tui_show_locator_content.
 804         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 805         declare.
 806         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 807         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 808         declare.
 809
 810 2019-08-30  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 813
 814 2019-08-30  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 817         Remove unnecessary forward declarations.
 818
 819 2019-08-30  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 822         rerender.
 823         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 824         tui_show_locator_content.
 825
 826 2019-08-30  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 829         (tui_locator_window::rerender): Rewrite using body of previous
 830         tui_show_locator_content.
 831
 832 2019-08-30  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 835         set_locator_fullname>: New methods.
 836         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 837         Rename from tui_set_locator_fullname.
 838         (tui_locator_window::set_locator_info): Rename from
 839         tui_set_locator_info.  Return bool.
 840         (tui_update_locator_fullname, tui_show_frame_info): Update.
 841
 842 2019-08-30  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 845
 846 2019-08-30  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 849         call touchwin.
 850
 851 2019-08-30  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-wingeneral.c (box_win): Assume win_info and
 854         win_info->handle cannot be NULL.
 855
 856 2019-08-30  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 859         refresh_window>: Declare.
 860         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 861         resize.
 862         (tui_data_item_window::rerender): Rename from
 863         tui_display_register.
 864         (tui_data_item_window::refresh_window): New method.
 865         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 866         no-op.
 867
 868 2019-08-30  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 871         regs_column_count, current_group>: Move later.  Now private.
 872         <get_current_group>: New method.
 873         * tui/tui-regs.c (tui_reg_command): Update.
 874         * tui/tui-layout.c (tui_set_layout): Update.
 875
 876 2019-08-30  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 879         (tui_data_window::rerender): Don't call
 880         check_and_display_highlight_if_needed.
 881         (tui_data_window::refresh_all): Remove call to
 882         erase_data_content.
 883
 884 2019-08-30  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 887         (tui_data_window::display_registers_from)
 888         (tui_data_window::display_reg_element_at_line)
 889         (tui_data_window::display_registers_from_line): Remove checks of
 890         "empty".
 891
 892 2019-08-30  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 895         Don't declare.
 896         * tui/tui-regs.c (tui_data_window::show_registers): Call
 897         rerender.
 898         (tui_data_window::rerender): Rename from display_all_data.
 899         (tui_data_window::rerender): Remove old implementation.
 900
 901 2019-08-30  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 904         text.
 905         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 906
 907 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 908             Sergio Durigan Junior  <sergiodj@redhat.com>
 909
 910         PR win32/24284
 911         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 912
 913 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 916         when searching for types.
 917
 918 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 919
 920         * f-lang.c (f_language_defn): Use f_print_typedef.
 921         * f-lang.h (f_print_typedef): Declare.
 922         * f-typeprint.c (f_print_typedef): Define.
 923
 924 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 925
 926         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 927
 928 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 929
 930         * cli/cli-utils.c (info_print_options_defs): Delete.
 931         (make_info_print_options_def_group): Delete.
 932         (extract_info_print_options): Delete.
 933         (info_print_command_completer): Delete.
 934         (info_print_args_help): Add extra parameter, and optionally
 935         include text about -n flag.
 936         * cli/cli-utils.h (struct info_print_options): Delete.
 937         (extract_info_print_options): Delete declaration.
 938         (info_print_command_completer): Delete declaration.
 939         (info_print_args_help): Add extra parameter, extend header
 940         comment.
 941         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 942         search_symbols.
 943         * stack.c (struct info_print_options): New type.
 944         (info_print_options_defs): New file scoped variable.
 945         (make_info_print_options_def_group): New static function.
 946         (info_print_command_completer): New static function.
 947         (info_locals_command): Update to use new local functions.
 948         (info_args_command): Likewise.
 949         (_initialize_stack): Add extra parameter to calls to
 950         info_print_args_help.
 951         * symtab.c (search_symbols): Add extra parameter, use this to
 952         possibly excluse non-debug symbols.
 953         (symtab_symbol_info): Add extra parameter, which is passed on to
 954         search_symbols.
 955         (struct info_print_options): New type.
 956         (info_print_options_defs): New file scoped variable.
 957         (make_info_print_options_def_group): New static function.
 958         (info_print_command_completer): New static function.
 959         (info_variables_command): Update to use local functions, and pass
 960         extra parameter through to symtab_symbol_info.
 961         (info_functions_command): Likewise.
 962         (info_types_command): Pass additional argument through to
 963         symtab_symbol_info.
 964         (rbreak_command): Pass extra argument to search_symbols.
 965         (_initialize_symtab): Add extra arguments for calls to
 966         info_print_args_help, and update help text for 'info variables',
 967         'whereis', and 'info functions' commands.
 968         * symtab.h (search_symbols): Add extra argument to declaration.
 969         * NEWS: Mention new flags.
 970
 971 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 972
 973         * symtab.c (lookup_static_symbol): Call the new function (and move
 974         it down to be next to lookup_global_symbol).
 975         (struct global_sym_lookup_data): Add block_enum member and rename to...
 976         (struct global_or_static_sym_lookup_data): ...this.
 977         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 978         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 979         (lookup_symbol_global_or_static_iterator_cb): ...this.
 980         (lookup_global_or_static_symbol): New function.
 981         (lookup_global_symbol): Call new function.
 982
 983 2019-08-26  Tom de Vries  <tdevries@suse.de>
 984
 985         PR c++/24852
 986         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 987         when pc_probe.prob == NULL.
 988
 989 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 990
 991         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 992         variable symbol_linkage to symbol_linkage_.
 993
 994 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 995
 996         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 997         represent whether the symbol is static, dynamic, or we don't
 998         know.
 999
1000 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1001
1002         * gdb/rx-tdep.c (rx_register_names): New.
1003         (rx_register_name): Delete.
1004         (rx_psw_type): Delete.
1005         (rx_fpsw_type): Delete.
1006         (rx_register_type): Delete.
1007         (rx_gdbarch_init): Convert target-descriptions.
1008         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1009         * gdb/features/Makefile: Add rx.xml.
1010         * gdb/features/rx.xml: New.
1011         * gdb/features/rx.c: Generated.
1012         * gdb/NEWS: Mention target description support.
1013
1014 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1015
1016         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1017         *slot_ptr.
1018
1019 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1020
1021         * configure.ac: Don't check for 'dlfcn.h' (moved to
1022         gdbsupport/common.m4).
1023         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1024         'gdbsupport/'.
1025         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1026         * compile/compile-c-support.c: Include
1027         'gdbsupport/gdb-dlfcn.h'.
1028         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1029         * gdb-dlfcn.c: Move to...
1030         * gdbsupport/gdb-dlfcn.c: ... here.
1031         * gdb-dlfcn.h: Move to...
1032         * gdbsupport/gdb-dlfcn.h: ... here.
1033
1034 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1035
1036         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1037         the offset field signed.
1038
1039 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1040
1041         * python/lib/gdb/__init__.py (_execute_file): New function.
1042         * python/python.c (python_run_simple_file): Call gdb._execute_file
1043         on Windows.
1044
1045 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1046
1047         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1048         all uses as this was never set to anything but a zero value.
1049
1050 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1051
1052         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1053
1054 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1055
1056         * tui/tui-data.h (tui_gen_win_info): Add an =default
1057         move constructor, required by some GCC versions.
1058
1059 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1060
1061         * go32-nat.c (go32_sysinfo): Add hygon_p.
1062
1063 2019-08-20  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1066         line_from_reg_element_no, first_reg_element_no_inline,
1067         display_all_data, delete_data_content_windows,
1068         erase_data_content>: Now private.
1069
1070 2019-08-20  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1073         (tui_unhighlight_win, tui_highlight_win)
1074         (tui_win_info::make_window): Update.
1075         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1076
1077 2019-08-20  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1080         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1081         (MAX_PID_WIDTH): Move to tui-stack.c.
1082         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1083         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1084         (MAX_PID_WIDTH): Move from tui-data.h.
1085
1086 2019-08-20  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1089         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1090         (box_win): Update.
1091         (tui_gen_win_info::make_window): Rename from tui_make_window.
1092         (tui_win_info::make_window): New method.
1093         (tui_gen_win_info::make_visible): Update.
1094         * tui/tui-source.c (tui_source_window::set_contents): Update.
1095         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1096         (tui_data_window::display_registers_from): Update.
1097         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1098         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1099         Declare.
1100         <can_box>: Remove.
1101         <title>: Remove.
1102         (struct tui_win_info) <make_window>: Declare.
1103         <can_box>: Now virtual.
1104         <title>: New member.
1105         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1106         * tui/tui-command.c (tui_cmd_window::resize): Update.
1107
1108 2019-08-20  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1111         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1112         (tui_data_window::check_register_values): Update.
1113
1114 2019-08-20  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-regs.h (struct tui_data_window): Use
1117         DISABLE_COPY_AND_ASSIGN.
1118         <regs_content>: Change type, removing unique_ptr.
1119         <tui_data_window>: Add move constructor.
1120         * tui/tui-regs.c (tui_data_window::show_registers)
1121         (tui_data_window::show_register_group)
1122         (tui_data_window::display_registers_from)
1123         (tui_data_window::display_registers_from)
1124         (tui_data_window::first_data_item_displayed)
1125         (tui_data_window::delete_data_content_windows)
1126         (tui_data_window::rerender, tui_data_window::refresh_window)
1127         (tui_data_window::check_register_values): Update.
1128
1129 2019-08-20  Tom Tromey  <tom@tromey.com>
1130
1131         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1132         show_register_group>: Declare.
1133         (tui_show_register_group): Don't declare.
1134         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1135         tui_show_registers.
1136         (tui_data_window::show_register_group): Rename from
1137         tui_show_register_group.
1138         (tui_data_window::check_register_values, tui_reg_command):
1139         Update.
1140         * tui/tui-layout.c (tui_set_layout): Update.
1141
1142 2019-08-20  Tom Tromey  <tom@tromey.com>
1143
1144         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1145         Declare.
1146         (tui_check_register_values): Don't declare.
1147         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1148         from tui_check_register_values.
1149         * tui/tui-hooks.c (tui_register_changed): Update.
1150
1151 2019-08-20  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-regs.c (tui_reg_layout): Move later.
1154         (tui_show_registers): Don't enable TUI mode or change layout.
1155
1156 2019-08-20  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-regs.h (struct tui_data_item_window)
1159         <~tui_data_item_window>: Remove.
1160         <content>: Now a unique_xmalloc_ptr.
1161         * tui/tui-regs.c (tui_register_format): Return a
1162         unique_xmalloc_ptr.
1163         (tui_get_register): Update.
1164         (~tui_data_item_window): Remove.
1165         (tui_data_window::display_registers_from, tui_display_register):
1166         Update.
1167         * tui/tui-io.h (tui_expand_tabs): Update.
1168         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1169         Remove "col" parameter.
1170
1171 2019-08-20  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1174         field.
1175         * tui/tui-regs.c (~tui_data_item_window): Update.
1176
1177 2019-08-20  Tom Tromey  <tom@tromey.com>
1178
1179         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1180         earlier.
1181
1182 2019-08-20  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1185
1186 2019-08-20  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-source.h (struct tui_source_window): Update.
1189         * tui/tui-regs.c (tui_show_registers): Update.
1190         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1191         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1192         (NO_REGS_STRING): Remove defines.
1193
1194 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1195
1196         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1197         unnecessary thread walk if remote doesn't support the packet.
1198
1199 2019-08-19  Tom Tromey  <tromey@adacore.com>
1200
1201         * python/py-value.c (value_has_field): Fix indentation.
1202
1203 2019-08-19  Tom Tromey  <tromey@adacore.com>
1204
1205         * printcmd.c (do_one_display, info_display_command): Update.
1206         * block.h (contained_in): Return bool.  Add allow_nested
1207         parameter.
1208         * block.c (contained_in): Return bool.  Add allow_nested
1209         parameter.
1210
1211 2019-08-19  Tom Tromey  <tom@tromey.com>
1212
1213         * configure: Rebuild.
1214         * configure.ac: Disallow the combination of -static-libstdc++ and
1215         source highlight.
1216         * source-cache.c (get_language_name): Handle rust.
1217         (source_cache::get_source_lines): Ignore highlighting exceptions.
1218
1219 2019-08-16  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1222         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1223         (struct tui_source_window_base) <make_visible, refresh_window,
1224         resize>: Remove methods.
1225         <execution_info>: Remove field.
1226         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1227         (tui_show_source_line, tui_source_window_base)
1228         (~tui_source_window_base): Update.
1229         (tui_source_window_base::resize)
1230         (tui_source_window_base::make_visible)
1231         (tui_source_window_base::refresh_window): Remove.
1232         (tui_source_window_base::update_exec_info): Update.
1233         * tui/tui-source.c (tui_source_window::set_contents): Update.
1234         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1235
1236 2019-08-16  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1239         deprecated_query_hook.
1240
1241 2019-08-16  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1244         (tui_update_source_windows_with_line): Update.
1245         * tui/tui-source.h (struct tui_source_window)
1246         <show_symtab_source>: Declare.
1247         (tui_show_symtab_source): Don't declare.
1248         * tui/tui-source.c (tui_show_symtab_source): Rename from
1249         tui_show_symtab_source.
1250
1251 2019-08-16  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-winsource.h (struct tui_source_window_base)
1254         <set_contents>: Declare.
1255         * tui/tui-winsource.c
1256         (tui_source_window_base::update_source_window_as_is): Update.
1257         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1258         Declare.
1259         (tui_set_source_content): Don't declare.
1260         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1261         tui_set_source_content.
1262         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1263         Declare.
1264         (tui_set_disassem_content): Don't declare.
1265         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1266         tui_set_disassem_content.
1267
1268 2019-08-16  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-winsource.h (struct tui_source_window_base)
1271         <update_breakpoint_info>: Declare.
1272         (tui_update_breakpoint_info): Don't declare.
1273         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1274         (tui_update_all_breakpoint_info): Update.
1275         (tui_source_window_base::update_breakpoint_info): Rename from
1276         tui_update_breakpoint_info.
1277         (tui_source_window_base::update_exec_info): Update.
1278
1279 2019-08-16  Tom Tromey  <tom@tromey.com>
1280
1281         * tui/tui-winsource.h (struct tui_source_window_base)
1282         <update_source_window>: Declare.
1283         (tui_update_source_window): Don't declare.
1284         * tui/tui-winsource.c
1285         (tui_source_window_base::update_source_window): Rename from
1286         tui_update_source_window.
1287         (tui_source_window_base::rerender): Update.
1288         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1289         * tui/tui-disasm.c (tui_show_disassem)
1290         (tui_show_disassem_and_update_source)
1291         (tui_disasm_window::maybe_update): Update.
1292
1293 2019-08-16  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-winsource.h (struct tui_source_window_base)
1296         <update_source_window_as_is>: Declare.
1297         (tui_update_source_window_as_is): Don't declare.
1298         * tui/tui-winsource.c (tui_update_source_window): Update
1299         (tui_source_window_base::update_source_window_as_is): Rename from
1300         tui_update_source_window_as_is.
1301         (tui_source_window_base::refill): Update.
1302         * tui/tui-source.c (tui_show_symtab_source): Update.
1303         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1304         Update.
1305
1306 2019-08-16  Tom Tromey  <tom@tromey.com>
1307
1308         * tui/tui-winsource.h (tui_update_source_window)
1309         (tui_update_source_window_as_is): Remove "noerror" parameter.
1310         * tui/tui-winsource.c (tui_update_source_window)
1311         (tui_update_source_window_as_is): Remove "noerror" parameter.
1312         (tui_update_source_windows_with_addr)
1313         (tui_update_source_windows_with_line)
1314         (tui_source_window_base::rerender)
1315         (tui_source_window_base::refill): Update.
1316         * tui/tui-source.h (tui_set_source_content)
1317         (tui_show_symtab_source): Remove "noerror" parameter.
1318         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1319         parameter.
1320         (tui_show_symtab_source): Likewise.
1321         (tui_source_window::maybe_update): Update.
1322         * tui/tui-disasm.c (tui_show_disassem)
1323         (tui_show_disassem_and_update_source)
1324         (tui_disasm_window::do_scroll_vertical)
1325         (tui_disasm_window::maybe_update): Update.
1326
1327 2019-08-16  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui.c (tui_is_window_visible): Update.
1330         * tui/tui-wingeneral.c (tui_make_window)
1331         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1332         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1333         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1334         (tui_set_win_height_command, parse_scrolling_args): Update.
1335         * tui/tui-source.c (tui_source_window::style_changed): Update.
1336         * tui/tui-regs.c (tui_show_registers)
1337         (tui_data_window::first_data_item_displayed)
1338         (tui_data_window::delete_data_content_windows)
1339         (tui_check_register_values, tui_reg_command): Update.
1340         * tui/tui-disasm.c (tui_show_disassem): Update.
1341         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1342         method.
1343         <is_visible>: Remove field.
1344         * tui/tui-data.c (tui_next_win, tui_prev_win)
1345         (tui_delete_invisible_windows): Update.
1346
1347 2019-08-16  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-winsource.h (struct tui_source_window_base)
1350         <m_has_locator>: Remove.
1351         * tui/tui-layout.c (show_source_disasm_command, show_data)
1352         (show_source_or_disasm_and_command): Update.
1353
1354 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1355
1356         * NEWS (Other MI changes): New subsection.
1357         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1358         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1359         * arch-utils.c (default_get_pc_address_flags): New function.
1360         * arch-utils.h (default_get_pc_address_flags): New declaration.
1361         * gdbarch.sh: Add get_pc_address_flags.
1362         * gdbarch.c: Regenerate.
1363         * gdbarch.h: Likewise.
1364         * stack.c (print_pc): New function.
1365         (print_frame_info) (print_frame): Call print_pc.
1366
1367 2019-08-16  Tom de Vries  <tdevries@suse.de>
1368
1369         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1370         print_objfile_section_info.
1371
1372 2019-08-15  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1375         calling update_cmdwin_start_line.
1376         * tui/tui-winsource.h (struct tui_source_window_base)
1377         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1378         <rerender>: Declare.
1379         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1380         Call rerender.
1381         (tui_source_window_base::set_new_height): Remove.
1382         (tui_source_window_base::rerender): Rename from
1383         do_make_visible_with_new_height.
1384         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1385         resize method.
1386         (tui_win_info::make_invisible_and_set_new_height)
1387         (tui_win_info::make_visible_with_new_height): Remove.
1388         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1389         Declare.
1390         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1391         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1392         do_make_visible_with_new_height>: Don't declare.
1393         <rerender>: Declare.
1394         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1395         set_new_height.
1396         (tui_data_window::do_make_visible_with_new_height): Remove.
1397         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1398         call tui_show_locator_content.
1399         (tui_gen_win_info::resize): Call rerender.
1400         (show_source_or_disasm_and_command): Don't call
1401         tui_show_locator_content.
1402         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1403         method.
1404         (struct tui_win_info) <rerender>: Declare.
1405         <set_new_height, make_invisible_and_set_new_height,
1406         make_visible_with_new_height>: Don't declare.
1407         * tui/tui-data.c (tui_win_list::rerender): New method.
1408         * tui/tui-command.h (struct tui_cmd_window)
1409         <do_make_visible_with_new_height>: Don't declare.
1410         * tui/tui-command.c
1411         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1412
1413 2019-08-15  Tom Tromey  <tromey@adacore.com>
1414
1415         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1416         * ada-lang.c (ada_enum_name): Likewise.
1417
1418 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1419
1420         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1421         leading underscore.
1422         (GdbOutputErrorFile): Likewise.
1423         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1424         accordingly.
1425         (execute_unwinders): Rename to have a leading underscore.
1426         (auto_load_packages): Likewise.
1427         (global scope): Adjust call to auto_load_packages accordingly.
1428         (GdbSetPythonDirectory): Likewise.
1429         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1430         instead of execute_unwinders.
1431
1432 2019-08-15  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1435         (show_data): Don't change window visibility.
1436         (tui_gen_win_info::resize): Remove special case for command
1437         window.  Use wresize, when available.
1438         (show_source_or_disasm_and_command): Don't change window
1439         visibility.
1440         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1441         <make_visible>: New method.
1442         * tui/tui-command.c (tui_cmd_window::resize): New method.
1443
1444 2019-08-15  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1447         (struct tui_source_windows): New.
1448         * tui/tui-winsource.c (tui_display_main): Update.
1449         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1450         (new_height_ok, parse_scrolling_args): Update.
1451         * tui/tui-layout.c (show_layout, show_data): Update.
1452         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1453         (tui_add_to_source_windows): Don't declare.
1454         * tui/tui-data.c (source_windows, tui_source_windows)
1455         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1456
1457 2019-08-15  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1460         Rename from reset.
1461         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1462         * tui/tui-layout.c (show_source_disasm_command, show_data):
1463         Update.
1464         (tui_gen_win_info::resize): Rename.
1465         (show_source_or_disasm_and_command): Update.
1466         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1467         reset.
1468
1469 2019-08-15  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1472         * tui/tui-interp.c (tui_interp::init): Don't call
1473         tui_initialize_static_data.
1474         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1475
1476 2019-08-15  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1479         examine tui_win_list.
1480
1481 2019-08-15  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1484         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1485         tui_clear_source_content.
1486         (tui_clear_source_content): Remove.
1487         (tui_source_window_base::do_erase_source_content): Hoist call to
1488         content.clear().
1489         * tui/tui-stack.c (tui_show_frame_info): Don't call
1490         tui_clear_source_content.
1491
1492 2019-08-15  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-winsource.h (struct tui_source_window_base)
1495         <do_erase_source_content>: New method.
1496         <erase_source_content>: New method.
1497         (tui_erase_source_content): Don't declare.
1498         * tui/tui-winsource.c (tui_clear_source_content): Update.
1499         (tui_source_window_base::do_erase_source_content): Rename from
1500         tui_erase_source_content.
1501         (tui_source_window_base::show_source_content): Update.
1502         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1503         * tui/tui-source.h (struct tui_source_window)
1504         <erase_source_content>: New method.
1505         * tui/tui-disasm.h (struct tui_disasm_window)
1506         <erase_source_content>: New method.
1507
1508 2019-08-15  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1511         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1512         constructor.
1513         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1514         * tui/tui-source.c (tui_set_source_content): Update.
1515         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1516
1517 2019-08-15  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1520         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1521         tui-source.c.
1522         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1523         Declare.
1524         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1525         method.
1526         (tui_source_window::maybe_update): Update.
1527
1528 2019-08-15  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1531         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1532         tui-disasm.c.
1533         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1534         Declare.
1535         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1536         method.
1537         (tui_disasm_window::maybe_update): Update.
1538
1539 2019-08-15  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-winsource.h (struct tui_source_window_base)
1542         <maybe_update>: Declare.
1543         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1544         method.
1545         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1546         Declare.
1547         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1548         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1549         Declare.
1550         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1551
1552 2019-08-15  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1555
1556 2019-08-15  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-wingeneral.c: Include tui-stack.h.
1559         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1560         (struct tui_locator_window): Move from tui-data.h.
1561         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1562         (tui_initialize_static_data): Move from tui-data.c.
1563         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1564         (struct tui_locator_window): Move to tui-stack.c.
1565         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1566         (tui_initialize_static_data): Move to tui-stack.c.
1567
1568 2019-08-15  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-layout.c (show_source_disasm_command)
1571         (show_source_or_disasm_and_command): Use make_visible method, not
1572         tui_make_window.
1573         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1574         Remove.
1575
1576 2019-08-15  Tom Tromey  <tom@tromey.com>
1577
1578         * tui/tui-wingeneral.h (tui_make_window): Update.
1579         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1580         parameter.
1581         (tui_gen_win_info::make_visible): Update.
1582         * tui/tui-regs.c (tui_data_window::display_registers_from):
1583         Update.
1584         * tui/tui-layout.c (show_source_disasm_command)
1585         (show_source_or_disasm_and_command): Update.
1586         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1587         (enum tui_box): Remove.
1588         (struct tui_win_info) <can_box>: New method.
1589         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1590         method.
1591
1592 2019-08-15  Tom de Vries  <tdevries@suse.de>
1593
1594         * linux-nat-trad.c: Include gdbarch.h.
1595
1596 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1597
1598         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1599         register sizes.
1600
1601 2019-08-14  Tom Tromey  <tromey@adacore.com>
1602
1603         * darwin-nat.c: Include gdbarch.h.
1604         * darwin-nat-info.c: Include gdbarch.h.
1605
1606 2019-08-13  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1609         Remove.
1610         * tui/tui-data.c (tui_initialize_static_data): Update.
1611
1612 2019-08-13  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-winsource.h (struct tui_exec_info_window)
1615         <~tui_exec_info_window, maybe_allocate_content, get_content,
1616         m_content>: Remove.
1617         (struct tui_source_window_base) <set_exec_info_content,
1618         show_exec_info_content>: Don't declare.
1619         * tui/tui-winsource.c
1620         (tui_exec_info_window::maybe_allocate_content): Remove.
1621         (tui_source_window_base::update_exec_info): Rename from
1622         set_exec_info_content.
1623         (tui_source_window_base::show_exec_info_content)
1624         (tui_source_window_base::update_exec_info): Remove.
1625
1626 2019-08-13  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1629         declare.
1630         * tui/tui-winsource.c (tui_update_source_window_as_is)
1631         (tui_update_source_windows_with_addr, tui_erase_source_content):
1632         Update.
1633         (tui_clear_exec_info_content): Remove.
1634
1635 2019-08-13  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1638         declare.
1639         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1640         call tui_erase_exec_info_content.
1641         (tui_clear_exec_info_content): Rename from
1642         tui_erase_exec_info_content.
1643         (tui_clear_exec_info_content): Delete.
1644
1645 2019-08-13  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-winsource.h (struct tui_source_window_base)
1648         <show_exec_info_content>: Declare.
1649         (tui_show_exec_info_content): Don't declare.
1650         * tui/tui-winsource.c
1651         (tui_source_window_base::show_exec_info_content): Rename from
1652         tui_show_exec_info_content.
1653         (tui_source_window_base::update_exec_info): Update.
1654
1655 2019-08-13  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1658         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1659         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1660         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1661         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1662         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1663         ... here.
1664
1665 2019-08-13  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-winsource.h (struct tui_source_window_base)
1668         <update_exec_info>: Declare.
1669         (tui_update_exec_info): Don't declare.
1670         * tui/tui-winsource.c (tui_update_source_window_as_is)
1671         (tui_source_window_base::refresh_all)
1672         (tui_update_all_breakpoint_info): Update.
1673         (tui_source_window_base::update_exec_info): Rename from
1674         tui_update_exec_info.
1675         * tui/tui-stack.c (tui_show_frame_info): Update.
1676
1677 2019-08-13  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-winsource.h (struct tui_source_window_base)
1680         <set_exec_info_content>: Declare.
1681         (tui_set_exec_info_content): Don't declare.
1682         * tui/tui-winsource.c
1683         (tui_source_window_base::set_exec_info_content): Rename from
1684         tui_set_exec_info_content.
1685         (tui_update_exec_info): Update.
1686
1687 2019-08-13  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-winsource.h (struct tui_source_window_base)
1690         <show_source_content>: Declare.
1691         (tui_show_source_content): Don't declare.
1692         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1693         (tui_source_window_base::show_source_content): Rename from
1694         tui_show_source_content.
1695         (tui_source_window_base::refresh_all): Update.
1696         * tui/tui-layout.c (show_source_disasm_command)
1697         (show_source_or_disasm_and_command): Update.
1698
1699 2019-08-13  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-winsource.c (tui_erase_source_content)
1702         (tui_show_source_content, tui_source_window_base::refresh_all):
1703         Update.
1704         * tui/tui-wingeneral.h
1705         (tui_check_and_display_highlight_if_needed): Don't declare.
1706         * tui/tui-wingeneral.c
1707         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1708         check_and_display_highlight_if_needed.
1709         * tui/tui-win.c (tui_rehighlight_all)
1710         (tui_win_info::make_visible_with_new_height): Update.
1711         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1712         (tui_data_window::erase_data_content)
1713         (tui_data_window::display_all_data): Update.
1714         * tui/tui-data.h (struct tui_win_info)
1715         <check_and_display_highlight_if_needed>: Declare.
1716
1717 2019-08-13  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-win.c (tui_resize_all): Call
1720         tui_delete_invisible_windows.
1721         * tui/tui-layout.c (show_layout): Call
1722         tui_delete_invisible_windows.
1723         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1724         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1725
1726 2019-08-13  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1729         tui_add_win_to_layout.
1730
1731 2019-08-13  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1734         * tui/tui-layout.c (tui_default_win_height): Now static.
1735
1736 2019-08-13  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1739         single switch.
1740         (show_source_disasm_command, show_source_or_disasm_and_command):
1741         Don't check current layout.
1742
1743 2019-08-13  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-wingeneral.c (make_all_visible): Remove.
1746         (tui_make_all_invisible): Simplify.
1747         * tui/tui-layout.c (tui_make_all_invisible): Move from
1748         tui-wingeneral.c; simplify.
1749         (show_layout): Hoist call to tui_make_all_invisible.
1750         (show_data): Don't call tui_make_all_invisible.
1751
1752 2019-08-13  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1755         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1756
1757 2019-08-13  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1760         tui-data.c.
1761         (show_source_disasm_command, show_data)
1762         (show_source_or_disasm_and_command): Don't use
1763         tui_set_current_layout_to.
1764         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1765         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1766         tui-layout.c.
1767         (tui_set_current_layout_to): Remove.
1768
1769 2019-08-13  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-layout.c (tui_set_layout): Update.
1772         * tui/tui-data.h (struct tui_layout_def): Remove.
1773         (tui_layout_def): Don't declare.
1774         * tui/tui-data.c (layout_def): Remove.
1775         (tui_layout_def): Remove.
1776
1777 2019-08-13  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.h (struct tui_source_window_base)
1780         <clear_detail>: No longer "override".
1781         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1782         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1783         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1784         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1785         Remove.
1786         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1787
1788 2019-08-13  Tom Tromey  <tromey@adacore.com>
1789
1790         * tracepoint.c: Don't include readline.h or history.h.
1791
1792 2019-08-12  Tom Tromey  <tom@tromey.com>
1793
1794         * configure: Rebuild.
1795         * configure.ac: Check for readline 7.
1796         * NEWS: Mention readline 7 requirement.
1797         * README: Update.
1798
1799 2019-08-12  Tom Tromey  <tom@tromey.com>
1800
1801         * mingw-hdep.c (gdb_select): Remove readline hack.
1802
1803 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1804
1805         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1806         when the function fails.
1807
1808 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1809
1810         * s390-tdep.c (s390_type_align): New function.
1811         (s390_gdbarch_init): Set it as type_align gdbarch method.
1812
1813 2019-08-09  Tom de Vries  <tdevries@suse.de>
1814
1815         PR gdb/24591
1816         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1817         pc_low with relocation offset.
1818
1819 2019-08-07  Tom Tromey  <tromey@adacore.com>
1820
1821         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1822         (print_frame_args): Update.
1823         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1824         Update.
1825         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1826         * frame.h (struct frame_arg): Add initializers.
1827         <error>: Now a unique_xmalloc_ptr.
1828
1829 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1830
1831         * NEWS: Expand the Pointer Authentication entry.
1832         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1833         (aarch64_frame_unmask_lr): ... to this.
1834         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1835         Call aarch64_frame_unmask_lr.
1836         * frame.c (struct frame_info): Add "masked" variable.
1837         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1838         (fprint_frame): Check for masked pc.
1839         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1840         declarations.
1841         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1842         * stack.c (print_frame): Check for masked pc.
1843
1844 2019-08-06  Tom Tromey  <tom@tromey.com>
1845
1846         * stabsread.c (patch_block_stabs, read_one_struct_field)
1847         (read_enum_type): Use obstack_strndup.
1848         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1849         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1850         * dwarf2read.c (guess_full_die_structure_name)
1851         (anonymous_struct_prefix): Use obstack_strndup.
1852         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1853         * c-exp.y (yylex): Use obstack_strndup.
1854         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1855         (write_var_or_type): Use obstack_strndup.
1856
1857 2019-08-06  Tom Tromey  <tom@tromey.com>
1858
1859         * symfile.c (reread_symbols): Use obstack_strdup.
1860         * stabsread.c (read_type): Use obstack_strdup.
1861         * gdb_obstack.h (obstack_strdup): New overload.
1862         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1863         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1864         (dwarf2_canonicalize_name): Use obstack_strdup.
1865         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1866         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1867         Use obstack_strdup.
1868
1869 2019-08-06  Tom Tromey  <tom@tromey.com>
1870
1871         * gdb_obstack.h (obstack_strdup): Define.
1872         * gdb_obstack.c (obstack_strdup): Don't define.
1873
1874 2019-08-06  Tom Tromey  <tom@tromey.com>
1875
1876         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1877         obstack_strdup.
1878         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1879         obstack_strdup.
1880         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1881         * stabsread.c (common_block_start): Use obstack_strdup.
1882         * objfiles.c (set_objfile_main_name, objfile): Use
1883         obstack_strdup.
1884         * namespace.c (add_using_directive): Use obstack_strdup.
1885         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1886         * jit.c (finalize_symtab): Use obstack_strdup.
1887         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1888         (guess_partial_die_structure_name, partial_die_info::fixup)
1889         (dwarf2_name): Use obstack_strdup.
1890         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1891         obstack_strdup.
1892         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1893         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1894         obstack_strdup.
1895         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1896
1897 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1898
1899         * unittests/help-doc-selftests.c: New file.
1900         * Makefile.in: Add the new file.
1901
1902 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1903
1904         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1905         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1906         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1907         the trailing '.' is not output, and the first character is uppercased.
1908         (print_help_for_command): Update call to print_doc_line.
1909         (print_doc_of_command): Likewise.
1910         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1911         * cli/cli-option.c (append_indented_doc): Do not append newline.
1912         (build_help_option): Append newline after first appended_indented_doc
1913         only if a second call is done.
1914         (build_help): Append 2 new lines before each option, except the first
1915         one.
1916         * compile/compile.c (_initialize_compile): Add new lines after
1917         %OPTIONS%, when not at the end of the help.
1918         Change help doc or code
1919         producing the help doc to respect the invariants.
1920         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1921         Also removed the new line after 'Options:', as all other commands
1922         do not put an empty line between 'Options:' and the first option.
1923         * printcmd.c (_initialize_printcmd): Likewise.
1924         * stack.c (_initialize_stack): Likewise.
1925         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1926         incorrectly telling COMMAND is optional.
1927         * ada-lang.c (_initialize_ada_language): Change help doc or code
1928         producing the help doc to respect the invariants.
1929         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1930         * breakpoint.c (_initialize_breakpoint): Likewise.
1931         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1932         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1933         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1934         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1935         _initialize_cli_style): Likewise.
1936         * corelow.c (core_target_info): Likewise.
1937         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1938         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1939         * filesystem.c (_initialize_filesystem): Likewise.
1940         * frame.c (_initialize_frame): Likewise.
1941         * gnu-nat.c (add_task_commands): Likewise.
1942         * infcall.c (_initialize_infcall): Likewise.
1943         * infcmd.c (_initialize_infcmd): Likewise.
1944         * interps.c (_initialize_interpreter): Likewise.
1945         * language.c (_initialize_language): Likewise.
1946         * linux-fork.c (_initialize_linux_fork): Likewise.
1947         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1948         * maint.c (_initialize_maint_cmds): Likewise.
1949         * memattr.c (_initialize_mem): Likewise.
1950         * printcmd.c (_initialize_printcmd): Likewise.
1951         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1952         _RegEx): Likewise.
1953         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1954         * record-btrace.c (_initialize_record_btrace): Likewise.
1955         * record-full.c (_initialize_record_full): Likewise.
1956         * record.c (_initialize_record): Likewise.
1957         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1958         * regcache.c (_initialize_regcache): Likewise.
1959         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1960         _initialize_remote): Likewise.
1961         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1962         * serial.c (_initialize_serial): Likewise.
1963         * skip.c (_initialize_step_skip): Likewise.
1964         * source.c (_initialize_source): Likewise.
1965         * stack.c (_initialize_stack): Likewise.
1966         * symfile.c (_initialize_symfile): Likewise.
1967         * symtab.c (_initialize_symtab): Likewise.
1968         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1969         * top.c (init_main): Likewise.
1970         * tracefile-tfile.c (tfile_target_info): Likewise.
1971         * tracepoint.c (_initialize_tracepoint): Likewise.
1972         * tui/tui-win.c (_initialize_tui_win): Likewise.
1973         * utils.c (add_internal_problem_command): Likewise.
1974         * valprint.c (value_print_option_defs): Likewise.
1975
1976 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1977
1978         PR build/24886
1979         * configure.ac: Drop enable-libmcheck support.
1980         * configure, config.in: Rebuild.
1981         * libmcheck.m4: Remove.
1982         * acinclude.m4: Don't include it.
1983         * Makefile.in: Don't distribute it.
1984         * top.c (print_gdb_configuration): Don't mention it.
1985
1986 2019-08-06  Tom Tromey  <tom@tromey.com>
1987
1988         * utils.c (set_output_style): Sometimes pass stream to
1989         emit_style_escape.
1990         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1991         * record-btrace.c (btrace_insn_history): Update.
1992         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1993         method.
1994         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1995         Update initializers.
1996         <m_uiout>: New field.
1997         <m_di>: Move lower.
1998         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1999         Remove "uiout" parameter.
2000         (dump_insns): Update.
2001         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2002         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2003
2004 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2005
2006         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2007         (error_in_psymtab_expansion): Likewise.
2008         (lookup_symbol_via_quick_fns): Likewise.
2009         (basic_lookup_transparent_type_quick): Likewise.
2010         (basic_lookup_transparent_type_1): Likewise.
2011
2012 2019-08-06  Tom Tromey  <tromey@adacore.com>
2013
2014         * source.c (last_source_error): Now bool.
2015         (print_source_lines_base): Make "noprint" bool.  Only open
2016         source file when last_source_visited changes.
2017
2018 2019-08-06  Tom Tromey  <tromey@adacore.com>
2019
2020         * annotate.c (annotate_source_line): Use g_source_cache.
2021         * source-cache.c (source_cache::get_plain_source_lines): Change
2022         parameters.  Populate m_offset_cache.
2023         (source_cache::ensure): New method.
2024         (source_cache::get_line_charpos): New method.
2025         (extract_lines): Move lower.  Change parameters.
2026         (source_cache::get_source_lines): Move lower.
2027         * source-cache.h (class source_cache): Update comment.
2028         <get_line_charpos>: New method.
2029         <get_source_lines>: Update comment.
2030         <clear>: Clear m_offset_cache.
2031         <get_plain_source_lines>: Change parameters.
2032         <ensure>: New method
2033         <m_offset_cache>: New member.
2034         * source.c (forget_cached_source_info_for_objfile): Update.
2035         (info_source_command): Use g_source_cache.
2036         (find_source_lines, open_source_file_with_line_charpos): Remove.
2037         (print_source_lines_base, search_command_helper): Use g_source_cache.
2038         * source.h (open_source_file_with_line_charpos): Don't declare.
2039         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2040         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2041         Use g_source_cache.
2042
2043 2019-08-06  Tom Tromey  <tromey@adacore.com>
2044
2045         * source-cache.c (source_cache::get_plain_source_lines):
2046         Remove "first_line" and "last_line" parameters.
2047         (source_cache::get_source_lines): Cache plain text.
2048         * source-cache.h (class source_cache)
2049         <get_plain_source_lines>: Update.
2050
2051 2019-08-06  Tom Tromey  <tromey@adacore.com>
2052
2053         * source-cache.c (extract_lines): No longer a method.
2054         Changed type of parameter.  Include final newline.
2055         (selftests::extract_lines_test): New function.
2056         (_initialize_source_cache): Likewise.
2057         * source-cache.h (class source_cache)
2058         <extract_lines>: Don't declare.
2059
2060 2019-08-06  Tom Tromey  <tromey@adacore.com>
2061
2062         * breakpoint.c (init_breakpoint_sal): Update.
2063         (breakpoint): Update.
2064         * breakpoint.h (struct breakpoint) <filter>: Now a
2065         unique_xmalloc_ptr.
2066
2067 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2068
2069         * NEWS: Mention dictionary access on blocks.
2070         * python/py-block.c (blpy_getitem): New function.
2071         (block_object_as_mapping): New struct.
2072         (block_object_type): Use new struct for tp_as_mapping field.
2073
2074 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2075
2076         * objfiles.h (objfile): Add a comment describing partial symbols.
2077
2078 2019-08-05  Tom Tromey  <tromey@adacore.com>
2079
2080         * compile/compile.c (_initialize_compile): Use _(), not N_().
2081         * thread.c (_initialize_thread): Use _(), not N_().
2082         * stack.c (_initialize_stack): Use _(), not N_().
2083         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2084
2085 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2086
2087         * dwarf2read.c (struct dw2_symtab_iterator):
2088         <want_specific_block>: Remove.
2089         <block_index>: Change type to gdb::optional.
2090         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2091         change type of BLOCK_INDEX parameter to gdb::optional.
2092         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2093         (dw2_lookup_symbol): Don't pass argument for
2094         WANT_SPECIFIC_BLOCK.
2095         (dw2_expand_symtabs_for_function): Don't pass argument for
2096         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2097         (class dw2_debug_names_iterator)
2098         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2099         parameter, change BLOCK_INDEX type to gdb::optional.
2100         <m_want_specific_block>: Remove.
2101         <m_block_index>: Change type to gdb::optional.
2102         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2103         gdb::optional.  Re-write in function of gdb::optional.
2104         (dw2_debug_names_lookup_symbol): Don't pass argument for
2105         WANT_SPECIFIC_BLOCK.
2106         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2107         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2108         BLOCK_INDEX.
2109
2110 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2111
2112         * NEWS: Mention changes to "info sources" command.
2113
2114 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2115
2116         * symtab.c (filename_partial_match_opts): New struct type.
2117         (struct output_source_filename_data): New members
2118         regexp, c_regexp, partial_match.
2119         (output_source_filename): Use new members to decide to print file.
2120         (info_sources_option_defs): New variable.
2121         (make_info_sources_options_def_group, print_info_sources_header,
2122         info_sources_command_completer):
2123         New functions.
2124         (info_sources_command): Read new optional arguments.
2125         (_initialize_symtab): Update info sources help.
2126
2127 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2128
2129         * ada-lang.c (exception_support_info_v0): Renamed from...
2130         (default_exception_support_info): ... this.  Create new
2131         definition for v1.
2132         (ada_has_this_exception_support): Look up catch_handlers_sym.
2133         (ada_exception_support_info_sniffer): Try v0 after default.
2134
2135 2019-08-01  Tom Tromey  <tromey@adacore.com>
2136
2137         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2138         gdbarch.h.
2139
2140 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2141
2142         * s12z-tdep.c: Fix include path for s12z-opc.h.
2143
2144 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2145
2146         * NEWS: Require GNU make 3.82.
2147
2148 2019-07-16  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2151         declare.
2152
2153 2019-07-30  Tom Tromey  <tromey@adacore.com>
2154
2155         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2156
2157 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2158
2159         * printcmd.c (print_address_symbolic): Print negative offsets.
2160         (build_address_symbolic): Force signed arithmetic when computing
2161         offset.
2162
2163 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2164
2165         PR/24474: Add a function to lookup static variables.
2166         * NEWS: Mention this new function.
2167         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2168         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2169         * python/python.c (python_GdbMethods): Add new function.
2170
2171 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2172
2173         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2174         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2175         (objfpy_lookup_static_symbol): New function.
2176         (objfile_object_methods): Add new functions.
2177
2178 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2179
2180         * NEWS: Mention 'set|show print frame-info'.  Mention new
2181         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2182         backtrace argument.  Mention that python frame filtering code
2183         is now consistent with what 'backtrace' command prints.
2184
2185 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2186
2187         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2188         comments.
2189         (print_frame_info_auto, print_frame_info_source_line,
2190         print_frame_info_location, print_frame_info_source_and_location,
2191         print_frame_info_location_and_address, print_frame_info_short_location):
2192         New declarations.
2193         (struct frame_print_options): New member print_frame_info.
2194         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2195         * stack.h (get_user_print_what_frame_info): New declaration.
2196         (frame_show_address): New declaration.
2197         * stack.c (print_frame_arguments_choices): New value 'presence'.
2198         (print_frame_info_auto, print_frame_info_source_line,
2199         print_frame_info_location, print_frame_info_source_and_location,
2200         print_frame_info_location_and_address, print_frame_info_short_location,
2201         print_frame_info_choices, print_frame_info_print_what): New definitions.
2202         (print_frame_args): Only print dots for args if print frame-arguments
2203         is 'presence'.
2204         (frame_print_option_defs): New element for "frame-info".
2205         (get_user_print_what_frame_info): New function.
2206         (frame_show_address): Make non static.  Move comment to stack.h.
2207         (print_frame_info_to_print_what): New function.
2208         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2209         to decide what to print.
2210         (backtrace_command_1): Handle the new print_frame_arguments_presence
2211         value.
2212         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2213         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2214         (py_print_frame): In non-mi mode, use LOCATION as default for
2215         print_what, similarly to frame information printed directly by
2216         backtrace command. Handle frame-info user option in non MI mode.
2217
2218 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2219
2220         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2221         Add case for debugging 32-bit target on 64-bit host.  Revise
2222         comment.
2223
2224 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2225
2226         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2227         instead of find_function_entry_range_from_pc.
2228
2229 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2230
2231         * stack.c (find_frame_funname): Remove code which preferred
2232         minsym over symtab sym in "certain pathological cases".
2233
2234         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2235         parameter.  Change type of "do_demangle" to bool.
2236         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2237         Pass suitable "prefer_sym_over_minsym" flag to
2238         build_address_symbolic().  Don't output "+" for negative offsets.
2239         * printcmd.c (print_address_symbolic): Update invocation of
2240         build_address_symbolic to include a "prefer_sym_over_minsym"
2241         flag.
2242         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2243         Restrict cases in which use of minimal symbol is preferred to that
2244         of a found symbol.  Update comments.
2245
2246         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2247         for entry pc when entry pc is out of range for that FDE.
2248
2249 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2250
2251         PR gdb/24839:
2252         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2253         type.
2254
2255 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2256
2257         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2258         this function's Python signature.
2259
2260
2261 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2262
2263         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2264         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2265         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2266         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2267         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2268
2269
2270 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2271
2272         * h8300-tdep.c (h8300_register_name_common): New.
2273         h8300_register_name): Use h8300_register_name_common.
2274         (h8300s_register_name): Likewise.
2275         (h8300sx_register_name): Likewise.
2276         (h8300h_register_nam): New.
2277         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2278
2279
2280 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2281
2282         * arm-tdep.c (arm_skip_cmse_entry): New function.
2283         (arm_is_sgstubs_section): New function.
2284         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2285
2286 2019-07-22  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2289         Don't self-assign.
2290
2291 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2294         type_print.
2295
2296 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2297
2298         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2299         so that GDB doesn't match any msymbols when searching in the
2300         TYPES_DOMAIN.
2301         (print_symbol_info): Print using typedef_print or type_print based
2302         on the type of the symbol.  Add updated FIXME comment moved from...
2303         (_initialize_symtab): ... move and update FIXME comment to above.
2304
2305 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * NEWS: Mention adding -q option to "info types".
2308         * symtab.c (struct info_types_options): New struct.
2309         (info_types_options_defs): New variable.
2310         (make_info_types_options_def_group): New function.
2311         (info_types_command): Use gdb::option framework to parse options.
2312         (info_types_command_completer): New function.
2313         (_initialize_symtab): Extend the help text on "info types" and
2314         register command completer.
2315
2316 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2317
2318         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2319         (lookup_symbol_in_objfile): Change int to block_enum and add a
2320         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2321
2322 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2323
2324         * MAINTAINERS (Write After Approval): Add self.
2325
2326 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2327
2328         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2329         instruction to the dummy code region.
2330
2331 2019-07-19  Tom Tromey  <tromey@adacore.com>
2332
2333         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2334         (ARGSUSED, PARAMS, __func__): Remove rules.
2335
2336 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2337
2338         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2339         * features/arm/arm-with-iwmmxt.c: Remove.
2340         * features/arm/arm-with-iwmmxt.xml: Remove.
2341         * features/arm/arm-with-m-fpa-layout.c: Remove.
2342         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2343         * features/arm/arm-with-m-vfp-d16.c: Remove.
2344         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2345         * features/arm/arm-with-m.c: Remove.
2346         * features/arm/arm-with-m.xml: Remove.
2347         * features/arm/arm-with-neon.c: Remove.
2348         * features/arm/arm-with-neon.xml: Remove.
2349         * features/arm/arm-with-vfpv2.c: Remove.
2350         * features/arm/arm-with-vfpv2.xml: Remove.
2351         * features/arm/arm-with-vfpv3.c: Remove.
2352         * features/arm/arm-with-vfpv3.xml: Remove.
2353
2354 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2355
2356         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2357
2358 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2359
2360         * arch/aarch32.c (aarch32_create_target_description): Create
2361         target descriptions using features.
2362         * arch/arm.c (arm_create_target_description)
2363         (arm_create_mprofile_target_description): Likewise.
2364         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2365
2366 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2367
2368         * Makefile.in: Add new files.
2369         * aarch32-tdep.c: New file.
2370         * aarch32-tdep.h: New file.
2371         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2372         Call aarch32_read_description.
2373         * arch/aarch32.c: New file.
2374         * arch/aarch32.h: New file.
2375         * arch/arm.c (arm_create_target_description)
2376         (arm_create_mprofile_target_description): New function.
2377         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2378         (arm_create_target_description)
2379         (arm_create_mprofile_target_description): New declaration.
2380         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2381         read_description functions.
2382         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2383         Likewise.
2384         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2385         * arm-tdep.c (tdesc_arm_list): New variable.
2386         (arm_register_g_packet_guesses): Call create description functions.
2387         (arm_read_description) (arm_read_mprofile_description): New
2388         function.
2389         * arm-tdep.h (arm_read_description)
2390         (arm_read_mprofile_description): Add declaration.
2391         * configure.tgt: Add new files.
2392
2393 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2394
2395         * top.c (new_ui_command): Open specified terminal just once.
2396
2397 2019-07-18  Tom Tromey  <tromey@adacore.com>
2398
2399         * symtab.c (main_name): Constify return type.
2400         * symfile.c (set_initial_language): Update.
2401         * symtab.h (main_name): Constify return type.
2402
2403 2019-07-17  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-winsource.c (tui_update_source_window)
2406         (tui_update_source_window_as_is)
2407         (tui_update_source_windows_with_line): Remove return.
2408         * tui/tui-disasm.c (tui_show_disassem)
2409         (tui_show_disassem_and_update_source): Remove return.
2410         * tui/tui.c (tui_reset): Remove return.
2411         * tui/tui-wingeneral.c
2412         (tui_check_and_display_highlight_if_needed): Remove return.
2413
2414 2019-07-17  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2417
2418 2019-07-17  Tom Tromey  <tom@tromey.com>
2419
2420         * tui/tui-winsource.h (struct tui_exec_info_window)
2421         (struct tui_source_window_base): Move from tui-data.h.
2422         * tui/tui-winsource.c: Move many method definitions from
2423         elsewhere.  Remove "structuring" comments.
2424         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2425         (tui_source_window_base::refresh_window): Move to
2426         tui-winsource.c.
2427         * tui/tui-win.c (tui_source_window_base::refresh_all)
2428         (tui_source_window_base::update_tab_width)
2429         (tui_source_window_base::set_new_height)
2430         (tui_source_window_base::do_make_visible_with_new_height): Move to
2431         tui-winsource.c.
2432         * tui/tui-source.h: Update.
2433         * tui/tui-source.c (tui_source_window_base::reset): Move to
2434         tui-winsource.c.
2435         * tui/tui-disasm.h: Update.
2436         * tui/tui-data.h (struct tui_exec_info_window): Move to
2437         tui-winsource.h.
2438         (struct tui_source_window_base): Likewise.
2439         * tui/tui-data.c (tui_source_window_base::clear_detail)
2440         (tui_source_window_base, ~tui_source_window_base): Move to
2441         tui-winsource.c.
2442
2443 2019-07-17  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui-win.c (tui_resize_all)
2446         (tui_source_window_base::update_tab_width)
2447         (tui_adjust_win_heights): Update.
2448         (tui_win_info::make_invisible_and_set_new_height): Rename from
2449         make_invisible_and_set_new_height.
2450         * tui/tui-data.h (struct tui_win_info)
2451         <make_invisible_and_set_new_height>: New method.
2452
2453 2019-07-17  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui.c: Update.
2456         * tui/tui-source.h (struct tui_source_window): Move from
2457         tui-data.h.
2458         * tui/tui-layout.c: Update.
2459         * tui/tui-disasm.c: Update.
2460         * tui/tui-data.h (struct tui_source_window): Move to
2461         tui-source.h.
2462
2463 2019-07-17  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2466         tui-data.h.
2467         * tui/tui-data.h (struct tui_disasm_window): Move to
2468         tui-disasm.h.
2469
2470 2019-07-17  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui-regs.h (struct tui_data_item_window): Move from
2473         tui-data.h.
2474         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2475         * tui/tui-data.h (struct tui_data_item_window): Move to
2476         tui-regs.h.
2477         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2478
2479 2019-07-17  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui.c: Update.
2482         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2483         (tui_cmd_window::max_height): Move to tui-command.c.
2484         * tui/tui-layout.c: Update.
2485         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2486         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2487         tui-command.c.
2488         * tui/tui-command.h (struct tui_cmd_window): Move from
2489         tui-data.h.
2490         * tui/tui-command.c: Remove "structuring" comments.
2491         (tui_cmd_window::clear_detail)
2492         (tui_cmd_window::do_make_visible_with_new_height)
2493         (tui_cmd_window::max_height): Move from elsewhere.
2494
2495 2019-07-17  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2498         Now static.
2499         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2500         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2501
2502 2019-07-17  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui.c: Update.
2505         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2506         tui-regs.c.
2507         * tui/tui-windata.h: Remove file.
2508         * tui/tui-windata.c: Remove file.
2509         * tui/tui-win.c (tui_data_window::set_new_height)
2510         (tui_data_window::do_make_visible_with_new_height): Move to
2511         tui-regs.c.
2512         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2513         * tui/tui-regs.c: Remove "structuring" comments.
2514         (tui_data_window::first_data_item_displayed)
2515         (tui_data_window::delete_data_content_windows)
2516         (tui_data_window::erase_data_content)
2517         (tui_data_window::display_all_data)
2518         (tui_data_window::refresh_all)
2519         (tui_data_window::do_scroll_vertical)
2520         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2521         (tui_data_window::do_make_visible_with_new_height)
2522         (tui_data_window::refresh_window): Move from elsewhere.
2523         (_initialize_tui_regs): Move to end of file.
2524         * tui/tui-layout.c: Update.
2525         * tui/tui-hooks.c: Update.
2526         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2527         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2528         tui-regs.c.
2529         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2530
2531 2019-07-17  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2534         seen.
2535
2536 2019-07-17  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-win.c (tui_source_window_base::set_new_height)
2539         (tui_source_window_base::do_make_visible_with_new_height): Use
2540         m_has_locator field directly.
2541         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2542         method.
2543         (struct tui_source_window_base) <has_locator>: Likewise.
2544
2545 2019-07-17  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2548         Don't declare.
2549         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2550         Remove.
2551         * tui/tui-win.c (tui_source_window_base::set_new_height)
2552         (tui_source_window_base::set_new_height)
2553         (make_invisible_and_set_new_height)
2554         (tui_source_window_base::do_make_visible_with_new_height)
2555         (tui_source_window_base::do_make_visible_with_new_height):
2556         Update.
2557         * tui/tui-layout.c (show_source_disasm_command, show_data)
2558         (show_source_or_disasm_and_command): Update.
2559         * tui/tui-layout.c (show_layout): Update.
2560
2561 2019-07-17  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-layout.c (make_data_window): Remove.
2564         (show_data): Unify creation and re-initialization cases.
2565
2566 2019-07-17  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-layout.c (make_source_window, make_disasm_window):
2569         Remove.
2570         (show_data): Unify creation and re-initialization cases.
2571
2572 2019-07-17  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-layout.c (make_command_window): Remove.
2575         (show_source_disasm_command, show_source_or_disasm_and_command):
2576         Unify creation and re-initialization cases.
2577
2578 2019-07-17  Tom Tromey  <tom@tromey.com>
2579
2580         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2581         creation and re-initialization cases.
2582
2583 2019-07-17  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-regs.c (tui_get_register): Return void.
2586
2587 2019-07-17  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2590         Simplify.
2591
2592 2019-07-17  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2595         resetting.
2596
2597 2019-07-17  Tom Tromey  <tom@tromey.com>
2598
2599         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2600         * tui/tui-regs.c (tui_reg_layout): New function.
2601         (tui_show_registers, tui_reg_command): Use it.
2602         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2603         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2604         parameters.
2605         (tui_layout_command): Remove.
2606
2607 2019-07-17  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-layout.h (tui/tui-layout): Return void.
2610         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2611
2612 2019-07-17  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-layout.c (show_source_disasm_command, show_data):
2615         Update.
2616         (reset_locator): Remove.
2617         (show_source_or_disasm_and_command): Update.
2618
2619 2019-07-17  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-source.c (tui_source_window_base::reset): Remove
2622         win_type parameter.
2623         * tui/tui-layout.c (make_command_window, make_source_window)
2624         (make_disasm_window, make_data_window)
2625         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2626         (reset_locator, show_source_or_disasm_and_command): Update.
2627         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2628         win_type parameter.
2629         (struct tui_source_window_base) <reset>: Likewise.
2630
2631 2019-07-17  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-layout.c (show_source_disasm_command): Use
2634         reset_locator.
2635         (reset_locator): New function.
2636         (init_and_make_win): Remove.
2637         (show_source_or_disasm_and_command): Use reset_locator.
2638
2639 2019-07-17  Tom Tromey  <tom@tromey.com>
2640
2641         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2642         condition.
2643         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2644         Remove condition.
2645         * tui/tui-source.c (tui_source_window_base::reset): New method.
2646         * tui/tui-layout.c (make_command_window): Don't call
2647         init_and_make_win.
2648         (make_source_window, make_disasm_window): Don't call
2649         make_source_or_disasm_window.
2650         (make_data_window): Don't call init_and_make_win.  Change calling
2651         convention.
2652         (show_source_disasm_command, show_data): Simplify.
2653         (make_source_or_disasm_window): Remove.
2654         (show_source_or_disasm_and_command): Simplify.
2655         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2656         (struct tui_source_window_base) <reset>: Likewise.
2657         <execution_info>: Remove initializer.
2658         * tui/tui-data.c (tui_source_window_base): Initialize
2659         execution_info.
2660
2661 2019-07-17  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2664         variable.
2665
2666 2019-07-17  Tom Tromey  <tom@tromey.com>
2667
2668         * tui/tui.c (tui_rl_other_window): Update.
2669         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2670         superclass method first.  Always iterate over regs_content.
2671         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2672         method.
2673         * tui/tui-win.c (tui_set_focus_command): Update.
2674
2675 2019-07-17  Tom Tromey  <tom@tromey.com>
2676
2677         * tui/tui-win.c (tui_set_focus_command): Rename from
2678         tui_set_focus.  Call tui_enable.
2679         (tui_set_focus_command): Remove.
2680
2681 2019-07-17  Tom Tromey  <tom@tromey.com>
2682
2683         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2684         refresh_window.
2685         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2686         touchwin.
2687         (tui_data_window::refresh_window): Call refresh_window on data
2688         items.  Always call superclass refresh_window.
2689         (tui_win_info::refresh): Remove.
2690         (tui_source_window_base::refresh_window): Update.
2691         (tui_refresh_all): Update.
2692         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2693         refresh_window.
2694         (show_source_or_disasm_and_command): Likewise.
2695         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2696         (struct tui_source_window_base) <refresh>: Likewise.
2697
2698 2019-07-17  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui-winsource.c (tui_clear_source_content)
2701         (tui_show_source_content): Update.
2702         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2703         whether content is empty.
2704         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2705         Remove.
2706
2707 2019-07-17  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2710         window's contents.
2711         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2712         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2713
2714 2019-07-17  Tom Tromey  <tom@tromey.com>
2715
2716         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2717         (struct tui_data_item_window): Update.
2718
2719 2019-07-17  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2722         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2723         defines.
2724
2725 2019-07-17  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-winsource.h (tui_erase_source_content)
2728         (tui_clear_source_content): Remove "display_prompt" parameter.
2729         * tui/tui-winsource.c (tui_update_source_window_as_is)
2730         (tui_update_source_windows_with_addr): Update.
2731         (tui_clear_source_content): Remove "display_prompt" parameter.
2732         (tui_erase_source_content): Likewise.  Simplify.
2733         (tui_show_source_content): Update.
2734         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2735         * tui/tui-stack.c (tui_show_frame_info): Update.
2736         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2737         Remove defines.
2738
2739 2019-07-17  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2742         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2743         parameter.
2744         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2745         parameter.
2746
2747 2019-07-17  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-winsource.c (tui_clear_source_content)
2750         (tui_show_source_content, tui_show_exec_info_content)
2751         (tui_clear_exec_info_content): Update.
2752         * tui/tui-stack.c (tui_show_locator_content): Update.
2753         (tui_show_frame_info): Update.
2754         * tui/tui-source.h (tui_source_window): Don't declare.
2755         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2756         from tui_source_is_displayed.
2757         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2758         Remove field.
2759         (struct tui_source_window_base) <content_in_use>: New field.  Now
2760         bool.
2761         (struct tui_source_window) <showing_source_p>: New method.
2762         (TUI_SRC_WIN): Change cast.
2763         * tui/tui-data.c (tui_initialize_static_data): Update.
2764
2765 2019-07-17  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2768         location_matches_p.
2769         * tui/tui-source.c (tui_source_window::location_matches_p): New
2770         method.
2771         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2772         method.
2773         * tui/tui-data.h (struct tui_source_window_base)
2774         <location_matches_p>: New method.
2775         (struct tui_source_window, struct tui_disasm_window)
2776         <location_matches_p>: Likewise.
2777
2778 2019-07-17  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui-win.c (tui_set_win_height_command): Rename from
2781         tui_set_win_height.
2782         (tui_set_win_height_command): Remove.
2783
2784 2019-07-17  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-source.c (tui_source_window): New constructor.  Add
2787         observer.
2788         (~tui_source_window): New destructor.
2789         (tui_source_window::style_changed): New method.
2790         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2791         (tui_attach_detach_observers): Update.
2792         * tui/tui-data.h (struct tui_source_window): Make constructor not
2793         inline.  Add destructor.
2794         (struct tui_source_window) <style_changed>: New method.
2795         <m_observable>: New member.
2796
2797 2019-07-17  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2800         * tui/tui-win.c (tui_resize_all): Fix typo.
2801
2802 2019-07-17  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2805         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2806         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2807         * tui/tui-win.c (window_name_completer): Use foreach.
2808         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2809         (update_tab_width): Likewise.
2810         * tui/tui-layout.c (show_layout): Update.
2811         * tui/tui-data.h (class tui_window_iterator): New.
2812         (struct all_tui_windows): New.
2813         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2814
2815 2019-07-17  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2818         parameter.  Don't reference globals.
2819         (tui_reg_command): Update.
2820
2821 2019-07-17  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-regs.c (tui_show_registers): Simplify.
2824
2825 2019-07-17  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-regs.c (tui_show_registers): Update.
2828         (tui_show_register_group): Add win_info parameter.
2829
2830 2019-07-17  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2833         Rename from tui_display_reg_element_at_line.
2834         (tui_data_window::display_registers_from_line): Update.
2835         * tui/tui-data.h (struct tui_data_window)
2836         <display_reg_element_at_line>: New method.
2837
2838 2019-07-17  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-regs.h (tui_display_registers_from)
2841         (tui_display_registers_from_line): Don't declare.
2842         * tui/tui-windata.c (tui_data_window::display_all_data)
2843         (tui_data_window::refresh_all)
2844         (tui_data_window::do_scroll_vertical): Update.
2845         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2846         from tui_display_registers_from.
2847         (tui_display_reg_element_at_line): Update.
2848         (tui_data_window::display_registers_from_line): Rename from
2849         tui_display_registers_from_line.
2850         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2851         display_registers_from_line>: New methods.
2852
2853 2019-07-17  Tom Tromey  <tom@tromey.com>
2854
2855         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2856         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2857         from tui_erase_data_content.
2858         (tui_data_window::display_all_data)
2859         (tui_data_window::refresh_all)
2860         (tui_data_window::do_scroll_vertical): Update.
2861         * tui/tui-regs.c (tui_show_registers): Update.
2862         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2863         New method.
2864
2865 2019-07-17  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2868         declare.
2869         * tui/tui-windata.c
2870         (tui_data_window::delete_data_content_windows): Rename from
2871         tui_delete_data_content_windows.
2872         (tui_data_window::display_all_data)
2873         (tui_data_window::do_scroll_vertical): Update.
2874         * tui/tui-data.h (struct tui_data_window)
2875         <delete_data_content_windows>: New method.
2876
2877 2019-07-17  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2880         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2881
2882 2019-07-17  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2885         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2886         from tui_display_all_data.
2887         * tui/tui-win.c
2888         (tui_data_window::do_make_visible_with_new_height): Update.
2889         * tui/tui-regs.c (tui_show_registers): Update.
2890         * tui/tui-layout.c (tui_set_layout): Update.
2891         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2892         method.
2893
2894 2019-07-17  Tom Tromey  <tom@tromey.com>
2895
2896         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2897         * tui/tui-windata.c (tui_display_data_from): Remove.
2898         (tui_data_window::refresh_all): Update.
2899
2900 2019-07-17  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2903         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2904         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2905         tui_display_registers_from_line.
2906         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2907         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2908         "force_display" parameter.
2909
2910 2019-07-17  Tom Tromey  <tom@tromey.com>
2911
2912         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2913         declare.
2914         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2915         Rename from tui_first_reg_element_no_inline.
2916         (tui_display_reg_element_at_line)
2917         (tui_display_registers_from_line): Update.
2918         * tui/tui-data.h (struct tui_data_window)
2919         <first_reg_element_no_inline>: New method.
2920
2921 2019-07-17  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-windata.c (tui_display_data_from)
2924         (tui_data_window::do_scroll_vertical): Update.
2925         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2926         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2927         Rename from tui_line_from_reg_element_no.
2928         (tui_display_registers_from_line): Update.
2929         * tui/tui-data.h (struct tui_data_window)
2930         <line_from_reg_element_no>: New method.
2931
2932 2019-07-17  Tom Tromey  <tom@tromey.com>
2933
2934         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2935         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2936         tui_last_regs_line_no.
2937         (tui_display_reg_element_at_line)
2938         (tui_display_registers_from_line): Update.
2939         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2940         method.
2941
2942 2019-07-17  Tom Tromey  <tom@tromey.com>
2943
2944         PR tui/24722:
2945         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2946         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2947         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2948         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2949         (tui_update_breakpoint_info): Likewise.
2950         * tui/tui-hooks.c (tui_event_create_breakpoint)
2951         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2952         Update.
2953
2954 2019-07-17  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2957
2958 2019-07-17  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-winsource.c (tui_update_source_window_as_is)
2961         (tui_update_source_windows_with_addr): Update.
2962         * tui/tui-source.h (tui_set_source_content)
2963         (tui_show_symtab_source): Add "win_info" parameter.
2964         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2965         parameter.
2966         (tui_show_symtab_source): Likewise.
2967
2968 2019-07-17  Tom Tromey  <tom@tromey.com>
2969
2970         * tui/tui-wingeneral.c
2971         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2972
2973 2019-07-17  Tom Tromey  <tom@tromey.com>
2974
2975         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2976         (struct tui_cmd_window) <can_scroll>: New method.
2977         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2978         method.
2979
2980 2019-07-17  Tom Tromey  <tromey@adacore.com>
2981
2982         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2983         do_field_signed>: Rename.  Change type of "value".
2984         * ui-out.c (ui_out::field_signed): Rename from field_int.
2985         Change type of "value".
2986         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2987         type of "value".
2988         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2989         do_field_int.  Change type of "value".
2990         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2991         do_field_int.  Change type of "value".
2992         * tracepoint.c (trace_status_mi, tfind_1)
2993         (print_one_static_tracepoint_marker): Update.
2994         * thread.c (print_thread_info_1, print_selected_thread_frame):
2995         Update.
2996         * stack.c (print_frame, print_frame_info): Update.
2997         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2998         Update.
2999         * source.c (print_source_lines_base): Update.
3000         * skip.c (info_skip_command): Update.
3001         * record-btrace.c (btrace_ui_out_decode_error)
3002         (btrace_call_history_src_line): Update.
3003         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3004         Update.
3005         * progspace.c (print_program_space): Update.
3006         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3007         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3008         do_field_int.  Change type of "value".
3009         * mi/mi-out.c (mi_ui_out::do_table_begin)
3010         (mi_ui_out::do_table_header): Update.
3011         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3012         type of "value".
3013         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3014         (mi_cmd_data_list_changed_registers, output_register)
3015         (mi_cmd_data_read_memory, mi_load_progress)
3016         (mi_cmd_trace_frame_collected): Update.
3017         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3018         Update.
3019         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3020         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3021         (mi_cmd_var_list_children, varobj_update_one): Update.
3022         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3023         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3024         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3025         * inferior.c (print_inferior): Update.
3026         * gdb_bfd.c (print_one_bfd): Update.
3027         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3028         Update.
3029         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3030         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3031         do_field_int.  Change type of "value".
3032         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3033         do_field_int.  Change type of "value".
3034         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3035         (print_one_breakpoint_location, print_it_catch_fork)
3036         (print_one_catch_fork, print_it_catch_vfork)
3037         (print_one_catch_vfork, print_it_catch_solib)
3038         (print_it_catch_exec, print_it_ranged_breakpoint)
3039         (print_mention_watchpoint, print_mention_masked_watchpoint)
3040         (bkpt_print_it, update_static_tracepoint): Update.
3041         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3042         * break-catch-syscall.c (print_it_catch_syscall): Update.
3043         * ada-tasks.c (print_ada_task_info): Update.
3044         * ada-lang.c (print_it_exception, print_mention_exception):
3045         Update.
3046
3047 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3048
3049         PR breakpoints/24541
3050         * gdbarch.c: Regenerate.
3051         * gdbarch.h: Regenerate.
3052         * gdbarch.sh: Adjust return type and parameter types for
3053         'stap_adjust_register'.
3054         (i386_stap_adjust_register): Adjust signature and return new
3055         register name.
3056         * stap-probe.c (stap_parse_register_operand): Adjust use of
3057         'gdbarch_stap_adjust_register'.
3058
3059 2019-07-17  Tom Tromey  <tromey@adacore.com>
3060
3061         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3062         declare VEC.
3063         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3064         std::vector.
3065         (struct s390_process_info): Add initializers.
3066         (s390_add_process): Use new.
3067         (s390_linux_nat_target::low_forget_process): Use delete.
3068         (s390_linux_nat_target::low_new_fork)
3069         (s390_linux_nat_target::stopped_by_watchpoint)
3070         (s390_linux_nat_target::low_prepare_to_resume)
3071         (s390_linux_nat_target::insert_watchpoint)
3072         (s390_linux_nat_target::insert_hw_breakpoint)
3073         (s390_linux_nat_target::remove_watchpoint)
3074         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3075
3076 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3077
3078         * aarch64-fbsd-nat.c: Include regcache.h.
3079         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3080         argument.
3081         (aarch64_fbsd_nat_target::fetch_registers)
3082         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3083         variable.
3084         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3085
3086 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3087
3088         * fbsd-nat.c: Include gdbarch.h.
3089
3090 2019-07-15  Tom Tromey  <tromey@adacore.com>
3091
3092         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3093
3094 2019-07-15  Tom Tromey  <tromey@adacore.com>
3095
3096         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3097         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3098         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3099         * cli-out.c (cli_ui_out::do_field_int): New method.
3100         * ui-out.c (ui_out::field_unsigned): New method.
3101         * symfile.c (generic_load): Use field_unsigned.
3102         (print_transfer_performance): Likewise.
3103         * record-btrace.c (ui_out_field_uint): Remove.
3104         (btrace_call_history_insn_range, btrace_call_history): Use
3105         field_unsigned.
3106         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3107         field_unsigned.
3108         * ui-out.h (class ui_out) <field_unsigned>: New method.
3109         <do_field_unsigned>: Likewise.
3110
3111 2019-07-15  Tom Tromey  <tromey@adacore.com>
3112
3113         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3114         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3115         * target.c (flash_erase_command): Use field_string.
3116         * infrun.c (print_signal_received_reason): Use field_string.
3117         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3118         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3119         field_string.
3120         * ada-tasks.c (print_ada_task_info): Use field_string.
3121
3122 2019-07-15  Tom Tromey  <tromey@adacore.com>
3123
3124         * target.c (flash_erase_command): Use field_core_addr.
3125         * symfile.c (generic_load): Use field_core_addr.
3126         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3127         Use field_core_addr.
3128         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3129         field_core_addr.
3130
3131 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3132
3133         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3134         value if its desired type is smaller than a CORE_ADDR and signed.
3135
3136 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3137
3138         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3139         of changes to field names, and use new is_reference field to
3140         decide if a property is a reference or not.
3141         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3142         field.
3143         (struct dwarf2_property_baton): Update header comment, rename
3144         'referenced_type' to 'property_type' and update comments.
3145         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3146         default property type, store in property baton, update to take
3147         accound of renamed field.
3148         (read_func_scope): Update call to attr_to_dynamic_prop.
3149         (read_array_type): Likewise.
3150         (dwarf2_per_cu_addr_sized_int_type): New function.
3151         (read_subrange_index_type): Move type finding code to
3152         dwarf2_per_cu_addr_sized_int_type.
3153         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3154         (dwarf2_per_cu_addr_type): New function.
3155         (set_die_type): Update calls to attr_to_dynamic_prop.
3156
3157 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3158
3159         * dwarf2read.c (read_subrange_index_type): New function.
3160         (read_subrange_type): Move code into new function and call it.
3161         * gdbtypes.c (create_range_type): Add some asserts.
3162
3163 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3164
3165         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3166         update return statements.
3167         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3168         declaration, and update comment to match.
3169         * gdbtypes.c (resolve_dynamic_array): Update call to
3170         dwarf2_evaluate_property to match new return type.
3171
3172 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3173
3174         * valarith.c (value_subscripted_rvalue): Change lowerbound
3175         parameter type from int to LONGEST.
3176         * value.h (value_subscripted_rvalue): Likewise in declaration.
3177
3178 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * cli/cli-utils.c (info_print_command_completer): New function.
3181         * cli/cli-utils.h: Add 'completer.h' include, and forward
3182         declaration for 'struct cmd_list_element'.
3183         (info_print_command_completer): Declare.
3184         * stack.c (_initialize_stack): Add completer for 'info locals' and
3185         'info args'.
3186         * symtab.c (_initialize_symtab): Add completer for 'info
3187         variables' and 'info functions'.
3188         * NEWS: Mention completion for additional info commands.
3189
3190 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3191
3192         * cli/cli-utils.c (extract_info_print_args): Delete.
3193         (extract_arg_maybe_quoted): Delete.
3194         (info_print_options_defs): New variable.
3195         (make_info_print_options_def_group): New function.
3196         (extract_info_print_options): Define new function.
3197         * cli/cli-utils.h (extract_info_print_args): Delete.
3198         (struct info_print_options): New structure.
3199         (extract_info_print_options): Declare new function.
3200         * stack.c (info_locals_command): Update to use new
3201         extract_info_print_options, also add a header comment.
3202         (info_args_command): Likewise.
3203         * symtab.c (info_variables_command): Likewise.
3204         (info_functions_command): Likewise.
3205
3206 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3207
3208         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3209         to extract string arguments.
3210         * common/common-utils.c (extract_string_maybe_quoted): New function.
3211         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3212
3213 2019-07-11  Tom Tromey  <tromey@adacore.com>
3214
3215         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3216         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3217         * top.h (gdbinit): Don't declare.
3218         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3219         into...
3220         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3221         * top.c (gdb_init): Don't call init_cli_cmds.
3222         (gdbinit): Remove.
3223         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3224
3225 2019-07-11  Tom Tromey  <tromey@adacore.com>
3226
3227         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3228         after it has been moved.
3229
3230 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3231
3232         * valops.c (value_must_coerce_to_target): Change return type to
3233         bool.
3234         * value.h (value_must_coerce_to_target): Likewise.
3235
3236 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3237
3238         * breakpoint.c (is_hardware_watchpoint): Remove
3239         forward-declaration.
3240         (is_masked_watchpoint): Change return type to bool.
3241         (is_tracepoint): Likewise.
3242         (is_breakpoint): Likewise.
3243         (is_hardware_watchpoint): Likewise.
3244         (is_watchpoint): Likewise.
3245         (is_no_memory_software_watchpoint): Likewise.
3246         (is_catchpoint): Likewise.
3247         (breakpoint_1): Make FILTER parameter's return type bool.
3248         is_masked_watchpoint): Change return type to bool.
3249         (save_breakpoints): Make FILTER parameter's return type bool.
3250         * breakpoint.h (is_breakpoint): Change return type to bool.
3251         (is_watchpoint): Likewise.
3252         (is_catchpoint): Likewise.
3253         (is_tracepoint): Likewise.
3254
3255 2019-07-10  Tom Tromey  <tom@tromey.com>
3256
3257         * defs.h: Don't include gdbarch.h.
3258         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3259         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3260         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3261         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3262         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3263         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3264         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3265         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3266         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3267         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3268         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3269         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3270         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3271         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3272         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3273         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3274         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3275         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3276         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3277         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3278         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3279         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3280         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3281         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3282         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3283         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3284         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3285
3286 2019-07-10  Tom Tromey  <tromey@adacore.com>
3287
3288         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3289         * breakpoint.c (init_ada_exception_breakpoint): Register as
3290         bp_catchpoint.
3291         (print_one_breakpoint_location, print_one_breakpoint): Use
3292         is_ada_exception_catchpoint.
3293         * ada-lang.c (class ada_catchpoint_location): Pass
3294         bp_loc_software_breakpoint to bp_location constructor.
3295         (is_ada_exception_catchpoint): New function.
3296
3297 2019-07-10  Tom Tromey  <tromey@adacore.com>
3298
3299         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3300         VEC.
3301         (struct arm_exidx_entry): New method operator<.
3302         (struct arm_exidx_data) <section_maps>: Change type.
3303         (arm_exidx_data_free): Remove.
3304         (arm_exidx_data_key): Change type.  Move lower.
3305         (arm_exidx_new_objfile): Update.
3306         (arm_compare_exidx_entries): Remove.
3307         (arm_find_exidx_entry, _initialize_arm_tdep)
3308
3309 2019-07-10  Tom Tromey  <tromey@adacore.com>
3310
3311         * solib-spu.c (ocl_program_data_key): Change type.
3312         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3313         Update.
3314
3315 2019-07-10  Tom Tromey  <tromey@adacore.com>
3316
3317         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3318         (struct solib_aix_inferior_data) <library_list>: Change type.
3319         (solib_aix_inferior_data_handle): Change type.
3320         (get_solib_aix_inferior_data): Update.
3321         (solib_aix_free_library_list): Remove.
3322         (library_list_start_library): Update.
3323         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3324         return type.
3325         (solib_aix_get_library_list)
3326         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3327         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3328
3329 2019-07-10  Tom Tromey  <tromey@adacore.com>
3330
3331         * solib-dsbt.c (struct dsbt_info): Add initializers.
3332         (solib_dsbt_pspace_data): Change type.
3333         (dsbt_pspace_data_cleanup): Remove.
3334         (get_dsbt_info, _initialize_dsbt_solib): Update.
3335
3336 2019-07-10  Tom Tromey  <tromey@adacore.com>
3337
3338         * spu-tdep.c (spu_overlay_data): Change type.
3339         (spu_get_overlay_table, spu_overlay_new_objfile)
3340         (_initialize_spu_tdep): Update.
3341
3342 2019-07-10  Tom Tromey  <tromey@adacore.com>
3343
3344         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3345         destructor.
3346         (dbx_objfile_data_key): Change type and declare later.
3347         (DBX_SYMFILE_INFO): Rewrite.
3348         * dbxread.c (dbx_objfile_data_key): Change type.
3349         (dbx_symfile_init): Update.
3350         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3351         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3352         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3353
3354 2019-07-10  Tom Tromey  <tromey@adacore.com>
3355
3356         * jit.c (jit_program_space_key): Change type.  Move lower.
3357         (get_jit_program_space_data): Update.
3358         (jit_program_space_data_cleanup): Remove.
3359         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3360         Update.
3361         (struct jit_program_space_data): Add initializers.
3362
3363 2019-07-10  Tom Tromey  <tromey@adacore.com>
3364
3365         * solib-darwin.c (struct darwin_info): Add initializers.
3366         (solib_darwin_pspace_data): Change type.
3367         (darwin_pspace_data_cleanup): Remove.
3368         (get_darwin_info, _initialize_darwin_solib): Update.
3369
3370 2019-07-10  Tom Tromey  <tromey@adacore.com>
3371
3372         * remote-sim.c (struct sim_inferior_data): Add initializers,
3373         constructor, and destructor.
3374         (sim_inferior_data_key): Change type.  Move lower.
3375         (check_for_duplicate_sim_descriptor): Update.
3376         (get_sim_inferior_data): Use new.  Update.
3377         (~sim_inferior_data_cleanup): Rename from
3378         sim_inferior_data_cleanup.  Simplify.
3379         (gdbsim_close_inferior, simulator_command)
3380         (sim_command_completer, _initialize_remote_sim): Update.
3381         (next_pid, INITIAL_PID): Move earlier.
3382
3383 2019-07-10  Tom Tromey  <tromey@adacore.com>
3384
3385         * python/python-internal.h (create_thread_object): Return
3386         gdbpy_ref.
3387         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3388         * python/py-inferior.c (struct threadlist_entry): Add
3389         constructor.
3390         <thread_obj>: Now a gdbpy_ref.
3391         (thread_to_thread_object): Update.
3392         (add_thread_object): Use new.
3393         (delete_thread_object): Use delete.
3394         (infpy_threads): Update.
3395         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3396         GIL.
3397
3398 2019-07-10  Tom Tromey  <tromey@adacore.com>
3399
3400         * valops.c (value_cast): Specialize error message for Ada.
3401
3402 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3403
3404         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3405
3406 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3407
3408         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3409         bpstat_should_step): Return bool, adjust comments.
3410         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3411         bpstat_should_step): Likewise.
3412
3413 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3414
3415         * features/Makefile: Use feature target descriptions for Arm.
3416         * features/arm/arm-core.c: Generate new file.
3417         * features/arm/arm-fpa.c: Likewise.
3418         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3419         * features/arm/arm-m-profile.c: Likewise.
3420         * features/arm/arm-vfpv2.c: Likewise.
3421         * features/arm/arm-vfpv3.c: Likewise.
3422         * features/arm/xscale-iwmmxt.c: Likewise.
3423         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3424
3425 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3426
3427         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3428         ptrace earlier.
3429
3430 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3431
3432         * features/aarch64-pauth.c: Regenerate.
3433
3434 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3435
3436         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3437         bool.
3438         (bpstat_what): Use false instead of 0.
3439
3440 2019-07-09  Pedro Alves  <palves@redhat.com>
3441
3442         * break-catch-throw.c (is_exception_catchpoint): New.
3443         * breakpoint.c (print_one_breakpoint_location): New parameter
3444         'raw_loc'.  Handle it.  Use
3445         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3446         looking at the breakpoint's type.
3447         (print_one_breakpoint): If handling "maint info breakpoints", also
3448         print locations of exception catchpoints.
3449         * breakpoint.h (is_exception_catchpoint): Declare.
3450
3451 2019-07-09  Pedro Alves  <palves@redhat.com>
3452
3453         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3454         "addr" field.
3455         (allocate_location_exception_catchpoint): New.
3456         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3457         (initialize_throw_catchpoint_ops): Install
3458         allocate_location_exception_catchpoint as allocate_location
3459         method.
3460         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3461         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3462         bp_loc_other.
3463         (breakpoint_address_is_meaningful): Delete.
3464         (bl_address_is_meaningful): New.
3465         (breakpoint_locations_match): Adjust comment.
3466         (bp_location_from_bp_type): New, factored out of...
3467         (bp_location::bp_location(breakpoint *)): ... this.
3468         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3469         factored out of...
3470         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3471         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3472         breakpoint_address_is_meaningful.
3473         (bp_locations_compare): Adjust comment.
3474         (update_global_location_list): Use bl_address_is_meaningful
3475         instead of breakpoint_address_is_meaningful.
3476         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3477         explicit.
3478         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3479         * python/py-breakpoint.c (bppy_get_location): No longer check
3480         whether location is null.
3481
3482 2019-07-09  Pedro Alves  <palves@redhat.com>
3483
3484         PR c++/15468
3485         * breakpoint.c (print_one_breakpoint_location): Remove
3486         single-location assert.
3487
3488 2019-07-09  Tom Tromey  <tom@tromey.com>
3489
3490         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3491         * configure: Rebuild.
3492         * configure.ac: Change common to gdbsupport.
3493         * gdbsupport: Rename from common.
3494         * acinclude.m4: Change common to gdbsupport.
3495         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3496         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3497         gdbsupport.
3498         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3499         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3500         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3501         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3502         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3503         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3504         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3505         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3506         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3507         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3508         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3509         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3510         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3511         coff-pe-read.c, command.h, compile/compile-c-support.c,
3512         compile/compile-c.h, compile/compile-cplus-symbols.c,
3513         compile/compile-cplus-types.c, compile/compile-cplus.h,
3514         compile/compile-loc2c.c, compile/compile.c, completer.c,
3515         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3516         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3517         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3518         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3519         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3520         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3521         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3522         features/aarch64-core.c, features/aarch64-fpu.c,
3523         features/aarch64-pauth.c, features/aarch64-sve.c,
3524         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3525         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3526         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3527         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3528         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3529         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3530         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3531         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3532         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3533         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3534         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3535         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3536         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3537         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3538         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3539         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3540         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3541         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3542         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3543         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3544         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3545         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3546         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3547         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3548         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3549         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3550         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3551         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3552         minsyms.c, mips-linux-tdep.c, namespace.h,
3553         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3554         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3555         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3556         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3557         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3558         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3559         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3560         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3561         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3562         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3563         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3564         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3565         procfs.c, producer.c, progspace.h, psymtab.h,
3566         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3567         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3568         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3569         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3570         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3571         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3572         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3573         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3574         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3575         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3576         target-memory.c, target.c, target.h, target/waitstatus.c,
3577         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3578         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3579         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3580         unittests/array-view-selftests.c,
3581         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3582         unittests/common-utils-selftests.c,
3583         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3584         unittests/format_pieces-selftests.c,
3585         unittests/function-view-selftests.c,
3586         unittests/lookup_name_info-selftests.c,
3587         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3588         unittests/mkdir-recursive-selftests.c,
3589         unittests/observable-selftests.c,
3590         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3591         unittests/parse-connection-spec-selftests.c,
3592         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3593         unittests/scoped_fd-selftests.c,
3594         unittests/scoped_mmap-selftests.c,
3595         unittests/scoped_restore-selftests.c,
3596         unittests/string_view-selftests.c, unittests/style-selftests.c,
3597         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3598         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3599         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3600         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3601         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3602         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3603
3604 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3605
3606         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3607         bool value.
3608         (decode_digits_ordinary): Set explicit_line field in sal.
3609         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3610         symtab_and_line that was set on an explicit line number in
3611         assembler code.  Do always update the recorded symtab and line if
3612         we do skip the prologue.
3613
3614 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3615
3616         * breakpoint.c (set_breakpoint_location_function): Remove
3617         explicit_loc parameter.
3618         (momentary_breakpoint_from_master): Update call to
3619         set_breakpoint_location_function.
3620         (add_location_to_breakpoint): Likewise.
3621
3622 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3623
3624         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3625         required features based on default bfd type when no specific bfd
3626         is present.
3627
3628 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3629
3630         * NEWS: Mention that GDB printf and eval commands can now print
3631         C-style and Ada-style convenience var strings without
3632         calling the inferior.
3633         * printcmd.c (printf_c_string): Locally print GDB internal var
3634         instead of transiting via the inferior.
3635         (printf_wide_c_string): Likewise.
3636
3637 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3638
3639         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3640
3641 2019-07-04  Tom Tromey  <tom@tromey.com>
3642
3643         PR tui/24724:
3644         * tui/tui-winsource.c (tui_clear_source_content): Update.
3645         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3646         (tui_update_breakpoint_info): Update.
3647         (tui_set_exec_info_content): Update.
3648         * tui/tui-source.c (tui_set_source_content_nil): Update.
3649         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3650         has_break.
3651         * tui/tui-data.h (enum tui_bp_flag): New.
3652         (tui_bp_flags): New enum flags type.
3653         (struct tui_source_element) <break_mode>: Change type.  Rename
3654         from has_break.
3655         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3656         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3657         constants.
3658         * tui/tui-winsource.h: Fix comment.
3659
3660 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3661
3662         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3663         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3664         (store_fpregs_to_thread)
3665         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3666         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3667         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3668         (IWMMXT_REGS_SIZE): Add define.
3669         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3670         (fetch_vfp_regs, store_vfp_regs)
3671         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3672         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3673
3674 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3675
3676         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3677         defines.
3678         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3679         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3680         (ARM_INT_REGISTER_SIZE): ...to this.
3681         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3682         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3683         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3684         (arm_linux_collect_gregset, supply_nwfpe_register)
3685         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3686         defines.
3687         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3688         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3689         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3690         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3691         (arm_return_in_memory, arm_store_return_value)
3692         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3693         (arm_record_ld_st_multiple): Likewise.
3694         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3695         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3696
3697 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3698
3699         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3700         AARCH64_DISPLACED_MODIFIED_INSNS.
3701         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3702         (aarch64_displaced_step_copy_insn): Likewise.
3703         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3704         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3705         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3706         ARM_DISPLACED_MODIFIED_INSNS.
3707         * arm-tdep.c (arm_gdbarch_init): Likewise.
3708         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3709         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3710         (struct arm_displaced_step_closure): Use
3711         ARM_DISPLACED_MODIFIED_INSNS.
3712
3713 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3714
3715         * features/Makefile: Remove unused xml files.
3716         * features/aarch64.xml: Remove.
3717         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3718         * features/i386/amd64-avx-avx512.xml: Remove.
3719         * features/i386/amd64-avx-linux.xml: Remove.
3720         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3721         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3722         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3723         * features/i386/amd64-avx-mpx.xml: Remove.
3724         * features/i386/amd64-avx.xml: Remove.
3725         * features/i386/amd64-linux.xml: Remove.
3726         * features/i386/amd64-mpx-linux.xml: Remove.
3727         * features/i386/amd64-mpx.xml: Remove.
3728         * features/i386/amd64.xml: Remove.
3729         * features/i386/i386-avx-avx512-linux.xml: Remove.
3730         * features/i386/i386-avx-avx512.xml: Remove.
3731         * features/i386/i386-avx-linux.xml: Remove.
3732         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3733         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3734         * features/i386/i386-avx-mpx-linux.xml: Remove.
3735         * features/i386/i386-avx-mpx.xml: Remove.
3736         * features/i386/i386-avx.xml: Remove.
3737         * features/i386/i386-linux.xml: Remove.
3738         * features/i386/i386-mmx-linux.xml: Remove.
3739         * features/i386/i386-mmx.xml: Remove.
3740         * features/i386/i386-mpx-linux.xml: Remove.
3741         * features/i386/i386-mpx.xml: Remove.
3742         * features/i386/i386.xml: Remove.
3743         * features/i386/x32-avx-avx512-linux.xml: Remove.
3744         * features/i386/x32-avx-linux.xml: Remove.
3745         * features/i386/x32-linux.xml: Remove.
3746
3747 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3748
3749         * regformats/aarch64.dat: Remove.
3750         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3751         * regformats/i386/amd64-avx-linux.dat: Remove.
3752         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3753         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3754         * regformats/i386/amd64-linux.dat: Remove.
3755         * regformats/i386/amd64-mpx-linux.dat: Remove.
3756         * regformats/i386/amd64.dat: Remove.
3757         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3758         * regformats/i386/i386-avx-linux.dat: Remove.
3759         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3760         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3761         * regformats/i386/i386-linux.dat: Remove.
3762         * regformats/i386/i386-mmx-linux.dat: Remove.
3763         * regformats/i386/i386-mpx-linux.dat: Remove.
3764         * regformats/i386/i386.dat: Remove.
3765         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3766         * regformats/i386/x32-avx-linux.dat: Remove.
3767         * regformats/i386/x32-linux.dat: Remove.
3768
3769 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3770
3771         * aarch64-tdep.c: Remove xml self tests.
3772         * amd64-linux-tdep.c: Likewise.
3773         * amd64-tdep.c: Likewise.
3774         * i386-linux-tdep.c: Likewise.
3775         * i386-tdep.c: Likewise.
3776
3777 2019-07-03  Pedro Alves  <palves@redhat.com>
3778
3779         PR cli/24732
3780         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3781         (pipe_cmd_option_defs): New.
3782         (make_pipe_cmd_options_def_group): New.
3783         (pipe_command): Use gdb::option::process_options.
3784         (pipe_command_completer): New function.
3785         (_initialize_cli_cmds): Install completer for "pipe" command.
3786
3787 2019-07-03  Pedro Alves  <palves@redhat.com>
3788
3789         * cli/cli-option.c (union option_value) <string>: New field.
3790         (struct option_def_and_value): Add ctor, move ctor, dtor and
3791         use DISABLE_COPY_AND_ASSIGN.
3792         (option_def_and_value::clear_value): New.
3793         (parse_option, save_option_value_in_ctx, get_val_type_str)
3794         (add_setshow_cmds_for_options): Handle var_string.
3795         * cli-option.h (union option_def::var_address) <string>: New
3796         field.
3797         (struct string_option_def): New.
3798         * maint-test-options.c (struct test_options_opts): Add default
3799         ctor and use DISABLE_COPY_AND_ASSIGN.
3800         <string_opt>: New field.
3801         (test_options_opts::~test_options_opts): New.
3802         (test_options_opts::dump): Also dump "-string".
3803         (test_options_option_defs): Install "string.
3804
3805 2019-07-03  Pedro Alves  <palves@redhat.com>
3806
3807         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3808         option_value with a null enumeration.
3809         (complete_options): Save the option values in the context.
3810         (save_option_value_in_ctx): New, factored out from ...
3811         (process_options): ... here.
3812         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3813         of the function.
3814         * maint-test-options.c (test_options_opts::dump): New, factored
3815         out from ...
3816         (maintenance_test_options_command_mode): ... here.
3817         (maintenance_test_options_command_completion_result): Delete.
3818         (maintenance_test_options_command_completion_text): Update
3819         comment.
3820         (maintenance_show_test_options_completion_result): Change
3821         prototype.  Just print
3822         maintenance_test_options_command_completion_text.
3823         (save_completion_result): New.
3824         (maintenance_test_options_completer_mode): Pass options context to
3825         complete_options, and then save a dump.
3826         (_initialize_maint_test_options): Use add_cmd to install "maint
3827         show test-options-completion-result".
3828
3829 2019-07-03  Pedro Alves  <palves@redhat.com>
3830
3831         * NEWS (New commands): Mention "with" and "maint with".
3832         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3833         (with_command, with_command_completer): New.
3834         (pipe_command): Adjust to new repeat_previous
3835         interface.
3836         (_initialize_cli_cmds): Install the "with" command and its "w"
3837         alias.
3838         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3839         declarations.
3840         * cli/cli-setshow.c (parse_cli_var_uinteger)
3841         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3842         argument strings for all var_types.
3843         (get_setshow_command_value_string): New, factored out from ...
3844         (do_show_command): ... this.
3845         * cli/cli-setshow.h: Include <string>.
3846         (get_setshow_command_value_string): Declare.
3847         * command.h (repeat_previous): Now returns const char *.  Adjust
3848         comment.
3849         * maint.c: Include "cli/cli-cmds.h".
3850         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3851         (_initialize_maint_cmds): Register the "maintenance with" command.
3852         * top.c (repeat_previous): Move bits from pipe_command here:
3853         Return the saved command line, if any; error out if there's no
3854         command to relaunch.
3855
3856 2019-07-03  Pedro Alves  <palves@redhat.com>
3857
3858         * NEWS (New commands): Mention "maint set/show test-settings"
3859         instead of "maint test-settings".
3860         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3861         (maintenance_test_settings_set_list): Rename to ...
3862         (maintenance_set_test_settings_list): ... this.
3863         (maintenance_test_settings_show_list): Rename to  ...
3864         (maintenance_show_test_settings_list): ... this.
3865         (maintenance_test_settings_cmd): Delete.
3866         (maintenance_test_settings_set_cmd): ...
3867         (maintenance_set_test_settings_cmd): ... this.
3868         (maintenance_test_settings_show_cmd): ...
3869         (maintenance_show_test_settings_cmd): ... this.
3870         (maintenance_test_settings_show_value_cmd):
3871         (maintenance_show_test_settings_value_cmd): ... this.
3872         (_initialize_maint_test_settings): No longer install the "maint
3873         test-settings" prefix command.  Rename "maint test-settings set"
3874         to "maint set test-settings", and "maint test-settings show" to
3875         "maint show test-settings".  Adjust all subcommands.
3876
3877 2019-07-03  Pedro Alves  <palves@redhat.com>
3878
3879         * maint-test-settings.c: Fix file's intro comment.  Replace all
3880         references to "test-options" with references to "test-settings",
3881         in comments.
3882
3883 2019-07-03  Pedro Alves  <palves@redhat.com>
3884
3885         * maint-test-settings.c (maintenance_test_settings_xxx)
3886         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3887         New.
3888         (maintenance_test_settings_enums): Use them.
3889         (maintenance_test_settings_enum): Default to
3890         maintenance_test_settings_xxx.
3891         (_initialize_maint_test_settings): Initialize
3892         MAINTENANCE_TEST_SETTINGS_FILENAME.
3893
3894 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3895
3896         * breakpoint.h (remove_breakpoints_inf): Change return type to
3897         void, move function documentation here.
3898         * breakpoint.c (remove_breakpoints_inf): Change return type to
3899         void, move function documentation to header.
3900
3901 2019-07-02  Pedro Alves  <palves@redhat.com>
3902
3903         * NEWS (Completion improvements): Mention "info threads".
3904         * thread.c (struct info_threads_opts, info_threads_option_defs)
3905         (make_info_threads_options_def_group): New.
3906         (info_threads_command): Use gdb::option::process_options.
3907         (info_threads_command_completer): New.
3908         (_initialize_thread): Use gdb::option::build_help to build the
3909         help text for "info threads".
3910
3911 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3912
3913         * defs.h (generic_load): Move from here...
3914         * symfile.h (generic_load): ... to here.  Rename name parameter
3915         to args.
3916         * symfile.c (generic_load): Add comment.
3917
3918 2019-07-01  Tom Tromey  <tromey@adacore.com>
3919
3920         * dwarf2read.c
3921         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3922         declaration of without_params.  Fix formatting.
3923
3924 2019-07-01  Tom Tromey  <tromey@adacore.com>
3925
3926         * ada-exp.y (find_primitive_type): Update.
3927         * ada-lang.h (ada_lookup_symbol): Update.
3928         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3929         parameter.
3930         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3931
3932 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3933
3934         PR breakpoints/24541
3935         * gdbarch.c: Regenerate.
3936         * gdbarch.h: Regenerate.
3937         * gdbarch.sh: Add 'stap_adjust_register'.
3938         * i386-tdep.c: Include '<unordered_set>'.
3939         (i386_stap_adjust_register): New function.
3940         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3941         * stap-probe.c (stap_parse_register_operand): Call
3942         'gdbarch_stap_adjust_register'.
3943
3944 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3945
3946         PR python/24742
3947         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3948         * python/python.c (do_start_initialization): Use 'xmalloc'
3949         instead of 'PyMem_Malloc'.
3950
3951 2019-06-28  Tom Tromey  <tromey@adacore.com>
3952
3953         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3954         for Ada.
3955
3956 2019-06-27  Tom Tromey  <tromey@adacore.com>
3957
3958         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3959         objfile_key.
3960         (arm_find_mapping_symbol, arm_record_special_symbol)
3961         (_initialize_arm_tdep): Update.
3962         (arm_objfile_data_free): Remove.
3963
3964 2019-06-27  Tom Tromey  <tromey@adacore.com>
3965
3966         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3967         to cp_print_static_field.
3968
3969 2019-06-26  Tom Tromey  <tromey@adacore.com>
3970
3971         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3972         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3973         declare.
3974
3975 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3976
3977         * features/aarch64-core.c (create_feature_aarch64_core):
3978         Regenerate.
3979         * features/aarch64-core.xml: Add cpsr flags.
3980
3981 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3982
3983         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3984         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3985
3986 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3987
3988         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3989         field.
3990         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3991         use.
3992         (arm_record_special_symbol): Don't insert new symbol in sorted
3993         position, push it at the end.
3994
3995 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3996
3997         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3998         (arm_mapping_symbol_s): Remove.
3999         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4000         (arm_mapping_symbol_vec): New typedef.
4001         (struct arm_per_objfile): Add constructor.
4002         <section_maps>: Change type to
4003         std::unique_ptr<arm_mapping_symbol_vec[]>.
4004         (arm_compare_mapping_symbols): Remove.
4005         (arm_find_mapping_symbol): Adjust to section_maps type change.
4006         (arm_objfile_data_free): Call delete on arm_per_objfile.
4007         (arm_record_special_symbol): Adjust to section_maps type change.
4008         Allocate arm_per_objfile with new.
4009
4010 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4011
4012         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4013         with the command prefix.
4014
4015 2019-06-25  Tom Tromey  <tom@tromey.com>
4016
4017         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4018         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4019
4020 2019-06-25  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4023         type.
4024         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4025         protected.
4026
4027 2019-06-25  Tom Tromey  <tom@tromey.com>
4028
4029         * tui/tui-winsource.c
4030         (tui_source_window_base::set_is_exec_point_at): Add check against
4031         LOA_ADDRESS.
4032
4033 2019-06-25  Tom Tromey  <tom@tromey.com>
4034
4035         * tui/tui-source.c (tui_set_source_content): Don't check before
4036         xfree.
4037         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4038
4039 2019-06-25  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-winsource.h (tui_update_source_window_as_is)
4042         (tui_alloc_source_buffer, tui_line_is_displayed)
4043         (tui_addr_is_displayed): Change type of win_info.
4044         * tui/tui-winsource.c (tui_update_source_window_as_is)
4045         (tui_clear_source_content, tui_show_source_line)
4046         (tui_show_source_content, tui_source_window_base::refill)
4047         (tui_source_window_base::set_is_exec_point_at)
4048         (tui_source_window_base::set_is_exec_point_at)
4049         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4050         (tui_alloc_source_buffer, tui_line_is_displayed)
4051         (tui_addr_is_displayed): Change type of win_info.  Update.
4052         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4053         (tui_source_window_base::do_make_visible_with_new_height):
4054         Update.
4055         * tui/tui-source.c (tui_set_source_content)
4056         (tui_set_source_content_nil)
4057         (tui_source_window::do_scroll_vertical): Update.
4058         * tui/tui-layout.c (show_layout): Update.
4059         * tui/tui-disasm.c (tui_set_disassem_content)
4060         (tui_disasm_window::do_scroll_vertical): Update.
4061         * tui/tui-data.h (tui_win_content): Remove.
4062         (struct tui_gen_win_info) <content, content_size>: Remove.
4063         (struct tui_source_element): Add initializers and destructor.
4064         (union tui_which_element, struct tui_win_element): Remove.
4065         (struct tui_source_window_base) <content>: New field.
4066         (struct tui_data_window): Remove destructor.
4067         (tui_alloc_content, tui_free_win_content)
4068         (tui_free_all_source_wins_content): Don't declare.
4069         * tui/tui-data.c (tui_initialize_static_data): Update.
4070         (init_content_element, tui_alloc_content): Remove.
4071         (~tui_gen_win_info): Update.
4072         (~tui_data_window, tui_free_all_source_wins_content)
4073         (tui_free_win_content, free_content, free_content_elements):
4074         Remove.
4075
4076 2019-06-25  Tom Tromey  <tom@tromey.com>
4077
4078         * tui/tui-winsource.h (tui_clear_source_content)
4079         (tui_erase_source_content, tui_show_source_content): Change type
4080         of win_info.
4081         * tui/tui-winsource.c (tui_clear_source_content)
4082         (tui_erase_source_content, tui_show_source_content): Change type
4083         of win_info.
4084         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4085         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4086         win_info.
4087         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4088         win_info.
4089         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4090
4091 2019-06-25  Tom Tromey  <tom@tromey.com>
4092
4093         * tui/tui-winsource.c (tui_clear_source_content)
4094         (tui_source_window_base::set_is_exec_point_at): Update.
4095         * tui/tui-source.c (tui_set_source_content_nil): Update.
4096         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4097         a bool.
4098         * tui/tui-data.c (init_content_element): Update.
4099
4100 2019-06-25  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4103         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4104         * tui/tui-layout.c (init_and_make_win): Update.
4105         * tui/tui.h (enum tui_win_type): Update.
4106         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4107         tui_win_is_auxillary.
4108         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4109         tui_win_is_auxillary.
4110
4111 2019-06-25  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4114         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4115         (tui_delete_data_content_windows, tui_display_all_data)
4116         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4117         Update.
4118         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4119         * tui/tui-regs.c (tui_last_regs_line_no)
4120         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4121         (tui_show_registers): Update.
4122         (tui_show_register_group): Return void.  Update.
4123         (tui_display_registers_from, tui_display_reg_element_at_line)
4124         (tui_display_registers_from_line, tui_check_register_values):
4125         Update.
4126         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4127         member.
4128         (struct tui_data_window) <regs_content>: Now a std::vector.
4129         <regs_content_count>: Remove.
4130         (tui_add_content_elements, tui_free_data_content): Don't declare.
4131         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4132         (init_content_element): Remove DATA_WIN case.  Add assert.
4133         (tui_add_content_elements): Remove.
4134         (tui_data_window): Update.
4135         (tui_free_data_content): Remove.
4136         (free_content_elements): Remove DATA_WIN case.
4137
4138 2019-06-25  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui-data.c (tui_data_item_window): Update.
4141         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4142         * tui/tui-windata.c (tui_display_all_data)
4143         (tui_display_data_from_line): Update.
4144         (tui_check_data_values): Remove.
4145         * tui/tui-regs.c (tui_show_register_group)
4146         (tui_display_reg_element_at_line): Update.
4147         * tui/tui-hooks.c (tui_register_changed)
4148         (tui_refresh_frame_and_register_information): Call
4149         tui_check_register_values.
4150         * tui/tui-data.h (struct tui_data_window) <data_content,
4151         data_content_count, data_type>: Remove.
4152         (enum tui_data_type): Remove.
4153
4154         * tui/tui-data.c (tui_data_window::clear_detail)
4155         (~tui_data_window): Update.
4156
4157 2019-06-25  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4160         declare.
4161         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4162         Rename from tui_first_data_item_displayed.  Update.
4163         (tui_data_window::refresh_all)
4164         (tui_data_window::do_scroll_vertical): Update.
4165         * tui/tui-data.h (struct tui_data_window)
4166         <first_data_item_displayed>: Declare new method.
4167
4168 2019-06-25  Tom Tromey  <tom@tromey.com>
4169
4170         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4171         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4172         contents...
4173         (tui_initialize_static_data): ...here.
4174
4175 2019-06-25  Tom Tromey  <tom@tromey.com>
4176
4177         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4178         (tui_display_registers_from, tui_check_register_values): Update.
4179         (tui_display_register): Remove win_info parameter; update.
4180         (tui_get_register): Change type of parameters.
4181         * tui/tui-data.h (struct tui_data_element): Remove.
4182         (union tui_which_element) <data>: Remove.
4183         <data_window>: Change type.
4184         (struct tui_data_item_window): New.
4185         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4186         case.  Add assert.
4187         (~tui_data_item_window): New destructor.
4188         (free_content_elements): Remove DATA_ITEM_WIN case.
4189
4190 2019-06-25  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4193         Remove.
4194
4195 2019-06-25  Tom Tromey  <tom@tromey.com>
4196
4197         * tui/tui-data.h (struct tui_command_element): Remove.
4198         (union tui_which_element) <command>: Remove.
4199         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4200         assert.
4201         (free_content_elements): Remove CMD_WIN case.
4202
4203 2019-06-25  Tom Tromey  <tom@tromey.com>
4204
4205         * tui/tui-layout.c (tui_set_layout): Update.
4206         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4207         * tui/tui-data.c (layout_def): Update.
4208
4209 2019-06-25  Tom Tromey  <tom@tromey.com>
4210
4211         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4212         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4213         (tui_source_window_base::set_new_height): Update.
4214         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4215         Update.
4216         (tui_set_locator_fullname, tui_set_locator_info)
4217         (tui_show_frame_info): Update.
4218         * tui/tui-source.c (tui_set_source_content)
4219         (tui_source_is_displayed): Update.
4220         * tui/tui-layout.c (show_source_disasm_command, show_data)
4221         (show_source_or_disasm_and_command): Update.
4222         * tui/tui-disasm.c (tui_set_disassem_content)
4223         (tui_get_begin_asm_address): Update.
4224         * tui/tui-data.h (struct tui_locator_element): Remove.
4225         (union tui_which_element) <locator>: Remove.
4226         (struct tui_locator_window): New.
4227         (tui_locator_win_info_ptr): Change return type.
4228         * tui/tui-data.c (_locator): Change type.
4229         (tui_locator_win_info_ptr): Change return type.
4230         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4231         (tui_alloc_content): Add assert.
4232
4233 2019-06-25  Tom Tromey  <tom@tromey.com>
4234
4235         * tui/tui-winsource.c
4236         (tui_exec_info_window::maybe_allocate_content): New method.
4237         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4238         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4239         (make_source_or_disasm_window): Add cast.
4240         * tui/tui-data.h (union tui_which_element) <simple_string>:
4241         Remove.
4242         (struct tui_source_info): New.
4243         (struct tui_source_window_base) <execution_info>: Change type.
4244         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4245         case, and add assert.
4246         (tui_alloc_content): Add assert.
4247
4248 2019-06-25  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4251         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4252         * tui/tui-data.c (tui_alloc_win_info): Remove.
4253
4254 2019-06-25  Tom Tromey  <tom@tromey.com>
4255
4256         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4257         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4258         can_highlight.
4259
4260 2019-06-25  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4263         make_visible_with_new_height method.
4264         (tui_win_info::make_visible_with_new_height): New method.
4265         (tui_source_window_base::do_make_visible_with_new_height)
4266         (tui_data_window::do_make_visible_with_new_height)
4267         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4268         (make_visible_with_new_height): Remove.
4269         (tui_resize_all, tui_adjust_win_heights): Use
4270         make_visible_with_new_height method.
4271         * tui/tui-data.h (struct tui_win_info)
4272         <do_make_visible_with_new_height, make_visible_with_new_height>:
4273         New methods.
4274         (struct tui_source_window_base, struct tui_data_window)
4275         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4276         methods.
4277
4278 2019-06-25  Tom Tromey  <tom@tromey.com>
4279
4280         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4281         method.
4282         (update_tab_width): Call update_tab_width method.
4283         * tui/tui-data.h (struct tui_win_info)
4284         (struct tui_source_window_base) <update_tab_width>: New methods.
4285
4286 2019-06-25  Tom Tromey  <tom@tromey.com>
4287
4288         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4289         parameter.
4290         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4291         parameter.
4292         (tui_gen_win_info::make_visible): Update.
4293         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4294         parameter.
4295         * tui/tui-data.h (enum tui_box): New enum.
4296         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4297
4298 2019-06-25  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4301         init_and_make_win for EXEC_INFO_WIN.
4302         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4303         longer inline.
4304         (struct tui_win_info) <~tui_win_info>: Inline.
4305         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4306         Don't declare.
4307         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4308         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4309         Remove.
4310         (tui_initialize_static_data): Update.
4311         (~tui_gen_win_info): Handle more cleanup here.
4312         (~tui_source_window_base): Delete "execution_info".
4313         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4314
4315 2019-06-25  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-layout.c (make_command_window): Don't set
4318         can_highlight.
4319         (show_source_disasm_command): Call the reset method.
4320         (show_data): Don't set can_highlight.  Call the reset method.
4321         (tui_gen_win_info::reset): Rename from init_gen_win_info
4322         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4323         (show_source_or_disasm_and_command): Call the reset method.
4324         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4325         (struct tui_cmd_window): Set can_highlight.
4326
4327 2019-06-25  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4330         from make_visible.
4331         (tui_make_visible, tui_make_invisible): Rewrite.
4332         (tui_win_info::make_visible): Remove.
4333         (tui_source_window_base::make_visible): Update.
4334         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4335         method.  Moved from...
4336         (struct tui_win_info) <make_visible>: ...here.
4337
4338 2019-06-25  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-winsource.c
4341         (tui_source_window_base::do_scroll_horizontal): Remove direction
4342         parameter.
4343         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4344         direction parameter.
4345         * tui/tui-win.c (tui_win_info::forward_scroll)
4346         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4347         (tui_win_info::right_scroll): Update.
4348         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4349         direction parameter.
4350         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4351         direction parameter.
4352         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4353         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4354         Remove direction parameter.
4355         (struct tui_source_window_base, struct tui_source_window)
4356         (struct tui_disasm_window, struct tui_data_window)
4357         (struct tui_cmd_window): Update.
4358
4359 2019-06-25  Tom Tromey  <tom@tromey.com>
4360
4361         * tui/tui-winsource.h (tui_set_exec_info_content)
4362         (tui_show_exec_info_content, tui_erase_exec_info_content)
4363         (tui_clear_exec_info_content, tui_update_exec_info): Change
4364         argument to tui_source_window_base.
4365         * tui/tui-winsource.c (tui_set_exec_info_content)
4366         (tui_show_exec_info_content, tui_erase_exec_info_content)
4367         (tui_clear_exec_info_content, tui_update_exec_info): Change
4368         argument to tui_source_window_base.
4369
4370 2019-06-25  Tom Tromey  <tom@tromey.com>
4371
4372         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4373         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4374
4375 2019-06-25  Tom Tromey  <tom@tromey.com>
4376
4377         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4378         check.
4379
4380 2019-06-25  Tom Tromey  <tom@tromey.com>
4381
4382         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4383         type to void.
4384         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4385         type to void.
4386         * tui/tui-source.c (tui_set_source_content): Update.
4387         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4388
4389 2019-06-25  Tom Tromey  <tom@tromey.com>
4390
4391         * tui/tui-win.c (window_name_completer, tui_set_focus)
4392         (tui_all_windows_info): Use name method.
4393         * tui/tui-data.h (struct tui_gen_win_info)
4394         (struct tui_source_window, struct tui_disasm_window)
4395         (struct tui_data_window, struct tui_cmd_window) <name>: New
4396         method.
4397         (tui_win_name): Don't declare.
4398         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4399         (tui_win_name): Remove.
4400
4401 2019-06-25  Tom Tromey  <tom@tromey.com>
4402
4403         * tui/tui-winsource.h (tui_update_source_window)
4404         (tui_update_source_window_as_is): Change parameter type.
4405         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4406         to be a tui_source_window_base.
4407         (tui_update_source_window_as_is): Likewise.
4408         * tui/tui-win.c (make_visible_with_new_height): Update.
4409
4410 2019-06-25  Tom Tromey  <tom@tromey.com>
4411
4412         * tui/tui-winsource.c (tui_erase_source_content)
4413         (tui_show_source_content, tui_show_exec_info_content)
4414         (tui_erase_exec_info_content): Use refresh_window method.
4415         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4416         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4417         from tui_refresh_win.
4418         (tui_data_window::refresh_window): New method.
4419         (tui_win_info::refresh, tui_source_window_base::refresh)
4420         (tui_refresh_all): Use refresh_window method.
4421         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4422         method.
4423         * tui/tui-regs.c (tui_display_register): Call refresh_window
4424         method.
4425         * tui/tui-layout.c (show_source_disasm_command)
4426         (show_source_or_disasm_and_command): Call refresh_window method.
4427         * tui/tui-data.h (struct tui_gen_win_info)
4428         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4429         New method.
4430
4431 2019-06-25  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui.c (tui_rl_other_window, tui_enable)
4434         (tui_is_window_visible, tui_get_command_dimension): Update.
4435         * tui/tui-winsource.c (tui_update_source_window_as_is)
4436         (tui_clear_source_content, tui_erase_source_content)
4437         (tui_show_source_line, tui_source_window_base::refill)
4438         (tui_source_window_base::do_scroll_horizontal)
4439         (tui_source_window_base::set_is_exec_point_at)
4440         (tui_update_breakpoint_info, tui_set_exec_info_content)
4441         (tui_alloc_source_buffer, tui_line_is_displayed)
4442         (tui_addr_is_displayed): Update.
4443         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4444         (tui_check_and_display_highlight_if_needed)
4445         (tui_win_info::make_visible, tui_win_info::refresh)
4446         (tui_refresh_all): Update.
4447         * tui/tui-windata.c (tui_first_data_item_displayed)
4448         (tui_delete_data_content_windows, tui_erase_data_content)
4449         (tui_display_all_data, tui_data_window::refresh_all)
4450         (tui_check_data_values): Update.
4451         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4452         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4453         (tui_win_info::backward_scroll, tui_refresh_all_win)
4454         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4455         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4456         (tui_source_window_base::set_new_height)
4457         (tui_data_window::set_new_height)
4458         (make_invisible_and_set_new_height)
4459         (make_visible_with_new_height, new_height_ok)
4460         (parse_scrolling_args): Update.
4461         * tui/tui-stack.c (tui_show_frame_info): Update.
4462         * tui/tui-source.c (tui_set_source_content)
4463         (tui_set_source_content_nil, tui_source_is_displayed)
4464         (tui_source_window::do_scroll_vertical): Update.
4465         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4466         (tui_display_registers_from, tui_display_reg_element_at_line)
4467         (tui_check_register_values, tui_reg_command): Update.
4468         * tui/tui-layout.c (tui_default_win_height)
4469         (show_source_disasm_command, show_data, init_and_make_win)
4470         (show_source_or_disasm_and_command): Update.
4471         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4472         (tui_redisplay_readline, tui_mld_flush)
4473         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4474         (tui_getc): Update.
4475         * tui/tui-disasm.c (tui_set_disassem_content)
4476         (tui_disasm_window::do_scroll_vertical): Update.
4477         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4478         Now virtual.
4479         (struct tui_win_info): Derive from tui_gen_win_info.
4480         <~tui_win_info>: Mark as override.
4481         <generic>: Remove member.
4482         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4483         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4484         (~tui_data_window, ~tui_win_info)
4485         (tui_free_all_source_wins_content): Update.
4486         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4487
4488 2019-06-25  Tom Tromey  <tom@tromey.com>
4489
4490         * tui/tui-layout.c (init_and_make_win): Use new.
4491         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4492         destructor, initializers.
4493         (tui_alloc_generic_win_info): Don't declare.
4494         * tui/tui-data.c (_locator): Add argument to constructor.
4495         (source_win, disasm_win): New globals.
4496         (exec_info): Remove.
4497         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4498         Update.
4499         (tui_alloc_generic_win_info): Remove.
4500         (init_content_element): Use new.
4501         (tui_win_info::tui_win_info): Update.
4502         (free_content_elements) <case DATA_WIN>: Use delete.
4503
4504 2019-06-25  Tom Tromey  <tom@tromey.com>
4505
4506         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4507         * tui/tui-windata.c (tui_first_data_item_displayed)
4508         (tui_delete_data_content_windows): Update.
4509         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4510         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4511         (tui_display_registers_from, tui_check_register_values): Update.
4512         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4513         pointer.
4514         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4515         window.
4516         (tui_free_data_content): Update.
4517         (free_content_elements) <case DATA_WIN>: Free the window.
4518
4519 2019-06-25  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4522         Update.
4523         * tui/tui-layout.c (make_command_window)
4524         (show_source_disasm_command, show_data, init_and_make_win)
4525         (show_source_or_disasm_and_command): Update.
4526         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4527         method.
4528         <can_highight, is_highlighted>: Now bool.
4529         (tui_set_win_highlight): Don't declare.
4530         * tui/tui-data.c (tui_set_win_highlight): Remove.
4531
4532 2019-06-25  Tom Tromey  <tom@tromey.com>
4533
4534         * tui/tui-wingeneral.c (make_visible): Remove check of window
4535         type.
4536
4537 2019-06-25  Tom Tromey  <tom@tromey.com>
4538
4539         * tui/tui-win.c (tui_win_info::max_height)
4540         (tui_cmd_window::max_height): New methods.
4541         (new_height_ok): Call max_height.
4542         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4543         <max_height>: New method.
4544
4545 2019-06-25  Tom Tromey  <tom@tromey.com>
4546
4547         * tui/tui-win.c (tui_source_window_base::set_new_height)
4548         (tui_data_window::set_new_height): New methods.
4549         (make_invisible_and_set_new_height): Call set_new_height method.
4550         * tui/tui-data.h (struct tui_win_info)
4551         (struct tui_source_window_base, struct tui_data_window)
4552         <set_new_height>: New method.
4553
4554 2019-06-25  Tom Tromey  <tom@tromey.com>
4555
4556         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4557         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4558         tui_refresh_data_win.
4559         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4560         method.
4561         (tui_refresh_all_win): Call the refresh_all method.
4562         (tui_set_focus): Likewise.
4563         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4564         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4565         Likewise.
4566
4567 2019-06-25  Tom Tromey  <tom@tromey.com>
4568
4569         * tui/tui-winsource.h (tui_refill_source_window)
4570         (tui_set_is_exec_point_at): Don't declare.
4571         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4572         (tui_source_window_base::refill): Rename from
4573         tui_refill_source_window.
4574         (tui_source_window_base::do_scroll_horizontal): Update.
4575         (tui_source_window_base::set_is_exec_point_at): Rename from
4576         tui_set_is_exec_point_at.
4577         (tui_update_all_breakpoint_info): Update.
4578         * tui/tui-stack.c (tui_show_frame_info): Update.
4579         * tui/tui-layout.c (show_data): Add cast.
4580         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4581         * tui/tui-data.h (struct tui_source_window_base) <refill,
4582         set_is_exec_point_at>: New methods.
4583         (tui_source_windows, tui_add_to_source_windows): Update types.
4584         (tui_add_to_source_windows): Remove redundant declaration.
4585         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4586         (tui_source_windows): Change return type.
4587         (tui_clear_source_windows_detail): Update.
4588         (tui_add_to_source_windows): Change type of parameter.
4589         (tui_free_all_source_wins_content): Update.
4590
4591 2019-06-25  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui-wingeneral.c (tui_win_info::refresh)
4594         (tui_source_window_base::refresh): New methods.
4595         (tui_refresh_all): Call the refresh method.
4596         * tui/tui-data.h (struct tui_win_info)
4597         (struct tui_source_window_base) <refresh>: New method.
4598
4599 2019-06-25  Tom Tromey  <tom@tromey.com>
4600
4601         * tui/tui.h (tui_is_window_visible): Return bool.
4602         * tui/tui.c (tui_is_window_visible): Return bool.
4603         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4604         (tui_make_visible, tui_make_invisible)
4605         (tui_win_info::make_visible)
4606         (tui_source_window_base::make_visible, make_all_visible)
4607         (tui_make_all_visible, tui_make_all_invisible): Update.
4608         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4609         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4610         bool.
4611         (struct tui_win_info, struct tui_source_window_base)
4612         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4613         * tui/tui-data.c (tui_init_generic_part): Update.
4614
4615 2019-06-25  Tom Tromey  <tom@tromey.com>
4616
4617         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4618         (tui_source_window_base::make_visible): New methods.
4619         (make_all_visible): Make method call.
4620         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4621         (struct tui_source_window_base, struct tui_cmd_window): Override
4622         make_visible.
4623         (tui_win_is_source_type): Don't declare.
4624         * tui/tui-data.c (tui_win_is_source_type): Remove.
4625
4626 2019-06-25  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4629         NULL check.
4630
4631 2019-06-25  Tom Tromey  <tom@tromey.com>
4632
4633         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4634         Inline constructor.  Add initializers for members.
4635         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4636         constructors; now inline in class.
4637
4638 2019-06-25  Tom Tromey  <tom@tromey.com>
4639
4640         * tui/tui-regs.c (tui_show_registers): Update.
4641         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4642         bool.
4643         * tui/tui-data.c (tui_data_window::clear_detail)
4644         (tui_data_window): Update.
4645
4646 2019-06-25  Tom Tromey  <tom@tromey.com>
4647
4648         * tui/tui-windata.c (tui_display_all_data)
4649         (tui_display_data_from_line, tui_display_data_from)
4650         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4651         Update.
4652         * tui/tui-regs.c (tui_last_regs_line_no)
4653         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4654         (tui_show_registers, tui_show_register_group)
4655         (tui_display_registers_from, tui_display_reg_element_at_line)
4656         (tui_display_registers_from_line, tui_check_register_values)
4657         (tui_reg_next, tui_reg_prev): Update.
4658         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4659         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4660         tui_data_window.
4661         (struct tui_win_info) <detail>: Remove.  Add new fields from
4662         tui_data_info.
4663         (TUI_DATA_WIN): Add cast.
4664         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4665         (~tui_data_window): Simplify.
4666
4667 2019-06-25  Tom Tromey  <tom@tromey.com>
4668
4669         * tui/tui-layout.c (show_source_disasm_command)
4670         (show_source_or_disasm_and_command): Update.
4671         * tui/tui-io.c (update_cmdwin_start_line)
4672         (tui_redisplay_readline): Update.
4673         * tui/tui-data.h (struct tui_command_info): Remove.
4674         (struct tui_win_info) <detail>: Remove command_info member.
4675         (struct tui_data_window) <start_line>: New member, from
4676         tui_command_info.
4677         (TUI_CMD_WIN): Add casts.
4678
4679 2019-06-25  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-winsource.c (tui_update_source_window)
4682         (tui_refill_source_window)
4683         (tui_source_window_base::do_scroll_horizontal)
4684         (tui_update_breakpoint_info, tui_set_exec_info_content)
4685         (tui_show_exec_info_content, tui_erase_exec_info_content)
4686         (tui_clear_exec_info_content): Update.
4687         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4688         Update.
4689         * tui/tui-win.c (make_invisible_and_set_new_height)
4690         (make_visible_with_new_height): Update.
4691         * tui/tui-source.c (tui_set_source_content)
4692         (tui_show_symtab_source): Update.
4693         * tui/tui-layout.c (extract_display_start_addr)
4694         (show_source_disasm_command, show_data)
4695         (make_source_or_disasm_window)
4696         (show_source_or_disasm_and_command): Update.
4697         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4698         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4699         "gdbarch".
4700         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4701         to tui_source_window_base.
4702         (struct tui_win_info) <detail>: Remove source_info member.
4703         (struct tui_source_window_base) <has_locator>: Inline.
4704         Move contents from tui_source_info; rename has_locator member to
4705         m_has_locator.
4706         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4707         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4708         header file.
4709         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4710         Simplify.
4711         (tui_free_all_source_wins_content): Cast to
4712         tui_source_window_base.
4713
4714 2019-06-25  Tom Tromey  <tom@tromey.com>
4715
4716         * tui/tui-win.c (make_invisible_and_set_new_height)
4717         (make_visible_with_new_height): Call has_locator method.
4718         * tui/tui-layout.c (show_source_disasm_command, show_data)
4719         (show_source_or_disasm_and_command): Update for bool change.
4720         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4721         (tui_win_info) <has_locator>: New method.
4722         (struct tui_source_window_base) <has_locator>: New method.
4723         (tui_win_has_locator): Don't declare.
4724         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4725         from tui_win_has_locator.
4726         (tui_source_window_base): Use false, not FALSE.
4727
4728 2019-06-25  Tom Tromey  <tom@tromey.com>
4729
4730         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4731         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4732         clear_detail method directly.
4733         (tui_clear_win_detail): Remove.
4734
4735 2019-06-25  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4738         "this", not TUI_DISASM_WIN.
4739
4740 2019-06-25  Tom Tromey  <tom@tromey.com>
4741
4742         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4743         declare.
4744         * tui/tui-winsource.c
4745         (tui_source_window_base::do_scroll_horizontal): Rename from
4746         tui_horizontal_source_scroll.
4747         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4748         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4749         from tui_vertical_data_scroll.
4750         * tui/tui-win.h (tui_scroll): Don't declare.
4751         * tui/tui-win.c (tui_win_info::forward_scroll)
4752         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4753         (tui_win_info::right_scroll): Rename and update.
4754         (tui_scroll_forward_command, tui_scroll_backward_command)
4755         (tui_scroll_left_command, tui_scroll_right_command): Update.
4756         (tui_scroll): Remove.
4757         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4758         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4759         from tui_vertical_source_scroll.
4760         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4761         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4762         from tui_vertical_disassem_scroll.
4763         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4764         do_scroll_horizontal>: New methods.
4765         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4766         Likewise.
4767         (struct tui_source_window_base): Add do_scroll_horizontal.
4768         (struct tui_source_window, struct tui_disasm_window): Add
4769         do_scroll_vertical.
4770         (struct tui_data_window, struct tui_cmd_window): Add
4771         do_scroll_horizontal and do_scroll_vertical.
4772         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4773
4774 2019-06-25  Tom Tromey  <tom@tromey.com>
4775
4776         * tui/tui-data.h (struct tui_source_window_base): New struct.
4777         (struct tui_source_window): Derive from tui_source_window_base.
4778         (struct tui_disasm_window): New struct.
4779         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4780         from tui_source_window::clear_detail.
4781         (tui_source_window_base): Rename from tui_source_window.
4782         (~tui_source_window_base): Rename from ~tui_source_window.
4783         (tui_alloc_win_info): Create a tui_disasm_window.
4784
4785 2019-06-25  Tom Tromey  <tom@tromey.com>
4786
4787         * tui/tui-data.h (struct tui_source_window)
4788         (struct tui_data_window): Declare destructors.
4789         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4790         destructors.
4791         (tui_win_info): Simplify.
4792
4793 2019-06-25  Tom Tromey  <tom@tromey.com>
4794
4795         * tui/tui-winsource.c (tui_display_main)
4796         (tui_update_source_windows_with_addr)
4797         (tui_update_all_breakpoint_info): Update.
4798         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4799         (new_height_ok, parse_scrolling_args): Update.
4800         * tui/tui-stack.c (tui_show_frame_info): Update.
4801         * tui/tui-data.h (struct tui_list): Remove.
4802         (tui_source_windows): Return a reference to a std::vector.
4803         * tui/tui-data.c (source_windows): Now a std::vector.
4804         (tui_source_windows): Change return type.
4805         (tui_clear_source_windows): Rewrite.
4806         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4807         (tui_free_all_source_wins_content): Rewrite.
4808
4809 2019-06-25  Tom Tromey  <tom@tromey.com>
4810
4811         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4812         (struct tui_data_window, struct tui_cmd_window): Declare
4813         clear_detail method.
4814         * tui/tui-data.c (tui_source_window::clear_detail)
4815         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4816         methods.
4817         (tui_clear_win_detail): Simplify.
4818
4819 2019-06-25  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-layout.c (make_source_window, make_disasm_window)
4822         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4823         Return the new window.
4824         (show_source_disasm_command, show_data)
4825         (show_source_or_disasm_and_command): Update.
4826
4827 2019-06-25  Tom Tromey  <tom@tromey.com>
4828
4829         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4830         parameter.  Return the new window.
4831         (show_source_disasm_command): Update and remove NULL check.
4832         (show_source_or_disasm_and_command): Update.
4833
4834 2019-06-25  Tom Tromey  <tom@tromey.com>
4835
4836         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4837
4838 2019-06-25  Tom Tromey  <tom@tromey.com>
4839
4840         * tui/tui-data.h (struct tui_win_info): Make constructor
4841         protected.  Make destructor virtual.  Add initializers.
4842         (tui_source_window, tui_data_window, tui_cmd_window): New
4843         classes.
4844         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4845         constructor.  Add "type" parameter.
4846         (tui_source_window, tui_data_window, tui_cmd_window): New
4847         constructors.
4848         (tui_alloc_win_info): Instantiate the appropriate subclass.
4849
4850 2019-06-25  Tom Tromey  <tom@tromey.com>
4851
4852         * tui/tui-win.c (tui_resize_all): Use delete.
4853         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4854         destructor.
4855         (tui_free_window): Don't declare.
4856         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4857         Update.
4858
4859 2019-06-25  Tom Tromey  <tom@tromey.com>
4860
4861         * tui/tui-data.h (struct tui_win_info): Add constructor.
4862         * tui/tui-data.c (tui_alloc_win_info): Use new.
4863         (tui_free_window): Use delete.
4864
4865 2019-06-22  Tom Tromey  <tom@tromey.com>
4866
4867         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4868         declare.
4869         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4870
4871 2019-06-22  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4874         declare.
4875         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4876
4877 2019-06-22  Tom de Vries  <tdevries@suse.de>
4878
4879         * dwarf2read.c (create_addrmap_from_aranges)
4880         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4881         instead of '%zu'.
4882
4883 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4884
4885         * dwarf2read.h (dwarf2_section_info_def): Remove.
4886         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4887         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4888         std::vector<dwarf2_section_info>.
4889         (struct dwo_file) <~dwo_file>: Remove.
4890         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4891         types field.
4892         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4893         (dwarf2_read_debug_names): Likewise.
4894         (create_debug_types_hash_table): Change parameter type to
4895         array_view, adjust code accordingly.
4896         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4897         (partial_die_info::fixup): Likewise.
4898         (determine_prefix): Likewise.
4899         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4900
4901 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4902
4903         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4904         gdb_bfd_ref_ptr.
4905         <~dwo_file>: Remove call to gdb_bfd_unref.
4906         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4907         gdb_bfd_ref_ptr::get.
4908
4909 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4910
4911         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4912         type to htab_up.
4913         * dwarf2read.c (struct dwo_file): Initialize fields.
4914         <~dwo_file>: New.
4915         (free_dwo_file): Remove, move content to ~dwo_file.
4916         (struct dwo_file_deleter): Remove.
4917         (dwo_file_up>: Remove custom deleter.
4918         (free_dwo_files): Remove.
4919         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4920         dwo_files.
4921         (process_skeletonless_type_units): Call unique_ptr::get.
4922         (allocate_dwo_file_hash_table): Add deleter to created hash
4923         table.  Change return type to htab_up.
4924         (lookup_dwo_file_slot): Don't memset dwo_file, call
4925         unique_ptr::get.
4926         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4927         (create_dwo_unit_in_dwp_v2): Likewise.
4928         (open_and_init_dwo_file): Likewise.
4929         (free_dwo_file_from_slot): Remove.
4930
4931 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4932
4933         * dwarf2read.h (struct dwarf2_section_info) <readin,
4934         is_virtual>: Change type to bool.
4935         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4936         true instead of 1.
4937
4938 2019-06-19  Tom Tromey  <tom@tromey.com>
4939
4940         * tui/tui-data.h (tui_init_content_element): Don't declare.
4941
4942 2019-06-19  Tom Tromey  <tom@tromey.com>
4943
4944         * tui/tui-data.h (tui_init_win_info): Don't declare.
4945
4946 2019-06-19  Tom de Vries  <tdevries@suse.de>
4947
4948         * dwarf2read.h (abstract_to_concrete): Change type to
4949         std::unordered_map<sect_offset, std::vector<sect_offset>,
4950         gdb::hash_enum<sect_offset>>.
4951
4952 2019-06-19  Tom Tromey  <tromey@adacore.com>
4953
4954         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4955         EVAL_AVOID_SIDE_EFFECTS specially.
4956
4957 2019-06-19  Tom Tromey  <tromey@adacore.com>
4958
4959         * source-cache.c (highlighter): New global.
4960         (source_cache::get_source_lines): Create a highlighter on demand.
4961
4962 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4963
4964         * defs.h (deprecated_interactive_hook): Delete declaration.
4965         * interps.c (clear_interpreter_hooks): Remove use of
4966         deprecated_interactive_hook.
4967         * top.c (deprecated_interactive_hook): Delete definition.
4968         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4969
4970 2019-06-18  Tom de Vries  <tdevries@suse.de>
4971
4972         PR gdb/24515
4973         * dwarf2read.h (abstract_to_concrete): Change type from
4974         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4975         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4976         * dwarf2read.c (read_variable): Update.
4977         (dwarf2_fetch_die_loc_sect_off): Update.
4978
4979 2019-06-17  Tom de Vries  <tdevries@suse.de>
4980
4981         PR gdb/24617
4982         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4983         accessing parent[parent_len - 1].
4984
4985 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4986
4987         PR gdb/24364
4988         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4989         call dtrace_process_dof with NULL dof.
4990
4991 2019-06-16  Tom de Vries  <tdevries@suse.de>
4992
4993         PR gdb/24445
4994         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4995
4996 2019-06-16  Tom Tromey  <tom@tromey.com>
4997
4998         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4999         (make_all_visible): Use address of member.
5000
5001 2019-06-16  Tom Tromey  <tom@tromey.com>
5002
5003         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5004         (tui_free_window, free_content, free_content_elements): Remove
5005         unnecessary cast.
5006         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5007         cast.
5008         * tui/tui-regs.c (tui_show_register_group)
5009         (tui_display_registers_from, tui_display_reg_element_at_line):
5010         Remove unnecessary cast.
5011
5012 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5013
5014         * linux-nat.c (normal_mask): Delete.
5015         (_initialize_linux_nat): Don't initialise normal_mask.
5016
5017 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5018
5019         PR gdb/24445
5020         * dwarf-index-write.h (write_psymtabs_to_index): Add
5021         dwz_basename parameter.
5022         * dwarf-index-write.c (write_gdbindex): Move file writing to
5023         write_gdbindex_1.  Change return type void.
5024         (assert_file_size): Move up, remove filename parameter.
5025         (write_gdbindex_1): New function.
5026         (write_debug_names): Change return type to void, call
5027         assert_file_size.
5028         (struct index_wip_file): New struct.
5029         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5030         file logic to index_wip_file.  Write index for dwz file if
5031         needed.
5032         (save_gdb_index_command): Pass basename of dwz file, if present.
5033         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5034         build-id of dwz file, if present.
5035         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5036         (dwarf2_get_dwz_file): Likewise.
5037         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5038         (dwarf2_get_dwz_file): Likewise.
5039
5040 2019-06-16  Tom Tromey  <tom@tromey.com>
5041
5042         * coffread.c (process_coff_symbol): Use xstrdup.
5043         * value.c (create_internalvar): Use xstrdup.
5044
5045 2019-06-16  Tom Tromey  <tom@tromey.com>
5046
5047         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5048         * breakpoint.c (stopin_command, stopat_command)
5049         (until_break_command, decode_location_default): Remove unnecessary
5050         cast.
5051         * utils.c (subset_compare): Remove unnecessary cast.
5052         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5053         cast.
5054         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5055         cast.
5056         * infcmd.c (path_command): Remove unnecessary cast.
5057         * coffread.c (decode_type): Remove unnecessary cast.
5058         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5059         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5060         * tui/tui-stack.c (tui_show_locator_content)
5061         (tui_show_frame_info): Remove unnecessary cast.
5062         * tui/tui-win.c (tui_scroll_forward_command)
5063         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5064         (parse_scrolling_args): Remove unnecessary cast.
5065         * tui/tui-data.c (init_win_info, tui_del_window)
5066         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5067         (free_content_elements): Remove unnecessary cast.
5068         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5069         unnecessary cast.
5070         * tui/tui-source.c (tui_set_source_content)
5071         (tui_vertical_source_scroll): Remove unnecessary cast.
5072         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5073         cast.
5074         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5075         * tui/tui-regs.c (tui_display_registers_from)
5076         (tui_display_register): Remove unnecessary cast.
5077         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5078         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5079         (make_visible): Remove unnecessary cast.
5080         * tui/tui-winsource.c (tui_erase_source_content)
5081         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5082         unnecessary cast.
5083         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5084         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5085         * stabsread.c (read_type, read_array_type, read_range_type):
5086         Remove unnecessary cast.
5087         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5088         (parse_symbol, parse_type, upgrade_type, parse_external)
5089         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5090         unnecessary cast.
5091         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5092
5093 2019-06-16  Tom Tromey  <tom@tromey.com>
5094
5095         * tui/tui-data.c (tui_alloc_generic_win_info)
5096         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5097         checks.
5098
5099 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5100             Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * f-typeprint.c (f_print_type): Don't return early for not
5103         associated or not allocated types.
5104         (f_type_print_varspec_suffix): Add print_rank parameter and print
5105         ranks of array types in case they dangling.
5106         (f_type_print_base): Add print_rank parameter.
5107
5108 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * NEWS: Mention new MI commands.
5111         * break-catch-throw.c (enum exception_event_kind): Move to
5112         breakpoint.h.
5113         (print_mention_exception_catchpoint): Output text as a single
5114         message.
5115         (catch_exception_command_1): Rename to...
5116         (catch_exception_event): ...this, make non-static, update header
5117         command, and change some parameter types.
5118         (catch_catch_command): Update for changes to
5119         catch_exception_command_1.
5120         (catch_throw_command): Likewise.
5121         (catch_rethrow_command): Likewise.
5122         * breakpoint.c (enum exception_event_kind): Delete.
5123         * breakpoint.h (enum exception_event_kind): Moved here from
5124         break-catch-throw.c.
5125         (catch_exception_event): Declare.
5126         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5127         (mi_cmd_catch_throw): New function.
5128         (mi_cmd_catch_rethrow): New function.
5129         (mi_cmd_catch_catch): New function.
5130         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5131         'catch-catch' entries.
5132         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5133         (mi_cmd_catch_rethrow): Declare.
5134         (mi_cmd_catch_catch): Declare.
5135
5136 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5137
5138         * annotate.c (annotate_source_line): Change return type to void,
5139         update implementation to match.
5140         * annotate.h (annotate_source_line): Change return type to void,
5141         update header comment.
5142         * stack.c (print_frame_info): Don't change what frame information
5143         is printed based on whether annotations are on or not.
5144
5145 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5146
5147         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5148         (annotate_source): Make static.
5149         (annotate_source_line): Moved from source.c and renamed from
5150         identify_source_line.  Update the return type.
5151         * annotate.h (annotate_source): Delete declaration.
5152         (annotate_source_line): Declaration moved from source.h, and
5153         renamed from identify_source_line.  Return type updated.
5154         * source.c (identify_source_line): Moved to annotate.c and renamed
5155         to annotate_source_line.
5156         (info_line_command): Remove check of annotation_level.
5157         * source.h (identify_source_line): Move declaration to annotate.h
5158         and rename to annotate_source_line.
5159         * stack.c: Add 'annotate.h' include.
5160         (print_frame_info): Remove check of annotation_level before
5161         calling annotate_source_line.
5162
5163 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * source-cache.c (source_cache::get_plain_source_lines): Use
5166         open_source_file_with_line_charpos instead of just
5167         open_source_file, remove call to find_source_lines.
5168         (source_cache::get_source_lines): Likewise.
5169         * source.c (find_source_lines): Make static.
5170         (get_filename_and_charpos): Renamed into...
5171         (open_source_file_with_line_charpos): ..this along with changes to
5172         return a scoped_fd, and some other minor clean ups.
5173         (identify_source_line): Use open_source_file_with_line_charpos.
5174         (search_command_helper): Use open_source_file_with_line_charpos
5175         instead of just open_source_file, remove call to
5176         find_source_lines.
5177         * source.h (open_source_file_with_line_charpos): Declare new
5178         function.
5179         (find_source_lines): Delete declaration.
5180
5181 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5182
5183         * source.c (get_filename_and_charpos): Remove fullname
5184         parameter.
5185         (identify_source_line): Update call to get_filename_and_charpos.
5186
5187 2019-06-14  Tom Tromey  <tromey@adacore.com>
5188
5189         PR gdb/24502:
5190         * ui-style.h (skip_ansi_escape): Update comment.
5191         * ui-file.h (class no_terminal_escape_file): New class.
5192         * ui-file.c (no_terminal_escape_file::write)
5193         (no_terminal_escape_file::puts): New methods.
5194         * cli/cli-logging.c (handle_redirections): Use
5195         no_terminal_escape_file.
5196
5197 2019-06-14  Tom Tromey  <tromey@adacore.com>
5198
5199         * NEWS: Move convenience variable news above Python news.
5200
5201 2019-06-14  Tom Tromey  <tom@tromey.com>
5202
5203         * gnulib: Move directory to top-level.
5204         * configure.ac: Don't configure gnulib.
5205         * configure: Rebuild.
5206         * common/common-defs.h: Use new path to gnulib.
5207         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5208         (GNULIB_H): Remove.
5209         (INCGNU): Look in new gnulib location.
5210         (HFILES_NO_SRCDIR): Remove gnulib files.
5211         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5212         (generated_files): Remove GNULIB_H.
5213         ($(LIBGNU), all-lib): Remove targets.
5214         (distclean): Don't mention GNULIB_BUILDDIR.
5215         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5216
5217 2019-06-14  Tom Tromey  <tromey@adacore.com>
5218
5219         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5220         Warn if symbol file does not provide any symbols.
5221
5222 2019-06-14  Tom Tromey  <tromey@adacore.com>
5223
5224         * source.c (find_and_open_source): Respect basenames_may_differ.
5225
5226 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5227
5228         * annotate.c (annotate_breakpoints_invalid): Make use of
5229         scoped_restore_terminal_state.
5230         (annotate_frames_invalid): Likewise.
5231
5232 2019-06-14  Tom Tromey  <tromey@adacore.com>
5233
5234         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5235         allow assignment to an internalvar.
5236
5237 2019-06-14  Tom Tromey  <tromey@adacore.com>
5238
5239         * ada-lex.l: Allow "_" in attribute names.
5240
5241 2019-06-14  Tom Tromey  <tromey@adacore.com>
5242
5243         PR gdb/24653:
5244         * regcache.c (registers_changed): Don't call alloca.
5245         * top.c (execute_command): Don't call alloca.
5246
5247 2019-06-13  Pedro Alves  <palves@redhat.com>
5248
5249         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5250         'expression'.  When parsing an expression, error out if there's
5251         junk after "unlimited".
5252         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5253         (do_set_command): Adjust calls to is_unlimited_literal.
5254
5255 2019-06-13  Pedro Alves  <palves@redhat.com>
5256
5257         * compile/compile.c (make_compile_options_def_group): Add braces
5258         around array_view initializer.
5259         * thread.c (make_thread_apply_all_options_def_group)
5260         (make_thread_apply_all_options_def_group): Likewise.
5261
5262 2019-06-13  Pedro Alves  <palves@redhat.com>
5263
5264         * NEWS (New commands): Mention "maint test-options
5265         require-delimiter", "maint test-options unknown-is-error", "maint
5266         test-options unknown-is-operand" and "maint show
5267         test-options-completion-result".
5268         (New command options, command completion): New section.
5269         (Completion improvements): New section.
5270         Mention that you can abbreviate "unlimited".
5271
5272 2019-06-13  Pedro Alves  <palves@redhat.com>
5273
5274         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5275         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5276         * unittests/cli-utils-selftests.c (test_parse_flags)
5277         (test_parse_flags_qcs): Delete.
5278         (test_cli_utils): Don't call deleted functions.
5279
5280 2019-06-13  Pedro Alves  <palves@redhat.com>
5281
5282         * thread.c: Include "cli/cli-option.h".
5283         (tp_array_compar_ascending): Global.
5284         (tp_array_compar): Delete function.
5285         (tp_array_compar_ascending, tp_array_compar_descending): New
5286         functions.
5287         (ascending_option_def, qcs_flag_option_def)
5288         (thr_qcs_flags_option_defs)
5289         (make_thread_apply_all_options_def_group)
5290         (make_thread_apply_options_def_group): New.
5291         (thread_apply_all_command): Use gdb::option::process_options.
5292         (thread_apply_command_completer)
5293         (thread_apply_all_command_completer): New.
5294         (thread_apply_command): Use gdb::option::process_options.
5295         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5296         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5297         to generate help text of "thread apply".  Adjust "taas"'s help.
5298         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5299         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5300
5301 2019-06-13  Pedro Alves  <palves@redhat.com>
5302
5303         * thread.c (thread_apply_command): Check for invalid TID with
5304         isdigit instead of !isalpha.
5305
5306 2019-06-13  Pedro Alves  <palves@redhat.com>
5307
5308         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5309         (validate_flags_qcs): New.
5310         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5311         (validate_flags_qcs): Declare.
5312         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5313         (make_frame_apply_options_def_group): New.
5314         (frame_apply_command_count): Process options with
5315         gdb::option::process_options.
5316         (frame_apply_completer): New.
5317         (frame_apply_level_completer, frame_apply_all_completer)
5318         (frame_apply_completer): New.
5319         (_initialize_stack): Update help of "frame apply", "frame apply
5320         level", "frame apply all" and "faas" to mention supported options
5321         and install command completers.
5322         * stack.h (frame_apply_all_completer): Declare.
5323         * thread.c: Include "stack.h".
5324         (tfaas_command): Add "--".
5325         (_initialize_thread): Update help "tfaas" to mention supported
5326         options and install command completer.
5327
5328 2019-06-13  Pedro Alves  <palves@redhat.com>
5329
5330         * completer.c (complete_nested_command_line): New.
5331         (gdb_completion_word_break_characters_throw): Add assertion.
5332         * completer.h (complete_nested_command_line): Declare.
5333
5334 2019-06-13  Pedro Alves  <palves@redhat.com>
5335
5336         * stack.c (parse_backtrace_qualifiers): New.
5337         (backtrace_command): Use it.
5338         (backtrace_command_completer): Complete on qualifiers.
5339
5340 2019-06-13  Pedro Alves  <palves@redhat.com>
5341
5342         * frame.c: Include "cli/cli-option.h.
5343         (user_set_backtrace_options): New.
5344         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5345         Delete.
5346         (get_prev_frame): Adjust.
5347         (boolean_option_def, uinteger_option_def)
5348         (set_backtrace_option_defs): New.
5349         (_initialize_frame): Adjust and use
5350         gdb::option::add_setshow_cmds_for_options to install "set
5351         backtrace past-main" and "set backtrace past-entry".
5352         * frame.h: Include "cli/cli-option.h".
5353         (struct frame_print_options): Forward declare.
5354         (print_frame_arguments_all, print_frame_arguments_scalars)
5355         (print_frame_arguments_none): Declare.
5356         (print_entry_values): Delete declaration.
5357         (struct frame_print_options, user_frame_print_options): New.
5358         (struct set_backtrace_options): New.
5359         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5360         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5361         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5362         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5363         (list_args_or_locals): Add frame_print_options parameter.
5364         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5365         * python/py-framefilter.c (enumerate_args): Pass down
5366         USER_FRAME_PRINT_OPTIONS.
5367         * stack.c: Include "cli/cli-option.h".
5368         (print_frame_arguments_all, print_frame_arguments_scalars)
5369         (print_frame_arguments_none): Declare.
5370         (print_raw_frame_arguments, print_entry_values): Delete.
5371         (user_frame_print_options): New.
5372         (boolean_option_def, enum_option_def, frame_print_option_defs):
5373         New.
5374         (struct backtrace_cmd_options): New.
5375         (bt_flag_option_def): New.
5376         (backtrace_command_option_defs): New.
5377         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5378         (print_frame_arg, read_frame_arg, print_frame_args)
5379         (print_frame_info, print_frame): Add frame_print_options parameter
5380         and use it.
5381         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5382         (backtrace_command_1): Add frame_print_options and
5383         backtrace_cmd_options parameters and use them.
5384         (make_backtrace_options_def_group): New.
5385         (backtrace_command): Process command options with
5386         gdb::option::process_options.
5387         (backtrace_command_completer): New.
5388         (_initialize_stack): Extend "backtrace"'s help to mention
5389         supported options.  Install completer for "backtrace".
5390         Install some settings commands with add_setshow_cmds_for_options.
5391
5392 2019-06-13  Pedro Alves  <palves@redhat.com>
5393
5394         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5395         and that "set/show print raw frame-arguments" are now deprecated.
5396
5397         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5398         command.
5399         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5400         * stack.c (_initialize_stack): Install "set/show print
5401         raw-frame-arguments", and deprecate "set/show print raw
5402         frame-arguments".
5403         * valprint.c (_initialize_valprint): Deprecate "set/show print
5404         raw".
5405
5406 2019-06-13  Pedro Alves  <palves@redhat.com>
5407
5408         * compile/compile.c (struct compile_options): New.
5409         (compile_flag_option_def, compile_command_option_defs)
5410         (make_compile_options_def_group): New.
5411         (compile_file_command): Handle options with
5412         gdb::option::process_options.
5413         (compile_file_command_completer): New function.
5414         (compile_code_command): Handle options with
5415         gdb::option::process_options.
5416         (compile_code_command_completer): New function.
5417         (_initialize_compiler): Install completers for "compile code" and
5418         "compile file".  Mention available options in "compile code" and
5419         "compile code"'s help.
5420         * completer.c (advance_to_completion_word): New, factored out from
5421         ...
5422         (advance_to_expression_complete_word_point): ... this.
5423         (advance_to_filename_complete_word_point): New.
5424         * completer.h (advance_to_filename_complete_word_point): New
5425         declaration.
5426
5427 2019-06-13  Pedro Alves  <palves@redhat.com>
5428
5429         * compile/compile.c: Include "cli/cli-option.h".
5430         (compile_print_value): Scope data pointer is now a
5431         value_print_options pointer; adjust.
5432         (compile_print_command): Process options.  Scope data pointer is
5433         now a value_print_options pointer; adjust.
5434         (_initialize_compile): Update "compile print"'s help to include
5435         supported options.  Install a completer for "compile print".
5436         * cp-valprint.c (show_vtblprint, show_objectprint)
5437         (show_static_field_print): Delete.
5438         (_initialize_cp_valprint): Don't install "set print
5439         static-members", "set print vtbl", "set print object" here.
5440         * printcmd.c: Include "cli/cli-option.h" and
5441         "common/gdb_optional.h".
5442         (print_command_parse_format): Rework to fill in a
5443         value_print_options instead of a format_data.
5444         (print_value): Change parameter type from format_data pointer to
5445         value_print_options reference.  Adjust.
5446         (print_command_1): Process options.  Adjust to pass down a
5447         value_print_options.
5448         (print_command_completer): New.
5449         (_initialize_printcmd): Install print_command_completer as
5450         handle_brkchars completer for the "print" command.  Update
5451         "print"'s help to include supported options.
5452         * valprint.c: Include "cli/cli-option.h".
5453         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5454         here from cp-valprint.c.
5455         (boolean_option_def, uinteger_option_def)
5456         (value_print_option_defs, make_value_print_options_def_group):
5457         New.  Use gdb::option::add_setshow_cmds_for_options to install
5458         "set print elements", "set print null-stop", "set print repeats",
5459         "set print pretty", "set print union", "set print array", "set
5460         print address", "set print symbol", "set print array-indexes".
5461         * valprint.h: Include <string> and "cli/cli-option.h".
5462         (make_value_print_options_def_group): Declare.
5463         (print_value): Change parameter type from format_data pointer to
5464         value_print_options reference.
5465         (print_command_completer): Declare.
5466
5467 2019-06-13  Pedro Alves  <palves@redhat.com>
5468
5469         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5470         (COMMON_SFILES): Add maint-test-settings.c.
5471         * cli/cli-decode.c (boolean_enums): New global, factored out from
5472         ...
5473         (add_setshow_boolean_cmd): ... here.
5474         * cli/cli-decode.h (boolean_enums): Declare.
5475         * cli/cli-option.c: New file.
5476         * cli/cli-option.h: New file.
5477         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5478         factored out from ...
5479         (parse_cli_boolean_value(const char *)): ... this.
5480         (is_unlimited_literal): Change parameter type to pointer to
5481         pointer.  Adjust and advance ARG pointer.
5482         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5483         (parse_cli_var_enum): New, factored out from ...
5484         (do_set_command): ... this.  Adjust.
5485         * cli/cli-setshow.h (parse_cli_boolean_value)
5486         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5487         (parse_cli_var_enum): Declare.
5488         * cli/cli-utils.c: Include "cli/cli-option.h".
5489         (get_ulongest): New.
5490         * cli/cli-utils.h (get_ulongest): Declare.
5491         (check_for_argument): New overloads.
5492         * maint-test-options.c: New file.
5493
5494 2019-06-13  Pedro Alves  <palves@redhat.com>
5495
5496         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5497         parse a range if "-" is at the end of the string.
5498
5499 2019-06-13  Pedro Alves  <palves@redhat.com>
5500
5501         * cli/cli-setshow.c (parse_auto_binary_operation)
5502         (parse_cli_boolean_value): Don't allow "o".
5503
5504 2019-06-13  Pedro Alves  <palves@redhat.com>
5505
5506         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5507         * NEWS: Mention maint test-settings KIND.
5508         * maint-test-settings.c: New file.
5509
5510 2019-06-13  Pedro Alves  <palves@redhat.com>
5511
5512         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5513         completer.
5514         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5515         "set" completers.
5516
5517 2019-06-13  Pedro Alves  <palves@redhat.com>
5518
5519         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5520         after item.
5521
5522 2019-06-13  Pedro Alves  <palves@redhat.com>
5523
5524         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5525
5526 2019-06-13  Pedro Alves <palves@redhat.com>
5527
5528         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5529         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5530         call.
5531         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5532         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5533         calls.
5534         (check_for_argument): Skip spaces after argument.
5535
5536 2019-06-13  Pedro Alves  <palves@redhat.com>
5537
5538         * thread.c (thread_apply_command): Adjust TID parsing.
5539         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5540         detected before end of string.
5541         (tid_is_in_list): Error out if LIST is invalid.
5542
5543 2019-06-13  Pedro Alves  <palves@redhat.com>
5544
5545         * completer.c (complete_line_internal_1): Rewind completion word
5546         point.
5547         (completion_tracker::advance_custom_word_point_by): Change
5548         parameter type to int.
5549         * completer.h (completion_tracker::advance_custom_word_point_by):
5550         Likewise.
5551
5552 2019-06-13  Pedro Alves  <palves@redhat.com>
5553
5554         * completer.c (advance_to_completion_word): Handle delimiters.
5555
5556 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5557
5558         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5559
5560 2019-06-11  Tom Tromey  <tom@tromey.com>
5561
5562         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5563         (xmalloc_failed): Move to alloc.c.
5564         * alloc.c: New file.
5565         * Makefile.in (COMMON_SFILES): Add alloc.c.
5566
5567 2019-06-11  Tom Tromey  <tom@tromey.com>
5568
5569         * nat/linux-waitpid.c: Don't include server.h.
5570         (linux_debug): Remove.
5571         (my_waitpid): Update.
5572
5573 2019-06-11  Tom Tromey  <tromey@adacore.com>
5574
5575         * infcall.c (_initialize_infcall): Remove trailing newline from
5576         help.
5577         * user-regs.c (_initialize_user_regs): Remove trailing newline
5578         from help.
5579         * typeprint.c (_initialize_typeprint): Remove trailing newline
5580         from help.
5581         * reverse.c (_initialize_reverse): Remove trailing newlines from
5582         help.
5583         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5584         from help.
5585         * language.c (add_set_language_command): Remove trailing newline
5586         from help.
5587         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5588         help.
5589         * disasm.c (_initialize_disasm): Remove trailing newline from
5590         help.
5591         * top.c (init_main): Remove trailing newline from help.
5592         * interps.c (_initialize_interpreter): Remove trailing newline
5593         from help.
5594         * btrace.c (_initialize_btrace): Remove trailing newlines from
5595         help.
5596         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5597         from help.
5598         * python/python.c (_initialize_python): Remove trailing newline
5599         from help.
5600         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5601         help.
5602         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5603         from help.  Reformat some text.
5604         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5605         from help.
5606         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5607         newline from help.
5608
5609 2019-06-11  Tom Tromey  <tromey@adacore.com>
5610
5611         * darwin-nat.c (darwin_decode_exception_message)
5612         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5613
5614 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5615
5616         * valops.c (value_slice): Check for not allocated or not
5617         associated values.
5618
5619 2019-06-10  Tom de Vries  <tdevries@suse.de>
5620
5621         PR gdb/24618
5622         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5623         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5624         invalid.
5625
5626 2019-06-10  Tom de Vries  <tdevries@suse.de>
5627
5628         PR gdb/24611
5629         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5630         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5631
5632 2019-06-10  Tom de Vries  <tdevries@suse.de>
5633
5634         PR symtab/24545
5635         * symtab.c (struct demangled_name_entry): Add language field.
5636         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5637         static minimal symbol".  Set and use language field.
5638
5639 2019-06-10  Tom Tromey  <tromey@adacore.com>
5640
5641         * ada-lang.c (_initialize_ada_language): Update help text.
5642
5643 2019-06-10  Tom Tromey  <tromey@adacore.com>
5644
5645         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5646         with a newline.
5647         * guile/guile.c (handle_boot_error): Don't end warning with a
5648         newline.
5649         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5650         warning with a newline.
5651         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5652         newline.
5653         (s12z_frame_cache): Likewise.
5654         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5655         a newline.
5656         * solib-svr4.c (disable_probes_interface): Don't end warning with
5657         a newline.
5658         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5659         newline.
5660         * python/python.c (do_finish_initialization): Don't end warning
5661         with a newline.
5662
5663 2019-06-10  Tom Tromey  <tom@tromey.com>
5664
5665         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5666         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5667         gdbpy_enter.
5668
5669 2019-06-10  Tom Tromey  <tromey@adacore.com>
5670
5671         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5672         data.
5673         (elf_new_init): Don't call stabsread_new_init.
5674         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5675         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5676         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5677
5678 2019-06-10  Tom de Vries  <tdevries@suse.de>
5679
5680         PR symtab/16264
5681         PR symtab/24517
5682         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5683
5684 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5685
5686         * source.c (find_and_open_source): Also rewrite relative file
5687         names.
5688
5689 2019-04-26  Amos Bird  <amosbird@gmail.com>
5690
5691         * annotate.c (annotate_thread_exited): Add "thread-exited"
5692         annotation.
5693
5694 2019-06-06  Tom Tromey  <tromey@adacore.com>
5695
5696         * maint.h (class scoped_command_stats): Use
5697         DISABLE_COPY_AND_ASSIGN.
5698         <print_time>: New method.
5699         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5700         print_time.
5701         (scoped_command_stats::print_time): New method.
5702
5703 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5704
5705         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5706         instructions of lengths 6 or 8 bytes.
5707
5708 2019-06-04  Pedro Alves  <palves@redhat.com>
5709
5710         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5711
5712         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5713         * breakpoint.c (condition_completer): Likewise.
5714         * cli/cli-dump.c (scan_expression): Likewise.
5715         * common/filestuff.c (mkdir_recursive): Likewise.
5716         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5717         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5718         (gdb_abspath): Likewise.
5719         * compile/compile-cplus-types.c
5720         (compile_cplus_instance::decl_name): Likewise.
5721         * completer.c (complete_explicit_location):
5722         (signal_completer, reg_or_group_completer_1): Likewise.
5723         * cp-support.c (cp_remove_params_if_any): Likewise.
5724         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5725         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5726         * infcmd.c (strip_bg_char): Likewise.
5727         * linespec.c (copy_token_string): Likewise.
5728         * mi/mi-main.c (output_cores): Likewise.
5729         * psymtab.c (psymtab_search_name):
5730         * symfile.c (test_set_ext_lang_command): Likewise.
5731         * target.c (target_fileio_read_stralloc): Likewise.
5732         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5733         * value.c (complete_internalvar): Likewise.
5734
5735 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5736
5737         Add objfile property to gdb.Type.
5738         * NEWS: Mention Python API addition.
5739         * python/py-type.c (typy_get_objfile): New method.
5740
5741 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5742
5743         * NEWS: Mention the new set|show style [title|highlight].
5744         Mention changes to "show style", "help" and "apropos".
5745
5746 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5747
5748         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5749         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5750         instead of print_help_for_command.
5751         (print_doc_of_command): New function.
5752         (help_list): Add 'apropos -v word' suggestion.
5753         (print_help_for_command): Style the command name using title style.
5754         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5755         (_initialize_cli_cmds): Describe -v in apropos_command help.
5756
5757 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5758
5759         * cli/cli-style.h (cli_style_option): Add name in constructor,
5760         add m_name class member, add constructor with intensity,
5761         add name class function.
5762         (cli_style_option::add_setshow_commands): Remove name argument.
5763         (highlight_style, title_style): New styles.
5764         * cli/cli-style.c (do_show): New function that shows a style
5765         characteristic styling the style name with itself.
5766         (set_style_name): New function.
5767         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5768         Update all callers according to the changes in cli/cli-style.h.
5769         * utils.h (fputs_highlighted): New function.
5770         * utils.c (fputs_highlighted): Likewise.
5771
5772 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5773
5774         * NEWS: Mention new pipe command and new convenience variables.
5775
5776 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5777
5778         * cli/cli-cmds.c (pipe_command): New function.
5779         (_initialize_cli_cmds): Call add_com for pipe_command.
5780         Define | as an alias for pipe.
5781         (exit_status_set_internal_vars): New function.
5782         (shell_escape): Call exit_status_set_internal_vars.
5783         cli/cli-decode.c (find_command_name_length): Recognize | as
5784         a single character command.
5785
5786 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5787
5788         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5789         top.c (execute_command_to_ui_file): New function, mostly a copy
5790         of execute_command_to_string.
5791         (execute_command_to_string): Implement by calling
5792         execute_command_to_ui_file.
5793
5794 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5795
5796         * top.h (saved_command_line): Remove declaration.
5797         * top.c (previous_saved_command_line, previous_repeat_arguments):
5798         New variables.
5799         (saved_command_line): Make static, define together with other
5800         'repeat variables'.
5801         (dont_repeat): Clear repeat_arguments.
5802         (repeat_previous, get_saved_command_line, save_command_line):
5803         New functions.
5804         (gdb_init): Initialize saved_command_line
5805         and previous_saved_command_line.
5806         * main.c (captured_main_1): Remove saved_command_line initialization.
5807         * event-top.c (handle_line_of_input): Update to use
5808         the new 'repeat' related functions instead of direct access to
5809         saved_command_line.
5810         * command.h (repeat_previous, get_saved_command_line,
5811         save_command_line): New declarations.
5812         (dont_repeat): Add comment.
5813
5814 2019-05-30  Tom Tromey  <tromey@adacore.com>
5815
5816         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5817         Fix comment.
5818         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5819
5820 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5821
5822         PR cli/24587
5823         * completer.c (complete): Initialize variable word.
5824
5825 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5826
5827         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5828         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5829         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5830         'body' is NULL to the outter 'if', protecting the '!is_define'
5831         situation as well.
5832
5833 2019-05-29  Tom Tromey  <tromey@adacore.com>
5834
5835         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5836         (dwarf_unknown): New function.
5837         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5838         (dwarf_type_encoding_name): Use dwarf_unknown.
5839
5840 2019-05-29  Tom Tromey  <tromey@adacore.com>
5841
5842         PR c++/20020:
5843         * cp-valprint.c (cp_print_value_fields): Call
5844         cp_print_static_field inside "try".
5845
5846 2019-05-29  Tom Tromey  <tromey@adacore.com>
5847
5848         * inflow.c (struct terminal_info): Add default operator=.
5849         * configure: Rebuild.
5850         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5851         -Wdeprecated-copy-dtor, -Wredundant-move.
5852
5853 2019-05-29  Tom Tromey  <tromey@adacore.com>
5854
5855         * NEWS: Add entry.
5856         * infcmd.c (print_return_value_1): Handle finish_print
5857         option.
5858         (show_print_finish): New function.
5859         (_initialize_infcmd): Add "set/show print finish" commands.
5860         * valprint.c (user_print_options): Initialize new member.
5861         * valprint.h (struct value_print_options) <finish_print>: New
5862         member.
5863
5864 2019-05-28  Tom Tromey  <tromey@adacore.com>
5865
5866         * ada-lang.c (ada_remove_Xbn_suffix)
5867         (find_old_style_renaming_symbol)
5868         (parse_old_style_renaming): Remove.
5869         (ada_find_renaming_symbol): Don't call
5870         find_old_style_renaming_symbol.
5871         (ada_is_renaming_symbol): Rename from
5872         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5873         bool.  Now static.
5874         (ada_read_var_value): Update and simplify.
5875         * ada-exp.y (write_var_or_type): Remove old code.
5876
5877 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5878
5879         * event-top.c: Remove include comment.
5880         * inflow.c (class scoped_ignore_sigttou): Move from here...
5881         * inflow.h (class scoped_ignore_sigttou): ...to here.
5882         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5883         * top.c:  Remove include comment.
5884
5885 2019-05-27  Tom Tromey  <tom@tromey.com>
5886
5887         * NEWS: Fix typo.
5888
5889 2019-05-22  Tom Tromey  <tromey@adacore.com>
5890
5891         * target.c (target_follow_exec): Constify parameter.
5892         * target-delegates.c: Rebuild.
5893         * remote.c (remote_target::follow_exec): Constify parameter.
5894         * infrun.c (follow_exec): Constify parameter.
5895         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5896         (target_follow_exec): Likewise.
5897
5898 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5899
5900         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5901         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5902
5903 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5904
5905         * NEWS: Add debugredirect and testsuite sections.
5906
5907 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5908
5909         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5910         target descriptions using exclusively floating point register name
5911         aliases.
5912
5913 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5914
5915         PR gdb/18644:
5916         * f-lang.c (build_fortran_types): Handle the case where
5917         gdbarch_floatformat_for_type returns a nullptr.
5918
5919 2019-05-21  Tom de Vries  <tdevries@suse.de>
5920
5921         PR cli/24587
5922         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5923
5924 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5925
5926         PR gdb/18644:
5927         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5928         16-byte floats.
5929         * i386-tdep.c (i386_floatformat_for_type): Use
5930         floatformats_ia64_quad for the 16-byte floating point component
5931         within a fortran 32-byte complex number.
5932
5933 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5936         delete default constructor.
5937         (find_partial_die): Update to return const struct.
5938         (partial_die_parent_scope): Move variable declaration into scope
5939         of its use and change its type to auto.
5940         (guess_partial_die_structure_name): Likewise.
5941         (partial_die_info::fixup): Likewise.
5942
5943 2019-05-17  Tom Tromey  <tromey@adacore.com>
5944
5945         * source.c (find_and_open_source): Remove cast.
5946
5947 2019-05-17  Tom Tromey  <tromey@adacore.com>
5948
5949         * annotate.c (annotate_source): Make "filename" const.
5950         * annotate.h (annotate_source): Use const.
5951
5952 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5953
5954         * disasm.c (set_disassembler_options): Send errors to stderr.
5955
5956 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5957
5958         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5959         (cli_interp_base::set_logging): Check debug_redirect.
5960         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5961         * cli/cli-logging.c (debug_redirect): Add static variable.
5962         (pop_output_files): Add default param.
5963         (handle_redirections): Print debug setting.
5964         (show_logging_command): Likewise.
5965         (_initialize_cli_logging): Add debugredirect command.
5966         * interps.c (current_interp_set_logging): Add debug_redirect
5967         parameter.
5968         * interps.h (set_logging): Add debug_redirect parameter.
5969         (current_interp_set_logging): Likewise.
5970         * mi/mi-common.h: Likewise.
5971         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5972
5973 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5974             Tom Tromey  <tromey@adacore.com>
5975
5976         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5977         directly.
5978         * cli/cli-interp.h (make_logging_output): Remove declaration.
5979         * cli/cli-logging.c (make_logging_output): Remove function.
5980         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5981         directly.
5982         * ui-file.c (tee_file::tee_file): Remove bools.
5983         (tee_file::~tee_file): Remove deletes.
5984         * ui-file.h (tee_file): Remove bools.
5985
5986 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5987
5988         * mi/mi-cmds.h (mi_cmd_complete): New function.
5989         * mi/mi-main.c (mi_cmd_complete): Likewise.
5990         * mi/mi-cmds.c: Define new MI command -complete.
5991         * NEWS: Mention new -complete command.
5992
5993 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5994
5995         * completer.h (complete): New function.
5996         * completer.c (complete): Likewise.
5997         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5998         function defined in completer.h.
5999
6000 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6001
6002         * MAINTAINERS (Write After Approval): Add myself.
6003
6004 2019-05-17  Tom de Vries  <tdevries@suse.de>
6005
6006         PR gdb/24094
6007         * dwarf2read.c (struct cu_partial_die_info): New struct.
6008         (find_partial_die): Return cu_partial_die_info.
6009         (partial_die_parent_scope, guess_partial_die_structure_name)
6010         (partial_die_info::fixup): Handle new return type of find_partial_die.
6011
6012 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6013
6014         PR breakpoints/24541
6015         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6016         "std::string", simplifying the algorithm.
6017
6018 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6019
6020         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6021         (stap_static_probe_ops::get_probes): Likewise.
6022
6023 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6024
6025         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6026         '-')" and "else if".
6027         (stap_parse_single_operand): Join checks for
6028         "gdbarch_stap_parse_special_token_p" and
6029         "gdbarch_stap_parse_special_token" in the same "if" statement.
6030         Invert check when verifying for operation on register
6031         displacement.
6032
6033 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6034
6035         * stap-probe.c (stap_get_opcode): Update comment.
6036         (stap_get_expected_argument_type): Likewise.
6037         (handle_stap_probe): Likewise.
6038
6039 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6040
6041         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6042         return type to 'bool'.  Adjust comment.  Use 'bool' when
6043         appropriate.
6044         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6045         * stap-probe.c (stap_parse_argument_1): Likewise.
6046         (stap_is_operator): Likewise.
6047         (stap_is_generic_prefix): Likewise.
6048         (stap_is_register_prefix): Likewise.
6049         (stap_is_register_indirection_prefix): Likewise.
6050         (stap_is_integer_prefix): Likewise.
6051         (stap_generic_check_suffix): Likewise.
6052         (stap_check_integer_suffix): Likewise.
6053         (stap_check_register_suffix): Likewise.
6054         (stap_check_register_indirection_suffix): Likewise.
6055         (stap_parse_register_operand): Likewise.
6056         (stap_parse_single_operand): Likewise.
6057         (stap_parse_argument_1): Likewise.
6058         (stap_probe::get_argument_count): Likewise.
6059         (stap_is_operator): Likewise.
6060
6061 2019-05-16  Tom Tromey  <tromey@adacore.com>
6062
6063         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6064         keyword to foreach.
6065
6066 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6067
6068         * linux-thread-db.c (try_thread_db_load_1): Change return type
6069         to bool.
6070         (try_thread_db_load): Likewise.
6071         (try_thread_db_load_from_pdir_1): Likewise.
6072         (try_thread_db_load_from_pdir): Likewise.
6073         (try_thread_db_load_from_sdir): Likewise.
6074         (try_thread_db_load_from_dir): Likewise.
6075         (thread_db_load_search): Likewise.
6076         (has_libpthread): Likewise.
6077         (thread_db_load): Likewise.
6078
6079 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6080
6081         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6082         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6083         NULL, and complain/return if that's the case.
6084
6085 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6086
6087         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6088         (advance, posn, abstract_read_memory): New functions.
6089         [struct mem_read_abstraction]: New struct.
6090         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6091
6092 2019-05-14  Tom Tromey  <tromey@adacore.com>
6093
6094         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6095         value is not lval_memory.
6096
6097 2019-05-14  Tom Tromey  <tromey@adacore.com>
6098
6099         * solib.c (info_sharedlibrary_command): Style the file name.
6100
6101 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6102
6103         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6104         (aarch64_vnv_type): Likewise.
6105         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6106         * common/tdesc.c: Likewise.
6107         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6108         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6109         * features/aarch64-fpu.xml: Add ieee half view.
6110         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6111         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6112         * gdbtypes.h (struct builtin_type): Likewise.
6113         (struct objfile_type): Likewise.
6114
6115 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6116
6117         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6118         typo.
6119         * location.h (string_to_event_location): Likewise.
6120
6121 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6122
6123         GDB 8.3 released.
6124
6125 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6126
6127         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6128         New variable declaration.
6129         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6130         New variable.
6131         (print_one_breakpoint): Use ui_out::test_flags and new global
6132         variable to compute use_fixed_output.
6133         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6134         Remove.
6135         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6136         (mi_multi_location_breakpoint_output_fixed): Remove.
6137         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6138         new variable.
6139         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6140         fix_multi_location_breakpoint_output flag if version >= 3.
6141         * ui-out.h (enum ui_out_flag)
6142         <fix_multi_location_breakpoint_output>: New enumerator.
6143
6144 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6145
6146         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6147
6148 2019-05-10  Tom Tromey  <tromey@adacore.com>
6149
6150         * ada-lang.c (catch_ada_completer): New function.
6151         (_initialize_ada_language): Use it.
6152
6153 2019-05-10  Tom Tromey  <tromey@adacore.com>
6154
6155         * thread.c (print_thread_info): Make "requested_threads" const.
6156         * gdbthread.h (print_thread_info): Make "requested_threads"
6157         const.
6158         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6159         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6160
6161 2019-05-08  Tom Tromey  <tom@tromey.com>
6162
6163         * gdbtypes.c (objfile_type_data): Change type.
6164         (objfile_type, _initialize_gdbtypes): Update.
6165
6166 2019-05-08  Tom Tromey  <tom@tromey.com>
6167
6168         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6169         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6170         (_initialize_dwarf2_frame): Update.
6171
6172 2019-05-08  Tom Tromey  <tom@tromey.com>
6173
6174         * objc-lang.c (objc_objfile_data): Change type.
6175         (find_methods): Update.
6176         (_initialize_objc_lang): Remove.
6177
6178 2019-05-08  Tom Tromey  <tom@tromey.com>
6179
6180         * stabsread.c (rs6000_builtin_type_data): Change type.
6181         (rs6000_builtin_type, _initialize_stabsread): Update.
6182
6183 2019-05-08  Tom Tromey  <tom@tromey.com>
6184
6185         * mips-tdep.c (mips_pdr_data): Remove.
6186         (_initialize_mips_tdep): Update.
6187
6188 2019-05-08  Tom Tromey  <tom@tromey.com>
6189
6190         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6191         (hppa_init_objfile_priv_data, read_unwind_info)
6192         (find_unwind_entry, _initialize_hppa_tdep): Update.
6193
6194 2019-05-08  Tom Tromey  <tom@tromey.com>
6195
6196         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6197         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6198         on obstack.
6199         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6200
6201 2019-05-08  Tom Tromey  <tom@tromey.com>
6202
6203         * mdebugread.c (basic_type_data): Change type.
6204         (basic_type, _initialize_mdebugread): Update.
6205
6206 2019-05-08  Tom Tromey  <tom@tromey.com>
6207
6208         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6209
6210 2019-05-08  Tom Tromey  <tom@tromey.com>
6211
6212         * nto-tdep.c (nto_inferior_data_reg): Change type.
6213         (nto_inferior_data): Update.
6214         (nto_inferior_data_cleanup, nto_new_inferior_data)
6215         (_initialize_nto_tdep): Remove.
6216         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6217
6218 2019-05-08  Tom Tromey  <tom@tromey.com>
6219
6220         * ada-lang.c (struct ada_inferior_data): Add initializers.
6221         (ada_inferior_data): Change type.
6222         (ada_inferior_data_cleanup): Remove.
6223         (get_ada_inferior_data, ada_inferior_exit)
6224         (struct ada_pspace_data): Add initializers, destructor.
6225         (ada_pspace_data_handle): Change type.
6226         (get_ada_pspace_data): Update.
6227         (ada_pspace_data_cleanup): Remove.
6228
6229 2019-05-08  Tom Tromey  <tom@tromey.com>
6230
6231         * coffread.c (struct coff_symfile_info): Add initializers.
6232         (coff_objfile_data_key): Move lower.  Change type.
6233         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6234         Update.
6235         (coff_free_info): Remove.
6236
6237 2019-05-08  Tom Tromey  <tom@tromey.com>
6238
6239         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6240         (fbsd_pspace_data_handle): Move lower.  Change type.
6241         (get_fbsd_pspace_data): Update.
6242         (fbsd_pspace_data_cleanup): Remove.
6243         (_initialize_fbsd_tdep): Update.
6244
6245 2019-05-08  Tom Tromey  <tom@tromey.com>
6246
6247         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6248         (get_ada_tasks_pspace_data): Update.
6249         (ada_tasks_pspace_data_cleanup): Remove.
6250         (_initialize_tasks): Update.
6251         (ada_tasks_inferior_data_handle): Change type.
6252         (get_ada_tasks_inferior_data): Update.
6253         (ada_tasks_inferior_data_cleanup): Remove.
6254         (struct ada_tasks_pspace_data): Add initializers.
6255
6256 2019-05-08  Tom Tromey  <tom@tromey.com>
6257
6258         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6259         * symfile-debug.c (debug_sym_get_probes): Change type.
6260         * stap-probe.c (handle_stap_probe):
6261         (stap_static_probe_ops::get_probes): Change type.
6262         * probe.h (class static_probe_ops) <get_probes>: Change type.
6263         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6264         (parse_probes_in_pspace): Update.
6265         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6266         Update.
6267         (any_static_probe_ops::get_probes): Change type.
6268         * elfread.c (elfread_data): New typedef.
6269         (probe_key): Change type.
6270         (elf_get_probes): Likewise.  Update.
6271         (probe_key_free): Remove.
6272         (_initialize_elfread): Update.
6273         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6274         Change type.
6275         (dtrace_process_dof_probe, dtrace_process_dof)
6276         (dtrace_static_probe_ops::get_probe): Change type.
6277
6278 2019-05-08  Tom Tromey  <tom@tromey.com>
6279
6280         * xcoffread.c (struct xcoff_symfile_info): Rename from
6281         coff_symfile_info.  Add initializers.
6282         (xcoff_objfile_data_key): Move lower.  Change type.
6283         (XCOFF_DATA): Rewrite.
6284         (xcoff_free_info): Remove.
6285         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6286         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6287         (xcoff_initial_scan): Update.
6288
6289 2019-05-08  Tom Tromey  <tom@tromey.com>
6290
6291         * solib-svr4.c (struct svr4_info): Add initializers and
6292         destructor.
6293         <probes_table>: Now an htab_up.
6294         (solib_svr4_pspace_data): Change type.
6295         (free_probes_table): Simplify.
6296         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6297         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6298         (probes_table_remove_objfile_probes, register_solib_event_probe)
6299         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6300         (_initialize_svr4_solib): Update.
6301
6302 2019-05-08  Tom Tromey  <tom@tromey.com>
6303
6304         * remote.c (remote_pspace_data): Change type.
6305         (remote_pspace_data_cleanup): Remove.
6306         (get_remote_exec_file, set_pspace_remote_exec_file)
6307         (_initialize_remote): Update.
6308
6309 2019-05-08  Tom Tromey  <tom@tromey.com>
6310
6311         * breakpoint.c (breakpoint_objfile_key): Change type.
6312         (get_breakpoint_objfile_data): Update.
6313         (free_breakpoint_objfile_data): Remove.
6314         (_initialize_breakpoint): Update.
6315
6316 2019-05-08  Tom Tromey  <tom@tromey.com>
6317
6318         * linux-tdep.c (struct linux_info): Add initializers.
6319         (linux_inferior_data): Move.  Change type.
6320         (invalidate_linux_cache_inf): Update.
6321         (linux_inferior_data_cleanup): Remove.
6322         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6323
6324 2019-05-08  Tom Tromey  <tom@tromey.com>
6325
6326         * auxv.c (auxv_inferior_data): Move.  Change type.
6327         (auxv_inferior_data_cleanup): Remove.
6328         (invalidate_auxv_cache_inf): Rewrite.
6329         (get_auxv_inferior_data, _initialize_auxv): Update.
6330
6331 2019-05-08  Tom Tromey  <tom@tromey.com>
6332
6333         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6334         (symfile_debug_objfile_data_key): Change type.
6335         (symfile_debug_installed, debug_qf_has_symbols)
6336         (debug_qf_find_last_source_symtab)
6337         (debug_qf_forget_cached_source_info)
6338         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6339         (debug_qf_print_stats, debug_qf_dump)
6340         (debug_qf_expand_symtabs_for_function)
6341         (debug_qf_expand_all_symtabs)
6342         (debug_qf_expand_symtabs_with_fullname)
6343         (debug_qf_map_matching_symbols)
6344         (debug_qf_expand_symtabs_matching)
6345         (debug_qf_find_pc_sect_compunit_symtab)
6346         (debug_qf_map_symbol_filenames)
6347         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6348         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6349         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6350         (debug_sym_read_linetable, debug_sym_relocate): Update.
6351         (symfile_debug_free_objfile): Remove.
6352         (install_symfile_debug_logging, _initialize_symfile_debug):
6353         Update.
6354
6355 2019-05-08  Tom Tromey  <tom@tromey.com>
6356
6357         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6358         allocate_on_obstack.
6359         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6360         (get_dwarf2_per_objfile): Update.
6361         (set_dwarf2_per_objfile): Remove.
6362         (dwarf2_has_info, dwarf2_get_section_info): Update.
6363         (dwarf2_free_objfile): Remove.
6364         (_initialize_dwarf2_read): Update.
6365
6366 2019-05-08  Tom Tromey  <tom@tromey.com>
6367
6368         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6369         initializers.
6370         <unsupported_script_warning_printed,
6371         script_not_found_warning_printed>: Now bool.
6372         (auto_load_pspace_data): Change type.
6373         (~auto_load_pspace_info): Rename from
6374         auto_load_pspace_data_cleanup.
6375         (get_auto_load_pspace_data, init_loaded_scripts_info)
6376         (clear_section_scripts, maybe_print_unsupported_script_warning)
6377         (maybe_print_script_not_found_warning, _initialize_auto_load):
6378         Update.
6379
6380 2019-05-08  Tom Tromey  <tom@tromey.com>
6381
6382         * objfiles.c (objfile_pspace_info): Add destructor and
6383         initializers.
6384         (objfiles_pspace_data): Change type.
6385         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6386         (get_objfile_pspace_data): Update.
6387         (objfiles_bfd_data): Change type.
6388         (get_objfile_bfd_data): Update.
6389         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6390
6391 2019-05-08  Tom Tromey  <tom@tromey.com>
6392
6393         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6394         Change type.
6395         (get_catch_syscall_inferior_data): Update.
6396         (catch_syscall_inferior_data_cleanup): Remove.
6397         (_initialize_break_catch_syscall): Update.
6398
6399 2019-05-08  Tom Tromey  <tom@tromey.com>
6400
6401         * inflow.c (struct terminal_info): Add destructor and
6402         initializers.
6403         (inflow_inferior_data): Change type.
6404         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6405         (get_inflow_inferior_data, inflow_inferior_exit)
6406         (swap_terminal_info, _initialize_inflow): Update.
6407
6408 2019-05-08  Tom Tromey  <tom@tromey.com>
6409
6410         * target-dcache.c (target_dcache_cleanup): Remove.
6411         (target_dcache_aspace_key): Change type.
6412         (target_dcache_init_p, target_dcache_invalidate)
6413         (target_dcache_get, target_dcache_get_or_init)
6414         (_initialize_target_dcache): Update.
6415         * dcache.h (struct dcache_deleter): New.
6416
6417 2019-05-08  Tom Tromey  <tom@tromey.com>
6418
6419         * symtab.c (struct symbol_cache): Add destructor and
6420         initializers.
6421         (symbol_cache_key): Move.  Change type.
6422         (make_symbol_cache, free_symbol_cache): Remove.
6423         (get_symbol_cache): Update.
6424         (symbol_cache_cleanup): Remove.
6425         (ALL_PSPACES, symbol_cache_flush)
6426         (maintenance_print_symbol_cache)
6427         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6428         Update.
6429
6430 2019-05-08  Tom Tromey  <tom@tromey.com>
6431
6432         * symtab.c (struct main_info): Add destructor and initializers.
6433         (main_progspace_key): Move.  Change type.
6434         (get_main_info): Update.
6435         (main_info_cleanup): Remove.
6436         (_initialize_symtab): Update.
6437
6438 2019-05-08  Tom Tromey  <tom@tromey.com>
6439
6440         * registry.h (DECLARE_REGISTRY): Define the _key class.
6441
6442 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * NEWS: Merge two 'New commands' sections.
6445
6446 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6447
6448         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6449         parameter and use Ada language definition instead.
6450         (ada_val_print_ptr): Remove unused language parameter.
6451         (ada_val_print_num): Remove language parameter and use Ada language
6452         definition instead.
6453         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6454         parameter.
6455         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6456         parameter and use Ada language definition instead.
6457         (ada_val_print_1): Update all ada_val_print_xxx calls.
6458         Remove language parameter.
6459         (ada_val_print): Update ada_val_print_1 call.
6460
6461 2019-05-08  Tom Tromey  <tromey@adacore.com>
6462
6463         * remote.c (remote_hw_watchpoint_limit)
6464         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6465         Now static.
6466
6467 2019-05-08  Tom Tromey  <tromey@adacore.com>
6468
6469         * maint.c (_initialize_maint_cmds): Move initialization code to
6470         remote.c.
6471         (watchdog, show_watchdog): Move to remote.c.
6472         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6473         "watchdog" static.
6474         (_initialize_remote): Move initialization code from maint.c.
6475         * defs.h (watchdog): Don't declare.
6476
6477 2019-05-08  Tom Tromey  <tromey@adacore.com>
6478
6479         * tui/tui-interp.c: Include main.h.
6480         * interps.c: Include main.h.
6481         * main.h (interpreter_p): Declare.
6482         * defs.h (interpreter_p): Don't declare.
6483
6484 2019-05-08  Tom Tromey  <tromey@adacore.com>
6485
6486         * dwarf2loc.c: Include dwarf2read.h.
6487         * defs.h (read_unsigned_leb128): Don't declare.
6488         * dwarf2read.h (read_unsigned_leb128): Declare.
6489
6490 2019-05-08  Tom Tromey  <tromey@adacore.com>
6491
6492         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6493         method.
6494
6495 2019-05-08  Tom Tromey  <tromey@adacore.com>
6496
6497         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6498         when no wrap column is set.
6499
6500 2019-05-08  Tom Tromey  <tromey@adacore.com>
6501
6502         * c-lang.c (c_get_string): Handle non-C-style arrays.
6503
6504 2019-05-08  Tom Tromey  <tromey@adacore.com>
6505
6506         * typeprint.c (print_offset_data::update): Print the bit offset,
6507         not the number of bits remaining.
6508
6509 2019-05-08  Tom Tromey  <tromey@adacore.com>
6510
6511         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6512         padding at end of comment.
6513
6514 2019-05-08  Tom Tromey  <tromey@adacore.com>
6515
6516         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6517         Compare main types.
6518
6519 2019-05-06  Tom Tromey  <tom@tromey.com>
6520
6521         * common/scoped_mmap.c: Include common-defs.h.
6522         * common/scoped_mmap.h: Don't include config.h.
6523
6524 2019-05-04  Tom Tromey  <tom@tromey.com>
6525
6526         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6527         (struct aarch64_call_info): Add initializers.
6528         <si>: Now a std::vector.
6529         (pass_on_stack, aarch64_push_dummy_call): Update.
6530
6531 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6532             Tom Tromey  <tom@tromey.com>
6533
6534         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6535         (ppc_threads): Now a std::vector.  Now static.
6536         (hwdebug_find_thread_points_by_tid)
6537         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6538         Update.
6539
6540 2019-05-04  Tom Tromey  <tom@tromey.com>
6541
6542         * arc-tdep.c (arc_tdesc_init): Return bool.
6543
6544 2019-05-04  Tom Tromey  <tom@tromey.com>
6545
6546         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6547         Use gdb_assert_not_reached.
6548
6549 2019-05-04  Tom Tromey  <tom@tromey.com>
6550
6551         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6552         "false".
6553
6554 2019-05-04  Tom Tromey  <tom@tromey.com>
6555
6556         * arc-tdep.c (arc_tdesc_init): Use bool.
6557
6558 2019-05-04  Tom Tromey  <tom@tromey.com>
6559
6560         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6561
6562 2019-05-04  Tom Tromey  <tom@tromey.com>
6563
6564         * cli/cli-cmds.c (valid_command_p): Return bool.
6565
6566 2019-05-04  Tom Tromey  <tom@tromey.com>
6567
6568         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6569         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6570
6571 2019-05-04  Raul Tambre  <raul@tambre.ee>
6572
6573         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6574         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6575         operator for comparison.
6576
6577 2019-05-04  Tom Tromey  <tom@tromey.com>
6578
6579         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6580         (lookup_partial_symbol, print_partial_symbols)
6581         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6582         (psymbol_compare): Update.
6583         (add_psymbol_to_bcache): Clear the entire psymbol.
6584         (maintenance_check_psymtabs): Update.
6585         * psympriv.h (struct partial_symbol): Don't derive from
6586         general_symbol_info.
6587         <obj_section, unrelocated_address, address,
6588         set_unrelocated_address>: Update.
6589         <ginfo>: New member.
6590         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6591         (debug_names::write_psymbols): Update.
6592
6593 2019-05-04  Tom de Vries  <tdevries@suse.de>
6594
6595         * contrib/cc-with-tweaks.sh: Support -n arg.
6596
6597 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6598
6599         * corelow.c (core_target::detach): Ensure frame cache and
6600         register caches are cleared.
6601         inferior.c (exit_inferior_1): Likewise.
6602
6603 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6604             Tom Tromey  <tom@tromey.com>
6605
6606         * dictionary.c (collate_pending_symbols_by_language): Remove
6607         "struct" from foreach.
6608         * symtab.c (lookup_global_symbol_from_objfile)
6609         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6610         foreach.
6611         * ser-tcp.c (net_open): Remove "struct" from foreach.
6612         * objfiles.c (objfile_relocate, objfile_rebase)
6613         (objfile_has_symbols): Remove "struct" from foreach.
6614         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6615         from foreach.
6616         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6617         foreach.
6618         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6619         "struct" from foreach.
6620         * ada-lang.c (create_excep_cond_exprs)
6621         (ada_exception_catchpoint_cond_string): Remove "struct" from
6622         foreach.
6623
6624 2019-05-03  Tom Tromey  <tromey@adacore.com>
6625
6626         * ada-exp.y (convert_char_literal): Check suffix of each
6627         enumerator.
6628
6629 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6630
6631         PR ada/21406:
6632         * ada-exp.y (yywrap): Don't define.
6633         * ada-lex.l (%option): Add noyywrap
6634         (yywrap): Remove.
6635
6636 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6637
6638         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6639         _WIN32_WINNT to the XP level, unless already defined to a higher
6640         level.
6641
6642         * unittests/parse-connection-spec-selftests.c:
6643         * ser-tcp.c:
6644         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6645         override.
6646
6647         * symfile.c (find_separate_debug_file): Remove colon from the
6648         drive spec of DOS/Windows file names of the target, so that the
6649         file name produced from DEBUGDIR and the target's directory will
6650         be valid on DOS/Windows systems.
6651
6652 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6653
6654         * rust-lang.c (val_print_struct): Handle printing structures
6655         containing strings.
6656
6657 2019-05-02  Tom Tromey  <tromey@adacore.com>
6658
6659         * valarith.c (_initialize_valarith): Remove.
6660
6661 2019-05-01  Tom Tromey  <tromey@adacore.com>
6662
6663         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6664         bitfields.
6665
6666 2019-05-01  Tom Tromey  <tromey@adacore.com>
6667
6668         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6669         for big-endian copies.
6670
6671 2019-04-30  Ali Tamur  <tamur@google.com>
6672         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6673         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6674         (read_3_bytes): New function.
6675
6676 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6677
6678         * windows-nat.c (main_thread_id): Delete.
6679         (handle_output_debug_string): Replace main_thread_id by
6680         current_event.dwThreadId.
6681         (fake_create_process): Likewise.
6682         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6683         Do not set main_thread_id.
6684         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6685         current_event.dwThreadId.
6686         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6687
6688 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6689
6690         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6691         Use current_event.dwThreadId instead of main_thread_id.
6692
6693 2019-04-30  Tom Tromey  <tromey@adacore.com>
6694
6695         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6696         (create_excep_cond_exprs): Iterate over program spaces.
6697         (ada_exception_catchpoint_cond_string): Examine all minimal
6698         symbols for exception types.
6699
6700 2019-04-30  Tom Tromey  <tromey@adacore.com>
6701
6702         PR c++/24470:
6703         * dwarf2read.c (process_structure_scope): Handle case where type
6704         has template parameters but no symbol was created.
6705
6706 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6707             Chris January  <chris.january@arm.com>
6708
6709         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6710         qualifier.
6711         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6712
6713 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6714
6715         * f-typeprint.c (f_print_type): Update rules for printing
6716         whitespace.
6717         (f_type_print_varspec_suffix): Likewise.
6718
6719 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6720             Chris January  <chris.january@arm.com>
6721
6722         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6723         function arguments.
6724
6725 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6726
6727         * f-lang.c (build_fortran_types): Change name of void type to
6728         lower case.
6729         * f-typeprint.c (f_type_print_base): Print the name of the void
6730         type, rather than a fixed string.
6731         * f-valprint.c (f_decorations): Use lower case void string.
6732
6733 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6734             Chris January  <chris.january@arm.com>
6735
6736         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6737         types for Fortran.
6738
6739 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6740             Chris January  <chris.january@arm.com>
6741             David Lecomber  <david.lecomber@arm.com>
6742
6743         * f-exp.y (BINOP_INTRINSIC): New token.
6744         (exp): New parser rule handling BINOP_INTRINSIC.
6745         (f77_keywords): Add new builtin procedures.
6746         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6747         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6748         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6749         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6750         (print_unop_subexp_f): New function.
6751         (print_binop_subexp_f): New function.
6752         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6753         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6754         (dump_subexp_body_f): Likewise.
6755         (operator_check_f): Likewise.
6756         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6757         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6758
6759 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6760
6761         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6762         UNOP_KIND.
6763         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6764         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6765         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6766         (operator_length_f): New fuction.
6767         (print_subexp_f): New function.
6768         (op_name_f): New function.
6769         (dump_subexp_body_f): New function.
6770         (operator_check_f): New function.
6771         (exp_descriptor_f): Replace standard expression handling functions
6772         with new functions.
6773         * gdb/fortran-operator.def: New file.
6774         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6775         * gdb/std-operator.def: Remove UNOP_KIND.
6776
6777 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6778
6779         * std-operator.def: Remove unbalanced, stray double quote
6780         character.
6781
6782 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6783             Chris January  <chris.january@arm.com>
6784             Daniel Everett  <daniel.everett@arm.com>
6785             Nick Forrington  <nick.forrington@arm.com>
6786             Richard Bunt  <richard.bunt@arm.com>
6787
6788         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6789         of depth when printing anonymous structs or unions.
6790         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6791         Don't print either the top-level value, or the children if the
6792         max-depth is exceeded.
6793         (ppscm_print_children): When printing the key of a map, allow one
6794         extra level of depth.
6795         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6796         print either the top-level value, or the children if the max-depth
6797         is exceeded.
6798         (print_children): When printing the key of a map, allow one extra
6799         level of depth.
6800         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6801         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6802         (user_print_options): Initialise max_depth field.
6803         (val_print_scalar_or_string_type_p): New function.
6804         (val_print): Check to see if the max depth has been reached.
6805         (val_print_check_max_depth): Define new function.
6806         (show_print_max_depth): New function.
6807         (_initialize_valprint): Add 'print max-depth' option.
6808         * valprint.h (struct value_print_options) <max_depth>: New field.
6809         (val_print_check_max_depth): Declare new function.
6810         * NEWS: Document new feature.
6811
6812 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6813
6814         * ada-lang.c (ada_language_defn): Initialise new field.
6815         * c-lang.c (c_is_string_type_p): New function.
6816         (c_language_defn): Initialise new field.
6817         (cplus_language_defn): Initialise new field.
6818         (asm_language_defn): Initialise new field.
6819         (minimal_language_defn): Initialise new field.
6820         * c-lang.h (c_is_string_type_p): Declare new function.
6821         * d-lang.c (d_language_defn): Initialise new field.
6822         * f-lang.c (f_is_string_type_p): New function.
6823         (f_language_defn): Initialise new field.
6824         * go-lang.c (go_is_string_type_p): New function.
6825         (go_language_defn): Initialise new field.
6826         * language.c (default_is_string_type_p): New function.
6827         (unknown_language_defn): Initialise new field.
6828         (auto_language_defn): Initialise new field.
6829         * language.h (struct language_defn) <la_is_string_type_p>: New
6830         member variable.
6831         (default_is_string_type_p): Declare new function.
6832         * m2-lang.c (m2_language_defn): Initialise new field.
6833         * objc-lang.c (objc_language_defn): Initialise new field.
6834         * opencl-lang.c (opencl_language_defn): Initialise new field.
6835         * p-lang.c (pascal_is_string_type_p): New function.
6836         (pascal_language_defn): Initialise new field.
6837         * rust-lang.c (rust_is_string_type_p): New function.
6838         (rust_language_defn): Initialise new field.
6839
6840 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6841
6842         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6843         New field.
6844         * ada-lang.c (ada_language_defn): Initialise new field.
6845         * c-lang.c (c_language_defn): Likewise.
6846         (cplus_language_defn): Likewise.
6847         (asm_language_defn): Likewise.
6848         (minimal_language_defn): Likewise.
6849         * d-lang.c (d_language_defn): Likewise.
6850         * f-lang.c (f_language_defn): Likewise.
6851         * go-lang.c (go_language_defn): Likewise.
6852         * language.c (unknown_language_defn): Likewise.
6853         (auto_language_defn): Likewise.
6854         * m2-lang.c (m2_language_defn): Likewise.
6855         * objc-lang.c (objc_language_defn): Likewise.
6856         * opencl-lang.c (opencl_language_defn): Likewise.
6857         * p-lang.c (pascal_language_defn): Likewise.
6858         * rust-lang.c (rust_language_defn): Likewise.
6859
6860 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6861
6862         * ada-lang.c (ada_is_character_type): Change return type to bool.
6863         (ada_is_string_type): Likewise.
6864         * ada-lang.h (ada_is_character_type): Update declaration
6865         (ada_is_string_type): Likewise.
6866
6867 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6868
6869         Support style in 'frame|thread apply'
6870
6871         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6872         * record.c (record_start, record_stop): Update callers of
6873         execute_command_to_string with false.
6874         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6875         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6876         methods.
6877         (class string_file): New constructor with term_out parameter.
6878         Override methods term_out and can_emit_style_escape.  New member
6879         term_out.
6880         (class stdio_file): Override can_emit_style_escape.
6881         (class tee_file): Override term_out and can_emit_style_escape.
6882         * utils.h (can_emit_style_escape): Remove.
6883         * utils.c (can_emit_style_escape): Likewise.
6884         Update all callers of can_emit_style_escape (SOMESTREAM) to
6885         SOMESTREAM->can_emit_style_escape.
6886         * source-cache.c (source_cache::get_source_lines): Likewise.
6887         * stack.c (frame_apply_command_count): Call execute_command_to_string
6888         passing the term_out characteristic of the current gdb_stdout.
6889         * thread.c (thr_try_catch_cmd): Likewise.
6890         * top.c (execute_command_to_string): pass term_out parameter
6891         to construct the string_file for the command output.
6892         * ui-file.c (term_cli_styling): New function (most code moved
6893         from utils.c can_emit_style_escape).
6894         (string_file::string_file, string_file::can_emit_style_escape,
6895         stdio_file::can_emit_style_escape, tee_file::term_out,
6896         tee_file::can_emit_style_escape): New functions.
6897
6898 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6899
6900         * NEWS: Mention the new set|show may-call-functions.
6901         * infcall.c (may_call_functions_p): New variable.
6902         (show_may_call_functions_p): New function.
6903         (call_function_by_hand_dummy): Throws an error if not
6904         may-call-functions.
6905         (_initialize_infcall): Call add_setshow_boolean_cmd for
6906         may-call-functions.
6907
6908 2019-04-25  Keith Seitz  <keiths@redhat.com>
6909
6910         PR c++/24367
6911         * cp-support.c (inspect_type): Don't attempt substitutions
6912         of symbol with the same name.
6913
6914 2019-04-25  Tom Tromey  <tromey@adacore.com>
6915
6916         PR gdb/24475:
6917         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6918         static.
6919
6920 2019-04-25  Tom Tromey  <tromey@adacore.com>
6921
6922         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6923         rvalue reference.
6924         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6925         (gdb_xml_parser::parse): Use std::move.
6926         * python/python-internal.h (gdbpy_convert_exception): Take a const
6927         reference.
6928         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6929         std::move.
6930         * python/py-utils.c (gdbpy_convert_exception): Take a const
6931         reference.
6932         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6933         Use std::move.
6934         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6935         Use std::move.
6936         * mi/mi-main.c (mi_print_exception): Take a const reference.
6937         * main.c (handle_command_errors): Take a const reference.
6938         * linespec.c (parse_linespec): Use std::move.
6939         * infcall.c (run_inferior_call): Use std::move.
6940         (call_function_by_hand_dummy): Use std::move.
6941         * exec.c (try_open_exec_file): Use std::move.
6942         * exceptions.h (exception_print, exception_fprintf)
6943         (exception_print_same): Update.
6944         * exceptions.c (print_exception, exception_print)
6945         (exception_fprintf, exception_print_same): Change parameters to
6946         const reference.
6947         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6948         * common/new-op.c: Use std::move.
6949         * common/common-exceptions.h (struct gdb_exception): Add move
6950         constructor.
6951         (struct gdb_exception_error, struct gdb_exception_quit, struct
6952         gdb_quit_bad_alloc): Change constructor to move constructor.
6953         (throw_exception): Change parameter to rvalue reference.
6954         * common/common-exceptions.c (throw_exception): Take rvalue
6955         reference.
6956         * cli/cli-interp.c (safe_execute_command): Use std::move.
6957         * breakpoint.c (insert_bp_location, location_to_sals): Use
6958         std::move.
6959
6960 2019-04-25  Tom Tromey  <tromey@adacore.com>
6961
6962         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6963         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6964         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6965         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6966         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6967         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6968         guile/scm-value.c: Use unpack.
6969         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6970         gdbscm_gdb_exception.
6971         (gdbscm_throw_gdb_exception): Likewise.
6972         (struct gdbscm_gdb_exception): New.
6973         (unpack): New function.
6974         (gdbscm_wrap): Use unpack.
6975
6976 2019-04-25  Tom Tromey  <tromey@adacore.com>
6977
6978         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6979         (gdb_rl_callback_handler): Use std::move.
6980         * common/common-exceptions.h (struct gdb_exception): Add move
6981         assignment operator.
6982         (throw_exception_sjlj): Change "exception" to const reference.
6983         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6984         (throw_exception_sjlj): Change "exception" to const reference.
6985
6986 2019-04-25  Tom Tromey  <tromey@adacore.com>
6987
6988         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6989         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6990         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6991         Update.
6992         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6993         Update.
6994         * mi/mi-interp.c (mi_interp::exec): Update.
6995         * linespec.c (parse_linespec): Update.
6996         * infcall.c (run_inferior_call): Update.
6997         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6998         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6999         (gdbscm_lookup_global_symbol): Update.
7000         * guile/scm-param.c (gdbscm_parameter_value): Update.
7001         * guile/scm-frame.c (gdbscm_frame_read_register)
7002         (gdbscm_frame_read_var): Update.
7003         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7004         * exec.c (try_open_exec_file): Update.
7005         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7006         (gdb_rl_callback_handler): Update.
7007         * common/common-exceptions.h (exception_none): Don't declare.
7008         * common/common-exceptions.c (exception_none): Don't define.
7009         (struct catcher) <exception>: Update.
7010         * cli/cli-interp.c (safe_execute_command): Update.
7011         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7012
7013 2019-04-25  Ali Tamur  <tamur@google.com>
7014
7015         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7016         (read_attribute_value): Likewise.
7017         (dwarf2_read_addr_index): Update comment.
7018         (read_str_index): Add DW_FORM_strx.
7019         (dwarf2_string_attr): Likewise.
7020         (dwarf2_const_value_attr): Likewise.
7021         (dump_die_shallow): Likewise.
7022         (dwarf2_fetch_constant_bytes): Likewise.
7023         (skip_form_bytes): Likewise.
7024         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7025
7026 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7027
7028         PR corefiles/11608
7029         PR corefiles/18187
7030         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7031         OFFSET.  Verify if current mapping contains an ELF header.
7032         (linux_find_memory_regions_full): Adjust call to
7033         dump_mapping_p.
7034
7035 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7036             Kang Li <kanglictf@gmail.com>
7037
7038         PR gdb/21600
7039
7040         * dwarf2-frame.c (read_initial_length): Be consistent about using
7041         unsigned representation of length.
7042         (decode_frame_entry_1): Likewise.  Check for wraparound of
7043         end pointer as well as buffer overflow.
7044
7045 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7046
7047         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7048         "vq".
7049
7050 2019-04-24  Tom Tromey  <tromey@adacore.com>
7051
7052         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7053
7054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7055
7056         * s12z-tdep.c (s12z_unwind_pc): Delete.
7057         (s12z_unwind_sp): Delete.
7058         (s12z_gdbarch_init): Don't register deleted functions with
7059         gdbarch.
7060
7061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7062
7063         * rl78-tdep.c (rl78_unwind_sp): Delete.
7064         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7065
7066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7067
7068         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7069         (xstormy16_unwind_pc): Delete.
7070         (xstormy16_dummy_id): Delete.
7071         (xstormy16_gdbarch_init): Don't register deleted functions with
7072         gdbarch.
7073
7074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7075
7076         * vax-tdep.c (vax_unwind_pc): Delete.
7077         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7078
7079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7080
7081         * v850-tdep.c (v850_unwind_sp): Delete.
7082         (v850_unwind_pc): Delete.
7083         (v850_dummy_id): Delete.
7084         (v850_gdbarch_init): Don't register deleted functions with
7085         gdbarch.
7086
7087 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7088
7089         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7090         (tilegx_unwind_pc): Delete.
7091         (tilegx_unwind_dummy_id): Delete.
7092         (tilegx_gdbarch_init): Don't register deleted functions with
7093         gdbarch.
7094
7095 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7096
7097         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7098         (tic6x_dummy_id): Delete.
7099         (tic6x_gdbarch_init): Don't register deleted functions with
7100         gdbarch.
7101
7102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7103
7104         * sparc-tdep.c (sparc_unwind_pc): Delete.
7105         (sparc32_gdbarch_init): Don't register deleted function with
7106         gdbarch.
7107
7108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7109
7110         * sh-tdep.c (sh_unwind_sp): Delete.
7111         (sh_unwind_pc): Delete.
7112         (sh_dummy_id): Delete.
7113         (sh_gdbarch_init): Don't register deleted functions with
7114         gdbarch.
7115
7116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7117
7118         * score-tdep.c (score_unwind_sp): Delete.
7119         (score_unwind_pc): Delete.
7120         (score_dummy_id): Delete.
7121         (score_gdbarch_init): Don't register deleted functions with
7122         gdbarch.
7123
7124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7125
7126         * rx-tdep.c (rx_unwind_pc): Delete.
7127         (rx_unwind_sp): Delete.
7128         (rx_dummy_id): Delete.
7129         (rx_gdbarch_init): Don't register deleted functions with
7130         gdbarch.  Update comment.
7131
7132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7133
7134         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7135         (rs6000_dummy_id): Delete.
7136         (rs6000_gdbarch_init): Don't register deleted functions with
7137         gdbarch.
7138
7139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7140
7141         * or1k-tdep.c (or1k_dummy_id): Delete.
7142         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7143
7144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7145
7146         * nios2-tdep.c (nios2_dummy_id): Delete.
7147         (nios2_unwind_sp): Delete.
7148         (nios2_gdbarch_init): Don't register deleted functions with
7149         gdbarch.
7150
7151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * nds32-tdep.c (nds32_dummy_id): Delete.
7154         (nds32_unwind_pc): Delete.
7155         (nds32_unwind_sp): Delete.
7156         (nds32_gdbarch_init): Don't register deleted functions with
7157         gdbarch.
7158
7159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7160
7161         * msp430-tdep.c (msp430_unwind_pc): Delete.
7162         (msp430_unwind_sp): Delete.
7163         (msp430_dummy_id): Delete.
7164         (msp430_gdbarch_init): Don't register deleted functions with
7165         gdbarch.
7166
7167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7168
7169         * moxie-tdep.c (moxie_unwind_sp): Delete.
7170         (moxie_unwind_pc): Delete.
7171         (moxie_dummy_id): Delete.
7172         (moxie_gdbarch_init): Don't register deleted functions with
7173         gdbarch.
7174
7175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7176
7177         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7178         (mn10300_unwind_pc): Delete.
7179         (mn10300_unwind_sp): Delete.
7180         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7181         mn10300_unwind_sp.
7182         (mn10300_frame_unwind_init): Don't register deleted functions with
7183         gdbarch.
7184
7185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7186
7187         * mep-tdep.c (mep_unwind_pc): Delete.
7188         (mep_unwind_sp): Delete.
7189         (mep_dummy_id): Delete.
7190         (mep_gdbarch_init): Don't register deleted functions with
7191         gdbarch.
7192
7193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7194
7195         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7196         (m68hc11_unwind_sp): Delete.
7197         (m68hc11_gdbarch_init): Don't register deleted functions with
7198         gdbarch.
7199
7200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7201
7202         * m32r-tdep.c (m32r_unwind_sp): Delete.
7203         (m32r_unwind_pc): Delete.
7204         (m32r_dummy_id): Delete.
7205         (m32r_gdbarch_init): Don't register deleted functions with
7206         gdbarch.
7207
7208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7209
7210         * m32c-tdep.c (m32c_unwind_pc): Delete.
7211         (m32c_unwind_sp): Delete.
7212         (m32c_dummy_id): Delete.
7213         (m32c_gdbarch_init): Don't register deleted functions with
7214         gdbarch.
7215
7216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7217
7218         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7219         (lm32_unwind_pc): Delete.
7220         (lm32_dummy_id): Delete.
7221         (lm32_gdbarch_init): Don't register deleted functions with
7222         gdbarch.
7223
7224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7225
7226         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7227         (iq2000_unwind_pc): Delete.
7228         (iq2000_dummy_id): Delete.
7229         (iq2000_gdbarch_init): Don't register deleted functions with
7230         gdbarch.
7231
7232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7233
7234         * nds32-tdep.c (nds32_type_align): Delete.
7235         (nds32_push_dummy_call): Use type_align instead.
7236
7237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7238
7239         * arm-tdep.c (arm_type_align): Only handle vector override case.
7240         (arm_push_dummy_call): Use type_align.
7241         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7242
7243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7244
7245         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7246         case.
7247         (pass_on_stack): Use type_align.
7248         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7249         function.
7250
7251 2019-04-23  Tom Tromey  <tromey@adacore.com>
7252
7253         * dwarf2read.c (line_header::file_name_at): Remove unused
7254         overload.
7255
7256 2019-04-23  Tom de Vries  <tdevries@suse.de>
7257
7258         PR gdb/24438
7259         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7260         invocation.
7261
7262
7263 2019-03-27  Ali Tamur  <tamur@google.com>
7264
7265         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7266         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7267         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7268         (dwarf_expr_context::get_addr_index): Likewise
7269         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7270         (symbol_needs_eval_context::get_addr_index): Likewise
7271         (disassemble_dwarf_expression): Add DW_OP_addrx
7272         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7273         (read_cutu_die_from_dwo): Update comment
7274         (skip_one_die): Add DW_FORM_addrx
7275         (read_attribute_value): Likewise
7276         (var_decode_location): Add DW_OP_addrx
7277         (dwarf2_const_value_attr): Add DW_FORM_addrx
7278         (dump_die_shallow): Likewise
7279         (dwarf2_fetch_constant_bytes): Likewise
7280         (decode_locdesc): Add DW_OP_addrx
7281         (skip_form_bytes): Add DW_FORM_addrx
7282
7283 2019-04-22  Ali Tamur  <tamur@google.com>
7284
7285         * MAINTAINERS (Write After Approval): Add self.
7286
7287 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7288
7289         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7290         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7291         (open_symbol_file_object): Likewise.
7292         (svr4_default_sos): Add info parameter.
7293         (svr4_read_so_list): Likewise.
7294         (svr4_current_sos_direct): Adjust functions calls to pass down
7295         info.
7296         (svr4_current_sos_1): Add info parameter.
7297         (svr4_current_sos): Call get_svr4_info, pass info down to
7298         svr4_current_sos_1.
7299         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7300         get_svr4_info.
7301         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7302         get_svr4_info.
7303         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7304         to get_svr4_info.
7305         (probes_table_remove_objfile_probes): Likewise.
7306         (register_solib_event_probe): Add info parameter.
7307         (solist_update_incremental): Pass info parameter down to
7308         svr4_read_so_list.
7309         (disable_probes_interface): Add info parameter.
7310         (svr4_handle_solib_event): Pass current_program_space to
7311         get_svr4_info.  Adjust disable_probes_interface cleanup.
7312         (svr4_create_probe_breakpoints): Add info parameter, pass it
7313         down to register_solib_event_probe.
7314         (svr4_create_solib_event_breakpoints): Add info parameter,
7315         pass it down to svr4_create_probe_breakpoints.
7316         (enable_break): Pass info down to
7317         svr4_create_solib_event_breakpoints.
7318         (svr4_solib_create_inferior_hook): Pass current_program_space to
7319         get_svr4_info.
7320         (svr4_clear_solib): Likewise.
7321
7322 2019-04-22  Pedro Alves  <palves@redhat.com>
7323
7324         * solib-svr4.c (svr4_free_objfile_observer): New.
7325         (probe_and_action::objfile): New field.
7326         (probes_table_htab_remove_objfile_probes)
7327         (probes_table_remove_objfile_probes): New functions.
7328         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7329         in the new probe_and_action.  Don't store the probe in 'lookup'.
7330         (svr4_create_probe_breakpoints): Pass objfile to
7331         register_solib_event_probe.
7332         (_initialize_svr4_solib): Register a free_objfile observer.
7333
7334 2019-04-19  Tom Tromey  <tom@tromey.com>
7335
7336         * common/queue.h: Remove.
7337
7338 2019-04-19  Tom Tromey  <tom@tromey.com>
7339
7340         * event-loop.c: Don't include "common/queue.h".
7341
7342 2019-04-19  Tom Tromey  <tom@tromey.com>
7343
7344         * remote.c (remote_target): Use delete.
7345         * remote-notif.h: Include <list>, not "common/queue.h".
7346         (notif_client_p): Remove typedef.
7347         (remote_notif_state): Add constructor, destructor, initializer.
7348         <notif_queue>: Now a std::list.
7349         (remote_notif_state_xfree): Don't declare.
7350         * remote-notif.c (remote_notif_process, handle_notification)
7351         (remote_notif_state_allocate): Update.
7352         (~remote_notif_state): Rename from remote_notif_state_xfree.
7353
7354 2019-04-19  Tom Tromey  <tom@tromey.com>
7355
7356         * symfile.c (reread_symbols): Update.
7357         * objfiles.c (objfile_register_static_link)
7358         (objfile_lookup_static_link): Update
7359         (~objfile) Don't delete static_links.
7360         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7361
7362 2019-04-19  Tom Tromey  <tom@tromey.com>
7363
7364         * type-stack.h (struct type_stack) <insert>: Constify string.
7365         * type-stack.c (type_stack::insert): Constify string.
7366         * gdbtypes.h (lookup_template_type): Update.
7367         (address_space_name_to_int): Update.
7368         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7369         const.
7370         (lookup_template_type): Make name const.
7371         * c-exp.y: Update rules.
7372         (lex_one_token, classify_name, classify_inner_name)
7373         (c_print_token): Update.
7374         * p-exp.y: Update rules.
7375         (yylex): Update.
7376         * f-exp.y: Update rules.
7377         (yylex): Update.
7378         * d-exp.y: Update rules.
7379         (lex_one_token, classify_name, classify_inner_name): Update.
7380         * parse.c (write_dollar_variable, copy_name): Return std::string.
7381         * parser-defs.h (copy_name): Change return type.
7382         * m2-exp.y: Update rules.
7383         (yylex): Update.
7384         * go-exp.y (lex_one_token): Update.
7385         Update rules.
7386         (classify_unsafe_function, classify_packaged_name)
7387         (classify_name, yylex): Update.
7388
7389 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7390
7391         * configure.ac: add --enable-source-highlight switch.
7392         * configure: Regenerate.
7393         * top.c (print_gdb_version): plumb --enable-source-highlight
7394         status to "show configuration".
7395
7396 2019-04-19  Tom Tromey  <tromey@adacore.com>
7397
7398         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7399         Check ADA_TYPE_P.
7400         (empty_record, ada_template_to_fixed_record_type_1)
7401         (template_to_static_fixed_type)
7402         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7403         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7404         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7405         macros.
7406
7407 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7408
7409         PR symtab/24423:
7410         * source.c (print_source_lines_base): Advance "iter" when a
7411         control character is seen.
7412
7413 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7414
7415         * inferior.h (struct infcall_suspend_state_deleter):
7416         Catch exception in destructor to avoid crash.
7417
7418 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7419
7420         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7421         close to the add_com "shell".
7422
7423 2019-04-18  Tom Tromey  <tromey@adacore.com>
7424
7425         * process-stratum-target.h (class process_stratum_target)
7426         <stratum>: Add "final".
7427
7428 2019-04-17  Tom Tromey  <tromey@adacore.com>
7429
7430         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7431         against nullptr before use.
7432
7433 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7434
7435         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7436
7437 2019-04-17  Jim Wilson  <jimw@sifive.com>
7438             Andrew Burgess  <andrew.burgess@embecosm.com>
7439
7440         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7441         code read might fail, assume 4-byte breakpoint in that case.
7442
7443 2019-04-15  Leszek Swirski  <leszeks@google.com>
7444
7445         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7446         rather than a hand-rolled POD check when checking for forced MEMORY
7447         classification.
7448
7449 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7450
7451         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7452         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7453         function.
7454         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7455         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7456         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7457         declaration.
7458
7459 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7460
7461         * aarch64-linux-nat.c
7462         (aarch64_linux_nat_target::thread_architecture): Add override.
7463         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7464         each VQ.
7465
7466 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7467
7468         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7469
7470 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7471
7472         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7473         target types of size 96-bits, add some additional comments, and
7474         check that the builtin type we found was the correct size.
7475
7476 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7477
7478         * utils.c (prompt_for_continue): Don't restore the styling at the
7479         end, as applied_style has the wrong value.  This fixes styling in
7480         long lists of file names that are interrupted by the "Continue?"
7481         prompt.
7482
7483 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7484
7485         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7486         * c-lang.c (c_language_defn): Likewise.
7487         (cplus_language_defn): Likewise.
7488         (asm_language_defn): Likewise.
7489         (minimal_language_defn): Likewise.
7490         * d-lang.c (d_language_defn): Likewise.
7491         * f-lang.c (f_language_defn): Likewise.
7492         * go-lang.c (go_language_defn): Likewise.
7493         * language.c (unknown_language_defn): Likewise.
7494         (auto_language_defn): Likewise.
7495         * language.h (struct language_defn): Remove la_magic field.
7496         (LANG_MAGIC): Delete.
7497         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7498         * objc-lang.c (objc_language_defn): Likewise.
7499         * opencl-lang.c (opencl_language_defn): Likewise.
7500         * p-lang.c (pascal_language_defn): Likewise.
7501         * rust-lang.c (rust_language_defn): Likewise.
7502
7503 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7504
7505         * riscv-tdep.c (riscv_type_align): New function.
7506         (riscv_type_alignment): Delete.
7507         (riscv_arg_location): Use 'type_align'.
7508         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7509
7510 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7511
7512         * gdbtypes.c (type_align): A struct with no non-static fields also
7513         has alignment of 1.
7514
7515 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7516
7517         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7518         component to 0.
7519         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7520         member.
7521         (riscv_struct_info::analyse): New implementation using new
7522         analyse_inner member function.
7523         (riscv_struct_info::field_offset): New member function.
7524         (riscv_struct_info::m_offsets): New member variable.
7525         (riscv_struct_info::analyse_inner): New private member function,
7526         takes the old implementation of riscv_struct_info::analyse but
7527         extended to track field offsets.
7528         (riscv_call_arg_struct): Update the struct folding special cases
7529         to handle cases where empty C++ structs, which are non-zero
7530         length, are found.
7531         (riscv_arg_location): Initialise the length of each location, a
7532         non-zero length now indicates the location is in use.
7533         (riscv_push_dummy_call): Allow for the first location having a
7534         non-zero offset when setting up arguments.
7535         (riscv_return_value): Likewise, but for return values.
7536
7537 2019-04-11  Tom Tromey  <tromey@adacore.com>
7538
7539         * utils.c (internal_vproblem): Make "msg" const.
7540
7541 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7542
7543         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7544         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7545         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7546         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7547
7548 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7549
7550         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7551         function.
7552         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7553         of amd64_collect_native_gregset.
7554         (amd64_linux_nat_target::store_registers): Likewise.
7555
7556 2019-04-10  Tom Tromey  <tom@tromey.com>
7557
7558         * symtab.c (lookup_global_symbol_from_objfile)
7559         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7560         * objfiles.h (class separate_debug_iterator): New.
7561         (class separate_debug_range): New.
7562         (struct objfile) <separate_debug_objfiles>: New method.
7563         (objfile_separate_debug_iterate): Don't declare.
7564         * objfiles.c (separate_debug_iterator::operator++): Rename from
7565         objfile_separate_debug_iterate.
7566         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7567         iterator.
7568         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7569         iterator.
7570
7571 2019-04-10  Tom Tromey  <tom@tromey.com>
7572
7573         * symfile.c (reread_symbols): Remove old comment.
7574         * objfiles.c (free_all_objfiles): Fix a typo.
7575
7576 2019-04-10  Tom Tromey  <tom@tromey.com>
7577
7578         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7579         * minsyms.c (lookup_minimal_symbol): Use foreach.
7580         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7581         (lookup_minimal_symbol_solib_trampoline): Likewise.
7582         * symfile.c (reread_symbols): Use foreach.
7583
7584 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7585             Tom Tromey  <tromey@adacore.com>
7586
7587         PR rust/24414:
7588         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7589         (rust_lex_int_test): Change "value" to be LONGEST.
7590         (rust_lex_tests): Add test for long integer literal.
7591
7592 2019-04-09  Tom Tromey  <tromey@adacore.com>
7593
7594         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7595         to bool.
7596         (extended_remote_target::attach): Update.
7597         (remote_target::remote_notice_new_inferior): Update.
7598         (remote_target::add_current_inferior_and_thread): Update.
7599         * inferior.c (exit_inferior_1): Use "false".
7600         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7601
7602 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7603
7604         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7605         the "start" command.
7606
7607 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7608
7609         * python/py-inferior.c (infpy_thread_from_thread_handle):
7610         Adjust comments to reflect renaming of thread_from_thread_handle
7611         to thread_from_handle.  Adjust keywords.  Fix type error message.
7612         (inferior_object_methods): Add thread_from_handle.  Retain
7613         thread_from_thread_handle, but mark it as deprecated.
7614
7615 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7616
7617         * gdbthread.h (find_thread_by_handle): Revise declaration.
7618         * thread.c (find_thread_by_handle): Likewise.  Adjust
7619         implementation too.
7620         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7621         support for buffer objects as handles.
7622
7623 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7624
7625         * python/py-infthread.c (thpy_thread_handle): New function.
7626         (thread_object_methods): Register thpy_thread_handle.
7627
7628 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7629
7630         * gdbthread.h (thread_to_thread_handle): Declare.
7631         * thread.c (gdbtypes.h): Include.
7632         (thread_to_thread_handle): New function.
7633
7634         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7635         (target_thread_info_to_thread_handle): Declare.
7636         * target.c (target_thread_info_to_thread_handle): New function.
7637         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7638         * target-delegates.c: Regenerate.
7639
7640         * linux-thread-db.c (class thread_db_target): Add method
7641         thread_info_to_thread_handle.
7642         (thread_db_target::thread_info_to_thread_handle): Define.
7643         * remote.c (class remote_target): Add new method
7644         thread_info_to_thread_handle.
7645         (remote_target::thread_info_to_thread_handle): Define.
7646
7647 2019-04-08  Pedro Alves  <palves@redhat.com>
7648
7649         * common/common-exceptions.c (throw_exception): Don't create
7650         named object to throw; throw directly.
7651         (throw_it): Likewise.  Don't initialize gdb_exception::message
7652         here, with new; pass FMT and AP to the ctor instead.
7653         * common/common-exceptions.h: Include <string>.
7654         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7655         const char *, va_list)): New ctor.  Use std::make_shared.
7656         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7657         errors)): Delete.
7658         (gdb_exception_error::gdb_exception_error(enum errors, const char
7659         *, va_list)): New.
7660         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7661         Add assertion.
7662         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7663         errors)): Delete.
7664         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7665         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7666         Add assertion.
7667
7668 2019-04-08  Tom Tromey  <tom@tromey.com>
7669
7670         * valops.c (value_rtti_indirect_type): Replace throw_exception
7671         with throw.
7672         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7673         with throw.
7674         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7675         throw.
7676         * target.c (target_translate_tls_address): Replace throw_exception
7677         with throw.
7678         * stack.c (frame_apply_command_count): Replace throw_exception
7679         with throw.
7680         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7681         throw.
7682         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7683         with throw.
7684         * rs6000-tdep.c (rs6000_frame_cache)
7685         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7686         * remote.c: Replace throw_exception with throw.
7687         * record-full.c (record_full_message, record_full_wait_1)
7688         (record_full_restore): Replace throw_exception with throw.
7689         * record-btrace.c:
7690         (get_thread_current_frame_id, record_btrace_start_replaying)
7691         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7692         (cmd_record_btrace_start): Replace throw_exception with throw.
7693         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7694         throw.
7695         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7696         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7697         * linespec.c:
7698         (find_linespec_symbols): Replace throw_exception with throw.
7699         * infrun.c (displaced_step_prepare, resume): Replace
7700         throw_exception with throw.
7701         * infcmd.c (post_create_inferior): Replace throw_exception with
7702         throw.
7703         * inf-loop.c (inferior_event_handler): Replace throw_exception
7704         with throw.
7705         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7706         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7707         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7708         (get_prev_frame_always, get_frame_pc_if_available)
7709         (get_frame_address_in_block_if_available, get_frame_language):
7710         Replace throw_exception with throw.
7711         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7712         throw_exception with throw.
7713         * eval.c (fetch_subexp_value, evaluate_var_value)
7714         (evaluate_funcall, evaluate_subexp_standard): Replace
7715         throw_exception with throw.
7716         * dwarf2loc.c (call_site_find_chain)
7717         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7718         Replace throw_exception with throw.
7719         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7720         with throw.
7721         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7722         throw.
7723         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7724         * completer.c (complete_line_internal): Replace throw_exception
7725         with throw.
7726         * compile/compile-object-run.c (compile_object_run): Replace
7727         throw_exception with throw.
7728         * cli/cli-script.c (process_next_line): Replace throw_exception
7729         with throw.
7730         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7731         (btrace_enable, btrace_maint_update_pt_packets): Replace
7732         throw_exception with throw.
7733         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7734         throw_exception with throw.
7735         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7736         throw_exception with throw.
7737         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7738         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7739         * aarch64-tdep.c (aarch64_make_prologue_cache)
7740         (aarch64_make_stub_cache): Replace throw_exception with throw.
7741
7742 2019-04-08  Tom Tromey  <tom@tromey.com>
7743
7744         * common/common-exceptions.c (throw_exception): Rename from
7745         throw_exception_cxx.  Remove old copy.  Make argument const.
7746         (throw_it): Create and throw exception objects directly.
7747         * common/common-exceptions.h (throw_exception): Make argument
7748         const.
7749         (struct gdb_exception_error): Add constructor.
7750         (struct gdb_exception_quit): Add constructor.
7751
7752 2019-04-08  Tom Tromey  <tom@tromey.com>
7753
7754         * common/common-exceptions.h (exception_rethrow): Don't declare.
7755         (TRY_SJLJ): Update comment.
7756         (TRY, CATCH, END_CATCH): Remove.
7757         * common/common-exceptions.c (exception_rethrow): Remove.
7758
7759 2019-04-08  Tom Tromey  <tom@tromey.com>
7760
7761         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7762         Remove.
7763         (gdb_exception_error): Rename from
7764         gdb_exception_RETURN_MASK_ERROR.
7765         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7766         (gdb_quit_bad_alloc): Update.
7767         * aarch64-tdep.c: Update.
7768         * ada-lang.c: Update.
7769         * ada-typeprint.c: Update.
7770         * ada-valprint.c: Update.
7771         * amd64-tdep.c: Update.
7772         * arch-utils.c: Update.
7773         * break-catch-throw.c: Update.
7774         * breakpoint.c: Update.
7775         * btrace.c: Update.
7776         * c-varobj.c: Update.
7777         * cli/cli-cmds.c: Update.
7778         * cli/cli-interp.c: Update.
7779         * cli/cli-script.c: Update.
7780         * common/common-exceptions.c: Update.
7781         * common/new-op.c: Update.
7782         * common/selftest.c: Update.
7783         * compile/compile-c-symbols.c: Update.
7784         * compile/compile-cplus-symbols.c: Update.
7785         * compile/compile-object-load.c: Update.
7786         * compile/compile-object-run.c: Update.
7787         * completer.c: Update.
7788         * corelow.c: Update.
7789         * cp-abi.c: Update.
7790         * cp-support.c: Update.
7791         * cp-valprint.c: Update.
7792         * darwin-nat.c: Update.
7793         * disasm-selftests.c: Update.
7794         * dtrace-probe.c: Update.
7795         * dwarf-index-cache.c: Update.
7796         * dwarf-index-write.c: Update.
7797         * dwarf2-frame-tailcall.c: Update.
7798         * dwarf2-frame.c: Update.
7799         * dwarf2loc.c: Update.
7800         * dwarf2read.c: Update.
7801         * eval.c: Update.
7802         * event-loop.c: Update.
7803         * event-top.c: Update.
7804         * exec.c: Update.
7805         * f-valprint.c: Update.
7806         * fbsd-tdep.c: Update.
7807         * frame-unwind.c: Update.
7808         * frame.c: Update.
7809         * gdbtypes.c: Update.
7810         * gnu-v3-abi.c: Update.
7811         * guile/guile-internal.h: Update.
7812         * guile/scm-block.c: Update.
7813         * guile/scm-breakpoint.c: Update.
7814         * guile/scm-cmd.c: Update.
7815         * guile/scm-disasm.c: Update.
7816         * guile/scm-frame.c: Update.
7817         * guile/scm-lazy-string.c: Update.
7818         * guile/scm-math.c: Update.
7819         * guile/scm-param.c: Update.
7820         * guile/scm-ports.c: Update.
7821         * guile/scm-pretty-print.c: Update.
7822         * guile/scm-symbol.c: Update.
7823         * guile/scm-symtab.c: Update.
7824         * guile/scm-type.c: Update.
7825         * guile/scm-value.c: Update.
7826         * i386-linux-tdep.c: Update.
7827         * i386-tdep.c: Update.
7828         * inf-loop.c: Update.
7829         * infcall.c: Update.
7830         * infcmd.c: Update.
7831         * infrun.c: Update.
7832         * jit.c: Update.
7833         * language.c: Update.
7834         * linespec.c: Update.
7835         * linux-fork.c: Update.
7836         * linux-nat.c: Update.
7837         * linux-tdep.c: Update.
7838         * linux-thread-db.c: Update.
7839         * main.c: Update.
7840         * mi/mi-cmd-break.c: Update.
7841         * mi/mi-cmd-stack.c: Update.
7842         * mi/mi-interp.c: Update.
7843         * mi/mi-main.c: Update.
7844         * objc-lang.c: Update.
7845         * p-valprint.c: Update.
7846         * parse.c: Update.
7847         * ppc-linux-tdep.c: Update.
7848         * printcmd.c: Update.
7849         * python/py-arch.c: Update.
7850         * python/py-breakpoint.c: Update.
7851         * python/py-cmd.c: Update.
7852         * python/py-finishbreakpoint.c: Update.
7853         * python/py-frame.c: Update.
7854         * python/py-framefilter.c: Update.
7855         * python/py-gdb-readline.c: Update.
7856         * python/py-inferior.c: Update.
7857         * python/py-infthread.c: Update.
7858         * python/py-lazy-string.c: Update.
7859         * python/py-linetable.c: Update.
7860         * python/py-objfile.c: Update.
7861         * python/py-param.c: Update.
7862         * python/py-prettyprint.c: Update.
7863         * python/py-progspace.c: Update.
7864         * python/py-record-btrace.c: Update.
7865         * python/py-record.c: Update.
7866         * python/py-symbol.c: Update.
7867         * python/py-type.c: Update.
7868         * python/py-unwind.c: Update.
7869         * python/py-utils.c: Update.
7870         * python/py-value.c: Update.
7871         * python/python.c: Update.
7872         * record-btrace.c: Update.
7873         * record-full.c: Update.
7874         * remote-fileio.c: Update.
7875         * remote.c: Update.
7876         * riscv-tdep.c: Update.
7877         * rs6000-aix-tdep.c: Update.
7878         * rs6000-tdep.c: Update.
7879         * rust-exp.y: Update.
7880         * rust-lang.c: Update.
7881         * s390-tdep.c: Update.
7882         * selftest-arch.c: Update.
7883         * solib-dsbt.c: Update.
7884         * solib-frv.c: Update.
7885         * solib-spu.c: Update.
7886         * solib-svr4.c: Update.
7887         * solib.c: Update.
7888         * sparc64-linux-tdep.c: Update.
7889         * stack.c: Update.
7890         * symfile-mem.c: Update.
7891         * symmisc.c: Update.
7892         * target.c: Update.
7893         * thread.c: Update.
7894         * top.c: Update.
7895         * tracefile-tfile.c: Update.
7896         * tui/tui.c: Update.
7897         * typeprint.c: Update.
7898         * unittests/cli-utils-selftests.c: Update.
7899         * unittests/parse-connection-spec-selftests.c: Update.
7900         * valops.c: Update.
7901         * valprint.c: Update.
7902         * value.c: Update.
7903         * varobj.c: Update.
7904         * windows-nat.c: Update.
7905         * x86-linux-nat.c: Update.
7906         * xml-support.c: Update.
7907
7908 2019-04-08  Tom Tromey  <tom@tromey.com>
7909
7910         * xml-support.c: Use C++ exception handling.
7911         * x86-linux-nat.c: Use C++ exception handling.
7912         * windows-nat.c: Use C++ exception handling.
7913         * varobj.c: Use C++ exception handling.
7914         * value.c: Use C++ exception handling.
7915         * valprint.c: Use C++ exception handling.
7916         * valops.c: Use C++ exception handling.
7917         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7918         handling.
7919         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7920         * typeprint.c: Use C++ exception handling.
7921         * tui/tui.c: Use C++ exception handling.
7922         * tracefile-tfile.c: Use C++ exception handling.
7923         * top.c: Use C++ exception handling.
7924         * thread.c: Use C++ exception handling.
7925         * target.c: Use C++ exception handling.
7926         * symmisc.c: Use C++ exception handling.
7927         * symfile-mem.c: Use C++ exception handling.
7928         * stack.c: Use C++ exception handling.
7929         * sparc64-linux-tdep.c: Use C++ exception handling.
7930         * solib.c: Use C++ exception handling.
7931         * solib-svr4.c: Use C++ exception handling.
7932         * solib-spu.c: Use C++ exception handling.
7933         * solib-frv.c: Use C++ exception handling.
7934         * solib-dsbt.c: Use C++ exception handling.
7935         * selftest-arch.c: Use C++ exception handling.
7936         * s390-tdep.c: Use C++ exception handling.
7937         * rust-lang.c: Use C++ exception handling.
7938         * rust-exp.y: Use C++ exception handling.
7939         * rs6000-tdep.c: Use C++ exception handling.
7940         * rs6000-aix-tdep.c: Use C++ exception handling.
7941         * riscv-tdep.c: Use C++ exception handling.
7942         * remote.c: Use C++ exception handling.
7943         * remote-fileio.c: Use C++ exception handling.
7944         * record-full.c: Use C++ exception handling.
7945         * record-btrace.c: Use C++ exception handling.
7946         * python/python.c: Use C++ exception handling.
7947         * python/py-value.c: Use C++ exception handling.
7948         * python/py-utils.c: Use C++ exception handling.
7949         * python/py-unwind.c: Use C++ exception handling.
7950         * python/py-type.c: Use C++ exception handling.
7951         * python/py-symbol.c: Use C++ exception handling.
7952         * python/py-record.c: Use C++ exception handling.
7953         * python/py-record-btrace.c: Use C++ exception handling.
7954         * python/py-progspace.c: Use C++ exception handling.
7955         * python/py-prettyprint.c: Use C++ exception handling.
7956         * python/py-param.c: Use C++ exception handling.
7957         * python/py-objfile.c: Use C++ exception handling.
7958         * python/py-linetable.c: Use C++ exception handling.
7959         * python/py-lazy-string.c: Use C++ exception handling.
7960         * python/py-infthread.c: Use C++ exception handling.
7961         * python/py-inferior.c: Use C++ exception handling.
7962         * python/py-gdb-readline.c: Use C++ exception handling.
7963         * python/py-framefilter.c: Use C++ exception handling.
7964         * python/py-frame.c: Use C++ exception handling.
7965         * python/py-finishbreakpoint.c: Use C++ exception handling.
7966         * python/py-cmd.c: Use C++ exception handling.
7967         * python/py-breakpoint.c: Use C++ exception handling.
7968         * python/py-arch.c: Use C++ exception handling.
7969         * printcmd.c: Use C++ exception handling.
7970         * ppc-linux-tdep.c: Use C++ exception handling.
7971         * parse.c: Use C++ exception handling.
7972         * p-valprint.c: Use C++ exception handling.
7973         * objc-lang.c: Use C++ exception handling.
7974         * mi/mi-main.c: Use C++ exception handling.
7975         * mi/mi-interp.c: Use C++ exception handling.
7976         * mi/mi-cmd-stack.c: Use C++ exception handling.
7977         * mi/mi-cmd-break.c: Use C++ exception handling.
7978         * main.c: Use C++ exception handling.
7979         * linux-thread-db.c: Use C++ exception handling.
7980         * linux-tdep.c: Use C++ exception handling.
7981         * linux-nat.c: Use C++ exception handling.
7982         * linux-fork.c: Use C++ exception handling.
7983         * linespec.c: Use C++ exception handling.
7984         * language.c: Use C++ exception handling.
7985         * jit.c: Use C++ exception handling.
7986         * infrun.c: Use C++ exception handling.
7987         * infcmd.c: Use C++ exception handling.
7988         * infcall.c: Use C++ exception handling.
7989         * inf-loop.c: Use C++ exception handling.
7990         * i386-tdep.c: Use C++ exception handling.
7991         * i386-linux-tdep.c: Use C++ exception handling.
7992         * guile/scm-value.c: Use C++ exception handling.
7993         * guile/scm-type.c: Use C++ exception handling.
7994         * guile/scm-symtab.c: Use C++ exception handling.
7995         * guile/scm-symbol.c: Use C++ exception handling.
7996         * guile/scm-pretty-print.c: Use C++ exception handling.
7997         * guile/scm-ports.c: Use C++ exception handling.
7998         * guile/scm-param.c: Use C++ exception handling.
7999         * guile/scm-math.c: Use C++ exception handling.
8000         * guile/scm-lazy-string.c: Use C++ exception handling.
8001         * guile/scm-frame.c: Use C++ exception handling.
8002         * guile/scm-disasm.c: Use C++ exception handling.
8003         * guile/scm-cmd.c: Use C++ exception handling.
8004         * guile/scm-breakpoint.c: Use C++ exception handling.
8005         * guile/scm-block.c: Use C++ exception handling.
8006         * guile/guile-internal.h: Use C++ exception handling.
8007         * gnu-v3-abi.c: Use C++ exception handling.
8008         * gdbtypes.c: Use C++ exception handling.
8009         * frame.c: Use C++ exception handling.
8010         * frame-unwind.c: Use C++ exception handling.
8011         * fbsd-tdep.c: Use C++ exception handling.
8012         * f-valprint.c: Use C++ exception handling.
8013         * exec.c: Use C++ exception handling.
8014         * event-top.c: Use C++ exception handling.
8015         * event-loop.c: Use C++ exception handling.
8016         * eval.c: Use C++ exception handling.
8017         * dwarf2read.c: Use C++ exception handling.
8018         * dwarf2loc.c: Use C++ exception handling.
8019         * dwarf2-frame.c: Use C++ exception handling.
8020         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8021         * dwarf-index-write.c: Use C++ exception handling.
8022         * dwarf-index-cache.c: Use C++ exception handling.
8023         * dtrace-probe.c: Use C++ exception handling.
8024         * disasm-selftests.c: Use C++ exception handling.
8025         * darwin-nat.c: Use C++ exception handling.
8026         * cp-valprint.c: Use C++ exception handling.
8027         * cp-support.c: Use C++ exception handling.
8028         * cp-abi.c: Use C++ exception handling.
8029         * corelow.c: Use C++ exception handling.
8030         * completer.c: Use C++ exception handling.
8031         * compile/compile-object-run.c: Use C++ exception handling.
8032         * compile/compile-object-load.c: Use C++ exception handling.
8033         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8034         * compile/compile-c-symbols.c: Use C++ exception handling.
8035         * common/selftest.c: Use C++ exception handling.
8036         * common/new-op.c: Use C++ exception handling.
8037         * cli/cli-script.c: Use C++ exception handling.
8038         * cli/cli-interp.c: Use C++ exception handling.
8039         * cli/cli-cmds.c: Use C++ exception handling.
8040         * c-varobj.c: Use C++ exception handling.
8041         * btrace.c: Use C++ exception handling.
8042         * breakpoint.c: Use C++ exception handling.
8043         * break-catch-throw.c: Use C++ exception handling.
8044         * arch-utils.c: Use C++ exception handling.
8045         * amd64-tdep.c: Use C++ exception handling.
8046         * ada-valprint.c: Use C++ exception handling.
8047         * ada-typeprint.c: Use C++ exception handling.
8048         * ada-lang.c: Use C++ exception handling.
8049         * aarch64-tdep.c: Use C++ exception handling.
8050
8051 2019-04-08  Tom Tromey  <tom@tromey.com>
8052
8053         * xml-support.c (gdb_xml_parser::parse): Update.
8054         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8055         * value.c (show_convenience): Update.
8056         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8057         (test_parse_flags_qcs): Update.
8058         * thread.c (thr_try_catch_cmd): Update.
8059         * target.c (target_translate_tls_address): Update.
8060         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8061         (info_frame_command_core, frame_apply_command_count): Update.
8062         * rust-exp.y (rust_lex_exception_test): Update.
8063         * riscv-tdep.c (riscv_print_one_register_info): Update.
8064         * remote.c (remote_target::enable_btrace): Update.
8065         * record-btrace.c (record_btrace_enable_warn): Update.
8066         * python/py-utils.c (gdbpy_convert_exception): Update.
8067         * printcmd.c (do_one_display, print_variable_and_value): Update.
8068         * mi/mi-main.c (mi_print_exception): Update.
8069         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8070         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8071         * linux-nat.c (linux_nat_target::attach): Update.
8072         * linux-fork.c (class scoped_switch_fork_info): Update.
8073         * infrun.c (displaced_step_prepare): Update.
8074         * infcall.c (call_function_by_hand_dummy): Update.
8075         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8076         * gnu-v3-abi.c (print_one_vtable): Update.
8077         * frame.c (get_prev_frame_always): Update.
8078         * f-valprint.c (info_common_command_for_block): Update.
8079         * exec.c (try_open_exec_file): Update.
8080         * exceptions.c (print_exception, exception_print)
8081         (exception_fprintf, exception_print_same): Update.
8082         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8083         * dwarf-index-cache.c (index_cache::store)
8084         (index_cache::lookup_gdb_index): Update.
8085         * darwin-nat.c (maybe_cache_shell): Update.
8086         * cp-valprint.c (cp_print_value_fields): Update.
8087         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8088         (gcc_cplus_symbol_address): Update.
8089         * compile/compile-c-symbols.c (gcc_convert_symbol)
8090         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8091         * common/selftest.c: Update.
8092         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8093         a std::string.
8094         (exception_try_scope_entry, exception_try_scope_exit): Don't
8095         declare.
8096         (struct exception_try_scope): Remove.
8097         (TRY): Don't use exception_try_scope.
8098         (struct gdb_exception): Add constructor, operator=.
8099         <what>: New method.
8100         (struct gdb_exception_RETURN_MASK_ALL)
8101         (struct gdb_exception_RETURN_MASK_ERROR)
8102         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8103         (struct gdb_quit_bad_alloc): Update.
8104         * common/common-exceptions.c (exception_none): Change
8105         initializer.
8106         (struct catcher) <state, exception>: Initialize inline.
8107         <prev>: Remove member.
8108         (current_catcher): Remove.
8109         (catchers): New global.
8110         (exceptions_state_mc_init): Simplify.
8111         (catcher_pop): Remove.
8112         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8113         (try_scope_depth, exception_try_scope_entry)
8114         (exception_try_scope_exit): Remove.
8115         (throw_exception_sjlj): Update.
8116         (exception_messages, exception_messages_size): Remove.
8117         (throw_it): Simplify.
8118         (gdb_exception_sliced_copy): Remove.
8119         (throw_exception_cxx): Update.
8120         * cli/cli-script.c (script_from_file): Update.
8121         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8122         Update.
8123         * ada-valprint.c (ada_val_print): Update.
8124         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8125         (create_excep_cond_exprs): Update.
8126
8127 2019-04-08  Tom Tromey  <tom@tromey.com>
8128
8129         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8130         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8131         (TRY, CATCH, END_CATCH): Remove some definitions.
8132         * common/common-exceptions.c: Don't use GDB_XCPT.
8133         (catcher_list_size): Remove.
8134         (throw_exception, throw_it): Simplify.
8135
8136 2019-04-05  Tom Tromey  <tom@tromey.com>
8137
8138         Revert the header-sorting patch.
8139         * ft32-tdep.c: Revert.
8140         * frv-tdep.c: Revert.
8141         * frv-linux-tdep.c: Revert.
8142         * frame.c: Revert.
8143         * frame-unwind.c: Revert.
8144         * frame-base.c: Revert.
8145         * fork-child.c: Revert.
8146         * findvar.c: Revert.
8147         * findcmd.c: Revert.
8148         * filesystem.c: Revert.
8149         * filename-seen-cache.h: Revert.
8150         * filename-seen-cache.c: Revert.
8151         * fbsd-tdep.c: Revert.
8152         * fbsd-nat.h: Revert.
8153         * fbsd-nat.c: Revert.
8154         * f-valprint.c: Revert.
8155         * f-typeprint.c: Revert.
8156         * f-lang.c: Revert.
8157         * extension.h: Revert.
8158         * extension.c: Revert.
8159         * extension-priv.h: Revert.
8160         * expprint.c: Revert.
8161         * exec.h: Revert.
8162         * exec.c: Revert.
8163         * exceptions.c: Revert.
8164         * event-top.c: Revert.
8165         * event-loop.c: Revert.
8166         * eval.c: Revert.
8167         * elfread.c: Revert.
8168         * dwarf2read.h: Revert.
8169         * dwarf2read.c: Revert.
8170         * dwarf2loc.c: Revert.
8171         * dwarf2expr.h: Revert.
8172         * dwarf2expr.c: Revert.
8173         * dwarf2-frame.c: Revert.
8174         * dwarf2-frame-tailcall.c: Revert.
8175         * dwarf-index-write.h: Revert.
8176         * dwarf-index-write.c: Revert.
8177         * dwarf-index-common.c: Revert.
8178         * dwarf-index-cache.h: Revert.
8179         * dwarf-index-cache.c: Revert.
8180         * dummy-frame.c: Revert.
8181         * dtrace-probe.c: Revert.
8182         * disasm.h: Revert.
8183         * disasm.c: Revert.
8184         * disasm-selftests.c: Revert.
8185         * dictionary.c: Revert.
8186         * dicos-tdep.c: Revert.
8187         * demangle.c: Revert.
8188         * dcache.h: Revert.
8189         * dcache.c: Revert.
8190         * darwin-nat.h: Revert.
8191         * darwin-nat.c: Revert.
8192         * darwin-nat-info.c: Revert.
8193         * d-valprint.c: Revert.
8194         * d-namespace.c: Revert.
8195         * d-lang.c: Revert.
8196         * ctf.c: Revert.
8197         * csky-tdep.c: Revert.
8198         * csky-linux-tdep.c: Revert.
8199         * cris-tdep.c: Revert.
8200         * cris-linux-tdep.c: Revert.
8201         * cp-valprint.c: Revert.
8202         * cp-support.c: Revert.
8203         * cp-namespace.c: Revert.
8204         * cp-abi.c: Revert.
8205         * corelow.c: Revert.
8206         * corefile.c: Revert.
8207         * continuations.c: Revert.
8208         * completer.h: Revert.
8209         * completer.c: Revert.
8210         * complaints.c: Revert.
8211         * coffread.c: Revert.
8212         * coff-pe-read.c: Revert.
8213         * cli-out.h: Revert.
8214         * cli-out.c: Revert.
8215         * charset.c: Revert.
8216         * c-varobj.c: Revert.
8217         * c-valprint.c: Revert.
8218         * c-typeprint.c: Revert.
8219         * c-lang.c: Revert.
8220         * buildsym.c: Revert.
8221         * buildsym-legacy.c: Revert.
8222         * build-id.h: Revert.
8223         * build-id.c: Revert.
8224         * btrace.c: Revert.
8225         * bsd-uthread.c: Revert.
8226         * breakpoint.h: Revert.
8227         * breakpoint.c: Revert.
8228         * break-catch-throw.c: Revert.
8229         * break-catch-syscall.c: Revert.
8230         * break-catch-sig.c: Revert.
8231         * blockframe.c: Revert.
8232         * block.c: Revert.
8233         * bfin-tdep.c: Revert.
8234         * bfin-linux-tdep.c: Revert.
8235         * bfd-target.c: Revert.
8236         * bcache.c: Revert.
8237         * ax-general.c: Revert.
8238         * ax-gdb.h: Revert.
8239         * ax-gdb.c: Revert.
8240         * avr-tdep.c: Revert.
8241         * auxv.c: Revert.
8242         * auto-load.c: Revert.
8243         * arm-wince-tdep.c: Revert.
8244         * arm-tdep.c: Revert.
8245         * arm-symbian-tdep.c: Revert.
8246         * arm-pikeos-tdep.c: Revert.
8247         * arm-obsd-tdep.c: Revert.
8248         * arm-nbsd-tdep.c: Revert.
8249         * arm-nbsd-nat.c: Revert.
8250         * arm-linux-tdep.c: Revert.
8251         * arm-linux-nat.c: Revert.
8252         * arm-fbsd-tdep.c: Revert.
8253         * arm-fbsd-nat.c: Revert.
8254         * arm-bsd-tdep.c: Revert.
8255         * arch-utils.c: Revert.
8256         * arc-tdep.c: Revert.
8257         * arc-newlib-tdep.c: Revert.
8258         * annotate.h: Revert.
8259         * annotate.c: Revert.
8260         * amd64-windows-tdep.c: Revert.
8261         * amd64-windows-nat.c: Revert.
8262         * amd64-tdep.c: Revert.
8263         * amd64-sol2-tdep.c: Revert.
8264         * amd64-obsd-tdep.c: Revert.
8265         * amd64-obsd-nat.c: Revert.
8266         * amd64-nbsd-tdep.c: Revert.
8267         * amd64-nbsd-nat.c: Revert.
8268         * amd64-nat.c: Revert.
8269         * amd64-linux-tdep.c: Revert.
8270         * amd64-linux-nat.c: Revert.
8271         * amd64-fbsd-tdep.c: Revert.
8272         * amd64-fbsd-nat.c: Revert.
8273         * amd64-dicos-tdep.c: Revert.
8274         * amd64-darwin-tdep.c: Revert.
8275         * amd64-bsd-nat.c: Revert.
8276         * alpha-tdep.c: Revert.
8277         * alpha-obsd-tdep.c: Revert.
8278         * alpha-nbsd-tdep.c: Revert.
8279         * alpha-mdebug-tdep.c: Revert.
8280         * alpha-linux-tdep.c: Revert.
8281         * alpha-linux-nat.c: Revert.
8282         * alpha-bsd-tdep.c: Revert.
8283         * alpha-bsd-nat.c: Revert.
8284         * aix-thread.c: Revert.
8285         * agent.c: Revert.
8286         * addrmap.c: Revert.
8287         * ada-varobj.c: Revert.
8288         * ada-valprint.c: Revert.
8289         * ada-typeprint.c: Revert.
8290         * ada-tasks.c: Revert.
8291         * ada-lang.c: Revert.
8292         * aarch64-tdep.c: Revert.
8293         * aarch64-ravenscar-thread.c: Revert.
8294         * aarch64-newlib-tdep.c: Revert.
8295         * aarch64-linux-tdep.c: Revert.
8296         * aarch64-linux-nat.c: Revert.
8297         * aarch64-fbsd-tdep.c: Revert.
8298         * aarch64-fbsd-nat.c: Revert.
8299         * aarch32-linux-nat.c: Revert.
8300
8301 2019-04-05  Tom Tromey  <tom@tromey.com>
8302
8303         * ft32-tdep.c: Sort headers.
8304         * frv-tdep.c: Sort headers.
8305         * frv-linux-tdep.c: Sort headers.
8306         * frame.c: Sort headers.
8307         * frame-unwind.c: Sort headers.
8308         * frame-base.c: Sort headers.
8309         * fork-child.c: Sort headers.
8310         * findvar.c: Sort headers.
8311         * findcmd.c: Sort headers.
8312         * filesystem.c: Sort headers.
8313         * filename-seen-cache.h: Sort headers.
8314         * filename-seen-cache.c: Sort headers.
8315         * fbsd-tdep.c: Sort headers.
8316         * fbsd-nat.h: Sort headers.
8317         * fbsd-nat.c: Sort headers.
8318         * f-valprint.c: Sort headers.
8319         * f-typeprint.c: Sort headers.
8320         * f-lang.c: Sort headers.
8321         * extension.h: Sort headers.
8322         * extension.c: Sort headers.
8323         * extension-priv.h: Sort headers.
8324         * expprint.c: Sort headers.
8325         * exec.h: Sort headers.
8326         * exec.c: Sort headers.
8327         * exceptions.c: Sort headers.
8328         * event-top.c: Sort headers.
8329         * event-loop.c: Sort headers.
8330         * eval.c: Sort headers.
8331         * elfread.c: Sort headers.
8332         * dwarf2read.h: Sort headers.
8333         * dwarf2read.c: Sort headers.
8334         * dwarf2loc.c: Sort headers.
8335         * dwarf2expr.h: Sort headers.
8336         * dwarf2expr.c: Sort headers.
8337         * dwarf2-frame.c: Sort headers.
8338         * dwarf2-frame-tailcall.c: Sort headers.
8339         * dwarf-index-write.h: Sort headers.
8340         * dwarf-index-write.c: Sort headers.
8341         * dwarf-index-common.c: Sort headers.
8342         * dwarf-index-cache.h: Sort headers.
8343         * dwarf-index-cache.c: Sort headers.
8344         * dummy-frame.c: Sort headers.
8345         * dtrace-probe.c: Sort headers.
8346         * disasm.h: Sort headers.
8347         * disasm.c: Sort headers.
8348         * disasm-selftests.c: Sort headers.
8349         * dictionary.c: Sort headers.
8350         * dicos-tdep.c: Sort headers.
8351         * demangle.c: Sort headers.
8352         * dcache.h: Sort headers.
8353         * dcache.c: Sort headers.
8354         * darwin-nat.h: Sort headers.
8355         * darwin-nat.c: Sort headers.
8356         * darwin-nat-info.c: Sort headers.
8357         * d-valprint.c: Sort headers.
8358         * d-namespace.c: Sort headers.
8359         * d-lang.c: Sort headers.
8360         * ctf.c: Sort headers.
8361         * csky-tdep.c: Sort headers.
8362         * csky-linux-tdep.c: Sort headers.
8363         * cris-tdep.c: Sort headers.
8364         * cris-linux-tdep.c: Sort headers.
8365         * cp-valprint.c: Sort headers.
8366         * cp-support.c: Sort headers.
8367         * cp-namespace.c: Sort headers.
8368         * cp-abi.c: Sort headers.
8369         * corelow.c: Sort headers.
8370         * corefile.c: Sort headers.
8371         * continuations.c: Sort headers.
8372         * completer.h: Sort headers.
8373         * completer.c: Sort headers.
8374         * complaints.c: Sort headers.
8375         * coffread.c: Sort headers.
8376         * coff-pe-read.c: Sort headers.
8377         * cli-out.h: Sort headers.
8378         * cli-out.c: Sort headers.
8379         * charset.c: Sort headers.
8380         * c-varobj.c: Sort headers.
8381         * c-valprint.c: Sort headers.
8382         * c-typeprint.c: Sort headers.
8383         * c-lang.c: Sort headers.
8384         * buildsym.c: Sort headers.
8385         * buildsym-legacy.c: Sort headers.
8386         * build-id.h: Sort headers.
8387         * build-id.c: Sort headers.
8388         * btrace.c: Sort headers.
8389         * bsd-uthread.c: Sort headers.
8390         * breakpoint.h: Sort headers.
8391         * breakpoint.c: Sort headers.
8392         * break-catch-throw.c: Sort headers.
8393         * break-catch-syscall.c: Sort headers.
8394         * break-catch-sig.c: Sort headers.
8395         * blockframe.c: Sort headers.
8396         * block.c: Sort headers.
8397         * bfin-tdep.c: Sort headers.
8398         * bfin-linux-tdep.c: Sort headers.
8399         * bfd-target.c: Sort headers.
8400         * bcache.c: Sort headers.
8401         * ax-general.c: Sort headers.
8402         * ax-gdb.h: Sort headers.
8403         * ax-gdb.c: Sort headers.
8404         * avr-tdep.c: Sort headers.
8405         * auxv.c: Sort headers.
8406         * auto-load.c: Sort headers.
8407         * arm-wince-tdep.c: Sort headers.
8408         * arm-tdep.c: Sort headers.
8409         * arm-symbian-tdep.c: Sort headers.
8410         * arm-pikeos-tdep.c: Sort headers.
8411         * arm-obsd-tdep.c: Sort headers.
8412         * arm-nbsd-tdep.c: Sort headers.
8413         * arm-nbsd-nat.c: Sort headers.
8414         * arm-linux-tdep.c: Sort headers.
8415         * arm-linux-nat.c: Sort headers.
8416         * arm-fbsd-tdep.c: Sort headers.
8417         * arm-fbsd-nat.c: Sort headers.
8418         * arm-bsd-tdep.c: Sort headers.
8419         * arch-utils.c: Sort headers.
8420         * arc-tdep.c: Sort headers.
8421         * arc-newlib-tdep.c: Sort headers.
8422         * annotate.h: Sort headers.
8423         * annotate.c: Sort headers.
8424         * amd64-windows-tdep.c: Sort headers.
8425         * amd64-windows-nat.c: Sort headers.
8426         * amd64-tdep.c: Sort headers.
8427         * amd64-sol2-tdep.c: Sort headers.
8428         * amd64-obsd-tdep.c: Sort headers.
8429         * amd64-obsd-nat.c: Sort headers.
8430         * amd64-nbsd-tdep.c: Sort headers.
8431         * amd64-nbsd-nat.c: Sort headers.
8432         * amd64-nat.c: Sort headers.
8433         * amd64-linux-tdep.c: Sort headers.
8434         * amd64-linux-nat.c: Sort headers.
8435         * amd64-fbsd-tdep.c: Sort headers.
8436         * amd64-fbsd-nat.c: Sort headers.
8437         * amd64-dicos-tdep.c: Sort headers.
8438         * amd64-darwin-tdep.c: Sort headers.
8439         * amd64-bsd-nat.c: Sort headers.
8440         * alpha-tdep.c: Sort headers.
8441         * alpha-obsd-tdep.c: Sort headers.
8442         * alpha-nbsd-tdep.c: Sort headers.
8443         * alpha-mdebug-tdep.c: Sort headers.
8444         * alpha-linux-tdep.c: Sort headers.
8445         * alpha-linux-nat.c: Sort headers.
8446         * alpha-bsd-tdep.c: Sort headers.
8447         * alpha-bsd-nat.c: Sort headers.
8448         * aix-thread.c: Sort headers.
8449         * agent.c: Sort headers.
8450         * addrmap.c: Sort headers.
8451         * ada-varobj.c: Sort headers.
8452         * ada-valprint.c: Sort headers.
8453         * ada-typeprint.c: Sort headers.
8454         * ada-tasks.c: Sort headers.
8455         * ada-lang.c: Sort headers.
8456         * aarch64-tdep.c: Sort headers.
8457         * aarch64-ravenscar-thread.c: Sort headers.
8458         * aarch64-newlib-tdep.c: Sort headers.
8459         * aarch64-linux-tdep.c: Sort headers.
8460         * aarch64-linux-nat.c: Sort headers.
8461         * aarch64-fbsd-tdep.c: Sort headers.
8462         * aarch64-fbsd-nat.c: Sort headers.
8463         * aarch32-linux-nat.c: Sort headers.
8464
8465 2019-04-04  Tom Tromey  <tom@tromey.com>
8466
8467         * varobj.c (varobj_create): Update.
8468         * rust-exp.y (struct rust_parser) <update_innermost_block,
8469         lookup_symbol>: New methods.
8470         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8471         Rename.
8472         (rust_parser::rust_lookup_type)
8473         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8474         * printcmd.c (display_command, do_one_display): Update.
8475         * parser-defs.h (struct parser_state) <parser_state>: Add
8476         "tracker" parameter.
8477         (block_tracker): New member.
8478         (class innermost_block_tracker) <innermost_block_tracker>: Add
8479         "types" parameter.
8480         <reset>: Remove method.
8481         (innermost_block): Don't declare.
8482         (null_post_parser): Update.
8483         * parse.c (innermost_block): Remove global.
8484         (write_dollar_variable): Update.
8485         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8486         Remove "tracker_types" parameter.
8487         (parse_expression): Add "tracker" parameter.
8488         (parse_expression_for_completion): Update.
8489         (null_post_parser): Add "tracker" parameter.
8490         * p-exp.y: Update rules.
8491         * m2-exp.y: Update rules.
8492         * language.h (struct language_defn) <la_post_parser>: Add
8493         "tracker" parameter.
8494         * go-exp.y: Update rules.
8495         * f-exp.y: Update rules.
8496         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8497         parameter.
8498         * d-exp.y: Update rules.
8499         * c-exp.y: Update rules.
8500         * breakpoint.c (set_breakpoint_condition): Create an
8501         innermost_block_tracker.
8502         (watch_command_1): Likewise.
8503         * ada-lang.c (resolve): Add "tracker" parameter.
8504         (resolve_subexp): Likewise.
8505         * ada-exp.y (write_var_from_sym): Update.
8506
8507 2019-04-04  Tom Tromey  <tom@tromey.com>
8508
8509         * type-stack.h: New file.
8510         * type-stack.c: New file.
8511         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8512         type-stack.h.
8513         (insert_into_type_stack, insert_type, push_type, push_type_int)
8514         (insert_type_address_space, pop_type, pop_type_int)
8515         (pop_typelist, pop_type_stack, append_type_stack)
8516         (push_type_stack, get_type_stack, push_typelist)
8517         (follow_type_instance_flags, follow_types): Don't declare.
8518         * parse.c (type_stack): Remove global.
8519         (parse_exp_in_context): Update.
8520         (insert_into_type_stack, insert_type, push_type, push_type_int)
8521         (insert_type_address_space, pop_type, pop_type_int)
8522         (pop_typelist, pop_type_stack, append_type_stack)
8523         (push_type_stack, get_type_stack, push_typelist)
8524         (follow_type_instance_flags, follow_types): Remove (moved to
8525         type-stack.c).
8526         * f-exp.y (type_stack): New global.
8527         Update rules.
8528         (push_kind_type, f_parse): Update.
8529         * d-exp.y (type_stack): New global.
8530         Update rules.
8531         (d_parse): Update.
8532         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8533         Update rules.
8534         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8535         (HFILES_NO_SRCDIR): Add type-stack.h.
8536
8537 2019-04-04  Tom Tromey  <tom@tromey.com>
8538
8539         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8540         (rust_parser::convert_ast_to_expression, rust_parse)
8541         (rust_lex_test_completion, rust_lex_tests): Update.
8542         * parser-defs.h (struct expr_completion_state): New.
8543         (struct parser_state) <parser_state>: Add completion parameter.
8544         <mark_struct_expression, mark_completion_tag>: New methods.
8545         <parse_completion, m_completion_state>: New members.
8546         (prefixify_expression, null_post_parser): Update.
8547         (mark_struct_expression, mark_completion_tag): Don't declare.
8548         * parse.c (parse_completion, expout_last_struct)
8549         (expout_tag_completion_type, expout_completion_name): Remove
8550         globals.
8551         (parser_state::mark_struct_expression)
8552         (parser_state::mark_completion_tag): Now methods.
8553         (prefixify_expression): Add last_struct parameter.
8554         (prefixify_subexp): Likewise.
8555         (parse_exp_1): Update.
8556         (parse_exp_in_context): Add cstate parameter.  Update.
8557         (parse_expression_for_completion): Create an
8558         expr_completion_state.
8559         (null_post_parser): Add "completion" parameter.
8560         * p-exp.y: Update rules.
8561         (yylex): Update.
8562         * language.h (struct language_defn) <la_post_parser>: Add
8563         "completing" parameter.
8564         * go-exp.y: Update rules.
8565         (lex_one_token): Update.
8566         * expression.h (parse_completion): Don't declare.
8567         * d-exp.y: Update rules.
8568         (lex_one_token): Update rules.
8569         * c-exp.y: Update rules.
8570         (lex_one_token): Update.
8571         * ada-lang.c (resolve): Add "parse_completion" parameter.
8572         (resolve_subexp): Likewise.
8573         (ada_resolve_function): Likewise.
8574
8575 2019-04-04  Tom Tromey  <tom@tromey.com>
8576
8577         * parser-defs.h (struct parser_state) <start_arglist,
8578         end_arglist>: New methods.
8579         <arglist_len, m_funcall_chain>: New members.
8580         (arglist_len, start_arglist, end_arglist): Don't declare.
8581         * parse.c (arglist_len, funcall_chain): Remove global.
8582         (start_arglist, end_arglist): Remove functions.
8583         (parse_exp_in_context): Update.
8584         * p-exp.y: Update rules.
8585         * m2-exp.y: Update rules.
8586         * go-exp.y: Update rules.
8587         * f-exp.y: Update rules.
8588         * d-exp.y: Update rules.
8589         * c-exp.y: Update rules.
8590
8591 2019-04-04  Tom Tromey  <tom@tromey.com>
8592
8593         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8594         lex_operator, push_back>: New methods.
8595         Update all rules.
8596         (rust_parser::lex_hex, lex_escape): Rename and update.
8597         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8598         (rust_parser::lex_operator): Rename and update.
8599         (rust_parser::lex_number, rustyylex, rustyyerror)
8600         (rust_lex_test_init, rust_lex_test_sequence)
8601         (rust_lex_test_push_back, rust_lex_tests): Update.
8602         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8603         parameter.
8604         <lexptr, prev_lexptr>: New members.
8605         (lexptr, prev_lexptr): Don't declare.
8606         * parse.c (lexptr, prev_lexptr): Remove globals.
8607         (parse_exp_in_context): Update.
8608         * p-exp.y (yylex, yyerror): Update.
8609         * m2-exp.y (parse_number, yylex, yyerror): Update.
8610         * go-exp.y (lex_one_token, yyerror): Update.
8611         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8612         * d-exp.y (lex_one_token, yyerror): Update.
8613         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8614         (lex_one_token, yyerror): Update.
8615         * ada-lex.l (YY_INPUT): Update.
8616         (rewind_to_char): Update.
8617         * ada-exp.y (yyerror): Update.
8618
8619 2019-04-04  Tom Tromey  <tom@tromey.com>
8620
8621         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8622         * parser-defs.h (struct parser_state) <parser_state>: Add new
8623         parameter.
8624         <comma_terminates>: New member.
8625         (comma_terminates): Don't declare global.
8626         * parse.c (comma_terminates): Remove global.
8627         (parse_exp_in_context): Update.
8628         * p-exp.y (yylex): Update.
8629         * m2-exp.y (yylex): Update.
8630         * go-exp.y (lex_one_token): Update.
8631         * f-exp.y (yylex): Update.
8632         * d-exp.y (lex_one_token): Update.
8633         * c-exp.y (lex_one_token): Update.
8634         * ada-lex.l: Update.
8635
8636 2019-04-04  Tom Tromey  <tom@tromey.com>
8637
8638         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8639         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8640         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8641         * parser-defs.h (paren_depth): Don't declare.
8642         * parse.c (paren_depth): Remove global.
8643         (parse_exp_in_context): Update.
8644         * p-exp.y (paren_depth): New global.
8645         (pascal_parse): Initialize it.
8646         * m2-exp.y (paren_depth): New global.
8647         (m2_parse): Initialize it.
8648         * go-exp.y (paren_depth): New global.
8649         (go_parse): Initialize it.
8650         * f-exp.y (paren_depth): New global.
8651         (f_parse): Initialize it.
8652         * d-exp.y (paren_depth): New global.
8653         (d_parse): Initialize it.
8654         * c-exp.y (paren_depth): New global.
8655         (c_parse): Initialize it.
8656         * ada-lex.l (paren_depth): New global.
8657         (lexer_init): Initialize it.
8658
8659 2019-04-04  Tom Tromey  <tom@tromey.com>
8660
8661         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8662         (rust_parser::convert_ast_to_type)
8663         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8664         * parser-defs.h (struct parser_state) <parser_state>: Add
8665         parameters.  Initialize new members.
8666         <expression_context_block, expression_context_pc>: New members.
8667         * parse.c (expression_context_block, expression_context_pc):
8668         Remove globals.
8669         (parse_exp_in_context): Update.
8670         * p-exp.y: Update all rules.
8671         (yylex): Update.
8672         * m2-exp.y: Update all rules.
8673         (yylex): Update.
8674         * go-exp.y (yylex): Update.
8675         * f-exp.y (yylex): Update.
8676         * d-exp.y: Update all rules.
8677         (yylex): Update.
8678         * c-exp.y: Update all rules.
8679         (lex_one_token, classify_name, yylex, c_parse): Update.
8680         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8681
8682 2019-04-04  Tom Tromey  <tom@tromey.com>
8683
8684         * gdbarch.h, gdbarch.c: Rebuild.
8685         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8686         * stap-probe.h:
8687         (struct stap_parse_info): Replace "parser_state" with
8688         "expr_builder".
8689         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8690         (parser_state): New class.
8691         * parse.c (expr_builder): Rename.
8692         (expr_builder::release): Rename.
8693         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8694         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8695         (write_exp_elt_longcst, write_exp_elt_floatcst)
8696         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8697         (write_exp_string_vector, write_exp_bitstring)
8698         (write_exp_msymbol, mark_struct_expression)
8699         (write_dollar_variable)
8700         (insert_type_address_space, increase_expout_size): Replace
8701         "parser_state" with "expr_builder".
8702         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8703         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8704         "parser_state" with "expr_builder".
8705
8706 2019-04-04  Tom Tromey  <tom@tromey.com>
8707
8708         * rust-exp.y: Replace "parse_language" with method call.
8709         * p-exp.y:
8710         (yylex): Replace "parse_language" with method call.
8711         * m2-exp.y:
8712         (yylex): Replace "parse_language" with method call.
8713         * go-exp.y (classify_name): Replace "parse_language" with method
8714         call.
8715         * f-exp.y (yylex): Replace "parse_language" with method call.
8716         * d-exp.y (lex_one_token): Replace "parse_language" with method
8717         call.
8718         * c-exp.y:
8719         (lex_one_token, classify_name, yylex): Replace "parse_language"
8720         with method call.
8721         * ada-exp.y (find_primitive_type, type_char)
8722         (type_system_address): Replace "parse_language" with method call.
8723
8724 2019-04-04  Tom Tromey  <tom@tromey.com>
8725
8726         * rust-exp.y: Replace "parse_gdbarch" with method call.
8727         * parse.c (write_dollar_variable, insert_type_address_space):
8728         Replace "parse_gdbarch" with method call.
8729         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8730         call.
8731         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8732         call.
8733         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8734         "parse_gdbarch" with method call.
8735         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8736         with method call.
8737         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8738         "parse_gdbarch" with method call.
8739         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8740         "parse_gdbarch" with method call.
8741         * c-exp.y (parse_type, parse_number, classify_name): Replace
8742         "parse_gdbarch" with method call.
8743         * ada-lex.l: Replace "parse_gdbarch" with method call.
8744         * ada-exp.y (parse_type, find_primitive_type, type_char)
8745         (type_system_address): Replace "parse_gdbarch" with method call.
8746
8747 2019-04-04  Tom Tromey  <tom@tromey.com>
8748
8749         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8750         * stap-probe.c (stap_parse_argument): Update.
8751         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8752         initial_size parameter.
8753         * rust-exp.y (rust_lex_tests): Update.
8754         * parse.c (parser_state): Update.
8755         (parse_exp_in_context): Update.
8756         * parser-defs.h (struct parser_state) <parser_state>: Remove
8757         "initial_size" parameter.
8758
8759 2019-04-04  Tom Tromey  <tom@tromey.com>
8760
8761         * parser-defs.h (increase_expout_size): Don't declare.
8762         * parse.c (increase_expout_size): Now static.
8763
8764 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8765
8766         * gnu-nat.c (gnu_nat_target::wait): Fix
8767         target_waitstatus_to_string call.
8768
8769 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8770
8771         * eval.c (evaluate_subexp_standard): Handle internal functions
8772         during Fortran function call handling.
8773
8774 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8775
8776         * NEWS: Mention new internal functions.
8777         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8778         (read_base_type): Use dwarf2_init_complex_target_type.
8779         * value.c (creal_internal_fn): New function.
8780         (cimag_internal_fn): New function.
8781         (_initialize_values): Register new internal functions.
8782
8783 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8784
8785         * infrun.c (stop_all_threads): If debug_infrun, always
8786         trace the wait status after wait_one, using
8787         target_waitstatus_to_string and target_pid_to_str.
8788         (handle_inferior_event): Replace various trace of
8789         wait status kind by a single trace.
8790         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8791         wait status kind image by target_waitstatus_to_string.
8792         * target/waitstatus.c (target_waitstatus_to_string): Fix
8793         obsolete comment.
8794
8795 2019-04-01  Tom Tromey  <tromey@adacore.com>
8796
8797         PR symtab/23331:
8798         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8799
8800 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8801             Pedro Alves  <palves@redhat.com>
8802
8803         * top.c (quit_force): Call 'finalize_values'.
8804         * value.c (finalize_values): New function.
8805         * value.h (finalize_values): Declare.
8806
8807 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8808
8809         * NEWS: Announce $_gdb_major and $_gdb_minor.
8810
8811         * top.c (init_gdb_version_vars): New function.
8812         (gdb_init): Call init_gdb_version_vars.
8813
8814 2019-03-29  Tom Tromey  <tromey@adacore.com>
8815
8816         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8817         help text.  Remove dead code.
8818
8819 2019-03-29  Keith Seitz  <keiths@redhat.com>
8820
8821         From Siddhesh Poyarekar:
8822         * f-lang.h (f77_get_upperbound): Return LONGEST.
8823         (f77_get_lowerbound): Likewise.
8824         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8825         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8826         print them.
8827         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8828         plongest to format print it.
8829         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8830         (f77_get_upperbound): Likewise.
8831         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8832         LOWER_BOUND to LONGEST.
8833         (f77_create_arrayprint_offset_tbl): Likewise.
8834
8835 2019-03-29  Keith Seitz  <keiths@redhat.com>
8836
8837         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8838         %s/pulongest for TYPE_LENGTH instead of %d in format
8839         strings.
8840         * ada-typerint.c (ada_print_type): Likewise.
8841         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8842         * compile/compile-c-support.c (generate_register_struct): Likewise.
8843         * gdbtypes.c (recursive_dump_type): Likewise.
8844         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8845         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8846         instead of %d in format strings.
8847         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8848         to std::min to ULONGEST.
8849         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8850         instead of %d in format strings.
8851         * tracepoint.c (info_scope_command): Likewise.
8852         * typeprint.c (print_offset_data::update)
8853         (print_offset_data::finish): Likewise.
8854         * xtensa-tdep.c (xtensa_store_return_value)
8855         (xtensa_push_dummy_call): Likewise.
8856
8857 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8858
8859         * windows-nat.c (display_selector): Fixed format specifications
8860         for 64-bit Cygwin.
8861
8862 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8863
8864         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8865
8866 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8867
8868         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8869         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8870         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8871         (nios2_linux_init_abi): Install it.
8872
8873 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8874
8875         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8876
8877 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8878
8879         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8880
8881 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8882             Tom Tromey  <tromey@adacore.com>
8883
8884         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8885
8886 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8887
8888         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8889         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8890         method to compute the bounds of range types. Also print "[evaluated]"
8891         if the bounds' values come from a dynamic evaluation.
8892
8893 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8894
8895         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8896         whitespace when pretty printing is on.
8897
8898 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8899
8900         * ppc-linux-nat.c: Add include.
8901
8902 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8903
8904         * NEWS: Mention AArch64 Pointer Authentication.
8905
8906 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8907
8908         * arm-linux-nat.c: Add include.
8909
8910 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8911
8912         * source-cache.c (source_cache::get_source_lines): Re-read
8913         fullname after calling open_source_file.
8914
8915 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8916
8917         * NEWS: Mention TLS support for FreeBSD.
8918
8919 2019-03-25  Tom Tromey  <tromey@adacore.com>
8920
8921         * minsyms.c (BUNCH_SIZE): Update comment.
8922         (~minimal_symbol_reader): Remove old comment.
8923         (compact_minimal_symbols): Update comment.
8924         (minimal_symbol_reader::install): Remove old comment.  Update
8925         other comments.
8926
8927 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8928
8929         * s390-linux-nat.c: Add include.
8930
8931 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8932
8933         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8934         Call linux_get_hwcap.
8935         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8936         Likewise.
8937         (aarch64_linux_get_hwcap): Remove function.
8938         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8939         declaration.
8940         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8941         linux_get_hwcap.
8942         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8943         * linux-tdep.c (linux_get_hwcap): Add function.
8944         (linux_get_hwcap2): Likewise.
8945         * linux-tdep.h (linux_get_hwcap): Add declaration.
8946         (linux_get_hwcap2): Likewise.
8947         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8948         (ppc_linux_get_hwcap2): Likewise.
8949         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8950         linux_get_hwcap.
8951         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8952         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8953         (ppc_linux_nat_target::read_description): Likewise.
8954         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8955         * s390-linux-nat.c: Likewise.
8956         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8957
8958 2019-03-24  Tom Tromey  <tom@tromey.com>
8959
8960         * ada-lang.c (standard_lookup): Simplify initialization.
8961         (ada_lookup_symbol_nonlocal): Simplify return.
8962         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8963         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8964         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8965         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8966         initialization.
8967         * solib.c (solib_global_lookup): Simplify.
8968         * symtab.c (null_block_symbol): Remove.
8969         (symbol_cache_lookup): Simplify returns.
8970         (lookup_language_this): Simplify returns.
8971         (lookup_symbol_aux): Simplify return.
8972         (lookup_local_symbol): Simplify returns.
8973         (lookup_global_symbol_from_objfile): Simplify return.
8974         (lookup_symbol_in_objfile_symtabs)
8975         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8976         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8977         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8978         * cp-namespace.c (cp_lookup_bare_symbol)
8979         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8980         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8981         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8982         (cp_lookup_symbol_via_imports): Simplify initialization.
8983         (find_symbol_in_baseclass): Likewise.
8984         * symtab.h (null_block_symbol): Remove.
8985         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8986         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8987         (d_lookup_symbol_module): Likewise.
8988         (find_symbol_in_baseclass): Simplify initialization.
8989
8990 2019-03-24  Tom Tromey  <tom@tromey.com>
8991
8992         * expression.h: Don't include symtab.h.
8993         (struct block): Forward declare.
8994
8995 2019-03-24  Tom Tromey  <tom@tromey.com>
8996
8997         * c-exp.y (typebase): Remove casts.
8998         * gdbtypes.c (lookup_unsigned_typename, )
8999         (lookup_signed_typename): Remove cast.
9000         * eval.c (parse_to_comma_and_eval): Remove cast.
9001         * parse.c (write_dollar_variable): Remove cast.
9002         * block.h (struct block) <superblock>: Now const.
9003         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9004         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9005         (map_block): Make "block" const.
9006         * symfile.h (struct quick_symbol_functions)
9007         <map_matching_symbols>: Constify block argument to "callback".
9008         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9009         const.
9010         (find_pc_sect_compunit_symtab): Make "b" const.
9011         (find_symbol_at_address): Likewise.
9012         (search_symbols): Likewise.
9013         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9014         (dw2_debug_names_lookup_symbol): Likewise.
9015         (dw2_map_matching_symbols): Update.
9016         * p-valprint.c (pascal_val_print): Remove "block".
9017         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9018         (aux_add_nonlocal_symbols): Make "block" const.
9019         (resolve_subexp): Remove cast.
9020         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9021         const.
9022         (iterate_over_file_blocks): Likewise.
9023         * f-exp.y (%union) <bval>: Remove.
9024         * coffread.c (patch_opaque_types): Make "b" const.
9025         * spu-tdep.c (spu_catch_start): Make "block" const.
9026         * c-valprint.c (print_unpacked_pointer): Remove "block".
9027         * symmisc.c (dump_symtab_1): Make "b" const.
9028         (block_depth): Make "block" const.
9029         * d-exp.y (%union) <bval>: Remove.
9030         * cp-support.h (cp_lookup_rtti_type): Update.
9031         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9032         * psymtab.c (psym_lookup_symbol): Make "block" const.
9033         (maintenance_check_psymtabs): Make "b" const.
9034         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9035         (enumerate_locals, enumerate_args): Update.
9036         * python/py-symtab.c (stpy_global_block): Make "block" const.
9037         (stpy_static_block): Likewise.
9038         * inline-frame.c (block_starting_point_at): Make "new_block"
9039         const.
9040         * block.c (find_block_in_blockvector): Make return type const.
9041         (blockvector_for_pc_sect): Make "b" const.
9042         (find_block_in_blockvector): Make "b" const.
9043
9044 2019-03-23  Tom Tromey  <tom@tromey.com>
9045
9046         * varobj.c (varobj_create): Update.
9047         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9048         * printcmd.c (display_command, do_one_display): Don't reset
9049         innermost_block.
9050         * parser-defs.h (enum innermost_block_tracker_type): Move to
9051         expression.h.
9052         (innermost_block): Update comment.
9053         * parse.c (parse_exp_1): Add tracker_types parameter.
9054         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9055         tracker_types parameter.  Reset innermost_block.
9056         (parse_exp_in_context): Remove.
9057         (parse_expression_for_completion): Update.
9058         * objfiles.c (~objfile): Don't reset expression_context_block or
9059         innermost_block.
9060         * expression.h (enum innermost_block_tracker_type): Move from
9061         parser-defs.h.
9062         (parse_exp_1): Add tracker_types parameter.
9063         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9064         reset innermost_block.
9065
9066 2019-03-23  Tom Tromey  <tom@tromey.com>
9067
9068         * objfiles.h: Include bcache.h.
9069
9070 2019-03-23  Tom Tromey  <tom@tromey.com>
9071
9072         * linespec.c (get_current_search_block): Use
9073         scoped_restore_current_language.
9074         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9075
9076 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9077             Jiong Wang  <jiong.wang@arm.com>
9078
9079         * aarch64-linux-tdep.c
9080         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9081         section.
9082         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9083
9084 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9085             Jiong Wang  <jiong.wang@arm.com>
9086
9087         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9088         instructions.
9089         (aarch64_analyze_prologue_test): Add PACIASP test.
9090         (aarch64_prologue_prev_register): Unmask PC value.
9091
9092 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9093             Jiong Wang  <jiong.wang@arm.com>
9094
9095         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9096         (aarch64_dwarf2_prev_register): Unmask PC value.
9097         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9098         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9099         DW_CFA_AARCH64_negate_ra_state.
9100         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9101
9102 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9103             Jiong Wang  <jiong.wang@arm.com>
9104
9105         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9106         registers.
9107         (aarch64_pseudo_register_name): Likewise.
9108         (aarch64_pseudo_register_type): Likewise.
9109         (aarch64_pseudo_register_reggroup_p): Likewise.
9110         (aarch64_gdbarch_init): Add pauth registers.
9111         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9112         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9113         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9114         (struct gdbarch_tdep): Add regnum for ra_state.
9115
9116 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9117             Jiong Wang  <jiong.wang@arm.com>
9118
9119         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9120
9121 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9122             Jiong Wang  <jiong.wang@arm.com>
9123
9124         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9125         function.
9126         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9127         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9128         (aarch64_gdbarch_init): Add puth registers.
9129         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9130         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9131         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9132
9133 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9134             Jiong Wang  <jiong.wang@arm.com>
9135
9136         * aarch64-linux-nat.c
9137         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9138         * aarch64-linux-tdep.c
9139         (aarch64_linux_core_read_description): Likewise.
9140         (aarch64_linux_get_hwcap): New function.
9141         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9142         (aarch64_linux_get_hwcap): New declaration.
9143
9144 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9145             Jiong Wang  <jiong.wang@arm.com>
9146
9147         * aarch64-linux-nat.c
9148         (aarch64_linux_nat_target::read_description): Add pauth param.
9149         * aarch64-linux-tdep.c
9150         (aarch64_linux_core_read_description): Likewise.
9151         * aarch64-tdep.c (struct target_desc): Add in pauth.
9152         (aarch64_read_description): Add pauth param.
9153         (aarch64_gdbarch_init): Likewise.
9154         * aarch64-tdep.h (aarch64_read_description): Likewise.
9155         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9156         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9157         * features/Makefile: Add new files.
9158         * features/aarch64-pauth.c: New file.
9159         * features/aarch64-pauth.xml: New file.
9160
9161 2019-03-20  Tom Tromey  <tromey@adacore.com>
9162
9163         * infrun.c (handle_inferior_event): Rename from
9164         handle_inferior_event_1.  Create a scoped_value_mark.
9165         (handle_inferior_event): Remove.
9166
9167 2019-03-19  Tom Tromey  <tromey@adacore.com>
9168
9169         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9170         * infrun.h (print_stop_event): Add "displays" parameter.
9171         * infrun.c (print_stop_event): Add "displays" parameter.
9172
9173 2019-03-19  Pedro Alves  <palves@redhat.com>
9174
9175         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9176         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9177         to -1.  Fix TABs vs spaces.
9178         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9179         * tui/tui-out.h (tui_ui_out) Add intro comments.
9180         <m_line, m_start_of_line>: In-class initialize, and add describing
9181         comment.
9182
9183 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9184
9185         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9186         variable names.
9187         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9188
9189 2019-03-18  Pedro Alves  <palves@redhat.com>
9190             Eli Zaretskii <eliz@gnu.org>
9191
9192         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9193         m_line and m_start_of_line.
9194
9195 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9196
9197         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9198         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9199         it returns a newline.  This fixes a regression in TU mode, whereby
9200         the next line is output on the same screen line as the user input.
9201
9202 2019-03-18  Tom Tromey  <tromey@adacore.com>
9203
9204         * minsyms.c (minimal_symbol_reader::install): Remove call to
9205         obstack_blank.
9206
9207 2019-03-18  Pedro Alves  <palves@redhat.com>
9208
9209         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9210         New globals.
9211         (apply_style): New, factored out from ...
9212         (apply_ansi_escape): ... this.  Handle reverse video mode.
9213         (tui_set_reverse_mode): New function.
9214         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9215         * tui/tui-winsource.c (tui_show_source_line): Use
9216         tui_set_reverse_mode instead of setting A_STANDOUT.
9217         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9218         New setter methods.
9219
9220 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9221
9222         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9223         Handle tabs.
9224
9225 2019-03-18  Tom Tromey  <tromey@adacore.com>
9226
9227         * ada-lang.c (empty_array): Add "high" parameter.
9228         (ada_evaluate_subexp): Update.
9229
9230 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9231
9232         * unittests/string_view-selftests.c: Define
9233         _initialize_string_view_selftests unconditionally.
9234
9235 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9236
9237         PR gdb/24350
9238         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9239
9240 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9241
9242         PR gdb/24351
9243         * windows-nat.c (display_selector): Fix format specifiers.
9244
9245 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9246
9247         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9248         tui_refill_source_window instead of tui_refresh_win, to update the
9249         current execution line.  This fixes redisplay of the current line
9250         when stepping through the code with "next" or "step".
9251
9252 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9253
9254         * source-cache.c (source_cache::get_source_lines): Call
9255         find_source_lines to initialize s->nlines.  This fixes vertical
9256         scrolling of TUI source window when the DOWN arrow is pressed.
9257
9258 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9259
9260         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9261         linux-thread-db.c (_initialize_thread_db): Likewise.
9262
9263 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9264
9265         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9266         wclrtoeol in tui_show_source_line".  This reverts changes made in
9267         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9268
9269 2019-03-15  Tom Tromey  <tom@tromey.com>
9270
9271         * symtab.h (struct minimal_symbol): Derive from
9272         general_symbol_info.
9273         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9274         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9275         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9276         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9277         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9278         (MSYMBOL_SEARCH_NAME): Update.
9279         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9280         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9281         * minsyms.c (minimal_symbol_reader::record_full): Update.
9282
9283 2019-03-15  Tom Tromey  <tom@tromey.com>
9284
9285         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9286
9287 2019-03-15  Tom Tromey  <tom@tromey.com>
9288
9289         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9290         unique_xmalloc_ptr.
9291         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9292         Update.
9293         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9294         (build_minimal_symbol_hash_tables)
9295         (minimal_symbol_reader::install): Update.
9296
9297 2019-03-15  Tom Tromey  <tom@tromey.com>
9298
9299         * symtab.c (create_demangled_names_hash): Update.
9300         (symbol_set_names): Update.
9301         * objfiles.h (struct objfile_per_bfd_storage)
9302         <demangled_names_hash>: Now an htab_up.
9303         * objfiles.c (objfile_per_bfd_storage): Simplify.
9304
9305 2019-03-15  Tom Tromey  <tom@tromey.com>
9306
9307         * objfiles.h (struct objfile_per_bfd_storage): Declare
9308         destructor.
9309         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9310         New.
9311         (get_objfile_bfd_data): Use new.  Don't initialize
9312         language_of_main.
9313         (free_objfile_per_bfd_storage): Remove.
9314         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9315
9316 2019-03-15  Tom Tromey  <tom@tromey.com>
9317
9318         * symfile.c (reread_symbols): Update.
9319         * objfiles.c (objfile::objfile): Update.
9320         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9321         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9322         comment.
9323         (minimal_symbol_reader::install): Update.
9324         (terminate_minimal_symbol_table): Remove.
9325         * jit.c (jit_object_close_impl): Update.
9326
9327 2019-03-15  Tom Tromey  <tom@tromey.com>
9328
9329         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9330         initializations.
9331
9332 2019-03-15  Tom Tromey  <tom@tromey.com>
9333
9334         * objfiles.h (struct objfile_per_bfd_storage)
9335         <demangled_hash_languages>: Now a bitset.
9336         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9337         (lookup_minimal_symbol): Update.
9338
9339 2019-03-15  Tom Tromey  <tom@tromey.com>
9340
9341         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9342         Don't return the symbol.
9343         * coffread.c (record_minimal_symbol): Use record_full.
9344
9345 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9346
9347         The MS-Windows port of ncurses fails to switch to a color pair if
9348         one or both of the colors are the implicit default colors.  This
9349         change records the default colors when TUI is initialized, and
9350         then specifies them explicitly when a color pair uses the default
9351         colors.  This allows color styling in TUI mode on MS-Windows.
9352
9353         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9354         ncurses_norm_attr.
9355         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9356         colors in ncurses_norm_attr.
9357         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9358         "none", replace it with the default color recorded in
9359         ncurses_norm_attr.
9360
9361 2019-03-14  Tom Tromey  <tromey@adacore.com>
9362
9363         * source-cache.h (class source_cache) <get_source_lines>: Return
9364         std::string.
9365         * source-cache.c (source_cache::extract_lines): Handle case where
9366         first_pos==npos.  Return std::string.
9367         (source_cache::get_source_lines): Update.
9368
9369 2019-03-14  Tom Tromey  <tromey@adacore.com>
9370
9371         * NEWS: Add item for "style sources" commands.
9372         * source-cache.c (source_cache::get_source_lines): Check
9373         source_styling.
9374         * cli/cli-style.c (source_styling): New global.
9375         (_initialize_cli_style): Add "style sources" commands.
9376         (show_style_sources): New function.
9377         * cli/cli-style.h (source_styling): Declare.
9378
9379 2019-03-14  Pedro Alves  <palves@redhat.com>
9380             Tom Tromey  <tromey@adacore.com>
9381
9382         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9383         * tui/tui-winsource.c (tui_refill_source_window): New function,
9384         from...
9385         (tui_horizontal_source_scroll): ... here.  Move some logic.
9386         * cli/cli-style.c (set_style_enabled): Notify new observable.
9387         * tui/tui-hooks.c (tui_redisplay_source): New function.
9388         (tui_attach_detach_observers): Attach or detach
9389         tui_redisplay_source.
9390         * observable.h (source_styling_changed): New observable.
9391         * observable.c: Define source_styling_changed observable.
9392
9393 2019-03-13  Tom Tromey  <tromey@adacore.com>
9394
9395         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9396         (i386_gnu_nat_target::store_registers): Update.
9397         * target-debug.h (target_debug_print_std_string): New macro.
9398         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9399         * windows-tdep.c (display_one_tib): Update.
9400         * tui/tui-stack.c (tui_make_status_line): Update.
9401         * top.c (print_inferior_quit_action): Update.
9402         * thread.c (thr_try_catch_cmd): Update.
9403         (add_thread_with_info): Update.
9404         (thread_target_id_str): Update.
9405         (thr_try_catch_cmd): Update.
9406         (thread_command): Update.
9407         (thread_find_command): Update.
9408         * record-btrace.c (record_btrace_target::info_record)
9409         (record_btrace_resume_thread, record_btrace_target::resume)
9410         (record_btrace_cancel_resume, record_btrace_step_thread)
9411         (record_btrace_target::wait, record_btrace_target::wait)
9412         (record_btrace_target::wait, record_btrace_target::stop): Update.
9413         * progspace.c (print_program_space): Update.
9414         * process-stratum-target.c
9415         (process_stratum_target::thread_address_space): Update.
9416         * linux-fork.c (linux_fork_mourn_inferior)
9417         (detach_checkpoint_command, info_checkpoints_command)
9418         (linux_fork_context): Update.
9419         (linux_fork_detach): Update.
9420         (class scoped_switch_fork_info): Update.
9421         (delete_checkpoint_command): Update.
9422         * infrun.c (follow_fork_inferior): Update.
9423         (follow_fork_inferior): Update.
9424         (proceed_after_vfork_done): Update.
9425         (handle_vfork_child_exec_or_exit): Update.
9426         (follow_exec): Update.
9427         (displaced_step_prepare_throw): Update.
9428         (displaced_step_restore): Update.
9429         (start_step_over): Update.
9430         (resume_1): Update.
9431         (clear_proceed_status_thread): Update.
9432         (proceed): Update.
9433         (print_target_wait_results): Update.
9434         (do_target_wait): Update.
9435         (context_switch): Update.
9436         (stop_all_threads): Update.
9437         (restart_threads): Update.
9438         (finish_step_over): Update.
9439         (handle_signal_stop): Update.
9440         (switch_back_to_stepped_thread): Update.
9441         (keep_going_pass_signal): Update.
9442         (print_exited_reason): Update.
9443         (normal_stop): Update.
9444         * inferior.c (inferior_pid_to_str): Change return type.
9445         (print_selected_inferior): Update.
9446         (add_inferior): Update.
9447         (detach_inferior): Update.
9448         * dummy-frame.c (fprint_dummy_frames): Update.
9449         * dcache.c (dcache_info_1): Update.
9450         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9451         (btrace_fetch, btrace_clear): Update.
9452         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9453         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9454         type.
9455         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9456         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9457         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9458         * gdbarch.c, gdbarch.h: Rebuild.
9459         * gdbarch.sh (core_pid_to_str): Change return type.
9460         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9461         return type.
9462         (windows_nat_target::pid_to_str): Change return type.
9463         (windows_delete_thread): Update.
9464         (windows_nat_target::attach): Update.
9465         (windows_nat_target::files_info): Update.
9466         * target-delegates.c: Rebuild.
9467         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9468         return type.
9469         (sol_thread_target::pid_to_str): Change return type.
9470         * remote.c (class remote_target) <pid_to_str>: Change return
9471         type.
9472         (remote_target::pid_to_str): Change return type.
9473         (extended_remote_target::attach, remote_target::remote_stop_ns)
9474         (remote_target::remote_notif_remove_queued_reply)
9475         (remote_target::push_stop_reply, remote_target::disable_btrace):
9476         Update.
9477         (extended_remote_target::attach): Update.
9478         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9479         type.
9480         (gdbsim_target::pid_to_str): Change return type.
9481         * ravenscar-thread.c (struct ravenscar_thread_target)
9482         <pid_to_str>: Change return type.
9483         (ravenscar_thread_target::pid_to_str): Change return type.
9484         * procfs.c (class procfs_target) <pid_to_str>: Change return
9485         type.
9486         (procfs_target::pid_to_str): Change return type.
9487         (procfs_target::attach): Update.
9488         (procfs_target::detach): Update.
9489         (procfs_target::fetch_registers): Update.
9490         (procfs_target::store_registers): Update.
9491         (procfs_target::wait): Update.
9492         (procfs_target::files_info): Update.
9493         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9494         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9495         return type.
9496         (nto_procfs_target::pid_to_str): Change return type.
9497         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9498         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9499         return type.
9500         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9501         (exit_lwp): Update.
9502         (attach_proc_task_lwp_callback, get_detach_signal)
9503         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9504         (linux_nat_target::resume, wait_lwp, stop_callback)
9505         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9506         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9507         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9508         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9509         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9510         type.
9511         (inf_ptrace_target::attach): Update.
9512         (inf_ptrace_target::files_info): Update.
9513         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9514         type.
9515         (go32_nat_target::pid_to_str): Change return type.
9516         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9517         (gnu_nat_target::wait): Update.
9518         (gnu_nat_target::wait): Update.
9519         (gnu_nat_target::resume): Update.
9520         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9521         (fbsd_nat_target::wait): Update.
9522         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9523         type.
9524         (darwin_nat_target::attach): Update.
9525         * corelow.c (class core_target) <pid_to_str>: Change return type.
9526         (core_target::pid_to_str): Change return type.
9527         * target.c (normal_pid_to_str): Change return type.
9528         (default_pid_to_str): Likewise.
9529         (target_pid_to_str): Change return type.
9530         (target_translate_tls_address): Update.
9531         (target_announce_detach): Update.
9532         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9533         return type.
9534         (bsd_uthread_target::pid_to_str): Change return type.
9535         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9536         type.
9537         (bsd_kvm_target::pid_to_str): Change return type.
9538         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9539         return type.
9540         (aix_thread_target::pid_to_str): Change return type.
9541         * target.h (struct target_ops) <pid_to_str>: Change return type.
9542         (target_pid_to_str, normal_pid_to_str): Likewise.
9543         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9544         type.
9545         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9546         type.
9547         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9548         return type.
9549         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9550         type.
9551         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9552         type.
9553         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9554         return type.
9555
9556 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9557
9558         * NEWS: Mention that the new default MI version is 3.  Mention
9559         changes to the output of commands and events that deal with
9560         multi-location breakpoints.
9561         * breakpoint.c: Include "mi/mi-out.h".
9562         (print_one_breakpoint): Change output syntax if using MI version
9563         >= 3.
9564         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9565         New.
9566         (mi_multi_location_breakpoint_output_fixed): New.
9567         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9568         (mi_cmd_fix_multi_location_breakpoint_output): New.
9569         (mi_multi_location_breakpoint_output_fixed): New.
9570         * mi/mi-cmds.c (mi_cmds): Register command
9571         -fix-multi-location-breakpoint-output.
9572         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9573         interpreter "mi".
9574
9575 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9576
9577         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9578         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9579         instantiate mi_ui_out based on interpreter name.
9580         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9581         * mi/mi-main.c (mi_load_progress): Likewise.
9582
9583 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9584
9585         * NEWS: Combine separate "New targets" sections for 8.3.
9586
9587 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9588
9589         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9590         (ppcfbsd_init_abi): Install gdbarch
9591         "fetch_tls_load_module_address" and "get_thread_local_address"
9592         methods.
9593
9594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9595
9596         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9597         (riscv_fbsd_init_abi): Install gdbarch
9598         "fetch_tls_load_module_address" and "get_thread_local_address"
9599         methods.
9600
9601 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9602
9603         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9604         (i386fbsd_init_abi): Install gdbarch
9605         "fetch_tls_load_module_address" and "get_thread_local_address"
9606         methods.
9607
9608 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9609
9610         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9611         (amd64fbsd_init_abi): Install gdbarch
9612         "fetch_tls_load_module_address" and "get_thread_local_address"
9613         methods.
9614
9615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9616
9617         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9618         (struct fbsd_pspace_data): New type.
9619         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9620         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9621         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9622         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9623         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9624
9625 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9626
9627         * gdbtypes.c (lookup_struct_elt): New function.
9628         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9629         * gdbtypes.h (struct struct_elt): New type.
9630         (lookup_struct_elt): New prototype.
9631
9632 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9633
9634         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9635         remove disabled code block.
9636
9637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9638
9639         * gdbarch.sh (get_thread_local_address): New method.
9640         * gdbarch.h, gdbarch.c: Regenerate.
9641         * target.c (target_translate_tls_address): Use
9642         gdbarch_get_thread_local_address if present instead of
9643         target::get_thread_local_address.
9644
9645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9646
9647         * target.h (target::get_thread_local_address): Update comment.
9648
9649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9650
9651         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9652         objfile->separate_debug_objfile_backlink if not NULL.
9653
9654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9655
9656         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9657         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9658         (amd64bsd_store_inferior_registers): Likewise.
9659         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9660         Enable segment base registers.
9661         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9662         PT_GETFSBASE and PT_GETGSBASE.
9663         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9664         PT_SETGSBASE.
9665         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9666         segment base registers.
9667         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9668
9669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9670
9671         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9672         Update calls to i386_target_description to add 'segments'
9673         parameter.
9674         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9675         add segment base registers.
9676         * arch/i386.c (i386_create_target_description): Add 'segments'
9677         parameter to enable segment base registers.
9678         * arch/i386.h (i386_create_target_description): Likewise.
9679         * features/i386/32bit-segments.xml: New file.
9680         * features/i386/32bit-segments.c: Generate.
9681         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9682         call to i386_target_description to add 'segments' parameter.
9683         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9684         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9685         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9686         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9687         if feature is present.
9688         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9689         Add 'segments' parameter to call to i386_target_description.
9690         (i386_target_description): Add 'segments' parameter to enable
9691         segment base registers.
9692         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9693         to call to i386_target_description.
9694         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9695         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9696         Define I386_NUM_REGS.
9697         (i386_target_description): Add 'segments' parameter to enable
9698         segment base registers.
9699
9700 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9701
9702         PR/24325
9703         * source-cache.c: #undef open and close, to avoid unresolved
9704         externals during linking.
9705
9706 2019-03-12  Tom Tromey  <tromey@adacore.com>
9707
9708         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9709         const.  Add initializers.
9710         (_initialize_remote): Don't initialize ptid globals.
9711
9712 2019-03-12  Pedro Alves  <palves@redhat.com>
9713
9714         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9715
9716 2019-03-12  Pedro Alves  <palves@redhat.com>
9717
9718         * cp-name-parser.y (main): Remove unused 'len' variable.
9719
9720 2019-03-12  Tom Tromey  <tromey@adacore.com>
9721
9722         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9723         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9724
9725 2019-03-12  Tom Tromey  <tromey@adacore.com>
9726
9727         * linux-nat.c (iterate_over_lwps): Update.
9728         (stop_callback): Remove parameter.
9729         (stop_wait_callback, detach_callback, resume_set_callback)
9730         (select_singlestep_lwp_callback, set_ignore_sigint)
9731         (status_callback, resumed_callback, resume_clear_callback)
9732         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9733         data parameter.
9734         (linux_nat_target::detach, linux_nat_target::resume)
9735         (linux_stop_and_wait_all_lwps, select_event_lwp)
9736         (linux_nat_filter_event, linux_nat_wait_1)
9737         (linux_nat_target::kill, linux_nat_target::stop)
9738         (linux_nat_target::stop): Update.
9739         (linux_nat_resume_callback): Change type.
9740         (resume_stopped_resumed_lwps, count_events_callback)
9741         (select_event_lwp_callback): Likewise.
9742         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9743         * arm-linux-nat.c (struct update_registers_data): Remove.
9744         (update_registers_callback): Change type.
9745         (arm_linux_insert_hw_breakpoint1): Update.
9746         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9747         parameter.
9748         (x86_linux_dr_set_addr): Update.
9749         (x86_linux_dr_set_control): Update.
9750         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9751         (iterate_over_lwps): Use gdb::function_view.
9752         * nat/aarch64-linux-hw-point.c (struct
9753         aarch64_dr_update_callback_param): Remove.
9754         (debug_reg_change_callback): Change type.
9755         (aarch64_notify_debug_reg_change): Update.
9756         * s390-linux-nat.c (s390_refresh_per_info): Update.
9757
9758 2019-03-11  Tom Tromey  <tromey@adacore.com>
9759
9760         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9761         redundant assignment to "this_cu".
9762
9763 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9764
9765         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9766
9767 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9768
9769         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9770         from...
9771         (rank_one_type): ... this.
9772
9773 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9774
9775         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9776         from...
9777         (rank_one_type): ... this.
9778
9779 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9780
9781         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9782         from...
9783         (rank_one_type): ... this.
9784
9785 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9786
9787         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9788         from...
9789         (rank_one_type): ... this.
9790
9791 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9792
9793         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9794         from...
9795         (rank_one_type): ... this.
9796
9797 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9798
9799         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9800         from...
9801         (rank_one_type): ... this.
9802
9803 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9804
9805         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9806         from...
9807         (rank_one_type): ... this.
9808
9809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9810
9811         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9812         from...
9813         (rank_one_type): ... this.
9814
9815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9816
9817         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9818         from...
9819         (rank_one_type): ... this.
9820
9821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9822
9823         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9824         from...
9825         (rank_one_type): ... this.
9826
9827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9828
9829         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9830         from...
9831         (rank_one_type): ... this.
9832
9833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9834
9835         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9836         from...
9837         (rank_one_type): ... this.
9838
9839 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9840
9841         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9842         inferior-events' shows the example events.
9843
9844 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9845
9846         Support styling on native MS-Windows console
9847
9848         PR/24315
9849         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9850         on MS-Windows if $TERM is not defined.
9851
9852         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9853
9854         * posix-hdep.c (gdb_console_fputs):
9855         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9856         functions.
9857         * ui-file.h (gdb_console_fputs): Add prototype.
9858
9859         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9860         back to fputs only if the former returns zero.
9861
9862 2019-03-07  Tom Tromey  <tom@tromey.com>
9863
9864         * symmisc.c (print_symbol_bcache_statistics): Update.
9865         (print_objfile_statistics): Update.
9866         * symfile.c (allocate_symtab): Update.
9867         * stabsread.c: Don't include bcache.h.
9868         * psymtab.h (struct psymbol_bcache): Don't declare.
9869         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9870         (psymbol_bcache_init, psymbol_bcache_free)
9871         (psymbol_bcache_get_bcache): Don't declare.
9872         * psymtab.c (struct psymbol_bcache): Remove.
9873         (psymtab_storage::psymtab_storage): Update.
9874         (psymtab_storage::~psymtab_storage): Update.
9875         (psymbol_bcache_init, psymbol_bcache_free)
9876         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9877         (add_psymbol_to_bcache): Update.
9878         (allocate_psymtab): Update.
9879         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9880         macro_cache>: No longer pointers.
9881         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9882         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9883         * macrotab.c (macro_bcache): Update.
9884         * macroexp.c: Don't include bcache.h.
9885         * gdbtypes.c (check_types_worklist): Update.
9886         (types_deeply_equal): Remove TRY/CATCH.  Update.
9887         * elfread.c (elf_symtab_read): Update.
9888         * dwarf2read.c: Don't include bcache.h.
9889         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9890         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9891         (print_bcache_statistics, bcache_memory_used): Don't declare.
9892         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9893         methods.  Rename all data members.
9894         * bcache.c (struct bcache): Move to bcache.h.
9895         (bcache::expand_hash_table): Rename from expand_hash_table.
9896         (bcache): Remove.
9897         (bcache::insert): Rename from bcache_full.
9898         (bcache::compare): Rename from bcache_compare.
9899         (bcache_xmalloc): Remove.
9900         (bcache::~bcache): Rename from bcache_xfree.
9901         (bcache::print_statistics): Rename from print_bcache_statistics.
9902         (bcache::memory_used): Rename from bcache_memory_used.
9903
9904 2019-03-07  Pedro Alves  <palves@redhat.com>
9905
9906         * infrun.c (normal_stop): Also check for
9907         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9908
9909 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9910
9911         * f-lang.c (value_from_host_double): Moved to...
9912         * value.c (value_from_host_double): ...here.
9913         * value.h (value_from_host_double): Declare.
9914         * guile/scm-math.c (vlscm_convert_typed_number): Use
9915         value_from_host_double.
9916         (vlscm_convert_number): Likewise.
9917         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9918         * python/py-value.c (convert_value_from_python): Likewise.
9919
9920 2019-03-06  Tom Tromey  <tom@tromey.com>
9921
9922         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9923
9924 2019-03-06  Tom Tromey  <tom@tromey.com>
9925
9926         * utils.h (free_current_contents): Don't declare.
9927         * utils.c (free_current_contents): Remove.
9928
9929 2019-03-06  Tom Tromey  <tom@tromey.com>
9930
9931         * top.c (quit_force): Update.
9932         * main.c (captured_command_loop): Update.
9933         * common/new-op.c (operator new): Update.
9934         * common/common-exceptions.c (struct catcher)
9935         <save_cleanup_chain>: Remove member.
9936         (exceptions_state_mc_init): Update.
9937         (exception_try_scope_entry): Return nullptr.
9938         (exception_try_scope_exit, exception_rethrow)
9939         (throw_exception_sjlj, throw_exception_cxx): Update.
9940         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9941         (all_cleanups, do_cleanups, discard_cleanups)
9942         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9943         (restore_cleanups, restore_final_cleanups): Don't declare.
9944         (do_final_cleanups): Remove parameter.
9945         * common/cleanups.c (cleanup_chain, make_cleanup)
9946         (make_cleanup_dtor, all_cleanups, do_cleanups)
9947         (discard_my_cleanups, discard_cleanups)
9948         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9949         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9950         (null_cleanup): Remove.
9951         (do_final_cleanups): Remove parameter.
9952
9953 2019-03-06  Tom Tromey  <tom@tromey.com>
9954
9955         * remote.c (remote_target::remote_parse_stop_reply): Use
9956         unique_xmalloc_ptr.
9957
9958 2019-03-06  Tom Tromey  <tom@tromey.com>
9959
9960         * stabsread.c (struct stabs_field_info): Rename from field_info.
9961         <list, fnlist>: Add initializers.
9962         <obstack>: New member.
9963         (read_member_functions, read_struct_fields, read_baseclasses):
9964         Allocate on obstack.  Don't use cleanups.
9965         (read_one_struct_field, read_member_functions, read_struct_fields)
9966         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9967         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9968         (read_struct_type): Update.
9969
9970 2019-03-06  Tom Tromey  <tom@tromey.com>
9971
9972         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9973         * common/filestuff.h (make_cleanup_close): Don't declare.
9974         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9975         Remove.
9976
9977 2019-03-06  Tom Tromey  <tom@tromey.com>
9978
9979         * solib-aix.c: Use make_scope_exit.
9980
9981 2019-03-06  Tom Tromey  <tom@tromey.com>
9982
9983         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9984         Use make_scope_exit.
9985
9986 2019-03-06  Tom Tromey  <tom@tromey.com>
9987
9988         * solib-svr4.c (disable_probes_interface): Remove parameter.
9989         (svr4_handle_solib_event): Use make_scope_exit.
9990
9991 2019-03-06  Tom Tromey  <tom@tromey.com>
9992
9993         * remote.c (struct stop_reply_deleter): Remove.
9994         (stop_reply_up): Update.
9995         (struct stop_reply): Derive from notif_event.  Don't typedef.
9996         <regcache>: Now a std::vector.
9997         (stop_reply_xfree): Remove.
9998         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9999         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10000         (remote_target::discard_pending_stop_replies): Use delete.
10001         (remote_target::remote_parse_stop_reply): Update.
10002         (remote_target::process_stop_reply): Update.
10003         * remote-notif.h (struct notif_event): Add virtual destructor.
10004         Remove "dtr" member.
10005         (struct notif_client) <alloc_event>: Return a unique_ptr.
10006         (notif_event_xfree): Don't declare.
10007         (notif_event_up): New typedef.
10008         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10009         (notif_event_xfree, do_notif_event_xfree): Remove.
10010         (remote_notif_state_xfree): Update.
10011
10012 2019-03-06  Tom Tromey  <tom@tromey.com>
10013
10014         * infrun.c (displaced_step_clear_cleanup): Now a
10015         forward_scope_exit type.
10016         (displaced_step_prepare_throw): Update.
10017         (displaced_step_fixup): Update.
10018
10019 2019-03-06  Tom Tromey  <tom@tromey.com>
10020
10021         * inferior.h (class inferior): Update comment.
10022         * gdbthread.h (class thread_info): Update comment.
10023
10024 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10025             Tom Tromey  <tom@tromey.com>
10026
10027         * stabsread.h (struct stab_section_list): Remove.
10028         (coffstab_build_psymtabs): Update.
10029         * dbxread.c (symbuf_sections): Now a std::vector.
10030         (sect_idx): New global.
10031         (fill_symbuf): Update.
10032         (coffstab_build_psymtabs): Change type of stabsects parameter.
10033         Update.
10034         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10035         std::vector.
10036         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10037         (coff_locate_sections): Update.
10038         (coff_symfile_read): Remove cleanups.  Update.
10039         (init_stringtab): Add storage parameter.
10040         (free_stringtab, free_stringtab_cleanup): Remove.
10041         (init_lineno): Add storage parameter.
10042         (free_linetab, free_linetab_cleanup): Remove.
10043
10044 2019-03-06  Pedro Alves  <palves@redhat.com>
10045
10046         * linux-fork.c (fork_info::clobber_regs): Delete.
10047         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10048         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10049         comment.  Adjust.
10050         (scoped_switch_fork_info::scoped_switch_fork_info)
10051         (checkpoint_command, linux_fork_context): Adjust
10052         fork_save_infrun_state calls.
10053
10054 2019-03-06  Pedro Alves  <palves@redhat.com>
10055
10056         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10057         (inf_has_multiple_threads): Return 'bool' and rewrite using
10058         inferior_info::threads().
10059
10060 2019-03-06  Pedro Alves  <palves@redhat.com>
10061
10062         * linux-fork.c: Include <list>.
10063         (fork_list): Now a std::list instance.
10064         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10065         (forks_exist_p, find_last_fork): Adjust.
10066         (new_fork): Delete.
10067         (one_fork_p): New.
10068         (add_fork): Adjust.
10069         (free_fork): Delete, folded into fork_info::~fork_info().
10070         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10071         Adjust.
10072         (init_fork_list): Delete.
10073         (linux_fork_killall, linux_fork_mourn_inferior)
10074         (linux_fork_detach, info_checkpoints_command): Adjust.
10075         (_initialize_linux_fork): No longer call init_fork_list.
10076
10077 2019-03-06  Pedro Alves  <palves@redhat.com>
10078
10079         * linux-fork.c (new_fork): New, split out of ...
10080         (add_fork): ... this.  Return void.  Move "first fork" special
10081         case from here, to ...
10082         (checkpoint_command): ... here.
10083         * linux-linux.h (add_fork): Return void.
10084
10085 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10086
10087         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10088
10089 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10090             Chris January  <chris.january@arm.com>
10091             David Lecomber  <david.lecomber@arm.com>
10092
10093         * f-exp.y: New token, UNOP_INTRINSIC.
10094         (exp): New pattern using UNOP_INTRINSIC token.
10095         (f77_keywords): Add 'abs' keyword.
10096         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10097         (value_from_host_double): New function.
10098         (evaluate_subexp_f): Support UNOP_ABS.
10099
10100 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10101
10102         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10103         types.
10104
10105 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10106
10107         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10108         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10109         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10110
10111 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10112
10113         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10114
10115 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10116             Chris January  <chris.january@arm.com>
10117
10118         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10119         * f-exp.y: Define 'KIND' token.
10120         (exp): New pattern for KIND expressions.
10121         (ptype): Handle types with a kind extension.
10122         (direct_abs_decl): Extend to spot kind extensions.
10123         (f77_keywords): Add 'kind' to the list.
10124         (push_kind_type): New function.
10125         (convert_to_kind_type): New function.
10126         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10127         * parse.c (operator_length_standard): Likewise.
10128         * parser-defs.h (enum type_pieces): Add tp_kind.
10129         * std-operator.def: Add UNOP_KIND.
10130
10131 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10132
10133         * f-exp.y (f_parse): Set yydebug.
10134
10135 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10136
10137         * f-lang.c (evaluate_subexp_f): New function.
10138         (exp_descriptor_f): New global.
10139         (f_language_defn): Use exp_descriptor_f instead of
10140         exp_descriptor_standard.
10141
10142 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10143
10144         * f-exp.y (struct token): Add comments.
10145         (dot_ops): Remove uppercase versions and the end marker.
10146         (f77_keywords): Likewise.
10147         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10148         entries in the dot_ops array are case insensitive, and use
10149         strncasecmp to compare strings.  Also some whitespace cleanup in
10150         this area.  Similar for the f77_keywords array, except entries in
10151         this list might be case sensitive.
10152
10153 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10154
10155         * f-exp.y (struct f77_boolean_val): Add comments.
10156         (boolean_values): Remove uppercase versions, and end marker.
10157         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10158         and use strncasecmp to achieve case insensitivity.  Additionally,
10159         perform whitespace cleanup around this code.
10160
10161 2019-03-06  Tom Tromey  <tromey@adacore.com>
10162
10163         * remote-sim.c (gdbsim_target_open): Use result of
10164         gdb_argv::release.
10165
10166 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10167         Dirk Schubert  <dirk.schubert@arm.com>
10168         Chris January  <chris.january@arm.com>
10169
10170         * eval.c (evaluate_subexp_standard): Call Fortran argument
10171         wrapping logic.
10172         * f-lang.c (struct value): A value which can be passed into a
10173         Fortran function call.
10174         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10175         where appropriate.
10176         (struct type): Value ready for a Fortran function call.
10177         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10178         is needed.
10179         * f-lang.h (fortran_argument_convert): Declaration.
10180         (fortran_preserve_arg_pointer): Declaration.
10181         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10182
10183 2019-03-05  Tom Tromey  <tromey@adacore.com>
10184
10185         * python/py-prettyprint.c (print_string_repr): Remove #if.
10186         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10187
10188 2019-03-05  Tom Tromey  <tromey@adacore.com>
10189
10190         * target.c (the_dummy_target): Move later.  Change type to
10191         "dummy_target".
10192         (initialize_targets): Don't initialize the_dummy_target.
10193
10194 2019-03-05  Tom Tromey  <tromey@adacore.com>
10195
10196         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10197         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10198
10199 2019-03-05  Tom Tromey  <tromey@adacore.com>
10200
10201         * windows-nat.c (windows_nat_target::attach)
10202         (windows_nat_target::detach): Don't call gdb_flush.
10203         * valprint.c (generic_val_print, val_print, val_print_string):
10204         Don't call gdb_flush.
10205         * utils.c (defaulted_query): Don't call gdb_flush.
10206         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10207         * target.c (target_announce_detach): Don't call gdb_flush.
10208         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10209         * remote.c (extended_remote_target::attach): Don't call
10210         gdb_flush.
10211         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10212         * printcmd.c (do_examine): Don't call gdb_flush.
10213         (info_display_command): Don't call gdb_flush.
10214         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10215         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10216         * memattr.c (info_mem_command): Don't call gdb_flush.
10217         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10218         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10219         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10220         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10221         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10222         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10223         (gnu_nat_target::detach): Don't call gdb_flush.
10224         * f-valprint.c (f_val_print): Don't call gdb_flush.
10225         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10226         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10227         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10228         gdb_flush.
10229         * c-valprint.c (c_val_print): Don't call gdb_flush.
10230         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10231
10232 2019-03-05  Tom Tromey  <tromey@adacore.com>
10233
10234         * varobj.c (update_dynamic_varobj_children): Update.
10235         (install_default_visualizer): Use reset, not release.
10236         * value.c (set_internalvar): Update.
10237         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10238         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10239         ATTRIBUTE_UNUSED_RESULT.
10240
10241 2019-03-05  Tom Tromey  <tromey@adacore.com>
10242
10243         * remote.c (class scoped_remote_fd) <release>: Add
10244         ATTRIBUTE_UNUSED_RESULT.
10245
10246 2019-03-05  Tom Tromey  <tromey@adacore.com>
10247
10248         * macroexp.c (struct macro_buffer) <release>: Add
10249         ATTRIBUTE_UNUSED_RESULT.
10250
10251 2019-03-05  Tom Tromey  <tromey@adacore.com>
10252
10253         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10254         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10255         ATTRIBUTE_UNUSED_RESULT.
10256
10257 2019-03-05  Tom Tromey  <tromey@adacore.com>
10258
10259         * common/scoped_fd.h (class scoped_fd) <release>: Add
10260         ATTRIBUTE_UNUSED_RESULT.
10261
10262 2019-03-05  Tom Tromey  <tromey@adacore.com>
10263
10264         * parser-defs.h (struct parser_state) <release>: Add
10265         ATTRIBUTE_UNUSED_RESULT.
10266
10267 2019-03-05  Tom Tromey  <tromey@adacore.com>
10268
10269         * utils.h (class gdb_argv) <release>: Add
10270         ATTRIBUTE_UNUSED_RESULT.
10271         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10272
10273 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10274
10275         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10276         for-loop range, to avoid compiler warnings.
10277
10278         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10279         avoid compiler warnings about unused variables.
10280
10281         * NEWS: Mention end of support for native debugging on MS-Windows
10282         before XP.
10283
10284         PR gdb/24292
10285         * common/netstuff.c:
10286         * gdbserver/gdbreplay.c
10287         * gdbserver/remote-utils.c:
10288         * ser-tcp.c:
10289         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10290         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10291         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10292         'getaddrinfo' and 'freeaddrinfo' were not available before
10293         Windows XP, and mingw.org's MinGW headers by default define
10294         _WIN32_WINNT to 0x500.
10295
10296 2019-03-01  Gary Benson <gbenson@redhat.com>
10297
10298         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10299
10300 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10301             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10302
10303         PR gdb/8527
10304         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10305         set_sigint_trap, clear_sigint_trap.
10306
10307 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10308
10309         * target.c (target_detach): Clear the regcache and the
10310         frame cache.
10311
10312 2019-02-27  Pedro Alves  <palves@redhat.com>
10313
10314         * utils.c (set_screen_size): When we cap the height/width sizes,
10315         tweak the corresponding command variable to show "unlimited":
10316
10317 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10318             Pedro Alves  <palves@redhat.com>
10319
10320         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10321         before calling rl_set_screen_size.
10322
10323 2019-02-27  Tom Tromey  <tromey@adacore.com>
10324
10325         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10326         define.
10327         * python/py-value.c: Remove Python 2.4 workaround.
10328         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10329         workaround.
10330         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10331         Python 2.4 workaround.
10332         * python/python-internal.h: Remove Python 2.4 comment.
10333         (Py_ssize_t): Don't define.
10334         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10335         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10336         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10337         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10338         * python/python.c (do_start_initialization): Remove Python 2.4
10339         workaround.
10340         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10341         (print_children): Remove Python 2.4 workaround.
10342         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10343         workaround.
10344         (CHARBUFFERPROC_NAME): Remove.
10345         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10346         Python 2.4 workaround.
10347
10348 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10349
10350         * NEWS: Note minimum Python version.
10351
10352 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10353
10354         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10355         code from these functions.  Remove corresponding ifdefs.  Use
10356         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10357         Remove gotos and target of gotos.
10358         (infpy_search_memory): Likewise.
10359
10360 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10361
10362         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10363         (hppa_gdbarch_init): Don't register deleted functions with
10364         gdbarch.
10365
10366 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10367
10368         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10369         (h8300_unwind_sp): Delete.
10370         (h8300_dummy_id): Delete.
10371         (h8300_gdbarch_init): Don't register deleted functions with
10372         gdbarch.
10373
10374 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10375
10376         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10377         (ft32_unwind_pc): Delete.
10378         (ft32_unwind_sp): Delete.
10379         (ft32_gdbarch_init): Don't register deleted functions with
10380         gdbarch.
10381
10382 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10383
10384         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10385         (frv_unwind_pc): Delete.
10386         (frv_unwind_sp): Delete.
10387         (frv_gdbarch_init): Don't register deleted functions with
10388         gdbarch.
10389
10390 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10391
10392         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10393         (riscv_unwind_pc): Delete.
10394         (riscv_unwind_sp): Delete.
10395         (riscv_gdbarch_init): Don't register deleted functions with
10396         gdbarch.
10397
10398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10399
10400         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10401         (csky_unwind_pc): Delete.
10402         (csky_unwind_sp): Delete.
10403         (csky_gdbarch_init): Don't register deleted functions with
10404         gdbarch.
10405
10406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10407
10408         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10409         (cris_unwind_pc): Delete.
10410         (cris_unwind_sp): Delete.
10411         (cris_gdbarch_init): Don't register deleted functions with
10412         gdbarch.
10413
10414 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10415
10416         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10417         (bfin_unwind_pc): Delete.
10418         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10419
10420 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10421
10422         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10423         (arm_unwind_pc): Delete.
10424         (arm_unwind_sp): Delete.
10425         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10426
10427 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10428
10429         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10430         (arc_unwind_pc): Delete.
10431         (arc_unwind_sp): Delete.
10432         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10433
10434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10435
10436         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10437         (alpha_unwind_pc): Delete.
10438         (alpha_gdbarch_init): Don't register deleted functions with
10439         gdbarch.
10440
10441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10442
10443         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10444         (aarch64_unwind_pc): Delete.
10445         (aarch64_unwind_sp): Delete.
10446         (aarch64_gdbarch_init): Don't register deleted functions with
10447         gdbarch.
10448
10449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10450
10451         * gdbtypes.c (type_align): Don't consider static members when
10452         computing structure alignment.
10453
10454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10455
10456         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10457         return 0 for other types.
10458         * arch-utils.c (default_type_align): Always return 0.
10459         * gdbarch.h: Regenerate.
10460         * gdbarch.sh (type_align): Extend comment.
10461         * gdbtypes.c (type_align): Add additional comments, always call
10462         gdbarch_type_align before applying the default rules.
10463         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10464         generic code will then apply a suitable default.
10465         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10466         types, return 0 for other types.
10467
10468 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10469
10470         * NEWS: Create a new section for the next release branch.
10471         Rename the section of the current branch, now that it has
10472         been cut.
10473
10474 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10475
10476         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10477         * version.in: Bump version to 8.3.50.DATE-git.
10478
10479 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10480
10481         * aix-thread.c (ptid_cmp): Remove unused variable.
10482         (get_signaled_thread): Likewise.
10483         (store_regs_user_thread): Likewise.
10484         (store_regs_kernel_thread): Likewise.
10485         (fetch_regs_kernel_thread): Remove shadowed variable.
10486
10487 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10488
10489         * features/riscv/32bit-cpu.xml: Add register numbers.
10490         * features/riscv/32bit-fpu.c: Regenerate.
10491         * features/riscv/32bit-fpu.xml: Add register numbers.
10492         * features/riscv/64bit-cpu.xml: Add register numbers.
10493         * features/riscv/64bit-fpu.c: Regenerate.
10494         * features/riscv/64bit-fpu.xml: Add register numbers.
10495
10496 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10497
10498         * NEWS: Mention two argument form of gdb.Value constructor.
10499         * python/py-value.c (convert_buffer_and_type_to_value): New
10500         function.
10501         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10502         Add support for handling an optional second argument.  Call
10503         convert_buffer_and_type_to_value as appropriate.
10504         * python/python-internal.h (Py_buffer_deleter): New struct.
10505         (Py_buffer_up): New typedef.
10506
10507 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10508
10509         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10510         instead of releasing ownership.
10511
10512 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10513
10514         * dwarf2read.c (open_and_init_dwp_file): Call
10515         elf_numsections instead of bfd_count_sections to initialize
10516         dwp_file->num_sections.
10517
10518 2019-02-25  Tom Tromey  <tromey@adacore.com>
10519
10520         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10521
10522 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10523
10524         * gcore.in: Add '--readnever' option when invoking GDB.
10525
10526 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10527
10528         * MAINTAINERS: Update my email address.
10529
10530 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10531
10532         * build-id.c (build_id_to_debug_bfd_1): New function.
10533         (build_id_to_debug_bfd): Look for separate debug file in
10534         sysroot.
10535
10536 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10537
10538         * gdbarch.sh: Update the copyright year range that is placed into
10539         generated files.
10540
10541 2019-02-22  Keith Seitz  <keiths@redhat.com>
10542
10543         PR symtab/23853
10544         * linespec.c (create_sals_line_offset): Search for the default
10545         symtab's filename instead of its fullname.
10546
10547 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10548
10549         * NEWS: Update style defaults.
10550
10551 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10552
10553         * main.c (captured_main_1): Disable styling in batch mode.
10554
10555 2019-02-20  Tom Tromey  <tom@tromey.com>
10556
10557         * symtab.c (symtab_symbol_info): Fix typos.
10558
10559 2019-02-20  Tom Tromey  <tromey@adacore.com>
10560
10561         * findcmd.c (_initialize_mem_search): Use upper case for
10562         metasyntactic variables.
10563
10564 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10565
10566         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10567         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10568
10569 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10570
10571         * top.h (source_file_name): Change to std::string.
10572         * top.c (source_file_name): Likewise.
10573         (command_line_input): Adjust.
10574         * cli/cli-script.c (script_from_file): Adjust.
10575
10576 2019-02-19  Tom Tromey  <tromey@adacore.com>
10577
10578         * ravenscar-thread.c
10579         (ravenscar_thread_target::update_thread_list): Don't call
10580         ada_build_task_list.
10581         * ada-lang.h (ada_build_task_list): Don't declare.
10582         * ada-tasks.c (struct ada_tasks_inferior_data)
10583         <task_list_valid_p>: Now bool.
10584         (read_known_tasks, ada_task_list_changed)
10585         (ada_tasks_invalidate_inferior_data): Update.
10586         (read_known_tasks_array): Return bool.
10587         (read_known_tasks_list): Likewise.
10588         (read_known_tasks): Return void.
10589         (ada_build_task_list): Now static.
10590
10591 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10592
10593         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10594         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10595
10596 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10597
10598         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10599         variant for ada_tasks_pspace_data_handle and
10600         ada_tasks_inferior_data_handle.
10601         (ada_tasks_pspace_data_cleanup): New function.
10602         (ada_tasks_inferior_data_cleanup): New function.
10603
10604 2019-02-17  Tom Tromey  <tom@tromey.com>
10605
10606         * macrotab.h (macro_source_fullname): Return a std::string.
10607         * macrotab.c (macro_include, check_for_redefinition)
10608         (macro_undef, macro_lookup_definition, foreach_macro)
10609         (foreach_macro_in_scope): Update.
10610         (macro_source_fullname): Return a std::string.
10611         * macrocmd.c (show_pp_source_pos): Update.
10612
10613 2019-02-17  Tom Tromey  <tom@tromey.com>
10614
10615         * macrocmd.c (show_pp_source_pos): Style the file names.
10616
10617 2019-02-17  Tom Tromey  <tom@tromey.com>
10618
10619         PR tui/24197:
10620         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10621
10622 2019-02-17  Tom Tromey  <tom@tromey.com>
10623
10624         * ada-lang.c (user_select_syms): Use filtered printing.
10625         * utils.c (wrap_style): New global.
10626         (desired_style): Remove.
10627         (emit_style_escape): Add stream parameter.
10628         (set_output_style, reset_terminal_style, prompt_for_continue):
10629         Update.
10630         (flush_wrap_buffer): Only flush gdb_stdout.
10631         (wrap_here): Set wrap_style.
10632         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10633         treat escape sequences as a character.  Change when wrap buffer is
10634         flushed.
10635         (fputs_styled): Do not set the output style when the default is
10636         requested.
10637         * ui-style.h (struct ui_file_style) <is_default>: New method.
10638         * source.c (print_source_lines_base): Emit escape sequences in one
10639         piece.
10640
10641 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10642
10643         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10644         integers and enumeration types.
10645
10646 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10647
10648         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10649         instead of lookup_symbol_in_language
10650         (do_exact_match): New function.
10651         (ada_get_symbol_name_matcher): Return do_exact_match when
10652         doing a verbatim match.
10653
10654 2019-02-15  Tom Tromey  <tromey@adacore.com>
10655
10656         * ravenscar-thread.c (ravenscar_thread_target::resume)
10657         (ravenscar_thread_target::wait): Special case wildcard requests.
10658
10659 2019-02-15  Tom Tromey  <tromey@adacore.com>
10660
10661         * ravenscar-thread.c (base_ptid): Remove.
10662         (struct ravenscar_thread_target) <close>: New method.
10663         <m_base_ptid>: New member.
10664         <update_inferior_ptid, active_task, task_is_currently_active,
10665         runtime_initialized>: Declare methods.
10666         <ravenscar_thread_target>: Add constructor.
10667         (ravenscar_thread_target::task_is_currently_active)
10668         (ravenscar_thread_target::update_inferior_ptid)
10669         (ravenscar_runtime_initialized): Rename.  Now methods.
10670         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10671         (ravenscar_thread_target::update_thread_list): Update.
10672         (ravenscar_thread_target::active_task): Now method.
10673         (ravenscar_thread_target::store_registers)
10674         (ravenscar_thread_target::prepare_to_store)
10675         (ravenscar_thread_target::prepare_to_store)
10676         (ravenscar_thread_target::mourn_inferior): Update.
10677         (ravenscar_inferior_created): Use "new" to create target.
10678         (ravenscar_thread_target::get_ada_task_ptid): Update.
10679         (_initialize_ravenscar): Don't initialize base_ptid.
10680         (ravenscar_ops): Remove global.
10681
10682 2019-02-15  Tom Tromey  <tromey@adacore.com>
10683
10684         * target.h (push_target): Declare new overload.
10685         * target.c (push_target): New overload, taking an rvalue reference.
10686         * remote.c (remote_target::open_1): Use push_target overload.
10687         * corelow.c (core_target_open): Use push_target overload.
10688
10689 2019-02-15  Tom Tromey  <tromey@adacore.com>
10690
10691         * ravenscar-thread.c (is_ravenscar_task)
10692         (ravenscar_task_is_currently_active): Return bool.
10693         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10694         (_initialize_ravenscar): Remove "(void)".
10695         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10696         Return bool.
10697
10698 2019-02-15  Tom Tromey  <tromey@adacore.com>
10699
10700         * ravenscar-thread.c (ravenscar_runtime_initializer)
10701         (has_ravenscar_runtime, get_running_thread_id)
10702         (ravenscar_thread_target::resume): Fix indentation.
10703
10704 2019-02-15  Tom Tromey  <tromey@adacore.com>
10705
10706         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10707         from ravenscar_arch_ops.
10708         (sparc_ravenscar_ops::fetch_registers)
10709         (sparc_ravenscar_ops::store_registers): Now methods.
10710         (sparc_ravenscar_prepare_to_store): Remove.
10711         (sparc_ravenscar_ops): Redefine.
10712         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10713         methods and destructor.  Remove members.
10714         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10715         (ravenscar_thread_target::store_registers)
10716         (ravenscar_thread_target::prepare_to_store): Update.
10717         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10718         Remove.
10719         (struct ppc_ravenscar_powerpc_ops): Derive from
10720         ravenscar_arch_ops.
10721         (ppc_ravenscar_powerpc_ops::fetch_registers)
10722         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10723         (ppc_ravenscar_powerpc_ops): Redefine.
10724         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10725         (ppc_ravenscar_e500_ops::fetch_registers)
10726         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10727         (ppc_ravenscar_e500_ops): Redefine.
10728         * aarch64-ravenscar-thread.c
10729         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10730         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10731         (aarch64_ravenscar_fetch_registers)
10732         (aarch64_ravenscar_store_registers): Now methods.
10733         (aarch64_ravenscar_ops): Redefine.
10734
10735 2019-02-15  Tom Tromey  <tromey@adacore.com>
10736
10737         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10738         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10739         (ravenscar_thread_target::stopped_by_watchpoint)
10740         (ravenscar_thread_target::stopped_data_address)
10741         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10742
10743 2019-02-15  Tom Tromey  <tromey@adacore.com>
10744
10745         * ravenscar-thread.c: Fix some typos.
10746
10747 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10748             Tom Tromey  <tromey@adacore.com>
10749
10750         * ada-lang.c (ada_exception_sal): Change addr_string to a
10751         std::string.
10752         (create_ada_exception_catchpoint): Update.
10753
10754 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10755             Tom Tromey  <tromey@adacore.com>
10756
10757         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10758         (bp_location_ops): Remove.
10759         (base_breakpoint_allocate_location): Update.
10760         (free_bp_location): Update.
10761         * ada-lang.c (class ada_catchpoint_location)
10762         <ada_catchpoint_location>: Remove ops parameter.
10763         (ada_catchpoint_location_dtor): Remove.
10764         (ada_catchpoint_location_ops): Remove.
10765         (allocate_location_exception): Update.
10766         * breakpoint.h (struct bp_location_ops): Remove.
10767         (class bp_location) <bp_location>: Remove bp_location_ops
10768         parameter.
10769         <~bp_location>: Add destructor.
10770         <ops>: Remove.
10771
10772 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10773             Pedro Alves  <palves@redhat.com>
10774
10775         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10776         'PATH_MAX'.
10777
10778 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10779             Samuel Thibault  <samuel.thibault@gnu.org>
10780             Thomas Schwinge  <thomas@codesourcery.com>
10781
10782         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10783         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10784
10785 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10786
10787         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10788         (check_empty): Use "const char *".
10789
10790         * gnu-nat.c (gnu_nat_target::detach): Instead of
10791         'detach_inferior (pid)' call
10792         'detach_inferior (find_inferior_pid (pid))'.
10793
10794         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10795         'nat/fork-inferior.o'.
10796         * gnu-nat.c: #include "nat/fork-inferior.h".
10797
10798         * gnu-nat.c (gnu_nat_target::detach): Instead of
10799         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10800         * gnu-nat.h: #include "inf-child.h".
10801         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10802         'i386_gnu_nat_target::fetch_registers'.
10803         (gnu_store_registers): Rename/move to
10804         'i386_gnu_nat_target::store_registers'.
10805
10806         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10807         * gnu-nat.h (mach_thread_info): New function.
10808         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10809
10810         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10811
10812 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10813
10814         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10815
10816 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10817
10818         * windows-nat.c (windows_add_thread): Add new parameter
10819         "main_thread_p" with default value set to false.  Update
10820         function documentation as well as all callers.
10821         (windows_delete_thread): Likewise.
10822         (fake_create_process): Update call to windows_add_thread.
10823         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10824         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10825         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10826         call to windows_delete_thread.
10827
10828 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10829
10830         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10831
10832 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10833
10834         * symfile.c (find_separate_debug_file): Use canonical path of
10835         sysroot with child_path instead of gdb_sysroot if it is valid.
10836
10837 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10838
10839         * symfile.c (find_separate_debug_file): Use child_path to
10840         determine if an object file is under a sysroot.
10841
10842 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10843
10844         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10845         unittests/child-path-selftests.c.
10846         * common/pathstuff.c (child_path): New function.
10847         * common/pathstuff.h (child_path): New prototype.
10848         * unittests/child-path-selftests.c: New file.
10849
10850 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10851
10852         * symfile.c (find_separate_debug_file): Look for separate debug
10853         files in debug directories under the sysroot.
10854
10855 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10856
10857         * symtab.h (struct minimal_symbol data_p): New const method.
10858         (struct minimal_symbol text_p): Likewise.
10859         * symtab.c (output_source_filename): Use file name style
10860         to print file name.
10861         (print_symbol_info): Likewise.
10862         (print_msymbol_info): Use address style to print addresses.
10863         Use function name style to print executable text symbols.
10864         (expand_symtab_containing_pc): Use data_p.
10865         (find_pc_sect_compunit_symtab): Likewise.
10866
10867 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10868
10869         * breakpoint.c (describe_other_breakpoints): Use address style
10870         to print addresses.
10871         (say_where): Likewise.
10872
10873 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10874
10875         * ada-typeprint.c (print_func_type): Print function name
10876         style to print function name.
10877         * c-typeprint.c (c_print_type_1): Likewise.
10878
10879 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10880
10881         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10882         for execve.
10883
10884 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10885
10886         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10887         type_stack.
10888
10889 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10890
10891         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10892         TYPE_CODE_REF types.
10893
10894 2019-02-08  Jim Wilson  <jimw@sifive.com>
10895
10896         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10897         (riscv_linux_fregset): New.
10898         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10899
10900 2019-02-07  Tom Tromey  <tom@tromey.com>
10901
10902         * thread.c (thread_cancel_execution_command): Update.
10903         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10904         methods.
10905         (struct thread_fsm_ops): Remove.
10906         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10907         (thread_fsm_should_stop, thread_fsm_return_value)
10908         (thread_fsm_set_finished, thread_fsm_finished_p)
10909         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10910         Don't declare.
10911         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10912         * infrun.c (clear_proceed_status_thread)
10913         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10914         (print_stop_event): Update.
10915         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10916         Add constructor.
10917         (step_command_fsm_ops): Remove.
10918         (new_step_command_fsm): Remove.
10919         (step_1): Update.
10920         (step_command_fsm::should_stop): Rename from
10921         step_command_fsm_should_stop.
10922         (step_command_fsm::clean_up): Rename from
10923         step_command_fsm_clean_up.
10924         (step_command_fsm::do_async_reply_reason): Rename from
10925         step_command_fsm_async_reply_reason.
10926         (struct until_next_fsm): Inherit from thread_fsm.  Add
10927         constructor.
10928         (until_next_fsm_ops): Remove.
10929         (new_until_next_fsm): Remove.
10930         (until_next_fsm::should_stop): Rename from
10931         until_next_fsm_should_stop.
10932         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10933         (until_next_fsm::do_async_reply_reason): Rename from
10934         until_next_fsm_async_reply_reason.
10935         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10936         constructor.  Change type of breakpoint.
10937         (finish_command_fsm_ops): Remove.
10938         (new_finish_command_fsm): Remove.
10939         (finish_command_fsm::should_stop): Rename from
10940         finish_command_fsm_should_stop.
10941         (finish_command_fsm::clean_up): Rename from
10942         finish_command_fsm_clean_up.
10943         (finish_command_fsm::return_value): Rename from
10944         finish_command_fsm_return_value.
10945         (finish_command_fsm::do_async_reply_reason): Rename from
10946         finish_command_fsm_async_reply_reason.
10947         (finish_command): Update.
10948         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10949         Add constructor.
10950         (call_thread_fsm_ops): Remove.
10951         (call_thread_fsm::call_thread_fsm): Rename from
10952         new_call_thread_fsm.
10953         (call_thread_fsm::should_stop): Rename from
10954         call_thread_fsm_should_stop.
10955         (call_thread_fsm::should_notify_stop): Rename from
10956         call_thread_fsm_should_notify_stop.
10957         (run_inferior_call, call_function_by_hand_dummy): Update.
10958         * cli/cli-interp.c (should_print_stop_to_console): Update.
10959         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10960         Add constructor.  Change type of location_breakpoint,
10961         caller_breakpoint.
10962         (until_break_fsm_ops): Remove.
10963         (new_until_break_fsm): Remove.
10964         (until_break_fsm::should_stop): Rename from
10965         until_break_fsm_should_stop.
10966         (until_break_fsm::clean_up): Rename from
10967         until_break_fsm_clean_up.
10968         (until_break_fsm::do_async_reply_reason): Rename from
10969         until_break_fsm_async_reply_reason.
10970         (until_break_command): Update.
10971         * thread-fsm.c: Remove.
10972         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10973
10974 2019-02-07  Tom Tromey  <tom@tromey.com>
10975
10976         * yy-remap.h: Add include guard.
10977         * xtensa-tdep.h: Add include guard.
10978         * xcoffread.h: Rename include guard.
10979         * varobj-iter.h: Add include guard.
10980         * tui/tui.h: Rename include guard.
10981         * tui/tui-winsource.h: Rename include guard.
10982         * tui/tui-wingeneral.h: Rename include guard.
10983         * tui/tui-windata.h: Rename include guard.
10984         * tui/tui-win.h: Rename include guard.
10985         * tui/tui-stack.h: Rename include guard.
10986         * tui/tui-source.h: Rename include guard.
10987         * tui/tui-regs.h: Rename include guard.
10988         * tui/tui-out.h: Rename include guard.
10989         * tui/tui-layout.h: Rename include guard.
10990         * tui/tui-io.h: Rename include guard.
10991         * tui/tui-hooks.h: Rename include guard.
10992         * tui/tui-file.h: Rename include guard.
10993         * tui/tui-disasm.h: Rename include guard.
10994         * tui/tui-data.h: Rename include guard.
10995         * tui/tui-command.h: Rename include guard.
10996         * tic6x-tdep.h: Add include guard.
10997         * target/waitstatus.h: Rename include guard.
10998         * target/wait.h: Rename include guard.
10999         * target/target.h: Rename include guard.
11000         * target/resume.h: Rename include guard.
11001         * target-float.h: Rename include guard.
11002         * stabsread.h: Add include guard.
11003         * rs6000-tdep.h: Add include guard.
11004         * riscv-fbsd-tdep.h: Add include guard.
11005         * regformats/regdef.h: Rename include guard.
11006         * record.h: Rename include guard.
11007         * python/python.h: Rename include guard.
11008         * python/python-internal.h: Rename include guard.
11009         * python/py-stopevent.h: Rename include guard.
11010         * python/py-ref.h: Rename include guard.
11011         * python/py-record.h: Rename include guard.
11012         * python/py-record-full.h: Rename include guard.
11013         * python/py-record-btrace.h: Rename include guard.
11014         * python/py-instruction.h: Rename include guard.
11015         * python/py-events.h: Rename include guard.
11016         * python/py-event.h: Rename include guard.
11017         * procfs.h: Add include guard.
11018         * proc-utils.h: Add include guard.
11019         * p-lang.h: Add include guard.
11020         * or1k-tdep.h: Rename include guard.
11021         * observable.h: Rename include guard.
11022         * nto-tdep.h: Rename include guard.
11023         * nat/x86-linux.h: Rename include guard.
11024         * nat/x86-linux-dregs.h: Rename include guard.
11025         * nat/x86-gcc-cpuid.h: Add include guard.
11026         * nat/x86-dregs.h: Rename include guard.
11027         * nat/x86-cpuid.h: Rename include guard.
11028         * nat/ppc-linux.h: Rename include guard.
11029         * nat/mips-linux-watch.h: Rename include guard.
11030         * nat/linux-waitpid.h: Rename include guard.
11031         * nat/linux-ptrace.h: Rename include guard.
11032         * nat/linux-procfs.h: Rename include guard.
11033         * nat/linux-osdata.h: Rename include guard.
11034         * nat/linux-nat.h: Rename include guard.
11035         * nat/linux-namespaces.h: Rename include guard.
11036         * nat/linux-btrace.h: Rename include guard.
11037         * nat/glibc_thread_db.h: Rename include guard.
11038         * nat/gdb_thread_db.h: Rename include guard.
11039         * nat/gdb_ptrace.h: Rename include guard.
11040         * nat/fork-inferior.h: Rename include guard.
11041         * nat/amd64-linux-siginfo.h: Rename include guard.
11042         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11043         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11044         * nat/aarch64-linux.h: Rename include guard.
11045         * nat/aarch64-linux-hw-point.h: Rename include guard.
11046         * mn10300-tdep.h: Add include guard.
11047         * mips-linux-tdep.h: Add include guard.
11048         * mi/mi-parse.h: Rename include guard.
11049         * mi/mi-out.h: Rename include guard.
11050         * mi/mi-main.h: Rename include guard.
11051         * mi/mi-interp.h: Rename include guard.
11052         * mi/mi-getopt.h: Rename include guard.
11053         * mi/mi-console.h: Rename include guard.
11054         * mi/mi-common.h: Rename include guard.
11055         * mi/mi-cmds.h: Rename include guard.
11056         * mi/mi-cmd-break.h: Rename include guard.
11057         * m2-lang.h: Add include guard.
11058         * location.h: Rename include guard.
11059         * linux-record.h: Rename include guard.
11060         * linux-nat.h: Add include guard.
11061         * linux-fork.h: Add include guard.
11062         * i386-darwin-tdep.h: Rename include guard.
11063         * hppa-linux-offsets.h: Add include guard.
11064         * guile/guile.h: Rename include guard.
11065         * guile/guile-internal.h: Rename include guard.
11066         * gnu-nat.h: Rename include guard.
11067         * gdb-stabs.h: Rename include guard.
11068         * frv-tdep.h: Add include guard.
11069         * f-lang.h: Add include guard.
11070         * event-loop.h: Add include guard.
11071         * darwin-nat.h: Rename include guard.
11072         * cp-abi.h: Rename include guard.
11073         * config/sparc/nm-sol2.h: Rename include guard.
11074         * config/nm-nto.h: Rename include guard.
11075         * config/nm-linux.h: Add include guard.
11076         * config/i386/nm-i386gnu.h: Rename include guard.
11077         * config/djgpp/nl_types.h: Rename include guard.
11078         * config/djgpp/langinfo.h: Rename include guard.
11079         * compile/gcc-cp-plugin.h: Add include guard.
11080         * compile/gcc-c-plugin.h: Add include guard.
11081         * compile/compile.h: Rename include guard.
11082         * compile/compile-object-run.h: Rename include guard.
11083         * compile/compile-object-load.h: Rename include guard.
11084         * compile/compile-internal.h: Rename include guard.
11085         * compile/compile-cplus.h: Rename include guard.
11086         * compile/compile-c.h: Rename include guard.
11087         * common/xml-utils.h: Rename include guard.
11088         * common/x86-xstate.h: Rename include guard.
11089         * common/version.h: Rename include guard.
11090         * common/vec.h: Rename include guard.
11091         * common/tdesc.h: Rename include guard.
11092         * common/selftest.h: Rename include guard.
11093         * common/scoped_restore.h: Rename include guard.
11094         * common/scoped_mmap.h: Rename include guard.
11095         * common/scoped_fd.h: Rename include guard.
11096         * common/safe-iterator.h: Rename include guard.
11097         * common/run-time-clock.h: Rename include guard.
11098         * common/refcounted-object.h: Rename include guard.
11099         * common/queue.h: Rename include guard.
11100         * common/ptid.h: Rename include guard.
11101         * common/print-utils.h: Rename include guard.
11102         * common/preprocessor.h: Rename include guard.
11103         * common/pathstuff.h: Rename include guard.
11104         * common/observable.h: Rename include guard.
11105         * common/netstuff.h: Rename include guard.
11106         * common/job-control.h: Rename include guard.
11107         * common/host-defs.h: Rename include guard.
11108         * common/gdb_wait.h: Rename include guard.
11109         * common/gdb_vecs.h: Rename include guard.
11110         * common/gdb_unlinker.h: Rename include guard.
11111         * common/gdb_unique_ptr.h: Rename include guard.
11112         * common/gdb_tilde_expand.h: Rename include guard.
11113         * common/gdb_sys_time.h: Rename include guard.
11114         * common/gdb_string_view.h: Rename include guard.
11115         * common/gdb_splay_tree.h: Rename include guard.
11116         * common/gdb_setjmp.h: Rename include guard.
11117         * common/gdb_ref_ptr.h: Rename include guard.
11118         * common/gdb_optional.h: Rename include guard.
11119         * common/gdb_locale.h: Rename include guard.
11120         * common/gdb_assert.h: Rename include guard.
11121         * common/filtered-iterator.h: Rename include guard.
11122         * common/filestuff.h: Rename include guard.
11123         * common/fileio.h: Rename include guard.
11124         * common/environ.h: Rename include guard.
11125         * common/common-utils.h: Rename include guard.
11126         * common/common-types.h: Rename include guard.
11127         * common/common-regcache.h: Rename include guard.
11128         * common/common-inferior.h: Rename include guard.
11129         * common/common-gdbthread.h: Rename include guard.
11130         * common/common-exceptions.h: Rename include guard.
11131         * common/common-defs.h: Rename include guard.
11132         * common/common-debug.h: Rename include guard.
11133         * common/cleanups.h: Rename include guard.
11134         * common/buffer.h: Rename include guard.
11135         * common/btrace-common.h: Rename include guard.
11136         * common/break-common.h: Rename include guard.
11137         * cli/cli-utils.h: Rename include guard.
11138         * cli/cli-style.h: Rename include guard.
11139         * cli/cli-setshow.h: Rename include guard.
11140         * cli/cli-script.h: Rename include guard.
11141         * cli/cli-interp.h: Rename include guard.
11142         * cli/cli-decode.h: Rename include guard.
11143         * cli/cli-cmds.h: Rename include guard.
11144         * charset-list.h: Add include guard.
11145         * buildsym-legacy.h: Rename include guard.
11146         * bfin-tdep.h: Add include guard.
11147         * ax.h: Rename include guard.
11148         * arm-linux-tdep.h: Add include guard.
11149         * arm-fbsd-tdep.h: Add include guard.
11150         * arch/xtensa.h: Rename include guard.
11151         * arch/tic6x.h: Add include guard.
11152         * arch/i386.h: Add include guard.
11153         * arch/arm.h: Rename include guard.
11154         * arch/arm-linux.h: Rename include guard.
11155         * arch/arm-get-next-pcs.h: Rename include guard.
11156         * arch/amd64.h: Add include guard.
11157         * arch/aarch64-insn.h: Rename include guard.
11158         * arch-utils.h: Rename include guard.
11159         * annotate.h: Add include guard.
11160         * amd64-darwin-tdep.h: Rename include guard.
11161         * aarch64-linux-tdep.h: Add include guard.
11162         * aarch64-fbsd-tdep.h: Add include guard.
11163         * aarch32-linux-nat.h: Add include guard.
11164
11165 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11166
11167         * macrotab.c (macro_define_internal): New function that
11168         factorizes macro_define_object_internal and macro_define_function
11169         code.
11170         (macro_define_object_internal): Use macro_define_internal.
11171         (macro_define_function): Likewise.
11172
11173 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11174
11175         * macrocmd.c (extract_identifier): Return
11176         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11177         callers.
11178
11179 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11180
11181         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11182
11183 2019-02-05  Tom Tromey  <tom@tromey.com>
11184
11185         * target.c (target_stack::unpush): Move assertion earlier.
11186
11187 2019-01-30  Tom Tromey  <tom@tromey.com>
11188
11189         PR python/23615:
11190         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11191         (gdbpy_parse_and_eval): Likewise.
11192         * python/python-internal.h (gdbpy_allow_threads): New class.
11193
11194 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11195
11196         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11197         (aarch64_fbsd_fpregmap): Move earlier.
11198         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11199         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11200         instead of individual calls to trad_frame_set_reg_addr.
11201         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11202         earlier.
11203         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11204         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11205         instead of individual calls to trad_frame_set_reg_addr.
11206
11207 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11208
11209         * CONTRIBUTE: Replace contribution list with wiki link.
11210
11211 2019-01-25  Tom Tromey  <tom@tromey.com>
11212
11213         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11214
11215 2019-01-25  Tom Tromey  <tom@tromey.com>
11216
11217         * xtensa-linux-nat.c: Fix common/ includes.
11218         * xml-support.h: Fix common/ includes.
11219         * xml-support.c: Fix common/ includes.
11220         * x86-linux-nat.c: Fix common/ includes.
11221         * windows-nat.c: Fix common/ includes.
11222         * varobj.h: Fix common/ includes.
11223         * varobj.c: Fix common/ includes.
11224         * value.c: Fix common/ includes.
11225         * valops.c: Fix common/ includes.
11226         * utils.c: Fix common/ includes.
11227         * unittests/xml-utils-selftests.c: Fix common/ includes.
11228         * unittests/utils-selftests.c: Fix common/ includes.
11229         * unittests/unpack-selftests.c: Fix common/ includes.
11230         * unittests/tracepoint-selftests.c: Fix common/ includes.
11231         * unittests/style-selftests.c: Fix common/ includes.
11232         * unittests/string_view-selftests.c: Fix common/ includes.
11233         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11234         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11235         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11236         * unittests/rsp-low-selftests.c: Fix common/ includes.
11237         * unittests/parse-connection-spec-selftests.c: Fix common/
11238         includes.
11239         * unittests/optional-selftests.c: Fix common/ includes.
11240         * unittests/offset-type-selftests.c: Fix common/ includes.
11241         * unittests/observable-selftests.c: Fix common/ includes.
11242         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11243         * unittests/memrange-selftests.c: Fix common/ includes.
11244         * unittests/memory-map-selftests.c: Fix common/ includes.
11245         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11246         * unittests/function-view-selftests.c: Fix common/ includes.
11247         * unittests/environ-selftests.c: Fix common/ includes.
11248         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11249         * unittests/common-utils-selftests.c: Fix common/ includes.
11250         * unittests/cli-utils-selftests.c: Fix common/ includes.
11251         * unittests/array-view-selftests.c: Fix common/ includes.
11252         * ui-file.c: Fix common/ includes.
11253         * tui/tui-io.c: Fix common/ includes.
11254         * tracepoint.h: Fix common/ includes.
11255         * tracepoint.c: Fix common/ includes.
11256         * tracefile-tfile.c: Fix common/ includes.
11257         * top.h: Fix common/ includes.
11258         * top.c: Fix common/ includes.
11259         * thread.c: Fix common/ includes.
11260         * target/waitstatus.h: Fix common/ includes.
11261         * target/waitstatus.c: Fix common/ includes.
11262         * target.h: Fix common/ includes.
11263         * target.c: Fix common/ includes.
11264         * target-memory.c: Fix common/ includes.
11265         * target-descriptions.c: Fix common/ includes.
11266         * symtab.h: Fix common/ includes.
11267         * symfile.c: Fix common/ includes.
11268         * stap-probe.c: Fix common/ includes.
11269         * spu-linux-nat.c: Fix common/ includes.
11270         * sparc-nat.c: Fix common/ includes.
11271         * source.c: Fix common/ includes.
11272         * solib.c: Fix common/ includes.
11273         * solib-target.c: Fix common/ includes.
11274         * ser-unix.c: Fix common/ includes.
11275         * ser-tcp.c: Fix common/ includes.
11276         * ser-pipe.c: Fix common/ includes.
11277         * ser-base.c: Fix common/ includes.
11278         * selftest-arch.c: Fix common/ includes.
11279         * s12z-tdep.c: Fix common/ includes.
11280         * rust-exp.y: Fix common/ includes.
11281         * rs6000-aix-tdep.c: Fix common/ includes.
11282         * riscv-tdep.c: Fix common/ includes.
11283         * remote.c: Fix common/ includes.
11284         * remote-notif.h: Fix common/ includes.
11285         * remote-fileio.h: Fix common/ includes.
11286         * remote-fileio.c: Fix common/ includes.
11287         * regcache.h: Fix common/ includes.
11288         * regcache.c: Fix common/ includes.
11289         * record-btrace.c: Fix common/ includes.
11290         * python/python.c: Fix common/ includes.
11291         * python/py-type.c: Fix common/ includes.
11292         * python/py-inferior.c: Fix common/ includes.
11293         * progspace.h: Fix common/ includes.
11294         * producer.c: Fix common/ includes.
11295         * procfs.c: Fix common/ includes.
11296         * proc-api.c: Fix common/ includes.
11297         * printcmd.c: Fix common/ includes.
11298         * ppc-linux-nat.c: Fix common/ includes.
11299         * parser-defs.h: Fix common/ includes.
11300         * osdata.c: Fix common/ includes.
11301         * obsd-nat.c: Fix common/ includes.
11302         * nat/x86-linux.c: Fix common/ includes.
11303         * nat/x86-linux-dregs.c: Fix common/ includes.
11304         * nat/x86-dregs.h: Fix common/ includes.
11305         * nat/x86-dregs.c: Fix common/ includes.
11306         * nat/ppc-linux.c: Fix common/ includes.
11307         * nat/mips-linux-watch.h: Fix common/ includes.
11308         * nat/mips-linux-watch.c: Fix common/ includes.
11309         * nat/linux-waitpid.c: Fix common/ includes.
11310         * nat/linux-ptrace.h: Fix common/ includes.
11311         * nat/linux-ptrace.c: Fix common/ includes.
11312         * nat/linux-procfs.c: Fix common/ includes.
11313         * nat/linux-personality.c: Fix common/ includes.
11314         * nat/linux-osdata.c: Fix common/ includes.
11315         * nat/linux-namespaces.c: Fix common/ includes.
11316         * nat/linux-btrace.h: Fix common/ includes.
11317         * nat/linux-btrace.c: Fix common/ includes.
11318         * nat/fork-inferior.c: Fix common/ includes.
11319         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11320         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11321         * nat/aarch64-linux.c: Fix common/ includes.
11322         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11323         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11324         * namespace.h: Fix common/ includes.
11325         * mips-linux-tdep.c: Fix common/ includes.
11326         * minsyms.c: Fix common/ includes.
11327         * mi/mi-parse.h: Fix common/ includes.
11328         * mi/mi-main.c: Fix common/ includes.
11329         * mi/mi-cmd-env.c: Fix common/ includes.
11330         * memrange.h: Fix common/ includes.
11331         * memattr.c: Fix common/ includes.
11332         * maint.h: Fix common/ includes.
11333         * maint.c: Fix common/ includes.
11334         * main.c: Fix common/ includes.
11335         * machoread.c: Fix common/ includes.
11336         * location.c: Fix common/ includes.
11337         * linux-thread-db.c: Fix common/ includes.
11338         * linux-nat.c: Fix common/ includes.
11339         * linux-fork.c: Fix common/ includes.
11340         * inline-frame.c: Fix common/ includes.
11341         * infrun.c: Fix common/ includes.
11342         * inflow.c: Fix common/ includes.
11343         * inferior.h: Fix common/ includes.
11344         * inferior.c: Fix common/ includes.
11345         * infcmd.c: Fix common/ includes.
11346         * inf-ptrace.c: Fix common/ includes.
11347         * inf-child.c: Fix common/ includes.
11348         * ia64-linux-nat.c: Fix common/ includes.
11349         * i387-tdep.c: Fix common/ includes.
11350         * i386-tdep.c: Fix common/ includes.
11351         * i386-linux-tdep.c: Fix common/ includes.
11352         * i386-linux-nat.c: Fix common/ includes.
11353         * i386-go32-tdep.c: Fix common/ includes.
11354         * i386-fbsd-tdep.c: Fix common/ includes.
11355         * i386-fbsd-nat.c: Fix common/ includes.
11356         * guile/scm-type.c: Fix common/ includes.
11357         * guile/guile.c: Fix common/ includes.
11358         * go32-nat.c: Fix common/ includes.
11359         * gnu-nat.c: Fix common/ includes.
11360         * gdbthread.h: Fix common/ includes.
11361         * gdbarch-selftests.c: Fix common/ includes.
11362         * gdb_usleep.c: Fix common/ includes.
11363         * gdb_select.h: Fix common/ includes.
11364         * gdb_bfd.c: Fix common/ includes.
11365         * gcore.c: Fix common/ includes.
11366         * fork-child.c: Fix common/ includes.
11367         * findvar.c: Fix common/ includes.
11368         * fbsd-nat.c: Fix common/ includes.
11369         * event-top.c: Fix common/ includes.
11370         * event-loop.c: Fix common/ includes.
11371         * dwarf2read.c: Fix common/ includes.
11372         * dwarf2loc.c: Fix common/ includes.
11373         * dwarf2-frame.c: Fix common/ includes.
11374         * dwarf-index-cache.c: Fix common/ includes.
11375         * dtrace-probe.c: Fix common/ includes.
11376         * disasm-selftests.c: Fix common/ includes.
11377         * defs.h: Fix common/ includes.
11378         * csky-tdep.c: Fix common/ includes.
11379         * cp-valprint.c: Fix common/ includes.
11380         * cp-support.h: Fix common/ includes.
11381         * cp-support.c: Fix common/ includes.
11382         * corelow.c: Fix common/ includes.
11383         * completer.h: Fix common/ includes.
11384         * completer.c: Fix common/ includes.
11385         * compile/compile.c: Fix common/ includes.
11386         * compile/compile-loc2c.c: Fix common/ includes.
11387         * compile/compile-cplus-types.c: Fix common/ includes.
11388         * compile/compile-cplus-symbols.c: Fix common/ includes.
11389         * command.h: Fix common/ includes.
11390         * cli/cli-dump.c: Fix common/ includes.
11391         * cli/cli-cmds.c: Fix common/ includes.
11392         * charset.c: Fix common/ includes.
11393         * build-id.c: Fix common/ includes.
11394         * btrace.h: Fix common/ includes.
11395         * btrace.c: Fix common/ includes.
11396         * breakpoint.h: Fix common/ includes.
11397         * breakpoint.c: Fix common/ includes.
11398         * ax.h:
11399         (enum agent_op): Fix common/ includes.
11400         * ax-general.c (struct aop_map): Fix common/ includes.
11401         * ax-gdb.c: Fix common/ includes.
11402         * auxv.c: Fix common/ includes.
11403         * auto-load.c: Fix common/ includes.
11404         * arm-tdep.c: Fix common/ includes.
11405         * arch/riscv.c: Fix common/ includes.
11406         * arch/ppc-linux-common.c: Fix common/ includes.
11407         * arch/i386.c: Fix common/ includes.
11408         * arch/arm.c: Fix common/ includes.
11409         * arch/arm-linux.c: Fix common/ includes.
11410         * arch/arm-get-next-pcs.c: Fix common/ includes.
11411         * arch/amd64.c: Fix common/ includes.
11412         * arch/aarch64.c: Fix common/ includes.
11413         * arch/aarch64-insn.c: Fix common/ includes.
11414         * arch-utils.c: Fix common/ includes.
11415         * amd64-windows-tdep.c: Fix common/ includes.
11416         * amd64-tdep.c: Fix common/ includes.
11417         * amd64-sol2-tdep.c: Fix common/ includes.
11418         * amd64-obsd-tdep.c: Fix common/ includes.
11419         * amd64-nbsd-tdep.c: Fix common/ includes.
11420         * amd64-linux-tdep.c: Fix common/ includes.
11421         * amd64-linux-nat.c: Fix common/ includes.
11422         * amd64-fbsd-tdep.c: Fix common/ includes.
11423         * amd64-fbsd-nat.c: Fix common/ includes.
11424         * amd64-dicos-tdep.c: Fix common/ includes.
11425         * amd64-darwin-tdep.c: Fix common/ includes.
11426         * agent.c: Fix common/ includes.
11427         * ada-lang.h: Fix common/ includes.
11428         * ada-lang.c: Fix common/ includes.
11429         * aarch64-tdep.c: Fix common/ includes.
11430
11431 2019-01-25  Tom Tromey  <tom@tromey.com>
11432
11433         * common/create-version.sh: Use common/version.h.
11434
11435 2019-01-24  Pedro Alves  <palves@redhat.com>
11436
11437         * infrun.c (signal_stop, signal_print, signal_program)
11438         (signal_catch, signal_pass): Now arrays instead of pointers.
11439         (update_signals_program_target, do_target_resume)
11440         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11441         * linux-nat.c (linux_nat_target::pass_signals)
11442         (linux_nat_target::create_inferior, linux_nat_target::attach):
11443         Adjust.
11444         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11445         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11446         * procfs.c (procfs_target::pass_signals): Adjust.
11447         * record-full.c (record_full_target::resume): Adjust.
11448         * remote.c (remote_target::pass_signals)
11449         (remote_target::program_signals): Adjust.
11450         * target-debug.h (target_debug_print_signals): Now takes a
11451         gdb::array_view as parameter.  Adjust.
11452         * target.h (target_ops) <pass_signals, program_signals>: Replace
11453         pointer and length parameters with gdb::array_view.
11454         (target_pass_signals, target_program_signals): Likewise.
11455         * target-delegates.c: Regenerate.
11456
11457 2019-01-24  Pedro Alves  <palves@redhat.com>
11458
11459         * common/forward-scope-exit.h
11460         (forward_scope_exit::forward_scope_exit): Pass arguments to
11461         m_bind_function directly, instead of creating a std::bind and
11462         copying that.
11463
11464 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11465
11466         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11467         for static members.
11468         (pass_in_v_vfp_candidate): Likewise.
11469
11470 2019-01-23  Tom Tromey  <tom@tromey.com>
11471             Pedro Alves  <palves@redhat.com>
11472
11473         * regcache.c (class regcache_invalidator): Remove.
11474         (regcache::raw_write): Use make_scope_exit.
11475
11476 2019-01-23  Tom Tromey  <tom@tromey.com>
11477
11478         * ui-out.h (class ui_out_emit_type): Update comment.
11479
11480 2019-01-23  Tom Tromey  <tom@tromey.com>
11481
11482         * infrun.c (fetch_inferior_event): Update comment.
11483
11484 2019-01-23  Tom Tromey  <tom@tromey.com>
11485             Pedro Alves  <palves@redhat.com>
11486
11487         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11488         parameter.
11489         (fetch_inferior_event): Use SCOPE_EXIT.
11490
11491
11492 2019-01-23  Tom Tromey  <tom@tromey.com>
11493             Pedro Alves  <palves@redhat.com>
11494
11495         * infrun.c (disable_thread_events): Delete.
11496         (stop_all_threads): Use SCOPE_EXIT.
11497
11498 2019-01-23  Tom Tromey  <tom@tromey.com>
11499             Pedro Alves  <palves@redhat.com>
11500
11501         * symfile.c: Include forward-scope-exit.h.
11502         (clear_symtab_users_cleanup): Replace forward declaration with
11503         a FORWARD_SCOPE_EXIT.
11504         (syms_from_objfile_1): Use the forward_scope_exit and
11505         gdb::optional instead of cleanup_function.
11506         (reread_symbols): Use the forward_scope_exit instead of
11507         cleanup_function.
11508         (clear_symtab_users_cleanup): Remove function.
11509
11510 2019-01-23  Tom Tromey  <tom@tromey.com>
11511             Pedro Alves  <palves@redhat.com>
11512
11513         * linux-nat.c: Include scope-exit.h.
11514         (cleanup_target_stop): Remove.
11515         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11516         SCOPE_EXIT.
11517
11518 2019-01-23  Tom Tromey  <tom@tromey.com>
11519             Pedro Alves  <palves@redhat.com>
11520
11521         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11522         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11523
11524 2019-01-23  Tom Tromey  <tom@tromey.com>
11525             Andrew Burgess  <andrew.burgess@embecosm.com>
11526             Pedro Alves  <palves@redhat.com>
11527
11528         * infrun.c (fetch_inferior_event): Use scope_exit.
11529         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11530         * top.c (execute_command): Use scope_exit.
11531         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11532         * utils.c (do_bpstat_clear_actions_cleanup)
11533         (make_bpstat_clear_actions_cleanup): Remove.
11534
11535 2019-01-23  Tom Tromey  <tom@tromey.com>
11536             Pedro Alves  <palves@redhat.com>
11537
11538         * infrun.c: Include "common/scope-exit.h"
11539         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11540         (wait_for_inferior): Use SCOPE_EXIT.
11541         (fetch_inferior_event): Use scope_exit.
11542
11543 2019-01-23  Tom Tromey  <tom@tromey.com>
11544             Pedro Alves  <palves@redhat.com>
11545
11546         * breakpoint.c (create_breakpoint): Remove cleanup.
11547
11548 2019-01-23  Tom Tromey  <tom@tromey.com>
11549             Andrew Burgess  <andrew.burgess@embecosm.com>
11550             Pedro Alves  <palves@redhat.com>
11551
11552 2019-01-23  Pedro Alves  <palves@redhat.com>
11553
11554         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11555
11556 2019-01-23  Pedro Alves  <palves@redhat.com>
11557             Andrew Burgess  <andrew.burgess@embecosm.com>
11558
11559         * gdbthread.h: Include "common/forward-scope-exit.h".
11560         (scoped_finish_thread_state): Redefine custom class in terms of
11561         forward_scope_exit.
11562
11563 2019-01-23  Pedro Alves  <palves@redhat.com>
11564             Andrew Burgess  <andrew.burgess@embecosm.com>
11565
11566         * common/forward-scope-exit.h: New file.
11567
11568 2019-01-23  Pedro Alves  <palves@redhat.com>
11569             Andrew Burgess  <andrew.burgess@embecosm.com>
11570             Tom Tromey  <tom@tromey.com>
11571
11572         * common/scope-exit.h: New file.
11573
11574 2019-01-23  Pedro Alves  <palves@redhat.com>
11575
11576         * common/preprocessor.h (ESC): Rename to ...
11577         (ESC_PARENS): ... this.
11578         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11579         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11580
11581 2019-01-23  Tom Tromey  <tom@tromey.com>
11582
11583         * language.h (class scoped_switch_to_sym_language_if_auto):
11584         Initialize m_lang in both cases.
11585
11586 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11587
11588         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11589         with XCNEW.
11590
11591 2019-01-22  Tom Tromey  <tom@tromey.com>
11592
11593         * corelow.c: Do not include sys/file.h.
11594
11595 2019-01-22  Tom Tromey  <tom@tromey.com>
11596
11597         * tui/tui-wingeneral.h: Include gdb_curses.h.
11598
11599 2019-01-22  Tom Tromey  <tom@tromey.com>
11600
11601         * source-cache.h (class source_cache) <get_source_lines,
11602         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11603
11604 2019-01-22  Tom Tromey  <tom@tromey.com>
11605
11606         * remote-fileio.h (struct remote_target): Declare.
11607
11608 2019-01-22  Tom Tromey  <tom@tromey.com>
11609
11610         * python/py-arch.c: Do not include py-ref.h.
11611         * python/py-bpevent.c: Do not include py-ref.h.
11612         * python/py-cmd.c: Do not include py-ref.h.
11613         * python/py-continueevent.c: Do not include py-ref.h.
11614         * python/py-event.h: Do not include py-ref.h.
11615         * python/py-evtregistry.c: Do not include py-ref.h.
11616         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11617         * python/py-frame.c: Do not include py-ref.h.
11618         * python/py-framefilter.c: Do not include py-ref.h.
11619         * python/py-function.c: Do not include py-ref.h.
11620         * python/py-infevents.c: Do not include py-ref.h.
11621         * python/py-linetable.c: Do not include py-ref.h.
11622         * python/py-objfile.c: Do not include py-ref.h.
11623         * python/py-param.c: Do not include py-ref.h.
11624         * python/py-prettyprint.c: Do not include py-ref.h.
11625         * python/py-progspace.c: Do not include py-ref.h.
11626         * python/py-symbol.c: Do not include py-ref.h.
11627         * python/py-symtab.c: Do not include py-ref.h.
11628         * python/py-type.c: Do not include py-ref.h.
11629         * python/py-unwind.c: Do not include py-ref.h.
11630         * python/py-utils.c: Do not include py-ref.h.
11631         * python/py-value.c: Do not include py-ref.h.
11632         * python/py-varobj.c: Do not include py-ref.h.
11633         * python/py-xmethods.c: Do not include py-ref.h.
11634         * python/python.c: Do not include py-ref.h.
11635         * varobj.c: Do not include py-ref.h.
11636
11637 2019-01-22  Tom Tromey  <tom@tromey.com>
11638
11639         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11640         keyword for bcache.
11641
11642 2019-01-22  Tom Tromey  <tom@tromey.com>
11643
11644         * compile/compile-cplus-types.c: Remove a comment by #include.
11645
11646 2019-01-22  Tom Tromey  <tom@tromey.com>
11647
11648         * compile/gcc-c-plugin.h: Include compile-internal.h.
11649
11650 2019-01-22  Tom Tromey  <tom@tromey.com>
11651
11652         * stabsread.c (EXTERN): Do not define.
11653         (symnum, next_symbol_text_func, processing_gcc_compilation)
11654         (within_function, global_sym_chain, global_stabs)
11655         (previous_stab_code, this_object_header_files)
11656         (n_this_object_header_files)
11657         (n_allocated_this_object_header_files): Define.
11658         * stabsread.h (EXTERN): Never define.  Use "extern".
11659
11660 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11661
11662         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11663         history_value.
11664
11665 2019-01-21  Tom Tromey  <tom@tromey.com>
11666
11667         * ui-out.c: Fix includes.
11668         * tui/tui-source.c: Fix includes.
11669         * target.c: Fix includes.
11670         * remote.c: Fix includes.
11671         * regcache.c: Fix includes.
11672         * python/py-block.c: Fix includes.
11673         * printcmd.c: Fix includes.
11674         * or1k-tdep.c: Fix includes.
11675         * mi/mi-main.c: Fix includes.
11676         * m32r-tdep.c: Fix includes.
11677         * csky-tdep.c: Fix includes.
11678         * compile/compile-cplus-types.c: Fix includes.
11679         * cli/cli-interp.c: Fix includes.
11680
11681 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11682
11683         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11684         for padding.
11685
11686 2019-01-16  Tom Tromey  <tom@tromey.com>
11687
11688         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11689         earlier.
11690         (struct objfile) <msymbols_range>: Move from top level.
11691         <msymbols>: New method.
11692         (class objfile_msymbols): Remove.
11693         * symtab.c (default_collect_symbol_completion_matches_break_on):
11694         Update.
11695         * symmisc.c (dump_msymbols): Update.
11696         * stabsread.c (scan_file_globals): Update.
11697         * objc-lang.c (info_selectors_command, info_classes_command)
11698         (find_methods): Update.
11699         * minsyms.c (find_solib_trampoline_target): Update.
11700         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11701         * coffread.c (coff_symfile_read): Update.
11702         * ada-lang.c (ada_lookup_simple_minsym)
11703         (ada_collect_symbol_completion_matches): Update.
11704
11705 2019-01-16  Tom Tromey  <tom@tromey.com>
11706
11707         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11708         type.  Remove no-argument constructor.
11709         <iterator::operator++>: Simplify.
11710         <begin>: Update.
11711         <end>: Use minimal_symbol_count.
11712
11713 2019-01-16  Tom Tromey  <tom@tromey.com>
11714
11715         * objfiles.h (struct objfile) <psymtabs>: New method.
11716         (class objfile_psymtabs): Remove.
11717         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11718         typedef.
11719         <range>: New method.
11720         (require_partial_symbols): Change return type.
11721         * psymtab.c (require_partial_symbols)
11722         (psym_expand_symtabs_matching): Update.
11723         * mdebugread.c (parse_partial_symbols): Update.
11724         * dbxread.c (dbx_end_psymtab): Update.
11725
11726 2019-01-15  Tom Tromey  <tom@tromey.com>
11727
11728         * symtab.c (lookup_objfile_from_block)
11729         (lookup_symbol_in_objfile_symtabs)
11730         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11731         (find_line_symtab, info_sources_command)
11732         (default_collect_symbol_completion_matches_break_on)
11733         (make_source_files_completion_list): Update.
11734         * symmisc.c (print_objfile_statistics, dump_objfile)
11735         (maintenance_print_symbols, maintenance_info_symtabs)
11736         (maintenance_check_symtabs, maintenance_info_line_tables):
11737         Update.
11738         * source.c (select_source_symtab)
11739         (forget_cached_source_info_for_objfile): Update.
11740         * objfiles.h (class objfile_compunits): Remove.
11741         (struct objfile) <compunits_range>: New typedef.
11742         (compunits): New method.
11743         * objfiles.c (objfile_relocate1): Update.
11744         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11745         * maint.c (count_symtabs_and_blocks): Update.
11746         * linespec.c (iterate_over_all_matching_symtabs): Update.
11747         * cp-support.c (add_symbol_overload_list_qualified): Update.
11748         * coffread.c (coff_symtab_read): Update.
11749         * ada-lang.c (add_nonlocal_symbols)
11750         (ada_collect_symbol_completion_matches)
11751         (ada_add_global_exceptions): Update.
11752
11753 2019-01-15  Tom Tromey  <tom@tromey.com>
11754
11755         * progspace.h (program_space) <objfiles_safe_range>: New
11756         typedef.
11757         <objfiles_safe>: New method.
11758         * objfiles.h (class all_objfiles_safe): Remove.
11759         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11760         * jit.c (jit_inferior_exit_hook): Update.
11761
11762 2019-01-17  Tom Tromey  <tom@tromey.com>
11763
11764         * progspace.h (program_space) <objfiles_range>: New typedef.
11765         <objfiles>: New method.
11766         <objfiles_head>: Rename from objfiles.
11767         (object_files): Update.
11768         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11769         * guile/scm-pretty-print.c
11770         (ppscm_find_pretty_printer_from_objfiles): Update.
11771         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11772         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11773         Update.
11774         * python/py-progspace.c (pspy_get_objfiles): Update.
11775         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11776         Update.
11777         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11778         (objfpy_lookup_objfile_by_build_id): Update.
11779         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11780         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11781         Update.
11782         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11783         (expand_symtab_containing_pc, lookup_objfile_from_block)
11784         (lookup_static_symbol, basic_lookup_transparent_type)
11785         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11786         (find_line_symtab, info_sources_command)
11787         (default_collect_symbol_completion_matches_break_on)
11788         (make_source_files_completion_list, find_main_name): Update.
11789         * symmisc.c (print_symbol_bcache_statistics)
11790         (print_objfile_statistics, maintenance_print_symbols)
11791         (maintenance_print_msymbols, maintenance_print_objfiles)
11792         (maintenance_info_symtabs, maintenance_check_symtabs)
11793         (maintenance_expand_symtabs, maintenance_info_line_tables):
11794         Update.
11795         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11796         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11797         (map_overlay_command, unmap_overlay_command)
11798         (simple_overlay_update, expand_symtabs_matching)
11799         (map_symbol_filenames): Update.
11800         * symfile-debug.c (set_debug_symfile): Update.
11801         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11802         Update.
11803         * source.c (select_source_symtab, forget_cached_source_info):
11804         Update.
11805         * solib.c (solib_read_symbols): Update.
11806         * solib-spu.c (append_ocl_sos): Update.
11807         * psymtab.c (maintenance_print_psymbols)
11808         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11809         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11810         * printcmd.c (info_symbol_command): Update.
11811         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11812         Update.
11813         * objfiles.h (class all_objfiles): Remove.
11814         * objfiles.c (have_partial_symbols, have_full_symbols)
11815         (have_minimal_symbols, qsort_cmp, update_section_map)
11816         (shared_objfile_contains_address_p)
11817         (default_iterate_over_objfiles_in_search_order): Update.
11818         * objc-lang.c (info_selectors_command, info_classes_command)
11819         (find_methods): Update.
11820         * minsyms.c (find_solib_trampoline_target): Update.
11821         * maint.c (maintenance_info_sections)
11822         (maintenance_translate_address, count_symtabs_and_blocks):
11823         Update.
11824         * main.c (captured_main_1): Update.
11825         * linux-thread-db.c (try_thread_db_load_from_pdir)
11826         (has_libpthread): Update.
11827         * linespec.c (iterate_over_all_matching_symtabs)
11828         (search_minsyms_for_name): Update.
11829         * jit.c (jit_find_objf_with_entry_addr): Update.
11830         * hppa-tdep.c (find_unwind_entry)
11831         (hppa_lookup_stub_minimal_symbol): Update.
11832         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11833         Update.
11834         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11835         (elf_gnu_ifunc_resolve_by_got): Update.
11836         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11837         * dwarf-index-write.c (save_gdb_index_command): Update.
11838         * cp-support.c (add_symbol_overload_list_qualified): Update.
11839         * breakpoint.c (create_overlay_event_breakpoint)
11840         (create_longjmp_master_breakpoint)
11841         (create_std_terminate_master_breakpoint)
11842         (create_exception_master_breakpoint): Update.
11843         * blockframe.c (find_pc_partial_function): Update.
11844         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11845         (ada_collect_symbol_completion_matches)
11846         (ada_add_global_exceptions): Update.
11847
11848 2019-01-17  Tom Tromey  <tom@tromey.com>
11849
11850         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11851         declare VEC.
11852         (solib_target_parse_libraries): Change return type.
11853         (library_list_start_segment, library_list_start_section)
11854         (library_list_end_library, library_list_start_library); Update.
11855         (solib_target_free_library_list): Remove.
11856         (solib_target_parse_libraries): Remove cleanup.  Change return
11857         type.
11858         (solib_target_current_sos): Update.
11859
11860 2019-01-17  Tom Tromey  <tromey@bapiya>
11861
11862         * valprint.c: Replace "the the" with "the".
11863         * symtab.c: Replace "the the" with "the".
11864         * solib.c: Replace "the the" with "the".
11865         * solib-dsbt.c: Replace "the the" with "the".
11866         * linespec.c: Replace "the the" with "the".
11867         * dwarf2loc.h: Replace "the the" with "the".
11868         * amd64-windows-tdep.c: Replace "the the" with "the".
11869         * aarch64-tdep.c: Replace "the the" with "the".
11870
11871 2019-01-16  Keith Seitz  <keiths@redhat.com>
11872
11873         PR gdb/23773
11874         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11875         <builder>: Rename to ..
11876         <m_builder>: ... this and make private.
11877         (dwarf2_cu::get_builder): New method.  Change all users of
11878         `builder' to use this method.
11879         (dwarf2_start_symtab): Move to ...
11880         (dwarf2_cu::start_symtab): ... here.  Update all callers
11881         (setup_type_unit_groups): Move to ...
11882         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11883         callers.
11884         (dwarf2_cu::reset_builder): New method.
11885         (process_full_compunit, process_full_type_unit): Use
11886         dwarf2_cu::reset_builder.
11887         (follow_die_offset): Record the ancestor CU if it is different
11888         from the followed DIE's CU.
11889         (follow_die_sig_1): Likewise.
11890
11891 2019-01-15  Tom Tromey  <tom@tromey.com>
11892
11893         * remote.c (class remote_state) <buf>: Now a char_vector.
11894         <buf_size>: Remove.
11895         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11896         parameter.
11897         (remote_target::getpkt_or_notif_sane_1)
11898         (remote_target::getpkt_sane)
11899         (remote_target::getpkt_or_notif_sane): Likewise.
11900         (class remote_target) <putpkt>: New overload.
11901         (remote_target::read_frame): Change type of "buf_p".  Remove
11902         sizeof_p parameter.
11903         (packet_ok): New overload.
11904         (packet_check_result): New overload.
11905         Update all uses.
11906
11907 2019-01-14  Tom Tromey  <tom@tromey.com>
11908
11909         * remote-notif.c (handle_notification, remote_notif_ack)
11910         (remote_notif_parse): Make "buf" const.
11911         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11912         const.
11913         (remote_notif_parse, remote_notif_ack, handle_notification):
11914         Likewise.
11915         * remote.c (remote_notif_stop_parse): Make "buf" const.
11916         (remote_target::remote_parse_stop_reply): Make "buf" const.
11917         (remote_notif_stop_ack): Make "buf" const.
11918
11919 2019-01-14  Tom Tromey  <tom@tromey.com>
11920
11921         * remote.c (remote_console_output): Make parameter const.
11922
11923 2019-01-14  Tom Tromey  <tom@tromey.com>
11924
11925         * target-debug.h (target_debug_print_signals): Constify.
11926         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11927         * procfs.c (procfs_target::pass_signals): Update.
11928         * linux-nat.c (linux_nat_target::pass_signals): Update.
11929         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11930         * target-delegates.c: Rebuild.
11931         * remote.c (remote_target::program_signals): Update.
11932         (remote_target::pass_signals): Update.
11933         * target.c (target_pass_signals): Constify argument.
11934         (target_program_signals): Likewise.
11935         * target.h (struct target_ops) <pass_signals, program_signals>:
11936         Constify argument.
11937         (target_pass_signals, target_program_signals): Constify argument.
11938
11939 2019-01-14  Tom Tromey  <tom@tromey.com>
11940
11941         PR tui/28819:
11942         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11943
11944 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11945
11946         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11947         field.
11948         * rs6000-tdep.c: Include reggroups.h.
11949         (IS_V_ALIAS_PSEUDOREG): Define.
11950         (rs6000_register_name): Return names for the "vX" aliases.
11951         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11952         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11953         aliases.  Call default_register_reggroup_p for all other
11954         pseudo-registers.
11955         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11956         New functions.
11957         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11958         Handle "vX" aliases.
11959         (v_alias_pseudo_register_collect): New function.
11960         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11961         (rs6000_gdbarch_init): Initialize "vX" aliases as
11962         pseudo-registers.  Restore registration of
11963         rs6000_pseudo_register_reggroup_p with
11964         set_tdesc_pseudo_register_reggroup_p.
11965
11966 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11967
11968         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11969         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11970         set_gdbarch_num_pseudo_regs.
11971
11972 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11973
11974         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11975         Remove arg prefixname, add do_set and do_show.
11976         Add member functions set_list and show_list.
11977         * cli/cli-style.c (class cli_style_option): Update accordingly.
11978         (style_set_list): Move to file scope.
11979         (style_show_list): Likewise.
11980         (set_style): Call help_list.
11981         (show_style): Call cmd_show_list.
11982         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11983         Update to use the new macro.
11984
11985 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11986
11987         * ada-lang.c (_initialize_ada_language): Expand the help text
11988         for the "catch exception" command.
11989
11990 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11991
11992         * symtab.c (matching_obj_sections): Initialize obj,
11993         declare it closer to its usage.
11994
11995 2019-01-10  Tom Tromey  <tom@tromey.com>
11996
11997         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11998         (basic_inf_threads_range): Remove.
11999         (inf_threads_range, inf_non_exited_threads_range)
12000         (safe_inf_threads_range): Use next_adapter.
12001
12002 2019-01-10  Keith Seitz  <keiths@redhat.com>
12003
12004         PR gdb/23712
12005         PR symtab/23010
12006         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12007         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12008
12009 2019-01-10  Keith Seitz  <keiths@redhat.com>
12010
12011         PR gdb/23712
12012         PR symtab/23010
12013         * dictionary.c (pending_to_vector): Remove.
12014         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12015         Remove _1 suffix, replacing functions of the same name.  Update
12016         all callers.
12017         (dict_create_hashed, dict_create_hashed_expandable)
12018         (dict_create_linear, dict_create_linear_expandable, dict_free)
12019         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12020         Make functions static.
12021
12022 2019-01-10  Keith Seitz  <keiths@redhat.com>
12023
12024         PR gdb/23712
12025         PR symtab/23010
12026         * dictionary.h (struct dictionary): Replace declaration with
12027         multidictionary.
12028         (dict_create_hashed, dict_create_hashed_expandable)
12029         (dict_create_linear, dict_create_linear_expandable)
12030         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12031         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12032         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12033         taking multidictionary argument.
12034         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12035         * block.h (struct block) <dict>: Change to multidictionary
12036         and rename `multidict'.
12037         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12038         symmisc.c: Update all dictionary references to multidictionary.
12039
12040 2019-01-10  Keith Seitz  <keiths@redhat.com>
12041
12042         PR gdb/23712
12043         PR symtab/23010
12044         * dictionary.c: Include unordered_map.
12045         (pending_to_vector): New function.
12046         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12047         Rewrite the non-"_1" functions to take vector instead
12048         of linked list.
12049         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12050         "new" _1 versions of the same name.
12051         (multidictionary): Define.
12052         (std::hash<enum language): New definition.
12053         (collate_pending_symbols_by_language, mdict_create_hashed)
12054         (mdict_create_hashed_expandable, mdict_create_linear)
12055         (mdict_create_linear_expandable, mdict_free)
12056         (find_language_dictionary, create_new_language_dictionary)
12057         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12058         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12059         (mdict_size, mdict_empty): New functions.
12060         * dictionary.h (mdict_iterator): Define.
12061
12062 2019-01-10  Pedro Alves  <palves@redhat.com>
12063
12064         * breakpoint.c (read_uploaded_action)
12065         (create_tracepoint_from_upload): Adjust to use
12066         gdb::unique_xmalloc_ptr.
12067         * ctf.c (ctf_write_uploaded_tp):
12068         (SET_ARRAY_FIELD): Use emplace_back.
12069         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12070         * tracefile-tfile.c (tfile_write_uploaded_tp):
12071         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12072         gdb::unique_xmalloc_ptr.
12073         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12074         at_string, cond_string, cmd_strings>: Replace char pointers
12075         with gdb::unique_xmalloc_ptr.
12076
12077 2019-01-10  Pedro Alves  <palves@redhat.com>
12078
12079         * solib-target.c (library_list_start_library): Don't xstrdup name.
12080
12081 2019-01-10  Pedro Alves  <palves@redhat.com>
12082
12083         * mdebugread.c (parse_partial_symbols): Use
12084         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12085
12086 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12087
12088         * linux-fork.c (scoped_switch_fork_info)
12089         <~scoped_switch_fork_info>: Fix incorrect variable name.
12090
12091 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12092
12093         * linux-fork.c (scoped_switch_fork_info)
12094         <scoped_switch_fork_info>: Make explicit.
12095         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12096
12097 2019-01-10  Tom Tromey  <tom@tromey.com>
12098
12099         * objfiles.h (objfile::reset_psymtabs): Update.
12100         * objfiles.c (objfile::objfile): Update.
12101         * psymtab.h (psymtab_storage::obstack): Update.
12102         (psymtab_storage::m_obstack): Use gdb::optional.
12103         (class psymtab_storage): Update comment.  Remove objfile
12104         parameter.
12105         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12106
12107 2019-01-10  Tom Tromey  <tom@tromey.com>
12108
12109         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12110         <free_psymtabs>: Now private.
12111         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12112         (allocate_psymtab): Use new method.
12113
12114 2019-01-10  Tom Tromey  <tom@tromey.com>
12115
12116         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12117         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12118         * mdebugread.c (parse_partial_symbols): Use
12119         allocate_dependencies.
12120         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12121         allocate_dependencies.
12122         (process_psymtab_comp_unit_reader)
12123         (build_type_psymtab_dependencies): Likewise.
12124         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12125
12126 2019-01-10  Tom Tromey  <tom@tromey.com>
12127
12128         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12129         PSYMBOL_SET_LANGUAGE.
12130         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12131
12132 2019-01-10  Tom Tromey  <tom@tromey.com>
12133
12134         * psymtab.h (psymtab_storage::obstack): New method.
12135         <m_obstack>: Rename from obstack; now private.
12136         * psymtab.c (psymtab_storage): Update.
12137         * dwarf2read.c (create_addrmap_from_index)
12138         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12139         Update.
12140
12141 2019-01-10  Tom Tromey  <tom@tromey.com>
12142
12143         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12144         * objfiles.h (objfile::reset_psymtabs): New method.
12145
12146 2019-01-10  Tom Tromey  <tom@tromey.com>
12147
12148         * symmisc.c (print_symbol_bcache_statistics): Update.
12149         (print_objfile_statistics): Update.
12150         * symfile.c (reread_symbols): Update.
12151         * psymtab.h (class psymtab_storage): New.
12152         * psymtab.c (psymtab_storage): New constructor.
12153         (~psymtab_storage): New destructor.
12154         (require_partial_symbols): Update.
12155         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12156         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12157         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12158         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12159         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12160         (start_psymtab_common, end_psymtab_common)
12161         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12162         (allocate_psymtab): Update.
12163         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12164         Update.
12165         (dump_psymtab_addrmap, maintenance_print_psymbols)
12166         (maintenance_check_psymtabs): Update.
12167         (class objfile_psymtabs): Move to objfiles.h.
12168         * psympriv.h (discard_psymtab): Now inline.
12169         (psymtab_discarder::psymtab_discarder): Update.
12170         (psymtab_discarder::~psymtab_discarder): Update.
12171         (ALL_OBJFILE_PSYMTABS): Rewrite.
12172         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12173         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12174         Remove fields.
12175         <partial_symtabs>: New field.
12176         (class objfile_psymtabs): Move from psymtab.h.  Update.
12177         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12178         psymbol_cache.
12179         (objfile::~objfile): Don't destroy psymbol_cache.
12180         * mdebugread.c (parse_partial_symbols): Update.
12181         * dwarf2read.c (create_addrmap_from_index)
12182         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12183         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12184         (add_partial_subprogram, dwarf2_ranges_read): Update.
12185         * dwarf-index-write.c (write_address_map)
12186         (write_one_signatured_type, recursively_write_psymbols)
12187         (class debug_names, class debug_names, write_psymtabs_to_index):
12188         Update.
12189
12190 2019-01-10  Tom Tromey  <tom@tromey.com>
12191
12192         * symtab.h (SYMBOL_SET_NAMES): Update.
12193         (symbol_set_names): Update.
12194         (MSYMBOL_SET_NAMES): Update.
12195         * symtab.c (symbol_set_names): Change argument to be an
12196         objfile_per_bfd_storage.
12197         * psymtab.c (add_psymbol_to_bcache): Update.
12198         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12199
12200 2019-01-10  Tom Tromey  <tom@tromey.com>
12201
12202         * symtab.c (create_demangled_names_hash): Change argument to be an
12203         objfile_per_bfd_storage.
12204         (symbol_set_names): Update.
12205
12206 2019-01-10  Tom Tromey  <tom@tromey.com>
12207
12208         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12209         init_psymbol_list.
12210         * psymtab.c (init_psymbol_list): Do nothing if already called.
12211         * psympriv.h (init_psymbol_list): Add comment.
12212         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12213         init_psymbol_list.
12214         * dbxread.c (dbx_symfile_read): Unconditionally call
12215         init_psymbol_list.
12216
12217 2019-01-10  Tom Tromey  <tom@tromey.com>
12218
12219         * xcoffread.c (scan_xcoff_symtab): Update.
12220         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12221         "where".
12222         * mdebugread.c (parse_partial_symbols)
12223         (handle_psymbol_enumerators): Update.
12224         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12225         * dbxread.c (read_dbx_symtab): Update.
12226         * psympriv.h (psymbol_placement): New enum.
12227         (add_psymbol_to_list): Update.
12228
12229 2019-01-10  Tom Tromey  <tom@tromey.com>
12230
12231         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12232         static_psymbols parameters.
12233         (scan_xcoff_symtab): Update.
12234         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12235         static_psymbols parameters.
12236         * psympriv.h (start_psymtab_common): Update.
12237         * mdebugread.c (parse_partial_symbols): Update.
12238         * dwarf2read.c (create_partial_symtab): Update.
12239         * dbxread.c (read_dbx_symtab): Update.
12240         (start_psymtab): Remove global_psymbols and static_psymbols
12241         parameters.
12242
12243 2019-01-10  Tom Tromey  <tom@tromey.com>
12244
12245         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12246         * psymtab.c (allocate_psymtab): Add comment.
12247         * psympriv.h (allocate_psymtab): Add comment.
12248         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12249         initializations.
12250         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12251
12252 2019-01-10  Tom Tromey  <tom@tromey.com>
12253
12254         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12255         Don't declare.
12256         * mipsread.c: Include mdebugread.h.
12257         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12258         Declare.
12259         * elfread.c: Include mdebugread.h.
12260
12261 2019-01-09  Tom Tromey  <tom@tromey.com>
12262
12263         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12264         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12265         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12266         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12267         (psym_lookup_symbol, psym_find_last_source_symtab)
12268         (psym_forget_cached_source_info, psym_print_stats)
12269         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12270         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12271         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12272         (psym_find_compunit_symtab_by_address)
12273         (maintenance_print_psymbols, maintenance_info_psymtabs)
12274         (maintenance_check_psymtabs): Use ranged for.
12275         * psymtab.h (class objfile_psymtabs): New.
12276         (require_partial_symbols): Return objfile_psymtabs.
12277         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12278
12279 2019-01-09  Tom Tromey  <tom@tromey.com>
12280
12281         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12282         (find_pc_mapped_section, list_overlays_command)
12283         (map_overlay_command, unmap_overlay_command)
12284         (simple_overlay_update): Use all_objfiles.
12285         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12286         * printcmd.c (info_symbol_command): Use all_objfiles.
12287         * objfiles.h (ALL_OBJSECTIONS): Remove.
12288         * maint.c (maintenance_translate_address): Use all_objfiles.
12289         * gcore.c (gcore_create_callback): Use all_objfiles.
12290         (objfile_find_memory_regions): Likewise.
12291
12292 2019-01-09  Tom Tromey  <tom@tromey.com>
12293
12294         * symtab.c (find_line_symtab, info_sources_command)
12295         (make_source_files_completion_list): Use objfile_compunits.
12296         * source.c (select_source_symtab): Use objfile_compunits.
12297         * objfiles.h (struct objfile): Update comment.
12298         (ALL_OBJFILES): Remove.
12299         (ALL_FILETABS): Remove.
12300         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12301         objfile_compunits.
12302
12303 2019-01-09  Tom Tromey  <tom@tromey.com>
12304
12305         * symmisc.c (print_objfile_statistics, dump_objfile)
12306         (maintenance_print_symbols): Use compunit_filetabs.
12307         * source.c (forget_cached_source_info_for_objfile): Use
12308         compunit_filetabs.
12309         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12310         (ALL_FILETABS): Use compunit_filetabs.
12311         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12312         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12313
12314 2019-01-09  Tom Tromey  <tom@tromey.com>
12315
12316         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12317         (compunit_filetabs): New.
12318         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12319         compunit_filetabs.
12320         (info_sources_command, make_source_files_completion_list): Remove
12321         declaration.
12322         * symmisc.c (print_objfile_statistics, dump_objfile)
12323         (maintenance_print_symbols): Remove declaration.
12324         (maintenance_info_symtabs): Use compunit_filetabs.
12325         (maintenance_info_line_tables): Likewise.
12326         * source.c (select_source_symtab): Change local variable name.
12327         (forget_cached_source_info_for_objfile): Remove declaration.
12328         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12329         * objfiles.c (objfile_relocate1): Remove declaration.
12330         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12331         declaration.
12332         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12333         * coffread.c (coff_symtab_read): Remove declaration.
12334         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12335         compunit_filetabs.
12336
12337 2019-01-09  Tom Tromey  <tom@tromey.com>
12338
12339         * symtab.c (lookup_objfile_from_block)
12340         (find_pc_sect_compunit_symtab, search_symbols)
12341         (default_collect_symbol_completion_matches_break_on): Use
12342         objfile_compunits.
12343         * objfiles.h (ALL_COMPUNITS): Remove.
12344         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12345         * cp-support.c (add_symbol_overload_list_qualified): Use
12346         objfile_compunits.
12347         * ada-lang.c (ada_collect_symbol_completion_matches)
12348         (ada_add_global_exceptions): Use objfile_compunits.
12349
12350 2019-01-09  Tom Tromey  <tom@tromey.com>
12351
12352         * source.c (select_source_symtab)
12353         (forget_cached_source_info_for_objfile): Remove declaration.
12354         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12355         declaration.
12356         * maint.c (count_symtabs_and_blocks): Remove declaration.
12357         * cp-support.c (add_symbol_overload_list_qualified): Remove
12358         declaration.
12359         * coffread.c (coff_symtab_read): Remove declaration.
12360         * symtab.c (lookup_symbol_in_objfile_symtabs)
12361         (basic_lookup_transparent_type_1): Use objfile_compunits.
12362         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12363         (info_sources_command, search_symbols)
12364         (default_collect_symbol_completion_matches_break_on)
12365         (make_source_files_completion_list): Remove declaration.
12366         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12367         (ada_collect_symbol_completion_matches)
12368         (ada_add_global_exceptions): Remove declaration.
12369         * linespec.c (iterate_over_all_matching_symtabs): Use
12370         objfile_compunits.
12371         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12372         (class objfile_compunits): New.
12373         (ALL_COMPUNITS): Use objfile_compunits.
12374         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12375         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12376         objfile_compunits.
12377         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12378
12379 2019-01-09  Tom Tromey  <tom@tromey.com>
12380
12381         * symtab.c (search_symbols)
12382         (default_collect_symbol_completion_matches_break_on): Use
12383         objfile_msymbols.
12384         * ada-lang.c (ada_lookup_simple_minsym)
12385         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12386         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12387         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12388         objfile_msymbols.
12389         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12390         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12391         * objc-lang.c (find_methods): Use objfile_msymbols.
12392         (info_selectors_command, info_classes_command): Likewise.
12393         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12394         * objfiles.h (class objfile_msymbols): New.
12395         (ALL_OBJFILE_MSYMBOLS): Remove.
12396         (ALL_MSYMBOLS): Remove.
12397
12398 2019-01-09  Tom Tromey  <tom@tromey.com>
12399
12400         * common/next-iterator.h (next_adapter): Add Iterator template
12401         parameter.
12402         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12403         (class all_objfiles_safe): New.
12404         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12405         * objfiles.c (put_objfile_before): Update comment.
12406         (add_separate_debug_objfile): Likewise.
12407         (free_all_objfiles): Use all_objfiles_safe.
12408         (objfile_purge_solibs): Likewise.
12409
12410 2019-01-09  Tom Tromey  <tom@tromey.com>
12411
12412         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12413         (expand_symtab_containing_pc, lookup_static_symbol)
12414         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12415         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12416         all_objfiles.
12417         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12418         * breakpoint.c (create_overlay_event_breakpoint)
12419         (create_longjmp_master_breakpoint)
12420         (create_std_terminate_master_breakpoint)
12421         (create_exception_master_breakpoint): Use all_objfiles.
12422         * linux-thread-db.c (try_thread_db_load_from_pdir)
12423         (has_libpthread): Use all_objfiles.
12424         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12425         * linespec.c (iterate_over_all_matching_symtabs)
12426         (search_minsyms_for_name): Use all_objfiles.
12427         * maint.c (maintenance_info_sections): Use all_objfiles.
12428         * main.c (captured_main_1): Use all_objfiles.
12429         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12430         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12431         * guile/scm-pretty-print.c
12432         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12433         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12434         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12435         (maintenance_print_msymbols): Use all_objfiles.
12436         * source.c (select_source_symtab): Use all_objfiles.
12437         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12438         * symfile.c (remove_symbol_file_command)
12439         (expand_symtabs_matching, map_symbol_filenames): Use
12440         all_objfiles.
12441         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12442         all_objfiles.
12443         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12444         * objc-lang.c (find_methods): Use all_objfiles.
12445         * objfiles.c (have_partial_symbols, have_full_symbols)
12446         (have_minimal_symbols, qsort_cmp)
12447         (default_iterate_over_objfiles_in_search_order): Use
12448         all_objfiles.
12449         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12450         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12451         (maintenance_check_psymtabs): Use all_objfiles.
12452         (ALL_PSYMTABS): Remove.
12453         * compile/compile-object-run.c (do_module_cleanup): Use
12454         all_objfiles.
12455         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12456         * cp-support.c (add_symbol_overload_list_qualified): Use
12457         all_objfiles.
12458         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12459         Use all_objfiles.
12460         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12461         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12462         all_objfiles.
12463         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12464         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12465         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12466         Uses all_objfiles.
12467         * solib.c (solib_read_symbols): Use all_objfiles
12468
12469 2019-01-09  Tom Tromey  <tom@tromey.com>
12470
12471         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12472         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12473         all_objfiles.
12474         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12475         * symmisc.c (print_symbol_bcache_statistics)
12476         (print_objfile_statistics, maintenance_print_objfiles)
12477         (maintenance_info_symtabs, maintenance_check_symtabs)
12478         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12479         all_objfiles.
12480         * source.c (forget_cached_source_info): Use all_objfiles.
12481         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12482         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12483         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12484         * objfiles.c (update_section_map): Use all_objfiles.
12485         (shared_objfile_contains_address_p): Likewise.
12486         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12487         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12488
12489 2019-01-09  Tom Tromey  <tom@tromey.com>
12490
12491         * common/next-iterator.h: New file.
12492         * objfiles.h (class all_objfiles): New.
12493         (struct objfile_iterator): New.
12494
12495 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12496
12497         * NEWS: Move the description of the changed "frame", "select-frame",
12498          and "info frame" commands to the Changed commands section.
12499
12500 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12501
12502         * gdbtypes.c (check_stub_method_group): Remove handling of old
12503         mangling schemes.
12504         * linespec.c (find_methods): Likewise.
12505         * stabsread.c (read_member_functions): Likewise.
12506         * valops.c (search_struct_method): Likewise.
12507         (value_struct_elt_for_reference): Likewise.
12508         * NEWS: Mention this change.
12509
12510 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12511
12512         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12513         print_source_lines.
12514         * source.c (print_source_lines_base): Update line number check.
12515         (print_source_lines): New function.
12516         (source_lines_range::source_lines_range): New function.
12517         * source.h (class source_lines_range): New class.
12518         (print_source_lines): New declaration.
12519
12520 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12521
12522         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12523
12524 2019-01-08  Tom Tromey  <tom@tromey.com>
12525             Simon Marchi  <simon.marchi@ericsson.com>
12526
12527         PR gdb/24060
12528         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12529         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12530         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12531         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12532         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12533         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12534
12535 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12536
12537         * source.c (select_source_symtab): Move header comment to
12538         declaration in source.h.
12539         (forget_cached_source_info_for_objfile): Likewise.
12540         (forget_cached_source_info): Likewise.
12541         (identify_source_line): Likewise.
12542         * source.h (identify_source_line): Move declaration from symtab.h
12543         and add comment from source.c
12544         (print_source_lines): Likewise.
12545         (forget_cached_source_info_for_objfile): Likewise.
12546         (forget_cached_source_info): Likewise.
12547         (select_source_symtab): Likewise.
12548         (enum print_source_lines_flag): Move definition from symtab.h.
12549         * symtab.h (identify_source_line): Move declaration to source.h.
12550         (print_source_lines): Likewise.
12551         (forget_cached_source_info_for_objfile): Likewise.
12552         (forget_cached_source_info): Likewise.
12553         (select_source_symtab): Likewise.
12554         (enum print_source_lines_flag): Move definition to source.h.
12555         * tui/tui-hooks.c: Add 'source.h' include.
12556
12557 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12558
12559         * source.c (print_source_lines_base): Handle requests to print
12560         reverse line number sequences, and guard against empty lines
12561         string.
12562
12563 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12564
12565         * source.c (print_source_lines_base): Fix skip of '\r' if next
12566         character is '\n'.
12567
12568 2019-01-06  Tom Tromey  <tom@tromey.com>
12569
12570         * c-exp.y (struct c_parse_state) <macro_original_text,
12571         expansion_obstack>: New member.
12572         (macro_original_text, expansion_obstack): Remove globals.
12573         (scan_macro_expansion, scanning_macro_expansion)
12574         (finished_macro_expansion): Update.
12575         (scan_macro_cleanup): Remove.
12576         (yylex, c_parse): Update.
12577
12578 2019-01-06  Tom Tromey  <tom@tromey.com>
12579
12580         * c-exp.y (struct c_parse_state) <strings>: New member.
12581         (operator_stoken): Update.
12582
12583 2019-01-06  Tom Tromey  <tom@tromey.com>
12584
12585         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12586         (union type_stack_elt) <typelist_val>: Now a pointer to
12587         std::vector.
12588         (type_stack_cleanup): Don't declare.
12589         (push_typelist): Update.
12590         * parse.c (pop_typelist): Return a std::vector.
12591         (push_typelist): Take a std::vector.
12592         (follow_types): Update.  Do not free args.
12593         (type_stack_cleanup): Remove.
12594         * c-exp.y (struct c_parse_state): New.
12595         (cpstate): New global.
12596         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12597         (nonempty_typelist): Update.
12598         (func_mod): Create a new vector.
12599         (c_parse): Create a c_parse_state.
12600         (check_parameter_typelist): Do not delete params.
12601         (function_method): Update.  Do not delete type_list.
12602
12603 2019-01-06  Tom Tromey  <tom@tromey.com>
12604
12605         PR gdb/28155:
12606         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12607         check_typedef.
12608         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12609         (print_return_value): Likewise.
12610
12611 2019-01-05  Tom Tromey  <tom@tromey.com>
12612
12613         * contrib/cleanup_check.py: Remove.
12614         * contrib/gcc-with-excheck: Remove.
12615         * contrib/exsummary.py: Remove.
12616         * contrib/excheck.py: Remove.
12617
12618 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12619
12620         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12621         NULL. Initialize tpprev to NULL instead of assigning it
12622         to NULL on the next statement.
12623         * windows-nat.c (windows_delete_thread): Remove check for
12624         main_thread_id before printing thread exit notifications.
12625         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12626         Remove thread ID check against main_thread_id.
12627         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12628         windows_delete_thread.
12629         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12630
12631 2019-01-04  Tom Tromey  <tom@tromey.com>
12632
12633         * compile/compile.c (_initialize_compile): Use upper case for
12634         metasyntactic variables.
12635         * symmisc.c (_initialize_symmisc): Use upper case for
12636         metasyntactic variables.
12637         * psymtab.c (_initialize_psymtab): Use upper case for
12638         metasyntactic variables.
12639         * demangle.c (demangle_command): Use upper case for metasyntactic
12640         variables.
12641         (_initialize_demangler): Likewise.
12642         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12643         variables.
12644
12645 2019-01-03  Tom Tromey  <tom@tromey.com>
12646
12647         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12648
12649 2019-01-03  Tom Tromey  <tom@tromey.com>
12650
12651         * python/py-symtab.c (salpy_str): Update.
12652         (struct salpy_sal_object) <symtab>: Now a PyObject.
12653         (salpy_dealloc): Update.
12654         (del_objfile_sal): Use gdbpy_ref.
12655
12656 2019-01-03  Tom Tromey  <tom@tromey.com>
12657
12658         * python/py-type.c (convert_field): Use new_reference.  Return
12659         gdbpy_ref.
12660         (make_fielditem): Return gdbpy_ref.
12661         (typy_fields): Update.
12662         (typy_getitem): Update.
12663         (field_name): Return gdbpy_ref.  Use new_reference.
12664         (typy_iterator_iternext): Update.
12665
12666 2019-01-03  Tom Tromey  <tom@tromey.com>
12667
12668         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12669
12670 2019-01-03  Tom Tromey  <tom@tromey.com>
12671
12672         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12673         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12674         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12675         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12676         (pspy_set_type_printers): Likewise.
12677         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12678         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12679         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12680         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12681         (objfpy_set_type_printers): Likewise.
12682
12683 2019-01-03  Tom Tromey  <tom@tromey.com>
12684
12685         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12686         (gdbpy_print_stack): Use gdbpy_err_fetch.
12687         * python/python-internal.h (class gdbpy_err_fetch): New class.
12688         (class gdbpy_enter) <m_error_type, m_error_value,
12689         m_error_traceback>: Remove.
12690         <m_error>: New member.
12691         (gdbpy_exception_to_string): Don't declare.
12692         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12693         * python/py-value.c (convert_value_from_python): Use
12694         gdbpy_err_fetch.
12695         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12696         gdbpy_exception_to_string.
12697         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12698         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12699         gdbpy_err_fetch.
12700
12701 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12702
12703         * linux-nat.c (delete_lwp_cleanup): Delete.
12704         (struct lwp_deleter): New struct.
12705         (lwp_info_up): New typedef.
12706         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12707         lwp_info_up.
12708
12709 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12710
12711         * linux-fork.c (class scoped_switch_fork_info): New class.
12712         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12713
12714 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12715
12716         * valops.c (find_overload_match): Remove use of null_cleanup, and
12717         calls to do_cleanups.
12718
12719 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12720
12721         * compile/compile-cplus-types.c
12722         (compile_cplus_instance::decl_name): Handle changes to
12723         cp_func_name.
12724         * cp-support.c (cp_func_name): Update header comment, update
12725         return type.
12726         * cp-support.h (cp_func_name): Update return type in declaration.
12727         * valops.c (find_overload_match): Move temp_func local to top
12728         level of function and change its type.  Use temp_func to hold and
12729         delete temporary string obtained from cp_func_name.
12730
12731 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12732
12733         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12734         gdb::char_vector, remove cleanup, and update uses of `msg`.
12735
12736 2019-01-03  Jim Wilson  <jimw@sifive.com>
12737
12738         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12739
12740 2019-01-02  Tom Tromey  <tom@tromey.com>
12741
12742         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12743         (tdesc_parse_xml): Remove cleanups.
12744         * target-descriptions.h (make_cleanup_free_target_description):
12745         Don't declare.
12746         (target_desc_deleter): New struct.
12747         (target_desc_up): New typedef.
12748         * target-descriptions.c (target_desc_deleter::operator()): Rename
12749         from free_target_description.
12750         (make_cleanup_free_target_description): Remove.
12751
12752 2019-01-02  Tom Tromey  <tom@tromey.com>
12753
12754         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12755         constructor, destructor.
12756         (linespec_parser): Remove typedef.
12757         (~linespec_parser): Rename from linespec_parser_delete.
12758         (linespec_lex_to_end, linespec_complete_label)
12759         (linespec_complete): Update.
12760         (decode_line_full): Remove cleanups.
12761         (decode_line_1): Update.
12762
12763 2019-01-02  Tom Tromey  <tom@tromey.com>
12764
12765         * python/python-internal.h (inferior_to_inferior_object): Change
12766         return type.
12767         * python/py-exitedevent.c (create_exited_event_object): Update.
12768         * python/py-inferior.c (inferior_to_inferior_object): Return
12769         gdbpy_ref.
12770         (python_new_inferior, python_inferior_deleted)
12771         (thread_to_thread_object, delete_thread_object)
12772         (build_inferior_list, gdbpy_selected_inferior): Update.
12773         * python/py-infthread.c (create_thread_object): Update.  Also fail
12774         if inferior_to_inferior_object fails.
12775
12776 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12777
12778         * inferior.h (class inferior) <displaced_step_state>: New field.
12779         * infrun.h (struct displaced_step_state): Move here from
12780         infrun.c.  Initialize fields, add constructor.
12781         <inf>: Remove field.
12782         <reset>: New method.
12783         * infrun.c (struct displaced_step_inferior_state): Move to
12784         infrun.h.
12785         (displaced_step_inferior_states): Remove.
12786         (get_displaced_stepping_state): Adust.
12787         (displaced_step_in_progress_any_inferior): Adjust.
12788         (displaced_step_in_progress_thread): Adjust.
12789         (displaced_step_in_progress): Adjust.
12790         (add_displaced_stepping_state): Remove.
12791         (get_displaced_step_closure_by_addr): Adjust.
12792         (remove_displaced_stepping_state): Remove.
12793         (infrun_inferior_exit): Call displaced_step_state.reset.
12794         (use_displaced_stepping): Don't check for NULL.
12795         (displaced_step_prepare_throw): Call
12796         get_displaced_stepping_state.
12797         (displaced_step_fixup): Don't check for NULL.
12798         (prepare_for_detach): Don't check for NULL.
12799
12800 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12801
12802         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12803          in case of call that did not complete.
12804
12805 2019-01-02  Andrey Utkin  <autkin@undo.io>
12806
12807         * symfile.c (find_separate_debug_file): Fix search of debug files for
12808         remote debuggee.
12809
12810 2019-01-02  Tom Tromey  <tom@tromey.com>
12811
12812         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12813         indentation.
12814         * python/py-frame.c (frapy_older): Remove cast.
12815         (frapy_newer): Likewise.
12816         * python/py-breakpoint.c (local_setattro): Remove cast.
12817         * python/py-arch.c (archpy_name): Remove local variable.
12818         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12819
12820 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12821
12822         * unittests/basic_string_view/element_access/char/empty.cc:
12823         Fix year range in copyright header.
12824
12825 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12826
12827         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12828         Delete.
12829         <operator==>: Update with for removed field.
12830         <hash>: Likewise.
12831         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12832         <isa_features>: ...this.
12833         <abi_features>: New field.
12834         (riscv_isa_flen): Update comment.
12835         (riscv_abi_xlen): New declaration.
12836         (riscv_abi_flen): New declaration.
12837         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12838         isa_features.
12839         (riscv_abi_xlen): New function.
12840         (riscv_isa_flen): Update to get answer from isa_features.
12841         (riscv_abi_flen): New function.
12842         (riscv_has_fp_abi): Update to get answer from abi_features.
12843         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12844         xlen and flen.
12845         (riscv_call_info) <xlen, flen>: Update comment.
12846         (riscv_call_arg_struct): Remove invalid assertions
12847         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12848         is removed.
12849         (riscv_gdbarch_init): Gather isa features and abi features
12850         separately, ensure both match on the gdbarch when reusing an old
12851         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12852         a target with 64-bit float hardware.
12853
12854 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12855
12856         * source.c (search_command_helper): Stop reverse search
12857         when line 1 has been searched.
12858
12859 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12860
12861         * record-full.c (record_full_base_target::close): Rewrite
12862         record_full_core_buf_list free logic.
12863
12864 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12865
12866         * break-catch-syscall.c (print_one_catch_syscall): xfree
12867         the last text.
12868
12869 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12870
12871         * top.c (print_gdb_version): Update Copyright year in version
12872         message.
12873
12874 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12875
12876         Update copyright year range in all GDB files.
12877
12878 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12879
12880         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12881
12882 For older changes see ChangeLog-2018.
12883 \f
12884 Local Variables:
12885 mode: change-log
12886 left-margin: 8
12887 fill-column: 74
12888 version-control: never
12889 coding: utf-8
12890 End:
12891